Minor doc fixes. Remove duplicate ChangeLog entries.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
75bfc667
JL
12011-08-07 Juri Linkov <juri@jurta.org>
2
3 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4 to show the arg `TIME' instead of `TIMEVAL'.
5
d1410150
EZ
62011-08-06 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9 display property strides EOL and includes a newline, as in
10 longlines-mode. (Bug#9254)
75b771e4
EZ
11 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
12 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
13
14 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
15 is non-zero, even if the data buffer is NULL. Fixes a crash in
16 vertical-motion with longlines-mode. (Bug#9254)
17
35928349
EZ
182011-08-05 Eli Zaretskii <eliz@gnu.org>
19
ec7cc85b
EZ
20 * bidi.c <bidi_cache_total_alloc>: Now static.
21 (bidi_initialize): Initialize bidi_cache_total_alloc.
22
35928349
EZ
23 *xdisp.c (display_line): Release buffer allocated for shelved bidi
24 cache. (Bug#9221)
25
26 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
27 amount allocated this far in `bidi_cache_total_alloc'.
28 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
29 non-zero, only free the data buffer without restoring the cache
30 contents. All callers changed.
31
32 * dispextern.h (bidi_unshelve_cache): Update prototype.
33
34 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
35 (move_it_in_display_line, move_it_to)
36 (move_it_vertically_backward, move_it_by_lines): Replace the call
37 to xfree to an equivalent call to bidi_unshelve_cache.
38 (move_it_in_display_line_to): Fix logic of returning
412b6358 39 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 40
e2e2423b
EZ
412011-08-05 Eli Zaretskii <eliz@gnu.org>
42
43 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
44 came from a string character with a `cursor' property. (Bug#9229)
45
ae9e757a
JD
462011-08-04 Jan Djärv <jan.h.d@swipnet.se>
47
48 * Makefile.in (LIB_PTHREAD): New variable.
49 (LIBES): Add LIB_PTHREAD (Bug#9216).
50
51 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
52 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
53
213bd7f2
AS
542011-08-04 Andreas Schwab <schwab@linux-m68k.org>
55
56 * regex.c (re_iswctype): Remove some redundant boolean
57 conversions.
58
99aaf75f
JD
592011-08-04 Jan Djärv <jan.h.d@swipnet.se>
60
61 * xterm.c (x_find_topmost_parent): New function.
62 (x_set_frame_alpha): Find topmost parent window with
63 x_find_topmost_parent and set the property there also (bug#9181).
64 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
65
c74e9d86
PE
662011-08-04 Paul Eggert <eggert@cs.ucla.edu>
67
68 * callproc.c (Fcall_process): Avoid vfork clobbering
69 the local vars buffer, coding_systems, current_dir.
70
640c8776
SM
712011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
72
73 * keymap.c (Fmake_composed_keymap): Move to subr.el.
74
f26d0e4c
PE
752011-08-03 Paul Eggert <eggert@cs.ucla.edu>
76
8a10d76c
PE
77 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
78 so that it is not optimized away.
79
f26d0e4c
PE
80 * xdisp.c (compute_display_string_pos): Remove unused local.
81
55439c61
EZ
822011-08-02 Eli Zaretskii <eliz@gnu.org>
83
84 Fix slow cursor motion and scrolling in large buffers with
85 selective display, like Org Mode buffers. (Bug#9218)
86
87 * dispextern.h (struct bidi_it): New member disp_prop_p.
88
89 * xdisp.c: Remove one-slot cache of display string positions.
90 (compute_display_string_pos): Accept an additional argument
91 DISP_PROP_P; callers changed. Scan at most 5K characters forward
92 for a display string or property. If found, set DISP_PROP_P
93 non-zero.
94
95 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
96 DISP_PROP_P, and pass it to compute_display_string_pos.
97 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
98 non-zero. All callers of bidi_fetch_char changed.
99
fb33fa43
SM
1002011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
101
102 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
103
b099e063
DM
1042010-12-03 Don March <don@ohspite.net>
105
106 * keymap.c (Fdefine_key): Fix non-prefix key error message when
107 last character M-[char] is translated to ESC [char] (bug#7541).
108
5cc7f7af
KH
1092011-08-02 Kenichi Handa <handa@m17n.org>
110
d0fffa3f 111 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
112
113 * chartab.c (uniprop_table): Make it non-static.
114
525d5e6e
EZ
1152011-08-01 Eli Zaretskii <eliz@gnu.org>
116
117 * xdisp.c (forward_to_next_line_start): Accept additional argument
118 BIDI_IT_PREV, and store into it the state of the bidi iterator had
119 on the newline.
120 (reseat_at_next_visible_line_start): Use the bidi iterator state
121 returned by forward_to_next_line_start to restore the state of
122 it->bidi_it after backing up to previous newline. (Bug#9212)
123
31011111
AS
1242011-07-30 Andreas Schwab <schwab@linux-m68k.org>
125
126 * regex.c (re_comp): Protoize.
127 (re_exec): Fix return type.
128 (regexec): Fix type of `ret'. (Bug#9203)
129
e5d76069
PE
1302011-07-29 Paul Eggert <eggert@cs.ucla.edu>
131
132 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
133 This is needed if max-image-size is a floating-point number.
134
9a79b20c
AS
1352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
136
137 * print.c (print_object): Print empty symbol as ##.
138
139 * lread.c (read1): Read ## as empty symbol.
140
d8c2fa78
AA
1412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
142
143 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
144 setting frame foreground color (Bug#9175).
145 (x_set_background_color): Likewise.
146
ffe57a7a
AA
147 * nsmenu.m (-setText): Size tooltip dimensions precisely to
148 contents (Bug#9176).
149 (EmacsTooltip -init): Remove bezels and add shadows to
150 tooltip windows.
151
bf3492a5
AA
152 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
153 or scroll bar (Bug#8470).
154
d55e9c53
AA
155 * nsfont.m (nsfont_open): Remove assignment to voffset and
156 unnecessary vars hshink, expand, hd, full_height, min_height.
157 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
158
159 * nsterm.h (nsfont_info): Remove voffset field.
160
d8c2fa78 1612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
162
163 Implement strike-through and overline on NextStep (Bug#8863).
164
165 * nsfont.m (nsfont_open): Use underline position provided by font,
166 instead of hard-coded value of 2.
167 (nsfont_draw): Call ns_draw_text_decoration instead.
168
169 * nsterm.h: Add declaration for ns_draw_text_decoration.
170
171 * nsterm.m (ns_draw_text_decoration): New function for drawing
172 underline, overline, and strike-through.
173 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
174 ns_draw_text_decoration. Change treatment of cursor drawing to
175 accomodate underlining, etc.
176
4cc60b9b
EZ
1772011-07-28 Eli Zaretskii <eliz@gnu.org>
178
bc7ece87
EZ
179 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
180 default.
4cc60b9b 181
476371c4
PE
1822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
183
66606eea
PE
184 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
185 Without this fix, if a signal arrives just after memory fills up,
186 'malloc' might be invoked reentrantly.
187
476371c4
PE
188 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
189 In other words, assume that every image size is allowed, on non-X
190 hosts. This assumption is probably wrong, but it lets Emacs compile.
191
f3fcc40d
AS
1922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
193
194 * regex.c (re_iswctype): Convert return values to boolean.
195
350c992f
EZ
1962011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
197
198 * xdisp.c (compute_display_string_pos): Don't use cached display
199 string position if the buffer had its restriction changed.
200 (Bug#9184)
201
5266b4bb
PE
2022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
203
204 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
205
2573a837 2062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 207
41f55ccd 208 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 209
39e378da
PE
210 * bidi.c: Integer size and overflow fixes.
211 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
212 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
213 (bidi_cache_find_level_change, bidi_cache_ensure_space)
214 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
215 (bidi_find_other_level_edge):
216 Use ptrdiff_t instead of EMACS_INT where either will do.
217 This works better on 32-bit hosts configured --with-wide-int.
218 (bidi_cache_ensure_space): Check for size-calculation overflow.
219 Use % rather than repeated addition, for better worst-case speed.
220 Don't set bidi_cache_size until after xrealloc returns, because it
221 might not return.
222 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
223 (bidi_cache_ensure_space): Also check that the bidi cache size
224 does not exceed that of the largest Lisp string or buffer. See Eli
225 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 226
5e927815
PE
227 * alloc.c (__malloc_size_t): Remove.
228 All uses replaced by size_t. See Andreas Schwab's note
229 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
230
ca4aa935
PE
231 * image.c: Improve checking for integer overflow.
232 (check_image_size): Assume that f is nonnull, since
233 it is always nonnull in practice. This is one less thing to
234 worry about when checking for integer overflow later.
235 (x_check_image_size): New function, which checks for integer
236 overflow issues inside X.
237 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
238 This removes the need for a memory_full check.
239 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
240 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
241 (xbm_read_bitmap_data): Change locals back to 'int', since
242 their values must fit in 'int'.
243 (xpm_load_image, png_load, tiff_load):
244 Invoke x_create_x_image_and_pixmap earlier,
245 to avoid much needless work if the image is too large.
246 (tiff_load): Treat overly large images as if
247 x_create_x_image_and_pixmap failed, not as malloc failures.
248 (gs_load): Use x_check_image_size.
249
5f8f9cc2
PE
250 * gtkutil.c: Omit integer casts.
251 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
252 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
253
5adf60bc
PE
254 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
255
c8907a93
PE
256 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
257 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
258 would wrongly return t on a 64-bit host.
259
e3c25c68
PE
260 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
261 The plain *_OVERFLOW macros run afoul of GCC bug 49705
262 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
263 and therefore cause GCC to emit a bogus diagnostic in some cases.
264
3f791afe
PE
265 * image.c: Integer signedness and overflow and related fixes.
266 This is not an exhaustive set of fixes, but it's time to
267 record what I've got.
268 (lookup_pixel_color, check_image_size): Remove redundant decls.
269 (check_image_size): Don't assume that arbitrary EMACS_INT values
270 fit in 'int', or that arbitrary 'double' values fit in 'int'.
271 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
272 (tiff_load, imagemagick_load_image):
273 Check for overflow in size calculations.
274 (x_create_x_image_and_pixmap): Remove unnecessary test for
275 xmalloc returning NULL; that can't happen.
276 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
277 (xpm_color_bucket): Use better integer hashing function.
278 (xpm_cache_color): Don't possibly over-allocate memory.
279 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
280 (gif_memory_source):
281 Use ptrdiff_t, not int or size_t, to record sizes.
282 (png_load): Don't assume values greater than 2**31 fit in 'int'.
283 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
284 either works, as we prefer signed integers.
285 (tiff_read_from_memory, tiff_write_from_memory):
286 Return tsize_t, not size_t, since that's what the TIFF API wants.
287 (tiff_read_from_memory): Don't fail simply because the read would
288 go past EOF; instead, return a short read.
289 (tiff_load): Omit no-longer-needed casts.
290 (Fimagemagick_types): Don't assume size fits into 'int'.
291
3cc5a532
PE
292 Improve hashing quality when configured --with-wide-int.
293 * fns.c (hash_string): New function, taken from sxhash_string.
294 Do not discard information about ASCII character case; this
295 discarding is no longer needed.
296 (sxhash-string): Use it. Change sig to match it. Caller changed.
297 * lisp.h: Declare it.
298 * lread.c (hash_string): Remove, since we now use fns.c's version.
299 The fns.c version returns a wider integer if --with-wide-int is
300 specified, so this should help the quality of the hashing a bit.
301
b312a492
PE
302 * emacs.c: Integer overflow minor fix.
303 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
304 Define only if GNU_LINUX.
305 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
306
dfd153ae
PE
307 * dispnew.c: Integer signedness and overflow fixes.
308 Remove unnecessary forward decls, that were a maintenance hassle.
309 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
310 All uses changed.
311 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
312 (scrolling_window): Use ptrdiff_t, not int, for byte count.
313 (prepare_desired_row, line_draw_cost):
314 Use int, not unsigned, where either works.
315 (save_current_matrix, restore_current_matrix):
316 Use ptrdiff_t, not size_t, where either works.
317 (init_display): Check for overflow more accurately, and without
318 relying on undefined behavior.
319
a81d11a3
PE
320 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
321 Remove, replacing with the new symbols in lisp.h. All uses changed.
322 * fileio.c (make_temp_name):
323 * filelock.c (lock_file_1, lock_file):
324 * xdisp.c (message_dolog):
325 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
326 Use pMd etc. instead.
327 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
328 replacing the pWIDE etc. symbols removed from editfns.c.
329
3300e6fd
PE
330 * keyboard.h (num_input_events): Now uintmax_t.
331 This is (very slightly) less likely to mess up due to wraparound.
332 All uses changed.
333
fd05c7e9
PE
334 * buffer.c: Integer signedness fixes.
335 (alloc_buffer_text, enlarge_buffer_text):
336 Use ptrdiff_t rather than size_t when either will do, as we prefer
337 signed integers.
338
903fe15d
PE
339 * alloc.c: Integer signedness and overflow fixes.
340 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
341 (__malloc_size_t): Default to size_t, not to int.
342 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
343 (Fgarbage_collect, mark_object_loop_halt, mark_object):
344 Prefer ptrdiff_t to size_t when either would do, as we prefer
345 signed integers.
346 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
347 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
348 Now const. Initialize with values that are in range even if char
349 is signed.
350 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
351 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
352 These functions do the right thing with sizes > 2**32.
353 (check_depth): Now ptrdiff_t, not int.
354 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
355 Adjust to new way of storing sizes. Check for size overflow bugs
356 in rest of code.
357 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
358 slightly wrong anyway, as it missed one instance of
359 XMALLOC_OVERRUN_CHECK_OVERHEAD.
360 (refill_memory_reserve): Omit needless cast to size_t.
361 (mark_object_loop_halt): Mark as externally visible.
362
ac82cc6a
PE
363 * xselect.c: Integer signedness and overflow fixes.
364 (Fx_register_dnd_atom, x_handle_dnd_message):
365 Use ptrdiff_t, not size_t, since we prefer signed.
366 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
367 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
368 x_dnd_atoms_size and x_dnd_atoms_length.
369
c2d1e36d
PE
370 * doprnt.c: Prefer signed to unsigned when either works.
371 * eval.c (verror):
372 * doprnt.c (doprnt):
373 * lisp.h (doprnt):
374 * xdisp.c (vmessage):
375 Use ptrdiff_t, not size_t, when using or implementing doprnt,
376 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
377 prefer signed arithmetic to avoid comparison confusion.
378 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
379 but is a bit tricky.
380
0e926e56
PE
381 Assume freestanding C89 headers, string.h, stdlib.h.
382 * data.c, doprnt.c, floatfns.c, print.c:
383 Include float.h unconditionally.
384 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
385 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
386 * regex.c: Likewise for stddef.h, string.h.
387 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
388 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
389 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
390 (STDC_HEADERS): Remove obsolete defines.
391 * sysdep.c: Include limits.h unconditionally.
392
9cfdb3ec
PE
393 Assume support for memcmp, memcpy, memmove, memset.
394 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
395 * regex.c (memcmp, memcpy):
396 Remove; we assume C89 now.
397
398 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
399 (__malloc_safe_bcopy): Remove; no longer needed.
400
cf950e6b 401 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
402 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
403 well either way, and we prefer signed to unsigned.
404
dbf38e02
LMI
4052011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
406
407 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
408 closes the connection while we're reading (bug#9182).
409
d6f0886c
JD
4102011-07-25 Jan Djärv <jan.h.d@swipnet.se>
411
412 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
413 are specified (Bug#9168).
414
2eb1f9e6
PE
4152011-07-25 Paul Eggert <eggert@cs.ucla.edu>
416
417 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
418 Found by GCC static checking and --with-wide-int on a 32-bit host.
419
22381272 4202011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
421
422 * xdisp.c (compute_display_string_pos): Fix logic of caching
423 previous display string position. Initialize cached_prev_pos to
424 -1. Fixes slow-down at the beginning of a buffer.
425
f25e39b4
EZ
4262011-07-24 Eli Zaretskii <eliz@gnu.org>
427
428 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
429 for attrs[LFACE_FONTSET_INDEX].
430
04c4b52e
PE
4312011-07-23 Paul Eggert <eggert@cs.ucla.edu>
432
433 * xml.c (parse_region): Remove unused local
434 that was recently introduced.
435
c1734fbd
EZ
4362011-07-23 Eli Zaretskii <eliz@gnu.org>
437
be18c5a5
EZ
438 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
439 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
440
c1734fbd
EZ
441 * xdisp.c (move_it_in_display_line_to): Record the best matching
442 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
443 exit if none of the characters scanned was an exact match.
444 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
445 when exact match is impossible due to invisible text, and the
446 lines are truncated.
447
a258d627
JD
4482011-07-23 Jan Djärv <jan.h.d@swipnet.se>
449
450 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
451 for OSX >= 10.7.
452
b6d5a689
EZ
4532011-07-22 Eli Zaretskii <eliz@gnu.org>
454
0f74f785
EZ
455 Fix a significant slow-down of cursor motion with C-n, C-p,
456 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
457 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 458 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
459 (next_element_from_buffer): Call compute_stop_pos_backwards to
460 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
461 base_level_stop.
462 (reseat): Don't look for prev_stop, as that could mean a very long
463 run.
464 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
465 <cached_disp_overlay_modiff>: Cache for last found display string
466 position.
551918c1 467 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
468 about the same buffer in the same area of character positions, and
469 the buffer wasn't changed since the time the display string
470 position was cached.
551918c1 471
b2d0c91a
EZ
4722011-07-22 Eli Zaretskii <eliz@gnu.org>
473
474 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
475 is an integer, which is important for empty lines. (Bug#9149)
476
043604ee
CY
4772011-07-22 Chong Yidong <cyd@stupidchicken.com>
478
479 * frame.c (Fmodify_frame_parameters): In tty case, update the
480 default face if necessary (Bug#4238).
481
da4adb04
CY
4822011-07-21 Chong Yidong <cyd@stupidchicken.com>
483
484 * editfns.c (Fstring_to_char): No need to explain what a character
485 is in the docstring (Bug#6576).
486
9abd0532
LMI
4872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
488
489 * xml.c (parse_region): Make sure we always return a tree.
490
36881d16
HK
4912011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
492
493 * xml.c (parse_region): If a document contains only comments,
494 return that, too.
495
1e98674d
LMI
4962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
497
498 * xml.c (make_dom): Return comments, too.
499
590bd467
PE
5002011-07-19 Paul Eggert <eggert@cs.ucla.edu>
501
502 Port to OpenBSD.
503 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
504 and the surrounding thread.
505 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
506 rather than fgets, and retry after EINTR. Otherwise, 'emacs
507 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
508 timer goes off.
509 * s/openbsd.h (BROKEN_SIGIO): Define.
510 * unexelf.c (unexec) [__OpenBSD__]:
511 Don't update the .mdebug section of the Alpha COFF symbol table.
512
f41628b2
LMI
5132011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
514
515 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
516 (bug#8460).
517
b59b67c5
PE
5182011-07-18 Paul Eggert <eggert@cs.ucla.edu>
519
15e3a074
PE
520 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
521 This fixes some race conditions on the permissions of any newly
522 created file.
523
41bed37d
PE
524 * alloc.c (valid_pointer_p): Use pipe, not open.
525 This fixes some permissions issues when debugging.
526
b59b67c5
PE
527 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
528 If fchown fails to set both uid and gid, try to set just gid,
529 as that is sometimes allowed. Adjust the file's mode to eliminate
530 setuid or setgid bits that are inappropriate if fchown fails.
531
925a6be7
SM
5322011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
533
534 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
535 to compare Lisp_Objects.
536 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
537 global_gnutls_log_level, don't mistake it for a Lisp_Object.
538 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
539
52968808
AS
5402011-07-17 Andreas Schwab <schwab@linux-m68k.org>
541
0a6a104b
AS
542 * lread.c (read_integer): Unread even EOF character.
543 (read1): Likewise. Properly record start position of symbol.
544
52968808
AS
545 * lread.c (read1): Read `#:' as empty uninterned symbol if no
546 symbol character follows.
547
9e381cdd
PE
5482011-07-17 Paul Eggert <eggert@cs.ucla.edu>
549
550 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
551 This works around a problem with the previous change to Fcopy_file.
552 Recent glibc declares fchown with __attribute__((warn_unused_result)),
553 and without this change, GCC might complain about discarding
554 fchown's return value.
555
b5641435
JB
5562011-07-16 Juanma Barranquero <lekktu@gmail.com>
557
558 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
559
a8031457
PE
5602011-07-16 Paul Eggert <eggert@cs.ucla.edu>
561
562 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
563
dd889327
LMI
5642011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
565
750c33f7
LMI
566 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
567 it's used from the C level.
568
dd889327
LMI
569 * process.c: Use the same condition for POLL_FOR_INPUT in both
570 keyboard.c and process.c (bug#1858).
571
87e86684
LM
5722011-07-09 Lawrence Mitchell <wence@gmx.li>
573
574 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
575 (Fgnutls_boot): Use it.
576
64348f40
AS
5772011-07-15 Andreas Schwab <schwab@linux-m68k.org>
578
579 * doc.c (Fsubstitute_command_keys): Revert last change.
580
1d698799
LMI
5812011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
582
f863868c
LMI
583 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
584 quotes the next character, and doesn't affect other longer
585 sequences (bug#8935).
586
1d698799
LMI
587 * lread.c (syms_of_lread): Clarify that is isn't only
588 `eval-buffer' and `eval-defun' that's affected by
589 `lexical-binding' (bug#8460).
590
aa4b6df6
EZ
5912011-07-15 Eli Zaretskii <eliz@gnu.org>
592
593 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
594 bidi redisplay when a line includes both an image and is
595 truncated.
596
5d856da6
PE
5972011-07-14 Paul Eggert <eggert@cs.ucla.edu>
598
ad6042bb
PE
599 Fix minor problems found by static checking.
600 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
601 (elsz): Now a signed constant, not a size_t var. We prefer signed
602 types to unsigned, to avoid integer comparison confusion. Without
603 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
604 "cannot optimize loop, the loop counter may overflow", a symptom
605 of the confusion.
f00bbb22 606 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
607 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
608
6468f31c
LMI
6092011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
610
49080b10
LMI
611 * search.c (Fre_search_backward): Mention `case-fold-search' in
612 all the re_search_* functions (bug#8138).
613
6468f31c
LMI
614 * keyboard.c (Fopen_dribble_file): Document when the file is
615 closed (bug#8056).
616
c965adc5
EZ
6172011-07-14 Eli Zaretskii <eliz@gnu.org>
618
df9733bf
EZ
619 * bidi.c (bidi_dump_cached_states): Fix format of displaying
620 bidi_cache_idx.
621
0bb23927
EZ
622 Support bidi reordering of display and overlay strings.
623 * xdisp.c (compute_display_string_pos)
624 (compute_display_string_end): Accept additional argument STRING.
625 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
626 (reseat_to_string): Initialize bidi_it->string.s and
627 bidi_it->string.schars.
628 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
629 NULL (avoids a crash in bidi_paragraph_init).
630 Initialize itb.string.lstring.
0bb23927
EZ
631 (init_iterator): Call bidi_init_it only of a valid
632 buffer position was specified. Initialize paragraph_embedding to
633 L2R.
634 (reseat_to_string): Initialize the bidi iterator.
635 (display_string): If we need to ignore text properties of
636 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
637 original value of -1 will not work with bidi.)
638 (compute_display_string_pos): First arg is now struct
639 `text_pos *'; all callers changed. Support display properties on
640 Lisp strings.
641 (compute_display_string_end): Support display properties on Lisp
642 strings.
643 (init_iterator, reseat_1, reseat_to_string): Initialize the
644 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
645 when iterating on a string not from display properties).
640c8776
SM
646 (compute_display_string_pos, compute_display_string_end):
647 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
648 arrow keys.
649 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
650 base_level_stop; instead, set base_level_stop to BEGV.
651 Fixes crashes in vertical-motion.
0bb23927
EZ
652 (next_element_from_buffer): Improve commentary for when
653 the iterator is before prev_stop.
654 (init_iterator): Initialize bidi_p from the default value of
655 bidi-display-reordering, not from buffer-local value. Use the
656 buffer-local value only if initializing for buffer iteration.
657 (handle_invisible_prop): Support invisible properties on strings
658 that are being bidi-reordered.
659 (set_iterator_to_next): Support bidi reordering of C strings and
660 Lisp strings.
661 (next_element_from_string): Support bidi reordering of Lisp
662 strings.
663 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
664 (display_string): Support display of R2L glyph rows.
665 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
666 (init_iterator): Don't initialize it->bidi_p for strings
667 here.
668 (reseat_to_string): Initialize it->bidi_p for strings here.
669 (next_element_from_string, next_element_from_c_string)
670 (next_element_from_buffer): Add xassert's for correspondence
671 between IT's object being iterated and it->bidi_it.string
672 structure.
673 (face_before_or_after_it_pos): Support bidi iteration.
674 (next_element_from_c_string): Handle the case of the first string
675 character that is not the first one in the visual order.
676 (get_visually_first_element): New function, refactored from common
677 parts of next_element_from_buffer, next_element_from_string, and
678 next_element_from_c_string.
679 (tool_bar_lines_needed, redisplay_tool_bar)
680 (display_menu_bar): Force left-to-right direction. Add a FIXME
681 comment for making that be controlled by a user option.
682 (push_it, pop_it): Save and restore the state of the
683 bidi iterator. Save and restore the bidi_p flag.
684 (pop_it): Iterate out of display property for string iteration as
685 well.
686 (iterate_out_of_display_property): Support iteration over strings.
687 (handle_single_display_spec): Set up it->bidi_it for iteration
688 over a display string, and call bidi_init_it.
689 (handle_single_display_spec, next_overlay_string)
690 (get_overlay_strings_1, push_display_prop): Set up the bidi
691 iterator for displaying display or overlay strings.
692 (forward_to_next_line_start): Don't use the shortcut if
693 bidi-iterating.
694 (back_to_previous_visible_line_start): If handle_display_prop
695 pushed the iterator stack, restore the internal state of the bidi
696 iterator by calling bidi_pop_it same number of times.
697 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
698 and we are bidi-iterating, don't decrement the iterator position;
699 instead, set the first_elt flag in the bidi iterator, to produce
700 the same effect.
701 (reseat_1): Remove redundant setting of string_from_display_prop_p.
702 (push_display_prop): xassert that we are iterating a buffer.
703 (push_it, pop_it): Save and restore paragraph_embedding member.
704 (handle_single_display_spec, next_overlay_string)
705 (get_overlay_strings_1, reseat_1, reseat_to_string)
706 (push_display_prop): Set up the `unibyte' member of bidi_it.string
707 correctly. Don't assume unibyte strings are not bidi-reordered.
708 (compute_display_string_pos)
709 (compute_display_string_end): Fix handling the case of C string.
710 (push_it, pop_it): Save and restore from_disp_prop_p.
711 (handle_single_display_spec, push_display_prop): Set the
712 from_disp_prop_p flag.
713 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
714 (pop_it): Call iterate_out_of_display_property only if we are
715 popping after iteration over a string that came from a display
716 property. Fix a typo in popping stretch info. Add an assertion
717 for verifying that the iterator position is in sync with the bidi
718 iterator.
719 (handle_single_display_spec, get_overlay_strings_1)
720 (push_display_prop): Fix initialization of paragraph direction for
721 string when that of the parent object is not yet determined.
722 (reseat_1): Call bidi_init_it to resync the bidi
723 iterator with IT's position. (Bug#7616)
724 (find_row_edges): If ROW->start.pos gives position
725 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
726 (handle_stop, back_to_previous_visible_line_start, reseat_1):
727 Reset the from_disp_prop_p flag.
728 (SAVE_IT, RESTORE_IT): New macros.
729 (pos_visible_p, face_before_or_after_it_pos)
730 (back_to_previous_visible_line_start)
731 (move_it_in_display_line_to, move_it_in_display_line)
732 (move_it_to, move_it_vertically_backward, move_it_by_lines)
733 (try_scrolling, redisplay_window, display_line): Use them when
734 saving a temporary copy of the iterator and restoring it back.
735 (back_to_previous_visible_line_start, reseat_1)
736 (init_iterator): Empty the bidi cache "stack".
737 (move_it_in_display_line_to): If iterator ended up at
738 EOL, but we never saw any buffer positions smaller than
739 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
740 motion in bidi-reordered lines.
741 (move_it_in_display_line_to): Record prev_method and prev_pos
742 immediately before the call to set_iterator_to_next. Fixes cursor
743 motion in bidi-reordered lines with stretch glyphs and strings
744 displayed in margins. (Bug#8133) (Bug#8867)
745 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
746 TO_CHARPOS.
640c8776
SM
747 (pos_visible_p): Support positions in bidi-reordered lines.
748 Save and restore bidi cache.
0bb23927
EZ
749
750 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
751 (bidi_paragraph_info): Delete unused struct.
752 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
753 (bidi_cache_start): New variable.
754 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
755 to zero.
756 (bidi_cache_fetch_state, bidi_cache_search)
757 (bidi_cache_find_level_change, bidi_cache_iterator_state)
758 (bidi_cache_find, bidi_peek_at_next_level)
759 (bidi_level_of_next_char, bidi_find_other_level_edge)
760 (bidi_move_to_visually_next): Compare cache index with
761 bidi_cache_start rather than with zero.
762 (bidi_fetch_char): Accept new argument STRING; all callers
763 changed. Support iteration over a string. Support strings with
764 display properties. Support unibyte strings. Fix the type of
765 `len' according to what STRING_CHAR_AND_LENGTH expects.
766 (bidi_paragraph_init, bidi_resolve_explicit_1)
767 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
768 (bidi_level_of_next_char, bidi_move_to_visually_next):
769 Support iteration over a string.
0bb23927
EZ
770 (bidi_set_sor_type, bidi_resolve_explicit_1)
771 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
772 can now be zero (for strings); special values 0 and -1 were
773 changed to -1 and -2, respectively.
774 (bidi_char_at_pos): New function.
775 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
776 Call it instead of FETCH_MULTIBYTE_CHAR.
777 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
778 initialized to valid values.
779 (bidi_init_it): Don't initialize charpos and bytepos with invalid
780 values.
781 (bidi_level_of_next_char): Allow the sentinel "position" to pass
782 the test for valid cached positions. Fix the logic for looking up
783 the sentinel state in the cache. GCPRO the Lisp string we are
784 iterating.
785 (bidi_push_it, bidi_pop_it): New functions.
786 (bidi_initialize): Initialize the bidi cache start stack pointer.
787 (bidi_cache_ensure_space): New function, refactored from part of
788 bidi_cache_iterator_state. Don't assume the required size is just
789 one BIDI_CACHE_CHUNK away.
790 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
791 (bidi_count_bytes, bidi_char_at_pos): New functions.
792 (bidi_cache_search): Don't assume bidi_cache_last_idx is
793 always valid if bidi_cache_idx is valid.
794 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
795 is valid if it's going to be used.
796 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
797 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
798 (bidi_cache_find_level_change, bidi_cache_ensure_space)
799 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
800 (bidi_find_other_level_edge, bidi_cache_start_stack):
801 All variables related to cache indices are now EMACS_INT.
c965adc5 802
0bb23927
EZ
803 * dispextern.h (struct bidi_string_data): New structure.
804 (struct bidi_it): New member `string'. Make flag members be 1-bit
805 fields, and put them last in the struct.
640c8776
SM
806 (compute_display_string_pos, compute_display_string_end):
807 Update prototypes.
0bb23927
EZ
808 (bidi_push_it, bidi_pop_it): Add prototypes.
809 (struct iterator_stack_entry): New members bidi_p,
810 paragraph_embedding, and from_disp_prop_p.
811 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
812 (bidi_shelve_cache, bidi_unshelve_cache):
813 Declare prototypes.
0bb23927
EZ
814
815 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
816 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
817 and vector-like objects.
818
819 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
820 cache around display iteration.
821
822 * window.c (Fwindow_end, window_scroll_pixel_based)
823 (displayed_window_lines, Frecenter): Save and restore the bidi
824 cache around display iteration.
825
3bbd2265
LMI
8262011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
827
828 * editfns.c (Fdelete_region): Clarify the use of the named
829 parameters (bug#6788).
830
adc47434
MR
8312011-07-14 Martin Rudalics <rudalics@gmx.at>
832
833 * indent.c (Fvertical_motion): Set and restore w->pointm when
834 saving and restoring the window's buffer (Bug#9006).
835
837c31f8
LMI
8362011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
837
838 * editfns.c (Fstring_to_char): Clarify just what is returned
839 (bug#6576). Text by Eli Zaretskii.
840
ac389d0c
JB
8412011-07-13 Juanma Barranquero <lekktu@gmail.com>
842
843 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
844
0be0ce47
EZ
8452011-07-13 Eli Zaretskii <eliz@gnu.org>
846
847 * buffer.c (mmap_find): Fix a typo.
848
cd18e7e3
JB
8492011-07-13 Johan Bockgård <bojohan@gnu.org>
850
851 Fix execution of x selection hooks.
852 * xselect.c (Qx_lost_selection_functions)
853 (Qx_sent_selection_functions): New vars.
854 (syms_of_xselect): DEFSYM them.
855 (x_handle_selection_request): Pass Qx_sent_selection_functions
856 rather than Vx_sent_selection_functions to Frun_hook_with_args.
857 (x_handle_selection_clear,x_clear_frame_selections):
858 Pass Qx_lost_selection_functions rather than
859 Vx_lost_selection_functions to Frun_hook_with_args.
860
47ea7f44
PE
8612011-07-13 Paul Eggert <eggert@cs.ucla.edu>
862
ac389d0c 863 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
864 The old code sometimes used this field without initializing it.
865
47ea7f44
PE
866 * alloc.c (gc_sweep): Don't read past end of array.
867 In theory, the old code could also have corrupted Emacs internals,
868 though it'd be very unlikely.
869
bc985c87
AS
8702011-07-12 Andreas Schwab <schwab@linux-m68k.org>
871
872 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 873 argument. (Bug#4026)
bc985c87 874
0cf34688
LMI
8752011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
876
b3dadd76
LMI
877 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
878 key" (bug#4257).
879
0cf34688
LMI
880 * window.c (Fset_window_start): Doc fix (bug#4199).
881 (Fset_window_hscroll): Ditto.
882
270768cd
PE
8832011-07-12 Paul Eggert <eggert@cs.ucla.edu>
884
077e3dda 885 Fix minor new problems caught by GCC 4.6.1.
270768cd 886 * term.c (init_tty): Remove unused local.
490011a6 887 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 888 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 889 not used otherwise.
270768cd 890
b1f58454
CY
8912011-07-12 Chong Yidong <cyd@stupidchicken.com>
892
893 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
894
22b9578d
LMI
8952011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
896
6e70ab07
LMI
897 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
898 are the mini-buffer and the echo area (bug#3320).
899
22b9578d
LMI
900 * term.c (init_tty): Remove support for supdup, c10 and perq
901 terminals, which are no longer supported (bug#1482).
902
8974cc9f
JB
9032011-07-10 Johan Bockgård <bojohan@gnu.org>
904
905 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
906
a560d974
JD
9072011-07-10 Jan Djärv <jan.h.d@swipnet.se>
908
909 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
910 for non-popups (Bug#3642).
911
1dae0f0a
AS
9122011-07-10 Andreas Schwab <schwab@linux-m68k.org>
913
268c2c36 914 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 915 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
916 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
917 * cm.c (losecursor): Likewise.
1dae0f0a
AS
918 * data.c (fmod): Likewise.
919 * dispnew.c (swap_glyphs_in_rows): Likewise.
920 * emacs.c (memory_warning_signal): Likewise.
921 * floatfns.c (float_error): Likewise.
922 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
923 (otf_open, font_otf_capability, generate_otf_features)
924 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
925 Likewise.
926 * image.c (pbm_read_file): Likewise.
927 * indent.c (string_display_width): Likewise.
928 * intervals.c (check_for_interval, search_for_interval)
929 (inc_interval_count, count_intervals, root_interval)
930 (adjust_intervals_for_insertion, make_new_interval): Likewise.
931 * lread.c (defalias): Likewise.
268c2c36 932 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
933 * regex.c (set_image_of_range_1, set_image_of_range)
934 (regex_grow_registers): Likewise.
935 * sysdep.c (strerror): Likewise.
936 * termcap.c (valid_filename_p, tprint, main): Likewise.
937 * tparam.c (main): Likewise.
938 * unexhp9k800.c (run_time_remap, save_data_space)
939 (update_file_ptrs, read_header, write_header, calculate_checksum)
940 (copy_file, copy_rest, display_header): Likewise.
941 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
942 Likewise.
943 * xdisp.c (check_it): Likewise.
944 * xfaces.c (register_color, unregister_color, unregister_colors):
945 Likewise.
946 * xfns.c (print_fontset_result): Likewise.
947 * xrdb.c (member, fatal, main): Likewise.
948
99033785
PE
9492011-07-10 Paul Eggert <eggert@cs.ucla.edu>
950
951 Fix minor problems found by static checking (Bug#9031).
952 * chartab.c (char_table_set_range, map_sub_char_table):
953 Remove unused locals.
954 (uniprop_table): Now static.
955 * composite.c (_work_char): Remove unused static var.
956
9cb2ac56
JB
9572011-07-09 Juanma Barranquero <lekktu@gmail.com>
958
959 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
960
f25661f0
JD
9612011-07-09 Jan Djärv <jan.h.d@swipnet.se>
962
963 * gtkutil.c (qttip_cb): Remove code without function.
964
8278c4fe
EZ
9652011-07-09 Eli Zaretskii <eliz@gnu.org>
966
967 * w32.c (pthread_sigmask): New stub.
968
1692ae2d 9692011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 970
8a6ebd58 971 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
972 sigprocmask is portable only for single-threaded applications, and
973 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
974 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
975 (LIBES): Use it.
976 * callproc.c (Fcall_process):
977 * process.c (create_process):
978 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
979 Use pthread_sigmask, not sigprocmask.
123403e4 980
1b854618
JD
9812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
982
983 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
984 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
985 wrong (Bug#8591).
986
3fe4b549
JD
9872011-07-08 Jan Djärv <jan.h.d@swipnet.se>
988
0ce7e563
JD
989 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
990 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
991 (xg_hide_tooltip): Fix comment.
992
3fe4b549
JD
993 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
994 in registerServicesMenuSendTypes.
995 (validRequestorForSendType): Don't check ns_return_types.
996
997 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
998 ns_return_type.
999
5df75e47
JR
10002011-07-08 Jason Rumney <jasonr@gnu.org>
1001
1002 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1003 frame struct members of non-existent frames (Bug#6284).
1004
699c10bd
JD
10052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1006
4393663b
JD
1007 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1008 variable firstTime not needed on OSX >= 10.6.
1009 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1010 >= 10.5. Use setKnobProportion, setDoubleValue.
1011
1012 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1013 (MAC_OS_X_VERSION_10_5): Define if not defined.
1014 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1015 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1016 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1017
1018 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1019 cString and lossyCString on OSX >= 10.4
1020
1021 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1022 sizeToFit on OSX >= 10.2.
1023
1024 * nsimage.m (allocInitFromFile): Don't use deprecated method
1025 bestRepresentationForDevice on OSX >= 10.6.
1026
1027 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1028 to avoid warning.
1029
1030 * emacs.c: Declare unexec_init_emacs_zone.
1031
a63e0781
JD
1032 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1033
699c10bd
JD
1034 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1035
1036 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1037 on svcsMenu (Bug#8842).
1038
1039 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1040 ns_return_types.
1041 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1042
1043 * nsterm.m (QUTF8_STRING): Declare.
1044 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1045 (validRequestorForSendType): Return type is (id).
1046 Change indexOfObjectIdenticalTo to indexOfObject.
1047 Check if we have local selection before returning self (Bug#8842).
1048 (writeSelectionToPasteboard): Put local selection into paste board
1049 if we have a local selection (Bug#8842).
1050 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1051
1052 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1053 (ns_get_local_selection): Declare.
1054
54e10184
LMI
10552011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1056
9888ff71
LMI
1057 * keymap.c (describe_map_tree): Don't insert a double newline at
1058 the end of the buffer (bug#1169) and return whether we inserted
1059 something.
1060
54e10184
LMI
1061 * callint.c (Fcall_interactively): Change "reading args" to
1062 "providing args" to try to clarify what it does (bug#1010).
1063
15fa4783
KH
10642011-07-07 Kenichi Handa <handa@m17n.org>
1065
1066 * composite.c (composition_compute_stop_pos): Ignore a static
1067 composition starting before CHARPOS (Bug#8915).
1068
1069 * xdisp.c (handle_composition_prop): Likewise.
1070
a8815b00
EZ
10712011-07-07 Eli Zaretskii <eliz@gnu.org>
1072
1073 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1074 (Bug#9015)
1075
ef7b981d 10762011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1077
1078 * character.h (unicode_category_t): New enum type.
1079
1080 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1081 (Qchar_code_property_table): New variable.
1082 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1083 (UNIPROP_COMPRESSED_FORM_P): New macros.
1084 (char_table_ascii): Uncompress the compressed values.
1085 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1086 Uncompress the compressed values.
ac389d0c 1087 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1088 (char_table_ref_and_range): Uncompress the compressed values.
1089 (sub_char_table_set): New arg is_uniprop. Callers changed.
1090 Uncompress the compressed values.
1091 (sub_char_table_set_range): Args changed. Callers changed.
1092 (char_table_set_range): Adjuted for the above change.
1093 (map_sub_char_table): Delete args default_val and parent. Add arg
1094 top. Give decoded values to a Lisp function.
640c8776 1095 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1096 values to a Lisp function. Gcpro more variables.
1097 (uniprop_table_uncompress)
1098 (uniprop_decode_value_run_length): New functions.
1099 (uniprop_decoder, uniprop_decoder_count): New variables.
1100 (uniprop_get_decoder, uniprop_encode_value_character)
1101 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1102 New functions.
1103 (uniprop_encoder, uniprop_encoder_count): New variables.
1104 (uniprop_get_encoder, uniprop_table)
1105 (Funicode_property_table_internal, Fget_unicode_property_internal)
1106 (Fput_unicode_property_internal): New functions.
1107 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1108 Sunicode_property_table_internal, Sget_unicode_property_internal,
1109 and Sput_unicode_property_internal. Defvar_lisp
1110 char-code-property-alist.
1111
640c8776 1112 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1113 Vunicode_category_table.
1114
640c8776 1115 * font.c (font_range): Adjust for the change of
c805dec0
KH
1116 Vunicode_category_table.
1117
76b397fb
DN
11182011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1119
1120 * m/iris4d.h: Remove file, move contents ...
1121 * s/irix6-5.h: ... here.
1122
22b4128e
PE
11232011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1126 * alloc.c (mark_buffer):
1127 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1128 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1129 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1130 This isn't true in general, and it's particularly not true
1131 if Emacs is configured with --with-wide-int.
1132 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1133 New macros, used in the buffer.c change.
1134
869795d6
JD
11352011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1136
1137 * xsettings.c: Use both GConf and GSettings if both are available.
1138 (store_config_changed_event): Add comment.
1139 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1140 (store_tool_bar_style_changed): New functions.
1141 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1142 (struct xsettings): Move font inside HAVE_XFT.
1143 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1144 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1145 Move inside HAVE_XFT.
640c8776 1146 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1147 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1148 also.
1149 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1150 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1151 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1152 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1153 (parse_settings): Move check for font inside HAVE_XFT.
1154 (read_settings, apply_xft_settings): Add comment.
1155 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1156 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1157 call store_font_name_changed.
1158 (xft_settings_event): Add comment.
1159 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1160 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1161 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1162 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1163 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1164 (xsettings_get_system_font, xsettings_get_system_normal_font):
1165 Add comment.
869795d6 1166
d8ed26bd
PE
11672011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 Random fixes. E.g., (random) never returned negative values.
1170 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1171 subseconds part to the entropy, as that's a bit more random.
1172 Prefer signed to unsigned, since the signedness doesn't matter and
1173 in general we prefer signed. When given a limit, use a
1174 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1175 latter isn't right if USE_2_TAGS_FOR_INTS.
1176 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1177 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1178
cabf1cac
SM
11792011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1180
1181 * textprop.c (text_property_stickiness):
1182 Obey Vtext_property_default_nonsticky.
1183 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1184 * w32fns.c (syms_of_w32fns):
1185 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1186
6e9b2be9
PE
11872011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1190 This is more efficient than Ffile_directory_p and avoids a minor race.
1191
90186c68
LMI
11922011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1193
7c301272
LMI
1194 * buffer.c (Foverlay_put): Say what the return value is
1195 (bug#7835).
1196
c4f2d8d4
LMI
1197 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1198 is a directory before asking whether to use the file name
1199 (bug#7564).
ad637907
LMI
1200 (barf_or_query_if_file_exists): Make the "File is a directory"
1201 error be more correct.
c4f2d8d4 1202
90186c68
LMI
1203 * fns.c (Frequire): Remove the mention of the .gz files, since
1204 that's installation-specific, but keep the mention of
1205 `get-load-suffixes'.
1206
da64016e
PE
12072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1208
1209 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1210 Report string overflow if the output is too long.
1211
7d47b580
JB
12122011-07-04 Juanma Barranquero <lekktu@gmail.com>
1213
a555cb87
JB
1214 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1215 (syms_of_gnutls): Remove duplicate DEFSYM for
1216 Qgnutls_bootprop_verify_hostname_error, an error for
1217 Qgnutls_bootprop_verify_error (which is no longer used).
1218
7d47b580
JB
1219 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1220 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1221 Also (re)move comments that are misplaced or no longer relevant.
1222
1e49bfab
LMI
12232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1224
1225 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1226
1485f4c0
CY
12272011-07-03 Chong Yidong <cyd@stupidchicken.com>
1228
1229 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1230 and background color parameters if they have been changed.
1231
a9ab721e
LMI
12322011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1233
1234 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1235
cf7cff57
PE
12362011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1237
2e13213d
PE
1238 * xsettings.c (SYSTEM_FONT): Define only when used.
1239 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1240
cf7cff57
PE
1241 * keymap.c (access_keymap_1): Now static.
1242
7a8e04f7
CY
12432011-07-02 Chong Yidong <cyd@stupidchicken.com>
1244
1245 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1246 leave any prefix arg for the up event (Bug#1586).
1247
61352f62
LMI
12482011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1249
69bb1ef7
LMI
1250 * lread.c (syms_of_lread): Mention single symbols defined by
1251 `defvar' or `defconst' (bug#7154).
1252
61352f62 1253 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1254 (Frequire): Mention get-load-suffixes.
61352f62 1255
28545e04
MR
12562011-07-02 Martin Rudalics <rudalics@gmx.at>
1257
1258 * window.h (window): Remove clone_number slot.
1259 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1260 Remove.
1261 (make_parent_window, make_window, saved_window)
1262 (Fset_window_configuration, save_window_save): Don't deal with
1263 clone numbers.
1264 * buffer.c (Qclone_number): Remove declaration.
1265 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1266
3349e122
SM
12672011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1268
1269 Add multiple inheritance to keymaps.
1270 * keymap.c (Fmake_composed_keymap): New function.
1271 (Fset_keymap_parent): Simplify.
1272 (fix_submap_inheritance): Remove.
1273 (access_keymap_1): New function extracted from access_keymap to handle
1274 embedded parents and handle lists of maps.
1275 (access_keymap): Use it.
1276 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1277 (Fcopy_keymap): Handle embedded parents.
1278 (Fcommand_remapping, define_as_prefix): Simplify.
1279 (Fkey_binding): Simplify.
1280 (syms_of_keymap): Move minibuffer-local-completion-map,
1281 minibuffer-local-filename-completion-map,
1282 minibuffer-local-must-match-map, and
1283 minibuffer-local-filename-must-match-map to Elisp.
1284 (syms_of_keymap): Defsubr make-composed-keymap.
1285 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1286 (parse_menu_item): Trivial simplification.
1287
3279eb87
GM
12882011-07-01 Glenn Morris <rgm@gnu.org>
1289
1290 * Makefile.in (SETTINGS_LIBS): Fix typo.
1291
4550efdf
KI
12922011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1293
1294 * coding.c (Fencode_coding_string): Record the last coding system
1295 used, as the function doc string says (bug#8738).
1296
0949d2b6
JD
12972011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1298
1299 * xsettings.c (store_monospaced_changed): Take new font as arg and
1300 check for change against current_mono_font.
1301 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1302 (emacs_settings_constructor, emacs_settings_get_property)
1303 (emacs_settings_set_property, emacs_settings_class_init)
1304 (emacs_settings_init, gsettings_obj): Remove.
1305 (something_changedCB): New function for HAVE_GSETTINGS.
1306 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1307 with value as argument.
1308 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1309 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1310 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1311 "changed".
1312
1313 * xgselect.c: Add defined (HAVE_GSETTINGS).
1314 (xgselect_initialize): Ditto.
1315
1316 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1317 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1318 xg_select.
1319
bbc6b304
PE
13202011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 * eval.c (struct backtrace): Simplify and port the data structure.
1323 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1324 signed bit field, as this assumption is not portable and it makes
1325 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1326 "char debug_on_exit : 1" as this is not portable either; instead,
1327 use the portable "unsigned int debug_on_exit : 1". Remove unused
1328 member evalargs. Remove obsolete comments about cc bombing out.
1329
9851bfc5
JD
13302011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1331
51bb811f 1332 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1333 Let HAVE_GSETTINGS override HAVE_GCONF.
1334 (store_monospaced_changed): New function.
1335 (EMACS_SETTINGS): A new type derived from GObject to handle
1336 GSettings notifications.
1337 (emacs_settings_constructor, emacs_settings_get_property)
1338 (emacs_settings_set_property, emacs_settings_class_init):
1339 New functions.
1340 (gsettings_client, gsettings_obj): New variables.
1341 (GSETTINGS_SCHEMA): New define.
1342 (something_changedCB): Call store_monospaced_changed.
1343 (init_gsettings): New function.
1344 (xsettings_initialize): Call init_gsettings.
1345 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1346 to NULL.
1347
640c8776 1348 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1349 GCONF_CFLAGS/LIBS.
1350
5386012d
MR
13512011-06-29 Martin Rudalics <rudalics@gmx.at>
1352
1353 * window.c (resize_root_window, grow_mini_window)
1354 (shrink_mini_window): Rename Qresize_root_window to
1355 Qwindow_resize_root_window and Qresize_root_window_vertically to
1356 Qwindow_resize_root_window_vertically.
1357
f13e0b08
PE
13582011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1361
94515237
JB
13622011-06-27 Juanma Barranquero <lekktu@gmail.com>
1363
1364 * makefile.w32-in: Redesign dependencies so they reflect more
1365 clearly which files are directly included by each source file,
1366 and not through other includes.
1367
e43b6e43
MR
13682011-06-27 Martin Rudalics <rudalics@gmx.at>
1369
1370 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1371 (sort_overlays, overlay_strings): When an overlay's clone number
1372 matches the window's clone number process the overlay even if
1373 the overlay's window property doesn't match the current window.
1374
d68443dc
MR
1375 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1376 (Fwindow_hchild): Rename to Fwindow_left_child.
1377 (Fwindow_next): Rename to Fwindow_next_sibling.
1378 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1379 (resize_window_check): Rename to window_resize_check.
1380 (resize_window_apply): Rename to window_resize_apply.
1381 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1382 (Fdelete_other_windows_internal, resize_frame_windows)
1383 (Fsplit_window_internal, Fdelete_window_internal)
1384 (grow_mini_window, shrink_mini_window)
1385 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1386
c7e73be5
JD
13872011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1388
1389 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1390 (emacs_fixed_set_min_size): Remove.
1391 (emacs_fixed_new): Take frame as argument.
1392
1393 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1394 (_EmacsFixedPrivate): Remove minwidth/height.
1395 Add struct frame *f.
1396 (emacs_fixed_init): Initialize priv->f.
1397 (get_parent_class, emacs_fixed_set_min_size): Remove.
1398 (emacs_fixed_new): Set priv->f to argument.
1399 (emacs_fixed_get_preferred_width)
1400 (emacs_fixed_get_preferred_height): Use min_width/height from
1401 frames size_hint to set minimum and natural (Bug#8919).
1402 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1403 and use min_width/height from frames size_hint to set
1404 min_width/height (Bug#8919).
1405
1406 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1407 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1408 Fix indentation.
c7e73be5 1409
cf99dcf8
EZ
14102011-06-26 Eli Zaretskii <eliz@gnu.org>
1411
1412 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1413 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1414 called at ZV.
1415
029529ac
CY
14162011-06-26 Chong Yidong <cyd@stupidchicken.com>
1417
1418 * process.c (wait_reading_process_output): Bypass select if
1419 waiting for a cell while ignoring keyboard input, and input is
1420 pending. Suggested by Jan Djärv (Bug#8869).
1421
7a7ef429
PE
14222011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 Use gnulib's dup2 module instead of rolling our own.
1425 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1426
11fdef7d 14272011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1428
1429 * dispnew.c (scrolling_window): Before scrolling, turn off a
1430 mouse-highlight in the window being scrolled.
1431
cd3520a4
JB
14322011-06-24 Juanma Barranquero <lekktu@gmail.com>
1433
1434 Move DEFSYM to lisp.h and use everywhere.
1435
1436 * character.h (DEFSYM): Move declaration...
1437 * lisp.h (DEFSYM): ...here.
1438
1439 * gnutls.c:
1440 * minibuf.c:
1441 * w32menu.c:
1442 * w32proc.c:
1443 * w32select.c: Don't include character.h.
1444
1445 * alloc.c (syms_of_alloc):
1446 * buffer.c (syms_of_buffer):
1447 * bytecode.c (syms_of_bytecode):
1448 * callint.c (syms_of_callint):
1449 * casefiddle.c (syms_of_casefiddle):
1450 * casetab.c (init_casetab_once):
1451 * category.c (init_category_once, syms_of_category):
1452 * ccl.c (syms_of_ccl):
1453 * cmds.c (syms_of_cmds):
1454 * composite.c (syms_of_composite):
1455 * dbusbind.c (syms_of_dbusbind):
1456 * dired.c (syms_of_dired):
1457 * dispnew.c (syms_of_display):
1458 * doc.c (syms_of_doc):
1459 * editfns.c (syms_of_editfns):
1460 * emacs.c (syms_of_emacs):
1461 * eval.c (syms_of_eval):
1462 * fileio.c (syms_of_fileio):
1463 * fns.c (syms_of_fns):
1464 * frame.c (syms_of_frame):
1465 * fringe.c (syms_of_fringe):
1466 * insdel.c (syms_of_insdel):
1467 * keymap.c (syms_of_keymap):
1468 * lread.c (init_obarray, syms_of_lread):
1469 * macros.c (syms_of_macros):
1470 * msdos.c (syms_of_msdos):
1471 * print.c (syms_of_print):
1472 * process.c (syms_of_process):
1473 * search.c (syms_of_search):
1474 * sound.c (syms_of_sound):
1475 * syntax.c (init_syntax_once, syms_of_syntax):
1476 * terminal.c (syms_of_terminal):
1477 * textprop.c (syms_of_textprop):
1478 * undo.c (syms_of_undo):
1479 * w32.c (globals_of_w32):
1480 * window.c (syms_of_window):
1481 * xdisp.c (syms_of_xdisp):
1482 * xfaces.c (syms_of_xfaces):
1483 * xfns.c (syms_of_xfns):
1484 * xmenu.c (syms_of_xmenu):
1485 * xsettings.c (syms_of_xsettings):
1486 * xterm.c (syms_of_xterm): Use DEFSYM.
1487
4228cf16
TZ
14882011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1489
cd3520a4 1490 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1491
7fcccf1e
PE
14922011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1493
7efb4e0e
PE
1494 Integer and buffer overflow fixes (Bug#8873).
1495
ff5844ad
PE
1496 * print.c (printchar, strout): Check for string overflow.
1497 (PRINTPREPARE, printchar, strout):
1498 Don't set size unless allocation succeeds.
1499
90532f02
PE
1500 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1501 for sizes. Check for string overflow more accurately.
1502 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1503
6d84508d
PE
1504 * macros.c: Integer and buffer overflow fixes.
1505 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1506 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1507 Use ptrdiff_t, not int, for sizes.
1508 Don't increment bufsize until after realloc succeeds.
1509 Check for size-calculation overflow.
1510 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1511
437b2cb4
PE
1512 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1513
8b9ac8b4
PE
1514 * lread.c: Integer overflow fixes.
1515 (read_integer): Radix is now EMACS_INT, not int,
1516 to improve quality of diagnostics for out-of-range radices.
1517 Calculate buffer size correctly for out-of-range radices.
1518 (read1): Check for integer overflow in radices, and in
1519 read-circle numbers.
82cb60d3
PE
1520 (read_escape): Avoid int overflow.
1521 (Fload, openp, read_buffer_size, read1)
1522 (substitute_object_recurse, read_vector, read_list, map_obarray):
1523 Use ptrdiff_t, not int, for sizes.
1524 (read1): Use EMACS_INT, not int, for sizes.
20270765 1525 Check for size overflow.
8b9ac8b4 1526
7fcccf1e
PE
1527 * image.c (cache_image): Check for size arithmetic overflow.
1528
bfbbd7e7
PE
1529 * lread.c: Integer overflow issues.
1530 (saved_doc_string_size, saved_doc_string_length)
1531 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1532 Now ptrdiff_t, not int.
1533 (read1): Don't assume doc string length fits in int. Check for
1534 out-of-range doc string lengths.
1535 (read_list): Don't assume file position fits in int.
39019e54 1536 (read_escape): Check for hex character overflow.
bfbbd7e7 1537
4e323265
LL
15382011-06-22 Leo Liu <sdl.web@gmail.com>
1539
1540 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1541 Move to minibuffer.el.
1542
85fece3e
PE
15432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1544
20b84ce9 1545 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1546 The following patches are for when GLYPH_DEBUG && !XASSERT.
1547 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1548 * dispnew.c (flush_stdout):
1549 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1550 Mark as externally visible.
1551 * dispnew.c (check_window_matrix_pointers): Now static.
1552 * dispnew.c (window_to_frame_vpos):
1553 * xfns.c (unwind_create_frame):
1554 * xterm.c (x_check_font): Remove unused local.
1555 * scroll.c (CHECK_BOUNDS):
1556 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1557 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1558 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1559 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1560 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1561 Now static.
1562 (debug_method_add): Use va_list and vsprintf rather than relying
1563 on undefined behavior with wrong number of arguments.
1564 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1565 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1566 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1567 since we're not interested in debugging glyphs with old libraries.
1568 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1569 GCC 4.6.0's static checking.
1570
0766b489
PE
15712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1572
31fd4b32
PE
1573 Integer overflow and signedness fixes (Bug#8873).
1574 A few related buffer overrun fixes, too.
1575
b79e8648
PE
1576 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1577
0766b489
PE
1578 * dispextern.h (struct face.stipple):
1579 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1580 (x_bitmap_mask, x_allocate_bitmap_record)
1581 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1582 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1583 (x_create_bitmap_from_xpm_data):
1584 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1585 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1586 (.bitmaps_last):
1587 * xfaces.c (load_pixmap):
1588 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1589 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1590 (.bitmaps_last, struct x_output.icon_bitmap):
1591 Use ptrdiff_t, not int, for bitmap indexes.
1592 (x_allocate_bitmap_record): Check for size overflow.
1593 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1594
b081724f
PE
1595 Use ptrdiff_t, not int, for overlay counts.
1596 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1597 * editfns.c (overlays_around, get_pos_property):
1598 * textprop.c (get_char_property_and_overlay):
1599 * xdisp.c (next_overlay_change, note_mouse_highlight):
1600 * xfaces.c (face_at_buffer_position):
21514da7
PE
1601 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1602 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1603 (Fnext_overlay_change, Fprevious_overlay_change)
1604 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1605 Use ptrdiff_t, not int, for sizes.
21514da7 1606 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1607
3de73e5e
PE
1608 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1609
2606c57b
PE
1610 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1611 (x_session_initialize): Do not assume string length fits in int.
1612
aaafe47a
PE
1613 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1614 This is unlikely, but can occur if DPI is outlandish.
1615
2674ddc8 1616 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1617 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1618
28154962
PE
1619 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1620 * xrdb.c (magic_file_p, search_magic_path):
1621 Omit last arg SUFFIX; it was always 0. All callers changed.
1622 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1623
7de51af5
PE
1624 * xfont.c (xfont_match): Avoid need for strlen.
1625
25ed6cc3
PE
1626 * xfns.c: Don't assume strlen fits in int.
1627 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1628
4eab31dd
PE
1629 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1630 not unsigned long, as we prefer signed integers. All callers changed.
1631 Detect integer overflow in repeat count.
1632 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1633 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1634
171e2a58
PE
1635 * termcap.c: Don't assume sizes fit in int and never overflow.
1636 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1637 (gobble_line): Check for size-calculation overflow.
1638
ad39faca 1639 * minibuf.c (Fread_buffer):
6e5bb2dc 1640 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1641 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1642 Don't assume string length fits in int.
1643
52c61c22 1644 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1645 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1646
b5b8c9e5
PE
1647 * font.c: Don't assume string length fits in int.
1648 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1649 Use ptrdiff_t, not int.
ccd6111c
PE
1650 (font_intern_prop): Don't assume string length fits in int.
1651 Don't assume integer property fits in fixnum.
1652 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1653
882f0d81 1654 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1655 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1656 Reformulate so as not to need the command string.
1657 Invoke gzip -cd rather than gunzip, as it's more portable.
1658 (lock_info_type, lock_file_1, lock_file):
1659 Don't assume pid_t and time_t fit in unsigned long.
1660 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1661 (current_lock_owner): Prefer signed type for sizes.
1662 Use memcpy, not strncpy, where memcpy is what is really wanted.
1663 Don't assume (via atoi) that time_t and pid_t fit in int.
1664 Check for time_t and/or pid_t out of range, e.g., via a network share.
1665 Don't alloca where an auto var works fine.
1666
93f4cf88
PE
1667 * fileio.c: Fix some integer overflow issues.
1668 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1669 Don't assume string length fits in int.
1670 (directory_file_name): Don't assume string length fits in long.
1671 (make_temp_name): Don't assume pid fits in int, or that its print
1672 length is less than 20.
1673
f3e92b69
PE
1674 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1675
1bfdaf10
PE
1676 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1677
35016e9a
PE
1678 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1679
3d1e65a1
PE
1680 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1681 We prefer signed integers, even for size calculations.
1682
0b963a93
PE
1683 * emacs.c: Don't assume string length fits in 'int'.
1684 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1685 (main): Don't invoke strlen when not needed.
1686
573f4b54
PE
1687 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1688 (XD_DEBUG_MESSAGE): Don't waste a byte.
1689
989f33ba
PE
1690 * callproc.c (getenv_internal_1, getenv_internal)
1691 (Fgetenv_internal):
965d34eb
PE
1692 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1693
e4d29b33
PE
1694 * lread.c (invalid_syntax): Omit length argument.
1695 All uses changed. This doesn't fix a bug, but it simplifies the
1696 code away from its former Hollerith-constant appearance, and it's
1697 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1698 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1699
eb49b136
PE
1700 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1701 This didn't break anything, but it didn't help either.
1702 It's confusing to put a bogus integer in a place where the actual
1703 value does not matter.
9f62aeb1 1704 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1705 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1706
15375a22
PE
1707 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1708 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1709 implementation.
b61cc01c
PE
1710 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1711 We prefer signed types, and the value cannot exceed the EMACS_INT
1712 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1713 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1714 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1715 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1716
53b2623d
PE
1717 * indent.c (sane_tab_width): New function.
1718 (current_column, scan_for_column, Findent_to, position_indentation)
1719 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1720 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1721
51cab52b 1722 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1723
f2ed8a70
PE
1724 * lisp.h (lint_assume): New macro.
1725 * composite.c (composition_gstring_put_cache):
1726 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1727
abe80cc6
PE
1728 * editfns.c, insdel.c:
1729 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1730
b02c740e
PE
1731 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1732
ebc96716
PE
1733 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1734
b4e50fa0 1735 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1736 Use much-faster test for byte-length change.
311d5d7c 1737 Don't assume string byte-length fits in 'int'.
a4cf38e4 1738 Check that character arg fits in 'int'.
85461888 1739 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1740
c0c1ee9f
PE
1741 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1742
a498d7f4
PE
1743 * fns.c (concat): Catch string overflow earlier.
1744 Do not rely on integer wraparound.
1745
51cab52b
PE
1746 * dispextern.h (struct it.overlay_strings_charpos)
1747 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1748 * xdisp.c (forward_to_next_line_start)
1749 (back_to_previous_visible_line_start)
1750 (reseat_at_next_visible_line_start, next_element_from_buffer):
1751 Don't arbitrarily truncate the value of 'selective' to int.
1752
76031fad
PE
1753 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1754
5eb55db9
PE
1755 * composite.c: Don't truncate sizes to 'int'.
1756 (composition_gstring_p, composition_reseat_it)
1757 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1758 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1759 not EMACS_UINT, for indexes.
5eb55db9 1760
0703a717
PE
1761 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1762
d6202519
PE
1763 * buffer.c: Include <verify.h>.
1764 (struct sortvec.priority, struct sortstr.priority):
8961a454 1765 Now EMACS_INT, not int.
c20998a7 1766 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1767 (struct sortstr.size, record_overlay_string)
1768 (struct sortstrlist.size, struct sortlist.used):
1769 Don't truncate size to int.
1770 (record_overlay_string): Check for size-calculation overflow.
d6202519 1771 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1772
d5a19415
JM
17732011-06-22 Jim Meyering <meyering@redhat.com>
1774
029529ac 1775 Don't leak an XBM-image-sized buffer
d5a19415
JM
1776 * image.c (xbm_load): Free the image buffer after using it.
1777
a9041e6c
PE
17782011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1779
1780 Port to Sun C.
1781 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1782 that Sun C diagnosed.
1783 * fns.c (secure_hash): Fix pointer signedness issue.
1784 * intervals.c (static_offset_intervals): New function.
1785 (offset_intervals): Use it.
1786
7f3f739f
LL
17872011-06-21 Leo Liu <sdl.web@gmail.com>
1788
1789 * deps.mk (fns.o):
1790 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1791 sha512.h.
1792
1793 * fns.c (secure_hash): Rename from crypto_hash_function and change
1794 the first arg to accept symbols.
5b66d427 1795 (Fsecure_hash): New primitive.
7f3f739f
LL
1796 (syms_of_fns): New symbols.
1797
76147d94
DD
17982011-06-20 Deniz Dogan <deniz@dogan.se>
1799
1800 * process.c (Fset_process_buffer): Clarify return value in
1801 docstring.
1802
7d7d0045
CY
18032011-06-18 Chong Yidong <cyd@stupidchicken.com>
1804
1805 * dispnew.c (add_window_display_history): Use BVAR.
1806
1807 * xdisp.c (debug_method_add): Use BVAR.
1808 (check_window_end, dump_glyph_matrix, dump_glyph)
1809 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1810
1811 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1812 Likewise.
1813
1814 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1815 check till after the cache is created in init_frame_faces.
1816
ff2bc410
SM
18172011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1818
1819 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1820
28177add
PE
18212011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1822
dd3482fe
PE
1823 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1824 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1825 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1826
393d71f3 1827 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1828 * fileio.c (Finsert_file_contents):
1829 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1830 Remove the old (too-loose) buffer overflow checks.
1831 They weren't needed, since make_gap checks for buffer overflow.
1832 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1833 The old code merely checked for Emacs fixnum overflow, and relied
1834 on undefined (wraparound) behavior. The new code avoids undefined
1835 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1836
2e6813b0 1837 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1838 Tune. Don't use wider integers than needed. Don't use alloca.
1839 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1840
599a9e4f
PE
1841 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1842
99561444
PE
1843 * insdel.c, lisp.h (buffer_overflow): New function.
1844 (insert_from_buffer_1, replace_range, replace_range_2):
1845 * insdel.c (make_gap_larger):
1846 * editfns.c (Finsert_char):
1847 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1848
28177add
PE
1849 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1850
e69dafad
PE
18512011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1852
a7af7fde 1853 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1854
b1c46f02
PE
1855 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1856 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1857
e69dafad
PE
1858 * fileio.c: Don't assume EMACS_INT fits in off_t.
1859 (emacs_lseek): New static function.
1860 (Finsert_file_contents, Fwrite_region): Use it.
1861 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1862
566684ea
PE
1863 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1864
e6966cd6
PE
1865 * fns.c: Don't overflow int when computing a list length.
1866 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1867 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1868 truncation on 64-bit hosts. Check for QUIT every
1869 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1870 faster and is responsive enough.
1871 (Flength): Report an error instead of overflowing an integer.
1872 (Fsafe_length): Return a float if the value is not representable
1873 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1874 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1875 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1876
dd0b0efb
PE
1877 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1878 (header_size, word_size): New constants.
1879 (allocate_vectorlike): Don't check size overflow here.
1880 (allocate_vector): Check it here instead, since this is the only
1881 caller of allocate_vectorlike that could cause overflow.
1882 Check that the new vector's length is representable as a fixnum.
1883
86fe5cfe
PE
1884 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1885 The previous code was bogus. For example, next_almost_prime (32)
1886 returned 39, which is undesirable as it is a multiple of 3; and
1887 next_almost_prime (24) returned 25, which is a multiple of 5 so
1888 why was the code bothering to check for multiples of 7?
1889
80e88859
PE
1890 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1891
4a2f0ad6
PE
1892 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1893
f66c7cf8
PE
1894 Variadic C functions now count arguments with ptrdiff_t.
1895 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1896 Back then I didn't know that the Emacs coding style prefers signed int.
1897 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1898 were being counted with int, which may truncate counts on 64-bit
1899 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1900 * lisp.h (struct Lisp_Subr.function.aMANY)
1901 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1902 Arg counts are now ptrdiff_t, not size_t.
1903 All variadic functions and their callers changed accordingly.
1904 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1905 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1906 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1907 * callint.c (Fcall_interactively): Check arg count for overflow,
1908 to avoid potential buffer overrun. Use signed char, not 'int',
1909 for 'varies' array, so that we needn't bother to check its size
1910 calculation for overflow.
1911 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1912 * eval.c (apply_lambda):
1913 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1914 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1915 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1916
a1759b76
PE
1917 * callint.c (Fcall_interactively): Don't use index var as event count.
1918
d96be9fc
PE
1919 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1920 * mem-limits.h (SIZE): Remove; no longer used.
1921
a690a978 1922 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1923
578c21e6
PE
1924 Remove unnecessary casts.
1925 * xterm.c (x_term_init):
1926 * xfns.c (x_set_border_pixel):
1927 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1928 These aren't needed now that we assume ANSI C.
1929
96f53c6c
PE
1930 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1931 It's more likely to cause problems (due to unsigned overflow)
1932 than to cure them.
1933
83c77d31
PE
1934 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1935
ee2079f1
PE
1936 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1937
6da65536
PE
1938 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1939
7147c4a4
PE
1940 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1941
193e32d9
PE
1942 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1943
e5533da6
PE
1944 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1945
9910e595
PE
1946 GLYPH_CODE_FACE returns EMACS_INT, not int.
1947 * dispextern.h (merge_faces):
1948 * xfaces.c (merge_faces):
01103c44
PE
1949 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1950 Don't assume EMACS_INT fits in int.
9910e595 1951
2638320e
PE
1952 * character.h (CHAR_VALID_P): Remove unused parameter.
1953 * fontset.c, lisp.h, xdisp.c: All uses changed.
1954
045eb8d9
PE
1955 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1956
c1f134b5
PE
1957 * fns.c (concat): Minor tuning based on overflow analysis.
1958 This doesn't fix any bugs. Use int to hold character, instead
1959 of constantly refetching from Emacs object. Use XFASTINT, not
1960 XINT, for value known to be a character. Don't bother comparing
1961 a single byte to 0400, as it's always less.
1962
395fcb93 1963 * floatfns.c (Fexpt):
327eeec8
PE
1964 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1965
abbd3d23
PE
1966 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1967 for characters.
1968
684a03ef
PE
1969 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1970
0fed43f3
PE
1971 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1972 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1973 incorrectly succeed when S was a string, because 4294967386 was
1974 truncated before it was used.
1975
8fd02eb7
PE
1976 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1977 Otherwise, an out-of-range integer could cause undefined behavior
1978 on a 64-bit host.
1979
f8c86b69
PE
1980 * composite.c: Use int, not EMACS_INT, for characters.
1981 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1982 EMACS_INT, for values that are known to be in character range.
1983 This doesn't fix any bugs but is the usual style inside Emacs and
1984 may generate better code on 32-bit machines.
1985
34206dd2
PE
1986 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1987 This is for reasons similar to the recent CHAR_STRING fix.
1988 * charset.c (Fencode_char): Check that character arg is actually
1989 a character. Pass an int to ENCODE_CHAR.
1990 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1991 wider than 'int', as a compile-time check to prevent future regressions
1992 in this area.
1993
c5958d4c 1994 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1995
1996 Make sure a 64-bit char is never passed to CHAR_STRING.
1997 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1998 by silently ignoring the top 32 bits, allowing some values
1999 that were far too large to be valid characters.
2000 * character.h: Include <verify.h>.
2001 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2002 arguments are no wider than unsigned, as a compile-time check
2003 to prevent future regressions in this area.
2004 * data.c (Faset):
01103c44 2005 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2006 (Fsubst_char_in_region):
2007 * fns.c (concat):
2008 * xdisp.c (decode_mode_spec_coding):
2009 Adjust to CHAR_STRING's new requirement.
2010 * editfns.c (Finsert_char, Fsubst_char_in_region):
2011 * fns.c (concat): Check that character args are actually
2012 characters. Without this test, these functions did the wrong
2013 thing with wildly out-of-range values on 64-bit hosts.
2014
d37ca623
PE
2015 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2016 These casts should not be needed on 32-bit hosts, either.
2017 * keyboard.c (read_char):
2018 * lread.c (Fload): Remove casts to unsigned.
2019
ea204efb
PE
2020 * lisp.h (UNSIGNED_CMP): New macro.
2021 This fixes comparison bugs on 64-bit hosts.
2022 (ASCII_CHAR_P): Use it.
2023 * casefiddle.c (casify_object):
01103c44 2024 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2025 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2026 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2027 * dispextern.h (FACE_FROM_ID):
2028 * keyboard.c (read_char): Use UNSIGNED_CMP.
2029
41cb286c
PE
2030 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2031 not to EMACS_INT, to avoid GCC warning.
2032
4a1b9832
PE
2033 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2034
55daad71
PE
2035 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2036 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2037 isn't needed on 32-bit machines.
8f95c75c 2038
01103c44
PE
2039 * buffer.c (Fgenerate_new_buffer_name):
2040 Use EMACS_INT for count, not int.
0ceccced 2041 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2042
2043 * data.c (Qcompiled_function): Now static.
2044
c6f072e7
PE
2045 * window.c (window_body_lines): Now static.
2046
20ce5912
PE
2047 * image.c (gif_load): Rename local to avoid shadowing.
2048
9c4c5f81
PE
2049 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2050 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2051 * alloc.c (make_save_value): Integer argument is now of type
2052 ptrdiff_t, not int.
2053 (mark_object): Use ptrdiff_t, not int.
2054 * lisp.h (pD): New macro.
2055 * print.c (print_object): Use it.
2056
c0c5c8ae
PE
2057 * alloc.c: Use EMACS_INT, not int, to count objects.
2058 (total_conses, total_markers, total_symbols, total_vector_size)
2059 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2060 (total_free_floats, total_floats, total_free_intervals)
2061 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2062 Now EMACS_INT, not int. All uses changed.
2063 (Fgarbage_collect): Compute overall total using a double, so that
2064 integer overflow is less likely to be a problem. Check for overflow
2065 when converting back to an integer.
5a25e253
PE
2066 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2067 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2068 These were 'int' variables that could overflow on 64-bit hosts;
2069 they were never used, so remove them instead of repairing them.
211a0b2a 2070 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2071 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2072 Previously, this ceilinged at INT_MAX, but that doesn't work on
2073 64-bit machines.
e46bb31a 2074 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2075
c78baabf 2076 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2077 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2078 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2079 when a (possibly-narrower) signed value would do just as well.
2080 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2081
c9d624c6
PE
2082 * alloc.c: Catch some string size overflows that we were missing.
2083 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2084 for convenience in STRING_BYTES_MAX.
2085 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2086 The definition here is exact; the one in lisp.h was approximate.
2087 (allocate_string_data): Check for string overflow. This catches
2088 some instances we weren't catching before. Also, it catches
2089 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2090 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2091 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2092
c9d624c6
PE
2093 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2094 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2095 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2096
353032ce
PE
2097 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2098
2bccce07
PE
2099 * alloc.c (Fmake_string): Check for out-of-range init.
2100
0ac30604
SM
21012011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2102
2103 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2104
c195f2de
JD
21052011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2108 xg_get_default_scrollbar_width.
2109
2110 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2111 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2112 (style_changed_cb): Call update_theme_scrollbar_width and call
2113 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2114 all frames (Bug#8505).
2115 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2116 Call gtk_window_set_resizable if HAVE_GTK3.
2117 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2118 and height if HAVE_GTK3 (Bug#8505).
2119 (scroll_bar_width_for_theme): New variable.
2120 (update_theme_scrollbar_width): New function.
2121 (xg_get_default_scrollbar_width): Move code to
2122 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2123 (xg_initialize): Call update_theme_scrollbar_width.
2124
2125 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2126
2127 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2128
e10ac9f1
MR
21292011-06-12 Martin Rudalics <rudalics@gmx.at>
2130
2131 * frame.c (make_frame): Call other_buffer_safely instead of
2132 other_buffer.
2133
2134 * window.c (temp_output_buffer_show): Call display_buffer with
2135 second argument Vtemp_buffer_show_specifiers and reset latter
2136 immediately after the call.
2137 (Vtemp_buffer_show_specifiers): New variable.
2138 (auto_window_vscroll_p, next_screen_context_lines)
2139 (Vscroll_preserve_screen_position): Remove leading asterisks from
2140 doc-strings.
2141
2d3c217e 21422011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2143
7b7f97e8 2144 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2145 * buffer.c (Qclone_number): Remove for now, as it's unused.
2146 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2147 (record_buffer): Remove unused local.
2148 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2149 (set_frame_buffer_list): Remove; unused.
2150 * frame.h (other_visible_frames): Remove decl.
2151 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2152 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2153 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2154 if HAVE_GPM.
2155 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2156 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2157 Define only if HAVE_GPM.
2158 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2159 (update_hints_inhibit): Remove; never set. All uses removed.
2160 * widgetprv.h (emacsFrameClassRec): Remove decl.
2161 * window.c (delete_deletable_window): Now returns void, since it
2162 wasn't returning anything.
2163 (compare_window_configurations): Remove unused locals.
2164 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2165 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2166 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2167 the same widths as pointers. This follows up on the 2011-05-06 patch.
2168 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2169 * xterm.h: Likewise.
2170 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2171
1384b89e
JB
21722011-06-12 Juanma Barranquero <lekktu@gmail.com>
2173
2174 * makefile.w32-in: Update dependencies.
2175 (LISP_H): Add lib/intprops.h.
2176
1100a63c
CY
21772011-06-11 Chong Yidong <cyd@stupidchicken.com>
2178
2179 * image.c (gif_load): Add animation frame delay to the metadata.
2180 (syms_of_image): Use DEFSYM. New symbol `delay'.
2181
6198ccd0
MR
21822011-06-11 Martin Rudalics <rudalics@gmx.at>
2183
2184 * window.c (delete_deletable_window): Re-add.
2185 (Fset_window_configuration): Rewrite to handle dead buffers and
2186 consequently deletable windows.
2187 (window_tree, Fwindow_tree): Remove. Supply functionality in
2188 window.el.
2189 (compare_window_configurations): Simplify code.
2190
b6e3633c
AS
21912011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2192
1ab0dee5
AS
2193 * image.c (imagemagick_load_image): Fix type mismatch.
2194 (Fimagemagick_types): Likewise.
2195
b6e3633c
AS
2196 * window.h (replace_buffer_in_windows): Declare.
2197
9397e56f
MR
21982011-06-11 Martin Rudalics <rudalics@gmx.at>
2199
2200 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2201 Qclone_number. Remove external declaration of Qdelete_window.
2202 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2203 code.
640c8776
SM
2204 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2205 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2206 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2207 buffer list implementation.
2208 (other_buffer_safely): New function.
2209 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2210 calls to replace_buffer_in_windows and
2211 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2212 if allowed.
2213 (record_buffer): Inhibit quitting and rewrite using quittable
2214 functions. Run Qbuffer_list_update_hook if allowed.
2215 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2216 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2217 Move switch-to-buffer to window.el.
9397e56f
MR
2218 (bury-buffer): Move to window.el.
2219 (Vbuffer_list_update_hook): New variable.
2220
2221 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2222 section.
2223
2224 * window.h (resize_frame_windows): Move up in code.
2225 (Fwindow_frame): Remove EXFUN.
2226 (replace_buffer_in_all_windows): Remove prototype.
2227 (replace_buffer_in_windows_safely): Add prototype.
2228
2229 * window.c: Declare Qdelete_window static again. Move down
2230 declaration of select_count.
2231 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2232 (Fother_window): Move to window.el.
2233 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2234 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2235 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2236 window.el.
2237 (replace_buffer_in_windows): Implement by calling
2238 Qreplace_buffer_in_windows.
2239 (replace_buffer_in_all_windows): Remove with some functionality
2240 moved into replace_buffer_in_windows_safely.
2241 (replace_buffer_in_windows_safely): New function.
2242 (select_window_norecord, select_frame_norecord): Move in front
2243 of run_window_configuration_change_hook. Remove now obsolete
2244 declarations.
640c8776
SM
2245 (Fset_window_buffer): Rewrite doc-string.
2246 Call Qrecord_window_buffer.
9397e56f
MR
2247 (keys_of_window): Move binding for other-window to window.el.
2248
b50691aa
CY
22492011-06-11 Chong Yidong <cyd@stupidchicken.com>
2250
2251 * dispextern.h (struct image): Replace data member, whose int_val
2252 and ptr_val fields were not used by anything, with a single
2253 lisp_val object.
2254
2255 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2256 (gif_clear_image, gif_load, imagemagick_load_image)
2257 (gs_clear_image, gs_load): Callers changed.
2258
3f754b86
PE
22592011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2260
cca69397
PE
2261 * buffer.h: Include <time.h>, for time_t.
2262 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2263
109e28d0
PE
2264 Fix minor problems found by static checking.
2265
60737f02
PE
2266 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2267
4b66faf3
PE
2268 Make identifiers static if they are not used in other modules.
2269 * data.c (Qcompiled_function, Qframe, Qvector):
2270 * image.c (QimageMagick, Qsvg):
2271 * minibuf.c (Qmetadata):
2272 * window.c (resize_window_check, resize_root_window): Now static.
2273 * window.h (resize_window_check, resize_root_window): Remove decls.
2274
109e28d0
PE
2275 * window.c (window_deletion_count, delete_deletable_window):
2276 Remove; unused.
46a4ce9e
PE
2277 (window_body_lines): Now static.
2278 (Fdelete_other_windows_internal): Mark vars as initialized.
2279 Make sure 'resize_failed' is initialized.
2280 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2281 (resize_window_apply): Remove unused local.
2282 * window.h (delete_deletable_window): Remove decl.
2283
109e28d0 2284 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2285 (imagemagick_load_image): Fix pointer signedness problem by changing
2286 last arg from unsigned char * to char *. All uses changed.
2287 Also, fix a local for similar reasons.
2288 Remove unused locals. Remove locals to avoid shadowing.
2289 (fn_rsvg_handle_free): Remove; unused.
2290 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2291 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2292
3f754b86
PE
2293 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2294
2547adb1
CY
22952011-06-10 Chong Yidong <cyd@stupidchicken.com>
2296
2297 * image.c (gif_load): Fix omitted cast error introduced by
2298 2011-06-06 change.
2299
2c8e37d4
MR
23002011-06-10 Martin Rudalics <rudalics@gmx.at>
2301
2302 * window.h (resize_proportionally, orig_total_lines)
2303 (orig_top_line): Remove from window structure.
2304 (set_window_height, set_window_width, change_window_heights)
2305 (Fdelete_window): Remove prototypes.
2306 (resize_frame_windows): Remove duplicate declaration.
2307
440a42e3
EZ
23082011-06-10 Eli Zaretskii <eliz@gnu.org>
2309
2310 * window.h (resize_frame_windows, resize_window_check)
2311 (delete_deletable_window, resize_root_window)
2312 (resize_frame_windows): Declare prototypes.
2313
2314 * window.c (resize_window_apply): Make definition be "static" to
2315 match the prototype.
2316
562dd5e9
MR
23172011-06-10 Martin Rudalics <rudalics@gmx.at>
2318
2319 * window.c: Remove declarations of Qwindow_size_fixed,
2320 window_min_size_1, window_min_size_2, window_min_size,
2321 size_window, window_fixed_size_p, enlarge_window, delete_window.
2322 Remove static from declaration of Qdelete_window, it's
2323 temporarily needed by Fbury_buffer.
2324 (replace_window): Don't assign orig_top_line and
2325 orig_total_lines.
2326 (Fdelete_window, delete_window): Remove. Window deletion is
2327 handled by window.el.
640c8776
SM
2328 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2329 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2330 (Fdelete_other_windows): Remove. Deleting other windows is
2331 handled by window.el.
2332 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2333 handled in window.el.
2334 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2335 Window minimum sizes are handled in window.el.
2336 (shrink_windows, size_window, set_window_height)
2337 (set_window_width, change_window_heights, window_height)
2338 (window_width, CURBEG, CURSIZE, enlarge_window)
2339 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2340 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2341 handled in window.el.
2342 (make_dummy_parent): Rename to make_parent_window and give it a
2343 second argument horflag.
2344 (make_window): Don't set resize_proportionally any more.
2345 (Fsplit_window): Remove. Windows are split in window.el.
2346 (save_restore_action, save_restore_orig_size)
2347 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2348 Resize mini windows in window.el.
2349 (grow_mini_window, shrink_mini_window): Implement by calling
2350 Qresize_root_window_vertically, resize_window_check and
2351 resize_window_apply.
640c8776
SM
2352 (saved_window, Fset_window_configuration, save_window_save):
2353 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2354 resize_proportionally.
2355 (window_min_height, window_min_width): Move to window.el.
2356 (keys_of_window): Move bindings for delete-other-windows,
2357 split-window, delete-window and enlarge-window to window.el.
2358
2359 * buffer.c: Temporarily extern Qdelete_window.
2360 (Fbury_buffer): Temporarily call Qdelete_window instead of
2361 Fdelete_window (Fbury_buffer will move to window.el soon).
2362
2363 * frame.c (set_menu_bar_lines_1): Remove code handling
2364 orig_top_line and orig_total_lines.
2365
2366 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2367 set_window_height but set heights directly.
2368 (change_frame_size_1): Use resize_frame_windows.
2369
2370 * xdisp.c (init_xdisp): Don't use set_window_height but set
2371 heights directly.
2372
640c8776
SM
2373 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2374 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2375 run_window_configuration_change_hook.
2376
2377 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2378 instead of change_window_heights and run
2379 run_window_configuration_change_hook.
2380
1a13852e
MR
23812011-06-09 Martin Rudalics <rudalics@gmx.at>
2382
2383 * window.c (replace_window): Rename second argument REPLACEMENT to
2384 NEW. New third argument SETFLAG. Rewrite.
2385 (delete_window, make_dummy_parent): Call replace_window with
2386 third argument 1.
2387 (window_list_1): Move down in code.
2388 (run_window_configuration_change_hook): Move set_buffer part
2389 before select_frame_norecord part in order to unwind correctly.
2390 Rename count1 to count.
2391 (recombine_windows, delete_deletable_window, resize_root_window)
2392 (Fdelete_other_windows_internal)
2393 (Frun_window_configuration_change_hook, make_parent_window)
2394 (resize_window_check, resize_window_apply, Fresize_window_apply)
2395 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2396 (Fdelete_window_internal, Fresize_mini_window_internal):
2397 New functions.
1a13852e
MR
2398 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2399
f3d1777e
MR
24002011-06-08 Martin Rudalics <rudalics@gmx.at>
2401
496e208e
MR
2402 * window.h (window): Add some new members to window structure -
2403 normal_lines, normal_cols, new_total, new_normal, clone_number,
2404 splits, nest, prev_buffers, next_buffers.
2405 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2406 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2407
f3d1777e
MR
2408 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2409 Remove.
496e208e
MR
2410 (make_dummy_parent): Set new members of windows structure.
2411 (make_window): Move down in code. Handle new members of window
2412 structure.
2413 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2414 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2415 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2416 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2417 (Fset_window_next_buffers, Fset_window_clone_number):
2418 New functions.
496e208e
MR
2419 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2420 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2421 Doc-string fixes.
2422 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2423 Argument WINDOW can be now internal window too.
2424 (Fwindow_use_time): Move up in code.
2425 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2426 Rewrite doc-string.
2427 (Fset_window_configuration, saved_window)
2428 (Fcurrent_window_configuration, save_window_save): Handle new
2429 members of window structure.
b9e809c2
MR
2430 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2431 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2432 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2433 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2434 Qget_mru_window, Qresize_root_window,
2435 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2436 Qauto_buffer_name; staticpro them.
f3d1777e 2437
abde8f8c
MR
24382011-06-07 Martin Rudalics <rudalics@gmx.at>
2439
2440 * window.c (Fwindow_total_size, Fwindow_left_column)
2441 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2442 (Fwindow_list_1): New functions.
2443 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2444 (Fwindow_width, Fscroll_left, Fscroll_right):
2445 Use window_body_cols instead of window_box_text_cols.
2446 (delete_window, Fset_window_configuration):
2447 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2448 (delete_all_subwindows): Take a window as argument and not a
2449 structure. Rewrite.
190b47e6
MR
2450 (window_loop): Remove handling of GET_LRU_WINDOW and
2451 GET_LARGEST_WINDOW.
2452 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2453
2454 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2455 window_box_text_cols. delete_all_subwindows now takes a
2456 Lisp_Object as argument.
abde8f8c 2457
640c8776
SM
2458 * indent.c (compute_motion, Fcompute_motion):
2459 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2460
fa8a67e6
MR
2461 * frame.c (delete_frame): Call delete_all_subwindows with root
2462 window as argument.
2463
a54e3482
DC
24642011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2465
2466 * fns.c (Fputhash): Document return value.
2467
60002bf5
CY
24682011-06-06 Chong Yidong <cyd@stupidchicken.com>
2469
2470 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2471
0c671da6 24722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2473
b862a52a 2474 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2475
be44ca6c
PE
2476 Check for overflow when converting integer to cons and back.
2477 * charset.c (Fdefine_charset_internal, Fdecode_char):
2478 Use cons_to_unsigned to catch overflow.
2479 (Fencode_char): Use INTEGER_TO_CONS.
2480 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2481 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2482 * data.c (long_to_cons, cons_to_long): Remove.
2483 (cons_to_unsigned, cons_to_signed): New functions.
2484 These signal an error for invalid or out-of-range values.
2485 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2486 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2487 * font.c (Ffont_variation_glyphs):
2488 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2489 * lisp.h: Include <intprops.h>.
2490 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2491 (cons_to_signed, cons_to_unsigned): New decls.
2492 (long_to_cons, cons_to_long): Remove decls.
2493 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2494 (Fprimitive_undo): Use CONS_TO_INTEGER.
2495 * xfns.c (Fx_window_property): Likewise.
2496 * xselect.c: Include <limits.h>.
2497 (x_own_selection, selection_data_to_lisp_data):
2498 Use INTEGER_TO_CONS.
2499 (x_handle_selection_request, x_handle_selection_clear)
2500 (x_get_foreign_selection, Fx_disown_selection_internal)
2501 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2502 (lisp_data_to_selection_data): Use cons_to_unsigned.
2503 (x_fill_property_data): Use cons_to_signed.
2504 Report values out of range.
2505
d1f3d2af
PE
2506 Check for buffer and string overflow more precisely.
2507 * buffer.h (BUF_BYTES_MAX): New macro.
2508 * lisp.h (STRING_BYTES_MAX): New macro.
2509 * alloc.c (Fmake_string):
2510 * character.c (string_escape_byte8):
2511 * coding.c (coding_alloc_by_realloc):
2512 * doprnt.c (doprnt):
2513 * editfns.c (Fformat):
2514 * eval.c (verror):
2515 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2516 since they may not be the same number.
2517 * editfns.c (Finsert_char):
2518 * fileio.c (Finsert_file_contents):
2519 Likewise for BUF_BYTES_MAX.
2520
dd52fcea
PE
2521 * image.c: Use ptrdiff_t, not int, for sizes.
2522 (slurp_file): Switch from int to ptrdiff_t.
2523 All uses changed.
2524 (slurp_file): Check that file size fits in both size_t (for
2525 malloc) and ptrdiff_t (for sanity and safety).
2526
7f9bbdbb
PE
2527 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2528 if b->modtime has its maximal value.
2529
dfe18f82
PE
2530 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2531
84acfcf0
PE
2532 Don't assume time_t can fit into int.
2533 * buffer.h (struct buffer.modtime): Now time_t, not int.
2534 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2535 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2536
ccd9a01a
PE
2537 Minor fixes for signed vs unsigned integers.
2538 * character.h (MAYBE_UNIFY_CHAR):
2539 * charset.c (maybe_unify_char):
2540 * keyboard.c (read_char, reorder_modifiers):
2541 XINT -> XFASTINT, since the integer must be nonnegative.
2542 * ftfont.c (ftfont_spec_pattern):
2543 * keymap.c (access_keymap, silly_event_symbol_error):
2544 XUINT -> XFASTINT, since the integer must be nonnegative.
2545 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2546 since it makes no difference and we prefer signed.
2547 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2548 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2549 nonnegative.
2550
d6d100dd
SM
25512011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2552
2553 * window.h (Fwindow_frame): Declare.
2554
2b6148e4
PE
25552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2558 (SPARE_MEMORY): Always define.
2559 (LARGE_REQUEST): Remove.
2560 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2561
f230ecc9
MR
25622011-06-06 Martin Rudalics <rudalics@gmx.at>
2563
727e958e
MR
2564 * lisp.h: Move EXFUNS for Fframe_root_window,
2565 Fframe_first_window and Fset_frame_selected_window to window.h.
2566
2567 * window.h: Move EXFUNS for Fframe_root_window,
2568 Fframe_first_window and Fset_frame_selected_window here from
2569 lisp.h.
2570
2571 * frame.c (Fwindow_frame, Fframe_first_window)
2572 (Fframe_root_window, Fframe_selected_window)
2573 (Fset_frame_selected_window): Move to window.c.
2574 (Factive_minibuffer_window): Move to minibuf.c.
2575 (Fother_visible_frames_p): New function.
2576
2577 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2578
f230ecc9
MR
2579 * window.c (decode_window, decode_any_window): Move up in code.
2580 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2581 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2582 (Fwindow_buffer): Move up and rewrite doc-string.
2583 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2584 (Fwindow_prev): New functions.
727e958e
MR
2585 (Fwindow_frame): Move here from frame.c. Accept any window as
2586 argument.
2587 (Fframe_root_window, Fframe_first_window)
2588 (Fframe_selected_window): Move here from frame.c. Accept frame
2589 or arbitrary window as argument. Update doc-strings.
2590 (Fminibuffer_window): Move up in code.
2591 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2592 (Fset_frame_selected_window): Move here from frame.c.
2593 Marginal rewrite.
727e958e
MR
2594 (Fselected_window, select_window, Fselect_window): Move up in
2595 code. Minor doc-string fixes.
f230ecc9 2596
4d09bcf6
PE
25972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2600 Do not assume that spare memory exists; that assumption is valid
2601 only if SYSTEM_MALLOC.
2602 (LARGE_REQUEST): New macro, so that the issue of large requests
2603 is separated from the issue of spare memory.
2604
810928a2
AS
26052011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2606
172418ad
AS
2607 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2608 format. (Bug#8806)
2609
43f862f7
AS
2610 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2611
810928a2
AS
2612 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2613 before statements.
2614
a059fe24
JD
26152011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2616
2617 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2618
2619 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2620
2621 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2622 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2623
989bf368
JB
26242011-06-05 Juanma Barranquero <lekktu@gmail.com>
2625
2626 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2627
4b80f674
CY
26282011-06-04 Chong Yidong <cyd@stupidchicken.com>
2629
2630 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2631 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2632 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2633 New error handlers.
4b80f674
CY
2634 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2635 Obey Vx_select_enable_clipboard_manager. Catch errors in
2636 x_clipboard_manager_save (Bug#8779).
2637 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2638 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2639
99a33b77 26402011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2641
2642 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2643
99a33b77 26442011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2645
2646 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2647 in the current matrix if keep_current_p is non-zero.
2648
8264569d
EZ
26492011-06-04 Eli Zaretskii <eliz@gnu.org>
2650
2651 * bidi.c (bidi_level_of_next_char): Fix last change.
2652
57f97249
EZ
26532011-06-03 Eli Zaretskii <eliz@gnu.org>
2654
fec2107c 2655 Support bidi reordering of text covered by display properties.
57f97249 2656
fec2107c
EZ
2657 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2658 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2659 (bidi_cache_search, bidi_cache_iterator_state)
2660 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2661 (bidi_level_of_next_char, bidi_move_to_visually_next):
2662 Support character positions inside a run of characters covered by a
fec2107c
EZ
2663 display string.
2664 (bidi_paragraph_init, bidi_resolve_explicit_1)
2665 (bidi_level_of_next_char): Call bidi_fetch_char and
2666 bidi_fetch_char_advance instead of FETCH_CHAR and
2667 FETCH_CHAR_ADVANCE.
2668 (bidi_init_it): Initialize new members.
2669 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2670 definitions.
2671 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2672 instead of using explicit *_CHAR codes.
d6d100dd
SM
2673 (bidi_resolve_explicit, bidi_resolve_weak):
2674 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2675 bidirectional text is supported only in multibyte buffers.
2676 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2677 it to initialize the frame_window_p member of struct bidi_it.
2678 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2679 (bidi_resolve_explicit, bidi_resolve_weak)
2680 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2681 bidi_it->nchars is non-positive.
2682 (bidi_level_of_next_char): Don't try to lookup the cache for the
2683 next/previous character if nothing is cached there yet, or if we
2684 were just reseat()'ed to a new position.
c40e2fb2 2685
0e14fe90
EZ
2686 * xdisp.c (set_cursor_from_row): Set start and stop points
2687 according to the row's direction when priming the loop that looks
2688 for the glyph on which to display cursor.
2689 (single_display_spec_intangible_p): Function deleted.
2690 (display_prop_intangible_p): Reimplement to call
2691 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2692 Accept 3 additional arguments needed by handle_display_spec.
2693 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2694 values: lists, `(when COND...)' forms, etc.
2695 (single_display_spec_string_p): Support property values that are
2696 lists with the argument STRING its top-level element.
2697 (display_prop_string_p): Fix the condition for processing a
2698 property that is a list to be consistent with handle_display_spec.
fec2107c 2699 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2700 last portion of handle_display_prop.
2701 (compute_display_string_pos): Accept additional argument
2702 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2703 value of a `display' property is a "replacing spec".
2704 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2705 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2706 the display property, but just return a value indicating whether
2707 the display property will replace the characters it covers.
2708 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2709 frame_window_p members of struct bidi_it.
d6d100dd
SM
2710 (compute_display_string_pos, compute_display_string_end):
2711 New functions.
fec2107c
EZ
2712 (push_it): Accept second argument POSITION, where pop_it should
2713 jump to continue iteration.
2714 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2715
fec2107c
EZ
2716 * keyboard.c (adjust_point_for_property): Adjust the call to
2717 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2718
2719 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2720 (bidi_init_it): Update prototypes.
2721 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2722 (compute_display_string_pos, compute_display_string_end):
2723 Declare prototypes.
fec2107c
EZ
2724 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2725 EMACS_INT.
fc6f18ce 2726
40087514 27272011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2728
57f53182
PE
2729 Malloc failure behavior now depends on size of allocation.
2730 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2731 * lisp.h: Change signatures accordingly.
2732 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2733 All callers changed. (Bug#8762)
2734
2735 * gnutls.c: Use Emacs's memory allocators.
2736 Without this change, the gnutls library would invoke malloc etc.
2737 directly, which causes problems on non-SYNC_INPUT hosts, and which
2738 runs afoul of improving memory_full behavior. (Bug#8761)
2739 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2740 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2741 xfree instead of the default malloc, realloc, free.
2742 (Fgnutls_boot): No need to check for memory allocation failure,
2743 since xmalloc does that for us.
2744
ac32cd99 2745 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2746 * category.c (hash_get_category_set):
2747 * ccl.c (ccl_driver):
2748 * charset.c (Fdefine_charset_internal):
2749 * charset.h (struct charset.hash_index):
2750 * composite.c (get_composition_id, gstring_lookup_cache)
2751 (composition_gstring_put_cache):
2752 * composite.h (struct composition.hash_index):
2753 * dispextern.h (struct image.hash):
2754 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2755 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2756 (hashfn_equal, hashfn_user_defined, make_hash_table)
2757 (maybe_resize_hash_table, hash_lookup, hash_put)
2758 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2759 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2760 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2761 * image.c (make_image, search_image_cache, lookup_image)
2762 (xpm_put_color_table_h):
2763 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2764 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2765 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2766 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2767 * alloc.c (allocate_vectorlike):
2768 Check for overflow in vector size calculations.
2769 * ccl.c (ccl_driver):
2770 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2771 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2772 need to be updated by these changes.
40087514
PE
2773 * fns.c (make_hash_table, maybe_resize_hash_table):
2774 Check for integer overflow with large hash tables.
0de4bb68
PE
2775 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2776 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2777 (SXHASH_REDUCE): New macro.
2778 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2779 Use it instead of discarding useful hash info with large hash values.
2780 (sxhash_float): New function.
2781 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2782 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2783 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2784 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2785 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2786 Adjust signatures to match updated version of code.
2787 (consing_since_gc): Now EMACS_INT, since a single hash table can
2788 use more than INT_MAX bytes.
2789
698d32e2
DN
27902011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2791
2792 Make it possible to build with GCC-4.6+ -O2 -flto.
2793
2794 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2795
fd6fa53f
SM
27962011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2797
2798 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2799 Call minibuffer-inactive-mode.
2800
864db017
JB
28012011-05-31 Juanma Barranquero <lekktu@gmail.com>
2802
2803 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2804 Update dependencies.
2805
2ad0baf4
DN
28062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2807
2808 * data.c (init_data): Remove code for UTS, this system is not
2809 supported anymore.
2810
4fcc2638
DN
28112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2812
2813 Don't force ./temacs to start in terminal mode.
2814
2815 * frame.c (make_initial_frame): Initialize faces in all cases, not
2816 only when CANNOT_DUMP is defined.
2817 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2818
c56e0fd5
DN
28192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2820
2821 * dispnew.c (add_window_display_history): Use const for the string
2822 pointer. Remove declaration, not needed.
2823
333d54da 28242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2825
55d4c1b2 2826 Use 'inline', not 'INLINE'.
333d54da 2827 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2828 * alloc.c, fontset.c (INLINE): Remove.
2829 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2830 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2831 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2832 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2833 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2834
738db178
DN
28352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2836
2837 Make it possible to run ./temacs.
2838
2839 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2840 syms_of_callproc does the same thing. Remove test for
2841 "initialized", do it in the caller.
2842 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2843
620c53a6
SM
28442011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2845
2846 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2847 (read_minibuf): Use get_minibuffer.
2848 (syms_of_minibuf): Use DEFSYM.
2849 (Qmetadata): New var.
2850 * data.c (Qbuffer): Don't make it static.
2851 (syms_of_data): Use DEFSYM.
2852
e003a292
PE
28532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2854
2855 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2856 (CCL_CODE_MIN): New macro.
2857
ed008a6d
PE
28582011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2859
3687c2ef
PE
2860 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2861
ed008a6d
PE
2862 * eval.c (Qdebug): Now static.
2863 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2864 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2865 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2866
d66c4c7c
CY
28672011-05-29 Chong Yidong <cyd@stupidchicken.com>
2868
2869 * image.c: Various fixes to ImageMagick code comments.
2870 (Fimagemagick_types): Doc fix.
2871
5fbc2025
PE
28722011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2873
0196f88a
PE
2874 Minor fixes prompted by GCC 4.6.0 warnings.
2875
2876 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2877
5fbc2025
PE
2878 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2879 (x_clipboard_manager_save_all): Move extern decl to ...
2880 * xterm.h: ... here, so that it can be checked for consistency.
2881
1dd3c2d9
CY
28822011-05-29 Chong Yidong <cyd@stupidchicken.com>
2883
2884 * xselect.c (x_clipboard_manager_save_frame)
2885 (x_clipboard_manager_save_all): New functions.
2886 (Fx_clipboard_manager_save): Lisp function deleted.
2887
2888 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2889 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2890
2891 * xterm.h: Update prototype.
2892
5ba6571d
WX
28932011-05-28 William Xu <william.xwl@gmail.com>
2894
2895 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2896 exiting (Bug#8239).
2897
3eaff834
JM
28982011-05-28 Jim Meyering <meyering@redhat.com>
2899
e1900994 2900 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2901 * fns.c (to_uchar): Define.
2902 (crypto_hash_function): Use it to convert some newly-signed
2903 variables to unsigned, to avoid sign-extension bugs. For example,
2904 without this change, (md5 "truc") would evaluate to
2905 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2906 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2907 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2908
0f6990a7
PE
29092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 Integer overflow fixes.
c8a9ca5a 2912
08686060
PE
2913 * dbusbind.c: Serial number integer overflow fixes.
2914 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2915 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2916 to hold a serial number that is too large for a fixnum.
2917 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2918 Check for serial numbers out of range. Decode any serial number
59568bf0 2919 that was so large that it became a float. (Bug#8722)
08686060 2920
2d1fc3c7
PE
2921 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2922 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2923 Use XFASTINT rather than XUINT when numbers are nonnegative.
2924 (xd_append_arg, Fdbus_method_return_internal):
2925 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2926 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2927 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2928 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2929 (Bug#8722)
2d1fc3c7 2930
c8a9ca5a
PE
2931 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2932
519e1d69
PE
2933 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2934
30569699
PE
2935 ccl: add integer overflow checks
2936 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2937 (IN_INT_RANGE): New macros.
2938 (ccl_driver): Use them to check for integer overflow when
2939 decoding a CCL program. Many of the new checks are whether XINT (x)
2940 fits in int; it doesn't always, on 64-bit hosts. The new version
2941 doesn't catch all possible integer overflows, but it's an
847044ea 2942 improvement. (Bug#8719)
30569699 2943
c11285dc
PE
2944 * alloc.c (make_event_array): Use XINT, not XUINT.
2945 There's no need for unsigned here.
2946
fdccd48e
PE
2947 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2948 This follows up to the 2011-05-06 change that substituted uintptr_t
2949 for EMACS_INT. This case wasn't caught back then.
2950
37910ab2
PE
2951 Rework Fformat to avoid integer overflow issues.
2952 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2953 now (part of C89). Include <verify.h>.
2954 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2955 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2956 (Fformat): Avoid the prepass trying to compute sizes; it was only
2957 approximate and thus did not catch overflow reliably. Instead, walk
2958 through the format just once, formatting and computing sizes as we go,
2959 checking for integer overflow at every step, and allocating a larger
2960 buffer as needed. Keep track separately whether the format is
2961 multibyte. Keep only the most-recently calculated precision, rather
2962 than them all. Record whether each argument has been converted to
2963 string. Use EMACS_INT, not int, for byte and char and arg counts.
2964 Support field widths and precisions larger than INT_MAX. Avoid
2965 sprintf's undefined behavior with conversion specifications such as %#d
2966 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2967 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2968 formatting out-of-range floating point numbers with int
9173deec 2969 formats. (Bug#8668)
37910ab2 2970
2e6578fb
PE
2971 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2972
0ae6bdee
PE
2973 * data.c: Avoid integer truncation in expressions involving floats.
2974 * data.c: Include <intprops.h>.
2975 (arith_driver): When there's an integer overflow in an expression
2976 involving floating point, convert the integers to floating point
2977 so that the resulting value does not suffer from catastrophic
2978 integer truncation. For example, on a 64-bit host (* 4
2979 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2980 Do not rely on undefined behavior after integer overflow.
2981
de883a70
PE
2982 merge count_size_as_multibyte, parse_str_to_multibyte
2983 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2984 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2985 Check for integer overflow.
2986 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2987 since it's now a duplicate of the other. This is more of
2988 a character than a buffer op, so better that it's in character.c.
2989 * fns.c, print.c: Adjust to above changes.
2990
2ff916cb
PE
29912011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2992
2993 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2994
f1b54466
PE
29952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2996
fb1ac845
PE
2997 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2998 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2999 (x_clipboard_manager_save): Now static.
3000 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3001
f1b54466
PE
3002 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3003 (crypto_hash_function): Now static.
3004 Fix pointer signedness problems. Avoid unnecessary initializations.
3005
a9f737ee
CY
30062011-05-27 Chong Yidong <cyd@stupidchicken.com>
3007
3008 * termhooks.h (Vselection_alist): Make it terminal-local.
3009
3010 * terminal.c (create_terminal): Initialize it.
3011
3012 * xselect.c: Support for clipboard managers.
3013 (Vselection_alist): Move to termhooks.h as terminal-local var.
3014 (LOCAL_SELECTION): New macro.
3015 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3016 (symbol_to_x_atom): Remove gratuitous arg.
3017 (x_handle_selection_request, lisp_data_to_selection_data)
3018 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3019 (x_own_selection, x_get_local_selection, x_convert_selection):
3020 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3021 (some_frame_on_display): Delete unused function.
3022 (Fx_own_selection_internal, Fx_get_selection_internal)
3023 (Fx_disown_selection_internal, Fx_selection_owner_p)
3024 (Fx_selection_exists_p): New optional frame arg.
3025 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3026 (x_handle_selection_clear): Don't treat other terminals with the
3027 same keyboard specially. Use the terminal-local Vselection_alist.
3028 (x_clear_frame_selections): Use Frun_hook_with_args.
3029
3030 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3031
3032 * xterm.h: Add support for those atoms.
3033
e067f0c1
CY
30342011-05-26 Chong Yidong <cyd@stupidchicken.com>
3035
3036 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3037 (converted_selections, conversion_fail_tag): New global variables.
3038 (x_selection_request_lisp_error): Free the above.
3039 (x_get_local_selection): Remove unnecessary code.
3040 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3041 of converted selections stored in converted_selections.
3042 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3043 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3044 (x_convert_selection): New function.
3045 (x_handle_selection_event): Simplify.
3046 (x_get_foreign_selection): Don't ignore incoming requests while
3047 waiting for an answer; this will fail when we implement
3048 SAVE_TARGETS, and seems unnecessary anyway.
3049 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3050 (Vx_sent_selection_functions): Doc fix.
3051
0f4aebc0
LL
30522011-05-26 Leo Liu <sdl.web@gmail.com>
3053
3054 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3055
e61124cd
YM
30562011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3057
3058 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3059
3060 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3061 for fringe update if it has periodic bitmap.
ac389d0c 3062 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3063 and fringe_bitmap_periodic_p.
3064
3065 * fringe.c (get_fringe_bitmap_data): New function.
3066 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3067 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3068 row. Mark glyph row for fringe update if periodicity changed.
3069
3070 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3071 for fringe update unless it has periodic bitmap.
3072
f16d9837
KH
30732011-05-25 Kenichi Handa <handa@m17n.org>
3074
3075 * xdisp.c (get_next_display_element): Set correct it->face_id for
3076 a static composition.
3077
e1b90ef6
LL
30782011-05-24 Leo Liu <sdl.web@gmail.com>
3079
3080 * deps.mk (fns.o):
3081 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3082
3083 * fns.c (crypto_hash_function, Fsha1): New function.
3084 (Fmd5): Use crypto_hash_function.
3085 (syms_of_fns): Add Ssha1.
3086
7400048f
PE
30872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3088
3089 * gnutls.c: Remove unused macros.
3090 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3091 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3092 Remove macros that are defined and never used.
3093 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3094
abb71cf4
CY
30952011-05-22 Chong Yidong <cyd@stupidchicken.com>
3096
3097 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3098 (Fx_get_selection_internal): Minor cleanup.
3099 (Fx_own_selection_internal): Rename arguments for consistency with
3100 select.el.
3101
6307db39
PE
31022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3105
f3d4e0a4
CY
31062011-05-22 Chong Yidong <cyd@stupidchicken.com>
3107
3108 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3109
4d8ade89
YM
31102011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3111
3112 * dispnew.c (scrolling_window): Don't exclude the case that the
3113 last enabled row in the desired matrix touches the bottom boundary.
3114
32078c8d
GM
31152011-05-21 Glenn Morris <rgm@gnu.org>
3116
3117 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3118 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3119 and add some more files.
32078c8d 3120
7285dc67
EZ
31212011-05-20 Eli Zaretskii <eliz@gnu.org>
3122
3123 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3124 report_file_error introduced by the change from 2011-05-07.
3125
89d1bd22
PE
31262011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3127
3128 * systime.h (Time): Define only if emacs is defined.
3129 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3130 where the include path doesn't have X11/X.h by default. See
3131 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3132
e23640bb 31332011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3134
3135 * composite.c (find_automatic_composition): Fix previous change.
3136
b9704ad9
GM
31372011-05-20 Glenn Morris <rgm@gnu.org>
3138
3139 * lisp.mk: New file, split from Makefile.in.
3140 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3141 (shortlisp): Remove.
3142 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3143
4a720484
GM
31442011-05-19 Glenn Morris <rgm@gnu.org>
3145
3146 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3147 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3148 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3149 (lisp): Set the order to that of loadup.el.
3150 (shortlisp): Make it a copy of $lisp.
3151 (SOME_MACHINE_LISP): Remove.
3152 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3153 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3154
a28d4396
KH
31552011-05-18 Kenichi Handa <handa@m17n.org>
3156
3157 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3158 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3159 (find_automatic_composition): Mostly rewrite for efficiency.
3160
a2b1fa8e
JB
31612011-05-18 Juanma Barranquero <lekktu@gmail.com>
3162
3163 * makefile.w32-in: Update dependencies.
3164
8e1f5610
CS
31652011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3166
3167 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3168 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3169
7025ee00 31702011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3171
cdfa6eab
PE
3172 Fix some integer overflow issues, such as string length overflow.
3173
06d6db33
PE
3174 * insdel.c (count_size_as_multibyte): Check for string overflow.
3175
2b4560a8
PE
3176 * character.c (lisp_string_width): Check for string overflow.
3177 Use EMACS_INT, not int, for string indexes and lengths; in
3178 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3179 the resulting string length overflows an EMACS_INT; instead,
3180 report a string overflow if no precision given. When checking for
3181 precision exhaustion, use a check that cannot possibly have
3182 integer overflow. (Bug#8675)
3183 * character.h (lisp_string_width): Adjust to new signature.
3184
cb93f9be
PE
3185 * alloc.c (string_overflow): New function.
3186 (Fmake_string): Use it. This doesn't change behavior, but saves
3187 a few bytes and will simplify future changes.
3188 * character.c (string_escape_byte8): Likewise.
3189 * lisp.h (string_overflow): New decl.
3190
1a1f3366
PE
3191 Fixups, following up to the user-interface timestamp change.
3192 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3193 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3194 * msdos.c (mouse_get_pos): Likewise.
3195 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3196 * w32gui.h (Time): Define by including "systime.h" rather than by
3197 declaring it ourselves. (Bug#8664)
3198
d4e3e4d3
PE
3199 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3200 * image.c (clear_image_cache): Likewise.
3201
f6a24d19
PE
3202 * term.c (term_mouse_position): Don't assume time_t wraparound.
3203
08dc5ae6
PE
3204 Be more systematic about user-interface timestamps.
3205 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3206 and sometimes 'EMACS_UINT', to represent these timestamps.
3207 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3208 This makes the code easier to follow, and makes it easier to catch
3209 integer overflow bugs such as Bug#8664.
3210 * frame.c (Fmouse_position, Fmouse_pixel_position):
3211 Use Time, not unsigned long, for user-interface timestamps.
3212 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3213 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3214 * keyboard.h (last_event_timestamp): Likewise.
3215 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3216 * menu.h (xmenu_show): Likewise.
3217 * term.c (term_mouse_position): Likewise.
3218 * termhooks.h (struct input_event.timestamp): Likewise.
3219 (struct terminal.mouse_position_hook): Likewise.
3220 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3221 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3222 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3223 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3224 what it was before.
3225 * menu.h, termhooks.h: Include "systime.h", for Time.
3226
8e55734a
PE
3227 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3228 Don't assume that the difference between two unsigned long values
3229 can fit into an integer. At this point, we know button_down_time
3230 <= event->timestamp, so the difference must be nonnegative, so
3231 there's no need to cast the result if double-click-time is
3232 nonnegative, as it should be; check that it's nonnegative, just in
3233 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3234 apart (about 25 days). (Bug#8664)
8e55734a 3235
841f1b75 3236 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3237 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3238
3e26f69c
PE
3239 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3240 that always fit in int. Use a sentinel instead of a counter, to
3241 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3242 * frame.h (struct frame): Use int for menu_bar_items_used
3243 instead of EMACS_INT, since it always fits in int.
3e26f69c 3244
5cc152c0
PE
3245 * menu.c (grow_menu_items): Check for int overflow.
3246
d89eb65e
PE
3247 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3248
5235bd3e
PE
3249 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3250 Before, the code was not consistent. These values cannot exceed
3251 2**31 - 1 so there's no need to make them unsigned.
3252 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3253 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3254 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3255 as modifiers.
3256 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3257
bc827e23
PE
3258 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3259 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3260 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3261 presumably because the widths might not match.
3262
78eb494e
PE
3263 * window.c (size_window): Avoid needless test at loop start.
3264
04f2d78b
CB
32652011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3266
3267 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3268
d2fc7e3d 32692011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3270
3271 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3272
d2fc7e3d 32732011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3274
3275 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3276 `width' to `bar_area_x' and `bar_area_width', respectively.
3277 (x_scroll_run): Take account of fringe background extension.
3278
04f2d78b
CB
3279 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3280 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3281 `bar_area_width', respectively.
3282 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3283 background extension.
3284
79b70037
GM
32852011-05-10 Jim Meyering <meyering@redhat.com>
3286
3287 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3288
2f142cc5
JB
32892011-05-10 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * image.c (Finit_image_library): Return t for built-in image types,
3292 like pbm and xbm. (Bug#8640)
3293
57679c86
AS
32942011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3295
3296 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3297
888c9e86
EZ
32982011-05-07 Eli Zaretskii <eliz@gnu.org>
3299
b0512a1d
EZ
3300 * w32console.c (Fset_screen_color): Doc fix.
3301 (Fget_screen_color): New function.
3302 (syms_of_ntterm): Defsubr it.
3303
7285dc67
EZ
3304 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3305 unlink the temporary file if Fcall_process didn't create it in the
3306 first place.
3307 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3308 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3309 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3310 cue to call_process_cleanup not to close that handle.
3311
4d3fcc8e
BK
33122011-05-07 Ben Key <bkey76@gmail.com>
3313
3314 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3315 one of two shell specific rules, either bootstrap-temacs-CMD or
3316 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3317 to the previous implementation of the bootstrap-temacs rule.
3318 The bootstrap-temacs-CMD rule is similar to the previous
3319 implementation of the bootstrap-temacs rule except that it
3320 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3321 variable.
3322
3323 These changes, along with some changes to nt/configure.bat,
3324 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3325 earlier fix to add support for --cflags and --ldflags options
3326 that include quotes so that it works whether make uses cmd or
3327 sh as the shell.
3328
b4289b64
MA
33292011-05-06 Michael Albinus <michael.albinus@gmx.de>
3330
3331 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3332 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3333 is a constant.
3334 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3335 a string. Handle both cases.
3336 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3337 (Fdbus_register_method): Use Qinvalid_function.
3338
af4c0e28
JB
33392011-05-06 Juanma Barranquero <lekktu@gmail.com>
3340
3341 * makefile.w32-in: Update dependencies.
3342 (LISP_H): Add inttypes.h and stdin.h.
3343 (PROCESS_H): Add unistd.h.
3344
c51453d9
EZ
33452011-05-06 Eli Zaretskii <eliz@gnu.org>
3346
3347 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3348 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3349
8ff0ac3c 33502011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3351
4c4b566b
PE
3352 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3353
aab2b9b5
PE
3354 * term.c (vfatal): Remove stray call to va_end.
3355 It's not needed and the C Standard doesn't allow it here anyway.
3356
c378da0b
PE
3357 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3358 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3359
288b08c7
PE
3360 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3361 bytes.
3362
e3601888
PE
3363 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3364
db6c0e74
PE
3365 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3366
dd5963ea
PE
3367 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3368
88c9450f
PE
3369 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3370
2f9442b8
PE
3371 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3372
c032b5f8
PE
3373 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3374 * charset.c (Fdefine_charset_internal): Don't initialize
3375 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3376 32-bit int (Bug#8600).
a108c10b
PE
3377
3378 * lread.c (read_integer): Be more consistent with string-to-number.
3379 Use string_to_number to do the actual conversion; this avoids
3380 rounding errors and fixes some other screwups. Without this fix,
3381 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3382 (digit_to_number): Move earlier, for benefit of read_integer.
3383 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3384 not a digit in any supported base. (Bug#8602)
a108c10b 3385
ad5f9eea
PE
3386 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3387
aec1708a
PE
3388 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3389 to match comment at start of function. This also removes a
3390 GCC warning about overflow in a 32+64-bit port.
3391
47be4ab5
PE
3392 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3393
371cac43
PE
3394 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3395 Reported by Stefan Monnier in
3396 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3397 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3398 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3399
d01a7826
PE
3400 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3401 (EMACS_UINTPTR): Likewise, with uintptr_t.
3402
7fd47d5c
PE
3403 * lisp.h: Prefer 64-bit EMACS_INT if available.
3404 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3405 on 32-bit hosts that have 64-bit int, so that they can access
3406 large files.
122b0c86
PE
3407 However, temporarily disable this change unless the temporary
3408 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3409
8727937b
PE
3410 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3411
8ac068ac
PE
3412 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3413 This removes an assumption that EMACS_INT and long are the same
3414 width as pointers. The assumption is true for Emacs porting targets
3415 now, but we want to make other targets possible.
3416 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3417 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3418 In the rest of the code, change types of integers that hold casted
3419 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3420 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3421 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3422 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3423 No need to cast type when ORing.
3424 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3425 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3426 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3427 assume EMACS_INT is the same width as char *.
3428 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3429 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3430 Remove no-longer-needed casts.
3431 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3432 (xg_tool_bar_help_callback, xg_make_tool_item):
3433 Use EMACS_INTPTR to hold an integer
3434 that will be cast to void *; this can avoid a GCC warning
3435 if EMACS_INT is not the same width as void *.
3436 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3437 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3438 (current_message_1, set_message_1):
3439 Use a local to convert to proper width without a cast.
3440 * xmenu.c (dialog_selection_callback): Likewise.
3441
ede49d71
PE
3442 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3443 Also, don't assume VALBITS / RAND_BITS is less than 5,
3444 and don't rely on undefined behavior when shifting a 1 left into
3445 the sign bit.
3446 * lisp.h (get_random): Change signature to match.
3447
2f30ecd0
PE
3448 * lread.c (hash_string): Use size_t, not int, for hash computation.
3449 Normally we prefer signed values; but hashing is special, because
3450 it's better to use unsigned division on hash table sizes so that
3451 the remainder is nonnegative. Also, size_t is the natural width
3452 for hashing into memory. The previous code used 'int', which doesn't
3453 retain enough info to hash well into very large tables.
3454 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3455
2a866e7b
PE
3456 * dbusbind.c: Don't possibly lose pointer info when converting.
3457 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3458 Use XPNTR rather than XHASH, so that the high-order bits of
3459 the pointer aren't lost when converting through void *.
3460
51639eac
PE
3461 * eval.c (Fautoload): Don't double-shift a pointer.
3462
92394119
PE
3463 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3464
dbdb9a7c
JB
34652011-05-06 Juanma Barranquero <lekktu@gmail.com>
3466
3467 * gnutls.c (DEF_GNUTLS_FN):
3468 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3469
db7a0b4f
AS
34702011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3471
3472 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3473 marker. (Bug#8610)
3474
f7ff1b0f 34752011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3476
3477 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3478 New version that can reserve upto 2GB of heap space.
3479
f7ff1b0f 34802011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3481
3482 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3483
639c109b
TZ
34842011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3485
3486 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3487 `gnutls_certificate_set_x509_key_file'.
3488
d2127135
JB
34892011-05-05 Juanma Barranquero <lekktu@gmail.com>
3490
3491 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3492 Update dependencies.
3493
e968f4f3
JB
34942011-05-04 Juanma Barranquero <lekktu@gmail.com>
3495
3496 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3497 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3498 Remove unused parameter `fildes'.
3499 * process.c (read_process_output, send_process): Don't pass it.
3500
84d358f0
JB
35012011-05-04 Juanma Barranquero <lekktu@gmail.com>
3502
3503 Fix previous change: the library cache is defined in w32.c.
3504 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3505 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3506
0898ca10
JB
35072011-05-04 Juanma Barranquero <lekktu@gmail.com>
3508
3509 Implement dynamic loading of GnuTLS on Windows.
3510
3511 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3512 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3513 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3514 Declare.
3515
3516 * gnutls.c (Qgnutls_dll): Define.
3517 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3518 (gnutls_*): Declare function pointers.
3519 (init_gnutls_functions): New function to initialize function pointers.
3520 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3521 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3522 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3523 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3524 (emacs_gnutls_write, emacs_gnutls_read)
3525 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3526 (Fgnutls_available_p): New function.
3527 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3528 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3529 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3530
3531 * image.c: Include w32.h.
3532 (Vimage_type_cache): Delete.
3533 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3534 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3535 (w32_delayed_load): Move to w32.c.
3536
3537 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3538
3539 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3540 (w32_delayed_load): Move from image.c. When loading a library, record
3541 its filename in the :loaded-from property of the library id.
3542 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3543 Initialize and staticpro them.
3544 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3545
3546 * process.c: Include lisp.h before w32.h, not after.
3547 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3548 instead of gnutls_record_check_pending.
3549
3550 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3551
ff4de4aa
TZ
35522011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3553
3554 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3555 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3556 as passed in.
3557
abe95abb
JD
35582011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3559
3560 * xterm.c (x_set_frame_alpha): Do not set property on anything
3561 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3562
e16e55d4
JB
35632011-05-02 Juanma Barranquero <lekktu@gmail.com>
3564
3565 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3566
bafcf6a5
JB
35672011-05-02 Juanma Barranquero <lekktu@gmail.com>
3568
3569 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3570 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3571 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3572 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3573 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3574 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3575 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3576 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3577 (Qgnutls_bootprop_callbacks_verify): Make static.
3578
e7a6747f
AS
35792011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3580
19ed11ba
AS
3581 * callproc.c: Indentation fixup.
3582
e7a6747f 3583 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3584 (wait_for_termination, interruptible_wait_for_termination):
3585 Move after wait_for_termination_1.
e7a6747f 3586
1ef14cb4
LMI
35872011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3588
3589 * sysdep.c (interruptible_wait_for_termination): New function
3590 which is like wait_for_termination, but allows keyboard
3591 interruptions.
3592
3593 * callproc.c (Fcall_process): Add (:file "file") as an option for
3594 the STDOUT buffer.
3595 (Fcall_process_region): Ditto.
3596
330d880c
EZ
35972011-04-30 Eli Zaretskii <eliz@gnu.org>
3598
8db90b73
EZ
3599 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3600 rather than `XVECTOR (FOO)->size'.
3601
330d880c
EZ
3602 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3603 inttypes.h, as a gnulib replacement is used if it not available in
3604 system headers.
3605
15cbd324
EZ
36062011-04-21 Eli Zaretskii <eliz@gnu.org>
3607
3608 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3609 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3610 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3611
3612 * coding.c (coding_alloc_by_realloc): Error out if destination
3613 will grow beyond MOST_POSITIVE_FIXNUM.
3614 (decode_coding_emacs_mule): Abort if there isn't enough place in
3615 charbuf for the composition carryover bytes. Reserve an extra
3616 space for up to 2 characters produced in a loop.
3617 (decode_coding_iso_2022): Abort if there isn't enough place in
3618 charbuf for the composition carryover bytes.
3619
36202011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3621
ae940cca
EZ
3622 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3623 aborting when %lld or %lll format is passed.
3624 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3625 %llo or %llx format is passed. (Bug#8545)
3626
03ab8921
EZ
3627 * window.c (window_scroll_line_based): Use a marker instead of
3628 simple variables to record original value of point. (Bug#7952)
3629
afda1437
EZ
3630 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3631 produced by %s or %c overflows available buffer space. (Bug#8545)
3632
f76dee0c
PE
36332011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3636 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3637
fdc5744d
JB
36382011-04-28 Juanma Barranquero <lekktu@gmail.com>
3639
3640 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3641
638f053a
JB
36422011-04-28 Juanma Barranquero <lekktu@gmail.com>
3643
3644 * keyboard.c (Qdelayed_warnings_hook): Define.
3645 (command_loop_1): Run `delayed-warnings-hook'
3646 if Vdelayed_warnings_list is non-nil.
3647 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3648 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3649
d178f871
EZ
36502011-04-28 Eli Zaretskii <eliz@gnu.org>
3651
3652 * doprnt.c (doprnt): Don't return value smaller than the buffer
3653 size if the message was truncated. (Bug#8545).
3654
b124fd93
JB
36552011-04-28 Juanma Barranquero <lekktu@gmail.com>
3656
3657 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3658 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3659
e810457d
PE
36602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3661
3662 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3663
ea51cceb
JB
36642011-04-27 Juanma Barranquero <lekktu@gmail.com>
3665
3666 * makefile.w32-in: Update dependencies.
3667
94dcfacf
EZ
36682011-04-27 Eli Zaretskii <eliz@gnu.org>
3669
3670 Improve `doprnt' and its usage. (Bug#8545)
3671 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3672 `format_end'. Remove support for %l as a conversion specifier.
3673 Don't use xrealloc. Improve diagnostics when the %l size modifier
3674 is used. Update the commentary.
3675
3676 * eval.c (verror): Simplify calculation of size_t.
3677
3678 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3679 messages.
3680
f61f41d7
PE
36812011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3682
3683 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3684 change.
3685
96fb4434
PE
36862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3687
3688 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3689 This makes this file independent of the recent pseudovector change.
3690
671875da 36912011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3692
69e9b5a3
PE
3693 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3694
b5f869a7 3695 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3696 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3697 Remove unused local.
c8926152 3698 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3699
841a1577 3700 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3701 GCC 4.6.0 optimizes based on type-based alias analysis.
3702 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3703 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3704 != &v->size, and therefore "v->size = 1; b->size = 2; return
3705 v->size;" must therefore return 1. This assumption is incorrect
3706 for Emacs, since it type-puns struct Lisp_Vector * with many other
3707 types. To fix this problem, this patch adds a new type struct
f904488f 3708 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3709 and pseudovectors, and helps optimizing compilers not get fooled
3710 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3711 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3712 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3713 the size member.
eab3844f
PE
3714 (XSETPVECTYPE): Rewrite in terms of new macro.
3715 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3716 This is a bit clearer, and further avoids the possibility of
3717 undesirable aliasing.
3718 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3719 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3720 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3721 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3722 (ASIZE): Now uses header.size rather than size.
3723 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3724 to avoid the hassle of writing XVECTOR (foo)->header.size.
3725 (struct vectorlike_header): New type.
eab3844f
PE
3726 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3727 object, to help avoid aliasing.
3728 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3729 (SUBRP): Likewise, since Lisp_Subr is a special case.
3730 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3731 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3732 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3733 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3734 changed to be "header.size" and "header.next".
3735 * buffer.h (struct buffer): Likewise.
3736 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3737 * frame.h (struct frame): Likewise.
3738 * process.h (struct Lisp_Process): Likewise.
3739 * termhooks.h (struct terminal): Likewise.
3740 * window.c (struct save_window_data, struct saved_window): Likewise.
3741 * window.h (struct window): Likewise.
3742 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3743 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3744 * buffer.c (init_buffer_once): Likewise.
3745 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3746 special case.
3747 * process.c (Fformat_network_address): Use local var for size,
3748 for brevity.
3749
0df1eac5
PE
3750 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3751
847ab9d1 3752 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3753 * data.c (atof): Remove decl; no longer used or needed.
3754 (digit_to_number): Move to lread.c.
3755 (Fstring_to_number): Use new string_to_number function, to be
3756 consistent with how the Lisp reader treats infinities and NaNs.
3757 Do not assume that floating-point numbers represent EMACS_INT
3758 without losing information; this is not true on most 64-bit hosts.
3759 Avoid double-rounding errors, by insisting on integers when
3760 parsing non-base-10 numbers, as the documentation specifies.
3761 * lisp.h (string_to_number): New decl, replacing ...
3762 (isfloat_string): Remove.
bc0a5c13 3763 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3764 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3765 appears to have been a coding error. Similarly, do not accept
3766 strings like +-1e0 as floating point numbers. Do not report
3767 overflow for integer overflows unless the base is not 10 which
3768 means we have no simple and reliable way to continue.
3769 Break out the floating-point parsing into a new
3770 function string_to_number, so that Fstring_to_number parses
3771 floating point numbers consistently with the Lisp reader.
04f2d78b 3772 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3773 (E_CHAR, EXP_INT): Remove, replacing with ...
3774 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3775 (string_to_number): New function, replacing isfloat_string.
3776 This function checks for valid syntax and produces the resulting
3777 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3778 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3779 so that overflow for non-base-10 numbers is reported only when
3780 there's no portable and simple way to convert to floating point.
452f4150 3781
67769ffc
PE
3782 * textprop.c (set_text_properties_1): Rewrite for clarity,
3783 and to avoid GCC warning about integer overflow.
3784
c20db43f
PE
3785 * intervals.h (struct interval): Use EMACS_INT for members
3786 where EMACS_UINT might cause problems. See
3787 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3788 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3789 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3790 All uses changed.
37aa2f85
PE
3791 (offset_intervals): Tell GCC not to worry about length overflow
3792 when negating a negative length.
c20db43f 3793
2538aa2f
PE
3794 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3795 (overrun_check_free): Likewise.
3796
f2d3008d
PE
3797 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3798 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3799 word size.
3800
ec8df744
PE
3801 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3802 (gnutls_make_error): Rename local to avoid shadowing.
3803 (gnutls_emacs_global_deinit): ifdef out; not used.
3804 (Fgnutls_boot): Use const for pointer to readonly storage.
3805 Comment out unused local. Fix pointer signedness problems.
3806
640ee02d
PE
3807 * lread.c (openp): Don't stuff size_t into an 'int'.
3808 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3809 about possible signed overflow.
3810
6048fb2a
PE
3811 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3812 (GDK_KEY_g): Don't define if already defined.
3813 (xg_prepare_tooltip): Avoid pointer signedness problem.
3814 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3815
fa3c87e1
PE
3816 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3817 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3818
2172544b
PE
3819 * xfns.c (Fx_window_property): Simplify a bit,
3820 to make a bit faster and to avoid GCC 4.6.0 warning.
3821 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3822
9b821a21
PE
3823 * fns.c (internal_equal): Don't assume size_t fits in int.
3824
3c616cfa
PE
3825 * alloc.c (compact_small_strings): Tighten assertion a little.
3826
c2982e87
PE
3827 Replace pEd with more-general pI, and fix some printf arg casts.
3828 * lisp.h (pI): New macro, generalizing old pEd macro to other
3829 conversion specifiers. For example, use "...%"pI"d..." rather
3830 than "...%"pEd"...".
3831 (pEd): Remove. All uses replaced with similar uses of pI.
3832 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3833 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3834 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3835 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3836 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3837 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3838 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3839 64-bit hosts.
3840 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3841 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3842 * print.c (safe_debug_print, print_object): Likewise.
3843 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3844 to int.
6f04d126
PE
3845 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3846 avoiding the 0 flag, which is not portable.
c2982e87
PE
3847 * process.c (Fmake_network_process): Use pI to avoid cast.
3848 * region-cache.c (pp_cache): Likewise.
3849 * xdisp.c (decode_mode_spec): Likewise.
3850 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3851 behavior on 64-bit hosts with printf arg.
6f04d126 3852 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3853 (x_stop_queuing_selection_requests): Likewise.
3854 (x_get_window_property): Don't truncate byte count to an 'int'
3855 when tracing.
0b432f21 3856
5e073ec7
PE
3857 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3858 here, since it parses constructs like leading '-' and spaces,
3859 which are not wanted; and it overflows with large numbers.
3860 Instead, simply match F[0-9]+, which is what is wanted anyway.
3861
36372bf9
PE
3862 * alloc.c: Remove unportable assumptions about struct layout.
3863 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3864 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3865 (allocate_vectorlike, make_pure_vector): Use the new macros,
3866 plus offsetof, to remove unportable assumptions about struct layout.
3867 These assumptions hold on all porting targets that I know of, but
3868 they are not guaranteed, they're easy to remove, and removing them
3869 makes further changes easier.
3870
0b432f21
PE
3871 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3872 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3873 (string_overrun_cookie): Now const. Use initializers that
3874 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3875 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3876 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3877 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3878 multiple of sizeof (EMACS_INT); it need not be, if
3879 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3880 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3881
895009e1
JB
38822011-04-26 Juanma Barranquero <lekktu@gmail.com>
3883
3884 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3885
6a7a1b0b
TZ
38862011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3887
3888 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3889 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3890 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3891
841a1577 38922011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3893
3894 * lisp.h (Qdebug): List symbol.
895009e1 3895 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3896 * keyboard.c (debug-on-event): New variable.
3897 (handle_user_signal): Break into debugger when debug-on-event
3898 matches the current signal symbol.
3899
f2d3ba6f
DN
39002011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3901
3902 * alloc.c (check_sblock, check_string_bytes)
3903 (check_string_free_list): Convert to standard C.
3904
42ce4c63
TZ
39052011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3906
3907 * w32.c (emacs_gnutls_push): Fix typo.
3908
825cd63c
EZ
39092011-04-25 Eli Zaretskii <eliz@gnu.org>
3910
fb11d64d
EZ
3911 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3912 "cast to pointer from integer of different size".
3913
825cd63c
EZ
3914 Improve doprnt and its use in verror. (Bug#8545)
3915 * doprnt.c (doprnt): Document the set of format control sequences
3916 supported by the function. Use SAFE_ALLOCA instead of always
3917 using `alloca'.
3918
3919 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3920 is one byte too soon. Don't use xrealloc; instead xfree and
3921 xmalloc anew.
3922
e061a11b
TZ
39232011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3924
3925 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3926 callbacks stage.
3927
3928 * gnutls.c: Renamed global_initialized to
3929 gnutls_global_initialized. Added internals for the
3930 :verify-hostname-error, :verify-error, and :verify-flags
3931 parameters of `gnutls-boot' and documented those parameters in the
3932 docstring. Start callback support.
9173deec
JB
3933 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3934 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3935 on error. Return error code.
e061a11b
TZ
3936 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3937 (emacs_gnutls_read): Likewise.
3938 (Fgnutls_boot): Return handshake error code.
3939 (emacs_gnutls_handle_error): New function.
3940 (wsaerror_to_errno): Likewise.
3941
3942 * w32.h (emacs_gnutls_pull): Add prototype.
3943 (emacs_gnutls_push): Likewise.
3944
3945 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3946 (emacs_gnutls_push): Likewise.
3947
39482011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3949
3950 * process.c (wait_reading_process_output): Check if GnuTLS
3951 buffered some data internally if no FDs are set for TLS
3952 connections.
3953
3954 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3955 (LIBS): Link to USER_LIBS.
3956 ($(BLD)/gnutls.$(0)): New target.
3957
fa6996bc
EZ
39582011-04-24 Eli Zaretskii <eliz@gnu.org>
3959
eb35682e
EZ
3960 * xdisp.c (handle_single_display_spec): Rename the
3961 display_replaced_before_p argument into display_replaced_p, to
3962 make it consistent with the commentary. Fix typos in the
3963 commentary.
3964
e2ad650c
EZ
3965 * textprop.c (syms_of_textprop): Remove dead code.
3966 (copy_text_properties): Delete obsolete commentary about an
3967 interface that was deleted long ago. Fix typos in the description
3968 of arguments.
3969
1b2de274
EZ
3970 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3971 to changes in oldXMenu/XMenu.h from 2011-04-16.
3972 <menu_help_message, prev_menu_help_message>: Constify.
3973 (IT_menu_make_room): menu->help_text is now `const char **';
3974 adjust.
3975
3976 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3977 to changes in oldXMenu/XMenu.h from 2011-04-16.
3978 (struct XMenu): Declare `help_text' `const char **'.
3979
3980 * xfaces.c <Qunspecified>: Make extern again.
3981
3982 * syntax.c: Include sys/types.h before including regex.h, as
3983 required by Posix.
3984
762b15be
EZ
3985 * doc.c (get_doc_string): Improve the format passed to `error'.
3986
3987 * doprnt.c (doprnt): Improve commentary.
3988
3989 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3990
3991 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3992 them with etags.
3993
f1052e5d
EZ
3994 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3995 changes in globals.h immediately force recompilation.
762b15be
EZ
3996 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3997 $(CURDIR)/s/ms-w32.h.
3998 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3999
fa6996bc
EZ
4000 * character.c (Fchar_direction): Function deleted.
4001 (syms_of_character): Don't defsubr it.
4002 <char-direction-table>: Deleted.
4003
e6c3da20
EZ
40042011-04-23 Eli Zaretskii <eliz@gnu.org>
4005
4006 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4007 * doprnt.c: Include limits.h.
4008 (SIZE_MAX): New macro.
04f2d78b
CB
4009 (doprnt): Return a size_t value. 2nd arg is now size_t.
4010 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4011 Improve overflow protection. Support `l' modifier for integer
4012 conversions. Support %l conversion. Don't assume an EMACS_INT
4013 argument for integer conversions and for %c.
4014
4015 * lisp.h (doprnt): Restore prototype.
4016
4017 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4018 $(SRC)/character.h.
4019
4020 * Makefile.in (base_obj): Add back doprnt.o.
4021
4022 * deps.mk (doprnt.o): Add back prerequisites.
4023 (callint.o): Depend on character.h.
4024
4025 * eval.c (internal_lisp_condition_case): Include the handler
4026 representation in the error message.
4027 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4028 when breaking from the loop.
4029
4030 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4031
4032 * callint.c (Fcall_interactively): When displaying error message
4033 about invalid control letter, pass the character's codepoint, not
4034 a pointer to its multibyte form. Improve display of the character
4035 in octal and display also its hex code.
4036
4037 * character.c (char_string): Use %x to display the (unsigned)
4038 codepoint of an invalid character, to avoid displaying a bogus
4039 negative value.
4040
4041 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4042 `error', not SYMBOL_NAME itself.
4043
4044 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4045 character arguments to `error'.
4046
4047 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4048 to `error' in error message about FINAL_CHAR argument. Make sure
4049 FINAL_CHAR is a character, and use %c when it is passed as
4050 argument to `error'.
4051
4ffd0d6b 40522011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4053
4054 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4055
4056 * w32.c: Include <time.h>.
4057 (sys_localtime): New function.
4058
4ffd0d6b 40592011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4060
4061 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4062
4ffd0d6b 4063 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4064
4ffd0d6b 40652011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4066
4ffd0d6b
GM
4067 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4068 zombies (Bug#8467).
aac0c6e3 4069
04c56954
EZ
40702011-04-19 Eli Zaretskii <eliz@gnu.org>
4071
4072 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4073 gl_state.e_property when gl_state.object is Qt.
4074
4075 * insdel.c (make_gap_larger): Remove limitation of buffer size
4076 to <= INT_MAX.
4077
16a43933
CY
40782011-04-18 Chong Yidong <cyd@stupidchicken.com>
4079
4080 * xdisp.c (lookup_glyphless_char_display)
4081 (produce_glyphless_glyph): Handle cons cell entry in
4082 glyphless-char-display.
4083 (Vglyphless_char_display): Document it.
4084
4085 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4086 glyphless-char-display.
4087
4581706e
CY
40882011-04-17 Chong Yidong <cyd@stupidchicken.com>
4089
4090 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4091
4092 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4093
4094 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4095 definition for no-X builds.
4096
4887c6e2 40972011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4098
fd35b6f9
PE
4099 Static checks with GCC 4.6.0 and non-default toolkits.
4100
5c1ccb01
PE
4101 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4102
006c5daa
PE
4103 * process.c (keyboard_bit_set): Define only if SIGIO.
4104 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4105 (send_process): Repair possible setjmp clobbering.
4106
efc736d3
PE
4107 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4108
4e2fe2e6
PE
4109 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4110
f97334a2
PE
4111 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4112
4e75f29d
PE
4113 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4114 Define only if needed.
4115
90efadd1
PE
4116 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4117 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4118 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4119
3c647824
PE
4120 * dispextern.h (struct redisplay_interface): Rename param
4121 to avoid shadowing.
e264f262 4122 * termhooks.h (struct terminal): Likewise.
761383f4 4123 * xterm.c (xembed_send_message): Likewise.
3c647824 4124
b58c5c4a
PE
4125 * insdel.c (make_gap_smaller): Define only if
4126 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4127
cad59032
PE
4128 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4129 it.
4130
c339dc2e
PE
4131 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4132 so that we aren't warned about unused symbols.
4133
91a3e27b
PE
4134 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4135
399c71d3 4136 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4137
8ffc96f5
PE
4138 * xfns.c (x_real_positions): Mark locals as initialized.
4139
eef9bc79
PE
4140 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4141
098db9dd
PE
4142 * xterm.c: Fix problems found by static analysis with other toolkits.
4143 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4144 (x_dispatch_event): Declare static if USE_GTK, and
4145 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4146 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4147 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4148 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4149 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4150
eb18f6cc
PE
4151 * xmenu.c (menu_help_callback): Pointer type fixes.
4152 Use const pointers when pointing at readonly data. Avoid pointer
4153 signedness clashes.
4154 (FALSE): Remove unused macro.
4155 (update_frame_menubar): Remove unused decl.
4156
1fe72bf8
PE
4157 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4158
60d9e1db
PE
4159 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4160 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4161 (single_menu_item): Rename local to avoid shadowing.
4162
39261c26
PE
4163 * keyboard.c (make_lispy_event): Remove unused local var.
4164
018c5e19
PE
4165 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4166 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4167
63d2b86e
PE
4168 * bitmaps: Change bitmaps from unsigned char back to the X11
4169 compatible char. Avoid the old compiler warnings about
4170 out-of-range initializers by using, for example, '\xab' rather
4171 than 0xab.
4172
aefd87e1
PE
4173 * xgselect.c (xgselect_initialize): Check vs interface
4174 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4175
bf501fb9
PE
4176 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4177
e9829fdf
PE
4178 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4179 to read-only memory.
4180
1086c095
PE
4181 * fns.c (vector): Remove; this old hack is no longer needed.
4182
2baccd04 4183 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4184 Remove unused var.
dde42981 4185 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4186
72391843 4187 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4188
436c16df 4189 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4190 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4191 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4192
92bb796d 4193 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4194 (x_term_init): Remove local to avoid shadowing.
92bb796d 4195
764430a3 4196 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4197
4198 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4199 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4200
d1dfb56c
EZ
42012011-04-16 Eli Zaretskii <eliz@gnu.org>
4202
c4354cb4
EZ
4203 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4204
d1dfb56c
EZ
4205 Fix regex.c, syntax.c and friends for buffers > 2GB.
4206 * syntax.h (struct gl_state_s): Declare character position members
4207 EMACS_INT.
4208
4209 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4210
04f2d78b
CB
4211 * textprop.c (verify_interval_modification, interval_of):
4212 Declare arguments EMACS_INT.
d1dfb56c
EZ
4213
4214 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4215 EMACS_INT.
4216
4217 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4218
4219 * indent.c (Fvertical_motion): Local variable it_start is now
4220 EMACS_INT.
4221
4222 * regex.c (re_match, re_match_2, re_match_2_internal)
4223 (bcmp_translate, regcomp, regexec, print_double_string)
4224 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4225 (re_compile_pattern, re_exec): Declare arguments and local
4226 variables `size_t' and `ssize_t' and return values `regoff_t', as
4227 appropriate.
4228 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4229 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4230 <compile_stack_type>: `size' and `avail' are now `size_t'.
4231
4232 * regex.h <regoff_t>: Use ssize_t, not int.
4233 (re_search, re_search_2, re_match, re_match_2): Arguments that
4234 specify buffer/string position and length are now ssize_t and
4235 size_t. Return type is regoff_t.
4236
613052cd
BK
42372011-04-16 Ben Key <bkey76@gmail.com>
4238
4239 * nsfont.m: Fixed bugs in ns_get_family and
4240 ns_descriptor_to_entity that were caused by using free to
4241 deallocate memory blocks that were allocated by xmalloc (via
4242 xstrdup). This caused Emacs to crash when compiled with
4243 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4244 --enable-checking=xmallocoverrun). xfree is now used to
4245 deallocate these memory blocks.
4246
4170f62f 42472011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4248
71b41406
PE
4249 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4250
9587a89d
PE
4251 emacs_write: Accept and return EMACS_INT for sizes.
4252 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4253 et seq.
4254 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4255 Accept and return EMACS_INT.
4256 (emacs_gnutls_write): Return the number of bytes written on
4257 partial writes.
4258 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4259 (emacs_read, emacs_write): Remove check for negative size, as the
4260 Emacs source code has been audited now.
9587a89d
PE
4261 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4262 (emacs_read, emacs_write): Use it.
273a5f82
PE
4263 * process.c (send_process): Adjust to the new signatures of
4264 emacs_write and emacs_gnutls_write. Do not attempt to store
4265 a byte offset into an 'int'; it might overflow.
9587a89d 4266 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4267
3e047f51
PE
4268 * sound.c: Don't assume sizes fit in 'int'.
4269 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4270 Return EMACS_INT, not int.
3e047f51 4271 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4272 Accept EMACS_INT, not int.
4273 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4274 record read return values.
4275
cc39a9db
BK
42762011-04-15 Ben Key <bkey76@gmail.com>
4277
c9d0ec6d
JB
4278 * keyboard.c (Qundefined): Don't declare static since it is used
4279 in nsfns.m.
4280 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4281 static since they are used in nsfont.m.
cc39a9db 4282
6c60eb9f
SM
42832011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4284
4285 * process.c (Qprocessp): Don't declare static.
4286 * lisp.h (Qprocessp): Declare again.
4287
7990b61a
JB
42882011-04-15 Juanma Barranquero <lekktu@gmail.com>
4289
4290 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4291
5d4cb038
PE
42922011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4293
8bd7b830 4294 Improve C-level modularity by making more things 'static'.
cd64ea1d 4295
e3b27b31
PE
4296 Don't publish debugger-only interfaces to other modules.
4297 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4298 (verify_bytepos, count_markers): Move decls to the only modules
4299 that need them.
4300 * region-cache.h (pp_cache): Likewise.
4301 * window.h (check_all_windows): Likewise.
4302 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4303
5d4cb038
PE
4304 * sysdep.c (croak): Now static, if
4305 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4306 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4307
4308 * alloc.c (refill_memory_reserve): Now static if
4309 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4310 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4311
e87b6180
PE
4312 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4313 Define only if USE_LUCID.
4314
ac64929e
PE
4315 * xrdb.c (x_customization_string, x_rm_string): Now static.
4316
6f37259d
PE
4317 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4318 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4319
1683e3ab
PE
4320 * xdisp.c (draw_row_with_mouse_face): Now static.
4321 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4322
de9c2632
PE
4323 * window.h (check_all_windows): Mark externally visible.
4324
2b96acb7
PE
4325 * window.c (window_deletion_count): Now static.
4326
4327 * undo.c: Make symbols static if they're not exported.
4328 (last_undo_buffer, last_boundary_position, pending_boundary):
4329 Now static.
4330
50436f33
PE
4331 * textprop.c (interval_insert_behind_hooks): Now static.
4332 (interval_insert_in_front_hooks): Likewise.
4333
64520e5c
PE
4334 * term.c: Make symbols static if they're not exported.
4335 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4336 (max_frame_lines, tty_set_terminal_modes):
4337 (tty_reset_terminal_modes, tty_turn_off_highlight):
4338 (get_tty_terminal): Now static.
4339 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4340 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4341 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4342 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4343 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4344
1fa53021
PE
4345 * sysdep.c: Make symbols static if they're not exported.
4346 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4347 Now static.
4348 (sigprocmask_set, full_mask): Remove; unused.
4349 (wait_debugging): Mark as visible.
4350 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4351 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4352
d4b43b22
PE
4353 * syntax.c (syntax_temp): Define only if !__GNUC__.
4354
b7c513d0
PE
4355 * sound.c (current_sound_device, current_sound): Now static.
4356
989b29ad
PE
4357 * search.c (searchbufs, searchbuf_head): Now static.
4358
13a55a78
PE
4359 * scroll.c (scroll_cost): Remove; unused.
4360 * dispextern.h (scroll_cost): Remove decl.
4361
de68a1fc
PE
4362 * region-cache.h (pp_cache): Mark as externally visible.
4363
40ccffa6
PE
4364 * process.c: Make symbols static if they're not exported.
4365 (process_tick, update_tick, create_process, chan_process):
4366 (Vprocess_alist, proc_buffered_char, datagram_access):
4367 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4368 (deactivate_process): Mark defn as static, as well as decl.
4369 * lisp.h (create_process): Remove decl.
4370 * process.h (chan_process, Vprocess_alist): Remove decls.
4371
ad64fc97
PE
4372 * print.c: Make symbols static if they're not exported.
4373 (print_depth, new_backquote_output, being_printed, print_buffer):
4374 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4375 (print_interval, print_number_index, initial_stderr_stream):
4376 Now static.
4377 * lisp.h (Fprinc): Remove decl.
4378 (debug_output_compilation_hack): Mark as externally visible.
4379
adddb265
PE
4380 * sysdep.c (croak): Move decl from here to syssignal.h.
4381 * syssignal.h (croak): Put it here, so the API can be checked when
4382 'croak' is called from dissociate_if_controlling_tty.
4383
1717ede2
PE
4384 * minibuf.c: Make symbols static if they're not exported.
4385 (minibuf_save_list, choose_minibuf_frame): Now static.
4386 * lisp.h (choose_minibuf_frame): Remove decl.
4387
fa5fb2bc
PE
4388 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4389
1e3890d1
PE
4390 * lread.c: Make symbols static if they're not exported.
4391 (read_objects, initial_obarray, oblookup_last_bucket_number):
4392 Now static.
4393 (make_symbol): Remove; unused.
4394 * lisp.h (initial_obarray, make_symbol): Remove decls.
4395
8a1414fa
PE
4396 * keyboard.c: Make symbols static if they're not exported.
4397 (single_kboard, recent_keys_index, total_keys, recent_keys):
4398 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4399 (this_single_command_key_start, echoing, last_auto_save):
4400 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4401 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4402 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4403 (Vlispy_mouse_stem, double_click_count):
4404 Now static.
4405 (force_auto_save_soon): Define only if SIGDANGER.
4406 (ignore_mouse_drag_p): Now static if
4407 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4408 (print_help): Remove; unused.
4409 (stop_character, last_timer_event): Mark as externally visible.
4410 * keyboard.h (ignore_mouse_drag_p): Declare only if
4411 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4412 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4413 * lisp.h (echoing): Remove decl.
4414 (force_auto_save_soon): Declare only if SIGDANGER.
4415 * xdisp.c (redisplay_window): Simplify code, to make it more
4416 obvious that ignore_mouse_drag_p is not accessed if !defined
4417 USE_GTK && !defined HAVE_NS.
4418
93ea6e8f
PE
4419 * intervals.c: Make symbols static if they're not exported.
4420 (merge_properties_sticky, merge_interval_right, delete_interval):
4421 Now static.
4422 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4423
77382fcc
PE
4424 * insdel.c: Make symbols static if they're not exported.
4425 However, leave prepare_to_modify_buffer alone. It's never
4426 called from outside this function, but that appears to be a bug.
4427 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4428 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4429 (adjust_after_replace_noundo): Remove; unused.
4430 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4431 (signal_before_change): Remove decls.
77382fcc 4432
9306c32e
PE
4433 * indent.c (val_compute_motion, val_vmotion): Now static.
4434
cd44d2eb
PE
4435 * image.c: Make symbols static if they're not exported.
4436 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4437 if USE_GTK.
4438 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4439 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4440
ad9a7a06
PE
4441 * fringe.c (standard_bitmaps): Now static.
4442 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4443
81626931
PE
4444 * frame.c: Make symbols static if they're not exported.
4445 (x_report_frame_params, make_terminal_frame): Now static.
4446 (get_frame_param): Now static, unless HAVE_NS.
4447 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4448 (x_get_resource_string): Remove; not used.
4449 * frame.h (make_terminal_frame, x_report_frame_params):
4450 (x_get_resource_string); Remove decls.
4451 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4452 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4453
239f9db9
PE
4454 * font.c, fontset.c: Make symbols static if they're not exported.
4455 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4456 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4457 * font.c (font_close_object): Now static.
4458 * font.h (font_close_object): Remove.
4459 * fontset.c (FONTSET_OBJLIST): Remove.
4460 (free_realized_fontset) #if-0 the body, which does nothing.
4461 (face_suitable_for_char_p): #if-0, as it's never called.
4462 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4463 * xfaces.c (face_at_string_position):
4464 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4465 since 0 is always ASCII.
4466
dfcf3579
PE
4467 * fns.c (weak_hash_tables): Now static.
4468
5045092b
PE
4469 * fileio.c: Make symbols static if they're not exported.
4470 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4471 (Vwrite_region_annotation_buffers): Now static.
4472
57a96f5c
PE
4473 * eval.c: Make symbols static if they're not exported.
4474 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4475 * lisp.h (backtrace_list): Remove decl.
4476
35f08c38
PE
4477 * emacs.c: Make symbols static if they're not exported.
4478 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4479 (fatal_error_code, fatal_error_signal_hook, standard_args):
4480 Now static.
4481 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4482 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4483 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4484 * lisp.h (fatal_error_signal_hook): Remove decl.
4485 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4486
f44bd759
PE
4487 * editfns.c: Move a (normally-unused) function to its only use.
4488 * editfns.c, lisp.h (get_operating_system_release): Remove.
4489 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4490 worth the hassle of breaking this out.
4491
b532497d
PE
4492 * xterm.c: Make symbols static if they're not exported.
4493 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4494 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4495 (x_destroy_window, x_delete_display):
4496 Now static.
4497 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4498 (x_mouse_leave): Remove; unused.
4499 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4500 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4501 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4502 Remove decls.
4503 (x_mouse_leave): Declare only if WINDOWSNT.
4504 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4505 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4506 USE_X_TOOLKIT.
4507
1675728f
PE
4508 * ftxfont.c: Make symbols static if they're not exported.
4509 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4510 HAVE_FREETYPE.
4511 * font.h (ftxfont_driver): Likewise.
4512
e4cebfca
PE
4513 * xfns.c: Make symbols static if they're not exported.
4514 (x_last_font_name, x_display_info_for_name):
4515 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4516 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4517 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4518 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4519 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4520 (last_show_tip_args): Now static.
4521 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4522 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4523 (x_screen_planes): Remove; unused.
4524 * dispextern.h (x_screen_planes): Remove decl.
4525
5bf46f05
PE
4526 * dispnew.c: Make symbols static if they're not exported.
4527 * dispextern.h (redraw_garbaged_frames, scrolling):
4528 (increment_row_positions): Remove.
4529 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4530 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4531 Now static.
4532 (redraw_garbaged_frames): Remove; unused.
4533
435f4c28
PE
4534 * xfaces.c: Make symbols static if they're not exported.
4535 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4536 Remove decls.
4537 * xterm.h (defined_color): Remove decls.
4538 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4539 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4540 (menu_face_changed_default, defined_color, free_realized_face):
4541 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4542 (ascii_face_of_lisp_face): Remove; unused.
4543
8524aef3
PE
4544 * xdisp.c: Make symbols static if they're not exported.
4545 * dispextern.h (scratch_glyph_row, window_box_edges):
4546 (glyph_to_pixel_coords, set_cursor_from_row):
4547 (get_next_display_element, set_iterator_to_next):
4548 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4549 (show_mouse_face): Remove decls
4550 * frame.h (message_buf_print): Likewise.
4551 * lisp.h (pop_message, set_message, check_point_in_composition):
4552 Likewise.
4553 * xterm.h (set_vertical_scroll_bar): Likewise.
4554 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4555 (message_buf_print, scratch_glyph_row, displayed_buffer):
4556 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4557 (get_next_display_element, show_mouse_face, window_box_edges):
4558 (frame_to_window_pixel_xy, check_point_in_composition):
4559 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4560 (glyph_to_pixel_coords): Remove; unused.
4561
16390cd2
PE
4562 * dired.c (file_name_completion): Now static.
4563
4564 * dbusbind.c (xd_in_read_queued_messages): Now static.
4565
a25f4dfa
PE
4566 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4567 * data.c (circular_list_error): Remove.
4568
14a9c8df
PE
4569 * commands.h (last_point_position, last_point_position_buffer):
4570 (last_point_position_window): Remove decls.
4571 * keyboard.c: Make these variables static.
4572
04f2d78b
CB
4573 * coding.h (coding, code_convert_region, encode_coding_gap):
4574 Remove decls.
74ab6df5
PE
4575 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4576 (iso_code_class, detect_coding, code_convert_region): Now static.
4577 (encode_coding_gap): Remove; unused.
4578
38dfbee1
PE
4579 * chartab.c (chartab_chars, chartab_bits): Now static.
4580
a2cb4e63
PE
4581 * charset.h (charset_iso_8859_1): Remove decl.
4582 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4583 Now static.
4584
127198fd
PE
4585 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4586 * ccl.c (Vccl_program_table): Now static.
4587 (check_ccl_update): Remove; unused.
4588
d85b608f
PE
4589 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4590 * category.h: ... from here.
4591 * category.c (check_category_table, set_category_set): Now static.
4592
31cd66f3
PE
4593 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4594 * lisp.h: Remove these decls.
4595
c358e587
PE
4596 * buffer.c (buffer_count): Remove unused var.
4597
e78aecca
PE
4598 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4599 so that it's not optimized away.
4600 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4601 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4602 exported only to the debugger.
4603
e192d7d3 4604 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4605 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4606
92470028
PE
4607 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4608 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4609 was inaccessible from Lisp.
4610 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4611 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4612
244ed907
PE
4613 alloc.c: Import and export fewer symbols, and remove unused items.
4614 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4615 is defined.
4616 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4617 it's not optimized away by whole-program optimization.
4618 (message_enable_multibyte, free_misc): Remove.
4619 (catchlist, handlerlist, mark_backtrace):
4620 Declare only if BYTE_MARK_STACK.
4621 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4622 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4623 (message_enable_multibyte): Remove decl.
4624 (free_misc, interval_free_list, float_block, float_block_index):
4625 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4626 (cons_free_list, last_marked_index):
4627 Now static.
4628 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4629 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4630 (mark_backtrace): Define only if BYTE_MARK_STACK.
4631 * xdisp.c (message_enable_multibyte): Now static.
4632
61c2b50e 4633 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4634 This makes it easier for human readers (and static analyzers)
4635 to see whether these variables are used from other modules.
4636 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4637 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4638 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4639 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4640 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4641 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4642 * xmenu.c, xselect.c:
4643 Declare Q* vars static if they are not used in other modules.
4644 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4645 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4646 Remove decls of unexported vars.
4647 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4648
95c82688
PE
4649 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4650
16a97296
PE
4651 Make Emacs functions such as Fatom 'static' by default.
4652 This makes it easier for human readers (and static analyzers)
4653 to see whether these functions can be called from other modules.
4654 DEFUN now defines a static function. To make the function external
4655 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4656 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4657 (Finit_image_library):
16a97296
PE
4658 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4659 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4660 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4661 Remove decls, since these functions are now static.
4662 (Funintern, Fget_internal_run_time): New decls, since these functions
4663 were already external.
95c82688 4664
16a97296
PE
4665 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4666 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4667 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4668 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4669 * keyboard.c, keymap.c, lread.c:
4670 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4671 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4672 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4673 Mark functions with DEFUE instead of DEFUN,
4674 if they are used in other modules.
4675 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4676 decls for now-static functions.
4677 * buffer.h (Fdelete_overlay): Remove decl.
4678 * callproc.c (Fgetenv_internal): Mark as internal.
4679 * composite.c (Fremove_list_of_text_properties): Remove decl.
4680 (Fcomposition_get_gstring): New forward static decl.
4681 * composite.h (Fcomposite_get_gstring): Remove decl.
4682 * dired.c (Ffile_attributes): New forward static decl.
4683 * doc.c (Fdocumntation_property): New forward static decl.
4684 * eval.c (Ffetch_bytecode): New forward static decl.
4685 (Funintern): Remove extern decl; now in .h file where it belongs.
4686 * fileio.c (Fmake_symbolic_link): New forward static decl.
4687 * image.c (Finit_image_library): New forward static decl.
4688 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4689 * intervals.h (Fprevious_property_change):
4690 (Fremove_list_of_text_properties): Remove decls.
4691 * keyboard.c (Fthis_command_keys): Remove decl.
4692 (Fcommand_execute): New forward static decl.
4693 * keymap.c (Flookup_key): New forward static decl.
4694 (Fcopy_keymap): Now static.
4695 * keymap.h (Flookup_key): Remove decl.
4696 * process.c (Fget_process): New forward static decl.
4697 (Fprocess_datagram_address): Mark as internal.
4698 * syntax.c (Fsyntax_table_p): New forward static decl.
4699 (skip_chars): Remove duplicate decl.
4700 * textprop.c (Fprevious_property_change): New forward static decl.
4701 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4702 Now internal.
4703 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4704 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4705
785bbd42
PE
4706 * editfns.c (Fformat): Remove unreachable code.
4707
8b913b57
AS
47082011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4709
4710 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4711 change. (Bug#8496)
4712
a6744a35
EZ
47132011-04-13 Eli Zaretskii <eliz@gnu.org>
4714
4715 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4716 when at ZV. (Bug#8487)
4717
e7974947
AS
47182011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4719
baad03f0
AS
4720 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4721 (Bug#8437)
4722 * keyboard.c (parse_tool_bar_item): Likewise.
4723 * sound.c (sound_cleanup, alsa_close): Likewise.
4724 * termcap.c (tgetent): Likewise.
4725 * xfns.c (x_default_font_parameter): Likewise.
4726 * xsettings.c (read_and_apply_settings): Likewise.
4727
e7974947
AS
4728 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4729 (overrun_check_free): Protoize.
4730
28272684
PE
47312011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4732
4733 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4734 since callers should never pass a negative size.
4735 Change the signature to match that of plain 'read' and 'write'; see
4736 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4737 * lisp.h: Update prototypes of emacs_write and emacs_read.
4738
11997c76
EZ
47392011-04-11 Eli Zaretskii <eliz@gnu.org>
4740
4741 * xdisp.c (redisplay_window): Don't try to determine the character
4742 position of the scroll margin if the window start point w->startp
e896f03c 4743 is outside the buffer's accessible region. (Bug#8468)
11997c76 4744
8a2cbd72
EZ
47452011-04-10 Eli Zaretskii <eliz@gnu.org>
4746
4747 Fix write-region and its subroutines for buffers > 2GB.
4748 * fileio.c (a_write, e_write): Modify declaration of arguments and
4749 local variables to support buffers larger than 2GB.
4750 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4751
4752 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4753 argument, local variables, and return value.
4754
4755 * lisp.h: Update prototypes of emacs_write and emacs_read.
4756
4757 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4758
4073e537 47592011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4760
1ebfdcb6
PE
4761 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4762
b2ded58d
PE
4763 Fix more problems found by GCC 4.6.0's static checks.
4764
7d66342c
PE
4765 * xdisp.c (vmessage): Use a better test for character truncation.
4766
bbf47d44
PE
4767 * charset.c (load_charset_map): <, not <=, for optimization,
4768 and to avoid potential problems with integer overflow.
9248994d 4769 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4770 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4771 * editfns.c (Fformat): Likewise.
1e69125e 4772 * syntax.c (skip_chars): Likewise.
3befa583 4773
e3019616
PE
4774 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4775 This also lets GCC 4.6.0 generate slightly better loop code.
4776
becfa255
PE
4777 * callint.c (Fcall_interactively): <, not <=, for optimization.
4778 (Fcall_interactively): Count the number of arguments produced,
4779 not the number of arguments given. This is simpler and lets GCC
4780 4.6.0 generate slightly better code.
4781
dae0cd48
PE
4782 * ftfont.c: Distingish more carefully between FcChar8 and char.
4783 The previous code passed unsigned char * to a functions like
4784 strlen and xstrcasecmp that expect char *, which does not
4785 conform to the C standard.
4786 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4787 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4788 char * when the C standard requires it.
4789
76032d70
PE
4790 * keyboard.c (read_char): Remove unused var.
4791
eb3f1cc8
PE
4792 * eval.c: Port to Windows vsnprintf (Bug#8435).
4793 Include <limits.h>.
4794 (SIZE_MAX): Define if the headers do not.
4795 (verror): Do not give up if vsnprintf returns a negative count.
4796 Instead, grow the buffer. This ports to Windows vsnprintf, which
4797 does not conform to C99. Problem reported by Eli Zaretskii.
4798 Also, simplify the allocation scheme, by avoiding the need for
4799 calling realloc, and removing the ALLOCATED variable.
4800
70476b54
PE
4801 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4802
12020a9e
PE
4803 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4804 But keep the doprint source code for now, as we might revamp it
4805 and use it again (Bug#8435).
ea6c7ae6
PE
4806 * lisp.h (doprnt): Remove.
4807 * Makefile.in (base_obj): Remove doprnt.o.
4808 * deps.mk (doprnt.o): Remove.
4809
5fdb398c
PE
4810 error: Print 32- and 64-bit integers portably (Bug#8435).
4811 Without this change, on typical 64-bit hosts error ("...%d...", N)
4812 was used to print both 32- and 64-bit integers N, which relied on
4813 undefined behavior.
4814 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4815 New macro.
4816 * lisp.h (error, verror): Mark as printf-like functions.
4817 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4818 Report overflow in size calculations when allocating printf buffer.
4819 Do not truncate output string at its first null byte.
4820 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4821 Truncate the output at a character boundary, since vsnprintf does not
4822 do that.
4823 * charset.c (check_iso_charset_parameter): Convert internal
4824 character to string before calling 'error', since %c now has the
4825 printf meaning.
4826 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4827 overflow when computing char to be passed to 'error'. Do not
4828 pass Lisp_Object to 'error'; pass the integer instead.
4829 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4830 formatted with plain %d.
4831
b189fa66
PE
4832 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4833
bff87ef0
PE
4834 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4835
7e2cac20
PE
4836 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4837
ce4d90b5
PE
4838 * xterm.c (x_catch_errors): Remove duplicate declaration.
4839
266c9547
PE
4840 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4841
79c49ad2
PE
4842 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4843
368f4090
JM
48442011-04-10 Jim Meyering <meyering@redhat.com>
4845
4846 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4847 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4848 return ssize_t not "int", and use size_t as the buffer length.
4849 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4850 * gnutls.h: Update declarations.
4851 * process.c (read_process_output): Use ssize_t, to match.
4852 (send_process): Likewise.
4853
a32d4040
CY
48542011-04-09 Chong Yidong <cyd@stupidchicken.com>
4855
4856 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4857
8546720e 48582011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4859
04f2d78b
CB
4860 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4861 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4862
8546720e
GM
4863 * xterm.c (handle_one_xevent):
4864 * xmenu.c (create_and_show_popup_menu):
4865 * xselect.c (x_decline_selection_request)
4866 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4867
0a2f5c1a 48682011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4869
4870 Fix some uses of `int' instead of EMACS_INT.
4871 * search.c (string_match_1, fast_string_match)
4872 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4873 (scan_buffer, find_next_newline_no_quit)
4874 (find_before_next_newline, search_command, Freplace_match)
4875 (Fmatch_data): Make some `int' variables be EMACS_INT.
4876
4877 * xdisp.c (display_count_lines): 3rd argument and return value now
4878 EMACS_INT. All callers changed.
4879 (pint2hrstr): Last argument is now EMACS_INT.
4880
4881 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4882 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4883 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4884 (decode_coding_utf_16, decode_coding_emacs_mule)
4885 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4886 (decode_coding_ccl, decode_coding_charset)
4887 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4888 (decode_coding_iso_2022, decode_coding_emacs_mule)
4889 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4890 <char_offset, last_offset>: Declare EMACS_INT.
4891 (encode_coding_utf_8, encode_coding_utf_16)
4892 (encode_coding_emacs_mule, encode_invocation_designation)
4893 (encode_designation_at_bol, encode_coding_iso_2022)
4894 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4895 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4896 Declare EMACS_INT.
4897 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4898 (encode_invocation_designation): Last argument P_NCHARS is now
4899 EMACS_INT.
4900 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4901 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4902
4903 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4904 All users changed.
4905
4906 * ccl.c (Fccl_execute_on_string): Declare some variables
4907 EMACS_INT.
4908
8546720e 49092011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4910
4911 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4912
4e19a977
CS
49132011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4914
4915 * process.c (Fformat_network_address): Doc fix.
4916
87302331
R
49172011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4918
4919 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4920
cbb59342
CY
49212011-04-08 Chong Yidong <cyd@stupidchicken.com>
4922
4923 * keyboard.c (read_char): Call Lisp function help-form-show,
4924 instead of using internal_with_output_to_temp_buffer.
4925 (Qhelp_form_show): New var.
e0d38eeb 4926 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4927
4928 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4929
4930 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4931
e67a13ab
CY
49322011-04-06 Chong Yidong <cyd@stupidchicken.com>
4933
04f2d78b
CB
4934 * process.c (Flist_processes): Remove to Lisp.
4935 (list_processes_1): Delete.
e67a13ab 4936
973f782d
EZ
49372011-04-06 Eli Zaretskii <eliz@gnu.org>
4938
7c106b1e
EZ
4939 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4940
973f782d
EZ
4941 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4942
41cf7d1a 49432011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4944
ca23cc88
PE
4945 Fix more problems found by GCC 4.6.0's static checks.
4946
f390e2d5
PE
4947 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4948
42eea0d0
PE
4949 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4950
b69769da 4951 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4952
f9541e84
PE
4953 * xdisp.c (vmessage): Mark as a printf-like function.
4954
13841b55
PE
4955 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4956
c136c10f
PE
4957 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4958
5e2d4a30
PE
4959 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4960 printf-like functions.
4961 (tiff_load): Add casts to remove these marks before passing them
4962 to system-supplied API.
4963
583f48b9
PE
4964 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4965
b25d760e
PE
4966 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4967 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4968 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4969 directly, rather than having caller test rule sign. This avoids
4970 some unnecessary tests.
4971 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4972 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4973 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4974
bc7b6697 4975 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4976 (xfont_open): Avoid unnecessary tests.
bc7b6697 4977
27ccc379
PE
4978 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4979
dcd5c89a
PE
4980 * composite.h, composite.c (composition_gstring_put_cache):
4981 Use EMACS_INT, not int, for length.
4982
b13a45c6
PE
4983 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4984 breaking out part of COMPOSITION_DECODE_RULE.
4985 (COMPOSITION_DECODE_RULE): Use it.
4986 * composite.c (get_composition_id): Remove unused local vars,
4987 by using the new macro.
4988
1e792e4d
PE
4989 * textprop.c (set_text_properties_1): Change while to do-while,
4990 since the condition is always true at first.
4991
dc6c6455 4992 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4993 (interval_deletion_adjustment): Return unsigned value.
4994 All uses changed.
dc6c6455 4995
aba7731a
PE
4996 * process.c (list_processes_1, create_pty, read_process_output):
4997 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4998 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4999 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5000 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5001 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5002
fdfc4bf3
PE
5003 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5004
fca8fe46 5005 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5006 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5007
06a0259a 5008 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5009 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5010 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5011
e7b9e80f
PE
5012 * print.c (print_error_message): Avoid int overflow.
5013
56201685
PE
5014 * font.c (font_list_entities): Redo for clarity,
5015 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5016
78834453 5017 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5018 (font_score): Avoid potential overflow in diff calculation.
78834453 5019
0bc0b309 5020 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5021 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5022
e610eaca
PE
5023 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5024
b895abce
PE
5025 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5026 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5027 can always succeed if overflow has undefined behavior.
5028
1f1d9321 5029 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5030 (wordify): Omit three unnecessary tests.
1f1d9321 5031
c59478bc
PE
5032 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5033 All callers changed. This avoids the need for an unused var.
5034
79b73827
PE
5035 * casefiddle.c (casify_region): Remove var that is set but not used.
5036
a4db5dfe
PE
5037 * dired.c (file_name_completion): Remove var that is set but not used.
5038
43aae36e
PE
5039 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5040
2a47c44d 5041 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5042 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5043
a37c69bf
PE
5044 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5045 Check for integer overflow on size calculations.
5046
328ab8e7
PE
5047 * buffer.c (Fprevious_overlay_change): Remove var that is set
5048 but not used.
5049
e5a2a5cb
PE
5050 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5051 Remove vars that are set but not used.
8d84a6eb 5052 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5053 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5054
a60e5f68
PE
5055 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5056
f661cb61 5057 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5058 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5059
f0397f5a
PE
5060 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5061 that are set but not used.
5062
8664db06 5063 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5064 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5065
6abdaa4a
PE
5066 * xselect.c (x_get_local_selection, x_handle_property_notify):
5067 Remove vars that are set but not used.
5068
0ce7538d 5069 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5070 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5071
9ae848fc
PE
5072 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5073 Remove var that is set but not used.
0b918413
PE
5074 (scroll_bar_windows_size): Now size_t, not int.
5075 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5076 Check for overflow.
9ae848fc 5077
a5a62657
PE
5078 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5079 (map_tty_color) [!defined MSDOS]: Likewise.
5080
5c5cdd39
PE
5081 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5082
66ebf983
PE
5083 * coding.c: Remove vars that are set but not used.
5084 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5085 All callers changed.
5086 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5087 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5088 (decode_coding_charset): Remove vars that are set but not used.
5089
1be4d761
PE
5090 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5091 that is set but not used.
5092
47553fa8
PE
5093 * print.c (print_object): Remove var that is set but not used.
5094
1f7196bf 5095 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5096 The gnulib version avoids calling malloc in the usual case,
5097 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5098 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5099 * filelock.c (current_lock_owner): Likewise.
5100 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5101 * sysdep.c: Include allocator.h, careadlinkat.h.
5102 (emacs_no_realloc_allocator): New static constant.
5103 (emacs_readlink): New function.
fdb61804
PE
5104 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5105 ../lib/careadlinkat.h.
d1fdcab7 5106
f84c17c7
SM
51072011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5108
5109 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5110 first non-nil return value).
5111
ef3862ad
JD
51122011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5113
5114 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5115 if not defined (Bug#8403).
5116
376a7006
JB
51172011-04-02 Juanma Barranquero <lekktu@gmail.com>
5118
5119 * xdisp.c (display_count_lines): Remove parameter `start',
5120 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5121 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5122 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5123 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5124 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5125 and thereabouts. All callers changed.
5126 (get_per_char_metric): Remove parameter `f', unused since
5127 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5128
6ca3801d
JM
51292011-04-02 Jim Meyering <meyering@redhat.com>
5130
5131 do not dereference NULL upon failed strdup
5132 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5133 (ns_get_family): Likewise.
5134
d8e2b5ba
JB
51352011-04-02 Juanma Barranquero <lekktu@gmail.com>
5136
5137 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5138
8c74fcbd
JD
51392011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5140
5141 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5142 later (Bug#8403).
5143
7200d79c
SM
51442011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5145
03408648 5146 Add lexical binding.
7200d79c 5147
03408648
SM
5148 * window.c (Ftemp_output_buffer_show): New fun.
5149 (Fsave_window_excursion):
5150 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5151
5152 * lread.c (lisp_file_lexically_bound_p): New function.
5153 (Fload): Bind Qlexical_binding.
5154 (readevalloop): Remove `evalfun' arg.
5155 Bind Qinternal_interpreter_environment.
5156 (Feval_buffer): Bind Qlexical_binding.
5157 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5158 Mark as dynamic.
5159 (syms_of_lread): Declare `lexical-binding'.
5160
5161 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5162
5163 * keyboard.c (eval_dyn): New fun.
5164 (menu_item_eval_property): Use it.
ca105506
SM
5165
5166 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5167
03408648
SM
5168 * fns.c (concat, mapcar1): Accept byte-code-functions.
5169
5170 * eval.c (Fsetq): Handle lexical vars.
5171 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5172 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5173 (FletX, Flet): Obey lexical binding.
5174 (Fcommandp): Handle closures.
5175 (Feval): New `lexical' arg.
5176 (eval_sub): New function extracted from Feval. Use it almost
5177 everywhere where Feval was used. Look up vars in lexical env.
5178 Handle closures.
5179 (Ffunctionp): Move from subr.el.
5180 (Ffuncall): Handle closures.
5181 (apply_lambda): Remove `eval_flags'.
5182 (funcall_lambda): Handle closures and new byte-code-functions.
5183 (Fspecial_variable_p): New function.
5184 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5185 but without exporting it to Lisp.
23aba0ea 5186
23aba0ea 5187 * doc.c (Fdocumentation, store_function_docstring):
03408648 5188 * data.c (Finteractive_form): Handle closures.
23aba0ea 5189
03408648
SM
5190 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5191 interactive spec.
ba83908c 5192
04f2d78b
CB
5193 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5194 New byte-codes.
03408648
SM
5195 (exec_byte_code): New function extracted from Fbyte_code to handle new
5196 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5197
03408648 5198 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5199
03408648 5200 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5201
e2abce01
JB
52022011-03-31 Juanma Barranquero <lekktu@gmail.com>
5203
5204 * xdisp.c (redisplay_internal): Fix prototype.
5205
63696a73 52062011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5207
63696a73 5208 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5209 (try_scrolling): Use it when setting scroll_limit.
5210 Limit scrolling to 100 screen lines.
63696a73
EZ
5211 (redisplay_window): Even when falling back on "recentering",
5212 position point in the window according to scroll-conservatively,
5213 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5214
5215 (try_scrolling): When point is above the window, allow searching
5216 as far as scroll_max, or one screenful, to compute vertical
5217 distance from PT to the scroll margin position. This prevents
5218 try_scrolling from unnecessarily failing when
5219 scroll-conservatively is set to a value slightly larger than the
5220 window height. Clean up the case of PT below the margin at bottom
5221 of window: scroll_max can no longer be INT_MAX. When aggressive
5222 scrolling is in use, don't let point enter the opposite scroll
5223 margin as result of the scroll.
5224 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5225 threshold of 100 lines for never-recentering scrolling.
5226
e4cc2dfc
JB
52272011-03-31 Juanma Barranquero <lekktu@gmail.com>
5228
5229 * dispextern.h (move_it_by_lines):
5230 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5231 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5232 (message_log_check_duplicate): Remove parameters `prev_bol' and
5233 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5234 (redisplay_internal): Remove parameter `preserve_echo_area',
5235 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5236
5237 * indent.c (Fvertical_motion):
5238 * window.c (window_scroll_pixel_based, Frecenter):
5239 Don't pass `need_y_p' to `move_it_by_lines'.
5240
1c470562
SM
52412011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5242
44f230aa
SM
5243 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5244 steal a few bits to be more compact.
5245 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5246 Remove unneeded casts.
5247
1c470562
SM
5248 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5249
888adce9
ZK
52502011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5251
5252 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5253 binding" message (bug#7967).
5254
f838ed7b
PE
52552011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5256
77861b95
PE
5257 Fix more problems found by GCC 4.6.0's static checks.
5258
de6dbc14
PE
5259 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5260 Remove unused local var.
5261
f838ed7b
PE
5262 * editfns.c (Fmessage_box): Remove unused local var.
5263
792c7b2b
PE
5264 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5265 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5266 Omit unused local vars.
c499e557 5267 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5268 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5269 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5270 Omit unused local var.
5271
ba0165e1
PE
5272 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5273 Don't assume string length fits in int.
32ad8845 5274 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5275 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5276
3c59b4c9
PE
5277 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5278 instead of alloca (Bug#8344).
5279
a3eed478 5280 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5281 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5282
eb4d412d
PE
5283 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5284
1658b401
PE
5285 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5286 concerns.
5287
5288 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5289
5290 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5291
9a2c6e05
PE
5292 * keyboard.c (syms_of_keyboard): Use the same style as later
5293 in this function when indexing through an array. This also
5294 works around GCC bug 48267.
5295
03d0a109
PE
5296 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5297
44f730c8
PE
5298 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5299
fe75f926
PE
5300 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5301 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5302
ffa8c828
PE
5303 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5304 This avoids undefined behavior on integer overflow, and is a bit
5305 more convenient anyway since it is compared to a size_t variable.
5306
c5101a77
PE
5307 Variadic C functions now count arguments with size_t, not int.
5308 This avoids an unnecessary limitation on 64-bit machines, which
5309 caused (substring ...) to crash on large vectors (Bug#8344).
5310 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5311 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5312 All variadic functions and their callers changed accordingly.
c5101a77
PE
5313 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5314 * data.c (arith_driver, float_arith_driver): Likewise.
5315 * editfns.c (general_insert_function): Likewise.
5316 * eval.c (struct backtrace.nargs, interactive_p)
5317 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5318 (funcall_lambda, mark_backtrace): Likewise.
5319 * fns.c (concat): Likewise.
5320 * frame.c (x_set_frame_parameters): Likewise.
5321 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5322 0 if not found, not -1. All callers changed.
5323
dd3f25f7
PE
5324 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5325 (stack_copy_size): Now size_t, not int.
5326 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5327
461c2ab9
JB
53282011-03-28 Juanma Barranquero <lekktu@gmail.com>
5329
5330 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5331 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5332 All callers changed.
5333
5334 * lisp.h (multibyte_char_to_unibyte):
5335 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5336 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5337 * character.h (CHAR_TO_BYTE8):
5338 * cmds.c (internal_self_insert):
5339 * editfns.c (general_insert_function):
5340 * keymap.c (push_key_description):
5341 * search.c (Freplace_match):
5342 * xdisp.c (message_dolog, set_message_1): All callers changed.
5343
f6d62986
SM
53442011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5345
5346 * keyboard.c (safe_run_hook_funcall): New function.
5347 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5348 don't set the hook to nil, but remove the offending function instead.
5349 (Qcommand_hook_internal): Remove, unused.
5350 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5351 Vcommand_hook_internal.
5352
5353 * eval.c (enum run_hooks_condition): Remove.
5354 (funcall_nil, funcall_not): New functions.
5355 (run_hook_with_args): Call each function through a `funcall' argument.
5356 Remove `cond' argument, now redundant.
5357 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5358 (Frun_hook_with_args_until_failure): Adjust accordingly.
5359 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5360
1db5b1ad
JB
53612011-03-28 Juanma Barranquero <lekktu@gmail.com>
5362
5363 * dispextern.h (string_buffer_position): Remove declaration.
5364
5365 * print.c (strout): Remove parameter `multibyte', unused since
5366 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5367
5368 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5369 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5370 All callers changed.
5371
5372 * w32.c (_wsa_errlist): Use braces for struct initializers.
5373
5374 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5375 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5376 All callers changed.
5377 (string_buffer_position): Likewise. Also, make static (it's never
5378 used outside xdisp.c).
5379 (cursor_row_p): Remove parameter `w', unused since
5380 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5381 (decode_mode_spec): Remove parameter `precision', introduced during
5382 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5383 All callers changed.
5384
5ffb62aa
JD
53852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5386
5387 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5388
461c2ab9 53892011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5390
5391 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5392 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5393 (ns_update_auto_hide_menu_bar): New functions.
5394 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5395 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5396 ns_constrain_all_frames.
5397 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5398 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5399
5c380ffb
JD
54002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5401
5402 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5403
9af30bdf
GM
54042011-03-27 Glenn Morris <rgm@gnu.org>
5405
5406 * syssignal.h: Replace RETSIGTYPE with void.
5407 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5408 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5409 Replace SIGTYPE with void everywhere.
5410 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5411 * s/template.h (SIGTYPE): Remove commented out definition.
5412
e2abce01
JB
54132011-03-26 Eli Zaretskii <eliz@gnu.org>
5414
5415 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5416 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5417
f868cd8a
JB
54182011-03-26 Juanma Barranquero <lekktu@gmail.com>
5419
59eb0929
JB
5420 * w32.c (read_unc_volume): Use parameter `henum', instead of
5421 global variable `wget_enum_handle'.
5422
5423 * keymap.c (describe_vector): Remove parameters `indices' and
5424 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5425 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5426
f868cd8a
JB
5427 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5428
5429 * keyboard.c (timer_check): Remove parameter `do_it_now',
5430 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5431 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5432 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5433
5434 * keyboard.c (read_char):
5435 * w32menu.c (w32_menu_display_help):
5436 * xmenu.c (show_help_event, menu_help_callback):
5437 Adjust calls to `show_help_echo'.
5438
5439 * gtkutil.c (xg_maybe_add_timer):
5440 * keyboard.c (readable_events):
5441 * process.c (wait_reading_process_output):
5442 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5443
5444 * insdel.c (adjust_markers_gap_motion):
5445 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5446 (gap_left, gap_right): Don't call it.
5447
2ecf6fdb
CY
54482011-03-25 Chong Yidong <cyd@stupidchicken.com>
5449
5450 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5451 incurred during fontification.
5452
6b1f9ba4
JB
54532011-03-25 Juanma Barranquero <lekktu@gmail.com>
5454
5455 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5456 (DEFVAR_PER_BUFFER): Don't pass it.
5457
5458 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5459 (scrolling_window): Don't pass it.
5460
0f4a96b5
JB
54612011-03-25 Juanma Barranquero <lekktu@gmail.com>
5462
5463 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5464
5465 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5466 and `suffix'.
5467 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5468 of variables specific to SELinux and computation of `encoded_absname'.
5469
5470 * image.c (XPutPixel): Remove unused variable `height'.
5471
5472 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5473
5474 * unexw32.c (get_section_info): Remove unused variable `section'.
5475
5476 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5477 (system_process_attributes): Remove unused variable `sess'.
5478 (sys_read): Remove unused variable `err'.
5479
5480 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5481 (w32_wnd_proc): Remove unused variable `isdead'.
5482 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5483 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5484 (x_create_tip_frame): Remove unused variable `tem'.
5485
5486 * w32inevt.c (w32_console_read_socket):
5487 Remove unused variable `no_events'.
5488
5489 * w32term.c (x_draw_composite_glyph_string_foreground):
5490 Remove unused variable `width'.
5491
1149507c
JB
54922011-03-24 Juanma Barranquero <lekktu@gmail.com>
5493
5494 * w32term.c (x_set_glyph_string_clipping):
5495 Don't pass uninitialized region to CombineRgn.
5496
9c88f339
JB
54972011-03-23 Juanma Barranquero <lekktu@gmail.com>
5498
5499 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5500 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5501 (Fx_close_connection): Remove unused variable `i'.
5502
5503 * w32font.c (w32font_draw): Return number of glyphs.
5504 (w32font_open_internal): Remove unused variable `i'.
5505 (w32font_driver): Add missing initializer.
5506
5507 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5508 (fill_in_menu): Remove unused variable `items_added'.
5509
5510 * w32term.c (last_mouse_press_frame): Remove static global variable.
5511 (w32_clip_to_row): Remove unused variable `f'.
5512 (x_delete_terminal): Remove unused variable `i'.
5513
5514 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5515 (NOTHING): Remove unused static global variable.
5516 (uniscribe_check_otf): Remove unused variable `table'.
5517 (uniscribe_font_driver): Add missing initializers.
5518
dee091a3
JD
55192011-03-23 Julien Danjou <julien@danjou.info>
5520
5521 * term.c (Fsuspend_tty, Fresume_tty):
5522 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5523 * window.c (temp_output_buffer_show):
5524 * insdel.c (signal_before_change):
5525 * frame.c (Fhandle_switch_frame):
5526 * fileio.c (Fdo_auto_save):
5527 * emacs.c (Fkill_emacs):
5528 * editfns.c (save_excursion_restore):
5529 * cmds.c (internal_self_insert):
5530 * callint.c (Fcall_interactively):
5531 * buffer.c (Fkill_all_local_variables):
5532 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5533 Use Frun_hooks.
0f4a96b5 5534 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5535 unconditionnaly since it does the check itself.
5536
2c520ab5 55372011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5538
c9c49752
PE
5539 Fix more problems found by GCC 4.5.2's static checks.
5540
8abc3f12
PE
5541 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5542 the first time through the loop, since we know p0 < p1 then.
5543 This also avoids a gcc -Wstrict-overflow warning.
5544
a2d26660
PE
5545 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5546 leading to a memory leak, possible in functions like
5547 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5548 of objects (Bug#8318).
a2d26660 5549
916c72e9
PE
5550 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5551 that could (at least in theory) be that large.
5552
19ab8a18
PE
5553 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5554 This is less likely to overflow, and avoids undefined behavior if
5555 overflow does occur. All callers changed. Use strtoul to scan
5556 for the unsigned long integer.
b7cbbd6f
PE
5557 (pint2hrstr): Simplify and tune code slightly.
5558 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5559
f0641eff
PE
5560 * scroll.c (do_scrolling): Work around GCC bug 48228.
5561 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5562
7f650bb9
PE
5563 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5564 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5565 (validate_x_resource_name): Simplify count usage.
5566 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5567
37dd57d1
PE
5568 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5569 fail (Bug#8306).
81e56e61 5570
699979fc 5571 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5572
401bf9b4
PE
5573 * process.c (Fmake_network_process): Use socklen_t, not int,
5574 where POSIX says socklen_t is required in portable programs.
5575 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5576 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5577 (Fmake_network_process, server_accept_connection):
5578 (wait_reading_process_output, read_process_output):
5579 Likewise.
5580
b93aacde
PE
5581 * process.c: Rename or move locals to avoid shadowing.
5582 (list_processes_1, Fmake_network_process):
5583 (read_process_output_error_handler, exec_sentinel_error_handler):
5584 Rename or move locals.
4dc343ee 5585 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5586 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5587 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5588 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5589 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5590
af8a867c 5591 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5592 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5593 Include tparam.h instead, since it declares them.
af8a867c
PE
5594 * cm.h (PC): Remove extern decl; tparam.h now does this.
5595 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5596 * terminfo.c: Include tparam.h, to check interfaces.
5597 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5598 (tparam): Adjust signature to match interface in tparam.h;
5599 this removes some undefined behavior. Check that outstring and len
5600 are zero, which they always are with Emacs.
5601 * tparam.h (PC, BC, UP): New extern decls.
5602
0248044d 5603 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5604 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5605
8ff096c1 5606 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5607 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5608 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5609 (ftfont_list): Remove unused local.
49eaafba
PE
5610 (get_adstyle_property, ftfont_pattern_entity):
5611 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5612 Rename locals to avoid shadowing.
8ff096c1 5613
e2be39f6
PE
5614 * xfont.c (xfont_list_family): Mark var as initialized.
5615
c9735e30
PE
5616 * xml.c (make_dom): Now static.
5617
8f5201ae
PE
5618 * composite.c (composition_compute_stop_pos): Rename local to
5619 avoid shadowing.
b246f932
PE
5620 (composition_reseat_it): Remove unused locals.
5621 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5622 (composition_update_it): Mark var as initialized.
11b61122
PE
5623 (find_automatic_composition): Mark vars as initialized,
5624 with a FIXME (Bug#8290).
8f5201ae 5625
760fbc2c
PE
5626 character.h: Rename locals to avoid shadowing.
5627 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5628 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5629 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5630 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5631 to avoid shadowing.
5632
ff08eb85
PE
5633 * textprop.c (property_change_between_p): Remove; unused.
5634
fc7bf025
PE
5635 * intervals.c (interval_start_pos): Now static.
5636
235d7abc
PE
5637 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5638
44f230aa
SM
5639 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5640 Rename locals to avoid shadowing.
3e7d6594 5641
50060332
PE
5642 * sound.c (wav_play, au_play, Fplay_sound_internal):
5643 Fix pointer signedness.
d01f234b 5644 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5645 (wav_play): Initialize a variable to 0, to prevent undefined
5646 behavior (Bug#8278).
50060332 5647
c4fc4e30
PE
5648 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5649
918436ed
PE
5650 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5651
c939f91b
PE
5652 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5653 clobbering (Bug#8298).
b9c7f648
PE
5654 * sysdep.c (sys_subshell): Likewise.
5655 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5656
6bd8c144
PE
5657 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5658 This should get cleaned up, so that child_setup has the
5659 same signature on all platforms.
5660
7710357c 5661 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5662 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5663
c59da222
CY
56642011-03-22 Chong Yidong <cyd@stupidchicken.com>
5665
5666 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5667 not to be necessary, and produces flickering.
5668
66b87493
GM
56692011-03-20 Glenn Morris <rgm@gnu.org>
5670
5671 * config.in: Remove file.
5672
45b6f6d5
JB
56732011-03-20 Juanma Barranquero <lekktu@gmail.com>
5674
5675 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5676 are now in src/globals.h.
5677 (syms_of_minibuf): Remove spurious & from previous change.
5678
3ec03f7e
LL
56792011-03-20 Leo <sdl.web@gmail.com>
5680
5681 * minibuf.c (completing-read-function): New variable.
5682 (completing-read-default): Rename from completing-read.
5683 (completing-read): Call completing-read-function.
5684
b14e3e21
CY
56852011-03-19 Juanma Barranquero <lekktu@gmail.com>
5686
5687 * xfaces.c (Fx_load_color_file):
5688 Read color file from absolute filename (bug#8250).
5689
f2b726e6
JB
56902011-03-19 Juanma Barranquero <lekktu@gmail.com>
5691
5692 * makefile.w32-in: Update dependencies.
5693
09f6ff02
EZ
56942011-03-17 Eli Zaretskii <eliz@gnu.org>
5695
5696 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5697
29a6015a
PE
56982011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5699
a3a6c54e
PE
5700 Fix more problems found by GCC 4.5.2's static checks.
5701
b766f867
PE
5702 * process.c (make_serial_process_unwind, send_process_trap):
5703 (sigchld_handler): Now static.
5704
be02381c
PE
5705 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5706 That way, the code declares only the vars that it needs.
5707 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5708 * s/cygwin.h (PTY_ITERATION): Likewise.
5709 * s/darwin.h (PTY_ITERATION): Likewise.
5710 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5711
57048744
PE
5712 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5713 * process.c (allocate_pty): Don't declare stb unless it's needed.
5714
7914961c 5715 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5716 (CONSTANTLIM): Remove; unused.
5717 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5718 Define only if needed.
7914961c 5719
b3967b18
PE
5720 * unexelf.c (unexec): Name an expression,
5721 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5722 Use a different way to cause a compilation error if anyone uses
5723 n rather than nn, a way that does not involve shadowing.
73366a00 5724 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5725
29a6015a
PE
5726 * deps.mk (unexalpha.o): Remove; unused.
5727
43cfc33e 5728 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5729 * unexec.h: New file.
ce701a33
PE
5730 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5731 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5732 Depend on unexec.h.
5733 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5734 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5735 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5736 Change as necessary to match prototype in unexec.h.
ce701a33 5737
01f44d5a
PE
5738 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5739 shadowing.
4f63c6bb 5740 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5741
a6670b0b
PE
5742 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5743 Rename locals to avoid shadowing.
5744
cef2010d 5745 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5746 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5747
d4d7173a
PE
5748 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5749
f08b802a
PE
5750 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5751 warning when compiling print.c.
5752
3ddb0639
PE
5753 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5754 instead of using an uninitialized var.
5ad03b97 5755 (font_sort_entities): Mark var as initialized.
3ddb0639 5756
170a2692
PE
5757 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5758
e663c700
PE
5759 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5760 pointers to constants.
89bc529a 5761 (font_parse_fcname): Remove unused vars.
7b81e2d0 5762 (font_delete_unmatched): Now static.
ea838e10 5763 (font_get_spec): Remove; unused.
13a547c6
PE
5764 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5765 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5766 Rename or move locals to avoid shadowing.
e663c700 5767
2a80c887 5768 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5769 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5770
1384fa33 5771 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5772 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5773
8b2c52e9
PE
5774 * alloc.c (mark_backtrace): Move decl from here ...
5775 * lisp.h: ... to here, so that it can be checked.
5776
475545b5 5777 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5778 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5779 (lisp_indirect_variable): Name an expression,
5780 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5781 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5782
b1349114 5783 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5784 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5785 Use const pointer when appropriate.
b1349114 5786
a2928364
PE
5787 * lisp.h (get_system_name, get_operating_system_release):
5788 Move decls here, to check interfaces.
5789 * process.c (get_operating_system_release): Move decl to lisp.h.
5790 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5791 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5792 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5793 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5794 (Fformat_time_string, Fencode_time, Finsert_char):
5795 (Ftranslate_region_internal, Fformat):
5796 Rename or remove local vars to avoid shadowing.
9710023e 5797 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5798
a415e694
PE
5799 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5800 avoid shadowing.
5801
8ef4622d
PE
5802 * lisp.h (eassert): Check that the argument compiles, even if
5803 ENABLE_CHECKING is not defined.
5804
946f9a5b
PE
5805 * data.c (Findirect_variable): Name an expression, to avoid
5806 gcc -Wbad-function-cast warning.
112396d6 5807 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5808 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5809 (Fmake_variable_buffer_local, Fmake_local_variable):
5810 Mark variables as initialized.
52746918 5811 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5812
e5aab7e7 5813 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5814 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5815 Rename locals to avoid shadowing.
dff45157
PE
5816 (mark_stack): Move local variables into the #ifdef region where
5817 they're used.
7bc26fdb
PE
5818 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5819 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5820 needed otherwise.
5821 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5822 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5823 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5824
e5aab7e7
PE
5825 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5826 avoids undefined behavior in theory.
5827
4da60324
PE
5828 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5829
88043301
PE
5830 Use functions, not macros, for up- and down-casing (Bug#8254).
5831 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5832 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5833 to use the following functions instead of these macros.
5834 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5835 EMACS_INT, since callers assume the returned value fits in int.
5836 (upcase1): Likewise, for UPCASE_TABLE.
5837 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5838 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5839 the race-condition problem in the old DOWNCASE.
88043301 5840
19ed5445
PE
5841 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5842 Rename locals to avoid shadowing.
5843 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5844 (regex_compile, re_search_2, re_match_2_internal):
5845 Remove unused local vars.
952db0d7
PE
5846 (FREE_VAR): Rewrite so as not to use empty "else",
5847 which gcc can warn about.
da053e48 5848 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5849 (RETALLOC_IF): Define only if needed.
5850 (WORDCHAR_P): Likewise. This one is never needed, but is used
5851 only in a comment talking about a compiler bug, so put inside
5852 the #if 0 of that comment.
5853 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5854 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5855 Remove; unused.
19ed5445 5856
1f3561e4 5857 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5858 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5859 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5860
ded6f8f7
PE
5861 * search.c (simple_search): Remove unused var.
5862
dbd37a95
PE
5863 * dired.c (compile_pattern): Move decl from here ...
5864 * lisp.h: ... to here, so that it can be checked.
5865 (struct re_registers): New forward decl.
5866
7e47afad
PE
5867 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5868
85f24f61
PE
5869 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5870 All uses changed.
5871 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5872 Rename locals to avoid shadowing.
5671df8f 5873 (Fvertical_motion): Mark locals as initialized.
85f24f61 5874
181aa2be 5875 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5876 (casify_region): Mark local as initialized.
181aa2be 5877
930d429c
PE
5878 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5879
7082eac6
PE
5880 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5881 New macros, so that the caller can use some names other than
5882 gcpro1, gcpro2, etc.
5883 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5884 of the new macros.
5885 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5886 argument, for consistency with GCPRO2_VAR, etc: it is now the
5887 prefix of the variable, not the variable itself. All uses
5888 changed.
38b2c076
PE
5889 * dired.c (directory_files_internal, file_name_completion):
5890 Rename locals to avoid shadowing.
5891
15206ed9
PE
5892 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5893 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5894 dired.c's scmp function, had undefined behavior.
5895 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5896 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5897 * buffer.h: ... to here, because these macros use current_buffer,
5898 and the new implementation with inline functions needs to have
5899 current_buffer in scope now, rather than later when the macros
5900 are used.
5901 (downcase, upcase1): New static inline functions.
5902 (DOWNCASE, UPCASE1): Reimplement using these functions.
5903 This avoids undefined behavior in expressions like
5904 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5905 from race conditions in accessing the global variables
5906 case_temp1 and case_temp2.
5907 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5908 * lisp.h (case_temp1, case_temp2): Remove their decls.
5909 * character.h (ASCII_CHAR_P): Move from here ...
5910 * lisp.h: ... to here, so that the inline functions mentioned
5911 above can use them.
5912
4a6bea26
PE
5913 * dired.c (directory_files_internal_unwind): Now static.
5914
f14b7e14
PE
5915 * fileio.c (file_name_as_directory, directory_file_name):
5916 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5917 Now static.
2893f146
PE
5918 (file_name_as_directory): Use const pointers when appropriate.
5919 (Fexpand_file_name): Likewise. In particular, newdir might
5920 point at constant storage, so make it a const pointer.
fd4ead52 5921 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5922 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5923 signedness issues.
f839df0c
PE
5924 (Fset_file_times, Finsert_file_contents, auto_save_error):
5925 Rename locals to avoid shadowing.
f14b7e14 5926
5716756e 5927 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5928 (Ftry_completion, Fall_completions): Rename or remove locals
5929 to avoid shadowing.
5716756e 5930
b4c3046a
PE
5931 * marker.c (bytepos_to_charpos): Remove; unused.
5932
b45db522
PE
5933 * lisp.h (verify_bytepos, count_markers): New decls,
5934 so that gcc does not warn that these functions aren't declared.
5935
85876d07
PE
5936 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5937 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5938 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5939 (copy_text): Remove unused local var.
85876d07 5940
03d78a21 5941 * filelock.c (within_one_second): Now static.
b3dd38ab 5942 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5943
5df8f01b
PE
5944 * buffer.c (fix_overlays_before): Mark locals as initialized.
5945 (fix_start_end_in_overlays): Likewise. This function should be
5946 simplified by using pointers-to-pointers, but that's a different
5947 matter.
b1d876f1 5948 (switch_to_buffer_1): Now static.
8f54f30a
PE
5949 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5950 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5951
a70072c9 5952 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5953 Fix pointer signedness issue.
edced198
PE
5954 (sys_subshell): Mark local as volatile if checking for lint,
5955 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5956 (MAXPATHLEN): Define only if needed.
a70072c9 5957
a0977c44
PE
5958 * process.c (serial_open, serial_configure): Move decls from here ...
5959 * systty.h: ... to here, so that they can be checked.
5960
a884fdcc
PE
5961 * fns.c (get_random, seed_random): Move extern decls from here ...
5962 * lisp.h: ... to here, so that they can be checked.
5963
604efe86 5964 * sysdep.c (reset_io): Now static.
b8950c94 5965 (wait_for_termination_signal): Remove; unused.
604efe86 5966
38fc62d9
PE
5967 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5968 (copy_keymap_item, append_key, push_text_char_description):
5969 Now static.
1004a21a 5970 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5971 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5972 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5973 (describe_map_tree):
5974 Rename locals to avoid shadowing.
38fc62d9 5975
2f2650da
PE
5976 * keyboard.c: Declare functions static if they are not used elsewhere.
5977 (echo_char, echo_dash, cmd_error, top_level_2):
5978 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5979 (read_char, kbd_buffer_get_event, make_lispy_position):
5980 (make_lispy_event, make_lispy_movement, apply_modifiers):
5981 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5982 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5983 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5984 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5985 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5986
a053e86c 5987 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5988 (mark_kboards): Move decl here ...
5989 * alloc.c (mark_kboards): ... from here.
a053e86c 5990
4752793e
PE
5991 * lisp.h (force_auto_save_soon): New decl.
5992
74f10ca7 5993 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5994 (DEFINE_DUMMY_FUNCTION): New macro.
5995 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5996 Use it.
c03cd23f
PE
5997 (main): Add casts to avoid warnings
5998 if GCC considers string literals to be constants.
74f10ca7 5999
022e70d4
PE
6000 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6001
59d6fe83
PE
6002 * dbusbind.c: Pointer signedness fixes.
6003 (xd_signature, xd_append_arg, xd_initialize):
6004 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6005 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6006 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6007 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6008
78320123
PE
6009 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6010 if GCC considers string literals to be constants.
49cebcca 6011 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6012
35ac2a97
SM
60132011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6014
fb103ca9
SM
6015 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6016 (print_preprocess, print_object): New macro to fix last change.
6017
35ac2a97
SM
6018 * print.c (print_preprocess): Don't forget font objects.
6019
62973b41
JB
60202011-03-16 Juanma Barranquero <lekktu@gmail.com>
6021
6022 * emacs.c (USAGE3): Doc fixes.
6023
0e48bb22
AS
60242011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6025
6026 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6027 structure.
6028
7684e57b
JB
60292011-03-14 Juanma Barranquero <lekktu@gmail.com>
6030
6031 * lisp.h (VWindow_system, Qfile_name_history):
6032 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6033 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6034 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6035
6036 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6037 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6038
6039 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6040 * w32console.c (detect_input_pending, read_input_pending)
6041 (encode_terminal_code):
6042 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6043 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6044 (w32_system_caret_y, Qfile_name_history):
6045 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6046 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6047 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6048 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6049 * w32proc.c (Qlocal, report_file_error):
6050 * w32term.c (Vwindow_system, updating_frame):
6051 * w32uniscribe.c (initialized, uniscribe_font_driver):
6052 Remove unneeded extern declarations.
6053
2aa46d6c
CY
60542011-03-14 Chong Yidong <cyd@stupidchicken.com>
6055
c96bbc66 6056 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6057
cffc6f3b
CY
60582011-03-13 Chong Yidong <cyd@stupidchicken.com>
6059
6060 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6061 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6062 These macros can no longer be used for assignment.
6063
44f230aa
SM
6064 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6065 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6066 (record_buffer_markers, fetch_buffer_markers): New functions for
6067 recording and fetching special buffer markers.
6068 (set_buffer_internal_1, set_buffer_temp): Use them.
6069
6070 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6071
6072 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6073
6074 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6075 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6076
6077 * xdisp.c (hscroll_window_tree):
6078 (reconsider_clip_changes): Use PT instead of BUF_PT.
6079
d251f04b
EZ
60802011-03-13 Eli Zaretskii <eliz@gnu.org>
6081
6082 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6083 $(EMACS_ROOT)/lib/intprops.h.
6084
f0c77cd1
PE
60852011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6086
3eca4629
PE
6087 Fix more problems found by GCC 4.5.2's static checks.
6088
7c86ee98
PE
6089 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6090 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6091 (xg_free_frame_widgets): Make it clear that a local variable is
6092 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6093 (gdk_window_get_screen): Make it clear that this macro is needed
6094 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6095 (int_gtk_range_get_value): New function, which avoids a diagnostic
6096 from gcc -Wbad-function-cast.
6097 (xg_set_toolkit_scroll_bar_thumb): Use it.
6098 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6099 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6100 (get_utf8_string, xg_get_file_with_chooser):
6101 Rename locals to avoid shadowing.
6102 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6103
41729b81
PE
6104 * xgselect.c (xg_select): Remove unused var.
6105
f0c77cd1
PE
6106 * image.c (four_corners_best): Mark locals as initialized.
6107 (gif_load): Initialize transparent_p to zero (Bug#8238).
6108 Mark another local as initialized.
ec6cf4c6 6109 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6110
ce0ad53d 6111 * image.c (clear_image_cache): Now static.
d5d5a617 6112 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6113 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6114 (x_edge_detection): Remove unnecessary cast that
6115 gcc -Wbad-function-cast diagnoses.
2037898d 6116 (gif_load): Fix pointer signedness.
6ae141d6
PE
6117 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6118 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6119
33383987 61202011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6121
d32df629
PE
6122 Improve quality of tests for time stamp overflow.
6123 For example, without this patch (encode-time 0 0 0 1 1
6124 1152921504606846976) returns the obviously-bogus value (-948597
6125 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6126 reports time overflow. See
6127 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6128 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6129 * editfns.c: Include limits.h and intprops.h.
6130 (TIME_T_MIN, TIME_T_MAX): New macros.
6131 (time_overflow): Move earlier, to before first use.
6132 (hi_time, lo_time): New functions, for an accurate test for
6133 out-of-range times.
6134 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6135 (Fget_internal_run_time): Don't assume time_t fits in int.
6136 (make_time): Use list2 instead of Fcons twice.
6137 (Fdecode_time): More accurate test for out-of-range times.
6138 (check_tm_member): New function.
6139 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6140 (lisp_time_argument): Don't rely on undefined left-shift and
6141 right-shift behavior when checking for time stamp overflow.
8be6f318 6142
fe31d94c
PE
6143 * editfns.c (time_overflow): New function, refactoring common code.
6144 (Fformat_time_string, Fdecode_time, Fencode_time):
6145 (Fcurrent_time_string): Use it.
6146
8be6f318
PE
6147 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6148 * dired.c (make_time): Move to ...
6149 * editfns.c (make_time): ... here.
6150 * systime.h: Note the move.
6151
09d9db2c 61522011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6153
126bc0dc
YM
6154 * fringe.c (update_window_fringes): Remove unused variables.
6155
c47cbdfd
YM
6156 * unexmacosx.c (copy_data_segment): Also copy __got section.
6157 (Bug#8223)
6158
7ac80be9
EZ
61592011-03-12 Eli Zaretskii <eliz@gnu.org>
6160
c96bbc66 6161 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6162 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6163 Constify `char *' arguments and their references according to
6164 prototypes in tparam.h.
6165
ecb0f94d 6166 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6167
7ac80be9
EZ
6168 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6169 Adapt all references accordingly.
6170
6171 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6172
ef1fd07e
TT
61732011-03-11 Tom Tromey <tromey@redhat.com>
6174
6175 * buffer.c (syms_of_buffer): Remove obsolete comment.
6176
7ef4b50c
EZ
61772011-03-11 Eli Zaretskii <eliz@gnu.org>
6178
6179 * termhooks.h (encode_terminal_code): Declare prototype.
6180
6181 * msdos.c (encode_terminal_code): Don't declare prototype.
6182
6183 * term.c (encode_terminal_code): Now external again, used by
6184 w32console.c and msdos.c.
6185
44f230aa
SM
6186 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6187 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6188
4b1ec863 61892011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6190
1714f52b 6191 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6192
4b1ec863
PE
6193 * fringe.c (update_window_fringes): Mark locals as initialized
6194 (Bug#8227).
6195 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6196
524c7aa6
PE
6197 * alloc.c (mark_fringe_data): Move decl from here ...
6198 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6199 to check its interface.
6200 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6201
a5c0af81 6202 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6203 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6204 (fontset_font): Mark local as initialized.
a9a06e0b 6205 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6206
b4716021
PE
6207 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6208
811e9bac 6209 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6210 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6211 (x_own_selection, Fx_disown_selection_internal): Rename locals
6212 to avoid shadowing.
6213 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6214
7e3ab302
PE
6215 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6216 so that the caller can use some name other than gcpro1.
6217 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6218 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6219 (Fx_backspace_delete_keys_p):
6220 Use them to avoid shadowing, and rename vars to avoid shadowing.
6221 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6222 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6223 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6224 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6225 Remove unused locals.
7e3ab302
PE
6226 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6227 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6228 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6229 macros.
f78faa98 6230
e2b13473
PE
6231 * xterm.h (x_mouse_leave): New decl.
6232
77f23912
PE
6233 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6234 Remove unused functions.
cdf4ba58
PE
6235 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6236 (x_calc_absolute_position): Now static.
7411c686 6237 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6238 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6239 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6240 unless they are used.
38d0b34a
PE
6241 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6242 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6243 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6244 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6245 (x_error_catcher, x_connection_closed, x_error_handler):
6246 (x_error_quitter, xembed_send_message, x_iconify_frame):
6247 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6248 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6249 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6250
44f230aa
SM
6251 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6252 Rename or move locals to avoid shadowing.
6b463e58 6253 (tty_defined_color, merge_face_heights): Now static.
5967d051 6254 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6255 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6256 does not deduce is never used uninitialized.
73719eba
PE
6257 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6258 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6259
426994c3 6260 * terminal.c (store_terminal_param): Now static.
5489860b 6261
032f1620 6262 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6263 (set_frame_menubar): Remove unused local.
d4323972 6264 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6265 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6266 since they might point to immutable storage.
281585b0
PE
6267 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6268 since it's unused otherwise.
032f1620 6269
367c19e5 6270 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6271 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6272 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6273 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6274 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6275 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6276 does not deduce are never used uninitialized.
70739cbe 6277
07b48fa9
PE
6278 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6279
8868a238 6280 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6281 * window.c (window_loop, size_window):
6282 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6283
7e5cf297 6284 * window.c (display_buffer): Now static.
d6550a9f
PE
6285 (size_window): Mark variables that gcc -Wuninitialized
6286 does not deduce are never used uninitialized.
a586633d
PE
6287 * window.h (check_all_windows): New decl, to forestall
6288 gcc -Wmissing-prototypes diagnostic.
5b555da1 6289 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6290
f6095868
PE
6291 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6292 shadowing.
6293 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6294 Include <limits.h>.
6295 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6296 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6297 (load_charset_map): Mark variables that gcc -Wuninitialized
6298 does not deduce are never used uninitialized.
53df7c11 6299 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6300
f38b440c
PE
6301 * coding.c (coding_set_source, coding_set_destination):
6302 Use "else { /* comment */ }" rather than "else /* comment */;"
6303 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6304 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6305 a block, when the outer 'i' will do.
6306 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6307 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6308 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6309 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6310 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6311 Rename locals to avoid shadowing.
6312 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6313 * coding.c (emacs_mule_char, encode_invocation_designation):
6314 Now static, since they're not used elsewhere.
413bb2db 6315 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6316 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6317 (decode_coding_emacs_mule): Mark variables that gcc
6318 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6319 (detect_coding_iso_2022): Initialize a local variable that might
6320 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6321 this initialization is needed. (Bug#8211)
5f58e762
PE
6322 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6323 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6324 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6325 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6326 Remove unused macros.
f38b440c 6327
232b38b9 6328 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6329 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6330 * character.c (string_count_byte8): Likewise.
232b38b9 6331
fb90da1b
PE
6332 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6333 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6334
fb93dbc2
PE
6335 * chartab.c (copy_sub_char_table): Now static, since it's not used
6336 elsewhere.
5c156ace
PE
6337 (sub_char_table_ref_and_range, char_table_ref_and_range):
6338 Rename locals to avoid shadowing.
bbcd0949 6339 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6340
7d3b3862 6341 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6342 (BIDI_BOB): Remove unused macro.
7d3b3862 6343
6be7d3da
PE
6344 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6345 deduce are never used uninitialized.
c2ed9c8b 6346 * term.c (encode_terminal_code): Likewise.
6be7d3da 6347
75f8807f 6348 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6349
50938595
PE
6350 * tparam.h: New file.
6351 * term.c, tparam.h: Include it.
6352 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6353 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6354 Move these decls to tparam.h, and make them agree with what
6355 is actually in tparam.c. The previous trick of using incompatible
6356 decls in different modules does not conform to the C standard.
6357 All callers of tparam changed to use tparam's actual API.
6358 * tparam.c (tparam1, tparam, tgoto):
6359 Use const pointers where appropriate.
6360
fbceeba2
PE
6361 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6362 * cm.h (struct cm): Likewise.
6363 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6364 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6365 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6366 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6367 (turn_on_face, init_tty): Likewise.
6368 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6369
7f3f1250
PE
6370 * term.c (term_mouse_position): Rename local to avoid shadowing.
6371
e6ca6543
PE
6372 * alloc.c (mark_ttys): Move decl from here ...
6373 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6374
c40f8d15
AS
63752011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6376
6377 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6378
cfe0661d
JB
63792011-03-09 Juanma Barranquero <lekktu@gmail.com>
6380
6381 * search.c (compile_pattern_1): Remove argument regp, unused since
6382 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6383 (compile_pattern): Don't pass it.
6384
0afb4571
J
63852011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6386
6387 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6388 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6389 for ! HAVE_GTK3.
6390 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6391
6392 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6393
6394 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6395 gdk_window_get_screen, gdk_window_get_geometry,
6396 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6397 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6398 (xg_get_pixbuf_from_pixmap): New function.
6399 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6400 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6401 Call xg_get_pixbuf_from_pixmap instead of
6402 gdk_pixbuf_get_from_drawable.
6403 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6404 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6405 (xg_check_special_colors): Use GtkStyleContext and its functions
6406 for HAVE_GTK3.
6407 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6408 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6409 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6410 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6411 Call gtk_widget_get_preferred_size.
0afb4571
J
6412 (xg_frame_resized): gdk_window_get_geometry only takes 5
6413 parameters.
44f230aa
SM
6414 (xg_win_to_widget, xg_event_is_for_menubar):
6415 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6416 (xg_set_widget_bg): New function.
6417 (delete_cb): New function.
895009e1 6418 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6419 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6420 (xg_set_background_color): Call xg_set_widget_bg.
6421 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6422 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6423 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6424 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6425 if ! HAVE_GTK3.
6426 (update_frame_tool_bar): Call gtk_widget_hide.
6427 (xg_initialize): Use GDK_KEY_g.
6428
6429 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6430 if ! HAVE_GTK3
6431 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6432
6433 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6434 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6435 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6436
1c2cc4ef
JB
64372011-03-08 Juanma Barranquero <lekktu@gmail.com>
6438
6439 * w32xfns.c (select_palette): Check success of RealizePalette against
6440 GDI_ERROR, not zero.
6441
33383987 6442See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6443
6444;; Local Variables:
6445;; coding: utf-8
aac0c6e3
MR
6446;; End:
6447
33383987 6448 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6449
6450 This file is part of GNU Emacs.
6451
6452 GNU Emacs is free software: you can redistribute it and/or modify
6453 it under the terms of the GNU General Public License as published by
6454 the Free Software Foundation, either version 3 of the License, or
6455 (at your option) any later version.
6456
6457 GNU Emacs is distributed in the hope that it will be useful,
6458 but WITHOUT ANY WARRANTY; without even the implied warranty of
6459 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6460 GNU General Public License for more details.
6461
6462 You should have received a copy of the GNU General Public License
6463 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.