* src/xselect.c (x_convert_selection): Initialize a pointer.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9be2fd9b
CY
12012-04-24 Chong Yidong <cyd@gnu.org>
2
3 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4
f0ee99a0
EZ
52012-04-23 Eli Zaretskii <eliz@gnu.org>
6
7 * xdisp.c (pos_visible_p): If the window start position is beyond
8 ZV, start the display from buffer beginning. Prevents assertion
9 violation in init_iterator when the minibuffer window is scrolled
10 via the scroll bar.
11
12 * window.c (window_scroll_pixel_based): Likewise.
13
9ec7751f
CY
142012-04-23 Chong Yidong <cyd@gnu.org>
15
16 * keymap.c (where_is_internal): Doc fix (Bug#10872).
17
24c51a09
GM
182012-04-20 Glenn Morris <rgm@gnu.org>
19
20 * fileio.c (Fcopy_file, Fset_file_selinux_context):
21 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
22
73055685
EZ
232012-04-20 Eli Zaretskii <eliz@gnu.org>
24
25 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
26 overrun array limits of glyph row's used[] array. (Bug#11288)
27
f30d612a
CY
282012-04-20 Chong Yidong <cyd@gnu.org>
29
30 * process.c (wait_reading_process_output): If EIO occurs on a pty,
31 set the status to "failed" and ensure that sentinel is run.
32
016a35df
GM
332012-04-18 Glenn Morris <rgm@gnu.org>
34
35 * process.c (Fset_process_inherit_coding_system_flag)
36 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 37 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 38
20a68157
EZ
392012-04-17 Eli Zaretskii <eliz@gnu.org>
40
41 * xdisp.c (string_buffer_position_lim): Limit starting position to
42 BEGV.
43 (set_cursor_from_row): If called for a mode-line or header-line
44 row, return zero immediately.
45 (try_cursor_movement): If inside continuation line, don't back up
46 farther than the first row after the header line, if any. Don't
47 consider the header-line row as "partially visible", even if
48 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
49
ad3a2b41
AO
502012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
51
52 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
53
e63c261b
CY
542012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
55
56 * process.c (make_process):
57 * process.h: Add integer `gnutls_handshakes_tried' member to
58 process struct.
59
ad3a2b41
AO
60 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
61 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
62
63 * gnutls.c (gnutls_log_function2i): Convenience log function.
64 (emacs_gnutls_read): Use new log functions,
65 `gnutls_handshakes_tried' process member, and
66 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
67 attempts per process (connection).
68
e53357c4
EZ
692012-04-09 Eli Zaretskii <eliz@gnu.org>
70
71 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
72 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
73
aff67c82
JD
742012-04-09 Jan Djärv <jan.h.d@swipnet.se>
75
76 * nsterm.m (constrainFrameRect): Always constrain when there is only
77 one screen (Bug#10962).
78
2f8e16b2
EZ
792012-04-06 Eli Zaretskii <eliz@gnu.org>
80
81 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
82 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
83 about subtle differences between FETCH_CHAR* and STRING_CHAR*
84 macros related to unification of CJK characters. For the details,
85 see the discussion following the message here:
86 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
87
3d439cd1
CY
882012-04-04 Chong Yidong <cyd@gnu.org>
89
90 * keyboard.c (Vdelayed_warnings_list): Doc fix.
91
8bc53d00
EZ
922012-04-01 Eli Zaretskii <eliz@gnu.org>
93
94 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
95 instead of alloca. (Bug#11138)
96
3b0512a3
AS
972012-04-01 Andreas Schwab <schwab@linux-m68k.org>
98
99 * w32menu.c (is_simple_dialog): Properly check lisp types.
100 (Bug#11141)
101
8427ddd2
EZ
1022012-03-31 Eli Zaretskii <eliz@gnu.org>
103
979022ef
EZ
104 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
105 position we get to after a call to move_it_to fails the
106 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
107 only if we wind up in a string from display property. (Bug#11063)
108
a6b1c7cc
EZ
109 * window.c (Fdelete_other_windows_internal): Invalidate the row
110 and column information about mouse highlight, so that redisplay
111 restores it after reallocating the glyph matrices. (Bug#7464)
112
8427ddd2
EZ
113 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
114 string comes from a `display' text property, use the buffer
115 position of that property as if we actually saw that position in
116 the row's glyphs.
697ba24b
EZ
117 (move_it_by_lines): Remove the assertion that
118 "it->current_x == 0 && it->hpos == 0" which can be legitimately
119 violated when there's a before-string at the beginning of a line.
120 (Bug#11063)
8427ddd2 121
65a0a738
EZ
1222012-03-30 Eli Zaretskii <eliz@gnu.org>
123
124 * xdisp.c (append_space_for_newline): If the default face was
125 remapped, use the remapped face for the appended newline.
126 (extend_face_to_end_of_line): Use the remapped default face for
127 extending the face to the end of the line.
128 (display_line): Call extend_face_to_end_of_line when the default
129 face was remapped. (Bug#11068)
130
581355cc
EZ
1312012-03-29 Eli Zaretskii <eliz@gnu.org>
132
133 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
134
e8fc049f
SM
1352012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
136
137 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
138
4fb9a543
GM
1392012-03-27 Glenn Morris <rgm@gnu.org>
140
141 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
142 Doc fixes.
143
679910f1
KH
1442012-03-26 Kenichi Handa <handa@m17n.org>
145
146 * dispextern.h (struct glyph): Fix previous change. Change the
147 bit length of glyphless.ch to 25 (Bug#11082).
148
90d49b7f
CY
1492012-03-26 Chong Yidong <cyd@gnu.org>
150
151 * keyboard.c (Vselection_inhibit_update_commands): New variable.
152 (command_loop_1): Use it; inhibit selection update for
153 handle-select-window too (Bug#8996).
154
f514f6f0
FP
1552012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
156
e8fc049f 157 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 158
bf43fa51
KH
1592012-03-25 Kenichi Handa <handa@m17n.org>
160
161 * dispextern.h (struct glyph): Change the bit length of
162 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
163
8a0c01dd
EZ
1642012-03-24 Eli Zaretskii <eliz@gnu.org>
165
166 * s/ms-w32.h (tzname): Include time.h before redirecting to
167 _tzname. Fixes the MSVC build. (Bug#9960)
168
7d1c3a76
AS
1692012-03-24 Andreas Schwab <schwab@linux-m68k.org>
170
8ed79523
AS
171 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
172 characters.
173
7d1c3a76
AS
174 * xterm.c (XTread_socket): Only modify handling_signal if
175 !SYNC_INPUT. (Bug#11080)
176
e99a9b8b
EZ
1772012-03-23 Eli Zaretskii <eliz@gnu.org>
178
179 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
180 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
181 when fetching a multibyte character consumes more bytes than
182 CHAR_BYTES returns, due to unification of CJK characters in
183 string_char. (Bug#11073)
184
5063c0e1
TN
1852012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
186
187 * process.c (wait_reading_process_output): Handle pty disconnect
188 by refraining from sending oneself a SIGCHLD (bug#10933).
189
9f851fbd
CY
1902012-03-22 Chong Yidong <cyd@gnu.org>
191
192 * dispextern.h (struct it): New member string_from_prefix_prop_p.
193
5063c0e1 194 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
195 Mark string as coming from a prefix property.
196 (handle_face_prop): Use default face for prefix strings (Bug#4281).
197 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
198
fb5b8aca
CY
1992012-03-21 Chong Yidong <cyd@gnu.org>
200
201 * xfaces.c (Vface_remapping_alist): Doc fix.
202
62356a1b
EZ
2032012-03-20 Eli Zaretskii <eliz@gnu.org>
204
205 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
206 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
207 Doc fixes.
62356a1b 208
025de85b
CY
2092012-03-20 Chong Yidong <cyd@gnu.org>
210
211 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
212 to reflect default non-nil value of redisplay-dont-pause.
213
4827f94e
KH
2142012-03-19 Kenichi Handa <handa@m17n.org>
215
216 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
217 it fit in a valid range (Bug#11003).
218
e50a24a2
EZ
2192012-03-18 Eli Zaretskii <eliz@gnu.org>
220
221 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
222 that is not from display property, accept the row as a "cursor
223 row" if one of the string's character has a non-nil `cursor'
224 property. Fixes cursor positioning when there are newlines in
225 overlay strings, e.g. in icomplete.el. (Bug#11035)
226
9af5ed87
PE
2272012-03-12 Paul Eggert <eggert@cs.ucla.edu>
228
229 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
230
d1f55f16
CY
2312012-03-12 Chong Yidong <cyd@gnu.org>
232
233 * eval.c (inhibit_lisp_code): Rename from
234 inhibit_window_configuration_change_hook; move from window.c.
235
236 * xfns.c (unwind_create_frame_1, Fx_create_frame):
237 * window.c (run_window_configuration_change_hook)
238 (syms_of_window): Callers changed.
239
66c5eebd
CY
2402012-03-11 Chong Yidong <cyd@gnu.org>
241
413df973
CY
242 * keymap.c (Fkey_description): Doc fix (Bug#9700).
243
66c5eebd
CY
244 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
245
1de11f56
CY
2462012-03-10 Chong Yidong <cyd@gnu.org>
247
248 * frame.c (other_visible_frames): Don't assume the selected frame
249 is visible (Bug#10955).
250
cae07000
SM
2512012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
252
253 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
254
89c94350
JD
2552012-03-08 Jan Djärv <jan.h.d@swipnet.se>
256
257 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
258 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
259 zero (Bug#10954).
260
999dd333
GM
2612012-03-03 Glenn Morris <rgm@gnu.org>
262
01a6dcc8 263 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 264
de0100f2
EZ
2652012-03-02 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
268 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
269 (redisplay_window, next_element_from_string): Fix typos in
270 comments.
3e441275
EZ
271 (redisplay_window): Pass to move_it_vertically the margin in
272 pixels, not in screen lines.
de0100f2 273
96a72ee9
GM
2742012-03-02 Glenn Morris <rgm@gnu.org>
275
276 * buffer.c (buffer-list-update-hook): Doc fix.
277
312508d7
EZ
2782012-02-29 Eli Zaretskii <eliz@gnu.org>
279
280 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
281 push_it before setting up the iterator for the first overlay
282 string, even if we have an empty string loaded.
283 (next_overlay_string): If there's an empty string on the iterator
284 stack, pop the stack. (Bug#10903)
285
27f3c637
PE
2862012-02-25 Paul Eggert <eggert@cs.ucla.edu>
287
288 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
289 Suggested by Stefan Monnier in
290 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
291 * alloc.c (widen_to_Lisp_Object): New static function.
292 (mark_memory): Also mark Lisp_Objects by fetching pointer words
293 and widening them to Lisp_Objects. This would work even if
294 USE_LSB_TAG is defined and wide integers are used, which might
295 happen in a future version of Emacs.
296
3c9dfce6
CY
2972012-02-25 Chong Yidong <cyd@gnu.org>
298
fa74b241
CY
299 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
300 Doc fix.
301
3c9dfce6
CY
302 * xselect.c (Fx_selection_exists_p): Doc fix.
303 (x_clipboard_manager_save_all): Print an informative message
304 before saving to clipboard manager.
305
9486df08
CY
3062012-02-24 Chong Yidong <cyd@gnu.org>
307
308 * keyboard.c (process_special_events): Handle all X selection
309 requests in kbd_buffer, not just the next one (Bug#8869).
310
f01d3321
CY
3112012-02-23 Chong Yidong <cyd@gnu.org>
312
313 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
314 call when setting menu-bar-lines and tool-bar-lines parameters.
315 (unwind_create_frame_1): New helper function.
316
317 * window.c (inhibit_window_configuration_change_hook): New var.
318 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 319 (syms_of_window): Initialize it.
f01d3321 320
86b847b6
CY
3212012-02-22 Chong Yidong <cyd@gnu.org>
322
323 * xterm.c (x_draw_image_relief): Add missing type check for
324 Vtool_bar_button_margin (Bug#10743).
325
a59225b1
CY
3262012-02-21 Chong Yidong <cyd@gnu.org>
327
328 * fileio.c (Vfile_name_handler_alist): Doc fix.
329
330 * buffer.c (Fget_file_buffer): Protect against invalid file
331 handler return value.
332
310f5bd4
PE
3332012-02-20 Paul Eggert <eggert@cs.ucla.edu>
334
cb3a28cc
PE
335 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
336 when computing $valmask.
337
310f5bd4
PE
338 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
339 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
340 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
341 It's useless in that case, and it can cause problems on hosts
342 that allocate halves of EMACS_INT values separately.
343 Reported by Dan Horák. Diagnosed by Andreas Schwab in
344 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
345 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
346 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
347 it avoids undefined behavior on hosts where shifting right by more
348 than the word width has undefined behavior.
349
2375c96a
CY
3502012-02-19 Chong Yidong <cyd@gnu.org>
351
352 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
353 (Funhandled_file_name_directory, Ffile_name_as_directory)
354 (Fdirectory_file_name, Fexpand_file_name)
355 (Fsubstitute_in_file_name): Protect against invalid file handler
356 return values (Bug#10845).
357
3eb49e71
EZ
3582012-02-18 Eli Zaretskii <eliz@gnu.org>
359
360 * .gdbinit (pitx): Fix incorrect references to fields of the
361 iterator stack.
362
7b926f3f
CY
3632012-02-17 Chong Yidong <cyd@gnu.org>
364
365 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
366
11273115
PE
3672012-02-15 Paul Eggert <eggert@cs.ucla.edu>
368
369 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
370 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
371
c3a70e2b
CY
3722012-02-15 Chong Yidong <cyd@gnu.org>
373
374 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
375 marked as special. Also, starting docstrings with * is obsolete.
376
0ca43699
AS
3772012-02-13 Andreas Schwab <schwab@linux-m68k.org>
378
379 * gnutls.c (emacs_gnutls_write): Fix last change.
380
2e8f3c56
LI
3812012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
382
383 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
384 send_process.
385
af70074f
SM
3862012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
387
388 * keymap.c (Fsingle_key_description): Handle char ranges.
389
95986d52
CY
3902012-02-12 Chong Yidong <cyd@gnu.org>
391
afd83bd1
CY
392 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
393 as that creates a dangerous corner case.
394
95986d52
CY
395 * window.c (Fdelete_window_internal): Invalidate the mouse
396 highlight (Bug#9904).
397
bd7da63e
GM
3982012-02-12 Glenn Morris <rgm@gnu.org>
399
400 * xselect.c (Fx_own_selection_internal)
401 (Fx_get_selection_internal, Fx_disown_selection_internal)
402 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
403 * nsselect.m (Fx_own_selection_internal)
404 (Fx_disown_selection_internal, Fx_selection_exists_p)
405 (Fx_selection_owner_p, Fx_get_selection_internal):
406 Sync docs and argument specs with the xselect.c versions.
407
77abcbc2
LI
4082012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
409
410 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
411
90b671e2
EZ
4122012-02-11 Eli Zaretskii <eliz@gnu.org>
413
1c0ca0b7
EZ
414 * w32select.c (Fx_selection_exists_p): Sync doc string and
415 argument list with xselect.c. (Bug#10783)
416
417 * w16select.c (Fx_selection_exists_p): Sync doc string and
418 argument list with xselect.c. (Bug#10783)
90b671e2 419
49241268
GM
4202012-02-10 Glenn Morris <rgm@gnu.org>
421
422 * fns.c (Fsecure_hash): Doc fix.
423
f998bbe7 4242012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
425
426 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
427
0992bd9c
CY
4282012-02-07 Chong Yidong <cyd@gnu.org>
429
430 * buffer.c (Fbuffer_local_variables)
431 (buffer_lisp_local_variables): Handle unbound vars correctly;
432 don't let Qunbound leak into Lisp.
433
af008560
GM
4342012-02-07 Glenn Morris <rgm@gnu.org>
435
dd605cc4
GM
436 * image.c (Fimagemagick_types): Doc fix.
437
af008560
GM
438 * image.c (imagemagick-render-type): Change it from a lisp object
439 to an integer. Move the doc here from the lisp manual.
440 Treat all values not equal to 0 the same.
441
1449fa1d
CY
4422012-02-06 Chong Yidong <cyd@gnu.org>
443
444 * doc.c (store_function_docstring): Avoid applying docstring of
445 alias to base function (Bug#2603).
446
3723ec07
AS
4472012-02-04 Andreas Schwab <schwab@linux-m68k.org>
448
449 * .gdbinit (pp1, pv1): Remove redundant defines.
450 (pr): Use pp.
451
79c1cc1e
CY
4522012-02-04 Chong Yidong <cyd@gnu.org>
453
454 * nsterm.m: Declare a global (Bug#10694).
455
d7f29f8e
EZ
4562012-02-04 Eli Zaretskii <eliz@gnu.org>
457
cae07000
SM
458 * w32.c (get_emacs_configuration_options):
459 Include --enable-checking, if specified, in the return value.
d7f29f8e 460
3b95a6f9
MR
4612012-02-04 Martin Rudalics <rudalics@gmx.at>
462
463 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
464 after rounding frame sizes. (Bug#9723)
465
d6fa96a6
EZ
4662012-02-04 Eli Zaretskii <eliz@gnu.org>
467
468 * keyboard.c (adjust_point_for_property): Don't position point
469 before BEGV. (Bug#10696)
470
df0b2940
PE
4712012-02-03 Paul Eggert <eggert@cs.ucla.edu>
472
473 Handle overflow when computing char display width (Bug#9496).
474 * character.c (char_width): Return EMACS_INT, not int.
475 (char_width, c_string_width): Check for overflow when
476 computing the width; this is possible now that individual
477 characters can have unbounded width. Problem introduced
478 by merge from Emacs 23 on 2012-01-19.
479
6bee44d6
MA
4802012-02-02 Michael Albinus <michael.albinus@gmx.de>
481
482 * dbusbind.c (Fdbus_register_method): Mention the return value
483 :ignore in the docstring.
484
44f92739
GM
4852012-02-02 Glenn Morris <rgm@gnu.org>
486
1b9f60cc
GM
487 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
488
44f92739
GM
489 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
490 Unconditionally set to t. (Bug#10673)
491 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
492 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
493 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
494
c5d3843c
KH
4952012-02-02 Kenichi Handa <handa@m17n.org>
496
497 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
498 0, do not call append_composite_glyph.
499
159462d4 5002012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
501
502 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
503 NULL (Bug#6988).
504 (x_produce_glyphs): If the component of a composition is a null
505 string, set it->pixel_width to 1 to avoid zero-width glyph.
506
78cef877
EZ
5072012-02-01 Eli Zaretskii <eliz@gnu.org>
508
509 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
510 first 2 arguments are identical. This makes inserting large
511 output from a subprocess an order of magnitude faster on
512 MS-Windows, where all sbrk'ed memory is always contiguous.
513
97897668
GM
5142012-01-31 Glenn Morris <rgm@gnu.org>
515
516 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 517 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
518 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
519
31fd3586
GM
5202012-01-29 Glenn Morris <rgm@gnu.org>
521
522 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
523
0e24a8b2
CY
5242012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
525
526 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
527
cc0adcb0
CY
5282012-01-28 Chong Yidong <cyd@gnu.org>
529
530 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
531
acc28cb9
CY
5322012-01-26 Chong Yidong <cyd@gnu.org>
533
9c69cfb7
CY
534 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
535
acc28cb9
CY
536 * search.c (Fsearch_forward, Fsearch_backward): Document negative
537 repeat counts (Bug#10507).
538
48da7392
GM
5392012-01-26 Glenn Morris <rgm@gnu.org>
540
541 * lread.c (syms_of_lread): Doc fix.
542
14af5f7f
CY
5432012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
544
545 * coding.c (encode_designation_at_bol): Change return value to
546 EMACS_INT.
547
0b21c100
CY
5482012-01-25 Chong Yidong <cyd@gnu.org>
549
550 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
551
3c2907f7
CY
5522012-01-21 Chong Yidong <cyd@gnu.org>
553
554 * floatfns.c (Fcopysign): Make the second argument non-optional,
555 since nil is not allowed anyway.
556
959ad23f
AS
5572012-01-21 Andreas Schwab <schwab@linux-m68k.org>
558
559 * process.c (read_process_output): Use p instead of XPROCESS (proc).
560 (send_process): Likewise.
561
34a02f46
MR
5622012-01-19 Martin Rudalics <rudalics@gmx.at>
563
564 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
565 (Vwindow_persistent_parameters): Do not use Qstate.
566 Rewrite doc-strings.
34a02f46 567
1259009a 5682012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
569
570 * character.c (char_width): New function.
70d4fdf6
GM
571 (Fchar_width, c_string_width, lisp_string_width):
572 Use char_width (Bug#9496).
25ed9e61 573
6a6ee00d
MR
5742012-01-16 Martin Rudalics <rudalics@gmx.at>
575
576 * window.c (Vwindow_persistent_parameters): New variable.
577 (Fset_window_configuration, save_window_save): Handle persistent
578 window parameters.
579
c85efaf7
EZ
5802012-01-14 Eli Zaretskii <eliz@gnu.org>
581
582 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
583 thrashing the stack of the thread. (Bug#9087)
584
5944709e
PE
5852012-01-12 Paul Eggert <eggert@cs.ucla.edu>
586
587 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
588
e71f5d99
EZ
5892012-01-11 Eli Zaretskii <eliz@gnu.org>
590
591 * xdisp.c (rows_from_pos_range): Handle the case where the
592 highlight ends on a newline. (Bug#10464)
593 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
594 he end column for display of highlight that ends on a newline
595 before a R2L line.
596
ce316182
GM
5972012-01-11 Glenn Morris <rgm@gnu.org>
598
599 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
600 from load-path also when installation-directory is nil. (Bug#10208)
601
5b43da69
GM
6022012-01-10 Glenn Morris <rgm@gnu.org>
603
74cc8ff9
GM
604 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
605
7d8d6e4e
GM
606 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
607 Update template values to be closer to their typical values these days.
5b43da69 608
a0db8d43
EZ
6092012-01-09 Eli Zaretskii <eliz@gnu.org>
610
611 * xdisp.c (rows_from_pos_range): Accept additional argument
612 DISP_STRING, and accept any glyph in a row whose object is that
613 string as eligible for mouse highlight. Fixes mouse highlight of
614 display strings from overlays. (Bug#10464)
615
9a0115ab 6162012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 617
b9110d6a 618 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
619 * fileio.c (auto_saving_dir_umask): New static var.
620 (Fmake_directory_internal): Use it.
621 (do_auto_save_make_dir): Set it, instead of invoking chmod after
622 creating the directory. The old code temporarily assigns
623 too-generous permissions to the directory.
624 (do_auto_save_eh): Clear it.
b9110d6a 625 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
626 that the var is always cleared.
627
6c1bd3f3
EZ
6282012-01-07 Eli Zaretskii <eliz@gnu.org>
629
630 * search.c (scan_buffer): Pass character positions to
631 know_region_cache, not byte positions. (Bug#6540)
632
069d2b50
L
6332012-01-07 LynX <_LynX@bk.ru> (tiny change)
634
635 * w32.c (sys_rename): Report EXDEV when rename of a directory
636 fails because the target is on another logical disk. (Bug#10284)
637
75bf0d33
DB
6382012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
639
640 * xterm.c (x_embed_request_focus): New function.
641
642 * xterm.h: Add prototype.
643
644 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
645
1c6e5a32
GM
6462012-01-05 Glenn Morris <rgm@gnu.org>
647
648 * emacs.c (emacs_copyright): Update short copyright year to 2012.
649
651e947e
EZ
6502012-01-01 Eli Zaretskii <eliz@gnu.org>
651
652 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
653 Load gnutls_transport_set_lowat only if GnuTLS version is below
654 2.11.1.
655 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
656 GnuTLS versions below 2.11.1.
657
3778cdd8
AL
6582011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
659
660 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
661 to the doc string advising against its use for altering the way
662 windows are scrolled.
663
0e5317f7
KH
6642011-12-28 Kenichi Handa <handa@m17n.org>
665
666 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
667 coding-system ASCII compatible only when it does not produce BOM
668 on encoding (Bug#10383).
669
93d5ca1f
JD
6702011-12-26 Jan Djärv <jan.h.d@swipnet.se>
671
672 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
673 can scroll.
674 (create_and_show_popup_menu): Always use menu_position_func for
675 Gtk3 (Bug#10361).
676
ca22b785
AS
6772011-12-24 Andreas Schwab <schwab@linux-m68k.org>
678
679 * callint.c (Fcall_interactively): Don't truncate prompt string.
680
d048e1e6
EZ
6812011-12-23 Eli Zaretskii <eliz@gnu.org>
682
683 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
684 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 685 resumed from there (after widening). (Bug#10360)
d048e1e6 686
5ccaba1f
JD
6872011-12-22 Jan Djärv <jan.h.d@swipnet.se>
688
689 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
690
204ee57f
JD
6912011-12-21 Jan Djärv <jan.h.d@swipnet.se>
692
b81d40f0
JB
693 * nsterm.m (x_free_frame_resources):
694 Release f->output_data.ns->miniimage.
204ee57f
JD
695 (ns_index_color): Fix indentation. Do not retain
696 color_table->colors[i].
697
698 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
699 before returning.
700
701 * nsfns.m (x_set_background_color): Assign return value from
702 ns_index_color to face-background instead of NSColor*.
703 (ns_implicitly_set_icon_type): Fix indentation.
704 Change assignment in for loop to comparison.
705
706 * emacs.c (ns_pool): New variable.
707 (main): Assign ns_pool.
708 (Fkill_emacs): Call ns_release_autorelease_pool.
709
710 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
711 autorelease fdesc, release fdAttrs and tdict.
712 (ns_get_covering_families): Release charset.
713 (ns_findfonts): Release NSFontDescriptor created with new.
714 (ns_uni_to_glyphs): Fix indentation.
715 (setString): Release attrStr before assigning new value.
716
c803b2b7
JD
7172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
718
678f4426
JD
719 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
720 and NS_IMPL_COCOA.
721 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
722 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
723
cd394be1 7242011-12-18 David Reitter <reitter@cmu.edu>
678f4426 725
5fecd5fc
JD
726 * nsterm.m (ns_term_init): Subscribe for notifications
727 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
728 to method trackingNotification in EmacsMenu.
729
730 * nsmenu.m (trackingMenu): New variable.
3771cb17 731 (trackingNotification): New method (from Aquamacs).
5fecd5fc 732 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 733 from Aquamacs (Bug#7030).
678f4426
JD
734
7352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 736
c803b2b7
JD
737 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
738 (symbol_to_nsstring): Fix indentation.
739 (ns_symbol_to_pb): New function.
cae07000
SM
740 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
741 (Fns_rotate_cut_buffers_internal): Remove.
742 (Fns_store_selection_internal): Rename from
c803b2b7
JD
743 Fns_store_cut_buffer_internal.
744 (ns_get_foreign_selection, Fx_own_selection_internal)
745 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
746 (Fns_get_selection_internal, Fns_store_selection_internal):
747 Use ns_symbol_to_pb and check if return value is nil.
748 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
749 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
750 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
751 renamed to Sns_store_selection_internal.
752 (ns_handle_selection_request): Move code to Fx_own_selection_internal
753 and remove this function.
754 (ns_handle_selection_clear): Remove, never used.
755 (Fx_own_selection_internal): Move code from ns_handle_selection_request
756 here.
757
e1b01a3a
KB
7582011-12-17 Ken Brown <kbrown@cornell.edu>
759
760 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
761 GID is unknown (Bug#10257).
762
2adb6e85
PE
7632011-12-17 Paul Eggert <eggert@cs.ucla.edu>
764
765 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
766 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
767 which caused a build failure on GNU/Linux IA-64. This problem was
768 introduced by my 2011-10-07 patch.
769
d1d7b339
JL
7702011-12-15 Juri Linkov <juri@jurta.org>
771
772 * image.c (imagemagick_error): New function. (Bug#10112)
773 (imagemagick_load_image): Comment out `MagickSetResolution' call.
774 Use `imagemagick_error' where ImageMagick functions return
775 `MagickFalse'.
776 (Fimagemagick_types): Add `Fnreverse' to return the list in the
777 proper order.
778
100d5755
KH
7792011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
780
781 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
782 fill background (Bug#8992).
783
454592a6
MR
7842011-12-13 Martin Rudalics <rudalics@gmx.at>
785
786 * window.c (Vwindow_combination_resize)
787 (Vwindow_combination_limit): Use t instead of non-nil in
788 doc-strings.
61d4b438
MR
789 (Vrecenter_redisplay): Add first sentence of doc-string on
790 separate line.
53524d93 791 (Frecenter): Fix doc-string typo.
454592a6 792
3633e3aa
KH
7932011-12-11 Kenichi Handa <handa@m17n.org>
794
795 * coding.c (Funencodable_char_position): Pay attention to the
796 buffer text relocation (Bug#9389).
797
7b9d523a
JD
7982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
799
800 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
801 gtk_init (Bug#10100).
802
b73189c6
EZ
8032011-12-10 Eli Zaretskii <eliz@gnu.org>
804
805 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
806 IT->string is nil. (Bug#10263)
807
f7dfe5d6
JD
8082011-12-10 Jan Djärv <jan.h.d@swipnet.se>
809
83faebb4
JD
810 * nsterm.h (x_free_frame_resources): Declare.
811
f7dfe5d6
JD
812 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
813 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
814
815 * nsterm.h (ns_get_defaults_value): Declare.
816
817 * nsterm.m (ns_default): Call ns_get_defaults_value.
818
7cd4e72c
EZ
8192011-12-09 Eli Zaretskii <eliz@gnu.org>
820
821 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
822 (Bug#10170)
823
b34d7317
YM
8242011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
825
826 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
827 that where the value of an _OBJC_* symbol points to is in the .bss
828 section (Bug#10240).
829
76470ad1
KH
8302011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
831
832 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 833 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 834
745fff94
KH
8352011-12-08 Kenichi Handa <handa@m17n.org>
836
837 * ftfont.c (get_adstyle_property): Fix previous change
838 (Bug#10233).
839
6e44397c
JB
8402011-12-07 Juanma Barranquero <lekktu@gmail.com>
841
842 * w32.c (init_environment): If no_site_lisp, remove site-lisp
843 dirs from the default value of EMACSLOADPATH (bug#10208).
844
7efa6272
GM
8452011-12-07 Glenn Morris <rgm@gnu.org>
846
847 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
848 installation and source directories as well. (Bug#10208)
849
f6fc4d87
CY
8502011-12-06 Chong Yidong <cyd@gnu.org>
851
852 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
853
2bf26180
GM
8542011-12-06 Glenn Morris <rgm@gnu.org>
855
856 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
857 as an error, not just -1. (Bug#10217)
858
3a6ad4f0
CY
8592011-12-05 Chong Yidong <cyd@gnu.org>
860
861 * keyboard.c (process_special_events): New function.
862 (swallow_events, Finput_pending_p): Use it (Bug#10195).
863
75a3b399
PE
8642011-12-05 Paul Eggert <eggert@cs.ucla.edu>
865
866 * coding.c (encode_designation_at_bol): Don't use uninitialized
867 local variable (Bug#9318).
868
c3c9e25e
KH
8692011-12-05 Kenichi Handa <handa@m17n.org>
870
871 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
872 return Qnil (Bug#8046, Bug#10193).
873
5eb05ea3
KH
8742011-12-05 Kenichi Handa <handa@m17n.org>
875
876 * coding.c (encode_designation_at_bol): New args charbuf_end and
877 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
878 (coding_set_source): Return how many bytes coding->source was
879 relocated.
880 (coding_set_destination): Return how many bytes
881 coding->destination was relocated.
882 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 883 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
884
8852011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
886
887 * coding.c (CODING_CHAR_CHARSET_P): New macro.
888 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
889 macro (Bug#9318).
890
8912011-12-05 Andreas Schwab <schwab@linux-m68k.org>
892
893 The following changes are to fix Bug#9318.
894
a79703f5 895 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
896 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
897 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 898 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 899
7dbda6df
JB
9002011-12-05 Juanma Barranquero <lekktu@gmail.com>
901
902 * lisp.h (process_quit_flag): Fix external declaration.
903
6d5eb5b0
SM
9042011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
905
906 Don't macro-inline non-performance-critical code.
907 * eval.c (process_quit_flag): New function.
908 * lisp.h (QUIT): Use it.
909
a0c3fad0
JD
9102011-12-04 Jan Djärv <jan.h.d@swipnet.se>
911
912 * nsfns.m (get_geometry_from_preferences): New function.
913 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
914
6c07aac2
AS
9152011-12-04 Andreas Schwab <schwab@linux-m68k.org>
916
917 * emacs.c (Qkill_emacs): Define.
918 (syms_of_emacs): Initialize it.
919 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
920 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
921 (quit_throw_to_read_char): Add parameter `from_signal'.
922 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
923 * lisp.h (QUIT): Call Fkill_emacs if requested.
924
c052ead4
JD
9252011-12-03 Jan Djärv <jan.h.d@swipnet.se>
926
927 * widget.c (update_wm_hints): Return if wmshell is null.
928 (widget_update_wm_size_hints): New function.
929
930 * widget.h (widget_update_wm_size_hints): Declare.
931
932 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
933 widget_update_wm_size_hints (Bug#10104).
934
9e49252b
EZ
9352011-12-03 Eli Zaretskii <eliz@gnu.org>
936
937 * xdisp.c (handle_invisible_prop): If the invisible text ends just
938 before a newline, prepare the bidi iterator for consuming the
939 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 940 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 941
02b16839
JL
9422011-12-02 Juri Linkov <juri@jurta.org>
943
944 * search.c (Fword_search_regexp): New Lisp function created from
945 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
946 (Fword_search_backward, Fword_search_forward)
947 (Fword_search_backward_lax, Fword_search_forward_lax):
948 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
949 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
950
0068070e
SM
9512011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
952
953 * fileio.c (Finsert_file_contents): Move after-change-function call
954 to before the "handled:" label, since all "goto handled" appear in
955 cases where the *-change-functions have already been properly called
956 (bug#10117).
957
3360a3fc
AS
9582011-12-01 Andreas Schwab <schwab@linux-m68k.org>
959
960 * keyboard.c (interrupt_signal): Don't call kill-emacs when
961 waiting for input. (Bug#10169)
962
73d6c093
EZ
9632011-11-30 Eli Zaretskii <eliz@gnu.org>
964
965 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
966 verifies glyph row's hash code--we have just reallocated the
967 glyphs, so their contents can be complete garbage. (Bug#10164)
968
febe6bea
JB
9692011-11-30 Juanma Barranquero <lekktu@gmail.com>
970
971 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
972
801a4313
EZ
9732011-11-30 Eli Zaretskii <eliz@gnu.org>
974
975 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
976 attributes are tested _before_ calling verify_row_hash, to protect
977 against GCC re-ordering of the tests. (Bug#10164)
978
2b56b87e
JD
9792011-11-29 Jan Djärv <jan.h.d@swipnet.se>
980
981 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
982
983 * xterm.c (handle_one_xevent): Only set async_visible and friends
984 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 985 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
986 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
987
dbf31225
PE
9882011-11-28 Paul Eggert <eggert@cs.ucla.edu>
989
990 Remove GCPRO-related macros that exist only to avoid shadowing locals.
991 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
992 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
993 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
994 All uses changed to use GCPRO1 etc.
995 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
996 Revert to old implementation (i.e., before 2011-03-11).
997
1305621b
YM
9982011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
999
1000 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1001 of scroll runs so as to avoid assigning disabled bogus rows and
1002 unnecessary graphics copy operations.
1003
8c9afb46
EZ
10042011-11-27 Eli Zaretskii <eliz@gnu.org>
1005
1006 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1007 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1008 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1009 (malloc, free, realloc, calloc): Redirect to e_* only when
1010 compiling Emacs.
1011
1012 * lisp.h (GCTYPEBITS): Move before first use.
1013 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1014 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1015 this macro definition.
1016
1017 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1018 _MSC_VER.
1019
54e9e3bf
JD
10202011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1021
6d5eb5b0
SM
1022 * gtkutil.c (xg_create_frame_widgets):
1023 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1024 present with Gtk+ 2.0.
1025
83aca1cb
PE
10262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 * fileio.c (Finsert_file_contents): Undo previous change; see
1029 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1030
5b76caa4
PE
10312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1032
1033 Rename locals to avoid shadowing.
1034 * fileio.c (Finsert_file_contents):
1035 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1036 * process.c (wait_reading_process_output):
1037 Rename inner 'proc' to 'p' to avoid shadowing.
1038 Indent for consistency with usual Emacs style.
1039
8c535114
EZ
10402011-11-25 Eli Zaretskii <eliz@gnu.org>
1041
1042 * xdisp.c (redisplay_window): If cursor row is not fully visible
1043 after recentering, and scroll-conservatively is set to a large
1044 number, scroll window by a few more lines to make the cursor fully
1045 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1046 (start_display): Don't move to the next line if the display should
1047 start at a newline that is part of a display vector or an overlay
1048 string. (Bug#10119)
8c535114 1049
fa4fdb5c
JL
10502011-11-24 Juri Linkov <juri@jurta.org>
1051
1052 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1053 after the `MagickPingImage' call. (Bug#10112)
1054
90ec88df
CY
10552011-11-23 Chong Yidong <cyd@gnu.org>
1056
1057 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1058
56e2e794
MR
10592011-11-23 Martin Rudalics <rudalics@gmx.at>
1060
1061 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1062 making another buffer current. (Bug#10114)
1063
b6e64c41
GM
10642011-11-23 Glenn Morris <rgm@gnu.org>
1065
1066 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1067
6b21de18
CY
10682011-11-23 Chong Yidong <cyd@gnu.org>
1069
1070 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1071 using it (Bug#5984).
1072
b12cd789
EZ
10732011-11-22 Eli Zaretskii <eliz@gnu.org>
1074
1075 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1076 and header-lines, as they don't have one computed for them.
1077 (Bug#10098)
1078
1079 * .gdbinit (prow): Make displayed values more self-explaining.
1080 Add row's hash code.
1081
261b6fd4
LMI
10822011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1083
1084 * process.c (wait_reading_process_output): Fix asynchrounous
1085 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1086 (wait_reading_process_output): Add comment and URL.
261b6fd4 1087
e7cfd277
JD
10882011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1089
1090 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1091
a9b9b7f5
CY
10922011-11-21 Chong Yidong <cyd@gnu.org>
1093
1094 * window.c (Fnext_window, Fprevious_window): Doc fix.
1095
b0d15b4f
SM
10962011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1097
1098 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1099
fe7a3057
JB
11002011-11-20 Juanma Barranquero <lekktu@gmail.com>
1101
1102 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1103
d2999b1a
MR
11042011-11-20 Martin Rudalics <rudalics@gmx.at>
1105
1106 * window.c (Fset_window_combination_limit): Rename argument
1107 STATUS to LIMIT.
1108 (Vwindow_combination_limit): Remove "status" from doc-string.
1109
d5ff9cd0
AS
11102011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1111
1112 * m/ibms390.h: Remove.
1113 * m/ibms390x.h: Don't include "ibms390.h".
1114
a5bb9bd3
SM
11152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1118 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1119
cd1181db
JB
11202011-11-20 Juanma Barranquero <lekktu@gmail.com>
1121
1122 * casetab.c (Fset_case_table):
1123 * charset.c (Fcharset_after): Fix typos.
1124
615a3b8d 11252011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1126
17e845af
PE
1127 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1128 Otherwise, valgrind does not work on some platforms.
1129 Problem reported by Andreas Schwab in
6a0bf43d
PE
1130 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1131 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1132 is set, removing the need for VIRT_ADDRESS_VARIES.
1133 (PURE_P): Use a more-efficient implementation that needs just one
1134 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1135 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1136 to 4 (xorl, subq, cmpq, setbe).
1137 * alloc.c (pure): Always extern now, since that's the
1138 VIRT_ADDR_VARIES behavior.
1139 (PURE_POINTER_P): Use a single comparison, not two, for
1140 consistency with the new puresize.h.
1141 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1142 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1143 Remove VIRT_ADDR_VARIES no longer needed.
1144
f8fe6f96
EZ
11452011-11-19 Eli Zaretskii <eliz@gnu.org>
1146
1147 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1148 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1149 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1150 behave as if the cursor position were at the window margin.
1151
1152 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1153 and the cursor position is out of bounds, behave as if the cursor
1154 position were at the window margin. (Bug#10075)
1155
df05a53c
CY
11562011-11-18 Chong Yidong <cyd@gnu.org>
1157
1158 * window.c (Fwindow_combination_limit): Make first argument
1159 non-optional, since it is meaningless for live windows like the
1160 selected window.
1161
2071918e
DA
11622011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1163
1164 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1165
b50a28de
SM
11662011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1167
1168 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1169 (graft_intervals_into_buffer): Simplify.
1170
015137db
EZ
11712011-11-18 Eli Zaretskii <eliz@gnu.org>
1172
1173 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1174 hash values of the two rows.
1175 (copy_row_except_pointers): Preserve the used[] arrays and the
1176 hash values of the two rows. (Bug#10035)
68c95424 1177 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1178
1179 * xdisp.c (row_hash): New function, body extracted from
1180 compute_line_metrics.
1181 (compute_line_metrics): Call row_hash, instead of computing the
1182 hash code inline.
1183
1184 * dispnew.c (verify_row_hash): Call row_hash for computing the
1185 hash code of a row, instead of duplicating code from xdisp.c.
1186
1187 * dispextern.h (row_hash): Add prototype.
1188
a2addb04
TH
11892011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1190
1191 * frame.c (delete_frame): Don't delete the terminal when the last
1192 X frame is closed if emacs is built with GTK toolkit.
1193
df85d315
JB
11942011-11-17 Juanma Barranquero <lekktu@gmail.com>
1195
1196 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1197
a0c2d0ae
MR
11982011-11-17 Martin Rudalics <rudalics@gmx.at>
1199
1200 * window.c (Vwindow_splits): Rename to
1201 Vwindow_combination_resize. Suggested by Juri Linkov.
1202 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1203 of Vwindow_splits.
1204
58179cce
JB
12052011-11-16 Juanma Barranquero <lekktu@gmail.com>
1206
7877f373
JB
1207 * nsfns.m (Fns_font_name):
1208 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1209
b6f67890
MR
12102011-11-16 Martin Rudalics <rudalics@gmx.at>
1211
1212 * window.h (window): Rename slot "nest" to "combination_limit".
1213 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1214 (Fset_window_nest): Rename to Fset_window_combination_limit.
1215 (Vwindow_nest): Rename to Vwindow_combination_limit.
1216 (recombine_windows, make_parent_window, make_window)
1217 (Fsplit_window_internal, saved_window)
1218 (Fset_window_configuration, save_window_save): Rename all
1219 occurrences of window_nest to window_combination_limit.
1220
c7015153
JB
12212011-11-15 Juanma Barranquero <lekktu@gmail.com>
1222
1223 * image.c (imagemagick_load_image): Fix typo.
1224
322ad6ec
EZ
12252011-11-14 Eli Zaretskii <eliz@gnu.org>
1226
1227 * xdisp.c (display_line): Move the call to
1228 highlight_trailing_whitespace before the call to
1229 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1230 faces of all the glyphs to compute ROW's hash value.
1231 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1232
f067b8ec
JB
12332011-11-14 Juanma Barranquero <lekktu@gmail.com>
1234
1235 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1236 just return (bug#10044).
1237
1e5b2111
EZ
12382011-11-12 Eli Zaretskii <eliz@gnu.org>
1239
7ef3cbd5
EZ
1240 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1241 with user-defined heap size. Bump the default size of the temacs
1242 heap to 27MB, to avoid memory warning when running temacs.
1243 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1244
1e5b2111
EZ
1245 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1246 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1247 (verify_row_hash) [XASSERTS]: New function.
1248 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1249 that the hash value of glyph rows is correct.
1e5b2111 1250
89d61221
MR
12512011-11-12 Martin Rudalics <rudalics@gmx.at>
1252
1253 * window.h (window): Remove splits slot.
1254 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1255 (Fdelete_other_windows_internal, make_parent_window)
1256 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1257 (Fset_window_configuration, save_window_save): Don't deal with
1258 split status of windows.
1259 (saved_window): Remove splits slot.
1260 (Vwindow_splits): Rewrite doc-string.
1261
97f18cc8
JD
12622011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1263
1264 * xfns.c (unwind_create_frame):
1265 * nsfns.m (unwind_create_frame):
1266 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1267 Vframe_list (Bug#9999).
1268
22a648b4
DA
12692011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1270
0b381c7e 1271 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1272
659afede
KH
12732011-11-11 Kenichi Handa <handa@m17n.org>
1274
1275 * callproc.c (Fcall_process): Set the member dst_multibyte of
1276 process_coding.
1277
9ac0394b
KH
12782011-11-11 Johan Bockgård <bojohan@gnu.org>
1279
1280 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1281 avoid a crash (bug#9496).
1282
2fbdc249
CY
12832011-11-09 Chong Yidong <cyd@gnu.org>
1284
1285 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1286 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1287
ac6b1f81
PE
12882011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1291
09db192c
PE
12922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Avoid some portability problems by eschewing 'extern inline' functions.
1295 The trivial performance wins aren't worth the portability hassles; see
1296 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1297 et seq.
1298 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1299 (window_box_width, window_box_left, window_box_left_offset)
1300 (window_box_right, window_box_right_offset): Undo previous change,
1301 by removing the "extern"s.
1302 * intervals.c (adjust_intervals_for_insertion)
1303 (adjust_intervals_for_deletion): Undo previous change,
1304 making these static again.
1305 (offset_intervals, temp_set_point_both, temp_set_point)
1306 (copy_intervals_to_string): No longer inline.
1307 * xdisp.c (window_text_bottom_y, window_box_width)
1308 (window_box_height, window_box_left_offset)
1309 (window_box_right_offset, window_box_left, window_box_right)
1310 (window_box): No longer inline.
1311
105216ed
CY
13122011-11-08 Chong Yidong <cyd@gnu.org>
1313
1314 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1315 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1316 Signal an error if not a live window.
105216ed
CY
1317 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1318 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1319
ae9e237f
JB
13202011-11-07 Juanma Barranquero <lekktu@gmail.com>
1321
1322 * lisp.h (syms_of_abbrev): Remove declaration.
1323 Reported by CHENG Gao <chenggao@royau.me>.
1324
c7aa8333
EZ
13252011-11-07 Eli Zaretskii <eliz@gnu.org>
1326
1327 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1328 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1329 of temacs in GUI mode.
1330
be7f5545
MR
13312011-11-07 Martin Rudalics <rudalics@gmx.at>
1332
1333 * window.h: Declare delete_all_child_windows instead of
1334 delete_all_subwindows.
1335 * window.c (Fwindow_nest, Fset_window_nest)
1336 (Fset_window_new_total, Fset_window_new_normal)
1337 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1338 (delete_all_subwindows): Rename to delete_all_child_windows.
1339 (Fdelete_other_windows_internal, Fset_window_configuration):
1340 Call delete_all_child_windows instead of delete_all_subwindows.
1341 * frame.c (delete_frame): Call delete_all_child_windows instead
1342 of delete_all_subwindows.
1343
ca78dc43
PE
13442011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1347 This is also needed for porting to any host where GC_MARK_STACK is
1348 not GC_MAKE_GCPROS_NOOPS.
1349 (which_symbols): Use it.
1350
a0241d01
KH
13512011-11-07 Kenichi Handa <handa@m17n.org>
1352
1353 * coding.c (coding_set_destination): Check coding->src_pos only
1354 when coding->src_object is a buffer (bug#9910).
1355
1356 * process.c (send_process): Set the member src_multibyte of coding
1357 to 0 (bug#9911) when sending a unibyte text.
1358
1359 * callproc.c (Fcall_process): Set the member src_multibyte of
1360 process_coding to 0 (bug#9912).
1361
a64bfdfa 13622011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1363
1364 * xmenu.c (cleanup_widget_value_tree): New function.
1365 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1366 calling free_menubar_widget_value_tree directly (Bug#9830).
1367
cb41b32a
PE
13682011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 Fix some portability problems with 'inline'.
1371 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1372 (window_box_width, window_box_left, window_box_left_offset)
1373 (window_box_right, window_box_right_offset): Declare extern.
1374 Otherwise, these inline functions do not conform to C99 and
1375 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1376 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1377 * intervals.c (adjust_intervals_for_insertion)
1378 (adjust_intervals_for_deletion): Now extern, because otherwise the
1379 extern inline functions 'offset_intervals' couldn't refer to it.
1380 (static_offset_intervals): Remove.
1381 (offset_intervals): Rewrite using the old contents of
1382 static_offset_intervals. The old version didn't conform to C99
1383 because an extern inline function contained a reference to an
1384 identifier with static linkage.
1385
b7041366
AS
13862011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1387
1388 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1389 GC.
1390
88a37c4d
EZ
13912011-11-06 Eli Zaretskii <eliz@gnu.org>
1392
1393 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1394 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1395 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1396 return Qleft_to_right.
1397
49745b39
CY
13982011-11-06 Chong Yidong <cyd@gnu.org>
1399
1400 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1401 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1402 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1403 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1404 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1405 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1406 (Fwindow_vscroll): Doc fix.
1407 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1408 argument, since it makes no sense to pass a live window and for
1409 consistency with window-child.
1410
1f05cd82
CS
14112011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1412
1413 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1414 support MSVC.
1415
22610910
JR
14162011-11-05 Jason Rumney <jasonr@gnu.org>
1417
1418 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1419 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1420 fonts (Bug#6029).
1421 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1422 bitwise arithmetic preventing use of unicode-sip and non-truetype
1423 opentype fonts.
1424
a06776b2
EZ
14252011-11-05 Eli Zaretskii <eliz@gnu.org>
1426
3ad924ba
EZ
1427 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1428 "emacs"-only part.
1429
a06776b2
EZ
1430 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1431 initialization code to keep similarity to xfns.c after changes
1432 from 2011-11-05.
1433
c9e7db78
JD
14342011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1435
a97f8f3f
JD
1436 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1437 (unwind_create_frame): New function (Bug#9943).
1438 (Fx_create_frame): Restructure code to be more similar to the one in
1439 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1440 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1441 Move terminal->reference_count++ just before making the frame official
1442 (Bug#9943).
1443
1444 * nsterm.m (x_free_frame_resources): New function.
1445 (x_destroy_window): Move code to x_free_frame_resources.
1446
c9e7db78 1447 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1448 (Fx_create_frame, x_create_tip_frame):
1449 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1450 official. Move initialization of image_cache_refcount and
1451 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1452
a6fc3b5c
EZ
14532011-11-05 Eli Zaretskii <eliz@gnu.org>
1454
1455 Support MSVC build with newer versions of Visual Studio.
1456 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1457 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1458 nt/gmake.defs.
1459
1460 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1461 which are not supported by MSVC.
1462 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1463 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1464 bitfields.
1465 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1466 types in bitfields.
1467 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1468
1469 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1470
58179cce 14712011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1472
1473 Support MSVC build with newer versions of Visual Studio.
1474 * w32.c: Don't include w32api.h for MSVC.
1475 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1476
1477 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1478 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1479 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1480 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1481 e_* cousins.
1482 (alloca) [_MSC_VER]: Define to _alloca.
1483
1484 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1485
1486 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1487
a58c13ed
EZ
14882011-11-04 Eli Zaretskii <eliz@gnu.org>
1489
1490 * xdisp.c (note_mouse_highlight): If either of
1491 previous/next-single-property-change returns nil, treat that as
1492 the beginning or the end of the buffer. (Bug#9955)
1493
fe0b6370
JD
14942011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1495
a58c13ed 1496 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1497 label is not null (Bug#9951).
1498 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1499 may be NULL.
1500
89bd5ee1
EZ
15012011-11-04 Eli Zaretskii <eliz@gnu.org>
1502
1503 * window.c (Fwindow_body_size): Mention in the doc string that the
1504 return value is in frame's canonical units. (Bug#9949)
1505
84c3edb9
EZ
15062011-11-03 Eli Zaretskii <eliz@gnu.org>
1507
4e2fb5c7
EZ
1508 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1509
84c3edb9 1510 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1511 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1512 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1513
bc17a887
EZ
15142011-11-01 Eli Zaretskii <eliz@gnu.org>
1515
1516 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1517 Don't stop backward scan on the continuation glyph, even though
1518 its CHARPOS is positive.
6d5eb5b0
SM
1519 (mouse_face_from_buffer_pos, note_mouse_highlight):
1520 Rename cover_string to disp_string.
bc17a887 1521
4ee88440
MR
15222011-11-01 Martin Rudalics <rudalics@gmx.at>
1523
1524 * window.c (temp_output_buffer_show): Don't use
1525 Vtemp_buffer_show_specifiers.
1526 (Vtemp_buffer_show_specifiers): Remove unused variable.
1527
c2ff3c02
EZ
15282011-10-30 Eli Zaretskii <eliz@gnu.org>
1529
1530 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1531 past the beginning of the current glyph matrix.
1532
58179cce 15332011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1534
1535 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1536 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1537 HAVE_GTK3 (Bug#9869).
b77a6a7f 1538
3b574623
JD
1539 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1540 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1541
b77a6a7f
JD
1542 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1543
1544 * xterm.c: Declare x_handle_net_wm_state to return int.
1545 (handle_one_xevent): Check if we are iconified but don't have
1546 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1547 (get_current_wm_state): Return non-zero if not hidden,
1548 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1549 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1550 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1551 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1552
196e41e4
PE
15532011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1556 so that this new function doesn't get optimized away by a
1557 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1558
021f2e1a
AS
15592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1560
1561 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1562
8b058d44
EZ
15632011-10-29 Eli Zaretskii <eliz@gnu.org>
1564
1565 Fix the `xbytecode' command.
1566 * .gdbinit (xprintbytestr): New command.
b50a28de 1567 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1568 (xbytecode): Print the byte-code string as well.
1569
4452fb80
EZ
15702011-10-29 Kim Storm <storm@cua.dk>
1571
8b058d44
EZ
1572 * alloc.c (which_symbols): New function.
1573
21b72067
AS
15742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1575
1576 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1577 line. (Bug#9903)
1578
83ed7b5c
GM
15792011-10-29 Glenn Morris <rgm@gnu.org>
1580
1581 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1582 Not clear what it was for, and it causes various bugs. (Bug#9839)
1583
5a7a728b
EZ
15842011-10-28 Eli Zaretskii <eliz@gnu.org>
1585
1586 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1587 possible random value that matches one of those tested as
1588 condition to clear the mouse face.
1589
d3d0842f
CY
15902011-10-28 Chong Yidong <cyd@gnu.org>
1591
1592 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1593
31b39d13
DN
15942011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1595
1596 * window.c (make_window): Initialize phys_cursor_on_p.
1597
9aba6043
SM
15982011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1599
1600 * lisp.h (struct Lisp_Symbol): Update comments.
1601
c20992f4
JB
16022011-10-28 Juanma Barranquero <lekktu@gmail.com>
1603
1604 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1605
db4f02f2
EZ
16062011-10-28 Eli Zaretskii <eliz@gnu.org>
1607
1608 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1609 <oslsachem@gmail.com> for helping to debug this.
1610
1611 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1612 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1613 (g_b_init_get_glyph_outline_w): New static variables.
1614 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1615 (GetGlyphOutlineW_Proc): New typedefs.
1616 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1617 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1618 New functions.
1619 (w32font_open_internal, compute_metrics):
1620 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1621 instead of calling the "wide" APIs directly.
1622
1623 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1624
1625 * w32.h (syms_of_w32font): Add prototype.
1626
87e68db4
JB
16272011-10-27 Juanma Barranquero <lekktu@gmail.com>
1628
1629 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1630 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1631 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1632 (Fmove_to_window_line): Doc fix.
1633
435c1d67
CY
16342011-10-27 Chong Yidong <cyd@gnu.org>
1635
1636 * process.c (make_process): Set gnutls_state to NULL.
1637
1638 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1639 non-NULL, regardless of GNUTLS_INITSTAGE.
1640 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1641 an error. Set process slots as soon as we allocate them.
1642
1643 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1644
9c6c6f49
CY
16452011-10-27 Chong Yidong <cyd@gnu.org>
1646
9aba6043
SM
1647 * gnutls.c (emacs_gnutls_deinit): New function.
1648 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1649 (Fgnutls_deinit, Fgnutls_boot): Use it.
1650
1651 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1652 (deactivate_process): Call emacs_gnutls_deinit.
1653
657d08d3
JB
16542011-10-27 Juanma Barranquero <lekktu@gmail.com>
1655
1656 * image.c (x_create_x_image_and_pixmap):
1657 * w32.c (sys_rename, w32_delayed_load):
1658 * w32font.c (fill_in_logfont):
1659 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1660
5430d399
JB
16612011-10-26 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * w32fns.c (w32_default_color_map): New function,
1664 extracted from Fw32_default_color_map.
a7ef684b 1665 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1666
fe0055fa
PE
16672011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1670
e6346438
SM
16712011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1672
1673 * keyboard.c (test_undefined): New function (bug#9751).
1674 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1675
e112cc37
ET
16762011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1677
1678 * sysdep.c (init_sys_modes): Fix the check for the controlling
1679 terminal (Bug#6649).
1680
7b5d6677
EZ
16812011-10-20 Eli Zaretskii <eliz@gnu.org>
1682
1683 * dispextern.h (struct bidi_it): New member next_en_type.
1684
1685 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1686 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1687 current character, check also for next_en_type being WEAK_EN.
1688 (bidi_resolve_weak): Don't enter the expensive loop if the current
1689 position is before next_en_pos. Record the bidi type of the first
1690 non-ET, non-BN character we find, in addition to its position.
1691 (bidi_level_of_next_char): Invalidate next_en_type when
1692 next_en_pos is over-stepped.
1693
7da0b018
PE
16942011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1697 * editfns.c: Rewrite current-time-zone so that it invokes
1698 the equivalent of (format-time-string "%Z") to get the time zone name.
1699 This fixes a bug when the time zone name contains characters that
1700 need converting from the system time locale to Emacs internal format.
1701 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1702 that patch fixed format-time-string to do the conversion, but
1703 I forgot to fix current-time-zone.
1704 (format_time_string): New function, containing most of
1705 what Fformat_time_string used to contain.
1706 (Fformat_time_string): Rewrite in terms of format_time_string.
1707 This doesn't change this function's behavior.
1708 (current-time-zone): Rewrite to use format_time_string.
1709 This fixes the bug reported by Michael Schierl in
1710 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1711 Jason Rumney's 2007-06-07 change worked around this bug, but
1712 didn't fix it.
1713 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1714
8547b010
EZ
17152011-10-19 Eli Zaretskii <eliz@gnu.org>
1716
1717 * xdisp.c (start_display): If the character at POS is displayed
1718 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1719 (try_window_reusing_current_matrix): If a line ends in a display
1720 vector or the next line starts in a display vector, continue
1721 redrawing the window even though the character position of
1722 start_row was reached.
8547b010
EZ
1723 (Bug#9771, part 2)
1724
4e948d15
CY
17252011-10-18 Chong Yidong <cyd@gnu.org>
1726
1727 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1728 with nobreak-char-display too.
1729
4787455f
EZ
17302011-10-18 Eli Zaretskii <eliz@gnu.org>
1731
1732 Fix part 3 of bug#9771.
1733 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1734 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1735 non-neutral characters if the current character is a paragraph
1736 separator (a.k.a. Newline). This avoids running the same
1737 expensive loop twice, once when we consume the preceding newline
1738 and the other time when the line actually needs to be displayed.
1739 Avoid the loop when we see neutrals on the base embedding level
1740 following a character whose directionality is the same as the
1741 paragraph's. This avoids running the expensive loop when a line
1742 ends in a long sequence of neutrals, like control characters.
1743 Add assertion against STRONG_AL type. Slightly rearrange code
1744 that determines the type of a neutral given the first non-neutral
1745 that follows it.
1746 (bidi_level_of_next_char): Set next_en_pos to zero when
1747 invalidating its info.
1748
2c91f553
EZ
17492011-10-17 Eli Zaretskii <eliz@gnu.org>
1750
1751 * xdisp.c (push_display_prop): Determine whether to record string
1752 or buffer position by IT->string, not by IT->method. Allow
1753 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1754 (move_it_vertically_backward): Don't look for character position
1755 immediately after the newline when in a continuation line.
1756 (Bug#9771, part 1)
2c91f553 1757
c7b08b0d
MR
17582011-10-15 Martin Rudalics <rudalics@gmx.at>
1759
1760 * window.c (coordinates_in_window): Rewrite and delabelize
1761 vertical border check. (Bug#5357) (Bug#9618)
1762
6b02f655
SM
17632011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1764
1765 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1766 errors in XSetWindowBorder (bug#9310).
1767
81d40c92
DA
17682011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1769
1770 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1771 avoid crash when xmalloc overrun checking is enabled.
1772
d4172c3b
EZ
17732011-10-13 Eli Zaretskii <eliz@gnu.org>
1774
1775 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1776 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1777 cursor motion with <left> and <right> arrow keys.
1778
1779 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1780 some callers set that themselves.
1781
b00eea75
EZ
17822011-10-12 Eli Zaretskii <eliz@gnu.org>
1783
1784 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1785 display string and the previous row comes from the same string and
1786 is empty. (Bug#9739) (Bug#9738)
1787
8fe012c4
SM
17882011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1789
1790 * doc.c (get_doc_string): Encode file name (bug#9735).
1791
0074aef2
EZ
17922011-10-12 Eli Zaretskii <eliz@gnu.org>
1793
79beb178
EZ
1794 * bidi.c (bidi_level_of_next_char):
1795 * xdisp.c (get_visually_first_element): Remove old incorrect
1796 comments regarding the Unicode Line Separator character.
1797
0074aef2
EZ
1798 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1799
6e4b3fbe
DA
18002011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 * alloc.c (Fgc_status): Do not access beyond zombies array
1803 boundary if nzombies > MAX_ZOMBIES.
1804 * alloc.c (dump_zombies): Add missing format specifier.
1805
0324f3af
PE
18062011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1807
b5525cac
PE
1808 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1809 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1810
0324f3af
PE
1811 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1812 Some packages use them to denote characters with modifiers.
1813
e9b5f888
AS
18142011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1815
1816 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1817 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1818 matching a pp-number. Rename parameter var to var1.
1819
127827c0
SM
18202011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1821
1822 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1823
c8fd3bd0
GM
18242011-10-08 Glenn Morris <rgm@gnu.org>
1825
1826 * callint.c (Fcall_interactively): Give a more explicit error for the
1827 'c' case with a non-character input. (Bug#8479)
1828
352ec8ff
EZ
18292011-10-08 Eli Zaretskii <eliz@gnu.org>
1830
03669ccb
EZ
1831 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1832 lines.
7061c986
EZ
1833 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1834 lines that are hscrolled on the left.
03669ccb 1835
352ec8ff
EZ
1836 * dispnew.c (buffer_posn_from_coords): Account for a possible
1837 presence of header-line. (Bug#4426)
1838
a66cfb1c
SM
18392011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1840
6b02f655
SM
1841 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1842 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1843
7c5ee88e
PE
18442011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1847 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1848 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1849 this makes Emacs dump core during garbage collection on rare
1850 occasions. sizeof is obviously inferior to offsetof here, so
1851 stick with offsetof.
1852 (GC_POINTER_ALIGNMENT): New macro.
1853 (mark_memory): Omit 3rd (offset) arg; caller changed.
1854 Don't assume EMACS_INT alignment is the same as pointer alignment.
1855
df1bbe5b
SM
18562011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1857
1858 * keyboard.c (read_key_sequence_remapped): New var.
1859 (read_key_sequence): Compute remapping in the right buffer.
1860 (command_loop_1): Use read_key_sequence's remapping directly.
1861
51553db6
SM
18622011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1863
32c1fffd
SM
1864 * dired.c (file_name_completion): Don't expand file name.
1865 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1866 before checking file name handler.
1867
51553db6
SM
1868 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1869 they've been requested explicitly (bug#9591).
1870
b6bd1599 18712011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1872
1873 * keymap.c (Fsingle_key_description): Use make_specified_string
1874 instead of build_string to build string from push_key_description.
1875 (Bug#5193)
1876
f701dc2a
PE
18772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1878
4222c55d
PE
1879 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1880 This fixes a Y2038 bug on 64-bit hosts.
1881 * buffer.c (reset_buffer):
1882 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1883 (Fclear_buffer_auto_save_failure):
1884 Use 0, not -1, to represent an unset failure time, since time_t
1885 might not be signed.
1886
f701dc2a
PE
1887 Remove dependency on glibc malloc internals.
1888 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1889 Move back here from lisp.h, but with their new implementations.
1890 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1891 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1892 * charset.c (charset_table_init): New static var.
1893 (syms_of_charset): Use it instead of xmalloc. This removes a
1894 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1895 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1896 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1897 Move back to alloc.c.
1898 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1899 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1900
9ceebf39
JD
19012011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1902
1903 * nsterm.m (windowDidResize): Call x_set_window_size only when
1904 ns_in_resize is true. Otherwise set pixelwidth/height and
1905 call change_frame_size (Bug#9628).
1906
cb993c58
PE
19072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1908
3930c88b
PE
1909 Port --enable-checking=all to Fedora 14 x86-64.
1910 * charset.c (syms_of_charset): Also account for glibc malloc's
1911 internal overhead when calculating the initial malloc maximum.
1912
cb993c58
PE
1913 Port --enable-checking=all to Fedora 14 x86.
1914 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1915 Move to lisp.h.
1916 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1917 (overrun_check_realloc, overrun_check_free):
1918 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1919 That way, xmalloc returns a properly-aligned pointer even if
1920 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1921 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1922 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1923 into account when calculating the initial malloc maximum.
1924 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1925 Move here from alloc.c, so that charset.c can use it too.
1926 Properly align; the old code wasn't right for common 32-bit hosts
1927 when configured with --enable-checking=all.
1928 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1929 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1930
31bed486
EZ
19312011-09-29 Eli Zaretskii <eliz@gnu.org>
1932
04c70788 1933 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1934 use EDOM.
1935
fbcaa2f3
EZ
19362011-09-28 Eli Zaretskii <eliz@gnu.org>
1937
1938 * xdisp.c (compute_display_string_end): If there's no display
1939 string at CHARPOS, return -1.
1940
1941 * bidi.c (bidi_fetch_char): When compute_display_string_end
1942 returns a negative value, treat the character as a normal
1943 character not covered by a display string. (Bug#9624)
1944
a239d4e9
JB
19452011-09-28 Juanma Barranquero <lekktu@gmail.com>
1946
1947 * lread.c (Fread_from_string): Fix typo in docstring.
1948
88652fd5
EZ
19492011-09-27 Eli Zaretskii <eliz@gnu.org>
1950
1951 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1952 newline, reseat the iterator instead of bidi-iterating there one
1953 character at a time. (Bug#9610)
32c1fffd
SM
1954 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1955 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1956
ed497dd4
AS
19572011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1958
1959 * lread.c (readevalloop): Use correct code for NBSP.
1960 (read1): Likewise. (Bug#9608)
1961
b2bf61aa
MA
19622011-09-25 Michael Albinus <michael.albinus@gmx.de>
1963
1964 * dbusbind.c (Fdbus_register_signal): When service is not
1965 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1966
32bbb17c
GM
19672011-09-25 Glenn Morris <rgm@gnu.org>
1968
1969 * buffer.c (truncate-lines): Doc fix.
1970
94e0933e
CY
19712011-09-24 Chong Yidong <cyd@stupidchicken.com>
1972
1973 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1974 (Fset_window_next_buffers): Doc fix.
1975
cddde921
GM
19762011-09-24 Glenn Morris <rgm@gnu.org>
1977
1978 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1979
1260aef1
PE
19802011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1981
25b4bfa0
PE
1982 Fix minor problems found by static checking.
1983 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1984 * indent.c (Fvertical_motion): Fix == vs = typo.
1985
e3cbd34b
EZ
19862011-09-24 Eli Zaretskii <eliz@gnu.org>
1987
a66cfb1c
SM
1988 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1989 Default value is now t. Doc fix.
6bf7006f 1990
e3cbd34b 1991 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1992 logic when moving up, not only when moving down. Fix the
e3cbd34b 1993 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1994 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1995
1996 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1997 CHARPOS is covered by a display string which includes newlines.
1998 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1999 is covered by a display string with embedded newlines.
2000
a3de0cbd
MA
20012011-09-24 Michael Albinus <michael.albinus@gmx.de>
2002
2003 * dbusbind.c (Fdbus_register_signal): Add match rule to
2004 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2005 (Fdbus_register_method, Vdbus_registered_objects_table):
2006 Fix docstring.
a3de0cbd 2007
b260039d
JM
20082011-09-24 Jim Meyering <meyering@redhat.com>
2009
32c1fffd 2010 do not ignore write error for any output size
b260039d
JM
2011 The previous change was incomplete.
2012 While it makes emacs --batch detect the vast majority of stdout
2013 write failures, errors were still ignored whenever the output size is
2014 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2015 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2016 && echo FAIL: ignored write error
2017 FAIL: ignored write error
2018 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2019 && echo FAIL: ignored write error
2020 FAIL: ignored write error
2021 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2022
8eca8a7c
AS
20232011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2024
2025 * emacs.c (Fkill_emacs): In noninteractive mode exit
2026 non-successfully if a write error occurred on stdout. (Bug#9574)
2027
3341db62
EZ
20282011-09-21 Eli Zaretskii <eliz@gnu.org>
2029
2030 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2031 the xassert test.
2032
2033 * dispextern.h (struct it): Update the comment documenting what
2034 can it->OBJECT be.
2035
8c203dbf
EZ
20362011-09-20 Eli Zaretskii <eliz@gnu.org>
2037
2038 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2039 a display string, extend search for cursor position to end of row.
2040 (find_row_edges): If the row ends in a newline from a display
2041 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2042 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2043 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2044 non-empty line. Fixes confusing cursor motion with arrow keys at
2045 the beginning of a line that starts with whitespace.
8c203dbf 2046
a4824228
LMI
20472011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2048
2049 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2050 (bug#9493).
2051
33ed493b
CY
20522011-09-18 Chong Yidong <cyd@stupidchicken.com>
2053
2054 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2055 boolean (Bug#9154).
2056
56cd55c8
EZ
20572011-09-18 Eli Zaretskii <eliz@gnu.org>
2058
2059 * xdisp.c (display_line): Record maximum and minimum buffer
2060 positions even if no glyphs were produced (e.g., by a zero-width
2061 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2062 buffer positions that will be removed from the glyph row because
2063 they don't fit.
c02dcedf
EZ
2064 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2065 column is beyond frame width: don't subtract 1 "pixel" when
2066 computing width of the stretch.
3e62b7e0
EZ
2067 (reseat_at_next_visible_line_start): Undo the change made on
2068 2011-09-17 that saved paragraph information and restored it after
2069 the call to `reseat'. (Bug#9545)
56cd55c8 2070
5ed99d36 20712011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2072
2073 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2074 and turn window cursor on if cleared (Bug#9415).
2075
5ed99d36 20762011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2077
2078 * search.c (boyer_moore): Take unibyte characters from pattern
2079 literally. (Bug#9458)
2080
9bade7b2
EZ
20812011-09-18 Eli Zaretskii <eliz@gnu.org>
2082
2083 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2084
e5e9d610
PE
20852011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2086
87e4427a
PE
2087 Fix minor problem found by static checking.
2088 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2089 initialized, to pacify gcc -Wuninitialized.
2090
e5e9d610
PE
2091 * fileio.c: Report proper errno when syscall falls.
2092 (Finsert_file_contents): Save and restore errno,
2093 so that report_file_error outputs the correct diagnostic.
2094 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2095
a1674f0b
EZ
20962011-09-18 Eli Zaretskii <eliz@gnu.org>
2097
2098 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2099
fbfb6dd4
EZ
21002011-09-17 Eli Zaretskii <eliz@gnu.org>
2101
2102 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2103 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2104
bb187662
EZ
21052011-09-17 Eli Zaretskii <eliz@gnu.org>
2106
1137e8b8 2107 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2108 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2109
2110 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2111 (bidi_find_paragraph_start): Search back for paragraph beginning
2112 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2113 (bidi_move_to_visually_next): Only trigger paragraph-related
2114 computations when the last character is a newline or at EOB, not
2115 just any NEUTRAL_B. (Bug#9470)
2116
bb187662
EZ
2117 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2118 truncated lines if point is covered by a display string. (Bug#9524)
2119
2e621251
PE
21202011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2121
2122 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2123 (cons_to_x_long): New function.
2124 (lisp_data_to_selection_data): Use it. Correct the test for
2125 short-versus-long data; it was negated. Break out of vector
2126 loop, for efficiency, when a long datum is discovered.
2127
91a15bc6
SM
21282011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2129
2130 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2131
b41c3a35
EZ
21322011-09-16 Eli Zaretskii <eliz@gnu.org>
2133
2134 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2135 GCC PR/17406) by declaring this function with external scope.
2136
7812ba2d
PE
21372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2140 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2141
cf7edc2a
AS
21422011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2143
2144 * editfns.c (Fformat): Correctly handle text properties on "%%".
2145
bd01620e
EZ
21462011-09-15 Eli Zaretskii <eliz@gnu.org>
2147
2148 * xterm.c (x_draw_composite_glyph_string_foreground):
2149 * w32term.c (x_draw_composite_glyph_string_foreground):
2150 * term.c (encode_terminal_code):
2151 * composite.c (composition_update_it, get_composition_id):
2152 * xdisp.c (get_next_display_element)
2153 (fill_composite_glyph_string): Add comments about special meaning
2154 of TAB characters in a composition.
2155
a02719a3
PE
21562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2159 This occurs when processing a multibyte format.
2160 Problem reported by Wolfgang Jenker.
a02719a3 2161
72589a3c
JB
21622011-09-15 Johan Bockgård <bojohan@gnu.org>
2163
2164 * xdisp.c (try_cursor_movement): Only check for exact match if
2165 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2166
1c14176c
PE
21672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2168
2169 Remove unused external symbols.
2170 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2171 * xdisp.c (calc_pixel_width_or_height): Now static.
2172 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2173 * indent.c (check_display_width):
2174 * w32term.c: Fix comment to match code.
2175 * xterm.c, xterm.h (x_catching_errors): Remove.
2176
d2eea5b5
PE
21772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 * xselect.c: Use signed conversions more consistently (Bug#9498).
2180 (selection_data_to_lisp_data): Assume incoming selection data are
2181 signed integers, not unsigned. This is to be consistent with
2182 outgoing selection data, which was modified to use signed integers
2183 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2184 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2185 expects long, not unsigned long.
2186
46888499
EZ
21872011-09-14 Eli Zaretskii <eliz@gnu.org>
2188
2189 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2190 computation of loop end. Reported by Johan Bockgård
2191 <bojohan@gnu.org>.
2192
ef8ef9fb
CY
21932011-09-13 Chong Yidong <cyd@stupidchicken.com>
2194
2195 * frame.c (Fother_visible_frames_p): Function deleted.
2196
fa819fed
EZ
21972011-09-12 Eli Zaretskii <eliz@gnu.org>
2198
2199 * indent.c (compute_motion): Process display vector front to back
2200 rather than the other way around. (Bug#2496)
2201
2ba8e008
SM
22022011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2203
2204 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2205
20f53c69
CY
22062011-09-11 Chong Yidong <cyd@stupidchicken.com>
2207
2208 * minibuf.c (Fread_from_minibuffer): Doc fix.
2209
d562d7a4
EZ
22102011-09-11 Eli Zaretskii <eliz@gnu.org>
2211
2212 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2213 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2214
1c4d7f3d
LMI
22152011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2216
2217 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2218 value for non-existent files.
2219
b885bf36
EZ
22202011-09-11 Eli Zaretskii <eliz@gnu.org>
2221
2222 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2223 set its "size" to -1. This will set the modtime_size field of
2224 the corresponding buffer to -1, which is what
2225 verify-visited-file-modtime expects for files that do not exist.
2226 (Bug#9139)
2227
6612f0bf
PE
22282011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2231 here ...
2232 * lisp.h: ... from here. push_key_description is no longer
2233 defined in keyboard.c, so its declaration should not be in
2234 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2235 logically belongs with push_key_description.
2236
dfb3f755
PE
22372011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2238
2239 * buffer.h: Include <sys/types.h> instead of <time.h>.
2240 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2241 Problem reported by Herbert J. Skuhra.
2242
3134906c
LMI
22432011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2244
2245 * xml.c (parse_region): Make the parsing work for
2246 non-comment-starting XML files again (bug#9144).
2247
8d903f4e
AS
22482011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2249
2250 * image.c (gif_load): Fix calculation of bottom and right corner.
2251 (Bug#9468)
2252
80ad64f4
EZ
22532011-09-10 Eli Zaretskii <eliz@gnu.org>
2254
2255 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2256 redisplay in small windows.
2257
208a048d
EZ
22582011-09-09 Eli Zaretskii <eliz@gnu.org>
2259
2260 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2261
9b1c252e
MR
22622011-09-08 Martin Rudalics <rudalics@gmx.at>
2263
2264 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2265 Operate on live windows only.
2266
2949f33b
JB
22672011-09-08 Juanma Barranquero <lekktu@gmail.com>
2268
2269 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2270
e08dcafd
EZ
22712011-09-07 Eli Zaretskii <eliz@gnu.org>
2272
2273 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2274 only under bidi iteration.
2275
115b96bd
JD
22762011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2277
2278 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2279
c8199d0f
PE
22802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2281
2282 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2283 Without this fix, the command to link temacs failed due to an
2284 undefined symbol __builtin_isnan. This is because
2285 /usr/include/iso/math_c99.h #defines isnan(x) to
2286 __builtin_isnan(x), but the bundled gcc, which identifies itself
2287 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2288 a __builtin_isnan.
2289 * floatfns.c (isnan): #undef, and then #define to a clone of
2290 what's in data.c.
2291 (Fisnan): Always define, since it's always available now.
2292 (syms_of_floatfns): Always define isnan at the Lisp level.
2293
e39b275c 22942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2295
2296 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2297
b2db44d9 22982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2299
f4af5137 2300 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2301 The previous code assumed that file offsets (off_t values) fit in
2302 EMACS_INT variables, which is not true on typical 32-bit hosts.
2303 The code messed up by falsely reporting buffer overflow in cases
2304 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2305 when "big" contains more than 2**29 bytes, even though this
2306 inserts just one byte and does not overflow the buffer.
2307 (Finsert_file_contents): Store file offsets as off_t
2308 values, not as EMACS_INT values. Check for overflow when
2309 converting between EMACS_INT and off_t. When checking for
2310 buffer overflow or for overlap, take the offsets into account.
2311 Don't use EMACS_INT for small values where int suffices.
2312 When checking for overlap, fix a typo: ZV was used where
2313 ZV_BYTE was intended.
2314 (Fwrite_region): Don't assume off_t fits into 'long'.
2315 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2316
ecfc0a49
MA
23172011-09-05 Michael Albinus <michael.albinus@gmx.de>
2318
2319 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2320
6511acf2 23212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2322
0999621a 2323 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2324
2325 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2326 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2327 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2328 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2329 (modify_event_symbol): Do not assume that the length of
2330 name_alist_or_stem is safe to alloca and fits in int.
2331 (Fexecute_extended_command): Likewise for function name and binding.
2332 (Frecursion_depth): Wrap around reliably on integer overflow.
2333 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2334 since some callers pass EMACS_INT values.
2335 (Fsingle_key_description): Don't crash if symbol name contains more
2336 than MAX_ALLOCA bytes.
2337 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2338 (get_minibuffer): Arg is now EMACS_INT, not int.
2339 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2340 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2341 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2342
2be7d702
PE
2343 * dbusbind.c (signature_cat): New function.
2344 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2345 Do not overrun buffer; instead, report string overflow.
2346
9d1df220
PE
2347 * dispnew.c (add_window_display_history): Don't overrun buffer.
2348 Truncate instead; this is OK since it's just a log.
2349
33ef5c64
PE
2350 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2351 even if the time zone offset is outlandishly large.
2352 Don't mishandle offset == INT_MIN.
2353
66c6fdd5
PE
2354 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2355 when creating daemon; the previous buffer-overflow check was incorrect.
2356
d749b01b
PE
2357 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2358 which has the guts of the old verror function.
2359
b5cd1905
PE
2360 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2361 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2362
6e1a67fb
PE
2363 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2364 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2365 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2366 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2367 length of string rather than counting it via multiple sprintfs;
2368 that's simpler and more reliable.
c21721cc
PE
2369 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2370 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2371 sprintf, in case result does not fit in int.
2372
c57b67fc
PE
2373 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2374 (fontset_from_font): Print it.
2375
8a401434
PE
2376 * frame.c (tty_frame_count): Now printmax_t, not int.
2377 (make_terminal_frame, set_term_frame_name): Print it.
2378 (x_report_frame_params): In X, window IDs are unsigned long,
2379 not signed long, so print them as unsigned.
2380 (validate_x_resource_name): Check for implausibly long names,
2381 and don't assume name length fits in 'int'.
2382 (x_get_resource_string): Don't blindly alloca invocation name;
2383 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2384 not fit in int.
2385
6e1a67fb
PE
2386 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2387 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2388 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2389
0df02bf3
PE
2390 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2391 Use esprintf, not sprintf, in case result does not fit in int.
2392
48e30793
PE
2393 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2394 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2395 it as a large positive number.
2396 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2397 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2398
a66ff6d8
PE
2399 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2400 in case result does not fit in int.
2401
aca216ff
PE
2402 * print.c (float_to_string): Detect width overflow more reliably.
2403 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2404 buffer overrun. Don't assume list length fits in 'int'. Treat
2405 print length of 0 as 0, not as infinity; to be consistent with other
2406 uses of print length in this function. Don't overflow print length
2407 index. Don't assume hash table size fits in 'long', or that
2408 vectorlike size fits in 'unsigned long'.
2409
31c286f7
PE
2410 * process.c (make_process): Use printmax_t, not int, to format
2411 process-name gensyms.
2412
55e5faa1
PE
2413 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2414
80f2e268
PE
2415 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2416 to avoid potential buffer overrun.
2417
670741ab
PE
2418 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2419 if X resource line is longer than 512 bytes.
2420
b7163a50
PE
2421 * xfns.c (x_window): Make sprintf buffer a bit bigger
2422 to avoid potential buffer overrun.
2423
ae58ff1f
PE
2424 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2425
c43c8a6a
PE
2426 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2427
3f8236f4
PE
24282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2429
53e9fe90 2430 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2431 Without these, Emacs silently mishandles large integers sometimes.
2432 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2433 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2434
6511acf2
PE
2435 * xdisp.c (try_window_id): Check Emacs fixnum range before
2436 converting to 'int'.
806add1d 2437
6511acf2 2438 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2439 Check that an Emacs fixnum is in range before assigning it to 'int'.
2440 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2441 values converted from Emacs fixnums.
2442 (Frecenter): Don't wrap around a line count if it is out of 'int'
2443 range; instead, treat it as an extreme value.
2444 (Fset_window_configuration, compare_window_configurations):
2445 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2446
6511acf2
PE
2447 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2448 that can exceed INT_MAX. Check that EMACS_INT value is in range
2449 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2450 (match_limit): Don't assume that a fixnum can fit in 'int'.
2451
6511acf2 2452 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2453 exceed INT_MAX.
2454
6511acf2 2455 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2456 (Fvertical_motion): Don't wrap around LINES values that don't fit
2457 in 'int'. Instead, treat them as extreme values. This is good
2458 enough for windows, which can't have more than INT_MAX lines anyway.
2459
fcb901a7
LMI
24602011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2461
0f2f6b6d
LMI
2462 * Require libxml/parser.h to avoid compilation warning.
2463
fcb901a7
LMI
2464 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2465
2466 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2467 since this reportedly can destroy thread storage.
2468
6e20a0d4
CY
24692011-08-30 Chong Yidong <cyd@stupidchicken.com>
2470
2471 * syntax.c (find_defun_start): Update all cache variables if
2472 exiting early (Bug#9401).
2473
148ae00e
EZ
24742011-08-30 Eli Zaretskii <eliz@gnu.org>
2475
f6cfbd8f
EZ
2476 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2477
148ae00e
EZ
2478 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2479 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2480 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2481
2482 * term.c (tty_append_glyph): New function.
2483 (produce_stretch_glyph): Static function and its prototype deleted.
2484
a66cfb1c
SM
2485 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2486 Add prototypes.
148ae00e 2487
c4a07a4c
PE
24882011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2491 when checking :margin (Bug#9390).
2492 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2493 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2494 so that the name doesn't mislead. All uses changed.
2495
6bc8cd65
JB
24962011-08-28 Johan Bockgård <bojohan@gnu.org>
2497
2498 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2499 set_tty_hooks.
2500
dca4927e
EZ
25012011-08-27 Eli Zaretskii <eliz@gnu.org>
2502
2503 * xdisp.c (move_it_to): Don't bail out early when reaching
2504 position beyond to_charpos, if we are scanning backwards.
2505 (move_it_vertically_backward): When DY == 0, make sure we get to
2506 the first character in the line after the newline.
2507
f2cad773
PE
25082011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2509
2510 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2511 (ccl_driver): Do not generate an out-of-range pointer.
2512 (Fccl_execute_on_string): Remove unnecessary check for
2513 integer overflow, noted by Stefan Monnier in
2514 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2515 Remove a FIXME that didn't need fixing.
2516 Simplify the newly-introduced buffer reallocation code.
2517
0cae2cdb
JB
25182011-08-27 Juanma Barranquero <lekktu@gmail.com>
2519
2520 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2521
5fc295a4 25222011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2523
70c60eb2 2524 Integer and memory overflow issues (Bug#9196).
726e0ab1 2525
d31850da
PE
2526 * doc.c (get_doc_string): Rework so that
2527 get_doc_string_buffer_size is the actual buffer size, rather than
2528 being 1 less than the actual buffer size; this makes xpalloc more
2529 convenient.
2530
a69fbedb
PE
2531 * image.c (x_allocate_bitmap_record, cache_image):
2532 * xselect.c (Fx_register_dnd_atom):
2533 Simplify previous changes by using xpalloc.
2534
fe5c5d37
PE
2535 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2536 since either will do and ptrdiff_t is convenient with xpalloc.
2537
0065d054
PE
2538 * charset.c (charset_table_size)
2539 (struct charset_sort_data.priority): Now ptrdiff_t.
2540 (charset_compare): Don't overflow if priorities differ greatly.
2541 (Fsort_charsets): Don't assume list length fits in int.
2542 Check for size-calculation overflow when allocating sort data.
2543 (syms_of_charset): Allocate an initial charset table that is
2544 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2545
2546 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2547
2548 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2549 The actual value is always <= INT_MAX, and leaving it unsigned made
2550 overflow checking harder.
2551
2552 * dispextern.h (struct glyph_matrix.rows_allocated)
2553 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2554 with xpalloc. The values are still always <= INT_MAX.
2555
2556 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2557
2558 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2559 (SAFE_NALLOCA): New macro.
2560
2561 * region-cache.c (struct boundary.pos, find_cache_boundary)
2562 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2563 (set_cache_region, invalidate_region_cache)
2564 (revalidate_region_cache, know_region_cache, region_cache_forward)
2565 (region_cache_backward, pp_cache):
2566 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2567 so that ptrdiff_t * can be passed to xpalloc.
2568 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2569 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2570 (pp_cache): Don't assume cache_len fits in int.
2571 * region-cache.h: Adjust extern decls to match.
2572
2573 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2574 EMACS_INT, since either will do, for xpalloc.
2575
2576 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2577 (xnmalloc, xnrealloc, xpalloc): New functions.
2578
726e0ab1
PE
2579 * bidi.c (bidi_shelve_header_size): New constant.
2580 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2581 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2582
51f30bc5 2583 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2584 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2585 (overlay_strings):
2586 Don't update size of array until after memory allocation succeeds,
2587 because xmalloc/xrealloc may not return.
0065d054
PE
2588 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2589 now that we have proper integer overflow checking.
2590 (record_overlay_string, overlay_strings): Catch overflows when
2591 calculating size of overlay_str_buf.
726e0ab1 2592
0065d054
PE
2593 * callproc.c (Fcall_process): Check for size overflow when
2594 calculating size of args2.
2595 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2596 Normally we prefer signed values, but sticking with ptrdiff_t would
2597 require adding more-complicated checks.
726e0ab1
PE
2598
2599 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2600 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2601 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2602 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2603
2604 * character.c (Fstring): Check for size-calculation overflow.
2605
2606 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2607 unnecessary integer overflow. Check for size overflow.
2608 (encode_coding_object): Don't update size until xmalloc succeeds.
2609
2610 * composite.c (get_composition_id): Check for overflow in glyph
2611 length calculations.
2612
2613 Integer and memory overflow fixes for display code.
2614 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2615 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2616 (scrolling_window): Check for overflow in size calculations.
2617 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2618 Don't assume glyph table len fits in int.
2619 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2620 (row_table_size): Now ptrdiff_t, not int.
2621 (scrolling_window): Avoid overflow in size calculations.
2622 Don't update size until allocation succeeds.
2623 * fns.c (concat): Check for overflow in size calculations.
2624 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2625 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2626 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2627
2628 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2629 (get_doc_string): Check for size calculation overflow.
2630 Don't update size until allocation succeeds.
2631 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2632 EMACS_INT, where ptrdiff_t will do.
2633 (Fsubstitute_command_keys): Check for string overflow.
2634
2635 * editfns.c (set_time_zone_rule): Don't assume environment length
2636 fits in int.
2637 (message_length): Now ptrdiff_t, not int.
2638 (Fmessage_box): Don't update size until allocation succeeds.
2639 Don't assume message length fits in int.
2640 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2641
0065d054
PE
2642 * emacs.c (main): Do not reallocate argv, since there is a null at
2643 the end that can be overwritten, and this way there's no need to
2644 worry about size-calculation overflow.
2645 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2646
2647 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2648 alloc succeeds.
2649 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2650
2651 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2652 (x_set_scroll_bar_width, x_figure_window_size):
2653 Check for integer overflow.
2654 (x_set_alpha): Do not assume XINT fits in int.
2655
2656 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2657 This is for the members text_lines, text_cols, total_lines, total_cols,
2658 where the system imposes an 'int' limit.
2659
2660 * fringe.c (Fdefine_fringe_bitmap):
2661 Don't update size until alloc works.
2662
2663 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2664 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2665
2666 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2667 Check for size-calculation overflow.
2668 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2669 do, as we prefer signed integers.
2670 (id_to_widget.max_size, id_to_widget.used)
2671 (xg_store_widget_in_map, xg_remove_widget_from_map)
2672 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2673 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2674 Use and return ptrdiff_t, not int.
2675 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2676 * gtkutil.h: Change prototypes to match the above.
2677
2678 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2679 are duplicate now that they've been promoted to lisp.h.
2680 (x_allocate_bitmap_record, x_alloc_image_color)
2681 (make_image_cache, cache_image, xpm_load):
2682 Don't update size until alloc is done.
2683 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2684 (x_detect_edges):
3256efce 2685 Check for size calculation overflow.
726e0ab1
PE
2686 (ct_colors_allocated_max): New constant.
2687 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2688 overflow.
3256efce 2689
726e0ab1
PE
2690 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2691 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2692 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2693 Use ptrdiff_t, not int, to count maps.
2694 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2695 calculations. Don't update size until allocation succeeds.
2696 Redo calculations to avoid overflow.
726e0ab1
PE
2697 * keyboard.h: Change prototypes to match the above.
2698
2699 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2700 to count maps.
2701 (current_minor_maps): Check for size calculation overflow.
2702 * keymap.h: Change prototypes to match the above.
2703
2704 * lread.c (read1, init_obarray): Don't update size until alloc done.
2705
2706 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2707 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2708
726e0ab1
PE
2709 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2710 Now ptrdiff_t, not int.
2711 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2712 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2713
2714 * process.c (Fnetwork_interface_list): Check for overflow
2715 in size calculation.
2716
2717 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2718
2719 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2720 overflow. Don't bother calling xmalloc when xrealloc will do.
2721
2722 * search.c (Freplace_match): Check for size calculation overflow.
2723 (Fset_match_data): Don't assume list lengths fit in 'int'.
2724
2725 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2726 for command line length. Do not attempt to address one before the
2727 beginning of an array, as that's not portable.
2728
2729 * term.c (max_frame_lines): Remove; unused.
2730 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2731 not int.
2732 (encode_terminal_code, calculate_costs): Check for size
2733 calculation overflow.
2734 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2735 table lengths and related sizes. Don't update size until alloc
2736 done. Redo calculations to avoid overflow.
2737 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2738
2739 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2740 subtracting pointers.
2741 (gobble_line): Check for overflow more carefully. Don't update size
2742 until alloc done.
2743
2744 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2745 Don't update size until alloc done.
2746 Redo size calculations to avoid overflow.
2747 Check for size calculation overflow.
0065d054 2748 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2749
2750 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2751 Use ptrdiff_t, not int, for sizes.
2752 (store_mode_line_noprop_char): Don't update size until alloc done.
2753
0065d054
PE
2754 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2755 Use ptrdiff_t, not int, for sizes.
2756 (Finternal_make_lisp_face, cache_face):
2757 Check for size calculation overflow.
2758 (cache_face): Treat size calculation overflows as if they were
2759 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2760
2761 * xfns.c (x_encode_text, x_set_name_internal)
2762 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2763 sizes, since they can exceed INT_MAX in size. Check for size
2764 calculation overflow.
2765
0065d054
PE
2766 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2767 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2768 Don't update size until alloc done.
2769
0065d054 2770 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2771 as sprintf is limited to int lengths.
1d526e2f 2772
252c5ee1
PE
2773 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2774 (X_LONG_MIN): New macros.
864d7ce7
PE
2775 Use them to make the following changes clearer.
2776 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2777 This change doesn't affect the value now, but it may help remind
2778 future maintainers not to raise the value too much later.
2779 (SELECTION_QUANTUM): Remove, replacing with ...
2780 (selection_quantum): ... new function, which avoids overflow.
2781 All uses changed.
2782 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2783 assumption that selection length fits in 'int'.
2784 (x_reply_selection_request, x_handle_selection_request)
2785 (x_get_window_property, receive_incremental_selection)
2786 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2787 (lisp_data_to_selection_data, clean_local_selection_data):
2788 Use ptrdiff_t, not int, to record length of selection.
2789 (x_reply_selection_request, x_get_window_property)
2790 (receive_incremental_selection, x_property_data_to_lisp):
2791 Redo calculations to avoid overflow.
2792 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2793 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2794 something.
2795 (x_get_window_property, receive_incremental_selection)
2796 (lisp_data_to_selection_data, x_property_data_to_lisp):
2797 Check for size-calculation overflow.
2798 (x_get_window_property, receive_incremental_selection)
2799 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2800 Don't store size until memory allocation succeeds.
2801 (x_get_window_property): Plug memory leak on memory exhaustion.
2802 Don't double-block input; malloc is safe here. Don't assume 2**34
2803 - 4 fits in unsigned long. Add an xassert to check
2804 XGetWindowProperty overflow. Be more careful about overflow
2805 calculations, and distinguish size from memory overflow better.
2806 (receive_incremental_selection): When tracing, don't assume
2807 unsigned int is less than INT_MAX.
2808 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2809 harmful) conversions of unsigned short to int.
2810 (lisp_data_to_selection_data): Don't assume that integers
2811 in the range -65535 through -1 fit in an X unsigned short.
2812 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2813 result parameters unless successful. Rely on cons_to_unsigned
2814 to report problems with elements; the old code wasn't right anyway.
2815 (x_check_property_data): Check for int overflow; we cannot use
2816 a wider type due to X limits.
2817 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2818
726e0ab1 2819 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2820
0065d054
PE
2821 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2822 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2823 (x_color_cells): Don't store size until memory allocation succeeds.
2824 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2825 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2826 (x_term_init): Don't assume length fits in int (sprintf is limited
2827 to int size).
bc18e09d 2828
ebfa62c0
PE
2829 Use ptrdiff_t for composition IDs.
2830 * character.c (lisp_string_width):
2831 * composite.c (composition_table_size, n_compositions)
2832 (get_composition_id, composition_gstring_from_id):
2833 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2834 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2835 * window.c (Frecenter):
2836 Use ptrdiff_t, not int, for composition IDs.
2837 * composite.c (get_composition_id): Check for integer overflow.
2838 * composite.h: Adjust prototypes to match the above changes.
2839
d3411f89
PE
2840 Use ptrdiff_t for hash table indexes.
2841 * category.c (hash_get_category_set):
2842 * ccl.c (ccl_driver):
2843 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2844 * coding.c (coding_system_charset_list, detect_coding_system):
2845 * coding.h (struct coding_system.id):
2846 * composite.c (get_composition_id, gstring_lookup_cache):
2847 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2848 * image.c (xpm_get_color_table_h):
2849 * lisp.h (hash_lookup, hash_put):
2850 * minibuf.c (Ftest_completion):
2851 Use ptrdiff_t for hash table indexes, not int (which is too
2852 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2853 32-bit --with-wide-int hosts).
2854
e097a6fa
PE
2855 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2856 Add a FIXME comment about memory leaks.
2857 (syms_of_charset): Don't assume xmalloc returns.
2858
5637687f
PE
2859 Don't assume that stated character widths fit in int.
2860 * character.c (Fchar_width, c_string_width, lisp_string_width):
2861 * character.h (CHAR_WIDTH):
2862 * indent.c (MULTIBYTE_BYTES_WIDTH):
2863 Use sanitize_char_width to avoid undefined and/or bad behavior
2864 with outlandish widths.
a66cfb1c 2865 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2866 now that we have two such functions. All uses changed.
2867 (sanitize_char_width): New inline function.
2868
a2271ba2
PE
2869 Don't assume that tab-width fits in int.
2870 * character.h (sanitize_width): New inline function.
2871 (SANE_TAB_WIDTH): New macro.
2872 (ASCII_CHAR_WIDTH): Use it.
2873 * indent.c (sane_tab_width): Remove. All uses replaced by
2874 SANE_TAB_WIDTH (current_buffer).
2875 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2876
18c52557
PE
2877 * fileio.c: Integer overflow issues with file modes.
2878 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2879
caeeedc1
PE
2880 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2881 Remove unreachable code.
2882 (read_hex, load_charset_map_from_file): Check for integer overflow.
2883
6df6ae42 2884 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2885 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2886 (x_send_scroll_bar_event): Likewise. Check that the size does not
2887 exceed limits imposed by XClientMessageEvent, as well as the usual
2888 ptrdiff_t and size_t limits.
2889
b13995db
PE
2890 * keyboard.c: Overflow, signedness and related fixes.
2891 (make_lispy_movement): Use same integer type in forward decl
2892 that is used in the definition.
2893 (read_key_sequence, keyremap_step):
2894 Change bufsize argument back to int, undoing my 2011-03-30 change.
2895 We prefer signed types, and int is wide enough here.
2896 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2897 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2898 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2899 length, not size_t. Use ptrdiff_t for index, not int.
2900 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2901 possibility of integer overflow.
2902
13464394
PE
2903 Overflow, signedness and related fixes for images.
2904
2905 * dispextern.h (struct it.stack[0].u.image.image_id)
2906 (struct_it.image_id, struct image.id, struct image_cache.size)
2907 (struct image_cache.used, struct image_cache.ref_count):
2908 * gtkutil.c (update_frame_tool_bar):
2909 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2910 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2911 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2912 * nsmenu.m (update_frame_tool_bar):
2913 * xdisp.c (calc_pixel_width_or_height):
2914 * xfns.c (image_cache_refcount):
2915 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2916 on typical 64-bit hosts.
2917
2918 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2919 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2920 Omit unnecessary casts to int.
2921 (parse_image_spec): Check that integers fall into 'int' range
2922 when the callers expect that.
2923 (image_ascent): Redo ascent calculation to avoid int overflow.
2924 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2925 (lookup_image): Remove unnecessary tests.
2926 (xbm_image_p): Locals are now of int, not EMACS_INT,
2927 since parse_image_check makes sure they fit into int.
2928 (png_load, gif_load, svg_load_image):
2929 Prefer int to unsigned where either will do.
2930 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2931 old tiff_error_handler and tiff_warning_handler.
2932 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2933 stack buffer overflows. It uses only the features of vsnprintf
2934 that are common to both POSIX and native Microsoft.
2935 (tiff_error_handler, tiff_warning_handler): Use it.
2936 (tiff_load, gif_load, imagemagick_load_image):
2937 Don't assume :index value fits in 'int'.
2938 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2939 (imagemagick_load_image): Check that crop parameters fit into
2940 the integer types that MagickCropImage accepts. Don't assume
2941 Vimagemagick_render_type has a nonnegative value. Don't assume
2942 size_t fits in 'long'.
2943 (gs_load): Use printmax_t to print the widest integers possible.
2944 Check for integer overflow when computing image height and width.
2945
c11821d4
EZ
29462011-08-26 Eli Zaretskii <eliz@gnu.org>
2947
2948 * xdisp.c (redisplay_window): Don't force window start if point
2949 will be invisible in the resulting window. (Bug#9324)
2950
0c95fcf7
EZ
29512011-08-25 Eli Zaretskii <eliz@gnu.org>
2952
2953 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2954 the display spec is of the form `(space ...)'.
2955 (handle_display_spec): Return the value returned by
2956 handle_single_display_spec, not just 1 or zero.
2957 (handle_single_display_spec): If the display spec is of the form
2958 `(space ...)', and specifies display in the text area, return 2
2959 rather than 1.
fee65a97 2960 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2961 accurately, and prefer exact match for point under bidi.
2962 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2963
2964 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2965 into disp_prop; all users changed.
2966
2967 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2968 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2969 for the text covered by the display property.
2970
e4ed06f1
CY
29712011-08-25 Chong Yidong <cyd@stupidchicken.com>
2972
2973 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2974 Change return value to nil.
2975 (Frecord_buffer): Delete unused function.
2976
f67cdd7f
EZ
29772011-08-24 Eli Zaretskii <eliz@gnu.org>
2978
5980d4c6
EZ
2979 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2980 buffers, return left-to-right.
8610fe8b
EZ
2981 (set_cursor_from_row): Consider candidate row a win if its glyph
2982 represents a newline and point is on that newline. Fixes cursor
2983 positioning on the newline at EOL of R2L text within L2R
2984 paragraph, and vice versa.
2985 (try_cursor_movement): Check continued rows, in addition to
2986 continuation rows. Fixes unwarranted scroll when point enters a
2987 continued line of R2L text within an L2R paragraph, or vice versa.
2988 (cursor_row_p): Consider the case of point being equal to
2989 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2990 from the end of a short line to the beginning of a continued line
2991 of R2L text within L2R paragraph.
2992 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2993 composed characters.
5980d4c6 2994
f67cdd7f
EZ
2995 * bidi.c (bidi_check_type): Use xassert.
2996 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2997 members.
2998
bca633fb
EZ
29992011-08-23 Eli Zaretskii <eliz@gnu.org>
3000
3001 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3002 a character.
3003
4a5885a7
CY
30042011-08-23 Chong Yidong <cyd@stupidchicken.com>
3005
3006 * nsfont.m (ns_otf_to_script): Fix typo.
3007
0902a04e
KH
30082011-08-22 Kenichi Handa <handa@m17n.org>
3009
3010 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3011 extra slot even if the purpose is char-code-property-table.
3012
1a2e6670
EZ
30132011-08-23 Eli Zaretskii <eliz@gnu.org>
3014
8ddde651
EZ
3015 * xdisp.c (redisplay_window): When computing centering_position,
3016 account for the height of the header line. (Bug#8874)
3017
425cc014
EZ
3018 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3019 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3020 candidate is selected by the mouse, and that candidate has a
3021 composed character under the mouse.
3022
1a2e6670
EZ
3023 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3024 coordinates reported by pos-visible-in-window-p for a composed
3025 character in column zero.
3026
8b76d6f8
SM
30272011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3028
3029 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3030
dac347dd
EZ
30312011-08-22 Eli Zaretskii <eliz@gnu.org>
3032
3033 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3034 consider it a hit if to_charpos is anywhere in the range of the
3035 composed buffer positions.
3036
e013fb34
CY
30372011-08-22 Chong Yidong <cyd@stupidchicken.com>
3038
3039 * image.c (gif_load): Don't assume that each subimage has the same
3040 dimensions as the base image. Handle disposal method that is
3041 "undefined" by the gif spec (Bug#9335).
3042
bd1ba3e8
CY
30432011-08-20 Chong Yidong <cyd@stupidchicken.com>
3044
3045 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3046 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3047
54a1215b
EZ
30482011-08-19 Eli Zaretskii <eliz@gnu.org>
3049
823564e5
EZ
3050 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3051 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3052 from an Org mode buffer to a Speedbar frame.
3053
54a1215b
EZ
3054 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3055 a composition, take its buffer position from IT->cmp_it.charpos.
3056 Fixes cursor positioning at the beginning of a line that begins
3057 with a composed character.
3058
9778ebcc
EZ
30592011-08-18 Eli Zaretskii <eliz@gnu.org>
3060
0be6ee06
EZ
3061 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3062 character bidirectional type, use STRONG_L instead. Fixes crashes
3063 in a buffer produced by `describe-categories'.
3064
9778ebcc
EZ
3065 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3066 members before the level stack, so they would be saved and
3067 restored when copying iterator state. Fixes incorrect reordering
3068 around TABs covered by display properties.
3069
156bffbe
AS
30702011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3071
6b02f655 3072 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3073
72ad093b
CY
30742011-08-17 Chong Yidong <cyd@stupidchicken.com>
3075
3076 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3077 (internal_condition_case_2, internal_condition_case_n):
3078 Remove unnecessary aborts (Bug#9081).
72ad093b 3079
35774242
EZ
30802011-08-17 Eli Zaretskii <eliz@gnu.org>
3081
3082 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3083 has no `load' handler, try opening the file locally. (Bug#9311)
3084
db76dd85
KB
30852011-08-16 Ken Brown <kbrown@cornell.edu>
3086
3087 * gmalloc.c: Expand comment.
3088
b215eee5
EZ
30892011-08-16 Eli Zaretskii <eliz@gnu.org>
3090
3091 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3092 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3093
a4579d33
KB
30942011-08-16 Ken Brown <kbrown@cornell.edu>
3095
3096 Fix memory allocation problems in Cygwin build (Bug#9273).
3097
3098 * unexcw.c ( __malloc_initialized): Declare external variable.
3099 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3100
8b76d6f8
SM
3101 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3102 New variables.
a4579d33
KB
3103 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3104 dumped emacs.
3105 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3106 in the static heap.
3107 [CYGWIN] (special_realloc): New function.
3108 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3109 requests to realloc storage in the static heap.
3110
3ebec551
PE
31112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 * bidi.c (bidi_initialize): Remove unused local.
3114
9fd8be00
EZ
31152011-08-15 Eli Zaretskii <eliz@gnu.org>
3116
6b02f655
SM
3117 * bidimirror.h:
3118 * biditype.h: Remove file.
3119 * makefile.w32-in ($(BLD)/bidi.$(O)):
3120 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3121
3122 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3123
3124 * chartab.c: Improve commentary for the uniprop_table API.
3125
32413314
EZ
3126 * bidi.c (bidi_paragraph_init): Support zero value of
3127 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3128 (bidi_initialize): Use uniprop_table instead of including
3129 biditype.h and bidimirror.h.
32413314 3130
9fd8be00
EZ
3131 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3132 coordinates of the iterator when restoring from ppos_it.
3133 (Bug#9296)
3134
5cf2b69b
KH
31352011-08-14 Kenichi Handa <handa@m17n.org>
3136
3137 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3138 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3139
daf17d00
EZ
31402011-08-14 Eli Zaretskii <eliz@gnu.org>
3141
3142 * xdisp.c (move_it_in_display_line_to): Don't invoke
3143 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3144 ppos_it. Fixes vertical cursor motion when line beginning is
3145 covered by an image. (Bug#9296)
3146
08e3161a
JD
31472011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3148
3149 * nsterm.h (ns_run_ascript): Declare.
3150 (NSAPP_DATA2_RUNASSCRIPT): Define.
3151
3152 * nsfns.m (as_script, as_result, as_status): New static variables.
3153 (ns_run_ascript): New function.
5e617bc2 3154 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3155 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3156 the event loop. Get status from as_status (Bug#7276).
3157
3158 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3159 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3160 the event loop (Bug#7276).
3161
a3720aa2
AS
31622011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3163
3164 * gnutls.c (QCgnutls_bootprop_priority)
3165 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3166 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3167 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3168 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3169 (QCgnutls_bootprop_verify_hostname_error)
3170 (QCgnutls_bootprop_callbacks_verify): Rename from
3171 Qgnutls_bootprop_..., all uses changed.
3172
3173 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3174 uses changed.
3175
0a0d27fb
PE
31762011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3177
19d5c50c
PE
3178 * xfaces.c (Qframe_set_background_mode): Now static.
3179 * dispextern.h (Qframe_set_background_mode): Remove decl.
3180
0a0d27fb
PE
3181 * process.c (Fnetwork_interface_info): Declare local only if needed.
3182
377538cb
JD
31832011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3184
3185 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3186 (Fnetwork_interface_list): Allocate in increments of bytes instead
3187 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3188 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3189 sockaddr.
3190 (struct ifflag_def): notrailers is smart on OSX.
3191 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3192 Get hardware address with getifaddrs if available.
3193
08fff70c
EZ
31942011-08-12 Eli Zaretskii <eliz@gnu.org>
3195
3196 * xdisp.c (iterate_out_of_display_property): xassert that
3197 IT->position is set to within IT->object's boundaries. Break from
3198 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3199 when IT->position is set up wrongly due to some bug.
3200 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3201 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3202 entry. Force push_it to save on the stack the current
3203 buffer/string position, to be restored by pop_it. Fix flags in
3204 the iterator structure wrt the object coming from a display
3205 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3206 properties. (Bug#9284)
3207
7be1c708 32082011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3209
7be1c708
CY
3210 * fontset.c (fontset_get_font_group): Add proper type checks.
3211 (Bug#9172)
aac0c6e3 3212
7be1c708 32132011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3214
7be1c708
CY
3215 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3216 and LC_VERSION_MIN_MACOSX.
3217 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3218 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3219
97bb72a6
EZ
32202011-08-08 Eli Zaretskii <eliz@gnu.org>
3221
3222 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3223 no-display-properties-and-no-overlays under bidi display.
3224 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3225 properties and overlays.
97bb72a6 3226
d5617611
CY
32272011-08-08 Chong Yidong <cyd@stupidchicken.com>
3228
37e11a63
CY
3229 * editfns.c (Fset_time_zone_rule): Document relationship with the
3230 setenv function.
3231
d5617611
CY
3232 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3233 the font entity extracted from the cache (Bug#8109).
3234
58872834
CY
32352011-08-07 Chong Yidong <cyd@stupidchicken.com>
3236
3237 * composite.c (autocmp_chars): Don't reset point. That is done by
3238 restore_point_unwind (Bug#5984).
3239
75bfc667
JL
32402011-08-07 Juri Linkov <juri@jurta.org>
3241
3242 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3243 to show the arg `TIME' instead of `TIMEVAL'.
3244
d1410150
EZ
32452011-08-06 Eli Zaretskii <eliz@gnu.org>
3246
3247 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3248 display property strides EOL and includes a newline, as in
3249 longlines-mode. (Bug#9254)
75b771e4
EZ
3250 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3251 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3252
3253 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3254 is non-zero, even if the data buffer is NULL. Fixes a crash in
3255 vertical-motion with longlines-mode. (Bug#9254)
3256
35928349
EZ
32572011-08-05 Eli Zaretskii <eliz@gnu.org>
3258
ec7cc85b
EZ
3259 * bidi.c <bidi_cache_total_alloc>: Now static.
3260 (bidi_initialize): Initialize bidi_cache_total_alloc.
3261
8b76d6f8 3262 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3263 cache. (Bug#9221)
3264
3265 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3266 amount allocated this far in `bidi_cache_total_alloc'.
3267 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3268 non-zero, only free the data buffer without restoring the cache
3269 contents. All callers changed.
3270
3271 * dispextern.h (bidi_unshelve_cache): Update prototype.
3272
3273 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3274 (move_it_in_display_line, move_it_to)
3275 (move_it_vertically_backward, move_it_by_lines): Replace the call
3276 to xfree to an equivalent call to bidi_unshelve_cache.
3277 (move_it_in_display_line_to): Fix logic of returning
412b6358 3278 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3279
e2e2423b
EZ
32802011-08-05 Eli Zaretskii <eliz@gnu.org>
3281
3282 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3283 came from a string character with a `cursor' property. (Bug#9229)
3284
ae9e757a
JD
32852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3286
3287 * Makefile.in (LIB_PTHREAD): New variable.
3288 (LIBES): Add LIB_PTHREAD (Bug#9216).
3289
3290 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3291 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3292
213bd7f2
AS
32932011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3294
6b02f655 3295 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3296
99aaf75f
JD
32972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3298
3299 * xterm.c (x_find_topmost_parent): New function.
3300 (x_set_frame_alpha): Find topmost parent window with
3301 x_find_topmost_parent and set the property there also (bug#9181).
3302 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3303
c74e9d86
PE
33042011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 * callproc.c (Fcall_process): Avoid vfork clobbering
3307 the local vars buffer, coding_systems, current_dir.
3308
640c8776
SM
33092011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3310
3311 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3312
f26d0e4c
PE
33132011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3314
8a10d76c
PE
3315 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3316 so that it is not optimized away.
3317
f26d0e4c
PE
3318 * xdisp.c (compute_display_string_pos): Remove unused local.
3319
55439c61
EZ
33202011-08-02 Eli Zaretskii <eliz@gnu.org>
3321
3322 Fix slow cursor motion and scrolling in large buffers with
3323 selective display, like Org Mode buffers. (Bug#9218)
3324
3325 * dispextern.h (struct bidi_it): New member disp_prop_p.
3326
3327 * xdisp.c: Remove one-slot cache of display string positions.
3328 (compute_display_string_pos): Accept an additional argument
5e617bc2 3329 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3330 for a display string or property. If found, set DISP_PROP_P
3331 non-zero.
3332
3333 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3334 DISP_PROP_P, and pass it to compute_display_string_pos.
3335 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3336 non-zero. All callers of bidi_fetch_char changed.
3337
fb33fa43
SM
33382011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3339
3340 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3341
b099e063
DM
33422010-12-03 Don March <don@ohspite.net>
3343
3344 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3345 last character M-[char] is translated to ESC [char] (bug#7541).
3346
5cc7f7af
KH
33472011-08-02 Kenichi Handa <handa@m17n.org>
3348
d0fffa3f 3349 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3350
3351 * chartab.c (uniprop_table): Make it non-static.
3352
525d5e6e
EZ
33532011-08-01 Eli Zaretskii <eliz@gnu.org>
3354
3355 * xdisp.c (forward_to_next_line_start): Accept additional argument
3356 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3357 on the newline.
3358 (reseat_at_next_visible_line_start): Use the bidi iterator state
3359 returned by forward_to_next_line_start to restore the state of
3360 it->bidi_it after backing up to previous newline. (Bug#9212)
3361
31011111
AS
33622011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3363
3364 * regex.c (re_comp): Protoize.
3365 (re_exec): Fix return type.
3366 (regexec): Fix type of `ret'. (Bug#9203)
3367
476371c4
PE
33682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3369
e5d76069
PE
3370 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3371 This is needed if max-image-size is a floating-point number.
3372
9a79b20c
AS
33732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3374
3375 * print.c (print_object): Print empty symbol as ##.
3376
3377 * lread.c (read1): Read ## as empty symbol.
3378
d8c2fa78
AA
33792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3380
3381 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3382 setting frame foreground color (Bug#9175).
3383 (x_set_background_color): Likewise.
3384
ffe57a7a
AA
3385 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3386 contents (Bug#9176).
3387 (EmacsTooltip -init): Remove bezels and add shadows to
3388 tooltip windows.
3389
bf3492a5
AA
3390 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3391 or scroll bar (Bug#8470).
3392
d55e9c53
AA
3393 * nsfont.m (nsfont_open): Remove assignment to voffset and
3394 unnecessary vars hshink, expand, hd, full_height, min_height.
3395 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3396
3397 * nsterm.h (nsfont_info): Remove voffset field.
3398
d8c2fa78 33992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3400
3401 Implement strike-through and overline on NextStep (Bug#8863).
3402
3403 * nsfont.m (nsfont_open): Use underline position provided by font,
3404 instead of hard-coded value of 2.
3405 (nsfont_draw): Call ns_draw_text_decoration instead.
3406
3407 * nsterm.h: Add declaration for ns_draw_text_decoration.
3408
3409 * nsterm.m (ns_draw_text_decoration): New function for drawing
3410 underline, overline, and strike-through.
3411 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3412 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3413 accommodate underlining, etc.
4843aac3 3414
4cc60b9b
EZ
34152011-07-28 Eli Zaretskii <eliz@gnu.org>
3416
bc7ece87
EZ
3417 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3418 default.
4cc60b9b 3419
476371c4
PE
34202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3421
66606eea
PE
3422 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3423 Without this fix, if a signal arrives just after memory fills up,
3424 'malloc' might be invoked reentrantly.
3425
476371c4
PE
3426 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3427 In other words, assume that every image size is allowed, on non-X
3428 hosts. This assumption is probably wrong, but it lets Emacs compile.
3429
f3fcc40d
AS
34302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3431
3432 * regex.c (re_iswctype): Convert return values to boolean.
3433
350c992f
EZ
34342011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3435
3436 * xdisp.c (compute_display_string_pos): Don't use cached display
3437 string position if the buffer had its restriction changed.
3438 (Bug#9184)
3439
5266b4bb
PE
34402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3441
3442 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3443
2573a837 34442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3445
41f55ccd 3446 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3447
39e378da
PE
3448 * bidi.c: Integer size and overflow fixes.
3449 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3450 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3451 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3452 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3453 (bidi_find_other_level_edge):
3454 Use ptrdiff_t instead of EMACS_INT where either will do.
3455 This works better on 32-bit hosts configured --with-wide-int.
3456 (bidi_cache_ensure_space): Check for size-calculation overflow.
3457 Use % rather than repeated addition, for better worst-case speed.
3458 Don't set bidi_cache_size until after xrealloc returns, because it
3459 might not return.
3460 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3461 (bidi_cache_ensure_space): Also check that the bidi cache size
3462 does not exceed that of the largest Lisp string or buffer. See Eli
3463 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3464
5e927815
PE
3465 * alloc.c (__malloc_size_t): Remove.
3466 All uses replaced by size_t. See Andreas Schwab's note
3467 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3468
ca4aa935
PE
3469 * image.c: Improve checking for integer overflow.
3470 (check_image_size): Assume that f is nonnull, since
3471 it is always nonnull in practice. This is one less thing to
3472 worry about when checking for integer overflow later.
3473 (x_check_image_size): New function, which checks for integer
3474 overflow issues inside X.
3475 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3476 This removes the need for a memory_full check.
3477 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3478 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3479 (xbm_read_bitmap_data): Change locals back to 'int', since
3480 their values must fit in 'int'.
3481 (xpm_load_image, png_load, tiff_load):
3482 Invoke x_create_x_image_and_pixmap earlier,
3483 to avoid much needless work if the image is too large.
3484 (tiff_load): Treat overly large images as if
3485 x_create_x_image_and_pixmap failed, not as malloc failures.
3486 (gs_load): Use x_check_image_size.
3487
5f8f9cc2
PE
3488 * gtkutil.c: Omit integer casts.
3489 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3490 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3491
5adf60bc
PE
3492 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3493
c8907a93
PE
3494 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3495 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3496 would wrongly return t on a 64-bit host.
3497
e3c25c68
PE
3498 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3499 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3500 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3501 and therefore cause GCC to emit a bogus diagnostic in some cases.
3502
3f791afe
PE
3503 * image.c: Integer signedness and overflow and related fixes.
3504 This is not an exhaustive set of fixes, but it's time to
3505 record what I've got.
3506 (lookup_pixel_color, check_image_size): Remove redundant decls.
3507 (check_image_size): Don't assume that arbitrary EMACS_INT values
3508 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3509 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3510 (tiff_load, imagemagick_load_image):
3511 Check for overflow in size calculations.
3512 (x_create_x_image_and_pixmap): Remove unnecessary test for
3513 xmalloc returning NULL; that can't happen.
3514 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3515 (xpm_color_bucket): Use better integer hashing function.
3516 (xpm_cache_color): Don't possibly over-allocate memory.
3517 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3518 (gif_memory_source):
3519 Use ptrdiff_t, not int or size_t, to record sizes.
3520 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3521 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3522 either works, as we prefer signed integers.
3523 (tiff_read_from_memory, tiff_write_from_memory):
3524 Return tsize_t, not size_t, since that's what the TIFF API wants.
3525 (tiff_read_from_memory): Don't fail simply because the read would
3526 go past EOF; instead, return a short read.
3527 (tiff_load): Omit no-longer-needed casts.
3528 (Fimagemagick_types): Don't assume size fits into 'int'.
3529
3cc5a532
PE
3530 Improve hashing quality when configured --with-wide-int.
3531 * fns.c (hash_string): New function, taken from sxhash_string.
3532 Do not discard information about ASCII character case; this
3533 discarding is no longer needed.
3534 (sxhash-string): Use it. Change sig to match it. Caller changed.
3535 * lisp.h: Declare it.
3536 * lread.c (hash_string): Remove, since we now use fns.c's version.
3537 The fns.c version returns a wider integer if --with-wide-int is
3538 specified, so this should help the quality of the hashing a bit.
3539
b312a492
PE
3540 * emacs.c: Integer overflow minor fix.
3541 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3542 Define only if GNU_LINUX.
3543 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3544
dfd153ae
PE
3545 * dispnew.c: Integer signedness and overflow fixes.
3546 Remove unnecessary forward decls, that were a maintenance hassle.
3547 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3548 All uses changed.
3549 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3550 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3551 (prepare_desired_row, line_draw_cost):
3552 Use int, not unsigned, where either works.
3553 (save_current_matrix, restore_current_matrix):
3554 Use ptrdiff_t, not size_t, where either works.
3555 (init_display): Check for overflow more accurately, and without
3556 relying on undefined behavior.
3557
a81d11a3
PE
3558 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3559 Remove, replacing with the new symbols in lisp.h. All uses changed.
3560 * fileio.c (make_temp_name):
3561 * filelock.c (lock_file_1, lock_file):
3562 * xdisp.c (message_dolog):
3563 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3564 Use pMd etc. instead.
3565 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3566 replacing the pWIDE etc. symbols removed from editfns.c.
3567
3300e6fd
PE
3568 * keyboard.h (num_input_events): Now uintmax_t.
3569 This is (very slightly) less likely to mess up due to wraparound.
3570 All uses changed.
3571
fd05c7e9
PE
3572 * buffer.c: Integer signedness fixes.
3573 (alloc_buffer_text, enlarge_buffer_text):
3574 Use ptrdiff_t rather than size_t when either will do, as we prefer
3575 signed integers.
3576
903fe15d
PE
3577 * alloc.c: Integer signedness and overflow fixes.
3578 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3579 (__malloc_size_t): Default to size_t, not to int.
3580 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3581 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3582 Prefer ptrdiff_t to size_t when either would do, as we prefer
3583 signed integers.
3584 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3585 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3586 Now const. Initialize with values that are in range even if char
3587 is signed.
3588 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3589 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3590 These functions do the right thing with sizes > 2**32.
3591 (check_depth): Now ptrdiff_t, not int.
3592 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3593 Adjust to new way of storing sizes. Check for size overflow bugs
3594 in rest of code.
3595 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3596 slightly wrong anyway, as it missed one instance of
3597 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3598 (refill_memory_reserve): Omit needless cast to size_t.
3599 (mark_object_loop_halt): Mark as externally visible.
3600
ac82cc6a
PE
3601 * xselect.c: Integer signedness and overflow fixes.
3602 (Fx_register_dnd_atom, x_handle_dnd_message):
3603 Use ptrdiff_t, not size_t, since we prefer signed.
3604 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3605 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3606 x_dnd_atoms_size and x_dnd_atoms_length.
3607
c2d1e36d
PE
3608 * doprnt.c: Prefer signed to unsigned when either works.
3609 * eval.c (verror):
3610 * doprnt.c (doprnt):
3611 * lisp.h (doprnt):
3612 * xdisp.c (vmessage):
3613 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3614 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3615 prefer signed arithmetic to avoid comparison confusion.
3616 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3617 but is a bit tricky.
3618
0e926e56
PE
3619 Assume freestanding C89 headers, string.h, stdlib.h.
3620 * data.c, doprnt.c, floatfns.c, print.c:
3621 Include float.h unconditionally.
3622 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3623 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3624 * regex.c: Likewise for stddef.h, string.h.
3625 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3626 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3627 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3628 (STDC_HEADERS): Remove obsolete defines.
3629 * sysdep.c: Include limits.h unconditionally.
3630
9cfdb3ec
PE
3631 Assume support for memcmp, memcpy, memmove, memset.
3632 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3633 * regex.c (memcmp, memcpy):
3634 Remove; we assume C89 now.
3635
3636 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3637 (__malloc_safe_bcopy): Remove; no longer needed.
3638
cf950e6b 3639 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3640 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3641 well either way, and we prefer signed to unsigned.
3642
dbf38e02
LMI
36432011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3644
3645 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3646 closes the connection while we're reading (bug#9182).
3647
d6f0886c 36482011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3649
d6f0886c
JD
3650 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3651 are specified (Bug#9168).
24e0f6b1 3652
2eb1f9e6
PE
36532011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3654
3655 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3656 Found by GCC static checking and --with-wide-int on a 32-bit host.
3657
22381272 36582011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3659
3660 * xdisp.c (compute_display_string_pos): Fix logic of caching
3661 previous display string position. Initialize cached_prev_pos to
3662 -1. Fixes slow-down at the beginning of a buffer.
3663
f25e39b4
EZ
36642011-07-24 Eli Zaretskii <eliz@gnu.org>
3665
3666 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3667 for attrs[LFACE_FONTSET_INDEX].
3668
04c4b52e
PE
36692011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 * xml.c (parse_region): Remove unused local
3672 that was recently introduced.
3673
c1734fbd
EZ
36742011-07-23 Eli Zaretskii <eliz@gnu.org>
3675
be18c5a5
EZ
3676 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3677 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3678
c1734fbd
EZ
3679 * xdisp.c (move_it_in_display_line_to): Record the best matching
3680 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3681 exit if none of the characters scanned was an exact match.
3682 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3683 when exact match is impossible due to invisible text, and the
3684 lines are truncated.
3685
a258d627
JD
36862011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3687
3688 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3689 for OSX >= 10.7.
3690
b6d5a689
EZ
36912011-07-22 Eli Zaretskii <eliz@gnu.org>
3692
0f74f785
EZ
3693 Fix a significant slow-down of cursor motion with C-n, C-p,
3694 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3695 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3696 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3697 (next_element_from_buffer): Call compute_stop_pos_backwards to
3698 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3699 base_level_stop.
3700 (reseat): Don't look for prev_stop, as that could mean a very long
3701 run.
3702 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3703 <cached_disp_overlay_modiff>: Cache for last found display string
3704 position.
551918c1 3705 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3706 about the same buffer in the same area of character positions, and
3707 the buffer wasn't changed since the time the display string
3708 position was cached.
551918c1 3709
b2d0c91a
EZ
37102011-07-22 Eli Zaretskii <eliz@gnu.org>
3711
3712 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3713 is an integer, which is important for empty lines. (Bug#9149)
3714
043604ee
CY
37152011-07-22 Chong Yidong <cyd@stupidchicken.com>
3716
3717 * frame.c (Fmodify_frame_parameters): In tty case, update the
3718 default face if necessary (Bug#4238).
3719
da4adb04
CY
37202011-07-21 Chong Yidong <cyd@stupidchicken.com>
3721
3722 * editfns.c (Fstring_to_char): No need to explain what a character
3723 is in the docstring (Bug#6576).
3724
9abd0532
LMI
37252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3726
3727 * xml.c (parse_region): Make sure we always return a tree.
3728
36881d16
HK
37292011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3730
3731 * xml.c (parse_region): If a document contains only comments,
3732 return that, too.
3733
1e98674d
LMI
37342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3735
3736 * xml.c (make_dom): Return comments, too.
3737
590bd467
PE
37382011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 Port to OpenBSD.
3741 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3742 and the surrounding thread.
3743 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3744 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3745 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3746 timer goes off.
3747 * s/openbsd.h (BROKEN_SIGIO): Define.
3748 * unexelf.c (unexec) [__OpenBSD__]:
3749 Don't update the .mdebug section of the Alpha COFF symbol table.
3750
f41628b2
LMI
37512011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3752
3753 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3754 (bug#8460).
3755
b59b67c5
PE
37562011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3757
15e3a074
PE
3758 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3759 This fixes some race conditions on the permissions of any newly
3760 created file.
3761
41bed37d
PE
3762 * alloc.c (valid_pointer_p): Use pipe, not open.
3763 This fixes some permissions issues when debugging.
3764
b59b67c5
PE
3765 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3766 If fchown fails to set both uid and gid, try to set just gid,
3767 as that is sometimes allowed. Adjust the file's mode to eliminate
3768 setuid or setgid bits that are inappropriate if fchown fails.
3769
925a6be7
SM
37702011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3771
3772 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3773 to compare Lisp_Objects.
3774 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3775 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3776 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3777
52968808
AS
37782011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3779
0a6a104b
AS
3780 * lread.c (read_integer): Unread even EOF character.
3781 (read1): Likewise. Properly record start position of symbol.
3782
52968808
AS
3783 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3784 symbol character follows.
3785
9e381cdd
PE
37862011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3787
3788 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3789 This works around a problem with the previous change to Fcopy_file.
3790 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3791 and without this change, GCC might complain about discarding
3792 fchown's return value.
3793
b5641435
JB
37942011-07-16 Juanma Barranquero <lekktu@gmail.com>
3795
3796 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3797
a8031457
PE
37982011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3801
dd889327
LMI
38022011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3803
750c33f7
LMI
3804 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3805 it's used from the C level.
3806
dd889327
LMI
3807 * process.c: Use the same condition for POLL_FOR_INPUT in both
3808 keyboard.c and process.c (bug#1858).
3809
87e86684
LM
38102011-07-09 Lawrence Mitchell <wence@gmx.li>
3811
3812 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3813 (Fgnutls_boot): Use it.
3814
64348f40
AS
38152011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3816
3817 * doc.c (Fsubstitute_command_keys): Revert last change.
3818
1d698799
LMI
38192011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3820
f863868c
LMI
3821 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3822 quotes the next character, and doesn't affect other longer
3823 sequences (bug#8935).
3824
1d698799
LMI
3825 * lread.c (syms_of_lread): Clarify that is isn't only
3826 `eval-buffer' and `eval-defun' that's affected by
3827 `lexical-binding' (bug#8460).
3828
aa4b6df6
EZ
38292011-07-15 Eli Zaretskii <eliz@gnu.org>
3830
3831 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3832 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3833
5d856da6
PE
38342011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3835
ad6042bb
PE
3836 Fix minor problems found by static checking.
3837 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3838 (elsz): Now a signed constant, not a size_t var. We prefer signed
3839 types to unsigned, to avoid integer comparison confusion. Without
3840 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3841 "cannot optimize loop, the loop counter may overflow", a symptom
3842 of the confusion.
f00bbb22 3843 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3844 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3845
6468f31c
LMI
38462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3847
49080b10
LMI
3848 * search.c (Fre_search_backward): Mention `case-fold-search' in
3849 all the re_search_* functions (bug#8138).
3850
6468f31c
LMI
3851 * keyboard.c (Fopen_dribble_file): Document when the file is
3852 closed (bug#8056).
3853
c965adc5
EZ
38542011-07-14 Eli Zaretskii <eliz@gnu.org>
3855
df9733bf
EZ
3856 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3857 bidi_cache_idx.
3858
0bb23927
EZ
3859 Support bidi reordering of display and overlay strings.
3860 * xdisp.c (compute_display_string_pos)
3861 (compute_display_string_end): Accept additional argument STRING.
3862 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3863 (reseat_to_string): Initialize bidi_it->string.s and
3864 bidi_it->string.schars.
3865 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3866 NULL (avoids a crash in bidi_paragraph_init).
3867 Initialize itb.string.lstring.
0bb23927
EZ
3868 (init_iterator): Call bidi_init_it only of a valid
3869 buffer position was specified. Initialize paragraph_embedding to
3870 L2R.
3871 (reseat_to_string): Initialize the bidi iterator.
3872 (display_string): If we need to ignore text properties of
3873 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3874 original value of -1 will not work with bidi.)
3875 (compute_display_string_pos): First arg is now struct
3876 `text_pos *'; all callers changed. Support display properties on
3877 Lisp strings.
3878 (compute_display_string_end): Support display properties on Lisp
3879 strings.
3880 (init_iterator, reseat_1, reseat_to_string): Initialize the
3881 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3882 when iterating on a string not from display properties).
640c8776
SM
3883 (compute_display_string_pos, compute_display_string_end):
3884 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3885 arrow keys.
3886 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3887 base_level_stop; instead, set base_level_stop to BEGV.
3888 Fixes crashes in vertical-motion.
0bb23927
EZ
3889 (next_element_from_buffer): Improve commentary for when
3890 the iterator is before prev_stop.
3891 (init_iterator): Initialize bidi_p from the default value of
3892 bidi-display-reordering, not from buffer-local value. Use the
3893 buffer-local value only if initializing for buffer iteration.
3894 (handle_invisible_prop): Support invisible properties on strings
3895 that are being bidi-reordered.
3896 (set_iterator_to_next): Support bidi reordering of C strings and
3897 Lisp strings.
3898 (next_element_from_string): Support bidi reordering of Lisp
3899 strings.
3900 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3901 (display_string): Support display of R2L glyph rows.
3902 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3903 (init_iterator): Don't initialize it->bidi_p for strings
3904 here.
3905 (reseat_to_string): Initialize it->bidi_p for strings here.
3906 (next_element_from_string, next_element_from_c_string)
3907 (next_element_from_buffer): Add xassert's for correspondence
3908 between IT's object being iterated and it->bidi_it.string
3909 structure.
3910 (face_before_or_after_it_pos): Support bidi iteration.
3911 (next_element_from_c_string): Handle the case of the first string
3912 character that is not the first one in the visual order.
3913 (get_visually_first_element): New function, refactored from common
3914 parts of next_element_from_buffer, next_element_from_string, and
3915 next_element_from_c_string.
3916 (tool_bar_lines_needed, redisplay_tool_bar)
3917 (display_menu_bar): Force left-to-right direction. Add a FIXME
3918 comment for making that be controlled by a user option.
3919 (push_it, pop_it): Save and restore the state of the
3920 bidi iterator. Save and restore the bidi_p flag.
3921 (pop_it): Iterate out of display property for string iteration as
3922 well.
3923 (iterate_out_of_display_property): Support iteration over strings.
3924 (handle_single_display_spec): Set up it->bidi_it for iteration
3925 over a display string, and call bidi_init_it.
3926 (handle_single_display_spec, next_overlay_string)
3927 (get_overlay_strings_1, push_display_prop): Set up the bidi
3928 iterator for displaying display or overlay strings.
3929 (forward_to_next_line_start): Don't use the shortcut if
3930 bidi-iterating.
3931 (back_to_previous_visible_line_start): If handle_display_prop
3932 pushed the iterator stack, restore the internal state of the bidi
3933 iterator by calling bidi_pop_it same number of times.
3934 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3935 and we are bidi-iterating, don't decrement the iterator position;
3936 instead, set the first_elt flag in the bidi iterator, to produce
3937 the same effect.
3938 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3939 (push_display_prop): xassert that we are iterating a buffer.
3940 (push_it, pop_it): Save and restore paragraph_embedding member.
3941 (handle_single_display_spec, next_overlay_string)
3942 (get_overlay_strings_1, reseat_1, reseat_to_string)
3943 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3944 correctly. Don't assume unibyte strings are not bidi-reordered.
3945 (compute_display_string_pos)
3946 (compute_display_string_end): Fix handling the case of C string.
3947 (push_it, pop_it): Save and restore from_disp_prop_p.
3948 (handle_single_display_spec, push_display_prop): Set the
3949 from_disp_prop_p flag.
3950 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3951 (pop_it): Call iterate_out_of_display_property only if we are
3952 popping after iteration over a string that came from a display
3953 property. Fix a typo in popping stretch info. Add an assertion
3954 for verifying that the iterator position is in sync with the bidi
3955 iterator.
3956 (handle_single_display_spec, get_overlay_strings_1)
3957 (push_display_prop): Fix initialization of paragraph direction for
3958 string when that of the parent object is not yet determined.
3959 (reseat_1): Call bidi_init_it to resync the bidi
3960 iterator with IT's position. (Bug#7616)
3961 (find_row_edges): If ROW->start.pos gives position
3962 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3963 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3964 Reset the from_disp_prop_p flag.
3965 (SAVE_IT, RESTORE_IT): New macros.
3966 (pos_visible_p, face_before_or_after_it_pos)
3967 (back_to_previous_visible_line_start)
3968 (move_it_in_display_line_to, move_it_in_display_line)
3969 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3970 (try_scrolling, redisplay_window, display_line): Use them when
3971 saving a temporary copy of the iterator and restoring it back.
3972 (back_to_previous_visible_line_start, reseat_1)
3973 (init_iterator): Empty the bidi cache "stack".
3974 (move_it_in_display_line_to): If iterator ended up at
3975 EOL, but we never saw any buffer positions smaller than
3976 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3977 motion in bidi-reordered lines.
3978 (move_it_in_display_line_to): Record prev_method and prev_pos
3979 immediately before the call to set_iterator_to_next. Fixes cursor
3980 motion in bidi-reordered lines with stretch glyphs and strings
3981 displayed in margins. (Bug#8133) (Bug#8867)
3982 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3983 TO_CHARPOS.
640c8776
SM
3984 (pos_visible_p): Support positions in bidi-reordered lines.
3985 Save and restore bidi cache.
0bb23927
EZ
3986
3987 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3988 (bidi_paragraph_info): Delete unused struct.
3989 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3990 (bidi_cache_start): New variable.
3991 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3992 to zero.
3993 (bidi_cache_fetch_state, bidi_cache_search)
3994 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3995 (bidi_cache_find, bidi_peek_at_next_level)
3996 (bidi_level_of_next_char, bidi_find_other_level_edge)
3997 (bidi_move_to_visually_next): Compare cache index with
3998 bidi_cache_start rather than with zero.
3999 (bidi_fetch_char): Accept new argument STRING; all callers
4000 changed. Support iteration over a string. Support strings with
4001 display properties. Support unibyte strings. Fix the type of
4002 `len' according to what STRING_CHAR_AND_LENGTH expects.
4003 (bidi_paragraph_init, bidi_resolve_explicit_1)
4004 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4005 (bidi_level_of_next_char, bidi_move_to_visually_next):
4006 Support iteration over a string.
0bb23927
EZ
4007 (bidi_set_sor_type, bidi_resolve_explicit_1)
4008 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4009 can now be zero (for strings); special values 0 and -1 were
4010 changed to -1 and -2, respectively.
4011 (bidi_char_at_pos): New function.
4012 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4013 Call it instead of FETCH_MULTIBYTE_CHAR.
4014 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4015 initialized to valid values.
4016 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4017 values.
4018 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4019 the test for valid cached positions. Fix the logic for looking up
4020 the sentinel state in the cache. GCPRO the Lisp string we are
4021 iterating.
4022 (bidi_push_it, bidi_pop_it): New functions.
4023 (bidi_initialize): Initialize the bidi cache start stack pointer.
4024 (bidi_cache_ensure_space): New function, refactored from part of
4025 bidi_cache_iterator_state. Don't assume the required size is just
4026 one BIDI_CACHE_CHUNK away.
4027 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4028 (bidi_count_bytes, bidi_char_at_pos): New functions.
4029 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4030 always valid if bidi_cache_idx is valid.
4031 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4032 is valid if it's going to be used.
4033 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4034 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4035 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4036 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4037 (bidi_find_other_level_edge, bidi_cache_start_stack):
4038 All variables related to cache indices are now EMACS_INT.
c965adc5 4039
0bb23927
EZ
4040 * dispextern.h (struct bidi_string_data): New structure.
4041 (struct bidi_it): New member `string'. Make flag members be 1-bit
4042 fields, and put them last in the struct.
640c8776
SM
4043 (compute_display_string_pos, compute_display_string_end):
4044 Update prototypes.
0bb23927
EZ
4045 (bidi_push_it, bidi_pop_it): Add prototypes.
4046 (struct iterator_stack_entry): New members bidi_p,
4047 paragraph_embedding, and from_disp_prop_p.
4048 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4049 (bidi_shelve_cache, bidi_unshelve_cache):
4050 Declare prototypes.
0bb23927
EZ
4051
4052 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4053 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4054 and vector-like objects.
4055
4056 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4057 cache around display iteration.
4058
4059 * window.c (Fwindow_end, window_scroll_pixel_based)
4060 (displayed_window_lines, Frecenter): Save and restore the bidi
4061 cache around display iteration.
4062
3bbd2265
LMI
40632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4064
4065 * editfns.c (Fdelete_region): Clarify the use of the named
4066 parameters (bug#6788).
4067
adc47434
MR
40682011-07-14 Martin Rudalics <rudalics@gmx.at>
4069
4070 * indent.c (Fvertical_motion): Set and restore w->pointm when
4071 saving and restoring the window's buffer (Bug#9006).
4072
837c31f8
LMI
40732011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4074
4075 * editfns.c (Fstring_to_char): Clarify just what is returned
4076 (bug#6576). Text by Eli Zaretskii.
4077
ac389d0c
JB
40782011-07-13 Juanma Barranquero <lekktu@gmail.com>
4079
4080 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4081
0be0ce47
EZ
40822011-07-13 Eli Zaretskii <eliz@gnu.org>
4083
4084 * buffer.c (mmap_find): Fix a typo.
4085
cd18e7e3
JB
40862011-07-13 Johan Bockgård <bojohan@gnu.org>
4087
4088 Fix execution of x selection hooks.
4089 * xselect.c (Qx_lost_selection_functions)
4090 (Qx_sent_selection_functions): New vars.
4091 (syms_of_xselect): DEFSYM them.
4092 (x_handle_selection_request): Pass Qx_sent_selection_functions
4093 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4094 (x_handle_selection_clear,x_clear_frame_selections):
4095 Pass Qx_lost_selection_functions rather than
4096 Vx_lost_selection_functions to Frun_hook_with_args.
4097
47ea7f44
PE
40982011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4099
ac389d0c 4100 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4101 The old code sometimes used this field without initializing it.
4102
47ea7f44
PE
4103 * alloc.c (gc_sweep): Don't read past end of array.
4104 In theory, the old code could also have corrupted Emacs internals,
4105 though it'd be very unlikely.
4106
bc985c87
AS
41072011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4108
4109 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4110 argument. (Bug#4026)
bc985c87 4111
0cf34688
LMI
41122011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4113
b3dadd76
LMI
4114 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4115 key" (bug#4257).
4116
0cf34688
LMI
4117 * window.c (Fset_window_start): Doc fix (bug#4199).
4118 (Fset_window_hscroll): Ditto.
4119
270768cd
PE
41202011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4121
077e3dda 4122 Fix minor new problems caught by GCC 4.6.1.
270768cd 4123 * term.c (init_tty): Remove unused local.
490011a6 4124 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4125 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4126 not used otherwise.
270768cd 4127
b1f58454
CY
41282011-07-12 Chong Yidong <cyd@stupidchicken.com>
4129
4130 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4131
22b9578d
LMI
41322011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4133
6e70ab07
LMI
4134 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4135 are the mini-buffer and the echo area (bug#3320).
4136
22b9578d
LMI
4137 * term.c (init_tty): Remove support for supdup, c10 and perq
4138 terminals, which are no longer supported (bug#1482).
4139
8974cc9f
JB
41402011-07-10 Johan Bockgård <bojohan@gnu.org>
4141
4142 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4143
a560d974
JD
41442011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4145
4146 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4147 for non-popups (Bug#3642).
4148
1dae0f0a
AS
41492011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4150
268c2c36 4151 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4152 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4153 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4154 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4155 * data.c (fmod): Likewise.
4156 * dispnew.c (swap_glyphs_in_rows): Likewise.
4157 * emacs.c (memory_warning_signal): Likewise.
4158 * floatfns.c (float_error): Likewise.
4159 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4160 (otf_open, font_otf_capability, generate_otf_features)
4161 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4162 Likewise.
4163 * image.c (pbm_read_file): Likewise.
4164 * indent.c (string_display_width): Likewise.
4165 * intervals.c (check_for_interval, search_for_interval)
4166 (inc_interval_count, count_intervals, root_interval)
4167 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4168 * lread.c (defalias): Likewise.
268c2c36 4169 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4170 * regex.c (set_image_of_range_1, set_image_of_range)
4171 (regex_grow_registers): Likewise.
4172 * sysdep.c (strerror): Likewise.
4173 * termcap.c (valid_filename_p, tprint, main): Likewise.
4174 * tparam.c (main): Likewise.
4175 * unexhp9k800.c (run_time_remap, save_data_space)
4176 (update_file_ptrs, read_header, write_header, calculate_checksum)
4177 (copy_file, copy_rest, display_header): Likewise.
4178 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4179 Likewise.
4180 * xdisp.c (check_it): Likewise.
4181 * xfaces.c (register_color, unregister_color, unregister_colors):
4182 Likewise.
4183 * xfns.c (print_fontset_result): Likewise.
4184 * xrdb.c (member, fatal, main): Likewise.
4185
99033785
PE
41862011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4187
4188 Fix minor problems found by static checking (Bug#9031).
4189 * chartab.c (char_table_set_range, map_sub_char_table):
4190 Remove unused locals.
4191 (uniprop_table): Now static.
4192 * composite.c (_work_char): Remove unused static var.
4193
9cb2ac56
JB
41942011-07-09 Juanma Barranquero <lekktu@gmail.com>
4195
4196 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4197
f25661f0
JD
41982011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4199
4200 * gtkutil.c (qttip_cb): Remove code without function.
4201
8278c4fe
EZ
42022011-07-09 Eli Zaretskii <eliz@gnu.org>
4203
4204 * w32.c (pthread_sigmask): New stub.
4205
1692ae2d 42062011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4207
8a6ebd58 4208 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4209 sigprocmask is portable only for single-threaded applications, and
4210 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4211 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4212 (LIBES): Use it.
4213 * callproc.c (Fcall_process):
4214 * process.c (create_process):
4215 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4216 Use pthread_sigmask, not sigprocmask.
123403e4 4217
1b854618
JD
42182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4219
4220 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4221 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4222 wrong (Bug#8591).
4223
3fe4b549
JD
42242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4225
0ce7e563
JD
4226 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4227 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4228 (xg_hide_tooltip): Fix comment.
4229
3fe4b549
JD
4230 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4231 in registerServicesMenuSendTypes.
4232 (validRequestorForSendType): Don't check ns_return_types.
4233
4234 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4235 ns_return_type.
4236
5df75e47
JR
42372011-07-08 Jason Rumney <jasonr@gnu.org>
4238
22610910
JR
4239 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4240 SH_SHOW for hidden windows (Bug#5482).
4241
5df75e47
JR
4242 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4243 frame struct members of non-existent frames (Bug#6284).
4244
699c10bd
JD
42452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4246
4393663b
JD
4247 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4248 variable firstTime not needed on OSX >= 10.6.
4249 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4250 >= 10.5. Use setKnobProportion, setDoubleValue.
4251
4252 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4253 (MAC_OS_X_VERSION_10_5): Define if not defined.
4254 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4255 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4256 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4257
4258 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4259 cString and lossyCString on OSX >= 10.4
4260
58179cce 4261 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4262 sizeToFit on OSX >= 10.2.
4263
4264 * nsimage.m (allocInitFromFile): Don't use deprecated method
4265 bestRepresentationForDevice on OSX >= 10.6.
4266
4267 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4268 to avoid warning.
4269
4270 * emacs.c: Declare unexec_init_emacs_zone.
4271
a63e0781
JD
4272 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4273
699c10bd
JD
4274 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4275
4276 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4277 on svcsMenu (Bug#8842).
4278
4279 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4280 ns_return_types.
4281 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4282
4283 * nsterm.m (QUTF8_STRING): Declare.
4284 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4285 (validRequestorForSendType): Return type is (id).
4286 Change indexOfObjectIdenticalTo to indexOfObject.
4287 Check if we have local selection before returning self (Bug#8842).
4288 (writeSelectionToPasteboard): Put local selection into paste board
4289 if we have a local selection (Bug#8842).
4290 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4291
4292 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4293 (ns_get_local_selection): Declare.
4294
54e10184
LMI
42952011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4296
9888ff71
LMI
4297 * keymap.c (describe_map_tree): Don't insert a double newline at
4298 the end of the buffer (bug#1169) and return whether we inserted
4299 something.
4300
54e10184
LMI
4301 * callint.c (Fcall_interactively): Change "reading args" to
4302 "providing args" to try to clarify what it does (bug#1010).
4303
15fa4783
KH
43042011-07-07 Kenichi Handa <handa@m17n.org>
4305
4306 * composite.c (composition_compute_stop_pos): Ignore a static
4307 composition starting before CHARPOS (Bug#8915).
4308
4309 * xdisp.c (handle_composition_prop): Likewise.
4310
a8815b00
EZ
43112011-07-07 Eli Zaretskii <eliz@gnu.org>
4312
4313 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4314 (Bug#9015)
4315
ef7b981d 43162011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4317
4318 * character.h (unicode_category_t): New enum type.
4319
4320 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4321 (Qchar_code_property_table): New variable.
4322 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4323 (UNIPROP_COMPRESSED_FORM_P): New macros.
4324 (char_table_ascii): Uncompress the compressed values.
4325 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4326 Uncompress the compressed values.
ac389d0c 4327 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4328 (char_table_ref_and_range): Uncompress the compressed values.
4329 (sub_char_table_set): New arg is_uniprop. Callers changed.
4330 Uncompress the compressed values.
4331 (sub_char_table_set_range): Args changed. Callers changed.
4332 (char_table_set_range): Adjuted for the above change.
4333 (map_sub_char_table): Delete args default_val and parent. Add arg
4334 top. Give decoded values to a Lisp function.
640c8776 4335 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4336 values to a Lisp function. Gcpro more variables.
4337 (uniprop_table_uncompress)
4338 (uniprop_decode_value_run_length): New functions.
4339 (uniprop_decoder, uniprop_decoder_count): New variables.
4340 (uniprop_get_decoder, uniprop_encode_value_character)
4341 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4342 New functions.
4343 (uniprop_encoder, uniprop_encoder_count): New variables.
4344 (uniprop_get_encoder, uniprop_table)
4345 (Funicode_property_table_internal, Fget_unicode_property_internal)
4346 (Fput_unicode_property_internal): New functions.
4347 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4348 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4349 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4350 char-code-property-alist.
4351
640c8776 4352 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4353 Vunicode_category_table.
4354
640c8776 4355 * font.c (font_range): Adjust for the change of
c805dec0
KH
4356 Vunicode_category_table.
4357
76b397fb
DN
43582011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4359
4360 * m/iris4d.h: Remove file, move contents ...
4361 * s/irix6-5.h: ... here.
4362
22b4128e
PE
43632011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4364
4365 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4366 * alloc.c (mark_buffer):
4367 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4368 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4369 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4370 This isn't true in general, and it's particularly not true
4371 if Emacs is configured with --with-wide-int.
4372 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4373 New macros, used in the buffer.c change.
4374
869795d6
JD
43752011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4376
4377 * xsettings.c: Use both GConf and GSettings if both are available.
4378 (store_config_changed_event): Add comment.
4379 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4380 (store_tool_bar_style_changed): New functions.
5e617bc2 4381 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4382 (struct xsettings): Move font inside HAVE_XFT.
4383 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4384 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4385 Move inside HAVE_XFT.
640c8776 4386 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4387 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4388 also.
4389 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4390 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4391 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4392 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4393 (parse_settings): Move check for font inside HAVE_XFT.
4394 (read_settings, apply_xft_settings): Add comment.
4395 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4396 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4397 call store_font_name_changed.
4398 (xft_settings_event): Add comment.
4399 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4400 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4401 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4402 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4403 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4404 (xsettings_get_system_font, xsettings_get_system_normal_font):
4405 Add comment.
869795d6 4406
d8ed26bd
PE
44072011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4408
4409 Random fixes. E.g., (random) never returned negative values.
4410 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4411 subseconds part to the entropy, as that's a bit more random.
4412 Prefer signed to unsigned, since the signedness doesn't matter and
4413 in general we prefer signed. When given a limit, use a
4414 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4415 latter isn't right if USE_2_TAGS_FOR_INTS.
4416 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4417 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4418
cabf1cac
SM
44192011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4420
4421 * textprop.c (text_property_stickiness):
4422 Obey Vtext_property_default_nonsticky.
4423 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4424 * w32fns.c (syms_of_w32fns):
4425 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4426
6e9b2be9
PE
44272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4428
4429 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4430 This is more efficient than Ffile_directory_p and avoids a minor race.
4431
90186c68
LMI
44322011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4433
7c301272
LMI
4434 * buffer.c (Foverlay_put): Say what the return value is
4435 (bug#7835).
4436
c4f2d8d4
LMI
4437 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4438 is a directory before asking whether to use the file name
4439 (bug#7564).
ad637907
LMI
4440 (barf_or_query_if_file_exists): Make the "File is a directory"
4441 error be more correct.
c4f2d8d4 4442
90186c68
LMI
4443 * fns.c (Frequire): Remove the mention of the .gz files, since
4444 that's installation-specific, but keep the mention of
4445 `get-load-suffixes'.
4446
da64016e
PE
44472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4448
4449 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4450 Report string overflow if the output is too long.
4451
7d47b580
JB
44522011-07-04 Juanma Barranquero <lekktu@gmail.com>
4453
a555cb87
JB
4454 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4455 (syms_of_gnutls): Remove duplicate DEFSYM for
4456 Qgnutls_bootprop_verify_hostname_error, an error for
4457 Qgnutls_bootprop_verify_error (which is no longer used).
4458
7d47b580
JB
4459 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4460 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4461 Also (re)move comments that are misplaced or no longer relevant.
4462
1e49bfab
LMI
44632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4464
4465 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4466
1485f4c0
CY
44672011-07-03 Chong Yidong <cyd@stupidchicken.com>
4468
4469 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4470 and background color parameters if they have been changed.
4471
a9ab721e
LMI
44722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4473
4474 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4475
cf7cff57
PE
44762011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4477
2e13213d
PE
4478 * xsettings.c (SYSTEM_FONT): Define only when used.
4479 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4480
cf7cff57
PE
4481 * keymap.c (access_keymap_1): Now static.
4482
7a8e04f7
CY
44832011-07-02 Chong Yidong <cyd@stupidchicken.com>
4484
4485 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4486 leave any prefix arg for the up event (Bug#1586).
4487
61352f62
LMI
44882011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4489
69bb1ef7
LMI
4490 * lread.c (syms_of_lread): Mention single symbols defined by
4491 `defvar' or `defconst' (bug#7154).
4492
61352f62 4493 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4494 (Frequire): Mention get-load-suffixes.
61352f62 4495
28545e04
MR
44962011-07-02 Martin Rudalics <rudalics@gmx.at>
4497
4498 * window.h (window): Remove clone_number slot.
4499 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4500 Remove.
4501 (make_parent_window, make_window, saved_window)
4502 (Fset_window_configuration, save_window_save): Don't deal with
4503 clone numbers.
4504 * buffer.c (Qclone_number): Remove declaration.
4505 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4506
3349e122
SM
45072011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4508
4509 Add multiple inheritance to keymaps.
4510 * keymap.c (Fmake_composed_keymap): New function.
4511 (Fset_keymap_parent): Simplify.
4512 (fix_submap_inheritance): Remove.
4513 (access_keymap_1): New function extracted from access_keymap to handle
4514 embedded parents and handle lists of maps.
4515 (access_keymap): Use it.
4516 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4517 (Fcopy_keymap): Handle embedded parents.
4518 (Fcommand_remapping, define_as_prefix): Simplify.
4519 (Fkey_binding): Simplify.
4520 (syms_of_keymap): Move minibuffer-local-completion-map,
4521 minibuffer-local-filename-completion-map,
4522 minibuffer-local-must-match-map, and
4523 minibuffer-local-filename-must-match-map to Elisp.
4524 (syms_of_keymap): Defsubr make-composed-keymap.
4525 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4526 (parse_menu_item): Trivial simplification.
4527
3279eb87
GM
45282011-07-01 Glenn Morris <rgm@gnu.org>
4529
4530 * Makefile.in (SETTINGS_LIBS): Fix typo.
4531
4550efdf
KI
45322011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4533
4534 * coding.c (Fencode_coding_string): Record the last coding system
4535 used, as the function doc string says (bug#8738).
4536
0949d2b6
JD
45372011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4538
4539 * xsettings.c (store_monospaced_changed): Take new font as arg and
4540 check for change against current_mono_font.
4541 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4542 (emacs_settings_constructor, emacs_settings_get_property)
4543 (emacs_settings_set_property, emacs_settings_class_init)
4544 (emacs_settings_init, gsettings_obj): Remove.
4545 (something_changedCB): New function for HAVE_GSETTINGS.
4546 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4547 with value as argument.
4548 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4549 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4550 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4551 "changed".
4552
4553 * xgselect.c: Add defined (HAVE_GSETTINGS).
4554 (xgselect_initialize): Ditto.
4555
4556 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4557 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4558 xg_select.
4559
bbc6b304
PE
45602011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4561
4562 * eval.c (struct backtrace): Simplify and port the data structure.
4563 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4564 signed bit field, as this assumption is not portable and it makes
4565 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4566 "char debug_on_exit : 1" as this is not portable either; instead,
4567 use the portable "unsigned int debug_on_exit : 1". Remove unused
4568 member evalargs. Remove obsolete comments about cc bombing out.
4569
9851bfc5
JD
45702011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4571
51bb811f 4572 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4573 Let HAVE_GSETTINGS override HAVE_GCONF.
4574 (store_monospaced_changed): New function.
4575 (EMACS_SETTINGS): A new type derived from GObject to handle
4576 GSettings notifications.
4577 (emacs_settings_constructor, emacs_settings_get_property)
4578 (emacs_settings_set_property, emacs_settings_class_init):
4579 New functions.
4580 (gsettings_client, gsettings_obj): New variables.
4581 (GSETTINGS_SCHEMA): New define.
4582 (something_changedCB): Call store_monospaced_changed.
4583 (init_gsettings): New function.
4584 (xsettings_initialize): Call init_gsettings.
4585 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4586 to NULL.
4587
640c8776 4588 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4589 GCONF_CFLAGS/LIBS.
4590
5386012d
MR
45912011-06-29 Martin Rudalics <rudalics@gmx.at>
4592
4593 * window.c (resize_root_window, grow_mini_window)
4594 (shrink_mini_window): Rename Qresize_root_window to
4595 Qwindow_resize_root_window and Qresize_root_window_vertically to
4596 Qwindow_resize_root_window_vertically.
4597
f13e0b08
PE
45982011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4601
94515237
JB
46022011-06-27 Juanma Barranquero <lekktu@gmail.com>
4603
4604 * makefile.w32-in: Redesign dependencies so they reflect more
4605 clearly which files are directly included by each source file,
4606 and not through other includes.
4607
e43b6e43
MR
46082011-06-27 Martin Rudalics <rudalics@gmx.at>
4609
4610 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4611 (sort_overlays, overlay_strings): When an overlay's clone number
4612 matches the window's clone number process the overlay even if
4613 the overlay's window property doesn't match the current window.
4614
d68443dc
MR
4615 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4616 (Fwindow_hchild): Rename to Fwindow_left_child.
4617 (Fwindow_next): Rename to Fwindow_next_sibling.
4618 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4619 (resize_window_check): Rename to window_resize_check.
4620 (resize_window_apply): Rename to window_resize_apply.
4621 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4622 (Fdelete_other_windows_internal, resize_frame_windows)
4623 (Fsplit_window_internal, Fdelete_window_internal)
4624 (grow_mini_window, shrink_mini_window)
4625 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4626
c7e73be5
JD
46272011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4628
4629 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4630 (emacs_fixed_set_min_size): Remove.
4631 (emacs_fixed_new): Take frame as argument.
4632
4633 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4634 (_EmacsFixedPrivate): Remove minwidth/height.
4635 Add struct frame *f.
4636 (emacs_fixed_init): Initialize priv->f.
4637 (get_parent_class, emacs_fixed_set_min_size): Remove.
4638 (emacs_fixed_new): Set priv->f to argument.
4639 (emacs_fixed_get_preferred_width)
4640 (emacs_fixed_get_preferred_height): Use min_width/height from
4641 frames size_hint to set minimum and natural (Bug#8919).
4642 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4643 and use min_width/height from frames size_hint to set
4644 min_width/height (Bug#8919).
4645
4646 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4647 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4648 Fix indentation.
c7e73be5 4649
cf99dcf8
EZ
46502011-06-26 Eli Zaretskii <eliz@gnu.org>
4651
4652 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4653 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4654 called at ZV.
4655
029529ac
CY
46562011-06-26 Chong Yidong <cyd@stupidchicken.com>
4657
4658 * process.c (wait_reading_process_output): Bypass select if
4659 waiting for a cell while ignoring keyboard input, and input is
4660 pending. Suggested by Jan Djärv (Bug#8869).
4661
7a7ef429
PE
46622011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4663
4664 Use gnulib's dup2 module instead of rolling our own.
4665 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4666
11fdef7d 46672011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4668
4669 * dispnew.c (scrolling_window): Before scrolling, turn off a
4670 mouse-highlight in the window being scrolled.
4671
cd3520a4
JB
46722011-06-24 Juanma Barranquero <lekktu@gmail.com>
4673
4674 Move DEFSYM to lisp.h and use everywhere.
4675
4676 * character.h (DEFSYM): Move declaration...
4677 * lisp.h (DEFSYM): ...here.
4678
4679 * gnutls.c:
4680 * minibuf.c:
4681 * w32menu.c:
4682 * w32proc.c:
4683 * w32select.c: Don't include character.h.
4684
4685 * alloc.c (syms_of_alloc):
4686 * buffer.c (syms_of_buffer):
4687 * bytecode.c (syms_of_bytecode):
4688 * callint.c (syms_of_callint):
4689 * casefiddle.c (syms_of_casefiddle):
4690 * casetab.c (init_casetab_once):
4691 * category.c (init_category_once, syms_of_category):
4692 * ccl.c (syms_of_ccl):
4693 * cmds.c (syms_of_cmds):
4694 * composite.c (syms_of_composite):
4695 * dbusbind.c (syms_of_dbusbind):
4696 * dired.c (syms_of_dired):
4697 * dispnew.c (syms_of_display):
4698 * doc.c (syms_of_doc):
4699 * editfns.c (syms_of_editfns):
4700 * emacs.c (syms_of_emacs):
4701 * eval.c (syms_of_eval):
4702 * fileio.c (syms_of_fileio):
4703 * fns.c (syms_of_fns):
4704 * frame.c (syms_of_frame):
4705 * fringe.c (syms_of_fringe):
4706 * insdel.c (syms_of_insdel):
4707 * keymap.c (syms_of_keymap):
4708 * lread.c (init_obarray, syms_of_lread):
4709 * macros.c (syms_of_macros):
4710 * msdos.c (syms_of_msdos):
4711 * print.c (syms_of_print):
4712 * process.c (syms_of_process):
4713 * search.c (syms_of_search):
4714 * sound.c (syms_of_sound):
4715 * syntax.c (init_syntax_once, syms_of_syntax):
4716 * terminal.c (syms_of_terminal):
4717 * textprop.c (syms_of_textprop):
4718 * undo.c (syms_of_undo):
4719 * w32.c (globals_of_w32):
4720 * window.c (syms_of_window):
4721 * xdisp.c (syms_of_xdisp):
4722 * xfaces.c (syms_of_xfaces):
4723 * xfns.c (syms_of_xfns):
4724 * xmenu.c (syms_of_xmenu):
4725 * xsettings.c (syms_of_xsettings):
4726 * xterm.c (syms_of_xterm): Use DEFSYM.
4727
4228cf16
TZ
47282011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4729
cd3520a4 4730 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4731
7fcccf1e
PE
47322011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4733
7efb4e0e
PE
4734 Integer and buffer overflow fixes (Bug#8873).
4735
ff5844ad
PE
4736 * print.c (printchar, strout): Check for string overflow.
4737 (PRINTPREPARE, printchar, strout):
4738 Don't set size unless allocation succeeds.
4739
90532f02
PE
4740 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4741 for sizes. Check for string overflow more accurately.
4742 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4743
6d84508d
PE
4744 * macros.c: Integer and buffer overflow fixes.
4745 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4746 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4747 Use ptrdiff_t, not int, for sizes.
4748 Don't increment bufsize until after realloc succeeds.
4749 Check for size-calculation overflow.
4750 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4751
437b2cb4
PE
4752 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4753
8b9ac8b4
PE
4754 * lread.c: Integer overflow fixes.
4755 (read_integer): Radix is now EMACS_INT, not int,
4756 to improve quality of diagnostics for out-of-range radices.
4757 Calculate buffer size correctly for out-of-range radices.
4758 (read1): Check for integer overflow in radices, and in
4759 read-circle numbers.
82cb60d3
PE
4760 (read_escape): Avoid int overflow.
4761 (Fload, openp, read_buffer_size, read1)
4762 (substitute_object_recurse, read_vector, read_list, map_obarray):
4763 Use ptrdiff_t, not int, for sizes.
4764 (read1): Use EMACS_INT, not int, for sizes.
20270765 4765 Check for size overflow.
8b9ac8b4 4766
7fcccf1e
PE
4767 * image.c (cache_image): Check for size arithmetic overflow.
4768
bfbbd7e7
PE
4769 * lread.c: Integer overflow issues.
4770 (saved_doc_string_size, saved_doc_string_length)
4771 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4772 Now ptrdiff_t, not int.
4773 (read1): Don't assume doc string length fits in int. Check for
4774 out-of-range doc string lengths.
4775 (read_list): Don't assume file position fits in int.
39019e54 4776 (read_escape): Check for hex character overflow.
bfbbd7e7 4777
4e323265
LL
47782011-06-22 Leo Liu <sdl.web@gmail.com>
4779
4780 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4781 Move to minibuffer.el.
4782
85fece3e
PE
47832011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4784
20b84ce9 4785 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4786 The following patches are for when GLYPH_DEBUG && !XASSERT.
4787 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4788 * dispnew.c (flush_stdout):
4789 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4790 Mark as externally visible.
4791 * dispnew.c (check_window_matrix_pointers): Now static.
4792 * dispnew.c (window_to_frame_vpos):
4793 * xfns.c (unwind_create_frame):
4794 * xterm.c (x_check_font): Remove unused local.
4795 * scroll.c (CHECK_BOUNDS):
4796 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4797 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4798 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4799 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4800 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4801 Now static.
4802 (debug_method_add): Use va_list and vsprintf rather than relying
4803 on undefined behavior with wrong number of arguments.
4804 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4805 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4806 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4807 since we're not interested in debugging glyphs with old libraries.
4808 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4809 GCC 4.6.0's static checking.
4810
0766b489
PE
48112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4812
31fd4b32
PE
4813 Integer overflow and signedness fixes (Bug#8873).
4814 A few related buffer overrun fixes, too.
4815
b79e8648
PE
4816 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4817
0766b489
PE
4818 * dispextern.h (struct face.stipple):
4819 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4820 (x_bitmap_mask, x_allocate_bitmap_record)
4821 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4822 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4823 (x_create_bitmap_from_xpm_data):
4824 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4825 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4826 (.bitmaps_last):
4827 * xfaces.c (load_pixmap):
4828 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4829 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4830 (.bitmaps_last, struct x_output.icon_bitmap):
4831 Use ptrdiff_t, not int, for bitmap indexes.
4832 (x_allocate_bitmap_record): Check for size overflow.
4833 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4834
b081724f
PE
4835 Use ptrdiff_t, not int, for overlay counts.
4836 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4837 * editfns.c (overlays_around, get_pos_property):
4838 * textprop.c (get_char_property_and_overlay):
4839 * xdisp.c (next_overlay_change, note_mouse_highlight):
4840 * xfaces.c (face_at_buffer_position):
21514da7
PE
4841 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4842 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4843 (Fnext_overlay_change, Fprevious_overlay_change)
4844 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4845 Use ptrdiff_t, not int, for sizes.
21514da7 4846 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4847
3de73e5e
PE
4848 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4849
2606c57b
PE
4850 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4851 (x_session_initialize): Do not assume string length fits in int.
4852
aaafe47a
PE
4853 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4854 This is unlikely, but can occur if DPI is outlandish.
4855
2674ddc8 4856 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4857 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4858
28154962
PE
4859 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4860 * xrdb.c (magic_file_p, search_magic_path):
4861 Omit last arg SUFFIX; it was always 0. All callers changed.
4862 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4863
7de51af5
PE
4864 * xfont.c (xfont_match): Avoid need for strlen.
4865
25ed6cc3
PE
4866 * xfns.c: Don't assume strlen fits in int.
4867 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4868
4eab31dd
PE
4869 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4870 not unsigned long, as we prefer signed integers. All callers changed.
4871 Detect integer overflow in repeat count.
4872 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4873 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4874
171e2a58
PE
4875 * termcap.c: Don't assume sizes fit in int and never overflow.
4876 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4877 (gobble_line): Check for size-calculation overflow.
4878
ad39faca 4879 * minibuf.c (Fread_buffer):
6e5bb2dc 4880 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4881 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4882 Don't assume string length fits in int.
4883
52c61c22 4884 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4885 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4886
b5b8c9e5
PE
4887 * font.c: Don't assume string length fits in int.
4888 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4889 Use ptrdiff_t, not int.
ccd6111c
PE
4890 (font_intern_prop): Don't assume string length fits in int.
4891 Don't assume integer property fits in fixnum.
4892 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4893
882f0d81 4894 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4895 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4896 Reformulate so as not to need the command string.
4897 Invoke gzip -cd rather than gunzip, as it's more portable.
4898 (lock_info_type, lock_file_1, lock_file):
4899 Don't assume pid_t and time_t fit in unsigned long.
4900 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4901 (current_lock_owner): Prefer signed type for sizes.
4902 Use memcpy, not strncpy, where memcpy is what is really wanted.
4903 Don't assume (via atoi) that time_t and pid_t fit in int.
4904 Check for time_t and/or pid_t out of range, e.g., via a network share.
4905 Don't alloca where an auto var works fine.
4906
93f4cf88
PE
4907 * fileio.c: Fix some integer overflow issues.
4908 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4909 Don't assume string length fits in int.
4910 (directory_file_name): Don't assume string length fits in long.
4911 (make_temp_name): Don't assume pid fits in int, or that its print
4912 length is less than 20.
4913
f3e92b69
PE
4914 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4915
1bfdaf10
PE
4916 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4917
35016e9a
PE
4918 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4919
3d1e65a1
PE
4920 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4921 We prefer signed integers, even for size calculations.
4922
0b963a93
PE
4923 * emacs.c: Don't assume string length fits in 'int'.
4924 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4925 (main): Don't invoke strlen when not needed.
4926
573f4b54
PE
4927 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4928 (XD_DEBUG_MESSAGE): Don't waste a byte.
4929
989f33ba
PE
4930 * callproc.c (getenv_internal_1, getenv_internal)
4931 (Fgetenv_internal):
965d34eb
PE
4932 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4933
e4d29b33
PE
4934 * lread.c (invalid_syntax): Omit length argument.
4935 All uses changed. This doesn't fix a bug, but it simplifies the
4936 code away from its former Hollerith-constant appearance, and it's
4937 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4938 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4939
eb49b136
PE
4940 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4941 This didn't break anything, but it didn't help either.
4942 It's confusing to put a bogus integer in a place where the actual
4943 value does not matter.
9f62aeb1 4944 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4945 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4946
15375a22
PE
4947 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4948 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4949 implementation.
b61cc01c
PE
4950 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4951 We prefer signed types, and the value cannot exceed the EMACS_INT
4952 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4953 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4954 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4955 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4956
53b2623d
PE
4957 * indent.c (sane_tab_width): New function.
4958 (current_column, scan_for_column, Findent_to, position_indentation)
4959 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4960 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4961
51cab52b 4962 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4963
f2ed8a70
PE
4964 * lisp.h (lint_assume): New macro.
4965 * composite.c (composition_gstring_put_cache):
4966 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4967
abe80cc6
PE
4968 * editfns.c, insdel.c:
4969 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4970
b02c740e
PE
4971 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4972
ebc96716
PE
4973 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4974
b4e50fa0 4975 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4976 Use much-faster test for byte-length change.
311d5d7c 4977 Don't assume string byte-length fits in 'int'.
a4cf38e4 4978 Check that character arg fits in 'int'.
85461888 4979 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4980
c0c1ee9f
PE
4981 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4982
a498d7f4
PE
4983 * fns.c (concat): Catch string overflow earlier.
4984 Do not rely on integer wraparound.
4985
51cab52b
PE
4986 * dispextern.h (struct it.overlay_strings_charpos)
4987 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4988 * xdisp.c (forward_to_next_line_start)
4989 (back_to_previous_visible_line_start)
4990 (reseat_at_next_visible_line_start, next_element_from_buffer):
4991 Don't arbitrarily truncate the value of 'selective' to int.
4992
76031fad
PE
4993 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4994
5eb55db9
PE
4995 * composite.c: Don't truncate sizes to 'int'.
4996 (composition_gstring_p, composition_reseat_it)
4997 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4998 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4999 not EMACS_UINT, for indexes.
5eb55db9 5000
0703a717
PE
5001 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5002
d6202519
PE
5003 * buffer.c: Include <verify.h>.
5004 (struct sortvec.priority, struct sortstr.priority):
8961a454 5005 Now EMACS_INT, not int.
c20998a7 5006 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5007 (struct sortstr.size, record_overlay_string)
5008 (struct sortstrlist.size, struct sortlist.used):
5009 Don't truncate size to int.
5010 (record_overlay_string): Check for size-calculation overflow.
d6202519 5011 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5012
d5a19415
JM
50132011-06-22 Jim Meyering <meyering@redhat.com>
5014
029529ac 5015 Don't leak an XBM-image-sized buffer
d5a19415
JM
5016 * image.c (xbm_load): Free the image buffer after using it.
5017
a9041e6c
PE
50182011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5019
5020 Port to Sun C.
5021 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5022 that Sun C diagnosed.
5023 * fns.c (secure_hash): Fix pointer signedness issue.
5024 * intervals.c (static_offset_intervals): New function.
5025 (offset_intervals): Use it.
5026
7f3f739f
LL
50272011-06-21 Leo Liu <sdl.web@gmail.com>
5028
5029 * deps.mk (fns.o):
5030 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5031 sha512.h.
5032
5033 * fns.c (secure_hash): Rename from crypto_hash_function and change
5034 the first arg to accept symbols.
5b66d427 5035 (Fsecure_hash): New primitive.
7f3f739f
LL
5036 (syms_of_fns): New symbols.
5037
76147d94
DD
50382011-06-20 Deniz Dogan <deniz@dogan.se>
5039
5040 * process.c (Fset_process_buffer): Clarify return value in
5041 docstring.
5042
7d7d0045
CY
50432011-06-18 Chong Yidong <cyd@stupidchicken.com>
5044
5045 * dispnew.c (add_window_display_history): Use BVAR.
5046
5047 * xdisp.c (debug_method_add): Use BVAR.
5048 (check_window_end, dump_glyph_matrix, dump_glyph)
5049 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5050
5051 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5052 Likewise.
5053
5054 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5055 check till after the cache is created in init_frame_faces.
5056
ff2bc410
SM
50572011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5058
5059 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5060
28177add
PE
50612011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5062
dd3482fe
PE
5063 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5064 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5065 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5066
393d71f3 5067 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5068 * fileio.c (Finsert_file_contents):
5069 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5070 Remove the old (too-loose) buffer overflow checks.
5071 They weren't needed, since make_gap checks for buffer overflow.
5072 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5073 The old code merely checked for Emacs fixnum overflow, and relied
5074 on undefined (wraparound) behavior. The new code avoids undefined
5075 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5076
2e6813b0 5077 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5078 Tune. Don't use wider integers than needed. Don't use alloca.
5079 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5080
599a9e4f
PE
5081 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5082
99561444
PE
5083 * insdel.c, lisp.h (buffer_overflow): New function.
5084 (insert_from_buffer_1, replace_range, replace_range_2):
5085 * insdel.c (make_gap_larger):
5086 * editfns.c (Finsert_char):
5087 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5088
28177add
PE
5089 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5090
e69dafad
PE
50912011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5092
4baa020d 5093 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5094
b1c46f02
PE
5095 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5096 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5097
e69dafad
PE
5098 * fileio.c: Don't assume EMACS_INT fits in off_t.
5099 (emacs_lseek): New static function.
5100 (Finsert_file_contents, Fwrite_region): Use it.
5101 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5102
566684ea
PE
5103 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5104
e6966cd6
PE
5105 * fns.c: Don't overflow int when computing a list length.
5106 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5107 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5108 truncation on 64-bit hosts. Check for QUIT every
5109 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5110 faster and is responsive enough.
5111 (Flength): Report an error instead of overflowing an integer.
5112 (Fsafe_length): Return a float if the value is not representable
5113 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5114 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5115 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5116
dd0b0efb
PE
5117 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5118 (header_size, word_size): New constants.
5119 (allocate_vectorlike): Don't check size overflow here.
5120 (allocate_vector): Check it here instead, since this is the only
5121 caller of allocate_vectorlike that could cause overflow.
5122 Check that the new vector's length is representable as a fixnum.
5123
86fe5cfe
PE
5124 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5125 The previous code was bogus. For example, next_almost_prime (32)
5126 returned 39, which is undesirable as it is a multiple of 3; and
5127 next_almost_prime (24) returned 25, which is a multiple of 5 so
5128 why was the code bothering to check for multiples of 7?
5129
80e88859
PE
5130 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5131
4a2f0ad6
PE
5132 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5133
f66c7cf8
PE
5134 Variadic C functions now count arguments with ptrdiff_t.
5135 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5136 Back then I didn't know that the Emacs coding style prefers signed int.
5137 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5138 were being counted with int, which may truncate counts on 64-bit
5139 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5140 * lisp.h (struct Lisp_Subr.function.aMANY)
5141 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5142 Arg counts are now ptrdiff_t, not size_t.
5143 All variadic functions and their callers changed accordingly.
5144 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5145 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5146 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5147 * callint.c (Fcall_interactively): Check arg count for overflow,
5148 to avoid potential buffer overrun. Use signed char, not 'int',
5149 for 'varies' array, so that we needn't bother to check its size
5150 calculation for overflow.
5151 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5152 * eval.c (apply_lambda):
5153 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5154 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5155 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5156
a1759b76
PE
5157 * callint.c (Fcall_interactively): Don't use index var as event count.
5158
d96be9fc
PE
5159 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5160 * mem-limits.h (SIZE): Remove; no longer used.
5161
a690a978 5162 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5163
578c21e6
PE
5164 Remove unnecessary casts.
5165 * xterm.c (x_term_init):
5166 * xfns.c (x_set_border_pixel):
5167 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5168 These aren't needed now that we assume ANSI C.
5169
96f53c6c
PE
5170 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5171 It's more likely to cause problems (due to unsigned overflow)
5172 than to cure them.
5173
83c77d31
PE
5174 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5175
ee2079f1
PE
5176 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5177
6da65536
PE
5178 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5179
7147c4a4
PE
5180 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5181
193e32d9
PE
5182 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5183
e5533da6
PE
5184 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5185
9910e595
PE
5186 GLYPH_CODE_FACE returns EMACS_INT, not int.
5187 * dispextern.h (merge_faces):
5188 * xfaces.c (merge_faces):
01103c44
PE
5189 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5190 Don't assume EMACS_INT fits in int.
9910e595 5191
2638320e
PE
5192 * character.h (CHAR_VALID_P): Remove unused parameter.
5193 * fontset.c, lisp.h, xdisp.c: All uses changed.
5194
045eb8d9
PE
5195 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5196
c1f134b5
PE
5197 * fns.c (concat): Minor tuning based on overflow analysis.
5198 This doesn't fix any bugs. Use int to hold character, instead
5199 of constantly refetching from Emacs object. Use XFASTINT, not
5200 XINT, for value known to be a character. Don't bother comparing
5201 a single byte to 0400, as it's always less.
5202
395fcb93 5203 * floatfns.c (Fexpt):
327eeec8
PE
5204 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5205
abbd3d23
PE
5206 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5207 for characters.
5208
684a03ef
PE
5209 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5210
0fed43f3
PE
5211 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5212 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5213 incorrectly succeed when S was a string, because 4294967386 was
5214 truncated before it was used.
5215
8fd02eb7
PE
5216 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5217 Otherwise, an out-of-range integer could cause undefined behavior
5218 on a 64-bit host.
5219
f8c86b69
PE
5220 * composite.c: Use int, not EMACS_INT, for characters.
5221 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5222 EMACS_INT, for values that are known to be in character range.
5223 This doesn't fix any bugs but is the usual style inside Emacs and
5224 may generate better code on 32-bit machines.
5225
34206dd2
PE
5226 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5227 This is for reasons similar to the recent CHAR_STRING fix.
5228 * charset.c (Fencode_char): Check that character arg is actually
5229 a character. Pass an int to ENCODE_CHAR.
5230 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5231 wider than 'int', as a compile-time check to prevent future regressions
5232 in this area.
5233
c5958d4c 5234 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5235
5236 Make sure a 64-bit char is never passed to CHAR_STRING.
5237 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5238 by silently ignoring the top 32 bits, allowing some values
5239 that were far too large to be valid characters.
5240 * character.h: Include <verify.h>.
5241 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5242 arguments are no wider than unsigned, as a compile-time check
5243 to prevent future regressions in this area.
5244 * data.c (Faset):
01103c44 5245 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5246 (Fsubst_char_in_region):
5247 * fns.c (concat):
5248 * xdisp.c (decode_mode_spec_coding):
5249 Adjust to CHAR_STRING's new requirement.
5250 * editfns.c (Finsert_char, Fsubst_char_in_region):
5251 * fns.c (concat): Check that character args are actually
5252 characters. Without this test, these functions did the wrong
5253 thing with wildly out-of-range values on 64-bit hosts.
5254
d37ca623
PE
5255 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5256 These casts should not be needed on 32-bit hosts, either.
5257 * keyboard.c (read_char):
5258 * lread.c (Fload): Remove casts to unsigned.
5259
ea204efb
PE
5260 * lisp.h (UNSIGNED_CMP): New macro.
5261 This fixes comparison bugs on 64-bit hosts.
5262 (ASCII_CHAR_P): Use it.
5263 * casefiddle.c (casify_object):
01103c44 5264 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5265 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5266 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5267 * dispextern.h (FACE_FROM_ID):
5268 * keyboard.c (read_char): Use UNSIGNED_CMP.
5269
41cb286c
PE
5270 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5271 not to EMACS_INT, to avoid GCC warning.
5272
4a1b9832
PE
5273 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5274
55daad71
PE
5275 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5276 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5277 isn't needed on 32-bit machines.
8f95c75c 5278
01103c44
PE
5279 * buffer.c (Fgenerate_new_buffer_name):
5280 Use EMACS_INT for count, not int.
0ceccced 5281 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5282
5283 * data.c (Qcompiled_function): Now static.
5284
c6f072e7
PE
5285 * window.c (window_body_lines): Now static.
5286
20ce5912
PE
5287 * image.c (gif_load): Rename local to avoid shadowing.
5288
9c4c5f81
PE
5289 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5290 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5291 * alloc.c (make_save_value): Integer argument is now of type
5292 ptrdiff_t, not int.
5293 (mark_object): Use ptrdiff_t, not int.
5294 * lisp.h (pD): New macro.
5295 * print.c (print_object): Use it.
5296
c0c5c8ae
PE
5297 * alloc.c: Use EMACS_INT, not int, to count objects.
5298 (total_conses, total_markers, total_symbols, total_vector_size)
5299 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5300 (total_free_floats, total_floats, total_free_intervals)
5301 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5302 Now EMACS_INT, not int. All uses changed.
5303 (Fgarbage_collect): Compute overall total using a double, so that
5304 integer overflow is less likely to be a problem. Check for overflow
5305 when converting back to an integer.
5a25e253
PE
5306 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5307 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5308 These were 'int' variables that could overflow on 64-bit hosts;
5309 they were never used, so remove them instead of repairing them.
211a0b2a 5310 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5311 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5312 Previously, this ceilinged at INT_MAX, but that doesn't work on
5313 64-bit machines.
e46bb31a 5314 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5315
c78baabf 5316 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5317 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5318 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5319 when a (possibly-narrower) signed value would do just as well.
5320 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5321
c9d624c6
PE
5322 * alloc.c: Catch some string size overflows that we were missing.
5323 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5324 for convenience in STRING_BYTES_MAX.
5325 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5326 The definition here is exact; the one in lisp.h was approximate.
5327 (allocate_string_data): Check for string overflow. This catches
5328 some instances we weren't catching before. Also, it catches
5329 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5330 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5331 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5332
c9d624c6
PE
5333 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5334 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5335 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5336
353032ce
PE
5337 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5338
2bccce07
PE
5339 * alloc.c (Fmake_string): Check for out-of-range init.
5340
0ac30604
SM
53412011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5342
5343 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5344
c195f2de
JD
53452011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5346
5347 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5348 xg_get_default_scrollbar_width.
5349
5350 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5351 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5352 (style_changed_cb): Call update_theme_scrollbar_width and call
5353 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5354 all frames (Bug#8505).
5355 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5356 Call gtk_window_set_resizable if HAVE_GTK3.
5357 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5358 and height if HAVE_GTK3 (Bug#8505).
5359 (scroll_bar_width_for_theme): New variable.
5360 (update_theme_scrollbar_width): New function.
5361 (xg_get_default_scrollbar_width): Move code to
5362 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5363 (xg_initialize): Call update_theme_scrollbar_width.
5364
5365 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5366
5367 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5368
e10ac9f1
MR
53692011-06-12 Martin Rudalics <rudalics@gmx.at>
5370
5371 * frame.c (make_frame): Call other_buffer_safely instead of
5372 other_buffer.
5373
5374 * window.c (temp_output_buffer_show): Call display_buffer with
5375 second argument Vtemp_buffer_show_specifiers and reset latter
5376 immediately after the call.
5377 (Vtemp_buffer_show_specifiers): New variable.
5378 (auto_window_vscroll_p, next_screen_context_lines)
5379 (Vscroll_preserve_screen_position): Remove leading asterisks from
5380 doc-strings.
5381
2d3c217e 53822011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5383
7b7f97e8 5384 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5385 * buffer.c (Qclone_number): Remove for now, as it's unused.
5386 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5387 (record_buffer): Remove unused local.
5388 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5389 (set_frame_buffer_list): Remove; unused.
5390 * frame.h (other_visible_frames): Remove decl.
5391 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5392 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5393 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5394 if HAVE_GPM.
5395 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5396 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5397 Define only if HAVE_GPM.
5398 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5399 (update_hints_inhibit): Remove; never set. All uses removed.
5400 * widgetprv.h (emacsFrameClassRec): Remove decl.
5401 * window.c (delete_deletable_window): Now returns void, since it
5402 wasn't returning anything.
5403 (compare_window_configurations): Remove unused locals.
5404 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5405 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5406 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5407 the same widths as pointers. This follows up on the 2011-05-06 patch.
5408 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5409 * xterm.h: Likewise.
5410 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5411
1384b89e
JB
54122011-06-12 Juanma Barranquero <lekktu@gmail.com>
5413
5414 * makefile.w32-in: Update dependencies.
5415 (LISP_H): Add lib/intprops.h.
5416
1100a63c
CY
54172011-06-11 Chong Yidong <cyd@stupidchicken.com>
5418
5419 * image.c (gif_load): Add animation frame delay to the metadata.
5420 (syms_of_image): Use DEFSYM. New symbol `delay'.
5421
6198ccd0
MR
54222011-06-11 Martin Rudalics <rudalics@gmx.at>
5423
5424 * window.c (delete_deletable_window): Re-add.
5425 (Fset_window_configuration): Rewrite to handle dead buffers and
5426 consequently deletable windows.
5427 (window_tree, Fwindow_tree): Remove. Supply functionality in
5428 window.el.
5429 (compare_window_configurations): Simplify code.
5430
b6e3633c
AS
54312011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5432
1ab0dee5
AS
5433 * image.c (imagemagick_load_image): Fix type mismatch.
5434 (Fimagemagick_types): Likewise.
5435
b6e3633c
AS
5436 * window.h (replace_buffer_in_windows): Declare.
5437
9397e56f
MR
54382011-06-11 Martin Rudalics <rudalics@gmx.at>
5439
5440 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5441 Qclone_number. Remove external declaration of Qdelete_window.
5442 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5443 code.
640c8776
SM
5444 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5445 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5446 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5447 buffer list implementation.
5448 (other_buffer_safely): New function.
5449 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5450 calls to replace_buffer_in_windows and
5451 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5452 if allowed.
5453 (record_buffer): Inhibit quitting and rewrite using quittable
5454 functions. Run Qbuffer_list_update_hook if allowed.
5455 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5456 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5457 Move switch-to-buffer to window.el.
9397e56f
MR
5458 (bury-buffer): Move to window.el.
5459 (Vbuffer_list_update_hook): New variable.
5460
5461 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5462 section.
5463
5464 * window.h (resize_frame_windows): Move up in code.
5465 (Fwindow_frame): Remove EXFUN.
5466 (replace_buffer_in_all_windows): Remove prototype.
5467 (replace_buffer_in_windows_safely): Add prototype.
5468
5469 * window.c: Declare Qdelete_window static again. Move down
5470 declaration of select_count.
5471 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5472 (Fother_window): Move to window.el.
5473 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5474 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5475 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5476 window.el.
5477 (replace_buffer_in_windows): Implement by calling
5478 Qreplace_buffer_in_windows.
5479 (replace_buffer_in_all_windows): Remove with some functionality
5480 moved into replace_buffer_in_windows_safely.
5481 (replace_buffer_in_windows_safely): New function.
5482 (select_window_norecord, select_frame_norecord): Move in front
5483 of run_window_configuration_change_hook. Remove now obsolete
5484 declarations.
640c8776
SM
5485 (Fset_window_buffer): Rewrite doc-string.
5486 Call Qrecord_window_buffer.
9397e56f
MR
5487 (keys_of_window): Move binding for other-window to window.el.
5488
b50691aa
CY
54892011-06-11 Chong Yidong <cyd@stupidchicken.com>
5490
5491 * dispextern.h (struct image): Replace data member, whose int_val
5492 and ptr_val fields were not used by anything, with a single
5493 lisp_val object.
5494
5495 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5496 (gif_clear_image, gif_load, imagemagick_load_image)
5497 (gs_clear_image, gs_load): Callers changed.
5498
3f754b86
PE
54992011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5500
cca69397
PE
5501 * buffer.h: Include <time.h>, for time_t.
5502 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5503
109e28d0
PE
5504 Fix minor problems found by static checking.
5505
60737f02
PE
5506 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5507
4b66faf3
PE
5508 Make identifiers static if they are not used in other modules.
5509 * data.c (Qcompiled_function, Qframe, Qvector):
5510 * image.c (QimageMagick, Qsvg):
5511 * minibuf.c (Qmetadata):
5512 * window.c (resize_window_check, resize_root_window): Now static.
5513 * window.h (resize_window_check, resize_root_window): Remove decls.
5514
109e28d0
PE
5515 * window.c (window_deletion_count, delete_deletable_window):
5516 Remove; unused.
46a4ce9e
PE
5517 (window_body_lines): Now static.
5518 (Fdelete_other_windows_internal): Mark vars as initialized.
5519 Make sure 'resize_failed' is initialized.
5520 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5521 (resize_window_apply): Remove unused local.
5522 * window.h (delete_deletable_window): Remove decl.
5523
109e28d0 5524 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5525 (imagemagick_load_image): Fix pointer signedness problem by changing
5526 last arg from unsigned char * to char *. All uses changed.
5527 Also, fix a local for similar reasons.
5528 Remove unused locals. Remove locals to avoid shadowing.
5529 (fn_rsvg_handle_free): Remove; unused.
5530 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5531 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5532
3f754b86
PE
5533 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5534
2547adb1
CY
55352011-06-10 Chong Yidong <cyd@stupidchicken.com>
5536
5537 * image.c (gif_load): Fix omitted cast error introduced by
5538 2011-06-06 change.
5539
2c8e37d4
MR
55402011-06-10 Martin Rudalics <rudalics@gmx.at>
5541
5542 * window.h (resize_proportionally, orig_total_lines)
5543 (orig_top_line): Remove from window structure.
5544 (set_window_height, set_window_width, change_window_heights)
5545 (Fdelete_window): Remove prototypes.
5546 (resize_frame_windows): Remove duplicate declaration.
5547
440a42e3
EZ
55482011-06-10 Eli Zaretskii <eliz@gnu.org>
5549
5550 * window.h (resize_frame_windows, resize_window_check)
5551 (delete_deletable_window, resize_root_window)
5552 (resize_frame_windows): Declare prototypes.
5553
5554 * window.c (resize_window_apply): Make definition be "static" to
5555 match the prototype.
5556
562dd5e9
MR
55572011-06-10 Martin Rudalics <rudalics@gmx.at>
5558
5559 * window.c: Remove declarations of Qwindow_size_fixed,
5560 window_min_size_1, window_min_size_2, window_min_size,
5561 size_window, window_fixed_size_p, enlarge_window, delete_window.
5562 Remove static from declaration of Qdelete_window, it's
5563 temporarily needed by Fbury_buffer.
5564 (replace_window): Don't assign orig_top_line and
5565 orig_total_lines.
5566 (Fdelete_window, delete_window): Remove. Window deletion is
5567 handled by window.el.
640c8776
SM
5568 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5569 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5570 (Fdelete_other_windows): Remove. Deleting other windows is
5571 handled by window.el.
5572 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5573 handled in window.el.
5574 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5575 Window minimum sizes are handled in window.el.
5576 (shrink_windows, size_window, set_window_height)
5577 (set_window_width, change_window_heights, window_height)
5578 (window_width, CURBEG, CURSIZE, enlarge_window)
5579 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5580 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5581 handled in window.el.
5582 (make_dummy_parent): Rename to make_parent_window and give it a
5583 second argument horflag.
5584 (make_window): Don't set resize_proportionally any more.
5585 (Fsplit_window): Remove. Windows are split in window.el.
5586 (save_restore_action, save_restore_orig_size)
5587 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5588 Resize mini windows in window.el.
5589 (grow_mini_window, shrink_mini_window): Implement by calling
5590 Qresize_root_window_vertically, resize_window_check and
5591 resize_window_apply.
640c8776
SM
5592 (saved_window, Fset_window_configuration, save_window_save):
5593 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5594 resize_proportionally.
5595 (window_min_height, window_min_width): Move to window.el.
5596 (keys_of_window): Move bindings for delete-other-windows,
5597 split-window, delete-window and enlarge-window to window.el.
5598
5599 * buffer.c: Temporarily extern Qdelete_window.
5600 (Fbury_buffer): Temporarily call Qdelete_window instead of
5601 Fdelete_window (Fbury_buffer will move to window.el soon).
5602
5603 * frame.c (set_menu_bar_lines_1): Remove code handling
5604 orig_top_line and orig_total_lines.
5605
5606 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5607 set_window_height but set heights directly.
5608 (change_frame_size_1): Use resize_frame_windows.
5609
5610 * xdisp.c (init_xdisp): Don't use set_window_height but set
5611 heights directly.
5612
640c8776
SM
5613 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5614 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5615 run_window_configuration_change_hook.
5616
5617 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5618 instead of change_window_heights and run
5619 run_window_configuration_change_hook.
5620
1a13852e
MR
56212011-06-09 Martin Rudalics <rudalics@gmx.at>
5622
5623 * window.c (replace_window): Rename second argument REPLACEMENT to
5624 NEW. New third argument SETFLAG. Rewrite.
5625 (delete_window, make_dummy_parent): Call replace_window with
5626 third argument 1.
5627 (window_list_1): Move down in code.
5628 (run_window_configuration_change_hook): Move set_buffer part
5629 before select_frame_norecord part in order to unwind correctly.
5630 Rename count1 to count.
5631 (recombine_windows, delete_deletable_window, resize_root_window)
5632 (Fdelete_other_windows_internal)
5633 (Frun_window_configuration_change_hook, make_parent_window)
5634 (resize_window_check, resize_window_apply, Fresize_window_apply)
5635 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5636 (Fdelete_window_internal, Fresize_mini_window_internal):
5637 New functions.
1a13852e
MR
5638 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5639
f3d1777e
MR
56402011-06-08 Martin Rudalics <rudalics@gmx.at>
5641
496e208e
MR
5642 * window.h (window): Add some new members to window structure -
5643 normal_lines, normal_cols, new_total, new_normal, clone_number,
5644 splits, nest, prev_buffers, next_buffers.
5645 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5646 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5647
f3d1777e
MR
5648 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5649 Remove.
496e208e
MR
5650 (make_dummy_parent): Set new members of windows structure.
5651 (make_window): Move down in code. Handle new members of window
5652 structure.
5653 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5654 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5655 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5656 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5657 (Fset_window_next_buffers, Fset_window_clone_number):
5658 New functions.
496e208e
MR
5659 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5660 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5661 Doc-string fixes.
5662 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5663 Argument WINDOW can be now internal window too.
5664 (Fwindow_use_time): Move up in code.
5665 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5666 Rewrite doc-string.
5667 (Fset_window_configuration, saved_window)
5668 (Fcurrent_window_configuration, save_window_save): Handle new
5669 members of window structure.
b9e809c2
MR
5670 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5671 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5672 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5673 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5674 Qget_mru_window, Qresize_root_window,
5675 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5676 Qauto_buffer_name; staticpro them.
f3d1777e 5677
abde8f8c
MR
56782011-06-07 Martin Rudalics <rudalics@gmx.at>
5679
5680 * window.c (Fwindow_total_size, Fwindow_left_column)
5681 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5682 (Fwindow_list_1): New functions.
5683 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5684 (Fwindow_width, Fscroll_left, Fscroll_right):
5685 Use window_body_cols instead of window_box_text_cols.
5686 (delete_window, Fset_window_configuration):
5687 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5688 (delete_all_subwindows): Take a window as argument and not a
5689 structure. Rewrite.
190b47e6
MR
5690 (window_loop): Remove handling of GET_LRU_WINDOW and
5691 GET_LARGEST_WINDOW.
5692 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5693
5694 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5695 window_box_text_cols. delete_all_subwindows now takes a
5696 Lisp_Object as argument.
abde8f8c 5697
640c8776
SM
5698 * indent.c (compute_motion, Fcompute_motion):
5699 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5700
fa8a67e6
MR
5701 * frame.c (delete_frame): Call delete_all_subwindows with root
5702 window as argument.
5703
a54e3482
DC
57042011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5705
5706 * fns.c (Fputhash): Document return value.
5707
60002bf5
CY
57082011-06-06 Chong Yidong <cyd@stupidchicken.com>
5709
5710 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5711
0c671da6 57122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5713
b862a52a 5714 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5715
be44ca6c
PE
5716 Check for overflow when converting integer to cons and back.
5717 * charset.c (Fdefine_charset_internal, Fdecode_char):
5718 Use cons_to_unsigned to catch overflow.
5719 (Fencode_char): Use INTEGER_TO_CONS.
5720 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5721 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5722 * data.c (long_to_cons, cons_to_long): Remove.
5723 (cons_to_unsigned, cons_to_signed): New functions.
5724 These signal an error for invalid or out-of-range values.
5725 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5726 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5727 * font.c (Ffont_variation_glyphs):
5728 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5729 * lisp.h: Include <intprops.h>.
5730 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5731 (cons_to_signed, cons_to_unsigned): New decls.
5732 (long_to_cons, cons_to_long): Remove decls.
5733 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5734 (Fprimitive_undo): Use CONS_TO_INTEGER.
5735 * xfns.c (Fx_window_property): Likewise.
5736 * xselect.c: Include <limits.h>.
5737 (x_own_selection, selection_data_to_lisp_data):
5738 Use INTEGER_TO_CONS.
5739 (x_handle_selection_request, x_handle_selection_clear)
5740 (x_get_foreign_selection, Fx_disown_selection_internal)
5741 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5742 (lisp_data_to_selection_data): Use cons_to_unsigned.
5743 (x_fill_property_data): Use cons_to_signed.
5744 Report values out of range.
5745
d1f3d2af
PE
5746 Check for buffer and string overflow more precisely.
5747 * buffer.h (BUF_BYTES_MAX): New macro.
5748 * lisp.h (STRING_BYTES_MAX): New macro.
5749 * alloc.c (Fmake_string):
5750 * character.c (string_escape_byte8):
5751 * coding.c (coding_alloc_by_realloc):
5752 * doprnt.c (doprnt):
5753 * editfns.c (Fformat):
5754 * eval.c (verror):
5755 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5756 since they may not be the same number.
5757 * editfns.c (Finsert_char):
5758 * fileio.c (Finsert_file_contents):
5759 Likewise for BUF_BYTES_MAX.
5760
dd52fcea
PE
5761 * image.c: Use ptrdiff_t, not int, for sizes.
5762 (slurp_file): Switch from int to ptrdiff_t.
5763 All uses changed.
5764 (slurp_file): Check that file size fits in both size_t (for
5765 malloc) and ptrdiff_t (for sanity and safety).
5766
7f9bbdbb
PE
5767 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5768 if b->modtime has its maximal value.
5769
dfe18f82
PE
5770 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5771
84acfcf0
PE
5772 Don't assume time_t can fit into int.
5773 * buffer.h (struct buffer.modtime): Now time_t, not int.
5774 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5775 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5776
ccd9a01a
PE
5777 Minor fixes for signed vs unsigned integers.
5778 * character.h (MAYBE_UNIFY_CHAR):
5779 * charset.c (maybe_unify_char):
5780 * keyboard.c (read_char, reorder_modifiers):
5781 XINT -> XFASTINT, since the integer must be nonnegative.
5782 * ftfont.c (ftfont_spec_pattern):
5783 * keymap.c (access_keymap, silly_event_symbol_error):
5784 XUINT -> XFASTINT, since the integer must be nonnegative.
5785 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5786 since it makes no difference and we prefer signed.
5787 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5788 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5789 nonnegative.
5790
d6d100dd
SM
57912011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5792
5793 * window.h (Fwindow_frame): Declare.
5794
2b6148e4
PE
57952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5796
5797 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5798 (SPARE_MEMORY): Always define.
5799 (LARGE_REQUEST): Remove.
5800 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5801
f230ecc9
MR
58022011-06-06 Martin Rudalics <rudalics@gmx.at>
5803
727e958e
MR
5804 * lisp.h: Move EXFUNS for Fframe_root_window,
5805 Fframe_first_window and Fset_frame_selected_window to window.h.
5806
5807 * window.h: Move EXFUNS for Fframe_root_window,
5808 Fframe_first_window and Fset_frame_selected_window here from
5809 lisp.h.
5810
5811 * frame.c (Fwindow_frame, Fframe_first_window)
5812 (Fframe_root_window, Fframe_selected_window)
5813 (Fset_frame_selected_window): Move to window.c.
5814 (Factive_minibuffer_window): Move to minibuf.c.
5815 (Fother_visible_frames_p): New function.
5816
5817 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5818
f230ecc9
MR
5819 * window.c (decode_window, decode_any_window): Move up in code.
5820 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5821 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5822 (Fwindow_buffer): Move up and rewrite doc-string.
5823 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5824 (Fwindow_prev): New functions.
727e958e
MR
5825 (Fwindow_frame): Move here from frame.c. Accept any window as
5826 argument.
5827 (Fframe_root_window, Fframe_first_window)
5828 (Fframe_selected_window): Move here from frame.c. Accept frame
5829 or arbitrary window as argument. Update doc-strings.
5830 (Fminibuffer_window): Move up in code.
5831 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5832 (Fset_frame_selected_window): Move here from frame.c.
5833 Marginal rewrite.
727e958e
MR
5834 (Fselected_window, select_window, Fselect_window): Move up in
5835 code. Minor doc-string fixes.
f230ecc9 5836
4d09bcf6
PE
58372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5838
5839 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5840 Do not assume that spare memory exists; that assumption is valid
5841 only if SYSTEM_MALLOC.
5842 (LARGE_REQUEST): New macro, so that the issue of large requests
5843 is separated from the issue of spare memory.
5844
810928a2
AS
58452011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5846
172418ad
AS
5847 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5848 format. (Bug#8806)
5849
43f862f7
AS
5850 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5851
810928a2
AS
5852 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5853 before statements.
5854
a059fe24
JD
58552011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5856
5857 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5858
5859 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5860
5861 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5862 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5863
989bf368
JB
58642011-06-05 Juanma Barranquero <lekktu@gmail.com>
5865
5866 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5867
4b80f674
CY
58682011-06-04 Chong Yidong <cyd@stupidchicken.com>
5869
5870 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5871 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5872 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5873 New error handlers.
4b80f674
CY
5874 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5875 Obey Vx_select_enable_clipboard_manager. Catch errors in
5876 x_clipboard_manager_save (Bug#8779).
5877 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5878 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5879
99a33b77 58802011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5881
5882 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5883
99a33b77 58842011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5885
5886 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5887 in the current matrix if keep_current_p is non-zero.
5888
8264569d
EZ
58892011-06-04 Eli Zaretskii <eliz@gnu.org>
5890
5891 * bidi.c (bidi_level_of_next_char): Fix last change.
5892
57f97249
EZ
58932011-06-03 Eli Zaretskii <eliz@gnu.org>
5894
fec2107c 5895 Support bidi reordering of text covered by display properties.
57f97249 5896
fec2107c
EZ
5897 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5898 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5899 (bidi_cache_search, bidi_cache_iterator_state)
5900 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5901 (bidi_level_of_next_char, bidi_move_to_visually_next):
5902 Support character positions inside a run of characters covered by a
fec2107c
EZ
5903 display string.
5904 (bidi_paragraph_init, bidi_resolve_explicit_1)
5905 (bidi_level_of_next_char): Call bidi_fetch_char and
5906 bidi_fetch_char_advance instead of FETCH_CHAR and
5907 FETCH_CHAR_ADVANCE.
5908 (bidi_init_it): Initialize new members.
5909 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5910 definitions.
5911 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5912 instead of using explicit *_CHAR codes.
d6d100dd
SM
5913 (bidi_resolve_explicit, bidi_resolve_weak):
5914 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5915 bidirectional text is supported only in multibyte buffers.
5916 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5917 it to initialize the frame_window_p member of struct bidi_it.
5918 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5919 (bidi_resolve_explicit, bidi_resolve_weak)
5920 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5921 bidi_it->nchars is non-positive.
5922 (bidi_level_of_next_char): Don't try to lookup the cache for the
5923 next/previous character if nothing is cached there yet, or if we
5924 were just reseat()'ed to a new position.
c40e2fb2 5925
0e14fe90
EZ
5926 * xdisp.c (set_cursor_from_row): Set start and stop points
5927 according to the row's direction when priming the loop that looks
5928 for the glyph on which to display cursor.
5929 (single_display_spec_intangible_p): Function deleted.
5930 (display_prop_intangible_p): Reimplement to call
5931 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5932 Accept 3 additional arguments needed by handle_display_spec.
5933 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5934 values: lists, `(when COND...)' forms, etc.
5935 (single_display_spec_string_p): Support property values that are
5936 lists with the argument STRING its top-level element.
5937 (display_prop_string_p): Fix the condition for processing a
5938 property that is a list to be consistent with handle_display_spec.
fec2107c 5939 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5940 last portion of handle_display_prop.
5941 (compute_display_string_pos): Accept additional argument
5942 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5943 value of a `display' property is a "replacing spec".
5944 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5945 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5946 the display property, but just return a value indicating whether
5947 the display property will replace the characters it covers.
5948 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5949 frame_window_p members of struct bidi_it.
d6d100dd
SM
5950 (compute_display_string_pos, compute_display_string_end):
5951 New functions.
fec2107c
EZ
5952 (push_it): Accept second argument POSITION, where pop_it should
5953 jump to continue iteration.
5954 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5955
fec2107c
EZ
5956 * keyboard.c (adjust_point_for_property): Adjust the call to
5957 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5958
5959 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5960 (bidi_init_it): Update prototypes.
5961 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5962 (compute_display_string_pos, compute_display_string_end):
5963 Declare prototypes.
fec2107c
EZ
5964 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5965 EMACS_INT.
fc6f18ce 5966
40087514 59672011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5968
57f53182
PE
5969 Malloc failure behavior now depends on size of allocation.
5970 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5971 * lisp.h: Change signatures accordingly.
5972 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5973 All callers changed. (Bug#8762)
5974
5975 * gnutls.c: Use Emacs's memory allocators.
5976 Without this change, the gnutls library would invoke malloc etc.
5977 directly, which causes problems on non-SYNC_INPUT hosts, and which
5978 runs afoul of improving memory_full behavior. (Bug#8761)
5979 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5980 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5981 xfree instead of the default malloc, realloc, free.
5982 (Fgnutls_boot): No need to check for memory allocation failure,
5983 since xmalloc does that for us.
5984
ac32cd99 5985 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5986 * category.c (hash_get_category_set):
5987 * ccl.c (ccl_driver):
5988 * charset.c (Fdefine_charset_internal):
5989 * charset.h (struct charset.hash_index):
5990 * composite.c (get_composition_id, gstring_lookup_cache)
5991 (composition_gstring_put_cache):
5992 * composite.h (struct composition.hash_index):
5993 * dispextern.h (struct image.hash):
5994 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5995 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5996 (hashfn_equal, hashfn_user_defined, make_hash_table)
5997 (maybe_resize_hash_table, hash_lookup, hash_put)
5998 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5999 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6000 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6001 * image.c (make_image, search_image_cache, lookup_image)
6002 (xpm_put_color_table_h):
6003 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6004 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6005 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6006 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6007 * alloc.c (allocate_vectorlike):
6008 Check for overflow in vector size calculations.
6009 * ccl.c (ccl_driver):
6010 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6011 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6012 need to be updated by these changes.
40087514
PE
6013 * fns.c (make_hash_table, maybe_resize_hash_table):
6014 Check for integer overflow with large hash tables.
0de4bb68
PE
6015 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6016 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6017 (SXHASH_REDUCE): New macro.
6018 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6019 Use it instead of discarding useful hash info with large hash values.
6020 (sxhash_float): New function.
6021 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6022 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6023 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6024 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6025 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6026 Adjust signatures to match updated version of code.
6027 (consing_since_gc): Now EMACS_INT, since a single hash table can
6028 use more than INT_MAX bytes.
6029
698d32e2
DN
60302011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6031
6032 Make it possible to build with GCC-4.6+ -O2 -flto.
6033
6034 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6035
fd6fa53f
SM
60362011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6037
6038 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6039 Call minibuffer-inactive-mode.
6040
864db017
JB
60412011-05-31 Juanma Barranquero <lekktu@gmail.com>
6042
6043 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6044 Update dependencies.
6045
2ad0baf4
DN
60462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6047
6048 * data.c (init_data): Remove code for UTS, this system is not
6049 supported anymore.
6050
4fcc2638
DN
60512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6052
6053 Don't force ./temacs to start in terminal mode.
6054
6055 * frame.c (make_initial_frame): Initialize faces in all cases, not
6056 only when CANNOT_DUMP is defined.
6057 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6058
c56e0fd5
DN
60592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6060
6061 * dispnew.c (add_window_display_history): Use const for the string
6062 pointer. Remove declaration, not needed.
6063
333d54da 60642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6065
55d4c1b2 6066 Use 'inline', not 'INLINE'.
333d54da 6067 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6068 * alloc.c, fontset.c (INLINE): Remove.
6069 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6070 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6071 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6072 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6073 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6074
738db178
DN
60752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6076
6077 Make it possible to run ./temacs.
6078
6079 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6080 syms_of_callproc does the same thing. Remove test for
6081 "initialized", do it in the caller.
6082 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6083
620c53a6
SM
60842011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6085
6086 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6087 (read_minibuf): Use get_minibuffer.
6088 (syms_of_minibuf): Use DEFSYM.
6089 (Qmetadata): New var.
6090 * data.c (Qbuffer): Don't make it static.
6091 (syms_of_data): Use DEFSYM.
6092
e003a292
PE
60932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6094
6095 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6096 (CCL_CODE_MIN): New macro.
6097
ed008a6d
PE
60982011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6099
3687c2ef
PE
6100 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6101
ed008a6d
PE
6102 * eval.c (Qdebug): Now static.
6103 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6104 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6105 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6106
d66c4c7c
CY
61072011-05-29 Chong Yidong <cyd@stupidchicken.com>
6108
6109 * image.c: Various fixes to ImageMagick code comments.
6110 (Fimagemagick_types): Doc fix.
6111
5fbc2025
PE
61122011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6113
0196f88a
PE
6114 Minor fixes prompted by GCC 4.6.0 warnings.
6115
6116 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6117
5fbc2025
PE
6118 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6119 (x_clipboard_manager_save_all): Move extern decl to ...
6120 * xterm.h: ... here, so that it can be checked for consistency.
6121
1dd3c2d9
CY
61222011-05-29 Chong Yidong <cyd@stupidchicken.com>
6123
6124 * xselect.c (x_clipboard_manager_save_frame)
6125 (x_clipboard_manager_save_all): New functions.
6126 (Fx_clipboard_manager_save): Lisp function deleted.
6127
6128 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6129 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6130
6131 * xterm.h: Update prototype.
6132
5ba6571d
WX
61332011-05-28 William Xu <william.xwl@gmail.com>
6134
6135 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6136 exiting (Bug#8239).
6137
3eaff834
JM
61382011-05-28 Jim Meyering <meyering@redhat.com>
6139
e1900994 6140 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6141 * fns.c (to_uchar): Define.
6142 (crypto_hash_function): Use it to convert some newly-signed
6143 variables to unsigned, to avoid sign-extension bugs. For example,
6144 without this change, (md5 "truc") would evaluate to
6145 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6146 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6147 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6148
0f6990a7
PE
61492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6150
6151 Integer overflow fixes.
c8a9ca5a 6152
08686060
PE
6153 * dbusbind.c: Serial number integer overflow fixes.
6154 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6155 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6156 to hold a serial number that is too large for a fixnum.
6157 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6158 Check for serial numbers out of range. Decode any serial number
59568bf0 6159 that was so large that it became a float. (Bug#8722)
08686060 6160
2d1fc3c7
PE
6161 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6162 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6163 Use XFASTINT rather than XUINT when numbers are nonnegative.
6164 (xd_append_arg, Fdbus_method_return_internal):
6165 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6166 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6167 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6168 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6169 (Bug#8722)
2d1fc3c7 6170
c8a9ca5a
PE
6171 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6172
519e1d69
PE
6173 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6174
6df6ae42 6175 ccl: Add integer overflow checks.
30569699
PE
6176 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6177 (IN_INT_RANGE): New macros.
6178 (ccl_driver): Use them to check for integer overflow when
6179 decoding a CCL program. Many of the new checks are whether XINT (x)
6180 fits in int; it doesn't always, on 64-bit hosts. The new version
6181 doesn't catch all possible integer overflows, but it's an
847044ea 6182 improvement. (Bug#8719)
30569699 6183
c11285dc
PE
6184 * alloc.c (make_event_array): Use XINT, not XUINT.
6185 There's no need for unsigned here.
6186
fdccd48e
PE
6187 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6188 This follows up to the 2011-05-06 change that substituted uintptr_t
6189 for EMACS_INT. This case wasn't caught back then.
6190
37910ab2
PE
6191 Rework Fformat to avoid integer overflow issues.
6192 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6193 now (part of C89). Include <verify.h>.
6194 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6195 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6196 (Fformat): Avoid the prepass trying to compute sizes; it was only
6197 approximate and thus did not catch overflow reliably. Instead, walk
6198 through the format just once, formatting and computing sizes as we go,
6199 checking for integer overflow at every step, and allocating a larger
6200 buffer as needed. Keep track separately whether the format is
6201 multibyte. Keep only the most-recently calculated precision, rather
6202 than them all. Record whether each argument has been converted to
6203 string. Use EMACS_INT, not int, for byte and char and arg counts.
6204 Support field widths and precisions larger than INT_MAX. Avoid
6205 sprintf's undefined behavior with conversion specifications such as %#d
6206 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6207 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6208 formatting out-of-range floating point numbers with int
9173deec 6209 formats. (Bug#8668)
37910ab2 6210
2e6578fb
PE
6211 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6212
0ae6bdee
PE
6213 * data.c: Avoid integer truncation in expressions involving floats.
6214 * data.c: Include <intprops.h>.
6215 (arith_driver): When there's an integer overflow in an expression
6216 involving floating point, convert the integers to floating point
6217 so that the resulting value does not suffer from catastrophic
6218 integer truncation. For example, on a 64-bit host (* 4
6219 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6220 Do not rely on undefined behavior after integer overflow.
6221
de883a70
PE
6222 merge count_size_as_multibyte, parse_str_to_multibyte
6223 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6224 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6225 Check for integer overflow.
6226 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6227 since it's now a duplicate of the other. This is more of
6228 a character than a buffer op, so better that it's in character.c.
6229 * fns.c, print.c: Adjust to above changes.
6230
2ff916cb
PE
62312011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6232
6233 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6234
f1b54466
PE
62352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6236
fb1ac845
PE
6237 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6238 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6239 (x_clipboard_manager_save): Now static.
6240 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6241
f1b54466
PE
6242 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6243 (crypto_hash_function): Now static.
6244 Fix pointer signedness problems. Avoid unnecessary initializations.
6245
a9f737ee
CY
62462011-05-27 Chong Yidong <cyd@stupidchicken.com>
6247
6248 * termhooks.h (Vselection_alist): Make it terminal-local.
6249
6250 * terminal.c (create_terminal): Initialize it.
6251
6252 * xselect.c: Support for clipboard managers.
6253 (Vselection_alist): Move to termhooks.h as terminal-local var.
6254 (LOCAL_SELECTION): New macro.
6255 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6256 (symbol_to_x_atom): Remove gratuitous arg.
6257 (x_handle_selection_request, lisp_data_to_selection_data)
6258 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6259 (x_own_selection, x_get_local_selection, x_convert_selection):
6260 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6261 (some_frame_on_display): Delete unused function.
6262 (Fx_own_selection_internal, Fx_get_selection_internal)
6263 (Fx_disown_selection_internal, Fx_selection_owner_p)
6264 (Fx_selection_exists_p): New optional frame arg.
6265 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6266 (x_handle_selection_clear): Don't treat other terminals with the
6267 same keyboard specially. Use the terminal-local Vselection_alist.
6268 (x_clear_frame_selections): Use Frun_hook_with_args.
6269
6270 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6271
6272 * xterm.h: Add support for those atoms.
6273
e067f0c1
CY
62742011-05-26 Chong Yidong <cyd@stupidchicken.com>
6275
6276 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6277 (converted_selections, conversion_fail_tag): New global variables.
6278 (x_selection_request_lisp_error): Free the above.
6279 (x_get_local_selection): Remove unnecessary code.
6280 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6281 of converted selections stored in converted_selections.
6282 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6283 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6284 (x_convert_selection): New function.
6285 (x_handle_selection_event): Simplify.
6286 (x_get_foreign_selection): Don't ignore incoming requests while
6287 waiting for an answer; this will fail when we implement
6288 SAVE_TARGETS, and seems unnecessary anyway.
6289 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6290 (Vx_sent_selection_functions): Doc fix.
6291
0f4aebc0
LL
62922011-05-26 Leo Liu <sdl.web@gmail.com>
6293
6294 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6295
e61124cd
YM
62962011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6297
6298 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6299
6300 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6301 for fringe update if it has periodic bitmap.
ac389d0c 6302 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6303 and fringe_bitmap_periodic_p.
6304
6305 * fringe.c (get_fringe_bitmap_data): New function.
6306 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6307 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6308 row. Mark glyph row for fringe update if periodicity changed.
6309
6310 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6311 for fringe update unless it has periodic bitmap.
6312
f16d9837
KH
63132011-05-25 Kenichi Handa <handa@m17n.org>
6314
6315 * xdisp.c (get_next_display_element): Set correct it->face_id for
6316 a static composition.
6317
e1b90ef6
LL
63182011-05-24 Leo Liu <sdl.web@gmail.com>
6319
6320 * deps.mk (fns.o):
6321 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6322
6323 * fns.c (crypto_hash_function, Fsha1): New function.
6324 (Fmd5): Use crypto_hash_function.
6325 (syms_of_fns): Add Ssha1.
6326
7400048f
PE
63272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6328
6329 * gnutls.c: Remove unused macros.
6330 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6331 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6332 Remove macros that are defined and never used.
6333 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6334
abb71cf4
CY
63352011-05-22 Chong Yidong <cyd@stupidchicken.com>
6336
6337 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6338 (Fx_get_selection_internal): Minor cleanup.
6339 (Fx_own_selection_internal): Rename arguments for consistency with
6340 select.el.
6341
6307db39
PE
63422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6343
6344 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6345
f3d4e0a4
CY
63462011-05-22 Chong Yidong <cyd@stupidchicken.com>
6347
6348 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6349
4d8ade89
YM
63502011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6351
6352 * dispnew.c (scrolling_window): Don't exclude the case that the
6353 last enabled row in the desired matrix touches the bottom boundary.
6354
32078c8d
GM
63552011-05-21 Glenn Morris <rgm@gnu.org>
6356
6357 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6358 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6359 and add some more files.
32078c8d 6360
7285dc67
EZ
63612011-05-20 Eli Zaretskii <eliz@gnu.org>
6362
6363 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6364 report_file_error introduced by the change from 2011-05-07.
6365
89d1bd22
PE
63662011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6367
6368 * systime.h (Time): Define only if emacs is defined.
6369 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6370 where the include path doesn't have X11/X.h by default. See
6371 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6372
cd394be1 63732011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6374
6375 * composite.c (find_automatic_composition): Fix previous change.
6376
b9704ad9
GM
63772011-05-20 Glenn Morris <rgm@gnu.org>
6378
6379 * lisp.mk: New file, split from Makefile.in.
6380 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6381 (shortlisp): Remove.
6382 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6383
4a720484
GM
63842011-05-19 Glenn Morris <rgm@gnu.org>
6385
6386 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6387 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6388 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6389 (lisp): Set the order to that of loadup.el.
6390 (shortlisp): Make it a copy of $lisp.
6391 (SOME_MACHINE_LISP): Remove.
6392 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6393 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6394
a28d4396
KH
63952011-05-18 Kenichi Handa <handa@m17n.org>
6396
6397 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6398 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6399 (find_automatic_composition): Mostly rewrite for efficiency.
6400
a2b1fa8e
JB
64012011-05-18 Juanma Barranquero <lekktu@gmail.com>
6402
6403 * makefile.w32-in: Update dependencies.
6404
8e1f5610
CS
64052011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6406
6407 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6408 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6409
7025ee00 64102011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6411
cdfa6eab
PE
6412 Fix some integer overflow issues, such as string length overflow.
6413
06d6db33
PE
6414 * insdel.c (count_size_as_multibyte): Check for string overflow.
6415
2b4560a8
PE
6416 * character.c (lisp_string_width): Check for string overflow.
6417 Use EMACS_INT, not int, for string indexes and lengths; in
6418 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6419 the resulting string length overflows an EMACS_INT; instead,
6420 report a string overflow if no precision given. When checking for
6421 precision exhaustion, use a check that cannot possibly have
6422 integer overflow. (Bug#8675)
6423 * character.h (lisp_string_width): Adjust to new signature.
6424
cb93f9be
PE
6425 * alloc.c (string_overflow): New function.
6426 (Fmake_string): Use it. This doesn't change behavior, but saves
6427 a few bytes and will simplify future changes.
6428 * character.c (string_escape_byte8): Likewise.
6429 * lisp.h (string_overflow): New decl.
6430
1a1f3366
PE
6431 Fixups, following up to the user-interface timestamp change.
6432 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6433 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6434 * msdos.c (mouse_get_pos): Likewise.
6435 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6436 * w32gui.h (Time): Define by including "systime.h" rather than by
6437 declaring it ourselves. (Bug#8664)
6438
d4e3e4d3
PE
6439 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6440 * image.c (clear_image_cache): Likewise.
6441
f6a24d19
PE
6442 * term.c (term_mouse_position): Don't assume time_t wraparound.
6443
08dc5ae6
PE
6444 Be more systematic about user-interface timestamps.
6445 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6446 and sometimes 'EMACS_UINT', to represent these timestamps.
6447 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6448 This makes the code easier to follow, and makes it easier to catch
6449 integer overflow bugs such as Bug#8664.
6450 * frame.c (Fmouse_position, Fmouse_pixel_position):
6451 Use Time, not unsigned long, for user-interface timestamps.
6452 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6453 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6454 * keyboard.h (last_event_timestamp): Likewise.
6455 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6456 * menu.h (xmenu_show): Likewise.
6457 * term.c (term_mouse_position): Likewise.
6458 * termhooks.h (struct input_event.timestamp): Likewise.
6459 (struct terminal.mouse_position_hook): Likewise.
6460 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6461 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6462 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6463 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6464 what it was before.
6465 * menu.h, termhooks.h: Include "systime.h", for Time.
6466
8e55734a
PE
6467 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6468 Don't assume that the difference between two unsigned long values
6469 can fit into an integer. At this point, we know button_down_time
6470 <= event->timestamp, so the difference must be nonnegative, so
6471 there's no need to cast the result if double-click-time is
6472 nonnegative, as it should be; check that it's nonnegative, just in
6473 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6474 apart (about 25 days). (Bug#8664)
8e55734a 6475
841f1b75 6476 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6477 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6478
3e26f69c
PE
6479 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6480 that always fit in int. Use a sentinel instead of a counter, to
6481 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6482 * frame.h (struct frame): Use int for menu_bar_items_used
6483 instead of EMACS_INT, since it always fits in int.
3e26f69c 6484
5cc152c0
PE
6485 * menu.c (grow_menu_items): Check for int overflow.
6486
d89eb65e
PE
6487 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6488
5235bd3e
PE
6489 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6490 Before, the code was not consistent. These values cannot exceed
6491 2**31 - 1 so there's no need to make them unsigned.
6492 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6493 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6494 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6495 as modifiers.
6496 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6497
bc827e23
PE
6498 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6499 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6500 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6501 presumably because the widths might not match.
6502
78eb494e
PE
6503 * window.c (size_window): Avoid needless test at loop start.
6504
04f2d78b
CB
65052011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6506
6507 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6508
d2fc7e3d 65092011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6510
6511 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6512
d2fc7e3d 65132011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6514
6515 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6516 `width' to `bar_area_x' and `bar_area_width', respectively.
6517 (x_scroll_run): Take account of fringe background extension.
6518
04f2d78b
CB
6519 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6520 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6521 `bar_area_width', respectively.
6522 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6523 background extension.
6524
79b70037
GM
65252011-05-10 Jim Meyering <meyering@redhat.com>
6526
6527 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6528
2f142cc5
JB
65292011-05-10 Juanma Barranquero <lekktu@gmail.com>
6530
6531 * image.c (Finit_image_library): Return t for built-in image types,
6532 like pbm and xbm. (Bug#8640)
6533
57679c86
AS
65342011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6535
6536 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6537
888c9e86
EZ
65382011-05-07 Eli Zaretskii <eliz@gnu.org>
6539
b0512a1d
EZ
6540 * w32console.c (Fset_screen_color): Doc fix.
6541 (Fget_screen_color): New function.
6542 (syms_of_ntterm): Defsubr it.
6543
7285dc67
EZ
6544 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6545 unlink the temporary file if Fcall_process didn't create it in the
6546 first place.
6547 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6548 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6549 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6550 cue to call_process_cleanup not to close that handle.
6551
4d3fcc8e
BK
65522011-05-07 Ben Key <bkey76@gmail.com>
6553
6554 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6555 one of two shell specific rules, either bootstrap-temacs-CMD or
6556 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6557 to the previous implementation of the bootstrap-temacs rule.
6558 The bootstrap-temacs-CMD rule is similar to the previous
6559 implementation of the bootstrap-temacs rule except that it
6560 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6561 variable.
6562
6563 These changes, along with some changes to nt/configure.bat,
6564 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6565 earlier fix to add support for --cflags and --ldflags options
6566 that include quotes so that it works whether make uses cmd or
6567 sh as the shell.
6568
b4289b64
MA
65692011-05-06 Michael Albinus <michael.albinus@gmx.de>
6570
6571 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6572 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6573 is a constant.
6574 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6575 a string. Handle both cases.
6576 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6577 (Fdbus_register_method): Use Qinvalid_function.
6578
af4c0e28
JB
65792011-05-06 Juanma Barranquero <lekktu@gmail.com>
6580
6581 * makefile.w32-in: Update dependencies.
6582 (LISP_H): Add inttypes.h and stdin.h.
6583 (PROCESS_H): Add unistd.h.
6584
c51453d9
EZ
65852011-05-06 Eli Zaretskii <eliz@gnu.org>
6586
6587 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6588 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6589
8ff0ac3c 65902011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6591
4c4b566b
PE
6592 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6593
aab2b9b5
PE
6594 * term.c (vfatal): Remove stray call to va_end.
6595 It's not needed and the C Standard doesn't allow it here anyway.
6596
c378da0b
PE
6597 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6598 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6599
288b08c7
PE
6600 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6601 bytes.
6602
e3601888
PE
6603 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6604
db6c0e74
PE
6605 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6606
dd5963ea
PE
6607 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6608
88c9450f
PE
6609 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6610
2f9442b8
PE
6611 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6612
c032b5f8
PE
6613 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6614 * charset.c (Fdefine_charset_internal): Don't initialize
6615 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6616 32-bit int (Bug#8600).
a108c10b
PE
6617
6618 * lread.c (read_integer): Be more consistent with string-to-number.
6619 Use string_to_number to do the actual conversion; this avoids
6620 rounding errors and fixes some other screwups. Without this fix,
6621 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6622 (digit_to_number): Move earlier, for benefit of read_integer.
6623 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6624 not a digit in any supported base. (Bug#8602)
a108c10b 6625
ad5f9eea
PE
6626 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6627
aec1708a
PE
6628 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6629 to match comment at start of function. This also removes a
6630 GCC warning about overflow in a 32+64-bit port.
6631
47be4ab5
PE
6632 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6633
371cac43
PE
6634 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6635 Reported by Stefan Monnier in
6636 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6637 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6638 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6639
d01a7826
PE
6640 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6641 (EMACS_UINTPTR): Likewise, with uintptr_t.
6642
7fd47d5c
PE
6643 * lisp.h: Prefer 64-bit EMACS_INT if available.
6644 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6645 on 32-bit hosts that have 64-bit int, so that they can access
6646 large files.
122b0c86
PE
6647 However, temporarily disable this change unless the temporary
6648 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6649
8727937b
PE
6650 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6651
8ac068ac
PE
6652 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6653 This removes an assumption that EMACS_INT and long are the same
6654 width as pointers. The assumption is true for Emacs porting targets
6655 now, but we want to make other targets possible.
6656 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6657 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6658 In the rest of the code, change types of integers that hold casted
6659 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6660 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6661 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6662 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6663 No need to cast type when ORing.
6664 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6665 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6666 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6667 assume EMACS_INT is the same width as char *.
6668 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6669 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6670 Remove no-longer-needed casts.
6671 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6672 (xg_tool_bar_help_callback, xg_make_tool_item):
6673 Use EMACS_INTPTR to hold an integer
6674 that will be cast to void *; this can avoid a GCC warning
6675 if EMACS_INT is not the same width as void *.
6676 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6677 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6678 (current_message_1, set_message_1):
6679 Use a local to convert to proper width without a cast.
6680 * xmenu.c (dialog_selection_callback): Likewise.
6681
ede49d71
PE
6682 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6683 Also, don't assume VALBITS / RAND_BITS is less than 5,
6684 and don't rely on undefined behavior when shifting a 1 left into
6685 the sign bit.
6686 * lisp.h (get_random): Change signature to match.
6687
2f30ecd0
PE
6688 * lread.c (hash_string): Use size_t, not int, for hash computation.
6689 Normally we prefer signed values; but hashing is special, because
6690 it's better to use unsigned division on hash table sizes so that
6691 the remainder is nonnegative. Also, size_t is the natural width
6692 for hashing into memory. The previous code used 'int', which doesn't
6693 retain enough info to hash well into very large tables.
6694 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6695
2a866e7b
PE
6696 * dbusbind.c: Don't possibly lose pointer info when converting.
6697 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6698 Use XPNTR rather than XHASH, so that the high-order bits of
6699 the pointer aren't lost when converting through void *.
6700
51639eac
PE
6701 * eval.c (Fautoload): Don't double-shift a pointer.
6702
92394119
PE
6703 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6704
dbdb9a7c
JB
67052011-05-06 Juanma Barranquero <lekktu@gmail.com>
6706
6707 * gnutls.c (DEF_GNUTLS_FN):
6708 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6709
db7a0b4f
AS
67102011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6711
6712 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6713 marker. (Bug#8610)
6714
cd394be1 67152011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6716
6717 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6718 New version that can reserve upto 2GB of heap space.
6719
f7ff1b0f 67202011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6721
6722 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6723
639c109b
TZ
67242011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6725
6726 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6727 `gnutls_certificate_set_x509_key_file'.
6728
d2127135
JB
67292011-05-05 Juanma Barranquero <lekktu@gmail.com>
6730
6731 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6732 Update dependencies.
6733
e968f4f3
JB
67342011-05-04 Juanma Barranquero <lekktu@gmail.com>
6735
6736 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6737 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6738 Remove unused parameter `fildes'.
6739 * process.c (read_process_output, send_process): Don't pass it.
6740
84d358f0
JB
67412011-05-04 Juanma Barranquero <lekktu@gmail.com>
6742
6743 Fix previous change: the library cache is defined in w32.c.
6744 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6745 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6746
0898ca10
JB
67472011-05-04 Juanma Barranquero <lekktu@gmail.com>
6748
6749 Implement dynamic loading of GnuTLS on Windows.
6750
6751 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6752 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6753 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6754 Declare.
6755
6756 * gnutls.c (Qgnutls_dll): Define.
6757 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6758 (gnutls_*): Declare function pointers.
6759 (init_gnutls_functions): New function to initialize function pointers.
6760 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6761 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6762 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6763 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6764 (emacs_gnutls_write, emacs_gnutls_read)
6765 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6766 (Fgnutls_available_p): New function.
6767 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6768 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6769 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6770
6771 * image.c: Include w32.h.
6772 (Vimage_type_cache): Delete.
6773 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6774 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6775 (w32_delayed_load): Move to w32.c.
6776
6777 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6778
6779 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6780 (w32_delayed_load): Move from image.c. When loading a library, record
6781 its filename in the :loaded-from property of the library id.
6782 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6783 Initialize and staticpro them.
6784 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6785
6786 * process.c: Include lisp.h before w32.h, not after.
6787 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6788 instead of gnutls_record_check_pending.
6789
6790 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6791
ff4de4aa
TZ
67922011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6793
6794 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6795 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6796 as passed in.
6797
abe95abb
JD
67982011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6799
6800 * xterm.c (x_set_frame_alpha): Do not set property on anything
6801 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6802
e16e55d4
JB
68032011-05-02 Juanma Barranquero <lekktu@gmail.com>
6804
6805 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6806
bafcf6a5
JB
68072011-05-02 Juanma Barranquero <lekktu@gmail.com>
6808
6809 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6810 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6811 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6812 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6813 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6814 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6815 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6816 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6817 (Qgnutls_bootprop_callbacks_verify): Make static.
6818
e7a6747f
AS
68192011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6820
19ed11ba
AS
6821 * callproc.c: Indentation fixup.
6822
e7a6747f 6823 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6824 (wait_for_termination, interruptible_wait_for_termination):
6825 Move after wait_for_termination_1.
e7a6747f 6826
1ef14cb4
LMI
68272011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6828
6829 * sysdep.c (interruptible_wait_for_termination): New function
6830 which is like wait_for_termination, but allows keyboard
6831 interruptions.
6832
6833 * callproc.c (Fcall_process): Add (:file "file") as an option for
6834 the STDOUT buffer.
6835 (Fcall_process_region): Ditto.
6836
330d880c
EZ
68372011-04-30 Eli Zaretskii <eliz@gnu.org>
6838
8db90b73
EZ
6839 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6840 rather than `XVECTOR (FOO)->size'.
6841
330d880c
EZ
6842 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6843 inttypes.h, as a gnulib replacement is used if it not available in
6844 system headers.
6845
15cbd324
EZ
68462011-04-21 Eli Zaretskii <eliz@gnu.org>
6847
6848 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6849 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6850 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6851
6852 * coding.c (coding_alloc_by_realloc): Error out if destination
6853 will grow beyond MOST_POSITIVE_FIXNUM.
6854 (decode_coding_emacs_mule): Abort if there isn't enough place in
6855 charbuf for the composition carryover bytes. Reserve an extra
6856 space for up to 2 characters produced in a loop.
6857 (decode_coding_iso_2022): Abort if there isn't enough place in
6858 charbuf for the composition carryover bytes.
6859
68602011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6861
ae940cca
EZ
6862 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6863 aborting when %lld or %lll format is passed.
6864 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6865 %llo or %llx format is passed. (Bug#8545)
6866
03ab8921
EZ
6867 * window.c (window_scroll_line_based): Use a marker instead of
6868 simple variables to record original value of point. (Bug#7952)
6869
afda1437
EZ
6870 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6871 produced by %s or %c overflows available buffer space. (Bug#8545)
6872
f76dee0c
PE
68732011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6874
6875 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6876 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6877
fdc5744d
JB
68782011-04-28 Juanma Barranquero <lekktu@gmail.com>
6879
6880 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6881
638f053a
JB
68822011-04-28 Juanma Barranquero <lekktu@gmail.com>
6883
6884 * keyboard.c (Qdelayed_warnings_hook): Define.
6885 (command_loop_1): Run `delayed-warnings-hook'
6886 if Vdelayed_warnings_list is non-nil.
6887 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6888 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6889
d178f871
EZ
68902011-04-28 Eli Zaretskii <eliz@gnu.org>
6891
6892 * doprnt.c (doprnt): Don't return value smaller than the buffer
6893 size if the message was truncated. (Bug#8545).
6894
b124fd93
JB
68952011-04-28 Juanma Barranquero <lekktu@gmail.com>
6896
6897 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6898 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6899
e810457d
PE
69002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6901
6902 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6903
ea51cceb
JB
69042011-04-27 Juanma Barranquero <lekktu@gmail.com>
6905
6906 * makefile.w32-in: Update dependencies.
6907
94dcfacf
EZ
69082011-04-27 Eli Zaretskii <eliz@gnu.org>
6909
6910 Improve `doprnt' and its usage. (Bug#8545)
6911 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6912 `format_end'. Remove support for %l as a conversion specifier.
6913 Don't use xrealloc. Improve diagnostics when the %l size modifier
6914 is used. Update the commentary.
6915
6916 * eval.c (verror): Simplify calculation of size_t.
6917
6918 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6919 messages.
6920
f61f41d7
PE
69212011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6922
6923 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6924 change.
6925
96fb4434
PE
69262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6927
6928 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6929 This makes this file independent of the recent pseudovector change.
6930
671875da 69312011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6932
69e9b5a3
PE
6933 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6934
b5f869a7 6935 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6936 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6937 Remove unused local.
c8926152 6938 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6939
841a1577 6940 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6941 GCC 4.6.0 optimizes based on type-based alias analysis.
6942 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6943 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6944 != &v->size, and therefore "v->size = 1; b->size = 2; return
6945 v->size;" must therefore return 1. This assumption is incorrect
6946 for Emacs, since it type-puns struct Lisp_Vector * with many other
6947 types. To fix this problem, this patch adds a new type struct
f904488f 6948 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6949 and pseudovectors, and helps optimizing compilers not get fooled
6950 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6951 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6952 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6953 the size member.
eab3844f
PE
6954 (XSETPVECTYPE): Rewrite in terms of new macro.
6955 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6956 This is a bit clearer, and further avoids the possibility of
6957 undesirable aliasing.
6958 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6959 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6960 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6961 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6962 (ASIZE): Now uses header.size rather than size.
6963 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6964 to avoid the hassle of writing XVECTOR (foo)->header.size.
6965 (struct vectorlike_header): New type.
eab3844f
PE
6966 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6967 object, to help avoid aliasing.
6968 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6969 (SUBRP): Likewise, since Lisp_Subr is a special case.
6970 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6971 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6972 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6973 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6974 changed to be "header.size" and "header.next".
6975 * buffer.h (struct buffer): Likewise.
6976 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6977 * frame.h (struct frame): Likewise.
6978 * process.h (struct Lisp_Process): Likewise.
6979 * termhooks.h (struct terminal): Likewise.
6980 * window.c (struct save_window_data, struct saved_window): Likewise.
6981 * window.h (struct window): Likewise.
6982 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6983 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6984 * buffer.c (init_buffer_once): Likewise.
6985 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6986 special case.
6987 * process.c (Fformat_network_address): Use local var for size,
6988 for brevity.
6989
0df1eac5
PE
6990 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6991
847ab9d1 6992 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6993 * data.c (atof): Remove decl; no longer used or needed.
6994 (digit_to_number): Move to lread.c.
6995 (Fstring_to_number): Use new string_to_number function, to be
6996 consistent with how the Lisp reader treats infinities and NaNs.
6997 Do not assume that floating-point numbers represent EMACS_INT
6998 without losing information; this is not true on most 64-bit hosts.
6999 Avoid double-rounding errors, by insisting on integers when
7000 parsing non-base-10 numbers, as the documentation specifies.
7001 * lisp.h (string_to_number): New decl, replacing ...
7002 (isfloat_string): Remove.
bc0a5c13 7003 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7004 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7005 appears to have been a coding error. Similarly, do not accept
7006 strings like +-1e0 as floating point numbers. Do not report
7007 overflow for integer overflows unless the base is not 10 which
7008 means we have no simple and reliable way to continue.
7009 Break out the floating-point parsing into a new
7010 function string_to_number, so that Fstring_to_number parses
7011 floating point numbers consistently with the Lisp reader.
04f2d78b 7012 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7013 (E_CHAR, EXP_INT): Remove, replacing with ...
7014 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7015 (string_to_number): New function, replacing isfloat_string.
7016 This function checks for valid syntax and produces the resulting
7017 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7018 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7019 so that overflow for non-base-10 numbers is reported only when
7020 there's no portable and simple way to convert to floating point.
452f4150 7021
67769ffc
PE
7022 * textprop.c (set_text_properties_1): Rewrite for clarity,
7023 and to avoid GCC warning about integer overflow.
7024
c20db43f
PE
7025 * intervals.h (struct interval): Use EMACS_INT for members
7026 where EMACS_UINT might cause problems. See
7027 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7028 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7029 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7030 All uses changed.
37aa2f85
PE
7031 (offset_intervals): Tell GCC not to worry about length overflow
7032 when negating a negative length.
c20db43f 7033
2538aa2f
PE
7034 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7035 (overrun_check_free): Likewise.
7036
f2d3008d
PE
7037 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7038 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7039 word size.
7040
ec8df744
PE
7041 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7042 (gnutls_make_error): Rename local to avoid shadowing.
7043 (gnutls_emacs_global_deinit): ifdef out; not used.
7044 (Fgnutls_boot): Use const for pointer to readonly storage.
7045 Comment out unused local. Fix pointer signedness problems.
7046
640ee02d
PE
7047 * lread.c (openp): Don't stuff size_t into an 'int'.
7048 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7049 about possible signed overflow.
7050
6048fb2a
PE
7051 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7052 (GDK_KEY_g): Don't define if already defined.
7053 (xg_prepare_tooltip): Avoid pointer signedness problem.
7054 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7055
fa3c87e1
PE
7056 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7057 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7058
2172544b
PE
7059 * xfns.c (Fx_window_property): Simplify a bit,
7060 to make a bit faster and to avoid GCC 4.6.0 warning.
7061 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7062
9b821a21
PE
7063 * fns.c (internal_equal): Don't assume size_t fits in int.
7064
3c616cfa
PE
7065 * alloc.c (compact_small_strings): Tighten assertion a little.
7066
c2982e87
PE
7067 Replace pEd with more-general pI, and fix some printf arg casts.
7068 * lisp.h (pI): New macro, generalizing old pEd macro to other
7069 conversion specifiers. For example, use "...%"pI"d..." rather
7070 than "...%"pEd"...".
7071 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7072 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7073 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7074 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7075 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7076 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7077 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7078 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7079 64-bit hosts.
7080 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7081 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7082 * print.c (safe_debug_print, print_object): Likewise.
7083 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7084 to int.
6f04d126
PE
7085 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7086 avoiding the 0 flag, which is not portable.
c2982e87
PE
7087 * process.c (Fmake_network_process): Use pI to avoid cast.
7088 * region-cache.c (pp_cache): Likewise.
7089 * xdisp.c (decode_mode_spec): Likewise.
7090 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7091 behavior on 64-bit hosts with printf arg.
6f04d126 7092 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7093 (x_stop_queuing_selection_requests): Likewise.
7094 (x_get_window_property): Don't truncate byte count to an 'int'
7095 when tracing.
0b432f21 7096
5e073ec7
PE
7097 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7098 here, since it parses constructs like leading '-' and spaces,
7099 which are not wanted; and it overflows with large numbers.
7100 Instead, simply match F[0-9]+, which is what is wanted anyway.
7101
36372bf9
PE
7102 * alloc.c: Remove unportable assumptions about struct layout.
7103 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7104 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7105 (allocate_vectorlike, make_pure_vector): Use the new macros,
7106 plus offsetof, to remove unportable assumptions about struct layout.
7107 These assumptions hold on all porting targets that I know of, but
7108 they are not guaranteed, they're easy to remove, and removing them
7109 makes further changes easier.
7110
0b432f21
PE
7111 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7112 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7113 (string_overrun_cookie): Now const. Use initializers that
7114 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7115 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7116 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7117 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7118 multiple of sizeof (EMACS_INT); it need not be, if
7119 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7120 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7121
895009e1
JB
71222011-04-26 Juanma Barranquero <lekktu@gmail.com>
7123
7124 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7125
6a7a1b0b
TZ
71262011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7127
7128 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7129 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7130 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7131
841a1577 71322011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7133
7134 * lisp.h (Qdebug): List symbol.
895009e1 7135 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7136 * keyboard.c (debug-on-event): New variable.
7137 (handle_user_signal): Break into debugger when debug-on-event
7138 matches the current signal symbol.
7139
f2d3ba6f
DN
71402011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7141
7142 * alloc.c (check_sblock, check_string_bytes)
7143 (check_string_free_list): Convert to standard C.
7144
42ce4c63
TZ
71452011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7146
7147 * w32.c (emacs_gnutls_push): Fix typo.
7148
825cd63c
EZ
71492011-04-25 Eli Zaretskii <eliz@gnu.org>
7150
fb11d64d
EZ
7151 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7152 "cast to pointer from integer of different size".
7153
825cd63c
EZ
7154 Improve doprnt and its use in verror. (Bug#8545)
7155 * doprnt.c (doprnt): Document the set of format control sequences
7156 supported by the function. Use SAFE_ALLOCA instead of always
7157 using `alloca'.
7158
7159 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7160 is one byte too soon. Don't use xrealloc; instead xfree and
7161 xmalloc anew.
7162
e061a11b
TZ
71632011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7164
7165 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7166 callbacks stage.
7167
7168 * gnutls.c: Renamed global_initialized to
7169 gnutls_global_initialized. Added internals for the
7170 :verify-hostname-error, :verify-error, and :verify-flags
7171 parameters of `gnutls-boot' and documented those parameters in the
7172 docstring. Start callback support.
9173deec
JB
7173 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7174 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7175 on error. Return error code.
e061a11b
TZ
7176 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7177 (emacs_gnutls_read): Likewise.
7178 (Fgnutls_boot): Return handshake error code.
7179 (emacs_gnutls_handle_error): New function.
7180 (wsaerror_to_errno): Likewise.
7181
7182 * w32.h (emacs_gnutls_pull): Add prototype.
7183 (emacs_gnutls_push): Likewise.
7184
7185 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7186 (emacs_gnutls_push): Likewise.
7187
71882011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7189
7190 * process.c (wait_reading_process_output): Check if GnuTLS
7191 buffered some data internally if no FDs are set for TLS
7192 connections.
7193
7194 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7195 (LIBS): Link to USER_LIBS.
7196 ($(BLD)/gnutls.$(0)): New target.
7197
fa6996bc
EZ
71982011-04-24 Eli Zaretskii <eliz@gnu.org>
7199
eb35682e
EZ
7200 * xdisp.c (handle_single_display_spec): Rename the
7201 display_replaced_before_p argument into display_replaced_p, to
7202 make it consistent with the commentary. Fix typos in the
7203 commentary.
7204
e2ad650c
EZ
7205 * textprop.c (syms_of_textprop): Remove dead code.
7206 (copy_text_properties): Delete obsolete commentary about an
7207 interface that was deleted long ago. Fix typos in the description
7208 of arguments.
7209
1b2de274
EZ
7210 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7211 to changes in oldXMenu/XMenu.h from 2011-04-16.
7212 <menu_help_message, prev_menu_help_message>: Constify.
7213 (IT_menu_make_room): menu->help_text is now `const char **';
7214 adjust.
7215
7216 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7217 to changes in oldXMenu/XMenu.h from 2011-04-16.
7218 (struct XMenu): Declare `help_text' `const char **'.
7219
7220 * xfaces.c <Qunspecified>: Make extern again.
7221
7222 * syntax.c: Include sys/types.h before including regex.h, as
7223 required by Posix.
7224
762b15be
EZ
7225 * doc.c (get_doc_string): Improve the format passed to `error'.
7226
7227 * doprnt.c (doprnt): Improve commentary.
7228
7229 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7230
7231 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7232 them with etags.
7233
f1052e5d
EZ
7234 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7235 changes in globals.h immediately force recompilation.
762b15be
EZ
7236 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7237 $(CURDIR)/s/ms-w32.h.
7238 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7239
fa6996bc
EZ
7240 * character.c (Fchar_direction): Function deleted.
7241 (syms_of_character): Don't defsubr it.
7242 <char-direction-table>: Deleted.
7243
e6c3da20
EZ
72442011-04-23 Eli Zaretskii <eliz@gnu.org>
7245
7246 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7247 * doprnt.c: Include limits.h.
7248 (SIZE_MAX): New macro.
04f2d78b
CB
7249 (doprnt): Return a size_t value. 2nd arg is now size_t.
7250 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7251 Improve overflow protection. Support `l' modifier for integer
7252 conversions. Support %l conversion. Don't assume an EMACS_INT
7253 argument for integer conversions and for %c.
7254
7255 * lisp.h (doprnt): Restore prototype.
7256
7257 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7258 $(SRC)/character.h.
7259
7260 * Makefile.in (base_obj): Add back doprnt.o.
7261
7262 * deps.mk (doprnt.o): Add back prerequisites.
7263 (callint.o): Depend on character.h.
7264
7265 * eval.c (internal_lisp_condition_case): Include the handler
7266 representation in the error message.
7267 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7268 when breaking from the loop.
7269
7270 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7271
7272 * callint.c (Fcall_interactively): When displaying error message
7273 about invalid control letter, pass the character's codepoint, not
7274 a pointer to its multibyte form. Improve display of the character
7275 in octal and display also its hex code.
7276
7277 * character.c (char_string): Use %x to display the (unsigned)
7278 codepoint of an invalid character, to avoid displaying a bogus
7279 negative value.
7280
7281 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7282 `error', not SYMBOL_NAME itself.
7283
7284 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7285 character arguments to `error'.
7286
7287 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7288 to `error' in error message about FINAL_CHAR argument. Make sure
7289 FINAL_CHAR is a character, and use %c when it is passed as
7290 argument to `error'.
7291
4ffd0d6b 72922011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7293
7294 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7295
7296 * w32.c: Include <time.h>.
7297 (sys_localtime): New function.
7298
4ffd0d6b 72992011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7300
7301 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7302
4ffd0d6b 7303 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7304
4ffd0d6b 73052011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7306
4ffd0d6b
GM
7307 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7308 zombies (Bug#8467).
aac0c6e3 7309
04c56954
EZ
73102011-04-19 Eli Zaretskii <eliz@gnu.org>
7311
7312 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7313 gl_state.e_property when gl_state.object is Qt.
7314
7315 * insdel.c (make_gap_larger): Remove limitation of buffer size
7316 to <= INT_MAX.
7317
16a43933
CY
73182011-04-18 Chong Yidong <cyd@stupidchicken.com>
7319
7320 * xdisp.c (lookup_glyphless_char_display)
7321 (produce_glyphless_glyph): Handle cons cell entry in
7322 glyphless-char-display.
7323 (Vglyphless_char_display): Document it.
7324
7325 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7326 glyphless-char-display.
7327
4581706e
CY
73282011-04-17 Chong Yidong <cyd@stupidchicken.com>
7329
7330 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7331
7332 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7333
7334 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7335 definition for no-X builds.
7336
4887c6e2 73372011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7338
fd35b6f9
PE
7339 Static checks with GCC 4.6.0 and non-default toolkits.
7340
5c1ccb01
PE
7341 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7342
006c5daa
PE
7343 * process.c (keyboard_bit_set): Define only if SIGIO.
7344 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7345 (send_process): Repair possible setjmp clobbering.
7346
efc736d3
PE
7347 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7348
4e2fe2e6
PE
7349 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7350
f97334a2
PE
7351 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7352
4e75f29d
PE
7353 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7354 Define only if needed.
7355
90efadd1
PE
7356 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7357 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7358 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7359
3c647824
PE
7360 * dispextern.h (struct redisplay_interface): Rename param
7361 to avoid shadowing.
e264f262 7362 * termhooks.h (struct terminal): Likewise.
761383f4 7363 * xterm.c (xembed_send_message): Likewise.
3c647824 7364
b58c5c4a
PE
7365 * insdel.c (make_gap_smaller): Define only if
7366 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7367
cad59032
PE
7368 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7369 it.
7370
c339dc2e
PE
7371 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7372 so that we aren't warned about unused symbols.
7373
91a3e27b
PE
7374 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7375
399c71d3 7376 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7377
8ffc96f5
PE
7378 * xfns.c (x_real_positions): Mark locals as initialized.
7379
eef9bc79
PE
7380 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7381
098db9dd
PE
7382 * xterm.c: Fix problems found by static analysis with other toolkits.
7383 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7384 (x_dispatch_event): Declare static if USE_GTK, and
7385 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7386 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7387 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7388 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7389 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7390
eb18f6cc
PE
7391 * xmenu.c (menu_help_callback): Pointer type fixes.
7392 Use const pointers when pointing at readonly data. Avoid pointer
7393 signedness clashes.
7394 (FALSE): Remove unused macro.
7395 (update_frame_menubar): Remove unused decl.
7396
1fe72bf8
PE
7397 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7398
60d9e1db
PE
7399 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7400 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7401 (single_menu_item): Rename local to avoid shadowing.
7402
39261c26
PE
7403 * keyboard.c (make_lispy_event): Remove unused local var.
7404
018c5e19
PE
7405 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7406 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7407
63d2b86e
PE
7408 * bitmaps: Change bitmaps from unsigned char back to the X11
7409 compatible char. Avoid the old compiler warnings about
7410 out-of-range initializers by using, for example, '\xab' rather
7411 than 0xab.
7412
aefd87e1
PE
7413 * xgselect.c (xgselect_initialize): Check vs interface
7414 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7415
bf501fb9
PE
7416 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7417
e9829fdf
PE
7418 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7419 to read-only memory.
7420
1086c095
PE
7421 * fns.c (vector): Remove; this old hack is no longer needed.
7422
2baccd04 7423 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7424 Remove unused var.
dde42981 7425 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7426
72391843 7427 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7428
436c16df 7429 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7430 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7431 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7432
92bb796d 7433 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7434 (x_term_init): Remove local to avoid shadowing.
92bb796d 7435
764430a3 7436 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7437
7438 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7439 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7440
d1dfb56c
EZ
74412011-04-16 Eli Zaretskii <eliz@gnu.org>
7442
c4354cb4
EZ
7443 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7444
d1dfb56c
EZ
7445 Fix regex.c, syntax.c and friends for buffers > 2GB.
7446 * syntax.h (struct gl_state_s): Declare character position members
7447 EMACS_INT.
7448
7449 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7450
04f2d78b
CB
7451 * textprop.c (verify_interval_modification, interval_of):
7452 Declare arguments EMACS_INT.
d1dfb56c
EZ
7453
7454 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7455 EMACS_INT.
7456
7457 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7458
7459 * indent.c (Fvertical_motion): Local variable it_start is now
7460 EMACS_INT.
7461
7462 * regex.c (re_match, re_match_2, re_match_2_internal)
7463 (bcmp_translate, regcomp, regexec, print_double_string)
7464 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7465 (re_compile_pattern, re_exec): Declare arguments and local
7466 variables `size_t' and `ssize_t' and return values `regoff_t', as
7467 appropriate.
7468 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7469 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7470 <compile_stack_type>: `size' and `avail' are now `size_t'.
7471
7472 * regex.h <regoff_t>: Use ssize_t, not int.
7473 (re_search, re_search_2, re_match, re_match_2): Arguments that
7474 specify buffer/string position and length are now ssize_t and
7475 size_t. Return type is regoff_t.
7476
613052cd
BK
74772011-04-16 Ben Key <bkey76@gmail.com>
7478
7479 * nsfont.m: Fixed bugs in ns_get_family and
7480 ns_descriptor_to_entity that were caused by using free to
7481 deallocate memory blocks that were allocated by xmalloc (via
7482 xstrdup). This caused Emacs to crash when compiled with
7483 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7484 --enable-checking=xmallocoverrun). xfree is now used to
7485 deallocate these memory blocks.
7486
4170f62f 74872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7488
71b41406
PE
7489 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7490
9587a89d
PE
7491 emacs_write: Accept and return EMACS_INT for sizes.
7492 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7493 et seq.
7494 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7495 Accept and return EMACS_INT.
7496 (emacs_gnutls_write): Return the number of bytes written on
7497 partial writes.
7498 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7499 (emacs_read, emacs_write): Remove check for negative size, as the
7500 Emacs source code has been audited now.
9587a89d
PE
7501 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7502 (emacs_read, emacs_write): Use it.
273a5f82
PE
7503 * process.c (send_process): Adjust to the new signatures of
7504 emacs_write and emacs_gnutls_write. Do not attempt to store
7505 a byte offset into an 'int'; it might overflow.
9587a89d 7506 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7507
3e047f51
PE
7508 * sound.c: Don't assume sizes fit in 'int'.
7509 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7510 Return EMACS_INT, not int.
3e047f51 7511 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7512 Accept EMACS_INT, not int.
7513 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7514 record read return values.
7515
cc39a9db
BK
75162011-04-15 Ben Key <bkey76@gmail.com>
7517
c9d0ec6d
JB
7518 * keyboard.c (Qundefined): Don't declare static since it is used
7519 in nsfns.m.
7520 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7521 static since they are used in nsfont.m.
cc39a9db 7522
6c60eb9f
SM
75232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7524
7525 * process.c (Qprocessp): Don't declare static.
7526 * lisp.h (Qprocessp): Declare again.
7527
7990b61a
JB
75282011-04-15 Juanma Barranquero <lekktu@gmail.com>
7529
7530 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7531
5d4cb038
PE
75322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7533
8bd7b830 7534 Improve C-level modularity by making more things 'static'.
cd64ea1d 7535
e3b27b31
PE
7536 Don't publish debugger-only interfaces to other modules.
7537 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7538 (verify_bytepos, count_markers): Move decls to the only modules
7539 that need them.
7540 * region-cache.h (pp_cache): Likewise.
7541 * window.h (check_all_windows): Likewise.
7542 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7543
5d4cb038
PE
7544 * sysdep.c (croak): Now static, if
7545 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7546 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7547
7548 * alloc.c (refill_memory_reserve): Now static if
7549 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7550 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7551
e87b6180
PE
7552 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7553 Define only if USE_LUCID.
7554
ac64929e
PE
7555 * xrdb.c (x_customization_string, x_rm_string): Now static.
7556
6f37259d
PE
7557 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7558 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7559
1683e3ab
PE
7560 * xdisp.c (draw_row_with_mouse_face): Now static.
7561 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7562
de9c2632
PE
7563 * window.h (check_all_windows): Mark externally visible.
7564
2b96acb7
PE
7565 * window.c (window_deletion_count): Now static.
7566
7567 * undo.c: Make symbols static if they're not exported.
7568 (last_undo_buffer, last_boundary_position, pending_boundary):
7569 Now static.
7570
50436f33
PE
7571 * textprop.c (interval_insert_behind_hooks): Now static.
7572 (interval_insert_in_front_hooks): Likewise.
7573
64520e5c
PE
7574 * term.c: Make symbols static if they're not exported.
7575 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7576 (max_frame_lines, tty_set_terminal_modes):
7577 (tty_reset_terminal_modes, tty_turn_off_highlight):
7578 (get_tty_terminal): Now static.
7579 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7580 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7581 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7582 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7583 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7584
1fa53021
PE
7585 * sysdep.c: Make symbols static if they're not exported.
7586 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7587 Now static.
7588 (sigprocmask_set, full_mask): Remove; unused.
7589 (wait_debugging): Mark as visible.
7590 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7591 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7592
d4b43b22
PE
7593 * syntax.c (syntax_temp): Define only if !__GNUC__.
7594
b7c513d0
PE
7595 * sound.c (current_sound_device, current_sound): Now static.
7596
989b29ad
PE
7597 * search.c (searchbufs, searchbuf_head): Now static.
7598
13a55a78
PE
7599 * scroll.c (scroll_cost): Remove; unused.
7600 * dispextern.h (scroll_cost): Remove decl.
7601
de68a1fc
PE
7602 * region-cache.h (pp_cache): Mark as externally visible.
7603
40ccffa6
PE
7604 * process.c: Make symbols static if they're not exported.
7605 (process_tick, update_tick, create_process, chan_process):
7606 (Vprocess_alist, proc_buffered_char, datagram_access):
7607 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7608 (deactivate_process): Mark defn as static, as well as decl.
7609 * lisp.h (create_process): Remove decl.
7610 * process.h (chan_process, Vprocess_alist): Remove decls.
7611
ad64fc97
PE
7612 * print.c: Make symbols static if they're not exported.
7613 (print_depth, new_backquote_output, being_printed, print_buffer):
7614 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7615 (print_interval, print_number_index, initial_stderr_stream):
7616 Now static.
7617 * lisp.h (Fprinc): Remove decl.
7618 (debug_output_compilation_hack): Mark as externally visible.
7619
adddb265
PE
7620 * sysdep.c (croak): Move decl from here to syssignal.h.
7621 * syssignal.h (croak): Put it here, so the API can be checked when
7622 'croak' is called from dissociate_if_controlling_tty.
7623
1717ede2
PE
7624 * minibuf.c: Make symbols static if they're not exported.
7625 (minibuf_save_list, choose_minibuf_frame): Now static.
7626 * lisp.h (choose_minibuf_frame): Remove decl.
7627
fa5fb2bc
PE
7628 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7629
1e3890d1
PE
7630 * lread.c: Make symbols static if they're not exported.
7631 (read_objects, initial_obarray, oblookup_last_bucket_number):
7632 Now static.
7633 (make_symbol): Remove; unused.
7634 * lisp.h (initial_obarray, make_symbol): Remove decls.
7635
8a1414fa
PE
7636 * keyboard.c: Make symbols static if they're not exported.
7637 (single_kboard, recent_keys_index, total_keys, recent_keys):
7638 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7639 (this_single_command_key_start, echoing, last_auto_save):
7640 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7641 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7642 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7643 (Vlispy_mouse_stem, double_click_count):
7644 Now static.
7645 (force_auto_save_soon): Define only if SIGDANGER.
7646 (ignore_mouse_drag_p): Now static if
7647 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7648 (print_help): Remove; unused.
7649 (stop_character, last_timer_event): Mark as externally visible.
7650 * keyboard.h (ignore_mouse_drag_p): Declare only if
7651 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7652 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7653 * lisp.h (echoing): Remove decl.
7654 (force_auto_save_soon): Declare only if SIGDANGER.
7655 * xdisp.c (redisplay_window): Simplify code, to make it more
7656 obvious that ignore_mouse_drag_p is not accessed if !defined
7657 USE_GTK && !defined HAVE_NS.
7658
93ea6e8f
PE
7659 * intervals.c: Make symbols static if they're not exported.
7660 (merge_properties_sticky, merge_interval_right, delete_interval):
7661 Now static.
7662 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7663
77382fcc
PE
7664 * insdel.c: Make symbols static if they're not exported.
7665 However, leave prepare_to_modify_buffer alone. It's never
7666 called from outside this function, but that appears to be a bug.
7667 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7668 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7669 (adjust_after_replace_noundo): Remove; unused.
7670 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7671 (signal_before_change): Remove decls.
77382fcc 7672
9306c32e
PE
7673 * indent.c (val_compute_motion, val_vmotion): Now static.
7674
cd44d2eb
PE
7675 * image.c: Make symbols static if they're not exported.
7676 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7677 if USE_GTK.
7678 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7679 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7680
ad9a7a06
PE
7681 * fringe.c (standard_bitmaps): Now static.
7682 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7683
81626931
PE
7684 * frame.c: Make symbols static if they're not exported.
7685 (x_report_frame_params, make_terminal_frame): Now static.
7686 (get_frame_param): Now static, unless HAVE_NS.
7687 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7688 (x_get_resource_string): Remove; not used.
7689 * frame.h (make_terminal_frame, x_report_frame_params):
7690 (x_get_resource_string); Remove decls.
7691 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7692 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7693
239f9db9
PE
7694 * font.c, fontset.c: Make symbols static if they're not exported.
7695 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7696 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7697 * font.c (font_close_object): Now static.
7698 * font.h (font_close_object): Remove.
7699 * fontset.c (FONTSET_OBJLIST): Remove.
7700 (free_realized_fontset) #if-0 the body, which does nothing.
7701 (face_suitable_for_char_p): #if-0, as it's never called.
7702 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7703 * xfaces.c (face_at_string_position):
7704 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7705 since 0 is always ASCII.
7706
dfcf3579
PE
7707 * fns.c (weak_hash_tables): Now static.
7708
5045092b
PE
7709 * fileio.c: Make symbols static if they're not exported.
7710 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7711 (Vwrite_region_annotation_buffers): Now static.
7712
57a96f5c
PE
7713 * eval.c: Make symbols static if they're not exported.
7714 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7715 * lisp.h (backtrace_list): Remove decl.
7716
35f08c38
PE
7717 * emacs.c: Make symbols static if they're not exported.
7718 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7719 (fatal_error_code, fatal_error_signal_hook, standard_args):
7720 Now static.
7721 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7722 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7723 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7724 * lisp.h (fatal_error_signal_hook): Remove decl.
7725 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7726
f44bd759
PE
7727 * editfns.c: Move a (normally-unused) function to its only use.
7728 * editfns.c, lisp.h (get_operating_system_release): Remove.
7729 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7730 worth the hassle of breaking this out.
7731
b532497d
PE
7732 * xterm.c: Make symbols static if they're not exported.
7733 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7734 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7735 (x_destroy_window, x_delete_display):
7736 Now static.
7737 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7738 (x_mouse_leave): Remove; unused.
7739 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7740 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7741 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7742 Remove decls.
7743 (x_mouse_leave): Declare only if WINDOWSNT.
7744 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7745 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7746 USE_X_TOOLKIT.
7747
1675728f
PE
7748 * ftxfont.c: Make symbols static if they're not exported.
7749 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7750 HAVE_FREETYPE.
7751 * font.h (ftxfont_driver): Likewise.
7752
e4cebfca
PE
7753 * xfns.c: Make symbols static if they're not exported.
7754 (x_last_font_name, x_display_info_for_name):
7755 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7756 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7757 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7758 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7759 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7760 (last_show_tip_args): Now static.
7761 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7762 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7763 (x_screen_planes): Remove; unused.
7764 * dispextern.h (x_screen_planes): Remove decl.
7765
5bf46f05
PE
7766 * dispnew.c: Make symbols static if they're not exported.
7767 * dispextern.h (redraw_garbaged_frames, scrolling):
7768 (increment_row_positions): Remove.
7769 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7770 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7771 Now static.
7772 (redraw_garbaged_frames): Remove; unused.
7773
435f4c28
PE
7774 * xfaces.c: Make symbols static if they're not exported.
7775 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7776 Remove decls.
7777 * xterm.h (defined_color): Remove decls.
7778 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7779 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7780 (menu_face_changed_default, defined_color, free_realized_face):
7781 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7782 (ascii_face_of_lisp_face): Remove; unused.
7783
8524aef3
PE
7784 * xdisp.c: Make symbols static if they're not exported.
7785 * dispextern.h (scratch_glyph_row, window_box_edges):
7786 (glyph_to_pixel_coords, set_cursor_from_row):
7787 (get_next_display_element, set_iterator_to_next):
7788 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7789 (show_mouse_face): Remove decls
7790 * frame.h (message_buf_print): Likewise.
7791 * lisp.h (pop_message, set_message, check_point_in_composition):
7792 Likewise.
7793 * xterm.h (set_vertical_scroll_bar): Likewise.
7794 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7795 (message_buf_print, scratch_glyph_row, displayed_buffer):
7796 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7797 (get_next_display_element, show_mouse_face, window_box_edges):
7798 (frame_to_window_pixel_xy, check_point_in_composition):
7799 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7800 (glyph_to_pixel_coords): Remove; unused.
7801
16390cd2
PE
7802 * dired.c (file_name_completion): Now static.
7803
7804 * dbusbind.c (xd_in_read_queued_messages): Now static.
7805
a25f4dfa
PE
7806 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7807 * data.c (circular_list_error): Remove.
7808
14a9c8df
PE
7809 * commands.h (last_point_position, last_point_position_buffer):
7810 (last_point_position_window): Remove decls.
7811 * keyboard.c: Make these variables static.
7812
04f2d78b
CB
7813 * coding.h (coding, code_convert_region, encode_coding_gap):
7814 Remove decls.
74ab6df5
PE
7815 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7816 (iso_code_class, detect_coding, code_convert_region): Now static.
7817 (encode_coding_gap): Remove; unused.
7818
38dfbee1
PE
7819 * chartab.c (chartab_chars, chartab_bits): Now static.
7820
a2cb4e63
PE
7821 * charset.h (charset_iso_8859_1): Remove decl.
7822 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7823 Now static.
7824
127198fd
PE
7825 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7826 * ccl.c (Vccl_program_table): Now static.
7827 (check_ccl_update): Remove; unused.
7828
d85b608f
PE
7829 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7830 * category.h: ... from here.
7831 * category.c (check_category_table, set_category_set): Now static.
7832
31cd66f3
PE
7833 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7834 * lisp.h: Remove these decls.
7835
c358e587
PE
7836 * buffer.c (buffer_count): Remove unused var.
7837
e78aecca
PE
7838 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7839 so that it's not optimized away.
7840 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7841 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7842 exported only to the debugger.
7843
e192d7d3 7844 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7845 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7846
92470028
PE
7847 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7848 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7849 was inaccessible from Lisp.
7850 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7851 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7852
244ed907
PE
7853 alloc.c: Import and export fewer symbols, and remove unused items.
7854 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7855 is defined.
7856 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7857 it's not optimized away by whole-program optimization.
7858 (message_enable_multibyte, free_misc): Remove.
7859 (catchlist, handlerlist, mark_backtrace):
7860 Declare only if BYTE_MARK_STACK.
7861 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7862 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7863 (message_enable_multibyte): Remove decl.
7864 (free_misc, interval_free_list, float_block, float_block_index):
7865 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7866 (cons_free_list, last_marked_index):
7867 Now static.
7868 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7869 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7870 (mark_backtrace): Define only if BYTE_MARK_STACK.
7871 * xdisp.c (message_enable_multibyte): Now static.
7872
61c2b50e 7873 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7874 This makes it easier for human readers (and static analyzers)
7875 to see whether these variables are used from other modules.
7876 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7877 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7878 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7879 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7880 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7881 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7882 * xmenu.c, xselect.c:
7883 Declare Q* vars static if they are not used in other modules.
7884 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7885 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7886 Remove decls of unexported vars.
7887 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7888
95c82688
PE
7889 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7890
16a97296
PE
7891 Make Emacs functions such as Fatom 'static' by default.
7892 This makes it easier for human readers (and static analyzers)
7893 to see whether these functions can be called from other modules.
7894 DEFUN now defines a static function. To make the function external
7895 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7896 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7897 (Finit_image_library):
16a97296
PE
7898 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7899 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7900 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7901 Remove decls, since these functions are now static.
7902 (Funintern, Fget_internal_run_time): New decls, since these functions
7903 were already external.
95c82688 7904
16a97296
PE
7905 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7906 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7907 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7908 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7909 * keyboard.c, keymap.c, lread.c:
7910 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7911 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7912 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7913 Mark functions with DEFUE instead of DEFUN,
7914 if they are used in other modules.
7915 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7916 decls for now-static functions.
7917 * buffer.h (Fdelete_overlay): Remove decl.
7918 * callproc.c (Fgetenv_internal): Mark as internal.
7919 * composite.c (Fremove_list_of_text_properties): Remove decl.
7920 (Fcomposition_get_gstring): New forward static decl.
7921 * composite.h (Fcomposite_get_gstring): Remove decl.
7922 * dired.c (Ffile_attributes): New forward static decl.
7923 * doc.c (Fdocumntation_property): New forward static decl.
7924 * eval.c (Ffetch_bytecode): New forward static decl.
7925 (Funintern): Remove extern decl; now in .h file where it belongs.
7926 * fileio.c (Fmake_symbolic_link): New forward static decl.
7927 * image.c (Finit_image_library): New forward static decl.
7928 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7929 * intervals.h (Fprevious_property_change):
7930 (Fremove_list_of_text_properties): Remove decls.
7931 * keyboard.c (Fthis_command_keys): Remove decl.
7932 (Fcommand_execute): New forward static decl.
7933 * keymap.c (Flookup_key): New forward static decl.
7934 (Fcopy_keymap): Now static.
7935 * keymap.h (Flookup_key): Remove decl.
7936 * process.c (Fget_process): New forward static decl.
7937 (Fprocess_datagram_address): Mark as internal.
7938 * syntax.c (Fsyntax_table_p): New forward static decl.
7939 (skip_chars): Remove duplicate decl.
7940 * textprop.c (Fprevious_property_change): New forward static decl.
7941 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7942 Now internal.
7943 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7944 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7945
785bbd42
PE
7946 * editfns.c (Fformat): Remove unreachable code.
7947
8b913b57
AS
79482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7949
7950 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7951 change. (Bug#8496)
7952
a6744a35
EZ
79532011-04-13 Eli Zaretskii <eliz@gnu.org>
7954
7955 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7956 when at ZV. (Bug#8487)
7957
e7974947
AS
79582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7959
baad03f0
AS
7960 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7961 (Bug#8437)
7962 * keyboard.c (parse_tool_bar_item): Likewise.
7963 * sound.c (sound_cleanup, alsa_close): Likewise.
7964 * termcap.c (tgetent): Likewise.
7965 * xfns.c (x_default_font_parameter): Likewise.
7966 * xsettings.c (read_and_apply_settings): Likewise.
7967
e7974947
AS
7968 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7969 (overrun_check_free): Protoize.
7970
28272684
PE
79712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7972
7973 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7974 since callers should never pass a negative size.
7975 Change the signature to match that of plain 'read' and 'write'; see
7976 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7977 * lisp.h: Update prototypes of emacs_write and emacs_read.
7978
11997c76
EZ
79792011-04-11 Eli Zaretskii <eliz@gnu.org>
7980
7981 * xdisp.c (redisplay_window): Don't try to determine the character
7982 position of the scroll margin if the window start point w->startp
e896f03c 7983 is outside the buffer's accessible region. (Bug#8468)
11997c76 7984
8a2cbd72
EZ
79852011-04-10 Eli Zaretskii <eliz@gnu.org>
7986
7987 Fix write-region and its subroutines for buffers > 2GB.
7988 * fileio.c (a_write, e_write): Modify declaration of arguments and
7989 local variables to support buffers larger than 2GB.
7990 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7991
7992 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7993 argument, local variables, and return value.
7994
7995 * lisp.h: Update prototypes of emacs_write and emacs_read.
7996
7997 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7998
4073e537 79992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8000
1ebfdcb6
PE
8001 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8002
b2ded58d
PE
8003 Fix more problems found by GCC 4.6.0's static checks.
8004
7d66342c
PE
8005 * xdisp.c (vmessage): Use a better test for character truncation.
8006
bbf47d44
PE
8007 * charset.c (load_charset_map): <, not <=, for optimization,
8008 and to avoid potential problems with integer overflow.
9248994d 8009 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8010 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8011 * editfns.c (Fformat): Likewise.
1e69125e 8012 * syntax.c (skip_chars): Likewise.
3befa583 8013
e3019616
PE
8014 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8015 This also lets GCC 4.6.0 generate slightly better loop code.
8016
becfa255
PE
8017 * callint.c (Fcall_interactively): <, not <=, for optimization.
8018 (Fcall_interactively): Count the number of arguments produced,
8019 not the number of arguments given. This is simpler and lets GCC
8020 4.6.0 generate slightly better code.
8021
dae0cd48
PE
8022 * ftfont.c: Distingish more carefully between FcChar8 and char.
8023 The previous code passed unsigned char * to a functions like
8024 strlen and xstrcasecmp that expect char *, which does not
8025 conform to the C standard.
8026 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8027 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8028 char * when the C standard requires it.
8029
76032d70
PE
8030 * keyboard.c (read_char): Remove unused var.
8031
eb3f1cc8
PE
8032 * eval.c: Port to Windows vsnprintf (Bug#8435).
8033 Include <limits.h>.
8034 (SIZE_MAX): Define if the headers do not.
8035 (verror): Do not give up if vsnprintf returns a negative count.
8036 Instead, grow the buffer. This ports to Windows vsnprintf, which
8037 does not conform to C99. Problem reported by Eli Zaretskii.
8038 Also, simplify the allocation scheme, by avoiding the need for
8039 calling realloc, and removing the ALLOCATED variable.
8040
70476b54
PE
8041 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8042
12020a9e
PE
8043 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8044 But keep the doprint source code for now, as we might revamp it
8045 and use it again (Bug#8435).
ea6c7ae6
PE
8046 * lisp.h (doprnt): Remove.
8047 * Makefile.in (base_obj): Remove doprnt.o.
8048 * deps.mk (doprnt.o): Remove.
8049
5fdb398c
PE
8050 error: Print 32- and 64-bit integers portably (Bug#8435).
8051 Without this change, on typical 64-bit hosts error ("...%d...", N)
8052 was used to print both 32- and 64-bit integers N, which relied on
8053 undefined behavior.
61bdb816 8054 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8055 * lisp.h (error, verror): Mark as printf-like functions.
8056 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8057 Report overflow in size calculations when allocating printf buffer.
8058 Do not truncate output string at its first null byte.
8059 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8060 Truncate the output at a character boundary, since vsnprintf does not
8061 do that.
8062 * charset.c (check_iso_charset_parameter): Convert internal
8063 character to string before calling 'error', since %c now has the
8064 printf meaning.
8065 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8066 overflow when computing char to be passed to 'error'. Do not
8067 pass Lisp_Object to 'error'; pass the integer instead.
8068 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8069 formatted with plain %d.
8070
b189fa66
PE
8071 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8072
bff87ef0
PE
8073 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8074
7e2cac20
PE
8075 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8076
ce4d90b5
PE
8077 * xterm.c (x_catch_errors): Remove duplicate declaration.
8078
266c9547
PE
8079 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8080
79c49ad2
PE
8081 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8082
368f4090
JM
80832011-04-10 Jim Meyering <meyering@redhat.com>
8084
8085 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8086 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8087 return ssize_t not "int", and use size_t as the buffer length.
8088 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8089 * gnutls.h: Update declarations.
8090 * process.c (read_process_output): Use ssize_t, to match.
8091 (send_process): Likewise.
8092
a32d4040
CY
80932011-04-09 Chong Yidong <cyd@stupidchicken.com>
8094
8095 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8096
8546720e 80972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8098
04f2d78b
CB
8099 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8100 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8101
8546720e
GM
8102 * xterm.c (handle_one_xevent):
8103 * xmenu.c (create_and_show_popup_menu):
8104 * xselect.c (x_decline_selection_request)
8105 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8106
0a2f5c1a 81072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8108
8109 Fix some uses of `int' instead of EMACS_INT.
8110 * search.c (string_match_1, fast_string_match)
8111 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8112 (scan_buffer, find_next_newline_no_quit)
8113 (find_before_next_newline, search_command, Freplace_match)
8114 (Fmatch_data): Make some `int' variables be EMACS_INT.
8115
8116 * xdisp.c (display_count_lines): 3rd argument and return value now
8117 EMACS_INT. All callers changed.
8118 (pint2hrstr): Last argument is now EMACS_INT.
8119
8120 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8121 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8122 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8123 (decode_coding_utf_16, decode_coding_emacs_mule)
8124 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8125 (decode_coding_ccl, decode_coding_charset)
8126 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8127 (decode_coding_iso_2022, decode_coding_emacs_mule)
8128 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8129 <char_offset, last_offset>: Declare EMACS_INT.
8130 (encode_coding_utf_8, encode_coding_utf_16)
8131 (encode_coding_emacs_mule, encode_invocation_designation)
8132 (encode_designation_at_bol, encode_coding_iso_2022)
8133 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8134 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8135 Declare EMACS_INT.
8136 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8137 (encode_invocation_designation): Last argument P_NCHARS is now
8138 EMACS_INT.
8139 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8140 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8141
8142 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8143 All users changed.
8144
8145 * ccl.c (Fccl_execute_on_string): Declare some variables
8146 EMACS_INT.
8147
8546720e 81482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8149
8150 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8151
4e19a977
CS
81522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8153
8154 * process.c (Fformat_network_address): Doc fix.
8155
87302331
R
81562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8157
ee7683eb 8158 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8159
cbb59342
CY
81602011-04-08 Chong Yidong <cyd@stupidchicken.com>
8161
8162 * keyboard.c (read_char): Call Lisp function help-form-show,
8163 instead of using internal_with_output_to_temp_buffer.
8164 (Qhelp_form_show): New var.
e0d38eeb 8165 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8166
8167 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8168
8169 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8170
e67a13ab
CY
81712011-04-06 Chong Yidong <cyd@stupidchicken.com>
8172
04f2d78b
CB
8173 * process.c (Flist_processes): Remove to Lisp.
8174 (list_processes_1): Delete.
e67a13ab 8175
973f782d
EZ
81762011-04-06 Eli Zaretskii <eliz@gnu.org>
8177
7c106b1e
EZ
8178 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8179
973f782d
EZ
8180 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8181
41cf7d1a 81822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8183
ca23cc88
PE
8184 Fix more problems found by GCC 4.6.0's static checks.
8185
f390e2d5
PE
8186 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8187
42eea0d0
PE
8188 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8189
b69769da 8190 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8191
f9541e84
PE
8192 * xdisp.c (vmessage): Mark as a printf-like function.
8193
13841b55
PE
8194 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8195
c136c10f
PE
8196 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8197
5e2d4a30
PE
8198 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8199 printf-like functions.
8200 (tiff_load): Add casts to remove these marks before passing them
8201 to system-supplied API.
8202
583f48b9
PE
8203 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8204
b25d760e
PE
8205 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8206 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8207 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8208 directly, rather than having caller test rule sign. This avoids
8209 some unnecessary tests.
8210 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8211 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8212 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8213
bc7b6697 8214 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8215 (xfont_open): Avoid unnecessary tests.
bc7b6697 8216
27ccc379
PE
8217 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8218
dcd5c89a
PE
8219 * composite.h, composite.c (composition_gstring_put_cache):
8220 Use EMACS_INT, not int, for length.
8221
b13a45c6
PE
8222 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8223 breaking out part of COMPOSITION_DECODE_RULE.
8224 (COMPOSITION_DECODE_RULE): Use it.
8225 * composite.c (get_composition_id): Remove unused local vars,
8226 by using the new macro.
8227
1e792e4d
PE
8228 * textprop.c (set_text_properties_1): Change while to do-while,
8229 since the condition is always true at first.
8230
dc6c6455 8231 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8232 (interval_deletion_adjustment): Return unsigned value.
8233 All uses changed.
dc6c6455 8234
aba7731a
PE
8235 * process.c (list_processes_1, create_pty, read_process_output):
8236 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8237 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8238 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8239 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8240 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8241
fdfc4bf3
PE
8242 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8243
fca8fe46 8244 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8245 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8246
06a0259a 8247 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8248 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8249 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8250
e7b9e80f
PE
8251 * print.c (print_error_message): Avoid int overflow.
8252
56201685
PE
8253 * font.c (font_list_entities): Redo for clarity,
8254 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8255
78834453 8256 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8257 (font_score): Avoid potential overflow in diff calculation.
78834453 8258
0bc0b309 8259 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8260 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8261
e610eaca
PE
8262 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8263
b895abce
PE
8264 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8265 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8266 can always succeed if overflow has undefined behavior.
8267
1f1d9321 8268 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8269 (wordify): Omit three unnecessary tests.
1f1d9321 8270
c59478bc
PE
8271 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8272 All callers changed. This avoids the need for an unused var.
8273
79b73827
PE
8274 * casefiddle.c (casify_region): Remove var that is set but not used.
8275
a4db5dfe
PE
8276 * dired.c (file_name_completion): Remove var that is set but not used.
8277
43aae36e
PE
8278 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8279
2a47c44d 8280 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8281 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8282
a37c69bf
PE
8283 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8284 Check for integer overflow on size calculations.
8285
328ab8e7
PE
8286 * buffer.c (Fprevious_overlay_change): Remove var that is set
8287 but not used.
8288
e5a2a5cb
PE
8289 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8290 Remove vars that are set but not used.
8d84a6eb 8291 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8292 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8293
a60e5f68
PE
8294 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8295
f661cb61 8296 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8297 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8298
f0397f5a
PE
8299 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8300 that are set but not used.
8301
8664db06 8302 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8303 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8304
6abdaa4a
PE
8305 * xselect.c (x_get_local_selection, x_handle_property_notify):
8306 Remove vars that are set but not used.
8307
0ce7538d 8308 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8309 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8310
9ae848fc
PE
8311 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8312 Remove var that is set but not used.
0b918413
PE
8313 (scroll_bar_windows_size): Now size_t, not int.
8314 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8315 Check for overflow.
9ae848fc 8316
a5a62657
PE
8317 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8318 (map_tty_color) [!defined MSDOS]: Likewise.
8319
5c5cdd39
PE
8320 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8321
66ebf983
PE
8322 * coding.c: Remove vars that are set but not used.
8323 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8324 All callers changed.
8325 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8326 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8327 (decode_coding_charset): Remove vars that are set but not used.
8328
1be4d761
PE
8329 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8330 that is set but not used.
8331
47553fa8
PE
8332 * print.c (print_object): Remove var that is set but not used.
8333
1f7196bf 8334 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8335 The gnulib version avoids calling malloc in the usual case,
8336 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8337 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8338 * filelock.c (current_lock_owner): Likewise.
8339 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8340 * sysdep.c: Include allocator.h, careadlinkat.h.
8341 (emacs_no_realloc_allocator): New static constant.
8342 (emacs_readlink): New function.
fdb61804
PE
8343 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8344 ../lib/careadlinkat.h.
d1fdcab7 8345
f84c17c7
SM
83462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8347
8348 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8349 first non-nil return value).
8350
ef3862ad
JD
83512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8352
8353 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8354 if not defined (Bug#8403).
8355
376a7006
JB
83562011-04-02 Juanma Barranquero <lekktu@gmail.com>
8357
8358 * xdisp.c (display_count_lines): Remove parameter `start',
8359 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8360 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8361 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8362 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8363 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8364 and thereabouts. All callers changed.
8365 (get_per_char_metric): Remove parameter `f', unused since
8366 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8367
6ca3801d
JM
83682011-04-02 Jim Meyering <meyering@redhat.com>
8369
8370 do not dereference NULL upon failed strdup
8371 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8372 (ns_get_family): Likewise.
8373
d8e2b5ba
JB
83742011-04-02 Juanma Barranquero <lekktu@gmail.com>
8375
8376 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8377
8c74fcbd
JD
83782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8379
8380 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8381 later (Bug#8403).
8382
7200d79c
SM
83832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8384
03408648 8385 Add lexical binding.
7200d79c 8386
03408648
SM
8387 * window.c (Ftemp_output_buffer_show): New fun.
8388 (Fsave_window_excursion):
8389 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8390
8391 * lread.c (lisp_file_lexically_bound_p): New function.
8392 (Fload): Bind Qlexical_binding.
8393 (readevalloop): Remove `evalfun' arg.
8394 Bind Qinternal_interpreter_environment.
8395 (Feval_buffer): Bind Qlexical_binding.
8396 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8397 Mark as dynamic.
8398 (syms_of_lread): Declare `lexical-binding'.
8399
8400 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8401
8402 * keyboard.c (eval_dyn): New fun.
8403 (menu_item_eval_property): Use it.
ca105506
SM
8404
8405 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8406
03408648
SM
8407 * fns.c (concat, mapcar1): Accept byte-code-functions.
8408
8409 * eval.c (Fsetq): Handle lexical vars.
8410 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8411 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8412 (FletX, Flet): Obey lexical binding.
8413 (Fcommandp): Handle closures.
8414 (Feval): New `lexical' arg.
8415 (eval_sub): New function extracted from Feval. Use it almost
8416 everywhere where Feval was used. Look up vars in lexical env.
8417 Handle closures.
8418 (Ffunctionp): Move from subr.el.
8419 (Ffuncall): Handle closures.
8420 (apply_lambda): Remove `eval_flags'.
8421 (funcall_lambda): Handle closures and new byte-code-functions.
8422 (Fspecial_variable_p): New function.
8423 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8424 but without exporting it to Lisp.
23aba0ea 8425
23aba0ea 8426 * doc.c (Fdocumentation, store_function_docstring):
03408648 8427 * data.c (Finteractive_form): Handle closures.
23aba0ea 8428
03408648
SM
8429 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8430 interactive spec.
ba83908c 8431
04f2d78b
CB
8432 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8433 New byte-codes.
03408648
SM
8434 (exec_byte_code): New function extracted from Fbyte_code to handle new
8435 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8436
03408648 8437 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8438
03408648 8439 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8440
e2abce01
JB
84412011-03-31 Juanma Barranquero <lekktu@gmail.com>
8442
8443 * xdisp.c (redisplay_internal): Fix prototype.
8444
63696a73 84452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8446
63696a73 8447 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8448 (try_scrolling): Use it when setting scroll_limit.
8449 Limit scrolling to 100 screen lines.
63696a73
EZ
8450 (redisplay_window): Even when falling back on "recentering",
8451 position point in the window according to scroll-conservatively,
8452 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8453
8454 (try_scrolling): When point is above the window, allow searching
8455 as far as scroll_max, or one screenful, to compute vertical
8456 distance from PT to the scroll margin position. This prevents
8457 try_scrolling from unnecessarily failing when
8458 scroll-conservatively is set to a value slightly larger than the
8459 window height. Clean up the case of PT below the margin at bottom
8460 of window: scroll_max can no longer be INT_MAX. When aggressive
8461 scrolling is in use, don't let point enter the opposite scroll
8462 margin as result of the scroll.
8463 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8464 threshold of 100 lines for never-recentering scrolling.
8465
e4cc2dfc
JB
84662011-03-31 Juanma Barranquero <lekktu@gmail.com>
8467
8468 * dispextern.h (move_it_by_lines):
8469 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8470 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8471 (message_log_check_duplicate): Remove parameters `prev_bol' and
8472 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8473 (redisplay_internal): Remove parameter `preserve_echo_area',
8474 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8475
8476 * indent.c (Fvertical_motion):
8477 * window.c (window_scroll_pixel_based, Frecenter):
8478 Don't pass `need_y_p' to `move_it_by_lines'.
8479
1c470562
SM
84802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8481
44f230aa
SM
8482 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8483 steal a few bits to be more compact.
8484 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8485 Remove unneeded casts.
8486
1c470562
SM
8487 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8488
888adce9
ZK
84892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8490
8491 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8492 binding" message (bug#7967).
8493
f838ed7b
PE
84942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8495
77861b95
PE
8496 Fix more problems found by GCC 4.6.0's static checks.
8497
de6dbc14
PE
8498 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8499 Remove unused local var.
8500
f838ed7b
PE
8501 * editfns.c (Fmessage_box): Remove unused local var.
8502
792c7b2b
PE
8503 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8504 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8505 Omit unused local vars.
c499e557 8506 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8507 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8508 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8509 Omit unused local var.
8510
ba0165e1
PE
8511 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8512 Don't assume string length fits in int.
32ad8845 8513 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8514 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8515
3c59b4c9
PE
8516 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8517 instead of alloca (Bug#8344).
8518
a3eed478 8519 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8520 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8521
eb4d412d
PE
8522 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8523
1658b401
PE
8524 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8525 concerns.
8526
8527 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8528
8529 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8530
9a2c6e05
PE
8531 * keyboard.c (syms_of_keyboard): Use the same style as later
8532 in this function when indexing through an array. This also
8533 works around GCC bug 48267.
8534
03d0a109
PE
8535 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8536
44f730c8
PE
8537 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8538
fe75f926
PE
8539 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8540 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8541
ffa8c828
PE
8542 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8543 This avoids undefined behavior on integer overflow, and is a bit
8544 more convenient anyway since it is compared to a size_t variable.
8545
c5101a77
PE
8546 Variadic C functions now count arguments with size_t, not int.
8547 This avoids an unnecessary limitation on 64-bit machines, which
8548 caused (substring ...) to crash on large vectors (Bug#8344).
8549 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8550 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8551 All variadic functions and their callers changed accordingly.
c5101a77
PE
8552 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8553 * data.c (arith_driver, float_arith_driver): Likewise.
8554 * editfns.c (general_insert_function): Likewise.
8555 * eval.c (struct backtrace.nargs, interactive_p)
8556 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8557 (funcall_lambda, mark_backtrace): Likewise.
8558 * fns.c (concat): Likewise.
8559 * frame.c (x_set_frame_parameters): Likewise.
8560 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8561 0 if not found, not -1. All callers changed.
8562
dd3f25f7
PE
8563 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8564 (stack_copy_size): Now size_t, not int.
8565 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8566
461c2ab9
JB
85672011-03-28 Juanma Barranquero <lekktu@gmail.com>
8568
8569 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8570 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8571 All callers changed.
8572
8573 * lisp.h (multibyte_char_to_unibyte):
8574 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8575 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8576 * character.h (CHAR_TO_BYTE8):
8577 * cmds.c (internal_self_insert):
8578 * editfns.c (general_insert_function):
8579 * keymap.c (push_key_description):
8580 * search.c (Freplace_match):
8581 * xdisp.c (message_dolog, set_message_1): All callers changed.
8582
f6d62986
SM
85832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8584
8585 * keyboard.c (safe_run_hook_funcall): New function.
8586 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8587 don't set the hook to nil, but remove the offending function instead.
8588 (Qcommand_hook_internal): Remove, unused.
8589 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8590 Vcommand_hook_internal.
8591
8592 * eval.c (enum run_hooks_condition): Remove.
8593 (funcall_nil, funcall_not): New functions.
8594 (run_hook_with_args): Call each function through a `funcall' argument.
8595 Remove `cond' argument, now redundant.
8596 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8597 (Frun_hook_with_args_until_failure): Adjust accordingly.
8598 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8599
1db5b1ad
JB
86002011-03-28 Juanma Barranquero <lekktu@gmail.com>
8601
8602 * dispextern.h (string_buffer_position): Remove declaration.
8603
8604 * print.c (strout): Remove parameter `multibyte', unused since
8605 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8606
8607 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8608 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8609 All callers changed.
8610
8611 * w32.c (_wsa_errlist): Use braces for struct initializers.
8612
8613 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8614 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8615 All callers changed.
8616 (string_buffer_position): Likewise. Also, make static (it's never
8617 used outside xdisp.c).
8618 (cursor_row_p): Remove parameter `w', unused since
8619 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8620 (decode_mode_spec): Remove parameter `precision', introduced during
8621 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8622 All callers changed.
8623
5ffb62aa
JD
86242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8625
8626 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8627
461c2ab9 86282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8629
8630 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8631 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8632 (ns_update_auto_hide_menu_bar): New functions.
8633 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8634 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8635 ns_constrain_all_frames.
8636 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8637 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8638
5c380ffb
JD
86392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8640
8641 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8642
9af30bdf
GM
86432011-03-27 Glenn Morris <rgm@gnu.org>
8644
8645 * syssignal.h: Replace RETSIGTYPE with void.
8646 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8647 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8648 Replace SIGTYPE with void everywhere.
8649 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8650 * s/template.h (SIGTYPE): Remove commented out definition.
8651
e2abce01
JB
86522011-03-26 Eli Zaretskii <eliz@gnu.org>
8653
8654 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8655 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8656
f868cd8a
JB
86572011-03-26 Juanma Barranquero <lekktu@gmail.com>
8658
59eb0929
JB
8659 * w32.c (read_unc_volume): Use parameter `henum', instead of
8660 global variable `wget_enum_handle'.
8661
8662 * keymap.c (describe_vector): Remove parameters `indices' and
8663 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8664 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8665
f868cd8a
JB
8666 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8667
8668 * keyboard.c (timer_check): Remove parameter `do_it_now',
8669 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8670 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8671 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8672
8673 * keyboard.c (read_char):
8674 * w32menu.c (w32_menu_display_help):
8675 * xmenu.c (show_help_event, menu_help_callback):
8676 Adjust calls to `show_help_echo'.
8677
8678 * gtkutil.c (xg_maybe_add_timer):
8679 * keyboard.c (readable_events):
8680 * process.c (wait_reading_process_output):
8681 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8682
8683 * insdel.c (adjust_markers_gap_motion):
8684 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8685 (gap_left, gap_right): Don't call it.
8686
2ecf6fdb
CY
86872011-03-25 Chong Yidong <cyd@stupidchicken.com>
8688
8689 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8690 incurred during fontification.
8691
6b1f9ba4
JB
86922011-03-25 Juanma Barranquero <lekktu@gmail.com>
8693
8694 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8695 (DEFVAR_PER_BUFFER): Don't pass it.
8696
8697 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8698 (scrolling_window): Don't pass it.
8699
0f4a96b5
JB
87002011-03-25 Juanma Barranquero <lekktu@gmail.com>
8701
8702 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8703
8704 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8705 and `suffix'.
8706 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8707 of variables specific to SELinux and computation of `encoded_absname'.
8708
8709 * image.c (XPutPixel): Remove unused variable `height'.
8710
8711 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8712
8713 * unexw32.c (get_section_info): Remove unused variable `section'.
8714
8715 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8716 (system_process_attributes): Remove unused variable `sess'.
8717 (sys_read): Remove unused variable `err'.
8718
8719 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8720 (w32_wnd_proc): Remove unused variable `isdead'.
8721 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8722 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8723 (x_create_tip_frame): Remove unused variable `tem'.
8724
8725 * w32inevt.c (w32_console_read_socket):
8726 Remove unused variable `no_events'.
8727
8728 * w32term.c (x_draw_composite_glyph_string_foreground):
8729 Remove unused variable `width'.
8730
1149507c
JB
87312011-03-24 Juanma Barranquero <lekktu@gmail.com>
8732
8733 * w32term.c (x_set_glyph_string_clipping):
8734 Don't pass uninitialized region to CombineRgn.
8735
9c88f339
JB
87362011-03-23 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8739 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8740 (Fx_close_connection): Remove unused variable `i'.
8741
8742 * w32font.c (w32font_draw): Return number of glyphs.
8743 (w32font_open_internal): Remove unused variable `i'.
8744 (w32font_driver): Add missing initializer.
8745
8746 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8747 (fill_in_menu): Remove unused variable `items_added'.
8748
8749 * w32term.c (last_mouse_press_frame): Remove static global variable.
8750 (w32_clip_to_row): Remove unused variable `f'.
8751 (x_delete_terminal): Remove unused variable `i'.
8752
8753 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8754 (NOTHING): Remove unused static global variable.
8755 (uniscribe_check_otf): Remove unused variable `table'.
8756 (uniscribe_font_driver): Add missing initializers.
8757
dee091a3
JD
87582011-03-23 Julien Danjou <julien@danjou.info>
8759
8760 * term.c (Fsuspend_tty, Fresume_tty):
8761 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8762 * window.c (temp_output_buffer_show):
8763 * insdel.c (signal_before_change):
8764 * frame.c (Fhandle_switch_frame):
8765 * fileio.c (Fdo_auto_save):
8766 * emacs.c (Fkill_emacs):
8767 * editfns.c (save_excursion_restore):
8768 * cmds.c (internal_self_insert):
8769 * callint.c (Fcall_interactively):
8770 * buffer.c (Fkill_all_local_variables):
8771 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8772 Use Frun_hooks.
0f4a96b5 8773 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8774 unconditionally since it does the check itself.
dee091a3 8775
2c520ab5 87762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8777
c9c49752
PE
8778 Fix more problems found by GCC 4.5.2's static checks.
8779
8abc3f12
PE
8780 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8781 the first time through the loop, since we know p0 < p1 then.
8782 This also avoids a gcc -Wstrict-overflow warning.
8783
a2d26660
PE
8784 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8785 leading to a memory leak, possible in functions like
8786 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8787 of objects (Bug#8318).
a2d26660 8788
916c72e9
PE
8789 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8790 that could (at least in theory) be that large.
8791
19ab8a18
PE
8792 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8793 This is less likely to overflow, and avoids undefined behavior if
8794 overflow does occur. All callers changed. Use strtoul to scan
8795 for the unsigned long integer.
b7cbbd6f
PE
8796 (pint2hrstr): Simplify and tune code slightly.
8797 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8798
f0641eff
PE
8799 * scroll.c (do_scrolling): Work around GCC bug 48228.
8800 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8801
7f650bb9
PE
8802 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8803 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8804 (validate_x_resource_name): Simplify count usage.
8805 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8806
37dd57d1
PE
8807 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8808 fail (Bug#8306).
81e56e61 8809
699979fc 8810 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8811
401bf9b4
PE
8812 * process.c (Fmake_network_process): Use socklen_t, not int,
8813 where POSIX says socklen_t is required in portable programs.
8814 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8815 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8816 (Fmake_network_process, server_accept_connection):
8817 (wait_reading_process_output, read_process_output):
8818 Likewise.
8819
b93aacde
PE
8820 * process.c: Rename or move locals to avoid shadowing.
8821 (list_processes_1, Fmake_network_process):
8822 (read_process_output_error_handler, exec_sentinel_error_handler):
8823 Rename or move locals.
4dc343ee 8824 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8825 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8826 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8827 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8828 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8829
af8a867c 8830 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8831 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8832 Include tparam.h instead, since it declares them.
af8a867c
PE
8833 * cm.h (PC): Remove extern decl; tparam.h now does this.
8834 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8835 * terminfo.c: Include tparam.h, to check interfaces.
8836 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8837 (tparam): Adjust signature to match interface in tparam.h;
8838 this removes some undefined behavior. Check that outstring and len
8839 are zero, which they always are with Emacs.
8840 * tparam.h (PC, BC, UP): New extern decls.
8841
0248044d 8842 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8843 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8844
8ff096c1 8845 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8846 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8847 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8848 (ftfont_list): Remove unused local.
49eaafba
PE
8849 (get_adstyle_property, ftfont_pattern_entity):
8850 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8851 Rename locals to avoid shadowing.
8ff096c1 8852
e2be39f6
PE
8853 * xfont.c (xfont_list_family): Mark var as initialized.
8854
c9735e30
PE
8855 * xml.c (make_dom): Now static.
8856
8f5201ae
PE
8857 * composite.c (composition_compute_stop_pos): Rename local to
8858 avoid shadowing.
b246f932
PE
8859 (composition_reseat_it): Remove unused locals.
8860 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8861 (composition_update_it): Mark var as initialized.
11b61122
PE
8862 (find_automatic_composition): Mark vars as initialized,
8863 with a FIXME (Bug#8290).
8f5201ae 8864
760fbc2c
PE
8865 character.h: Rename locals to avoid shadowing.
8866 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8867 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8868 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8869 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8870 to avoid shadowing.
8871
ff08eb85
PE
8872 * textprop.c (property_change_between_p): Remove; unused.
8873
fc7bf025
PE
8874 * intervals.c (interval_start_pos): Now static.
8875
235d7abc
PE
8876 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8877
44f230aa
SM
8878 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8879 Rename locals to avoid shadowing.
3e7d6594 8880
50060332
PE
8881 * sound.c (wav_play, au_play, Fplay_sound_internal):
8882 Fix pointer signedness.
d01f234b 8883 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8884 (wav_play): Initialize a variable to 0, to prevent undefined
8885 behavior (Bug#8278).
50060332 8886
c4fc4e30
PE
8887 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8888
918436ed
PE
8889 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8890
c939f91b
PE
8891 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8892 clobbering (Bug#8298).
b9c7f648
PE
8893 * sysdep.c (sys_subshell): Likewise.
8894 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8895
6bd8c144
PE
8896 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8897 This should get cleaned up, so that child_setup has the
8898 same signature on all platforms.
8899
7710357c 8900 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8901 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8902
c59da222
CY
89032011-03-22 Chong Yidong <cyd@stupidchicken.com>
8904
8905 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8906 not to be necessary, and produces flickering.
8907
66b87493
GM
89082011-03-20 Glenn Morris <rgm@gnu.org>
8909
8910 * config.in: Remove file.
8911
45b6f6d5
JB
89122011-03-20 Juanma Barranquero <lekktu@gmail.com>
8913
8914 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8915 are now in src/globals.h.
8916 (syms_of_minibuf): Remove spurious & from previous change.
8917
cd394be1 89182011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8919
8920 * minibuf.c (completing-read-function): New variable.
8921 (completing-read-default): Rename from completing-read.
8922 (completing-read): Call completing-read-function.
8923
b14e3e21
CY
89242011-03-19 Juanma Barranquero <lekktu@gmail.com>
8925
8926 * xfaces.c (Fx_load_color_file):
8927 Read color file from absolute filename (bug#8250).
8928
f2b726e6
JB
89292011-03-19 Juanma Barranquero <lekktu@gmail.com>
8930
8931 * makefile.w32-in: Update dependencies.
8932
09f6ff02
EZ
89332011-03-17 Eli Zaretskii <eliz@gnu.org>
8934
8935 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8936
29a6015a
PE
89372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8938
a3a6c54e
PE
8939 Fix more problems found by GCC 4.5.2's static checks.
8940
b766f867
PE
8941 * process.c (make_serial_process_unwind, send_process_trap):
8942 (sigchld_handler): Now static.
8943
be02381c
PE
8944 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8945 That way, the code declares only the vars that it needs.
8946 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8947 * s/cygwin.h (PTY_ITERATION): Likewise.
8948 * s/darwin.h (PTY_ITERATION): Likewise.
8949 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8950
57048744
PE
8951 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8952 * process.c (allocate_pty): Don't declare stb unless it's needed.
8953
7914961c 8954 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8955 (CONSTANTLIM): Remove; unused.
8956 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8957 Define only if needed.
7914961c 8958
b3967b18
PE
8959 * unexelf.c (unexec): Name an expression,
8960 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8961 Use a different way to cause a compilation error if anyone uses
8962 n rather than nn, a way that does not involve shadowing.
73366a00 8963 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8964
29a6015a
PE
8965 * deps.mk (unexalpha.o): Remove; unused.
8966
43cfc33e 8967 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8968 * unexec.h: New file.
ce701a33
PE
8969 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8970 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8971 Depend on unexec.h.
8972 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8973 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8974 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8975 Change as necessary to match prototype in unexec.h.
ce701a33 8976
01f44d5a
PE
8977 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8978 shadowing.
4f63c6bb 8979 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8980
a6670b0b
PE
8981 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8982 Rename locals to avoid shadowing.
8983
cef2010d 8984 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8985 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8986
d4d7173a
PE
8987 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8988
f08b802a
PE
8989 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8990 warning when compiling print.c.
8991
3ddb0639
PE
8992 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8993 instead of using an uninitialized var.
5ad03b97 8994 (font_sort_entities): Mark var as initialized.
3ddb0639 8995
170a2692
PE
8996 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8997
e663c700
PE
8998 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8999 pointers to constants.
89bc529a 9000 (font_parse_fcname): Remove unused vars.
7b81e2d0 9001 (font_delete_unmatched): Now static.
ea838e10 9002 (font_get_spec): Remove; unused.
13a547c6
PE
9003 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9004 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9005 Rename or move locals to avoid shadowing.
e663c700 9006
2a80c887 9007 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9008 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9009
1384fa33 9010 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9011 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9012
8b2c52e9
PE
9013 * alloc.c (mark_backtrace): Move decl from here ...
9014 * lisp.h: ... to here, so that it can be checked.
9015
475545b5 9016 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9017 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9018 (lisp_indirect_variable): Name an expression,
9019 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9020 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9021
b1349114 9022 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9023 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9024 Use const pointer when appropriate.
b1349114 9025
a2928364
PE
9026 * lisp.h (get_system_name, get_operating_system_release):
9027 Move decls here, to check interfaces.
9028 * process.c (get_operating_system_release): Move decl to lisp.h.
9029 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9030 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9031 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9032 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9033 (Fformat_time_string, Fencode_time, Finsert_char):
9034 (Ftranslate_region_internal, Fformat):
9035 Rename or remove local vars to avoid shadowing.
9710023e 9036 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9037
a415e694
PE
9038 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9039 avoid shadowing.
9040
8ef4622d
PE
9041 * lisp.h (eassert): Check that the argument compiles, even if
9042 ENABLE_CHECKING is not defined.
9043
946f9a5b
PE
9044 * data.c (Findirect_variable): Name an expression, to avoid
9045 gcc -Wbad-function-cast warning.
112396d6 9046 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9047 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9048 (Fmake_variable_buffer_local, Fmake_local_variable):
9049 Mark variables as initialized.
52746918 9050 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9051
e5aab7e7 9052 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9053 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9054 Rename locals to avoid shadowing.
dff45157
PE
9055 (mark_stack): Move local variables into the #ifdef region where
9056 they're used.
7bc26fdb
PE
9057 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9058 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9059 needed otherwise.
9060 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9061 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9062 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9063
e5aab7e7
PE
9064 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9065 avoids undefined behavior in theory.
9066
4da60324
PE
9067 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9068
88043301
PE
9069 Use functions, not macros, for up- and down-casing (Bug#8254).
9070 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9071 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9072 to use the following functions instead of these macros.
9073 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9074 EMACS_INT, since callers assume the returned value fits in int.
9075 (upcase1): Likewise, for UPCASE_TABLE.
9076 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9077 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9078 the race-condition problem in the old DOWNCASE.
88043301 9079
19ed5445
PE
9080 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9081 Rename locals to avoid shadowing.
9082 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9083 (regex_compile, re_search_2, re_match_2_internal):
9084 Remove unused local vars.
952db0d7
PE
9085 (FREE_VAR): Rewrite so as not to use empty "else",
9086 which gcc can warn about.
da053e48 9087 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9088 (RETALLOC_IF): Define only if needed.
9089 (WORDCHAR_P): Likewise. This one is never needed, but is used
9090 only in a comment talking about a compiler bug, so put inside
9091 the #if 0 of that comment.
9092 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9093 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9094 Remove; unused.
19ed5445 9095
1f3561e4 9096 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9097 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9098 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9099
ded6f8f7
PE
9100 * search.c (simple_search): Remove unused var.
9101
dbd37a95
PE
9102 * dired.c (compile_pattern): Move decl from here ...
9103 * lisp.h: ... to here, so that it can be checked.
9104 (struct re_registers): New forward decl.
9105
7e47afad
PE
9106 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9107
85f24f61
PE
9108 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9109 All uses changed.
9110 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9111 Rename locals to avoid shadowing.
5671df8f 9112 (Fvertical_motion): Mark locals as initialized.
85f24f61 9113
181aa2be 9114 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9115 (casify_region): Mark local as initialized.
181aa2be 9116
930d429c
PE
9117 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9118
7082eac6
PE
9119 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9120 New macros, so that the caller can use some names other than
9121 gcpro1, gcpro2, etc.
9122 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9123 of the new macros.
9124 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9125 argument, for consistency with GCPRO2_VAR, etc: it is now the
9126 prefix of the variable, not the variable itself. All uses
9127 changed.
38b2c076
PE
9128 * dired.c (directory_files_internal, file_name_completion):
9129 Rename locals to avoid shadowing.
9130
15206ed9
PE
9131 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9132 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9133 dired.c's scmp function, had undefined behavior.
9134 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9135 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9136 * buffer.h: ... to here, because these macros use current_buffer,
9137 and the new implementation with inline functions needs to have
9138 current_buffer in scope now, rather than later when the macros
9139 are used.
9140 (downcase, upcase1): New static inline functions.
9141 (DOWNCASE, UPCASE1): Reimplement using these functions.
9142 This avoids undefined behavior in expressions like
9143 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9144 from race conditions in accessing the global variables
9145 case_temp1 and case_temp2.
9146 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9147 * lisp.h (case_temp1, case_temp2): Remove their decls.
9148 * character.h (ASCII_CHAR_P): Move from here ...
9149 * lisp.h: ... to here, so that the inline functions mentioned
9150 above can use them.
9151
4a6bea26
PE
9152 * dired.c (directory_files_internal_unwind): Now static.
9153
f14b7e14
PE
9154 * fileio.c (file_name_as_directory, directory_file_name):
9155 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9156 Now static.
2893f146
PE
9157 (file_name_as_directory): Use const pointers when appropriate.
9158 (Fexpand_file_name): Likewise. In particular, newdir might
9159 point at constant storage, so make it a const pointer.
fd4ead52 9160 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9161 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9162 signedness issues.
f839df0c
PE
9163 (Fset_file_times, Finsert_file_contents, auto_save_error):
9164 Rename locals to avoid shadowing.
f14b7e14 9165
5716756e 9166 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9167 (Ftry_completion, Fall_completions): Rename or remove locals
9168 to avoid shadowing.
5716756e 9169
b4c3046a
PE
9170 * marker.c (bytepos_to_charpos): Remove; unused.
9171
b45db522
PE
9172 * lisp.h (verify_bytepos, count_markers): New decls,
9173 so that gcc does not warn that these functions aren't declared.
9174
85876d07
PE
9175 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9176 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9177 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9178 (copy_text): Remove unused local var.
85876d07 9179
03d78a21 9180 * filelock.c (within_one_second): Now static.
b3dd38ab 9181 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9182
5df8f01b
PE
9183 * buffer.c (fix_overlays_before): Mark locals as initialized.
9184 (fix_start_end_in_overlays): Likewise. This function should be
9185 simplified by using pointers-to-pointers, but that's a different
9186 matter.
b1d876f1 9187 (switch_to_buffer_1): Now static.
8f54f30a
PE
9188 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9189 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9190
a70072c9 9191 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9192 Fix pointer signedness issue.
edced198
PE
9193 (sys_subshell): Mark local as volatile if checking for lint,
9194 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9195 (MAXPATHLEN): Define only if needed.
a70072c9 9196
a0977c44
PE
9197 * process.c (serial_open, serial_configure): Move decls from here ...
9198 * systty.h: ... to here, so that they can be checked.
9199
a884fdcc
PE
9200 * fns.c (get_random, seed_random): Move extern decls from here ...
9201 * lisp.h: ... to here, so that they can be checked.
9202
604efe86 9203 * sysdep.c (reset_io): Now static.
b8950c94 9204 (wait_for_termination_signal): Remove; unused.
604efe86 9205
38fc62d9
PE
9206 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9207 (copy_keymap_item, append_key, push_text_char_description):
9208 Now static.
1004a21a 9209 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9210 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9211 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9212 (describe_map_tree):
9213 Rename locals to avoid shadowing.
38fc62d9 9214
2f2650da
PE
9215 * keyboard.c: Declare functions static if they are not used elsewhere.
9216 (echo_char, echo_dash, cmd_error, top_level_2):
9217 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9218 (read_char, kbd_buffer_get_event, make_lispy_position):
9219 (make_lispy_event, make_lispy_movement, apply_modifiers):
9220 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9221 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9222 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9223 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9224 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9225
a053e86c 9226 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9227 (mark_kboards): Move decl here ...
9228 * alloc.c (mark_kboards): ... from here.
a053e86c 9229
4752793e
PE
9230 * lisp.h (force_auto_save_soon): New decl.
9231
74f10ca7 9232 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9233 (DEFINE_DUMMY_FUNCTION): New macro.
9234 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9235 Use it.
c03cd23f
PE
9236 (main): Add casts to avoid warnings
9237 if GCC considers string literals to be constants.
74f10ca7 9238
022e70d4
PE
9239 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9240
59d6fe83
PE
9241 * dbusbind.c: Pointer signedness fixes.
9242 (xd_signature, xd_append_arg, xd_initialize):
9243 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9244 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9245 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9246 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9247
78320123
PE
9248 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9249 if GCC considers string literals to be constants.
49cebcca 9250 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9251
35ac2a97
SM
92522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9253
fb103ca9
SM
9254 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9255 (print_preprocess, print_object): New macro to fix last change.
9256
35ac2a97
SM
9257 * print.c (print_preprocess): Don't forget font objects.
9258
62973b41
JB
92592011-03-16 Juanma Barranquero <lekktu@gmail.com>
9260
9261 * emacs.c (USAGE3): Doc fixes.
9262
0e48bb22
AS
92632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9264
9265 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9266 structure.
9267
7684e57b
JB
92682011-03-14 Juanma Barranquero <lekktu@gmail.com>
9269
9270 * lisp.h (VWindow_system, Qfile_name_history):
9271 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9272 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9273 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9274
9275 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9276 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9277
9278 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9279 * w32console.c (detect_input_pending, read_input_pending)
9280 (encode_terminal_code):
9281 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9282 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9283 (w32_system_caret_y, Qfile_name_history):
9284 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9285 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9286 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9287 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9288 * w32proc.c (Qlocal, report_file_error):
9289 * w32term.c (Vwindow_system, updating_frame):
9290 * w32uniscribe.c (initialized, uniscribe_font_driver):
9291 Remove unneeded extern declarations.
9292
2aa46d6c
CY
92932011-03-14 Chong Yidong <cyd@stupidchicken.com>
9294
c96bbc66 9295 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9296
cffc6f3b
CY
92972011-03-13 Chong Yidong <cyd@stupidchicken.com>
9298
9299 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9300 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9301 These macros can no longer be used for assignment.
9302
44f230aa
SM
9303 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9304 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9305 (record_buffer_markers, fetch_buffer_markers): New functions for
9306 recording and fetching special buffer markers.
9307 (set_buffer_internal_1, set_buffer_temp): Use them.
9308
9309 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9310
9311 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9312
9313 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9314 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9315
9316 * xdisp.c (hscroll_window_tree):
9317 (reconsider_clip_changes): Use PT instead of BUF_PT.
9318
d251f04b
EZ
93192011-03-13 Eli Zaretskii <eliz@gnu.org>
9320
9321 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9322 $(EMACS_ROOT)/lib/intprops.h.
9323
f0c77cd1
PE
93242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9325
3eca4629
PE
9326 Fix more problems found by GCC 4.5.2's static checks.
9327
7c86ee98
PE
9328 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9329 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9330 (xg_free_frame_widgets): Make it clear that a local variable is
9331 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9332 (gdk_window_get_screen): Make it clear that this macro is needed
9333 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9334 (int_gtk_range_get_value): New function, which avoids a diagnostic
9335 from gcc -Wbad-function-cast.
9336 (xg_set_toolkit_scroll_bar_thumb): Use it.
9337 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9338 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9339 (get_utf8_string, xg_get_file_with_chooser):
9340 Rename locals to avoid shadowing.
9341 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9342
41729b81
PE
9343 * xgselect.c (xg_select): Remove unused var.
9344
f0c77cd1
PE
9345 * image.c (four_corners_best): Mark locals as initialized.
9346 (gif_load): Initialize transparent_p to zero (Bug#8238).
9347 Mark another local as initialized.
ec6cf4c6 9348 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9349
ce0ad53d 9350 * image.c (clear_image_cache): Now static.
d5d5a617 9351 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9352 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9353 (x_edge_detection): Remove unnecessary cast that
9354 gcc -Wbad-function-cast diagnoses.
2037898d 9355 (gif_load): Fix pointer signedness.
6ae141d6
PE
9356 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9357 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9358
33383987 93592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9360
d32df629
PE
9361 Improve quality of tests for time stamp overflow.
9362 For example, without this patch (encode-time 0 0 0 1 1
9363 1152921504606846976) returns the obviously-bogus value (-948597
9364 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9365 reports time overflow. See
9366 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9367 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9368 * editfns.c: Include limits.h and intprops.h.
9369 (TIME_T_MIN, TIME_T_MAX): New macros.
9370 (time_overflow): Move earlier, to before first use.
9371 (hi_time, lo_time): New functions, for an accurate test for
9372 out-of-range times.
9373 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9374 (Fget_internal_run_time): Don't assume time_t fits in int.
9375 (make_time): Use list2 instead of Fcons twice.
9376 (Fdecode_time): More accurate test for out-of-range times.
9377 (check_tm_member): New function.
9378 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9379 (lisp_time_argument): Don't rely on undefined left-shift and
9380 right-shift behavior when checking for time stamp overflow.
8be6f318 9381
fe31d94c
PE
9382 * editfns.c (time_overflow): New function, refactoring common code.
9383 (Fformat_time_string, Fdecode_time, Fencode_time):
9384 (Fcurrent_time_string): Use it.
9385
8be6f318
PE
9386 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9387 * dired.c (make_time): Move to ...
9388 * editfns.c (make_time): ... here.
9389 * systime.h: Note the move.
9390
09d9db2c 93912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9392
126bc0dc
YM
9393 * fringe.c (update_window_fringes): Remove unused variables.
9394
c47cbdfd
YM
9395 * unexmacosx.c (copy_data_segment): Also copy __got section.
9396 (Bug#8223)
9397
7ac80be9
EZ
93982011-03-12 Eli Zaretskii <eliz@gnu.org>
9399
c96bbc66 9400 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9401 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9402 Constify `char *' arguments and their references according to
9403 prototypes in tparam.h.
9404
ecb0f94d 9405 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9406
7ac80be9
EZ
9407 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9408 Adapt all references accordingly.
9409
9410 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9411
ef1fd07e
TT
94122011-03-11 Tom Tromey <tromey@redhat.com>
9413
9414 * buffer.c (syms_of_buffer): Remove obsolete comment.
9415
7ef4b50c
EZ
94162011-03-11 Eli Zaretskii <eliz@gnu.org>
9417
9418 * termhooks.h (encode_terminal_code): Declare prototype.
9419
9420 * msdos.c (encode_terminal_code): Don't declare prototype.
9421
9422 * term.c (encode_terminal_code): Now external again, used by
9423 w32console.c and msdos.c.
9424
44f230aa
SM
9425 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9426 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9427
4b1ec863 94282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9429
1714f52b 9430 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9431
4b1ec863
PE
9432 * fringe.c (update_window_fringes): Mark locals as initialized
9433 (Bug#8227).
9434 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9435
524c7aa6
PE
9436 * alloc.c (mark_fringe_data): Move decl from here ...
9437 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9438 to check its interface.
9439 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9440
a5c0af81 9441 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9442 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9443 (fontset_font): Mark local as initialized.
a9a06e0b 9444 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9445
b4716021
PE
9446 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9447
811e9bac 9448 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9449 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9450 (x_own_selection, Fx_disown_selection_internal): Rename locals
9451 to avoid shadowing.
9452 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9453
7e3ab302
PE
9454 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9455 so that the caller can use some name other than gcpro1.
9456 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9457 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9458 (Fx_backspace_delete_keys_p):
9459 Use them to avoid shadowing, and rename vars to avoid shadowing.
9460 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9461 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9462 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9463 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9464 Remove unused locals.
7e3ab302
PE
9465 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9466 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9467 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9468 macros.
f78faa98 9469
e2b13473
PE
9470 * xterm.h (x_mouse_leave): New decl.
9471
77f23912
PE
9472 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9473 Remove unused functions.
cdf4ba58
PE
9474 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9475 (x_calc_absolute_position): Now static.
7411c686 9476 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9477 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9478 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9479 unless they are used.
38d0b34a
PE
9480 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9481 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9482 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9483 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9484 (x_error_catcher, x_connection_closed, x_error_handler):
9485 (x_error_quitter, xembed_send_message, x_iconify_frame):
9486 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9487 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9488 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9489
44f230aa
SM
9490 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9491 Rename or move locals to avoid shadowing.
6b463e58 9492 (tty_defined_color, merge_face_heights): Now static.
5967d051 9493 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9494 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9495 does not deduce is never used uninitialized.
73719eba
PE
9496 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9497 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9498
426994c3 9499 * terminal.c (store_terminal_param): Now static.
5489860b 9500
032f1620 9501 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9502 (set_frame_menubar): Remove unused local.
d4323972 9503 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9504 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9505 since they might point to immutable storage.
281585b0
PE
9506 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9507 since it's unused otherwise.
032f1620 9508
367c19e5 9509 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9510 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9511 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9512 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9513 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9514 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9515 does not deduce are never used uninitialized.
70739cbe 9516
07b48fa9
PE
9517 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9518
8868a238 9519 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9520 * window.c (window_loop, size_window):
9521 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9522
7e5cf297 9523 * window.c (display_buffer): Now static.
d6550a9f
PE
9524 (size_window): Mark variables that gcc -Wuninitialized
9525 does not deduce are never used uninitialized.
a586633d
PE
9526 * window.h (check_all_windows): New decl, to forestall
9527 gcc -Wmissing-prototypes diagnostic.
5b555da1 9528 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9529
f6095868
PE
9530 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9531 shadowing.
9532 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9533 Include <limits.h>.
9534 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9535 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9536 (load_charset_map): Mark variables that gcc -Wuninitialized
9537 does not deduce are never used uninitialized.
53df7c11 9538 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9539
f38b440c
PE
9540 * coding.c (coding_set_source, coding_set_destination):
9541 Use "else { /* comment */ }" rather than "else /* comment */;"
9542 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9543 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9544 a block, when the outer 'i' will do.
9545 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9546 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9547 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9548 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9549 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9550 Rename locals to avoid shadowing.
9551 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9552 * coding.c (emacs_mule_char, encode_invocation_designation):
9553 Now static, since they're not used elsewhere.
413bb2db 9554 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9555 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9556 (decode_coding_emacs_mule): Mark variables that gcc
9557 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9558 (detect_coding_iso_2022): Initialize a local variable that might
9559 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9560 this initialization is needed. (Bug#8211)
5f58e762
PE
9561 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9562 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9563 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9564 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9565 Remove unused macros.
f38b440c 9566
232b38b9 9567 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9568 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9569 * character.c (string_count_byte8): Likewise.
232b38b9 9570
fb90da1b
PE
9571 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9572 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9573
fb93dbc2
PE
9574 * chartab.c (copy_sub_char_table): Now static, since it's not used
9575 elsewhere.
5c156ace
PE
9576 (sub_char_table_ref_and_range, char_table_ref_and_range):
9577 Rename locals to avoid shadowing.
bbcd0949 9578 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9579
7d3b3862 9580 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9581 (BIDI_BOB): Remove unused macro.
7d3b3862 9582
6be7d3da
PE
9583 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9584 deduce are never used uninitialized.
c2ed9c8b 9585 * term.c (encode_terminal_code): Likewise.
6be7d3da 9586
75f8807f 9587 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9588
50938595
PE
9589 * tparam.h: New file.
9590 * term.c, tparam.h: Include it.
9591 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9592 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9593 Move these decls to tparam.h, and make them agree with what
9594 is actually in tparam.c. The previous trick of using incompatible
9595 decls in different modules does not conform to the C standard.
9596 All callers of tparam changed to use tparam's actual API.
9597 * tparam.c (tparam1, tparam, tgoto):
9598 Use const pointers where appropriate.
9599
fbceeba2
PE
9600 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9601 * cm.h (struct cm): Likewise.
9602 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9603 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9604 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9605 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9606 (turn_on_face, init_tty): Likewise.
9607 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9608
7f3f1250
PE
9609 * term.c (term_mouse_position): Rename local to avoid shadowing.
9610
e6ca6543
PE
9611 * alloc.c (mark_ttys): Move decl from here ...
9612 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9613
c40f8d15
AS
96142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9615
9616 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9617
cfe0661d
JB
96182011-03-09 Juanma Barranquero <lekktu@gmail.com>
9619
9620 * search.c (compile_pattern_1): Remove argument regp, unused since
9621 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9622 (compile_pattern): Don't pass it.
9623
0afb4571
J
96242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9625
9626 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9627 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9628 for ! HAVE_GTK3.
9629 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9630
9631 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9632
9633 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9634 gdk_window_get_screen, gdk_window_get_geometry,
9635 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9636 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9637 (xg_get_pixbuf_from_pixmap): New function.
9638 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9639 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9640 Call xg_get_pixbuf_from_pixmap instead of
9641 gdk_pixbuf_get_from_drawable.
9642 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9643 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9644 (xg_check_special_colors): Use GtkStyleContext and its functions
9645 for HAVE_GTK3.
9646 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9647 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9648 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9649 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9650 Call gtk_widget_get_preferred_size.
0afb4571
J
9651 (xg_frame_resized): gdk_window_get_geometry only takes 5
9652 parameters.
44f230aa
SM
9653 (xg_win_to_widget, xg_event_is_for_menubar):
9654 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9655 (xg_set_widget_bg): New function.
9656 (delete_cb): New function.
895009e1 9657 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9658 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9659 (xg_set_background_color): Call xg_set_widget_bg.
9660 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9661 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9662 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9663 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9664 if ! HAVE_GTK3.
9665 (update_frame_tool_bar): Call gtk_widget_hide.
9666 (xg_initialize): Use GDK_KEY_g.
9667
9668 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9669 if ! HAVE_GTK3
9670 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9671
9672 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9673 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9674 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9675
1c2cc4ef
JB
96762011-03-08 Juanma Barranquero <lekktu@gmail.com>
9677
9678 * w32xfns.c (select_palette): Check success of RealizePalette against
9679 GDI_ERROR, not zero.
9680
33383987 9681See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9682
9683;; Local Variables:
9684;; coding: utf-8
aac0c6e3
MR
9685;; End:
9686
acaf905b 9687 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9688
9689 This file is part of GNU Emacs.
9690
9691 GNU Emacs is free software: you can redistribute it and/or modify
9692 it under the terms of the GNU General Public License as published by
9693 the Free Software Foundation, either version 3 of the License, or
9694 (at your option) any later version.
9695
9696 GNU Emacs is distributed in the hope that it will be useful,
9697 but WITHOUT ANY WARRANTY; without even the implied warranty of
9698 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9699 GNU General Public License for more details.
9700
9701 You should have received a copy of the GNU General Public License
9702 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.