doc.c fix for bug#11036
[bpt/emacs.git] / src / ChangeLog
CommitLineData
935396c0
GM
12012-04-09 Glenn Morris <rgm@gnu.org>
2
05920a43
GM
3 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4 not just in the obarray, before snarfing them. (Bug#11036)
5
935396c0
GM
6 * Makefile.in ($(leimdir)/leim-list.el):
7 Pass EMACS rather than BUILT_EMACS.
8
a18ecafa
TZ
92012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
10
11 * process.c (make_process):
12 * process.h: Add integer `gnutls_handshakes_tried' member to
13 process struct.
14
15 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit. Add
16 convenience `GNUTLS_LOG2i' macro.
17
18 * gnutls.c (gnutls_log_function2i): Convenience log function.
19 (emacs_gnutls_read): Use new log functions,
20 `gnutls_handshakes_tried' process member, and
21 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
22 attempts per process (connection).
23
b4d3bc10
CY
242012-04-09 Chong Yidong <cyd@gnu.org>
25
26 * eval.c (Fuser_variable_p, user_variable_p_eh)
27 (lisp_indirect_variable): Functions deleted.
28 (Fdefvar): Caller changed.
29
30 * callint.c (Finteractive, Fcall_interactively):
31 * minibuf.c (Fread_variable): Callers changed.
32
70f4d973
EZ
332012-04-09 Eli Zaretskii <eliz@gnu.org>
34
35 * xdisp.c (set_cursor_from_row): If the display string appears in
36 the buffer at position that is closer to point than the position
37 after the display string, display the cursor on the first glyph of
38 the display string. Fixes cursor display when a 'display' text
39 property immediately follows invisible text. (Bug#11094)
40
cb3c2e3e
PE
412012-04-09 Paul Eggert <eggert@cs.ucla.edu>
42
43 composite.c: use 'double' consistently
44 * composite.c (get_composition_id): Use 'double' consistently
45 instead of converting 'float' to 'double' and vice versa; this is
46 easier to understand and avoids a GCC warning.
47
fd06db5d
GM
482012-04-09 Glenn Morris <rgm@gnu.org>
49
50fe702a
GM
50 * Makefile.in: Generate leim-list with bootstrap-emacs, in
51 preparation for dumping it with emacs. (Bug#4789)
52 (leimdir): New variable.
53 ($(leimdir)/leim-list.el): New rule.
54 (emacs$(EXEEXT)): Depend on leim-list.el.
55
fd06db5d
GM
56 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
57 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
58 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
59
55c131ee
AS
602012-04-08 Andreas Schwab <schwab@linux-m68k.org>
61
62 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
63 proper alignment.
64
9209588f
JB
652012-04-07 Juanma Barranquero <lekktu@gmail.com>
66
67 * xml.c (init_libxml2_functions) [WINDOWSNT]:
68 Remove unused local variable.
69
e3fb2efb
PE
702012-04-07 Paul Eggert <eggert@cs.ucla.edu>
71
72 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
73 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
74 (mark_memory): Mark Lisp_Objects only if pointers might hide in
75 objects, as mark_maybe_pointer will catch them otherwise.
76 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
77 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
78
b5385551
PE
792012-04-07 Paul Eggert <eggert@cs.ucla.edu>
80
81 Fix typo that broke non-Windows builds.
82 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
83
9078ead6
EZ
842012-04-07 Eli Zaretskii <eliz@gnu.org>
85
86 Support building on MS-Windows with libxml2.
87
88 * makefile.w32-in (OBJ2): Add xml.$(O).
89 (GLOBAL_SOURCES): Add xml.c.
90 ($(BLD)/xml.$(O)): New dependency list.
91
92 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
93 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
94 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
95 [!WINDOWSNT]: New macros.
96 (init_libxml2_functions, libxml2_loaded_p): New functions.
97 (parse_region): Call fn_xmlCheckVersion instead of using the macro
98 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
99 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
100 Calls xmlCleanupParser only if libxml2 was loaded (or statically
101 linked in).
102 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
103 init_libxml2_functions before calling libxml2 functions.
104 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
105
106 * emacs.c: Don't include libxml/parser.h.
107 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
108 xmlCleanupParser directly.
109
110 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
111
3811fdf3
EZ
1122012-04-07 Eli Zaretskii <eliz@gnu.org>
113
114 * indent.c (Fvertical_motion): If there is a display string at
115 point, use it.vpos to compute how many lines to backtrack after
116 move_it_to point. (Bug#11133)
117
2f8e16b2
EZ
1182012-04-06 Eli Zaretskii <eliz@gnu.org>
119
120 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
121 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
122 about subtle differences between FETCH_CHAR* and STRING_CHAR*
123 macros related to unification of CJK characters. For the details,
124 see the discussion following the message here:
125 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
126
3d439cd1
CY
1272012-04-04 Chong Yidong <cyd@gnu.org>
128
129 * keyboard.c (Vdelayed_warnings_list): Doc fix.
130
8bc53d00
EZ
1312012-04-01 Eli Zaretskii <eliz@gnu.org>
132
133 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
134 instead of alloca. (Bug#11138)
135
3b0512a3
AS
1362012-04-01 Andreas Schwab <schwab@linux-m68k.org>
137
138 * w32menu.c (is_simple_dialog): Properly check lisp types.
139 (Bug#11141)
140
8427ddd2
EZ
1412012-03-31 Eli Zaretskii <eliz@gnu.org>
142
979022ef
EZ
143 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
144 position we get to after a call to move_it_to fails the
145 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
146 only if we wind up in a string from display property. (Bug#11063)
147
a6b1c7cc
EZ
148 * window.c (Fdelete_other_windows_internal): Invalidate the row
149 and column information about mouse highlight, so that redisplay
150 restores it after reallocating the glyph matrices. (Bug#7464)
151
8427ddd2
EZ
152 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
153 string comes from a `display' text property, use the buffer
154 position of that property as if we actually saw that position in
155 the row's glyphs.
697ba24b
EZ
156 (move_it_by_lines): Remove the assertion that
157 "it->current_x == 0 && it->hpos == 0" which can be legitimately
158 violated when there's a before-string at the beginning of a line.
159 (Bug#11063)
8427ddd2 160
65a0a738
EZ
1612012-03-30 Eli Zaretskii <eliz@gnu.org>
162
163 * xdisp.c (append_space_for_newline): If the default face was
164 remapped, use the remapped face for the appended newline.
165 (extend_face_to_end_of_line): Use the remapped default face for
166 extending the face to the end of the line.
167 (display_line): Call extend_face_to_end_of_line when the default
168 face was remapped. (Bug#11068)
169
581355cc
EZ
1702012-03-29 Eli Zaretskii <eliz@gnu.org>
171
172 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
173
e8fc049f
SM
1742012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
175
176 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
177
4fb9a543
GM
1782012-03-27 Glenn Morris <rgm@gnu.org>
179
180 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
181 Doc fixes.
182
679910f1
KH
1832012-03-26 Kenichi Handa <handa@m17n.org>
184
185 * dispextern.h (struct glyph): Fix previous change. Change the
186 bit length of glyphless.ch to 25 (Bug#11082).
187
90d49b7f
CY
1882012-03-26 Chong Yidong <cyd@gnu.org>
189
190 * keyboard.c (Vselection_inhibit_update_commands): New variable.
191 (command_loop_1): Use it; inhibit selection update for
192 handle-select-window too (Bug#8996).
193
f514f6f0
FP
1942012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
195
e8fc049f 196 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 197
bf43fa51
KH
1982012-03-25 Kenichi Handa <handa@m17n.org>
199
200 * dispextern.h (struct glyph): Change the bit length of
201 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
202
8a0c01dd
EZ
2032012-03-24 Eli Zaretskii <eliz@gnu.org>
204
205 * s/ms-w32.h (tzname): Include time.h before redirecting to
206 _tzname. Fixes the MSVC build. (Bug#9960)
207
7d1c3a76
AS
2082012-03-24 Andreas Schwab <schwab@linux-m68k.org>
209
8ed79523
AS
210 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
211 characters.
212
7d1c3a76
AS
213 * xterm.c (XTread_socket): Only modify handling_signal if
214 !SYNC_INPUT. (Bug#11080)
215
e99a9b8b
EZ
2162012-03-23 Eli Zaretskii <eliz@gnu.org>
217
218 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
219 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
220 when fetching a multibyte character consumes more bytes than
221 CHAR_BYTES returns, due to unification of CJK characters in
222 string_char. (Bug#11073)
223
5063c0e1
TN
2242012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
225
226 * process.c (wait_reading_process_output): Handle pty disconnect
227 by refraining from sending oneself a SIGCHLD (bug#10933).
228
9f851fbd
CY
2292012-03-22 Chong Yidong <cyd@gnu.org>
230
231 * dispextern.h (struct it): New member string_from_prefix_prop_p.
232
5063c0e1 233 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
234 Mark string as coming from a prefix property.
235 (handle_face_prop): Use default face for prefix strings (Bug#4281).
236 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
237
fb5b8aca
CY
2382012-03-21 Chong Yidong <cyd@gnu.org>
239
240 * xfaces.c (Vface_remapping_alist): Doc fix.
241
62356a1b
EZ
2422012-03-20 Eli Zaretskii <eliz@gnu.org>
243
244 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
245 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
246 Doc fixes.
62356a1b 247
025de85b
CY
2482012-03-20 Chong Yidong <cyd@gnu.org>
249
250 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
251 to reflect default non-nil value of redisplay-dont-pause.
252
4827f94e
KH
2532012-03-19 Kenichi Handa <handa@m17n.org>
254
255 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
256 it fit in a valid range (Bug#11003).
257
e50a24a2
EZ
2582012-03-18 Eli Zaretskii <eliz@gnu.org>
259
260 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
261 that is not from display property, accept the row as a "cursor
262 row" if one of the string's character has a non-nil `cursor'
263 property. Fixes cursor positioning when there are newlines in
264 overlay strings, e.g. in icomplete.el. (Bug#11035)
265
9af5ed87
PE
2662012-03-12 Paul Eggert <eggert@cs.ucla.edu>
267
268 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
269
d1f55f16
CY
2702012-03-12 Chong Yidong <cyd@gnu.org>
271
272 * eval.c (inhibit_lisp_code): Rename from
273 inhibit_window_configuration_change_hook; move from window.c.
274
275 * xfns.c (unwind_create_frame_1, Fx_create_frame):
276 * window.c (run_window_configuration_change_hook)
277 (syms_of_window): Callers changed.
278
66c5eebd
CY
2792012-03-11 Chong Yidong <cyd@gnu.org>
280
413df973
CY
281 * keymap.c (Fkey_description): Doc fix (Bug#9700).
282
66c5eebd
CY
283 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
284
1de11f56
CY
2852012-03-10 Chong Yidong <cyd@gnu.org>
286
287 * frame.c (other_visible_frames): Don't assume the selected frame
288 is visible (Bug#10955).
289
cae07000
SM
2902012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
291
292 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
293
89c94350
JD
2942012-03-08 Jan Djärv <jan.h.d@swipnet.se>
295
296 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
297 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
298 zero (Bug#10954).
299
999dd333
GM
3002012-03-03 Glenn Morris <rgm@gnu.org>
301
01a6dcc8 302 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 303
de0100f2
EZ
3042012-03-02 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
307 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
308 (redisplay_window, next_element_from_string): Fix typos in
309 comments.
3e441275
EZ
310 (redisplay_window): Pass to move_it_vertically the margin in
311 pixels, not in screen lines.
de0100f2 312
96a72ee9
GM
3132012-03-02 Glenn Morris <rgm@gnu.org>
314
315 * buffer.c (buffer-list-update-hook): Doc fix.
316
312508d7
EZ
3172012-02-29 Eli Zaretskii <eliz@gnu.org>
318
319 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
320 push_it before setting up the iterator for the first overlay
321 string, even if we have an empty string loaded.
322 (next_overlay_string): If there's an empty string on the iterator
323 stack, pop the stack. (Bug#10903)
324
27f3c637
PE
3252012-02-25 Paul Eggert <eggert@cs.ucla.edu>
326
327 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
328 Suggested by Stefan Monnier in
329 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
330 * alloc.c (widen_to_Lisp_Object): New static function.
331 (mark_memory): Also mark Lisp_Objects by fetching pointer words
332 and widening them to Lisp_Objects. This would work even if
333 USE_LSB_TAG is defined and wide integers are used, which might
334 happen in a future version of Emacs.
335
3c9dfce6
CY
3362012-02-25 Chong Yidong <cyd@gnu.org>
337
fa74b241
CY
338 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
339 Doc fix.
340
3c9dfce6
CY
341 * xselect.c (Fx_selection_exists_p): Doc fix.
342 (x_clipboard_manager_save_all): Print an informative message
343 before saving to clipboard manager.
344
9486df08
CY
3452012-02-24 Chong Yidong <cyd@gnu.org>
346
347 * keyboard.c (process_special_events): Handle all X selection
348 requests in kbd_buffer, not just the next one (Bug#8869).
349
f01d3321
CY
3502012-02-23 Chong Yidong <cyd@gnu.org>
351
352 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
353 call when setting menu-bar-lines and tool-bar-lines parameters.
354 (unwind_create_frame_1): New helper function.
355
356 * window.c (inhibit_window_configuration_change_hook): New var.
357 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 358 (syms_of_window): Initialize it.
f01d3321 359
86b847b6
CY
3602012-02-22 Chong Yidong <cyd@gnu.org>
361
362 * xterm.c (x_draw_image_relief): Add missing type check for
363 Vtool_bar_button_margin (Bug#10743).
364
a59225b1
CY
3652012-02-21 Chong Yidong <cyd@gnu.org>
366
367 * fileio.c (Vfile_name_handler_alist): Doc fix.
368
369 * buffer.c (Fget_file_buffer): Protect against invalid file
370 handler return value.
371
310f5bd4
PE
3722012-02-20 Paul Eggert <eggert@cs.ucla.edu>
373
cb3a28cc
PE
374 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
375 when computing $valmask.
376
310f5bd4
PE
377 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
378 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
379 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
380 It's useless in that case, and it can cause problems on hosts
381 that allocate halves of EMACS_INT values separately.
382 Reported by Dan Horák. Diagnosed by Andreas Schwab in
383 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
384 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
385 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
386 it avoids undefined behavior on hosts where shifting right by more
387 than the word width has undefined behavior.
388
2375c96a
CY
3892012-02-19 Chong Yidong <cyd@gnu.org>
390
391 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
392 (Funhandled_file_name_directory, Ffile_name_as_directory)
393 (Fdirectory_file_name, Fexpand_file_name)
394 (Fsubstitute_in_file_name): Protect against invalid file handler
395 return values (Bug#10845).
396
3eb49e71
EZ
3972012-02-18 Eli Zaretskii <eliz@gnu.org>
398
399 * .gdbinit (pitx): Fix incorrect references to fields of the
400 iterator stack.
401
7b926f3f
CY
4022012-02-17 Chong Yidong <cyd@gnu.org>
403
404 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
405
11273115
PE
4062012-02-15 Paul Eggert <eggert@cs.ucla.edu>
407
408 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
409 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
410
c3a70e2b
CY
4112012-02-15 Chong Yidong <cyd@gnu.org>
412
413 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
414 marked as special. Also, starting docstrings with * is obsolete.
415
0ca43699
AS
4162012-02-13 Andreas Schwab <schwab@linux-m68k.org>
417
418 * gnutls.c (emacs_gnutls_write): Fix last change.
419
2e8f3c56
LI
4202012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
421
422 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
423 send_process.
424
af70074f
SM
4252012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
426
427 * keymap.c (Fsingle_key_description): Handle char ranges.
428
95986d52
CY
4292012-02-12 Chong Yidong <cyd@gnu.org>
430
afd83bd1
CY
431 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
432 as that creates a dangerous corner case.
433
95986d52
CY
434 * window.c (Fdelete_window_internal): Invalidate the mouse
435 highlight (Bug#9904).
436
bd7da63e
GM
4372012-02-12 Glenn Morris <rgm@gnu.org>
438
439 * xselect.c (Fx_own_selection_internal)
440 (Fx_get_selection_internal, Fx_disown_selection_internal)
441 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
442 * nsselect.m (Fx_own_selection_internal)
443 (Fx_disown_selection_internal, Fx_selection_exists_p)
444 (Fx_selection_owner_p, Fx_get_selection_internal):
445 Sync docs and argument specs with the xselect.c versions.
446
77abcbc2
LI
4472012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
448
449 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
450
90b671e2
EZ
4512012-02-11 Eli Zaretskii <eliz@gnu.org>
452
1c0ca0b7
EZ
453 * w32select.c (Fx_selection_exists_p): Sync doc string and
454 argument list with xselect.c. (Bug#10783)
455
456 * w16select.c (Fx_selection_exists_p): Sync doc string and
457 argument list with xselect.c. (Bug#10783)
90b671e2 458
49241268
GM
4592012-02-10 Glenn Morris <rgm@gnu.org>
460
461 * fns.c (Fsecure_hash): Doc fix.
462
f998bbe7 4632012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
464
465 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
466
0992bd9c
CY
4672012-02-07 Chong Yidong <cyd@gnu.org>
468
469 * buffer.c (Fbuffer_local_variables)
470 (buffer_lisp_local_variables): Handle unbound vars correctly;
471 don't let Qunbound leak into Lisp.
472
af008560
GM
4732012-02-07 Glenn Morris <rgm@gnu.org>
474
dd605cc4
GM
475 * image.c (Fimagemagick_types): Doc fix.
476
af008560
GM
477 * image.c (imagemagick-render-type): Change it from a lisp object
478 to an integer. Move the doc here from the lisp manual.
479 Treat all values not equal to 0 the same.
480
1449fa1d
CY
4812012-02-06 Chong Yidong <cyd@gnu.org>
482
483 * doc.c (store_function_docstring): Avoid applying docstring of
484 alias to base function (Bug#2603).
485
3723ec07
AS
4862012-02-04 Andreas Schwab <schwab@linux-m68k.org>
487
488 * .gdbinit (pp1, pv1): Remove redundant defines.
489 (pr): Use pp.
490
79c1cc1e
CY
4912012-02-04 Chong Yidong <cyd@gnu.org>
492
493 * nsterm.m: Declare a global (Bug#10694).
494
d7f29f8e
EZ
4952012-02-04 Eli Zaretskii <eliz@gnu.org>
496
cae07000
SM
497 * w32.c (get_emacs_configuration_options):
498 Include --enable-checking, if specified, in the return value.
d7f29f8e 499
3b95a6f9
MR
5002012-02-04 Martin Rudalics <rudalics@gmx.at>
501
502 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
503 after rounding frame sizes. (Bug#9723)
504
d6fa96a6
EZ
5052012-02-04 Eli Zaretskii <eliz@gnu.org>
506
507 * keyboard.c (adjust_point_for_property): Don't position point
508 before BEGV. (Bug#10696)
509
df0b2940
PE
5102012-02-03 Paul Eggert <eggert@cs.ucla.edu>
511
512 Handle overflow when computing char display width (Bug#9496).
513 * character.c (char_width): Return EMACS_INT, not int.
514 (char_width, c_string_width): Check for overflow when
515 computing the width; this is possible now that individual
516 characters can have unbounded width. Problem introduced
517 by merge from Emacs 23 on 2012-01-19.
518
6bee44d6
MA
5192012-02-02 Michael Albinus <michael.albinus@gmx.de>
520
521 * dbusbind.c (Fdbus_register_method): Mention the return value
522 :ignore in the docstring.
523
44f92739
GM
5242012-02-02 Glenn Morris <rgm@gnu.org>
525
1b9f60cc
GM
526 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
527
44f92739
GM
528 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
529 Unconditionally set to t. (Bug#10673)
530 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
531 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
532 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
533
c5d3843c
KH
5342012-02-02 Kenichi Handa <handa@m17n.org>
535
536 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
537 0, do not call append_composite_glyph.
538
159462d4 5392012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
540
541 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
542 NULL (Bug#6988).
543 (x_produce_glyphs): If the component of a composition is a null
544 string, set it->pixel_width to 1 to avoid zero-width glyph.
545
78cef877
EZ
5462012-02-01 Eli Zaretskii <eliz@gnu.org>
547
548 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
549 first 2 arguments are identical. This makes inserting large
550 output from a subprocess an order of magnitude faster on
551 MS-Windows, where all sbrk'ed memory is always contiguous.
552
97897668
GM
5532012-01-31 Glenn Morris <rgm@gnu.org>
554
555 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 556 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
557 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
558
31fd3586
GM
5592012-01-29 Glenn Morris <rgm@gnu.org>
560
561 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
562
0e24a8b2
CY
5632012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
564
565 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
566
cc0adcb0
CY
5672012-01-28 Chong Yidong <cyd@gnu.org>
568
569 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
570
acc28cb9
CY
5712012-01-26 Chong Yidong <cyd@gnu.org>
572
9c69cfb7
CY
573 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
574
acc28cb9
CY
575 * search.c (Fsearch_forward, Fsearch_backward): Document negative
576 repeat counts (Bug#10507).
577
48da7392
GM
5782012-01-26 Glenn Morris <rgm@gnu.org>
579
580 * lread.c (syms_of_lread): Doc fix.
581
14af5f7f
CY
5822012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
583
584 * coding.c (encode_designation_at_bol): Change return value to
585 EMACS_INT.
586
0b21c100
CY
5872012-01-25 Chong Yidong <cyd@gnu.org>
588
589 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
590
3c2907f7
CY
5912012-01-21 Chong Yidong <cyd@gnu.org>
592
593 * floatfns.c (Fcopysign): Make the second argument non-optional,
594 since nil is not allowed anyway.
595
959ad23f
AS
5962012-01-21 Andreas Schwab <schwab@linux-m68k.org>
597
598 * process.c (read_process_output): Use p instead of XPROCESS (proc).
599 (send_process): Likewise.
600
34a02f46
MR
6012012-01-19 Martin Rudalics <rudalics@gmx.at>
602
603 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
604 (Vwindow_persistent_parameters): Do not use Qstate.
605 Rewrite doc-strings.
34a02f46 606
1259009a 6072012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
608
609 * character.c (char_width): New function.
70d4fdf6
GM
610 (Fchar_width, c_string_width, lisp_string_width):
611 Use char_width (Bug#9496).
25ed9e61 612
6a6ee00d
MR
6132012-01-16 Martin Rudalics <rudalics@gmx.at>
614
615 * window.c (Vwindow_persistent_parameters): New variable.
616 (Fset_window_configuration, save_window_save): Handle persistent
617 window parameters.
618
c85efaf7
EZ
6192012-01-14 Eli Zaretskii <eliz@gnu.org>
620
621 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
622 thrashing the stack of the thread. (Bug#9087)
623
5944709e
PE
6242012-01-12 Paul Eggert <eggert@cs.ucla.edu>
625
626 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
627
e71f5d99
EZ
6282012-01-11 Eli Zaretskii <eliz@gnu.org>
629
630 * xdisp.c (rows_from_pos_range): Handle the case where the
631 highlight ends on a newline. (Bug#10464)
632 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
633 he end column for display of highlight that ends on a newline
634 before a R2L line.
635
ce316182
GM
6362012-01-11 Glenn Morris <rgm@gnu.org>
637
638 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
639 from load-path also when installation-directory is nil. (Bug#10208)
640
5b43da69
GM
6412012-01-10 Glenn Morris <rgm@gnu.org>
642
74cc8ff9
GM
643 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
644
7d8d6e4e
GM
645 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
646 Update template values to be closer to their typical values these days.
5b43da69 647
a0db8d43
EZ
6482012-01-09 Eli Zaretskii <eliz@gnu.org>
649
650 * xdisp.c (rows_from_pos_range): Accept additional argument
651 DISP_STRING, and accept any glyph in a row whose object is that
652 string as eligible for mouse highlight. Fixes mouse highlight of
653 display strings from overlays. (Bug#10464)
654
9a0115ab 6552012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 656
b9110d6a 657 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
658 * fileio.c (auto_saving_dir_umask): New static var.
659 (Fmake_directory_internal): Use it.
660 (do_auto_save_make_dir): Set it, instead of invoking chmod after
661 creating the directory. The old code temporarily assigns
662 too-generous permissions to the directory.
663 (do_auto_save_eh): Clear it.
b9110d6a 664 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
665 that the var is always cleared.
666
6c1bd3f3
EZ
6672012-01-07 Eli Zaretskii <eliz@gnu.org>
668
669 * search.c (scan_buffer): Pass character positions to
670 know_region_cache, not byte positions. (Bug#6540)
671
069d2b50
L
6722012-01-07 LynX <_LynX@bk.ru> (tiny change)
673
674 * w32.c (sys_rename): Report EXDEV when rename of a directory
675 fails because the target is on another logical disk. (Bug#10284)
676
75bf0d33
DB
6772012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
678
679 * xterm.c (x_embed_request_focus): New function.
680
681 * xterm.h: Add prototype.
682
683 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
684
1c6e5a32
GM
6852012-01-05 Glenn Morris <rgm@gnu.org>
686
687 * emacs.c (emacs_copyright): Update short copyright year to 2012.
688
651e947e
EZ
6892012-01-01 Eli Zaretskii <eliz@gnu.org>
690
691 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
692 Load gnutls_transport_set_lowat only if GnuTLS version is below
693 2.11.1.
694 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
695 GnuTLS versions below 2.11.1.
696
3778cdd8
AL
6972011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
698
699 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
700 to the doc string advising against its use for altering the way
701 windows are scrolled.
702
0e5317f7
KH
7032011-12-28 Kenichi Handa <handa@m17n.org>
704
705 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
706 coding-system ASCII compatible only when it does not produce BOM
707 on encoding (Bug#10383).
708
93d5ca1f
JD
7092011-12-26 Jan Djärv <jan.h.d@swipnet.se>
710
711 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
712 can scroll.
713 (create_and_show_popup_menu): Always use menu_position_func for
714 Gtk3 (Bug#10361).
715
ca22b785
AS
7162011-12-24 Andreas Schwab <schwab@linux-m68k.org>
717
718 * callint.c (Fcall_interactively): Don't truncate prompt string.
719
d048e1e6
EZ
7202011-12-23 Eli Zaretskii <eliz@gnu.org>
721
722 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
723 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 724 resumed from there (after widening). (Bug#10360)
d048e1e6 725
5ccaba1f
JD
7262011-12-22 Jan Djärv <jan.h.d@swipnet.se>
727
728 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
729
204ee57f
JD
7302011-12-21 Jan Djärv <jan.h.d@swipnet.se>
731
b81d40f0
JB
732 * nsterm.m (x_free_frame_resources):
733 Release f->output_data.ns->miniimage.
204ee57f
JD
734 (ns_index_color): Fix indentation. Do not retain
735 color_table->colors[i].
736
737 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
738 before returning.
739
740 * nsfns.m (x_set_background_color): Assign return value from
741 ns_index_color to face-background instead of NSColor*.
742 (ns_implicitly_set_icon_type): Fix indentation.
743 Change assignment in for loop to comparison.
744
745 * emacs.c (ns_pool): New variable.
746 (main): Assign ns_pool.
747 (Fkill_emacs): Call ns_release_autorelease_pool.
748
749 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
750 autorelease fdesc, release fdAttrs and tdict.
751 (ns_get_covering_families): Release charset.
752 (ns_findfonts): Release NSFontDescriptor created with new.
753 (ns_uni_to_glyphs): Fix indentation.
754 (setString): Release attrStr before assigning new value.
755
c803b2b7
JD
7562011-12-18 Jan Djärv <jan.h.d@swipnet.se>
757
678f4426
JD
758 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
759 and NS_IMPL_COCOA.
760 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
761 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
762
cd394be1 7632011-12-18 David Reitter <reitter@cmu.edu>
678f4426 764
5fecd5fc
JD
765 * nsterm.m (ns_term_init): Subscribe for notifications
766 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
767 to method trackingNotification in EmacsMenu.
768
769 * nsmenu.m (trackingMenu): New variable.
3771cb17 770 (trackingNotification): New method (from Aquamacs).
5fecd5fc 771 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 772 from Aquamacs (Bug#7030).
678f4426
JD
773
7742011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 775
c803b2b7
JD
776 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
777 (symbol_to_nsstring): Fix indentation.
778 (ns_symbol_to_pb): New function.
cae07000
SM
779 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
780 (Fns_rotate_cut_buffers_internal): Remove.
781 (Fns_store_selection_internal): Rename from
c803b2b7
JD
782 Fns_store_cut_buffer_internal.
783 (ns_get_foreign_selection, Fx_own_selection_internal)
784 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
785 (Fns_get_selection_internal, Fns_store_selection_internal):
786 Use ns_symbol_to_pb and check if return value is nil.
787 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
788 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
789 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
790 renamed to Sns_store_selection_internal.
791 (ns_handle_selection_request): Move code to Fx_own_selection_internal
792 and remove this function.
793 (ns_handle_selection_clear): Remove, never used.
794 (Fx_own_selection_internal): Move code from ns_handle_selection_request
795 here.
796
e1b01a3a
KB
7972011-12-17 Ken Brown <kbrown@cornell.edu>
798
799 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
800 GID is unknown (Bug#10257).
801
2adb6e85
PE
8022011-12-17 Paul Eggert <eggert@cs.ucla.edu>
803
804 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
805 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
806 which caused a build failure on GNU/Linux IA-64. This problem was
807 introduced by my 2011-10-07 patch.
808
d1d7b339
JL
8092011-12-15 Juri Linkov <juri@jurta.org>
810
811 * image.c (imagemagick_error): New function. (Bug#10112)
812 (imagemagick_load_image): Comment out `MagickSetResolution' call.
813 Use `imagemagick_error' where ImageMagick functions return
814 `MagickFalse'.
815 (Fimagemagick_types): Add `Fnreverse' to return the list in the
816 proper order.
817
100d5755
KH
8182011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
819
820 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
821 fill background (Bug#8992).
822
454592a6
MR
8232011-12-13 Martin Rudalics <rudalics@gmx.at>
824
825 * window.c (Vwindow_combination_resize)
826 (Vwindow_combination_limit): Use t instead of non-nil in
827 doc-strings.
61d4b438
MR
828 (Vrecenter_redisplay): Add first sentence of doc-string on
829 separate line.
53524d93 830 (Frecenter): Fix doc-string typo.
454592a6 831
3633e3aa
KH
8322011-12-11 Kenichi Handa <handa@m17n.org>
833
834 * coding.c (Funencodable_char_position): Pay attention to the
835 buffer text relocation (Bug#9389).
836
7b9d523a
JD
8372011-12-10 Jan Djärv <jan.h.d@swipnet.se>
838
839 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
840 gtk_init (Bug#10100).
841
b73189c6
EZ
8422011-12-10 Eli Zaretskii <eliz@gnu.org>
843
844 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
845 IT->string is nil. (Bug#10263)
846
f7dfe5d6
JD
8472011-12-10 Jan Djärv <jan.h.d@swipnet.se>
848
83faebb4
JD
849 * nsterm.h (x_free_frame_resources): Declare.
850
f7dfe5d6
JD
851 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
852 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
853
854 * nsterm.h (ns_get_defaults_value): Declare.
855
856 * nsterm.m (ns_default): Call ns_get_defaults_value.
857
7cd4e72c
EZ
8582011-12-09 Eli Zaretskii <eliz@gnu.org>
859
860 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
861 (Bug#10170)
862
b34d7317
YM
8632011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
864
865 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
866 that where the value of an _OBJC_* symbol points to is in the .bss
867 section (Bug#10240).
868
76470ad1
KH
8692011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
870
871 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 872 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 873
745fff94
KH
8742011-12-08 Kenichi Handa <handa@m17n.org>
875
876 * ftfont.c (get_adstyle_property): Fix previous change
877 (Bug#10233).
878
6e44397c
JB
8792011-12-07 Juanma Barranquero <lekktu@gmail.com>
880
881 * w32.c (init_environment): If no_site_lisp, remove site-lisp
882 dirs from the default value of EMACSLOADPATH (bug#10208).
883
7efa6272
GM
8842011-12-07 Glenn Morris <rgm@gnu.org>
885
886 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
887 installation and source directories as well. (Bug#10208)
888
f6fc4d87
CY
8892011-12-06 Chong Yidong <cyd@gnu.org>
890
891 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
892
2bf26180
GM
8932011-12-06 Glenn Morris <rgm@gnu.org>
894
895 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
896 as an error, not just -1. (Bug#10217)
897
3a6ad4f0
CY
8982011-12-05 Chong Yidong <cyd@gnu.org>
899
900 * keyboard.c (process_special_events): New function.
901 (swallow_events, Finput_pending_p): Use it (Bug#10195).
902
75a3b399
PE
9032011-12-05 Paul Eggert <eggert@cs.ucla.edu>
904
905 * coding.c (encode_designation_at_bol): Don't use uninitialized
906 local variable (Bug#9318).
907
c3c9e25e
KH
9082011-12-05 Kenichi Handa <handa@m17n.org>
909
910 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
911 return Qnil (Bug#8046, Bug#10193).
912
5eb05ea3
KH
9132011-12-05 Kenichi Handa <handa@m17n.org>
914
915 * coding.c (encode_designation_at_bol): New args charbuf_end and
916 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
917 (coding_set_source): Return how many bytes coding->source was
918 relocated.
919 (coding_set_destination): Return how many bytes
920 coding->destination was relocated.
921 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 922 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
923
9242011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
925
926 * coding.c (CODING_CHAR_CHARSET_P): New macro.
927 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
928 macro (Bug#9318).
929
9302011-12-05 Andreas Schwab <schwab@linux-m68k.org>
931
932 The following changes are to fix Bug#9318.
933
a79703f5 934 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
935 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
936 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 937 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 938
7dbda6df
JB
9392011-12-05 Juanma Barranquero <lekktu@gmail.com>
940
941 * lisp.h (process_quit_flag): Fix external declaration.
942
6d5eb5b0
SM
9432011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
944
945 Don't macro-inline non-performance-critical code.
946 * eval.c (process_quit_flag): New function.
947 * lisp.h (QUIT): Use it.
948
a0c3fad0
JD
9492011-12-04 Jan Djärv <jan.h.d@swipnet.se>
950
951 * nsfns.m (get_geometry_from_preferences): New function.
952 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
953
6c07aac2
AS
9542011-12-04 Andreas Schwab <schwab@linux-m68k.org>
955
956 * emacs.c (Qkill_emacs): Define.
957 (syms_of_emacs): Initialize it.
958 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
959 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
960 (quit_throw_to_read_char): Add parameter `from_signal'.
961 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
962 * lisp.h (QUIT): Call Fkill_emacs if requested.
963
c052ead4
JD
9642011-12-03 Jan Djärv <jan.h.d@swipnet.se>
965
966 * widget.c (update_wm_hints): Return if wmshell is null.
967 (widget_update_wm_size_hints): New function.
968
969 * widget.h (widget_update_wm_size_hints): Declare.
970
971 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
972 widget_update_wm_size_hints (Bug#10104).
973
9e49252b
EZ
9742011-12-03 Eli Zaretskii <eliz@gnu.org>
975
976 * xdisp.c (handle_invisible_prop): If the invisible text ends just
977 before a newline, prepare the bidi iterator for consuming the
978 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 979 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 980
02b16839
JL
9812011-12-02 Juri Linkov <juri@jurta.org>
982
983 * search.c (Fword_search_regexp): New Lisp function created from
984 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
985 (Fword_search_backward, Fword_search_forward)
986 (Fword_search_backward_lax, Fword_search_forward_lax):
987 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
988 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
989
0068070e
SM
9902011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
991
992 * fileio.c (Finsert_file_contents): Move after-change-function call
993 to before the "handled:" label, since all "goto handled" appear in
994 cases where the *-change-functions have already been properly called
995 (bug#10117).
996
3360a3fc
AS
9972011-12-01 Andreas Schwab <schwab@linux-m68k.org>
998
999 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1000 waiting for input. (Bug#10169)
1001
73d6c093
EZ
10022011-11-30 Eli Zaretskii <eliz@gnu.org>
1003
1004 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1005 verifies glyph row's hash code--we have just reallocated the
1006 glyphs, so their contents can be complete garbage. (Bug#10164)
1007
febe6bea
JB
10082011-11-30 Juanma Barranquero <lekktu@gmail.com>
1009
1010 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1011
801a4313
EZ
10122011-11-30 Eli Zaretskii <eliz@gnu.org>
1013
1014 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1015 attributes are tested _before_ calling verify_row_hash, to protect
1016 against GCC re-ordering of the tests. (Bug#10164)
1017
2b56b87e
JD
10182011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1019
1020 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1021
1022 * xterm.c (handle_one_xevent): Only set async_visible and friends
1023 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1024 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1025 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1026
dbf31225
PE
10272011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1028
1029 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1030 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1031 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1032 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1033 All uses changed to use GCPRO1 etc.
1034 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1035 Revert to old implementation (i.e., before 2011-03-11).
1036
1305621b
YM
10372011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1038
1039 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1040 of scroll runs so as to avoid assigning disabled bogus rows and
1041 unnecessary graphics copy operations.
1042
8c9afb46
EZ
10432011-11-27 Eli Zaretskii <eliz@gnu.org>
1044
1045 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1046 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1047 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1048 (malloc, free, realloc, calloc): Redirect to e_* only when
1049 compiling Emacs.
1050
1051 * lisp.h (GCTYPEBITS): Move before first use.
1052 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1053 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1054 this macro definition.
1055
1056 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1057 _MSC_VER.
1058
54e9e3bf
JD
10592011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1060
6d5eb5b0
SM
1061 * gtkutil.c (xg_create_frame_widgets):
1062 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1063 present with Gtk+ 2.0.
1064
83aca1cb
PE
10652011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 * fileio.c (Finsert_file_contents): Undo previous change; see
1068 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1069
5b76caa4
PE
10702011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 Rename locals to avoid shadowing.
1073 * fileio.c (Finsert_file_contents):
1074 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1075 * process.c (wait_reading_process_output):
1076 Rename inner 'proc' to 'p' to avoid shadowing.
1077 Indent for consistency with usual Emacs style.
1078
8c535114
EZ
10792011-11-25 Eli Zaretskii <eliz@gnu.org>
1080
1081 * xdisp.c (redisplay_window): If cursor row is not fully visible
1082 after recentering, and scroll-conservatively is set to a large
1083 number, scroll window by a few more lines to make the cursor fully
1084 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1085 (start_display): Don't move to the next line if the display should
1086 start at a newline that is part of a display vector or an overlay
1087 string. (Bug#10119)
8c535114 1088
fa4fdb5c
JL
10892011-11-24 Juri Linkov <juri@jurta.org>
1090
1091 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1092 after the `MagickPingImage' call. (Bug#10112)
1093
90ec88df
CY
10942011-11-23 Chong Yidong <cyd@gnu.org>
1095
1096 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1097
56e2e794
MR
10982011-11-23 Martin Rudalics <rudalics@gmx.at>
1099
1100 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1101 making another buffer current. (Bug#10114)
1102
b6e64c41
GM
11032011-11-23 Glenn Morris <rgm@gnu.org>
1104
1105 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1106
6b21de18
CY
11072011-11-23 Chong Yidong <cyd@gnu.org>
1108
1109 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1110 using it (Bug#5984).
1111
b12cd789
EZ
11122011-11-22 Eli Zaretskii <eliz@gnu.org>
1113
1114 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1115 and header-lines, as they don't have one computed for them.
1116 (Bug#10098)
1117
1118 * .gdbinit (prow): Make displayed values more self-explaining.
1119 Add row's hash code.
1120
261b6fd4
LMI
11212011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1122
1123 * process.c (wait_reading_process_output): Fix asynchrounous
1124 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1125 (wait_reading_process_output): Add comment and URL.
261b6fd4 1126
e7cfd277
JD
11272011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1128
1129 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1130
a9b9b7f5
CY
11312011-11-21 Chong Yidong <cyd@gnu.org>
1132
1133 * window.c (Fnext_window, Fprevious_window): Doc fix.
1134
b0d15b4f
SM
11352011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1136
1137 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1138
fe7a3057
JB
11392011-11-20 Juanma Barranquero <lekktu@gmail.com>
1140
1141 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1142
d2999b1a
MR
11432011-11-20 Martin Rudalics <rudalics@gmx.at>
1144
1145 * window.c (Fset_window_combination_limit): Rename argument
1146 STATUS to LIMIT.
1147 (Vwindow_combination_limit): Remove "status" from doc-string.
1148
d5ff9cd0
AS
11492011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1150
1151 * m/ibms390.h: Remove.
1152 * m/ibms390x.h: Don't include "ibms390.h".
1153
a5bb9bd3
SM
11542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1155
1156 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1157 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1158
cd1181db
JB
11592011-11-20 Juanma Barranquero <lekktu@gmail.com>
1160
1161 * casetab.c (Fset_case_table):
1162 * charset.c (Fcharset_after): Fix typos.
1163
615a3b8d 11642011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1165
17e845af
PE
1166 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1167 Otherwise, valgrind does not work on some platforms.
1168 Problem reported by Andreas Schwab in
6a0bf43d
PE
1169 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1170 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1171 is set, removing the need for VIRT_ADDRESS_VARIES.
1172 (PURE_P): Use a more-efficient implementation that needs just one
1173 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1174 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1175 to 4 (xorl, subq, cmpq, setbe).
1176 * alloc.c (pure): Always extern now, since that's the
1177 VIRT_ADDR_VARIES behavior.
1178 (PURE_POINTER_P): Use a single comparison, not two, for
1179 consistency with the new puresize.h.
1180 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1181 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1182 Remove VIRT_ADDR_VARIES no longer needed.
1183
f8fe6f96
EZ
11842011-11-19 Eli Zaretskii <eliz@gnu.org>
1185
1186 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1187 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1188 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1189 behave as if the cursor position were at the window margin.
1190
1191 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1192 and the cursor position is out of bounds, behave as if the cursor
1193 position were at the window margin. (Bug#10075)
1194
df05a53c
CY
11952011-11-18 Chong Yidong <cyd@gnu.org>
1196
1197 * window.c (Fwindow_combination_limit): Make first argument
1198 non-optional, since it is meaningless for live windows like the
1199 selected window.
1200
2071918e
DA
12012011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1202
1203 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1204
b50a28de
SM
12052011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1208 (graft_intervals_into_buffer): Simplify.
1209
015137db
EZ
12102011-11-18 Eli Zaretskii <eliz@gnu.org>
1211
1212 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1213 hash values of the two rows.
1214 (copy_row_except_pointers): Preserve the used[] arrays and the
1215 hash values of the two rows. (Bug#10035)
68c95424 1216 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1217
1218 * xdisp.c (row_hash): New function, body extracted from
1219 compute_line_metrics.
1220 (compute_line_metrics): Call row_hash, instead of computing the
1221 hash code inline.
1222
1223 * dispnew.c (verify_row_hash): Call row_hash for computing the
1224 hash code of a row, instead of duplicating code from xdisp.c.
1225
1226 * dispextern.h (row_hash): Add prototype.
1227
a2addb04
TH
12282011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1229
1230 * frame.c (delete_frame): Don't delete the terminal when the last
1231 X frame is closed if emacs is built with GTK toolkit.
1232
df85d315
JB
12332011-11-17 Juanma Barranquero <lekktu@gmail.com>
1234
1235 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1236
a0c2d0ae
MR
12372011-11-17 Martin Rudalics <rudalics@gmx.at>
1238
1239 * window.c (Vwindow_splits): Rename to
1240 Vwindow_combination_resize. Suggested by Juri Linkov.
1241 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1242 of Vwindow_splits.
1243
58179cce
JB
12442011-11-16 Juanma Barranquero <lekktu@gmail.com>
1245
7877f373
JB
1246 * nsfns.m (Fns_font_name):
1247 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1248
b6f67890
MR
12492011-11-16 Martin Rudalics <rudalics@gmx.at>
1250
1251 * window.h (window): Rename slot "nest" to "combination_limit".
1252 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1253 (Fset_window_nest): Rename to Fset_window_combination_limit.
1254 (Vwindow_nest): Rename to Vwindow_combination_limit.
1255 (recombine_windows, make_parent_window, make_window)
1256 (Fsplit_window_internal, saved_window)
1257 (Fset_window_configuration, save_window_save): Rename all
1258 occurrences of window_nest to window_combination_limit.
1259
c7015153
JB
12602011-11-15 Juanma Barranquero <lekktu@gmail.com>
1261
1262 * image.c (imagemagick_load_image): Fix typo.
1263
322ad6ec
EZ
12642011-11-14 Eli Zaretskii <eliz@gnu.org>
1265
1266 * xdisp.c (display_line): Move the call to
1267 highlight_trailing_whitespace before the call to
1268 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1269 faces of all the glyphs to compute ROW's hash value.
1270 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1271
f067b8ec
JB
12722011-11-14 Juanma Barranquero <lekktu@gmail.com>
1273
1274 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1275 just return (bug#10044).
1276
1e5b2111
EZ
12772011-11-12 Eli Zaretskii <eliz@gnu.org>
1278
7ef3cbd5
EZ
1279 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1280 with user-defined heap size. Bump the default size of the temacs
1281 heap to 27MB, to avoid memory warning when running temacs.
1282 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1283
1e5b2111
EZ
1284 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1285 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1286 (verify_row_hash) [XASSERTS]: New function.
1287 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1288 that the hash value of glyph rows is correct.
1e5b2111 1289
89d61221
MR
12902011-11-12 Martin Rudalics <rudalics@gmx.at>
1291
1292 * window.h (window): Remove splits slot.
1293 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1294 (Fdelete_other_windows_internal, make_parent_window)
1295 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1296 (Fset_window_configuration, save_window_save): Don't deal with
1297 split status of windows.
1298 (saved_window): Remove splits slot.
1299 (Vwindow_splits): Rewrite doc-string.
1300
97f18cc8
JD
13012011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1302
1303 * xfns.c (unwind_create_frame):
1304 * nsfns.m (unwind_create_frame):
1305 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1306 Vframe_list (Bug#9999).
1307
22a648b4
DA
13082011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1309
0b381c7e 1310 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1311
659afede
KH
13122011-11-11 Kenichi Handa <handa@m17n.org>
1313
1314 * callproc.c (Fcall_process): Set the member dst_multibyte of
1315 process_coding.
1316
9ac0394b
KH
13172011-11-11 Johan Bockgård <bojohan@gnu.org>
1318
1319 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1320 avoid a crash (bug#9496).
1321
2fbdc249
CY
13222011-11-09 Chong Yidong <cyd@gnu.org>
1323
1324 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1325 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1326
ac6b1f81
PE
13272011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1330
09db192c
PE
13312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1332
1333 Avoid some portability problems by eschewing 'extern inline' functions.
1334 The trivial performance wins aren't worth the portability hassles; see
1335 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1336 et seq.
1337 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1338 (window_box_width, window_box_left, window_box_left_offset)
1339 (window_box_right, window_box_right_offset): Undo previous change,
1340 by removing the "extern"s.
1341 * intervals.c (adjust_intervals_for_insertion)
1342 (adjust_intervals_for_deletion): Undo previous change,
1343 making these static again.
1344 (offset_intervals, temp_set_point_both, temp_set_point)
1345 (copy_intervals_to_string): No longer inline.
1346 * xdisp.c (window_text_bottom_y, window_box_width)
1347 (window_box_height, window_box_left_offset)
1348 (window_box_right_offset, window_box_left, window_box_right)
1349 (window_box): No longer inline.
1350
105216ed
CY
13512011-11-08 Chong Yidong <cyd@gnu.org>
1352
1353 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1354 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1355 Signal an error if not a live window.
105216ed
CY
1356 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1357 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1358
ae9e237f
JB
13592011-11-07 Juanma Barranquero <lekktu@gmail.com>
1360
1361 * lisp.h (syms_of_abbrev): Remove declaration.
1362 Reported by CHENG Gao <chenggao@royau.me>.
1363
c7aa8333
EZ
13642011-11-07 Eli Zaretskii <eliz@gnu.org>
1365
1366 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1367 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1368 of temacs in GUI mode.
1369
be7f5545
MR
13702011-11-07 Martin Rudalics <rudalics@gmx.at>
1371
1372 * window.h: Declare delete_all_child_windows instead of
1373 delete_all_subwindows.
1374 * window.c (Fwindow_nest, Fset_window_nest)
1375 (Fset_window_new_total, Fset_window_new_normal)
1376 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1377 (delete_all_subwindows): Rename to delete_all_child_windows.
1378 (Fdelete_other_windows_internal, Fset_window_configuration):
1379 Call delete_all_child_windows instead of delete_all_subwindows.
1380 * frame.c (delete_frame): Call delete_all_child_windows instead
1381 of delete_all_subwindows.
1382
ca78dc43
PE
13832011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1386 This is also needed for porting to any host where GC_MARK_STACK is
1387 not GC_MAKE_GCPROS_NOOPS.
1388 (which_symbols): Use it.
1389
a0241d01
KH
13902011-11-07 Kenichi Handa <handa@m17n.org>
1391
1392 * coding.c (coding_set_destination): Check coding->src_pos only
1393 when coding->src_object is a buffer (bug#9910).
1394
1395 * process.c (send_process): Set the member src_multibyte of coding
1396 to 0 (bug#9911) when sending a unibyte text.
1397
1398 * callproc.c (Fcall_process): Set the member src_multibyte of
1399 process_coding to 0 (bug#9912).
1400
a64bfdfa 14012011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1402
1403 * xmenu.c (cleanup_widget_value_tree): New function.
1404 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1405 calling free_menubar_widget_value_tree directly (Bug#9830).
1406
cb41b32a
PE
14072011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1408
1409 Fix some portability problems with 'inline'.
1410 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1411 (window_box_width, window_box_left, window_box_left_offset)
1412 (window_box_right, window_box_right_offset): Declare extern.
1413 Otherwise, these inline functions do not conform to C99 and
1414 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1415 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1416 * intervals.c (adjust_intervals_for_insertion)
1417 (adjust_intervals_for_deletion): Now extern, because otherwise the
1418 extern inline functions 'offset_intervals' couldn't refer to it.
1419 (static_offset_intervals): Remove.
1420 (offset_intervals): Rewrite using the old contents of
1421 static_offset_intervals. The old version didn't conform to C99
1422 because an extern inline function contained a reference to an
1423 identifier with static linkage.
1424
b7041366
AS
14252011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1426
1427 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1428 GC.
1429
88a37c4d
EZ
14302011-11-06 Eli Zaretskii <eliz@gnu.org>
1431
1432 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1433 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1434 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1435 return Qleft_to_right.
1436
49745b39
CY
14372011-11-06 Chong Yidong <cyd@gnu.org>
1438
1439 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1440 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1441 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1442 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1443 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1444 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1445 (Fwindow_vscroll): Doc fix.
1446 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1447 argument, since it makes no sense to pass a live window and for
1448 consistency with window-child.
1449
1f05cd82
CS
14502011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1451
1452 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1453 support MSVC.
1454
22610910
JR
14552011-11-05 Jason Rumney <jasonr@gnu.org>
1456
1457 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1458 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1459 fonts (Bug#6029).
1460 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1461 bitwise arithmetic preventing use of unicode-sip and non-truetype
1462 opentype fonts.
1463
a06776b2
EZ
14642011-11-05 Eli Zaretskii <eliz@gnu.org>
1465
3ad924ba
EZ
1466 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1467 "emacs"-only part.
1468
a06776b2
EZ
1469 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1470 initialization code to keep similarity to xfns.c after changes
1471 from 2011-11-05.
1472
c9e7db78
JD
14732011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1474
a97f8f3f
JD
1475 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1476 (unwind_create_frame): New function (Bug#9943).
1477 (Fx_create_frame): Restructure code to be more similar to the one in
1478 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1479 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1480 Move terminal->reference_count++ just before making the frame official
1481 (Bug#9943).
1482
1483 * nsterm.m (x_free_frame_resources): New function.
1484 (x_destroy_window): Move code to x_free_frame_resources.
1485
c9e7db78 1486 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1487 (Fx_create_frame, x_create_tip_frame):
1488 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1489 official. Move initialization of image_cache_refcount and
1490 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1491
a6fc3b5c
EZ
14922011-11-05 Eli Zaretskii <eliz@gnu.org>
1493
1494 Support MSVC build with newer versions of Visual Studio.
1495 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1496 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1497 nt/gmake.defs.
1498
1499 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1500 which are not supported by MSVC.
1501 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1502 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1503 bitfields.
1504 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1505 types in bitfields.
1506 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1507
1508 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1509
58179cce 15102011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1511
1512 Support MSVC build with newer versions of Visual Studio.
1513 * w32.c: Don't include w32api.h for MSVC.
1514 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1515
1516 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1517 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1518 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1519 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1520 e_* cousins.
1521 (alloca) [_MSC_VER]: Define to _alloca.
1522
1523 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1524
1525 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1526
a58c13ed
EZ
15272011-11-04 Eli Zaretskii <eliz@gnu.org>
1528
1529 * xdisp.c (note_mouse_highlight): If either of
1530 previous/next-single-property-change returns nil, treat that as
1531 the beginning or the end of the buffer. (Bug#9955)
1532
fe0b6370
JD
15332011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1534
a58c13ed 1535 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1536 label is not null (Bug#9951).
1537 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1538 may be NULL.
1539
89bd5ee1
EZ
15402011-11-04 Eli Zaretskii <eliz@gnu.org>
1541
1542 * window.c (Fwindow_body_size): Mention in the doc string that the
1543 return value is in frame's canonical units. (Bug#9949)
1544
84c3edb9
EZ
15452011-11-03 Eli Zaretskii <eliz@gnu.org>
1546
4e2fb5c7
EZ
1547 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1548
84c3edb9 1549 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1550 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1551 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1552
bc17a887
EZ
15532011-11-01 Eli Zaretskii <eliz@gnu.org>
1554
1555 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1556 Don't stop backward scan on the continuation glyph, even though
1557 its CHARPOS is positive.
6d5eb5b0
SM
1558 (mouse_face_from_buffer_pos, note_mouse_highlight):
1559 Rename cover_string to disp_string.
bc17a887 1560
4ee88440
MR
15612011-11-01 Martin Rudalics <rudalics@gmx.at>
1562
1563 * window.c (temp_output_buffer_show): Don't use
1564 Vtemp_buffer_show_specifiers.
1565 (Vtemp_buffer_show_specifiers): Remove unused variable.
1566
c2ff3c02
EZ
15672011-10-30 Eli Zaretskii <eliz@gnu.org>
1568
1569 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1570 past the beginning of the current glyph matrix.
1571
58179cce 15722011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1573
1574 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1575 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1576 HAVE_GTK3 (Bug#9869).
b77a6a7f 1577
3b574623
JD
1578 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1579 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1580
b77a6a7f
JD
1581 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1582
1583 * xterm.c: Declare x_handle_net_wm_state to return int.
1584 (handle_one_xevent): Check if we are iconified but don't have
1585 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1586 (get_current_wm_state): Return non-zero if not hidden,
1587 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1588 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1589 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1590 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1591
196e41e4
PE
15922011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1595 so that this new function doesn't get optimized away by a
1596 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1597
021f2e1a
AS
15982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1599
1600 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1601
8b058d44
EZ
16022011-10-29 Eli Zaretskii <eliz@gnu.org>
1603
1604 Fix the `xbytecode' command.
1605 * .gdbinit (xprintbytestr): New command.
b50a28de 1606 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1607 (xbytecode): Print the byte-code string as well.
1608
4452fb80
EZ
16092011-10-29 Kim Storm <storm@cua.dk>
1610
8b058d44
EZ
1611 * alloc.c (which_symbols): New function.
1612
21b72067
AS
16132011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1614
1615 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1616 line. (Bug#9903)
1617
83ed7b5c
GM
16182011-10-29 Glenn Morris <rgm@gnu.org>
1619
1620 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1621 Not clear what it was for, and it causes various bugs. (Bug#9839)
1622
5a7a728b
EZ
16232011-10-28 Eli Zaretskii <eliz@gnu.org>
1624
1625 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1626 possible random value that matches one of those tested as
1627 condition to clear the mouse face.
1628
d3d0842f
CY
16292011-10-28 Chong Yidong <cyd@gnu.org>
1630
1631 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1632
31b39d13
DN
16332011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1634
1635 * window.c (make_window): Initialize phys_cursor_on_p.
1636
9aba6043
SM
16372011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1638
1639 * lisp.h (struct Lisp_Symbol): Update comments.
1640
c20992f4
JB
16412011-10-28 Juanma Barranquero <lekktu@gmail.com>
1642
1643 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1644
db4f02f2
EZ
16452011-10-28 Eli Zaretskii <eliz@gnu.org>
1646
1647 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1648 <oslsachem@gmail.com> for helping to debug this.
1649
1650 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1651 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1652 (g_b_init_get_glyph_outline_w): New static variables.
1653 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1654 (GetGlyphOutlineW_Proc): New typedefs.
1655 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1656 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1657 New functions.
1658 (w32font_open_internal, compute_metrics):
1659 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1660 instead of calling the "wide" APIs directly.
1661
1662 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1663
1664 * w32.h (syms_of_w32font): Add prototype.
1665
87e68db4
JB
16662011-10-27 Juanma Barranquero <lekktu@gmail.com>
1667
1668 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1669 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1670 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1671 (Fmove_to_window_line): Doc fix.
1672
435c1d67
CY
16732011-10-27 Chong Yidong <cyd@gnu.org>
1674
1675 * process.c (make_process): Set gnutls_state to NULL.
1676
1677 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1678 non-NULL, regardless of GNUTLS_INITSTAGE.
1679 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1680 an error. Set process slots as soon as we allocate them.
1681
1682 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1683
9c6c6f49
CY
16842011-10-27 Chong Yidong <cyd@gnu.org>
1685
9aba6043
SM
1686 * gnutls.c (emacs_gnutls_deinit): New function.
1687 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1688 (Fgnutls_deinit, Fgnutls_boot): Use it.
1689
1690 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1691 (deactivate_process): Call emacs_gnutls_deinit.
1692
657d08d3
JB
16932011-10-27 Juanma Barranquero <lekktu@gmail.com>
1694
1695 * image.c (x_create_x_image_and_pixmap):
1696 * w32.c (sys_rename, w32_delayed_load):
1697 * w32font.c (fill_in_logfont):
1698 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1699
5430d399
JB
17002011-10-26 Juanma Barranquero <lekktu@gmail.com>
1701
1702 * w32fns.c (w32_default_color_map): New function,
1703 extracted from Fw32_default_color_map.
a7ef684b 1704 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1705
fe0055fa
PE
17062011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1707
1708 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1709
e6346438
SM
17102011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1711
1712 * keyboard.c (test_undefined): New function (bug#9751).
1713 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1714
e112cc37
ET
17152011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1716
1717 * sysdep.c (init_sys_modes): Fix the check for the controlling
1718 terminal (Bug#6649).
1719
7b5d6677
EZ
17202011-10-20 Eli Zaretskii <eliz@gnu.org>
1721
1722 * dispextern.h (struct bidi_it): New member next_en_type.
1723
1724 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1725 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1726 current character, check also for next_en_type being WEAK_EN.
1727 (bidi_resolve_weak): Don't enter the expensive loop if the current
1728 position is before next_en_pos. Record the bidi type of the first
1729 non-ET, non-BN character we find, in addition to its position.
1730 (bidi_level_of_next_char): Invalidate next_en_type when
1731 next_en_pos is over-stepped.
1732
7da0b018
PE
17332011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1736 * editfns.c: Rewrite current-time-zone so that it invokes
1737 the equivalent of (format-time-string "%Z") to get the time zone name.
1738 This fixes a bug when the time zone name contains characters that
1739 need converting from the system time locale to Emacs internal format.
1740 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1741 that patch fixed format-time-string to do the conversion, but
1742 I forgot to fix current-time-zone.
1743 (format_time_string): New function, containing most of
1744 what Fformat_time_string used to contain.
1745 (Fformat_time_string): Rewrite in terms of format_time_string.
1746 This doesn't change this function's behavior.
1747 (current-time-zone): Rewrite to use format_time_string.
1748 This fixes the bug reported by Michael Schierl in
1749 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1750 Jason Rumney's 2007-06-07 change worked around this bug, but
1751 didn't fix it.
1752 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1753
8547b010
EZ
17542011-10-19 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (start_display): If the character at POS is displayed
1757 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1758 (try_window_reusing_current_matrix): If a line ends in a display
1759 vector or the next line starts in a display vector, continue
1760 redrawing the window even though the character position of
1761 start_row was reached.
8547b010
EZ
1762 (Bug#9771, part 2)
1763
4e948d15
CY
17642011-10-18 Chong Yidong <cyd@gnu.org>
1765
1766 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1767 with nobreak-char-display too.
1768
4787455f
EZ
17692011-10-18 Eli Zaretskii <eliz@gnu.org>
1770
1771 Fix part 3 of bug#9771.
1772 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1773 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1774 non-neutral characters if the current character is a paragraph
1775 separator (a.k.a. Newline). This avoids running the same
1776 expensive loop twice, once when we consume the preceding newline
1777 and the other time when the line actually needs to be displayed.
1778 Avoid the loop when we see neutrals on the base embedding level
1779 following a character whose directionality is the same as the
1780 paragraph's. This avoids running the expensive loop when a line
1781 ends in a long sequence of neutrals, like control characters.
1782 Add assertion against STRONG_AL type. Slightly rearrange code
1783 that determines the type of a neutral given the first non-neutral
1784 that follows it.
1785 (bidi_level_of_next_char): Set next_en_pos to zero when
1786 invalidating its info.
1787
2c91f553
EZ
17882011-10-17 Eli Zaretskii <eliz@gnu.org>
1789
1790 * xdisp.c (push_display_prop): Determine whether to record string
1791 or buffer position by IT->string, not by IT->method. Allow
1792 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1793 (move_it_vertically_backward): Don't look for character position
1794 immediately after the newline when in a continuation line.
1795 (Bug#9771, part 1)
2c91f553 1796
c7b08b0d
MR
17972011-10-15 Martin Rudalics <rudalics@gmx.at>
1798
1799 * window.c (coordinates_in_window): Rewrite and delabelize
1800 vertical border check. (Bug#5357) (Bug#9618)
1801
6b02f655
SM
18022011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1803
1804 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1805 errors in XSetWindowBorder (bug#9310).
1806
81d40c92
DA
18072011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1808
1809 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1810 avoid crash when xmalloc overrun checking is enabled.
1811
d4172c3b
EZ
18122011-10-13 Eli Zaretskii <eliz@gnu.org>
1813
1814 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1815 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1816 cursor motion with <left> and <right> arrow keys.
1817
1818 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1819 some callers set that themselves.
1820
b00eea75
EZ
18212011-10-12 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1824 display string and the previous row comes from the same string and
1825 is empty. (Bug#9739) (Bug#9738)
1826
8fe012c4
SM
18272011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1828
1829 * doc.c (get_doc_string): Encode file name (bug#9735).
1830
0074aef2
EZ
18312011-10-12 Eli Zaretskii <eliz@gnu.org>
1832
79beb178
EZ
1833 * bidi.c (bidi_level_of_next_char):
1834 * xdisp.c (get_visually_first_element): Remove old incorrect
1835 comments regarding the Unicode Line Separator character.
1836
0074aef2
EZ
1837 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1838
6e4b3fbe
DA
18392011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1840
1841 * alloc.c (Fgc_status): Do not access beyond zombies array
1842 boundary if nzombies > MAX_ZOMBIES.
1843 * alloc.c (dump_zombies): Add missing format specifier.
1844
0324f3af
PE
18452011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1846
b5525cac
PE
1847 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1848 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1849
0324f3af
PE
1850 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1851 Some packages use them to denote characters with modifiers.
1852
e9b5f888
AS
18532011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1854
1855 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1856 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1857 matching a pp-number. Rename parameter var to var1.
1858
127827c0
SM
18592011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1860
1861 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1862
c8fd3bd0
GM
18632011-10-08 Glenn Morris <rgm@gnu.org>
1864
1865 * callint.c (Fcall_interactively): Give a more explicit error for the
1866 'c' case with a non-character input. (Bug#8479)
1867
352ec8ff
EZ
18682011-10-08 Eli Zaretskii <eliz@gnu.org>
1869
03669ccb
EZ
1870 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1871 lines.
7061c986
EZ
1872 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1873 lines that are hscrolled on the left.
03669ccb 1874
352ec8ff
EZ
1875 * dispnew.c (buffer_posn_from_coords): Account for a possible
1876 presence of header-line. (Bug#4426)
1877
a66cfb1c
SM
18782011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1879
6b02f655
SM
1880 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1881 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1882
7c5ee88e
PE
18832011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1886 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1887 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1888 this makes Emacs dump core during garbage collection on rare
1889 occasions. sizeof is obviously inferior to offsetof here, so
1890 stick with offsetof.
1891 (GC_POINTER_ALIGNMENT): New macro.
1892 (mark_memory): Omit 3rd (offset) arg; caller changed.
1893 Don't assume EMACS_INT alignment is the same as pointer alignment.
1894
df1bbe5b
SM
18952011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1896
1897 * keyboard.c (read_key_sequence_remapped): New var.
1898 (read_key_sequence): Compute remapping in the right buffer.
1899 (command_loop_1): Use read_key_sequence's remapping directly.
1900
51553db6
SM
19012011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1902
32c1fffd
SM
1903 * dired.c (file_name_completion): Don't expand file name.
1904 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1905 before checking file name handler.
1906
51553db6
SM
1907 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1908 they've been requested explicitly (bug#9591).
1909
b6bd1599 19102011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1911
1912 * keymap.c (Fsingle_key_description): Use make_specified_string
1913 instead of build_string to build string from push_key_description.
1914 (Bug#5193)
1915
f701dc2a
PE
19162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1917
4222c55d
PE
1918 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1919 This fixes a Y2038 bug on 64-bit hosts.
1920 * buffer.c (reset_buffer):
1921 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1922 (Fclear_buffer_auto_save_failure):
1923 Use 0, not -1, to represent an unset failure time, since time_t
1924 might not be signed.
1925
f701dc2a
PE
1926 Remove dependency on glibc malloc internals.
1927 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1928 Move back here from lisp.h, but with their new implementations.
1929 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1930 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1931 * charset.c (charset_table_init): New static var.
1932 (syms_of_charset): Use it instead of xmalloc. This removes a
1933 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1934 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1935 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1936 Move back to alloc.c.
1937 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1938 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1939
9ceebf39
JD
19402011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1941
1942 * nsterm.m (windowDidResize): Call x_set_window_size only when
1943 ns_in_resize is true. Otherwise set pixelwidth/height and
1944 call change_frame_size (Bug#9628).
1945
cb993c58
PE
19462011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1947
3930c88b
PE
1948 Port --enable-checking=all to Fedora 14 x86-64.
1949 * charset.c (syms_of_charset): Also account for glibc malloc's
1950 internal overhead when calculating the initial malloc maximum.
1951
cb993c58
PE
1952 Port --enable-checking=all to Fedora 14 x86.
1953 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1954 Move to lisp.h.
1955 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1956 (overrun_check_realloc, overrun_check_free):
1957 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1958 That way, xmalloc returns a properly-aligned pointer even if
1959 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1960 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1961 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1962 into account when calculating the initial malloc maximum.
1963 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1964 Move here from alloc.c, so that charset.c can use it too.
1965 Properly align; the old code wasn't right for common 32-bit hosts
1966 when configured with --enable-checking=all.
1967 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1968 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1969
31bed486
EZ
19702011-09-29 Eli Zaretskii <eliz@gnu.org>
1971
04c70788 1972 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1973 use EDOM.
1974
fbcaa2f3
EZ
19752011-09-28 Eli Zaretskii <eliz@gnu.org>
1976
1977 * xdisp.c (compute_display_string_end): If there's no display
1978 string at CHARPOS, return -1.
1979
1980 * bidi.c (bidi_fetch_char): When compute_display_string_end
1981 returns a negative value, treat the character as a normal
1982 character not covered by a display string. (Bug#9624)
1983
a239d4e9
JB
19842011-09-28 Juanma Barranquero <lekktu@gmail.com>
1985
1986 * lread.c (Fread_from_string): Fix typo in docstring.
1987
88652fd5
EZ
19882011-09-27 Eli Zaretskii <eliz@gnu.org>
1989
1990 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1991 newline, reseat the iterator instead of bidi-iterating there one
1992 character at a time. (Bug#9610)
32c1fffd
SM
1993 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1994 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1995
ed497dd4
AS
19962011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1997
1998 * lread.c (readevalloop): Use correct code for NBSP.
1999 (read1): Likewise. (Bug#9608)
2000
b2bf61aa
MA
20012011-09-25 Michael Albinus <michael.albinus@gmx.de>
2002
2003 * dbusbind.c (Fdbus_register_signal): When service is not
2004 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2005
32bbb17c
GM
20062011-09-25 Glenn Morris <rgm@gnu.org>
2007
2008 * buffer.c (truncate-lines): Doc fix.
2009
94e0933e
CY
20102011-09-24 Chong Yidong <cyd@stupidchicken.com>
2011
2012 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2013 (Fset_window_next_buffers): Doc fix.
2014
cddde921
GM
20152011-09-24 Glenn Morris <rgm@gnu.org>
2016
2017 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2018
1260aef1
PE
20192011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2020
25b4bfa0
PE
2021 Fix minor problems found by static checking.
2022 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2023 * indent.c (Fvertical_motion): Fix == vs = typo.
2024
e3cbd34b
EZ
20252011-09-24 Eli Zaretskii <eliz@gnu.org>
2026
a66cfb1c
SM
2027 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2028 Default value is now t. Doc fix.
6bf7006f 2029
e3cbd34b 2030 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2031 logic when moving up, not only when moving down. Fix the
e3cbd34b 2032 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2033 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2034
2035 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2036 CHARPOS is covered by a display string which includes newlines.
2037 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2038 is covered by a display string with embedded newlines.
2039
a3de0cbd
MA
20402011-09-24 Michael Albinus <michael.albinus@gmx.de>
2041
2042 * dbusbind.c (Fdbus_register_signal): Add match rule to
2043 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2044 (Fdbus_register_method, Vdbus_registered_objects_table):
2045 Fix docstring.
a3de0cbd 2046
b260039d
JM
20472011-09-24 Jim Meyering <meyering@redhat.com>
2048
32c1fffd 2049 do not ignore write error for any output size
b260039d
JM
2050 The previous change was incomplete.
2051 While it makes emacs --batch detect the vast majority of stdout
2052 write failures, errors were still ignored whenever the output size is
2053 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2054 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2055 && echo FAIL: ignored write error
2056 FAIL: ignored write error
2057 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2058 && echo FAIL: ignored write error
2059 FAIL: ignored write error
2060 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2061
8eca8a7c
AS
20622011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2063
2064 * emacs.c (Fkill_emacs): In noninteractive mode exit
2065 non-successfully if a write error occurred on stdout. (Bug#9574)
2066
3341db62
EZ
20672011-09-21 Eli Zaretskii <eliz@gnu.org>
2068
2069 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2070 the xassert test.
2071
2072 * dispextern.h (struct it): Update the comment documenting what
2073 can it->OBJECT be.
2074
8c203dbf
EZ
20752011-09-20 Eli Zaretskii <eliz@gnu.org>
2076
2077 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2078 a display string, extend search for cursor position to end of row.
2079 (find_row_edges): If the row ends in a newline from a display
2080 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2081 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2082 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2083 non-empty line. Fixes confusing cursor motion with arrow keys at
2084 the beginning of a line that starts with whitespace.
8c203dbf 2085
a4824228
LMI
20862011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2087
2088 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2089 (bug#9493).
2090
33ed493b
CY
20912011-09-18 Chong Yidong <cyd@stupidchicken.com>
2092
2093 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2094 boolean (Bug#9154).
2095
56cd55c8
EZ
20962011-09-18 Eli Zaretskii <eliz@gnu.org>
2097
2098 * xdisp.c (display_line): Record maximum and minimum buffer
2099 positions even if no glyphs were produced (e.g., by a zero-width
2100 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2101 buffer positions that will be removed from the glyph row because
2102 they don't fit.
c02dcedf
EZ
2103 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2104 column is beyond frame width: don't subtract 1 "pixel" when
2105 computing width of the stretch.
3e62b7e0
EZ
2106 (reseat_at_next_visible_line_start): Undo the change made on
2107 2011-09-17 that saved paragraph information and restored it after
2108 the call to `reseat'. (Bug#9545)
56cd55c8 2109
5ed99d36 21102011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2111
2112 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2113 and turn window cursor on if cleared (Bug#9415).
2114
5ed99d36 21152011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2116
2117 * search.c (boyer_moore): Take unibyte characters from pattern
2118 literally. (Bug#9458)
2119
9bade7b2
EZ
21202011-09-18 Eli Zaretskii <eliz@gnu.org>
2121
2122 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2123
e5e9d610
PE
21242011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2125
87e4427a
PE
2126 Fix minor problem found by static checking.
2127 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2128 initialized, to pacify gcc -Wuninitialized.
2129
e5e9d610
PE
2130 * fileio.c: Report proper errno when syscall falls.
2131 (Finsert_file_contents): Save and restore errno,
2132 so that report_file_error outputs the correct diagnostic.
2133 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2134
a1674f0b
EZ
21352011-09-18 Eli Zaretskii <eliz@gnu.org>
2136
2137 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2138
fbfb6dd4
EZ
21392011-09-17 Eli Zaretskii <eliz@gnu.org>
2140
2141 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2142 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2143
bb187662
EZ
21442011-09-17 Eli Zaretskii <eliz@gnu.org>
2145
1137e8b8 2146 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2147 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2148
2149 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2150 (bidi_find_paragraph_start): Search back for paragraph beginning
2151 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2152 (bidi_move_to_visually_next): Only trigger paragraph-related
2153 computations when the last character is a newline or at EOB, not
2154 just any NEUTRAL_B. (Bug#9470)
2155
bb187662
EZ
2156 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2157 truncated lines if point is covered by a display string. (Bug#9524)
2158
2e621251
PE
21592011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2162 (cons_to_x_long): New function.
2163 (lisp_data_to_selection_data): Use it. Correct the test for
2164 short-versus-long data; it was negated. Break out of vector
2165 loop, for efficiency, when a long datum is discovered.
2166
91a15bc6
SM
21672011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2168
2169 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2170
b41c3a35
EZ
21712011-09-16 Eli Zaretskii <eliz@gnu.org>
2172
2173 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2174 GCC PR/17406) by declaring this function with external scope.
2175
7812ba2d
PE
21762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2179 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2180
cf7edc2a
AS
21812011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2182
2183 * editfns.c (Fformat): Correctly handle text properties on "%%".
2184
bd01620e
EZ
21852011-09-15 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xterm.c (x_draw_composite_glyph_string_foreground):
2188 * w32term.c (x_draw_composite_glyph_string_foreground):
2189 * term.c (encode_terminal_code):
2190 * composite.c (composition_update_it, get_composition_id):
2191 * xdisp.c (get_next_display_element)
2192 (fill_composite_glyph_string): Add comments about special meaning
2193 of TAB characters in a composition.
2194
a02719a3
PE
21952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2198 This occurs when processing a multibyte format.
2199 Problem reported by Wolfgang Jenker.
a02719a3 2200
72589a3c
JB
22012011-09-15 Johan Bockgård <bojohan@gnu.org>
2202
2203 * xdisp.c (try_cursor_movement): Only check for exact match if
2204 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2205
1c14176c
PE
22062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2207
2208 Remove unused external symbols.
2209 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2210 * xdisp.c (calc_pixel_width_or_height): Now static.
2211 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2212 * indent.c (check_display_width):
2213 * w32term.c: Fix comment to match code.
2214 * xterm.c, xterm.h (x_catching_errors): Remove.
2215
d2eea5b5
PE
22162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 * xselect.c: Use signed conversions more consistently (Bug#9498).
2219 (selection_data_to_lisp_data): Assume incoming selection data are
2220 signed integers, not unsigned. This is to be consistent with
2221 outgoing selection data, which was modified to use signed integers
2222 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2223 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2224 expects long, not unsigned long.
2225
46888499
EZ
22262011-09-14 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2229 computation of loop end. Reported by Johan Bockgård
2230 <bojohan@gnu.org>.
2231
ef8ef9fb
CY
22322011-09-13 Chong Yidong <cyd@stupidchicken.com>
2233
2234 * frame.c (Fother_visible_frames_p): Function deleted.
2235
fa819fed
EZ
22362011-09-12 Eli Zaretskii <eliz@gnu.org>
2237
2238 * indent.c (compute_motion): Process display vector front to back
2239 rather than the other way around. (Bug#2496)
2240
2ba8e008
SM
22412011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2242
2243 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2244
20f53c69
CY
22452011-09-11 Chong Yidong <cyd@stupidchicken.com>
2246
2247 * minibuf.c (Fread_from_minibuffer): Doc fix.
2248
d562d7a4
EZ
22492011-09-11 Eli Zaretskii <eliz@gnu.org>
2250
2251 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2252 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2253
1c4d7f3d
LMI
22542011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2255
2256 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2257 value for non-existent files.
2258
b885bf36
EZ
22592011-09-11 Eli Zaretskii <eliz@gnu.org>
2260
2261 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2262 set its "size" to -1. This will set the modtime_size field of
2263 the corresponding buffer to -1, which is what
2264 verify-visited-file-modtime expects for files that do not exist.
2265 (Bug#9139)
2266
6612f0bf
PE
22672011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2270 here ...
2271 * lisp.h: ... from here. push_key_description is no longer
2272 defined in keyboard.c, so its declaration should not be in
2273 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2274 logically belongs with push_key_description.
2275
dfb3f755
PE
22762011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2277
2278 * buffer.h: Include <sys/types.h> instead of <time.h>.
2279 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2280 Problem reported by Herbert J. Skuhra.
2281
3134906c
LMI
22822011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2283
2284 * xml.c (parse_region): Make the parsing work for
2285 non-comment-starting XML files again (bug#9144).
2286
8d903f4e
AS
22872011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2288
2289 * image.c (gif_load): Fix calculation of bottom and right corner.
2290 (Bug#9468)
2291
80ad64f4
EZ
22922011-09-10 Eli Zaretskii <eliz@gnu.org>
2293
2294 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2295 redisplay in small windows.
2296
208a048d
EZ
22972011-09-09 Eli Zaretskii <eliz@gnu.org>
2298
2299 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2300
9b1c252e
MR
23012011-09-08 Martin Rudalics <rudalics@gmx.at>
2302
2303 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2304 Operate on live windows only.
2305
2949f33b
JB
23062011-09-08 Juanma Barranquero <lekktu@gmail.com>
2307
2308 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2309
e08dcafd
EZ
23102011-09-07 Eli Zaretskii <eliz@gnu.org>
2311
2312 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2313 only under bidi iteration.
2314
115b96bd
JD
23152011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2316
2317 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2318
c8199d0f
PE
23192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2322 Without this fix, the command to link temacs failed due to an
2323 undefined symbol __builtin_isnan. This is because
2324 /usr/include/iso/math_c99.h #defines isnan(x) to
2325 __builtin_isnan(x), but the bundled gcc, which identifies itself
2326 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2327 a __builtin_isnan.
2328 * floatfns.c (isnan): #undef, and then #define to a clone of
2329 what's in data.c.
2330 (Fisnan): Always define, since it's always available now.
2331 (syms_of_floatfns): Always define isnan at the Lisp level.
2332
e39b275c 23332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2334
2335 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2336
b2db44d9 23372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2338
f4af5137 2339 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2340 The previous code assumed that file offsets (off_t values) fit in
2341 EMACS_INT variables, which is not true on typical 32-bit hosts.
2342 The code messed up by falsely reporting buffer overflow in cases
2343 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2344 when "big" contains more than 2**29 bytes, even though this
2345 inserts just one byte and does not overflow the buffer.
2346 (Finsert_file_contents): Store file offsets as off_t
2347 values, not as EMACS_INT values. Check for overflow when
2348 converting between EMACS_INT and off_t. When checking for
2349 buffer overflow or for overlap, take the offsets into account.
2350 Don't use EMACS_INT for small values where int suffices.
2351 When checking for overlap, fix a typo: ZV was used where
2352 ZV_BYTE was intended.
2353 (Fwrite_region): Don't assume off_t fits into 'long'.
2354 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2355
ecfc0a49
MA
23562011-09-05 Michael Albinus <michael.albinus@gmx.de>
2357
2358 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2359
6511acf2 23602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2361
0999621a 2362 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2363
2364 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2365 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2366 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2367 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2368 (modify_event_symbol): Do not assume that the length of
2369 name_alist_or_stem is safe to alloca and fits in int.
2370 (Fexecute_extended_command): Likewise for function name and binding.
2371 (Frecursion_depth): Wrap around reliably on integer overflow.
2372 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2373 since some callers pass EMACS_INT values.
2374 (Fsingle_key_description): Don't crash if symbol name contains more
2375 than MAX_ALLOCA bytes.
2376 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2377 (get_minibuffer): Arg is now EMACS_INT, not int.
2378 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2379 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2380 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2381
2be7d702
PE
2382 * dbusbind.c (signature_cat): New function.
2383 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2384 Do not overrun buffer; instead, report string overflow.
2385
9d1df220
PE
2386 * dispnew.c (add_window_display_history): Don't overrun buffer.
2387 Truncate instead; this is OK since it's just a log.
2388
33ef5c64
PE
2389 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2390 even if the time zone offset is outlandishly large.
2391 Don't mishandle offset == INT_MIN.
2392
66c6fdd5
PE
2393 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2394 when creating daemon; the previous buffer-overflow check was incorrect.
2395
d749b01b
PE
2396 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2397 which has the guts of the old verror function.
2398
b5cd1905
PE
2399 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2400 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2401
6e1a67fb
PE
2402 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2403 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2404 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2405 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2406 length of string rather than counting it via multiple sprintfs;
2407 that's simpler and more reliable.
c21721cc
PE
2408 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2409 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2410 sprintf, in case result does not fit in int.
2411
c57b67fc
PE
2412 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2413 (fontset_from_font): Print it.
2414
8a401434
PE
2415 * frame.c (tty_frame_count): Now printmax_t, not int.
2416 (make_terminal_frame, set_term_frame_name): Print it.
2417 (x_report_frame_params): In X, window IDs are unsigned long,
2418 not signed long, so print them as unsigned.
2419 (validate_x_resource_name): Check for implausibly long names,
2420 and don't assume name length fits in 'int'.
2421 (x_get_resource_string): Don't blindly alloca invocation name;
2422 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2423 not fit in int.
2424
6e1a67fb
PE
2425 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2426 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2427 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2428
0df02bf3
PE
2429 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2430 Use esprintf, not sprintf, in case result does not fit in int.
2431
48e30793
PE
2432 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2433 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2434 it as a large positive number.
2435 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2436 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2437
a66ff6d8
PE
2438 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2439 in case result does not fit in int.
2440
aca216ff
PE
2441 * print.c (float_to_string): Detect width overflow more reliably.
2442 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2443 buffer overrun. Don't assume list length fits in 'int'. Treat
2444 print length of 0 as 0, not as infinity; to be consistent with other
2445 uses of print length in this function. Don't overflow print length
2446 index. Don't assume hash table size fits in 'long', or that
2447 vectorlike size fits in 'unsigned long'.
2448
31c286f7
PE
2449 * process.c (make_process): Use printmax_t, not int, to format
2450 process-name gensyms.
2451
55e5faa1
PE
2452 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2453
80f2e268
PE
2454 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2455 to avoid potential buffer overrun.
2456
670741ab
PE
2457 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2458 if X resource line is longer than 512 bytes.
2459
b7163a50
PE
2460 * xfns.c (x_window): Make sprintf buffer a bit bigger
2461 to avoid potential buffer overrun.
2462
ae58ff1f
PE
2463 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2464
c43c8a6a
PE
2465 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2466
3f8236f4
PE
24672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2468
53e9fe90 2469 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2470 Without these, Emacs silently mishandles large integers sometimes.
2471 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2472 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2473
6511acf2
PE
2474 * xdisp.c (try_window_id): Check Emacs fixnum range before
2475 converting to 'int'.
806add1d 2476
6511acf2 2477 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2478 Check that an Emacs fixnum is in range before assigning it to 'int'.
2479 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2480 values converted from Emacs fixnums.
2481 (Frecenter): Don't wrap around a line count if it is out of 'int'
2482 range; instead, treat it as an extreme value.
2483 (Fset_window_configuration, compare_window_configurations):
2484 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2485
6511acf2
PE
2486 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2487 that can exceed INT_MAX. Check that EMACS_INT value is in range
2488 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2489 (match_limit): Don't assume that a fixnum can fit in 'int'.
2490
6511acf2 2491 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2492 exceed INT_MAX.
2493
6511acf2 2494 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2495 (Fvertical_motion): Don't wrap around LINES values that don't fit
2496 in 'int'. Instead, treat them as extreme values. This is good
2497 enough for windows, which can't have more than INT_MAX lines anyway.
2498
fcb901a7
LMI
24992011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2500
0f2f6b6d
LMI
2501 * Require libxml/parser.h to avoid compilation warning.
2502
fcb901a7
LMI
2503 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2504
2505 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2506 since this reportedly can destroy thread storage.
2507
6e20a0d4
CY
25082011-08-30 Chong Yidong <cyd@stupidchicken.com>
2509
2510 * syntax.c (find_defun_start): Update all cache variables if
2511 exiting early (Bug#9401).
2512
148ae00e
EZ
25132011-08-30 Eli Zaretskii <eliz@gnu.org>
2514
f6cfbd8f
EZ
2515 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2516
148ae00e
EZ
2517 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2518 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2519 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2520
2521 * term.c (tty_append_glyph): New function.
2522 (produce_stretch_glyph): Static function and its prototype deleted.
2523
a66cfb1c
SM
2524 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2525 Add prototypes.
148ae00e 2526
c4a07a4c
PE
25272011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2530 when checking :margin (Bug#9390).
2531 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2532 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2533 so that the name doesn't mislead. All uses changed.
2534
6bc8cd65
JB
25352011-08-28 Johan Bockgård <bojohan@gnu.org>
2536
2537 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2538 set_tty_hooks.
2539
dca4927e
EZ
25402011-08-27 Eli Zaretskii <eliz@gnu.org>
2541
2542 * xdisp.c (move_it_to): Don't bail out early when reaching
2543 position beyond to_charpos, if we are scanning backwards.
2544 (move_it_vertically_backward): When DY == 0, make sure we get to
2545 the first character in the line after the newline.
2546
f2cad773
PE
25472011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2548
2549 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2550 (ccl_driver): Do not generate an out-of-range pointer.
2551 (Fccl_execute_on_string): Remove unnecessary check for
2552 integer overflow, noted by Stefan Monnier in
2553 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2554 Remove a FIXME that didn't need fixing.
2555 Simplify the newly-introduced buffer reallocation code.
2556
0cae2cdb
JB
25572011-08-27 Juanma Barranquero <lekktu@gmail.com>
2558
2559 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2560
5fc295a4 25612011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2562
70c60eb2 2563 Integer and memory overflow issues (Bug#9196).
726e0ab1 2564
d31850da
PE
2565 * doc.c (get_doc_string): Rework so that
2566 get_doc_string_buffer_size is the actual buffer size, rather than
2567 being 1 less than the actual buffer size; this makes xpalloc more
2568 convenient.
2569
a69fbedb
PE
2570 * image.c (x_allocate_bitmap_record, cache_image):
2571 * xselect.c (Fx_register_dnd_atom):
2572 Simplify previous changes by using xpalloc.
2573
fe5c5d37
PE
2574 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2575 since either will do and ptrdiff_t is convenient with xpalloc.
2576
0065d054
PE
2577 * charset.c (charset_table_size)
2578 (struct charset_sort_data.priority): Now ptrdiff_t.
2579 (charset_compare): Don't overflow if priorities differ greatly.
2580 (Fsort_charsets): Don't assume list length fits in int.
2581 Check for size-calculation overflow when allocating sort data.
2582 (syms_of_charset): Allocate an initial charset table that is
2583 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2584
2585 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2586
2587 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2588 The actual value is always <= INT_MAX, and leaving it unsigned made
2589 overflow checking harder.
2590
2591 * dispextern.h (struct glyph_matrix.rows_allocated)
2592 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2593 with xpalloc. The values are still always <= INT_MAX.
2594
2595 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2596
2597 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2598 (SAFE_NALLOCA): New macro.
2599
2600 * region-cache.c (struct boundary.pos, find_cache_boundary)
2601 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2602 (set_cache_region, invalidate_region_cache)
2603 (revalidate_region_cache, know_region_cache, region_cache_forward)
2604 (region_cache_backward, pp_cache):
2605 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2606 so that ptrdiff_t * can be passed to xpalloc.
2607 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2608 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2609 (pp_cache): Don't assume cache_len fits in int.
2610 * region-cache.h: Adjust extern decls to match.
2611
2612 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2613 EMACS_INT, since either will do, for xpalloc.
2614
2615 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2616 (xnmalloc, xnrealloc, xpalloc): New functions.
2617
726e0ab1
PE
2618 * bidi.c (bidi_shelve_header_size): New constant.
2619 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2620 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2621
51f30bc5 2622 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2623 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2624 (overlay_strings):
2625 Don't update size of array until after memory allocation succeeds,
2626 because xmalloc/xrealloc may not return.
0065d054
PE
2627 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2628 now that we have proper integer overflow checking.
2629 (record_overlay_string, overlay_strings): Catch overflows when
2630 calculating size of overlay_str_buf.
726e0ab1 2631
0065d054
PE
2632 * callproc.c (Fcall_process): Check for size overflow when
2633 calculating size of args2.
2634 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2635 Normally we prefer signed values, but sticking with ptrdiff_t would
2636 require adding more-complicated checks.
726e0ab1
PE
2637
2638 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2639 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2640 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2641 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2642
2643 * character.c (Fstring): Check for size-calculation overflow.
2644
2645 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2646 unnecessary integer overflow. Check for size overflow.
2647 (encode_coding_object): Don't update size until xmalloc succeeds.
2648
2649 * composite.c (get_composition_id): Check for overflow in glyph
2650 length calculations.
2651
2652 Integer and memory overflow fixes for display code.
2653 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2654 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2655 (scrolling_window): Check for overflow in size calculations.
2656 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2657 Don't assume glyph table len fits in int.
2658 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2659 (row_table_size): Now ptrdiff_t, not int.
2660 (scrolling_window): Avoid overflow in size calculations.
2661 Don't update size until allocation succeeds.
2662 * fns.c (concat): Check for overflow in size calculations.
2663 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2664 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2665 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2666
2667 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2668 (get_doc_string): Check for size calculation overflow.
2669 Don't update size until allocation succeeds.
2670 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2671 EMACS_INT, where ptrdiff_t will do.
2672 (Fsubstitute_command_keys): Check for string overflow.
2673
2674 * editfns.c (set_time_zone_rule): Don't assume environment length
2675 fits in int.
2676 (message_length): Now ptrdiff_t, not int.
2677 (Fmessage_box): Don't update size until allocation succeeds.
2678 Don't assume message length fits in int.
2679 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2680
0065d054
PE
2681 * emacs.c (main): Do not reallocate argv, since there is a null at
2682 the end that can be overwritten, and this way there's no need to
2683 worry about size-calculation overflow.
2684 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2685
2686 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2687 alloc succeeds.
2688 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2689
2690 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2691 (x_set_scroll_bar_width, x_figure_window_size):
2692 Check for integer overflow.
2693 (x_set_alpha): Do not assume XINT fits in int.
2694
2695 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2696 This is for the members text_lines, text_cols, total_lines, total_cols,
2697 where the system imposes an 'int' limit.
2698
2699 * fringe.c (Fdefine_fringe_bitmap):
2700 Don't update size until alloc works.
2701
2702 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2703 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2704
2705 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2706 Check for size-calculation overflow.
2707 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2708 do, as we prefer signed integers.
2709 (id_to_widget.max_size, id_to_widget.used)
2710 (xg_store_widget_in_map, xg_remove_widget_from_map)
2711 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2712 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2713 Use and return ptrdiff_t, not int.
2714 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2715 * gtkutil.h: Change prototypes to match the above.
2716
2717 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2718 are duplicate now that they've been promoted to lisp.h.
2719 (x_allocate_bitmap_record, x_alloc_image_color)
2720 (make_image_cache, cache_image, xpm_load):
2721 Don't update size until alloc is done.
2722 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2723 (x_detect_edges):
3256efce 2724 Check for size calculation overflow.
726e0ab1
PE
2725 (ct_colors_allocated_max): New constant.
2726 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2727 overflow.
3256efce 2728
726e0ab1
PE
2729 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2730 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2731 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2732 Use ptrdiff_t, not int, to count maps.
2733 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2734 calculations. Don't update size until allocation succeeds.
2735 Redo calculations to avoid overflow.
726e0ab1
PE
2736 * keyboard.h: Change prototypes to match the above.
2737
2738 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2739 to count maps.
2740 (current_minor_maps): Check for size calculation overflow.
2741 * keymap.h: Change prototypes to match the above.
2742
2743 * lread.c (read1, init_obarray): Don't update size until alloc done.
2744
2745 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2746 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2747
726e0ab1
PE
2748 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2749 Now ptrdiff_t, not int.
2750 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2751 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2752
2753 * process.c (Fnetwork_interface_list): Check for overflow
2754 in size calculation.
2755
2756 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2757
2758 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2759 overflow. Don't bother calling xmalloc when xrealloc will do.
2760
2761 * search.c (Freplace_match): Check for size calculation overflow.
2762 (Fset_match_data): Don't assume list lengths fit in 'int'.
2763
2764 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2765 for command line length. Do not attempt to address one before the
2766 beginning of an array, as that's not portable.
2767
2768 * term.c (max_frame_lines): Remove; unused.
2769 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2770 not int.
2771 (encode_terminal_code, calculate_costs): Check for size
2772 calculation overflow.
2773 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2774 table lengths and related sizes. Don't update size until alloc
2775 done. Redo calculations to avoid overflow.
2776 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2777
2778 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2779 subtracting pointers.
2780 (gobble_line): Check for overflow more carefully. Don't update size
2781 until alloc done.
2782
2783 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2784 Don't update size until alloc done.
2785 Redo size calculations to avoid overflow.
2786 Check for size calculation overflow.
0065d054 2787 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2788
2789 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2790 Use ptrdiff_t, not int, for sizes.
2791 (store_mode_line_noprop_char): Don't update size until alloc done.
2792
0065d054
PE
2793 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2794 Use ptrdiff_t, not int, for sizes.
2795 (Finternal_make_lisp_face, cache_face):
2796 Check for size calculation overflow.
2797 (cache_face): Treat size calculation overflows as if they were
2798 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2799
2800 * xfns.c (x_encode_text, x_set_name_internal)
2801 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2802 sizes, since they can exceed INT_MAX in size. Check for size
2803 calculation overflow.
2804
0065d054
PE
2805 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2806 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2807 Don't update size until alloc done.
2808
0065d054 2809 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2810 as sprintf is limited to int lengths.
1d526e2f 2811
252c5ee1
PE
2812 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2813 (X_LONG_MIN): New macros.
864d7ce7
PE
2814 Use them to make the following changes clearer.
2815 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2816 This change doesn't affect the value now, but it may help remind
2817 future maintainers not to raise the value too much later.
2818 (SELECTION_QUANTUM): Remove, replacing with ...
2819 (selection_quantum): ... new function, which avoids overflow.
2820 All uses changed.
2821 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2822 assumption that selection length fits in 'int'.
2823 (x_reply_selection_request, x_handle_selection_request)
2824 (x_get_window_property, receive_incremental_selection)
2825 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2826 (lisp_data_to_selection_data, clean_local_selection_data):
2827 Use ptrdiff_t, not int, to record length of selection.
2828 (x_reply_selection_request, x_get_window_property)
2829 (receive_incremental_selection, x_property_data_to_lisp):
2830 Redo calculations to avoid overflow.
2831 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2832 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2833 something.
2834 (x_get_window_property, receive_incremental_selection)
2835 (lisp_data_to_selection_data, x_property_data_to_lisp):
2836 Check for size-calculation overflow.
2837 (x_get_window_property, receive_incremental_selection)
2838 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2839 Don't store size until memory allocation succeeds.
2840 (x_get_window_property): Plug memory leak on memory exhaustion.
2841 Don't double-block input; malloc is safe here. Don't assume 2**34
2842 - 4 fits in unsigned long. Add an xassert to check
2843 XGetWindowProperty overflow. Be more careful about overflow
2844 calculations, and distinguish size from memory overflow better.
2845 (receive_incremental_selection): When tracing, don't assume
2846 unsigned int is less than INT_MAX.
2847 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2848 harmful) conversions of unsigned short to int.
2849 (lisp_data_to_selection_data): Don't assume that integers
2850 in the range -65535 through -1 fit in an X unsigned short.
2851 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2852 result parameters unless successful. Rely on cons_to_unsigned
2853 to report problems with elements; the old code wasn't right anyway.
2854 (x_check_property_data): Check for int overflow; we cannot use
2855 a wider type due to X limits.
2856 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2857
726e0ab1 2858 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2859
0065d054
PE
2860 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2861 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2862 (x_color_cells): Don't store size until memory allocation succeeds.
2863 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2864 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2865 (x_term_init): Don't assume length fits in int (sprintf is limited
2866 to int size).
bc18e09d 2867
ebfa62c0
PE
2868 Use ptrdiff_t for composition IDs.
2869 * character.c (lisp_string_width):
2870 * composite.c (composition_table_size, n_compositions)
2871 (get_composition_id, composition_gstring_from_id):
2872 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2873 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2874 * window.c (Frecenter):
2875 Use ptrdiff_t, not int, for composition IDs.
2876 * composite.c (get_composition_id): Check for integer overflow.
2877 * composite.h: Adjust prototypes to match the above changes.
2878
d3411f89
PE
2879 Use ptrdiff_t for hash table indexes.
2880 * category.c (hash_get_category_set):
2881 * ccl.c (ccl_driver):
2882 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2883 * coding.c (coding_system_charset_list, detect_coding_system):
2884 * coding.h (struct coding_system.id):
2885 * composite.c (get_composition_id, gstring_lookup_cache):
2886 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2887 * image.c (xpm_get_color_table_h):
2888 * lisp.h (hash_lookup, hash_put):
2889 * minibuf.c (Ftest_completion):
2890 Use ptrdiff_t for hash table indexes, not int (which is too
2891 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2892 32-bit --with-wide-int hosts).
2893
e097a6fa
PE
2894 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2895 Add a FIXME comment about memory leaks.
2896 (syms_of_charset): Don't assume xmalloc returns.
2897
5637687f
PE
2898 Don't assume that stated character widths fit in int.
2899 * character.c (Fchar_width, c_string_width, lisp_string_width):
2900 * character.h (CHAR_WIDTH):
2901 * indent.c (MULTIBYTE_BYTES_WIDTH):
2902 Use sanitize_char_width to avoid undefined and/or bad behavior
2903 with outlandish widths.
a66cfb1c 2904 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2905 now that we have two such functions. All uses changed.
2906 (sanitize_char_width): New inline function.
2907
a2271ba2
PE
2908 Don't assume that tab-width fits in int.
2909 * character.h (sanitize_width): New inline function.
2910 (SANE_TAB_WIDTH): New macro.
2911 (ASCII_CHAR_WIDTH): Use it.
2912 * indent.c (sane_tab_width): Remove. All uses replaced by
2913 SANE_TAB_WIDTH (current_buffer).
2914 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2915
18c52557
PE
2916 * fileio.c: Integer overflow issues with file modes.
2917 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2918
caeeedc1
PE
2919 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2920 Remove unreachable code.
2921 (read_hex, load_charset_map_from_file): Check for integer overflow.
2922
6df6ae42 2923 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2924 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2925 (x_send_scroll_bar_event): Likewise. Check that the size does not
2926 exceed limits imposed by XClientMessageEvent, as well as the usual
2927 ptrdiff_t and size_t limits.
2928
b13995db
PE
2929 * keyboard.c: Overflow, signedness and related fixes.
2930 (make_lispy_movement): Use same integer type in forward decl
2931 that is used in the definition.
2932 (read_key_sequence, keyremap_step):
2933 Change bufsize argument back to int, undoing my 2011-03-30 change.
2934 We prefer signed types, and int is wide enough here.
2935 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2936 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2937 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2938 length, not size_t. Use ptrdiff_t for index, not int.
2939 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2940 possibility of integer overflow.
2941
13464394
PE
2942 Overflow, signedness and related fixes for images.
2943
2944 * dispextern.h (struct it.stack[0].u.image.image_id)
2945 (struct_it.image_id, struct image.id, struct image_cache.size)
2946 (struct image_cache.used, struct image_cache.ref_count):
2947 * gtkutil.c (update_frame_tool_bar):
2948 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2949 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2950 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2951 * nsmenu.m (update_frame_tool_bar):
2952 * xdisp.c (calc_pixel_width_or_height):
2953 * xfns.c (image_cache_refcount):
2954 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2955 on typical 64-bit hosts.
2956
2957 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2958 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2959 Omit unnecessary casts to int.
2960 (parse_image_spec): Check that integers fall into 'int' range
2961 when the callers expect that.
2962 (image_ascent): Redo ascent calculation to avoid int overflow.
2963 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2964 (lookup_image): Remove unnecessary tests.
2965 (xbm_image_p): Locals are now of int, not EMACS_INT,
2966 since parse_image_check makes sure they fit into int.
2967 (png_load, gif_load, svg_load_image):
2968 Prefer int to unsigned where either will do.
2969 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2970 old tiff_error_handler and tiff_warning_handler.
2971 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2972 stack buffer overflows. It uses only the features of vsnprintf
2973 that are common to both POSIX and native Microsoft.
2974 (tiff_error_handler, tiff_warning_handler): Use it.
2975 (tiff_load, gif_load, imagemagick_load_image):
2976 Don't assume :index value fits in 'int'.
2977 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2978 (imagemagick_load_image): Check that crop parameters fit into
2979 the integer types that MagickCropImage accepts. Don't assume
2980 Vimagemagick_render_type has a nonnegative value. Don't assume
2981 size_t fits in 'long'.
2982 (gs_load): Use printmax_t to print the widest integers possible.
2983 Check for integer overflow when computing image height and width.
2984
c11821d4
EZ
29852011-08-26 Eli Zaretskii <eliz@gnu.org>
2986
2987 * xdisp.c (redisplay_window): Don't force window start if point
2988 will be invisible in the resulting window. (Bug#9324)
2989
0c95fcf7
EZ
29902011-08-25 Eli Zaretskii <eliz@gnu.org>
2991
2992 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2993 the display spec is of the form `(space ...)'.
2994 (handle_display_spec): Return the value returned by
2995 handle_single_display_spec, not just 1 or zero.
2996 (handle_single_display_spec): If the display spec is of the form
2997 `(space ...)', and specifies display in the text area, return 2
2998 rather than 1.
fee65a97 2999 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3000 accurately, and prefer exact match for point under bidi.
3001 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3002
3003 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3004 into disp_prop; all users changed.
3005
3006 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3007 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3008 for the text covered by the display property.
3009
e4ed06f1
CY
30102011-08-25 Chong Yidong <cyd@stupidchicken.com>
3011
3012 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3013 Change return value to nil.
3014 (Frecord_buffer): Delete unused function.
3015
f67cdd7f
EZ
30162011-08-24 Eli Zaretskii <eliz@gnu.org>
3017
5980d4c6
EZ
3018 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3019 buffers, return left-to-right.
8610fe8b
EZ
3020 (set_cursor_from_row): Consider candidate row a win if its glyph
3021 represents a newline and point is on that newline. Fixes cursor
3022 positioning on the newline at EOL of R2L text within L2R
3023 paragraph, and vice versa.
3024 (try_cursor_movement): Check continued rows, in addition to
3025 continuation rows. Fixes unwarranted scroll when point enters a
3026 continued line of R2L text within an L2R paragraph, or vice versa.
3027 (cursor_row_p): Consider the case of point being equal to
3028 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3029 from the end of a short line to the beginning of a continued line
3030 of R2L text within L2R paragraph.
3031 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3032 composed characters.
5980d4c6 3033
f67cdd7f
EZ
3034 * bidi.c (bidi_check_type): Use xassert.
3035 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3036 members.
3037
bca633fb
EZ
30382011-08-23 Eli Zaretskii <eliz@gnu.org>
3039
3040 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3041 a character.
3042
4a5885a7
CY
30432011-08-23 Chong Yidong <cyd@stupidchicken.com>
3044
3045 * nsfont.m (ns_otf_to_script): Fix typo.
3046
0902a04e
KH
30472011-08-22 Kenichi Handa <handa@m17n.org>
3048
3049 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3050 extra slot even if the purpose is char-code-property-table.
3051
1a2e6670
EZ
30522011-08-23 Eli Zaretskii <eliz@gnu.org>
3053
8ddde651
EZ
3054 * xdisp.c (redisplay_window): When computing centering_position,
3055 account for the height of the header line. (Bug#8874)
3056
425cc014
EZ
3057 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3058 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3059 candidate is selected by the mouse, and that candidate has a
3060 composed character under the mouse.
3061
1a2e6670
EZ
3062 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3063 coordinates reported by pos-visible-in-window-p for a composed
3064 character in column zero.
3065
8b76d6f8
SM
30662011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3067
3068 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3069
dac347dd
EZ
30702011-08-22 Eli Zaretskii <eliz@gnu.org>
3071
3072 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3073 consider it a hit if to_charpos is anywhere in the range of the
3074 composed buffer positions.
3075
e013fb34
CY
30762011-08-22 Chong Yidong <cyd@stupidchicken.com>
3077
3078 * image.c (gif_load): Don't assume that each subimage has the same
3079 dimensions as the base image. Handle disposal method that is
3080 "undefined" by the gif spec (Bug#9335).
3081
bd1ba3e8
CY
30822011-08-20 Chong Yidong <cyd@stupidchicken.com>
3083
3084 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3085 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3086
54a1215b
EZ
30872011-08-19 Eli Zaretskii <eliz@gnu.org>
3088
823564e5
EZ
3089 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3090 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3091 from an Org mode buffer to a Speedbar frame.
3092
54a1215b
EZ
3093 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3094 a composition, take its buffer position from IT->cmp_it.charpos.
3095 Fixes cursor positioning at the beginning of a line that begins
3096 with a composed character.
3097
9778ebcc
EZ
30982011-08-18 Eli Zaretskii <eliz@gnu.org>
3099
0be6ee06
EZ
3100 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3101 character bidirectional type, use STRONG_L instead. Fixes crashes
3102 in a buffer produced by `describe-categories'.
3103
9778ebcc
EZ
3104 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3105 members before the level stack, so they would be saved and
3106 restored when copying iterator state. Fixes incorrect reordering
3107 around TABs covered by display properties.
3108
156bffbe
AS
31092011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3110
6b02f655 3111 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3112
72ad093b
CY
31132011-08-17 Chong Yidong <cyd@stupidchicken.com>
3114
3115 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3116 (internal_condition_case_2, internal_condition_case_n):
3117 Remove unnecessary aborts (Bug#9081).
72ad093b 3118
35774242
EZ
31192011-08-17 Eli Zaretskii <eliz@gnu.org>
3120
3121 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3122 has no `load' handler, try opening the file locally. (Bug#9311)
3123
db76dd85
KB
31242011-08-16 Ken Brown <kbrown@cornell.edu>
3125
3126 * gmalloc.c: Expand comment.
3127
b215eee5
EZ
31282011-08-16 Eli Zaretskii <eliz@gnu.org>
3129
3130 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3131 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3132
a4579d33
KB
31332011-08-16 Ken Brown <kbrown@cornell.edu>
3134
3135 Fix memory allocation problems in Cygwin build (Bug#9273).
3136
3137 * unexcw.c ( __malloc_initialized): Declare external variable.
3138 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3139
8b76d6f8
SM
3140 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3141 New variables.
a4579d33
KB
3142 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3143 dumped emacs.
3144 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3145 in the static heap.
3146 [CYGWIN] (special_realloc): New function.
3147 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3148 requests to realloc storage in the static heap.
3149
3ebec551
PE
31502011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3151
3152 * bidi.c (bidi_initialize): Remove unused local.
3153
9fd8be00
EZ
31542011-08-15 Eli Zaretskii <eliz@gnu.org>
3155
6b02f655
SM
3156 * bidimirror.h:
3157 * biditype.h: Remove file.
3158 * makefile.w32-in ($(BLD)/bidi.$(O)):
3159 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3160
3161 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3162
3163 * chartab.c: Improve commentary for the uniprop_table API.
3164
32413314
EZ
3165 * bidi.c (bidi_paragraph_init): Support zero value of
3166 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3167 (bidi_initialize): Use uniprop_table instead of including
3168 biditype.h and bidimirror.h.
32413314 3169
9fd8be00
EZ
3170 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3171 coordinates of the iterator when restoring from ppos_it.
3172 (Bug#9296)
3173
5cf2b69b
KH
31742011-08-14 Kenichi Handa <handa@m17n.org>
3175
3176 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3177 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3178
daf17d00
EZ
31792011-08-14 Eli Zaretskii <eliz@gnu.org>
3180
3181 * xdisp.c (move_it_in_display_line_to): Don't invoke
3182 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3183 ppos_it. Fixes vertical cursor motion when line beginning is
3184 covered by an image. (Bug#9296)
3185
08e3161a
JD
31862011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3187
3188 * nsterm.h (ns_run_ascript): Declare.
3189 (NSAPP_DATA2_RUNASSCRIPT): Define.
3190
3191 * nsfns.m (as_script, as_result, as_status): New static variables.
3192 (ns_run_ascript): New function.
5e617bc2 3193 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3194 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3195 the event loop. Get status from as_status (Bug#7276).
3196
3197 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3198 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3199 the event loop (Bug#7276).
3200
a3720aa2
AS
32012011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3202
3203 * gnutls.c (QCgnutls_bootprop_priority)
3204 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3205 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3206 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3207 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3208 (QCgnutls_bootprop_verify_hostname_error)
3209 (QCgnutls_bootprop_callbacks_verify): Rename from
3210 Qgnutls_bootprop_..., all uses changed.
3211
3212 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3213 uses changed.
3214
0a0d27fb
PE
32152011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3216
19d5c50c
PE
3217 * xfaces.c (Qframe_set_background_mode): Now static.
3218 * dispextern.h (Qframe_set_background_mode): Remove decl.
3219
0a0d27fb
PE
3220 * process.c (Fnetwork_interface_info): Declare local only if needed.
3221
377538cb
JD
32222011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3223
3224 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3225 (Fnetwork_interface_list): Allocate in increments of bytes instead
3226 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3227 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3228 sockaddr.
3229 (struct ifflag_def): notrailers is smart on OSX.
3230 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3231 Get hardware address with getifaddrs if available.
3232
08fff70c
EZ
32332011-08-12 Eli Zaretskii <eliz@gnu.org>
3234
3235 * xdisp.c (iterate_out_of_display_property): xassert that
3236 IT->position is set to within IT->object's boundaries. Break from
3237 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3238 when IT->position is set up wrongly due to some bug.
3239 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3240 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3241 entry. Force push_it to save on the stack the current
3242 buffer/string position, to be restored by pop_it. Fix flags in
3243 the iterator structure wrt the object coming from a display
3244 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3245 properties. (Bug#9284)
3246
7be1c708 32472011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3248
7be1c708
CY
3249 * fontset.c (fontset_get_font_group): Add proper type checks.
3250 (Bug#9172)
aac0c6e3 3251
7be1c708 32522011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3253
7be1c708
CY
3254 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3255 and LC_VERSION_MIN_MACOSX.
3256 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3257 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3258
97bb72a6
EZ
32592011-08-08 Eli Zaretskii <eliz@gnu.org>
3260
3261 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3262 no-display-properties-and-no-overlays under bidi display.
3263 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3264 properties and overlays.
97bb72a6 3265
d5617611
CY
32662011-08-08 Chong Yidong <cyd@stupidchicken.com>
3267
37e11a63
CY
3268 * editfns.c (Fset_time_zone_rule): Document relationship with the
3269 setenv function.
3270
d5617611
CY
3271 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3272 the font entity extracted from the cache (Bug#8109).
3273
58872834
CY
32742011-08-07 Chong Yidong <cyd@stupidchicken.com>
3275
3276 * composite.c (autocmp_chars): Don't reset point. That is done by
3277 restore_point_unwind (Bug#5984).
3278
75bfc667
JL
32792011-08-07 Juri Linkov <juri@jurta.org>
3280
3281 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3282 to show the arg `TIME' instead of `TIMEVAL'.
3283
d1410150
EZ
32842011-08-06 Eli Zaretskii <eliz@gnu.org>
3285
3286 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3287 display property strides EOL and includes a newline, as in
3288 longlines-mode. (Bug#9254)
75b771e4
EZ
3289 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3290 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3291
3292 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3293 is non-zero, even if the data buffer is NULL. Fixes a crash in
3294 vertical-motion with longlines-mode. (Bug#9254)
3295
35928349
EZ
32962011-08-05 Eli Zaretskii <eliz@gnu.org>
3297
ec7cc85b
EZ
3298 * bidi.c <bidi_cache_total_alloc>: Now static.
3299 (bidi_initialize): Initialize bidi_cache_total_alloc.
3300
8b76d6f8 3301 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3302 cache. (Bug#9221)
3303
3304 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3305 amount allocated this far in `bidi_cache_total_alloc'.
3306 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3307 non-zero, only free the data buffer without restoring the cache
3308 contents. All callers changed.
3309
3310 * dispextern.h (bidi_unshelve_cache): Update prototype.
3311
3312 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3313 (move_it_in_display_line, move_it_to)
3314 (move_it_vertically_backward, move_it_by_lines): Replace the call
3315 to xfree to an equivalent call to bidi_unshelve_cache.
3316 (move_it_in_display_line_to): Fix logic of returning
412b6358 3317 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3318
e2e2423b
EZ
33192011-08-05 Eli Zaretskii <eliz@gnu.org>
3320
3321 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3322 came from a string character with a `cursor' property. (Bug#9229)
3323
ae9e757a
JD
33242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3325
3326 * Makefile.in (LIB_PTHREAD): New variable.
3327 (LIBES): Add LIB_PTHREAD (Bug#9216).
3328
3329 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3330 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3331
213bd7f2
AS
33322011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3333
6b02f655 3334 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3335
99aaf75f
JD
33362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3337
3338 * xterm.c (x_find_topmost_parent): New function.
3339 (x_set_frame_alpha): Find topmost parent window with
3340 x_find_topmost_parent and set the property there also (bug#9181).
3341 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3342
c74e9d86
PE
33432011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 * callproc.c (Fcall_process): Avoid vfork clobbering
3346 the local vars buffer, coding_systems, current_dir.
3347
640c8776
SM
33482011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3349
3350 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3351
f26d0e4c
PE
33522011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3353
8a10d76c
PE
3354 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3355 so that it is not optimized away.
3356
f26d0e4c
PE
3357 * xdisp.c (compute_display_string_pos): Remove unused local.
3358
55439c61
EZ
33592011-08-02 Eli Zaretskii <eliz@gnu.org>
3360
3361 Fix slow cursor motion and scrolling in large buffers with
3362 selective display, like Org Mode buffers. (Bug#9218)
3363
3364 * dispextern.h (struct bidi_it): New member disp_prop_p.
3365
3366 * xdisp.c: Remove one-slot cache of display string positions.
3367 (compute_display_string_pos): Accept an additional argument
5e617bc2 3368 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3369 for a display string or property. If found, set DISP_PROP_P
3370 non-zero.
3371
3372 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3373 DISP_PROP_P, and pass it to compute_display_string_pos.
3374 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3375 non-zero. All callers of bidi_fetch_char changed.
3376
fb33fa43
SM
33772011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3378
3379 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3380
b099e063
DM
33812010-12-03 Don March <don@ohspite.net>
3382
3383 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3384 last character M-[char] is translated to ESC [char] (bug#7541).
3385
5cc7f7af
KH
33862011-08-02 Kenichi Handa <handa@m17n.org>
3387
d0fffa3f 3388 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3389
3390 * chartab.c (uniprop_table): Make it non-static.
3391
525d5e6e
EZ
33922011-08-01 Eli Zaretskii <eliz@gnu.org>
3393
3394 * xdisp.c (forward_to_next_line_start): Accept additional argument
3395 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3396 on the newline.
3397 (reseat_at_next_visible_line_start): Use the bidi iterator state
3398 returned by forward_to_next_line_start to restore the state of
3399 it->bidi_it after backing up to previous newline. (Bug#9212)
3400
31011111
AS
34012011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3402
3403 * regex.c (re_comp): Protoize.
3404 (re_exec): Fix return type.
3405 (regexec): Fix type of `ret'. (Bug#9203)
3406
476371c4
PE
34072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3408
e5d76069
PE
3409 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3410 This is needed if max-image-size is a floating-point number.
3411
9a79b20c
AS
34122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3413
3414 * print.c (print_object): Print empty symbol as ##.
3415
3416 * lread.c (read1): Read ## as empty symbol.
3417
d8c2fa78
AA
34182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3419
3420 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3421 setting frame foreground color (Bug#9175).
3422 (x_set_background_color): Likewise.
3423
ffe57a7a
AA
3424 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3425 contents (Bug#9176).
3426 (EmacsTooltip -init): Remove bezels and add shadows to
3427 tooltip windows.
3428
bf3492a5
AA
3429 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3430 or scroll bar (Bug#8470).
3431
d55e9c53
AA
3432 * nsfont.m (nsfont_open): Remove assignment to voffset and
3433 unnecessary vars hshink, expand, hd, full_height, min_height.
3434 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3435
3436 * nsterm.h (nsfont_info): Remove voffset field.
3437
d8c2fa78 34382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3439
3440 Implement strike-through and overline on NextStep (Bug#8863).
3441
3442 * nsfont.m (nsfont_open): Use underline position provided by font,
3443 instead of hard-coded value of 2.
3444 (nsfont_draw): Call ns_draw_text_decoration instead.
3445
3446 * nsterm.h: Add declaration for ns_draw_text_decoration.
3447
3448 * nsterm.m (ns_draw_text_decoration): New function for drawing
3449 underline, overline, and strike-through.
3450 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3451 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3452 accommodate underlining, etc.
4843aac3 3453
4cc60b9b
EZ
34542011-07-28 Eli Zaretskii <eliz@gnu.org>
3455
bc7ece87
EZ
3456 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3457 default.
4cc60b9b 3458
476371c4
PE
34592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3460
66606eea
PE
3461 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3462 Without this fix, if a signal arrives just after memory fills up,
3463 'malloc' might be invoked reentrantly.
3464
476371c4
PE
3465 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3466 In other words, assume that every image size is allowed, on non-X
3467 hosts. This assumption is probably wrong, but it lets Emacs compile.
3468
f3fcc40d
AS
34692011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3470
3471 * regex.c (re_iswctype): Convert return values to boolean.
3472
350c992f
EZ
34732011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3474
3475 * xdisp.c (compute_display_string_pos): Don't use cached display
3476 string position if the buffer had its restriction changed.
3477 (Bug#9184)
3478
5266b4bb
PE
34792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3480
3481 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3482
2573a837 34832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3484
41f55ccd 3485 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3486
39e378da
PE
3487 * bidi.c: Integer size and overflow fixes.
3488 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3489 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3490 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3491 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3492 (bidi_find_other_level_edge):
3493 Use ptrdiff_t instead of EMACS_INT where either will do.
3494 This works better on 32-bit hosts configured --with-wide-int.
3495 (bidi_cache_ensure_space): Check for size-calculation overflow.
3496 Use % rather than repeated addition, for better worst-case speed.
3497 Don't set bidi_cache_size until after xrealloc returns, because it
3498 might not return.
3499 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3500 (bidi_cache_ensure_space): Also check that the bidi cache size
3501 does not exceed that of the largest Lisp string or buffer. See Eli
3502 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3503
5e927815
PE
3504 * alloc.c (__malloc_size_t): Remove.
3505 All uses replaced by size_t. See Andreas Schwab's note
3506 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3507
ca4aa935
PE
3508 * image.c: Improve checking for integer overflow.
3509 (check_image_size): Assume that f is nonnull, since
3510 it is always nonnull in practice. This is one less thing to
3511 worry about when checking for integer overflow later.
3512 (x_check_image_size): New function, which checks for integer
3513 overflow issues inside X.
3514 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3515 This removes the need for a memory_full check.
3516 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3517 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3518 (xbm_read_bitmap_data): Change locals back to 'int', since
3519 their values must fit in 'int'.
3520 (xpm_load_image, png_load, tiff_load):
3521 Invoke x_create_x_image_and_pixmap earlier,
3522 to avoid much needless work if the image is too large.
3523 (tiff_load): Treat overly large images as if
3524 x_create_x_image_and_pixmap failed, not as malloc failures.
3525 (gs_load): Use x_check_image_size.
3526
5f8f9cc2
PE
3527 * gtkutil.c: Omit integer casts.
3528 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3529 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3530
5adf60bc
PE
3531 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3532
c8907a93
PE
3533 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3534 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3535 would wrongly return t on a 64-bit host.
3536
e3c25c68
PE
3537 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3538 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3539 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3540 and therefore cause GCC to emit a bogus diagnostic in some cases.
3541
3f791afe
PE
3542 * image.c: Integer signedness and overflow and related fixes.
3543 This is not an exhaustive set of fixes, but it's time to
3544 record what I've got.
3545 (lookup_pixel_color, check_image_size): Remove redundant decls.
3546 (check_image_size): Don't assume that arbitrary EMACS_INT values
3547 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3548 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3549 (tiff_load, imagemagick_load_image):
3550 Check for overflow in size calculations.
3551 (x_create_x_image_and_pixmap): Remove unnecessary test for
3552 xmalloc returning NULL; that can't happen.
3553 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3554 (xpm_color_bucket): Use better integer hashing function.
3555 (xpm_cache_color): Don't possibly over-allocate memory.
3556 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3557 (gif_memory_source):
3558 Use ptrdiff_t, not int or size_t, to record sizes.
3559 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3560 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3561 either works, as we prefer signed integers.
3562 (tiff_read_from_memory, tiff_write_from_memory):
3563 Return tsize_t, not size_t, since that's what the TIFF API wants.
3564 (tiff_read_from_memory): Don't fail simply because the read would
3565 go past EOF; instead, return a short read.
3566 (tiff_load): Omit no-longer-needed casts.
3567 (Fimagemagick_types): Don't assume size fits into 'int'.
3568
3cc5a532
PE
3569 Improve hashing quality when configured --with-wide-int.
3570 * fns.c (hash_string): New function, taken from sxhash_string.
3571 Do not discard information about ASCII character case; this
3572 discarding is no longer needed.
3573 (sxhash-string): Use it. Change sig to match it. Caller changed.
3574 * lisp.h: Declare it.
3575 * lread.c (hash_string): Remove, since we now use fns.c's version.
3576 The fns.c version returns a wider integer if --with-wide-int is
3577 specified, so this should help the quality of the hashing a bit.
3578
b312a492
PE
3579 * emacs.c: Integer overflow minor fix.
3580 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3581 Define only if GNU_LINUX.
3582 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3583
dfd153ae
PE
3584 * dispnew.c: Integer signedness and overflow fixes.
3585 Remove unnecessary forward decls, that were a maintenance hassle.
3586 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3587 All uses changed.
3588 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3589 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3590 (prepare_desired_row, line_draw_cost):
3591 Use int, not unsigned, where either works.
3592 (save_current_matrix, restore_current_matrix):
3593 Use ptrdiff_t, not size_t, where either works.
3594 (init_display): Check for overflow more accurately, and without
3595 relying on undefined behavior.
3596
a81d11a3
PE
3597 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3598 Remove, replacing with the new symbols in lisp.h. All uses changed.
3599 * fileio.c (make_temp_name):
3600 * filelock.c (lock_file_1, lock_file):
3601 * xdisp.c (message_dolog):
3602 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3603 Use pMd etc. instead.
3604 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3605 replacing the pWIDE etc. symbols removed from editfns.c.
3606
3300e6fd
PE
3607 * keyboard.h (num_input_events): Now uintmax_t.
3608 This is (very slightly) less likely to mess up due to wraparound.
3609 All uses changed.
3610
fd05c7e9
PE
3611 * buffer.c: Integer signedness fixes.
3612 (alloc_buffer_text, enlarge_buffer_text):
3613 Use ptrdiff_t rather than size_t when either will do, as we prefer
3614 signed integers.
3615
903fe15d
PE
3616 * alloc.c: Integer signedness and overflow fixes.
3617 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3618 (__malloc_size_t): Default to size_t, not to int.
3619 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3620 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3621 Prefer ptrdiff_t to size_t when either would do, as we prefer
3622 signed integers.
3623 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3624 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3625 Now const. Initialize with values that are in range even if char
3626 is signed.
3627 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3628 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3629 These functions do the right thing with sizes > 2**32.
3630 (check_depth): Now ptrdiff_t, not int.
3631 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3632 Adjust to new way of storing sizes. Check for size overflow bugs
3633 in rest of code.
3634 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3635 slightly wrong anyway, as it missed one instance of
3636 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3637 (refill_memory_reserve): Omit needless cast to size_t.
3638 (mark_object_loop_halt): Mark as externally visible.
3639
ac82cc6a
PE
3640 * xselect.c: Integer signedness and overflow fixes.
3641 (Fx_register_dnd_atom, x_handle_dnd_message):
3642 Use ptrdiff_t, not size_t, since we prefer signed.
3643 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3644 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3645 x_dnd_atoms_size and x_dnd_atoms_length.
3646
c2d1e36d
PE
3647 * doprnt.c: Prefer signed to unsigned when either works.
3648 * eval.c (verror):
3649 * doprnt.c (doprnt):
3650 * lisp.h (doprnt):
3651 * xdisp.c (vmessage):
3652 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3653 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3654 prefer signed arithmetic to avoid comparison confusion.
3655 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3656 but is a bit tricky.
3657
0e926e56
PE
3658 Assume freestanding C89 headers, string.h, stdlib.h.
3659 * data.c, doprnt.c, floatfns.c, print.c:
3660 Include float.h unconditionally.
3661 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3662 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3663 * regex.c: Likewise for stddef.h, string.h.
3664 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3665 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3666 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3667 (STDC_HEADERS): Remove obsolete defines.
3668 * sysdep.c: Include limits.h unconditionally.
3669
9cfdb3ec
PE
3670 Assume support for memcmp, memcpy, memmove, memset.
3671 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3672 * regex.c (memcmp, memcpy):
3673 Remove; we assume C89 now.
3674
3675 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3676 (__malloc_safe_bcopy): Remove; no longer needed.
3677
cf950e6b 3678 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3679 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3680 well either way, and we prefer signed to unsigned.
3681
dbf38e02
LMI
36822011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3683
3684 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3685 closes the connection while we're reading (bug#9182).
3686
d6f0886c 36872011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3688
d6f0886c
JD
3689 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3690 are specified (Bug#9168).
24e0f6b1 3691
2eb1f9e6
PE
36922011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3693
3694 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3695 Found by GCC static checking and --with-wide-int on a 32-bit host.
3696
22381272 36972011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3698
3699 * xdisp.c (compute_display_string_pos): Fix logic of caching
3700 previous display string position. Initialize cached_prev_pos to
3701 -1. Fixes slow-down at the beginning of a buffer.
3702
f25e39b4
EZ
37032011-07-24 Eli Zaretskii <eliz@gnu.org>
3704
3705 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3706 for attrs[LFACE_FONTSET_INDEX].
3707
04c4b52e
PE
37082011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3709
3710 * xml.c (parse_region): Remove unused local
3711 that was recently introduced.
3712
c1734fbd
EZ
37132011-07-23 Eli Zaretskii <eliz@gnu.org>
3714
be18c5a5
EZ
3715 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3716 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3717
c1734fbd
EZ
3718 * xdisp.c (move_it_in_display_line_to): Record the best matching
3719 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3720 exit if none of the characters scanned was an exact match.
3721 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3722 when exact match is impossible due to invisible text, and the
3723 lines are truncated.
3724
a258d627
JD
37252011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3726
3727 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3728 for OSX >= 10.7.
3729
b6d5a689
EZ
37302011-07-22 Eli Zaretskii <eliz@gnu.org>
3731
0f74f785
EZ
3732 Fix a significant slow-down of cursor motion with C-n, C-p,
3733 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3734 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3735 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3736 (next_element_from_buffer): Call compute_stop_pos_backwards to
3737 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3738 base_level_stop.
3739 (reseat): Don't look for prev_stop, as that could mean a very long
3740 run.
3741 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3742 <cached_disp_overlay_modiff>: Cache for last found display string
3743 position.
551918c1 3744 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3745 about the same buffer in the same area of character positions, and
3746 the buffer wasn't changed since the time the display string
3747 position was cached.
551918c1 3748
b2d0c91a
EZ
37492011-07-22 Eli Zaretskii <eliz@gnu.org>
3750
3751 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3752 is an integer, which is important for empty lines. (Bug#9149)
3753
043604ee
CY
37542011-07-22 Chong Yidong <cyd@stupidchicken.com>
3755
3756 * frame.c (Fmodify_frame_parameters): In tty case, update the
3757 default face if necessary (Bug#4238).
3758
da4adb04
CY
37592011-07-21 Chong Yidong <cyd@stupidchicken.com>
3760
3761 * editfns.c (Fstring_to_char): No need to explain what a character
3762 is in the docstring (Bug#6576).
3763
9abd0532
LMI
37642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3765
3766 * xml.c (parse_region): Make sure we always return a tree.
3767
36881d16
HK
37682011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3769
3770 * xml.c (parse_region): If a document contains only comments,
3771 return that, too.
3772
1e98674d
LMI
37732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3774
3775 * xml.c (make_dom): Return comments, too.
3776
590bd467
PE
37772011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3778
3779 Port to OpenBSD.
3780 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3781 and the surrounding thread.
3782 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3783 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3784 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3785 timer goes off.
3786 * s/openbsd.h (BROKEN_SIGIO): Define.
3787 * unexelf.c (unexec) [__OpenBSD__]:
3788 Don't update the .mdebug section of the Alpha COFF symbol table.
3789
f41628b2
LMI
37902011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3791
3792 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3793 (bug#8460).
3794
b59b67c5
PE
37952011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3796
15e3a074
PE
3797 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3798 This fixes some race conditions on the permissions of any newly
3799 created file.
3800
41bed37d
PE
3801 * alloc.c (valid_pointer_p): Use pipe, not open.
3802 This fixes some permissions issues when debugging.
3803
b59b67c5
PE
3804 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3805 If fchown fails to set both uid and gid, try to set just gid,
3806 as that is sometimes allowed. Adjust the file's mode to eliminate
3807 setuid or setgid bits that are inappropriate if fchown fails.
3808
925a6be7
SM
38092011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3810
3811 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3812 to compare Lisp_Objects.
3813 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3814 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3815 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3816
52968808
AS
38172011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3818
0a6a104b
AS
3819 * lread.c (read_integer): Unread even EOF character.
3820 (read1): Likewise. Properly record start position of symbol.
3821
52968808
AS
3822 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3823 symbol character follows.
3824
9e381cdd
PE
38252011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3826
3827 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3828 This works around a problem with the previous change to Fcopy_file.
3829 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3830 and without this change, GCC might complain about discarding
3831 fchown's return value.
3832
b5641435
JB
38332011-07-16 Juanma Barranquero <lekktu@gmail.com>
3834
3835 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3836
a8031457
PE
38372011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3838
3839 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3840
dd889327
LMI
38412011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3842
750c33f7
LMI
3843 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3844 it's used from the C level.
3845
dd889327
LMI
3846 * process.c: Use the same condition for POLL_FOR_INPUT in both
3847 keyboard.c and process.c (bug#1858).
3848
87e86684
LM
38492011-07-09 Lawrence Mitchell <wence@gmx.li>
3850
3851 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3852 (Fgnutls_boot): Use it.
3853
64348f40
AS
38542011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3855
3856 * doc.c (Fsubstitute_command_keys): Revert last change.
3857
1d698799
LMI
38582011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3859
f863868c
LMI
3860 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3861 quotes the next character, and doesn't affect other longer
3862 sequences (bug#8935).
3863
1d698799
LMI
3864 * lread.c (syms_of_lread): Clarify that is isn't only
3865 `eval-buffer' and `eval-defun' that's affected by
3866 `lexical-binding' (bug#8460).
3867
aa4b6df6
EZ
38682011-07-15 Eli Zaretskii <eliz@gnu.org>
3869
3870 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3871 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3872
5d856da6
PE
38732011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3874
ad6042bb
PE
3875 Fix minor problems found by static checking.
3876 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3877 (elsz): Now a signed constant, not a size_t var. We prefer signed
3878 types to unsigned, to avoid integer comparison confusion. Without
3879 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3880 "cannot optimize loop, the loop counter may overflow", a symptom
3881 of the confusion.
f00bbb22 3882 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3883 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3884
6468f31c
LMI
38852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3886
49080b10
LMI
3887 * search.c (Fre_search_backward): Mention `case-fold-search' in
3888 all the re_search_* functions (bug#8138).
3889
6468f31c
LMI
3890 * keyboard.c (Fopen_dribble_file): Document when the file is
3891 closed (bug#8056).
3892
c965adc5
EZ
38932011-07-14 Eli Zaretskii <eliz@gnu.org>
3894
df9733bf
EZ
3895 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3896 bidi_cache_idx.
3897
0bb23927
EZ
3898 Support bidi reordering of display and overlay strings.
3899 * xdisp.c (compute_display_string_pos)
3900 (compute_display_string_end): Accept additional argument STRING.
3901 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3902 (reseat_to_string): Initialize bidi_it->string.s and
3903 bidi_it->string.schars.
3904 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3905 NULL (avoids a crash in bidi_paragraph_init).
3906 Initialize itb.string.lstring.
0bb23927
EZ
3907 (init_iterator): Call bidi_init_it only of a valid
3908 buffer position was specified. Initialize paragraph_embedding to
3909 L2R.
3910 (reseat_to_string): Initialize the bidi iterator.
3911 (display_string): If we need to ignore text properties of
3912 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3913 original value of -1 will not work with bidi.)
3914 (compute_display_string_pos): First arg is now struct
3915 `text_pos *'; all callers changed. Support display properties on
3916 Lisp strings.
3917 (compute_display_string_end): Support display properties on Lisp
3918 strings.
3919 (init_iterator, reseat_1, reseat_to_string): Initialize the
3920 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3921 when iterating on a string not from display properties).
640c8776
SM
3922 (compute_display_string_pos, compute_display_string_end):
3923 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3924 arrow keys.
3925 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3926 base_level_stop; instead, set base_level_stop to BEGV.
3927 Fixes crashes in vertical-motion.
0bb23927
EZ
3928 (next_element_from_buffer): Improve commentary for when
3929 the iterator is before prev_stop.
3930 (init_iterator): Initialize bidi_p from the default value of
3931 bidi-display-reordering, not from buffer-local value. Use the
3932 buffer-local value only if initializing for buffer iteration.
3933 (handle_invisible_prop): Support invisible properties on strings
3934 that are being bidi-reordered.
3935 (set_iterator_to_next): Support bidi reordering of C strings and
3936 Lisp strings.
3937 (next_element_from_string): Support bidi reordering of Lisp
3938 strings.
3939 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3940 (display_string): Support display of R2L glyph rows.
3941 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3942 (init_iterator): Don't initialize it->bidi_p for strings
3943 here.
3944 (reseat_to_string): Initialize it->bidi_p for strings here.
3945 (next_element_from_string, next_element_from_c_string)
3946 (next_element_from_buffer): Add xassert's for correspondence
3947 between IT's object being iterated and it->bidi_it.string
3948 structure.
3949 (face_before_or_after_it_pos): Support bidi iteration.
3950 (next_element_from_c_string): Handle the case of the first string
3951 character that is not the first one in the visual order.
3952 (get_visually_first_element): New function, refactored from common
3953 parts of next_element_from_buffer, next_element_from_string, and
3954 next_element_from_c_string.
3955 (tool_bar_lines_needed, redisplay_tool_bar)
3956 (display_menu_bar): Force left-to-right direction. Add a FIXME
3957 comment for making that be controlled by a user option.
3958 (push_it, pop_it): Save and restore the state of the
3959 bidi iterator. Save and restore the bidi_p flag.
3960 (pop_it): Iterate out of display property for string iteration as
3961 well.
3962 (iterate_out_of_display_property): Support iteration over strings.
3963 (handle_single_display_spec): Set up it->bidi_it for iteration
3964 over a display string, and call bidi_init_it.
3965 (handle_single_display_spec, next_overlay_string)
3966 (get_overlay_strings_1, push_display_prop): Set up the bidi
3967 iterator for displaying display or overlay strings.
3968 (forward_to_next_line_start): Don't use the shortcut if
3969 bidi-iterating.
3970 (back_to_previous_visible_line_start): If handle_display_prop
3971 pushed the iterator stack, restore the internal state of the bidi
3972 iterator by calling bidi_pop_it same number of times.
3973 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3974 and we are bidi-iterating, don't decrement the iterator position;
3975 instead, set the first_elt flag in the bidi iterator, to produce
3976 the same effect.
3977 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3978 (push_display_prop): xassert that we are iterating a buffer.
3979 (push_it, pop_it): Save and restore paragraph_embedding member.
3980 (handle_single_display_spec, next_overlay_string)
3981 (get_overlay_strings_1, reseat_1, reseat_to_string)
3982 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3983 correctly. Don't assume unibyte strings are not bidi-reordered.
3984 (compute_display_string_pos)
3985 (compute_display_string_end): Fix handling the case of C string.
3986 (push_it, pop_it): Save and restore from_disp_prop_p.
3987 (handle_single_display_spec, push_display_prop): Set the
3988 from_disp_prop_p flag.
3989 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3990 (pop_it): Call iterate_out_of_display_property only if we are
3991 popping after iteration over a string that came from a display
3992 property. Fix a typo in popping stretch info. Add an assertion
3993 for verifying that the iterator position is in sync with the bidi
3994 iterator.
3995 (handle_single_display_spec, get_overlay_strings_1)
3996 (push_display_prop): Fix initialization of paragraph direction for
3997 string when that of the parent object is not yet determined.
3998 (reseat_1): Call bidi_init_it to resync the bidi
3999 iterator with IT's position. (Bug#7616)
4000 (find_row_edges): If ROW->start.pos gives position
4001 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4002 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4003 Reset the from_disp_prop_p flag.
4004 (SAVE_IT, RESTORE_IT): New macros.
4005 (pos_visible_p, face_before_or_after_it_pos)
4006 (back_to_previous_visible_line_start)
4007 (move_it_in_display_line_to, move_it_in_display_line)
4008 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4009 (try_scrolling, redisplay_window, display_line): Use them when
4010 saving a temporary copy of the iterator and restoring it back.
4011 (back_to_previous_visible_line_start, reseat_1)
4012 (init_iterator): Empty the bidi cache "stack".
4013 (move_it_in_display_line_to): If iterator ended up at
4014 EOL, but we never saw any buffer positions smaller than
4015 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4016 motion in bidi-reordered lines.
4017 (move_it_in_display_line_to): Record prev_method and prev_pos
4018 immediately before the call to set_iterator_to_next. Fixes cursor
4019 motion in bidi-reordered lines with stretch glyphs and strings
4020 displayed in margins. (Bug#8133) (Bug#8867)
4021 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4022 TO_CHARPOS.
640c8776
SM
4023 (pos_visible_p): Support positions in bidi-reordered lines.
4024 Save and restore bidi cache.
0bb23927
EZ
4025
4026 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4027 (bidi_paragraph_info): Delete unused struct.
4028 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4029 (bidi_cache_start): New variable.
4030 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4031 to zero.
4032 (bidi_cache_fetch_state, bidi_cache_search)
4033 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4034 (bidi_cache_find, bidi_peek_at_next_level)
4035 (bidi_level_of_next_char, bidi_find_other_level_edge)
4036 (bidi_move_to_visually_next): Compare cache index with
4037 bidi_cache_start rather than with zero.
4038 (bidi_fetch_char): Accept new argument STRING; all callers
4039 changed. Support iteration over a string. Support strings with
4040 display properties. Support unibyte strings. Fix the type of
4041 `len' according to what STRING_CHAR_AND_LENGTH expects.
4042 (bidi_paragraph_init, bidi_resolve_explicit_1)
4043 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4044 (bidi_level_of_next_char, bidi_move_to_visually_next):
4045 Support iteration over a string.
0bb23927
EZ
4046 (bidi_set_sor_type, bidi_resolve_explicit_1)
4047 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4048 can now be zero (for strings); special values 0 and -1 were
4049 changed to -1 and -2, respectively.
4050 (bidi_char_at_pos): New function.
4051 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4052 Call it instead of FETCH_MULTIBYTE_CHAR.
4053 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4054 initialized to valid values.
4055 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4056 values.
4057 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4058 the test for valid cached positions. Fix the logic for looking up
4059 the sentinel state in the cache. GCPRO the Lisp string we are
4060 iterating.
4061 (bidi_push_it, bidi_pop_it): New functions.
4062 (bidi_initialize): Initialize the bidi cache start stack pointer.
4063 (bidi_cache_ensure_space): New function, refactored from part of
4064 bidi_cache_iterator_state. Don't assume the required size is just
4065 one BIDI_CACHE_CHUNK away.
4066 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4067 (bidi_count_bytes, bidi_char_at_pos): New functions.
4068 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4069 always valid if bidi_cache_idx is valid.
4070 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4071 is valid if it's going to be used.
4072 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4073 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4074 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4075 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4076 (bidi_find_other_level_edge, bidi_cache_start_stack):
4077 All variables related to cache indices are now EMACS_INT.
c965adc5 4078
0bb23927
EZ
4079 * dispextern.h (struct bidi_string_data): New structure.
4080 (struct bidi_it): New member `string'. Make flag members be 1-bit
4081 fields, and put them last in the struct.
640c8776
SM
4082 (compute_display_string_pos, compute_display_string_end):
4083 Update prototypes.
0bb23927
EZ
4084 (bidi_push_it, bidi_pop_it): Add prototypes.
4085 (struct iterator_stack_entry): New members bidi_p,
4086 paragraph_embedding, and from_disp_prop_p.
4087 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4088 (bidi_shelve_cache, bidi_unshelve_cache):
4089 Declare prototypes.
0bb23927
EZ
4090
4091 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4092 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4093 and vector-like objects.
4094
4095 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4096 cache around display iteration.
4097
4098 * window.c (Fwindow_end, window_scroll_pixel_based)
4099 (displayed_window_lines, Frecenter): Save and restore the bidi
4100 cache around display iteration.
4101
3bbd2265
LMI
41022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4103
4104 * editfns.c (Fdelete_region): Clarify the use of the named
4105 parameters (bug#6788).
4106
adc47434
MR
41072011-07-14 Martin Rudalics <rudalics@gmx.at>
4108
4109 * indent.c (Fvertical_motion): Set and restore w->pointm when
4110 saving and restoring the window's buffer (Bug#9006).
4111
837c31f8
LMI
41122011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4113
4114 * editfns.c (Fstring_to_char): Clarify just what is returned
4115 (bug#6576). Text by Eli Zaretskii.
4116
ac389d0c
JB
41172011-07-13 Juanma Barranquero <lekktu@gmail.com>
4118
4119 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4120
0be0ce47
EZ
41212011-07-13 Eli Zaretskii <eliz@gnu.org>
4122
4123 * buffer.c (mmap_find): Fix a typo.
4124
cd18e7e3
JB
41252011-07-13 Johan Bockgård <bojohan@gnu.org>
4126
4127 Fix execution of x selection hooks.
4128 * xselect.c (Qx_lost_selection_functions)
4129 (Qx_sent_selection_functions): New vars.
4130 (syms_of_xselect): DEFSYM them.
4131 (x_handle_selection_request): Pass Qx_sent_selection_functions
4132 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4133 (x_handle_selection_clear,x_clear_frame_selections):
4134 Pass Qx_lost_selection_functions rather than
4135 Vx_lost_selection_functions to Frun_hook_with_args.
4136
47ea7f44
PE
41372011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4138
ac389d0c 4139 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4140 The old code sometimes used this field without initializing it.
4141
47ea7f44
PE
4142 * alloc.c (gc_sweep): Don't read past end of array.
4143 In theory, the old code could also have corrupted Emacs internals,
4144 though it'd be very unlikely.
4145
bc985c87
AS
41462011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4147
4148 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4149 argument. (Bug#4026)
bc985c87 4150
0cf34688
LMI
41512011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4152
b3dadd76
LMI
4153 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4154 key" (bug#4257).
4155
0cf34688
LMI
4156 * window.c (Fset_window_start): Doc fix (bug#4199).
4157 (Fset_window_hscroll): Ditto.
4158
270768cd
PE
41592011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4160
077e3dda 4161 Fix minor new problems caught by GCC 4.6.1.
270768cd 4162 * term.c (init_tty): Remove unused local.
490011a6 4163 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4164 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4165 not used otherwise.
270768cd 4166
b1f58454
CY
41672011-07-12 Chong Yidong <cyd@stupidchicken.com>
4168
4169 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4170
22b9578d
LMI
41712011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4172
6e70ab07
LMI
4173 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4174 are the mini-buffer and the echo area (bug#3320).
4175
22b9578d
LMI
4176 * term.c (init_tty): Remove support for supdup, c10 and perq
4177 terminals, which are no longer supported (bug#1482).
4178
8974cc9f
JB
41792011-07-10 Johan Bockgård <bojohan@gnu.org>
4180
4181 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4182
a560d974
JD
41832011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4184
4185 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4186 for non-popups (Bug#3642).
4187
1dae0f0a
AS
41882011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4189
268c2c36 4190 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4191 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4192 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4193 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4194 * data.c (fmod): Likewise.
4195 * dispnew.c (swap_glyphs_in_rows): Likewise.
4196 * emacs.c (memory_warning_signal): Likewise.
4197 * floatfns.c (float_error): Likewise.
4198 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4199 (otf_open, font_otf_capability, generate_otf_features)
4200 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4201 Likewise.
4202 * image.c (pbm_read_file): Likewise.
4203 * indent.c (string_display_width): Likewise.
4204 * intervals.c (check_for_interval, search_for_interval)
4205 (inc_interval_count, count_intervals, root_interval)
4206 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4207 * lread.c (defalias): Likewise.
268c2c36 4208 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4209 * regex.c (set_image_of_range_1, set_image_of_range)
4210 (regex_grow_registers): Likewise.
4211 * sysdep.c (strerror): Likewise.
4212 * termcap.c (valid_filename_p, tprint, main): Likewise.
4213 * tparam.c (main): Likewise.
4214 * unexhp9k800.c (run_time_remap, save_data_space)
4215 (update_file_ptrs, read_header, write_header, calculate_checksum)
4216 (copy_file, copy_rest, display_header): Likewise.
4217 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4218 Likewise.
4219 * xdisp.c (check_it): Likewise.
4220 * xfaces.c (register_color, unregister_color, unregister_colors):
4221 Likewise.
4222 * xfns.c (print_fontset_result): Likewise.
4223 * xrdb.c (member, fatal, main): Likewise.
4224
99033785
PE
42252011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4226
4227 Fix minor problems found by static checking (Bug#9031).
4228 * chartab.c (char_table_set_range, map_sub_char_table):
4229 Remove unused locals.
4230 (uniprop_table): Now static.
4231 * composite.c (_work_char): Remove unused static var.
4232
9cb2ac56
JB
42332011-07-09 Juanma Barranquero <lekktu@gmail.com>
4234
4235 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4236
f25661f0
JD
42372011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4238
4239 * gtkutil.c (qttip_cb): Remove code without function.
4240
8278c4fe
EZ
42412011-07-09 Eli Zaretskii <eliz@gnu.org>
4242
4243 * w32.c (pthread_sigmask): New stub.
4244
1692ae2d 42452011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4246
8a6ebd58 4247 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4248 sigprocmask is portable only for single-threaded applications, and
4249 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4250 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4251 (LIBES): Use it.
4252 * callproc.c (Fcall_process):
4253 * process.c (create_process):
4254 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4255 Use pthread_sigmask, not sigprocmask.
123403e4 4256
1b854618
JD
42572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4258
4259 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4260 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4261 wrong (Bug#8591).
4262
3fe4b549
JD
42632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4264
0ce7e563
JD
4265 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4266 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4267 (xg_hide_tooltip): Fix comment.
4268
3fe4b549
JD
4269 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4270 in registerServicesMenuSendTypes.
4271 (validRequestorForSendType): Don't check ns_return_types.
4272
4273 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4274 ns_return_type.
4275
5df75e47
JR
42762011-07-08 Jason Rumney <jasonr@gnu.org>
4277
22610910
JR
4278 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4279 SH_SHOW for hidden windows (Bug#5482).
4280
5df75e47
JR
4281 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4282 frame struct members of non-existent frames (Bug#6284).
4283
699c10bd
JD
42842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4285
4393663b
JD
4286 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4287 variable firstTime not needed on OSX >= 10.6.
4288 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4289 >= 10.5. Use setKnobProportion, setDoubleValue.
4290
4291 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4292 (MAC_OS_X_VERSION_10_5): Define if not defined.
4293 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4294 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4295 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4296
4297 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4298 cString and lossyCString on OSX >= 10.4
4299
58179cce 4300 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4301 sizeToFit on OSX >= 10.2.
4302
4303 * nsimage.m (allocInitFromFile): Don't use deprecated method
4304 bestRepresentationForDevice on OSX >= 10.6.
4305
4306 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4307 to avoid warning.
4308
4309 * emacs.c: Declare unexec_init_emacs_zone.
4310
a63e0781
JD
4311 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4312
699c10bd
JD
4313 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4314
4315 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4316 on svcsMenu (Bug#8842).
4317
4318 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4319 ns_return_types.
4320 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4321
4322 * nsterm.m (QUTF8_STRING): Declare.
4323 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4324 (validRequestorForSendType): Return type is (id).
4325 Change indexOfObjectIdenticalTo to indexOfObject.
4326 Check if we have local selection before returning self (Bug#8842).
4327 (writeSelectionToPasteboard): Put local selection into paste board
4328 if we have a local selection (Bug#8842).
4329 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4330
4331 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4332 (ns_get_local_selection): Declare.
4333
54e10184
LMI
43342011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4335
9888ff71
LMI
4336 * keymap.c (describe_map_tree): Don't insert a double newline at
4337 the end of the buffer (bug#1169) and return whether we inserted
4338 something.
4339
54e10184
LMI
4340 * callint.c (Fcall_interactively): Change "reading args" to
4341 "providing args" to try to clarify what it does (bug#1010).
4342
15fa4783
KH
43432011-07-07 Kenichi Handa <handa@m17n.org>
4344
4345 * composite.c (composition_compute_stop_pos): Ignore a static
4346 composition starting before CHARPOS (Bug#8915).
4347
4348 * xdisp.c (handle_composition_prop): Likewise.
4349
a8815b00
EZ
43502011-07-07 Eli Zaretskii <eliz@gnu.org>
4351
4352 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4353 (Bug#9015)
4354
ef7b981d 43552011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4356
4357 * character.h (unicode_category_t): New enum type.
4358
4359 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4360 (Qchar_code_property_table): New variable.
4361 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4362 (UNIPROP_COMPRESSED_FORM_P): New macros.
4363 (char_table_ascii): Uncompress the compressed values.
4364 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4365 Uncompress the compressed values.
ac389d0c 4366 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4367 (char_table_ref_and_range): Uncompress the compressed values.
4368 (sub_char_table_set): New arg is_uniprop. Callers changed.
4369 Uncompress the compressed values.
4370 (sub_char_table_set_range): Args changed. Callers changed.
4371 (char_table_set_range): Adjuted for the above change.
4372 (map_sub_char_table): Delete args default_val and parent. Add arg
4373 top. Give decoded values to a Lisp function.
640c8776 4374 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4375 values to a Lisp function. Gcpro more variables.
4376 (uniprop_table_uncompress)
4377 (uniprop_decode_value_run_length): New functions.
4378 (uniprop_decoder, uniprop_decoder_count): New variables.
4379 (uniprop_get_decoder, uniprop_encode_value_character)
4380 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4381 New functions.
4382 (uniprop_encoder, uniprop_encoder_count): New variables.
4383 (uniprop_get_encoder, uniprop_table)
4384 (Funicode_property_table_internal, Fget_unicode_property_internal)
4385 (Fput_unicode_property_internal): New functions.
4386 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4387 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4388 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4389 char-code-property-alist.
4390
640c8776 4391 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4392 Vunicode_category_table.
4393
640c8776 4394 * font.c (font_range): Adjust for the change of
c805dec0
KH
4395 Vunicode_category_table.
4396
76b397fb
DN
43972011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4398
4399 * m/iris4d.h: Remove file, move contents ...
4400 * s/irix6-5.h: ... here.
4401
22b4128e
PE
44022011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4403
4404 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4405 * alloc.c (mark_buffer):
4406 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4407 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4408 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4409 This isn't true in general, and it's particularly not true
4410 if Emacs is configured with --with-wide-int.
4411 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4412 New macros, used in the buffer.c change.
4413
869795d6
JD
44142011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4415
4416 * xsettings.c: Use both GConf and GSettings if both are available.
4417 (store_config_changed_event): Add comment.
4418 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4419 (store_tool_bar_style_changed): New functions.
5e617bc2 4420 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4421 (struct xsettings): Move font inside HAVE_XFT.
4422 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4423 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4424 Move inside HAVE_XFT.
640c8776 4425 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4426 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4427 also.
4428 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4429 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4430 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4431 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4432 (parse_settings): Move check for font inside HAVE_XFT.
4433 (read_settings, apply_xft_settings): Add comment.
4434 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4435 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4436 call store_font_name_changed.
4437 (xft_settings_event): Add comment.
4438 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4439 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4440 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4441 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4442 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4443 (xsettings_get_system_font, xsettings_get_system_normal_font):
4444 Add comment.
869795d6 4445
d8ed26bd
PE
44462011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 Random fixes. E.g., (random) never returned negative values.
4449 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4450 subseconds part to the entropy, as that's a bit more random.
4451 Prefer signed to unsigned, since the signedness doesn't matter and
4452 in general we prefer signed. When given a limit, use a
4453 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4454 latter isn't right if USE_2_TAGS_FOR_INTS.
4455 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4456 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4457
cabf1cac
SM
44582011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4459
4460 * textprop.c (text_property_stickiness):
4461 Obey Vtext_property_default_nonsticky.
4462 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4463 * w32fns.c (syms_of_w32fns):
4464 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4465
6e9b2be9
PE
44662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4467
4468 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4469 This is more efficient than Ffile_directory_p and avoids a minor race.
4470
90186c68
LMI
44712011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4472
7c301272
LMI
4473 * buffer.c (Foverlay_put): Say what the return value is
4474 (bug#7835).
4475
c4f2d8d4
LMI
4476 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4477 is a directory before asking whether to use the file name
4478 (bug#7564).
ad637907
LMI
4479 (barf_or_query_if_file_exists): Make the "File is a directory"
4480 error be more correct.
c4f2d8d4 4481
90186c68
LMI
4482 * fns.c (Frequire): Remove the mention of the .gz files, since
4483 that's installation-specific, but keep the mention of
4484 `get-load-suffixes'.
4485
da64016e
PE
44862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4487
4488 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4489 Report string overflow if the output is too long.
4490
7d47b580
JB
44912011-07-04 Juanma Barranquero <lekktu@gmail.com>
4492
a555cb87
JB
4493 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4494 (syms_of_gnutls): Remove duplicate DEFSYM for
4495 Qgnutls_bootprop_verify_hostname_error, an error for
4496 Qgnutls_bootprop_verify_error (which is no longer used).
4497
7d47b580
JB
4498 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4499 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4500 Also (re)move comments that are misplaced or no longer relevant.
4501
1e49bfab
LMI
45022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4503
4504 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4505
1485f4c0
CY
45062011-07-03 Chong Yidong <cyd@stupidchicken.com>
4507
4508 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4509 and background color parameters if they have been changed.
4510
a9ab721e
LMI
45112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4512
4513 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4514
cf7cff57
PE
45152011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4516
2e13213d
PE
4517 * xsettings.c (SYSTEM_FONT): Define only when used.
4518 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4519
cf7cff57
PE
4520 * keymap.c (access_keymap_1): Now static.
4521
7a8e04f7
CY
45222011-07-02 Chong Yidong <cyd@stupidchicken.com>
4523
4524 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4525 leave any prefix arg for the up event (Bug#1586).
4526
61352f62
LMI
45272011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4528
69bb1ef7
LMI
4529 * lread.c (syms_of_lread): Mention single symbols defined by
4530 `defvar' or `defconst' (bug#7154).
4531
61352f62 4532 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4533 (Frequire): Mention get-load-suffixes.
61352f62 4534
28545e04
MR
45352011-07-02 Martin Rudalics <rudalics@gmx.at>
4536
4537 * window.h (window): Remove clone_number slot.
4538 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4539 Remove.
4540 (make_parent_window, make_window, saved_window)
4541 (Fset_window_configuration, save_window_save): Don't deal with
4542 clone numbers.
4543 * buffer.c (Qclone_number): Remove declaration.
4544 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4545
3349e122
SM
45462011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4547
4548 Add multiple inheritance to keymaps.
4549 * keymap.c (Fmake_composed_keymap): New function.
4550 (Fset_keymap_parent): Simplify.
4551 (fix_submap_inheritance): Remove.
4552 (access_keymap_1): New function extracted from access_keymap to handle
4553 embedded parents and handle lists of maps.
4554 (access_keymap): Use it.
4555 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4556 (Fcopy_keymap): Handle embedded parents.
4557 (Fcommand_remapping, define_as_prefix): Simplify.
4558 (Fkey_binding): Simplify.
4559 (syms_of_keymap): Move minibuffer-local-completion-map,
4560 minibuffer-local-filename-completion-map,
4561 minibuffer-local-must-match-map, and
4562 minibuffer-local-filename-must-match-map to Elisp.
4563 (syms_of_keymap): Defsubr make-composed-keymap.
4564 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4565 (parse_menu_item): Trivial simplification.
4566
3279eb87
GM
45672011-07-01 Glenn Morris <rgm@gnu.org>
4568
4569 * Makefile.in (SETTINGS_LIBS): Fix typo.
4570
4550efdf
KI
45712011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4572
4573 * coding.c (Fencode_coding_string): Record the last coding system
4574 used, as the function doc string says (bug#8738).
4575
0949d2b6
JD
45762011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4577
4578 * xsettings.c (store_monospaced_changed): Take new font as arg and
4579 check for change against current_mono_font.
4580 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4581 (emacs_settings_constructor, emacs_settings_get_property)
4582 (emacs_settings_set_property, emacs_settings_class_init)
4583 (emacs_settings_init, gsettings_obj): Remove.
4584 (something_changedCB): New function for HAVE_GSETTINGS.
4585 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4586 with value as argument.
4587 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4588 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4589 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4590 "changed".
4591
4592 * xgselect.c: Add defined (HAVE_GSETTINGS).
4593 (xgselect_initialize): Ditto.
4594
4595 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4596 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4597 xg_select.
4598
bbc6b304
PE
45992011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4600
4601 * eval.c (struct backtrace): Simplify and port the data structure.
4602 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4603 signed bit field, as this assumption is not portable and it makes
4604 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4605 "char debug_on_exit : 1" as this is not portable either; instead,
4606 use the portable "unsigned int debug_on_exit : 1". Remove unused
4607 member evalargs. Remove obsolete comments about cc bombing out.
4608
9851bfc5
JD
46092011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4610
51bb811f 4611 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4612 Let HAVE_GSETTINGS override HAVE_GCONF.
4613 (store_monospaced_changed): New function.
4614 (EMACS_SETTINGS): A new type derived from GObject to handle
4615 GSettings notifications.
4616 (emacs_settings_constructor, emacs_settings_get_property)
4617 (emacs_settings_set_property, emacs_settings_class_init):
4618 New functions.
4619 (gsettings_client, gsettings_obj): New variables.
4620 (GSETTINGS_SCHEMA): New define.
4621 (something_changedCB): Call store_monospaced_changed.
4622 (init_gsettings): New function.
4623 (xsettings_initialize): Call init_gsettings.
4624 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4625 to NULL.
4626
640c8776 4627 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4628 GCONF_CFLAGS/LIBS.
4629
5386012d
MR
46302011-06-29 Martin Rudalics <rudalics@gmx.at>
4631
4632 * window.c (resize_root_window, grow_mini_window)
4633 (shrink_mini_window): Rename Qresize_root_window to
4634 Qwindow_resize_root_window and Qresize_root_window_vertically to
4635 Qwindow_resize_root_window_vertically.
4636
f13e0b08
PE
46372011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4638
4639 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4640
94515237
JB
46412011-06-27 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * makefile.w32-in: Redesign dependencies so they reflect more
4644 clearly which files are directly included by each source file,
4645 and not through other includes.
4646
e43b6e43
MR
46472011-06-27 Martin Rudalics <rudalics@gmx.at>
4648
4649 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4650 (sort_overlays, overlay_strings): When an overlay's clone number
4651 matches the window's clone number process the overlay even if
4652 the overlay's window property doesn't match the current window.
4653
d68443dc
MR
4654 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4655 (Fwindow_hchild): Rename to Fwindow_left_child.
4656 (Fwindow_next): Rename to Fwindow_next_sibling.
4657 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4658 (resize_window_check): Rename to window_resize_check.
4659 (resize_window_apply): Rename to window_resize_apply.
4660 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4661 (Fdelete_other_windows_internal, resize_frame_windows)
4662 (Fsplit_window_internal, Fdelete_window_internal)
4663 (grow_mini_window, shrink_mini_window)
4664 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4665
c7e73be5
JD
46662011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4667
4668 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4669 (emacs_fixed_set_min_size): Remove.
4670 (emacs_fixed_new): Take frame as argument.
4671
4672 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4673 (_EmacsFixedPrivate): Remove minwidth/height.
4674 Add struct frame *f.
4675 (emacs_fixed_init): Initialize priv->f.
4676 (get_parent_class, emacs_fixed_set_min_size): Remove.
4677 (emacs_fixed_new): Set priv->f to argument.
4678 (emacs_fixed_get_preferred_width)
4679 (emacs_fixed_get_preferred_height): Use min_width/height from
4680 frames size_hint to set minimum and natural (Bug#8919).
4681 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4682 and use min_width/height from frames size_hint to set
4683 min_width/height (Bug#8919).
4684
4685 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4686 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4687 Fix indentation.
c7e73be5 4688
cf99dcf8
EZ
46892011-06-26 Eli Zaretskii <eliz@gnu.org>
4690
4691 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4692 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4693 called at ZV.
4694
029529ac
CY
46952011-06-26 Chong Yidong <cyd@stupidchicken.com>
4696
4697 * process.c (wait_reading_process_output): Bypass select if
4698 waiting for a cell while ignoring keyboard input, and input is
4699 pending. Suggested by Jan Djärv (Bug#8869).
4700
7a7ef429
PE
47012011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4702
4703 Use gnulib's dup2 module instead of rolling our own.
4704 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4705
11fdef7d 47062011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4707
4708 * dispnew.c (scrolling_window): Before scrolling, turn off a
4709 mouse-highlight in the window being scrolled.
4710
cd3520a4
JB
47112011-06-24 Juanma Barranquero <lekktu@gmail.com>
4712
4713 Move DEFSYM to lisp.h and use everywhere.
4714
4715 * character.h (DEFSYM): Move declaration...
4716 * lisp.h (DEFSYM): ...here.
4717
4718 * gnutls.c:
4719 * minibuf.c:
4720 * w32menu.c:
4721 * w32proc.c:
4722 * w32select.c: Don't include character.h.
4723
4724 * alloc.c (syms_of_alloc):
4725 * buffer.c (syms_of_buffer):
4726 * bytecode.c (syms_of_bytecode):
4727 * callint.c (syms_of_callint):
4728 * casefiddle.c (syms_of_casefiddle):
4729 * casetab.c (init_casetab_once):
4730 * category.c (init_category_once, syms_of_category):
4731 * ccl.c (syms_of_ccl):
4732 * cmds.c (syms_of_cmds):
4733 * composite.c (syms_of_composite):
4734 * dbusbind.c (syms_of_dbusbind):
4735 * dired.c (syms_of_dired):
4736 * dispnew.c (syms_of_display):
4737 * doc.c (syms_of_doc):
4738 * editfns.c (syms_of_editfns):
4739 * emacs.c (syms_of_emacs):
4740 * eval.c (syms_of_eval):
4741 * fileio.c (syms_of_fileio):
4742 * fns.c (syms_of_fns):
4743 * frame.c (syms_of_frame):
4744 * fringe.c (syms_of_fringe):
4745 * insdel.c (syms_of_insdel):
4746 * keymap.c (syms_of_keymap):
4747 * lread.c (init_obarray, syms_of_lread):
4748 * macros.c (syms_of_macros):
4749 * msdos.c (syms_of_msdos):
4750 * print.c (syms_of_print):
4751 * process.c (syms_of_process):
4752 * search.c (syms_of_search):
4753 * sound.c (syms_of_sound):
4754 * syntax.c (init_syntax_once, syms_of_syntax):
4755 * terminal.c (syms_of_terminal):
4756 * textprop.c (syms_of_textprop):
4757 * undo.c (syms_of_undo):
4758 * w32.c (globals_of_w32):
4759 * window.c (syms_of_window):
4760 * xdisp.c (syms_of_xdisp):
4761 * xfaces.c (syms_of_xfaces):
4762 * xfns.c (syms_of_xfns):
4763 * xmenu.c (syms_of_xmenu):
4764 * xsettings.c (syms_of_xsettings):
4765 * xterm.c (syms_of_xterm): Use DEFSYM.
4766
4228cf16
TZ
47672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4768
cd3520a4 4769 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4770
7fcccf1e
PE
47712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4772
7efb4e0e
PE
4773 Integer and buffer overflow fixes (Bug#8873).
4774
ff5844ad
PE
4775 * print.c (printchar, strout): Check for string overflow.
4776 (PRINTPREPARE, printchar, strout):
4777 Don't set size unless allocation succeeds.
4778
90532f02
PE
4779 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4780 for sizes. Check for string overflow more accurately.
4781 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4782
6d84508d
PE
4783 * macros.c: Integer and buffer overflow fixes.
4784 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4785 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4786 Use ptrdiff_t, not int, for sizes.
4787 Don't increment bufsize until after realloc succeeds.
4788 Check for size-calculation overflow.
4789 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4790
437b2cb4
PE
4791 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4792
8b9ac8b4
PE
4793 * lread.c: Integer overflow fixes.
4794 (read_integer): Radix is now EMACS_INT, not int,
4795 to improve quality of diagnostics for out-of-range radices.
4796 Calculate buffer size correctly for out-of-range radices.
4797 (read1): Check for integer overflow in radices, and in
4798 read-circle numbers.
82cb60d3
PE
4799 (read_escape): Avoid int overflow.
4800 (Fload, openp, read_buffer_size, read1)
4801 (substitute_object_recurse, read_vector, read_list, map_obarray):
4802 Use ptrdiff_t, not int, for sizes.
4803 (read1): Use EMACS_INT, not int, for sizes.
20270765 4804 Check for size overflow.
8b9ac8b4 4805
7fcccf1e
PE
4806 * image.c (cache_image): Check for size arithmetic overflow.
4807
bfbbd7e7
PE
4808 * lread.c: Integer overflow issues.
4809 (saved_doc_string_size, saved_doc_string_length)
4810 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4811 Now ptrdiff_t, not int.
4812 (read1): Don't assume doc string length fits in int. Check for
4813 out-of-range doc string lengths.
4814 (read_list): Don't assume file position fits in int.
39019e54 4815 (read_escape): Check for hex character overflow.
bfbbd7e7 4816
4e323265
LL
48172011-06-22 Leo Liu <sdl.web@gmail.com>
4818
4819 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4820 Move to minibuffer.el.
4821
85fece3e
PE
48222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4823
20b84ce9 4824 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4825 The following patches are for when GLYPH_DEBUG && !XASSERT.
4826 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4827 * dispnew.c (flush_stdout):
4828 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4829 Mark as externally visible.
4830 * dispnew.c (check_window_matrix_pointers): Now static.
4831 * dispnew.c (window_to_frame_vpos):
4832 * xfns.c (unwind_create_frame):
4833 * xterm.c (x_check_font): Remove unused local.
4834 * scroll.c (CHECK_BOUNDS):
4835 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4836 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4837 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4838 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4839 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4840 Now static.
4841 (debug_method_add): Use va_list and vsprintf rather than relying
4842 on undefined behavior with wrong number of arguments.
4843 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4844 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4845 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4846 since we're not interested in debugging glyphs with old libraries.
4847 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4848 GCC 4.6.0's static checking.
4849
0766b489
PE
48502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4851
31fd4b32
PE
4852 Integer overflow and signedness fixes (Bug#8873).
4853 A few related buffer overrun fixes, too.
4854
b79e8648
PE
4855 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4856
0766b489
PE
4857 * dispextern.h (struct face.stipple):
4858 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4859 (x_bitmap_mask, x_allocate_bitmap_record)
4860 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4861 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4862 (x_create_bitmap_from_xpm_data):
4863 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4864 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4865 (.bitmaps_last):
4866 * xfaces.c (load_pixmap):
4867 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4868 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4869 (.bitmaps_last, struct x_output.icon_bitmap):
4870 Use ptrdiff_t, not int, for bitmap indexes.
4871 (x_allocate_bitmap_record): Check for size overflow.
4872 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4873
b081724f
PE
4874 Use ptrdiff_t, not int, for overlay counts.
4875 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4876 * editfns.c (overlays_around, get_pos_property):
4877 * textprop.c (get_char_property_and_overlay):
4878 * xdisp.c (next_overlay_change, note_mouse_highlight):
4879 * xfaces.c (face_at_buffer_position):
21514da7
PE
4880 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4881 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4882 (Fnext_overlay_change, Fprevious_overlay_change)
4883 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4884 Use ptrdiff_t, not int, for sizes.
21514da7 4885 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4886
3de73e5e
PE
4887 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4888
2606c57b
PE
4889 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4890 (x_session_initialize): Do not assume string length fits in int.
4891
aaafe47a
PE
4892 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4893 This is unlikely, but can occur if DPI is outlandish.
4894
2674ddc8 4895 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4896 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4897
28154962
PE
4898 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4899 * xrdb.c (magic_file_p, search_magic_path):
4900 Omit last arg SUFFIX; it was always 0. All callers changed.
4901 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4902
7de51af5
PE
4903 * xfont.c (xfont_match): Avoid need for strlen.
4904
25ed6cc3
PE
4905 * xfns.c: Don't assume strlen fits in int.
4906 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4907
4eab31dd
PE
4908 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4909 not unsigned long, as we prefer signed integers. All callers changed.
4910 Detect integer overflow in repeat count.
4911 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4912 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4913
171e2a58
PE
4914 * termcap.c: Don't assume sizes fit in int and never overflow.
4915 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4916 (gobble_line): Check for size-calculation overflow.
4917
ad39faca 4918 * minibuf.c (Fread_buffer):
6e5bb2dc 4919 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4920 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4921 Don't assume string length fits in int.
4922
52c61c22 4923 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4924 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4925
b5b8c9e5
PE
4926 * font.c: Don't assume string length fits in int.
4927 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4928 Use ptrdiff_t, not int.
ccd6111c
PE
4929 (font_intern_prop): Don't assume string length fits in int.
4930 Don't assume integer property fits in fixnum.
4931 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4932
882f0d81 4933 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4934 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4935 Reformulate so as not to need the command string.
4936 Invoke gzip -cd rather than gunzip, as it's more portable.
4937 (lock_info_type, lock_file_1, lock_file):
4938 Don't assume pid_t and time_t fit in unsigned long.
4939 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4940 (current_lock_owner): Prefer signed type for sizes.
4941 Use memcpy, not strncpy, where memcpy is what is really wanted.
4942 Don't assume (via atoi) that time_t and pid_t fit in int.
4943 Check for time_t and/or pid_t out of range, e.g., via a network share.
4944 Don't alloca where an auto var works fine.
4945
93f4cf88
PE
4946 * fileio.c: Fix some integer overflow issues.
4947 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4948 Don't assume string length fits in int.
4949 (directory_file_name): Don't assume string length fits in long.
4950 (make_temp_name): Don't assume pid fits in int, or that its print
4951 length is less than 20.
4952
f3e92b69
PE
4953 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4954
1bfdaf10
PE
4955 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4956
35016e9a
PE
4957 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4958
3d1e65a1
PE
4959 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4960 We prefer signed integers, even for size calculations.
4961
0b963a93
PE
4962 * emacs.c: Don't assume string length fits in 'int'.
4963 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4964 (main): Don't invoke strlen when not needed.
4965
573f4b54
PE
4966 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4967 (XD_DEBUG_MESSAGE): Don't waste a byte.
4968
989f33ba
PE
4969 * callproc.c (getenv_internal_1, getenv_internal)
4970 (Fgetenv_internal):
965d34eb
PE
4971 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4972
e4d29b33
PE
4973 * lread.c (invalid_syntax): Omit length argument.
4974 All uses changed. This doesn't fix a bug, but it simplifies the
4975 code away from its former Hollerith-constant appearance, and it's
4976 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4977 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4978
eb49b136
PE
4979 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4980 This didn't break anything, but it didn't help either.
4981 It's confusing to put a bogus integer in a place where the actual
4982 value does not matter.
9f62aeb1 4983 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4984 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4985
15375a22
PE
4986 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4987 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4988 implementation.
b61cc01c
PE
4989 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4990 We prefer signed types, and the value cannot exceed the EMACS_INT
4991 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4992 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4993 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4994 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4995
53b2623d
PE
4996 * indent.c (sane_tab_width): New function.
4997 (current_column, scan_for_column, Findent_to, position_indentation)
4998 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4999 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5000
51cab52b 5001 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5002
f2ed8a70
PE
5003 * lisp.h (lint_assume): New macro.
5004 * composite.c (composition_gstring_put_cache):
5005 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5006
abe80cc6
PE
5007 * editfns.c, insdel.c:
5008 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5009
b02c740e
PE
5010 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5011
ebc96716
PE
5012 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5013
b4e50fa0 5014 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5015 Use much-faster test for byte-length change.
311d5d7c 5016 Don't assume string byte-length fits in 'int'.
a4cf38e4 5017 Check that character arg fits in 'int'.
85461888 5018 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5019
c0c1ee9f
PE
5020 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5021
a498d7f4
PE
5022 * fns.c (concat): Catch string overflow earlier.
5023 Do not rely on integer wraparound.
5024
51cab52b
PE
5025 * dispextern.h (struct it.overlay_strings_charpos)
5026 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5027 * xdisp.c (forward_to_next_line_start)
5028 (back_to_previous_visible_line_start)
5029 (reseat_at_next_visible_line_start, next_element_from_buffer):
5030 Don't arbitrarily truncate the value of 'selective' to int.
5031
76031fad
PE
5032 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5033
5eb55db9
PE
5034 * composite.c: Don't truncate sizes to 'int'.
5035 (composition_gstring_p, composition_reseat_it)
5036 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5037 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5038 not EMACS_UINT, for indexes.
5eb55db9 5039
0703a717
PE
5040 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5041
d6202519
PE
5042 * buffer.c: Include <verify.h>.
5043 (struct sortvec.priority, struct sortstr.priority):
8961a454 5044 Now EMACS_INT, not int.
c20998a7 5045 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5046 (struct sortstr.size, record_overlay_string)
5047 (struct sortstrlist.size, struct sortlist.used):
5048 Don't truncate size to int.
5049 (record_overlay_string): Check for size-calculation overflow.
d6202519 5050 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5051
d5a19415
JM
50522011-06-22 Jim Meyering <meyering@redhat.com>
5053
029529ac 5054 Don't leak an XBM-image-sized buffer
d5a19415
JM
5055 * image.c (xbm_load): Free the image buffer after using it.
5056
a9041e6c
PE
50572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5058
5059 Port to Sun C.
5060 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5061 that Sun C diagnosed.
5062 * fns.c (secure_hash): Fix pointer signedness issue.
5063 * intervals.c (static_offset_intervals): New function.
5064 (offset_intervals): Use it.
5065
7f3f739f
LL
50662011-06-21 Leo Liu <sdl.web@gmail.com>
5067
5068 * deps.mk (fns.o):
5069 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5070 sha512.h.
5071
5072 * fns.c (secure_hash): Rename from crypto_hash_function and change
5073 the first arg to accept symbols.
5b66d427 5074 (Fsecure_hash): New primitive.
7f3f739f
LL
5075 (syms_of_fns): New symbols.
5076
76147d94
DD
50772011-06-20 Deniz Dogan <deniz@dogan.se>
5078
5079 * process.c (Fset_process_buffer): Clarify return value in
5080 docstring.
5081
7d7d0045
CY
50822011-06-18 Chong Yidong <cyd@stupidchicken.com>
5083
5084 * dispnew.c (add_window_display_history): Use BVAR.
5085
5086 * xdisp.c (debug_method_add): Use BVAR.
5087 (check_window_end, dump_glyph_matrix, dump_glyph)
5088 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5089
5090 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5091 Likewise.
5092
5093 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5094 check till after the cache is created in init_frame_faces.
5095
ff2bc410
SM
50962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5097
5098 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5099
28177add
PE
51002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5101
dd3482fe
PE
5102 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5103 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5104 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5105
393d71f3 5106 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5107 * fileio.c (Finsert_file_contents):
5108 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5109 Remove the old (too-loose) buffer overflow checks.
5110 They weren't needed, since make_gap checks for buffer overflow.
5111 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5112 The old code merely checked for Emacs fixnum overflow, and relied
5113 on undefined (wraparound) behavior. The new code avoids undefined
5114 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5115
2e6813b0 5116 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5117 Tune. Don't use wider integers than needed. Don't use alloca.
5118 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5119
599a9e4f
PE
5120 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5121
99561444
PE
5122 * insdel.c, lisp.h (buffer_overflow): New function.
5123 (insert_from_buffer_1, replace_range, replace_range_2):
5124 * insdel.c (make_gap_larger):
5125 * editfns.c (Finsert_char):
5126 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5127
28177add
PE
5128 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5129
e69dafad
PE
51302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5131
4baa020d 5132 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5133
b1c46f02
PE
5134 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5135 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5136
e69dafad
PE
5137 * fileio.c: Don't assume EMACS_INT fits in off_t.
5138 (emacs_lseek): New static function.
5139 (Finsert_file_contents, Fwrite_region): Use it.
5140 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5141
566684ea
PE
5142 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5143
e6966cd6
PE
5144 * fns.c: Don't overflow int when computing a list length.
5145 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5146 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5147 truncation on 64-bit hosts. Check for QUIT every
5148 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5149 faster and is responsive enough.
5150 (Flength): Report an error instead of overflowing an integer.
5151 (Fsafe_length): Return a float if the value is not representable
5152 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5153 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5154 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5155
dd0b0efb
PE
5156 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5157 (header_size, word_size): New constants.
5158 (allocate_vectorlike): Don't check size overflow here.
5159 (allocate_vector): Check it here instead, since this is the only
5160 caller of allocate_vectorlike that could cause overflow.
5161 Check that the new vector's length is representable as a fixnum.
5162
86fe5cfe
PE
5163 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5164 The previous code was bogus. For example, next_almost_prime (32)
5165 returned 39, which is undesirable as it is a multiple of 3; and
5166 next_almost_prime (24) returned 25, which is a multiple of 5 so
5167 why was the code bothering to check for multiples of 7?
5168
80e88859
PE
5169 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5170
4a2f0ad6
PE
5171 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5172
f66c7cf8
PE
5173 Variadic C functions now count arguments with ptrdiff_t.
5174 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5175 Back then I didn't know that the Emacs coding style prefers signed int.
5176 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5177 were being counted with int, which may truncate counts on 64-bit
5178 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5179 * lisp.h (struct Lisp_Subr.function.aMANY)
5180 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5181 Arg counts are now ptrdiff_t, not size_t.
5182 All variadic functions and their callers changed accordingly.
5183 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5184 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5185 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5186 * callint.c (Fcall_interactively): Check arg count for overflow,
5187 to avoid potential buffer overrun. Use signed char, not 'int',
5188 for 'varies' array, so that we needn't bother to check its size
5189 calculation for overflow.
5190 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5191 * eval.c (apply_lambda):
5192 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5193 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5194 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5195
a1759b76
PE
5196 * callint.c (Fcall_interactively): Don't use index var as event count.
5197
d96be9fc
PE
5198 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5199 * mem-limits.h (SIZE): Remove; no longer used.
5200
a690a978 5201 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5202
578c21e6
PE
5203 Remove unnecessary casts.
5204 * xterm.c (x_term_init):
5205 * xfns.c (x_set_border_pixel):
5206 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5207 These aren't needed now that we assume ANSI C.
5208
96f53c6c
PE
5209 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5210 It's more likely to cause problems (due to unsigned overflow)
5211 than to cure them.
5212
83c77d31
PE
5213 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5214
ee2079f1
PE
5215 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5216
6da65536
PE
5217 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5218
7147c4a4
PE
5219 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5220
193e32d9
PE
5221 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5222
e5533da6
PE
5223 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5224
9910e595
PE
5225 GLYPH_CODE_FACE returns EMACS_INT, not int.
5226 * dispextern.h (merge_faces):
5227 * xfaces.c (merge_faces):
01103c44
PE
5228 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5229 Don't assume EMACS_INT fits in int.
9910e595 5230
2638320e
PE
5231 * character.h (CHAR_VALID_P): Remove unused parameter.
5232 * fontset.c, lisp.h, xdisp.c: All uses changed.
5233
045eb8d9
PE
5234 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5235
c1f134b5
PE
5236 * fns.c (concat): Minor tuning based on overflow analysis.
5237 This doesn't fix any bugs. Use int to hold character, instead
5238 of constantly refetching from Emacs object. Use XFASTINT, not
5239 XINT, for value known to be a character. Don't bother comparing
5240 a single byte to 0400, as it's always less.
5241
395fcb93 5242 * floatfns.c (Fexpt):
327eeec8
PE
5243 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5244
abbd3d23
PE
5245 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5246 for characters.
5247
684a03ef
PE
5248 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5249
0fed43f3
PE
5250 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5251 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5252 incorrectly succeed when S was a string, because 4294967386 was
5253 truncated before it was used.
5254
8fd02eb7
PE
5255 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5256 Otherwise, an out-of-range integer could cause undefined behavior
5257 on a 64-bit host.
5258
f8c86b69
PE
5259 * composite.c: Use int, not EMACS_INT, for characters.
5260 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5261 EMACS_INT, for values that are known to be in character range.
5262 This doesn't fix any bugs but is the usual style inside Emacs and
5263 may generate better code on 32-bit machines.
5264
34206dd2
PE
5265 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5266 This is for reasons similar to the recent CHAR_STRING fix.
5267 * charset.c (Fencode_char): Check that character arg is actually
5268 a character. Pass an int to ENCODE_CHAR.
5269 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5270 wider than 'int', as a compile-time check to prevent future regressions
5271 in this area.
5272
c5958d4c 5273 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5274
5275 Make sure a 64-bit char is never passed to CHAR_STRING.
5276 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5277 by silently ignoring the top 32 bits, allowing some values
5278 that were far too large to be valid characters.
5279 * character.h: Include <verify.h>.
5280 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5281 arguments are no wider than unsigned, as a compile-time check
5282 to prevent future regressions in this area.
5283 * data.c (Faset):
01103c44 5284 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5285 (Fsubst_char_in_region):
5286 * fns.c (concat):
5287 * xdisp.c (decode_mode_spec_coding):
5288 Adjust to CHAR_STRING's new requirement.
5289 * editfns.c (Finsert_char, Fsubst_char_in_region):
5290 * fns.c (concat): Check that character args are actually
5291 characters. Without this test, these functions did the wrong
5292 thing with wildly out-of-range values on 64-bit hosts.
5293
d37ca623
PE
5294 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5295 These casts should not be needed on 32-bit hosts, either.
5296 * keyboard.c (read_char):
5297 * lread.c (Fload): Remove casts to unsigned.
5298
ea204efb
PE
5299 * lisp.h (UNSIGNED_CMP): New macro.
5300 This fixes comparison bugs on 64-bit hosts.
5301 (ASCII_CHAR_P): Use it.
5302 * casefiddle.c (casify_object):
01103c44 5303 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5304 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5305 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5306 * dispextern.h (FACE_FROM_ID):
5307 * keyboard.c (read_char): Use UNSIGNED_CMP.
5308
41cb286c
PE
5309 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5310 not to EMACS_INT, to avoid GCC warning.
5311
4a1b9832
PE
5312 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5313
55daad71
PE
5314 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5315 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5316 isn't needed on 32-bit machines.
8f95c75c 5317
01103c44
PE
5318 * buffer.c (Fgenerate_new_buffer_name):
5319 Use EMACS_INT for count, not int.
0ceccced 5320 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5321
5322 * data.c (Qcompiled_function): Now static.
5323
c6f072e7
PE
5324 * window.c (window_body_lines): Now static.
5325
20ce5912
PE
5326 * image.c (gif_load): Rename local to avoid shadowing.
5327
9c4c5f81
PE
5328 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5329 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5330 * alloc.c (make_save_value): Integer argument is now of type
5331 ptrdiff_t, not int.
5332 (mark_object): Use ptrdiff_t, not int.
5333 * lisp.h (pD): New macro.
5334 * print.c (print_object): Use it.
5335
c0c5c8ae
PE
5336 * alloc.c: Use EMACS_INT, not int, to count objects.
5337 (total_conses, total_markers, total_symbols, total_vector_size)
5338 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5339 (total_free_floats, total_floats, total_free_intervals)
5340 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5341 Now EMACS_INT, not int. All uses changed.
5342 (Fgarbage_collect): Compute overall total using a double, so that
5343 integer overflow is less likely to be a problem. Check for overflow
5344 when converting back to an integer.
5a25e253
PE
5345 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5346 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5347 These were 'int' variables that could overflow on 64-bit hosts;
5348 they were never used, so remove them instead of repairing them.
211a0b2a 5349 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5350 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5351 Previously, this ceilinged at INT_MAX, but that doesn't work on
5352 64-bit machines.
e46bb31a 5353 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5354
c78baabf 5355 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5356 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5357 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5358 when a (possibly-narrower) signed value would do just as well.
5359 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5360
c9d624c6
PE
5361 * alloc.c: Catch some string size overflows that we were missing.
5362 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5363 for convenience in STRING_BYTES_MAX.
5364 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5365 The definition here is exact; the one in lisp.h was approximate.
5366 (allocate_string_data): Check for string overflow. This catches
5367 some instances we weren't catching before. Also, it catches
5368 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5369 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5370 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5371
c9d624c6
PE
5372 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5373 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5374 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5375
353032ce
PE
5376 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5377
2bccce07
PE
5378 * alloc.c (Fmake_string): Check for out-of-range init.
5379
0ac30604
SM
53802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5381
5382 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5383
c195f2de
JD
53842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5385
5386 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5387 xg_get_default_scrollbar_width.
5388
5389 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5390 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5391 (style_changed_cb): Call update_theme_scrollbar_width and call
5392 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5393 all frames (Bug#8505).
5394 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5395 Call gtk_window_set_resizable if HAVE_GTK3.
5396 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5397 and height if HAVE_GTK3 (Bug#8505).
5398 (scroll_bar_width_for_theme): New variable.
5399 (update_theme_scrollbar_width): New function.
5400 (xg_get_default_scrollbar_width): Move code to
5401 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5402 (xg_initialize): Call update_theme_scrollbar_width.
5403
5404 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5405
5406 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5407
e10ac9f1
MR
54082011-06-12 Martin Rudalics <rudalics@gmx.at>
5409
5410 * frame.c (make_frame): Call other_buffer_safely instead of
5411 other_buffer.
5412
5413 * window.c (temp_output_buffer_show): Call display_buffer with
5414 second argument Vtemp_buffer_show_specifiers and reset latter
5415 immediately after the call.
5416 (Vtemp_buffer_show_specifiers): New variable.
5417 (auto_window_vscroll_p, next_screen_context_lines)
5418 (Vscroll_preserve_screen_position): Remove leading asterisks from
5419 doc-strings.
5420
2d3c217e 54212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5422
7b7f97e8 5423 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5424 * buffer.c (Qclone_number): Remove for now, as it's unused.
5425 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5426 (record_buffer): Remove unused local.
5427 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5428 (set_frame_buffer_list): Remove; unused.
5429 * frame.h (other_visible_frames): Remove decl.
5430 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5431 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5432 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5433 if HAVE_GPM.
5434 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5435 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5436 Define only if HAVE_GPM.
5437 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5438 (update_hints_inhibit): Remove; never set. All uses removed.
5439 * widgetprv.h (emacsFrameClassRec): Remove decl.
5440 * window.c (delete_deletable_window): Now returns void, since it
5441 wasn't returning anything.
5442 (compare_window_configurations): Remove unused locals.
5443 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5444 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5445 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5446 the same widths as pointers. This follows up on the 2011-05-06 patch.
5447 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5448 * xterm.h: Likewise.
5449 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5450
1384b89e
JB
54512011-06-12 Juanma Barranquero <lekktu@gmail.com>
5452
5453 * makefile.w32-in: Update dependencies.
5454 (LISP_H): Add lib/intprops.h.
5455
1100a63c
CY
54562011-06-11 Chong Yidong <cyd@stupidchicken.com>
5457
5458 * image.c (gif_load): Add animation frame delay to the metadata.
5459 (syms_of_image): Use DEFSYM. New symbol `delay'.
5460
6198ccd0
MR
54612011-06-11 Martin Rudalics <rudalics@gmx.at>
5462
5463 * window.c (delete_deletable_window): Re-add.
5464 (Fset_window_configuration): Rewrite to handle dead buffers and
5465 consequently deletable windows.
5466 (window_tree, Fwindow_tree): Remove. Supply functionality in
5467 window.el.
5468 (compare_window_configurations): Simplify code.
5469
b6e3633c
AS
54702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5471
1ab0dee5
AS
5472 * image.c (imagemagick_load_image): Fix type mismatch.
5473 (Fimagemagick_types): Likewise.
5474
b6e3633c
AS
5475 * window.h (replace_buffer_in_windows): Declare.
5476
9397e56f
MR
54772011-06-11 Martin Rudalics <rudalics@gmx.at>
5478
5479 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5480 Qclone_number. Remove external declaration of Qdelete_window.
5481 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5482 code.
640c8776
SM
5483 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5484 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5485 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5486 buffer list implementation.
5487 (other_buffer_safely): New function.
5488 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5489 calls to replace_buffer_in_windows and
5490 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5491 if allowed.
5492 (record_buffer): Inhibit quitting and rewrite using quittable
5493 functions. Run Qbuffer_list_update_hook if allowed.
5494 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5495 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5496 Move switch-to-buffer to window.el.
9397e56f
MR
5497 (bury-buffer): Move to window.el.
5498 (Vbuffer_list_update_hook): New variable.
5499
5500 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5501 section.
5502
5503 * window.h (resize_frame_windows): Move up in code.
5504 (Fwindow_frame): Remove EXFUN.
5505 (replace_buffer_in_all_windows): Remove prototype.
5506 (replace_buffer_in_windows_safely): Add prototype.
5507
5508 * window.c: Declare Qdelete_window static again. Move down
5509 declaration of select_count.
5510 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5511 (Fother_window): Move to window.el.
5512 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5513 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5514 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5515 window.el.
5516 (replace_buffer_in_windows): Implement by calling
5517 Qreplace_buffer_in_windows.
5518 (replace_buffer_in_all_windows): Remove with some functionality
5519 moved into replace_buffer_in_windows_safely.
5520 (replace_buffer_in_windows_safely): New function.
5521 (select_window_norecord, select_frame_norecord): Move in front
5522 of run_window_configuration_change_hook. Remove now obsolete
5523 declarations.
640c8776
SM
5524 (Fset_window_buffer): Rewrite doc-string.
5525 Call Qrecord_window_buffer.
9397e56f
MR
5526 (keys_of_window): Move binding for other-window to window.el.
5527
b50691aa
CY
55282011-06-11 Chong Yidong <cyd@stupidchicken.com>
5529
5530 * dispextern.h (struct image): Replace data member, whose int_val
5531 and ptr_val fields were not used by anything, with a single
5532 lisp_val object.
5533
5534 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5535 (gif_clear_image, gif_load, imagemagick_load_image)
5536 (gs_clear_image, gs_load): Callers changed.
5537
3f754b86
PE
55382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5539
cca69397
PE
5540 * buffer.h: Include <time.h>, for time_t.
5541 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5542
109e28d0
PE
5543 Fix minor problems found by static checking.
5544
60737f02
PE
5545 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5546
4b66faf3
PE
5547 Make identifiers static if they are not used in other modules.
5548 * data.c (Qcompiled_function, Qframe, Qvector):
5549 * image.c (QimageMagick, Qsvg):
5550 * minibuf.c (Qmetadata):
5551 * window.c (resize_window_check, resize_root_window): Now static.
5552 * window.h (resize_window_check, resize_root_window): Remove decls.
5553
109e28d0
PE
5554 * window.c (window_deletion_count, delete_deletable_window):
5555 Remove; unused.
46a4ce9e
PE
5556 (window_body_lines): Now static.
5557 (Fdelete_other_windows_internal): Mark vars as initialized.
5558 Make sure 'resize_failed' is initialized.
5559 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5560 (resize_window_apply): Remove unused local.
5561 * window.h (delete_deletable_window): Remove decl.
5562
109e28d0 5563 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5564 (imagemagick_load_image): Fix pointer signedness problem by changing
5565 last arg from unsigned char * to char *. All uses changed.
5566 Also, fix a local for similar reasons.
5567 Remove unused locals. Remove locals to avoid shadowing.
5568 (fn_rsvg_handle_free): Remove; unused.
5569 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5570 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5571
3f754b86
PE
5572 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5573
2547adb1
CY
55742011-06-10 Chong Yidong <cyd@stupidchicken.com>
5575
5576 * image.c (gif_load): Fix omitted cast error introduced by
5577 2011-06-06 change.
5578
2c8e37d4
MR
55792011-06-10 Martin Rudalics <rudalics@gmx.at>
5580
5581 * window.h (resize_proportionally, orig_total_lines)
5582 (orig_top_line): Remove from window structure.
5583 (set_window_height, set_window_width, change_window_heights)
5584 (Fdelete_window): Remove prototypes.
5585 (resize_frame_windows): Remove duplicate declaration.
5586
440a42e3
EZ
55872011-06-10 Eli Zaretskii <eliz@gnu.org>
5588
5589 * window.h (resize_frame_windows, resize_window_check)
5590 (delete_deletable_window, resize_root_window)
5591 (resize_frame_windows): Declare prototypes.
5592
5593 * window.c (resize_window_apply): Make definition be "static" to
5594 match the prototype.
5595
562dd5e9
MR
55962011-06-10 Martin Rudalics <rudalics@gmx.at>
5597
5598 * window.c: Remove declarations of Qwindow_size_fixed,
5599 window_min_size_1, window_min_size_2, window_min_size,
5600 size_window, window_fixed_size_p, enlarge_window, delete_window.
5601 Remove static from declaration of Qdelete_window, it's
5602 temporarily needed by Fbury_buffer.
5603 (replace_window): Don't assign orig_top_line and
5604 orig_total_lines.
5605 (Fdelete_window, delete_window): Remove. Window deletion is
5606 handled by window.el.
640c8776
SM
5607 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5608 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5609 (Fdelete_other_windows): Remove. Deleting other windows is
5610 handled by window.el.
5611 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5612 handled in window.el.
5613 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5614 Window minimum sizes are handled in window.el.
5615 (shrink_windows, size_window, set_window_height)
5616 (set_window_width, change_window_heights, window_height)
5617 (window_width, CURBEG, CURSIZE, enlarge_window)
5618 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5619 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5620 handled in window.el.
5621 (make_dummy_parent): Rename to make_parent_window and give it a
5622 second argument horflag.
5623 (make_window): Don't set resize_proportionally any more.
5624 (Fsplit_window): Remove. Windows are split in window.el.
5625 (save_restore_action, save_restore_orig_size)
5626 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5627 Resize mini windows in window.el.
5628 (grow_mini_window, shrink_mini_window): Implement by calling
5629 Qresize_root_window_vertically, resize_window_check and
5630 resize_window_apply.
640c8776
SM
5631 (saved_window, Fset_window_configuration, save_window_save):
5632 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5633 resize_proportionally.
5634 (window_min_height, window_min_width): Move to window.el.
5635 (keys_of_window): Move bindings for delete-other-windows,
5636 split-window, delete-window and enlarge-window to window.el.
5637
5638 * buffer.c: Temporarily extern Qdelete_window.
5639 (Fbury_buffer): Temporarily call Qdelete_window instead of
5640 Fdelete_window (Fbury_buffer will move to window.el soon).
5641
5642 * frame.c (set_menu_bar_lines_1): Remove code handling
5643 orig_top_line and orig_total_lines.
5644
5645 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5646 set_window_height but set heights directly.
5647 (change_frame_size_1): Use resize_frame_windows.
5648
5649 * xdisp.c (init_xdisp): Don't use set_window_height but set
5650 heights directly.
5651
640c8776
SM
5652 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5653 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5654 run_window_configuration_change_hook.
5655
5656 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5657 instead of change_window_heights and run
5658 run_window_configuration_change_hook.
5659
1a13852e
MR
56602011-06-09 Martin Rudalics <rudalics@gmx.at>
5661
5662 * window.c (replace_window): Rename second argument REPLACEMENT to
5663 NEW. New third argument SETFLAG. Rewrite.
5664 (delete_window, make_dummy_parent): Call replace_window with
5665 third argument 1.
5666 (window_list_1): Move down in code.
5667 (run_window_configuration_change_hook): Move set_buffer part
5668 before select_frame_norecord part in order to unwind correctly.
5669 Rename count1 to count.
5670 (recombine_windows, delete_deletable_window, resize_root_window)
5671 (Fdelete_other_windows_internal)
5672 (Frun_window_configuration_change_hook, make_parent_window)
5673 (resize_window_check, resize_window_apply, Fresize_window_apply)
5674 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5675 (Fdelete_window_internal, Fresize_mini_window_internal):
5676 New functions.
1a13852e
MR
5677 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5678
f3d1777e
MR
56792011-06-08 Martin Rudalics <rudalics@gmx.at>
5680
496e208e
MR
5681 * window.h (window): Add some new members to window structure -
5682 normal_lines, normal_cols, new_total, new_normal, clone_number,
5683 splits, nest, prev_buffers, next_buffers.
5684 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5685 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5686
f3d1777e
MR
5687 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5688 Remove.
496e208e
MR
5689 (make_dummy_parent): Set new members of windows structure.
5690 (make_window): Move down in code. Handle new members of window
5691 structure.
5692 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5693 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5694 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5695 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5696 (Fset_window_next_buffers, Fset_window_clone_number):
5697 New functions.
496e208e
MR
5698 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5699 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5700 Doc-string fixes.
5701 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5702 Argument WINDOW can be now internal window too.
5703 (Fwindow_use_time): Move up in code.
5704 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5705 Rewrite doc-string.
5706 (Fset_window_configuration, saved_window)
5707 (Fcurrent_window_configuration, save_window_save): Handle new
5708 members of window structure.
b9e809c2
MR
5709 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5710 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5711 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5712 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5713 Qget_mru_window, Qresize_root_window,
5714 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5715 Qauto_buffer_name; staticpro them.
f3d1777e 5716
abde8f8c
MR
57172011-06-07 Martin Rudalics <rudalics@gmx.at>
5718
5719 * window.c (Fwindow_total_size, Fwindow_left_column)
5720 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5721 (Fwindow_list_1): New functions.
5722 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5723 (Fwindow_width, Fscroll_left, Fscroll_right):
5724 Use window_body_cols instead of window_box_text_cols.
5725 (delete_window, Fset_window_configuration):
5726 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5727 (delete_all_subwindows): Take a window as argument and not a
5728 structure. Rewrite.
190b47e6
MR
5729 (window_loop): Remove handling of GET_LRU_WINDOW and
5730 GET_LARGEST_WINDOW.
5731 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5732
5733 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5734 window_box_text_cols. delete_all_subwindows now takes a
5735 Lisp_Object as argument.
abde8f8c 5736
640c8776
SM
5737 * indent.c (compute_motion, Fcompute_motion):
5738 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5739
fa8a67e6
MR
5740 * frame.c (delete_frame): Call delete_all_subwindows with root
5741 window as argument.
5742
a54e3482
DC
57432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5744
5745 * fns.c (Fputhash): Document return value.
5746
60002bf5
CY
57472011-06-06 Chong Yidong <cyd@stupidchicken.com>
5748
5749 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5750
0c671da6 57512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5752
b862a52a 5753 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5754
be44ca6c
PE
5755 Check for overflow when converting integer to cons and back.
5756 * charset.c (Fdefine_charset_internal, Fdecode_char):
5757 Use cons_to_unsigned to catch overflow.
5758 (Fencode_char): Use INTEGER_TO_CONS.
5759 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5760 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5761 * data.c (long_to_cons, cons_to_long): Remove.
5762 (cons_to_unsigned, cons_to_signed): New functions.
5763 These signal an error for invalid or out-of-range values.
5764 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5765 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5766 * font.c (Ffont_variation_glyphs):
5767 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5768 * lisp.h: Include <intprops.h>.
5769 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5770 (cons_to_signed, cons_to_unsigned): New decls.
5771 (long_to_cons, cons_to_long): Remove decls.
5772 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5773 (Fprimitive_undo): Use CONS_TO_INTEGER.
5774 * xfns.c (Fx_window_property): Likewise.
5775 * xselect.c: Include <limits.h>.
5776 (x_own_selection, selection_data_to_lisp_data):
5777 Use INTEGER_TO_CONS.
5778 (x_handle_selection_request, x_handle_selection_clear)
5779 (x_get_foreign_selection, Fx_disown_selection_internal)
5780 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5781 (lisp_data_to_selection_data): Use cons_to_unsigned.
5782 (x_fill_property_data): Use cons_to_signed.
5783 Report values out of range.
5784
d1f3d2af
PE
5785 Check for buffer and string overflow more precisely.
5786 * buffer.h (BUF_BYTES_MAX): New macro.
5787 * lisp.h (STRING_BYTES_MAX): New macro.
5788 * alloc.c (Fmake_string):
5789 * character.c (string_escape_byte8):
5790 * coding.c (coding_alloc_by_realloc):
5791 * doprnt.c (doprnt):
5792 * editfns.c (Fformat):
5793 * eval.c (verror):
5794 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5795 since they may not be the same number.
5796 * editfns.c (Finsert_char):
5797 * fileio.c (Finsert_file_contents):
5798 Likewise for BUF_BYTES_MAX.
5799
dd52fcea
PE
5800 * image.c: Use ptrdiff_t, not int, for sizes.
5801 (slurp_file): Switch from int to ptrdiff_t.
5802 All uses changed.
5803 (slurp_file): Check that file size fits in both size_t (for
5804 malloc) and ptrdiff_t (for sanity and safety).
5805
7f9bbdbb
PE
5806 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5807 if b->modtime has its maximal value.
5808
dfe18f82
PE
5809 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5810
84acfcf0
PE
5811 Don't assume time_t can fit into int.
5812 * buffer.h (struct buffer.modtime): Now time_t, not int.
5813 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5814 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5815
ccd9a01a
PE
5816 Minor fixes for signed vs unsigned integers.
5817 * character.h (MAYBE_UNIFY_CHAR):
5818 * charset.c (maybe_unify_char):
5819 * keyboard.c (read_char, reorder_modifiers):
5820 XINT -> XFASTINT, since the integer must be nonnegative.
5821 * ftfont.c (ftfont_spec_pattern):
5822 * keymap.c (access_keymap, silly_event_symbol_error):
5823 XUINT -> XFASTINT, since the integer must be nonnegative.
5824 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5825 since it makes no difference and we prefer signed.
5826 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5827 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5828 nonnegative.
5829
d6d100dd
SM
58302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5831
5832 * window.h (Fwindow_frame): Declare.
5833
2b6148e4
PE
58342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5835
5836 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5837 (SPARE_MEMORY): Always define.
5838 (LARGE_REQUEST): Remove.
5839 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5840
f230ecc9
MR
58412011-06-06 Martin Rudalics <rudalics@gmx.at>
5842
727e958e
MR
5843 * lisp.h: Move EXFUNS for Fframe_root_window,
5844 Fframe_first_window and Fset_frame_selected_window to window.h.
5845
5846 * window.h: Move EXFUNS for Fframe_root_window,
5847 Fframe_first_window and Fset_frame_selected_window here from
5848 lisp.h.
5849
5850 * frame.c (Fwindow_frame, Fframe_first_window)
5851 (Fframe_root_window, Fframe_selected_window)
5852 (Fset_frame_selected_window): Move to window.c.
5853 (Factive_minibuffer_window): Move to minibuf.c.
5854 (Fother_visible_frames_p): New function.
5855
5856 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5857
f230ecc9
MR
5858 * window.c (decode_window, decode_any_window): Move up in code.
5859 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5860 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5861 (Fwindow_buffer): Move up and rewrite doc-string.
5862 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5863 (Fwindow_prev): New functions.
727e958e
MR
5864 (Fwindow_frame): Move here from frame.c. Accept any window as
5865 argument.
5866 (Fframe_root_window, Fframe_first_window)
5867 (Fframe_selected_window): Move here from frame.c. Accept frame
5868 or arbitrary window as argument. Update doc-strings.
5869 (Fminibuffer_window): Move up in code.
5870 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5871 (Fset_frame_selected_window): Move here from frame.c.
5872 Marginal rewrite.
727e958e
MR
5873 (Fselected_window, select_window, Fselect_window): Move up in
5874 code. Minor doc-string fixes.
f230ecc9 5875
4d09bcf6
PE
58762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5877
5878 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5879 Do not assume that spare memory exists; that assumption is valid
5880 only if SYSTEM_MALLOC.
5881 (LARGE_REQUEST): New macro, so that the issue of large requests
5882 is separated from the issue of spare memory.
5883
810928a2
AS
58842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5885
172418ad
AS
5886 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5887 format. (Bug#8806)
5888
43f862f7
AS
5889 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5890
810928a2
AS
5891 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5892 before statements.
5893
a059fe24
JD
58942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5895
5896 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5897
5898 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5899
5900 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5901 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5902
989bf368
JB
59032011-06-05 Juanma Barranquero <lekktu@gmail.com>
5904
5905 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5906
4b80f674
CY
59072011-06-04 Chong Yidong <cyd@stupidchicken.com>
5908
5909 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5910 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5911 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5912 New error handlers.
4b80f674
CY
5913 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5914 Obey Vx_select_enable_clipboard_manager. Catch errors in
5915 x_clipboard_manager_save (Bug#8779).
5916 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5917 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5918
99a33b77 59192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5920
5921 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5922
99a33b77 59232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5924
5925 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5926 in the current matrix if keep_current_p is non-zero.
5927
8264569d
EZ
59282011-06-04 Eli Zaretskii <eliz@gnu.org>
5929
5930 * bidi.c (bidi_level_of_next_char): Fix last change.
5931
57f97249
EZ
59322011-06-03 Eli Zaretskii <eliz@gnu.org>
5933
fec2107c 5934 Support bidi reordering of text covered by display properties.
57f97249 5935
fec2107c
EZ
5936 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5937 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5938 (bidi_cache_search, bidi_cache_iterator_state)
5939 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5940 (bidi_level_of_next_char, bidi_move_to_visually_next):
5941 Support character positions inside a run of characters covered by a
fec2107c
EZ
5942 display string.
5943 (bidi_paragraph_init, bidi_resolve_explicit_1)
5944 (bidi_level_of_next_char): Call bidi_fetch_char and
5945 bidi_fetch_char_advance instead of FETCH_CHAR and
5946 FETCH_CHAR_ADVANCE.
5947 (bidi_init_it): Initialize new members.
5948 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5949 definitions.
5950 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5951 instead of using explicit *_CHAR codes.
d6d100dd
SM
5952 (bidi_resolve_explicit, bidi_resolve_weak):
5953 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5954 bidirectional text is supported only in multibyte buffers.
5955 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5956 it to initialize the frame_window_p member of struct bidi_it.
5957 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5958 (bidi_resolve_explicit, bidi_resolve_weak)
5959 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5960 bidi_it->nchars is non-positive.
5961 (bidi_level_of_next_char): Don't try to lookup the cache for the
5962 next/previous character if nothing is cached there yet, or if we
5963 were just reseat()'ed to a new position.
c40e2fb2 5964
0e14fe90
EZ
5965 * xdisp.c (set_cursor_from_row): Set start and stop points
5966 according to the row's direction when priming the loop that looks
5967 for the glyph on which to display cursor.
5968 (single_display_spec_intangible_p): Function deleted.
5969 (display_prop_intangible_p): Reimplement to call
5970 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5971 Accept 3 additional arguments needed by handle_display_spec.
5972 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5973 values: lists, `(when COND...)' forms, etc.
5974 (single_display_spec_string_p): Support property values that are
5975 lists with the argument STRING its top-level element.
5976 (display_prop_string_p): Fix the condition for processing a
5977 property that is a list to be consistent with handle_display_spec.
fec2107c 5978 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5979 last portion of handle_display_prop.
5980 (compute_display_string_pos): Accept additional argument
5981 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5982 value of a `display' property is a "replacing spec".
5983 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5984 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5985 the display property, but just return a value indicating whether
5986 the display property will replace the characters it covers.
5987 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5988 frame_window_p members of struct bidi_it.
d6d100dd
SM
5989 (compute_display_string_pos, compute_display_string_end):
5990 New functions.
fec2107c
EZ
5991 (push_it): Accept second argument POSITION, where pop_it should
5992 jump to continue iteration.
5993 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5994
fec2107c
EZ
5995 * keyboard.c (adjust_point_for_property): Adjust the call to
5996 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5997
5998 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5999 (bidi_init_it): Update prototypes.
6000 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6001 (compute_display_string_pos, compute_display_string_end):
6002 Declare prototypes.
fec2107c
EZ
6003 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6004 EMACS_INT.
fc6f18ce 6005
40087514 60062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6007
57f53182
PE
6008 Malloc failure behavior now depends on size of allocation.
6009 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6010 * lisp.h: Change signatures accordingly.
6011 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6012 All callers changed. (Bug#8762)
6013
6014 * gnutls.c: Use Emacs's memory allocators.
6015 Without this change, the gnutls library would invoke malloc etc.
6016 directly, which causes problems on non-SYNC_INPUT hosts, and which
6017 runs afoul of improving memory_full behavior. (Bug#8761)
6018 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6019 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6020 xfree instead of the default malloc, realloc, free.
6021 (Fgnutls_boot): No need to check for memory allocation failure,
6022 since xmalloc does that for us.
6023
ac32cd99 6024 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6025 * category.c (hash_get_category_set):
6026 * ccl.c (ccl_driver):
6027 * charset.c (Fdefine_charset_internal):
6028 * charset.h (struct charset.hash_index):
6029 * composite.c (get_composition_id, gstring_lookup_cache)
6030 (composition_gstring_put_cache):
6031 * composite.h (struct composition.hash_index):
6032 * dispextern.h (struct image.hash):
6033 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6034 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6035 (hashfn_equal, hashfn_user_defined, make_hash_table)
6036 (maybe_resize_hash_table, hash_lookup, hash_put)
6037 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6038 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6039 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6040 * image.c (make_image, search_image_cache, lookup_image)
6041 (xpm_put_color_table_h):
6042 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6043 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6044 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6045 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6046 * alloc.c (allocate_vectorlike):
6047 Check for overflow in vector size calculations.
6048 * ccl.c (ccl_driver):
6049 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6050 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6051 need to be updated by these changes.
40087514
PE
6052 * fns.c (make_hash_table, maybe_resize_hash_table):
6053 Check for integer overflow with large hash tables.
0de4bb68
PE
6054 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6055 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6056 (SXHASH_REDUCE): New macro.
6057 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6058 Use it instead of discarding useful hash info with large hash values.
6059 (sxhash_float): New function.
6060 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6061 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6062 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6063 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6064 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6065 Adjust signatures to match updated version of code.
6066 (consing_since_gc): Now EMACS_INT, since a single hash table can
6067 use more than INT_MAX bytes.
6068
698d32e2
DN
60692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6070
6071 Make it possible to build with GCC-4.6+ -O2 -flto.
6072
6073 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6074
fd6fa53f
SM
60752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6076
6077 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6078 Call minibuffer-inactive-mode.
6079
864db017
JB
60802011-05-31 Juanma Barranquero <lekktu@gmail.com>
6081
6082 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6083 Update dependencies.
6084
2ad0baf4
DN
60852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6086
6087 * data.c (init_data): Remove code for UTS, this system is not
6088 supported anymore.
6089
4fcc2638
DN
60902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6091
6092 Don't force ./temacs to start in terminal mode.
6093
6094 * frame.c (make_initial_frame): Initialize faces in all cases, not
6095 only when CANNOT_DUMP is defined.
6096 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6097
c56e0fd5
DN
60982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6099
6100 * dispnew.c (add_window_display_history): Use const for the string
6101 pointer. Remove declaration, not needed.
6102
333d54da 61032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6104
55d4c1b2 6105 Use 'inline', not 'INLINE'.
333d54da 6106 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6107 * alloc.c, fontset.c (INLINE): Remove.
6108 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6109 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6110 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6111 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6112 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6113
738db178
DN
61142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6115
6116 Make it possible to run ./temacs.
6117
6118 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6119 syms_of_callproc does the same thing. Remove test for
6120 "initialized", do it in the caller.
6121 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6122
620c53a6
SM
61232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6124
6125 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6126 (read_minibuf): Use get_minibuffer.
6127 (syms_of_minibuf): Use DEFSYM.
6128 (Qmetadata): New var.
6129 * data.c (Qbuffer): Don't make it static.
6130 (syms_of_data): Use DEFSYM.
6131
e003a292
PE
61322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6133
6134 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6135 (CCL_CODE_MIN): New macro.
6136
ed008a6d
PE
61372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6138
3687c2ef
PE
6139 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6140
ed008a6d
PE
6141 * eval.c (Qdebug): Now static.
6142 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6143 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6144 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6145
d66c4c7c
CY
61462011-05-29 Chong Yidong <cyd@stupidchicken.com>
6147
6148 * image.c: Various fixes to ImageMagick code comments.
6149 (Fimagemagick_types): Doc fix.
6150
5fbc2025
PE
61512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6152
0196f88a
PE
6153 Minor fixes prompted by GCC 4.6.0 warnings.
6154
6155 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6156
5fbc2025
PE
6157 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6158 (x_clipboard_manager_save_all): Move extern decl to ...
6159 * xterm.h: ... here, so that it can be checked for consistency.
6160
1dd3c2d9
CY
61612011-05-29 Chong Yidong <cyd@stupidchicken.com>
6162
6163 * xselect.c (x_clipboard_manager_save_frame)
6164 (x_clipboard_manager_save_all): New functions.
6165 (Fx_clipboard_manager_save): Lisp function deleted.
6166
6167 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6168 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6169
6170 * xterm.h: Update prototype.
6171
5ba6571d
WX
61722011-05-28 William Xu <william.xwl@gmail.com>
6173
6174 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6175 exiting (Bug#8239).
6176
3eaff834
JM
61772011-05-28 Jim Meyering <meyering@redhat.com>
6178
e1900994 6179 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6180 * fns.c (to_uchar): Define.
6181 (crypto_hash_function): Use it to convert some newly-signed
6182 variables to unsigned, to avoid sign-extension bugs. For example,
6183 without this change, (md5 "truc") would evaluate to
6184 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6185 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6186 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6187
0f6990a7
PE
61882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6189
6190 Integer overflow fixes.
c8a9ca5a 6191
08686060
PE
6192 * dbusbind.c: Serial number integer overflow fixes.
6193 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6194 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6195 to hold a serial number that is too large for a fixnum.
6196 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6197 Check for serial numbers out of range. Decode any serial number
59568bf0 6198 that was so large that it became a float. (Bug#8722)
08686060 6199
2d1fc3c7
PE
6200 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6201 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6202 Use XFASTINT rather than XUINT when numbers are nonnegative.
6203 (xd_append_arg, Fdbus_method_return_internal):
6204 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6205 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6206 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6207 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6208 (Bug#8722)
2d1fc3c7 6209
c8a9ca5a
PE
6210 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6211
519e1d69
PE
6212 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6213
6df6ae42 6214 ccl: Add integer overflow checks.
30569699
PE
6215 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6216 (IN_INT_RANGE): New macros.
6217 (ccl_driver): Use them to check for integer overflow when
6218 decoding a CCL program. Many of the new checks are whether XINT (x)
6219 fits in int; it doesn't always, on 64-bit hosts. The new version
6220 doesn't catch all possible integer overflows, but it's an
847044ea 6221 improvement. (Bug#8719)
30569699 6222
c11285dc
PE
6223 * alloc.c (make_event_array): Use XINT, not XUINT.
6224 There's no need for unsigned here.
6225
fdccd48e
PE
6226 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6227 This follows up to the 2011-05-06 change that substituted uintptr_t
6228 for EMACS_INT. This case wasn't caught back then.
6229
37910ab2
PE
6230 Rework Fformat to avoid integer overflow issues.
6231 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6232 now (part of C89). Include <verify.h>.
6233 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6234 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6235 (Fformat): Avoid the prepass trying to compute sizes; it was only
6236 approximate and thus did not catch overflow reliably. Instead, walk
6237 through the format just once, formatting and computing sizes as we go,
6238 checking for integer overflow at every step, and allocating a larger
6239 buffer as needed. Keep track separately whether the format is
6240 multibyte. Keep only the most-recently calculated precision, rather
6241 than them all. Record whether each argument has been converted to
6242 string. Use EMACS_INT, not int, for byte and char and arg counts.
6243 Support field widths and precisions larger than INT_MAX. Avoid
6244 sprintf's undefined behavior with conversion specifications such as %#d
6245 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6246 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6247 formatting out-of-range floating point numbers with int
9173deec 6248 formats. (Bug#8668)
37910ab2 6249
2e6578fb
PE
6250 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6251
0ae6bdee
PE
6252 * data.c: Avoid integer truncation in expressions involving floats.
6253 * data.c: Include <intprops.h>.
6254 (arith_driver): When there's an integer overflow in an expression
6255 involving floating point, convert the integers to floating point
6256 so that the resulting value does not suffer from catastrophic
6257 integer truncation. For example, on a 64-bit host (* 4
6258 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6259 Do not rely on undefined behavior after integer overflow.
6260
de883a70
PE
6261 merge count_size_as_multibyte, parse_str_to_multibyte
6262 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6263 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6264 Check for integer overflow.
6265 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6266 since it's now a duplicate of the other. This is more of
6267 a character than a buffer op, so better that it's in character.c.
6268 * fns.c, print.c: Adjust to above changes.
6269
2ff916cb
PE
62702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6271
6272 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6273
f1b54466
PE
62742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6275
fb1ac845
PE
6276 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6277 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6278 (x_clipboard_manager_save): Now static.
6279 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6280
f1b54466
PE
6281 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6282 (crypto_hash_function): Now static.
6283 Fix pointer signedness problems. Avoid unnecessary initializations.
6284
a9f737ee
CY
62852011-05-27 Chong Yidong <cyd@stupidchicken.com>
6286
6287 * termhooks.h (Vselection_alist): Make it terminal-local.
6288
6289 * terminal.c (create_terminal): Initialize it.
6290
6291 * xselect.c: Support for clipboard managers.
6292 (Vselection_alist): Move to termhooks.h as terminal-local var.
6293 (LOCAL_SELECTION): New macro.
6294 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6295 (symbol_to_x_atom): Remove gratuitous arg.
6296 (x_handle_selection_request, lisp_data_to_selection_data)
6297 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6298 (x_own_selection, x_get_local_selection, x_convert_selection):
6299 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6300 (some_frame_on_display): Delete unused function.
6301 (Fx_own_selection_internal, Fx_get_selection_internal)
6302 (Fx_disown_selection_internal, Fx_selection_owner_p)
6303 (Fx_selection_exists_p): New optional frame arg.
6304 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6305 (x_handle_selection_clear): Don't treat other terminals with the
6306 same keyboard specially. Use the terminal-local Vselection_alist.
6307 (x_clear_frame_selections): Use Frun_hook_with_args.
6308
6309 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6310
6311 * xterm.h: Add support for those atoms.
6312
e067f0c1
CY
63132011-05-26 Chong Yidong <cyd@stupidchicken.com>
6314
6315 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6316 (converted_selections, conversion_fail_tag): New global variables.
6317 (x_selection_request_lisp_error): Free the above.
6318 (x_get_local_selection): Remove unnecessary code.
6319 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6320 of converted selections stored in converted_selections.
6321 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6322 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6323 (x_convert_selection): New function.
6324 (x_handle_selection_event): Simplify.
6325 (x_get_foreign_selection): Don't ignore incoming requests while
6326 waiting for an answer; this will fail when we implement
6327 SAVE_TARGETS, and seems unnecessary anyway.
6328 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6329 (Vx_sent_selection_functions): Doc fix.
6330
0f4aebc0
LL
63312011-05-26 Leo Liu <sdl.web@gmail.com>
6332
6333 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6334
e61124cd
YM
63352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6336
6337 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6338
6339 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6340 for fringe update if it has periodic bitmap.
ac389d0c 6341 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6342 and fringe_bitmap_periodic_p.
6343
6344 * fringe.c (get_fringe_bitmap_data): New function.
6345 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6346 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6347 row. Mark glyph row for fringe update if periodicity changed.
6348
6349 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6350 for fringe update unless it has periodic bitmap.
6351
f16d9837
KH
63522011-05-25 Kenichi Handa <handa@m17n.org>
6353
6354 * xdisp.c (get_next_display_element): Set correct it->face_id for
6355 a static composition.
6356
e1b90ef6
LL
63572011-05-24 Leo Liu <sdl.web@gmail.com>
6358
6359 * deps.mk (fns.o):
6360 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6361
6362 * fns.c (crypto_hash_function, Fsha1): New function.
6363 (Fmd5): Use crypto_hash_function.
6364 (syms_of_fns): Add Ssha1.
6365
7400048f
PE
63662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6367
6368 * gnutls.c: Remove unused macros.
6369 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6370 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6371 Remove macros that are defined and never used.
6372 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6373
abb71cf4
CY
63742011-05-22 Chong Yidong <cyd@stupidchicken.com>
6375
6376 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6377 (Fx_get_selection_internal): Minor cleanup.
6378 (Fx_own_selection_internal): Rename arguments for consistency with
6379 select.el.
6380
6307db39
PE
63812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6382
6383 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6384
f3d4e0a4
CY
63852011-05-22 Chong Yidong <cyd@stupidchicken.com>
6386
6387 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6388
4d8ade89
YM
63892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6390
6391 * dispnew.c (scrolling_window): Don't exclude the case that the
6392 last enabled row in the desired matrix touches the bottom boundary.
6393
32078c8d
GM
63942011-05-21 Glenn Morris <rgm@gnu.org>
6395
6396 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6397 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6398 and add some more files.
32078c8d 6399
7285dc67
EZ
64002011-05-20 Eli Zaretskii <eliz@gnu.org>
6401
6402 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6403 report_file_error introduced by the change from 2011-05-07.
6404
89d1bd22
PE
64052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6406
6407 * systime.h (Time): Define only if emacs is defined.
6408 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6409 where the include path doesn't have X11/X.h by default. See
6410 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6411
cd394be1 64122011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6413
6414 * composite.c (find_automatic_composition): Fix previous change.
6415
b9704ad9
GM
64162011-05-20 Glenn Morris <rgm@gnu.org>
6417
6418 * lisp.mk: New file, split from Makefile.in.
6419 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6420 (shortlisp): Remove.
6421 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6422
4a720484
GM
64232011-05-19 Glenn Morris <rgm@gnu.org>
6424
6425 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6426 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6427 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6428 (lisp): Set the order to that of loadup.el.
6429 (shortlisp): Make it a copy of $lisp.
6430 (SOME_MACHINE_LISP): Remove.
6431 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6432 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6433
a28d4396
KH
64342011-05-18 Kenichi Handa <handa@m17n.org>
6435
6436 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6437 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6438 (find_automatic_composition): Mostly rewrite for efficiency.
6439
a2b1fa8e
JB
64402011-05-18 Juanma Barranquero <lekktu@gmail.com>
6441
6442 * makefile.w32-in: Update dependencies.
6443
8e1f5610
CS
64442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6445
6446 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6447 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6448
7025ee00 64492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6450
cdfa6eab
PE
6451 Fix some integer overflow issues, such as string length overflow.
6452
06d6db33
PE
6453 * insdel.c (count_size_as_multibyte): Check for string overflow.
6454
2b4560a8
PE
6455 * character.c (lisp_string_width): Check for string overflow.
6456 Use EMACS_INT, not int, for string indexes and lengths; in
6457 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6458 the resulting string length overflows an EMACS_INT; instead,
6459 report a string overflow if no precision given. When checking for
6460 precision exhaustion, use a check that cannot possibly have
6461 integer overflow. (Bug#8675)
6462 * character.h (lisp_string_width): Adjust to new signature.
6463
cb93f9be
PE
6464 * alloc.c (string_overflow): New function.
6465 (Fmake_string): Use it. This doesn't change behavior, but saves
6466 a few bytes and will simplify future changes.
6467 * character.c (string_escape_byte8): Likewise.
6468 * lisp.h (string_overflow): New decl.
6469
1a1f3366
PE
6470 Fixups, following up to the user-interface timestamp change.
6471 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6472 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6473 * msdos.c (mouse_get_pos): Likewise.
6474 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6475 * w32gui.h (Time): Define by including "systime.h" rather than by
6476 declaring it ourselves. (Bug#8664)
6477
d4e3e4d3
PE
6478 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6479 * image.c (clear_image_cache): Likewise.
6480
f6a24d19
PE
6481 * term.c (term_mouse_position): Don't assume time_t wraparound.
6482
08dc5ae6
PE
6483 Be more systematic about user-interface timestamps.
6484 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6485 and sometimes 'EMACS_UINT', to represent these timestamps.
6486 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6487 This makes the code easier to follow, and makes it easier to catch
6488 integer overflow bugs such as Bug#8664.
6489 * frame.c (Fmouse_position, Fmouse_pixel_position):
6490 Use Time, not unsigned long, for user-interface timestamps.
6491 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6492 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6493 * keyboard.h (last_event_timestamp): Likewise.
6494 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6495 * menu.h (xmenu_show): Likewise.
6496 * term.c (term_mouse_position): Likewise.
6497 * termhooks.h (struct input_event.timestamp): Likewise.
6498 (struct terminal.mouse_position_hook): Likewise.
6499 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6500 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6501 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6502 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6503 what it was before.
6504 * menu.h, termhooks.h: Include "systime.h", for Time.
6505
8e55734a
PE
6506 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6507 Don't assume that the difference between two unsigned long values
6508 can fit into an integer. At this point, we know button_down_time
6509 <= event->timestamp, so the difference must be nonnegative, so
6510 there's no need to cast the result if double-click-time is
6511 nonnegative, as it should be; check that it's nonnegative, just in
6512 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6513 apart (about 25 days). (Bug#8664)
8e55734a 6514
841f1b75 6515 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6516 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6517
3e26f69c
PE
6518 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6519 that always fit in int. Use a sentinel instead of a counter, to
6520 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6521 * frame.h (struct frame): Use int for menu_bar_items_used
6522 instead of EMACS_INT, since it always fits in int.
3e26f69c 6523
5cc152c0
PE
6524 * menu.c (grow_menu_items): Check for int overflow.
6525
d89eb65e
PE
6526 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6527
5235bd3e
PE
6528 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6529 Before, the code was not consistent. These values cannot exceed
6530 2**31 - 1 so there's no need to make them unsigned.
6531 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6532 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6533 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6534 as modifiers.
6535 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6536
bc827e23
PE
6537 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6538 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6539 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6540 presumably because the widths might not match.
6541
78eb494e
PE
6542 * window.c (size_window): Avoid needless test at loop start.
6543
04f2d78b
CB
65442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6545
6546 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6547
d2fc7e3d 65482011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6549
6550 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6551
d2fc7e3d 65522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6553
6554 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6555 `width' to `bar_area_x' and `bar_area_width', respectively.
6556 (x_scroll_run): Take account of fringe background extension.
6557
04f2d78b
CB
6558 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6559 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6560 `bar_area_width', respectively.
6561 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6562 background extension.
6563
79b70037
GM
65642011-05-10 Jim Meyering <meyering@redhat.com>
6565
6566 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6567
2f142cc5
JB
65682011-05-10 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * image.c (Finit_image_library): Return t for built-in image types,
6571 like pbm and xbm. (Bug#8640)
6572
57679c86
AS
65732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6574
6575 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6576
888c9e86
EZ
65772011-05-07 Eli Zaretskii <eliz@gnu.org>
6578
b0512a1d
EZ
6579 * w32console.c (Fset_screen_color): Doc fix.
6580 (Fget_screen_color): New function.
6581 (syms_of_ntterm): Defsubr it.
6582
7285dc67
EZ
6583 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6584 unlink the temporary file if Fcall_process didn't create it in the
6585 first place.
6586 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6587 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6588 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6589 cue to call_process_cleanup not to close that handle.
6590
4d3fcc8e
BK
65912011-05-07 Ben Key <bkey76@gmail.com>
6592
6593 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6594 one of two shell specific rules, either bootstrap-temacs-CMD or
6595 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6596 to the previous implementation of the bootstrap-temacs rule.
6597 The bootstrap-temacs-CMD rule is similar to the previous
6598 implementation of the bootstrap-temacs rule except that it
6599 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6600 variable.
6601
6602 These changes, along with some changes to nt/configure.bat,
6603 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6604 earlier fix to add support for --cflags and --ldflags options
6605 that include quotes so that it works whether make uses cmd or
6606 sh as the shell.
6607
b4289b64
MA
66082011-05-06 Michael Albinus <michael.albinus@gmx.de>
6609
6610 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6611 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6612 is a constant.
6613 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6614 a string. Handle both cases.
6615 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6616 (Fdbus_register_method): Use Qinvalid_function.
6617
af4c0e28
JB
66182011-05-06 Juanma Barranquero <lekktu@gmail.com>
6619
6620 * makefile.w32-in: Update dependencies.
6621 (LISP_H): Add inttypes.h and stdin.h.
6622 (PROCESS_H): Add unistd.h.
6623
c51453d9
EZ
66242011-05-06 Eli Zaretskii <eliz@gnu.org>
6625
6626 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6627 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6628
8ff0ac3c 66292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6630
4c4b566b
PE
6631 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6632
aab2b9b5
PE
6633 * term.c (vfatal): Remove stray call to va_end.
6634 It's not needed and the C Standard doesn't allow it here anyway.
6635
c378da0b
PE
6636 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6637 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6638
288b08c7
PE
6639 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6640 bytes.
6641
e3601888
PE
6642 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6643
db6c0e74
PE
6644 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6645
dd5963ea
PE
6646 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6647
88c9450f
PE
6648 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6649
2f9442b8
PE
6650 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6651
c032b5f8
PE
6652 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6653 * charset.c (Fdefine_charset_internal): Don't initialize
6654 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6655 32-bit int (Bug#8600).
a108c10b
PE
6656
6657 * lread.c (read_integer): Be more consistent with string-to-number.
6658 Use string_to_number to do the actual conversion; this avoids
6659 rounding errors and fixes some other screwups. Without this fix,
6660 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6661 (digit_to_number): Move earlier, for benefit of read_integer.
6662 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6663 not a digit in any supported base. (Bug#8602)
a108c10b 6664
ad5f9eea
PE
6665 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6666
aec1708a
PE
6667 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6668 to match comment at start of function. This also removes a
6669 GCC warning about overflow in a 32+64-bit port.
6670
47be4ab5
PE
6671 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6672
371cac43
PE
6673 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6674 Reported by Stefan Monnier in
6675 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6676 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6677 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6678
d01a7826
PE
6679 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6680 (EMACS_UINTPTR): Likewise, with uintptr_t.
6681
7fd47d5c
PE
6682 * lisp.h: Prefer 64-bit EMACS_INT if available.
6683 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6684 on 32-bit hosts that have 64-bit int, so that they can access
6685 large files.
122b0c86
PE
6686 However, temporarily disable this change unless the temporary
6687 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6688
8727937b
PE
6689 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6690
8ac068ac
PE
6691 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6692 This removes an assumption that EMACS_INT and long are the same
6693 width as pointers. The assumption is true for Emacs porting targets
6694 now, but we want to make other targets possible.
6695 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6696 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6697 In the rest of the code, change types of integers that hold casted
6698 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6699 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6700 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6701 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6702 No need to cast type when ORing.
6703 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6704 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6705 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6706 assume EMACS_INT is the same width as char *.
6707 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6708 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6709 Remove no-longer-needed casts.
6710 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6711 (xg_tool_bar_help_callback, xg_make_tool_item):
6712 Use EMACS_INTPTR to hold an integer
6713 that will be cast to void *; this can avoid a GCC warning
6714 if EMACS_INT is not the same width as void *.
6715 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6716 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6717 (current_message_1, set_message_1):
6718 Use a local to convert to proper width without a cast.
6719 * xmenu.c (dialog_selection_callback): Likewise.
6720
ede49d71
PE
6721 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6722 Also, don't assume VALBITS / RAND_BITS is less than 5,
6723 and don't rely on undefined behavior when shifting a 1 left into
6724 the sign bit.
6725 * lisp.h (get_random): Change signature to match.
6726
2f30ecd0
PE
6727 * lread.c (hash_string): Use size_t, not int, for hash computation.
6728 Normally we prefer signed values; but hashing is special, because
6729 it's better to use unsigned division on hash table sizes so that
6730 the remainder is nonnegative. Also, size_t is the natural width
6731 for hashing into memory. The previous code used 'int', which doesn't
6732 retain enough info to hash well into very large tables.
6733 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6734
2a866e7b
PE
6735 * dbusbind.c: Don't possibly lose pointer info when converting.
6736 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6737 Use XPNTR rather than XHASH, so that the high-order bits of
6738 the pointer aren't lost when converting through void *.
6739
51639eac
PE
6740 * eval.c (Fautoload): Don't double-shift a pointer.
6741
92394119
PE
6742 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6743
dbdb9a7c
JB
67442011-05-06 Juanma Barranquero <lekktu@gmail.com>
6745
6746 * gnutls.c (DEF_GNUTLS_FN):
6747 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6748
db7a0b4f
AS
67492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6750
6751 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6752 marker. (Bug#8610)
6753
cd394be1 67542011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6755
6756 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6757 New version that can reserve upto 2GB of heap space.
6758
f7ff1b0f 67592011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6760
6761 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6762
639c109b
TZ
67632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6764
6765 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6766 `gnutls_certificate_set_x509_key_file'.
6767
d2127135
JB
67682011-05-05 Juanma Barranquero <lekktu@gmail.com>
6769
6770 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6771 Update dependencies.
6772
e968f4f3
JB
67732011-05-04 Juanma Barranquero <lekktu@gmail.com>
6774
6775 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6776 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6777 Remove unused parameter `fildes'.
6778 * process.c (read_process_output, send_process): Don't pass it.
6779
84d358f0
JB
67802011-05-04 Juanma Barranquero <lekktu@gmail.com>
6781
6782 Fix previous change: the library cache is defined in w32.c.
6783 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6784 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6785
0898ca10
JB
67862011-05-04 Juanma Barranquero <lekktu@gmail.com>
6787
6788 Implement dynamic loading of GnuTLS on Windows.
6789
6790 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6791 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6792 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6793 Declare.
6794
6795 * gnutls.c (Qgnutls_dll): Define.
6796 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6797 (gnutls_*): Declare function pointers.
6798 (init_gnutls_functions): New function to initialize function pointers.
6799 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6800 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6801 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6802 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6803 (emacs_gnutls_write, emacs_gnutls_read)
6804 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6805 (Fgnutls_available_p): New function.
6806 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6807 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6808 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6809
6810 * image.c: Include w32.h.
6811 (Vimage_type_cache): Delete.
6812 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6813 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6814 (w32_delayed_load): Move to w32.c.
6815
6816 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6817
6818 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6819 (w32_delayed_load): Move from image.c. When loading a library, record
6820 its filename in the :loaded-from property of the library id.
6821 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6822 Initialize and staticpro them.
6823 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6824
6825 * process.c: Include lisp.h before w32.h, not after.
6826 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6827 instead of gnutls_record_check_pending.
6828
6829 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6830
ff4de4aa
TZ
68312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6832
6833 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6834 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6835 as passed in.
6836
abe95abb
JD
68372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6838
6839 * xterm.c (x_set_frame_alpha): Do not set property on anything
6840 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6841
e16e55d4
JB
68422011-05-02 Juanma Barranquero <lekktu@gmail.com>
6843
6844 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6845
bafcf6a5
JB
68462011-05-02 Juanma Barranquero <lekktu@gmail.com>
6847
6848 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6849 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6850 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6851 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6852 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6853 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6854 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6855 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6856 (Qgnutls_bootprop_callbacks_verify): Make static.
6857
e7a6747f
AS
68582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6859
19ed11ba
AS
6860 * callproc.c: Indentation fixup.
6861
e7a6747f 6862 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6863 (wait_for_termination, interruptible_wait_for_termination):
6864 Move after wait_for_termination_1.
e7a6747f 6865
1ef14cb4
LMI
68662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6867
6868 * sysdep.c (interruptible_wait_for_termination): New function
6869 which is like wait_for_termination, but allows keyboard
6870 interruptions.
6871
6872 * callproc.c (Fcall_process): Add (:file "file") as an option for
6873 the STDOUT buffer.
6874 (Fcall_process_region): Ditto.
6875
330d880c
EZ
68762011-04-30 Eli Zaretskii <eliz@gnu.org>
6877
8db90b73
EZ
6878 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6879 rather than `XVECTOR (FOO)->size'.
6880
330d880c
EZ
6881 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6882 inttypes.h, as a gnulib replacement is used if it not available in
6883 system headers.
6884
15cbd324
EZ
68852011-04-21 Eli Zaretskii <eliz@gnu.org>
6886
6887 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6888 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6889 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6890
6891 * coding.c (coding_alloc_by_realloc): Error out if destination
6892 will grow beyond MOST_POSITIVE_FIXNUM.
6893 (decode_coding_emacs_mule): Abort if there isn't enough place in
6894 charbuf for the composition carryover bytes. Reserve an extra
6895 space for up to 2 characters produced in a loop.
6896 (decode_coding_iso_2022): Abort if there isn't enough place in
6897 charbuf for the composition carryover bytes.
6898
68992011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6900
ae940cca
EZ
6901 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6902 aborting when %lld or %lll format is passed.
6903 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6904 %llo or %llx format is passed. (Bug#8545)
6905
03ab8921
EZ
6906 * window.c (window_scroll_line_based): Use a marker instead of
6907 simple variables to record original value of point. (Bug#7952)
6908
afda1437
EZ
6909 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6910 produced by %s or %c overflows available buffer space. (Bug#8545)
6911
f76dee0c
PE
69122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6913
6914 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6915 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6916
fdc5744d
JB
69172011-04-28 Juanma Barranquero <lekktu@gmail.com>
6918
6919 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6920
638f053a
JB
69212011-04-28 Juanma Barranquero <lekktu@gmail.com>
6922
6923 * keyboard.c (Qdelayed_warnings_hook): Define.
6924 (command_loop_1): Run `delayed-warnings-hook'
6925 if Vdelayed_warnings_list is non-nil.
6926 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6927 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6928
d178f871
EZ
69292011-04-28 Eli Zaretskii <eliz@gnu.org>
6930
6931 * doprnt.c (doprnt): Don't return value smaller than the buffer
6932 size if the message was truncated. (Bug#8545).
6933
b124fd93
JB
69342011-04-28 Juanma Barranquero <lekktu@gmail.com>
6935
6936 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6937 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6938
e810457d
PE
69392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6940
6941 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6942
ea51cceb
JB
69432011-04-27 Juanma Barranquero <lekktu@gmail.com>
6944
6945 * makefile.w32-in: Update dependencies.
6946
94dcfacf
EZ
69472011-04-27 Eli Zaretskii <eliz@gnu.org>
6948
6949 Improve `doprnt' and its usage. (Bug#8545)
6950 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6951 `format_end'. Remove support for %l as a conversion specifier.
6952 Don't use xrealloc. Improve diagnostics when the %l size modifier
6953 is used. Update the commentary.
6954
6955 * eval.c (verror): Simplify calculation of size_t.
6956
6957 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6958 messages.
6959
f61f41d7
PE
69602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6961
6962 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6963 change.
6964
96fb4434
PE
69652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6966
6967 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6968 This makes this file independent of the recent pseudovector change.
6969
671875da 69702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6971
69e9b5a3
PE
6972 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6973
b5f869a7 6974 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6975 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6976 Remove unused local.
c8926152 6977 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6978
841a1577 6979 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6980 GCC 4.6.0 optimizes based on type-based alias analysis.
6981 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6982 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6983 != &v->size, and therefore "v->size = 1; b->size = 2; return
6984 v->size;" must therefore return 1. This assumption is incorrect
6985 for Emacs, since it type-puns struct Lisp_Vector * with many other
6986 types. To fix this problem, this patch adds a new type struct
f904488f 6987 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6988 and pseudovectors, and helps optimizing compilers not get fooled
6989 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6990 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6991 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6992 the size member.
eab3844f
PE
6993 (XSETPVECTYPE): Rewrite in terms of new macro.
6994 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6995 This is a bit clearer, and further avoids the possibility of
6996 undesirable aliasing.
6997 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6998 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6999 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7000 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7001 (ASIZE): Now uses header.size rather than size.
7002 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7003 to avoid the hassle of writing XVECTOR (foo)->header.size.
7004 (struct vectorlike_header): New type.
eab3844f
PE
7005 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7006 object, to help avoid aliasing.
7007 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7008 (SUBRP): Likewise, since Lisp_Subr is a special case.
7009 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7010 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7011 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7012 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7013 changed to be "header.size" and "header.next".
7014 * buffer.h (struct buffer): Likewise.
7015 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7016 * frame.h (struct frame): Likewise.
7017 * process.h (struct Lisp_Process): Likewise.
7018 * termhooks.h (struct terminal): Likewise.
7019 * window.c (struct save_window_data, struct saved_window): Likewise.
7020 * window.h (struct window): Likewise.
7021 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7022 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7023 * buffer.c (init_buffer_once): Likewise.
7024 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7025 special case.
7026 * process.c (Fformat_network_address): Use local var for size,
7027 for brevity.
7028
0df1eac5
PE
7029 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7030
847ab9d1 7031 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7032 * data.c (atof): Remove decl; no longer used or needed.
7033 (digit_to_number): Move to lread.c.
7034 (Fstring_to_number): Use new string_to_number function, to be
7035 consistent with how the Lisp reader treats infinities and NaNs.
7036 Do not assume that floating-point numbers represent EMACS_INT
7037 without losing information; this is not true on most 64-bit hosts.
7038 Avoid double-rounding errors, by insisting on integers when
7039 parsing non-base-10 numbers, as the documentation specifies.
7040 * lisp.h (string_to_number): New decl, replacing ...
7041 (isfloat_string): Remove.
bc0a5c13 7042 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7043 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7044 appears to have been a coding error. Similarly, do not accept
7045 strings like +-1e0 as floating point numbers. Do not report
7046 overflow for integer overflows unless the base is not 10 which
7047 means we have no simple and reliable way to continue.
7048 Break out the floating-point parsing into a new
7049 function string_to_number, so that Fstring_to_number parses
7050 floating point numbers consistently with the Lisp reader.
04f2d78b 7051 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7052 (E_CHAR, EXP_INT): Remove, replacing with ...
7053 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7054 (string_to_number): New function, replacing isfloat_string.
7055 This function checks for valid syntax and produces the resulting
7056 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7057 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7058 so that overflow for non-base-10 numbers is reported only when
7059 there's no portable and simple way to convert to floating point.
452f4150 7060
67769ffc
PE
7061 * textprop.c (set_text_properties_1): Rewrite for clarity,
7062 and to avoid GCC warning about integer overflow.
7063
c20db43f
PE
7064 * intervals.h (struct interval): Use EMACS_INT for members
7065 where EMACS_UINT might cause problems. See
7066 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7067 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7068 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7069 All uses changed.
37aa2f85
PE
7070 (offset_intervals): Tell GCC not to worry about length overflow
7071 when negating a negative length.
c20db43f 7072
2538aa2f
PE
7073 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7074 (overrun_check_free): Likewise.
7075
f2d3008d
PE
7076 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7077 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7078 word size.
7079
ec8df744
PE
7080 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7081 (gnutls_make_error): Rename local to avoid shadowing.
7082 (gnutls_emacs_global_deinit): ifdef out; not used.
7083 (Fgnutls_boot): Use const for pointer to readonly storage.
7084 Comment out unused local. Fix pointer signedness problems.
7085
640ee02d
PE
7086 * lread.c (openp): Don't stuff size_t into an 'int'.
7087 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7088 about possible signed overflow.
7089
6048fb2a
PE
7090 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7091 (GDK_KEY_g): Don't define if already defined.
7092 (xg_prepare_tooltip): Avoid pointer signedness problem.
7093 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7094
fa3c87e1
PE
7095 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7096 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7097
2172544b
PE
7098 * xfns.c (Fx_window_property): Simplify a bit,
7099 to make a bit faster and to avoid GCC 4.6.0 warning.
7100 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7101
9b821a21
PE
7102 * fns.c (internal_equal): Don't assume size_t fits in int.
7103
3c616cfa
PE
7104 * alloc.c (compact_small_strings): Tighten assertion a little.
7105
c2982e87
PE
7106 Replace pEd with more-general pI, and fix some printf arg casts.
7107 * lisp.h (pI): New macro, generalizing old pEd macro to other
7108 conversion specifiers. For example, use "...%"pI"d..." rather
7109 than "...%"pEd"...".
7110 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7111 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7112 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7113 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7114 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7115 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7116 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7117 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7118 64-bit hosts.
7119 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7120 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7121 * print.c (safe_debug_print, print_object): Likewise.
7122 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7123 to int.
6f04d126
PE
7124 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7125 avoiding the 0 flag, which is not portable.
c2982e87
PE
7126 * process.c (Fmake_network_process): Use pI to avoid cast.
7127 * region-cache.c (pp_cache): Likewise.
7128 * xdisp.c (decode_mode_spec): Likewise.
7129 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7130 behavior on 64-bit hosts with printf arg.
6f04d126 7131 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7132 (x_stop_queuing_selection_requests): Likewise.
7133 (x_get_window_property): Don't truncate byte count to an 'int'
7134 when tracing.
0b432f21 7135
5e073ec7
PE
7136 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7137 here, since it parses constructs like leading '-' and spaces,
7138 which are not wanted; and it overflows with large numbers.
7139 Instead, simply match F[0-9]+, which is what is wanted anyway.
7140
36372bf9
PE
7141 * alloc.c: Remove unportable assumptions about struct layout.
7142 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7143 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7144 (allocate_vectorlike, make_pure_vector): Use the new macros,
7145 plus offsetof, to remove unportable assumptions about struct layout.
7146 These assumptions hold on all porting targets that I know of, but
7147 they are not guaranteed, they're easy to remove, and removing them
7148 makes further changes easier.
7149
0b432f21
PE
7150 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7151 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7152 (string_overrun_cookie): Now const. Use initializers that
7153 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7154 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7155 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7156 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7157 multiple of sizeof (EMACS_INT); it need not be, if
7158 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7159 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7160
895009e1
JB
71612011-04-26 Juanma Barranquero <lekktu@gmail.com>
7162
7163 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7164
6a7a1b0b
TZ
71652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7166
7167 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7168 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7169 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7170
841a1577 71712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7172
7173 * lisp.h (Qdebug): List symbol.
895009e1 7174 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7175 * keyboard.c (debug-on-event): New variable.
7176 (handle_user_signal): Break into debugger when debug-on-event
7177 matches the current signal symbol.
7178
f2d3ba6f
DN
71792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7180
7181 * alloc.c (check_sblock, check_string_bytes)
7182 (check_string_free_list): Convert to standard C.
7183
42ce4c63
TZ
71842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7185
7186 * w32.c (emacs_gnutls_push): Fix typo.
7187
825cd63c
EZ
71882011-04-25 Eli Zaretskii <eliz@gnu.org>
7189
fb11d64d
EZ
7190 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7191 "cast to pointer from integer of different size".
7192
825cd63c
EZ
7193 Improve doprnt and its use in verror. (Bug#8545)
7194 * doprnt.c (doprnt): Document the set of format control sequences
7195 supported by the function. Use SAFE_ALLOCA instead of always
7196 using `alloca'.
7197
7198 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7199 is one byte too soon. Don't use xrealloc; instead xfree and
7200 xmalloc anew.
7201
e061a11b
TZ
72022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7203
7204 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7205 callbacks stage.
7206
7207 * gnutls.c: Renamed global_initialized to
7208 gnutls_global_initialized. Added internals for the
7209 :verify-hostname-error, :verify-error, and :verify-flags
7210 parameters of `gnutls-boot' and documented those parameters in the
7211 docstring. Start callback support.
9173deec
JB
7212 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7213 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7214 on error. Return error code.
e061a11b
TZ
7215 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7216 (emacs_gnutls_read): Likewise.
7217 (Fgnutls_boot): Return handshake error code.
7218 (emacs_gnutls_handle_error): New function.
7219 (wsaerror_to_errno): Likewise.
7220
7221 * w32.h (emacs_gnutls_pull): Add prototype.
7222 (emacs_gnutls_push): Likewise.
7223
7224 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7225 (emacs_gnutls_push): Likewise.
7226
72272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7228
7229 * process.c (wait_reading_process_output): Check if GnuTLS
7230 buffered some data internally if no FDs are set for TLS
7231 connections.
7232
7233 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7234 (LIBS): Link to USER_LIBS.
7235 ($(BLD)/gnutls.$(0)): New target.
7236
fa6996bc
EZ
72372011-04-24 Eli Zaretskii <eliz@gnu.org>
7238
eb35682e
EZ
7239 * xdisp.c (handle_single_display_spec): Rename the
7240 display_replaced_before_p argument into display_replaced_p, to
7241 make it consistent with the commentary. Fix typos in the
7242 commentary.
7243
e2ad650c
EZ
7244 * textprop.c (syms_of_textprop): Remove dead code.
7245 (copy_text_properties): Delete obsolete commentary about an
7246 interface that was deleted long ago. Fix typos in the description
7247 of arguments.
7248
1b2de274
EZ
7249 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7250 to changes in oldXMenu/XMenu.h from 2011-04-16.
7251 <menu_help_message, prev_menu_help_message>: Constify.
7252 (IT_menu_make_room): menu->help_text is now `const char **';
7253 adjust.
7254
7255 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7256 to changes in oldXMenu/XMenu.h from 2011-04-16.
7257 (struct XMenu): Declare `help_text' `const char **'.
7258
7259 * xfaces.c <Qunspecified>: Make extern again.
7260
7261 * syntax.c: Include sys/types.h before including regex.h, as
7262 required by Posix.
7263
762b15be
EZ
7264 * doc.c (get_doc_string): Improve the format passed to `error'.
7265
7266 * doprnt.c (doprnt): Improve commentary.
7267
7268 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7269
7270 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7271 them with etags.
7272
f1052e5d
EZ
7273 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7274 changes in globals.h immediately force recompilation.
762b15be
EZ
7275 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7276 $(CURDIR)/s/ms-w32.h.
7277 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7278
fa6996bc
EZ
7279 * character.c (Fchar_direction): Function deleted.
7280 (syms_of_character): Don't defsubr it.
7281 <char-direction-table>: Deleted.
7282
e6c3da20
EZ
72832011-04-23 Eli Zaretskii <eliz@gnu.org>
7284
7285 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7286 * doprnt.c: Include limits.h.
7287 (SIZE_MAX): New macro.
04f2d78b
CB
7288 (doprnt): Return a size_t value. 2nd arg is now size_t.
7289 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7290 Improve overflow protection. Support `l' modifier for integer
7291 conversions. Support %l conversion. Don't assume an EMACS_INT
7292 argument for integer conversions and for %c.
7293
7294 * lisp.h (doprnt): Restore prototype.
7295
7296 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7297 $(SRC)/character.h.
7298
7299 * Makefile.in (base_obj): Add back doprnt.o.
7300
7301 * deps.mk (doprnt.o): Add back prerequisites.
7302 (callint.o): Depend on character.h.
7303
7304 * eval.c (internal_lisp_condition_case): Include the handler
7305 representation in the error message.
7306 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7307 when breaking from the loop.
7308
7309 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7310
7311 * callint.c (Fcall_interactively): When displaying error message
7312 about invalid control letter, pass the character's codepoint, not
7313 a pointer to its multibyte form. Improve display of the character
7314 in octal and display also its hex code.
7315
7316 * character.c (char_string): Use %x to display the (unsigned)
7317 codepoint of an invalid character, to avoid displaying a bogus
7318 negative value.
7319
7320 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7321 `error', not SYMBOL_NAME itself.
7322
7323 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7324 character arguments to `error'.
7325
7326 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7327 to `error' in error message about FINAL_CHAR argument. Make sure
7328 FINAL_CHAR is a character, and use %c when it is passed as
7329 argument to `error'.
7330
4ffd0d6b 73312011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7332
7333 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7334
7335 * w32.c: Include <time.h>.
7336 (sys_localtime): New function.
7337
4ffd0d6b 73382011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7339
7340 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7341
4ffd0d6b 7342 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7343
4ffd0d6b 73442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7345
4ffd0d6b
GM
7346 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7347 zombies (Bug#8467).
aac0c6e3 7348
04c56954
EZ
73492011-04-19 Eli Zaretskii <eliz@gnu.org>
7350
7351 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7352 gl_state.e_property when gl_state.object is Qt.
7353
7354 * insdel.c (make_gap_larger): Remove limitation of buffer size
7355 to <= INT_MAX.
7356
16a43933
CY
73572011-04-18 Chong Yidong <cyd@stupidchicken.com>
7358
7359 * xdisp.c (lookup_glyphless_char_display)
7360 (produce_glyphless_glyph): Handle cons cell entry in
7361 glyphless-char-display.
7362 (Vglyphless_char_display): Document it.
7363
7364 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7365 glyphless-char-display.
7366
4581706e
CY
73672011-04-17 Chong Yidong <cyd@stupidchicken.com>
7368
7369 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7370
7371 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7372
7373 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7374 definition for no-X builds.
7375
4887c6e2 73762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7377
fd35b6f9
PE
7378 Static checks with GCC 4.6.0 and non-default toolkits.
7379
5c1ccb01
PE
7380 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7381
006c5daa
PE
7382 * process.c (keyboard_bit_set): Define only if SIGIO.
7383 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7384 (send_process): Repair possible setjmp clobbering.
7385
efc736d3
PE
7386 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7387
4e2fe2e6
PE
7388 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7389
f97334a2
PE
7390 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7391
4e75f29d
PE
7392 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7393 Define only if needed.
7394
90efadd1
PE
7395 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7396 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7397 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7398
3c647824
PE
7399 * dispextern.h (struct redisplay_interface): Rename param
7400 to avoid shadowing.
e264f262 7401 * termhooks.h (struct terminal): Likewise.
761383f4 7402 * xterm.c (xembed_send_message): Likewise.
3c647824 7403
b58c5c4a
PE
7404 * insdel.c (make_gap_smaller): Define only if
7405 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7406
cad59032
PE
7407 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7408 it.
7409
c339dc2e
PE
7410 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7411 so that we aren't warned about unused symbols.
7412
91a3e27b
PE
7413 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7414
399c71d3 7415 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7416
8ffc96f5
PE
7417 * xfns.c (x_real_positions): Mark locals as initialized.
7418
eef9bc79
PE
7419 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7420
098db9dd
PE
7421 * xterm.c: Fix problems found by static analysis with other toolkits.
7422 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7423 (x_dispatch_event): Declare static if USE_GTK, and
7424 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7425 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7426 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7427 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7428 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7429
eb18f6cc
PE
7430 * xmenu.c (menu_help_callback): Pointer type fixes.
7431 Use const pointers when pointing at readonly data. Avoid pointer
7432 signedness clashes.
7433 (FALSE): Remove unused macro.
7434 (update_frame_menubar): Remove unused decl.
7435
1fe72bf8
PE
7436 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7437
60d9e1db
PE
7438 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7439 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7440 (single_menu_item): Rename local to avoid shadowing.
7441
39261c26
PE
7442 * keyboard.c (make_lispy_event): Remove unused local var.
7443
018c5e19
PE
7444 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7445 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7446
63d2b86e
PE
7447 * bitmaps: Change bitmaps from unsigned char back to the X11
7448 compatible char. Avoid the old compiler warnings about
7449 out-of-range initializers by using, for example, '\xab' rather
7450 than 0xab.
7451
aefd87e1
PE
7452 * xgselect.c (xgselect_initialize): Check vs interface
7453 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7454
bf501fb9
PE
7455 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7456
e9829fdf
PE
7457 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7458 to read-only memory.
7459
1086c095
PE
7460 * fns.c (vector): Remove; this old hack is no longer needed.
7461
2baccd04 7462 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7463 Remove unused var.
dde42981 7464 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7465
72391843 7466 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7467
436c16df 7468 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7469 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7470 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7471
92bb796d 7472 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7473 (x_term_init): Remove local to avoid shadowing.
92bb796d 7474
764430a3 7475 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7476
7477 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7478 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7479
d1dfb56c
EZ
74802011-04-16 Eli Zaretskii <eliz@gnu.org>
7481
c4354cb4
EZ
7482 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7483
d1dfb56c
EZ
7484 Fix regex.c, syntax.c and friends for buffers > 2GB.
7485 * syntax.h (struct gl_state_s): Declare character position members
7486 EMACS_INT.
7487
7488 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7489
04f2d78b
CB
7490 * textprop.c (verify_interval_modification, interval_of):
7491 Declare arguments EMACS_INT.
d1dfb56c
EZ
7492
7493 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7494 EMACS_INT.
7495
7496 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7497
7498 * indent.c (Fvertical_motion): Local variable it_start is now
7499 EMACS_INT.
7500
7501 * regex.c (re_match, re_match_2, re_match_2_internal)
7502 (bcmp_translate, regcomp, regexec, print_double_string)
7503 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7504 (re_compile_pattern, re_exec): Declare arguments and local
7505 variables `size_t' and `ssize_t' and return values `regoff_t', as
7506 appropriate.
7507 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7508 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7509 <compile_stack_type>: `size' and `avail' are now `size_t'.
7510
7511 * regex.h <regoff_t>: Use ssize_t, not int.
7512 (re_search, re_search_2, re_match, re_match_2): Arguments that
7513 specify buffer/string position and length are now ssize_t and
7514 size_t. Return type is regoff_t.
7515
613052cd
BK
75162011-04-16 Ben Key <bkey76@gmail.com>
7517
7518 * nsfont.m: Fixed bugs in ns_get_family and
7519 ns_descriptor_to_entity that were caused by using free to
7520 deallocate memory blocks that were allocated by xmalloc (via
7521 xstrdup). This caused Emacs to crash when compiled with
7522 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7523 --enable-checking=xmallocoverrun). xfree is now used to
7524 deallocate these memory blocks.
7525
4170f62f 75262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7527
71b41406
PE
7528 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7529
9587a89d
PE
7530 emacs_write: Accept and return EMACS_INT for sizes.
7531 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7532 et seq.
7533 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7534 Accept and return EMACS_INT.
7535 (emacs_gnutls_write): Return the number of bytes written on
7536 partial writes.
7537 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7538 (emacs_read, emacs_write): Remove check for negative size, as the
7539 Emacs source code has been audited now.
9587a89d
PE
7540 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7541 (emacs_read, emacs_write): Use it.
273a5f82
PE
7542 * process.c (send_process): Adjust to the new signatures of
7543 emacs_write and emacs_gnutls_write. Do not attempt to store
7544 a byte offset into an 'int'; it might overflow.
9587a89d 7545 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7546
3e047f51
PE
7547 * sound.c: Don't assume sizes fit in 'int'.
7548 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7549 Return EMACS_INT, not int.
3e047f51 7550 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7551 Accept EMACS_INT, not int.
7552 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7553 record read return values.
7554
cc39a9db
BK
75552011-04-15 Ben Key <bkey76@gmail.com>
7556
c9d0ec6d
JB
7557 * keyboard.c (Qundefined): Don't declare static since it is used
7558 in nsfns.m.
7559 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7560 static since they are used in nsfont.m.
cc39a9db 7561
6c60eb9f
SM
75622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7563
7564 * process.c (Qprocessp): Don't declare static.
7565 * lisp.h (Qprocessp): Declare again.
7566
7990b61a
JB
75672011-04-15 Juanma Barranquero <lekktu@gmail.com>
7568
7569 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7570
5d4cb038
PE
75712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7572
8bd7b830 7573 Improve C-level modularity by making more things 'static'.
cd64ea1d 7574
e3b27b31
PE
7575 Don't publish debugger-only interfaces to other modules.
7576 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7577 (verify_bytepos, count_markers): Move decls to the only modules
7578 that need them.
7579 * region-cache.h (pp_cache): Likewise.
7580 * window.h (check_all_windows): Likewise.
7581 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7582
5d4cb038
PE
7583 * sysdep.c (croak): Now static, if
7584 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7585 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7586
7587 * alloc.c (refill_memory_reserve): Now static if
7588 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7589 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7590
e87b6180
PE
7591 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7592 Define only if USE_LUCID.
7593
ac64929e
PE
7594 * xrdb.c (x_customization_string, x_rm_string): Now static.
7595
6f37259d
PE
7596 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7597 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7598
1683e3ab
PE
7599 * xdisp.c (draw_row_with_mouse_face): Now static.
7600 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7601
de9c2632
PE
7602 * window.h (check_all_windows): Mark externally visible.
7603
2b96acb7
PE
7604 * window.c (window_deletion_count): Now static.
7605
7606 * undo.c: Make symbols static if they're not exported.
7607 (last_undo_buffer, last_boundary_position, pending_boundary):
7608 Now static.
7609
50436f33
PE
7610 * textprop.c (interval_insert_behind_hooks): Now static.
7611 (interval_insert_in_front_hooks): Likewise.
7612
64520e5c
PE
7613 * term.c: Make symbols static if they're not exported.
7614 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7615 (max_frame_lines, tty_set_terminal_modes):
7616 (tty_reset_terminal_modes, tty_turn_off_highlight):
7617 (get_tty_terminal): Now static.
7618 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7619 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7620 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7621 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7622 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7623
1fa53021
PE
7624 * sysdep.c: Make symbols static if they're not exported.
7625 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7626 Now static.
7627 (sigprocmask_set, full_mask): Remove; unused.
7628 (wait_debugging): Mark as visible.
7629 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7630 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7631
d4b43b22
PE
7632 * syntax.c (syntax_temp): Define only if !__GNUC__.
7633
b7c513d0
PE
7634 * sound.c (current_sound_device, current_sound): Now static.
7635
989b29ad
PE
7636 * search.c (searchbufs, searchbuf_head): Now static.
7637
13a55a78
PE
7638 * scroll.c (scroll_cost): Remove; unused.
7639 * dispextern.h (scroll_cost): Remove decl.
7640
de68a1fc
PE
7641 * region-cache.h (pp_cache): Mark as externally visible.
7642
40ccffa6
PE
7643 * process.c: Make symbols static if they're not exported.
7644 (process_tick, update_tick, create_process, chan_process):
7645 (Vprocess_alist, proc_buffered_char, datagram_access):
7646 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7647 (deactivate_process): Mark defn as static, as well as decl.
7648 * lisp.h (create_process): Remove decl.
7649 * process.h (chan_process, Vprocess_alist): Remove decls.
7650
ad64fc97
PE
7651 * print.c: Make symbols static if they're not exported.
7652 (print_depth, new_backquote_output, being_printed, print_buffer):
7653 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7654 (print_interval, print_number_index, initial_stderr_stream):
7655 Now static.
7656 * lisp.h (Fprinc): Remove decl.
7657 (debug_output_compilation_hack): Mark as externally visible.
7658
adddb265
PE
7659 * sysdep.c (croak): Move decl from here to syssignal.h.
7660 * syssignal.h (croak): Put it here, so the API can be checked when
7661 'croak' is called from dissociate_if_controlling_tty.
7662
1717ede2
PE
7663 * minibuf.c: Make symbols static if they're not exported.
7664 (minibuf_save_list, choose_minibuf_frame): Now static.
7665 * lisp.h (choose_minibuf_frame): Remove decl.
7666
fa5fb2bc
PE
7667 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7668
1e3890d1
PE
7669 * lread.c: Make symbols static if they're not exported.
7670 (read_objects, initial_obarray, oblookup_last_bucket_number):
7671 Now static.
7672 (make_symbol): Remove; unused.
7673 * lisp.h (initial_obarray, make_symbol): Remove decls.
7674
8a1414fa
PE
7675 * keyboard.c: Make symbols static if they're not exported.
7676 (single_kboard, recent_keys_index, total_keys, recent_keys):
7677 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7678 (this_single_command_key_start, echoing, last_auto_save):
7679 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7680 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7681 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7682 (Vlispy_mouse_stem, double_click_count):
7683 Now static.
7684 (force_auto_save_soon): Define only if SIGDANGER.
7685 (ignore_mouse_drag_p): Now static if
7686 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7687 (print_help): Remove; unused.
7688 (stop_character, last_timer_event): Mark as externally visible.
7689 * keyboard.h (ignore_mouse_drag_p): Declare only if
7690 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7691 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7692 * lisp.h (echoing): Remove decl.
7693 (force_auto_save_soon): Declare only if SIGDANGER.
7694 * xdisp.c (redisplay_window): Simplify code, to make it more
7695 obvious that ignore_mouse_drag_p is not accessed if !defined
7696 USE_GTK && !defined HAVE_NS.
7697
93ea6e8f
PE
7698 * intervals.c: Make symbols static if they're not exported.
7699 (merge_properties_sticky, merge_interval_right, delete_interval):
7700 Now static.
7701 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7702
77382fcc
PE
7703 * insdel.c: Make symbols static if they're not exported.
7704 However, leave prepare_to_modify_buffer alone. It's never
7705 called from outside this function, but that appears to be a bug.
7706 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7707 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7708 (adjust_after_replace_noundo): Remove; unused.
7709 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7710 (signal_before_change): Remove decls.
77382fcc 7711
9306c32e
PE
7712 * indent.c (val_compute_motion, val_vmotion): Now static.
7713
cd44d2eb
PE
7714 * image.c: Make symbols static if they're not exported.
7715 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7716 if USE_GTK.
7717 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7718 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7719
ad9a7a06
PE
7720 * fringe.c (standard_bitmaps): Now static.
7721 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7722
81626931
PE
7723 * frame.c: Make symbols static if they're not exported.
7724 (x_report_frame_params, make_terminal_frame): Now static.
7725 (get_frame_param): Now static, unless HAVE_NS.
7726 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7727 (x_get_resource_string): Remove; not used.
7728 * frame.h (make_terminal_frame, x_report_frame_params):
7729 (x_get_resource_string); Remove decls.
7730 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7731 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7732
239f9db9
PE
7733 * font.c, fontset.c: Make symbols static if they're not exported.
7734 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7735 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7736 * font.c (font_close_object): Now static.
7737 * font.h (font_close_object): Remove.
7738 * fontset.c (FONTSET_OBJLIST): Remove.
7739 (free_realized_fontset) #if-0 the body, which does nothing.
7740 (face_suitable_for_char_p): #if-0, as it's never called.
7741 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7742 * xfaces.c (face_at_string_position):
7743 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7744 since 0 is always ASCII.
7745
dfcf3579
PE
7746 * fns.c (weak_hash_tables): Now static.
7747
5045092b
PE
7748 * fileio.c: Make symbols static if they're not exported.
7749 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7750 (Vwrite_region_annotation_buffers): Now static.
7751
57a96f5c
PE
7752 * eval.c: Make symbols static if they're not exported.
7753 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7754 * lisp.h (backtrace_list): Remove decl.
7755
35f08c38
PE
7756 * emacs.c: Make symbols static if they're not exported.
7757 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7758 (fatal_error_code, fatal_error_signal_hook, standard_args):
7759 Now static.
7760 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7761 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7762 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7763 * lisp.h (fatal_error_signal_hook): Remove decl.
7764 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7765
f44bd759
PE
7766 * editfns.c: Move a (normally-unused) function to its only use.
7767 * editfns.c, lisp.h (get_operating_system_release): Remove.
7768 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7769 worth the hassle of breaking this out.
7770
b532497d
PE
7771 * xterm.c: Make symbols static if they're not exported.
7772 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7773 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7774 (x_destroy_window, x_delete_display):
7775 Now static.
7776 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7777 (x_mouse_leave): Remove; unused.
7778 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7779 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7780 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7781 Remove decls.
7782 (x_mouse_leave): Declare only if WINDOWSNT.
7783 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7784 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7785 USE_X_TOOLKIT.
7786
1675728f
PE
7787 * ftxfont.c: Make symbols static if they're not exported.
7788 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7789 HAVE_FREETYPE.
7790 * font.h (ftxfont_driver): Likewise.
7791
e4cebfca
PE
7792 * xfns.c: Make symbols static if they're not exported.
7793 (x_last_font_name, x_display_info_for_name):
7794 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7795 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7796 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7797 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7798 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7799 (last_show_tip_args): Now static.
7800 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7801 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7802 (x_screen_planes): Remove; unused.
7803 * dispextern.h (x_screen_planes): Remove decl.
7804
5bf46f05
PE
7805 * dispnew.c: Make symbols static if they're not exported.
7806 * dispextern.h (redraw_garbaged_frames, scrolling):
7807 (increment_row_positions): Remove.
7808 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7809 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7810 Now static.
7811 (redraw_garbaged_frames): Remove; unused.
7812
435f4c28
PE
7813 * xfaces.c: Make symbols static if they're not exported.
7814 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7815 Remove decls.
7816 * xterm.h (defined_color): Remove decls.
7817 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7818 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7819 (menu_face_changed_default, defined_color, free_realized_face):
7820 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7821 (ascii_face_of_lisp_face): Remove; unused.
7822
8524aef3
PE
7823 * xdisp.c: Make symbols static if they're not exported.
7824 * dispextern.h (scratch_glyph_row, window_box_edges):
7825 (glyph_to_pixel_coords, set_cursor_from_row):
7826 (get_next_display_element, set_iterator_to_next):
7827 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7828 (show_mouse_face): Remove decls
7829 * frame.h (message_buf_print): Likewise.
7830 * lisp.h (pop_message, set_message, check_point_in_composition):
7831 Likewise.
7832 * xterm.h (set_vertical_scroll_bar): Likewise.
7833 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7834 (message_buf_print, scratch_glyph_row, displayed_buffer):
7835 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7836 (get_next_display_element, show_mouse_face, window_box_edges):
7837 (frame_to_window_pixel_xy, check_point_in_composition):
7838 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7839 (glyph_to_pixel_coords): Remove; unused.
7840
16390cd2
PE
7841 * dired.c (file_name_completion): Now static.
7842
7843 * dbusbind.c (xd_in_read_queued_messages): Now static.
7844
a25f4dfa
PE
7845 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7846 * data.c (circular_list_error): Remove.
7847
14a9c8df
PE
7848 * commands.h (last_point_position, last_point_position_buffer):
7849 (last_point_position_window): Remove decls.
7850 * keyboard.c: Make these variables static.
7851
04f2d78b
CB
7852 * coding.h (coding, code_convert_region, encode_coding_gap):
7853 Remove decls.
74ab6df5
PE
7854 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7855 (iso_code_class, detect_coding, code_convert_region): Now static.
7856 (encode_coding_gap): Remove; unused.
7857
38dfbee1
PE
7858 * chartab.c (chartab_chars, chartab_bits): Now static.
7859
a2cb4e63
PE
7860 * charset.h (charset_iso_8859_1): Remove decl.
7861 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7862 Now static.
7863
127198fd
PE
7864 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7865 * ccl.c (Vccl_program_table): Now static.
7866 (check_ccl_update): Remove; unused.
7867
d85b608f
PE
7868 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7869 * category.h: ... from here.
7870 * category.c (check_category_table, set_category_set): Now static.
7871
31cd66f3
PE
7872 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7873 * lisp.h: Remove these decls.
7874
c358e587
PE
7875 * buffer.c (buffer_count): Remove unused var.
7876
e78aecca
PE
7877 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7878 so that it's not optimized away.
7879 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7880 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7881 exported only to the debugger.
7882
e192d7d3 7883 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7884 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7885
92470028
PE
7886 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7887 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7888 was inaccessible from Lisp.
7889 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7890 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7891
244ed907
PE
7892 alloc.c: Import and export fewer symbols, and remove unused items.
7893 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7894 is defined.
7895 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7896 it's not optimized away by whole-program optimization.
7897 (message_enable_multibyte, free_misc): Remove.
7898 (catchlist, handlerlist, mark_backtrace):
7899 Declare only if BYTE_MARK_STACK.
7900 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7901 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7902 (message_enable_multibyte): Remove decl.
7903 (free_misc, interval_free_list, float_block, float_block_index):
7904 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7905 (cons_free_list, last_marked_index):
7906 Now static.
7907 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7908 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7909 (mark_backtrace): Define only if BYTE_MARK_STACK.
7910 * xdisp.c (message_enable_multibyte): Now static.
7911
61c2b50e 7912 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7913 This makes it easier for human readers (and static analyzers)
7914 to see whether these variables are used from other modules.
7915 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7916 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7917 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7918 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7919 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7920 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7921 * xmenu.c, xselect.c:
7922 Declare Q* vars static if they are not used in other modules.
7923 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7924 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7925 Remove decls of unexported vars.
7926 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7927
95c82688
PE
7928 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7929
16a97296
PE
7930 Make Emacs functions such as Fatom 'static' by default.
7931 This makes it easier for human readers (and static analyzers)
7932 to see whether these functions can be called from other modules.
7933 DEFUN now defines a static function. To make the function external
7934 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7935 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7936 (Finit_image_library):
16a97296
PE
7937 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7938 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7939 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7940 Remove decls, since these functions are now static.
7941 (Funintern, Fget_internal_run_time): New decls, since these functions
7942 were already external.
95c82688 7943
16a97296
PE
7944 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7945 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7946 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7947 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7948 * keyboard.c, keymap.c, lread.c:
7949 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7950 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7951 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7952 Mark functions with DEFUE instead of DEFUN,
7953 if they are used in other modules.
7954 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7955 decls for now-static functions.
7956 * buffer.h (Fdelete_overlay): Remove decl.
7957 * callproc.c (Fgetenv_internal): Mark as internal.
7958 * composite.c (Fremove_list_of_text_properties): Remove decl.
7959 (Fcomposition_get_gstring): New forward static decl.
7960 * composite.h (Fcomposite_get_gstring): Remove decl.
7961 * dired.c (Ffile_attributes): New forward static decl.
7962 * doc.c (Fdocumntation_property): New forward static decl.
7963 * eval.c (Ffetch_bytecode): New forward static decl.
7964 (Funintern): Remove extern decl; now in .h file where it belongs.
7965 * fileio.c (Fmake_symbolic_link): New forward static decl.
7966 * image.c (Finit_image_library): New forward static decl.
7967 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7968 * intervals.h (Fprevious_property_change):
7969 (Fremove_list_of_text_properties): Remove decls.
7970 * keyboard.c (Fthis_command_keys): Remove decl.
7971 (Fcommand_execute): New forward static decl.
7972 * keymap.c (Flookup_key): New forward static decl.
7973 (Fcopy_keymap): Now static.
7974 * keymap.h (Flookup_key): Remove decl.
7975 * process.c (Fget_process): New forward static decl.
7976 (Fprocess_datagram_address): Mark as internal.
7977 * syntax.c (Fsyntax_table_p): New forward static decl.
7978 (skip_chars): Remove duplicate decl.
7979 * textprop.c (Fprevious_property_change): New forward static decl.
7980 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7981 Now internal.
7982 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7983 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7984
785bbd42
PE
7985 * editfns.c (Fformat): Remove unreachable code.
7986
8b913b57
AS
79872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7988
7989 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7990 change. (Bug#8496)
7991
a6744a35
EZ
79922011-04-13 Eli Zaretskii <eliz@gnu.org>
7993
7994 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7995 when at ZV. (Bug#8487)
7996
e7974947
AS
79972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7998
baad03f0
AS
7999 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8000 (Bug#8437)
8001 * keyboard.c (parse_tool_bar_item): Likewise.
8002 * sound.c (sound_cleanup, alsa_close): Likewise.
8003 * termcap.c (tgetent): Likewise.
8004 * xfns.c (x_default_font_parameter): Likewise.
8005 * xsettings.c (read_and_apply_settings): Likewise.
8006
e7974947
AS
8007 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8008 (overrun_check_free): Protoize.
8009
28272684
PE
80102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8011
8012 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8013 since callers should never pass a negative size.
8014 Change the signature to match that of plain 'read' and 'write'; see
8015 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8016 * lisp.h: Update prototypes of emacs_write and emacs_read.
8017
11997c76
EZ
80182011-04-11 Eli Zaretskii <eliz@gnu.org>
8019
8020 * xdisp.c (redisplay_window): Don't try to determine the character
8021 position of the scroll margin if the window start point w->startp
e896f03c 8022 is outside the buffer's accessible region. (Bug#8468)
11997c76 8023
8a2cbd72
EZ
80242011-04-10 Eli Zaretskii <eliz@gnu.org>
8025
8026 Fix write-region and its subroutines for buffers > 2GB.
8027 * fileio.c (a_write, e_write): Modify declaration of arguments and
8028 local variables to support buffers larger than 2GB.
8029 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8030
8031 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8032 argument, local variables, and return value.
8033
8034 * lisp.h: Update prototypes of emacs_write and emacs_read.
8035
8036 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8037
4073e537 80382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8039
1ebfdcb6
PE
8040 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8041
b2ded58d
PE
8042 Fix more problems found by GCC 4.6.0's static checks.
8043
7d66342c
PE
8044 * xdisp.c (vmessage): Use a better test for character truncation.
8045
bbf47d44
PE
8046 * charset.c (load_charset_map): <, not <=, for optimization,
8047 and to avoid potential problems with integer overflow.
9248994d 8048 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8049 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8050 * editfns.c (Fformat): Likewise.
1e69125e 8051 * syntax.c (skip_chars): Likewise.
3befa583 8052
e3019616
PE
8053 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8054 This also lets GCC 4.6.0 generate slightly better loop code.
8055
becfa255
PE
8056 * callint.c (Fcall_interactively): <, not <=, for optimization.
8057 (Fcall_interactively): Count the number of arguments produced,
8058 not the number of arguments given. This is simpler and lets GCC
8059 4.6.0 generate slightly better code.
8060
dae0cd48
PE
8061 * ftfont.c: Distingish more carefully between FcChar8 and char.
8062 The previous code passed unsigned char * to a functions like
8063 strlen and xstrcasecmp that expect char *, which does not
8064 conform to the C standard.
8065 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8066 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8067 char * when the C standard requires it.
8068
76032d70
PE
8069 * keyboard.c (read_char): Remove unused var.
8070
eb3f1cc8
PE
8071 * eval.c: Port to Windows vsnprintf (Bug#8435).
8072 Include <limits.h>.
8073 (SIZE_MAX): Define if the headers do not.
8074 (verror): Do not give up if vsnprintf returns a negative count.
8075 Instead, grow the buffer. This ports to Windows vsnprintf, which
8076 does not conform to C99. Problem reported by Eli Zaretskii.
8077 Also, simplify the allocation scheme, by avoiding the need for
8078 calling realloc, and removing the ALLOCATED variable.
8079
70476b54
PE
8080 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8081
12020a9e
PE
8082 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8083 But keep the doprint source code for now, as we might revamp it
8084 and use it again (Bug#8435).
ea6c7ae6
PE
8085 * lisp.h (doprnt): Remove.
8086 * Makefile.in (base_obj): Remove doprnt.o.
8087 * deps.mk (doprnt.o): Remove.
8088
5fdb398c
PE
8089 error: Print 32- and 64-bit integers portably (Bug#8435).
8090 Without this change, on typical 64-bit hosts error ("...%d...", N)
8091 was used to print both 32- and 64-bit integers N, which relied on
8092 undefined behavior.
61bdb816 8093 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8094 * lisp.h (error, verror): Mark as printf-like functions.
8095 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8096 Report overflow in size calculations when allocating printf buffer.
8097 Do not truncate output string at its first null byte.
8098 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8099 Truncate the output at a character boundary, since vsnprintf does not
8100 do that.
8101 * charset.c (check_iso_charset_parameter): Convert internal
8102 character to string before calling 'error', since %c now has the
8103 printf meaning.
8104 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8105 overflow when computing char to be passed to 'error'. Do not
8106 pass Lisp_Object to 'error'; pass the integer instead.
8107 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8108 formatted with plain %d.
8109
b189fa66
PE
8110 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8111
bff87ef0
PE
8112 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8113
7e2cac20
PE
8114 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8115
ce4d90b5
PE
8116 * xterm.c (x_catch_errors): Remove duplicate declaration.
8117
266c9547
PE
8118 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8119
79c49ad2
PE
8120 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8121
368f4090
JM
81222011-04-10 Jim Meyering <meyering@redhat.com>
8123
8124 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8125 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8126 return ssize_t not "int", and use size_t as the buffer length.
8127 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8128 * gnutls.h: Update declarations.
8129 * process.c (read_process_output): Use ssize_t, to match.
8130 (send_process): Likewise.
8131
a32d4040
CY
81322011-04-09 Chong Yidong <cyd@stupidchicken.com>
8133
8134 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8135
8546720e 81362011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8137
04f2d78b
CB
8138 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8139 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8140
8546720e
GM
8141 * xterm.c (handle_one_xevent):
8142 * xmenu.c (create_and_show_popup_menu):
8143 * xselect.c (x_decline_selection_request)
8144 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8145
0a2f5c1a 81462011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8147
8148 Fix some uses of `int' instead of EMACS_INT.
8149 * search.c (string_match_1, fast_string_match)
8150 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8151 (scan_buffer, find_next_newline_no_quit)
8152 (find_before_next_newline, search_command, Freplace_match)
8153 (Fmatch_data): Make some `int' variables be EMACS_INT.
8154
8155 * xdisp.c (display_count_lines): 3rd argument and return value now
8156 EMACS_INT. All callers changed.
8157 (pint2hrstr): Last argument is now EMACS_INT.
8158
8159 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8160 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8161 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8162 (decode_coding_utf_16, decode_coding_emacs_mule)
8163 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8164 (decode_coding_ccl, decode_coding_charset)
8165 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8166 (decode_coding_iso_2022, decode_coding_emacs_mule)
8167 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8168 <char_offset, last_offset>: Declare EMACS_INT.
8169 (encode_coding_utf_8, encode_coding_utf_16)
8170 (encode_coding_emacs_mule, encode_invocation_designation)
8171 (encode_designation_at_bol, encode_coding_iso_2022)
8172 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8173 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8174 Declare EMACS_INT.
8175 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8176 (encode_invocation_designation): Last argument P_NCHARS is now
8177 EMACS_INT.
8178 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8179 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8180
8181 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8182 All users changed.
8183
8184 * ccl.c (Fccl_execute_on_string): Declare some variables
8185 EMACS_INT.
8186
8546720e 81872011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8188
8189 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8190
4e19a977
CS
81912011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8192
8193 * process.c (Fformat_network_address): Doc fix.
8194
87302331
R
81952011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8196
ee7683eb 8197 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8198
cbb59342
CY
81992011-04-08 Chong Yidong <cyd@stupidchicken.com>
8200
8201 * keyboard.c (read_char): Call Lisp function help-form-show,
8202 instead of using internal_with_output_to_temp_buffer.
8203 (Qhelp_form_show): New var.
e0d38eeb 8204 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8205
8206 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8207
8208 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8209
e67a13ab
CY
82102011-04-06 Chong Yidong <cyd@stupidchicken.com>
8211
04f2d78b
CB
8212 * process.c (Flist_processes): Remove to Lisp.
8213 (list_processes_1): Delete.
e67a13ab 8214
973f782d
EZ
82152011-04-06 Eli Zaretskii <eliz@gnu.org>
8216
7c106b1e
EZ
8217 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8218
973f782d
EZ
8219 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8220
41cf7d1a 82212011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8222
ca23cc88
PE
8223 Fix more problems found by GCC 4.6.0's static checks.
8224
f390e2d5
PE
8225 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8226
42eea0d0
PE
8227 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8228
b69769da 8229 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8230
f9541e84
PE
8231 * xdisp.c (vmessage): Mark as a printf-like function.
8232
13841b55
PE
8233 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8234
c136c10f
PE
8235 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8236
5e2d4a30
PE
8237 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8238 printf-like functions.
8239 (tiff_load): Add casts to remove these marks before passing them
8240 to system-supplied API.
8241
583f48b9
PE
8242 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8243
b25d760e
PE
8244 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8245 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8246 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8247 directly, rather than having caller test rule sign. This avoids
8248 some unnecessary tests.
8249 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8250 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8251 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8252
bc7b6697 8253 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8254 (xfont_open): Avoid unnecessary tests.
bc7b6697 8255
27ccc379
PE
8256 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8257
dcd5c89a
PE
8258 * composite.h, composite.c (composition_gstring_put_cache):
8259 Use EMACS_INT, not int, for length.
8260
b13a45c6
PE
8261 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8262 breaking out part of COMPOSITION_DECODE_RULE.
8263 (COMPOSITION_DECODE_RULE): Use it.
8264 * composite.c (get_composition_id): Remove unused local vars,
8265 by using the new macro.
8266
1e792e4d
PE
8267 * textprop.c (set_text_properties_1): Change while to do-while,
8268 since the condition is always true at first.
8269
dc6c6455 8270 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8271 (interval_deletion_adjustment): Return unsigned value.
8272 All uses changed.
dc6c6455 8273
aba7731a
PE
8274 * process.c (list_processes_1, create_pty, read_process_output):
8275 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8276 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8277 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8278 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8279 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8280
fdfc4bf3
PE
8281 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8282
fca8fe46 8283 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8284 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8285
06a0259a 8286 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8287 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8288 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8289
e7b9e80f
PE
8290 * print.c (print_error_message): Avoid int overflow.
8291
56201685
PE
8292 * font.c (font_list_entities): Redo for clarity,
8293 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8294
78834453 8295 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8296 (font_score): Avoid potential overflow in diff calculation.
78834453 8297
0bc0b309 8298 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8299 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8300
e610eaca
PE
8301 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8302
b895abce
PE
8303 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8304 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8305 can always succeed if overflow has undefined behavior.
8306
1f1d9321 8307 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8308 (wordify): Omit three unnecessary tests.
1f1d9321 8309
c59478bc
PE
8310 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8311 All callers changed. This avoids the need for an unused var.
8312
79b73827
PE
8313 * casefiddle.c (casify_region): Remove var that is set but not used.
8314
a4db5dfe
PE
8315 * dired.c (file_name_completion): Remove var that is set but not used.
8316
43aae36e
PE
8317 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8318
2a47c44d 8319 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8320 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8321
a37c69bf
PE
8322 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8323 Check for integer overflow on size calculations.
8324
328ab8e7
PE
8325 * buffer.c (Fprevious_overlay_change): Remove var that is set
8326 but not used.
8327
e5a2a5cb
PE
8328 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8329 Remove vars that are set but not used.
8d84a6eb 8330 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8331 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8332
a60e5f68
PE
8333 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8334
f661cb61 8335 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8336 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8337
f0397f5a
PE
8338 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8339 that are set but not used.
8340
8664db06 8341 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8342 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8343
6abdaa4a
PE
8344 * xselect.c (x_get_local_selection, x_handle_property_notify):
8345 Remove vars that are set but not used.
8346
0ce7538d 8347 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8348 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8349
9ae848fc
PE
8350 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8351 Remove var that is set but not used.
0b918413
PE
8352 (scroll_bar_windows_size): Now size_t, not int.
8353 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8354 Check for overflow.
9ae848fc 8355
a5a62657
PE
8356 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8357 (map_tty_color) [!defined MSDOS]: Likewise.
8358
5c5cdd39
PE
8359 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8360
66ebf983
PE
8361 * coding.c: Remove vars that are set but not used.
8362 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8363 All callers changed.
8364 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8365 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8366 (decode_coding_charset): Remove vars that are set but not used.
8367
1be4d761
PE
8368 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8369 that is set but not used.
8370
47553fa8
PE
8371 * print.c (print_object): Remove var that is set but not used.
8372
1f7196bf 8373 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8374 The gnulib version avoids calling malloc in the usual case,
8375 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8376 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8377 * filelock.c (current_lock_owner): Likewise.
8378 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8379 * sysdep.c: Include allocator.h, careadlinkat.h.
8380 (emacs_no_realloc_allocator): New static constant.
8381 (emacs_readlink): New function.
fdb61804
PE
8382 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8383 ../lib/careadlinkat.h.
d1fdcab7 8384
f84c17c7
SM
83852011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8386
8387 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8388 first non-nil return value).
8389
ef3862ad
JD
83902011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8391
8392 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8393 if not defined (Bug#8403).
8394
376a7006
JB
83952011-04-02 Juanma Barranquero <lekktu@gmail.com>
8396
8397 * xdisp.c (display_count_lines): Remove parameter `start',
8398 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8399 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8400 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8401 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8402 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8403 and thereabouts. All callers changed.
8404 (get_per_char_metric): Remove parameter `f', unused since
8405 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8406
6ca3801d
JM
84072011-04-02 Jim Meyering <meyering@redhat.com>
8408
8409 do not dereference NULL upon failed strdup
8410 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8411 (ns_get_family): Likewise.
8412
d8e2b5ba
JB
84132011-04-02 Juanma Barranquero <lekktu@gmail.com>
8414
8415 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8416
8c74fcbd
JD
84172011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8418
8419 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8420 later (Bug#8403).
8421
7200d79c
SM
84222011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8423
03408648 8424 Add lexical binding.
7200d79c 8425
03408648
SM
8426 * window.c (Ftemp_output_buffer_show): New fun.
8427 (Fsave_window_excursion):
8428 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8429
8430 * lread.c (lisp_file_lexically_bound_p): New function.
8431 (Fload): Bind Qlexical_binding.
8432 (readevalloop): Remove `evalfun' arg.
8433 Bind Qinternal_interpreter_environment.
8434 (Feval_buffer): Bind Qlexical_binding.
8435 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8436 Mark as dynamic.
8437 (syms_of_lread): Declare `lexical-binding'.
8438
8439 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8440
8441 * keyboard.c (eval_dyn): New fun.
8442 (menu_item_eval_property): Use it.
ca105506
SM
8443
8444 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8445
03408648
SM
8446 * fns.c (concat, mapcar1): Accept byte-code-functions.
8447
8448 * eval.c (Fsetq): Handle lexical vars.
8449 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8450 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8451 (FletX, Flet): Obey lexical binding.
8452 (Fcommandp): Handle closures.
8453 (Feval): New `lexical' arg.
8454 (eval_sub): New function extracted from Feval. Use it almost
8455 everywhere where Feval was used. Look up vars in lexical env.
8456 Handle closures.
8457 (Ffunctionp): Move from subr.el.
8458 (Ffuncall): Handle closures.
8459 (apply_lambda): Remove `eval_flags'.
8460 (funcall_lambda): Handle closures and new byte-code-functions.
8461 (Fspecial_variable_p): New function.
8462 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8463 but without exporting it to Lisp.
23aba0ea 8464
23aba0ea 8465 * doc.c (Fdocumentation, store_function_docstring):
03408648 8466 * data.c (Finteractive_form): Handle closures.
23aba0ea 8467
03408648
SM
8468 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8469 interactive spec.
ba83908c 8470
04f2d78b
CB
8471 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8472 New byte-codes.
03408648
SM
8473 (exec_byte_code): New function extracted from Fbyte_code to handle new
8474 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8475
03408648 8476 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8477
03408648 8478 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8479
e2abce01
JB
84802011-03-31 Juanma Barranquero <lekktu@gmail.com>
8481
8482 * xdisp.c (redisplay_internal): Fix prototype.
8483
63696a73 84842011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8485
63696a73 8486 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8487 (try_scrolling): Use it when setting scroll_limit.
8488 Limit scrolling to 100 screen lines.
63696a73
EZ
8489 (redisplay_window): Even when falling back on "recentering",
8490 position point in the window according to scroll-conservatively,
8491 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8492
8493 (try_scrolling): When point is above the window, allow searching
8494 as far as scroll_max, or one screenful, to compute vertical
8495 distance from PT to the scroll margin position. This prevents
8496 try_scrolling from unnecessarily failing when
8497 scroll-conservatively is set to a value slightly larger than the
8498 window height. Clean up the case of PT below the margin at bottom
8499 of window: scroll_max can no longer be INT_MAX. When aggressive
8500 scrolling is in use, don't let point enter the opposite scroll
8501 margin as result of the scroll.
8502 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8503 threshold of 100 lines for never-recentering scrolling.
8504
e4cc2dfc
JB
85052011-03-31 Juanma Barranquero <lekktu@gmail.com>
8506
8507 * dispextern.h (move_it_by_lines):
8508 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8509 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8510 (message_log_check_duplicate): Remove parameters `prev_bol' and
8511 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8512 (redisplay_internal): Remove parameter `preserve_echo_area',
8513 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8514
8515 * indent.c (Fvertical_motion):
8516 * window.c (window_scroll_pixel_based, Frecenter):
8517 Don't pass `need_y_p' to `move_it_by_lines'.
8518
1c470562
SM
85192011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8520
44f230aa
SM
8521 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8522 steal a few bits to be more compact.
8523 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8524 Remove unneeded casts.
8525
1c470562
SM
8526 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8527
888adce9
ZK
85282011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8529
8530 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8531 binding" message (bug#7967).
8532
f838ed7b
PE
85332011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8534
77861b95
PE
8535 Fix more problems found by GCC 4.6.0's static checks.
8536
de6dbc14
PE
8537 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8538 Remove unused local var.
8539
f838ed7b
PE
8540 * editfns.c (Fmessage_box): Remove unused local var.
8541
792c7b2b
PE
8542 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8543 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8544 Omit unused local vars.
c499e557 8545 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8546 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8547 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8548 Omit unused local var.
8549
ba0165e1
PE
8550 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8551 Don't assume string length fits in int.
32ad8845 8552 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8553 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8554
3c59b4c9
PE
8555 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8556 instead of alloca (Bug#8344).
8557
a3eed478 8558 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8559 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8560
eb4d412d
PE
8561 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8562
1658b401
PE
8563 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8564 concerns.
8565
8566 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8567
8568 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8569
9a2c6e05
PE
8570 * keyboard.c (syms_of_keyboard): Use the same style as later
8571 in this function when indexing through an array. This also
8572 works around GCC bug 48267.
8573
03d0a109
PE
8574 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8575
44f730c8
PE
8576 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8577
fe75f926
PE
8578 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8579 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8580
ffa8c828
PE
8581 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8582 This avoids undefined behavior on integer overflow, and is a bit
8583 more convenient anyway since it is compared to a size_t variable.
8584
c5101a77
PE
8585 Variadic C functions now count arguments with size_t, not int.
8586 This avoids an unnecessary limitation on 64-bit machines, which
8587 caused (substring ...) to crash on large vectors (Bug#8344).
8588 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8589 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8590 All variadic functions and their callers changed accordingly.
c5101a77
PE
8591 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8592 * data.c (arith_driver, float_arith_driver): Likewise.
8593 * editfns.c (general_insert_function): Likewise.
8594 * eval.c (struct backtrace.nargs, interactive_p)
8595 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8596 (funcall_lambda, mark_backtrace): Likewise.
8597 * fns.c (concat): Likewise.
8598 * frame.c (x_set_frame_parameters): Likewise.
8599 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8600 0 if not found, not -1. All callers changed.
8601
dd3f25f7
PE
8602 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8603 (stack_copy_size): Now size_t, not int.
8604 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8605
461c2ab9
JB
86062011-03-28 Juanma Barranquero <lekktu@gmail.com>
8607
8608 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8609 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8610 All callers changed.
8611
8612 * lisp.h (multibyte_char_to_unibyte):
8613 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8614 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8615 * character.h (CHAR_TO_BYTE8):
8616 * cmds.c (internal_self_insert):
8617 * editfns.c (general_insert_function):
8618 * keymap.c (push_key_description):
8619 * search.c (Freplace_match):
8620 * xdisp.c (message_dolog, set_message_1): All callers changed.
8621
f6d62986
SM
86222011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8623
8624 * keyboard.c (safe_run_hook_funcall): New function.
8625 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8626 don't set the hook to nil, but remove the offending function instead.
8627 (Qcommand_hook_internal): Remove, unused.
8628 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8629 Vcommand_hook_internal.
8630
8631 * eval.c (enum run_hooks_condition): Remove.
8632 (funcall_nil, funcall_not): New functions.
8633 (run_hook_with_args): Call each function through a `funcall' argument.
8634 Remove `cond' argument, now redundant.
8635 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8636 (Frun_hook_with_args_until_failure): Adjust accordingly.
8637 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8638
1db5b1ad
JB
86392011-03-28 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * dispextern.h (string_buffer_position): Remove declaration.
8642
8643 * print.c (strout): Remove parameter `multibyte', unused since
8644 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8645
8646 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8647 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8648 All callers changed.
8649
8650 * w32.c (_wsa_errlist): Use braces for struct initializers.
8651
8652 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8653 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8654 All callers changed.
8655 (string_buffer_position): Likewise. Also, make static (it's never
8656 used outside xdisp.c).
8657 (cursor_row_p): Remove parameter `w', unused since
8658 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8659 (decode_mode_spec): Remove parameter `precision', introduced during
8660 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8661 All callers changed.
8662
5ffb62aa
JD
86632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8664
8665 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8666
461c2ab9 86672011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8668
8669 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8670 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8671 (ns_update_auto_hide_menu_bar): New functions.
8672 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8673 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8674 ns_constrain_all_frames.
8675 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8676 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8677
5c380ffb
JD
86782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8679
8680 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8681
9af30bdf
GM
86822011-03-27 Glenn Morris <rgm@gnu.org>
8683
8684 * syssignal.h: Replace RETSIGTYPE with void.
8685 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8686 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8687 Replace SIGTYPE with void everywhere.
8688 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8689 * s/template.h (SIGTYPE): Remove commented out definition.
8690
e2abce01
JB
86912011-03-26 Eli Zaretskii <eliz@gnu.org>
8692
8693 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8694 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8695
f868cd8a
JB
86962011-03-26 Juanma Barranquero <lekktu@gmail.com>
8697
59eb0929
JB
8698 * w32.c (read_unc_volume): Use parameter `henum', instead of
8699 global variable `wget_enum_handle'.
8700
8701 * keymap.c (describe_vector): Remove parameters `indices' and
8702 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8703 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8704
f868cd8a
JB
8705 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8706
8707 * keyboard.c (timer_check): Remove parameter `do_it_now',
8708 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8709 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8710 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8711
8712 * keyboard.c (read_char):
8713 * w32menu.c (w32_menu_display_help):
8714 * xmenu.c (show_help_event, menu_help_callback):
8715 Adjust calls to `show_help_echo'.
8716
8717 * gtkutil.c (xg_maybe_add_timer):
8718 * keyboard.c (readable_events):
8719 * process.c (wait_reading_process_output):
8720 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8721
8722 * insdel.c (adjust_markers_gap_motion):
8723 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8724 (gap_left, gap_right): Don't call it.
8725
2ecf6fdb
CY
87262011-03-25 Chong Yidong <cyd@stupidchicken.com>
8727
8728 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8729 incurred during fontification.
8730
6b1f9ba4
JB
87312011-03-25 Juanma Barranquero <lekktu@gmail.com>
8732
8733 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8734 (DEFVAR_PER_BUFFER): Don't pass it.
8735
8736 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8737 (scrolling_window): Don't pass it.
8738
0f4a96b5
JB
87392011-03-25 Juanma Barranquero <lekktu@gmail.com>
8740
8741 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8742
8743 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8744 and `suffix'.
8745 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8746 of variables specific to SELinux and computation of `encoded_absname'.
8747
8748 * image.c (XPutPixel): Remove unused variable `height'.
8749
8750 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8751
8752 * unexw32.c (get_section_info): Remove unused variable `section'.
8753
8754 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8755 (system_process_attributes): Remove unused variable `sess'.
8756 (sys_read): Remove unused variable `err'.
8757
8758 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8759 (w32_wnd_proc): Remove unused variable `isdead'.
8760 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8761 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8762 (x_create_tip_frame): Remove unused variable `tem'.
8763
8764 * w32inevt.c (w32_console_read_socket):
8765 Remove unused variable `no_events'.
8766
8767 * w32term.c (x_draw_composite_glyph_string_foreground):
8768 Remove unused variable `width'.
8769
1149507c
JB
87702011-03-24 Juanma Barranquero <lekktu@gmail.com>
8771
8772 * w32term.c (x_set_glyph_string_clipping):
8773 Don't pass uninitialized region to CombineRgn.
8774
9c88f339
JB
87752011-03-23 Juanma Barranquero <lekktu@gmail.com>
8776
8777 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8778 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8779 (Fx_close_connection): Remove unused variable `i'.
8780
8781 * w32font.c (w32font_draw): Return number of glyphs.
8782 (w32font_open_internal): Remove unused variable `i'.
8783 (w32font_driver): Add missing initializer.
8784
8785 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8786 (fill_in_menu): Remove unused variable `items_added'.
8787
8788 * w32term.c (last_mouse_press_frame): Remove static global variable.
8789 (w32_clip_to_row): Remove unused variable `f'.
8790 (x_delete_terminal): Remove unused variable `i'.
8791
8792 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8793 (NOTHING): Remove unused static global variable.
8794 (uniscribe_check_otf): Remove unused variable `table'.
8795 (uniscribe_font_driver): Add missing initializers.
8796
dee091a3
JD
87972011-03-23 Julien Danjou <julien@danjou.info>
8798
8799 * term.c (Fsuspend_tty, Fresume_tty):
8800 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8801 * window.c (temp_output_buffer_show):
8802 * insdel.c (signal_before_change):
8803 * frame.c (Fhandle_switch_frame):
8804 * fileio.c (Fdo_auto_save):
8805 * emacs.c (Fkill_emacs):
8806 * editfns.c (save_excursion_restore):
8807 * cmds.c (internal_self_insert):
8808 * callint.c (Fcall_interactively):
8809 * buffer.c (Fkill_all_local_variables):
8810 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8811 Use Frun_hooks.
0f4a96b5 8812 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8813 unconditionally since it does the check itself.
dee091a3 8814
2c520ab5 88152011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8816
c9c49752
PE
8817 Fix more problems found by GCC 4.5.2's static checks.
8818
8abc3f12
PE
8819 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8820 the first time through the loop, since we know p0 < p1 then.
8821 This also avoids a gcc -Wstrict-overflow warning.
8822
a2d26660
PE
8823 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8824 leading to a memory leak, possible in functions like
8825 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8826 of objects (Bug#8318).
a2d26660 8827
916c72e9
PE
8828 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8829 that could (at least in theory) be that large.
8830
19ab8a18
PE
8831 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8832 This is less likely to overflow, and avoids undefined behavior if
8833 overflow does occur. All callers changed. Use strtoul to scan
8834 for the unsigned long integer.
b7cbbd6f
PE
8835 (pint2hrstr): Simplify and tune code slightly.
8836 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8837
f0641eff
PE
8838 * scroll.c (do_scrolling): Work around GCC bug 48228.
8839 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8840
7f650bb9
PE
8841 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8842 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8843 (validate_x_resource_name): Simplify count usage.
8844 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8845
37dd57d1
PE
8846 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8847 fail (Bug#8306).
81e56e61 8848
699979fc 8849 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8850
401bf9b4
PE
8851 * process.c (Fmake_network_process): Use socklen_t, not int,
8852 where POSIX says socklen_t is required in portable programs.
8853 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8854 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8855 (Fmake_network_process, server_accept_connection):
8856 (wait_reading_process_output, read_process_output):
8857 Likewise.
8858
b93aacde
PE
8859 * process.c: Rename or move locals to avoid shadowing.
8860 (list_processes_1, Fmake_network_process):
8861 (read_process_output_error_handler, exec_sentinel_error_handler):
8862 Rename or move locals.
4dc343ee 8863 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8864 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8865 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8866 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8867 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8868
af8a867c 8869 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8870 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8871 Include tparam.h instead, since it declares them.
af8a867c
PE
8872 * cm.h (PC): Remove extern decl; tparam.h now does this.
8873 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8874 * terminfo.c: Include tparam.h, to check interfaces.
8875 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8876 (tparam): Adjust signature to match interface in tparam.h;
8877 this removes some undefined behavior. Check that outstring and len
8878 are zero, which they always are with Emacs.
8879 * tparam.h (PC, BC, UP): New extern decls.
8880
0248044d 8881 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8882 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8883
8ff096c1 8884 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8885 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8886 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8887 (ftfont_list): Remove unused local.
49eaafba
PE
8888 (get_adstyle_property, ftfont_pattern_entity):
8889 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8890 Rename locals to avoid shadowing.
8ff096c1 8891
e2be39f6
PE
8892 * xfont.c (xfont_list_family): Mark var as initialized.
8893
c9735e30
PE
8894 * xml.c (make_dom): Now static.
8895
8f5201ae
PE
8896 * composite.c (composition_compute_stop_pos): Rename local to
8897 avoid shadowing.
b246f932
PE
8898 (composition_reseat_it): Remove unused locals.
8899 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8900 (composition_update_it): Mark var as initialized.
11b61122
PE
8901 (find_automatic_composition): Mark vars as initialized,
8902 with a FIXME (Bug#8290).
8f5201ae 8903
760fbc2c
PE
8904 character.h: Rename locals to avoid shadowing.
8905 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8906 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8907 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8908 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8909 to avoid shadowing.
8910
ff08eb85
PE
8911 * textprop.c (property_change_between_p): Remove; unused.
8912
fc7bf025
PE
8913 * intervals.c (interval_start_pos): Now static.
8914
235d7abc
PE
8915 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8916
44f230aa
SM
8917 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8918 Rename locals to avoid shadowing.
3e7d6594 8919
50060332
PE
8920 * sound.c (wav_play, au_play, Fplay_sound_internal):
8921 Fix pointer signedness.
d01f234b 8922 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8923 (wav_play): Initialize a variable to 0, to prevent undefined
8924 behavior (Bug#8278).
50060332 8925
c4fc4e30
PE
8926 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8927
918436ed
PE
8928 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8929
c939f91b
PE
8930 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8931 clobbering (Bug#8298).
b9c7f648
PE
8932 * sysdep.c (sys_subshell): Likewise.
8933 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8934
6bd8c144
PE
8935 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8936 This should get cleaned up, so that child_setup has the
8937 same signature on all platforms.
8938
7710357c 8939 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8940 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8941
c59da222
CY
89422011-03-22 Chong Yidong <cyd@stupidchicken.com>
8943
8944 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8945 not to be necessary, and produces flickering.
8946
66b87493
GM
89472011-03-20 Glenn Morris <rgm@gnu.org>
8948
8949 * config.in: Remove file.
8950
45b6f6d5
JB
89512011-03-20 Juanma Barranquero <lekktu@gmail.com>
8952
8953 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8954 are now in src/globals.h.
8955 (syms_of_minibuf): Remove spurious & from previous change.
8956
cd394be1 89572011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8958
8959 * minibuf.c (completing-read-function): New variable.
8960 (completing-read-default): Rename from completing-read.
8961 (completing-read): Call completing-read-function.
8962
b14e3e21
CY
89632011-03-19 Juanma Barranquero <lekktu@gmail.com>
8964
8965 * xfaces.c (Fx_load_color_file):
8966 Read color file from absolute filename (bug#8250).
8967
f2b726e6
JB
89682011-03-19 Juanma Barranquero <lekktu@gmail.com>
8969
8970 * makefile.w32-in: Update dependencies.
8971
09f6ff02
EZ
89722011-03-17 Eli Zaretskii <eliz@gnu.org>
8973
8974 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8975
29a6015a
PE
89762011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8977
a3a6c54e
PE
8978 Fix more problems found by GCC 4.5.2's static checks.
8979
b766f867
PE
8980 * process.c (make_serial_process_unwind, send_process_trap):
8981 (sigchld_handler): Now static.
8982
be02381c
PE
8983 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8984 That way, the code declares only the vars that it needs.
8985 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8986 * s/cygwin.h (PTY_ITERATION): Likewise.
8987 * s/darwin.h (PTY_ITERATION): Likewise.
8988 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8989
57048744
PE
8990 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8991 * process.c (allocate_pty): Don't declare stb unless it's needed.
8992
7914961c 8993 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8994 (CONSTANTLIM): Remove; unused.
8995 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8996 Define only if needed.
7914961c 8997
b3967b18
PE
8998 * unexelf.c (unexec): Name an expression,
8999 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9000 Use a different way to cause a compilation error if anyone uses
9001 n rather than nn, a way that does not involve shadowing.
73366a00 9002 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9003
29a6015a
PE
9004 * deps.mk (unexalpha.o): Remove; unused.
9005
43cfc33e 9006 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9007 * unexec.h: New file.
ce701a33
PE
9008 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9009 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9010 Depend on unexec.h.
9011 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9012 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9013 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9014 Change as necessary to match prototype in unexec.h.
ce701a33 9015
01f44d5a
PE
9016 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9017 shadowing.
4f63c6bb 9018 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9019
a6670b0b
PE
9020 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9021 Rename locals to avoid shadowing.
9022
cef2010d 9023 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9024 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9025
d4d7173a
PE
9026 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9027
f08b802a
PE
9028 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9029 warning when compiling print.c.
9030
3ddb0639
PE
9031 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9032 instead of using an uninitialized var.
5ad03b97 9033 (font_sort_entities): Mark var as initialized.
3ddb0639 9034
170a2692
PE
9035 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9036
e663c700
PE
9037 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9038 pointers to constants.
89bc529a 9039 (font_parse_fcname): Remove unused vars.
7b81e2d0 9040 (font_delete_unmatched): Now static.
ea838e10 9041 (font_get_spec): Remove; unused.
13a547c6
PE
9042 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9043 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9044 Rename or move locals to avoid shadowing.
e663c700 9045
2a80c887 9046 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9047 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9048
1384fa33 9049 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9050 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9051
8b2c52e9
PE
9052 * alloc.c (mark_backtrace): Move decl from here ...
9053 * lisp.h: ... to here, so that it can be checked.
9054
475545b5 9055 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9056 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9057 (lisp_indirect_variable): Name an expression,
9058 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9059 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9060
b1349114 9061 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9062 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9063 Use const pointer when appropriate.
b1349114 9064
a2928364
PE
9065 * lisp.h (get_system_name, get_operating_system_release):
9066 Move decls here, to check interfaces.
9067 * process.c (get_operating_system_release): Move decl to lisp.h.
9068 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9069 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9070 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9071 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9072 (Fformat_time_string, Fencode_time, Finsert_char):
9073 (Ftranslate_region_internal, Fformat):
9074 Rename or remove local vars to avoid shadowing.
9710023e 9075 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9076
a415e694
PE
9077 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9078 avoid shadowing.
9079
8ef4622d
PE
9080 * lisp.h (eassert): Check that the argument compiles, even if
9081 ENABLE_CHECKING is not defined.
9082
946f9a5b
PE
9083 * data.c (Findirect_variable): Name an expression, to avoid
9084 gcc -Wbad-function-cast warning.
112396d6 9085 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9086 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9087 (Fmake_variable_buffer_local, Fmake_local_variable):
9088 Mark variables as initialized.
52746918 9089 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9090
e5aab7e7 9091 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9092 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9093 Rename locals to avoid shadowing.
dff45157
PE
9094 (mark_stack): Move local variables into the #ifdef region where
9095 they're used.
7bc26fdb
PE
9096 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9097 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9098 needed otherwise.
9099 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9100 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9101 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9102
e5aab7e7
PE
9103 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9104 avoids undefined behavior in theory.
9105
4da60324
PE
9106 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9107
88043301
PE
9108 Use functions, not macros, for up- and down-casing (Bug#8254).
9109 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9110 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9111 to use the following functions instead of these macros.
9112 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9113 EMACS_INT, since callers assume the returned value fits in int.
9114 (upcase1): Likewise, for UPCASE_TABLE.
9115 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9116 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9117 the race-condition problem in the old DOWNCASE.
88043301 9118
19ed5445
PE
9119 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9120 Rename locals to avoid shadowing.
9121 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9122 (regex_compile, re_search_2, re_match_2_internal):
9123 Remove unused local vars.
952db0d7
PE
9124 (FREE_VAR): Rewrite so as not to use empty "else",
9125 which gcc can warn about.
da053e48 9126 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9127 (RETALLOC_IF): Define only if needed.
9128 (WORDCHAR_P): Likewise. This one is never needed, but is used
9129 only in a comment talking about a compiler bug, so put inside
9130 the #if 0 of that comment.
9131 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9132 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9133 Remove; unused.
19ed5445 9134
1f3561e4 9135 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9136 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9137 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9138
ded6f8f7
PE
9139 * search.c (simple_search): Remove unused var.
9140
dbd37a95
PE
9141 * dired.c (compile_pattern): Move decl from here ...
9142 * lisp.h: ... to here, so that it can be checked.
9143 (struct re_registers): New forward decl.
9144
7e47afad
PE
9145 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9146
85f24f61
PE
9147 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9148 All uses changed.
9149 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9150 Rename locals to avoid shadowing.
5671df8f 9151 (Fvertical_motion): Mark locals as initialized.
85f24f61 9152
181aa2be 9153 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9154 (casify_region): Mark local as initialized.
181aa2be 9155
930d429c
PE
9156 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9157
7082eac6
PE
9158 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9159 New macros, so that the caller can use some names other than
9160 gcpro1, gcpro2, etc.
9161 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9162 of the new macros.
9163 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9164 argument, for consistency with GCPRO2_VAR, etc: it is now the
9165 prefix of the variable, not the variable itself. All uses
9166 changed.
38b2c076
PE
9167 * dired.c (directory_files_internal, file_name_completion):
9168 Rename locals to avoid shadowing.
9169
15206ed9
PE
9170 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9171 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9172 dired.c's scmp function, had undefined behavior.
9173 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9174 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9175 * buffer.h: ... to here, because these macros use current_buffer,
9176 and the new implementation with inline functions needs to have
9177 current_buffer in scope now, rather than later when the macros
9178 are used.
9179 (downcase, upcase1): New static inline functions.
9180 (DOWNCASE, UPCASE1): Reimplement using these functions.
9181 This avoids undefined behavior in expressions like
9182 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9183 from race conditions in accessing the global variables
9184 case_temp1 and case_temp2.
9185 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9186 * lisp.h (case_temp1, case_temp2): Remove their decls.
9187 * character.h (ASCII_CHAR_P): Move from here ...
9188 * lisp.h: ... to here, so that the inline functions mentioned
9189 above can use them.
9190
4a6bea26
PE
9191 * dired.c (directory_files_internal_unwind): Now static.
9192
f14b7e14
PE
9193 * fileio.c (file_name_as_directory, directory_file_name):
9194 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9195 Now static.
2893f146
PE
9196 (file_name_as_directory): Use const pointers when appropriate.
9197 (Fexpand_file_name): Likewise. In particular, newdir might
9198 point at constant storage, so make it a const pointer.
fd4ead52 9199 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9200 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9201 signedness issues.
f839df0c
PE
9202 (Fset_file_times, Finsert_file_contents, auto_save_error):
9203 Rename locals to avoid shadowing.
f14b7e14 9204
5716756e 9205 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9206 (Ftry_completion, Fall_completions): Rename or remove locals
9207 to avoid shadowing.
5716756e 9208
b4c3046a
PE
9209 * marker.c (bytepos_to_charpos): Remove; unused.
9210
b45db522
PE
9211 * lisp.h (verify_bytepos, count_markers): New decls,
9212 so that gcc does not warn that these functions aren't declared.
9213
85876d07
PE
9214 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9215 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9216 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9217 (copy_text): Remove unused local var.
85876d07 9218
03d78a21 9219 * filelock.c (within_one_second): Now static.
b3dd38ab 9220 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9221
5df8f01b
PE
9222 * buffer.c (fix_overlays_before): Mark locals as initialized.
9223 (fix_start_end_in_overlays): Likewise. This function should be
9224 simplified by using pointers-to-pointers, but that's a different
9225 matter.
b1d876f1 9226 (switch_to_buffer_1): Now static.
8f54f30a
PE
9227 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9228 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9229
a70072c9 9230 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9231 Fix pointer signedness issue.
edced198
PE
9232 (sys_subshell): Mark local as volatile if checking for lint,
9233 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9234 (MAXPATHLEN): Define only if needed.
a70072c9 9235
a0977c44
PE
9236 * process.c (serial_open, serial_configure): Move decls from here ...
9237 * systty.h: ... to here, so that they can be checked.
9238
a884fdcc
PE
9239 * fns.c (get_random, seed_random): Move extern decls from here ...
9240 * lisp.h: ... to here, so that they can be checked.
9241
604efe86 9242 * sysdep.c (reset_io): Now static.
b8950c94 9243 (wait_for_termination_signal): Remove; unused.
604efe86 9244
38fc62d9
PE
9245 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9246 (copy_keymap_item, append_key, push_text_char_description):
9247 Now static.
1004a21a 9248 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9249 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9250 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9251 (describe_map_tree):
9252 Rename locals to avoid shadowing.
38fc62d9 9253
2f2650da
PE
9254 * keyboard.c: Declare functions static if they are not used elsewhere.
9255 (echo_char, echo_dash, cmd_error, top_level_2):
9256 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9257 (read_char, kbd_buffer_get_event, make_lispy_position):
9258 (make_lispy_event, make_lispy_movement, apply_modifiers):
9259 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9260 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9261 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9262 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9263 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9264
a053e86c 9265 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9266 (mark_kboards): Move decl here ...
9267 * alloc.c (mark_kboards): ... from here.
a053e86c 9268
4752793e
PE
9269 * lisp.h (force_auto_save_soon): New decl.
9270
74f10ca7 9271 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9272 (DEFINE_DUMMY_FUNCTION): New macro.
9273 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9274 Use it.
c03cd23f
PE
9275 (main): Add casts to avoid warnings
9276 if GCC considers string literals to be constants.
74f10ca7 9277
022e70d4
PE
9278 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9279
59d6fe83
PE
9280 * dbusbind.c: Pointer signedness fixes.
9281 (xd_signature, xd_append_arg, xd_initialize):
9282 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9283 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9284 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9285 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9286
78320123
PE
9287 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9288 if GCC considers string literals to be constants.
49cebcca 9289 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9290
35ac2a97
SM
92912011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9292
fb103ca9
SM
9293 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9294 (print_preprocess, print_object): New macro to fix last change.
9295
35ac2a97
SM
9296 * print.c (print_preprocess): Don't forget font objects.
9297
62973b41
JB
92982011-03-16 Juanma Barranquero <lekktu@gmail.com>
9299
9300 * emacs.c (USAGE3): Doc fixes.
9301
0e48bb22
AS
93022011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9303
9304 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9305 structure.
9306
7684e57b
JB
93072011-03-14 Juanma Barranquero <lekktu@gmail.com>
9308
9309 * lisp.h (VWindow_system, Qfile_name_history):
9310 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9311 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9312 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9313
9314 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9315 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9316
9317 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9318 * w32console.c (detect_input_pending, read_input_pending)
9319 (encode_terminal_code):
9320 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9321 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9322 (w32_system_caret_y, Qfile_name_history):
9323 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9324 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9325 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9326 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9327 * w32proc.c (Qlocal, report_file_error):
9328 * w32term.c (Vwindow_system, updating_frame):
9329 * w32uniscribe.c (initialized, uniscribe_font_driver):
9330 Remove unneeded extern declarations.
9331
2aa46d6c
CY
93322011-03-14 Chong Yidong <cyd@stupidchicken.com>
9333
c96bbc66 9334 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9335
cffc6f3b
CY
93362011-03-13 Chong Yidong <cyd@stupidchicken.com>
9337
9338 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9339 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9340 These macros can no longer be used for assignment.
9341
44f230aa
SM
9342 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9343 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9344 (record_buffer_markers, fetch_buffer_markers): New functions for
9345 recording and fetching special buffer markers.
9346 (set_buffer_internal_1, set_buffer_temp): Use them.
9347
9348 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9349
9350 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9351
9352 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9353 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9354
9355 * xdisp.c (hscroll_window_tree):
9356 (reconsider_clip_changes): Use PT instead of BUF_PT.
9357
d251f04b
EZ
93582011-03-13 Eli Zaretskii <eliz@gnu.org>
9359
9360 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9361 $(EMACS_ROOT)/lib/intprops.h.
9362
f0c77cd1
PE
93632011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9364
3eca4629
PE
9365 Fix more problems found by GCC 4.5.2's static checks.
9366
7c86ee98
PE
9367 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9368 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9369 (xg_free_frame_widgets): Make it clear that a local variable is
9370 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9371 (gdk_window_get_screen): Make it clear that this macro is needed
9372 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9373 (int_gtk_range_get_value): New function, which avoids a diagnostic
9374 from gcc -Wbad-function-cast.
9375 (xg_set_toolkit_scroll_bar_thumb): Use it.
9376 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9377 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9378 (get_utf8_string, xg_get_file_with_chooser):
9379 Rename locals to avoid shadowing.
9380 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9381
41729b81
PE
9382 * xgselect.c (xg_select): Remove unused var.
9383
f0c77cd1
PE
9384 * image.c (four_corners_best): Mark locals as initialized.
9385 (gif_load): Initialize transparent_p to zero (Bug#8238).
9386 Mark another local as initialized.
ec6cf4c6 9387 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9388
ce0ad53d 9389 * image.c (clear_image_cache): Now static.
d5d5a617 9390 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9391 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9392 (x_edge_detection): Remove unnecessary cast that
9393 gcc -Wbad-function-cast diagnoses.
2037898d 9394 (gif_load): Fix pointer signedness.
6ae141d6
PE
9395 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9396 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9397
33383987 93982011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9399
d32df629
PE
9400 Improve quality of tests for time stamp overflow.
9401 For example, without this patch (encode-time 0 0 0 1 1
9402 1152921504606846976) returns the obviously-bogus value (-948597
9403 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9404 reports time overflow. See
9405 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9406 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9407 * editfns.c: Include limits.h and intprops.h.
9408 (TIME_T_MIN, TIME_T_MAX): New macros.
9409 (time_overflow): Move earlier, to before first use.
9410 (hi_time, lo_time): New functions, for an accurate test for
9411 out-of-range times.
9412 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9413 (Fget_internal_run_time): Don't assume time_t fits in int.
9414 (make_time): Use list2 instead of Fcons twice.
9415 (Fdecode_time): More accurate test for out-of-range times.
9416 (check_tm_member): New function.
9417 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9418 (lisp_time_argument): Don't rely on undefined left-shift and
9419 right-shift behavior when checking for time stamp overflow.
8be6f318 9420
fe31d94c
PE
9421 * editfns.c (time_overflow): New function, refactoring common code.
9422 (Fformat_time_string, Fdecode_time, Fencode_time):
9423 (Fcurrent_time_string): Use it.
9424
8be6f318
PE
9425 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9426 * dired.c (make_time): Move to ...
9427 * editfns.c (make_time): ... here.
9428 * systime.h: Note the move.
9429
09d9db2c 94302011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9431
126bc0dc
YM
9432 * fringe.c (update_window_fringes): Remove unused variables.
9433
c47cbdfd
YM
9434 * unexmacosx.c (copy_data_segment): Also copy __got section.
9435 (Bug#8223)
9436
7ac80be9
EZ
94372011-03-12 Eli Zaretskii <eliz@gnu.org>
9438
c96bbc66 9439 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9440 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9441 Constify `char *' arguments and their references according to
9442 prototypes in tparam.h.
9443
ecb0f94d 9444 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9445
7ac80be9
EZ
9446 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9447 Adapt all references accordingly.
9448
9449 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9450
ef1fd07e
TT
94512011-03-11 Tom Tromey <tromey@redhat.com>
9452
9453 * buffer.c (syms_of_buffer): Remove obsolete comment.
9454
7ef4b50c
EZ
94552011-03-11 Eli Zaretskii <eliz@gnu.org>
9456
9457 * termhooks.h (encode_terminal_code): Declare prototype.
9458
9459 * msdos.c (encode_terminal_code): Don't declare prototype.
9460
9461 * term.c (encode_terminal_code): Now external again, used by
9462 w32console.c and msdos.c.
9463
44f230aa
SM
9464 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9465 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9466
4b1ec863 94672011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9468
1714f52b 9469 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9470
4b1ec863
PE
9471 * fringe.c (update_window_fringes): Mark locals as initialized
9472 (Bug#8227).
9473 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9474
524c7aa6
PE
9475 * alloc.c (mark_fringe_data): Move decl from here ...
9476 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9477 to check its interface.
9478 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9479
a5c0af81 9480 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9481 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9482 (fontset_font): Mark local as initialized.
a9a06e0b 9483 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9484
b4716021
PE
9485 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9486
811e9bac 9487 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9488 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9489 (x_own_selection, Fx_disown_selection_internal): Rename locals
9490 to avoid shadowing.
9491 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9492
7e3ab302
PE
9493 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9494 so that the caller can use some name other than gcpro1.
9495 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9496 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9497 (Fx_backspace_delete_keys_p):
9498 Use them to avoid shadowing, and rename vars to avoid shadowing.
9499 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9500 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9501 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9502 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9503 Remove unused locals.
7e3ab302
PE
9504 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9505 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9506 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9507 macros.
f78faa98 9508
e2b13473
PE
9509 * xterm.h (x_mouse_leave): New decl.
9510
77f23912
PE
9511 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9512 Remove unused functions.
cdf4ba58
PE
9513 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9514 (x_calc_absolute_position): Now static.
7411c686 9515 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9516 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9517 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9518 unless they are used.
38d0b34a
PE
9519 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9520 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9521 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9522 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9523 (x_error_catcher, x_connection_closed, x_error_handler):
9524 (x_error_quitter, xembed_send_message, x_iconify_frame):
9525 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9526 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9527 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9528
44f230aa
SM
9529 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9530 Rename or move locals to avoid shadowing.
6b463e58 9531 (tty_defined_color, merge_face_heights): Now static.
5967d051 9532 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9533 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9534 does not deduce is never used uninitialized.
73719eba
PE
9535 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9536 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9537
426994c3 9538 * terminal.c (store_terminal_param): Now static.
5489860b 9539
032f1620 9540 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9541 (set_frame_menubar): Remove unused local.
d4323972 9542 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9543 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9544 since they might point to immutable storage.
281585b0
PE
9545 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9546 since it's unused otherwise.
032f1620 9547
367c19e5 9548 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9549 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9550 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9551 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9552 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9553 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9554 does not deduce are never used uninitialized.
70739cbe 9555
07b48fa9
PE
9556 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9557
8868a238 9558 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9559 * window.c (window_loop, size_window):
9560 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9561
7e5cf297 9562 * window.c (display_buffer): Now static.
d6550a9f
PE
9563 (size_window): Mark variables that gcc -Wuninitialized
9564 does not deduce are never used uninitialized.
a586633d
PE
9565 * window.h (check_all_windows): New decl, to forestall
9566 gcc -Wmissing-prototypes diagnostic.
5b555da1 9567 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9568
f6095868
PE
9569 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9570 shadowing.
9571 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9572 Include <limits.h>.
9573 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9574 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9575 (load_charset_map): Mark variables that gcc -Wuninitialized
9576 does not deduce are never used uninitialized.
53df7c11 9577 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9578
f38b440c
PE
9579 * coding.c (coding_set_source, coding_set_destination):
9580 Use "else { /* comment */ }" rather than "else /* comment */;"
9581 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9582 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9583 a block, when the outer 'i' will do.
9584 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9585 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9586 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9587 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9588 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9589 Rename locals to avoid shadowing.
9590 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9591 * coding.c (emacs_mule_char, encode_invocation_designation):
9592 Now static, since they're not used elsewhere.
413bb2db 9593 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9594 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9595 (decode_coding_emacs_mule): Mark variables that gcc
9596 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9597 (detect_coding_iso_2022): Initialize a local variable that might
9598 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9599 this initialization is needed. (Bug#8211)
5f58e762
PE
9600 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9601 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9602 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9603 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9604 Remove unused macros.
f38b440c 9605
232b38b9 9606 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9607 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9608 * character.c (string_count_byte8): Likewise.
232b38b9 9609
fb90da1b
PE
9610 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9611 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9612
fb93dbc2
PE
9613 * chartab.c (copy_sub_char_table): Now static, since it's not used
9614 elsewhere.
5c156ace
PE
9615 (sub_char_table_ref_and_range, char_table_ref_and_range):
9616 Rename locals to avoid shadowing.
bbcd0949 9617 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9618
7d3b3862 9619 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9620 (BIDI_BOB): Remove unused macro.
7d3b3862 9621
6be7d3da
PE
9622 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9623 deduce are never used uninitialized.
c2ed9c8b 9624 * term.c (encode_terminal_code): Likewise.
6be7d3da 9625
75f8807f 9626 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9627
50938595
PE
9628 * tparam.h: New file.
9629 * term.c, tparam.h: Include it.
9630 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9631 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9632 Move these decls to tparam.h, and make them agree with what
9633 is actually in tparam.c. The previous trick of using incompatible
9634 decls in different modules does not conform to the C standard.
9635 All callers of tparam changed to use tparam's actual API.
9636 * tparam.c (tparam1, tparam, tgoto):
9637 Use const pointers where appropriate.
9638
fbceeba2
PE
9639 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9640 * cm.h (struct cm): Likewise.
9641 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9642 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9643 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9644 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9645 (turn_on_face, init_tty): Likewise.
9646 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9647
7f3f1250
PE
9648 * term.c (term_mouse_position): Rename local to avoid shadowing.
9649
e6ca6543
PE
9650 * alloc.c (mark_ttys): Move decl from here ...
9651 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9652
c40f8d15
AS
96532011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9654
9655 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9656
cfe0661d
JB
96572011-03-09 Juanma Barranquero <lekktu@gmail.com>
9658
9659 * search.c (compile_pattern_1): Remove argument regp, unused since
9660 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9661 (compile_pattern): Don't pass it.
9662
0afb4571
J
96632011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9664
9665 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9666 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9667 for ! HAVE_GTK3.
9668 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9669
9670 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9671
9672 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9673 gdk_window_get_screen, gdk_window_get_geometry,
9674 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9675 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9676 (xg_get_pixbuf_from_pixmap): New function.
9677 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9678 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9679 Call xg_get_pixbuf_from_pixmap instead of
9680 gdk_pixbuf_get_from_drawable.
9681 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9682 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9683 (xg_check_special_colors): Use GtkStyleContext and its functions
9684 for HAVE_GTK3.
9685 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9686 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9687 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9688 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9689 Call gtk_widget_get_preferred_size.
0afb4571
J
9690 (xg_frame_resized): gdk_window_get_geometry only takes 5
9691 parameters.
44f230aa
SM
9692 (xg_win_to_widget, xg_event_is_for_menubar):
9693 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9694 (xg_set_widget_bg): New function.
9695 (delete_cb): New function.
895009e1 9696 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9697 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9698 (xg_set_background_color): Call xg_set_widget_bg.
9699 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9700 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9701 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9702 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9703 if ! HAVE_GTK3.
9704 (update_frame_tool_bar): Call gtk_widget_hide.
9705 (xg_initialize): Use GDK_KEY_g.
9706
9707 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9708 if ! HAVE_GTK3
9709 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9710
9711 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9712 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9713 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9714
1c2cc4ef
JB
97152011-03-08 Juanma Barranquero <lekktu@gmail.com>
9716
9717 * w32xfns.c (select_palette): Check success of RealizePalette against
9718 GDI_ERROR, not zero.
9719
33383987 9720See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9721
9722;; Local Variables:
9723;; coding: utf-8
aac0c6e3
MR
9724;; End:
9725
acaf905b 9726 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9727
9728 This file is part of GNU Emacs.
9729
9730 GNU Emacs is free software: you can redistribute it and/or modify
9731 it under the terms of the GNU General Public License as published by
9732 the Free Software Foundation, either version 3 of the License, or
9733 (at your option) any later version.
9734
9735 GNU Emacs is distributed in the hope that it will be useful,
9736 but WITHOUT ANY WARRANTY; without even the implied warranty of
9737 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9738 GNU General Public License for more details.
9739
9740 You should have received a copy of the GNU General Public License
9741 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.