More process-related doc and manual small edits
[bpt/emacs.git] / src / ChangeLog
CommitLineData
016a35df
GM
12012-04-18 Glenn Morris <rgm@gnu.org>
2
3 * process.c (Fset_process_inherit_coding_system_flag)
4 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
5 (Fmake_network_process): Doc fix.
6
20a68157
EZ
72012-04-17 Eli Zaretskii <eliz@gnu.org>
8
9 * xdisp.c (string_buffer_position_lim): Limit starting position to
10 BEGV.
11 (set_cursor_from_row): If called for a mode-line or header-line
12 row, return zero immediately.
13 (try_cursor_movement): If inside continuation line, don't back up
14 farther than the first row after the header line, if any. Don't
15 consider the header-line row as "partially visible", even if
16 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
17
ad3a2b41
AO
182012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
19
20 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
21
e63c261b
CY
222012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
23
24 * process.c (make_process):
25 * process.h: Add integer `gnutls_handshakes_tried' member to
26 process struct.
27
ad3a2b41
AO
28 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
29 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
30
31 * gnutls.c (gnutls_log_function2i): Convenience log function.
32 (emacs_gnutls_read): Use new log functions,
33 `gnutls_handshakes_tried' process member, and
34 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
35 attempts per process (connection).
36
e53357c4
EZ
372012-04-09 Eli Zaretskii <eliz@gnu.org>
38
39 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
40 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
41
aff67c82
JD
422012-04-09 Jan Djärv <jan.h.d@swipnet.se>
43
44 * nsterm.m (constrainFrameRect): Always constrain when there is only
45 one screen (Bug#10962).
46
2f8e16b2
EZ
472012-04-06 Eli Zaretskii <eliz@gnu.org>
48
49 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
50 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
51 about subtle differences between FETCH_CHAR* and STRING_CHAR*
52 macros related to unification of CJK characters. For the details,
53 see the discussion following the message here:
54 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
55
3d439cd1
CY
562012-04-04 Chong Yidong <cyd@gnu.org>
57
58 * keyboard.c (Vdelayed_warnings_list): Doc fix.
59
8bc53d00
EZ
602012-04-01 Eli Zaretskii <eliz@gnu.org>
61
62 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
63 instead of alloca. (Bug#11138)
64
3b0512a3
AS
652012-04-01 Andreas Schwab <schwab@linux-m68k.org>
66
67 * w32menu.c (is_simple_dialog): Properly check lisp types.
68 (Bug#11141)
69
8427ddd2
EZ
702012-03-31 Eli Zaretskii <eliz@gnu.org>
71
979022ef
EZ
72 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
73 position we get to after a call to move_it_to fails the
74 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
75 only if we wind up in a string from display property. (Bug#11063)
76
a6b1c7cc
EZ
77 * window.c (Fdelete_other_windows_internal): Invalidate the row
78 and column information about mouse highlight, so that redisplay
79 restores it after reallocating the glyph matrices. (Bug#7464)
80
8427ddd2
EZ
81 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
82 string comes from a `display' text property, use the buffer
83 position of that property as if we actually saw that position in
84 the row's glyphs.
697ba24b
EZ
85 (move_it_by_lines): Remove the assertion that
86 "it->current_x == 0 && it->hpos == 0" which can be legitimately
87 violated when there's a before-string at the beginning of a line.
88 (Bug#11063)
8427ddd2 89
65a0a738
EZ
902012-03-30 Eli Zaretskii <eliz@gnu.org>
91
92 * xdisp.c (append_space_for_newline): If the default face was
93 remapped, use the remapped face for the appended newline.
94 (extend_face_to_end_of_line): Use the remapped default face for
95 extending the face to the end of the line.
96 (display_line): Call extend_face_to_end_of_line when the default
97 face was remapped. (Bug#11068)
98
581355cc
EZ
992012-03-29 Eli Zaretskii <eliz@gnu.org>
100
101 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
102
e8fc049f
SM
1032012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
104
105 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
106
4fb9a543
GM
1072012-03-27 Glenn Morris <rgm@gnu.org>
108
109 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
110 Doc fixes.
111
679910f1
KH
1122012-03-26 Kenichi Handa <handa@m17n.org>
113
114 * dispextern.h (struct glyph): Fix previous change. Change the
115 bit length of glyphless.ch to 25 (Bug#11082).
116
90d49b7f
CY
1172012-03-26 Chong Yidong <cyd@gnu.org>
118
119 * keyboard.c (Vselection_inhibit_update_commands): New variable.
120 (command_loop_1): Use it; inhibit selection update for
121 handle-select-window too (Bug#8996).
122
f514f6f0
FP
1232012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
124
e8fc049f 125 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 126
bf43fa51
KH
1272012-03-25 Kenichi Handa <handa@m17n.org>
128
129 * dispextern.h (struct glyph): Change the bit length of
130 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
131
8a0c01dd
EZ
1322012-03-24 Eli Zaretskii <eliz@gnu.org>
133
134 * s/ms-w32.h (tzname): Include time.h before redirecting to
135 _tzname. Fixes the MSVC build. (Bug#9960)
136
7d1c3a76
AS
1372012-03-24 Andreas Schwab <schwab@linux-m68k.org>
138
8ed79523
AS
139 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
140 characters.
141
7d1c3a76
AS
142 * xterm.c (XTread_socket): Only modify handling_signal if
143 !SYNC_INPUT. (Bug#11080)
144
e99a9b8b
EZ
1452012-03-23 Eli Zaretskii <eliz@gnu.org>
146
147 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
148 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
149 when fetching a multibyte character consumes more bytes than
150 CHAR_BYTES returns, due to unification of CJK characters in
151 string_char. (Bug#11073)
152
5063c0e1
TN
1532012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
154
155 * process.c (wait_reading_process_output): Handle pty disconnect
156 by refraining from sending oneself a SIGCHLD (bug#10933).
157
9f851fbd
CY
1582012-03-22 Chong Yidong <cyd@gnu.org>
159
160 * dispextern.h (struct it): New member string_from_prefix_prop_p.
161
5063c0e1 162 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
163 Mark string as coming from a prefix property.
164 (handle_face_prop): Use default face for prefix strings (Bug#4281).
165 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
166
fb5b8aca
CY
1672012-03-21 Chong Yidong <cyd@gnu.org>
168
169 * xfaces.c (Vface_remapping_alist): Doc fix.
170
62356a1b
EZ
1712012-03-20 Eli Zaretskii <eliz@gnu.org>
172
173 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
174 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
175 Doc fixes.
62356a1b 176
025de85b
CY
1772012-03-20 Chong Yidong <cyd@gnu.org>
178
179 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
180 to reflect default non-nil value of redisplay-dont-pause.
181
4827f94e
KH
1822012-03-19 Kenichi Handa <handa@m17n.org>
183
184 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
185 it fit in a valid range (Bug#11003).
186
e50a24a2
EZ
1872012-03-18 Eli Zaretskii <eliz@gnu.org>
188
189 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
190 that is not from display property, accept the row as a "cursor
191 row" if one of the string's character has a non-nil `cursor'
192 property. Fixes cursor positioning when there are newlines in
193 overlay strings, e.g. in icomplete.el. (Bug#11035)
194
9af5ed87
PE
1952012-03-12 Paul Eggert <eggert@cs.ucla.edu>
196
197 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
198
d1f55f16
CY
1992012-03-12 Chong Yidong <cyd@gnu.org>
200
201 * eval.c (inhibit_lisp_code): Rename from
202 inhibit_window_configuration_change_hook; move from window.c.
203
204 * xfns.c (unwind_create_frame_1, Fx_create_frame):
205 * window.c (run_window_configuration_change_hook)
206 (syms_of_window): Callers changed.
207
66c5eebd
CY
2082012-03-11 Chong Yidong <cyd@gnu.org>
209
413df973
CY
210 * keymap.c (Fkey_description): Doc fix (Bug#9700).
211
66c5eebd
CY
212 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
213
1de11f56
CY
2142012-03-10 Chong Yidong <cyd@gnu.org>
215
216 * frame.c (other_visible_frames): Don't assume the selected frame
217 is visible (Bug#10955).
218
cae07000
SM
2192012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
220
221 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
222
89c94350
JD
2232012-03-08 Jan Djärv <jan.h.d@swipnet.se>
224
225 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
226 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
227 zero (Bug#10954).
228
999dd333
GM
2292012-03-03 Glenn Morris <rgm@gnu.org>
230
01a6dcc8 231 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 232
de0100f2
EZ
2332012-03-02 Eli Zaretskii <eliz@gnu.org>
234
235 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
236 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
237 (redisplay_window, next_element_from_string): Fix typos in
238 comments.
3e441275
EZ
239 (redisplay_window): Pass to move_it_vertically the margin in
240 pixels, not in screen lines.
de0100f2 241
96a72ee9
GM
2422012-03-02 Glenn Morris <rgm@gnu.org>
243
244 * buffer.c (buffer-list-update-hook): Doc fix.
245
312508d7
EZ
2462012-02-29 Eli Zaretskii <eliz@gnu.org>
247
248 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
249 push_it before setting up the iterator for the first overlay
250 string, even if we have an empty string loaded.
251 (next_overlay_string): If there's an empty string on the iterator
252 stack, pop the stack. (Bug#10903)
253
27f3c637
PE
2542012-02-25 Paul Eggert <eggert@cs.ucla.edu>
255
256 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
257 Suggested by Stefan Monnier in
258 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
259 * alloc.c (widen_to_Lisp_Object): New static function.
260 (mark_memory): Also mark Lisp_Objects by fetching pointer words
261 and widening them to Lisp_Objects. This would work even if
262 USE_LSB_TAG is defined and wide integers are used, which might
263 happen in a future version of Emacs.
264
3c9dfce6
CY
2652012-02-25 Chong Yidong <cyd@gnu.org>
266
fa74b241
CY
267 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
268 Doc fix.
269
3c9dfce6
CY
270 * xselect.c (Fx_selection_exists_p): Doc fix.
271 (x_clipboard_manager_save_all): Print an informative message
272 before saving to clipboard manager.
273
9486df08
CY
2742012-02-24 Chong Yidong <cyd@gnu.org>
275
276 * keyboard.c (process_special_events): Handle all X selection
277 requests in kbd_buffer, not just the next one (Bug#8869).
278
f01d3321
CY
2792012-02-23 Chong Yidong <cyd@gnu.org>
280
281 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
282 call when setting menu-bar-lines and tool-bar-lines parameters.
283 (unwind_create_frame_1): New helper function.
284
285 * window.c (inhibit_window_configuration_change_hook): New var.
286 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 287 (syms_of_window): Initialize it.
f01d3321 288
86b847b6
CY
2892012-02-22 Chong Yidong <cyd@gnu.org>
290
291 * xterm.c (x_draw_image_relief): Add missing type check for
292 Vtool_bar_button_margin (Bug#10743).
293
a59225b1
CY
2942012-02-21 Chong Yidong <cyd@gnu.org>
295
296 * fileio.c (Vfile_name_handler_alist): Doc fix.
297
298 * buffer.c (Fget_file_buffer): Protect against invalid file
299 handler return value.
300
310f5bd4
PE
3012012-02-20 Paul Eggert <eggert@cs.ucla.edu>
302
cb3a28cc
PE
303 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
304 when computing $valmask.
305
310f5bd4
PE
306 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
307 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
308 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
309 It's useless in that case, and it can cause problems on hosts
310 that allocate halves of EMACS_INT values separately.
311 Reported by Dan Horák. Diagnosed by Andreas Schwab in
312 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
313 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
314 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
315 it avoids undefined behavior on hosts where shifting right by more
316 than the word width has undefined behavior.
317
2375c96a
CY
3182012-02-19 Chong Yidong <cyd@gnu.org>
319
320 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
321 (Funhandled_file_name_directory, Ffile_name_as_directory)
322 (Fdirectory_file_name, Fexpand_file_name)
323 (Fsubstitute_in_file_name): Protect against invalid file handler
324 return values (Bug#10845).
325
3eb49e71
EZ
3262012-02-18 Eli Zaretskii <eliz@gnu.org>
327
328 * .gdbinit (pitx): Fix incorrect references to fields of the
329 iterator stack.
330
7b926f3f
CY
3312012-02-17 Chong Yidong <cyd@gnu.org>
332
333 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
334
11273115
PE
3352012-02-15 Paul Eggert <eggert@cs.ucla.edu>
336
337 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
338 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
339
c3a70e2b
CY
3402012-02-15 Chong Yidong <cyd@gnu.org>
341
342 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
343 marked as special. Also, starting docstrings with * is obsolete.
344
0ca43699
AS
3452012-02-13 Andreas Schwab <schwab@linux-m68k.org>
346
347 * gnutls.c (emacs_gnutls_write): Fix last change.
348
2e8f3c56
LI
3492012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
350
351 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
352 send_process.
353
af70074f
SM
3542012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
355
356 * keymap.c (Fsingle_key_description): Handle char ranges.
357
95986d52
CY
3582012-02-12 Chong Yidong <cyd@gnu.org>
359
afd83bd1
CY
360 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
361 as that creates a dangerous corner case.
362
95986d52
CY
363 * window.c (Fdelete_window_internal): Invalidate the mouse
364 highlight (Bug#9904).
365
bd7da63e
GM
3662012-02-12 Glenn Morris <rgm@gnu.org>
367
368 * xselect.c (Fx_own_selection_internal)
369 (Fx_get_selection_internal, Fx_disown_selection_internal)
370 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
371 * nsselect.m (Fx_own_selection_internal)
372 (Fx_disown_selection_internal, Fx_selection_exists_p)
373 (Fx_selection_owner_p, Fx_get_selection_internal):
374 Sync docs and argument specs with the xselect.c versions.
375
77abcbc2
LI
3762012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
377
378 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
379
90b671e2
EZ
3802012-02-11 Eli Zaretskii <eliz@gnu.org>
381
1c0ca0b7
EZ
382 * w32select.c (Fx_selection_exists_p): Sync doc string and
383 argument list with xselect.c. (Bug#10783)
384
385 * w16select.c (Fx_selection_exists_p): Sync doc string and
386 argument list with xselect.c. (Bug#10783)
90b671e2 387
49241268
GM
3882012-02-10 Glenn Morris <rgm@gnu.org>
389
390 * fns.c (Fsecure_hash): Doc fix.
391
f998bbe7 3922012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
393
394 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
395
0992bd9c
CY
3962012-02-07 Chong Yidong <cyd@gnu.org>
397
398 * buffer.c (Fbuffer_local_variables)
399 (buffer_lisp_local_variables): Handle unbound vars correctly;
400 don't let Qunbound leak into Lisp.
401
af008560
GM
4022012-02-07 Glenn Morris <rgm@gnu.org>
403
dd605cc4
GM
404 * image.c (Fimagemagick_types): Doc fix.
405
af008560
GM
406 * image.c (imagemagick-render-type): Change it from a lisp object
407 to an integer. Move the doc here from the lisp manual.
408 Treat all values not equal to 0 the same.
409
1449fa1d
CY
4102012-02-06 Chong Yidong <cyd@gnu.org>
411
412 * doc.c (store_function_docstring): Avoid applying docstring of
413 alias to base function (Bug#2603).
414
3723ec07
AS
4152012-02-04 Andreas Schwab <schwab@linux-m68k.org>
416
417 * .gdbinit (pp1, pv1): Remove redundant defines.
418 (pr): Use pp.
419
79c1cc1e
CY
4202012-02-04 Chong Yidong <cyd@gnu.org>
421
422 * nsterm.m: Declare a global (Bug#10694).
423
d7f29f8e
EZ
4242012-02-04 Eli Zaretskii <eliz@gnu.org>
425
cae07000
SM
426 * w32.c (get_emacs_configuration_options):
427 Include --enable-checking, if specified, in the return value.
d7f29f8e 428
3b95a6f9
MR
4292012-02-04 Martin Rudalics <rudalics@gmx.at>
430
431 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
432 after rounding frame sizes. (Bug#9723)
433
d6fa96a6
EZ
4342012-02-04 Eli Zaretskii <eliz@gnu.org>
435
436 * keyboard.c (adjust_point_for_property): Don't position point
437 before BEGV. (Bug#10696)
438
df0b2940
PE
4392012-02-03 Paul Eggert <eggert@cs.ucla.edu>
440
441 Handle overflow when computing char display width (Bug#9496).
442 * character.c (char_width): Return EMACS_INT, not int.
443 (char_width, c_string_width): Check for overflow when
444 computing the width; this is possible now that individual
445 characters can have unbounded width. Problem introduced
446 by merge from Emacs 23 on 2012-01-19.
447
6bee44d6
MA
4482012-02-02 Michael Albinus <michael.albinus@gmx.de>
449
450 * dbusbind.c (Fdbus_register_method): Mention the return value
451 :ignore in the docstring.
452
44f92739
GM
4532012-02-02 Glenn Morris <rgm@gnu.org>
454
1b9f60cc
GM
455 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
456
44f92739
GM
457 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
458 Unconditionally set to t. (Bug#10673)
459 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
460 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
461 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
462
c5d3843c
KH
4632012-02-02 Kenichi Handa <handa@m17n.org>
464
465 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
466 0, do not call append_composite_glyph.
467
159462d4 4682012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
469
470 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
471 NULL (Bug#6988).
472 (x_produce_glyphs): If the component of a composition is a null
473 string, set it->pixel_width to 1 to avoid zero-width glyph.
474
78cef877
EZ
4752012-02-01 Eli Zaretskii <eliz@gnu.org>
476
477 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
478 first 2 arguments are identical. This makes inserting large
479 output from a subprocess an order of magnitude faster on
480 MS-Windows, where all sbrk'ed memory is always contiguous.
481
97897668
GM
4822012-01-31 Glenn Morris <rgm@gnu.org>
483
484 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 485 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
486 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
487
31fd3586
GM
4882012-01-29 Glenn Morris <rgm@gnu.org>
489
490 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
491
0e24a8b2
CY
4922012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
493
494 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
495
cc0adcb0
CY
4962012-01-28 Chong Yidong <cyd@gnu.org>
497
498 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
499
acc28cb9
CY
5002012-01-26 Chong Yidong <cyd@gnu.org>
501
9c69cfb7
CY
502 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
503
acc28cb9
CY
504 * search.c (Fsearch_forward, Fsearch_backward): Document negative
505 repeat counts (Bug#10507).
506
48da7392
GM
5072012-01-26 Glenn Morris <rgm@gnu.org>
508
509 * lread.c (syms_of_lread): Doc fix.
510
14af5f7f
CY
5112012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
512
513 * coding.c (encode_designation_at_bol): Change return value to
514 EMACS_INT.
515
0b21c100
CY
5162012-01-25 Chong Yidong <cyd@gnu.org>
517
518 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
519
3c2907f7
CY
5202012-01-21 Chong Yidong <cyd@gnu.org>
521
522 * floatfns.c (Fcopysign): Make the second argument non-optional,
523 since nil is not allowed anyway.
524
959ad23f
AS
5252012-01-21 Andreas Schwab <schwab@linux-m68k.org>
526
527 * process.c (read_process_output): Use p instead of XPROCESS (proc).
528 (send_process): Likewise.
529
34a02f46
MR
5302012-01-19 Martin Rudalics <rudalics@gmx.at>
531
532 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
533 (Vwindow_persistent_parameters): Do not use Qstate.
534 Rewrite doc-strings.
34a02f46 535
1259009a 5362012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
537
538 * character.c (char_width): New function.
70d4fdf6
GM
539 (Fchar_width, c_string_width, lisp_string_width):
540 Use char_width (Bug#9496).
25ed9e61 541
6a6ee00d
MR
5422012-01-16 Martin Rudalics <rudalics@gmx.at>
543
544 * window.c (Vwindow_persistent_parameters): New variable.
545 (Fset_window_configuration, save_window_save): Handle persistent
546 window parameters.
547
c85efaf7
EZ
5482012-01-14 Eli Zaretskii <eliz@gnu.org>
549
550 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
551 thrashing the stack of the thread. (Bug#9087)
552
5944709e
PE
5532012-01-12 Paul Eggert <eggert@cs.ucla.edu>
554
555 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
556
e71f5d99
EZ
5572012-01-11 Eli Zaretskii <eliz@gnu.org>
558
559 * xdisp.c (rows_from_pos_range): Handle the case where the
560 highlight ends on a newline. (Bug#10464)
561 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
562 he end column for display of highlight that ends on a newline
563 before a R2L line.
564
ce316182
GM
5652012-01-11 Glenn Morris <rgm@gnu.org>
566
567 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
568 from load-path also when installation-directory is nil. (Bug#10208)
569
5b43da69
GM
5702012-01-10 Glenn Morris <rgm@gnu.org>
571
74cc8ff9
GM
572 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
573
7d8d6e4e
GM
574 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
575 Update template values to be closer to their typical values these days.
5b43da69 576
a0db8d43
EZ
5772012-01-09 Eli Zaretskii <eliz@gnu.org>
578
579 * xdisp.c (rows_from_pos_range): Accept additional argument
580 DISP_STRING, and accept any glyph in a row whose object is that
581 string as eligible for mouse highlight. Fixes mouse highlight of
582 display strings from overlays. (Bug#10464)
583
9a0115ab 5842012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 585
b9110d6a 586 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
587 * fileio.c (auto_saving_dir_umask): New static var.
588 (Fmake_directory_internal): Use it.
589 (do_auto_save_make_dir): Set it, instead of invoking chmod after
590 creating the directory. The old code temporarily assigns
591 too-generous permissions to the directory.
592 (do_auto_save_eh): Clear it.
b9110d6a 593 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
594 that the var is always cleared.
595
6c1bd3f3
EZ
5962012-01-07 Eli Zaretskii <eliz@gnu.org>
597
598 * search.c (scan_buffer): Pass character positions to
599 know_region_cache, not byte positions. (Bug#6540)
600
069d2b50
L
6012012-01-07 LynX <_LynX@bk.ru> (tiny change)
602
603 * w32.c (sys_rename): Report EXDEV when rename of a directory
604 fails because the target is on another logical disk. (Bug#10284)
605
75bf0d33
DB
6062012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
607
608 * xterm.c (x_embed_request_focus): New function.
609
610 * xterm.h: Add prototype.
611
612 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
613
1c6e5a32
GM
6142012-01-05 Glenn Morris <rgm@gnu.org>
615
616 * emacs.c (emacs_copyright): Update short copyright year to 2012.
617
651e947e
EZ
6182012-01-01 Eli Zaretskii <eliz@gnu.org>
619
620 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
621 Load gnutls_transport_set_lowat only if GnuTLS version is below
622 2.11.1.
623 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
624 GnuTLS versions below 2.11.1.
625
3778cdd8
AL
6262011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
627
628 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
629 to the doc string advising against its use for altering the way
630 windows are scrolled.
631
0e5317f7
KH
6322011-12-28 Kenichi Handa <handa@m17n.org>
633
634 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
635 coding-system ASCII compatible only when it does not produce BOM
636 on encoding (Bug#10383).
637
93d5ca1f
JD
6382011-12-26 Jan Djärv <jan.h.d@swipnet.se>
639
640 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
641 can scroll.
642 (create_and_show_popup_menu): Always use menu_position_func for
643 Gtk3 (Bug#10361).
644
ca22b785
AS
6452011-12-24 Andreas Schwab <schwab@linux-m68k.org>
646
647 * callint.c (Fcall_interactively): Don't truncate prompt string.
648
d048e1e6
EZ
6492011-12-23 Eli Zaretskii <eliz@gnu.org>
650
651 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
652 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 653 resumed from there (after widening). (Bug#10360)
d048e1e6 654
5ccaba1f
JD
6552011-12-22 Jan Djärv <jan.h.d@swipnet.se>
656
657 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
658
204ee57f
JD
6592011-12-21 Jan Djärv <jan.h.d@swipnet.se>
660
b81d40f0
JB
661 * nsterm.m (x_free_frame_resources):
662 Release f->output_data.ns->miniimage.
204ee57f
JD
663 (ns_index_color): Fix indentation. Do not retain
664 color_table->colors[i].
665
666 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
667 before returning.
668
669 * nsfns.m (x_set_background_color): Assign return value from
670 ns_index_color to face-background instead of NSColor*.
671 (ns_implicitly_set_icon_type): Fix indentation.
672 Change assignment in for loop to comparison.
673
674 * emacs.c (ns_pool): New variable.
675 (main): Assign ns_pool.
676 (Fkill_emacs): Call ns_release_autorelease_pool.
677
678 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
679 autorelease fdesc, release fdAttrs and tdict.
680 (ns_get_covering_families): Release charset.
681 (ns_findfonts): Release NSFontDescriptor created with new.
682 (ns_uni_to_glyphs): Fix indentation.
683 (setString): Release attrStr before assigning new value.
684
c803b2b7
JD
6852011-12-18 Jan Djärv <jan.h.d@swipnet.se>
686
678f4426
JD
687 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
688 and NS_IMPL_COCOA.
689 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
690 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
691
cd394be1 6922011-12-18 David Reitter <reitter@cmu.edu>
678f4426 693
5fecd5fc
JD
694 * nsterm.m (ns_term_init): Subscribe for notifications
695 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
696 to method trackingNotification in EmacsMenu.
697
698 * nsmenu.m (trackingMenu): New variable.
3771cb17 699 (trackingNotification): New method (from Aquamacs).
5fecd5fc 700 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 701 from Aquamacs (Bug#7030).
678f4426
JD
702
7032011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 704
c803b2b7
JD
705 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
706 (symbol_to_nsstring): Fix indentation.
707 (ns_symbol_to_pb): New function.
cae07000
SM
708 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
709 (Fns_rotate_cut_buffers_internal): Remove.
710 (Fns_store_selection_internal): Rename from
c803b2b7
JD
711 Fns_store_cut_buffer_internal.
712 (ns_get_foreign_selection, Fx_own_selection_internal)
713 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
714 (Fns_get_selection_internal, Fns_store_selection_internal):
715 Use ns_symbol_to_pb and check if return value is nil.
716 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
717 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
718 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
719 renamed to Sns_store_selection_internal.
720 (ns_handle_selection_request): Move code to Fx_own_selection_internal
721 and remove this function.
722 (ns_handle_selection_clear): Remove, never used.
723 (Fx_own_selection_internal): Move code from ns_handle_selection_request
724 here.
725
e1b01a3a
KB
7262011-12-17 Ken Brown <kbrown@cornell.edu>
727
728 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
729 GID is unknown (Bug#10257).
730
2adb6e85
PE
7312011-12-17 Paul Eggert <eggert@cs.ucla.edu>
732
733 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
734 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
735 which caused a build failure on GNU/Linux IA-64. This problem was
736 introduced by my 2011-10-07 patch.
737
d1d7b339
JL
7382011-12-15 Juri Linkov <juri@jurta.org>
739
740 * image.c (imagemagick_error): New function. (Bug#10112)
741 (imagemagick_load_image): Comment out `MagickSetResolution' call.
742 Use `imagemagick_error' where ImageMagick functions return
743 `MagickFalse'.
744 (Fimagemagick_types): Add `Fnreverse' to return the list in the
745 proper order.
746
100d5755
KH
7472011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
748
749 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
750 fill background (Bug#8992).
751
454592a6
MR
7522011-12-13 Martin Rudalics <rudalics@gmx.at>
753
754 * window.c (Vwindow_combination_resize)
755 (Vwindow_combination_limit): Use t instead of non-nil in
756 doc-strings.
61d4b438
MR
757 (Vrecenter_redisplay): Add first sentence of doc-string on
758 separate line.
53524d93 759 (Frecenter): Fix doc-string typo.
454592a6 760
3633e3aa
KH
7612011-12-11 Kenichi Handa <handa@m17n.org>
762
763 * coding.c (Funencodable_char_position): Pay attention to the
764 buffer text relocation (Bug#9389).
765
7b9d523a
JD
7662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
767
768 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
769 gtk_init (Bug#10100).
770
b73189c6
EZ
7712011-12-10 Eli Zaretskii <eliz@gnu.org>
772
773 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
774 IT->string is nil. (Bug#10263)
775
f7dfe5d6
JD
7762011-12-10 Jan Djärv <jan.h.d@swipnet.se>
777
83faebb4
JD
778 * nsterm.h (x_free_frame_resources): Declare.
779
f7dfe5d6
JD
780 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
781 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
782
783 * nsterm.h (ns_get_defaults_value): Declare.
784
785 * nsterm.m (ns_default): Call ns_get_defaults_value.
786
7cd4e72c
EZ
7872011-12-09 Eli Zaretskii <eliz@gnu.org>
788
789 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
790 (Bug#10170)
791
b34d7317
YM
7922011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
793
794 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
795 that where the value of an _OBJC_* symbol points to is in the .bss
796 section (Bug#10240).
797
76470ad1
KH
7982011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
799
800 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 801 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 802
745fff94
KH
8032011-12-08 Kenichi Handa <handa@m17n.org>
804
805 * ftfont.c (get_adstyle_property): Fix previous change
806 (Bug#10233).
807
6e44397c
JB
8082011-12-07 Juanma Barranquero <lekktu@gmail.com>
809
810 * w32.c (init_environment): If no_site_lisp, remove site-lisp
811 dirs from the default value of EMACSLOADPATH (bug#10208).
812
7efa6272
GM
8132011-12-07 Glenn Morris <rgm@gnu.org>
814
815 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
816 installation and source directories as well. (Bug#10208)
817
f6fc4d87
CY
8182011-12-06 Chong Yidong <cyd@gnu.org>
819
820 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
821
2bf26180
GM
8222011-12-06 Glenn Morris <rgm@gnu.org>
823
824 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
825 as an error, not just -1. (Bug#10217)
826
3a6ad4f0
CY
8272011-12-05 Chong Yidong <cyd@gnu.org>
828
829 * keyboard.c (process_special_events): New function.
830 (swallow_events, Finput_pending_p): Use it (Bug#10195).
831
75a3b399
PE
8322011-12-05 Paul Eggert <eggert@cs.ucla.edu>
833
834 * coding.c (encode_designation_at_bol): Don't use uninitialized
835 local variable (Bug#9318).
836
c3c9e25e
KH
8372011-12-05 Kenichi Handa <handa@m17n.org>
838
839 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
840 return Qnil (Bug#8046, Bug#10193).
841
5eb05ea3
KH
8422011-12-05 Kenichi Handa <handa@m17n.org>
843
844 * coding.c (encode_designation_at_bol): New args charbuf_end and
845 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
846 (coding_set_source): Return how many bytes coding->source was
847 relocated.
848 (coding_set_destination): Return how many bytes
849 coding->destination was relocated.
850 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 851 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
852
8532011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
854
855 * coding.c (CODING_CHAR_CHARSET_P): New macro.
856 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
857 macro (Bug#9318).
858
8592011-12-05 Andreas Schwab <schwab@linux-m68k.org>
860
861 The following changes are to fix Bug#9318.
862
a79703f5 863 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
864 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
865 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 866 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 867
7dbda6df
JB
8682011-12-05 Juanma Barranquero <lekktu@gmail.com>
869
870 * lisp.h (process_quit_flag): Fix external declaration.
871
6d5eb5b0
SM
8722011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
873
874 Don't macro-inline non-performance-critical code.
875 * eval.c (process_quit_flag): New function.
876 * lisp.h (QUIT): Use it.
877
a0c3fad0
JD
8782011-12-04 Jan Djärv <jan.h.d@swipnet.se>
879
880 * nsfns.m (get_geometry_from_preferences): New function.
881 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
882
6c07aac2
AS
8832011-12-04 Andreas Schwab <schwab@linux-m68k.org>
884
885 * emacs.c (Qkill_emacs): Define.
886 (syms_of_emacs): Initialize it.
887 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
888 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
889 (quit_throw_to_read_char): Add parameter `from_signal'.
890 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
891 * lisp.h (QUIT): Call Fkill_emacs if requested.
892
c052ead4
JD
8932011-12-03 Jan Djärv <jan.h.d@swipnet.se>
894
895 * widget.c (update_wm_hints): Return if wmshell is null.
896 (widget_update_wm_size_hints): New function.
897
898 * widget.h (widget_update_wm_size_hints): Declare.
899
900 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
901 widget_update_wm_size_hints (Bug#10104).
902
9e49252b
EZ
9032011-12-03 Eli Zaretskii <eliz@gnu.org>
904
905 * xdisp.c (handle_invisible_prop): If the invisible text ends just
906 before a newline, prepare the bidi iterator for consuming the
907 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 908 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 909
02b16839
JL
9102011-12-02 Juri Linkov <juri@jurta.org>
911
912 * search.c (Fword_search_regexp): New Lisp function created from
913 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
914 (Fword_search_backward, Fword_search_forward)
915 (Fword_search_backward_lax, Fword_search_forward_lax):
916 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
917 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
918
0068070e
SM
9192011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
920
921 * fileio.c (Finsert_file_contents): Move after-change-function call
922 to before the "handled:" label, since all "goto handled" appear in
923 cases where the *-change-functions have already been properly called
924 (bug#10117).
925
3360a3fc
AS
9262011-12-01 Andreas Schwab <schwab@linux-m68k.org>
927
928 * keyboard.c (interrupt_signal): Don't call kill-emacs when
929 waiting for input. (Bug#10169)
930
73d6c093
EZ
9312011-11-30 Eli Zaretskii <eliz@gnu.org>
932
933 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
934 verifies glyph row's hash code--we have just reallocated the
935 glyphs, so their contents can be complete garbage. (Bug#10164)
936
febe6bea
JB
9372011-11-30 Juanma Barranquero <lekktu@gmail.com>
938
939 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
940
801a4313
EZ
9412011-11-30 Eli Zaretskii <eliz@gnu.org>
942
943 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
944 attributes are tested _before_ calling verify_row_hash, to protect
945 against GCC re-ordering of the tests. (Bug#10164)
946
2b56b87e
JD
9472011-11-29 Jan Djärv <jan.h.d@swipnet.se>
948
949 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
950
951 * xterm.c (handle_one_xevent): Only set async_visible and friends
952 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 953 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
954 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
955
dbf31225
PE
9562011-11-28 Paul Eggert <eggert@cs.ucla.edu>
957
958 Remove GCPRO-related macros that exist only to avoid shadowing locals.
959 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
960 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
961 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
962 All uses changed to use GCPRO1 etc.
963 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
964 Revert to old implementation (i.e., before 2011-03-11).
965
1305621b
YM
9662011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
967
968 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
969 of scroll runs so as to avoid assigning disabled bogus rows and
970 unnecessary graphics copy operations.
971
8c9afb46
EZ
9722011-11-27 Eli Zaretskii <eliz@gnu.org>
973
974 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
975 (snprintf) [_MSC_VER]: Redirect to _snprintf.
976 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
977 (malloc, free, realloc, calloc): Redirect to e_* only when
978 compiling Emacs.
979
980 * lisp.h (GCTYPEBITS): Move before first use.
981 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
982 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
983 this macro definition.
984
985 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
986 _MSC_VER.
987
54e9e3bf
JD
9882011-11-27 Jan Djärv <jan.h.d@swipnet.se>
989
6d5eb5b0
SM
990 * gtkutil.c (xg_create_frame_widgets):
991 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
992 present with Gtk+ 2.0.
993
83aca1cb
PE
9942011-11-26 Paul Eggert <eggert@cs.ucla.edu>
995
996 * fileio.c (Finsert_file_contents): Undo previous change; see
997 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
998
5b76caa4
PE
9992011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1000
1001 Rename locals to avoid shadowing.
1002 * fileio.c (Finsert_file_contents):
1003 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1004 * process.c (wait_reading_process_output):
1005 Rename inner 'proc' to 'p' to avoid shadowing.
1006 Indent for consistency with usual Emacs style.
1007
8c535114
EZ
10082011-11-25 Eli Zaretskii <eliz@gnu.org>
1009
1010 * xdisp.c (redisplay_window): If cursor row is not fully visible
1011 after recentering, and scroll-conservatively is set to a large
1012 number, scroll window by a few more lines to make the cursor fully
1013 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1014 (start_display): Don't move to the next line if the display should
1015 start at a newline that is part of a display vector or an overlay
1016 string. (Bug#10119)
8c535114 1017
fa4fdb5c
JL
10182011-11-24 Juri Linkov <juri@jurta.org>
1019
1020 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1021 after the `MagickPingImage' call. (Bug#10112)
1022
90ec88df
CY
10232011-11-23 Chong Yidong <cyd@gnu.org>
1024
1025 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1026
56e2e794
MR
10272011-11-23 Martin Rudalics <rudalics@gmx.at>
1028
1029 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1030 making another buffer current. (Bug#10114)
1031
b6e64c41
GM
10322011-11-23 Glenn Morris <rgm@gnu.org>
1033
1034 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1035
6b21de18
CY
10362011-11-23 Chong Yidong <cyd@gnu.org>
1037
1038 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1039 using it (Bug#5984).
1040
b12cd789
EZ
10412011-11-22 Eli Zaretskii <eliz@gnu.org>
1042
1043 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1044 and header-lines, as they don't have one computed for them.
1045 (Bug#10098)
1046
1047 * .gdbinit (prow): Make displayed values more self-explaining.
1048 Add row's hash code.
1049
261b6fd4
LMI
10502011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1051
1052 * process.c (wait_reading_process_output): Fix asynchrounous
1053 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1054 (wait_reading_process_output): Add comment and URL.
261b6fd4 1055
e7cfd277
JD
10562011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1057
1058 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1059
a9b9b7f5
CY
10602011-11-21 Chong Yidong <cyd@gnu.org>
1061
1062 * window.c (Fnext_window, Fprevious_window): Doc fix.
1063
b0d15b4f
SM
10642011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1065
1066 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1067
fe7a3057
JB
10682011-11-20 Juanma Barranquero <lekktu@gmail.com>
1069
1070 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1071
d2999b1a
MR
10722011-11-20 Martin Rudalics <rudalics@gmx.at>
1073
1074 * window.c (Fset_window_combination_limit): Rename argument
1075 STATUS to LIMIT.
1076 (Vwindow_combination_limit): Remove "status" from doc-string.
1077
d5ff9cd0
AS
10782011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1079
1080 * m/ibms390.h: Remove.
1081 * m/ibms390x.h: Don't include "ibms390.h".
1082
a5bb9bd3
SM
10832011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1084
1085 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1086 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1087
cd1181db
JB
10882011-11-20 Juanma Barranquero <lekktu@gmail.com>
1089
1090 * casetab.c (Fset_case_table):
1091 * charset.c (Fcharset_after): Fix typos.
1092
615a3b8d 10932011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1094
17e845af
PE
1095 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1096 Otherwise, valgrind does not work on some platforms.
1097 Problem reported by Andreas Schwab in
6a0bf43d
PE
1098 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1099 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1100 is set, removing the need for VIRT_ADDRESS_VARIES.
1101 (PURE_P): Use a more-efficient implementation that needs just one
1102 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1103 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1104 to 4 (xorl, subq, cmpq, setbe).
1105 * alloc.c (pure): Always extern now, since that's the
1106 VIRT_ADDR_VARIES behavior.
1107 (PURE_POINTER_P): Use a single comparison, not two, for
1108 consistency with the new puresize.h.
1109 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1110 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1111 Remove VIRT_ADDR_VARIES no longer needed.
1112
f8fe6f96
EZ
11132011-11-19 Eli Zaretskii <eliz@gnu.org>
1114
1115 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1116 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1117 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1118 behave as if the cursor position were at the window margin.
1119
1120 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1121 and the cursor position is out of bounds, behave as if the cursor
1122 position were at the window margin. (Bug#10075)
1123
df05a53c
CY
11242011-11-18 Chong Yidong <cyd@gnu.org>
1125
1126 * window.c (Fwindow_combination_limit): Make first argument
1127 non-optional, since it is meaningless for live windows like the
1128 selected window.
1129
2071918e
DA
11302011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1133
b50a28de
SM
11342011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1137 (graft_intervals_into_buffer): Simplify.
1138
015137db
EZ
11392011-11-18 Eli Zaretskii <eliz@gnu.org>
1140
1141 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1142 hash values of the two rows.
1143 (copy_row_except_pointers): Preserve the used[] arrays and the
1144 hash values of the two rows. (Bug#10035)
68c95424 1145 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1146
1147 * xdisp.c (row_hash): New function, body extracted from
1148 compute_line_metrics.
1149 (compute_line_metrics): Call row_hash, instead of computing the
1150 hash code inline.
1151
1152 * dispnew.c (verify_row_hash): Call row_hash for computing the
1153 hash code of a row, instead of duplicating code from xdisp.c.
1154
1155 * dispextern.h (row_hash): Add prototype.
1156
a2addb04
TH
11572011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1158
1159 * frame.c (delete_frame): Don't delete the terminal when the last
1160 X frame is closed if emacs is built with GTK toolkit.
1161
df85d315
JB
11622011-11-17 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1165
a0c2d0ae
MR
11662011-11-17 Martin Rudalics <rudalics@gmx.at>
1167
1168 * window.c (Vwindow_splits): Rename to
1169 Vwindow_combination_resize. Suggested by Juri Linkov.
1170 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1171 of Vwindow_splits.
1172
58179cce
JB
11732011-11-16 Juanma Barranquero <lekktu@gmail.com>
1174
7877f373
JB
1175 * nsfns.m (Fns_font_name):
1176 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1177
b6f67890
MR
11782011-11-16 Martin Rudalics <rudalics@gmx.at>
1179
1180 * window.h (window): Rename slot "nest" to "combination_limit".
1181 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1182 (Fset_window_nest): Rename to Fset_window_combination_limit.
1183 (Vwindow_nest): Rename to Vwindow_combination_limit.
1184 (recombine_windows, make_parent_window, make_window)
1185 (Fsplit_window_internal, saved_window)
1186 (Fset_window_configuration, save_window_save): Rename all
1187 occurrences of window_nest to window_combination_limit.
1188
c7015153
JB
11892011-11-15 Juanma Barranquero <lekktu@gmail.com>
1190
1191 * image.c (imagemagick_load_image): Fix typo.
1192
322ad6ec
EZ
11932011-11-14 Eli Zaretskii <eliz@gnu.org>
1194
1195 * xdisp.c (display_line): Move the call to
1196 highlight_trailing_whitespace before the call to
1197 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1198 faces of all the glyphs to compute ROW's hash value.
1199 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1200
f067b8ec
JB
12012011-11-14 Juanma Barranquero <lekktu@gmail.com>
1202
1203 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1204 just return (bug#10044).
1205
1e5b2111
EZ
12062011-11-12 Eli Zaretskii <eliz@gnu.org>
1207
7ef3cbd5
EZ
1208 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1209 with user-defined heap size. Bump the default size of the temacs
1210 heap to 27MB, to avoid memory warning when running temacs.
1211 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1212
1e5b2111
EZ
1213 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1214 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1215 (verify_row_hash) [XASSERTS]: New function.
1216 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1217 that the hash value of glyph rows is correct.
1e5b2111 1218
89d61221
MR
12192011-11-12 Martin Rudalics <rudalics@gmx.at>
1220
1221 * window.h (window): Remove splits slot.
1222 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1223 (Fdelete_other_windows_internal, make_parent_window)
1224 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1225 (Fset_window_configuration, save_window_save): Don't deal with
1226 split status of windows.
1227 (saved_window): Remove splits slot.
1228 (Vwindow_splits): Rewrite doc-string.
1229
97f18cc8
JD
12302011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1231
1232 * xfns.c (unwind_create_frame):
1233 * nsfns.m (unwind_create_frame):
1234 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1235 Vframe_list (Bug#9999).
1236
22a648b4
DA
12372011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1238
0b381c7e 1239 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1240
659afede
KH
12412011-11-11 Kenichi Handa <handa@m17n.org>
1242
1243 * callproc.c (Fcall_process): Set the member dst_multibyte of
1244 process_coding.
1245
9ac0394b
KH
12462011-11-11 Johan Bockgård <bojohan@gnu.org>
1247
1248 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1249 avoid a crash (bug#9496).
1250
2fbdc249
CY
12512011-11-09 Chong Yidong <cyd@gnu.org>
1252
1253 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1254 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1255
ac6b1f81
PE
12562011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1259
09db192c
PE
12602011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 Avoid some portability problems by eschewing 'extern inline' functions.
1263 The trivial performance wins aren't worth the portability hassles; see
1264 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1265 et seq.
1266 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1267 (window_box_width, window_box_left, window_box_left_offset)
1268 (window_box_right, window_box_right_offset): Undo previous change,
1269 by removing the "extern"s.
1270 * intervals.c (adjust_intervals_for_insertion)
1271 (adjust_intervals_for_deletion): Undo previous change,
1272 making these static again.
1273 (offset_intervals, temp_set_point_both, temp_set_point)
1274 (copy_intervals_to_string): No longer inline.
1275 * xdisp.c (window_text_bottom_y, window_box_width)
1276 (window_box_height, window_box_left_offset)
1277 (window_box_right_offset, window_box_left, window_box_right)
1278 (window_box): No longer inline.
1279
105216ed
CY
12802011-11-08 Chong Yidong <cyd@gnu.org>
1281
1282 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1283 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1284 Signal an error if not a live window.
105216ed
CY
1285 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1286 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1287
ae9e237f
JB
12882011-11-07 Juanma Barranquero <lekktu@gmail.com>
1289
1290 * lisp.h (syms_of_abbrev): Remove declaration.
1291 Reported by CHENG Gao <chenggao@royau.me>.
1292
c7aa8333
EZ
12932011-11-07 Eli Zaretskii <eliz@gnu.org>
1294
1295 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1296 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1297 of temacs in GUI mode.
1298
be7f5545
MR
12992011-11-07 Martin Rudalics <rudalics@gmx.at>
1300
1301 * window.h: Declare delete_all_child_windows instead of
1302 delete_all_subwindows.
1303 * window.c (Fwindow_nest, Fset_window_nest)
1304 (Fset_window_new_total, Fset_window_new_normal)
1305 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1306 (delete_all_subwindows): Rename to delete_all_child_windows.
1307 (Fdelete_other_windows_internal, Fset_window_configuration):
1308 Call delete_all_child_windows instead of delete_all_subwindows.
1309 * frame.c (delete_frame): Call delete_all_child_windows instead
1310 of delete_all_subwindows.
1311
ca78dc43
PE
13122011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1315 This is also needed for porting to any host where GC_MARK_STACK is
1316 not GC_MAKE_GCPROS_NOOPS.
1317 (which_symbols): Use it.
1318
a0241d01
KH
13192011-11-07 Kenichi Handa <handa@m17n.org>
1320
1321 * coding.c (coding_set_destination): Check coding->src_pos only
1322 when coding->src_object is a buffer (bug#9910).
1323
1324 * process.c (send_process): Set the member src_multibyte of coding
1325 to 0 (bug#9911) when sending a unibyte text.
1326
1327 * callproc.c (Fcall_process): Set the member src_multibyte of
1328 process_coding to 0 (bug#9912).
1329
a64bfdfa 13302011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1331
1332 * xmenu.c (cleanup_widget_value_tree): New function.
1333 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1334 calling free_menubar_widget_value_tree directly (Bug#9830).
1335
cb41b32a
PE
13362011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 Fix some portability problems with 'inline'.
1339 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1340 (window_box_width, window_box_left, window_box_left_offset)
1341 (window_box_right, window_box_right_offset): Declare extern.
1342 Otherwise, these inline functions do not conform to C99 and
1343 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1344 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1345 * intervals.c (adjust_intervals_for_insertion)
1346 (adjust_intervals_for_deletion): Now extern, because otherwise the
1347 extern inline functions 'offset_intervals' couldn't refer to it.
1348 (static_offset_intervals): Remove.
1349 (offset_intervals): Rewrite using the old contents of
1350 static_offset_intervals. The old version didn't conform to C99
1351 because an extern inline function contained a reference to an
1352 identifier with static linkage.
1353
b7041366
AS
13542011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1355
1356 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1357 GC.
1358
88a37c4d
EZ
13592011-11-06 Eli Zaretskii <eliz@gnu.org>
1360
1361 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1362 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1363 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1364 return Qleft_to_right.
1365
49745b39
CY
13662011-11-06 Chong Yidong <cyd@gnu.org>
1367
1368 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1369 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1370 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1371 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1372 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1373 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1374 (Fwindow_vscroll): Doc fix.
1375 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1376 argument, since it makes no sense to pass a live window and for
1377 consistency with window-child.
1378
1f05cd82
CS
13792011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1380
1381 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1382 support MSVC.
1383
22610910
JR
13842011-11-05 Jason Rumney <jasonr@gnu.org>
1385
1386 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1387 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1388 fonts (Bug#6029).
1389 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1390 bitwise arithmetic preventing use of unicode-sip and non-truetype
1391 opentype fonts.
1392
a06776b2
EZ
13932011-11-05 Eli Zaretskii <eliz@gnu.org>
1394
3ad924ba
EZ
1395 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1396 "emacs"-only part.
1397
a06776b2
EZ
1398 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1399 initialization code to keep similarity to xfns.c after changes
1400 from 2011-11-05.
1401
c9e7db78
JD
14022011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1403
a97f8f3f
JD
1404 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1405 (unwind_create_frame): New function (Bug#9943).
1406 (Fx_create_frame): Restructure code to be more similar to the one in
1407 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1408 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1409 Move terminal->reference_count++ just before making the frame official
1410 (Bug#9943).
1411
1412 * nsterm.m (x_free_frame_resources): New function.
1413 (x_destroy_window): Move code to x_free_frame_resources.
1414
c9e7db78 1415 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1416 (Fx_create_frame, x_create_tip_frame):
1417 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1418 official. Move initialization of image_cache_refcount and
1419 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1420
a6fc3b5c
EZ
14212011-11-05 Eli Zaretskii <eliz@gnu.org>
1422
1423 Support MSVC build with newer versions of Visual Studio.
1424 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1425 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1426 nt/gmake.defs.
1427
1428 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1429 which are not supported by MSVC.
1430 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1431 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1432 bitfields.
1433 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1434 types in bitfields.
1435 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1436
1437 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1438
58179cce 14392011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1440
1441 Support MSVC build with newer versions of Visual Studio.
1442 * w32.c: Don't include w32api.h for MSVC.
1443 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1444
1445 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1446 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1447 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1448 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1449 e_* cousins.
1450 (alloca) [_MSC_VER]: Define to _alloca.
1451
1452 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1453
1454 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1455
a58c13ed
EZ
14562011-11-04 Eli Zaretskii <eliz@gnu.org>
1457
1458 * xdisp.c (note_mouse_highlight): If either of
1459 previous/next-single-property-change returns nil, treat that as
1460 the beginning or the end of the buffer. (Bug#9955)
1461
fe0b6370
JD
14622011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1463
a58c13ed 1464 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1465 label is not null (Bug#9951).
1466 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1467 may be NULL.
1468
89bd5ee1
EZ
14692011-11-04 Eli Zaretskii <eliz@gnu.org>
1470
1471 * window.c (Fwindow_body_size): Mention in the doc string that the
1472 return value is in frame's canonical units. (Bug#9949)
1473
84c3edb9
EZ
14742011-11-03 Eli Zaretskii <eliz@gnu.org>
1475
4e2fb5c7
EZ
1476 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1477
84c3edb9 1478 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1479 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1480 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1481
bc17a887
EZ
14822011-11-01 Eli Zaretskii <eliz@gnu.org>
1483
1484 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1485 Don't stop backward scan on the continuation glyph, even though
1486 its CHARPOS is positive.
6d5eb5b0
SM
1487 (mouse_face_from_buffer_pos, note_mouse_highlight):
1488 Rename cover_string to disp_string.
bc17a887 1489
4ee88440
MR
14902011-11-01 Martin Rudalics <rudalics@gmx.at>
1491
1492 * window.c (temp_output_buffer_show): Don't use
1493 Vtemp_buffer_show_specifiers.
1494 (Vtemp_buffer_show_specifiers): Remove unused variable.
1495
c2ff3c02
EZ
14962011-10-30 Eli Zaretskii <eliz@gnu.org>
1497
1498 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1499 past the beginning of the current glyph matrix.
1500
58179cce 15012011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1502
1503 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1504 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1505 HAVE_GTK3 (Bug#9869).
b77a6a7f 1506
3b574623
JD
1507 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1508 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1509
b77a6a7f
JD
1510 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1511
1512 * xterm.c: Declare x_handle_net_wm_state to return int.
1513 (handle_one_xevent): Check if we are iconified but don't have
1514 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1515 (get_current_wm_state): Return non-zero if not hidden,
1516 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1517 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1518 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1519 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1520
196e41e4
PE
15212011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1524 so that this new function doesn't get optimized away by a
1525 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1526
021f2e1a
AS
15272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1528
1529 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1530
8b058d44
EZ
15312011-10-29 Eli Zaretskii <eliz@gnu.org>
1532
1533 Fix the `xbytecode' command.
1534 * .gdbinit (xprintbytestr): New command.
b50a28de 1535 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1536 (xbytecode): Print the byte-code string as well.
1537
4452fb80
EZ
15382011-10-29 Kim Storm <storm@cua.dk>
1539
8b058d44
EZ
1540 * alloc.c (which_symbols): New function.
1541
21b72067
AS
15422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1543
1544 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1545 line. (Bug#9903)
1546
83ed7b5c
GM
15472011-10-29 Glenn Morris <rgm@gnu.org>
1548
1549 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1550 Not clear what it was for, and it causes various bugs. (Bug#9839)
1551
5a7a728b
EZ
15522011-10-28 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1555 possible random value that matches one of those tested as
1556 condition to clear the mouse face.
1557
d3d0842f
CY
15582011-10-28 Chong Yidong <cyd@gnu.org>
1559
1560 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1561
31b39d13
DN
15622011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1563
1564 * window.c (make_window): Initialize phys_cursor_on_p.
1565
9aba6043
SM
15662011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1567
1568 * lisp.h (struct Lisp_Symbol): Update comments.
1569
c20992f4
JB
15702011-10-28 Juanma Barranquero <lekktu@gmail.com>
1571
1572 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1573
db4f02f2
EZ
15742011-10-28 Eli Zaretskii <eliz@gnu.org>
1575
1576 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1577 <oslsachem@gmail.com> for helping to debug this.
1578
1579 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1580 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1581 (g_b_init_get_glyph_outline_w): New static variables.
1582 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1583 (GetGlyphOutlineW_Proc): New typedefs.
1584 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1585 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1586 New functions.
1587 (w32font_open_internal, compute_metrics):
1588 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1589 instead of calling the "wide" APIs directly.
1590
1591 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1592
1593 * w32.h (syms_of_w32font): Add prototype.
1594
87e68db4
JB
15952011-10-27 Juanma Barranquero <lekktu@gmail.com>
1596
1597 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1598 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1599 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1600 (Fmove_to_window_line): Doc fix.
1601
435c1d67
CY
16022011-10-27 Chong Yidong <cyd@gnu.org>
1603
1604 * process.c (make_process): Set gnutls_state to NULL.
1605
1606 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1607 non-NULL, regardless of GNUTLS_INITSTAGE.
1608 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1609 an error. Set process slots as soon as we allocate them.
1610
1611 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1612
9c6c6f49
CY
16132011-10-27 Chong Yidong <cyd@gnu.org>
1614
9aba6043
SM
1615 * gnutls.c (emacs_gnutls_deinit): New function.
1616 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1617 (Fgnutls_deinit, Fgnutls_boot): Use it.
1618
1619 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1620 (deactivate_process): Call emacs_gnutls_deinit.
1621
657d08d3
JB
16222011-10-27 Juanma Barranquero <lekktu@gmail.com>
1623
1624 * image.c (x_create_x_image_and_pixmap):
1625 * w32.c (sys_rename, w32_delayed_load):
1626 * w32font.c (fill_in_logfont):
1627 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1628
5430d399
JB
16292011-10-26 Juanma Barranquero <lekktu@gmail.com>
1630
1631 * w32fns.c (w32_default_color_map): New function,
1632 extracted from Fw32_default_color_map.
a7ef684b 1633 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1634
fe0055fa
PE
16352011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1638
e6346438
SM
16392011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1640
1641 * keyboard.c (test_undefined): New function (bug#9751).
1642 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1643
e112cc37
ET
16442011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1645
1646 * sysdep.c (init_sys_modes): Fix the check for the controlling
1647 terminal (Bug#6649).
1648
7b5d6677
EZ
16492011-10-20 Eli Zaretskii <eliz@gnu.org>
1650
1651 * dispextern.h (struct bidi_it): New member next_en_type.
1652
1653 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1654 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1655 current character, check also for next_en_type being WEAK_EN.
1656 (bidi_resolve_weak): Don't enter the expensive loop if the current
1657 position is before next_en_pos. Record the bidi type of the first
1658 non-ET, non-BN character we find, in addition to its position.
1659 (bidi_level_of_next_char): Invalidate next_en_type when
1660 next_en_pos is over-stepped.
1661
7da0b018
PE
16622011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1663
1664 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1665 * editfns.c: Rewrite current-time-zone so that it invokes
1666 the equivalent of (format-time-string "%Z") to get the time zone name.
1667 This fixes a bug when the time zone name contains characters that
1668 need converting from the system time locale to Emacs internal format.
1669 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1670 that patch fixed format-time-string to do the conversion, but
1671 I forgot to fix current-time-zone.
1672 (format_time_string): New function, containing most of
1673 what Fformat_time_string used to contain.
1674 (Fformat_time_string): Rewrite in terms of format_time_string.
1675 This doesn't change this function's behavior.
1676 (current-time-zone): Rewrite to use format_time_string.
1677 This fixes the bug reported by Michael Schierl in
1678 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1679 Jason Rumney's 2007-06-07 change worked around this bug, but
1680 didn't fix it.
1681 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1682
8547b010
EZ
16832011-10-19 Eli Zaretskii <eliz@gnu.org>
1684
1685 * xdisp.c (start_display): If the character at POS is displayed
1686 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1687 (try_window_reusing_current_matrix): If a line ends in a display
1688 vector or the next line starts in a display vector, continue
1689 redrawing the window even though the character position of
1690 start_row was reached.
8547b010
EZ
1691 (Bug#9771, part 2)
1692
4e948d15
CY
16932011-10-18 Chong Yidong <cyd@gnu.org>
1694
1695 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1696 with nobreak-char-display too.
1697
4787455f
EZ
16982011-10-18 Eli Zaretskii <eliz@gnu.org>
1699
1700 Fix part 3 of bug#9771.
1701 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1702 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1703 non-neutral characters if the current character is a paragraph
1704 separator (a.k.a. Newline). This avoids running the same
1705 expensive loop twice, once when we consume the preceding newline
1706 and the other time when the line actually needs to be displayed.
1707 Avoid the loop when we see neutrals on the base embedding level
1708 following a character whose directionality is the same as the
1709 paragraph's. This avoids running the expensive loop when a line
1710 ends in a long sequence of neutrals, like control characters.
1711 Add assertion against STRONG_AL type. Slightly rearrange code
1712 that determines the type of a neutral given the first non-neutral
1713 that follows it.
1714 (bidi_level_of_next_char): Set next_en_pos to zero when
1715 invalidating its info.
1716
2c91f553
EZ
17172011-10-17 Eli Zaretskii <eliz@gnu.org>
1718
1719 * xdisp.c (push_display_prop): Determine whether to record string
1720 or buffer position by IT->string, not by IT->method. Allow
1721 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1722 (move_it_vertically_backward): Don't look for character position
1723 immediately after the newline when in a continuation line.
1724 (Bug#9771, part 1)
2c91f553 1725
c7b08b0d
MR
17262011-10-15 Martin Rudalics <rudalics@gmx.at>
1727
1728 * window.c (coordinates_in_window): Rewrite and delabelize
1729 vertical border check. (Bug#5357) (Bug#9618)
1730
6b02f655
SM
17312011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1732
1733 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1734 errors in XSetWindowBorder (bug#9310).
1735
81d40c92
DA
17362011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1737
1738 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1739 avoid crash when xmalloc overrun checking is enabled.
1740
d4172c3b
EZ
17412011-10-13 Eli Zaretskii <eliz@gnu.org>
1742
1743 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1744 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1745 cursor motion with <left> and <right> arrow keys.
1746
1747 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1748 some callers set that themselves.
1749
b00eea75
EZ
17502011-10-12 Eli Zaretskii <eliz@gnu.org>
1751
1752 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1753 display string and the previous row comes from the same string and
1754 is empty. (Bug#9739) (Bug#9738)
1755
8fe012c4
SM
17562011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1757
1758 * doc.c (get_doc_string): Encode file name (bug#9735).
1759
0074aef2
EZ
17602011-10-12 Eli Zaretskii <eliz@gnu.org>
1761
79beb178
EZ
1762 * bidi.c (bidi_level_of_next_char):
1763 * xdisp.c (get_visually_first_element): Remove old incorrect
1764 comments regarding the Unicode Line Separator character.
1765
0074aef2
EZ
1766 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1767
6e4b3fbe
DA
17682011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1769
1770 * alloc.c (Fgc_status): Do not access beyond zombies array
1771 boundary if nzombies > MAX_ZOMBIES.
1772 * alloc.c (dump_zombies): Add missing format specifier.
1773
0324f3af
PE
17742011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1775
b5525cac
PE
1776 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1777 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1778
0324f3af
PE
1779 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1780 Some packages use them to denote characters with modifiers.
1781
e9b5f888
AS
17822011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1783
1784 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1785 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1786 matching a pp-number. Rename parameter var to var1.
1787
127827c0
SM
17882011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1789
1790 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1791
c8fd3bd0
GM
17922011-10-08 Glenn Morris <rgm@gnu.org>
1793
1794 * callint.c (Fcall_interactively): Give a more explicit error for the
1795 'c' case with a non-character input. (Bug#8479)
1796
352ec8ff
EZ
17972011-10-08 Eli Zaretskii <eliz@gnu.org>
1798
03669ccb
EZ
1799 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1800 lines.
7061c986
EZ
1801 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1802 lines that are hscrolled on the left.
03669ccb 1803
352ec8ff
EZ
1804 * dispnew.c (buffer_posn_from_coords): Account for a possible
1805 presence of header-line. (Bug#4426)
1806
a66cfb1c
SM
18072011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1808
6b02f655
SM
1809 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1810 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1811
7c5ee88e
PE
18122011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1813
1814 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1815 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1816 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1817 this makes Emacs dump core during garbage collection on rare
1818 occasions. sizeof is obviously inferior to offsetof here, so
1819 stick with offsetof.
1820 (GC_POINTER_ALIGNMENT): New macro.
1821 (mark_memory): Omit 3rd (offset) arg; caller changed.
1822 Don't assume EMACS_INT alignment is the same as pointer alignment.
1823
df1bbe5b
SM
18242011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1825
1826 * keyboard.c (read_key_sequence_remapped): New var.
1827 (read_key_sequence): Compute remapping in the right buffer.
1828 (command_loop_1): Use read_key_sequence's remapping directly.
1829
51553db6
SM
18302011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1831
32c1fffd
SM
1832 * dired.c (file_name_completion): Don't expand file name.
1833 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1834 before checking file name handler.
1835
51553db6
SM
1836 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1837 they've been requested explicitly (bug#9591).
1838
b6bd1599 18392011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1840
1841 * keymap.c (Fsingle_key_description): Use make_specified_string
1842 instead of build_string to build string from push_key_description.
1843 (Bug#5193)
1844
f701dc2a
PE
18452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1846
4222c55d
PE
1847 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1848 This fixes a Y2038 bug on 64-bit hosts.
1849 * buffer.c (reset_buffer):
1850 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1851 (Fclear_buffer_auto_save_failure):
1852 Use 0, not -1, to represent an unset failure time, since time_t
1853 might not be signed.
1854
f701dc2a
PE
1855 Remove dependency on glibc malloc internals.
1856 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1857 Move back here from lisp.h, but with their new implementations.
1858 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1859 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1860 * charset.c (charset_table_init): New static var.
1861 (syms_of_charset): Use it instead of xmalloc. This removes a
1862 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1863 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1864 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1865 Move back to alloc.c.
1866 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1867 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1868
9ceebf39
JD
18692011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1870
1871 * nsterm.m (windowDidResize): Call x_set_window_size only when
1872 ns_in_resize is true. Otherwise set pixelwidth/height and
1873 call change_frame_size (Bug#9628).
1874
cb993c58
PE
18752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1876
3930c88b
PE
1877 Port --enable-checking=all to Fedora 14 x86-64.
1878 * charset.c (syms_of_charset): Also account for glibc malloc's
1879 internal overhead when calculating the initial malloc maximum.
1880
cb993c58
PE
1881 Port --enable-checking=all to Fedora 14 x86.
1882 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1883 Move to lisp.h.
1884 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1885 (overrun_check_realloc, overrun_check_free):
1886 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1887 That way, xmalloc returns a properly-aligned pointer even if
1888 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1889 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1890 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1891 into account when calculating the initial malloc maximum.
1892 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1893 Move here from alloc.c, so that charset.c can use it too.
1894 Properly align; the old code wasn't right for common 32-bit hosts
1895 when configured with --enable-checking=all.
1896 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1897 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1898
31bed486
EZ
18992011-09-29 Eli Zaretskii <eliz@gnu.org>
1900
04c70788 1901 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1902 use EDOM.
1903
fbcaa2f3
EZ
19042011-09-28 Eli Zaretskii <eliz@gnu.org>
1905
1906 * xdisp.c (compute_display_string_end): If there's no display
1907 string at CHARPOS, return -1.
1908
1909 * bidi.c (bidi_fetch_char): When compute_display_string_end
1910 returns a negative value, treat the character as a normal
1911 character not covered by a display string. (Bug#9624)
1912
a239d4e9
JB
19132011-09-28 Juanma Barranquero <lekktu@gmail.com>
1914
1915 * lread.c (Fread_from_string): Fix typo in docstring.
1916
88652fd5
EZ
19172011-09-27 Eli Zaretskii <eliz@gnu.org>
1918
1919 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1920 newline, reseat the iterator instead of bidi-iterating there one
1921 character at a time. (Bug#9610)
32c1fffd
SM
1922 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1923 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1924
ed497dd4
AS
19252011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1926
1927 * lread.c (readevalloop): Use correct code for NBSP.
1928 (read1): Likewise. (Bug#9608)
1929
b2bf61aa
MA
19302011-09-25 Michael Albinus <michael.albinus@gmx.de>
1931
1932 * dbusbind.c (Fdbus_register_signal): When service is not
1933 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1934
32bbb17c
GM
19352011-09-25 Glenn Morris <rgm@gnu.org>
1936
1937 * buffer.c (truncate-lines): Doc fix.
1938
94e0933e
CY
19392011-09-24 Chong Yidong <cyd@stupidchicken.com>
1940
1941 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1942 (Fset_window_next_buffers): Doc fix.
1943
cddde921
GM
19442011-09-24 Glenn Morris <rgm@gnu.org>
1945
1946 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1947
1260aef1
PE
19482011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1949
25b4bfa0
PE
1950 Fix minor problems found by static checking.
1951 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1952 * indent.c (Fvertical_motion): Fix == vs = typo.
1953
e3cbd34b
EZ
19542011-09-24 Eli Zaretskii <eliz@gnu.org>
1955
a66cfb1c
SM
1956 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1957 Default value is now t. Doc fix.
6bf7006f 1958
e3cbd34b 1959 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1960 logic when moving up, not only when moving down. Fix the
e3cbd34b 1961 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1962 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1963
1964 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1965 CHARPOS is covered by a display string which includes newlines.
1966 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1967 is covered by a display string with embedded newlines.
1968
a3de0cbd
MA
19692011-09-24 Michael Albinus <michael.albinus@gmx.de>
1970
1971 * dbusbind.c (Fdbus_register_signal): Add match rule to
1972 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1973 (Fdbus_register_method, Vdbus_registered_objects_table):
1974 Fix docstring.
a3de0cbd 1975
b260039d
JM
19762011-09-24 Jim Meyering <meyering@redhat.com>
1977
32c1fffd 1978 do not ignore write error for any output size
b260039d
JM
1979 The previous change was incomplete.
1980 While it makes emacs --batch detect the vast majority of stdout
1981 write failures, errors were still ignored whenever the output size is
1982 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1983 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1984 && echo FAIL: ignored write error
1985 FAIL: ignored write error
1986 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1987 && echo FAIL: ignored write error
1988 FAIL: ignored write error
1989 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1990
8eca8a7c
AS
19912011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1992
1993 * emacs.c (Fkill_emacs): In noninteractive mode exit
1994 non-successfully if a write error occurred on stdout. (Bug#9574)
1995
3341db62
EZ
19962011-09-21 Eli Zaretskii <eliz@gnu.org>
1997
1998 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1999 the xassert test.
2000
2001 * dispextern.h (struct it): Update the comment documenting what
2002 can it->OBJECT be.
2003
8c203dbf
EZ
20042011-09-20 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2007 a display string, extend search for cursor position to end of row.
2008 (find_row_edges): If the row ends in a newline from a display
2009 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2010 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2011 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2012 non-empty line. Fixes confusing cursor motion with arrow keys at
2013 the beginning of a line that starts with whitespace.
8c203dbf 2014
a4824228
LMI
20152011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2016
2017 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2018 (bug#9493).
2019
33ed493b
CY
20202011-09-18 Chong Yidong <cyd@stupidchicken.com>
2021
2022 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2023 boolean (Bug#9154).
2024
56cd55c8
EZ
20252011-09-18 Eli Zaretskii <eliz@gnu.org>
2026
2027 * xdisp.c (display_line): Record maximum and minimum buffer
2028 positions even if no glyphs were produced (e.g., by a zero-width
2029 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2030 buffer positions that will be removed from the glyph row because
2031 they don't fit.
c02dcedf
EZ
2032 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2033 column is beyond frame width: don't subtract 1 "pixel" when
2034 computing width of the stretch.
3e62b7e0
EZ
2035 (reseat_at_next_visible_line_start): Undo the change made on
2036 2011-09-17 that saved paragraph information and restored it after
2037 the call to `reseat'. (Bug#9545)
56cd55c8 2038
5ed99d36 20392011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2040
2041 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2042 and turn window cursor on if cleared (Bug#9415).
2043
5ed99d36 20442011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2045
2046 * search.c (boyer_moore): Take unibyte characters from pattern
2047 literally. (Bug#9458)
2048
9bade7b2
EZ
20492011-09-18 Eli Zaretskii <eliz@gnu.org>
2050
2051 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2052
e5e9d610
PE
20532011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2054
87e4427a
PE
2055 Fix minor problem found by static checking.
2056 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2057 initialized, to pacify gcc -Wuninitialized.
2058
e5e9d610
PE
2059 * fileio.c: Report proper errno when syscall falls.
2060 (Finsert_file_contents): Save and restore errno,
2061 so that report_file_error outputs the correct diagnostic.
2062 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2063
a1674f0b
EZ
20642011-09-18 Eli Zaretskii <eliz@gnu.org>
2065
2066 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2067
fbfb6dd4
EZ
20682011-09-17 Eli Zaretskii <eliz@gnu.org>
2069
2070 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2071 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2072
bb187662
EZ
20732011-09-17 Eli Zaretskii <eliz@gnu.org>
2074
1137e8b8 2075 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2076 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2077
2078 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2079 (bidi_find_paragraph_start): Search back for paragraph beginning
2080 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2081 (bidi_move_to_visually_next): Only trigger paragraph-related
2082 computations when the last character is a newline or at EOB, not
2083 just any NEUTRAL_B. (Bug#9470)
2084
bb187662
EZ
2085 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2086 truncated lines if point is covered by a display string. (Bug#9524)
2087
2e621251
PE
20882011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2091 (cons_to_x_long): New function.
2092 (lisp_data_to_selection_data): Use it. Correct the test for
2093 short-versus-long data; it was negated. Break out of vector
2094 loop, for efficiency, when a long datum is discovered.
2095
91a15bc6
SM
20962011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2097
2098 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2099
b41c3a35
EZ
21002011-09-16 Eli Zaretskii <eliz@gnu.org>
2101
2102 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2103 GCC PR/17406) by declaring this function with external scope.
2104
7812ba2d
PE
21052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2106
2107 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2108 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2109
cf7edc2a
AS
21102011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2111
2112 * editfns.c (Fformat): Correctly handle text properties on "%%".
2113
bd01620e
EZ
21142011-09-15 Eli Zaretskii <eliz@gnu.org>
2115
2116 * xterm.c (x_draw_composite_glyph_string_foreground):
2117 * w32term.c (x_draw_composite_glyph_string_foreground):
2118 * term.c (encode_terminal_code):
2119 * composite.c (composition_update_it, get_composition_id):
2120 * xdisp.c (get_next_display_element)
2121 (fill_composite_glyph_string): Add comments about special meaning
2122 of TAB characters in a composition.
2123
a02719a3
PE
21242011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2127 This occurs when processing a multibyte format.
2128 Problem reported by Wolfgang Jenker.
a02719a3 2129
72589a3c
JB
21302011-09-15 Johan Bockgård <bojohan@gnu.org>
2131
2132 * xdisp.c (try_cursor_movement): Only check for exact match if
2133 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2134
1c14176c
PE
21352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 Remove unused external symbols.
2138 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2139 * xdisp.c (calc_pixel_width_or_height): Now static.
2140 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2141 * indent.c (check_display_width):
2142 * w32term.c: Fix comment to match code.
2143 * xterm.c, xterm.h (x_catching_errors): Remove.
2144
d2eea5b5
PE
21452011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2146
2147 * xselect.c: Use signed conversions more consistently (Bug#9498).
2148 (selection_data_to_lisp_data): Assume incoming selection data are
2149 signed integers, not unsigned. This is to be consistent with
2150 outgoing selection data, which was modified to use signed integers
2151 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2152 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2153 expects long, not unsigned long.
2154
46888499
EZ
21552011-09-14 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2158 computation of loop end. Reported by Johan Bockgård
2159 <bojohan@gnu.org>.
2160
ef8ef9fb
CY
21612011-09-13 Chong Yidong <cyd@stupidchicken.com>
2162
2163 * frame.c (Fother_visible_frames_p): Function deleted.
2164
fa819fed
EZ
21652011-09-12 Eli Zaretskii <eliz@gnu.org>
2166
2167 * indent.c (compute_motion): Process display vector front to back
2168 rather than the other way around. (Bug#2496)
2169
2ba8e008
SM
21702011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2171
2172 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2173
20f53c69
CY
21742011-09-11 Chong Yidong <cyd@stupidchicken.com>
2175
2176 * minibuf.c (Fread_from_minibuffer): Doc fix.
2177
d562d7a4
EZ
21782011-09-11 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2181 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2182
1c4d7f3d
LMI
21832011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2184
2185 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2186 value for non-existent files.
2187
b885bf36
EZ
21882011-09-11 Eli Zaretskii <eliz@gnu.org>
2189
2190 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2191 set its "size" to -1. This will set the modtime_size field of
2192 the corresponding buffer to -1, which is what
2193 verify-visited-file-modtime expects for files that do not exist.
2194 (Bug#9139)
2195
6612f0bf
PE
21962011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2197
2198 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2199 here ...
2200 * lisp.h: ... from here. push_key_description is no longer
2201 defined in keyboard.c, so its declaration should not be in
2202 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2203 logically belongs with push_key_description.
2204
dfb3f755
PE
22052011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2206
2207 * buffer.h: Include <sys/types.h> instead of <time.h>.
2208 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2209 Problem reported by Herbert J. Skuhra.
2210
3134906c
LMI
22112011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2212
2213 * xml.c (parse_region): Make the parsing work for
2214 non-comment-starting XML files again (bug#9144).
2215
8d903f4e
AS
22162011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2217
2218 * image.c (gif_load): Fix calculation of bottom and right corner.
2219 (Bug#9468)
2220
80ad64f4
EZ
22212011-09-10 Eli Zaretskii <eliz@gnu.org>
2222
2223 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2224 redisplay in small windows.
2225
208a048d
EZ
22262011-09-09 Eli Zaretskii <eliz@gnu.org>
2227
2228 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2229
9b1c252e
MR
22302011-09-08 Martin Rudalics <rudalics@gmx.at>
2231
2232 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2233 Operate on live windows only.
2234
2949f33b
JB
22352011-09-08 Juanma Barranquero <lekktu@gmail.com>
2236
2237 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2238
e08dcafd
EZ
22392011-09-07 Eli Zaretskii <eliz@gnu.org>
2240
2241 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2242 only under bidi iteration.
2243
115b96bd
JD
22442011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2245
2246 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2247
c8199d0f
PE
22482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2249
2250 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2251 Without this fix, the command to link temacs failed due to an
2252 undefined symbol __builtin_isnan. This is because
2253 /usr/include/iso/math_c99.h #defines isnan(x) to
2254 __builtin_isnan(x), but the bundled gcc, which identifies itself
2255 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2256 a __builtin_isnan.
2257 * floatfns.c (isnan): #undef, and then #define to a clone of
2258 what's in data.c.
2259 (Fisnan): Always define, since it's always available now.
2260 (syms_of_floatfns): Always define isnan at the Lisp level.
2261
e39b275c 22622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2263
2264 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2265
b2db44d9 22662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2267
f4af5137 2268 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2269 The previous code assumed that file offsets (off_t values) fit in
2270 EMACS_INT variables, which is not true on typical 32-bit hosts.
2271 The code messed up by falsely reporting buffer overflow in cases
2272 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2273 when "big" contains more than 2**29 bytes, even though this
2274 inserts just one byte and does not overflow the buffer.
2275 (Finsert_file_contents): Store file offsets as off_t
2276 values, not as EMACS_INT values. Check for overflow when
2277 converting between EMACS_INT and off_t. When checking for
2278 buffer overflow or for overlap, take the offsets into account.
2279 Don't use EMACS_INT for small values where int suffices.
2280 When checking for overlap, fix a typo: ZV was used where
2281 ZV_BYTE was intended.
2282 (Fwrite_region): Don't assume off_t fits into 'long'.
2283 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2284
ecfc0a49
MA
22852011-09-05 Michael Albinus <michael.albinus@gmx.de>
2286
2287 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2288
6511acf2 22892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2290
0999621a 2291 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2292
2293 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2294 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2295 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2296 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2297 (modify_event_symbol): Do not assume that the length of
2298 name_alist_or_stem is safe to alloca and fits in int.
2299 (Fexecute_extended_command): Likewise for function name and binding.
2300 (Frecursion_depth): Wrap around reliably on integer overflow.
2301 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2302 since some callers pass EMACS_INT values.
2303 (Fsingle_key_description): Don't crash if symbol name contains more
2304 than MAX_ALLOCA bytes.
2305 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2306 (get_minibuffer): Arg is now EMACS_INT, not int.
2307 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2308 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2309 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2310
2be7d702
PE
2311 * dbusbind.c (signature_cat): New function.
2312 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2313 Do not overrun buffer; instead, report string overflow.
2314
9d1df220
PE
2315 * dispnew.c (add_window_display_history): Don't overrun buffer.
2316 Truncate instead; this is OK since it's just a log.
2317
33ef5c64
PE
2318 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2319 even if the time zone offset is outlandishly large.
2320 Don't mishandle offset == INT_MIN.
2321
66c6fdd5
PE
2322 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2323 when creating daemon; the previous buffer-overflow check was incorrect.
2324
d749b01b
PE
2325 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2326 which has the guts of the old verror function.
2327
b5cd1905
PE
2328 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2329 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2330
6e1a67fb
PE
2331 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2332 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2333 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2334 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2335 length of string rather than counting it via multiple sprintfs;
2336 that's simpler and more reliable.
c21721cc
PE
2337 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2338 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2339 sprintf, in case result does not fit in int.
2340
c57b67fc
PE
2341 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2342 (fontset_from_font): Print it.
2343
8a401434
PE
2344 * frame.c (tty_frame_count): Now printmax_t, not int.
2345 (make_terminal_frame, set_term_frame_name): Print it.
2346 (x_report_frame_params): In X, window IDs are unsigned long,
2347 not signed long, so print them as unsigned.
2348 (validate_x_resource_name): Check for implausibly long names,
2349 and don't assume name length fits in 'int'.
2350 (x_get_resource_string): Don't blindly alloca invocation name;
2351 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2352 not fit in int.
2353
6e1a67fb
PE
2354 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2355 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2356 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2357
0df02bf3
PE
2358 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2359 Use esprintf, not sprintf, in case result does not fit in int.
2360
48e30793
PE
2361 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2362 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2363 it as a large positive number.
2364 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2365 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2366
a66ff6d8
PE
2367 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2368 in case result does not fit in int.
2369
aca216ff
PE
2370 * print.c (float_to_string): Detect width overflow more reliably.
2371 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2372 buffer overrun. Don't assume list length fits in 'int'. Treat
2373 print length of 0 as 0, not as infinity; to be consistent with other
2374 uses of print length in this function. Don't overflow print length
2375 index. Don't assume hash table size fits in 'long', or that
2376 vectorlike size fits in 'unsigned long'.
2377
31c286f7
PE
2378 * process.c (make_process): Use printmax_t, not int, to format
2379 process-name gensyms.
2380
55e5faa1
PE
2381 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2382
80f2e268
PE
2383 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2384 to avoid potential buffer overrun.
2385
670741ab
PE
2386 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2387 if X resource line is longer than 512 bytes.
2388
b7163a50
PE
2389 * xfns.c (x_window): Make sprintf buffer a bit bigger
2390 to avoid potential buffer overrun.
2391
ae58ff1f
PE
2392 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2393
c43c8a6a
PE
2394 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2395
3f8236f4
PE
23962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2397
53e9fe90 2398 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2399 Without these, Emacs silently mishandles large integers sometimes.
2400 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2401 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2402
6511acf2
PE
2403 * xdisp.c (try_window_id): Check Emacs fixnum range before
2404 converting to 'int'.
806add1d 2405
6511acf2 2406 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2407 Check that an Emacs fixnum is in range before assigning it to 'int'.
2408 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2409 values converted from Emacs fixnums.
2410 (Frecenter): Don't wrap around a line count if it is out of 'int'
2411 range; instead, treat it as an extreme value.
2412 (Fset_window_configuration, compare_window_configurations):
2413 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2414
6511acf2
PE
2415 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2416 that can exceed INT_MAX. Check that EMACS_INT value is in range
2417 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2418 (match_limit): Don't assume that a fixnum can fit in 'int'.
2419
6511acf2 2420 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2421 exceed INT_MAX.
2422
6511acf2 2423 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2424 (Fvertical_motion): Don't wrap around LINES values that don't fit
2425 in 'int'. Instead, treat them as extreme values. This is good
2426 enough for windows, which can't have more than INT_MAX lines anyway.
2427
fcb901a7
LMI
24282011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2429
0f2f6b6d
LMI
2430 * Require libxml/parser.h to avoid compilation warning.
2431
fcb901a7
LMI
2432 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2433
2434 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2435 since this reportedly can destroy thread storage.
2436
6e20a0d4
CY
24372011-08-30 Chong Yidong <cyd@stupidchicken.com>
2438
2439 * syntax.c (find_defun_start): Update all cache variables if
2440 exiting early (Bug#9401).
2441
148ae00e
EZ
24422011-08-30 Eli Zaretskii <eliz@gnu.org>
2443
f6cfbd8f
EZ
2444 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2445
148ae00e
EZ
2446 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2447 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2448 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2449
2450 * term.c (tty_append_glyph): New function.
2451 (produce_stretch_glyph): Static function and its prototype deleted.
2452
a66cfb1c
SM
2453 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2454 Add prototypes.
148ae00e 2455
c4a07a4c
PE
24562011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2457
2458 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2459 when checking :margin (Bug#9390).
2460 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2461 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2462 so that the name doesn't mislead. All uses changed.
2463
6bc8cd65
JB
24642011-08-28 Johan Bockgård <bojohan@gnu.org>
2465
2466 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2467 set_tty_hooks.
2468
dca4927e
EZ
24692011-08-27 Eli Zaretskii <eliz@gnu.org>
2470
2471 * xdisp.c (move_it_to): Don't bail out early when reaching
2472 position beyond to_charpos, if we are scanning backwards.
2473 (move_it_vertically_backward): When DY == 0, make sure we get to
2474 the first character in the line after the newline.
2475
f2cad773
PE
24762011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2477
2478 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2479 (ccl_driver): Do not generate an out-of-range pointer.
2480 (Fccl_execute_on_string): Remove unnecessary check for
2481 integer overflow, noted by Stefan Monnier in
2482 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2483 Remove a FIXME that didn't need fixing.
2484 Simplify the newly-introduced buffer reallocation code.
2485
0cae2cdb
JB
24862011-08-27 Juanma Barranquero <lekktu@gmail.com>
2487
2488 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2489
5fc295a4 24902011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2491
70c60eb2 2492 Integer and memory overflow issues (Bug#9196).
726e0ab1 2493
d31850da
PE
2494 * doc.c (get_doc_string): Rework so that
2495 get_doc_string_buffer_size is the actual buffer size, rather than
2496 being 1 less than the actual buffer size; this makes xpalloc more
2497 convenient.
2498
a69fbedb
PE
2499 * image.c (x_allocate_bitmap_record, cache_image):
2500 * xselect.c (Fx_register_dnd_atom):
2501 Simplify previous changes by using xpalloc.
2502
fe5c5d37
PE
2503 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2504 since either will do and ptrdiff_t is convenient with xpalloc.
2505
0065d054
PE
2506 * charset.c (charset_table_size)
2507 (struct charset_sort_data.priority): Now ptrdiff_t.
2508 (charset_compare): Don't overflow if priorities differ greatly.
2509 (Fsort_charsets): Don't assume list length fits in int.
2510 Check for size-calculation overflow when allocating sort data.
2511 (syms_of_charset): Allocate an initial charset table that is
2512 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2513
2514 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2515
2516 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2517 The actual value is always <= INT_MAX, and leaving it unsigned made
2518 overflow checking harder.
2519
2520 * dispextern.h (struct glyph_matrix.rows_allocated)
2521 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2522 with xpalloc. The values are still always <= INT_MAX.
2523
2524 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2525
2526 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2527 (SAFE_NALLOCA): New macro.
2528
2529 * region-cache.c (struct boundary.pos, find_cache_boundary)
2530 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2531 (set_cache_region, invalidate_region_cache)
2532 (revalidate_region_cache, know_region_cache, region_cache_forward)
2533 (region_cache_backward, pp_cache):
2534 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2535 so that ptrdiff_t * can be passed to xpalloc.
2536 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2537 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2538 (pp_cache): Don't assume cache_len fits in int.
2539 * region-cache.h: Adjust extern decls to match.
2540
2541 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2542 EMACS_INT, since either will do, for xpalloc.
2543
2544 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2545 (xnmalloc, xnrealloc, xpalloc): New functions.
2546
726e0ab1
PE
2547 * bidi.c (bidi_shelve_header_size): New constant.
2548 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2549 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2550
51f30bc5 2551 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2552 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2553 (overlay_strings):
2554 Don't update size of array until after memory allocation succeeds,
2555 because xmalloc/xrealloc may not return.
0065d054
PE
2556 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2557 now that we have proper integer overflow checking.
2558 (record_overlay_string, overlay_strings): Catch overflows when
2559 calculating size of overlay_str_buf.
726e0ab1 2560
0065d054
PE
2561 * callproc.c (Fcall_process): Check for size overflow when
2562 calculating size of args2.
2563 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2564 Normally we prefer signed values, but sticking with ptrdiff_t would
2565 require adding more-complicated checks.
726e0ab1
PE
2566
2567 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2568 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2569 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2570 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2571
2572 * character.c (Fstring): Check for size-calculation overflow.
2573
2574 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2575 unnecessary integer overflow. Check for size overflow.
2576 (encode_coding_object): Don't update size until xmalloc succeeds.
2577
2578 * composite.c (get_composition_id): Check for overflow in glyph
2579 length calculations.
2580
2581 Integer and memory overflow fixes for display code.
2582 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2583 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2584 (scrolling_window): Check for overflow in size calculations.
2585 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2586 Don't assume glyph table len fits in int.
2587 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2588 (row_table_size): Now ptrdiff_t, not int.
2589 (scrolling_window): Avoid overflow in size calculations.
2590 Don't update size until allocation succeeds.
2591 * fns.c (concat): Check for overflow in size calculations.
2592 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2593 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2594 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2595
2596 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2597 (get_doc_string): Check for size calculation overflow.
2598 Don't update size until allocation succeeds.
2599 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2600 EMACS_INT, where ptrdiff_t will do.
2601 (Fsubstitute_command_keys): Check for string overflow.
2602
2603 * editfns.c (set_time_zone_rule): Don't assume environment length
2604 fits in int.
2605 (message_length): Now ptrdiff_t, not int.
2606 (Fmessage_box): Don't update size until allocation succeeds.
2607 Don't assume message length fits in int.
2608 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2609
0065d054
PE
2610 * emacs.c (main): Do not reallocate argv, since there is a null at
2611 the end that can be overwritten, and this way there's no need to
2612 worry about size-calculation overflow.
2613 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2614
2615 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2616 alloc succeeds.
2617 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2618
2619 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2620 (x_set_scroll_bar_width, x_figure_window_size):
2621 Check for integer overflow.
2622 (x_set_alpha): Do not assume XINT fits in int.
2623
2624 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2625 This is for the members text_lines, text_cols, total_lines, total_cols,
2626 where the system imposes an 'int' limit.
2627
2628 * fringe.c (Fdefine_fringe_bitmap):
2629 Don't update size until alloc works.
2630
2631 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2632 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2633
2634 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2635 Check for size-calculation overflow.
2636 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2637 do, as we prefer signed integers.
2638 (id_to_widget.max_size, id_to_widget.used)
2639 (xg_store_widget_in_map, xg_remove_widget_from_map)
2640 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2641 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2642 Use and return ptrdiff_t, not int.
2643 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2644 * gtkutil.h: Change prototypes to match the above.
2645
2646 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2647 are duplicate now that they've been promoted to lisp.h.
2648 (x_allocate_bitmap_record, x_alloc_image_color)
2649 (make_image_cache, cache_image, xpm_load):
2650 Don't update size until alloc is done.
2651 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2652 (x_detect_edges):
3256efce 2653 Check for size calculation overflow.
726e0ab1
PE
2654 (ct_colors_allocated_max): New constant.
2655 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2656 overflow.
3256efce 2657
726e0ab1
PE
2658 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2659 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2660 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2661 Use ptrdiff_t, not int, to count maps.
2662 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2663 calculations. Don't update size until allocation succeeds.
2664 Redo calculations to avoid overflow.
726e0ab1
PE
2665 * keyboard.h: Change prototypes to match the above.
2666
2667 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2668 to count maps.
2669 (current_minor_maps): Check for size calculation overflow.
2670 * keymap.h: Change prototypes to match the above.
2671
2672 * lread.c (read1, init_obarray): Don't update size until alloc done.
2673
2674 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2675 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2676
726e0ab1
PE
2677 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2678 Now ptrdiff_t, not int.
2679 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2680 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2681
2682 * process.c (Fnetwork_interface_list): Check for overflow
2683 in size calculation.
2684
2685 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2686
2687 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2688 overflow. Don't bother calling xmalloc when xrealloc will do.
2689
2690 * search.c (Freplace_match): Check for size calculation overflow.
2691 (Fset_match_data): Don't assume list lengths fit in 'int'.
2692
2693 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2694 for command line length. Do not attempt to address one before the
2695 beginning of an array, as that's not portable.
2696
2697 * term.c (max_frame_lines): Remove; unused.
2698 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2699 not int.
2700 (encode_terminal_code, calculate_costs): Check for size
2701 calculation overflow.
2702 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2703 table lengths and related sizes. Don't update size until alloc
2704 done. Redo calculations to avoid overflow.
2705 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2706
2707 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2708 subtracting pointers.
2709 (gobble_line): Check for overflow more carefully. Don't update size
2710 until alloc done.
2711
2712 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2713 Don't update size until alloc done.
2714 Redo size calculations to avoid overflow.
2715 Check for size calculation overflow.
0065d054 2716 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2717
2718 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2719 Use ptrdiff_t, not int, for sizes.
2720 (store_mode_line_noprop_char): Don't update size until alloc done.
2721
0065d054
PE
2722 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2723 Use ptrdiff_t, not int, for sizes.
2724 (Finternal_make_lisp_face, cache_face):
2725 Check for size calculation overflow.
2726 (cache_face): Treat size calculation overflows as if they were
2727 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2728
2729 * xfns.c (x_encode_text, x_set_name_internal)
2730 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2731 sizes, since they can exceed INT_MAX in size. Check for size
2732 calculation overflow.
2733
0065d054
PE
2734 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2735 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2736 Don't update size until alloc done.
2737
0065d054 2738 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2739 as sprintf is limited to int lengths.
1d526e2f 2740
252c5ee1
PE
2741 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2742 (X_LONG_MIN): New macros.
864d7ce7
PE
2743 Use them to make the following changes clearer.
2744 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2745 This change doesn't affect the value now, but it may help remind
2746 future maintainers not to raise the value too much later.
2747 (SELECTION_QUANTUM): Remove, replacing with ...
2748 (selection_quantum): ... new function, which avoids overflow.
2749 All uses changed.
2750 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2751 assumption that selection length fits in 'int'.
2752 (x_reply_selection_request, x_handle_selection_request)
2753 (x_get_window_property, receive_incremental_selection)
2754 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2755 (lisp_data_to_selection_data, clean_local_selection_data):
2756 Use ptrdiff_t, not int, to record length of selection.
2757 (x_reply_selection_request, x_get_window_property)
2758 (receive_incremental_selection, x_property_data_to_lisp):
2759 Redo calculations to avoid overflow.
2760 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2761 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2762 something.
2763 (x_get_window_property, receive_incremental_selection)
2764 (lisp_data_to_selection_data, x_property_data_to_lisp):
2765 Check for size-calculation overflow.
2766 (x_get_window_property, receive_incremental_selection)
2767 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2768 Don't store size until memory allocation succeeds.
2769 (x_get_window_property): Plug memory leak on memory exhaustion.
2770 Don't double-block input; malloc is safe here. Don't assume 2**34
2771 - 4 fits in unsigned long. Add an xassert to check
2772 XGetWindowProperty overflow. Be more careful about overflow
2773 calculations, and distinguish size from memory overflow better.
2774 (receive_incremental_selection): When tracing, don't assume
2775 unsigned int is less than INT_MAX.
2776 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2777 harmful) conversions of unsigned short to int.
2778 (lisp_data_to_selection_data): Don't assume that integers
2779 in the range -65535 through -1 fit in an X unsigned short.
2780 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2781 result parameters unless successful. Rely on cons_to_unsigned
2782 to report problems with elements; the old code wasn't right anyway.
2783 (x_check_property_data): Check for int overflow; we cannot use
2784 a wider type due to X limits.
2785 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2786
726e0ab1 2787 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2788
0065d054
PE
2789 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2790 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2791 (x_color_cells): Don't store size until memory allocation succeeds.
2792 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2793 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2794 (x_term_init): Don't assume length fits in int (sprintf is limited
2795 to int size).
bc18e09d 2796
ebfa62c0
PE
2797 Use ptrdiff_t for composition IDs.
2798 * character.c (lisp_string_width):
2799 * composite.c (composition_table_size, n_compositions)
2800 (get_composition_id, composition_gstring_from_id):
2801 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2802 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2803 * window.c (Frecenter):
2804 Use ptrdiff_t, not int, for composition IDs.
2805 * composite.c (get_composition_id): Check for integer overflow.
2806 * composite.h: Adjust prototypes to match the above changes.
2807
d3411f89
PE
2808 Use ptrdiff_t for hash table indexes.
2809 * category.c (hash_get_category_set):
2810 * ccl.c (ccl_driver):
2811 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2812 * coding.c (coding_system_charset_list, detect_coding_system):
2813 * coding.h (struct coding_system.id):
2814 * composite.c (get_composition_id, gstring_lookup_cache):
2815 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2816 * image.c (xpm_get_color_table_h):
2817 * lisp.h (hash_lookup, hash_put):
2818 * minibuf.c (Ftest_completion):
2819 Use ptrdiff_t for hash table indexes, not int (which is too
2820 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2821 32-bit --with-wide-int hosts).
2822
e097a6fa
PE
2823 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2824 Add a FIXME comment about memory leaks.
2825 (syms_of_charset): Don't assume xmalloc returns.
2826
5637687f
PE
2827 Don't assume that stated character widths fit in int.
2828 * character.c (Fchar_width, c_string_width, lisp_string_width):
2829 * character.h (CHAR_WIDTH):
2830 * indent.c (MULTIBYTE_BYTES_WIDTH):
2831 Use sanitize_char_width to avoid undefined and/or bad behavior
2832 with outlandish widths.
a66cfb1c 2833 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2834 now that we have two such functions. All uses changed.
2835 (sanitize_char_width): New inline function.
2836
a2271ba2
PE
2837 Don't assume that tab-width fits in int.
2838 * character.h (sanitize_width): New inline function.
2839 (SANE_TAB_WIDTH): New macro.
2840 (ASCII_CHAR_WIDTH): Use it.
2841 * indent.c (sane_tab_width): Remove. All uses replaced by
2842 SANE_TAB_WIDTH (current_buffer).
2843 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2844
18c52557
PE
2845 * fileio.c: Integer overflow issues with file modes.
2846 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2847
caeeedc1
PE
2848 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2849 Remove unreachable code.
2850 (read_hex, load_charset_map_from_file): Check for integer overflow.
2851
6df6ae42 2852 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2853 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2854 (x_send_scroll_bar_event): Likewise. Check that the size does not
2855 exceed limits imposed by XClientMessageEvent, as well as the usual
2856 ptrdiff_t and size_t limits.
2857
b13995db
PE
2858 * keyboard.c: Overflow, signedness and related fixes.
2859 (make_lispy_movement): Use same integer type in forward decl
2860 that is used in the definition.
2861 (read_key_sequence, keyremap_step):
2862 Change bufsize argument back to int, undoing my 2011-03-30 change.
2863 We prefer signed types, and int is wide enough here.
2864 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2865 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2866 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2867 length, not size_t. Use ptrdiff_t for index, not int.
2868 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2869 possibility of integer overflow.
2870
13464394
PE
2871 Overflow, signedness and related fixes for images.
2872
2873 * dispextern.h (struct it.stack[0].u.image.image_id)
2874 (struct_it.image_id, struct image.id, struct image_cache.size)
2875 (struct image_cache.used, struct image_cache.ref_count):
2876 * gtkutil.c (update_frame_tool_bar):
2877 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2878 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2879 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2880 * nsmenu.m (update_frame_tool_bar):
2881 * xdisp.c (calc_pixel_width_or_height):
2882 * xfns.c (image_cache_refcount):
2883 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2884 on typical 64-bit hosts.
2885
2886 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2887 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2888 Omit unnecessary casts to int.
2889 (parse_image_spec): Check that integers fall into 'int' range
2890 when the callers expect that.
2891 (image_ascent): Redo ascent calculation to avoid int overflow.
2892 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2893 (lookup_image): Remove unnecessary tests.
2894 (xbm_image_p): Locals are now of int, not EMACS_INT,
2895 since parse_image_check makes sure they fit into int.
2896 (png_load, gif_load, svg_load_image):
2897 Prefer int to unsigned where either will do.
2898 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2899 old tiff_error_handler and tiff_warning_handler.
2900 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2901 stack buffer overflows. It uses only the features of vsnprintf
2902 that are common to both POSIX and native Microsoft.
2903 (tiff_error_handler, tiff_warning_handler): Use it.
2904 (tiff_load, gif_load, imagemagick_load_image):
2905 Don't assume :index value fits in 'int'.
2906 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2907 (imagemagick_load_image): Check that crop parameters fit into
2908 the integer types that MagickCropImage accepts. Don't assume
2909 Vimagemagick_render_type has a nonnegative value. Don't assume
2910 size_t fits in 'long'.
2911 (gs_load): Use printmax_t to print the widest integers possible.
2912 Check for integer overflow when computing image height and width.
2913
c11821d4
EZ
29142011-08-26 Eli Zaretskii <eliz@gnu.org>
2915
2916 * xdisp.c (redisplay_window): Don't force window start if point
2917 will be invisible in the resulting window. (Bug#9324)
2918
0c95fcf7
EZ
29192011-08-25 Eli Zaretskii <eliz@gnu.org>
2920
2921 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2922 the display spec is of the form `(space ...)'.
2923 (handle_display_spec): Return the value returned by
2924 handle_single_display_spec, not just 1 or zero.
2925 (handle_single_display_spec): If the display spec is of the form
2926 `(space ...)', and specifies display in the text area, return 2
2927 rather than 1.
fee65a97 2928 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2929 accurately, and prefer exact match for point under bidi.
2930 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2931
2932 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2933 into disp_prop; all users changed.
2934
2935 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2936 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2937 for the text covered by the display property.
2938
e4ed06f1
CY
29392011-08-25 Chong Yidong <cyd@stupidchicken.com>
2940
2941 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2942 Change return value to nil.
2943 (Frecord_buffer): Delete unused function.
2944
f67cdd7f
EZ
29452011-08-24 Eli Zaretskii <eliz@gnu.org>
2946
5980d4c6
EZ
2947 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2948 buffers, return left-to-right.
8610fe8b
EZ
2949 (set_cursor_from_row): Consider candidate row a win if its glyph
2950 represents a newline and point is on that newline. Fixes cursor
2951 positioning on the newline at EOL of R2L text within L2R
2952 paragraph, and vice versa.
2953 (try_cursor_movement): Check continued rows, in addition to
2954 continuation rows. Fixes unwarranted scroll when point enters a
2955 continued line of R2L text within an L2R paragraph, or vice versa.
2956 (cursor_row_p): Consider the case of point being equal to
2957 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2958 from the end of a short line to the beginning of a continued line
2959 of R2L text within L2R paragraph.
2960 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2961 composed characters.
5980d4c6 2962
f67cdd7f
EZ
2963 * bidi.c (bidi_check_type): Use xassert.
2964 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2965 members.
2966
bca633fb
EZ
29672011-08-23 Eli Zaretskii <eliz@gnu.org>
2968
2969 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2970 a character.
2971
4a5885a7
CY
29722011-08-23 Chong Yidong <cyd@stupidchicken.com>
2973
2974 * nsfont.m (ns_otf_to_script): Fix typo.
2975
0902a04e
KH
29762011-08-22 Kenichi Handa <handa@m17n.org>
2977
2978 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2979 extra slot even if the purpose is char-code-property-table.
2980
1a2e6670
EZ
29812011-08-23 Eli Zaretskii <eliz@gnu.org>
2982
8ddde651
EZ
2983 * xdisp.c (redisplay_window): When computing centering_position,
2984 account for the height of the header line. (Bug#8874)
2985
425cc014
EZ
2986 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2987 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2988 candidate is selected by the mouse, and that candidate has a
2989 composed character under the mouse.
2990
1a2e6670
EZ
2991 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2992 coordinates reported by pos-visible-in-window-p for a composed
2993 character in column zero.
2994
8b76d6f8
SM
29952011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2996
2997 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2998
dac347dd
EZ
29992011-08-22 Eli Zaretskii <eliz@gnu.org>
3000
3001 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3002 consider it a hit if to_charpos is anywhere in the range of the
3003 composed buffer positions.
3004
e013fb34
CY
30052011-08-22 Chong Yidong <cyd@stupidchicken.com>
3006
3007 * image.c (gif_load): Don't assume that each subimage has the same
3008 dimensions as the base image. Handle disposal method that is
3009 "undefined" by the gif spec (Bug#9335).
3010
bd1ba3e8
CY
30112011-08-20 Chong Yidong <cyd@stupidchicken.com>
3012
3013 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3014 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3015
54a1215b
EZ
30162011-08-19 Eli Zaretskii <eliz@gnu.org>
3017
823564e5
EZ
3018 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3019 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3020 from an Org mode buffer to a Speedbar frame.
3021
54a1215b
EZ
3022 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3023 a composition, take its buffer position from IT->cmp_it.charpos.
3024 Fixes cursor positioning at the beginning of a line that begins
3025 with a composed character.
3026
9778ebcc
EZ
30272011-08-18 Eli Zaretskii <eliz@gnu.org>
3028
0be6ee06
EZ
3029 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3030 character bidirectional type, use STRONG_L instead. Fixes crashes
3031 in a buffer produced by `describe-categories'.
3032
9778ebcc
EZ
3033 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3034 members before the level stack, so they would be saved and
3035 restored when copying iterator state. Fixes incorrect reordering
3036 around TABs covered by display properties.
3037
156bffbe
AS
30382011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3039
6b02f655 3040 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3041
72ad093b
CY
30422011-08-17 Chong Yidong <cyd@stupidchicken.com>
3043
3044 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3045 (internal_condition_case_2, internal_condition_case_n):
3046 Remove unnecessary aborts (Bug#9081).
72ad093b 3047
35774242
EZ
30482011-08-17 Eli Zaretskii <eliz@gnu.org>
3049
3050 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3051 has no `load' handler, try opening the file locally. (Bug#9311)
3052
db76dd85
KB
30532011-08-16 Ken Brown <kbrown@cornell.edu>
3054
3055 * gmalloc.c: Expand comment.
3056
b215eee5
EZ
30572011-08-16 Eli Zaretskii <eliz@gnu.org>
3058
3059 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3060 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3061
a4579d33
KB
30622011-08-16 Ken Brown <kbrown@cornell.edu>
3063
3064 Fix memory allocation problems in Cygwin build (Bug#9273).
3065
3066 * unexcw.c ( __malloc_initialized): Declare external variable.
3067 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3068
8b76d6f8
SM
3069 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3070 New variables.
a4579d33
KB
3071 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3072 dumped emacs.
3073 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3074 in the static heap.
3075 [CYGWIN] (special_realloc): New function.
3076 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3077 requests to realloc storage in the static heap.
3078
3ebec551
PE
30792011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3080
3081 * bidi.c (bidi_initialize): Remove unused local.
3082
9fd8be00
EZ
30832011-08-15 Eli Zaretskii <eliz@gnu.org>
3084
6b02f655
SM
3085 * bidimirror.h:
3086 * biditype.h: Remove file.
3087 * makefile.w32-in ($(BLD)/bidi.$(O)):
3088 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3089
3090 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3091
3092 * chartab.c: Improve commentary for the uniprop_table API.
3093
32413314
EZ
3094 * bidi.c (bidi_paragraph_init): Support zero value of
3095 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3096 (bidi_initialize): Use uniprop_table instead of including
3097 biditype.h and bidimirror.h.
32413314 3098
9fd8be00
EZ
3099 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3100 coordinates of the iterator when restoring from ppos_it.
3101 (Bug#9296)
3102
5cf2b69b
KH
31032011-08-14 Kenichi Handa <handa@m17n.org>
3104
3105 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3106 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3107
daf17d00
EZ
31082011-08-14 Eli Zaretskii <eliz@gnu.org>
3109
3110 * xdisp.c (move_it_in_display_line_to): Don't invoke
3111 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3112 ppos_it. Fixes vertical cursor motion when line beginning is
3113 covered by an image. (Bug#9296)
3114
08e3161a
JD
31152011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3116
3117 * nsterm.h (ns_run_ascript): Declare.
3118 (NSAPP_DATA2_RUNASSCRIPT): Define.
3119
3120 * nsfns.m (as_script, as_result, as_status): New static variables.
3121 (ns_run_ascript): New function.
5e617bc2 3122 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3123 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3124 the event loop. Get status from as_status (Bug#7276).
3125
3126 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3127 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3128 the event loop (Bug#7276).
3129
a3720aa2
AS
31302011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3131
3132 * gnutls.c (QCgnutls_bootprop_priority)
3133 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3134 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3135 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3136 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3137 (QCgnutls_bootprop_verify_hostname_error)
3138 (QCgnutls_bootprop_callbacks_verify): Rename from
3139 Qgnutls_bootprop_..., all uses changed.
3140
3141 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3142 uses changed.
3143
0a0d27fb
PE
31442011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3145
19d5c50c
PE
3146 * xfaces.c (Qframe_set_background_mode): Now static.
3147 * dispextern.h (Qframe_set_background_mode): Remove decl.
3148
0a0d27fb
PE
3149 * process.c (Fnetwork_interface_info): Declare local only if needed.
3150
377538cb
JD
31512011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3152
3153 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3154 (Fnetwork_interface_list): Allocate in increments of bytes instead
3155 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3156 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3157 sockaddr.
3158 (struct ifflag_def): notrailers is smart on OSX.
3159 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3160 Get hardware address with getifaddrs if available.
3161
08fff70c
EZ
31622011-08-12 Eli Zaretskii <eliz@gnu.org>
3163
3164 * xdisp.c (iterate_out_of_display_property): xassert that
3165 IT->position is set to within IT->object's boundaries. Break from
3166 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3167 when IT->position is set up wrongly due to some bug.
3168 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3169 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3170 entry. Force push_it to save on the stack the current
3171 buffer/string position, to be restored by pop_it. Fix flags in
3172 the iterator structure wrt the object coming from a display
3173 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3174 properties. (Bug#9284)
3175
7be1c708 31762011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3177
7be1c708
CY
3178 * fontset.c (fontset_get_font_group): Add proper type checks.
3179 (Bug#9172)
aac0c6e3 3180
7be1c708 31812011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3182
7be1c708
CY
3183 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3184 and LC_VERSION_MIN_MACOSX.
3185 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3186 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3187
97bb72a6
EZ
31882011-08-08 Eli Zaretskii <eliz@gnu.org>
3189
3190 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3191 no-display-properties-and-no-overlays under bidi display.
3192 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3193 properties and overlays.
97bb72a6 3194
d5617611
CY
31952011-08-08 Chong Yidong <cyd@stupidchicken.com>
3196
37e11a63
CY
3197 * editfns.c (Fset_time_zone_rule): Document relationship with the
3198 setenv function.
3199
d5617611
CY
3200 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3201 the font entity extracted from the cache (Bug#8109).
3202
58872834
CY
32032011-08-07 Chong Yidong <cyd@stupidchicken.com>
3204
3205 * composite.c (autocmp_chars): Don't reset point. That is done by
3206 restore_point_unwind (Bug#5984).
3207
75bfc667
JL
32082011-08-07 Juri Linkov <juri@jurta.org>
3209
3210 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3211 to show the arg `TIME' instead of `TIMEVAL'.
3212
d1410150
EZ
32132011-08-06 Eli Zaretskii <eliz@gnu.org>
3214
3215 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3216 display property strides EOL and includes a newline, as in
3217 longlines-mode. (Bug#9254)
75b771e4
EZ
3218 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3219 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3220
3221 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3222 is non-zero, even if the data buffer is NULL. Fixes a crash in
3223 vertical-motion with longlines-mode. (Bug#9254)
3224
35928349
EZ
32252011-08-05 Eli Zaretskii <eliz@gnu.org>
3226
ec7cc85b
EZ
3227 * bidi.c <bidi_cache_total_alloc>: Now static.
3228 (bidi_initialize): Initialize bidi_cache_total_alloc.
3229
8b76d6f8 3230 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3231 cache. (Bug#9221)
3232
3233 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3234 amount allocated this far in `bidi_cache_total_alloc'.
3235 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3236 non-zero, only free the data buffer without restoring the cache
3237 contents. All callers changed.
3238
3239 * dispextern.h (bidi_unshelve_cache): Update prototype.
3240
3241 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3242 (move_it_in_display_line, move_it_to)
3243 (move_it_vertically_backward, move_it_by_lines): Replace the call
3244 to xfree to an equivalent call to bidi_unshelve_cache.
3245 (move_it_in_display_line_to): Fix logic of returning
412b6358 3246 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3247
e2e2423b
EZ
32482011-08-05 Eli Zaretskii <eliz@gnu.org>
3249
3250 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3251 came from a string character with a `cursor' property. (Bug#9229)
3252
ae9e757a
JD
32532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3254
3255 * Makefile.in (LIB_PTHREAD): New variable.
3256 (LIBES): Add LIB_PTHREAD (Bug#9216).
3257
3258 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3259 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3260
213bd7f2
AS
32612011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3262
6b02f655 3263 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3264
99aaf75f
JD
32652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3266
3267 * xterm.c (x_find_topmost_parent): New function.
3268 (x_set_frame_alpha): Find topmost parent window with
3269 x_find_topmost_parent and set the property there also (bug#9181).
3270 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3271
c74e9d86
PE
32722011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 * callproc.c (Fcall_process): Avoid vfork clobbering
3275 the local vars buffer, coding_systems, current_dir.
3276
640c8776
SM
32772011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3278
3279 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3280
f26d0e4c
PE
32812011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3282
8a10d76c
PE
3283 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3284 so that it is not optimized away.
3285
f26d0e4c
PE
3286 * xdisp.c (compute_display_string_pos): Remove unused local.
3287
55439c61
EZ
32882011-08-02 Eli Zaretskii <eliz@gnu.org>
3289
3290 Fix slow cursor motion and scrolling in large buffers with
3291 selective display, like Org Mode buffers. (Bug#9218)
3292
3293 * dispextern.h (struct bidi_it): New member disp_prop_p.
3294
3295 * xdisp.c: Remove one-slot cache of display string positions.
3296 (compute_display_string_pos): Accept an additional argument
5e617bc2 3297 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3298 for a display string or property. If found, set DISP_PROP_P
3299 non-zero.
3300
3301 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3302 DISP_PROP_P, and pass it to compute_display_string_pos.
3303 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3304 non-zero. All callers of bidi_fetch_char changed.
3305
fb33fa43
SM
33062011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3307
3308 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3309
b099e063
DM
33102010-12-03 Don March <don@ohspite.net>
3311
3312 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3313 last character M-[char] is translated to ESC [char] (bug#7541).
3314
5cc7f7af
KH
33152011-08-02 Kenichi Handa <handa@m17n.org>
3316
d0fffa3f 3317 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3318
3319 * chartab.c (uniprop_table): Make it non-static.
3320
525d5e6e
EZ
33212011-08-01 Eli Zaretskii <eliz@gnu.org>
3322
3323 * xdisp.c (forward_to_next_line_start): Accept additional argument
3324 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3325 on the newline.
3326 (reseat_at_next_visible_line_start): Use the bidi iterator state
3327 returned by forward_to_next_line_start to restore the state of
3328 it->bidi_it after backing up to previous newline. (Bug#9212)
3329
31011111
AS
33302011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3331
3332 * regex.c (re_comp): Protoize.
3333 (re_exec): Fix return type.
3334 (regexec): Fix type of `ret'. (Bug#9203)
3335
476371c4
PE
33362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3337
e5d76069
PE
3338 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3339 This is needed if max-image-size is a floating-point number.
3340
9a79b20c
AS
33412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3342
3343 * print.c (print_object): Print empty symbol as ##.
3344
3345 * lread.c (read1): Read ## as empty symbol.
3346
d8c2fa78
AA
33472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3348
3349 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3350 setting frame foreground color (Bug#9175).
3351 (x_set_background_color): Likewise.
3352
ffe57a7a
AA
3353 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3354 contents (Bug#9176).
3355 (EmacsTooltip -init): Remove bezels and add shadows to
3356 tooltip windows.
3357
bf3492a5
AA
3358 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3359 or scroll bar (Bug#8470).
3360
d55e9c53
AA
3361 * nsfont.m (nsfont_open): Remove assignment to voffset and
3362 unnecessary vars hshink, expand, hd, full_height, min_height.
3363 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3364
3365 * nsterm.h (nsfont_info): Remove voffset field.
3366
d8c2fa78 33672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3368
3369 Implement strike-through and overline on NextStep (Bug#8863).
3370
3371 * nsfont.m (nsfont_open): Use underline position provided by font,
3372 instead of hard-coded value of 2.
3373 (nsfont_draw): Call ns_draw_text_decoration instead.
3374
3375 * nsterm.h: Add declaration for ns_draw_text_decoration.
3376
3377 * nsterm.m (ns_draw_text_decoration): New function for drawing
3378 underline, overline, and strike-through.
3379 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3380 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3381 accommodate underlining, etc.
4843aac3 3382
4cc60b9b
EZ
33832011-07-28 Eli Zaretskii <eliz@gnu.org>
3384
bc7ece87
EZ
3385 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3386 default.
4cc60b9b 3387
476371c4
PE
33882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3389
66606eea
PE
3390 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3391 Without this fix, if a signal arrives just after memory fills up,
3392 'malloc' might be invoked reentrantly.
3393
476371c4
PE
3394 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3395 In other words, assume that every image size is allowed, on non-X
3396 hosts. This assumption is probably wrong, but it lets Emacs compile.
3397
f3fcc40d
AS
33982011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3399
3400 * regex.c (re_iswctype): Convert return values to boolean.
3401
350c992f
EZ
34022011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3403
3404 * xdisp.c (compute_display_string_pos): Don't use cached display
3405 string position if the buffer had its restriction changed.
3406 (Bug#9184)
3407
5266b4bb
PE
34082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3411
2573a837 34122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3413
41f55ccd 3414 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3415
39e378da
PE
3416 * bidi.c: Integer size and overflow fixes.
3417 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3418 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3419 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3420 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3421 (bidi_find_other_level_edge):
3422 Use ptrdiff_t instead of EMACS_INT where either will do.
3423 This works better on 32-bit hosts configured --with-wide-int.
3424 (bidi_cache_ensure_space): Check for size-calculation overflow.
3425 Use % rather than repeated addition, for better worst-case speed.
3426 Don't set bidi_cache_size until after xrealloc returns, because it
3427 might not return.
3428 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3429 (bidi_cache_ensure_space): Also check that the bidi cache size
3430 does not exceed that of the largest Lisp string or buffer. See Eli
3431 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3432
5e927815
PE
3433 * alloc.c (__malloc_size_t): Remove.
3434 All uses replaced by size_t. See Andreas Schwab's note
3435 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3436
ca4aa935
PE
3437 * image.c: Improve checking for integer overflow.
3438 (check_image_size): Assume that f is nonnull, since
3439 it is always nonnull in practice. This is one less thing to
3440 worry about when checking for integer overflow later.
3441 (x_check_image_size): New function, which checks for integer
3442 overflow issues inside X.
3443 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3444 This removes the need for a memory_full check.
3445 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3446 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3447 (xbm_read_bitmap_data): Change locals back to 'int', since
3448 their values must fit in 'int'.
3449 (xpm_load_image, png_load, tiff_load):
3450 Invoke x_create_x_image_and_pixmap earlier,
3451 to avoid much needless work if the image is too large.
3452 (tiff_load): Treat overly large images as if
3453 x_create_x_image_and_pixmap failed, not as malloc failures.
3454 (gs_load): Use x_check_image_size.
3455
5f8f9cc2
PE
3456 * gtkutil.c: Omit integer casts.
3457 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3458 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3459
5adf60bc
PE
3460 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3461
c8907a93
PE
3462 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3463 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3464 would wrongly return t on a 64-bit host.
3465
e3c25c68
PE
3466 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3467 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3468 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3469 and therefore cause GCC to emit a bogus diagnostic in some cases.
3470
3f791afe
PE
3471 * image.c: Integer signedness and overflow and related fixes.
3472 This is not an exhaustive set of fixes, but it's time to
3473 record what I've got.
3474 (lookup_pixel_color, check_image_size): Remove redundant decls.
3475 (check_image_size): Don't assume that arbitrary EMACS_INT values
3476 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3477 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3478 (tiff_load, imagemagick_load_image):
3479 Check for overflow in size calculations.
3480 (x_create_x_image_and_pixmap): Remove unnecessary test for
3481 xmalloc returning NULL; that can't happen.
3482 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3483 (xpm_color_bucket): Use better integer hashing function.
3484 (xpm_cache_color): Don't possibly over-allocate memory.
3485 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3486 (gif_memory_source):
3487 Use ptrdiff_t, not int or size_t, to record sizes.
3488 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3489 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3490 either works, as we prefer signed integers.
3491 (tiff_read_from_memory, tiff_write_from_memory):
3492 Return tsize_t, not size_t, since that's what the TIFF API wants.
3493 (tiff_read_from_memory): Don't fail simply because the read would
3494 go past EOF; instead, return a short read.
3495 (tiff_load): Omit no-longer-needed casts.
3496 (Fimagemagick_types): Don't assume size fits into 'int'.
3497
3cc5a532
PE
3498 Improve hashing quality when configured --with-wide-int.
3499 * fns.c (hash_string): New function, taken from sxhash_string.
3500 Do not discard information about ASCII character case; this
3501 discarding is no longer needed.
3502 (sxhash-string): Use it. Change sig to match it. Caller changed.
3503 * lisp.h: Declare it.
3504 * lread.c (hash_string): Remove, since we now use fns.c's version.
3505 The fns.c version returns a wider integer if --with-wide-int is
3506 specified, so this should help the quality of the hashing a bit.
3507
b312a492
PE
3508 * emacs.c: Integer overflow minor fix.
3509 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3510 Define only if GNU_LINUX.
3511 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3512
dfd153ae
PE
3513 * dispnew.c: Integer signedness and overflow fixes.
3514 Remove unnecessary forward decls, that were a maintenance hassle.
3515 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3516 All uses changed.
3517 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3518 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3519 (prepare_desired_row, line_draw_cost):
3520 Use int, not unsigned, where either works.
3521 (save_current_matrix, restore_current_matrix):
3522 Use ptrdiff_t, not size_t, where either works.
3523 (init_display): Check for overflow more accurately, and without
3524 relying on undefined behavior.
3525
a81d11a3
PE
3526 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3527 Remove, replacing with the new symbols in lisp.h. All uses changed.
3528 * fileio.c (make_temp_name):
3529 * filelock.c (lock_file_1, lock_file):
3530 * xdisp.c (message_dolog):
3531 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3532 Use pMd etc. instead.
3533 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3534 replacing the pWIDE etc. symbols removed from editfns.c.
3535
3300e6fd
PE
3536 * keyboard.h (num_input_events): Now uintmax_t.
3537 This is (very slightly) less likely to mess up due to wraparound.
3538 All uses changed.
3539
fd05c7e9
PE
3540 * buffer.c: Integer signedness fixes.
3541 (alloc_buffer_text, enlarge_buffer_text):
3542 Use ptrdiff_t rather than size_t when either will do, as we prefer
3543 signed integers.
3544
903fe15d
PE
3545 * alloc.c: Integer signedness and overflow fixes.
3546 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3547 (__malloc_size_t): Default to size_t, not to int.
3548 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3549 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3550 Prefer ptrdiff_t to size_t when either would do, as we prefer
3551 signed integers.
3552 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3553 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3554 Now const. Initialize with values that are in range even if char
3555 is signed.
3556 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3557 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3558 These functions do the right thing with sizes > 2**32.
3559 (check_depth): Now ptrdiff_t, not int.
3560 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3561 Adjust to new way of storing sizes. Check for size overflow bugs
3562 in rest of code.
3563 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3564 slightly wrong anyway, as it missed one instance of
3565 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3566 (refill_memory_reserve): Omit needless cast to size_t.
3567 (mark_object_loop_halt): Mark as externally visible.
3568
ac82cc6a
PE
3569 * xselect.c: Integer signedness and overflow fixes.
3570 (Fx_register_dnd_atom, x_handle_dnd_message):
3571 Use ptrdiff_t, not size_t, since we prefer signed.
3572 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3573 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3574 x_dnd_atoms_size and x_dnd_atoms_length.
3575
c2d1e36d
PE
3576 * doprnt.c: Prefer signed to unsigned when either works.
3577 * eval.c (verror):
3578 * doprnt.c (doprnt):
3579 * lisp.h (doprnt):
3580 * xdisp.c (vmessage):
3581 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3582 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3583 prefer signed arithmetic to avoid comparison confusion.
3584 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3585 but is a bit tricky.
3586
0e926e56
PE
3587 Assume freestanding C89 headers, string.h, stdlib.h.
3588 * data.c, doprnt.c, floatfns.c, print.c:
3589 Include float.h unconditionally.
3590 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3591 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3592 * regex.c: Likewise for stddef.h, string.h.
3593 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3594 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3595 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3596 (STDC_HEADERS): Remove obsolete defines.
3597 * sysdep.c: Include limits.h unconditionally.
3598
9cfdb3ec
PE
3599 Assume support for memcmp, memcpy, memmove, memset.
3600 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3601 * regex.c (memcmp, memcpy):
3602 Remove; we assume C89 now.
3603
3604 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3605 (__malloc_safe_bcopy): Remove; no longer needed.
3606
cf950e6b 3607 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3608 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3609 well either way, and we prefer signed to unsigned.
3610
dbf38e02
LMI
36112011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3612
3613 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3614 closes the connection while we're reading (bug#9182).
3615
d6f0886c 36162011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3617
d6f0886c
JD
3618 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3619 are specified (Bug#9168).
24e0f6b1 3620
2eb1f9e6
PE
36212011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3622
3623 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3624 Found by GCC static checking and --with-wide-int on a 32-bit host.
3625
22381272 36262011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3627
3628 * xdisp.c (compute_display_string_pos): Fix logic of caching
3629 previous display string position. Initialize cached_prev_pos to
3630 -1. Fixes slow-down at the beginning of a buffer.
3631
f25e39b4
EZ
36322011-07-24 Eli Zaretskii <eliz@gnu.org>
3633
3634 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3635 for attrs[LFACE_FONTSET_INDEX].
3636
04c4b52e
PE
36372011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 * xml.c (parse_region): Remove unused local
3640 that was recently introduced.
3641
c1734fbd
EZ
36422011-07-23 Eli Zaretskii <eliz@gnu.org>
3643
be18c5a5
EZ
3644 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3645 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3646
c1734fbd
EZ
3647 * xdisp.c (move_it_in_display_line_to): Record the best matching
3648 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3649 exit if none of the characters scanned was an exact match.
3650 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3651 when exact match is impossible due to invisible text, and the
3652 lines are truncated.
3653
a258d627
JD
36542011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3655
3656 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3657 for OSX >= 10.7.
3658
b6d5a689
EZ
36592011-07-22 Eli Zaretskii <eliz@gnu.org>
3660
0f74f785
EZ
3661 Fix a significant slow-down of cursor motion with C-n, C-p,
3662 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3663 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3664 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3665 (next_element_from_buffer): Call compute_stop_pos_backwards to
3666 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3667 base_level_stop.
3668 (reseat): Don't look for prev_stop, as that could mean a very long
3669 run.
3670 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3671 <cached_disp_overlay_modiff>: Cache for last found display string
3672 position.
551918c1 3673 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3674 about the same buffer in the same area of character positions, and
3675 the buffer wasn't changed since the time the display string
3676 position was cached.
551918c1 3677
b2d0c91a
EZ
36782011-07-22 Eli Zaretskii <eliz@gnu.org>
3679
3680 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3681 is an integer, which is important for empty lines. (Bug#9149)
3682
043604ee
CY
36832011-07-22 Chong Yidong <cyd@stupidchicken.com>
3684
3685 * frame.c (Fmodify_frame_parameters): In tty case, update the
3686 default face if necessary (Bug#4238).
3687
da4adb04
CY
36882011-07-21 Chong Yidong <cyd@stupidchicken.com>
3689
3690 * editfns.c (Fstring_to_char): No need to explain what a character
3691 is in the docstring (Bug#6576).
3692
9abd0532
LMI
36932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3694
3695 * xml.c (parse_region): Make sure we always return a tree.
3696
36881d16
HK
36972011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3698
3699 * xml.c (parse_region): If a document contains only comments,
3700 return that, too.
3701
1e98674d
LMI
37022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3703
3704 * xml.c (make_dom): Return comments, too.
3705
590bd467
PE
37062011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3707
3708 Port to OpenBSD.
3709 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3710 and the surrounding thread.
3711 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3712 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3713 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3714 timer goes off.
3715 * s/openbsd.h (BROKEN_SIGIO): Define.
3716 * unexelf.c (unexec) [__OpenBSD__]:
3717 Don't update the .mdebug section of the Alpha COFF symbol table.
3718
f41628b2
LMI
37192011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3720
3721 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3722 (bug#8460).
3723
b59b67c5
PE
37242011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3725
15e3a074
PE
3726 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3727 This fixes some race conditions on the permissions of any newly
3728 created file.
3729
41bed37d
PE
3730 * alloc.c (valid_pointer_p): Use pipe, not open.
3731 This fixes some permissions issues when debugging.
3732
b59b67c5
PE
3733 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3734 If fchown fails to set both uid and gid, try to set just gid,
3735 as that is sometimes allowed. Adjust the file's mode to eliminate
3736 setuid or setgid bits that are inappropriate if fchown fails.
3737
925a6be7
SM
37382011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3739
3740 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3741 to compare Lisp_Objects.
3742 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3743 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3744 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3745
52968808
AS
37462011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3747
0a6a104b
AS
3748 * lread.c (read_integer): Unread even EOF character.
3749 (read1): Likewise. Properly record start position of symbol.
3750
52968808
AS
3751 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3752 symbol character follows.
3753
9e381cdd
PE
37542011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3755
3756 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3757 This works around a problem with the previous change to Fcopy_file.
3758 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3759 and without this change, GCC might complain about discarding
3760 fchown's return value.
3761
b5641435
JB
37622011-07-16 Juanma Barranquero <lekktu@gmail.com>
3763
3764 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3765
a8031457
PE
37662011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3767
3768 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3769
dd889327
LMI
37702011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3771
750c33f7
LMI
3772 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3773 it's used from the C level.
3774
dd889327
LMI
3775 * process.c: Use the same condition for POLL_FOR_INPUT in both
3776 keyboard.c and process.c (bug#1858).
3777
87e86684
LM
37782011-07-09 Lawrence Mitchell <wence@gmx.li>
3779
3780 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3781 (Fgnutls_boot): Use it.
3782
64348f40
AS
37832011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3784
3785 * doc.c (Fsubstitute_command_keys): Revert last change.
3786
1d698799
LMI
37872011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3788
f863868c
LMI
3789 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3790 quotes the next character, and doesn't affect other longer
3791 sequences (bug#8935).
3792
1d698799
LMI
3793 * lread.c (syms_of_lread): Clarify that is isn't only
3794 `eval-buffer' and `eval-defun' that's affected by
3795 `lexical-binding' (bug#8460).
3796
aa4b6df6
EZ
37972011-07-15 Eli Zaretskii <eliz@gnu.org>
3798
3799 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3800 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3801
5d856da6
PE
38022011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3803
ad6042bb
PE
3804 Fix minor problems found by static checking.
3805 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3806 (elsz): Now a signed constant, not a size_t var. We prefer signed
3807 types to unsigned, to avoid integer comparison confusion. Without
3808 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3809 "cannot optimize loop, the loop counter may overflow", a symptom
3810 of the confusion.
f00bbb22 3811 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3812 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3813
6468f31c
LMI
38142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3815
49080b10
LMI
3816 * search.c (Fre_search_backward): Mention `case-fold-search' in
3817 all the re_search_* functions (bug#8138).
3818
6468f31c
LMI
3819 * keyboard.c (Fopen_dribble_file): Document when the file is
3820 closed (bug#8056).
3821
c965adc5
EZ
38222011-07-14 Eli Zaretskii <eliz@gnu.org>
3823
df9733bf
EZ
3824 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3825 bidi_cache_idx.
3826
0bb23927
EZ
3827 Support bidi reordering of display and overlay strings.
3828 * xdisp.c (compute_display_string_pos)
3829 (compute_display_string_end): Accept additional argument STRING.
3830 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3831 (reseat_to_string): Initialize bidi_it->string.s and
3832 bidi_it->string.schars.
3833 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3834 NULL (avoids a crash in bidi_paragraph_init).
3835 Initialize itb.string.lstring.
0bb23927
EZ
3836 (init_iterator): Call bidi_init_it only of a valid
3837 buffer position was specified. Initialize paragraph_embedding to
3838 L2R.
3839 (reseat_to_string): Initialize the bidi iterator.
3840 (display_string): If we need to ignore text properties of
3841 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3842 original value of -1 will not work with bidi.)
3843 (compute_display_string_pos): First arg is now struct
3844 `text_pos *'; all callers changed. Support display properties on
3845 Lisp strings.
3846 (compute_display_string_end): Support display properties on Lisp
3847 strings.
3848 (init_iterator, reseat_1, reseat_to_string): Initialize the
3849 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3850 when iterating on a string not from display properties).
640c8776
SM
3851 (compute_display_string_pos, compute_display_string_end):
3852 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3853 arrow keys.
3854 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3855 base_level_stop; instead, set base_level_stop to BEGV.
3856 Fixes crashes in vertical-motion.
0bb23927
EZ
3857 (next_element_from_buffer): Improve commentary for when
3858 the iterator is before prev_stop.
3859 (init_iterator): Initialize bidi_p from the default value of
3860 bidi-display-reordering, not from buffer-local value. Use the
3861 buffer-local value only if initializing for buffer iteration.
3862 (handle_invisible_prop): Support invisible properties on strings
3863 that are being bidi-reordered.
3864 (set_iterator_to_next): Support bidi reordering of C strings and
3865 Lisp strings.
3866 (next_element_from_string): Support bidi reordering of Lisp
3867 strings.
3868 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3869 (display_string): Support display of R2L glyph rows.
3870 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3871 (init_iterator): Don't initialize it->bidi_p for strings
3872 here.
3873 (reseat_to_string): Initialize it->bidi_p for strings here.
3874 (next_element_from_string, next_element_from_c_string)
3875 (next_element_from_buffer): Add xassert's for correspondence
3876 between IT's object being iterated and it->bidi_it.string
3877 structure.
3878 (face_before_or_after_it_pos): Support bidi iteration.
3879 (next_element_from_c_string): Handle the case of the first string
3880 character that is not the first one in the visual order.
3881 (get_visually_first_element): New function, refactored from common
3882 parts of next_element_from_buffer, next_element_from_string, and
3883 next_element_from_c_string.
3884 (tool_bar_lines_needed, redisplay_tool_bar)
3885 (display_menu_bar): Force left-to-right direction. Add a FIXME
3886 comment for making that be controlled by a user option.
3887 (push_it, pop_it): Save and restore the state of the
3888 bidi iterator. Save and restore the bidi_p flag.
3889 (pop_it): Iterate out of display property for string iteration as
3890 well.
3891 (iterate_out_of_display_property): Support iteration over strings.
3892 (handle_single_display_spec): Set up it->bidi_it for iteration
3893 over a display string, and call bidi_init_it.
3894 (handle_single_display_spec, next_overlay_string)
3895 (get_overlay_strings_1, push_display_prop): Set up the bidi
3896 iterator for displaying display or overlay strings.
3897 (forward_to_next_line_start): Don't use the shortcut if
3898 bidi-iterating.
3899 (back_to_previous_visible_line_start): If handle_display_prop
3900 pushed the iterator stack, restore the internal state of the bidi
3901 iterator by calling bidi_pop_it same number of times.
3902 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3903 and we are bidi-iterating, don't decrement the iterator position;
3904 instead, set the first_elt flag in the bidi iterator, to produce
3905 the same effect.
3906 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3907 (push_display_prop): xassert that we are iterating a buffer.
3908 (push_it, pop_it): Save and restore paragraph_embedding member.
3909 (handle_single_display_spec, next_overlay_string)
3910 (get_overlay_strings_1, reseat_1, reseat_to_string)
3911 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3912 correctly. Don't assume unibyte strings are not bidi-reordered.
3913 (compute_display_string_pos)
3914 (compute_display_string_end): Fix handling the case of C string.
3915 (push_it, pop_it): Save and restore from_disp_prop_p.
3916 (handle_single_display_spec, push_display_prop): Set the
3917 from_disp_prop_p flag.
3918 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3919 (pop_it): Call iterate_out_of_display_property only if we are
3920 popping after iteration over a string that came from a display
3921 property. Fix a typo in popping stretch info. Add an assertion
3922 for verifying that the iterator position is in sync with the bidi
3923 iterator.
3924 (handle_single_display_spec, get_overlay_strings_1)
3925 (push_display_prop): Fix initialization of paragraph direction for
3926 string when that of the parent object is not yet determined.
3927 (reseat_1): Call bidi_init_it to resync the bidi
3928 iterator with IT's position. (Bug#7616)
3929 (find_row_edges): If ROW->start.pos gives position
3930 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3931 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3932 Reset the from_disp_prop_p flag.
3933 (SAVE_IT, RESTORE_IT): New macros.
3934 (pos_visible_p, face_before_or_after_it_pos)
3935 (back_to_previous_visible_line_start)
3936 (move_it_in_display_line_to, move_it_in_display_line)
3937 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3938 (try_scrolling, redisplay_window, display_line): Use them when
3939 saving a temporary copy of the iterator and restoring it back.
3940 (back_to_previous_visible_line_start, reseat_1)
3941 (init_iterator): Empty the bidi cache "stack".
3942 (move_it_in_display_line_to): If iterator ended up at
3943 EOL, but we never saw any buffer positions smaller than
3944 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3945 motion in bidi-reordered lines.
3946 (move_it_in_display_line_to): Record prev_method and prev_pos
3947 immediately before the call to set_iterator_to_next. Fixes cursor
3948 motion in bidi-reordered lines with stretch glyphs and strings
3949 displayed in margins. (Bug#8133) (Bug#8867)
3950 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3951 TO_CHARPOS.
640c8776
SM
3952 (pos_visible_p): Support positions in bidi-reordered lines.
3953 Save and restore bidi cache.
0bb23927
EZ
3954
3955 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3956 (bidi_paragraph_info): Delete unused struct.
3957 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3958 (bidi_cache_start): New variable.
3959 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3960 to zero.
3961 (bidi_cache_fetch_state, bidi_cache_search)
3962 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3963 (bidi_cache_find, bidi_peek_at_next_level)
3964 (bidi_level_of_next_char, bidi_find_other_level_edge)
3965 (bidi_move_to_visually_next): Compare cache index with
3966 bidi_cache_start rather than with zero.
3967 (bidi_fetch_char): Accept new argument STRING; all callers
3968 changed. Support iteration over a string. Support strings with
3969 display properties. Support unibyte strings. Fix the type of
3970 `len' according to what STRING_CHAR_AND_LENGTH expects.
3971 (bidi_paragraph_init, bidi_resolve_explicit_1)
3972 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3973 (bidi_level_of_next_char, bidi_move_to_visually_next):
3974 Support iteration over a string.
0bb23927
EZ
3975 (bidi_set_sor_type, bidi_resolve_explicit_1)
3976 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3977 can now be zero (for strings); special values 0 and -1 were
3978 changed to -1 and -2, respectively.
3979 (bidi_char_at_pos): New function.
3980 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3981 Call it instead of FETCH_MULTIBYTE_CHAR.
3982 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3983 initialized to valid values.
3984 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3985 values.
3986 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3987 the test for valid cached positions. Fix the logic for looking up
3988 the sentinel state in the cache. GCPRO the Lisp string we are
3989 iterating.
3990 (bidi_push_it, bidi_pop_it): New functions.
3991 (bidi_initialize): Initialize the bidi cache start stack pointer.
3992 (bidi_cache_ensure_space): New function, refactored from part of
3993 bidi_cache_iterator_state. Don't assume the required size is just
3994 one BIDI_CACHE_CHUNK away.
3995 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3996 (bidi_count_bytes, bidi_char_at_pos): New functions.
3997 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3998 always valid if bidi_cache_idx is valid.
3999 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4000 is valid if it's going to be used.
4001 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4002 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4003 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4004 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4005 (bidi_find_other_level_edge, bidi_cache_start_stack):
4006 All variables related to cache indices are now EMACS_INT.
c965adc5 4007
0bb23927
EZ
4008 * dispextern.h (struct bidi_string_data): New structure.
4009 (struct bidi_it): New member `string'. Make flag members be 1-bit
4010 fields, and put them last in the struct.
640c8776
SM
4011 (compute_display_string_pos, compute_display_string_end):
4012 Update prototypes.
0bb23927
EZ
4013 (bidi_push_it, bidi_pop_it): Add prototypes.
4014 (struct iterator_stack_entry): New members bidi_p,
4015 paragraph_embedding, and from_disp_prop_p.
4016 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4017 (bidi_shelve_cache, bidi_unshelve_cache):
4018 Declare prototypes.
0bb23927
EZ
4019
4020 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4021 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4022 and vector-like objects.
4023
4024 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4025 cache around display iteration.
4026
4027 * window.c (Fwindow_end, window_scroll_pixel_based)
4028 (displayed_window_lines, Frecenter): Save and restore the bidi
4029 cache around display iteration.
4030
3bbd2265
LMI
40312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4032
4033 * editfns.c (Fdelete_region): Clarify the use of the named
4034 parameters (bug#6788).
4035
adc47434
MR
40362011-07-14 Martin Rudalics <rudalics@gmx.at>
4037
4038 * indent.c (Fvertical_motion): Set and restore w->pointm when
4039 saving and restoring the window's buffer (Bug#9006).
4040
837c31f8
LMI
40412011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4042
4043 * editfns.c (Fstring_to_char): Clarify just what is returned
4044 (bug#6576). Text by Eli Zaretskii.
4045
ac389d0c
JB
40462011-07-13 Juanma Barranquero <lekktu@gmail.com>
4047
4048 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4049
0be0ce47
EZ
40502011-07-13 Eli Zaretskii <eliz@gnu.org>
4051
4052 * buffer.c (mmap_find): Fix a typo.
4053
cd18e7e3
JB
40542011-07-13 Johan Bockgård <bojohan@gnu.org>
4055
4056 Fix execution of x selection hooks.
4057 * xselect.c (Qx_lost_selection_functions)
4058 (Qx_sent_selection_functions): New vars.
4059 (syms_of_xselect): DEFSYM them.
4060 (x_handle_selection_request): Pass Qx_sent_selection_functions
4061 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4062 (x_handle_selection_clear,x_clear_frame_selections):
4063 Pass Qx_lost_selection_functions rather than
4064 Vx_lost_selection_functions to Frun_hook_with_args.
4065
47ea7f44
PE
40662011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4067
ac389d0c 4068 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4069 The old code sometimes used this field without initializing it.
4070
47ea7f44
PE
4071 * alloc.c (gc_sweep): Don't read past end of array.
4072 In theory, the old code could also have corrupted Emacs internals,
4073 though it'd be very unlikely.
4074
bc985c87
AS
40752011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4076
4077 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4078 argument. (Bug#4026)
bc985c87 4079
0cf34688
LMI
40802011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4081
b3dadd76
LMI
4082 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4083 key" (bug#4257).
4084
0cf34688
LMI
4085 * window.c (Fset_window_start): Doc fix (bug#4199).
4086 (Fset_window_hscroll): Ditto.
4087
270768cd
PE
40882011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4089
077e3dda 4090 Fix minor new problems caught by GCC 4.6.1.
270768cd 4091 * term.c (init_tty): Remove unused local.
490011a6 4092 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4093 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4094 not used otherwise.
270768cd 4095
b1f58454
CY
40962011-07-12 Chong Yidong <cyd@stupidchicken.com>
4097
4098 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4099
22b9578d
LMI
41002011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4101
6e70ab07
LMI
4102 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4103 are the mini-buffer and the echo area (bug#3320).
4104
22b9578d
LMI
4105 * term.c (init_tty): Remove support for supdup, c10 and perq
4106 terminals, which are no longer supported (bug#1482).
4107
8974cc9f
JB
41082011-07-10 Johan Bockgård <bojohan@gnu.org>
4109
4110 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4111
a560d974
JD
41122011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4113
4114 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4115 for non-popups (Bug#3642).
4116
1dae0f0a
AS
41172011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4118
268c2c36 4119 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4120 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4121 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4122 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4123 * data.c (fmod): Likewise.
4124 * dispnew.c (swap_glyphs_in_rows): Likewise.
4125 * emacs.c (memory_warning_signal): Likewise.
4126 * floatfns.c (float_error): Likewise.
4127 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4128 (otf_open, font_otf_capability, generate_otf_features)
4129 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4130 Likewise.
4131 * image.c (pbm_read_file): Likewise.
4132 * indent.c (string_display_width): Likewise.
4133 * intervals.c (check_for_interval, search_for_interval)
4134 (inc_interval_count, count_intervals, root_interval)
4135 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4136 * lread.c (defalias): Likewise.
268c2c36 4137 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4138 * regex.c (set_image_of_range_1, set_image_of_range)
4139 (regex_grow_registers): Likewise.
4140 * sysdep.c (strerror): Likewise.
4141 * termcap.c (valid_filename_p, tprint, main): Likewise.
4142 * tparam.c (main): Likewise.
4143 * unexhp9k800.c (run_time_remap, save_data_space)
4144 (update_file_ptrs, read_header, write_header, calculate_checksum)
4145 (copy_file, copy_rest, display_header): Likewise.
4146 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4147 Likewise.
4148 * xdisp.c (check_it): Likewise.
4149 * xfaces.c (register_color, unregister_color, unregister_colors):
4150 Likewise.
4151 * xfns.c (print_fontset_result): Likewise.
4152 * xrdb.c (member, fatal, main): Likewise.
4153
99033785
PE
41542011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 Fix minor problems found by static checking (Bug#9031).
4157 * chartab.c (char_table_set_range, map_sub_char_table):
4158 Remove unused locals.
4159 (uniprop_table): Now static.
4160 * composite.c (_work_char): Remove unused static var.
4161
9cb2ac56
JB
41622011-07-09 Juanma Barranquero <lekktu@gmail.com>
4163
4164 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4165
f25661f0
JD
41662011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4167
4168 * gtkutil.c (qttip_cb): Remove code without function.
4169
8278c4fe
EZ
41702011-07-09 Eli Zaretskii <eliz@gnu.org>
4171
4172 * w32.c (pthread_sigmask): New stub.
4173
1692ae2d 41742011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4175
8a6ebd58 4176 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4177 sigprocmask is portable only for single-threaded applications, and
4178 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4179 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4180 (LIBES): Use it.
4181 * callproc.c (Fcall_process):
4182 * process.c (create_process):
4183 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4184 Use pthread_sigmask, not sigprocmask.
123403e4 4185
1b854618
JD
41862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4187
4188 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4189 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4190 wrong (Bug#8591).
4191
3fe4b549
JD
41922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4193
0ce7e563
JD
4194 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4195 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4196 (xg_hide_tooltip): Fix comment.
4197
3fe4b549
JD
4198 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4199 in registerServicesMenuSendTypes.
4200 (validRequestorForSendType): Don't check ns_return_types.
4201
4202 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4203 ns_return_type.
4204
5df75e47
JR
42052011-07-08 Jason Rumney <jasonr@gnu.org>
4206
22610910
JR
4207 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4208 SH_SHOW for hidden windows (Bug#5482).
4209
5df75e47
JR
4210 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4211 frame struct members of non-existent frames (Bug#6284).
4212
699c10bd
JD
42132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4214
4393663b
JD
4215 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4216 variable firstTime not needed on OSX >= 10.6.
4217 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4218 >= 10.5. Use setKnobProportion, setDoubleValue.
4219
4220 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4221 (MAC_OS_X_VERSION_10_5): Define if not defined.
4222 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4223 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4224 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4225
4226 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4227 cString and lossyCString on OSX >= 10.4
4228
58179cce 4229 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4230 sizeToFit on OSX >= 10.2.
4231
4232 * nsimage.m (allocInitFromFile): Don't use deprecated method
4233 bestRepresentationForDevice on OSX >= 10.6.
4234
4235 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4236 to avoid warning.
4237
4238 * emacs.c: Declare unexec_init_emacs_zone.
4239
a63e0781
JD
4240 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4241
699c10bd
JD
4242 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4243
4244 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4245 on svcsMenu (Bug#8842).
4246
4247 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4248 ns_return_types.
4249 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4250
4251 * nsterm.m (QUTF8_STRING): Declare.
4252 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4253 (validRequestorForSendType): Return type is (id).
4254 Change indexOfObjectIdenticalTo to indexOfObject.
4255 Check if we have local selection before returning self (Bug#8842).
4256 (writeSelectionToPasteboard): Put local selection into paste board
4257 if we have a local selection (Bug#8842).
4258 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4259
4260 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4261 (ns_get_local_selection): Declare.
4262
54e10184
LMI
42632011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4264
9888ff71
LMI
4265 * keymap.c (describe_map_tree): Don't insert a double newline at
4266 the end of the buffer (bug#1169) and return whether we inserted
4267 something.
4268
54e10184
LMI
4269 * callint.c (Fcall_interactively): Change "reading args" to
4270 "providing args" to try to clarify what it does (bug#1010).
4271
15fa4783
KH
42722011-07-07 Kenichi Handa <handa@m17n.org>
4273
4274 * composite.c (composition_compute_stop_pos): Ignore a static
4275 composition starting before CHARPOS (Bug#8915).
4276
4277 * xdisp.c (handle_composition_prop): Likewise.
4278
a8815b00
EZ
42792011-07-07 Eli Zaretskii <eliz@gnu.org>
4280
4281 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4282 (Bug#9015)
4283
ef7b981d 42842011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4285
4286 * character.h (unicode_category_t): New enum type.
4287
4288 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4289 (Qchar_code_property_table): New variable.
4290 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4291 (UNIPROP_COMPRESSED_FORM_P): New macros.
4292 (char_table_ascii): Uncompress the compressed values.
4293 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4294 Uncompress the compressed values.
ac389d0c 4295 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4296 (char_table_ref_and_range): Uncompress the compressed values.
4297 (sub_char_table_set): New arg is_uniprop. Callers changed.
4298 Uncompress the compressed values.
4299 (sub_char_table_set_range): Args changed. Callers changed.
4300 (char_table_set_range): Adjuted for the above change.
4301 (map_sub_char_table): Delete args default_val and parent. Add arg
4302 top. Give decoded values to a Lisp function.
640c8776 4303 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4304 values to a Lisp function. Gcpro more variables.
4305 (uniprop_table_uncompress)
4306 (uniprop_decode_value_run_length): New functions.
4307 (uniprop_decoder, uniprop_decoder_count): New variables.
4308 (uniprop_get_decoder, uniprop_encode_value_character)
4309 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4310 New functions.
4311 (uniprop_encoder, uniprop_encoder_count): New variables.
4312 (uniprop_get_encoder, uniprop_table)
4313 (Funicode_property_table_internal, Fget_unicode_property_internal)
4314 (Fput_unicode_property_internal): New functions.
4315 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4316 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4317 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4318 char-code-property-alist.
4319
640c8776 4320 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4321 Vunicode_category_table.
4322
640c8776 4323 * font.c (font_range): Adjust for the change of
c805dec0
KH
4324 Vunicode_category_table.
4325
76b397fb
DN
43262011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4327
4328 * m/iris4d.h: Remove file, move contents ...
4329 * s/irix6-5.h: ... here.
4330
22b4128e
PE
43312011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4332
4333 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4334 * alloc.c (mark_buffer):
4335 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4336 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4337 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4338 This isn't true in general, and it's particularly not true
4339 if Emacs is configured with --with-wide-int.
4340 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4341 New macros, used in the buffer.c change.
4342
869795d6
JD
43432011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4344
4345 * xsettings.c: Use both GConf and GSettings if both are available.
4346 (store_config_changed_event): Add comment.
4347 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4348 (store_tool_bar_style_changed): New functions.
5e617bc2 4349 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4350 (struct xsettings): Move font inside HAVE_XFT.
4351 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4352 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4353 Move inside HAVE_XFT.
640c8776 4354 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4355 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4356 also.
4357 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4358 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4359 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4360 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4361 (parse_settings): Move check for font inside HAVE_XFT.
4362 (read_settings, apply_xft_settings): Add comment.
4363 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4364 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4365 call store_font_name_changed.
4366 (xft_settings_event): Add comment.
4367 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4368 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4369 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4370 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4371 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4372 (xsettings_get_system_font, xsettings_get_system_normal_font):
4373 Add comment.
869795d6 4374
d8ed26bd
PE
43752011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4376
4377 Random fixes. E.g., (random) never returned negative values.
4378 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4379 subseconds part to the entropy, as that's a bit more random.
4380 Prefer signed to unsigned, since the signedness doesn't matter and
4381 in general we prefer signed. When given a limit, use a
4382 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4383 latter isn't right if USE_2_TAGS_FOR_INTS.
4384 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4385 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4386
cabf1cac
SM
43872011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4388
4389 * textprop.c (text_property_stickiness):
4390 Obey Vtext_property_default_nonsticky.
4391 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4392 * w32fns.c (syms_of_w32fns):
4393 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4394
6e9b2be9
PE
43952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4396
4397 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4398 This is more efficient than Ffile_directory_p and avoids a minor race.
4399
90186c68
LMI
44002011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4401
7c301272
LMI
4402 * buffer.c (Foverlay_put): Say what the return value is
4403 (bug#7835).
4404
c4f2d8d4
LMI
4405 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4406 is a directory before asking whether to use the file name
4407 (bug#7564).
ad637907
LMI
4408 (barf_or_query_if_file_exists): Make the "File is a directory"
4409 error be more correct.
c4f2d8d4 4410
90186c68
LMI
4411 * fns.c (Frequire): Remove the mention of the .gz files, since
4412 that's installation-specific, but keep the mention of
4413 `get-load-suffixes'.
4414
da64016e
PE
44152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4416
4417 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4418 Report string overflow if the output is too long.
4419
7d47b580
JB
44202011-07-04 Juanma Barranquero <lekktu@gmail.com>
4421
a555cb87
JB
4422 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4423 (syms_of_gnutls): Remove duplicate DEFSYM for
4424 Qgnutls_bootprop_verify_hostname_error, an error for
4425 Qgnutls_bootprop_verify_error (which is no longer used).
4426
7d47b580
JB
4427 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4428 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4429 Also (re)move comments that are misplaced or no longer relevant.
4430
1e49bfab
LMI
44312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4432
4433 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4434
1485f4c0
CY
44352011-07-03 Chong Yidong <cyd@stupidchicken.com>
4436
4437 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4438 and background color parameters if they have been changed.
4439
a9ab721e
LMI
44402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4441
4442 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4443
cf7cff57
PE
44442011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4445
2e13213d
PE
4446 * xsettings.c (SYSTEM_FONT): Define only when used.
4447 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4448
cf7cff57
PE
4449 * keymap.c (access_keymap_1): Now static.
4450
7a8e04f7
CY
44512011-07-02 Chong Yidong <cyd@stupidchicken.com>
4452
4453 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4454 leave any prefix arg for the up event (Bug#1586).
4455
61352f62
LMI
44562011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4457
69bb1ef7
LMI
4458 * lread.c (syms_of_lread): Mention single symbols defined by
4459 `defvar' or `defconst' (bug#7154).
4460
61352f62 4461 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4462 (Frequire): Mention get-load-suffixes.
61352f62 4463
28545e04
MR
44642011-07-02 Martin Rudalics <rudalics@gmx.at>
4465
4466 * window.h (window): Remove clone_number slot.
4467 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4468 Remove.
4469 (make_parent_window, make_window, saved_window)
4470 (Fset_window_configuration, save_window_save): Don't deal with
4471 clone numbers.
4472 * buffer.c (Qclone_number): Remove declaration.
4473 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4474
3349e122
SM
44752011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4476
4477 Add multiple inheritance to keymaps.
4478 * keymap.c (Fmake_composed_keymap): New function.
4479 (Fset_keymap_parent): Simplify.
4480 (fix_submap_inheritance): Remove.
4481 (access_keymap_1): New function extracted from access_keymap to handle
4482 embedded parents and handle lists of maps.
4483 (access_keymap): Use it.
4484 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4485 (Fcopy_keymap): Handle embedded parents.
4486 (Fcommand_remapping, define_as_prefix): Simplify.
4487 (Fkey_binding): Simplify.
4488 (syms_of_keymap): Move minibuffer-local-completion-map,
4489 minibuffer-local-filename-completion-map,
4490 minibuffer-local-must-match-map, and
4491 minibuffer-local-filename-must-match-map to Elisp.
4492 (syms_of_keymap): Defsubr make-composed-keymap.
4493 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4494 (parse_menu_item): Trivial simplification.
4495
3279eb87
GM
44962011-07-01 Glenn Morris <rgm@gnu.org>
4497
4498 * Makefile.in (SETTINGS_LIBS): Fix typo.
4499
4550efdf
KI
45002011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4501
4502 * coding.c (Fencode_coding_string): Record the last coding system
4503 used, as the function doc string says (bug#8738).
4504
0949d2b6
JD
45052011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4506
4507 * xsettings.c (store_monospaced_changed): Take new font as arg and
4508 check for change against current_mono_font.
4509 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4510 (emacs_settings_constructor, emacs_settings_get_property)
4511 (emacs_settings_set_property, emacs_settings_class_init)
4512 (emacs_settings_init, gsettings_obj): Remove.
4513 (something_changedCB): New function for HAVE_GSETTINGS.
4514 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4515 with value as argument.
4516 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4517 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4518 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4519 "changed".
4520
4521 * xgselect.c: Add defined (HAVE_GSETTINGS).
4522 (xgselect_initialize): Ditto.
4523
4524 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4525 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4526 xg_select.
4527
bbc6b304
PE
45282011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4529
4530 * eval.c (struct backtrace): Simplify and port the data structure.
4531 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4532 signed bit field, as this assumption is not portable and it makes
4533 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4534 "char debug_on_exit : 1" as this is not portable either; instead,
4535 use the portable "unsigned int debug_on_exit : 1". Remove unused
4536 member evalargs. Remove obsolete comments about cc bombing out.
4537
9851bfc5
JD
45382011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4539
51bb811f 4540 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4541 Let HAVE_GSETTINGS override HAVE_GCONF.
4542 (store_monospaced_changed): New function.
4543 (EMACS_SETTINGS): A new type derived from GObject to handle
4544 GSettings notifications.
4545 (emacs_settings_constructor, emacs_settings_get_property)
4546 (emacs_settings_set_property, emacs_settings_class_init):
4547 New functions.
4548 (gsettings_client, gsettings_obj): New variables.
4549 (GSETTINGS_SCHEMA): New define.
4550 (something_changedCB): Call store_monospaced_changed.
4551 (init_gsettings): New function.
4552 (xsettings_initialize): Call init_gsettings.
4553 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4554 to NULL.
4555
640c8776 4556 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4557 GCONF_CFLAGS/LIBS.
4558
5386012d
MR
45592011-06-29 Martin Rudalics <rudalics@gmx.at>
4560
4561 * window.c (resize_root_window, grow_mini_window)
4562 (shrink_mini_window): Rename Qresize_root_window to
4563 Qwindow_resize_root_window and Qresize_root_window_vertically to
4564 Qwindow_resize_root_window_vertically.
4565
f13e0b08
PE
45662011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4567
4568 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4569
94515237
JB
45702011-06-27 Juanma Barranquero <lekktu@gmail.com>
4571
4572 * makefile.w32-in: Redesign dependencies so they reflect more
4573 clearly which files are directly included by each source file,
4574 and not through other includes.
4575
e43b6e43
MR
45762011-06-27 Martin Rudalics <rudalics@gmx.at>
4577
4578 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4579 (sort_overlays, overlay_strings): When an overlay's clone number
4580 matches the window's clone number process the overlay even if
4581 the overlay's window property doesn't match the current window.
4582
d68443dc
MR
4583 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4584 (Fwindow_hchild): Rename to Fwindow_left_child.
4585 (Fwindow_next): Rename to Fwindow_next_sibling.
4586 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4587 (resize_window_check): Rename to window_resize_check.
4588 (resize_window_apply): Rename to window_resize_apply.
4589 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4590 (Fdelete_other_windows_internal, resize_frame_windows)
4591 (Fsplit_window_internal, Fdelete_window_internal)
4592 (grow_mini_window, shrink_mini_window)
4593 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4594
c7e73be5
JD
45952011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4596
4597 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4598 (emacs_fixed_set_min_size): Remove.
4599 (emacs_fixed_new): Take frame as argument.
4600
4601 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4602 (_EmacsFixedPrivate): Remove minwidth/height.
4603 Add struct frame *f.
4604 (emacs_fixed_init): Initialize priv->f.
4605 (get_parent_class, emacs_fixed_set_min_size): Remove.
4606 (emacs_fixed_new): Set priv->f to argument.
4607 (emacs_fixed_get_preferred_width)
4608 (emacs_fixed_get_preferred_height): Use min_width/height from
4609 frames size_hint to set minimum and natural (Bug#8919).
4610 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4611 and use min_width/height from frames size_hint to set
4612 min_width/height (Bug#8919).
4613
4614 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4615 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4616 Fix indentation.
c7e73be5 4617
cf99dcf8
EZ
46182011-06-26 Eli Zaretskii <eliz@gnu.org>
4619
4620 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4621 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4622 called at ZV.
4623
029529ac
CY
46242011-06-26 Chong Yidong <cyd@stupidchicken.com>
4625
4626 * process.c (wait_reading_process_output): Bypass select if
4627 waiting for a cell while ignoring keyboard input, and input is
4628 pending. Suggested by Jan Djärv (Bug#8869).
4629
7a7ef429
PE
46302011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4631
4632 Use gnulib's dup2 module instead of rolling our own.
4633 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4634
11fdef7d 46352011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4636
4637 * dispnew.c (scrolling_window): Before scrolling, turn off a
4638 mouse-highlight in the window being scrolled.
4639
cd3520a4
JB
46402011-06-24 Juanma Barranquero <lekktu@gmail.com>
4641
4642 Move DEFSYM to lisp.h and use everywhere.
4643
4644 * character.h (DEFSYM): Move declaration...
4645 * lisp.h (DEFSYM): ...here.
4646
4647 * gnutls.c:
4648 * minibuf.c:
4649 * w32menu.c:
4650 * w32proc.c:
4651 * w32select.c: Don't include character.h.
4652
4653 * alloc.c (syms_of_alloc):
4654 * buffer.c (syms_of_buffer):
4655 * bytecode.c (syms_of_bytecode):
4656 * callint.c (syms_of_callint):
4657 * casefiddle.c (syms_of_casefiddle):
4658 * casetab.c (init_casetab_once):
4659 * category.c (init_category_once, syms_of_category):
4660 * ccl.c (syms_of_ccl):
4661 * cmds.c (syms_of_cmds):
4662 * composite.c (syms_of_composite):
4663 * dbusbind.c (syms_of_dbusbind):
4664 * dired.c (syms_of_dired):
4665 * dispnew.c (syms_of_display):
4666 * doc.c (syms_of_doc):
4667 * editfns.c (syms_of_editfns):
4668 * emacs.c (syms_of_emacs):
4669 * eval.c (syms_of_eval):
4670 * fileio.c (syms_of_fileio):
4671 * fns.c (syms_of_fns):
4672 * frame.c (syms_of_frame):
4673 * fringe.c (syms_of_fringe):
4674 * insdel.c (syms_of_insdel):
4675 * keymap.c (syms_of_keymap):
4676 * lread.c (init_obarray, syms_of_lread):
4677 * macros.c (syms_of_macros):
4678 * msdos.c (syms_of_msdos):
4679 * print.c (syms_of_print):
4680 * process.c (syms_of_process):
4681 * search.c (syms_of_search):
4682 * sound.c (syms_of_sound):
4683 * syntax.c (init_syntax_once, syms_of_syntax):
4684 * terminal.c (syms_of_terminal):
4685 * textprop.c (syms_of_textprop):
4686 * undo.c (syms_of_undo):
4687 * w32.c (globals_of_w32):
4688 * window.c (syms_of_window):
4689 * xdisp.c (syms_of_xdisp):
4690 * xfaces.c (syms_of_xfaces):
4691 * xfns.c (syms_of_xfns):
4692 * xmenu.c (syms_of_xmenu):
4693 * xsettings.c (syms_of_xsettings):
4694 * xterm.c (syms_of_xterm): Use DEFSYM.
4695
4228cf16
TZ
46962011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4697
cd3520a4 4698 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4699
7fcccf1e
PE
47002011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4701
7efb4e0e
PE
4702 Integer and buffer overflow fixes (Bug#8873).
4703
ff5844ad
PE
4704 * print.c (printchar, strout): Check for string overflow.
4705 (PRINTPREPARE, printchar, strout):
4706 Don't set size unless allocation succeeds.
4707
90532f02
PE
4708 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4709 for sizes. Check for string overflow more accurately.
4710 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4711
6d84508d
PE
4712 * macros.c: Integer and buffer overflow fixes.
4713 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4714 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4715 Use ptrdiff_t, not int, for sizes.
4716 Don't increment bufsize until after realloc succeeds.
4717 Check for size-calculation overflow.
4718 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4719
437b2cb4
PE
4720 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4721
8b9ac8b4
PE
4722 * lread.c: Integer overflow fixes.
4723 (read_integer): Radix is now EMACS_INT, not int,
4724 to improve quality of diagnostics for out-of-range radices.
4725 Calculate buffer size correctly for out-of-range radices.
4726 (read1): Check for integer overflow in radices, and in
4727 read-circle numbers.
82cb60d3
PE
4728 (read_escape): Avoid int overflow.
4729 (Fload, openp, read_buffer_size, read1)
4730 (substitute_object_recurse, read_vector, read_list, map_obarray):
4731 Use ptrdiff_t, not int, for sizes.
4732 (read1): Use EMACS_INT, not int, for sizes.
20270765 4733 Check for size overflow.
8b9ac8b4 4734
7fcccf1e
PE
4735 * image.c (cache_image): Check for size arithmetic overflow.
4736
bfbbd7e7
PE
4737 * lread.c: Integer overflow issues.
4738 (saved_doc_string_size, saved_doc_string_length)
4739 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4740 Now ptrdiff_t, not int.
4741 (read1): Don't assume doc string length fits in int. Check for
4742 out-of-range doc string lengths.
4743 (read_list): Don't assume file position fits in int.
39019e54 4744 (read_escape): Check for hex character overflow.
bfbbd7e7 4745
4e323265
LL
47462011-06-22 Leo Liu <sdl.web@gmail.com>
4747
4748 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4749 Move to minibuffer.el.
4750
85fece3e
PE
47512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4752
20b84ce9 4753 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4754 The following patches are for when GLYPH_DEBUG && !XASSERT.
4755 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4756 * dispnew.c (flush_stdout):
4757 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4758 Mark as externally visible.
4759 * dispnew.c (check_window_matrix_pointers): Now static.
4760 * dispnew.c (window_to_frame_vpos):
4761 * xfns.c (unwind_create_frame):
4762 * xterm.c (x_check_font): Remove unused local.
4763 * scroll.c (CHECK_BOUNDS):
4764 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4765 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4766 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4767 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4768 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4769 Now static.
4770 (debug_method_add): Use va_list and vsprintf rather than relying
4771 on undefined behavior with wrong number of arguments.
4772 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4773 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4774 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4775 since we're not interested in debugging glyphs with old libraries.
4776 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4777 GCC 4.6.0's static checking.
4778
0766b489
PE
47792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4780
31fd4b32
PE
4781 Integer overflow and signedness fixes (Bug#8873).
4782 A few related buffer overrun fixes, too.
4783
b79e8648
PE
4784 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4785
0766b489
PE
4786 * dispextern.h (struct face.stipple):
4787 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4788 (x_bitmap_mask, x_allocate_bitmap_record)
4789 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4790 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4791 (x_create_bitmap_from_xpm_data):
4792 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4793 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4794 (.bitmaps_last):
4795 * xfaces.c (load_pixmap):
4796 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4797 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4798 (.bitmaps_last, struct x_output.icon_bitmap):
4799 Use ptrdiff_t, not int, for bitmap indexes.
4800 (x_allocate_bitmap_record): Check for size overflow.
4801 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4802
b081724f
PE
4803 Use ptrdiff_t, not int, for overlay counts.
4804 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4805 * editfns.c (overlays_around, get_pos_property):
4806 * textprop.c (get_char_property_and_overlay):
4807 * xdisp.c (next_overlay_change, note_mouse_highlight):
4808 * xfaces.c (face_at_buffer_position):
21514da7
PE
4809 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4810 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4811 (Fnext_overlay_change, Fprevious_overlay_change)
4812 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4813 Use ptrdiff_t, not int, for sizes.
21514da7 4814 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4815
3de73e5e
PE
4816 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4817
2606c57b
PE
4818 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4819 (x_session_initialize): Do not assume string length fits in int.
4820
aaafe47a
PE
4821 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4822 This is unlikely, but can occur if DPI is outlandish.
4823
2674ddc8 4824 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4825 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4826
28154962
PE
4827 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4828 * xrdb.c (magic_file_p, search_magic_path):
4829 Omit last arg SUFFIX; it was always 0. All callers changed.
4830 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4831
7de51af5
PE
4832 * xfont.c (xfont_match): Avoid need for strlen.
4833
25ed6cc3
PE
4834 * xfns.c: Don't assume strlen fits in int.
4835 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4836
4eab31dd
PE
4837 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4838 not unsigned long, as we prefer signed integers. All callers changed.
4839 Detect integer overflow in repeat count.
4840 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4841 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4842
171e2a58
PE
4843 * termcap.c: Don't assume sizes fit in int and never overflow.
4844 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4845 (gobble_line): Check for size-calculation overflow.
4846
ad39faca 4847 * minibuf.c (Fread_buffer):
6e5bb2dc 4848 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4849 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4850 Don't assume string length fits in int.
4851
52c61c22 4852 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4853 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4854
b5b8c9e5
PE
4855 * font.c: Don't assume string length fits in int.
4856 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4857 Use ptrdiff_t, not int.
ccd6111c
PE
4858 (font_intern_prop): Don't assume string length fits in int.
4859 Don't assume integer property fits in fixnum.
4860 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4861
882f0d81 4862 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4863 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4864 Reformulate so as not to need the command string.
4865 Invoke gzip -cd rather than gunzip, as it's more portable.
4866 (lock_info_type, lock_file_1, lock_file):
4867 Don't assume pid_t and time_t fit in unsigned long.
4868 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4869 (current_lock_owner): Prefer signed type for sizes.
4870 Use memcpy, not strncpy, where memcpy is what is really wanted.
4871 Don't assume (via atoi) that time_t and pid_t fit in int.
4872 Check for time_t and/or pid_t out of range, e.g., via a network share.
4873 Don't alloca where an auto var works fine.
4874
93f4cf88
PE
4875 * fileio.c: Fix some integer overflow issues.
4876 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4877 Don't assume string length fits in int.
4878 (directory_file_name): Don't assume string length fits in long.
4879 (make_temp_name): Don't assume pid fits in int, or that its print
4880 length is less than 20.
4881
f3e92b69
PE
4882 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4883
1bfdaf10
PE
4884 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4885
35016e9a
PE
4886 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4887
3d1e65a1
PE
4888 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4889 We prefer signed integers, even for size calculations.
4890
0b963a93
PE
4891 * emacs.c: Don't assume string length fits in 'int'.
4892 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4893 (main): Don't invoke strlen when not needed.
4894
573f4b54
PE
4895 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4896 (XD_DEBUG_MESSAGE): Don't waste a byte.
4897
989f33ba
PE
4898 * callproc.c (getenv_internal_1, getenv_internal)
4899 (Fgetenv_internal):
965d34eb
PE
4900 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4901
e4d29b33
PE
4902 * lread.c (invalid_syntax): Omit length argument.
4903 All uses changed. This doesn't fix a bug, but it simplifies the
4904 code away from its former Hollerith-constant appearance, and it's
4905 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4906 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4907
eb49b136
PE
4908 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4909 This didn't break anything, but it didn't help either.
4910 It's confusing to put a bogus integer in a place where the actual
4911 value does not matter.
9f62aeb1 4912 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4913 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4914
15375a22
PE
4915 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4916 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4917 implementation.
b61cc01c
PE
4918 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4919 We prefer signed types, and the value cannot exceed the EMACS_INT
4920 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4921 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4922 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4923 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4924
53b2623d
PE
4925 * indent.c (sane_tab_width): New function.
4926 (current_column, scan_for_column, Findent_to, position_indentation)
4927 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4928 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4929
51cab52b 4930 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4931
f2ed8a70
PE
4932 * lisp.h (lint_assume): New macro.
4933 * composite.c (composition_gstring_put_cache):
4934 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4935
abe80cc6
PE
4936 * editfns.c, insdel.c:
4937 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4938
b02c740e
PE
4939 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4940
ebc96716
PE
4941 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4942
b4e50fa0 4943 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4944 Use much-faster test for byte-length change.
311d5d7c 4945 Don't assume string byte-length fits in 'int'.
a4cf38e4 4946 Check that character arg fits in 'int'.
85461888 4947 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4948
c0c1ee9f
PE
4949 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4950
a498d7f4
PE
4951 * fns.c (concat): Catch string overflow earlier.
4952 Do not rely on integer wraparound.
4953
51cab52b
PE
4954 * dispextern.h (struct it.overlay_strings_charpos)
4955 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4956 * xdisp.c (forward_to_next_line_start)
4957 (back_to_previous_visible_line_start)
4958 (reseat_at_next_visible_line_start, next_element_from_buffer):
4959 Don't arbitrarily truncate the value of 'selective' to int.
4960
76031fad
PE
4961 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4962
5eb55db9
PE
4963 * composite.c: Don't truncate sizes to 'int'.
4964 (composition_gstring_p, composition_reseat_it)
4965 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4966 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4967 not EMACS_UINT, for indexes.
5eb55db9 4968
0703a717
PE
4969 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4970
d6202519
PE
4971 * buffer.c: Include <verify.h>.
4972 (struct sortvec.priority, struct sortstr.priority):
8961a454 4973 Now EMACS_INT, not int.
c20998a7 4974 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4975 (struct sortstr.size, record_overlay_string)
4976 (struct sortstrlist.size, struct sortlist.used):
4977 Don't truncate size to int.
4978 (record_overlay_string): Check for size-calculation overflow.
d6202519 4979 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4980
d5a19415
JM
49812011-06-22 Jim Meyering <meyering@redhat.com>
4982
029529ac 4983 Don't leak an XBM-image-sized buffer
d5a19415
JM
4984 * image.c (xbm_load): Free the image buffer after using it.
4985
a9041e6c
PE
49862011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4987
4988 Port to Sun C.
4989 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4990 that Sun C diagnosed.
4991 * fns.c (secure_hash): Fix pointer signedness issue.
4992 * intervals.c (static_offset_intervals): New function.
4993 (offset_intervals): Use it.
4994
7f3f739f
LL
49952011-06-21 Leo Liu <sdl.web@gmail.com>
4996
4997 * deps.mk (fns.o):
4998 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4999 sha512.h.
5000
5001 * fns.c (secure_hash): Rename from crypto_hash_function and change
5002 the first arg to accept symbols.
5b66d427 5003 (Fsecure_hash): New primitive.
7f3f739f
LL
5004 (syms_of_fns): New symbols.
5005
76147d94
DD
50062011-06-20 Deniz Dogan <deniz@dogan.se>
5007
5008 * process.c (Fset_process_buffer): Clarify return value in
5009 docstring.
5010
7d7d0045
CY
50112011-06-18 Chong Yidong <cyd@stupidchicken.com>
5012
5013 * dispnew.c (add_window_display_history): Use BVAR.
5014
5015 * xdisp.c (debug_method_add): Use BVAR.
5016 (check_window_end, dump_glyph_matrix, dump_glyph)
5017 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5018
5019 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5020 Likewise.
5021
5022 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5023 check till after the cache is created in init_frame_faces.
5024
ff2bc410
SM
50252011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5026
5027 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5028
28177add
PE
50292011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5030
dd3482fe
PE
5031 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5032 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5033 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5034
393d71f3 5035 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5036 * fileio.c (Finsert_file_contents):
5037 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5038 Remove the old (too-loose) buffer overflow checks.
5039 They weren't needed, since make_gap checks for buffer overflow.
5040 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5041 The old code merely checked for Emacs fixnum overflow, and relied
5042 on undefined (wraparound) behavior. The new code avoids undefined
5043 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5044
2e6813b0 5045 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5046 Tune. Don't use wider integers than needed. Don't use alloca.
5047 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5048
599a9e4f
PE
5049 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5050
99561444
PE
5051 * insdel.c, lisp.h (buffer_overflow): New function.
5052 (insert_from_buffer_1, replace_range, replace_range_2):
5053 * insdel.c (make_gap_larger):
5054 * editfns.c (Finsert_char):
5055 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5056
28177add
PE
5057 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5058
e69dafad
PE
50592011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5060
4baa020d 5061 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5062
b1c46f02
PE
5063 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5064 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5065
e69dafad
PE
5066 * fileio.c: Don't assume EMACS_INT fits in off_t.
5067 (emacs_lseek): New static function.
5068 (Finsert_file_contents, Fwrite_region): Use it.
5069 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5070
566684ea
PE
5071 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5072
e6966cd6
PE
5073 * fns.c: Don't overflow int when computing a list length.
5074 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5075 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5076 truncation on 64-bit hosts. Check for QUIT every
5077 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5078 faster and is responsive enough.
5079 (Flength): Report an error instead of overflowing an integer.
5080 (Fsafe_length): Return a float if the value is not representable
5081 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5082 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5083 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5084
dd0b0efb
PE
5085 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5086 (header_size, word_size): New constants.
5087 (allocate_vectorlike): Don't check size overflow here.
5088 (allocate_vector): Check it here instead, since this is the only
5089 caller of allocate_vectorlike that could cause overflow.
5090 Check that the new vector's length is representable as a fixnum.
5091
86fe5cfe
PE
5092 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5093 The previous code was bogus. For example, next_almost_prime (32)
5094 returned 39, which is undesirable as it is a multiple of 3; and
5095 next_almost_prime (24) returned 25, which is a multiple of 5 so
5096 why was the code bothering to check for multiples of 7?
5097
80e88859
PE
5098 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5099
4a2f0ad6
PE
5100 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5101
f66c7cf8
PE
5102 Variadic C functions now count arguments with ptrdiff_t.
5103 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5104 Back then I didn't know that the Emacs coding style prefers signed int.
5105 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5106 were being counted with int, which may truncate counts on 64-bit
5107 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5108 * lisp.h (struct Lisp_Subr.function.aMANY)
5109 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5110 Arg counts are now ptrdiff_t, not size_t.
5111 All variadic functions and their callers changed accordingly.
5112 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5113 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5114 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5115 * callint.c (Fcall_interactively): Check arg count for overflow,
5116 to avoid potential buffer overrun. Use signed char, not 'int',
5117 for 'varies' array, so that we needn't bother to check its size
5118 calculation for overflow.
5119 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5120 * eval.c (apply_lambda):
5121 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5122 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5123 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5124
a1759b76
PE
5125 * callint.c (Fcall_interactively): Don't use index var as event count.
5126
d96be9fc
PE
5127 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5128 * mem-limits.h (SIZE): Remove; no longer used.
5129
a690a978 5130 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5131
578c21e6
PE
5132 Remove unnecessary casts.
5133 * xterm.c (x_term_init):
5134 * xfns.c (x_set_border_pixel):
5135 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5136 These aren't needed now that we assume ANSI C.
5137
96f53c6c
PE
5138 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5139 It's more likely to cause problems (due to unsigned overflow)
5140 than to cure them.
5141
83c77d31
PE
5142 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5143
ee2079f1
PE
5144 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5145
6da65536
PE
5146 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5147
7147c4a4
PE
5148 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5149
193e32d9
PE
5150 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5151
e5533da6
PE
5152 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5153
9910e595
PE
5154 GLYPH_CODE_FACE returns EMACS_INT, not int.
5155 * dispextern.h (merge_faces):
5156 * xfaces.c (merge_faces):
01103c44
PE
5157 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5158 Don't assume EMACS_INT fits in int.
9910e595 5159
2638320e
PE
5160 * character.h (CHAR_VALID_P): Remove unused parameter.
5161 * fontset.c, lisp.h, xdisp.c: All uses changed.
5162
045eb8d9
PE
5163 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5164
c1f134b5
PE
5165 * fns.c (concat): Minor tuning based on overflow analysis.
5166 This doesn't fix any bugs. Use int to hold character, instead
5167 of constantly refetching from Emacs object. Use XFASTINT, not
5168 XINT, for value known to be a character. Don't bother comparing
5169 a single byte to 0400, as it's always less.
5170
395fcb93 5171 * floatfns.c (Fexpt):
327eeec8
PE
5172 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5173
abbd3d23
PE
5174 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5175 for characters.
5176
684a03ef
PE
5177 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5178
0fed43f3
PE
5179 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5180 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5181 incorrectly succeed when S was a string, because 4294967386 was
5182 truncated before it was used.
5183
8fd02eb7
PE
5184 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5185 Otherwise, an out-of-range integer could cause undefined behavior
5186 on a 64-bit host.
5187
f8c86b69
PE
5188 * composite.c: Use int, not EMACS_INT, for characters.
5189 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5190 EMACS_INT, for values that are known to be in character range.
5191 This doesn't fix any bugs but is the usual style inside Emacs and
5192 may generate better code on 32-bit machines.
5193
34206dd2
PE
5194 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5195 This is for reasons similar to the recent CHAR_STRING fix.
5196 * charset.c (Fencode_char): Check that character arg is actually
5197 a character. Pass an int to ENCODE_CHAR.
5198 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5199 wider than 'int', as a compile-time check to prevent future regressions
5200 in this area.
5201
c5958d4c 5202 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5203
5204 Make sure a 64-bit char is never passed to CHAR_STRING.
5205 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5206 by silently ignoring the top 32 bits, allowing some values
5207 that were far too large to be valid characters.
5208 * character.h: Include <verify.h>.
5209 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5210 arguments are no wider than unsigned, as a compile-time check
5211 to prevent future regressions in this area.
5212 * data.c (Faset):
01103c44 5213 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5214 (Fsubst_char_in_region):
5215 * fns.c (concat):
5216 * xdisp.c (decode_mode_spec_coding):
5217 Adjust to CHAR_STRING's new requirement.
5218 * editfns.c (Finsert_char, Fsubst_char_in_region):
5219 * fns.c (concat): Check that character args are actually
5220 characters. Without this test, these functions did the wrong
5221 thing with wildly out-of-range values on 64-bit hosts.
5222
d37ca623
PE
5223 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5224 These casts should not be needed on 32-bit hosts, either.
5225 * keyboard.c (read_char):
5226 * lread.c (Fload): Remove casts to unsigned.
5227
ea204efb
PE
5228 * lisp.h (UNSIGNED_CMP): New macro.
5229 This fixes comparison bugs on 64-bit hosts.
5230 (ASCII_CHAR_P): Use it.
5231 * casefiddle.c (casify_object):
01103c44 5232 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5233 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5234 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5235 * dispextern.h (FACE_FROM_ID):
5236 * keyboard.c (read_char): Use UNSIGNED_CMP.
5237
41cb286c
PE
5238 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5239 not to EMACS_INT, to avoid GCC warning.
5240
4a1b9832
PE
5241 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5242
55daad71
PE
5243 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5244 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5245 isn't needed on 32-bit machines.
8f95c75c 5246
01103c44
PE
5247 * buffer.c (Fgenerate_new_buffer_name):
5248 Use EMACS_INT for count, not int.
0ceccced 5249 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5250
5251 * data.c (Qcompiled_function): Now static.
5252
c6f072e7
PE
5253 * window.c (window_body_lines): Now static.
5254
20ce5912
PE
5255 * image.c (gif_load): Rename local to avoid shadowing.
5256
9c4c5f81
PE
5257 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5258 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5259 * alloc.c (make_save_value): Integer argument is now of type
5260 ptrdiff_t, not int.
5261 (mark_object): Use ptrdiff_t, not int.
5262 * lisp.h (pD): New macro.
5263 * print.c (print_object): Use it.
5264
c0c5c8ae
PE
5265 * alloc.c: Use EMACS_INT, not int, to count objects.
5266 (total_conses, total_markers, total_symbols, total_vector_size)
5267 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5268 (total_free_floats, total_floats, total_free_intervals)
5269 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5270 Now EMACS_INT, not int. All uses changed.
5271 (Fgarbage_collect): Compute overall total using a double, so that
5272 integer overflow is less likely to be a problem. Check for overflow
5273 when converting back to an integer.
5a25e253
PE
5274 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5275 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5276 These were 'int' variables that could overflow on 64-bit hosts;
5277 they were never used, so remove them instead of repairing them.
211a0b2a 5278 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5279 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5280 Previously, this ceilinged at INT_MAX, but that doesn't work on
5281 64-bit machines.
e46bb31a 5282 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5283
c78baabf 5284 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5285 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5286 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5287 when a (possibly-narrower) signed value would do just as well.
5288 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5289
c9d624c6
PE
5290 * alloc.c: Catch some string size overflows that we were missing.
5291 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5292 for convenience in STRING_BYTES_MAX.
5293 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5294 The definition here is exact; the one in lisp.h was approximate.
5295 (allocate_string_data): Check for string overflow. This catches
5296 some instances we weren't catching before. Also, it catches
5297 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5298 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5299 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5300
c9d624c6
PE
5301 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5302 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5303 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5304
353032ce
PE
5305 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5306
2bccce07
PE
5307 * alloc.c (Fmake_string): Check for out-of-range init.
5308
0ac30604
SM
53092011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5310
5311 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5312
c195f2de
JD
53132011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5314
5315 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5316 xg_get_default_scrollbar_width.
5317
5318 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5319 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5320 (style_changed_cb): Call update_theme_scrollbar_width and call
5321 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5322 all frames (Bug#8505).
5323 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5324 Call gtk_window_set_resizable if HAVE_GTK3.
5325 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5326 and height if HAVE_GTK3 (Bug#8505).
5327 (scroll_bar_width_for_theme): New variable.
5328 (update_theme_scrollbar_width): New function.
5329 (xg_get_default_scrollbar_width): Move code to
5330 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5331 (xg_initialize): Call update_theme_scrollbar_width.
5332
5333 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5334
5335 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5336
e10ac9f1
MR
53372011-06-12 Martin Rudalics <rudalics@gmx.at>
5338
5339 * frame.c (make_frame): Call other_buffer_safely instead of
5340 other_buffer.
5341
5342 * window.c (temp_output_buffer_show): Call display_buffer with
5343 second argument Vtemp_buffer_show_specifiers and reset latter
5344 immediately after the call.
5345 (Vtemp_buffer_show_specifiers): New variable.
5346 (auto_window_vscroll_p, next_screen_context_lines)
5347 (Vscroll_preserve_screen_position): Remove leading asterisks from
5348 doc-strings.
5349
2d3c217e 53502011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5351
7b7f97e8 5352 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5353 * buffer.c (Qclone_number): Remove for now, as it's unused.
5354 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5355 (record_buffer): Remove unused local.
5356 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5357 (set_frame_buffer_list): Remove; unused.
5358 * frame.h (other_visible_frames): Remove decl.
5359 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5360 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5361 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5362 if HAVE_GPM.
5363 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5364 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5365 Define only if HAVE_GPM.
5366 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5367 (update_hints_inhibit): Remove; never set. All uses removed.
5368 * widgetprv.h (emacsFrameClassRec): Remove decl.
5369 * window.c (delete_deletable_window): Now returns void, since it
5370 wasn't returning anything.
5371 (compare_window_configurations): Remove unused locals.
5372 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5373 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5374 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5375 the same widths as pointers. This follows up on the 2011-05-06 patch.
5376 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5377 * xterm.h: Likewise.
5378 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5379
1384b89e
JB
53802011-06-12 Juanma Barranquero <lekktu@gmail.com>
5381
5382 * makefile.w32-in: Update dependencies.
5383 (LISP_H): Add lib/intprops.h.
5384
1100a63c
CY
53852011-06-11 Chong Yidong <cyd@stupidchicken.com>
5386
5387 * image.c (gif_load): Add animation frame delay to the metadata.
5388 (syms_of_image): Use DEFSYM. New symbol `delay'.
5389
6198ccd0
MR
53902011-06-11 Martin Rudalics <rudalics@gmx.at>
5391
5392 * window.c (delete_deletable_window): Re-add.
5393 (Fset_window_configuration): Rewrite to handle dead buffers and
5394 consequently deletable windows.
5395 (window_tree, Fwindow_tree): Remove. Supply functionality in
5396 window.el.
5397 (compare_window_configurations): Simplify code.
5398
b6e3633c
AS
53992011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5400
1ab0dee5
AS
5401 * image.c (imagemagick_load_image): Fix type mismatch.
5402 (Fimagemagick_types): Likewise.
5403
b6e3633c
AS
5404 * window.h (replace_buffer_in_windows): Declare.
5405
9397e56f
MR
54062011-06-11 Martin Rudalics <rudalics@gmx.at>
5407
5408 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5409 Qclone_number. Remove external declaration of Qdelete_window.
5410 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5411 code.
640c8776
SM
5412 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5413 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5414 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5415 buffer list implementation.
5416 (other_buffer_safely): New function.
5417 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5418 calls to replace_buffer_in_windows and
5419 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5420 if allowed.
5421 (record_buffer): Inhibit quitting and rewrite using quittable
5422 functions. Run Qbuffer_list_update_hook if allowed.
5423 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5424 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5425 Move switch-to-buffer to window.el.
9397e56f
MR
5426 (bury-buffer): Move to window.el.
5427 (Vbuffer_list_update_hook): New variable.
5428
5429 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5430 section.
5431
5432 * window.h (resize_frame_windows): Move up in code.
5433 (Fwindow_frame): Remove EXFUN.
5434 (replace_buffer_in_all_windows): Remove prototype.
5435 (replace_buffer_in_windows_safely): Add prototype.
5436
5437 * window.c: Declare Qdelete_window static again. Move down
5438 declaration of select_count.
5439 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5440 (Fother_window): Move to window.el.
5441 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5442 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5443 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5444 window.el.
5445 (replace_buffer_in_windows): Implement by calling
5446 Qreplace_buffer_in_windows.
5447 (replace_buffer_in_all_windows): Remove with some functionality
5448 moved into replace_buffer_in_windows_safely.
5449 (replace_buffer_in_windows_safely): New function.
5450 (select_window_norecord, select_frame_norecord): Move in front
5451 of run_window_configuration_change_hook. Remove now obsolete
5452 declarations.
640c8776
SM
5453 (Fset_window_buffer): Rewrite doc-string.
5454 Call Qrecord_window_buffer.
9397e56f
MR
5455 (keys_of_window): Move binding for other-window to window.el.
5456
b50691aa
CY
54572011-06-11 Chong Yidong <cyd@stupidchicken.com>
5458
5459 * dispextern.h (struct image): Replace data member, whose int_val
5460 and ptr_val fields were not used by anything, with a single
5461 lisp_val object.
5462
5463 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5464 (gif_clear_image, gif_load, imagemagick_load_image)
5465 (gs_clear_image, gs_load): Callers changed.
5466
3f754b86
PE
54672011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5468
cca69397
PE
5469 * buffer.h: Include <time.h>, for time_t.
5470 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5471
109e28d0
PE
5472 Fix minor problems found by static checking.
5473
60737f02
PE
5474 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5475
4b66faf3
PE
5476 Make identifiers static if they are not used in other modules.
5477 * data.c (Qcompiled_function, Qframe, Qvector):
5478 * image.c (QimageMagick, Qsvg):
5479 * minibuf.c (Qmetadata):
5480 * window.c (resize_window_check, resize_root_window): Now static.
5481 * window.h (resize_window_check, resize_root_window): Remove decls.
5482
109e28d0
PE
5483 * window.c (window_deletion_count, delete_deletable_window):
5484 Remove; unused.
46a4ce9e
PE
5485 (window_body_lines): Now static.
5486 (Fdelete_other_windows_internal): Mark vars as initialized.
5487 Make sure 'resize_failed' is initialized.
5488 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5489 (resize_window_apply): Remove unused local.
5490 * window.h (delete_deletable_window): Remove decl.
5491
109e28d0 5492 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5493 (imagemagick_load_image): Fix pointer signedness problem by changing
5494 last arg from unsigned char * to char *. All uses changed.
5495 Also, fix a local for similar reasons.
5496 Remove unused locals. Remove locals to avoid shadowing.
5497 (fn_rsvg_handle_free): Remove; unused.
5498 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5499 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5500
3f754b86
PE
5501 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5502
2547adb1
CY
55032011-06-10 Chong Yidong <cyd@stupidchicken.com>
5504
5505 * image.c (gif_load): Fix omitted cast error introduced by
5506 2011-06-06 change.
5507
2c8e37d4
MR
55082011-06-10 Martin Rudalics <rudalics@gmx.at>
5509
5510 * window.h (resize_proportionally, orig_total_lines)
5511 (orig_top_line): Remove from window structure.
5512 (set_window_height, set_window_width, change_window_heights)
5513 (Fdelete_window): Remove prototypes.
5514 (resize_frame_windows): Remove duplicate declaration.
5515
440a42e3
EZ
55162011-06-10 Eli Zaretskii <eliz@gnu.org>
5517
5518 * window.h (resize_frame_windows, resize_window_check)
5519 (delete_deletable_window, resize_root_window)
5520 (resize_frame_windows): Declare prototypes.
5521
5522 * window.c (resize_window_apply): Make definition be "static" to
5523 match the prototype.
5524
562dd5e9
MR
55252011-06-10 Martin Rudalics <rudalics@gmx.at>
5526
5527 * window.c: Remove declarations of Qwindow_size_fixed,
5528 window_min_size_1, window_min_size_2, window_min_size,
5529 size_window, window_fixed_size_p, enlarge_window, delete_window.
5530 Remove static from declaration of Qdelete_window, it's
5531 temporarily needed by Fbury_buffer.
5532 (replace_window): Don't assign orig_top_line and
5533 orig_total_lines.
5534 (Fdelete_window, delete_window): Remove. Window deletion is
5535 handled by window.el.
640c8776
SM
5536 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5537 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5538 (Fdelete_other_windows): Remove. Deleting other windows is
5539 handled by window.el.
5540 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5541 handled in window.el.
5542 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5543 Window minimum sizes are handled in window.el.
5544 (shrink_windows, size_window, set_window_height)
5545 (set_window_width, change_window_heights, window_height)
5546 (window_width, CURBEG, CURSIZE, enlarge_window)
5547 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5548 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5549 handled in window.el.
5550 (make_dummy_parent): Rename to make_parent_window and give it a
5551 second argument horflag.
5552 (make_window): Don't set resize_proportionally any more.
5553 (Fsplit_window): Remove. Windows are split in window.el.
5554 (save_restore_action, save_restore_orig_size)
5555 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5556 Resize mini windows in window.el.
5557 (grow_mini_window, shrink_mini_window): Implement by calling
5558 Qresize_root_window_vertically, resize_window_check and
5559 resize_window_apply.
640c8776
SM
5560 (saved_window, Fset_window_configuration, save_window_save):
5561 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5562 resize_proportionally.
5563 (window_min_height, window_min_width): Move to window.el.
5564 (keys_of_window): Move bindings for delete-other-windows,
5565 split-window, delete-window and enlarge-window to window.el.
5566
5567 * buffer.c: Temporarily extern Qdelete_window.
5568 (Fbury_buffer): Temporarily call Qdelete_window instead of
5569 Fdelete_window (Fbury_buffer will move to window.el soon).
5570
5571 * frame.c (set_menu_bar_lines_1): Remove code handling
5572 orig_top_line and orig_total_lines.
5573
5574 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5575 set_window_height but set heights directly.
5576 (change_frame_size_1): Use resize_frame_windows.
5577
5578 * xdisp.c (init_xdisp): Don't use set_window_height but set
5579 heights directly.
5580
640c8776
SM
5581 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5582 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5583 run_window_configuration_change_hook.
5584
5585 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5586 instead of change_window_heights and run
5587 run_window_configuration_change_hook.
5588
1a13852e
MR
55892011-06-09 Martin Rudalics <rudalics@gmx.at>
5590
5591 * window.c (replace_window): Rename second argument REPLACEMENT to
5592 NEW. New third argument SETFLAG. Rewrite.
5593 (delete_window, make_dummy_parent): Call replace_window with
5594 third argument 1.
5595 (window_list_1): Move down in code.
5596 (run_window_configuration_change_hook): Move set_buffer part
5597 before select_frame_norecord part in order to unwind correctly.
5598 Rename count1 to count.
5599 (recombine_windows, delete_deletable_window, resize_root_window)
5600 (Fdelete_other_windows_internal)
5601 (Frun_window_configuration_change_hook, make_parent_window)
5602 (resize_window_check, resize_window_apply, Fresize_window_apply)
5603 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5604 (Fdelete_window_internal, Fresize_mini_window_internal):
5605 New functions.
1a13852e
MR
5606 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5607
f3d1777e
MR
56082011-06-08 Martin Rudalics <rudalics@gmx.at>
5609
496e208e
MR
5610 * window.h (window): Add some new members to window structure -
5611 normal_lines, normal_cols, new_total, new_normal, clone_number,
5612 splits, nest, prev_buffers, next_buffers.
5613 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5614 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5615
f3d1777e
MR
5616 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5617 Remove.
496e208e
MR
5618 (make_dummy_parent): Set new members of windows structure.
5619 (make_window): Move down in code. Handle new members of window
5620 structure.
5621 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5622 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5623 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5624 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5625 (Fset_window_next_buffers, Fset_window_clone_number):
5626 New functions.
496e208e
MR
5627 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5628 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5629 Doc-string fixes.
5630 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5631 Argument WINDOW can be now internal window too.
5632 (Fwindow_use_time): Move up in code.
5633 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5634 Rewrite doc-string.
5635 (Fset_window_configuration, saved_window)
5636 (Fcurrent_window_configuration, save_window_save): Handle new
5637 members of window structure.
b9e809c2
MR
5638 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5639 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5640 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5641 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5642 Qget_mru_window, Qresize_root_window,
5643 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5644 Qauto_buffer_name; staticpro them.
f3d1777e 5645
abde8f8c
MR
56462011-06-07 Martin Rudalics <rudalics@gmx.at>
5647
5648 * window.c (Fwindow_total_size, Fwindow_left_column)
5649 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5650 (Fwindow_list_1): New functions.
5651 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5652 (Fwindow_width, Fscroll_left, Fscroll_right):
5653 Use window_body_cols instead of window_box_text_cols.
5654 (delete_window, Fset_window_configuration):
5655 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5656 (delete_all_subwindows): Take a window as argument and not a
5657 structure. Rewrite.
190b47e6
MR
5658 (window_loop): Remove handling of GET_LRU_WINDOW and
5659 GET_LARGEST_WINDOW.
5660 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5661
5662 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5663 window_box_text_cols. delete_all_subwindows now takes a
5664 Lisp_Object as argument.
abde8f8c 5665
640c8776
SM
5666 * indent.c (compute_motion, Fcompute_motion):
5667 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5668
fa8a67e6
MR
5669 * frame.c (delete_frame): Call delete_all_subwindows with root
5670 window as argument.
5671
a54e3482
DC
56722011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5673
5674 * fns.c (Fputhash): Document return value.
5675
60002bf5
CY
56762011-06-06 Chong Yidong <cyd@stupidchicken.com>
5677
5678 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5679
0c671da6 56802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5681
b862a52a 5682 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5683
be44ca6c
PE
5684 Check for overflow when converting integer to cons and back.
5685 * charset.c (Fdefine_charset_internal, Fdecode_char):
5686 Use cons_to_unsigned to catch overflow.
5687 (Fencode_char): Use INTEGER_TO_CONS.
5688 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5689 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5690 * data.c (long_to_cons, cons_to_long): Remove.
5691 (cons_to_unsigned, cons_to_signed): New functions.
5692 These signal an error for invalid or out-of-range values.
5693 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5694 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5695 * font.c (Ffont_variation_glyphs):
5696 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5697 * lisp.h: Include <intprops.h>.
5698 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5699 (cons_to_signed, cons_to_unsigned): New decls.
5700 (long_to_cons, cons_to_long): Remove decls.
5701 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5702 (Fprimitive_undo): Use CONS_TO_INTEGER.
5703 * xfns.c (Fx_window_property): Likewise.
5704 * xselect.c: Include <limits.h>.
5705 (x_own_selection, selection_data_to_lisp_data):
5706 Use INTEGER_TO_CONS.
5707 (x_handle_selection_request, x_handle_selection_clear)
5708 (x_get_foreign_selection, Fx_disown_selection_internal)
5709 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5710 (lisp_data_to_selection_data): Use cons_to_unsigned.
5711 (x_fill_property_data): Use cons_to_signed.
5712 Report values out of range.
5713
d1f3d2af
PE
5714 Check for buffer and string overflow more precisely.
5715 * buffer.h (BUF_BYTES_MAX): New macro.
5716 * lisp.h (STRING_BYTES_MAX): New macro.
5717 * alloc.c (Fmake_string):
5718 * character.c (string_escape_byte8):
5719 * coding.c (coding_alloc_by_realloc):
5720 * doprnt.c (doprnt):
5721 * editfns.c (Fformat):
5722 * eval.c (verror):
5723 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5724 since they may not be the same number.
5725 * editfns.c (Finsert_char):
5726 * fileio.c (Finsert_file_contents):
5727 Likewise for BUF_BYTES_MAX.
5728
dd52fcea
PE
5729 * image.c: Use ptrdiff_t, not int, for sizes.
5730 (slurp_file): Switch from int to ptrdiff_t.
5731 All uses changed.
5732 (slurp_file): Check that file size fits in both size_t (for
5733 malloc) and ptrdiff_t (for sanity and safety).
5734
7f9bbdbb
PE
5735 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5736 if b->modtime has its maximal value.
5737
dfe18f82
PE
5738 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5739
84acfcf0
PE
5740 Don't assume time_t can fit into int.
5741 * buffer.h (struct buffer.modtime): Now time_t, not int.
5742 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5743 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5744
ccd9a01a
PE
5745 Minor fixes for signed vs unsigned integers.
5746 * character.h (MAYBE_UNIFY_CHAR):
5747 * charset.c (maybe_unify_char):
5748 * keyboard.c (read_char, reorder_modifiers):
5749 XINT -> XFASTINT, since the integer must be nonnegative.
5750 * ftfont.c (ftfont_spec_pattern):
5751 * keymap.c (access_keymap, silly_event_symbol_error):
5752 XUINT -> XFASTINT, since the integer must be nonnegative.
5753 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5754 since it makes no difference and we prefer signed.
5755 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5756 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5757 nonnegative.
5758
d6d100dd
SM
57592011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5760
5761 * window.h (Fwindow_frame): Declare.
5762
2b6148e4
PE
57632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5764
5765 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5766 (SPARE_MEMORY): Always define.
5767 (LARGE_REQUEST): Remove.
5768 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5769
f230ecc9
MR
57702011-06-06 Martin Rudalics <rudalics@gmx.at>
5771
727e958e
MR
5772 * lisp.h: Move EXFUNS for Fframe_root_window,
5773 Fframe_first_window and Fset_frame_selected_window to window.h.
5774
5775 * window.h: Move EXFUNS for Fframe_root_window,
5776 Fframe_first_window and Fset_frame_selected_window here from
5777 lisp.h.
5778
5779 * frame.c (Fwindow_frame, Fframe_first_window)
5780 (Fframe_root_window, Fframe_selected_window)
5781 (Fset_frame_selected_window): Move to window.c.
5782 (Factive_minibuffer_window): Move to minibuf.c.
5783 (Fother_visible_frames_p): New function.
5784
5785 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5786
f230ecc9
MR
5787 * window.c (decode_window, decode_any_window): Move up in code.
5788 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5789 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5790 (Fwindow_buffer): Move up and rewrite doc-string.
5791 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5792 (Fwindow_prev): New functions.
727e958e
MR
5793 (Fwindow_frame): Move here from frame.c. Accept any window as
5794 argument.
5795 (Fframe_root_window, Fframe_first_window)
5796 (Fframe_selected_window): Move here from frame.c. Accept frame
5797 or arbitrary window as argument. Update doc-strings.
5798 (Fminibuffer_window): Move up in code.
5799 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5800 (Fset_frame_selected_window): Move here from frame.c.
5801 Marginal rewrite.
727e958e
MR
5802 (Fselected_window, select_window, Fselect_window): Move up in
5803 code. Minor doc-string fixes.
f230ecc9 5804
4d09bcf6
PE
58052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5806
5807 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5808 Do not assume that spare memory exists; that assumption is valid
5809 only if SYSTEM_MALLOC.
5810 (LARGE_REQUEST): New macro, so that the issue of large requests
5811 is separated from the issue of spare memory.
5812
810928a2
AS
58132011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5814
172418ad
AS
5815 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5816 format. (Bug#8806)
5817
43f862f7
AS
5818 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5819
810928a2
AS
5820 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5821 before statements.
5822
a059fe24
JD
58232011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5824
5825 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5826
5827 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5828
5829 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5830 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5831
989bf368
JB
58322011-06-05 Juanma Barranquero <lekktu@gmail.com>
5833
5834 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5835
4b80f674
CY
58362011-06-04 Chong Yidong <cyd@stupidchicken.com>
5837
5838 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5839 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5840 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5841 New error handlers.
4b80f674
CY
5842 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5843 Obey Vx_select_enable_clipboard_manager. Catch errors in
5844 x_clipboard_manager_save (Bug#8779).
5845 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5846 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5847
99a33b77 58482011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5849
5850 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5851
99a33b77 58522011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5853
5854 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5855 in the current matrix if keep_current_p is non-zero.
5856
8264569d
EZ
58572011-06-04 Eli Zaretskii <eliz@gnu.org>
5858
5859 * bidi.c (bidi_level_of_next_char): Fix last change.
5860
57f97249
EZ
58612011-06-03 Eli Zaretskii <eliz@gnu.org>
5862
fec2107c 5863 Support bidi reordering of text covered by display properties.
57f97249 5864
fec2107c
EZ
5865 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5866 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5867 (bidi_cache_search, bidi_cache_iterator_state)
5868 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5869 (bidi_level_of_next_char, bidi_move_to_visually_next):
5870 Support character positions inside a run of characters covered by a
fec2107c
EZ
5871 display string.
5872 (bidi_paragraph_init, bidi_resolve_explicit_1)
5873 (bidi_level_of_next_char): Call bidi_fetch_char and
5874 bidi_fetch_char_advance instead of FETCH_CHAR and
5875 FETCH_CHAR_ADVANCE.
5876 (bidi_init_it): Initialize new members.
5877 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5878 definitions.
5879 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5880 instead of using explicit *_CHAR codes.
d6d100dd
SM
5881 (bidi_resolve_explicit, bidi_resolve_weak):
5882 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5883 bidirectional text is supported only in multibyte buffers.
5884 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5885 it to initialize the frame_window_p member of struct bidi_it.
5886 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5887 (bidi_resolve_explicit, bidi_resolve_weak)
5888 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5889 bidi_it->nchars is non-positive.
5890 (bidi_level_of_next_char): Don't try to lookup the cache for the
5891 next/previous character if nothing is cached there yet, or if we
5892 were just reseat()'ed to a new position.
c40e2fb2 5893
0e14fe90
EZ
5894 * xdisp.c (set_cursor_from_row): Set start and stop points
5895 according to the row's direction when priming the loop that looks
5896 for the glyph on which to display cursor.
5897 (single_display_spec_intangible_p): Function deleted.
5898 (display_prop_intangible_p): Reimplement to call
5899 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5900 Accept 3 additional arguments needed by handle_display_spec.
5901 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5902 values: lists, `(when COND...)' forms, etc.
5903 (single_display_spec_string_p): Support property values that are
5904 lists with the argument STRING its top-level element.
5905 (display_prop_string_p): Fix the condition for processing a
5906 property that is a list to be consistent with handle_display_spec.
fec2107c 5907 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5908 last portion of handle_display_prop.
5909 (compute_display_string_pos): Accept additional argument
5910 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5911 value of a `display' property is a "replacing spec".
5912 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5913 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5914 the display property, but just return a value indicating whether
5915 the display property will replace the characters it covers.
5916 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5917 frame_window_p members of struct bidi_it.
d6d100dd
SM
5918 (compute_display_string_pos, compute_display_string_end):
5919 New functions.
fec2107c
EZ
5920 (push_it): Accept second argument POSITION, where pop_it should
5921 jump to continue iteration.
5922 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5923
fec2107c
EZ
5924 * keyboard.c (adjust_point_for_property): Adjust the call to
5925 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5926
5927 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5928 (bidi_init_it): Update prototypes.
5929 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5930 (compute_display_string_pos, compute_display_string_end):
5931 Declare prototypes.
fec2107c
EZ
5932 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5933 EMACS_INT.
fc6f18ce 5934
40087514 59352011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5936
57f53182
PE
5937 Malloc failure behavior now depends on size of allocation.
5938 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5939 * lisp.h: Change signatures accordingly.
5940 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5941 All callers changed. (Bug#8762)
5942
5943 * gnutls.c: Use Emacs's memory allocators.
5944 Without this change, the gnutls library would invoke malloc etc.
5945 directly, which causes problems on non-SYNC_INPUT hosts, and which
5946 runs afoul of improving memory_full behavior. (Bug#8761)
5947 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5948 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5949 xfree instead of the default malloc, realloc, free.
5950 (Fgnutls_boot): No need to check for memory allocation failure,
5951 since xmalloc does that for us.
5952
ac32cd99 5953 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5954 * category.c (hash_get_category_set):
5955 * ccl.c (ccl_driver):
5956 * charset.c (Fdefine_charset_internal):
5957 * charset.h (struct charset.hash_index):
5958 * composite.c (get_composition_id, gstring_lookup_cache)
5959 (composition_gstring_put_cache):
5960 * composite.h (struct composition.hash_index):
5961 * dispextern.h (struct image.hash):
5962 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5963 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5964 (hashfn_equal, hashfn_user_defined, make_hash_table)
5965 (maybe_resize_hash_table, hash_lookup, hash_put)
5966 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5967 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5968 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5969 * image.c (make_image, search_image_cache, lookup_image)
5970 (xpm_put_color_table_h):
5971 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5972 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5973 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5974 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5975 * alloc.c (allocate_vectorlike):
5976 Check for overflow in vector size calculations.
5977 * ccl.c (ccl_driver):
5978 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5979 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5980 need to be updated by these changes.
40087514
PE
5981 * fns.c (make_hash_table, maybe_resize_hash_table):
5982 Check for integer overflow with large hash tables.
0de4bb68
PE
5983 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5984 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5985 (SXHASH_REDUCE): New macro.
5986 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5987 Use it instead of discarding useful hash info with large hash values.
5988 (sxhash_float): New function.
5989 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5990 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5991 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5992 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5993 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5994 Adjust signatures to match updated version of code.
5995 (consing_since_gc): Now EMACS_INT, since a single hash table can
5996 use more than INT_MAX bytes.
5997
698d32e2
DN
59982011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5999
6000 Make it possible to build with GCC-4.6+ -O2 -flto.
6001
6002 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6003
fd6fa53f
SM
60042011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6005
6006 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6007 Call minibuffer-inactive-mode.
6008
864db017
JB
60092011-05-31 Juanma Barranquero <lekktu@gmail.com>
6010
6011 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6012 Update dependencies.
6013
2ad0baf4
DN
60142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6015
6016 * data.c (init_data): Remove code for UTS, this system is not
6017 supported anymore.
6018
4fcc2638
DN
60192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6020
6021 Don't force ./temacs to start in terminal mode.
6022
6023 * frame.c (make_initial_frame): Initialize faces in all cases, not
6024 only when CANNOT_DUMP is defined.
6025 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6026
c56e0fd5
DN
60272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6028
6029 * dispnew.c (add_window_display_history): Use const for the string
6030 pointer. Remove declaration, not needed.
6031
333d54da 60322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6033
55d4c1b2 6034 Use 'inline', not 'INLINE'.
333d54da 6035 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6036 * alloc.c, fontset.c (INLINE): Remove.
6037 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6038 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6039 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6040 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6041 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6042
738db178
DN
60432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6044
6045 Make it possible to run ./temacs.
6046
6047 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6048 syms_of_callproc does the same thing. Remove test for
6049 "initialized", do it in the caller.
6050 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6051
620c53a6
SM
60522011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6053
6054 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6055 (read_minibuf): Use get_minibuffer.
6056 (syms_of_minibuf): Use DEFSYM.
6057 (Qmetadata): New var.
6058 * data.c (Qbuffer): Don't make it static.
6059 (syms_of_data): Use DEFSYM.
6060
e003a292
PE
60612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6062
6063 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6064 (CCL_CODE_MIN): New macro.
6065
ed008a6d
PE
60662011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6067
3687c2ef
PE
6068 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6069
ed008a6d
PE
6070 * eval.c (Qdebug): Now static.
6071 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6072 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6073 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6074
d66c4c7c
CY
60752011-05-29 Chong Yidong <cyd@stupidchicken.com>
6076
6077 * image.c: Various fixes to ImageMagick code comments.
6078 (Fimagemagick_types): Doc fix.
6079
5fbc2025
PE
60802011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6081
0196f88a
PE
6082 Minor fixes prompted by GCC 4.6.0 warnings.
6083
6084 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6085
5fbc2025
PE
6086 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6087 (x_clipboard_manager_save_all): Move extern decl to ...
6088 * xterm.h: ... here, so that it can be checked for consistency.
6089
1dd3c2d9
CY
60902011-05-29 Chong Yidong <cyd@stupidchicken.com>
6091
6092 * xselect.c (x_clipboard_manager_save_frame)
6093 (x_clipboard_manager_save_all): New functions.
6094 (Fx_clipboard_manager_save): Lisp function deleted.
6095
6096 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6097 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6098
6099 * xterm.h: Update prototype.
6100
5ba6571d
WX
61012011-05-28 William Xu <william.xwl@gmail.com>
6102
6103 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6104 exiting (Bug#8239).
6105
3eaff834
JM
61062011-05-28 Jim Meyering <meyering@redhat.com>
6107
e1900994 6108 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6109 * fns.c (to_uchar): Define.
6110 (crypto_hash_function): Use it to convert some newly-signed
6111 variables to unsigned, to avoid sign-extension bugs. For example,
6112 without this change, (md5 "truc") would evaluate to
6113 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6114 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6115 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6116
0f6990a7
PE
61172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6118
6119 Integer overflow fixes.
c8a9ca5a 6120
08686060
PE
6121 * dbusbind.c: Serial number integer overflow fixes.
6122 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6123 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6124 to hold a serial number that is too large for a fixnum.
6125 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6126 Check for serial numbers out of range. Decode any serial number
59568bf0 6127 that was so large that it became a float. (Bug#8722)
08686060 6128
2d1fc3c7
PE
6129 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6130 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6131 Use XFASTINT rather than XUINT when numbers are nonnegative.
6132 (xd_append_arg, Fdbus_method_return_internal):
6133 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6134 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6135 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6136 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6137 (Bug#8722)
2d1fc3c7 6138
c8a9ca5a
PE
6139 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6140
519e1d69
PE
6141 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6142
6df6ae42 6143 ccl: Add integer overflow checks.
30569699
PE
6144 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6145 (IN_INT_RANGE): New macros.
6146 (ccl_driver): Use them to check for integer overflow when
6147 decoding a CCL program. Many of the new checks are whether XINT (x)
6148 fits in int; it doesn't always, on 64-bit hosts. The new version
6149 doesn't catch all possible integer overflows, but it's an
847044ea 6150 improvement. (Bug#8719)
30569699 6151
c11285dc
PE
6152 * alloc.c (make_event_array): Use XINT, not XUINT.
6153 There's no need for unsigned here.
6154
fdccd48e
PE
6155 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6156 This follows up to the 2011-05-06 change that substituted uintptr_t
6157 for EMACS_INT. This case wasn't caught back then.
6158
37910ab2
PE
6159 Rework Fformat to avoid integer overflow issues.
6160 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6161 now (part of C89). Include <verify.h>.
6162 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6163 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6164 (Fformat): Avoid the prepass trying to compute sizes; it was only
6165 approximate and thus did not catch overflow reliably. Instead, walk
6166 through the format just once, formatting and computing sizes as we go,
6167 checking for integer overflow at every step, and allocating a larger
6168 buffer as needed. Keep track separately whether the format is
6169 multibyte. Keep only the most-recently calculated precision, rather
6170 than them all. Record whether each argument has been converted to
6171 string. Use EMACS_INT, not int, for byte and char and arg counts.
6172 Support field widths and precisions larger than INT_MAX. Avoid
6173 sprintf's undefined behavior with conversion specifications such as %#d
6174 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6175 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6176 formatting out-of-range floating point numbers with int
9173deec 6177 formats. (Bug#8668)
37910ab2 6178
2e6578fb
PE
6179 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6180
0ae6bdee
PE
6181 * data.c: Avoid integer truncation in expressions involving floats.
6182 * data.c: Include <intprops.h>.
6183 (arith_driver): When there's an integer overflow in an expression
6184 involving floating point, convert the integers to floating point
6185 so that the resulting value does not suffer from catastrophic
6186 integer truncation. For example, on a 64-bit host (* 4
6187 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6188 Do not rely on undefined behavior after integer overflow.
6189
de883a70
PE
6190 merge count_size_as_multibyte, parse_str_to_multibyte
6191 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6192 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6193 Check for integer overflow.
6194 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6195 since it's now a duplicate of the other. This is more of
6196 a character than a buffer op, so better that it's in character.c.
6197 * fns.c, print.c: Adjust to above changes.
6198
2ff916cb
PE
61992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6200
6201 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6202
f1b54466
PE
62032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6204
fb1ac845
PE
6205 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6206 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6207 (x_clipboard_manager_save): Now static.
6208 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6209
f1b54466
PE
6210 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6211 (crypto_hash_function): Now static.
6212 Fix pointer signedness problems. Avoid unnecessary initializations.
6213
a9f737ee
CY
62142011-05-27 Chong Yidong <cyd@stupidchicken.com>
6215
6216 * termhooks.h (Vselection_alist): Make it terminal-local.
6217
6218 * terminal.c (create_terminal): Initialize it.
6219
6220 * xselect.c: Support for clipboard managers.
6221 (Vselection_alist): Move to termhooks.h as terminal-local var.
6222 (LOCAL_SELECTION): New macro.
6223 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6224 (symbol_to_x_atom): Remove gratuitous arg.
6225 (x_handle_selection_request, lisp_data_to_selection_data)
6226 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6227 (x_own_selection, x_get_local_selection, x_convert_selection):
6228 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6229 (some_frame_on_display): Delete unused function.
6230 (Fx_own_selection_internal, Fx_get_selection_internal)
6231 (Fx_disown_selection_internal, Fx_selection_owner_p)
6232 (Fx_selection_exists_p): New optional frame arg.
6233 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6234 (x_handle_selection_clear): Don't treat other terminals with the
6235 same keyboard specially. Use the terminal-local Vselection_alist.
6236 (x_clear_frame_selections): Use Frun_hook_with_args.
6237
6238 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6239
6240 * xterm.h: Add support for those atoms.
6241
e067f0c1
CY
62422011-05-26 Chong Yidong <cyd@stupidchicken.com>
6243
6244 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6245 (converted_selections, conversion_fail_tag): New global variables.
6246 (x_selection_request_lisp_error): Free the above.
6247 (x_get_local_selection): Remove unnecessary code.
6248 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6249 of converted selections stored in converted_selections.
6250 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6251 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6252 (x_convert_selection): New function.
6253 (x_handle_selection_event): Simplify.
6254 (x_get_foreign_selection): Don't ignore incoming requests while
6255 waiting for an answer; this will fail when we implement
6256 SAVE_TARGETS, and seems unnecessary anyway.
6257 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6258 (Vx_sent_selection_functions): Doc fix.
6259
0f4aebc0
LL
62602011-05-26 Leo Liu <sdl.web@gmail.com>
6261
6262 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6263
e61124cd
YM
62642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6265
6266 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6267
6268 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6269 for fringe update if it has periodic bitmap.
ac389d0c 6270 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6271 and fringe_bitmap_periodic_p.
6272
6273 * fringe.c (get_fringe_bitmap_data): New function.
6274 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6275 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6276 row. Mark glyph row for fringe update if periodicity changed.
6277
6278 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6279 for fringe update unless it has periodic bitmap.
6280
f16d9837
KH
62812011-05-25 Kenichi Handa <handa@m17n.org>
6282
6283 * xdisp.c (get_next_display_element): Set correct it->face_id for
6284 a static composition.
6285
e1b90ef6
LL
62862011-05-24 Leo Liu <sdl.web@gmail.com>
6287
6288 * deps.mk (fns.o):
6289 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6290
6291 * fns.c (crypto_hash_function, Fsha1): New function.
6292 (Fmd5): Use crypto_hash_function.
6293 (syms_of_fns): Add Ssha1.
6294
7400048f
PE
62952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6296
6297 * gnutls.c: Remove unused macros.
6298 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6299 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6300 Remove macros that are defined and never used.
6301 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6302
abb71cf4
CY
63032011-05-22 Chong Yidong <cyd@stupidchicken.com>
6304
6305 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6306 (Fx_get_selection_internal): Minor cleanup.
6307 (Fx_own_selection_internal): Rename arguments for consistency with
6308 select.el.
6309
6307db39
PE
63102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6311
6312 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6313
f3d4e0a4
CY
63142011-05-22 Chong Yidong <cyd@stupidchicken.com>
6315
6316 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6317
4d8ade89
YM
63182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6319
6320 * dispnew.c (scrolling_window): Don't exclude the case that the
6321 last enabled row in the desired matrix touches the bottom boundary.
6322
32078c8d
GM
63232011-05-21 Glenn Morris <rgm@gnu.org>
6324
6325 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6326 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6327 and add some more files.
32078c8d 6328
7285dc67
EZ
63292011-05-20 Eli Zaretskii <eliz@gnu.org>
6330
6331 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6332 report_file_error introduced by the change from 2011-05-07.
6333
89d1bd22
PE
63342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6335
6336 * systime.h (Time): Define only if emacs is defined.
6337 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6338 where the include path doesn't have X11/X.h by default. See
6339 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6340
cd394be1 63412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6342
6343 * composite.c (find_automatic_composition): Fix previous change.
6344
b9704ad9
GM
63452011-05-20 Glenn Morris <rgm@gnu.org>
6346
6347 * lisp.mk: New file, split from Makefile.in.
6348 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6349 (shortlisp): Remove.
6350 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6351
4a720484
GM
63522011-05-19 Glenn Morris <rgm@gnu.org>
6353
6354 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6355 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6356 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6357 (lisp): Set the order to that of loadup.el.
6358 (shortlisp): Make it a copy of $lisp.
6359 (SOME_MACHINE_LISP): Remove.
6360 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6361 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6362
a28d4396
KH
63632011-05-18 Kenichi Handa <handa@m17n.org>
6364
6365 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6366 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6367 (find_automatic_composition): Mostly rewrite for efficiency.
6368
a2b1fa8e
JB
63692011-05-18 Juanma Barranquero <lekktu@gmail.com>
6370
6371 * makefile.w32-in: Update dependencies.
6372
8e1f5610
CS
63732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6374
6375 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6376 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6377
7025ee00 63782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6379
cdfa6eab
PE
6380 Fix some integer overflow issues, such as string length overflow.
6381
06d6db33
PE
6382 * insdel.c (count_size_as_multibyte): Check for string overflow.
6383
2b4560a8
PE
6384 * character.c (lisp_string_width): Check for string overflow.
6385 Use EMACS_INT, not int, for string indexes and lengths; in
6386 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6387 the resulting string length overflows an EMACS_INT; instead,
6388 report a string overflow if no precision given. When checking for
6389 precision exhaustion, use a check that cannot possibly have
6390 integer overflow. (Bug#8675)
6391 * character.h (lisp_string_width): Adjust to new signature.
6392
cb93f9be
PE
6393 * alloc.c (string_overflow): New function.
6394 (Fmake_string): Use it. This doesn't change behavior, but saves
6395 a few bytes and will simplify future changes.
6396 * character.c (string_escape_byte8): Likewise.
6397 * lisp.h (string_overflow): New decl.
6398
1a1f3366
PE
6399 Fixups, following up to the user-interface timestamp change.
6400 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6401 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6402 * msdos.c (mouse_get_pos): Likewise.
6403 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6404 * w32gui.h (Time): Define by including "systime.h" rather than by
6405 declaring it ourselves. (Bug#8664)
6406
d4e3e4d3
PE
6407 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6408 * image.c (clear_image_cache): Likewise.
6409
f6a24d19
PE
6410 * term.c (term_mouse_position): Don't assume time_t wraparound.
6411
08dc5ae6
PE
6412 Be more systematic about user-interface timestamps.
6413 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6414 and sometimes 'EMACS_UINT', to represent these timestamps.
6415 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6416 This makes the code easier to follow, and makes it easier to catch
6417 integer overflow bugs such as Bug#8664.
6418 * frame.c (Fmouse_position, Fmouse_pixel_position):
6419 Use Time, not unsigned long, for user-interface timestamps.
6420 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6421 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6422 * keyboard.h (last_event_timestamp): Likewise.
6423 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6424 * menu.h (xmenu_show): Likewise.
6425 * term.c (term_mouse_position): Likewise.
6426 * termhooks.h (struct input_event.timestamp): Likewise.
6427 (struct terminal.mouse_position_hook): Likewise.
6428 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6429 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6430 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6431 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6432 what it was before.
6433 * menu.h, termhooks.h: Include "systime.h", for Time.
6434
8e55734a
PE
6435 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6436 Don't assume that the difference between two unsigned long values
6437 can fit into an integer. At this point, we know button_down_time
6438 <= event->timestamp, so the difference must be nonnegative, so
6439 there's no need to cast the result if double-click-time is
6440 nonnegative, as it should be; check that it's nonnegative, just in
6441 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6442 apart (about 25 days). (Bug#8664)
8e55734a 6443
841f1b75 6444 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6445 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6446
3e26f69c
PE
6447 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6448 that always fit in int. Use a sentinel instead of a counter, to
6449 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6450 * frame.h (struct frame): Use int for menu_bar_items_used
6451 instead of EMACS_INT, since it always fits in int.
3e26f69c 6452
5cc152c0
PE
6453 * menu.c (grow_menu_items): Check for int overflow.
6454
d89eb65e
PE
6455 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6456
5235bd3e
PE
6457 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6458 Before, the code was not consistent. These values cannot exceed
6459 2**31 - 1 so there's no need to make them unsigned.
6460 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6461 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6462 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6463 as modifiers.
6464 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6465
bc827e23
PE
6466 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6467 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6468 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6469 presumably because the widths might not match.
6470
78eb494e
PE
6471 * window.c (size_window): Avoid needless test at loop start.
6472
04f2d78b
CB
64732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6474
6475 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6476
d2fc7e3d 64772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6478
6479 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6480
d2fc7e3d 64812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6482
6483 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6484 `width' to `bar_area_x' and `bar_area_width', respectively.
6485 (x_scroll_run): Take account of fringe background extension.
6486
04f2d78b
CB
6487 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6488 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6489 `bar_area_width', respectively.
6490 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6491 background extension.
6492
79b70037
GM
64932011-05-10 Jim Meyering <meyering@redhat.com>
6494
6495 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6496
2f142cc5
JB
64972011-05-10 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * image.c (Finit_image_library): Return t for built-in image types,
6500 like pbm and xbm. (Bug#8640)
6501
57679c86
AS
65022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6503
6504 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6505
888c9e86
EZ
65062011-05-07 Eli Zaretskii <eliz@gnu.org>
6507
b0512a1d
EZ
6508 * w32console.c (Fset_screen_color): Doc fix.
6509 (Fget_screen_color): New function.
6510 (syms_of_ntterm): Defsubr it.
6511
7285dc67
EZ
6512 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6513 unlink the temporary file if Fcall_process didn't create it in the
6514 first place.
6515 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6516 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6517 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6518 cue to call_process_cleanup not to close that handle.
6519
4d3fcc8e
BK
65202011-05-07 Ben Key <bkey76@gmail.com>
6521
6522 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6523 one of two shell specific rules, either bootstrap-temacs-CMD or
6524 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6525 to the previous implementation of the bootstrap-temacs rule.
6526 The bootstrap-temacs-CMD rule is similar to the previous
6527 implementation of the bootstrap-temacs rule except that it
6528 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6529 variable.
6530
6531 These changes, along with some changes to nt/configure.bat,
6532 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6533 earlier fix to add support for --cflags and --ldflags options
6534 that include quotes so that it works whether make uses cmd or
6535 sh as the shell.
6536
b4289b64
MA
65372011-05-06 Michael Albinus <michael.albinus@gmx.de>
6538
6539 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6540 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6541 is a constant.
6542 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6543 a string. Handle both cases.
6544 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6545 (Fdbus_register_method): Use Qinvalid_function.
6546
af4c0e28
JB
65472011-05-06 Juanma Barranquero <lekktu@gmail.com>
6548
6549 * makefile.w32-in: Update dependencies.
6550 (LISP_H): Add inttypes.h and stdin.h.
6551 (PROCESS_H): Add unistd.h.
6552
c51453d9
EZ
65532011-05-06 Eli Zaretskii <eliz@gnu.org>
6554
6555 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6556 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6557
8ff0ac3c 65582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6559
4c4b566b
PE
6560 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6561
aab2b9b5
PE
6562 * term.c (vfatal): Remove stray call to va_end.
6563 It's not needed and the C Standard doesn't allow it here anyway.
6564
c378da0b
PE
6565 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6566 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6567
288b08c7
PE
6568 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6569 bytes.
6570
e3601888
PE
6571 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6572
db6c0e74
PE
6573 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6574
dd5963ea
PE
6575 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6576
88c9450f
PE
6577 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6578
2f9442b8
PE
6579 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6580
c032b5f8
PE
6581 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6582 * charset.c (Fdefine_charset_internal): Don't initialize
6583 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6584 32-bit int (Bug#8600).
a108c10b
PE
6585
6586 * lread.c (read_integer): Be more consistent with string-to-number.
6587 Use string_to_number to do the actual conversion; this avoids
6588 rounding errors and fixes some other screwups. Without this fix,
6589 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6590 (digit_to_number): Move earlier, for benefit of read_integer.
6591 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6592 not a digit in any supported base. (Bug#8602)
a108c10b 6593
ad5f9eea
PE
6594 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6595
aec1708a
PE
6596 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6597 to match comment at start of function. This also removes a
6598 GCC warning about overflow in a 32+64-bit port.
6599
47be4ab5
PE
6600 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6601
371cac43
PE
6602 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6603 Reported by Stefan Monnier in
6604 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6605 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6606 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6607
d01a7826
PE
6608 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6609 (EMACS_UINTPTR): Likewise, with uintptr_t.
6610
7fd47d5c
PE
6611 * lisp.h: Prefer 64-bit EMACS_INT if available.
6612 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6613 on 32-bit hosts that have 64-bit int, so that they can access
6614 large files.
122b0c86
PE
6615 However, temporarily disable this change unless the temporary
6616 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6617
8727937b
PE
6618 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6619
8ac068ac
PE
6620 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6621 This removes an assumption that EMACS_INT and long are the same
6622 width as pointers. The assumption is true for Emacs porting targets
6623 now, but we want to make other targets possible.
6624 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6625 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6626 In the rest of the code, change types of integers that hold casted
6627 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6628 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6629 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6630 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6631 No need to cast type when ORing.
6632 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6633 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6634 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6635 assume EMACS_INT is the same width as char *.
6636 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6637 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6638 Remove no-longer-needed casts.
6639 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6640 (xg_tool_bar_help_callback, xg_make_tool_item):
6641 Use EMACS_INTPTR to hold an integer
6642 that will be cast to void *; this can avoid a GCC warning
6643 if EMACS_INT is not the same width as void *.
6644 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6645 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6646 (current_message_1, set_message_1):
6647 Use a local to convert to proper width without a cast.
6648 * xmenu.c (dialog_selection_callback): Likewise.
6649
ede49d71
PE
6650 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6651 Also, don't assume VALBITS / RAND_BITS is less than 5,
6652 and don't rely on undefined behavior when shifting a 1 left into
6653 the sign bit.
6654 * lisp.h (get_random): Change signature to match.
6655
2f30ecd0
PE
6656 * lread.c (hash_string): Use size_t, not int, for hash computation.
6657 Normally we prefer signed values; but hashing is special, because
6658 it's better to use unsigned division on hash table sizes so that
6659 the remainder is nonnegative. Also, size_t is the natural width
6660 for hashing into memory. The previous code used 'int', which doesn't
6661 retain enough info to hash well into very large tables.
6662 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6663
2a866e7b
PE
6664 * dbusbind.c: Don't possibly lose pointer info when converting.
6665 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6666 Use XPNTR rather than XHASH, so that the high-order bits of
6667 the pointer aren't lost when converting through void *.
6668
51639eac
PE
6669 * eval.c (Fautoload): Don't double-shift a pointer.
6670
92394119
PE
6671 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6672
dbdb9a7c
JB
66732011-05-06 Juanma Barranquero <lekktu@gmail.com>
6674
6675 * gnutls.c (DEF_GNUTLS_FN):
6676 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6677
db7a0b4f
AS
66782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6679
6680 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6681 marker. (Bug#8610)
6682
cd394be1 66832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6684
6685 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6686 New version that can reserve upto 2GB of heap space.
6687
f7ff1b0f 66882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6689
6690 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6691
639c109b
TZ
66922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6693
6694 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6695 `gnutls_certificate_set_x509_key_file'.
6696
d2127135
JB
66972011-05-05 Juanma Barranquero <lekktu@gmail.com>
6698
6699 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6700 Update dependencies.
6701
e968f4f3
JB
67022011-05-04 Juanma Barranquero <lekktu@gmail.com>
6703
6704 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6705 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6706 Remove unused parameter `fildes'.
6707 * process.c (read_process_output, send_process): Don't pass it.
6708
84d358f0
JB
67092011-05-04 Juanma Barranquero <lekktu@gmail.com>
6710
6711 Fix previous change: the library cache is defined in w32.c.
6712 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6713 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6714
0898ca10
JB
67152011-05-04 Juanma Barranquero <lekktu@gmail.com>
6716
6717 Implement dynamic loading of GnuTLS on Windows.
6718
6719 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6720 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6721 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6722 Declare.
6723
6724 * gnutls.c (Qgnutls_dll): Define.
6725 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6726 (gnutls_*): Declare function pointers.
6727 (init_gnutls_functions): New function to initialize function pointers.
6728 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6729 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6730 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6731 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6732 (emacs_gnutls_write, emacs_gnutls_read)
6733 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6734 (Fgnutls_available_p): New function.
6735 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6736 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6737 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6738
6739 * image.c: Include w32.h.
6740 (Vimage_type_cache): Delete.
6741 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6742 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6743 (w32_delayed_load): Move to w32.c.
6744
6745 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6746
6747 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6748 (w32_delayed_load): Move from image.c. When loading a library, record
6749 its filename in the :loaded-from property of the library id.
6750 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6751 Initialize and staticpro them.
6752 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6753
6754 * process.c: Include lisp.h before w32.h, not after.
6755 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6756 instead of gnutls_record_check_pending.
6757
6758 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6759
ff4de4aa
TZ
67602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6761
6762 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6763 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6764 as passed in.
6765
abe95abb
JD
67662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6767
6768 * xterm.c (x_set_frame_alpha): Do not set property on anything
6769 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6770
e16e55d4
JB
67712011-05-02 Juanma Barranquero <lekktu@gmail.com>
6772
6773 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6774
bafcf6a5
JB
67752011-05-02 Juanma Barranquero <lekktu@gmail.com>
6776
6777 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6778 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6779 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6780 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6781 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6782 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6783 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6784 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6785 (Qgnutls_bootprop_callbacks_verify): Make static.
6786
e7a6747f
AS
67872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6788
19ed11ba
AS
6789 * callproc.c: Indentation fixup.
6790
e7a6747f 6791 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6792 (wait_for_termination, interruptible_wait_for_termination):
6793 Move after wait_for_termination_1.
e7a6747f 6794
1ef14cb4
LMI
67952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6796
6797 * sysdep.c (interruptible_wait_for_termination): New function
6798 which is like wait_for_termination, but allows keyboard
6799 interruptions.
6800
6801 * callproc.c (Fcall_process): Add (:file "file") as an option for
6802 the STDOUT buffer.
6803 (Fcall_process_region): Ditto.
6804
330d880c
EZ
68052011-04-30 Eli Zaretskii <eliz@gnu.org>
6806
8db90b73
EZ
6807 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6808 rather than `XVECTOR (FOO)->size'.
6809
330d880c
EZ
6810 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6811 inttypes.h, as a gnulib replacement is used if it not available in
6812 system headers.
6813
15cbd324
EZ
68142011-04-21 Eli Zaretskii <eliz@gnu.org>
6815
6816 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6817 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6818 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6819
6820 * coding.c (coding_alloc_by_realloc): Error out if destination
6821 will grow beyond MOST_POSITIVE_FIXNUM.
6822 (decode_coding_emacs_mule): Abort if there isn't enough place in
6823 charbuf for the composition carryover bytes. Reserve an extra
6824 space for up to 2 characters produced in a loop.
6825 (decode_coding_iso_2022): Abort if there isn't enough place in
6826 charbuf for the composition carryover bytes.
6827
68282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6829
ae940cca
EZ
6830 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6831 aborting when %lld or %lll format is passed.
6832 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6833 %llo or %llx format is passed. (Bug#8545)
6834
03ab8921
EZ
6835 * window.c (window_scroll_line_based): Use a marker instead of
6836 simple variables to record original value of point. (Bug#7952)
6837
afda1437
EZ
6838 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6839 produced by %s or %c overflows available buffer space. (Bug#8545)
6840
f76dee0c
PE
68412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6842
6843 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6844 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6845
fdc5744d
JB
68462011-04-28 Juanma Barranquero <lekktu@gmail.com>
6847
6848 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6849
638f053a
JB
68502011-04-28 Juanma Barranquero <lekktu@gmail.com>
6851
6852 * keyboard.c (Qdelayed_warnings_hook): Define.
6853 (command_loop_1): Run `delayed-warnings-hook'
6854 if Vdelayed_warnings_list is non-nil.
6855 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6856 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6857
d178f871
EZ
68582011-04-28 Eli Zaretskii <eliz@gnu.org>
6859
6860 * doprnt.c (doprnt): Don't return value smaller than the buffer
6861 size if the message was truncated. (Bug#8545).
6862
b124fd93
JB
68632011-04-28 Juanma Barranquero <lekktu@gmail.com>
6864
6865 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6866 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6867
e810457d
PE
68682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6869
6870 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6871
ea51cceb
JB
68722011-04-27 Juanma Barranquero <lekktu@gmail.com>
6873
6874 * makefile.w32-in: Update dependencies.
6875
94dcfacf
EZ
68762011-04-27 Eli Zaretskii <eliz@gnu.org>
6877
6878 Improve `doprnt' and its usage. (Bug#8545)
6879 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6880 `format_end'. Remove support for %l as a conversion specifier.
6881 Don't use xrealloc. Improve diagnostics when the %l size modifier
6882 is used. Update the commentary.
6883
6884 * eval.c (verror): Simplify calculation of size_t.
6885
6886 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6887 messages.
6888
f61f41d7
PE
68892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6890
6891 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6892 change.
6893
96fb4434
PE
68942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6895
6896 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6897 This makes this file independent of the recent pseudovector change.
6898
671875da 68992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6900
69e9b5a3
PE
6901 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6902
b5f869a7 6903 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6904 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6905 Remove unused local.
c8926152 6906 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6907
841a1577 6908 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6909 GCC 4.6.0 optimizes based on type-based alias analysis.
6910 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6911 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6912 != &v->size, and therefore "v->size = 1; b->size = 2; return
6913 v->size;" must therefore return 1. This assumption is incorrect
6914 for Emacs, since it type-puns struct Lisp_Vector * with many other
6915 types. To fix this problem, this patch adds a new type struct
f904488f 6916 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6917 and pseudovectors, and helps optimizing compilers not get fooled
6918 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6919 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6920 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6921 the size member.
eab3844f
PE
6922 (XSETPVECTYPE): Rewrite in terms of new macro.
6923 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6924 This is a bit clearer, and further avoids the possibility of
6925 undesirable aliasing.
6926 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6927 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6928 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6929 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6930 (ASIZE): Now uses header.size rather than size.
6931 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6932 to avoid the hassle of writing XVECTOR (foo)->header.size.
6933 (struct vectorlike_header): New type.
eab3844f
PE
6934 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6935 object, to help avoid aliasing.
6936 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6937 (SUBRP): Likewise, since Lisp_Subr is a special case.
6938 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6939 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6940 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6941 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6942 changed to be "header.size" and "header.next".
6943 * buffer.h (struct buffer): Likewise.
6944 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6945 * frame.h (struct frame): Likewise.
6946 * process.h (struct Lisp_Process): Likewise.
6947 * termhooks.h (struct terminal): Likewise.
6948 * window.c (struct save_window_data, struct saved_window): Likewise.
6949 * window.h (struct window): Likewise.
6950 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6951 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6952 * buffer.c (init_buffer_once): Likewise.
6953 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6954 special case.
6955 * process.c (Fformat_network_address): Use local var for size,
6956 for brevity.
6957
0df1eac5
PE
6958 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6959
847ab9d1 6960 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6961 * data.c (atof): Remove decl; no longer used or needed.
6962 (digit_to_number): Move to lread.c.
6963 (Fstring_to_number): Use new string_to_number function, to be
6964 consistent with how the Lisp reader treats infinities and NaNs.
6965 Do not assume that floating-point numbers represent EMACS_INT
6966 without losing information; this is not true on most 64-bit hosts.
6967 Avoid double-rounding errors, by insisting on integers when
6968 parsing non-base-10 numbers, as the documentation specifies.
6969 * lisp.h (string_to_number): New decl, replacing ...
6970 (isfloat_string): Remove.
bc0a5c13 6971 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6972 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6973 appears to have been a coding error. Similarly, do not accept
6974 strings like +-1e0 as floating point numbers. Do not report
6975 overflow for integer overflows unless the base is not 10 which
6976 means we have no simple and reliable way to continue.
6977 Break out the floating-point parsing into a new
6978 function string_to_number, so that Fstring_to_number parses
6979 floating point numbers consistently with the Lisp reader.
04f2d78b 6980 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6981 (E_CHAR, EXP_INT): Remove, replacing with ...
6982 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6983 (string_to_number): New function, replacing isfloat_string.
6984 This function checks for valid syntax and produces the resulting
6985 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6986 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6987 so that overflow for non-base-10 numbers is reported only when
6988 there's no portable and simple way to convert to floating point.
452f4150 6989
67769ffc
PE
6990 * textprop.c (set_text_properties_1): Rewrite for clarity,
6991 and to avoid GCC warning about integer overflow.
6992
c20db43f
PE
6993 * intervals.h (struct interval): Use EMACS_INT for members
6994 where EMACS_UINT might cause problems. See
6995 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6996 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6997 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6998 All uses changed.
37aa2f85
PE
6999 (offset_intervals): Tell GCC not to worry about length overflow
7000 when negating a negative length.
c20db43f 7001
2538aa2f
PE
7002 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7003 (overrun_check_free): Likewise.
7004
f2d3008d
PE
7005 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7006 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7007 word size.
7008
ec8df744
PE
7009 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7010 (gnutls_make_error): Rename local to avoid shadowing.
7011 (gnutls_emacs_global_deinit): ifdef out; not used.
7012 (Fgnutls_boot): Use const for pointer to readonly storage.
7013 Comment out unused local. Fix pointer signedness problems.
7014
640ee02d
PE
7015 * lread.c (openp): Don't stuff size_t into an 'int'.
7016 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7017 about possible signed overflow.
7018
6048fb2a
PE
7019 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7020 (GDK_KEY_g): Don't define if already defined.
7021 (xg_prepare_tooltip): Avoid pointer signedness problem.
7022 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7023
fa3c87e1
PE
7024 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7025 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7026
2172544b
PE
7027 * xfns.c (Fx_window_property): Simplify a bit,
7028 to make a bit faster and to avoid GCC 4.6.0 warning.
7029 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7030
9b821a21
PE
7031 * fns.c (internal_equal): Don't assume size_t fits in int.
7032
3c616cfa
PE
7033 * alloc.c (compact_small_strings): Tighten assertion a little.
7034
c2982e87
PE
7035 Replace pEd with more-general pI, and fix some printf arg casts.
7036 * lisp.h (pI): New macro, generalizing old pEd macro to other
7037 conversion specifiers. For example, use "...%"pI"d..." rather
7038 than "...%"pEd"...".
7039 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7040 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7041 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7042 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7043 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7044 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7045 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7046 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7047 64-bit hosts.
7048 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7049 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7050 * print.c (safe_debug_print, print_object): Likewise.
7051 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7052 to int.
6f04d126
PE
7053 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7054 avoiding the 0 flag, which is not portable.
c2982e87
PE
7055 * process.c (Fmake_network_process): Use pI to avoid cast.
7056 * region-cache.c (pp_cache): Likewise.
7057 * xdisp.c (decode_mode_spec): Likewise.
7058 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7059 behavior on 64-bit hosts with printf arg.
6f04d126 7060 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7061 (x_stop_queuing_selection_requests): Likewise.
7062 (x_get_window_property): Don't truncate byte count to an 'int'
7063 when tracing.
0b432f21 7064
5e073ec7
PE
7065 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7066 here, since it parses constructs like leading '-' and spaces,
7067 which are not wanted; and it overflows with large numbers.
7068 Instead, simply match F[0-9]+, which is what is wanted anyway.
7069
36372bf9
PE
7070 * alloc.c: Remove unportable assumptions about struct layout.
7071 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7072 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7073 (allocate_vectorlike, make_pure_vector): Use the new macros,
7074 plus offsetof, to remove unportable assumptions about struct layout.
7075 These assumptions hold on all porting targets that I know of, but
7076 they are not guaranteed, they're easy to remove, and removing them
7077 makes further changes easier.
7078
0b432f21
PE
7079 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7080 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7081 (string_overrun_cookie): Now const. Use initializers that
7082 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7083 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7084 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7085 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7086 multiple of sizeof (EMACS_INT); it need not be, if
7087 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7088 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7089
895009e1
JB
70902011-04-26 Juanma Barranquero <lekktu@gmail.com>
7091
7092 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7093
6a7a1b0b
TZ
70942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7095
7096 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7097 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7098 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7099
841a1577 71002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7101
7102 * lisp.h (Qdebug): List symbol.
895009e1 7103 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7104 * keyboard.c (debug-on-event): New variable.
7105 (handle_user_signal): Break into debugger when debug-on-event
7106 matches the current signal symbol.
7107
f2d3ba6f
DN
71082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7109
7110 * alloc.c (check_sblock, check_string_bytes)
7111 (check_string_free_list): Convert to standard C.
7112
42ce4c63
TZ
71132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7114
7115 * w32.c (emacs_gnutls_push): Fix typo.
7116
825cd63c
EZ
71172011-04-25 Eli Zaretskii <eliz@gnu.org>
7118
fb11d64d
EZ
7119 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7120 "cast to pointer from integer of different size".
7121
825cd63c
EZ
7122 Improve doprnt and its use in verror. (Bug#8545)
7123 * doprnt.c (doprnt): Document the set of format control sequences
7124 supported by the function. Use SAFE_ALLOCA instead of always
7125 using `alloca'.
7126
7127 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7128 is one byte too soon. Don't use xrealloc; instead xfree and
7129 xmalloc anew.
7130
e061a11b
TZ
71312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7132
7133 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7134 callbacks stage.
7135
7136 * gnutls.c: Renamed global_initialized to
7137 gnutls_global_initialized. Added internals for the
7138 :verify-hostname-error, :verify-error, and :verify-flags
7139 parameters of `gnutls-boot' and documented those parameters in the
7140 docstring. Start callback support.
9173deec
JB
7141 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7142 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7143 on error. Return error code.
e061a11b
TZ
7144 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7145 (emacs_gnutls_read): Likewise.
7146 (Fgnutls_boot): Return handshake error code.
7147 (emacs_gnutls_handle_error): New function.
7148 (wsaerror_to_errno): Likewise.
7149
7150 * w32.h (emacs_gnutls_pull): Add prototype.
7151 (emacs_gnutls_push): Likewise.
7152
7153 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7154 (emacs_gnutls_push): Likewise.
7155
71562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7157
7158 * process.c (wait_reading_process_output): Check if GnuTLS
7159 buffered some data internally if no FDs are set for TLS
7160 connections.
7161
7162 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7163 (LIBS): Link to USER_LIBS.
7164 ($(BLD)/gnutls.$(0)): New target.
7165
fa6996bc
EZ
71662011-04-24 Eli Zaretskii <eliz@gnu.org>
7167
eb35682e
EZ
7168 * xdisp.c (handle_single_display_spec): Rename the
7169 display_replaced_before_p argument into display_replaced_p, to
7170 make it consistent with the commentary. Fix typos in the
7171 commentary.
7172
e2ad650c
EZ
7173 * textprop.c (syms_of_textprop): Remove dead code.
7174 (copy_text_properties): Delete obsolete commentary about an
7175 interface that was deleted long ago. Fix typos in the description
7176 of arguments.
7177
1b2de274
EZ
7178 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7179 to changes in oldXMenu/XMenu.h from 2011-04-16.
7180 <menu_help_message, prev_menu_help_message>: Constify.
7181 (IT_menu_make_room): menu->help_text is now `const char **';
7182 adjust.
7183
7184 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7185 to changes in oldXMenu/XMenu.h from 2011-04-16.
7186 (struct XMenu): Declare `help_text' `const char **'.
7187
7188 * xfaces.c <Qunspecified>: Make extern again.
7189
7190 * syntax.c: Include sys/types.h before including regex.h, as
7191 required by Posix.
7192
762b15be
EZ
7193 * doc.c (get_doc_string): Improve the format passed to `error'.
7194
7195 * doprnt.c (doprnt): Improve commentary.
7196
7197 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7198
7199 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7200 them with etags.
7201
f1052e5d
EZ
7202 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7203 changes in globals.h immediately force recompilation.
762b15be
EZ
7204 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7205 $(CURDIR)/s/ms-w32.h.
7206 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7207
fa6996bc
EZ
7208 * character.c (Fchar_direction): Function deleted.
7209 (syms_of_character): Don't defsubr it.
7210 <char-direction-table>: Deleted.
7211
e6c3da20
EZ
72122011-04-23 Eli Zaretskii <eliz@gnu.org>
7213
7214 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7215 * doprnt.c: Include limits.h.
7216 (SIZE_MAX): New macro.
04f2d78b
CB
7217 (doprnt): Return a size_t value. 2nd arg is now size_t.
7218 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7219 Improve overflow protection. Support `l' modifier for integer
7220 conversions. Support %l conversion. Don't assume an EMACS_INT
7221 argument for integer conversions and for %c.
7222
7223 * lisp.h (doprnt): Restore prototype.
7224
7225 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7226 $(SRC)/character.h.
7227
7228 * Makefile.in (base_obj): Add back doprnt.o.
7229
7230 * deps.mk (doprnt.o): Add back prerequisites.
7231 (callint.o): Depend on character.h.
7232
7233 * eval.c (internal_lisp_condition_case): Include the handler
7234 representation in the error message.
7235 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7236 when breaking from the loop.
7237
7238 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7239
7240 * callint.c (Fcall_interactively): When displaying error message
7241 about invalid control letter, pass the character's codepoint, not
7242 a pointer to its multibyte form. Improve display of the character
7243 in octal and display also its hex code.
7244
7245 * character.c (char_string): Use %x to display the (unsigned)
7246 codepoint of an invalid character, to avoid displaying a bogus
7247 negative value.
7248
7249 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7250 `error', not SYMBOL_NAME itself.
7251
7252 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7253 character arguments to `error'.
7254
7255 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7256 to `error' in error message about FINAL_CHAR argument. Make sure
7257 FINAL_CHAR is a character, and use %c when it is passed as
7258 argument to `error'.
7259
4ffd0d6b 72602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7261
7262 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7263
7264 * w32.c: Include <time.h>.
7265 (sys_localtime): New function.
7266
4ffd0d6b 72672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7268
7269 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7270
4ffd0d6b 7271 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7272
4ffd0d6b 72732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7274
4ffd0d6b
GM
7275 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7276 zombies (Bug#8467).
aac0c6e3 7277
04c56954
EZ
72782011-04-19 Eli Zaretskii <eliz@gnu.org>
7279
7280 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7281 gl_state.e_property when gl_state.object is Qt.
7282
7283 * insdel.c (make_gap_larger): Remove limitation of buffer size
7284 to <= INT_MAX.
7285
16a43933
CY
72862011-04-18 Chong Yidong <cyd@stupidchicken.com>
7287
7288 * xdisp.c (lookup_glyphless_char_display)
7289 (produce_glyphless_glyph): Handle cons cell entry in
7290 glyphless-char-display.
7291 (Vglyphless_char_display): Document it.
7292
7293 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7294 glyphless-char-display.
7295
4581706e
CY
72962011-04-17 Chong Yidong <cyd@stupidchicken.com>
7297
7298 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7299
7300 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7301
7302 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7303 definition for no-X builds.
7304
4887c6e2 73052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7306
fd35b6f9
PE
7307 Static checks with GCC 4.6.0 and non-default toolkits.
7308
5c1ccb01
PE
7309 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7310
006c5daa
PE
7311 * process.c (keyboard_bit_set): Define only if SIGIO.
7312 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7313 (send_process): Repair possible setjmp clobbering.
7314
efc736d3
PE
7315 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7316
4e2fe2e6
PE
7317 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7318
f97334a2
PE
7319 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7320
4e75f29d
PE
7321 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7322 Define only if needed.
7323
90efadd1
PE
7324 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7325 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7326 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7327
3c647824
PE
7328 * dispextern.h (struct redisplay_interface): Rename param
7329 to avoid shadowing.
e264f262 7330 * termhooks.h (struct terminal): Likewise.
761383f4 7331 * xterm.c (xembed_send_message): Likewise.
3c647824 7332
b58c5c4a
PE
7333 * insdel.c (make_gap_smaller): Define only if
7334 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7335
cad59032
PE
7336 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7337 it.
7338
c339dc2e
PE
7339 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7340 so that we aren't warned about unused symbols.
7341
91a3e27b
PE
7342 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7343
399c71d3 7344 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7345
8ffc96f5
PE
7346 * xfns.c (x_real_positions): Mark locals as initialized.
7347
eef9bc79
PE
7348 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7349
098db9dd
PE
7350 * xterm.c: Fix problems found by static analysis with other toolkits.
7351 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7352 (x_dispatch_event): Declare static if USE_GTK, and
7353 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7354 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7355 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7356 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7357 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7358
eb18f6cc
PE
7359 * xmenu.c (menu_help_callback): Pointer type fixes.
7360 Use const pointers when pointing at readonly data. Avoid pointer
7361 signedness clashes.
7362 (FALSE): Remove unused macro.
7363 (update_frame_menubar): Remove unused decl.
7364
1fe72bf8
PE
7365 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7366
60d9e1db
PE
7367 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7368 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7369 (single_menu_item): Rename local to avoid shadowing.
7370
39261c26
PE
7371 * keyboard.c (make_lispy_event): Remove unused local var.
7372
018c5e19
PE
7373 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7374 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7375
63d2b86e
PE
7376 * bitmaps: Change bitmaps from unsigned char back to the X11
7377 compatible char. Avoid the old compiler warnings about
7378 out-of-range initializers by using, for example, '\xab' rather
7379 than 0xab.
7380
aefd87e1
PE
7381 * xgselect.c (xgselect_initialize): Check vs interface
7382 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7383
bf501fb9
PE
7384 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7385
e9829fdf
PE
7386 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7387 to read-only memory.
7388
1086c095
PE
7389 * fns.c (vector): Remove; this old hack is no longer needed.
7390
2baccd04 7391 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7392 Remove unused var.
dde42981 7393 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7394
72391843 7395 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7396
436c16df 7397 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7398 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7399 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7400
92bb796d 7401 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7402 (x_term_init): Remove local to avoid shadowing.
92bb796d 7403
764430a3 7404 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7405
7406 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7407 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7408
d1dfb56c
EZ
74092011-04-16 Eli Zaretskii <eliz@gnu.org>
7410
c4354cb4
EZ
7411 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7412
d1dfb56c
EZ
7413 Fix regex.c, syntax.c and friends for buffers > 2GB.
7414 * syntax.h (struct gl_state_s): Declare character position members
7415 EMACS_INT.
7416
7417 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7418
04f2d78b
CB
7419 * textprop.c (verify_interval_modification, interval_of):
7420 Declare arguments EMACS_INT.
d1dfb56c
EZ
7421
7422 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7423 EMACS_INT.
7424
7425 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7426
7427 * indent.c (Fvertical_motion): Local variable it_start is now
7428 EMACS_INT.
7429
7430 * regex.c (re_match, re_match_2, re_match_2_internal)
7431 (bcmp_translate, regcomp, regexec, print_double_string)
7432 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7433 (re_compile_pattern, re_exec): Declare arguments and local
7434 variables `size_t' and `ssize_t' and return values `regoff_t', as
7435 appropriate.
7436 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7437 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7438 <compile_stack_type>: `size' and `avail' are now `size_t'.
7439
7440 * regex.h <regoff_t>: Use ssize_t, not int.
7441 (re_search, re_search_2, re_match, re_match_2): Arguments that
7442 specify buffer/string position and length are now ssize_t and
7443 size_t. Return type is regoff_t.
7444
613052cd
BK
74452011-04-16 Ben Key <bkey76@gmail.com>
7446
7447 * nsfont.m: Fixed bugs in ns_get_family and
7448 ns_descriptor_to_entity that were caused by using free to
7449 deallocate memory blocks that were allocated by xmalloc (via
7450 xstrdup). This caused Emacs to crash when compiled with
7451 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7452 --enable-checking=xmallocoverrun). xfree is now used to
7453 deallocate these memory blocks.
7454
4170f62f 74552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7456
71b41406
PE
7457 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7458
9587a89d
PE
7459 emacs_write: Accept and return EMACS_INT for sizes.
7460 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7461 et seq.
7462 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7463 Accept and return EMACS_INT.
7464 (emacs_gnutls_write): Return the number of bytes written on
7465 partial writes.
7466 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7467 (emacs_read, emacs_write): Remove check for negative size, as the
7468 Emacs source code has been audited now.
9587a89d
PE
7469 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7470 (emacs_read, emacs_write): Use it.
273a5f82
PE
7471 * process.c (send_process): Adjust to the new signatures of
7472 emacs_write and emacs_gnutls_write. Do not attempt to store
7473 a byte offset into an 'int'; it might overflow.
9587a89d 7474 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7475
3e047f51
PE
7476 * sound.c: Don't assume sizes fit in 'int'.
7477 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7478 Return EMACS_INT, not int.
3e047f51 7479 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7480 Accept EMACS_INT, not int.
7481 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7482 record read return values.
7483
cc39a9db
BK
74842011-04-15 Ben Key <bkey76@gmail.com>
7485
c9d0ec6d
JB
7486 * keyboard.c (Qundefined): Don't declare static since it is used
7487 in nsfns.m.
7488 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7489 static since they are used in nsfont.m.
cc39a9db 7490
6c60eb9f
SM
74912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7492
7493 * process.c (Qprocessp): Don't declare static.
7494 * lisp.h (Qprocessp): Declare again.
7495
7990b61a
JB
74962011-04-15 Juanma Barranquero <lekktu@gmail.com>
7497
7498 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7499
5d4cb038
PE
75002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7501
8bd7b830 7502 Improve C-level modularity by making more things 'static'.
cd64ea1d 7503
e3b27b31
PE
7504 Don't publish debugger-only interfaces to other modules.
7505 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7506 (verify_bytepos, count_markers): Move decls to the only modules
7507 that need them.
7508 * region-cache.h (pp_cache): Likewise.
7509 * window.h (check_all_windows): Likewise.
7510 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7511
5d4cb038
PE
7512 * sysdep.c (croak): Now static, if
7513 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7514 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7515
7516 * alloc.c (refill_memory_reserve): Now static if
7517 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7518 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7519
e87b6180
PE
7520 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7521 Define only if USE_LUCID.
7522
ac64929e
PE
7523 * xrdb.c (x_customization_string, x_rm_string): Now static.
7524
6f37259d
PE
7525 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7526 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7527
1683e3ab
PE
7528 * xdisp.c (draw_row_with_mouse_face): Now static.
7529 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7530
de9c2632
PE
7531 * window.h (check_all_windows): Mark externally visible.
7532
2b96acb7
PE
7533 * window.c (window_deletion_count): Now static.
7534
7535 * undo.c: Make symbols static if they're not exported.
7536 (last_undo_buffer, last_boundary_position, pending_boundary):
7537 Now static.
7538
50436f33
PE
7539 * textprop.c (interval_insert_behind_hooks): Now static.
7540 (interval_insert_in_front_hooks): Likewise.
7541
64520e5c
PE
7542 * term.c: Make symbols static if they're not exported.
7543 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7544 (max_frame_lines, tty_set_terminal_modes):
7545 (tty_reset_terminal_modes, tty_turn_off_highlight):
7546 (get_tty_terminal): Now static.
7547 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7548 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7549 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7550 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7551 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7552
1fa53021
PE
7553 * sysdep.c: Make symbols static if they're not exported.
7554 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7555 Now static.
7556 (sigprocmask_set, full_mask): Remove; unused.
7557 (wait_debugging): Mark as visible.
7558 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7559 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7560
d4b43b22
PE
7561 * syntax.c (syntax_temp): Define only if !__GNUC__.
7562
b7c513d0
PE
7563 * sound.c (current_sound_device, current_sound): Now static.
7564
989b29ad
PE
7565 * search.c (searchbufs, searchbuf_head): Now static.
7566
13a55a78
PE
7567 * scroll.c (scroll_cost): Remove; unused.
7568 * dispextern.h (scroll_cost): Remove decl.
7569
de68a1fc
PE
7570 * region-cache.h (pp_cache): Mark as externally visible.
7571
40ccffa6
PE
7572 * process.c: Make symbols static if they're not exported.
7573 (process_tick, update_tick, create_process, chan_process):
7574 (Vprocess_alist, proc_buffered_char, datagram_access):
7575 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7576 (deactivate_process): Mark defn as static, as well as decl.
7577 * lisp.h (create_process): Remove decl.
7578 * process.h (chan_process, Vprocess_alist): Remove decls.
7579
ad64fc97
PE
7580 * print.c: Make symbols static if they're not exported.
7581 (print_depth, new_backquote_output, being_printed, print_buffer):
7582 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7583 (print_interval, print_number_index, initial_stderr_stream):
7584 Now static.
7585 * lisp.h (Fprinc): Remove decl.
7586 (debug_output_compilation_hack): Mark as externally visible.
7587
adddb265
PE
7588 * sysdep.c (croak): Move decl from here to syssignal.h.
7589 * syssignal.h (croak): Put it here, so the API can be checked when
7590 'croak' is called from dissociate_if_controlling_tty.
7591
1717ede2
PE
7592 * minibuf.c: Make symbols static if they're not exported.
7593 (minibuf_save_list, choose_minibuf_frame): Now static.
7594 * lisp.h (choose_minibuf_frame): Remove decl.
7595
fa5fb2bc
PE
7596 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7597
1e3890d1
PE
7598 * lread.c: Make symbols static if they're not exported.
7599 (read_objects, initial_obarray, oblookup_last_bucket_number):
7600 Now static.
7601 (make_symbol): Remove; unused.
7602 * lisp.h (initial_obarray, make_symbol): Remove decls.
7603
8a1414fa
PE
7604 * keyboard.c: Make symbols static if they're not exported.
7605 (single_kboard, recent_keys_index, total_keys, recent_keys):
7606 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7607 (this_single_command_key_start, echoing, last_auto_save):
7608 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7609 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7610 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7611 (Vlispy_mouse_stem, double_click_count):
7612 Now static.
7613 (force_auto_save_soon): Define only if SIGDANGER.
7614 (ignore_mouse_drag_p): Now static if
7615 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7616 (print_help): Remove; unused.
7617 (stop_character, last_timer_event): Mark as externally visible.
7618 * keyboard.h (ignore_mouse_drag_p): Declare only if
7619 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7620 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7621 * lisp.h (echoing): Remove decl.
7622 (force_auto_save_soon): Declare only if SIGDANGER.
7623 * xdisp.c (redisplay_window): Simplify code, to make it more
7624 obvious that ignore_mouse_drag_p is not accessed if !defined
7625 USE_GTK && !defined HAVE_NS.
7626
93ea6e8f
PE
7627 * intervals.c: Make symbols static if they're not exported.
7628 (merge_properties_sticky, merge_interval_right, delete_interval):
7629 Now static.
7630 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7631
77382fcc
PE
7632 * insdel.c: Make symbols static if they're not exported.
7633 However, leave prepare_to_modify_buffer alone. It's never
7634 called from outside this function, but that appears to be a bug.
7635 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7636 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7637 (adjust_after_replace_noundo): Remove; unused.
7638 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7639 (signal_before_change): Remove decls.
77382fcc 7640
9306c32e
PE
7641 * indent.c (val_compute_motion, val_vmotion): Now static.
7642
cd44d2eb
PE
7643 * image.c: Make symbols static if they're not exported.
7644 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7645 if USE_GTK.
7646 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7647 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7648
ad9a7a06
PE
7649 * fringe.c (standard_bitmaps): Now static.
7650 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7651
81626931
PE
7652 * frame.c: Make symbols static if they're not exported.
7653 (x_report_frame_params, make_terminal_frame): Now static.
7654 (get_frame_param): Now static, unless HAVE_NS.
7655 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7656 (x_get_resource_string): Remove; not used.
7657 * frame.h (make_terminal_frame, x_report_frame_params):
7658 (x_get_resource_string); Remove decls.
7659 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7660 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7661
239f9db9
PE
7662 * font.c, fontset.c: Make symbols static if they're not exported.
7663 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7664 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7665 * font.c (font_close_object): Now static.
7666 * font.h (font_close_object): Remove.
7667 * fontset.c (FONTSET_OBJLIST): Remove.
7668 (free_realized_fontset) #if-0 the body, which does nothing.
7669 (face_suitable_for_char_p): #if-0, as it's never called.
7670 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7671 * xfaces.c (face_at_string_position):
7672 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7673 since 0 is always ASCII.
7674
dfcf3579
PE
7675 * fns.c (weak_hash_tables): Now static.
7676
5045092b
PE
7677 * fileio.c: Make symbols static if they're not exported.
7678 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7679 (Vwrite_region_annotation_buffers): Now static.
7680
57a96f5c
PE
7681 * eval.c: Make symbols static if they're not exported.
7682 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7683 * lisp.h (backtrace_list): Remove decl.
7684
35f08c38
PE
7685 * emacs.c: Make symbols static if they're not exported.
7686 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7687 (fatal_error_code, fatal_error_signal_hook, standard_args):
7688 Now static.
7689 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7690 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7691 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7692 * lisp.h (fatal_error_signal_hook): Remove decl.
7693 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7694
f44bd759
PE
7695 * editfns.c: Move a (normally-unused) function to its only use.
7696 * editfns.c, lisp.h (get_operating_system_release): Remove.
7697 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7698 worth the hassle of breaking this out.
7699
b532497d
PE
7700 * xterm.c: Make symbols static if they're not exported.
7701 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7702 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7703 (x_destroy_window, x_delete_display):
7704 Now static.
7705 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7706 (x_mouse_leave): Remove; unused.
7707 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7708 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7709 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7710 Remove decls.
7711 (x_mouse_leave): Declare only if WINDOWSNT.
7712 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7713 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7714 USE_X_TOOLKIT.
7715
1675728f
PE
7716 * ftxfont.c: Make symbols static if they're not exported.
7717 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7718 HAVE_FREETYPE.
7719 * font.h (ftxfont_driver): Likewise.
7720
e4cebfca
PE
7721 * xfns.c: Make symbols static if they're not exported.
7722 (x_last_font_name, x_display_info_for_name):
7723 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7724 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7725 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7726 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7727 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7728 (last_show_tip_args): Now static.
7729 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7730 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7731 (x_screen_planes): Remove; unused.
7732 * dispextern.h (x_screen_planes): Remove decl.
7733
5bf46f05
PE
7734 * dispnew.c: Make symbols static if they're not exported.
7735 * dispextern.h (redraw_garbaged_frames, scrolling):
7736 (increment_row_positions): Remove.
7737 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7738 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7739 Now static.
7740 (redraw_garbaged_frames): Remove; unused.
7741
435f4c28
PE
7742 * xfaces.c: Make symbols static if they're not exported.
7743 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7744 Remove decls.
7745 * xterm.h (defined_color): Remove decls.
7746 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7747 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7748 (menu_face_changed_default, defined_color, free_realized_face):
7749 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7750 (ascii_face_of_lisp_face): Remove; unused.
7751
8524aef3
PE
7752 * xdisp.c: Make symbols static if they're not exported.
7753 * dispextern.h (scratch_glyph_row, window_box_edges):
7754 (glyph_to_pixel_coords, set_cursor_from_row):
7755 (get_next_display_element, set_iterator_to_next):
7756 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7757 (show_mouse_face): Remove decls
7758 * frame.h (message_buf_print): Likewise.
7759 * lisp.h (pop_message, set_message, check_point_in_composition):
7760 Likewise.
7761 * xterm.h (set_vertical_scroll_bar): Likewise.
7762 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7763 (message_buf_print, scratch_glyph_row, displayed_buffer):
7764 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7765 (get_next_display_element, show_mouse_face, window_box_edges):
7766 (frame_to_window_pixel_xy, check_point_in_composition):
7767 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7768 (glyph_to_pixel_coords): Remove; unused.
7769
16390cd2
PE
7770 * dired.c (file_name_completion): Now static.
7771
7772 * dbusbind.c (xd_in_read_queued_messages): Now static.
7773
a25f4dfa
PE
7774 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7775 * data.c (circular_list_error): Remove.
7776
14a9c8df
PE
7777 * commands.h (last_point_position, last_point_position_buffer):
7778 (last_point_position_window): Remove decls.
7779 * keyboard.c: Make these variables static.
7780
04f2d78b
CB
7781 * coding.h (coding, code_convert_region, encode_coding_gap):
7782 Remove decls.
74ab6df5
PE
7783 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7784 (iso_code_class, detect_coding, code_convert_region): Now static.
7785 (encode_coding_gap): Remove; unused.
7786
38dfbee1
PE
7787 * chartab.c (chartab_chars, chartab_bits): Now static.
7788
a2cb4e63
PE
7789 * charset.h (charset_iso_8859_1): Remove decl.
7790 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7791 Now static.
7792
127198fd
PE
7793 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7794 * ccl.c (Vccl_program_table): Now static.
7795 (check_ccl_update): Remove; unused.
7796
d85b608f
PE
7797 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7798 * category.h: ... from here.
7799 * category.c (check_category_table, set_category_set): Now static.
7800
31cd66f3
PE
7801 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7802 * lisp.h: Remove these decls.
7803
c358e587
PE
7804 * buffer.c (buffer_count): Remove unused var.
7805
e78aecca
PE
7806 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7807 so that it's not optimized away.
7808 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7809 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7810 exported only to the debugger.
7811
e192d7d3 7812 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7813 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7814
92470028
PE
7815 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7816 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7817 was inaccessible from Lisp.
7818 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7819 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7820
244ed907
PE
7821 alloc.c: Import and export fewer symbols, and remove unused items.
7822 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7823 is defined.
7824 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7825 it's not optimized away by whole-program optimization.
7826 (message_enable_multibyte, free_misc): Remove.
7827 (catchlist, handlerlist, mark_backtrace):
7828 Declare only if BYTE_MARK_STACK.
7829 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7830 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7831 (message_enable_multibyte): Remove decl.
7832 (free_misc, interval_free_list, float_block, float_block_index):
7833 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7834 (cons_free_list, last_marked_index):
7835 Now static.
7836 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7837 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7838 (mark_backtrace): Define only if BYTE_MARK_STACK.
7839 * xdisp.c (message_enable_multibyte): Now static.
7840
61c2b50e 7841 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7842 This makes it easier for human readers (and static analyzers)
7843 to see whether these variables are used from other modules.
7844 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7845 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7846 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7847 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7848 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7849 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7850 * xmenu.c, xselect.c:
7851 Declare Q* vars static if they are not used in other modules.
7852 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7853 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7854 Remove decls of unexported vars.
7855 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7856
95c82688
PE
7857 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7858
16a97296
PE
7859 Make Emacs functions such as Fatom 'static' by default.
7860 This makes it easier for human readers (and static analyzers)
7861 to see whether these functions can be called from other modules.
7862 DEFUN now defines a static function. To make the function external
7863 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7864 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7865 (Finit_image_library):
16a97296
PE
7866 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7867 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7868 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7869 Remove decls, since these functions are now static.
7870 (Funintern, Fget_internal_run_time): New decls, since these functions
7871 were already external.
95c82688 7872
16a97296
PE
7873 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7874 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7875 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7876 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7877 * keyboard.c, keymap.c, lread.c:
7878 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7879 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7880 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7881 Mark functions with DEFUE instead of DEFUN,
7882 if they are used in other modules.
7883 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7884 decls for now-static functions.
7885 * buffer.h (Fdelete_overlay): Remove decl.
7886 * callproc.c (Fgetenv_internal): Mark as internal.
7887 * composite.c (Fremove_list_of_text_properties): Remove decl.
7888 (Fcomposition_get_gstring): New forward static decl.
7889 * composite.h (Fcomposite_get_gstring): Remove decl.
7890 * dired.c (Ffile_attributes): New forward static decl.
7891 * doc.c (Fdocumntation_property): New forward static decl.
7892 * eval.c (Ffetch_bytecode): New forward static decl.
7893 (Funintern): Remove extern decl; now in .h file where it belongs.
7894 * fileio.c (Fmake_symbolic_link): New forward static decl.
7895 * image.c (Finit_image_library): New forward static decl.
7896 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7897 * intervals.h (Fprevious_property_change):
7898 (Fremove_list_of_text_properties): Remove decls.
7899 * keyboard.c (Fthis_command_keys): Remove decl.
7900 (Fcommand_execute): New forward static decl.
7901 * keymap.c (Flookup_key): New forward static decl.
7902 (Fcopy_keymap): Now static.
7903 * keymap.h (Flookup_key): Remove decl.
7904 * process.c (Fget_process): New forward static decl.
7905 (Fprocess_datagram_address): Mark as internal.
7906 * syntax.c (Fsyntax_table_p): New forward static decl.
7907 (skip_chars): Remove duplicate decl.
7908 * textprop.c (Fprevious_property_change): New forward static decl.
7909 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7910 Now internal.
7911 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7912 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7913
785bbd42
PE
7914 * editfns.c (Fformat): Remove unreachable code.
7915
8b913b57
AS
79162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7917
7918 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7919 change. (Bug#8496)
7920
a6744a35
EZ
79212011-04-13 Eli Zaretskii <eliz@gnu.org>
7922
7923 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7924 when at ZV. (Bug#8487)
7925
e7974947
AS
79262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7927
baad03f0
AS
7928 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7929 (Bug#8437)
7930 * keyboard.c (parse_tool_bar_item): Likewise.
7931 * sound.c (sound_cleanup, alsa_close): Likewise.
7932 * termcap.c (tgetent): Likewise.
7933 * xfns.c (x_default_font_parameter): Likewise.
7934 * xsettings.c (read_and_apply_settings): Likewise.
7935
e7974947
AS
7936 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7937 (overrun_check_free): Protoize.
7938
28272684
PE
79392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7940
7941 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7942 since callers should never pass a negative size.
7943 Change the signature to match that of plain 'read' and 'write'; see
7944 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7945 * lisp.h: Update prototypes of emacs_write and emacs_read.
7946
11997c76
EZ
79472011-04-11 Eli Zaretskii <eliz@gnu.org>
7948
7949 * xdisp.c (redisplay_window): Don't try to determine the character
7950 position of the scroll margin if the window start point w->startp
e896f03c 7951 is outside the buffer's accessible region. (Bug#8468)
11997c76 7952
8a2cbd72
EZ
79532011-04-10 Eli Zaretskii <eliz@gnu.org>
7954
7955 Fix write-region and its subroutines for buffers > 2GB.
7956 * fileio.c (a_write, e_write): Modify declaration of arguments and
7957 local variables to support buffers larger than 2GB.
7958 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7959
7960 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7961 argument, local variables, and return value.
7962
7963 * lisp.h: Update prototypes of emacs_write and emacs_read.
7964
7965 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7966
4073e537 79672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7968
1ebfdcb6
PE
7969 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7970
b2ded58d
PE
7971 Fix more problems found by GCC 4.6.0's static checks.
7972
7d66342c
PE
7973 * xdisp.c (vmessage): Use a better test for character truncation.
7974
bbf47d44
PE
7975 * charset.c (load_charset_map): <, not <=, for optimization,
7976 and to avoid potential problems with integer overflow.
9248994d 7977 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7978 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7979 * editfns.c (Fformat): Likewise.
1e69125e 7980 * syntax.c (skip_chars): Likewise.
3befa583 7981
e3019616
PE
7982 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7983 This also lets GCC 4.6.0 generate slightly better loop code.
7984
becfa255
PE
7985 * callint.c (Fcall_interactively): <, not <=, for optimization.
7986 (Fcall_interactively): Count the number of arguments produced,
7987 not the number of arguments given. This is simpler and lets GCC
7988 4.6.0 generate slightly better code.
7989
dae0cd48
PE
7990 * ftfont.c: Distingish more carefully between FcChar8 and char.
7991 The previous code passed unsigned char * to a functions like
7992 strlen and xstrcasecmp that expect char *, which does not
7993 conform to the C standard.
7994 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7995 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7996 char * when the C standard requires it.
7997
76032d70
PE
7998 * keyboard.c (read_char): Remove unused var.
7999
eb3f1cc8
PE
8000 * eval.c: Port to Windows vsnprintf (Bug#8435).
8001 Include <limits.h>.
8002 (SIZE_MAX): Define if the headers do not.
8003 (verror): Do not give up if vsnprintf returns a negative count.
8004 Instead, grow the buffer. This ports to Windows vsnprintf, which
8005 does not conform to C99. Problem reported by Eli Zaretskii.
8006 Also, simplify the allocation scheme, by avoiding the need for
8007 calling realloc, and removing the ALLOCATED variable.
8008
70476b54
PE
8009 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8010
12020a9e
PE
8011 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8012 But keep the doprint source code for now, as we might revamp it
8013 and use it again (Bug#8435).
ea6c7ae6
PE
8014 * lisp.h (doprnt): Remove.
8015 * Makefile.in (base_obj): Remove doprnt.o.
8016 * deps.mk (doprnt.o): Remove.
8017
5fdb398c
PE
8018 error: Print 32- and 64-bit integers portably (Bug#8435).
8019 Without this change, on typical 64-bit hosts error ("...%d...", N)
8020 was used to print both 32- and 64-bit integers N, which relied on
8021 undefined behavior.
61bdb816 8022 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8023 * lisp.h (error, verror): Mark as printf-like functions.
8024 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8025 Report overflow in size calculations when allocating printf buffer.
8026 Do not truncate output string at its first null byte.
8027 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8028 Truncate the output at a character boundary, since vsnprintf does not
8029 do that.
8030 * charset.c (check_iso_charset_parameter): Convert internal
8031 character to string before calling 'error', since %c now has the
8032 printf meaning.
8033 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8034 overflow when computing char to be passed to 'error'. Do not
8035 pass Lisp_Object to 'error'; pass the integer instead.
8036 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8037 formatted with plain %d.
8038
b189fa66
PE
8039 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8040
bff87ef0
PE
8041 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8042
7e2cac20
PE
8043 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8044
ce4d90b5
PE
8045 * xterm.c (x_catch_errors): Remove duplicate declaration.
8046
266c9547
PE
8047 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8048
79c49ad2
PE
8049 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8050
368f4090
JM
80512011-04-10 Jim Meyering <meyering@redhat.com>
8052
8053 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8054 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8055 return ssize_t not "int", and use size_t as the buffer length.
8056 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8057 * gnutls.h: Update declarations.
8058 * process.c (read_process_output): Use ssize_t, to match.
8059 (send_process): Likewise.
8060
a32d4040
CY
80612011-04-09 Chong Yidong <cyd@stupidchicken.com>
8062
8063 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8064
8546720e 80652011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8066
04f2d78b
CB
8067 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8068 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8069
8546720e
GM
8070 * xterm.c (handle_one_xevent):
8071 * xmenu.c (create_and_show_popup_menu):
8072 * xselect.c (x_decline_selection_request)
8073 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8074
0a2f5c1a 80752011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8076
8077 Fix some uses of `int' instead of EMACS_INT.
8078 * search.c (string_match_1, fast_string_match)
8079 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8080 (scan_buffer, find_next_newline_no_quit)
8081 (find_before_next_newline, search_command, Freplace_match)
8082 (Fmatch_data): Make some `int' variables be EMACS_INT.
8083
8084 * xdisp.c (display_count_lines): 3rd argument and return value now
8085 EMACS_INT. All callers changed.
8086 (pint2hrstr): Last argument is now EMACS_INT.
8087
8088 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8089 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8090 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8091 (decode_coding_utf_16, decode_coding_emacs_mule)
8092 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8093 (decode_coding_ccl, decode_coding_charset)
8094 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8095 (decode_coding_iso_2022, decode_coding_emacs_mule)
8096 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8097 <char_offset, last_offset>: Declare EMACS_INT.
8098 (encode_coding_utf_8, encode_coding_utf_16)
8099 (encode_coding_emacs_mule, encode_invocation_designation)
8100 (encode_designation_at_bol, encode_coding_iso_2022)
8101 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8102 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8103 Declare EMACS_INT.
8104 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8105 (encode_invocation_designation): Last argument P_NCHARS is now
8106 EMACS_INT.
8107 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8108 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8109
8110 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8111 All users changed.
8112
8113 * ccl.c (Fccl_execute_on_string): Declare some variables
8114 EMACS_INT.
8115
8546720e 81162011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8117
8118 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8119
4e19a977
CS
81202011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8121
8122 * process.c (Fformat_network_address): Doc fix.
8123
87302331
R
81242011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8125
ee7683eb 8126 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8127
cbb59342
CY
81282011-04-08 Chong Yidong <cyd@stupidchicken.com>
8129
8130 * keyboard.c (read_char): Call Lisp function help-form-show,
8131 instead of using internal_with_output_to_temp_buffer.
8132 (Qhelp_form_show): New var.
e0d38eeb 8133 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8134
8135 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8136
8137 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8138
e67a13ab
CY
81392011-04-06 Chong Yidong <cyd@stupidchicken.com>
8140
04f2d78b
CB
8141 * process.c (Flist_processes): Remove to Lisp.
8142 (list_processes_1): Delete.
e67a13ab 8143
973f782d
EZ
81442011-04-06 Eli Zaretskii <eliz@gnu.org>
8145
7c106b1e
EZ
8146 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8147
973f782d
EZ
8148 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8149
41cf7d1a 81502011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8151
ca23cc88
PE
8152 Fix more problems found by GCC 4.6.0's static checks.
8153
f390e2d5
PE
8154 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8155
42eea0d0
PE
8156 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8157
b69769da 8158 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8159
f9541e84
PE
8160 * xdisp.c (vmessage): Mark as a printf-like function.
8161
13841b55
PE
8162 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8163
c136c10f
PE
8164 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8165
5e2d4a30
PE
8166 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8167 printf-like functions.
8168 (tiff_load): Add casts to remove these marks before passing them
8169 to system-supplied API.
8170
583f48b9
PE
8171 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8172
b25d760e
PE
8173 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8174 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8175 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8176 directly, rather than having caller test rule sign. This avoids
8177 some unnecessary tests.
8178 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8179 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8180 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8181
bc7b6697 8182 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8183 (xfont_open): Avoid unnecessary tests.
bc7b6697 8184
27ccc379
PE
8185 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8186
dcd5c89a
PE
8187 * composite.h, composite.c (composition_gstring_put_cache):
8188 Use EMACS_INT, not int, for length.
8189
b13a45c6
PE
8190 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8191 breaking out part of COMPOSITION_DECODE_RULE.
8192 (COMPOSITION_DECODE_RULE): Use it.
8193 * composite.c (get_composition_id): Remove unused local vars,
8194 by using the new macro.
8195
1e792e4d
PE
8196 * textprop.c (set_text_properties_1): Change while to do-while,
8197 since the condition is always true at first.
8198
dc6c6455 8199 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8200 (interval_deletion_adjustment): Return unsigned value.
8201 All uses changed.
dc6c6455 8202
aba7731a
PE
8203 * process.c (list_processes_1, create_pty, read_process_output):
8204 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8205 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8206 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8207 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8208 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8209
fdfc4bf3
PE
8210 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8211
fca8fe46 8212 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8213 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8214
06a0259a 8215 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8216 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8217 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8218
e7b9e80f
PE
8219 * print.c (print_error_message): Avoid int overflow.
8220
56201685
PE
8221 * font.c (font_list_entities): Redo for clarity,
8222 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8223
78834453 8224 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8225 (font_score): Avoid potential overflow in diff calculation.
78834453 8226
0bc0b309 8227 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8228 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8229
e610eaca
PE
8230 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8231
b895abce
PE
8232 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8233 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8234 can always succeed if overflow has undefined behavior.
8235
1f1d9321 8236 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8237 (wordify): Omit three unnecessary tests.
1f1d9321 8238
c59478bc
PE
8239 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8240 All callers changed. This avoids the need for an unused var.
8241
79b73827
PE
8242 * casefiddle.c (casify_region): Remove var that is set but not used.
8243
a4db5dfe
PE
8244 * dired.c (file_name_completion): Remove var that is set but not used.
8245
43aae36e
PE
8246 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8247
2a47c44d 8248 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8249 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8250
a37c69bf
PE
8251 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8252 Check for integer overflow on size calculations.
8253
328ab8e7
PE
8254 * buffer.c (Fprevious_overlay_change): Remove var that is set
8255 but not used.
8256
e5a2a5cb
PE
8257 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8258 Remove vars that are set but not used.
8d84a6eb 8259 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8260 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8261
a60e5f68
PE
8262 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8263
f661cb61 8264 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8265 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8266
f0397f5a
PE
8267 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8268 that are set but not used.
8269
8664db06 8270 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8271 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8272
6abdaa4a
PE
8273 * xselect.c (x_get_local_selection, x_handle_property_notify):
8274 Remove vars that are set but not used.
8275
0ce7538d 8276 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8277 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8278
9ae848fc
PE
8279 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8280 Remove var that is set but not used.
0b918413
PE
8281 (scroll_bar_windows_size): Now size_t, not int.
8282 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8283 Check for overflow.
9ae848fc 8284
a5a62657
PE
8285 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8286 (map_tty_color) [!defined MSDOS]: Likewise.
8287
5c5cdd39
PE
8288 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8289
66ebf983
PE
8290 * coding.c: Remove vars that are set but not used.
8291 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8292 All callers changed.
8293 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8294 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8295 (decode_coding_charset): Remove vars that are set but not used.
8296
1be4d761
PE
8297 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8298 that is set but not used.
8299
47553fa8
PE
8300 * print.c (print_object): Remove var that is set but not used.
8301
1f7196bf 8302 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8303 The gnulib version avoids calling malloc in the usual case,
8304 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8305 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8306 * filelock.c (current_lock_owner): Likewise.
8307 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8308 * sysdep.c: Include allocator.h, careadlinkat.h.
8309 (emacs_no_realloc_allocator): New static constant.
8310 (emacs_readlink): New function.
fdb61804
PE
8311 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8312 ../lib/careadlinkat.h.
d1fdcab7 8313
f84c17c7
SM
83142011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8315
8316 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8317 first non-nil return value).
8318
ef3862ad
JD
83192011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8320
8321 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8322 if not defined (Bug#8403).
8323
376a7006
JB
83242011-04-02 Juanma Barranquero <lekktu@gmail.com>
8325
8326 * xdisp.c (display_count_lines): Remove parameter `start',
8327 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8328 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8329 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8330 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8331 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8332 and thereabouts. All callers changed.
8333 (get_per_char_metric): Remove parameter `f', unused since
8334 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8335
6ca3801d
JM
83362011-04-02 Jim Meyering <meyering@redhat.com>
8337
8338 do not dereference NULL upon failed strdup
8339 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8340 (ns_get_family): Likewise.
8341
d8e2b5ba
JB
83422011-04-02 Juanma Barranquero <lekktu@gmail.com>
8343
8344 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8345
8c74fcbd
JD
83462011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8347
8348 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8349 later (Bug#8403).
8350
7200d79c
SM
83512011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8352
03408648 8353 Add lexical binding.
7200d79c 8354
03408648
SM
8355 * window.c (Ftemp_output_buffer_show): New fun.
8356 (Fsave_window_excursion):
8357 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8358
8359 * lread.c (lisp_file_lexically_bound_p): New function.
8360 (Fload): Bind Qlexical_binding.
8361 (readevalloop): Remove `evalfun' arg.
8362 Bind Qinternal_interpreter_environment.
8363 (Feval_buffer): Bind Qlexical_binding.
8364 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8365 Mark as dynamic.
8366 (syms_of_lread): Declare `lexical-binding'.
8367
8368 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8369
8370 * keyboard.c (eval_dyn): New fun.
8371 (menu_item_eval_property): Use it.
ca105506
SM
8372
8373 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8374
03408648
SM
8375 * fns.c (concat, mapcar1): Accept byte-code-functions.
8376
8377 * eval.c (Fsetq): Handle lexical vars.
8378 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8379 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8380 (FletX, Flet): Obey lexical binding.
8381 (Fcommandp): Handle closures.
8382 (Feval): New `lexical' arg.
8383 (eval_sub): New function extracted from Feval. Use it almost
8384 everywhere where Feval was used. Look up vars in lexical env.
8385 Handle closures.
8386 (Ffunctionp): Move from subr.el.
8387 (Ffuncall): Handle closures.
8388 (apply_lambda): Remove `eval_flags'.
8389 (funcall_lambda): Handle closures and new byte-code-functions.
8390 (Fspecial_variable_p): New function.
8391 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8392 but without exporting it to Lisp.
23aba0ea 8393
23aba0ea 8394 * doc.c (Fdocumentation, store_function_docstring):
03408648 8395 * data.c (Finteractive_form): Handle closures.
23aba0ea 8396
03408648
SM
8397 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8398 interactive spec.
ba83908c 8399
04f2d78b
CB
8400 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8401 New byte-codes.
03408648
SM
8402 (exec_byte_code): New function extracted from Fbyte_code to handle new
8403 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8404
03408648 8405 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8406
03408648 8407 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8408
e2abce01
JB
84092011-03-31 Juanma Barranquero <lekktu@gmail.com>
8410
8411 * xdisp.c (redisplay_internal): Fix prototype.
8412
63696a73 84132011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8414
63696a73 8415 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8416 (try_scrolling): Use it when setting scroll_limit.
8417 Limit scrolling to 100 screen lines.
63696a73
EZ
8418 (redisplay_window): Even when falling back on "recentering",
8419 position point in the window according to scroll-conservatively,
8420 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8421
8422 (try_scrolling): When point is above the window, allow searching
8423 as far as scroll_max, or one screenful, to compute vertical
8424 distance from PT to the scroll margin position. This prevents
8425 try_scrolling from unnecessarily failing when
8426 scroll-conservatively is set to a value slightly larger than the
8427 window height. Clean up the case of PT below the margin at bottom
8428 of window: scroll_max can no longer be INT_MAX. When aggressive
8429 scrolling is in use, don't let point enter the opposite scroll
8430 margin as result of the scroll.
8431 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8432 threshold of 100 lines for never-recentering scrolling.
8433
e4cc2dfc
JB
84342011-03-31 Juanma Barranquero <lekktu@gmail.com>
8435
8436 * dispextern.h (move_it_by_lines):
8437 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8438 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8439 (message_log_check_duplicate): Remove parameters `prev_bol' and
8440 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8441 (redisplay_internal): Remove parameter `preserve_echo_area',
8442 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8443
8444 * indent.c (Fvertical_motion):
8445 * window.c (window_scroll_pixel_based, Frecenter):
8446 Don't pass `need_y_p' to `move_it_by_lines'.
8447
1c470562
SM
84482011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8449
44f230aa
SM
8450 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8451 steal a few bits to be more compact.
8452 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8453 Remove unneeded casts.
8454
1c470562
SM
8455 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8456
888adce9
ZK
84572011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8458
8459 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8460 binding" message (bug#7967).
8461
f838ed7b
PE
84622011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8463
77861b95
PE
8464 Fix more problems found by GCC 4.6.0's static checks.
8465
de6dbc14
PE
8466 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8467 Remove unused local var.
8468
f838ed7b
PE
8469 * editfns.c (Fmessage_box): Remove unused local var.
8470
792c7b2b
PE
8471 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8472 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8473 Omit unused local vars.
c499e557 8474 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8475 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8476 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8477 Omit unused local var.
8478
ba0165e1
PE
8479 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8480 Don't assume string length fits in int.
32ad8845 8481 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8482 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8483
3c59b4c9
PE
8484 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8485 instead of alloca (Bug#8344).
8486
a3eed478 8487 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8488 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8489
eb4d412d
PE
8490 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8491
1658b401
PE
8492 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8493 concerns.
8494
8495 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8496
8497 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8498
9a2c6e05
PE
8499 * keyboard.c (syms_of_keyboard): Use the same style as later
8500 in this function when indexing through an array. This also
8501 works around GCC bug 48267.
8502
03d0a109
PE
8503 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8504
44f730c8
PE
8505 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8506
fe75f926
PE
8507 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8508 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8509
ffa8c828
PE
8510 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8511 This avoids undefined behavior on integer overflow, and is a bit
8512 more convenient anyway since it is compared to a size_t variable.
8513
c5101a77
PE
8514 Variadic C functions now count arguments with size_t, not int.
8515 This avoids an unnecessary limitation on 64-bit machines, which
8516 caused (substring ...) to crash on large vectors (Bug#8344).
8517 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8518 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8519 All variadic functions and their callers changed accordingly.
c5101a77
PE
8520 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8521 * data.c (arith_driver, float_arith_driver): Likewise.
8522 * editfns.c (general_insert_function): Likewise.
8523 * eval.c (struct backtrace.nargs, interactive_p)
8524 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8525 (funcall_lambda, mark_backtrace): Likewise.
8526 * fns.c (concat): Likewise.
8527 * frame.c (x_set_frame_parameters): Likewise.
8528 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8529 0 if not found, not -1. All callers changed.
8530
dd3f25f7
PE
8531 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8532 (stack_copy_size): Now size_t, not int.
8533 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8534
461c2ab9
JB
85352011-03-28 Juanma Barranquero <lekktu@gmail.com>
8536
8537 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8538 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8539 All callers changed.
8540
8541 * lisp.h (multibyte_char_to_unibyte):
8542 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8543 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8544 * character.h (CHAR_TO_BYTE8):
8545 * cmds.c (internal_self_insert):
8546 * editfns.c (general_insert_function):
8547 * keymap.c (push_key_description):
8548 * search.c (Freplace_match):
8549 * xdisp.c (message_dolog, set_message_1): All callers changed.
8550
f6d62986
SM
85512011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8552
8553 * keyboard.c (safe_run_hook_funcall): New function.
8554 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8555 don't set the hook to nil, but remove the offending function instead.
8556 (Qcommand_hook_internal): Remove, unused.
8557 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8558 Vcommand_hook_internal.
8559
8560 * eval.c (enum run_hooks_condition): Remove.
8561 (funcall_nil, funcall_not): New functions.
8562 (run_hook_with_args): Call each function through a `funcall' argument.
8563 Remove `cond' argument, now redundant.
8564 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8565 (Frun_hook_with_args_until_failure): Adjust accordingly.
8566 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8567
1db5b1ad
JB
85682011-03-28 Juanma Barranquero <lekktu@gmail.com>
8569
8570 * dispextern.h (string_buffer_position): Remove declaration.
8571
8572 * print.c (strout): Remove parameter `multibyte', unused since
8573 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8574
8575 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8576 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8577 All callers changed.
8578
8579 * w32.c (_wsa_errlist): Use braces for struct initializers.
8580
8581 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8582 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8583 All callers changed.
8584 (string_buffer_position): Likewise. Also, make static (it's never
8585 used outside xdisp.c).
8586 (cursor_row_p): Remove parameter `w', unused since
8587 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8588 (decode_mode_spec): Remove parameter `precision', introduced during
8589 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8590 All callers changed.
8591
5ffb62aa
JD
85922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8593
8594 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8595
461c2ab9 85962011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8597
8598 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8599 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8600 (ns_update_auto_hide_menu_bar): New functions.
8601 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8602 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8603 ns_constrain_all_frames.
8604 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8605 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8606
5c380ffb
JD
86072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8608
8609 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8610
9af30bdf
GM
86112011-03-27 Glenn Morris <rgm@gnu.org>
8612
8613 * syssignal.h: Replace RETSIGTYPE with void.
8614 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8615 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8616 Replace SIGTYPE with void everywhere.
8617 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8618 * s/template.h (SIGTYPE): Remove commented out definition.
8619
e2abce01
JB
86202011-03-26 Eli Zaretskii <eliz@gnu.org>
8621
8622 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8623 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8624
f868cd8a
JB
86252011-03-26 Juanma Barranquero <lekktu@gmail.com>
8626
59eb0929
JB
8627 * w32.c (read_unc_volume): Use parameter `henum', instead of
8628 global variable `wget_enum_handle'.
8629
8630 * keymap.c (describe_vector): Remove parameters `indices' and
8631 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8632 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8633
f868cd8a
JB
8634 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8635
8636 * keyboard.c (timer_check): Remove parameter `do_it_now',
8637 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8638 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8639 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8640
8641 * keyboard.c (read_char):
8642 * w32menu.c (w32_menu_display_help):
8643 * xmenu.c (show_help_event, menu_help_callback):
8644 Adjust calls to `show_help_echo'.
8645
8646 * gtkutil.c (xg_maybe_add_timer):
8647 * keyboard.c (readable_events):
8648 * process.c (wait_reading_process_output):
8649 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8650
8651 * insdel.c (adjust_markers_gap_motion):
8652 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8653 (gap_left, gap_right): Don't call it.
8654
2ecf6fdb
CY
86552011-03-25 Chong Yidong <cyd@stupidchicken.com>
8656
8657 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8658 incurred during fontification.
8659
6b1f9ba4
JB
86602011-03-25 Juanma Barranquero <lekktu@gmail.com>
8661
8662 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8663 (DEFVAR_PER_BUFFER): Don't pass it.
8664
8665 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8666 (scrolling_window): Don't pass it.
8667
0f4a96b5
JB
86682011-03-25 Juanma Barranquero <lekktu@gmail.com>
8669
8670 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8671
8672 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8673 and `suffix'.
8674 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8675 of variables specific to SELinux and computation of `encoded_absname'.
8676
8677 * image.c (XPutPixel): Remove unused variable `height'.
8678
8679 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8680
8681 * unexw32.c (get_section_info): Remove unused variable `section'.
8682
8683 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8684 (system_process_attributes): Remove unused variable `sess'.
8685 (sys_read): Remove unused variable `err'.
8686
8687 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8688 (w32_wnd_proc): Remove unused variable `isdead'.
8689 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8690 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8691 (x_create_tip_frame): Remove unused variable `tem'.
8692
8693 * w32inevt.c (w32_console_read_socket):
8694 Remove unused variable `no_events'.
8695
8696 * w32term.c (x_draw_composite_glyph_string_foreground):
8697 Remove unused variable `width'.
8698
1149507c
JB
86992011-03-24 Juanma Barranquero <lekktu@gmail.com>
8700
8701 * w32term.c (x_set_glyph_string_clipping):
8702 Don't pass uninitialized region to CombineRgn.
8703
9c88f339
JB
87042011-03-23 Juanma Barranquero <lekktu@gmail.com>
8705
8706 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8707 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8708 (Fx_close_connection): Remove unused variable `i'.
8709
8710 * w32font.c (w32font_draw): Return number of glyphs.
8711 (w32font_open_internal): Remove unused variable `i'.
8712 (w32font_driver): Add missing initializer.
8713
8714 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8715 (fill_in_menu): Remove unused variable `items_added'.
8716
8717 * w32term.c (last_mouse_press_frame): Remove static global variable.
8718 (w32_clip_to_row): Remove unused variable `f'.
8719 (x_delete_terminal): Remove unused variable `i'.
8720
8721 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8722 (NOTHING): Remove unused static global variable.
8723 (uniscribe_check_otf): Remove unused variable `table'.
8724 (uniscribe_font_driver): Add missing initializers.
8725
dee091a3
JD
87262011-03-23 Julien Danjou <julien@danjou.info>
8727
8728 * term.c (Fsuspend_tty, Fresume_tty):
8729 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8730 * window.c (temp_output_buffer_show):
8731 * insdel.c (signal_before_change):
8732 * frame.c (Fhandle_switch_frame):
8733 * fileio.c (Fdo_auto_save):
8734 * emacs.c (Fkill_emacs):
8735 * editfns.c (save_excursion_restore):
8736 * cmds.c (internal_self_insert):
8737 * callint.c (Fcall_interactively):
8738 * buffer.c (Fkill_all_local_variables):
8739 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8740 Use Frun_hooks.
0f4a96b5 8741 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8742 unconditionally since it does the check itself.
dee091a3 8743
2c520ab5 87442011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8745
c9c49752
PE
8746 Fix more problems found by GCC 4.5.2's static checks.
8747
8abc3f12
PE
8748 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8749 the first time through the loop, since we know p0 < p1 then.
8750 This also avoids a gcc -Wstrict-overflow warning.
8751
a2d26660
PE
8752 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8753 leading to a memory leak, possible in functions like
8754 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8755 of objects (Bug#8318).
a2d26660 8756
916c72e9
PE
8757 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8758 that could (at least in theory) be that large.
8759
19ab8a18
PE
8760 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8761 This is less likely to overflow, and avoids undefined behavior if
8762 overflow does occur. All callers changed. Use strtoul to scan
8763 for the unsigned long integer.
b7cbbd6f
PE
8764 (pint2hrstr): Simplify and tune code slightly.
8765 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8766
f0641eff
PE
8767 * scroll.c (do_scrolling): Work around GCC bug 48228.
8768 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8769
7f650bb9
PE
8770 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8771 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8772 (validate_x_resource_name): Simplify count usage.
8773 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8774
37dd57d1
PE
8775 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8776 fail (Bug#8306).
81e56e61 8777
699979fc 8778 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8779
401bf9b4
PE
8780 * process.c (Fmake_network_process): Use socklen_t, not int,
8781 where POSIX says socklen_t is required in portable programs.
8782 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8783 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8784 (Fmake_network_process, server_accept_connection):
8785 (wait_reading_process_output, read_process_output):
8786 Likewise.
8787
b93aacde
PE
8788 * process.c: Rename or move locals to avoid shadowing.
8789 (list_processes_1, Fmake_network_process):
8790 (read_process_output_error_handler, exec_sentinel_error_handler):
8791 Rename or move locals.
4dc343ee 8792 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8793 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8794 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8795 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8796 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8797
af8a867c 8798 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8799 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8800 Include tparam.h instead, since it declares them.
af8a867c
PE
8801 * cm.h (PC): Remove extern decl; tparam.h now does this.
8802 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8803 * terminfo.c: Include tparam.h, to check interfaces.
8804 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8805 (tparam): Adjust signature to match interface in tparam.h;
8806 this removes some undefined behavior. Check that outstring and len
8807 are zero, which they always are with Emacs.
8808 * tparam.h (PC, BC, UP): New extern decls.
8809
0248044d 8810 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8811 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8812
8ff096c1 8813 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8814 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8815 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8816 (ftfont_list): Remove unused local.
49eaafba
PE
8817 (get_adstyle_property, ftfont_pattern_entity):
8818 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8819 Rename locals to avoid shadowing.
8ff096c1 8820
e2be39f6
PE
8821 * xfont.c (xfont_list_family): Mark var as initialized.
8822
c9735e30
PE
8823 * xml.c (make_dom): Now static.
8824
8f5201ae
PE
8825 * composite.c (composition_compute_stop_pos): Rename local to
8826 avoid shadowing.
b246f932
PE
8827 (composition_reseat_it): Remove unused locals.
8828 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8829 (composition_update_it): Mark var as initialized.
11b61122
PE
8830 (find_automatic_composition): Mark vars as initialized,
8831 with a FIXME (Bug#8290).
8f5201ae 8832
760fbc2c
PE
8833 character.h: Rename locals to avoid shadowing.
8834 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8835 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8836 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8837 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8838 to avoid shadowing.
8839
ff08eb85
PE
8840 * textprop.c (property_change_between_p): Remove; unused.
8841
fc7bf025
PE
8842 * intervals.c (interval_start_pos): Now static.
8843
235d7abc
PE
8844 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8845
44f230aa
SM
8846 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8847 Rename locals to avoid shadowing.
3e7d6594 8848
50060332
PE
8849 * sound.c (wav_play, au_play, Fplay_sound_internal):
8850 Fix pointer signedness.
d01f234b 8851 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8852 (wav_play): Initialize a variable to 0, to prevent undefined
8853 behavior (Bug#8278).
50060332 8854
c4fc4e30
PE
8855 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8856
918436ed
PE
8857 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8858
c939f91b
PE
8859 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8860 clobbering (Bug#8298).
b9c7f648
PE
8861 * sysdep.c (sys_subshell): Likewise.
8862 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8863
6bd8c144
PE
8864 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8865 This should get cleaned up, so that child_setup has the
8866 same signature on all platforms.
8867
7710357c 8868 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8869 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8870
c59da222
CY
88712011-03-22 Chong Yidong <cyd@stupidchicken.com>
8872
8873 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8874 not to be necessary, and produces flickering.
8875
66b87493
GM
88762011-03-20 Glenn Morris <rgm@gnu.org>
8877
8878 * config.in: Remove file.
8879
45b6f6d5
JB
88802011-03-20 Juanma Barranquero <lekktu@gmail.com>
8881
8882 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8883 are now in src/globals.h.
8884 (syms_of_minibuf): Remove spurious & from previous change.
8885
cd394be1 88862011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8887
8888 * minibuf.c (completing-read-function): New variable.
8889 (completing-read-default): Rename from completing-read.
8890 (completing-read): Call completing-read-function.
8891
b14e3e21
CY
88922011-03-19 Juanma Barranquero <lekktu@gmail.com>
8893
8894 * xfaces.c (Fx_load_color_file):
8895 Read color file from absolute filename (bug#8250).
8896
f2b726e6
JB
88972011-03-19 Juanma Barranquero <lekktu@gmail.com>
8898
8899 * makefile.w32-in: Update dependencies.
8900
09f6ff02
EZ
89012011-03-17 Eli Zaretskii <eliz@gnu.org>
8902
8903 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8904
29a6015a
PE
89052011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8906
a3a6c54e
PE
8907 Fix more problems found by GCC 4.5.2's static checks.
8908
b766f867
PE
8909 * process.c (make_serial_process_unwind, send_process_trap):
8910 (sigchld_handler): Now static.
8911
be02381c
PE
8912 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8913 That way, the code declares only the vars that it needs.
8914 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8915 * s/cygwin.h (PTY_ITERATION): Likewise.
8916 * s/darwin.h (PTY_ITERATION): Likewise.
8917 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8918
57048744
PE
8919 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8920 * process.c (allocate_pty): Don't declare stb unless it's needed.
8921
7914961c 8922 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8923 (CONSTANTLIM): Remove; unused.
8924 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8925 Define only if needed.
7914961c 8926
b3967b18
PE
8927 * unexelf.c (unexec): Name an expression,
8928 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8929 Use a different way to cause a compilation error if anyone uses
8930 n rather than nn, a way that does not involve shadowing.
73366a00 8931 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8932
29a6015a
PE
8933 * deps.mk (unexalpha.o): Remove; unused.
8934
43cfc33e 8935 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8936 * unexec.h: New file.
ce701a33
PE
8937 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8938 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8939 Depend on unexec.h.
8940 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8941 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8942 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8943 Change as necessary to match prototype in unexec.h.
ce701a33 8944
01f44d5a
PE
8945 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8946 shadowing.
4f63c6bb 8947 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8948
a6670b0b
PE
8949 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8950 Rename locals to avoid shadowing.
8951
cef2010d 8952 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8953 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8954
d4d7173a
PE
8955 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8956
f08b802a
PE
8957 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8958 warning when compiling print.c.
8959
3ddb0639
PE
8960 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8961 instead of using an uninitialized var.
5ad03b97 8962 (font_sort_entities): Mark var as initialized.
3ddb0639 8963
170a2692
PE
8964 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8965
e663c700
PE
8966 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8967 pointers to constants.
89bc529a 8968 (font_parse_fcname): Remove unused vars.
7b81e2d0 8969 (font_delete_unmatched): Now static.
ea838e10 8970 (font_get_spec): Remove; unused.
13a547c6
PE
8971 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8972 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8973 Rename or move locals to avoid shadowing.
e663c700 8974
2a80c887 8975 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8976 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8977
1384fa33 8978 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8979 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8980
8b2c52e9
PE
8981 * alloc.c (mark_backtrace): Move decl from here ...
8982 * lisp.h: ... to here, so that it can be checked.
8983
475545b5 8984 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8985 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8986 (lisp_indirect_variable): Name an expression,
8987 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8988 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8989
b1349114 8990 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8991 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8992 Use const pointer when appropriate.
b1349114 8993
a2928364
PE
8994 * lisp.h (get_system_name, get_operating_system_release):
8995 Move decls here, to check interfaces.
8996 * process.c (get_operating_system_release): Move decl to lisp.h.
8997 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8998 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8999 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9000 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9001 (Fformat_time_string, Fencode_time, Finsert_char):
9002 (Ftranslate_region_internal, Fformat):
9003 Rename or remove local vars to avoid shadowing.
9710023e 9004 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9005
a415e694
PE
9006 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9007 avoid shadowing.
9008
8ef4622d
PE
9009 * lisp.h (eassert): Check that the argument compiles, even if
9010 ENABLE_CHECKING is not defined.
9011
946f9a5b
PE
9012 * data.c (Findirect_variable): Name an expression, to avoid
9013 gcc -Wbad-function-cast warning.
112396d6 9014 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9015 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9016 (Fmake_variable_buffer_local, Fmake_local_variable):
9017 Mark variables as initialized.
52746918 9018 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9019
e5aab7e7 9020 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9021 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9022 Rename locals to avoid shadowing.
dff45157
PE
9023 (mark_stack): Move local variables into the #ifdef region where
9024 they're used.
7bc26fdb
PE
9025 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9026 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9027 needed otherwise.
9028 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9029 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9030 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9031
e5aab7e7
PE
9032 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9033 avoids undefined behavior in theory.
9034
4da60324
PE
9035 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9036
88043301
PE
9037 Use functions, not macros, for up- and down-casing (Bug#8254).
9038 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9039 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9040 to use the following functions instead of these macros.
9041 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9042 EMACS_INT, since callers assume the returned value fits in int.
9043 (upcase1): Likewise, for UPCASE_TABLE.
9044 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9045 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9046 the race-condition problem in the old DOWNCASE.
88043301 9047
19ed5445
PE
9048 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9049 Rename locals to avoid shadowing.
9050 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9051 (regex_compile, re_search_2, re_match_2_internal):
9052 Remove unused local vars.
952db0d7
PE
9053 (FREE_VAR): Rewrite so as not to use empty "else",
9054 which gcc can warn about.
da053e48 9055 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9056 (RETALLOC_IF): Define only if needed.
9057 (WORDCHAR_P): Likewise. This one is never needed, but is used
9058 only in a comment talking about a compiler bug, so put inside
9059 the #if 0 of that comment.
9060 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9061 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9062 Remove; unused.
19ed5445 9063
1f3561e4 9064 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9065 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9066 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9067
ded6f8f7
PE
9068 * search.c (simple_search): Remove unused var.
9069
dbd37a95
PE
9070 * dired.c (compile_pattern): Move decl from here ...
9071 * lisp.h: ... to here, so that it can be checked.
9072 (struct re_registers): New forward decl.
9073
7e47afad
PE
9074 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9075
85f24f61
PE
9076 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9077 All uses changed.
9078 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9079 Rename locals to avoid shadowing.
5671df8f 9080 (Fvertical_motion): Mark locals as initialized.
85f24f61 9081
181aa2be 9082 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9083 (casify_region): Mark local as initialized.
181aa2be 9084
930d429c
PE
9085 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9086
7082eac6
PE
9087 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9088 New macros, so that the caller can use some names other than
9089 gcpro1, gcpro2, etc.
9090 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9091 of the new macros.
9092 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9093 argument, for consistency with GCPRO2_VAR, etc: it is now the
9094 prefix of the variable, not the variable itself. All uses
9095 changed.
38b2c076
PE
9096 * dired.c (directory_files_internal, file_name_completion):
9097 Rename locals to avoid shadowing.
9098
15206ed9
PE
9099 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9100 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9101 dired.c's scmp function, had undefined behavior.
9102 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9103 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9104 * buffer.h: ... to here, because these macros use current_buffer,
9105 and the new implementation with inline functions needs to have
9106 current_buffer in scope now, rather than later when the macros
9107 are used.
9108 (downcase, upcase1): New static inline functions.
9109 (DOWNCASE, UPCASE1): Reimplement using these functions.
9110 This avoids undefined behavior in expressions like
9111 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9112 from race conditions in accessing the global variables
9113 case_temp1 and case_temp2.
9114 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9115 * lisp.h (case_temp1, case_temp2): Remove their decls.
9116 * character.h (ASCII_CHAR_P): Move from here ...
9117 * lisp.h: ... to here, so that the inline functions mentioned
9118 above can use them.
9119
4a6bea26
PE
9120 * dired.c (directory_files_internal_unwind): Now static.
9121
f14b7e14
PE
9122 * fileio.c (file_name_as_directory, directory_file_name):
9123 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9124 Now static.
2893f146
PE
9125 (file_name_as_directory): Use const pointers when appropriate.
9126 (Fexpand_file_name): Likewise. In particular, newdir might
9127 point at constant storage, so make it a const pointer.
fd4ead52 9128 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9129 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9130 signedness issues.
f839df0c
PE
9131 (Fset_file_times, Finsert_file_contents, auto_save_error):
9132 Rename locals to avoid shadowing.
f14b7e14 9133
5716756e 9134 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9135 (Ftry_completion, Fall_completions): Rename or remove locals
9136 to avoid shadowing.
5716756e 9137
b4c3046a
PE
9138 * marker.c (bytepos_to_charpos): Remove; unused.
9139
b45db522
PE
9140 * lisp.h (verify_bytepos, count_markers): New decls,
9141 so that gcc does not warn that these functions aren't declared.
9142
85876d07
PE
9143 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9144 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9145 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9146 (copy_text): Remove unused local var.
85876d07 9147
03d78a21 9148 * filelock.c (within_one_second): Now static.
b3dd38ab 9149 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9150
5df8f01b
PE
9151 * buffer.c (fix_overlays_before): Mark locals as initialized.
9152 (fix_start_end_in_overlays): Likewise. This function should be
9153 simplified by using pointers-to-pointers, but that's a different
9154 matter.
b1d876f1 9155 (switch_to_buffer_1): Now static.
8f54f30a
PE
9156 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9157 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9158
a70072c9 9159 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9160 Fix pointer signedness issue.
edced198
PE
9161 (sys_subshell): Mark local as volatile if checking for lint,
9162 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9163 (MAXPATHLEN): Define only if needed.
a70072c9 9164
a0977c44
PE
9165 * process.c (serial_open, serial_configure): Move decls from here ...
9166 * systty.h: ... to here, so that they can be checked.
9167
a884fdcc
PE
9168 * fns.c (get_random, seed_random): Move extern decls from here ...
9169 * lisp.h: ... to here, so that they can be checked.
9170
604efe86 9171 * sysdep.c (reset_io): Now static.
b8950c94 9172 (wait_for_termination_signal): Remove; unused.
604efe86 9173
38fc62d9
PE
9174 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9175 (copy_keymap_item, append_key, push_text_char_description):
9176 Now static.
1004a21a 9177 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9178 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9179 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9180 (describe_map_tree):
9181 Rename locals to avoid shadowing.
38fc62d9 9182
2f2650da
PE
9183 * keyboard.c: Declare functions static if they are not used elsewhere.
9184 (echo_char, echo_dash, cmd_error, top_level_2):
9185 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9186 (read_char, kbd_buffer_get_event, make_lispy_position):
9187 (make_lispy_event, make_lispy_movement, apply_modifiers):
9188 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9189 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9190 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9191 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9192 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9193
a053e86c 9194 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9195 (mark_kboards): Move decl here ...
9196 * alloc.c (mark_kboards): ... from here.
a053e86c 9197
4752793e
PE
9198 * lisp.h (force_auto_save_soon): New decl.
9199
74f10ca7 9200 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9201 (DEFINE_DUMMY_FUNCTION): New macro.
9202 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9203 Use it.
c03cd23f
PE
9204 (main): Add casts to avoid warnings
9205 if GCC considers string literals to be constants.
74f10ca7 9206
022e70d4
PE
9207 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9208
59d6fe83
PE
9209 * dbusbind.c: Pointer signedness fixes.
9210 (xd_signature, xd_append_arg, xd_initialize):
9211 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9212 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9213 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9214 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9215
78320123
PE
9216 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9217 if GCC considers string literals to be constants.
49cebcca 9218 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9219
35ac2a97
SM
92202011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9221
fb103ca9
SM
9222 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9223 (print_preprocess, print_object): New macro to fix last change.
9224
35ac2a97
SM
9225 * print.c (print_preprocess): Don't forget font objects.
9226
62973b41
JB
92272011-03-16 Juanma Barranquero <lekktu@gmail.com>
9228
9229 * emacs.c (USAGE3): Doc fixes.
9230
0e48bb22
AS
92312011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9232
9233 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9234 structure.
9235
7684e57b
JB
92362011-03-14 Juanma Barranquero <lekktu@gmail.com>
9237
9238 * lisp.h (VWindow_system, Qfile_name_history):
9239 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9240 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9241 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9242
9243 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9244 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9245
9246 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9247 * w32console.c (detect_input_pending, read_input_pending)
9248 (encode_terminal_code):
9249 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9250 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9251 (w32_system_caret_y, Qfile_name_history):
9252 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9253 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9254 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9255 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9256 * w32proc.c (Qlocal, report_file_error):
9257 * w32term.c (Vwindow_system, updating_frame):
9258 * w32uniscribe.c (initialized, uniscribe_font_driver):
9259 Remove unneeded extern declarations.
9260
2aa46d6c
CY
92612011-03-14 Chong Yidong <cyd@stupidchicken.com>
9262
c96bbc66 9263 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9264
cffc6f3b
CY
92652011-03-13 Chong Yidong <cyd@stupidchicken.com>
9266
9267 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9268 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9269 These macros can no longer be used for assignment.
9270
44f230aa
SM
9271 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9272 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9273 (record_buffer_markers, fetch_buffer_markers): New functions for
9274 recording and fetching special buffer markers.
9275 (set_buffer_internal_1, set_buffer_temp): Use them.
9276
9277 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9278
9279 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9280
9281 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9282 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9283
9284 * xdisp.c (hscroll_window_tree):
9285 (reconsider_clip_changes): Use PT instead of BUF_PT.
9286
d251f04b
EZ
92872011-03-13 Eli Zaretskii <eliz@gnu.org>
9288
9289 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9290 $(EMACS_ROOT)/lib/intprops.h.
9291
f0c77cd1
PE
92922011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9293
3eca4629
PE
9294 Fix more problems found by GCC 4.5.2's static checks.
9295
7c86ee98
PE
9296 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9297 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9298 (xg_free_frame_widgets): Make it clear that a local variable is
9299 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9300 (gdk_window_get_screen): Make it clear that this macro is needed
9301 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9302 (int_gtk_range_get_value): New function, which avoids a diagnostic
9303 from gcc -Wbad-function-cast.
9304 (xg_set_toolkit_scroll_bar_thumb): Use it.
9305 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9306 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9307 (get_utf8_string, xg_get_file_with_chooser):
9308 Rename locals to avoid shadowing.
9309 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9310
41729b81
PE
9311 * xgselect.c (xg_select): Remove unused var.
9312
f0c77cd1
PE
9313 * image.c (four_corners_best): Mark locals as initialized.
9314 (gif_load): Initialize transparent_p to zero (Bug#8238).
9315 Mark another local as initialized.
ec6cf4c6 9316 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9317
ce0ad53d 9318 * image.c (clear_image_cache): Now static.
d5d5a617 9319 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9320 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9321 (x_edge_detection): Remove unnecessary cast that
9322 gcc -Wbad-function-cast diagnoses.
2037898d 9323 (gif_load): Fix pointer signedness.
6ae141d6
PE
9324 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9325 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9326
33383987 93272011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9328
d32df629
PE
9329 Improve quality of tests for time stamp overflow.
9330 For example, without this patch (encode-time 0 0 0 1 1
9331 1152921504606846976) returns the obviously-bogus value (-948597
9332 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9333 reports time overflow. See
9334 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9335 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9336 * editfns.c: Include limits.h and intprops.h.
9337 (TIME_T_MIN, TIME_T_MAX): New macros.
9338 (time_overflow): Move earlier, to before first use.
9339 (hi_time, lo_time): New functions, for an accurate test for
9340 out-of-range times.
9341 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9342 (Fget_internal_run_time): Don't assume time_t fits in int.
9343 (make_time): Use list2 instead of Fcons twice.
9344 (Fdecode_time): More accurate test for out-of-range times.
9345 (check_tm_member): New function.
9346 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9347 (lisp_time_argument): Don't rely on undefined left-shift and
9348 right-shift behavior when checking for time stamp overflow.
8be6f318 9349
fe31d94c
PE
9350 * editfns.c (time_overflow): New function, refactoring common code.
9351 (Fformat_time_string, Fdecode_time, Fencode_time):
9352 (Fcurrent_time_string): Use it.
9353
8be6f318
PE
9354 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9355 * dired.c (make_time): Move to ...
9356 * editfns.c (make_time): ... here.
9357 * systime.h: Note the move.
9358
09d9db2c 93592011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9360
126bc0dc
YM
9361 * fringe.c (update_window_fringes): Remove unused variables.
9362
c47cbdfd
YM
9363 * unexmacosx.c (copy_data_segment): Also copy __got section.
9364 (Bug#8223)
9365
7ac80be9
EZ
93662011-03-12 Eli Zaretskii <eliz@gnu.org>
9367
c96bbc66 9368 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9369 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9370 Constify `char *' arguments and their references according to
9371 prototypes in tparam.h.
9372
ecb0f94d 9373 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9374
7ac80be9
EZ
9375 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9376 Adapt all references accordingly.
9377
9378 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9379
ef1fd07e
TT
93802011-03-11 Tom Tromey <tromey@redhat.com>
9381
9382 * buffer.c (syms_of_buffer): Remove obsolete comment.
9383
7ef4b50c
EZ
93842011-03-11 Eli Zaretskii <eliz@gnu.org>
9385
9386 * termhooks.h (encode_terminal_code): Declare prototype.
9387
9388 * msdos.c (encode_terminal_code): Don't declare prototype.
9389
9390 * term.c (encode_terminal_code): Now external again, used by
9391 w32console.c and msdos.c.
9392
44f230aa
SM
9393 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9394 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9395
4b1ec863 93962011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9397
1714f52b 9398 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9399
4b1ec863
PE
9400 * fringe.c (update_window_fringes): Mark locals as initialized
9401 (Bug#8227).
9402 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9403
524c7aa6
PE
9404 * alloc.c (mark_fringe_data): Move decl from here ...
9405 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9406 to check its interface.
9407 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9408
a5c0af81 9409 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9410 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9411 (fontset_font): Mark local as initialized.
a9a06e0b 9412 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9413
b4716021
PE
9414 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9415
811e9bac 9416 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9417 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9418 (x_own_selection, Fx_disown_selection_internal): Rename locals
9419 to avoid shadowing.
9420 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9421
7e3ab302
PE
9422 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9423 so that the caller can use some name other than gcpro1.
9424 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9425 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9426 (Fx_backspace_delete_keys_p):
9427 Use them to avoid shadowing, and rename vars to avoid shadowing.
9428 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9429 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9430 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9431 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9432 Remove unused locals.
7e3ab302
PE
9433 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9434 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9435 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9436 macros.
f78faa98 9437
e2b13473
PE
9438 * xterm.h (x_mouse_leave): New decl.
9439
77f23912
PE
9440 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9441 Remove unused functions.
cdf4ba58
PE
9442 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9443 (x_calc_absolute_position): Now static.
7411c686 9444 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9445 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9446 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9447 unless they are used.
38d0b34a
PE
9448 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9449 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9450 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9451 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9452 (x_error_catcher, x_connection_closed, x_error_handler):
9453 (x_error_quitter, xembed_send_message, x_iconify_frame):
9454 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9455 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9456 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9457
44f230aa
SM
9458 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9459 Rename or move locals to avoid shadowing.
6b463e58 9460 (tty_defined_color, merge_face_heights): Now static.
5967d051 9461 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9462 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9463 does not deduce is never used uninitialized.
73719eba
PE
9464 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9465 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9466
426994c3 9467 * terminal.c (store_terminal_param): Now static.
5489860b 9468
032f1620 9469 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9470 (set_frame_menubar): Remove unused local.
d4323972 9471 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9472 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9473 since they might point to immutable storage.
281585b0
PE
9474 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9475 since it's unused otherwise.
032f1620 9476
367c19e5 9477 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9478 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9479 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9480 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9481 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9482 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9483 does not deduce are never used uninitialized.
70739cbe 9484
07b48fa9
PE
9485 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9486
8868a238 9487 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9488 * window.c (window_loop, size_window):
9489 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9490
7e5cf297 9491 * window.c (display_buffer): Now static.
d6550a9f
PE
9492 (size_window): Mark variables that gcc -Wuninitialized
9493 does not deduce are never used uninitialized.
a586633d
PE
9494 * window.h (check_all_windows): New decl, to forestall
9495 gcc -Wmissing-prototypes diagnostic.
5b555da1 9496 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9497
f6095868
PE
9498 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9499 shadowing.
9500 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9501 Include <limits.h>.
9502 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9503 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9504 (load_charset_map): Mark variables that gcc -Wuninitialized
9505 does not deduce are never used uninitialized.
53df7c11 9506 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9507
f38b440c
PE
9508 * coding.c (coding_set_source, coding_set_destination):
9509 Use "else { /* comment */ }" rather than "else /* comment */;"
9510 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9511 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9512 a block, when the outer 'i' will do.
9513 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9514 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9515 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9516 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9517 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9518 Rename locals to avoid shadowing.
9519 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9520 * coding.c (emacs_mule_char, encode_invocation_designation):
9521 Now static, since they're not used elsewhere.
413bb2db 9522 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9523 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9524 (decode_coding_emacs_mule): Mark variables that gcc
9525 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9526 (detect_coding_iso_2022): Initialize a local variable that might
9527 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9528 this initialization is needed. (Bug#8211)
5f58e762
PE
9529 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9530 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9531 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9532 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9533 Remove unused macros.
f38b440c 9534
232b38b9 9535 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9536 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9537 * character.c (string_count_byte8): Likewise.
232b38b9 9538
fb90da1b
PE
9539 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9540 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9541
fb93dbc2
PE
9542 * chartab.c (copy_sub_char_table): Now static, since it's not used
9543 elsewhere.
5c156ace
PE
9544 (sub_char_table_ref_and_range, char_table_ref_and_range):
9545 Rename locals to avoid shadowing.
bbcd0949 9546 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9547
7d3b3862 9548 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9549 (BIDI_BOB): Remove unused macro.
7d3b3862 9550
6be7d3da
PE
9551 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9552 deduce are never used uninitialized.
c2ed9c8b 9553 * term.c (encode_terminal_code): Likewise.
6be7d3da 9554
75f8807f 9555 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9556
50938595
PE
9557 * tparam.h: New file.
9558 * term.c, tparam.h: Include it.
9559 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9560 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9561 Move these decls to tparam.h, and make them agree with what
9562 is actually in tparam.c. The previous trick of using incompatible
9563 decls in different modules does not conform to the C standard.
9564 All callers of tparam changed to use tparam's actual API.
9565 * tparam.c (tparam1, tparam, tgoto):
9566 Use const pointers where appropriate.
9567
fbceeba2
PE
9568 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9569 * cm.h (struct cm): Likewise.
9570 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9571 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9572 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9573 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9574 (turn_on_face, init_tty): Likewise.
9575 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9576
7f3f1250
PE
9577 * term.c (term_mouse_position): Rename local to avoid shadowing.
9578
e6ca6543
PE
9579 * alloc.c (mark_ttys): Move decl from here ...
9580 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9581
c40f8d15
AS
95822011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9583
9584 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9585
cfe0661d
JB
95862011-03-09 Juanma Barranquero <lekktu@gmail.com>
9587
9588 * search.c (compile_pattern_1): Remove argument regp, unused since
9589 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9590 (compile_pattern): Don't pass it.
9591
0afb4571
J
95922011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9593
9594 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9595 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9596 for ! HAVE_GTK3.
9597 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9598
9599 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9600
9601 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9602 gdk_window_get_screen, gdk_window_get_geometry,
9603 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9604 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9605 (xg_get_pixbuf_from_pixmap): New function.
9606 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9607 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9608 Call xg_get_pixbuf_from_pixmap instead of
9609 gdk_pixbuf_get_from_drawable.
9610 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9611 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9612 (xg_check_special_colors): Use GtkStyleContext and its functions
9613 for HAVE_GTK3.
9614 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9615 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9616 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9617 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9618 Call gtk_widget_get_preferred_size.
0afb4571
J
9619 (xg_frame_resized): gdk_window_get_geometry only takes 5
9620 parameters.
44f230aa
SM
9621 (xg_win_to_widget, xg_event_is_for_menubar):
9622 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9623 (xg_set_widget_bg): New function.
9624 (delete_cb): New function.
895009e1 9625 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9626 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9627 (xg_set_background_color): Call xg_set_widget_bg.
9628 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9629 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9630 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9631 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9632 if ! HAVE_GTK3.
9633 (update_frame_tool_bar): Call gtk_widget_hide.
9634 (xg_initialize): Use GDK_KEY_g.
9635
9636 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9637 if ! HAVE_GTK3
9638 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9639
9640 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9641 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9642 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9643
1c2cc4ef
JB
96442011-03-08 Juanma Barranquero <lekktu@gmail.com>
9645
9646 * w32xfns.c (select_palette): Check success of RealizePalette against
9647 GDI_ERROR, not zero.
9648
33383987 9649See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9650
9651;; Local Variables:
9652;; coding: utf-8
aac0c6e3
MR
9653;; End:
9654
acaf905b 9655 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9656
9657 This file is part of GNU Emacs.
9658
9659 GNU Emacs is free software: you can redistribute it and/or modify
9660 it under the terms of the GNU General Public License as published by
9661 the Free Software Foundation, either version 3 of the License, or
9662 (at your option) any later version.
9663
9664 GNU Emacs is distributed in the hope that it will be useful,
9665 but WITHOUT ANY WARRANTY; without even the implied warranty of
9666 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9667 GNU General Public License for more details.
9668
9669 You should have received a copy of the GNU General Public License
9670 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.