* emacs.c (main, sort_args): Check for size-calculation overflow.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bc18e09d
PE
12011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
b4fb6314
PE
3 * emacs.c (main, sort_args): Check for size-calculation overflow.
4
c9f8d652
PE
5 * editfns.c: Integer and memory overflow fixes.
6 (set_time_zone_rule): Don't assume environment length fits in int.
7 (message_length): Now ptrdiff_t, not int.
8 (Fmessage_box): Don't update size until allocation succeeds.
9 Don't assume message length fits in int.
10 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
11
3d0c92a2
PE
12 * doc.c: Integer and memory overflow fixes.
13 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
14 (get_doc_string): Check for size calculation overflow.
15 Don't update size until allocation succeeds.
16 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
17 EMACS_INT, where ptrdiff_t will do.
18 (Fsubstitute_command_keys): Check for string overflow.
19
ca9ce8f2
PE
20 Integer and memory overflow fixes for display code.
21 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
22 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
23 Check for overflow in size calculations.
24 (line_draw_cost, realloc_glyph_pool, add_row_entry):
25 Don't assume glyph table len fits in int.
26 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
27 (row_table_size): Now ptrdiff_t, not int.
28 (scrolling_window): Avoid overflow in size calculations.
29 Don't update size until allocation succeeds.
30 * fns.c (concat): Check for overflow in size calculations.
31 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
32 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
33 (NEXT_ALMOST_PRIME_LIMIT): New constant.
34
d86d0d74
PE
35 * composite.c: Integer overflow fixes.
36 (get_composition_id): Check for overflow in glyph length calculations.
37
5d009b3a
PE
38 * coding.c: Integer and memory overflow fixes.
39 (produce_chars): Redo buffer-overflow calculations to avoid
40 unnecessary integer overflow. Check for size overflow.
41 (encode_coding_object): Don't update size until xmalloc succeeds.
42
17828df2
PE
43 * character.c (Fstring): Check for size-calculation overflow.
44
69e8622f
PE
45 * ccl.c: Integer and memory overflow fixes.
46 (Fccl_execute_on_string): Check for memory overflow.
47 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
48 Redo buffer-overflow calculations to avoid integer overflow.
49
860887db
PE
50 * callproc.c (child_setup): Don't assume strlen fits in int.
51
6e1fc452
PE
52 * buffer.c: Memory overflow fixes.
53 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
54 Don't update size of array until after memory allocation succeeds,
55 because xmalloc/xrealloc may not return.
56
bc18e09d
PE
57 * bidi.c: Integer overflow fix.
58 (bidi_shelve_header_size): New constant.
59 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
60 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
61
5637687f
PE
622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
63
ebfa62c0
PE
64 Use ptrdiff_t for composition IDs.
65 * character.c (lisp_string_width):
66 * composite.c (composition_table_size, n_compositions)
67 (get_composition_id, composition_gstring_from_id):
68 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
69 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
70 * window.c (Frecenter):
71 Use ptrdiff_t, not int, for composition IDs.
72 * composite.c (get_composition_id): Check for integer overflow.
73 * composite.h: Adjust prototypes to match the above changes.
74
d3411f89
PE
75 Use ptrdiff_t for hash table indexes.
76 * category.c (hash_get_category_set):
77 * ccl.c (ccl_driver):
78 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
79 * coding.c (coding_system_charset_list, detect_coding_system):
80 * coding.h (struct coding_system.id):
81 * composite.c (get_composition_id, gstring_lookup_cache):
82 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
83 * image.c (xpm_get_color_table_h):
84 * lisp.h (hash_lookup, hash_put):
85 * minibuf.c (Ftest_completion):
86 Use ptrdiff_t for hash table indexes, not int (which is too
87 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
88 32-bit --with-wide-int hosts).
89
e097a6fa
PE
90 * charset.c (Fdefine_charset_internal): Check for integer overflow.
91 Add a FIXME comment about memory leaks.
92 (syms_of_charset): Don't assume xmalloc returns.
93
5637687f
PE
94 Don't assume that stated character widths fit in int.
95 * character.c (Fchar_width, c_string_width, lisp_string_width):
96 * character.h (CHAR_WIDTH):
97 * indent.c (MULTIBYTE_BYTES_WIDTH):
98 Use sanitize_char_width to avoid undefined and/or bad behavior
99 with outlandish widths.
100 * character.h (sanitize_tab_width): Renamed from sanitize_width,
101 now that we have two such functions. All uses changed.
102 (sanitize_char_width): New inline function.
103
a2271ba2
PE
104 Don't assume that tab-width fits in int.
105 * character.h (sanitize_width): New inline function.
106 (SANE_TAB_WIDTH): New macro.
107 (ASCII_CHAR_WIDTH): Use it.
108 * indent.c (sane_tab_width): Remove. All uses replaced by
109 SANE_TAB_WIDTH (current_buffer).
110 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
111
18c52557
PE
112 * fileio.c: Integer overflow issues with file modes.
113 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
114
caeeedc1
PE
115 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
116 Remove unreachable code.
117 (read_hex, load_charset_map_from_file): Check for integer overflow.
118
50849c52
PE
119 * xterm.c: don't go over XClientMessageEvent limit
120 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
121 (x_send_scroll_bar_event): Likewise. Check that the size does not
122 exceed limits imposed by XClientMessageEvent, as well as the usual
123 ptrdiff_t and size_t limits.
124
b13995db
PE
125 * keyboard.c: Overflow, signedness and related fixes.
126 (make_lispy_movement): Use same integer type in forward decl
127 that is used in the definition.
128 (read_key_sequence, keyremap_step):
129 Change bufsize argument back to int, undoing my 2011-03-30 change.
130 We prefer signed types, and int is wide enough here.
131 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
132 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
133 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
134 length, not size_t. Use ptrdiff_t for index, not int.
135 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
136 possibility of integer overflow.
137
13464394
PE
138 Overflow, signedness and related fixes for images.
139
140 * dispextern.h (struct it.stack[0].u.image.image_id)
141 (struct_it.image_id, struct image.id, struct image_cache.size)
142 (struct image_cache.used, struct image_cache.ref_count):
143 * gtkutil.c (update_frame_tool_bar):
144 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
145 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
146 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
147 * nsmenu.m (update_frame_tool_bar):
148 * xdisp.c (calc_pixel_width_or_height):
149 * xfns.c (image_cache_refcount):
150 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
151 on typical 64-bit hosts.
152
153 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
154 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
155 Omit unnecessary casts to int.
156 (parse_image_spec): Check that integers fall into 'int' range
157 when the callers expect that.
158 (image_ascent): Redo ascent calculation to avoid int overflow.
159 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
160 (lookup_image): Remove unnecessary tests.
161 (xbm_image_p): Locals are now of int, not EMACS_INT,
162 since parse_image_check makes sure they fit into int.
163 (png_load, gif_load, svg_load_image):
164 Prefer int to unsigned where either will do.
165 (tiff_handler): New function, combining the cores of the
166 old tiff_error_handler and tiff_warning_handler. This
167 function is rewritten to use vsnprintf and thereby avoid
168 stack buffer overflows. It uses only the features of vsnprintf
169 that are common to both POSIX and native Microsoft.
170 (tiff_error_handler, tiff_warning_handler): Use it.
171 (tiff_load, gif_load, imagemagick_load_image):
172 Don't assume :index value fits in 'int'.
173 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
174 (imagemagick_load_image): Check that crop parameters fit into
175 the integer types that MagickCropImage accepts. Don't assume
176 Vimagemagick_render_type has a nonnegative value. Don't assume
177 size_t fits in 'long'.
178 (gs_load): Use printmax_t to print the widest integers possible.
179 Check for integer overflow when computing image height and width.
180
0d8de0fd 1812011-07-19 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 182
41f55ccd 183 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 184
39e378da
PE
185 * bidi.c: Integer size and overflow fixes.
186 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
187 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
188 (bidi_cache_find_level_change, bidi_cache_ensure_space)
189 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
190 (bidi_find_other_level_edge):
191 Use ptrdiff_t instead of EMACS_INT where either will do.
192 This works better on 32-bit hosts configured --with-wide-int.
193 (bidi_cache_ensure_space): Check for size-calculation overflow.
194 Use % rather than repeated addition, for better worst-case speed.
195 Don't set bidi_cache_size until after xrealloc returns, because it
196 might not return.
197 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
198 (bidi_cache_ensure_space): Also check that the bidi cache size
199 does not exceed that of the largest Lisp string or buffer. See Eli
200 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 201
5e927815
PE
202 * alloc.c (__malloc_size_t): Remove.
203 All uses replaced by size_t. See Andreas Schwab's note
204 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
205
ca4aa935
PE
206 * image.c: Improve checking for integer overflow.
207 (check_image_size): Assume that f is nonnull, since
208 it is always nonnull in practice. This is one less thing to
209 worry about when checking for integer overflow later.
210 (x_check_image_size): New function, which checks for integer
211 overflow issues inside X.
212 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
213 This removes the need for a memory_full check.
214 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
215 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
216 (xbm_read_bitmap_data): Change locals back to 'int', since
217 their values must fit in 'int'.
218 (xpm_load_image, png_load, tiff_load):
219 Invoke x_create_x_image_and_pixmap earlier,
220 to avoid much needless work if the image is too large.
221 (tiff_load): Treat overly large images as if
222 x_create_x_image_and_pixmap failed, not as malloc failures.
223 (gs_load): Use x_check_image_size.
224
5f8f9cc2
PE
225 * gtkutil.c: Omit integer casts.
226 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
227 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
228
5adf60bc
PE
229 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
230
c8907a93
PE
231 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
232 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
233 would wrongly return t on a 64-bit host.
234
e3c25c68
PE
235 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
236 The plain *_OVERFLOW macros run afoul of GCC bug 49705
237 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
238 and therefore cause GCC to emit a bogus diagnostic in some cases.
239
3f791afe
PE
240 * image.c: Integer signedness and overflow and related fixes.
241 This is not an exhaustive set of fixes, but it's time to
242 record what I've got.
243 (lookup_pixel_color, check_image_size): Remove redundant decls.
244 (check_image_size): Don't assume that arbitrary EMACS_INT values
245 fit in 'int', or that arbitrary 'double' values fit in 'int'.
246 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
247 (tiff_load, imagemagick_load_image):
248 Check for overflow in size calculations.
249 (x_create_x_image_and_pixmap): Remove unnecessary test for
250 xmalloc returning NULL; that can't happen.
251 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
252 (xpm_color_bucket): Use better integer hashing function.
253 (xpm_cache_color): Don't possibly over-allocate memory.
254 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
255 (gif_memory_source):
256 Use ptrdiff_t, not int or size_t, to record sizes.
257 (png_load): Don't assume values greater than 2**31 fit in 'int'.
258 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
259 either works, as we prefer signed integers.
260 (tiff_read_from_memory, tiff_write_from_memory):
261 Return tsize_t, not size_t, since that's what the TIFF API wants.
262 (tiff_read_from_memory): Don't fail simply because the read would
263 go past EOF; instead, return a short read.
264 (tiff_load): Omit no-longer-needed casts.
265 (Fimagemagick_types): Don't assume size fits into 'int'.
266
3cc5a532
PE
267 Improve hashing quality when configured --with-wide-int.
268 * fns.c (hash_string): New function, taken from sxhash_string.
269 Do not discard information about ASCII character case; this
270 discarding is no longer needed.
271 (sxhash-string): Use it. Change sig to match it. Caller changed.
272 * lisp.h: Declare it.
273 * lread.c (hash_string): Remove, since we now use fns.c's version.
274 The fns.c version returns a wider integer if --with-wide-int is
275 specified, so this should help the quality of the hashing a bit.
276
b312a492
PE
277 * emacs.c: Integer overflow minor fix.
278 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
279 Define only if GNU_LINUX.
280 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
281
dfd153ae
PE
282 * dispnew.c: Integer signedness and overflow fixes.
283 Remove unnecessary forward decls, that were a maintenance hassle.
284 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
285 All uses changed.
286 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
287 (scrolling_window): Use ptrdiff_t, not int, for byte count.
288 (prepare_desired_row, line_draw_cost):
289 Use int, not unsigned, where either works.
290 (save_current_matrix, restore_current_matrix):
291 Use ptrdiff_t, not size_t, where either works.
292 (init_display): Check for overflow more accurately, and without
293 relying on undefined behavior.
294
a81d11a3
PE
295 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
296 Remove, replacing with the new symbols in lisp.h. All uses changed.
297 * fileio.c (make_temp_name):
298 * filelock.c (lock_file_1, lock_file):
299 * xdisp.c (message_dolog):
300 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
301 Use pMd etc. instead.
302 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
303 replacing the pWIDE etc. symbols removed from editfns.c.
304
3300e6fd
PE
305 * keyboard.h (num_input_events): Now uintmax_t.
306 This is (very slightly) less likely to mess up due to wraparound.
307 All uses changed.
308
fd05c7e9
PE
309 * buffer.c: Integer signedness fixes.
310 (alloc_buffer_text, enlarge_buffer_text):
311 Use ptrdiff_t rather than size_t when either will do, as we prefer
312 signed integers.
313
903fe15d
PE
314 * alloc.c: Integer signedness and overflow fixes.
315 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
316 (__malloc_size_t): Default to size_t, not to int.
317 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
318 (Fgarbage_collect, mark_object_loop_halt, mark_object):
319 Prefer ptrdiff_t to size_t when either would do, as we prefer
320 signed integers.
321 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
322 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
323 Now const. Initialize with values that are in range even if char
324 is signed.
325 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
326 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
327 These functions do the right thing with sizes > 2**32.
328 (check_depth): Now ptrdiff_t, not int.
329 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
330 Adjust to new way of storing sizes. Check for size overflow bugs
331 in rest of code.
332 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
333 slightly wrong anyway, as it missed one instance of
334 XMALLOC_OVERRUN_CHECK_OVERHEAD.
335 (refill_memory_reserve): Omit needless cast to size_t.
336 (mark_object_loop_halt): Mark as externally visible.
337
ac82cc6a
PE
338 * xselect.c: Integer signedness and overflow fixes.
339 (Fx_register_dnd_atom, x_handle_dnd_message):
340 Use ptrdiff_t, not size_t, since we prefer signed.
341 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
342 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
343 x_dnd_atoms_size and x_dnd_atoms_length.
344
c2d1e36d
PE
345 * doprnt.c: Prefer signed to unsigned when either works.
346 * eval.c (verror):
347 * doprnt.c (doprnt):
348 * lisp.h (doprnt):
349 * xdisp.c (vmessage):
350 Use ptrdiff_t, not size_t, when using or implementing doprnt,
351 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
352 prefer signed arithmetic to avoid comparison confusion.
353 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
354 but is a bit tricky.
355
0e926e56
PE
356 Assume freestanding C89 headers, string.h, stdlib.h.
357 * data.c, doprnt.c, floatfns.c, print.c:
358 Include float.h unconditionally.
359 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
360 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
361 * regex.c: Likewise for stddef.h, string.h.
362 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
363 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
364 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
365 (STDC_HEADERS): Remove obsolete defines.
366 * sysdep.c: Include limits.h unconditionally.
367
9cfdb3ec
PE
368 Assume support for memcmp, memcpy, memmove, memset.
369 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
370 * regex.c (memcmp, memcpy):
371 Remove; we assume C89 now.
372
373 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
374 (__malloc_safe_bcopy): Remove; no longer needed.
375
cf950e6b 376 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
377 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
378 well either way, and we prefer signed to unsigned.
379
590bd467
PE
3802011-07-19 Paul Eggert <eggert@cs.ucla.edu>
381
382 Port to OpenBSD.
383 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
384 and the surrounding thread.
385 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
386 rather than fgets, and retry after EINTR. Otherwise, 'emacs
387 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
388 timer goes off.
389 * s/openbsd.h (BROKEN_SIGIO): Define.
390 * unexelf.c (unexec) [__OpenBSD__]:
391 Don't update the .mdebug section of the Alpha COFF symbol table.
392
f41628b2
LMI
3932011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
394
395 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
396 (bug#8460).
397
b59b67c5
PE
3982011-07-18 Paul Eggert <eggert@cs.ucla.edu>
399
15e3a074
PE
400 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
401 This fixes some race conditions on the permissions of any newly
402 created file.
403
41bed37d
PE
404 * alloc.c (valid_pointer_p): Use pipe, not open.
405 This fixes some permissions issues when debugging.
406
b59b67c5
PE
407 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
408 If fchown fails to set both uid and gid, try to set just gid,
409 as that is sometimes allowed. Adjust the file's mode to eliminate
410 setuid or setgid bits that are inappropriate if fchown fails.
411
925a6be7
SM
4122011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
413
414 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
415 to compare Lisp_Objects.
416 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
417 global_gnutls_log_level, don't mistake it for a Lisp_Object.
418 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
419
52968808
AS
4202011-07-17 Andreas Schwab <schwab@linux-m68k.org>
421
0a6a104b
AS
422 * lread.c (read_integer): Unread even EOF character.
423 (read1): Likewise. Properly record start position of symbol.
424
52968808
AS
425 * lread.c (read1): Read `#:' as empty uninterned symbol if no
426 symbol character follows.
427
9e381cdd
PE
4282011-07-17 Paul Eggert <eggert@cs.ucla.edu>
429
430 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
431 This works around a problem with the previous change to Fcopy_file.
432 Recent glibc declares fchown with __attribute__((warn_unused_result)),
433 and without this change, GCC might complain about discarding
434 fchown's return value.
435
b5641435
JB
4362011-07-16 Juanma Barranquero <lekktu@gmail.com>
437
438 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
439
a8031457
PE
4402011-07-16 Paul Eggert <eggert@cs.ucla.edu>
441
442 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
443
dd889327
LMI
4442011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
445
750c33f7
LMI
446 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
447 it's used from the C level.
448
dd889327
LMI
449 * process.c: Use the same condition for POLL_FOR_INPUT in both
450 keyboard.c and process.c (bug#1858).
451
87e86684
LM
4522011-07-09 Lawrence Mitchell <wence@gmx.li>
453
454 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
455 (Fgnutls_boot): Use it.
456
64348f40
AS
4572011-07-15 Andreas Schwab <schwab@linux-m68k.org>
458
459 * doc.c (Fsubstitute_command_keys): Revert last change.
460
1d698799
LMI
4612011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
462
f863868c
LMI
463 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
464 quotes the next character, and doesn't affect other longer
465 sequences (bug#8935).
466
1d698799
LMI
467 * lread.c (syms_of_lread): Clarify that is isn't only
468 `eval-buffer' and `eval-defun' that's affected by
469 `lexical-binding' (bug#8460).
470
aa4b6df6
EZ
4712011-07-15 Eli Zaretskii <eliz@gnu.org>
472
473 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
474 bidi redisplay when a line includes both an image and is
475 truncated.
476
5d856da6
PE
4772011-07-14 Paul Eggert <eggert@cs.ucla.edu>
478
ad6042bb
PE
479 Fix minor problems found by static checking.
480 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
481 (elsz): Now a signed constant, not a size_t var. We prefer signed
482 types to unsigned, to avoid integer comparison confusion. Without
483 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
484 "cannot optimize loop, the loop counter may overflow", a symptom
485 of the confusion.
f00bbb22 486 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
487 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
488
6468f31c
LMI
4892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
490
49080b10
LMI
491 * search.c (Fre_search_backward): Mention `case-fold-search' in
492 all the re_search_* functions (bug#8138).
493
6468f31c
LMI
494 * keyboard.c (Fopen_dribble_file): Document when the file is
495 closed (bug#8056).
496
c965adc5
EZ
4972011-07-14 Eli Zaretskii <eliz@gnu.org>
498
df9733bf
EZ
499 * bidi.c (bidi_dump_cached_states): Fix format of displaying
500 bidi_cache_idx.
501
0bb23927
EZ
502 Support bidi reordering of display and overlay strings.
503 * xdisp.c (compute_display_string_pos)
504 (compute_display_string_end): Accept additional argument STRING.
505 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
506 (reseat_to_string): Initialize bidi_it->string.s and
507 bidi_it->string.schars.
508 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
509 NULL (avoids a crash in bidi_paragraph_init). Initialize
510 itb.string.lstring.
511 (init_iterator): Call bidi_init_it only of a valid
512 buffer position was specified. Initialize paragraph_embedding to
513 L2R.
514 (reseat_to_string): Initialize the bidi iterator.
515 (display_string): If we need to ignore text properties of
516 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
517 original value of -1 will not work with bidi.)
518 (compute_display_string_pos): First arg is now struct
519 `text_pos *'; all callers changed. Support display properties on
520 Lisp strings.
521 (compute_display_string_end): Support display properties on Lisp
522 strings.
523 (init_iterator, reseat_1, reseat_to_string): Initialize the
524 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
525 when iterating on a string not from display properties).
526 (compute_display_string_pos, compute_display_string_end): Fix
527 calculation of the object to scan. Fixes an error when using
528 arrow keys.
529 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
530 base_level_stop; instead, set base_level_stop to BEGV. Fixes
531 crashes in vertical-motion.
532 (next_element_from_buffer): Improve commentary for when
533 the iterator is before prev_stop.
534 (init_iterator): Initialize bidi_p from the default value of
535 bidi-display-reordering, not from buffer-local value. Use the
536 buffer-local value only if initializing for buffer iteration.
537 (handle_invisible_prop): Support invisible properties on strings
538 that are being bidi-reordered.
539 (set_iterator_to_next): Support bidi reordering of C strings and
540 Lisp strings.
541 (next_element_from_string): Support bidi reordering of Lisp
542 strings.
543 (handle_stop_backwards): Support Lisp strings as well.
544 (display_string): Support display of R2L glyph rows. Use
545 IT_STRING_CHARPOS when displaying from a Lisp string.
546 (init_iterator): Don't initialize it->bidi_p for strings
547 here.
548 (reseat_to_string): Initialize it->bidi_p for strings here.
549 (next_element_from_string, next_element_from_c_string)
550 (next_element_from_buffer): Add xassert's for correspondence
551 between IT's object being iterated and it->bidi_it.string
552 structure.
553 (face_before_or_after_it_pos): Support bidi iteration.
554 (next_element_from_c_string): Handle the case of the first string
555 character that is not the first one in the visual order.
556 (get_visually_first_element): New function, refactored from common
557 parts of next_element_from_buffer, next_element_from_string, and
558 next_element_from_c_string.
559 (tool_bar_lines_needed, redisplay_tool_bar)
560 (display_menu_bar): Force left-to-right direction. Add a FIXME
561 comment for making that be controlled by a user option.
562 (push_it, pop_it): Save and restore the state of the
563 bidi iterator. Save and restore the bidi_p flag.
564 (pop_it): Iterate out of display property for string iteration as
565 well.
566 (iterate_out_of_display_property): Support iteration over strings.
567 (handle_single_display_spec): Set up it->bidi_it for iteration
568 over a display string, and call bidi_init_it.
569 (handle_single_display_spec, next_overlay_string)
570 (get_overlay_strings_1, push_display_prop): Set up the bidi
571 iterator for displaying display or overlay strings.
572 (forward_to_next_line_start): Don't use the shortcut if
573 bidi-iterating.
574 (back_to_previous_visible_line_start): If handle_display_prop
575 pushed the iterator stack, restore the internal state of the bidi
576 iterator by calling bidi_pop_it same number of times.
577 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
578 and we are bidi-iterating, don't decrement the iterator position;
579 instead, set the first_elt flag in the bidi iterator, to produce
580 the same effect.
581 (reseat_1): Remove redundant setting of string_from_display_prop_p.
582 (push_display_prop): xassert that we are iterating a buffer.
583 (push_it, pop_it): Save and restore paragraph_embedding member.
584 (handle_single_display_spec, next_overlay_string)
585 (get_overlay_strings_1, reseat_1, reseat_to_string)
586 (push_display_prop): Set up the `unibyte' member of bidi_it.string
587 correctly. Don't assume unibyte strings are not bidi-reordered.
588 (compute_display_string_pos)
589 (compute_display_string_end): Fix handling the case of C string.
590 (push_it, pop_it): Save and restore from_disp_prop_p.
591 (handle_single_display_spec, push_display_prop): Set the
592 from_disp_prop_p flag.
593 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
594 (pop_it): Call iterate_out_of_display_property only if we are
595 popping after iteration over a string that came from a display
596 property. Fix a typo in popping stretch info. Add an assertion
597 for verifying that the iterator position is in sync with the bidi
598 iterator.
599 (handle_single_display_spec, get_overlay_strings_1)
600 (push_display_prop): Fix initialization of paragraph direction for
601 string when that of the parent object is not yet determined.
602 (reseat_1): Call bidi_init_it to resync the bidi
603 iterator with IT's position. (Bug#7616)
604 (find_row_edges): If ROW->start.pos gives position
605 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
606 (handle_stop, back_to_previous_visible_line_start, reseat_1):
607 Reset the from_disp_prop_p flag.
608 (SAVE_IT, RESTORE_IT): New macros.
609 (pos_visible_p, face_before_or_after_it_pos)
610 (back_to_previous_visible_line_start)
611 (move_it_in_display_line_to, move_it_in_display_line)
612 (move_it_to, move_it_vertically_backward, move_it_by_lines)
613 (try_scrolling, redisplay_window, display_line): Use them when
614 saving a temporary copy of the iterator and restoring it back.
615 (back_to_previous_visible_line_start, reseat_1)
616 (init_iterator): Empty the bidi cache "stack".
617 (move_it_in_display_line_to): If iterator ended up at
618 EOL, but we never saw any buffer positions smaller than
619 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
620 motion in bidi-reordered lines.
621 (move_it_in_display_line_to): Record prev_method and prev_pos
622 immediately before the call to set_iterator_to_next. Fixes cursor
623 motion in bidi-reordered lines with stretch glyphs and strings
624 displayed in margins. (Bug#8133) (Bug#8867)
625 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
626 TO_CHARPOS.
627 (pos_visible_p): Support positions in bidi-reordered lines. Save
628 and restore bidi cache.
629
630 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
631 (bidi_paragraph_info): Delete unused struct.
632 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
633 (bidi_cache_start): New variable.
634 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
635 to zero.
636 (bidi_cache_fetch_state, bidi_cache_search)
637 (bidi_cache_find_level_change, bidi_cache_iterator_state)
638 (bidi_cache_find, bidi_peek_at_next_level)
639 (bidi_level_of_next_char, bidi_find_other_level_edge)
640 (bidi_move_to_visually_next): Compare cache index with
641 bidi_cache_start rather than with zero.
642 (bidi_fetch_char): Accept new argument STRING; all callers
643 changed. Support iteration over a string. Support strings with
644 display properties. Support unibyte strings. Fix the type of
645 `len' according to what STRING_CHAR_AND_LENGTH expects.
646 (bidi_paragraph_init, bidi_resolve_explicit_1)
647 (bidi_resolve_explicit, bidi_resolve_weak)
648 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
649 iteration over a string.
650 (bidi_set_sor_type, bidi_resolve_explicit_1)
651 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
652 can now be zero (for strings); special values 0 and -1 were
653 changed to -1 and -2, respectively.
654 (bidi_char_at_pos): New function.
655 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
656 Call it instead of FETCH_MULTIBYTE_CHAR.
657 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
658 initialized to valid values.
659 (bidi_init_it): Don't initialize charpos and bytepos with invalid
660 values.
661 (bidi_level_of_next_char): Allow the sentinel "position" to pass
662 the test for valid cached positions. Fix the logic for looking up
663 the sentinel state in the cache. GCPRO the Lisp string we are
664 iterating.
665 (bidi_push_it, bidi_pop_it): New functions.
666 (bidi_initialize): Initialize the bidi cache start stack pointer.
667 (bidi_cache_ensure_space): New function, refactored from part of
668 bidi_cache_iterator_state. Don't assume the required size is just
669 one BIDI_CACHE_CHUNK away.
670 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
671 (bidi_count_bytes, bidi_char_at_pos): New functions.
672 (bidi_cache_search): Don't assume bidi_cache_last_idx is
673 always valid if bidi_cache_idx is valid.
674 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
675 is valid if it's going to be used.
676 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
677 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
678 (bidi_cache_find_level_change, bidi_cache_ensure_space)
679 (bidi_cache_iterator_state, bidi_cache_find)
680 (bidi_find_other_level_edge, bidi_cache_start_stack): All
681 variables related to cache indices are now EMACS_INT.
682
0bb23927
EZ
683 * dispextern.h (struct bidi_string_data): New structure.
684 (struct bidi_it): New member `string'. Make flag members be 1-bit
685 fields, and put them last in the struct.
686 (compute_display_string_pos, compute_display_string_end): Update
687 prototypes.
688 (bidi_push_it, bidi_pop_it): Add prototypes.
689 (struct iterator_stack_entry): New members bidi_p,
690 paragraph_embedding, and from_disp_prop_p.
691 (struct it): Member bidi_p is now a bit field 1 bit wide.
692 (bidi_shelve_cache, bidi_unshelve_cache): Declare
693 prototypes.
694
695 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
696 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
697 and vector-like objects.
698
699 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
700 cache around display iteration.
701
702 * window.c (Fwindow_end, window_scroll_pixel_based)
703 (displayed_window_lines, Frecenter): Save and restore the bidi
704 cache around display iteration.
705
3bbd2265
LMI
7062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
707
708 * editfns.c (Fdelete_region): Clarify the use of the named
709 parameters (bug#6788).
710
adc47434
MR
7112011-07-14 Martin Rudalics <rudalics@gmx.at>
712
713 * indent.c (Fvertical_motion): Set and restore w->pointm when
714 saving and restoring the window's buffer (Bug#9006).
715
837c31f8
LMI
7162011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
717
718 * editfns.c (Fstring_to_char): Clarify just what is returned
719 (bug#6576). Text by Eli Zaretskii.
720
ac389d0c
JB
7212011-07-13 Juanma Barranquero <lekktu@gmail.com>
722
723 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
724
0be0ce47
EZ
7252011-07-13 Eli Zaretskii <eliz@gnu.org>
726
727 * buffer.c (mmap_find): Fix a typo.
728
cd18e7e3
JB
7292011-07-13 Johan Bockgård <bojohan@gnu.org>
730
731 Fix execution of x selection hooks.
732 * xselect.c (Qx_lost_selection_functions)
733 (Qx_sent_selection_functions): New vars.
734 (syms_of_xselect): DEFSYM them.
735 (x_handle_selection_request): Pass Qx_sent_selection_functions
736 rather than Vx_sent_selection_functions to Frun_hook_with_args.
737 (x_handle_selection_clear,x_clear_frame_selections):
738 Pass Qx_lost_selection_functions rather than
739 Vx_lost_selection_functions to Frun_hook_with_args.
740
47ea7f44
PE
7412011-07-13 Paul Eggert <eggert@cs.ucla.edu>
742
ac389d0c 743 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
744 The old code sometimes used this field without initializing it.
745
47ea7f44
PE
746 * alloc.c (gc_sweep): Don't read past end of array.
747 In theory, the old code could also have corrupted Emacs internals,
748 though it'd be very unlikely.
749
bc985c87
AS
7502011-07-12 Andreas Schwab <schwab@linux-m68k.org>
751
752 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 753 argument. (Bug#4026)
bc985c87 754
0cf34688
LMI
7552011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
756
b3dadd76
LMI
757 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
758 key" (bug#4257).
759
0cf34688
LMI
760 * window.c (Fset_window_start): Doc fix (bug#4199).
761 (Fset_window_hscroll): Ditto.
762
270768cd
PE
7632011-07-12 Paul Eggert <eggert@cs.ucla.edu>
764
077e3dda 765 Fix minor new problems caught by GCC 4.6.1.
270768cd 766 * term.c (init_tty): Remove unused local.
490011a6 767 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 768 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 769 not used otherwise.
270768cd 770
b1f58454
CY
7712011-07-12 Chong Yidong <cyd@stupidchicken.com>
772
773 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
774
22b9578d
LMI
7752011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
776
6e70ab07
LMI
777 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
778 are the mini-buffer and the echo area (bug#3320).
779
22b9578d
LMI
780 * term.c (init_tty): Remove support for supdup, c10 and perq
781 terminals, which are no longer supported (bug#1482).
782
8974cc9f
JB
7832011-07-10 Johan Bockgård <bojohan@gnu.org>
784
785 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
786
a560d974
JD
7872011-07-10 Jan Djärv <jan.h.d@swipnet.se>
788
789 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
790 for non-popups (Bug#3642).
791
1dae0f0a
AS
7922011-07-10 Andreas Schwab <schwab@linux-m68k.org>
793
268c2c36 794 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 795 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
796 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
797 * cm.c (losecursor): Likewise.
1dae0f0a
AS
798 * data.c (fmod): Likewise.
799 * dispnew.c (swap_glyphs_in_rows): Likewise.
800 * emacs.c (memory_warning_signal): Likewise.
801 * floatfns.c (float_error): Likewise.
802 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
803 (otf_open, font_otf_capability, generate_otf_features)
804 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
805 Likewise.
806 * image.c (pbm_read_file): Likewise.
807 * indent.c (string_display_width): Likewise.
808 * intervals.c (check_for_interval, search_for_interval)
809 (inc_interval_count, count_intervals, root_interval)
810 (adjust_intervals_for_insertion, make_new_interval): Likewise.
811 * lread.c (defalias): Likewise.
268c2c36 812 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
813 * regex.c (set_image_of_range_1, set_image_of_range)
814 (regex_grow_registers): Likewise.
815 * sysdep.c (strerror): Likewise.
816 * termcap.c (valid_filename_p, tprint, main): Likewise.
817 * tparam.c (main): Likewise.
818 * unexhp9k800.c (run_time_remap, save_data_space)
819 (update_file_ptrs, read_header, write_header, calculate_checksum)
820 (copy_file, copy_rest, display_header): Likewise.
821 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
822 Likewise.
823 * xdisp.c (check_it): Likewise.
824 * xfaces.c (register_color, unregister_color, unregister_colors):
825 Likewise.
826 * xfns.c (print_fontset_result): Likewise.
827 * xrdb.c (member, fatal, main): Likewise.
828
99033785
PE
8292011-07-10 Paul Eggert <eggert@cs.ucla.edu>
830
831 Fix minor problems found by static checking (Bug#9031).
832 * chartab.c (char_table_set_range, map_sub_char_table):
833 Remove unused locals.
834 (uniprop_table): Now static.
835 * composite.c (_work_char): Remove unused static var.
836
9cb2ac56
JB
8372011-07-09 Juanma Barranquero <lekktu@gmail.com>
838
839 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
840
f25661f0
JD
8412011-07-09 Jan Djärv <jan.h.d@swipnet.se>
842
843 * gtkutil.c (qttip_cb): Remove code without function.
844
8278c4fe
EZ
8452011-07-09 Eli Zaretskii <eliz@gnu.org>
846
847 * w32.c (pthread_sigmask): New stub.
848
1692ae2d 8492011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 850
8a6ebd58 851 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
852 sigprocmask is portable only for single-threaded applications, and
853 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
854 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
855 (LIBES): Use it.
856 * callproc.c (Fcall_process):
857 * process.c (create_process):
858 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
859 Use pthread_sigmask, not sigprocmask.
123403e4 860
1b854618
JD
8612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
862
863 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
864 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
865 wrong (Bug#8591).
866
3fe4b549
JD
8672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
868
0ce7e563
JD
869 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
870 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
871 (xg_hide_tooltip): Fix comment.
872
3fe4b549
JD
873 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
874 in registerServicesMenuSendTypes.
875 (validRequestorForSendType): Don't check ns_return_types.
876
877 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
878 ns_return_type.
879
5df75e47
JR
8802011-07-08 Jason Rumney <jasonr@gnu.org>
881
882 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
883 frame struct members of non-existent frames (Bug#6284).
884
699c10bd
JD
8852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
886
4393663b
JD
887 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
888 variable firstTime not needed on OSX >= 10.6.
889 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
890 >= 10.5. Use setKnobProportion, setDoubleValue.
891
892 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
893 (MAC_OS_X_VERSION_10_5): Define if not defined.
894 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
895 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
896 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
897
898 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
899 cString and lossyCString on OSX >= 10.4
900
901 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
902 sizeToFit on OSX >= 10.2.
903
904 * nsimage.m (allocInitFromFile): Don't use deprecated method
905 bestRepresentationForDevice on OSX >= 10.6.
906
907 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
908 to avoid warning.
909
910 * emacs.c: Declare unexec_init_emacs_zone.
911
a63e0781
JD
912 * nsgui.h: Fix compiler warning about gnulib redefining verify.
913
699c10bd
JD
914 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
915
916 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
917 on svcsMenu (Bug#8842).
918
919 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
920 ns_return_types.
921 (Fns_list_services): Just return Qnil on 10.6, code not working there.
922
923 * nsterm.m (QUTF8_STRING): Declare.
924 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
925 (validRequestorForSendType): Return type is (id).
926 Change indexOfObjectIdenticalTo to indexOfObject.
927 Check if we have local selection before returning self (Bug#8842).
928 (writeSelectionToPasteboard): Put local selection into paste board
929 if we have a local selection (Bug#8842).
930 (syms_of_nsterm): DEFSYM QUTF8_STRING.
931
932 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
933 (ns_get_local_selection): Declare.
934
54e10184
LMI
9352011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
936
9888ff71
LMI
937 * keymap.c (describe_map_tree): Don't insert a double newline at
938 the end of the buffer (bug#1169) and return whether we inserted
939 something.
940
54e10184
LMI
941 * callint.c (Fcall_interactively): Change "reading args" to
942 "providing args" to try to clarify what it does (bug#1010).
943
15fa4783
KH
9442011-07-07 Kenichi Handa <handa@m17n.org>
945
946 * composite.c (composition_compute_stop_pos): Ignore a static
947 composition starting before CHARPOS (Bug#8915).
948
949 * xdisp.c (handle_composition_prop): Likewise.
950
a8815b00
EZ
9512011-07-07 Eli Zaretskii <eliz@gnu.org>
952
953 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
954 (Bug#9015)
955
ef7b981d 9562011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
957
958 * character.h (unicode_category_t): New enum type.
959
960 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
961 (Qchar_code_property_table): New variable.
962 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
963 (UNIPROP_COMPRESSED_FORM_P): New macros.
964 (char_table_ascii): Uncompress the compressed values.
965 (sub_char_table_ref): New arg is_uniprop. Callers changed.
966 Uncompress the compressed values.
ac389d0c 967 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
968 (char_table_ref_and_range): Uncompress the compressed values.
969 (sub_char_table_set): New arg is_uniprop. Callers changed.
970 Uncompress the compressed values.
971 (sub_char_table_set_range): Args changed. Callers changed.
972 (char_table_set_range): Adjuted for the above change.
973 (map_sub_char_table): Delete args default_val and parent. Add arg
974 top. Give decoded values to a Lisp function.
975 (map_char_table): Adjusted for the above change. Give decoded
976 values to a Lisp function. Gcpro more variables.
977 (uniprop_table_uncompress)
978 (uniprop_decode_value_run_length): New functions.
979 (uniprop_decoder, uniprop_decoder_count): New variables.
980 (uniprop_get_decoder, uniprop_encode_value_character)
981 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
982 New functions.
983 (uniprop_encoder, uniprop_encoder_count): New variables.
984 (uniprop_get_encoder, uniprop_table)
985 (Funicode_property_table_internal, Fget_unicode_property_internal)
986 (Fput_unicode_property_internal): New functions.
987 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
988 Sunicode_property_table_internal, Sget_unicode_property_internal,
989 and Sput_unicode_property_internal. Defvar_lisp
990 char-code-property-alist.
991
992 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
993 Vunicode_category_table.
994
995 * font.c (font_range): Adjusted for the change of
996 Vunicode_category_table.
997
76b397fb
DN
9982011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
999
1000 * m/iris4d.h: Remove file, move contents ...
1001 * s/irix6-5.h: ... here.
1002
22b4128e
PE
10032011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1006 * alloc.c (mark_buffer):
1007 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1008 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1009 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1010 This isn't true in general, and it's particularly not true
1011 if Emacs is configured with --with-wide-int.
1012 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1013 New macros, used in the buffer.c change.
1014
869795d6
JD
10152011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1016
1017 * xsettings.c: Use both GConf and GSettings if both are available.
1018 (store_config_changed_event): Add comment.
1019 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1020 (store_tool_bar_style_changed): New functions.
1021 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1022 (struct xsettings): Move font inside HAVE_XFT.
1023 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1024 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1025 Move inside HAVE_XFT.
1026 (something_changed_gsettingsCB): Renamed from something_changedCB.
1027 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1028 also.
1029 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1030 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1031 (something_changed_gconfCB): Renamed from something_changedCB.
1032 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1033 (parse_settings): Move check for font inside HAVE_XFT.
1034 (read_settings, apply_xft_settings): Add comment.
1035 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1036 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1037 call store_font_name_changed.
1038 (xft_settings_event): Add comment.
1039 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1040 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1041 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1042 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1043 (xsettings_initialize): Call init_gsettings last.
1044 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1045 comment.
1046
d8ed26bd
PE
10472011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 Random fixes. E.g., (random) never returned negative values.
1050 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1051 subseconds part to the entropy, as that's a bit more random.
1052 Prefer signed to unsigned, since the signedness doesn't matter and
1053 in general we prefer signed. When given a limit, use a
1054 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1055 latter isn't right if USE_2_TAGS_FOR_INTS.
1056 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1057 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1058
cabf1cac
SM
10592011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1060
1061 * textprop.c (text_property_stickiness):
1062 Obey Vtext_property_default_nonsticky.
1063 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1064 * w32fns.c (syms_of_w32fns):
1065 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1066
6e9b2be9
PE
10672011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1068
1069 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1070 This is more efficient than Ffile_directory_p and avoids a minor race.
1071
90186c68
LMI
10722011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1073
7c301272
LMI
1074 * buffer.c (Foverlay_put): Say what the return value is
1075 (bug#7835).
1076
c4f2d8d4
LMI
1077 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1078 is a directory before asking whether to use the file name
1079 (bug#7564).
ad637907
LMI
1080 (barf_or_query_if_file_exists): Make the "File is a directory"
1081 error be more correct.
c4f2d8d4 1082
90186c68
LMI
1083 * fns.c (Frequire): Remove the mention of the .gz files, since
1084 that's installation-specific, but keep the mention of
1085 `get-load-suffixes'.
1086
da64016e
PE
10872011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1090 Report string overflow if the output is too long.
1091
7d47b580
JB
10922011-07-04 Juanma Barranquero <lekktu@gmail.com>
1093
a555cb87
JB
1094 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1095 (syms_of_gnutls): Remove duplicate DEFSYM for
1096 Qgnutls_bootprop_verify_hostname_error, an error for
1097 Qgnutls_bootprop_verify_error (which is no longer used).
1098
7d47b580
JB
1099 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1100 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1101 Also (re)move comments that are misplaced or no longer relevant.
1102
1e49bfab
LMI
11032011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1104
1105 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1106
1485f4c0
CY
11072011-07-03 Chong Yidong <cyd@stupidchicken.com>
1108
1109 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1110 and background color parameters if they have been changed.
1111
a9ab721e
LMI
11122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1113
1114 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1115
cf7cff57
PE
11162011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1117
2e13213d
PE
1118 * xsettings.c (SYSTEM_FONT): Define only when used.
1119 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1120
cf7cff57
PE
1121 * keymap.c (access_keymap_1): Now static.
1122
7a8e04f7
CY
11232011-07-02 Chong Yidong <cyd@stupidchicken.com>
1124
1125 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1126 leave any prefix arg for the up event (Bug#1586).
1127
61352f62
LMI
11282011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1129
69bb1ef7
LMI
1130 * lread.c (syms_of_lread): Mention single symbols defined by
1131 `defvar' or `defconst' (bug#7154).
1132
61352f62 1133 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1134 (Frequire): Mention get-load-suffixes.
61352f62 1135
28545e04
MR
11362011-07-02 Martin Rudalics <rudalics@gmx.at>
1137
1138 * window.h (window): Remove clone_number slot.
1139 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1140 Remove.
1141 (make_parent_window, make_window, saved_window)
1142 (Fset_window_configuration, save_window_save): Don't deal with
1143 clone numbers.
1144 * buffer.c (Qclone_number): Remove declaration.
1145 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1146
3349e122
SM
11472011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1148
1149 Add multiple inheritance to keymaps.
1150 * keymap.c (Fmake_composed_keymap): New function.
1151 (Fset_keymap_parent): Simplify.
1152 (fix_submap_inheritance): Remove.
1153 (access_keymap_1): New function extracted from access_keymap to handle
1154 embedded parents and handle lists of maps.
1155 (access_keymap): Use it.
1156 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1157 (Fcopy_keymap): Handle embedded parents.
1158 (Fcommand_remapping, define_as_prefix): Simplify.
1159 (Fkey_binding): Simplify.
1160 (syms_of_keymap): Move minibuffer-local-completion-map,
1161 minibuffer-local-filename-completion-map,
1162 minibuffer-local-must-match-map, and
1163 minibuffer-local-filename-must-match-map to Elisp.
1164 (syms_of_keymap): Defsubr make-composed-keymap.
1165 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1166 (parse_menu_item): Trivial simplification.
1167
3279eb87
GM
11682011-07-01 Glenn Morris <rgm@gnu.org>
1169
1170 * Makefile.in (SETTINGS_LIBS): Fix typo.
1171
4550efdf
KI
11722011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1173
1174 * coding.c (Fencode_coding_string): Record the last coding system
1175 used, as the function doc string says (bug#8738).
1176
0949d2b6
JD
11772011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1178
1179 * xsettings.c (store_monospaced_changed): Take new font as arg and
1180 check for change against current_mono_font.
1181 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1182 (emacs_settings_constructor, emacs_settings_get_property)
1183 (emacs_settings_set_property, emacs_settings_class_init)
1184 (emacs_settings_init, gsettings_obj): Remove.
1185 (something_changedCB): New function for HAVE_GSETTINGS.
1186 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1187 with value as argument.
1188 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1189 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1190 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1191 "changed".
1192
1193 * xgselect.c: Add defined (HAVE_GSETTINGS).
1194 (xgselect_initialize): Ditto.
1195
1196 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1197 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1198 xg_select.
1199
bbc6b304
PE
12002011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1201
1202 * eval.c (struct backtrace): Simplify and port the data structure.
1203 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1204 signed bit field, as this assumption is not portable and it makes
1205 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1206 "char debug_on_exit : 1" as this is not portable either; instead,
1207 use the portable "unsigned int debug_on_exit : 1". Remove unused
1208 member evalargs. Remove obsolete comments about cc bombing out.
1209
9851bfc5
JD
12102011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1211
51bb811f 1212 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1213 Let HAVE_GSETTINGS override HAVE_GCONF.
1214 (store_monospaced_changed): New function.
1215 (EMACS_SETTINGS): A new type derived from GObject to handle
1216 GSettings notifications.
1217 (emacs_settings_constructor, emacs_settings_get_property)
1218 (emacs_settings_set_property, emacs_settings_class_init):
1219 New functions.
1220 (gsettings_client, gsettings_obj): New variables.
1221 (GSETTINGS_SCHEMA): New define.
1222 (something_changedCB): Call store_monospaced_changed.
1223 (init_gsettings): New function.
1224 (xsettings_initialize): Call init_gsettings.
1225 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1226 to NULL.
1227
1228 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1229 GCONF_CFLAGS/LIBS.
1230
5386012d
MR
12312011-06-29 Martin Rudalics <rudalics@gmx.at>
1232
1233 * window.c (resize_root_window, grow_mini_window)
1234 (shrink_mini_window): Rename Qresize_root_window to
1235 Qwindow_resize_root_window and Qresize_root_window_vertically to
1236 Qwindow_resize_root_window_vertically.
1237
f13e0b08
PE
12382011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1239
1240 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1241
94515237
JB
12422011-06-27 Juanma Barranquero <lekktu@gmail.com>
1243
1244 * makefile.w32-in: Redesign dependencies so they reflect more
1245 clearly which files are directly included by each source file,
1246 and not through other includes.
1247
e43b6e43
MR
12482011-06-27 Martin Rudalics <rudalics@gmx.at>
1249
1250 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1251 (sort_overlays, overlay_strings): When an overlay's clone number
1252 matches the window's clone number process the overlay even if
1253 the overlay's window property doesn't match the current window.
1254
d68443dc
MR
1255 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1256 (Fwindow_hchild): Rename to Fwindow_left_child.
1257 (Fwindow_next): Rename to Fwindow_next_sibling.
1258 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1259 (resize_window_check): Rename to window_resize_check.
1260 (resize_window_apply): Rename to window_resize_apply.
1261 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1262 (Fdelete_other_windows_internal, resize_frame_windows)
1263 (Fsplit_window_internal, Fdelete_window_internal)
1264 (grow_mini_window, shrink_mini_window)
1265 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1266
c7e73be5
JD
12672011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1268
1269 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1270 (emacs_fixed_set_min_size): Remove.
1271 (emacs_fixed_new): Take frame as argument.
1272
1273 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1274 (_EmacsFixedPrivate): Remove minwidth/height.
1275 Add struct frame *f.
1276 (emacs_fixed_init): Initialize priv->f.
1277 (get_parent_class, emacs_fixed_set_min_size): Remove.
1278 (emacs_fixed_new): Set priv->f to argument.
1279 (emacs_fixed_get_preferred_width)
1280 (emacs_fixed_get_preferred_height): Use min_width/height from
1281 frames size_hint to set minimum and natural (Bug#8919).
1282 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1283 and use min_width/height from frames size_hint to set
1284 min_width/height (Bug#8919).
1285
1286 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1287 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1288 Fix indentation.
c7e73be5 1289
cf99dcf8
EZ
12902011-06-26 Eli Zaretskii <eliz@gnu.org>
1291
1292 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1293 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1294 called at ZV.
1295
029529ac
CY
12962011-06-26 Chong Yidong <cyd@stupidchicken.com>
1297
1298 * process.c (wait_reading_process_output): Bypass select if
1299 waiting for a cell while ignoring keyboard input, and input is
1300 pending. Suggested by Jan Djärv (Bug#8869).
1301
7a7ef429
PE
13022011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 Use gnulib's dup2 module instead of rolling our own.
1305 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1306
11fdef7d 13072011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1308
1309 * dispnew.c (scrolling_window): Before scrolling, turn off a
1310 mouse-highlight in the window being scrolled.
1311
cd3520a4
JB
13122011-06-24 Juanma Barranquero <lekktu@gmail.com>
1313
1314 Move DEFSYM to lisp.h and use everywhere.
1315
1316 * character.h (DEFSYM): Move declaration...
1317 * lisp.h (DEFSYM): ...here.
1318
1319 * gnutls.c:
1320 * minibuf.c:
1321 * w32menu.c:
1322 * w32proc.c:
1323 * w32select.c: Don't include character.h.
1324
1325 * alloc.c (syms_of_alloc):
1326 * buffer.c (syms_of_buffer):
1327 * bytecode.c (syms_of_bytecode):
1328 * callint.c (syms_of_callint):
1329 * casefiddle.c (syms_of_casefiddle):
1330 * casetab.c (init_casetab_once):
1331 * category.c (init_category_once, syms_of_category):
1332 * ccl.c (syms_of_ccl):
1333 * cmds.c (syms_of_cmds):
1334 * composite.c (syms_of_composite):
1335 * dbusbind.c (syms_of_dbusbind):
1336 * dired.c (syms_of_dired):
1337 * dispnew.c (syms_of_display):
1338 * doc.c (syms_of_doc):
1339 * editfns.c (syms_of_editfns):
1340 * emacs.c (syms_of_emacs):
1341 * eval.c (syms_of_eval):
1342 * fileio.c (syms_of_fileio):
1343 * fns.c (syms_of_fns):
1344 * frame.c (syms_of_frame):
1345 * fringe.c (syms_of_fringe):
1346 * insdel.c (syms_of_insdel):
1347 * keymap.c (syms_of_keymap):
1348 * lread.c (init_obarray, syms_of_lread):
1349 * macros.c (syms_of_macros):
1350 * msdos.c (syms_of_msdos):
1351 * print.c (syms_of_print):
1352 * process.c (syms_of_process):
1353 * search.c (syms_of_search):
1354 * sound.c (syms_of_sound):
1355 * syntax.c (init_syntax_once, syms_of_syntax):
1356 * terminal.c (syms_of_terminal):
1357 * textprop.c (syms_of_textprop):
1358 * undo.c (syms_of_undo):
1359 * w32.c (globals_of_w32):
1360 * window.c (syms_of_window):
1361 * xdisp.c (syms_of_xdisp):
1362 * xfaces.c (syms_of_xfaces):
1363 * xfns.c (syms_of_xfns):
1364 * xmenu.c (syms_of_xmenu):
1365 * xsettings.c (syms_of_xsettings):
1366 * xterm.c (syms_of_xterm): Use DEFSYM.
1367
4228cf16
TZ
13682011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1369
cd3520a4 1370 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1371
7fcccf1e
PE
13722011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1373
7efb4e0e
PE
1374 Integer and buffer overflow fixes (Bug#8873).
1375
ff5844ad
PE
1376 * print.c (printchar, strout): Check for string overflow.
1377 (PRINTPREPARE, printchar, strout):
1378 Don't set size unless allocation succeeds.
1379
90532f02
PE
1380 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1381 for sizes. Check for string overflow more accurately.
1382 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1383
6d84508d
PE
1384 * macros.c: Integer and buffer overflow fixes.
1385 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1386 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1387 Use ptrdiff_t, not int, for sizes.
1388 Don't increment bufsize until after realloc succeeds.
1389 Check for size-calculation overflow.
1390 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1391
437b2cb4
PE
1392 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1393
8b9ac8b4
PE
1394 * lread.c: Integer overflow fixes.
1395 (read_integer): Radix is now EMACS_INT, not int,
1396 to improve quality of diagnostics for out-of-range radices.
1397 Calculate buffer size correctly for out-of-range radices.
1398 (read1): Check for integer overflow in radices, and in
1399 read-circle numbers.
82cb60d3
PE
1400 (read_escape): Avoid int overflow.
1401 (Fload, openp, read_buffer_size, read1)
1402 (substitute_object_recurse, read_vector, read_list, map_obarray):
1403 Use ptrdiff_t, not int, for sizes.
1404 (read1): Use EMACS_INT, not int, for sizes.
20270765 1405 Check for size overflow.
8b9ac8b4 1406
7fcccf1e
PE
1407 * image.c (cache_image): Check for size arithmetic overflow.
1408
bfbbd7e7
PE
1409 * lread.c: Integer overflow issues.
1410 (saved_doc_string_size, saved_doc_string_length)
1411 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1412 Now ptrdiff_t, not int.
1413 (read1): Don't assume doc string length fits in int. Check for
1414 out-of-range doc string lengths.
1415 (read_list): Don't assume file position fits in int.
39019e54 1416 (read_escape): Check for hex character overflow.
bfbbd7e7 1417
4e323265
LL
14182011-06-22 Leo Liu <sdl.web@gmail.com>
1419
1420 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1421 Move to minibuffer.el.
1422
85fece3e
PE
14232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1424
20b84ce9 1425 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1426 The following patches are for when GLYPH_DEBUG && !XASSERT.
1427 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1428 * dispnew.c (flush_stdout):
1429 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1430 Mark as externally visible.
1431 * dispnew.c (check_window_matrix_pointers): Now static.
1432 * dispnew.c (window_to_frame_vpos):
1433 * xfns.c (unwind_create_frame):
1434 * xterm.c (x_check_font): Remove unused local.
1435 * scroll.c (CHECK_BOUNDS):
1436 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1437 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1438 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1439 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1440 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1441 Now static.
1442 (debug_method_add): Use va_list and vsprintf rather than relying
1443 on undefined behavior with wrong number of arguments.
1444 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1445 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1446 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1447 since we're not interested in debugging glyphs with old libraries.
1448 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1449 GCC 4.6.0's static checking.
1450
0766b489
PE
14512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1452
31fd4b32
PE
1453 Integer overflow and signedness fixes (Bug#8873).
1454 A few related buffer overrun fixes, too.
1455
b79e8648
PE
1456 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1457
0766b489
PE
1458 * dispextern.h (struct face.stipple):
1459 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1460 (x_bitmap_mask, x_allocate_bitmap_record)
1461 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1462 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1463 (x_create_bitmap_from_xpm_data):
1464 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1465 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1466 (.bitmaps_last):
1467 * xfaces.c (load_pixmap):
1468 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1469 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1470 (.bitmaps_last, struct x_output.icon_bitmap):
1471 Use ptrdiff_t, not int, for bitmap indexes.
1472 (x_allocate_bitmap_record): Check for size overflow.
1473 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1474
b081724f
PE
1475 Use ptrdiff_t, not int, for overlay counts.
1476 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1477 * editfns.c (overlays_around, get_pos_property):
1478 * textprop.c (get_char_property_and_overlay):
1479 * xdisp.c (next_overlay_change, note_mouse_highlight):
1480 * xfaces.c (face_at_buffer_position):
21514da7
PE
1481 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1482 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1483 (Fnext_overlay_change, Fprevious_overlay_change)
1484 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1485 Use ptrdiff_t, not int, for sizes.
21514da7 1486 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1487
3de73e5e
PE
1488 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1489
2606c57b
PE
1490 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1491 (x_session_initialize): Do not assume string length fits in int.
1492
aaafe47a
PE
1493 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1494 This is unlikely, but can occur if DPI is outlandish.
1495
2674ddc8 1496 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1497 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1498
28154962
PE
1499 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1500 * xrdb.c (magic_file_p, search_magic_path):
1501 Omit last arg SUFFIX; it was always 0. All callers changed.
1502 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1503
7de51af5
PE
1504 * xfont.c (xfont_match): Avoid need for strlen.
1505
25ed6cc3
PE
1506 * xfns.c: Don't assume strlen fits in int.
1507 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1508
4eab31dd
PE
1509 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1510 not unsigned long, as we prefer signed integers. All callers changed.
1511 Detect integer overflow in repeat count.
1512 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1513 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1514
171e2a58
PE
1515 * termcap.c: Don't assume sizes fit in int and never overflow.
1516 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1517 (gobble_line): Check for size-calculation overflow.
1518
ad39faca 1519 * minibuf.c (Fread_buffer):
6e5bb2dc 1520 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1521 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1522 Don't assume string length fits in int.
1523
52c61c22 1524 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1525 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1526
b5b8c9e5
PE
1527 * font.c: Don't assume string length fits in int.
1528 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1529 Use ptrdiff_t, not int.
ccd6111c
PE
1530 (font_intern_prop): Don't assume string length fits in int.
1531 Don't assume integer property fits in fixnum.
1532 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1533
882f0d81 1534 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1535 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1536 Reformulate so as not to need the command string.
1537 Invoke gzip -cd rather than gunzip, as it's more portable.
1538 (lock_info_type, lock_file_1, lock_file):
1539 Don't assume pid_t and time_t fit in unsigned long.
1540 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1541 (current_lock_owner): Prefer signed type for sizes.
1542 Use memcpy, not strncpy, where memcpy is what is really wanted.
1543 Don't assume (via atoi) that time_t and pid_t fit in int.
1544 Check for time_t and/or pid_t out of range, e.g., via a network share.
1545 Don't alloca where an auto var works fine.
1546
93f4cf88
PE
1547 * fileio.c: Fix some integer overflow issues.
1548 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1549 Don't assume string length fits in int.
1550 (directory_file_name): Don't assume string length fits in long.
1551 (make_temp_name): Don't assume pid fits in int, or that its print
1552 length is less than 20.
1553
f3e92b69
PE
1554 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1555
1bfdaf10
PE
1556 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1557
35016e9a
PE
1558 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1559
3d1e65a1
PE
1560 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1561 We prefer signed integers, even for size calculations.
1562
0b963a93
PE
1563 * emacs.c: Don't assume string length fits in 'int'.
1564 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1565 (main): Don't invoke strlen when not needed.
1566
573f4b54
PE
1567 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1568 (XD_DEBUG_MESSAGE): Don't waste a byte.
1569
989f33ba
PE
1570 * callproc.c (getenv_internal_1, getenv_internal)
1571 (Fgetenv_internal):
965d34eb
PE
1572 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1573
e4d29b33
PE
1574 * lread.c (invalid_syntax): Omit length argument.
1575 All uses changed. This doesn't fix a bug, but it simplifies the
1576 code away from its former Hollerith-constant appearance, and it's
1577 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1578 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1579
eb49b136
PE
1580 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1581 This didn't break anything, but it didn't help either.
1582 It's confusing to put a bogus integer in a place where the actual
1583 value does not matter.
9f62aeb1 1584 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1585 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1586
15375a22
PE
1587 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1588 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1589 implementation.
b61cc01c
PE
1590 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1591 We prefer signed types, and the value cannot exceed the EMACS_INT
1592 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1593 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1594 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1595 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1596
53b2623d
PE
1597 * indent.c (sane_tab_width): New function.
1598 (current_column, scan_for_column, Findent_to, position_indentation)
1599 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1600 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1601
51cab52b 1602 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1603
f2ed8a70
PE
1604 * lisp.h (lint_assume): New macro.
1605 * composite.c (composition_gstring_put_cache):
1606 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1607
abe80cc6
PE
1608 * editfns.c, insdel.c:
1609 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1610
b02c740e
PE
1611 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1612
ebc96716
PE
1613 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1614
b4e50fa0 1615 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1616 Use much-faster test for byte-length change.
311d5d7c 1617 Don't assume string byte-length fits in 'int'.
a4cf38e4 1618 Check that character arg fits in 'int'.
85461888 1619 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1620
c0c1ee9f
PE
1621 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1622
a498d7f4
PE
1623 * fns.c (concat): Catch string overflow earlier.
1624 Do not rely on integer wraparound.
1625
51cab52b
PE
1626 * dispextern.h (struct it.overlay_strings_charpos)
1627 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1628 * xdisp.c (forward_to_next_line_start)
1629 (back_to_previous_visible_line_start)
1630 (reseat_at_next_visible_line_start, next_element_from_buffer):
1631 Don't arbitrarily truncate the value of 'selective' to int.
1632
76031fad
PE
1633 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1634
5eb55db9
PE
1635 * composite.c: Don't truncate sizes to 'int'.
1636 (composition_gstring_p, composition_reseat_it)
1637 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1638 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1639 not EMACS_UINT, for indexes.
5eb55db9 1640
0703a717
PE
1641 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1642
d6202519
PE
1643 * buffer.c: Include <verify.h>.
1644 (struct sortvec.priority, struct sortstr.priority):
8961a454 1645 Now EMACS_INT, not int.
c20998a7 1646 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1647 (struct sortstr.size, record_overlay_string)
1648 (struct sortstrlist.size, struct sortlist.used):
1649 Don't truncate size to int.
1650 (record_overlay_string): Check for size-calculation overflow.
d6202519 1651 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1652
d5a19415
JM
16532011-06-22 Jim Meyering <meyering@redhat.com>
1654
029529ac 1655 Don't leak an XBM-image-sized buffer
d5a19415
JM
1656 * image.c (xbm_load): Free the image buffer after using it.
1657
a9041e6c
PE
16582011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 Port to Sun C.
1661 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1662 that Sun C diagnosed.
1663 * fns.c (secure_hash): Fix pointer signedness issue.
1664 * intervals.c (static_offset_intervals): New function.
1665 (offset_intervals): Use it.
1666
7f3f739f
LL
16672011-06-21 Leo Liu <sdl.web@gmail.com>
1668
1669 * deps.mk (fns.o):
1670 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1671 sha512.h.
1672
1673 * fns.c (secure_hash): Rename from crypto_hash_function and change
1674 the first arg to accept symbols.
5b66d427 1675 (Fsecure_hash): New primitive.
7f3f739f
LL
1676 (syms_of_fns): New symbols.
1677
76147d94
DD
16782011-06-20 Deniz Dogan <deniz@dogan.se>
1679
1680 * process.c (Fset_process_buffer): Clarify return value in
1681 docstring.
1682
7d7d0045
CY
16832011-06-18 Chong Yidong <cyd@stupidchicken.com>
1684
1685 * dispnew.c (add_window_display_history): Use BVAR.
1686
1687 * xdisp.c (debug_method_add): Use BVAR.
1688 (check_window_end, dump_glyph_matrix, dump_glyph)
1689 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1690
1691 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1692 Likewise.
1693
1694 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1695 check till after the cache is created in init_frame_faces.
1696
ff2bc410
SM
16972011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1698
1699 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1700
28177add
PE
17012011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1702
dd3482fe
PE
1703 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1704 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1705 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1706
393d71f3 1707 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1708 * fileio.c (Finsert_file_contents):
1709 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1710 Remove the old (too-loose) buffer overflow checks.
1711 They weren't needed, since make_gap checks for buffer overflow.
1712 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1713 The old code merely checked for Emacs fixnum overflow, and relied
1714 on undefined (wraparound) behavior. The new code avoids undefined
1715 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1716
2e6813b0 1717 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1718 Tune. Don't use wider integers than needed. Don't use alloca.
1719 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1720
599a9e4f
PE
1721 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1722
99561444
PE
1723 * insdel.c, lisp.h (buffer_overflow): New function.
1724 (insert_from_buffer_1, replace_range, replace_range_2):
1725 * insdel.c (make_gap_larger):
1726 * editfns.c (Finsert_char):
1727 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1728
28177add
PE
1729 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1730
e69dafad
PE
17312011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1732
a7af7fde 1733 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1734
b1c46f02
PE
1735 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1736 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1737
e69dafad
PE
1738 * fileio.c: Don't assume EMACS_INT fits in off_t.
1739 (emacs_lseek): New static function.
1740 (Finsert_file_contents, Fwrite_region): Use it.
1741 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1742
566684ea
PE
1743 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1744
e6966cd6
PE
1745 * fns.c: Don't overflow int when computing a list length.
1746 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1747 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1748 truncation on 64-bit hosts. Check for QUIT every
1749 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1750 faster and is responsive enough.
1751 (Flength): Report an error instead of overflowing an integer.
1752 (Fsafe_length): Return a float if the value is not representable
1753 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1754 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1755 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1756
dd0b0efb
PE
1757 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1758 (header_size, word_size): New constants.
1759 (allocate_vectorlike): Don't check size overflow here.
1760 (allocate_vector): Check it here instead, since this is the only
1761 caller of allocate_vectorlike that could cause overflow.
1762 Check that the new vector's length is representable as a fixnum.
1763
86fe5cfe
PE
1764 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1765 The previous code was bogus. For example, next_almost_prime (32)
1766 returned 39, which is undesirable as it is a multiple of 3; and
1767 next_almost_prime (24) returned 25, which is a multiple of 5 so
1768 why was the code bothering to check for multiples of 7?
1769
80e88859
PE
1770 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1771
4a2f0ad6
PE
1772 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1773
f66c7cf8
PE
1774 Variadic C functions now count arguments with ptrdiff_t.
1775 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1776 Back then I didn't know that the Emacs coding style prefers signed int.
1777 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1778 were being counted with int, which may truncate counts on 64-bit
1779 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1780 * lisp.h (struct Lisp_Subr.function.aMANY)
1781 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1782 Arg counts are now ptrdiff_t, not size_t.
1783 All variadic functions and their callers changed accordingly.
1784 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1785 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1786 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1787 * callint.c (Fcall_interactively): Check arg count for overflow,
1788 to avoid potential buffer overrun. Use signed char, not 'int',
1789 for 'varies' array, so that we needn't bother to check its size
1790 calculation for overflow.
1791 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1792 * eval.c (apply_lambda):
1793 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1794 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1795 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1796
a1759b76
PE
1797 * callint.c (Fcall_interactively): Don't use index var as event count.
1798
d96be9fc
PE
1799 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1800 * mem-limits.h (SIZE): Remove; no longer used.
1801
a690a978 1802 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1803
578c21e6
PE
1804 Remove unnecessary casts.
1805 * xterm.c (x_term_init):
1806 * xfns.c (x_set_border_pixel):
1807 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1808 These aren't needed now that we assume ANSI C.
1809
96f53c6c
PE
1810 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1811 It's more likely to cause problems (due to unsigned overflow)
1812 than to cure them.
1813
83c77d31
PE
1814 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1815
ee2079f1
PE
1816 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1817
6da65536
PE
1818 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1819
7147c4a4
PE
1820 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1821
193e32d9
PE
1822 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1823
e5533da6
PE
1824 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1825
9910e595
PE
1826 GLYPH_CODE_FACE returns EMACS_INT, not int.
1827 * dispextern.h (merge_faces):
1828 * xfaces.c (merge_faces):
01103c44
PE
1829 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1830 Don't assume EMACS_INT fits in int.
9910e595 1831
2638320e
PE
1832 * character.h (CHAR_VALID_P): Remove unused parameter.
1833 * fontset.c, lisp.h, xdisp.c: All uses changed.
1834
045eb8d9
PE
1835 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1836
c1f134b5
PE
1837 * fns.c (concat): Minor tuning based on overflow analysis.
1838 This doesn't fix any bugs. Use int to hold character, instead
1839 of constantly refetching from Emacs object. Use XFASTINT, not
1840 XINT, for value known to be a character. Don't bother comparing
1841 a single byte to 0400, as it's always less.
1842
395fcb93 1843 * floatfns.c (Fexpt):
327eeec8
PE
1844 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1845
abbd3d23
PE
1846 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1847 for characters.
1848
684a03ef
PE
1849 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1850
0fed43f3
PE
1851 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1852 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1853 incorrectly succeed when S was a string, because 4294967386 was
1854 truncated before it was used.
1855
8fd02eb7
PE
1856 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1857 Otherwise, an out-of-range integer could cause undefined behavior
1858 on a 64-bit host.
1859
f8c86b69
PE
1860 * composite.c: Use int, not EMACS_INT, for characters.
1861 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1862 EMACS_INT, for values that are known to be in character range.
1863 This doesn't fix any bugs but is the usual style inside Emacs and
1864 may generate better code on 32-bit machines.
1865
34206dd2
PE
1866 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1867 This is for reasons similar to the recent CHAR_STRING fix.
1868 * charset.c (Fencode_char): Check that character arg is actually
1869 a character. Pass an int to ENCODE_CHAR.
1870 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1871 wider than 'int', as a compile-time check to prevent future regressions
1872 in this area.
1873
c5958d4c 1874 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1875
1876 Make sure a 64-bit char is never passed to CHAR_STRING.
1877 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1878 by silently ignoring the top 32 bits, allowing some values
1879 that were far too large to be valid characters.
1880 * character.h: Include <verify.h>.
1881 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1882 arguments are no wider than unsigned, as a compile-time check
1883 to prevent future regressions in this area.
1884 * data.c (Faset):
01103c44 1885 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1886 (Fsubst_char_in_region):
1887 * fns.c (concat):
1888 * xdisp.c (decode_mode_spec_coding):
1889 Adjust to CHAR_STRING's new requirement.
1890 * editfns.c (Finsert_char, Fsubst_char_in_region):
1891 * fns.c (concat): Check that character args are actually
1892 characters. Without this test, these functions did the wrong
1893 thing with wildly out-of-range values on 64-bit hosts.
1894
d37ca623
PE
1895 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1896 These casts should not be needed on 32-bit hosts, either.
1897 * keyboard.c (read_char):
1898 * lread.c (Fload): Remove casts to unsigned.
1899
ea204efb
PE
1900 * lisp.h (UNSIGNED_CMP): New macro.
1901 This fixes comparison bugs on 64-bit hosts.
1902 (ASCII_CHAR_P): Use it.
1903 * casefiddle.c (casify_object):
01103c44 1904 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1905 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1906 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1907 * dispextern.h (FACE_FROM_ID):
1908 * keyboard.c (read_char): Use UNSIGNED_CMP.
1909
41cb286c
PE
1910 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1911 not to EMACS_INT, to avoid GCC warning.
1912
4a1b9832
PE
1913 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1914
55daad71
PE
1915 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1916 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1917 isn't needed on 32-bit machines.
8f95c75c 1918
01103c44
PE
1919 * buffer.c (Fgenerate_new_buffer_name):
1920 Use EMACS_INT for count, not int.
0ceccced 1921 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1922
1923 * data.c (Qcompiled_function): Now static.
1924
c6f072e7
PE
1925 * window.c (window_body_lines): Now static.
1926
20ce5912
PE
1927 * image.c (gif_load): Rename local to avoid shadowing.
1928
9c4c5f81
PE
1929 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1930 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1931 * alloc.c (make_save_value): Integer argument is now of type
1932 ptrdiff_t, not int.
1933 (mark_object): Use ptrdiff_t, not int.
1934 * lisp.h (pD): New macro.
1935 * print.c (print_object): Use it.
1936
c0c5c8ae
PE
1937 * alloc.c: Use EMACS_INT, not int, to count objects.
1938 (total_conses, total_markers, total_symbols, total_vector_size)
1939 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1940 (total_free_floats, total_floats, total_free_intervals)
1941 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1942 Now EMACS_INT, not int. All uses changed.
1943 (Fgarbage_collect): Compute overall total using a double, so that
1944 integer overflow is less likely to be a problem. Check for overflow
1945 when converting back to an integer.
5a25e253
PE
1946 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1947 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1948 These were 'int' variables that could overflow on 64-bit hosts;
1949 they were never used, so remove them instead of repairing them.
211a0b2a 1950 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1951 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1952 Previously, this ceilinged at INT_MAX, but that doesn't work on
1953 64-bit machines.
e46bb31a 1954 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1955
c78baabf 1956 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1957 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1958 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1959 when a (possibly-narrower) signed value would do just as well.
1960 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1961
c9d624c6
PE
1962 * alloc.c: Catch some string size overflows that we were missing.
1963 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1964 for convenience in STRING_BYTES_MAX.
1965 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1966 The definition here is exact; the one in lisp.h was approximate.
1967 (allocate_string_data): Check for string overflow. This catches
1968 some instances we weren't catching before. Also, it catches
1969 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1970 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1971 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1972
c9d624c6
PE
1973 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1974 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1975 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1976
353032ce
PE
1977 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1978
2bccce07
PE
1979 * alloc.c (Fmake_string): Check for out-of-range init.
1980
0ac30604
SM
19812011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1982
1983 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1984
c195f2de
JD
19852011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1986
1987 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1988 xg_get_default_scrollbar_width.
1989
1990 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1991 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1992 (style_changed_cb): Call update_theme_scrollbar_width and call
1993 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1994 all frames (Bug#8505).
1995 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1996 Call gtk_window_set_resizable if HAVE_GTK3.
1997 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1998 and height if HAVE_GTK3 (Bug#8505).
1999 (scroll_bar_width_for_theme): New variable.
2000 (update_theme_scrollbar_width): New function.
2001 (xg_get_default_scrollbar_width): Move code to
2002 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2003 (xg_initialize): Call update_theme_scrollbar_width.
2004
2005 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2006
2007 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2008
e10ac9f1
MR
20092011-06-12 Martin Rudalics <rudalics@gmx.at>
2010
2011 * frame.c (make_frame): Call other_buffer_safely instead of
2012 other_buffer.
2013
2014 * window.c (temp_output_buffer_show): Call display_buffer with
2015 second argument Vtemp_buffer_show_specifiers and reset latter
2016 immediately after the call.
2017 (Vtemp_buffer_show_specifiers): New variable.
2018 (auto_window_vscroll_p, next_screen_context_lines)
2019 (Vscroll_preserve_screen_position): Remove leading asterisks from
2020 doc-strings.
2021
2d3c217e 20222011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2023
7b7f97e8 2024 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2025 * buffer.c (Qclone_number): Remove for now, as it's unused.
2026 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2027 (record_buffer): Remove unused local.
2028 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2029 (set_frame_buffer_list): Remove; unused.
2030 * frame.h (other_visible_frames): Remove decl.
2031 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2032 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2033 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2034 if HAVE_GPM.
2035 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2036 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2037 Define only if HAVE_GPM.
2038 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2039 (update_hints_inhibit): Remove; never set. All uses removed.
2040 * widgetprv.h (emacsFrameClassRec): Remove decl.
2041 * window.c (delete_deletable_window): Now returns void, since it
2042 wasn't returning anything.
2043 (compare_window_configurations): Remove unused locals.
2044 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2045 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2046 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2047 the same widths as pointers. This follows up on the 2011-05-06 patch.
2048 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2049 * xterm.h: Likewise.
2050 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2051
1384b89e
JB
20522011-06-12 Juanma Barranquero <lekktu@gmail.com>
2053
2054 * makefile.w32-in: Update dependencies.
2055 (LISP_H): Add lib/intprops.h.
2056
1100a63c
CY
20572011-06-11 Chong Yidong <cyd@stupidchicken.com>
2058
2059 * image.c (gif_load): Add animation frame delay to the metadata.
2060 (syms_of_image): Use DEFSYM. New symbol `delay'.
2061
6198ccd0
MR
20622011-06-11 Martin Rudalics <rudalics@gmx.at>
2063
2064 * window.c (delete_deletable_window): Re-add.
2065 (Fset_window_configuration): Rewrite to handle dead buffers and
2066 consequently deletable windows.
2067 (window_tree, Fwindow_tree): Remove. Supply functionality in
2068 window.el.
2069 (compare_window_configurations): Simplify code.
2070
b6e3633c
AS
20712011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2072
1ab0dee5
AS
2073 * image.c (imagemagick_load_image): Fix type mismatch.
2074 (Fimagemagick_types): Likewise.
2075
b6e3633c
AS
2076 * window.h (replace_buffer_in_windows): Declare.
2077
9397e56f
MR
20782011-06-11 Martin Rudalics <rudalics@gmx.at>
2079
2080 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2081 Qclone_number. Remove external declaration of Qdelete_window.
2082 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2083 code.
2084 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2085 Qbuffer_list_update_hook if allowed.
2086 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2087 buffer list implementation.
2088 (other_buffer_safely): New function.
2089 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2090 calls to replace_buffer_in_windows and
2091 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2092 if allowed.
2093 (record_buffer): Inhibit quitting and rewrite using quittable
2094 functions. Run Qbuffer_list_update_hook if allowed.
2095 (Frecord_buffer, Funrecord_buffer): New functions.
2096 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2097 switch-to-buffer to window.el.
2098 (bury-buffer): Move to window.el.
2099 (Vbuffer_list_update_hook): New variable.
2100
2101 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2102 section.
2103
2104 * window.h (resize_frame_windows): Move up in code.
2105 (Fwindow_frame): Remove EXFUN.
2106 (replace_buffer_in_all_windows): Remove prototype.
2107 (replace_buffer_in_windows_safely): Add prototype.
2108
2109 * window.c: Declare Qdelete_window static again. Move down
2110 declaration of select_count.
2111 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2112 (Fother_window): Move to window.el.
2113 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2114 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2115 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2116 window.el.
2117 (replace_buffer_in_windows): Implement by calling
2118 Qreplace_buffer_in_windows.
2119 (replace_buffer_in_all_windows): Remove with some functionality
2120 moved into replace_buffer_in_windows_safely.
2121 (replace_buffer_in_windows_safely): New function.
2122 (select_window_norecord, select_frame_norecord): Move in front
2123 of run_window_configuration_change_hook. Remove now obsolete
2124 declarations.
2125 (Fset_window_buffer): Rewrite doc-string. Call
2126 Qrecord_window_buffer.
2127 (keys_of_window): Move binding for other-window to window.el.
2128
b50691aa
CY
21292011-06-11 Chong Yidong <cyd@stupidchicken.com>
2130
2131 * dispextern.h (struct image): Replace data member, whose int_val
2132 and ptr_val fields were not used by anything, with a single
2133 lisp_val object.
2134
2135 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2136 (gif_clear_image, gif_load, imagemagick_load_image)
2137 (gs_clear_image, gs_load): Callers changed.
2138
3f754b86
PE
21392011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2140
cca69397
PE
2141 * buffer.h: Include <time.h>, for time_t.
2142 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2143
109e28d0
PE
2144 Fix minor problems found by static checking.
2145
60737f02
PE
2146 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2147
4b66faf3
PE
2148 Make identifiers static if they are not used in other modules.
2149 * data.c (Qcompiled_function, Qframe, Qvector):
2150 * image.c (QimageMagick, Qsvg):
2151 * minibuf.c (Qmetadata):
2152 * window.c (resize_window_check, resize_root_window): Now static.
2153 * window.h (resize_window_check, resize_root_window): Remove decls.
2154
109e28d0
PE
2155 * window.c (window_deletion_count, delete_deletable_window):
2156 Remove; unused.
46a4ce9e
PE
2157 (window_body_lines): Now static.
2158 (Fdelete_other_windows_internal): Mark vars as initialized.
2159 Make sure 'resize_failed' is initialized.
2160 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2161 (resize_window_apply): Remove unused local.
2162 * window.h (delete_deletable_window): Remove decl.
2163
109e28d0 2164 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2165 (imagemagick_load_image): Fix pointer signedness problem by changing
2166 last arg from unsigned char * to char *. All uses changed.
2167 Also, fix a local for similar reasons.
2168 Remove unused locals. Remove locals to avoid shadowing.
2169 (fn_rsvg_handle_free): Remove; unused.
2170 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2171 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2172
3f754b86
PE
2173 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2174
2547adb1
CY
21752011-06-10 Chong Yidong <cyd@stupidchicken.com>
2176
2177 * image.c (gif_load): Fix omitted cast error introduced by
2178 2011-06-06 change.
2179
2c8e37d4
MR
21802011-06-10 Martin Rudalics <rudalics@gmx.at>
2181
2182 * window.h (resize_proportionally, orig_total_lines)
2183 (orig_top_line): Remove from window structure.
2184 (set_window_height, set_window_width, change_window_heights)
2185 (Fdelete_window): Remove prototypes.
2186 (resize_frame_windows): Remove duplicate declaration.
2187
440a42e3
EZ
21882011-06-10 Eli Zaretskii <eliz@gnu.org>
2189
2190 * window.h (resize_frame_windows, resize_window_check)
2191 (delete_deletable_window, resize_root_window)
2192 (resize_frame_windows): Declare prototypes.
2193
2194 * window.c (resize_window_apply): Make definition be "static" to
2195 match the prototype.
2196
562dd5e9
MR
21972011-06-10 Martin Rudalics <rudalics@gmx.at>
2198
2199 * window.c: Remove declarations of Qwindow_size_fixed,
2200 window_min_size_1, window_min_size_2, window_min_size,
2201 size_window, window_fixed_size_p, enlarge_window, delete_window.
2202 Remove static from declaration of Qdelete_window, it's
2203 temporarily needed by Fbury_buffer.
2204 (replace_window): Don't assign orig_top_line and
2205 orig_total_lines.
2206 (Fdelete_window, delete_window): Remove. Window deletion is
2207 handled by window.el.
2208 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2209 Fdelete_window calls with calls to Qdelete_window.
2210 (Fdelete_other_windows): Remove. Deleting other windows is
2211 handled by window.el.
2212 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2213 handled in window.el.
2214 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2215 Window minimum sizes are handled in window.el.
2216 (shrink_windows, size_window, set_window_height)
2217 (set_window_width, change_window_heights, window_height)
2218 (window_width, CURBEG, CURSIZE, enlarge_window)
2219 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2220 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2221 handled in window.el.
2222 (make_dummy_parent): Rename to make_parent_window and give it a
2223 second argument horflag.
2224 (make_window): Don't set resize_proportionally any more.
2225 (Fsplit_window): Remove. Windows are split in window.el.
2226 (save_restore_action, save_restore_orig_size)
2227 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2228 Resize mini windows in window.el.
2229 (grow_mini_window, shrink_mini_window): Implement by calling
2230 Qresize_root_window_vertically, resize_window_check and
2231 resize_window_apply.
2232 (saved_window, Fset_window_configuration, save_window_save): Do
2233 not handle orig_top_line, orig_total_lines, and
2234 resize_proportionally.
2235 (window_min_height, window_min_width): Move to window.el.
2236 (keys_of_window): Move bindings for delete-other-windows,
2237 split-window, delete-window and enlarge-window to window.el.
2238
2239 * buffer.c: Temporarily extern Qdelete_window.
2240 (Fbury_buffer): Temporarily call Qdelete_window instead of
2241 Fdelete_window (Fbury_buffer will move to window.el soon).
2242
2243 * frame.c (set_menu_bar_lines_1): Remove code handling
2244 orig_top_line and orig_total_lines.
2245
2246 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2247 set_window_height but set heights directly.
2248 (change_frame_size_1): Use resize_frame_windows.
2249
2250 * xdisp.c (init_xdisp): Don't use set_window_height but set
2251 heights directly.
2252
2253 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2254 resize_frame_windows instead of change_window_heights and run
2255 run_window_configuration_change_hook.
2256
2257 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2258 instead of change_window_heights and run
2259 run_window_configuration_change_hook.
2260
1a13852e
MR
22612011-06-09 Martin Rudalics <rudalics@gmx.at>
2262
2263 * window.c (replace_window): Rename second argument REPLACEMENT to
2264 NEW. New third argument SETFLAG. Rewrite.
2265 (delete_window, make_dummy_parent): Call replace_window with
2266 third argument 1.
2267 (window_list_1): Move down in code.
2268 (run_window_configuration_change_hook): Move set_buffer part
2269 before select_frame_norecord part in order to unwind correctly.
2270 Rename count1 to count.
2271 (recombine_windows, delete_deletable_window, resize_root_window)
2272 (Fdelete_other_windows_internal)
2273 (Frun_window_configuration_change_hook, make_parent_window)
2274 (resize_window_check, resize_window_apply, Fresize_window_apply)
2275 (resize_frame_windows, Fsplit_window_internal)
2276 (Fdelete_window_internal, Fresize_mini_window_internal): New
2277 functions.
2278 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2279
f3d1777e
MR
22802011-06-08 Martin Rudalics <rudalics@gmx.at>
2281
496e208e
MR
2282 * window.h (window): Add some new members to window structure -
2283 normal_lines, normal_cols, new_total, new_normal, clone_number,
2284 splits, nest, prev_buffers, next_buffers.
2285 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2286 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2287
f3d1777e
MR
2288 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2289 Remove.
496e208e
MR
2290 (make_dummy_parent): Set new members of windows structure.
2291 (make_window): Move down in code. Handle new members of window
2292 structure.
2293 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2294 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2295 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2296 (Fset_window_prev_buffers, Fwindow_next_buffers)
2297 (Fset_window_next_buffers, Fset_window_clone_number): New
2298 functions.
2299 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2300 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2301 Doc-string fixes.
2302 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2303 Argument WINDOW can be now internal window too.
2304 (Fwindow_use_time): Move up in code.
2305 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2306 Rewrite doc-string.
2307 (Fset_window_configuration, saved_window)
2308 (Fcurrent_window_configuration, save_window_save): Handle new
2309 members of window structure.
b9e809c2
MR
2310 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2311 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2312 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2313 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2314 Qget_mru_window, Qresize_root_window,
2315 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2316 Qauto_buffer_name; staticpro them.
f3d1777e 2317
abde8f8c
MR
23182011-06-07 Martin Rudalics <rudalics@gmx.at>
2319
2320 * window.c (Fwindow_total_size, Fwindow_left_column)
2321 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2322 (Fwindow_list_1): New functions.
2323 (window_box_text_cols): Replace with window_body_cols.
2324 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2325 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2326 (delete_window, Fset_window_configuration): Call
2327 delete_all_subwindows with window as argument.
2328 (delete_all_subwindows): Take a window as argument and not a
2329 structure. Rewrite.
190b47e6
MR
2330 (window_loop): Remove handling of GET_LRU_WINDOW and
2331 GET_LARGEST_WINDOW.
2332 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2333
2334 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2335 window_box_text_cols. delete_all_subwindows now takes a
2336 Lisp_Object as argument.
abde8f8c
MR
2337
2338 * indent.c (compute_motion, Fcompute_motion): Use
2339 window_body_cols instead of window_box_text_cols.
2340
fa8a67e6
MR
2341 * frame.c (delete_frame): Call delete_all_subwindows with root
2342 window as argument.
2343
a54e3482
DC
23442011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2345
2346 * fns.c (Fputhash): Document return value.
2347
60002bf5
CY
23482011-06-06 Chong Yidong <cyd@stupidchicken.com>
2349
2350 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2351
0c671da6 23522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2353
b862a52a 2354 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2355
be44ca6c
PE
2356 Check for overflow when converting integer to cons and back.
2357 * charset.c (Fdefine_charset_internal, Fdecode_char):
2358 Use cons_to_unsigned to catch overflow.
2359 (Fencode_char): Use INTEGER_TO_CONS.
2360 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2361 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2362 * data.c (long_to_cons, cons_to_long): Remove.
2363 (cons_to_unsigned, cons_to_signed): New functions.
2364 These signal an error for invalid or out-of-range values.
2365 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2366 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2367 * font.c (Ffont_variation_glyphs):
2368 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2369 * lisp.h: Include <intprops.h>.
2370 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2371 (cons_to_signed, cons_to_unsigned): New decls.
2372 (long_to_cons, cons_to_long): Remove decls.
2373 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2374 (Fprimitive_undo): Use CONS_TO_INTEGER.
2375 * xfns.c (Fx_window_property): Likewise.
2376 * xselect.c: Include <limits.h>.
2377 (x_own_selection, selection_data_to_lisp_data):
2378 Use INTEGER_TO_CONS.
2379 (x_handle_selection_request, x_handle_selection_clear)
2380 (x_get_foreign_selection, Fx_disown_selection_internal)
2381 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2382 (lisp_data_to_selection_data): Use cons_to_unsigned.
2383 (x_fill_property_data): Use cons_to_signed.
2384 Report values out of range.
2385
d1f3d2af
PE
2386 Check for buffer and string overflow more precisely.
2387 * buffer.h (BUF_BYTES_MAX): New macro.
2388 * lisp.h (STRING_BYTES_MAX): New macro.
2389 * alloc.c (Fmake_string):
2390 * character.c (string_escape_byte8):
2391 * coding.c (coding_alloc_by_realloc):
2392 * doprnt.c (doprnt):
2393 * editfns.c (Fformat):
2394 * eval.c (verror):
2395 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2396 since they may not be the same number.
2397 * editfns.c (Finsert_char):
2398 * fileio.c (Finsert_file_contents):
2399 Likewise for BUF_BYTES_MAX.
2400
dd52fcea
PE
2401 * image.c: Use ptrdiff_t, not int, for sizes.
2402 (slurp_file): Switch from int to ptrdiff_t.
2403 All uses changed.
2404 (slurp_file): Check that file size fits in both size_t (for
2405 malloc) and ptrdiff_t (for sanity and safety).
2406
7f9bbdbb
PE
2407 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2408 if b->modtime has its maximal value.
2409
dfe18f82
PE
2410 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2411
84acfcf0
PE
2412 Don't assume time_t can fit into int.
2413 * buffer.h (struct buffer.modtime): Now time_t, not int.
2414 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2415 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2416
ccd9a01a
PE
2417 Minor fixes for signed vs unsigned integers.
2418 * character.h (MAYBE_UNIFY_CHAR):
2419 * charset.c (maybe_unify_char):
2420 * keyboard.c (read_char, reorder_modifiers):
2421 XINT -> XFASTINT, since the integer must be nonnegative.
2422 * ftfont.c (ftfont_spec_pattern):
2423 * keymap.c (access_keymap, silly_event_symbol_error):
2424 XUINT -> XFASTINT, since the integer must be nonnegative.
2425 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2426 since it makes no difference and we prefer signed.
2427 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2428 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2429 nonnegative.
2430
d6d100dd
SM
24312011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2432
2433 * window.h (Fwindow_frame): Declare.
2434
2b6148e4
PE
24352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2438 (SPARE_MEMORY): Always define.
2439 (LARGE_REQUEST): Remove.
2440 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2441
f230ecc9
MR
24422011-06-06 Martin Rudalics <rudalics@gmx.at>
2443
727e958e
MR
2444 * lisp.h: Move EXFUNS for Fframe_root_window,
2445 Fframe_first_window and Fset_frame_selected_window to window.h.
2446
2447 * window.h: Move EXFUNS for Fframe_root_window,
2448 Fframe_first_window and Fset_frame_selected_window here from
2449 lisp.h.
2450
2451 * frame.c (Fwindow_frame, Fframe_first_window)
2452 (Fframe_root_window, Fframe_selected_window)
2453 (Fset_frame_selected_window): Move to window.c.
2454 (Factive_minibuffer_window): Move to minibuf.c.
2455 (Fother_visible_frames_p): New function.
2456
2457 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2458
f230ecc9
MR
2459 * window.c (decode_window, decode_any_window): Move up in code.
2460 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2461 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2462 (Fwindow_buffer): Move up and rewrite doc-string.
2463 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2464 (Fwindow_prev): New functions.
727e958e
MR
2465 (Fwindow_frame): Move here from frame.c. Accept any window as
2466 argument.
2467 (Fframe_root_window, Fframe_first_window)
2468 (Fframe_selected_window): Move here from frame.c. Accept frame
2469 or arbitrary window as argument. Update doc-strings.
2470 (Fminibuffer_window): Move up in code.
2471 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2472 (Fset_frame_selected_window): Move here from frame.c.
2473 Marginal rewrite.
727e958e
MR
2474 (Fselected_window, select_window, Fselect_window): Move up in
2475 code. Minor doc-string fixes.
f230ecc9 2476
4d09bcf6
PE
24772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2478
2479 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2480 Do not assume that spare memory exists; that assumption is valid
2481 only if SYSTEM_MALLOC.
2482 (LARGE_REQUEST): New macro, so that the issue of large requests
2483 is separated from the issue of spare memory.
2484
810928a2
AS
24852011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2486
172418ad
AS
2487 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2488 format. (Bug#8806)
2489
43f862f7
AS
2490 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2491
810928a2
AS
2492 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2493 before statements.
2494
a059fe24
JD
24952011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2496
2497 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2498
2499 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2500
2501 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2502 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2503
989bf368
JB
25042011-06-05 Juanma Barranquero <lekktu@gmail.com>
2505
2506 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2507
4b80f674
CY
25082011-06-04 Chong Yidong <cyd@stupidchicken.com>
2509
2510 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2511 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2512 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2513 New error handlers.
4b80f674
CY
2514 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2515 Obey Vx_select_enable_clipboard_manager. Catch errors in
2516 x_clipboard_manager_save (Bug#8779).
2517 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2518 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2519
99a33b77 25202011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2521
2522 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2523
99a33b77 25242011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2525
2526 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2527 in the current matrix if keep_current_p is non-zero.
2528
8264569d
EZ
25292011-06-04 Eli Zaretskii <eliz@gnu.org>
2530
2531 * bidi.c (bidi_level_of_next_char): Fix last change.
2532
57f97249
EZ
25332011-06-03 Eli Zaretskii <eliz@gnu.org>
2534
fec2107c 2535 Support bidi reordering of text covered by display properties.
57f97249 2536
fec2107c
EZ
2537 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2538 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2539 (bidi_cache_search, bidi_cache_iterator_state)
2540 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2541 (bidi_level_of_next_char, bidi_move_to_visually_next):
2542 Support character positions inside a run of characters covered by a
fec2107c
EZ
2543 display string.
2544 (bidi_paragraph_init, bidi_resolve_explicit_1)
2545 (bidi_level_of_next_char): Call bidi_fetch_char and
2546 bidi_fetch_char_advance instead of FETCH_CHAR and
2547 FETCH_CHAR_ADVANCE.
2548 (bidi_init_it): Initialize new members.
2549 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2550 definitions.
2551 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2552 instead of using explicit *_CHAR codes.
d6d100dd
SM
2553 (bidi_resolve_explicit, bidi_resolve_weak):
2554 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2555 bidirectional text is supported only in multibyte buffers.
2556 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2557 it to initialize the frame_window_p member of struct bidi_it.
2558 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2559 (bidi_resolve_explicit, bidi_resolve_weak)
2560 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2561 bidi_it->nchars is non-positive.
2562 (bidi_level_of_next_char): Don't try to lookup the cache for the
2563 next/previous character if nothing is cached there yet, or if we
2564 were just reseat()'ed to a new position.
c40e2fb2 2565
0e14fe90
EZ
2566 * xdisp.c (set_cursor_from_row): Set start and stop points
2567 according to the row's direction when priming the loop that looks
2568 for the glyph on which to display cursor.
2569 (single_display_spec_intangible_p): Function deleted.
2570 (display_prop_intangible_p): Reimplement to call
2571 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2572 Accept 3 additional arguments needed by handle_display_spec.
2573 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2574 values: lists, `(when COND...)' forms, etc.
2575 (single_display_spec_string_p): Support property values that are
2576 lists with the argument STRING its top-level element.
2577 (display_prop_string_p): Fix the condition for processing a
2578 property that is a list to be consistent with handle_display_spec.
fec2107c 2579 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2580 last portion of handle_display_prop.
2581 (compute_display_string_pos): Accept additional argument
2582 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2583 value of a `display' property is a "replacing spec".
2584 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2585 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2586 the display property, but just return a value indicating whether
2587 the display property will replace the characters it covers.
2588 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2589 frame_window_p members of struct bidi_it.
d6d100dd
SM
2590 (compute_display_string_pos, compute_display_string_end):
2591 New functions.
fec2107c
EZ
2592 (push_it): Accept second argument POSITION, where pop_it should
2593 jump to continue iteration.
2594 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2595
fec2107c
EZ
2596 * keyboard.c (adjust_point_for_property): Adjust the call to
2597 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2598
2599 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2600 (bidi_init_it): Update prototypes.
2601 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2602 (compute_display_string_pos, compute_display_string_end):
2603 Declare prototypes.
fec2107c
EZ
2604 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2605 EMACS_INT.
fc6f18ce 2606
40087514 26072011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2608
57f53182
PE
2609 Malloc failure behavior now depends on size of allocation.
2610 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2611 * lisp.h: Change signatures accordingly.
2612 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2613 All callers changed. (Bug#8762)
2614
2615 * gnutls.c: Use Emacs's memory allocators.
2616 Without this change, the gnutls library would invoke malloc etc.
2617 directly, which causes problems on non-SYNC_INPUT hosts, and which
2618 runs afoul of improving memory_full behavior. (Bug#8761)
2619 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2620 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2621 xfree instead of the default malloc, realloc, free.
2622 (Fgnutls_boot): No need to check for memory allocation failure,
2623 since xmalloc does that for us.
2624
ac32cd99 2625 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2626 * category.c (hash_get_category_set):
2627 * ccl.c (ccl_driver):
2628 * charset.c (Fdefine_charset_internal):
2629 * charset.h (struct charset.hash_index):
2630 * composite.c (get_composition_id, gstring_lookup_cache)
2631 (composition_gstring_put_cache):
2632 * composite.h (struct composition.hash_index):
2633 * dispextern.h (struct image.hash):
2634 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2635 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2636 (hashfn_equal, hashfn_user_defined, make_hash_table)
2637 (maybe_resize_hash_table, hash_lookup, hash_put)
2638 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2639 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2640 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2641 * image.c (make_image, search_image_cache, lookup_image)
2642 (xpm_put_color_table_h):
2643 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2644 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2645 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2646 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2647 * alloc.c (allocate_vectorlike):
2648 Check for overflow in vector size calculations.
2649 * ccl.c (ccl_driver):
2650 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2651 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2652 need to be updated by these changes.
40087514
PE
2653 * fns.c (make_hash_table, maybe_resize_hash_table):
2654 Check for integer overflow with large hash tables.
0de4bb68
PE
2655 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2656 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2657 (SXHASH_REDUCE): New macro.
2658 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2659 Use it instead of discarding useful hash info with large hash values.
2660 (sxhash_float): New function.
2661 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2662 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2663 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2664 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2665 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2666 Adjust signatures to match updated version of code.
2667 (consing_since_gc): Now EMACS_INT, since a single hash table can
2668 use more than INT_MAX bytes.
2669
698d32e2
DN
26702011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2671
2672 Make it possible to build with GCC-4.6+ -O2 -flto.
2673
2674 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2675
fd6fa53f
SM
26762011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2677
2678 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2679 Call minibuffer-inactive-mode.
2680
864db017
JB
26812011-05-31 Juanma Barranquero <lekktu@gmail.com>
2682
2683 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2684 Update dependencies.
2685
2ad0baf4
DN
26862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2687
2688 * data.c (init_data): Remove code for UTS, this system is not
2689 supported anymore.
2690
4fcc2638
DN
26912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2692
2693 Don't force ./temacs to start in terminal mode.
2694
2695 * frame.c (make_initial_frame): Initialize faces in all cases, not
2696 only when CANNOT_DUMP is defined.
2697 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2698
c56e0fd5
DN
26992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2700
2701 * dispnew.c (add_window_display_history): Use const for the string
2702 pointer. Remove declaration, not needed.
2703
333d54da 27042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2705
55d4c1b2 2706 Use 'inline', not 'INLINE'.
333d54da 2707 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2708 * alloc.c, fontset.c (INLINE): Remove.
2709 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2710 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2711 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2712 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2713 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2714
738db178
DN
27152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2716
2717 Make it possible to run ./temacs.
2718
2719 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2720 syms_of_callproc does the same thing. Remove test for
2721 "initialized", do it in the caller.
2722 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2723
620c53a6
SM
27242011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2725
2726 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2727 (read_minibuf): Use get_minibuffer.
2728 (syms_of_minibuf): Use DEFSYM.
2729 (Qmetadata): New var.
2730 * data.c (Qbuffer): Don't make it static.
2731 (syms_of_data): Use DEFSYM.
2732
e003a292
PE
27332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2734
2735 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2736 (CCL_CODE_MIN): New macro.
2737
ed008a6d
PE
27382011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2739
3687c2ef
PE
2740 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2741
ed008a6d
PE
2742 * eval.c (Qdebug): Now static.
2743 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2744 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2745 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2746
d66c4c7c
CY
27472011-05-29 Chong Yidong <cyd@stupidchicken.com>
2748
2749 * image.c: Various fixes to ImageMagick code comments.
2750 (Fimagemagick_types): Doc fix.
2751
5fbc2025
PE
27522011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2753
0196f88a
PE
2754 Minor fixes prompted by GCC 4.6.0 warnings.
2755
2756 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2757
5fbc2025
PE
2758 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2759 (x_clipboard_manager_save_all): Move extern decl to ...
2760 * xterm.h: ... here, so that it can be checked for consistency.
2761
1dd3c2d9
CY
27622011-05-29 Chong Yidong <cyd@stupidchicken.com>
2763
2764 * xselect.c (x_clipboard_manager_save_frame)
2765 (x_clipboard_manager_save_all): New functions.
2766 (Fx_clipboard_manager_save): Lisp function deleted.
2767
2768 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2769 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2770
2771 * xterm.h: Update prototype.
2772
5ba6571d
WX
27732011-05-28 William Xu <william.xwl@gmail.com>
2774
2775 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2776 exiting (Bug#8239).
2777
3eaff834
JM
27782011-05-28 Jim Meyering <meyering@redhat.com>
2779
e1900994 2780 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2781 * fns.c (to_uchar): Define.
2782 (crypto_hash_function): Use it to convert some newly-signed
2783 variables to unsigned, to avoid sign-extension bugs. For example,
2784 without this change, (md5 "truc") would evaluate to
2785 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2786 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2787 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2788
0f6990a7
PE
27892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 Integer overflow fixes.
c8a9ca5a 2792
08686060
PE
2793 * dbusbind.c: Serial number integer overflow fixes.
2794 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2795 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2796 to hold a serial number that is too large for a fixnum.
2797 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2798 Check for serial numbers out of range. Decode any serial number
59568bf0 2799 that was so large that it became a float. (Bug#8722)
08686060 2800
2d1fc3c7
PE
2801 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2802 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2803 Use XFASTINT rather than XUINT when numbers are nonnegative.
2804 (xd_append_arg, Fdbus_method_return_internal):
2805 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2806 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2807 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2808 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2809 (Bug#8722)
2d1fc3c7 2810
c8a9ca5a
PE
2811 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2812
519e1d69
PE
2813 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2814
30569699
PE
2815 ccl: add integer overflow checks
2816 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2817 (IN_INT_RANGE): New macros.
2818 (ccl_driver): Use them to check for integer overflow when
2819 decoding a CCL program. Many of the new checks are whether XINT (x)
2820 fits in int; it doesn't always, on 64-bit hosts. The new version
2821 doesn't catch all possible integer overflows, but it's an
847044ea 2822 improvement. (Bug#8719)
30569699 2823
c11285dc
PE
2824 * alloc.c (make_event_array): Use XINT, not XUINT.
2825 There's no need for unsigned here.
2826
fdccd48e
PE
2827 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2828 This follows up to the 2011-05-06 change that substituted uintptr_t
2829 for EMACS_INT. This case wasn't caught back then.
2830
37910ab2
PE
2831 Rework Fformat to avoid integer overflow issues.
2832 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2833 now (part of C89). Include <verify.h>.
2834 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2835 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2836 (Fformat): Avoid the prepass trying to compute sizes; it was only
2837 approximate and thus did not catch overflow reliably. Instead, walk
2838 through the format just once, formatting and computing sizes as we go,
2839 checking for integer overflow at every step, and allocating a larger
2840 buffer as needed. Keep track separately whether the format is
2841 multibyte. Keep only the most-recently calculated precision, rather
2842 than them all. Record whether each argument has been converted to
2843 string. Use EMACS_INT, not int, for byte and char and arg counts.
2844 Support field widths and precisions larger than INT_MAX. Avoid
2845 sprintf's undefined behavior with conversion specifications such as %#d
2846 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2847 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2848 formatting out-of-range floating point numbers with int
9173deec 2849 formats. (Bug#8668)
37910ab2 2850
2e6578fb
PE
2851 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2852
0ae6bdee
PE
2853 * data.c: Avoid integer truncation in expressions involving floats.
2854 * data.c: Include <intprops.h>.
2855 (arith_driver): When there's an integer overflow in an expression
2856 involving floating point, convert the integers to floating point
2857 so that the resulting value does not suffer from catastrophic
2858 integer truncation. For example, on a 64-bit host (* 4
2859 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2860 Do not rely on undefined behavior after integer overflow.
2861
de883a70
PE
2862 merge count_size_as_multibyte, parse_str_to_multibyte
2863 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2864 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2865 Check for integer overflow.
2866 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2867 since it's now a duplicate of the other. This is more of
2868 a character than a buffer op, so better that it's in character.c.
2869 * fns.c, print.c: Adjust to above changes.
2870
2ff916cb
PE
28712011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2872
2873 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2874
f1b54466
PE
28752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2876
fb1ac845
PE
2877 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2878 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2879 (x_clipboard_manager_save): Now static.
2880 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2881
f1b54466
PE
2882 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2883 (crypto_hash_function): Now static.
2884 Fix pointer signedness problems. Avoid unnecessary initializations.
2885
a9f737ee
CY
28862011-05-27 Chong Yidong <cyd@stupidchicken.com>
2887
2888 * termhooks.h (Vselection_alist): Make it terminal-local.
2889
2890 * terminal.c (create_terminal): Initialize it.
2891
2892 * xselect.c: Support for clipboard managers.
2893 (Vselection_alist): Move to termhooks.h as terminal-local var.
2894 (LOCAL_SELECTION): New macro.
2895 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2896 (symbol_to_x_atom): Remove gratuitous arg.
2897 (x_handle_selection_request, lisp_data_to_selection_data)
2898 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2899 (x_own_selection, x_get_local_selection, x_convert_selection):
2900 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2901 (some_frame_on_display): Delete unused function.
2902 (Fx_own_selection_internal, Fx_get_selection_internal)
2903 (Fx_disown_selection_internal, Fx_selection_owner_p)
2904 (Fx_selection_exists_p): New optional frame arg.
2905 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2906 (x_handle_selection_clear): Don't treat other terminals with the
2907 same keyboard specially. Use the terminal-local Vselection_alist.
2908 (x_clear_frame_selections): Use Frun_hook_with_args.
2909
2910 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2911
2912 * xterm.h: Add support for those atoms.
2913
e067f0c1
CY
29142011-05-26 Chong Yidong <cyd@stupidchicken.com>
2915
2916 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2917 (converted_selections, conversion_fail_tag): New global variables.
2918 (x_selection_request_lisp_error): Free the above.
2919 (x_get_local_selection): Remove unnecessary code.
2920 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2921 of converted selections stored in converted_selections.
2922 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2923 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2924 (x_convert_selection): New function.
2925 (x_handle_selection_event): Simplify.
2926 (x_get_foreign_selection): Don't ignore incoming requests while
2927 waiting for an answer; this will fail when we implement
2928 SAVE_TARGETS, and seems unnecessary anyway.
2929 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2930 (Vx_sent_selection_functions): Doc fix.
2931
0f4aebc0
LL
29322011-05-26 Leo Liu <sdl.web@gmail.com>
2933
2934 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2935
e61124cd
YM
29362011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2937
2938 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2939
2940 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2941 for fringe update if it has periodic bitmap.
ac389d0c 2942 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2943 and fringe_bitmap_periodic_p.
2944
2945 * fringe.c (get_fringe_bitmap_data): New function.
2946 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2947 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2948 row. Mark glyph row for fringe update if periodicity changed.
2949
2950 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2951 for fringe update unless it has periodic bitmap.
2952
f16d9837
KH
29532011-05-25 Kenichi Handa <handa@m17n.org>
2954
2955 * xdisp.c (get_next_display_element): Set correct it->face_id for
2956 a static composition.
2957
e1b90ef6
LL
29582011-05-24 Leo Liu <sdl.web@gmail.com>
2959
2960 * deps.mk (fns.o):
2961 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2962
2963 * fns.c (crypto_hash_function, Fsha1): New function.
2964 (Fmd5): Use crypto_hash_function.
2965 (syms_of_fns): Add Ssha1.
2966
7400048f
PE
29672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2968
2969 * gnutls.c: Remove unused macros.
2970 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2971 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2972 Remove macros that are defined and never used.
2973 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2974
abb71cf4
CY
29752011-05-22 Chong Yidong <cyd@stupidchicken.com>
2976
2977 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2978 (Fx_get_selection_internal): Minor cleanup.
2979 (Fx_own_selection_internal): Rename arguments for consistency with
2980 select.el.
2981
6307db39
PE
29822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2983
2984 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2985
f3d4e0a4
CY
29862011-05-22 Chong Yidong <cyd@stupidchicken.com>
2987
2988 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2989
4d8ade89
YM
29902011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2991
2992 * dispnew.c (scrolling_window): Don't exclude the case that the
2993 last enabled row in the desired matrix touches the bottom boundary.
2994
32078c8d
GM
29952011-05-21 Glenn Morris <rgm@gnu.org>
2996
2997 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2998 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2999 and add some more files.
32078c8d 3000
7285dc67
EZ
30012011-05-20 Eli Zaretskii <eliz@gnu.org>
3002
3003 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3004 report_file_error introduced by the change from 2011-05-07.
3005
89d1bd22
PE
30062011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3007
3008 * systime.h (Time): Define only if emacs is defined.
3009 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3010 where the include path doesn't have X11/X.h by default. See
3011 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3012
e23640bb 30132011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3014
3015 * composite.c (find_automatic_composition): Fix previous change.
3016
b9704ad9
GM
30172011-05-20 Glenn Morris <rgm@gnu.org>
3018
3019 * lisp.mk: New file, split from Makefile.in.
3020 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3021 (shortlisp): Remove.
3022 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3023
4a720484
GM
30242011-05-19 Glenn Morris <rgm@gnu.org>
3025
3026 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3027 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3028 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3029 (lisp): Set the order to that of loadup.el.
3030 (shortlisp): Make it a copy of $lisp.
3031 (SOME_MACHINE_LISP): Remove.
3032 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3033 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3034
a28d4396
KH
30352011-05-18 Kenichi Handa <handa@m17n.org>
3036
3037 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3038 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3039 (find_automatic_composition): Mostly rewrite for efficiency.
3040
a2b1fa8e
JB
30412011-05-18 Juanma Barranquero <lekktu@gmail.com>
3042
3043 * makefile.w32-in: Update dependencies.
3044
8e1f5610
CS
30452011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3046
3047 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3048 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3049
7025ee00 30502011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3051
cdfa6eab
PE
3052 Fix some integer overflow issues, such as string length overflow.
3053
06d6db33
PE
3054 * insdel.c (count_size_as_multibyte): Check for string overflow.
3055
2b4560a8
PE
3056 * character.c (lisp_string_width): Check for string overflow.
3057 Use EMACS_INT, not int, for string indexes and lengths; in
3058 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3059 the resulting string length overflows an EMACS_INT; instead,
3060 report a string overflow if no precision given. When checking for
3061 precision exhaustion, use a check that cannot possibly have
3062 integer overflow. (Bug#8675)
3063 * character.h (lisp_string_width): Adjust to new signature.
3064
cb93f9be
PE
3065 * alloc.c (string_overflow): New function.
3066 (Fmake_string): Use it. This doesn't change behavior, but saves
3067 a few bytes and will simplify future changes.
3068 * character.c (string_escape_byte8): Likewise.
3069 * lisp.h (string_overflow): New decl.
3070
1a1f3366
PE
3071 Fixups, following up to the user-interface timestamp change.
3072 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3073 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3074 * msdos.c (mouse_get_pos): Likewise.
3075 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3076 * w32gui.h (Time): Define by including "systime.h" rather than by
3077 declaring it ourselves. (Bug#8664)
3078
d4e3e4d3
PE
3079 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3080 * image.c (clear_image_cache): Likewise.
3081
f6a24d19
PE
3082 * term.c (term_mouse_position): Don't assume time_t wraparound.
3083
08dc5ae6
PE
3084 Be more systematic about user-interface timestamps.
3085 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3086 and sometimes 'EMACS_UINT', to represent these timestamps.
3087 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3088 This makes the code easier to follow, and makes it easier to catch
3089 integer overflow bugs such as Bug#8664.
3090 * frame.c (Fmouse_position, Fmouse_pixel_position):
3091 Use Time, not unsigned long, for user-interface timestamps.
3092 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3093 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3094 * keyboard.h (last_event_timestamp): Likewise.
3095 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3096 * menu.h (xmenu_show): Likewise.
3097 * term.c (term_mouse_position): Likewise.
3098 * termhooks.h (struct input_event.timestamp): Likewise.
3099 (struct terminal.mouse_position_hook): Likewise.
3100 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3101 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3102 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3103 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3104 what it was before.
3105 * menu.h, termhooks.h: Include "systime.h", for Time.
3106
8e55734a
PE
3107 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3108 Don't assume that the difference between two unsigned long values
3109 can fit into an integer. At this point, we know button_down_time
3110 <= event->timestamp, so the difference must be nonnegative, so
3111 there's no need to cast the result if double-click-time is
3112 nonnegative, as it should be; check that it's nonnegative, just in
3113 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3114 apart (about 25 days). (Bug#8664)
8e55734a 3115
841f1b75 3116 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3117 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3118
3e26f69c
PE
3119 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3120 that always fit in int. Use a sentinel instead of a counter, to
3121 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3122 * frame.h (struct frame): Use int for menu_bar_items_used
3123 instead of EMACS_INT, since it always fits in int.
3e26f69c 3124
5cc152c0
PE
3125 * menu.c (grow_menu_items): Check for int overflow.
3126
d89eb65e
PE
3127 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3128
5235bd3e
PE
3129 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3130 Before, the code was not consistent. These values cannot exceed
3131 2**31 - 1 so there's no need to make them unsigned.
3132 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3133 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3134 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3135 as modifiers.
3136 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3137
bc827e23
PE
3138 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3139 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3140 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3141 presumably because the widths might not match.
3142
78eb494e
PE
3143 * window.c (size_window): Avoid needless test at loop start.
3144
04f2d78b
CB
31452011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3146
3147 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3148
d2fc7e3d 31492011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3150
3151 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3152
d2fc7e3d 31532011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3154
3155 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3156 `width' to `bar_area_x' and `bar_area_width', respectively.
3157 (x_scroll_run): Take account of fringe background extension.
3158
04f2d78b
CB
3159 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3160 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3161 `bar_area_width', respectively.
3162 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3163 background extension.
3164
79b70037
GM
31652011-05-10 Jim Meyering <meyering@redhat.com>
3166
3167 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3168
2f142cc5
JB
31692011-05-10 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * image.c (Finit_image_library): Return t for built-in image types,
3172 like pbm and xbm. (Bug#8640)
3173
57679c86
AS
31742011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3175
3176 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3177
888c9e86
EZ
31782011-05-07 Eli Zaretskii <eliz@gnu.org>
3179
b0512a1d
EZ
3180 * w32console.c (Fset_screen_color): Doc fix.
3181 (Fget_screen_color): New function.
3182 (syms_of_ntterm): Defsubr it.
3183
7285dc67
EZ
3184 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3185 unlink the temporary file if Fcall_process didn't create it in the
3186 first place.
3187 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3188 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3189 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3190 cue to call_process_cleanup not to close that handle.
3191
4d3fcc8e
BK
31922011-05-07 Ben Key <bkey76@gmail.com>
3193
3194 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3195 one of two shell specific rules, either bootstrap-temacs-CMD or
3196 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3197 to the previous implementation of the bootstrap-temacs rule.
3198 The bootstrap-temacs-CMD rule is similar to the previous
3199 implementation of the bootstrap-temacs rule except that it
3200 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3201 variable.
3202
3203 These changes, along with some changes to nt/configure.bat,
3204 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3205 earlier fix to add support for --cflags and --ldflags options
3206 that include quotes so that it works whether make uses cmd or
3207 sh as the shell.
3208
b4289b64
MA
32092011-05-06 Michael Albinus <michael.albinus@gmx.de>
3210
3211 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3212 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3213 is a constant.
3214 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3215 a string. Handle both cases.
3216 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3217 (Fdbus_register_method): Use Qinvalid_function.
3218
af4c0e28
JB
32192011-05-06 Juanma Barranquero <lekktu@gmail.com>
3220
3221 * makefile.w32-in: Update dependencies.
3222 (LISP_H): Add inttypes.h and stdin.h.
3223 (PROCESS_H): Add unistd.h.
3224
c51453d9
EZ
32252011-05-06 Eli Zaretskii <eliz@gnu.org>
3226
3227 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3228 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3229
8ff0ac3c 32302011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3231
4c4b566b
PE
3232 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3233
aab2b9b5
PE
3234 * term.c (vfatal): Remove stray call to va_end.
3235 It's not needed and the C Standard doesn't allow it here anyway.
3236
c378da0b
PE
3237 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3238 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3239
288b08c7
PE
3240 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3241 bytes.
3242
e3601888
PE
3243 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3244
db6c0e74
PE
3245 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3246
dd5963ea
PE
3247 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3248
88c9450f
PE
3249 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3250
2f9442b8
PE
3251 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3252
c032b5f8
PE
3253 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3254 * charset.c (Fdefine_charset_internal): Don't initialize
3255 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3256 32-bit int (Bug#8600).
a108c10b
PE
3257
3258 * lread.c (read_integer): Be more consistent with string-to-number.
3259 Use string_to_number to do the actual conversion; this avoids
3260 rounding errors and fixes some other screwups. Without this fix,
3261 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3262 (digit_to_number): Move earlier, for benefit of read_integer.
3263 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3264 not a digit in any supported base. (Bug#8602)
a108c10b 3265
ad5f9eea
PE
3266 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3267
aec1708a
PE
3268 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3269 to match comment at start of function. This also removes a
3270 GCC warning about overflow in a 32+64-bit port.
3271
47be4ab5
PE
3272 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3273
371cac43
PE
3274 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3275 Reported by Stefan Monnier in
3276 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3277 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3278 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3279
d01a7826
PE
3280 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3281 (EMACS_UINTPTR): Likewise, with uintptr_t.
3282
7fd47d5c
PE
3283 * lisp.h: Prefer 64-bit EMACS_INT if available.
3284 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3285 on 32-bit hosts that have 64-bit int, so that they can access
3286 large files.
122b0c86
PE
3287 However, temporarily disable this change unless the temporary
3288 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3289
8727937b
PE
3290 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3291
8ac068ac
PE
3292 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3293 This removes an assumption that EMACS_INT and long are the same
3294 width as pointers. The assumption is true for Emacs porting targets
3295 now, but we want to make other targets possible.
3296 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3297 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3298 In the rest of the code, change types of integers that hold casted
3299 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3300 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3301 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3302 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3303 No need to cast type when ORing.
3304 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3305 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3306 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3307 assume EMACS_INT is the same width as char *.
3308 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3309 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3310 Remove no-longer-needed casts.
3311 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3312 (xg_tool_bar_help_callback, xg_make_tool_item):
3313 Use EMACS_INTPTR to hold an integer
3314 that will be cast to void *; this can avoid a GCC warning
3315 if EMACS_INT is not the same width as void *.
3316 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3317 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3318 (current_message_1, set_message_1):
3319 Use a local to convert to proper width without a cast.
3320 * xmenu.c (dialog_selection_callback): Likewise.
3321
ede49d71
PE
3322 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3323 Also, don't assume VALBITS / RAND_BITS is less than 5,
3324 and don't rely on undefined behavior when shifting a 1 left into
3325 the sign bit.
3326 * lisp.h (get_random): Change signature to match.
3327
2f30ecd0
PE
3328 * lread.c (hash_string): Use size_t, not int, for hash computation.
3329 Normally we prefer signed values; but hashing is special, because
3330 it's better to use unsigned division on hash table sizes so that
3331 the remainder is nonnegative. Also, size_t is the natural width
3332 for hashing into memory. The previous code used 'int', which doesn't
3333 retain enough info to hash well into very large tables.
3334 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3335
2a866e7b
PE
3336 * dbusbind.c: Don't possibly lose pointer info when converting.
3337 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3338 Use XPNTR rather than XHASH, so that the high-order bits of
3339 the pointer aren't lost when converting through void *.
3340
51639eac
PE
3341 * eval.c (Fautoload): Don't double-shift a pointer.
3342
92394119
PE
3343 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3344
dbdb9a7c
JB
33452011-05-06 Juanma Barranquero <lekktu@gmail.com>
3346
3347 * gnutls.c (DEF_GNUTLS_FN):
3348 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3349
db7a0b4f
AS
33502011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3351
3352 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3353 marker. (Bug#8610)
3354
f7ff1b0f 33552011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3356
3357 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3358 New version that can reserve upto 2GB of heap space.
3359
f7ff1b0f 33602011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3361
3362 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3363
639c109b
TZ
33642011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3365
3366 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3367 `gnutls_certificate_set_x509_key_file'.
3368
d2127135
JB
33692011-05-05 Juanma Barranquero <lekktu@gmail.com>
3370
3371 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3372 Update dependencies.
3373
e968f4f3
JB
33742011-05-04 Juanma Barranquero <lekktu@gmail.com>
3375
3376 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3377 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3378 Remove unused parameter `fildes'.
3379 * process.c (read_process_output, send_process): Don't pass it.
3380
84d358f0
JB
33812011-05-04 Juanma Barranquero <lekktu@gmail.com>
3382
3383 Fix previous change: the library cache is defined in w32.c.
3384 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3385 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3386
0898ca10
JB
33872011-05-04 Juanma Barranquero <lekktu@gmail.com>
3388
3389 Implement dynamic loading of GnuTLS on Windows.
3390
3391 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3392 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3393 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3394 Declare.
3395
3396 * gnutls.c (Qgnutls_dll): Define.
3397 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3398 (gnutls_*): Declare function pointers.
3399 (init_gnutls_functions): New function to initialize function pointers.
3400 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3401 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3402 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3403 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3404 (emacs_gnutls_write, emacs_gnutls_read)
3405 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3406 (Fgnutls_available_p): New function.
3407 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3408 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3409 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3410
3411 * image.c: Include w32.h.
3412 (Vimage_type_cache): Delete.
3413 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3414 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3415 (w32_delayed_load): Move to w32.c.
3416
3417 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3418
3419 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3420 (w32_delayed_load): Move from image.c. When loading a library, record
3421 its filename in the :loaded-from property of the library id.
3422 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3423 Initialize and staticpro them.
3424 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3425
3426 * process.c: Include lisp.h before w32.h, not after.
3427 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3428 instead of gnutls_record_check_pending.
3429
3430 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3431
ff4de4aa
TZ
34322011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3433
3434 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3435 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3436 as passed in.
3437
abe95abb
JD
34382011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3439
3440 * xterm.c (x_set_frame_alpha): Do not set property on anything
3441 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3442
e16e55d4
JB
34432011-05-02 Juanma Barranquero <lekktu@gmail.com>
3444
3445 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3446
bafcf6a5
JB
34472011-05-02 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3450 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3451 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3452 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3453 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3454 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3455 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3456 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3457 (Qgnutls_bootprop_callbacks_verify): Make static.
3458
e7a6747f
AS
34592011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3460
19ed11ba
AS
3461 * callproc.c: Indentation fixup.
3462
e7a6747f 3463 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3464 (wait_for_termination, interruptible_wait_for_termination):
3465 Move after wait_for_termination_1.
e7a6747f 3466
1ef14cb4
LMI
34672011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3468
3469 * sysdep.c (interruptible_wait_for_termination): New function
3470 which is like wait_for_termination, but allows keyboard
3471 interruptions.
3472
3473 * callproc.c (Fcall_process): Add (:file "file") as an option for
3474 the STDOUT buffer.
3475 (Fcall_process_region): Ditto.
3476
330d880c
EZ
34772011-04-30 Eli Zaretskii <eliz@gnu.org>
3478
8db90b73
EZ
3479 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3480 rather than `XVECTOR (FOO)->size'.
3481
330d880c
EZ
3482 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3483 inttypes.h, as a gnulib replacement is used if it not available in
3484 system headers.
3485
15cbd324
EZ
34862011-04-21 Eli Zaretskii <eliz@gnu.org>
3487
3488 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3489 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3490 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3491
3492 * coding.c (coding_alloc_by_realloc): Error out if destination
3493 will grow beyond MOST_POSITIVE_FIXNUM.
3494 (decode_coding_emacs_mule): Abort if there isn't enough place in
3495 charbuf for the composition carryover bytes. Reserve an extra
3496 space for up to 2 characters produced in a loop.
3497 (decode_coding_iso_2022): Abort if there isn't enough place in
3498 charbuf for the composition carryover bytes.
3499
35002011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3501
ae940cca
EZ
3502 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3503 aborting when %lld or %lll format is passed.
3504 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3505 %llo or %llx format is passed. (Bug#8545)
3506
03ab8921
EZ
3507 * window.c (window_scroll_line_based): Use a marker instead of
3508 simple variables to record original value of point. (Bug#7952)
3509
afda1437
EZ
3510 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3511 produced by %s or %c overflows available buffer space. (Bug#8545)
3512
f76dee0c
PE
35132011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3516 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3517
fdc5744d
JB
35182011-04-28 Juanma Barranquero <lekktu@gmail.com>
3519
3520 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3521
638f053a
JB
35222011-04-28 Juanma Barranquero <lekktu@gmail.com>
3523
3524 * keyboard.c (Qdelayed_warnings_hook): Define.
3525 (command_loop_1): Run `delayed-warnings-hook'
3526 if Vdelayed_warnings_list is non-nil.
3527 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3528 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3529
d178f871
EZ
35302011-04-28 Eli Zaretskii <eliz@gnu.org>
3531
3532 * doprnt.c (doprnt): Don't return value smaller than the buffer
3533 size if the message was truncated. (Bug#8545).
3534
b124fd93
JB
35352011-04-28 Juanma Barranquero <lekktu@gmail.com>
3536
3537 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3538 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3539
e810457d
PE
35402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3541
3542 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3543
ea51cceb
JB
35442011-04-27 Juanma Barranquero <lekktu@gmail.com>
3545
3546 * makefile.w32-in: Update dependencies.
3547
94dcfacf
EZ
35482011-04-27 Eli Zaretskii <eliz@gnu.org>
3549
3550 Improve `doprnt' and its usage. (Bug#8545)
3551 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3552 `format_end'. Remove support for %l as a conversion specifier.
3553 Don't use xrealloc. Improve diagnostics when the %l size modifier
3554 is used. Update the commentary.
3555
3556 * eval.c (verror): Simplify calculation of size_t.
3557
3558 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3559 messages.
3560
f61f41d7
PE
35612011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3562
3563 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3564 change.
3565
96fb4434
PE
35662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3567
3568 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3569 This makes this file independent of the recent pseudovector change.
3570
671875da 35712011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3572
69e9b5a3
PE
3573 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3574
b5f869a7 3575 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3576 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3577 Remove unused local.
c8926152 3578 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3579
841a1577 3580 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3581 GCC 4.6.0 optimizes based on type-based alias analysis.
3582 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3583 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3584 != &v->size, and therefore "v->size = 1; b->size = 2; return
3585 v->size;" must therefore return 1. This assumption is incorrect
3586 for Emacs, since it type-puns struct Lisp_Vector * with many other
3587 types. To fix this problem, this patch adds a new type struct
f904488f 3588 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3589 and pseudovectors, and helps optimizing compilers not get fooled
3590 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3591 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3592 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3593 the size member.
eab3844f
PE
3594 (XSETPVECTYPE): Rewrite in terms of new macro.
3595 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3596 This is a bit clearer, and further avoids the possibility of
3597 undesirable aliasing.
3598 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3599 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3600 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3601 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3602 (ASIZE): Now uses header.size rather than size.
3603 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3604 to avoid the hassle of writing XVECTOR (foo)->header.size.
3605 (struct vectorlike_header): New type.
eab3844f
PE
3606 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3607 object, to help avoid aliasing.
3608 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3609 (SUBRP): Likewise, since Lisp_Subr is a special case.
3610 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3611 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3612 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3613 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3614 changed to be "header.size" and "header.next".
3615 * buffer.h (struct buffer): Likewise.
3616 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3617 * frame.h (struct frame): Likewise.
3618 * process.h (struct Lisp_Process): Likewise.
3619 * termhooks.h (struct terminal): Likewise.
3620 * window.c (struct save_window_data, struct saved_window): Likewise.
3621 * window.h (struct window): Likewise.
3622 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3623 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3624 * buffer.c (init_buffer_once): Likewise.
3625 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3626 special case.
3627 * process.c (Fformat_network_address): Use local var for size,
3628 for brevity.
3629
0df1eac5
PE
3630 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3631
847ab9d1 3632 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3633 * data.c (atof): Remove decl; no longer used or needed.
3634 (digit_to_number): Move to lread.c.
3635 (Fstring_to_number): Use new string_to_number function, to be
3636 consistent with how the Lisp reader treats infinities and NaNs.
3637 Do not assume that floating-point numbers represent EMACS_INT
3638 without losing information; this is not true on most 64-bit hosts.
3639 Avoid double-rounding errors, by insisting on integers when
3640 parsing non-base-10 numbers, as the documentation specifies.
3641 * lisp.h (string_to_number): New decl, replacing ...
3642 (isfloat_string): Remove.
bc0a5c13 3643 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3644 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3645 appears to have been a coding error. Similarly, do not accept
3646 strings like +-1e0 as floating point numbers. Do not report
3647 overflow for integer overflows unless the base is not 10 which
3648 means we have no simple and reliable way to continue.
3649 Break out the floating-point parsing into a new
3650 function string_to_number, so that Fstring_to_number parses
3651 floating point numbers consistently with the Lisp reader.
04f2d78b 3652 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3653 (E_CHAR, EXP_INT): Remove, replacing with ...
3654 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3655 (string_to_number): New function, replacing isfloat_string.
3656 This function checks for valid syntax and produces the resulting
3657 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3658 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3659 so that overflow for non-base-10 numbers is reported only when
3660 there's no portable and simple way to convert to floating point.
452f4150 3661
67769ffc
PE
3662 * textprop.c (set_text_properties_1): Rewrite for clarity,
3663 and to avoid GCC warning about integer overflow.
3664
c20db43f
PE
3665 * intervals.h (struct interval): Use EMACS_INT for members
3666 where EMACS_UINT might cause problems. See
3667 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3668 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3669 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3670 All uses changed.
37aa2f85
PE
3671 (offset_intervals): Tell GCC not to worry about length overflow
3672 when negating a negative length.
c20db43f 3673
2538aa2f
PE
3674 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3675 (overrun_check_free): Likewise.
3676
f2d3008d
PE
3677 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3678 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3679 word size.
3680
ec8df744
PE
3681 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3682 (gnutls_make_error): Rename local to avoid shadowing.
3683 (gnutls_emacs_global_deinit): ifdef out; not used.
3684 (Fgnutls_boot): Use const for pointer to readonly storage.
3685 Comment out unused local. Fix pointer signedness problems.
3686
640ee02d
PE
3687 * lread.c (openp): Don't stuff size_t into an 'int'.
3688 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3689 about possible signed overflow.
3690
6048fb2a
PE
3691 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3692 (GDK_KEY_g): Don't define if already defined.
3693 (xg_prepare_tooltip): Avoid pointer signedness problem.
3694 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3695
fa3c87e1
PE
3696 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3697 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3698
2172544b
PE
3699 * xfns.c (Fx_window_property): Simplify a bit,
3700 to make a bit faster and to avoid GCC 4.6.0 warning.
3701 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3702
9b821a21
PE
3703 * fns.c (internal_equal): Don't assume size_t fits in int.
3704
3c616cfa
PE
3705 * alloc.c (compact_small_strings): Tighten assertion a little.
3706
c2982e87
PE
3707 Replace pEd with more-general pI, and fix some printf arg casts.
3708 * lisp.h (pI): New macro, generalizing old pEd macro to other
3709 conversion specifiers. For example, use "...%"pI"d..." rather
3710 than "...%"pEd"...".
3711 (pEd): Remove. All uses replaced with similar uses of pI.
3712 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3713 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3714 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3715 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3716 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3717 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3718 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3719 64-bit hosts.
3720 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3721 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3722 * print.c (safe_debug_print, print_object): Likewise.
3723 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3724 to int.
6f04d126
PE
3725 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3726 avoiding the 0 flag, which is not portable.
c2982e87
PE
3727 * process.c (Fmake_network_process): Use pI to avoid cast.
3728 * region-cache.c (pp_cache): Likewise.
3729 * xdisp.c (decode_mode_spec): Likewise.
3730 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3731 behavior on 64-bit hosts with printf arg.
6f04d126 3732 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3733 (x_stop_queuing_selection_requests): Likewise.
3734 (x_get_window_property): Don't truncate byte count to an 'int'
3735 when tracing.
0b432f21 3736
5e073ec7
PE
3737 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3738 here, since it parses constructs like leading '-' and spaces,
3739 which are not wanted; and it overflows with large numbers.
3740 Instead, simply match F[0-9]+, which is what is wanted anyway.
3741
36372bf9
PE
3742 * alloc.c: Remove unportable assumptions about struct layout.
3743 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3744 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3745 (allocate_vectorlike, make_pure_vector): Use the new macros,
3746 plus offsetof, to remove unportable assumptions about struct layout.
3747 These assumptions hold on all porting targets that I know of, but
3748 they are not guaranteed, they're easy to remove, and removing them
3749 makes further changes easier.
3750
0b432f21
PE
3751 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3752 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3753 (string_overrun_cookie): Now const. Use initializers that
3754 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3755 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3756 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3757 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3758 multiple of sizeof (EMACS_INT); it need not be, if
3759 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3760 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3761
895009e1
JB
37622011-04-26 Juanma Barranquero <lekktu@gmail.com>
3763
3764 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3765
6a7a1b0b
TZ
37662011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3767
3768 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3769 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3770 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3771
841a1577 37722011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3773
3774 * lisp.h (Qdebug): List symbol.
895009e1 3775 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3776 * keyboard.c (debug-on-event): New variable.
3777 (handle_user_signal): Break into debugger when debug-on-event
3778 matches the current signal symbol.
3779
f2d3ba6f
DN
37802011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3781
3782 * alloc.c (check_sblock, check_string_bytes)
3783 (check_string_free_list): Convert to standard C.
3784
42ce4c63
TZ
37852011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3786
3787 * w32.c (emacs_gnutls_push): Fix typo.
3788
825cd63c
EZ
37892011-04-25 Eli Zaretskii <eliz@gnu.org>
3790
fb11d64d
EZ
3791 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3792 "cast to pointer from integer of different size".
3793
825cd63c
EZ
3794 Improve doprnt and its use in verror. (Bug#8545)
3795 * doprnt.c (doprnt): Document the set of format control sequences
3796 supported by the function. Use SAFE_ALLOCA instead of always
3797 using `alloca'.
3798
3799 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3800 is one byte too soon. Don't use xrealloc; instead xfree and
3801 xmalloc anew.
3802
e061a11b
TZ
38032011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3804
3805 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3806 callbacks stage.
3807
3808 * gnutls.c: Renamed global_initialized to
3809 gnutls_global_initialized. Added internals for the
3810 :verify-hostname-error, :verify-error, and :verify-flags
3811 parameters of `gnutls-boot' and documented those parameters in the
3812 docstring. Start callback support.
9173deec
JB
3813 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3814 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3815 on error. Return error code.
e061a11b
TZ
3816 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3817 (emacs_gnutls_read): Likewise.
3818 (Fgnutls_boot): Return handshake error code.
3819 (emacs_gnutls_handle_error): New function.
3820 (wsaerror_to_errno): Likewise.
3821
3822 * w32.h (emacs_gnutls_pull): Add prototype.
3823 (emacs_gnutls_push): Likewise.
3824
3825 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3826 (emacs_gnutls_push): Likewise.
3827
38282011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3829
3830 * process.c (wait_reading_process_output): Check if GnuTLS
3831 buffered some data internally if no FDs are set for TLS
3832 connections.
3833
3834 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3835 (LIBS): Link to USER_LIBS.
3836 ($(BLD)/gnutls.$(0)): New target.
3837
fa6996bc
EZ
38382011-04-24 Eli Zaretskii <eliz@gnu.org>
3839
eb35682e
EZ
3840 * xdisp.c (handle_single_display_spec): Rename the
3841 display_replaced_before_p argument into display_replaced_p, to
3842 make it consistent with the commentary. Fix typos in the
3843 commentary.
3844
e2ad650c
EZ
3845 * textprop.c (syms_of_textprop): Remove dead code.
3846 (copy_text_properties): Delete obsolete commentary about an
3847 interface that was deleted long ago. Fix typos in the description
3848 of arguments.
3849
1b2de274
EZ
3850 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3851 to changes in oldXMenu/XMenu.h from 2011-04-16.
3852 <menu_help_message, prev_menu_help_message>: Constify.
3853 (IT_menu_make_room): menu->help_text is now `const char **';
3854 adjust.
3855
3856 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3857 to changes in oldXMenu/XMenu.h from 2011-04-16.
3858 (struct XMenu): Declare `help_text' `const char **'.
3859
3860 * xfaces.c <Qunspecified>: Make extern again.
3861
3862 * syntax.c: Include sys/types.h before including regex.h, as
3863 required by Posix.
3864
762b15be
EZ
3865 * doc.c (get_doc_string): Improve the format passed to `error'.
3866
3867 * doprnt.c (doprnt): Improve commentary.
3868
3869 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3870
3871 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3872 them with etags.
3873
f1052e5d
EZ
3874 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3875 changes in globals.h immediately force recompilation.
762b15be
EZ
3876 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3877 $(CURDIR)/s/ms-w32.h.
3878 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3879
fa6996bc
EZ
3880 * character.c (Fchar_direction): Function deleted.
3881 (syms_of_character): Don't defsubr it.
3882 <char-direction-table>: Deleted.
3883
e6c3da20
EZ
38842011-04-23 Eli Zaretskii <eliz@gnu.org>
3885
3886 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3887 * doprnt.c: Include limits.h.
3888 (SIZE_MAX): New macro.
04f2d78b
CB
3889 (doprnt): Return a size_t value. 2nd arg is now size_t.
3890 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3891 Improve overflow protection. Support `l' modifier for integer
3892 conversions. Support %l conversion. Don't assume an EMACS_INT
3893 argument for integer conversions and for %c.
3894
3895 * lisp.h (doprnt): Restore prototype.
3896
3897 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3898 $(SRC)/character.h.
3899
3900 * Makefile.in (base_obj): Add back doprnt.o.
3901
3902 * deps.mk (doprnt.o): Add back prerequisites.
3903 (callint.o): Depend on character.h.
3904
3905 * eval.c (internal_lisp_condition_case): Include the handler
3906 representation in the error message.
3907 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3908 when breaking from the loop.
3909
3910 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3911
3912 * callint.c (Fcall_interactively): When displaying error message
3913 about invalid control letter, pass the character's codepoint, not
3914 a pointer to its multibyte form. Improve display of the character
3915 in octal and display also its hex code.
3916
3917 * character.c (char_string): Use %x to display the (unsigned)
3918 codepoint of an invalid character, to avoid displaying a bogus
3919 negative value.
3920
3921 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3922 `error', not SYMBOL_NAME itself.
3923
3924 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3925 character arguments to `error'.
3926
3927 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3928 to `error' in error message about FINAL_CHAR argument. Make sure
3929 FINAL_CHAR is a character, and use %c when it is passed as
3930 argument to `error'.
3931
4ffd0d6b 39322011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3933
3934 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3935
3936 * w32.c: Include <time.h>.
3937 (sys_localtime): New function.
3938
4ffd0d6b 39392011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3940
3941 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3942
4ffd0d6b 3943 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3944
4ffd0d6b 39452011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3946
4ffd0d6b
GM
3947 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3948 zombies (Bug#8467).
aac0c6e3 3949
04c56954
EZ
39502011-04-19 Eli Zaretskii <eliz@gnu.org>
3951
3952 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3953 gl_state.e_property when gl_state.object is Qt.
3954
3955 * insdel.c (make_gap_larger): Remove limitation of buffer size
3956 to <= INT_MAX.
3957
16a43933
CY
39582011-04-18 Chong Yidong <cyd@stupidchicken.com>
3959
3960 * xdisp.c (lookup_glyphless_char_display)
3961 (produce_glyphless_glyph): Handle cons cell entry in
3962 glyphless-char-display.
3963 (Vglyphless_char_display): Document it.
3964
3965 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3966 glyphless-char-display.
3967
4581706e
CY
39682011-04-17 Chong Yidong <cyd@stupidchicken.com>
3969
3970 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3971
3972 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3973
3974 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3975 definition for no-X builds.
3976
4887c6e2 39772011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3978
fd35b6f9
PE
3979 Static checks with GCC 4.6.0 and non-default toolkits.
3980
5c1ccb01
PE
3981 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3982
006c5daa
PE
3983 * process.c (keyboard_bit_set): Define only if SIGIO.
3984 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3985 (send_process): Repair possible setjmp clobbering.
3986
efc736d3
PE
3987 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3988
4e2fe2e6
PE
3989 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3990
f97334a2
PE
3991 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3992
4e75f29d
PE
3993 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3994 Define only if needed.
3995
90efadd1
PE
3996 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3997 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3998 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3999
3c647824
PE
4000 * dispextern.h (struct redisplay_interface): Rename param
4001 to avoid shadowing.
e264f262 4002 * termhooks.h (struct terminal): Likewise.
761383f4 4003 * xterm.c (xembed_send_message): Likewise.
3c647824 4004
b58c5c4a
PE
4005 * insdel.c (make_gap_smaller): Define only if
4006 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4007
cad59032
PE
4008 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4009 it.
4010
c339dc2e
PE
4011 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4012 so that we aren't warned about unused symbols.
4013
91a3e27b
PE
4014 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4015
399c71d3 4016 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4017
8ffc96f5
PE
4018 * xfns.c (x_real_positions): Mark locals as initialized.
4019
eef9bc79
PE
4020 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4021
098db9dd
PE
4022 * xterm.c: Fix problems found by static analysis with other toolkits.
4023 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4024 (x_dispatch_event): Declare static if USE_GTK, and
4025 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4026 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4027 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4028 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4029 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4030
eb18f6cc
PE
4031 * xmenu.c (menu_help_callback): Pointer type fixes.
4032 Use const pointers when pointing at readonly data. Avoid pointer
4033 signedness clashes.
4034 (FALSE): Remove unused macro.
4035 (update_frame_menubar): Remove unused decl.
4036
1fe72bf8
PE
4037 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4038
60d9e1db
PE
4039 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4040 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4041 (single_menu_item): Rename local to avoid shadowing.
4042
39261c26
PE
4043 * keyboard.c (make_lispy_event): Remove unused local var.
4044
018c5e19
PE
4045 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4046 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4047
63d2b86e
PE
4048 * bitmaps: Change bitmaps from unsigned char back to the X11
4049 compatible char. Avoid the old compiler warnings about
4050 out-of-range initializers by using, for example, '\xab' rather
4051 than 0xab.
4052
aefd87e1
PE
4053 * xgselect.c (xgselect_initialize): Check vs interface
4054 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4055
bf501fb9
PE
4056 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4057
e9829fdf
PE
4058 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4059 to read-only memory.
4060
1086c095
PE
4061 * fns.c (vector): Remove; this old hack is no longer needed.
4062
2baccd04 4063 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4064 Remove unused var.
dde42981 4065 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4066
72391843 4067 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4068
436c16df 4069 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4070 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4071 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4072
92bb796d 4073 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4074 (x_term_init): Remove local to avoid shadowing.
92bb796d 4075
764430a3 4076 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4077
4078 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4079 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4080
d1dfb56c
EZ
40812011-04-16 Eli Zaretskii <eliz@gnu.org>
4082
c4354cb4
EZ
4083 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4084
d1dfb56c
EZ
4085 Fix regex.c, syntax.c and friends for buffers > 2GB.
4086 * syntax.h (struct gl_state_s): Declare character position members
4087 EMACS_INT.
4088
4089 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4090
04f2d78b
CB
4091 * textprop.c (verify_interval_modification, interval_of):
4092 Declare arguments EMACS_INT.
d1dfb56c
EZ
4093
4094 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4095 EMACS_INT.
4096
4097 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4098
4099 * indent.c (Fvertical_motion): Local variable it_start is now
4100 EMACS_INT.
4101
4102 * regex.c (re_match, re_match_2, re_match_2_internal)
4103 (bcmp_translate, regcomp, regexec, print_double_string)
4104 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4105 (re_compile_pattern, re_exec): Declare arguments and local
4106 variables `size_t' and `ssize_t' and return values `regoff_t', as
4107 appropriate.
4108 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4109 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4110 <compile_stack_type>: `size' and `avail' are now `size_t'.
4111
4112 * regex.h <regoff_t>: Use ssize_t, not int.
4113 (re_search, re_search_2, re_match, re_match_2): Arguments that
4114 specify buffer/string position and length are now ssize_t and
4115 size_t. Return type is regoff_t.
4116
613052cd
BK
41172011-04-16 Ben Key <bkey76@gmail.com>
4118
4119 * nsfont.m: Fixed bugs in ns_get_family and
4120 ns_descriptor_to_entity that were caused by using free to
4121 deallocate memory blocks that were allocated by xmalloc (via
4122 xstrdup). This caused Emacs to crash when compiled with
4123 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4124 --enable-checking=xmallocoverrun). xfree is now used to
4125 deallocate these memory blocks.
4126
4170f62f 41272011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4128
71b41406
PE
4129 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4130
9587a89d
PE
4131 emacs_write: Accept and return EMACS_INT for sizes.
4132 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4133 et seq.
4134 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4135 Accept and return EMACS_INT.
4136 (emacs_gnutls_write): Return the number of bytes written on
4137 partial writes.
4138 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4139 (emacs_read, emacs_write): Remove check for negative size, as the
4140 Emacs source code has been audited now.
9587a89d
PE
4141 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4142 (emacs_read, emacs_write): Use it.
273a5f82
PE
4143 * process.c (send_process): Adjust to the new signatures of
4144 emacs_write and emacs_gnutls_write. Do not attempt to store
4145 a byte offset into an 'int'; it might overflow.
9587a89d 4146 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4147
3e047f51
PE
4148 * sound.c: Don't assume sizes fit in 'int'.
4149 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4150 Return EMACS_INT, not int.
3e047f51 4151 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4152 Accept EMACS_INT, not int.
4153 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4154 record read return values.
4155
cc39a9db
BK
41562011-04-15 Ben Key <bkey76@gmail.com>
4157
c9d0ec6d
JB
4158 * keyboard.c (Qundefined): Don't declare static since it is used
4159 in nsfns.m.
4160 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4161 static since they are used in nsfont.m.
cc39a9db 4162
6c60eb9f
SM
41632011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4164
4165 * process.c (Qprocessp): Don't declare static.
4166 * lisp.h (Qprocessp): Declare again.
4167
7990b61a
JB
41682011-04-15 Juanma Barranquero <lekktu@gmail.com>
4169
4170 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4171
5d4cb038
PE
41722011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4173
8bd7b830 4174 Improve C-level modularity by making more things 'static'.
cd64ea1d 4175
e3b27b31
PE
4176 Don't publish debugger-only interfaces to other modules.
4177 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4178 (verify_bytepos, count_markers): Move decls to the only modules
4179 that need them.
4180 * region-cache.h (pp_cache): Likewise.
4181 * window.h (check_all_windows): Likewise.
4182 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4183
5d4cb038
PE
4184 * sysdep.c (croak): Now static, if
4185 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4186 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4187
4188 * alloc.c (refill_memory_reserve): Now static if
4189 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4190 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4191
e87b6180
PE
4192 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4193 Define only if USE_LUCID.
4194
ac64929e
PE
4195 * xrdb.c (x_customization_string, x_rm_string): Now static.
4196
6f37259d
PE
4197 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4198 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4199
1683e3ab
PE
4200 * xdisp.c (draw_row_with_mouse_face): Now static.
4201 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4202
de9c2632
PE
4203 * window.h (check_all_windows): Mark externally visible.
4204
2b96acb7
PE
4205 * window.c (window_deletion_count): Now static.
4206
4207 * undo.c: Make symbols static if they're not exported.
4208 (last_undo_buffer, last_boundary_position, pending_boundary):
4209 Now static.
4210
50436f33
PE
4211 * textprop.c (interval_insert_behind_hooks): Now static.
4212 (interval_insert_in_front_hooks): Likewise.
4213
64520e5c
PE
4214 * term.c: Make symbols static if they're not exported.
4215 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4216 (max_frame_lines, tty_set_terminal_modes):
4217 (tty_reset_terminal_modes, tty_turn_off_highlight):
4218 (get_tty_terminal): Now static.
4219 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4220 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4221 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4222 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4223 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4224
1fa53021
PE
4225 * sysdep.c: Make symbols static if they're not exported.
4226 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4227 Now static.
4228 (sigprocmask_set, full_mask): Remove; unused.
4229 (wait_debugging): Mark as visible.
4230 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4231 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4232
d4b43b22
PE
4233 * syntax.c (syntax_temp): Define only if !__GNUC__.
4234
b7c513d0
PE
4235 * sound.c (current_sound_device, current_sound): Now static.
4236
989b29ad
PE
4237 * search.c (searchbufs, searchbuf_head): Now static.
4238
13a55a78
PE
4239 * scroll.c (scroll_cost): Remove; unused.
4240 * dispextern.h (scroll_cost): Remove decl.
4241
de68a1fc
PE
4242 * region-cache.h (pp_cache): Mark as externally visible.
4243
40ccffa6
PE
4244 * process.c: Make symbols static if they're not exported.
4245 (process_tick, update_tick, create_process, chan_process):
4246 (Vprocess_alist, proc_buffered_char, datagram_access):
4247 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4248 (deactivate_process): Mark defn as static, as well as decl.
4249 * lisp.h (create_process): Remove decl.
4250 * process.h (chan_process, Vprocess_alist): Remove decls.
4251
ad64fc97
PE
4252 * print.c: Make symbols static if they're not exported.
4253 (print_depth, new_backquote_output, being_printed, print_buffer):
4254 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4255 (print_interval, print_number_index, initial_stderr_stream):
4256 Now static.
4257 * lisp.h (Fprinc): Remove decl.
4258 (debug_output_compilation_hack): Mark as externally visible.
4259
adddb265
PE
4260 * sysdep.c (croak): Move decl from here to syssignal.h.
4261 * syssignal.h (croak): Put it here, so the API can be checked when
4262 'croak' is called from dissociate_if_controlling_tty.
4263
1717ede2
PE
4264 * minibuf.c: Make symbols static if they're not exported.
4265 (minibuf_save_list, choose_minibuf_frame): Now static.
4266 * lisp.h (choose_minibuf_frame): Remove decl.
4267
fa5fb2bc
PE
4268 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4269
1e3890d1
PE
4270 * lread.c: Make symbols static if they're not exported.
4271 (read_objects, initial_obarray, oblookup_last_bucket_number):
4272 Now static.
4273 (make_symbol): Remove; unused.
4274 * lisp.h (initial_obarray, make_symbol): Remove decls.
4275
8a1414fa
PE
4276 * keyboard.c: Make symbols static if they're not exported.
4277 (single_kboard, recent_keys_index, total_keys, recent_keys):
4278 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4279 (this_single_command_key_start, echoing, last_auto_save):
4280 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4281 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4282 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4283 (Vlispy_mouse_stem, double_click_count):
4284 Now static.
4285 (force_auto_save_soon): Define only if SIGDANGER.
4286 (ignore_mouse_drag_p): Now static if
4287 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4288 (print_help): Remove; unused.
4289 (stop_character, last_timer_event): Mark as externally visible.
4290 * keyboard.h (ignore_mouse_drag_p): Declare only if
4291 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4292 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4293 * lisp.h (echoing): Remove decl.
4294 (force_auto_save_soon): Declare only if SIGDANGER.
4295 * xdisp.c (redisplay_window): Simplify code, to make it more
4296 obvious that ignore_mouse_drag_p is not accessed if !defined
4297 USE_GTK && !defined HAVE_NS.
4298
93ea6e8f
PE
4299 * intervals.c: Make symbols static if they're not exported.
4300 (merge_properties_sticky, merge_interval_right, delete_interval):
4301 Now static.
4302 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4303
77382fcc
PE
4304 * insdel.c: Make symbols static if they're not exported.
4305 However, leave prepare_to_modify_buffer alone. It's never
4306 called from outside this function, but that appears to be a bug.
4307 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4308 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4309 (adjust_after_replace_noundo): Remove; unused.
4310 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4311 (signal_before_change): Remove decls.
77382fcc 4312
9306c32e
PE
4313 * indent.c (val_compute_motion, val_vmotion): Now static.
4314
cd44d2eb
PE
4315 * image.c: Make symbols static if they're not exported.
4316 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4317 if USE_GTK.
4318 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4319 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4320
ad9a7a06
PE
4321 * fringe.c (standard_bitmaps): Now static.
4322 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4323
81626931
PE
4324 * frame.c: Make symbols static if they're not exported.
4325 (x_report_frame_params, make_terminal_frame): Now static.
4326 (get_frame_param): Now static, unless HAVE_NS.
4327 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4328 (x_get_resource_string): Remove; not used.
4329 * frame.h (make_terminal_frame, x_report_frame_params):
4330 (x_get_resource_string); Remove decls.
4331 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4332 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4333
239f9db9
PE
4334 * font.c, fontset.c: Make symbols static if they're not exported.
4335 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4336 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4337 * font.c (font_close_object): Now static.
4338 * font.h (font_close_object): Remove.
4339 * fontset.c (FONTSET_OBJLIST): Remove.
4340 (free_realized_fontset) #if-0 the body, which does nothing.
4341 (face_suitable_for_char_p): #if-0, as it's never called.
4342 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4343 * xfaces.c (face_at_string_position):
4344 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4345 since 0 is always ASCII.
4346
dfcf3579
PE
4347 * fns.c (weak_hash_tables): Now static.
4348
5045092b
PE
4349 * fileio.c: Make symbols static if they're not exported.
4350 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4351 (Vwrite_region_annotation_buffers): Now static.
4352
57a96f5c
PE
4353 * eval.c: Make symbols static if they're not exported.
4354 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4355 * lisp.h (backtrace_list): Remove decl.
4356
35f08c38
PE
4357 * emacs.c: Make symbols static if they're not exported.
4358 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4359 (fatal_error_code, fatal_error_signal_hook, standard_args):
4360 Now static.
4361 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4362 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4363 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4364 * lisp.h (fatal_error_signal_hook): Remove decl.
4365 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4366
f44bd759
PE
4367 * editfns.c: Move a (normally-unused) function to its only use.
4368 * editfns.c, lisp.h (get_operating_system_release): Remove.
4369 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4370 worth the hassle of breaking this out.
4371
b532497d
PE
4372 * xterm.c: Make symbols static if they're not exported.
4373 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4374 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4375 (x_destroy_window, x_delete_display):
4376 Now static.
4377 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4378 (x_mouse_leave): Remove; unused.
4379 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4380 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4381 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4382 Remove decls.
4383 (x_mouse_leave): Declare only if WINDOWSNT.
4384 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4385 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4386 USE_X_TOOLKIT.
4387
1675728f
PE
4388 * ftxfont.c: Make symbols static if they're not exported.
4389 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4390 HAVE_FREETYPE.
4391 * font.h (ftxfont_driver): Likewise.
4392
e4cebfca
PE
4393 * xfns.c: Make symbols static if they're not exported.
4394 (x_last_font_name, x_display_info_for_name):
4395 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4396 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4397 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4398 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4399 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4400 (last_show_tip_args): Now static.
4401 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4402 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4403 (x_screen_planes): Remove; unused.
4404 * dispextern.h (x_screen_planes): Remove decl.
4405
5bf46f05
PE
4406 * dispnew.c: Make symbols static if they're not exported.
4407 * dispextern.h (redraw_garbaged_frames, scrolling):
4408 (increment_row_positions): Remove.
4409 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4410 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4411 Now static.
4412 (redraw_garbaged_frames): Remove; unused.
4413
435f4c28
PE
4414 * xfaces.c: Make symbols static if they're not exported.
4415 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4416 Remove decls.
4417 * xterm.h (defined_color): Remove decls.
4418 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4419 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4420 (menu_face_changed_default, defined_color, free_realized_face):
4421 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4422 (ascii_face_of_lisp_face): Remove; unused.
4423
8524aef3
PE
4424 * xdisp.c: Make symbols static if they're not exported.
4425 * dispextern.h (scratch_glyph_row, window_box_edges):
4426 (glyph_to_pixel_coords, set_cursor_from_row):
4427 (get_next_display_element, set_iterator_to_next):
4428 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4429 (show_mouse_face): Remove decls
4430 * frame.h (message_buf_print): Likewise.
4431 * lisp.h (pop_message, set_message, check_point_in_composition):
4432 Likewise.
4433 * xterm.h (set_vertical_scroll_bar): Likewise.
4434 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4435 (message_buf_print, scratch_glyph_row, displayed_buffer):
4436 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4437 (get_next_display_element, show_mouse_face, window_box_edges):
4438 (frame_to_window_pixel_xy, check_point_in_composition):
4439 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4440 (glyph_to_pixel_coords): Remove; unused.
4441
16390cd2
PE
4442 * dired.c (file_name_completion): Now static.
4443
4444 * dbusbind.c (xd_in_read_queued_messages): Now static.
4445
a25f4dfa
PE
4446 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4447 * data.c (circular_list_error): Remove.
4448
14a9c8df
PE
4449 * commands.h (last_point_position, last_point_position_buffer):
4450 (last_point_position_window): Remove decls.
4451 * keyboard.c: Make these variables static.
4452
04f2d78b
CB
4453 * coding.h (coding, code_convert_region, encode_coding_gap):
4454 Remove decls.
74ab6df5
PE
4455 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4456 (iso_code_class, detect_coding, code_convert_region): Now static.
4457 (encode_coding_gap): Remove; unused.
4458
38dfbee1
PE
4459 * chartab.c (chartab_chars, chartab_bits): Now static.
4460
a2cb4e63
PE
4461 * charset.h (charset_iso_8859_1): Remove decl.
4462 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4463 Now static.
4464
127198fd
PE
4465 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4466 * ccl.c (Vccl_program_table): Now static.
4467 (check_ccl_update): Remove; unused.
4468
d85b608f
PE
4469 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4470 * category.h: ... from here.
4471 * category.c (check_category_table, set_category_set): Now static.
4472
31cd66f3
PE
4473 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4474 * lisp.h: Remove these decls.
4475
c358e587
PE
4476 * buffer.c (buffer_count): Remove unused var.
4477
e78aecca
PE
4478 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4479 so that it's not optimized away.
4480 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4481 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4482 exported only to the debugger.
4483
e192d7d3 4484 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4485 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4486
92470028
PE
4487 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4488 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4489 was inaccessible from Lisp.
4490 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4491 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4492
244ed907
PE
4493 alloc.c: Import and export fewer symbols, and remove unused items.
4494 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4495 is defined.
4496 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4497 it's not optimized away by whole-program optimization.
4498 (message_enable_multibyte, free_misc): Remove.
4499 (catchlist, handlerlist, mark_backtrace):
4500 Declare only if BYTE_MARK_STACK.
4501 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4502 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4503 (message_enable_multibyte): Remove decl.
4504 (free_misc, interval_free_list, float_block, float_block_index):
4505 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4506 (cons_free_list, last_marked_index):
4507 Now static.
4508 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4509 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4510 (mark_backtrace): Define only if BYTE_MARK_STACK.
4511 * xdisp.c (message_enable_multibyte): Now static.
4512
61c2b50e 4513 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4514 This makes it easier for human readers (and static analyzers)
4515 to see whether these variables are used from other modules.
4516 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4517 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4518 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4519 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4520 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4521 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4522 * xmenu.c, xselect.c:
4523 Declare Q* vars static if they are not used in other modules.
4524 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4525 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4526 Remove decls of unexported vars.
4527 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4528
95c82688
PE
4529 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4530
16a97296
PE
4531 Make Emacs functions such as Fatom 'static' by default.
4532 This makes it easier for human readers (and static analyzers)
4533 to see whether these functions can be called from other modules.
4534 DEFUN now defines a static function. To make the function external
4535 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4536 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4537 (Finit_image_library):
16a97296
PE
4538 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4539 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4540 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4541 Remove decls, since these functions are now static.
4542 (Funintern, Fget_internal_run_time): New decls, since these functions
4543 were already external.
95c82688 4544
16a97296
PE
4545 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4546 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4547 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4548 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4549 * keyboard.c, keymap.c, lread.c:
4550 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4551 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4552 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4553 Mark functions with DEFUE instead of DEFUN,
4554 if they are used in other modules.
4555 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4556 decls for now-static functions.
4557 * buffer.h (Fdelete_overlay): Remove decl.
4558 * callproc.c (Fgetenv_internal): Mark as internal.
4559 * composite.c (Fremove_list_of_text_properties): Remove decl.
4560 (Fcomposition_get_gstring): New forward static decl.
4561 * composite.h (Fcomposite_get_gstring): Remove decl.
4562 * dired.c (Ffile_attributes): New forward static decl.
4563 * doc.c (Fdocumntation_property): New forward static decl.
4564 * eval.c (Ffetch_bytecode): New forward static decl.
4565 (Funintern): Remove extern decl; now in .h file where it belongs.
4566 * fileio.c (Fmake_symbolic_link): New forward static decl.
4567 * image.c (Finit_image_library): New forward static decl.
4568 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4569 * intervals.h (Fprevious_property_change):
4570 (Fremove_list_of_text_properties): Remove decls.
4571 * keyboard.c (Fthis_command_keys): Remove decl.
4572 (Fcommand_execute): New forward static decl.
4573 * keymap.c (Flookup_key): New forward static decl.
4574 (Fcopy_keymap): Now static.
4575 * keymap.h (Flookup_key): Remove decl.
4576 * process.c (Fget_process): New forward static decl.
4577 (Fprocess_datagram_address): Mark as internal.
4578 * syntax.c (Fsyntax_table_p): New forward static decl.
4579 (skip_chars): Remove duplicate decl.
4580 * textprop.c (Fprevious_property_change): New forward static decl.
4581 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4582 Now internal.
4583 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4584 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4585
785bbd42
PE
4586 * editfns.c (Fformat): Remove unreachable code.
4587
8b913b57
AS
45882011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4589
4590 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4591 change. (Bug#8496)
4592
a6744a35
EZ
45932011-04-13 Eli Zaretskii <eliz@gnu.org>
4594
4595 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4596 when at ZV. (Bug#8487)
4597
e7974947
AS
45982011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4599
baad03f0
AS
4600 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4601 (Bug#8437)
4602 * keyboard.c (parse_tool_bar_item): Likewise.
4603 * sound.c (sound_cleanup, alsa_close): Likewise.
4604 * termcap.c (tgetent): Likewise.
4605 * xfns.c (x_default_font_parameter): Likewise.
4606 * xsettings.c (read_and_apply_settings): Likewise.
4607
e7974947
AS
4608 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4609 (overrun_check_free): Protoize.
4610
28272684
PE
46112011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4612
4613 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4614 since callers should never pass a negative size.
4615 Change the signature to match that of plain 'read' and 'write'; see
4616 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4617 * lisp.h: Update prototypes of emacs_write and emacs_read.
4618
11997c76
EZ
46192011-04-11 Eli Zaretskii <eliz@gnu.org>
4620
4621 * xdisp.c (redisplay_window): Don't try to determine the character
4622 position of the scroll margin if the window start point w->startp
e896f03c 4623 is outside the buffer's accessible region. (Bug#8468)
11997c76 4624
8a2cbd72
EZ
46252011-04-10 Eli Zaretskii <eliz@gnu.org>
4626
4627 Fix write-region and its subroutines for buffers > 2GB.
4628 * fileio.c (a_write, e_write): Modify declaration of arguments and
4629 local variables to support buffers larger than 2GB.
4630 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4631
4632 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4633 argument, local variables, and return value.
4634
4635 * lisp.h: Update prototypes of emacs_write and emacs_read.
4636
4637 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4638
4073e537 46392011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4640
1ebfdcb6
PE
4641 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4642
b2ded58d
PE
4643 Fix more problems found by GCC 4.6.0's static checks.
4644
7d66342c
PE
4645 * xdisp.c (vmessage): Use a better test for character truncation.
4646
bbf47d44
PE
4647 * charset.c (load_charset_map): <, not <=, for optimization,
4648 and to avoid potential problems with integer overflow.
9248994d 4649 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4650 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4651 * editfns.c (Fformat): Likewise.
1e69125e 4652 * syntax.c (skip_chars): Likewise.
3befa583 4653
e3019616
PE
4654 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4655 This also lets GCC 4.6.0 generate slightly better loop code.
4656
becfa255
PE
4657 * callint.c (Fcall_interactively): <, not <=, for optimization.
4658 (Fcall_interactively): Count the number of arguments produced,
4659 not the number of arguments given. This is simpler and lets GCC
4660 4.6.0 generate slightly better code.
4661
dae0cd48
PE
4662 * ftfont.c: Distingish more carefully between FcChar8 and char.
4663 The previous code passed unsigned char * to a functions like
4664 strlen and xstrcasecmp that expect char *, which does not
4665 conform to the C standard.
4666 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4667 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4668 char * when the C standard requires it.
4669
76032d70
PE
4670 * keyboard.c (read_char): Remove unused var.
4671
eb3f1cc8
PE
4672 * eval.c: Port to Windows vsnprintf (Bug#8435).
4673 Include <limits.h>.
4674 (SIZE_MAX): Define if the headers do not.
4675 (verror): Do not give up if vsnprintf returns a negative count.
4676 Instead, grow the buffer. This ports to Windows vsnprintf, which
4677 does not conform to C99. Problem reported by Eli Zaretskii.
4678 Also, simplify the allocation scheme, by avoiding the need for
4679 calling realloc, and removing the ALLOCATED variable.
4680
70476b54
PE
4681 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4682
12020a9e
PE
4683 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4684 But keep the doprint source code for now, as we might revamp it
4685 and use it again (Bug#8435).
ea6c7ae6
PE
4686 * lisp.h (doprnt): Remove.
4687 * Makefile.in (base_obj): Remove doprnt.o.
4688 * deps.mk (doprnt.o): Remove.
4689
5fdb398c
PE
4690 error: Print 32- and 64-bit integers portably (Bug#8435).
4691 Without this change, on typical 64-bit hosts error ("...%d...", N)
4692 was used to print both 32- and 64-bit integers N, which relied on
4693 undefined behavior.
4694 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4695 New macro.
4696 * lisp.h (error, verror): Mark as printf-like functions.
4697 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4698 Report overflow in size calculations when allocating printf buffer.
4699 Do not truncate output string at its first null byte.
4700 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4701 Truncate the output at a character boundary, since vsnprintf does not
4702 do that.
4703 * charset.c (check_iso_charset_parameter): Convert internal
4704 character to string before calling 'error', since %c now has the
4705 printf meaning.
4706 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4707 overflow when computing char to be passed to 'error'. Do not
4708 pass Lisp_Object to 'error'; pass the integer instead.
4709 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4710 formatted with plain %d.
4711
b189fa66
PE
4712 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4713
bff87ef0
PE
4714 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4715
7e2cac20
PE
4716 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4717
ce4d90b5
PE
4718 * xterm.c (x_catch_errors): Remove duplicate declaration.
4719
266c9547
PE
4720 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4721
79c49ad2
PE
4722 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4723
368f4090
JM
47242011-04-10 Jim Meyering <meyering@redhat.com>
4725
4726 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4727 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4728 return ssize_t not "int", and use size_t as the buffer length.
4729 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4730 * gnutls.h: Update declarations.
4731 * process.c (read_process_output): Use ssize_t, to match.
4732 (send_process): Likewise.
4733
a32d4040
CY
47342011-04-09 Chong Yidong <cyd@stupidchicken.com>
4735
4736 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4737
8546720e 47382011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4739
04f2d78b
CB
4740 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4741 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4742
8546720e
GM
4743 * xterm.c (handle_one_xevent):
4744 * xmenu.c (create_and_show_popup_menu):
4745 * xselect.c (x_decline_selection_request)
4746 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4747
0a2f5c1a 47482011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4749
4750 Fix some uses of `int' instead of EMACS_INT.
4751 * search.c (string_match_1, fast_string_match)
4752 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4753 (scan_buffer, find_next_newline_no_quit)
4754 (find_before_next_newline, search_command, Freplace_match)
4755 (Fmatch_data): Make some `int' variables be EMACS_INT.
4756
4757 * xdisp.c (display_count_lines): 3rd argument and return value now
4758 EMACS_INT. All callers changed.
4759 (pint2hrstr): Last argument is now EMACS_INT.
4760
4761 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4762 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4763 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4764 (decode_coding_utf_16, decode_coding_emacs_mule)
4765 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4766 (decode_coding_ccl, decode_coding_charset)
4767 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4768 (decode_coding_iso_2022, decode_coding_emacs_mule)
4769 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4770 <char_offset, last_offset>: Declare EMACS_INT.
4771 (encode_coding_utf_8, encode_coding_utf_16)
4772 (encode_coding_emacs_mule, encode_invocation_designation)
4773 (encode_designation_at_bol, encode_coding_iso_2022)
4774 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4775 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4776 Declare EMACS_INT.
4777 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4778 (encode_invocation_designation): Last argument P_NCHARS is now
4779 EMACS_INT.
4780 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4781 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4782
4783 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4784 All users changed.
4785
4786 * ccl.c (Fccl_execute_on_string): Declare some variables
4787 EMACS_INT.
4788
8546720e 47892011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4790
4791 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4792
4e19a977
CS
47932011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4794
4795 * process.c (Fformat_network_address): Doc fix.
4796
87302331
R
47972011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4798
4799 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4800
cbb59342
CY
48012011-04-08 Chong Yidong <cyd@stupidchicken.com>
4802
4803 * keyboard.c (read_char): Call Lisp function help-form-show,
4804 instead of using internal_with_output_to_temp_buffer.
4805 (Qhelp_form_show): New var.
e0d38eeb 4806 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4807
4808 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4809
4810 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4811
e67a13ab
CY
48122011-04-06 Chong Yidong <cyd@stupidchicken.com>
4813
04f2d78b
CB
4814 * process.c (Flist_processes): Remove to Lisp.
4815 (list_processes_1): Delete.
e67a13ab 4816
973f782d
EZ
48172011-04-06 Eli Zaretskii <eliz@gnu.org>
4818
7c106b1e
EZ
4819 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4820
973f782d
EZ
4821 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4822
41cf7d1a 48232011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4824
ca23cc88
PE
4825 Fix more problems found by GCC 4.6.0's static checks.
4826
f390e2d5
PE
4827 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4828
42eea0d0
PE
4829 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4830
b69769da 4831 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4832
f9541e84
PE
4833 * xdisp.c (vmessage): Mark as a printf-like function.
4834
13841b55
PE
4835 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4836
c136c10f
PE
4837 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4838
5e2d4a30
PE
4839 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4840 printf-like functions.
4841 (tiff_load): Add casts to remove these marks before passing them
4842 to system-supplied API.
4843
583f48b9
PE
4844 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4845
b25d760e
PE
4846 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4847 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4848 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4849 directly, rather than having caller test rule sign. This avoids
4850 some unnecessary tests.
4851 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4852 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4853 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4854
bc7b6697 4855 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4856 (xfont_open): Avoid unnecessary tests.
bc7b6697 4857
27ccc379
PE
4858 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4859
dcd5c89a
PE
4860 * composite.h, composite.c (composition_gstring_put_cache):
4861 Use EMACS_INT, not int, for length.
4862
b13a45c6
PE
4863 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4864 breaking out part of COMPOSITION_DECODE_RULE.
4865 (COMPOSITION_DECODE_RULE): Use it.
4866 * composite.c (get_composition_id): Remove unused local vars,
4867 by using the new macro.
4868
1e792e4d
PE
4869 * textprop.c (set_text_properties_1): Change while to do-while,
4870 since the condition is always true at first.
4871
dc6c6455 4872 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4873 (interval_deletion_adjustment): Return unsigned value.
4874 All uses changed.
dc6c6455 4875
aba7731a
PE
4876 * process.c (list_processes_1, create_pty, read_process_output):
4877 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4878 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4879 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4880 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4881 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4882
fdfc4bf3
PE
4883 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4884
fca8fe46 4885 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4886 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4887
06a0259a 4888 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4889 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4890 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4891
e7b9e80f
PE
4892 * print.c (print_error_message): Avoid int overflow.
4893
56201685
PE
4894 * font.c (font_list_entities): Redo for clarity,
4895 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4896
78834453 4897 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4898 (font_score): Avoid potential overflow in diff calculation.
78834453 4899
0bc0b309 4900 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4901 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4902
e610eaca
PE
4903 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4904
b895abce
PE
4905 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4906 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4907 can always succeed if overflow has undefined behavior.
4908
1f1d9321 4909 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4910 (wordify): Omit three unnecessary tests.
1f1d9321 4911
c59478bc
PE
4912 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4913 All callers changed. This avoids the need for an unused var.
4914
79b73827
PE
4915 * casefiddle.c (casify_region): Remove var that is set but not used.
4916
a4db5dfe
PE
4917 * dired.c (file_name_completion): Remove var that is set but not used.
4918
43aae36e
PE
4919 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4920
2a47c44d 4921 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4922 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4923
a37c69bf
PE
4924 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4925 Check for integer overflow on size calculations.
4926
328ab8e7
PE
4927 * buffer.c (Fprevious_overlay_change): Remove var that is set
4928 but not used.
4929
e5a2a5cb
PE
4930 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4931 Remove vars that are set but not used.
8d84a6eb 4932 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4933 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4934
a60e5f68
PE
4935 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4936
f661cb61 4937 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4938 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4939
f0397f5a
PE
4940 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4941 that are set but not used.
4942
8664db06 4943 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4944 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4945
6abdaa4a
PE
4946 * xselect.c (x_get_local_selection, x_handle_property_notify):
4947 Remove vars that are set but not used.
4948
0ce7538d 4949 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4950 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4951
9ae848fc
PE
4952 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4953 Remove var that is set but not used.
0b918413
PE
4954 (scroll_bar_windows_size): Now size_t, not int.
4955 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4956 Check for overflow.
9ae848fc 4957
a5a62657
PE
4958 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4959 (map_tty_color) [!defined MSDOS]: Likewise.
4960
5c5cdd39
PE
4961 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4962
66ebf983
PE
4963 * coding.c: Remove vars that are set but not used.
4964 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4965 All callers changed.
4966 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4967 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4968 (decode_coding_charset): Remove vars that are set but not used.
4969
1be4d761
PE
4970 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4971 that is set but not used.
4972
47553fa8
PE
4973 * print.c (print_object): Remove var that is set but not used.
4974
1f7196bf 4975 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4976 The gnulib version avoids calling malloc in the usual case,
4977 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4978 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4979 * filelock.c (current_lock_owner): Likewise.
4980 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4981 * sysdep.c: Include allocator.h, careadlinkat.h.
4982 (emacs_no_realloc_allocator): New static constant.
4983 (emacs_readlink): New function.
fdb61804
PE
4984 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4985 ../lib/careadlinkat.h.
d1fdcab7 4986
f84c17c7
SM
49872011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4988
4989 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4990 first non-nil return value).
4991
ef3862ad
JD
49922011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4993
4994 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4995 if not defined (Bug#8403).
4996
376a7006
JB
49972011-04-02 Juanma Barranquero <lekktu@gmail.com>
4998
4999 * xdisp.c (display_count_lines): Remove parameter `start',
5000 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5001 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5002 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5003 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5004 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5005 and thereabouts. All callers changed.
5006 (get_per_char_metric): Remove parameter `f', unused since
5007 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5008
6ca3801d
JM
50092011-04-02 Jim Meyering <meyering@redhat.com>
5010
5011 do not dereference NULL upon failed strdup
5012 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5013 (ns_get_family): Likewise.
5014
d8e2b5ba
JB
50152011-04-02 Juanma Barranquero <lekktu@gmail.com>
5016
5017 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5018
8c74fcbd
JD
50192011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5020
5021 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5022 later (Bug#8403).
5023
7200d79c
SM
50242011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5025
03408648 5026 Add lexical binding.
7200d79c 5027
03408648
SM
5028 * window.c (Ftemp_output_buffer_show): New fun.
5029 (Fsave_window_excursion):
5030 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5031
5032 * lread.c (lisp_file_lexically_bound_p): New function.
5033 (Fload): Bind Qlexical_binding.
5034 (readevalloop): Remove `evalfun' arg.
5035 Bind Qinternal_interpreter_environment.
5036 (Feval_buffer): Bind Qlexical_binding.
5037 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5038 Mark as dynamic.
5039 (syms_of_lread): Declare `lexical-binding'.
5040
5041 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5042
5043 * keyboard.c (eval_dyn): New fun.
5044 (menu_item_eval_property): Use it.
ca105506
SM
5045
5046 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5047
03408648
SM
5048 * fns.c (concat, mapcar1): Accept byte-code-functions.
5049
5050 * eval.c (Fsetq): Handle lexical vars.
5051 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5052 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5053 (FletX, Flet): Obey lexical binding.
5054 (Fcommandp): Handle closures.
5055 (Feval): New `lexical' arg.
5056 (eval_sub): New function extracted from Feval. Use it almost
5057 everywhere where Feval was used. Look up vars in lexical env.
5058 Handle closures.
5059 (Ffunctionp): Move from subr.el.
5060 (Ffuncall): Handle closures.
5061 (apply_lambda): Remove `eval_flags'.
5062 (funcall_lambda): Handle closures and new byte-code-functions.
5063 (Fspecial_variable_p): New function.
5064 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5065 but without exporting it to Lisp.
23aba0ea 5066
23aba0ea 5067 * doc.c (Fdocumentation, store_function_docstring):
03408648 5068 * data.c (Finteractive_form): Handle closures.
23aba0ea 5069
03408648
SM
5070 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5071 interactive spec.
ba83908c 5072
04f2d78b
CB
5073 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5074 New byte-codes.
03408648
SM
5075 (exec_byte_code): New function extracted from Fbyte_code to handle new
5076 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5077
03408648 5078 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5079
03408648 5080 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5081
e2abce01
JB
50822011-03-31 Juanma Barranquero <lekktu@gmail.com>
5083
5084 * xdisp.c (redisplay_internal): Fix prototype.
5085
63696a73 50862011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5087
63696a73 5088 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5089 (try_scrolling): Use it when setting scroll_limit.
5090 Limit scrolling to 100 screen lines.
63696a73
EZ
5091 (redisplay_window): Even when falling back on "recentering",
5092 position point in the window according to scroll-conservatively,
5093 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5094
5095 (try_scrolling): When point is above the window, allow searching
5096 as far as scroll_max, or one screenful, to compute vertical
5097 distance from PT to the scroll margin position. This prevents
5098 try_scrolling from unnecessarily failing when
5099 scroll-conservatively is set to a value slightly larger than the
5100 window height. Clean up the case of PT below the margin at bottom
5101 of window: scroll_max can no longer be INT_MAX. When aggressive
5102 scrolling is in use, don't let point enter the opposite scroll
5103 margin as result of the scroll.
5104 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5105 threshold of 100 lines for never-recentering scrolling.
5106
e4cc2dfc
JB
51072011-03-31 Juanma Barranquero <lekktu@gmail.com>
5108
5109 * dispextern.h (move_it_by_lines):
5110 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5111 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5112 (message_log_check_duplicate): Remove parameters `prev_bol' and
5113 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5114 (redisplay_internal): Remove parameter `preserve_echo_area',
5115 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5116
5117 * indent.c (Fvertical_motion):
5118 * window.c (window_scroll_pixel_based, Frecenter):
5119 Don't pass `need_y_p' to `move_it_by_lines'.
5120
1c470562
SM
51212011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5122
44f230aa
SM
5123 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5124 steal a few bits to be more compact.
5125 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5126 Remove unneeded casts.
5127
1c470562
SM
5128 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5129
888adce9
ZK
51302011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5131
5132 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5133 binding" message (bug#7967).
5134
f838ed7b
PE
51352011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5136
77861b95
PE
5137 Fix more problems found by GCC 4.6.0's static checks.
5138
de6dbc14
PE
5139 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5140 Remove unused local var.
5141
f838ed7b
PE
5142 * editfns.c (Fmessage_box): Remove unused local var.
5143
792c7b2b
PE
5144 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5145 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5146 Omit unused local vars.
c499e557 5147 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5148 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5149 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5150 Omit unused local var.
5151
ba0165e1
PE
5152 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5153 Don't assume string length fits in int.
32ad8845 5154 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5155 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5156
3c59b4c9
PE
5157 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5158 instead of alloca (Bug#8344).
5159
a3eed478 5160 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5161 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5162
eb4d412d
PE
5163 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5164
1658b401
PE
5165 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5166 concerns.
5167
5168 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5169
5170 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5171
9a2c6e05
PE
5172 * keyboard.c (syms_of_keyboard): Use the same style as later
5173 in this function when indexing through an array. This also
5174 works around GCC bug 48267.
5175
03d0a109
PE
5176 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5177
44f730c8
PE
5178 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5179
fe75f926
PE
5180 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5181 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5182
ffa8c828
PE
5183 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5184 This avoids undefined behavior on integer overflow, and is a bit
5185 more convenient anyway since it is compared to a size_t variable.
5186
c5101a77
PE
5187 Variadic C functions now count arguments with size_t, not int.
5188 This avoids an unnecessary limitation on 64-bit machines, which
5189 caused (substring ...) to crash on large vectors (Bug#8344).
5190 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5191 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5192 All variadic functions and their callers changed accordingly.
c5101a77
PE
5193 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5194 * data.c (arith_driver, float_arith_driver): Likewise.
5195 * editfns.c (general_insert_function): Likewise.
5196 * eval.c (struct backtrace.nargs, interactive_p)
5197 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5198 (funcall_lambda, mark_backtrace): Likewise.
5199 * fns.c (concat): Likewise.
5200 * frame.c (x_set_frame_parameters): Likewise.
5201 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5202 0 if not found, not -1. All callers changed.
5203
dd3f25f7
PE
5204 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5205 (stack_copy_size): Now size_t, not int.
5206 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5207
461c2ab9
JB
52082011-03-28 Juanma Barranquero <lekktu@gmail.com>
5209
5210 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5211 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5212 All callers changed.
5213
5214 * lisp.h (multibyte_char_to_unibyte):
5215 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5216 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5217 * character.h (CHAR_TO_BYTE8):
5218 * cmds.c (internal_self_insert):
5219 * editfns.c (general_insert_function):
5220 * keymap.c (push_key_description):
5221 * search.c (Freplace_match):
5222 * xdisp.c (message_dolog, set_message_1): All callers changed.
5223
f6d62986
SM
52242011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5225
5226 * keyboard.c (safe_run_hook_funcall): New function.
5227 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5228 don't set the hook to nil, but remove the offending function instead.
5229 (Qcommand_hook_internal): Remove, unused.
5230 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5231 Vcommand_hook_internal.
5232
5233 * eval.c (enum run_hooks_condition): Remove.
5234 (funcall_nil, funcall_not): New functions.
5235 (run_hook_with_args): Call each function through a `funcall' argument.
5236 Remove `cond' argument, now redundant.
5237 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5238 (Frun_hook_with_args_until_failure): Adjust accordingly.
5239 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5240
1db5b1ad
JB
52412011-03-28 Juanma Barranquero <lekktu@gmail.com>
5242
5243 * dispextern.h (string_buffer_position): Remove declaration.
5244
5245 * print.c (strout): Remove parameter `multibyte', unused since
5246 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5247
5248 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5249 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5250 All callers changed.
5251
5252 * w32.c (_wsa_errlist): Use braces for struct initializers.
5253
5254 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5255 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5256 All callers changed.
5257 (string_buffer_position): Likewise. Also, make static (it's never
5258 used outside xdisp.c).
5259 (cursor_row_p): Remove parameter `w', unused since
5260 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5261 (decode_mode_spec): Remove parameter `precision', introduced during
5262 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5263 All callers changed.
5264
5ffb62aa
JD
52652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5266
5267 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5268
461c2ab9 52692011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5270
5271 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5272 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5273 (ns_update_auto_hide_menu_bar): New functions.
5274 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5275 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5276 ns_constrain_all_frames.
5277 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5278 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5279
5c380ffb
JD
52802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5281
5282 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5283
9af30bdf
GM
52842011-03-27 Glenn Morris <rgm@gnu.org>
5285
5286 * syssignal.h: Replace RETSIGTYPE with void.
5287 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5288 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5289 Replace SIGTYPE with void everywhere.
5290 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5291 * s/template.h (SIGTYPE): Remove commented out definition.
5292
e2abce01
JB
52932011-03-26 Eli Zaretskii <eliz@gnu.org>
5294
5295 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5296 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5297
f868cd8a
JB
52982011-03-26 Juanma Barranquero <lekktu@gmail.com>
5299
59eb0929
JB
5300 * w32.c (read_unc_volume): Use parameter `henum', instead of
5301 global variable `wget_enum_handle'.
5302
5303 * keymap.c (describe_vector): Remove parameters `indices' and
5304 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5305 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5306
f868cd8a
JB
5307 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5308
5309 * keyboard.c (timer_check): Remove parameter `do_it_now',
5310 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5311 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5312 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5313
5314 * keyboard.c (read_char):
5315 * w32menu.c (w32_menu_display_help):
5316 * xmenu.c (show_help_event, menu_help_callback):
5317 Adjust calls to `show_help_echo'.
5318
5319 * gtkutil.c (xg_maybe_add_timer):
5320 * keyboard.c (readable_events):
5321 * process.c (wait_reading_process_output):
5322 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5323
5324 * insdel.c (adjust_markers_gap_motion):
5325 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5326 (gap_left, gap_right): Don't call it.
5327
2ecf6fdb
CY
53282011-03-25 Chong Yidong <cyd@stupidchicken.com>
5329
5330 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5331 incurred during fontification.
5332
6b1f9ba4
JB
53332011-03-25 Juanma Barranquero <lekktu@gmail.com>
5334
5335 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5336 (DEFVAR_PER_BUFFER): Don't pass it.
5337
5338 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5339 (scrolling_window): Don't pass it.
5340
0f4a96b5
JB
53412011-03-25 Juanma Barranquero <lekktu@gmail.com>
5342
5343 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5344
5345 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5346 and `suffix'.
5347 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5348 of variables specific to SELinux and computation of `encoded_absname'.
5349
5350 * image.c (XPutPixel): Remove unused variable `height'.
5351
5352 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5353
5354 * unexw32.c (get_section_info): Remove unused variable `section'.
5355
5356 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5357 (system_process_attributes): Remove unused variable `sess'.
5358 (sys_read): Remove unused variable `err'.
5359
5360 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5361 (w32_wnd_proc): Remove unused variable `isdead'.
5362 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5363 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5364 (x_create_tip_frame): Remove unused variable `tem'.
5365
5366 * w32inevt.c (w32_console_read_socket):
5367 Remove unused variable `no_events'.
5368
5369 * w32term.c (x_draw_composite_glyph_string_foreground):
5370 Remove unused variable `width'.
5371
1149507c
JB
53722011-03-24 Juanma Barranquero <lekktu@gmail.com>
5373
5374 * w32term.c (x_set_glyph_string_clipping):
5375 Don't pass uninitialized region to CombineRgn.
5376
9c88f339
JB
53772011-03-23 Juanma Barranquero <lekktu@gmail.com>
5378
5379 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5380 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5381 (Fx_close_connection): Remove unused variable `i'.
5382
5383 * w32font.c (w32font_draw): Return number of glyphs.
5384 (w32font_open_internal): Remove unused variable `i'.
5385 (w32font_driver): Add missing initializer.
5386
5387 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5388 (fill_in_menu): Remove unused variable `items_added'.
5389
5390 * w32term.c (last_mouse_press_frame): Remove static global variable.
5391 (w32_clip_to_row): Remove unused variable `f'.
5392 (x_delete_terminal): Remove unused variable `i'.
5393
5394 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5395 (NOTHING): Remove unused static global variable.
5396 (uniscribe_check_otf): Remove unused variable `table'.
5397 (uniscribe_font_driver): Add missing initializers.
5398
dee091a3
JD
53992011-03-23 Julien Danjou <julien@danjou.info>
5400
5401 * term.c (Fsuspend_tty, Fresume_tty):
5402 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5403 * window.c (temp_output_buffer_show):
5404 * insdel.c (signal_before_change):
5405 * frame.c (Fhandle_switch_frame):
5406 * fileio.c (Fdo_auto_save):
5407 * emacs.c (Fkill_emacs):
5408 * editfns.c (save_excursion_restore):
5409 * cmds.c (internal_self_insert):
5410 * callint.c (Fcall_interactively):
5411 * buffer.c (Fkill_all_local_variables):
5412 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5413 Use Frun_hooks.
0f4a96b5 5414 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5415 unconditionnaly since it does the check itself.
5416
2c520ab5 54172011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5418
c9c49752
PE
5419 Fix more problems found by GCC 4.5.2's static checks.
5420
8abc3f12
PE
5421 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5422 the first time through the loop, since we know p0 < p1 then.
5423 This also avoids a gcc -Wstrict-overflow warning.
5424
a2d26660
PE
5425 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5426 leading to a memory leak, possible in functions like
5427 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5428 of objects (Bug#8318).
a2d26660 5429
916c72e9
PE
5430 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5431 that could (at least in theory) be that large.
5432
19ab8a18
PE
5433 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5434 This is less likely to overflow, and avoids undefined behavior if
5435 overflow does occur. All callers changed. Use strtoul to scan
5436 for the unsigned long integer.
b7cbbd6f
PE
5437 (pint2hrstr): Simplify and tune code slightly.
5438 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5439
f0641eff
PE
5440 * scroll.c (do_scrolling): Work around GCC bug 48228.
5441 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5442
7f650bb9
PE
5443 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5444 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5445 (validate_x_resource_name): Simplify count usage.
5446 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5447
37dd57d1
PE
5448 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5449 fail (Bug#8306).
81e56e61 5450
699979fc 5451 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5452
401bf9b4
PE
5453 * process.c (Fmake_network_process): Use socklen_t, not int,
5454 where POSIX says socklen_t is required in portable programs.
5455 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5456 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5457 (Fmake_network_process, server_accept_connection):
5458 (wait_reading_process_output, read_process_output):
5459 Likewise.
5460
b93aacde
PE
5461 * process.c: Rename or move locals to avoid shadowing.
5462 (list_processes_1, Fmake_network_process):
5463 (read_process_output_error_handler, exec_sentinel_error_handler):
5464 Rename or move locals.
4dc343ee 5465 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5466 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5467 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5468 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5469 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5470
af8a867c 5471 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5472 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5473 Include tparam.h instead, since it declares them.
af8a867c
PE
5474 * cm.h (PC): Remove extern decl; tparam.h now does this.
5475 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5476 * terminfo.c: Include tparam.h, to check interfaces.
5477 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5478 (tparam): Adjust signature to match interface in tparam.h;
5479 this removes some undefined behavior. Check that outstring and len
5480 are zero, which they always are with Emacs.
5481 * tparam.h (PC, BC, UP): New extern decls.
5482
0248044d 5483 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5484 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5485
8ff096c1 5486 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5487 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5488 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5489 (ftfont_list): Remove unused local.
49eaafba
PE
5490 (get_adstyle_property, ftfont_pattern_entity):
5491 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5492 Rename locals to avoid shadowing.
8ff096c1 5493
e2be39f6
PE
5494 * xfont.c (xfont_list_family): Mark var as initialized.
5495
c9735e30
PE
5496 * xml.c (make_dom): Now static.
5497
8f5201ae
PE
5498 * composite.c (composition_compute_stop_pos): Rename local to
5499 avoid shadowing.
b246f932
PE
5500 (composition_reseat_it): Remove unused locals.
5501 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5502 (composition_update_it): Mark var as initialized.
11b61122
PE
5503 (find_automatic_composition): Mark vars as initialized,
5504 with a FIXME (Bug#8290).
8f5201ae 5505
760fbc2c
PE
5506 character.h: Rename locals to avoid shadowing.
5507 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5508 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5509 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5510 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5511 to avoid shadowing.
5512
ff08eb85
PE
5513 * textprop.c (property_change_between_p): Remove; unused.
5514
fc7bf025
PE
5515 * intervals.c (interval_start_pos): Now static.
5516
235d7abc
PE
5517 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5518
44f230aa
SM
5519 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5520 Rename locals to avoid shadowing.
3e7d6594 5521
50060332
PE
5522 * sound.c (wav_play, au_play, Fplay_sound_internal):
5523 Fix pointer signedness.
d01f234b 5524 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5525 (wav_play): Initialize a variable to 0, to prevent undefined
5526 behavior (Bug#8278).
50060332 5527
c4fc4e30
PE
5528 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5529
918436ed
PE
5530 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5531
c939f91b
PE
5532 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5533 clobbering (Bug#8298).
b9c7f648
PE
5534 * sysdep.c (sys_subshell): Likewise.
5535 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5536
6bd8c144
PE
5537 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5538 This should get cleaned up, so that child_setup has the
5539 same signature on all platforms.
5540
7710357c 5541 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5542 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5543
c59da222
CY
55442011-03-22 Chong Yidong <cyd@stupidchicken.com>
5545
5546 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5547 not to be necessary, and produces flickering.
5548
66b87493
GM
55492011-03-20 Glenn Morris <rgm@gnu.org>
5550
5551 * config.in: Remove file.
5552
45b6f6d5
JB
55532011-03-20 Juanma Barranquero <lekktu@gmail.com>
5554
5555 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5556 are now in src/globals.h.
5557 (syms_of_minibuf): Remove spurious & from previous change.
5558
3ec03f7e
LL
55592011-03-20 Leo <sdl.web@gmail.com>
5560
5561 * minibuf.c (completing-read-function): New variable.
5562 (completing-read-default): Rename from completing-read.
5563 (completing-read): Call completing-read-function.
5564
b14e3e21
CY
55652011-03-19 Juanma Barranquero <lekktu@gmail.com>
5566
5567 * xfaces.c (Fx_load_color_file):
5568 Read color file from absolute filename (bug#8250).
5569
f2b726e6
JB
55702011-03-19 Juanma Barranquero <lekktu@gmail.com>
5571
5572 * makefile.w32-in: Update dependencies.
5573
09f6ff02
EZ
55742011-03-17 Eli Zaretskii <eliz@gnu.org>
5575
5576 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5577
29a6015a
PE
55782011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5579
a3a6c54e
PE
5580 Fix more problems found by GCC 4.5.2's static checks.
5581
b766f867
PE
5582 * process.c (make_serial_process_unwind, send_process_trap):
5583 (sigchld_handler): Now static.
5584
be02381c
PE
5585 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5586 That way, the code declares only the vars that it needs.
5587 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5588 * s/cygwin.h (PTY_ITERATION): Likewise.
5589 * s/darwin.h (PTY_ITERATION): Likewise.
5590 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5591
57048744
PE
5592 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5593 * process.c (allocate_pty): Don't declare stb unless it's needed.
5594
7914961c 5595 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5596 (CONSTANTLIM): Remove; unused.
5597 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5598 Define only if needed.
7914961c 5599
b3967b18
PE
5600 * unexelf.c (unexec): Name an expression,
5601 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5602 Use a different way to cause a compilation error if anyone uses
5603 n rather than nn, a way that does not involve shadowing.
73366a00 5604 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5605
29a6015a
PE
5606 * deps.mk (unexalpha.o): Remove; unused.
5607
43cfc33e 5608 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5609 * unexec.h: New file.
ce701a33
PE
5610 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5611 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5612 Depend on unexec.h.
5613 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5614 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5615 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5616 Change as necessary to match prototype in unexec.h.
ce701a33 5617
01f44d5a
PE
5618 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5619 shadowing.
4f63c6bb 5620 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5621
a6670b0b
PE
5622 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5623 Rename locals to avoid shadowing.
5624
cef2010d 5625 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5626 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5627
d4d7173a
PE
5628 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5629
f08b802a
PE
5630 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5631 warning when compiling print.c.
5632
3ddb0639
PE
5633 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5634 instead of using an uninitialized var.
5ad03b97 5635 (font_sort_entities): Mark var as initialized.
3ddb0639 5636
170a2692
PE
5637 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5638
e663c700
PE
5639 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5640 pointers to constants.
89bc529a 5641 (font_parse_fcname): Remove unused vars.
7b81e2d0 5642 (font_delete_unmatched): Now static.
ea838e10 5643 (font_get_spec): Remove; unused.
13a547c6
PE
5644 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5645 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5646 Rename or move locals to avoid shadowing.
e663c700 5647
2a80c887 5648 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5649 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5650
1384fa33 5651 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5652 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5653
8b2c52e9
PE
5654 * alloc.c (mark_backtrace): Move decl from here ...
5655 * lisp.h: ... to here, so that it can be checked.
5656
475545b5 5657 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5658 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5659 (lisp_indirect_variable): Name an expression,
5660 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5661 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5662
b1349114 5663 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5664 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5665 Use const pointer when appropriate.
b1349114 5666
a2928364
PE
5667 * lisp.h (get_system_name, get_operating_system_release):
5668 Move decls here, to check interfaces.
5669 * process.c (get_operating_system_release): Move decl to lisp.h.
5670 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5671 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5672 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5673 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5674 (Fformat_time_string, Fencode_time, Finsert_char):
5675 (Ftranslate_region_internal, Fformat):
5676 Rename or remove local vars to avoid shadowing.
9710023e 5677 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5678
a415e694
PE
5679 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5680 avoid shadowing.
5681
8ef4622d
PE
5682 * lisp.h (eassert): Check that the argument compiles, even if
5683 ENABLE_CHECKING is not defined.
5684
946f9a5b
PE
5685 * data.c (Findirect_variable): Name an expression, to avoid
5686 gcc -Wbad-function-cast warning.
112396d6 5687 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5688 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5689 (Fmake_variable_buffer_local, Fmake_local_variable):
5690 Mark variables as initialized.
52746918 5691 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5692
e5aab7e7 5693 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5694 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5695 Rename locals to avoid shadowing.
dff45157
PE
5696 (mark_stack): Move local variables into the #ifdef region where
5697 they're used.
7bc26fdb
PE
5698 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5699 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5700 needed otherwise.
5701 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5702 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5703 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5704
e5aab7e7
PE
5705 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5706 avoids undefined behavior in theory.
5707
4da60324
PE
5708 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5709
88043301
PE
5710 Use functions, not macros, for up- and down-casing (Bug#8254).
5711 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5712 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5713 to use the following functions instead of these macros.
5714 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5715 EMACS_INT, since callers assume the returned value fits in int.
5716 (upcase1): Likewise, for UPCASE_TABLE.
5717 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5718 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5719 the race-condition problem in the old DOWNCASE.
88043301 5720
19ed5445
PE
5721 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5722 Rename locals to avoid shadowing.
5723 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5724 (regex_compile, re_search_2, re_match_2_internal):
5725 Remove unused local vars.
952db0d7
PE
5726 (FREE_VAR): Rewrite so as not to use empty "else",
5727 which gcc can warn about.
da053e48 5728 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5729 (RETALLOC_IF): Define only if needed.
5730 (WORDCHAR_P): Likewise. This one is never needed, but is used
5731 only in a comment talking about a compiler bug, so put inside
5732 the #if 0 of that comment.
5733 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5734 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5735 Remove; unused.
19ed5445 5736
1f3561e4 5737 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5738 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5739 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5740
ded6f8f7
PE
5741 * search.c (simple_search): Remove unused var.
5742
dbd37a95
PE
5743 * dired.c (compile_pattern): Move decl from here ...
5744 * lisp.h: ... to here, so that it can be checked.
5745 (struct re_registers): New forward decl.
5746
7e47afad
PE
5747 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5748
85f24f61
PE
5749 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5750 All uses changed.
5751 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5752 Rename locals to avoid shadowing.
5671df8f 5753 (Fvertical_motion): Mark locals as initialized.
85f24f61 5754
181aa2be 5755 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5756 (casify_region): Mark local as initialized.
181aa2be 5757
930d429c
PE
5758 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5759
7082eac6
PE
5760 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5761 New macros, so that the caller can use some names other than
5762 gcpro1, gcpro2, etc.
5763 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5764 of the new macros.
5765 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5766 argument, for consistency with GCPRO2_VAR, etc: it is now the
5767 prefix of the variable, not the variable itself. All uses
5768 changed.
38b2c076
PE
5769 * dired.c (directory_files_internal, file_name_completion):
5770 Rename locals to avoid shadowing.
5771
15206ed9
PE
5772 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5773 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5774 dired.c's scmp function, had undefined behavior.
5775 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5776 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5777 * buffer.h: ... to here, because these macros use current_buffer,
5778 and the new implementation with inline functions needs to have
5779 current_buffer in scope now, rather than later when the macros
5780 are used.
5781 (downcase, upcase1): New static inline functions.
5782 (DOWNCASE, UPCASE1): Reimplement using these functions.
5783 This avoids undefined behavior in expressions like
5784 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5785 from race conditions in accessing the global variables
5786 case_temp1 and case_temp2.
5787 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5788 * lisp.h (case_temp1, case_temp2): Remove their decls.
5789 * character.h (ASCII_CHAR_P): Move from here ...
5790 * lisp.h: ... to here, so that the inline functions mentioned
5791 above can use them.
5792
4a6bea26
PE
5793 * dired.c (directory_files_internal_unwind): Now static.
5794
f14b7e14
PE
5795 * fileio.c (file_name_as_directory, directory_file_name):
5796 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5797 Now static.
2893f146
PE
5798 (file_name_as_directory): Use const pointers when appropriate.
5799 (Fexpand_file_name): Likewise. In particular, newdir might
5800 point at constant storage, so make it a const pointer.
fd4ead52 5801 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5802 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5803 signedness issues.
f839df0c
PE
5804 (Fset_file_times, Finsert_file_contents, auto_save_error):
5805 Rename locals to avoid shadowing.
f14b7e14 5806
5716756e 5807 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5808 (Ftry_completion, Fall_completions): Rename or remove locals
5809 to avoid shadowing.
5716756e 5810
b4c3046a
PE
5811 * marker.c (bytepos_to_charpos): Remove; unused.
5812
b45db522
PE
5813 * lisp.h (verify_bytepos, count_markers): New decls,
5814 so that gcc does not warn that these functions aren't declared.
5815
85876d07
PE
5816 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5817 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5818 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5819 (copy_text): Remove unused local var.
85876d07 5820
03d78a21 5821 * filelock.c (within_one_second): Now static.
b3dd38ab 5822 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5823
5df8f01b
PE
5824 * buffer.c (fix_overlays_before): Mark locals as initialized.
5825 (fix_start_end_in_overlays): Likewise. This function should be
5826 simplified by using pointers-to-pointers, but that's a different
5827 matter.
b1d876f1 5828 (switch_to_buffer_1): Now static.
8f54f30a
PE
5829 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5830 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5831
a70072c9 5832 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5833 Fix pointer signedness issue.
edced198
PE
5834 (sys_subshell): Mark local as volatile if checking for lint,
5835 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5836 (MAXPATHLEN): Define only if needed.
a70072c9 5837
a0977c44
PE
5838 * process.c (serial_open, serial_configure): Move decls from here ...
5839 * systty.h: ... to here, so that they can be checked.
5840
a884fdcc
PE
5841 * fns.c (get_random, seed_random): Move extern decls from here ...
5842 * lisp.h: ... to here, so that they can be checked.
5843
604efe86 5844 * sysdep.c (reset_io): Now static.
b8950c94 5845 (wait_for_termination_signal): Remove; unused.
604efe86 5846
38fc62d9
PE
5847 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5848 (copy_keymap_item, append_key, push_text_char_description):
5849 Now static.
1004a21a 5850 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5851 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5852 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5853 (describe_map_tree):
5854 Rename locals to avoid shadowing.
38fc62d9 5855
2f2650da
PE
5856 * keyboard.c: Declare functions static if they are not used elsewhere.
5857 (echo_char, echo_dash, cmd_error, top_level_2):
5858 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5859 (read_char, kbd_buffer_get_event, make_lispy_position):
5860 (make_lispy_event, make_lispy_movement, apply_modifiers):
5861 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5862 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5863 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5864 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5865 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5866
a053e86c 5867 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5868 (mark_kboards): Move decl here ...
5869 * alloc.c (mark_kboards): ... from here.
a053e86c 5870
4752793e
PE
5871 * lisp.h (force_auto_save_soon): New decl.
5872
74f10ca7 5873 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5874 (DEFINE_DUMMY_FUNCTION): New macro.
5875 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5876 Use it.
c03cd23f
PE
5877 (main): Add casts to avoid warnings
5878 if GCC considers string literals to be constants.
74f10ca7 5879
022e70d4
PE
5880 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5881
59d6fe83
PE
5882 * dbusbind.c: Pointer signedness fixes.
5883 (xd_signature, xd_append_arg, xd_initialize):
5884 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5885 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5886 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5887 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5888
78320123
PE
5889 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5890 if GCC considers string literals to be constants.
49cebcca 5891 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5892
35ac2a97
SM
58932011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5894
fb103ca9
SM
5895 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5896 (print_preprocess, print_object): New macro to fix last change.
5897
35ac2a97
SM
5898 * print.c (print_preprocess): Don't forget font objects.
5899
62973b41
JB
59002011-03-16 Juanma Barranquero <lekktu@gmail.com>
5901
5902 * emacs.c (USAGE3): Doc fixes.
5903
0e48bb22
AS
59042011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5905
5906 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5907 structure.
5908
7684e57b
JB
59092011-03-14 Juanma Barranquero <lekktu@gmail.com>
5910
5911 * lisp.h (VWindow_system, Qfile_name_history):
5912 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5913 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5914 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5915
5916 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5917 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5918
5919 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5920 * w32console.c (detect_input_pending, read_input_pending)
5921 (encode_terminal_code):
5922 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5923 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5924 (w32_system_caret_y, Qfile_name_history):
5925 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5926 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5927 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5928 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5929 * w32proc.c (Qlocal, report_file_error):
5930 * w32term.c (Vwindow_system, updating_frame):
5931 * w32uniscribe.c (initialized, uniscribe_font_driver):
5932 Remove unneeded extern declarations.
5933
2aa46d6c
CY
59342011-03-14 Chong Yidong <cyd@stupidchicken.com>
5935
c96bbc66 5936 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5937
cffc6f3b
CY
59382011-03-13 Chong Yidong <cyd@stupidchicken.com>
5939
5940 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5941 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5942 These macros can no longer be used for assignment.
5943
44f230aa
SM
5944 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5945 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5946 (record_buffer_markers, fetch_buffer_markers): New functions for
5947 recording and fetching special buffer markers.
5948 (set_buffer_internal_1, set_buffer_temp): Use them.
5949
5950 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5951
5952 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5953
5954 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5955 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5956
5957 * xdisp.c (hscroll_window_tree):
5958 (reconsider_clip_changes): Use PT instead of BUF_PT.
5959
d251f04b
EZ
59602011-03-13 Eli Zaretskii <eliz@gnu.org>
5961
5962 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5963 $(EMACS_ROOT)/lib/intprops.h.
5964
f0c77cd1
PE
59652011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5966
3eca4629
PE
5967 Fix more problems found by GCC 4.5.2's static checks.
5968
7c86ee98
PE
5969 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5970 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5971 (xg_free_frame_widgets): Make it clear that a local variable is
5972 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5973 (gdk_window_get_screen): Make it clear that this macro is needed
5974 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5975 (int_gtk_range_get_value): New function, which avoids a diagnostic
5976 from gcc -Wbad-function-cast.
5977 (xg_set_toolkit_scroll_bar_thumb): Use it.
5978 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5979 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5980 (get_utf8_string, xg_get_file_with_chooser):
5981 Rename locals to avoid shadowing.
5982 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5983
41729b81
PE
5984 * xgselect.c (xg_select): Remove unused var.
5985
f0c77cd1
PE
5986 * image.c (four_corners_best): Mark locals as initialized.
5987 (gif_load): Initialize transparent_p to zero (Bug#8238).
5988 Mark another local as initialized.
ec6cf4c6 5989 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5990
ce0ad53d 5991 * image.c (clear_image_cache): Now static.
d5d5a617 5992 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5993 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5994 (x_edge_detection): Remove unnecessary cast that
5995 gcc -Wbad-function-cast diagnoses.
2037898d 5996 (gif_load): Fix pointer signedness.
6ae141d6
PE
5997 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5998 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5999
33383987 60002011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6001
d32df629
PE
6002 Improve quality of tests for time stamp overflow.
6003 For example, without this patch (encode-time 0 0 0 1 1
6004 1152921504606846976) returns the obviously-bogus value (-948597
6005 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6006 reports time overflow. See
6007 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6008 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6009 * editfns.c: Include limits.h and intprops.h.
6010 (TIME_T_MIN, TIME_T_MAX): New macros.
6011 (time_overflow): Move earlier, to before first use.
6012 (hi_time, lo_time): New functions, for an accurate test for
6013 out-of-range times.
6014 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6015 (Fget_internal_run_time): Don't assume time_t fits in int.
6016 (make_time): Use list2 instead of Fcons twice.
6017 (Fdecode_time): More accurate test for out-of-range times.
6018 (check_tm_member): New function.
6019 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6020 (lisp_time_argument): Don't rely on undefined left-shift and
6021 right-shift behavior when checking for time stamp overflow.
8be6f318 6022
fe31d94c
PE
6023 * editfns.c (time_overflow): New function, refactoring common code.
6024 (Fformat_time_string, Fdecode_time, Fencode_time):
6025 (Fcurrent_time_string): Use it.
6026
8be6f318
PE
6027 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6028 * dired.c (make_time): Move to ...
6029 * editfns.c (make_time): ... here.
6030 * systime.h: Note the move.
6031
09d9db2c 60322011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6033
126bc0dc
YM
6034 * fringe.c (update_window_fringes): Remove unused variables.
6035
c47cbdfd
YM
6036 * unexmacosx.c (copy_data_segment): Also copy __got section.
6037 (Bug#8223)
6038
7ac80be9
EZ
60392011-03-12 Eli Zaretskii <eliz@gnu.org>
6040
c96bbc66 6041 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6042 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6043 Constify `char *' arguments and their references according to
6044 prototypes in tparam.h.
6045
ecb0f94d 6046 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6047
7ac80be9
EZ
6048 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6049 Adapt all references accordingly.
6050
6051 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6052
ef1fd07e
TT
60532011-03-11 Tom Tromey <tromey@redhat.com>
6054
6055 * buffer.c (syms_of_buffer): Remove obsolete comment.
6056
7ef4b50c
EZ
60572011-03-11 Eli Zaretskii <eliz@gnu.org>
6058
6059 * termhooks.h (encode_terminal_code): Declare prototype.
6060
6061 * msdos.c (encode_terminal_code): Don't declare prototype.
6062
6063 * term.c (encode_terminal_code): Now external again, used by
6064 w32console.c and msdos.c.
6065
44f230aa
SM
6066 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6067 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6068
4b1ec863 60692011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6070
1714f52b 6071 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6072
4b1ec863
PE
6073 * fringe.c (update_window_fringes): Mark locals as initialized
6074 (Bug#8227).
6075 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6076
524c7aa6
PE
6077 * alloc.c (mark_fringe_data): Move decl from here ...
6078 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6079 to check its interface.
6080 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6081
a5c0af81 6082 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6083 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6084 (fontset_font): Mark local as initialized.
a9a06e0b 6085 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6086
b4716021
PE
6087 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6088
811e9bac 6089 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6090 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6091 (x_own_selection, Fx_disown_selection_internal): Rename locals
6092 to avoid shadowing.
6093 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6094
7e3ab302
PE
6095 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6096 so that the caller can use some name other than gcpro1.
6097 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6098 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6099 (Fx_backspace_delete_keys_p):
6100 Use them to avoid shadowing, and rename vars to avoid shadowing.
6101 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6102 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6103 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6104 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6105 Remove unused locals.
7e3ab302
PE
6106 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6107 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6108 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6109 macros.
f78faa98 6110
e2b13473
PE
6111 * xterm.h (x_mouse_leave): New decl.
6112
77f23912
PE
6113 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6114 Remove unused functions.
cdf4ba58
PE
6115 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6116 (x_calc_absolute_position): Now static.
7411c686 6117 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6118 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6119 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6120 unless they are used.
38d0b34a
PE
6121 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6122 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6123 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6124 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6125 (x_error_catcher, x_connection_closed, x_error_handler):
6126 (x_error_quitter, xembed_send_message, x_iconify_frame):
6127 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6128 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6129 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6130
44f230aa
SM
6131 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6132 Rename or move locals to avoid shadowing.
6b463e58 6133 (tty_defined_color, merge_face_heights): Now static.
5967d051 6134 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6135 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6136 does not deduce is never used uninitialized.
73719eba
PE
6137 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6138 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6139
426994c3 6140 * terminal.c (store_terminal_param): Now static.
5489860b 6141
032f1620 6142 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6143 (set_frame_menubar): Remove unused local.
d4323972 6144 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6145 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6146 since they might point to immutable storage.
281585b0
PE
6147 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6148 since it's unused otherwise.
032f1620 6149
367c19e5 6150 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6151 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6152 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6153 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6154 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6155 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6156 does not deduce are never used uninitialized.
70739cbe 6157
07b48fa9
PE
6158 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6159
8868a238 6160 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6161 * window.c (window_loop, size_window):
6162 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6163
7e5cf297 6164 * window.c (display_buffer): Now static.
d6550a9f
PE
6165 (size_window): Mark variables that gcc -Wuninitialized
6166 does not deduce are never used uninitialized.
a586633d
PE
6167 * window.h (check_all_windows): New decl, to forestall
6168 gcc -Wmissing-prototypes diagnostic.
5b555da1 6169 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6170
f6095868
PE
6171 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6172 shadowing.
6173 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6174 Include <limits.h>.
6175 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6176 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6177 (load_charset_map): Mark variables that gcc -Wuninitialized
6178 does not deduce are never used uninitialized.
53df7c11 6179 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6180
f38b440c
PE
6181 * coding.c (coding_set_source, coding_set_destination):
6182 Use "else { /* comment */ }" rather than "else /* comment */;"
6183 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6184 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6185 a block, when the outer 'i' will do.
6186 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6187 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6188 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6189 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6190 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6191 Rename locals to avoid shadowing.
6192 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6193 * coding.c (emacs_mule_char, encode_invocation_designation):
6194 Now static, since they're not used elsewhere.
413bb2db 6195 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6196 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6197 (decode_coding_emacs_mule): Mark variables that gcc
6198 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6199 (detect_coding_iso_2022): Initialize a local variable that might
6200 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6201 this initialization is needed. (Bug#8211)
5f58e762
PE
6202 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6203 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6204 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6205 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6206 Remove unused macros.
f38b440c 6207
232b38b9 6208 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6209 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6210 * character.c (string_count_byte8): Likewise.
232b38b9 6211
fb90da1b
PE
6212 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6213 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6214
fb93dbc2
PE
6215 * chartab.c (copy_sub_char_table): Now static, since it's not used
6216 elsewhere.
5c156ace
PE
6217 (sub_char_table_ref_and_range, char_table_ref_and_range):
6218 Rename locals to avoid shadowing.
bbcd0949 6219 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6220
7d3b3862 6221 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6222 (BIDI_BOB): Remove unused macro.
7d3b3862 6223
6be7d3da
PE
6224 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6225 deduce are never used uninitialized.
c2ed9c8b 6226 * term.c (encode_terminal_code): Likewise.
6be7d3da 6227
75f8807f 6228 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6229
50938595
PE
6230 * tparam.h: New file.
6231 * term.c, tparam.h: Include it.
6232 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6233 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6234 Move these decls to tparam.h, and make them agree with what
6235 is actually in tparam.c. The previous trick of using incompatible
6236 decls in different modules does not conform to the C standard.
6237 All callers of tparam changed to use tparam's actual API.
6238 * tparam.c (tparam1, tparam, tgoto):
6239 Use const pointers where appropriate.
6240
fbceeba2
PE
6241 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6242 * cm.h (struct cm): Likewise.
6243 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6244 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6245 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6246 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6247 (turn_on_face, init_tty): Likewise.
6248 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6249
7f3f1250
PE
6250 * term.c (term_mouse_position): Rename local to avoid shadowing.
6251
e6ca6543
PE
6252 * alloc.c (mark_ttys): Move decl from here ...
6253 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6254
c40f8d15
AS
62552011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6256
6257 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6258
cfe0661d
JB
62592011-03-09 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * search.c (compile_pattern_1): Remove argument regp, unused since
6262 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6263 (compile_pattern): Don't pass it.
6264
0afb4571
J
62652011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6266
6267 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6268 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6269 for ! HAVE_GTK3.
6270 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6271
6272 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6273
6274 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6275 gdk_window_get_screen, gdk_window_get_geometry,
6276 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6277 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6278 (xg_get_pixbuf_from_pixmap): New function.
6279 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6280 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6281 Call xg_get_pixbuf_from_pixmap instead of
6282 gdk_pixbuf_get_from_drawable.
6283 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6284 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6285 (xg_check_special_colors): Use GtkStyleContext and its functions
6286 for HAVE_GTK3.
6287 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6288 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6289 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6290 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6291 Call gtk_widget_get_preferred_size.
0afb4571
J
6292 (xg_frame_resized): gdk_window_get_geometry only takes 5
6293 parameters.
44f230aa
SM
6294 (xg_win_to_widget, xg_event_is_for_menubar):
6295 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6296 (xg_set_widget_bg): New function.
6297 (delete_cb): New function.
895009e1 6298 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6299 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6300 (xg_set_background_color): Call xg_set_widget_bg.
6301 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6302 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6303 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6304 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6305 if ! HAVE_GTK3.
6306 (update_frame_tool_bar): Call gtk_widget_hide.
6307 (xg_initialize): Use GDK_KEY_g.
6308
6309 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6310 if ! HAVE_GTK3
6311 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6312
6313 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6314 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6315 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6316
1c2cc4ef
JB
63172011-03-08 Juanma Barranquero <lekktu@gmail.com>
6318
6319 * w32xfns.c (select_palette): Check success of RealizePalette against
6320 GDI_ERROR, not zero.
6321
33383987 6322See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6323
6324;; Local Variables:
6325;; coding: utf-8
aac0c6e3
MR
6326;; End:
6327
33383987 6328 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6329
6330 This file is part of GNU Emacs.
6331
6332 GNU Emacs is free software: you can redistribute it and/or modify
6333 it under the terms of the GNU General Public License as published by
6334 the Free Software Foundation, either version 3 of the License, or
6335 (at your option) any later version.
6336
6337 GNU Emacs is distributed in the hope that it will be useful,
6338 but WITHOUT ANY WARRANTY; without even the implied warranty of
6339 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6340 GNU General Public License for more details.
6341
6342 You should have received a copy of the GNU General Public License
6343 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.