* src/buffer.c (buffer-list-update-hook): Doc fix.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
96a72ee9
GM
12012-03-02 Glenn Morris <rgm@gnu.org>
2
3 * buffer.c (buffer-list-update-hook): Doc fix.
4
312508d7
EZ
52012-02-29 Eli Zaretskii <eliz@gnu.org>
6
7 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
8 push_it before setting up the iterator for the first overlay
9 string, even if we have an empty string loaded.
10 (next_overlay_string): If there's an empty string on the iterator
11 stack, pop the stack. (Bug#10903)
12
27f3c637
PE
132012-02-25 Paul Eggert <eggert@cs.ucla.edu>
14
15 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
16 Suggested by Stefan Monnier in
17 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
18 * alloc.c (widen_to_Lisp_Object): New static function.
19 (mark_memory): Also mark Lisp_Objects by fetching pointer words
20 and widening them to Lisp_Objects. This would work even if
21 USE_LSB_TAG is defined and wide integers are used, which might
22 happen in a future version of Emacs.
23
3c9dfce6
CY
242012-02-25 Chong Yidong <cyd@gnu.org>
25
fa74b241
CY
26 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
27 Doc fix.
28
3c9dfce6
CY
29 * xselect.c (Fx_selection_exists_p): Doc fix.
30 (x_clipboard_manager_save_all): Print an informative message
31 before saving to clipboard manager.
32
9486df08
CY
332012-02-24 Chong Yidong <cyd@gnu.org>
34
35 * keyboard.c (process_special_events): Handle all X selection
36 requests in kbd_buffer, not just the next one (Bug#8869).
37
f01d3321
CY
382012-02-23 Chong Yidong <cyd@gnu.org>
39
40 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
41 call when setting menu-bar-lines and tool-bar-lines parameters.
42 (unwind_create_frame_1): New helper function.
43
44 * window.c (inhibit_window_configuration_change_hook): New var.
45 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 46 (syms_of_window): Initialize it.
f01d3321 47
86b847b6
CY
482012-02-22 Chong Yidong <cyd@gnu.org>
49
50 * xterm.c (x_draw_image_relief): Add missing type check for
51 Vtool_bar_button_margin (Bug#10743).
52
a59225b1
CY
532012-02-21 Chong Yidong <cyd@gnu.org>
54
55 * fileio.c (Vfile_name_handler_alist): Doc fix.
56
57 * buffer.c (Fget_file_buffer): Protect against invalid file
58 handler return value.
59
310f5bd4
PE
602012-02-20 Paul Eggert <eggert@cs.ucla.edu>
61
cb3a28cc
PE
62 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
63 when computing $valmask.
64
310f5bd4
PE
65 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
66 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
67 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
68 It's useless in that case, and it can cause problems on hosts
69 that allocate halves of EMACS_INT values separately.
70 Reported by Dan Horák. Diagnosed by Andreas Schwab in
71 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
72 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
73 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
74 it avoids undefined behavior on hosts where shifting right by more
75 than the word width has undefined behavior.
76
2375c96a
CY
772012-02-19 Chong Yidong <cyd@gnu.org>
78
79 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
80 (Funhandled_file_name_directory, Ffile_name_as_directory)
81 (Fdirectory_file_name, Fexpand_file_name)
82 (Fsubstitute_in_file_name): Protect against invalid file handler
83 return values (Bug#10845).
84
3eb49e71
EZ
852012-02-18 Eli Zaretskii <eliz@gnu.org>
86
87 * .gdbinit (pitx): Fix incorrect references to fields of the
88 iterator stack.
89
7b926f3f
CY
902012-02-17 Chong Yidong <cyd@gnu.org>
91
92 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
93
11273115
PE
942012-02-15 Paul Eggert <eggert@cs.ucla.edu>
95
96 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
97 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
98
c3a70e2b
CY
992012-02-15 Chong Yidong <cyd@gnu.org>
100
101 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
102 marked as special. Also, starting docstrings with * is obsolete.
103
0ca43699
AS
1042012-02-13 Andreas Schwab <schwab@linux-m68k.org>
105
106 * gnutls.c (emacs_gnutls_write): Fix last change.
107
2e8f3c56
LI
1082012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
109
110 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
111 send_process.
112
af70074f
SM
1132012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
114
115 * keymap.c (Fsingle_key_description): Handle char ranges.
116
95986d52
CY
1172012-02-12 Chong Yidong <cyd@gnu.org>
118
afd83bd1
CY
119 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
120 as that creates a dangerous corner case.
121
95986d52
CY
122 * window.c (Fdelete_window_internal): Invalidate the mouse
123 highlight (Bug#9904).
124
bd7da63e
GM
1252012-02-12 Glenn Morris <rgm@gnu.org>
126
127 * xselect.c (Fx_own_selection_internal)
128 (Fx_get_selection_internal, Fx_disown_selection_internal)
129 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
130 * nsselect.m (Fx_own_selection_internal)
131 (Fx_disown_selection_internal, Fx_selection_exists_p)
132 (Fx_selection_owner_p, Fx_get_selection_internal):
133 Sync docs and argument specs with the xselect.c versions.
134
77abcbc2
LI
1352012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
136
137 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
138
90b671e2
EZ
1392012-02-11 Eli Zaretskii <eliz@gnu.org>
140
1c0ca0b7
EZ
141 * w32select.c (Fx_selection_exists_p): Sync doc string and
142 argument list with xselect.c. (Bug#10783)
143
144 * w16select.c (Fx_selection_exists_p): Sync doc string and
145 argument list with xselect.c. (Bug#10783)
90b671e2 146
49241268
GM
1472012-02-10 Glenn Morris <rgm@gnu.org>
148
149 * fns.c (Fsecure_hash): Doc fix.
150
f998bbe7 1512012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
152
153 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
154
0992bd9c
CY
1552012-02-07 Chong Yidong <cyd@gnu.org>
156
157 * buffer.c (Fbuffer_local_variables)
158 (buffer_lisp_local_variables): Handle unbound vars correctly;
159 don't let Qunbound leak into Lisp.
160
af008560
GM
1612012-02-07 Glenn Morris <rgm@gnu.org>
162
dd605cc4
GM
163 * image.c (Fimagemagick_types): Doc fix.
164
af008560
GM
165 * image.c (imagemagick-render-type): Change it from a lisp object
166 to an integer. Move the doc here from the lisp manual.
167 Treat all values not equal to 0 the same.
168
1449fa1d
CY
1692012-02-06 Chong Yidong <cyd@gnu.org>
170
171 * doc.c (store_function_docstring): Avoid applying docstring of
172 alias to base function (Bug#2603).
173
3723ec07
AS
1742012-02-04 Andreas Schwab <schwab@linux-m68k.org>
175
176 * .gdbinit (pp1, pv1): Remove redundant defines.
177 (pr): Use pp.
178
79c1cc1e
CY
1792012-02-04 Chong Yidong <cyd@gnu.org>
180
181 * nsterm.m: Declare a global (Bug#10694).
182
d7f29f8e
EZ
1832012-02-04 Eli Zaretskii <eliz@gnu.org>
184
185 * w32.c (get_emacs_configuration_options): Include
186 --enable-checking, if specified, in the return value.
187
3b95a6f9
MR
1882012-02-04 Martin Rudalics <rudalics@gmx.at>
189
190 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
191 after rounding frame sizes. (Bug#9723)
192
d6fa96a6
EZ
1932012-02-04 Eli Zaretskii <eliz@gnu.org>
194
195 * keyboard.c (adjust_point_for_property): Don't position point
196 before BEGV. (Bug#10696)
197
df0b2940
PE
1982012-02-03 Paul Eggert <eggert@cs.ucla.edu>
199
200 Handle overflow when computing char display width (Bug#9496).
201 * character.c (char_width): Return EMACS_INT, not int.
202 (char_width, c_string_width): Check for overflow when
203 computing the width; this is possible now that individual
204 characters can have unbounded width. Problem introduced
205 by merge from Emacs 23 on 2012-01-19.
206
6bee44d6
MA
2072012-02-02 Michael Albinus <michael.albinus@gmx.de>
208
209 * dbusbind.c (Fdbus_register_method): Mention the return value
210 :ignore in the docstring.
211
44f92739
GM
2122012-02-02 Glenn Morris <rgm@gnu.org>
213
1b9f60cc
GM
214 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
215
44f92739
GM
216 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
217 Unconditionally set to t. (Bug#10673)
218 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
219 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
220 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
221
c5d3843c
KH
2222012-02-02 Kenichi Handa <handa@m17n.org>
223
224 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
225 0, do not call append_composite_glyph.
226
159462d4 2272012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
228
229 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
230 NULL (Bug#6988).
231 (x_produce_glyphs): If the component of a composition is a null
232 string, set it->pixel_width to 1 to avoid zero-width glyph.
233
78cef877
EZ
2342012-02-01 Eli Zaretskii <eliz@gnu.org>
235
236 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
237 first 2 arguments are identical. This makes inserting large
238 output from a subprocess an order of magnitude faster on
239 MS-Windows, where all sbrk'ed memory is always contiguous.
240
97897668
GM
2412012-01-31 Glenn Morris <rgm@gnu.org>
242
243 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 244 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
245 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
246
31fd3586
GM
2472012-01-29 Glenn Morris <rgm@gnu.org>
248
249 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
250
0e24a8b2
CY
2512012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
252
253 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
254
cc0adcb0
CY
2552012-01-28 Chong Yidong <cyd@gnu.org>
256
257 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
258
acc28cb9
CY
2592012-01-26 Chong Yidong <cyd@gnu.org>
260
9c69cfb7
CY
261 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
262
acc28cb9
CY
263 * search.c (Fsearch_forward, Fsearch_backward): Document negative
264 repeat counts (Bug#10507).
265
48da7392
GM
2662012-01-26 Glenn Morris <rgm@gnu.org>
267
268 * lread.c (syms_of_lread): Doc fix.
269
14af5f7f
CY
2702012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
271
272 * coding.c (encode_designation_at_bol): Change return value to
273 EMACS_INT.
274
0b21c100
CY
2752012-01-25 Chong Yidong <cyd@gnu.org>
276
277 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
278
3c2907f7
CY
2792012-01-21 Chong Yidong <cyd@gnu.org>
280
281 * floatfns.c (Fcopysign): Make the second argument non-optional,
282 since nil is not allowed anyway.
283
959ad23f
AS
2842012-01-21 Andreas Schwab <schwab@linux-m68k.org>
285
286 * process.c (read_process_output): Use p instead of XPROCESS (proc).
287 (send_process): Likewise.
288
34a02f46
MR
2892012-01-19 Martin Rudalics <rudalics@gmx.at>
290
291 * window.c (save_window_save, Fcurrent_window_configuration)
292 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
293 doc-strings.
294
1259009a 2952012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
296
297 * character.c (char_width): New function.
70d4fdf6
GM
298 (Fchar_width, c_string_width, lisp_string_width):
299 Use char_width (Bug#9496).
25ed9e61 300
6a6ee00d
MR
3012012-01-16 Martin Rudalics <rudalics@gmx.at>
302
303 * window.c (Vwindow_persistent_parameters): New variable.
304 (Fset_window_configuration, save_window_save): Handle persistent
305 window parameters.
306
c85efaf7
EZ
3072012-01-14 Eli Zaretskii <eliz@gnu.org>
308
309 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
310 thrashing the stack of the thread. (Bug#9087)
311
5944709e
PE
3122012-01-12 Paul Eggert <eggert@cs.ucla.edu>
313
314 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
315
e71f5d99
EZ
3162012-01-11 Eli Zaretskii <eliz@gnu.org>
317
318 * xdisp.c (rows_from_pos_range): Handle the case where the
319 highlight ends on a newline. (Bug#10464)
320 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
321 he end column for display of highlight that ends on a newline
322 before a R2L line.
323
ce316182
GM
3242012-01-11 Glenn Morris <rgm@gnu.org>
325
326 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
327 from load-path also when installation-directory is nil. (Bug#10208)
328
5b43da69
GM
3292012-01-10 Glenn Morris <rgm@gnu.org>
330
74cc8ff9
GM
331 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
332
7d8d6e4e
GM
333 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
334 Update template values to be closer to their typical values these days.
5b43da69 335
a0db8d43
EZ
3362012-01-09 Eli Zaretskii <eliz@gnu.org>
337
338 * xdisp.c (rows_from_pos_range): Accept additional argument
339 DISP_STRING, and accept any glyph in a row whose object is that
340 string as eligible for mouse highlight. Fixes mouse highlight of
341 display strings from overlays. (Bug#10464)
342
9a0115ab 3432012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 344
b9110d6a 345 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
346 * fileio.c (auto_saving_dir_umask): New static var.
347 (Fmake_directory_internal): Use it.
348 (do_auto_save_make_dir): Set it, instead of invoking chmod after
349 creating the directory. The old code temporarily assigns
350 too-generous permissions to the directory.
351 (do_auto_save_eh): Clear it.
b9110d6a 352 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
353 that the var is always cleared.
354
6c1bd3f3
EZ
3552012-01-07 Eli Zaretskii <eliz@gnu.org>
356
357 * search.c (scan_buffer): Pass character positions to
358 know_region_cache, not byte positions. (Bug#6540)
359
069d2b50
L
3602012-01-07 LynX <_LynX@bk.ru> (tiny change)
361
362 * w32.c (sys_rename): Report EXDEV when rename of a directory
363 fails because the target is on another logical disk. (Bug#10284)
364
75bf0d33
DB
3652012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
366
367 * xterm.c (x_embed_request_focus): New function.
368
369 * xterm.h: Add prototype.
370
371 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
372
1c6e5a32
GM
3732012-01-05 Glenn Morris <rgm@gnu.org>
374
375 * emacs.c (emacs_copyright): Update short copyright year to 2012.
376
651e947e
EZ
3772012-01-01 Eli Zaretskii <eliz@gnu.org>
378
379 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
380 Load gnutls_transport_set_lowat only if GnuTLS version is below
381 2.11.1.
382 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
383 GnuTLS versions below 2.11.1.
384
3778cdd8
AL
3852011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
386
387 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
388 to the doc string advising against its use for altering the way
389 windows are scrolled.
390
0e5317f7
KH
3912011-12-28 Kenichi Handa <handa@m17n.org>
392
393 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
394 coding-system ASCII compatible only when it does not produce BOM
395 on encoding (Bug#10383).
396
93d5ca1f
JD
3972011-12-26 Jan Djärv <jan.h.d@swipnet.se>
398
399 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
400 can scroll.
401 (create_and_show_popup_menu): Always use menu_position_func for
402 Gtk3 (Bug#10361).
403
ca22b785
AS
4042011-12-24 Andreas Schwab <schwab@linux-m68k.org>
405
406 * callint.c (Fcall_interactively): Don't truncate prompt string.
407
d048e1e6
EZ
4082011-12-23 Eli Zaretskii <eliz@gnu.org>
409
410 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
411 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 412 resumed from there (after widening). (Bug#10360)
d048e1e6 413
5ccaba1f
JD
4142011-12-22 Jan Djärv <jan.h.d@swipnet.se>
415
416 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
417
204ee57f
JD
4182011-12-21 Jan Djärv <jan.h.d@swipnet.se>
419
b81d40f0
JB
420 * nsterm.m (x_free_frame_resources):
421 Release f->output_data.ns->miniimage.
204ee57f
JD
422 (ns_index_color): Fix indentation. Do not retain
423 color_table->colors[i].
424
425 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
426 before returning.
427
428 * nsfns.m (x_set_background_color): Assign return value from
429 ns_index_color to face-background instead of NSColor*.
430 (ns_implicitly_set_icon_type): Fix indentation.
431 Change assignment in for loop to comparison.
432
433 * emacs.c (ns_pool): New variable.
434 (main): Assign ns_pool.
435 (Fkill_emacs): Call ns_release_autorelease_pool.
436
437 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
438 autorelease fdesc, release fdAttrs and tdict.
439 (ns_get_covering_families): Release charset.
440 (ns_findfonts): Release NSFontDescriptor created with new.
441 (ns_uni_to_glyphs): Fix indentation.
442 (setString): Release attrStr before assigning new value.
443
c803b2b7
JD
4442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
445
678f4426
JD
446 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
447 and NS_IMPL_COCOA.
448 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
449 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
450
cd394be1 4512011-12-18 David Reitter <reitter@cmu.edu>
678f4426 452
5fecd5fc
JD
453 * nsterm.m (ns_term_init): Subscribe for notifications
454 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
455 to method trackingNotification in EmacsMenu.
456
457 * nsmenu.m (trackingMenu): New variable.
3771cb17 458 (trackingNotification): New method (from Aquamacs).
5fecd5fc 459 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 460 from Aquamacs (Bug#7030).
678f4426
JD
461
4622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 463
c803b2b7
JD
464 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
465 (symbol_to_nsstring): Fix indentation.
466 (ns_symbol_to_pb): New function.
467 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
468 (Fns_rotate_cut_buffers_internal): Removed.
469 (Fns_store_selection_internal): Renamed from
470 Fns_store_cut_buffer_internal.
471 (ns_get_foreign_selection, Fx_own_selection_internal)
472 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
473 (Fns_get_selection_internal, Fns_store_selection_internal):
474 Use ns_symbol_to_pb and check if return value is nil.
475 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
476 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
477 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
478 renamed to Sns_store_selection_internal.
479 (ns_handle_selection_request): Move code to Fx_own_selection_internal
480 and remove this function.
481 (ns_handle_selection_clear): Remove, never used.
482 (Fx_own_selection_internal): Move code from ns_handle_selection_request
483 here.
484
e1b01a3a
KB
4852011-12-17 Ken Brown <kbrown@cornell.edu>
486
487 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
488 GID is unknown (Bug#10257).
489
2adb6e85
PE
4902011-12-17 Paul Eggert <eggert@cs.ucla.edu>
491
492 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
493 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
494 which caused a build failure on GNU/Linux IA-64. This problem was
495 introduced by my 2011-10-07 patch.
496
d1d7b339
JL
4972011-12-15 Juri Linkov <juri@jurta.org>
498
499 * image.c (imagemagick_error): New function. (Bug#10112)
500 (imagemagick_load_image): Comment out `MagickSetResolution' call.
501 Use `imagemagick_error' where ImageMagick functions return
502 `MagickFalse'.
503 (Fimagemagick_types): Add `Fnreverse' to return the list in the
504 proper order.
505
100d5755
KH
5062011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
507
508 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
509 fill background (Bug#8992).
510
454592a6
MR
5112011-12-13 Martin Rudalics <rudalics@gmx.at>
512
513 * window.c (Vwindow_combination_resize)
514 (Vwindow_combination_limit): Use t instead of non-nil in
515 doc-strings.
61d4b438
MR
516 (Vrecenter_redisplay): Add first sentence of doc-string on
517 separate line.
53524d93 518 (Frecenter): Fix doc-string typo.
454592a6 519
3633e3aa
KH
5202011-12-11 Kenichi Handa <handa@m17n.org>
521
522 * coding.c (Funencodable_char_position): Pay attention to the
523 buffer text relocation (Bug#9389).
524
7b9d523a
JD
5252011-12-10 Jan Djärv <jan.h.d@swipnet.se>
526
527 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
528 gtk_init (Bug#10100).
529
b73189c6
EZ
5302011-12-10 Eli Zaretskii <eliz@gnu.org>
531
532 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
533 IT->string is nil. (Bug#10263)
534
f7dfe5d6
JD
5352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
536
83faebb4
JD
537 * nsterm.h (x_free_frame_resources): Declare.
538
f7dfe5d6
JD
539 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
540 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
541
542 * nsterm.h (ns_get_defaults_value): Declare.
543
544 * nsterm.m (ns_default): Call ns_get_defaults_value.
545
7cd4e72c
EZ
5462011-12-09 Eli Zaretskii <eliz@gnu.org>
547
548 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
549 (Bug#10170)
550
b34d7317
YM
5512011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
552
553 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
554 that where the value of an _OBJC_* symbol points to is in the .bss
555 section (Bug#10240).
556
76470ad1
KH
5572011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
558
559 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 560 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 561
745fff94
KH
5622011-12-08 Kenichi Handa <handa@m17n.org>
563
564 * ftfont.c (get_adstyle_property): Fix previous change
565 (Bug#10233).
566
6e44397c
JB
5672011-12-07 Juanma Barranquero <lekktu@gmail.com>
568
569 * w32.c (init_environment): If no_site_lisp, remove site-lisp
570 dirs from the default value of EMACSLOADPATH (bug#10208).
571
7efa6272
GM
5722011-12-07 Glenn Morris <rgm@gnu.org>
573
574 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
575 installation and source directories as well. (Bug#10208)
576
f6fc4d87
CY
5772011-12-06 Chong Yidong <cyd@gnu.org>
578
579 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
580
2bf26180
GM
5812011-12-06 Glenn Morris <rgm@gnu.org>
582
583 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
584 as an error, not just -1. (Bug#10217)
585
3a6ad4f0
CY
5862011-12-05 Chong Yidong <cyd@gnu.org>
587
588 * keyboard.c (process_special_events): New function.
589 (swallow_events, Finput_pending_p): Use it (Bug#10195).
590
75a3b399
PE
5912011-12-05 Paul Eggert <eggert@cs.ucla.edu>
592
593 * coding.c (encode_designation_at_bol): Don't use uninitialized
594 local variable (Bug#9318).
595
c3c9e25e
KH
5962011-12-05 Kenichi Handa <handa@m17n.org>
597
598 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
599 return Qnil (Bug#8046, Bug#10193).
600
5eb05ea3
KH
6012011-12-05 Kenichi Handa <handa@m17n.org>
602
603 * coding.c (encode_designation_at_bol): New args charbuf_end and
604 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
605 (coding_set_source): Return how many bytes coding->source was
606 relocated.
607 (coding_set_destination): Return how many bytes
608 coding->destination was relocated.
609 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
610 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
611
6122011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
613
614 * coding.c (CODING_CHAR_CHARSET_P): New macro.
615 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
616 macro (Bug#9318).
617
6182011-12-05 Andreas Schwab <schwab@linux-m68k.org>
619
620 The following changes are to fix Bug#9318.
621
a79703f5 622 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
623 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
624 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 625 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 626
7dbda6df
JB
6272011-12-05 Juanma Barranquero <lekktu@gmail.com>
628
629 * lisp.h (process_quit_flag): Fix external declaration.
630
6d5eb5b0
SM
6312011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
632
633 Don't macro-inline non-performance-critical code.
634 * eval.c (process_quit_flag): New function.
635 * lisp.h (QUIT): Use it.
636
a0c3fad0
JD
6372011-12-04 Jan Djärv <jan.h.d@swipnet.se>
638
639 * nsfns.m (get_geometry_from_preferences): New function.
640 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
641
6c07aac2
AS
6422011-12-04 Andreas Schwab <schwab@linux-m68k.org>
643
644 * emacs.c (Qkill_emacs): Define.
645 (syms_of_emacs): Initialize it.
646 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
647 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
648 (quit_throw_to_read_char): Add parameter `from_signal'.
649 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
650 * lisp.h (QUIT): Call Fkill_emacs if requested.
651
c052ead4
JD
6522011-12-03 Jan Djärv <jan.h.d@swipnet.se>
653
654 * widget.c (update_wm_hints): Return if wmshell is null.
655 (widget_update_wm_size_hints): New function.
656
657 * widget.h (widget_update_wm_size_hints): Declare.
658
659 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
660 widget_update_wm_size_hints (Bug#10104).
661
9e49252b
EZ
6622011-12-03 Eli Zaretskii <eliz@gnu.org>
663
664 * xdisp.c (handle_invisible_prop): If the invisible text ends just
665 before a newline, prepare the bidi iterator for consuming the
666 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 667 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 668
02b16839
JL
6692011-12-02 Juri Linkov <juri@jurta.org>
670
671 * search.c (Fword_search_regexp): New Lisp function created from
672 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
673 (Fword_search_backward, Fword_search_forward)
674 (Fword_search_backward_lax, Fword_search_forward_lax):
675 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
676 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
677
0068070e
SM
6782011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
679
680 * fileio.c (Finsert_file_contents): Move after-change-function call
681 to before the "handled:" label, since all "goto handled" appear in
682 cases where the *-change-functions have already been properly called
683 (bug#10117).
684
3360a3fc
AS
6852011-12-01 Andreas Schwab <schwab@linux-m68k.org>
686
687 * keyboard.c (interrupt_signal): Don't call kill-emacs when
688 waiting for input. (Bug#10169)
689
73d6c093
EZ
6902011-11-30 Eli Zaretskii <eliz@gnu.org>
691
692 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
693 verifies glyph row's hash code--we have just reallocated the
694 glyphs, so their contents can be complete garbage. (Bug#10164)
695
febe6bea
JB
6962011-11-30 Juanma Barranquero <lekktu@gmail.com>
697
698 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
699
801a4313
EZ
7002011-11-30 Eli Zaretskii <eliz@gnu.org>
701
702 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
703 attributes are tested _before_ calling verify_row_hash, to protect
704 against GCC re-ordering of the tests. (Bug#10164)
705
2b56b87e
JD
7062011-11-29 Jan Djärv <jan.h.d@swipnet.se>
707
708 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
709
710 * xterm.c (handle_one_xevent): Only set async_visible and friends
711 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 712 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
713 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
714
dbf31225
PE
7152011-11-28 Paul Eggert <eggert@cs.ucla.edu>
716
717 Remove GCPRO-related macros that exist only to avoid shadowing locals.
718 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
719 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
720 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
721 All uses changed to use GCPRO1 etc.
722 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
723 Revert to old implementation (i.e., before 2011-03-11).
724
1305621b
YM
7252011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
726
727 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
728 of scroll runs so as to avoid assigning disabled bogus rows and
729 unnecessary graphics copy operations.
730
8c9afb46
EZ
7312011-11-27 Eli Zaretskii <eliz@gnu.org>
732
733 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
734 (snprintf) [_MSC_VER]: Redirect to _snprintf.
735 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
736 (malloc, free, realloc, calloc): Redirect to e_* only when
737 compiling Emacs.
738
739 * lisp.h (GCTYPEBITS): Move before first use.
740 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
741 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
742 this macro definition.
743
744 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
745 _MSC_VER.
746
54e9e3bf
JD
7472011-11-27 Jan Djärv <jan.h.d@swipnet.se>
748
6d5eb5b0
SM
749 * gtkutil.c (xg_create_frame_widgets):
750 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
751 present with Gtk+ 2.0.
752
83aca1cb
PE
7532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
754
755 * fileio.c (Finsert_file_contents): Undo previous change; see
756 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
757
5b76caa4
PE
7582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
759
760 Rename locals to avoid shadowing.
761 * fileio.c (Finsert_file_contents):
762 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
763 * process.c (wait_reading_process_output):
764 Rename inner 'proc' to 'p' to avoid shadowing.
765 Indent for consistency with usual Emacs style.
766
8c535114
EZ
7672011-11-25 Eli Zaretskii <eliz@gnu.org>
768
769 * xdisp.c (redisplay_window): If cursor row is not fully visible
770 after recentering, and scroll-conservatively is set to a large
771 number, scroll window by a few more lines to make the cursor fully
772 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
773 (start_display): Don't move to the next line if the display should
774 start at a newline that is part of a display vector or an overlay
775 string. (Bug#10119)
8c535114 776
fa4fdb5c
JL
7772011-11-24 Juri Linkov <juri@jurta.org>
778
779 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
780 after the `MagickPingImage' call. (Bug#10112)
781
90ec88df
CY
7822011-11-23 Chong Yidong <cyd@gnu.org>
783
784 * window.c (Fcoordinates_in_window_p): Accept only live windows.
785
56e2e794
MR
7862011-11-23 Martin Rudalics <rudalics@gmx.at>
787
788 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
789 making another buffer current. (Bug#10114)
790
b6e64c41
GM
7912011-11-23 Glenn Morris <rgm@gnu.org>
792
793 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
794
6b21de18
CY
7952011-11-23 Chong Yidong <cyd@gnu.org>
796
797 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
798 using it (Bug#5984).
799
b12cd789
EZ
8002011-11-22 Eli Zaretskii <eliz@gnu.org>
801
802 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
803 and header-lines, as they don't have one computed for them.
804 (Bug#10098)
805
806 * .gdbinit (prow): Make displayed values more self-explaining.
807 Add row's hash code.
808
261b6fd4
LMI
8092011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
810
811 * process.c (wait_reading_process_output): Fix asynchrounous
812 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 813 (wait_reading_process_output): Add comment and URL.
261b6fd4 814
e7cfd277
JD
8152011-11-21 Jan Djärv <jan.h.d@swipnet.se>
816
817 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
818
a9b9b7f5
CY
8192011-11-21 Chong Yidong <cyd@gnu.org>
820
821 * window.c (Fnext_window, Fprevious_window): Doc fix.
822
b0d15b4f
SM
8232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
824
825 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
826
fe7a3057
JB
8272011-11-20 Juanma Barranquero <lekktu@gmail.com>
828
829 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
830
d2999b1a
MR
8312011-11-20 Martin Rudalics <rudalics@gmx.at>
832
833 * window.c (Fset_window_combination_limit): Rename argument
834 STATUS to LIMIT.
835 (Vwindow_combination_limit): Remove "status" from doc-string.
836
d5ff9cd0
AS
8372011-11-20 Andreas Schwab <schwab@linux-m68k.org>
838
839 * m/ibms390.h: Remove.
840 * m/ibms390x.h: Don't include "ibms390.h".
841
a5bb9bd3
SM
8422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
845 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
846
cd1181db
JB
8472011-11-20 Juanma Barranquero <lekktu@gmail.com>
848
849 * casetab.c (Fset_case_table):
850 * charset.c (Fcharset_after): Fix typos.
851
615a3b8d 8522011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 853
17e845af
PE
854 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
855 Otherwise, valgrind does not work on some platforms.
856 Problem reported by Andreas Schwab in
6a0bf43d
PE
857 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
858 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
859 is set, removing the need for VIRT_ADDRESS_VARIES.
860 (PURE_P): Use a more-efficient implementation that needs just one
861 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
862 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
863 to 4 (xorl, subq, cmpq, setbe).
864 * alloc.c (pure): Always extern now, since that's the
865 VIRT_ADDR_VARIES behavior.
866 (PURE_POINTER_P): Use a single comparison, not two, for
867 consistency with the new puresize.h.
868 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
869 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
870 Remove VIRT_ADDR_VARIES no longer needed.
871
f8fe6f96
EZ
8722011-11-19 Eli Zaretskii <eliz@gnu.org>
873
874 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
875 (erase_phys_cursor, update_window_cursor, show_mouse_face)
876 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
877 behave as if the cursor position were at the window margin.
878
879 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
880 and the cursor position is out of bounds, behave as if the cursor
881 position were at the window margin. (Bug#10075)
882
df05a53c
CY
8832011-11-18 Chong Yidong <cyd@gnu.org>
884
885 * window.c (Fwindow_combination_limit): Make first argument
886 non-optional, since it is meaningless for live windows like the
887 selected window.
888
2071918e
DA
8892011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
890
891 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
892
b50a28de
SM
8932011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
894
895 * intervals.c: Fix grafting over the whole buffer (bug#10071).
896 (graft_intervals_into_buffer): Simplify.
897
015137db
EZ
8982011-11-18 Eli Zaretskii <eliz@gnu.org>
899
900 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
901 hash values of the two rows.
902 (copy_row_except_pointers): Preserve the used[] arrays and the
903 hash values of the two rows. (Bug#10035)
68c95424 904 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
905
906 * xdisp.c (row_hash): New function, body extracted from
907 compute_line_metrics.
908 (compute_line_metrics): Call row_hash, instead of computing the
909 hash code inline.
910
911 * dispnew.c (verify_row_hash): Call row_hash for computing the
912 hash code of a row, instead of duplicating code from xdisp.c.
913
914 * dispextern.h (row_hash): Add prototype.
915
a2addb04
TH
9162011-11-18 Tassilo Horn <tassilo@member.fsf.org>
917
918 * frame.c (delete_frame): Don't delete the terminal when the last
919 X frame is closed if emacs is built with GTK toolkit.
920
df85d315
JB
9212011-11-17 Juanma Barranquero <lekktu@gmail.com>
922
923 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
924
a0c2d0ae
MR
9252011-11-17 Martin Rudalics <rudalics@gmx.at>
926
927 * window.c (Vwindow_splits): Rename to
928 Vwindow_combination_resize. Suggested by Juri Linkov.
929 (Fsplit_window_internal): Use Vwindow_combination_resize instead
930 of Vwindow_splits.
931
58179cce
JB
9322011-11-16 Juanma Barranquero <lekktu@gmail.com>
933
7877f373
JB
934 * nsfns.m (Fns_font_name):
935 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 936
b6f67890
MR
9372011-11-16 Martin Rudalics <rudalics@gmx.at>
938
939 * window.h (window): Rename slot "nest" to "combination_limit".
940 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
941 (Fset_window_nest): Rename to Fset_window_combination_limit.
942 (Vwindow_nest): Rename to Vwindow_combination_limit.
943 (recombine_windows, make_parent_window, make_window)
944 (Fsplit_window_internal, saved_window)
945 (Fset_window_configuration, save_window_save): Rename all
946 occurrences of window_nest to window_combination_limit.
947
c7015153
JB
9482011-11-15 Juanma Barranquero <lekktu@gmail.com>
949
950 * image.c (imagemagick_load_image): Fix typo.
951
322ad6ec
EZ
9522011-11-14 Eli Zaretskii <eliz@gnu.org>
953
954 * xdisp.c (display_line): Move the call to
955 highlight_trailing_whitespace before the call to
956 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
957 faces of all the glyphs to compute ROW's hash value.
958 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 959
f067b8ec
JB
9602011-11-14 Juanma Barranquero <lekktu@gmail.com>
961
962 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
963 just return (bug#10044).
964
1e5b2111
EZ
9652011-11-12 Eli Zaretskii <eliz@gnu.org>
966
7ef3cbd5
EZ
967 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
968 with user-defined heap size. Bump the default size of the temacs
969 heap to 27MB, to avoid memory warning when running temacs.
970 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
971
1e5b2111
EZ
972 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
973 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
974 (verify_row_hash) [XASSERTS]: New function.
975 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
976 that the hash value of glyph rows is correct.
1e5b2111 977
89d61221
MR
9782011-11-12 Martin Rudalics <rudalics@gmx.at>
979
980 * window.h (window): Remove splits slot.
981 * window.c (Fwindow_splits, Fset_window_splits): Remove.
982 (Fdelete_other_windows_internal, make_parent_window)
983 (make_window, Fsplit_window_internal, Fdelete_window_internal)
984 (Fset_window_configuration, save_window_save): Don't deal with
985 split status of windows.
986 (saved_window): Remove splits slot.
987 (Vwindow_splits): Rewrite doc-string.
988
97f18cc8
JD
9892011-11-11 Jan Djärv <jan.h.d@swipnet.se>
990
991 * xfns.c (unwind_create_frame):
992 * nsfns.m (unwind_create_frame):
993 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
994 Vframe_list (Bug#9999).
995
22a648b4
DA
9962011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
997
0b381c7e 998 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 999
659afede
KH
10002011-11-11 Kenichi Handa <handa@m17n.org>
1001
1002 * callproc.c (Fcall_process): Set the member dst_multibyte of
1003 process_coding.
1004
9ac0394b
KH
10052011-11-11 Johan Bockgård <bojohan@gnu.org>
1006
1007 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1008 avoid a crash (bug#9496).
1009
2fbdc249
CY
10102011-11-09 Chong Yidong <cyd@gnu.org>
1011
1012 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1013 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1014
ac6b1f81
PE
10152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1018
09db192c
PE
10192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 Avoid some portability problems by eschewing 'extern inline' functions.
1022 The trivial performance wins aren't worth the portability hassles; see
1023 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1024 et seq.
1025 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1026 (window_box_width, window_box_left, window_box_left_offset)
1027 (window_box_right, window_box_right_offset): Undo previous change,
1028 by removing the "extern"s.
1029 * intervals.c (adjust_intervals_for_insertion)
1030 (adjust_intervals_for_deletion): Undo previous change,
1031 making these static again.
1032 (offset_intervals, temp_set_point_both, temp_set_point)
1033 (copy_intervals_to_string): No longer inline.
1034 * xdisp.c (window_text_bottom_y, window_box_width)
1035 (window_box_height, window_box_left_offset)
1036 (window_box_right_offset, window_box_left, window_box_right)
1037 (window_box): No longer inline.
1038
105216ed
CY
10392011-11-08 Chong Yidong <cyd@gnu.org>
1040
1041 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1042 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1043 Signal an error if not a live window.
105216ed
CY
1044 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1045 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1046
ae9e237f
JB
10472011-11-07 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * lisp.h (syms_of_abbrev): Remove declaration.
1050 Reported by CHENG Gao <chenggao@royau.me>.
1051
c7aa8333
EZ
10522011-11-07 Eli Zaretskii <eliz@gnu.org>
1053
1054 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1055 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1056 of temacs in GUI mode.
1057
be7f5545
MR
10582011-11-07 Martin Rudalics <rudalics@gmx.at>
1059
1060 * window.h: Declare delete_all_child_windows instead of
1061 delete_all_subwindows.
1062 * window.c (Fwindow_nest, Fset_window_nest)
1063 (Fset_window_new_total, Fset_window_new_normal)
1064 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1065 (delete_all_subwindows): Rename to delete_all_child_windows.
1066 (Fdelete_other_windows_internal, Fset_window_configuration):
1067 Call delete_all_child_windows instead of delete_all_subwindows.
1068 * frame.c (delete_frame): Call delete_all_child_windows instead
1069 of delete_all_subwindows.
1070
ca78dc43
PE
10712011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1074 This is also needed for porting to any host where GC_MARK_STACK is
1075 not GC_MAKE_GCPROS_NOOPS.
1076 (which_symbols): Use it.
1077
a0241d01
KH
10782011-11-07 Kenichi Handa <handa@m17n.org>
1079
1080 * coding.c (coding_set_destination): Check coding->src_pos only
1081 when coding->src_object is a buffer (bug#9910).
1082
1083 * process.c (send_process): Set the member src_multibyte of coding
1084 to 0 (bug#9911) when sending a unibyte text.
1085
1086 * callproc.c (Fcall_process): Set the member src_multibyte of
1087 process_coding to 0 (bug#9912).
1088
a64bfdfa 10892011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1090
1091 * xmenu.c (cleanup_widget_value_tree): New function.
1092 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1093 calling free_menubar_widget_value_tree directly (Bug#9830).
1094
cb41b32a
PE
10952011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 Fix some portability problems with 'inline'.
1098 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1099 (window_box_width, window_box_left, window_box_left_offset)
1100 (window_box_right, window_box_right_offset): Declare extern.
1101 Otherwise, these inline functions do not conform to C99 and
1102 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1103 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1104 * intervals.c (adjust_intervals_for_insertion)
1105 (adjust_intervals_for_deletion): Now extern, because otherwise the
1106 extern inline functions 'offset_intervals' couldn't refer to it.
1107 (static_offset_intervals): Remove.
1108 (offset_intervals): Rewrite using the old contents of
1109 static_offset_intervals. The old version didn't conform to C99
1110 because an extern inline function contained a reference to an
1111 identifier with static linkage.
1112
b7041366
AS
11132011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1114
1115 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1116 GC.
1117
88a37c4d
EZ
11182011-11-06 Eli Zaretskii <eliz@gnu.org>
1119
1120 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1121 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1122 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1123 return Qleft_to_right.
1124
49745b39
CY
11252011-11-06 Chong Yidong <cyd@gnu.org>
1126
1127 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1128 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1129 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1130 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1131 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1132 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1133 (Fwindow_vscroll): Doc fix.
1134 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1135 argument, since it makes no sense to pass a live window and for
1136 consistency with window-child.
1137
1f05cd82
CS
11382011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1139
1140 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1141 support MSVC.
1142
22610910
JR
11432011-11-05 Jason Rumney <jasonr@gnu.org>
1144
1145 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1146 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1147 fonts (Bug#6029).
1148 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1149 bitwise arithmetic preventing use of unicode-sip and non-truetype
1150 opentype fonts.
1151
a06776b2
EZ
11522011-11-05 Eli Zaretskii <eliz@gnu.org>
1153
3ad924ba
EZ
1154 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1155 "emacs"-only part.
1156
a06776b2
EZ
1157 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1158 initialization code to keep similarity to xfns.c after changes
1159 from 2011-11-05.
1160
c9e7db78
JD
11612011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1162
a97f8f3f
JD
1163 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1164 (unwind_create_frame): New function (Bug#9943).
1165 (Fx_create_frame): Restructure code to be more similar to the one in
1166 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1167 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1168 Move terminal->reference_count++ just before making the frame official
1169 (Bug#9943).
1170
1171 * nsterm.m (x_free_frame_resources): New function.
1172 (x_destroy_window): Move code to x_free_frame_resources.
1173
c9e7db78 1174 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1175 (Fx_create_frame, x_create_tip_frame):
1176 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1177 official. Move initialization of image_cache_refcount and
1178 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1179
a6fc3b5c
EZ
11802011-11-05 Eli Zaretskii <eliz@gnu.org>
1181
1182 Support MSVC build with newer versions of Visual Studio.
1183 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1184 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1185 nt/gmake.defs.
1186
1187 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1188 which are not supported by MSVC.
1189 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1190 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1191 bitfields.
1192 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1193 types in bitfields.
1194 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1195
1196 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1197
58179cce 11982011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1199
1200 Support MSVC build with newer versions of Visual Studio.
1201 * w32.c: Don't include w32api.h for MSVC.
1202 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1203
1204 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1205 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1206 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1207 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1208 e_* cousins.
1209 (alloca) [_MSC_VER]: Define to _alloca.
1210
1211 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1212
1213 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1214
a58c13ed
EZ
12152011-11-04 Eli Zaretskii <eliz@gnu.org>
1216
1217 * xdisp.c (note_mouse_highlight): If either of
1218 previous/next-single-property-change returns nil, treat that as
1219 the beginning or the end of the buffer. (Bug#9955)
1220
fe0b6370
JD
12212011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1222
a58c13ed 1223 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1224 label is not null (Bug#9951).
1225 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1226 may be NULL.
1227
89bd5ee1
EZ
12282011-11-04 Eli Zaretskii <eliz@gnu.org>
1229
1230 * window.c (Fwindow_body_size): Mention in the doc string that the
1231 return value is in frame's canonical units. (Bug#9949)
1232
84c3edb9
EZ
12332011-11-03 Eli Zaretskii <eliz@gnu.org>
1234
4e2fb5c7
EZ
1235 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1236
84c3edb9 1237 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1238 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1239 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1240
bc17a887
EZ
12412011-11-01 Eli Zaretskii <eliz@gnu.org>
1242
1243 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1244 Don't stop backward scan on the continuation glyph, even though
1245 its CHARPOS is positive.
6d5eb5b0
SM
1246 (mouse_face_from_buffer_pos, note_mouse_highlight):
1247 Rename cover_string to disp_string.
bc17a887 1248
4ee88440
MR
12492011-11-01 Martin Rudalics <rudalics@gmx.at>
1250
1251 * window.c (temp_output_buffer_show): Don't use
1252 Vtemp_buffer_show_specifiers.
1253 (Vtemp_buffer_show_specifiers): Remove unused variable.
1254
c2ff3c02
EZ
12552011-10-30 Eli Zaretskii <eliz@gnu.org>
1256
1257 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1258 past the beginning of the current glyph matrix.
1259
58179cce 12602011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1261
1262 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1263 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1264 HAVE_GTK3 (Bug#9869).
b77a6a7f 1265
3b574623
JD
1266 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1267 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1268
b77a6a7f
JD
1269 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1270
1271 * xterm.c: Declare x_handle_net_wm_state to return int.
1272 (handle_one_xevent): Check if we are iconified but don't have
1273 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1274 (get_current_wm_state): Return non-zero if not hidden,
1275 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1276 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1277 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1278 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1279
196e41e4
PE
12802011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1283 so that this new function doesn't get optimized away by a
1284 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1285
021f2e1a
AS
12862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1287
1288 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1289
8b058d44
EZ
12902011-10-29 Eli Zaretskii <eliz@gnu.org>
1291
1292 Fix the `xbytecode' command.
1293 * .gdbinit (xprintbytestr): New command.
b50a28de 1294 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1295 (xbytecode): Print the byte-code string as well.
1296
4452fb80
EZ
12972011-10-29 Kim Storm <storm@cua.dk>
1298
8b058d44
EZ
1299 * alloc.c (which_symbols): New function.
1300
21b72067
AS
13012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1302
1303 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1304 line. (Bug#9903)
1305
83ed7b5c
GM
13062011-10-29 Glenn Morris <rgm@gnu.org>
1307
1308 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1309 Not clear what it was for, and it causes various bugs. (Bug#9839)
1310
5a7a728b
EZ
13112011-10-28 Eli Zaretskii <eliz@gnu.org>
1312
1313 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1314 possible random value that matches one of those tested as
1315 condition to clear the mouse face.
1316
d3d0842f
CY
13172011-10-28 Chong Yidong <cyd@gnu.org>
1318
1319 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1320
31b39d13
DN
13212011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1322
1323 * window.c (make_window): Initialize phys_cursor_on_p.
1324
9aba6043
SM
13252011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1326
1327 * lisp.h (struct Lisp_Symbol): Update comments.
1328
c20992f4
JB
13292011-10-28 Juanma Barranquero <lekktu@gmail.com>
1330
1331 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1332
db4f02f2
EZ
13332011-10-28 Eli Zaretskii <eliz@gnu.org>
1334
1335 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1336 <oslsachem@gmail.com> for helping to debug this.
1337
1338 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1339 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1340 (g_b_init_get_glyph_outline_w): New static variables.
1341 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1342 (GetGlyphOutlineW_Proc): New typedefs.
1343 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1344 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1345 New functions.
1346 (w32font_open_internal, compute_metrics):
1347 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1348 instead of calling the "wide" APIs directly.
1349
1350 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1351
1352 * w32.h (syms_of_w32font): Add prototype.
1353
87e68db4
JB
13542011-10-27 Juanma Barranquero <lekktu@gmail.com>
1355
1356 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1357 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1358 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1359 (Fmove_to_window_line): Doc fix.
1360
435c1d67
CY
13612011-10-27 Chong Yidong <cyd@gnu.org>
1362
1363 * process.c (make_process): Set gnutls_state to NULL.
1364
1365 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1366 non-NULL, regardless of GNUTLS_INITSTAGE.
1367 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1368 an error. Set process slots as soon as we allocate them.
1369
1370 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1371
9c6c6f49
CY
13722011-10-27 Chong Yidong <cyd@gnu.org>
1373
9aba6043
SM
1374 * gnutls.c (emacs_gnutls_deinit): New function.
1375 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1376 (Fgnutls_deinit, Fgnutls_boot): Use it.
1377
1378 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1379 (deactivate_process): Call emacs_gnutls_deinit.
1380
657d08d3
JB
13812011-10-27 Juanma Barranquero <lekktu@gmail.com>
1382
1383 * image.c (x_create_x_image_and_pixmap):
1384 * w32.c (sys_rename, w32_delayed_load):
1385 * w32font.c (fill_in_logfont):
1386 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1387
5430d399
JB
13882011-10-26 Juanma Barranquero <lekktu@gmail.com>
1389
1390 * w32fns.c (w32_default_color_map): New function,
1391 extracted from Fw32_default_color_map.
a7ef684b 1392 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1393
fe0055fa
PE
13942011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1395
1396 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1397
e6346438
SM
13982011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1399
1400 * keyboard.c (test_undefined): New function (bug#9751).
1401 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1402
e112cc37
ET
14032011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1404
1405 * sysdep.c (init_sys_modes): Fix the check for the controlling
1406 terminal (Bug#6649).
1407
7b5d6677
EZ
14082011-10-20 Eli Zaretskii <eliz@gnu.org>
1409
1410 * dispextern.h (struct bidi_it): New member next_en_type.
1411
1412 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1413 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1414 current character, check also for next_en_type being WEAK_EN.
1415 (bidi_resolve_weak): Don't enter the expensive loop if the current
1416 position is before next_en_pos. Record the bidi type of the first
1417 non-ET, non-BN character we find, in addition to its position.
1418 (bidi_level_of_next_char): Invalidate next_en_type when
1419 next_en_pos is over-stepped.
1420
7da0b018
PE
14212011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1424 * editfns.c: Rewrite current-time-zone so that it invokes
1425 the equivalent of (format-time-string "%Z") to get the time zone name.
1426 This fixes a bug when the time zone name contains characters that
1427 need converting from the system time locale to Emacs internal format.
1428 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1429 that patch fixed format-time-string to do the conversion, but
1430 I forgot to fix current-time-zone.
1431 (format_time_string): New function, containing most of
1432 what Fformat_time_string used to contain.
1433 (Fformat_time_string): Rewrite in terms of format_time_string.
1434 This doesn't change this function's behavior.
1435 (current-time-zone): Rewrite to use format_time_string.
1436 This fixes the bug reported by Michael Schierl in
1437 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1438 Jason Rumney's 2007-06-07 change worked around this bug, but
1439 didn't fix it.
1440 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1441
8547b010
EZ
14422011-10-19 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (start_display): If the character at POS is displayed
1445 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1446 (try_window_reusing_current_matrix): If a line ends in a display
1447 vector or the next line starts in a display vector, continue
1448 redrawing the window even though the character position of
1449 start_row was reached.
8547b010
EZ
1450 (Bug#9771, part 2)
1451
4e948d15
CY
14522011-10-18 Chong Yidong <cyd@gnu.org>
1453
1454 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1455 with nobreak-char-display too.
1456
4787455f
EZ
14572011-10-18 Eli Zaretskii <eliz@gnu.org>
1458
1459 Fix part 3 of bug#9771.
1460 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1461 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1462 non-neutral characters if the current character is a paragraph
1463 separator (a.k.a. Newline). This avoids running the same
1464 expensive loop twice, once when we consume the preceding newline
1465 and the other time when the line actually needs to be displayed.
1466 Avoid the loop when we see neutrals on the base embedding level
1467 following a character whose directionality is the same as the
1468 paragraph's. This avoids running the expensive loop when a line
1469 ends in a long sequence of neutrals, like control characters.
1470 Add assertion against STRONG_AL type. Slightly rearrange code
1471 that determines the type of a neutral given the first non-neutral
1472 that follows it.
1473 (bidi_level_of_next_char): Set next_en_pos to zero when
1474 invalidating its info.
1475
2c91f553
EZ
14762011-10-17 Eli Zaretskii <eliz@gnu.org>
1477
1478 * xdisp.c (push_display_prop): Determine whether to record string
1479 or buffer position by IT->string, not by IT->method. Allow
1480 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1481 (move_it_vertically_backward): Don't look for character position
1482 immediately after the newline when in a continuation line.
1483 (Bug#9771, part 1)
2c91f553 1484
c7b08b0d
MR
14852011-10-15 Martin Rudalics <rudalics@gmx.at>
1486
1487 * window.c (coordinates_in_window): Rewrite and delabelize
1488 vertical border check. (Bug#5357) (Bug#9618)
1489
6b02f655
SM
14902011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1491
1492 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1493 errors in XSetWindowBorder (bug#9310).
1494
81d40c92
DA
14952011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1496
1497 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1498 avoid crash when xmalloc overrun checking is enabled.
1499
d4172c3b
EZ
15002011-10-13 Eli Zaretskii <eliz@gnu.org>
1501
1502 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1503 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1504 cursor motion with <left> and <right> arrow keys.
1505
1506 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1507 some callers set that themselves.
1508
b00eea75
EZ
15092011-10-12 Eli Zaretskii <eliz@gnu.org>
1510
1511 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1512 display string and the previous row comes from the same string and
1513 is empty. (Bug#9739) (Bug#9738)
1514
8fe012c4
SM
15152011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1516
1517 * doc.c (get_doc_string): Encode file name (bug#9735).
1518
0074aef2
EZ
15192011-10-12 Eli Zaretskii <eliz@gnu.org>
1520
79beb178
EZ
1521 * bidi.c (bidi_level_of_next_char):
1522 * xdisp.c (get_visually_first_element): Remove old incorrect
1523 comments regarding the Unicode Line Separator character.
1524
0074aef2
EZ
1525 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1526
6e4b3fbe
DA
15272011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1528
1529 * alloc.c (Fgc_status): Do not access beyond zombies array
1530 boundary if nzombies > MAX_ZOMBIES.
1531 * alloc.c (dump_zombies): Add missing format specifier.
1532
0324f3af
PE
15332011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1534
b5525cac
PE
1535 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1536 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1537
0324f3af
PE
1538 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1539 Some packages use them to denote characters with modifiers.
1540
e9b5f888
AS
15412011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1542
1543 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1544 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1545 matching a pp-number. Rename parameter var to var1.
1546
127827c0
SM
15472011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1548
1549 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1550
c8fd3bd0
GM
15512011-10-08 Glenn Morris <rgm@gnu.org>
1552
1553 * callint.c (Fcall_interactively): Give a more explicit error for the
1554 'c' case with a non-character input. (Bug#8479)
1555
352ec8ff
EZ
15562011-10-08 Eli Zaretskii <eliz@gnu.org>
1557
03669ccb
EZ
1558 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1559 lines.
7061c986
EZ
1560 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1561 lines that are hscrolled on the left.
03669ccb 1562
352ec8ff
EZ
1563 * dispnew.c (buffer_posn_from_coords): Account for a possible
1564 presence of header-line. (Bug#4426)
1565
a66cfb1c
SM
15662011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1567
6b02f655
SM
1568 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1569 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1570
7c5ee88e
PE
15712011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1574 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1575 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1576 this makes Emacs dump core during garbage collection on rare
1577 occasions. sizeof is obviously inferior to offsetof here, so
1578 stick with offsetof.
1579 (GC_POINTER_ALIGNMENT): New macro.
1580 (mark_memory): Omit 3rd (offset) arg; caller changed.
1581 Don't assume EMACS_INT alignment is the same as pointer alignment.
1582
df1bbe5b
SM
15832011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1584
1585 * keyboard.c (read_key_sequence_remapped): New var.
1586 (read_key_sequence): Compute remapping in the right buffer.
1587 (command_loop_1): Use read_key_sequence's remapping directly.
1588
51553db6
SM
15892011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1590
32c1fffd
SM
1591 * dired.c (file_name_completion): Don't expand file name.
1592 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1593 before checking file name handler.
1594
51553db6
SM
1595 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1596 they've been requested explicitly (bug#9591).
1597
b6bd1599 15982011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1599
1600 * keymap.c (Fsingle_key_description): Use make_specified_string
1601 instead of build_string to build string from push_key_description.
1602 (Bug#5193)
1603
f701dc2a
PE
16042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1605
4222c55d
PE
1606 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1607 This fixes a Y2038 bug on 64-bit hosts.
1608 * buffer.c (reset_buffer):
1609 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1610 (Fclear_buffer_auto_save_failure):
1611 Use 0, not -1, to represent an unset failure time, since time_t
1612 might not be signed.
1613
f701dc2a
PE
1614 Remove dependency on glibc malloc internals.
1615 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1616 Move back here from lisp.h, but with their new implementations.
1617 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1618 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1619 * charset.c (charset_table_init): New static var.
1620 (syms_of_charset): Use it instead of xmalloc. This removes a
1621 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1622 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1623 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1624 Move back to alloc.c.
1625 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1626 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1627
9ceebf39
JD
16282011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1629
1630 * nsterm.m (windowDidResize): Call x_set_window_size only when
1631 ns_in_resize is true. Otherwise set pixelwidth/height and
1632 call change_frame_size (Bug#9628).
1633
cb993c58
PE
16342011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1635
3930c88b
PE
1636 Port --enable-checking=all to Fedora 14 x86-64.
1637 * charset.c (syms_of_charset): Also account for glibc malloc's
1638 internal overhead when calculating the initial malloc maximum.
1639
cb993c58
PE
1640 Port --enable-checking=all to Fedora 14 x86.
1641 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1642 Move to lisp.h.
1643 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1644 (overrun_check_realloc, overrun_check_free):
1645 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1646 That way, xmalloc returns a properly-aligned pointer even if
1647 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1648 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1649 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1650 into account when calculating the initial malloc maximum.
1651 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1652 Move here from alloc.c, so that charset.c can use it too.
1653 Properly align; the old code wasn't right for common 32-bit hosts
1654 when configured with --enable-checking=all.
1655 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1656 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1657
31bed486
EZ
16582011-09-29 Eli Zaretskii <eliz@gnu.org>
1659
04c70788 1660 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1661 use EDOM.
1662
fbcaa2f3
EZ
16632011-09-28 Eli Zaretskii <eliz@gnu.org>
1664
1665 * xdisp.c (compute_display_string_end): If there's no display
1666 string at CHARPOS, return -1.
1667
1668 * bidi.c (bidi_fetch_char): When compute_display_string_end
1669 returns a negative value, treat the character as a normal
1670 character not covered by a display string. (Bug#9624)
1671
a239d4e9
JB
16722011-09-28 Juanma Barranquero <lekktu@gmail.com>
1673
1674 * lread.c (Fread_from_string): Fix typo in docstring.
1675
88652fd5
EZ
16762011-09-27 Eli Zaretskii <eliz@gnu.org>
1677
1678 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1679 newline, reseat the iterator instead of bidi-iterating there one
1680 character at a time. (Bug#9610)
32c1fffd
SM
1681 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1682 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1683
ed497dd4
AS
16842011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1685
1686 * lread.c (readevalloop): Use correct code for NBSP.
1687 (read1): Likewise. (Bug#9608)
1688
b2bf61aa
MA
16892011-09-25 Michael Albinus <michael.albinus@gmx.de>
1690
1691 * dbusbind.c (Fdbus_register_signal): When service is not
1692 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1693
32bbb17c
GM
16942011-09-25 Glenn Morris <rgm@gnu.org>
1695
1696 * buffer.c (truncate-lines): Doc fix.
1697
94e0933e
CY
16982011-09-24 Chong Yidong <cyd@stupidchicken.com>
1699
1700 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1701 (Fset_window_next_buffers): Doc fix.
1702
cddde921
GM
17032011-09-24 Glenn Morris <rgm@gnu.org>
1704
1705 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1706
1260aef1
PE
17072011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1708
25b4bfa0
PE
1709 Fix minor problems found by static checking.
1710 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1711 * indent.c (Fvertical_motion): Fix == vs = typo.
1712
e3cbd34b
EZ
17132011-09-24 Eli Zaretskii <eliz@gnu.org>
1714
a66cfb1c
SM
1715 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1716 Default value is now t. Doc fix.
6bf7006f 1717
e3cbd34b 1718 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1719 logic when moving up, not only when moving down. Fix the
e3cbd34b 1720 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1721 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1722
1723 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1724 CHARPOS is covered by a display string which includes newlines.
1725 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1726 is covered by a display string with embedded newlines.
1727
a3de0cbd
MA
17282011-09-24 Michael Albinus <michael.albinus@gmx.de>
1729
1730 * dbusbind.c (Fdbus_register_signal): Add match rule to
1731 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1732 (Fdbus_register_method, Vdbus_registered_objects_table):
1733 Fix docstring.
a3de0cbd 1734
b260039d
JM
17352011-09-24 Jim Meyering <meyering@redhat.com>
1736
32c1fffd 1737 do not ignore write error for any output size
b260039d
JM
1738 The previous change was incomplete.
1739 While it makes emacs --batch detect the vast majority of stdout
1740 write failures, errors were still ignored whenever the output size is
1741 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1742 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1743 && echo FAIL: ignored write error
1744 FAIL: ignored write error
1745 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1746 && echo FAIL: ignored write error
1747 FAIL: ignored write error
1748 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1749
8eca8a7c
AS
17502011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1751
1752 * emacs.c (Fkill_emacs): In noninteractive mode exit
1753 non-successfully if a write error occurred on stdout. (Bug#9574)
1754
3341db62
EZ
17552011-09-21 Eli Zaretskii <eliz@gnu.org>
1756
1757 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1758 the xassert test.
1759
1760 * dispextern.h (struct it): Update the comment documenting what
1761 can it->OBJECT be.
1762
8c203dbf
EZ
17632011-09-20 Eli Zaretskii <eliz@gnu.org>
1764
1765 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1766 a display string, extend search for cursor position to end of row.
1767 (find_row_edges): If the row ends in a newline from a display
1768 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1769 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1770 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1771 non-empty line. Fixes confusing cursor motion with arrow keys at
1772 the beginning of a line that starts with whitespace.
8c203dbf 1773
a4824228
LMI
17742011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1775
1776 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1777 (bug#9493).
1778
33ed493b
CY
17792011-09-18 Chong Yidong <cyd@stupidchicken.com>
1780
1781 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1782 boolean (Bug#9154).
1783
56cd55c8
EZ
17842011-09-18 Eli Zaretskii <eliz@gnu.org>
1785
1786 * xdisp.c (display_line): Record maximum and minimum buffer
1787 positions even if no glyphs were produced (e.g., by a zero-width
1788 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1789 buffer positions that will be removed from the glyph row because
1790 they don't fit.
c02dcedf
EZ
1791 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1792 column is beyond frame width: don't subtract 1 "pixel" when
1793 computing width of the stretch.
3e62b7e0
EZ
1794 (reseat_at_next_visible_line_start): Undo the change made on
1795 2011-09-17 that saved paragraph information and restored it after
1796 the call to `reseat'. (Bug#9545)
56cd55c8 1797
5ed99d36 17982011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1799
1800 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1801 and turn window cursor on if cleared (Bug#9415).
1802
5ed99d36 18032011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1804
1805 * search.c (boyer_moore): Take unibyte characters from pattern
1806 literally. (Bug#9458)
1807
9bade7b2
EZ
18082011-09-18 Eli Zaretskii <eliz@gnu.org>
1809
1810 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1811
e5e9d610
PE
18122011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1813
87e4427a
PE
1814 Fix minor problem found by static checking.
1815 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1816 initialized, to pacify gcc -Wuninitialized.
1817
e5e9d610
PE
1818 * fileio.c: Report proper errno when syscall falls.
1819 (Finsert_file_contents): Save and restore errno,
1820 so that report_file_error outputs the correct diagnostic.
1821 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1822
a1674f0b
EZ
18232011-09-18 Eli Zaretskii <eliz@gnu.org>
1824
1825 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1826
fbfb6dd4
EZ
18272011-09-17 Eli Zaretskii <eliz@gnu.org>
1828
1829 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1830 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1831
bb187662
EZ
18322011-09-17 Eli Zaretskii <eliz@gnu.org>
1833
1137e8b8 1834 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1835 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1836
1837 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1838 (bidi_find_paragraph_start): Search back for paragraph beginning
1839 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1840 (bidi_move_to_visually_next): Only trigger paragraph-related
1841 computations when the last character is a newline or at EOB, not
1842 just any NEUTRAL_B. (Bug#9470)
1843
bb187662
EZ
1844 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1845 truncated lines if point is covered by a display string. (Bug#9524)
1846
2e621251
PE
18472011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1850 (cons_to_x_long): New function.
1851 (lisp_data_to_selection_data): Use it. Correct the test for
1852 short-versus-long data; it was negated. Break out of vector
1853 loop, for efficiency, when a long datum is discovered.
1854
91a15bc6
SM
18552011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1856
1857 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1858
b41c3a35
EZ
18592011-09-16 Eli Zaretskii <eliz@gnu.org>
1860
1861 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1862 GCC PR/17406) by declaring this function with external scope.
1863
7812ba2d
PE
18642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1865
1866 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1867 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1868
cf7edc2a
AS
18692011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1870
1871 * editfns.c (Fformat): Correctly handle text properties on "%%".
1872
bd01620e
EZ
18732011-09-15 Eli Zaretskii <eliz@gnu.org>
1874
1875 * xterm.c (x_draw_composite_glyph_string_foreground):
1876 * w32term.c (x_draw_composite_glyph_string_foreground):
1877 * term.c (encode_terminal_code):
1878 * composite.c (composition_update_it, get_composition_id):
1879 * xdisp.c (get_next_display_element)
1880 (fill_composite_glyph_string): Add comments about special meaning
1881 of TAB characters in a composition.
1882
a02719a3
PE
18832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1886 This occurs when processing a multibyte format.
1887 Problem reported by Wolfgang Jenker.
a02719a3 1888
72589a3c
JB
18892011-09-15 Johan Bockgård <bojohan@gnu.org>
1890
1891 * xdisp.c (try_cursor_movement): Only check for exact match if
1892 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1893
1c14176c
PE
18942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1895
1896 Remove unused external symbols.
1897 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1898 * xdisp.c (calc_pixel_width_or_height): Now static.
1899 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1900 * indent.c (check_display_width):
1901 * w32term.c: Fix comment to match code.
1902 * xterm.c, xterm.h (x_catching_errors): Remove.
1903
d2eea5b5
PE
19042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 * xselect.c: Use signed conversions more consistently (Bug#9498).
1907 (selection_data_to_lisp_data): Assume incoming selection data are
1908 signed integers, not unsigned. This is to be consistent with
1909 outgoing selection data, which was modified to use signed integers
1910 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1911 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1912 expects long, not unsigned long.
1913
46888499
EZ
19142011-09-14 Eli Zaretskii <eliz@gnu.org>
1915
1916 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1917 computation of loop end. Reported by Johan Bockgård
1918 <bojohan@gnu.org>.
1919
ef8ef9fb
CY
19202011-09-13 Chong Yidong <cyd@stupidchicken.com>
1921
1922 * frame.c (Fother_visible_frames_p): Function deleted.
1923
fa819fed
EZ
19242011-09-12 Eli Zaretskii <eliz@gnu.org>
1925
1926 * indent.c (compute_motion): Process display vector front to back
1927 rather than the other way around. (Bug#2496)
1928
2ba8e008
SM
19292011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1930
1931 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1932
20f53c69
CY
19332011-09-11 Chong Yidong <cyd@stupidchicken.com>
1934
1935 * minibuf.c (Fread_from_minibuffer): Doc fix.
1936
d562d7a4
EZ
19372011-09-11 Eli Zaretskii <eliz@gnu.org>
1938
1939 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1940 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1941
1c4d7f3d
LMI
19422011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1943
1944 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1945 value for non-existent files.
1946
b885bf36
EZ
19472011-09-11 Eli Zaretskii <eliz@gnu.org>
1948
1949 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1950 set its "size" to -1. This will set the modtime_size field of
1951 the corresponding buffer to -1, which is what
1952 verify-visited-file-modtime expects for files that do not exist.
1953 (Bug#9139)
1954
6612f0bf
PE
19552011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1958 here ...
1959 * lisp.h: ... from here. push_key_description is no longer
1960 defined in keyboard.c, so its declaration should not be in
1961 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1962 logically belongs with push_key_description.
1963
dfb3f755
PE
19642011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 * buffer.h: Include <sys/types.h> instead of <time.h>.
1967 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1968 Problem reported by Herbert J. Skuhra.
1969
3134906c
LMI
19702011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1971
1972 * xml.c (parse_region): Make the parsing work for
1973 non-comment-starting XML files again (bug#9144).
1974
8d903f4e
AS
19752011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1976
1977 * image.c (gif_load): Fix calculation of bottom and right corner.
1978 (Bug#9468)
1979
80ad64f4
EZ
19802011-09-10 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1983 redisplay in small windows.
1984
208a048d
EZ
19852011-09-09 Eli Zaretskii <eliz@gnu.org>
1986
1987 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1988
9b1c252e
MR
19892011-09-08 Martin Rudalics <rudalics@gmx.at>
1990
1991 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1992 Operate on live windows only.
1993
2949f33b
JB
19942011-09-08 Juanma Barranquero <lekktu@gmail.com>
1995
1996 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1997
e08dcafd
EZ
19982011-09-07 Eli Zaretskii <eliz@gnu.org>
1999
2000 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2001 only under bidi iteration.
2002
115b96bd
JD
20032011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2004
2005 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2006
c8199d0f
PE
20072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2010 Without this fix, the command to link temacs failed due to an
2011 undefined symbol __builtin_isnan. This is because
2012 /usr/include/iso/math_c99.h #defines isnan(x) to
2013 __builtin_isnan(x), but the bundled gcc, which identifies itself
2014 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2015 a __builtin_isnan.
2016 * floatfns.c (isnan): #undef, and then #define to a clone of
2017 what's in data.c.
2018 (Fisnan): Always define, since it's always available now.
2019 (syms_of_floatfns): Always define isnan at the Lisp level.
2020
e39b275c 20212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2022
2023 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2024
b2db44d9 20252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2026
f4af5137 2027 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2028 The previous code assumed that file offsets (off_t values) fit in
2029 EMACS_INT variables, which is not true on typical 32-bit hosts.
2030 The code messed up by falsely reporting buffer overflow in cases
2031 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2032 when "big" contains more than 2**29 bytes, even though this
2033 inserts just one byte and does not overflow the buffer.
2034 (Finsert_file_contents): Store file offsets as off_t
2035 values, not as EMACS_INT values. Check for overflow when
2036 converting between EMACS_INT and off_t. When checking for
2037 buffer overflow or for overlap, take the offsets into account.
2038 Don't use EMACS_INT for small values where int suffices.
2039 When checking for overlap, fix a typo: ZV was used where
2040 ZV_BYTE was intended.
2041 (Fwrite_region): Don't assume off_t fits into 'long'.
2042 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2043
ecfc0a49
MA
20442011-09-05 Michael Albinus <michael.albinus@gmx.de>
2045
2046 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2047
6511acf2 20482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2049
0999621a 2050 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2051
2052 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2053 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2054 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2055 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2056 (modify_event_symbol): Do not assume that the length of
2057 name_alist_or_stem is safe to alloca and fits in int.
2058 (Fexecute_extended_command): Likewise for function name and binding.
2059 (Frecursion_depth): Wrap around reliably on integer overflow.
2060 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2061 since some callers pass EMACS_INT values.
2062 (Fsingle_key_description): Don't crash if symbol name contains more
2063 than MAX_ALLOCA bytes.
2064 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2065 (get_minibuffer): Arg is now EMACS_INT, not int.
2066 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2067 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2068 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2069
2be7d702
PE
2070 * dbusbind.c (signature_cat): New function.
2071 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2072 Do not overrun buffer; instead, report string overflow.
2073
9d1df220
PE
2074 * dispnew.c (add_window_display_history): Don't overrun buffer.
2075 Truncate instead; this is OK since it's just a log.
2076
33ef5c64
PE
2077 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2078 even if the time zone offset is outlandishly large.
2079 Don't mishandle offset == INT_MIN.
2080
66c6fdd5
PE
2081 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2082 when creating daemon; the previous buffer-overflow check was incorrect.
2083
d749b01b
PE
2084 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2085 which has the guts of the old verror function.
2086
b5cd1905
PE
2087 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2088 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2089
6e1a67fb
PE
2090 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2091 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2092 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2093 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2094 length of string rather than counting it via multiple sprintfs;
2095 that's simpler and more reliable.
c21721cc
PE
2096 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2097 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2098 sprintf, in case result does not fit in int.
2099
c57b67fc
PE
2100 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2101 (fontset_from_font): Print it.
2102
8a401434
PE
2103 * frame.c (tty_frame_count): Now printmax_t, not int.
2104 (make_terminal_frame, set_term_frame_name): Print it.
2105 (x_report_frame_params): In X, window IDs are unsigned long,
2106 not signed long, so print them as unsigned.
2107 (validate_x_resource_name): Check for implausibly long names,
2108 and don't assume name length fits in 'int'.
2109 (x_get_resource_string): Don't blindly alloca invocation name;
2110 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2111 not fit in int.
2112
6e1a67fb
PE
2113 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2114 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2115 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2116
0df02bf3
PE
2117 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2118 Use esprintf, not sprintf, in case result does not fit in int.
2119
48e30793
PE
2120 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2121 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2122 it as a large positive number.
2123 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2124 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2125
a66ff6d8
PE
2126 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2127 in case result does not fit in int.
2128
aca216ff
PE
2129 * print.c (float_to_string): Detect width overflow more reliably.
2130 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2131 buffer overrun. Don't assume list length fits in 'int'. Treat
2132 print length of 0 as 0, not as infinity; to be consistent with other
2133 uses of print length in this function. Don't overflow print length
2134 index. Don't assume hash table size fits in 'long', or that
2135 vectorlike size fits in 'unsigned long'.
2136
31c286f7
PE
2137 * process.c (make_process): Use printmax_t, not int, to format
2138 process-name gensyms.
2139
55e5faa1
PE
2140 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2141
80f2e268
PE
2142 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2143 to avoid potential buffer overrun.
2144
670741ab
PE
2145 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2146 if X resource line is longer than 512 bytes.
2147
b7163a50
PE
2148 * xfns.c (x_window): Make sprintf buffer a bit bigger
2149 to avoid potential buffer overrun.
2150
ae58ff1f
PE
2151 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2152
c43c8a6a
PE
2153 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2154
3f8236f4
PE
21552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2156
53e9fe90 2157 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2158 Without these, Emacs silently mishandles large integers sometimes.
2159 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2160 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2161
6511acf2
PE
2162 * xdisp.c (try_window_id): Check Emacs fixnum range before
2163 converting to 'int'.
806add1d 2164
6511acf2 2165 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2166 Check that an Emacs fixnum is in range before assigning it to 'int'.
2167 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2168 values converted from Emacs fixnums.
2169 (Frecenter): Don't wrap around a line count if it is out of 'int'
2170 range; instead, treat it as an extreme value.
2171 (Fset_window_configuration, compare_window_configurations):
2172 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2173
6511acf2
PE
2174 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2175 that can exceed INT_MAX. Check that EMACS_INT value is in range
2176 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2177 (match_limit): Don't assume that a fixnum can fit in 'int'.
2178
6511acf2 2179 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2180 exceed INT_MAX.
2181
6511acf2 2182 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2183 (Fvertical_motion): Don't wrap around LINES values that don't fit
2184 in 'int'. Instead, treat them as extreme values. This is good
2185 enough for windows, which can't have more than INT_MAX lines anyway.
2186
fcb901a7
LMI
21872011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2188
0f2f6b6d
LMI
2189 * Require libxml/parser.h to avoid compilation warning.
2190
fcb901a7
LMI
2191 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2192
2193 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2194 since this reportedly can destroy thread storage.
2195
6e20a0d4
CY
21962011-08-30 Chong Yidong <cyd@stupidchicken.com>
2197
2198 * syntax.c (find_defun_start): Update all cache variables if
2199 exiting early (Bug#9401).
2200
148ae00e
EZ
22012011-08-30 Eli Zaretskii <eliz@gnu.org>
2202
f6cfbd8f
EZ
2203 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2204
148ae00e
EZ
2205 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2206 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2207 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2208
2209 * term.c (tty_append_glyph): New function.
2210 (produce_stretch_glyph): Static function and its prototype deleted.
2211
a66cfb1c
SM
2212 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2213 Add prototypes.
148ae00e 2214
c4a07a4c
PE
22152011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2218 when checking :margin (Bug#9390).
2219 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2220 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2221 so that the name doesn't mislead. All uses changed.
2222
6bc8cd65
JB
22232011-08-28 Johan Bockgård <bojohan@gnu.org>
2224
2225 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2226 set_tty_hooks.
2227
dca4927e
EZ
22282011-08-27 Eli Zaretskii <eliz@gnu.org>
2229
2230 * xdisp.c (move_it_to): Don't bail out early when reaching
2231 position beyond to_charpos, if we are scanning backwards.
2232 (move_it_vertically_backward): When DY == 0, make sure we get to
2233 the first character in the line after the newline.
2234
f2cad773
PE
22352011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2236
2237 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2238 (ccl_driver): Do not generate an out-of-range pointer.
2239 (Fccl_execute_on_string): Remove unnecessary check for
2240 integer overflow, noted by Stefan Monnier in
2241 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2242 Remove a FIXME that didn't need fixing.
2243 Simplify the newly-introduced buffer reallocation code.
2244
0cae2cdb
JB
22452011-08-27 Juanma Barranquero <lekktu@gmail.com>
2246
2247 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2248
5fc295a4 22492011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2250
70c60eb2 2251 Integer and memory overflow issues (Bug#9196).
726e0ab1 2252
d31850da
PE
2253 * doc.c (get_doc_string): Rework so that
2254 get_doc_string_buffer_size is the actual buffer size, rather than
2255 being 1 less than the actual buffer size; this makes xpalloc more
2256 convenient.
2257
a69fbedb
PE
2258 * image.c (x_allocate_bitmap_record, cache_image):
2259 * xselect.c (Fx_register_dnd_atom):
2260 Simplify previous changes by using xpalloc.
2261
fe5c5d37
PE
2262 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2263 since either will do and ptrdiff_t is convenient with xpalloc.
2264
0065d054
PE
2265 * charset.c (charset_table_size)
2266 (struct charset_sort_data.priority): Now ptrdiff_t.
2267 (charset_compare): Don't overflow if priorities differ greatly.
2268 (Fsort_charsets): Don't assume list length fits in int.
2269 Check for size-calculation overflow when allocating sort data.
2270 (syms_of_charset): Allocate an initial charset table that is
2271 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2272
2273 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2274
2275 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2276 The actual value is always <= INT_MAX, and leaving it unsigned made
2277 overflow checking harder.
2278
2279 * dispextern.h (struct glyph_matrix.rows_allocated)
2280 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2281 with xpalloc. The values are still always <= INT_MAX.
2282
2283 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2284
2285 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2286 (SAFE_NALLOCA): New macro.
2287
2288 * region-cache.c (struct boundary.pos, find_cache_boundary)
2289 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2290 (set_cache_region, invalidate_region_cache)
2291 (revalidate_region_cache, know_region_cache, region_cache_forward)
2292 (region_cache_backward, pp_cache):
2293 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2294 so that ptrdiff_t * can be passed to xpalloc.
2295 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2296 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2297 (pp_cache): Don't assume cache_len fits in int.
2298 * region-cache.h: Adjust extern decls to match.
2299
2300 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2301 EMACS_INT, since either will do, for xpalloc.
2302
2303 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2304 (xnmalloc, xnrealloc, xpalloc): New functions.
2305
726e0ab1
PE
2306 * bidi.c (bidi_shelve_header_size): New constant.
2307 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2308 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2309
51f30bc5 2310 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2311 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2312 (overlay_strings):
2313 Don't update size of array until after memory allocation succeeds,
2314 because xmalloc/xrealloc may not return.
0065d054
PE
2315 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2316 now that we have proper integer overflow checking.
2317 (record_overlay_string, overlay_strings): Catch overflows when
2318 calculating size of overlay_str_buf.
726e0ab1 2319
0065d054
PE
2320 * callproc.c (Fcall_process): Check for size overflow when
2321 calculating size of args2.
2322 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2323 Normally we prefer signed values, but sticking with ptrdiff_t would
2324 require adding more-complicated checks.
726e0ab1
PE
2325
2326 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2327 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2328 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2329 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2330
2331 * character.c (Fstring): Check for size-calculation overflow.
2332
2333 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2334 unnecessary integer overflow. Check for size overflow.
2335 (encode_coding_object): Don't update size until xmalloc succeeds.
2336
2337 * composite.c (get_composition_id): Check for overflow in glyph
2338 length calculations.
2339
2340 Integer and memory overflow fixes for display code.
2341 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2342 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2343 (scrolling_window): Check for overflow in size calculations.
2344 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2345 Don't assume glyph table len fits in int.
2346 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2347 (row_table_size): Now ptrdiff_t, not int.
2348 (scrolling_window): Avoid overflow in size calculations.
2349 Don't update size until allocation succeeds.
2350 * fns.c (concat): Check for overflow in size calculations.
2351 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2352 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2353 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2354
2355 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2356 (get_doc_string): Check for size calculation overflow.
2357 Don't update size until allocation succeeds.
2358 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2359 EMACS_INT, where ptrdiff_t will do.
2360 (Fsubstitute_command_keys): Check for string overflow.
2361
2362 * editfns.c (set_time_zone_rule): Don't assume environment length
2363 fits in int.
2364 (message_length): Now ptrdiff_t, not int.
2365 (Fmessage_box): Don't update size until allocation succeeds.
2366 Don't assume message length fits in int.
2367 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2368
0065d054
PE
2369 * emacs.c (main): Do not reallocate argv, since there is a null at
2370 the end that can be overwritten, and this way there's no need to
2371 worry about size-calculation overflow.
2372 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2373
2374 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2375 alloc succeeds.
2376 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2377
2378 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2379 (x_set_scroll_bar_width, x_figure_window_size):
2380 Check for integer overflow.
2381 (x_set_alpha): Do not assume XINT fits in int.
2382
2383 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2384 This is for the members text_lines, text_cols, total_lines, total_cols,
2385 where the system imposes an 'int' limit.
2386
2387 * fringe.c (Fdefine_fringe_bitmap):
2388 Don't update size until alloc works.
2389
2390 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2391 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2392
2393 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2394 Check for size-calculation overflow.
2395 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2396 do, as we prefer signed integers.
2397 (id_to_widget.max_size, id_to_widget.used)
2398 (xg_store_widget_in_map, xg_remove_widget_from_map)
2399 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2400 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2401 Use and return ptrdiff_t, not int.
2402 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2403 * gtkutil.h: Change prototypes to match the above.
2404
2405 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2406 are duplicate now that they've been promoted to lisp.h.
2407 (x_allocate_bitmap_record, x_alloc_image_color)
2408 (make_image_cache, cache_image, xpm_load):
2409 Don't update size until alloc is done.
2410 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2411 (x_detect_edges):
3256efce 2412 Check for size calculation overflow.
726e0ab1
PE
2413 (ct_colors_allocated_max): New constant.
2414 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2415 overflow.
3256efce 2416
726e0ab1
PE
2417 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2418 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2419 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2420 Use ptrdiff_t, not int, to count maps.
2421 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2422 calculations. Don't update size until allocation succeeds.
2423 Redo calculations to avoid overflow.
726e0ab1
PE
2424 * keyboard.h: Change prototypes to match the above.
2425
2426 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2427 to count maps.
2428 (current_minor_maps): Check for size calculation overflow.
2429 * keymap.h: Change prototypes to match the above.
2430
2431 * lread.c (read1, init_obarray): Don't update size until alloc done.
2432
2433 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2434 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2435
726e0ab1
PE
2436 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2437 Now ptrdiff_t, not int.
2438 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2439 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2440
2441 * process.c (Fnetwork_interface_list): Check for overflow
2442 in size calculation.
2443
2444 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2445
2446 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2447 overflow. Don't bother calling xmalloc when xrealloc will do.
2448
2449 * search.c (Freplace_match): Check for size calculation overflow.
2450 (Fset_match_data): Don't assume list lengths fit in 'int'.
2451
2452 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2453 for command line length. Do not attempt to address one before the
2454 beginning of an array, as that's not portable.
2455
2456 * term.c (max_frame_lines): Remove; unused.
2457 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2458 not int.
2459 (encode_terminal_code, calculate_costs): Check for size
2460 calculation overflow.
2461 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2462 table lengths and related sizes. Don't update size until alloc
2463 done. Redo calculations to avoid overflow.
2464 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2465
2466 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2467 subtracting pointers.
2468 (gobble_line): Check for overflow more carefully. Don't update size
2469 until alloc done.
2470
2471 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2472 Don't update size until alloc done.
2473 Redo size calculations to avoid overflow.
2474 Check for size calculation overflow.
0065d054 2475 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2476
2477 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2478 Use ptrdiff_t, not int, for sizes.
2479 (store_mode_line_noprop_char): Don't update size until alloc done.
2480
0065d054
PE
2481 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2482 Use ptrdiff_t, not int, for sizes.
2483 (Finternal_make_lisp_face, cache_face):
2484 Check for size calculation overflow.
2485 (cache_face): Treat size calculation overflows as if they were
2486 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2487
2488 * xfns.c (x_encode_text, x_set_name_internal)
2489 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2490 sizes, since they can exceed INT_MAX in size. Check for size
2491 calculation overflow.
2492
0065d054
PE
2493 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2494 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2495 Don't update size until alloc done.
2496
0065d054 2497 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2498 as sprintf is limited to int lengths.
1d526e2f 2499
252c5ee1
PE
2500 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2501 (X_LONG_MIN): New macros.
864d7ce7
PE
2502 Use them to make the following changes clearer.
2503 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2504 This change doesn't affect the value now, but it may help remind
2505 future maintainers not to raise the value too much later.
2506 (SELECTION_QUANTUM): Remove, replacing with ...
2507 (selection_quantum): ... new function, which avoids overflow.
2508 All uses changed.
2509 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2510 assumption that selection length fits in 'int'.
2511 (x_reply_selection_request, x_handle_selection_request)
2512 (x_get_window_property, receive_incremental_selection)
2513 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2514 (lisp_data_to_selection_data, clean_local_selection_data):
2515 Use ptrdiff_t, not int, to record length of selection.
2516 (x_reply_selection_request, x_get_window_property)
2517 (receive_incremental_selection, x_property_data_to_lisp):
2518 Redo calculations to avoid overflow.
2519 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2520 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2521 something.
2522 (x_get_window_property, receive_incremental_selection)
2523 (lisp_data_to_selection_data, x_property_data_to_lisp):
2524 Check for size-calculation overflow.
2525 (x_get_window_property, receive_incremental_selection)
2526 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2527 Don't store size until memory allocation succeeds.
2528 (x_get_window_property): Plug memory leak on memory exhaustion.
2529 Don't double-block input; malloc is safe here. Don't assume 2**34
2530 - 4 fits in unsigned long. Add an xassert to check
2531 XGetWindowProperty overflow. Be more careful about overflow
2532 calculations, and distinguish size from memory overflow better.
2533 (receive_incremental_selection): When tracing, don't assume
2534 unsigned int is less than INT_MAX.
2535 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2536 harmful) conversions of unsigned short to int.
2537 (lisp_data_to_selection_data): Don't assume that integers
2538 in the range -65535 through -1 fit in an X unsigned short.
2539 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2540 result parameters unless successful. Rely on cons_to_unsigned
2541 to report problems with elements; the old code wasn't right anyway.
2542 (x_check_property_data): Check for int overflow; we cannot use
2543 a wider type due to X limits.
2544 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2545
726e0ab1 2546 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2547
0065d054
PE
2548 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2549 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2550 (x_color_cells): Don't store size until memory allocation succeeds.
2551 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2552 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2553 (x_term_init): Don't assume length fits in int (sprintf is limited
2554 to int size).
bc18e09d 2555
ebfa62c0
PE
2556 Use ptrdiff_t for composition IDs.
2557 * character.c (lisp_string_width):
2558 * composite.c (composition_table_size, n_compositions)
2559 (get_composition_id, composition_gstring_from_id):
2560 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2561 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2562 * window.c (Frecenter):
2563 Use ptrdiff_t, not int, for composition IDs.
2564 * composite.c (get_composition_id): Check for integer overflow.
2565 * composite.h: Adjust prototypes to match the above changes.
2566
d3411f89
PE
2567 Use ptrdiff_t for hash table indexes.
2568 * category.c (hash_get_category_set):
2569 * ccl.c (ccl_driver):
2570 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2571 * coding.c (coding_system_charset_list, detect_coding_system):
2572 * coding.h (struct coding_system.id):
2573 * composite.c (get_composition_id, gstring_lookup_cache):
2574 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2575 * image.c (xpm_get_color_table_h):
2576 * lisp.h (hash_lookup, hash_put):
2577 * minibuf.c (Ftest_completion):
2578 Use ptrdiff_t for hash table indexes, not int (which is too
2579 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2580 32-bit --with-wide-int hosts).
2581
e097a6fa
PE
2582 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2583 Add a FIXME comment about memory leaks.
2584 (syms_of_charset): Don't assume xmalloc returns.
2585
5637687f
PE
2586 Don't assume that stated character widths fit in int.
2587 * character.c (Fchar_width, c_string_width, lisp_string_width):
2588 * character.h (CHAR_WIDTH):
2589 * indent.c (MULTIBYTE_BYTES_WIDTH):
2590 Use sanitize_char_width to avoid undefined and/or bad behavior
2591 with outlandish widths.
a66cfb1c 2592 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2593 now that we have two such functions. All uses changed.
2594 (sanitize_char_width): New inline function.
2595
a2271ba2
PE
2596 Don't assume that tab-width fits in int.
2597 * character.h (sanitize_width): New inline function.
2598 (SANE_TAB_WIDTH): New macro.
2599 (ASCII_CHAR_WIDTH): Use it.
2600 * indent.c (sane_tab_width): Remove. All uses replaced by
2601 SANE_TAB_WIDTH (current_buffer).
2602 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2603
18c52557
PE
2604 * fileio.c: Integer overflow issues with file modes.
2605 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2606
caeeedc1
PE
2607 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2608 Remove unreachable code.
2609 (read_hex, load_charset_map_from_file): Check for integer overflow.
2610
6df6ae42 2611 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2612 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2613 (x_send_scroll_bar_event): Likewise. Check that the size does not
2614 exceed limits imposed by XClientMessageEvent, as well as the usual
2615 ptrdiff_t and size_t limits.
2616
b13995db
PE
2617 * keyboard.c: Overflow, signedness and related fixes.
2618 (make_lispy_movement): Use same integer type in forward decl
2619 that is used in the definition.
2620 (read_key_sequence, keyremap_step):
2621 Change bufsize argument back to int, undoing my 2011-03-30 change.
2622 We prefer signed types, and int is wide enough here.
2623 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2624 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2625 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2626 length, not size_t. Use ptrdiff_t for index, not int.
2627 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2628 possibility of integer overflow.
2629
13464394
PE
2630 Overflow, signedness and related fixes for images.
2631
2632 * dispextern.h (struct it.stack[0].u.image.image_id)
2633 (struct_it.image_id, struct image.id, struct image_cache.size)
2634 (struct image_cache.used, struct image_cache.ref_count):
2635 * gtkutil.c (update_frame_tool_bar):
2636 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2637 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2638 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2639 * nsmenu.m (update_frame_tool_bar):
2640 * xdisp.c (calc_pixel_width_or_height):
2641 * xfns.c (image_cache_refcount):
2642 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2643 on typical 64-bit hosts.
2644
2645 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2646 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2647 Omit unnecessary casts to int.
2648 (parse_image_spec): Check that integers fall into 'int' range
2649 when the callers expect that.
2650 (image_ascent): Redo ascent calculation to avoid int overflow.
2651 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2652 (lookup_image): Remove unnecessary tests.
2653 (xbm_image_p): Locals are now of int, not EMACS_INT,
2654 since parse_image_check makes sure they fit into int.
2655 (png_load, gif_load, svg_load_image):
2656 Prefer int to unsigned where either will do.
2657 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2658 old tiff_error_handler and tiff_warning_handler.
2659 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2660 stack buffer overflows. It uses only the features of vsnprintf
2661 that are common to both POSIX and native Microsoft.
2662 (tiff_error_handler, tiff_warning_handler): Use it.
2663 (tiff_load, gif_load, imagemagick_load_image):
2664 Don't assume :index value fits in 'int'.
2665 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2666 (imagemagick_load_image): Check that crop parameters fit into
2667 the integer types that MagickCropImage accepts. Don't assume
2668 Vimagemagick_render_type has a nonnegative value. Don't assume
2669 size_t fits in 'long'.
2670 (gs_load): Use printmax_t to print the widest integers possible.
2671 Check for integer overflow when computing image height and width.
2672
c11821d4
EZ
26732011-08-26 Eli Zaretskii <eliz@gnu.org>
2674
2675 * xdisp.c (redisplay_window): Don't force window start if point
2676 will be invisible in the resulting window. (Bug#9324)
2677
0c95fcf7
EZ
26782011-08-25 Eli Zaretskii <eliz@gnu.org>
2679
2680 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2681 the display spec is of the form `(space ...)'.
2682 (handle_display_spec): Return the value returned by
2683 handle_single_display_spec, not just 1 or zero.
2684 (handle_single_display_spec): If the display spec is of the form
2685 `(space ...)', and specifies display in the text area, return 2
2686 rather than 1.
fee65a97 2687 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2688 accurately, and prefer exact match for point under bidi.
2689 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2690
2691 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2692 into disp_prop; all users changed.
2693
2694 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2695 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2696 for the text covered by the display property.
2697
e4ed06f1
CY
26982011-08-25 Chong Yidong <cyd@stupidchicken.com>
2699
2700 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2701 Change return value to nil.
2702 (Frecord_buffer): Delete unused function.
2703
f67cdd7f
EZ
27042011-08-24 Eli Zaretskii <eliz@gnu.org>
2705
5980d4c6
EZ
2706 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2707 buffers, return left-to-right.
8610fe8b
EZ
2708 (set_cursor_from_row): Consider candidate row a win if its glyph
2709 represents a newline and point is on that newline. Fixes cursor
2710 positioning on the newline at EOL of R2L text within L2R
2711 paragraph, and vice versa.
2712 (try_cursor_movement): Check continued rows, in addition to
2713 continuation rows. Fixes unwarranted scroll when point enters a
2714 continued line of R2L text within an L2R paragraph, or vice versa.
2715 (cursor_row_p): Consider the case of point being equal to
2716 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2717 from the end of a short line to the beginning of a continued line
2718 of R2L text within L2R paragraph.
2719 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2720 composed characters.
5980d4c6 2721
f67cdd7f
EZ
2722 * bidi.c (bidi_check_type): Use xassert.
2723 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2724 members.
2725
bca633fb
EZ
27262011-08-23 Eli Zaretskii <eliz@gnu.org>
2727
2728 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2729 a character.
2730
4a5885a7
CY
27312011-08-23 Chong Yidong <cyd@stupidchicken.com>
2732
2733 * nsfont.m (ns_otf_to_script): Fix typo.
2734
0902a04e
KH
27352011-08-22 Kenichi Handa <handa@m17n.org>
2736
2737 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2738 extra slot even if the purpose is char-code-property-table.
2739
1a2e6670
EZ
27402011-08-23 Eli Zaretskii <eliz@gnu.org>
2741
8ddde651
EZ
2742 * xdisp.c (redisplay_window): When computing centering_position,
2743 account for the height of the header line. (Bug#8874)
2744
425cc014
EZ
2745 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2746 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2747 candidate is selected by the mouse, and that candidate has a
2748 composed character under the mouse.
2749
1a2e6670
EZ
2750 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2751 coordinates reported by pos-visible-in-window-p for a composed
2752 character in column zero.
2753
8b76d6f8
SM
27542011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2755
2756 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2757
dac347dd
EZ
27582011-08-22 Eli Zaretskii <eliz@gnu.org>
2759
2760 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2761 consider it a hit if to_charpos is anywhere in the range of the
2762 composed buffer positions.
2763
e013fb34
CY
27642011-08-22 Chong Yidong <cyd@stupidchicken.com>
2765
2766 * image.c (gif_load): Don't assume that each subimage has the same
2767 dimensions as the base image. Handle disposal method that is
2768 "undefined" by the gif spec (Bug#9335).
2769
bd1ba3e8
CY
27702011-08-20 Chong Yidong <cyd@stupidchicken.com>
2771
2772 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2773 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2774
54a1215b
EZ
27752011-08-19 Eli Zaretskii <eliz@gnu.org>
2776
823564e5
EZ
2777 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2778 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2779 from an Org mode buffer to a Speedbar frame.
2780
54a1215b
EZ
2781 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2782 a composition, take its buffer position from IT->cmp_it.charpos.
2783 Fixes cursor positioning at the beginning of a line that begins
2784 with a composed character.
2785
9778ebcc
EZ
27862011-08-18 Eli Zaretskii <eliz@gnu.org>
2787
0be6ee06
EZ
2788 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2789 character bidirectional type, use STRONG_L instead. Fixes crashes
2790 in a buffer produced by `describe-categories'.
2791
9778ebcc
EZ
2792 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2793 members before the level stack, so they would be saved and
2794 restored when copying iterator state. Fixes incorrect reordering
2795 around TABs covered by display properties.
2796
156bffbe
AS
27972011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2798
6b02f655 2799 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2800
72ad093b
CY
28012011-08-17 Chong Yidong <cyd@stupidchicken.com>
2802
2803 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2804 (internal_condition_case_2, internal_condition_case_n):
2805 Remove unnecessary aborts (Bug#9081).
72ad093b 2806
35774242
EZ
28072011-08-17 Eli Zaretskii <eliz@gnu.org>
2808
2809 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2810 has no `load' handler, try opening the file locally. (Bug#9311)
2811
db76dd85
KB
28122011-08-16 Ken Brown <kbrown@cornell.edu>
2813
2814 * gmalloc.c: Expand comment.
2815
b215eee5
EZ
28162011-08-16 Eli Zaretskii <eliz@gnu.org>
2817
2818 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2819 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2820
a4579d33
KB
28212011-08-16 Ken Brown <kbrown@cornell.edu>
2822
2823 Fix memory allocation problems in Cygwin build (Bug#9273).
2824
2825 * unexcw.c ( __malloc_initialized): Declare external variable.
2826 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2827
8b76d6f8
SM
2828 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2829 New variables.
a4579d33
KB
2830 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2831 dumped emacs.
2832 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2833 in the static heap.
2834 [CYGWIN] (special_realloc): New function.
2835 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2836 requests to realloc storage in the static heap.
2837
3ebec551
PE
28382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 * bidi.c (bidi_initialize): Remove unused local.
2841
9fd8be00
EZ
28422011-08-15 Eli Zaretskii <eliz@gnu.org>
2843
6b02f655
SM
2844 * bidimirror.h:
2845 * biditype.h: Remove file.
2846 * makefile.w32-in ($(BLD)/bidi.$(O)):
2847 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2848
2849 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2850
2851 * chartab.c: Improve commentary for the uniprop_table API.
2852
32413314
EZ
2853 * bidi.c (bidi_paragraph_init): Support zero value of
2854 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2855 (bidi_initialize): Use uniprop_table instead of including
2856 biditype.h and bidimirror.h.
32413314 2857
9fd8be00
EZ
2858 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2859 coordinates of the iterator when restoring from ppos_it.
2860 (Bug#9296)
2861
5cf2b69b
KH
28622011-08-14 Kenichi Handa <handa@m17n.org>
2863
2864 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2865 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2866
daf17d00
EZ
28672011-08-14 Eli Zaretskii <eliz@gnu.org>
2868
2869 * xdisp.c (move_it_in_display_line_to): Don't invoke
2870 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2871 ppos_it. Fixes vertical cursor motion when line beginning is
2872 covered by an image. (Bug#9296)
2873
08e3161a
JD
28742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2875
2876 * nsterm.h (ns_run_ascript): Declare.
2877 (NSAPP_DATA2_RUNASSCRIPT): Define.
2878
2879 * nsfns.m (as_script, as_result, as_status): New static variables.
2880 (ns_run_ascript): New function.
5e617bc2 2881 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2882 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2883 the event loop. Get status from as_status (Bug#7276).
2884
2885 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2886 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2887 the event loop (Bug#7276).
2888
a3720aa2
AS
28892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2890
2891 * gnutls.c (QCgnutls_bootprop_priority)
2892 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2893 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2894 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2895 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2896 (QCgnutls_bootprop_verify_hostname_error)
2897 (QCgnutls_bootprop_callbacks_verify): Rename from
2898 Qgnutls_bootprop_..., all uses changed.
2899
2900 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2901 uses changed.
2902
0a0d27fb
PE
29032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2904
19d5c50c
PE
2905 * xfaces.c (Qframe_set_background_mode): Now static.
2906 * dispextern.h (Qframe_set_background_mode): Remove decl.
2907
0a0d27fb
PE
2908 * process.c (Fnetwork_interface_info): Declare local only if needed.
2909
377538cb
JD
29102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2911
2912 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2913 (Fnetwork_interface_list): Allocate in increments of bytes instead
2914 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2915 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2916 sockaddr.
2917 (struct ifflag_def): notrailers is smart on OSX.
2918 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2919 Get hardware address with getifaddrs if available.
2920
08fff70c
EZ
29212011-08-12 Eli Zaretskii <eliz@gnu.org>
2922
2923 * xdisp.c (iterate_out_of_display_property): xassert that
2924 IT->position is set to within IT->object's boundaries. Break from
2925 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2926 when IT->position is set up wrongly due to some bug.
2927 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2928 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2929 entry. Force push_it to save on the stack the current
2930 buffer/string position, to be restored by pop_it. Fix flags in
2931 the iterator structure wrt the object coming from a display
2932 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2933 properties. (Bug#9284)
2934
7be1c708 29352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2936
7be1c708
CY
2937 * fontset.c (fontset_get_font_group): Add proper type checks.
2938 (Bug#9172)
aac0c6e3 2939
7be1c708 29402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2941
7be1c708
CY
2942 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2943 and LC_VERSION_MIN_MACOSX.
2944 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2945 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2946
97bb72a6
EZ
29472011-08-08 Eli Zaretskii <eliz@gnu.org>
2948
2949 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2950 no-display-properties-and-no-overlays under bidi display.
2951 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2952 properties and overlays.
97bb72a6 2953
d5617611
CY
29542011-08-08 Chong Yidong <cyd@stupidchicken.com>
2955
37e11a63
CY
2956 * editfns.c (Fset_time_zone_rule): Document relationship with the
2957 setenv function.
2958
d5617611
CY
2959 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2960 the font entity extracted from the cache (Bug#8109).
2961
58872834
CY
29622011-08-07 Chong Yidong <cyd@stupidchicken.com>
2963
2964 * composite.c (autocmp_chars): Don't reset point. That is done by
2965 restore_point_unwind (Bug#5984).
2966
75bfc667
JL
29672011-08-07 Juri Linkov <juri@jurta.org>
2968
2969 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2970 to show the arg `TIME' instead of `TIMEVAL'.
2971
d1410150
EZ
29722011-08-06 Eli Zaretskii <eliz@gnu.org>
2973
2974 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2975 display property strides EOL and includes a newline, as in
2976 longlines-mode. (Bug#9254)
75b771e4
EZ
2977 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2978 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2979
2980 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2981 is non-zero, even if the data buffer is NULL. Fixes a crash in
2982 vertical-motion with longlines-mode. (Bug#9254)
2983
35928349
EZ
29842011-08-05 Eli Zaretskii <eliz@gnu.org>
2985
ec7cc85b
EZ
2986 * bidi.c <bidi_cache_total_alloc>: Now static.
2987 (bidi_initialize): Initialize bidi_cache_total_alloc.
2988
8b76d6f8 2989 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2990 cache. (Bug#9221)
2991
2992 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2993 amount allocated this far in `bidi_cache_total_alloc'.
2994 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2995 non-zero, only free the data buffer without restoring the cache
2996 contents. All callers changed.
2997
2998 * dispextern.h (bidi_unshelve_cache): Update prototype.
2999
3000 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3001 (move_it_in_display_line, move_it_to)
3002 (move_it_vertically_backward, move_it_by_lines): Replace the call
3003 to xfree to an equivalent call to bidi_unshelve_cache.
3004 (move_it_in_display_line_to): Fix logic of returning
412b6358 3005 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3006
e2e2423b
EZ
30072011-08-05 Eli Zaretskii <eliz@gnu.org>
3008
3009 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3010 came from a string character with a `cursor' property. (Bug#9229)
3011
ae9e757a
JD
30122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3013
3014 * Makefile.in (LIB_PTHREAD): New variable.
3015 (LIBES): Add LIB_PTHREAD (Bug#9216).
3016
3017 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3018 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3019
213bd7f2
AS
30202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3021
6b02f655 3022 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3023
99aaf75f
JD
30242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3025
3026 * xterm.c (x_find_topmost_parent): New function.
3027 (x_set_frame_alpha): Find topmost parent window with
3028 x_find_topmost_parent and set the property there also (bug#9181).
3029 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3030
c74e9d86
PE
30312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3032
3033 * callproc.c (Fcall_process): Avoid vfork clobbering
3034 the local vars buffer, coding_systems, current_dir.
3035
640c8776
SM
30362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3037
3038 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3039
f26d0e4c
PE
30402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3041
8a10d76c
PE
3042 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3043 so that it is not optimized away.
3044
f26d0e4c
PE
3045 * xdisp.c (compute_display_string_pos): Remove unused local.
3046
55439c61
EZ
30472011-08-02 Eli Zaretskii <eliz@gnu.org>
3048
3049 Fix slow cursor motion and scrolling in large buffers with
3050 selective display, like Org Mode buffers. (Bug#9218)
3051
3052 * dispextern.h (struct bidi_it): New member disp_prop_p.
3053
3054 * xdisp.c: Remove one-slot cache of display string positions.
3055 (compute_display_string_pos): Accept an additional argument
5e617bc2 3056 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3057 for a display string or property. If found, set DISP_PROP_P
3058 non-zero.
3059
3060 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3061 DISP_PROP_P, and pass it to compute_display_string_pos.
3062 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3063 non-zero. All callers of bidi_fetch_char changed.
3064
fb33fa43
SM
30652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3066
3067 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3068
b099e063
DM
30692010-12-03 Don March <don@ohspite.net>
3070
3071 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3072 last character M-[char] is translated to ESC [char] (bug#7541).
3073
5cc7f7af
KH
30742011-08-02 Kenichi Handa <handa@m17n.org>
3075
d0fffa3f 3076 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3077
3078 * chartab.c (uniprop_table): Make it non-static.
3079
525d5e6e
EZ
30802011-08-01 Eli Zaretskii <eliz@gnu.org>
3081
3082 * xdisp.c (forward_to_next_line_start): Accept additional argument
3083 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3084 on the newline.
3085 (reseat_at_next_visible_line_start): Use the bidi iterator state
3086 returned by forward_to_next_line_start to restore the state of
3087 it->bidi_it after backing up to previous newline. (Bug#9212)
3088
31011111
AS
30892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3090
3091 * regex.c (re_comp): Protoize.
3092 (re_exec): Fix return type.
3093 (regexec): Fix type of `ret'. (Bug#9203)
3094
476371c4
PE
30952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3096
e5d76069
PE
3097 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3098 This is needed if max-image-size is a floating-point number.
3099
9a79b20c
AS
31002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3101
3102 * print.c (print_object): Print empty symbol as ##.
3103
3104 * lread.c (read1): Read ## as empty symbol.
3105
d8c2fa78
AA
31062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3107
3108 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3109 setting frame foreground color (Bug#9175).
3110 (x_set_background_color): Likewise.
3111
ffe57a7a
AA
3112 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3113 contents (Bug#9176).
3114 (EmacsTooltip -init): Remove bezels and add shadows to
3115 tooltip windows.
3116
bf3492a5
AA
3117 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3118 or scroll bar (Bug#8470).
3119
d55e9c53
AA
3120 * nsfont.m (nsfont_open): Remove assignment to voffset and
3121 unnecessary vars hshink, expand, hd, full_height, min_height.
3122 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3123
3124 * nsterm.h (nsfont_info): Remove voffset field.
3125
d8c2fa78 31262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3127
3128 Implement strike-through and overline on NextStep (Bug#8863).
3129
3130 * nsfont.m (nsfont_open): Use underline position provided by font,
3131 instead of hard-coded value of 2.
3132 (nsfont_draw): Call ns_draw_text_decoration instead.
3133
3134 * nsterm.h: Add declaration for ns_draw_text_decoration.
3135
3136 * nsterm.m (ns_draw_text_decoration): New function for drawing
3137 underline, overline, and strike-through.
3138 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3139 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3140 accommodate underlining, etc.
4843aac3 3141
4cc60b9b
EZ
31422011-07-28 Eli Zaretskii <eliz@gnu.org>
3143
bc7ece87
EZ
3144 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3145 default.
4cc60b9b 3146
476371c4
PE
31472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3148
66606eea
PE
3149 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3150 Without this fix, if a signal arrives just after memory fills up,
3151 'malloc' might be invoked reentrantly.
3152
476371c4
PE
3153 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3154 In other words, assume that every image size is allowed, on non-X
3155 hosts. This assumption is probably wrong, but it lets Emacs compile.
3156
f3fcc40d
AS
31572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3158
3159 * regex.c (re_iswctype): Convert return values to boolean.
3160
350c992f
EZ
31612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3162
3163 * xdisp.c (compute_display_string_pos): Don't use cached display
3164 string position if the buffer had its restriction changed.
3165 (Bug#9184)
3166
5266b4bb
PE
31672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3168
3169 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3170
2573a837 31712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3172
41f55ccd 3173 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3174
39e378da
PE
3175 * bidi.c: Integer size and overflow fixes.
3176 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3177 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3178 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3179 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3180 (bidi_find_other_level_edge):
3181 Use ptrdiff_t instead of EMACS_INT where either will do.
3182 This works better on 32-bit hosts configured --with-wide-int.
3183 (bidi_cache_ensure_space): Check for size-calculation overflow.
3184 Use % rather than repeated addition, for better worst-case speed.
3185 Don't set bidi_cache_size until after xrealloc returns, because it
3186 might not return.
3187 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3188 (bidi_cache_ensure_space): Also check that the bidi cache size
3189 does not exceed that of the largest Lisp string or buffer. See Eli
3190 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3191
5e927815
PE
3192 * alloc.c (__malloc_size_t): Remove.
3193 All uses replaced by size_t. See Andreas Schwab's note
3194 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3195
ca4aa935
PE
3196 * image.c: Improve checking for integer overflow.
3197 (check_image_size): Assume that f is nonnull, since
3198 it is always nonnull in practice. This is one less thing to
3199 worry about when checking for integer overflow later.
3200 (x_check_image_size): New function, which checks for integer
3201 overflow issues inside X.
3202 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3203 This removes the need for a memory_full check.
3204 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3205 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3206 (xbm_read_bitmap_data): Change locals back to 'int', since
3207 their values must fit in 'int'.
3208 (xpm_load_image, png_load, tiff_load):
3209 Invoke x_create_x_image_and_pixmap earlier,
3210 to avoid much needless work if the image is too large.
3211 (tiff_load): Treat overly large images as if
3212 x_create_x_image_and_pixmap failed, not as malloc failures.
3213 (gs_load): Use x_check_image_size.
3214
5f8f9cc2
PE
3215 * gtkutil.c: Omit integer casts.
3216 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3217 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3218
5adf60bc
PE
3219 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3220
c8907a93
PE
3221 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3222 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3223 would wrongly return t on a 64-bit host.
3224
e3c25c68
PE
3225 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3226 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3227 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3228 and therefore cause GCC to emit a bogus diagnostic in some cases.
3229
3f791afe
PE
3230 * image.c: Integer signedness and overflow and related fixes.
3231 This is not an exhaustive set of fixes, but it's time to
3232 record what I've got.
3233 (lookup_pixel_color, check_image_size): Remove redundant decls.
3234 (check_image_size): Don't assume that arbitrary EMACS_INT values
3235 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3236 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3237 (tiff_load, imagemagick_load_image):
3238 Check for overflow in size calculations.
3239 (x_create_x_image_and_pixmap): Remove unnecessary test for
3240 xmalloc returning NULL; that can't happen.
3241 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3242 (xpm_color_bucket): Use better integer hashing function.
3243 (xpm_cache_color): Don't possibly over-allocate memory.
3244 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3245 (gif_memory_source):
3246 Use ptrdiff_t, not int or size_t, to record sizes.
3247 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3248 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3249 either works, as we prefer signed integers.
3250 (tiff_read_from_memory, tiff_write_from_memory):
3251 Return tsize_t, not size_t, since that's what the TIFF API wants.
3252 (tiff_read_from_memory): Don't fail simply because the read would
3253 go past EOF; instead, return a short read.
3254 (tiff_load): Omit no-longer-needed casts.
3255 (Fimagemagick_types): Don't assume size fits into 'int'.
3256
3cc5a532
PE
3257 Improve hashing quality when configured --with-wide-int.
3258 * fns.c (hash_string): New function, taken from sxhash_string.
3259 Do not discard information about ASCII character case; this
3260 discarding is no longer needed.
3261 (sxhash-string): Use it. Change sig to match it. Caller changed.
3262 * lisp.h: Declare it.
3263 * lread.c (hash_string): Remove, since we now use fns.c's version.
3264 The fns.c version returns a wider integer if --with-wide-int is
3265 specified, so this should help the quality of the hashing a bit.
3266
b312a492
PE
3267 * emacs.c: Integer overflow minor fix.
3268 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3269 Define only if GNU_LINUX.
3270 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3271
dfd153ae
PE
3272 * dispnew.c: Integer signedness and overflow fixes.
3273 Remove unnecessary forward decls, that were a maintenance hassle.
3274 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3275 All uses changed.
3276 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3277 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3278 (prepare_desired_row, line_draw_cost):
3279 Use int, not unsigned, where either works.
3280 (save_current_matrix, restore_current_matrix):
3281 Use ptrdiff_t, not size_t, where either works.
3282 (init_display): Check for overflow more accurately, and without
3283 relying on undefined behavior.
3284
a81d11a3
PE
3285 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3286 Remove, replacing with the new symbols in lisp.h. All uses changed.
3287 * fileio.c (make_temp_name):
3288 * filelock.c (lock_file_1, lock_file):
3289 * xdisp.c (message_dolog):
3290 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3291 Use pMd etc. instead.
3292 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3293 replacing the pWIDE etc. symbols removed from editfns.c.
3294
3300e6fd
PE
3295 * keyboard.h (num_input_events): Now uintmax_t.
3296 This is (very slightly) less likely to mess up due to wraparound.
3297 All uses changed.
3298
fd05c7e9
PE
3299 * buffer.c: Integer signedness fixes.
3300 (alloc_buffer_text, enlarge_buffer_text):
3301 Use ptrdiff_t rather than size_t when either will do, as we prefer
3302 signed integers.
3303
903fe15d
PE
3304 * alloc.c: Integer signedness and overflow fixes.
3305 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3306 (__malloc_size_t): Default to size_t, not to int.
3307 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3308 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3309 Prefer ptrdiff_t to size_t when either would do, as we prefer
3310 signed integers.
3311 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3312 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3313 Now const. Initialize with values that are in range even if char
3314 is signed.
3315 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3316 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3317 These functions do the right thing with sizes > 2**32.
3318 (check_depth): Now ptrdiff_t, not int.
3319 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3320 Adjust to new way of storing sizes. Check for size overflow bugs
3321 in rest of code.
3322 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3323 slightly wrong anyway, as it missed one instance of
3324 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3325 (refill_memory_reserve): Omit needless cast to size_t.
3326 (mark_object_loop_halt): Mark as externally visible.
3327
ac82cc6a
PE
3328 * xselect.c: Integer signedness and overflow fixes.
3329 (Fx_register_dnd_atom, x_handle_dnd_message):
3330 Use ptrdiff_t, not size_t, since we prefer signed.
3331 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3332 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3333 x_dnd_atoms_size and x_dnd_atoms_length.
3334
c2d1e36d
PE
3335 * doprnt.c: Prefer signed to unsigned when either works.
3336 * eval.c (verror):
3337 * doprnt.c (doprnt):
3338 * lisp.h (doprnt):
3339 * xdisp.c (vmessage):
3340 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3341 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3342 prefer signed arithmetic to avoid comparison confusion.
3343 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3344 but is a bit tricky.
3345
0e926e56
PE
3346 Assume freestanding C89 headers, string.h, stdlib.h.
3347 * data.c, doprnt.c, floatfns.c, print.c:
3348 Include float.h unconditionally.
3349 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3350 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3351 * regex.c: Likewise for stddef.h, string.h.
3352 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3353 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3354 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3355 (STDC_HEADERS): Remove obsolete defines.
3356 * sysdep.c: Include limits.h unconditionally.
3357
9cfdb3ec
PE
3358 Assume support for memcmp, memcpy, memmove, memset.
3359 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3360 * regex.c (memcmp, memcpy):
3361 Remove; we assume C89 now.
3362
3363 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3364 (__malloc_safe_bcopy): Remove; no longer needed.
3365
cf950e6b 3366 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3367 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3368 well either way, and we prefer signed to unsigned.
3369
dbf38e02
LMI
33702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3371
3372 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3373 closes the connection while we're reading (bug#9182).
3374
d6f0886c 33752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3376
d6f0886c
JD
3377 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3378 are specified (Bug#9168).
24e0f6b1 3379
2eb1f9e6
PE
33802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3383 Found by GCC static checking and --with-wide-int on a 32-bit host.
3384
22381272 33852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3386
3387 * xdisp.c (compute_display_string_pos): Fix logic of caching
3388 previous display string position. Initialize cached_prev_pos to
3389 -1. Fixes slow-down at the beginning of a buffer.
3390
f25e39b4
EZ
33912011-07-24 Eli Zaretskii <eliz@gnu.org>
3392
3393 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3394 for attrs[LFACE_FONTSET_INDEX].
3395
04c4b52e
PE
33962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3397
3398 * xml.c (parse_region): Remove unused local
3399 that was recently introduced.
3400
c1734fbd
EZ
34012011-07-23 Eli Zaretskii <eliz@gnu.org>
3402
be18c5a5
EZ
3403 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3404 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3405
c1734fbd
EZ
3406 * xdisp.c (move_it_in_display_line_to): Record the best matching
3407 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3408 exit if none of the characters scanned was an exact match.
3409 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3410 when exact match is impossible due to invisible text, and the
3411 lines are truncated.
3412
a258d627
JD
34132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3414
3415 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3416 for OSX >= 10.7.
3417
b6d5a689
EZ
34182011-07-22 Eli Zaretskii <eliz@gnu.org>
3419
0f74f785
EZ
3420 Fix a significant slow-down of cursor motion with C-n, C-p,
3421 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3422 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3423 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3424 (next_element_from_buffer): Call compute_stop_pos_backwards to
3425 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3426 base_level_stop.
3427 (reseat): Don't look for prev_stop, as that could mean a very long
3428 run.
3429 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3430 <cached_disp_overlay_modiff>: Cache for last found display string
3431 position.
551918c1 3432 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3433 about the same buffer in the same area of character positions, and
3434 the buffer wasn't changed since the time the display string
3435 position was cached.
551918c1 3436
b2d0c91a
EZ
34372011-07-22 Eli Zaretskii <eliz@gnu.org>
3438
3439 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3440 is an integer, which is important for empty lines. (Bug#9149)
3441
043604ee
CY
34422011-07-22 Chong Yidong <cyd@stupidchicken.com>
3443
3444 * frame.c (Fmodify_frame_parameters): In tty case, update the
3445 default face if necessary (Bug#4238).
3446
da4adb04
CY
34472011-07-21 Chong Yidong <cyd@stupidchicken.com>
3448
3449 * editfns.c (Fstring_to_char): No need to explain what a character
3450 is in the docstring (Bug#6576).
3451
9abd0532
LMI
34522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3453
3454 * xml.c (parse_region): Make sure we always return a tree.
3455
36881d16
HK
34562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3457
3458 * xml.c (parse_region): If a document contains only comments,
3459 return that, too.
3460
1e98674d
LMI
34612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3462
3463 * xml.c (make_dom): Return comments, too.
3464
590bd467
PE
34652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3466
3467 Port to OpenBSD.
3468 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3469 and the surrounding thread.
3470 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3471 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3472 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3473 timer goes off.
3474 * s/openbsd.h (BROKEN_SIGIO): Define.
3475 * unexelf.c (unexec) [__OpenBSD__]:
3476 Don't update the .mdebug section of the Alpha COFF symbol table.
3477
f41628b2
LMI
34782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3479
3480 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3481 (bug#8460).
3482
b59b67c5
PE
34832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3484
15e3a074
PE
3485 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3486 This fixes some race conditions on the permissions of any newly
3487 created file.
3488
41bed37d
PE
3489 * alloc.c (valid_pointer_p): Use pipe, not open.
3490 This fixes some permissions issues when debugging.
3491
b59b67c5
PE
3492 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3493 If fchown fails to set both uid and gid, try to set just gid,
3494 as that is sometimes allowed. Adjust the file's mode to eliminate
3495 setuid or setgid bits that are inappropriate if fchown fails.
3496
925a6be7
SM
34972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3498
3499 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3500 to compare Lisp_Objects.
3501 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3502 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3503 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3504
52968808
AS
35052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3506
0a6a104b
AS
3507 * lread.c (read_integer): Unread even EOF character.
3508 (read1): Likewise. Properly record start position of symbol.
3509
52968808
AS
3510 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3511 symbol character follows.
3512
9e381cdd
PE
35132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3516 This works around a problem with the previous change to Fcopy_file.
3517 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3518 and without this change, GCC might complain about discarding
3519 fchown's return value.
3520
b5641435
JB
35212011-07-16 Juanma Barranquero <lekktu@gmail.com>
3522
3523 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3524
a8031457
PE
35252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3528
dd889327
LMI
35292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3530
750c33f7
LMI
3531 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3532 it's used from the C level.
3533
dd889327
LMI
3534 * process.c: Use the same condition for POLL_FOR_INPUT in both
3535 keyboard.c and process.c (bug#1858).
3536
87e86684
LM
35372011-07-09 Lawrence Mitchell <wence@gmx.li>
3538
3539 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3540 (Fgnutls_boot): Use it.
3541
64348f40
AS
35422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3543
3544 * doc.c (Fsubstitute_command_keys): Revert last change.
3545
1d698799
LMI
35462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3547
f863868c
LMI
3548 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3549 quotes the next character, and doesn't affect other longer
3550 sequences (bug#8935).
3551
1d698799
LMI
3552 * lread.c (syms_of_lread): Clarify that is isn't only
3553 `eval-buffer' and `eval-defun' that's affected by
3554 `lexical-binding' (bug#8460).
3555
aa4b6df6
EZ
35562011-07-15 Eli Zaretskii <eliz@gnu.org>
3557
3558 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3559 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3560
5d856da6
PE
35612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3562
ad6042bb
PE
3563 Fix minor problems found by static checking.
3564 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3565 (elsz): Now a signed constant, not a size_t var. We prefer signed
3566 types to unsigned, to avoid integer comparison confusion. Without
3567 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3568 "cannot optimize loop, the loop counter may overflow", a symptom
3569 of the confusion.
f00bbb22 3570 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3571 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3572
6468f31c
LMI
35732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3574
49080b10
LMI
3575 * search.c (Fre_search_backward): Mention `case-fold-search' in
3576 all the re_search_* functions (bug#8138).
3577
6468f31c
LMI
3578 * keyboard.c (Fopen_dribble_file): Document when the file is
3579 closed (bug#8056).
3580
c965adc5
EZ
35812011-07-14 Eli Zaretskii <eliz@gnu.org>
3582
df9733bf
EZ
3583 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3584 bidi_cache_idx.
3585
0bb23927
EZ
3586 Support bidi reordering of display and overlay strings.
3587 * xdisp.c (compute_display_string_pos)
3588 (compute_display_string_end): Accept additional argument STRING.
3589 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3590 (reseat_to_string): Initialize bidi_it->string.s and
3591 bidi_it->string.schars.
3592 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3593 NULL (avoids a crash in bidi_paragraph_init).
3594 Initialize itb.string.lstring.
0bb23927
EZ
3595 (init_iterator): Call bidi_init_it only of a valid
3596 buffer position was specified. Initialize paragraph_embedding to
3597 L2R.
3598 (reseat_to_string): Initialize the bidi iterator.
3599 (display_string): If we need to ignore text properties of
3600 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3601 original value of -1 will not work with bidi.)
3602 (compute_display_string_pos): First arg is now struct
3603 `text_pos *'; all callers changed. Support display properties on
3604 Lisp strings.
3605 (compute_display_string_end): Support display properties on Lisp
3606 strings.
3607 (init_iterator, reseat_1, reseat_to_string): Initialize the
3608 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3609 when iterating on a string not from display properties).
640c8776
SM
3610 (compute_display_string_pos, compute_display_string_end):
3611 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3612 arrow keys.
3613 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3614 base_level_stop; instead, set base_level_stop to BEGV.
3615 Fixes crashes in vertical-motion.
0bb23927
EZ
3616 (next_element_from_buffer): Improve commentary for when
3617 the iterator is before prev_stop.
3618 (init_iterator): Initialize bidi_p from the default value of
3619 bidi-display-reordering, not from buffer-local value. Use the
3620 buffer-local value only if initializing for buffer iteration.
3621 (handle_invisible_prop): Support invisible properties on strings
3622 that are being bidi-reordered.
3623 (set_iterator_to_next): Support bidi reordering of C strings and
3624 Lisp strings.
3625 (next_element_from_string): Support bidi reordering of Lisp
3626 strings.
3627 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3628 (display_string): Support display of R2L glyph rows.
3629 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3630 (init_iterator): Don't initialize it->bidi_p for strings
3631 here.
3632 (reseat_to_string): Initialize it->bidi_p for strings here.
3633 (next_element_from_string, next_element_from_c_string)
3634 (next_element_from_buffer): Add xassert's for correspondence
3635 between IT's object being iterated and it->bidi_it.string
3636 structure.
3637 (face_before_or_after_it_pos): Support bidi iteration.
3638 (next_element_from_c_string): Handle the case of the first string
3639 character that is not the first one in the visual order.
3640 (get_visually_first_element): New function, refactored from common
3641 parts of next_element_from_buffer, next_element_from_string, and
3642 next_element_from_c_string.
3643 (tool_bar_lines_needed, redisplay_tool_bar)
3644 (display_menu_bar): Force left-to-right direction. Add a FIXME
3645 comment for making that be controlled by a user option.
3646 (push_it, pop_it): Save and restore the state of the
3647 bidi iterator. Save and restore the bidi_p flag.
3648 (pop_it): Iterate out of display property for string iteration as
3649 well.
3650 (iterate_out_of_display_property): Support iteration over strings.
3651 (handle_single_display_spec): Set up it->bidi_it for iteration
3652 over a display string, and call bidi_init_it.
3653 (handle_single_display_spec, next_overlay_string)
3654 (get_overlay_strings_1, push_display_prop): Set up the bidi
3655 iterator for displaying display or overlay strings.
3656 (forward_to_next_line_start): Don't use the shortcut if
3657 bidi-iterating.
3658 (back_to_previous_visible_line_start): If handle_display_prop
3659 pushed the iterator stack, restore the internal state of the bidi
3660 iterator by calling bidi_pop_it same number of times.
3661 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3662 and we are bidi-iterating, don't decrement the iterator position;
3663 instead, set the first_elt flag in the bidi iterator, to produce
3664 the same effect.
3665 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3666 (push_display_prop): xassert that we are iterating a buffer.
3667 (push_it, pop_it): Save and restore paragraph_embedding member.
3668 (handle_single_display_spec, next_overlay_string)
3669 (get_overlay_strings_1, reseat_1, reseat_to_string)
3670 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3671 correctly. Don't assume unibyte strings are not bidi-reordered.
3672 (compute_display_string_pos)
3673 (compute_display_string_end): Fix handling the case of C string.
3674 (push_it, pop_it): Save and restore from_disp_prop_p.
3675 (handle_single_display_spec, push_display_prop): Set the
3676 from_disp_prop_p flag.
3677 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3678 (pop_it): Call iterate_out_of_display_property only if we are
3679 popping after iteration over a string that came from a display
3680 property. Fix a typo in popping stretch info. Add an assertion
3681 for verifying that the iterator position is in sync with the bidi
3682 iterator.
3683 (handle_single_display_spec, get_overlay_strings_1)
3684 (push_display_prop): Fix initialization of paragraph direction for
3685 string when that of the parent object is not yet determined.
3686 (reseat_1): Call bidi_init_it to resync the bidi
3687 iterator with IT's position. (Bug#7616)
3688 (find_row_edges): If ROW->start.pos gives position
3689 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3690 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3691 Reset the from_disp_prop_p flag.
3692 (SAVE_IT, RESTORE_IT): New macros.
3693 (pos_visible_p, face_before_or_after_it_pos)
3694 (back_to_previous_visible_line_start)
3695 (move_it_in_display_line_to, move_it_in_display_line)
3696 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3697 (try_scrolling, redisplay_window, display_line): Use them when
3698 saving a temporary copy of the iterator and restoring it back.
3699 (back_to_previous_visible_line_start, reseat_1)
3700 (init_iterator): Empty the bidi cache "stack".
3701 (move_it_in_display_line_to): If iterator ended up at
3702 EOL, but we never saw any buffer positions smaller than
3703 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3704 motion in bidi-reordered lines.
3705 (move_it_in_display_line_to): Record prev_method and prev_pos
3706 immediately before the call to set_iterator_to_next. Fixes cursor
3707 motion in bidi-reordered lines with stretch glyphs and strings
3708 displayed in margins. (Bug#8133) (Bug#8867)
3709 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3710 TO_CHARPOS.
640c8776
SM
3711 (pos_visible_p): Support positions in bidi-reordered lines.
3712 Save and restore bidi cache.
0bb23927
EZ
3713
3714 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3715 (bidi_paragraph_info): Delete unused struct.
3716 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3717 (bidi_cache_start): New variable.
3718 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3719 to zero.
3720 (bidi_cache_fetch_state, bidi_cache_search)
3721 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3722 (bidi_cache_find, bidi_peek_at_next_level)
3723 (bidi_level_of_next_char, bidi_find_other_level_edge)
3724 (bidi_move_to_visually_next): Compare cache index with
3725 bidi_cache_start rather than with zero.
3726 (bidi_fetch_char): Accept new argument STRING; all callers
3727 changed. Support iteration over a string. Support strings with
3728 display properties. Support unibyte strings. Fix the type of
3729 `len' according to what STRING_CHAR_AND_LENGTH expects.
3730 (bidi_paragraph_init, bidi_resolve_explicit_1)
3731 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3732 (bidi_level_of_next_char, bidi_move_to_visually_next):
3733 Support iteration over a string.
0bb23927
EZ
3734 (bidi_set_sor_type, bidi_resolve_explicit_1)
3735 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3736 can now be zero (for strings); special values 0 and -1 were
3737 changed to -1 and -2, respectively.
3738 (bidi_char_at_pos): New function.
3739 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3740 Call it instead of FETCH_MULTIBYTE_CHAR.
3741 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3742 initialized to valid values.
3743 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3744 values.
3745 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3746 the test for valid cached positions. Fix the logic for looking up
3747 the sentinel state in the cache. GCPRO the Lisp string we are
3748 iterating.
3749 (bidi_push_it, bidi_pop_it): New functions.
3750 (bidi_initialize): Initialize the bidi cache start stack pointer.
3751 (bidi_cache_ensure_space): New function, refactored from part of
3752 bidi_cache_iterator_state. Don't assume the required size is just
3753 one BIDI_CACHE_CHUNK away.
3754 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3755 (bidi_count_bytes, bidi_char_at_pos): New functions.
3756 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3757 always valid if bidi_cache_idx is valid.
3758 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3759 is valid if it's going to be used.
3760 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3761 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3762 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3763 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3764 (bidi_find_other_level_edge, bidi_cache_start_stack):
3765 All variables related to cache indices are now EMACS_INT.
c965adc5 3766
0bb23927
EZ
3767 * dispextern.h (struct bidi_string_data): New structure.
3768 (struct bidi_it): New member `string'. Make flag members be 1-bit
3769 fields, and put them last in the struct.
640c8776
SM
3770 (compute_display_string_pos, compute_display_string_end):
3771 Update prototypes.
0bb23927
EZ
3772 (bidi_push_it, bidi_pop_it): Add prototypes.
3773 (struct iterator_stack_entry): New members bidi_p,
3774 paragraph_embedding, and from_disp_prop_p.
3775 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3776 (bidi_shelve_cache, bidi_unshelve_cache):
3777 Declare prototypes.
0bb23927
EZ
3778
3779 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3780 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3781 and vector-like objects.
3782
3783 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3784 cache around display iteration.
3785
3786 * window.c (Fwindow_end, window_scroll_pixel_based)
3787 (displayed_window_lines, Frecenter): Save and restore the bidi
3788 cache around display iteration.
3789
3bbd2265
LMI
37902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3791
3792 * editfns.c (Fdelete_region): Clarify the use of the named
3793 parameters (bug#6788).
3794
adc47434
MR
37952011-07-14 Martin Rudalics <rudalics@gmx.at>
3796
3797 * indent.c (Fvertical_motion): Set and restore w->pointm when
3798 saving and restoring the window's buffer (Bug#9006).
3799
837c31f8
LMI
38002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3801
3802 * editfns.c (Fstring_to_char): Clarify just what is returned
3803 (bug#6576). Text by Eli Zaretskii.
3804
ac389d0c
JB
38052011-07-13 Juanma Barranquero <lekktu@gmail.com>
3806
3807 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3808
0be0ce47
EZ
38092011-07-13 Eli Zaretskii <eliz@gnu.org>
3810
3811 * buffer.c (mmap_find): Fix a typo.
3812
cd18e7e3
JB
38132011-07-13 Johan Bockgård <bojohan@gnu.org>
3814
3815 Fix execution of x selection hooks.
3816 * xselect.c (Qx_lost_selection_functions)
3817 (Qx_sent_selection_functions): New vars.
3818 (syms_of_xselect): DEFSYM them.
3819 (x_handle_selection_request): Pass Qx_sent_selection_functions
3820 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3821 (x_handle_selection_clear,x_clear_frame_selections):
3822 Pass Qx_lost_selection_functions rather than
3823 Vx_lost_selection_functions to Frun_hook_with_args.
3824
47ea7f44
PE
38252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3826
ac389d0c 3827 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3828 The old code sometimes used this field without initializing it.
3829
47ea7f44
PE
3830 * alloc.c (gc_sweep): Don't read past end of array.
3831 In theory, the old code could also have corrupted Emacs internals,
3832 though it'd be very unlikely.
3833
bc985c87
AS
38342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3835
3836 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3837 argument. (Bug#4026)
bc985c87 3838
0cf34688
LMI
38392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3840
b3dadd76
LMI
3841 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3842 key" (bug#4257).
3843
0cf34688
LMI
3844 * window.c (Fset_window_start): Doc fix (bug#4199).
3845 (Fset_window_hscroll): Ditto.
3846
270768cd
PE
38472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3848
077e3dda 3849 Fix minor new problems caught by GCC 4.6.1.
270768cd 3850 * term.c (init_tty): Remove unused local.
490011a6 3851 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3852 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3853 not used otherwise.
270768cd 3854
b1f58454
CY
38552011-07-12 Chong Yidong <cyd@stupidchicken.com>
3856
3857 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3858
22b9578d
LMI
38592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3860
6e70ab07
LMI
3861 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3862 are the mini-buffer and the echo area (bug#3320).
3863
22b9578d
LMI
3864 * term.c (init_tty): Remove support for supdup, c10 and perq
3865 terminals, which are no longer supported (bug#1482).
3866
8974cc9f
JB
38672011-07-10 Johan Bockgård <bojohan@gnu.org>
3868
3869 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3870
a560d974
JD
38712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3872
3873 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3874 for non-popups (Bug#3642).
3875
1dae0f0a
AS
38762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3877
268c2c36 3878 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3879 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3880 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3881 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3882 * data.c (fmod): Likewise.
3883 * dispnew.c (swap_glyphs_in_rows): Likewise.
3884 * emacs.c (memory_warning_signal): Likewise.
3885 * floatfns.c (float_error): Likewise.
3886 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3887 (otf_open, font_otf_capability, generate_otf_features)
3888 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3889 Likewise.
3890 * image.c (pbm_read_file): Likewise.
3891 * indent.c (string_display_width): Likewise.
3892 * intervals.c (check_for_interval, search_for_interval)
3893 (inc_interval_count, count_intervals, root_interval)
3894 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3895 * lread.c (defalias): Likewise.
268c2c36 3896 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3897 * regex.c (set_image_of_range_1, set_image_of_range)
3898 (regex_grow_registers): Likewise.
3899 * sysdep.c (strerror): Likewise.
3900 * termcap.c (valid_filename_p, tprint, main): Likewise.
3901 * tparam.c (main): Likewise.
3902 * unexhp9k800.c (run_time_remap, save_data_space)
3903 (update_file_ptrs, read_header, write_header, calculate_checksum)
3904 (copy_file, copy_rest, display_header): Likewise.
3905 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3906 Likewise.
3907 * xdisp.c (check_it): Likewise.
3908 * xfaces.c (register_color, unregister_color, unregister_colors):
3909 Likewise.
3910 * xfns.c (print_fontset_result): Likewise.
3911 * xrdb.c (member, fatal, main): Likewise.
3912
99033785
PE
39132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3914
3915 Fix minor problems found by static checking (Bug#9031).
3916 * chartab.c (char_table_set_range, map_sub_char_table):
3917 Remove unused locals.
3918 (uniprop_table): Now static.
3919 * composite.c (_work_char): Remove unused static var.
3920
9cb2ac56
JB
39212011-07-09 Juanma Barranquero <lekktu@gmail.com>
3922
3923 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3924
f25661f0
JD
39252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3926
3927 * gtkutil.c (qttip_cb): Remove code without function.
3928
8278c4fe
EZ
39292011-07-09 Eli Zaretskii <eliz@gnu.org>
3930
3931 * w32.c (pthread_sigmask): New stub.
3932
1692ae2d 39332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3934
8a6ebd58 3935 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3936 sigprocmask is portable only for single-threaded applications, and
3937 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3938 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3939 (LIBES): Use it.
3940 * callproc.c (Fcall_process):
3941 * process.c (create_process):
3942 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3943 Use pthread_sigmask, not sigprocmask.
123403e4 3944
1b854618
JD
39452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3946
3947 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3948 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3949 wrong (Bug#8591).
3950
3fe4b549
JD
39512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3952
0ce7e563
JD
3953 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3954 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3955 (xg_hide_tooltip): Fix comment.
3956
3fe4b549
JD
3957 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3958 in registerServicesMenuSendTypes.
3959 (validRequestorForSendType): Don't check ns_return_types.
3960
3961 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3962 ns_return_type.
3963
5df75e47
JR
39642011-07-08 Jason Rumney <jasonr@gnu.org>
3965
22610910
JR
3966 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3967 SH_SHOW for hidden windows (Bug#5482).
3968
5df75e47
JR
3969 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3970 frame struct members of non-existent frames (Bug#6284).
3971
699c10bd
JD
39722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3973
4393663b
JD
3974 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3975 variable firstTime not needed on OSX >= 10.6.
3976 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3977 >= 10.5. Use setKnobProportion, setDoubleValue.
3978
3979 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3980 (MAC_OS_X_VERSION_10_5): Define if not defined.
3981 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3982 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3983 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3984
3985 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3986 cString and lossyCString on OSX >= 10.4
3987
58179cce 3988 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3989 sizeToFit on OSX >= 10.2.
3990
3991 * nsimage.m (allocInitFromFile): Don't use deprecated method
3992 bestRepresentationForDevice on OSX >= 10.6.
3993
3994 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3995 to avoid warning.
3996
3997 * emacs.c: Declare unexec_init_emacs_zone.
3998
a63e0781
JD
3999 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4000
699c10bd
JD
4001 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4002
4003 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4004 on svcsMenu (Bug#8842).
4005
4006 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4007 ns_return_types.
4008 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4009
4010 * nsterm.m (QUTF8_STRING): Declare.
4011 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4012 (validRequestorForSendType): Return type is (id).
4013 Change indexOfObjectIdenticalTo to indexOfObject.
4014 Check if we have local selection before returning self (Bug#8842).
4015 (writeSelectionToPasteboard): Put local selection into paste board
4016 if we have a local selection (Bug#8842).
4017 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4018
4019 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4020 (ns_get_local_selection): Declare.
4021
54e10184
LMI
40222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4023
9888ff71
LMI
4024 * keymap.c (describe_map_tree): Don't insert a double newline at
4025 the end of the buffer (bug#1169) and return whether we inserted
4026 something.
4027
54e10184
LMI
4028 * callint.c (Fcall_interactively): Change "reading args" to
4029 "providing args" to try to clarify what it does (bug#1010).
4030
15fa4783
KH
40312011-07-07 Kenichi Handa <handa@m17n.org>
4032
4033 * composite.c (composition_compute_stop_pos): Ignore a static
4034 composition starting before CHARPOS (Bug#8915).
4035
4036 * xdisp.c (handle_composition_prop): Likewise.
4037
a8815b00
EZ
40382011-07-07 Eli Zaretskii <eliz@gnu.org>
4039
4040 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4041 (Bug#9015)
4042
ef7b981d 40432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4044
4045 * character.h (unicode_category_t): New enum type.
4046
4047 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4048 (Qchar_code_property_table): New variable.
4049 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4050 (UNIPROP_COMPRESSED_FORM_P): New macros.
4051 (char_table_ascii): Uncompress the compressed values.
4052 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4053 Uncompress the compressed values.
ac389d0c 4054 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4055 (char_table_ref_and_range): Uncompress the compressed values.
4056 (sub_char_table_set): New arg is_uniprop. Callers changed.
4057 Uncompress the compressed values.
4058 (sub_char_table_set_range): Args changed. Callers changed.
4059 (char_table_set_range): Adjuted for the above change.
4060 (map_sub_char_table): Delete args default_val and parent. Add arg
4061 top. Give decoded values to a Lisp function.
640c8776 4062 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4063 values to a Lisp function. Gcpro more variables.
4064 (uniprop_table_uncompress)
4065 (uniprop_decode_value_run_length): New functions.
4066 (uniprop_decoder, uniprop_decoder_count): New variables.
4067 (uniprop_get_decoder, uniprop_encode_value_character)
4068 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4069 New functions.
4070 (uniprop_encoder, uniprop_encoder_count): New variables.
4071 (uniprop_get_encoder, uniprop_table)
4072 (Funicode_property_table_internal, Fget_unicode_property_internal)
4073 (Fput_unicode_property_internal): New functions.
4074 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4075 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4076 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4077 char-code-property-alist.
4078
640c8776 4079 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4080 Vunicode_category_table.
4081
640c8776 4082 * font.c (font_range): Adjust for the change of
c805dec0
KH
4083 Vunicode_category_table.
4084
76b397fb
DN
40852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4086
4087 * m/iris4d.h: Remove file, move contents ...
4088 * s/irix6-5.h: ... here.
4089
22b4128e
PE
40902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4091
4092 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4093 * alloc.c (mark_buffer):
4094 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4095 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4096 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4097 This isn't true in general, and it's particularly not true
4098 if Emacs is configured with --with-wide-int.
4099 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4100 New macros, used in the buffer.c change.
4101
869795d6
JD
41022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4103
4104 * xsettings.c: Use both GConf and GSettings if both are available.
4105 (store_config_changed_event): Add comment.
4106 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4107 (store_tool_bar_style_changed): New functions.
5e617bc2 4108 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4109 (struct xsettings): Move font inside HAVE_XFT.
4110 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4111 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4112 Move inside HAVE_XFT.
640c8776 4113 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4114 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4115 also.
4116 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4117 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4118 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4119 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4120 (parse_settings): Move check for font inside HAVE_XFT.
4121 (read_settings, apply_xft_settings): Add comment.
4122 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4123 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4124 call store_font_name_changed.
4125 (xft_settings_event): Add comment.
4126 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4127 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4128 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4129 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4130 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4131 (xsettings_get_system_font, xsettings_get_system_normal_font):
4132 Add comment.
869795d6 4133
d8ed26bd
PE
41342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 Random fixes. E.g., (random) never returned negative values.
4137 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4138 subseconds part to the entropy, as that's a bit more random.
4139 Prefer signed to unsigned, since the signedness doesn't matter and
4140 in general we prefer signed. When given a limit, use a
4141 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4142 latter isn't right if USE_2_TAGS_FOR_INTS.
4143 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4144 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4145
cabf1cac
SM
41462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4147
4148 * textprop.c (text_property_stickiness):
4149 Obey Vtext_property_default_nonsticky.
4150 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4151 * w32fns.c (syms_of_w32fns):
4152 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4153
6e9b2be9
PE
41542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4157 This is more efficient than Ffile_directory_p and avoids a minor race.
4158
90186c68
LMI
41592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4160
7c301272
LMI
4161 * buffer.c (Foverlay_put): Say what the return value is
4162 (bug#7835).
4163
c4f2d8d4
LMI
4164 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4165 is a directory before asking whether to use the file name
4166 (bug#7564).
ad637907
LMI
4167 (barf_or_query_if_file_exists): Make the "File is a directory"
4168 error be more correct.
c4f2d8d4 4169
90186c68
LMI
4170 * fns.c (Frequire): Remove the mention of the .gz files, since
4171 that's installation-specific, but keep the mention of
4172 `get-load-suffixes'.
4173
da64016e
PE
41742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4175
4176 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4177 Report string overflow if the output is too long.
4178
7d47b580
JB
41792011-07-04 Juanma Barranquero <lekktu@gmail.com>
4180
a555cb87
JB
4181 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4182 (syms_of_gnutls): Remove duplicate DEFSYM for
4183 Qgnutls_bootprop_verify_hostname_error, an error for
4184 Qgnutls_bootprop_verify_error (which is no longer used).
4185
7d47b580
JB
4186 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4187 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4188 Also (re)move comments that are misplaced or no longer relevant.
4189
1e49bfab
LMI
41902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4191
4192 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4193
1485f4c0
CY
41942011-07-03 Chong Yidong <cyd@stupidchicken.com>
4195
4196 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4197 and background color parameters if they have been changed.
4198
a9ab721e
LMI
41992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4200
4201 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4202
cf7cff57
PE
42032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4204
2e13213d
PE
4205 * xsettings.c (SYSTEM_FONT): Define only when used.
4206 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4207
cf7cff57
PE
4208 * keymap.c (access_keymap_1): Now static.
4209
7a8e04f7
CY
42102011-07-02 Chong Yidong <cyd@stupidchicken.com>
4211
4212 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4213 leave any prefix arg for the up event (Bug#1586).
4214
61352f62
LMI
42152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4216
69bb1ef7
LMI
4217 * lread.c (syms_of_lread): Mention single symbols defined by
4218 `defvar' or `defconst' (bug#7154).
4219
61352f62 4220 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4221 (Frequire): Mention get-load-suffixes.
61352f62 4222
28545e04
MR
42232011-07-02 Martin Rudalics <rudalics@gmx.at>
4224
4225 * window.h (window): Remove clone_number slot.
4226 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4227 Remove.
4228 (make_parent_window, make_window, saved_window)
4229 (Fset_window_configuration, save_window_save): Don't deal with
4230 clone numbers.
4231 * buffer.c (Qclone_number): Remove declaration.
4232 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4233
3349e122
SM
42342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4235
4236 Add multiple inheritance to keymaps.
4237 * keymap.c (Fmake_composed_keymap): New function.
4238 (Fset_keymap_parent): Simplify.
4239 (fix_submap_inheritance): Remove.
4240 (access_keymap_1): New function extracted from access_keymap to handle
4241 embedded parents and handle lists of maps.
4242 (access_keymap): Use it.
4243 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4244 (Fcopy_keymap): Handle embedded parents.
4245 (Fcommand_remapping, define_as_prefix): Simplify.
4246 (Fkey_binding): Simplify.
4247 (syms_of_keymap): Move minibuffer-local-completion-map,
4248 minibuffer-local-filename-completion-map,
4249 minibuffer-local-must-match-map, and
4250 minibuffer-local-filename-must-match-map to Elisp.
4251 (syms_of_keymap): Defsubr make-composed-keymap.
4252 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4253 (parse_menu_item): Trivial simplification.
4254
3279eb87
GM
42552011-07-01 Glenn Morris <rgm@gnu.org>
4256
4257 * Makefile.in (SETTINGS_LIBS): Fix typo.
4258
4550efdf
KI
42592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4260
4261 * coding.c (Fencode_coding_string): Record the last coding system
4262 used, as the function doc string says (bug#8738).
4263
0949d2b6
JD
42642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4265
4266 * xsettings.c (store_monospaced_changed): Take new font as arg and
4267 check for change against current_mono_font.
4268 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4269 (emacs_settings_constructor, emacs_settings_get_property)
4270 (emacs_settings_set_property, emacs_settings_class_init)
4271 (emacs_settings_init, gsettings_obj): Remove.
4272 (something_changedCB): New function for HAVE_GSETTINGS.
4273 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4274 with value as argument.
4275 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4276 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4277 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4278 "changed".
4279
4280 * xgselect.c: Add defined (HAVE_GSETTINGS).
4281 (xgselect_initialize): Ditto.
4282
4283 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4284 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4285 xg_select.
4286
bbc6b304
PE
42872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4288
4289 * eval.c (struct backtrace): Simplify and port the data structure.
4290 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4291 signed bit field, as this assumption is not portable and it makes
4292 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4293 "char debug_on_exit : 1" as this is not portable either; instead,
4294 use the portable "unsigned int debug_on_exit : 1". Remove unused
4295 member evalargs. Remove obsolete comments about cc bombing out.
4296
9851bfc5
JD
42972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4298
51bb811f 4299 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4300 Let HAVE_GSETTINGS override HAVE_GCONF.
4301 (store_monospaced_changed): New function.
4302 (EMACS_SETTINGS): A new type derived from GObject to handle
4303 GSettings notifications.
4304 (emacs_settings_constructor, emacs_settings_get_property)
4305 (emacs_settings_set_property, emacs_settings_class_init):
4306 New functions.
4307 (gsettings_client, gsettings_obj): New variables.
4308 (GSETTINGS_SCHEMA): New define.
4309 (something_changedCB): Call store_monospaced_changed.
4310 (init_gsettings): New function.
4311 (xsettings_initialize): Call init_gsettings.
4312 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4313 to NULL.
4314
640c8776 4315 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4316 GCONF_CFLAGS/LIBS.
4317
5386012d
MR
43182011-06-29 Martin Rudalics <rudalics@gmx.at>
4319
4320 * window.c (resize_root_window, grow_mini_window)
4321 (shrink_mini_window): Rename Qresize_root_window to
4322 Qwindow_resize_root_window and Qresize_root_window_vertically to
4323 Qwindow_resize_root_window_vertically.
4324
f13e0b08
PE
43252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4326
4327 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4328
94515237
JB
43292011-06-27 Juanma Barranquero <lekktu@gmail.com>
4330
4331 * makefile.w32-in: Redesign dependencies so they reflect more
4332 clearly which files are directly included by each source file,
4333 and not through other includes.
4334
e43b6e43
MR
43352011-06-27 Martin Rudalics <rudalics@gmx.at>
4336
4337 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4338 (sort_overlays, overlay_strings): When an overlay's clone number
4339 matches the window's clone number process the overlay even if
4340 the overlay's window property doesn't match the current window.
4341
d68443dc
MR
4342 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4343 (Fwindow_hchild): Rename to Fwindow_left_child.
4344 (Fwindow_next): Rename to Fwindow_next_sibling.
4345 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4346 (resize_window_check): Rename to window_resize_check.
4347 (resize_window_apply): Rename to window_resize_apply.
4348 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4349 (Fdelete_other_windows_internal, resize_frame_windows)
4350 (Fsplit_window_internal, Fdelete_window_internal)
4351 (grow_mini_window, shrink_mini_window)
4352 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4353
c7e73be5
JD
43542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4355
4356 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4357 (emacs_fixed_set_min_size): Remove.
4358 (emacs_fixed_new): Take frame as argument.
4359
4360 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4361 (_EmacsFixedPrivate): Remove minwidth/height.
4362 Add struct frame *f.
4363 (emacs_fixed_init): Initialize priv->f.
4364 (get_parent_class, emacs_fixed_set_min_size): Remove.
4365 (emacs_fixed_new): Set priv->f to argument.
4366 (emacs_fixed_get_preferred_width)
4367 (emacs_fixed_get_preferred_height): Use min_width/height from
4368 frames size_hint to set minimum and natural (Bug#8919).
4369 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4370 and use min_width/height from frames size_hint to set
4371 min_width/height (Bug#8919).
4372
4373 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4374 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4375 Fix indentation.
c7e73be5 4376
cf99dcf8
EZ
43772011-06-26 Eli Zaretskii <eliz@gnu.org>
4378
4379 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4380 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4381 called at ZV.
4382
029529ac
CY
43832011-06-26 Chong Yidong <cyd@stupidchicken.com>
4384
4385 * process.c (wait_reading_process_output): Bypass select if
4386 waiting for a cell while ignoring keyboard input, and input is
4387 pending. Suggested by Jan Djärv (Bug#8869).
4388
7a7ef429
PE
43892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 Use gnulib's dup2 module instead of rolling our own.
4392 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4393
11fdef7d 43942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4395
4396 * dispnew.c (scrolling_window): Before scrolling, turn off a
4397 mouse-highlight in the window being scrolled.
4398
cd3520a4
JB
43992011-06-24 Juanma Barranquero <lekktu@gmail.com>
4400
4401 Move DEFSYM to lisp.h and use everywhere.
4402
4403 * character.h (DEFSYM): Move declaration...
4404 * lisp.h (DEFSYM): ...here.
4405
4406 * gnutls.c:
4407 * minibuf.c:
4408 * w32menu.c:
4409 * w32proc.c:
4410 * w32select.c: Don't include character.h.
4411
4412 * alloc.c (syms_of_alloc):
4413 * buffer.c (syms_of_buffer):
4414 * bytecode.c (syms_of_bytecode):
4415 * callint.c (syms_of_callint):
4416 * casefiddle.c (syms_of_casefiddle):
4417 * casetab.c (init_casetab_once):
4418 * category.c (init_category_once, syms_of_category):
4419 * ccl.c (syms_of_ccl):
4420 * cmds.c (syms_of_cmds):
4421 * composite.c (syms_of_composite):
4422 * dbusbind.c (syms_of_dbusbind):
4423 * dired.c (syms_of_dired):
4424 * dispnew.c (syms_of_display):
4425 * doc.c (syms_of_doc):
4426 * editfns.c (syms_of_editfns):
4427 * emacs.c (syms_of_emacs):
4428 * eval.c (syms_of_eval):
4429 * fileio.c (syms_of_fileio):
4430 * fns.c (syms_of_fns):
4431 * frame.c (syms_of_frame):
4432 * fringe.c (syms_of_fringe):
4433 * insdel.c (syms_of_insdel):
4434 * keymap.c (syms_of_keymap):
4435 * lread.c (init_obarray, syms_of_lread):
4436 * macros.c (syms_of_macros):
4437 * msdos.c (syms_of_msdos):
4438 * print.c (syms_of_print):
4439 * process.c (syms_of_process):
4440 * search.c (syms_of_search):
4441 * sound.c (syms_of_sound):
4442 * syntax.c (init_syntax_once, syms_of_syntax):
4443 * terminal.c (syms_of_terminal):
4444 * textprop.c (syms_of_textprop):
4445 * undo.c (syms_of_undo):
4446 * w32.c (globals_of_w32):
4447 * window.c (syms_of_window):
4448 * xdisp.c (syms_of_xdisp):
4449 * xfaces.c (syms_of_xfaces):
4450 * xfns.c (syms_of_xfns):
4451 * xmenu.c (syms_of_xmenu):
4452 * xsettings.c (syms_of_xsettings):
4453 * xterm.c (syms_of_xterm): Use DEFSYM.
4454
4228cf16
TZ
44552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4456
cd3520a4 4457 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4458
7fcccf1e
PE
44592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4460
7efb4e0e
PE
4461 Integer and buffer overflow fixes (Bug#8873).
4462
ff5844ad
PE
4463 * print.c (printchar, strout): Check for string overflow.
4464 (PRINTPREPARE, printchar, strout):
4465 Don't set size unless allocation succeeds.
4466
90532f02
PE
4467 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4468 for sizes. Check for string overflow more accurately.
4469 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4470
6d84508d
PE
4471 * macros.c: Integer and buffer overflow fixes.
4472 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4473 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4474 Use ptrdiff_t, not int, for sizes.
4475 Don't increment bufsize until after realloc succeeds.
4476 Check for size-calculation overflow.
4477 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4478
437b2cb4
PE
4479 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4480
8b9ac8b4
PE
4481 * lread.c: Integer overflow fixes.
4482 (read_integer): Radix is now EMACS_INT, not int,
4483 to improve quality of diagnostics for out-of-range radices.
4484 Calculate buffer size correctly for out-of-range radices.
4485 (read1): Check for integer overflow in radices, and in
4486 read-circle numbers.
82cb60d3
PE
4487 (read_escape): Avoid int overflow.
4488 (Fload, openp, read_buffer_size, read1)
4489 (substitute_object_recurse, read_vector, read_list, map_obarray):
4490 Use ptrdiff_t, not int, for sizes.
4491 (read1): Use EMACS_INT, not int, for sizes.
20270765 4492 Check for size overflow.
8b9ac8b4 4493
7fcccf1e
PE
4494 * image.c (cache_image): Check for size arithmetic overflow.
4495
bfbbd7e7
PE
4496 * lread.c: Integer overflow issues.
4497 (saved_doc_string_size, saved_doc_string_length)
4498 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4499 Now ptrdiff_t, not int.
4500 (read1): Don't assume doc string length fits in int. Check for
4501 out-of-range doc string lengths.
4502 (read_list): Don't assume file position fits in int.
39019e54 4503 (read_escape): Check for hex character overflow.
bfbbd7e7 4504
4e323265
LL
45052011-06-22 Leo Liu <sdl.web@gmail.com>
4506
4507 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4508 Move to minibuffer.el.
4509
85fece3e
PE
45102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4511
20b84ce9 4512 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4513 The following patches are for when GLYPH_DEBUG && !XASSERT.
4514 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4515 * dispnew.c (flush_stdout):
4516 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4517 Mark as externally visible.
4518 * dispnew.c (check_window_matrix_pointers): Now static.
4519 * dispnew.c (window_to_frame_vpos):
4520 * xfns.c (unwind_create_frame):
4521 * xterm.c (x_check_font): Remove unused local.
4522 * scroll.c (CHECK_BOUNDS):
4523 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4524 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4525 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4526 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4527 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4528 Now static.
4529 (debug_method_add): Use va_list and vsprintf rather than relying
4530 on undefined behavior with wrong number of arguments.
4531 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4532 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4533 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4534 since we're not interested in debugging glyphs with old libraries.
4535 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4536 GCC 4.6.0's static checking.
4537
0766b489
PE
45382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4539
31fd4b32
PE
4540 Integer overflow and signedness fixes (Bug#8873).
4541 A few related buffer overrun fixes, too.
4542
b79e8648
PE
4543 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4544
0766b489
PE
4545 * dispextern.h (struct face.stipple):
4546 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4547 (x_bitmap_mask, x_allocate_bitmap_record)
4548 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4549 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4550 (x_create_bitmap_from_xpm_data):
4551 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4552 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4553 (.bitmaps_last):
4554 * xfaces.c (load_pixmap):
4555 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4556 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4557 (.bitmaps_last, struct x_output.icon_bitmap):
4558 Use ptrdiff_t, not int, for bitmap indexes.
4559 (x_allocate_bitmap_record): Check for size overflow.
4560 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4561
b081724f
PE
4562 Use ptrdiff_t, not int, for overlay counts.
4563 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4564 * editfns.c (overlays_around, get_pos_property):
4565 * textprop.c (get_char_property_and_overlay):
4566 * xdisp.c (next_overlay_change, note_mouse_highlight):
4567 * xfaces.c (face_at_buffer_position):
21514da7
PE
4568 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4569 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4570 (Fnext_overlay_change, Fprevious_overlay_change)
4571 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4572 Use ptrdiff_t, not int, for sizes.
21514da7 4573 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4574
3de73e5e
PE
4575 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4576
2606c57b
PE
4577 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4578 (x_session_initialize): Do not assume string length fits in int.
4579
aaafe47a
PE
4580 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4581 This is unlikely, but can occur if DPI is outlandish.
4582
2674ddc8 4583 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4584 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4585
28154962
PE
4586 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4587 * xrdb.c (magic_file_p, search_magic_path):
4588 Omit last arg SUFFIX; it was always 0. All callers changed.
4589 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4590
7de51af5
PE
4591 * xfont.c (xfont_match): Avoid need for strlen.
4592
25ed6cc3
PE
4593 * xfns.c: Don't assume strlen fits in int.
4594 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4595
4eab31dd
PE
4596 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4597 not unsigned long, as we prefer signed integers. All callers changed.
4598 Detect integer overflow in repeat count.
4599 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4600 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4601
171e2a58
PE
4602 * termcap.c: Don't assume sizes fit in int and never overflow.
4603 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4604 (gobble_line): Check for size-calculation overflow.
4605
ad39faca 4606 * minibuf.c (Fread_buffer):
6e5bb2dc 4607 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4608 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4609 Don't assume string length fits in int.
4610
52c61c22 4611 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4612 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4613
b5b8c9e5
PE
4614 * font.c: Don't assume string length fits in int.
4615 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4616 Use ptrdiff_t, not int.
ccd6111c
PE
4617 (font_intern_prop): Don't assume string length fits in int.
4618 Don't assume integer property fits in fixnum.
4619 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4620
882f0d81 4621 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4622 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4623 Reformulate so as not to need the command string.
4624 Invoke gzip -cd rather than gunzip, as it's more portable.
4625 (lock_info_type, lock_file_1, lock_file):
4626 Don't assume pid_t and time_t fit in unsigned long.
4627 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4628 (current_lock_owner): Prefer signed type for sizes.
4629 Use memcpy, not strncpy, where memcpy is what is really wanted.
4630 Don't assume (via atoi) that time_t and pid_t fit in int.
4631 Check for time_t and/or pid_t out of range, e.g., via a network share.
4632 Don't alloca where an auto var works fine.
4633
93f4cf88
PE
4634 * fileio.c: Fix some integer overflow issues.
4635 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4636 Don't assume string length fits in int.
4637 (directory_file_name): Don't assume string length fits in long.
4638 (make_temp_name): Don't assume pid fits in int, or that its print
4639 length is less than 20.
4640
f3e92b69
PE
4641 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4642
1bfdaf10
PE
4643 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4644
35016e9a
PE
4645 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4646
3d1e65a1
PE
4647 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4648 We prefer signed integers, even for size calculations.
4649
0b963a93
PE
4650 * emacs.c: Don't assume string length fits in 'int'.
4651 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4652 (main): Don't invoke strlen when not needed.
4653
573f4b54
PE
4654 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4655 (XD_DEBUG_MESSAGE): Don't waste a byte.
4656
989f33ba
PE
4657 * callproc.c (getenv_internal_1, getenv_internal)
4658 (Fgetenv_internal):
965d34eb
PE
4659 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4660
e4d29b33
PE
4661 * lread.c (invalid_syntax): Omit length argument.
4662 All uses changed. This doesn't fix a bug, but it simplifies the
4663 code away from its former Hollerith-constant appearance, and it's
4664 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4665 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4666
eb49b136
PE
4667 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4668 This didn't break anything, but it didn't help either.
4669 It's confusing to put a bogus integer in a place where the actual
4670 value does not matter.
9f62aeb1 4671 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4672 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4673
15375a22
PE
4674 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4675 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4676 implementation.
b61cc01c
PE
4677 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4678 We prefer signed types, and the value cannot exceed the EMACS_INT
4679 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4680 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4681 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4682 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4683
53b2623d
PE
4684 * indent.c (sane_tab_width): New function.
4685 (current_column, scan_for_column, Findent_to, position_indentation)
4686 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4687 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4688
51cab52b 4689 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4690
f2ed8a70
PE
4691 * lisp.h (lint_assume): New macro.
4692 * composite.c (composition_gstring_put_cache):
4693 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4694
abe80cc6
PE
4695 * editfns.c, insdel.c:
4696 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4697
b02c740e
PE
4698 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4699
ebc96716
PE
4700 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4701
b4e50fa0 4702 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4703 Use much-faster test for byte-length change.
311d5d7c 4704 Don't assume string byte-length fits in 'int'.
a4cf38e4 4705 Check that character arg fits in 'int'.
85461888 4706 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4707
c0c1ee9f
PE
4708 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4709
a498d7f4
PE
4710 * fns.c (concat): Catch string overflow earlier.
4711 Do not rely on integer wraparound.
4712
51cab52b
PE
4713 * dispextern.h (struct it.overlay_strings_charpos)
4714 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4715 * xdisp.c (forward_to_next_line_start)
4716 (back_to_previous_visible_line_start)
4717 (reseat_at_next_visible_line_start, next_element_from_buffer):
4718 Don't arbitrarily truncate the value of 'selective' to int.
4719
76031fad
PE
4720 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4721
5eb55db9
PE
4722 * composite.c: Don't truncate sizes to 'int'.
4723 (composition_gstring_p, composition_reseat_it)
4724 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4725 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4726 not EMACS_UINT, for indexes.
5eb55db9 4727
0703a717
PE
4728 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4729
d6202519
PE
4730 * buffer.c: Include <verify.h>.
4731 (struct sortvec.priority, struct sortstr.priority):
8961a454 4732 Now EMACS_INT, not int.
c20998a7 4733 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4734 (struct sortstr.size, record_overlay_string)
4735 (struct sortstrlist.size, struct sortlist.used):
4736 Don't truncate size to int.
4737 (record_overlay_string): Check for size-calculation overflow.
d6202519 4738 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4739
d5a19415
JM
47402011-06-22 Jim Meyering <meyering@redhat.com>
4741
029529ac 4742 Don't leak an XBM-image-sized buffer
d5a19415
JM
4743 * image.c (xbm_load): Free the image buffer after using it.
4744
a9041e6c
PE
47452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4746
4747 Port to Sun C.
4748 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4749 that Sun C diagnosed.
4750 * fns.c (secure_hash): Fix pointer signedness issue.
4751 * intervals.c (static_offset_intervals): New function.
4752 (offset_intervals): Use it.
4753
7f3f739f
LL
47542011-06-21 Leo Liu <sdl.web@gmail.com>
4755
4756 * deps.mk (fns.o):
4757 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4758 sha512.h.
4759
4760 * fns.c (secure_hash): Rename from crypto_hash_function and change
4761 the first arg to accept symbols.
5b66d427 4762 (Fsecure_hash): New primitive.
7f3f739f
LL
4763 (syms_of_fns): New symbols.
4764
76147d94
DD
47652011-06-20 Deniz Dogan <deniz@dogan.se>
4766
4767 * process.c (Fset_process_buffer): Clarify return value in
4768 docstring.
4769
7d7d0045
CY
47702011-06-18 Chong Yidong <cyd@stupidchicken.com>
4771
4772 * dispnew.c (add_window_display_history): Use BVAR.
4773
4774 * xdisp.c (debug_method_add): Use BVAR.
4775 (check_window_end, dump_glyph_matrix, dump_glyph)
4776 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4777
4778 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4779 Likewise.
4780
4781 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4782 check till after the cache is created in init_frame_faces.
4783
ff2bc410
SM
47842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4785
4786 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4787
28177add
PE
47882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4789
dd3482fe
PE
4790 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4791 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4792 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4793
393d71f3 4794 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4795 * fileio.c (Finsert_file_contents):
4796 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4797 Remove the old (too-loose) buffer overflow checks.
4798 They weren't needed, since make_gap checks for buffer overflow.
4799 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4800 The old code merely checked for Emacs fixnum overflow, and relied
4801 on undefined (wraparound) behavior. The new code avoids undefined
4802 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4803
2e6813b0 4804 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4805 Tune. Don't use wider integers than needed. Don't use alloca.
4806 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4807
599a9e4f
PE
4808 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4809
99561444
PE
4810 * insdel.c, lisp.h (buffer_overflow): New function.
4811 (insert_from_buffer_1, replace_range, replace_range_2):
4812 * insdel.c (make_gap_larger):
4813 * editfns.c (Finsert_char):
4814 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4815
28177add
PE
4816 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4817
e69dafad
PE
48182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4819
4baa020d 4820 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4821
b1c46f02
PE
4822 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4823 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4824
e69dafad
PE
4825 * fileio.c: Don't assume EMACS_INT fits in off_t.
4826 (emacs_lseek): New static function.
4827 (Finsert_file_contents, Fwrite_region): Use it.
4828 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4829
566684ea
PE
4830 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4831
e6966cd6
PE
4832 * fns.c: Don't overflow int when computing a list length.
4833 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4834 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4835 truncation on 64-bit hosts. Check for QUIT every
4836 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4837 faster and is responsive enough.
4838 (Flength): Report an error instead of overflowing an integer.
4839 (Fsafe_length): Return a float if the value is not representable
4840 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4841 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4842 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4843
dd0b0efb
PE
4844 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4845 (header_size, word_size): New constants.
4846 (allocate_vectorlike): Don't check size overflow here.
4847 (allocate_vector): Check it here instead, since this is the only
4848 caller of allocate_vectorlike that could cause overflow.
4849 Check that the new vector's length is representable as a fixnum.
4850
86fe5cfe
PE
4851 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4852 The previous code was bogus. For example, next_almost_prime (32)
4853 returned 39, which is undesirable as it is a multiple of 3; and
4854 next_almost_prime (24) returned 25, which is a multiple of 5 so
4855 why was the code bothering to check for multiples of 7?
4856
80e88859
PE
4857 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4858
4a2f0ad6
PE
4859 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4860
f66c7cf8
PE
4861 Variadic C functions now count arguments with ptrdiff_t.
4862 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4863 Back then I didn't know that the Emacs coding style prefers signed int.
4864 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4865 were being counted with int, which may truncate counts on 64-bit
4866 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4867 * lisp.h (struct Lisp_Subr.function.aMANY)
4868 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4869 Arg counts are now ptrdiff_t, not size_t.
4870 All variadic functions and their callers changed accordingly.
4871 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4872 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4873 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4874 * callint.c (Fcall_interactively): Check arg count for overflow,
4875 to avoid potential buffer overrun. Use signed char, not 'int',
4876 for 'varies' array, so that we needn't bother to check its size
4877 calculation for overflow.
4878 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4879 * eval.c (apply_lambda):
4880 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4881 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4882 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4883
a1759b76
PE
4884 * callint.c (Fcall_interactively): Don't use index var as event count.
4885
d96be9fc
PE
4886 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4887 * mem-limits.h (SIZE): Remove; no longer used.
4888
a690a978 4889 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4890
578c21e6
PE
4891 Remove unnecessary casts.
4892 * xterm.c (x_term_init):
4893 * xfns.c (x_set_border_pixel):
4894 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4895 These aren't needed now that we assume ANSI C.
4896
96f53c6c
PE
4897 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4898 It's more likely to cause problems (due to unsigned overflow)
4899 than to cure them.
4900
83c77d31
PE
4901 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4902
ee2079f1
PE
4903 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4904
6da65536
PE
4905 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4906
7147c4a4
PE
4907 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4908
193e32d9
PE
4909 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4910
e5533da6
PE
4911 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4912
9910e595
PE
4913 GLYPH_CODE_FACE returns EMACS_INT, not int.
4914 * dispextern.h (merge_faces):
4915 * xfaces.c (merge_faces):
01103c44
PE
4916 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4917 Don't assume EMACS_INT fits in int.
9910e595 4918
2638320e
PE
4919 * character.h (CHAR_VALID_P): Remove unused parameter.
4920 * fontset.c, lisp.h, xdisp.c: All uses changed.
4921
045eb8d9
PE
4922 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4923
c1f134b5
PE
4924 * fns.c (concat): Minor tuning based on overflow analysis.
4925 This doesn't fix any bugs. Use int to hold character, instead
4926 of constantly refetching from Emacs object. Use XFASTINT, not
4927 XINT, for value known to be a character. Don't bother comparing
4928 a single byte to 0400, as it's always less.
4929
395fcb93 4930 * floatfns.c (Fexpt):
327eeec8
PE
4931 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4932
abbd3d23
PE
4933 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4934 for characters.
4935
684a03ef
PE
4936 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4937
0fed43f3
PE
4938 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4939 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4940 incorrectly succeed when S was a string, because 4294967386 was
4941 truncated before it was used.
4942
8fd02eb7
PE
4943 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4944 Otherwise, an out-of-range integer could cause undefined behavior
4945 on a 64-bit host.
4946
f8c86b69
PE
4947 * composite.c: Use int, not EMACS_INT, for characters.
4948 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4949 EMACS_INT, for values that are known to be in character range.
4950 This doesn't fix any bugs but is the usual style inside Emacs and
4951 may generate better code on 32-bit machines.
4952
34206dd2
PE
4953 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4954 This is for reasons similar to the recent CHAR_STRING fix.
4955 * charset.c (Fencode_char): Check that character arg is actually
4956 a character. Pass an int to ENCODE_CHAR.
4957 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4958 wider than 'int', as a compile-time check to prevent future regressions
4959 in this area.
4960
c5958d4c 4961 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4962
4963 Make sure a 64-bit char is never passed to CHAR_STRING.
4964 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4965 by silently ignoring the top 32 bits, allowing some values
4966 that were far too large to be valid characters.
4967 * character.h: Include <verify.h>.
4968 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4969 arguments are no wider than unsigned, as a compile-time check
4970 to prevent future regressions in this area.
4971 * data.c (Faset):
01103c44 4972 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4973 (Fsubst_char_in_region):
4974 * fns.c (concat):
4975 * xdisp.c (decode_mode_spec_coding):
4976 Adjust to CHAR_STRING's new requirement.
4977 * editfns.c (Finsert_char, Fsubst_char_in_region):
4978 * fns.c (concat): Check that character args are actually
4979 characters. Without this test, these functions did the wrong
4980 thing with wildly out-of-range values on 64-bit hosts.
4981
d37ca623
PE
4982 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4983 These casts should not be needed on 32-bit hosts, either.
4984 * keyboard.c (read_char):
4985 * lread.c (Fload): Remove casts to unsigned.
4986
ea204efb
PE
4987 * lisp.h (UNSIGNED_CMP): New macro.
4988 This fixes comparison bugs on 64-bit hosts.
4989 (ASCII_CHAR_P): Use it.
4990 * casefiddle.c (casify_object):
01103c44 4991 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4992 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4993 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4994 * dispextern.h (FACE_FROM_ID):
4995 * keyboard.c (read_char): Use UNSIGNED_CMP.
4996
41cb286c
PE
4997 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4998 not to EMACS_INT, to avoid GCC warning.
4999
4a1b9832
PE
5000 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5001
55daad71
PE
5002 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5003 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5004 isn't needed on 32-bit machines.
8f95c75c 5005
01103c44
PE
5006 * buffer.c (Fgenerate_new_buffer_name):
5007 Use EMACS_INT for count, not int.
0ceccced 5008 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5009
5010 * data.c (Qcompiled_function): Now static.
5011
c6f072e7
PE
5012 * window.c (window_body_lines): Now static.
5013
20ce5912
PE
5014 * image.c (gif_load): Rename local to avoid shadowing.
5015
9c4c5f81
PE
5016 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5017 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5018 * alloc.c (make_save_value): Integer argument is now of type
5019 ptrdiff_t, not int.
5020 (mark_object): Use ptrdiff_t, not int.
5021 * lisp.h (pD): New macro.
5022 * print.c (print_object): Use it.
5023
c0c5c8ae
PE
5024 * alloc.c: Use EMACS_INT, not int, to count objects.
5025 (total_conses, total_markers, total_symbols, total_vector_size)
5026 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5027 (total_free_floats, total_floats, total_free_intervals)
5028 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5029 Now EMACS_INT, not int. All uses changed.
5030 (Fgarbage_collect): Compute overall total using a double, so that
5031 integer overflow is less likely to be a problem. Check for overflow
5032 when converting back to an integer.
5a25e253
PE
5033 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5034 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5035 These were 'int' variables that could overflow on 64-bit hosts;
5036 they were never used, so remove them instead of repairing them.
211a0b2a 5037 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5038 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5039 Previously, this ceilinged at INT_MAX, but that doesn't work on
5040 64-bit machines.
e46bb31a 5041 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5042
c78baabf 5043 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5044 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5045 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5046 when a (possibly-narrower) signed value would do just as well.
5047 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5048
c9d624c6
PE
5049 * alloc.c: Catch some string size overflows that we were missing.
5050 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5051 for convenience in STRING_BYTES_MAX.
5052 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5053 The definition here is exact; the one in lisp.h was approximate.
5054 (allocate_string_data): Check for string overflow. This catches
5055 some instances we weren't catching before. Also, it catches
5056 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5057 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5058 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5059
c9d624c6
PE
5060 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5061 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5062 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5063
353032ce
PE
5064 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5065
2bccce07
PE
5066 * alloc.c (Fmake_string): Check for out-of-range init.
5067
0ac30604
SM
50682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5069
5070 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5071
c195f2de
JD
50722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5073
5074 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5075 xg_get_default_scrollbar_width.
5076
5077 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5078 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5079 (style_changed_cb): Call update_theme_scrollbar_width and call
5080 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5081 all frames (Bug#8505).
5082 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5083 Call gtk_window_set_resizable if HAVE_GTK3.
5084 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5085 and height if HAVE_GTK3 (Bug#8505).
5086 (scroll_bar_width_for_theme): New variable.
5087 (update_theme_scrollbar_width): New function.
5088 (xg_get_default_scrollbar_width): Move code to
5089 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5090 (xg_initialize): Call update_theme_scrollbar_width.
5091
5092 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5093
5094 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5095
e10ac9f1
MR
50962011-06-12 Martin Rudalics <rudalics@gmx.at>
5097
5098 * frame.c (make_frame): Call other_buffer_safely instead of
5099 other_buffer.
5100
5101 * window.c (temp_output_buffer_show): Call display_buffer with
5102 second argument Vtemp_buffer_show_specifiers and reset latter
5103 immediately after the call.
5104 (Vtemp_buffer_show_specifiers): New variable.
5105 (auto_window_vscroll_p, next_screen_context_lines)
5106 (Vscroll_preserve_screen_position): Remove leading asterisks from
5107 doc-strings.
5108
2d3c217e 51092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5110
7b7f97e8 5111 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5112 * buffer.c (Qclone_number): Remove for now, as it's unused.
5113 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5114 (record_buffer): Remove unused local.
5115 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5116 (set_frame_buffer_list): Remove; unused.
5117 * frame.h (other_visible_frames): Remove decl.
5118 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5119 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5120 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5121 if HAVE_GPM.
5122 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5123 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5124 Define only if HAVE_GPM.
5125 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5126 (update_hints_inhibit): Remove; never set. All uses removed.
5127 * widgetprv.h (emacsFrameClassRec): Remove decl.
5128 * window.c (delete_deletable_window): Now returns void, since it
5129 wasn't returning anything.
5130 (compare_window_configurations): Remove unused locals.
5131 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5132 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5133 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5134 the same widths as pointers. This follows up on the 2011-05-06 patch.
5135 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5136 * xterm.h: Likewise.
5137 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5138
1384b89e
JB
51392011-06-12 Juanma Barranquero <lekktu@gmail.com>
5140
5141 * makefile.w32-in: Update dependencies.
5142 (LISP_H): Add lib/intprops.h.
5143
1100a63c
CY
51442011-06-11 Chong Yidong <cyd@stupidchicken.com>
5145
5146 * image.c (gif_load): Add animation frame delay to the metadata.
5147 (syms_of_image): Use DEFSYM. New symbol `delay'.
5148
6198ccd0
MR
51492011-06-11 Martin Rudalics <rudalics@gmx.at>
5150
5151 * window.c (delete_deletable_window): Re-add.
5152 (Fset_window_configuration): Rewrite to handle dead buffers and
5153 consequently deletable windows.
5154 (window_tree, Fwindow_tree): Remove. Supply functionality in
5155 window.el.
5156 (compare_window_configurations): Simplify code.
5157
b6e3633c
AS
51582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5159
1ab0dee5
AS
5160 * image.c (imagemagick_load_image): Fix type mismatch.
5161 (Fimagemagick_types): Likewise.
5162
b6e3633c
AS
5163 * window.h (replace_buffer_in_windows): Declare.
5164
9397e56f
MR
51652011-06-11 Martin Rudalics <rudalics@gmx.at>
5166
5167 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5168 Qclone_number. Remove external declaration of Qdelete_window.
5169 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5170 code.
640c8776
SM
5171 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5172 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5173 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5174 buffer list implementation.
5175 (other_buffer_safely): New function.
5176 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5177 calls to replace_buffer_in_windows and
5178 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5179 if allowed.
5180 (record_buffer): Inhibit quitting and rewrite using quittable
5181 functions. Run Qbuffer_list_update_hook if allowed.
5182 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5183 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5184 Move switch-to-buffer to window.el.
9397e56f
MR
5185 (bury-buffer): Move to window.el.
5186 (Vbuffer_list_update_hook): New variable.
5187
5188 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5189 section.
5190
5191 * window.h (resize_frame_windows): Move up in code.
5192 (Fwindow_frame): Remove EXFUN.
5193 (replace_buffer_in_all_windows): Remove prototype.
5194 (replace_buffer_in_windows_safely): Add prototype.
5195
5196 * window.c: Declare Qdelete_window static again. Move down
5197 declaration of select_count.
5198 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5199 (Fother_window): Move to window.el.
5200 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5201 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5202 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5203 window.el.
5204 (replace_buffer_in_windows): Implement by calling
5205 Qreplace_buffer_in_windows.
5206 (replace_buffer_in_all_windows): Remove with some functionality
5207 moved into replace_buffer_in_windows_safely.
5208 (replace_buffer_in_windows_safely): New function.
5209 (select_window_norecord, select_frame_norecord): Move in front
5210 of run_window_configuration_change_hook. Remove now obsolete
5211 declarations.
640c8776
SM
5212 (Fset_window_buffer): Rewrite doc-string.
5213 Call Qrecord_window_buffer.
9397e56f
MR
5214 (keys_of_window): Move binding for other-window to window.el.
5215
b50691aa
CY
52162011-06-11 Chong Yidong <cyd@stupidchicken.com>
5217
5218 * dispextern.h (struct image): Replace data member, whose int_val
5219 and ptr_val fields were not used by anything, with a single
5220 lisp_val object.
5221
5222 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5223 (gif_clear_image, gif_load, imagemagick_load_image)
5224 (gs_clear_image, gs_load): Callers changed.
5225
3f754b86
PE
52262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5227
cca69397
PE
5228 * buffer.h: Include <time.h>, for time_t.
5229 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5230
109e28d0
PE
5231 Fix minor problems found by static checking.
5232
60737f02
PE
5233 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5234
4b66faf3
PE
5235 Make identifiers static if they are not used in other modules.
5236 * data.c (Qcompiled_function, Qframe, Qvector):
5237 * image.c (QimageMagick, Qsvg):
5238 * minibuf.c (Qmetadata):
5239 * window.c (resize_window_check, resize_root_window): Now static.
5240 * window.h (resize_window_check, resize_root_window): Remove decls.
5241
109e28d0
PE
5242 * window.c (window_deletion_count, delete_deletable_window):
5243 Remove; unused.
46a4ce9e
PE
5244 (window_body_lines): Now static.
5245 (Fdelete_other_windows_internal): Mark vars as initialized.
5246 Make sure 'resize_failed' is initialized.
5247 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5248 (resize_window_apply): Remove unused local.
5249 * window.h (delete_deletable_window): Remove decl.
5250
109e28d0 5251 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5252 (imagemagick_load_image): Fix pointer signedness problem by changing
5253 last arg from unsigned char * to char *. All uses changed.
5254 Also, fix a local for similar reasons.
5255 Remove unused locals. Remove locals to avoid shadowing.
5256 (fn_rsvg_handle_free): Remove; unused.
5257 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5258 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5259
3f754b86
PE
5260 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5261
2547adb1
CY
52622011-06-10 Chong Yidong <cyd@stupidchicken.com>
5263
5264 * image.c (gif_load): Fix omitted cast error introduced by
5265 2011-06-06 change.
5266
2c8e37d4
MR
52672011-06-10 Martin Rudalics <rudalics@gmx.at>
5268
5269 * window.h (resize_proportionally, orig_total_lines)
5270 (orig_top_line): Remove from window structure.
5271 (set_window_height, set_window_width, change_window_heights)
5272 (Fdelete_window): Remove prototypes.
5273 (resize_frame_windows): Remove duplicate declaration.
5274
440a42e3
EZ
52752011-06-10 Eli Zaretskii <eliz@gnu.org>
5276
5277 * window.h (resize_frame_windows, resize_window_check)
5278 (delete_deletable_window, resize_root_window)
5279 (resize_frame_windows): Declare prototypes.
5280
5281 * window.c (resize_window_apply): Make definition be "static" to
5282 match the prototype.
5283
562dd5e9
MR
52842011-06-10 Martin Rudalics <rudalics@gmx.at>
5285
5286 * window.c: Remove declarations of Qwindow_size_fixed,
5287 window_min_size_1, window_min_size_2, window_min_size,
5288 size_window, window_fixed_size_p, enlarge_window, delete_window.
5289 Remove static from declaration of Qdelete_window, it's
5290 temporarily needed by Fbury_buffer.
5291 (replace_window): Don't assign orig_top_line and
5292 orig_total_lines.
5293 (Fdelete_window, delete_window): Remove. Window deletion is
5294 handled by window.el.
640c8776
SM
5295 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5296 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5297 (Fdelete_other_windows): Remove. Deleting other windows is
5298 handled by window.el.
5299 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5300 handled in window.el.
5301 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5302 Window minimum sizes are handled in window.el.
5303 (shrink_windows, size_window, set_window_height)
5304 (set_window_width, change_window_heights, window_height)
5305 (window_width, CURBEG, CURSIZE, enlarge_window)
5306 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5307 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5308 handled in window.el.
5309 (make_dummy_parent): Rename to make_parent_window and give it a
5310 second argument horflag.
5311 (make_window): Don't set resize_proportionally any more.
5312 (Fsplit_window): Remove. Windows are split in window.el.
5313 (save_restore_action, save_restore_orig_size)
5314 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5315 Resize mini windows in window.el.
5316 (grow_mini_window, shrink_mini_window): Implement by calling
5317 Qresize_root_window_vertically, resize_window_check and
5318 resize_window_apply.
640c8776
SM
5319 (saved_window, Fset_window_configuration, save_window_save):
5320 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5321 resize_proportionally.
5322 (window_min_height, window_min_width): Move to window.el.
5323 (keys_of_window): Move bindings for delete-other-windows,
5324 split-window, delete-window and enlarge-window to window.el.
5325
5326 * buffer.c: Temporarily extern Qdelete_window.
5327 (Fbury_buffer): Temporarily call Qdelete_window instead of
5328 Fdelete_window (Fbury_buffer will move to window.el soon).
5329
5330 * frame.c (set_menu_bar_lines_1): Remove code handling
5331 orig_top_line and orig_total_lines.
5332
5333 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5334 set_window_height but set heights directly.
5335 (change_frame_size_1): Use resize_frame_windows.
5336
5337 * xdisp.c (init_xdisp): Don't use set_window_height but set
5338 heights directly.
5339
640c8776
SM
5340 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5341 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5342 run_window_configuration_change_hook.
5343
5344 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5345 instead of change_window_heights and run
5346 run_window_configuration_change_hook.
5347
1a13852e
MR
53482011-06-09 Martin Rudalics <rudalics@gmx.at>
5349
5350 * window.c (replace_window): Rename second argument REPLACEMENT to
5351 NEW. New third argument SETFLAG. Rewrite.
5352 (delete_window, make_dummy_parent): Call replace_window with
5353 third argument 1.
5354 (window_list_1): Move down in code.
5355 (run_window_configuration_change_hook): Move set_buffer part
5356 before select_frame_norecord part in order to unwind correctly.
5357 Rename count1 to count.
5358 (recombine_windows, delete_deletable_window, resize_root_window)
5359 (Fdelete_other_windows_internal)
5360 (Frun_window_configuration_change_hook, make_parent_window)
5361 (resize_window_check, resize_window_apply, Fresize_window_apply)
5362 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5363 (Fdelete_window_internal, Fresize_mini_window_internal):
5364 New functions.
1a13852e
MR
5365 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5366
f3d1777e
MR
53672011-06-08 Martin Rudalics <rudalics@gmx.at>
5368
496e208e
MR
5369 * window.h (window): Add some new members to window structure -
5370 normal_lines, normal_cols, new_total, new_normal, clone_number,
5371 splits, nest, prev_buffers, next_buffers.
5372 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5373 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5374
f3d1777e
MR
5375 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5376 Remove.
496e208e
MR
5377 (make_dummy_parent): Set new members of windows structure.
5378 (make_window): Move down in code. Handle new members of window
5379 structure.
5380 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5381 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5382 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5383 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5384 (Fset_window_next_buffers, Fset_window_clone_number):
5385 New functions.
496e208e
MR
5386 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5387 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5388 Doc-string fixes.
5389 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5390 Argument WINDOW can be now internal window too.
5391 (Fwindow_use_time): Move up in code.
5392 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5393 Rewrite doc-string.
5394 (Fset_window_configuration, saved_window)
5395 (Fcurrent_window_configuration, save_window_save): Handle new
5396 members of window structure.
b9e809c2
MR
5397 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5398 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5399 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5400 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5401 Qget_mru_window, Qresize_root_window,
5402 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5403 Qauto_buffer_name; staticpro them.
f3d1777e 5404
abde8f8c
MR
54052011-06-07 Martin Rudalics <rudalics@gmx.at>
5406
5407 * window.c (Fwindow_total_size, Fwindow_left_column)
5408 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5409 (Fwindow_list_1): New functions.
5410 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5411 (Fwindow_width, Fscroll_left, Fscroll_right):
5412 Use window_body_cols instead of window_box_text_cols.
5413 (delete_window, Fset_window_configuration):
5414 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5415 (delete_all_subwindows): Take a window as argument and not a
5416 structure. Rewrite.
190b47e6
MR
5417 (window_loop): Remove handling of GET_LRU_WINDOW and
5418 GET_LARGEST_WINDOW.
5419 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5420
5421 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5422 window_box_text_cols. delete_all_subwindows now takes a
5423 Lisp_Object as argument.
abde8f8c 5424
640c8776
SM
5425 * indent.c (compute_motion, Fcompute_motion):
5426 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5427
fa8a67e6
MR
5428 * frame.c (delete_frame): Call delete_all_subwindows with root
5429 window as argument.
5430
a54e3482
DC
54312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5432
5433 * fns.c (Fputhash): Document return value.
5434
60002bf5
CY
54352011-06-06 Chong Yidong <cyd@stupidchicken.com>
5436
5437 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5438
0c671da6 54392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5440
b862a52a 5441 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5442
be44ca6c
PE
5443 Check for overflow when converting integer to cons and back.
5444 * charset.c (Fdefine_charset_internal, Fdecode_char):
5445 Use cons_to_unsigned to catch overflow.
5446 (Fencode_char): Use INTEGER_TO_CONS.
5447 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5448 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5449 * data.c (long_to_cons, cons_to_long): Remove.
5450 (cons_to_unsigned, cons_to_signed): New functions.
5451 These signal an error for invalid or out-of-range values.
5452 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5453 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5454 * font.c (Ffont_variation_glyphs):
5455 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5456 * lisp.h: Include <intprops.h>.
5457 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5458 (cons_to_signed, cons_to_unsigned): New decls.
5459 (long_to_cons, cons_to_long): Remove decls.
5460 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5461 (Fprimitive_undo): Use CONS_TO_INTEGER.
5462 * xfns.c (Fx_window_property): Likewise.
5463 * xselect.c: Include <limits.h>.
5464 (x_own_selection, selection_data_to_lisp_data):
5465 Use INTEGER_TO_CONS.
5466 (x_handle_selection_request, x_handle_selection_clear)
5467 (x_get_foreign_selection, Fx_disown_selection_internal)
5468 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5469 (lisp_data_to_selection_data): Use cons_to_unsigned.
5470 (x_fill_property_data): Use cons_to_signed.
5471 Report values out of range.
5472
d1f3d2af
PE
5473 Check for buffer and string overflow more precisely.
5474 * buffer.h (BUF_BYTES_MAX): New macro.
5475 * lisp.h (STRING_BYTES_MAX): New macro.
5476 * alloc.c (Fmake_string):
5477 * character.c (string_escape_byte8):
5478 * coding.c (coding_alloc_by_realloc):
5479 * doprnt.c (doprnt):
5480 * editfns.c (Fformat):
5481 * eval.c (verror):
5482 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5483 since they may not be the same number.
5484 * editfns.c (Finsert_char):
5485 * fileio.c (Finsert_file_contents):
5486 Likewise for BUF_BYTES_MAX.
5487
dd52fcea
PE
5488 * image.c: Use ptrdiff_t, not int, for sizes.
5489 (slurp_file): Switch from int to ptrdiff_t.
5490 All uses changed.
5491 (slurp_file): Check that file size fits in both size_t (for
5492 malloc) and ptrdiff_t (for sanity and safety).
5493
7f9bbdbb
PE
5494 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5495 if b->modtime has its maximal value.
5496
dfe18f82
PE
5497 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5498
84acfcf0
PE
5499 Don't assume time_t can fit into int.
5500 * buffer.h (struct buffer.modtime): Now time_t, not int.
5501 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5502 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5503
ccd9a01a
PE
5504 Minor fixes for signed vs unsigned integers.
5505 * character.h (MAYBE_UNIFY_CHAR):
5506 * charset.c (maybe_unify_char):
5507 * keyboard.c (read_char, reorder_modifiers):
5508 XINT -> XFASTINT, since the integer must be nonnegative.
5509 * ftfont.c (ftfont_spec_pattern):
5510 * keymap.c (access_keymap, silly_event_symbol_error):
5511 XUINT -> XFASTINT, since the integer must be nonnegative.
5512 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5513 since it makes no difference and we prefer signed.
5514 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5515 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5516 nonnegative.
5517
d6d100dd
SM
55182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5519
5520 * window.h (Fwindow_frame): Declare.
5521
2b6148e4
PE
55222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5523
5524 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5525 (SPARE_MEMORY): Always define.
5526 (LARGE_REQUEST): Remove.
5527 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5528
f230ecc9
MR
55292011-06-06 Martin Rudalics <rudalics@gmx.at>
5530
727e958e
MR
5531 * lisp.h: Move EXFUNS for Fframe_root_window,
5532 Fframe_first_window and Fset_frame_selected_window to window.h.
5533
5534 * window.h: Move EXFUNS for Fframe_root_window,
5535 Fframe_first_window and Fset_frame_selected_window here from
5536 lisp.h.
5537
5538 * frame.c (Fwindow_frame, Fframe_first_window)
5539 (Fframe_root_window, Fframe_selected_window)
5540 (Fset_frame_selected_window): Move to window.c.
5541 (Factive_minibuffer_window): Move to minibuf.c.
5542 (Fother_visible_frames_p): New function.
5543
5544 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5545
f230ecc9
MR
5546 * window.c (decode_window, decode_any_window): Move up in code.
5547 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5548 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5549 (Fwindow_buffer): Move up and rewrite doc-string.
5550 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5551 (Fwindow_prev): New functions.
727e958e
MR
5552 (Fwindow_frame): Move here from frame.c. Accept any window as
5553 argument.
5554 (Fframe_root_window, Fframe_first_window)
5555 (Fframe_selected_window): Move here from frame.c. Accept frame
5556 or arbitrary window as argument. Update doc-strings.
5557 (Fminibuffer_window): Move up in code.
5558 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5559 (Fset_frame_selected_window): Move here from frame.c.
5560 Marginal rewrite.
727e958e
MR
5561 (Fselected_window, select_window, Fselect_window): Move up in
5562 code. Minor doc-string fixes.
f230ecc9 5563
4d09bcf6
PE
55642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5565
5566 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5567 Do not assume that spare memory exists; that assumption is valid
5568 only if SYSTEM_MALLOC.
5569 (LARGE_REQUEST): New macro, so that the issue of large requests
5570 is separated from the issue of spare memory.
5571
810928a2
AS
55722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5573
172418ad
AS
5574 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5575 format. (Bug#8806)
5576
43f862f7
AS
5577 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5578
810928a2
AS
5579 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5580 before statements.
5581
a059fe24
JD
55822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5583
5584 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5585
5586 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5587
5588 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5589 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5590
989bf368
JB
55912011-06-05 Juanma Barranquero <lekktu@gmail.com>
5592
5593 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5594
4b80f674
CY
55952011-06-04 Chong Yidong <cyd@stupidchicken.com>
5596
5597 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5598 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5599 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5600 New error handlers.
4b80f674
CY
5601 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5602 Obey Vx_select_enable_clipboard_manager. Catch errors in
5603 x_clipboard_manager_save (Bug#8779).
5604 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5605 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5606
99a33b77 56072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5608
5609 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5610
99a33b77 56112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5612
5613 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5614 in the current matrix if keep_current_p is non-zero.
5615
8264569d
EZ
56162011-06-04 Eli Zaretskii <eliz@gnu.org>
5617
5618 * bidi.c (bidi_level_of_next_char): Fix last change.
5619
57f97249
EZ
56202011-06-03 Eli Zaretskii <eliz@gnu.org>
5621
fec2107c 5622 Support bidi reordering of text covered by display properties.
57f97249 5623
fec2107c
EZ
5624 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5625 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5626 (bidi_cache_search, bidi_cache_iterator_state)
5627 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5628 (bidi_level_of_next_char, bidi_move_to_visually_next):
5629 Support character positions inside a run of characters covered by a
fec2107c
EZ
5630 display string.
5631 (bidi_paragraph_init, bidi_resolve_explicit_1)
5632 (bidi_level_of_next_char): Call bidi_fetch_char and
5633 bidi_fetch_char_advance instead of FETCH_CHAR and
5634 FETCH_CHAR_ADVANCE.
5635 (bidi_init_it): Initialize new members.
5636 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5637 definitions.
5638 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5639 instead of using explicit *_CHAR codes.
d6d100dd
SM
5640 (bidi_resolve_explicit, bidi_resolve_weak):
5641 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5642 bidirectional text is supported only in multibyte buffers.
5643 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5644 it to initialize the frame_window_p member of struct bidi_it.
5645 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5646 (bidi_resolve_explicit, bidi_resolve_weak)
5647 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5648 bidi_it->nchars is non-positive.
5649 (bidi_level_of_next_char): Don't try to lookup the cache for the
5650 next/previous character if nothing is cached there yet, or if we
5651 were just reseat()'ed to a new position.
c40e2fb2 5652
0e14fe90
EZ
5653 * xdisp.c (set_cursor_from_row): Set start and stop points
5654 according to the row's direction when priming the loop that looks
5655 for the glyph on which to display cursor.
5656 (single_display_spec_intangible_p): Function deleted.
5657 (display_prop_intangible_p): Reimplement to call
5658 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5659 Accept 3 additional arguments needed by handle_display_spec.
5660 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5661 values: lists, `(when COND...)' forms, etc.
5662 (single_display_spec_string_p): Support property values that are
5663 lists with the argument STRING its top-level element.
5664 (display_prop_string_p): Fix the condition for processing a
5665 property that is a list to be consistent with handle_display_spec.
fec2107c 5666 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5667 last portion of handle_display_prop.
5668 (compute_display_string_pos): Accept additional argument
5669 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5670 value of a `display' property is a "replacing spec".
5671 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5672 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5673 the display property, but just return a value indicating whether
5674 the display property will replace the characters it covers.
5675 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5676 frame_window_p members of struct bidi_it.
d6d100dd
SM
5677 (compute_display_string_pos, compute_display_string_end):
5678 New functions.
fec2107c
EZ
5679 (push_it): Accept second argument POSITION, where pop_it should
5680 jump to continue iteration.
5681 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5682
fec2107c
EZ
5683 * keyboard.c (adjust_point_for_property): Adjust the call to
5684 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5685
5686 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5687 (bidi_init_it): Update prototypes.
5688 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5689 (compute_display_string_pos, compute_display_string_end):
5690 Declare prototypes.
fec2107c
EZ
5691 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5692 EMACS_INT.
fc6f18ce 5693
40087514 56942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5695
57f53182
PE
5696 Malloc failure behavior now depends on size of allocation.
5697 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5698 * lisp.h: Change signatures accordingly.
5699 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5700 All callers changed. (Bug#8762)
5701
5702 * gnutls.c: Use Emacs's memory allocators.
5703 Without this change, the gnutls library would invoke malloc etc.
5704 directly, which causes problems on non-SYNC_INPUT hosts, and which
5705 runs afoul of improving memory_full behavior. (Bug#8761)
5706 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5707 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5708 xfree instead of the default malloc, realloc, free.
5709 (Fgnutls_boot): No need to check for memory allocation failure,
5710 since xmalloc does that for us.
5711
ac32cd99 5712 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5713 * category.c (hash_get_category_set):
5714 * ccl.c (ccl_driver):
5715 * charset.c (Fdefine_charset_internal):
5716 * charset.h (struct charset.hash_index):
5717 * composite.c (get_composition_id, gstring_lookup_cache)
5718 (composition_gstring_put_cache):
5719 * composite.h (struct composition.hash_index):
5720 * dispextern.h (struct image.hash):
5721 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5722 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5723 (hashfn_equal, hashfn_user_defined, make_hash_table)
5724 (maybe_resize_hash_table, hash_lookup, hash_put)
5725 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5726 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5727 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5728 * image.c (make_image, search_image_cache, lookup_image)
5729 (xpm_put_color_table_h):
5730 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5731 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5732 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5733 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5734 * alloc.c (allocate_vectorlike):
5735 Check for overflow in vector size calculations.
5736 * ccl.c (ccl_driver):
5737 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5738 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5739 need to be updated by these changes.
40087514
PE
5740 * fns.c (make_hash_table, maybe_resize_hash_table):
5741 Check for integer overflow with large hash tables.
0de4bb68
PE
5742 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5743 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5744 (SXHASH_REDUCE): New macro.
5745 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5746 Use it instead of discarding useful hash info with large hash values.
5747 (sxhash_float): New function.
5748 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5749 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5750 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5751 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5752 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5753 Adjust signatures to match updated version of code.
5754 (consing_since_gc): Now EMACS_INT, since a single hash table can
5755 use more than INT_MAX bytes.
5756
698d32e2
DN
57572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5758
5759 Make it possible to build with GCC-4.6+ -O2 -flto.
5760
5761 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5762
fd6fa53f
SM
57632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5764
5765 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5766 Call minibuffer-inactive-mode.
5767
864db017
JB
57682011-05-31 Juanma Barranquero <lekktu@gmail.com>
5769
5770 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5771 Update dependencies.
5772
2ad0baf4
DN
57732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5774
5775 * data.c (init_data): Remove code for UTS, this system is not
5776 supported anymore.
5777
4fcc2638
DN
57782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5779
5780 Don't force ./temacs to start in terminal mode.
5781
5782 * frame.c (make_initial_frame): Initialize faces in all cases, not
5783 only when CANNOT_DUMP is defined.
5784 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5785
c56e0fd5
DN
57862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5787
5788 * dispnew.c (add_window_display_history): Use const for the string
5789 pointer. Remove declaration, not needed.
5790
333d54da 57912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5792
55d4c1b2 5793 Use 'inline', not 'INLINE'.
333d54da 5794 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5795 * alloc.c, fontset.c (INLINE): Remove.
5796 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5797 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5798 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5799 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5800 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5801
738db178
DN
58022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5803
5804 Make it possible to run ./temacs.
5805
5806 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5807 syms_of_callproc does the same thing. Remove test for
5808 "initialized", do it in the caller.
5809 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5810
620c53a6
SM
58112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5812
5813 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5814 (read_minibuf): Use get_minibuffer.
5815 (syms_of_minibuf): Use DEFSYM.
5816 (Qmetadata): New var.
5817 * data.c (Qbuffer): Don't make it static.
5818 (syms_of_data): Use DEFSYM.
5819
e003a292
PE
58202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5821
5822 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5823 (CCL_CODE_MIN): New macro.
5824
ed008a6d
PE
58252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5826
3687c2ef
PE
5827 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5828
ed008a6d
PE
5829 * eval.c (Qdebug): Now static.
5830 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5831 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5832 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5833
d66c4c7c
CY
58342011-05-29 Chong Yidong <cyd@stupidchicken.com>
5835
5836 * image.c: Various fixes to ImageMagick code comments.
5837 (Fimagemagick_types): Doc fix.
5838
5fbc2025
PE
58392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5840
0196f88a
PE
5841 Minor fixes prompted by GCC 4.6.0 warnings.
5842
5843 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5844
5fbc2025
PE
5845 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5846 (x_clipboard_manager_save_all): Move extern decl to ...
5847 * xterm.h: ... here, so that it can be checked for consistency.
5848
1dd3c2d9
CY
58492011-05-29 Chong Yidong <cyd@stupidchicken.com>
5850
5851 * xselect.c (x_clipboard_manager_save_frame)
5852 (x_clipboard_manager_save_all): New functions.
5853 (Fx_clipboard_manager_save): Lisp function deleted.
5854
5855 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5856 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5857
5858 * xterm.h: Update prototype.
5859
5ba6571d
WX
58602011-05-28 William Xu <william.xwl@gmail.com>
5861
5862 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5863 exiting (Bug#8239).
5864
3eaff834
JM
58652011-05-28 Jim Meyering <meyering@redhat.com>
5866
e1900994 5867 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5868 * fns.c (to_uchar): Define.
5869 (crypto_hash_function): Use it to convert some newly-signed
5870 variables to unsigned, to avoid sign-extension bugs. For example,
5871 without this change, (md5 "truc") would evaluate to
5872 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5873 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5874 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5875
0f6990a7
PE
58762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5877
5878 Integer overflow fixes.
c8a9ca5a 5879
08686060
PE
5880 * dbusbind.c: Serial number integer overflow fixes.
5881 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5882 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5883 to hold a serial number that is too large for a fixnum.
5884 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5885 Check for serial numbers out of range. Decode any serial number
59568bf0 5886 that was so large that it became a float. (Bug#8722)
08686060 5887
2d1fc3c7
PE
5888 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5889 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5890 Use XFASTINT rather than XUINT when numbers are nonnegative.
5891 (xd_append_arg, Fdbus_method_return_internal):
5892 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5893 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5894 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5895 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5896 (Bug#8722)
2d1fc3c7 5897
c8a9ca5a
PE
5898 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5899
519e1d69
PE
5900 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5901
6df6ae42 5902 ccl: Add integer overflow checks.
30569699
PE
5903 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5904 (IN_INT_RANGE): New macros.
5905 (ccl_driver): Use them to check for integer overflow when
5906 decoding a CCL program. Many of the new checks are whether XINT (x)
5907 fits in int; it doesn't always, on 64-bit hosts. The new version
5908 doesn't catch all possible integer overflows, but it's an
847044ea 5909 improvement. (Bug#8719)
30569699 5910
c11285dc
PE
5911 * alloc.c (make_event_array): Use XINT, not XUINT.
5912 There's no need for unsigned here.
5913
fdccd48e
PE
5914 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5915 This follows up to the 2011-05-06 change that substituted uintptr_t
5916 for EMACS_INT. This case wasn't caught back then.
5917
37910ab2
PE
5918 Rework Fformat to avoid integer overflow issues.
5919 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5920 now (part of C89). Include <verify.h>.
5921 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5922 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5923 (Fformat): Avoid the prepass trying to compute sizes; it was only
5924 approximate and thus did not catch overflow reliably. Instead, walk
5925 through the format just once, formatting and computing sizes as we go,
5926 checking for integer overflow at every step, and allocating a larger
5927 buffer as needed. Keep track separately whether the format is
5928 multibyte. Keep only the most-recently calculated precision, rather
5929 than them all. Record whether each argument has been converted to
5930 string. Use EMACS_INT, not int, for byte and char and arg counts.
5931 Support field widths and precisions larger than INT_MAX. Avoid
5932 sprintf's undefined behavior with conversion specifications such as %#d
5933 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5934 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5935 formatting out-of-range floating point numbers with int
9173deec 5936 formats. (Bug#8668)
37910ab2 5937
2e6578fb
PE
5938 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5939
0ae6bdee
PE
5940 * data.c: Avoid integer truncation in expressions involving floats.
5941 * data.c: Include <intprops.h>.
5942 (arith_driver): When there's an integer overflow in an expression
5943 involving floating point, convert the integers to floating point
5944 so that the resulting value does not suffer from catastrophic
5945 integer truncation. For example, on a 64-bit host (* 4
5946 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5947 Do not rely on undefined behavior after integer overflow.
5948
de883a70
PE
5949 merge count_size_as_multibyte, parse_str_to_multibyte
5950 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5951 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5952 Check for integer overflow.
5953 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5954 since it's now a duplicate of the other. This is more of
5955 a character than a buffer op, so better that it's in character.c.
5956 * fns.c, print.c: Adjust to above changes.
5957
2ff916cb
PE
59582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5959
5960 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5961
f1b54466
PE
59622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5963
fb1ac845
PE
5964 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5965 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5966 (x_clipboard_manager_save): Now static.
5967 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5968
f1b54466
PE
5969 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5970 (crypto_hash_function): Now static.
5971 Fix pointer signedness problems. Avoid unnecessary initializations.
5972
a9f737ee
CY
59732011-05-27 Chong Yidong <cyd@stupidchicken.com>
5974
5975 * termhooks.h (Vselection_alist): Make it terminal-local.
5976
5977 * terminal.c (create_terminal): Initialize it.
5978
5979 * xselect.c: Support for clipboard managers.
5980 (Vselection_alist): Move to termhooks.h as terminal-local var.
5981 (LOCAL_SELECTION): New macro.
5982 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5983 (symbol_to_x_atom): Remove gratuitous arg.
5984 (x_handle_selection_request, lisp_data_to_selection_data)
5985 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5986 (x_own_selection, x_get_local_selection, x_convert_selection):
5987 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5988 (some_frame_on_display): Delete unused function.
5989 (Fx_own_selection_internal, Fx_get_selection_internal)
5990 (Fx_disown_selection_internal, Fx_selection_owner_p)
5991 (Fx_selection_exists_p): New optional frame arg.
5992 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5993 (x_handle_selection_clear): Don't treat other terminals with the
5994 same keyboard specially. Use the terminal-local Vselection_alist.
5995 (x_clear_frame_selections): Use Frun_hook_with_args.
5996
5997 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5998
5999 * xterm.h: Add support for those atoms.
6000
e067f0c1
CY
60012011-05-26 Chong Yidong <cyd@stupidchicken.com>
6002
6003 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6004 (converted_selections, conversion_fail_tag): New global variables.
6005 (x_selection_request_lisp_error): Free the above.
6006 (x_get_local_selection): Remove unnecessary code.
6007 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6008 of converted selections stored in converted_selections.
6009 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6010 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6011 (x_convert_selection): New function.
6012 (x_handle_selection_event): Simplify.
6013 (x_get_foreign_selection): Don't ignore incoming requests while
6014 waiting for an answer; this will fail when we implement
6015 SAVE_TARGETS, and seems unnecessary anyway.
6016 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6017 (Vx_sent_selection_functions): Doc fix.
6018
0f4aebc0
LL
60192011-05-26 Leo Liu <sdl.web@gmail.com>
6020
6021 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6022
e61124cd
YM
60232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6024
6025 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6026
6027 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6028 for fringe update if it has periodic bitmap.
ac389d0c 6029 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6030 and fringe_bitmap_periodic_p.
6031
6032 * fringe.c (get_fringe_bitmap_data): New function.
6033 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6034 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6035 row. Mark glyph row for fringe update if periodicity changed.
6036
6037 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6038 for fringe update unless it has periodic bitmap.
6039
f16d9837
KH
60402011-05-25 Kenichi Handa <handa@m17n.org>
6041
6042 * xdisp.c (get_next_display_element): Set correct it->face_id for
6043 a static composition.
6044
e1b90ef6
LL
60452011-05-24 Leo Liu <sdl.web@gmail.com>
6046
6047 * deps.mk (fns.o):
6048 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6049
6050 * fns.c (crypto_hash_function, Fsha1): New function.
6051 (Fmd5): Use crypto_hash_function.
6052 (syms_of_fns): Add Ssha1.
6053
7400048f
PE
60542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6055
6056 * gnutls.c: Remove unused macros.
6057 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6058 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6059 Remove macros that are defined and never used.
6060 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6061
abb71cf4
CY
60622011-05-22 Chong Yidong <cyd@stupidchicken.com>
6063
6064 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6065 (Fx_get_selection_internal): Minor cleanup.
6066 (Fx_own_selection_internal): Rename arguments for consistency with
6067 select.el.
6068
6307db39
PE
60692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6070
6071 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6072
f3d4e0a4
CY
60732011-05-22 Chong Yidong <cyd@stupidchicken.com>
6074
6075 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6076
4d8ade89
YM
60772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6078
6079 * dispnew.c (scrolling_window): Don't exclude the case that the
6080 last enabled row in the desired matrix touches the bottom boundary.
6081
32078c8d
GM
60822011-05-21 Glenn Morris <rgm@gnu.org>
6083
6084 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6085 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6086 and add some more files.
32078c8d 6087
7285dc67
EZ
60882011-05-20 Eli Zaretskii <eliz@gnu.org>
6089
6090 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6091 report_file_error introduced by the change from 2011-05-07.
6092
89d1bd22
PE
60932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6094
6095 * systime.h (Time): Define only if emacs is defined.
6096 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6097 where the include path doesn't have X11/X.h by default. See
6098 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6099
cd394be1 61002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6101
6102 * composite.c (find_automatic_composition): Fix previous change.
6103
b9704ad9
GM
61042011-05-20 Glenn Morris <rgm@gnu.org>
6105
6106 * lisp.mk: New file, split from Makefile.in.
6107 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6108 (shortlisp): Remove.
6109 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6110
4a720484
GM
61112011-05-19 Glenn Morris <rgm@gnu.org>
6112
6113 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6114 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6115 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6116 (lisp): Set the order to that of loadup.el.
6117 (shortlisp): Make it a copy of $lisp.
6118 (SOME_MACHINE_LISP): Remove.
6119 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6120 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6121
a28d4396
KH
61222011-05-18 Kenichi Handa <handa@m17n.org>
6123
6124 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6125 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6126 (find_automatic_composition): Mostly rewrite for efficiency.
6127
a2b1fa8e
JB
61282011-05-18 Juanma Barranquero <lekktu@gmail.com>
6129
6130 * makefile.w32-in: Update dependencies.
6131
8e1f5610
CS
61322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6133
6134 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6135 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6136
7025ee00 61372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6138
cdfa6eab
PE
6139 Fix some integer overflow issues, such as string length overflow.
6140
06d6db33
PE
6141 * insdel.c (count_size_as_multibyte): Check for string overflow.
6142
2b4560a8
PE
6143 * character.c (lisp_string_width): Check for string overflow.
6144 Use EMACS_INT, not int, for string indexes and lengths; in
6145 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6146 the resulting string length overflows an EMACS_INT; instead,
6147 report a string overflow if no precision given. When checking for
6148 precision exhaustion, use a check that cannot possibly have
6149 integer overflow. (Bug#8675)
6150 * character.h (lisp_string_width): Adjust to new signature.
6151
cb93f9be
PE
6152 * alloc.c (string_overflow): New function.
6153 (Fmake_string): Use it. This doesn't change behavior, but saves
6154 a few bytes and will simplify future changes.
6155 * character.c (string_escape_byte8): Likewise.
6156 * lisp.h (string_overflow): New decl.
6157
1a1f3366
PE
6158 Fixups, following up to the user-interface timestamp change.
6159 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6160 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6161 * msdos.c (mouse_get_pos): Likewise.
6162 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6163 * w32gui.h (Time): Define by including "systime.h" rather than by
6164 declaring it ourselves. (Bug#8664)
6165
d4e3e4d3
PE
6166 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6167 * image.c (clear_image_cache): Likewise.
6168
f6a24d19
PE
6169 * term.c (term_mouse_position): Don't assume time_t wraparound.
6170
08dc5ae6
PE
6171 Be more systematic about user-interface timestamps.
6172 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6173 and sometimes 'EMACS_UINT', to represent these timestamps.
6174 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6175 This makes the code easier to follow, and makes it easier to catch
6176 integer overflow bugs such as Bug#8664.
6177 * frame.c (Fmouse_position, Fmouse_pixel_position):
6178 Use Time, not unsigned long, for user-interface timestamps.
6179 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6180 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6181 * keyboard.h (last_event_timestamp): Likewise.
6182 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6183 * menu.h (xmenu_show): Likewise.
6184 * term.c (term_mouse_position): Likewise.
6185 * termhooks.h (struct input_event.timestamp): Likewise.
6186 (struct terminal.mouse_position_hook): Likewise.
6187 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6188 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6189 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6190 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6191 what it was before.
6192 * menu.h, termhooks.h: Include "systime.h", for Time.
6193
8e55734a
PE
6194 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6195 Don't assume that the difference between two unsigned long values
6196 can fit into an integer. At this point, we know button_down_time
6197 <= event->timestamp, so the difference must be nonnegative, so
6198 there's no need to cast the result if double-click-time is
6199 nonnegative, as it should be; check that it's nonnegative, just in
6200 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6201 apart (about 25 days). (Bug#8664)
8e55734a 6202
841f1b75 6203 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6204 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6205
3e26f69c
PE
6206 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6207 that always fit in int. Use a sentinel instead of a counter, to
6208 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6209 * frame.h (struct frame): Use int for menu_bar_items_used
6210 instead of EMACS_INT, since it always fits in int.
3e26f69c 6211
5cc152c0
PE
6212 * menu.c (grow_menu_items): Check for int overflow.
6213
d89eb65e
PE
6214 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6215
5235bd3e
PE
6216 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6217 Before, the code was not consistent. These values cannot exceed
6218 2**31 - 1 so there's no need to make them unsigned.
6219 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6220 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6221 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6222 as modifiers.
6223 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6224
bc827e23
PE
6225 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6226 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6227 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6228 presumably because the widths might not match.
6229
78eb494e
PE
6230 * window.c (size_window): Avoid needless test at loop start.
6231
04f2d78b
CB
62322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6233
6234 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6235
d2fc7e3d 62362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6237
6238 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6239
d2fc7e3d 62402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6241
6242 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6243 `width' to `bar_area_x' and `bar_area_width', respectively.
6244 (x_scroll_run): Take account of fringe background extension.
6245
04f2d78b
CB
6246 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6247 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6248 `bar_area_width', respectively.
6249 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6250 background extension.
6251
79b70037
GM
62522011-05-10 Jim Meyering <meyering@redhat.com>
6253
6254 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6255
2f142cc5
JB
62562011-05-10 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * image.c (Finit_image_library): Return t for built-in image types,
6259 like pbm and xbm. (Bug#8640)
6260
57679c86
AS
62612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6262
6263 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6264
888c9e86
EZ
62652011-05-07 Eli Zaretskii <eliz@gnu.org>
6266
b0512a1d
EZ
6267 * w32console.c (Fset_screen_color): Doc fix.
6268 (Fget_screen_color): New function.
6269 (syms_of_ntterm): Defsubr it.
6270
7285dc67
EZ
6271 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6272 unlink the temporary file if Fcall_process didn't create it in the
6273 first place.
6274 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6275 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6276 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6277 cue to call_process_cleanup not to close that handle.
6278
4d3fcc8e
BK
62792011-05-07 Ben Key <bkey76@gmail.com>
6280
6281 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6282 one of two shell specific rules, either bootstrap-temacs-CMD or
6283 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6284 to the previous implementation of the bootstrap-temacs rule.
6285 The bootstrap-temacs-CMD rule is similar to the previous
6286 implementation of the bootstrap-temacs rule except that it
6287 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6288 variable.
6289
6290 These changes, along with some changes to nt/configure.bat,
6291 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6292 earlier fix to add support for --cflags and --ldflags options
6293 that include quotes so that it works whether make uses cmd or
6294 sh as the shell.
6295
b4289b64
MA
62962011-05-06 Michael Albinus <michael.albinus@gmx.de>
6297
6298 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6299 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6300 is a constant.
6301 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6302 a string. Handle both cases.
6303 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6304 (Fdbus_register_method): Use Qinvalid_function.
6305
af4c0e28
JB
63062011-05-06 Juanma Barranquero <lekktu@gmail.com>
6307
6308 * makefile.w32-in: Update dependencies.
6309 (LISP_H): Add inttypes.h and stdin.h.
6310 (PROCESS_H): Add unistd.h.
6311
c51453d9
EZ
63122011-05-06 Eli Zaretskii <eliz@gnu.org>
6313
6314 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6315 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6316
8ff0ac3c 63172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6318
4c4b566b
PE
6319 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6320
aab2b9b5
PE
6321 * term.c (vfatal): Remove stray call to va_end.
6322 It's not needed and the C Standard doesn't allow it here anyway.
6323
c378da0b
PE
6324 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6325 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6326
288b08c7
PE
6327 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6328 bytes.
6329
e3601888
PE
6330 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6331
db6c0e74
PE
6332 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6333
dd5963ea
PE
6334 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6335
88c9450f
PE
6336 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6337
2f9442b8
PE
6338 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6339
c032b5f8
PE
6340 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6341 * charset.c (Fdefine_charset_internal): Don't initialize
6342 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6343 32-bit int (Bug#8600).
a108c10b
PE
6344
6345 * lread.c (read_integer): Be more consistent with string-to-number.
6346 Use string_to_number to do the actual conversion; this avoids
6347 rounding errors and fixes some other screwups. Without this fix,
6348 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6349 (digit_to_number): Move earlier, for benefit of read_integer.
6350 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6351 not a digit in any supported base. (Bug#8602)
a108c10b 6352
ad5f9eea
PE
6353 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6354
aec1708a
PE
6355 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6356 to match comment at start of function. This also removes a
6357 GCC warning about overflow in a 32+64-bit port.
6358
47be4ab5
PE
6359 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6360
371cac43
PE
6361 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6362 Reported by Stefan Monnier in
6363 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6364 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6365 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6366
d01a7826
PE
6367 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6368 (EMACS_UINTPTR): Likewise, with uintptr_t.
6369
7fd47d5c
PE
6370 * lisp.h: Prefer 64-bit EMACS_INT if available.
6371 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6372 on 32-bit hosts that have 64-bit int, so that they can access
6373 large files.
122b0c86
PE
6374 However, temporarily disable this change unless the temporary
6375 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6376
8727937b
PE
6377 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6378
8ac068ac
PE
6379 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6380 This removes an assumption that EMACS_INT and long are the same
6381 width as pointers. The assumption is true for Emacs porting targets
6382 now, but we want to make other targets possible.
6383 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6384 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6385 In the rest of the code, change types of integers that hold casted
6386 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6387 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6388 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6389 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6390 No need to cast type when ORing.
6391 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6392 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6393 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6394 assume EMACS_INT is the same width as char *.
6395 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6396 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6397 Remove no-longer-needed casts.
6398 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6399 (xg_tool_bar_help_callback, xg_make_tool_item):
6400 Use EMACS_INTPTR to hold an integer
6401 that will be cast to void *; this can avoid a GCC warning
6402 if EMACS_INT is not the same width as void *.
6403 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6404 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6405 (current_message_1, set_message_1):
6406 Use a local to convert to proper width without a cast.
6407 * xmenu.c (dialog_selection_callback): Likewise.
6408
ede49d71
PE
6409 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6410 Also, don't assume VALBITS / RAND_BITS is less than 5,
6411 and don't rely on undefined behavior when shifting a 1 left into
6412 the sign bit.
6413 * lisp.h (get_random): Change signature to match.
6414
2f30ecd0
PE
6415 * lread.c (hash_string): Use size_t, not int, for hash computation.
6416 Normally we prefer signed values; but hashing is special, because
6417 it's better to use unsigned division on hash table sizes so that
6418 the remainder is nonnegative. Also, size_t is the natural width
6419 for hashing into memory. The previous code used 'int', which doesn't
6420 retain enough info to hash well into very large tables.
6421 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6422
2a866e7b
PE
6423 * dbusbind.c: Don't possibly lose pointer info when converting.
6424 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6425 Use XPNTR rather than XHASH, so that the high-order bits of
6426 the pointer aren't lost when converting through void *.
6427
51639eac
PE
6428 * eval.c (Fautoload): Don't double-shift a pointer.
6429
92394119
PE
6430 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6431
dbdb9a7c
JB
64322011-05-06 Juanma Barranquero <lekktu@gmail.com>
6433
6434 * gnutls.c (DEF_GNUTLS_FN):
6435 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6436
db7a0b4f
AS
64372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6438
6439 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6440 marker. (Bug#8610)
6441
cd394be1 64422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6443
6444 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6445 New version that can reserve upto 2GB of heap space.
6446
f7ff1b0f 64472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6448
6449 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6450
639c109b
TZ
64512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6452
6453 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6454 `gnutls_certificate_set_x509_key_file'.
6455
d2127135
JB
64562011-05-05 Juanma Barranquero <lekktu@gmail.com>
6457
6458 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6459 Update dependencies.
6460
e968f4f3
JB
64612011-05-04 Juanma Barranquero <lekktu@gmail.com>
6462
6463 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6464 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6465 Remove unused parameter `fildes'.
6466 * process.c (read_process_output, send_process): Don't pass it.
6467
84d358f0
JB
64682011-05-04 Juanma Barranquero <lekktu@gmail.com>
6469
6470 Fix previous change: the library cache is defined in w32.c.
6471 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6472 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6473
0898ca10
JB
64742011-05-04 Juanma Barranquero <lekktu@gmail.com>
6475
6476 Implement dynamic loading of GnuTLS on Windows.
6477
6478 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6479 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6480 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6481 Declare.
6482
6483 * gnutls.c (Qgnutls_dll): Define.
6484 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6485 (gnutls_*): Declare function pointers.
6486 (init_gnutls_functions): New function to initialize function pointers.
6487 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6488 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6489 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6490 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6491 (emacs_gnutls_write, emacs_gnutls_read)
6492 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6493 (Fgnutls_available_p): New function.
6494 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6495 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6496 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6497
6498 * image.c: Include w32.h.
6499 (Vimage_type_cache): Delete.
6500 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6501 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6502 (w32_delayed_load): Move to w32.c.
6503
6504 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6505
6506 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6507 (w32_delayed_load): Move from image.c. When loading a library, record
6508 its filename in the :loaded-from property of the library id.
6509 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6510 Initialize and staticpro them.
6511 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6512
6513 * process.c: Include lisp.h before w32.h, not after.
6514 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6515 instead of gnutls_record_check_pending.
6516
6517 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6518
ff4de4aa
TZ
65192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6520
6521 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6522 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6523 as passed in.
6524
abe95abb
JD
65252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6526
6527 * xterm.c (x_set_frame_alpha): Do not set property on anything
6528 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6529
e16e55d4
JB
65302011-05-02 Juanma Barranquero <lekktu@gmail.com>
6531
6532 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6533
bafcf6a5
JB
65342011-05-02 Juanma Barranquero <lekktu@gmail.com>
6535
6536 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6537 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6538 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6539 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6540 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6541 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6542 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6543 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6544 (Qgnutls_bootprop_callbacks_verify): Make static.
6545
e7a6747f
AS
65462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6547
19ed11ba
AS
6548 * callproc.c: Indentation fixup.
6549
e7a6747f 6550 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6551 (wait_for_termination, interruptible_wait_for_termination):
6552 Move after wait_for_termination_1.
e7a6747f 6553
1ef14cb4
LMI
65542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6555
6556 * sysdep.c (interruptible_wait_for_termination): New function
6557 which is like wait_for_termination, but allows keyboard
6558 interruptions.
6559
6560 * callproc.c (Fcall_process): Add (:file "file") as an option for
6561 the STDOUT buffer.
6562 (Fcall_process_region): Ditto.
6563
330d880c
EZ
65642011-04-30 Eli Zaretskii <eliz@gnu.org>
6565
8db90b73
EZ
6566 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6567 rather than `XVECTOR (FOO)->size'.
6568
330d880c
EZ
6569 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6570 inttypes.h, as a gnulib replacement is used if it not available in
6571 system headers.
6572
15cbd324
EZ
65732011-04-21 Eli Zaretskii <eliz@gnu.org>
6574
6575 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6576 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6577 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6578
6579 * coding.c (coding_alloc_by_realloc): Error out if destination
6580 will grow beyond MOST_POSITIVE_FIXNUM.
6581 (decode_coding_emacs_mule): Abort if there isn't enough place in
6582 charbuf for the composition carryover bytes. Reserve an extra
6583 space for up to 2 characters produced in a loop.
6584 (decode_coding_iso_2022): Abort if there isn't enough place in
6585 charbuf for the composition carryover bytes.
6586
65872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6588
ae940cca
EZ
6589 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6590 aborting when %lld or %lll format is passed.
6591 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6592 %llo or %llx format is passed. (Bug#8545)
6593
03ab8921
EZ
6594 * window.c (window_scroll_line_based): Use a marker instead of
6595 simple variables to record original value of point. (Bug#7952)
6596
afda1437
EZ
6597 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6598 produced by %s or %c overflows available buffer space. (Bug#8545)
6599
f76dee0c
PE
66002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6601
6602 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6603 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6604
fdc5744d
JB
66052011-04-28 Juanma Barranquero <lekktu@gmail.com>
6606
6607 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6608
638f053a
JB
66092011-04-28 Juanma Barranquero <lekktu@gmail.com>
6610
6611 * keyboard.c (Qdelayed_warnings_hook): Define.
6612 (command_loop_1): Run `delayed-warnings-hook'
6613 if Vdelayed_warnings_list is non-nil.
6614 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6615 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6616
d178f871
EZ
66172011-04-28 Eli Zaretskii <eliz@gnu.org>
6618
6619 * doprnt.c (doprnt): Don't return value smaller than the buffer
6620 size if the message was truncated. (Bug#8545).
6621
b124fd93
JB
66222011-04-28 Juanma Barranquero <lekktu@gmail.com>
6623
6624 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6625 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6626
e810457d
PE
66272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6628
6629 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6630
ea51cceb
JB
66312011-04-27 Juanma Barranquero <lekktu@gmail.com>
6632
6633 * makefile.w32-in: Update dependencies.
6634
94dcfacf
EZ
66352011-04-27 Eli Zaretskii <eliz@gnu.org>
6636
6637 Improve `doprnt' and its usage. (Bug#8545)
6638 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6639 `format_end'. Remove support for %l as a conversion specifier.
6640 Don't use xrealloc. Improve diagnostics when the %l size modifier
6641 is used. Update the commentary.
6642
6643 * eval.c (verror): Simplify calculation of size_t.
6644
6645 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6646 messages.
6647
f61f41d7
PE
66482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6649
6650 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6651 change.
6652
96fb4434
PE
66532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6654
6655 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6656 This makes this file independent of the recent pseudovector change.
6657
671875da 66582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6659
69e9b5a3
PE
6660 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6661
b5f869a7 6662 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6663 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6664 Remove unused local.
c8926152 6665 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6666
841a1577 6667 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6668 GCC 4.6.0 optimizes based on type-based alias analysis.
6669 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6670 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6671 != &v->size, and therefore "v->size = 1; b->size = 2; return
6672 v->size;" must therefore return 1. This assumption is incorrect
6673 for Emacs, since it type-puns struct Lisp_Vector * with many other
6674 types. To fix this problem, this patch adds a new type struct
f904488f 6675 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6676 and pseudovectors, and helps optimizing compilers not get fooled
6677 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6678 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6679 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6680 the size member.
eab3844f
PE
6681 (XSETPVECTYPE): Rewrite in terms of new macro.
6682 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6683 This is a bit clearer, and further avoids the possibility of
6684 undesirable aliasing.
6685 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6686 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6687 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6688 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6689 (ASIZE): Now uses header.size rather than size.
6690 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6691 to avoid the hassle of writing XVECTOR (foo)->header.size.
6692 (struct vectorlike_header): New type.
eab3844f
PE
6693 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6694 object, to help avoid aliasing.
6695 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6696 (SUBRP): Likewise, since Lisp_Subr is a special case.
6697 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6698 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6699 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6700 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6701 changed to be "header.size" and "header.next".
6702 * buffer.h (struct buffer): Likewise.
6703 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6704 * frame.h (struct frame): Likewise.
6705 * process.h (struct Lisp_Process): Likewise.
6706 * termhooks.h (struct terminal): Likewise.
6707 * window.c (struct save_window_data, struct saved_window): Likewise.
6708 * window.h (struct window): Likewise.
6709 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6710 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6711 * buffer.c (init_buffer_once): Likewise.
6712 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6713 special case.
6714 * process.c (Fformat_network_address): Use local var for size,
6715 for brevity.
6716
0df1eac5
PE
6717 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6718
847ab9d1 6719 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6720 * data.c (atof): Remove decl; no longer used or needed.
6721 (digit_to_number): Move to lread.c.
6722 (Fstring_to_number): Use new string_to_number function, to be
6723 consistent with how the Lisp reader treats infinities and NaNs.
6724 Do not assume that floating-point numbers represent EMACS_INT
6725 without losing information; this is not true on most 64-bit hosts.
6726 Avoid double-rounding errors, by insisting on integers when
6727 parsing non-base-10 numbers, as the documentation specifies.
6728 * lisp.h (string_to_number): New decl, replacing ...
6729 (isfloat_string): Remove.
bc0a5c13 6730 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6731 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6732 appears to have been a coding error. Similarly, do not accept
6733 strings like +-1e0 as floating point numbers. Do not report
6734 overflow for integer overflows unless the base is not 10 which
6735 means we have no simple and reliable way to continue.
6736 Break out the floating-point parsing into a new
6737 function string_to_number, so that Fstring_to_number parses
6738 floating point numbers consistently with the Lisp reader.
04f2d78b 6739 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6740 (E_CHAR, EXP_INT): Remove, replacing with ...
6741 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6742 (string_to_number): New function, replacing isfloat_string.
6743 This function checks for valid syntax and produces the resulting
6744 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6745 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6746 so that overflow for non-base-10 numbers is reported only when
6747 there's no portable and simple way to convert to floating point.
452f4150 6748
67769ffc
PE
6749 * textprop.c (set_text_properties_1): Rewrite for clarity,
6750 and to avoid GCC warning about integer overflow.
6751
c20db43f
PE
6752 * intervals.h (struct interval): Use EMACS_INT for members
6753 where EMACS_UINT might cause problems. See
6754 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6755 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6756 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6757 All uses changed.
37aa2f85
PE
6758 (offset_intervals): Tell GCC not to worry about length overflow
6759 when negating a negative length.
c20db43f 6760
2538aa2f
PE
6761 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6762 (overrun_check_free): Likewise.
6763
f2d3008d
PE
6764 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6765 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6766 word size.
6767
ec8df744
PE
6768 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6769 (gnutls_make_error): Rename local to avoid shadowing.
6770 (gnutls_emacs_global_deinit): ifdef out; not used.
6771 (Fgnutls_boot): Use const for pointer to readonly storage.
6772 Comment out unused local. Fix pointer signedness problems.
6773
640ee02d
PE
6774 * lread.c (openp): Don't stuff size_t into an 'int'.
6775 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6776 about possible signed overflow.
6777
6048fb2a
PE
6778 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6779 (GDK_KEY_g): Don't define if already defined.
6780 (xg_prepare_tooltip): Avoid pointer signedness problem.
6781 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6782
fa3c87e1
PE
6783 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6784 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6785
2172544b
PE
6786 * xfns.c (Fx_window_property): Simplify a bit,
6787 to make a bit faster and to avoid GCC 4.6.0 warning.
6788 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6789
9b821a21
PE
6790 * fns.c (internal_equal): Don't assume size_t fits in int.
6791
3c616cfa
PE
6792 * alloc.c (compact_small_strings): Tighten assertion a little.
6793
c2982e87
PE
6794 Replace pEd with more-general pI, and fix some printf arg casts.
6795 * lisp.h (pI): New macro, generalizing old pEd macro to other
6796 conversion specifiers. For example, use "...%"pI"d..." rather
6797 than "...%"pEd"...".
6798 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6799 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6800 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6801 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6802 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6803 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6804 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6805 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6806 64-bit hosts.
6807 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6808 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6809 * print.c (safe_debug_print, print_object): Likewise.
6810 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6811 to int.
6f04d126
PE
6812 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6813 avoiding the 0 flag, which is not portable.
c2982e87
PE
6814 * process.c (Fmake_network_process): Use pI to avoid cast.
6815 * region-cache.c (pp_cache): Likewise.
6816 * xdisp.c (decode_mode_spec): Likewise.
6817 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6818 behavior on 64-bit hosts with printf arg.
6f04d126 6819 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6820 (x_stop_queuing_selection_requests): Likewise.
6821 (x_get_window_property): Don't truncate byte count to an 'int'
6822 when tracing.
0b432f21 6823
5e073ec7
PE
6824 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6825 here, since it parses constructs like leading '-' and spaces,
6826 which are not wanted; and it overflows with large numbers.
6827 Instead, simply match F[0-9]+, which is what is wanted anyway.
6828
36372bf9
PE
6829 * alloc.c: Remove unportable assumptions about struct layout.
6830 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6831 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6832 (allocate_vectorlike, make_pure_vector): Use the new macros,
6833 plus offsetof, to remove unportable assumptions about struct layout.
6834 These assumptions hold on all porting targets that I know of, but
6835 they are not guaranteed, they're easy to remove, and removing them
6836 makes further changes easier.
6837
0b432f21
PE
6838 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6839 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6840 (string_overrun_cookie): Now const. Use initializers that
6841 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6842 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6843 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6844 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6845 multiple of sizeof (EMACS_INT); it need not be, if
6846 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6847 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6848
895009e1
JB
68492011-04-26 Juanma Barranquero <lekktu@gmail.com>
6850
6851 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6852
6a7a1b0b
TZ
68532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6854
6855 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6856 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6857 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6858
841a1577 68592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6860
6861 * lisp.h (Qdebug): List symbol.
895009e1 6862 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6863 * keyboard.c (debug-on-event): New variable.
6864 (handle_user_signal): Break into debugger when debug-on-event
6865 matches the current signal symbol.
6866
f2d3ba6f
DN
68672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6868
6869 * alloc.c (check_sblock, check_string_bytes)
6870 (check_string_free_list): Convert to standard C.
6871
42ce4c63
TZ
68722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6873
6874 * w32.c (emacs_gnutls_push): Fix typo.
6875
825cd63c
EZ
68762011-04-25 Eli Zaretskii <eliz@gnu.org>
6877
fb11d64d
EZ
6878 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6879 "cast to pointer from integer of different size".
6880
825cd63c
EZ
6881 Improve doprnt and its use in verror. (Bug#8545)
6882 * doprnt.c (doprnt): Document the set of format control sequences
6883 supported by the function. Use SAFE_ALLOCA instead of always
6884 using `alloca'.
6885
6886 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6887 is one byte too soon. Don't use xrealloc; instead xfree and
6888 xmalloc anew.
6889
e061a11b
TZ
68902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6891
6892 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6893 callbacks stage.
6894
6895 * gnutls.c: Renamed global_initialized to
6896 gnutls_global_initialized. Added internals for the
6897 :verify-hostname-error, :verify-error, and :verify-flags
6898 parameters of `gnutls-boot' and documented those parameters in the
6899 docstring. Start callback support.
9173deec
JB
6900 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6901 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6902 on error. Return error code.
e061a11b
TZ
6903 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6904 (emacs_gnutls_read): Likewise.
6905 (Fgnutls_boot): Return handshake error code.
6906 (emacs_gnutls_handle_error): New function.
6907 (wsaerror_to_errno): Likewise.
6908
6909 * w32.h (emacs_gnutls_pull): Add prototype.
6910 (emacs_gnutls_push): Likewise.
6911
6912 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6913 (emacs_gnutls_push): Likewise.
6914
69152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6916
6917 * process.c (wait_reading_process_output): Check if GnuTLS
6918 buffered some data internally if no FDs are set for TLS
6919 connections.
6920
6921 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6922 (LIBS): Link to USER_LIBS.
6923 ($(BLD)/gnutls.$(0)): New target.
6924
fa6996bc
EZ
69252011-04-24 Eli Zaretskii <eliz@gnu.org>
6926
eb35682e
EZ
6927 * xdisp.c (handle_single_display_spec): Rename the
6928 display_replaced_before_p argument into display_replaced_p, to
6929 make it consistent with the commentary. Fix typos in the
6930 commentary.
6931
e2ad650c
EZ
6932 * textprop.c (syms_of_textprop): Remove dead code.
6933 (copy_text_properties): Delete obsolete commentary about an
6934 interface that was deleted long ago. Fix typos in the description
6935 of arguments.
6936
1b2de274
EZ
6937 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6938 to changes in oldXMenu/XMenu.h from 2011-04-16.
6939 <menu_help_message, prev_menu_help_message>: Constify.
6940 (IT_menu_make_room): menu->help_text is now `const char **';
6941 adjust.
6942
6943 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6944 to changes in oldXMenu/XMenu.h from 2011-04-16.
6945 (struct XMenu): Declare `help_text' `const char **'.
6946
6947 * xfaces.c <Qunspecified>: Make extern again.
6948
6949 * syntax.c: Include sys/types.h before including regex.h, as
6950 required by Posix.
6951
762b15be
EZ
6952 * doc.c (get_doc_string): Improve the format passed to `error'.
6953
6954 * doprnt.c (doprnt): Improve commentary.
6955
6956 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6957
6958 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6959 them with etags.
6960
f1052e5d
EZ
6961 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6962 changes in globals.h immediately force recompilation.
762b15be
EZ
6963 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6964 $(CURDIR)/s/ms-w32.h.
6965 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6966
fa6996bc
EZ
6967 * character.c (Fchar_direction): Function deleted.
6968 (syms_of_character): Don't defsubr it.
6969 <char-direction-table>: Deleted.
6970
e6c3da20
EZ
69712011-04-23 Eli Zaretskii <eliz@gnu.org>
6972
6973 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6974 * doprnt.c: Include limits.h.
6975 (SIZE_MAX): New macro.
04f2d78b
CB
6976 (doprnt): Return a size_t value. 2nd arg is now size_t.
6977 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6978 Improve overflow protection. Support `l' modifier for integer
6979 conversions. Support %l conversion. Don't assume an EMACS_INT
6980 argument for integer conversions and for %c.
6981
6982 * lisp.h (doprnt): Restore prototype.
6983
6984 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6985 $(SRC)/character.h.
6986
6987 * Makefile.in (base_obj): Add back doprnt.o.
6988
6989 * deps.mk (doprnt.o): Add back prerequisites.
6990 (callint.o): Depend on character.h.
6991
6992 * eval.c (internal_lisp_condition_case): Include the handler
6993 representation in the error message.
6994 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6995 when breaking from the loop.
6996
6997 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6998
6999 * callint.c (Fcall_interactively): When displaying error message
7000 about invalid control letter, pass the character's codepoint, not
7001 a pointer to its multibyte form. Improve display of the character
7002 in octal and display also its hex code.
7003
7004 * character.c (char_string): Use %x to display the (unsigned)
7005 codepoint of an invalid character, to avoid displaying a bogus
7006 negative value.
7007
7008 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7009 `error', not SYMBOL_NAME itself.
7010
7011 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7012 character arguments to `error'.
7013
7014 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7015 to `error' in error message about FINAL_CHAR argument. Make sure
7016 FINAL_CHAR is a character, and use %c when it is passed as
7017 argument to `error'.
7018
4ffd0d6b 70192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7020
7021 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7022
7023 * w32.c: Include <time.h>.
7024 (sys_localtime): New function.
7025
4ffd0d6b 70262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7027
7028 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7029
4ffd0d6b 7030 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7031
4ffd0d6b 70322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7033
4ffd0d6b
GM
7034 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7035 zombies (Bug#8467).
aac0c6e3 7036
04c56954
EZ
70372011-04-19 Eli Zaretskii <eliz@gnu.org>
7038
7039 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7040 gl_state.e_property when gl_state.object is Qt.
7041
7042 * insdel.c (make_gap_larger): Remove limitation of buffer size
7043 to <= INT_MAX.
7044
16a43933
CY
70452011-04-18 Chong Yidong <cyd@stupidchicken.com>
7046
7047 * xdisp.c (lookup_glyphless_char_display)
7048 (produce_glyphless_glyph): Handle cons cell entry in
7049 glyphless-char-display.
7050 (Vglyphless_char_display): Document it.
7051
7052 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7053 glyphless-char-display.
7054
4581706e
CY
70552011-04-17 Chong Yidong <cyd@stupidchicken.com>
7056
7057 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7058
7059 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7060
7061 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7062 definition for no-X builds.
7063
4887c6e2 70642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7065
fd35b6f9
PE
7066 Static checks with GCC 4.6.0 and non-default toolkits.
7067
5c1ccb01
PE
7068 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7069
006c5daa
PE
7070 * process.c (keyboard_bit_set): Define only if SIGIO.
7071 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7072 (send_process): Repair possible setjmp clobbering.
7073
efc736d3
PE
7074 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7075
4e2fe2e6
PE
7076 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7077
f97334a2
PE
7078 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7079
4e75f29d
PE
7080 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7081 Define only if needed.
7082
90efadd1
PE
7083 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7084 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7085 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7086
3c647824
PE
7087 * dispextern.h (struct redisplay_interface): Rename param
7088 to avoid shadowing.
e264f262 7089 * termhooks.h (struct terminal): Likewise.
761383f4 7090 * xterm.c (xembed_send_message): Likewise.
3c647824 7091
b58c5c4a
PE
7092 * insdel.c (make_gap_smaller): Define only if
7093 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7094
cad59032
PE
7095 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7096 it.
7097
c339dc2e
PE
7098 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7099 so that we aren't warned about unused symbols.
7100
91a3e27b
PE
7101 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7102
399c71d3 7103 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7104
8ffc96f5
PE
7105 * xfns.c (x_real_positions): Mark locals as initialized.
7106
eef9bc79
PE
7107 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7108
098db9dd
PE
7109 * xterm.c: Fix problems found by static analysis with other toolkits.
7110 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7111 (x_dispatch_event): Declare static if USE_GTK, and
7112 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7113 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7114 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7115 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7116 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7117
eb18f6cc
PE
7118 * xmenu.c (menu_help_callback): Pointer type fixes.
7119 Use const pointers when pointing at readonly data. Avoid pointer
7120 signedness clashes.
7121 (FALSE): Remove unused macro.
7122 (update_frame_menubar): Remove unused decl.
7123
1fe72bf8
PE
7124 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7125
60d9e1db
PE
7126 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7127 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7128 (single_menu_item): Rename local to avoid shadowing.
7129
39261c26
PE
7130 * keyboard.c (make_lispy_event): Remove unused local var.
7131
018c5e19
PE
7132 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7133 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7134
63d2b86e
PE
7135 * bitmaps: Change bitmaps from unsigned char back to the X11
7136 compatible char. Avoid the old compiler warnings about
7137 out-of-range initializers by using, for example, '\xab' rather
7138 than 0xab.
7139
aefd87e1
PE
7140 * xgselect.c (xgselect_initialize): Check vs interface
7141 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7142
bf501fb9
PE
7143 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7144
e9829fdf
PE
7145 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7146 to read-only memory.
7147
1086c095
PE
7148 * fns.c (vector): Remove; this old hack is no longer needed.
7149
2baccd04 7150 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7151 Remove unused var.
dde42981 7152 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7153
72391843 7154 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7155
436c16df 7156 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7157 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7158 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7159
92bb796d 7160 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7161 (x_term_init): Remove local to avoid shadowing.
92bb796d 7162
764430a3 7163 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7164
7165 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7166 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7167
d1dfb56c
EZ
71682011-04-16 Eli Zaretskii <eliz@gnu.org>
7169
c4354cb4
EZ
7170 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7171
d1dfb56c
EZ
7172 Fix regex.c, syntax.c and friends for buffers > 2GB.
7173 * syntax.h (struct gl_state_s): Declare character position members
7174 EMACS_INT.
7175
7176 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7177
04f2d78b
CB
7178 * textprop.c (verify_interval_modification, interval_of):
7179 Declare arguments EMACS_INT.
d1dfb56c
EZ
7180
7181 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7182 EMACS_INT.
7183
7184 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7185
7186 * indent.c (Fvertical_motion): Local variable it_start is now
7187 EMACS_INT.
7188
7189 * regex.c (re_match, re_match_2, re_match_2_internal)
7190 (bcmp_translate, regcomp, regexec, print_double_string)
7191 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7192 (re_compile_pattern, re_exec): Declare arguments and local
7193 variables `size_t' and `ssize_t' and return values `regoff_t', as
7194 appropriate.
7195 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7196 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7197 <compile_stack_type>: `size' and `avail' are now `size_t'.
7198
7199 * regex.h <regoff_t>: Use ssize_t, not int.
7200 (re_search, re_search_2, re_match, re_match_2): Arguments that
7201 specify buffer/string position and length are now ssize_t and
7202 size_t. Return type is regoff_t.
7203
613052cd
BK
72042011-04-16 Ben Key <bkey76@gmail.com>
7205
7206 * nsfont.m: Fixed bugs in ns_get_family and
7207 ns_descriptor_to_entity that were caused by using free to
7208 deallocate memory blocks that were allocated by xmalloc (via
7209 xstrdup). This caused Emacs to crash when compiled with
7210 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7211 --enable-checking=xmallocoverrun). xfree is now used to
7212 deallocate these memory blocks.
7213
4170f62f 72142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7215
71b41406
PE
7216 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7217
9587a89d
PE
7218 emacs_write: Accept and return EMACS_INT for sizes.
7219 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7220 et seq.
7221 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7222 Accept and return EMACS_INT.
7223 (emacs_gnutls_write): Return the number of bytes written on
7224 partial writes.
7225 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7226 (emacs_read, emacs_write): Remove check for negative size, as the
7227 Emacs source code has been audited now.
9587a89d
PE
7228 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7229 (emacs_read, emacs_write): Use it.
273a5f82
PE
7230 * process.c (send_process): Adjust to the new signatures of
7231 emacs_write and emacs_gnutls_write. Do not attempt to store
7232 a byte offset into an 'int'; it might overflow.
9587a89d 7233 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7234
3e047f51
PE
7235 * sound.c: Don't assume sizes fit in 'int'.
7236 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7237 Return EMACS_INT, not int.
3e047f51 7238 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7239 Accept EMACS_INT, not int.
7240 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7241 record read return values.
7242
cc39a9db
BK
72432011-04-15 Ben Key <bkey76@gmail.com>
7244
c9d0ec6d
JB
7245 * keyboard.c (Qundefined): Don't declare static since it is used
7246 in nsfns.m.
7247 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7248 static since they are used in nsfont.m.
cc39a9db 7249
6c60eb9f
SM
72502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7251
7252 * process.c (Qprocessp): Don't declare static.
7253 * lisp.h (Qprocessp): Declare again.
7254
7990b61a
JB
72552011-04-15 Juanma Barranquero <lekktu@gmail.com>
7256
7257 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7258
5d4cb038
PE
72592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7260
8bd7b830 7261 Improve C-level modularity by making more things 'static'.
cd64ea1d 7262
e3b27b31
PE
7263 Don't publish debugger-only interfaces to other modules.
7264 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7265 (verify_bytepos, count_markers): Move decls to the only modules
7266 that need them.
7267 * region-cache.h (pp_cache): Likewise.
7268 * window.h (check_all_windows): Likewise.
7269 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7270
5d4cb038
PE
7271 * sysdep.c (croak): Now static, if
7272 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7273 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7274
7275 * alloc.c (refill_memory_reserve): Now static if
7276 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7277 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7278
e87b6180
PE
7279 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7280 Define only if USE_LUCID.
7281
ac64929e
PE
7282 * xrdb.c (x_customization_string, x_rm_string): Now static.
7283
6f37259d
PE
7284 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7285 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7286
1683e3ab
PE
7287 * xdisp.c (draw_row_with_mouse_face): Now static.
7288 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7289
de9c2632
PE
7290 * window.h (check_all_windows): Mark externally visible.
7291
2b96acb7
PE
7292 * window.c (window_deletion_count): Now static.
7293
7294 * undo.c: Make symbols static if they're not exported.
7295 (last_undo_buffer, last_boundary_position, pending_boundary):
7296 Now static.
7297
50436f33
PE
7298 * textprop.c (interval_insert_behind_hooks): Now static.
7299 (interval_insert_in_front_hooks): Likewise.
7300
64520e5c
PE
7301 * term.c: Make symbols static if they're not exported.
7302 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7303 (max_frame_lines, tty_set_terminal_modes):
7304 (tty_reset_terminal_modes, tty_turn_off_highlight):
7305 (get_tty_terminal): Now static.
7306 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7307 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7308 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7309 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7310 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7311
1fa53021
PE
7312 * sysdep.c: Make symbols static if they're not exported.
7313 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7314 Now static.
7315 (sigprocmask_set, full_mask): Remove; unused.
7316 (wait_debugging): Mark as visible.
7317 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7318 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7319
d4b43b22
PE
7320 * syntax.c (syntax_temp): Define only if !__GNUC__.
7321
b7c513d0
PE
7322 * sound.c (current_sound_device, current_sound): Now static.
7323
989b29ad
PE
7324 * search.c (searchbufs, searchbuf_head): Now static.
7325
13a55a78
PE
7326 * scroll.c (scroll_cost): Remove; unused.
7327 * dispextern.h (scroll_cost): Remove decl.
7328
de68a1fc
PE
7329 * region-cache.h (pp_cache): Mark as externally visible.
7330
40ccffa6
PE
7331 * process.c: Make symbols static if they're not exported.
7332 (process_tick, update_tick, create_process, chan_process):
7333 (Vprocess_alist, proc_buffered_char, datagram_access):
7334 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7335 (deactivate_process): Mark defn as static, as well as decl.
7336 * lisp.h (create_process): Remove decl.
7337 * process.h (chan_process, Vprocess_alist): Remove decls.
7338
ad64fc97
PE
7339 * print.c: Make symbols static if they're not exported.
7340 (print_depth, new_backquote_output, being_printed, print_buffer):
7341 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7342 (print_interval, print_number_index, initial_stderr_stream):
7343 Now static.
7344 * lisp.h (Fprinc): Remove decl.
7345 (debug_output_compilation_hack): Mark as externally visible.
7346
adddb265
PE
7347 * sysdep.c (croak): Move decl from here to syssignal.h.
7348 * syssignal.h (croak): Put it here, so the API can be checked when
7349 'croak' is called from dissociate_if_controlling_tty.
7350
1717ede2
PE
7351 * minibuf.c: Make symbols static if they're not exported.
7352 (minibuf_save_list, choose_minibuf_frame): Now static.
7353 * lisp.h (choose_minibuf_frame): Remove decl.
7354
fa5fb2bc
PE
7355 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7356
1e3890d1
PE
7357 * lread.c: Make symbols static if they're not exported.
7358 (read_objects, initial_obarray, oblookup_last_bucket_number):
7359 Now static.
7360 (make_symbol): Remove; unused.
7361 * lisp.h (initial_obarray, make_symbol): Remove decls.
7362
8a1414fa
PE
7363 * keyboard.c: Make symbols static if they're not exported.
7364 (single_kboard, recent_keys_index, total_keys, recent_keys):
7365 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7366 (this_single_command_key_start, echoing, last_auto_save):
7367 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7368 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7369 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7370 (Vlispy_mouse_stem, double_click_count):
7371 Now static.
7372 (force_auto_save_soon): Define only if SIGDANGER.
7373 (ignore_mouse_drag_p): Now static if
7374 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7375 (print_help): Remove; unused.
7376 (stop_character, last_timer_event): Mark as externally visible.
7377 * keyboard.h (ignore_mouse_drag_p): Declare only if
7378 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7379 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7380 * lisp.h (echoing): Remove decl.
7381 (force_auto_save_soon): Declare only if SIGDANGER.
7382 * xdisp.c (redisplay_window): Simplify code, to make it more
7383 obvious that ignore_mouse_drag_p is not accessed if !defined
7384 USE_GTK && !defined HAVE_NS.
7385
93ea6e8f
PE
7386 * intervals.c: Make symbols static if they're not exported.
7387 (merge_properties_sticky, merge_interval_right, delete_interval):
7388 Now static.
7389 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7390
77382fcc
PE
7391 * insdel.c: Make symbols static if they're not exported.
7392 However, leave prepare_to_modify_buffer alone. It's never
7393 called from outside this function, but that appears to be a bug.
7394 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7395 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7396 (adjust_after_replace_noundo): Remove; unused.
7397 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7398 (signal_before_change): Remove decls.
77382fcc 7399
9306c32e
PE
7400 * indent.c (val_compute_motion, val_vmotion): Now static.
7401
cd44d2eb
PE
7402 * image.c: Make symbols static if they're not exported.
7403 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7404 if USE_GTK.
7405 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7406 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7407
ad9a7a06
PE
7408 * fringe.c (standard_bitmaps): Now static.
7409 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7410
81626931
PE
7411 * frame.c: Make symbols static if they're not exported.
7412 (x_report_frame_params, make_terminal_frame): Now static.
7413 (get_frame_param): Now static, unless HAVE_NS.
7414 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7415 (x_get_resource_string): Remove; not used.
7416 * frame.h (make_terminal_frame, x_report_frame_params):
7417 (x_get_resource_string); Remove decls.
7418 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7419 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7420
239f9db9
PE
7421 * font.c, fontset.c: Make symbols static if they're not exported.
7422 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7423 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7424 * font.c (font_close_object): Now static.
7425 * font.h (font_close_object): Remove.
7426 * fontset.c (FONTSET_OBJLIST): Remove.
7427 (free_realized_fontset) #if-0 the body, which does nothing.
7428 (face_suitable_for_char_p): #if-0, as it's never called.
7429 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7430 * xfaces.c (face_at_string_position):
7431 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7432 since 0 is always ASCII.
7433
dfcf3579
PE
7434 * fns.c (weak_hash_tables): Now static.
7435
5045092b
PE
7436 * fileio.c: Make symbols static if they're not exported.
7437 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7438 (Vwrite_region_annotation_buffers): Now static.
7439
57a96f5c
PE
7440 * eval.c: Make symbols static if they're not exported.
7441 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7442 * lisp.h (backtrace_list): Remove decl.
7443
35f08c38
PE
7444 * emacs.c: Make symbols static if they're not exported.
7445 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7446 (fatal_error_code, fatal_error_signal_hook, standard_args):
7447 Now static.
7448 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7449 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7450 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7451 * lisp.h (fatal_error_signal_hook): Remove decl.
7452 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7453
f44bd759
PE
7454 * editfns.c: Move a (normally-unused) function to its only use.
7455 * editfns.c, lisp.h (get_operating_system_release): Remove.
7456 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7457 worth the hassle of breaking this out.
7458
b532497d
PE
7459 * xterm.c: Make symbols static if they're not exported.
7460 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7461 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7462 (x_destroy_window, x_delete_display):
7463 Now static.
7464 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7465 (x_mouse_leave): Remove; unused.
7466 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7467 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7468 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7469 Remove decls.
7470 (x_mouse_leave): Declare only if WINDOWSNT.
7471 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7472 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7473 USE_X_TOOLKIT.
7474
1675728f
PE
7475 * ftxfont.c: Make symbols static if they're not exported.
7476 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7477 HAVE_FREETYPE.
7478 * font.h (ftxfont_driver): Likewise.
7479
e4cebfca
PE
7480 * xfns.c: Make symbols static if they're not exported.
7481 (x_last_font_name, x_display_info_for_name):
7482 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7483 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7484 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7485 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7486 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7487 (last_show_tip_args): Now static.
7488 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7489 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7490 (x_screen_planes): Remove; unused.
7491 * dispextern.h (x_screen_planes): Remove decl.
7492
5bf46f05
PE
7493 * dispnew.c: Make symbols static if they're not exported.
7494 * dispextern.h (redraw_garbaged_frames, scrolling):
7495 (increment_row_positions): Remove.
7496 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7497 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7498 Now static.
7499 (redraw_garbaged_frames): Remove; unused.
7500
435f4c28
PE
7501 * xfaces.c: Make symbols static if they're not exported.
7502 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7503 Remove decls.
7504 * xterm.h (defined_color): Remove decls.
7505 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7506 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7507 (menu_face_changed_default, defined_color, free_realized_face):
7508 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7509 (ascii_face_of_lisp_face): Remove; unused.
7510
8524aef3
PE
7511 * xdisp.c: Make symbols static if they're not exported.
7512 * dispextern.h (scratch_glyph_row, window_box_edges):
7513 (glyph_to_pixel_coords, set_cursor_from_row):
7514 (get_next_display_element, set_iterator_to_next):
7515 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7516 (show_mouse_face): Remove decls
7517 * frame.h (message_buf_print): Likewise.
7518 * lisp.h (pop_message, set_message, check_point_in_composition):
7519 Likewise.
7520 * xterm.h (set_vertical_scroll_bar): Likewise.
7521 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7522 (message_buf_print, scratch_glyph_row, displayed_buffer):
7523 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7524 (get_next_display_element, show_mouse_face, window_box_edges):
7525 (frame_to_window_pixel_xy, check_point_in_composition):
7526 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7527 (glyph_to_pixel_coords): Remove; unused.
7528
16390cd2
PE
7529 * dired.c (file_name_completion): Now static.
7530
7531 * dbusbind.c (xd_in_read_queued_messages): Now static.
7532
a25f4dfa
PE
7533 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7534 * data.c (circular_list_error): Remove.
7535
14a9c8df
PE
7536 * commands.h (last_point_position, last_point_position_buffer):
7537 (last_point_position_window): Remove decls.
7538 * keyboard.c: Make these variables static.
7539
04f2d78b
CB
7540 * coding.h (coding, code_convert_region, encode_coding_gap):
7541 Remove decls.
74ab6df5
PE
7542 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7543 (iso_code_class, detect_coding, code_convert_region): Now static.
7544 (encode_coding_gap): Remove; unused.
7545
38dfbee1
PE
7546 * chartab.c (chartab_chars, chartab_bits): Now static.
7547
a2cb4e63
PE
7548 * charset.h (charset_iso_8859_1): Remove decl.
7549 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7550 Now static.
7551
127198fd
PE
7552 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7553 * ccl.c (Vccl_program_table): Now static.
7554 (check_ccl_update): Remove; unused.
7555
d85b608f
PE
7556 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7557 * category.h: ... from here.
7558 * category.c (check_category_table, set_category_set): Now static.
7559
31cd66f3
PE
7560 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7561 * lisp.h: Remove these decls.
7562
c358e587
PE
7563 * buffer.c (buffer_count): Remove unused var.
7564
e78aecca
PE
7565 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7566 so that it's not optimized away.
7567 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7568 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7569 exported only to the debugger.
7570
e192d7d3 7571 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7572 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7573
92470028
PE
7574 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7575 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7576 was inaccessible from Lisp.
7577 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7578 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7579
244ed907
PE
7580 alloc.c: Import and export fewer symbols, and remove unused items.
7581 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7582 is defined.
7583 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7584 it's not optimized away by whole-program optimization.
7585 (message_enable_multibyte, free_misc): Remove.
7586 (catchlist, handlerlist, mark_backtrace):
7587 Declare only if BYTE_MARK_STACK.
7588 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7589 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7590 (message_enable_multibyte): Remove decl.
7591 (free_misc, interval_free_list, float_block, float_block_index):
7592 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7593 (cons_free_list, last_marked_index):
7594 Now static.
7595 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7596 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7597 (mark_backtrace): Define only if BYTE_MARK_STACK.
7598 * xdisp.c (message_enable_multibyte): Now static.
7599
61c2b50e 7600 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7601 This makes it easier for human readers (and static analyzers)
7602 to see whether these variables are used from other modules.
7603 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7604 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7605 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7606 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7607 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7608 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7609 * xmenu.c, xselect.c:
7610 Declare Q* vars static if they are not used in other modules.
7611 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7612 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7613 Remove decls of unexported vars.
7614 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7615
95c82688
PE
7616 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7617
16a97296
PE
7618 Make Emacs functions such as Fatom 'static' by default.
7619 This makes it easier for human readers (and static analyzers)
7620 to see whether these functions can be called from other modules.
7621 DEFUN now defines a static function. To make the function external
7622 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7623 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7624 (Finit_image_library):
16a97296
PE
7625 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7626 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7627 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7628 Remove decls, since these functions are now static.
7629 (Funintern, Fget_internal_run_time): New decls, since these functions
7630 were already external.
95c82688 7631
16a97296
PE
7632 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7633 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7634 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7635 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7636 * keyboard.c, keymap.c, lread.c:
7637 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7638 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7639 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7640 Mark functions with DEFUE instead of DEFUN,
7641 if they are used in other modules.
7642 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7643 decls for now-static functions.
7644 * buffer.h (Fdelete_overlay): Remove decl.
7645 * callproc.c (Fgetenv_internal): Mark as internal.
7646 * composite.c (Fremove_list_of_text_properties): Remove decl.
7647 (Fcomposition_get_gstring): New forward static decl.
7648 * composite.h (Fcomposite_get_gstring): Remove decl.
7649 * dired.c (Ffile_attributes): New forward static decl.
7650 * doc.c (Fdocumntation_property): New forward static decl.
7651 * eval.c (Ffetch_bytecode): New forward static decl.
7652 (Funintern): Remove extern decl; now in .h file where it belongs.
7653 * fileio.c (Fmake_symbolic_link): New forward static decl.
7654 * image.c (Finit_image_library): New forward static decl.
7655 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7656 * intervals.h (Fprevious_property_change):
7657 (Fremove_list_of_text_properties): Remove decls.
7658 * keyboard.c (Fthis_command_keys): Remove decl.
7659 (Fcommand_execute): New forward static decl.
7660 * keymap.c (Flookup_key): New forward static decl.
7661 (Fcopy_keymap): Now static.
7662 * keymap.h (Flookup_key): Remove decl.
7663 * process.c (Fget_process): New forward static decl.
7664 (Fprocess_datagram_address): Mark as internal.
7665 * syntax.c (Fsyntax_table_p): New forward static decl.
7666 (skip_chars): Remove duplicate decl.
7667 * textprop.c (Fprevious_property_change): New forward static decl.
7668 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7669 Now internal.
7670 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7671 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7672
785bbd42
PE
7673 * editfns.c (Fformat): Remove unreachable code.
7674
8b913b57
AS
76752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7676
7677 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7678 change. (Bug#8496)
7679
a6744a35
EZ
76802011-04-13 Eli Zaretskii <eliz@gnu.org>
7681
7682 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7683 when at ZV. (Bug#8487)
7684
e7974947
AS
76852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7686
baad03f0
AS
7687 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7688 (Bug#8437)
7689 * keyboard.c (parse_tool_bar_item): Likewise.
7690 * sound.c (sound_cleanup, alsa_close): Likewise.
7691 * termcap.c (tgetent): Likewise.
7692 * xfns.c (x_default_font_parameter): Likewise.
7693 * xsettings.c (read_and_apply_settings): Likewise.
7694
e7974947
AS
7695 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7696 (overrun_check_free): Protoize.
7697
28272684
PE
76982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7699
7700 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7701 since callers should never pass a negative size.
7702 Change the signature to match that of plain 'read' and 'write'; see
7703 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7704 * lisp.h: Update prototypes of emacs_write and emacs_read.
7705
11997c76
EZ
77062011-04-11 Eli Zaretskii <eliz@gnu.org>
7707
7708 * xdisp.c (redisplay_window): Don't try to determine the character
7709 position of the scroll margin if the window start point w->startp
e896f03c 7710 is outside the buffer's accessible region. (Bug#8468)
11997c76 7711
8a2cbd72
EZ
77122011-04-10 Eli Zaretskii <eliz@gnu.org>
7713
7714 Fix write-region and its subroutines for buffers > 2GB.
7715 * fileio.c (a_write, e_write): Modify declaration of arguments and
7716 local variables to support buffers larger than 2GB.
7717 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7718
7719 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7720 argument, local variables, and return value.
7721
7722 * lisp.h: Update prototypes of emacs_write and emacs_read.
7723
7724 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7725
4073e537 77262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7727
1ebfdcb6
PE
7728 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7729
b2ded58d
PE
7730 Fix more problems found by GCC 4.6.0's static checks.
7731
7d66342c
PE
7732 * xdisp.c (vmessage): Use a better test for character truncation.
7733
bbf47d44
PE
7734 * charset.c (load_charset_map): <, not <=, for optimization,
7735 and to avoid potential problems with integer overflow.
9248994d 7736 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7737 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7738 * editfns.c (Fformat): Likewise.
1e69125e 7739 * syntax.c (skip_chars): Likewise.
3befa583 7740
e3019616
PE
7741 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7742 This also lets GCC 4.6.0 generate slightly better loop code.
7743
becfa255
PE
7744 * callint.c (Fcall_interactively): <, not <=, for optimization.
7745 (Fcall_interactively): Count the number of arguments produced,
7746 not the number of arguments given. This is simpler and lets GCC
7747 4.6.0 generate slightly better code.
7748
dae0cd48
PE
7749 * ftfont.c: Distingish more carefully between FcChar8 and char.
7750 The previous code passed unsigned char * to a functions like
7751 strlen and xstrcasecmp that expect char *, which does not
7752 conform to the C standard.
7753 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7754 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7755 char * when the C standard requires it.
7756
76032d70
PE
7757 * keyboard.c (read_char): Remove unused var.
7758
eb3f1cc8
PE
7759 * eval.c: Port to Windows vsnprintf (Bug#8435).
7760 Include <limits.h>.
7761 (SIZE_MAX): Define if the headers do not.
7762 (verror): Do not give up if vsnprintf returns a negative count.
7763 Instead, grow the buffer. This ports to Windows vsnprintf, which
7764 does not conform to C99. Problem reported by Eli Zaretskii.
7765 Also, simplify the allocation scheme, by avoiding the need for
7766 calling realloc, and removing the ALLOCATED variable.
7767
70476b54
PE
7768 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7769
12020a9e
PE
7770 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7771 But keep the doprint source code for now, as we might revamp it
7772 and use it again (Bug#8435).
ea6c7ae6
PE
7773 * lisp.h (doprnt): Remove.
7774 * Makefile.in (base_obj): Remove doprnt.o.
7775 * deps.mk (doprnt.o): Remove.
7776
5fdb398c
PE
7777 error: Print 32- and 64-bit integers portably (Bug#8435).
7778 Without this change, on typical 64-bit hosts error ("...%d...", N)
7779 was used to print both 32- and 64-bit integers N, which relied on
7780 undefined behavior.
61bdb816 7781 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7782 * lisp.h (error, verror): Mark as printf-like functions.
7783 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7784 Report overflow in size calculations when allocating printf buffer.
7785 Do not truncate output string at its first null byte.
7786 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7787 Truncate the output at a character boundary, since vsnprintf does not
7788 do that.
7789 * charset.c (check_iso_charset_parameter): Convert internal
7790 character to string before calling 'error', since %c now has the
7791 printf meaning.
7792 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7793 overflow when computing char to be passed to 'error'. Do not
7794 pass Lisp_Object to 'error'; pass the integer instead.
7795 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7796 formatted with plain %d.
7797
b189fa66
PE
7798 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7799
bff87ef0
PE
7800 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7801
7e2cac20
PE
7802 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7803
ce4d90b5
PE
7804 * xterm.c (x_catch_errors): Remove duplicate declaration.
7805
266c9547
PE
7806 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7807
79c49ad2
PE
7808 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7809
368f4090
JM
78102011-04-10 Jim Meyering <meyering@redhat.com>
7811
7812 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7813 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7814 return ssize_t not "int", and use size_t as the buffer length.
7815 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7816 * gnutls.h: Update declarations.
7817 * process.c (read_process_output): Use ssize_t, to match.
7818 (send_process): Likewise.
7819
a32d4040
CY
78202011-04-09 Chong Yidong <cyd@stupidchicken.com>
7821
7822 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7823
8546720e 78242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7825
04f2d78b
CB
7826 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7827 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7828
8546720e
GM
7829 * xterm.c (handle_one_xevent):
7830 * xmenu.c (create_and_show_popup_menu):
7831 * xselect.c (x_decline_selection_request)
7832 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7833
0a2f5c1a 78342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7835
7836 Fix some uses of `int' instead of EMACS_INT.
7837 * search.c (string_match_1, fast_string_match)
7838 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7839 (scan_buffer, find_next_newline_no_quit)
7840 (find_before_next_newline, search_command, Freplace_match)
7841 (Fmatch_data): Make some `int' variables be EMACS_INT.
7842
7843 * xdisp.c (display_count_lines): 3rd argument and return value now
7844 EMACS_INT. All callers changed.
7845 (pint2hrstr): Last argument is now EMACS_INT.
7846
7847 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7848 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7849 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7850 (decode_coding_utf_16, decode_coding_emacs_mule)
7851 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7852 (decode_coding_ccl, decode_coding_charset)
7853 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7854 (decode_coding_iso_2022, decode_coding_emacs_mule)
7855 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7856 <char_offset, last_offset>: Declare EMACS_INT.
7857 (encode_coding_utf_8, encode_coding_utf_16)
7858 (encode_coding_emacs_mule, encode_invocation_designation)
7859 (encode_designation_at_bol, encode_coding_iso_2022)
7860 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7861 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7862 Declare EMACS_INT.
7863 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7864 (encode_invocation_designation): Last argument P_NCHARS is now
7865 EMACS_INT.
7866 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7867 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7868
7869 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7870 All users changed.
7871
7872 * ccl.c (Fccl_execute_on_string): Declare some variables
7873 EMACS_INT.
7874
8546720e 78752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7876
7877 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7878
4e19a977
CS
78792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7880
7881 * process.c (Fformat_network_address): Doc fix.
7882
87302331
R
78832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7884
ee7683eb 7885 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7886
cbb59342
CY
78872011-04-08 Chong Yidong <cyd@stupidchicken.com>
7888
7889 * keyboard.c (read_char): Call Lisp function help-form-show,
7890 instead of using internal_with_output_to_temp_buffer.
7891 (Qhelp_form_show): New var.
e0d38eeb 7892 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7893
7894 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7895
7896 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7897
e67a13ab
CY
78982011-04-06 Chong Yidong <cyd@stupidchicken.com>
7899
04f2d78b
CB
7900 * process.c (Flist_processes): Remove to Lisp.
7901 (list_processes_1): Delete.
e67a13ab 7902
973f782d
EZ
79032011-04-06 Eli Zaretskii <eliz@gnu.org>
7904
7c106b1e
EZ
7905 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7906
973f782d
EZ
7907 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7908
41cf7d1a 79092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7910
ca23cc88
PE
7911 Fix more problems found by GCC 4.6.0's static checks.
7912
f390e2d5
PE
7913 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7914
42eea0d0
PE
7915 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7916
b69769da 7917 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7918
f9541e84
PE
7919 * xdisp.c (vmessage): Mark as a printf-like function.
7920
13841b55
PE
7921 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7922
c136c10f
PE
7923 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7924
5e2d4a30
PE
7925 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7926 printf-like functions.
7927 (tiff_load): Add casts to remove these marks before passing them
7928 to system-supplied API.
7929
583f48b9
PE
7930 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7931
b25d760e
PE
7932 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7933 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7934 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7935 directly, rather than having caller test rule sign. This avoids
7936 some unnecessary tests.
7937 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7938 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7939 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7940
bc7b6697 7941 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7942 (xfont_open): Avoid unnecessary tests.
bc7b6697 7943
27ccc379
PE
7944 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7945
dcd5c89a
PE
7946 * composite.h, composite.c (composition_gstring_put_cache):
7947 Use EMACS_INT, not int, for length.
7948
b13a45c6
PE
7949 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7950 breaking out part of COMPOSITION_DECODE_RULE.
7951 (COMPOSITION_DECODE_RULE): Use it.
7952 * composite.c (get_composition_id): Remove unused local vars,
7953 by using the new macro.
7954
1e792e4d
PE
7955 * textprop.c (set_text_properties_1): Change while to do-while,
7956 since the condition is always true at first.
7957
dc6c6455 7958 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7959 (interval_deletion_adjustment): Return unsigned value.
7960 All uses changed.
dc6c6455 7961
aba7731a
PE
7962 * process.c (list_processes_1, create_pty, read_process_output):
7963 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7964 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7965 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7966 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7967 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7968
fdfc4bf3
PE
7969 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7970
fca8fe46 7971 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7972 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7973
06a0259a 7974 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7975 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7976 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7977
e7b9e80f
PE
7978 * print.c (print_error_message): Avoid int overflow.
7979
56201685
PE
7980 * font.c (font_list_entities): Redo for clarity,
7981 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7982
78834453 7983 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7984 (font_score): Avoid potential overflow in diff calculation.
78834453 7985
0bc0b309 7986 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7987 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7988
e610eaca
PE
7989 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7990
b895abce
PE
7991 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7992 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7993 can always succeed if overflow has undefined behavior.
7994
1f1d9321 7995 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7996 (wordify): Omit three unnecessary tests.
1f1d9321 7997
c59478bc
PE
7998 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7999 All callers changed. This avoids the need for an unused var.
8000
79b73827
PE
8001 * casefiddle.c (casify_region): Remove var that is set but not used.
8002
a4db5dfe
PE
8003 * dired.c (file_name_completion): Remove var that is set but not used.
8004
43aae36e
PE
8005 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8006
2a47c44d 8007 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8008 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8009
a37c69bf
PE
8010 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8011 Check for integer overflow on size calculations.
8012
328ab8e7
PE
8013 * buffer.c (Fprevious_overlay_change): Remove var that is set
8014 but not used.
8015
e5a2a5cb
PE
8016 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8017 Remove vars that are set but not used.
8d84a6eb 8018 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8019 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8020
a60e5f68
PE
8021 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8022
f661cb61 8023 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8024 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8025
f0397f5a
PE
8026 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8027 that are set but not used.
8028
8664db06 8029 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8030 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8031
6abdaa4a
PE
8032 * xselect.c (x_get_local_selection, x_handle_property_notify):
8033 Remove vars that are set but not used.
8034
0ce7538d 8035 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8036 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8037
9ae848fc
PE
8038 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8039 Remove var that is set but not used.
0b918413
PE
8040 (scroll_bar_windows_size): Now size_t, not int.
8041 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8042 Check for overflow.
9ae848fc 8043
a5a62657
PE
8044 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8045 (map_tty_color) [!defined MSDOS]: Likewise.
8046
5c5cdd39
PE
8047 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8048
66ebf983
PE
8049 * coding.c: Remove vars that are set but not used.
8050 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8051 All callers changed.
8052 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8053 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8054 (decode_coding_charset): Remove vars that are set but not used.
8055
1be4d761
PE
8056 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8057 that is set but not used.
8058
47553fa8
PE
8059 * print.c (print_object): Remove var that is set but not used.
8060
1f7196bf 8061 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8062 The gnulib version avoids calling malloc in the usual case,
8063 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8064 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8065 * filelock.c (current_lock_owner): Likewise.
8066 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8067 * sysdep.c: Include allocator.h, careadlinkat.h.
8068 (emacs_no_realloc_allocator): New static constant.
8069 (emacs_readlink): New function.
fdb61804
PE
8070 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8071 ../lib/careadlinkat.h.
d1fdcab7 8072
f84c17c7
SM
80732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8074
8075 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8076 first non-nil return value).
8077
ef3862ad
JD
80782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8079
8080 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8081 if not defined (Bug#8403).
8082
376a7006
JB
80832011-04-02 Juanma Barranquero <lekktu@gmail.com>
8084
8085 * xdisp.c (display_count_lines): Remove parameter `start',
8086 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8087 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8088 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8089 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8090 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8091 and thereabouts. All callers changed.
8092 (get_per_char_metric): Remove parameter `f', unused since
8093 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8094
6ca3801d
JM
80952011-04-02 Jim Meyering <meyering@redhat.com>
8096
8097 do not dereference NULL upon failed strdup
8098 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8099 (ns_get_family): Likewise.
8100
d8e2b5ba
JB
81012011-04-02 Juanma Barranquero <lekktu@gmail.com>
8102
8103 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8104
8c74fcbd
JD
81052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8106
8107 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8108 later (Bug#8403).
8109
7200d79c
SM
81102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8111
03408648 8112 Add lexical binding.
7200d79c 8113
03408648
SM
8114 * window.c (Ftemp_output_buffer_show): New fun.
8115 (Fsave_window_excursion):
8116 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8117
8118 * lread.c (lisp_file_lexically_bound_p): New function.
8119 (Fload): Bind Qlexical_binding.
8120 (readevalloop): Remove `evalfun' arg.
8121 Bind Qinternal_interpreter_environment.
8122 (Feval_buffer): Bind Qlexical_binding.
8123 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8124 Mark as dynamic.
8125 (syms_of_lread): Declare `lexical-binding'.
8126
8127 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8128
8129 * keyboard.c (eval_dyn): New fun.
8130 (menu_item_eval_property): Use it.
ca105506
SM
8131
8132 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8133
03408648
SM
8134 * fns.c (concat, mapcar1): Accept byte-code-functions.
8135
8136 * eval.c (Fsetq): Handle lexical vars.
8137 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8138 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8139 (FletX, Flet): Obey lexical binding.
8140 (Fcommandp): Handle closures.
8141 (Feval): New `lexical' arg.
8142 (eval_sub): New function extracted from Feval. Use it almost
8143 everywhere where Feval was used. Look up vars in lexical env.
8144 Handle closures.
8145 (Ffunctionp): Move from subr.el.
8146 (Ffuncall): Handle closures.
8147 (apply_lambda): Remove `eval_flags'.
8148 (funcall_lambda): Handle closures and new byte-code-functions.
8149 (Fspecial_variable_p): New function.
8150 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8151 but without exporting it to Lisp.
23aba0ea 8152
23aba0ea 8153 * doc.c (Fdocumentation, store_function_docstring):
03408648 8154 * data.c (Finteractive_form): Handle closures.
23aba0ea 8155
03408648
SM
8156 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8157 interactive spec.
ba83908c 8158
04f2d78b
CB
8159 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8160 New byte-codes.
03408648
SM
8161 (exec_byte_code): New function extracted from Fbyte_code to handle new
8162 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8163
03408648 8164 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8165
03408648 8166 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8167
e2abce01
JB
81682011-03-31 Juanma Barranquero <lekktu@gmail.com>
8169
8170 * xdisp.c (redisplay_internal): Fix prototype.
8171
63696a73 81722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8173
63696a73 8174 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8175 (try_scrolling): Use it when setting scroll_limit.
8176 Limit scrolling to 100 screen lines.
63696a73
EZ
8177 (redisplay_window): Even when falling back on "recentering",
8178 position point in the window according to scroll-conservatively,
8179 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8180
8181 (try_scrolling): When point is above the window, allow searching
8182 as far as scroll_max, or one screenful, to compute vertical
8183 distance from PT to the scroll margin position. This prevents
8184 try_scrolling from unnecessarily failing when
8185 scroll-conservatively is set to a value slightly larger than the
8186 window height. Clean up the case of PT below the margin at bottom
8187 of window: scroll_max can no longer be INT_MAX. When aggressive
8188 scrolling is in use, don't let point enter the opposite scroll
8189 margin as result of the scroll.
8190 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8191 threshold of 100 lines for never-recentering scrolling.
8192
e4cc2dfc
JB
81932011-03-31 Juanma Barranquero <lekktu@gmail.com>
8194
8195 * dispextern.h (move_it_by_lines):
8196 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8197 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8198 (message_log_check_duplicate): Remove parameters `prev_bol' and
8199 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8200 (redisplay_internal): Remove parameter `preserve_echo_area',
8201 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8202
8203 * indent.c (Fvertical_motion):
8204 * window.c (window_scroll_pixel_based, Frecenter):
8205 Don't pass `need_y_p' to `move_it_by_lines'.
8206
1c470562
SM
82072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8208
44f230aa
SM
8209 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8210 steal a few bits to be more compact.
8211 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8212 Remove unneeded casts.
8213
1c470562
SM
8214 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8215
888adce9
ZK
82162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8217
8218 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8219 binding" message (bug#7967).
8220
f838ed7b
PE
82212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8222
77861b95
PE
8223 Fix more problems found by GCC 4.6.0's static checks.
8224
de6dbc14
PE
8225 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8226 Remove unused local var.
8227
f838ed7b
PE
8228 * editfns.c (Fmessage_box): Remove unused local var.
8229
792c7b2b
PE
8230 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8231 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8232 Omit unused local vars.
c499e557 8233 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8234 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8235 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8236 Omit unused local var.
8237
ba0165e1
PE
8238 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8239 Don't assume string length fits in int.
32ad8845 8240 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8241 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8242
3c59b4c9
PE
8243 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8244 instead of alloca (Bug#8344).
8245
a3eed478 8246 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8247 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8248
eb4d412d
PE
8249 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8250
1658b401
PE
8251 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8252 concerns.
8253
8254 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8255
8256 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8257
9a2c6e05
PE
8258 * keyboard.c (syms_of_keyboard): Use the same style as later
8259 in this function when indexing through an array. This also
8260 works around GCC bug 48267.
8261
03d0a109
PE
8262 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8263
44f730c8
PE
8264 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8265
fe75f926
PE
8266 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8267 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8268
ffa8c828
PE
8269 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8270 This avoids undefined behavior on integer overflow, and is a bit
8271 more convenient anyway since it is compared to a size_t variable.
8272
c5101a77
PE
8273 Variadic C functions now count arguments with size_t, not int.
8274 This avoids an unnecessary limitation on 64-bit machines, which
8275 caused (substring ...) to crash on large vectors (Bug#8344).
8276 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8277 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8278 All variadic functions and their callers changed accordingly.
c5101a77
PE
8279 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8280 * data.c (arith_driver, float_arith_driver): Likewise.
8281 * editfns.c (general_insert_function): Likewise.
8282 * eval.c (struct backtrace.nargs, interactive_p)
8283 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8284 (funcall_lambda, mark_backtrace): Likewise.
8285 * fns.c (concat): Likewise.
8286 * frame.c (x_set_frame_parameters): Likewise.
8287 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8288 0 if not found, not -1. All callers changed.
8289
dd3f25f7
PE
8290 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8291 (stack_copy_size): Now size_t, not int.
8292 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8293
461c2ab9
JB
82942011-03-28 Juanma Barranquero <lekktu@gmail.com>
8295
8296 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8297 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8298 All callers changed.
8299
8300 * lisp.h (multibyte_char_to_unibyte):
8301 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8302 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8303 * character.h (CHAR_TO_BYTE8):
8304 * cmds.c (internal_self_insert):
8305 * editfns.c (general_insert_function):
8306 * keymap.c (push_key_description):
8307 * search.c (Freplace_match):
8308 * xdisp.c (message_dolog, set_message_1): All callers changed.
8309
f6d62986
SM
83102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8311
8312 * keyboard.c (safe_run_hook_funcall): New function.
8313 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8314 don't set the hook to nil, but remove the offending function instead.
8315 (Qcommand_hook_internal): Remove, unused.
8316 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8317 Vcommand_hook_internal.
8318
8319 * eval.c (enum run_hooks_condition): Remove.
8320 (funcall_nil, funcall_not): New functions.
8321 (run_hook_with_args): Call each function through a `funcall' argument.
8322 Remove `cond' argument, now redundant.
8323 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8324 (Frun_hook_with_args_until_failure): Adjust accordingly.
8325 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8326
1db5b1ad
JB
83272011-03-28 Juanma Barranquero <lekktu@gmail.com>
8328
8329 * dispextern.h (string_buffer_position): Remove declaration.
8330
8331 * print.c (strout): Remove parameter `multibyte', unused since
8332 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8333
8334 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8335 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8336 All callers changed.
8337
8338 * w32.c (_wsa_errlist): Use braces for struct initializers.
8339
8340 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8341 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8342 All callers changed.
8343 (string_buffer_position): Likewise. Also, make static (it's never
8344 used outside xdisp.c).
8345 (cursor_row_p): Remove parameter `w', unused since
8346 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8347 (decode_mode_spec): Remove parameter `precision', introduced during
8348 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8349 All callers changed.
8350
5ffb62aa
JD
83512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8352
8353 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8354
461c2ab9 83552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8356
8357 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8358 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8359 (ns_update_auto_hide_menu_bar): New functions.
8360 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8361 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8362 ns_constrain_all_frames.
8363 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8364 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8365
5c380ffb
JD
83662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8367
8368 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8369
9af30bdf
GM
83702011-03-27 Glenn Morris <rgm@gnu.org>
8371
8372 * syssignal.h: Replace RETSIGTYPE with void.
8373 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8374 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8375 Replace SIGTYPE with void everywhere.
8376 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8377 * s/template.h (SIGTYPE): Remove commented out definition.
8378
e2abce01
JB
83792011-03-26 Eli Zaretskii <eliz@gnu.org>
8380
8381 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8382 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8383
f868cd8a
JB
83842011-03-26 Juanma Barranquero <lekktu@gmail.com>
8385
59eb0929
JB
8386 * w32.c (read_unc_volume): Use parameter `henum', instead of
8387 global variable `wget_enum_handle'.
8388
8389 * keymap.c (describe_vector): Remove parameters `indices' and
8390 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8391 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8392
f868cd8a
JB
8393 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8394
8395 * keyboard.c (timer_check): Remove parameter `do_it_now',
8396 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8397 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8398 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8399
8400 * keyboard.c (read_char):
8401 * w32menu.c (w32_menu_display_help):
8402 * xmenu.c (show_help_event, menu_help_callback):
8403 Adjust calls to `show_help_echo'.
8404
8405 * gtkutil.c (xg_maybe_add_timer):
8406 * keyboard.c (readable_events):
8407 * process.c (wait_reading_process_output):
8408 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8409
8410 * insdel.c (adjust_markers_gap_motion):
8411 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8412 (gap_left, gap_right): Don't call it.
8413
2ecf6fdb
CY
84142011-03-25 Chong Yidong <cyd@stupidchicken.com>
8415
8416 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8417 incurred during fontification.
8418
6b1f9ba4
JB
84192011-03-25 Juanma Barranquero <lekktu@gmail.com>
8420
8421 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8422 (DEFVAR_PER_BUFFER): Don't pass it.
8423
8424 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8425 (scrolling_window): Don't pass it.
8426
0f4a96b5
JB
84272011-03-25 Juanma Barranquero <lekktu@gmail.com>
8428
8429 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8430
8431 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8432 and `suffix'.
8433 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8434 of variables specific to SELinux and computation of `encoded_absname'.
8435
8436 * image.c (XPutPixel): Remove unused variable `height'.
8437
8438 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8439
8440 * unexw32.c (get_section_info): Remove unused variable `section'.
8441
8442 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8443 (system_process_attributes): Remove unused variable `sess'.
8444 (sys_read): Remove unused variable `err'.
8445
8446 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8447 (w32_wnd_proc): Remove unused variable `isdead'.
8448 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8449 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8450 (x_create_tip_frame): Remove unused variable `tem'.
8451
8452 * w32inevt.c (w32_console_read_socket):
8453 Remove unused variable `no_events'.
8454
8455 * w32term.c (x_draw_composite_glyph_string_foreground):
8456 Remove unused variable `width'.
8457
1149507c
JB
84582011-03-24 Juanma Barranquero <lekktu@gmail.com>
8459
8460 * w32term.c (x_set_glyph_string_clipping):
8461 Don't pass uninitialized region to CombineRgn.
8462
9c88f339
JB
84632011-03-23 Juanma Barranquero <lekktu@gmail.com>
8464
8465 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8466 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8467 (Fx_close_connection): Remove unused variable `i'.
8468
8469 * w32font.c (w32font_draw): Return number of glyphs.
8470 (w32font_open_internal): Remove unused variable `i'.
8471 (w32font_driver): Add missing initializer.
8472
8473 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8474 (fill_in_menu): Remove unused variable `items_added'.
8475
8476 * w32term.c (last_mouse_press_frame): Remove static global variable.
8477 (w32_clip_to_row): Remove unused variable `f'.
8478 (x_delete_terminal): Remove unused variable `i'.
8479
8480 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8481 (NOTHING): Remove unused static global variable.
8482 (uniscribe_check_otf): Remove unused variable `table'.
8483 (uniscribe_font_driver): Add missing initializers.
8484
dee091a3
JD
84852011-03-23 Julien Danjou <julien@danjou.info>
8486
8487 * term.c (Fsuspend_tty, Fresume_tty):
8488 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8489 * window.c (temp_output_buffer_show):
8490 * insdel.c (signal_before_change):
8491 * frame.c (Fhandle_switch_frame):
8492 * fileio.c (Fdo_auto_save):
8493 * emacs.c (Fkill_emacs):
8494 * editfns.c (save_excursion_restore):
8495 * cmds.c (internal_self_insert):
8496 * callint.c (Fcall_interactively):
8497 * buffer.c (Fkill_all_local_variables):
8498 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8499 Use Frun_hooks.
0f4a96b5 8500 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8501 unconditionally since it does the check itself.
dee091a3 8502
2c520ab5 85032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8504
c9c49752
PE
8505 Fix more problems found by GCC 4.5.2's static checks.
8506
8abc3f12
PE
8507 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8508 the first time through the loop, since we know p0 < p1 then.
8509 This also avoids a gcc -Wstrict-overflow warning.
8510
a2d26660
PE
8511 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8512 leading to a memory leak, possible in functions like
8513 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8514 of objects (Bug#8318).
a2d26660 8515
916c72e9
PE
8516 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8517 that could (at least in theory) be that large.
8518
19ab8a18
PE
8519 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8520 This is less likely to overflow, and avoids undefined behavior if
8521 overflow does occur. All callers changed. Use strtoul to scan
8522 for the unsigned long integer.
b7cbbd6f
PE
8523 (pint2hrstr): Simplify and tune code slightly.
8524 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8525
f0641eff
PE
8526 * scroll.c (do_scrolling): Work around GCC bug 48228.
8527 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8528
7f650bb9
PE
8529 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8530 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8531 (validate_x_resource_name): Simplify count usage.
8532 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8533
37dd57d1
PE
8534 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8535 fail (Bug#8306).
81e56e61 8536
699979fc 8537 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8538
401bf9b4
PE
8539 * process.c (Fmake_network_process): Use socklen_t, not int,
8540 where POSIX says socklen_t is required in portable programs.
8541 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8542 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8543 (Fmake_network_process, server_accept_connection):
8544 (wait_reading_process_output, read_process_output):
8545 Likewise.
8546
b93aacde
PE
8547 * process.c: Rename or move locals to avoid shadowing.
8548 (list_processes_1, Fmake_network_process):
8549 (read_process_output_error_handler, exec_sentinel_error_handler):
8550 Rename or move locals.
4dc343ee 8551 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8552 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8553 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8554 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8555 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8556
af8a867c 8557 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8558 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8559 Include tparam.h instead, since it declares them.
af8a867c
PE
8560 * cm.h (PC): Remove extern decl; tparam.h now does this.
8561 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8562 * terminfo.c: Include tparam.h, to check interfaces.
8563 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8564 (tparam): Adjust signature to match interface in tparam.h;
8565 this removes some undefined behavior. Check that outstring and len
8566 are zero, which they always are with Emacs.
8567 * tparam.h (PC, BC, UP): New extern decls.
8568
0248044d 8569 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8570 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8571
8ff096c1 8572 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8573 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8574 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8575 (ftfont_list): Remove unused local.
49eaafba
PE
8576 (get_adstyle_property, ftfont_pattern_entity):
8577 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8578 Rename locals to avoid shadowing.
8ff096c1 8579
e2be39f6
PE
8580 * xfont.c (xfont_list_family): Mark var as initialized.
8581
c9735e30
PE
8582 * xml.c (make_dom): Now static.
8583
8f5201ae
PE
8584 * composite.c (composition_compute_stop_pos): Rename local to
8585 avoid shadowing.
b246f932
PE
8586 (composition_reseat_it): Remove unused locals.
8587 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8588 (composition_update_it): Mark var as initialized.
11b61122
PE
8589 (find_automatic_composition): Mark vars as initialized,
8590 with a FIXME (Bug#8290).
8f5201ae 8591
760fbc2c
PE
8592 character.h: Rename locals to avoid shadowing.
8593 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8594 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8595 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8596 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8597 to avoid shadowing.
8598
ff08eb85
PE
8599 * textprop.c (property_change_between_p): Remove; unused.
8600
fc7bf025
PE
8601 * intervals.c (interval_start_pos): Now static.
8602
235d7abc
PE
8603 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8604
44f230aa
SM
8605 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8606 Rename locals to avoid shadowing.
3e7d6594 8607
50060332
PE
8608 * sound.c (wav_play, au_play, Fplay_sound_internal):
8609 Fix pointer signedness.
d01f234b 8610 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8611 (wav_play): Initialize a variable to 0, to prevent undefined
8612 behavior (Bug#8278).
50060332 8613
c4fc4e30
PE
8614 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8615
918436ed
PE
8616 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8617
c939f91b
PE
8618 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8619 clobbering (Bug#8298).
b9c7f648
PE
8620 * sysdep.c (sys_subshell): Likewise.
8621 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8622
6bd8c144
PE
8623 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8624 This should get cleaned up, so that child_setup has the
8625 same signature on all platforms.
8626
7710357c 8627 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8628 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8629
c59da222
CY
86302011-03-22 Chong Yidong <cyd@stupidchicken.com>
8631
8632 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8633 not to be necessary, and produces flickering.
8634
66b87493
GM
86352011-03-20 Glenn Morris <rgm@gnu.org>
8636
8637 * config.in: Remove file.
8638
45b6f6d5
JB
86392011-03-20 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8642 are now in src/globals.h.
8643 (syms_of_minibuf): Remove spurious & from previous change.
8644
cd394be1 86452011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8646
8647 * minibuf.c (completing-read-function): New variable.
8648 (completing-read-default): Rename from completing-read.
8649 (completing-read): Call completing-read-function.
8650
b14e3e21
CY
86512011-03-19 Juanma Barranquero <lekktu@gmail.com>
8652
8653 * xfaces.c (Fx_load_color_file):
8654 Read color file from absolute filename (bug#8250).
8655
f2b726e6
JB
86562011-03-19 Juanma Barranquero <lekktu@gmail.com>
8657
8658 * makefile.w32-in: Update dependencies.
8659
09f6ff02
EZ
86602011-03-17 Eli Zaretskii <eliz@gnu.org>
8661
8662 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8663
29a6015a
PE
86642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8665
a3a6c54e
PE
8666 Fix more problems found by GCC 4.5.2's static checks.
8667
b766f867
PE
8668 * process.c (make_serial_process_unwind, send_process_trap):
8669 (sigchld_handler): Now static.
8670
be02381c
PE
8671 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8672 That way, the code declares only the vars that it needs.
8673 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8674 * s/cygwin.h (PTY_ITERATION): Likewise.
8675 * s/darwin.h (PTY_ITERATION): Likewise.
8676 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8677
57048744
PE
8678 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8679 * process.c (allocate_pty): Don't declare stb unless it's needed.
8680
7914961c 8681 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8682 (CONSTANTLIM): Remove; unused.
8683 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8684 Define only if needed.
7914961c 8685
b3967b18
PE
8686 * unexelf.c (unexec): Name an expression,
8687 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8688 Use a different way to cause a compilation error if anyone uses
8689 n rather than nn, a way that does not involve shadowing.
73366a00 8690 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8691
29a6015a
PE
8692 * deps.mk (unexalpha.o): Remove; unused.
8693
43cfc33e 8694 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8695 * unexec.h: New file.
ce701a33
PE
8696 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8697 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8698 Depend on unexec.h.
8699 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8700 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8701 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8702 Change as necessary to match prototype in unexec.h.
ce701a33 8703
01f44d5a
PE
8704 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8705 shadowing.
4f63c6bb 8706 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8707
a6670b0b
PE
8708 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8709 Rename locals to avoid shadowing.
8710
cef2010d 8711 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8712 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8713
d4d7173a
PE
8714 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8715
f08b802a
PE
8716 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8717 warning when compiling print.c.
8718
3ddb0639
PE
8719 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8720 instead of using an uninitialized var.
5ad03b97 8721 (font_sort_entities): Mark var as initialized.
3ddb0639 8722
170a2692
PE
8723 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8724
e663c700
PE
8725 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8726 pointers to constants.
89bc529a 8727 (font_parse_fcname): Remove unused vars.
7b81e2d0 8728 (font_delete_unmatched): Now static.
ea838e10 8729 (font_get_spec): Remove; unused.
13a547c6
PE
8730 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8731 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8732 Rename or move locals to avoid shadowing.
e663c700 8733
2a80c887 8734 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8735 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8736
1384fa33 8737 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8738 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8739
8b2c52e9
PE
8740 * alloc.c (mark_backtrace): Move decl from here ...
8741 * lisp.h: ... to here, so that it can be checked.
8742
475545b5 8743 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8744 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8745 (lisp_indirect_variable): Name an expression,
8746 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8747 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8748
b1349114 8749 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8750 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8751 Use const pointer when appropriate.
b1349114 8752
a2928364
PE
8753 * lisp.h (get_system_name, get_operating_system_release):
8754 Move decls here, to check interfaces.
8755 * process.c (get_operating_system_release): Move decl to lisp.h.
8756 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8757 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8758 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8759 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8760 (Fformat_time_string, Fencode_time, Finsert_char):
8761 (Ftranslate_region_internal, Fformat):
8762 Rename or remove local vars to avoid shadowing.
9710023e 8763 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8764
a415e694
PE
8765 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8766 avoid shadowing.
8767
8ef4622d
PE
8768 * lisp.h (eassert): Check that the argument compiles, even if
8769 ENABLE_CHECKING is not defined.
8770
946f9a5b
PE
8771 * data.c (Findirect_variable): Name an expression, to avoid
8772 gcc -Wbad-function-cast warning.
112396d6 8773 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8774 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8775 (Fmake_variable_buffer_local, Fmake_local_variable):
8776 Mark variables as initialized.
52746918 8777 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8778
e5aab7e7 8779 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8780 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8781 Rename locals to avoid shadowing.
dff45157
PE
8782 (mark_stack): Move local variables into the #ifdef region where
8783 they're used.
7bc26fdb
PE
8784 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8785 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8786 needed otherwise.
8787 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8788 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8789 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8790
e5aab7e7
PE
8791 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8792 avoids undefined behavior in theory.
8793
4da60324
PE
8794 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8795
88043301
PE
8796 Use functions, not macros, for up- and down-casing (Bug#8254).
8797 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8798 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8799 to use the following functions instead of these macros.
8800 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8801 EMACS_INT, since callers assume the returned value fits in int.
8802 (upcase1): Likewise, for UPCASE_TABLE.
8803 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8804 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8805 the race-condition problem in the old DOWNCASE.
88043301 8806
19ed5445
PE
8807 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8808 Rename locals to avoid shadowing.
8809 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8810 (regex_compile, re_search_2, re_match_2_internal):
8811 Remove unused local vars.
952db0d7
PE
8812 (FREE_VAR): Rewrite so as not to use empty "else",
8813 which gcc can warn about.
da053e48 8814 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8815 (RETALLOC_IF): Define only if needed.
8816 (WORDCHAR_P): Likewise. This one is never needed, but is used
8817 only in a comment talking about a compiler bug, so put inside
8818 the #if 0 of that comment.
8819 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8820 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8821 Remove; unused.
19ed5445 8822
1f3561e4 8823 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8824 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8825 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8826
ded6f8f7
PE
8827 * search.c (simple_search): Remove unused var.
8828
dbd37a95
PE
8829 * dired.c (compile_pattern): Move decl from here ...
8830 * lisp.h: ... to here, so that it can be checked.
8831 (struct re_registers): New forward decl.
8832
7e47afad
PE
8833 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8834
85f24f61
PE
8835 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8836 All uses changed.
8837 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8838 Rename locals to avoid shadowing.
5671df8f 8839 (Fvertical_motion): Mark locals as initialized.
85f24f61 8840
181aa2be 8841 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8842 (casify_region): Mark local as initialized.
181aa2be 8843
930d429c
PE
8844 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8845
7082eac6
PE
8846 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8847 New macros, so that the caller can use some names other than
8848 gcpro1, gcpro2, etc.
8849 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8850 of the new macros.
8851 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8852 argument, for consistency with GCPRO2_VAR, etc: it is now the
8853 prefix of the variable, not the variable itself. All uses
8854 changed.
38b2c076
PE
8855 * dired.c (directory_files_internal, file_name_completion):
8856 Rename locals to avoid shadowing.
8857
15206ed9
PE
8858 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8859 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8860 dired.c's scmp function, had undefined behavior.
8861 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8862 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8863 * buffer.h: ... to here, because these macros use current_buffer,
8864 and the new implementation with inline functions needs to have
8865 current_buffer in scope now, rather than later when the macros
8866 are used.
8867 (downcase, upcase1): New static inline functions.
8868 (DOWNCASE, UPCASE1): Reimplement using these functions.
8869 This avoids undefined behavior in expressions like
8870 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8871 from race conditions in accessing the global variables
8872 case_temp1 and case_temp2.
8873 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8874 * lisp.h (case_temp1, case_temp2): Remove their decls.
8875 * character.h (ASCII_CHAR_P): Move from here ...
8876 * lisp.h: ... to here, so that the inline functions mentioned
8877 above can use them.
8878
4a6bea26
PE
8879 * dired.c (directory_files_internal_unwind): Now static.
8880
f14b7e14
PE
8881 * fileio.c (file_name_as_directory, directory_file_name):
8882 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8883 Now static.
2893f146
PE
8884 (file_name_as_directory): Use const pointers when appropriate.
8885 (Fexpand_file_name): Likewise. In particular, newdir might
8886 point at constant storage, so make it a const pointer.
fd4ead52 8887 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8888 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8889 signedness issues.
f839df0c
PE
8890 (Fset_file_times, Finsert_file_contents, auto_save_error):
8891 Rename locals to avoid shadowing.
f14b7e14 8892
5716756e 8893 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8894 (Ftry_completion, Fall_completions): Rename or remove locals
8895 to avoid shadowing.
5716756e 8896
b4c3046a
PE
8897 * marker.c (bytepos_to_charpos): Remove; unused.
8898
b45db522
PE
8899 * lisp.h (verify_bytepos, count_markers): New decls,
8900 so that gcc does not warn that these functions aren't declared.
8901
85876d07
PE
8902 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8903 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8904 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8905 (copy_text): Remove unused local var.
85876d07 8906
03d78a21 8907 * filelock.c (within_one_second): Now static.
b3dd38ab 8908 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8909
5df8f01b
PE
8910 * buffer.c (fix_overlays_before): Mark locals as initialized.
8911 (fix_start_end_in_overlays): Likewise. This function should be
8912 simplified by using pointers-to-pointers, but that's a different
8913 matter.
b1d876f1 8914 (switch_to_buffer_1): Now static.
8f54f30a
PE
8915 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8916 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8917
a70072c9 8918 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8919 Fix pointer signedness issue.
edced198
PE
8920 (sys_subshell): Mark local as volatile if checking for lint,
8921 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8922 (MAXPATHLEN): Define only if needed.
a70072c9 8923
a0977c44
PE
8924 * process.c (serial_open, serial_configure): Move decls from here ...
8925 * systty.h: ... to here, so that they can be checked.
8926
a884fdcc
PE
8927 * fns.c (get_random, seed_random): Move extern decls from here ...
8928 * lisp.h: ... to here, so that they can be checked.
8929
604efe86 8930 * sysdep.c (reset_io): Now static.
b8950c94 8931 (wait_for_termination_signal): Remove; unused.
604efe86 8932
38fc62d9
PE
8933 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8934 (copy_keymap_item, append_key, push_text_char_description):
8935 Now static.
1004a21a 8936 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8937 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8938 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8939 (describe_map_tree):
8940 Rename locals to avoid shadowing.
38fc62d9 8941
2f2650da
PE
8942 * keyboard.c: Declare functions static if they are not used elsewhere.
8943 (echo_char, echo_dash, cmd_error, top_level_2):
8944 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8945 (read_char, kbd_buffer_get_event, make_lispy_position):
8946 (make_lispy_event, make_lispy_movement, apply_modifiers):
8947 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8948 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8949 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8950 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8951 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8952
a053e86c 8953 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8954 (mark_kboards): Move decl here ...
8955 * alloc.c (mark_kboards): ... from here.
a053e86c 8956
4752793e
PE
8957 * lisp.h (force_auto_save_soon): New decl.
8958
74f10ca7 8959 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8960 (DEFINE_DUMMY_FUNCTION): New macro.
8961 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8962 Use it.
c03cd23f
PE
8963 (main): Add casts to avoid warnings
8964 if GCC considers string literals to be constants.
74f10ca7 8965
022e70d4
PE
8966 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8967
59d6fe83
PE
8968 * dbusbind.c: Pointer signedness fixes.
8969 (xd_signature, xd_append_arg, xd_initialize):
8970 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8971 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8972 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8973 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8974
78320123
PE
8975 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8976 if GCC considers string literals to be constants.
49cebcca 8977 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8978
35ac2a97
SM
89792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8980
fb103ca9
SM
8981 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8982 (print_preprocess, print_object): New macro to fix last change.
8983
35ac2a97
SM
8984 * print.c (print_preprocess): Don't forget font objects.
8985
62973b41
JB
89862011-03-16 Juanma Barranquero <lekktu@gmail.com>
8987
8988 * emacs.c (USAGE3): Doc fixes.
8989
0e48bb22
AS
89902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8991
8992 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8993 structure.
8994
7684e57b
JB
89952011-03-14 Juanma Barranquero <lekktu@gmail.com>
8996
8997 * lisp.h (VWindow_system, Qfile_name_history):
8998 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8999 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9000 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9001
9002 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9003 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9004
9005 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9006 * w32console.c (detect_input_pending, read_input_pending)
9007 (encode_terminal_code):
9008 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9009 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9010 (w32_system_caret_y, Qfile_name_history):
9011 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9012 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9013 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9014 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9015 * w32proc.c (Qlocal, report_file_error):
9016 * w32term.c (Vwindow_system, updating_frame):
9017 * w32uniscribe.c (initialized, uniscribe_font_driver):
9018 Remove unneeded extern declarations.
9019
2aa46d6c
CY
90202011-03-14 Chong Yidong <cyd@stupidchicken.com>
9021
c96bbc66 9022 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9023
cffc6f3b
CY
90242011-03-13 Chong Yidong <cyd@stupidchicken.com>
9025
9026 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9027 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9028 These macros can no longer be used for assignment.
9029
44f230aa
SM
9030 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9031 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9032 (record_buffer_markers, fetch_buffer_markers): New functions for
9033 recording and fetching special buffer markers.
9034 (set_buffer_internal_1, set_buffer_temp): Use them.
9035
9036 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9037
9038 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9039
9040 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9041 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9042
9043 * xdisp.c (hscroll_window_tree):
9044 (reconsider_clip_changes): Use PT instead of BUF_PT.
9045
d251f04b
EZ
90462011-03-13 Eli Zaretskii <eliz@gnu.org>
9047
9048 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9049 $(EMACS_ROOT)/lib/intprops.h.
9050
f0c77cd1
PE
90512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9052
3eca4629
PE
9053 Fix more problems found by GCC 4.5.2's static checks.
9054
7c86ee98
PE
9055 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9056 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9057 (xg_free_frame_widgets): Make it clear that a local variable is
9058 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9059 (gdk_window_get_screen): Make it clear that this macro is needed
9060 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9061 (int_gtk_range_get_value): New function, which avoids a diagnostic
9062 from gcc -Wbad-function-cast.
9063 (xg_set_toolkit_scroll_bar_thumb): Use it.
9064 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9065 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9066 (get_utf8_string, xg_get_file_with_chooser):
9067 Rename locals to avoid shadowing.
9068 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9069
41729b81
PE
9070 * xgselect.c (xg_select): Remove unused var.
9071
f0c77cd1
PE
9072 * image.c (four_corners_best): Mark locals as initialized.
9073 (gif_load): Initialize transparent_p to zero (Bug#8238).
9074 Mark another local as initialized.
ec6cf4c6 9075 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9076
ce0ad53d 9077 * image.c (clear_image_cache): Now static.
d5d5a617 9078 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9079 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9080 (x_edge_detection): Remove unnecessary cast that
9081 gcc -Wbad-function-cast diagnoses.
2037898d 9082 (gif_load): Fix pointer signedness.
6ae141d6
PE
9083 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9084 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9085
33383987 90862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9087
d32df629
PE
9088 Improve quality of tests for time stamp overflow.
9089 For example, without this patch (encode-time 0 0 0 1 1
9090 1152921504606846976) returns the obviously-bogus value (-948597
9091 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9092 reports time overflow. See
9093 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9094 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9095 * editfns.c: Include limits.h and intprops.h.
9096 (TIME_T_MIN, TIME_T_MAX): New macros.
9097 (time_overflow): Move earlier, to before first use.
9098 (hi_time, lo_time): New functions, for an accurate test for
9099 out-of-range times.
9100 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9101 (Fget_internal_run_time): Don't assume time_t fits in int.
9102 (make_time): Use list2 instead of Fcons twice.
9103 (Fdecode_time): More accurate test for out-of-range times.
9104 (check_tm_member): New function.
9105 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9106 (lisp_time_argument): Don't rely on undefined left-shift and
9107 right-shift behavior when checking for time stamp overflow.
8be6f318 9108
fe31d94c
PE
9109 * editfns.c (time_overflow): New function, refactoring common code.
9110 (Fformat_time_string, Fdecode_time, Fencode_time):
9111 (Fcurrent_time_string): Use it.
9112
8be6f318
PE
9113 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9114 * dired.c (make_time): Move to ...
9115 * editfns.c (make_time): ... here.
9116 * systime.h: Note the move.
9117
09d9db2c 91182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9119
126bc0dc
YM
9120 * fringe.c (update_window_fringes): Remove unused variables.
9121
c47cbdfd
YM
9122 * unexmacosx.c (copy_data_segment): Also copy __got section.
9123 (Bug#8223)
9124
7ac80be9
EZ
91252011-03-12 Eli Zaretskii <eliz@gnu.org>
9126
c96bbc66 9127 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9128 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9129 Constify `char *' arguments and their references according to
9130 prototypes in tparam.h.
9131
ecb0f94d 9132 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9133
7ac80be9
EZ
9134 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9135 Adapt all references accordingly.
9136
9137 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9138
ef1fd07e
TT
91392011-03-11 Tom Tromey <tromey@redhat.com>
9140
9141 * buffer.c (syms_of_buffer): Remove obsolete comment.
9142
7ef4b50c
EZ
91432011-03-11 Eli Zaretskii <eliz@gnu.org>
9144
9145 * termhooks.h (encode_terminal_code): Declare prototype.
9146
9147 * msdos.c (encode_terminal_code): Don't declare prototype.
9148
9149 * term.c (encode_terminal_code): Now external again, used by
9150 w32console.c and msdos.c.
9151
44f230aa
SM
9152 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9153 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9154
4b1ec863 91552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9156
1714f52b 9157 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9158
4b1ec863
PE
9159 * fringe.c (update_window_fringes): Mark locals as initialized
9160 (Bug#8227).
9161 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9162
524c7aa6
PE
9163 * alloc.c (mark_fringe_data): Move decl from here ...
9164 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9165 to check its interface.
9166 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9167
a5c0af81 9168 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9169 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9170 (fontset_font): Mark local as initialized.
a9a06e0b 9171 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9172
b4716021
PE
9173 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9174
811e9bac 9175 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9176 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9177 (x_own_selection, Fx_disown_selection_internal): Rename locals
9178 to avoid shadowing.
9179 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9180
7e3ab302
PE
9181 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9182 so that the caller can use some name other than gcpro1.
9183 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9184 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9185 (Fx_backspace_delete_keys_p):
9186 Use them to avoid shadowing, and rename vars to avoid shadowing.
9187 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9188 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9189 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9190 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9191 Remove unused locals.
7e3ab302
PE
9192 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9193 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9194 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9195 macros.
f78faa98 9196
e2b13473
PE
9197 * xterm.h (x_mouse_leave): New decl.
9198
77f23912
PE
9199 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9200 Remove unused functions.
cdf4ba58
PE
9201 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9202 (x_calc_absolute_position): Now static.
7411c686 9203 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9204 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9205 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9206 unless they are used.
38d0b34a
PE
9207 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9208 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9209 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9210 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9211 (x_error_catcher, x_connection_closed, x_error_handler):
9212 (x_error_quitter, xembed_send_message, x_iconify_frame):
9213 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9214 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9215 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9216
44f230aa
SM
9217 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9218 Rename or move locals to avoid shadowing.
6b463e58 9219 (tty_defined_color, merge_face_heights): Now static.
5967d051 9220 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9221 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9222 does not deduce is never used uninitialized.
73719eba
PE
9223 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9224 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9225
426994c3 9226 * terminal.c (store_terminal_param): Now static.
5489860b 9227
032f1620 9228 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9229 (set_frame_menubar): Remove unused local.
d4323972 9230 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9231 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9232 since they might point to immutable storage.
281585b0
PE
9233 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9234 since it's unused otherwise.
032f1620 9235
367c19e5 9236 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9237 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9238 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9239 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9240 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9241 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9242 does not deduce are never used uninitialized.
70739cbe 9243
07b48fa9
PE
9244 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9245
8868a238 9246 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9247 * window.c (window_loop, size_window):
9248 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9249
7e5cf297 9250 * window.c (display_buffer): Now static.
d6550a9f
PE
9251 (size_window): Mark variables that gcc -Wuninitialized
9252 does not deduce are never used uninitialized.
a586633d
PE
9253 * window.h (check_all_windows): New decl, to forestall
9254 gcc -Wmissing-prototypes diagnostic.
5b555da1 9255 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9256
f6095868
PE
9257 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9258 shadowing.
9259 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9260 Include <limits.h>.
9261 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9262 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9263 (load_charset_map): Mark variables that gcc -Wuninitialized
9264 does not deduce are never used uninitialized.
53df7c11 9265 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9266
f38b440c
PE
9267 * coding.c (coding_set_source, coding_set_destination):
9268 Use "else { /* comment */ }" rather than "else /* comment */;"
9269 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9270 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9271 a block, when the outer 'i' will do.
9272 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9273 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9274 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9275 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9276 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9277 Rename locals to avoid shadowing.
9278 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9279 * coding.c (emacs_mule_char, encode_invocation_designation):
9280 Now static, since they're not used elsewhere.
413bb2db 9281 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9282 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9283 (decode_coding_emacs_mule): Mark variables that gcc
9284 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9285 (detect_coding_iso_2022): Initialize a local variable that might
9286 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9287 this initialization is needed. (Bug#8211)
5f58e762
PE
9288 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9289 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9290 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9291 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9292 Remove unused macros.
f38b440c 9293
232b38b9 9294 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9295 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9296 * character.c (string_count_byte8): Likewise.
232b38b9 9297
fb90da1b
PE
9298 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9299 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9300
fb93dbc2
PE
9301 * chartab.c (copy_sub_char_table): Now static, since it's not used
9302 elsewhere.
5c156ace
PE
9303 (sub_char_table_ref_and_range, char_table_ref_and_range):
9304 Rename locals to avoid shadowing.
bbcd0949 9305 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9306
7d3b3862 9307 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9308 (BIDI_BOB): Remove unused macro.
7d3b3862 9309
6be7d3da
PE
9310 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9311 deduce are never used uninitialized.
c2ed9c8b 9312 * term.c (encode_terminal_code): Likewise.
6be7d3da 9313
75f8807f 9314 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9315
50938595
PE
9316 * tparam.h: New file.
9317 * term.c, tparam.h: Include it.
9318 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9319 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9320 Move these decls to tparam.h, and make them agree with what
9321 is actually in tparam.c. The previous trick of using incompatible
9322 decls in different modules does not conform to the C standard.
9323 All callers of tparam changed to use tparam's actual API.
9324 * tparam.c (tparam1, tparam, tgoto):
9325 Use const pointers where appropriate.
9326
fbceeba2
PE
9327 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9328 * cm.h (struct cm): Likewise.
9329 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9330 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9331 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9332 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9333 (turn_on_face, init_tty): Likewise.
9334 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9335
7f3f1250
PE
9336 * term.c (term_mouse_position): Rename local to avoid shadowing.
9337
e6ca6543
PE
9338 * alloc.c (mark_ttys): Move decl from here ...
9339 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9340
c40f8d15
AS
93412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9342
9343 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9344
cfe0661d
JB
93452011-03-09 Juanma Barranquero <lekktu@gmail.com>
9346
9347 * search.c (compile_pattern_1): Remove argument regp, unused since
9348 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9349 (compile_pattern): Don't pass it.
9350
0afb4571
J
93512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9352
9353 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9354 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9355 for ! HAVE_GTK3.
9356 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9357
9358 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9359
9360 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9361 gdk_window_get_screen, gdk_window_get_geometry,
9362 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9363 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9364 (xg_get_pixbuf_from_pixmap): New function.
9365 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9366 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9367 Call xg_get_pixbuf_from_pixmap instead of
9368 gdk_pixbuf_get_from_drawable.
9369 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9370 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9371 (xg_check_special_colors): Use GtkStyleContext and its functions
9372 for HAVE_GTK3.
9373 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9374 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9375 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9376 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9377 Call gtk_widget_get_preferred_size.
0afb4571
J
9378 (xg_frame_resized): gdk_window_get_geometry only takes 5
9379 parameters.
44f230aa
SM
9380 (xg_win_to_widget, xg_event_is_for_menubar):
9381 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9382 (xg_set_widget_bg): New function.
9383 (delete_cb): New function.
895009e1 9384 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9385 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9386 (xg_set_background_color): Call xg_set_widget_bg.
9387 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9388 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9389 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9390 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9391 if ! HAVE_GTK3.
9392 (update_frame_tool_bar): Call gtk_widget_hide.
9393 (xg_initialize): Use GDK_KEY_g.
9394
9395 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9396 if ! HAVE_GTK3
9397 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9398
9399 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9400 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9401 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9402
1c2cc4ef
JB
94032011-03-08 Juanma Barranquero <lekktu@gmail.com>
9404
9405 * w32xfns.c (select_palette): Check success of RealizePalette against
9406 GDI_ERROR, not zero.
9407
33383987 9408See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9409
9410;; Local Variables:
9411;; coding: utf-8
aac0c6e3
MR
9412;; End:
9413
acaf905b 9414 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9415
9416 This file is part of GNU Emacs.
9417
9418 GNU Emacs is free software: you can redistribute it and/or modify
9419 it under the terms of the GNU General Public License as published by
9420 the Free Software Foundation, either version 3 of the License, or
9421 (at your option) any later version.
9422
9423 GNU Emacs is distributed in the hope that it will be useful,
9424 but WITHOUT ANY WARRANTY; without even the implied warranty of
9425 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9426 GNU General Public License for more details.
9427
9428 You should have received a copy of the GNU General Public License
9429 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.