* composite.c: Integer overflow fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bc18e09d
PE
12011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
d86d0d74
PE
3 * composite.c: Integer overflow fixes.
4 (get_composition_id): Check for overflow in glyph length calculations.
5
5d009b3a
PE
6 * coding.c: Integer and memory overflow fixes.
7 (produce_chars): Redo buffer-overflow calculations to avoid
8 unnecessary integer overflow. Check for size overflow.
9 (encode_coding_object): Don't update size until xmalloc succeeds.
10
17828df2
PE
11 * character.c (Fstring): Check for size-calculation overflow.
12
69e8622f
PE
13 * ccl.c: Integer and memory overflow fixes.
14 (Fccl_execute_on_string): Check for memory overflow.
15 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
16 Redo buffer-overflow calculations to avoid integer overflow.
17
860887db
PE
18 * callproc.c (child_setup): Don't assume strlen fits in int.
19
6e1fc452
PE
20 * buffer.c: Memory overflow fixes.
21 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
22 Don't update size of array until after memory allocation succeeds,
23 because xmalloc/xrealloc may not return.
24
bc18e09d
PE
25 * bidi.c: Integer overflow fix.
26 (bidi_shelve_header_size): New constant.
27 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
28 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
29
5637687f
PE
302011-07-19 Paul Eggert <eggert@cs.ucla.edu>
31
ebfa62c0
PE
32 Use ptrdiff_t for composition IDs.
33 * character.c (lisp_string_width):
34 * composite.c (composition_table_size, n_compositions)
35 (get_composition_id, composition_gstring_from_id):
36 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
37 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
38 * window.c (Frecenter):
39 Use ptrdiff_t, not int, for composition IDs.
40 * composite.c (get_composition_id): Check for integer overflow.
41 * composite.h: Adjust prototypes to match the above changes.
42
d3411f89
PE
43 Use ptrdiff_t for hash table indexes.
44 * category.c (hash_get_category_set):
45 * ccl.c (ccl_driver):
46 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
47 * coding.c (coding_system_charset_list, detect_coding_system):
48 * coding.h (struct coding_system.id):
49 * composite.c (get_composition_id, gstring_lookup_cache):
50 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
51 * image.c (xpm_get_color_table_h):
52 * lisp.h (hash_lookup, hash_put):
53 * minibuf.c (Ftest_completion):
54 Use ptrdiff_t for hash table indexes, not int (which is too
55 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
56 32-bit --with-wide-int hosts).
57
e097a6fa
PE
58 * charset.c (Fdefine_charset_internal): Check for integer overflow.
59 Add a FIXME comment about memory leaks.
60 (syms_of_charset): Don't assume xmalloc returns.
61
5637687f
PE
62 Don't assume that stated character widths fit in int.
63 * character.c (Fchar_width, c_string_width, lisp_string_width):
64 * character.h (CHAR_WIDTH):
65 * indent.c (MULTIBYTE_BYTES_WIDTH):
66 Use sanitize_char_width to avoid undefined and/or bad behavior
67 with outlandish widths.
68 * character.h (sanitize_tab_width): Renamed from sanitize_width,
69 now that we have two such functions. All uses changed.
70 (sanitize_char_width): New inline function.
71
a2271ba2
PE
72 Don't assume that tab-width fits in int.
73 * character.h (sanitize_width): New inline function.
74 (SANE_TAB_WIDTH): New macro.
75 (ASCII_CHAR_WIDTH): Use it.
76 * indent.c (sane_tab_width): Remove. All uses replaced by
77 SANE_TAB_WIDTH (current_buffer).
78 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
79
18c52557
PE
80 * fileio.c: Integer overflow issues with file modes.
81 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
82
caeeedc1
PE
83 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
84 Remove unreachable code.
85 (read_hex, load_charset_map_from_file): Check for integer overflow.
86
50849c52
PE
87 * xterm.c: don't go over XClientMessageEvent limit
88 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
89 (x_send_scroll_bar_event): Likewise. Check that the size does not
90 exceed limits imposed by XClientMessageEvent, as well as the usual
91 ptrdiff_t and size_t limits.
92
b13995db
PE
93 * keyboard.c: Overflow, signedness and related fixes.
94 (make_lispy_movement): Use same integer type in forward decl
95 that is used in the definition.
96 (read_key_sequence, keyremap_step):
97 Change bufsize argument back to int, undoing my 2011-03-30 change.
98 We prefer signed types, and int is wide enough here.
99 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
100 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
101 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
102 length, not size_t. Use ptrdiff_t for index, not int.
103 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
104 possibility of integer overflow.
105
13464394
PE
106 Overflow, signedness and related fixes for images.
107
108 * dispextern.h (struct it.stack[0].u.image.image_id)
109 (struct_it.image_id, struct image.id, struct image_cache.size)
110 (struct image_cache.used, struct image_cache.ref_count):
111 * gtkutil.c (update_frame_tool_bar):
112 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
113 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
114 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
115 * nsmenu.m (update_frame_tool_bar):
116 * xdisp.c (calc_pixel_width_or_height):
117 * xfns.c (image_cache_refcount):
118 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
119 on typical 64-bit hosts.
120
121 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
122 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
123 Omit unnecessary casts to int.
124 (parse_image_spec): Check that integers fall into 'int' range
125 when the callers expect that.
126 (image_ascent): Redo ascent calculation to avoid int overflow.
127 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
128 (lookup_image): Remove unnecessary tests.
129 (xbm_image_p): Locals are now of int, not EMACS_INT,
130 since parse_image_check makes sure they fit into int.
131 (png_load, gif_load, svg_load_image):
132 Prefer int to unsigned where either will do.
133 (tiff_handler): New function, combining the cores of the
134 old tiff_error_handler and tiff_warning_handler. This
135 function is rewritten to use vsnprintf and thereby avoid
136 stack buffer overflows. It uses only the features of vsnprintf
137 that are common to both POSIX and native Microsoft.
138 (tiff_error_handler, tiff_warning_handler): Use it.
139 (tiff_load, gif_load, imagemagick_load_image):
140 Don't assume :index value fits in 'int'.
141 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
142 (imagemagick_load_image): Check that crop parameters fit into
143 the integer types that MagickCropImage accepts. Don't assume
144 Vimagemagick_render_type has a nonnegative value. Don't assume
145 size_t fits in 'long'.
146 (gs_load): Use printmax_t to print the widest integers possible.
147 Check for integer overflow when computing image height and width.
148
0d8de0fd 1492011-07-19 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 150
41f55ccd 151 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 152
39e378da
PE
153 * bidi.c: Integer size and overflow fixes.
154 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
155 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
156 (bidi_cache_find_level_change, bidi_cache_ensure_space)
157 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
158 (bidi_find_other_level_edge):
159 Use ptrdiff_t instead of EMACS_INT where either will do.
160 This works better on 32-bit hosts configured --with-wide-int.
161 (bidi_cache_ensure_space): Check for size-calculation overflow.
162 Use % rather than repeated addition, for better worst-case speed.
163 Don't set bidi_cache_size until after xrealloc returns, because it
164 might not return.
165 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
166 (bidi_cache_ensure_space): Also check that the bidi cache size
167 does not exceed that of the largest Lisp string or buffer. See Eli
168 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 169
5e927815
PE
170 * alloc.c (__malloc_size_t): Remove.
171 All uses replaced by size_t. See Andreas Schwab's note
172 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
173
ca4aa935
PE
174 * image.c: Improve checking for integer overflow.
175 (check_image_size): Assume that f is nonnull, since
176 it is always nonnull in practice. This is one less thing to
177 worry about when checking for integer overflow later.
178 (x_check_image_size): New function, which checks for integer
179 overflow issues inside X.
180 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
181 This removes the need for a memory_full check.
182 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
183 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
184 (xbm_read_bitmap_data): Change locals back to 'int', since
185 their values must fit in 'int'.
186 (xpm_load_image, png_load, tiff_load):
187 Invoke x_create_x_image_and_pixmap earlier,
188 to avoid much needless work if the image is too large.
189 (tiff_load): Treat overly large images as if
190 x_create_x_image_and_pixmap failed, not as malloc failures.
191 (gs_load): Use x_check_image_size.
192
5f8f9cc2
PE
193 * gtkutil.c: Omit integer casts.
194 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
195 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
196
5adf60bc
PE
197 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
198
c8907a93
PE
199 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
200 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
201 would wrongly return t on a 64-bit host.
202
e3c25c68
PE
203 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
204 The plain *_OVERFLOW macros run afoul of GCC bug 49705
205 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
206 and therefore cause GCC to emit a bogus diagnostic in some cases.
207
3f791afe
PE
208 * image.c: Integer signedness and overflow and related fixes.
209 This is not an exhaustive set of fixes, but it's time to
210 record what I've got.
211 (lookup_pixel_color, check_image_size): Remove redundant decls.
212 (check_image_size): Don't assume that arbitrary EMACS_INT values
213 fit in 'int', or that arbitrary 'double' values fit in 'int'.
214 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
215 (tiff_load, imagemagick_load_image):
216 Check for overflow in size calculations.
217 (x_create_x_image_and_pixmap): Remove unnecessary test for
218 xmalloc returning NULL; that can't happen.
219 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
220 (xpm_color_bucket): Use better integer hashing function.
221 (xpm_cache_color): Don't possibly over-allocate memory.
222 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
223 (gif_memory_source):
224 Use ptrdiff_t, not int or size_t, to record sizes.
225 (png_load): Don't assume values greater than 2**31 fit in 'int'.
226 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
227 either works, as we prefer signed integers.
228 (tiff_read_from_memory, tiff_write_from_memory):
229 Return tsize_t, not size_t, since that's what the TIFF API wants.
230 (tiff_read_from_memory): Don't fail simply because the read would
231 go past EOF; instead, return a short read.
232 (tiff_load): Omit no-longer-needed casts.
233 (Fimagemagick_types): Don't assume size fits into 'int'.
234
3cc5a532
PE
235 Improve hashing quality when configured --with-wide-int.
236 * fns.c (hash_string): New function, taken from sxhash_string.
237 Do not discard information about ASCII character case; this
238 discarding is no longer needed.
239 (sxhash-string): Use it. Change sig to match it. Caller changed.
240 * lisp.h: Declare it.
241 * lread.c (hash_string): Remove, since we now use fns.c's version.
242 The fns.c version returns a wider integer if --with-wide-int is
243 specified, so this should help the quality of the hashing a bit.
244
b312a492
PE
245 * emacs.c: Integer overflow minor fix.
246 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
247 Define only if GNU_LINUX.
248 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
249
dfd153ae
PE
250 * dispnew.c: Integer signedness and overflow fixes.
251 Remove unnecessary forward decls, that were a maintenance hassle.
252 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
253 All uses changed.
254 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
255 (scrolling_window): Use ptrdiff_t, not int, for byte count.
256 (prepare_desired_row, line_draw_cost):
257 Use int, not unsigned, where either works.
258 (save_current_matrix, restore_current_matrix):
259 Use ptrdiff_t, not size_t, where either works.
260 (init_display): Check for overflow more accurately, and without
261 relying on undefined behavior.
262
a81d11a3
PE
263 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
264 Remove, replacing with the new symbols in lisp.h. All uses changed.
265 * fileio.c (make_temp_name):
266 * filelock.c (lock_file_1, lock_file):
267 * xdisp.c (message_dolog):
268 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
269 Use pMd etc. instead.
270 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
271 replacing the pWIDE etc. symbols removed from editfns.c.
272
3300e6fd
PE
273 * keyboard.h (num_input_events): Now uintmax_t.
274 This is (very slightly) less likely to mess up due to wraparound.
275 All uses changed.
276
fd05c7e9
PE
277 * buffer.c: Integer signedness fixes.
278 (alloc_buffer_text, enlarge_buffer_text):
279 Use ptrdiff_t rather than size_t when either will do, as we prefer
280 signed integers.
281
903fe15d
PE
282 * alloc.c: Integer signedness and overflow fixes.
283 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
284 (__malloc_size_t): Default to size_t, not to int.
285 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
286 (Fgarbage_collect, mark_object_loop_halt, mark_object):
287 Prefer ptrdiff_t to size_t when either would do, as we prefer
288 signed integers.
289 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
290 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
291 Now const. Initialize with values that are in range even if char
292 is signed.
293 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
294 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
295 These functions do the right thing with sizes > 2**32.
296 (check_depth): Now ptrdiff_t, not int.
297 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
298 Adjust to new way of storing sizes. Check for size overflow bugs
299 in rest of code.
300 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
301 slightly wrong anyway, as it missed one instance of
302 XMALLOC_OVERRUN_CHECK_OVERHEAD.
303 (refill_memory_reserve): Omit needless cast to size_t.
304 (mark_object_loop_halt): Mark as externally visible.
305
ac82cc6a
PE
306 * xselect.c: Integer signedness and overflow fixes.
307 (Fx_register_dnd_atom, x_handle_dnd_message):
308 Use ptrdiff_t, not size_t, since we prefer signed.
309 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
310 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
311 x_dnd_atoms_size and x_dnd_atoms_length.
312
c2d1e36d
PE
313 * doprnt.c: Prefer signed to unsigned when either works.
314 * eval.c (verror):
315 * doprnt.c (doprnt):
316 * lisp.h (doprnt):
317 * xdisp.c (vmessage):
318 Use ptrdiff_t, not size_t, when using or implementing doprnt,
319 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
320 prefer signed arithmetic to avoid comparison confusion.
321 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
322 but is a bit tricky.
323
0e926e56
PE
324 Assume freestanding C89 headers, string.h, stdlib.h.
325 * data.c, doprnt.c, floatfns.c, print.c:
326 Include float.h unconditionally.
327 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
328 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
329 * regex.c: Likewise for stddef.h, string.h.
330 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
331 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
332 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
333 (STDC_HEADERS): Remove obsolete defines.
334 * sysdep.c: Include limits.h unconditionally.
335
9cfdb3ec
PE
336 Assume support for memcmp, memcpy, memmove, memset.
337 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
338 * regex.c (memcmp, memcpy):
339 Remove; we assume C89 now.
340
341 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
342 (__malloc_safe_bcopy): Remove; no longer needed.
343
cf950e6b 344 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
345 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
346 well either way, and we prefer signed to unsigned.
347
590bd467
PE
3482011-07-19 Paul Eggert <eggert@cs.ucla.edu>
349
350 Port to OpenBSD.
351 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
352 and the surrounding thread.
353 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
354 rather than fgets, and retry after EINTR. Otherwise, 'emacs
355 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
356 timer goes off.
357 * s/openbsd.h (BROKEN_SIGIO): Define.
358 * unexelf.c (unexec) [__OpenBSD__]:
359 Don't update the .mdebug section of the Alpha COFF symbol table.
360
f41628b2
LMI
3612011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
362
363 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
364 (bug#8460).
365
b59b67c5
PE
3662011-07-18 Paul Eggert <eggert@cs.ucla.edu>
367
15e3a074
PE
368 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
369 This fixes some race conditions on the permissions of any newly
370 created file.
371
41bed37d
PE
372 * alloc.c (valid_pointer_p): Use pipe, not open.
373 This fixes some permissions issues when debugging.
374
b59b67c5
PE
375 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
376 If fchown fails to set both uid and gid, try to set just gid,
377 as that is sometimes allowed. Adjust the file's mode to eliminate
378 setuid or setgid bits that are inappropriate if fchown fails.
379
925a6be7
SM
3802011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
383 to compare Lisp_Objects.
384 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
385 global_gnutls_log_level, don't mistake it for a Lisp_Object.
386 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
387
52968808
AS
3882011-07-17 Andreas Schwab <schwab@linux-m68k.org>
389
0a6a104b
AS
390 * lread.c (read_integer): Unread even EOF character.
391 (read1): Likewise. Properly record start position of symbol.
392
52968808
AS
393 * lread.c (read1): Read `#:' as empty uninterned symbol if no
394 symbol character follows.
395
9e381cdd
PE
3962011-07-17 Paul Eggert <eggert@cs.ucla.edu>
397
398 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
399 This works around a problem with the previous change to Fcopy_file.
400 Recent glibc declares fchown with __attribute__((warn_unused_result)),
401 and without this change, GCC might complain about discarding
402 fchown's return value.
403
b5641435
JB
4042011-07-16 Juanma Barranquero <lekktu@gmail.com>
405
406 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
407
a8031457
PE
4082011-07-16 Paul Eggert <eggert@cs.ucla.edu>
409
410 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
411
dd889327
LMI
4122011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
413
750c33f7
LMI
414 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
415 it's used from the C level.
416
dd889327
LMI
417 * process.c: Use the same condition for POLL_FOR_INPUT in both
418 keyboard.c and process.c (bug#1858).
419
87e86684
LM
4202011-07-09 Lawrence Mitchell <wence@gmx.li>
421
422 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
423 (Fgnutls_boot): Use it.
424
64348f40
AS
4252011-07-15 Andreas Schwab <schwab@linux-m68k.org>
426
427 * doc.c (Fsubstitute_command_keys): Revert last change.
428
1d698799
LMI
4292011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
430
f863868c
LMI
431 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
432 quotes the next character, and doesn't affect other longer
433 sequences (bug#8935).
434
1d698799
LMI
435 * lread.c (syms_of_lread): Clarify that is isn't only
436 `eval-buffer' and `eval-defun' that's affected by
437 `lexical-binding' (bug#8460).
438
aa4b6df6
EZ
4392011-07-15 Eli Zaretskii <eliz@gnu.org>
440
441 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
442 bidi redisplay when a line includes both an image and is
443 truncated.
444
5d856da6
PE
4452011-07-14 Paul Eggert <eggert@cs.ucla.edu>
446
ad6042bb
PE
447 Fix minor problems found by static checking.
448 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
449 (elsz): Now a signed constant, not a size_t var. We prefer signed
450 types to unsigned, to avoid integer comparison confusion. Without
451 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
452 "cannot optimize loop, the loop counter may overflow", a symptom
453 of the confusion.
f00bbb22 454 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
455 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
456
6468f31c
LMI
4572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
458
49080b10
LMI
459 * search.c (Fre_search_backward): Mention `case-fold-search' in
460 all the re_search_* functions (bug#8138).
461
6468f31c
LMI
462 * keyboard.c (Fopen_dribble_file): Document when the file is
463 closed (bug#8056).
464
c965adc5
EZ
4652011-07-14 Eli Zaretskii <eliz@gnu.org>
466
df9733bf
EZ
467 * bidi.c (bidi_dump_cached_states): Fix format of displaying
468 bidi_cache_idx.
469
0bb23927
EZ
470 Support bidi reordering of display and overlay strings.
471 * xdisp.c (compute_display_string_pos)
472 (compute_display_string_end): Accept additional argument STRING.
473 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
474 (reseat_to_string): Initialize bidi_it->string.s and
475 bidi_it->string.schars.
476 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
477 NULL (avoids a crash in bidi_paragraph_init). Initialize
478 itb.string.lstring.
479 (init_iterator): Call bidi_init_it only of a valid
480 buffer position was specified. Initialize paragraph_embedding to
481 L2R.
482 (reseat_to_string): Initialize the bidi iterator.
483 (display_string): If we need to ignore text properties of
484 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
485 original value of -1 will not work with bidi.)
486 (compute_display_string_pos): First arg is now struct
487 `text_pos *'; all callers changed. Support display properties on
488 Lisp strings.
489 (compute_display_string_end): Support display properties on Lisp
490 strings.
491 (init_iterator, reseat_1, reseat_to_string): Initialize the
492 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
493 when iterating on a string not from display properties).
494 (compute_display_string_pos, compute_display_string_end): Fix
495 calculation of the object to scan. Fixes an error when using
496 arrow keys.
497 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
498 base_level_stop; instead, set base_level_stop to BEGV. Fixes
499 crashes in vertical-motion.
500 (next_element_from_buffer): Improve commentary for when
501 the iterator is before prev_stop.
502 (init_iterator): Initialize bidi_p from the default value of
503 bidi-display-reordering, not from buffer-local value. Use the
504 buffer-local value only if initializing for buffer iteration.
505 (handle_invisible_prop): Support invisible properties on strings
506 that are being bidi-reordered.
507 (set_iterator_to_next): Support bidi reordering of C strings and
508 Lisp strings.
509 (next_element_from_string): Support bidi reordering of Lisp
510 strings.
511 (handle_stop_backwards): Support Lisp strings as well.
512 (display_string): Support display of R2L glyph rows. Use
513 IT_STRING_CHARPOS when displaying from a Lisp string.
514 (init_iterator): Don't initialize it->bidi_p for strings
515 here.
516 (reseat_to_string): Initialize it->bidi_p for strings here.
517 (next_element_from_string, next_element_from_c_string)
518 (next_element_from_buffer): Add xassert's for correspondence
519 between IT's object being iterated and it->bidi_it.string
520 structure.
521 (face_before_or_after_it_pos): Support bidi iteration.
522 (next_element_from_c_string): Handle the case of the first string
523 character that is not the first one in the visual order.
524 (get_visually_first_element): New function, refactored from common
525 parts of next_element_from_buffer, next_element_from_string, and
526 next_element_from_c_string.
527 (tool_bar_lines_needed, redisplay_tool_bar)
528 (display_menu_bar): Force left-to-right direction. Add a FIXME
529 comment for making that be controlled by a user option.
530 (push_it, pop_it): Save and restore the state of the
531 bidi iterator. Save and restore the bidi_p flag.
532 (pop_it): Iterate out of display property for string iteration as
533 well.
534 (iterate_out_of_display_property): Support iteration over strings.
535 (handle_single_display_spec): Set up it->bidi_it for iteration
536 over a display string, and call bidi_init_it.
537 (handle_single_display_spec, next_overlay_string)
538 (get_overlay_strings_1, push_display_prop): Set up the bidi
539 iterator for displaying display or overlay strings.
540 (forward_to_next_line_start): Don't use the shortcut if
541 bidi-iterating.
542 (back_to_previous_visible_line_start): If handle_display_prop
543 pushed the iterator stack, restore the internal state of the bidi
544 iterator by calling bidi_pop_it same number of times.
545 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
546 and we are bidi-iterating, don't decrement the iterator position;
547 instead, set the first_elt flag in the bidi iterator, to produce
548 the same effect.
549 (reseat_1): Remove redundant setting of string_from_display_prop_p.
550 (push_display_prop): xassert that we are iterating a buffer.
551 (push_it, pop_it): Save and restore paragraph_embedding member.
552 (handle_single_display_spec, next_overlay_string)
553 (get_overlay_strings_1, reseat_1, reseat_to_string)
554 (push_display_prop): Set up the `unibyte' member of bidi_it.string
555 correctly. Don't assume unibyte strings are not bidi-reordered.
556 (compute_display_string_pos)
557 (compute_display_string_end): Fix handling the case of C string.
558 (push_it, pop_it): Save and restore from_disp_prop_p.
559 (handle_single_display_spec, push_display_prop): Set the
560 from_disp_prop_p flag.
561 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
562 (pop_it): Call iterate_out_of_display_property only if we are
563 popping after iteration over a string that came from a display
564 property. Fix a typo in popping stretch info. Add an assertion
565 for verifying that the iterator position is in sync with the bidi
566 iterator.
567 (handle_single_display_spec, get_overlay_strings_1)
568 (push_display_prop): Fix initialization of paragraph direction for
569 string when that of the parent object is not yet determined.
570 (reseat_1): Call bidi_init_it to resync the bidi
571 iterator with IT's position. (Bug#7616)
572 (find_row_edges): If ROW->start.pos gives position
573 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
574 (handle_stop, back_to_previous_visible_line_start, reseat_1):
575 Reset the from_disp_prop_p flag.
576 (SAVE_IT, RESTORE_IT): New macros.
577 (pos_visible_p, face_before_or_after_it_pos)
578 (back_to_previous_visible_line_start)
579 (move_it_in_display_line_to, move_it_in_display_line)
580 (move_it_to, move_it_vertically_backward, move_it_by_lines)
581 (try_scrolling, redisplay_window, display_line): Use them when
582 saving a temporary copy of the iterator and restoring it back.
583 (back_to_previous_visible_line_start, reseat_1)
584 (init_iterator): Empty the bidi cache "stack".
585 (move_it_in_display_line_to): If iterator ended up at
586 EOL, but we never saw any buffer positions smaller than
587 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
588 motion in bidi-reordered lines.
589 (move_it_in_display_line_to): Record prev_method and prev_pos
590 immediately before the call to set_iterator_to_next. Fixes cursor
591 motion in bidi-reordered lines with stretch glyphs and strings
592 displayed in margins. (Bug#8133) (Bug#8867)
593 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
594 TO_CHARPOS.
595 (pos_visible_p): Support positions in bidi-reordered lines. Save
596 and restore bidi cache.
597
598 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
599 (bidi_paragraph_info): Delete unused struct.
600 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
601 (bidi_cache_start): New variable.
602 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
603 to zero.
604 (bidi_cache_fetch_state, bidi_cache_search)
605 (bidi_cache_find_level_change, bidi_cache_iterator_state)
606 (bidi_cache_find, bidi_peek_at_next_level)
607 (bidi_level_of_next_char, bidi_find_other_level_edge)
608 (bidi_move_to_visually_next): Compare cache index with
609 bidi_cache_start rather than with zero.
610 (bidi_fetch_char): Accept new argument STRING; all callers
611 changed. Support iteration over a string. Support strings with
612 display properties. Support unibyte strings. Fix the type of
613 `len' according to what STRING_CHAR_AND_LENGTH expects.
614 (bidi_paragraph_init, bidi_resolve_explicit_1)
615 (bidi_resolve_explicit, bidi_resolve_weak)
616 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
617 iteration over a string.
618 (bidi_set_sor_type, bidi_resolve_explicit_1)
619 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
620 can now be zero (for strings); special values 0 and -1 were
621 changed to -1 and -2, respectively.
622 (bidi_char_at_pos): New function.
623 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
624 Call it instead of FETCH_MULTIBYTE_CHAR.
625 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
626 initialized to valid values.
627 (bidi_init_it): Don't initialize charpos and bytepos with invalid
628 values.
629 (bidi_level_of_next_char): Allow the sentinel "position" to pass
630 the test for valid cached positions. Fix the logic for looking up
631 the sentinel state in the cache. GCPRO the Lisp string we are
632 iterating.
633 (bidi_push_it, bidi_pop_it): New functions.
634 (bidi_initialize): Initialize the bidi cache start stack pointer.
635 (bidi_cache_ensure_space): New function, refactored from part of
636 bidi_cache_iterator_state. Don't assume the required size is just
637 one BIDI_CACHE_CHUNK away.
638 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
639 (bidi_count_bytes, bidi_char_at_pos): New functions.
640 (bidi_cache_search): Don't assume bidi_cache_last_idx is
641 always valid if bidi_cache_idx is valid.
642 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
643 is valid if it's going to be used.
644 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
645 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
646 (bidi_cache_find_level_change, bidi_cache_ensure_space)
647 (bidi_cache_iterator_state, bidi_cache_find)
648 (bidi_find_other_level_edge, bidi_cache_start_stack): All
649 variables related to cache indices are now EMACS_INT.
650
0bb23927
EZ
651 * dispextern.h (struct bidi_string_data): New structure.
652 (struct bidi_it): New member `string'. Make flag members be 1-bit
653 fields, and put them last in the struct.
654 (compute_display_string_pos, compute_display_string_end): Update
655 prototypes.
656 (bidi_push_it, bidi_pop_it): Add prototypes.
657 (struct iterator_stack_entry): New members bidi_p,
658 paragraph_embedding, and from_disp_prop_p.
659 (struct it): Member bidi_p is now a bit field 1 bit wide.
660 (bidi_shelve_cache, bidi_unshelve_cache): Declare
661 prototypes.
662
663 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
664 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
665 and vector-like objects.
666
667 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
668 cache around display iteration.
669
670 * window.c (Fwindow_end, window_scroll_pixel_based)
671 (displayed_window_lines, Frecenter): Save and restore the bidi
672 cache around display iteration.
673
3bbd2265
LMI
6742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
675
676 * editfns.c (Fdelete_region): Clarify the use of the named
677 parameters (bug#6788).
678
adc47434
MR
6792011-07-14 Martin Rudalics <rudalics@gmx.at>
680
681 * indent.c (Fvertical_motion): Set and restore w->pointm when
682 saving and restoring the window's buffer (Bug#9006).
683
837c31f8
LMI
6842011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
685
686 * editfns.c (Fstring_to_char): Clarify just what is returned
687 (bug#6576). Text by Eli Zaretskii.
688
ac389d0c
JB
6892011-07-13 Juanma Barranquero <lekktu@gmail.com>
690
691 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
692
0be0ce47
EZ
6932011-07-13 Eli Zaretskii <eliz@gnu.org>
694
695 * buffer.c (mmap_find): Fix a typo.
696
cd18e7e3
JB
6972011-07-13 Johan Bockgård <bojohan@gnu.org>
698
699 Fix execution of x selection hooks.
700 * xselect.c (Qx_lost_selection_functions)
701 (Qx_sent_selection_functions): New vars.
702 (syms_of_xselect): DEFSYM them.
703 (x_handle_selection_request): Pass Qx_sent_selection_functions
704 rather than Vx_sent_selection_functions to Frun_hook_with_args.
705 (x_handle_selection_clear,x_clear_frame_selections):
706 Pass Qx_lost_selection_functions rather than
707 Vx_lost_selection_functions to Frun_hook_with_args.
708
47ea7f44
PE
7092011-07-13 Paul Eggert <eggert@cs.ucla.edu>
710
ac389d0c 711 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
712 The old code sometimes used this field without initializing it.
713
47ea7f44
PE
714 * alloc.c (gc_sweep): Don't read past end of array.
715 In theory, the old code could also have corrupted Emacs internals,
716 though it'd be very unlikely.
717
bc985c87
AS
7182011-07-12 Andreas Schwab <schwab@linux-m68k.org>
719
720 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 721 argument. (Bug#4026)
bc985c87 722
0cf34688
LMI
7232011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
724
b3dadd76
LMI
725 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
726 key" (bug#4257).
727
0cf34688
LMI
728 * window.c (Fset_window_start): Doc fix (bug#4199).
729 (Fset_window_hscroll): Ditto.
730
270768cd
PE
7312011-07-12 Paul Eggert <eggert@cs.ucla.edu>
732
077e3dda 733 Fix minor new problems caught by GCC 4.6.1.
270768cd 734 * term.c (init_tty): Remove unused local.
490011a6 735 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 736 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 737 not used otherwise.
270768cd 738
b1f58454
CY
7392011-07-12 Chong Yidong <cyd@stupidchicken.com>
740
741 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
742
22b9578d
LMI
7432011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
744
6e70ab07
LMI
745 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
746 are the mini-buffer and the echo area (bug#3320).
747
22b9578d
LMI
748 * term.c (init_tty): Remove support for supdup, c10 and perq
749 terminals, which are no longer supported (bug#1482).
750
8974cc9f
JB
7512011-07-10 Johan Bockgård <bojohan@gnu.org>
752
753 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
754
a560d974
JD
7552011-07-10 Jan Djärv <jan.h.d@swipnet.se>
756
757 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
758 for non-popups (Bug#3642).
759
1dae0f0a
AS
7602011-07-10 Andreas Schwab <schwab@linux-m68k.org>
761
268c2c36 762 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 763 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
764 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
765 * cm.c (losecursor): Likewise.
1dae0f0a
AS
766 * data.c (fmod): Likewise.
767 * dispnew.c (swap_glyphs_in_rows): Likewise.
768 * emacs.c (memory_warning_signal): Likewise.
769 * floatfns.c (float_error): Likewise.
770 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
771 (otf_open, font_otf_capability, generate_otf_features)
772 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
773 Likewise.
774 * image.c (pbm_read_file): Likewise.
775 * indent.c (string_display_width): Likewise.
776 * intervals.c (check_for_interval, search_for_interval)
777 (inc_interval_count, count_intervals, root_interval)
778 (adjust_intervals_for_insertion, make_new_interval): Likewise.
779 * lread.c (defalias): Likewise.
268c2c36 780 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
781 * regex.c (set_image_of_range_1, set_image_of_range)
782 (regex_grow_registers): Likewise.
783 * sysdep.c (strerror): Likewise.
784 * termcap.c (valid_filename_p, tprint, main): Likewise.
785 * tparam.c (main): Likewise.
786 * unexhp9k800.c (run_time_remap, save_data_space)
787 (update_file_ptrs, read_header, write_header, calculate_checksum)
788 (copy_file, copy_rest, display_header): Likewise.
789 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
790 Likewise.
791 * xdisp.c (check_it): Likewise.
792 * xfaces.c (register_color, unregister_color, unregister_colors):
793 Likewise.
794 * xfns.c (print_fontset_result): Likewise.
795 * xrdb.c (member, fatal, main): Likewise.
796
99033785
PE
7972011-07-10 Paul Eggert <eggert@cs.ucla.edu>
798
799 Fix minor problems found by static checking (Bug#9031).
800 * chartab.c (char_table_set_range, map_sub_char_table):
801 Remove unused locals.
802 (uniprop_table): Now static.
803 * composite.c (_work_char): Remove unused static var.
804
9cb2ac56
JB
8052011-07-09 Juanma Barranquero <lekktu@gmail.com>
806
807 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
808
f25661f0
JD
8092011-07-09 Jan Djärv <jan.h.d@swipnet.se>
810
811 * gtkutil.c (qttip_cb): Remove code without function.
812
8278c4fe
EZ
8132011-07-09 Eli Zaretskii <eliz@gnu.org>
814
815 * w32.c (pthread_sigmask): New stub.
816
1692ae2d 8172011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 818
8a6ebd58 819 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
820 sigprocmask is portable only for single-threaded applications, and
821 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
822 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
823 (LIBES): Use it.
824 * callproc.c (Fcall_process):
825 * process.c (create_process):
826 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
827 Use pthread_sigmask, not sigprocmask.
123403e4 828
1b854618
JD
8292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
830
831 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
832 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
833 wrong (Bug#8591).
834
3fe4b549
JD
8352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
836
0ce7e563
JD
837 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
838 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
839 (xg_hide_tooltip): Fix comment.
840
3fe4b549
JD
841 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
842 in registerServicesMenuSendTypes.
843 (validRequestorForSendType): Don't check ns_return_types.
844
845 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
846 ns_return_type.
847
5df75e47
JR
8482011-07-08 Jason Rumney <jasonr@gnu.org>
849
850 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
851 frame struct members of non-existent frames (Bug#6284).
852
699c10bd
JD
8532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
854
4393663b
JD
855 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
856 variable firstTime not needed on OSX >= 10.6.
857 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
858 >= 10.5. Use setKnobProportion, setDoubleValue.
859
860 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
861 (MAC_OS_X_VERSION_10_5): Define if not defined.
862 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
863 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
864 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
865
866 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
867 cString and lossyCString on OSX >= 10.4
868
869 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
870 sizeToFit on OSX >= 10.2.
871
872 * nsimage.m (allocInitFromFile): Don't use deprecated method
873 bestRepresentationForDevice on OSX >= 10.6.
874
875 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
876 to avoid warning.
877
878 * emacs.c: Declare unexec_init_emacs_zone.
879
a63e0781
JD
880 * nsgui.h: Fix compiler warning about gnulib redefining verify.
881
699c10bd
JD
882 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
883
884 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
885 on svcsMenu (Bug#8842).
886
887 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
888 ns_return_types.
889 (Fns_list_services): Just return Qnil on 10.6, code not working there.
890
891 * nsterm.m (QUTF8_STRING): Declare.
892 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
893 (validRequestorForSendType): Return type is (id).
894 Change indexOfObjectIdenticalTo to indexOfObject.
895 Check if we have local selection before returning self (Bug#8842).
896 (writeSelectionToPasteboard): Put local selection into paste board
897 if we have a local selection (Bug#8842).
898 (syms_of_nsterm): DEFSYM QUTF8_STRING.
899
900 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
901 (ns_get_local_selection): Declare.
902
54e10184
LMI
9032011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
904
9888ff71
LMI
905 * keymap.c (describe_map_tree): Don't insert a double newline at
906 the end of the buffer (bug#1169) and return whether we inserted
907 something.
908
54e10184
LMI
909 * callint.c (Fcall_interactively): Change "reading args" to
910 "providing args" to try to clarify what it does (bug#1010).
911
15fa4783
KH
9122011-07-07 Kenichi Handa <handa@m17n.org>
913
914 * composite.c (composition_compute_stop_pos): Ignore a static
915 composition starting before CHARPOS (Bug#8915).
916
917 * xdisp.c (handle_composition_prop): Likewise.
918
a8815b00
EZ
9192011-07-07 Eli Zaretskii <eliz@gnu.org>
920
921 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
922 (Bug#9015)
923
ef7b981d 9242011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
925
926 * character.h (unicode_category_t): New enum type.
927
928 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
929 (Qchar_code_property_table): New variable.
930 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
931 (UNIPROP_COMPRESSED_FORM_P): New macros.
932 (char_table_ascii): Uncompress the compressed values.
933 (sub_char_table_ref): New arg is_uniprop. Callers changed.
934 Uncompress the compressed values.
ac389d0c 935 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
936 (char_table_ref_and_range): Uncompress the compressed values.
937 (sub_char_table_set): New arg is_uniprop. Callers changed.
938 Uncompress the compressed values.
939 (sub_char_table_set_range): Args changed. Callers changed.
940 (char_table_set_range): Adjuted for the above change.
941 (map_sub_char_table): Delete args default_val and parent. Add arg
942 top. Give decoded values to a Lisp function.
943 (map_char_table): Adjusted for the above change. Give decoded
944 values to a Lisp function. Gcpro more variables.
945 (uniprop_table_uncompress)
946 (uniprop_decode_value_run_length): New functions.
947 (uniprop_decoder, uniprop_decoder_count): New variables.
948 (uniprop_get_decoder, uniprop_encode_value_character)
949 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
950 New functions.
951 (uniprop_encoder, uniprop_encoder_count): New variables.
952 (uniprop_get_encoder, uniprop_table)
953 (Funicode_property_table_internal, Fget_unicode_property_internal)
954 (Fput_unicode_property_internal): New functions.
955 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
956 Sunicode_property_table_internal, Sget_unicode_property_internal,
957 and Sput_unicode_property_internal. Defvar_lisp
958 char-code-property-alist.
959
960 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
961 Vunicode_category_table.
962
963 * font.c (font_range): Adjusted for the change of
964 Vunicode_category_table.
965
76b397fb
DN
9662011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
967
968 * m/iris4d.h: Remove file, move contents ...
969 * s/irix6-5.h: ... here.
970
22b4128e
PE
9712011-07-06 Paul Eggert <eggert@cs.ucla.edu>
972
973 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
974 * alloc.c (mark_buffer):
975 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
976 (clone_per_buffer_values): Don't assume that
22b4128e
PE
977 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
978 This isn't true in general, and it's particularly not true
979 if Emacs is configured with --with-wide-int.
980 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
981 New macros, used in the buffer.c change.
982
869795d6
JD
9832011-07-05 Jan Djärv <jan.h.d@swipnet.se>
984
985 * xsettings.c: Use both GConf and GSettings if both are available.
986 (store_config_changed_event): Add comment.
987 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
988 (store_tool_bar_style_changed): New functions.
989 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
990 (struct xsettings): Move font inside HAVE_XFT.
991 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
992 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
993 Move inside HAVE_XFT.
994 (something_changed_gsettingsCB): Renamed from something_changedCB.
995 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
996 also.
997 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
998 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
999 (something_changed_gconfCB): Renamed from something_changedCB.
1000 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1001 (parse_settings): Move check for font inside HAVE_XFT.
1002 (read_settings, apply_xft_settings): Add comment.
1003 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1004 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1005 call store_font_name_changed.
1006 (xft_settings_event): Add comment.
1007 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1008 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1009 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1010 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1011 (xsettings_initialize): Call init_gsettings last.
1012 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1013 comment.
1014
d8ed26bd
PE
10152011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 Random fixes. E.g., (random) never returned negative values.
1018 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1019 subseconds part to the entropy, as that's a bit more random.
1020 Prefer signed to unsigned, since the signedness doesn't matter and
1021 in general we prefer signed. When given a limit, use a
1022 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1023 latter isn't right if USE_2_TAGS_FOR_INTS.
1024 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1025 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1026
cabf1cac
SM
10272011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1028
1029 * textprop.c (text_property_stickiness):
1030 Obey Vtext_property_default_nonsticky.
1031 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1032 * w32fns.c (syms_of_w32fns):
1033 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1034
6e9b2be9
PE
10352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1038 This is more efficient than Ffile_directory_p and avoids a minor race.
1039
90186c68
LMI
10402011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1041
7c301272
LMI
1042 * buffer.c (Foverlay_put): Say what the return value is
1043 (bug#7835).
1044
c4f2d8d4
LMI
1045 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1046 is a directory before asking whether to use the file name
1047 (bug#7564).
ad637907
LMI
1048 (barf_or_query_if_file_exists): Make the "File is a directory"
1049 error be more correct.
c4f2d8d4 1050
90186c68
LMI
1051 * fns.c (Frequire): Remove the mention of the .gz files, since
1052 that's installation-specific, but keep the mention of
1053 `get-load-suffixes'.
1054
da64016e
PE
10552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1056
1057 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1058 Report string overflow if the output is too long.
1059
7d47b580
JB
10602011-07-04 Juanma Barranquero <lekktu@gmail.com>
1061
a555cb87
JB
1062 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1063 (syms_of_gnutls): Remove duplicate DEFSYM for
1064 Qgnutls_bootprop_verify_hostname_error, an error for
1065 Qgnutls_bootprop_verify_error (which is no longer used).
1066
7d47b580
JB
1067 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1068 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1069 Also (re)move comments that are misplaced or no longer relevant.
1070
1e49bfab
LMI
10712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1072
1073 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1074
1485f4c0
CY
10752011-07-03 Chong Yidong <cyd@stupidchicken.com>
1076
1077 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1078 and background color parameters if they have been changed.
1079
a9ab721e
LMI
10802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1081
1082 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1083
cf7cff57
PE
10842011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1085
2e13213d
PE
1086 * xsettings.c (SYSTEM_FONT): Define only when used.
1087 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1088
cf7cff57
PE
1089 * keymap.c (access_keymap_1): Now static.
1090
7a8e04f7
CY
10912011-07-02 Chong Yidong <cyd@stupidchicken.com>
1092
1093 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1094 leave any prefix arg for the up event (Bug#1586).
1095
61352f62
LMI
10962011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1097
69bb1ef7
LMI
1098 * lread.c (syms_of_lread): Mention single symbols defined by
1099 `defvar' or `defconst' (bug#7154).
1100
61352f62 1101 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1102 (Frequire): Mention get-load-suffixes.
61352f62 1103
28545e04
MR
11042011-07-02 Martin Rudalics <rudalics@gmx.at>
1105
1106 * window.h (window): Remove clone_number slot.
1107 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1108 Remove.
1109 (make_parent_window, make_window, saved_window)
1110 (Fset_window_configuration, save_window_save): Don't deal with
1111 clone numbers.
1112 * buffer.c (Qclone_number): Remove declaration.
1113 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1114
3349e122
SM
11152011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 Add multiple inheritance to keymaps.
1118 * keymap.c (Fmake_composed_keymap): New function.
1119 (Fset_keymap_parent): Simplify.
1120 (fix_submap_inheritance): Remove.
1121 (access_keymap_1): New function extracted from access_keymap to handle
1122 embedded parents and handle lists of maps.
1123 (access_keymap): Use it.
1124 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1125 (Fcopy_keymap): Handle embedded parents.
1126 (Fcommand_remapping, define_as_prefix): Simplify.
1127 (Fkey_binding): Simplify.
1128 (syms_of_keymap): Move minibuffer-local-completion-map,
1129 minibuffer-local-filename-completion-map,
1130 minibuffer-local-must-match-map, and
1131 minibuffer-local-filename-must-match-map to Elisp.
1132 (syms_of_keymap): Defsubr make-composed-keymap.
1133 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1134 (parse_menu_item): Trivial simplification.
1135
3279eb87
GM
11362011-07-01 Glenn Morris <rgm@gnu.org>
1137
1138 * Makefile.in (SETTINGS_LIBS): Fix typo.
1139
4550efdf
KI
11402011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1141
1142 * coding.c (Fencode_coding_string): Record the last coding system
1143 used, as the function doc string says (bug#8738).
1144
0949d2b6
JD
11452011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1146
1147 * xsettings.c (store_monospaced_changed): Take new font as arg and
1148 check for change against current_mono_font.
1149 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1150 (emacs_settings_constructor, emacs_settings_get_property)
1151 (emacs_settings_set_property, emacs_settings_class_init)
1152 (emacs_settings_init, gsettings_obj): Remove.
1153 (something_changedCB): New function for HAVE_GSETTINGS.
1154 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1155 with value as argument.
1156 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1157 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1158 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1159 "changed".
1160
1161 * xgselect.c: Add defined (HAVE_GSETTINGS).
1162 (xgselect_initialize): Ditto.
1163
1164 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1165 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1166 xg_select.
1167
bbc6b304
PE
11682011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * eval.c (struct backtrace): Simplify and port the data structure.
1171 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1172 signed bit field, as this assumption is not portable and it makes
1173 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1174 "char debug_on_exit : 1" as this is not portable either; instead,
1175 use the portable "unsigned int debug_on_exit : 1". Remove unused
1176 member evalargs. Remove obsolete comments about cc bombing out.
1177
9851bfc5
JD
11782011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1179
51bb811f 1180 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1181 Let HAVE_GSETTINGS override HAVE_GCONF.
1182 (store_monospaced_changed): New function.
1183 (EMACS_SETTINGS): A new type derived from GObject to handle
1184 GSettings notifications.
1185 (emacs_settings_constructor, emacs_settings_get_property)
1186 (emacs_settings_set_property, emacs_settings_class_init):
1187 New functions.
1188 (gsettings_client, gsettings_obj): New variables.
1189 (GSETTINGS_SCHEMA): New define.
1190 (something_changedCB): Call store_monospaced_changed.
1191 (init_gsettings): New function.
1192 (xsettings_initialize): Call init_gsettings.
1193 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1194 to NULL.
1195
1196 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1197 GCONF_CFLAGS/LIBS.
1198
5386012d
MR
11992011-06-29 Martin Rudalics <rudalics@gmx.at>
1200
1201 * window.c (resize_root_window, grow_mini_window)
1202 (shrink_mini_window): Rename Qresize_root_window to
1203 Qwindow_resize_root_window and Qresize_root_window_vertically to
1204 Qwindow_resize_root_window_vertically.
1205
f13e0b08
PE
12062011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1209
94515237
JB
12102011-06-27 Juanma Barranquero <lekktu@gmail.com>
1211
1212 * makefile.w32-in: Redesign dependencies so they reflect more
1213 clearly which files are directly included by each source file,
1214 and not through other includes.
1215
e43b6e43
MR
12162011-06-27 Martin Rudalics <rudalics@gmx.at>
1217
1218 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1219 (sort_overlays, overlay_strings): When an overlay's clone number
1220 matches the window's clone number process the overlay even if
1221 the overlay's window property doesn't match the current window.
1222
d68443dc
MR
1223 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1224 (Fwindow_hchild): Rename to Fwindow_left_child.
1225 (Fwindow_next): Rename to Fwindow_next_sibling.
1226 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1227 (resize_window_check): Rename to window_resize_check.
1228 (resize_window_apply): Rename to window_resize_apply.
1229 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1230 (Fdelete_other_windows_internal, resize_frame_windows)
1231 (Fsplit_window_internal, Fdelete_window_internal)
1232 (grow_mini_window, shrink_mini_window)
1233 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1234
c7e73be5
JD
12352011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1236
1237 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1238 (emacs_fixed_set_min_size): Remove.
1239 (emacs_fixed_new): Take frame as argument.
1240
1241 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1242 (_EmacsFixedPrivate): Remove minwidth/height.
1243 Add struct frame *f.
1244 (emacs_fixed_init): Initialize priv->f.
1245 (get_parent_class, emacs_fixed_set_min_size): Remove.
1246 (emacs_fixed_new): Set priv->f to argument.
1247 (emacs_fixed_get_preferred_width)
1248 (emacs_fixed_get_preferred_height): Use min_width/height from
1249 frames size_hint to set minimum and natural (Bug#8919).
1250 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1251 and use min_width/height from frames size_hint to set
1252 min_width/height (Bug#8919).
1253
1254 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1255 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1256 Fix indentation.
c7e73be5 1257
cf99dcf8
EZ
12582011-06-26 Eli Zaretskii <eliz@gnu.org>
1259
1260 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1261 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1262 called at ZV.
1263
029529ac
CY
12642011-06-26 Chong Yidong <cyd@stupidchicken.com>
1265
1266 * process.c (wait_reading_process_output): Bypass select if
1267 waiting for a cell while ignoring keyboard input, and input is
1268 pending. Suggested by Jan Djärv (Bug#8869).
1269
7a7ef429
PE
12702011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 Use gnulib's dup2 module instead of rolling our own.
1273 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1274
11fdef7d 12752011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1276
1277 * dispnew.c (scrolling_window): Before scrolling, turn off a
1278 mouse-highlight in the window being scrolled.
1279
cd3520a4
JB
12802011-06-24 Juanma Barranquero <lekktu@gmail.com>
1281
1282 Move DEFSYM to lisp.h and use everywhere.
1283
1284 * character.h (DEFSYM): Move declaration...
1285 * lisp.h (DEFSYM): ...here.
1286
1287 * gnutls.c:
1288 * minibuf.c:
1289 * w32menu.c:
1290 * w32proc.c:
1291 * w32select.c: Don't include character.h.
1292
1293 * alloc.c (syms_of_alloc):
1294 * buffer.c (syms_of_buffer):
1295 * bytecode.c (syms_of_bytecode):
1296 * callint.c (syms_of_callint):
1297 * casefiddle.c (syms_of_casefiddle):
1298 * casetab.c (init_casetab_once):
1299 * category.c (init_category_once, syms_of_category):
1300 * ccl.c (syms_of_ccl):
1301 * cmds.c (syms_of_cmds):
1302 * composite.c (syms_of_composite):
1303 * dbusbind.c (syms_of_dbusbind):
1304 * dired.c (syms_of_dired):
1305 * dispnew.c (syms_of_display):
1306 * doc.c (syms_of_doc):
1307 * editfns.c (syms_of_editfns):
1308 * emacs.c (syms_of_emacs):
1309 * eval.c (syms_of_eval):
1310 * fileio.c (syms_of_fileio):
1311 * fns.c (syms_of_fns):
1312 * frame.c (syms_of_frame):
1313 * fringe.c (syms_of_fringe):
1314 * insdel.c (syms_of_insdel):
1315 * keymap.c (syms_of_keymap):
1316 * lread.c (init_obarray, syms_of_lread):
1317 * macros.c (syms_of_macros):
1318 * msdos.c (syms_of_msdos):
1319 * print.c (syms_of_print):
1320 * process.c (syms_of_process):
1321 * search.c (syms_of_search):
1322 * sound.c (syms_of_sound):
1323 * syntax.c (init_syntax_once, syms_of_syntax):
1324 * terminal.c (syms_of_terminal):
1325 * textprop.c (syms_of_textprop):
1326 * undo.c (syms_of_undo):
1327 * w32.c (globals_of_w32):
1328 * window.c (syms_of_window):
1329 * xdisp.c (syms_of_xdisp):
1330 * xfaces.c (syms_of_xfaces):
1331 * xfns.c (syms_of_xfns):
1332 * xmenu.c (syms_of_xmenu):
1333 * xsettings.c (syms_of_xsettings):
1334 * xterm.c (syms_of_xterm): Use DEFSYM.
1335
4228cf16
TZ
13362011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1337
cd3520a4 1338 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1339
7fcccf1e
PE
13402011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1341
7efb4e0e
PE
1342 Integer and buffer overflow fixes (Bug#8873).
1343
ff5844ad
PE
1344 * print.c (printchar, strout): Check for string overflow.
1345 (PRINTPREPARE, printchar, strout):
1346 Don't set size unless allocation succeeds.
1347
90532f02
PE
1348 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1349 for sizes. Check for string overflow more accurately.
1350 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1351
6d84508d
PE
1352 * macros.c: Integer and buffer overflow fixes.
1353 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1354 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1355 Use ptrdiff_t, not int, for sizes.
1356 Don't increment bufsize until after realloc succeeds.
1357 Check for size-calculation overflow.
1358 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1359
437b2cb4
PE
1360 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1361
8b9ac8b4
PE
1362 * lread.c: Integer overflow fixes.
1363 (read_integer): Radix is now EMACS_INT, not int,
1364 to improve quality of diagnostics for out-of-range radices.
1365 Calculate buffer size correctly for out-of-range radices.
1366 (read1): Check for integer overflow in radices, and in
1367 read-circle numbers.
82cb60d3
PE
1368 (read_escape): Avoid int overflow.
1369 (Fload, openp, read_buffer_size, read1)
1370 (substitute_object_recurse, read_vector, read_list, map_obarray):
1371 Use ptrdiff_t, not int, for sizes.
1372 (read1): Use EMACS_INT, not int, for sizes.
20270765 1373 Check for size overflow.
8b9ac8b4 1374
7fcccf1e
PE
1375 * image.c (cache_image): Check for size arithmetic overflow.
1376
bfbbd7e7
PE
1377 * lread.c: Integer overflow issues.
1378 (saved_doc_string_size, saved_doc_string_length)
1379 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1380 Now ptrdiff_t, not int.
1381 (read1): Don't assume doc string length fits in int. Check for
1382 out-of-range doc string lengths.
1383 (read_list): Don't assume file position fits in int.
39019e54 1384 (read_escape): Check for hex character overflow.
bfbbd7e7 1385
4e323265
LL
13862011-06-22 Leo Liu <sdl.web@gmail.com>
1387
1388 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1389 Move to minibuffer.el.
1390
85fece3e
PE
13912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1392
20b84ce9 1393 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1394 The following patches are for when GLYPH_DEBUG && !XASSERT.
1395 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1396 * dispnew.c (flush_stdout):
1397 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1398 Mark as externally visible.
1399 * dispnew.c (check_window_matrix_pointers): Now static.
1400 * dispnew.c (window_to_frame_vpos):
1401 * xfns.c (unwind_create_frame):
1402 * xterm.c (x_check_font): Remove unused local.
1403 * scroll.c (CHECK_BOUNDS):
1404 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1405 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1406 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1407 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1408 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1409 Now static.
1410 (debug_method_add): Use va_list and vsprintf rather than relying
1411 on undefined behavior with wrong number of arguments.
1412 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1413 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1414 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1415 since we're not interested in debugging glyphs with old libraries.
1416 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1417 GCC 4.6.0's static checking.
1418
0766b489
PE
14192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1420
31fd4b32
PE
1421 Integer overflow and signedness fixes (Bug#8873).
1422 A few related buffer overrun fixes, too.
1423
b79e8648
PE
1424 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1425
0766b489
PE
1426 * dispextern.h (struct face.stipple):
1427 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1428 (x_bitmap_mask, x_allocate_bitmap_record)
1429 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1430 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1431 (x_create_bitmap_from_xpm_data):
1432 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1433 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1434 (.bitmaps_last):
1435 * xfaces.c (load_pixmap):
1436 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1437 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1438 (.bitmaps_last, struct x_output.icon_bitmap):
1439 Use ptrdiff_t, not int, for bitmap indexes.
1440 (x_allocate_bitmap_record): Check for size overflow.
1441 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1442
b081724f
PE
1443 Use ptrdiff_t, not int, for overlay counts.
1444 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1445 * editfns.c (overlays_around, get_pos_property):
1446 * textprop.c (get_char_property_and_overlay):
1447 * xdisp.c (next_overlay_change, note_mouse_highlight):
1448 * xfaces.c (face_at_buffer_position):
21514da7
PE
1449 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1450 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1451 (Fnext_overlay_change, Fprevious_overlay_change)
1452 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1453 Use ptrdiff_t, not int, for sizes.
21514da7 1454 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1455
3de73e5e
PE
1456 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1457
2606c57b
PE
1458 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1459 (x_session_initialize): Do not assume string length fits in int.
1460
aaafe47a
PE
1461 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1462 This is unlikely, but can occur if DPI is outlandish.
1463
2674ddc8 1464 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1465 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1466
28154962
PE
1467 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1468 * xrdb.c (magic_file_p, search_magic_path):
1469 Omit last arg SUFFIX; it was always 0. All callers changed.
1470 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1471
7de51af5
PE
1472 * xfont.c (xfont_match): Avoid need for strlen.
1473
25ed6cc3
PE
1474 * xfns.c: Don't assume strlen fits in int.
1475 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1476
4eab31dd
PE
1477 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1478 not unsigned long, as we prefer signed integers. All callers changed.
1479 Detect integer overflow in repeat count.
1480 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1481 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1482
171e2a58
PE
1483 * termcap.c: Don't assume sizes fit in int and never overflow.
1484 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1485 (gobble_line): Check for size-calculation overflow.
1486
ad39faca 1487 * minibuf.c (Fread_buffer):
6e5bb2dc 1488 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1489 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1490 Don't assume string length fits in int.
1491
52c61c22 1492 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1493 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1494
b5b8c9e5
PE
1495 * font.c: Don't assume string length fits in int.
1496 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1497 Use ptrdiff_t, not int.
ccd6111c
PE
1498 (font_intern_prop): Don't assume string length fits in int.
1499 Don't assume integer property fits in fixnum.
1500 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1501
882f0d81 1502 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1503 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1504 Reformulate so as not to need the command string.
1505 Invoke gzip -cd rather than gunzip, as it's more portable.
1506 (lock_info_type, lock_file_1, lock_file):
1507 Don't assume pid_t and time_t fit in unsigned long.
1508 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1509 (current_lock_owner): Prefer signed type for sizes.
1510 Use memcpy, not strncpy, where memcpy is what is really wanted.
1511 Don't assume (via atoi) that time_t and pid_t fit in int.
1512 Check for time_t and/or pid_t out of range, e.g., via a network share.
1513 Don't alloca where an auto var works fine.
1514
93f4cf88
PE
1515 * fileio.c: Fix some integer overflow issues.
1516 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1517 Don't assume string length fits in int.
1518 (directory_file_name): Don't assume string length fits in long.
1519 (make_temp_name): Don't assume pid fits in int, or that its print
1520 length is less than 20.
1521
f3e92b69
PE
1522 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1523
1bfdaf10
PE
1524 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1525
35016e9a
PE
1526 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1527
3d1e65a1
PE
1528 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1529 We prefer signed integers, even for size calculations.
1530
0b963a93
PE
1531 * emacs.c: Don't assume string length fits in 'int'.
1532 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1533 (main): Don't invoke strlen when not needed.
1534
573f4b54
PE
1535 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1536 (XD_DEBUG_MESSAGE): Don't waste a byte.
1537
989f33ba
PE
1538 * callproc.c (getenv_internal_1, getenv_internal)
1539 (Fgetenv_internal):
965d34eb
PE
1540 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1541
e4d29b33
PE
1542 * lread.c (invalid_syntax): Omit length argument.
1543 All uses changed. This doesn't fix a bug, but it simplifies the
1544 code away from its former Hollerith-constant appearance, and it's
1545 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1546 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1547
eb49b136
PE
1548 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1549 This didn't break anything, but it didn't help either.
1550 It's confusing to put a bogus integer in a place where the actual
1551 value does not matter.
9f62aeb1 1552 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1553 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1554
15375a22
PE
1555 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1556 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1557 implementation.
b61cc01c
PE
1558 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1559 We prefer signed types, and the value cannot exceed the EMACS_INT
1560 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1561 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1562 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1563 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1564
53b2623d
PE
1565 * indent.c (sane_tab_width): New function.
1566 (current_column, scan_for_column, Findent_to, position_indentation)
1567 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1568 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1569
51cab52b 1570 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1571
f2ed8a70
PE
1572 * lisp.h (lint_assume): New macro.
1573 * composite.c (composition_gstring_put_cache):
1574 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1575
abe80cc6
PE
1576 * editfns.c, insdel.c:
1577 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1578
b02c740e
PE
1579 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1580
ebc96716
PE
1581 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1582
b4e50fa0 1583 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1584 Use much-faster test for byte-length change.
311d5d7c 1585 Don't assume string byte-length fits in 'int'.
a4cf38e4 1586 Check that character arg fits in 'int'.
85461888 1587 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1588
c0c1ee9f
PE
1589 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1590
a498d7f4
PE
1591 * fns.c (concat): Catch string overflow earlier.
1592 Do not rely on integer wraparound.
1593
51cab52b
PE
1594 * dispextern.h (struct it.overlay_strings_charpos)
1595 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1596 * xdisp.c (forward_to_next_line_start)
1597 (back_to_previous_visible_line_start)
1598 (reseat_at_next_visible_line_start, next_element_from_buffer):
1599 Don't arbitrarily truncate the value of 'selective' to int.
1600
76031fad
PE
1601 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1602
5eb55db9
PE
1603 * composite.c: Don't truncate sizes to 'int'.
1604 (composition_gstring_p, composition_reseat_it)
1605 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1606 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1607 not EMACS_UINT, for indexes.
5eb55db9 1608
0703a717
PE
1609 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1610
d6202519
PE
1611 * buffer.c: Include <verify.h>.
1612 (struct sortvec.priority, struct sortstr.priority):
8961a454 1613 Now EMACS_INT, not int.
c20998a7 1614 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1615 (struct sortstr.size, record_overlay_string)
1616 (struct sortstrlist.size, struct sortlist.used):
1617 Don't truncate size to int.
1618 (record_overlay_string): Check for size-calculation overflow.
d6202519 1619 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1620
d5a19415
JM
16212011-06-22 Jim Meyering <meyering@redhat.com>
1622
029529ac 1623 Don't leak an XBM-image-sized buffer
d5a19415
JM
1624 * image.c (xbm_load): Free the image buffer after using it.
1625
a9041e6c
PE
16262011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 Port to Sun C.
1629 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1630 that Sun C diagnosed.
1631 * fns.c (secure_hash): Fix pointer signedness issue.
1632 * intervals.c (static_offset_intervals): New function.
1633 (offset_intervals): Use it.
1634
7f3f739f
LL
16352011-06-21 Leo Liu <sdl.web@gmail.com>
1636
1637 * deps.mk (fns.o):
1638 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1639 sha512.h.
1640
1641 * fns.c (secure_hash): Rename from crypto_hash_function and change
1642 the first arg to accept symbols.
5b66d427 1643 (Fsecure_hash): New primitive.
7f3f739f
LL
1644 (syms_of_fns): New symbols.
1645
76147d94
DD
16462011-06-20 Deniz Dogan <deniz@dogan.se>
1647
1648 * process.c (Fset_process_buffer): Clarify return value in
1649 docstring.
1650
7d7d0045
CY
16512011-06-18 Chong Yidong <cyd@stupidchicken.com>
1652
1653 * dispnew.c (add_window_display_history): Use BVAR.
1654
1655 * xdisp.c (debug_method_add): Use BVAR.
1656 (check_window_end, dump_glyph_matrix, dump_glyph)
1657 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1658
1659 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1660 Likewise.
1661
1662 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1663 check till after the cache is created in init_frame_faces.
1664
ff2bc410
SM
16652011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1666
1667 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1668
28177add
PE
16692011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1670
dd3482fe
PE
1671 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1672 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1673 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1674
393d71f3 1675 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1676 * fileio.c (Finsert_file_contents):
1677 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1678 Remove the old (too-loose) buffer overflow checks.
1679 They weren't needed, since make_gap checks for buffer overflow.
1680 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1681 The old code merely checked for Emacs fixnum overflow, and relied
1682 on undefined (wraparound) behavior. The new code avoids undefined
1683 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1684
2e6813b0 1685 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1686 Tune. Don't use wider integers than needed. Don't use alloca.
1687 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1688
599a9e4f
PE
1689 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1690
99561444
PE
1691 * insdel.c, lisp.h (buffer_overflow): New function.
1692 (insert_from_buffer_1, replace_range, replace_range_2):
1693 * insdel.c (make_gap_larger):
1694 * editfns.c (Finsert_char):
1695 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1696
28177add
PE
1697 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1698
e69dafad
PE
16992011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1700
a7af7fde 1701 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1702
b1c46f02
PE
1703 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1704 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1705
e69dafad
PE
1706 * fileio.c: Don't assume EMACS_INT fits in off_t.
1707 (emacs_lseek): New static function.
1708 (Finsert_file_contents, Fwrite_region): Use it.
1709 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1710
566684ea
PE
1711 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1712
e6966cd6
PE
1713 * fns.c: Don't overflow int when computing a list length.
1714 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1715 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1716 truncation on 64-bit hosts. Check for QUIT every
1717 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1718 faster and is responsive enough.
1719 (Flength): Report an error instead of overflowing an integer.
1720 (Fsafe_length): Return a float if the value is not representable
1721 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1722 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1723 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1724
dd0b0efb
PE
1725 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1726 (header_size, word_size): New constants.
1727 (allocate_vectorlike): Don't check size overflow here.
1728 (allocate_vector): Check it here instead, since this is the only
1729 caller of allocate_vectorlike that could cause overflow.
1730 Check that the new vector's length is representable as a fixnum.
1731
86fe5cfe
PE
1732 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1733 The previous code was bogus. For example, next_almost_prime (32)
1734 returned 39, which is undesirable as it is a multiple of 3; and
1735 next_almost_prime (24) returned 25, which is a multiple of 5 so
1736 why was the code bothering to check for multiples of 7?
1737
80e88859
PE
1738 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1739
4a2f0ad6
PE
1740 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1741
f66c7cf8
PE
1742 Variadic C functions now count arguments with ptrdiff_t.
1743 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1744 Back then I didn't know that the Emacs coding style prefers signed int.
1745 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1746 were being counted with int, which may truncate counts on 64-bit
1747 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1748 * lisp.h (struct Lisp_Subr.function.aMANY)
1749 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1750 Arg counts are now ptrdiff_t, not size_t.
1751 All variadic functions and their callers changed accordingly.
1752 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1753 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1754 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1755 * callint.c (Fcall_interactively): Check arg count for overflow,
1756 to avoid potential buffer overrun. Use signed char, not 'int',
1757 for 'varies' array, so that we needn't bother to check its size
1758 calculation for overflow.
1759 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1760 * eval.c (apply_lambda):
1761 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1762 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1763 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1764
a1759b76
PE
1765 * callint.c (Fcall_interactively): Don't use index var as event count.
1766
d96be9fc
PE
1767 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1768 * mem-limits.h (SIZE): Remove; no longer used.
1769
a690a978 1770 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1771
578c21e6
PE
1772 Remove unnecessary casts.
1773 * xterm.c (x_term_init):
1774 * xfns.c (x_set_border_pixel):
1775 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1776 These aren't needed now that we assume ANSI C.
1777
96f53c6c
PE
1778 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1779 It's more likely to cause problems (due to unsigned overflow)
1780 than to cure them.
1781
83c77d31
PE
1782 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1783
ee2079f1
PE
1784 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1785
6da65536
PE
1786 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1787
7147c4a4
PE
1788 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1789
193e32d9
PE
1790 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1791
e5533da6
PE
1792 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1793
9910e595
PE
1794 GLYPH_CODE_FACE returns EMACS_INT, not int.
1795 * dispextern.h (merge_faces):
1796 * xfaces.c (merge_faces):
01103c44
PE
1797 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1798 Don't assume EMACS_INT fits in int.
9910e595 1799
2638320e
PE
1800 * character.h (CHAR_VALID_P): Remove unused parameter.
1801 * fontset.c, lisp.h, xdisp.c: All uses changed.
1802
045eb8d9
PE
1803 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1804
c1f134b5
PE
1805 * fns.c (concat): Minor tuning based on overflow analysis.
1806 This doesn't fix any bugs. Use int to hold character, instead
1807 of constantly refetching from Emacs object. Use XFASTINT, not
1808 XINT, for value known to be a character. Don't bother comparing
1809 a single byte to 0400, as it's always less.
1810
395fcb93 1811 * floatfns.c (Fexpt):
327eeec8
PE
1812 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1813
abbd3d23
PE
1814 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1815 for characters.
1816
684a03ef
PE
1817 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1818
0fed43f3
PE
1819 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1820 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1821 incorrectly succeed when S was a string, because 4294967386 was
1822 truncated before it was used.
1823
8fd02eb7
PE
1824 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1825 Otherwise, an out-of-range integer could cause undefined behavior
1826 on a 64-bit host.
1827
f8c86b69
PE
1828 * composite.c: Use int, not EMACS_INT, for characters.
1829 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1830 EMACS_INT, for values that are known to be in character range.
1831 This doesn't fix any bugs but is the usual style inside Emacs and
1832 may generate better code on 32-bit machines.
1833
34206dd2
PE
1834 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1835 This is for reasons similar to the recent CHAR_STRING fix.
1836 * charset.c (Fencode_char): Check that character arg is actually
1837 a character. Pass an int to ENCODE_CHAR.
1838 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1839 wider than 'int', as a compile-time check to prevent future regressions
1840 in this area.
1841
c5958d4c 1842 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1843
1844 Make sure a 64-bit char is never passed to CHAR_STRING.
1845 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1846 by silently ignoring the top 32 bits, allowing some values
1847 that were far too large to be valid characters.
1848 * character.h: Include <verify.h>.
1849 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1850 arguments are no wider than unsigned, as a compile-time check
1851 to prevent future regressions in this area.
1852 * data.c (Faset):
01103c44 1853 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1854 (Fsubst_char_in_region):
1855 * fns.c (concat):
1856 * xdisp.c (decode_mode_spec_coding):
1857 Adjust to CHAR_STRING's new requirement.
1858 * editfns.c (Finsert_char, Fsubst_char_in_region):
1859 * fns.c (concat): Check that character args are actually
1860 characters. Without this test, these functions did the wrong
1861 thing with wildly out-of-range values on 64-bit hosts.
1862
d37ca623
PE
1863 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1864 These casts should not be needed on 32-bit hosts, either.
1865 * keyboard.c (read_char):
1866 * lread.c (Fload): Remove casts to unsigned.
1867
ea204efb
PE
1868 * lisp.h (UNSIGNED_CMP): New macro.
1869 This fixes comparison bugs on 64-bit hosts.
1870 (ASCII_CHAR_P): Use it.
1871 * casefiddle.c (casify_object):
01103c44 1872 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1873 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1874 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1875 * dispextern.h (FACE_FROM_ID):
1876 * keyboard.c (read_char): Use UNSIGNED_CMP.
1877
41cb286c
PE
1878 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1879 not to EMACS_INT, to avoid GCC warning.
1880
4a1b9832
PE
1881 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1882
55daad71
PE
1883 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1884 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1885 isn't needed on 32-bit machines.
8f95c75c 1886
01103c44
PE
1887 * buffer.c (Fgenerate_new_buffer_name):
1888 Use EMACS_INT for count, not int.
0ceccced 1889 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1890
1891 * data.c (Qcompiled_function): Now static.
1892
c6f072e7
PE
1893 * window.c (window_body_lines): Now static.
1894
20ce5912
PE
1895 * image.c (gif_load): Rename local to avoid shadowing.
1896
9c4c5f81
PE
1897 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1898 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1899 * alloc.c (make_save_value): Integer argument is now of type
1900 ptrdiff_t, not int.
1901 (mark_object): Use ptrdiff_t, not int.
1902 * lisp.h (pD): New macro.
1903 * print.c (print_object): Use it.
1904
c0c5c8ae
PE
1905 * alloc.c: Use EMACS_INT, not int, to count objects.
1906 (total_conses, total_markers, total_symbols, total_vector_size)
1907 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1908 (total_free_floats, total_floats, total_free_intervals)
1909 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1910 Now EMACS_INT, not int. All uses changed.
1911 (Fgarbage_collect): Compute overall total using a double, so that
1912 integer overflow is less likely to be a problem. Check for overflow
1913 when converting back to an integer.
5a25e253
PE
1914 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1915 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1916 These were 'int' variables that could overflow on 64-bit hosts;
1917 they were never used, so remove them instead of repairing them.
211a0b2a 1918 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1919 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1920 Previously, this ceilinged at INT_MAX, but that doesn't work on
1921 64-bit machines.
e46bb31a 1922 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1923
c78baabf 1924 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1925 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1926 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1927 when a (possibly-narrower) signed value would do just as well.
1928 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1929
c9d624c6
PE
1930 * alloc.c: Catch some string size overflows that we were missing.
1931 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1932 for convenience in STRING_BYTES_MAX.
1933 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1934 The definition here is exact; the one in lisp.h was approximate.
1935 (allocate_string_data): Check for string overflow. This catches
1936 some instances we weren't catching before. Also, it catches
1937 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1938 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1939 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1940
c9d624c6
PE
1941 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1942 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1943 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1944
353032ce
PE
1945 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1946
2bccce07
PE
1947 * alloc.c (Fmake_string): Check for out-of-range init.
1948
0ac30604
SM
19492011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1950
1951 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1952
c195f2de
JD
19532011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1954
1955 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1956 xg_get_default_scrollbar_width.
1957
1958 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1959 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1960 (style_changed_cb): Call update_theme_scrollbar_width and call
1961 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1962 all frames (Bug#8505).
1963 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1964 Call gtk_window_set_resizable if HAVE_GTK3.
1965 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1966 and height if HAVE_GTK3 (Bug#8505).
1967 (scroll_bar_width_for_theme): New variable.
1968 (update_theme_scrollbar_width): New function.
1969 (xg_get_default_scrollbar_width): Move code to
1970 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1971 (xg_initialize): Call update_theme_scrollbar_width.
1972
1973 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1974
1975 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1976
e10ac9f1
MR
19772011-06-12 Martin Rudalics <rudalics@gmx.at>
1978
1979 * frame.c (make_frame): Call other_buffer_safely instead of
1980 other_buffer.
1981
1982 * window.c (temp_output_buffer_show): Call display_buffer with
1983 second argument Vtemp_buffer_show_specifiers and reset latter
1984 immediately after the call.
1985 (Vtemp_buffer_show_specifiers): New variable.
1986 (auto_window_vscroll_p, next_screen_context_lines)
1987 (Vscroll_preserve_screen_position): Remove leading asterisks from
1988 doc-strings.
1989
2d3c217e 19902011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1991
7b7f97e8 1992 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1993 * buffer.c (Qclone_number): Remove for now, as it's unused.
1994 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1995 (record_buffer): Remove unused local.
1996 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1997 (set_frame_buffer_list): Remove; unused.
1998 * frame.h (other_visible_frames): Remove decl.
1999 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2000 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2001 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2002 if HAVE_GPM.
2003 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2004 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2005 Define only if HAVE_GPM.
2006 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2007 (update_hints_inhibit): Remove; never set. All uses removed.
2008 * widgetprv.h (emacsFrameClassRec): Remove decl.
2009 * window.c (delete_deletable_window): Now returns void, since it
2010 wasn't returning anything.
2011 (compare_window_configurations): Remove unused locals.
2012 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2013 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2014 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2015 the same widths as pointers. This follows up on the 2011-05-06 patch.
2016 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2017 * xterm.h: Likewise.
2018 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2019
1384b89e
JB
20202011-06-12 Juanma Barranquero <lekktu@gmail.com>
2021
2022 * makefile.w32-in: Update dependencies.
2023 (LISP_H): Add lib/intprops.h.
2024
1100a63c
CY
20252011-06-11 Chong Yidong <cyd@stupidchicken.com>
2026
2027 * image.c (gif_load): Add animation frame delay to the metadata.
2028 (syms_of_image): Use DEFSYM. New symbol `delay'.
2029
6198ccd0
MR
20302011-06-11 Martin Rudalics <rudalics@gmx.at>
2031
2032 * window.c (delete_deletable_window): Re-add.
2033 (Fset_window_configuration): Rewrite to handle dead buffers and
2034 consequently deletable windows.
2035 (window_tree, Fwindow_tree): Remove. Supply functionality in
2036 window.el.
2037 (compare_window_configurations): Simplify code.
2038
b6e3633c
AS
20392011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2040
1ab0dee5
AS
2041 * image.c (imagemagick_load_image): Fix type mismatch.
2042 (Fimagemagick_types): Likewise.
2043
b6e3633c
AS
2044 * window.h (replace_buffer_in_windows): Declare.
2045
9397e56f
MR
20462011-06-11 Martin Rudalics <rudalics@gmx.at>
2047
2048 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2049 Qclone_number. Remove external declaration of Qdelete_window.
2050 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2051 code.
2052 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2053 Qbuffer_list_update_hook if allowed.
2054 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2055 buffer list implementation.
2056 (other_buffer_safely): New function.
2057 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2058 calls to replace_buffer_in_windows and
2059 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2060 if allowed.
2061 (record_buffer): Inhibit quitting and rewrite using quittable
2062 functions. Run Qbuffer_list_update_hook if allowed.
2063 (Frecord_buffer, Funrecord_buffer): New functions.
2064 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2065 switch-to-buffer to window.el.
2066 (bury-buffer): Move to window.el.
2067 (Vbuffer_list_update_hook): New variable.
2068
2069 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2070 section.
2071
2072 * window.h (resize_frame_windows): Move up in code.
2073 (Fwindow_frame): Remove EXFUN.
2074 (replace_buffer_in_all_windows): Remove prototype.
2075 (replace_buffer_in_windows_safely): Add prototype.
2076
2077 * window.c: Declare Qdelete_window static again. Move down
2078 declaration of select_count.
2079 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2080 (Fother_window): Move to window.el.
2081 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2082 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2083 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2084 window.el.
2085 (replace_buffer_in_windows): Implement by calling
2086 Qreplace_buffer_in_windows.
2087 (replace_buffer_in_all_windows): Remove with some functionality
2088 moved into replace_buffer_in_windows_safely.
2089 (replace_buffer_in_windows_safely): New function.
2090 (select_window_norecord, select_frame_norecord): Move in front
2091 of run_window_configuration_change_hook. Remove now obsolete
2092 declarations.
2093 (Fset_window_buffer): Rewrite doc-string. Call
2094 Qrecord_window_buffer.
2095 (keys_of_window): Move binding for other-window to window.el.
2096
b50691aa
CY
20972011-06-11 Chong Yidong <cyd@stupidchicken.com>
2098
2099 * dispextern.h (struct image): Replace data member, whose int_val
2100 and ptr_val fields were not used by anything, with a single
2101 lisp_val object.
2102
2103 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2104 (gif_clear_image, gif_load, imagemagick_load_image)
2105 (gs_clear_image, gs_load): Callers changed.
2106
3f754b86
PE
21072011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2108
cca69397
PE
2109 * buffer.h: Include <time.h>, for time_t.
2110 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2111
109e28d0
PE
2112 Fix minor problems found by static checking.
2113
60737f02
PE
2114 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2115
4b66faf3
PE
2116 Make identifiers static if they are not used in other modules.
2117 * data.c (Qcompiled_function, Qframe, Qvector):
2118 * image.c (QimageMagick, Qsvg):
2119 * minibuf.c (Qmetadata):
2120 * window.c (resize_window_check, resize_root_window): Now static.
2121 * window.h (resize_window_check, resize_root_window): Remove decls.
2122
109e28d0
PE
2123 * window.c (window_deletion_count, delete_deletable_window):
2124 Remove; unused.
46a4ce9e
PE
2125 (window_body_lines): Now static.
2126 (Fdelete_other_windows_internal): Mark vars as initialized.
2127 Make sure 'resize_failed' is initialized.
2128 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2129 (resize_window_apply): Remove unused local.
2130 * window.h (delete_deletable_window): Remove decl.
2131
109e28d0 2132 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2133 (imagemagick_load_image): Fix pointer signedness problem by changing
2134 last arg from unsigned char * to char *. All uses changed.
2135 Also, fix a local for similar reasons.
2136 Remove unused locals. Remove locals to avoid shadowing.
2137 (fn_rsvg_handle_free): Remove; unused.
2138 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2139 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2140
3f754b86
PE
2141 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2142
2547adb1
CY
21432011-06-10 Chong Yidong <cyd@stupidchicken.com>
2144
2145 * image.c (gif_load): Fix omitted cast error introduced by
2146 2011-06-06 change.
2147
2c8e37d4
MR
21482011-06-10 Martin Rudalics <rudalics@gmx.at>
2149
2150 * window.h (resize_proportionally, orig_total_lines)
2151 (orig_top_line): Remove from window structure.
2152 (set_window_height, set_window_width, change_window_heights)
2153 (Fdelete_window): Remove prototypes.
2154 (resize_frame_windows): Remove duplicate declaration.
2155
440a42e3
EZ
21562011-06-10 Eli Zaretskii <eliz@gnu.org>
2157
2158 * window.h (resize_frame_windows, resize_window_check)
2159 (delete_deletable_window, resize_root_window)
2160 (resize_frame_windows): Declare prototypes.
2161
2162 * window.c (resize_window_apply): Make definition be "static" to
2163 match the prototype.
2164
562dd5e9
MR
21652011-06-10 Martin Rudalics <rudalics@gmx.at>
2166
2167 * window.c: Remove declarations of Qwindow_size_fixed,
2168 window_min_size_1, window_min_size_2, window_min_size,
2169 size_window, window_fixed_size_p, enlarge_window, delete_window.
2170 Remove static from declaration of Qdelete_window, it's
2171 temporarily needed by Fbury_buffer.
2172 (replace_window): Don't assign orig_top_line and
2173 orig_total_lines.
2174 (Fdelete_window, delete_window): Remove. Window deletion is
2175 handled by window.el.
2176 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2177 Fdelete_window calls with calls to Qdelete_window.
2178 (Fdelete_other_windows): Remove. Deleting other windows is
2179 handled by window.el.
2180 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2181 handled in window.el.
2182 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2183 Window minimum sizes are handled in window.el.
2184 (shrink_windows, size_window, set_window_height)
2185 (set_window_width, change_window_heights, window_height)
2186 (window_width, CURBEG, CURSIZE, enlarge_window)
2187 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2188 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2189 handled in window.el.
2190 (make_dummy_parent): Rename to make_parent_window and give it a
2191 second argument horflag.
2192 (make_window): Don't set resize_proportionally any more.
2193 (Fsplit_window): Remove. Windows are split in window.el.
2194 (save_restore_action, save_restore_orig_size)
2195 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2196 Resize mini windows in window.el.
2197 (grow_mini_window, shrink_mini_window): Implement by calling
2198 Qresize_root_window_vertically, resize_window_check and
2199 resize_window_apply.
2200 (saved_window, Fset_window_configuration, save_window_save): Do
2201 not handle orig_top_line, orig_total_lines, and
2202 resize_proportionally.
2203 (window_min_height, window_min_width): Move to window.el.
2204 (keys_of_window): Move bindings for delete-other-windows,
2205 split-window, delete-window and enlarge-window to window.el.
2206
2207 * buffer.c: Temporarily extern Qdelete_window.
2208 (Fbury_buffer): Temporarily call Qdelete_window instead of
2209 Fdelete_window (Fbury_buffer will move to window.el soon).
2210
2211 * frame.c (set_menu_bar_lines_1): Remove code handling
2212 orig_top_line and orig_total_lines.
2213
2214 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2215 set_window_height but set heights directly.
2216 (change_frame_size_1): Use resize_frame_windows.
2217
2218 * xdisp.c (init_xdisp): Don't use set_window_height but set
2219 heights directly.
2220
2221 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2222 resize_frame_windows instead of change_window_heights and run
2223 run_window_configuration_change_hook.
2224
2225 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2226 instead of change_window_heights and run
2227 run_window_configuration_change_hook.
2228
1a13852e
MR
22292011-06-09 Martin Rudalics <rudalics@gmx.at>
2230
2231 * window.c (replace_window): Rename second argument REPLACEMENT to
2232 NEW. New third argument SETFLAG. Rewrite.
2233 (delete_window, make_dummy_parent): Call replace_window with
2234 third argument 1.
2235 (window_list_1): Move down in code.
2236 (run_window_configuration_change_hook): Move set_buffer part
2237 before select_frame_norecord part in order to unwind correctly.
2238 Rename count1 to count.
2239 (recombine_windows, delete_deletable_window, resize_root_window)
2240 (Fdelete_other_windows_internal)
2241 (Frun_window_configuration_change_hook, make_parent_window)
2242 (resize_window_check, resize_window_apply, Fresize_window_apply)
2243 (resize_frame_windows, Fsplit_window_internal)
2244 (Fdelete_window_internal, Fresize_mini_window_internal): New
2245 functions.
2246 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2247
f3d1777e
MR
22482011-06-08 Martin Rudalics <rudalics@gmx.at>
2249
496e208e
MR
2250 * window.h (window): Add some new members to window structure -
2251 normal_lines, normal_cols, new_total, new_normal, clone_number,
2252 splits, nest, prev_buffers, next_buffers.
2253 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2254 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2255
f3d1777e
MR
2256 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2257 Remove.
496e208e
MR
2258 (make_dummy_parent): Set new members of windows structure.
2259 (make_window): Move down in code. Handle new members of window
2260 structure.
2261 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2262 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2263 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2264 (Fset_window_prev_buffers, Fwindow_next_buffers)
2265 (Fset_window_next_buffers, Fset_window_clone_number): New
2266 functions.
2267 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2268 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2269 Doc-string fixes.
2270 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2271 Argument WINDOW can be now internal window too.
2272 (Fwindow_use_time): Move up in code.
2273 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2274 Rewrite doc-string.
2275 (Fset_window_configuration, saved_window)
2276 (Fcurrent_window_configuration, save_window_save): Handle new
2277 members of window structure.
b9e809c2
MR
2278 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2279 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2280 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2281 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2282 Qget_mru_window, Qresize_root_window,
2283 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2284 Qauto_buffer_name; staticpro them.
f3d1777e 2285
abde8f8c
MR
22862011-06-07 Martin Rudalics <rudalics@gmx.at>
2287
2288 * window.c (Fwindow_total_size, Fwindow_left_column)
2289 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2290 (Fwindow_list_1): New functions.
2291 (window_box_text_cols): Replace with window_body_cols.
2292 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2293 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2294 (delete_window, Fset_window_configuration): Call
2295 delete_all_subwindows with window as argument.
2296 (delete_all_subwindows): Take a window as argument and not a
2297 structure. Rewrite.
190b47e6
MR
2298 (window_loop): Remove handling of GET_LRU_WINDOW and
2299 GET_LARGEST_WINDOW.
2300 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2301
2302 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2303 window_box_text_cols. delete_all_subwindows now takes a
2304 Lisp_Object as argument.
abde8f8c
MR
2305
2306 * indent.c (compute_motion, Fcompute_motion): Use
2307 window_body_cols instead of window_box_text_cols.
2308
fa8a67e6
MR
2309 * frame.c (delete_frame): Call delete_all_subwindows with root
2310 window as argument.
2311
a54e3482
DC
23122011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2313
2314 * fns.c (Fputhash): Document return value.
2315
60002bf5
CY
23162011-06-06 Chong Yidong <cyd@stupidchicken.com>
2317
2318 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2319
0c671da6 23202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2321
b862a52a 2322 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2323
be44ca6c
PE
2324 Check for overflow when converting integer to cons and back.
2325 * charset.c (Fdefine_charset_internal, Fdecode_char):
2326 Use cons_to_unsigned to catch overflow.
2327 (Fencode_char): Use INTEGER_TO_CONS.
2328 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2329 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2330 * data.c (long_to_cons, cons_to_long): Remove.
2331 (cons_to_unsigned, cons_to_signed): New functions.
2332 These signal an error for invalid or out-of-range values.
2333 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2334 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2335 * font.c (Ffont_variation_glyphs):
2336 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2337 * lisp.h: Include <intprops.h>.
2338 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2339 (cons_to_signed, cons_to_unsigned): New decls.
2340 (long_to_cons, cons_to_long): Remove decls.
2341 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2342 (Fprimitive_undo): Use CONS_TO_INTEGER.
2343 * xfns.c (Fx_window_property): Likewise.
2344 * xselect.c: Include <limits.h>.
2345 (x_own_selection, selection_data_to_lisp_data):
2346 Use INTEGER_TO_CONS.
2347 (x_handle_selection_request, x_handle_selection_clear)
2348 (x_get_foreign_selection, Fx_disown_selection_internal)
2349 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2350 (lisp_data_to_selection_data): Use cons_to_unsigned.
2351 (x_fill_property_data): Use cons_to_signed.
2352 Report values out of range.
2353
d1f3d2af
PE
2354 Check for buffer and string overflow more precisely.
2355 * buffer.h (BUF_BYTES_MAX): New macro.
2356 * lisp.h (STRING_BYTES_MAX): New macro.
2357 * alloc.c (Fmake_string):
2358 * character.c (string_escape_byte8):
2359 * coding.c (coding_alloc_by_realloc):
2360 * doprnt.c (doprnt):
2361 * editfns.c (Fformat):
2362 * eval.c (verror):
2363 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2364 since they may not be the same number.
2365 * editfns.c (Finsert_char):
2366 * fileio.c (Finsert_file_contents):
2367 Likewise for BUF_BYTES_MAX.
2368
dd52fcea
PE
2369 * image.c: Use ptrdiff_t, not int, for sizes.
2370 (slurp_file): Switch from int to ptrdiff_t.
2371 All uses changed.
2372 (slurp_file): Check that file size fits in both size_t (for
2373 malloc) and ptrdiff_t (for sanity and safety).
2374
7f9bbdbb
PE
2375 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2376 if b->modtime has its maximal value.
2377
dfe18f82
PE
2378 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2379
84acfcf0
PE
2380 Don't assume time_t can fit into int.
2381 * buffer.h (struct buffer.modtime): Now time_t, not int.
2382 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2383 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2384
ccd9a01a
PE
2385 Minor fixes for signed vs unsigned integers.
2386 * character.h (MAYBE_UNIFY_CHAR):
2387 * charset.c (maybe_unify_char):
2388 * keyboard.c (read_char, reorder_modifiers):
2389 XINT -> XFASTINT, since the integer must be nonnegative.
2390 * ftfont.c (ftfont_spec_pattern):
2391 * keymap.c (access_keymap, silly_event_symbol_error):
2392 XUINT -> XFASTINT, since the integer must be nonnegative.
2393 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2394 since it makes no difference and we prefer signed.
2395 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2396 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2397 nonnegative.
2398
d6d100dd
SM
23992011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2400
2401 * window.h (Fwindow_frame): Declare.
2402
2b6148e4
PE
24032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2406 (SPARE_MEMORY): Always define.
2407 (LARGE_REQUEST): Remove.
2408 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2409
f230ecc9
MR
24102011-06-06 Martin Rudalics <rudalics@gmx.at>
2411
727e958e
MR
2412 * lisp.h: Move EXFUNS for Fframe_root_window,
2413 Fframe_first_window and Fset_frame_selected_window to window.h.
2414
2415 * window.h: Move EXFUNS for Fframe_root_window,
2416 Fframe_first_window and Fset_frame_selected_window here from
2417 lisp.h.
2418
2419 * frame.c (Fwindow_frame, Fframe_first_window)
2420 (Fframe_root_window, Fframe_selected_window)
2421 (Fset_frame_selected_window): Move to window.c.
2422 (Factive_minibuffer_window): Move to minibuf.c.
2423 (Fother_visible_frames_p): New function.
2424
2425 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2426
f230ecc9
MR
2427 * window.c (decode_window, decode_any_window): Move up in code.
2428 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2429 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2430 (Fwindow_buffer): Move up and rewrite doc-string.
2431 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2432 (Fwindow_prev): New functions.
727e958e
MR
2433 (Fwindow_frame): Move here from frame.c. Accept any window as
2434 argument.
2435 (Fframe_root_window, Fframe_first_window)
2436 (Fframe_selected_window): Move here from frame.c. Accept frame
2437 or arbitrary window as argument. Update doc-strings.
2438 (Fminibuffer_window): Move up in code.
2439 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2440 (Fset_frame_selected_window): Move here from frame.c.
2441 Marginal rewrite.
727e958e
MR
2442 (Fselected_window, select_window, Fselect_window): Move up in
2443 code. Minor doc-string fixes.
f230ecc9 2444
4d09bcf6
PE
24452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2446
2447 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2448 Do not assume that spare memory exists; that assumption is valid
2449 only if SYSTEM_MALLOC.
2450 (LARGE_REQUEST): New macro, so that the issue of large requests
2451 is separated from the issue of spare memory.
2452
810928a2
AS
24532011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2454
172418ad
AS
2455 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2456 format. (Bug#8806)
2457
43f862f7
AS
2458 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2459
810928a2
AS
2460 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2461 before statements.
2462
a059fe24
JD
24632011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2464
2465 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2466
2467 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2468
2469 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2470 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2471
989bf368
JB
24722011-06-05 Juanma Barranquero <lekktu@gmail.com>
2473
2474 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2475
4b80f674
CY
24762011-06-04 Chong Yidong <cyd@stupidchicken.com>
2477
2478 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2479 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2480 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2481 New error handlers.
4b80f674
CY
2482 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2483 Obey Vx_select_enable_clipboard_manager. Catch errors in
2484 x_clipboard_manager_save (Bug#8779).
2485 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2486 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2487
99a33b77 24882011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2489
2490 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2491
99a33b77 24922011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2493
2494 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2495 in the current matrix if keep_current_p is non-zero.
2496
8264569d
EZ
24972011-06-04 Eli Zaretskii <eliz@gnu.org>
2498
2499 * bidi.c (bidi_level_of_next_char): Fix last change.
2500
57f97249
EZ
25012011-06-03 Eli Zaretskii <eliz@gnu.org>
2502
fec2107c 2503 Support bidi reordering of text covered by display properties.
57f97249 2504
fec2107c
EZ
2505 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2506 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2507 (bidi_cache_search, bidi_cache_iterator_state)
2508 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2509 (bidi_level_of_next_char, bidi_move_to_visually_next):
2510 Support character positions inside a run of characters covered by a
fec2107c
EZ
2511 display string.
2512 (bidi_paragraph_init, bidi_resolve_explicit_1)
2513 (bidi_level_of_next_char): Call bidi_fetch_char and
2514 bidi_fetch_char_advance instead of FETCH_CHAR and
2515 FETCH_CHAR_ADVANCE.
2516 (bidi_init_it): Initialize new members.
2517 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2518 definitions.
2519 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2520 instead of using explicit *_CHAR codes.
d6d100dd
SM
2521 (bidi_resolve_explicit, bidi_resolve_weak):
2522 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2523 bidirectional text is supported only in multibyte buffers.
2524 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2525 it to initialize the frame_window_p member of struct bidi_it.
2526 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2527 (bidi_resolve_explicit, bidi_resolve_weak)
2528 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2529 bidi_it->nchars is non-positive.
2530 (bidi_level_of_next_char): Don't try to lookup the cache for the
2531 next/previous character if nothing is cached there yet, or if we
2532 were just reseat()'ed to a new position.
c40e2fb2 2533
0e14fe90
EZ
2534 * xdisp.c (set_cursor_from_row): Set start and stop points
2535 according to the row's direction when priming the loop that looks
2536 for the glyph on which to display cursor.
2537 (single_display_spec_intangible_p): Function deleted.
2538 (display_prop_intangible_p): Reimplement to call
2539 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2540 Accept 3 additional arguments needed by handle_display_spec.
2541 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2542 values: lists, `(when COND...)' forms, etc.
2543 (single_display_spec_string_p): Support property values that are
2544 lists with the argument STRING its top-level element.
2545 (display_prop_string_p): Fix the condition for processing a
2546 property that is a list to be consistent with handle_display_spec.
fec2107c 2547 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2548 last portion of handle_display_prop.
2549 (compute_display_string_pos): Accept additional argument
2550 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2551 value of a `display' property is a "replacing spec".
2552 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2553 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2554 the display property, but just return a value indicating whether
2555 the display property will replace the characters it covers.
2556 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2557 frame_window_p members of struct bidi_it.
d6d100dd
SM
2558 (compute_display_string_pos, compute_display_string_end):
2559 New functions.
fec2107c
EZ
2560 (push_it): Accept second argument POSITION, where pop_it should
2561 jump to continue iteration.
2562 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2563
fec2107c
EZ
2564 * keyboard.c (adjust_point_for_property): Adjust the call to
2565 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2566
2567 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2568 (bidi_init_it): Update prototypes.
2569 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2570 (compute_display_string_pos, compute_display_string_end):
2571 Declare prototypes.
fec2107c
EZ
2572 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2573 EMACS_INT.
fc6f18ce 2574
40087514 25752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2576
57f53182
PE
2577 Malloc failure behavior now depends on size of allocation.
2578 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2579 * lisp.h: Change signatures accordingly.
2580 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2581 All callers changed. (Bug#8762)
2582
2583 * gnutls.c: Use Emacs's memory allocators.
2584 Without this change, the gnutls library would invoke malloc etc.
2585 directly, which causes problems on non-SYNC_INPUT hosts, and which
2586 runs afoul of improving memory_full behavior. (Bug#8761)
2587 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2588 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2589 xfree instead of the default malloc, realloc, free.
2590 (Fgnutls_boot): No need to check for memory allocation failure,
2591 since xmalloc does that for us.
2592
ac32cd99 2593 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2594 * category.c (hash_get_category_set):
2595 * ccl.c (ccl_driver):
2596 * charset.c (Fdefine_charset_internal):
2597 * charset.h (struct charset.hash_index):
2598 * composite.c (get_composition_id, gstring_lookup_cache)
2599 (composition_gstring_put_cache):
2600 * composite.h (struct composition.hash_index):
2601 * dispextern.h (struct image.hash):
2602 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2603 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2604 (hashfn_equal, hashfn_user_defined, make_hash_table)
2605 (maybe_resize_hash_table, hash_lookup, hash_put)
2606 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2607 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2608 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2609 * image.c (make_image, search_image_cache, lookup_image)
2610 (xpm_put_color_table_h):
2611 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2612 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2613 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2614 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2615 * alloc.c (allocate_vectorlike):
2616 Check for overflow in vector size calculations.
2617 * ccl.c (ccl_driver):
2618 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2619 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2620 need to be updated by these changes.
40087514
PE
2621 * fns.c (make_hash_table, maybe_resize_hash_table):
2622 Check for integer overflow with large hash tables.
0de4bb68
PE
2623 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2624 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2625 (SXHASH_REDUCE): New macro.
2626 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2627 Use it instead of discarding useful hash info with large hash values.
2628 (sxhash_float): New function.
2629 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2630 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2631 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2632 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2633 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2634 Adjust signatures to match updated version of code.
2635 (consing_since_gc): Now EMACS_INT, since a single hash table can
2636 use more than INT_MAX bytes.
2637
698d32e2
DN
26382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2639
2640 Make it possible to build with GCC-4.6+ -O2 -flto.
2641
2642 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2643
fd6fa53f
SM
26442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2645
2646 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2647 Call minibuffer-inactive-mode.
2648
864db017
JB
26492011-05-31 Juanma Barranquero <lekktu@gmail.com>
2650
2651 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2652 Update dependencies.
2653
2ad0baf4
DN
26542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2655
2656 * data.c (init_data): Remove code for UTS, this system is not
2657 supported anymore.
2658
4fcc2638
DN
26592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2660
2661 Don't force ./temacs to start in terminal mode.
2662
2663 * frame.c (make_initial_frame): Initialize faces in all cases, not
2664 only when CANNOT_DUMP is defined.
2665 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2666
c56e0fd5
DN
26672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2668
2669 * dispnew.c (add_window_display_history): Use const for the string
2670 pointer. Remove declaration, not needed.
2671
333d54da 26722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2673
55d4c1b2 2674 Use 'inline', not 'INLINE'.
333d54da 2675 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2676 * alloc.c, fontset.c (INLINE): Remove.
2677 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2678 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2679 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2680 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2681 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2682
738db178
DN
26832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2684
2685 Make it possible to run ./temacs.
2686
2687 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2688 syms_of_callproc does the same thing. Remove test for
2689 "initialized", do it in the caller.
2690 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2691
620c53a6
SM
26922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2693
2694 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2695 (read_minibuf): Use get_minibuffer.
2696 (syms_of_minibuf): Use DEFSYM.
2697 (Qmetadata): New var.
2698 * data.c (Qbuffer): Don't make it static.
2699 (syms_of_data): Use DEFSYM.
2700
e003a292
PE
27012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2704 (CCL_CODE_MIN): New macro.
2705
ed008a6d
PE
27062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2707
3687c2ef
PE
2708 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2709
ed008a6d
PE
2710 * eval.c (Qdebug): Now static.
2711 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2712 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2713 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2714
d66c4c7c
CY
27152011-05-29 Chong Yidong <cyd@stupidchicken.com>
2716
2717 * image.c: Various fixes to ImageMagick code comments.
2718 (Fimagemagick_types): Doc fix.
2719
5fbc2025
PE
27202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2721
0196f88a
PE
2722 Minor fixes prompted by GCC 4.6.0 warnings.
2723
2724 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2725
5fbc2025
PE
2726 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2727 (x_clipboard_manager_save_all): Move extern decl to ...
2728 * xterm.h: ... here, so that it can be checked for consistency.
2729
1dd3c2d9
CY
27302011-05-29 Chong Yidong <cyd@stupidchicken.com>
2731
2732 * xselect.c (x_clipboard_manager_save_frame)
2733 (x_clipboard_manager_save_all): New functions.
2734 (Fx_clipboard_manager_save): Lisp function deleted.
2735
2736 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2737 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2738
2739 * xterm.h: Update prototype.
2740
5ba6571d
WX
27412011-05-28 William Xu <william.xwl@gmail.com>
2742
2743 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2744 exiting (Bug#8239).
2745
3eaff834
JM
27462011-05-28 Jim Meyering <meyering@redhat.com>
2747
e1900994 2748 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2749 * fns.c (to_uchar): Define.
2750 (crypto_hash_function): Use it to convert some newly-signed
2751 variables to unsigned, to avoid sign-extension bugs. For example,
2752 without this change, (md5 "truc") would evaluate to
2753 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2754 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2755 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2756
0f6990a7
PE
27572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2758
2759 Integer overflow fixes.
c8a9ca5a 2760
08686060
PE
2761 * dbusbind.c: Serial number integer overflow fixes.
2762 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2763 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2764 to hold a serial number that is too large for a fixnum.
2765 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2766 Check for serial numbers out of range. Decode any serial number
59568bf0 2767 that was so large that it became a float. (Bug#8722)
08686060 2768
2d1fc3c7
PE
2769 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2770 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2771 Use XFASTINT rather than XUINT when numbers are nonnegative.
2772 (xd_append_arg, Fdbus_method_return_internal):
2773 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2774 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2775 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2776 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2777 (Bug#8722)
2d1fc3c7 2778
c8a9ca5a
PE
2779 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2780
519e1d69
PE
2781 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2782
30569699
PE
2783 ccl: add integer overflow checks
2784 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2785 (IN_INT_RANGE): New macros.
2786 (ccl_driver): Use them to check for integer overflow when
2787 decoding a CCL program. Many of the new checks are whether XINT (x)
2788 fits in int; it doesn't always, on 64-bit hosts. The new version
2789 doesn't catch all possible integer overflows, but it's an
847044ea 2790 improvement. (Bug#8719)
30569699 2791
c11285dc
PE
2792 * alloc.c (make_event_array): Use XINT, not XUINT.
2793 There's no need for unsigned here.
2794
fdccd48e
PE
2795 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2796 This follows up to the 2011-05-06 change that substituted uintptr_t
2797 for EMACS_INT. This case wasn't caught back then.
2798
37910ab2
PE
2799 Rework Fformat to avoid integer overflow issues.
2800 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2801 now (part of C89). Include <verify.h>.
2802 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2803 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2804 (Fformat): Avoid the prepass trying to compute sizes; it was only
2805 approximate and thus did not catch overflow reliably. Instead, walk
2806 through the format just once, formatting and computing sizes as we go,
2807 checking for integer overflow at every step, and allocating a larger
2808 buffer as needed. Keep track separately whether the format is
2809 multibyte. Keep only the most-recently calculated precision, rather
2810 than them all. Record whether each argument has been converted to
2811 string. Use EMACS_INT, not int, for byte and char and arg counts.
2812 Support field widths and precisions larger than INT_MAX. Avoid
2813 sprintf's undefined behavior with conversion specifications such as %#d
2814 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2815 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2816 formatting out-of-range floating point numbers with int
9173deec 2817 formats. (Bug#8668)
37910ab2 2818
2e6578fb
PE
2819 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2820
0ae6bdee
PE
2821 * data.c: Avoid integer truncation in expressions involving floats.
2822 * data.c: Include <intprops.h>.
2823 (arith_driver): When there's an integer overflow in an expression
2824 involving floating point, convert the integers to floating point
2825 so that the resulting value does not suffer from catastrophic
2826 integer truncation. For example, on a 64-bit host (* 4
2827 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2828 Do not rely on undefined behavior after integer overflow.
2829
de883a70
PE
2830 merge count_size_as_multibyte, parse_str_to_multibyte
2831 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2832 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2833 Check for integer overflow.
2834 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2835 since it's now a duplicate of the other. This is more of
2836 a character than a buffer op, so better that it's in character.c.
2837 * fns.c, print.c: Adjust to above changes.
2838
2ff916cb
PE
28392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2840
2841 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2842
f1b54466
PE
28432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2844
fb1ac845
PE
2845 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2846 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2847 (x_clipboard_manager_save): Now static.
2848 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2849
f1b54466
PE
2850 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2851 (crypto_hash_function): Now static.
2852 Fix pointer signedness problems. Avoid unnecessary initializations.
2853
a9f737ee
CY
28542011-05-27 Chong Yidong <cyd@stupidchicken.com>
2855
2856 * termhooks.h (Vselection_alist): Make it terminal-local.
2857
2858 * terminal.c (create_terminal): Initialize it.
2859
2860 * xselect.c: Support for clipboard managers.
2861 (Vselection_alist): Move to termhooks.h as terminal-local var.
2862 (LOCAL_SELECTION): New macro.
2863 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2864 (symbol_to_x_atom): Remove gratuitous arg.
2865 (x_handle_selection_request, lisp_data_to_selection_data)
2866 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2867 (x_own_selection, x_get_local_selection, x_convert_selection):
2868 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2869 (some_frame_on_display): Delete unused function.
2870 (Fx_own_selection_internal, Fx_get_selection_internal)
2871 (Fx_disown_selection_internal, Fx_selection_owner_p)
2872 (Fx_selection_exists_p): New optional frame arg.
2873 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2874 (x_handle_selection_clear): Don't treat other terminals with the
2875 same keyboard specially. Use the terminal-local Vselection_alist.
2876 (x_clear_frame_selections): Use Frun_hook_with_args.
2877
2878 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2879
2880 * xterm.h: Add support for those atoms.
2881
e067f0c1
CY
28822011-05-26 Chong Yidong <cyd@stupidchicken.com>
2883
2884 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2885 (converted_selections, conversion_fail_tag): New global variables.
2886 (x_selection_request_lisp_error): Free the above.
2887 (x_get_local_selection): Remove unnecessary code.
2888 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2889 of converted selections stored in converted_selections.
2890 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2891 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2892 (x_convert_selection): New function.
2893 (x_handle_selection_event): Simplify.
2894 (x_get_foreign_selection): Don't ignore incoming requests while
2895 waiting for an answer; this will fail when we implement
2896 SAVE_TARGETS, and seems unnecessary anyway.
2897 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2898 (Vx_sent_selection_functions): Doc fix.
2899
0f4aebc0
LL
29002011-05-26 Leo Liu <sdl.web@gmail.com>
2901
2902 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2903
e61124cd
YM
29042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2905
2906 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2907
2908 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2909 for fringe update if it has periodic bitmap.
ac389d0c 2910 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2911 and fringe_bitmap_periodic_p.
2912
2913 * fringe.c (get_fringe_bitmap_data): New function.
2914 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2915 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2916 row. Mark glyph row for fringe update if periodicity changed.
2917
2918 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2919 for fringe update unless it has periodic bitmap.
2920
f16d9837
KH
29212011-05-25 Kenichi Handa <handa@m17n.org>
2922
2923 * xdisp.c (get_next_display_element): Set correct it->face_id for
2924 a static composition.
2925
e1b90ef6
LL
29262011-05-24 Leo Liu <sdl.web@gmail.com>
2927
2928 * deps.mk (fns.o):
2929 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2930
2931 * fns.c (crypto_hash_function, Fsha1): New function.
2932 (Fmd5): Use crypto_hash_function.
2933 (syms_of_fns): Add Ssha1.
2934
7400048f
PE
29352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * gnutls.c: Remove unused macros.
2938 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2939 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2940 Remove macros that are defined and never used.
2941 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2942
abb71cf4
CY
29432011-05-22 Chong Yidong <cyd@stupidchicken.com>
2944
2945 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2946 (Fx_get_selection_internal): Minor cleanup.
2947 (Fx_own_selection_internal): Rename arguments for consistency with
2948 select.el.
2949
6307db39
PE
29502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2953
f3d4e0a4
CY
29542011-05-22 Chong Yidong <cyd@stupidchicken.com>
2955
2956 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2957
4d8ade89
YM
29582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2959
2960 * dispnew.c (scrolling_window): Don't exclude the case that the
2961 last enabled row in the desired matrix touches the bottom boundary.
2962
32078c8d
GM
29632011-05-21 Glenn Morris <rgm@gnu.org>
2964
2965 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2966 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2967 and add some more files.
32078c8d 2968
7285dc67
EZ
29692011-05-20 Eli Zaretskii <eliz@gnu.org>
2970
2971 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2972 report_file_error introduced by the change from 2011-05-07.
2973
89d1bd22
PE
29742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 * systime.h (Time): Define only if emacs is defined.
2977 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2978 where the include path doesn't have X11/X.h by default. See
2979 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2980
e23640bb 29812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2982
2983 * composite.c (find_automatic_composition): Fix previous change.
2984
b9704ad9
GM
29852011-05-20 Glenn Morris <rgm@gnu.org>
2986
2987 * lisp.mk: New file, split from Makefile.in.
2988 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2989 (shortlisp): Remove.
2990 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2991
4a720484
GM
29922011-05-19 Glenn Morris <rgm@gnu.org>
2993
2994 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2995 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2996 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2997 (lisp): Set the order to that of loadup.el.
2998 (shortlisp): Make it a copy of $lisp.
2999 (SOME_MACHINE_LISP): Remove.
3000 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3001 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3002
a28d4396
KH
30032011-05-18 Kenichi Handa <handa@m17n.org>
3004
3005 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3006 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3007 (find_automatic_composition): Mostly rewrite for efficiency.
3008
a2b1fa8e
JB
30092011-05-18 Juanma Barranquero <lekktu@gmail.com>
3010
3011 * makefile.w32-in: Update dependencies.
3012
8e1f5610
CS
30132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3014
3015 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3016 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3017
7025ee00 30182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3019
cdfa6eab
PE
3020 Fix some integer overflow issues, such as string length overflow.
3021
06d6db33
PE
3022 * insdel.c (count_size_as_multibyte): Check for string overflow.
3023
2b4560a8
PE
3024 * character.c (lisp_string_width): Check for string overflow.
3025 Use EMACS_INT, not int, for string indexes and lengths; in
3026 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3027 the resulting string length overflows an EMACS_INT; instead,
3028 report a string overflow if no precision given. When checking for
3029 precision exhaustion, use a check that cannot possibly have
3030 integer overflow. (Bug#8675)
3031 * character.h (lisp_string_width): Adjust to new signature.
3032
cb93f9be
PE
3033 * alloc.c (string_overflow): New function.
3034 (Fmake_string): Use it. This doesn't change behavior, but saves
3035 a few bytes and will simplify future changes.
3036 * character.c (string_escape_byte8): Likewise.
3037 * lisp.h (string_overflow): New decl.
3038
1a1f3366
PE
3039 Fixups, following up to the user-interface timestamp change.
3040 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3041 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3042 * msdos.c (mouse_get_pos): Likewise.
3043 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3044 * w32gui.h (Time): Define by including "systime.h" rather than by
3045 declaring it ourselves. (Bug#8664)
3046
d4e3e4d3
PE
3047 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3048 * image.c (clear_image_cache): Likewise.
3049
f6a24d19
PE
3050 * term.c (term_mouse_position): Don't assume time_t wraparound.
3051
08dc5ae6
PE
3052 Be more systematic about user-interface timestamps.
3053 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3054 and sometimes 'EMACS_UINT', to represent these timestamps.
3055 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3056 This makes the code easier to follow, and makes it easier to catch
3057 integer overflow bugs such as Bug#8664.
3058 * frame.c (Fmouse_position, Fmouse_pixel_position):
3059 Use Time, not unsigned long, for user-interface timestamps.
3060 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3061 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3062 * keyboard.h (last_event_timestamp): Likewise.
3063 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3064 * menu.h (xmenu_show): Likewise.
3065 * term.c (term_mouse_position): Likewise.
3066 * termhooks.h (struct input_event.timestamp): Likewise.
3067 (struct terminal.mouse_position_hook): Likewise.
3068 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3069 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3070 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3071 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3072 what it was before.
3073 * menu.h, termhooks.h: Include "systime.h", for Time.
3074
8e55734a
PE
3075 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3076 Don't assume that the difference between two unsigned long values
3077 can fit into an integer. At this point, we know button_down_time
3078 <= event->timestamp, so the difference must be nonnegative, so
3079 there's no need to cast the result if double-click-time is
3080 nonnegative, as it should be; check that it's nonnegative, just in
3081 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3082 apart (about 25 days). (Bug#8664)
8e55734a 3083
841f1b75 3084 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3085 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3086
3e26f69c
PE
3087 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3088 that always fit in int. Use a sentinel instead of a counter, to
3089 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3090 * frame.h (struct frame): Use int for menu_bar_items_used
3091 instead of EMACS_INT, since it always fits in int.
3e26f69c 3092
5cc152c0
PE
3093 * menu.c (grow_menu_items): Check for int overflow.
3094
d89eb65e
PE
3095 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3096
5235bd3e
PE
3097 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3098 Before, the code was not consistent. These values cannot exceed
3099 2**31 - 1 so there's no need to make them unsigned.
3100 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3101 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3102 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3103 as modifiers.
3104 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3105
bc827e23
PE
3106 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3107 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3108 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3109 presumably because the widths might not match.
3110
78eb494e
PE
3111 * window.c (size_window): Avoid needless test at loop start.
3112
04f2d78b
CB
31132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3114
3115 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3116
d2fc7e3d 31172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3118
3119 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3120
d2fc7e3d 31212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3122
3123 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3124 `width' to `bar_area_x' and `bar_area_width', respectively.
3125 (x_scroll_run): Take account of fringe background extension.
3126
04f2d78b
CB
3127 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3128 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3129 `bar_area_width', respectively.
3130 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3131 background extension.
3132
79b70037
GM
31332011-05-10 Jim Meyering <meyering@redhat.com>
3134
3135 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3136
2f142cc5
JB
31372011-05-10 Juanma Barranquero <lekktu@gmail.com>
3138
3139 * image.c (Finit_image_library): Return t for built-in image types,
3140 like pbm and xbm. (Bug#8640)
3141
57679c86
AS
31422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3143
3144 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3145
888c9e86
EZ
31462011-05-07 Eli Zaretskii <eliz@gnu.org>
3147
b0512a1d
EZ
3148 * w32console.c (Fset_screen_color): Doc fix.
3149 (Fget_screen_color): New function.
3150 (syms_of_ntterm): Defsubr it.
3151
7285dc67
EZ
3152 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3153 unlink the temporary file if Fcall_process didn't create it in the
3154 first place.
3155 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3156 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3157 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3158 cue to call_process_cleanup not to close that handle.
3159
4d3fcc8e
BK
31602011-05-07 Ben Key <bkey76@gmail.com>
3161
3162 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3163 one of two shell specific rules, either bootstrap-temacs-CMD or
3164 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3165 to the previous implementation of the bootstrap-temacs rule.
3166 The bootstrap-temacs-CMD rule is similar to the previous
3167 implementation of the bootstrap-temacs rule except that it
3168 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3169 variable.
3170
3171 These changes, along with some changes to nt/configure.bat,
3172 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3173 earlier fix to add support for --cflags and --ldflags options
3174 that include quotes so that it works whether make uses cmd or
3175 sh as the shell.
3176
b4289b64
MA
31772011-05-06 Michael Albinus <michael.albinus@gmx.de>
3178
3179 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3180 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3181 is a constant.
3182 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3183 a string. Handle both cases.
3184 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3185 (Fdbus_register_method): Use Qinvalid_function.
3186
af4c0e28
JB
31872011-05-06 Juanma Barranquero <lekktu@gmail.com>
3188
3189 * makefile.w32-in: Update dependencies.
3190 (LISP_H): Add inttypes.h and stdin.h.
3191 (PROCESS_H): Add unistd.h.
3192
c51453d9
EZ
31932011-05-06 Eli Zaretskii <eliz@gnu.org>
3194
3195 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3196 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3197
8ff0ac3c 31982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3199
4c4b566b
PE
3200 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3201
aab2b9b5
PE
3202 * term.c (vfatal): Remove stray call to va_end.
3203 It's not needed and the C Standard doesn't allow it here anyway.
3204
c378da0b
PE
3205 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3206 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3207
288b08c7
PE
3208 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3209 bytes.
3210
e3601888
PE
3211 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3212
db6c0e74
PE
3213 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3214
dd5963ea
PE
3215 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3216
88c9450f
PE
3217 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3218
2f9442b8
PE
3219 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3220
c032b5f8
PE
3221 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3222 * charset.c (Fdefine_charset_internal): Don't initialize
3223 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3224 32-bit int (Bug#8600).
a108c10b
PE
3225
3226 * lread.c (read_integer): Be more consistent with string-to-number.
3227 Use string_to_number to do the actual conversion; this avoids
3228 rounding errors and fixes some other screwups. Without this fix,
3229 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3230 (digit_to_number): Move earlier, for benefit of read_integer.
3231 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3232 not a digit in any supported base. (Bug#8602)
a108c10b 3233
ad5f9eea
PE
3234 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3235
aec1708a
PE
3236 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3237 to match comment at start of function. This also removes a
3238 GCC warning about overflow in a 32+64-bit port.
3239
47be4ab5
PE
3240 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3241
371cac43
PE
3242 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3243 Reported by Stefan Monnier in
3244 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3245 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3246 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3247
d01a7826
PE
3248 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3249 (EMACS_UINTPTR): Likewise, with uintptr_t.
3250
7fd47d5c
PE
3251 * lisp.h: Prefer 64-bit EMACS_INT if available.
3252 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3253 on 32-bit hosts that have 64-bit int, so that they can access
3254 large files.
122b0c86
PE
3255 However, temporarily disable this change unless the temporary
3256 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3257
8727937b
PE
3258 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3259
8ac068ac
PE
3260 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3261 This removes an assumption that EMACS_INT and long are the same
3262 width as pointers. The assumption is true for Emacs porting targets
3263 now, but we want to make other targets possible.
3264 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3265 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3266 In the rest of the code, change types of integers that hold casted
3267 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3268 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3269 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3270 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3271 No need to cast type when ORing.
3272 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3273 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3274 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3275 assume EMACS_INT is the same width as char *.
3276 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3277 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3278 Remove no-longer-needed casts.
3279 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3280 (xg_tool_bar_help_callback, xg_make_tool_item):
3281 Use EMACS_INTPTR to hold an integer
3282 that will be cast to void *; this can avoid a GCC warning
3283 if EMACS_INT is not the same width as void *.
3284 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3285 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3286 (current_message_1, set_message_1):
3287 Use a local to convert to proper width without a cast.
3288 * xmenu.c (dialog_selection_callback): Likewise.
3289
ede49d71
PE
3290 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3291 Also, don't assume VALBITS / RAND_BITS is less than 5,
3292 and don't rely on undefined behavior when shifting a 1 left into
3293 the sign bit.
3294 * lisp.h (get_random): Change signature to match.
3295
2f30ecd0
PE
3296 * lread.c (hash_string): Use size_t, not int, for hash computation.
3297 Normally we prefer signed values; but hashing is special, because
3298 it's better to use unsigned division on hash table sizes so that
3299 the remainder is nonnegative. Also, size_t is the natural width
3300 for hashing into memory. The previous code used 'int', which doesn't
3301 retain enough info to hash well into very large tables.
3302 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3303
2a866e7b
PE
3304 * dbusbind.c: Don't possibly lose pointer info when converting.
3305 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3306 Use XPNTR rather than XHASH, so that the high-order bits of
3307 the pointer aren't lost when converting through void *.
3308
51639eac
PE
3309 * eval.c (Fautoload): Don't double-shift a pointer.
3310
92394119
PE
3311 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3312
dbdb9a7c
JB
33132011-05-06 Juanma Barranquero <lekktu@gmail.com>
3314
3315 * gnutls.c (DEF_GNUTLS_FN):
3316 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3317
db7a0b4f
AS
33182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3319
3320 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3321 marker. (Bug#8610)
3322
f7ff1b0f 33232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3324
3325 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3326 New version that can reserve upto 2GB of heap space.
3327
f7ff1b0f 33282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3329
3330 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3331
639c109b
TZ
33322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3333
3334 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3335 `gnutls_certificate_set_x509_key_file'.
3336
d2127135
JB
33372011-05-05 Juanma Barranquero <lekktu@gmail.com>
3338
3339 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3340 Update dependencies.
3341
e968f4f3
JB
33422011-05-04 Juanma Barranquero <lekktu@gmail.com>
3343
3344 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3345 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3346 Remove unused parameter `fildes'.
3347 * process.c (read_process_output, send_process): Don't pass it.
3348
84d358f0
JB
33492011-05-04 Juanma Barranquero <lekktu@gmail.com>
3350
3351 Fix previous change: the library cache is defined in w32.c.
3352 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3353 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3354
0898ca10
JB
33552011-05-04 Juanma Barranquero <lekktu@gmail.com>
3356
3357 Implement dynamic loading of GnuTLS on Windows.
3358
3359 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3360 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3361 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3362 Declare.
3363
3364 * gnutls.c (Qgnutls_dll): Define.
3365 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3366 (gnutls_*): Declare function pointers.
3367 (init_gnutls_functions): New function to initialize function pointers.
3368 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3369 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3370 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3371 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3372 (emacs_gnutls_write, emacs_gnutls_read)
3373 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3374 (Fgnutls_available_p): New function.
3375 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3376 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3377 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3378
3379 * image.c: Include w32.h.
3380 (Vimage_type_cache): Delete.
3381 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3382 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3383 (w32_delayed_load): Move to w32.c.
3384
3385 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3386
3387 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3388 (w32_delayed_load): Move from image.c. When loading a library, record
3389 its filename in the :loaded-from property of the library id.
3390 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3391 Initialize and staticpro them.
3392 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3393
3394 * process.c: Include lisp.h before w32.h, not after.
3395 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3396 instead of gnutls_record_check_pending.
3397
3398 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3399
ff4de4aa
TZ
34002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3401
3402 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3403 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3404 as passed in.
3405
abe95abb
JD
34062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3407
3408 * xterm.c (x_set_frame_alpha): Do not set property on anything
3409 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3410
e16e55d4
JB
34112011-05-02 Juanma Barranquero <lekktu@gmail.com>
3412
3413 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3414
bafcf6a5
JB
34152011-05-02 Juanma Barranquero <lekktu@gmail.com>
3416
3417 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3418 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3419 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3420 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3421 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3422 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3423 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3424 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3425 (Qgnutls_bootprop_callbacks_verify): Make static.
3426
e7a6747f
AS
34272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3428
19ed11ba
AS
3429 * callproc.c: Indentation fixup.
3430
e7a6747f 3431 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3432 (wait_for_termination, interruptible_wait_for_termination):
3433 Move after wait_for_termination_1.
e7a6747f 3434
1ef14cb4
LMI
34352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3436
3437 * sysdep.c (interruptible_wait_for_termination): New function
3438 which is like wait_for_termination, but allows keyboard
3439 interruptions.
3440
3441 * callproc.c (Fcall_process): Add (:file "file") as an option for
3442 the STDOUT buffer.
3443 (Fcall_process_region): Ditto.
3444
330d880c
EZ
34452011-04-30 Eli Zaretskii <eliz@gnu.org>
3446
8db90b73
EZ
3447 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3448 rather than `XVECTOR (FOO)->size'.
3449
330d880c
EZ
3450 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3451 inttypes.h, as a gnulib replacement is used if it not available in
3452 system headers.
3453
15cbd324
EZ
34542011-04-21 Eli Zaretskii <eliz@gnu.org>
3455
3456 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3457 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3458 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3459
3460 * coding.c (coding_alloc_by_realloc): Error out if destination
3461 will grow beyond MOST_POSITIVE_FIXNUM.
3462 (decode_coding_emacs_mule): Abort if there isn't enough place in
3463 charbuf for the composition carryover bytes. Reserve an extra
3464 space for up to 2 characters produced in a loop.
3465 (decode_coding_iso_2022): Abort if there isn't enough place in
3466 charbuf for the composition carryover bytes.
3467
34682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3469
ae940cca
EZ
3470 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3471 aborting when %lld or %lll format is passed.
3472 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3473 %llo or %llx format is passed. (Bug#8545)
3474
03ab8921
EZ
3475 * window.c (window_scroll_line_based): Use a marker instead of
3476 simple variables to record original value of point. (Bug#7952)
3477
afda1437
EZ
3478 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3479 produced by %s or %c overflows available buffer space. (Bug#8545)
3480
f76dee0c
PE
34812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3482
3483 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3484 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3485
fdc5744d
JB
34862011-04-28 Juanma Barranquero <lekktu@gmail.com>
3487
3488 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3489
638f053a
JB
34902011-04-28 Juanma Barranquero <lekktu@gmail.com>
3491
3492 * keyboard.c (Qdelayed_warnings_hook): Define.
3493 (command_loop_1): Run `delayed-warnings-hook'
3494 if Vdelayed_warnings_list is non-nil.
3495 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3496 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3497
d178f871
EZ
34982011-04-28 Eli Zaretskii <eliz@gnu.org>
3499
3500 * doprnt.c (doprnt): Don't return value smaller than the buffer
3501 size if the message was truncated. (Bug#8545).
3502
b124fd93
JB
35032011-04-28 Juanma Barranquero <lekktu@gmail.com>
3504
3505 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3506 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3507
e810457d
PE
35082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3509
3510 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3511
ea51cceb
JB
35122011-04-27 Juanma Barranquero <lekktu@gmail.com>
3513
3514 * makefile.w32-in: Update dependencies.
3515
94dcfacf
EZ
35162011-04-27 Eli Zaretskii <eliz@gnu.org>
3517
3518 Improve `doprnt' and its usage. (Bug#8545)
3519 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3520 `format_end'. Remove support for %l as a conversion specifier.
3521 Don't use xrealloc. Improve diagnostics when the %l size modifier
3522 is used. Update the commentary.
3523
3524 * eval.c (verror): Simplify calculation of size_t.
3525
3526 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3527 messages.
3528
f61f41d7
PE
35292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3530
3531 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3532 change.
3533
96fb4434
PE
35342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3535
3536 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3537 This makes this file independent of the recent pseudovector change.
3538
671875da 35392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3540
69e9b5a3
PE
3541 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3542
b5f869a7 3543 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3544 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3545 Remove unused local.
c8926152 3546 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3547
841a1577 3548 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3549 GCC 4.6.0 optimizes based on type-based alias analysis.
3550 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3551 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3552 != &v->size, and therefore "v->size = 1; b->size = 2; return
3553 v->size;" must therefore return 1. This assumption is incorrect
3554 for Emacs, since it type-puns struct Lisp_Vector * with many other
3555 types. To fix this problem, this patch adds a new type struct
f904488f 3556 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3557 and pseudovectors, and helps optimizing compilers not get fooled
3558 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3559 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3560 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3561 the size member.
eab3844f
PE
3562 (XSETPVECTYPE): Rewrite in terms of new macro.
3563 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3564 This is a bit clearer, and further avoids the possibility of
3565 undesirable aliasing.
3566 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3567 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3568 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3569 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3570 (ASIZE): Now uses header.size rather than size.
3571 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3572 to avoid the hassle of writing XVECTOR (foo)->header.size.
3573 (struct vectorlike_header): New type.
eab3844f
PE
3574 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3575 object, to help avoid aliasing.
3576 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3577 (SUBRP): Likewise, since Lisp_Subr is a special case.
3578 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3579 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3580 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3581 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3582 changed to be "header.size" and "header.next".
3583 * buffer.h (struct buffer): Likewise.
3584 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3585 * frame.h (struct frame): Likewise.
3586 * process.h (struct Lisp_Process): Likewise.
3587 * termhooks.h (struct terminal): Likewise.
3588 * window.c (struct save_window_data, struct saved_window): Likewise.
3589 * window.h (struct window): Likewise.
3590 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3591 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3592 * buffer.c (init_buffer_once): Likewise.
3593 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3594 special case.
3595 * process.c (Fformat_network_address): Use local var for size,
3596 for brevity.
3597
0df1eac5
PE
3598 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3599
847ab9d1 3600 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3601 * data.c (atof): Remove decl; no longer used or needed.
3602 (digit_to_number): Move to lread.c.
3603 (Fstring_to_number): Use new string_to_number function, to be
3604 consistent with how the Lisp reader treats infinities and NaNs.
3605 Do not assume that floating-point numbers represent EMACS_INT
3606 without losing information; this is not true on most 64-bit hosts.
3607 Avoid double-rounding errors, by insisting on integers when
3608 parsing non-base-10 numbers, as the documentation specifies.
3609 * lisp.h (string_to_number): New decl, replacing ...
3610 (isfloat_string): Remove.
bc0a5c13 3611 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3612 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3613 appears to have been a coding error. Similarly, do not accept
3614 strings like +-1e0 as floating point numbers. Do not report
3615 overflow for integer overflows unless the base is not 10 which
3616 means we have no simple and reliable way to continue.
3617 Break out the floating-point parsing into a new
3618 function string_to_number, so that Fstring_to_number parses
3619 floating point numbers consistently with the Lisp reader.
04f2d78b 3620 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3621 (E_CHAR, EXP_INT): Remove, replacing with ...
3622 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3623 (string_to_number): New function, replacing isfloat_string.
3624 This function checks for valid syntax and produces the resulting
3625 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3626 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3627 so that overflow for non-base-10 numbers is reported only when
3628 there's no portable and simple way to convert to floating point.
452f4150 3629
67769ffc
PE
3630 * textprop.c (set_text_properties_1): Rewrite for clarity,
3631 and to avoid GCC warning about integer overflow.
3632
c20db43f
PE
3633 * intervals.h (struct interval): Use EMACS_INT for members
3634 where EMACS_UINT might cause problems. See
3635 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3636 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3637 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3638 All uses changed.
37aa2f85
PE
3639 (offset_intervals): Tell GCC not to worry about length overflow
3640 when negating a negative length.
c20db43f 3641
2538aa2f
PE
3642 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3643 (overrun_check_free): Likewise.
3644
f2d3008d
PE
3645 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3646 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3647 word size.
3648
ec8df744
PE
3649 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3650 (gnutls_make_error): Rename local to avoid shadowing.
3651 (gnutls_emacs_global_deinit): ifdef out; not used.
3652 (Fgnutls_boot): Use const for pointer to readonly storage.
3653 Comment out unused local. Fix pointer signedness problems.
3654
640ee02d
PE
3655 * lread.c (openp): Don't stuff size_t into an 'int'.
3656 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3657 about possible signed overflow.
3658
6048fb2a
PE
3659 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3660 (GDK_KEY_g): Don't define if already defined.
3661 (xg_prepare_tooltip): Avoid pointer signedness problem.
3662 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3663
fa3c87e1
PE
3664 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3665 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3666
2172544b
PE
3667 * xfns.c (Fx_window_property): Simplify a bit,
3668 to make a bit faster and to avoid GCC 4.6.0 warning.
3669 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3670
9b821a21
PE
3671 * fns.c (internal_equal): Don't assume size_t fits in int.
3672
3c616cfa
PE
3673 * alloc.c (compact_small_strings): Tighten assertion a little.
3674
c2982e87
PE
3675 Replace pEd with more-general pI, and fix some printf arg casts.
3676 * lisp.h (pI): New macro, generalizing old pEd macro to other
3677 conversion specifiers. For example, use "...%"pI"d..." rather
3678 than "...%"pEd"...".
3679 (pEd): Remove. All uses replaced with similar uses of pI.
3680 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3681 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3682 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3683 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3684 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3685 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3686 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3687 64-bit hosts.
3688 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3689 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3690 * print.c (safe_debug_print, print_object): Likewise.
3691 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3692 to int.
6f04d126
PE
3693 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3694 avoiding the 0 flag, which is not portable.
c2982e87
PE
3695 * process.c (Fmake_network_process): Use pI to avoid cast.
3696 * region-cache.c (pp_cache): Likewise.
3697 * xdisp.c (decode_mode_spec): Likewise.
3698 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3699 behavior on 64-bit hosts with printf arg.
6f04d126 3700 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3701 (x_stop_queuing_selection_requests): Likewise.
3702 (x_get_window_property): Don't truncate byte count to an 'int'
3703 when tracing.
0b432f21 3704
5e073ec7
PE
3705 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3706 here, since it parses constructs like leading '-' and spaces,
3707 which are not wanted; and it overflows with large numbers.
3708 Instead, simply match F[0-9]+, which is what is wanted anyway.
3709
36372bf9
PE
3710 * alloc.c: Remove unportable assumptions about struct layout.
3711 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3712 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3713 (allocate_vectorlike, make_pure_vector): Use the new macros,
3714 plus offsetof, to remove unportable assumptions about struct layout.
3715 These assumptions hold on all porting targets that I know of, but
3716 they are not guaranteed, they're easy to remove, and removing them
3717 makes further changes easier.
3718
0b432f21
PE
3719 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3720 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3721 (string_overrun_cookie): Now const. Use initializers that
3722 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3723 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3724 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3725 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3726 multiple of sizeof (EMACS_INT); it need not be, if
3727 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3728 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3729
895009e1
JB
37302011-04-26 Juanma Barranquero <lekktu@gmail.com>
3731
3732 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3733
6a7a1b0b
TZ
37342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3735
3736 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3737 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3738 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3739
841a1577 37402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3741
3742 * lisp.h (Qdebug): List symbol.
895009e1 3743 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3744 * keyboard.c (debug-on-event): New variable.
3745 (handle_user_signal): Break into debugger when debug-on-event
3746 matches the current signal symbol.
3747
f2d3ba6f
DN
37482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3749
3750 * alloc.c (check_sblock, check_string_bytes)
3751 (check_string_free_list): Convert to standard C.
3752
42ce4c63
TZ
37532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3754
3755 * w32.c (emacs_gnutls_push): Fix typo.
3756
825cd63c
EZ
37572011-04-25 Eli Zaretskii <eliz@gnu.org>
3758
fb11d64d
EZ
3759 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3760 "cast to pointer from integer of different size".
3761
825cd63c
EZ
3762 Improve doprnt and its use in verror. (Bug#8545)
3763 * doprnt.c (doprnt): Document the set of format control sequences
3764 supported by the function. Use SAFE_ALLOCA instead of always
3765 using `alloca'.
3766
3767 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3768 is one byte too soon. Don't use xrealloc; instead xfree and
3769 xmalloc anew.
3770
e061a11b
TZ
37712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3772
3773 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3774 callbacks stage.
3775
3776 * gnutls.c: Renamed global_initialized to
3777 gnutls_global_initialized. Added internals for the
3778 :verify-hostname-error, :verify-error, and :verify-flags
3779 parameters of `gnutls-boot' and documented those parameters in the
3780 docstring. Start callback support.
9173deec
JB
3781 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3782 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3783 on error. Return error code.
e061a11b
TZ
3784 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3785 (emacs_gnutls_read): Likewise.
3786 (Fgnutls_boot): Return handshake error code.
3787 (emacs_gnutls_handle_error): New function.
3788 (wsaerror_to_errno): Likewise.
3789
3790 * w32.h (emacs_gnutls_pull): Add prototype.
3791 (emacs_gnutls_push): Likewise.
3792
3793 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3794 (emacs_gnutls_push): Likewise.
3795
37962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3797
3798 * process.c (wait_reading_process_output): Check if GnuTLS
3799 buffered some data internally if no FDs are set for TLS
3800 connections.
3801
3802 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3803 (LIBS): Link to USER_LIBS.
3804 ($(BLD)/gnutls.$(0)): New target.
3805
fa6996bc
EZ
38062011-04-24 Eli Zaretskii <eliz@gnu.org>
3807
eb35682e
EZ
3808 * xdisp.c (handle_single_display_spec): Rename the
3809 display_replaced_before_p argument into display_replaced_p, to
3810 make it consistent with the commentary. Fix typos in the
3811 commentary.
3812
e2ad650c
EZ
3813 * textprop.c (syms_of_textprop): Remove dead code.
3814 (copy_text_properties): Delete obsolete commentary about an
3815 interface that was deleted long ago. Fix typos in the description
3816 of arguments.
3817
1b2de274
EZ
3818 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3819 to changes in oldXMenu/XMenu.h from 2011-04-16.
3820 <menu_help_message, prev_menu_help_message>: Constify.
3821 (IT_menu_make_room): menu->help_text is now `const char **';
3822 adjust.
3823
3824 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3825 to changes in oldXMenu/XMenu.h from 2011-04-16.
3826 (struct XMenu): Declare `help_text' `const char **'.
3827
3828 * xfaces.c <Qunspecified>: Make extern again.
3829
3830 * syntax.c: Include sys/types.h before including regex.h, as
3831 required by Posix.
3832
762b15be
EZ
3833 * doc.c (get_doc_string): Improve the format passed to `error'.
3834
3835 * doprnt.c (doprnt): Improve commentary.
3836
3837 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3838
3839 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3840 them with etags.
3841
f1052e5d
EZ
3842 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3843 changes in globals.h immediately force recompilation.
762b15be
EZ
3844 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3845 $(CURDIR)/s/ms-w32.h.
3846 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3847
fa6996bc
EZ
3848 * character.c (Fchar_direction): Function deleted.
3849 (syms_of_character): Don't defsubr it.
3850 <char-direction-table>: Deleted.
3851
e6c3da20
EZ
38522011-04-23 Eli Zaretskii <eliz@gnu.org>
3853
3854 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3855 * doprnt.c: Include limits.h.
3856 (SIZE_MAX): New macro.
04f2d78b
CB
3857 (doprnt): Return a size_t value. 2nd arg is now size_t.
3858 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3859 Improve overflow protection. Support `l' modifier for integer
3860 conversions. Support %l conversion. Don't assume an EMACS_INT
3861 argument for integer conversions and for %c.
3862
3863 * lisp.h (doprnt): Restore prototype.
3864
3865 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3866 $(SRC)/character.h.
3867
3868 * Makefile.in (base_obj): Add back doprnt.o.
3869
3870 * deps.mk (doprnt.o): Add back prerequisites.
3871 (callint.o): Depend on character.h.
3872
3873 * eval.c (internal_lisp_condition_case): Include the handler
3874 representation in the error message.
3875 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3876 when breaking from the loop.
3877
3878 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3879
3880 * callint.c (Fcall_interactively): When displaying error message
3881 about invalid control letter, pass the character's codepoint, not
3882 a pointer to its multibyte form. Improve display of the character
3883 in octal and display also its hex code.
3884
3885 * character.c (char_string): Use %x to display the (unsigned)
3886 codepoint of an invalid character, to avoid displaying a bogus
3887 negative value.
3888
3889 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3890 `error', not SYMBOL_NAME itself.
3891
3892 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3893 character arguments to `error'.
3894
3895 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3896 to `error' in error message about FINAL_CHAR argument. Make sure
3897 FINAL_CHAR is a character, and use %c when it is passed as
3898 argument to `error'.
3899
4ffd0d6b 39002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3901
3902 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3903
3904 * w32.c: Include <time.h>.
3905 (sys_localtime): New function.
3906
4ffd0d6b 39072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3908
3909 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3910
4ffd0d6b 3911 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3912
4ffd0d6b 39132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3914
4ffd0d6b
GM
3915 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3916 zombies (Bug#8467).
aac0c6e3 3917
04c56954
EZ
39182011-04-19 Eli Zaretskii <eliz@gnu.org>
3919
3920 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3921 gl_state.e_property when gl_state.object is Qt.
3922
3923 * insdel.c (make_gap_larger): Remove limitation of buffer size
3924 to <= INT_MAX.
3925
16a43933
CY
39262011-04-18 Chong Yidong <cyd@stupidchicken.com>
3927
3928 * xdisp.c (lookup_glyphless_char_display)
3929 (produce_glyphless_glyph): Handle cons cell entry in
3930 glyphless-char-display.
3931 (Vglyphless_char_display): Document it.
3932
3933 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3934 glyphless-char-display.
3935
4581706e
CY
39362011-04-17 Chong Yidong <cyd@stupidchicken.com>
3937
3938 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3939
3940 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3941
3942 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3943 definition for no-X builds.
3944
4887c6e2 39452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3946
fd35b6f9
PE
3947 Static checks with GCC 4.6.0 and non-default toolkits.
3948
5c1ccb01
PE
3949 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3950
006c5daa
PE
3951 * process.c (keyboard_bit_set): Define only if SIGIO.
3952 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3953 (send_process): Repair possible setjmp clobbering.
3954
efc736d3
PE
3955 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3956
4e2fe2e6
PE
3957 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3958
f97334a2
PE
3959 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3960
4e75f29d
PE
3961 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3962 Define only if needed.
3963
90efadd1
PE
3964 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3965 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3966 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3967
3c647824
PE
3968 * dispextern.h (struct redisplay_interface): Rename param
3969 to avoid shadowing.
e264f262 3970 * termhooks.h (struct terminal): Likewise.
761383f4 3971 * xterm.c (xembed_send_message): Likewise.
3c647824 3972
b58c5c4a
PE
3973 * insdel.c (make_gap_smaller): Define only if
3974 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3975
cad59032
PE
3976 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3977 it.
3978
c339dc2e
PE
3979 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3980 so that we aren't warned about unused symbols.
3981
91a3e27b
PE
3982 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3983
399c71d3 3984 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3985
8ffc96f5
PE
3986 * xfns.c (x_real_positions): Mark locals as initialized.
3987
eef9bc79
PE
3988 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3989
098db9dd
PE
3990 * xterm.c: Fix problems found by static analysis with other toolkits.
3991 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3992 (x_dispatch_event): Declare static if USE_GTK, and
3993 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3994 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3995 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3996 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3997 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3998
eb18f6cc
PE
3999 * xmenu.c (menu_help_callback): Pointer type fixes.
4000 Use const pointers when pointing at readonly data. Avoid pointer
4001 signedness clashes.
4002 (FALSE): Remove unused macro.
4003 (update_frame_menubar): Remove unused decl.
4004
1fe72bf8
PE
4005 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4006
60d9e1db
PE
4007 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4008 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4009 (single_menu_item): Rename local to avoid shadowing.
4010
39261c26
PE
4011 * keyboard.c (make_lispy_event): Remove unused local var.
4012
018c5e19
PE
4013 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4014 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4015
63d2b86e
PE
4016 * bitmaps: Change bitmaps from unsigned char back to the X11
4017 compatible char. Avoid the old compiler warnings about
4018 out-of-range initializers by using, for example, '\xab' rather
4019 than 0xab.
4020
aefd87e1
PE
4021 * xgselect.c (xgselect_initialize): Check vs interface
4022 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4023
bf501fb9
PE
4024 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4025
e9829fdf
PE
4026 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4027 to read-only memory.
4028
1086c095
PE
4029 * fns.c (vector): Remove; this old hack is no longer needed.
4030
2baccd04 4031 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4032 Remove unused var.
dde42981 4033 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4034
72391843 4035 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4036
436c16df 4037 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4038 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4039 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4040
92bb796d 4041 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4042 (x_term_init): Remove local to avoid shadowing.
92bb796d 4043
764430a3 4044 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4045
4046 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4047 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4048
d1dfb56c
EZ
40492011-04-16 Eli Zaretskii <eliz@gnu.org>
4050
c4354cb4
EZ
4051 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4052
d1dfb56c
EZ
4053 Fix regex.c, syntax.c and friends for buffers > 2GB.
4054 * syntax.h (struct gl_state_s): Declare character position members
4055 EMACS_INT.
4056
4057 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4058
04f2d78b
CB
4059 * textprop.c (verify_interval_modification, interval_of):
4060 Declare arguments EMACS_INT.
d1dfb56c
EZ
4061
4062 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4063 EMACS_INT.
4064
4065 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4066
4067 * indent.c (Fvertical_motion): Local variable it_start is now
4068 EMACS_INT.
4069
4070 * regex.c (re_match, re_match_2, re_match_2_internal)
4071 (bcmp_translate, regcomp, regexec, print_double_string)
4072 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4073 (re_compile_pattern, re_exec): Declare arguments and local
4074 variables `size_t' and `ssize_t' and return values `regoff_t', as
4075 appropriate.
4076 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4077 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4078 <compile_stack_type>: `size' and `avail' are now `size_t'.
4079
4080 * regex.h <regoff_t>: Use ssize_t, not int.
4081 (re_search, re_search_2, re_match, re_match_2): Arguments that
4082 specify buffer/string position and length are now ssize_t and
4083 size_t. Return type is regoff_t.
4084
613052cd
BK
40852011-04-16 Ben Key <bkey76@gmail.com>
4086
4087 * nsfont.m: Fixed bugs in ns_get_family and
4088 ns_descriptor_to_entity that were caused by using free to
4089 deallocate memory blocks that were allocated by xmalloc (via
4090 xstrdup). This caused Emacs to crash when compiled with
4091 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4092 --enable-checking=xmallocoverrun). xfree is now used to
4093 deallocate these memory blocks.
4094
4170f62f 40952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4096
71b41406
PE
4097 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4098
9587a89d
PE
4099 emacs_write: Accept and return EMACS_INT for sizes.
4100 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4101 et seq.
4102 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4103 Accept and return EMACS_INT.
4104 (emacs_gnutls_write): Return the number of bytes written on
4105 partial writes.
4106 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4107 (emacs_read, emacs_write): Remove check for negative size, as the
4108 Emacs source code has been audited now.
9587a89d
PE
4109 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4110 (emacs_read, emacs_write): Use it.
273a5f82
PE
4111 * process.c (send_process): Adjust to the new signatures of
4112 emacs_write and emacs_gnutls_write. Do not attempt to store
4113 a byte offset into an 'int'; it might overflow.
9587a89d 4114 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4115
3e047f51
PE
4116 * sound.c: Don't assume sizes fit in 'int'.
4117 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4118 Return EMACS_INT, not int.
3e047f51 4119 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4120 Accept EMACS_INT, not int.
4121 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4122 record read return values.
4123
cc39a9db
BK
41242011-04-15 Ben Key <bkey76@gmail.com>
4125
c9d0ec6d
JB
4126 * keyboard.c (Qundefined): Don't declare static since it is used
4127 in nsfns.m.
4128 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4129 static since they are used in nsfont.m.
cc39a9db 4130
6c60eb9f
SM
41312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4132
4133 * process.c (Qprocessp): Don't declare static.
4134 * lisp.h (Qprocessp): Declare again.
4135
7990b61a
JB
41362011-04-15 Juanma Barranquero <lekktu@gmail.com>
4137
4138 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4139
5d4cb038
PE
41402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4141
8bd7b830 4142 Improve C-level modularity by making more things 'static'.
cd64ea1d 4143
e3b27b31
PE
4144 Don't publish debugger-only interfaces to other modules.
4145 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4146 (verify_bytepos, count_markers): Move decls to the only modules
4147 that need them.
4148 * region-cache.h (pp_cache): Likewise.
4149 * window.h (check_all_windows): Likewise.
4150 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4151
5d4cb038
PE
4152 * sysdep.c (croak): Now static, if
4153 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4154 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4155
4156 * alloc.c (refill_memory_reserve): Now static if
4157 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4158 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4159
e87b6180
PE
4160 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4161 Define only if USE_LUCID.
4162
ac64929e
PE
4163 * xrdb.c (x_customization_string, x_rm_string): Now static.
4164
6f37259d
PE
4165 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4166 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4167
1683e3ab
PE
4168 * xdisp.c (draw_row_with_mouse_face): Now static.
4169 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4170
de9c2632
PE
4171 * window.h (check_all_windows): Mark externally visible.
4172
2b96acb7
PE
4173 * window.c (window_deletion_count): Now static.
4174
4175 * undo.c: Make symbols static if they're not exported.
4176 (last_undo_buffer, last_boundary_position, pending_boundary):
4177 Now static.
4178
50436f33
PE
4179 * textprop.c (interval_insert_behind_hooks): Now static.
4180 (interval_insert_in_front_hooks): Likewise.
4181
64520e5c
PE
4182 * term.c: Make symbols static if they're not exported.
4183 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4184 (max_frame_lines, tty_set_terminal_modes):
4185 (tty_reset_terminal_modes, tty_turn_off_highlight):
4186 (get_tty_terminal): Now static.
4187 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4188 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4189 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4190 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4191 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4192
1fa53021
PE
4193 * sysdep.c: Make symbols static if they're not exported.
4194 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4195 Now static.
4196 (sigprocmask_set, full_mask): Remove; unused.
4197 (wait_debugging): Mark as visible.
4198 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4199 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4200
d4b43b22
PE
4201 * syntax.c (syntax_temp): Define only if !__GNUC__.
4202
b7c513d0
PE
4203 * sound.c (current_sound_device, current_sound): Now static.
4204
989b29ad
PE
4205 * search.c (searchbufs, searchbuf_head): Now static.
4206
13a55a78
PE
4207 * scroll.c (scroll_cost): Remove; unused.
4208 * dispextern.h (scroll_cost): Remove decl.
4209
de68a1fc
PE
4210 * region-cache.h (pp_cache): Mark as externally visible.
4211
40ccffa6
PE
4212 * process.c: Make symbols static if they're not exported.
4213 (process_tick, update_tick, create_process, chan_process):
4214 (Vprocess_alist, proc_buffered_char, datagram_access):
4215 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4216 (deactivate_process): Mark defn as static, as well as decl.
4217 * lisp.h (create_process): Remove decl.
4218 * process.h (chan_process, Vprocess_alist): Remove decls.
4219
ad64fc97
PE
4220 * print.c: Make symbols static if they're not exported.
4221 (print_depth, new_backquote_output, being_printed, print_buffer):
4222 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4223 (print_interval, print_number_index, initial_stderr_stream):
4224 Now static.
4225 * lisp.h (Fprinc): Remove decl.
4226 (debug_output_compilation_hack): Mark as externally visible.
4227
adddb265
PE
4228 * sysdep.c (croak): Move decl from here to syssignal.h.
4229 * syssignal.h (croak): Put it here, so the API can be checked when
4230 'croak' is called from dissociate_if_controlling_tty.
4231
1717ede2
PE
4232 * minibuf.c: Make symbols static if they're not exported.
4233 (minibuf_save_list, choose_minibuf_frame): Now static.
4234 * lisp.h (choose_minibuf_frame): Remove decl.
4235
fa5fb2bc
PE
4236 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4237
1e3890d1
PE
4238 * lread.c: Make symbols static if they're not exported.
4239 (read_objects, initial_obarray, oblookup_last_bucket_number):
4240 Now static.
4241 (make_symbol): Remove; unused.
4242 * lisp.h (initial_obarray, make_symbol): Remove decls.
4243
8a1414fa
PE
4244 * keyboard.c: Make symbols static if they're not exported.
4245 (single_kboard, recent_keys_index, total_keys, recent_keys):
4246 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4247 (this_single_command_key_start, echoing, last_auto_save):
4248 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4249 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4250 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4251 (Vlispy_mouse_stem, double_click_count):
4252 Now static.
4253 (force_auto_save_soon): Define only if SIGDANGER.
4254 (ignore_mouse_drag_p): Now static if
4255 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4256 (print_help): Remove; unused.
4257 (stop_character, last_timer_event): Mark as externally visible.
4258 * keyboard.h (ignore_mouse_drag_p): Declare only if
4259 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4260 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4261 * lisp.h (echoing): Remove decl.
4262 (force_auto_save_soon): Declare only if SIGDANGER.
4263 * xdisp.c (redisplay_window): Simplify code, to make it more
4264 obvious that ignore_mouse_drag_p is not accessed if !defined
4265 USE_GTK && !defined HAVE_NS.
4266
93ea6e8f
PE
4267 * intervals.c: Make symbols static if they're not exported.
4268 (merge_properties_sticky, merge_interval_right, delete_interval):
4269 Now static.
4270 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4271
77382fcc
PE
4272 * insdel.c: Make symbols static if they're not exported.
4273 However, leave prepare_to_modify_buffer alone. It's never
4274 called from outside this function, but that appears to be a bug.
4275 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4276 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4277 (adjust_after_replace_noundo): Remove; unused.
4278 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4279 (signal_before_change): Remove decls.
77382fcc 4280
9306c32e
PE
4281 * indent.c (val_compute_motion, val_vmotion): Now static.
4282
cd44d2eb
PE
4283 * image.c: Make symbols static if they're not exported.
4284 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4285 if USE_GTK.
4286 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4287 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4288
ad9a7a06
PE
4289 * fringe.c (standard_bitmaps): Now static.
4290 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4291
81626931
PE
4292 * frame.c: Make symbols static if they're not exported.
4293 (x_report_frame_params, make_terminal_frame): Now static.
4294 (get_frame_param): Now static, unless HAVE_NS.
4295 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4296 (x_get_resource_string): Remove; not used.
4297 * frame.h (make_terminal_frame, x_report_frame_params):
4298 (x_get_resource_string); Remove decls.
4299 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4300 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4301
239f9db9
PE
4302 * font.c, fontset.c: Make symbols static if they're not exported.
4303 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4304 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4305 * font.c (font_close_object): Now static.
4306 * font.h (font_close_object): Remove.
4307 * fontset.c (FONTSET_OBJLIST): Remove.
4308 (free_realized_fontset) #if-0 the body, which does nothing.
4309 (face_suitable_for_char_p): #if-0, as it's never called.
4310 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4311 * xfaces.c (face_at_string_position):
4312 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4313 since 0 is always ASCII.
4314
dfcf3579
PE
4315 * fns.c (weak_hash_tables): Now static.
4316
5045092b
PE
4317 * fileio.c: Make symbols static if they're not exported.
4318 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4319 (Vwrite_region_annotation_buffers): Now static.
4320
57a96f5c
PE
4321 * eval.c: Make symbols static if they're not exported.
4322 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4323 * lisp.h (backtrace_list): Remove decl.
4324
35f08c38
PE
4325 * emacs.c: Make symbols static if they're not exported.
4326 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4327 (fatal_error_code, fatal_error_signal_hook, standard_args):
4328 Now static.
4329 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4330 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4331 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4332 * lisp.h (fatal_error_signal_hook): Remove decl.
4333 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4334
f44bd759
PE
4335 * editfns.c: Move a (normally-unused) function to its only use.
4336 * editfns.c, lisp.h (get_operating_system_release): Remove.
4337 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4338 worth the hassle of breaking this out.
4339
b532497d
PE
4340 * xterm.c: Make symbols static if they're not exported.
4341 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4342 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4343 (x_destroy_window, x_delete_display):
4344 Now static.
4345 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4346 (x_mouse_leave): Remove; unused.
4347 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4348 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4349 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4350 Remove decls.
4351 (x_mouse_leave): Declare only if WINDOWSNT.
4352 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4353 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4354 USE_X_TOOLKIT.
4355
1675728f
PE
4356 * ftxfont.c: Make symbols static if they're not exported.
4357 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4358 HAVE_FREETYPE.
4359 * font.h (ftxfont_driver): Likewise.
4360
e4cebfca
PE
4361 * xfns.c: Make symbols static if they're not exported.
4362 (x_last_font_name, x_display_info_for_name):
4363 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4364 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4365 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4366 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4367 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4368 (last_show_tip_args): Now static.
4369 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4370 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4371 (x_screen_planes): Remove; unused.
4372 * dispextern.h (x_screen_planes): Remove decl.
4373
5bf46f05
PE
4374 * dispnew.c: Make symbols static if they're not exported.
4375 * dispextern.h (redraw_garbaged_frames, scrolling):
4376 (increment_row_positions): Remove.
4377 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4378 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4379 Now static.
4380 (redraw_garbaged_frames): Remove; unused.
4381
435f4c28
PE
4382 * xfaces.c: Make symbols static if they're not exported.
4383 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4384 Remove decls.
4385 * xterm.h (defined_color): Remove decls.
4386 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4387 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4388 (menu_face_changed_default, defined_color, free_realized_face):
4389 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4390 (ascii_face_of_lisp_face): Remove; unused.
4391
8524aef3
PE
4392 * xdisp.c: Make symbols static if they're not exported.
4393 * dispextern.h (scratch_glyph_row, window_box_edges):
4394 (glyph_to_pixel_coords, set_cursor_from_row):
4395 (get_next_display_element, set_iterator_to_next):
4396 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4397 (show_mouse_face): Remove decls
4398 * frame.h (message_buf_print): Likewise.
4399 * lisp.h (pop_message, set_message, check_point_in_composition):
4400 Likewise.
4401 * xterm.h (set_vertical_scroll_bar): Likewise.
4402 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4403 (message_buf_print, scratch_glyph_row, displayed_buffer):
4404 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4405 (get_next_display_element, show_mouse_face, window_box_edges):
4406 (frame_to_window_pixel_xy, check_point_in_composition):
4407 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4408 (glyph_to_pixel_coords): Remove; unused.
4409
16390cd2
PE
4410 * dired.c (file_name_completion): Now static.
4411
4412 * dbusbind.c (xd_in_read_queued_messages): Now static.
4413
a25f4dfa
PE
4414 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4415 * data.c (circular_list_error): Remove.
4416
14a9c8df
PE
4417 * commands.h (last_point_position, last_point_position_buffer):
4418 (last_point_position_window): Remove decls.
4419 * keyboard.c: Make these variables static.
4420
04f2d78b
CB
4421 * coding.h (coding, code_convert_region, encode_coding_gap):
4422 Remove decls.
74ab6df5
PE
4423 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4424 (iso_code_class, detect_coding, code_convert_region): Now static.
4425 (encode_coding_gap): Remove; unused.
4426
38dfbee1
PE
4427 * chartab.c (chartab_chars, chartab_bits): Now static.
4428
a2cb4e63
PE
4429 * charset.h (charset_iso_8859_1): Remove decl.
4430 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4431 Now static.
4432
127198fd
PE
4433 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4434 * ccl.c (Vccl_program_table): Now static.
4435 (check_ccl_update): Remove; unused.
4436
d85b608f
PE
4437 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4438 * category.h: ... from here.
4439 * category.c (check_category_table, set_category_set): Now static.
4440
31cd66f3
PE
4441 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4442 * lisp.h: Remove these decls.
4443
c358e587
PE
4444 * buffer.c (buffer_count): Remove unused var.
4445
e78aecca
PE
4446 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4447 so that it's not optimized away.
4448 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4449 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4450 exported only to the debugger.
4451
e192d7d3 4452 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4453 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4454
92470028
PE
4455 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4456 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4457 was inaccessible from Lisp.
4458 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4459 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4460
244ed907
PE
4461 alloc.c: Import and export fewer symbols, and remove unused items.
4462 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4463 is defined.
4464 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4465 it's not optimized away by whole-program optimization.
4466 (message_enable_multibyte, free_misc): Remove.
4467 (catchlist, handlerlist, mark_backtrace):
4468 Declare only if BYTE_MARK_STACK.
4469 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4470 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4471 (message_enable_multibyte): Remove decl.
4472 (free_misc, interval_free_list, float_block, float_block_index):
4473 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4474 (cons_free_list, last_marked_index):
4475 Now static.
4476 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4477 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4478 (mark_backtrace): Define only if BYTE_MARK_STACK.
4479 * xdisp.c (message_enable_multibyte): Now static.
4480
61c2b50e 4481 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4482 This makes it easier for human readers (and static analyzers)
4483 to see whether these variables are used from other modules.
4484 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4485 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4486 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4487 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4488 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4489 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4490 * xmenu.c, xselect.c:
4491 Declare Q* vars static if they are not used in other modules.
4492 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4493 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4494 Remove decls of unexported vars.
4495 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4496
95c82688
PE
4497 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4498
16a97296
PE
4499 Make Emacs functions such as Fatom 'static' by default.
4500 This makes it easier for human readers (and static analyzers)
4501 to see whether these functions can be called from other modules.
4502 DEFUN now defines a static function. To make the function external
4503 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4504 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4505 (Finit_image_library):
16a97296
PE
4506 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4507 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4508 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4509 Remove decls, since these functions are now static.
4510 (Funintern, Fget_internal_run_time): New decls, since these functions
4511 were already external.
95c82688 4512
16a97296
PE
4513 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4514 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4515 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4516 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4517 * keyboard.c, keymap.c, lread.c:
4518 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4519 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4520 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4521 Mark functions with DEFUE instead of DEFUN,
4522 if they are used in other modules.
4523 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4524 decls for now-static functions.
4525 * buffer.h (Fdelete_overlay): Remove decl.
4526 * callproc.c (Fgetenv_internal): Mark as internal.
4527 * composite.c (Fremove_list_of_text_properties): Remove decl.
4528 (Fcomposition_get_gstring): New forward static decl.
4529 * composite.h (Fcomposite_get_gstring): Remove decl.
4530 * dired.c (Ffile_attributes): New forward static decl.
4531 * doc.c (Fdocumntation_property): New forward static decl.
4532 * eval.c (Ffetch_bytecode): New forward static decl.
4533 (Funintern): Remove extern decl; now in .h file where it belongs.
4534 * fileio.c (Fmake_symbolic_link): New forward static decl.
4535 * image.c (Finit_image_library): New forward static decl.
4536 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4537 * intervals.h (Fprevious_property_change):
4538 (Fremove_list_of_text_properties): Remove decls.
4539 * keyboard.c (Fthis_command_keys): Remove decl.
4540 (Fcommand_execute): New forward static decl.
4541 * keymap.c (Flookup_key): New forward static decl.
4542 (Fcopy_keymap): Now static.
4543 * keymap.h (Flookup_key): Remove decl.
4544 * process.c (Fget_process): New forward static decl.
4545 (Fprocess_datagram_address): Mark as internal.
4546 * syntax.c (Fsyntax_table_p): New forward static decl.
4547 (skip_chars): Remove duplicate decl.
4548 * textprop.c (Fprevious_property_change): New forward static decl.
4549 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4550 Now internal.
4551 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4552 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4553
785bbd42
PE
4554 * editfns.c (Fformat): Remove unreachable code.
4555
8b913b57
AS
45562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4557
4558 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4559 change. (Bug#8496)
4560
a6744a35
EZ
45612011-04-13 Eli Zaretskii <eliz@gnu.org>
4562
4563 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4564 when at ZV. (Bug#8487)
4565
e7974947
AS
45662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4567
baad03f0
AS
4568 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4569 (Bug#8437)
4570 * keyboard.c (parse_tool_bar_item): Likewise.
4571 * sound.c (sound_cleanup, alsa_close): Likewise.
4572 * termcap.c (tgetent): Likewise.
4573 * xfns.c (x_default_font_parameter): Likewise.
4574 * xsettings.c (read_and_apply_settings): Likewise.
4575
e7974947
AS
4576 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4577 (overrun_check_free): Protoize.
4578
28272684
PE
45792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4580
4581 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4582 since callers should never pass a negative size.
4583 Change the signature to match that of plain 'read' and 'write'; see
4584 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4585 * lisp.h: Update prototypes of emacs_write and emacs_read.
4586
11997c76
EZ
45872011-04-11 Eli Zaretskii <eliz@gnu.org>
4588
4589 * xdisp.c (redisplay_window): Don't try to determine the character
4590 position of the scroll margin if the window start point w->startp
e896f03c 4591 is outside the buffer's accessible region. (Bug#8468)
11997c76 4592
8a2cbd72
EZ
45932011-04-10 Eli Zaretskii <eliz@gnu.org>
4594
4595 Fix write-region and its subroutines for buffers > 2GB.
4596 * fileio.c (a_write, e_write): Modify declaration of arguments and
4597 local variables to support buffers larger than 2GB.
4598 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4599
4600 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4601 argument, local variables, and return value.
4602
4603 * lisp.h: Update prototypes of emacs_write and emacs_read.
4604
4605 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4606
4073e537 46072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4608
1ebfdcb6
PE
4609 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4610
b2ded58d
PE
4611 Fix more problems found by GCC 4.6.0's static checks.
4612
7d66342c
PE
4613 * xdisp.c (vmessage): Use a better test for character truncation.
4614
bbf47d44
PE
4615 * charset.c (load_charset_map): <, not <=, for optimization,
4616 and to avoid potential problems with integer overflow.
9248994d 4617 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4618 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4619 * editfns.c (Fformat): Likewise.
1e69125e 4620 * syntax.c (skip_chars): Likewise.
3befa583 4621
e3019616
PE
4622 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4623 This also lets GCC 4.6.0 generate slightly better loop code.
4624
becfa255
PE
4625 * callint.c (Fcall_interactively): <, not <=, for optimization.
4626 (Fcall_interactively): Count the number of arguments produced,
4627 not the number of arguments given. This is simpler and lets GCC
4628 4.6.0 generate slightly better code.
4629
dae0cd48
PE
4630 * ftfont.c: Distingish more carefully between FcChar8 and char.
4631 The previous code passed unsigned char * to a functions like
4632 strlen and xstrcasecmp that expect char *, which does not
4633 conform to the C standard.
4634 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4635 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4636 char * when the C standard requires it.
4637
76032d70
PE
4638 * keyboard.c (read_char): Remove unused var.
4639
eb3f1cc8
PE
4640 * eval.c: Port to Windows vsnprintf (Bug#8435).
4641 Include <limits.h>.
4642 (SIZE_MAX): Define if the headers do not.
4643 (verror): Do not give up if vsnprintf returns a negative count.
4644 Instead, grow the buffer. This ports to Windows vsnprintf, which
4645 does not conform to C99. Problem reported by Eli Zaretskii.
4646 Also, simplify the allocation scheme, by avoiding the need for
4647 calling realloc, and removing the ALLOCATED variable.
4648
70476b54
PE
4649 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4650
12020a9e
PE
4651 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4652 But keep the doprint source code for now, as we might revamp it
4653 and use it again (Bug#8435).
ea6c7ae6
PE
4654 * lisp.h (doprnt): Remove.
4655 * Makefile.in (base_obj): Remove doprnt.o.
4656 * deps.mk (doprnt.o): Remove.
4657
5fdb398c
PE
4658 error: Print 32- and 64-bit integers portably (Bug#8435).
4659 Without this change, on typical 64-bit hosts error ("...%d...", N)
4660 was used to print both 32- and 64-bit integers N, which relied on
4661 undefined behavior.
4662 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4663 New macro.
4664 * lisp.h (error, verror): Mark as printf-like functions.
4665 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4666 Report overflow in size calculations when allocating printf buffer.
4667 Do not truncate output string at its first null byte.
4668 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4669 Truncate the output at a character boundary, since vsnprintf does not
4670 do that.
4671 * charset.c (check_iso_charset_parameter): Convert internal
4672 character to string before calling 'error', since %c now has the
4673 printf meaning.
4674 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4675 overflow when computing char to be passed to 'error'. Do not
4676 pass Lisp_Object to 'error'; pass the integer instead.
4677 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4678 formatted with plain %d.
4679
b189fa66
PE
4680 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4681
bff87ef0
PE
4682 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4683
7e2cac20
PE
4684 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4685
ce4d90b5
PE
4686 * xterm.c (x_catch_errors): Remove duplicate declaration.
4687
266c9547
PE
4688 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4689
79c49ad2
PE
4690 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4691
368f4090
JM
46922011-04-10 Jim Meyering <meyering@redhat.com>
4693
4694 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4695 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4696 return ssize_t not "int", and use size_t as the buffer length.
4697 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4698 * gnutls.h: Update declarations.
4699 * process.c (read_process_output): Use ssize_t, to match.
4700 (send_process): Likewise.
4701
a32d4040
CY
47022011-04-09 Chong Yidong <cyd@stupidchicken.com>
4703
4704 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4705
8546720e 47062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4707
04f2d78b
CB
4708 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4709 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4710
8546720e
GM
4711 * xterm.c (handle_one_xevent):
4712 * xmenu.c (create_and_show_popup_menu):
4713 * xselect.c (x_decline_selection_request)
4714 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4715
0a2f5c1a 47162011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4717
4718 Fix some uses of `int' instead of EMACS_INT.
4719 * search.c (string_match_1, fast_string_match)
4720 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4721 (scan_buffer, find_next_newline_no_quit)
4722 (find_before_next_newline, search_command, Freplace_match)
4723 (Fmatch_data): Make some `int' variables be EMACS_INT.
4724
4725 * xdisp.c (display_count_lines): 3rd argument and return value now
4726 EMACS_INT. All callers changed.
4727 (pint2hrstr): Last argument is now EMACS_INT.
4728
4729 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4730 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4731 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4732 (decode_coding_utf_16, decode_coding_emacs_mule)
4733 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4734 (decode_coding_ccl, decode_coding_charset)
4735 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4736 (decode_coding_iso_2022, decode_coding_emacs_mule)
4737 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4738 <char_offset, last_offset>: Declare EMACS_INT.
4739 (encode_coding_utf_8, encode_coding_utf_16)
4740 (encode_coding_emacs_mule, encode_invocation_designation)
4741 (encode_designation_at_bol, encode_coding_iso_2022)
4742 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4743 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4744 Declare EMACS_INT.
4745 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4746 (encode_invocation_designation): Last argument P_NCHARS is now
4747 EMACS_INT.
4748 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4749 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4750
4751 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4752 All users changed.
4753
4754 * ccl.c (Fccl_execute_on_string): Declare some variables
4755 EMACS_INT.
4756
8546720e 47572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4758
4759 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4760
4e19a977
CS
47612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4762
4763 * process.c (Fformat_network_address): Doc fix.
4764
87302331
R
47652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4766
4767 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4768
cbb59342
CY
47692011-04-08 Chong Yidong <cyd@stupidchicken.com>
4770
4771 * keyboard.c (read_char): Call Lisp function help-form-show,
4772 instead of using internal_with_output_to_temp_buffer.
4773 (Qhelp_form_show): New var.
e0d38eeb 4774 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4775
4776 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4777
4778 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4779
e67a13ab
CY
47802011-04-06 Chong Yidong <cyd@stupidchicken.com>
4781
04f2d78b
CB
4782 * process.c (Flist_processes): Remove to Lisp.
4783 (list_processes_1): Delete.
e67a13ab 4784
973f782d
EZ
47852011-04-06 Eli Zaretskii <eliz@gnu.org>
4786
7c106b1e
EZ
4787 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4788
973f782d
EZ
4789 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4790
41cf7d1a 47912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4792
ca23cc88
PE
4793 Fix more problems found by GCC 4.6.0's static checks.
4794
f390e2d5
PE
4795 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4796
42eea0d0
PE
4797 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4798
b69769da 4799 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4800
f9541e84
PE
4801 * xdisp.c (vmessage): Mark as a printf-like function.
4802
13841b55
PE
4803 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4804
c136c10f
PE
4805 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4806
5e2d4a30
PE
4807 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4808 printf-like functions.
4809 (tiff_load): Add casts to remove these marks before passing them
4810 to system-supplied API.
4811
583f48b9
PE
4812 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4813
b25d760e
PE
4814 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4815 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4816 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4817 directly, rather than having caller test rule sign. This avoids
4818 some unnecessary tests.
4819 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4820 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4821 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4822
bc7b6697 4823 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4824 (xfont_open): Avoid unnecessary tests.
bc7b6697 4825
27ccc379
PE
4826 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4827
dcd5c89a
PE
4828 * composite.h, composite.c (composition_gstring_put_cache):
4829 Use EMACS_INT, not int, for length.
4830
b13a45c6
PE
4831 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4832 breaking out part of COMPOSITION_DECODE_RULE.
4833 (COMPOSITION_DECODE_RULE): Use it.
4834 * composite.c (get_composition_id): Remove unused local vars,
4835 by using the new macro.
4836
1e792e4d
PE
4837 * textprop.c (set_text_properties_1): Change while to do-while,
4838 since the condition is always true at first.
4839
dc6c6455 4840 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4841 (interval_deletion_adjustment): Return unsigned value.
4842 All uses changed.
dc6c6455 4843
aba7731a
PE
4844 * process.c (list_processes_1, create_pty, read_process_output):
4845 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4846 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4847 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4848 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4849 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4850
fdfc4bf3
PE
4851 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4852
fca8fe46 4853 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4854 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4855
06a0259a 4856 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4857 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4858 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4859
e7b9e80f
PE
4860 * print.c (print_error_message): Avoid int overflow.
4861
56201685
PE
4862 * font.c (font_list_entities): Redo for clarity,
4863 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4864
78834453 4865 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4866 (font_score): Avoid potential overflow in diff calculation.
78834453 4867
0bc0b309 4868 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4869 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4870
e610eaca
PE
4871 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4872
b895abce
PE
4873 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4874 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4875 can always succeed if overflow has undefined behavior.
4876
1f1d9321 4877 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4878 (wordify): Omit three unnecessary tests.
1f1d9321 4879
c59478bc
PE
4880 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4881 All callers changed. This avoids the need for an unused var.
4882
79b73827
PE
4883 * casefiddle.c (casify_region): Remove var that is set but not used.
4884
a4db5dfe
PE
4885 * dired.c (file_name_completion): Remove var that is set but not used.
4886
43aae36e
PE
4887 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4888
2a47c44d 4889 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4890 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4891
a37c69bf
PE
4892 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4893 Check for integer overflow on size calculations.
4894
328ab8e7
PE
4895 * buffer.c (Fprevious_overlay_change): Remove var that is set
4896 but not used.
4897
e5a2a5cb
PE
4898 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4899 Remove vars that are set but not used.
8d84a6eb 4900 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4901 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4902
a60e5f68
PE
4903 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4904
f661cb61 4905 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4906 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4907
f0397f5a
PE
4908 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4909 that are set but not used.
4910
8664db06 4911 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4912 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4913
6abdaa4a
PE
4914 * xselect.c (x_get_local_selection, x_handle_property_notify):
4915 Remove vars that are set but not used.
4916
0ce7538d 4917 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4918 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4919
9ae848fc
PE
4920 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4921 Remove var that is set but not used.
0b918413
PE
4922 (scroll_bar_windows_size): Now size_t, not int.
4923 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4924 Check for overflow.
9ae848fc 4925
a5a62657
PE
4926 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4927 (map_tty_color) [!defined MSDOS]: Likewise.
4928
5c5cdd39
PE
4929 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4930
66ebf983
PE
4931 * coding.c: Remove vars that are set but not used.
4932 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4933 All callers changed.
4934 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4935 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4936 (decode_coding_charset): Remove vars that are set but not used.
4937
1be4d761
PE
4938 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4939 that is set but not used.
4940
47553fa8
PE
4941 * print.c (print_object): Remove var that is set but not used.
4942
1f7196bf 4943 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4944 The gnulib version avoids calling malloc in the usual case,
4945 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4946 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4947 * filelock.c (current_lock_owner): Likewise.
4948 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4949 * sysdep.c: Include allocator.h, careadlinkat.h.
4950 (emacs_no_realloc_allocator): New static constant.
4951 (emacs_readlink): New function.
fdb61804
PE
4952 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4953 ../lib/careadlinkat.h.
d1fdcab7 4954
f84c17c7
SM
49552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4956
4957 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4958 first non-nil return value).
4959
ef3862ad
JD
49602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4961
4962 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4963 if not defined (Bug#8403).
4964
376a7006
JB
49652011-04-02 Juanma Barranquero <lekktu@gmail.com>
4966
4967 * xdisp.c (display_count_lines): Remove parameter `start',
4968 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4969 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4970 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4971 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4972 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4973 and thereabouts. All callers changed.
4974 (get_per_char_metric): Remove parameter `f', unused since
4975 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4976
6ca3801d
JM
49772011-04-02 Jim Meyering <meyering@redhat.com>
4978
4979 do not dereference NULL upon failed strdup
4980 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4981 (ns_get_family): Likewise.
4982
d8e2b5ba
JB
49832011-04-02 Juanma Barranquero <lekktu@gmail.com>
4984
4985 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4986
8c74fcbd
JD
49872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4988
4989 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4990 later (Bug#8403).
4991
7200d79c
SM
49922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4993
03408648 4994 Add lexical binding.
7200d79c 4995
03408648
SM
4996 * window.c (Ftemp_output_buffer_show): New fun.
4997 (Fsave_window_excursion):
4998 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4999
5000 * lread.c (lisp_file_lexically_bound_p): New function.
5001 (Fload): Bind Qlexical_binding.
5002 (readevalloop): Remove `evalfun' arg.
5003 Bind Qinternal_interpreter_environment.
5004 (Feval_buffer): Bind Qlexical_binding.
5005 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5006 Mark as dynamic.
5007 (syms_of_lread): Declare `lexical-binding'.
5008
5009 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5010
5011 * keyboard.c (eval_dyn): New fun.
5012 (menu_item_eval_property): Use it.
ca105506
SM
5013
5014 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5015
03408648
SM
5016 * fns.c (concat, mapcar1): Accept byte-code-functions.
5017
5018 * eval.c (Fsetq): Handle lexical vars.
5019 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5020 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5021 (FletX, Flet): Obey lexical binding.
5022 (Fcommandp): Handle closures.
5023 (Feval): New `lexical' arg.
5024 (eval_sub): New function extracted from Feval. Use it almost
5025 everywhere where Feval was used. Look up vars in lexical env.
5026 Handle closures.
5027 (Ffunctionp): Move from subr.el.
5028 (Ffuncall): Handle closures.
5029 (apply_lambda): Remove `eval_flags'.
5030 (funcall_lambda): Handle closures and new byte-code-functions.
5031 (Fspecial_variable_p): New function.
5032 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5033 but without exporting it to Lisp.
23aba0ea 5034
23aba0ea 5035 * doc.c (Fdocumentation, store_function_docstring):
03408648 5036 * data.c (Finteractive_form): Handle closures.
23aba0ea 5037
03408648
SM
5038 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5039 interactive spec.
ba83908c 5040
04f2d78b
CB
5041 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5042 New byte-codes.
03408648
SM
5043 (exec_byte_code): New function extracted from Fbyte_code to handle new
5044 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5045
03408648 5046 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5047
03408648 5048 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5049
e2abce01
JB
50502011-03-31 Juanma Barranquero <lekktu@gmail.com>
5051
5052 * xdisp.c (redisplay_internal): Fix prototype.
5053
63696a73 50542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5055
63696a73 5056 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5057 (try_scrolling): Use it when setting scroll_limit.
5058 Limit scrolling to 100 screen lines.
63696a73
EZ
5059 (redisplay_window): Even when falling back on "recentering",
5060 position point in the window according to scroll-conservatively,
5061 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5062
5063 (try_scrolling): When point is above the window, allow searching
5064 as far as scroll_max, or one screenful, to compute vertical
5065 distance from PT to the scroll margin position. This prevents
5066 try_scrolling from unnecessarily failing when
5067 scroll-conservatively is set to a value slightly larger than the
5068 window height. Clean up the case of PT below the margin at bottom
5069 of window: scroll_max can no longer be INT_MAX. When aggressive
5070 scrolling is in use, don't let point enter the opposite scroll
5071 margin as result of the scroll.
5072 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5073 threshold of 100 lines for never-recentering scrolling.
5074
e4cc2dfc
JB
50752011-03-31 Juanma Barranquero <lekktu@gmail.com>
5076
5077 * dispextern.h (move_it_by_lines):
5078 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5079 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5080 (message_log_check_duplicate): Remove parameters `prev_bol' and
5081 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5082 (redisplay_internal): Remove parameter `preserve_echo_area',
5083 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5084
5085 * indent.c (Fvertical_motion):
5086 * window.c (window_scroll_pixel_based, Frecenter):
5087 Don't pass `need_y_p' to `move_it_by_lines'.
5088
1c470562
SM
50892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5090
44f230aa
SM
5091 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5092 steal a few bits to be more compact.
5093 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5094 Remove unneeded casts.
5095
1c470562
SM
5096 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5097
888adce9
ZK
50982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5099
5100 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5101 binding" message (bug#7967).
5102
f838ed7b
PE
51032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5104
77861b95
PE
5105 Fix more problems found by GCC 4.6.0's static checks.
5106
de6dbc14
PE
5107 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5108 Remove unused local var.
5109
f838ed7b
PE
5110 * editfns.c (Fmessage_box): Remove unused local var.
5111
792c7b2b
PE
5112 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5113 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5114 Omit unused local vars.
c499e557 5115 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5116 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5117 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5118 Omit unused local var.
5119
ba0165e1
PE
5120 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5121 Don't assume string length fits in int.
32ad8845 5122 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5123 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5124
3c59b4c9
PE
5125 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5126 instead of alloca (Bug#8344).
5127
a3eed478 5128 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5129 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5130
eb4d412d
PE
5131 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5132
1658b401
PE
5133 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5134 concerns.
5135
5136 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5137
5138 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5139
9a2c6e05
PE
5140 * keyboard.c (syms_of_keyboard): Use the same style as later
5141 in this function when indexing through an array. This also
5142 works around GCC bug 48267.
5143
03d0a109
PE
5144 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5145
44f730c8
PE
5146 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5147
fe75f926
PE
5148 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5149 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5150
ffa8c828
PE
5151 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5152 This avoids undefined behavior on integer overflow, and is a bit
5153 more convenient anyway since it is compared to a size_t variable.
5154
c5101a77
PE
5155 Variadic C functions now count arguments with size_t, not int.
5156 This avoids an unnecessary limitation on 64-bit machines, which
5157 caused (substring ...) to crash on large vectors (Bug#8344).
5158 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5159 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5160 All variadic functions and their callers changed accordingly.
c5101a77
PE
5161 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5162 * data.c (arith_driver, float_arith_driver): Likewise.
5163 * editfns.c (general_insert_function): Likewise.
5164 * eval.c (struct backtrace.nargs, interactive_p)
5165 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5166 (funcall_lambda, mark_backtrace): Likewise.
5167 * fns.c (concat): Likewise.
5168 * frame.c (x_set_frame_parameters): Likewise.
5169 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5170 0 if not found, not -1. All callers changed.
5171
dd3f25f7
PE
5172 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5173 (stack_copy_size): Now size_t, not int.
5174 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5175
461c2ab9
JB
51762011-03-28 Juanma Barranquero <lekktu@gmail.com>
5177
5178 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5179 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5180 All callers changed.
5181
5182 * lisp.h (multibyte_char_to_unibyte):
5183 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5184 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5185 * character.h (CHAR_TO_BYTE8):
5186 * cmds.c (internal_self_insert):
5187 * editfns.c (general_insert_function):
5188 * keymap.c (push_key_description):
5189 * search.c (Freplace_match):
5190 * xdisp.c (message_dolog, set_message_1): All callers changed.
5191
f6d62986
SM
51922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5193
5194 * keyboard.c (safe_run_hook_funcall): New function.
5195 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5196 don't set the hook to nil, but remove the offending function instead.
5197 (Qcommand_hook_internal): Remove, unused.
5198 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5199 Vcommand_hook_internal.
5200
5201 * eval.c (enum run_hooks_condition): Remove.
5202 (funcall_nil, funcall_not): New functions.
5203 (run_hook_with_args): Call each function through a `funcall' argument.
5204 Remove `cond' argument, now redundant.
5205 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5206 (Frun_hook_with_args_until_failure): Adjust accordingly.
5207 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5208
1db5b1ad
JB
52092011-03-28 Juanma Barranquero <lekktu@gmail.com>
5210
5211 * dispextern.h (string_buffer_position): Remove declaration.
5212
5213 * print.c (strout): Remove parameter `multibyte', unused since
5214 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5215
5216 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5217 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5218 All callers changed.
5219
5220 * w32.c (_wsa_errlist): Use braces for struct initializers.
5221
5222 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5223 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5224 All callers changed.
5225 (string_buffer_position): Likewise. Also, make static (it's never
5226 used outside xdisp.c).
5227 (cursor_row_p): Remove parameter `w', unused since
5228 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5229 (decode_mode_spec): Remove parameter `precision', introduced during
5230 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5231 All callers changed.
5232
5ffb62aa
JD
52332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5234
5235 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5236
461c2ab9 52372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5238
5239 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5240 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5241 (ns_update_auto_hide_menu_bar): New functions.
5242 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5243 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5244 ns_constrain_all_frames.
5245 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5246 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5247
5c380ffb
JD
52482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5249
5250 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5251
9af30bdf
GM
52522011-03-27 Glenn Morris <rgm@gnu.org>
5253
5254 * syssignal.h: Replace RETSIGTYPE with void.
5255 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5256 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5257 Replace SIGTYPE with void everywhere.
5258 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5259 * s/template.h (SIGTYPE): Remove commented out definition.
5260
e2abce01
JB
52612011-03-26 Eli Zaretskii <eliz@gnu.org>
5262
5263 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5264 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5265
f868cd8a
JB
52662011-03-26 Juanma Barranquero <lekktu@gmail.com>
5267
59eb0929
JB
5268 * w32.c (read_unc_volume): Use parameter `henum', instead of
5269 global variable `wget_enum_handle'.
5270
5271 * keymap.c (describe_vector): Remove parameters `indices' and
5272 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5273 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5274
f868cd8a
JB
5275 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5276
5277 * keyboard.c (timer_check): Remove parameter `do_it_now',
5278 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5279 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5280 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5281
5282 * keyboard.c (read_char):
5283 * w32menu.c (w32_menu_display_help):
5284 * xmenu.c (show_help_event, menu_help_callback):
5285 Adjust calls to `show_help_echo'.
5286
5287 * gtkutil.c (xg_maybe_add_timer):
5288 * keyboard.c (readable_events):
5289 * process.c (wait_reading_process_output):
5290 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5291
5292 * insdel.c (adjust_markers_gap_motion):
5293 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5294 (gap_left, gap_right): Don't call it.
5295
2ecf6fdb
CY
52962011-03-25 Chong Yidong <cyd@stupidchicken.com>
5297
5298 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5299 incurred during fontification.
5300
6b1f9ba4
JB
53012011-03-25 Juanma Barranquero <lekktu@gmail.com>
5302
5303 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5304 (DEFVAR_PER_BUFFER): Don't pass it.
5305
5306 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5307 (scrolling_window): Don't pass it.
5308
0f4a96b5
JB
53092011-03-25 Juanma Barranquero <lekktu@gmail.com>
5310
5311 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5312
5313 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5314 and `suffix'.
5315 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5316 of variables specific to SELinux and computation of `encoded_absname'.
5317
5318 * image.c (XPutPixel): Remove unused variable `height'.
5319
5320 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5321
5322 * unexw32.c (get_section_info): Remove unused variable `section'.
5323
5324 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5325 (system_process_attributes): Remove unused variable `sess'.
5326 (sys_read): Remove unused variable `err'.
5327
5328 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5329 (w32_wnd_proc): Remove unused variable `isdead'.
5330 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5331 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5332 (x_create_tip_frame): Remove unused variable `tem'.
5333
5334 * w32inevt.c (w32_console_read_socket):
5335 Remove unused variable `no_events'.
5336
5337 * w32term.c (x_draw_composite_glyph_string_foreground):
5338 Remove unused variable `width'.
5339
1149507c
JB
53402011-03-24 Juanma Barranquero <lekktu@gmail.com>
5341
5342 * w32term.c (x_set_glyph_string_clipping):
5343 Don't pass uninitialized region to CombineRgn.
5344
9c88f339
JB
53452011-03-23 Juanma Barranquero <lekktu@gmail.com>
5346
5347 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5348 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5349 (Fx_close_connection): Remove unused variable `i'.
5350
5351 * w32font.c (w32font_draw): Return number of glyphs.
5352 (w32font_open_internal): Remove unused variable `i'.
5353 (w32font_driver): Add missing initializer.
5354
5355 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5356 (fill_in_menu): Remove unused variable `items_added'.
5357
5358 * w32term.c (last_mouse_press_frame): Remove static global variable.
5359 (w32_clip_to_row): Remove unused variable `f'.
5360 (x_delete_terminal): Remove unused variable `i'.
5361
5362 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5363 (NOTHING): Remove unused static global variable.
5364 (uniscribe_check_otf): Remove unused variable `table'.
5365 (uniscribe_font_driver): Add missing initializers.
5366
dee091a3
JD
53672011-03-23 Julien Danjou <julien@danjou.info>
5368
5369 * term.c (Fsuspend_tty, Fresume_tty):
5370 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5371 * window.c (temp_output_buffer_show):
5372 * insdel.c (signal_before_change):
5373 * frame.c (Fhandle_switch_frame):
5374 * fileio.c (Fdo_auto_save):
5375 * emacs.c (Fkill_emacs):
5376 * editfns.c (save_excursion_restore):
5377 * cmds.c (internal_self_insert):
5378 * callint.c (Fcall_interactively):
5379 * buffer.c (Fkill_all_local_variables):
5380 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5381 Use Frun_hooks.
0f4a96b5 5382 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5383 unconditionnaly since it does the check itself.
5384
2c520ab5 53852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5386
c9c49752
PE
5387 Fix more problems found by GCC 4.5.2's static checks.
5388
8abc3f12
PE
5389 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5390 the first time through the loop, since we know p0 < p1 then.
5391 This also avoids a gcc -Wstrict-overflow warning.
5392
a2d26660
PE
5393 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5394 leading to a memory leak, possible in functions like
5395 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5396 of objects (Bug#8318).
a2d26660 5397
916c72e9
PE
5398 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5399 that could (at least in theory) be that large.
5400
19ab8a18
PE
5401 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5402 This is less likely to overflow, and avoids undefined behavior if
5403 overflow does occur. All callers changed. Use strtoul to scan
5404 for the unsigned long integer.
b7cbbd6f
PE
5405 (pint2hrstr): Simplify and tune code slightly.
5406 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5407
f0641eff
PE
5408 * scroll.c (do_scrolling): Work around GCC bug 48228.
5409 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5410
7f650bb9
PE
5411 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5412 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5413 (validate_x_resource_name): Simplify count usage.
5414 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5415
37dd57d1
PE
5416 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5417 fail (Bug#8306).
81e56e61 5418
699979fc 5419 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5420
401bf9b4
PE
5421 * process.c (Fmake_network_process): Use socklen_t, not int,
5422 where POSIX says socklen_t is required in portable programs.
5423 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5424 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5425 (Fmake_network_process, server_accept_connection):
5426 (wait_reading_process_output, read_process_output):
5427 Likewise.
5428
b93aacde
PE
5429 * process.c: Rename or move locals to avoid shadowing.
5430 (list_processes_1, Fmake_network_process):
5431 (read_process_output_error_handler, exec_sentinel_error_handler):
5432 Rename or move locals.
4dc343ee 5433 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5434 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5435 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5436 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5437 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5438
af8a867c 5439 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5440 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5441 Include tparam.h instead, since it declares them.
af8a867c
PE
5442 * cm.h (PC): Remove extern decl; tparam.h now does this.
5443 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5444 * terminfo.c: Include tparam.h, to check interfaces.
5445 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5446 (tparam): Adjust signature to match interface in tparam.h;
5447 this removes some undefined behavior. Check that outstring and len
5448 are zero, which they always are with Emacs.
5449 * tparam.h (PC, BC, UP): New extern decls.
5450
0248044d 5451 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5452 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5453
8ff096c1 5454 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5455 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5456 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5457 (ftfont_list): Remove unused local.
49eaafba
PE
5458 (get_adstyle_property, ftfont_pattern_entity):
5459 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5460 Rename locals to avoid shadowing.
8ff096c1 5461
e2be39f6
PE
5462 * xfont.c (xfont_list_family): Mark var as initialized.
5463
c9735e30
PE
5464 * xml.c (make_dom): Now static.
5465
8f5201ae
PE
5466 * composite.c (composition_compute_stop_pos): Rename local to
5467 avoid shadowing.
b246f932
PE
5468 (composition_reseat_it): Remove unused locals.
5469 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5470 (composition_update_it): Mark var as initialized.
11b61122
PE
5471 (find_automatic_composition): Mark vars as initialized,
5472 with a FIXME (Bug#8290).
8f5201ae 5473
760fbc2c
PE
5474 character.h: Rename locals to avoid shadowing.
5475 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5476 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5477 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5478 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5479 to avoid shadowing.
5480
ff08eb85
PE
5481 * textprop.c (property_change_between_p): Remove; unused.
5482
fc7bf025
PE
5483 * intervals.c (interval_start_pos): Now static.
5484
235d7abc
PE
5485 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5486
44f230aa
SM
5487 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5488 Rename locals to avoid shadowing.
3e7d6594 5489
50060332
PE
5490 * sound.c (wav_play, au_play, Fplay_sound_internal):
5491 Fix pointer signedness.
d01f234b 5492 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5493 (wav_play): Initialize a variable to 0, to prevent undefined
5494 behavior (Bug#8278).
50060332 5495
c4fc4e30
PE
5496 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5497
918436ed
PE
5498 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5499
c939f91b
PE
5500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5501 clobbering (Bug#8298).
b9c7f648
PE
5502 * sysdep.c (sys_subshell): Likewise.
5503 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5504
6bd8c144
PE
5505 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5506 This should get cleaned up, so that child_setup has the
5507 same signature on all platforms.
5508
7710357c 5509 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5510 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5511
c59da222
CY
55122011-03-22 Chong Yidong <cyd@stupidchicken.com>
5513
5514 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5515 not to be necessary, and produces flickering.
5516
66b87493
GM
55172011-03-20 Glenn Morris <rgm@gnu.org>
5518
5519 * config.in: Remove file.
5520
45b6f6d5
JB
55212011-03-20 Juanma Barranquero <lekktu@gmail.com>
5522
5523 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5524 are now in src/globals.h.
5525 (syms_of_minibuf): Remove spurious & from previous change.
5526
3ec03f7e
LL
55272011-03-20 Leo <sdl.web@gmail.com>
5528
5529 * minibuf.c (completing-read-function): New variable.
5530 (completing-read-default): Rename from completing-read.
5531 (completing-read): Call completing-read-function.
5532
b14e3e21
CY
55332011-03-19 Juanma Barranquero <lekktu@gmail.com>
5534
5535 * xfaces.c (Fx_load_color_file):
5536 Read color file from absolute filename (bug#8250).
5537
f2b726e6
JB
55382011-03-19 Juanma Barranquero <lekktu@gmail.com>
5539
5540 * makefile.w32-in: Update dependencies.
5541
09f6ff02
EZ
55422011-03-17 Eli Zaretskii <eliz@gnu.org>
5543
5544 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5545
29a6015a
PE
55462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5547
a3a6c54e
PE
5548 Fix more problems found by GCC 4.5.2's static checks.
5549
b766f867
PE
5550 * process.c (make_serial_process_unwind, send_process_trap):
5551 (sigchld_handler): Now static.
5552
be02381c
PE
5553 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5554 That way, the code declares only the vars that it needs.
5555 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5556 * s/cygwin.h (PTY_ITERATION): Likewise.
5557 * s/darwin.h (PTY_ITERATION): Likewise.
5558 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5559
57048744
PE
5560 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5561 * process.c (allocate_pty): Don't declare stb unless it's needed.
5562
7914961c 5563 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5564 (CONSTANTLIM): Remove; unused.
5565 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5566 Define only if needed.
7914961c 5567
b3967b18
PE
5568 * unexelf.c (unexec): Name an expression,
5569 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5570 Use a different way to cause a compilation error if anyone uses
5571 n rather than nn, a way that does not involve shadowing.
73366a00 5572 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5573
29a6015a
PE
5574 * deps.mk (unexalpha.o): Remove; unused.
5575
43cfc33e 5576 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5577 * unexec.h: New file.
ce701a33
PE
5578 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5579 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5580 Depend on unexec.h.
5581 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5582 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5583 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5584 Change as necessary to match prototype in unexec.h.
ce701a33 5585
01f44d5a
PE
5586 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5587 shadowing.
4f63c6bb 5588 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5589
a6670b0b
PE
5590 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5591 Rename locals to avoid shadowing.
5592
cef2010d 5593 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5594 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5595
d4d7173a
PE
5596 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5597
f08b802a
PE
5598 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5599 warning when compiling print.c.
5600
3ddb0639
PE
5601 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5602 instead of using an uninitialized var.
5ad03b97 5603 (font_sort_entities): Mark var as initialized.
3ddb0639 5604
170a2692
PE
5605 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5606
e663c700
PE
5607 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5608 pointers to constants.
89bc529a 5609 (font_parse_fcname): Remove unused vars.
7b81e2d0 5610 (font_delete_unmatched): Now static.
ea838e10 5611 (font_get_spec): Remove; unused.
13a547c6
PE
5612 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5613 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5614 Rename or move locals to avoid shadowing.
e663c700 5615
2a80c887 5616 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5617 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5618
1384fa33 5619 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5620 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5621
8b2c52e9
PE
5622 * alloc.c (mark_backtrace): Move decl from here ...
5623 * lisp.h: ... to here, so that it can be checked.
5624
475545b5 5625 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5626 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5627 (lisp_indirect_variable): Name an expression,
5628 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5629 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5630
b1349114 5631 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5632 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5633 Use const pointer when appropriate.
b1349114 5634
a2928364
PE
5635 * lisp.h (get_system_name, get_operating_system_release):
5636 Move decls here, to check interfaces.
5637 * process.c (get_operating_system_release): Move decl to lisp.h.
5638 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5639 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5640 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5641 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5642 (Fformat_time_string, Fencode_time, Finsert_char):
5643 (Ftranslate_region_internal, Fformat):
5644 Rename or remove local vars to avoid shadowing.
9710023e 5645 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5646
a415e694
PE
5647 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5648 avoid shadowing.
5649
8ef4622d
PE
5650 * lisp.h (eassert): Check that the argument compiles, even if
5651 ENABLE_CHECKING is not defined.
5652
946f9a5b
PE
5653 * data.c (Findirect_variable): Name an expression, to avoid
5654 gcc -Wbad-function-cast warning.
112396d6 5655 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5656 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5657 (Fmake_variable_buffer_local, Fmake_local_variable):
5658 Mark variables as initialized.
52746918 5659 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5660
e5aab7e7 5661 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5662 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5663 Rename locals to avoid shadowing.
dff45157
PE
5664 (mark_stack): Move local variables into the #ifdef region where
5665 they're used.
7bc26fdb
PE
5666 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5667 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5668 needed otherwise.
5669 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5670 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5671 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5672
e5aab7e7
PE
5673 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5674 avoids undefined behavior in theory.
5675
4da60324
PE
5676 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5677
88043301
PE
5678 Use functions, not macros, for up- and down-casing (Bug#8254).
5679 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5680 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5681 to use the following functions instead of these macros.
5682 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5683 EMACS_INT, since callers assume the returned value fits in int.
5684 (upcase1): Likewise, for UPCASE_TABLE.
5685 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5686 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5687 the race-condition problem in the old DOWNCASE.
88043301 5688
19ed5445
PE
5689 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5690 Rename locals to avoid shadowing.
5691 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5692 (regex_compile, re_search_2, re_match_2_internal):
5693 Remove unused local vars.
952db0d7
PE
5694 (FREE_VAR): Rewrite so as not to use empty "else",
5695 which gcc can warn about.
da053e48 5696 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5697 (RETALLOC_IF): Define only if needed.
5698 (WORDCHAR_P): Likewise. This one is never needed, but is used
5699 only in a comment talking about a compiler bug, so put inside
5700 the #if 0 of that comment.
5701 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5702 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5703 Remove; unused.
19ed5445 5704
1f3561e4 5705 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5706 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5707 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5708
ded6f8f7
PE
5709 * search.c (simple_search): Remove unused var.
5710
dbd37a95
PE
5711 * dired.c (compile_pattern): Move decl from here ...
5712 * lisp.h: ... to here, so that it can be checked.
5713 (struct re_registers): New forward decl.
5714
7e47afad
PE
5715 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5716
85f24f61
PE
5717 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5718 All uses changed.
5719 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5720 Rename locals to avoid shadowing.
5671df8f 5721 (Fvertical_motion): Mark locals as initialized.
85f24f61 5722
181aa2be 5723 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5724 (casify_region): Mark local as initialized.
181aa2be 5725
930d429c
PE
5726 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5727
7082eac6
PE
5728 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5729 New macros, so that the caller can use some names other than
5730 gcpro1, gcpro2, etc.
5731 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5732 of the new macros.
5733 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5734 argument, for consistency with GCPRO2_VAR, etc: it is now the
5735 prefix of the variable, not the variable itself. All uses
5736 changed.
38b2c076
PE
5737 * dired.c (directory_files_internal, file_name_completion):
5738 Rename locals to avoid shadowing.
5739
15206ed9
PE
5740 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5741 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5742 dired.c's scmp function, had undefined behavior.
5743 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5744 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5745 * buffer.h: ... to here, because these macros use current_buffer,
5746 and the new implementation with inline functions needs to have
5747 current_buffer in scope now, rather than later when the macros
5748 are used.
5749 (downcase, upcase1): New static inline functions.
5750 (DOWNCASE, UPCASE1): Reimplement using these functions.
5751 This avoids undefined behavior in expressions like
5752 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5753 from race conditions in accessing the global variables
5754 case_temp1 and case_temp2.
5755 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5756 * lisp.h (case_temp1, case_temp2): Remove their decls.
5757 * character.h (ASCII_CHAR_P): Move from here ...
5758 * lisp.h: ... to here, so that the inline functions mentioned
5759 above can use them.
5760
4a6bea26
PE
5761 * dired.c (directory_files_internal_unwind): Now static.
5762
f14b7e14
PE
5763 * fileio.c (file_name_as_directory, directory_file_name):
5764 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5765 Now static.
2893f146
PE
5766 (file_name_as_directory): Use const pointers when appropriate.
5767 (Fexpand_file_name): Likewise. In particular, newdir might
5768 point at constant storage, so make it a const pointer.
fd4ead52 5769 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5770 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5771 signedness issues.
f839df0c
PE
5772 (Fset_file_times, Finsert_file_contents, auto_save_error):
5773 Rename locals to avoid shadowing.
f14b7e14 5774
5716756e 5775 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5776 (Ftry_completion, Fall_completions): Rename or remove locals
5777 to avoid shadowing.
5716756e 5778
b4c3046a
PE
5779 * marker.c (bytepos_to_charpos): Remove; unused.
5780
b45db522
PE
5781 * lisp.h (verify_bytepos, count_markers): New decls,
5782 so that gcc does not warn that these functions aren't declared.
5783
85876d07
PE
5784 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5785 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5786 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5787 (copy_text): Remove unused local var.
85876d07 5788
03d78a21 5789 * filelock.c (within_one_second): Now static.
b3dd38ab 5790 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5791
5df8f01b
PE
5792 * buffer.c (fix_overlays_before): Mark locals as initialized.
5793 (fix_start_end_in_overlays): Likewise. This function should be
5794 simplified by using pointers-to-pointers, but that's a different
5795 matter.
b1d876f1 5796 (switch_to_buffer_1): Now static.
8f54f30a
PE
5797 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5798 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5799
a70072c9 5800 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5801 Fix pointer signedness issue.
edced198
PE
5802 (sys_subshell): Mark local as volatile if checking for lint,
5803 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5804 (MAXPATHLEN): Define only if needed.
a70072c9 5805
a0977c44
PE
5806 * process.c (serial_open, serial_configure): Move decls from here ...
5807 * systty.h: ... to here, so that they can be checked.
5808
a884fdcc
PE
5809 * fns.c (get_random, seed_random): Move extern decls from here ...
5810 * lisp.h: ... to here, so that they can be checked.
5811
604efe86 5812 * sysdep.c (reset_io): Now static.
b8950c94 5813 (wait_for_termination_signal): Remove; unused.
604efe86 5814
38fc62d9
PE
5815 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5816 (copy_keymap_item, append_key, push_text_char_description):
5817 Now static.
1004a21a 5818 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5819 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5820 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5821 (describe_map_tree):
5822 Rename locals to avoid shadowing.
38fc62d9 5823
2f2650da
PE
5824 * keyboard.c: Declare functions static if they are not used elsewhere.
5825 (echo_char, echo_dash, cmd_error, top_level_2):
5826 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5827 (read_char, kbd_buffer_get_event, make_lispy_position):
5828 (make_lispy_event, make_lispy_movement, apply_modifiers):
5829 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5830 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5831 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5832 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5833 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5834
a053e86c 5835 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5836 (mark_kboards): Move decl here ...
5837 * alloc.c (mark_kboards): ... from here.
a053e86c 5838
4752793e
PE
5839 * lisp.h (force_auto_save_soon): New decl.
5840
74f10ca7 5841 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5842 (DEFINE_DUMMY_FUNCTION): New macro.
5843 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5844 Use it.
c03cd23f
PE
5845 (main): Add casts to avoid warnings
5846 if GCC considers string literals to be constants.
74f10ca7 5847
022e70d4
PE
5848 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5849
59d6fe83
PE
5850 * dbusbind.c: Pointer signedness fixes.
5851 (xd_signature, xd_append_arg, xd_initialize):
5852 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5853 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5854 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5855 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5856
78320123
PE
5857 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5858 if GCC considers string literals to be constants.
49cebcca 5859 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5860
35ac2a97
SM
58612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5862
fb103ca9
SM
5863 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5864 (print_preprocess, print_object): New macro to fix last change.
5865
35ac2a97
SM
5866 * print.c (print_preprocess): Don't forget font objects.
5867
62973b41
JB
58682011-03-16 Juanma Barranquero <lekktu@gmail.com>
5869
5870 * emacs.c (USAGE3): Doc fixes.
5871
0e48bb22
AS
58722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5873
5874 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5875 structure.
5876
7684e57b
JB
58772011-03-14 Juanma Barranquero <lekktu@gmail.com>
5878
5879 * lisp.h (VWindow_system, Qfile_name_history):
5880 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5881 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5882 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5883
5884 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5885 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5886
5887 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5888 * w32console.c (detect_input_pending, read_input_pending)
5889 (encode_terminal_code):
5890 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5891 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5892 (w32_system_caret_y, Qfile_name_history):
5893 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5894 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5895 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5896 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5897 * w32proc.c (Qlocal, report_file_error):
5898 * w32term.c (Vwindow_system, updating_frame):
5899 * w32uniscribe.c (initialized, uniscribe_font_driver):
5900 Remove unneeded extern declarations.
5901
2aa46d6c
CY
59022011-03-14 Chong Yidong <cyd@stupidchicken.com>
5903
c96bbc66 5904 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5905
cffc6f3b
CY
59062011-03-13 Chong Yidong <cyd@stupidchicken.com>
5907
5908 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5909 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5910 These macros can no longer be used for assignment.
5911
44f230aa
SM
5912 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5913 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5914 (record_buffer_markers, fetch_buffer_markers): New functions for
5915 recording and fetching special buffer markers.
5916 (set_buffer_internal_1, set_buffer_temp): Use them.
5917
5918 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5919
5920 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5921
5922 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5923 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5924
5925 * xdisp.c (hscroll_window_tree):
5926 (reconsider_clip_changes): Use PT instead of BUF_PT.
5927
d251f04b
EZ
59282011-03-13 Eli Zaretskii <eliz@gnu.org>
5929
5930 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5931 $(EMACS_ROOT)/lib/intprops.h.
5932
f0c77cd1
PE
59332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5934
3eca4629
PE
5935 Fix more problems found by GCC 4.5.2's static checks.
5936
7c86ee98
PE
5937 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5938 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5939 (xg_free_frame_widgets): Make it clear that a local variable is
5940 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5941 (gdk_window_get_screen): Make it clear that this macro is needed
5942 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5943 (int_gtk_range_get_value): New function, which avoids a diagnostic
5944 from gcc -Wbad-function-cast.
5945 (xg_set_toolkit_scroll_bar_thumb): Use it.
5946 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5947 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5948 (get_utf8_string, xg_get_file_with_chooser):
5949 Rename locals to avoid shadowing.
5950 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5951
41729b81
PE
5952 * xgselect.c (xg_select): Remove unused var.
5953
f0c77cd1
PE
5954 * image.c (four_corners_best): Mark locals as initialized.
5955 (gif_load): Initialize transparent_p to zero (Bug#8238).
5956 Mark another local as initialized.
ec6cf4c6 5957 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5958
ce0ad53d 5959 * image.c (clear_image_cache): Now static.
d5d5a617 5960 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5961 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5962 (x_edge_detection): Remove unnecessary cast that
5963 gcc -Wbad-function-cast diagnoses.
2037898d 5964 (gif_load): Fix pointer signedness.
6ae141d6
PE
5965 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5966 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5967
33383987 59682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5969
d32df629
PE
5970 Improve quality of tests for time stamp overflow.
5971 For example, without this patch (encode-time 0 0 0 1 1
5972 1152921504606846976) returns the obviously-bogus value (-948597
5973 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5974 reports time overflow. See
5975 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5976 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5977 * editfns.c: Include limits.h and intprops.h.
5978 (TIME_T_MIN, TIME_T_MAX): New macros.
5979 (time_overflow): Move earlier, to before first use.
5980 (hi_time, lo_time): New functions, for an accurate test for
5981 out-of-range times.
5982 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5983 (Fget_internal_run_time): Don't assume time_t fits in int.
5984 (make_time): Use list2 instead of Fcons twice.
5985 (Fdecode_time): More accurate test for out-of-range times.
5986 (check_tm_member): New function.
5987 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5988 (lisp_time_argument): Don't rely on undefined left-shift and
5989 right-shift behavior when checking for time stamp overflow.
8be6f318 5990
fe31d94c
PE
5991 * editfns.c (time_overflow): New function, refactoring common code.
5992 (Fformat_time_string, Fdecode_time, Fencode_time):
5993 (Fcurrent_time_string): Use it.
5994
8be6f318
PE
5995 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5996 * dired.c (make_time): Move to ...
5997 * editfns.c (make_time): ... here.
5998 * systime.h: Note the move.
5999
09d9db2c 60002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6001
126bc0dc
YM
6002 * fringe.c (update_window_fringes): Remove unused variables.
6003
c47cbdfd
YM
6004 * unexmacosx.c (copy_data_segment): Also copy __got section.
6005 (Bug#8223)
6006
7ac80be9
EZ
60072011-03-12 Eli Zaretskii <eliz@gnu.org>
6008
c96bbc66 6009 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6010 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6011 Constify `char *' arguments and their references according to
6012 prototypes in tparam.h.
6013
ecb0f94d 6014 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6015
7ac80be9
EZ
6016 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6017 Adapt all references accordingly.
6018
6019 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6020
ef1fd07e
TT
60212011-03-11 Tom Tromey <tromey@redhat.com>
6022
6023 * buffer.c (syms_of_buffer): Remove obsolete comment.
6024
7ef4b50c
EZ
60252011-03-11 Eli Zaretskii <eliz@gnu.org>
6026
6027 * termhooks.h (encode_terminal_code): Declare prototype.
6028
6029 * msdos.c (encode_terminal_code): Don't declare prototype.
6030
6031 * term.c (encode_terminal_code): Now external again, used by
6032 w32console.c and msdos.c.
6033
44f230aa
SM
6034 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6035 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6036
4b1ec863 60372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6038
1714f52b 6039 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6040
4b1ec863
PE
6041 * fringe.c (update_window_fringes): Mark locals as initialized
6042 (Bug#8227).
6043 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6044
524c7aa6
PE
6045 * alloc.c (mark_fringe_data): Move decl from here ...
6046 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6047 to check its interface.
6048 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6049
a5c0af81 6050 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6051 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6052 (fontset_font): Mark local as initialized.
a9a06e0b 6053 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6054
b4716021
PE
6055 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6056
811e9bac 6057 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6058 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6059 (x_own_selection, Fx_disown_selection_internal): Rename locals
6060 to avoid shadowing.
6061 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6062
7e3ab302
PE
6063 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6064 so that the caller can use some name other than gcpro1.
6065 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6066 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6067 (Fx_backspace_delete_keys_p):
6068 Use them to avoid shadowing, and rename vars to avoid shadowing.
6069 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6070 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6071 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6072 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6073 Remove unused locals.
7e3ab302
PE
6074 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6075 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6076 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6077 macros.
f78faa98 6078
e2b13473
PE
6079 * xterm.h (x_mouse_leave): New decl.
6080
77f23912
PE
6081 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6082 Remove unused functions.
cdf4ba58
PE
6083 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6084 (x_calc_absolute_position): Now static.
7411c686 6085 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6086 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6087 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6088 unless they are used.
38d0b34a
PE
6089 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6090 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6091 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6092 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6093 (x_error_catcher, x_connection_closed, x_error_handler):
6094 (x_error_quitter, xembed_send_message, x_iconify_frame):
6095 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6096 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6097 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6098
44f230aa
SM
6099 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6100 Rename or move locals to avoid shadowing.
6b463e58 6101 (tty_defined_color, merge_face_heights): Now static.
5967d051 6102 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6103 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6104 does not deduce is never used uninitialized.
73719eba
PE
6105 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6106 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6107
426994c3 6108 * terminal.c (store_terminal_param): Now static.
5489860b 6109
032f1620 6110 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6111 (set_frame_menubar): Remove unused local.
d4323972 6112 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6113 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6114 since they might point to immutable storage.
281585b0
PE
6115 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6116 since it's unused otherwise.
032f1620 6117
367c19e5 6118 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6119 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6120 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6121 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6122 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6123 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6124 does not deduce are never used uninitialized.
70739cbe 6125
07b48fa9
PE
6126 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6127
8868a238 6128 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6129 * window.c (window_loop, size_window):
6130 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6131
7e5cf297 6132 * window.c (display_buffer): Now static.
d6550a9f
PE
6133 (size_window): Mark variables that gcc -Wuninitialized
6134 does not deduce are never used uninitialized.
a586633d
PE
6135 * window.h (check_all_windows): New decl, to forestall
6136 gcc -Wmissing-prototypes diagnostic.
5b555da1 6137 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6138
f6095868
PE
6139 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6140 shadowing.
6141 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6142 Include <limits.h>.
6143 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6144 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6145 (load_charset_map): Mark variables that gcc -Wuninitialized
6146 does not deduce are never used uninitialized.
53df7c11 6147 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6148
f38b440c
PE
6149 * coding.c (coding_set_source, coding_set_destination):
6150 Use "else { /* comment */ }" rather than "else /* comment */;"
6151 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6152 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6153 a block, when the outer 'i' will do.
6154 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6155 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6156 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6157 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6158 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6159 Rename locals to avoid shadowing.
6160 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6161 * coding.c (emacs_mule_char, encode_invocation_designation):
6162 Now static, since they're not used elsewhere.
413bb2db 6163 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6164 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6165 (decode_coding_emacs_mule): Mark variables that gcc
6166 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6167 (detect_coding_iso_2022): Initialize a local variable that might
6168 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6169 this initialization is needed. (Bug#8211)
5f58e762
PE
6170 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6171 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6172 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6173 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6174 Remove unused macros.
f38b440c 6175
232b38b9 6176 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6177 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6178 * character.c (string_count_byte8): Likewise.
232b38b9 6179
fb90da1b
PE
6180 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6181 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6182
fb93dbc2
PE
6183 * chartab.c (copy_sub_char_table): Now static, since it's not used
6184 elsewhere.
5c156ace
PE
6185 (sub_char_table_ref_and_range, char_table_ref_and_range):
6186 Rename locals to avoid shadowing.
bbcd0949 6187 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6188
7d3b3862 6189 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6190 (BIDI_BOB): Remove unused macro.
7d3b3862 6191
6be7d3da
PE
6192 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6193 deduce are never used uninitialized.
c2ed9c8b 6194 * term.c (encode_terminal_code): Likewise.
6be7d3da 6195
75f8807f 6196 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6197
50938595
PE
6198 * tparam.h: New file.
6199 * term.c, tparam.h: Include it.
6200 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6201 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6202 Move these decls to tparam.h, and make them agree with what
6203 is actually in tparam.c. The previous trick of using incompatible
6204 decls in different modules does not conform to the C standard.
6205 All callers of tparam changed to use tparam's actual API.
6206 * tparam.c (tparam1, tparam, tgoto):
6207 Use const pointers where appropriate.
6208
fbceeba2
PE
6209 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6210 * cm.h (struct cm): Likewise.
6211 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6212 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6213 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6214 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6215 (turn_on_face, init_tty): Likewise.
6216 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6217
7f3f1250
PE
6218 * term.c (term_mouse_position): Rename local to avoid shadowing.
6219
e6ca6543
PE
6220 * alloc.c (mark_ttys): Move decl from here ...
6221 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6222
c40f8d15
AS
62232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6224
6225 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6226
cfe0661d
JB
62272011-03-09 Juanma Barranquero <lekktu@gmail.com>
6228
6229 * search.c (compile_pattern_1): Remove argument regp, unused since
6230 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6231 (compile_pattern): Don't pass it.
6232
0afb4571
J
62332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6234
6235 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6236 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6237 for ! HAVE_GTK3.
6238 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6239
6240 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6241
6242 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6243 gdk_window_get_screen, gdk_window_get_geometry,
6244 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6245 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6246 (xg_get_pixbuf_from_pixmap): New function.
6247 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6248 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6249 Call xg_get_pixbuf_from_pixmap instead of
6250 gdk_pixbuf_get_from_drawable.
6251 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6252 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6253 (xg_check_special_colors): Use GtkStyleContext and its functions
6254 for HAVE_GTK3.
6255 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6256 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6257 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6258 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6259 Call gtk_widget_get_preferred_size.
0afb4571
J
6260 (xg_frame_resized): gdk_window_get_geometry only takes 5
6261 parameters.
44f230aa
SM
6262 (xg_win_to_widget, xg_event_is_for_menubar):
6263 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6264 (xg_set_widget_bg): New function.
6265 (delete_cb): New function.
895009e1 6266 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6267 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6268 (xg_set_background_color): Call xg_set_widget_bg.
6269 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6270 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6271 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6272 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6273 if ! HAVE_GTK3.
6274 (update_frame_tool_bar): Call gtk_widget_hide.
6275 (xg_initialize): Use GDK_KEY_g.
6276
6277 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6278 if ! HAVE_GTK3
6279 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6280
6281 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6282 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6283 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6284
1c2cc4ef
JB
62852011-03-08 Juanma Barranquero <lekktu@gmail.com>
6286
6287 * w32xfns.c (select_palette): Check success of RealizePalette against
6288 GDI_ERROR, not zero.
6289
33383987 6290See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6291
6292;; Local Variables:
6293;; coding: utf-8
aac0c6e3
MR
6294;; End:
6295
33383987 6296 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6297
6298 This file is part of GNU Emacs.
6299
6300 GNU Emacs is free software: you can redistribute it and/or modify
6301 it under the terms of the GNU General Public License as published by
6302 the Free Software Foundation, either version 3 of the License, or
6303 (at your option) any later version.
6304
6305 GNU Emacs is distributed in the hope that it will be useful,
6306 but WITHOUT ANY WARRANTY; without even the implied warranty of
6307 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6308 GNU General Public License for more details.
6309
6310 You should have received a copy of the GNU General Public License
6311 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.