* nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d6f0886c
JD
12011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4 are specified (Bug#9168).
5
2eb1f9e6
PE
62011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7
8 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9 Found by GCC static checking and --with-wide-int on a 32-bit host.
10
22381272 112011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
12
13 * xdisp.c (compute_display_string_pos): Fix logic of caching
14 previous display string position. Initialize cached_prev_pos to
15 -1. Fixes slow-down at the beginning of a buffer.
16
f25e39b4
EZ
172011-07-24 Eli Zaretskii <eliz@gnu.org>
18
19 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
20 for attrs[LFACE_FONTSET_INDEX].
21
04c4b52e
PE
222011-07-23 Paul Eggert <eggert@cs.ucla.edu>
23
24 * xml.c (parse_region): Remove unused local
25 that was recently introduced.
26
c1734fbd
EZ
272011-07-23 Eli Zaretskii <eliz@gnu.org>
28
be18c5a5
EZ
29 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
30 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
31
c1734fbd
EZ
32 * xdisp.c (move_it_in_display_line_to): Record the best matching
33 position for TO_CHARPOS while scanning the line, and restore it on
34 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
35 vertical-motion and pos-visible-in-window-p under bidi redisplay
36 when exact match is impossible due to invisible text, and the
37 lines are truncated.
38
a258d627
JD
392011-07-23 Jan Djärv <jan.h.d@swipnet.se>
40
41 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
42 for OSX >= 10.7.
43
b6d5a689
EZ
442011-07-22 Eli Zaretskii <eliz@gnu.org>
45
0f74f785
EZ
46 Fix a significant slow-down of cursor motion with C-n, C-p,
47 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
48 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 49 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
50 (next_element_from_buffer): Call compute_stop_pos_backwards to
51 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
52 base_level_stop.
53 (reseat): Don't look for prev_stop, as that could mean a very long
54 run.
55 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
56 <cached_disp_overlay_modiff>: Cache for last found display string
57 position.
551918c1 58 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
59 about the same buffer in the same area of character positions, and
60 the buffer wasn't changed since the time the display string
61 position was cached.
551918c1 62
b2d0c91a
EZ
632011-07-22 Eli Zaretskii <eliz@gnu.org>
64
65 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
66 is an integer, which is important for empty lines. (Bug#9149)
67
043604ee
CY
682011-07-22 Chong Yidong <cyd@stupidchicken.com>
69
70 * frame.c (Fmodify_frame_parameters): In tty case, update the
71 default face if necessary (Bug#4238).
72
da4adb04
CY
732011-07-21 Chong Yidong <cyd@stupidchicken.com>
74
75 * editfns.c (Fstring_to_char): No need to explain what a character
76 is in the docstring (Bug#6576).
77
9abd0532
LMI
782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
79
80 * xml.c (parse_region): Make sure we always return a tree.
81
36881d16
HK
822011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
83
84 * xml.c (parse_region): If a document contains only comments,
85 return that, too.
86
1e98674d
LMI
872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
88
89 * xml.c (make_dom): Return comments, too.
90
590bd467
PE
912011-07-19 Paul Eggert <eggert@cs.ucla.edu>
92
93 Port to OpenBSD.
94 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
95 and the surrounding thread.
96 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
97 rather than fgets, and retry after EINTR. Otherwise, 'emacs
98 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
99 timer goes off.
100 * s/openbsd.h (BROKEN_SIGIO): Define.
101 * unexelf.c (unexec) [__OpenBSD__]:
102 Don't update the .mdebug section of the Alpha COFF symbol table.
103
f41628b2
LMI
1042011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
105
106 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
107 (bug#8460).
108
b59b67c5
PE
1092011-07-18 Paul Eggert <eggert@cs.ucla.edu>
110
15e3a074
PE
111 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
112 This fixes some race conditions on the permissions of any newly
113 created file.
114
41bed37d
PE
115 * alloc.c (valid_pointer_p): Use pipe, not open.
116 This fixes some permissions issues when debugging.
117
b59b67c5
PE
118 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
119 If fchown fails to set both uid and gid, try to set just gid,
120 as that is sometimes allowed. Adjust the file's mode to eliminate
121 setuid or setgid bits that are inappropriate if fchown fails.
122
925a6be7
SM
1232011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
124
125 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
126 to compare Lisp_Objects.
127 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
128 global_gnutls_log_level, don't mistake it for a Lisp_Object.
129 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
130
52968808
AS
1312011-07-17 Andreas Schwab <schwab@linux-m68k.org>
132
0a6a104b
AS
133 * lread.c (read_integer): Unread even EOF character.
134 (read1): Likewise. Properly record start position of symbol.
135
52968808
AS
136 * lread.c (read1): Read `#:' as empty uninterned symbol if no
137 symbol character follows.
138
9e381cdd
PE
1392011-07-17 Paul Eggert <eggert@cs.ucla.edu>
140
141 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
142 This works around a problem with the previous change to Fcopy_file.
143 Recent glibc declares fchown with __attribute__((warn_unused_result)),
144 and without this change, GCC might complain about discarding
145 fchown's return value.
146
b5641435
JB
1472011-07-16 Juanma Barranquero <lekktu@gmail.com>
148
149 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
150
a8031457
PE
1512011-07-16 Paul Eggert <eggert@cs.ucla.edu>
152
153 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
154
dd889327
LMI
1552011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
156
750c33f7
LMI
157 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
158 it's used from the C level.
159
dd889327
LMI
160 * process.c: Use the same condition for POLL_FOR_INPUT in both
161 keyboard.c and process.c (bug#1858).
162
87e86684
LM
1632011-07-09 Lawrence Mitchell <wence@gmx.li>
164
165 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
166 (Fgnutls_boot): Use it.
167
64348f40
AS
1682011-07-15 Andreas Schwab <schwab@linux-m68k.org>
169
170 * doc.c (Fsubstitute_command_keys): Revert last change.
171
1d698799
LMI
1722011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
173
f863868c
LMI
174 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
175 quotes the next character, and doesn't affect other longer
176 sequences (bug#8935).
177
1d698799
LMI
178 * lread.c (syms_of_lread): Clarify that is isn't only
179 `eval-buffer' and `eval-defun' that's affected by
180 `lexical-binding' (bug#8460).
181
aa4b6df6
EZ
1822011-07-15 Eli Zaretskii <eliz@gnu.org>
183
184 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
185 bidi redisplay when a line includes both an image and is
186 truncated.
187
5d856da6
PE
1882011-07-14 Paul Eggert <eggert@cs.ucla.edu>
189
ad6042bb
PE
190 Fix minor problems found by static checking.
191 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
192 (elsz): Now a signed constant, not a size_t var. We prefer signed
193 types to unsigned, to avoid integer comparison confusion. Without
194 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
195 "cannot optimize loop, the loop counter may overflow", a symptom
196 of the confusion.
f00bbb22 197 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
198 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
199
6468f31c
LMI
2002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
201
49080b10
LMI
202 * search.c (Fre_search_backward): Mention `case-fold-search' in
203 all the re_search_* functions (bug#8138).
204
6468f31c
LMI
205 * keyboard.c (Fopen_dribble_file): Document when the file is
206 closed (bug#8056).
207
c965adc5
EZ
2082011-07-14 Eli Zaretskii <eliz@gnu.org>
209
df9733bf
EZ
210 * bidi.c (bidi_dump_cached_states): Fix format of displaying
211 bidi_cache_idx.
212
0bb23927
EZ
213 Support bidi reordering of display and overlay strings.
214 * xdisp.c (compute_display_string_pos)
215 (compute_display_string_end): Accept additional argument STRING.
216 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
217 (reseat_to_string): Initialize bidi_it->string.s and
218 bidi_it->string.schars.
219 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
220 NULL (avoids a crash in bidi_paragraph_init). Initialize
221 itb.string.lstring.
222 (init_iterator): Call bidi_init_it only of a valid
223 buffer position was specified. Initialize paragraph_embedding to
224 L2R.
225 (reseat_to_string): Initialize the bidi iterator.
226 (display_string): If we need to ignore text properties of
227 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
228 original value of -1 will not work with bidi.)
229 (compute_display_string_pos): First arg is now struct
230 `text_pos *'; all callers changed. Support display properties on
231 Lisp strings.
232 (compute_display_string_end): Support display properties on Lisp
233 strings.
234 (init_iterator, reseat_1, reseat_to_string): Initialize the
235 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
236 when iterating on a string not from display properties).
237 (compute_display_string_pos, compute_display_string_end): Fix
238 calculation of the object to scan. Fixes an error when using
239 arrow keys.
240 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
241 base_level_stop; instead, set base_level_stop to BEGV. Fixes
242 crashes in vertical-motion.
243 (next_element_from_buffer): Improve commentary for when
244 the iterator is before prev_stop.
245 (init_iterator): Initialize bidi_p from the default value of
246 bidi-display-reordering, not from buffer-local value. Use the
247 buffer-local value only if initializing for buffer iteration.
248 (handle_invisible_prop): Support invisible properties on strings
249 that are being bidi-reordered.
250 (set_iterator_to_next): Support bidi reordering of C strings and
251 Lisp strings.
252 (next_element_from_string): Support bidi reordering of Lisp
253 strings.
254 (handle_stop_backwards): Support Lisp strings as well.
255 (display_string): Support display of R2L glyph rows. Use
256 IT_STRING_CHARPOS when displaying from a Lisp string.
257 (init_iterator): Don't initialize it->bidi_p for strings
258 here.
259 (reseat_to_string): Initialize it->bidi_p for strings here.
260 (next_element_from_string, next_element_from_c_string)
261 (next_element_from_buffer): Add xassert's for correspondence
262 between IT's object being iterated and it->bidi_it.string
263 structure.
264 (face_before_or_after_it_pos): Support bidi iteration.
265 (next_element_from_c_string): Handle the case of the first string
266 character that is not the first one in the visual order.
267 (get_visually_first_element): New function, refactored from common
268 parts of next_element_from_buffer, next_element_from_string, and
269 next_element_from_c_string.
270 (tool_bar_lines_needed, redisplay_tool_bar)
271 (display_menu_bar): Force left-to-right direction. Add a FIXME
272 comment for making that be controlled by a user option.
273 (push_it, pop_it): Save and restore the state of the
274 bidi iterator. Save and restore the bidi_p flag.
275 (pop_it): Iterate out of display property for string iteration as
276 well.
277 (iterate_out_of_display_property): Support iteration over strings.
278 (handle_single_display_spec): Set up it->bidi_it for iteration
279 over a display string, and call bidi_init_it.
280 (handle_single_display_spec, next_overlay_string)
281 (get_overlay_strings_1, push_display_prop): Set up the bidi
282 iterator for displaying display or overlay strings.
283 (forward_to_next_line_start): Don't use the shortcut if
284 bidi-iterating.
285 (back_to_previous_visible_line_start): If handle_display_prop
286 pushed the iterator stack, restore the internal state of the bidi
287 iterator by calling bidi_pop_it same number of times.
288 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
289 and we are bidi-iterating, don't decrement the iterator position;
290 instead, set the first_elt flag in the bidi iterator, to produce
291 the same effect.
292 (reseat_1): Remove redundant setting of string_from_display_prop_p.
293 (push_display_prop): xassert that we are iterating a buffer.
294 (push_it, pop_it): Save and restore paragraph_embedding member.
295 (handle_single_display_spec, next_overlay_string)
296 (get_overlay_strings_1, reseat_1, reseat_to_string)
297 (push_display_prop): Set up the `unibyte' member of bidi_it.string
298 correctly. Don't assume unibyte strings are not bidi-reordered.
299 (compute_display_string_pos)
300 (compute_display_string_end): Fix handling the case of C string.
301 (push_it, pop_it): Save and restore from_disp_prop_p.
302 (handle_single_display_spec, push_display_prop): Set the
303 from_disp_prop_p flag.
304 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
305 (pop_it): Call iterate_out_of_display_property only if we are
306 popping after iteration over a string that came from a display
307 property. Fix a typo in popping stretch info. Add an assertion
308 for verifying that the iterator position is in sync with the bidi
309 iterator.
310 (handle_single_display_spec, get_overlay_strings_1)
311 (push_display_prop): Fix initialization of paragraph direction for
312 string when that of the parent object is not yet determined.
313 (reseat_1): Call bidi_init_it to resync the bidi
314 iterator with IT's position. (Bug#7616)
315 (find_row_edges): If ROW->start.pos gives position
316 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
317 (handle_stop, back_to_previous_visible_line_start, reseat_1):
318 Reset the from_disp_prop_p flag.
319 (SAVE_IT, RESTORE_IT): New macros.
320 (pos_visible_p, face_before_or_after_it_pos)
321 (back_to_previous_visible_line_start)
322 (move_it_in_display_line_to, move_it_in_display_line)
323 (move_it_to, move_it_vertically_backward, move_it_by_lines)
324 (try_scrolling, redisplay_window, display_line): Use them when
325 saving a temporary copy of the iterator and restoring it back.
326 (back_to_previous_visible_line_start, reseat_1)
327 (init_iterator): Empty the bidi cache "stack".
328 (move_it_in_display_line_to): If iterator ended up at
329 EOL, but we never saw any buffer positions smaller than
330 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
331 motion in bidi-reordered lines.
332 (move_it_in_display_line_to): Record prev_method and prev_pos
333 immediately before the call to set_iterator_to_next. Fixes cursor
334 motion in bidi-reordered lines with stretch glyphs and strings
335 displayed in margins. (Bug#8133) (Bug#8867)
336 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
337 TO_CHARPOS.
338 (pos_visible_p): Support positions in bidi-reordered lines. Save
339 and restore bidi cache.
340
341 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
342 (bidi_paragraph_info): Delete unused struct.
343 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
344 (bidi_cache_start): New variable.
345 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
346 to zero.
347 (bidi_cache_fetch_state, bidi_cache_search)
348 (bidi_cache_find_level_change, bidi_cache_iterator_state)
349 (bidi_cache_find, bidi_peek_at_next_level)
350 (bidi_level_of_next_char, bidi_find_other_level_edge)
351 (bidi_move_to_visually_next): Compare cache index with
352 bidi_cache_start rather than with zero.
353 (bidi_fetch_char): Accept new argument STRING; all callers
354 changed. Support iteration over a string. Support strings with
355 display properties. Support unibyte strings. Fix the type of
356 `len' according to what STRING_CHAR_AND_LENGTH expects.
357 (bidi_paragraph_init, bidi_resolve_explicit_1)
358 (bidi_resolve_explicit, bidi_resolve_weak)
359 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
360 iteration over a string.
361 (bidi_set_sor_type, bidi_resolve_explicit_1)
362 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
363 can now be zero (for strings); special values 0 and -1 were
364 changed to -1 and -2, respectively.
365 (bidi_char_at_pos): New function.
366 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
367 Call it instead of FETCH_MULTIBYTE_CHAR.
368 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
369 initialized to valid values.
370 (bidi_init_it): Don't initialize charpos and bytepos with invalid
371 values.
372 (bidi_level_of_next_char): Allow the sentinel "position" to pass
373 the test for valid cached positions. Fix the logic for looking up
374 the sentinel state in the cache. GCPRO the Lisp string we are
375 iterating.
376 (bidi_push_it, bidi_pop_it): New functions.
377 (bidi_initialize): Initialize the bidi cache start stack pointer.
378 (bidi_cache_ensure_space): New function, refactored from part of
379 bidi_cache_iterator_state. Don't assume the required size is just
380 one BIDI_CACHE_CHUNK away.
381 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
382 (bidi_count_bytes, bidi_char_at_pos): New functions.
383 (bidi_cache_search): Don't assume bidi_cache_last_idx is
384 always valid if bidi_cache_idx is valid.
385 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
386 is valid if it's going to be used.
387 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
388 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
389 (bidi_cache_find_level_change, bidi_cache_ensure_space)
390 (bidi_cache_iterator_state, bidi_cache_find)
391 (bidi_find_other_level_edge, bidi_cache_start_stack): All
392 variables related to cache indices are now EMACS_INT.
393
0bb23927
EZ
394 * dispextern.h (struct bidi_string_data): New structure.
395 (struct bidi_it): New member `string'. Make flag members be 1-bit
396 fields, and put them last in the struct.
397 (compute_display_string_pos, compute_display_string_end): Update
398 prototypes.
399 (bidi_push_it, bidi_pop_it): Add prototypes.
400 (struct iterator_stack_entry): New members bidi_p,
401 paragraph_embedding, and from_disp_prop_p.
402 (struct it): Member bidi_p is now a bit field 1 bit wide.
403 (bidi_shelve_cache, bidi_unshelve_cache): Declare
404 prototypes.
405
406 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
407 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
408 and vector-like objects.
409
410 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
411 cache around display iteration.
412
413 * window.c (Fwindow_end, window_scroll_pixel_based)
414 (displayed_window_lines, Frecenter): Save and restore the bidi
415 cache around display iteration.
416
3bbd2265
LMI
4172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
418
419 * editfns.c (Fdelete_region): Clarify the use of the named
420 parameters (bug#6788).
421
adc47434
MR
4222011-07-14 Martin Rudalics <rudalics@gmx.at>
423
424 * indent.c (Fvertical_motion): Set and restore w->pointm when
425 saving and restoring the window's buffer (Bug#9006).
426
837c31f8
LMI
4272011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
428
429 * editfns.c (Fstring_to_char): Clarify just what is returned
430 (bug#6576). Text by Eli Zaretskii.
431
ac389d0c
JB
4322011-07-13 Juanma Barranquero <lekktu@gmail.com>
433
434 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
435
0be0ce47
EZ
4362011-07-13 Eli Zaretskii <eliz@gnu.org>
437
438 * buffer.c (mmap_find): Fix a typo.
439
cd18e7e3
JB
4402011-07-13 Johan Bockgård <bojohan@gnu.org>
441
442 Fix execution of x selection hooks.
443 * xselect.c (Qx_lost_selection_functions)
444 (Qx_sent_selection_functions): New vars.
445 (syms_of_xselect): DEFSYM them.
446 (x_handle_selection_request): Pass Qx_sent_selection_functions
447 rather than Vx_sent_selection_functions to Frun_hook_with_args.
448 (x_handle_selection_clear,x_clear_frame_selections):
449 Pass Qx_lost_selection_functions rather than
450 Vx_lost_selection_functions to Frun_hook_with_args.
451
47ea7f44
PE
4522011-07-13 Paul Eggert <eggert@cs.ucla.edu>
453
ac389d0c 454 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
455 The old code sometimes used this field without initializing it.
456
47ea7f44
PE
457 * alloc.c (gc_sweep): Don't read past end of array.
458 In theory, the old code could also have corrupted Emacs internals,
459 though it'd be very unlikely.
460
bc985c87
AS
4612011-07-12 Andreas Schwab <schwab@linux-m68k.org>
462
463 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 464 argument. (Bug#4026)
bc985c87 465
0cf34688
LMI
4662011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
467
b3dadd76
LMI
468 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
469 key" (bug#4257).
470
0cf34688
LMI
471 * window.c (Fset_window_start): Doc fix (bug#4199).
472 (Fset_window_hscroll): Ditto.
473
270768cd
PE
4742011-07-12 Paul Eggert <eggert@cs.ucla.edu>
475
077e3dda 476 Fix minor new problems caught by GCC 4.6.1.
270768cd 477 * term.c (init_tty): Remove unused local.
490011a6 478 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 479 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 480 not used otherwise.
270768cd 481
b1f58454
CY
4822011-07-12 Chong Yidong <cyd@stupidchicken.com>
483
484 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
485
22b9578d
LMI
4862011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
487
6e70ab07
LMI
488 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
489 are the mini-buffer and the echo area (bug#3320).
490
22b9578d
LMI
491 * term.c (init_tty): Remove support for supdup, c10 and perq
492 terminals, which are no longer supported (bug#1482).
493
8974cc9f
JB
4942011-07-10 Johan Bockgård <bojohan@gnu.org>
495
496 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
497
a560d974
JD
4982011-07-10 Jan Djärv <jan.h.d@swipnet.se>
499
500 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
501 for non-popups (Bug#3642).
502
1dae0f0a
AS
5032011-07-10 Andreas Schwab <schwab@linux-m68k.org>
504
268c2c36 505 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 506 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
507 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
508 * cm.c (losecursor): Likewise.
1dae0f0a
AS
509 * data.c (fmod): Likewise.
510 * dispnew.c (swap_glyphs_in_rows): Likewise.
511 * emacs.c (memory_warning_signal): Likewise.
512 * floatfns.c (float_error): Likewise.
513 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
514 (otf_open, font_otf_capability, generate_otf_features)
515 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
516 Likewise.
517 * image.c (pbm_read_file): Likewise.
518 * indent.c (string_display_width): Likewise.
519 * intervals.c (check_for_interval, search_for_interval)
520 (inc_interval_count, count_intervals, root_interval)
521 (adjust_intervals_for_insertion, make_new_interval): Likewise.
522 * lread.c (defalias): Likewise.
268c2c36 523 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
524 * regex.c (set_image_of_range_1, set_image_of_range)
525 (regex_grow_registers): Likewise.
526 * sysdep.c (strerror): Likewise.
527 * termcap.c (valid_filename_p, tprint, main): Likewise.
528 * tparam.c (main): Likewise.
529 * unexhp9k800.c (run_time_remap, save_data_space)
530 (update_file_ptrs, read_header, write_header, calculate_checksum)
531 (copy_file, copy_rest, display_header): Likewise.
532 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
533 Likewise.
534 * xdisp.c (check_it): Likewise.
535 * xfaces.c (register_color, unregister_color, unregister_colors):
536 Likewise.
537 * xfns.c (print_fontset_result): Likewise.
538 * xrdb.c (member, fatal, main): Likewise.
539
99033785
PE
5402011-07-10 Paul Eggert <eggert@cs.ucla.edu>
541
542 Fix minor problems found by static checking (Bug#9031).
543 * chartab.c (char_table_set_range, map_sub_char_table):
544 Remove unused locals.
545 (uniprop_table): Now static.
546 * composite.c (_work_char): Remove unused static var.
547
9cb2ac56
JB
5482011-07-09 Juanma Barranquero <lekktu@gmail.com>
549
550 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
551
f25661f0
JD
5522011-07-09 Jan Djärv <jan.h.d@swipnet.se>
553
554 * gtkutil.c (qttip_cb): Remove code without function.
555
8278c4fe
EZ
5562011-07-09 Eli Zaretskii <eliz@gnu.org>
557
558 * w32.c (pthread_sigmask): New stub.
559
1692ae2d 5602011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 561
8a6ebd58 562 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
563 sigprocmask is portable only for single-threaded applications, and
564 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
565 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
566 (LIBES): Use it.
567 * callproc.c (Fcall_process):
568 * process.c (create_process):
569 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
570 Use pthread_sigmask, not sigprocmask.
123403e4 571
1b854618
JD
5722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
573
574 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
575 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
576 wrong (Bug#8591).
577
3fe4b549
JD
5782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
579
0ce7e563
JD
580 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
581 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
582 (xg_hide_tooltip): Fix comment.
583
3fe4b549
JD
584 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
585 in registerServicesMenuSendTypes.
586 (validRequestorForSendType): Don't check ns_return_types.
587
588 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
589 ns_return_type.
590
5df75e47
JR
5912011-07-08 Jason Rumney <jasonr@gnu.org>
592
593 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
594 frame struct members of non-existent frames (Bug#6284).
595
699c10bd
JD
5962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
597
4393663b
JD
598 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
599 variable firstTime not needed on OSX >= 10.6.
600 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
601 >= 10.5. Use setKnobProportion, setDoubleValue.
602
603 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
604 (MAC_OS_X_VERSION_10_5): Define if not defined.
605 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
606 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
607 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
608
609 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
610 cString and lossyCString on OSX >= 10.4
611
612 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
613 sizeToFit on OSX >= 10.2.
614
615 * nsimage.m (allocInitFromFile): Don't use deprecated method
616 bestRepresentationForDevice on OSX >= 10.6.
617
618 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
619 to avoid warning.
620
621 * emacs.c: Declare unexec_init_emacs_zone.
622
a63e0781
JD
623 * nsgui.h: Fix compiler warning about gnulib redefining verify.
624
699c10bd
JD
625 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
626
627 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
628 on svcsMenu (Bug#8842).
629
630 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
631 ns_return_types.
632 (Fns_list_services): Just return Qnil on 10.6, code not working there.
633
634 * nsterm.m (QUTF8_STRING): Declare.
635 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
636 (validRequestorForSendType): Return type is (id).
637 Change indexOfObjectIdenticalTo to indexOfObject.
638 Check if we have local selection before returning self (Bug#8842).
639 (writeSelectionToPasteboard): Put local selection into paste board
640 if we have a local selection (Bug#8842).
641 (syms_of_nsterm): DEFSYM QUTF8_STRING.
642
643 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
644 (ns_get_local_selection): Declare.
645
54e10184
LMI
6462011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
647
9888ff71
LMI
648 * keymap.c (describe_map_tree): Don't insert a double newline at
649 the end of the buffer (bug#1169) and return whether we inserted
650 something.
651
54e10184
LMI
652 * callint.c (Fcall_interactively): Change "reading args" to
653 "providing args" to try to clarify what it does (bug#1010).
654
15fa4783
KH
6552011-07-07 Kenichi Handa <handa@m17n.org>
656
657 * composite.c (composition_compute_stop_pos): Ignore a static
658 composition starting before CHARPOS (Bug#8915).
659
660 * xdisp.c (handle_composition_prop): Likewise.
661
a8815b00
EZ
6622011-07-07 Eli Zaretskii <eliz@gnu.org>
663
664 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
665 (Bug#9015)
666
ef7b981d 6672011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
668
669 * character.h (unicode_category_t): New enum type.
670
671 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
672 (Qchar_code_property_table): New variable.
673 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
674 (UNIPROP_COMPRESSED_FORM_P): New macros.
675 (char_table_ascii): Uncompress the compressed values.
676 (sub_char_table_ref): New arg is_uniprop. Callers changed.
677 Uncompress the compressed values.
ac389d0c 678 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
679 (char_table_ref_and_range): Uncompress the compressed values.
680 (sub_char_table_set): New arg is_uniprop. Callers changed.
681 Uncompress the compressed values.
682 (sub_char_table_set_range): Args changed. Callers changed.
683 (char_table_set_range): Adjuted for the above change.
684 (map_sub_char_table): Delete args default_val and parent. Add arg
685 top. Give decoded values to a Lisp function.
686 (map_char_table): Adjusted for the above change. Give decoded
687 values to a Lisp function. Gcpro more variables.
688 (uniprop_table_uncompress)
689 (uniprop_decode_value_run_length): New functions.
690 (uniprop_decoder, uniprop_decoder_count): New variables.
691 (uniprop_get_decoder, uniprop_encode_value_character)
692 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
693 New functions.
694 (uniprop_encoder, uniprop_encoder_count): New variables.
695 (uniprop_get_encoder, uniprop_table)
696 (Funicode_property_table_internal, Fget_unicode_property_internal)
697 (Fput_unicode_property_internal): New functions.
698 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
699 Sunicode_property_table_internal, Sget_unicode_property_internal,
700 and Sput_unicode_property_internal. Defvar_lisp
701 char-code-property-alist.
702
703 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
704 Vunicode_category_table.
705
706 * font.c (font_range): Adjusted for the change of
707 Vunicode_category_table.
708
76b397fb
DN
7092011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
710
711 * m/iris4d.h: Remove file, move contents ...
712 * s/irix6-5.h: ... here.
713
22b4128e
PE
7142011-07-06 Paul Eggert <eggert@cs.ucla.edu>
715
716 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
717 * alloc.c (mark_buffer):
718 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
719 (clone_per_buffer_values): Don't assume that
22b4128e
PE
720 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
721 This isn't true in general, and it's particularly not true
722 if Emacs is configured with --with-wide-int.
723 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
724 New macros, used in the buffer.c change.
725
869795d6
JD
7262011-07-05 Jan Djärv <jan.h.d@swipnet.se>
727
728 * xsettings.c: Use both GConf and GSettings if both are available.
729 (store_config_changed_event): Add comment.
730 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
731 (store_tool_bar_style_changed): New functions.
732 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
733 (struct xsettings): Move font inside HAVE_XFT.
734 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
735 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
736 Move inside HAVE_XFT.
737 (something_changed_gsettingsCB): Renamed from something_changedCB.
738 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
739 also.
740 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
741 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
742 (something_changed_gconfCB): Renamed from something_changedCB.
743 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
744 (parse_settings): Move check for font inside HAVE_XFT.
745 (read_settings, apply_xft_settings): Add comment.
746 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
747 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
748 call store_font_name_changed.
749 (xft_settings_event): Add comment.
750 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
751 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
752 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
753 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
754 (xsettings_initialize): Call init_gsettings last.
755 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
756 comment.
757
d8ed26bd
PE
7582011-07-05 Paul Eggert <eggert@cs.ucla.edu>
759
760 Random fixes. E.g., (random) never returned negative values.
761 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
762 subseconds part to the entropy, as that's a bit more random.
763 Prefer signed to unsigned, since the signedness doesn't matter and
764 in general we prefer signed. When given a limit, use a
765 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
766 latter isn't right if USE_2_TAGS_FOR_INTS.
767 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
768 not 0..VALMASK. Don't discard "excess" bits that random () returns.
769
cabf1cac
SM
7702011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
771
772 * textprop.c (text_property_stickiness):
773 Obey Vtext_property_default_nonsticky.
774 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
775 * w32fns.c (syms_of_w32fns):
776 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
777
6e9b2be9
PE
7782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
779
780 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
781 This is more efficient than Ffile_directory_p and avoids a minor race.
782
90186c68
LMI
7832011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
784
7c301272
LMI
785 * buffer.c (Foverlay_put): Say what the return value is
786 (bug#7835).
787
c4f2d8d4
LMI
788 * fileio.c (barf_or_query_if_file_exists): Check first if the file
789 is a directory before asking whether to use the file name
790 (bug#7564).
ad637907
LMI
791 (barf_or_query_if_file_exists): Make the "File is a directory"
792 error be more correct.
c4f2d8d4 793
90186c68
LMI
794 * fns.c (Frequire): Remove the mention of the .gz files, since
795 that's installation-specific, but keep the mention of
796 `get-load-suffixes'.
797
da64016e
PE
7982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
799
800 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
801 Report string overflow if the output is too long.
802
7d47b580
JB
8032011-07-04 Juanma Barranquero <lekktu@gmail.com>
804
a555cb87
JB
805 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
806 (syms_of_gnutls): Remove duplicate DEFSYM for
807 Qgnutls_bootprop_verify_hostname_error, an error for
808 Qgnutls_bootprop_verify_error (which is no longer used).
809
7d47b580
JB
810 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
811 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
812 Also (re)move comments that are misplaced or no longer relevant.
813
1e49bfab
LMI
8142011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
815
816 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
817
1485f4c0
CY
8182011-07-03 Chong Yidong <cyd@stupidchicken.com>
819
820 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
821 and background color parameters if they have been changed.
822
a9ab721e
LMI
8232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
824
825 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
826
cf7cff57
PE
8272011-07-03 Paul Eggert <eggert@cs.ucla.edu>
828
2e13213d
PE
829 * xsettings.c (SYSTEM_FONT): Define only when used.
830 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
831
cf7cff57
PE
832 * keymap.c (access_keymap_1): Now static.
833
7a8e04f7
CY
8342011-07-02 Chong Yidong <cyd@stupidchicken.com>
835
836 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
837 leave any prefix arg for the up event (Bug#1586).
838
61352f62
LMI
8392011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
840
69bb1ef7
LMI
841 * lread.c (syms_of_lread): Mention single symbols defined by
842 `defvar' or `defconst' (bug#7154).
843
61352f62 844 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 845 (Frequire): Mention get-load-suffixes.
61352f62 846
28545e04
MR
8472011-07-02 Martin Rudalics <rudalics@gmx.at>
848
849 * window.h (window): Remove clone_number slot.
850 * window.c (Fwindow_clone_number, Fset_window_clone_number):
851 Remove.
852 (make_parent_window, make_window, saved_window)
853 (Fset_window_configuration, save_window_save): Don't deal with
854 clone numbers.
855 * buffer.c (Qclone_number): Remove declaration.
856 (sort_overlays, overlay_strings): Don't deal with clone numbers.
857
3349e122
SM
8582011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
859
860 Add multiple inheritance to keymaps.
861 * keymap.c (Fmake_composed_keymap): New function.
862 (Fset_keymap_parent): Simplify.
863 (fix_submap_inheritance): Remove.
864 (access_keymap_1): New function extracted from access_keymap to handle
865 embedded parents and handle lists of maps.
866 (access_keymap): Use it.
867 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
868 (Fcopy_keymap): Handle embedded parents.
869 (Fcommand_remapping, define_as_prefix): Simplify.
870 (Fkey_binding): Simplify.
871 (syms_of_keymap): Move minibuffer-local-completion-map,
872 minibuffer-local-filename-completion-map,
873 minibuffer-local-must-match-map, and
874 minibuffer-local-filename-must-match-map to Elisp.
875 (syms_of_keymap): Defsubr make-composed-keymap.
876 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
877 (parse_menu_item): Trivial simplification.
878
3279eb87
GM
8792011-07-01 Glenn Morris <rgm@gnu.org>
880
881 * Makefile.in (SETTINGS_LIBS): Fix typo.
882
4550efdf
KI
8832011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
884
885 * coding.c (Fencode_coding_string): Record the last coding system
886 used, as the function doc string says (bug#8738).
887
0949d2b6
JD
8882011-07-01 Jan Djärv <jan.h.d@swipnet.se>
889
890 * xsettings.c (store_monospaced_changed): Take new font as arg and
891 check for change against current_mono_font.
892 (EMACS_TYPE_SETTINGS): Remove this and related defines.
893 (emacs_settings_constructor, emacs_settings_get_property)
894 (emacs_settings_set_property, emacs_settings_class_init)
895 (emacs_settings_init, gsettings_obj): Remove.
896 (something_changedCB): New function for HAVE_GSETTINGS.
897 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
898 with value as argument.
899 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
900 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 901 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
902 "changed".
903
904 * xgselect.c: Add defined (HAVE_GSETTINGS).
905 (xgselect_initialize): Ditto.
906
907 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
908 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
909 xg_select.
910
bbc6b304
PE
9112011-07-01 Paul Eggert <eggert@cs.ucla.edu>
912
913 * eval.c (struct backtrace): Simplify and port the data structure.
914 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
915 signed bit field, as this assumption is not portable and it makes
916 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
917 "char debug_on_exit : 1" as this is not portable either; instead,
918 use the portable "unsigned int debug_on_exit : 1". Remove unused
919 member evalargs. Remove obsolete comments about cc bombing out.
920
9851bfc5
JD
9212011-06-30 Jan Djärv <jan.h.d@swipnet.se>
922
51bb811f 923 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
924 Let HAVE_GSETTINGS override HAVE_GCONF.
925 (store_monospaced_changed): New function.
926 (EMACS_SETTINGS): A new type derived from GObject to handle
927 GSettings notifications.
928 (emacs_settings_constructor, emacs_settings_get_property)
929 (emacs_settings_set_property, emacs_settings_class_init):
930 New functions.
931 (gsettings_client, gsettings_obj): New variables.
932 (GSETTINGS_SCHEMA): New define.
933 (something_changedCB): Call store_monospaced_changed.
934 (init_gsettings): New function.
935 (xsettings_initialize): Call init_gsettings.
936 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
937 to NULL.
938
939 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
940 GCONF_CFLAGS/LIBS.
941
5386012d
MR
9422011-06-29 Martin Rudalics <rudalics@gmx.at>
943
944 * window.c (resize_root_window, grow_mini_window)
945 (shrink_mini_window): Rename Qresize_root_window to
946 Qwindow_resize_root_window and Qresize_root_window_vertically to
947 Qwindow_resize_root_window_vertically.
948
f13e0b08
PE
9492011-06-28 Paul Eggert <eggert@cs.ucla.edu>
950
951 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
952
94515237
JB
9532011-06-27 Juanma Barranquero <lekktu@gmail.com>
954
955 * makefile.w32-in: Redesign dependencies so they reflect more
956 clearly which files are directly included by each source file,
957 and not through other includes.
958
e43b6e43
MR
9592011-06-27 Martin Rudalics <rudalics@gmx.at>
960
961 * buffer.c (Qclone_number): Declare static and DEFSYM it.
962 (sort_overlays, overlay_strings): When an overlay's clone number
963 matches the window's clone number process the overlay even if
964 the overlay's window property doesn't match the current window.
965
d68443dc
MR
966 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
967 (Fwindow_hchild): Rename to Fwindow_left_child.
968 (Fwindow_next): Rename to Fwindow_next_sibling.
969 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
970 (resize_window_check): Rename to window_resize_check.
971 (resize_window_apply): Rename to window_resize_apply.
972 (Fresize_window_apply): Rename to Fwindow_resize_apply.
973 (Fdelete_other_windows_internal, resize_frame_windows)
974 (Fsplit_window_internal, Fdelete_window_internal)
975 (grow_mini_window, shrink_mini_window)
976 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 977
c7e73be5
JD
9782011-06-26 Jan Djärv <jan.h.d@swipnet.se>
979
980 * emacsgtkfixed.h: State that this is only used with Gtk+3.
981 (emacs_fixed_set_min_size): Remove.
982 (emacs_fixed_new): Take frame as argument.
983
984 * emacsgtkfixed.c: State that this is only used with Gtk+3.
985 (_EmacsFixedPrivate): Remove minwidth/height.
986 Add struct frame *f.
987 (emacs_fixed_init): Initialize priv->f.
988 (get_parent_class, emacs_fixed_set_min_size): Remove.
989 (emacs_fixed_new): Set priv->f to argument.
990 (emacs_fixed_get_preferred_width)
991 (emacs_fixed_get_preferred_height): Use min_width/height from
992 frames size_hint to set minimum and natural (Bug#8919).
993 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
994 and use min_width/height from frames size_hint to set
995 min_width/height (Bug#8919).
996
997 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
998 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
999 Fix indentation.
c7e73be5 1000
cf99dcf8
EZ
10012011-06-26 Eli Zaretskii <eliz@gnu.org>
1002
1003 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1004 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1005 called at ZV.
1006
029529ac
CY
10072011-06-26 Chong Yidong <cyd@stupidchicken.com>
1008
1009 * process.c (wait_reading_process_output): Bypass select if
1010 waiting for a cell while ignoring keyboard input, and input is
1011 pending. Suggested by Jan Djärv (Bug#8869).
1012
7a7ef429
PE
10132011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 Use gnulib's dup2 module instead of rolling our own.
1016 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1017
11fdef7d 10182011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1019
1020 * dispnew.c (scrolling_window): Before scrolling, turn off a
1021 mouse-highlight in the window being scrolled.
1022
cd3520a4
JB
10232011-06-24 Juanma Barranquero <lekktu@gmail.com>
1024
1025 Move DEFSYM to lisp.h and use everywhere.
1026
1027 * character.h (DEFSYM): Move declaration...
1028 * lisp.h (DEFSYM): ...here.
1029
1030 * gnutls.c:
1031 * minibuf.c:
1032 * w32menu.c:
1033 * w32proc.c:
1034 * w32select.c: Don't include character.h.
1035
1036 * alloc.c (syms_of_alloc):
1037 * buffer.c (syms_of_buffer):
1038 * bytecode.c (syms_of_bytecode):
1039 * callint.c (syms_of_callint):
1040 * casefiddle.c (syms_of_casefiddle):
1041 * casetab.c (init_casetab_once):
1042 * category.c (init_category_once, syms_of_category):
1043 * ccl.c (syms_of_ccl):
1044 * cmds.c (syms_of_cmds):
1045 * composite.c (syms_of_composite):
1046 * dbusbind.c (syms_of_dbusbind):
1047 * dired.c (syms_of_dired):
1048 * dispnew.c (syms_of_display):
1049 * doc.c (syms_of_doc):
1050 * editfns.c (syms_of_editfns):
1051 * emacs.c (syms_of_emacs):
1052 * eval.c (syms_of_eval):
1053 * fileio.c (syms_of_fileio):
1054 * fns.c (syms_of_fns):
1055 * frame.c (syms_of_frame):
1056 * fringe.c (syms_of_fringe):
1057 * insdel.c (syms_of_insdel):
1058 * keymap.c (syms_of_keymap):
1059 * lread.c (init_obarray, syms_of_lread):
1060 * macros.c (syms_of_macros):
1061 * msdos.c (syms_of_msdos):
1062 * print.c (syms_of_print):
1063 * process.c (syms_of_process):
1064 * search.c (syms_of_search):
1065 * sound.c (syms_of_sound):
1066 * syntax.c (init_syntax_once, syms_of_syntax):
1067 * terminal.c (syms_of_terminal):
1068 * textprop.c (syms_of_textprop):
1069 * undo.c (syms_of_undo):
1070 * w32.c (globals_of_w32):
1071 * window.c (syms_of_window):
1072 * xdisp.c (syms_of_xdisp):
1073 * xfaces.c (syms_of_xfaces):
1074 * xfns.c (syms_of_xfns):
1075 * xmenu.c (syms_of_xmenu):
1076 * xsettings.c (syms_of_xsettings):
1077 * xterm.c (syms_of_xterm): Use DEFSYM.
1078
4228cf16
TZ
10792011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1080
cd3520a4 1081 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1082
7fcccf1e
PE
10832011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1084
7efb4e0e
PE
1085 Integer and buffer overflow fixes (Bug#8873).
1086
ff5844ad
PE
1087 * print.c (printchar, strout): Check for string overflow.
1088 (PRINTPREPARE, printchar, strout):
1089 Don't set size unless allocation succeeds.
1090
90532f02
PE
1091 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1092 for sizes. Check for string overflow more accurately.
1093 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1094
6d84508d
PE
1095 * macros.c: Integer and buffer overflow fixes.
1096 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1097 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1098 Use ptrdiff_t, not int, for sizes.
1099 Don't increment bufsize until after realloc succeeds.
1100 Check for size-calculation overflow.
1101 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1102
437b2cb4
PE
1103 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1104
8b9ac8b4
PE
1105 * lread.c: Integer overflow fixes.
1106 (read_integer): Radix is now EMACS_INT, not int,
1107 to improve quality of diagnostics for out-of-range radices.
1108 Calculate buffer size correctly for out-of-range radices.
1109 (read1): Check for integer overflow in radices, and in
1110 read-circle numbers.
82cb60d3
PE
1111 (read_escape): Avoid int overflow.
1112 (Fload, openp, read_buffer_size, read1)
1113 (substitute_object_recurse, read_vector, read_list, map_obarray):
1114 Use ptrdiff_t, not int, for sizes.
1115 (read1): Use EMACS_INT, not int, for sizes.
20270765 1116 Check for size overflow.
8b9ac8b4 1117
7fcccf1e
PE
1118 * image.c (cache_image): Check for size arithmetic overflow.
1119
bfbbd7e7
PE
1120 * lread.c: Integer overflow issues.
1121 (saved_doc_string_size, saved_doc_string_length)
1122 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1123 Now ptrdiff_t, not int.
1124 (read1): Don't assume doc string length fits in int. Check for
1125 out-of-range doc string lengths.
1126 (read_list): Don't assume file position fits in int.
39019e54 1127 (read_escape): Check for hex character overflow.
bfbbd7e7 1128
4e323265
LL
11292011-06-22 Leo Liu <sdl.web@gmail.com>
1130
1131 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1132 Move to minibuffer.el.
1133
85fece3e
PE
11342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1135
20b84ce9 1136 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1137 The following patches are for when GLYPH_DEBUG && !XASSERT.
1138 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1139 * dispnew.c (flush_stdout):
1140 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1141 Mark as externally visible.
1142 * dispnew.c (check_window_matrix_pointers): Now static.
1143 * dispnew.c (window_to_frame_vpos):
1144 * xfns.c (unwind_create_frame):
1145 * xterm.c (x_check_font): Remove unused local.
1146 * scroll.c (CHECK_BOUNDS):
1147 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1148 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1149 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1150 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1151 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1152 Now static.
1153 (debug_method_add): Use va_list and vsprintf rather than relying
1154 on undefined behavior with wrong number of arguments.
1155 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1156 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1157 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1158 since we're not interested in debugging glyphs with old libraries.
1159 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1160 GCC 4.6.0's static checking.
1161
0766b489
PE
11622011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1163
31fd4b32
PE
1164 Integer overflow and signedness fixes (Bug#8873).
1165 A few related buffer overrun fixes, too.
1166
b79e8648
PE
1167 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1168
0766b489
PE
1169 * dispextern.h (struct face.stipple):
1170 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1171 (x_bitmap_mask, x_allocate_bitmap_record)
1172 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1173 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1174 (x_create_bitmap_from_xpm_data):
1175 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1176 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1177 (.bitmaps_last):
1178 * xfaces.c (load_pixmap):
1179 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1180 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1181 (.bitmaps_last, struct x_output.icon_bitmap):
1182 Use ptrdiff_t, not int, for bitmap indexes.
1183 (x_allocate_bitmap_record): Check for size overflow.
1184 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1185
b081724f
PE
1186 Use ptrdiff_t, not int, for overlay counts.
1187 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1188 * editfns.c (overlays_around, get_pos_property):
1189 * textprop.c (get_char_property_and_overlay):
1190 * xdisp.c (next_overlay_change, note_mouse_highlight):
1191 * xfaces.c (face_at_buffer_position):
21514da7
PE
1192 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1193 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1194 (Fnext_overlay_change, Fprevious_overlay_change)
1195 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1196 Use ptrdiff_t, not int, for sizes.
21514da7 1197 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1198
3de73e5e
PE
1199 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1200
2606c57b
PE
1201 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1202 (x_session_initialize): Do not assume string length fits in int.
1203
aaafe47a
PE
1204 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1205 This is unlikely, but can occur if DPI is outlandish.
1206
2674ddc8 1207 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1208 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1209
28154962
PE
1210 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1211 * xrdb.c (magic_file_p, search_magic_path):
1212 Omit last arg SUFFIX; it was always 0. All callers changed.
1213 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1214
7de51af5
PE
1215 * xfont.c (xfont_match): Avoid need for strlen.
1216
25ed6cc3
PE
1217 * xfns.c: Don't assume strlen fits in int.
1218 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1219
4eab31dd
PE
1220 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1221 not unsigned long, as we prefer signed integers. All callers changed.
1222 Detect integer overflow in repeat count.
1223 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1224 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1225
171e2a58
PE
1226 * termcap.c: Don't assume sizes fit in int and never overflow.
1227 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1228 (gobble_line): Check for size-calculation overflow.
1229
ad39faca 1230 * minibuf.c (Fread_buffer):
6e5bb2dc 1231 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1232 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1233 Don't assume string length fits in int.
1234
52c61c22 1235 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1236 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1237
b5b8c9e5
PE
1238 * font.c: Don't assume string length fits in int.
1239 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1240 Use ptrdiff_t, not int.
ccd6111c
PE
1241 (font_intern_prop): Don't assume string length fits in int.
1242 Don't assume integer property fits in fixnum.
1243 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1244
882f0d81 1245 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1246 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1247 Reformulate so as not to need the command string.
1248 Invoke gzip -cd rather than gunzip, as it's more portable.
1249 (lock_info_type, lock_file_1, lock_file):
1250 Don't assume pid_t and time_t fit in unsigned long.
1251 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1252 (current_lock_owner): Prefer signed type for sizes.
1253 Use memcpy, not strncpy, where memcpy is what is really wanted.
1254 Don't assume (via atoi) that time_t and pid_t fit in int.
1255 Check for time_t and/or pid_t out of range, e.g., via a network share.
1256 Don't alloca where an auto var works fine.
1257
93f4cf88
PE
1258 * fileio.c: Fix some integer overflow issues.
1259 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1260 Don't assume string length fits in int.
1261 (directory_file_name): Don't assume string length fits in long.
1262 (make_temp_name): Don't assume pid fits in int, or that its print
1263 length is less than 20.
1264
f3e92b69
PE
1265 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1266
1bfdaf10
PE
1267 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1268
35016e9a
PE
1269 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1270
3d1e65a1
PE
1271 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1272 We prefer signed integers, even for size calculations.
1273
0b963a93
PE
1274 * emacs.c: Don't assume string length fits in 'int'.
1275 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1276 (main): Don't invoke strlen when not needed.
1277
573f4b54
PE
1278 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1279 (XD_DEBUG_MESSAGE): Don't waste a byte.
1280
989f33ba
PE
1281 * callproc.c (getenv_internal_1, getenv_internal)
1282 (Fgetenv_internal):
965d34eb
PE
1283 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1284
e4d29b33
PE
1285 * lread.c (invalid_syntax): Omit length argument.
1286 All uses changed. This doesn't fix a bug, but it simplifies the
1287 code away from its former Hollerith-constant appearance, and it's
1288 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1289 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1290
eb49b136
PE
1291 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1292 This didn't break anything, but it didn't help either.
1293 It's confusing to put a bogus integer in a place where the actual
1294 value does not matter.
9f62aeb1 1295 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1296 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1297
15375a22
PE
1298 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1299 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1300 implementation.
b61cc01c
PE
1301 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1302 We prefer signed types, and the value cannot exceed the EMACS_INT
1303 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1304 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1305 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1306 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1307
53b2623d
PE
1308 * indent.c (sane_tab_width): New function.
1309 (current_column, scan_for_column, Findent_to, position_indentation)
1310 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1311 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1312
51cab52b 1313 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1314
f2ed8a70
PE
1315 * lisp.h (lint_assume): New macro.
1316 * composite.c (composition_gstring_put_cache):
1317 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1318
abe80cc6
PE
1319 * editfns.c, insdel.c:
1320 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1321
b02c740e
PE
1322 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1323
ebc96716
PE
1324 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1325
b4e50fa0 1326 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1327 Use much-faster test for byte-length change.
311d5d7c 1328 Don't assume string byte-length fits in 'int'.
a4cf38e4 1329 Check that character arg fits in 'int'.
85461888 1330 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1331
c0c1ee9f
PE
1332 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1333
a498d7f4
PE
1334 * fns.c (concat): Catch string overflow earlier.
1335 Do not rely on integer wraparound.
1336
51cab52b
PE
1337 * dispextern.h (struct it.overlay_strings_charpos)
1338 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1339 * xdisp.c (forward_to_next_line_start)
1340 (back_to_previous_visible_line_start)
1341 (reseat_at_next_visible_line_start, next_element_from_buffer):
1342 Don't arbitrarily truncate the value of 'selective' to int.
1343
76031fad
PE
1344 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1345
5eb55db9
PE
1346 * composite.c: Don't truncate sizes to 'int'.
1347 (composition_gstring_p, composition_reseat_it)
1348 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1349 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1350 not EMACS_UINT, for indexes.
5eb55db9 1351
0703a717
PE
1352 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1353
d6202519
PE
1354 * buffer.c: Include <verify.h>.
1355 (struct sortvec.priority, struct sortstr.priority):
8961a454 1356 Now EMACS_INT, not int.
c20998a7 1357 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1358 (struct sortstr.size, record_overlay_string)
1359 (struct sortstrlist.size, struct sortlist.used):
1360 Don't truncate size to int.
1361 (record_overlay_string): Check for size-calculation overflow.
d6202519 1362 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1363
d5a19415
JM
13642011-06-22 Jim Meyering <meyering@redhat.com>
1365
029529ac 1366 Don't leak an XBM-image-sized buffer
d5a19415
JM
1367 * image.c (xbm_load): Free the image buffer after using it.
1368
a9041e6c
PE
13692011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 Port to Sun C.
1372 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1373 that Sun C diagnosed.
1374 * fns.c (secure_hash): Fix pointer signedness issue.
1375 * intervals.c (static_offset_intervals): New function.
1376 (offset_intervals): Use it.
1377
7f3f739f
LL
13782011-06-21 Leo Liu <sdl.web@gmail.com>
1379
1380 * deps.mk (fns.o):
1381 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1382 sha512.h.
1383
1384 * fns.c (secure_hash): Rename from crypto_hash_function and change
1385 the first arg to accept symbols.
5b66d427 1386 (Fsecure_hash): New primitive.
7f3f739f
LL
1387 (syms_of_fns): New symbols.
1388
76147d94
DD
13892011-06-20 Deniz Dogan <deniz@dogan.se>
1390
1391 * process.c (Fset_process_buffer): Clarify return value in
1392 docstring.
1393
7d7d0045
CY
13942011-06-18 Chong Yidong <cyd@stupidchicken.com>
1395
1396 * dispnew.c (add_window_display_history): Use BVAR.
1397
1398 * xdisp.c (debug_method_add): Use BVAR.
1399 (check_window_end, dump_glyph_matrix, dump_glyph)
1400 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1401
1402 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1403 Likewise.
1404
1405 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1406 check till after the cache is created in init_frame_faces.
1407
ff2bc410
SM
14082011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1409
1410 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1411
28177add
PE
14122011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1413
dd3482fe
PE
1414 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1415 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1416 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1417
393d71f3 1418 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1419 * fileio.c (Finsert_file_contents):
1420 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1421 Remove the old (too-loose) buffer overflow checks.
1422 They weren't needed, since make_gap checks for buffer overflow.
1423 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1424 The old code merely checked for Emacs fixnum overflow, and relied
1425 on undefined (wraparound) behavior. The new code avoids undefined
1426 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1427
2e6813b0 1428 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1429 Tune. Don't use wider integers than needed. Don't use alloca.
1430 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1431
599a9e4f
PE
1432 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1433
99561444
PE
1434 * insdel.c, lisp.h (buffer_overflow): New function.
1435 (insert_from_buffer_1, replace_range, replace_range_2):
1436 * insdel.c (make_gap_larger):
1437 * editfns.c (Finsert_char):
1438 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1439
28177add
PE
1440 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1441
e69dafad
PE
14422011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1443
a7af7fde 1444 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1445
b1c46f02
PE
1446 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1447 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1448
e69dafad
PE
1449 * fileio.c: Don't assume EMACS_INT fits in off_t.
1450 (emacs_lseek): New static function.
1451 (Finsert_file_contents, Fwrite_region): Use it.
1452 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1453
566684ea
PE
1454 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1455
e6966cd6
PE
1456 * fns.c: Don't overflow int when computing a list length.
1457 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1458 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1459 truncation on 64-bit hosts. Check for QUIT every
1460 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1461 faster and is responsive enough.
1462 (Flength): Report an error instead of overflowing an integer.
1463 (Fsafe_length): Return a float if the value is not representable
1464 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1465 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1466 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1467
dd0b0efb
PE
1468 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1469 (header_size, word_size): New constants.
1470 (allocate_vectorlike): Don't check size overflow here.
1471 (allocate_vector): Check it here instead, since this is the only
1472 caller of allocate_vectorlike that could cause overflow.
1473 Check that the new vector's length is representable as a fixnum.
1474
86fe5cfe
PE
1475 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1476 The previous code was bogus. For example, next_almost_prime (32)
1477 returned 39, which is undesirable as it is a multiple of 3; and
1478 next_almost_prime (24) returned 25, which is a multiple of 5 so
1479 why was the code bothering to check for multiples of 7?
1480
80e88859
PE
1481 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1482
4a2f0ad6
PE
1483 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1484
f66c7cf8
PE
1485 Variadic C functions now count arguments with ptrdiff_t.
1486 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1487 Back then I didn't know that the Emacs coding style prefers signed int.
1488 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1489 were being counted with int, which may truncate counts on 64-bit
1490 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1491 * lisp.h (struct Lisp_Subr.function.aMANY)
1492 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1493 Arg counts are now ptrdiff_t, not size_t.
1494 All variadic functions and their callers changed accordingly.
1495 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1496 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1497 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1498 * callint.c (Fcall_interactively): Check arg count for overflow,
1499 to avoid potential buffer overrun. Use signed char, not 'int',
1500 for 'varies' array, so that we needn't bother to check its size
1501 calculation for overflow.
1502 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1503 * eval.c (apply_lambda):
1504 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1505 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1506 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1507
a1759b76
PE
1508 * callint.c (Fcall_interactively): Don't use index var as event count.
1509
d96be9fc
PE
1510 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1511 * mem-limits.h (SIZE): Remove; no longer used.
1512
a690a978 1513 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1514
578c21e6
PE
1515 Remove unnecessary casts.
1516 * xterm.c (x_term_init):
1517 * xfns.c (x_set_border_pixel):
1518 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1519 These aren't needed now that we assume ANSI C.
1520
96f53c6c
PE
1521 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1522 It's more likely to cause problems (due to unsigned overflow)
1523 than to cure them.
1524
83c77d31
PE
1525 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1526
ee2079f1
PE
1527 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1528
6da65536
PE
1529 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1530
7147c4a4
PE
1531 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1532
193e32d9
PE
1533 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1534
e5533da6
PE
1535 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1536
9910e595
PE
1537 GLYPH_CODE_FACE returns EMACS_INT, not int.
1538 * dispextern.h (merge_faces):
1539 * xfaces.c (merge_faces):
01103c44
PE
1540 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1541 Don't assume EMACS_INT fits in int.
9910e595 1542
2638320e
PE
1543 * character.h (CHAR_VALID_P): Remove unused parameter.
1544 * fontset.c, lisp.h, xdisp.c: All uses changed.
1545
045eb8d9
PE
1546 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1547
c1f134b5
PE
1548 * fns.c (concat): Minor tuning based on overflow analysis.
1549 This doesn't fix any bugs. Use int to hold character, instead
1550 of constantly refetching from Emacs object. Use XFASTINT, not
1551 XINT, for value known to be a character. Don't bother comparing
1552 a single byte to 0400, as it's always less.
1553
395fcb93 1554 * floatfns.c (Fexpt):
327eeec8
PE
1555 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1556
abbd3d23
PE
1557 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1558 for characters.
1559
684a03ef
PE
1560 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1561
0fed43f3
PE
1562 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1563 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1564 incorrectly succeed when S was a string, because 4294967386 was
1565 truncated before it was used.
1566
8fd02eb7
PE
1567 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1568 Otherwise, an out-of-range integer could cause undefined behavior
1569 on a 64-bit host.
1570
f8c86b69
PE
1571 * composite.c: Use int, not EMACS_INT, for characters.
1572 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1573 EMACS_INT, for values that are known to be in character range.
1574 This doesn't fix any bugs but is the usual style inside Emacs and
1575 may generate better code on 32-bit machines.
1576
34206dd2
PE
1577 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1578 This is for reasons similar to the recent CHAR_STRING fix.
1579 * charset.c (Fencode_char): Check that character arg is actually
1580 a character. Pass an int to ENCODE_CHAR.
1581 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1582 wider than 'int', as a compile-time check to prevent future regressions
1583 in this area.
1584
c5958d4c 1585 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1586
1587 Make sure a 64-bit char is never passed to CHAR_STRING.
1588 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1589 by silently ignoring the top 32 bits, allowing some values
1590 that were far too large to be valid characters.
1591 * character.h: Include <verify.h>.
1592 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1593 arguments are no wider than unsigned, as a compile-time check
1594 to prevent future regressions in this area.
1595 * data.c (Faset):
01103c44 1596 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1597 (Fsubst_char_in_region):
1598 * fns.c (concat):
1599 * xdisp.c (decode_mode_spec_coding):
1600 Adjust to CHAR_STRING's new requirement.
1601 * editfns.c (Finsert_char, Fsubst_char_in_region):
1602 * fns.c (concat): Check that character args are actually
1603 characters. Without this test, these functions did the wrong
1604 thing with wildly out-of-range values on 64-bit hosts.
1605
d37ca623
PE
1606 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1607 These casts should not be needed on 32-bit hosts, either.
1608 * keyboard.c (read_char):
1609 * lread.c (Fload): Remove casts to unsigned.
1610
ea204efb
PE
1611 * lisp.h (UNSIGNED_CMP): New macro.
1612 This fixes comparison bugs on 64-bit hosts.
1613 (ASCII_CHAR_P): Use it.
1614 * casefiddle.c (casify_object):
01103c44 1615 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1616 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1617 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1618 * dispextern.h (FACE_FROM_ID):
1619 * keyboard.c (read_char): Use UNSIGNED_CMP.
1620
41cb286c
PE
1621 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1622 not to EMACS_INT, to avoid GCC warning.
1623
4a1b9832
PE
1624 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1625
55daad71
PE
1626 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1627 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1628 isn't needed on 32-bit machines.
8f95c75c 1629
01103c44
PE
1630 * buffer.c (Fgenerate_new_buffer_name):
1631 Use EMACS_INT for count, not int.
0ceccced 1632 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1633
1634 * data.c (Qcompiled_function): Now static.
1635
c6f072e7
PE
1636 * window.c (window_body_lines): Now static.
1637
20ce5912
PE
1638 * image.c (gif_load): Rename local to avoid shadowing.
1639
9c4c5f81
PE
1640 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1641 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1642 * alloc.c (make_save_value): Integer argument is now of type
1643 ptrdiff_t, not int.
1644 (mark_object): Use ptrdiff_t, not int.
1645 * lisp.h (pD): New macro.
1646 * print.c (print_object): Use it.
1647
c0c5c8ae
PE
1648 * alloc.c: Use EMACS_INT, not int, to count objects.
1649 (total_conses, total_markers, total_symbols, total_vector_size)
1650 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1651 (total_free_floats, total_floats, total_free_intervals)
1652 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1653 Now EMACS_INT, not int. All uses changed.
1654 (Fgarbage_collect): Compute overall total using a double, so that
1655 integer overflow is less likely to be a problem. Check for overflow
1656 when converting back to an integer.
5a25e253
PE
1657 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1658 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1659 These were 'int' variables that could overflow on 64-bit hosts;
1660 they were never used, so remove them instead of repairing them.
211a0b2a 1661 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1662 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1663 Previously, this ceilinged at INT_MAX, but that doesn't work on
1664 64-bit machines.
e46bb31a 1665 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1666
c78baabf 1667 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1668 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1669 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1670 when a (possibly-narrower) signed value would do just as well.
1671 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1672
c9d624c6
PE
1673 * alloc.c: Catch some string size overflows that we were missing.
1674 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1675 for convenience in STRING_BYTES_MAX.
1676 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1677 The definition here is exact; the one in lisp.h was approximate.
1678 (allocate_string_data): Check for string overflow. This catches
1679 some instances we weren't catching before. Also, it catches
1680 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1681 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1682 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1683
c9d624c6
PE
1684 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1685 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1686 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1687
353032ce
PE
1688 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1689
2bccce07
PE
1690 * alloc.c (Fmake_string): Check for out-of-range init.
1691
0ac30604
SM
16922011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1693
1694 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1695
c195f2de
JD
16962011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1697
1698 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1699 xg_get_default_scrollbar_width.
1700
1701 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1702 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1703 (style_changed_cb): Call update_theme_scrollbar_width and call
1704 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1705 all frames (Bug#8505).
1706 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1707 Call gtk_window_set_resizable if HAVE_GTK3.
1708 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1709 and height if HAVE_GTK3 (Bug#8505).
1710 (scroll_bar_width_for_theme): New variable.
1711 (update_theme_scrollbar_width): New function.
1712 (xg_get_default_scrollbar_width): Move code to
1713 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1714 (xg_initialize): Call update_theme_scrollbar_width.
1715
1716 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1717
1718 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1719
e10ac9f1
MR
17202011-06-12 Martin Rudalics <rudalics@gmx.at>
1721
1722 * frame.c (make_frame): Call other_buffer_safely instead of
1723 other_buffer.
1724
1725 * window.c (temp_output_buffer_show): Call display_buffer with
1726 second argument Vtemp_buffer_show_specifiers and reset latter
1727 immediately after the call.
1728 (Vtemp_buffer_show_specifiers): New variable.
1729 (auto_window_vscroll_p, next_screen_context_lines)
1730 (Vscroll_preserve_screen_position): Remove leading asterisks from
1731 doc-strings.
1732
2d3c217e 17332011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1734
7b7f97e8 1735 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1736 * buffer.c (Qclone_number): Remove for now, as it's unused.
1737 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1738 (record_buffer): Remove unused local.
1739 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1740 (set_frame_buffer_list): Remove; unused.
1741 * frame.h (other_visible_frames): Remove decl.
1742 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1743 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1744 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1745 if HAVE_GPM.
1746 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1747 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1748 Define only if HAVE_GPM.
1749 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1750 (update_hints_inhibit): Remove; never set. All uses removed.
1751 * widgetprv.h (emacsFrameClassRec): Remove decl.
1752 * window.c (delete_deletable_window): Now returns void, since it
1753 wasn't returning anything.
1754 (compare_window_configurations): Remove unused locals.
1755 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1756 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1757 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1758 the same widths as pointers. This follows up on the 2011-05-06 patch.
1759 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1760 * xterm.h: Likewise.
1761 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1762
1384b89e
JB
17632011-06-12 Juanma Barranquero <lekktu@gmail.com>
1764
1765 * makefile.w32-in: Update dependencies.
1766 (LISP_H): Add lib/intprops.h.
1767
1100a63c
CY
17682011-06-11 Chong Yidong <cyd@stupidchicken.com>
1769
1770 * image.c (gif_load): Add animation frame delay to the metadata.
1771 (syms_of_image): Use DEFSYM. New symbol `delay'.
1772
6198ccd0
MR
17732011-06-11 Martin Rudalics <rudalics@gmx.at>
1774
1775 * window.c (delete_deletable_window): Re-add.
1776 (Fset_window_configuration): Rewrite to handle dead buffers and
1777 consequently deletable windows.
1778 (window_tree, Fwindow_tree): Remove. Supply functionality in
1779 window.el.
1780 (compare_window_configurations): Simplify code.
1781
b6e3633c
AS
17822011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1783
1ab0dee5
AS
1784 * image.c (imagemagick_load_image): Fix type mismatch.
1785 (Fimagemagick_types): Likewise.
1786
b6e3633c
AS
1787 * window.h (replace_buffer_in_windows): Declare.
1788
9397e56f
MR
17892011-06-11 Martin Rudalics <rudalics@gmx.at>
1790
1791 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1792 Qclone_number. Remove external declaration of Qdelete_window.
1793 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1794 code.
1795 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1796 Qbuffer_list_update_hook if allowed.
1797 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1798 buffer list implementation.
1799 (other_buffer_safely): New function.
1800 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1801 calls to replace_buffer_in_windows and
1802 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1803 if allowed.
1804 (record_buffer): Inhibit quitting and rewrite using quittable
1805 functions. Run Qbuffer_list_update_hook if allowed.
1806 (Frecord_buffer, Funrecord_buffer): New functions.
1807 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1808 switch-to-buffer to window.el.
1809 (bury-buffer): Move to window.el.
1810 (Vbuffer_list_update_hook): New variable.
1811
1812 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1813 section.
1814
1815 * window.h (resize_frame_windows): Move up in code.
1816 (Fwindow_frame): Remove EXFUN.
1817 (replace_buffer_in_all_windows): Remove prototype.
1818 (replace_buffer_in_windows_safely): Add prototype.
1819
1820 * window.c: Declare Qdelete_window static again. Move down
1821 declaration of select_count.
1822 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1823 (Fother_window): Move to window.el.
1824 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1825 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1826 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1827 window.el.
1828 (replace_buffer_in_windows): Implement by calling
1829 Qreplace_buffer_in_windows.
1830 (replace_buffer_in_all_windows): Remove with some functionality
1831 moved into replace_buffer_in_windows_safely.
1832 (replace_buffer_in_windows_safely): New function.
1833 (select_window_norecord, select_frame_norecord): Move in front
1834 of run_window_configuration_change_hook. Remove now obsolete
1835 declarations.
1836 (Fset_window_buffer): Rewrite doc-string. Call
1837 Qrecord_window_buffer.
1838 (keys_of_window): Move binding for other-window to window.el.
1839
b50691aa
CY
18402011-06-11 Chong Yidong <cyd@stupidchicken.com>
1841
1842 * dispextern.h (struct image): Replace data member, whose int_val
1843 and ptr_val fields were not used by anything, with a single
1844 lisp_val object.
1845
1846 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1847 (gif_clear_image, gif_load, imagemagick_load_image)
1848 (gs_clear_image, gs_load): Callers changed.
1849
3f754b86
PE
18502011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1851
cca69397
PE
1852 * buffer.h: Include <time.h>, for time_t.
1853 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1854
109e28d0
PE
1855 Fix minor problems found by static checking.
1856
60737f02
PE
1857 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1858
4b66faf3
PE
1859 Make identifiers static if they are not used in other modules.
1860 * data.c (Qcompiled_function, Qframe, Qvector):
1861 * image.c (QimageMagick, Qsvg):
1862 * minibuf.c (Qmetadata):
1863 * window.c (resize_window_check, resize_root_window): Now static.
1864 * window.h (resize_window_check, resize_root_window): Remove decls.
1865
109e28d0
PE
1866 * window.c (window_deletion_count, delete_deletable_window):
1867 Remove; unused.
46a4ce9e
PE
1868 (window_body_lines): Now static.
1869 (Fdelete_other_windows_internal): Mark vars as initialized.
1870 Make sure 'resize_failed' is initialized.
1871 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1872 (resize_window_apply): Remove unused local.
1873 * window.h (delete_deletable_window): Remove decl.
1874
109e28d0 1875 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1876 (imagemagick_load_image): Fix pointer signedness problem by changing
1877 last arg from unsigned char * to char *. All uses changed.
1878 Also, fix a local for similar reasons.
1879 Remove unused locals. Remove locals to avoid shadowing.
1880 (fn_rsvg_handle_free): Remove; unused.
1881 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1882 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1883
3f754b86
PE
1884 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1885
2547adb1
CY
18862011-06-10 Chong Yidong <cyd@stupidchicken.com>
1887
1888 * image.c (gif_load): Fix omitted cast error introduced by
1889 2011-06-06 change.
1890
2c8e37d4
MR
18912011-06-10 Martin Rudalics <rudalics@gmx.at>
1892
1893 * window.h (resize_proportionally, orig_total_lines)
1894 (orig_top_line): Remove from window structure.
1895 (set_window_height, set_window_width, change_window_heights)
1896 (Fdelete_window): Remove prototypes.
1897 (resize_frame_windows): Remove duplicate declaration.
1898
440a42e3
EZ
18992011-06-10 Eli Zaretskii <eliz@gnu.org>
1900
1901 * window.h (resize_frame_windows, resize_window_check)
1902 (delete_deletable_window, resize_root_window)
1903 (resize_frame_windows): Declare prototypes.
1904
1905 * window.c (resize_window_apply): Make definition be "static" to
1906 match the prototype.
1907
562dd5e9
MR
19082011-06-10 Martin Rudalics <rudalics@gmx.at>
1909
1910 * window.c: Remove declarations of Qwindow_size_fixed,
1911 window_min_size_1, window_min_size_2, window_min_size,
1912 size_window, window_fixed_size_p, enlarge_window, delete_window.
1913 Remove static from declaration of Qdelete_window, it's
1914 temporarily needed by Fbury_buffer.
1915 (replace_window): Don't assign orig_top_line and
1916 orig_total_lines.
1917 (Fdelete_window, delete_window): Remove. Window deletion is
1918 handled by window.el.
1919 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1920 Fdelete_window calls with calls to Qdelete_window.
1921 (Fdelete_other_windows): Remove. Deleting other windows is
1922 handled by window.el.
1923 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1924 handled in window.el.
1925 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1926 Window minimum sizes are handled in window.el.
1927 (shrink_windows, size_window, set_window_height)
1928 (set_window_width, change_window_heights, window_height)
1929 (window_width, CURBEG, CURSIZE, enlarge_window)
1930 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1931 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1932 handled in window.el.
1933 (make_dummy_parent): Rename to make_parent_window and give it a
1934 second argument horflag.
1935 (make_window): Don't set resize_proportionally any more.
1936 (Fsplit_window): Remove. Windows are split in window.el.
1937 (save_restore_action, save_restore_orig_size)
1938 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1939 Resize mini windows in window.el.
1940 (grow_mini_window, shrink_mini_window): Implement by calling
1941 Qresize_root_window_vertically, resize_window_check and
1942 resize_window_apply.
1943 (saved_window, Fset_window_configuration, save_window_save): Do
1944 not handle orig_top_line, orig_total_lines, and
1945 resize_proportionally.
1946 (window_min_height, window_min_width): Move to window.el.
1947 (keys_of_window): Move bindings for delete-other-windows,
1948 split-window, delete-window and enlarge-window to window.el.
1949
1950 * buffer.c: Temporarily extern Qdelete_window.
1951 (Fbury_buffer): Temporarily call Qdelete_window instead of
1952 Fdelete_window (Fbury_buffer will move to window.el soon).
1953
1954 * frame.c (set_menu_bar_lines_1): Remove code handling
1955 orig_top_line and orig_total_lines.
1956
1957 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1958 set_window_height but set heights directly.
1959 (change_frame_size_1): Use resize_frame_windows.
1960
1961 * xdisp.c (init_xdisp): Don't use set_window_height but set
1962 heights directly.
1963
1964 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1965 resize_frame_windows instead of change_window_heights and run
1966 run_window_configuration_change_hook.
1967
1968 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1969 instead of change_window_heights and run
1970 run_window_configuration_change_hook.
1971
1a13852e
MR
19722011-06-09 Martin Rudalics <rudalics@gmx.at>
1973
1974 * window.c (replace_window): Rename second argument REPLACEMENT to
1975 NEW. New third argument SETFLAG. Rewrite.
1976 (delete_window, make_dummy_parent): Call replace_window with
1977 third argument 1.
1978 (window_list_1): Move down in code.
1979 (run_window_configuration_change_hook): Move set_buffer part
1980 before select_frame_norecord part in order to unwind correctly.
1981 Rename count1 to count.
1982 (recombine_windows, delete_deletable_window, resize_root_window)
1983 (Fdelete_other_windows_internal)
1984 (Frun_window_configuration_change_hook, make_parent_window)
1985 (resize_window_check, resize_window_apply, Fresize_window_apply)
1986 (resize_frame_windows, Fsplit_window_internal)
1987 (Fdelete_window_internal, Fresize_mini_window_internal): New
1988 functions.
1989 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1990
f3d1777e
MR
19912011-06-08 Martin Rudalics <rudalics@gmx.at>
1992
496e208e
MR
1993 * window.h (window): Add some new members to window structure -
1994 normal_lines, normal_cols, new_total, new_normal, clone_number,
1995 splits, nest, prev_buffers, next_buffers.
1996 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1997 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1998
f3d1777e
MR
1999 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2000 Remove.
496e208e
MR
2001 (make_dummy_parent): Set new members of windows structure.
2002 (make_window): Move down in code. Handle new members of window
2003 structure.
2004 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2005 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2006 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2007 (Fset_window_prev_buffers, Fwindow_next_buffers)
2008 (Fset_window_next_buffers, Fset_window_clone_number): New
2009 functions.
2010 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2011 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2012 Doc-string fixes.
2013 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2014 Argument WINDOW can be now internal window too.
2015 (Fwindow_use_time): Move up in code.
2016 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2017 Rewrite doc-string.
2018 (Fset_window_configuration, saved_window)
2019 (Fcurrent_window_configuration, save_window_save): Handle new
2020 members of window structure.
b9e809c2
MR
2021 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2022 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2023 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2024 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2025 Qget_mru_window, Qresize_root_window,
2026 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2027 Qauto_buffer_name; staticpro them.
f3d1777e 2028
abde8f8c
MR
20292011-06-07 Martin Rudalics <rudalics@gmx.at>
2030
2031 * window.c (Fwindow_total_size, Fwindow_left_column)
2032 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2033 (Fwindow_list_1): New functions.
2034 (window_box_text_cols): Replace with window_body_cols.
2035 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2036 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2037 (delete_window, Fset_window_configuration): Call
2038 delete_all_subwindows with window as argument.
2039 (delete_all_subwindows): Take a window as argument and not a
2040 structure. Rewrite.
190b47e6
MR
2041 (window_loop): Remove handling of GET_LRU_WINDOW and
2042 GET_LARGEST_WINDOW.
2043 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2044
2045 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2046 window_box_text_cols. delete_all_subwindows now takes a
2047 Lisp_Object as argument.
abde8f8c
MR
2048
2049 * indent.c (compute_motion, Fcompute_motion): Use
2050 window_body_cols instead of window_box_text_cols.
2051
fa8a67e6
MR
2052 * frame.c (delete_frame): Call delete_all_subwindows with root
2053 window as argument.
2054
a54e3482
DC
20552011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2056
2057 * fns.c (Fputhash): Document return value.
2058
60002bf5
CY
20592011-06-06 Chong Yidong <cyd@stupidchicken.com>
2060
2061 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2062
0c671da6 20632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2064
b862a52a 2065 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2066
be44ca6c
PE
2067 Check for overflow when converting integer to cons and back.
2068 * charset.c (Fdefine_charset_internal, Fdecode_char):
2069 Use cons_to_unsigned to catch overflow.
2070 (Fencode_char): Use INTEGER_TO_CONS.
2071 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2072 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2073 * data.c (long_to_cons, cons_to_long): Remove.
2074 (cons_to_unsigned, cons_to_signed): New functions.
2075 These signal an error for invalid or out-of-range values.
2076 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2077 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2078 * font.c (Ffont_variation_glyphs):
2079 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2080 * lisp.h: Include <intprops.h>.
2081 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2082 (cons_to_signed, cons_to_unsigned): New decls.
2083 (long_to_cons, cons_to_long): Remove decls.
2084 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2085 (Fprimitive_undo): Use CONS_TO_INTEGER.
2086 * xfns.c (Fx_window_property): Likewise.
2087 * xselect.c: Include <limits.h>.
2088 (x_own_selection, selection_data_to_lisp_data):
2089 Use INTEGER_TO_CONS.
2090 (x_handle_selection_request, x_handle_selection_clear)
2091 (x_get_foreign_selection, Fx_disown_selection_internal)
2092 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2093 (lisp_data_to_selection_data): Use cons_to_unsigned.
2094 (x_fill_property_data): Use cons_to_signed.
2095 Report values out of range.
2096
d1f3d2af
PE
2097 Check for buffer and string overflow more precisely.
2098 * buffer.h (BUF_BYTES_MAX): New macro.
2099 * lisp.h (STRING_BYTES_MAX): New macro.
2100 * alloc.c (Fmake_string):
2101 * character.c (string_escape_byte8):
2102 * coding.c (coding_alloc_by_realloc):
2103 * doprnt.c (doprnt):
2104 * editfns.c (Fformat):
2105 * eval.c (verror):
2106 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2107 since they may not be the same number.
2108 * editfns.c (Finsert_char):
2109 * fileio.c (Finsert_file_contents):
2110 Likewise for BUF_BYTES_MAX.
2111
dd52fcea
PE
2112 * image.c: Use ptrdiff_t, not int, for sizes.
2113 (slurp_file): Switch from int to ptrdiff_t.
2114 All uses changed.
2115 (slurp_file): Check that file size fits in both size_t (for
2116 malloc) and ptrdiff_t (for sanity and safety).
2117
7f9bbdbb
PE
2118 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2119 if b->modtime has its maximal value.
2120
dfe18f82
PE
2121 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2122
84acfcf0
PE
2123 Don't assume time_t can fit into int.
2124 * buffer.h (struct buffer.modtime): Now time_t, not int.
2125 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2126 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2127
ccd9a01a
PE
2128 Minor fixes for signed vs unsigned integers.
2129 * character.h (MAYBE_UNIFY_CHAR):
2130 * charset.c (maybe_unify_char):
2131 * keyboard.c (read_char, reorder_modifiers):
2132 XINT -> XFASTINT, since the integer must be nonnegative.
2133 * ftfont.c (ftfont_spec_pattern):
2134 * keymap.c (access_keymap, silly_event_symbol_error):
2135 XUINT -> XFASTINT, since the integer must be nonnegative.
2136 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2137 since it makes no difference and we prefer signed.
2138 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2139 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2140 nonnegative.
2141
d6d100dd
SM
21422011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2143
2144 * window.h (Fwindow_frame): Declare.
2145
2b6148e4
PE
21462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2149 (SPARE_MEMORY): Always define.
2150 (LARGE_REQUEST): Remove.
2151 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2152
f230ecc9
MR
21532011-06-06 Martin Rudalics <rudalics@gmx.at>
2154
727e958e
MR
2155 * lisp.h: Move EXFUNS for Fframe_root_window,
2156 Fframe_first_window and Fset_frame_selected_window to window.h.
2157
2158 * window.h: Move EXFUNS for Fframe_root_window,
2159 Fframe_first_window and Fset_frame_selected_window here from
2160 lisp.h.
2161
2162 * frame.c (Fwindow_frame, Fframe_first_window)
2163 (Fframe_root_window, Fframe_selected_window)
2164 (Fset_frame_selected_window): Move to window.c.
2165 (Factive_minibuffer_window): Move to minibuf.c.
2166 (Fother_visible_frames_p): New function.
2167
2168 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2169
f230ecc9
MR
2170 * window.c (decode_window, decode_any_window): Move up in code.
2171 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2172 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2173 (Fwindow_buffer): Move up and rewrite doc-string.
2174 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2175 (Fwindow_prev): New functions.
727e958e
MR
2176 (Fwindow_frame): Move here from frame.c. Accept any window as
2177 argument.
2178 (Fframe_root_window, Fframe_first_window)
2179 (Fframe_selected_window): Move here from frame.c. Accept frame
2180 or arbitrary window as argument. Update doc-strings.
2181 (Fminibuffer_window): Move up in code.
2182 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2183 (Fset_frame_selected_window): Move here from frame.c.
2184 Marginal rewrite.
727e958e
MR
2185 (Fselected_window, select_window, Fselect_window): Move up in
2186 code. Minor doc-string fixes.
f230ecc9 2187
4d09bcf6
PE
21882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2191 Do not assume that spare memory exists; that assumption is valid
2192 only if SYSTEM_MALLOC.
2193 (LARGE_REQUEST): New macro, so that the issue of large requests
2194 is separated from the issue of spare memory.
2195
810928a2
AS
21962011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2197
172418ad
AS
2198 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2199 format. (Bug#8806)
2200
43f862f7
AS
2201 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2202
810928a2
AS
2203 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2204 before statements.
2205
a059fe24
JD
22062011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2207
2208 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2209
2210 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2211
2212 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2213 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2214
989bf368
JB
22152011-06-05 Juanma Barranquero <lekktu@gmail.com>
2216
2217 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2218
4b80f674
CY
22192011-06-04 Chong Yidong <cyd@stupidchicken.com>
2220
2221 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2222 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2223 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2224 New error handlers.
4b80f674
CY
2225 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2226 Obey Vx_select_enable_clipboard_manager. Catch errors in
2227 x_clipboard_manager_save (Bug#8779).
2228 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2229 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2230
99a33b77 22312011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2232
2233 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2234
99a33b77 22352011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2236
2237 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2238 in the current matrix if keep_current_p is non-zero.
2239
8264569d
EZ
22402011-06-04 Eli Zaretskii <eliz@gnu.org>
2241
2242 * bidi.c (bidi_level_of_next_char): Fix last change.
2243
57f97249
EZ
22442011-06-03 Eli Zaretskii <eliz@gnu.org>
2245
fec2107c 2246 Support bidi reordering of text covered by display properties.
57f97249 2247
fec2107c
EZ
2248 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2249 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2250 (bidi_cache_search, bidi_cache_iterator_state)
2251 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2252 (bidi_level_of_next_char, bidi_move_to_visually_next):
2253 Support character positions inside a run of characters covered by a
fec2107c
EZ
2254 display string.
2255 (bidi_paragraph_init, bidi_resolve_explicit_1)
2256 (bidi_level_of_next_char): Call bidi_fetch_char and
2257 bidi_fetch_char_advance instead of FETCH_CHAR and
2258 FETCH_CHAR_ADVANCE.
2259 (bidi_init_it): Initialize new members.
2260 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2261 definitions.
2262 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2263 instead of using explicit *_CHAR codes.
d6d100dd
SM
2264 (bidi_resolve_explicit, bidi_resolve_weak):
2265 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2266 bidirectional text is supported only in multibyte buffers.
2267 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2268 it to initialize the frame_window_p member of struct bidi_it.
2269 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2270 (bidi_resolve_explicit, bidi_resolve_weak)
2271 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2272 bidi_it->nchars is non-positive.
2273 (bidi_level_of_next_char): Don't try to lookup the cache for the
2274 next/previous character if nothing is cached there yet, or if we
2275 were just reseat()'ed to a new position.
c40e2fb2 2276
0e14fe90
EZ
2277 * xdisp.c (set_cursor_from_row): Set start and stop points
2278 according to the row's direction when priming the loop that looks
2279 for the glyph on which to display cursor.
2280 (single_display_spec_intangible_p): Function deleted.
2281 (display_prop_intangible_p): Reimplement to call
2282 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2283 Accept 3 additional arguments needed by handle_display_spec.
2284 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2285 values: lists, `(when COND...)' forms, etc.
2286 (single_display_spec_string_p): Support property values that are
2287 lists with the argument STRING its top-level element.
2288 (display_prop_string_p): Fix the condition for processing a
2289 property that is a list to be consistent with handle_display_spec.
fec2107c 2290 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2291 last portion of handle_display_prop.
2292 (compute_display_string_pos): Accept additional argument
2293 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2294 value of a `display' property is a "replacing spec".
2295 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2296 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2297 the display property, but just return a value indicating whether
2298 the display property will replace the characters it covers.
2299 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2300 frame_window_p members of struct bidi_it.
d6d100dd
SM
2301 (compute_display_string_pos, compute_display_string_end):
2302 New functions.
fec2107c
EZ
2303 (push_it): Accept second argument POSITION, where pop_it should
2304 jump to continue iteration.
2305 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2306
fec2107c
EZ
2307 * keyboard.c (adjust_point_for_property): Adjust the call to
2308 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2309
2310 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2311 (bidi_init_it): Update prototypes.
2312 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2313 (compute_display_string_pos, compute_display_string_end):
2314 Declare prototypes.
fec2107c
EZ
2315 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2316 EMACS_INT.
fc6f18ce 2317
40087514 23182011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2319
57f53182
PE
2320 Malloc failure behavior now depends on size of allocation.
2321 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2322 * lisp.h: Change signatures accordingly.
2323 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2324 All callers changed. (Bug#8762)
2325
2326 * gnutls.c: Use Emacs's memory allocators.
2327 Without this change, the gnutls library would invoke malloc etc.
2328 directly, which causes problems on non-SYNC_INPUT hosts, and which
2329 runs afoul of improving memory_full behavior. (Bug#8761)
2330 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2331 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2332 xfree instead of the default malloc, realloc, free.
2333 (Fgnutls_boot): No need to check for memory allocation failure,
2334 since xmalloc does that for us.
2335
ac32cd99 2336 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2337 * category.c (hash_get_category_set):
2338 * ccl.c (ccl_driver):
2339 * charset.c (Fdefine_charset_internal):
2340 * charset.h (struct charset.hash_index):
2341 * composite.c (get_composition_id, gstring_lookup_cache)
2342 (composition_gstring_put_cache):
2343 * composite.h (struct composition.hash_index):
2344 * dispextern.h (struct image.hash):
2345 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2346 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2347 (hashfn_equal, hashfn_user_defined, make_hash_table)
2348 (maybe_resize_hash_table, hash_lookup, hash_put)
2349 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2350 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2351 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2352 * image.c (make_image, search_image_cache, lookup_image)
2353 (xpm_put_color_table_h):
2354 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2355 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2356 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2357 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2358 * alloc.c (allocate_vectorlike):
2359 Check for overflow in vector size calculations.
2360 * ccl.c (ccl_driver):
2361 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2362 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2363 need to be updated by these changes.
40087514
PE
2364 * fns.c (make_hash_table, maybe_resize_hash_table):
2365 Check for integer overflow with large hash tables.
0de4bb68
PE
2366 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2367 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2368 (SXHASH_REDUCE): New macro.
2369 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2370 Use it instead of discarding useful hash info with large hash values.
2371 (sxhash_float): New function.
2372 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2373 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2374 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2375 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2376 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2377 Adjust signatures to match updated version of code.
2378 (consing_since_gc): Now EMACS_INT, since a single hash table can
2379 use more than INT_MAX bytes.
2380
698d32e2
DN
23812011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2382
2383 Make it possible to build with GCC-4.6+ -O2 -flto.
2384
2385 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2386
fd6fa53f
SM
23872011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2388
2389 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2390 Call minibuffer-inactive-mode.
2391
864db017
JB
23922011-05-31 Juanma Barranquero <lekktu@gmail.com>
2393
2394 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2395 Update dependencies.
2396
2ad0baf4
DN
23972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2398
2399 * data.c (init_data): Remove code for UTS, this system is not
2400 supported anymore.
2401
4fcc2638
DN
24022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2403
2404 Don't force ./temacs to start in terminal mode.
2405
2406 * frame.c (make_initial_frame): Initialize faces in all cases, not
2407 only when CANNOT_DUMP is defined.
2408 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2409
c56e0fd5
DN
24102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2411
2412 * dispnew.c (add_window_display_history): Use const for the string
2413 pointer. Remove declaration, not needed.
2414
333d54da 24152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2416
55d4c1b2 2417 Use 'inline', not 'INLINE'.
333d54da 2418 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2419 * alloc.c, fontset.c (INLINE): Remove.
2420 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2421 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2422 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2423 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2424 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2425
738db178
DN
24262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2427
2428 Make it possible to run ./temacs.
2429
2430 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2431 syms_of_callproc does the same thing. Remove test for
2432 "initialized", do it in the caller.
2433 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2434
620c53a6
SM
24352011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2436
2437 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2438 (read_minibuf): Use get_minibuffer.
2439 (syms_of_minibuf): Use DEFSYM.
2440 (Qmetadata): New var.
2441 * data.c (Qbuffer): Don't make it static.
2442 (syms_of_data): Use DEFSYM.
2443
e003a292
PE
24442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2445
2446 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2447 (CCL_CODE_MIN): New macro.
2448
ed008a6d
PE
24492011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2450
3687c2ef
PE
2451 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2452
ed008a6d
PE
2453 * eval.c (Qdebug): Now static.
2454 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2455 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2456 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2457
d66c4c7c
CY
24582011-05-29 Chong Yidong <cyd@stupidchicken.com>
2459
2460 * image.c: Various fixes to ImageMagick code comments.
2461 (Fimagemagick_types): Doc fix.
2462
5fbc2025
PE
24632011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2464
0196f88a
PE
2465 Minor fixes prompted by GCC 4.6.0 warnings.
2466
2467 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2468
5fbc2025
PE
2469 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2470 (x_clipboard_manager_save_all): Move extern decl to ...
2471 * xterm.h: ... here, so that it can be checked for consistency.
2472
1dd3c2d9
CY
24732011-05-29 Chong Yidong <cyd@stupidchicken.com>
2474
2475 * xselect.c (x_clipboard_manager_save_frame)
2476 (x_clipboard_manager_save_all): New functions.
2477 (Fx_clipboard_manager_save): Lisp function deleted.
2478
2479 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2480 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2481
2482 * xterm.h: Update prototype.
2483
5ba6571d
WX
24842011-05-28 William Xu <william.xwl@gmail.com>
2485
2486 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2487 exiting (Bug#8239).
2488
3eaff834
JM
24892011-05-28 Jim Meyering <meyering@redhat.com>
2490
e1900994 2491 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2492 * fns.c (to_uchar): Define.
2493 (crypto_hash_function): Use it to convert some newly-signed
2494 variables to unsigned, to avoid sign-extension bugs. For example,
2495 without this change, (md5 "truc") would evaluate to
2496 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2497 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2498 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2499
0f6990a7
PE
25002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2501
2502 Integer overflow fixes.
c8a9ca5a 2503
08686060
PE
2504 * dbusbind.c: Serial number integer overflow fixes.
2505 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2506 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2507 to hold a serial number that is too large for a fixnum.
2508 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2509 Check for serial numbers out of range. Decode any serial number
59568bf0 2510 that was so large that it became a float. (Bug#8722)
08686060 2511
2d1fc3c7
PE
2512 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2513 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2514 Use XFASTINT rather than XUINT when numbers are nonnegative.
2515 (xd_append_arg, Fdbus_method_return_internal):
2516 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2517 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2518 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2519 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2520 (Bug#8722)
2d1fc3c7 2521
c8a9ca5a
PE
2522 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2523
519e1d69
PE
2524 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2525
30569699
PE
2526 ccl: add integer overflow checks
2527 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2528 (IN_INT_RANGE): New macros.
2529 (ccl_driver): Use them to check for integer overflow when
2530 decoding a CCL program. Many of the new checks are whether XINT (x)
2531 fits in int; it doesn't always, on 64-bit hosts. The new version
2532 doesn't catch all possible integer overflows, but it's an
847044ea 2533 improvement. (Bug#8719)
30569699 2534
c11285dc
PE
2535 * alloc.c (make_event_array): Use XINT, not XUINT.
2536 There's no need for unsigned here.
2537
fdccd48e
PE
2538 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2539 This follows up to the 2011-05-06 change that substituted uintptr_t
2540 for EMACS_INT. This case wasn't caught back then.
2541
37910ab2
PE
2542 Rework Fformat to avoid integer overflow issues.
2543 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2544 now (part of C89). Include <verify.h>.
2545 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2546 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2547 (Fformat): Avoid the prepass trying to compute sizes; it was only
2548 approximate and thus did not catch overflow reliably. Instead, walk
2549 through the format just once, formatting and computing sizes as we go,
2550 checking for integer overflow at every step, and allocating a larger
2551 buffer as needed. Keep track separately whether the format is
2552 multibyte. Keep only the most-recently calculated precision, rather
2553 than them all. Record whether each argument has been converted to
2554 string. Use EMACS_INT, not int, for byte and char and arg counts.
2555 Support field widths and precisions larger than INT_MAX. Avoid
2556 sprintf's undefined behavior with conversion specifications such as %#d
2557 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2558 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2559 formatting out-of-range floating point numbers with int
9173deec 2560 formats. (Bug#8668)
37910ab2 2561
2e6578fb
PE
2562 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2563
0ae6bdee
PE
2564 * data.c: Avoid integer truncation in expressions involving floats.
2565 * data.c: Include <intprops.h>.
2566 (arith_driver): When there's an integer overflow in an expression
2567 involving floating point, convert the integers to floating point
2568 so that the resulting value does not suffer from catastrophic
2569 integer truncation. For example, on a 64-bit host (* 4
2570 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2571 Do not rely on undefined behavior after integer overflow.
2572
de883a70
PE
2573 merge count_size_as_multibyte, parse_str_to_multibyte
2574 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2575 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2576 Check for integer overflow.
2577 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2578 since it's now a duplicate of the other. This is more of
2579 a character than a buffer op, so better that it's in character.c.
2580 * fns.c, print.c: Adjust to above changes.
2581
2ff916cb
PE
25822011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2583
2584 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2585
f1b54466
PE
25862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2587
fb1ac845
PE
2588 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2589 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2590 (x_clipboard_manager_save): Now static.
2591 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2592
f1b54466
PE
2593 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2594 (crypto_hash_function): Now static.
2595 Fix pointer signedness problems. Avoid unnecessary initializations.
2596
a9f737ee
CY
25972011-05-27 Chong Yidong <cyd@stupidchicken.com>
2598
2599 * termhooks.h (Vselection_alist): Make it terminal-local.
2600
2601 * terminal.c (create_terminal): Initialize it.
2602
2603 * xselect.c: Support for clipboard managers.
2604 (Vselection_alist): Move to termhooks.h as terminal-local var.
2605 (LOCAL_SELECTION): New macro.
2606 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2607 (symbol_to_x_atom): Remove gratuitous arg.
2608 (x_handle_selection_request, lisp_data_to_selection_data)
2609 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2610 (x_own_selection, x_get_local_selection, x_convert_selection):
2611 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2612 (some_frame_on_display): Delete unused function.
2613 (Fx_own_selection_internal, Fx_get_selection_internal)
2614 (Fx_disown_selection_internal, Fx_selection_owner_p)
2615 (Fx_selection_exists_p): New optional frame arg.
2616 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2617 (x_handle_selection_clear): Don't treat other terminals with the
2618 same keyboard specially. Use the terminal-local Vselection_alist.
2619 (x_clear_frame_selections): Use Frun_hook_with_args.
2620
2621 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2622
2623 * xterm.h: Add support for those atoms.
2624
e067f0c1
CY
26252011-05-26 Chong Yidong <cyd@stupidchicken.com>
2626
2627 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2628 (converted_selections, conversion_fail_tag): New global variables.
2629 (x_selection_request_lisp_error): Free the above.
2630 (x_get_local_selection): Remove unnecessary code.
2631 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2632 of converted selections stored in converted_selections.
2633 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2634 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2635 (x_convert_selection): New function.
2636 (x_handle_selection_event): Simplify.
2637 (x_get_foreign_selection): Don't ignore incoming requests while
2638 waiting for an answer; this will fail when we implement
2639 SAVE_TARGETS, and seems unnecessary anyway.
2640 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2641 (Vx_sent_selection_functions): Doc fix.
2642
0f4aebc0
LL
26432011-05-26 Leo Liu <sdl.web@gmail.com>
2644
2645 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2646
e61124cd
YM
26472011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2648
2649 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2650
2651 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2652 for fringe update if it has periodic bitmap.
ac389d0c 2653 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2654 and fringe_bitmap_periodic_p.
2655
2656 * fringe.c (get_fringe_bitmap_data): New function.
2657 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2658 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2659 row. Mark glyph row for fringe update if periodicity changed.
2660
2661 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2662 for fringe update unless it has periodic bitmap.
2663
f16d9837
KH
26642011-05-25 Kenichi Handa <handa@m17n.org>
2665
2666 * xdisp.c (get_next_display_element): Set correct it->face_id for
2667 a static composition.
2668
e1b90ef6
LL
26692011-05-24 Leo Liu <sdl.web@gmail.com>
2670
2671 * deps.mk (fns.o):
2672 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2673
2674 * fns.c (crypto_hash_function, Fsha1): New function.
2675 (Fmd5): Use crypto_hash_function.
2676 (syms_of_fns): Add Ssha1.
2677
7400048f
PE
26782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * gnutls.c: Remove unused macros.
2681 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2682 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2683 Remove macros that are defined and never used.
2684 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2685
abb71cf4
CY
26862011-05-22 Chong Yidong <cyd@stupidchicken.com>
2687
2688 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2689 (Fx_get_selection_internal): Minor cleanup.
2690 (Fx_own_selection_internal): Rename arguments for consistency with
2691 select.el.
2692
6307db39
PE
26932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2696
f3d4e0a4
CY
26972011-05-22 Chong Yidong <cyd@stupidchicken.com>
2698
2699 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2700
4d8ade89
YM
27012011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2702
2703 * dispnew.c (scrolling_window): Don't exclude the case that the
2704 last enabled row in the desired matrix touches the bottom boundary.
2705
32078c8d
GM
27062011-05-21 Glenn Morris <rgm@gnu.org>
2707
2708 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2709 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2710 and add some more files.
32078c8d 2711
7285dc67
EZ
27122011-05-20 Eli Zaretskii <eliz@gnu.org>
2713
2714 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2715 report_file_error introduced by the change from 2011-05-07.
2716
89d1bd22
PE
27172011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2718
2719 * systime.h (Time): Define only if emacs is defined.
2720 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2721 where the include path doesn't have X11/X.h by default. See
2722 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2723
e23640bb 27242011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2725
2726 * composite.c (find_automatic_composition): Fix previous change.
2727
b9704ad9
GM
27282011-05-20 Glenn Morris <rgm@gnu.org>
2729
2730 * lisp.mk: New file, split from Makefile.in.
2731 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2732 (shortlisp): Remove.
2733 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2734
4a720484
GM
27352011-05-19 Glenn Morris <rgm@gnu.org>
2736
2737 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2738 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2739 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2740 (lisp): Set the order to that of loadup.el.
2741 (shortlisp): Make it a copy of $lisp.
2742 (SOME_MACHINE_LISP): Remove.
2743 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2744 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2745
a28d4396
KH
27462011-05-18 Kenichi Handa <handa@m17n.org>
2747
2748 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2749 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2750 (find_automatic_composition): Mostly rewrite for efficiency.
2751
a2b1fa8e
JB
27522011-05-18 Juanma Barranquero <lekktu@gmail.com>
2753
2754 * makefile.w32-in: Update dependencies.
2755
8e1f5610
CS
27562011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2757
2758 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2759 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2760
7025ee00 27612011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2762
cdfa6eab
PE
2763 Fix some integer overflow issues, such as string length overflow.
2764
06d6db33
PE
2765 * insdel.c (count_size_as_multibyte): Check for string overflow.
2766
2b4560a8
PE
2767 * character.c (lisp_string_width): Check for string overflow.
2768 Use EMACS_INT, not int, for string indexes and lengths; in
2769 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2770 the resulting string length overflows an EMACS_INT; instead,
2771 report a string overflow if no precision given. When checking for
2772 precision exhaustion, use a check that cannot possibly have
2773 integer overflow. (Bug#8675)
2774 * character.h (lisp_string_width): Adjust to new signature.
2775
cb93f9be
PE
2776 * alloc.c (string_overflow): New function.
2777 (Fmake_string): Use it. This doesn't change behavior, but saves
2778 a few bytes and will simplify future changes.
2779 * character.c (string_escape_byte8): Likewise.
2780 * lisp.h (string_overflow): New decl.
2781
1a1f3366
PE
2782 Fixups, following up to the user-interface timestamp change.
2783 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2784 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2785 * msdos.c (mouse_get_pos): Likewise.
2786 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2787 * w32gui.h (Time): Define by including "systime.h" rather than by
2788 declaring it ourselves. (Bug#8664)
2789
d4e3e4d3
PE
2790 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2791 * image.c (clear_image_cache): Likewise.
2792
f6a24d19
PE
2793 * term.c (term_mouse_position): Don't assume time_t wraparound.
2794
08dc5ae6
PE
2795 Be more systematic about user-interface timestamps.
2796 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2797 and sometimes 'EMACS_UINT', to represent these timestamps.
2798 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2799 This makes the code easier to follow, and makes it easier to catch
2800 integer overflow bugs such as Bug#8664.
2801 * frame.c (Fmouse_position, Fmouse_pixel_position):
2802 Use Time, not unsigned long, for user-interface timestamps.
2803 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2804 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2805 * keyboard.h (last_event_timestamp): Likewise.
2806 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2807 * menu.h (xmenu_show): Likewise.
2808 * term.c (term_mouse_position): Likewise.
2809 * termhooks.h (struct input_event.timestamp): Likewise.
2810 (struct terminal.mouse_position_hook): Likewise.
2811 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2812 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2813 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2814 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2815 what it was before.
2816 * menu.h, termhooks.h: Include "systime.h", for Time.
2817
8e55734a
PE
2818 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2819 Don't assume that the difference between two unsigned long values
2820 can fit into an integer. At this point, we know button_down_time
2821 <= event->timestamp, so the difference must be nonnegative, so
2822 there's no need to cast the result if double-click-time is
2823 nonnegative, as it should be; check that it's nonnegative, just in
2824 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2825 apart (about 25 days). (Bug#8664)
8e55734a 2826
841f1b75 2827 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2828 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2829
3e26f69c
PE
2830 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2831 that always fit in int. Use a sentinel instead of a counter, to
2832 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2833 * frame.h (struct frame): Use int for menu_bar_items_used
2834 instead of EMACS_INT, since it always fits in int.
3e26f69c 2835
5cc152c0
PE
2836 * menu.c (grow_menu_items): Check for int overflow.
2837
d89eb65e
PE
2838 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2839
5235bd3e
PE
2840 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2841 Before, the code was not consistent. These values cannot exceed
2842 2**31 - 1 so there's no need to make them unsigned.
2843 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2844 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2845 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2846 as modifiers.
2847 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2848
bc827e23
PE
2849 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2850 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2851 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2852 presumably because the widths might not match.
2853
78eb494e
PE
2854 * window.c (size_window): Avoid needless test at loop start.
2855
04f2d78b
CB
28562011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2857
2858 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2859
d2fc7e3d 28602011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2861
2862 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2863
d2fc7e3d 28642011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2865
2866 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2867 `width' to `bar_area_x' and `bar_area_width', respectively.
2868 (x_scroll_run): Take account of fringe background extension.
2869
04f2d78b
CB
2870 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2871 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2872 `bar_area_width', respectively.
2873 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2874 background extension.
2875
79b70037
GM
28762011-05-10 Jim Meyering <meyering@redhat.com>
2877
2878 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2879
2f142cc5
JB
28802011-05-10 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * image.c (Finit_image_library): Return t for built-in image types,
2883 like pbm and xbm. (Bug#8640)
2884
57679c86
AS
28852011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2886
2887 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2888
888c9e86
EZ
28892011-05-07 Eli Zaretskii <eliz@gnu.org>
2890
b0512a1d
EZ
2891 * w32console.c (Fset_screen_color): Doc fix.
2892 (Fget_screen_color): New function.
2893 (syms_of_ntterm): Defsubr it.
2894
7285dc67
EZ
2895 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2896 unlink the temporary file if Fcall_process didn't create it in the
2897 first place.
2898 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2899 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2900 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2901 cue to call_process_cleanup not to close that handle.
2902
4d3fcc8e
BK
29032011-05-07 Ben Key <bkey76@gmail.com>
2904
2905 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2906 one of two shell specific rules, either bootstrap-temacs-CMD or
2907 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2908 to the previous implementation of the bootstrap-temacs rule.
2909 The bootstrap-temacs-CMD rule is similar to the previous
2910 implementation of the bootstrap-temacs rule except that it
2911 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2912 variable.
2913
2914 These changes, along with some changes to nt/configure.bat,
2915 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2916 earlier fix to add support for --cflags and --ldflags options
2917 that include quotes so that it works whether make uses cmd or
2918 sh as the shell.
2919
b4289b64
MA
29202011-05-06 Michael Albinus <michael.albinus@gmx.de>
2921
2922 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2923 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2924 is a constant.
2925 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2926 a string. Handle both cases.
2927 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2928 (Fdbus_register_method): Use Qinvalid_function.
2929
af4c0e28
JB
29302011-05-06 Juanma Barranquero <lekktu@gmail.com>
2931
2932 * makefile.w32-in: Update dependencies.
2933 (LISP_H): Add inttypes.h and stdin.h.
2934 (PROCESS_H): Add unistd.h.
2935
c51453d9
EZ
29362011-05-06 Eli Zaretskii <eliz@gnu.org>
2937
2938 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2939 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2940
8ff0ac3c 29412011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2942
4c4b566b
PE
2943 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2944
aab2b9b5
PE
2945 * term.c (vfatal): Remove stray call to va_end.
2946 It's not needed and the C Standard doesn't allow it here anyway.
2947
c378da0b
PE
2948 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2949 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2950
288b08c7
PE
2951 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2952 bytes.
2953
e3601888
PE
2954 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2955
db6c0e74
PE
2956 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2957
dd5963ea
PE
2958 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2959
88c9450f
PE
2960 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2961
2f9442b8
PE
2962 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2963
c032b5f8
PE
2964 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2965 * charset.c (Fdefine_charset_internal): Don't initialize
2966 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2967 32-bit int (Bug#8600).
a108c10b
PE
2968
2969 * lread.c (read_integer): Be more consistent with string-to-number.
2970 Use string_to_number to do the actual conversion; this avoids
2971 rounding errors and fixes some other screwups. Without this fix,
2972 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2973 (digit_to_number): Move earlier, for benefit of read_integer.
2974 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2975 not a digit in any supported base. (Bug#8602)
a108c10b 2976
ad5f9eea
PE
2977 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2978
aec1708a
PE
2979 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2980 to match comment at start of function. This also removes a
2981 GCC warning about overflow in a 32+64-bit port.
2982
47be4ab5
PE
2983 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2984
371cac43
PE
2985 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2986 Reported by Stefan Monnier in
2987 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2988 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2989 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2990
d01a7826
PE
2991 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2992 (EMACS_UINTPTR): Likewise, with uintptr_t.
2993
7fd47d5c
PE
2994 * lisp.h: Prefer 64-bit EMACS_INT if available.
2995 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2996 on 32-bit hosts that have 64-bit int, so that they can access
2997 large files.
122b0c86
PE
2998 However, temporarily disable this change unless the temporary
2999 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3000
8727937b
PE
3001 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3002
8ac068ac
PE
3003 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3004 This removes an assumption that EMACS_INT and long are the same
3005 width as pointers. The assumption is true for Emacs porting targets
3006 now, but we want to make other targets possible.
3007 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3008 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3009 In the rest of the code, change types of integers that hold casted
3010 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3011 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3012 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3013 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3014 No need to cast type when ORing.
3015 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3016 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3017 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3018 assume EMACS_INT is the same width as char *.
3019 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3020 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3021 Remove no-longer-needed casts.
3022 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3023 (xg_tool_bar_help_callback, xg_make_tool_item):
3024 Use EMACS_INTPTR to hold an integer
3025 that will be cast to void *; this can avoid a GCC warning
3026 if EMACS_INT is not the same width as void *.
3027 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3028 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3029 (current_message_1, set_message_1):
3030 Use a local to convert to proper width without a cast.
3031 * xmenu.c (dialog_selection_callback): Likewise.
3032
ede49d71
PE
3033 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3034 Also, don't assume VALBITS / RAND_BITS is less than 5,
3035 and don't rely on undefined behavior when shifting a 1 left into
3036 the sign bit.
3037 * lisp.h (get_random): Change signature to match.
3038
2f30ecd0
PE
3039 * lread.c (hash_string): Use size_t, not int, for hash computation.
3040 Normally we prefer signed values; but hashing is special, because
3041 it's better to use unsigned division on hash table sizes so that
3042 the remainder is nonnegative. Also, size_t is the natural width
3043 for hashing into memory. The previous code used 'int', which doesn't
3044 retain enough info to hash well into very large tables.
3045 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3046
2a866e7b
PE
3047 * dbusbind.c: Don't possibly lose pointer info when converting.
3048 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3049 Use XPNTR rather than XHASH, so that the high-order bits of
3050 the pointer aren't lost when converting through void *.
3051
51639eac
PE
3052 * eval.c (Fautoload): Don't double-shift a pointer.
3053
92394119
PE
3054 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3055
dbdb9a7c
JB
30562011-05-06 Juanma Barranquero <lekktu@gmail.com>
3057
3058 * gnutls.c (DEF_GNUTLS_FN):
3059 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3060
db7a0b4f
AS
30612011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3062
3063 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3064 marker. (Bug#8610)
3065
f7ff1b0f 30662011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3067
3068 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3069 New version that can reserve upto 2GB of heap space.
3070
f7ff1b0f 30712011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3072
3073 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3074
639c109b
TZ
30752011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3076
3077 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3078 `gnutls_certificate_set_x509_key_file'.
3079
d2127135
JB
30802011-05-05 Juanma Barranquero <lekktu@gmail.com>
3081
3082 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3083 Update dependencies.
3084
e968f4f3
JB
30852011-05-04 Juanma Barranquero <lekktu@gmail.com>
3086
3087 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3088 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3089 Remove unused parameter `fildes'.
3090 * process.c (read_process_output, send_process): Don't pass it.
3091
84d358f0
JB
30922011-05-04 Juanma Barranquero <lekktu@gmail.com>
3093
3094 Fix previous change: the library cache is defined in w32.c.
3095 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3096 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3097
0898ca10
JB
30982011-05-04 Juanma Barranquero <lekktu@gmail.com>
3099
3100 Implement dynamic loading of GnuTLS on Windows.
3101
3102 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3103 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3104 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3105 Declare.
3106
3107 * gnutls.c (Qgnutls_dll): Define.
3108 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3109 (gnutls_*): Declare function pointers.
3110 (init_gnutls_functions): New function to initialize function pointers.
3111 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3112 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3113 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3114 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3115 (emacs_gnutls_write, emacs_gnutls_read)
3116 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3117 (Fgnutls_available_p): New function.
3118 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3119 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3120 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3121
3122 * image.c: Include w32.h.
3123 (Vimage_type_cache): Delete.
3124 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3125 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3126 (w32_delayed_load): Move to w32.c.
3127
3128 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3129
3130 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3131 (w32_delayed_load): Move from image.c. When loading a library, record
3132 its filename in the :loaded-from property of the library id.
3133 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3134 Initialize and staticpro them.
3135 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3136
3137 * process.c: Include lisp.h before w32.h, not after.
3138 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3139 instead of gnutls_record_check_pending.
3140
3141 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3142
ff4de4aa
TZ
31432011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3144
3145 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3146 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3147 as passed in.
3148
abe95abb
JD
31492011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3150
3151 * xterm.c (x_set_frame_alpha): Do not set property on anything
3152 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3153
e16e55d4
JB
31542011-05-02 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3157
bafcf6a5
JB
31582011-05-02 Juanma Barranquero <lekktu@gmail.com>
3159
3160 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3161 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3162 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3163 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3164 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3165 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3166 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3167 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3168 (Qgnutls_bootprop_callbacks_verify): Make static.
3169
e7a6747f
AS
31702011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3171
19ed11ba
AS
3172 * callproc.c: Indentation fixup.
3173
e7a6747f 3174 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3175 (wait_for_termination, interruptible_wait_for_termination):
3176 Move after wait_for_termination_1.
e7a6747f 3177
1ef14cb4
LMI
31782011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3179
3180 * sysdep.c (interruptible_wait_for_termination): New function
3181 which is like wait_for_termination, but allows keyboard
3182 interruptions.
3183
3184 * callproc.c (Fcall_process): Add (:file "file") as an option for
3185 the STDOUT buffer.
3186 (Fcall_process_region): Ditto.
3187
330d880c
EZ
31882011-04-30 Eli Zaretskii <eliz@gnu.org>
3189
8db90b73
EZ
3190 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3191 rather than `XVECTOR (FOO)->size'.
3192
330d880c
EZ
3193 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3194 inttypes.h, as a gnulib replacement is used if it not available in
3195 system headers.
3196
15cbd324
EZ
31972011-04-21 Eli Zaretskii <eliz@gnu.org>
3198
3199 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3200 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3201 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3202
3203 * coding.c (coding_alloc_by_realloc): Error out if destination
3204 will grow beyond MOST_POSITIVE_FIXNUM.
3205 (decode_coding_emacs_mule): Abort if there isn't enough place in
3206 charbuf for the composition carryover bytes. Reserve an extra
3207 space for up to 2 characters produced in a loop.
3208 (decode_coding_iso_2022): Abort if there isn't enough place in
3209 charbuf for the composition carryover bytes.
3210
32112011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3212
ae940cca
EZ
3213 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3214 aborting when %lld or %lll format is passed.
3215 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3216 %llo or %llx format is passed. (Bug#8545)
3217
03ab8921
EZ
3218 * window.c (window_scroll_line_based): Use a marker instead of
3219 simple variables to record original value of point. (Bug#7952)
3220
afda1437
EZ
3221 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3222 produced by %s or %c overflows available buffer space. (Bug#8545)
3223
f76dee0c
PE
32242011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3225
3226 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3227 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3228
fdc5744d
JB
32292011-04-28 Juanma Barranquero <lekktu@gmail.com>
3230
3231 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3232
638f053a
JB
32332011-04-28 Juanma Barranquero <lekktu@gmail.com>
3234
3235 * keyboard.c (Qdelayed_warnings_hook): Define.
3236 (command_loop_1): Run `delayed-warnings-hook'
3237 if Vdelayed_warnings_list is non-nil.
3238 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3239 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3240
d178f871
EZ
32412011-04-28 Eli Zaretskii <eliz@gnu.org>
3242
3243 * doprnt.c (doprnt): Don't return value smaller than the buffer
3244 size if the message was truncated. (Bug#8545).
3245
b124fd93
JB
32462011-04-28 Juanma Barranquero <lekktu@gmail.com>
3247
3248 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3249 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3250
e810457d
PE
32512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3254
ea51cceb
JB
32552011-04-27 Juanma Barranquero <lekktu@gmail.com>
3256
3257 * makefile.w32-in: Update dependencies.
3258
94dcfacf
EZ
32592011-04-27 Eli Zaretskii <eliz@gnu.org>
3260
3261 Improve `doprnt' and its usage. (Bug#8545)
3262 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3263 `format_end'. Remove support for %l as a conversion specifier.
3264 Don't use xrealloc. Improve diagnostics when the %l size modifier
3265 is used. Update the commentary.
3266
3267 * eval.c (verror): Simplify calculation of size_t.
3268
3269 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3270 messages.
3271
f61f41d7
PE
32722011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3273
3274 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3275 change.
3276
96fb4434
PE
32772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3280 This makes this file independent of the recent pseudovector change.
3281
671875da 32822011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3283
69e9b5a3
PE
3284 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3285
b5f869a7 3286 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3287 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3288 Remove unused local.
c8926152 3289 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3290
841a1577 3291 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3292 GCC 4.6.0 optimizes based on type-based alias analysis.
3293 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3294 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3295 != &v->size, and therefore "v->size = 1; b->size = 2; return
3296 v->size;" must therefore return 1. This assumption is incorrect
3297 for Emacs, since it type-puns struct Lisp_Vector * with many other
3298 types. To fix this problem, this patch adds a new type struct
f904488f 3299 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3300 and pseudovectors, and helps optimizing compilers not get fooled
3301 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3302 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3303 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3304 the size member.
eab3844f
PE
3305 (XSETPVECTYPE): Rewrite in terms of new macro.
3306 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3307 This is a bit clearer, and further avoids the possibility of
3308 undesirable aliasing.
3309 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3310 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3311 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3312 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3313 (ASIZE): Now uses header.size rather than size.
3314 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3315 to avoid the hassle of writing XVECTOR (foo)->header.size.
3316 (struct vectorlike_header): New type.
eab3844f
PE
3317 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3318 object, to help avoid aliasing.
3319 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3320 (SUBRP): Likewise, since Lisp_Subr is a special case.
3321 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3322 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3323 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3324 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3325 changed to be "header.size" and "header.next".
3326 * buffer.h (struct buffer): Likewise.
3327 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3328 * frame.h (struct frame): Likewise.
3329 * process.h (struct Lisp_Process): Likewise.
3330 * termhooks.h (struct terminal): Likewise.
3331 * window.c (struct save_window_data, struct saved_window): Likewise.
3332 * window.h (struct window): Likewise.
3333 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3334 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3335 * buffer.c (init_buffer_once): Likewise.
3336 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3337 special case.
3338 * process.c (Fformat_network_address): Use local var for size,
3339 for brevity.
3340
0df1eac5
PE
3341 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3342
847ab9d1 3343 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3344 * data.c (atof): Remove decl; no longer used or needed.
3345 (digit_to_number): Move to lread.c.
3346 (Fstring_to_number): Use new string_to_number function, to be
3347 consistent with how the Lisp reader treats infinities and NaNs.
3348 Do not assume that floating-point numbers represent EMACS_INT
3349 without losing information; this is not true on most 64-bit hosts.
3350 Avoid double-rounding errors, by insisting on integers when
3351 parsing non-base-10 numbers, as the documentation specifies.
3352 * lisp.h (string_to_number): New decl, replacing ...
3353 (isfloat_string): Remove.
bc0a5c13 3354 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3355 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3356 appears to have been a coding error. Similarly, do not accept
3357 strings like +-1e0 as floating point numbers. Do not report
3358 overflow for integer overflows unless the base is not 10 which
3359 means we have no simple and reliable way to continue.
3360 Break out the floating-point parsing into a new
3361 function string_to_number, so that Fstring_to_number parses
3362 floating point numbers consistently with the Lisp reader.
04f2d78b 3363 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3364 (E_CHAR, EXP_INT): Remove, replacing with ...
3365 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3366 (string_to_number): New function, replacing isfloat_string.
3367 This function checks for valid syntax and produces the resulting
3368 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3369 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3370 so that overflow for non-base-10 numbers is reported only when
3371 there's no portable and simple way to convert to floating point.
452f4150 3372
67769ffc
PE
3373 * textprop.c (set_text_properties_1): Rewrite for clarity,
3374 and to avoid GCC warning about integer overflow.
3375
c20db43f
PE
3376 * intervals.h (struct interval): Use EMACS_INT for members
3377 where EMACS_UINT might cause problems. See
3378 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3379 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3380 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3381 All uses changed.
37aa2f85
PE
3382 (offset_intervals): Tell GCC not to worry about length overflow
3383 when negating a negative length.
c20db43f 3384
2538aa2f
PE
3385 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3386 (overrun_check_free): Likewise.
3387
f2d3008d
PE
3388 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3389 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3390 word size.
3391
ec8df744
PE
3392 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3393 (gnutls_make_error): Rename local to avoid shadowing.
3394 (gnutls_emacs_global_deinit): ifdef out; not used.
3395 (Fgnutls_boot): Use const for pointer to readonly storage.
3396 Comment out unused local. Fix pointer signedness problems.
3397
640ee02d
PE
3398 * lread.c (openp): Don't stuff size_t into an 'int'.
3399 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3400 about possible signed overflow.
3401
6048fb2a
PE
3402 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3403 (GDK_KEY_g): Don't define if already defined.
3404 (xg_prepare_tooltip): Avoid pointer signedness problem.
3405 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3406
fa3c87e1
PE
3407 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3408 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3409
2172544b
PE
3410 * xfns.c (Fx_window_property): Simplify a bit,
3411 to make a bit faster and to avoid GCC 4.6.0 warning.
3412 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3413
9b821a21
PE
3414 * fns.c (internal_equal): Don't assume size_t fits in int.
3415
3c616cfa
PE
3416 * alloc.c (compact_small_strings): Tighten assertion a little.
3417
c2982e87
PE
3418 Replace pEd with more-general pI, and fix some printf arg casts.
3419 * lisp.h (pI): New macro, generalizing old pEd macro to other
3420 conversion specifiers. For example, use "...%"pI"d..." rather
3421 than "...%"pEd"...".
3422 (pEd): Remove. All uses replaced with similar uses of pI.
3423 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3424 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3425 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3426 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3427 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3428 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3429 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3430 64-bit hosts.
3431 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3432 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3433 * print.c (safe_debug_print, print_object): Likewise.
3434 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3435 to int.
6f04d126
PE
3436 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3437 avoiding the 0 flag, which is not portable.
c2982e87
PE
3438 * process.c (Fmake_network_process): Use pI to avoid cast.
3439 * region-cache.c (pp_cache): Likewise.
3440 * xdisp.c (decode_mode_spec): Likewise.
3441 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3442 behavior on 64-bit hosts with printf arg.
6f04d126 3443 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3444 (x_stop_queuing_selection_requests): Likewise.
3445 (x_get_window_property): Don't truncate byte count to an 'int'
3446 when tracing.
0b432f21 3447
5e073ec7
PE
3448 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3449 here, since it parses constructs like leading '-' and spaces,
3450 which are not wanted; and it overflows with large numbers.
3451 Instead, simply match F[0-9]+, which is what is wanted anyway.
3452
36372bf9
PE
3453 * alloc.c: Remove unportable assumptions about struct layout.
3454 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3455 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3456 (allocate_vectorlike, make_pure_vector): Use the new macros,
3457 plus offsetof, to remove unportable assumptions about struct layout.
3458 These assumptions hold on all porting targets that I know of, but
3459 they are not guaranteed, they're easy to remove, and removing them
3460 makes further changes easier.
3461
0b432f21
PE
3462 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3463 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3464 (string_overrun_cookie): Now const. Use initializers that
3465 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3466 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3467 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3468 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3469 multiple of sizeof (EMACS_INT); it need not be, if
3470 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3471 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3472
895009e1
JB
34732011-04-26 Juanma Barranquero <lekktu@gmail.com>
3474
3475 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3476
6a7a1b0b
TZ
34772011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3478
3479 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3480 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3481 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3482
841a1577 34832011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3484
3485 * lisp.h (Qdebug): List symbol.
895009e1 3486 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3487 * keyboard.c (debug-on-event): New variable.
3488 (handle_user_signal): Break into debugger when debug-on-event
3489 matches the current signal symbol.
3490
f2d3ba6f
DN
34912011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3492
3493 * alloc.c (check_sblock, check_string_bytes)
3494 (check_string_free_list): Convert to standard C.
3495
42ce4c63
TZ
34962011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3497
3498 * w32.c (emacs_gnutls_push): Fix typo.
3499
825cd63c
EZ
35002011-04-25 Eli Zaretskii <eliz@gnu.org>
3501
fb11d64d
EZ
3502 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3503 "cast to pointer from integer of different size".
3504
825cd63c
EZ
3505 Improve doprnt and its use in verror. (Bug#8545)
3506 * doprnt.c (doprnt): Document the set of format control sequences
3507 supported by the function. Use SAFE_ALLOCA instead of always
3508 using `alloca'.
3509
3510 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3511 is one byte too soon. Don't use xrealloc; instead xfree and
3512 xmalloc anew.
3513
e061a11b
TZ
35142011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3515
3516 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3517 callbacks stage.
3518
3519 * gnutls.c: Renamed global_initialized to
3520 gnutls_global_initialized. Added internals for the
3521 :verify-hostname-error, :verify-error, and :verify-flags
3522 parameters of `gnutls-boot' and documented those parameters in the
3523 docstring. Start callback support.
9173deec
JB
3524 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3525 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3526 on error. Return error code.
e061a11b
TZ
3527 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3528 (emacs_gnutls_read): Likewise.
3529 (Fgnutls_boot): Return handshake error code.
3530 (emacs_gnutls_handle_error): New function.
3531 (wsaerror_to_errno): Likewise.
3532
3533 * w32.h (emacs_gnutls_pull): Add prototype.
3534 (emacs_gnutls_push): Likewise.
3535
3536 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3537 (emacs_gnutls_push): Likewise.
3538
35392011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3540
3541 * process.c (wait_reading_process_output): Check if GnuTLS
3542 buffered some data internally if no FDs are set for TLS
3543 connections.
3544
3545 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3546 (LIBS): Link to USER_LIBS.
3547 ($(BLD)/gnutls.$(0)): New target.
3548
fa6996bc
EZ
35492011-04-24 Eli Zaretskii <eliz@gnu.org>
3550
eb35682e
EZ
3551 * xdisp.c (handle_single_display_spec): Rename the
3552 display_replaced_before_p argument into display_replaced_p, to
3553 make it consistent with the commentary. Fix typos in the
3554 commentary.
3555
e2ad650c
EZ
3556 * textprop.c (syms_of_textprop): Remove dead code.
3557 (copy_text_properties): Delete obsolete commentary about an
3558 interface that was deleted long ago. Fix typos in the description
3559 of arguments.
3560
1b2de274
EZ
3561 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3562 to changes in oldXMenu/XMenu.h from 2011-04-16.
3563 <menu_help_message, prev_menu_help_message>: Constify.
3564 (IT_menu_make_room): menu->help_text is now `const char **';
3565 adjust.
3566
3567 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3568 to changes in oldXMenu/XMenu.h from 2011-04-16.
3569 (struct XMenu): Declare `help_text' `const char **'.
3570
3571 * xfaces.c <Qunspecified>: Make extern again.
3572
3573 * syntax.c: Include sys/types.h before including regex.h, as
3574 required by Posix.
3575
762b15be
EZ
3576 * doc.c (get_doc_string): Improve the format passed to `error'.
3577
3578 * doprnt.c (doprnt): Improve commentary.
3579
3580 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3581
3582 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3583 them with etags.
3584
f1052e5d
EZ
3585 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3586 changes in globals.h immediately force recompilation.
762b15be
EZ
3587 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3588 $(CURDIR)/s/ms-w32.h.
3589 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3590
fa6996bc
EZ
3591 * character.c (Fchar_direction): Function deleted.
3592 (syms_of_character): Don't defsubr it.
3593 <char-direction-table>: Deleted.
3594
e6c3da20
EZ
35952011-04-23 Eli Zaretskii <eliz@gnu.org>
3596
3597 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3598 * doprnt.c: Include limits.h.
3599 (SIZE_MAX): New macro.
04f2d78b
CB
3600 (doprnt): Return a size_t value. 2nd arg is now size_t.
3601 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3602 Improve overflow protection. Support `l' modifier for integer
3603 conversions. Support %l conversion. Don't assume an EMACS_INT
3604 argument for integer conversions and for %c.
3605
3606 * lisp.h (doprnt): Restore prototype.
3607
3608 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3609 $(SRC)/character.h.
3610
3611 * Makefile.in (base_obj): Add back doprnt.o.
3612
3613 * deps.mk (doprnt.o): Add back prerequisites.
3614 (callint.o): Depend on character.h.
3615
3616 * eval.c (internal_lisp_condition_case): Include the handler
3617 representation in the error message.
3618 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3619 when breaking from the loop.
3620
3621 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3622
3623 * callint.c (Fcall_interactively): When displaying error message
3624 about invalid control letter, pass the character's codepoint, not
3625 a pointer to its multibyte form. Improve display of the character
3626 in octal and display also its hex code.
3627
3628 * character.c (char_string): Use %x to display the (unsigned)
3629 codepoint of an invalid character, to avoid displaying a bogus
3630 negative value.
3631
3632 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3633 `error', not SYMBOL_NAME itself.
3634
3635 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3636 character arguments to `error'.
3637
3638 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3639 to `error' in error message about FINAL_CHAR argument. Make sure
3640 FINAL_CHAR is a character, and use %c when it is passed as
3641 argument to `error'.
3642
4ffd0d6b 36432011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3644
3645 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3646
3647 * w32.c: Include <time.h>.
3648 (sys_localtime): New function.
3649
4ffd0d6b 36502011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3651
3652 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3653
4ffd0d6b 3654 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3655
4ffd0d6b 36562011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3657
4ffd0d6b
GM
3658 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3659 zombies (Bug#8467).
aac0c6e3 3660
04c56954
EZ
36612011-04-19 Eli Zaretskii <eliz@gnu.org>
3662
3663 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3664 gl_state.e_property when gl_state.object is Qt.
3665
3666 * insdel.c (make_gap_larger): Remove limitation of buffer size
3667 to <= INT_MAX.
3668
16a43933
CY
36692011-04-18 Chong Yidong <cyd@stupidchicken.com>
3670
3671 * xdisp.c (lookup_glyphless_char_display)
3672 (produce_glyphless_glyph): Handle cons cell entry in
3673 glyphless-char-display.
3674 (Vglyphless_char_display): Document it.
3675
3676 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3677 glyphless-char-display.
3678
4581706e
CY
36792011-04-17 Chong Yidong <cyd@stupidchicken.com>
3680
3681 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3682
3683 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3684
3685 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3686 definition for no-X builds.
3687
4887c6e2 36882011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3689
fd35b6f9
PE
3690 Static checks with GCC 4.6.0 and non-default toolkits.
3691
5c1ccb01
PE
3692 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3693
006c5daa
PE
3694 * process.c (keyboard_bit_set): Define only if SIGIO.
3695 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3696 (send_process): Repair possible setjmp clobbering.
3697
efc736d3
PE
3698 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3699
4e2fe2e6
PE
3700 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3701
f97334a2
PE
3702 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3703
4e75f29d
PE
3704 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3705 Define only if needed.
3706
90efadd1
PE
3707 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3708 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3709 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3710
3c647824
PE
3711 * dispextern.h (struct redisplay_interface): Rename param
3712 to avoid shadowing.
e264f262 3713 * termhooks.h (struct terminal): Likewise.
761383f4 3714 * xterm.c (xembed_send_message): Likewise.
3c647824 3715
b58c5c4a
PE
3716 * insdel.c (make_gap_smaller): Define only if
3717 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3718
cad59032
PE
3719 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3720 it.
3721
c339dc2e
PE
3722 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3723 so that we aren't warned about unused symbols.
3724
91a3e27b
PE
3725 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3726
399c71d3 3727 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3728
8ffc96f5
PE
3729 * xfns.c (x_real_positions): Mark locals as initialized.
3730
eef9bc79
PE
3731 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3732
098db9dd
PE
3733 * xterm.c: Fix problems found by static analysis with other toolkits.
3734 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3735 (x_dispatch_event): Declare static if USE_GTK, and
3736 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3737 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3738 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3739 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3740 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3741
eb18f6cc
PE
3742 * xmenu.c (menu_help_callback): Pointer type fixes.
3743 Use const pointers when pointing at readonly data. Avoid pointer
3744 signedness clashes.
3745 (FALSE): Remove unused macro.
3746 (update_frame_menubar): Remove unused decl.
3747
1fe72bf8
PE
3748 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3749
60d9e1db
PE
3750 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3751 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3752 (single_menu_item): Rename local to avoid shadowing.
3753
39261c26
PE
3754 * keyboard.c (make_lispy_event): Remove unused local var.
3755
018c5e19
PE
3756 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3757 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3758
63d2b86e
PE
3759 * bitmaps: Change bitmaps from unsigned char back to the X11
3760 compatible char. Avoid the old compiler warnings about
3761 out-of-range initializers by using, for example, '\xab' rather
3762 than 0xab.
3763
aefd87e1
PE
3764 * xgselect.c (xgselect_initialize): Check vs interface
3765 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3766
bf501fb9
PE
3767 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3768
e9829fdf
PE
3769 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3770 to read-only memory.
3771
1086c095
PE
3772 * fns.c (vector): Remove; this old hack is no longer needed.
3773
2baccd04 3774 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3775 Remove unused var.
dde42981 3776 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3777
72391843 3778 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3779
436c16df 3780 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3781 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3782 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3783
92bb796d 3784 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3785 (x_term_init): Remove local to avoid shadowing.
92bb796d 3786
764430a3 3787 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3788
3789 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3790 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3791
d1dfb56c
EZ
37922011-04-16 Eli Zaretskii <eliz@gnu.org>
3793
c4354cb4
EZ
3794 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3795
d1dfb56c
EZ
3796 Fix regex.c, syntax.c and friends for buffers > 2GB.
3797 * syntax.h (struct gl_state_s): Declare character position members
3798 EMACS_INT.
3799
3800 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3801
04f2d78b
CB
3802 * textprop.c (verify_interval_modification, interval_of):
3803 Declare arguments EMACS_INT.
d1dfb56c
EZ
3804
3805 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3806 EMACS_INT.
3807
3808 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3809
3810 * indent.c (Fvertical_motion): Local variable it_start is now
3811 EMACS_INT.
3812
3813 * regex.c (re_match, re_match_2, re_match_2_internal)
3814 (bcmp_translate, regcomp, regexec, print_double_string)
3815 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3816 (re_compile_pattern, re_exec): Declare arguments and local
3817 variables `size_t' and `ssize_t' and return values `regoff_t', as
3818 appropriate.
3819 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3820 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3821 <compile_stack_type>: `size' and `avail' are now `size_t'.
3822
3823 * regex.h <regoff_t>: Use ssize_t, not int.
3824 (re_search, re_search_2, re_match, re_match_2): Arguments that
3825 specify buffer/string position and length are now ssize_t and
3826 size_t. Return type is regoff_t.
3827
613052cd
BK
38282011-04-16 Ben Key <bkey76@gmail.com>
3829
3830 * nsfont.m: Fixed bugs in ns_get_family and
3831 ns_descriptor_to_entity that were caused by using free to
3832 deallocate memory blocks that were allocated by xmalloc (via
3833 xstrdup). This caused Emacs to crash when compiled with
3834 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3835 --enable-checking=xmallocoverrun). xfree is now used to
3836 deallocate these memory blocks.
3837
4170f62f 38382011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3839
71b41406
PE
3840 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3841
9587a89d
PE
3842 emacs_write: Accept and return EMACS_INT for sizes.
3843 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3844 et seq.
3845 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3846 Accept and return EMACS_INT.
3847 (emacs_gnutls_write): Return the number of bytes written on
3848 partial writes.
3849 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3850 (emacs_read, emacs_write): Remove check for negative size, as the
3851 Emacs source code has been audited now.
9587a89d
PE
3852 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3853 (emacs_read, emacs_write): Use it.
273a5f82
PE
3854 * process.c (send_process): Adjust to the new signatures of
3855 emacs_write and emacs_gnutls_write. Do not attempt to store
3856 a byte offset into an 'int'; it might overflow.
9587a89d 3857 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3858
3e047f51
PE
3859 * sound.c: Don't assume sizes fit in 'int'.
3860 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3861 Return EMACS_INT, not int.
3e047f51 3862 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3863 Accept EMACS_INT, not int.
3864 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3865 record read return values.
3866
cc39a9db
BK
38672011-04-15 Ben Key <bkey76@gmail.com>
3868
c9d0ec6d
JB
3869 * keyboard.c (Qundefined): Don't declare static since it is used
3870 in nsfns.m.
3871 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3872 static since they are used in nsfont.m.
cc39a9db 3873
6c60eb9f
SM
38742011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3875
3876 * process.c (Qprocessp): Don't declare static.
3877 * lisp.h (Qprocessp): Declare again.
3878
7990b61a
JB
38792011-04-15 Juanma Barranquero <lekktu@gmail.com>
3880
3881 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3882
5d4cb038
PE
38832011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3884
8bd7b830 3885 Improve C-level modularity by making more things 'static'.
cd64ea1d 3886
e3b27b31
PE
3887 Don't publish debugger-only interfaces to other modules.
3888 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3889 (verify_bytepos, count_markers): Move decls to the only modules
3890 that need them.
3891 * region-cache.h (pp_cache): Likewise.
3892 * window.h (check_all_windows): Likewise.
3893 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3894
5d4cb038
PE
3895 * sysdep.c (croak): Now static, if
3896 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3897 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3898
3899 * alloc.c (refill_memory_reserve): Now static if
3900 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3901 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3902
e87b6180
PE
3903 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3904 Define only if USE_LUCID.
3905
ac64929e
PE
3906 * xrdb.c (x_customization_string, x_rm_string): Now static.
3907
6f37259d
PE
3908 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3909 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3910
1683e3ab
PE
3911 * xdisp.c (draw_row_with_mouse_face): Now static.
3912 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3913
de9c2632
PE
3914 * window.h (check_all_windows): Mark externally visible.
3915
2b96acb7
PE
3916 * window.c (window_deletion_count): Now static.
3917
3918 * undo.c: Make symbols static if they're not exported.
3919 (last_undo_buffer, last_boundary_position, pending_boundary):
3920 Now static.
3921
50436f33
PE
3922 * textprop.c (interval_insert_behind_hooks): Now static.
3923 (interval_insert_in_front_hooks): Likewise.
3924
64520e5c
PE
3925 * term.c: Make symbols static if they're not exported.
3926 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3927 (max_frame_lines, tty_set_terminal_modes):
3928 (tty_reset_terminal_modes, tty_turn_off_highlight):
3929 (get_tty_terminal): Now static.
3930 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3931 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3932 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3933 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3934 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3935
1fa53021
PE
3936 * sysdep.c: Make symbols static if they're not exported.
3937 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3938 Now static.
3939 (sigprocmask_set, full_mask): Remove; unused.
3940 (wait_debugging): Mark as visible.
3941 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3942 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3943
d4b43b22
PE
3944 * syntax.c (syntax_temp): Define only if !__GNUC__.
3945
b7c513d0
PE
3946 * sound.c (current_sound_device, current_sound): Now static.
3947
989b29ad
PE
3948 * search.c (searchbufs, searchbuf_head): Now static.
3949
13a55a78
PE
3950 * scroll.c (scroll_cost): Remove; unused.
3951 * dispextern.h (scroll_cost): Remove decl.
3952
de68a1fc
PE
3953 * region-cache.h (pp_cache): Mark as externally visible.
3954
40ccffa6
PE
3955 * process.c: Make symbols static if they're not exported.
3956 (process_tick, update_tick, create_process, chan_process):
3957 (Vprocess_alist, proc_buffered_char, datagram_access):
3958 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3959 (deactivate_process): Mark defn as static, as well as decl.
3960 * lisp.h (create_process): Remove decl.
3961 * process.h (chan_process, Vprocess_alist): Remove decls.
3962
ad64fc97
PE
3963 * print.c: Make symbols static if they're not exported.
3964 (print_depth, new_backquote_output, being_printed, print_buffer):
3965 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3966 (print_interval, print_number_index, initial_stderr_stream):
3967 Now static.
3968 * lisp.h (Fprinc): Remove decl.
3969 (debug_output_compilation_hack): Mark as externally visible.
3970
adddb265
PE
3971 * sysdep.c (croak): Move decl from here to syssignal.h.
3972 * syssignal.h (croak): Put it here, so the API can be checked when
3973 'croak' is called from dissociate_if_controlling_tty.
3974
1717ede2
PE
3975 * minibuf.c: Make symbols static if they're not exported.
3976 (minibuf_save_list, choose_minibuf_frame): Now static.
3977 * lisp.h (choose_minibuf_frame): Remove decl.
3978
fa5fb2bc
PE
3979 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3980
1e3890d1
PE
3981 * lread.c: Make symbols static if they're not exported.
3982 (read_objects, initial_obarray, oblookup_last_bucket_number):
3983 Now static.
3984 (make_symbol): Remove; unused.
3985 * lisp.h (initial_obarray, make_symbol): Remove decls.
3986
8a1414fa
PE
3987 * keyboard.c: Make symbols static if they're not exported.
3988 (single_kboard, recent_keys_index, total_keys, recent_keys):
3989 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3990 (this_single_command_key_start, echoing, last_auto_save):
3991 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3992 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3993 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3994 (Vlispy_mouse_stem, double_click_count):
3995 Now static.
3996 (force_auto_save_soon): Define only if SIGDANGER.
3997 (ignore_mouse_drag_p): Now static if
3998 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3999 (print_help): Remove; unused.
4000 (stop_character, last_timer_event): Mark as externally visible.
4001 * keyboard.h (ignore_mouse_drag_p): Declare only if
4002 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4003 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4004 * lisp.h (echoing): Remove decl.
4005 (force_auto_save_soon): Declare only if SIGDANGER.
4006 * xdisp.c (redisplay_window): Simplify code, to make it more
4007 obvious that ignore_mouse_drag_p is not accessed if !defined
4008 USE_GTK && !defined HAVE_NS.
4009
93ea6e8f
PE
4010 * intervals.c: Make symbols static if they're not exported.
4011 (merge_properties_sticky, merge_interval_right, delete_interval):
4012 Now static.
4013 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4014
77382fcc
PE
4015 * insdel.c: Make symbols static if they're not exported.
4016 However, leave prepare_to_modify_buffer alone. It's never
4017 called from outside this function, but that appears to be a bug.
4018 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4019 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4020 (adjust_after_replace_noundo): Remove; unused.
4021 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4022 (signal_before_change): Remove decls.
77382fcc 4023
9306c32e
PE
4024 * indent.c (val_compute_motion, val_vmotion): Now static.
4025
cd44d2eb
PE
4026 * image.c: Make symbols static if they're not exported.
4027 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4028 if USE_GTK.
4029 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4030 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4031
ad9a7a06
PE
4032 * fringe.c (standard_bitmaps): Now static.
4033 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4034
81626931
PE
4035 * frame.c: Make symbols static if they're not exported.
4036 (x_report_frame_params, make_terminal_frame): Now static.
4037 (get_frame_param): Now static, unless HAVE_NS.
4038 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4039 (x_get_resource_string): Remove; not used.
4040 * frame.h (make_terminal_frame, x_report_frame_params):
4041 (x_get_resource_string); Remove decls.
4042 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4043 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4044
239f9db9
PE
4045 * font.c, fontset.c: Make symbols static if they're not exported.
4046 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4047 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4048 * font.c (font_close_object): Now static.
4049 * font.h (font_close_object): Remove.
4050 * fontset.c (FONTSET_OBJLIST): Remove.
4051 (free_realized_fontset) #if-0 the body, which does nothing.
4052 (face_suitable_for_char_p): #if-0, as it's never called.
4053 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4054 * xfaces.c (face_at_string_position):
4055 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4056 since 0 is always ASCII.
4057
dfcf3579
PE
4058 * fns.c (weak_hash_tables): Now static.
4059
5045092b
PE
4060 * fileio.c: Make symbols static if they're not exported.
4061 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4062 (Vwrite_region_annotation_buffers): Now static.
4063
57a96f5c
PE
4064 * eval.c: Make symbols static if they're not exported.
4065 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4066 * lisp.h (backtrace_list): Remove decl.
4067
35f08c38
PE
4068 * emacs.c: Make symbols static if they're not exported.
4069 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4070 (fatal_error_code, fatal_error_signal_hook, standard_args):
4071 Now static.
4072 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4073 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4074 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4075 * lisp.h (fatal_error_signal_hook): Remove decl.
4076 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4077
f44bd759
PE
4078 * editfns.c: Move a (normally-unused) function to its only use.
4079 * editfns.c, lisp.h (get_operating_system_release): Remove.
4080 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4081 worth the hassle of breaking this out.
4082
b532497d
PE
4083 * xterm.c: Make symbols static if they're not exported.
4084 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4085 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4086 (x_destroy_window, x_delete_display):
4087 Now static.
4088 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4089 (x_mouse_leave): Remove; unused.
4090 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4091 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4092 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4093 Remove decls.
4094 (x_mouse_leave): Declare only if WINDOWSNT.
4095 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4096 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4097 USE_X_TOOLKIT.
4098
1675728f
PE
4099 * ftxfont.c: Make symbols static if they're not exported.
4100 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4101 HAVE_FREETYPE.
4102 * font.h (ftxfont_driver): Likewise.
4103
e4cebfca
PE
4104 * xfns.c: Make symbols static if they're not exported.
4105 (x_last_font_name, x_display_info_for_name):
4106 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4107 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4108 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4109 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4110 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4111 (last_show_tip_args): Now static.
4112 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4113 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4114 (x_screen_planes): Remove; unused.
4115 * dispextern.h (x_screen_planes): Remove decl.
4116
5bf46f05
PE
4117 * dispnew.c: Make symbols static if they're not exported.
4118 * dispextern.h (redraw_garbaged_frames, scrolling):
4119 (increment_row_positions): Remove.
4120 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4121 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4122 Now static.
4123 (redraw_garbaged_frames): Remove; unused.
4124
435f4c28
PE
4125 * xfaces.c: Make symbols static if they're not exported.
4126 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4127 Remove decls.
4128 * xterm.h (defined_color): Remove decls.
4129 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4130 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4131 (menu_face_changed_default, defined_color, free_realized_face):
4132 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4133 (ascii_face_of_lisp_face): Remove; unused.
4134
8524aef3
PE
4135 * xdisp.c: Make symbols static if they're not exported.
4136 * dispextern.h (scratch_glyph_row, window_box_edges):
4137 (glyph_to_pixel_coords, set_cursor_from_row):
4138 (get_next_display_element, set_iterator_to_next):
4139 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4140 (show_mouse_face): Remove decls
4141 * frame.h (message_buf_print): Likewise.
4142 * lisp.h (pop_message, set_message, check_point_in_composition):
4143 Likewise.
4144 * xterm.h (set_vertical_scroll_bar): Likewise.
4145 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4146 (message_buf_print, scratch_glyph_row, displayed_buffer):
4147 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4148 (get_next_display_element, show_mouse_face, window_box_edges):
4149 (frame_to_window_pixel_xy, check_point_in_composition):
4150 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4151 (glyph_to_pixel_coords): Remove; unused.
4152
16390cd2
PE
4153 * dired.c (file_name_completion): Now static.
4154
4155 * dbusbind.c (xd_in_read_queued_messages): Now static.
4156
a25f4dfa
PE
4157 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4158 * data.c (circular_list_error): Remove.
4159
14a9c8df
PE
4160 * commands.h (last_point_position, last_point_position_buffer):
4161 (last_point_position_window): Remove decls.
4162 * keyboard.c: Make these variables static.
4163
04f2d78b
CB
4164 * coding.h (coding, code_convert_region, encode_coding_gap):
4165 Remove decls.
74ab6df5
PE
4166 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4167 (iso_code_class, detect_coding, code_convert_region): Now static.
4168 (encode_coding_gap): Remove; unused.
4169
38dfbee1
PE
4170 * chartab.c (chartab_chars, chartab_bits): Now static.
4171
a2cb4e63
PE
4172 * charset.h (charset_iso_8859_1): Remove decl.
4173 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4174 Now static.
4175
127198fd
PE
4176 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4177 * ccl.c (Vccl_program_table): Now static.
4178 (check_ccl_update): Remove; unused.
4179
d85b608f
PE
4180 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4181 * category.h: ... from here.
4182 * category.c (check_category_table, set_category_set): Now static.
4183
31cd66f3
PE
4184 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4185 * lisp.h: Remove these decls.
4186
c358e587
PE
4187 * buffer.c (buffer_count): Remove unused var.
4188
e78aecca
PE
4189 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4190 so that it's not optimized away.
4191 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4192 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4193 exported only to the debugger.
4194
e192d7d3 4195 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4196 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4197
92470028
PE
4198 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4199 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4200 was inaccessible from Lisp.
4201 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4202 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4203
244ed907
PE
4204 alloc.c: Import and export fewer symbols, and remove unused items.
4205 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4206 is defined.
4207 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4208 it's not optimized away by whole-program optimization.
4209 (message_enable_multibyte, free_misc): Remove.
4210 (catchlist, handlerlist, mark_backtrace):
4211 Declare only if BYTE_MARK_STACK.
4212 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4213 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4214 (message_enable_multibyte): Remove decl.
4215 (free_misc, interval_free_list, float_block, float_block_index):
4216 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4217 (cons_free_list, last_marked_index):
4218 Now static.
4219 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4220 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4221 (mark_backtrace): Define only if BYTE_MARK_STACK.
4222 * xdisp.c (message_enable_multibyte): Now static.
4223
61c2b50e 4224 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4225 This makes it easier for human readers (and static analyzers)
4226 to see whether these variables are used from other modules.
4227 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4228 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4229 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4230 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4231 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4232 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4233 * xmenu.c, xselect.c:
4234 Declare Q* vars static if they are not used in other modules.
4235 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4236 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4237 Remove decls of unexported vars.
4238 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4239
95c82688
PE
4240 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4241
16a97296
PE
4242 Make Emacs functions such as Fatom 'static' by default.
4243 This makes it easier for human readers (and static analyzers)
4244 to see whether these functions can be called from other modules.
4245 DEFUN now defines a static function. To make the function external
4246 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4247 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4248 (Finit_image_library):
16a97296
PE
4249 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4250 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4251 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4252 Remove decls, since these functions are now static.
4253 (Funintern, Fget_internal_run_time): New decls, since these functions
4254 were already external.
95c82688 4255
16a97296
PE
4256 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4257 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4258 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4259 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4260 * keyboard.c, keymap.c, lread.c:
4261 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4262 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4263 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4264 Mark functions with DEFUE instead of DEFUN,
4265 if they are used in other modules.
4266 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4267 decls for now-static functions.
4268 * buffer.h (Fdelete_overlay): Remove decl.
4269 * callproc.c (Fgetenv_internal): Mark as internal.
4270 * composite.c (Fremove_list_of_text_properties): Remove decl.
4271 (Fcomposition_get_gstring): New forward static decl.
4272 * composite.h (Fcomposite_get_gstring): Remove decl.
4273 * dired.c (Ffile_attributes): New forward static decl.
4274 * doc.c (Fdocumntation_property): New forward static decl.
4275 * eval.c (Ffetch_bytecode): New forward static decl.
4276 (Funintern): Remove extern decl; now in .h file where it belongs.
4277 * fileio.c (Fmake_symbolic_link): New forward static decl.
4278 * image.c (Finit_image_library): New forward static decl.
4279 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4280 * intervals.h (Fprevious_property_change):
4281 (Fremove_list_of_text_properties): Remove decls.
4282 * keyboard.c (Fthis_command_keys): Remove decl.
4283 (Fcommand_execute): New forward static decl.
4284 * keymap.c (Flookup_key): New forward static decl.
4285 (Fcopy_keymap): Now static.
4286 * keymap.h (Flookup_key): Remove decl.
4287 * process.c (Fget_process): New forward static decl.
4288 (Fprocess_datagram_address): Mark as internal.
4289 * syntax.c (Fsyntax_table_p): New forward static decl.
4290 (skip_chars): Remove duplicate decl.
4291 * textprop.c (Fprevious_property_change): New forward static decl.
4292 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4293 Now internal.
4294 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4295 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4296
785bbd42
PE
4297 * editfns.c (Fformat): Remove unreachable code.
4298
8b913b57
AS
42992011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4300
4301 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4302 change. (Bug#8496)
4303
a6744a35
EZ
43042011-04-13 Eli Zaretskii <eliz@gnu.org>
4305
4306 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4307 when at ZV. (Bug#8487)
4308
e7974947
AS
43092011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4310
baad03f0
AS
4311 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4312 (Bug#8437)
4313 * keyboard.c (parse_tool_bar_item): Likewise.
4314 * sound.c (sound_cleanup, alsa_close): Likewise.
4315 * termcap.c (tgetent): Likewise.
4316 * xfns.c (x_default_font_parameter): Likewise.
4317 * xsettings.c (read_and_apply_settings): Likewise.
4318
e7974947
AS
4319 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4320 (overrun_check_free): Protoize.
4321
28272684
PE
43222011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4325 since callers should never pass a negative size.
4326 Change the signature to match that of plain 'read' and 'write'; see
4327 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4328 * lisp.h: Update prototypes of emacs_write and emacs_read.
4329
11997c76
EZ
43302011-04-11 Eli Zaretskii <eliz@gnu.org>
4331
4332 * xdisp.c (redisplay_window): Don't try to determine the character
4333 position of the scroll margin if the window start point w->startp
e896f03c 4334 is outside the buffer's accessible region. (Bug#8468)
11997c76 4335
8a2cbd72
EZ
43362011-04-10 Eli Zaretskii <eliz@gnu.org>
4337
4338 Fix write-region and its subroutines for buffers > 2GB.
4339 * fileio.c (a_write, e_write): Modify declaration of arguments and
4340 local variables to support buffers larger than 2GB.
4341 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4342
4343 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4344 argument, local variables, and return value.
4345
4346 * lisp.h: Update prototypes of emacs_write and emacs_read.
4347
4348 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4349
4073e537 43502011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4351
1ebfdcb6
PE
4352 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4353
b2ded58d
PE
4354 Fix more problems found by GCC 4.6.0's static checks.
4355
7d66342c
PE
4356 * xdisp.c (vmessage): Use a better test for character truncation.
4357
bbf47d44
PE
4358 * charset.c (load_charset_map): <, not <=, for optimization,
4359 and to avoid potential problems with integer overflow.
9248994d 4360 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4361 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4362 * editfns.c (Fformat): Likewise.
1e69125e 4363 * syntax.c (skip_chars): Likewise.
3befa583 4364
e3019616
PE
4365 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4366 This also lets GCC 4.6.0 generate slightly better loop code.
4367
becfa255
PE
4368 * callint.c (Fcall_interactively): <, not <=, for optimization.
4369 (Fcall_interactively): Count the number of arguments produced,
4370 not the number of arguments given. This is simpler and lets GCC
4371 4.6.0 generate slightly better code.
4372
dae0cd48
PE
4373 * ftfont.c: Distingish more carefully between FcChar8 and char.
4374 The previous code passed unsigned char * to a functions like
4375 strlen and xstrcasecmp that expect char *, which does not
4376 conform to the C standard.
4377 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4378 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4379 char * when the C standard requires it.
4380
76032d70
PE
4381 * keyboard.c (read_char): Remove unused var.
4382
eb3f1cc8
PE
4383 * eval.c: Port to Windows vsnprintf (Bug#8435).
4384 Include <limits.h>.
4385 (SIZE_MAX): Define if the headers do not.
4386 (verror): Do not give up if vsnprintf returns a negative count.
4387 Instead, grow the buffer. This ports to Windows vsnprintf, which
4388 does not conform to C99. Problem reported by Eli Zaretskii.
4389 Also, simplify the allocation scheme, by avoiding the need for
4390 calling realloc, and removing the ALLOCATED variable.
4391
70476b54
PE
4392 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4393
12020a9e
PE
4394 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4395 But keep the doprint source code for now, as we might revamp it
4396 and use it again (Bug#8435).
ea6c7ae6
PE
4397 * lisp.h (doprnt): Remove.
4398 * Makefile.in (base_obj): Remove doprnt.o.
4399 * deps.mk (doprnt.o): Remove.
4400
5fdb398c
PE
4401 error: Print 32- and 64-bit integers portably (Bug#8435).
4402 Without this change, on typical 64-bit hosts error ("...%d...", N)
4403 was used to print both 32- and 64-bit integers N, which relied on
4404 undefined behavior.
4405 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4406 New macro.
4407 * lisp.h (error, verror): Mark as printf-like functions.
4408 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4409 Report overflow in size calculations when allocating printf buffer.
4410 Do not truncate output string at its first null byte.
4411 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4412 Truncate the output at a character boundary, since vsnprintf does not
4413 do that.
4414 * charset.c (check_iso_charset_parameter): Convert internal
4415 character to string before calling 'error', since %c now has the
4416 printf meaning.
4417 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4418 overflow when computing char to be passed to 'error'. Do not
4419 pass Lisp_Object to 'error'; pass the integer instead.
4420 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4421 formatted with plain %d.
4422
b189fa66
PE
4423 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4424
bff87ef0
PE
4425 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4426
7e2cac20
PE
4427 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4428
ce4d90b5
PE
4429 * xterm.c (x_catch_errors): Remove duplicate declaration.
4430
266c9547
PE
4431 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4432
79c49ad2
PE
4433 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4434
368f4090
JM
44352011-04-10 Jim Meyering <meyering@redhat.com>
4436
4437 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4438 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4439 return ssize_t not "int", and use size_t as the buffer length.
4440 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4441 * gnutls.h: Update declarations.
4442 * process.c (read_process_output): Use ssize_t, to match.
4443 (send_process): Likewise.
4444
a32d4040
CY
44452011-04-09 Chong Yidong <cyd@stupidchicken.com>
4446
4447 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4448
8546720e 44492011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4450
04f2d78b
CB
4451 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4452 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4453
8546720e
GM
4454 * xterm.c (handle_one_xevent):
4455 * xmenu.c (create_and_show_popup_menu):
4456 * xselect.c (x_decline_selection_request)
4457 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4458
0a2f5c1a 44592011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4460
4461 Fix some uses of `int' instead of EMACS_INT.
4462 * search.c (string_match_1, fast_string_match)
4463 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4464 (scan_buffer, find_next_newline_no_quit)
4465 (find_before_next_newline, search_command, Freplace_match)
4466 (Fmatch_data): Make some `int' variables be EMACS_INT.
4467
4468 * xdisp.c (display_count_lines): 3rd argument and return value now
4469 EMACS_INT. All callers changed.
4470 (pint2hrstr): Last argument is now EMACS_INT.
4471
4472 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4473 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4474 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4475 (decode_coding_utf_16, decode_coding_emacs_mule)
4476 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4477 (decode_coding_ccl, decode_coding_charset)
4478 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4479 (decode_coding_iso_2022, decode_coding_emacs_mule)
4480 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4481 <char_offset, last_offset>: Declare EMACS_INT.
4482 (encode_coding_utf_8, encode_coding_utf_16)
4483 (encode_coding_emacs_mule, encode_invocation_designation)
4484 (encode_designation_at_bol, encode_coding_iso_2022)
4485 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4486 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4487 Declare EMACS_INT.
4488 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4489 (encode_invocation_designation): Last argument P_NCHARS is now
4490 EMACS_INT.
4491 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4492 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4493
4494 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4495 All users changed.
4496
4497 * ccl.c (Fccl_execute_on_string): Declare some variables
4498 EMACS_INT.
4499
8546720e 45002011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4501
4502 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4503
4e19a977
CS
45042011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4505
4506 * process.c (Fformat_network_address): Doc fix.
4507
87302331
R
45082011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4509
4510 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4511
cbb59342
CY
45122011-04-08 Chong Yidong <cyd@stupidchicken.com>
4513
4514 * keyboard.c (read_char): Call Lisp function help-form-show,
4515 instead of using internal_with_output_to_temp_buffer.
4516 (Qhelp_form_show): New var.
e0d38eeb 4517 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4518
4519 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4520
4521 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4522
e67a13ab
CY
45232011-04-06 Chong Yidong <cyd@stupidchicken.com>
4524
04f2d78b
CB
4525 * process.c (Flist_processes): Remove to Lisp.
4526 (list_processes_1): Delete.
e67a13ab 4527
973f782d
EZ
45282011-04-06 Eli Zaretskii <eliz@gnu.org>
4529
7c106b1e
EZ
4530 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4531
973f782d
EZ
4532 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4533
41cf7d1a 45342011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4535
ca23cc88
PE
4536 Fix more problems found by GCC 4.6.0's static checks.
4537
f390e2d5
PE
4538 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4539
42eea0d0
PE
4540 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4541
b69769da 4542 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4543
f9541e84
PE
4544 * xdisp.c (vmessage): Mark as a printf-like function.
4545
13841b55
PE
4546 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4547
c136c10f
PE
4548 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4549
5e2d4a30
PE
4550 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4551 printf-like functions.
4552 (tiff_load): Add casts to remove these marks before passing them
4553 to system-supplied API.
4554
583f48b9
PE
4555 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4556
b25d760e
PE
4557 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4558 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4559 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4560 directly, rather than having caller test rule sign. This avoids
4561 some unnecessary tests.
4562 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4563 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4564 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4565
bc7b6697 4566 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4567 (xfont_open): Avoid unnecessary tests.
bc7b6697 4568
27ccc379
PE
4569 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4570
dcd5c89a
PE
4571 * composite.h, composite.c (composition_gstring_put_cache):
4572 Use EMACS_INT, not int, for length.
4573
b13a45c6
PE
4574 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4575 breaking out part of COMPOSITION_DECODE_RULE.
4576 (COMPOSITION_DECODE_RULE): Use it.
4577 * composite.c (get_composition_id): Remove unused local vars,
4578 by using the new macro.
4579
1e792e4d
PE
4580 * textprop.c (set_text_properties_1): Change while to do-while,
4581 since the condition is always true at first.
4582
dc6c6455 4583 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4584 (interval_deletion_adjustment): Return unsigned value.
4585 All uses changed.
dc6c6455 4586
aba7731a
PE
4587 * process.c (list_processes_1, create_pty, read_process_output):
4588 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4589 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4590 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4591 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4592 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4593
fdfc4bf3
PE
4594 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4595
fca8fe46 4596 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4597 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4598
06a0259a 4599 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4600 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4601 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4602
e7b9e80f
PE
4603 * print.c (print_error_message): Avoid int overflow.
4604
56201685
PE
4605 * font.c (font_list_entities): Redo for clarity,
4606 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4607
78834453 4608 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4609 (font_score): Avoid potential overflow in diff calculation.
78834453 4610
0bc0b309 4611 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4612 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4613
e610eaca
PE
4614 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4615
b895abce
PE
4616 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4617 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4618 can always succeed if overflow has undefined behavior.
4619
1f1d9321 4620 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4621 (wordify): Omit three unnecessary tests.
1f1d9321 4622
c59478bc
PE
4623 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4624 All callers changed. This avoids the need for an unused var.
4625
79b73827
PE
4626 * casefiddle.c (casify_region): Remove var that is set but not used.
4627
a4db5dfe
PE
4628 * dired.c (file_name_completion): Remove var that is set but not used.
4629
43aae36e
PE
4630 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4631
2a47c44d 4632 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4633 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4634
a37c69bf
PE
4635 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4636 Check for integer overflow on size calculations.
4637
328ab8e7
PE
4638 * buffer.c (Fprevious_overlay_change): Remove var that is set
4639 but not used.
4640
e5a2a5cb
PE
4641 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4642 Remove vars that are set but not used.
8d84a6eb 4643 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4644 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4645
a60e5f68
PE
4646 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4647
f661cb61 4648 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4649 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4650
f0397f5a
PE
4651 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4652 that are set but not used.
4653
8664db06 4654 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4655 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4656
6abdaa4a
PE
4657 * xselect.c (x_get_local_selection, x_handle_property_notify):
4658 Remove vars that are set but not used.
4659
0ce7538d 4660 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4661 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4662
9ae848fc
PE
4663 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4664 Remove var that is set but not used.
0b918413
PE
4665 (scroll_bar_windows_size): Now size_t, not int.
4666 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4667 Check for overflow.
9ae848fc 4668
a5a62657
PE
4669 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4670 (map_tty_color) [!defined MSDOS]: Likewise.
4671
5c5cdd39
PE
4672 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4673
66ebf983
PE
4674 * coding.c: Remove vars that are set but not used.
4675 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4676 All callers changed.
4677 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4678 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4679 (decode_coding_charset): Remove vars that are set but not used.
4680
1be4d761
PE
4681 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4682 that is set but not used.
4683
47553fa8
PE
4684 * print.c (print_object): Remove var that is set but not used.
4685
1f7196bf 4686 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4687 The gnulib version avoids calling malloc in the usual case,
4688 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4689 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4690 * filelock.c (current_lock_owner): Likewise.
4691 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4692 * sysdep.c: Include allocator.h, careadlinkat.h.
4693 (emacs_no_realloc_allocator): New static constant.
4694 (emacs_readlink): New function.
fdb61804
PE
4695 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4696 ../lib/careadlinkat.h.
d1fdcab7 4697
f84c17c7
SM
46982011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4699
4700 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4701 first non-nil return value).
4702
ef3862ad
JD
47032011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4704
4705 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4706 if not defined (Bug#8403).
4707
376a7006
JB
47082011-04-02 Juanma Barranquero <lekktu@gmail.com>
4709
4710 * xdisp.c (display_count_lines): Remove parameter `start',
4711 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4712 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4713 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4714 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4715 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4716 and thereabouts. All callers changed.
4717 (get_per_char_metric): Remove parameter `f', unused since
4718 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4719
6ca3801d
JM
47202011-04-02 Jim Meyering <meyering@redhat.com>
4721
4722 do not dereference NULL upon failed strdup
4723 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4724 (ns_get_family): Likewise.
4725
d8e2b5ba
JB
47262011-04-02 Juanma Barranquero <lekktu@gmail.com>
4727
4728 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4729
8c74fcbd
JD
47302011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4731
4732 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4733 later (Bug#8403).
4734
7200d79c
SM
47352011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4736
03408648 4737 Add lexical binding.
7200d79c 4738
03408648
SM
4739 * window.c (Ftemp_output_buffer_show): New fun.
4740 (Fsave_window_excursion):
4741 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4742
4743 * lread.c (lisp_file_lexically_bound_p): New function.
4744 (Fload): Bind Qlexical_binding.
4745 (readevalloop): Remove `evalfun' arg.
4746 Bind Qinternal_interpreter_environment.
4747 (Feval_buffer): Bind Qlexical_binding.
4748 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4749 Mark as dynamic.
4750 (syms_of_lread): Declare `lexical-binding'.
4751
4752 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4753
4754 * keyboard.c (eval_dyn): New fun.
4755 (menu_item_eval_property): Use it.
ca105506
SM
4756
4757 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4758
03408648
SM
4759 * fns.c (concat, mapcar1): Accept byte-code-functions.
4760
4761 * eval.c (Fsetq): Handle lexical vars.
4762 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4763 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4764 (FletX, Flet): Obey lexical binding.
4765 (Fcommandp): Handle closures.
4766 (Feval): New `lexical' arg.
4767 (eval_sub): New function extracted from Feval. Use it almost
4768 everywhere where Feval was used. Look up vars in lexical env.
4769 Handle closures.
4770 (Ffunctionp): Move from subr.el.
4771 (Ffuncall): Handle closures.
4772 (apply_lambda): Remove `eval_flags'.
4773 (funcall_lambda): Handle closures and new byte-code-functions.
4774 (Fspecial_variable_p): New function.
4775 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4776 but without exporting it to Lisp.
23aba0ea 4777
23aba0ea 4778 * doc.c (Fdocumentation, store_function_docstring):
03408648 4779 * data.c (Finteractive_form): Handle closures.
23aba0ea 4780
03408648
SM
4781 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4782 interactive spec.
ba83908c 4783
04f2d78b
CB
4784 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4785 New byte-codes.
03408648
SM
4786 (exec_byte_code): New function extracted from Fbyte_code to handle new
4787 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4788
03408648 4789 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4790
03408648 4791 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4792
e2abce01
JB
47932011-03-31 Juanma Barranquero <lekktu@gmail.com>
4794
4795 * xdisp.c (redisplay_internal): Fix prototype.
4796
63696a73 47972011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4798
63696a73 4799 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4800 (try_scrolling): Use it when setting scroll_limit.
4801 Limit scrolling to 100 screen lines.
63696a73
EZ
4802 (redisplay_window): Even when falling back on "recentering",
4803 position point in the window according to scroll-conservatively,
4804 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4805
4806 (try_scrolling): When point is above the window, allow searching
4807 as far as scroll_max, or one screenful, to compute vertical
4808 distance from PT to the scroll margin position. This prevents
4809 try_scrolling from unnecessarily failing when
4810 scroll-conservatively is set to a value slightly larger than the
4811 window height. Clean up the case of PT below the margin at bottom
4812 of window: scroll_max can no longer be INT_MAX. When aggressive
4813 scrolling is in use, don't let point enter the opposite scroll
4814 margin as result of the scroll.
4815 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4816 threshold of 100 lines for never-recentering scrolling.
4817
e4cc2dfc
JB
48182011-03-31 Juanma Barranquero <lekktu@gmail.com>
4819
4820 * dispextern.h (move_it_by_lines):
4821 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4822 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4823 (message_log_check_duplicate): Remove parameters `prev_bol' and
4824 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4825 (redisplay_internal): Remove parameter `preserve_echo_area',
4826 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4827
4828 * indent.c (Fvertical_motion):
4829 * window.c (window_scroll_pixel_based, Frecenter):
4830 Don't pass `need_y_p' to `move_it_by_lines'.
4831
1c470562
SM
48322011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4833
44f230aa
SM
4834 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4835 steal a few bits to be more compact.
4836 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4837 Remove unneeded casts.
4838
1c470562
SM
4839 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4840
888adce9
ZK
48412011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4842
4843 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4844 binding" message (bug#7967).
4845
f838ed7b
PE
48462011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4847
77861b95
PE
4848 Fix more problems found by GCC 4.6.0's static checks.
4849
de6dbc14
PE
4850 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4851 Remove unused local var.
4852
f838ed7b
PE
4853 * editfns.c (Fmessage_box): Remove unused local var.
4854
792c7b2b
PE
4855 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4856 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4857 Omit unused local vars.
c499e557 4858 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4859 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4860 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4861 Omit unused local var.
4862
ba0165e1
PE
4863 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4864 Don't assume string length fits in int.
32ad8845 4865 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4866 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4867
3c59b4c9
PE
4868 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4869 instead of alloca (Bug#8344).
4870
a3eed478 4871 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4872 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4873
eb4d412d
PE
4874 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4875
1658b401
PE
4876 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4877 concerns.
4878
4879 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4880
4881 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4882
9a2c6e05
PE
4883 * keyboard.c (syms_of_keyboard): Use the same style as later
4884 in this function when indexing through an array. This also
4885 works around GCC bug 48267.
4886
03d0a109
PE
4887 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4888
44f730c8
PE
4889 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4890
fe75f926
PE
4891 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4892 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4893
ffa8c828
PE
4894 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4895 This avoids undefined behavior on integer overflow, and is a bit
4896 more convenient anyway since it is compared to a size_t variable.
4897
c5101a77
PE
4898 Variadic C functions now count arguments with size_t, not int.
4899 This avoids an unnecessary limitation on 64-bit machines, which
4900 caused (substring ...) to crash on large vectors (Bug#8344).
4901 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4902 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4903 All variadic functions and their callers changed accordingly.
c5101a77
PE
4904 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4905 * data.c (arith_driver, float_arith_driver): Likewise.
4906 * editfns.c (general_insert_function): Likewise.
4907 * eval.c (struct backtrace.nargs, interactive_p)
4908 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4909 (funcall_lambda, mark_backtrace): Likewise.
4910 * fns.c (concat): Likewise.
4911 * frame.c (x_set_frame_parameters): Likewise.
4912 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4913 0 if not found, not -1. All callers changed.
4914
dd3f25f7
PE
4915 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4916 (stack_copy_size): Now size_t, not int.
4917 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4918
461c2ab9
JB
49192011-03-28 Juanma Barranquero <lekktu@gmail.com>
4920
4921 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4922 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4923 All callers changed.
4924
4925 * lisp.h (multibyte_char_to_unibyte):
4926 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4927 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4928 * character.h (CHAR_TO_BYTE8):
4929 * cmds.c (internal_self_insert):
4930 * editfns.c (general_insert_function):
4931 * keymap.c (push_key_description):
4932 * search.c (Freplace_match):
4933 * xdisp.c (message_dolog, set_message_1): All callers changed.
4934
f6d62986
SM
49352011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4936
4937 * keyboard.c (safe_run_hook_funcall): New function.
4938 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4939 don't set the hook to nil, but remove the offending function instead.
4940 (Qcommand_hook_internal): Remove, unused.
4941 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4942 Vcommand_hook_internal.
4943
4944 * eval.c (enum run_hooks_condition): Remove.
4945 (funcall_nil, funcall_not): New functions.
4946 (run_hook_with_args): Call each function through a `funcall' argument.
4947 Remove `cond' argument, now redundant.
4948 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4949 (Frun_hook_with_args_until_failure): Adjust accordingly.
4950 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4951
1db5b1ad
JB
49522011-03-28 Juanma Barranquero <lekktu@gmail.com>
4953
4954 * dispextern.h (string_buffer_position): Remove declaration.
4955
4956 * print.c (strout): Remove parameter `multibyte', unused since
4957 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4958
4959 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4960 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4961 All callers changed.
4962
4963 * w32.c (_wsa_errlist): Use braces for struct initializers.
4964
4965 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4966 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4967 All callers changed.
4968 (string_buffer_position): Likewise. Also, make static (it's never
4969 used outside xdisp.c).
4970 (cursor_row_p): Remove parameter `w', unused since
4971 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4972 (decode_mode_spec): Remove parameter `precision', introduced during
4973 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4974 All callers changed.
4975
5ffb62aa
JD
49762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4977
4978 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4979
461c2ab9 49802011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4981
4982 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4983 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4984 (ns_update_auto_hide_menu_bar): New functions.
4985 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4986 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4987 ns_constrain_all_frames.
4988 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4989 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4990
5c380ffb
JD
49912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4992
4993 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4994
9af30bdf
GM
49952011-03-27 Glenn Morris <rgm@gnu.org>
4996
4997 * syssignal.h: Replace RETSIGTYPE with void.
4998 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4999 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5000 Replace SIGTYPE with void everywhere.
5001 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5002 * s/template.h (SIGTYPE): Remove commented out definition.
5003
e2abce01
JB
50042011-03-26 Eli Zaretskii <eliz@gnu.org>
5005
5006 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5007 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5008
f868cd8a
JB
50092011-03-26 Juanma Barranquero <lekktu@gmail.com>
5010
59eb0929
JB
5011 * w32.c (read_unc_volume): Use parameter `henum', instead of
5012 global variable `wget_enum_handle'.
5013
5014 * keymap.c (describe_vector): Remove parameters `indices' and
5015 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5016 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5017
f868cd8a
JB
5018 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5019
5020 * keyboard.c (timer_check): Remove parameter `do_it_now',
5021 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5022 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5023 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5024
5025 * keyboard.c (read_char):
5026 * w32menu.c (w32_menu_display_help):
5027 * xmenu.c (show_help_event, menu_help_callback):
5028 Adjust calls to `show_help_echo'.
5029
5030 * gtkutil.c (xg_maybe_add_timer):
5031 * keyboard.c (readable_events):
5032 * process.c (wait_reading_process_output):
5033 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5034
5035 * insdel.c (adjust_markers_gap_motion):
5036 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5037 (gap_left, gap_right): Don't call it.
5038
2ecf6fdb
CY
50392011-03-25 Chong Yidong <cyd@stupidchicken.com>
5040
5041 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5042 incurred during fontification.
5043
6b1f9ba4
JB
50442011-03-25 Juanma Barranquero <lekktu@gmail.com>
5045
5046 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5047 (DEFVAR_PER_BUFFER): Don't pass it.
5048
5049 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5050 (scrolling_window): Don't pass it.
5051
0f4a96b5
JB
50522011-03-25 Juanma Barranquero <lekktu@gmail.com>
5053
5054 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5055
5056 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5057 and `suffix'.
5058 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5059 of variables specific to SELinux and computation of `encoded_absname'.
5060
5061 * image.c (XPutPixel): Remove unused variable `height'.
5062
5063 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5064
5065 * unexw32.c (get_section_info): Remove unused variable `section'.
5066
5067 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5068 (system_process_attributes): Remove unused variable `sess'.
5069 (sys_read): Remove unused variable `err'.
5070
5071 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5072 (w32_wnd_proc): Remove unused variable `isdead'.
5073 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5074 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5075 (x_create_tip_frame): Remove unused variable `tem'.
5076
5077 * w32inevt.c (w32_console_read_socket):
5078 Remove unused variable `no_events'.
5079
5080 * w32term.c (x_draw_composite_glyph_string_foreground):
5081 Remove unused variable `width'.
5082
1149507c
JB
50832011-03-24 Juanma Barranquero <lekktu@gmail.com>
5084
5085 * w32term.c (x_set_glyph_string_clipping):
5086 Don't pass uninitialized region to CombineRgn.
5087
9c88f339
JB
50882011-03-23 Juanma Barranquero <lekktu@gmail.com>
5089
5090 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5091 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5092 (Fx_close_connection): Remove unused variable `i'.
5093
5094 * w32font.c (w32font_draw): Return number of glyphs.
5095 (w32font_open_internal): Remove unused variable `i'.
5096 (w32font_driver): Add missing initializer.
5097
5098 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5099 (fill_in_menu): Remove unused variable `items_added'.
5100
5101 * w32term.c (last_mouse_press_frame): Remove static global variable.
5102 (w32_clip_to_row): Remove unused variable `f'.
5103 (x_delete_terminal): Remove unused variable `i'.
5104
5105 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5106 (NOTHING): Remove unused static global variable.
5107 (uniscribe_check_otf): Remove unused variable `table'.
5108 (uniscribe_font_driver): Add missing initializers.
5109
dee091a3
JD
51102011-03-23 Julien Danjou <julien@danjou.info>
5111
5112 * term.c (Fsuspend_tty, Fresume_tty):
5113 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5114 * window.c (temp_output_buffer_show):
5115 * insdel.c (signal_before_change):
5116 * frame.c (Fhandle_switch_frame):
5117 * fileio.c (Fdo_auto_save):
5118 * emacs.c (Fkill_emacs):
5119 * editfns.c (save_excursion_restore):
5120 * cmds.c (internal_self_insert):
5121 * callint.c (Fcall_interactively):
5122 * buffer.c (Fkill_all_local_variables):
5123 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5124 Use Frun_hooks.
0f4a96b5 5125 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5126 unconditionnaly since it does the check itself.
5127
2c520ab5 51282011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5129
c9c49752
PE
5130 Fix more problems found by GCC 4.5.2's static checks.
5131
8abc3f12
PE
5132 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5133 the first time through the loop, since we know p0 < p1 then.
5134 This also avoids a gcc -Wstrict-overflow warning.
5135
a2d26660
PE
5136 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5137 leading to a memory leak, possible in functions like
5138 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5139 of objects (Bug#8318).
a2d26660 5140
916c72e9
PE
5141 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5142 that could (at least in theory) be that large.
5143
19ab8a18
PE
5144 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5145 This is less likely to overflow, and avoids undefined behavior if
5146 overflow does occur. All callers changed. Use strtoul to scan
5147 for the unsigned long integer.
b7cbbd6f
PE
5148 (pint2hrstr): Simplify and tune code slightly.
5149 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5150
f0641eff
PE
5151 * scroll.c (do_scrolling): Work around GCC bug 48228.
5152 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5153
7f650bb9
PE
5154 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5155 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5156 (validate_x_resource_name): Simplify count usage.
5157 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5158
37dd57d1
PE
5159 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5160 fail (Bug#8306).
81e56e61 5161
699979fc 5162 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5163
401bf9b4
PE
5164 * process.c (Fmake_network_process): Use socklen_t, not int,
5165 where POSIX says socklen_t is required in portable programs.
5166 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5167 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5168 (Fmake_network_process, server_accept_connection):
5169 (wait_reading_process_output, read_process_output):
5170 Likewise.
5171
b93aacde
PE
5172 * process.c: Rename or move locals to avoid shadowing.
5173 (list_processes_1, Fmake_network_process):
5174 (read_process_output_error_handler, exec_sentinel_error_handler):
5175 Rename or move locals.
4dc343ee 5176 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5177 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5178 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5179 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5180 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5181
af8a867c 5182 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5183 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5184 Include tparam.h instead, since it declares them.
af8a867c
PE
5185 * cm.h (PC): Remove extern decl; tparam.h now does this.
5186 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5187 * terminfo.c: Include tparam.h, to check interfaces.
5188 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5189 (tparam): Adjust signature to match interface in tparam.h;
5190 this removes some undefined behavior. Check that outstring and len
5191 are zero, which they always are with Emacs.
5192 * tparam.h (PC, BC, UP): New extern decls.
5193
0248044d 5194 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5195 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5196
8ff096c1 5197 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5198 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5199 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5200 (ftfont_list): Remove unused local.
49eaafba
PE
5201 (get_adstyle_property, ftfont_pattern_entity):
5202 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5203 Rename locals to avoid shadowing.
8ff096c1 5204
e2be39f6
PE
5205 * xfont.c (xfont_list_family): Mark var as initialized.
5206
c9735e30
PE
5207 * xml.c (make_dom): Now static.
5208
8f5201ae
PE
5209 * composite.c (composition_compute_stop_pos): Rename local to
5210 avoid shadowing.
b246f932
PE
5211 (composition_reseat_it): Remove unused locals.
5212 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5213 (composition_update_it): Mark var as initialized.
11b61122
PE
5214 (find_automatic_composition): Mark vars as initialized,
5215 with a FIXME (Bug#8290).
8f5201ae 5216
760fbc2c
PE
5217 character.h: Rename locals to avoid shadowing.
5218 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5219 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5220 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5221 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5222 to avoid shadowing.
5223
ff08eb85
PE
5224 * textprop.c (property_change_between_p): Remove; unused.
5225
fc7bf025
PE
5226 * intervals.c (interval_start_pos): Now static.
5227
235d7abc
PE
5228 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5229
44f230aa
SM
5230 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5231 Rename locals to avoid shadowing.
3e7d6594 5232
50060332
PE
5233 * sound.c (wav_play, au_play, Fplay_sound_internal):
5234 Fix pointer signedness.
d01f234b 5235 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5236 (wav_play): Initialize a variable to 0, to prevent undefined
5237 behavior (Bug#8278).
50060332 5238
c4fc4e30
PE
5239 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5240
918436ed
PE
5241 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5242
c939f91b
PE
5243 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5244 clobbering (Bug#8298).
b9c7f648
PE
5245 * sysdep.c (sys_subshell): Likewise.
5246 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5247
6bd8c144
PE
5248 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5249 This should get cleaned up, so that child_setup has the
5250 same signature on all platforms.
5251
7710357c 5252 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5253 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5254
c59da222
CY
52552011-03-22 Chong Yidong <cyd@stupidchicken.com>
5256
5257 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5258 not to be necessary, and produces flickering.
5259
66b87493
GM
52602011-03-20 Glenn Morris <rgm@gnu.org>
5261
5262 * config.in: Remove file.
5263
45b6f6d5
JB
52642011-03-20 Juanma Barranquero <lekktu@gmail.com>
5265
5266 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5267 are now in src/globals.h.
5268 (syms_of_minibuf): Remove spurious & from previous change.
5269
3ec03f7e
LL
52702011-03-20 Leo <sdl.web@gmail.com>
5271
5272 * minibuf.c (completing-read-function): New variable.
5273 (completing-read-default): Rename from completing-read.
5274 (completing-read): Call completing-read-function.
5275
b14e3e21
CY
52762011-03-19 Juanma Barranquero <lekktu@gmail.com>
5277
5278 * xfaces.c (Fx_load_color_file):
5279 Read color file from absolute filename (bug#8250).
5280
f2b726e6
JB
52812011-03-19 Juanma Barranquero <lekktu@gmail.com>
5282
5283 * makefile.w32-in: Update dependencies.
5284
09f6ff02
EZ
52852011-03-17 Eli Zaretskii <eliz@gnu.org>
5286
5287 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5288
29a6015a
PE
52892011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5290
a3a6c54e
PE
5291 Fix more problems found by GCC 4.5.2's static checks.
5292
b766f867
PE
5293 * process.c (make_serial_process_unwind, send_process_trap):
5294 (sigchld_handler): Now static.
5295
be02381c
PE
5296 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5297 That way, the code declares only the vars that it needs.
5298 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5299 * s/cygwin.h (PTY_ITERATION): Likewise.
5300 * s/darwin.h (PTY_ITERATION): Likewise.
5301 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5302
57048744
PE
5303 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5304 * process.c (allocate_pty): Don't declare stb unless it's needed.
5305
7914961c 5306 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5307 (CONSTANTLIM): Remove; unused.
5308 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5309 Define only if needed.
7914961c 5310
b3967b18
PE
5311 * unexelf.c (unexec): Name an expression,
5312 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5313 Use a different way to cause a compilation error if anyone uses
5314 n rather than nn, a way that does not involve shadowing.
73366a00 5315 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5316
29a6015a
PE
5317 * deps.mk (unexalpha.o): Remove; unused.
5318
43cfc33e 5319 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5320 * unexec.h: New file.
ce701a33
PE
5321 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5322 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5323 Depend on unexec.h.
5324 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5325 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5326 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5327 Change as necessary to match prototype in unexec.h.
ce701a33 5328
01f44d5a
PE
5329 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5330 shadowing.
4f63c6bb 5331 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5332
a6670b0b
PE
5333 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5334 Rename locals to avoid shadowing.
5335
cef2010d 5336 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5337 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5338
d4d7173a
PE
5339 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5340
f08b802a
PE
5341 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5342 warning when compiling print.c.
5343
3ddb0639
PE
5344 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5345 instead of using an uninitialized var.
5ad03b97 5346 (font_sort_entities): Mark var as initialized.
3ddb0639 5347
170a2692
PE
5348 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5349
e663c700
PE
5350 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5351 pointers to constants.
89bc529a 5352 (font_parse_fcname): Remove unused vars.
7b81e2d0 5353 (font_delete_unmatched): Now static.
ea838e10 5354 (font_get_spec): Remove; unused.
13a547c6
PE
5355 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5356 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5357 Rename or move locals to avoid shadowing.
e663c700 5358
2a80c887 5359 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5360 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5361
1384fa33 5362 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5363 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5364
8b2c52e9
PE
5365 * alloc.c (mark_backtrace): Move decl from here ...
5366 * lisp.h: ... to here, so that it can be checked.
5367
475545b5 5368 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5369 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5370 (lisp_indirect_variable): Name an expression,
5371 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5372 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5373
b1349114 5374 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5375 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5376 Use const pointer when appropriate.
b1349114 5377
a2928364
PE
5378 * lisp.h (get_system_name, get_operating_system_release):
5379 Move decls here, to check interfaces.
5380 * process.c (get_operating_system_release): Move decl to lisp.h.
5381 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5382 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5383 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5384 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5385 (Fformat_time_string, Fencode_time, Finsert_char):
5386 (Ftranslate_region_internal, Fformat):
5387 Rename or remove local vars to avoid shadowing.
9710023e 5388 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5389
a415e694
PE
5390 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5391 avoid shadowing.
5392
8ef4622d
PE
5393 * lisp.h (eassert): Check that the argument compiles, even if
5394 ENABLE_CHECKING is not defined.
5395
946f9a5b
PE
5396 * data.c (Findirect_variable): Name an expression, to avoid
5397 gcc -Wbad-function-cast warning.
112396d6 5398 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5399 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5400 (Fmake_variable_buffer_local, Fmake_local_variable):
5401 Mark variables as initialized.
52746918 5402 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5403
e5aab7e7 5404 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5405 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5406 Rename locals to avoid shadowing.
dff45157
PE
5407 (mark_stack): Move local variables into the #ifdef region where
5408 they're used.
7bc26fdb
PE
5409 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5410 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5411 needed otherwise.
5412 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5413 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5414 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5415
e5aab7e7
PE
5416 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5417 avoids undefined behavior in theory.
5418
4da60324
PE
5419 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5420
88043301
PE
5421 Use functions, not macros, for up- and down-casing (Bug#8254).
5422 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5423 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5424 to use the following functions instead of these macros.
5425 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5426 EMACS_INT, since callers assume the returned value fits in int.
5427 (upcase1): Likewise, for UPCASE_TABLE.
5428 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5429 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5430 the race-condition problem in the old DOWNCASE.
88043301 5431
19ed5445
PE
5432 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5433 Rename locals to avoid shadowing.
5434 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5435 (regex_compile, re_search_2, re_match_2_internal):
5436 Remove unused local vars.
952db0d7
PE
5437 (FREE_VAR): Rewrite so as not to use empty "else",
5438 which gcc can warn about.
da053e48 5439 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5440 (RETALLOC_IF): Define only if needed.
5441 (WORDCHAR_P): Likewise. This one is never needed, but is used
5442 only in a comment talking about a compiler bug, so put inside
5443 the #if 0 of that comment.
5444 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5445 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5446 Remove; unused.
19ed5445 5447
1f3561e4 5448 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5449 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5450 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5451
ded6f8f7
PE
5452 * search.c (simple_search): Remove unused var.
5453
dbd37a95
PE
5454 * dired.c (compile_pattern): Move decl from here ...
5455 * lisp.h: ... to here, so that it can be checked.
5456 (struct re_registers): New forward decl.
5457
7e47afad
PE
5458 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5459
85f24f61
PE
5460 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5461 All uses changed.
5462 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5463 Rename locals to avoid shadowing.
5671df8f 5464 (Fvertical_motion): Mark locals as initialized.
85f24f61 5465
181aa2be 5466 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5467 (casify_region): Mark local as initialized.
181aa2be 5468
930d429c
PE
5469 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5470
7082eac6
PE
5471 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5472 New macros, so that the caller can use some names other than
5473 gcpro1, gcpro2, etc.
5474 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5475 of the new macros.
5476 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5477 argument, for consistency with GCPRO2_VAR, etc: it is now the
5478 prefix of the variable, not the variable itself. All uses
5479 changed.
38b2c076
PE
5480 * dired.c (directory_files_internal, file_name_completion):
5481 Rename locals to avoid shadowing.
5482
15206ed9
PE
5483 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5484 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5485 dired.c's scmp function, had undefined behavior.
5486 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5487 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5488 * buffer.h: ... to here, because these macros use current_buffer,
5489 and the new implementation with inline functions needs to have
5490 current_buffer in scope now, rather than later when the macros
5491 are used.
5492 (downcase, upcase1): New static inline functions.
5493 (DOWNCASE, UPCASE1): Reimplement using these functions.
5494 This avoids undefined behavior in expressions like
5495 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5496 from race conditions in accessing the global variables
5497 case_temp1 and case_temp2.
5498 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5499 * lisp.h (case_temp1, case_temp2): Remove their decls.
5500 * character.h (ASCII_CHAR_P): Move from here ...
5501 * lisp.h: ... to here, so that the inline functions mentioned
5502 above can use them.
5503
4a6bea26
PE
5504 * dired.c (directory_files_internal_unwind): Now static.
5505
f14b7e14
PE
5506 * fileio.c (file_name_as_directory, directory_file_name):
5507 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5508 Now static.
2893f146
PE
5509 (file_name_as_directory): Use const pointers when appropriate.
5510 (Fexpand_file_name): Likewise. In particular, newdir might
5511 point at constant storage, so make it a const pointer.
fd4ead52 5512 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5513 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5514 signedness issues.
f839df0c
PE
5515 (Fset_file_times, Finsert_file_contents, auto_save_error):
5516 Rename locals to avoid shadowing.
f14b7e14 5517
5716756e 5518 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5519 (Ftry_completion, Fall_completions): Rename or remove locals
5520 to avoid shadowing.
5716756e 5521
b4c3046a
PE
5522 * marker.c (bytepos_to_charpos): Remove; unused.
5523
b45db522
PE
5524 * lisp.h (verify_bytepos, count_markers): New decls,
5525 so that gcc does not warn that these functions aren't declared.
5526
85876d07
PE
5527 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5528 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5529 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5530 (copy_text): Remove unused local var.
85876d07 5531
03d78a21 5532 * filelock.c (within_one_second): Now static.
b3dd38ab 5533 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5534
5df8f01b
PE
5535 * buffer.c (fix_overlays_before): Mark locals as initialized.
5536 (fix_start_end_in_overlays): Likewise. This function should be
5537 simplified by using pointers-to-pointers, but that's a different
5538 matter.
b1d876f1 5539 (switch_to_buffer_1): Now static.
8f54f30a
PE
5540 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5541 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5542
a70072c9 5543 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5544 Fix pointer signedness issue.
edced198
PE
5545 (sys_subshell): Mark local as volatile if checking for lint,
5546 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5547 (MAXPATHLEN): Define only if needed.
a70072c9 5548
a0977c44
PE
5549 * process.c (serial_open, serial_configure): Move decls from here ...
5550 * systty.h: ... to here, so that they can be checked.
5551
a884fdcc
PE
5552 * fns.c (get_random, seed_random): Move extern decls from here ...
5553 * lisp.h: ... to here, so that they can be checked.
5554
604efe86 5555 * sysdep.c (reset_io): Now static.
b8950c94 5556 (wait_for_termination_signal): Remove; unused.
604efe86 5557
38fc62d9
PE
5558 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5559 (copy_keymap_item, append_key, push_text_char_description):
5560 Now static.
1004a21a 5561 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5562 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5563 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5564 (describe_map_tree):
5565 Rename locals to avoid shadowing.
38fc62d9 5566
2f2650da
PE
5567 * keyboard.c: Declare functions static if they are not used elsewhere.
5568 (echo_char, echo_dash, cmd_error, top_level_2):
5569 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5570 (read_char, kbd_buffer_get_event, make_lispy_position):
5571 (make_lispy_event, make_lispy_movement, apply_modifiers):
5572 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5573 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5574 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5575 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5576 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5577
a053e86c 5578 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5579 (mark_kboards): Move decl here ...
5580 * alloc.c (mark_kboards): ... from here.
a053e86c 5581
4752793e
PE
5582 * lisp.h (force_auto_save_soon): New decl.
5583
74f10ca7 5584 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5585 (DEFINE_DUMMY_FUNCTION): New macro.
5586 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5587 Use it.
c03cd23f
PE
5588 (main): Add casts to avoid warnings
5589 if GCC considers string literals to be constants.
74f10ca7 5590
022e70d4
PE
5591 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5592
59d6fe83
PE
5593 * dbusbind.c: Pointer signedness fixes.
5594 (xd_signature, xd_append_arg, xd_initialize):
5595 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5596 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5597 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5598 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5599
78320123
PE
5600 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5601 if GCC considers string literals to be constants.
49cebcca 5602 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5603
35ac2a97
SM
56042011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5605
fb103ca9
SM
5606 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5607 (print_preprocess, print_object): New macro to fix last change.
5608
35ac2a97
SM
5609 * print.c (print_preprocess): Don't forget font objects.
5610
62973b41
JB
56112011-03-16 Juanma Barranquero <lekktu@gmail.com>
5612
5613 * emacs.c (USAGE3): Doc fixes.
5614
0e48bb22
AS
56152011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5616
5617 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5618 structure.
5619
7684e57b
JB
56202011-03-14 Juanma Barranquero <lekktu@gmail.com>
5621
5622 * lisp.h (VWindow_system, Qfile_name_history):
5623 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5624 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5625 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5626
5627 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5628 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5629
5630 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5631 * w32console.c (detect_input_pending, read_input_pending)
5632 (encode_terminal_code):
5633 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5634 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5635 (w32_system_caret_y, Qfile_name_history):
5636 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5637 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5638 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5639 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5640 * w32proc.c (Qlocal, report_file_error):
5641 * w32term.c (Vwindow_system, updating_frame):
5642 * w32uniscribe.c (initialized, uniscribe_font_driver):
5643 Remove unneeded extern declarations.
5644
2aa46d6c
CY
56452011-03-14 Chong Yidong <cyd@stupidchicken.com>
5646
c96bbc66 5647 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5648
cffc6f3b
CY
56492011-03-13 Chong Yidong <cyd@stupidchicken.com>
5650
5651 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5652 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5653 These macros can no longer be used for assignment.
5654
44f230aa
SM
5655 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5656 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5657 (record_buffer_markers, fetch_buffer_markers): New functions for
5658 recording and fetching special buffer markers.
5659 (set_buffer_internal_1, set_buffer_temp): Use them.
5660
5661 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5662
5663 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5664
5665 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5666 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5667
5668 * xdisp.c (hscroll_window_tree):
5669 (reconsider_clip_changes): Use PT instead of BUF_PT.
5670
d251f04b
EZ
56712011-03-13 Eli Zaretskii <eliz@gnu.org>
5672
5673 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5674 $(EMACS_ROOT)/lib/intprops.h.
5675
f0c77cd1
PE
56762011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5677
3eca4629
PE
5678 Fix more problems found by GCC 4.5.2's static checks.
5679
7c86ee98
PE
5680 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5681 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5682 (xg_free_frame_widgets): Make it clear that a local variable is
5683 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5684 (gdk_window_get_screen): Make it clear that this macro is needed
5685 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5686 (int_gtk_range_get_value): New function, which avoids a diagnostic
5687 from gcc -Wbad-function-cast.
5688 (xg_set_toolkit_scroll_bar_thumb): Use it.
5689 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5690 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5691 (get_utf8_string, xg_get_file_with_chooser):
5692 Rename locals to avoid shadowing.
5693 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5694
41729b81
PE
5695 * xgselect.c (xg_select): Remove unused var.
5696
f0c77cd1
PE
5697 * image.c (four_corners_best): Mark locals as initialized.
5698 (gif_load): Initialize transparent_p to zero (Bug#8238).
5699 Mark another local as initialized.
ec6cf4c6 5700 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5701
ce0ad53d 5702 * image.c (clear_image_cache): Now static.
d5d5a617 5703 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5704 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5705 (x_edge_detection): Remove unnecessary cast that
5706 gcc -Wbad-function-cast diagnoses.
2037898d 5707 (gif_load): Fix pointer signedness.
6ae141d6
PE
5708 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5709 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5710
33383987 57112011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5712
d32df629
PE
5713 Improve quality of tests for time stamp overflow.
5714 For example, without this patch (encode-time 0 0 0 1 1
5715 1152921504606846976) returns the obviously-bogus value (-948597
5716 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5717 reports time overflow. See
5718 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5719 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5720 * editfns.c: Include limits.h and intprops.h.
5721 (TIME_T_MIN, TIME_T_MAX): New macros.
5722 (time_overflow): Move earlier, to before first use.
5723 (hi_time, lo_time): New functions, for an accurate test for
5724 out-of-range times.
5725 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5726 (Fget_internal_run_time): Don't assume time_t fits in int.
5727 (make_time): Use list2 instead of Fcons twice.
5728 (Fdecode_time): More accurate test for out-of-range times.
5729 (check_tm_member): New function.
5730 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5731 (lisp_time_argument): Don't rely on undefined left-shift and
5732 right-shift behavior when checking for time stamp overflow.
8be6f318 5733
fe31d94c
PE
5734 * editfns.c (time_overflow): New function, refactoring common code.
5735 (Fformat_time_string, Fdecode_time, Fencode_time):
5736 (Fcurrent_time_string): Use it.
5737
8be6f318
PE
5738 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5739 * dired.c (make_time): Move to ...
5740 * editfns.c (make_time): ... here.
5741 * systime.h: Note the move.
5742
09d9db2c 57432011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5744
126bc0dc
YM
5745 * fringe.c (update_window_fringes): Remove unused variables.
5746
c47cbdfd
YM
5747 * unexmacosx.c (copy_data_segment): Also copy __got section.
5748 (Bug#8223)
5749
7ac80be9
EZ
57502011-03-12 Eli Zaretskii <eliz@gnu.org>
5751
c96bbc66 5752 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5753 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5754 Constify `char *' arguments and their references according to
5755 prototypes in tparam.h.
5756
ecb0f94d 5757 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5758
7ac80be9
EZ
5759 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5760 Adapt all references accordingly.
5761
5762 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5763
ef1fd07e
TT
57642011-03-11 Tom Tromey <tromey@redhat.com>
5765
5766 * buffer.c (syms_of_buffer): Remove obsolete comment.
5767
7ef4b50c
EZ
57682011-03-11 Eli Zaretskii <eliz@gnu.org>
5769
5770 * termhooks.h (encode_terminal_code): Declare prototype.
5771
5772 * msdos.c (encode_terminal_code): Don't declare prototype.
5773
5774 * term.c (encode_terminal_code): Now external again, used by
5775 w32console.c and msdos.c.
5776
44f230aa
SM
5777 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5778 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5779
4b1ec863 57802011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5781
1714f52b 5782 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5783
4b1ec863
PE
5784 * fringe.c (update_window_fringes): Mark locals as initialized
5785 (Bug#8227).
5786 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5787
524c7aa6
PE
5788 * alloc.c (mark_fringe_data): Move decl from here ...
5789 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5790 to check its interface.
5791 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5792
a5c0af81 5793 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5794 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5795 (fontset_font): Mark local as initialized.
a9a06e0b 5796 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5797
b4716021
PE
5798 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5799
811e9bac 5800 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5801 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5802 (x_own_selection, Fx_disown_selection_internal): Rename locals
5803 to avoid shadowing.
5804 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5805
7e3ab302
PE
5806 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5807 so that the caller can use some name other than gcpro1.
5808 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5809 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5810 (Fx_backspace_delete_keys_p):
5811 Use them to avoid shadowing, and rename vars to avoid shadowing.
5812 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5813 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5814 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5815 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5816 Remove unused locals.
7e3ab302
PE
5817 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5818 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5819 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5820 macros.
f78faa98 5821
e2b13473
PE
5822 * xterm.h (x_mouse_leave): New decl.
5823
77f23912
PE
5824 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5825 Remove unused functions.
cdf4ba58
PE
5826 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5827 (x_calc_absolute_position): Now static.
7411c686 5828 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5829 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5830 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5831 unless they are used.
38d0b34a
PE
5832 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5833 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5834 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5835 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5836 (x_error_catcher, x_connection_closed, x_error_handler):
5837 (x_error_quitter, xembed_send_message, x_iconify_frame):
5838 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5839 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5840 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5841
44f230aa
SM
5842 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5843 Rename or move locals to avoid shadowing.
6b463e58 5844 (tty_defined_color, merge_face_heights): Now static.
5967d051 5845 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5846 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5847 does not deduce is never used uninitialized.
73719eba
PE
5848 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5849 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5850
426994c3 5851 * terminal.c (store_terminal_param): Now static.
5489860b 5852
032f1620 5853 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5854 (set_frame_menubar): Remove unused local.
d4323972 5855 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5856 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5857 since they might point to immutable storage.
281585b0
PE
5858 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5859 since it's unused otherwise.
032f1620 5860
367c19e5 5861 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5862 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5863 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5864 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5865 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5866 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5867 does not deduce are never used uninitialized.
70739cbe 5868
07b48fa9
PE
5869 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5870
8868a238 5871 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5872 * window.c (window_loop, size_window):
5873 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5874
7e5cf297 5875 * window.c (display_buffer): Now static.
d6550a9f
PE
5876 (size_window): Mark variables that gcc -Wuninitialized
5877 does not deduce are never used uninitialized.
a586633d
PE
5878 * window.h (check_all_windows): New decl, to forestall
5879 gcc -Wmissing-prototypes diagnostic.
5b555da1 5880 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5881
f6095868
PE
5882 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5883 shadowing.
5884 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5885 Include <limits.h>.
5886 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5887 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5888 (load_charset_map): Mark variables that gcc -Wuninitialized
5889 does not deduce are never used uninitialized.
53df7c11 5890 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5891
f38b440c
PE
5892 * coding.c (coding_set_source, coding_set_destination):
5893 Use "else { /* comment */ }" rather than "else /* comment */;"
5894 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5895 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5896 a block, when the outer 'i' will do.
5897 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5898 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5900 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5901 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5902 Rename locals to avoid shadowing.
5903 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5904 * coding.c (emacs_mule_char, encode_invocation_designation):
5905 Now static, since they're not used elsewhere.
413bb2db 5906 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5907 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5908 (decode_coding_emacs_mule): Mark variables that gcc
5909 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5910 (detect_coding_iso_2022): Initialize a local variable that might
5911 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5912 this initialization is needed. (Bug#8211)
5f58e762
PE
5913 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5914 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5915 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5916 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5917 Remove unused macros.
f38b440c 5918
232b38b9 5919 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5920 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5921 * character.c (string_count_byte8): Likewise.
232b38b9 5922
fb90da1b
PE
5923 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5924 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5925
fb93dbc2
PE
5926 * chartab.c (copy_sub_char_table): Now static, since it's not used
5927 elsewhere.
5c156ace
PE
5928 (sub_char_table_ref_and_range, char_table_ref_and_range):
5929 Rename locals to avoid shadowing.
bbcd0949 5930 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5931
7d3b3862 5932 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5933 (BIDI_BOB): Remove unused macro.
7d3b3862 5934
6be7d3da
PE
5935 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5936 deduce are never used uninitialized.
c2ed9c8b 5937 * term.c (encode_terminal_code): Likewise.
6be7d3da 5938
75f8807f 5939 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5940
50938595
PE
5941 * tparam.h: New file.
5942 * term.c, tparam.h: Include it.
5943 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5944 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5945 Move these decls to tparam.h, and make them agree with what
5946 is actually in tparam.c. The previous trick of using incompatible
5947 decls in different modules does not conform to the C standard.
5948 All callers of tparam changed to use tparam's actual API.
5949 * tparam.c (tparam1, tparam, tgoto):
5950 Use const pointers where appropriate.
5951
fbceeba2
PE
5952 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5953 * cm.h (struct cm): Likewise.
5954 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5955 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5956 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5957 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5958 (turn_on_face, init_tty): Likewise.
5959 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5960
7f3f1250
PE
5961 * term.c (term_mouse_position): Rename local to avoid shadowing.
5962
e6ca6543
PE
5963 * alloc.c (mark_ttys): Move decl from here ...
5964 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5965
c40f8d15
AS
59662011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5967
5968 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5969
cfe0661d
JB
59702011-03-09 Juanma Barranquero <lekktu@gmail.com>
5971
5972 * search.c (compile_pattern_1): Remove argument regp, unused since
5973 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5974 (compile_pattern): Don't pass it.
5975
0afb4571
J
59762011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5977
5978 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5979 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5980 for ! HAVE_GTK3.
5981 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5982
5983 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5984
5985 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5986 gdk_window_get_screen, gdk_window_get_geometry,
5987 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5988 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5989 (xg_get_pixbuf_from_pixmap): New function.
5990 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5991 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5992 Call xg_get_pixbuf_from_pixmap instead of
5993 gdk_pixbuf_get_from_drawable.
5994 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5995 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5996 (xg_check_special_colors): Use GtkStyleContext and its functions
5997 for HAVE_GTK3.
5998 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5999 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6000 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6001 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6002 Call gtk_widget_get_preferred_size.
0afb4571
J
6003 (xg_frame_resized): gdk_window_get_geometry only takes 5
6004 parameters.
44f230aa
SM
6005 (xg_win_to_widget, xg_event_is_for_menubar):
6006 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6007 (xg_set_widget_bg): New function.
6008 (delete_cb): New function.
895009e1 6009 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6010 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6011 (xg_set_background_color): Call xg_set_widget_bg.
6012 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6013 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6014 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6015 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6016 if ! HAVE_GTK3.
6017 (update_frame_tool_bar): Call gtk_widget_hide.
6018 (xg_initialize): Use GDK_KEY_g.
6019
6020 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6021 if ! HAVE_GTK3
6022 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6023
6024 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6025 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6026 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6027
1c2cc4ef
JB
60282011-03-08 Juanma Barranquero <lekktu@gmail.com>
6029
6030 * w32xfns.c (select_palette): Check success of RealizePalette against
6031 GDI_ERROR, not zero.
6032
33383987 6033See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6034
6035;; Local Variables:
6036;; coding: utf-8
aac0c6e3
MR
6037;; End:
6038
33383987 6039 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6040
6041 This file is part of GNU Emacs.
6042
6043 GNU Emacs is free software: you can redistribute it and/or modify
6044 it under the terms of the GNU General Public License as published by
6045 the Free Software Foundation, either version 3 of the License, or
6046 (at your option) any later version.
6047
6048 GNU Emacs is distributed in the hope that it will be useful,
6049 but WITHOUT ANY WARRANTY; without even the implied warranty of
6050 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6051 GNU General Public License for more details.
6052
6053 You should have received a copy of the GNU General Public License
6054 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.