1 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3 Integer signedness and overflow and related fixes. (Bug#9079)
5 * alloc.c (__malloc_size_t): Remove.
6 All uses replaced by size_t. See Andreas Schwab's note
7 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9 * image.c: Improve checking for integer overflow.
10 (check_image_size): Assume that f is nonnull, since
11 it is always nonnull in practice. This is one less thing to
12 worry about when checking for integer overflow later.
13 (x_check_image_size): New function, which checks for integer
14 overflow issues inside X.
15 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
16 This removes the need for a memory_full check.
17 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
18 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
19 (xbm_read_bitmap_data): Change locals back to 'int', since
20 their values must fit in 'int'.
21 (xpm_load_image, png_load, tiff_load):
22 Invoke x_create_x_image_and_pixmap earlier,
23 to avoid much needless work if the image is too large.
24 (tiff_load): Treat overly large images as if
25 x_create_x_image_and_pixmap failed, not as malloc failures.
26 (gs_load): Use x_check_image_size.
28 * gtkutil.c: Omit integer casts.
29 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
30 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
32 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
34 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
35 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
36 would wrongly return t on a 64-bit host.
38 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
39 The plain *_OVERFLOW macros run afoul of GCC bug 49705
40 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
41 and therefore cause GCC to emit a bogus diagnostic in some cases.
43 * image.c: Integer signedness and overflow and related fixes.
44 This is not an exhaustive set of fixes, but it's time to
46 (lookup_pixel_color, check_image_size): Remove redundant decls.
47 (check_image_size): Don't assume that arbitrary EMACS_INT values
48 fit in 'int', or that arbitrary 'double' values fit in 'int'.
49 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
50 (tiff_load, imagemagick_load_image):
51 Check for overflow in size calculations.
52 (x_create_x_image_and_pixmap): Remove unnecessary test for
53 xmalloc returning NULL; that can't happen.
54 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
55 (xpm_color_bucket): Use better integer hashing function.
56 (xpm_cache_color): Don't possibly over-allocate memory.
57 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
59 Use ptrdiff_t, not int or size_t, to record sizes.
60 (png_load): Don't assume values greater than 2**31 fit in 'int'.
61 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
62 either works, as we prefer signed integers.
63 (tiff_read_from_memory, tiff_write_from_memory):
64 Return tsize_t, not size_t, since that's what the TIFF API wants.
65 (tiff_read_from_memory): Don't fail simply because the read would
66 go past EOF; instead, return a short read.
67 (tiff_load): Omit no-longer-needed casts.
68 (Fimagemagick_types): Don't assume size fits into 'int'.
70 Improve hashing quality when configured --with-wide-int.
71 * fns.c (hash_string): New function, taken from sxhash_string.
72 Do not discard information about ASCII character case; this
73 discarding is no longer needed.
74 (sxhash-string): Use it. Change sig to match it. Caller changed.
76 * lread.c (hash_string): Remove, since we now use fns.c's version.
77 The fns.c version returns a wider integer if --with-wide-int is
78 specified, so this should help the quality of the hashing a bit.
80 * emacs.c: Integer overflow minor fix.
81 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
82 Define only if GNU_LINUX.
83 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
85 * dispnew.c: Integer signedness and overflow fixes.
86 Remove unnecessary forward decls, that were a maintenance hassle.
87 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
89 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
90 (scrolling_window): Use ptrdiff_t, not int, for byte count.
91 (prepare_desired_row, line_draw_cost):
92 Use int, not unsigned, where either works.
93 (save_current_matrix, restore_current_matrix):
94 Use ptrdiff_t, not size_t, where either works.
95 (init_display): Check for overflow more accurately, and without
96 relying on undefined behavior.
98 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
99 Remove, replacing with the new symbols in lisp.h. All uses changed.
100 * fileio.c (make_temp_name):
101 * filelock.c (lock_file_1, lock_file):
102 * xdisp.c (message_dolog):
103 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
104 Use pMd etc. instead.
105 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
106 replacing the pWIDE etc. symbols removed from editfns.c.
108 * keyboard.h (num_input_events): Now uintmax_t.
109 This is (very slightly) less likely to mess up due to wraparound.
112 * buffer.c: Integer signedness fixes.
113 (alloc_buffer_text, enlarge_buffer_text):
114 Use ptrdiff_t rather than size_t when either will do, as we prefer
117 * alloc.c: Integer signedness and overflow fixes.
118 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
119 (__malloc_size_t): Default to size_t, not to int.
120 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
121 (Fgarbage_collect, mark_object_loop_halt, mark_object):
122 Prefer ptrdiff_t to size_t when either would do, as we prefer
124 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
125 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
126 Now const. Initialize with values that are in range even if char
128 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
129 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
130 These functions do the right thing with sizes > 2**32.
131 (check_depth): Now ptrdiff_t, not int.
132 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
133 Adjust to new way of storing sizes. Check for size overflow bugs
135 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
136 slightly wrong anyway, as it missed one instance of
137 XMALLOC_OVERRUN_CHECK_OVERHEAD.
138 (refill_memory_reserve): Omit needless cast to size_t.
139 (mark_object_loop_halt): Mark as externally visible.
141 * xselect.c: Integer signedness and overflow fixes.
142 (Fx_register_dnd_atom, x_handle_dnd_message):
143 Use ptrdiff_t, not size_t, since we prefer signed.
144 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
145 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
146 x_dnd_atoms_size and x_dnd_atoms_length.
148 * doprnt.c: Prefer signed to unsigned when either works.
152 * xdisp.c (vmessage):
153 Use ptrdiff_t, not size_t, when using or implementing doprnt,
154 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
155 prefer signed arithmetic to avoid comparison confusion.
156 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
159 Assume freestanding C89 headers, string.h, stdlib.h.
160 * data.c, doprnt.c, floatfns.c, print.c:
161 Include float.h unconditionally.
162 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
163 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
164 * regex.c: Likewise for stddef.h, string.h.
165 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
166 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
167 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
168 (STDC_HEADERS): Remove obsolete defines.
169 * sysdep.c: Include limits.h unconditionally.
171 Assume support for memcmp, memcpy, memmove, memset.
172 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
173 * regex.c (memcmp, memcpy):
174 Remove; we assume C89 now.
176 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
177 (__malloc_safe_bcopy): Remove; no longer needed.
179 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
180 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
181 well either way, and we prefer signed to unsigned.
183 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
185 Fix minor problems found by static checking.
186 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
187 (elsz): Now a signed constant, not a size_t var. We prefer signed
188 types to unsigned, to avoid integer comparison confusion. Without
189 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
190 "cannot optimize loop, the loop counter may overflow", a symptom
192 * indent.c (Fvertical_motion): Mark locals as initialized.
193 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
195 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
197 * data.c (Fcdr, Fcar): Revert the last change, since it didn't
200 * search.c (Fre_search_backward): Mention `case-fold-search' in
201 all the re_search_* functions (bug#8138).
203 * keyboard.c (Fopen_dribble_file): Document when the file is
206 2011-07-14 Eli Zaretskii <eliz@gnu.org>
208 * bidi.c (bidi_dump_cached_states): Fix format of displaying
211 Support bidi reordering of display and overlay strings.
212 * xdisp.c (compute_display_string_pos)
213 (compute_display_string_end): Accept additional argument STRING.
214 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
215 (reseat_to_string): Initialize bidi_it->string.s and
216 bidi_it->string.schars.
217 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
218 NULL (avoids a crash in bidi_paragraph_init). Initialize
220 (init_iterator): Call bidi_init_it only of a valid
221 buffer position was specified. Initialize paragraph_embedding to
223 (reseat_to_string): Initialize the bidi iterator.
224 (display_string): If we need to ignore text properties of
225 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
226 original value of -1 will not work with bidi.)
227 (compute_display_string_pos): First arg is now struct
228 `text_pos *'; all callers changed. Support display properties on
230 (compute_display_string_end): Support display properties on Lisp
232 (init_iterator, reseat_1, reseat_to_string): Initialize the
233 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
234 when iterating on a string not from display properties).
235 (compute_display_string_pos, compute_display_string_end): Fix
236 calculation of the object to scan. Fixes an error when using
238 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
239 base_level_stop; instead, set base_level_stop to BEGV. Fixes
240 crashes in vertical-motion.
241 (next_element_from_buffer): Improve commentary for when
242 the iterator is before prev_stop.
243 (init_iterator): Initialize bidi_p from the default value of
244 bidi-display-reordering, not from buffer-local value. Use the
245 buffer-local value only if initializing for buffer iteration.
246 (handle_invisible_prop): Support invisible properties on strings
247 that are being bidi-reordered.
248 (set_iterator_to_next): Support bidi reordering of C strings and
250 (next_element_from_string): Support bidi reordering of Lisp
252 (handle_stop_backwards): Support Lisp strings as well.
253 (display_string): Support display of R2L glyph rows. Use
254 IT_STRING_CHARPOS when displaying from a Lisp string.
255 (init_iterator): Don't initialize it->bidi_p for strings
257 (reseat_to_string): Initialize it->bidi_p for strings here.
258 (next_element_from_string, next_element_from_c_string)
259 (next_element_from_buffer): Add xassert's for correspondence
260 between IT's object being iterated and it->bidi_it.string
262 (face_before_or_after_it_pos): Support bidi iteration.
263 (next_element_from_c_string): Handle the case of the first string
264 character that is not the first one in the visual order.
265 (get_visually_first_element): New function, refactored from common
266 parts of next_element_from_buffer, next_element_from_string, and
267 next_element_from_c_string.
268 (tool_bar_lines_needed, redisplay_tool_bar)
269 (display_menu_bar): Force left-to-right direction. Add a FIXME
270 comment for making that be controlled by a user option.
271 (push_it, pop_it): Save and restore the state of the
272 bidi iterator. Save and restore the bidi_p flag.
273 (pop_it): Iterate out of display property for string iteration as
275 (iterate_out_of_display_property): Support iteration over strings.
276 (handle_single_display_spec): Set up it->bidi_it for iteration
277 over a display string, and call bidi_init_it.
278 (handle_single_display_spec, next_overlay_string)
279 (get_overlay_strings_1, push_display_prop): Set up the bidi
280 iterator for displaying display or overlay strings.
281 (forward_to_next_line_start): Don't use the shortcut if
283 (back_to_previous_visible_line_start): If handle_display_prop
284 pushed the iterator stack, restore the internal state of the bidi
285 iterator by calling bidi_pop_it same number of times.
286 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
287 and we are bidi-iterating, don't decrement the iterator position;
288 instead, set the first_elt flag in the bidi iterator, to produce
290 (reseat_1): Remove redundant setting of string_from_display_prop_p.
291 (push_display_prop): xassert that we are iterating a buffer.
292 (push_it, pop_it): Save and restore paragraph_embedding member.
293 (handle_single_display_spec, next_overlay_string)
294 (get_overlay_strings_1, reseat_1, reseat_to_string)
295 (push_display_prop): Set up the `unibyte' member of bidi_it.string
296 correctly. Don't assume unibyte strings are not bidi-reordered.
297 (compute_display_string_pos)
298 (compute_display_string_end): Fix handling the case of C string.
299 (push_it, pop_it): Save and restore from_disp_prop_p.
300 (handle_single_display_spec, push_display_prop): Set the
301 from_disp_prop_p flag.
302 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
303 (pop_it): Call iterate_out_of_display_property only if we are
304 popping after iteration over a string that came from a display
305 property. Fix a typo in popping stretch info. Add an assertion
306 for verifying that the iterator position is in sync with the bidi
308 (handle_single_display_spec, get_overlay_strings_1)
309 (push_display_prop): Fix initialization of paragraph direction for
310 string when that of the parent object is not yet determined.
311 (reseat_1): Call bidi_init_it to resync the bidi
312 iterator with IT's position. (Bug#7616)
313 (find_row_edges): If ROW->start.pos gives position
314 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
315 (handle_stop, back_to_previous_visible_line_start, reseat_1):
316 Reset the from_disp_prop_p flag.
317 (SAVE_IT, RESTORE_IT): New macros.
318 (pos_visible_p, face_before_or_after_it_pos)
319 (back_to_previous_visible_line_start)
320 (move_it_in_display_line_to, move_it_in_display_line)
321 (move_it_to, move_it_vertically_backward, move_it_by_lines)
322 (try_scrolling, redisplay_window, display_line): Use them when
323 saving a temporary copy of the iterator and restoring it back.
324 (back_to_previous_visible_line_start, reseat_1)
325 (init_iterator): Empty the bidi cache "stack".
326 (move_it_in_display_line_to): If iterator ended up at
327 EOL, but we never saw any buffer positions smaller than
328 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
329 motion in bidi-reordered lines.
330 (move_it_in_display_line_to): Record prev_method and prev_pos
331 immediately before the call to set_iterator_to_next. Fixes cursor
332 motion in bidi-reordered lines with stretch glyphs and strings
333 displayed in margins. (Bug#8133) (Bug#8867)
334 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
336 (pos_visible_p): Support positions in bidi-reordered lines. Save
337 and restore bidi cache.
339 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
340 (bidi_paragraph_info): Delete unused struct.
341 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
342 (bidi_cache_start): New variable.
343 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
345 (bidi_cache_fetch_state, bidi_cache_search)
346 (bidi_cache_find_level_change, bidi_cache_iterator_state)
347 (bidi_cache_find, bidi_peek_at_next_level)
348 (bidi_level_of_next_char, bidi_find_other_level_edge)
349 (bidi_move_to_visually_next): Compare cache index with
350 bidi_cache_start rather than with zero.
351 (bidi_fetch_char): Accept new argument STRING; all callers
352 changed. Support iteration over a string. Support strings with
353 display properties. Support unibyte strings. Fix the type of
354 `len' according to what STRING_CHAR_AND_LENGTH expects.
355 (bidi_paragraph_init, bidi_resolve_explicit_1)
356 (bidi_resolve_explicit, bidi_resolve_weak)
357 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
358 iteration over a string.
359 (bidi_set_sor_type, bidi_resolve_explicit_1)
360 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
361 can now be zero (for strings); special values 0 and -1 were
362 changed to -1 and -2, respectively.
363 (bidi_char_at_pos): New function.
364 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
365 Call it instead of FETCH_MULTIBYTE_CHAR.
366 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
367 initialized to valid values.
368 (bidi_init_it): Don't initialize charpos and bytepos with invalid
370 (bidi_level_of_next_char): Allow the sentinel "position" to pass
371 the test for valid cached positions. Fix the logic for looking up
372 the sentinel state in the cache. GCPRO the Lisp string we are
374 (bidi_push_it, bidi_pop_it): New functions.
375 (bidi_initialize): Initialize the bidi cache start stack pointer.
376 (bidi_cache_ensure_space): New function, refactored from part of
377 bidi_cache_iterator_state. Don't assume the required size is just
378 one BIDI_CACHE_CHUNK away.
379 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
380 (bidi_count_bytes, bidi_char_at_pos): New functions.
381 (bidi_cache_search): Don't assume bidi_cache_last_idx is
382 always valid if bidi_cache_idx is valid.
383 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
384 is valid if it's going to be used.
385 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
386 (bidi_cache_fetch_state, bidi_cache_search)
387 (bidi_cache_find_level_change, bidi_cache_ensure_space)
388 (bidi_cache_iterator_state, bidi_cache_find)
389 (bidi_find_other_level_edge, bidi_cache_start_stack): All
390 variables related to cache indices are now EMACS_INT.
392 * dispextern.h (struct bidi_string_data): New structure.
393 (struct bidi_it): New member `string'. Make flag members be 1-bit
394 fields, and put them last in the struct.
395 (compute_display_string_pos, compute_display_string_end): Update
397 (bidi_push_it, bidi_pop_it): Add prototypes.
398 (struct iterator_stack_entry): New members bidi_p,
399 paragraph_embedding, and from_disp_prop_p.
400 (struct it): Member bidi_p is now a bit field 1 bit wide.
401 (bidi_shelve_cache, bidi_unshelve_cache): Declare
404 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
405 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
406 and vector-like objects.
408 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
409 cache around display iteration.
411 * window.c (Fwindow_end, window_scroll_pixel_based)
412 (displayed_window_lines, Frecenter): Save and restore the bidi
413 cache around display iteration.
415 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
417 * editfns.c (Fdelete_region): Clarify the use of the named
418 parameters (bug#6788).
420 2011-07-14 Martin Rudalics <rudalics@gmx.at>
422 * indent.c (Fvertical_motion): Set and restore w->pointm when
423 saving and restoring the window's buffer (Bug#9006).
425 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
427 * editfns.c (Fstring_to_char): Clarify just what is returned
428 (bug#6576). Text by Eli Zaretskii.
430 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
432 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
434 2011-07-13 Eli Zaretskii <eliz@gnu.org>
436 * buffer.c (mmap_find): Fix a typo.
438 2011-07-13 Johan Bockgård <bojohan@gnu.org>
440 Fix execution of x selection hooks.
441 * xselect.c (Qx_lost_selection_functions)
442 (Qx_sent_selection_functions): New vars.
443 (syms_of_xselect): DEFSYM them.
444 (x_handle_selection_request): Pass Qx_sent_selection_functions
445 rather than Vx_sent_selection_functions to Frun_hook_with_args.
446 (x_handle_selection_clear,x_clear_frame_selections):
447 Pass Qx_lost_selection_functions rather than
448 Vx_lost_selection_functions to Frun_hook_with_args.
450 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
452 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
453 The old code sometimes used this field without initializing it.
455 * alloc.c (gc_sweep): Don't read past end of array.
456 In theory, the old code could also have corrupted Emacs internals,
457 though it'd be very unlikely.
459 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
461 * character.c (Fcharacterp): Don't advertise optional ignored
464 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
466 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
469 * window.c (Fset_window_start): Doc fix (bug#4199).
470 (Fset_window_hscroll): Ditto.
472 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
474 Fix minor new problems caught by GCC 4.6.1.
475 * term.c (init_tty): Remove unused local.
476 * xsettings.c (store_monospaced_changed): Define this function only
477 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
480 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
482 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
484 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
486 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
487 are the mini-buffer and the echo area (bug#3320).
489 * term.c (init_tty): Remove support for supdup, c10 and perq
490 terminals, which are no longer supported (bug#1482).
492 2011-07-10 Johan Bockgård <bojohan@gnu.org>
494 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
496 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
498 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
499 for non-popups (Bug#3642).
501 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
503 * alloc.c (reset_malloc_hooks): Protoize.
504 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
505 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
506 * cm.c (losecursor): Likewise.
507 * data.c (fmod): Likewise.
508 * dispnew.c (swap_glyphs_in_rows): Likewise.
509 * emacs.c (memory_warning_signal): Likewise.
510 * floatfns.c (float_error): Likewise.
511 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
512 (otf_open, font_otf_capability, generate_otf_features)
513 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
515 * image.c (pbm_read_file): Likewise.
516 * indent.c (string_display_width): Likewise.
517 * intervals.c (check_for_interval, search_for_interval)
518 (inc_interval_count, count_intervals, root_interval)
519 (adjust_intervals_for_insertion, make_new_interval): Likewise.
520 * lread.c (defalias): Likewise.
521 * ralloc.c (r_alloc_check): Likewise.
522 * regex.c (set_image_of_range_1, set_image_of_range)
523 (regex_grow_registers): Likewise.
524 * sysdep.c (strerror): Likewise.
525 * termcap.c (valid_filename_p, tprint, main): Likewise.
526 * tparam.c (main): Likewise.
527 * unexhp9k800.c (run_time_remap, save_data_space)
528 (update_file_ptrs, read_header, write_header, calculate_checksum)
529 (copy_file, copy_rest, display_header): Likewise.
530 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
532 * xdisp.c (check_it): Likewise.
533 * xfaces.c (register_color, unregister_color, unregister_colors):
535 * xfns.c (print_fontset_result): Likewise.
536 * xrdb.c (member, fatal, main): Likewise.
538 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
540 Fix minor problems found by static checking (Bug#9031).
541 * chartab.c (char_table_set_range, map_sub_char_table):
542 Remove unused locals.
543 (uniprop_table): Now static.
544 * composite.c (_work_char): Remove unused static var.
546 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
548 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
550 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
552 * gtkutil.c (qttip_cb): Remove code without function.
554 2011-07-09 Eli Zaretskii <eliz@gnu.org>
556 * w32.c (pthread_sigmask): New stub.
558 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
560 Use pthread_sigmask, not sigprocmask (Bug#9010).
561 sigprocmask is portable only for single-threaded applications, and
562 Emacs can be multi-threaded when it uses GTK.
563 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
565 * callproc.c (Fcall_process):
566 * process.c (create_process):
567 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
568 Use pthread_sigmask, not sigprocmask.
570 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
572 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
573 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
576 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
578 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
579 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
580 (xg_hide_tooltip): Fix comment.
582 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
583 in registerServicesMenuSendTypes.
584 (validRequestorForSendType): Don't check ns_return_types.
586 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
589 2011-07-08 Jason Rumney <jasonr@gnu.org>
591 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
592 frame struct members of non-existent frames (Bug#6284).
594 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
596 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
597 variable firstTime not needed on OSX >= 10.6.
598 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
599 >= 10.5. Use setKnobProportion, setDoubleValue.
601 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
602 (MAC_OS_X_VERSION_10_5): Define if not defined.
603 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
604 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
605 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
607 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
608 cString and lossyCString on OSX >= 10.4
610 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
611 sizeToFit on OSX >= 10.2.
613 * nsimage.m (allocInitFromFile): Don't use deprecated method
614 bestRepresentationForDevice on OSX >= 10.6.
616 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
619 * emacs.c: Declare unexec_init_emacs_zone.
621 * nsgui.h: Fix compiler warning about gnulib redefining verify.
623 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
625 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
626 on svcsMenu (Bug#8842).
628 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
630 (Fns_list_services): Just return Qnil on 10.6, code not working there.
632 * nsterm.m (QUTF8_STRING): Declare.
633 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
634 (validRequestorForSendType): Return type is (id).
635 Change indexOfObjectIdenticalTo to indexOfObject.
636 Check if we have local selection before returning self (Bug#8842).
637 (writeSelectionToPasteboard): Put local selection into paste board
638 if we have a local selection (Bug#8842).
639 (syms_of_nsterm): DEFSYM QUTF8_STRING.
641 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
642 (ns_get_local_selection): Declare.
644 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
646 * keymap.c (describe_map_tree): Don't insert a double newline at
647 the end of the buffer (bug#1169) and return whether we inserted
650 * callint.c (Fcall_interactively): Change "reading args" to
651 "providing args" to try to clarify what it does (bug#1010).
653 2011-07-07 Kenichi Handa <handa@m17n.org>
655 * composite.c (composition_compute_stop_pos): Ignore a static
656 composition starting before CHARPOS (Bug#8915).
658 * xdisp.c (handle_composition_prop): Likewise.
660 2011-07-07 Eli Zaretskii <eliz@gnu.org>
662 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
665 2011-07-07 Kenichi Handa <handa@m17n.org>
667 * character.h (unicode_category_t): New enum type.
669 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
670 (Qchar_code_property_table): New variable.
671 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
672 (UNIPROP_COMPRESSED_FORM_P): New macros.
673 (char_table_ascii): Uncompress the compressed values.
674 (sub_char_table_ref): New arg is_uniprop. Callers changed.
675 Uncompress the compressed values.
676 (sub_char_table_ref_and_range): Likewise.
677 (char_table_ref_and_range): Uncompress the compressed values.
678 (sub_char_table_set): New arg is_uniprop. Callers changed.
679 Uncompress the compressed values.
680 (sub_char_table_set_range): Args changed. Callers changed.
681 (char_table_set_range): Adjuted for the above change.
682 (map_sub_char_table): Delete args default_val and parent. Add arg
683 top. Give decoded values to a Lisp function.
684 (map_char_table): Adjusted for the above change. Give decoded
685 values to a Lisp function. Gcpro more variables.
686 (uniprop_table_uncompress)
687 (uniprop_decode_value_run_length): New functions.
688 (uniprop_decoder, uniprop_decoder_count): New variables.
689 (uniprop_get_decoder, uniprop_encode_value_character)
690 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
692 (uniprop_encoder, uniprop_encoder_count): New variables.
693 (uniprop_get_encoder, uniprop_table)
694 (Funicode_property_table_internal, Fget_unicode_property_internal)
695 (Fput_unicode_property_internal): New functions.
696 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
697 Sunicode_property_table_internal, Sget_unicode_property_internal,
698 and Sput_unicode_property_internal. Defvar_lisp
699 char-code-property-alist.
701 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
702 Vunicode_category_table.
704 * font.c (font_range): Adjusted for the change of
705 Vunicode_category_table.
707 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
709 * m/iris4d.h: Remove file, move contents ...
710 * s/irix6-5.h: ... here.
712 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
714 Remove unportable assumption about struct layout (Bug#8884).
715 * alloc.c (mark_buffer):
716 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
717 (clone_per_buffer_values): Don't assume that
718 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
719 This isn't true in general, and it's particularly not true
720 if Emacs is configured with --with-wide-int.
721 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
722 New macros, used in the buffer.c change.
724 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
726 * xsettings.c: Use both GConf and GSettings if both are available.
727 (store_config_changed_event): Add comment.
728 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
729 (store_tool_bar_style_changed): New functions.
730 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
731 (struct xsettings): Move font inside HAVE_XFT.
732 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
733 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
734 Move inside HAVE_XFT.
735 (something_changed_gsettingsCB): Renamed from something_changedCB.
736 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
738 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
739 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
740 (something_changed_gconfCB): Renamed from something_changedCB.
741 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
742 (parse_settings): Move check for font inside HAVE_XFT.
743 (read_settings, apply_xft_settings): Add comment.
744 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
745 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
746 call store_font_name_changed.
747 (xft_settings_event): Add comment.
748 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
749 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
750 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
751 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
752 (xsettings_initialize): Call init_gsettings last.
753 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
756 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
758 Random fixes. E.g., (random) never returned negative values.
759 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
760 subseconds part to the entropy, as that's a bit more random.
761 Prefer signed to unsigned, since the signedness doesn't matter and
762 in general we prefer signed. When given a limit, use a
763 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
764 latter isn't right if USE_2_TAGS_FOR_INTS.
765 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
766 not 0..VALMASK. Don't discard "excess" bits that random () returns.
768 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
770 * textprop.c (text_property_stickiness):
771 Obey Vtext_property_default_nonsticky.
772 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
773 * w32fns.c (syms_of_w32fns):
774 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
776 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
778 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
779 This is more efficient than Ffile_directory_p and avoids a minor race.
781 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
783 * buffer.c (Foverlay_put): Say what the return value is
786 * fileio.c (barf_or_query_if_file_exists): Check first if the file
787 is a directory before asking whether to use the file name
789 (barf_or_query_if_file_exists): Make the "File is a directory"
790 error be more correct.
792 * fns.c (Frequire): Remove the mention of the .gz files, since
793 that's installation-specific, but keep the mention of
796 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
798 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
799 Report string overflow if the output is too long.
801 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
803 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
804 (syms_of_gnutls): Remove duplicate DEFSYM for
805 Qgnutls_bootprop_verify_hostname_error, an error for
806 Qgnutls_bootprop_verify_error (which is no longer used).
808 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
809 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
810 Also (re)move comments that are misplaced or no longer relevant.
812 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
814 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
816 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
818 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
819 and background color parameters if they have been changed.
821 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
823 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
825 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
827 * xsettings.c (SYSTEM_FONT): Define only when used.
828 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
830 * keymap.c (access_keymap_1): Now static.
832 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
834 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
835 leave any prefix arg for the up event (Bug#1586).
837 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
839 * lread.c (syms_of_lread): Mention single symbols defined by
840 `defvar' or `defconst' (bug#7154).
842 * fns.c (Frequire): Mention .el.gz files (bug#7314).
843 (Frequire): Mention get-load-suffixes.
845 2011-07-02 Martin Rudalics <rudalics@gmx.at>
847 * window.h (window): Remove clone_number slot.
848 * window.c (Fwindow_clone_number, Fset_window_clone_number):
850 (make_parent_window, make_window, saved_window)
851 (Fset_window_configuration, save_window_save): Don't deal with
853 * buffer.c (Qclone_number): Remove declaration.
854 (sort_overlays, overlay_strings): Don't deal with clone numbers.
856 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
858 Add multiple inheritance to keymaps.
859 * keymap.c (Fmake_composed_keymap): New function.
860 (Fset_keymap_parent): Simplify.
861 (fix_submap_inheritance): Remove.
862 (access_keymap_1): New function extracted from access_keymap to handle
863 embedded parents and handle lists of maps.
864 (access_keymap): Use it.
865 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
866 (Fcopy_keymap): Handle embedded parents.
867 (Fcommand_remapping, define_as_prefix): Simplify.
868 (Fkey_binding): Simplify.
869 (syms_of_keymap): Move minibuffer-local-completion-map,
870 minibuffer-local-filename-completion-map,
871 minibuffer-local-must-match-map, and
872 minibuffer-local-filename-must-match-map to Elisp.
873 (syms_of_keymap): Defsubr make-composed-keymap.
874 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
875 (parse_menu_item): Trivial simplification.
877 2011-07-01 Glenn Morris <rgm@gnu.org>
879 * Makefile.in (SETTINGS_LIBS): Fix typo.
881 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
883 * coding.c (Fencode_coding_string): Record the last coding system
884 used, as the function doc string says (bug#8738).
886 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
888 * xsettings.c (store_monospaced_changed): Take new font as arg and
889 check for change against current_mono_font.
890 (EMACS_TYPE_SETTINGS): Remove this and related defines.
891 (emacs_settings_constructor, emacs_settings_get_property)
892 (emacs_settings_set_property, emacs_settings_class_init)
893 (emacs_settings_init, gsettings_obj): Remove.
894 (something_changedCB): New function for HAVE_GSETTINGS.
895 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
896 with value as argument.
897 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
898 g_settings_new (Bug#8967). Do not create gsettings_obj.
899 Remove calls to g_settings_bind. Connect something_changedCB to
902 * xgselect.c: Add defined (HAVE_GSETTINGS).
903 (xgselect_initialize): Ditto.
905 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
906 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
909 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
911 * eval.c (struct backtrace): Simplify and port the data structure.
912 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
913 signed bit field, as this assumption is not portable and it makes
914 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
915 "char debug_on_exit : 1" as this is not portable either; instead,
916 use the portable "unsigned int debug_on_exit : 1". Remove unused
917 member evalargs. Remove obsolete comments about cc bombing out.
919 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
921 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
922 Let HAVE_GSETTINGS override HAVE_GCONF.
923 (store_monospaced_changed): New function.
924 (EMACS_SETTINGS): A new type derived from GObject to handle
925 GSettings notifications.
926 (emacs_settings_constructor, emacs_settings_get_property)
927 (emacs_settings_set_property, emacs_settings_class_init):
929 (gsettings_client, gsettings_obj): New variables.
930 (GSETTINGS_SCHEMA): New define.
931 (something_changedCB): Call store_monospaced_changed.
932 (init_gsettings): New function.
933 (xsettings_initialize): Call init_gsettings.
934 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
937 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
940 2011-06-29 Martin Rudalics <rudalics@gmx.at>
942 * window.c (resize_root_window, grow_mini_window)
943 (shrink_mini_window): Rename Qresize_root_window to
944 Qwindow_resize_root_window and Qresize_root_window_vertically to
945 Qwindow_resize_root_window_vertically.
947 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
949 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
951 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
953 * makefile.w32-in: Redesign dependencies so they reflect more
954 clearly which files are directly included by each source file,
955 and not through other includes.
957 2011-06-27 Martin Rudalics <rudalics@gmx.at>
959 * buffer.c (Qclone_number): Declare static and DEFSYM it.
960 (sort_overlays, overlay_strings): When an overlay's clone number
961 matches the window's clone number process the overlay even if
962 the overlay's window property doesn't match the current window.
964 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
965 (Fwindow_hchild): Rename to Fwindow_left_child.
966 (Fwindow_next): Rename to Fwindow_next_sibling.
967 (Fwindow_prev): Rename to Fwindow_prev_sibling.
968 (resize_window_check): Rename to window_resize_check.
969 (resize_window_apply): Rename to window_resize_apply.
970 (Fresize_window_apply): Rename to Fwindow_resize_apply.
971 (Fdelete_other_windows_internal, resize_frame_windows)
972 (Fsplit_window_internal, Fdelete_window_internal)
973 (grow_mini_window, shrink_mini_window)
974 (Fresize_mini_window_internal): Fix callers accordingly.
976 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
978 * emacsgtkfixed.h: State that this is only used with Gtk+3.
979 (emacs_fixed_set_min_size): Remove.
980 (emacs_fixed_new): Take frame as argument.
982 * emacsgtkfixed.c: State that this is only used with Gtk+3.
983 (_EmacsFixedPrivate): Remove minwidth/height.
985 (emacs_fixed_init): Initialize priv->f.
986 (get_parent_class, emacs_fixed_set_min_size): Remove.
987 (emacs_fixed_new): Set priv->f to argument.
988 (emacs_fixed_get_preferred_width)
989 (emacs_fixed_get_preferred_height): Use min_width/height from
990 frames size_hint to set minimum and natural (Bug#8919).
991 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
992 and use min_width/height from frames size_hint to set
993 min_width/height (Bug#8919).
995 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
996 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
999 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1001 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1002 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1005 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1007 * process.c (wait_reading_process_output): Bypass select if
1008 waiting for a cell while ignoring keyboard input, and input is
1009 pending. Suggested by Jan Djärv (Bug#8869).
1011 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1013 Use gnulib's dup2 module instead of rolling our own.
1014 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1016 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1018 * dispnew.c (scrolling_window): Before scrolling, turn off a
1019 mouse-highlight in the window being scrolled.
1021 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1023 Move DEFSYM to lisp.h and use everywhere.
1025 * character.h (DEFSYM): Move declaration...
1026 * lisp.h (DEFSYM): ...here.
1032 * w32select.c: Don't include character.h.
1034 * alloc.c (syms_of_alloc):
1035 * buffer.c (syms_of_buffer):
1036 * bytecode.c (syms_of_bytecode):
1037 * callint.c (syms_of_callint):
1038 * casefiddle.c (syms_of_casefiddle):
1039 * casetab.c (init_casetab_once):
1040 * category.c (init_category_once, syms_of_category):
1041 * ccl.c (syms_of_ccl):
1042 * cmds.c (syms_of_cmds):
1043 * composite.c (syms_of_composite):
1044 * dbusbind.c (syms_of_dbusbind):
1045 * dired.c (syms_of_dired):
1046 * dispnew.c (syms_of_display):
1047 * doc.c (syms_of_doc):
1048 * editfns.c (syms_of_editfns):
1049 * emacs.c (syms_of_emacs):
1050 * eval.c (syms_of_eval):
1051 * fileio.c (syms_of_fileio):
1052 * fns.c (syms_of_fns):
1053 * frame.c (syms_of_frame):
1054 * fringe.c (syms_of_fringe):
1055 * insdel.c (syms_of_insdel):
1056 * keymap.c (syms_of_keymap):
1057 * lread.c (init_obarray, syms_of_lread):
1058 * macros.c (syms_of_macros):
1059 * msdos.c (syms_of_msdos):
1060 * print.c (syms_of_print):
1061 * process.c (syms_of_process):
1062 * search.c (syms_of_search):
1063 * sound.c (syms_of_sound):
1064 * syntax.c (init_syntax_once, syms_of_syntax):
1065 * terminal.c (syms_of_terminal):
1066 * textprop.c (syms_of_textprop):
1067 * undo.c (syms_of_undo):
1068 * w32.c (globals_of_w32):
1069 * window.c (syms_of_window):
1070 * xdisp.c (syms_of_xdisp):
1071 * xfaces.c (syms_of_xfaces):
1072 * xfns.c (syms_of_xfns):
1073 * xmenu.c (syms_of_xmenu):
1074 * xsettings.c (syms_of_xsettings):
1075 * xterm.c (syms_of_xterm): Use DEFSYM.
1077 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1079 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1081 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1083 Integer and buffer overflow fixes (Bug#8873).
1085 * print.c (printchar, strout): Check for string overflow.
1086 (PRINTPREPARE, printchar, strout):
1087 Don't set size unless allocation succeeds.
1089 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1090 for sizes. Check for string overflow more accurately.
1091 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1093 * macros.c: Integer and buffer overflow fixes.
1094 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1095 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1096 Use ptrdiff_t, not int, for sizes.
1097 Don't increment bufsize until after realloc succeeds.
1098 Check for size-calculation overflow.
1099 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1101 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1103 * lread.c: Integer overflow fixes.
1104 (read_integer): Radix is now EMACS_INT, not int,
1105 to improve quality of diagnostics for out-of-range radices.
1106 Calculate buffer size correctly for out-of-range radices.
1107 (read1): Check for integer overflow in radices, and in
1108 read-circle numbers.
1109 (read_escape): Avoid int overflow.
1110 (Fload, openp, read_buffer_size, read1)
1111 (substitute_object_recurse, read_vector, read_list, map_obarray):
1112 Use ptrdiff_t, not int, for sizes.
1113 (read1): Use EMACS_INT, not int, for sizes.
1114 Check for size overflow.
1116 * image.c (cache_image): Check for size arithmetic overflow.
1118 * lread.c: Integer overflow issues.
1119 (saved_doc_string_size, saved_doc_string_length)
1120 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1121 Now ptrdiff_t, not int.
1122 (read1): Don't assume doc string length fits in int. Check for
1123 out-of-range doc string lengths.
1124 (read_list): Don't assume file position fits in int.
1125 (read_escape): Check for hex character overflow.
1127 2011-06-22 Leo Liu <sdl.web@gmail.com>
1129 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1130 Move to minibuffer.el.
1132 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1134 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1135 The following patches are for when GLYPH_DEBUG && !XASSERT.
1136 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1137 * dispnew.c (flush_stdout):
1138 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1139 Mark as externally visible.
1140 * dispnew.c (check_window_matrix_pointers): Now static.
1141 * dispnew.c (window_to_frame_vpos):
1142 * xfns.c (unwind_create_frame):
1143 * xterm.c (x_check_font): Remove unused local.
1144 * scroll.c (CHECK_BOUNDS):
1145 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1146 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1147 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1148 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1149 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1151 (debug_method_add): Use va_list and vsprintf rather than relying
1152 on undefined behavior with wrong number of arguments.
1153 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1154 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1155 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1156 since we're not interested in debugging glyphs with old libraries.
1157 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1158 GCC 4.6.0's static checking.
1160 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1162 Integer overflow and signedness fixes (Bug#8873).
1163 A few related buffer overrun fixes, too.
1165 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1167 * dispextern.h (struct face.stipple):
1168 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1169 (x_bitmap_mask, x_allocate_bitmap_record)
1170 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1171 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1172 (x_create_bitmap_from_xpm_data):
1173 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1174 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1176 * xfaces.c (load_pixmap):
1177 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1178 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1179 (.bitmaps_last, struct x_output.icon_bitmap):
1180 Use ptrdiff_t, not int, for bitmap indexes.
1181 (x_allocate_bitmap_record): Check for size overflow.
1182 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1184 Use ptrdiff_t, not int, for overlay counts.
1185 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1186 * editfns.c (overlays_around, get_pos_property):
1187 * textprop.c (get_char_property_and_overlay):
1188 * xdisp.c (next_overlay_change, note_mouse_highlight):
1189 * xfaces.c (face_at_buffer_position):
1190 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1191 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1192 (Fnext_overlay_change, Fprevious_overlay_change)
1193 (mouse_face_overlay_overlaps, Foverlays_in):
1194 Use ptrdiff_t, not int, for sizes.
1195 (overlays_at, overlays_in): Check for size-calculation overflow.
1197 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1199 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1200 (x_session_initialize): Do not assume string length fits in int.
1202 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1203 This is unlikely, but can occur if DPI is outlandish.
1205 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1206 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1208 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1209 * xrdb.c (magic_file_p, search_magic_path):
1210 Omit last arg SUFFIX; it was always 0. All callers changed.
1211 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1213 * xfont.c (xfont_match): Avoid need for strlen.
1215 * xfns.c: Don't assume strlen fits in int.
1216 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1218 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1219 not unsigned long, as we prefer signed integers. All callers changed.
1220 Detect integer overflow in repeat count.
1221 (message_dolog): Don't assume print length fits in 39 bytes.
1222 (display_mode_element): Don't assume strlen fits in int.
1224 * termcap.c: Don't assume sizes fit in int and never overflow.
1225 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1226 (gobble_line): Check for size-calculation overflow.
1228 * minibuf.c (Fread_buffer):
1229 * lread.c (intern, intern_c_string):
1230 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1231 Don't assume string length fits in int.
1233 * keyboard.c (parse_tool_bar_item):
1234 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1236 * font.c: Don't assume string length fits in int.
1237 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1238 Use ptrdiff_t, not int.
1239 (font_intern_prop): Don't assume string length fits in int.
1240 Don't assume integer property fits in fixnum.
1241 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1243 * filelock.c: Fix some buffer overrun and integer overflow issues.
1244 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1245 Reformulate so as not to need the command string.
1246 Invoke gzip -cd rather than gunzip, as it's more portable.
1247 (lock_info_type, lock_file_1, lock_file):
1248 Don't assume pid_t and time_t fit in unsigned long.
1249 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1250 (current_lock_owner): Prefer signed type for sizes.
1251 Use memcpy, not strncpy, where memcpy is what is really wanted.
1252 Don't assume (via atoi) that time_t and pid_t fit in int.
1253 Check for time_t and/or pid_t out of range, e.g., via a network share.
1254 Don't alloca where an auto var works fine.
1256 * fileio.c: Fix some integer overflow issues.
1257 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1258 Don't assume string length fits in int.
1259 (directory_file_name): Don't assume string length fits in long.
1260 (make_temp_name): Don't assume pid fits in int, or that its print
1261 length is less than 20.
1263 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1265 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1267 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1269 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1270 We prefer signed integers, even for size calculations.
1272 * emacs.c: Don't assume string length fits in 'int'.
1273 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1274 (main): Don't invoke strlen when not needed.
1276 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1277 (XD_DEBUG_MESSAGE): Don't waste a byte.
1279 * callproc.c (getenv_internal_1, getenv_internal)
1281 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1283 * lread.c (invalid_syntax): Omit length argument.
1284 All uses changed. This doesn't fix a bug, but it simplifies the
1285 code away from its former Hollerith-constant appearance, and it's
1286 one less 'int' to worry about when looking at integer-overflow issues.
1287 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1289 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1290 This didn't break anything, but it didn't help either.
1291 It's confusing to put a bogus integer in a place where the actual
1292 value does not matter.
1293 (LIST_END_P): Remove unused macro and its bogus comment.
1294 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1296 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1297 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1299 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1300 We prefer signed types, and the value cannot exceed the EMACS_INT
1301 range anyway (because otherwise the length would not be representable).
1302 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1303 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1304 This avoids a GCC warning when WIDE_EMACS_INT.
1306 * indent.c (sane_tab_width): New function.
1307 (current_column, scan_for_column, Findent_to, position_indentation)
1308 (compute_motion): Use it. This is just for clarity.
1309 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1311 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1313 * lisp.h (lint_assume): New macro.
1314 * composite.c (composition_gstring_put_cache):
1315 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1317 * editfns.c, insdel.c:
1318 Omit unnecessary forward decls, to simplify future changes.
1320 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1322 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1324 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1325 Use much-faster test for byte-length change.
1326 Don't assume string byte-length fits in 'int'.
1327 Check that character arg fits in 'int'.
1328 (mapcar1): Declare byte as byte, for clarity.
1330 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1332 * fns.c (concat): Catch string overflow earlier.
1333 Do not rely on integer wraparound.
1335 * dispextern.h (struct it.overlay_strings_charpos)
1336 (struct it.selective): Now EMACS_INT, not int.
1337 * xdisp.c (forward_to_next_line_start)
1338 (back_to_previous_visible_line_start)
1339 (reseat_at_next_visible_line_start, next_element_from_buffer):
1340 Don't arbitrarily truncate the value of 'selective' to int.
1342 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1344 * composite.c: Don't truncate sizes to 'int'.
1345 (composition_gstring_p, composition_reseat_it)
1346 (composition_adjust_point): Use EMACS_INT, not int.
1347 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1348 not EMACS_UINT, for indexes.
1350 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1352 * buffer.c: Include <verify.h>.
1353 (struct sortvec.priority, struct sortstr.priority):
1354 Now EMACS_INT, not int.
1355 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1356 (struct sortstr.size, record_overlay_string)
1357 (struct sortstrlist.size, struct sortlist.used):
1358 Don't truncate size to int.
1359 (record_overlay_string): Check for size-calculation overflow.
1360 (init_buffer_once): Check at compile-time, not run-time.
1362 2011-06-22 Jim Meyering <meyering@redhat.com>
1364 Don't leak an XBM-image-sized buffer
1365 * image.c (xbm_load): Free the image buffer after using it.
1367 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1370 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1371 that Sun C diagnosed.
1372 * fns.c (secure_hash): Fix pointer signedness issue.
1373 * intervals.c (static_offset_intervals): New function.
1374 (offset_intervals): Use it.
1376 2011-06-21 Leo Liu <sdl.web@gmail.com>
1379 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1382 * fns.c (secure_hash): Rename from crypto_hash_function and change
1383 the first arg to accept symbols.
1384 (Fsecure_hash): New primitive.
1385 (syms_of_fns): New symbols.
1387 2011-06-20 Deniz Dogan <deniz@dogan.se>
1389 * process.c (Fset_process_buffer): Clarify return value in
1392 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1394 * dispnew.c (add_window_display_history): Use BVAR.
1396 * xdisp.c (debug_method_add): Use BVAR.
1397 (check_window_end, dump_glyph_matrix, dump_glyph)
1398 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1400 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1403 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1404 check till after the cache is created in init_frame_faces.
1406 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1408 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1410 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1412 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1413 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1414 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1416 Improve buffer-overflow checking (Bug#8873).
1417 * fileio.c (Finsert_file_contents):
1418 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1419 Remove the old (too-loose) buffer overflow checks.
1420 They weren't needed, since make_gap checks for buffer overflow.
1421 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1422 The old code merely checked for Emacs fixnum overflow, and relied
1423 on undefined (wraparound) behavior. The new code avoids undefined
1424 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1426 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1427 Tune. Don't use wider integers than needed. Don't use alloca.
1428 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1430 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1432 * insdel.c, lisp.h (buffer_overflow): New function.
1433 (insert_from_buffer_1, replace_range, replace_range_2):
1434 * insdel.c (make_gap_larger):
1435 * editfns.c (Finsert_char):
1436 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1438 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1440 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1442 Integer overflow and signedness fixes (Bug#8873).
1444 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1445 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1447 * fileio.c: Don't assume EMACS_INT fits in off_t.
1448 (emacs_lseek): New static function.
1449 (Finsert_file_contents, Fwrite_region): Use it.
1450 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1452 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1454 * fns.c: Don't overflow int when computing a list length.
1455 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1456 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1457 truncation on 64-bit hosts. Check for QUIT every
1458 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1459 faster and is responsive enough.
1460 (Flength): Report an error instead of overflowing an integer.
1461 (Fsafe_length): Return a float if the value is not representable
1462 as a fixnum. This shouldn't happen except in contrived situations.
1463 (Fnthcdr, Fsort): Don't assume list length fits in int.
1464 (Fcopy_sequence): Don't assume vector length fits in int.
1466 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1467 (header_size, word_size): New constants.
1468 (allocate_vectorlike): Don't check size overflow here.
1469 (allocate_vector): Check it here instead, since this is the only
1470 caller of allocate_vectorlike that could cause overflow.
1471 Check that the new vector's length is representable as a fixnum.
1473 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1474 The previous code was bogus. For example, next_almost_prime (32)
1475 returned 39, which is undesirable as it is a multiple of 3; and
1476 next_almost_prime (24) returned 25, which is a multiple of 5 so
1477 why was the code bothering to check for multiples of 7?
1479 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1481 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1483 Variadic C functions now count arguments with ptrdiff_t.
1484 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1485 Back then I didn't know that the Emacs coding style prefers signed int.
1486 Also, in the meantime I found a few more instances where arguments
1487 were being counted with int, which may truncate counts on 64-bit
1488 machines, or EMACS_INT, which may be unnecessarily wide.
1489 * lisp.h (struct Lisp_Subr.function.aMANY)
1490 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1491 Arg counts are now ptrdiff_t, not size_t.
1492 All variadic functions and their callers changed accordingly.
1493 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1494 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1495 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1496 * callint.c (Fcall_interactively): Check arg count for overflow,
1497 to avoid potential buffer overrun. Use signed char, not 'int',
1498 for 'varies' array, so that we needn't bother to check its size
1499 calculation for overflow.
1500 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1501 * eval.c (apply_lambda):
1502 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1503 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1504 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1506 * callint.c (Fcall_interactively): Don't use index var as event count.
1508 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1509 * mem-limits.h (SIZE): Remove; no longer used.
1511 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1513 Remove unnecessary casts.
1514 * xterm.c (x_term_init):
1515 * xfns.c (x_set_border_pixel):
1516 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1517 These aren't needed now that we assume ANSI C.
1519 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1520 It's more likely to cause problems (due to unsigned overflow)
1523 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1525 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1527 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1529 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1531 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1533 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1535 GLYPH_CODE_FACE returns EMACS_INT, not int.
1536 * dispextern.h (merge_faces):
1537 * xfaces.c (merge_faces):
1538 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1539 Don't assume EMACS_INT fits in int.
1541 * character.h (CHAR_VALID_P): Remove unused parameter.
1542 * fontset.c, lisp.h, xdisp.c: All uses changed.
1544 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1546 * fns.c (concat): Minor tuning based on overflow analysis.
1547 This doesn't fix any bugs. Use int to hold character, instead
1548 of constantly refetching from Emacs object. Use XFASTINT, not
1549 XINT, for value known to be a character. Don't bother comparing
1550 a single byte to 0400, as it's always less.
1552 * floatfns.c (Fexpt):
1553 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1555 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1558 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1560 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1561 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1562 incorrectly succeed when S was a string, because 4294967386 was
1563 truncated before it was used.
1565 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1566 Otherwise, an out-of-range integer could cause undefined behavior
1569 * composite.c: Use int, not EMACS_INT, for characters.
1570 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1571 EMACS_INT, for values that are known to be in character range.
1572 This doesn't fix any bugs but is the usual style inside Emacs and
1573 may generate better code on 32-bit machines.
1575 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1576 This is for reasons similar to the recent CHAR_STRING fix.
1577 * charset.c (Fencode_char): Check that character arg is actually
1578 a character. Pass an int to ENCODE_CHAR.
1579 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1580 wider than 'int', as a compile-time check to prevent future regressions
1583 * character.c (char_string): Remove unnecessary casts.
1585 Make sure a 64-bit char is never passed to CHAR_STRING.
1586 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1587 by silently ignoring the top 32 bits, allowing some values
1588 that were far too large to be valid characters.
1589 * character.h: Include <verify.h>.
1590 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1591 arguments are no wider than unsigned, as a compile-time check
1592 to prevent future regressions in this area.
1594 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1595 (Fsubst_char_in_region):
1597 * xdisp.c (decode_mode_spec_coding):
1598 Adjust to CHAR_STRING's new requirement.
1599 * editfns.c (Finsert_char, Fsubst_char_in_region):
1600 * fns.c (concat): Check that character args are actually
1601 characters. Without this test, these functions did the wrong
1602 thing with wildly out-of-range values on 64-bit hosts.
1604 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1605 These casts should not be needed on 32-bit hosts, either.
1606 * keyboard.c (read_char):
1607 * lread.c (Fload): Remove casts to unsigned.
1609 * lisp.h (UNSIGNED_CMP): New macro.
1610 This fixes comparison bugs on 64-bit hosts.
1611 (ASCII_CHAR_P): Use it.
1612 * casefiddle.c (casify_object):
1613 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1614 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1615 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1616 * dispextern.h (FACE_FROM_ID):
1617 * keyboard.c (read_char): Use UNSIGNED_CMP.
1619 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1620 not to EMACS_INT, to avoid GCC warning.
1622 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1624 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1625 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1626 isn't needed on 32-bit machines.
1628 * buffer.c (Fgenerate_new_buffer_name):
1629 Use EMACS_INT for count, not int.
1630 (advance_to_char_boundary): Return EMACS_INT, not int.
1632 * data.c (Qcompiled_function): Now static.
1634 * window.c (window_body_lines): Now static.
1636 * image.c (gif_load): Rename local to avoid shadowing.
1638 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1639 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1640 * alloc.c (make_save_value): Integer argument is now of type
1642 (mark_object): Use ptrdiff_t, not int.
1643 * lisp.h (pD): New macro.
1644 * print.c (print_object): Use it.
1646 * alloc.c: Use EMACS_INT, not int, to count objects.
1647 (total_conses, total_markers, total_symbols, total_vector_size)
1648 (total_free_conses, total_free_markers, total_free_symbols)
1649 (total_free_floats, total_floats, total_free_intervals)
1650 (total_intervals, total_strings, total_free_strings):
1651 Now EMACS_INT, not int. All uses changed.
1652 (Fgarbage_collect): Compute overall total using a double, so that
1653 integer overflow is less likely to be a problem. Check for overflow
1654 when converting back to an integer.
1655 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1656 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1657 These were 'int' variables that could overflow on 64-bit hosts;
1658 they were never used, so remove them instead of repairing them.
1659 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1660 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1661 Previously, this ceilinged at INT_MAX, but that doesn't work on
1663 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1665 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1666 (allocate_vectorlike): Check for ptrdiff_t overflow.
1667 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1668 when a (possibly-narrower) signed value would do just as well.
1669 We prefer using signed arithmetic, to avoid comparison confusion.
1671 * alloc.c: Catch some string size overflows that we were missing.
1672 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1673 for convenience in STRING_BYTES_MAX.
1674 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1675 The definition here is exact; the one in lisp.h was approximate.
1676 (allocate_string_data): Check for string overflow. This catches
1677 some instances we weren't catching before. Also, it catches
1678 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1679 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1680 and ptrdiff_t and EMACS_INT are both 64 bits.
1682 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1683 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1684 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1686 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1688 * alloc.c (Fmake_string): Check for out-of-range init.
1690 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1692 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1694 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1696 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1697 xg_get_default_scrollbar_width.
1699 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1700 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1701 (style_changed_cb): Call update_theme_scrollbar_width and call
1702 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1703 all frames (Bug#8505).
1704 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1705 Call gtk_window_set_resizable if HAVE_GTK3.
1706 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1707 and height if HAVE_GTK3 (Bug#8505).
1708 (scroll_bar_width_for_theme): New variable.
1709 (update_theme_scrollbar_width): New function.
1710 (xg_get_default_scrollbar_width): Move code to
1711 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1712 (xg_initialize): Call update_theme_scrollbar_width.
1714 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1716 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1718 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1720 * frame.c (make_frame): Call other_buffer_safely instead of
1723 * window.c (temp_output_buffer_show): Call display_buffer with
1724 second argument Vtemp_buffer_show_specifiers and reset latter
1725 immediately after the call.
1726 (Vtemp_buffer_show_specifiers): New variable.
1727 (auto_window_vscroll_p, next_screen_context_lines)
1728 (Vscroll_preserve_screen_position): Remove leading asterisks from
1731 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1733 Fix minor problems found by GCC 4.6.0 static checking.
1734 * buffer.c (Qclone_number): Remove for now, as it's unused.
1735 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1736 (record_buffer): Remove unused local.
1737 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1738 (set_frame_buffer_list): Remove; unused.
1739 * frame.h (other_visible_frames): Remove decl.
1740 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1741 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1742 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1744 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1745 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1746 Define only if HAVE_GPM.
1747 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1748 (update_hints_inhibit): Remove; never set. All uses removed.
1749 * widgetprv.h (emacsFrameClassRec): Remove decl.
1750 * window.c (delete_deletable_window): Now returns void, since it
1751 wasn't returning anything.
1752 (compare_window_configurations): Remove unused locals.
1753 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1754 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1755 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1756 the same widths as pointers. This follows up on the 2011-05-06 patch.
1757 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1758 * xterm.h: Likewise.
1759 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1761 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1763 * makefile.w32-in: Update dependencies.
1764 (LISP_H): Add lib/intprops.h.
1766 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1768 * image.c (gif_load): Add animation frame delay to the metadata.
1769 (syms_of_image): Use DEFSYM. New symbol `delay'.
1771 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1773 * window.c (delete_deletable_window): Re-add.
1774 (Fset_window_configuration): Rewrite to handle dead buffers and
1775 consequently deletable windows.
1776 (window_tree, Fwindow_tree): Remove. Supply functionality in
1778 (compare_window_configurations): Simplify code.
1780 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1782 * image.c (imagemagick_load_image): Fix type mismatch.
1783 (Fimagemagick_types): Likewise.
1785 * window.h (replace_buffer_in_windows): Declare.
1787 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1789 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1790 Qclone_number. Remove external declaration of Qdelete_window.
1791 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1793 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1794 Qbuffer_list_update_hook if allowed.
1795 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1796 buffer list implementation.
1797 (other_buffer_safely): New function.
1798 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1799 calls to replace_buffer_in_windows and
1800 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1802 (record_buffer): Inhibit quitting and rewrite using quittable
1803 functions. Run Qbuffer_list_update_hook if allowed.
1804 (Frecord_buffer, Funrecord_buffer): New functions.
1805 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1806 switch-to-buffer to window.el.
1807 (bury-buffer): Move to window.el.
1808 (Vbuffer_list_update_hook): New variable.
1810 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1813 * window.h (resize_frame_windows): Move up in code.
1814 (Fwindow_frame): Remove EXFUN.
1815 (replace_buffer_in_all_windows): Remove prototype.
1816 (replace_buffer_in_windows_safely): Add prototype.
1818 * window.c: Declare Qdelete_window static again. Move down
1819 declaration of select_count.
1820 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1821 (Fother_window): Move to window.el.
1822 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1823 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1824 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1826 (replace_buffer_in_windows): Implement by calling
1827 Qreplace_buffer_in_windows.
1828 (replace_buffer_in_all_windows): Remove with some functionality
1829 moved into replace_buffer_in_windows_safely.
1830 (replace_buffer_in_windows_safely): New function.
1831 (select_window_norecord, select_frame_norecord): Move in front
1832 of run_window_configuration_change_hook. Remove now obsolete
1834 (Fset_window_buffer): Rewrite doc-string. Call
1835 Qrecord_window_buffer.
1836 (keys_of_window): Move binding for other-window to window.el.
1838 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1840 * dispextern.h (struct image): Replace data member, whose int_val
1841 and ptr_val fields were not used by anything, with a single
1844 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1845 (gif_clear_image, gif_load, imagemagick_load_image)
1846 (gs_clear_image, gs_load): Callers changed.
1848 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1850 * buffer.h: Include <time.h>, for time_t.
1851 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1853 Fix minor problems found by static checking.
1855 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1857 Make identifiers static if they are not used in other modules.
1858 * data.c (Qcompiled_function, Qframe, Qvector):
1859 * image.c (QimageMagick, Qsvg):
1860 * minibuf.c (Qmetadata):
1861 * window.c (resize_window_check, resize_root_window): Now static.
1862 * window.h (resize_window_check, resize_root_window): Remove decls.
1864 * window.c (window_deletion_count, delete_deletable_window):
1866 (window_body_lines): Now static.
1867 (Fdelete_other_windows_internal): Mark vars as initialized.
1868 Make sure 'resize_failed' is initialized.
1869 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1870 (resize_window_apply): Remove unused local.
1871 * window.h (delete_deletable_window): Remove decl.
1873 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1874 (imagemagick_load_image): Fix pointer signedness problem by changing
1875 last arg from unsigned char * to char *. All uses changed.
1876 Also, fix a local for similar reasons.
1877 Remove unused locals. Remove locals to avoid shadowing.
1878 (fn_rsvg_handle_free): Remove; unused.
1879 (svg_load, svg_load_image): Fix pointer signedness problem.
1880 (imagemagick_load_image): Don't use garbage pointer image_wand.
1882 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1884 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1886 * image.c (gif_load): Fix omitted cast error introduced by
1889 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1891 * window.h (resize_proportionally, orig_total_lines)
1892 (orig_top_line): Remove from window structure.
1893 (set_window_height, set_window_width, change_window_heights)
1894 (Fdelete_window): Remove prototypes.
1895 (resize_frame_windows): Remove duplicate declaration.
1897 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1899 * window.h (resize_frame_windows, resize_window_check)
1900 (delete_deletable_window, resize_root_window)
1901 (resize_frame_windows): Declare prototypes.
1903 * window.c (resize_window_apply): Make definition be "static" to
1904 match the prototype.
1906 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1908 * window.c: Remove declarations of Qwindow_size_fixed,
1909 window_min_size_1, window_min_size_2, window_min_size,
1910 size_window, window_fixed_size_p, enlarge_window, delete_window.
1911 Remove static from declaration of Qdelete_window, it's
1912 temporarily needed by Fbury_buffer.
1913 (replace_window): Don't assign orig_top_line and
1915 (Fdelete_window, delete_window): Remove. Window deletion is
1916 handled by window.el.
1917 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1918 Fdelete_window calls with calls to Qdelete_window.
1919 (Fdelete_other_windows): Remove. Deleting other windows is
1920 handled by window.el.
1921 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1922 handled in window.el.
1923 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1924 Window minimum sizes are handled in window.el.
1925 (shrink_windows, size_window, set_window_height)
1926 (set_window_width, change_window_heights, window_height)
1927 (window_width, CURBEG, CURSIZE, enlarge_window)
1928 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1929 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1930 handled in window.el.
1931 (make_dummy_parent): Rename to make_parent_window and give it a
1932 second argument horflag.
1933 (make_window): Don't set resize_proportionally any more.
1934 (Fsplit_window): Remove. Windows are split in window.el.
1935 (save_restore_action, save_restore_orig_size)
1936 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1937 Resize mini windows in window.el.
1938 (grow_mini_window, shrink_mini_window): Implement by calling
1939 Qresize_root_window_vertically, resize_window_check and
1940 resize_window_apply.
1941 (saved_window, Fset_window_configuration, save_window_save): Do
1942 not handle orig_top_line, orig_total_lines, and
1943 resize_proportionally.
1944 (window_min_height, window_min_width): Move to window.el.
1945 (keys_of_window): Move bindings for delete-other-windows,
1946 split-window, delete-window and enlarge-window to window.el.
1948 * buffer.c: Temporarily extern Qdelete_window.
1949 (Fbury_buffer): Temporarily call Qdelete_window instead of
1950 Fdelete_window (Fbury_buffer will move to window.el soon).
1952 * frame.c (set_menu_bar_lines_1): Remove code handling
1953 orig_top_line and orig_total_lines.
1955 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1956 set_window_height but set heights directly.
1957 (change_frame_size_1): Use resize_frame_windows.
1959 * xdisp.c (init_xdisp): Don't use set_window_height but set
1962 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1963 resize_frame_windows instead of change_window_heights and run
1964 run_window_configuration_change_hook.
1966 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1967 instead of change_window_heights and run
1968 run_window_configuration_change_hook.
1970 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1972 * window.c (replace_window): Rename second argument REPLACEMENT to
1973 NEW. New third argument SETFLAG. Rewrite.
1974 (delete_window, make_dummy_parent): Call replace_window with
1976 (window_list_1): Move down in code.
1977 (run_window_configuration_change_hook): Move set_buffer part
1978 before select_frame_norecord part in order to unwind correctly.
1979 Rename count1 to count.
1980 (recombine_windows, delete_deletable_window, resize_root_window)
1981 (Fdelete_other_windows_internal)
1982 (Frun_window_configuration_change_hook, make_parent_window)
1983 (resize_window_check, resize_window_apply, Fresize_window_apply)
1984 (resize_frame_windows, Fsplit_window_internal)
1985 (Fdelete_window_internal, Fresize_mini_window_internal): New
1987 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1989 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1991 * window.h (window): Add some new members to window structure -
1992 normal_lines, normal_cols, new_total, new_normal, clone_number,
1993 splits, nest, prev_buffers, next_buffers.
1994 (WINDOW_TOTAL_SIZE): Move here from window.c.
1995 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1997 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1999 (make_dummy_parent): Set new members of windows structure.
2000 (make_window): Move down in code. Handle new members of window
2002 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2003 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2004 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2005 (Fset_window_prev_buffers, Fwindow_next_buffers)
2006 (Fset_window_next_buffers, Fset_window_clone_number): New
2008 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2009 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2011 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2012 Argument WINDOW can be now internal window too.
2013 (Fwindow_use_time): Move up in code.
2014 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2016 (Fset_window_configuration, saved_window)
2017 (Fcurrent_window_configuration, save_window_save): Handle new
2018 members of window structure.
2019 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2020 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2021 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2022 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2023 Qget_mru_window, Qresize_root_window,
2024 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2025 Qauto_buffer_name; staticpro them.
2027 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2029 * window.c (Fwindow_total_size, Fwindow_left_column)
2030 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2031 (Fwindow_list_1): New functions.
2032 (window_box_text_cols): Replace with window_body_cols.
2033 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2034 window_body_cols instead of window_box_text_cols.
2035 (delete_window, Fset_window_configuration): Call
2036 delete_all_subwindows with window as argument.
2037 (delete_all_subwindows): Take a window as argument and not a
2039 (window_loop): Remove handling of GET_LRU_WINDOW and
2041 (Fget_lru_window, Fget_largest_window): Move to window.el.
2043 * window.h: Extern window_body_cols instead of
2044 window_box_text_cols. delete_all_subwindows now takes a
2045 Lisp_Object as argument.
2047 * indent.c (compute_motion, Fcompute_motion): Use
2048 window_body_cols instead of window_box_text_cols.
2050 * frame.c (delete_frame): Call delete_all_subwindows with root
2053 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2055 * fns.c (Fputhash): Document return value.
2057 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2059 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2061 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2063 Cons<->int and similar integer overflow fixes (Bug#8794).
2065 Check for overflow when converting integer to cons and back.
2066 * charset.c (Fdefine_charset_internal, Fdecode_char):
2067 Use cons_to_unsigned to catch overflow.
2068 (Fencode_char): Use INTEGER_TO_CONS.
2069 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2070 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2071 * data.c (long_to_cons, cons_to_long): Remove.
2072 (cons_to_unsigned, cons_to_signed): New functions.
2073 These signal an error for invalid or out-of-range values.
2074 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2075 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2076 * font.c (Ffont_variation_glyphs):
2077 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2078 * lisp.h: Include <intprops.h>.
2079 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2080 (cons_to_signed, cons_to_unsigned): New decls.
2081 (long_to_cons, cons_to_long): Remove decls.
2082 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2083 (Fprimitive_undo): Use CONS_TO_INTEGER.
2084 * xfns.c (Fx_window_property): Likewise.
2085 * xselect.c: Include <limits.h>.
2086 (x_own_selection, selection_data_to_lisp_data):
2087 Use INTEGER_TO_CONS.
2088 (x_handle_selection_request, x_handle_selection_clear)
2089 (x_get_foreign_selection, Fx_disown_selection_internal)
2090 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2091 (lisp_data_to_selection_data): Use cons_to_unsigned.
2092 (x_fill_property_data): Use cons_to_signed.
2093 Report values out of range.
2095 Check for buffer and string overflow more precisely.
2096 * buffer.h (BUF_BYTES_MAX): New macro.
2097 * lisp.h (STRING_BYTES_MAX): New macro.
2098 * alloc.c (Fmake_string):
2099 * character.c (string_escape_byte8):
2100 * coding.c (coding_alloc_by_realloc):
2101 * doprnt.c (doprnt):
2102 * editfns.c (Fformat):
2104 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2105 since they may not be the same number.
2106 * editfns.c (Finsert_char):
2107 * fileio.c (Finsert_file_contents):
2108 Likewise for BUF_BYTES_MAX.
2110 * image.c: Use ptrdiff_t, not int, for sizes.
2111 (slurp_file): Switch from int to ptrdiff_t.
2113 (slurp_file): Check that file size fits in both size_t (for
2114 malloc) and ptrdiff_t (for sanity and safety).
2116 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2117 if b->modtime has its maximal value.
2119 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2121 Don't assume time_t can fit into int.
2122 * buffer.h (struct buffer.modtime): Now time_t, not int.
2123 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2124 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2126 Minor fixes for signed vs unsigned integers.
2127 * character.h (MAYBE_UNIFY_CHAR):
2128 * charset.c (maybe_unify_char):
2129 * keyboard.c (read_char, reorder_modifiers):
2130 XINT -> XFASTINT, since the integer must be nonnegative.
2131 * ftfont.c (ftfont_spec_pattern):
2132 * keymap.c (access_keymap, silly_event_symbol_error):
2133 XUINT -> XFASTINT, since the integer must be nonnegative.
2134 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2135 since it makes no difference and we prefer signed.
2136 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2137 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2140 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2142 * window.h (Fwindow_frame): Declare.
2144 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2146 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2147 (SPARE_MEMORY): Always define.
2148 (LARGE_REQUEST): Remove.
2149 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2151 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2153 * lisp.h: Move EXFUNS for Fframe_root_window,
2154 Fframe_first_window and Fset_frame_selected_window to window.h.
2156 * window.h: Move EXFUNS for Fframe_root_window,
2157 Fframe_first_window and Fset_frame_selected_window here from
2160 * frame.c (Fwindow_frame, Fframe_first_window)
2161 (Fframe_root_window, Fframe_selected_window)
2162 (Fset_frame_selected_window): Move to window.c.
2163 (Factive_minibuffer_window): Move to minibuf.c.
2164 (Fother_visible_frames_p): New function.
2166 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2168 * window.c (decode_window, decode_any_window): Move up in code.
2169 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2170 (inhibit_frame_unsplittable): Remove unused variable.
2171 (Fwindow_buffer): Move up and rewrite doc-string.
2172 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2173 (Fwindow_prev): New functions.
2174 (Fwindow_frame): Move here from frame.c. Accept any window as
2176 (Fframe_root_window, Fframe_first_window)
2177 (Fframe_selected_window): Move here from frame.c. Accept frame
2178 or arbitrary window as argument. Update doc-strings.
2179 (Fminibuffer_window): Move up in code.
2180 (Fwindow_minibuffer_p): Move up in code and simplify.
2181 (Fset_frame_selected_window): Move here from frame.c.
2183 (Fselected_window, select_window, Fselect_window): Move up in
2184 code. Minor doc-string fixes.
2186 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2188 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2189 Do not assume that spare memory exists; that assumption is valid
2190 only if SYSTEM_MALLOC.
2191 (LARGE_REQUEST): New macro, so that the issue of large requests
2192 is separated from the issue of spare memory.
2194 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2196 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2199 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2201 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2204 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2206 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2208 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2210 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2211 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2213 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2215 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2217 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2219 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2220 (x_clipboard_manager_save): Add return value.
2221 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2223 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2224 Obey Vx_select_enable_clipboard_manager. Catch errors in
2225 x_clipboard_manager_save (Bug#8779).
2226 (Vx_select_enable_clipboard_manager): New variable.
2227 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2229 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2231 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2233 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2235 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2236 in the current matrix if keep_current_p is non-zero.
2238 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2240 * bidi.c (bidi_level_of_next_char): Fix last change.
2242 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2244 Support bidi reordering of text covered by display properties.
2246 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2247 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2248 (bidi_cache_search, bidi_cache_iterator_state)
2249 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2250 (bidi_level_of_next_char, bidi_move_to_visually_next):
2251 Support character positions inside a run of characters covered by a
2253 (bidi_paragraph_init, bidi_resolve_explicit_1)
2254 (bidi_level_of_next_char): Call bidi_fetch_char and
2255 bidi_fetch_char_advance instead of FETCH_CHAR and
2257 (bidi_init_it): Initialize new members.
2258 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2260 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2261 instead of using explicit *_CHAR codes.
2262 (bidi_resolve_explicit, bidi_resolve_weak):
2263 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2264 bidirectional text is supported only in multibyte buffers.
2265 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2266 it to initialize the frame_window_p member of struct bidi_it.
2267 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2268 (bidi_resolve_explicit, bidi_resolve_weak)
2269 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2270 bidi_it->nchars is non-positive.
2271 (bidi_level_of_next_char): Don't try to lookup the cache for the
2272 next/previous character if nothing is cached there yet, or if we
2273 were just reseat()'ed to a new position.
2275 * xdisp.c (set_cursor_from_row): Set start and stop points
2276 according to the row's direction when priming the loop that looks
2277 for the glyph on which to display cursor.
2278 (single_display_spec_intangible_p): Function deleted.
2279 (display_prop_intangible_p): Reimplement to call
2280 handle_display_spec instead of single_display_spec_intangible_p.
2281 Accept 3 additional arguments needed by handle_display_spec.
2282 This fixes incorrect cursor motion across display property with complex
2283 values: lists, `(when COND...)' forms, etc.
2284 (single_display_spec_string_p): Support property values that are
2285 lists with the argument STRING its top-level element.
2286 (display_prop_string_p): Fix the condition for processing a
2287 property that is a list to be consistent with handle_display_spec.
2288 (handle_display_spec): New function, refactored from the
2289 last portion of handle_display_prop.
2290 (compute_display_string_pos): Accept additional argument
2291 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2292 value of a `display' property is a "replacing spec".
2293 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2294 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2295 the display property, but just return a value indicating whether
2296 the display property will replace the characters it covers.
2297 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2298 frame_window_p members of struct bidi_it.
2299 (compute_display_string_pos, compute_display_string_end):
2301 (push_it): Accept second argument POSITION, where pop_it should
2302 jump to continue iteration.
2303 (reseat_1): Initialize bidi_it.disp_pos.
2305 * keyboard.c (adjust_point_for_property): Adjust the call to
2306 display_prop_intangible_p to its new signature.
2308 * dispextern.h (struct bidi_it): New member frame_window_p.
2309 (bidi_init_it): Update prototypes.
2310 (display_prop_intangible_p): Update prototype.
2311 (compute_display_string_pos, compute_display_string_end):
2313 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2316 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2318 Malloc failure behavior now depends on size of allocation.
2319 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2320 * lisp.h: Change signatures accordingly.
2321 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2322 All callers changed. (Bug#8762)
2324 * gnutls.c: Use Emacs's memory allocators.
2325 Without this change, the gnutls library would invoke malloc etc.
2326 directly, which causes problems on non-SYNC_INPUT hosts, and which
2327 runs afoul of improving memory_full behavior. (Bug#8761)
2328 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2329 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2330 xfree instead of the default malloc, realloc, free.
2331 (Fgnutls_boot): No need to check for memory allocation failure,
2332 since xmalloc does that for us.
2334 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2335 * category.c (hash_get_category_set):
2336 * ccl.c (ccl_driver):
2337 * charset.c (Fdefine_charset_internal):
2338 * charset.h (struct charset.hash_index):
2339 * composite.c (get_composition_id, gstring_lookup_cache)
2340 (composition_gstring_put_cache):
2341 * composite.h (struct composition.hash_index):
2342 * dispextern.h (struct image.hash):
2343 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2344 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2345 (hashfn_equal, hashfn_user_defined, make_hash_table)
2346 (maybe_resize_hash_table, hash_lookup, hash_put)
2347 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2348 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2349 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2350 * image.c (make_image, search_image_cache, lookup_image)
2351 (xpm_put_color_table_h):
2352 * lisp.h (struct Lisp_Hash_Table):
2353 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2354 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2355 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2356 * alloc.c (allocate_vectorlike):
2357 Check for overflow in vector size calculations.
2358 * ccl.c (ccl_driver):
2359 Check for overflow when converting EMACS_INT to int.
2360 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2361 need to be updated by these changes.
2362 * fns.c (make_hash_table, maybe_resize_hash_table):
2363 Check for integer overflow with large hash tables.
2364 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2365 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2366 (SXHASH_REDUCE): New macro.
2367 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2368 Use it instead of discarding useful hash info with large hash values.
2369 (sxhash_float): New function.
2370 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2371 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2372 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2373 Rewrite to use FIXNUM_BITS, as this simplifies things.
2374 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2375 Adjust signatures to match updated version of code.
2376 (consing_since_gc): Now EMACS_INT, since a single hash table can
2377 use more than INT_MAX bytes.
2379 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2381 Make it possible to build with GCC-4.6+ -O2 -flto.
2383 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2385 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2387 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2388 Call minibuffer-inactive-mode.
2390 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2392 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2393 Update dependencies.
2395 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2397 * data.c (init_data): Remove code for UTS, this system is not
2400 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2402 Don't force ./temacs to start in terminal mode.
2404 * frame.c (make_initial_frame): Initialize faces in all cases, not
2405 only when CANNOT_DUMP is defined.
2406 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2408 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2410 * dispnew.c (add_window_display_history): Use const for the string
2411 pointer. Remove declaration, not needed.
2413 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2415 Use 'inline', not 'INLINE'.
2416 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2417 * alloc.c, fontset.c (INLINE): Remove.
2418 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2419 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2420 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2421 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2422 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2424 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2426 Make it possible to run ./temacs.
2428 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2429 syms_of_callproc does the same thing. Remove test for
2430 "initialized", do it in the caller.
2431 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2433 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2435 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2436 (read_minibuf): Use get_minibuffer.
2437 (syms_of_minibuf): Use DEFSYM.
2438 (Qmetadata): New var.
2439 * data.c (Qbuffer): Don't make it static.
2440 (syms_of_data): Use DEFSYM.
2442 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2444 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2445 (CCL_CODE_MIN): New macro.
2447 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2449 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2451 * eval.c (Qdebug): Now static.
2452 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2453 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2454 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2456 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2458 * image.c: Various fixes to ImageMagick code comments.
2459 (Fimagemagick_types): Doc fix.
2461 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2463 Minor fixes prompted by GCC 4.6.0 warnings.
2465 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2467 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2468 (x_clipboard_manager_save_all): Move extern decl to ...
2469 * xterm.h: ... here, so that it can be checked for consistency.
2471 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2473 * xselect.c (x_clipboard_manager_save_frame)
2474 (x_clipboard_manager_save_all): New functions.
2475 (Fx_clipboard_manager_save): Lisp function deleted.
2477 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2478 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2480 * xterm.h: Update prototype.
2482 2011-05-28 William Xu <william.xwl@gmail.com>
2484 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2487 2011-05-28 Jim Meyering <meyering@redhat.com>
2489 Avoid a sign-extension bug in crypto_hash_function.
2490 * fns.c (to_uchar): Define.
2491 (crypto_hash_function): Use it to convert some newly-signed
2492 variables to unsigned, to avoid sign-extension bugs. For example,
2493 without this change, (md5 "truc") would evaluate to
2494 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2495 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2496 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2498 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2500 Integer overflow fixes.
2502 * dbusbind.c: Serial number integer overflow fixes.
2503 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2504 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2505 to hold a serial number that is too large for a fixnum.
2506 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2507 Check for serial numbers out of range. Decode any serial number
2508 that was so large that it became a float. (Bug#8722)
2510 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2511 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2512 Use XFASTINT rather than XUINT when numbers are nonnegative.
2513 (xd_append_arg, Fdbus_method_return_internal):
2514 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2515 arguments, check that Lisp number is nonnegative, rather than
2516 silently wrapping negative numbers around. (Bug#8722)
2517 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2520 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2522 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2524 ccl: add integer overflow checks
2525 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2526 (IN_INT_RANGE): New macros.
2527 (ccl_driver): Use them to check for integer overflow when
2528 decoding a CCL program. Many of the new checks are whether XINT (x)
2529 fits in int; it doesn't always, on 64-bit hosts. The new version
2530 doesn't catch all possible integer overflows, but it's an
2531 improvement. (Bug#8719)
2533 * alloc.c (make_event_array): Use XINT, not XUINT.
2534 There's no need for unsigned here.
2536 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2537 This follows up to the 2011-05-06 change that substituted uintptr_t
2538 for EMACS_INT. This case wasn't caught back then.
2540 Rework Fformat to avoid integer overflow issues.
2541 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2542 now (part of C89). Include <verify.h>.
2543 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2544 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2545 (Fformat): Avoid the prepass trying to compute sizes; it was only
2546 approximate and thus did not catch overflow reliably. Instead, walk
2547 through the format just once, formatting and computing sizes as we go,
2548 checking for integer overflow at every step, and allocating a larger
2549 buffer as needed. Keep track separately whether the format is
2550 multibyte. Keep only the most-recently calculated precision, rather
2551 than them all. Record whether each argument has been converted to
2552 string. Use EMACS_INT, not int, for byte and char and arg counts.
2553 Support field widths and precisions larger than INT_MAX. Avoid
2554 sprintf's undefined behavior with conversion specifications such as %#d
2555 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2556 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2557 formatting out-of-range floating point numbers with int
2560 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2562 * data.c: Avoid integer truncation in expressions involving floats.
2563 * data.c: Include <intprops.h>.
2564 (arith_driver): When there's an integer overflow in an expression
2565 involving floating point, convert the integers to floating point
2566 so that the resulting value does not suffer from catastrophic
2567 integer truncation. For example, on a 64-bit host (* 4
2568 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2569 Do not rely on undefined behavior after integer overflow.
2571 merge count_size_as_multibyte, parse_str_to_multibyte
2572 * character.c, character.h (count_size_as_multibyte):
2573 Rename from parse_str_to_multibyte; all uses changed.
2574 Check for integer overflow.
2575 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2576 since it's now a duplicate of the other. This is more of
2577 a character than a buffer op, so better that it's in character.c.
2578 * fns.c, print.c: Adjust to above changes.
2580 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2582 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2584 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2586 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2587 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2588 (x_clipboard_manager_save): Now static.
2589 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2591 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2592 (crypto_hash_function): Now static.
2593 Fix pointer signedness problems. Avoid unnecessary initializations.
2595 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2597 * termhooks.h (Vselection_alist): Make it terminal-local.
2599 * terminal.c (create_terminal): Initialize it.
2601 * xselect.c: Support for clipboard managers.
2602 (Vselection_alist): Move to termhooks.h as terminal-local var.
2603 (LOCAL_SELECTION): New macro.
2604 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2605 (symbol_to_x_atom): Remove gratuitous arg.
2606 (x_handle_selection_request, lisp_data_to_selection_data)
2607 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2608 (x_own_selection, x_get_local_selection, x_convert_selection):
2609 New arg, specifying work frame. Use terminal-local Vselection_alist.
2610 (some_frame_on_display): Delete unused function.
2611 (Fx_own_selection_internal, Fx_get_selection_internal)
2612 (Fx_disown_selection_internal, Fx_selection_owner_p)
2613 (Fx_selection_exists_p): New optional frame arg.
2614 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2615 (x_handle_selection_clear): Don't treat other terminals with the
2616 same keyboard specially. Use the terminal-local Vselection_alist.
2617 (x_clear_frame_selections): Use Frun_hook_with_args.
2619 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2621 * xterm.h: Add support for those atoms.
2623 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2625 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2626 (converted_selections, conversion_fail_tag): New global variables.
2627 (x_selection_request_lisp_error): Free the above.
2628 (x_get_local_selection): Remove unnecessary code.
2629 (x_reply_selection_request): Args changed; handle arbitrary array
2630 of converted selections stored in converted_selections.
2631 Separate the XChangeProperty and SelectionNotify steps.
2632 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2633 (x_convert_selection): New function.
2634 (x_handle_selection_event): Simplify.
2635 (x_get_foreign_selection): Don't ignore incoming requests while
2636 waiting for an answer; this will fail when we implement
2637 SAVE_TARGETS, and seems unnecessary anyway.
2638 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2639 (Vx_sent_selection_functions): Doc fix.
2641 2011-05-26 Leo Liu <sdl.web@gmail.com>
2643 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2645 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2647 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2649 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2650 for fringe update if it has periodic bitmap.
2651 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2652 and fringe_bitmap_periodic_p.
2654 * fringe.c (get_fringe_bitmap_data): New function.
2655 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2656 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2657 row. Mark glyph row for fringe update if periodicity changed.
2659 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2660 for fringe update unless it has periodic bitmap.
2662 2011-05-25 Kenichi Handa <handa@m17n.org>
2664 * xdisp.c (get_next_display_element): Set correct it->face_id for
2665 a static composition.
2667 2011-05-24 Leo Liu <sdl.web@gmail.com>
2670 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2672 * fns.c (crypto_hash_function, Fsha1): New function.
2673 (Fmd5): Use crypto_hash_function.
2674 (syms_of_fns): Add Ssha1.
2676 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2678 * gnutls.c: Remove unused macros.
2679 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2680 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2681 Remove macros that are defined and never used.
2682 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2684 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2686 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2687 (Fx_get_selection_internal): Minor cleanup.
2688 (Fx_own_selection_internal): Rename arguments for consistency with
2691 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2693 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2695 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2697 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2699 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2701 * dispnew.c (scrolling_window): Don't exclude the case that the
2702 last enabled row in the desired matrix touches the bottom boundary.
2704 2011-05-21 Glenn Morris <rgm@gnu.org>
2706 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2707 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2708 and add some more files.
2710 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2712 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2713 report_file_error introduced by the change from 2011-05-07.
2715 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2717 * systime.h (Time): Define only if emacs is defined.
2718 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2719 where the include path doesn't have X11/X.h by default. See
2720 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2722 2011-05-20 Kenichi Handa <handa@m17n.org>
2724 * composite.c (find_automatic_composition): Fix previous change.
2726 2011-05-20 Glenn Morris <rgm@gnu.org>
2728 * lisp.mk: New file, split from Makefile.in.
2729 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2730 (shortlisp): Remove.
2731 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2733 2011-05-19 Glenn Morris <rgm@gnu.org>
2735 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2736 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2737 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2738 (lisp): Set the order to that of loadup.el.
2739 (shortlisp): Make it a copy of $lisp.
2740 (SOME_MACHINE_LISP): Remove.
2741 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2742 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2744 2011-05-18 Kenichi Handa <handa@m17n.org>
2746 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2747 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2748 (find_automatic_composition): Mostly rewrite for efficiency.
2750 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2752 * makefile.w32-in: Update dependencies.
2754 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2756 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2757 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2759 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2761 Fix some integer overflow issues, such as string length overflow.
2763 * insdel.c (count_size_as_multibyte): Check for string overflow.
2765 * character.c (lisp_string_width): Check for string overflow.
2766 Use EMACS_INT, not int, for string indexes and lengths; in
2767 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2768 the resulting string length overflows an EMACS_INT; instead,
2769 report a string overflow if no precision given. When checking for
2770 precision exhaustion, use a check that cannot possibly have
2771 integer overflow. (Bug#8675)
2772 * character.h (lisp_string_width): Adjust to new signature.
2774 * alloc.c (string_overflow): New function.
2775 (Fmake_string): Use it. This doesn't change behavior, but saves
2776 a few bytes and will simplify future changes.
2777 * character.c (string_escape_byte8): Likewise.
2778 * lisp.h (string_overflow): New decl.
2780 Fixups, following up to the user-interface timestamp change.
2781 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2782 for UI timestamps, instead of unsigned long.
2783 * msdos.c (mouse_get_pos): Likewise.
2784 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2785 * w32gui.h (Time): Define by including "systime.h" rather than by
2786 declaring it ourselves. (Bug#8664)
2788 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2789 * image.c (clear_image_cache): Likewise.
2791 * term.c (term_mouse_position): Don't assume time_t wraparound.
2793 Be more systematic about user-interface timestamps.
2794 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2795 and sometimes 'EMACS_UINT', to represent these timestamps.
2796 This change causes it to use 'Time' uniformly, as that's what X uses.
2797 This makes the code easier to follow, and makes it easier to catch
2798 integer overflow bugs such as Bug#8664.
2799 * frame.c (Fmouse_position, Fmouse_pixel_position):
2800 Use Time, not unsigned long, for user-interface timestamps.
2801 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2802 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2803 * keyboard.h (last_event_timestamp): Likewise.
2804 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2805 * menu.h (xmenu_show): Likewise.
2806 * term.c (term_mouse_position): Likewise.
2807 * termhooks.h (struct input_event.timestamp): Likewise.
2808 (struct terminal.mouse_position_hook): Likewise.
2809 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2810 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2811 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2812 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2814 * menu.h, termhooks.h: Include "systime.h", for Time.
2816 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2817 Don't assume that the difference between two unsigned long values
2818 can fit into an integer. At this point, we know button_down_time
2819 <= event->timestamp, so the difference must be nonnegative, so
2820 there's no need to cast the result if double-click-time is
2821 nonnegative, as it should be; check that it's nonnegative, just in
2822 case. This bug is triggered when events are more than 2**31 ms
2823 apart (about 25 days). (Bug#8664)
2825 * xselect.c (last_event_timestamp): Remove duplicate decl.
2826 (x_own_selection): Remove needless cast to unsigned long.
2828 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2829 that always fit in int. Use a sentinel instead of a counter, to
2830 avoid a temp and to allay GCC's concerns about possible int overflow.
2831 * frame.h (struct frame): Use int for menu_bar_items_used
2832 instead of EMACS_INT, since it always fits in int.
2834 * menu.c (grow_menu_items): Check for int overflow.
2836 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2838 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2839 Before, the code was not consistent. These values cannot exceed
2840 2**31 - 1 so there's no need to make them unsigned.
2841 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2842 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2843 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2845 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2847 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2848 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2849 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2850 presumably because the widths might not match.
2852 * window.c (size_window): Avoid needless test at loop start.
2854 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2856 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2858 2011-05-12 Drew Adams <drew.adams@oracle.com>
2860 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2862 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2864 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2865 `width' to `bar_area_x' and `bar_area_width', respectively.
2866 (x_scroll_run): Take account of fringe background extension.
2868 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2869 Rename local vars `left' and `width' to `bar_area_x' and
2870 `bar_area_width', respectively.
2871 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2872 background extension.
2874 2011-05-10 Jim Meyering <meyering@redhat.com>
2876 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2878 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2880 * image.c (Finit_image_library): Return t for built-in image types,
2881 like pbm and xbm. (Bug#8640)
2883 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2885 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2887 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2889 * w32console.c (Fset_screen_color): Doc fix.
2890 (Fget_screen_color): New function.
2891 (syms_of_ntterm): Defsubr it.
2893 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2894 unlink the temporary file if Fcall_process didn't create it in the
2896 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2897 child process will be redirected to a file specified with `:file'.
2898 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2899 cue to call_process_cleanup not to close that handle.
2901 2011-05-07 Ben Key <bkey76@gmail.com>
2903 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2904 one of two shell specific rules, either bootstrap-temacs-CMD or
2905 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2906 to the previous implementation of the bootstrap-temacs rule.
2907 The bootstrap-temacs-CMD rule is similar to the previous
2908 implementation of the bootstrap-temacs rule except that it
2909 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2912 These changes, along with some changes to nt/configure.bat,
2913 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2914 earlier fix to add support for --cflags and --ldflags options
2915 that include quotes so that it works whether make uses cmd or
2918 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2920 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2921 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2923 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2924 a string. Handle both cases.
2925 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2926 (Fdbus_register_method): Use Qinvalid_function.
2928 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2930 * makefile.w32-in: Update dependencies.
2931 (LISP_H): Add inttypes.h and stdin.h.
2932 (PROCESS_H): Add unistd.h.
2934 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2936 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2937 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2939 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2941 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2943 * term.c (vfatal): Remove stray call to va_end.
2944 It's not needed and the C Standard doesn't allow it here anyway.
2946 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2947 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2949 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2952 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2954 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2956 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2958 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2960 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2962 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2963 * charset.c (Fdefine_charset_internal): Don't initialize
2964 charset.code_space[15]. The value was garbage, on hosts with
2965 32-bit int (Bug#8600).
2967 * lread.c (read_integer): Be more consistent with string-to-number.
2968 Use string_to_number to do the actual conversion; this avoids
2969 rounding errors and fixes some other screwups. Without this fix,
2970 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2971 (digit_to_number): Move earlier, for benefit of read_integer.
2972 Return -1 if the digit is out of range for the base, -2 if it is
2973 not a digit in any supported base. (Bug#8602)
2975 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2977 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2978 to match comment at start of function. This also removes a
2979 GCC warning about overflow in a 32+64-bit port.
2981 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2983 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2984 Reported by Stefan Monnier in
2985 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2986 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2987 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2989 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2990 (EMACS_UINTPTR): Likewise, with uintptr_t.
2992 * lisp.h: Prefer 64-bit EMACS_INT if available.
2993 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2994 on 32-bit hosts that have 64-bit int, so that they can access
2996 However, temporarily disable this change unless the temporary
2997 symbol WIDE_EMACS_INT is defined.
2999 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3001 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3002 This removes an assumption that EMACS_INT and long are the same
3003 width as pointers. The assumption is true for Emacs porting targets
3004 now, but we want to make other targets possible.
3005 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3006 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3007 In the rest of the code, change types of integers that hold casted
3008 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3009 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3010 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3011 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3012 No need to cast type when ORing.
3013 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3014 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3015 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3016 assume EMACS_INT is the same width as char *.
3017 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3018 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3019 Remove no-longer-needed casts.
3020 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3021 (xg_tool_bar_help_callback, xg_make_tool_item):
3022 Use EMACS_INTPTR to hold an integer
3023 that will be cast to void *; this can avoid a GCC warning
3024 if EMACS_INT is not the same width as void *.
3025 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3026 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3027 (current_message_1, set_message_1):
3028 Use a local to convert to proper width without a cast.
3029 * xmenu.c (dialog_selection_callback): Likewise.
3031 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3032 Also, don't assume VALBITS / RAND_BITS is less than 5,
3033 and don't rely on undefined behavior when shifting a 1 left into
3035 * lisp.h (get_random): Change signature to match.
3037 * lread.c (hash_string): Use size_t, not int, for hash computation.
3038 Normally we prefer signed values; but hashing is special, because
3039 it's better to use unsigned division on hash table sizes so that
3040 the remainder is nonnegative. Also, size_t is the natural width
3041 for hashing into memory. The previous code used 'int', which doesn't
3042 retain enough info to hash well into very large tables.
3043 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3045 * dbusbind.c: Don't possibly lose pointer info when converting.
3046 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3047 Use XPNTR rather than XHASH, so that the high-order bits of
3048 the pointer aren't lost when converting through void *.
3050 * eval.c (Fautoload): Don't double-shift a pointer.
3052 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3054 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3056 * gnutls.c (DEF_GNUTLS_FN):
3057 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3059 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3061 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3064 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3066 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3067 New version that can reserve upto 2GB of heap space.
3069 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3071 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3073 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3075 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3076 `gnutls_certificate_set_x509_key_file'.
3078 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3080 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3081 Update dependencies.
3083 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3085 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3086 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3087 Remove unused parameter `fildes'.
3088 * process.c (read_process_output, send_process): Don't pass it.
3090 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3092 Fix previous change: the library cache is defined in w32.c.
3093 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3094 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3096 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3098 Implement dynamic loading of GnuTLS on Windows.
3100 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3101 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3102 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3105 * gnutls.c (Qgnutls_dll): Define.
3106 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3107 (gnutls_*): Declare function pointers.
3108 (init_gnutls_functions): New function to initialize function pointers.
3109 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3110 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3111 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3112 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3113 (emacs_gnutls_write, emacs_gnutls_read)
3114 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3115 (Fgnutls_available_p): New function.
3116 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3117 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3118 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3120 * image.c: Include w32.h.
3121 (Vimage_type_cache): Delete.
3122 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3123 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3124 (w32_delayed_load): Move to w32.c.
3126 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3128 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3129 (w32_delayed_load): Move from image.c. When loading a library, record
3130 its filename in the :loaded-from property of the library id.
3131 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3132 Initialize and staticpro them.
3133 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3135 * process.c: Include lisp.h before w32.h, not after.
3136 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3137 instead of gnutls_record_check_pending.
3139 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3141 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3143 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3144 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3147 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3149 * xterm.c (x_set_frame_alpha): Do not set property on anything
3150 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3152 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3154 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3156 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3158 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3159 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3160 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3161 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3162 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3163 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3164 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3165 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3166 (Qgnutls_bootprop_callbacks_verify): Make static.
3168 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3170 * callproc.c: Indentation fixup.
3172 * sysdep.c (wait_for_termination_1): Make static.
3173 (wait_for_termination, interruptible_wait_for_termination):
3174 Move after wait_for_termination_1.
3176 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3178 * sysdep.c (interruptible_wait_for_termination): New function
3179 which is like wait_for_termination, but allows keyboard
3182 * callproc.c (Fcall_process): Add (:file "file") as an option for
3184 (Fcall_process_region): Ditto.
3186 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3188 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3189 rather than `XVECTOR (FOO)->size'.
3191 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3192 inttypes.h, as a gnulib replacement is used if it not available in
3195 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3197 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3198 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3199 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3201 * coding.c (coding_alloc_by_realloc): Error out if destination
3202 will grow beyond MOST_POSITIVE_FIXNUM.
3203 (decode_coding_emacs_mule): Abort if there isn't enough place in
3204 charbuf for the composition carryover bytes. Reserve an extra
3205 space for up to 2 characters produced in a loop.
3206 (decode_coding_iso_2022): Abort if there isn't enough place in
3207 charbuf for the composition carryover bytes.
3209 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3211 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3212 aborting when %lld or %lll format is passed.
3213 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3214 %llo or %llx format is passed. (Bug#8545)
3216 * window.c (window_scroll_line_based): Use a marker instead of
3217 simple variables to record original value of point. (Bug#7952)
3219 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3220 produced by %s or %c overflows available buffer space. (Bug#8545)
3222 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3224 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3225 (SIZE_MAX): Move defn after all includes, as they might #define it.
3227 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3229 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3231 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3233 * keyboard.c (Qdelayed_warnings_hook): Define.
3234 (command_loop_1): Run `delayed-warnings-hook'
3235 if Vdelayed_warnings_list is non-nil.
3236 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3237 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3239 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3241 * doprnt.c (doprnt): Don't return value smaller than the buffer
3242 size if the message was truncated. (Bug#8545).
3244 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3246 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3247 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3249 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3251 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3253 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3255 * makefile.w32-in: Update dependencies.
3257 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3259 Improve `doprnt' and its usage. (Bug#8545)
3260 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3261 `format_end'. Remove support for %l as a conversion specifier.
3262 Don't use xrealloc. Improve diagnostics when the %l size modifier
3263 is used. Update the commentary.
3265 * eval.c (verror): Simplify calculation of size_t.
3267 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3270 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3272 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3275 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3277 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3278 This makes this file independent of the recent pseudovector change.
3280 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3282 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3284 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3285 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3286 Remove unused local.
3287 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3289 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3290 GCC 4.6.0 optimizes based on type-based alias analysis.
3291 For example, if b is of type struct buffer * and v of type struct
3292 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3293 != &v->size, and therefore "v->size = 1; b->size = 2; return
3294 v->size;" must therefore return 1. This assumption is incorrect
3295 for Emacs, since it type-puns struct Lisp_Vector * with many other
3296 types. To fix this problem, this patch adds a new type struct
3297 vectorlike_header that documents the constraints on layout of vectors
3298 and pseudovectors, and helps optimizing compilers not get fooled
3299 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3300 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3301 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3303 (XSETPVECTYPE): Rewrite in terms of new macro.
3304 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3305 This is a bit clearer, and further avoids the possibility of
3306 undesirable aliasing.
3307 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3308 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3309 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3310 since Lisp_Subr is a special case (no "next" field).
3311 (ASIZE): Now uses header.size rather than size.
3312 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3313 to avoid the hassle of writing XVECTOR (foo)->header.size.
3314 (struct vectorlike_header): New type.
3315 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3316 object, to help avoid aliasing.
3317 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3318 (SUBRP): Likewise, since Lisp_Subr is a special case.
3319 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3320 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3321 (struct Lisp_Hash_Table): Combine first two members into a single
3322 struct vectorlike_header member. All uses of "size" and "next" members
3323 changed to be "header.size" and "header.next".
3324 * buffer.h (struct buffer): Likewise.
3325 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3326 * frame.h (struct frame): Likewise.
3327 * process.h (struct Lisp_Process): Likewise.
3328 * termhooks.h (struct terminal): Likewise.
3329 * window.c (struct save_window_data, struct saved_window): Likewise.
3330 * window.h (struct window): Likewise.
3331 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3332 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3333 * buffer.c (init_buffer_once): Likewise.
3334 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3336 * process.c (Fformat_network_address): Use local var for size,
3339 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3341 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3342 * data.c (atof): Remove decl; no longer used or needed.
3343 (digit_to_number): Move to lread.c.
3344 (Fstring_to_number): Use new string_to_number function, to be
3345 consistent with how the Lisp reader treats infinities and NaNs.
3346 Do not assume that floating-point numbers represent EMACS_INT
3347 without losing information; this is not true on most 64-bit hosts.
3348 Avoid double-rounding errors, by insisting on integers when
3349 parsing non-base-10 numbers, as the documentation specifies.
3350 * lisp.h (string_to_number): New decl, replacing ...
3351 (isfloat_string): Remove.
3352 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3353 (read1): Do not accept +. and -. as integers; this
3354 appears to have been a coding error. Similarly, do not accept
3355 strings like +-1e0 as floating point numbers. Do not report
3356 overflow for integer overflows unless the base is not 10 which
3357 means we have no simple and reliable way to continue.
3358 Break out the floating-point parsing into a new
3359 function string_to_number, so that Fstring_to_number parses
3360 floating point numbers consistently with the Lisp reader.
3361 (digit_to_number): Move here from data.c. Make it static inline.
3362 (E_CHAR, EXP_INT): Remove, replacing with ...
3363 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3364 (string_to_number): New function, replacing isfloat_string.
3365 This function checks for valid syntax and produces the resulting
3366 Lisp float number too. Rework it so that string-to-number
3367 no longer mishandles examples like "1.0e+". Use strtoumax,
3368 so that overflow for non-base-10 numbers is reported only when
3369 there's no portable and simple way to convert to floating point.
3371 * textprop.c (set_text_properties_1): Rewrite for clarity,
3372 and to avoid GCC warning about integer overflow.
3374 * intervals.h (struct interval): Use EMACS_INT for members
3375 where EMACS_UINT might cause problems. See
3376 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3377 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3378 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3380 (offset_intervals): Tell GCC not to worry about length overflow
3381 when negating a negative length.
3383 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3384 (overrun_check_free): Likewise.
3386 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3387 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3390 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3391 (gnutls_make_error): Rename local to avoid shadowing.
3392 (gnutls_emacs_global_deinit): ifdef out; not used.
3393 (Fgnutls_boot): Use const for pointer to readonly storage.
3394 Comment out unused local. Fix pointer signedness problems.
3396 * lread.c (openp): Don't stuff size_t into an 'int'.
3397 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3398 about possible signed overflow.
3400 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3401 (GDK_KEY_g): Don't define if already defined.
3402 (xg_prepare_tooltip): Avoid pointer signedness problem.
3403 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3405 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3406 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3408 * xfns.c (Fx_window_property): Simplify a bit,
3409 to make a bit faster and to avoid GCC 4.6.0 warning.
3410 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3412 * fns.c (internal_equal): Don't assume size_t fits in int.
3414 * alloc.c (compact_small_strings): Tighten assertion a little.
3416 Replace pEd with more-general pI, and fix some printf arg casts.
3417 * lisp.h (pI): New macro, generalizing old pEd macro to other
3418 conversion specifiers. For example, use "...%"pI"d..." rather
3419 than "...%"pEd"...".
3420 (pEd): Remove. All uses replaced with similar uses of pI.
3421 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3422 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3423 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3424 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3425 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3426 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3427 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3429 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3430 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3431 * print.c (safe_debug_print, print_object): Likewise.
3432 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3434 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3435 avoiding the 0 flag, which is not portable.
3436 * process.c (Fmake_network_process): Use pI to avoid cast.
3437 * region-cache.c (pp_cache): Likewise.
3438 * xdisp.c (decode_mode_spec): Likewise.
3439 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3440 behavior on 64-bit hosts with printf arg.
3441 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3442 (x_stop_queuing_selection_requests): Likewise.
3443 (x_get_window_property): Don't truncate byte count to an 'int'
3446 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3447 here, since it parses constructs like leading '-' and spaces,
3448 which are not wanted; and it overflows with large numbers.
3449 Instead, simply match F[0-9]+, which is what is wanted anyway.
3451 * alloc.c: Remove unportable assumptions about struct layout.
3452 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3453 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3454 (allocate_vectorlike, make_pure_vector): Use the new macros,
3455 plus offsetof, to remove unportable assumptions about struct layout.
3456 These assumptions hold on all porting targets that I know of, but
3457 they are not guaranteed, they're easy to remove, and removing them
3458 makes further changes easier.
3460 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3461 This doesn't fix a bug but makes the code clearer.
3462 (string_overrun_cookie): Now const. Use initializers that
3463 don't formally overflow signed char, to avoid warnings.
3464 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3465 can cause Emacs to crash when string overrun checking is enabled.
3466 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3467 multiple of sizeof (EMACS_INT); it need not be, if
3468 alignof(EMACS_INT) < sizeof (EMACS_INT).
3469 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3471 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3473 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3475 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3477 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3478 supposed to be handshaking. (Bug#8556)
3479 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3481 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3483 * lisp.h (Qdebug): List symbol.
3484 * eval.c (Qdebug): Restore global linkage.
3485 * keyboard.c (debug-on-event): New variable.
3486 (handle_user_signal): Break into debugger when debug-on-event
3487 matches the current signal symbol.
3489 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3491 * alloc.c (check_sblock, check_string_bytes)
3492 (check_string_free_list): Convert to standard C.
3494 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3496 * w32.c (emacs_gnutls_push): Fix typo.
3498 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3500 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3501 "cast to pointer from integer of different size".
3503 Improve doprnt and its use in verror. (Bug#8545)
3504 * doprnt.c (doprnt): Document the set of format control sequences
3505 supported by the function. Use SAFE_ALLOCA instead of always
3508 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3509 is one byte too soon. Don't use xrealloc; instead xfree and
3512 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3514 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3517 * gnutls.c: Renamed global_initialized to
3518 gnutls_global_initialized. Added internals for the
3519 :verify-hostname-error, :verify-error, and :verify-flags
3520 parameters of `gnutls-boot' and documented those parameters in the
3521 docstring. Start callback support.
3522 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3523 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3524 on error. Return error code.
3525 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3526 (emacs_gnutls_read): Likewise.
3527 (Fgnutls_boot): Return handshake error code.
3528 (emacs_gnutls_handle_error): New function.
3529 (wsaerror_to_errno): Likewise.
3531 * w32.h (emacs_gnutls_pull): Add prototype.
3532 (emacs_gnutls_push): Likewise.
3534 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3535 (emacs_gnutls_push): Likewise.
3537 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3539 * process.c (wait_reading_process_output): Check if GnuTLS
3540 buffered some data internally if no FDs are set for TLS
3543 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3544 (LIBS): Link to USER_LIBS.
3545 ($(BLD)/gnutls.$(0)): New target.
3547 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3549 * xdisp.c (handle_single_display_spec): Rename the
3550 display_replaced_before_p argument into display_replaced_p, to
3551 make it consistent with the commentary. Fix typos in the
3554 * textprop.c (syms_of_textprop): Remove dead code.
3555 (copy_text_properties): Delete obsolete commentary about an
3556 interface that was deleted long ago. Fix typos in the description
3559 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3560 to changes in oldXMenu/XMenu.h from 2011-04-16.
3561 <menu_help_message, prev_menu_help_message>: Constify.
3562 (IT_menu_make_room): menu->help_text is now `const char **';
3565 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3566 to changes in oldXMenu/XMenu.h from 2011-04-16.
3567 (struct XMenu): Declare `help_text' `const char **'.
3569 * xfaces.c <Qunspecified>: Make extern again.
3571 * syntax.c: Include sys/types.h before including regex.h, as
3574 * doc.c (get_doc_string): Improve the format passed to `error'.
3576 * doprnt.c (doprnt): Improve commentary.
3578 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3580 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3583 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3584 changes in globals.h immediately force recompilation.
3585 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3586 $(CURDIR)/s/ms-w32.h.
3587 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3589 * character.c (Fchar_direction): Function deleted.
3590 (syms_of_character): Don't defsubr it.
3591 <char-direction-table>: Deleted.
3593 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3595 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3596 * doprnt.c: Include limits.h.
3597 (SIZE_MAX): New macro.
3598 (doprnt): Return a size_t value. 2nd arg is now size_t.
3599 Many local variables are now size_t instead of int or unsigned.
3600 Improve overflow protection. Support `l' modifier for integer
3601 conversions. Support %l conversion. Don't assume an EMACS_INT
3602 argument for integer conversions and for %c.
3604 * lisp.h (doprnt): Restore prototype.
3606 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3609 * Makefile.in (base_obj): Add back doprnt.o.
3611 * deps.mk (doprnt.o): Add back prerequisites.
3612 (callint.o): Depend on character.h.
3614 * eval.c (internal_lisp_condition_case): Include the handler
3615 representation in the error message.
3616 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3617 when breaking from the loop.
3619 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3621 * callint.c (Fcall_interactively): When displaying error message
3622 about invalid control letter, pass the character's codepoint, not
3623 a pointer to its multibyte form. Improve display of the character
3624 in octal and display also its hex code.
3626 * character.c (char_string): Use %x to display the (unsigned)
3627 codepoint of an invalid character, to avoid displaying a bogus
3630 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3631 `error', not SYMBOL_NAME itself.
3633 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3634 character arguments to `error'.
3636 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3637 to `error' in error message about FINAL_CHAR argument. Make sure
3638 FINAL_CHAR is a character, and use %c when it is passed as
3639 argument to `error'.
3641 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3643 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3645 * w32.c: Include <time.h>.
3646 (sys_localtime): New function.
3648 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3650 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3652 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3654 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3656 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3659 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3661 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3662 gl_state.e_property when gl_state.object is Qt.
3664 * insdel.c (make_gap_larger): Remove limitation of buffer size
3667 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3669 * xdisp.c (lookup_glyphless_char_display)
3670 (produce_glyphless_glyph): Handle cons cell entry in
3671 glyphless-char-display.
3672 (Vglyphless_char_display): Document it.
3674 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3675 glyphless-char-display.
3677 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3679 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3681 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3683 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3684 definition for no-X builds.
3686 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3688 Static checks with GCC 4.6.0 and non-default toolkits.
3690 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3692 * process.c (keyboard_bit_set): Define only if SIGIO.
3693 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3694 (send_process): Repair possible setjmp clobbering.
3696 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3698 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3700 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3702 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3703 Define only if needed.
3705 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3706 by pacifying GCC about it. Maybe it's time to retire it?
3707 * xfaces.c (USG, __TIMEVAL__): Likewise.
3709 * dispextern.h (struct redisplay_interface): Rename param
3711 * termhooks.h (struct terminal): Likewise.
3712 * xterm.c (xembed_send_message): Likewise.
3714 * insdel.c (make_gap_smaller): Define only if
3715 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3717 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3720 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3721 so that we aren't warned about unused symbols.
3723 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3725 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3727 * xfns.c (x_real_positions): Mark locals as initialized.
3729 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3731 * xterm.c: Fix problems found by static analysis with other toolkits.
3732 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3733 (x_dispatch_event): Declare static if USE_GTK, and
3734 define if USE_GTK || USE_X_TOOLKIT.
3735 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3736 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3737 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3738 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3740 * xmenu.c (menu_help_callback): Pointer type fixes.
3741 Use const pointers when pointing at readonly data. Avoid pointer
3743 (FALSE): Remove unused macro.
3744 (update_frame_menubar): Remove unused decl.
3746 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3748 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3749 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3750 (single_menu_item): Rename local to avoid shadowing.
3752 * keyboard.c (make_lispy_event): Remove unused local var.
3754 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3755 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3757 * bitmaps: Change bitmaps from unsigned char back to the X11
3758 compatible char. Avoid the old compiler warnings about
3759 out-of-range initializers by using, for example, '\xab' rather
3762 * xgselect.c (xgselect_initialize): Check vs interface
3763 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3765 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3767 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3768 to read-only memory.
3770 * fns.c (vector): Remove; this old hack is no longer needed.
3772 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3774 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3776 * xrdb.c (x_load_resources): Omit unused local.
3778 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3779 (x_window): Rename locals to avoid shadowing.
3780 (USG): Use the kludged USG macro, to pacify gcc.
3782 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3783 (x_term_init): Remove local to avoid shadowing.
3785 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3787 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3788 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3790 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3792 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3794 Fix regex.c, syntax.c and friends for buffers > 2GB.
3795 * syntax.h (struct gl_state_s): Declare character position members
3798 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3800 * textprop.c (verify_interval_modification, interval_of):
3801 Declare arguments EMACS_INT.
3803 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3806 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3808 * indent.c (Fvertical_motion): Local variable it_start is now
3811 * regex.c (re_match, re_match_2, re_match_2_internal)
3812 (bcmp_translate, regcomp, regexec, print_double_string)
3813 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3814 (re_compile_pattern, re_exec): Declare arguments and local
3815 variables `size_t' and `ssize_t' and return values `regoff_t', as
3817 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3818 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3819 <compile_stack_type>: `size' and `avail' are now `size_t'.
3821 * regex.h <regoff_t>: Use ssize_t, not int.
3822 (re_search, re_search_2, re_match, re_match_2): Arguments that
3823 specify buffer/string position and length are now ssize_t and
3824 size_t. Return type is regoff_t.
3826 2011-04-16 Ben Key <bkey76@gmail.com>
3828 * nsfont.m: Fixed bugs in ns_get_family and
3829 ns_descriptor_to_entity that were caused by using free to
3830 deallocate memory blocks that were allocated by xmalloc (via
3831 xstrdup). This caused Emacs to crash when compiled with
3832 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3833 --enable-checking=xmallocoverrun). xfree is now used to
3834 deallocate these memory blocks.
3836 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3838 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3840 emacs_write: Accept and return EMACS_INT for sizes.
3841 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3843 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3844 Accept and return EMACS_INT.
3845 (emacs_gnutls_write): Return the number of bytes written on
3847 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3848 (emacs_read, emacs_write): Remove check for negative size, as the
3849 Emacs source code has been audited now.
3850 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3851 (emacs_read, emacs_write): Use it.
3852 * process.c (send_process): Adjust to the new signatures of
3853 emacs_write and emacs_gnutls_write. Do not attempt to store
3854 a byte offset into an 'int'; it might overflow.
3855 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3857 * sound.c: Don't assume sizes fit in 'int'.
3858 (struct sound_device.period_size, alsa_period_size):
3859 Return EMACS_INT, not int.
3860 (struct sound_device.write, vox_write, alsa_write):
3861 Accept EMACS_INT, not int.
3862 (wav_play, au_play): Use EMACS_INT to store sizes and to
3863 record read return values.
3865 2011-04-15 Ben Key <bkey76@gmail.com>
3867 * keyboard.c (Qundefined): Don't declare static since it is used
3869 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3870 static since they are used in nsfont.m.
3872 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3874 * process.c (Qprocessp): Don't declare static.
3875 * lisp.h (Qprocessp): Declare again.
3877 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3879 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3881 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3883 Improve C-level modularity by making more things 'static'.
3885 Don't publish debugger-only interfaces to other modules.
3886 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3887 (verify_bytepos, count_markers): Move decls to the only modules
3889 * region-cache.h (pp_cache): Likewise.
3890 * window.h (check_all_windows): Likewise.
3891 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3893 * sysdep.c (croak): Now static, if
3894 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3895 * syssignal.h (croak): Declare only if not static.
3897 * alloc.c (refill_memory_reserve): Now static if
3898 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3899 * lisp.h (refill_memory_reserve): Declare only if not static.
3901 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3902 Define only if USE_LUCID.
3904 * xrdb.c (x_customization_string, x_rm_string): Now static.
3906 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3907 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3909 * xdisp.c (draw_row_with_mouse_face): Now static.
3910 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3912 * window.h (check_all_windows): Mark externally visible.
3914 * window.c (window_deletion_count): Now static.
3916 * undo.c: Make symbols static if they're not exported.
3917 (last_undo_buffer, last_boundary_position, pending_boundary):
3920 * textprop.c (interval_insert_behind_hooks): Now static.
3921 (interval_insert_in_front_hooks): Likewise.
3923 * term.c: Make symbols static if they're not exported.
3924 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3925 (max_frame_lines, tty_set_terminal_modes):
3926 (tty_reset_terminal_modes, tty_turn_off_highlight):
3927 (get_tty_terminal): Now static.
3928 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3929 * termhooks.h (term_mouse_moveto): Do not declare if
3931 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3932 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3934 * sysdep.c: Make symbols static if they're not exported.
3935 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3937 (sigprocmask_set, full_mask): Remove; unused.
3938 (wait_debugging): Mark as visible.
3939 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3940 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3942 * syntax.c (syntax_temp): Define only if !__GNUC__.
3944 * sound.c (current_sound_device, current_sound): Now static.
3946 * search.c (searchbufs, searchbuf_head): Now static.
3948 * scroll.c (scroll_cost): Remove; unused.
3949 * dispextern.h (scroll_cost): Remove decl.
3951 * region-cache.h (pp_cache): Mark as externally visible.
3953 * process.c: Make symbols static if they're not exported.
3954 (process_tick, update_tick, create_process, chan_process):
3955 (Vprocess_alist, proc_buffered_char, datagram_access):
3956 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3957 (deactivate_process): Mark defn as static, as well as decl.
3958 * lisp.h (create_process): Remove decl.
3959 * process.h (chan_process, Vprocess_alist): Remove decls.
3961 * print.c: Make symbols static if they're not exported.
3962 (print_depth, new_backquote_output, being_printed, print_buffer):
3963 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3964 (print_interval, print_number_index, initial_stderr_stream):
3966 * lisp.h (Fprinc): Remove decl.
3967 (debug_output_compilation_hack): Mark as externally visible.
3969 * sysdep.c (croak): Move decl from here to syssignal.h.
3970 * syssignal.h (croak): Put it here, so the API can be checked when
3971 'croak' is called from dissociate_if_controlling_tty.
3973 * minibuf.c: Make symbols static if they're not exported.
3974 (minibuf_save_list, choose_minibuf_frame): Now static.
3975 * lisp.h (choose_minibuf_frame): Remove decl.
3977 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3979 * lread.c: Make symbols static if they're not exported.
3980 (read_objects, initial_obarray, oblookup_last_bucket_number):
3982 (make_symbol): Remove; unused.
3983 * lisp.h (initial_obarray, make_symbol): Remove decls.
3985 * keyboard.c: Make symbols static if they're not exported.
3986 (single_kboard, recent_keys_index, total_keys, recent_keys):
3987 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3988 (this_single_command_key_start, echoing, last_auto_save):
3989 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3990 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3991 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3992 (Vlispy_mouse_stem, double_click_count):
3994 (force_auto_save_soon): Define only if SIGDANGER.
3995 (ignore_mouse_drag_p): Now static if
3996 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3997 (print_help): Remove; unused.
3998 (stop_character, last_timer_event): Mark as externally visible.
3999 * keyboard.h (ignore_mouse_drag_p): Declare only if
4000 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4001 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4002 * lisp.h (echoing): Remove decl.
4003 (force_auto_save_soon): Declare only if SIGDANGER.
4004 * xdisp.c (redisplay_window): Simplify code, to make it more
4005 obvious that ignore_mouse_drag_p is not accessed if !defined
4006 USE_GTK && !defined HAVE_NS.
4008 * intervals.c: Make symbols static if they're not exported.
4009 (merge_properties_sticky, merge_interval_right, delete_interval):
4011 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4013 * insdel.c: Make symbols static if they're not exported.
4014 However, leave prepare_to_modify_buffer alone. It's never
4015 called from outside this function, but that appears to be a bug.
4016 (combine_after_change_list, combine_after_change_buffer):
4017 (adjust_after_replace, signal_before_change): Now static.
4018 (adjust_after_replace_noundo): Remove; unused.
4019 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4020 (signal_before_change): Remove decls.
4022 * indent.c (val_compute_motion, val_vmotion): Now static.
4024 * image.c: Make symbols static if they're not exported.
4025 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4027 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4028 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4030 * fringe.c (standard_bitmaps): Now static.
4031 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4033 * frame.c: Make symbols static if they're not exported.
4034 (x_report_frame_params, make_terminal_frame): Now static.
4035 (get_frame_param): Now static, unless HAVE_NS.
4036 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4037 (x_get_resource_string): Remove; not used.
4038 * frame.h (make_terminal_frame, x_report_frame_params):
4039 (x_get_resource_string); Remove decls.
4040 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4041 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4043 * font.c, fontset.c: Make symbols static if they're not exported.
4044 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4045 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4046 * font.c (font_close_object): Now static.
4047 * font.h (font_close_object): Remove.
4048 * fontset.c (FONTSET_OBJLIST): Remove.
4049 (free_realized_fontset) #if-0 the body, which does nothing.
4050 (face_suitable_for_char_p): #if-0, as it's never called.
4051 * fontset.h (face_suitable_for_char_p): Remove decl.
4052 * xfaces.c (face_at_string_position):
4053 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4054 since 0 is always ASCII.
4056 * fns.c (weak_hash_tables): Now static.
4058 * fileio.c: Make symbols static if they're not exported.
4059 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4060 (Vwrite_region_annotation_buffers): Now static.
4062 * eval.c: Make symbols static if they're not exported.
4063 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4064 * lisp.h (backtrace_list): Remove decl.
4066 * emacs.c: Make symbols static if they're not exported.
4067 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4068 (fatal_error_code, fatal_error_signal_hook, standard_args):
4070 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4071 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4072 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4073 * lisp.h (fatal_error_signal_hook): Remove decl.
4074 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4076 * editfns.c: Move a (normally-unused) function to its only use.
4077 * editfns.c, lisp.h (get_operating_system_release): Remove.
4078 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4079 worth the hassle of breaking this out.
4081 * xterm.c: Make symbols static if they're not exported.
4082 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4083 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4084 (x_destroy_window, x_delete_display):
4086 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4087 (x_mouse_leave): Remove; unused.
4088 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4089 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4090 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4092 (x_mouse_leave): Declare only if WINDOWSNT.
4093 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4094 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4097 * ftxfont.c: Make symbols static if they're not exported.
4098 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4100 * font.h (ftxfont_driver): Likewise.
4102 * xfns.c: Make symbols static if they're not exported.
4103 (x_last_font_name, x_display_info_for_name):
4104 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4105 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4106 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4107 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4108 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4109 (last_show_tip_args): Now static.
4110 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4111 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4112 (x_screen_planes): Remove; unused.
4113 * dispextern.h (x_screen_planes): Remove decl.
4115 * dispnew.c: Make symbols static if they're not exported.
4116 * dispextern.h (redraw_garbaged_frames, scrolling):
4117 (increment_row_positions): Remove.
4118 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4119 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4121 (redraw_garbaged_frames): Remove; unused.
4123 * xfaces.c: Make symbols static if they're not exported.
4124 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4126 * xterm.h (defined_color): Remove decls.
4127 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4128 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4129 (menu_face_changed_default, defined_color, free_realized_face):
4130 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4131 (ascii_face_of_lisp_face): Remove; unused.
4133 * xdisp.c: Make symbols static if they're not exported.
4134 * dispextern.h (scratch_glyph_row, window_box_edges):
4135 (glyph_to_pixel_coords, set_cursor_from_row):
4136 (get_next_display_element, set_iterator_to_next):
4137 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4138 (show_mouse_face): Remove decls
4139 * frame.h (message_buf_print): Likewise.
4140 * lisp.h (pop_message, set_message, check_point_in_composition):
4142 * xterm.h (set_vertical_scroll_bar): Likewise.
4143 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4144 (message_buf_print, scratch_glyph_row, displayed_buffer):
4145 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4146 (get_next_display_element, show_mouse_face, window_box_edges):
4147 (frame_to_window_pixel_xy, check_point_in_composition):
4148 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4149 (glyph_to_pixel_coords): Remove; unused.
4151 * dired.c (file_name_completion): Now static.
4153 * dbusbind.c (xd_in_read_queued_messages): Now static.
4155 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4156 * data.c (circular_list_error): Remove.
4158 * commands.h (last_point_position, last_point_position_buffer):
4159 (last_point_position_window): Remove decls.
4160 * keyboard.c: Make these variables static.
4162 * coding.h (coding, code_convert_region, encode_coding_gap):
4164 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4165 (iso_code_class, detect_coding, code_convert_region): Now static.
4166 (encode_coding_gap): Remove; unused.
4168 * chartab.c (chartab_chars, chartab_bits): Now static.
4170 * charset.h (charset_iso_8859_1): Remove decl.
4171 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4174 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4175 * ccl.c (Vccl_program_table): Now static.
4176 (check_ccl_update): Remove; unused.
4178 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4179 * category.h: ... from here.
4180 * category.c (check_category_table, set_category_set): Now static.
4182 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4183 * lisp.h: Remove these decls.
4185 * buffer.c (buffer_count): Remove unused var.
4187 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4188 so that it's not optimized away.
4189 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4190 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4191 exported only to the debugger.
4193 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4194 * atimer.h (run_all_atimers): Remove; not exported.
4196 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4197 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4198 was inaccessible from Lisp.
4199 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4200 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4202 alloc.c: Import and export fewer symbols, and remove unused items.
4203 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4205 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4206 it's not optimized away by whole-program optimization.
4207 (message_enable_multibyte, free_misc): Remove.
4208 (catchlist, handlerlist, mark_backtrace):
4209 Declare only if BYTE_MARK_STACK.
4210 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4211 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4212 (message_enable_multibyte): Remove decl.
4213 (free_misc, interval_free_list, float_block, float_block_index):
4214 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4215 (cons_free_list, last_marked_index):
4217 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4218 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4219 (mark_backtrace): Define only if BYTE_MARK_STACK.
4220 * xdisp.c (message_enable_multibyte): Now static.
4222 Declare Lisp_Object Q* variables to be 'static' if not exported.
4223 This makes it easier for human readers (and static analyzers)
4224 to see whether these variables are used from other modules.
4225 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4226 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4227 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4228 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4229 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4230 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4231 * xmenu.c, xselect.c:
4232 Declare Q* vars static if they are not used in other modules.
4233 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4234 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4235 Remove decls of unexported vars.
4236 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4238 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4240 Make Emacs functions such as Fatom 'static' by default.
4241 This makes it easier for human readers (and static analyzers)
4242 to see whether these functions can be called from other modules.
4243 DEFUN now defines a static function. To make the function external
4244 so that it can be used in other C modules, use the new macro DEFUE.
4245 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4246 (Finit_image_library):
4247 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4248 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4249 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4250 Remove decls, since these functions are now static.
4251 (Funintern, Fget_internal_run_time): New decls, since these functions
4252 were already external.
4254 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4255 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4256 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4257 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4258 * keyboard.c, keymap.c, lread.c:
4259 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4260 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4261 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4262 Mark functions with DEFUE instead of DEFUN,
4263 if they are used in other modules.
4264 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4265 decls for now-static functions.
4266 * buffer.h (Fdelete_overlay): Remove decl.
4267 * callproc.c (Fgetenv_internal): Mark as internal.
4268 * composite.c (Fremove_list_of_text_properties): Remove decl.
4269 (Fcomposition_get_gstring): New forward static decl.
4270 * composite.h (Fcomposite_get_gstring): Remove decl.
4271 * dired.c (Ffile_attributes): New forward static decl.
4272 * doc.c (Fdocumntation_property): New forward static decl.
4273 * eval.c (Ffetch_bytecode): New forward static decl.
4274 (Funintern): Remove extern decl; now in .h file where it belongs.
4275 * fileio.c (Fmake_symbolic_link): New forward static decl.
4276 * image.c (Finit_image_library): New forward static decl.
4277 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4278 * intervals.h (Fprevious_property_change):
4279 (Fremove_list_of_text_properties): Remove decls.
4280 * keyboard.c (Fthis_command_keys): Remove decl.
4281 (Fcommand_execute): New forward static decl.
4282 * keymap.c (Flookup_key): New forward static decl.
4283 (Fcopy_keymap): Now static.
4284 * keymap.h (Flookup_key): Remove decl.
4285 * process.c (Fget_process): New forward static decl.
4286 (Fprocess_datagram_address): Mark as internal.
4287 * syntax.c (Fsyntax_table_p): New forward static decl.
4288 (skip_chars): Remove duplicate decl.
4289 * textprop.c (Fprevious_property_change): New forward static decl.
4290 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4292 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4293 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4295 * editfns.c (Fformat): Remove unreachable code.
4297 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4299 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4302 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4304 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4305 when at ZV. (Bug#8487)
4307 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4309 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4311 * keyboard.c (parse_tool_bar_item): Likewise.
4312 * sound.c (sound_cleanup, alsa_close): Likewise.
4313 * termcap.c (tgetent): Likewise.
4314 * xfns.c (x_default_font_parameter): Likewise.
4315 * xsettings.c (read_and_apply_settings): Likewise.
4317 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4318 (overrun_check_free): Protoize.
4320 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4322 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4323 since callers should never pass a negative size.
4324 Change the signature to match that of plain 'read' and 'write'; see
4325 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4326 * lisp.h: Update prototypes of emacs_write and emacs_read.
4328 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4330 * xdisp.c (redisplay_window): Don't try to determine the character
4331 position of the scroll margin if the window start point w->startp
4332 is outside the buffer's accessible region. (Bug#8468)
4334 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4336 Fix write-region and its subroutines for buffers > 2GB.
4337 * fileio.c (a_write, e_write): Modify declaration of arguments and
4338 local variables to support buffers larger than 2GB.
4339 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4341 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4342 argument, local variables, and return value.
4344 * lisp.h: Update prototypes of emacs_write and emacs_read.
4346 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4348 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4350 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4352 Fix more problems found by GCC 4.6.0's static checks.
4354 * xdisp.c (vmessage): Use a better test for character truncation.
4356 * charset.c (load_charset_map): <, not <=, for optimization,
4357 and to avoid potential problems with integer overflow.
4358 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4359 * casetab.c (set_identity, shuffle): Likewise.
4360 * editfns.c (Fformat): Likewise.
4361 * syntax.c (skip_chars): Likewise.
4363 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4364 This also lets GCC 4.6.0 generate slightly better loop code.
4366 * callint.c (Fcall_interactively): <, not <=, for optimization.
4367 (Fcall_interactively): Count the number of arguments produced,
4368 not the number of arguments given. This is simpler and lets GCC
4369 4.6.0 generate slightly better code.
4371 * ftfont.c: Distingish more carefully between FcChar8 and char.
4372 The previous code passed unsigned char * to a functions like
4373 strlen and xstrcasecmp that expect char *, which does not
4374 conform to the C standard.
4375 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4376 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4377 char * when the C standard requires it.
4379 * keyboard.c (read_char): Remove unused var.
4381 * eval.c: Port to Windows vsnprintf (Bug#8435).
4383 (SIZE_MAX): Define if the headers do not.
4384 (verror): Do not give up if vsnprintf returns a negative count.
4385 Instead, grow the buffer. This ports to Windows vsnprintf, which
4386 does not conform to C99. Problem reported by Eli Zaretskii.
4387 Also, simplify the allocation scheme, by avoiding the need for
4388 calling realloc, and removing the ALLOCATED variable.
4390 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4392 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4393 But keep the doprint source code for now, as we might revamp it
4394 and use it again (Bug#8435).
4395 * lisp.h (doprnt): Remove.
4396 * Makefile.in (base_obj): Remove doprnt.o.
4397 * deps.mk (doprnt.o): Remove.
4399 error: Print 32- and 64-bit integers portably (Bug#8435).
4400 Without this change, on typical 64-bit hosts error ("...%d...", N)
4401 was used to print both 32- and 64-bit integers N, which relied on
4403 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4405 * lisp.h (error, verror): Mark as printf-like functions.
4406 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4407 Report overflow in size calculations when allocating printf buffer.
4408 Do not truncate output string at its first null byte.
4409 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4410 Truncate the output at a character boundary, since vsnprintf does not
4412 * charset.c (check_iso_charset_parameter): Convert internal
4413 character to string before calling 'error', since %c now has the
4415 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4416 overflow when computing char to be passed to 'error'. Do not
4417 pass Lisp_Object to 'error'; pass the integer instead.
4418 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4419 formatted with plain %d.
4421 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4423 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4425 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4427 * xterm.c (x_catch_errors): Remove duplicate declaration.
4429 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4431 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4433 2011-04-10 Jim Meyering <meyering@redhat.com>
4435 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4436 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4437 return ssize_t not "int", and use size_t as the buffer length.
4438 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4439 * gnutls.h: Update declarations.
4440 * process.c (read_process_output): Use ssize_t, to match.
4441 (send_process): Likewise.
4443 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4445 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4447 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4449 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4450 Use unsigned char, to match FcChar8 type definition.
4452 * xterm.c (handle_one_xevent):
4453 * xmenu.c (create_and_show_popup_menu):
4454 * xselect.c (x_decline_selection_request)
4455 (x_reply_selection_request): Avoid type-punned deref of X events.
4457 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4459 Fix some uses of `int' instead of EMACS_INT.
4460 * search.c (string_match_1, fast_string_match)
4461 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4462 (scan_buffer, find_next_newline_no_quit)
4463 (find_before_next_newline, search_command, Freplace_match)
4464 (Fmatch_data): Make some `int' variables be EMACS_INT.
4466 * xdisp.c (display_count_lines): 3rd argument and return value now
4467 EMACS_INT. All callers changed.
4468 (pint2hrstr): Last argument is now EMACS_INT.
4470 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4471 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4472 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4473 (decode_coding_utf_16, decode_coding_emacs_mule)
4474 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4475 (decode_coding_ccl, decode_coding_charset)
4476 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4477 (decode_coding_iso_2022, decode_coding_emacs_mule)
4478 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4479 <char_offset, last_offset>: Declare EMACS_INT.
4480 (encode_coding_utf_8, encode_coding_utf_16)
4481 (encode_coding_emacs_mule, encode_invocation_designation)
4482 (encode_designation_at_bol, encode_coding_iso_2022)
4483 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4484 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4486 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4487 (encode_invocation_designation): Last argument P_NCHARS is now
4489 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4490 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4492 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4495 * ccl.c (Fccl_execute_on_string): Declare some variables
4498 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4500 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4502 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4504 * process.c (Fformat_network_address): Doc fix.
4506 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4508 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4510 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4512 * keyboard.c (read_char): Call Lisp function help-form-show,
4513 instead of using internal_with_output_to_temp_buffer.
4514 (Qhelp_form_show): New var.
4515 (syms_of_keyboard): Use DEFSYM macro.
4517 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4519 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4521 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4523 * process.c (Flist_processes): Remove to Lisp.
4524 (list_processes_1): Delete.
4526 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4528 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4530 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4532 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4534 Fix more problems found by GCC 4.6.0's static checks.
4536 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4538 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4540 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4542 * xdisp.c (vmessage): Mark as a printf-like function.
4544 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4546 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4548 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4549 printf-like functions.
4550 (tiff_load): Add casts to remove these marks before passing them
4551 to system-supplied API.
4553 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4555 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4556 This avoids several warnings with gcc -Wstrict-overflow.
4557 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4558 directly, rather than having caller test rule sign. This avoids
4559 some unnecessary tests.
4560 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4561 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4562 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4564 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4565 (xfont_open): Avoid unnecessary tests.
4567 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4569 * composite.h, composite.c (composition_gstring_put_cache):
4570 Use EMACS_INT, not int, for length.
4572 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4573 breaking out part of COMPOSITION_DECODE_RULE.
4574 (COMPOSITION_DECODE_RULE): Use it.
4575 * composite.c (get_composition_id): Remove unused local vars,
4576 by using the new macro.
4578 * textprop.c (set_text_properties_1): Change while to do-while,
4579 since the condition is always true at first.
4581 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4582 (interval_deletion_adjustment): Return unsigned value.
4585 * process.c (list_processes_1, create_pty, read_process_output):
4586 (exec_sentinel): Remove vars that were set but not used.
4587 (create_pty): Remove unnecessary "volatile"s.
4588 (Fnetwork_interface_info): Avoid possibility of int overflow.
4589 (read_process_output): Do adaptive read buffering even if carryover.
4590 (read_process_output): Simplify nbytes computation if buffered.
4592 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4594 * syntax.c (scan_words): Remove var that was set but not used.
4595 (update_syntax_table): Use unsigned instead of int.
4597 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4598 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4599 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4601 * print.c (print_error_message): Avoid int overflow.
4603 * font.c (font_list_entities): Redo for clarity,
4604 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4606 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4607 (font_score): Avoid potential overflow in diff calculation.
4609 * fns.c (substring_both): Remove var that is set but not used.
4610 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4612 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4614 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4615 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4616 can always succeed if overflow has undefined behavior.
4618 * search.c (boyer_moore, wordify): Remove vars set but not used.
4619 (wordify): Omit three unnecessary tests.
4621 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4622 All callers changed. This avoids the need for an unused var.
4624 * casefiddle.c (casify_region): Remove var that is set but not used.
4626 * dired.c (file_name_completion): Remove var that is set but not used.
4628 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4630 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4631 (Finsert_file_contents): Remove unnecessary code checking fd.
4633 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4634 Check for integer overflow on size calculations.
4636 * buffer.c (Fprevious_overlay_change): Remove var that is set
4639 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4640 Remove vars that are set but not used.
4641 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4642 (timer_check_2): Mark vars as initialized.
4644 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4646 * image.c (lookup_image): Remove var that is set but not used.
4647 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4649 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4650 that are set but not used.
4652 * xfns.c (make_invisible_cursor): Don't return garbage
4653 if XCreateBitmapFromData fails (Bug#8410).
4655 * xselect.c (x_get_local_selection, x_handle_property_notify):
4656 Remove vars that are set but not used.
4658 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4659 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4661 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4662 Remove var that is set but not used.
4663 (scroll_bar_windows_size): Now size_t, not int.
4664 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4667 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4668 (map_tty_color) [!defined MSDOS]: Likewise.
4670 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4672 * coding.c: Remove vars that are set but not used.
4673 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4674 All callers changed.
4675 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4676 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4677 (decode_coding_charset): Remove vars that are set but not used.
4679 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4680 that is set but not used.
4682 * print.c (print_object): Remove var that is set but not used.
4684 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4685 The gnulib version avoids calling malloc in the usual case,
4686 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4687 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4688 * filelock.c (current_lock_owner): Likewise.
4689 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4690 * sysdep.c: Include allocator.h, careadlinkat.h.
4691 (emacs_no_realloc_allocator): New static constant.
4692 (emacs_readlink): New function.
4693 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4694 ../lib/careadlinkat.h.
4696 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4698 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4699 first non-nil return value).
4701 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4703 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4704 if not defined (Bug#8403).
4706 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4708 * xdisp.c (display_count_lines): Remove parameter `start',
4709 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4710 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4711 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4712 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4713 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4714 and thereabouts. All callers changed.
4715 (get_per_char_metric): Remove parameter `f', unused since
4716 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4718 2011-04-02 Jim Meyering <meyering@redhat.com>
4720 do not dereference NULL upon failed strdup
4721 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4722 (ns_get_family): Likewise.
4724 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4726 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4728 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4730 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4733 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4735 Add lexical binding.
4737 * window.c (Ftemp_output_buffer_show): New fun.
4738 (Fsave_window_excursion):
4739 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4741 * lread.c (lisp_file_lexically_bound_p): New function.
4742 (Fload): Bind Qlexical_binding.
4743 (readevalloop): Remove `evalfun' arg.
4744 Bind Qinternal_interpreter_environment.
4745 (Feval_buffer): Bind Qlexical_binding.
4746 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4748 (syms_of_lread): Declare `lexical-binding'.
4750 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4752 * keyboard.c (eval_dyn): New fun.
4753 (menu_item_eval_property): Use it.
4755 * image.c (parse_image_spec): Use Ffunctionp.
4757 * fns.c (concat, mapcar1): Accept byte-code-functions.
4759 * eval.c (Fsetq): Handle lexical vars.
4760 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4761 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4762 (FletX, Flet): Obey lexical binding.
4763 (Fcommandp): Handle closures.
4764 (Feval): New `lexical' arg.
4765 (eval_sub): New function extracted from Feval. Use it almost
4766 everywhere where Feval was used. Look up vars in lexical env.
4768 (Ffunctionp): Move from subr.el.
4769 (Ffuncall): Handle closures.
4770 (apply_lambda): Remove `eval_flags'.
4771 (funcall_lambda): Handle closures and new byte-code-functions.
4772 (Fspecial_variable_p): New function.
4773 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4774 but without exporting it to Lisp.
4776 * doc.c (Fdocumentation, store_function_docstring):
4777 * data.c (Finteractive_form): Handle closures.
4779 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4782 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4784 (exec_byte_code): New function extracted from Fbyte_code to handle new
4785 calling convention for byte-code-functions. Add new byte-codes.
4787 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4789 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4791 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4793 * xdisp.c (redisplay_internal): Fix prototype.
4795 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4797 * xdisp.c (SCROLL_LIMIT): New macro.
4798 (try_scrolling): Use it when setting scroll_limit.
4799 Limit scrolling to 100 screen lines.
4800 (redisplay_window): Even when falling back on "recentering",
4801 position point in the window according to scroll-conservatively,
4802 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4804 (try_scrolling): When point is above the window, allow searching
4805 as far as scroll_max, or one screenful, to compute vertical
4806 distance from PT to the scroll margin position. This prevents
4807 try_scrolling from unnecessarily failing when
4808 scroll-conservatively is set to a value slightly larger than the
4809 window height. Clean up the case of PT below the margin at bottom
4810 of window: scroll_max can no longer be INT_MAX. When aggressive
4811 scrolling is in use, don't let point enter the opposite scroll
4812 margin as result of the scroll.
4813 (syms_of_xdisp) <scroll-conservatively>: Document the
4814 threshold of 100 lines for never-recentering scrolling.
4816 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4818 * dispextern.h (move_it_by_lines):
4819 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4820 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4821 (message_log_check_duplicate): Remove parameters `prev_bol' and
4822 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4823 (redisplay_internal): Remove parameter `preserve_echo_area',
4824 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4826 * indent.c (Fvertical_motion):
4827 * window.c (window_scroll_pixel_based, Frecenter):
4828 Don't pass `need_y_p' to `move_it_by_lines'.
4830 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4832 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4833 steal a few bits to be more compact.
4834 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4835 Remove unneeded casts.
4837 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4839 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4841 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4842 binding" message (bug#7967).
4844 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4846 Fix more problems found by GCC 4.6.0's static checks.
4848 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4849 Remove unused local var.
4851 * editfns.c (Fmessage_box): Remove unused local var.
4853 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4854 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4855 Omit unused local vars.
4856 * window.c (shrink_windows): Omit unused local var.
4857 * menu.c (digest_single_submenu): Omit unused local var.
4858 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4859 Omit unused local var.
4861 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4862 Don't assume string length fits in int.
4863 (keyremap_step, read_key_sequence): Use size_t for sizes.
4864 (read_key_sequence): Don't check last_real_key_start redundantly.
4866 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4867 instead of alloca (Bug#8344).
4869 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4870 (Fbacktrace_frame): Don't assume nframes fits in int.
4872 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4874 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4877 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4879 * cm.c (calccost): Turn while-do into do-while, for clarity.
4881 * keyboard.c (syms_of_keyboard): Use the same style as later
4882 in this function when indexing through an array. This also
4883 works around GCC bug 48267.
4885 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4887 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4889 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4890 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4892 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4893 This avoids undefined behavior on integer overflow, and is a bit
4894 more convenient anyway since it is compared to a size_t variable.
4896 Variadic C functions now count arguments with size_t, not int.
4897 This avoids an unnecessary limitation on 64-bit machines, which
4898 caused (substring ...) to crash on large vectors (Bug#8344).
4899 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4900 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4901 All variadic functions and their callers changed accordingly.
4902 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4903 * data.c (arith_driver, float_arith_driver): Likewise.
4904 * editfns.c (general_insert_function): Likewise.
4905 * eval.c (struct backtrace.nargs, interactive_p)
4906 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4907 (funcall_lambda, mark_backtrace): Likewise.
4908 * fns.c (concat): Likewise.
4909 * frame.c (x_set_frame_parameters): Likewise.
4910 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4911 0 if not found, not -1. All callers changed.
4913 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4914 (stack_copy_size): Now size_t, not int.
4915 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4917 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4919 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4920 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4921 All callers changed.
4923 * lisp.h (multibyte_char_to_unibyte):
4924 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4925 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4926 * character.h (CHAR_TO_BYTE8):
4927 * cmds.c (internal_self_insert):
4928 * editfns.c (general_insert_function):
4929 * keymap.c (push_key_description):
4930 * search.c (Freplace_match):
4931 * xdisp.c (message_dolog, set_message_1): All callers changed.
4933 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4935 * keyboard.c (safe_run_hook_funcall): New function.
4936 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4937 don't set the hook to nil, but remove the offending function instead.
4938 (Qcommand_hook_internal): Remove, unused.
4939 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4940 Vcommand_hook_internal.
4942 * eval.c (enum run_hooks_condition): Remove.
4943 (funcall_nil, funcall_not): New functions.
4944 (run_hook_with_args): Call each function through a `funcall' argument.
4945 Remove `cond' argument, now redundant.
4946 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4947 (Frun_hook_with_args_until_failure): Adjust accordingly.
4948 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4950 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4952 * dispextern.h (string_buffer_position): Remove declaration.
4954 * print.c (strout): Remove parameter `multibyte', unused since
4955 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4957 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4958 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4959 All callers changed.
4961 * w32.c (_wsa_errlist): Use braces for struct initializers.
4963 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4964 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4965 All callers changed.
4966 (string_buffer_position): Likewise. Also, make static (it's never
4967 used outside xdisp.c).
4968 (cursor_row_p): Remove parameter `w', unused since
4969 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4970 (decode_mode_spec): Remove parameter `precision', introduced during
4971 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4972 All callers changed.
4974 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4976 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4978 2011-03-27 Anders Lindgren <andlind@gmail.com>
4980 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4981 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4982 (ns_update_auto_hide_menu_bar): New functions.
4983 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4984 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4985 ns_constrain_all_frames.
4986 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4987 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4989 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4991 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4993 2011-03-27 Glenn Morris <rgm@gnu.org>
4995 * syssignal.h: Replace RETSIGTYPE with void.
4996 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4997 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4998 Replace SIGTYPE with void everywhere.
4999 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5000 * s/template.h (SIGTYPE): Remove commented out definition.
5002 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5004 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5005 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5007 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5009 * w32.c (read_unc_volume): Use parameter `henum', instead of
5010 global variable `wget_enum_handle'.
5012 * keymap.c (describe_vector): Remove parameters `indices' and
5013 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5014 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5016 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5018 * keyboard.c (timer_check): Remove parameter `do_it_now',
5019 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5020 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5021 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5023 * keyboard.c (read_char):
5024 * w32menu.c (w32_menu_display_help):
5025 * xmenu.c (show_help_event, menu_help_callback):
5026 Adjust calls to `show_help_echo'.
5028 * gtkutil.c (xg_maybe_add_timer):
5029 * keyboard.c (readable_events):
5030 * process.c (wait_reading_process_output):
5031 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5033 * insdel.c (adjust_markers_gap_motion):
5034 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5035 (gap_left, gap_right): Don't call it.
5037 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5039 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5040 incurred during fontification.
5042 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5044 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5045 (DEFVAR_PER_BUFFER): Don't pass it.
5047 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5048 (scrolling_window): Don't pass it.
5050 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5052 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5054 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5056 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5057 of variables specific to SELinux and computation of `encoded_absname'.
5059 * image.c (XPutPixel): Remove unused variable `height'.
5061 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5063 * unexw32.c (get_section_info): Remove unused variable `section'.
5065 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5066 (system_process_attributes): Remove unused variable `sess'.
5067 (sys_read): Remove unused variable `err'.
5069 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5070 (w32_wnd_proc): Remove unused variable `isdead'.
5071 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5072 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5073 (x_create_tip_frame): Remove unused variable `tem'.
5075 * w32inevt.c (w32_console_read_socket):
5076 Remove unused variable `no_events'.
5078 * w32term.c (x_draw_composite_glyph_string_foreground):
5079 Remove unused variable `width'.
5081 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5083 * w32term.c (x_set_glyph_string_clipping):
5084 Don't pass uninitialized region to CombineRgn.
5086 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5088 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5089 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5090 (Fx_close_connection): Remove unused variable `i'.
5092 * w32font.c (w32font_draw): Return number of glyphs.
5093 (w32font_open_internal): Remove unused variable `i'.
5094 (w32font_driver): Add missing initializer.
5096 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5097 (fill_in_menu): Remove unused variable `items_added'.
5099 * w32term.c (last_mouse_press_frame): Remove static global variable.
5100 (w32_clip_to_row): Remove unused variable `f'.
5101 (x_delete_terminal): Remove unused variable `i'.
5103 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5104 (NOTHING): Remove unused static global variable.
5105 (uniscribe_check_otf): Remove unused variable `table'.
5106 (uniscribe_font_driver): Add missing initializers.
5108 2011-03-23 Julien Danjou <julien@danjou.info>
5110 * term.c (Fsuspend_tty, Fresume_tty):
5111 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5112 * window.c (temp_output_buffer_show):
5113 * insdel.c (signal_before_change):
5114 * frame.c (Fhandle_switch_frame):
5115 * fileio.c (Fdo_auto_save):
5116 * emacs.c (Fkill_emacs):
5117 * editfns.c (save_excursion_restore):
5118 * cmds.c (internal_self_insert):
5119 * callint.c (Fcall_interactively):
5120 * buffer.c (Fkill_all_local_variables):
5121 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5123 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5124 unconditionnaly since it does the check itself.
5126 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5128 Fix more problems found by GCC 4.5.2's static checks.
5130 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5131 the first time through the loop, since we know p0 < p1 then.
5132 This also avoids a gcc -Wstrict-overflow warning.
5134 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5135 leading to a memory leak, possible in functions like
5136 load_charset_map_from_file that can allocate an unbounded number
5137 of objects (Bug#8318).
5139 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5140 that could (at least in theory) be that large.
5142 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5143 This is less likely to overflow, and avoids undefined behavior if
5144 overflow does occur. All callers changed. Use strtoul to scan
5145 for the unsigned long integer.
5146 (pint2hrstr): Simplify and tune code slightly.
5147 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5149 * scroll.c (do_scrolling): Work around GCC bug 48228.
5150 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5152 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5153 This also avoids a warning with gcc -Wstrict-overflow.
5154 (validate_x_resource_name): Simplify count usage.
5155 This also avoids a warning with gcc -Wstrict-overflow.
5157 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5160 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5162 * process.c (Fmake_network_process): Use socklen_t, not int,
5163 where POSIX says socklen_t is required in portable programs.
5164 This fixes a porting bug on hosts like 64-bit HP-UX, where
5165 socklen_t is wider than int (Bug#8277).
5166 (Fmake_network_process, server_accept_connection):
5167 (wait_reading_process_output, read_process_output):
5170 * process.c: Rename or move locals to avoid shadowing.
5171 (list_processes_1, Fmake_network_process):
5172 (read_process_output_error_handler, exec_sentinel_error_handler):
5173 Rename or move locals.
5174 (Fmake_network_process): Define label "retry_connect" only if needed.
5175 (Fnetwork_interface_info): Fix pointer signedness.
5176 (process_send_signal): Add cast to avoid pointer signedness problem.
5177 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5178 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5180 Make tparam.h and terminfo.c consistent.
5181 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5182 Include tparam.h instead, since it declares them.
5183 * cm.h (PC): Remove extern decl; tparam.h now does this.
5184 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5185 * terminfo.c: Include tparam.h, to check interfaces.
5186 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5187 (tparam): Adjust signature to match interface in tparam.h;
5188 this removes some undefined behavior. Check that outstring and len
5189 are zero, which they always are with Emacs.
5190 * tparam.h (PC, BC, UP): New extern decls.
5192 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5193 (xftfont_open): Rename locals to avoid shadowing.
5195 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5196 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5197 (OTF_TAG_SYM): Omit macro if not needed.
5198 (ftfont_list): Remove unused local.
5199 (get_adstyle_property, ftfont_pattern_entity):
5200 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5201 Rename locals to avoid shadowing.
5203 * xfont.c (xfont_list_family): Mark var as initialized.
5205 * xml.c (make_dom): Now static.
5207 * composite.c (composition_compute_stop_pos): Rename local to
5209 (composition_reseat_it): Remove unused locals.
5210 (find_automatic_composition, composition_adjust_point): Likewise.
5211 (composition_update_it): Mark var as initialized.
5212 (find_automatic_composition): Mark vars as initialized,
5213 with a FIXME (Bug#8290).
5215 character.h: Rename locals to avoid shadowing.
5216 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5217 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5218 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5219 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5222 * textprop.c (property_change_between_p): Remove; unused.
5224 * intervals.c (interval_start_pos): Now static.
5226 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5228 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5229 Rename locals to avoid shadowing.
5231 * sound.c (wav_play, au_play, Fplay_sound_internal):
5232 Fix pointer signedness.
5233 (alsa_choose_format): Remove unused local var.
5234 (wav_play): Initialize a variable to 0, to prevent undefined
5235 behavior (Bug#8278).
5237 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5239 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5241 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5242 clobbering (Bug#8298).
5243 * sysdep.c (sys_subshell): Likewise.
5244 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5246 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5247 This should get cleaned up, so that child_setup has the
5248 same signature on all platforms.
5250 * callproc.c (call_process_cleanup): Now static.
5251 (relocate_fd): Rename locals to avoid shadowing.
5253 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5255 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5256 not to be necessary, and produces flickering.
5258 2011-03-20 Glenn Morris <rgm@gnu.org>
5260 * config.in: Remove file.
5262 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5264 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5265 are now in src/globals.h.
5266 (syms_of_minibuf): Remove spurious & from previous change.
5268 2011-03-20 Leo <sdl.web@gmail.com>
5270 * minibuf.c (completing-read-function): New variable.
5271 (completing-read-default): Rename from completing-read.
5272 (completing-read): Call completing-read-function.
5274 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5276 * xfaces.c (Fx_load_color_file):
5277 Read color file from absolute filename (bug#8250).
5279 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5281 * makefile.w32-in: Update dependencies.
5283 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5285 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5287 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5289 Fix more problems found by GCC 4.5.2's static checks.
5291 * process.c (make_serial_process_unwind, send_process_trap):
5292 (sigchld_handler): Now static.
5294 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5295 That way, the code declares only the vars that it needs.
5296 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5297 * s/cygwin.h (PTY_ITERATION): Likewise.
5298 * s/darwin.h (PTY_ITERATION): Likewise.
5299 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5301 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5302 * process.c (allocate_pty): Don't declare stb unless it's needed.
5304 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5305 (CONSTANTLIM): Remove; unused.
5306 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5307 Define only if needed.
5309 * unexelf.c (unexec): Name an expression,
5310 to avoid gcc -Wbad-function-cast warning.
5311 Use a different way to cause a compilation error if anyone uses
5312 n rather than nn, a way that does not involve shadowing.
5313 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5315 * deps.mk (unexalpha.o): Remove; unused.
5317 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5318 * unexec.h: New file.
5319 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5320 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5322 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5323 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5324 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5325 Change as necessary to match prototype in unexec.h.
5327 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5329 (back_comment, skip_chars): Mark vars as initialized.
5331 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5332 Rename locals to avoid shadowing.
5334 * lread.c (read1): Rewrite so as not to use empty "else".
5335 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5337 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5339 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5340 warning when compiling print.c.
5342 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5343 instead of using an uninitialized var.
5344 (font_sort_entities): Mark var as initialized.
5346 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5348 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5349 pointers to constants.
5350 (font_parse_fcname): Remove unused vars.
5351 (font_delete_unmatched): Now static.
5352 (font_get_spec): Remove; unused.
5353 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5354 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5355 Rename or move locals to avoid shadowing.
5357 * fns.c (require_nesting_list, require_unwind): Now static.
5358 (Ffillarray): Rename locals to avoid shadowing.
5360 * floatfns.c (domain_error2): Define only if needed.
5361 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5363 * alloc.c (mark_backtrace): Move decl from here ...
5364 * lisp.h: ... to here, so that it can be checked.
5366 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5367 (Fdefvar): Rewrite so as not to use empty "else".
5368 (lisp_indirect_variable): Name an expression,
5369 to avoid gcc -Wbad-function-cast warning.
5370 (Fdefvar): Rename locals to avoid shadowing.
5372 * callint.c (quotify_arg, quotify_args): Now static.
5373 (Fcall_interactively): Rename locals to avoid shadowing.
5374 Use const pointer when appropriate.
5376 * lisp.h (get_system_name, get_operating_system_release):
5377 Move decls here, to check interfaces.
5378 * process.c (get_operating_system_release): Move decl to lisp.h.
5379 * xrdb.c (get_system_name): Likewise.
5380 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5381 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5382 some of which prompt warnings from gcc -Wbad-function-cast.
5383 (Fformat_time_string, Fencode_time, Finsert_char):
5384 (Ftranslate_region_internal, Fformat):
5385 Rename or remove local vars to avoid shadowing.
5386 (Ftranslate_region_internal): Mark var as initialized.
5388 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5391 * lisp.h (eassert): Check that the argument compiles, even if
5392 ENABLE_CHECKING is not defined.
5394 * data.c (Findirect_variable): Name an expression, to avoid
5395 gcc -Wbad-function-cast warning.
5396 (default_value, arithcompare, arith_driver, arith_error): Now static.
5397 (store_symval_forwarding): Rename local to avoid shadowing.
5398 (Fmake_variable_buffer_local, Fmake_local_variable):
5399 Mark variables as initialized.
5400 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5402 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5403 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5404 Rename locals to avoid shadowing.
5405 (mark_stack): Move local variables into the #ifdef region where
5407 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5408 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5410 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5411 (GC_STRING_CHARS): Remove; not used.
5412 (Fmemory_limit): Cast sbrk's returned value to char *.
5414 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5415 avoids undefined behavior in theory.
5417 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5419 Use functions, not macros, for up- and down-casing (Bug#8254).
5420 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5421 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5422 to use the following functions instead of these macros.
5423 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5424 EMACS_INT, since callers assume the returned value fits in int.
5425 (upcase1): Likewise, for UPCASE_TABLE.
5426 (uppercasep, lowercasep, upcase): New static inline functions.
5427 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5428 the race-condition problem in the old DOWNCASE.
5430 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5431 Rename locals to avoid shadowing.
5432 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5433 (regex_compile, re_search_2, re_match_2_internal):
5434 Remove unused local vars.
5435 (FREE_VAR): Rewrite so as not to use empty "else",
5436 which gcc can warn about.
5437 (regex_compile, re_match_2_internal): Mark locals as initialized.
5438 (RETALLOC_IF): Define only if needed.
5439 (WORDCHAR_P): Likewise. This one is never needed, but is used
5440 only in a comment talking about a compiler bug, so put inside
5441 the #if 0 of that comment.
5442 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5443 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5446 * search.c (boyer_moore): Rename locals to avoid shadowing.
5447 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5448 (PREV_CHAR_BOUNDARY): Likewise.
5450 * search.c (simple_search): Remove unused var.
5452 * dired.c (compile_pattern): Move decl from here ...
5453 * lisp.h: ... to here, so that it can be checked.
5454 (struct re_registers): New forward decl.
5456 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5458 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5460 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5461 Rename locals to avoid shadowing.
5462 (Fvertical_motion): Mark locals as initialized.
5464 * casefiddle.c (casify_object, casify_region): Now static.
5465 (casify_region): Mark local as initialized.
5467 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5469 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5470 New macros, so that the caller can use some names other than
5471 gcpro1, gcpro2, etc.
5472 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5474 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5475 argument, for consistency with GCPRO2_VAR, etc: it is now the
5476 prefix of the variable, not the variable itself. All uses
5478 * dired.c (directory_files_internal, file_name_completion):
5479 Rename locals to avoid shadowing.
5481 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5482 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5483 dired.c's scmp function, had undefined behavior.
5484 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5485 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5486 * buffer.h: ... to here, because these macros use current_buffer,
5487 and the new implementation with inline functions needs to have
5488 current_buffer in scope now, rather than later when the macros
5490 (downcase, upcase1): New static inline functions.
5491 (DOWNCASE, UPCASE1): Reimplement using these functions.
5492 This avoids undefined behavior in expressions like
5493 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5494 from race conditions in accessing the global variables
5495 case_temp1 and case_temp2.
5496 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5497 * lisp.h (case_temp1, case_temp2): Remove their decls.
5498 * character.h (ASCII_CHAR_P): Move from here ...
5499 * lisp.h: ... to here, so that the inline functions mentioned
5502 * dired.c (directory_files_internal_unwind): Now static.
5504 * fileio.c (file_name_as_directory, directory_file_name):
5505 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5507 (file_name_as_directory): Use const pointers when appropriate.
5508 (Fexpand_file_name): Likewise. In particular, newdir might
5509 point at constant storage, so make it a const pointer.
5510 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5511 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5513 (Fset_file_times, Finsert_file_contents, auto_save_error):
5514 Rename locals to avoid shadowing.
5516 * minibuf.c (choose_minibuf_frame_1): Now static.
5517 (Ftry_completion, Fall_completions): Rename or remove locals
5520 * marker.c (bytepos_to_charpos): Remove; unused.
5522 * lisp.h (verify_bytepos, count_markers): New decls,
5523 so that gcc does not warn that these functions aren't declared.
5525 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5526 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5527 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5528 (copy_text): Remove unused local var.
5530 * filelock.c (within_one_second): Now static.
5531 (lock_file_1): Rename local to avoid shadowing.
5533 * buffer.c (fix_overlays_before): Mark locals as initialized.
5534 (fix_start_end_in_overlays): Likewise. This function should be
5535 simplified by using pointers-to-pointers, but that's a different
5537 (switch_to_buffer_1): Now static.
5538 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5539 (report_overlay_modification): Rename locals to avoid shadowing.
5541 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5542 Fix pointer signedness issue.
5543 (sys_subshell): Mark local as volatile if checking for lint,
5544 to suppress a gcc -Wclobbered warning that does not seem to be right.
5545 (MAXPATHLEN): Define only if needed.
5547 * process.c (serial_open, serial_configure): Move decls from here ...
5548 * systty.h: ... to here, so that they can be checked.
5550 * fns.c (get_random, seed_random): Move extern decls from here ...
5551 * lisp.h: ... to here, so that they can be checked.
5553 * sysdep.c (reset_io): Now static.
5554 (wait_for_termination_signal): Remove; unused.
5556 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5557 (copy_keymap_item, append_key, push_text_char_description):
5559 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5560 (DENSE_TABLE_SIZE): Remove; unused.
5561 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5562 (describe_map_tree):
5563 Rename locals to avoid shadowing.
5565 * keyboard.c: Declare functions static if they are not used elsewhere.
5566 (echo_char, echo_dash, cmd_error, top_level_2):
5567 (poll_for_input, handle_async_input): Now static.
5568 (read_char, kbd_buffer_get_event, make_lispy_position):
5569 (make_lispy_event, make_lispy_movement, apply_modifiers):
5570 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5571 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5572 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5573 (read_key_sequence, read_char): Mark locals as initialized.
5574 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5576 * keyboard.h (make_ctrl_char): New decl.
5577 (mark_kboards): Move decl here ...
5578 * alloc.c (mark_kboards): ... from here.
5580 * lisp.h (force_auto_save_soon): New decl.
5582 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5583 (DEFINE_DUMMY_FUNCTION): New macro.
5584 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5586 (main): Add casts to avoid warnings
5587 if GCC considers string literals to be constants.
5589 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5591 * dbusbind.c: Pointer signedness fixes.
5592 (xd_signature, xd_append_arg, xd_initialize):
5593 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5594 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5595 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5596 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5598 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5599 if GCC considers string literals to be constants.
5600 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5602 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5604 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5605 (print_preprocess, print_object): New macro to fix last change.
5607 * print.c (print_preprocess): Don't forget font objects.
5609 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5611 * emacs.c (USAGE3): Doc fixes.
5613 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5615 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5618 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5620 * lisp.h (VWindow_system, Qfile_name_history):
5621 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5622 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5623 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5625 * w32select.c: Don't #include "keyboard.h".
5626 (run_protected): Add extern declaration for waiting_for_input.
5628 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5629 * w32console.c (detect_input_pending, read_input_pending)
5630 (encode_terminal_code):
5631 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5632 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5633 (w32_system_caret_y, Qfile_name_history):
5634 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5635 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5636 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5637 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5638 * w32proc.c (Qlocal, report_file_error):
5639 * w32term.c (Vwindow_system, updating_frame):
5640 * w32uniscribe.c (initialized, uniscribe_font_driver):
5641 Remove unneeded extern declarations.
5643 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5645 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5647 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5649 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5650 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5651 These macros can no longer be used for assignment.
5653 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5654 Assign struct members directly, instead of using BUF_BEGV etc.
5655 (record_buffer_markers, fetch_buffer_markers): New functions for
5656 recording and fetching special buffer markers.
5657 (set_buffer_internal_1, set_buffer_temp): Use them.
5659 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5661 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5663 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5664 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5666 * xdisp.c (hscroll_window_tree):
5667 (reconsider_clip_changes): Use PT instead of BUF_PT.
5669 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5671 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5672 $(EMACS_ROOT)/lib/intprops.h.
5674 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5676 Fix more problems found by GCC 4.5.2's static checks.
5678 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5679 to unsigned char * to avoid compiler diagnostic.
5680 (xg_free_frame_widgets): Make it clear that a local variable is
5681 needed only if USE_GTK_TOOLTIP.
5682 (gdk_window_get_screen): Make it clear that this macro is needed
5683 only if USE_GTK_TOOLTIP.
5684 (int_gtk_range_get_value): New function, which avoids a diagnostic
5685 from gcc -Wbad-function-cast.
5686 (xg_set_toolkit_scroll_bar_thumb): Use it.
5687 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5688 diagnostic from gcc -Wbad-function-cast.
5689 (get_utf8_string, xg_get_file_with_chooser):
5690 Rename locals to avoid shadowing.
5691 (create_dialog): Move locals to avoid shadowing.
5693 * xgselect.c (xg_select): Remove unused var.
5695 * image.c (four_corners_best): Mark locals as initialized.
5696 (gif_load): Initialize transparent_p to zero (Bug#8238).
5697 Mark another local as initialized.
5698 (my_png_error, my_error_exit): Mark with NO_RETURN.
5700 * image.c (clear_image_cache): Now static.
5701 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5702 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5703 (x_edge_detection): Remove unnecessary cast that
5704 gcc -Wbad-function-cast diagnoses.
5705 (gif_load): Fix pointer signedness.
5706 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5707 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5709 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5711 Improve quality of tests for time stamp overflow.
5712 For example, without this patch (encode-time 0 0 0 1 1
5713 1152921504606846976) returns the obviously-bogus value (-948597
5714 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5715 reports time overflow. See
5716 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5717 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5718 * editfns.c: Include limits.h and intprops.h.
5719 (TIME_T_MIN, TIME_T_MAX): New macros.
5720 (time_overflow): Move earlier, to before first use.
5721 (hi_time, lo_time): New functions, for an accurate test for
5723 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5724 (Fget_internal_run_time): Don't assume time_t fits in int.
5725 (make_time): Use list2 instead of Fcons twice.
5726 (Fdecode_time): More accurate test for out-of-range times.
5727 (check_tm_member): New function.
5728 (Fencode_time): Use it, to test for out-of-range times.
5729 (lisp_time_argument): Don't rely on undefined left-shift and
5730 right-shift behavior when checking for time stamp overflow.
5732 * editfns.c (time_overflow): New function, refactoring common code.
5733 (Fformat_time_string, Fdecode_time, Fencode_time):
5734 (Fcurrent_time_string): Use it.
5736 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5737 * dired.c (make_time): Move to ...
5738 * editfns.c (make_time): ... here.
5739 * systime.h: Note the move.
5741 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5743 * fringe.c (update_window_fringes): Remove unused variables.
5745 * unexmacosx.c (copy_data_segment): Also copy __got section.
5748 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5750 * termcap.c [MSDOS]: Include "msdos.h".
5751 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5752 Constify `char *' arguments and their references according to
5753 prototypes in tparam.h.
5755 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5757 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5758 Adapt all references accordingly.
5760 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5762 2011-03-11 Tom Tromey <tromey@redhat.com>
5764 * buffer.c (syms_of_buffer): Remove obsolete comment.
5766 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5768 * termhooks.h (encode_terminal_code): Declare prototype.
5770 * msdos.c (encode_terminal_code): Don't declare prototype.
5772 * term.c (encode_terminal_code): Now external again, used by
5773 w32console.c and msdos.c.
5775 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5776 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5778 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5780 Fix some minor problems found by GCC 4.5.2's static checks.
5782 * fringe.c (update_window_fringes): Mark locals as initialized
5784 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5786 * alloc.c (mark_fringe_data): Move decl from here ...
5787 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5788 to check its interface.
5789 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5791 * fontset.c (free_realized_fontset): Now static.
5792 (Fset_fontset_font): Rename local to avoid shadowing.
5793 (fontset_font): Mark local as initialized.
5794 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5796 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5798 * xselect.c (x_disown_buffer_selections): Remove; not used.
5799 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5800 (x_own_selection, Fx_disown_selection_internal): Rename locals
5802 (x_handle_dnd_message): Remove local to avoid shadowing.
5804 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5805 so that the caller can use some name other than gcpro1.
5806 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5807 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5808 (Fx_backspace_delete_keys_p):
5809 Use them to avoid shadowing, and rename vars to avoid shadowing.
5810 (x_decode_color, x_set_name, x_window): Now static.
5811 (Fx_create_frame): Add braces to silence GCC warning.
5812 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5813 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5814 Remove unused locals.
5815 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5816 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5817 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5820 * xterm.h (x_mouse_leave): New decl.
5822 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5823 Remove unused functions.
5824 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5825 (x_calc_absolute_position): Now static.
5826 (XTread_socket): Don't define label "out" unless it's used.
5827 Don't declare local "event" unless it's used.
5828 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5829 unless they are used.
5830 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5831 (x_fatal_error_signal): Remove; not used.
5832 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5833 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5834 (x_error_catcher, x_connection_closed, x_error_handler):
5835 (x_error_quitter, xembed_send_message, x_iconify_frame):
5836 (my_log_handler): Rename locals to avoid shadowing.
5837 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5838 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5840 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5841 Rename or move locals to avoid shadowing.
5842 (tty_defined_color, merge_face_heights): Now static.
5843 (free_realized_faces_for_fontset): Remove; not used.
5844 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5845 does not deduce is never used uninitialized.
5846 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5847 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5849 * terminal.c (store_terminal_param): Now static.
5851 * xmenu.c (menu_highlight_callback): Now static.
5852 (set_frame_menubar): Remove unused local.
5853 (xmenu_show): Rename parameter to avoid shadowing.
5854 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5855 since they might point to immutable storage.
5856 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5857 since it's unused otherwise.
5859 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5860 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5861 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5862 avoids a gcc -Wuninitialized diagnostic.
5863 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5864 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5865 does not deduce are never used uninitialized.
5867 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5869 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5870 * window.c (window_loop, size_window):
5871 (run_window_configuration_change_hook, enlarge_window): Likewise.
5873 * window.c (display_buffer): Now static.
5874 (size_window): Mark variables that gcc -Wuninitialized
5875 does not deduce are never used uninitialized.
5876 * window.h (check_all_windows): New decl, to forestall
5877 gcc -Wmissing-prototypes diagnostic.
5878 * dispextern.h (bidi_dump_cached_states): Likewise.
5880 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5882 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5884 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5885 and to avoid gcc -Wuninitialized warning.
5886 (load_charset_map): Mark variables that gcc -Wuninitialized
5887 does not deduce are never used uninitialized.
5888 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5890 * coding.c (coding_set_source, coding_set_destination):
5891 Use "else { /* comment */ }" rather than "else /* comment */;"
5892 for clarity, and to avoid gcc -Wempty-body warning.
5893 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5894 a block, when the outer 'i' will do.
5895 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5896 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5897 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5898 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5899 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5900 Rename locals to avoid shadowing.
5901 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5902 * coding.c (emacs_mule_char, encode_invocation_designation):
5903 Now static, since they're not used elsewhere.
5904 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5905 (decode_coding_object, encode_coding_object, detect_coding_system):
5906 (decode_coding_emacs_mule): Mark variables that gcc
5907 -Wuninitialized does not deduce are never used uninitialized.
5908 (detect_coding_iso_2022): Initialize a local variable that might
5909 be used uninitialized. Leave a FIXME because it's not clear that
5910 this initialization is needed. (Bug#8211)
5911 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5912 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5913 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5914 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5915 Remove unused macros.
5917 * category.c (hash_get_category_set): Remove unused local var.
5918 (copy_category_table): Now static, since it's not used elsewhere.
5919 * character.c (string_count_byte8): Likewise.
5921 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5922 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5924 * chartab.c (copy_sub_char_table): Now static, since it's not used
5926 (sub_char_table_ref_and_range, char_table_ref_and_range):
5927 Rename locals to avoid shadowing.
5928 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5930 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5931 (BIDI_BOB): Remove unused macro.
5933 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5934 deduce are never used uninitialized.
5935 * term.c (encode_terminal_code): Likewise.
5937 * term.c (encode_terminal_code): Now static. Remove unused local.
5939 * tparam.h: New file.
5940 * term.c, tparam.h: Include it.
5941 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5942 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5943 Move these decls to tparam.h, and make them agree with what
5944 is actually in tparam.c. The previous trick of using incompatible
5945 decls in different modules does not conform to the C standard.
5946 All callers of tparam changed to use tparam's actual API.
5947 * tparam.c (tparam1, tparam, tgoto):
5948 Use const pointers where appropriate.
5950 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5951 * cm.h (struct cm): Likewise.
5952 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5953 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5954 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5955 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5956 (turn_on_face, init_tty): Likewise.
5957 * termchar.h (struct tty_display_info): Likewise.
5959 * term.c (term_mouse_position): Rename local to avoid shadowing.
5961 * alloc.c (mark_ttys): Move decl from here ...
5962 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5964 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5966 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5968 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5970 * search.c (compile_pattern_1): Remove argument regp, unused since
5971 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5972 (compile_pattern): Don't pass it.
5974 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5976 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5977 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5979 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5981 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5983 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5984 gdk_window_get_screen, gdk_window_get_geometry,
5985 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5986 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5987 (xg_get_pixbuf_from_pixmap): New function.
5988 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5989 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5990 Call xg_get_pixbuf_from_pixmap instead of
5991 gdk_pixbuf_get_from_drawable.
5992 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5993 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5994 (xg_check_special_colors): Use GtkStyleContext and its functions
5996 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5997 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5998 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5999 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6000 Call gtk_widget_get_preferred_size.
6001 (xg_frame_resized): gdk_window_get_geometry only takes 5
6003 (xg_win_to_widget, xg_event_is_for_menubar):
6004 Call gdk_x11_window_lookup_for_display.
6005 (xg_set_widget_bg): New function.
6006 (delete_cb): New function.
6007 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6008 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6009 (xg_set_background_color): Call xg_set_widget_bg.
6010 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6011 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6012 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6013 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6015 (update_frame_tool_bar): Call gtk_widget_hide.
6016 (xg_initialize): Use GDK_KEY_g.
6018 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6020 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6022 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6023 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6024 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6026 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6028 * w32xfns.c (select_palette): Check success of RealizePalette against
6029 GDI_ERROR, not zero.
6031 See ChangeLog.11 for earlier changes.
6037 Copyright (C) 2011 Free Software Foundation, Inc.
6039 This file is part of GNU Emacs.
6041 GNU Emacs is free software: you can redistribute it and/or modify
6042 it under the terms of the GNU General Public License as published by
6043 the Free Software Foundation, either version 3 of the License, or
6044 (at your option) any later version.
6046 GNU Emacs is distributed in the hope that it will be useful,
6047 but WITHOUT ANY WARRANTY; without even the implied warranty of
6048 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6049 GNU General Public License for more details.
6051 You should have received a copy of the GNU General Public License
6052 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.