Fix minor problems found by static checking.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1692ae2d 12011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2
5a9c4332
PE
3 Fix minor problems found by static checking.
4 * chartab.c (char_table_set_range, map_sub_char_table)
5 (uniprop_table_uncompress): Remove unused locals.
6 (uniprop_table): Now static.
7 * composite.c (_work_char): Remove unused static var.
8 * gtkutil.c (qttip_cb): Remove stray no-effect statement.
9
8a6ebd58 10 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
11 sigprocmask is portable only for single-threaded applications, and
12 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
13 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
14 (LIBES): Use it.
15 * callproc.c (Fcall_process):
16 * process.c (create_process):
17 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
18 Use pthread_sigmask, not sigprocmask.
123403e4 19
1b854618
JD
202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
21
22 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
23 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
24 wrong (Bug#8591).
25
3fe4b549
JD
262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
27
0ce7e563
JD
28 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
29 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
30 (xg_hide_tooltip): Fix comment.
31
3fe4b549
JD
32 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
33 in registerServicesMenuSendTypes.
34 (validRequestorForSendType): Don't check ns_return_types.
35
36 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
37 ns_return_type.
38
5df75e47
JR
392011-07-08 Jason Rumney <jasonr@gnu.org>
40
41 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
42 frame struct members of non-existent frames (Bug#6284).
43
699c10bd
JD
442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
45
4393663b
JD
46 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
47 variable firstTime not needed on OSX >= 10.6.
48 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
49 >= 10.5. Use setKnobProportion, setDoubleValue.
50
51 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
52 (MAC_OS_X_VERSION_10_5): Define if not defined.
53 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
54 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
55 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
56
57 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
58 cString and lossyCString on OSX >= 10.4
59
60 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
61 sizeToFit on OSX >= 10.2.
62
63 * nsimage.m (allocInitFromFile): Don't use deprecated method
64 bestRepresentationForDevice on OSX >= 10.6.
65
66 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
67 to avoid warning.
68
69 * emacs.c: Declare unexec_init_emacs_zone.
70
a63e0781
JD
71 * nsgui.h: Fix compiler warning about gnulib redefining verify.
72
699c10bd
JD
73 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
74
75 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
76 on svcsMenu (Bug#8842).
77
78 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
79 ns_return_types.
80 (Fns_list_services): Just return Qnil on 10.6, code not working there.
81
82 * nsterm.m (QUTF8_STRING): Declare.
83 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
84 (validRequestorForSendType): Return type is (id).
85 Change indexOfObjectIdenticalTo to indexOfObject.
86 Check if we have local selection before returning self (Bug#8842).
87 (writeSelectionToPasteboard): Put local selection into paste board
88 if we have a local selection (Bug#8842).
89 (syms_of_nsterm): DEFSYM QUTF8_STRING.
90
91 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
92 (ns_get_local_selection): Declare.
93
54e10184
LMI
942011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
95
9888ff71
LMI
96 * keymap.c (describe_map_tree): Don't insert a double newline at
97 the end of the buffer (bug#1169) and return whether we inserted
98 something.
99
54e10184
LMI
100 * callint.c (Fcall_interactively): Change "reading args" to
101 "providing args" to try to clarify what it does (bug#1010).
102
15fa4783
KH
1032011-07-07 Kenichi Handa <handa@m17n.org>
104
105 * composite.c (composition_compute_stop_pos): Ignore a static
106 composition starting before CHARPOS (Bug#8915).
107
108 * xdisp.c (handle_composition_prop): Likewise.
109
a8815b00
EZ
1102011-07-07 Eli Zaretskii <eliz@gnu.org>
111
112 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
113 (Bug#9015)
114
ef7b981d 1152011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
116
117 * character.h (unicode_category_t): New enum type.
118
119 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
120 (Qchar_code_property_table): New variable.
121 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
122 (UNIPROP_COMPRESSED_FORM_P): New macros.
123 (char_table_ascii): Uncompress the compressed values.
124 (sub_char_table_ref): New arg is_uniprop. Callers changed.
125 Uncompress the compressed values.
126 (sub_char_table_ref_and_range): Likewise.
127 (char_table_ref_and_range): Uncompress the compressed values.
128 (sub_char_table_set): New arg is_uniprop. Callers changed.
129 Uncompress the compressed values.
130 (sub_char_table_set_range): Args changed. Callers changed.
131 (char_table_set_range): Adjuted for the above change.
132 (map_sub_char_table): Delete args default_val and parent. Add arg
133 top. Give decoded values to a Lisp function.
134 (map_char_table): Adjusted for the above change. Give decoded
135 values to a Lisp function. Gcpro more variables.
136 (uniprop_table_uncompress)
137 (uniprop_decode_value_run_length): New functions.
138 (uniprop_decoder, uniprop_decoder_count): New variables.
139 (uniprop_get_decoder, uniprop_encode_value_character)
140 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
141 New functions.
142 (uniprop_encoder, uniprop_encoder_count): New variables.
143 (uniprop_get_encoder, uniprop_table)
144 (Funicode_property_table_internal, Fget_unicode_property_internal)
145 (Fput_unicode_property_internal): New functions.
146 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
147 Sunicode_property_table_internal, Sget_unicode_property_internal,
148 and Sput_unicode_property_internal. Defvar_lisp
149 char-code-property-alist.
150
151 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
152 Vunicode_category_table.
153
154 * font.c (font_range): Adjusted for the change of
155 Vunicode_category_table.
156
76b397fb
DN
1572011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
158
159 * m/iris4d.h: Remove file, move contents ...
160 * s/irix6-5.h: ... here.
161
22b4128e
PE
1622011-07-06 Paul Eggert <eggert@cs.ucla.edu>
163
164 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
165 * alloc.c (mark_buffer):
166 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
167 (clone_per_buffer_values): Don't assume that
22b4128e
PE
168 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
169 This isn't true in general, and it's particularly not true
170 if Emacs is configured with --with-wide-int.
171 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
172 New macros, used in the buffer.c change.
173
869795d6
JD
1742011-07-05 Jan Djärv <jan.h.d@swipnet.se>
175
176 * xsettings.c: Use both GConf and GSettings if both are available.
177 (store_config_changed_event): Add comment.
178 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
179 (store_tool_bar_style_changed): New functions.
180 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
181 (struct xsettings): Move font inside HAVE_XFT.
182 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
183 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
184 Move inside HAVE_XFT.
185 (something_changed_gsettingsCB): Renamed from something_changedCB.
186 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
187 also.
188 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
189 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
190 (something_changed_gconfCB): Renamed from something_changedCB.
191 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
192 (parse_settings): Move check for font inside HAVE_XFT.
193 (read_settings, apply_xft_settings): Add comment.
194 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
195 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
196 call store_font_name_changed.
197 (xft_settings_event): Add comment.
198 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
199 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
200 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
201 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
202 (xsettings_initialize): Call init_gsettings last.
203 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
204 comment.
205
d8ed26bd
PE
2062011-07-05 Paul Eggert <eggert@cs.ucla.edu>
207
208 Random fixes. E.g., (random) never returned negative values.
209 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
210 subseconds part to the entropy, as that's a bit more random.
211 Prefer signed to unsigned, since the signedness doesn't matter and
212 in general we prefer signed. When given a limit, use a
213 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
214 latter isn't right if USE_2_TAGS_FOR_INTS.
215 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
216 not 0..VALMASK. Don't discard "excess" bits that random () returns.
217
cabf1cac
SM
2182011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
219
220 * textprop.c (text_property_stickiness):
221 Obey Vtext_property_default_nonsticky.
222 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
223 * w32fns.c (syms_of_w32fns):
224 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
225
6e9b2be9
PE
2262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
227
228 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
229 This is more efficient than Ffile_directory_p and avoids a minor race.
230
90186c68
LMI
2312011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
232
7c301272
LMI
233 * buffer.c (Foverlay_put): Say what the return value is
234 (bug#7835).
235
c4f2d8d4
LMI
236 * fileio.c (barf_or_query_if_file_exists): Check first if the file
237 is a directory before asking whether to use the file name
238 (bug#7564).
ad637907
LMI
239 (barf_or_query_if_file_exists): Make the "File is a directory"
240 error be more correct.
c4f2d8d4 241
90186c68
LMI
242 * fns.c (Frequire): Remove the mention of the .gz files, since
243 that's installation-specific, but keep the mention of
244 `get-load-suffixes'.
245
da64016e
PE
2462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
247
248 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
249 Report string overflow if the output is too long.
250
7d47b580
JB
2512011-07-04 Juanma Barranquero <lekktu@gmail.com>
252
a555cb87
JB
253 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
254 (syms_of_gnutls): Remove duplicate DEFSYM for
255 Qgnutls_bootprop_verify_hostname_error, an error for
256 Qgnutls_bootprop_verify_error (which is no longer used).
257
7d47b580
JB
258 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
259 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
260 Also (re)move comments that are misplaced or no longer relevant.
261
1e49bfab
LMI
2622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
263
264 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
265
1485f4c0
CY
2662011-07-03 Chong Yidong <cyd@stupidchicken.com>
267
268 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
269 and background color parameters if they have been changed.
270
a9ab721e
LMI
2712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
272
273 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
274
cf7cff57
PE
2752011-07-03 Paul Eggert <eggert@cs.ucla.edu>
276
2e13213d
PE
277 * xsettings.c (SYSTEM_FONT): Define only when used.
278 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
279
cf7cff57
PE
280 * keymap.c (access_keymap_1): Now static.
281
7a8e04f7
CY
2822011-07-02 Chong Yidong <cyd@stupidchicken.com>
283
284 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
285 leave any prefix arg for the up event (Bug#1586).
286
61352f62
LMI
2872011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
288
69bb1ef7
LMI
289 * lread.c (syms_of_lread): Mention single symbols defined by
290 `defvar' or `defconst' (bug#7154).
291
61352f62 292 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 293 (Frequire): Mention get-load-suffixes.
61352f62 294
28545e04
MR
2952011-07-02 Martin Rudalics <rudalics@gmx.at>
296
297 * window.h (window): Remove clone_number slot.
298 * window.c (Fwindow_clone_number, Fset_window_clone_number):
299 Remove.
300 (make_parent_window, make_window, saved_window)
301 (Fset_window_configuration, save_window_save): Don't deal with
302 clone numbers.
303 * buffer.c (Qclone_number): Remove declaration.
304 (sort_overlays, overlay_strings): Don't deal with clone numbers.
305
3349e122
SM
3062011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
307
308 Add multiple inheritance to keymaps.
309 * keymap.c (Fmake_composed_keymap): New function.
310 (Fset_keymap_parent): Simplify.
311 (fix_submap_inheritance): Remove.
312 (access_keymap_1): New function extracted from access_keymap to handle
313 embedded parents and handle lists of maps.
314 (access_keymap): Use it.
315 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
316 (Fcopy_keymap): Handle embedded parents.
317 (Fcommand_remapping, define_as_prefix): Simplify.
318 (Fkey_binding): Simplify.
319 (syms_of_keymap): Move minibuffer-local-completion-map,
320 minibuffer-local-filename-completion-map,
321 minibuffer-local-must-match-map, and
322 minibuffer-local-filename-must-match-map to Elisp.
323 (syms_of_keymap): Defsubr make-composed-keymap.
324 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
325 (parse_menu_item): Trivial simplification.
326
3279eb87
GM
3272011-07-01 Glenn Morris <rgm@gnu.org>
328
329 * Makefile.in (SETTINGS_LIBS): Fix typo.
330
4550efdf
KI
3312011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
332
333 * coding.c (Fencode_coding_string): Record the last coding system
334 used, as the function doc string says (bug#8738).
335
0949d2b6
JD
3362011-07-01 Jan Djärv <jan.h.d@swipnet.se>
337
338 * xsettings.c (store_monospaced_changed): Take new font as arg and
339 check for change against current_mono_font.
340 (EMACS_TYPE_SETTINGS): Remove this and related defines.
341 (emacs_settings_constructor, emacs_settings_get_property)
342 (emacs_settings_set_property, emacs_settings_class_init)
343 (emacs_settings_init, gsettings_obj): Remove.
344 (something_changedCB): New function for HAVE_GSETTINGS.
345 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
346 with value as argument.
347 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
348 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 349 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
350 "changed".
351
352 * xgselect.c: Add defined (HAVE_GSETTINGS).
353 (xgselect_initialize): Ditto.
354
355 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
356 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
357 xg_select.
358
bbc6b304
PE
3592011-07-01 Paul Eggert <eggert@cs.ucla.edu>
360
361 * eval.c (struct backtrace): Simplify and port the data structure.
362 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
363 signed bit field, as this assumption is not portable and it makes
364 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
365 "char debug_on_exit : 1" as this is not portable either; instead,
366 use the portable "unsigned int debug_on_exit : 1". Remove unused
367 member evalargs. Remove obsolete comments about cc bombing out.
368
9851bfc5
JD
3692011-06-30 Jan Djärv <jan.h.d@swipnet.se>
370
51bb811f 371 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
372 Let HAVE_GSETTINGS override HAVE_GCONF.
373 (store_monospaced_changed): New function.
374 (EMACS_SETTINGS): A new type derived from GObject to handle
375 GSettings notifications.
376 (emacs_settings_constructor, emacs_settings_get_property)
377 (emacs_settings_set_property, emacs_settings_class_init):
378 New functions.
379 (gsettings_client, gsettings_obj): New variables.
380 (GSETTINGS_SCHEMA): New define.
381 (something_changedCB): Call store_monospaced_changed.
382 (init_gsettings): New function.
383 (xsettings_initialize): Call init_gsettings.
384 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
385 to NULL.
386
387 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
388 GCONF_CFLAGS/LIBS.
389
5386012d
MR
3902011-06-29 Martin Rudalics <rudalics@gmx.at>
391
392 * window.c (resize_root_window, grow_mini_window)
393 (shrink_mini_window): Rename Qresize_root_window to
394 Qwindow_resize_root_window and Qresize_root_window_vertically to
395 Qwindow_resize_root_window_vertically.
396
f13e0b08
PE
3972011-06-28 Paul Eggert <eggert@cs.ucla.edu>
398
399 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
400
94515237
JB
4012011-06-27 Juanma Barranquero <lekktu@gmail.com>
402
403 * makefile.w32-in: Redesign dependencies so they reflect more
404 clearly which files are directly included by each source file,
405 and not through other includes.
406
e43b6e43
MR
4072011-06-27 Martin Rudalics <rudalics@gmx.at>
408
409 * buffer.c (Qclone_number): Declare static and DEFSYM it.
410 (sort_overlays, overlay_strings): When an overlay's clone number
411 matches the window's clone number process the overlay even if
412 the overlay's window property doesn't match the current window.
413
d68443dc
MR
414 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
415 (Fwindow_hchild): Rename to Fwindow_left_child.
416 (Fwindow_next): Rename to Fwindow_next_sibling.
417 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
418 (resize_window_check): Rename to window_resize_check.
419 (resize_window_apply): Rename to window_resize_apply.
420 (Fresize_window_apply): Rename to Fwindow_resize_apply.
421 (Fdelete_other_windows_internal, resize_frame_windows)
422 (Fsplit_window_internal, Fdelete_window_internal)
423 (grow_mini_window, shrink_mini_window)
424 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 425
c7e73be5
JD
4262011-06-26 Jan Djärv <jan.h.d@swipnet.se>
427
428 * emacsgtkfixed.h: State that this is only used with Gtk+3.
429 (emacs_fixed_set_min_size): Remove.
430 (emacs_fixed_new): Take frame as argument.
431
432 * emacsgtkfixed.c: State that this is only used with Gtk+3.
433 (_EmacsFixedPrivate): Remove minwidth/height.
434 Add struct frame *f.
435 (emacs_fixed_init): Initialize priv->f.
436 (get_parent_class, emacs_fixed_set_min_size): Remove.
437 (emacs_fixed_new): Set priv->f to argument.
438 (emacs_fixed_get_preferred_width)
439 (emacs_fixed_get_preferred_height): Use min_width/height from
440 frames size_hint to set minimum and natural (Bug#8919).
441 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
442 and use min_width/height from frames size_hint to set
443 min_width/height (Bug#8919).
444
445 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
446 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
447 Fix indentation.
c7e73be5 448
cf99dcf8
EZ
4492011-06-26 Eli Zaretskii <eliz@gnu.org>
450
451 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
452 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
453 called at ZV.
454
029529ac
CY
4552011-06-26 Chong Yidong <cyd@stupidchicken.com>
456
457 * process.c (wait_reading_process_output): Bypass select if
458 waiting for a cell while ignoring keyboard input, and input is
459 pending. Suggested by Jan Djärv (Bug#8869).
460
7a7ef429
PE
4612011-06-25 Paul Eggert <eggert@cs.ucla.edu>
462
463 Use gnulib's dup2 module instead of rolling our own.
464 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
465
11fdef7d 4662011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
467
468 * dispnew.c (scrolling_window): Before scrolling, turn off a
469 mouse-highlight in the window being scrolled.
470
cd3520a4
JB
4712011-06-24 Juanma Barranquero <lekktu@gmail.com>
472
473 Move DEFSYM to lisp.h and use everywhere.
474
475 * character.h (DEFSYM): Move declaration...
476 * lisp.h (DEFSYM): ...here.
477
478 * gnutls.c:
479 * minibuf.c:
480 * w32menu.c:
481 * w32proc.c:
482 * w32select.c: Don't include character.h.
483
484 * alloc.c (syms_of_alloc):
485 * buffer.c (syms_of_buffer):
486 * bytecode.c (syms_of_bytecode):
487 * callint.c (syms_of_callint):
488 * casefiddle.c (syms_of_casefiddle):
489 * casetab.c (init_casetab_once):
490 * category.c (init_category_once, syms_of_category):
491 * ccl.c (syms_of_ccl):
492 * cmds.c (syms_of_cmds):
493 * composite.c (syms_of_composite):
494 * dbusbind.c (syms_of_dbusbind):
495 * dired.c (syms_of_dired):
496 * dispnew.c (syms_of_display):
497 * doc.c (syms_of_doc):
498 * editfns.c (syms_of_editfns):
499 * emacs.c (syms_of_emacs):
500 * eval.c (syms_of_eval):
501 * fileio.c (syms_of_fileio):
502 * fns.c (syms_of_fns):
503 * frame.c (syms_of_frame):
504 * fringe.c (syms_of_fringe):
505 * insdel.c (syms_of_insdel):
506 * keymap.c (syms_of_keymap):
507 * lread.c (init_obarray, syms_of_lread):
508 * macros.c (syms_of_macros):
509 * msdos.c (syms_of_msdos):
510 * print.c (syms_of_print):
511 * process.c (syms_of_process):
512 * search.c (syms_of_search):
513 * sound.c (syms_of_sound):
514 * syntax.c (init_syntax_once, syms_of_syntax):
515 * terminal.c (syms_of_terminal):
516 * textprop.c (syms_of_textprop):
517 * undo.c (syms_of_undo):
518 * w32.c (globals_of_w32):
519 * window.c (syms_of_window):
520 * xdisp.c (syms_of_xdisp):
521 * xfaces.c (syms_of_xfaces):
522 * xfns.c (syms_of_xfns):
523 * xmenu.c (syms_of_xmenu):
524 * xsettings.c (syms_of_xsettings):
525 * xterm.c (syms_of_xterm): Use DEFSYM.
526
4228cf16
TZ
5272011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
528
cd3520a4 529 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 530
7fcccf1e
PE
5312011-06-23 Paul Eggert <eggert@cs.ucla.edu>
532
7efb4e0e
PE
533 Integer and buffer overflow fixes (Bug#8873).
534
ff5844ad
PE
535 * print.c (printchar, strout): Check for string overflow.
536 (PRINTPREPARE, printchar, strout):
537 Don't set size unless allocation succeeds.
538
90532f02
PE
539 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
540 for sizes. Check for string overflow more accurately.
541 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
542
6d84508d
PE
543 * macros.c: Integer and buffer overflow fixes.
544 * keyboard.h (struct keyboard.kbd_macro_bufsize):
545 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
546 Use ptrdiff_t, not int, for sizes.
547 Don't increment bufsize until after realloc succeeds.
548 Check for size-calculation overflow.
549 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
550
437b2cb4
PE
551 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
552
8b9ac8b4
PE
553 * lread.c: Integer overflow fixes.
554 (read_integer): Radix is now EMACS_INT, not int,
555 to improve quality of diagnostics for out-of-range radices.
556 Calculate buffer size correctly for out-of-range radices.
557 (read1): Check for integer overflow in radices, and in
558 read-circle numbers.
82cb60d3
PE
559 (read_escape): Avoid int overflow.
560 (Fload, openp, read_buffer_size, read1)
561 (substitute_object_recurse, read_vector, read_list, map_obarray):
562 Use ptrdiff_t, not int, for sizes.
563 (read1): Use EMACS_INT, not int, for sizes.
20270765 564 Check for size overflow.
8b9ac8b4 565
7fcccf1e
PE
566 * image.c (cache_image): Check for size arithmetic overflow.
567
bfbbd7e7
PE
568 * lread.c: Integer overflow issues.
569 (saved_doc_string_size, saved_doc_string_length)
570 (prev_saved_doc_string_size, prev_saved_doc_string_length):
571 Now ptrdiff_t, not int.
572 (read1): Don't assume doc string length fits in int. Check for
573 out-of-range doc string lengths.
574 (read_list): Don't assume file position fits in int.
39019e54 575 (read_escape): Check for hex character overflow.
bfbbd7e7 576
4e323265
LL
5772011-06-22 Leo Liu <sdl.web@gmail.com>
578
579 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
580 Move to minibuffer.el.
581
85fece3e
PE
5822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
583
20b84ce9 584 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
585 The following patches are for when GLYPH_DEBUG && !XASSERT.
586 * dispextern.h (trace_redisplay_p, dump_glyph_string):
587 * dispnew.c (flush_stdout):
588 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
589 Mark as externally visible.
590 * dispnew.c (check_window_matrix_pointers): Now static.
591 * dispnew.c (window_to_frame_vpos):
592 * xfns.c (unwind_create_frame):
593 * xterm.c (x_check_font): Remove unused local.
594 * scroll.c (CHECK_BOUNDS):
595 * xfaces.c (cache_fache): Rename local to avoid shadowing.
596 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
597 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
598 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
599 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
600 Now static.
601 (debug_method_add): Use va_list and vsprintf rather than relying
602 on undefined behavior with wrong number of arguments.
603 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
604 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
605 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
606 since we're not interested in debugging glyphs with old libraries.
607 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
608 GCC 4.6.0's static checking.
609
0766b489
PE
6102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
611
31fd4b32
PE
612 Integer overflow and signedness fixes (Bug#8873).
613 A few related buffer overrun fixes, too.
614
b79e8648
PE
615 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
616
0766b489
PE
617 * dispextern.h (struct face.stipple):
618 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
619 (x_bitmap_mask, x_allocate_bitmap_record)
620 (x_create_bitmap_from_data, x_create_bitmap_from_file)
621 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
622 (x_create_bitmap_from_xpm_data):
623 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
624 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
625 (.bitmaps_last):
626 * xfaces.c (load_pixmap):
627 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
628 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
629 (.bitmaps_last, struct x_output.icon_bitmap):
630 Use ptrdiff_t, not int, for bitmap indexes.
631 (x_allocate_bitmap_record): Check for size overflow.
632 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
633
b081724f
PE
634 Use ptrdiff_t, not int, for overlay counts.
635 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
636 * editfns.c (overlays_around, get_pos_property):
637 * textprop.c (get_char_property_and_overlay):
638 * xdisp.c (next_overlay_change, note_mouse_highlight):
639 * xfaces.c (face_at_buffer_position):
21514da7
PE
640 * buffer.c (OVERLAY_COUNT_MAX): New macro.
641 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
642 (Fnext_overlay_change, Fprevious_overlay_change)
643 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 644 Use ptrdiff_t, not int, for sizes.
21514da7 645 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 646
3de73e5e
PE
647 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
648
2606c57b
PE
649 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
650 (x_session_initialize): Do not assume string length fits in int.
651
aaafe47a
PE
652 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
653 This is unlikely, but can occur if DPI is outlandish.
654
2674ddc8 655 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
656 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
657
28154962
PE
658 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
659 * xrdb.c (magic_file_p, search_magic_path):
660 Omit last arg SUFFIX; it was always 0. All callers changed.
661 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
662
7de51af5
PE
663 * xfont.c (xfont_match): Avoid need for strlen.
664
25ed6cc3
PE
665 * xfns.c: Don't assume strlen fits in int.
666 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
667
4eab31dd
PE
668 * xdisp.c (message_log_check_duplicate): Return intmax_t,
669 not unsigned long, as we prefer signed integers. All callers changed.
670 Detect integer overflow in repeat count.
671 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 672 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 673
171e2a58
PE
674 * termcap.c: Don't assume sizes fit in int and never overflow.
675 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
676 (gobble_line): Check for size-calculation overflow.
677
ad39faca 678 * minibuf.c (Fread_buffer):
6e5bb2dc 679 * lread.c (intern, intern_c_string):
74ca2eb3
PE
680 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
681 Don't assume string length fits in int.
682
52c61c22 683 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
684 * gtkutil.c (style_changed_cb): Avoid need for strlen.
685
b5b8c9e5
PE
686 * font.c: Don't assume string length fits in int.
687 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
688 Use ptrdiff_t, not int.
ccd6111c
PE
689 (font_intern_prop): Don't assume string length fits in int.
690 Don't assume integer property fits in fixnum.
691 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 692
882f0d81 693 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 694 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
695 Reformulate so as not to need the command string.
696 Invoke gzip -cd rather than gunzip, as it's more portable.
697 (lock_info_type, lock_file_1, lock_file):
698 Don't assume pid_t and time_t fit in unsigned long.
699 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
700 (current_lock_owner): Prefer signed type for sizes.
701 Use memcpy, not strncpy, where memcpy is what is really wanted.
702 Don't assume (via atoi) that time_t and pid_t fit in int.
703 Check for time_t and/or pid_t out of range, e.g., via a network share.
704 Don't alloca where an auto var works fine.
705
93f4cf88
PE
706 * fileio.c: Fix some integer overflow issues.
707 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
708 Don't assume string length fits in int.
709 (directory_file_name): Don't assume string length fits in long.
710 (make_temp_name): Don't assume pid fits in int, or that its print
711 length is less than 20.
712
f3e92b69
PE
713 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
714
1bfdaf10
PE
715 * coding.c (make_subsidiaries): Don't assume string length fits in int.
716
35016e9a
PE
717 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
718
3d1e65a1
PE
719 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
720 We prefer signed integers, even for size calculations.
721
0b963a93
PE
722 * emacs.c: Don't assume string length fits in 'int'.
723 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
724 (main): Don't invoke strlen when not needed.
725
573f4b54
PE
726 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
727 (XD_DEBUG_MESSAGE): Don't waste a byte.
728
989f33ba
PE
729 * callproc.c (getenv_internal_1, getenv_internal)
730 (Fgetenv_internal):
965d34eb
PE
731 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
732
e4d29b33
PE
733 * lread.c (invalid_syntax): Omit length argument.
734 All uses changed. This doesn't fix a bug, but it simplifies the
735 code away from its former Hollerith-constant appearance, and it's
736 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 737 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 738
eb49b136
PE
739 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
740 This didn't break anything, but it didn't help either.
741 It's confusing to put a bogus integer in a place where the actual
742 value does not matter.
9f62aeb1 743 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 744 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 745
15375a22
PE
746 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
747 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
748 implementation.
b61cc01c
PE
749 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
750 We prefer signed types, and the value cannot exceed the EMACS_INT
751 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
752 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
753 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
754 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 755
53b2623d
PE
756 * indent.c (sane_tab_width): New function.
757 (current_column, scan_for_column, Findent_to, position_indentation)
758 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 759 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 760
51cab52b 761 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 762
f2ed8a70
PE
763 * lisp.h (lint_assume): New macro.
764 * composite.c (composition_gstring_put_cache):
765 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
766
abe80cc6
PE
767 * editfns.c, insdel.c:
768 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 769
b02c740e
PE
770 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
771
ebc96716
PE
772 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
773
b4e50fa0 774 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 775 Use much-faster test for byte-length change.
311d5d7c 776 Don't assume string byte-length fits in 'int'.
a4cf38e4 777 Check that character arg fits in 'int'.
85461888 778 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 779
c0c1ee9f
PE
780 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
781
a498d7f4
PE
782 * fns.c (concat): Catch string overflow earlier.
783 Do not rely on integer wraparound.
784
51cab52b
PE
785 * dispextern.h (struct it.overlay_strings_charpos)
786 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
787 * xdisp.c (forward_to_next_line_start)
788 (back_to_previous_visible_line_start)
789 (reseat_at_next_visible_line_start, next_element_from_buffer):
790 Don't arbitrarily truncate the value of 'selective' to int.
791
76031fad
PE
792 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
793
5eb55db9
PE
794 * composite.c: Don't truncate sizes to 'int'.
795 (composition_gstring_p, composition_reseat_it)
796 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
797 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
798 not EMACS_UINT, for indexes.
5eb55db9 799
0703a717
PE
800 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
801
d6202519
PE
802 * buffer.c: Include <verify.h>.
803 (struct sortvec.priority, struct sortstr.priority):
8961a454 804 Now EMACS_INT, not int.
c20998a7 805 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
806 (struct sortstr.size, record_overlay_string)
807 (struct sortstrlist.size, struct sortlist.used):
808 Don't truncate size to int.
809 (record_overlay_string): Check for size-calculation overflow.
d6202519 810 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 811
d5a19415
JM
8122011-06-22 Jim Meyering <meyering@redhat.com>
813
029529ac 814 Don't leak an XBM-image-sized buffer
d5a19415
JM
815 * image.c (xbm_load): Free the image buffer after using it.
816
a9041e6c
PE
8172011-06-21 Paul Eggert <eggert@cs.ucla.edu>
818
819 Port to Sun C.
820 * composite.c (find_automatic_composition): Omit needless 'return 0;'
821 that Sun C diagnosed.
822 * fns.c (secure_hash): Fix pointer signedness issue.
823 * intervals.c (static_offset_intervals): New function.
824 (offset_intervals): Use it.
825
7f3f739f
LL
8262011-06-21 Leo Liu <sdl.web@gmail.com>
827
828 * deps.mk (fns.o):
829 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
830 sha512.h.
831
832 * fns.c (secure_hash): Rename from crypto_hash_function and change
833 the first arg to accept symbols.
5b66d427 834 (Fsecure_hash): New primitive.
7f3f739f
LL
835 (syms_of_fns): New symbols.
836
76147d94
DD
8372011-06-20 Deniz Dogan <deniz@dogan.se>
838
839 * process.c (Fset_process_buffer): Clarify return value in
840 docstring.
841
7d7d0045
CY
8422011-06-18 Chong Yidong <cyd@stupidchicken.com>
843
844 * dispnew.c (add_window_display_history): Use BVAR.
845
846 * xdisp.c (debug_method_add): Use BVAR.
847 (check_window_end, dump_glyph_matrix, dump_glyph)
848 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
849
850 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
851 Likewise.
852
853 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
854 check till after the cache is created in init_frame_faces.
855
ff2bc410
SM
8562011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
857
858 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
859
28177add
PE
8602011-06-16 Paul Eggert <eggert@cs.ucla.edu>
861
dd3482fe
PE
862 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
863 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
864 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
865
393d71f3 866 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
867 * fileio.c (Finsert_file_contents):
868 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
869 Remove the old (too-loose) buffer overflow checks.
870 They weren't needed, since make_gap checks for buffer overflow.
871 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
872 The old code merely checked for Emacs fixnum overflow, and relied
873 on undefined (wraparound) behavior. The new code avoids undefined
874 behavior, and also checks for ptrdiff_t and/or size_t overflow.
875
2e6813b0 876 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
877 Tune. Don't use wider integers than needed. Don't use alloca.
878 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 879
599a9e4f
PE
880 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
881
99561444
PE
882 * insdel.c, lisp.h (buffer_overflow): New function.
883 (insert_from_buffer_1, replace_range, replace_range_2):
884 * insdel.c (make_gap_larger):
885 * editfns.c (Finsert_char):
886 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
887
28177add
PE
888 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
889
e69dafad
PE
8902011-06-15 Paul Eggert <eggert@cs.ucla.edu>
891
a7af7fde 892 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 893
b1c46f02
PE
894 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
895 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
896
e69dafad
PE
897 * fileio.c: Don't assume EMACS_INT fits in off_t.
898 (emacs_lseek): New static function.
899 (Finsert_file_contents, Fwrite_region): Use it.
900 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
901
566684ea
PE
902 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
903
e6966cd6
PE
904 * fns.c: Don't overflow int when computing a list length.
905 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
906 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
907 truncation on 64-bit hosts. Check for QUIT every
908 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
909 faster and is responsive enough.
910 (Flength): Report an error instead of overflowing an integer.
911 (Fsafe_length): Return a float if the value is not representable
912 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 913 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 914 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 915
dd0b0efb
PE
916 * alloc.c: Check that resized vectors' lengths fit in fixnums.
917 (header_size, word_size): New constants.
918 (allocate_vectorlike): Don't check size overflow here.
919 (allocate_vector): Check it here instead, since this is the only
920 caller of allocate_vectorlike that could cause overflow.
921 Check that the new vector's length is representable as a fixnum.
922
86fe5cfe
PE
923 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
924 The previous code was bogus. For example, next_almost_prime (32)
925 returned 39, which is undesirable as it is a multiple of 3; and
926 next_almost_prime (24) returned 25, which is a multiple of 5 so
927 why was the code bothering to check for multiples of 7?
928
80e88859
PE
929 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
930
4a2f0ad6
PE
931 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
932
f66c7cf8
PE
933 Variadic C functions now count arguments with ptrdiff_t.
934 This partly undoes my 2011-03-30 change, which replaced int with size_t.
935 Back then I didn't know that the Emacs coding style prefers signed int.
936 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
937 were being counted with int, which may truncate counts on 64-bit
938 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
939 * lisp.h (struct Lisp_Subr.function.aMANY)
940 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
941 Arg counts are now ptrdiff_t, not size_t.
942 All variadic functions and their callers changed accordingly.
943 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
944 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
945 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
946 * callint.c (Fcall_interactively): Check arg count for overflow,
947 to avoid potential buffer overrun. Use signed char, not 'int',
948 for 'varies' array, so that we needn't bother to check its size
949 calculation for overflow.
950 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
951 * eval.c (apply_lambda):
952 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
953 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
954 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
955
a1759b76
PE
956 * callint.c (Fcall_interactively): Don't use index var as event count.
957
d96be9fc
PE
958 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
959 * mem-limits.h (SIZE): Remove; no longer used.
960
a690a978 961 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 962
578c21e6
PE
963 Remove unnecessary casts.
964 * xterm.c (x_term_init):
965 * xfns.c (x_set_border_pixel):
966 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
967 These aren't needed now that we assume ANSI C.
968
96f53c6c
PE
969 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
970 It's more likely to cause problems (due to unsigned overflow)
971 than to cure them.
972
83c77d31
PE
973 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
974
ee2079f1
PE
975 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
976
6da65536
PE
977 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
978
7147c4a4
PE
979 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
980
193e32d9
PE
981 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
982
e5533da6
PE
983 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
984
9910e595
PE
985 GLYPH_CODE_FACE returns EMACS_INT, not int.
986 * dispextern.h (merge_faces):
987 * xfaces.c (merge_faces):
01103c44
PE
988 * xdisp.c (get_next_display_element, next_element_from_display_vector):
989 Don't assume EMACS_INT fits in int.
9910e595 990
2638320e
PE
991 * character.h (CHAR_VALID_P): Remove unused parameter.
992 * fontset.c, lisp.h, xdisp.c: All uses changed.
993
045eb8d9
PE
994 * editfns.c (Ftranslate_region_internal): Omit redundant test.
995
c1f134b5
PE
996 * fns.c (concat): Minor tuning based on overflow analysis.
997 This doesn't fix any bugs. Use int to hold character, instead
998 of constantly refetching from Emacs object. Use XFASTINT, not
999 XINT, for value known to be a character. Don't bother comparing
1000 a single byte to 0400, as it's always less.
1001
395fcb93 1002 * floatfns.c (Fexpt):
327eeec8
PE
1003 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1004
abbd3d23
PE
1005 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1006 for characters.
1007
684a03ef
PE
1008 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1009
0fed43f3
PE
1010 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1011 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1012 incorrectly succeed when S was a string, because 4294967386 was
1013 truncated before it was used.
1014
8fd02eb7
PE
1015 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1016 Otherwise, an out-of-range integer could cause undefined behavior
1017 on a 64-bit host.
1018
f8c86b69
PE
1019 * composite.c: Use int, not EMACS_INT, for characters.
1020 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1021 EMACS_INT, for values that are known to be in character range.
1022 This doesn't fix any bugs but is the usual style inside Emacs and
1023 may generate better code on 32-bit machines.
1024
34206dd2
PE
1025 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1026 This is for reasons similar to the recent CHAR_STRING fix.
1027 * charset.c (Fencode_char): Check that character arg is actually
1028 a character. Pass an int to ENCODE_CHAR.
1029 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1030 wider than 'int', as a compile-time check to prevent future regressions
1031 in this area.
1032
c5958d4c 1033 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1034
1035 Make sure a 64-bit char is never passed to CHAR_STRING.
1036 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1037 by silently ignoring the top 32 bits, allowing some values
1038 that were far too large to be valid characters.
1039 * character.h: Include <verify.h>.
1040 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1041 arguments are no wider than unsigned, as a compile-time check
1042 to prevent future regressions in this area.
1043 * data.c (Faset):
01103c44 1044 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1045 (Fsubst_char_in_region):
1046 * fns.c (concat):
1047 * xdisp.c (decode_mode_spec_coding):
1048 Adjust to CHAR_STRING's new requirement.
1049 * editfns.c (Finsert_char, Fsubst_char_in_region):
1050 * fns.c (concat): Check that character args are actually
1051 characters. Without this test, these functions did the wrong
1052 thing with wildly out-of-range values on 64-bit hosts.
1053
d37ca623
PE
1054 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1055 These casts should not be needed on 32-bit hosts, either.
1056 * keyboard.c (read_char):
1057 * lread.c (Fload): Remove casts to unsigned.
1058
ea204efb
PE
1059 * lisp.h (UNSIGNED_CMP): New macro.
1060 This fixes comparison bugs on 64-bit hosts.
1061 (ASCII_CHAR_P): Use it.
1062 * casefiddle.c (casify_object):
01103c44 1063 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1064 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1065 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1066 * dispextern.h (FACE_FROM_ID):
1067 * keyboard.c (read_char): Use UNSIGNED_CMP.
1068
41cb286c
PE
1069 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1070 not to EMACS_INT, to avoid GCC warning.
1071
4a1b9832
PE
1072 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1073
55daad71
PE
1074 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1075 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1076 isn't needed on 32-bit machines.
8f95c75c 1077
01103c44
PE
1078 * buffer.c (Fgenerate_new_buffer_name):
1079 Use EMACS_INT for count, not int.
0ceccced 1080 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1081
1082 * data.c (Qcompiled_function): Now static.
1083
c6f072e7
PE
1084 * window.c (window_body_lines): Now static.
1085
20ce5912
PE
1086 * image.c (gif_load): Rename local to avoid shadowing.
1087
9c4c5f81
PE
1088 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1089 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1090 * alloc.c (make_save_value): Integer argument is now of type
1091 ptrdiff_t, not int.
1092 (mark_object): Use ptrdiff_t, not int.
1093 * lisp.h (pD): New macro.
1094 * print.c (print_object): Use it.
1095
c0c5c8ae
PE
1096 * alloc.c: Use EMACS_INT, not int, to count objects.
1097 (total_conses, total_markers, total_symbols, total_vector_size)
1098 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1099 (total_free_floats, total_floats, total_free_intervals)
1100 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1101 Now EMACS_INT, not int. All uses changed.
1102 (Fgarbage_collect): Compute overall total using a double, so that
1103 integer overflow is less likely to be a problem. Check for overflow
1104 when converting back to an integer.
5a25e253
PE
1105 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1106 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1107 These were 'int' variables that could overflow on 64-bit hosts;
1108 they were never used, so remove them instead of repairing them.
211a0b2a 1109 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1110 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1111 Previously, this ceilinged at INT_MAX, but that doesn't work on
1112 64-bit machines.
e46bb31a 1113 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1114
c78baabf 1115 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1116 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1117 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1118 when a (possibly-narrower) signed value would do just as well.
1119 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1120
c9d624c6
PE
1121 * alloc.c: Catch some string size overflows that we were missing.
1122 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1123 for convenience in STRING_BYTES_MAX.
1124 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1125 The definition here is exact; the one in lisp.h was approximate.
1126 (allocate_string_data): Check for string overflow. This catches
1127 some instances we weren't catching before. Also, it catches
1128 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1129 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1130 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1131
c9d624c6
PE
1132 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1133 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1134 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1135
353032ce
PE
1136 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1137
2bccce07
PE
1138 * alloc.c (Fmake_string): Check for out-of-range init.
1139
0ac30604
SM
11402011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1141
1142 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1143
c195f2de
JD
11442011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1145
1146 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1147 xg_get_default_scrollbar_width.
1148
1149 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1150 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1151 (style_changed_cb): Call update_theme_scrollbar_width and call
1152 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1153 all frames (Bug#8505).
1154 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1155 Call gtk_window_set_resizable if HAVE_GTK3.
1156 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1157 and height if HAVE_GTK3 (Bug#8505).
1158 (scroll_bar_width_for_theme): New variable.
1159 (update_theme_scrollbar_width): New function.
1160 (xg_get_default_scrollbar_width): Move code to
1161 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1162 (xg_initialize): Call update_theme_scrollbar_width.
1163
1164 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1165
1166 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1167
e10ac9f1
MR
11682011-06-12 Martin Rudalics <rudalics@gmx.at>
1169
1170 * frame.c (make_frame): Call other_buffer_safely instead of
1171 other_buffer.
1172
1173 * window.c (temp_output_buffer_show): Call display_buffer with
1174 second argument Vtemp_buffer_show_specifiers and reset latter
1175 immediately after the call.
1176 (Vtemp_buffer_show_specifiers): New variable.
1177 (auto_window_vscroll_p, next_screen_context_lines)
1178 (Vscroll_preserve_screen_position): Remove leading asterisks from
1179 doc-strings.
1180
2d3c217e 11812011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1182
7b7f97e8 1183 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1184 * buffer.c (Qclone_number): Remove for now, as it's unused.
1185 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1186 (record_buffer): Remove unused local.
1187 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1188 (set_frame_buffer_list): Remove; unused.
1189 * frame.h (other_visible_frames): Remove decl.
1190 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1191 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1192 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1193 if HAVE_GPM.
1194 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1195 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1196 Define only if HAVE_GPM.
1197 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1198 (update_hints_inhibit): Remove; never set. All uses removed.
1199 * widgetprv.h (emacsFrameClassRec): Remove decl.
1200 * window.c (delete_deletable_window): Now returns void, since it
1201 wasn't returning anything.
1202 (compare_window_configurations): Remove unused locals.
1203 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1204 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1205 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1206 the same widths as pointers. This follows up on the 2011-05-06 patch.
1207 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1208 * xterm.h: Likewise.
1209 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1210
1384b89e
JB
12112011-06-12 Juanma Barranquero <lekktu@gmail.com>
1212
1213 * makefile.w32-in: Update dependencies.
1214 (LISP_H): Add lib/intprops.h.
1215
1100a63c
CY
12162011-06-11 Chong Yidong <cyd@stupidchicken.com>
1217
1218 * image.c (gif_load): Add animation frame delay to the metadata.
1219 (syms_of_image): Use DEFSYM. New symbol `delay'.
1220
6198ccd0
MR
12212011-06-11 Martin Rudalics <rudalics@gmx.at>
1222
1223 * window.c (delete_deletable_window): Re-add.
1224 (Fset_window_configuration): Rewrite to handle dead buffers and
1225 consequently deletable windows.
1226 (window_tree, Fwindow_tree): Remove. Supply functionality in
1227 window.el.
1228 (compare_window_configurations): Simplify code.
1229
b6e3633c
AS
12302011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1231
1ab0dee5
AS
1232 * image.c (imagemagick_load_image): Fix type mismatch.
1233 (Fimagemagick_types): Likewise.
1234
b6e3633c
AS
1235 * window.h (replace_buffer_in_windows): Declare.
1236
9397e56f
MR
12372011-06-11 Martin Rudalics <rudalics@gmx.at>
1238
1239 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1240 Qclone_number. Remove external declaration of Qdelete_window.
1241 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1242 code.
1243 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1244 Qbuffer_list_update_hook if allowed.
1245 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1246 buffer list implementation.
1247 (other_buffer_safely): New function.
1248 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1249 calls to replace_buffer_in_windows and
1250 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1251 if allowed.
1252 (record_buffer): Inhibit quitting and rewrite using quittable
1253 functions. Run Qbuffer_list_update_hook if allowed.
1254 (Frecord_buffer, Funrecord_buffer): New functions.
1255 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1256 switch-to-buffer to window.el.
1257 (bury-buffer): Move to window.el.
1258 (Vbuffer_list_update_hook): New variable.
1259
1260 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1261 section.
1262
1263 * window.h (resize_frame_windows): Move up in code.
1264 (Fwindow_frame): Remove EXFUN.
1265 (replace_buffer_in_all_windows): Remove prototype.
1266 (replace_buffer_in_windows_safely): Add prototype.
1267
1268 * window.c: Declare Qdelete_window static again. Move down
1269 declaration of select_count.
1270 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1271 (Fother_window): Move to window.el.
1272 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1273 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1274 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1275 window.el.
1276 (replace_buffer_in_windows): Implement by calling
1277 Qreplace_buffer_in_windows.
1278 (replace_buffer_in_all_windows): Remove with some functionality
1279 moved into replace_buffer_in_windows_safely.
1280 (replace_buffer_in_windows_safely): New function.
1281 (select_window_norecord, select_frame_norecord): Move in front
1282 of run_window_configuration_change_hook. Remove now obsolete
1283 declarations.
1284 (Fset_window_buffer): Rewrite doc-string. Call
1285 Qrecord_window_buffer.
1286 (keys_of_window): Move binding for other-window to window.el.
1287
b50691aa
CY
12882011-06-11 Chong Yidong <cyd@stupidchicken.com>
1289
1290 * dispextern.h (struct image): Replace data member, whose int_val
1291 and ptr_val fields were not used by anything, with a single
1292 lisp_val object.
1293
1294 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1295 (gif_clear_image, gif_load, imagemagick_load_image)
1296 (gs_clear_image, gs_load): Callers changed.
1297
3f754b86
PE
12982011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1299
cca69397
PE
1300 * buffer.h: Include <time.h>, for time_t.
1301 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1302
109e28d0
PE
1303 Fix minor problems found by static checking.
1304
60737f02
PE
1305 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1306
4b66faf3
PE
1307 Make identifiers static if they are not used in other modules.
1308 * data.c (Qcompiled_function, Qframe, Qvector):
1309 * image.c (QimageMagick, Qsvg):
1310 * minibuf.c (Qmetadata):
1311 * window.c (resize_window_check, resize_root_window): Now static.
1312 * window.h (resize_window_check, resize_root_window): Remove decls.
1313
109e28d0
PE
1314 * window.c (window_deletion_count, delete_deletable_window):
1315 Remove; unused.
46a4ce9e
PE
1316 (window_body_lines): Now static.
1317 (Fdelete_other_windows_internal): Mark vars as initialized.
1318 Make sure 'resize_failed' is initialized.
1319 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1320 (resize_window_apply): Remove unused local.
1321 * window.h (delete_deletable_window): Remove decl.
1322
109e28d0 1323 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1324 (imagemagick_load_image): Fix pointer signedness problem by changing
1325 last arg from unsigned char * to char *. All uses changed.
1326 Also, fix a local for similar reasons.
1327 Remove unused locals. Remove locals to avoid shadowing.
1328 (fn_rsvg_handle_free): Remove; unused.
1329 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1330 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1331
3f754b86
PE
1332 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1333
2547adb1
CY
13342011-06-10 Chong Yidong <cyd@stupidchicken.com>
1335
1336 * image.c (gif_load): Fix omitted cast error introduced by
1337 2011-06-06 change.
1338
2c8e37d4
MR
13392011-06-10 Martin Rudalics <rudalics@gmx.at>
1340
1341 * window.h (resize_proportionally, orig_total_lines)
1342 (orig_top_line): Remove from window structure.
1343 (set_window_height, set_window_width, change_window_heights)
1344 (Fdelete_window): Remove prototypes.
1345 (resize_frame_windows): Remove duplicate declaration.
1346
440a42e3
EZ
13472011-06-10 Eli Zaretskii <eliz@gnu.org>
1348
1349 * window.h (resize_frame_windows, resize_window_check)
1350 (delete_deletable_window, resize_root_window)
1351 (resize_frame_windows): Declare prototypes.
1352
1353 * window.c (resize_window_apply): Make definition be "static" to
1354 match the prototype.
1355
562dd5e9
MR
13562011-06-10 Martin Rudalics <rudalics@gmx.at>
1357
1358 * window.c: Remove declarations of Qwindow_size_fixed,
1359 window_min_size_1, window_min_size_2, window_min_size,
1360 size_window, window_fixed_size_p, enlarge_window, delete_window.
1361 Remove static from declaration of Qdelete_window, it's
1362 temporarily needed by Fbury_buffer.
1363 (replace_window): Don't assign orig_top_line and
1364 orig_total_lines.
1365 (Fdelete_window, delete_window): Remove. Window deletion is
1366 handled by window.el.
1367 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1368 Fdelete_window calls with calls to Qdelete_window.
1369 (Fdelete_other_windows): Remove. Deleting other windows is
1370 handled by window.el.
1371 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1372 handled in window.el.
1373 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1374 Window minimum sizes are handled in window.el.
1375 (shrink_windows, size_window, set_window_height)
1376 (set_window_width, change_window_heights, window_height)
1377 (window_width, CURBEG, CURSIZE, enlarge_window)
1378 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1379 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1380 handled in window.el.
1381 (make_dummy_parent): Rename to make_parent_window and give it a
1382 second argument horflag.
1383 (make_window): Don't set resize_proportionally any more.
1384 (Fsplit_window): Remove. Windows are split in window.el.
1385 (save_restore_action, save_restore_orig_size)
1386 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1387 Resize mini windows in window.el.
1388 (grow_mini_window, shrink_mini_window): Implement by calling
1389 Qresize_root_window_vertically, resize_window_check and
1390 resize_window_apply.
1391 (saved_window, Fset_window_configuration, save_window_save): Do
1392 not handle orig_top_line, orig_total_lines, and
1393 resize_proportionally.
1394 (window_min_height, window_min_width): Move to window.el.
1395 (keys_of_window): Move bindings for delete-other-windows,
1396 split-window, delete-window and enlarge-window to window.el.
1397
1398 * buffer.c: Temporarily extern Qdelete_window.
1399 (Fbury_buffer): Temporarily call Qdelete_window instead of
1400 Fdelete_window (Fbury_buffer will move to window.el soon).
1401
1402 * frame.c (set_menu_bar_lines_1): Remove code handling
1403 orig_top_line and orig_total_lines.
1404
1405 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1406 set_window_height but set heights directly.
1407 (change_frame_size_1): Use resize_frame_windows.
1408
1409 * xdisp.c (init_xdisp): Don't use set_window_height but set
1410 heights directly.
1411
1412 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1413 resize_frame_windows instead of change_window_heights and run
1414 run_window_configuration_change_hook.
1415
1416 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1417 instead of change_window_heights and run
1418 run_window_configuration_change_hook.
1419
1a13852e
MR
14202011-06-09 Martin Rudalics <rudalics@gmx.at>
1421
1422 * window.c (replace_window): Rename second argument REPLACEMENT to
1423 NEW. New third argument SETFLAG. Rewrite.
1424 (delete_window, make_dummy_parent): Call replace_window with
1425 third argument 1.
1426 (window_list_1): Move down in code.
1427 (run_window_configuration_change_hook): Move set_buffer part
1428 before select_frame_norecord part in order to unwind correctly.
1429 Rename count1 to count.
1430 (recombine_windows, delete_deletable_window, resize_root_window)
1431 (Fdelete_other_windows_internal)
1432 (Frun_window_configuration_change_hook, make_parent_window)
1433 (resize_window_check, resize_window_apply, Fresize_window_apply)
1434 (resize_frame_windows, Fsplit_window_internal)
1435 (Fdelete_window_internal, Fresize_mini_window_internal): New
1436 functions.
1437 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1438
f3d1777e
MR
14392011-06-08 Martin Rudalics <rudalics@gmx.at>
1440
496e208e
MR
1441 * window.h (window): Add some new members to window structure -
1442 normal_lines, normal_cols, new_total, new_normal, clone_number,
1443 splits, nest, prev_buffers, next_buffers.
1444 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1445 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1446
f3d1777e
MR
1447 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1448 Remove.
496e208e
MR
1449 (make_dummy_parent): Set new members of windows structure.
1450 (make_window): Move down in code. Handle new members of window
1451 structure.
1452 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1453 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1454 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1455 (Fset_window_prev_buffers, Fwindow_next_buffers)
1456 (Fset_window_next_buffers, Fset_window_clone_number): New
1457 functions.
1458 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1459 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1460 Doc-string fixes.
1461 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1462 Argument WINDOW can be now internal window too.
1463 (Fwindow_use_time): Move up in code.
1464 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1465 Rewrite doc-string.
1466 (Fset_window_configuration, saved_window)
1467 (Fcurrent_window_configuration, save_window_save): Handle new
1468 members of window structure.
b9e809c2
MR
1469 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1470 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1471 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1472 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1473 Qget_mru_window, Qresize_root_window,
1474 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1475 Qauto_buffer_name; staticpro them.
f3d1777e 1476
abde8f8c
MR
14772011-06-07 Martin Rudalics <rudalics@gmx.at>
1478
1479 * window.c (Fwindow_total_size, Fwindow_left_column)
1480 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1481 (Fwindow_list_1): New functions.
1482 (window_box_text_cols): Replace with window_body_cols.
1483 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1484 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1485 (delete_window, Fset_window_configuration): Call
1486 delete_all_subwindows with window as argument.
1487 (delete_all_subwindows): Take a window as argument and not a
1488 structure. Rewrite.
190b47e6
MR
1489 (window_loop): Remove handling of GET_LRU_WINDOW and
1490 GET_LARGEST_WINDOW.
1491 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1492
1493 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1494 window_box_text_cols. delete_all_subwindows now takes a
1495 Lisp_Object as argument.
abde8f8c
MR
1496
1497 * indent.c (compute_motion, Fcompute_motion): Use
1498 window_body_cols instead of window_box_text_cols.
1499
fa8a67e6
MR
1500 * frame.c (delete_frame): Call delete_all_subwindows with root
1501 window as argument.
1502
a54e3482
DC
15032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1504
1505 * fns.c (Fputhash): Document return value.
1506
60002bf5
CY
15072011-06-06 Chong Yidong <cyd@stupidchicken.com>
1508
1509 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1510
0c671da6 15112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1512
b862a52a 1513 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1514
be44ca6c
PE
1515 Check for overflow when converting integer to cons and back.
1516 * charset.c (Fdefine_charset_internal, Fdecode_char):
1517 Use cons_to_unsigned to catch overflow.
1518 (Fencode_char): Use INTEGER_TO_CONS.
1519 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1520 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1521 * data.c (long_to_cons, cons_to_long): Remove.
1522 (cons_to_unsigned, cons_to_signed): New functions.
1523 These signal an error for invalid or out-of-range values.
1524 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1525 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1526 * font.c (Ffont_variation_glyphs):
1527 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1528 * lisp.h: Include <intprops.h>.
1529 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1530 (cons_to_signed, cons_to_unsigned): New decls.
1531 (long_to_cons, cons_to_long): Remove decls.
1532 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1533 (Fprimitive_undo): Use CONS_TO_INTEGER.
1534 * xfns.c (Fx_window_property): Likewise.
1535 * xselect.c: Include <limits.h>.
1536 (x_own_selection, selection_data_to_lisp_data):
1537 Use INTEGER_TO_CONS.
1538 (x_handle_selection_request, x_handle_selection_clear)
1539 (x_get_foreign_selection, Fx_disown_selection_internal)
1540 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1541 (lisp_data_to_selection_data): Use cons_to_unsigned.
1542 (x_fill_property_data): Use cons_to_signed.
1543 Report values out of range.
1544
d1f3d2af
PE
1545 Check for buffer and string overflow more precisely.
1546 * buffer.h (BUF_BYTES_MAX): New macro.
1547 * lisp.h (STRING_BYTES_MAX): New macro.
1548 * alloc.c (Fmake_string):
1549 * character.c (string_escape_byte8):
1550 * coding.c (coding_alloc_by_realloc):
1551 * doprnt.c (doprnt):
1552 * editfns.c (Fformat):
1553 * eval.c (verror):
1554 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1555 since they may not be the same number.
1556 * editfns.c (Finsert_char):
1557 * fileio.c (Finsert_file_contents):
1558 Likewise for BUF_BYTES_MAX.
1559
dd52fcea
PE
1560 * image.c: Use ptrdiff_t, not int, for sizes.
1561 (slurp_file): Switch from int to ptrdiff_t.
1562 All uses changed.
1563 (slurp_file): Check that file size fits in both size_t (for
1564 malloc) and ptrdiff_t (for sanity and safety).
1565
7f9bbdbb
PE
1566 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1567 if b->modtime has its maximal value.
1568
dfe18f82
PE
1569 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1570
84acfcf0
PE
1571 Don't assume time_t can fit into int.
1572 * buffer.h (struct buffer.modtime): Now time_t, not int.
1573 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1574 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1575
ccd9a01a
PE
1576 Minor fixes for signed vs unsigned integers.
1577 * character.h (MAYBE_UNIFY_CHAR):
1578 * charset.c (maybe_unify_char):
1579 * keyboard.c (read_char, reorder_modifiers):
1580 XINT -> XFASTINT, since the integer must be nonnegative.
1581 * ftfont.c (ftfont_spec_pattern):
1582 * keymap.c (access_keymap, silly_event_symbol_error):
1583 XUINT -> XFASTINT, since the integer must be nonnegative.
1584 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1585 since it makes no difference and we prefer signed.
1586 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1587 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1588 nonnegative.
1589
d6d100dd
SM
15902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * window.h (Fwindow_frame): Declare.
1593
2b6148e4
PE
15942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1597 (SPARE_MEMORY): Always define.
1598 (LARGE_REQUEST): Remove.
1599 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1600
f230ecc9
MR
16012011-06-06 Martin Rudalics <rudalics@gmx.at>
1602
727e958e
MR
1603 * lisp.h: Move EXFUNS for Fframe_root_window,
1604 Fframe_first_window and Fset_frame_selected_window to window.h.
1605
1606 * window.h: Move EXFUNS for Fframe_root_window,
1607 Fframe_first_window and Fset_frame_selected_window here from
1608 lisp.h.
1609
1610 * frame.c (Fwindow_frame, Fframe_first_window)
1611 (Fframe_root_window, Fframe_selected_window)
1612 (Fset_frame_selected_window): Move to window.c.
1613 (Factive_minibuffer_window): Move to minibuf.c.
1614 (Fother_visible_frames_p): New function.
1615
1616 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1617
f230ecc9
MR
1618 * window.c (decode_window, decode_any_window): Move up in code.
1619 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1620 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1621 (Fwindow_buffer): Move up and rewrite doc-string.
1622 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1623 (Fwindow_prev): New functions.
727e958e
MR
1624 (Fwindow_frame): Move here from frame.c. Accept any window as
1625 argument.
1626 (Fframe_root_window, Fframe_first_window)
1627 (Fframe_selected_window): Move here from frame.c. Accept frame
1628 or arbitrary window as argument. Update doc-strings.
1629 (Fminibuffer_window): Move up in code.
1630 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1631 (Fset_frame_selected_window): Move here from frame.c.
1632 Marginal rewrite.
727e958e
MR
1633 (Fselected_window, select_window, Fselect_window): Move up in
1634 code. Minor doc-string fixes.
f230ecc9 1635
4d09bcf6
PE
16362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1637
1638 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1639 Do not assume that spare memory exists; that assumption is valid
1640 only if SYSTEM_MALLOC.
1641 (LARGE_REQUEST): New macro, so that the issue of large requests
1642 is separated from the issue of spare memory.
1643
810928a2
AS
16442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1645
172418ad
AS
1646 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1647 format. (Bug#8806)
1648
43f862f7
AS
1649 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1650
810928a2
AS
1651 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1652 before statements.
1653
a059fe24
JD
16542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1655
1656 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1657
1658 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1659
1660 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1661 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1662
989bf368
JB
16632011-06-05 Juanma Barranquero <lekktu@gmail.com>
1664
1665 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1666
4b80f674
CY
16672011-06-04 Chong Yidong <cyd@stupidchicken.com>
1668
1669 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1670 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1671 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1672 New error handlers.
4b80f674
CY
1673 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1674 Obey Vx_select_enable_clipboard_manager. Catch errors in
1675 x_clipboard_manager_save (Bug#8779).
1676 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1677 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1678
99a33b77 16792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1680
1681 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1682
99a33b77 16832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1684
1685 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1686 in the current matrix if keep_current_p is non-zero.
1687
8264569d
EZ
16882011-06-04 Eli Zaretskii <eliz@gnu.org>
1689
1690 * bidi.c (bidi_level_of_next_char): Fix last change.
1691
57f97249
EZ
16922011-06-03 Eli Zaretskii <eliz@gnu.org>
1693
fec2107c 1694 Support bidi reordering of text covered by display properties.
57f97249 1695
fec2107c
EZ
1696 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1697 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1698 (bidi_cache_search, bidi_cache_iterator_state)
1699 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1700 (bidi_level_of_next_char, bidi_move_to_visually_next):
1701 Support character positions inside a run of characters covered by a
fec2107c
EZ
1702 display string.
1703 (bidi_paragraph_init, bidi_resolve_explicit_1)
1704 (bidi_level_of_next_char): Call bidi_fetch_char and
1705 bidi_fetch_char_advance instead of FETCH_CHAR and
1706 FETCH_CHAR_ADVANCE.
1707 (bidi_init_it): Initialize new members.
1708 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1709 definitions.
1710 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1711 instead of using explicit *_CHAR codes.
d6d100dd
SM
1712 (bidi_resolve_explicit, bidi_resolve_weak):
1713 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1714 bidirectional text is supported only in multibyte buffers.
1715 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1716 it to initialize the frame_window_p member of struct bidi_it.
1717 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1718 (bidi_resolve_explicit, bidi_resolve_weak)
1719 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1720 bidi_it->nchars is non-positive.
1721 (bidi_level_of_next_char): Don't try to lookup the cache for the
1722 next/previous character if nothing is cached there yet, or if we
1723 were just reseat()'ed to a new position.
c40e2fb2 1724
0e14fe90
EZ
1725 * xdisp.c (set_cursor_from_row): Set start and stop points
1726 according to the row's direction when priming the loop that looks
1727 for the glyph on which to display cursor.
1728 (single_display_spec_intangible_p): Function deleted.
1729 (display_prop_intangible_p): Reimplement to call
1730 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1731 Accept 3 additional arguments needed by handle_display_spec.
1732 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1733 values: lists, `(when COND...)' forms, etc.
1734 (single_display_spec_string_p): Support property values that are
1735 lists with the argument STRING its top-level element.
1736 (display_prop_string_p): Fix the condition for processing a
1737 property that is a list to be consistent with handle_display_spec.
fec2107c 1738 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1739 last portion of handle_display_prop.
1740 (compute_display_string_pos): Accept additional argument
1741 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1742 value of a `display' property is a "replacing spec".
1743 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1744 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1745 the display property, but just return a value indicating whether
1746 the display property will replace the characters it covers.
1747 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1748 frame_window_p members of struct bidi_it.
d6d100dd
SM
1749 (compute_display_string_pos, compute_display_string_end):
1750 New functions.
fec2107c
EZ
1751 (push_it): Accept second argument POSITION, where pop_it should
1752 jump to continue iteration.
1753 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1754
fec2107c
EZ
1755 * keyboard.c (adjust_point_for_property): Adjust the call to
1756 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1757
1758 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1759 (bidi_init_it): Update prototypes.
1760 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1761 (compute_display_string_pos, compute_display_string_end):
1762 Declare prototypes.
fec2107c
EZ
1763 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1764 EMACS_INT.
fc6f18ce 1765
40087514 17662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1767
57f53182
PE
1768 Malloc failure behavior now depends on size of allocation.
1769 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1770 * lisp.h: Change signatures accordingly.
1771 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1772 All callers changed. (Bug#8762)
1773
1774 * gnutls.c: Use Emacs's memory allocators.
1775 Without this change, the gnutls library would invoke malloc etc.
1776 directly, which causes problems on non-SYNC_INPUT hosts, and which
1777 runs afoul of improving memory_full behavior. (Bug#8761)
1778 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1779 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1780 xfree instead of the default malloc, realloc, free.
1781 (Fgnutls_boot): No need to check for memory allocation failure,
1782 since xmalloc does that for us.
1783
ac32cd99 1784 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1785 * category.c (hash_get_category_set):
1786 * ccl.c (ccl_driver):
1787 * charset.c (Fdefine_charset_internal):
1788 * charset.h (struct charset.hash_index):
1789 * composite.c (get_composition_id, gstring_lookup_cache)
1790 (composition_gstring_put_cache):
1791 * composite.h (struct composition.hash_index):
1792 * dispextern.h (struct image.hash):
1793 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1794 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1795 (hashfn_equal, hashfn_user_defined, make_hash_table)
1796 (maybe_resize_hash_table, hash_lookup, hash_put)
1797 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1798 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1799 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1800 * image.c (make_image, search_image_cache, lookup_image)
1801 (xpm_put_color_table_h):
1802 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1803 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1804 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1805 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1806 * alloc.c (allocate_vectorlike):
1807 Check for overflow in vector size calculations.
1808 * ccl.c (ccl_driver):
1809 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1810 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1811 need to be updated by these changes.
40087514
PE
1812 * fns.c (make_hash_table, maybe_resize_hash_table):
1813 Check for integer overflow with large hash tables.
0de4bb68
PE
1814 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1815 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1816 (SXHASH_REDUCE): New macro.
1817 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1818 Use it instead of discarding useful hash info with large hash values.
1819 (sxhash_float): New function.
1820 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1821 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1822 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1823 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1824 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1825 Adjust signatures to match updated version of code.
1826 (consing_since_gc): Now EMACS_INT, since a single hash table can
1827 use more than INT_MAX bytes.
1828
698d32e2
DN
18292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1830
1831 Make it possible to build with GCC-4.6+ -O2 -flto.
1832
1833 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1834
fd6fa53f
SM
18352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1836
1837 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1838 Call minibuffer-inactive-mode.
1839
864db017
JB
18402011-05-31 Juanma Barranquero <lekktu@gmail.com>
1841
1842 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1843 Update dependencies.
1844
2ad0baf4
DN
18452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1846
1847 * data.c (init_data): Remove code for UTS, this system is not
1848 supported anymore.
1849
4fcc2638
DN
18502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1851
1852 Don't force ./temacs to start in terminal mode.
1853
1854 * frame.c (make_initial_frame): Initialize faces in all cases, not
1855 only when CANNOT_DUMP is defined.
1856 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1857
c56e0fd5
DN
18582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1859
1860 * dispnew.c (add_window_display_history): Use const for the string
1861 pointer. Remove declaration, not needed.
1862
333d54da 18632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1864
55d4c1b2 1865 Use 'inline', not 'INLINE'.
333d54da 1866 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1867 * alloc.c, fontset.c (INLINE): Remove.
1868 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1869 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1870 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1871 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1872 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1873
738db178
DN
18742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1875
1876 Make it possible to run ./temacs.
1877
1878 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1879 syms_of_callproc does the same thing. Remove test for
1880 "initialized", do it in the caller.
1881 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1882
620c53a6
SM
18832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1884
1885 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1886 (read_minibuf): Use get_minibuffer.
1887 (syms_of_minibuf): Use DEFSYM.
1888 (Qmetadata): New var.
1889 * data.c (Qbuffer): Don't make it static.
1890 (syms_of_data): Use DEFSYM.
1891
e003a292
PE
18922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1893
1894 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1895 (CCL_CODE_MIN): New macro.
1896
ed008a6d
PE
18972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1898
3687c2ef
PE
1899 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1900
ed008a6d
PE
1901 * eval.c (Qdebug): Now static.
1902 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1903 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1904 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1905
d66c4c7c
CY
19062011-05-29 Chong Yidong <cyd@stupidchicken.com>
1907
1908 * image.c: Various fixes to ImageMagick code comments.
1909 (Fimagemagick_types): Doc fix.
1910
5fbc2025
PE
19112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1912
0196f88a
PE
1913 Minor fixes prompted by GCC 4.6.0 warnings.
1914
1915 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1916
5fbc2025
PE
1917 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1918 (x_clipboard_manager_save_all): Move extern decl to ...
1919 * xterm.h: ... here, so that it can be checked for consistency.
1920
1dd3c2d9
CY
19212011-05-29 Chong Yidong <cyd@stupidchicken.com>
1922
1923 * xselect.c (x_clipboard_manager_save_frame)
1924 (x_clipboard_manager_save_all): New functions.
1925 (Fx_clipboard_manager_save): Lisp function deleted.
1926
1927 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1928 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1929
1930 * xterm.h: Update prototype.
1931
5ba6571d
WX
19322011-05-28 William Xu <william.xwl@gmail.com>
1933
1934 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1935 exiting (Bug#8239).
1936
3eaff834
JM
19372011-05-28 Jim Meyering <meyering@redhat.com>
1938
e1900994 1939 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1940 * fns.c (to_uchar): Define.
1941 (crypto_hash_function): Use it to convert some newly-signed
1942 variables to unsigned, to avoid sign-extension bugs. For example,
1943 without this change, (md5 "truc") would evaluate to
1944 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1945 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1946 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1947
0f6990a7
PE
19482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 Integer overflow fixes.
c8a9ca5a 1951
08686060
PE
1952 * dbusbind.c: Serial number integer overflow fixes.
1953 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1954 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1955 to hold a serial number that is too large for a fixnum.
1956 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1957 Check for serial numbers out of range. Decode any serial number
59568bf0 1958 that was so large that it became a float. (Bug#8722)
08686060 1959
2d1fc3c7
PE
1960 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1961 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1962 Use XFASTINT rather than XUINT when numbers are nonnegative.
1963 (xd_append_arg, Fdbus_method_return_internal):
1964 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1965 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1966 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1967 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1968 (Bug#8722)
2d1fc3c7 1969
c8a9ca5a
PE
1970 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1971
519e1d69
PE
1972 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1973
30569699
PE
1974 ccl: add integer overflow checks
1975 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1976 (IN_INT_RANGE): New macros.
1977 (ccl_driver): Use them to check for integer overflow when
1978 decoding a CCL program. Many of the new checks are whether XINT (x)
1979 fits in int; it doesn't always, on 64-bit hosts. The new version
1980 doesn't catch all possible integer overflows, but it's an
847044ea 1981 improvement. (Bug#8719)
30569699 1982
c11285dc
PE
1983 * alloc.c (make_event_array): Use XINT, not XUINT.
1984 There's no need for unsigned here.
1985
fdccd48e
PE
1986 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1987 This follows up to the 2011-05-06 change that substituted uintptr_t
1988 for EMACS_INT. This case wasn't caught back then.
1989
37910ab2
PE
1990 Rework Fformat to avoid integer overflow issues.
1991 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1992 now (part of C89). Include <verify.h>.
1993 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1994 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1995 (Fformat): Avoid the prepass trying to compute sizes; it was only
1996 approximate and thus did not catch overflow reliably. Instead, walk
1997 through the format just once, formatting and computing sizes as we go,
1998 checking for integer overflow at every step, and allocating a larger
1999 buffer as needed. Keep track separately whether the format is
2000 multibyte. Keep only the most-recently calculated precision, rather
2001 than them all. Record whether each argument has been converted to
2002 string. Use EMACS_INT, not int, for byte and char and arg counts.
2003 Support field widths and precisions larger than INT_MAX. Avoid
2004 sprintf's undefined behavior with conversion specifications such as %#d
2005 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2006 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2007 formatting out-of-range floating point numbers with int
9173deec 2008 formats. (Bug#8668)
37910ab2 2009
2e6578fb
PE
2010 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2011
0ae6bdee
PE
2012 * data.c: Avoid integer truncation in expressions involving floats.
2013 * data.c: Include <intprops.h>.
2014 (arith_driver): When there's an integer overflow in an expression
2015 involving floating point, convert the integers to floating point
2016 so that the resulting value does not suffer from catastrophic
2017 integer truncation. For example, on a 64-bit host (* 4
2018 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2019 Do not rely on undefined behavior after integer overflow.
2020
de883a70
PE
2021 merge count_size_as_multibyte, parse_str_to_multibyte
2022 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2023 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2024 Check for integer overflow.
2025 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2026 since it's now a duplicate of the other. This is more of
2027 a character than a buffer op, so better that it's in character.c.
2028 * fns.c, print.c: Adjust to above changes.
2029
2ff916cb
PE
20302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2031
2032 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2033
f1b54466
PE
20342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2035
fb1ac845
PE
2036 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2037 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2038 (x_clipboard_manager_save): Now static.
2039 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2040
f1b54466
PE
2041 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2042 (crypto_hash_function): Now static.
2043 Fix pointer signedness problems. Avoid unnecessary initializations.
2044
a9f737ee
CY
20452011-05-27 Chong Yidong <cyd@stupidchicken.com>
2046
2047 * termhooks.h (Vselection_alist): Make it terminal-local.
2048
2049 * terminal.c (create_terminal): Initialize it.
2050
2051 * xselect.c: Support for clipboard managers.
2052 (Vselection_alist): Move to termhooks.h as terminal-local var.
2053 (LOCAL_SELECTION): New macro.
2054 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2055 (symbol_to_x_atom): Remove gratuitous arg.
2056 (x_handle_selection_request, lisp_data_to_selection_data)
2057 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2058 (x_own_selection, x_get_local_selection, x_convert_selection):
2059 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2060 (some_frame_on_display): Delete unused function.
2061 (Fx_own_selection_internal, Fx_get_selection_internal)
2062 (Fx_disown_selection_internal, Fx_selection_owner_p)
2063 (Fx_selection_exists_p): New optional frame arg.
2064 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2065 (x_handle_selection_clear): Don't treat other terminals with the
2066 same keyboard specially. Use the terminal-local Vselection_alist.
2067 (x_clear_frame_selections): Use Frun_hook_with_args.
2068
2069 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2070
2071 * xterm.h: Add support for those atoms.
2072
e067f0c1
CY
20732011-05-26 Chong Yidong <cyd@stupidchicken.com>
2074
2075 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2076 (converted_selections, conversion_fail_tag): New global variables.
2077 (x_selection_request_lisp_error): Free the above.
2078 (x_get_local_selection): Remove unnecessary code.
2079 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2080 of converted selections stored in converted_selections.
2081 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2082 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2083 (x_convert_selection): New function.
2084 (x_handle_selection_event): Simplify.
2085 (x_get_foreign_selection): Don't ignore incoming requests while
2086 waiting for an answer; this will fail when we implement
2087 SAVE_TARGETS, and seems unnecessary anyway.
2088 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2089 (Vx_sent_selection_functions): Doc fix.
2090
0f4aebc0
LL
20912011-05-26 Leo Liu <sdl.web@gmail.com>
2092
2093 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2094
e61124cd
YM
20952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2096
2097 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2098
2099 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2100 for fringe update if it has periodic bitmap.
2101 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2102 and fringe_bitmap_periodic_p.
2103
2104 * fringe.c (get_fringe_bitmap_data): New function.
2105 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2106 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2107 row. Mark glyph row for fringe update if periodicity changed.
2108
2109 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2110 for fringe update unless it has periodic bitmap.
2111
f16d9837
KH
21122011-05-25 Kenichi Handa <handa@m17n.org>
2113
2114 * xdisp.c (get_next_display_element): Set correct it->face_id for
2115 a static composition.
2116
e1b90ef6
LL
21172011-05-24 Leo Liu <sdl.web@gmail.com>
2118
2119 * deps.mk (fns.o):
2120 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2121
2122 * fns.c (crypto_hash_function, Fsha1): New function.
2123 (Fmd5): Use crypto_hash_function.
2124 (syms_of_fns): Add Ssha1.
2125
7400048f
PE
21262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * gnutls.c: Remove unused macros.
2129 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2130 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2131 Remove macros that are defined and never used.
2132 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2133
abb71cf4
CY
21342011-05-22 Chong Yidong <cyd@stupidchicken.com>
2135
2136 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2137 (Fx_get_selection_internal): Minor cleanup.
2138 (Fx_own_selection_internal): Rename arguments for consistency with
2139 select.el.
2140
6307db39
PE
21412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2142
2143 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2144
f3d4e0a4
CY
21452011-05-22 Chong Yidong <cyd@stupidchicken.com>
2146
2147 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2148
4d8ade89
YM
21492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2150
2151 * dispnew.c (scrolling_window): Don't exclude the case that the
2152 last enabled row in the desired matrix touches the bottom boundary.
2153
32078c8d
GM
21542011-05-21 Glenn Morris <rgm@gnu.org>
2155
2156 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2157 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2158 and add some more files.
32078c8d 2159
7285dc67
EZ
21602011-05-20 Eli Zaretskii <eliz@gnu.org>
2161
2162 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2163 report_file_error introduced by the change from 2011-05-07.
2164
89d1bd22
PE
21652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2166
2167 * systime.h (Time): Define only if emacs is defined.
2168 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2169 where the include path doesn't have X11/X.h by default. See
2170 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2171
e23640bb 21722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2173
2174 * composite.c (find_automatic_composition): Fix previous change.
2175
b9704ad9
GM
21762011-05-20 Glenn Morris <rgm@gnu.org>
2177
2178 * lisp.mk: New file, split from Makefile.in.
2179 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2180 (shortlisp): Remove.
2181 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2182
4a720484
GM
21832011-05-19 Glenn Morris <rgm@gnu.org>
2184
2185 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2186 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2187 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2188 (lisp): Set the order to that of loadup.el.
2189 (shortlisp): Make it a copy of $lisp.
2190 (SOME_MACHINE_LISP): Remove.
2191 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2192 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2193
a28d4396
KH
21942011-05-18 Kenichi Handa <handa@m17n.org>
2195
2196 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2197 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2198 (find_automatic_composition): Mostly rewrite for efficiency.
2199
a2b1fa8e
JB
22002011-05-18 Juanma Barranquero <lekktu@gmail.com>
2201
2202 * makefile.w32-in: Update dependencies.
2203
8e1f5610
CS
22042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2205
2206 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2207 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2208
7025ee00 22092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2210
cdfa6eab
PE
2211 Fix some integer overflow issues, such as string length overflow.
2212
06d6db33
PE
2213 * insdel.c (count_size_as_multibyte): Check for string overflow.
2214
2b4560a8
PE
2215 * character.c (lisp_string_width): Check for string overflow.
2216 Use EMACS_INT, not int, for string indexes and lengths; in
2217 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2218 the resulting string length overflows an EMACS_INT; instead,
2219 report a string overflow if no precision given. When checking for
2220 precision exhaustion, use a check that cannot possibly have
2221 integer overflow. (Bug#8675)
2222 * character.h (lisp_string_width): Adjust to new signature.
2223
cb93f9be
PE
2224 * alloc.c (string_overflow): New function.
2225 (Fmake_string): Use it. This doesn't change behavior, but saves
2226 a few bytes and will simplify future changes.
2227 * character.c (string_escape_byte8): Likewise.
2228 * lisp.h (string_overflow): New decl.
2229
1a1f3366
PE
2230 Fixups, following up to the user-interface timestamp change.
2231 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2232 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2233 * msdos.c (mouse_get_pos): Likewise.
2234 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2235 * w32gui.h (Time): Define by including "systime.h" rather than by
2236 declaring it ourselves. (Bug#8664)
2237
d4e3e4d3
PE
2238 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2239 * image.c (clear_image_cache): Likewise.
2240
f6a24d19
PE
2241 * term.c (term_mouse_position): Don't assume time_t wraparound.
2242
08dc5ae6
PE
2243 Be more systematic about user-interface timestamps.
2244 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2245 and sometimes 'EMACS_UINT', to represent these timestamps.
2246 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2247 This makes the code easier to follow, and makes it easier to catch
2248 integer overflow bugs such as Bug#8664.
2249 * frame.c (Fmouse_position, Fmouse_pixel_position):
2250 Use Time, not unsigned long, for user-interface timestamps.
2251 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2252 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2253 * keyboard.h (last_event_timestamp): Likewise.
2254 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2255 * menu.h (xmenu_show): Likewise.
2256 * term.c (term_mouse_position): Likewise.
2257 * termhooks.h (struct input_event.timestamp): Likewise.
2258 (struct terminal.mouse_position_hook): Likewise.
2259 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2260 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2261 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2262 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2263 what it was before.
2264 * menu.h, termhooks.h: Include "systime.h", for Time.
2265
8e55734a
PE
2266 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2267 Don't assume that the difference between two unsigned long values
2268 can fit into an integer. At this point, we know button_down_time
2269 <= event->timestamp, so the difference must be nonnegative, so
2270 there's no need to cast the result if double-click-time is
2271 nonnegative, as it should be; check that it's nonnegative, just in
2272 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2273 apart (about 25 days). (Bug#8664)
8e55734a 2274
841f1b75 2275 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2276 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2277
3e26f69c
PE
2278 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2279 that always fit in int. Use a sentinel instead of a counter, to
2280 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2281 * frame.h (struct frame): Use int for menu_bar_items_used
2282 instead of EMACS_INT, since it always fits in int.
3e26f69c 2283
5cc152c0
PE
2284 * menu.c (grow_menu_items): Check for int overflow.
2285
d89eb65e
PE
2286 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2287
5235bd3e
PE
2288 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2289 Before, the code was not consistent. These values cannot exceed
2290 2**31 - 1 so there's no need to make them unsigned.
2291 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2292 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2293 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2294 as modifiers.
2295 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2296
bc827e23
PE
2297 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2298 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2299 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2300 presumably because the widths might not match.
2301
78eb494e
PE
2302 * window.c (size_window): Avoid needless test at loop start.
2303
04f2d78b
CB
23042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2305
2306 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2307
d2fc7e3d 23082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2309
2310 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2311
d2fc7e3d 23122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2313
2314 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2315 `width' to `bar_area_x' and `bar_area_width', respectively.
2316 (x_scroll_run): Take account of fringe background extension.
2317
04f2d78b
CB
2318 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2319 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2320 `bar_area_width', respectively.
2321 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2322 background extension.
2323
79b70037
GM
23242011-05-10 Jim Meyering <meyering@redhat.com>
2325
2326 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2327
2f142cc5
JB
23282011-05-10 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * image.c (Finit_image_library): Return t for built-in image types,
2331 like pbm and xbm. (Bug#8640)
2332
57679c86
AS
23332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2334
2335 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2336
888c9e86
EZ
23372011-05-07 Eli Zaretskii <eliz@gnu.org>
2338
b0512a1d
EZ
2339 * w32console.c (Fset_screen_color): Doc fix.
2340 (Fget_screen_color): New function.
2341 (syms_of_ntterm): Defsubr it.
2342
7285dc67
EZ
2343 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2344 unlink the temporary file if Fcall_process didn't create it in the
2345 first place.
2346 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2347 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2348 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2349 cue to call_process_cleanup not to close that handle.
2350
4d3fcc8e
BK
23512011-05-07 Ben Key <bkey76@gmail.com>
2352
2353 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2354 one of two shell specific rules, either bootstrap-temacs-CMD or
2355 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2356 to the previous implementation of the bootstrap-temacs rule.
2357 The bootstrap-temacs-CMD rule is similar to the previous
2358 implementation of the bootstrap-temacs rule except that it
2359 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2360 variable.
2361
2362 These changes, along with some changes to nt/configure.bat,
2363 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2364 earlier fix to add support for --cflags and --ldflags options
2365 that include quotes so that it works whether make uses cmd or
2366 sh as the shell.
2367
b4289b64
MA
23682011-05-06 Michael Albinus <michael.albinus@gmx.de>
2369
2370 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2371 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2372 is a constant.
2373 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2374 a string. Handle both cases.
2375 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2376 (Fdbus_register_method): Use Qinvalid_function.
2377
af4c0e28
JB
23782011-05-06 Juanma Barranquero <lekktu@gmail.com>
2379
2380 * makefile.w32-in: Update dependencies.
2381 (LISP_H): Add inttypes.h and stdin.h.
2382 (PROCESS_H): Add unistd.h.
2383
c51453d9
EZ
23842011-05-06 Eli Zaretskii <eliz@gnu.org>
2385
2386 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2387 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2388
8ff0ac3c 23892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2390
4c4b566b
PE
2391 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2392
aab2b9b5
PE
2393 * term.c (vfatal): Remove stray call to va_end.
2394 It's not needed and the C Standard doesn't allow it here anyway.
2395
c378da0b
PE
2396 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2397 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2398
288b08c7
PE
2399 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2400 bytes.
2401
e3601888
PE
2402 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2403
db6c0e74
PE
2404 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2405
dd5963ea
PE
2406 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2407
88c9450f
PE
2408 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2409
2f9442b8
PE
2410 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2411
c032b5f8
PE
2412 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2413 * charset.c (Fdefine_charset_internal): Don't initialize
2414 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2415 32-bit int (Bug#8600).
a108c10b
PE
2416
2417 * lread.c (read_integer): Be more consistent with string-to-number.
2418 Use string_to_number to do the actual conversion; this avoids
2419 rounding errors and fixes some other screwups. Without this fix,
2420 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2421 (digit_to_number): Move earlier, for benefit of read_integer.
2422 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2423 not a digit in any supported base. (Bug#8602)
a108c10b 2424
ad5f9eea
PE
2425 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2426
aec1708a
PE
2427 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2428 to match comment at start of function. This also removes a
2429 GCC warning about overflow in a 32+64-bit port.
2430
47be4ab5
PE
2431 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2432
371cac43
PE
2433 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2434 Reported by Stefan Monnier in
2435 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2436 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2437 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2438
d01a7826
PE
2439 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2440 (EMACS_UINTPTR): Likewise, with uintptr_t.
2441
7fd47d5c
PE
2442 * lisp.h: Prefer 64-bit EMACS_INT if available.
2443 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2444 on 32-bit hosts that have 64-bit int, so that they can access
2445 large files.
122b0c86
PE
2446 However, temporarily disable this change unless the temporary
2447 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2448
8727937b
PE
2449 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2450
8ac068ac
PE
2451 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2452 This removes an assumption that EMACS_INT and long are the same
2453 width as pointers. The assumption is true for Emacs porting targets
2454 now, but we want to make other targets possible.
2455 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2456 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2457 In the rest of the code, change types of integers that hold casted
2458 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2459 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2460 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2461 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2462 No need to cast type when ORing.
2463 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2464 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2465 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2466 assume EMACS_INT is the same width as char *.
2467 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2468 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2469 Remove no-longer-needed casts.
2470 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2471 (xg_tool_bar_help_callback, xg_make_tool_item):
2472 Use EMACS_INTPTR to hold an integer
2473 that will be cast to void *; this can avoid a GCC warning
2474 if EMACS_INT is not the same width as void *.
2475 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2476 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2477 (current_message_1, set_message_1):
2478 Use a local to convert to proper width without a cast.
2479 * xmenu.c (dialog_selection_callback): Likewise.
2480
ede49d71
PE
2481 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2482 Also, don't assume VALBITS / RAND_BITS is less than 5,
2483 and don't rely on undefined behavior when shifting a 1 left into
2484 the sign bit.
2485 * lisp.h (get_random): Change signature to match.
2486
2f30ecd0
PE
2487 * lread.c (hash_string): Use size_t, not int, for hash computation.
2488 Normally we prefer signed values; but hashing is special, because
2489 it's better to use unsigned division on hash table sizes so that
2490 the remainder is nonnegative. Also, size_t is the natural width
2491 for hashing into memory. The previous code used 'int', which doesn't
2492 retain enough info to hash well into very large tables.
2493 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2494
2a866e7b
PE
2495 * dbusbind.c: Don't possibly lose pointer info when converting.
2496 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2497 Use XPNTR rather than XHASH, so that the high-order bits of
2498 the pointer aren't lost when converting through void *.
2499
51639eac
PE
2500 * eval.c (Fautoload): Don't double-shift a pointer.
2501
92394119
PE
2502 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2503
dbdb9a7c
JB
25042011-05-06 Juanma Barranquero <lekktu@gmail.com>
2505
2506 * gnutls.c (DEF_GNUTLS_FN):
2507 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2508
db7a0b4f
AS
25092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2510
2511 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2512 marker. (Bug#8610)
2513
f7ff1b0f 25142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2515
2516 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2517 New version that can reserve upto 2GB of heap space.
2518
f7ff1b0f 25192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2520
2521 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2522
639c109b
TZ
25232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2524
2525 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2526 `gnutls_certificate_set_x509_key_file'.
2527
d2127135
JB
25282011-05-05 Juanma Barranquero <lekktu@gmail.com>
2529
2530 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2531 Update dependencies.
2532
e968f4f3
JB
25332011-05-04 Juanma Barranquero <lekktu@gmail.com>
2534
2535 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2536 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2537 Remove unused parameter `fildes'.
2538 * process.c (read_process_output, send_process): Don't pass it.
2539
84d358f0
JB
25402011-05-04 Juanma Barranquero <lekktu@gmail.com>
2541
2542 Fix previous change: the library cache is defined in w32.c.
2543 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2544 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2545
0898ca10
JB
25462011-05-04 Juanma Barranquero <lekktu@gmail.com>
2547
2548 Implement dynamic loading of GnuTLS on Windows.
2549
2550 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2551 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2552 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2553 Declare.
2554
2555 * gnutls.c (Qgnutls_dll): Define.
2556 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2557 (gnutls_*): Declare function pointers.
2558 (init_gnutls_functions): New function to initialize function pointers.
2559 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2560 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2561 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2562 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2563 (emacs_gnutls_write, emacs_gnutls_read)
2564 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2565 (Fgnutls_available_p): New function.
2566 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2567 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2568 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2569
2570 * image.c: Include w32.h.
2571 (Vimage_type_cache): Delete.
2572 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2573 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2574 (w32_delayed_load): Move to w32.c.
2575
2576 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2577
2578 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2579 (w32_delayed_load): Move from image.c. When loading a library, record
2580 its filename in the :loaded-from property of the library id.
2581 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2582 Initialize and staticpro them.
2583 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2584
2585 * process.c: Include lisp.h before w32.h, not after.
2586 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2587 instead of gnutls_record_check_pending.
2588
2589 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2590
ff4de4aa
TZ
25912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2592
2593 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2594 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2595 as passed in.
2596
abe95abb
JD
25972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2598
2599 * xterm.c (x_set_frame_alpha): Do not set property on anything
2600 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2601
e16e55d4
JB
26022011-05-02 Juanma Barranquero <lekktu@gmail.com>
2603
2604 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2605
bafcf6a5
JB
26062011-05-02 Juanma Barranquero <lekktu@gmail.com>
2607
2608 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2609 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2610 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2611 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2612 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2613 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2614 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2615 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2616 (Qgnutls_bootprop_callbacks_verify): Make static.
2617
e7a6747f
AS
26182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2619
19ed11ba
AS
2620 * callproc.c: Indentation fixup.
2621
e7a6747f 2622 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2623 (wait_for_termination, interruptible_wait_for_termination):
2624 Move after wait_for_termination_1.
e7a6747f 2625
1ef14cb4
LMI
26262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2627
2628 * sysdep.c (interruptible_wait_for_termination): New function
2629 which is like wait_for_termination, but allows keyboard
2630 interruptions.
2631
2632 * callproc.c (Fcall_process): Add (:file "file") as an option for
2633 the STDOUT buffer.
2634 (Fcall_process_region): Ditto.
2635
330d880c
EZ
26362011-04-30 Eli Zaretskii <eliz@gnu.org>
2637
8db90b73
EZ
2638 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2639 rather than `XVECTOR (FOO)->size'.
2640
330d880c
EZ
2641 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2642 inttypes.h, as a gnulib replacement is used if it not available in
2643 system headers.
2644
15cbd324
EZ
26452011-04-21 Eli Zaretskii <eliz@gnu.org>
2646
2647 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2648 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2649 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2650
2651 * coding.c (coding_alloc_by_realloc): Error out if destination
2652 will grow beyond MOST_POSITIVE_FIXNUM.
2653 (decode_coding_emacs_mule): Abort if there isn't enough place in
2654 charbuf for the composition carryover bytes. Reserve an extra
2655 space for up to 2 characters produced in a loop.
2656 (decode_coding_iso_2022): Abort if there isn't enough place in
2657 charbuf for the composition carryover bytes.
2658
26592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2660
ae940cca
EZ
2661 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2662 aborting when %lld or %lll format is passed.
2663 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2664 %llo or %llx format is passed. (Bug#8545)
2665
03ab8921
EZ
2666 * window.c (window_scroll_line_based): Use a marker instead of
2667 simple variables to record original value of point. (Bug#7952)
2668
afda1437
EZ
2669 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2670 produced by %s or %c overflows available buffer space. (Bug#8545)
2671
f76dee0c
PE
26722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2675 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2676
fdc5744d
JB
26772011-04-28 Juanma Barranquero <lekktu@gmail.com>
2678
2679 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2680
638f053a
JB
26812011-04-28 Juanma Barranquero <lekktu@gmail.com>
2682
2683 * keyboard.c (Qdelayed_warnings_hook): Define.
2684 (command_loop_1): Run `delayed-warnings-hook'
2685 if Vdelayed_warnings_list is non-nil.
2686 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2687 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2688
d178f871
EZ
26892011-04-28 Eli Zaretskii <eliz@gnu.org>
2690
2691 * doprnt.c (doprnt): Don't return value smaller than the buffer
2692 size if the message was truncated. (Bug#8545).
2693
b124fd93
JB
26942011-04-28 Juanma Barranquero <lekktu@gmail.com>
2695
2696 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2697 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2698
e810457d
PE
26992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2702
ea51cceb
JB
27032011-04-27 Juanma Barranquero <lekktu@gmail.com>
2704
2705 * makefile.w32-in: Update dependencies.
2706
94dcfacf
EZ
27072011-04-27 Eli Zaretskii <eliz@gnu.org>
2708
2709 Improve `doprnt' and its usage. (Bug#8545)
2710 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2711 `format_end'. Remove support for %l as a conversion specifier.
2712 Don't use xrealloc. Improve diagnostics when the %l size modifier
2713 is used. Update the commentary.
2714
2715 * eval.c (verror): Simplify calculation of size_t.
2716
2717 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2718 messages.
2719
f61f41d7
PE
27202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2721
2722 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2723 change.
2724
96fb4434
PE
27252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2726
2727 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2728 This makes this file independent of the recent pseudovector change.
2729
671875da 27302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2731
69e9b5a3
PE
2732 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2733
b5f869a7 2734 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2735 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2736 Remove unused local.
c8926152 2737 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2738
841a1577 2739 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2740 GCC 4.6.0 optimizes based on type-based alias analysis.
2741 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2742 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2743 != &v->size, and therefore "v->size = 1; b->size = 2; return
2744 v->size;" must therefore return 1. This assumption is incorrect
2745 for Emacs, since it type-puns struct Lisp_Vector * with many other
2746 types. To fix this problem, this patch adds a new type struct
f904488f 2747 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2748 and pseudovectors, and helps optimizing compilers not get fooled
2749 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2750 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2751 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2752 the size member.
eab3844f
PE
2753 (XSETPVECTYPE): Rewrite in terms of new macro.
2754 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2755 This is a bit clearer, and further avoids the possibility of
2756 undesirable aliasing.
2757 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2758 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2759 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2760 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2761 (ASIZE): Now uses header.size rather than size.
2762 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2763 to avoid the hassle of writing XVECTOR (foo)->header.size.
2764 (struct vectorlike_header): New type.
eab3844f
PE
2765 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2766 object, to help avoid aliasing.
2767 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2768 (SUBRP): Likewise, since Lisp_Subr is a special case.
2769 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2770 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2771 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2772 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2773 changed to be "header.size" and "header.next".
2774 * buffer.h (struct buffer): Likewise.
2775 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2776 * frame.h (struct frame): Likewise.
2777 * process.h (struct Lisp_Process): Likewise.
2778 * termhooks.h (struct terminal): Likewise.
2779 * window.c (struct save_window_data, struct saved_window): Likewise.
2780 * window.h (struct window): Likewise.
2781 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2782 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2783 * buffer.c (init_buffer_once): Likewise.
2784 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2785 special case.
2786 * process.c (Fformat_network_address): Use local var for size,
2787 for brevity.
2788
0df1eac5
PE
2789 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2790
847ab9d1 2791 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2792 * data.c (atof): Remove decl; no longer used or needed.
2793 (digit_to_number): Move to lread.c.
2794 (Fstring_to_number): Use new string_to_number function, to be
2795 consistent with how the Lisp reader treats infinities and NaNs.
2796 Do not assume that floating-point numbers represent EMACS_INT
2797 without losing information; this is not true on most 64-bit hosts.
2798 Avoid double-rounding errors, by insisting on integers when
2799 parsing non-base-10 numbers, as the documentation specifies.
2800 * lisp.h (string_to_number): New decl, replacing ...
2801 (isfloat_string): Remove.
bc0a5c13 2802 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2803 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2804 appears to have been a coding error. Similarly, do not accept
2805 strings like +-1e0 as floating point numbers. Do not report
2806 overflow for integer overflows unless the base is not 10 which
2807 means we have no simple and reliable way to continue.
2808 Break out the floating-point parsing into a new
2809 function string_to_number, so that Fstring_to_number parses
2810 floating point numbers consistently with the Lisp reader.
04f2d78b 2811 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2812 (E_CHAR, EXP_INT): Remove, replacing with ...
2813 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2814 (string_to_number): New function, replacing isfloat_string.
2815 This function checks for valid syntax and produces the resulting
2816 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2817 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2818 so that overflow for non-base-10 numbers is reported only when
2819 there's no portable and simple way to convert to floating point.
452f4150 2820
67769ffc
PE
2821 * textprop.c (set_text_properties_1): Rewrite for clarity,
2822 and to avoid GCC warning about integer overflow.
2823
c20db43f
PE
2824 * intervals.h (struct interval): Use EMACS_INT for members
2825 where EMACS_UINT might cause problems. See
2826 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2827 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2828 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2829 All uses changed.
37aa2f85
PE
2830 (offset_intervals): Tell GCC not to worry about length overflow
2831 when negating a negative length.
c20db43f 2832
2538aa2f
PE
2833 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2834 (overrun_check_free): Likewise.
2835
f2d3008d
PE
2836 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2837 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2838 word size.
2839
ec8df744
PE
2840 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2841 (gnutls_make_error): Rename local to avoid shadowing.
2842 (gnutls_emacs_global_deinit): ifdef out; not used.
2843 (Fgnutls_boot): Use const for pointer to readonly storage.
2844 Comment out unused local. Fix pointer signedness problems.
2845
640ee02d
PE
2846 * lread.c (openp): Don't stuff size_t into an 'int'.
2847 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2848 about possible signed overflow.
2849
6048fb2a
PE
2850 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2851 (GDK_KEY_g): Don't define if already defined.
2852 (xg_prepare_tooltip): Avoid pointer signedness problem.
2853 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2854
fa3c87e1
PE
2855 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2856 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2857
2172544b
PE
2858 * xfns.c (Fx_window_property): Simplify a bit,
2859 to make a bit faster and to avoid GCC 4.6.0 warning.
2860 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2861
9b821a21
PE
2862 * fns.c (internal_equal): Don't assume size_t fits in int.
2863
3c616cfa
PE
2864 * alloc.c (compact_small_strings): Tighten assertion a little.
2865
c2982e87
PE
2866 Replace pEd with more-general pI, and fix some printf arg casts.
2867 * lisp.h (pI): New macro, generalizing old pEd macro to other
2868 conversion specifiers. For example, use "...%"pI"d..." rather
2869 than "...%"pEd"...".
2870 (pEd): Remove. All uses replaced with similar uses of pI.
2871 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2872 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2873 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2874 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2875 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2876 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2877 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2878 64-bit hosts.
2879 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2880 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2881 * print.c (safe_debug_print, print_object): Likewise.
2882 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2883 to int.
6f04d126
PE
2884 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2885 avoiding the 0 flag, which is not portable.
c2982e87
PE
2886 * process.c (Fmake_network_process): Use pI to avoid cast.
2887 * region-cache.c (pp_cache): Likewise.
2888 * xdisp.c (decode_mode_spec): Likewise.
2889 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2890 behavior on 64-bit hosts with printf arg.
6f04d126 2891 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2892 (x_stop_queuing_selection_requests): Likewise.
2893 (x_get_window_property): Don't truncate byte count to an 'int'
2894 when tracing.
0b432f21 2895
5e073ec7
PE
2896 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2897 here, since it parses constructs like leading '-' and spaces,
2898 which are not wanted; and it overflows with large numbers.
2899 Instead, simply match F[0-9]+, which is what is wanted anyway.
2900
36372bf9
PE
2901 * alloc.c: Remove unportable assumptions about struct layout.
2902 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2903 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2904 (allocate_vectorlike, make_pure_vector): Use the new macros,
2905 plus offsetof, to remove unportable assumptions about struct layout.
2906 These assumptions hold on all porting targets that I know of, but
2907 they are not guaranteed, they're easy to remove, and removing them
2908 makes further changes easier.
2909
0b432f21
PE
2910 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2911 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2912 (string_overrun_cookie): Now const. Use initializers that
2913 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2914 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2915 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2916 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2917 multiple of sizeof (EMACS_INT); it need not be, if
2918 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2919 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2920
895009e1
JB
29212011-04-26 Juanma Barranquero <lekktu@gmail.com>
2922
2923 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2924
6a7a1b0b
TZ
29252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2926
2927 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2928 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2929 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2930
841a1577 29312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2932
2933 * lisp.h (Qdebug): List symbol.
895009e1 2934 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2935 * keyboard.c (debug-on-event): New variable.
2936 (handle_user_signal): Break into debugger when debug-on-event
2937 matches the current signal symbol.
2938
f2d3ba6f
DN
29392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2940
2941 * alloc.c (check_sblock, check_string_bytes)
2942 (check_string_free_list): Convert to standard C.
2943
42ce4c63
TZ
29442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2945
2946 * w32.c (emacs_gnutls_push): Fix typo.
2947
825cd63c
EZ
29482011-04-25 Eli Zaretskii <eliz@gnu.org>
2949
fb11d64d
EZ
2950 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2951 "cast to pointer from integer of different size".
2952
825cd63c
EZ
2953 Improve doprnt and its use in verror. (Bug#8545)
2954 * doprnt.c (doprnt): Document the set of format control sequences
2955 supported by the function. Use SAFE_ALLOCA instead of always
2956 using `alloca'.
2957
2958 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2959 is one byte too soon. Don't use xrealloc; instead xfree and
2960 xmalloc anew.
2961
e061a11b
TZ
29622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2963
2964 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2965 callbacks stage.
2966
2967 * gnutls.c: Renamed global_initialized to
2968 gnutls_global_initialized. Added internals for the
2969 :verify-hostname-error, :verify-error, and :verify-flags
2970 parameters of `gnutls-boot' and documented those parameters in the
2971 docstring. Start callback support.
9173deec
JB
2972 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2973 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2974 on error. Return error code.
e061a11b
TZ
2975 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2976 (emacs_gnutls_read): Likewise.
2977 (Fgnutls_boot): Return handshake error code.
2978 (emacs_gnutls_handle_error): New function.
2979 (wsaerror_to_errno): Likewise.
2980
2981 * w32.h (emacs_gnutls_pull): Add prototype.
2982 (emacs_gnutls_push): Likewise.
2983
2984 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2985 (emacs_gnutls_push): Likewise.
2986
29872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2988
2989 * process.c (wait_reading_process_output): Check if GnuTLS
2990 buffered some data internally if no FDs are set for TLS
2991 connections.
2992
2993 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2994 (LIBS): Link to USER_LIBS.
2995 ($(BLD)/gnutls.$(0)): New target.
2996
fa6996bc
EZ
29972011-04-24 Eli Zaretskii <eliz@gnu.org>
2998
eb35682e
EZ
2999 * xdisp.c (handle_single_display_spec): Rename the
3000 display_replaced_before_p argument into display_replaced_p, to
3001 make it consistent with the commentary. Fix typos in the
3002 commentary.
3003
e2ad650c
EZ
3004 * textprop.c (syms_of_textprop): Remove dead code.
3005 (copy_text_properties): Delete obsolete commentary about an
3006 interface that was deleted long ago. Fix typos in the description
3007 of arguments.
3008
1b2de274
EZ
3009 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3010 to changes in oldXMenu/XMenu.h from 2011-04-16.
3011 <menu_help_message, prev_menu_help_message>: Constify.
3012 (IT_menu_make_room): menu->help_text is now `const char **';
3013 adjust.
3014
3015 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3016 to changes in oldXMenu/XMenu.h from 2011-04-16.
3017 (struct XMenu): Declare `help_text' `const char **'.
3018
3019 * xfaces.c <Qunspecified>: Make extern again.
3020
3021 * syntax.c: Include sys/types.h before including regex.h, as
3022 required by Posix.
3023
762b15be
EZ
3024 * doc.c (get_doc_string): Improve the format passed to `error'.
3025
3026 * doprnt.c (doprnt): Improve commentary.
3027
3028 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3029
3030 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3031 them with etags.
3032
f1052e5d
EZ
3033 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3034 changes in globals.h immediately force recompilation.
762b15be
EZ
3035 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3036 $(CURDIR)/s/ms-w32.h.
3037 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3038
fa6996bc
EZ
3039 * character.c (Fchar_direction): Function deleted.
3040 (syms_of_character): Don't defsubr it.
3041 <char-direction-table>: Deleted.
3042
e6c3da20
EZ
30432011-04-23 Eli Zaretskii <eliz@gnu.org>
3044
3045 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3046 * doprnt.c: Include limits.h.
3047 (SIZE_MAX): New macro.
04f2d78b
CB
3048 (doprnt): Return a size_t value. 2nd arg is now size_t.
3049 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3050 Improve overflow protection. Support `l' modifier for integer
3051 conversions. Support %l conversion. Don't assume an EMACS_INT
3052 argument for integer conversions and for %c.
3053
3054 * lisp.h (doprnt): Restore prototype.
3055
3056 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3057 $(SRC)/character.h.
3058
3059 * Makefile.in (base_obj): Add back doprnt.o.
3060
3061 * deps.mk (doprnt.o): Add back prerequisites.
3062 (callint.o): Depend on character.h.
3063
3064 * eval.c (internal_lisp_condition_case): Include the handler
3065 representation in the error message.
3066 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3067 when breaking from the loop.
3068
3069 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3070
3071 * callint.c (Fcall_interactively): When displaying error message
3072 about invalid control letter, pass the character's codepoint, not
3073 a pointer to its multibyte form. Improve display of the character
3074 in octal and display also its hex code.
3075
3076 * character.c (char_string): Use %x to display the (unsigned)
3077 codepoint of an invalid character, to avoid displaying a bogus
3078 negative value.
3079
3080 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3081 `error', not SYMBOL_NAME itself.
3082
3083 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3084 character arguments to `error'.
3085
3086 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3087 to `error' in error message about FINAL_CHAR argument. Make sure
3088 FINAL_CHAR is a character, and use %c when it is passed as
3089 argument to `error'.
3090
4ffd0d6b 30912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3092
3093 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3094
3095 * w32.c: Include <time.h>.
3096 (sys_localtime): New function.
3097
4ffd0d6b 30982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3099
3100 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3101
4ffd0d6b 3102 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3103
4ffd0d6b 31042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3105
4ffd0d6b
GM
3106 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3107 zombies (Bug#8467).
aac0c6e3 3108
04c56954
EZ
31092011-04-19 Eli Zaretskii <eliz@gnu.org>
3110
3111 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3112 gl_state.e_property when gl_state.object is Qt.
3113
3114 * insdel.c (make_gap_larger): Remove limitation of buffer size
3115 to <= INT_MAX.
3116
16a43933
CY
31172011-04-18 Chong Yidong <cyd@stupidchicken.com>
3118
3119 * xdisp.c (lookup_glyphless_char_display)
3120 (produce_glyphless_glyph): Handle cons cell entry in
3121 glyphless-char-display.
3122 (Vglyphless_char_display): Document it.
3123
3124 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3125 glyphless-char-display.
3126
4581706e
CY
31272011-04-17 Chong Yidong <cyd@stupidchicken.com>
3128
3129 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3130
3131 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3132
3133 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3134 definition for no-X builds.
3135
4887c6e2 31362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3137
fd35b6f9
PE
3138 Static checks with GCC 4.6.0 and non-default toolkits.
3139
5c1ccb01
PE
3140 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3141
006c5daa
PE
3142 * process.c (keyboard_bit_set): Define only if SIGIO.
3143 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3144 (send_process): Repair possible setjmp clobbering.
3145
efc736d3
PE
3146 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3147
4e2fe2e6
PE
3148 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3149
f97334a2
PE
3150 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3151
4e75f29d
PE
3152 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3153 Define only if needed.
3154
90efadd1
PE
3155 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3156 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3157 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3158
3c647824
PE
3159 * dispextern.h (struct redisplay_interface): Rename param
3160 to avoid shadowing.
e264f262 3161 * termhooks.h (struct terminal): Likewise.
761383f4 3162 * xterm.c (xembed_send_message): Likewise.
3c647824 3163
b58c5c4a
PE
3164 * insdel.c (make_gap_smaller): Define only if
3165 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3166
cad59032
PE
3167 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3168 it.
3169
c339dc2e
PE
3170 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3171 so that we aren't warned about unused symbols.
3172
91a3e27b
PE
3173 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3174
399c71d3 3175 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3176
8ffc96f5
PE
3177 * xfns.c (x_real_positions): Mark locals as initialized.
3178
eef9bc79
PE
3179 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3180
098db9dd
PE
3181 * xterm.c: Fix problems found by static analysis with other toolkits.
3182 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3183 (x_dispatch_event): Declare static if USE_GTK, and
3184 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3185 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3186 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3187 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3188 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3189
eb18f6cc
PE
3190 * xmenu.c (menu_help_callback): Pointer type fixes.
3191 Use const pointers when pointing at readonly data. Avoid pointer
3192 signedness clashes.
3193 (FALSE): Remove unused macro.
3194 (update_frame_menubar): Remove unused decl.
3195
1fe72bf8
PE
3196 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3197
60d9e1db
PE
3198 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3199 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3200 (single_menu_item): Rename local to avoid shadowing.
3201
39261c26
PE
3202 * keyboard.c (make_lispy_event): Remove unused local var.
3203
018c5e19
PE
3204 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3205 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3206
63d2b86e
PE
3207 * bitmaps: Change bitmaps from unsigned char back to the X11
3208 compatible char. Avoid the old compiler warnings about
3209 out-of-range initializers by using, for example, '\xab' rather
3210 than 0xab.
3211
aefd87e1
PE
3212 * xgselect.c (xgselect_initialize): Check vs interface
3213 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3214
bf501fb9
PE
3215 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3216
e9829fdf
PE
3217 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3218 to read-only memory.
3219
1086c095
PE
3220 * fns.c (vector): Remove; this old hack is no longer needed.
3221
2baccd04 3222 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3223 Remove unused var.
dde42981 3224 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3225
72391843 3226 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3227
436c16df 3228 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3229 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3230 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3231
92bb796d 3232 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3233 (x_term_init): Remove local to avoid shadowing.
92bb796d 3234
764430a3 3235 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3236
3237 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3238 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3239
d1dfb56c
EZ
32402011-04-16 Eli Zaretskii <eliz@gnu.org>
3241
c4354cb4
EZ
3242 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3243
d1dfb56c
EZ
3244 Fix regex.c, syntax.c and friends for buffers > 2GB.
3245 * syntax.h (struct gl_state_s): Declare character position members
3246 EMACS_INT.
3247
3248 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3249
04f2d78b
CB
3250 * textprop.c (verify_interval_modification, interval_of):
3251 Declare arguments EMACS_INT.
d1dfb56c
EZ
3252
3253 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3254 EMACS_INT.
3255
3256 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3257
3258 * indent.c (Fvertical_motion): Local variable it_start is now
3259 EMACS_INT.
3260
3261 * regex.c (re_match, re_match_2, re_match_2_internal)
3262 (bcmp_translate, regcomp, regexec, print_double_string)
3263 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3264 (re_compile_pattern, re_exec): Declare arguments and local
3265 variables `size_t' and `ssize_t' and return values `regoff_t', as
3266 appropriate.
3267 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3268 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3269 <compile_stack_type>: `size' and `avail' are now `size_t'.
3270
3271 * regex.h <regoff_t>: Use ssize_t, not int.
3272 (re_search, re_search_2, re_match, re_match_2): Arguments that
3273 specify buffer/string position and length are now ssize_t and
3274 size_t. Return type is regoff_t.
3275
613052cd
BK
32762011-04-16 Ben Key <bkey76@gmail.com>
3277
3278 * nsfont.m: Fixed bugs in ns_get_family and
3279 ns_descriptor_to_entity that were caused by using free to
3280 deallocate memory blocks that were allocated by xmalloc (via
3281 xstrdup). This caused Emacs to crash when compiled with
3282 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3283 --enable-checking=xmallocoverrun). xfree is now used to
3284 deallocate these memory blocks.
3285
4170f62f 32862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3287
71b41406
PE
3288 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3289
9587a89d
PE
3290 emacs_write: Accept and return EMACS_INT for sizes.
3291 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3292 et seq.
3293 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3294 Accept and return EMACS_INT.
3295 (emacs_gnutls_write): Return the number of bytes written on
3296 partial writes.
3297 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3298 (emacs_read, emacs_write): Remove check for negative size, as the
3299 Emacs source code has been audited now.
9587a89d
PE
3300 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3301 (emacs_read, emacs_write): Use it.
273a5f82
PE
3302 * process.c (send_process): Adjust to the new signatures of
3303 emacs_write and emacs_gnutls_write. Do not attempt to store
3304 a byte offset into an 'int'; it might overflow.
9587a89d 3305 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3306
3e047f51
PE
3307 * sound.c: Don't assume sizes fit in 'int'.
3308 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3309 Return EMACS_INT, not int.
3e047f51 3310 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3311 Accept EMACS_INT, not int.
3312 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3313 record read return values.
3314
cc39a9db
BK
33152011-04-15 Ben Key <bkey76@gmail.com>
3316
c9d0ec6d
JB
3317 * keyboard.c (Qundefined): Don't declare static since it is used
3318 in nsfns.m.
3319 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3320 static since they are used in nsfont.m.
cc39a9db 3321
6c60eb9f
SM
33222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3323
3324 * process.c (Qprocessp): Don't declare static.
3325 * lisp.h (Qprocessp): Declare again.
3326
7990b61a
JB
33272011-04-15 Juanma Barranquero <lekktu@gmail.com>
3328
3329 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3330
5d4cb038
PE
33312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3332
8bd7b830 3333 Improve C-level modularity by making more things 'static'.
cd64ea1d 3334
e3b27b31
PE
3335 Don't publish debugger-only interfaces to other modules.
3336 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3337 (verify_bytepos, count_markers): Move decls to the only modules
3338 that need them.
3339 * region-cache.h (pp_cache): Likewise.
3340 * window.h (check_all_windows): Likewise.
3341 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3342
5d4cb038
PE
3343 * sysdep.c (croak): Now static, if
3344 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3345 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3346
3347 * alloc.c (refill_memory_reserve): Now static if
3348 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3349 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3350
e87b6180
PE
3351 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3352 Define only if USE_LUCID.
3353
ac64929e
PE
3354 * xrdb.c (x_customization_string, x_rm_string): Now static.
3355
6f37259d
PE
3356 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3357 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3358
1683e3ab
PE
3359 * xdisp.c (draw_row_with_mouse_face): Now static.
3360 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3361
de9c2632
PE
3362 * window.h (check_all_windows): Mark externally visible.
3363
2b96acb7
PE
3364 * window.c (window_deletion_count): Now static.
3365
3366 * undo.c: Make symbols static if they're not exported.
3367 (last_undo_buffer, last_boundary_position, pending_boundary):
3368 Now static.
3369
50436f33
PE
3370 * textprop.c (interval_insert_behind_hooks): Now static.
3371 (interval_insert_in_front_hooks): Likewise.
3372
64520e5c
PE
3373 * term.c: Make symbols static if they're not exported.
3374 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3375 (max_frame_lines, tty_set_terminal_modes):
3376 (tty_reset_terminal_modes, tty_turn_off_highlight):
3377 (get_tty_terminal): Now static.
3378 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3379 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3380 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3381 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3382 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3383
1fa53021
PE
3384 * sysdep.c: Make symbols static if they're not exported.
3385 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3386 Now static.
3387 (sigprocmask_set, full_mask): Remove; unused.
3388 (wait_debugging): Mark as visible.
3389 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3390 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3391
d4b43b22
PE
3392 * syntax.c (syntax_temp): Define only if !__GNUC__.
3393
b7c513d0
PE
3394 * sound.c (current_sound_device, current_sound): Now static.
3395
989b29ad
PE
3396 * search.c (searchbufs, searchbuf_head): Now static.
3397
13a55a78
PE
3398 * scroll.c (scroll_cost): Remove; unused.
3399 * dispextern.h (scroll_cost): Remove decl.
3400
de68a1fc
PE
3401 * region-cache.h (pp_cache): Mark as externally visible.
3402
40ccffa6
PE
3403 * process.c: Make symbols static if they're not exported.
3404 (process_tick, update_tick, create_process, chan_process):
3405 (Vprocess_alist, proc_buffered_char, datagram_access):
3406 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3407 (deactivate_process): Mark defn as static, as well as decl.
3408 * lisp.h (create_process): Remove decl.
3409 * process.h (chan_process, Vprocess_alist): Remove decls.
3410
ad64fc97
PE
3411 * print.c: Make symbols static if they're not exported.
3412 (print_depth, new_backquote_output, being_printed, print_buffer):
3413 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3414 (print_interval, print_number_index, initial_stderr_stream):
3415 Now static.
3416 * lisp.h (Fprinc): Remove decl.
3417 (debug_output_compilation_hack): Mark as externally visible.
3418
adddb265
PE
3419 * sysdep.c (croak): Move decl from here to syssignal.h.
3420 * syssignal.h (croak): Put it here, so the API can be checked when
3421 'croak' is called from dissociate_if_controlling_tty.
3422
1717ede2
PE
3423 * minibuf.c: Make symbols static if they're not exported.
3424 (minibuf_save_list, choose_minibuf_frame): Now static.
3425 * lisp.h (choose_minibuf_frame): Remove decl.
3426
fa5fb2bc
PE
3427 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3428
1e3890d1
PE
3429 * lread.c: Make symbols static if they're not exported.
3430 (read_objects, initial_obarray, oblookup_last_bucket_number):
3431 Now static.
3432 (make_symbol): Remove; unused.
3433 * lisp.h (initial_obarray, make_symbol): Remove decls.
3434
8a1414fa
PE
3435 * keyboard.c: Make symbols static if they're not exported.
3436 (single_kboard, recent_keys_index, total_keys, recent_keys):
3437 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3438 (this_single_command_key_start, echoing, last_auto_save):
3439 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3440 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3441 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3442 (Vlispy_mouse_stem, double_click_count):
3443 Now static.
3444 (force_auto_save_soon): Define only if SIGDANGER.
3445 (ignore_mouse_drag_p): Now static if
3446 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3447 (print_help): Remove; unused.
3448 (stop_character, last_timer_event): Mark as externally visible.
3449 * keyboard.h (ignore_mouse_drag_p): Declare only if
3450 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3451 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3452 * lisp.h (echoing): Remove decl.
3453 (force_auto_save_soon): Declare only if SIGDANGER.
3454 * xdisp.c (redisplay_window): Simplify code, to make it more
3455 obvious that ignore_mouse_drag_p is not accessed if !defined
3456 USE_GTK && !defined HAVE_NS.
3457
93ea6e8f
PE
3458 * intervals.c: Make symbols static if they're not exported.
3459 (merge_properties_sticky, merge_interval_right, delete_interval):
3460 Now static.
3461 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3462
77382fcc
PE
3463 * insdel.c: Make symbols static if they're not exported.
3464 However, leave prepare_to_modify_buffer alone. It's never
3465 called from outside this function, but that appears to be a bug.
3466 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3467 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3468 (adjust_after_replace_noundo): Remove; unused.
3469 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3470 (signal_before_change): Remove decls.
77382fcc 3471
9306c32e
PE
3472 * indent.c (val_compute_motion, val_vmotion): Now static.
3473
cd44d2eb
PE
3474 * image.c: Make symbols static if they're not exported.
3475 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3476 if USE_GTK.
3477 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3478 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3479
ad9a7a06
PE
3480 * fringe.c (standard_bitmaps): Now static.
3481 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3482
81626931
PE
3483 * frame.c: Make symbols static if they're not exported.
3484 (x_report_frame_params, make_terminal_frame): Now static.
3485 (get_frame_param): Now static, unless HAVE_NS.
3486 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3487 (x_get_resource_string): Remove; not used.
3488 * frame.h (make_terminal_frame, x_report_frame_params):
3489 (x_get_resource_string); Remove decls.
3490 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3491 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3492
239f9db9
PE
3493 * font.c, fontset.c: Make symbols static if they're not exported.
3494 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3495 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3496 * font.c (font_close_object): Now static.
3497 * font.h (font_close_object): Remove.
3498 * fontset.c (FONTSET_OBJLIST): Remove.
3499 (free_realized_fontset) #if-0 the body, which does nothing.
3500 (face_suitable_for_char_p): #if-0, as it's never called.
3501 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3502 * xfaces.c (face_at_string_position):
3503 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3504 since 0 is always ASCII.
3505
dfcf3579
PE
3506 * fns.c (weak_hash_tables): Now static.
3507
5045092b
PE
3508 * fileio.c: Make symbols static if they're not exported.
3509 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3510 (Vwrite_region_annotation_buffers): Now static.
3511
57a96f5c
PE
3512 * eval.c: Make symbols static if they're not exported.
3513 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3514 * lisp.h (backtrace_list): Remove decl.
3515
35f08c38
PE
3516 * emacs.c: Make symbols static if they're not exported.
3517 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3518 (fatal_error_code, fatal_error_signal_hook, standard_args):
3519 Now static.
3520 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3521 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3522 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3523 * lisp.h (fatal_error_signal_hook): Remove decl.
3524 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3525
f44bd759
PE
3526 * editfns.c: Move a (normally-unused) function to its only use.
3527 * editfns.c, lisp.h (get_operating_system_release): Remove.
3528 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3529 worth the hassle of breaking this out.
3530
b532497d
PE
3531 * xterm.c: Make symbols static if they're not exported.
3532 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3533 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3534 (x_destroy_window, x_delete_display):
3535 Now static.
3536 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3537 (x_mouse_leave): Remove; unused.
3538 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3539 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3540 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3541 Remove decls.
3542 (x_mouse_leave): Declare only if WINDOWSNT.
3543 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3544 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3545 USE_X_TOOLKIT.
3546
1675728f
PE
3547 * ftxfont.c: Make symbols static if they're not exported.
3548 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3549 HAVE_FREETYPE.
3550 * font.h (ftxfont_driver): Likewise.
3551
e4cebfca
PE
3552 * xfns.c: Make symbols static if they're not exported.
3553 (x_last_font_name, x_display_info_for_name):
3554 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3555 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3556 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3557 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3558 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3559 (last_show_tip_args): Now static.
3560 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3561 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3562 (x_screen_planes): Remove; unused.
3563 * dispextern.h (x_screen_planes): Remove decl.
3564
5bf46f05
PE
3565 * dispnew.c: Make symbols static if they're not exported.
3566 * dispextern.h (redraw_garbaged_frames, scrolling):
3567 (increment_row_positions): Remove.
3568 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3569 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3570 Now static.
3571 (redraw_garbaged_frames): Remove; unused.
3572
435f4c28
PE
3573 * xfaces.c: Make symbols static if they're not exported.
3574 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3575 Remove decls.
3576 * xterm.h (defined_color): Remove decls.
3577 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3578 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3579 (menu_face_changed_default, defined_color, free_realized_face):
3580 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3581 (ascii_face_of_lisp_face): Remove; unused.
3582
8524aef3
PE
3583 * xdisp.c: Make symbols static if they're not exported.
3584 * dispextern.h (scratch_glyph_row, window_box_edges):
3585 (glyph_to_pixel_coords, set_cursor_from_row):
3586 (get_next_display_element, set_iterator_to_next):
3587 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3588 (show_mouse_face): Remove decls
3589 * frame.h (message_buf_print): Likewise.
3590 * lisp.h (pop_message, set_message, check_point_in_composition):
3591 Likewise.
3592 * xterm.h (set_vertical_scroll_bar): Likewise.
3593 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3594 (message_buf_print, scratch_glyph_row, displayed_buffer):
3595 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3596 (get_next_display_element, show_mouse_face, window_box_edges):
3597 (frame_to_window_pixel_xy, check_point_in_composition):
3598 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3599 (glyph_to_pixel_coords): Remove; unused.
3600
16390cd2
PE
3601 * dired.c (file_name_completion): Now static.
3602
3603 * dbusbind.c (xd_in_read_queued_messages): Now static.
3604
a25f4dfa
PE
3605 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3606 * data.c (circular_list_error): Remove.
3607
14a9c8df
PE
3608 * commands.h (last_point_position, last_point_position_buffer):
3609 (last_point_position_window): Remove decls.
3610 * keyboard.c: Make these variables static.
3611
04f2d78b
CB
3612 * coding.h (coding, code_convert_region, encode_coding_gap):
3613 Remove decls.
74ab6df5
PE
3614 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3615 (iso_code_class, detect_coding, code_convert_region): Now static.
3616 (encode_coding_gap): Remove; unused.
3617
38dfbee1
PE
3618 * chartab.c (chartab_chars, chartab_bits): Now static.
3619
a2cb4e63
PE
3620 * charset.h (charset_iso_8859_1): Remove decl.
3621 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3622 Now static.
3623
127198fd
PE
3624 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3625 * ccl.c (Vccl_program_table): Now static.
3626 (check_ccl_update): Remove; unused.
3627
d85b608f
PE
3628 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3629 * category.h: ... from here.
3630 * category.c (check_category_table, set_category_set): Now static.
3631
31cd66f3
PE
3632 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3633 * lisp.h: Remove these decls.
3634
c358e587
PE
3635 * buffer.c (buffer_count): Remove unused var.
3636
e78aecca
PE
3637 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3638 so that it's not optimized away.
3639 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3640 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3641 exported only to the debugger.
3642
e192d7d3 3643 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3644 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3645
92470028
PE
3646 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3647 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3648 was inaccessible from Lisp.
3649 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3650 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3651
244ed907
PE
3652 alloc.c: Import and export fewer symbols, and remove unused items.
3653 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3654 is defined.
3655 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3656 it's not optimized away by whole-program optimization.
3657 (message_enable_multibyte, free_misc): Remove.
3658 (catchlist, handlerlist, mark_backtrace):
3659 Declare only if BYTE_MARK_STACK.
3660 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3661 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3662 (message_enable_multibyte): Remove decl.
3663 (free_misc, interval_free_list, float_block, float_block_index):
3664 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3665 (cons_free_list, last_marked_index):
3666 Now static.
3667 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3668 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3669 (mark_backtrace): Define only if BYTE_MARK_STACK.
3670 * xdisp.c (message_enable_multibyte): Now static.
3671
61c2b50e 3672 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3673 This makes it easier for human readers (and static analyzers)
3674 to see whether these variables are used from other modules.
3675 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3676 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3677 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3678 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3679 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3680 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3681 * xmenu.c, xselect.c:
3682 Declare Q* vars static if they are not used in other modules.
3683 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3684 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3685 Remove decls of unexported vars.
3686 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3687
95c82688
PE
3688 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3689
16a97296
PE
3690 Make Emacs functions such as Fatom 'static' by default.
3691 This makes it easier for human readers (and static analyzers)
3692 to see whether these functions can be called from other modules.
3693 DEFUN now defines a static function. To make the function external
3694 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3695 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3696 (Finit_image_library):
16a97296
PE
3697 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3698 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3699 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3700 Remove decls, since these functions are now static.
3701 (Funintern, Fget_internal_run_time): New decls, since these functions
3702 were already external.
95c82688 3703
16a97296
PE
3704 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3705 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3706 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3707 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3708 * keyboard.c, keymap.c, lread.c:
3709 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3710 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3711 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3712 Mark functions with DEFUE instead of DEFUN,
3713 if they are used in other modules.
3714 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3715 decls for now-static functions.
3716 * buffer.h (Fdelete_overlay): Remove decl.
3717 * callproc.c (Fgetenv_internal): Mark as internal.
3718 * composite.c (Fremove_list_of_text_properties): Remove decl.
3719 (Fcomposition_get_gstring): New forward static decl.
3720 * composite.h (Fcomposite_get_gstring): Remove decl.
3721 * dired.c (Ffile_attributes): New forward static decl.
3722 * doc.c (Fdocumntation_property): New forward static decl.
3723 * eval.c (Ffetch_bytecode): New forward static decl.
3724 (Funintern): Remove extern decl; now in .h file where it belongs.
3725 * fileio.c (Fmake_symbolic_link): New forward static decl.
3726 * image.c (Finit_image_library): New forward static decl.
3727 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3728 * intervals.h (Fprevious_property_change):
3729 (Fremove_list_of_text_properties): Remove decls.
3730 * keyboard.c (Fthis_command_keys): Remove decl.
3731 (Fcommand_execute): New forward static decl.
3732 * keymap.c (Flookup_key): New forward static decl.
3733 (Fcopy_keymap): Now static.
3734 * keymap.h (Flookup_key): Remove decl.
3735 * process.c (Fget_process): New forward static decl.
3736 (Fprocess_datagram_address): Mark as internal.
3737 * syntax.c (Fsyntax_table_p): New forward static decl.
3738 (skip_chars): Remove duplicate decl.
3739 * textprop.c (Fprevious_property_change): New forward static decl.
3740 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3741 Now internal.
3742 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3743 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3744
785bbd42
PE
3745 * editfns.c (Fformat): Remove unreachable code.
3746
8b913b57
AS
37472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3748
3749 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3750 change. (Bug#8496)
3751
a6744a35
EZ
37522011-04-13 Eli Zaretskii <eliz@gnu.org>
3753
3754 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3755 when at ZV. (Bug#8487)
3756
e7974947
AS
37572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3758
baad03f0
AS
3759 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3760 (Bug#8437)
3761 * keyboard.c (parse_tool_bar_item): Likewise.
3762 * sound.c (sound_cleanup, alsa_close): Likewise.
3763 * termcap.c (tgetent): Likewise.
3764 * xfns.c (x_default_font_parameter): Likewise.
3765 * xsettings.c (read_and_apply_settings): Likewise.
3766
e7974947
AS
3767 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3768 (overrun_check_free): Protoize.
3769
28272684
PE
37702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3771
3772 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3773 since callers should never pass a negative size.
3774 Change the signature to match that of plain 'read' and 'write'; see
3775 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3776 * lisp.h: Update prototypes of emacs_write and emacs_read.
3777
11997c76
EZ
37782011-04-11 Eli Zaretskii <eliz@gnu.org>
3779
3780 * xdisp.c (redisplay_window): Don't try to determine the character
3781 position of the scroll margin if the window start point w->startp
e896f03c 3782 is outside the buffer's accessible region. (Bug#8468)
11997c76 3783
8a2cbd72
EZ
37842011-04-10 Eli Zaretskii <eliz@gnu.org>
3785
3786 Fix write-region and its subroutines for buffers > 2GB.
3787 * fileio.c (a_write, e_write): Modify declaration of arguments and
3788 local variables to support buffers larger than 2GB.
3789 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3790
3791 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3792 argument, local variables, and return value.
3793
3794 * lisp.h: Update prototypes of emacs_write and emacs_read.
3795
3796 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3797
4073e537 37982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3799
1ebfdcb6
PE
3800 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3801
b2ded58d
PE
3802 Fix more problems found by GCC 4.6.0's static checks.
3803
7d66342c
PE
3804 * xdisp.c (vmessage): Use a better test for character truncation.
3805
bbf47d44
PE
3806 * charset.c (load_charset_map): <, not <=, for optimization,
3807 and to avoid potential problems with integer overflow.
9248994d 3808 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3809 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3810 * editfns.c (Fformat): Likewise.
1e69125e 3811 * syntax.c (skip_chars): Likewise.
3befa583 3812
e3019616
PE
3813 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3814 This also lets GCC 4.6.0 generate slightly better loop code.
3815
becfa255
PE
3816 * callint.c (Fcall_interactively): <, not <=, for optimization.
3817 (Fcall_interactively): Count the number of arguments produced,
3818 not the number of arguments given. This is simpler and lets GCC
3819 4.6.0 generate slightly better code.
3820
dae0cd48
PE
3821 * ftfont.c: Distingish more carefully between FcChar8 and char.
3822 The previous code passed unsigned char * to a functions like
3823 strlen and xstrcasecmp that expect char *, which does not
3824 conform to the C standard.
3825 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3826 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3827 char * when the C standard requires it.
3828
76032d70
PE
3829 * keyboard.c (read_char): Remove unused var.
3830
eb3f1cc8
PE
3831 * eval.c: Port to Windows vsnprintf (Bug#8435).
3832 Include <limits.h>.
3833 (SIZE_MAX): Define if the headers do not.
3834 (verror): Do not give up if vsnprintf returns a negative count.
3835 Instead, grow the buffer. This ports to Windows vsnprintf, which
3836 does not conform to C99. Problem reported by Eli Zaretskii.
3837 Also, simplify the allocation scheme, by avoiding the need for
3838 calling realloc, and removing the ALLOCATED variable.
3839
70476b54
PE
3840 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3841
12020a9e
PE
3842 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3843 But keep the doprint source code for now, as we might revamp it
3844 and use it again (Bug#8435).
ea6c7ae6
PE
3845 * lisp.h (doprnt): Remove.
3846 * Makefile.in (base_obj): Remove doprnt.o.
3847 * deps.mk (doprnt.o): Remove.
3848
5fdb398c
PE
3849 error: Print 32- and 64-bit integers portably (Bug#8435).
3850 Without this change, on typical 64-bit hosts error ("...%d...", N)
3851 was used to print both 32- and 64-bit integers N, which relied on
3852 undefined behavior.
3853 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3854 New macro.
3855 * lisp.h (error, verror): Mark as printf-like functions.
3856 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3857 Report overflow in size calculations when allocating printf buffer.
3858 Do not truncate output string at its first null byte.
3859 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3860 Truncate the output at a character boundary, since vsnprintf does not
3861 do that.
3862 * charset.c (check_iso_charset_parameter): Convert internal
3863 character to string before calling 'error', since %c now has the
3864 printf meaning.
3865 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3866 overflow when computing char to be passed to 'error'. Do not
3867 pass Lisp_Object to 'error'; pass the integer instead.
3868 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3869 formatted with plain %d.
3870
b189fa66
PE
3871 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3872
bff87ef0
PE
3873 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3874
7e2cac20
PE
3875 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3876
ce4d90b5
PE
3877 * xterm.c (x_catch_errors): Remove duplicate declaration.
3878
266c9547
PE
3879 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3880
79c49ad2
PE
3881 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3882
368f4090
JM
38832011-04-10 Jim Meyering <meyering@redhat.com>
3884
3885 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3886 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3887 return ssize_t not "int", and use size_t as the buffer length.
3888 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3889 * gnutls.h: Update declarations.
3890 * process.c (read_process_output): Use ssize_t, to match.
3891 (send_process): Likewise.
3892
a32d4040
CY
38932011-04-09 Chong Yidong <cyd@stupidchicken.com>
3894
3895 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3896
8546720e 38972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3898
04f2d78b
CB
3899 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3900 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3901
8546720e
GM
3902 * xterm.c (handle_one_xevent):
3903 * xmenu.c (create_and_show_popup_menu):
3904 * xselect.c (x_decline_selection_request)
3905 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3906
0a2f5c1a 39072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3908
3909 Fix some uses of `int' instead of EMACS_INT.
3910 * search.c (string_match_1, fast_string_match)
3911 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3912 (scan_buffer, find_next_newline_no_quit)
3913 (find_before_next_newline, search_command, Freplace_match)
3914 (Fmatch_data): Make some `int' variables be EMACS_INT.
3915
3916 * xdisp.c (display_count_lines): 3rd argument and return value now
3917 EMACS_INT. All callers changed.
3918 (pint2hrstr): Last argument is now EMACS_INT.
3919
3920 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3921 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3922 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3923 (decode_coding_utf_16, decode_coding_emacs_mule)
3924 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3925 (decode_coding_ccl, decode_coding_charset)
3926 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3927 (decode_coding_iso_2022, decode_coding_emacs_mule)
3928 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3929 <char_offset, last_offset>: Declare EMACS_INT.
3930 (encode_coding_utf_8, encode_coding_utf_16)
3931 (encode_coding_emacs_mule, encode_invocation_designation)
3932 (encode_designation_at_bol, encode_coding_iso_2022)
3933 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3934 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3935 Declare EMACS_INT.
3936 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3937 (encode_invocation_designation): Last argument P_NCHARS is now
3938 EMACS_INT.
3939 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3940 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3941
3942 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3943 All users changed.
3944
3945 * ccl.c (Fccl_execute_on_string): Declare some variables
3946 EMACS_INT.
3947
8546720e 39482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3949
3950 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3951
4e19a977
CS
39522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3953
3954 * process.c (Fformat_network_address): Doc fix.
3955
87302331
R
39562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3957
3958 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3959
cbb59342
CY
39602011-04-08 Chong Yidong <cyd@stupidchicken.com>
3961
3962 * keyboard.c (read_char): Call Lisp function help-form-show,
3963 instead of using internal_with_output_to_temp_buffer.
3964 (Qhelp_form_show): New var.
e0d38eeb 3965 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3966
3967 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3968
3969 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3970
e67a13ab
CY
39712011-04-06 Chong Yidong <cyd@stupidchicken.com>
3972
04f2d78b
CB
3973 * process.c (Flist_processes): Remove to Lisp.
3974 (list_processes_1): Delete.
e67a13ab 3975
973f782d
EZ
39762011-04-06 Eli Zaretskii <eliz@gnu.org>
3977
7c106b1e
EZ
3978 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3979
973f782d
EZ
3980 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3981
41cf7d1a 39822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3983
ca23cc88
PE
3984 Fix more problems found by GCC 4.6.0's static checks.
3985
f390e2d5
PE
3986 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3987
42eea0d0
PE
3988 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3989
b69769da 3990 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3991
f9541e84
PE
3992 * xdisp.c (vmessage): Mark as a printf-like function.
3993
13841b55
PE
3994 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3995
c136c10f
PE
3996 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3997
5e2d4a30
PE
3998 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3999 printf-like functions.
4000 (tiff_load): Add casts to remove these marks before passing them
4001 to system-supplied API.
4002
583f48b9
PE
4003 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4004
b25d760e
PE
4005 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4006 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4007 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4008 directly, rather than having caller test rule sign. This avoids
4009 some unnecessary tests.
4010 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4011 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4012 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4013
bc7b6697 4014 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4015 (xfont_open): Avoid unnecessary tests.
bc7b6697 4016
27ccc379
PE
4017 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4018
dcd5c89a
PE
4019 * composite.h, composite.c (composition_gstring_put_cache):
4020 Use EMACS_INT, not int, for length.
4021
b13a45c6
PE
4022 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4023 breaking out part of COMPOSITION_DECODE_RULE.
4024 (COMPOSITION_DECODE_RULE): Use it.
4025 * composite.c (get_composition_id): Remove unused local vars,
4026 by using the new macro.
4027
1e792e4d
PE
4028 * textprop.c (set_text_properties_1): Change while to do-while,
4029 since the condition is always true at first.
4030
dc6c6455 4031 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4032 (interval_deletion_adjustment): Return unsigned value.
4033 All uses changed.
dc6c6455 4034
aba7731a
PE
4035 * process.c (list_processes_1, create_pty, read_process_output):
4036 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4037 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4038 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4039 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4040 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4041
fdfc4bf3
PE
4042 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4043
fca8fe46 4044 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4045 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4046
06a0259a 4047 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4048 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4049 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4050
e7b9e80f
PE
4051 * print.c (print_error_message): Avoid int overflow.
4052
56201685
PE
4053 * font.c (font_list_entities): Redo for clarity,
4054 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4055
78834453 4056 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4057 (font_score): Avoid potential overflow in diff calculation.
78834453 4058
0bc0b309 4059 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4060 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4061
e610eaca
PE
4062 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4063
b895abce
PE
4064 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4065 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4066 can always succeed if overflow has undefined behavior.
4067
1f1d9321 4068 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4069 (wordify): Omit three unnecessary tests.
1f1d9321 4070
c59478bc
PE
4071 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4072 All callers changed. This avoids the need for an unused var.
4073
79b73827
PE
4074 * casefiddle.c (casify_region): Remove var that is set but not used.
4075
a4db5dfe
PE
4076 * dired.c (file_name_completion): Remove var that is set but not used.
4077
43aae36e
PE
4078 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4079
2a47c44d 4080 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4081 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4082
a37c69bf
PE
4083 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4084 Check for integer overflow on size calculations.
4085
328ab8e7
PE
4086 * buffer.c (Fprevious_overlay_change): Remove var that is set
4087 but not used.
4088
e5a2a5cb
PE
4089 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4090 Remove vars that are set but not used.
8d84a6eb 4091 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4092 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4093
a60e5f68
PE
4094 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4095
f661cb61 4096 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4097 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4098
f0397f5a
PE
4099 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4100 that are set but not used.
4101
8664db06 4102 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4103 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4104
6abdaa4a
PE
4105 * xselect.c (x_get_local_selection, x_handle_property_notify):
4106 Remove vars that are set but not used.
4107
0ce7538d 4108 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4109 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4110
9ae848fc
PE
4111 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4112 Remove var that is set but not used.
0b918413
PE
4113 (scroll_bar_windows_size): Now size_t, not int.
4114 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4115 Check for overflow.
9ae848fc 4116
a5a62657
PE
4117 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4118 (map_tty_color) [!defined MSDOS]: Likewise.
4119
5c5cdd39
PE
4120 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4121
66ebf983
PE
4122 * coding.c: Remove vars that are set but not used.
4123 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4124 All callers changed.
4125 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4126 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4127 (decode_coding_charset): Remove vars that are set but not used.
4128
1be4d761
PE
4129 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4130 that is set but not used.
4131
47553fa8
PE
4132 * print.c (print_object): Remove var that is set but not used.
4133
1f7196bf 4134 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4135 The gnulib version avoids calling malloc in the usual case,
4136 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4137 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4138 * filelock.c (current_lock_owner): Likewise.
4139 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4140 * sysdep.c: Include allocator.h, careadlinkat.h.
4141 (emacs_no_realloc_allocator): New static constant.
4142 (emacs_readlink): New function.
fdb61804
PE
4143 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4144 ../lib/careadlinkat.h.
d1fdcab7 4145
f84c17c7
SM
41462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4147
4148 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4149 first non-nil return value).
4150
ef3862ad
JD
41512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4152
4153 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4154 if not defined (Bug#8403).
4155
376a7006
JB
41562011-04-02 Juanma Barranquero <lekktu@gmail.com>
4157
4158 * xdisp.c (display_count_lines): Remove parameter `start',
4159 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4160 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4161 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4162 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4163 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4164 and thereabouts. All callers changed.
4165 (get_per_char_metric): Remove parameter `f', unused since
4166 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4167
6ca3801d
JM
41682011-04-02 Jim Meyering <meyering@redhat.com>
4169
4170 do not dereference NULL upon failed strdup
4171 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4172 (ns_get_family): Likewise.
4173
d8e2b5ba
JB
41742011-04-02 Juanma Barranquero <lekktu@gmail.com>
4175
4176 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4177
8c74fcbd
JD
41782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4179
4180 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4181 later (Bug#8403).
4182
7200d79c
SM
41832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4184
03408648 4185 Add lexical binding.
7200d79c 4186
03408648
SM
4187 * window.c (Ftemp_output_buffer_show): New fun.
4188 (Fsave_window_excursion):
4189 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4190
4191 * lread.c (lisp_file_lexically_bound_p): New function.
4192 (Fload): Bind Qlexical_binding.
4193 (readevalloop): Remove `evalfun' arg.
4194 Bind Qinternal_interpreter_environment.
4195 (Feval_buffer): Bind Qlexical_binding.
4196 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4197 Mark as dynamic.
4198 (syms_of_lread): Declare `lexical-binding'.
4199
4200 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4201
4202 * keyboard.c (eval_dyn): New fun.
4203 (menu_item_eval_property): Use it.
ca105506
SM
4204
4205 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4206
03408648
SM
4207 * fns.c (concat, mapcar1): Accept byte-code-functions.
4208
4209 * eval.c (Fsetq): Handle lexical vars.
4210 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4211 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4212 (FletX, Flet): Obey lexical binding.
4213 (Fcommandp): Handle closures.
4214 (Feval): New `lexical' arg.
4215 (eval_sub): New function extracted from Feval. Use it almost
4216 everywhere where Feval was used. Look up vars in lexical env.
4217 Handle closures.
4218 (Ffunctionp): Move from subr.el.
4219 (Ffuncall): Handle closures.
4220 (apply_lambda): Remove `eval_flags'.
4221 (funcall_lambda): Handle closures and new byte-code-functions.
4222 (Fspecial_variable_p): New function.
4223 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4224 but without exporting it to Lisp.
23aba0ea 4225
23aba0ea 4226 * doc.c (Fdocumentation, store_function_docstring):
03408648 4227 * data.c (Finteractive_form): Handle closures.
23aba0ea 4228
03408648
SM
4229 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4230 interactive spec.
ba83908c 4231
04f2d78b
CB
4232 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4233 New byte-codes.
03408648
SM
4234 (exec_byte_code): New function extracted from Fbyte_code to handle new
4235 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4236
03408648 4237 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4238
03408648 4239 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4240
e2abce01
JB
42412011-03-31 Juanma Barranquero <lekktu@gmail.com>
4242
4243 * xdisp.c (redisplay_internal): Fix prototype.
4244
63696a73 42452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4246
63696a73 4247 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4248 (try_scrolling): Use it when setting scroll_limit.
4249 Limit scrolling to 100 screen lines.
63696a73
EZ
4250 (redisplay_window): Even when falling back on "recentering",
4251 position point in the window according to scroll-conservatively,
4252 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4253
4254 (try_scrolling): When point is above the window, allow searching
4255 as far as scroll_max, or one screenful, to compute vertical
4256 distance from PT to the scroll margin position. This prevents
4257 try_scrolling from unnecessarily failing when
4258 scroll-conservatively is set to a value slightly larger than the
4259 window height. Clean up the case of PT below the margin at bottom
4260 of window: scroll_max can no longer be INT_MAX. When aggressive
4261 scrolling is in use, don't let point enter the opposite scroll
4262 margin as result of the scroll.
4263 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4264 threshold of 100 lines for never-recentering scrolling.
4265
e4cc2dfc
JB
42662011-03-31 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * dispextern.h (move_it_by_lines):
4269 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4270 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4271 (message_log_check_duplicate): Remove parameters `prev_bol' and
4272 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4273 (redisplay_internal): Remove parameter `preserve_echo_area',
4274 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4275
4276 * indent.c (Fvertical_motion):
4277 * window.c (window_scroll_pixel_based, Frecenter):
4278 Don't pass `need_y_p' to `move_it_by_lines'.
4279
1c470562
SM
42802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4281
44f230aa
SM
4282 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4283 steal a few bits to be more compact.
4284 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4285 Remove unneeded casts.
4286
1c470562
SM
4287 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4288
888adce9
ZK
42892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4290
4291 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4292 binding" message (bug#7967).
4293
f838ed7b
PE
42942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4295
77861b95
PE
4296 Fix more problems found by GCC 4.6.0's static checks.
4297
de6dbc14
PE
4298 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4299 Remove unused local var.
4300
f838ed7b
PE
4301 * editfns.c (Fmessage_box): Remove unused local var.
4302
792c7b2b
PE
4303 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4304 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4305 Omit unused local vars.
c499e557 4306 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4307 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4308 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4309 Omit unused local var.
4310
ba0165e1
PE
4311 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4312 Don't assume string length fits in int.
32ad8845 4313 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4314 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4315
3c59b4c9
PE
4316 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4317 instead of alloca (Bug#8344).
4318
a3eed478 4319 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4320 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4321
eb4d412d
PE
4322 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4323
1658b401
PE
4324 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4325 concerns.
4326
4327 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4328
4329 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4330
9a2c6e05
PE
4331 * keyboard.c (syms_of_keyboard): Use the same style as later
4332 in this function when indexing through an array. This also
4333 works around GCC bug 48267.
4334
03d0a109
PE
4335 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4336
44f730c8
PE
4337 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4338
fe75f926
PE
4339 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4340 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4341
ffa8c828
PE
4342 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4343 This avoids undefined behavior on integer overflow, and is a bit
4344 more convenient anyway since it is compared to a size_t variable.
4345
c5101a77
PE
4346 Variadic C functions now count arguments with size_t, not int.
4347 This avoids an unnecessary limitation on 64-bit machines, which
4348 caused (substring ...) to crash on large vectors (Bug#8344).
4349 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4350 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4351 All variadic functions and their callers changed accordingly.
c5101a77
PE
4352 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4353 * data.c (arith_driver, float_arith_driver): Likewise.
4354 * editfns.c (general_insert_function): Likewise.
4355 * eval.c (struct backtrace.nargs, interactive_p)
4356 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4357 (funcall_lambda, mark_backtrace): Likewise.
4358 * fns.c (concat): Likewise.
4359 * frame.c (x_set_frame_parameters): Likewise.
4360 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4361 0 if not found, not -1. All callers changed.
4362
dd3f25f7
PE
4363 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4364 (stack_copy_size): Now size_t, not int.
4365 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4366
461c2ab9
JB
43672011-03-28 Juanma Barranquero <lekktu@gmail.com>
4368
4369 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4370 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4371 All callers changed.
4372
4373 * lisp.h (multibyte_char_to_unibyte):
4374 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4375 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4376 * character.h (CHAR_TO_BYTE8):
4377 * cmds.c (internal_self_insert):
4378 * editfns.c (general_insert_function):
4379 * keymap.c (push_key_description):
4380 * search.c (Freplace_match):
4381 * xdisp.c (message_dolog, set_message_1): All callers changed.
4382
f6d62986
SM
43832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4384
4385 * keyboard.c (safe_run_hook_funcall): New function.
4386 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4387 don't set the hook to nil, but remove the offending function instead.
4388 (Qcommand_hook_internal): Remove, unused.
4389 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4390 Vcommand_hook_internal.
4391
4392 * eval.c (enum run_hooks_condition): Remove.
4393 (funcall_nil, funcall_not): New functions.
4394 (run_hook_with_args): Call each function through a `funcall' argument.
4395 Remove `cond' argument, now redundant.
4396 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4397 (Frun_hook_with_args_until_failure): Adjust accordingly.
4398 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4399
1db5b1ad
JB
44002011-03-28 Juanma Barranquero <lekktu@gmail.com>
4401
4402 * dispextern.h (string_buffer_position): Remove declaration.
4403
4404 * print.c (strout): Remove parameter `multibyte', unused since
4405 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4406
4407 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4408 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4409 All callers changed.
4410
4411 * w32.c (_wsa_errlist): Use braces for struct initializers.
4412
4413 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4414 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4415 All callers changed.
4416 (string_buffer_position): Likewise. Also, make static (it's never
4417 used outside xdisp.c).
4418 (cursor_row_p): Remove parameter `w', unused since
4419 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4420 (decode_mode_spec): Remove parameter `precision', introduced during
4421 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4422 All callers changed.
4423
5ffb62aa
JD
44242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4425
4426 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4427
461c2ab9 44282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4429
4430 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4431 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4432 (ns_update_auto_hide_menu_bar): New functions.
4433 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4434 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4435 ns_constrain_all_frames.
4436 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4437 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4438
5c380ffb
JD
44392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4440
4441 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4442
9af30bdf
GM
44432011-03-27 Glenn Morris <rgm@gnu.org>
4444
4445 * syssignal.h: Replace RETSIGTYPE with void.
4446 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4447 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4448 Replace SIGTYPE with void everywhere.
4449 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4450 * s/template.h (SIGTYPE): Remove commented out definition.
4451
e2abce01
JB
44522011-03-26 Eli Zaretskii <eliz@gnu.org>
4453
4454 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4455 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4456
f868cd8a
JB
44572011-03-26 Juanma Barranquero <lekktu@gmail.com>
4458
59eb0929
JB
4459 * w32.c (read_unc_volume): Use parameter `henum', instead of
4460 global variable `wget_enum_handle'.
4461
4462 * keymap.c (describe_vector): Remove parameters `indices' and
4463 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4464 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4465
f868cd8a
JB
4466 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4467
4468 * keyboard.c (timer_check): Remove parameter `do_it_now',
4469 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4470 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4471 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4472
4473 * keyboard.c (read_char):
4474 * w32menu.c (w32_menu_display_help):
4475 * xmenu.c (show_help_event, menu_help_callback):
4476 Adjust calls to `show_help_echo'.
4477
4478 * gtkutil.c (xg_maybe_add_timer):
4479 * keyboard.c (readable_events):
4480 * process.c (wait_reading_process_output):
4481 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4482
4483 * insdel.c (adjust_markers_gap_motion):
4484 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4485 (gap_left, gap_right): Don't call it.
4486
2ecf6fdb
CY
44872011-03-25 Chong Yidong <cyd@stupidchicken.com>
4488
4489 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4490 incurred during fontification.
4491
6b1f9ba4
JB
44922011-03-25 Juanma Barranquero <lekktu@gmail.com>
4493
4494 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4495 (DEFVAR_PER_BUFFER): Don't pass it.
4496
4497 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4498 (scrolling_window): Don't pass it.
4499
0f4a96b5
JB
45002011-03-25 Juanma Barranquero <lekktu@gmail.com>
4501
4502 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4503
4504 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4505 and `suffix'.
4506 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4507 of variables specific to SELinux and computation of `encoded_absname'.
4508
4509 * image.c (XPutPixel): Remove unused variable `height'.
4510
4511 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4512
4513 * unexw32.c (get_section_info): Remove unused variable `section'.
4514
4515 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4516 (system_process_attributes): Remove unused variable `sess'.
4517 (sys_read): Remove unused variable `err'.
4518
4519 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4520 (w32_wnd_proc): Remove unused variable `isdead'.
4521 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4522 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4523 (x_create_tip_frame): Remove unused variable `tem'.
4524
4525 * w32inevt.c (w32_console_read_socket):
4526 Remove unused variable `no_events'.
4527
4528 * w32term.c (x_draw_composite_glyph_string_foreground):
4529 Remove unused variable `width'.
4530
1149507c
JB
45312011-03-24 Juanma Barranquero <lekktu@gmail.com>
4532
4533 * w32term.c (x_set_glyph_string_clipping):
4534 Don't pass uninitialized region to CombineRgn.
4535
9c88f339
JB
45362011-03-23 Juanma Barranquero <lekktu@gmail.com>
4537
4538 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4539 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4540 (Fx_close_connection): Remove unused variable `i'.
4541
4542 * w32font.c (w32font_draw): Return number of glyphs.
4543 (w32font_open_internal): Remove unused variable `i'.
4544 (w32font_driver): Add missing initializer.
4545
4546 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4547 (fill_in_menu): Remove unused variable `items_added'.
4548
4549 * w32term.c (last_mouse_press_frame): Remove static global variable.
4550 (w32_clip_to_row): Remove unused variable `f'.
4551 (x_delete_terminal): Remove unused variable `i'.
4552
4553 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4554 (NOTHING): Remove unused static global variable.
4555 (uniscribe_check_otf): Remove unused variable `table'.
4556 (uniscribe_font_driver): Add missing initializers.
4557
dee091a3
JD
45582011-03-23 Julien Danjou <julien@danjou.info>
4559
4560 * term.c (Fsuspend_tty, Fresume_tty):
4561 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4562 * window.c (temp_output_buffer_show):
4563 * insdel.c (signal_before_change):
4564 * frame.c (Fhandle_switch_frame):
4565 * fileio.c (Fdo_auto_save):
4566 * emacs.c (Fkill_emacs):
4567 * editfns.c (save_excursion_restore):
4568 * cmds.c (internal_self_insert):
4569 * callint.c (Fcall_interactively):
4570 * buffer.c (Fkill_all_local_variables):
4571 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4572 Use Frun_hooks.
0f4a96b5 4573 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4574 unconditionnaly since it does the check itself.
4575
2c520ab5 45762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4577
c9c49752
PE
4578 Fix more problems found by GCC 4.5.2's static checks.
4579
8abc3f12
PE
4580 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4581 the first time through the loop, since we know p0 < p1 then.
4582 This also avoids a gcc -Wstrict-overflow warning.
4583
a2d26660
PE
4584 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4585 leading to a memory leak, possible in functions like
4586 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4587 of objects (Bug#8318).
a2d26660 4588
916c72e9
PE
4589 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4590 that could (at least in theory) be that large.
4591
19ab8a18
PE
4592 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4593 This is less likely to overflow, and avoids undefined behavior if
4594 overflow does occur. All callers changed. Use strtoul to scan
4595 for the unsigned long integer.
b7cbbd6f
PE
4596 (pint2hrstr): Simplify and tune code slightly.
4597 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4598
f0641eff
PE
4599 * scroll.c (do_scrolling): Work around GCC bug 48228.
4600 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4601
7f650bb9
PE
4602 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4603 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4604 (validate_x_resource_name): Simplify count usage.
4605 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4606
37dd57d1
PE
4607 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4608 fail (Bug#8306).
81e56e61 4609
699979fc 4610 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4611
401bf9b4
PE
4612 * process.c (Fmake_network_process): Use socklen_t, not int,
4613 where POSIX says socklen_t is required in portable programs.
4614 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4615 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4616 (Fmake_network_process, server_accept_connection):
4617 (wait_reading_process_output, read_process_output):
4618 Likewise.
4619
b93aacde
PE
4620 * process.c: Rename or move locals to avoid shadowing.
4621 (list_processes_1, Fmake_network_process):
4622 (read_process_output_error_handler, exec_sentinel_error_handler):
4623 Rename or move locals.
4dc343ee 4624 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4625 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4626 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4627 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4628 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4629
af8a867c 4630 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4631 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4632 Include tparam.h instead, since it declares them.
af8a867c
PE
4633 * cm.h (PC): Remove extern decl; tparam.h now does this.
4634 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4635 * terminfo.c: Include tparam.h, to check interfaces.
4636 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4637 (tparam): Adjust signature to match interface in tparam.h;
4638 this removes some undefined behavior. Check that outstring and len
4639 are zero, which they always are with Emacs.
4640 * tparam.h (PC, BC, UP): New extern decls.
4641
0248044d 4642 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4643 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4644
8ff096c1 4645 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4646 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4647 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4648 (ftfont_list): Remove unused local.
49eaafba
PE
4649 (get_adstyle_property, ftfont_pattern_entity):
4650 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4651 Rename locals to avoid shadowing.
8ff096c1 4652
e2be39f6
PE
4653 * xfont.c (xfont_list_family): Mark var as initialized.
4654
c9735e30
PE
4655 * xml.c (make_dom): Now static.
4656
8f5201ae
PE
4657 * composite.c (composition_compute_stop_pos): Rename local to
4658 avoid shadowing.
b246f932
PE
4659 (composition_reseat_it): Remove unused locals.
4660 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4661 (composition_update_it): Mark var as initialized.
11b61122
PE
4662 (find_automatic_composition): Mark vars as initialized,
4663 with a FIXME (Bug#8290).
8f5201ae 4664
760fbc2c
PE
4665 character.h: Rename locals to avoid shadowing.
4666 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4667 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4668 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4669 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4670 to avoid shadowing.
4671
ff08eb85
PE
4672 * textprop.c (property_change_between_p): Remove; unused.
4673
fc7bf025
PE
4674 * intervals.c (interval_start_pos): Now static.
4675
235d7abc
PE
4676 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4677
44f230aa
SM
4678 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4679 Rename locals to avoid shadowing.
3e7d6594 4680
50060332
PE
4681 * sound.c (wav_play, au_play, Fplay_sound_internal):
4682 Fix pointer signedness.
d01f234b 4683 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4684 (wav_play): Initialize a variable to 0, to prevent undefined
4685 behavior (Bug#8278).
50060332 4686
c4fc4e30
PE
4687 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4688
918436ed
PE
4689 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4690
c939f91b
PE
4691 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4692 clobbering (Bug#8298).
b9c7f648
PE
4693 * sysdep.c (sys_subshell): Likewise.
4694 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4695
6bd8c144
PE
4696 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4697 This should get cleaned up, so that child_setup has the
4698 same signature on all platforms.
4699
7710357c 4700 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4701 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4702
c59da222
CY
47032011-03-22 Chong Yidong <cyd@stupidchicken.com>
4704
4705 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4706 not to be necessary, and produces flickering.
4707
66b87493
GM
47082011-03-20 Glenn Morris <rgm@gnu.org>
4709
4710 * config.in: Remove file.
4711
45b6f6d5
JB
47122011-03-20 Juanma Barranquero <lekktu@gmail.com>
4713
4714 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4715 are now in src/globals.h.
4716 (syms_of_minibuf): Remove spurious & from previous change.
4717
3ec03f7e
LL
47182011-03-20 Leo <sdl.web@gmail.com>
4719
4720 * minibuf.c (completing-read-function): New variable.
4721 (completing-read-default): Rename from completing-read.
4722 (completing-read): Call completing-read-function.
4723
b14e3e21
CY
47242011-03-19 Juanma Barranquero <lekktu@gmail.com>
4725
4726 * xfaces.c (Fx_load_color_file):
4727 Read color file from absolute filename (bug#8250).
4728
f2b726e6
JB
47292011-03-19 Juanma Barranquero <lekktu@gmail.com>
4730
4731 * makefile.w32-in: Update dependencies.
4732
09f6ff02
EZ
47332011-03-17 Eli Zaretskii <eliz@gnu.org>
4734
4735 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4736
29a6015a
PE
47372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4738
a3a6c54e
PE
4739 Fix more problems found by GCC 4.5.2's static checks.
4740
b766f867
PE
4741 * process.c (make_serial_process_unwind, send_process_trap):
4742 (sigchld_handler): Now static.
4743
be02381c
PE
4744 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4745 That way, the code declares only the vars that it needs.
4746 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4747 * s/cygwin.h (PTY_ITERATION): Likewise.
4748 * s/darwin.h (PTY_ITERATION): Likewise.
4749 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4750
57048744
PE
4751 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4752 * process.c (allocate_pty): Don't declare stb unless it's needed.
4753
7914961c 4754 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4755 (CONSTANTLIM): Remove; unused.
4756 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4757 Define only if needed.
7914961c 4758
b3967b18
PE
4759 * unexelf.c (unexec): Name an expression,
4760 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4761 Use a different way to cause a compilation error if anyone uses
4762 n rather than nn, a way that does not involve shadowing.
73366a00 4763 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4764
29a6015a
PE
4765 * deps.mk (unexalpha.o): Remove; unused.
4766
43cfc33e 4767 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4768 * unexec.h: New file.
ce701a33
PE
4769 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4770 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4771 Depend on unexec.h.
4772 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4773 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4774 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4775 Change as necessary to match prototype in unexec.h.
ce701a33 4776
01f44d5a
PE
4777 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4778 shadowing.
4f63c6bb 4779 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4780
a6670b0b
PE
4781 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4782 Rename locals to avoid shadowing.
4783
cef2010d 4784 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4785 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4786
d4d7173a
PE
4787 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4788
f08b802a
PE
4789 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4790 warning when compiling print.c.
4791
3ddb0639
PE
4792 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4793 instead of using an uninitialized var.
5ad03b97 4794 (font_sort_entities): Mark var as initialized.
3ddb0639 4795
170a2692
PE
4796 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4797
e663c700
PE
4798 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4799 pointers to constants.
89bc529a 4800 (font_parse_fcname): Remove unused vars.
7b81e2d0 4801 (font_delete_unmatched): Now static.
ea838e10 4802 (font_get_spec): Remove; unused.
13a547c6
PE
4803 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4804 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4805 Rename or move locals to avoid shadowing.
e663c700 4806
2a80c887 4807 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4808 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4809
1384fa33 4810 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4811 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4812
8b2c52e9
PE
4813 * alloc.c (mark_backtrace): Move decl from here ...
4814 * lisp.h: ... to here, so that it can be checked.
4815
475545b5 4816 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4817 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4818 (lisp_indirect_variable): Name an expression,
4819 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4820 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4821
b1349114 4822 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4823 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4824 Use const pointer when appropriate.
b1349114 4825
a2928364
PE
4826 * lisp.h (get_system_name, get_operating_system_release):
4827 Move decls here, to check interfaces.
4828 * process.c (get_operating_system_release): Move decl to lisp.h.
4829 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4830 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4831 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4832 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4833 (Fformat_time_string, Fencode_time, Finsert_char):
4834 (Ftranslate_region_internal, Fformat):
4835 Rename or remove local vars to avoid shadowing.
9710023e 4836 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4837
a415e694
PE
4838 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4839 avoid shadowing.
4840
8ef4622d
PE
4841 * lisp.h (eassert): Check that the argument compiles, even if
4842 ENABLE_CHECKING is not defined.
4843
946f9a5b
PE
4844 * data.c (Findirect_variable): Name an expression, to avoid
4845 gcc -Wbad-function-cast warning.
112396d6 4846 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4847 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4848 (Fmake_variable_buffer_local, Fmake_local_variable):
4849 Mark variables as initialized.
52746918 4850 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4851
e5aab7e7 4852 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4853 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4854 Rename locals to avoid shadowing.
dff45157
PE
4855 (mark_stack): Move local variables into the #ifdef region where
4856 they're used.
7bc26fdb
PE
4857 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4858 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4859 needed otherwise.
4860 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4861 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4862 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4863
e5aab7e7
PE
4864 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4865 avoids undefined behavior in theory.
4866
4da60324
PE
4867 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4868
88043301
PE
4869 Use functions, not macros, for up- and down-casing (Bug#8254).
4870 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4871 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4872 to use the following functions instead of these macros.
4873 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4874 EMACS_INT, since callers assume the returned value fits in int.
4875 (upcase1): Likewise, for UPCASE_TABLE.
4876 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4877 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4878 the race-condition problem in the old DOWNCASE.
88043301 4879
19ed5445
PE
4880 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4881 Rename locals to avoid shadowing.
4882 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4883 (regex_compile, re_search_2, re_match_2_internal):
4884 Remove unused local vars.
952db0d7
PE
4885 (FREE_VAR): Rewrite so as not to use empty "else",
4886 which gcc can warn about.
da053e48 4887 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4888 (RETALLOC_IF): Define only if needed.
4889 (WORDCHAR_P): Likewise. This one is never needed, but is used
4890 only in a comment talking about a compiler bug, so put inside
4891 the #if 0 of that comment.
4892 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4893 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4894 Remove; unused.
19ed5445 4895
1f3561e4 4896 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4897 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4898 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4899
ded6f8f7
PE
4900 * search.c (simple_search): Remove unused var.
4901
dbd37a95
PE
4902 * dired.c (compile_pattern): Move decl from here ...
4903 * lisp.h: ... to here, so that it can be checked.
4904 (struct re_registers): New forward decl.
4905
7e47afad
PE
4906 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4907
85f24f61
PE
4908 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4909 All uses changed.
4910 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4911 Rename locals to avoid shadowing.
5671df8f 4912 (Fvertical_motion): Mark locals as initialized.
85f24f61 4913
181aa2be 4914 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4915 (casify_region): Mark local as initialized.
181aa2be 4916
930d429c
PE
4917 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4918
7082eac6
PE
4919 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4920 New macros, so that the caller can use some names other than
4921 gcpro1, gcpro2, etc.
4922 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4923 of the new macros.
4924 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4925 argument, for consistency with GCPRO2_VAR, etc: it is now the
4926 prefix of the variable, not the variable itself. All uses
4927 changed.
38b2c076
PE
4928 * dired.c (directory_files_internal, file_name_completion):
4929 Rename locals to avoid shadowing.
4930
15206ed9
PE
4931 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4932 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4933 dired.c's scmp function, had undefined behavior.
4934 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4935 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4936 * buffer.h: ... to here, because these macros use current_buffer,
4937 and the new implementation with inline functions needs to have
4938 current_buffer in scope now, rather than later when the macros
4939 are used.
4940 (downcase, upcase1): New static inline functions.
4941 (DOWNCASE, UPCASE1): Reimplement using these functions.
4942 This avoids undefined behavior in expressions like
4943 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4944 from race conditions in accessing the global variables
4945 case_temp1 and case_temp2.
4946 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4947 * lisp.h (case_temp1, case_temp2): Remove their decls.
4948 * character.h (ASCII_CHAR_P): Move from here ...
4949 * lisp.h: ... to here, so that the inline functions mentioned
4950 above can use them.
4951
4a6bea26
PE
4952 * dired.c (directory_files_internal_unwind): Now static.
4953
f14b7e14
PE
4954 * fileio.c (file_name_as_directory, directory_file_name):
4955 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4956 Now static.
2893f146
PE
4957 (file_name_as_directory): Use const pointers when appropriate.
4958 (Fexpand_file_name): Likewise. In particular, newdir might
4959 point at constant storage, so make it a const pointer.
fd4ead52 4960 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4961 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4962 signedness issues.
f839df0c
PE
4963 (Fset_file_times, Finsert_file_contents, auto_save_error):
4964 Rename locals to avoid shadowing.
f14b7e14 4965
5716756e 4966 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4967 (Ftry_completion, Fall_completions): Rename or remove locals
4968 to avoid shadowing.
5716756e 4969
b4c3046a
PE
4970 * marker.c (bytepos_to_charpos): Remove; unused.
4971
b45db522
PE
4972 * lisp.h (verify_bytepos, count_markers): New decls,
4973 so that gcc does not warn that these functions aren't declared.
4974
85876d07
PE
4975 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4976 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4977 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4978 (copy_text): Remove unused local var.
85876d07 4979
03d78a21 4980 * filelock.c (within_one_second): Now static.
b3dd38ab 4981 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4982
5df8f01b
PE
4983 * buffer.c (fix_overlays_before): Mark locals as initialized.
4984 (fix_start_end_in_overlays): Likewise. This function should be
4985 simplified by using pointers-to-pointers, but that's a different
4986 matter.
b1d876f1 4987 (switch_to_buffer_1): Now static.
8f54f30a
PE
4988 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4989 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4990
a70072c9 4991 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4992 Fix pointer signedness issue.
edced198
PE
4993 (sys_subshell): Mark local as volatile if checking for lint,
4994 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4995 (MAXPATHLEN): Define only if needed.
a70072c9 4996
a0977c44
PE
4997 * process.c (serial_open, serial_configure): Move decls from here ...
4998 * systty.h: ... to here, so that they can be checked.
4999
a884fdcc
PE
5000 * fns.c (get_random, seed_random): Move extern decls from here ...
5001 * lisp.h: ... to here, so that they can be checked.
5002
604efe86 5003 * sysdep.c (reset_io): Now static.
b8950c94 5004 (wait_for_termination_signal): Remove; unused.
604efe86 5005
38fc62d9
PE
5006 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5007 (copy_keymap_item, append_key, push_text_char_description):
5008 Now static.
1004a21a 5009 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5010 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5011 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5012 (describe_map_tree):
5013 Rename locals to avoid shadowing.
38fc62d9 5014
2f2650da
PE
5015 * keyboard.c: Declare functions static if they are not used elsewhere.
5016 (echo_char, echo_dash, cmd_error, top_level_2):
5017 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5018 (read_char, kbd_buffer_get_event, make_lispy_position):
5019 (make_lispy_event, make_lispy_movement, apply_modifiers):
5020 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5021 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5022 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5023 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5024 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5025
a053e86c 5026 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5027 (mark_kboards): Move decl here ...
5028 * alloc.c (mark_kboards): ... from here.
a053e86c 5029
4752793e
PE
5030 * lisp.h (force_auto_save_soon): New decl.
5031
74f10ca7 5032 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5033 (DEFINE_DUMMY_FUNCTION): New macro.
5034 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5035 Use it.
c03cd23f
PE
5036 (main): Add casts to avoid warnings
5037 if GCC considers string literals to be constants.
74f10ca7 5038
022e70d4
PE
5039 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5040
59d6fe83
PE
5041 * dbusbind.c: Pointer signedness fixes.
5042 (xd_signature, xd_append_arg, xd_initialize):
5043 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5044 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5045 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5046 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5047
78320123
PE
5048 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5049 if GCC considers string literals to be constants.
49cebcca 5050 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5051
35ac2a97
SM
50522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5053
fb103ca9
SM
5054 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5055 (print_preprocess, print_object): New macro to fix last change.
5056
35ac2a97
SM
5057 * print.c (print_preprocess): Don't forget font objects.
5058
62973b41
JB
50592011-03-16 Juanma Barranquero <lekktu@gmail.com>
5060
5061 * emacs.c (USAGE3): Doc fixes.
5062
0e48bb22
AS
50632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5064
5065 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5066 structure.
5067
7684e57b
JB
50682011-03-14 Juanma Barranquero <lekktu@gmail.com>
5069
5070 * lisp.h (VWindow_system, Qfile_name_history):
5071 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5072 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5073 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5074
5075 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5076 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5077
5078 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5079 * w32console.c (detect_input_pending, read_input_pending)
5080 (encode_terminal_code):
5081 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5082 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5083 (w32_system_caret_y, Qfile_name_history):
5084 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5085 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5086 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5087 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5088 * w32proc.c (Qlocal, report_file_error):
5089 * w32term.c (Vwindow_system, updating_frame):
5090 * w32uniscribe.c (initialized, uniscribe_font_driver):
5091 Remove unneeded extern declarations.
5092
2aa46d6c
CY
50932011-03-14 Chong Yidong <cyd@stupidchicken.com>
5094
c96bbc66 5095 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5096
cffc6f3b
CY
50972011-03-13 Chong Yidong <cyd@stupidchicken.com>
5098
5099 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5100 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5101 These macros can no longer be used for assignment.
5102
44f230aa
SM
5103 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5104 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5105 (record_buffer_markers, fetch_buffer_markers): New functions for
5106 recording and fetching special buffer markers.
5107 (set_buffer_internal_1, set_buffer_temp): Use them.
5108
5109 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5110
5111 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5112
5113 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5114 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5115
5116 * xdisp.c (hscroll_window_tree):
5117 (reconsider_clip_changes): Use PT instead of BUF_PT.
5118
d251f04b
EZ
51192011-03-13 Eli Zaretskii <eliz@gnu.org>
5120
5121 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5122 $(EMACS_ROOT)/lib/intprops.h.
5123
f0c77cd1
PE
51242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5125
3eca4629
PE
5126 Fix more problems found by GCC 4.5.2's static checks.
5127
7c86ee98
PE
5128 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5129 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5130 (xg_free_frame_widgets): Make it clear that a local variable is
5131 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5132 (gdk_window_get_screen): Make it clear that this macro is needed
5133 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5134 (int_gtk_range_get_value): New function, which avoids a diagnostic
5135 from gcc -Wbad-function-cast.
5136 (xg_set_toolkit_scroll_bar_thumb): Use it.
5137 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5138 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5139 (get_utf8_string, xg_get_file_with_chooser):
5140 Rename locals to avoid shadowing.
5141 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5142
41729b81
PE
5143 * xgselect.c (xg_select): Remove unused var.
5144
f0c77cd1
PE
5145 * image.c (four_corners_best): Mark locals as initialized.
5146 (gif_load): Initialize transparent_p to zero (Bug#8238).
5147 Mark another local as initialized.
ec6cf4c6 5148 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5149
ce0ad53d 5150 * image.c (clear_image_cache): Now static.
d5d5a617 5151 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5152 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5153 (x_edge_detection): Remove unnecessary cast that
5154 gcc -Wbad-function-cast diagnoses.
2037898d 5155 (gif_load): Fix pointer signedness.
6ae141d6
PE
5156 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5157 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5158
33383987 51592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5160
d32df629
PE
5161 Improve quality of tests for time stamp overflow.
5162 For example, without this patch (encode-time 0 0 0 1 1
5163 1152921504606846976) returns the obviously-bogus value (-948597
5164 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5165 reports time overflow. See
5166 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5167 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5168 * editfns.c: Include limits.h and intprops.h.
5169 (TIME_T_MIN, TIME_T_MAX): New macros.
5170 (time_overflow): Move earlier, to before first use.
5171 (hi_time, lo_time): New functions, for an accurate test for
5172 out-of-range times.
5173 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5174 (Fget_internal_run_time): Don't assume time_t fits in int.
5175 (make_time): Use list2 instead of Fcons twice.
5176 (Fdecode_time): More accurate test for out-of-range times.
5177 (check_tm_member): New function.
5178 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5179 (lisp_time_argument): Don't rely on undefined left-shift and
5180 right-shift behavior when checking for time stamp overflow.
8be6f318 5181
fe31d94c
PE
5182 * editfns.c (time_overflow): New function, refactoring common code.
5183 (Fformat_time_string, Fdecode_time, Fencode_time):
5184 (Fcurrent_time_string): Use it.
5185
8be6f318
PE
5186 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5187 * dired.c (make_time): Move to ...
5188 * editfns.c (make_time): ... here.
5189 * systime.h: Note the move.
5190
09d9db2c 51912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5192
126bc0dc
YM
5193 * fringe.c (update_window_fringes): Remove unused variables.
5194
c47cbdfd
YM
5195 * unexmacosx.c (copy_data_segment): Also copy __got section.
5196 (Bug#8223)
5197
7ac80be9
EZ
51982011-03-12 Eli Zaretskii <eliz@gnu.org>
5199
c96bbc66 5200 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5201 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5202 Constify `char *' arguments and their references according to
5203 prototypes in tparam.h.
5204
ecb0f94d 5205 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5206
7ac80be9
EZ
5207 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5208 Adapt all references accordingly.
5209
5210 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5211
ef1fd07e
TT
52122011-03-11 Tom Tromey <tromey@redhat.com>
5213
5214 * buffer.c (syms_of_buffer): Remove obsolete comment.
5215
7ef4b50c
EZ
52162011-03-11 Eli Zaretskii <eliz@gnu.org>
5217
5218 * termhooks.h (encode_terminal_code): Declare prototype.
5219
5220 * msdos.c (encode_terminal_code): Don't declare prototype.
5221
5222 * term.c (encode_terminal_code): Now external again, used by
5223 w32console.c and msdos.c.
5224
44f230aa
SM
5225 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5226 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5227
4b1ec863 52282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5229
1714f52b 5230 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5231
4b1ec863
PE
5232 * fringe.c (update_window_fringes): Mark locals as initialized
5233 (Bug#8227).
5234 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5235
524c7aa6
PE
5236 * alloc.c (mark_fringe_data): Move decl from here ...
5237 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5238 to check its interface.
5239 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5240
a5c0af81 5241 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5242 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5243 (fontset_font): Mark local as initialized.
a9a06e0b 5244 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5245
b4716021
PE
5246 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5247
811e9bac 5248 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5249 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5250 (x_own_selection, Fx_disown_selection_internal): Rename locals
5251 to avoid shadowing.
5252 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5253
7e3ab302
PE
5254 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5255 so that the caller can use some name other than gcpro1.
5256 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5257 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5258 (Fx_backspace_delete_keys_p):
5259 Use them to avoid shadowing, and rename vars to avoid shadowing.
5260 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5261 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5262 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5263 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5264 Remove unused locals.
7e3ab302
PE
5265 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5266 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5267 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5268 macros.
f78faa98 5269
e2b13473
PE
5270 * xterm.h (x_mouse_leave): New decl.
5271
77f23912
PE
5272 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5273 Remove unused functions.
cdf4ba58
PE
5274 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5275 (x_calc_absolute_position): Now static.
7411c686 5276 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5277 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5278 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5279 unless they are used.
38d0b34a
PE
5280 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5281 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5282 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5283 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5284 (x_error_catcher, x_connection_closed, x_error_handler):
5285 (x_error_quitter, xembed_send_message, x_iconify_frame):
5286 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5287 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5288 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5289
44f230aa
SM
5290 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5291 Rename or move locals to avoid shadowing.
6b463e58 5292 (tty_defined_color, merge_face_heights): Now static.
5967d051 5293 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5294 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5295 does not deduce is never used uninitialized.
73719eba
PE
5296 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5297 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5298
426994c3 5299 * terminal.c (store_terminal_param): Now static.
5489860b 5300
032f1620 5301 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5302 (set_frame_menubar): Remove unused local.
d4323972 5303 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5304 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5305 since they might point to immutable storage.
281585b0
PE
5306 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5307 since it's unused otherwise.
032f1620 5308
367c19e5 5309 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5310 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5311 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5312 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5313 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5314 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5315 does not deduce are never used uninitialized.
70739cbe 5316
07b48fa9
PE
5317 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5318
8868a238 5319 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5320 * window.c (window_loop, size_window):
5321 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5322
7e5cf297 5323 * window.c (display_buffer): Now static.
d6550a9f
PE
5324 (size_window): Mark variables that gcc -Wuninitialized
5325 does not deduce are never used uninitialized.
a586633d
PE
5326 * window.h (check_all_windows): New decl, to forestall
5327 gcc -Wmissing-prototypes diagnostic.
5b555da1 5328 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5329
f6095868
PE
5330 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5331 shadowing.
5332 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5333 Include <limits.h>.
5334 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5335 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5336 (load_charset_map): Mark variables that gcc -Wuninitialized
5337 does not deduce are never used uninitialized.
53df7c11 5338 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5339
f38b440c
PE
5340 * coding.c (coding_set_source, coding_set_destination):
5341 Use "else { /* comment */ }" rather than "else /* comment */;"
5342 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5343 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5344 a block, when the outer 'i' will do.
5345 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5346 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5347 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5348 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5349 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5350 Rename locals to avoid shadowing.
5351 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5352 * coding.c (emacs_mule_char, encode_invocation_designation):
5353 Now static, since they're not used elsewhere.
413bb2db 5354 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5355 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5356 (decode_coding_emacs_mule): Mark variables that gcc
5357 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5358 (detect_coding_iso_2022): Initialize a local variable that might
5359 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5360 this initialization is needed. (Bug#8211)
5f58e762
PE
5361 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5362 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5363 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5364 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5365 Remove unused macros.
f38b440c 5366
232b38b9 5367 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5368 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5369 * character.c (string_count_byte8): Likewise.
232b38b9 5370
fb90da1b
PE
5371 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5372 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5373
fb93dbc2
PE
5374 * chartab.c (copy_sub_char_table): Now static, since it's not used
5375 elsewhere.
5c156ace
PE
5376 (sub_char_table_ref_and_range, char_table_ref_and_range):
5377 Rename locals to avoid shadowing.
bbcd0949 5378 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5379
7d3b3862 5380 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5381 (BIDI_BOB): Remove unused macro.
7d3b3862 5382
6be7d3da
PE
5383 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5384 deduce are never used uninitialized.
c2ed9c8b 5385 * term.c (encode_terminal_code): Likewise.
6be7d3da 5386
75f8807f 5387 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5388
50938595
PE
5389 * tparam.h: New file.
5390 * term.c, tparam.h: Include it.
5391 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5392 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5393 Move these decls to tparam.h, and make them agree with what
5394 is actually in tparam.c. The previous trick of using incompatible
5395 decls in different modules does not conform to the C standard.
5396 All callers of tparam changed to use tparam's actual API.
5397 * tparam.c (tparam1, tparam, tgoto):
5398 Use const pointers where appropriate.
5399
fbceeba2
PE
5400 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5401 * cm.h (struct cm): Likewise.
5402 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5403 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5404 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5405 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5406 (turn_on_face, init_tty): Likewise.
5407 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5408
7f3f1250
PE
5409 * term.c (term_mouse_position): Rename local to avoid shadowing.
5410
e6ca6543
PE
5411 * alloc.c (mark_ttys): Move decl from here ...
5412 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5413
c40f8d15
AS
54142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5415
5416 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5417
cfe0661d
JB
54182011-03-09 Juanma Barranquero <lekktu@gmail.com>
5419
5420 * search.c (compile_pattern_1): Remove argument regp, unused since
5421 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5422 (compile_pattern): Don't pass it.
5423
0afb4571
J
54242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5425
5426 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5427 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5428 for ! HAVE_GTK3.
5429 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5430
5431 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5432
5433 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5434 gdk_window_get_screen, gdk_window_get_geometry,
5435 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5436 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5437 (xg_get_pixbuf_from_pixmap): New function.
5438 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5439 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5440 Call xg_get_pixbuf_from_pixmap instead of
5441 gdk_pixbuf_get_from_drawable.
5442 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5443 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5444 (xg_check_special_colors): Use GtkStyleContext and its functions
5445 for HAVE_GTK3.
5446 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5447 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5448 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5449 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5450 Call gtk_widget_get_preferred_size.
0afb4571
J
5451 (xg_frame_resized): gdk_window_get_geometry only takes 5
5452 parameters.
44f230aa
SM
5453 (xg_win_to_widget, xg_event_is_for_menubar):
5454 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5455 (xg_set_widget_bg): New function.
5456 (delete_cb): New function.
895009e1 5457 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5458 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5459 (xg_set_background_color): Call xg_set_widget_bg.
5460 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5461 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5462 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5463 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5464 if ! HAVE_GTK3.
5465 (update_frame_tool_bar): Call gtk_widget_hide.
5466 (xg_initialize): Use GDK_KEY_g.
5467
5468 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5469 if ! HAVE_GTK3
5470 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5471
5472 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5473 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5474 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5475
1c2cc4ef
JB
54762011-03-08 Juanma Barranquero <lekktu@gmail.com>
5477
5478 * w32xfns.c (select_palette): Check success of RealizePalette against
5479 GDI_ERROR, not zero.
5480
33383987 5481See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5482
5483;; Local Variables:
5484;; coding: utf-8
aac0c6e3
MR
5485;; End:
5486
33383987 5487 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5488
5489 This file is part of GNU Emacs.
5490
5491 GNU Emacs is free software: you can redistribute it and/or modify
5492 it under the terms of the GNU General Public License as published by
5493 the Free Software Foundation, either version 3 of the License, or
5494 (at your option) any later version.
5495
5496 GNU Emacs is distributed in the hope that it will be useful,
5497 but WITHOUT ANY WARRANTY; without even the implied warranty of
5498 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5499 GNU General Public License for more details.
5500
5501 You should have received a copy of the GNU General Public License
5502 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.