Fix wm_size-hints race between KDE/KWin and Gtk+ 3.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c7e73be5
JD
12011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2
3 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4 (emacs_fixed_set_min_size): Remove.
5 (emacs_fixed_new): Take frame as argument.
6
7 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8 (_EmacsFixedPrivate): Remove minwidth/height.
9 Add struct frame *f.
10 (emacs_fixed_init): Initialize priv->f.
11 (get_parent_class, emacs_fixed_set_min_size): Remove.
12 (emacs_fixed_new): Set priv->f to argument.
13 (emacs_fixed_get_preferred_width)
14 (emacs_fixed_get_preferred_height): Use min_width/height from
15 frames size_hint to set minimum and natural (Bug#8919).
16 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
17 and use min_width/height from frames size_hint to set
18 min_width/height (Bug#8919).
19
20 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
21 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
22 indentation.
23
cf99dcf8
EZ
242011-06-26 Eli Zaretskii <eliz@gnu.org>
25
26 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
27 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
28 called at ZV.
29
029529ac
CY
302011-06-26 Chong Yidong <cyd@stupidchicken.com>
31
32 * process.c (wait_reading_process_output): Bypass select if
33 waiting for a cell while ignoring keyboard input, and input is
34 pending. Suggested by Jan Djärv (Bug#8869).
35
7a7ef429
PE
362011-06-25 Paul Eggert <eggert@cs.ucla.edu>
37
38 Use gnulib's dup2 module instead of rolling our own.
39 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
40
11fdef7d 412011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
42
43 * dispnew.c (scrolling_window): Before scrolling, turn off a
44 mouse-highlight in the window being scrolled.
45
cd3520a4
JB
462011-06-24 Juanma Barranquero <lekktu@gmail.com>
47
48 Move DEFSYM to lisp.h and use everywhere.
49
50 * character.h (DEFSYM): Move declaration...
51 * lisp.h (DEFSYM): ...here.
52
53 * gnutls.c:
54 * minibuf.c:
55 * w32menu.c:
56 * w32proc.c:
57 * w32select.c: Don't include character.h.
58
59 * alloc.c (syms_of_alloc):
60 * buffer.c (syms_of_buffer):
61 * bytecode.c (syms_of_bytecode):
62 * callint.c (syms_of_callint):
63 * casefiddle.c (syms_of_casefiddle):
64 * casetab.c (init_casetab_once):
65 * category.c (init_category_once, syms_of_category):
66 * ccl.c (syms_of_ccl):
67 * cmds.c (syms_of_cmds):
68 * composite.c (syms_of_composite):
69 * dbusbind.c (syms_of_dbusbind):
70 * dired.c (syms_of_dired):
71 * dispnew.c (syms_of_display):
72 * doc.c (syms_of_doc):
73 * editfns.c (syms_of_editfns):
74 * emacs.c (syms_of_emacs):
75 * eval.c (syms_of_eval):
76 * fileio.c (syms_of_fileio):
77 * fns.c (syms_of_fns):
78 * frame.c (syms_of_frame):
79 * fringe.c (syms_of_fringe):
80 * insdel.c (syms_of_insdel):
81 * keymap.c (syms_of_keymap):
82 * lread.c (init_obarray, syms_of_lread):
83 * macros.c (syms_of_macros):
84 * msdos.c (syms_of_msdos):
85 * print.c (syms_of_print):
86 * process.c (syms_of_process):
87 * search.c (syms_of_search):
88 * sound.c (syms_of_sound):
89 * syntax.c (init_syntax_once, syms_of_syntax):
90 * terminal.c (syms_of_terminal):
91 * textprop.c (syms_of_textprop):
92 * undo.c (syms_of_undo):
93 * w32.c (globals_of_w32):
94 * window.c (syms_of_window):
95 * xdisp.c (syms_of_xdisp):
96 * xfaces.c (syms_of_xfaces):
97 * xfns.c (syms_of_xfns):
98 * xmenu.c (syms_of_xmenu):
99 * xsettings.c (syms_of_xsettings):
100 * xterm.c (syms_of_xterm): Use DEFSYM.
101
4228cf16
TZ
1022011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
103
cd3520a4 104 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 105
7fcccf1e
PE
1062011-06-23 Paul Eggert <eggert@cs.ucla.edu>
107
7efb4e0e
PE
108 Integer and buffer overflow fixes (Bug#8873).
109
ff5844ad
PE
110 * print.c (printchar, strout): Check for string overflow.
111 (PRINTPREPARE, printchar, strout):
112 Don't set size unless allocation succeeds.
113
90532f02
PE
114 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
115 for sizes. Check for string overflow more accurately.
116 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
117
6d84508d
PE
118 * macros.c: Integer and buffer overflow fixes.
119 * keyboard.h (struct keyboard.kbd_macro_bufsize):
120 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
121 Use ptrdiff_t, not int, for sizes.
122 Don't increment bufsize until after realloc succeeds.
123 Check for size-calculation overflow.
124 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
125
437b2cb4
PE
126 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
127
8b9ac8b4
PE
128 * lread.c: Integer overflow fixes.
129 (read_integer): Radix is now EMACS_INT, not int,
130 to improve quality of diagnostics for out-of-range radices.
131 Calculate buffer size correctly for out-of-range radices.
132 (read1): Check for integer overflow in radices, and in
133 read-circle numbers.
82cb60d3
PE
134 (read_escape): Avoid int overflow.
135 (Fload, openp, read_buffer_size, read1)
136 (substitute_object_recurse, read_vector, read_list, map_obarray):
137 Use ptrdiff_t, not int, for sizes.
138 (read1): Use EMACS_INT, not int, for sizes.
20270765 139 Check for size overflow.
8b9ac8b4 140
7fcccf1e
PE
141 * image.c (cache_image): Check for size arithmetic overflow.
142
bfbbd7e7
PE
143 * lread.c: Integer overflow issues.
144 (saved_doc_string_size, saved_doc_string_length)
145 (prev_saved_doc_string_size, prev_saved_doc_string_length):
146 Now ptrdiff_t, not int.
147 (read1): Don't assume doc string length fits in int. Check for
148 out-of-range doc string lengths.
149 (read_list): Don't assume file position fits in int.
39019e54 150 (read_escape): Check for hex character overflow.
bfbbd7e7 151
4e323265
LL
1522011-06-22 Leo Liu <sdl.web@gmail.com>
153
154 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
155 Move to minibuffer.el.
156
85fece3e
PE
1572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
158
20b84ce9 159 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
160 The following patches are for when GLYPH_DEBUG && !XASSERT.
161 * dispextern.h (trace_redisplay_p, dump_glyph_string):
162 * dispnew.c (flush_stdout):
163 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
164 Mark as externally visible.
165 * dispnew.c (check_window_matrix_pointers): Now static.
166 * dispnew.c (window_to_frame_vpos):
167 * xfns.c (unwind_create_frame):
168 * xterm.c (x_check_font): Remove unused local.
169 * scroll.c (CHECK_BOUNDS):
170 * xfaces.c (cache_fache): Rename local to avoid shadowing.
171 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
172 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
173 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
174 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
175 Now static.
176 (debug_method_add): Use va_list and vsprintf rather than relying
177 on undefined behavior with wrong number of arguments.
178 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
179 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
180 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
181 since we're not interested in debugging glyphs with old libraries.
182 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
183 GCC 4.6.0's static checking.
184
0766b489
PE
1852011-06-22 Paul Eggert <eggert@cs.ucla.edu>
186
31fd4b32
PE
187 Integer overflow and signedness fixes (Bug#8873).
188 A few related buffer overrun fixes, too.
189
b79e8648
PE
190 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
191
0766b489
PE
192 * dispextern.h (struct face.stipple):
193 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
194 (x_bitmap_mask, x_allocate_bitmap_record)
195 (x_create_bitmap_from_data, x_create_bitmap_from_file)
196 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
197 (x_create_bitmap_from_xpm_data):
198 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
199 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
200 (.bitmaps_last):
201 * xfaces.c (load_pixmap):
202 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
203 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
204 (.bitmaps_last, struct x_output.icon_bitmap):
205 Use ptrdiff_t, not int, for bitmap indexes.
206 (x_allocate_bitmap_record): Check for size overflow.
207 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
208
b081724f
PE
209 Use ptrdiff_t, not int, for overlay counts.
210 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
211 * editfns.c (overlays_around, get_pos_property):
212 * textprop.c (get_char_property_and_overlay):
213 * xdisp.c (next_overlay_change, note_mouse_highlight):
214 * xfaces.c (face_at_buffer_position):
21514da7
PE
215 * buffer.c (OVERLAY_COUNT_MAX): New macro.
216 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
217 (Fnext_overlay_change, Fprevious_overlay_change)
218 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 219 Use ptrdiff_t, not int, for sizes.
21514da7 220 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 221
3de73e5e
PE
222 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
223
2606c57b
PE
224 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
225 (x_session_initialize): Do not assume string length fits in int.
226
aaafe47a
PE
227 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
228 This is unlikely, but can occur if DPI is outlandish.
229
2674ddc8 230 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
231 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
232
28154962
PE
233 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
234 * xrdb.c (magic_file_p, search_magic_path):
235 Omit last arg SUFFIX; it was always 0. All callers changed.
236 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
237
7de51af5
PE
238 * xfont.c (xfont_match): Avoid need for strlen.
239
25ed6cc3
PE
240 * xfns.c: Don't assume strlen fits in int.
241 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
242
4eab31dd
PE
243 * xdisp.c (message_log_check_duplicate): Return intmax_t,
244 not unsigned long, as we prefer signed integers. All callers changed.
245 Detect integer overflow in repeat count.
246 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 247 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 248
171e2a58
PE
249 * termcap.c: Don't assume sizes fit in int and never overflow.
250 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
251 (gobble_line): Check for size-calculation overflow.
252
ad39faca 253 * minibuf.c (Fread_buffer):
6e5bb2dc 254 * lread.c (intern, intern_c_string):
74ca2eb3
PE
255 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
256 Don't assume string length fits in int.
257
52c61c22 258 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
259 * gtkutil.c (style_changed_cb): Avoid need for strlen.
260
b5b8c9e5
PE
261 * font.c: Don't assume string length fits in int.
262 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
263 Use ptrdiff_t, not int.
ccd6111c
PE
264 (font_intern_prop): Don't assume string length fits in int.
265 Don't assume integer property fits in fixnum.
266 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 267
882f0d81 268 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 269 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
270 Reformulate so as not to need the command string.
271 Invoke gzip -cd rather than gunzip, as it's more portable.
272 (lock_info_type, lock_file_1, lock_file):
273 Don't assume pid_t and time_t fit in unsigned long.
274 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
275 (current_lock_owner): Prefer signed type for sizes.
276 Use memcpy, not strncpy, where memcpy is what is really wanted.
277 Don't assume (via atoi) that time_t and pid_t fit in int.
278 Check for time_t and/or pid_t out of range, e.g., via a network share.
279 Don't alloca where an auto var works fine.
280
93f4cf88
PE
281 * fileio.c: Fix some integer overflow issues.
282 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
283 Don't assume string length fits in int.
284 (directory_file_name): Don't assume string length fits in long.
285 (make_temp_name): Don't assume pid fits in int, or that its print
286 length is less than 20.
287
f3e92b69
PE
288 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
289
1bfdaf10
PE
290 * coding.c (make_subsidiaries): Don't assume string length fits in int.
291
35016e9a
PE
292 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
293
3d1e65a1
PE
294 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
295 We prefer signed integers, even for size calculations.
296
0b963a93
PE
297 * emacs.c: Don't assume string length fits in 'int'.
298 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
299 (main): Don't invoke strlen when not needed.
300
573f4b54
PE
301 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
302 (XD_DEBUG_MESSAGE): Don't waste a byte.
303
989f33ba
PE
304 * callproc.c (getenv_internal_1, getenv_internal)
305 (Fgetenv_internal):
965d34eb
PE
306 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
307
e4d29b33
PE
308 * lread.c (invalid_syntax): Omit length argument.
309 All uses changed. This doesn't fix a bug, but it simplifies the
310 code away from its former Hollerith-constant appearance, and it's
311 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 312 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 313
eb49b136
PE
314 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
315 This didn't break anything, but it didn't help either.
316 It's confusing to put a bogus integer in a place where the actual
317 value does not matter.
9f62aeb1 318 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 319 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 320
15375a22
PE
321 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
322 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
323 implementation.
b61cc01c
PE
324 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
325 We prefer signed types, and the value cannot exceed the EMACS_INT
326 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
327 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
328 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
329 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 330
53b2623d
PE
331 * indent.c (sane_tab_width): New function.
332 (current_column, scan_for_column, Findent_to, position_indentation)
333 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 334 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 335
51cab52b 336 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 337
f2ed8a70
PE
338 * lisp.h (lint_assume): New macro.
339 * composite.c (composition_gstring_put_cache):
340 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
341
abe80cc6
PE
342 * editfns.c, insdel.c:
343 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 344
b02c740e
PE
345 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
346
ebc96716
PE
347 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
348
b4e50fa0 349 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 350 Use much-faster test for byte-length change.
311d5d7c 351 Don't assume string byte-length fits in 'int'.
a4cf38e4 352 Check that character arg fits in 'int'.
85461888 353 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 354
c0c1ee9f
PE
355 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
356
a498d7f4
PE
357 * fns.c (concat): Catch string overflow earlier.
358 Do not rely on integer wraparound.
359
51cab52b
PE
360 * dispextern.h (struct it.overlay_strings_charpos)
361 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
362 * xdisp.c (forward_to_next_line_start)
363 (back_to_previous_visible_line_start)
364 (reseat_at_next_visible_line_start, next_element_from_buffer):
365 Don't arbitrarily truncate the value of 'selective' to int.
366
76031fad
PE
367 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
368
5eb55db9
PE
369 * composite.c: Don't truncate sizes to 'int'.
370 (composition_gstring_p, composition_reseat_it)
371 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
372 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
373 not EMACS_UINT, for indexes.
5eb55db9 374
0703a717
PE
375 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
376
d6202519
PE
377 * buffer.c: Include <verify.h>.
378 (struct sortvec.priority, struct sortstr.priority):
8961a454 379 Now EMACS_INT, not int.
c20998a7 380 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
381 (struct sortstr.size, record_overlay_string)
382 (struct sortstrlist.size, struct sortlist.used):
383 Don't truncate size to int.
384 (record_overlay_string): Check for size-calculation overflow.
d6202519 385 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 386
d5a19415
JM
3872011-06-22 Jim Meyering <meyering@redhat.com>
388
029529ac 389 Don't leak an XBM-image-sized buffer
d5a19415
JM
390 * image.c (xbm_load): Free the image buffer after using it.
391
a9041e6c
PE
3922011-06-21 Paul Eggert <eggert@cs.ucla.edu>
393
394 Port to Sun C.
395 * composite.c (find_automatic_composition): Omit needless 'return 0;'
396 that Sun C diagnosed.
397 * fns.c (secure_hash): Fix pointer signedness issue.
398 * intervals.c (static_offset_intervals): New function.
399 (offset_intervals): Use it.
400
7f3f739f
LL
4012011-06-21 Leo Liu <sdl.web@gmail.com>
402
403 * deps.mk (fns.o):
404 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
405 sha512.h.
406
407 * fns.c (secure_hash): Rename from crypto_hash_function and change
408 the first arg to accept symbols.
5b66d427 409 (Fsecure_hash): New primitive.
7f3f739f
LL
410 (syms_of_fns): New symbols.
411
76147d94
DD
4122011-06-20 Deniz Dogan <deniz@dogan.se>
413
414 * process.c (Fset_process_buffer): Clarify return value in
415 docstring.
416
7d7d0045
CY
4172011-06-18 Chong Yidong <cyd@stupidchicken.com>
418
419 * dispnew.c (add_window_display_history): Use BVAR.
420
421 * xdisp.c (debug_method_add): Use BVAR.
422 (check_window_end, dump_glyph_matrix, dump_glyph)
423 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
424
425 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
426 Likewise.
427
428 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
429 check till after the cache is created in init_frame_faces.
430
ff2bc410
SM
4312011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
432
433 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
434
28177add
PE
4352011-06-16 Paul Eggert <eggert@cs.ucla.edu>
436
dd3482fe
PE
437 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
438 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
439 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
440
393d71f3 441 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
442 * fileio.c (Finsert_file_contents):
443 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
444 Remove the old (too-loose) buffer overflow checks.
445 They weren't needed, since make_gap checks for buffer overflow.
446 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
447 The old code merely checked for Emacs fixnum overflow, and relied
448 on undefined (wraparound) behavior. The new code avoids undefined
449 behavior, and also checks for ptrdiff_t and/or size_t overflow.
450
2e6813b0 451 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
452 Tune. Don't use wider integers than needed. Don't use alloca.
453 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 454
599a9e4f
PE
455 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
456
99561444
PE
457 * insdel.c, lisp.h (buffer_overflow): New function.
458 (insert_from_buffer_1, replace_range, replace_range_2):
459 * insdel.c (make_gap_larger):
460 * editfns.c (Finsert_char):
461 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
462
28177add
PE
463 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
464
e69dafad
PE
4652011-06-15 Paul Eggert <eggert@cs.ucla.edu>
466
a7af7fde 467 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 468
b1c46f02
PE
469 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
470 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
471
e69dafad
PE
472 * fileio.c: Don't assume EMACS_INT fits in off_t.
473 (emacs_lseek): New static function.
474 (Finsert_file_contents, Fwrite_region): Use it.
475 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
476
566684ea
PE
477 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
478
e6966cd6
PE
479 * fns.c: Don't overflow int when computing a list length.
480 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
481 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
482 truncation on 64-bit hosts. Check for QUIT every
483 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
484 faster and is responsive enough.
485 (Flength): Report an error instead of overflowing an integer.
486 (Fsafe_length): Return a float if the value is not representable
487 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 488 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 489 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 490
dd0b0efb
PE
491 * alloc.c: Check that resized vectors' lengths fit in fixnums.
492 (header_size, word_size): New constants.
493 (allocate_vectorlike): Don't check size overflow here.
494 (allocate_vector): Check it here instead, since this is the only
495 caller of allocate_vectorlike that could cause overflow.
496 Check that the new vector's length is representable as a fixnum.
497
86fe5cfe
PE
498 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
499 The previous code was bogus. For example, next_almost_prime (32)
500 returned 39, which is undesirable as it is a multiple of 3; and
501 next_almost_prime (24) returned 25, which is a multiple of 5 so
502 why was the code bothering to check for multiples of 7?
503
80e88859
PE
504 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
505
4a2f0ad6
PE
506 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
507
f66c7cf8
PE
508 Variadic C functions now count arguments with ptrdiff_t.
509 This partly undoes my 2011-03-30 change, which replaced int with size_t.
510 Back then I didn't know that the Emacs coding style prefers signed int.
511 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
512 were being counted with int, which may truncate counts on 64-bit
513 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
514 * lisp.h (struct Lisp_Subr.function.aMANY)
515 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
516 Arg counts are now ptrdiff_t, not size_t.
517 All variadic functions and their callers changed accordingly.
518 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
519 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
520 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
521 * callint.c (Fcall_interactively): Check arg count for overflow,
522 to avoid potential buffer overrun. Use signed char, not 'int',
523 for 'varies' array, so that we needn't bother to check its size
524 calculation for overflow.
525 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
526 * eval.c (apply_lambda):
527 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
528 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
529 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
530
a1759b76
PE
531 * callint.c (Fcall_interactively): Don't use index var as event count.
532
d96be9fc
PE
533 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
534 * mem-limits.h (SIZE): Remove; no longer used.
535
a690a978 536 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 537
578c21e6
PE
538 Remove unnecessary casts.
539 * xterm.c (x_term_init):
540 * xfns.c (x_set_border_pixel):
541 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
542 These aren't needed now that we assume ANSI C.
543
96f53c6c
PE
544 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
545 It's more likely to cause problems (due to unsigned overflow)
546 than to cure them.
547
83c77d31
PE
548 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
549
ee2079f1
PE
550 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
551
6da65536
PE
552 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
553
7147c4a4
PE
554 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
555
193e32d9
PE
556 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
557
e5533da6
PE
558 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
559
9910e595
PE
560 GLYPH_CODE_FACE returns EMACS_INT, not int.
561 * dispextern.h (merge_faces):
562 * xfaces.c (merge_faces):
01103c44
PE
563 * xdisp.c (get_next_display_element, next_element_from_display_vector):
564 Don't assume EMACS_INT fits in int.
9910e595 565
2638320e
PE
566 * character.h (CHAR_VALID_P): Remove unused parameter.
567 * fontset.c, lisp.h, xdisp.c: All uses changed.
568
045eb8d9
PE
569 * editfns.c (Ftranslate_region_internal): Omit redundant test.
570
c1f134b5
PE
571 * fns.c (concat): Minor tuning based on overflow analysis.
572 This doesn't fix any bugs. Use int to hold character, instead
573 of constantly refetching from Emacs object. Use XFASTINT, not
574 XINT, for value known to be a character. Don't bother comparing
575 a single byte to 0400, as it's always less.
576
395fcb93 577 * floatfns.c (Fexpt):
327eeec8
PE
578 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
579
abbd3d23
PE
580 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
581 for characters.
582
684a03ef
PE
583 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
584
0fed43f3
PE
585 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
586 Without this fix, on a 64-bit host (aset S 0 4294967386) would
587 incorrectly succeed when S was a string, because 4294967386 was
588 truncated before it was used.
589
8fd02eb7
PE
590 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
591 Otherwise, an out-of-range integer could cause undefined behavior
592 on a 64-bit host.
593
f8c86b69
PE
594 * composite.c: Use int, not EMACS_INT, for characters.
595 (fill_gstring_body, composition_compute_stop_pos): Use int, not
596 EMACS_INT, for values that are known to be in character range.
597 This doesn't fix any bugs but is the usual style inside Emacs and
598 may generate better code on 32-bit machines.
599
34206dd2
PE
600 Make sure a 64-bit char is never passed to ENCODE_CHAR.
601 This is for reasons similar to the recent CHAR_STRING fix.
602 * charset.c (Fencode_char): Check that character arg is actually
603 a character. Pass an int to ENCODE_CHAR.
604 * charset.h (ENCODE_CHAR): Verify that the character argument is no
605 wider than 'int', as a compile-time check to prevent future regressions
606 in this area.
607
c5958d4c 608 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
609
610 Make sure a 64-bit char is never passed to CHAR_STRING.
611 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
612 by silently ignoring the top 32 bits, allowing some values
613 that were far too large to be valid characters.
614 * character.h: Include <verify.h>.
615 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
616 arguments are no wider than unsigned, as a compile-time check
617 to prevent future regressions in this area.
618 * data.c (Faset):
01103c44 619 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
620 (Fsubst_char_in_region):
621 * fns.c (concat):
622 * xdisp.c (decode_mode_spec_coding):
623 Adjust to CHAR_STRING's new requirement.
624 * editfns.c (Finsert_char, Fsubst_char_in_region):
625 * fns.c (concat): Check that character args are actually
626 characters. Without this test, these functions did the wrong
627 thing with wildly out-of-range values on 64-bit hosts.
628
d37ca623
PE
629 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
630 These casts should not be needed on 32-bit hosts, either.
631 * keyboard.c (read_char):
632 * lread.c (Fload): Remove casts to unsigned.
633
ea204efb
PE
634 * lisp.h (UNSIGNED_CMP): New macro.
635 This fixes comparison bugs on 64-bit hosts.
636 (ASCII_CHAR_P): Use it.
637 * casefiddle.c (casify_object):
01103c44 638 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
639 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
640 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
641 * dispextern.h (FACE_FROM_ID):
642 * keyboard.c (read_char): Use UNSIGNED_CMP.
643
41cb286c
PE
644 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
645 not to EMACS_INT, to avoid GCC warning.
646
4a1b9832
PE
647 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
648
55daad71
PE
649 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
650 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
651 isn't needed on 32-bit machines.
8f95c75c 652
01103c44
PE
653 * buffer.c (Fgenerate_new_buffer_name):
654 Use EMACS_INT for count, not int.
0ceccced 655 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
656
657 * data.c (Qcompiled_function): Now static.
658
c6f072e7
PE
659 * window.c (window_body_lines): Now static.
660
20ce5912
PE
661 * image.c (gif_load): Rename local to avoid shadowing.
662
9c4c5f81
PE
663 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
664 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
665 * alloc.c (make_save_value): Integer argument is now of type
666 ptrdiff_t, not int.
667 (mark_object): Use ptrdiff_t, not int.
668 * lisp.h (pD): New macro.
669 * print.c (print_object): Use it.
670
c0c5c8ae
PE
671 * alloc.c: Use EMACS_INT, not int, to count objects.
672 (total_conses, total_markers, total_symbols, total_vector_size)
673 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
674 (total_free_floats, total_floats, total_free_intervals)
675 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
676 Now EMACS_INT, not int. All uses changed.
677 (Fgarbage_collect): Compute overall total using a double, so that
678 integer overflow is less likely to be a problem. Check for overflow
679 when converting back to an integer.
5a25e253
PE
680 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
681 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
682 These were 'int' variables that could overflow on 64-bit hosts;
683 they were never used, so remove them instead of repairing them.
211a0b2a 684 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
685 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
686 Previously, this ceilinged at INT_MAX, but that doesn't work on
687 64-bit machines.
e46bb31a 688 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 689
c78baabf 690 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 691 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
692 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
693 when a (possibly-narrower) signed value would do just as well.
694 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 695
c9d624c6
PE
696 * alloc.c: Catch some string size overflows that we were missing.
697 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
698 for convenience in STRING_BYTES_MAX.
699 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
700 The definition here is exact; the one in lisp.h was approximate.
701 (allocate_string_data): Check for string overflow. This catches
702 some instances we weren't catching before. Also, it catches
703 size_t overflow on (unusual) hosts where SIZE_MAX <= min
704 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
705 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 706
c9d624c6
PE
707 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
708 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
709 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
710
353032ce
PE
711 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
712
2bccce07
PE
713 * alloc.c (Fmake_string): Check for out-of-range init.
714
0ac30604
SM
7152011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
716
717 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
718
c195f2de
JD
7192011-06-14 Jan Djärv <jan.h.d@swipnet.se>
720
721 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
722 xg_get_default_scrollbar_width.
723
724 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
725 (int_gtk_range_get_value): Move to the scroll bar part of the file.
726 (style_changed_cb): Call update_theme_scrollbar_width and call
727 x_set_scroll_bar_default_width and xg_frame_set_char_size for
728 all frames (Bug#8505).
729 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
730 Call gtk_window_set_resizable if HAVE_GTK3.
731 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
732 and height if HAVE_GTK3 (Bug#8505).
733 (scroll_bar_width_for_theme): New variable.
734 (update_theme_scrollbar_width): New function.
735 (xg_get_default_scrollbar_width): Move code to
736 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
737 (xg_initialize): Call update_theme_scrollbar_width.
738
739 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
740
741 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
742
e10ac9f1
MR
7432011-06-12 Martin Rudalics <rudalics@gmx.at>
744
745 * frame.c (make_frame): Call other_buffer_safely instead of
746 other_buffer.
747
748 * window.c (temp_output_buffer_show): Call display_buffer with
749 second argument Vtemp_buffer_show_specifiers and reset latter
750 immediately after the call.
751 (Vtemp_buffer_show_specifiers): New variable.
752 (auto_window_vscroll_p, next_screen_context_lines)
753 (Vscroll_preserve_screen_position): Remove leading asterisks from
754 doc-strings.
755
2d3c217e 7562011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 757
7b7f97e8 758 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
759 * buffer.c (Qclone_number): Remove for now, as it's unused.
760 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
761 (record_buffer): Remove unused local.
762 * frame.c (other_visible_frames, frame_buffer_list): Now static.
763 (set_frame_buffer_list): Remove; unused.
764 * frame.h (other_visible_frames): Remove decl.
765 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
766 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
767 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
768 if HAVE_GPM.
769 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
770 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
771 Define only if HAVE_GPM.
772 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
773 (update_hints_inhibit): Remove; never set. All uses removed.
774 * widgetprv.h (emacsFrameClassRec): Remove decl.
775 * window.c (delete_deletable_window): Now returns void, since it
776 wasn't returning anything.
777 (compare_window_configurations): Remove unused locals.
778 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
779 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
780 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
781 the same widths as pointers. This follows up on the 2011-05-06 patch.
782 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
783 * xterm.h: Likewise.
784 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
785
1384b89e
JB
7862011-06-12 Juanma Barranquero <lekktu@gmail.com>
787
788 * makefile.w32-in: Update dependencies.
789 (LISP_H): Add lib/intprops.h.
790
1100a63c
CY
7912011-06-11 Chong Yidong <cyd@stupidchicken.com>
792
793 * image.c (gif_load): Add animation frame delay to the metadata.
794 (syms_of_image): Use DEFSYM. New symbol `delay'.
795
6198ccd0
MR
7962011-06-11 Martin Rudalics <rudalics@gmx.at>
797
798 * window.c (delete_deletable_window): Re-add.
799 (Fset_window_configuration): Rewrite to handle dead buffers and
800 consequently deletable windows.
801 (window_tree, Fwindow_tree): Remove. Supply functionality in
802 window.el.
803 (compare_window_configurations): Simplify code.
804
b6e3633c
AS
8052011-06-11 Andreas Schwab <schwab@linux-m68k.org>
806
1ab0dee5
AS
807 * image.c (imagemagick_load_image): Fix type mismatch.
808 (Fimagemagick_types): Likewise.
809
b6e3633c
AS
810 * window.h (replace_buffer_in_windows): Declare.
811
9397e56f
MR
8122011-06-11 Martin Rudalics <rudalics@gmx.at>
813
814 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
815 Qclone_number. Remove external declaration of Qdelete_window.
816 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
817 code.
818 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
819 Qbuffer_list_update_hook if allowed.
820 (Fother_buffer): Rewrite doc-string. Major rewrite for new
821 buffer list implementation.
822 (other_buffer_safely): New function.
823 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
824 calls to replace_buffer_in_windows and
825 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
826 if allowed.
827 (record_buffer): Inhibit quitting and rewrite using quittable
828 functions. Run Qbuffer_list_update_hook if allowed.
829 (Frecord_buffer, Funrecord_buffer): New functions.
830 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
831 switch-to-buffer to window.el.
832 (bury-buffer): Move to window.el.
833 (Vbuffer_list_update_hook): New variable.
834
835 * lisp.h (other_buffer_safely): Add prototype in buffer.c
836 section.
837
838 * window.h (resize_frame_windows): Move up in code.
839 (Fwindow_frame): Remove EXFUN.
840 (replace_buffer_in_all_windows): Remove prototype.
841 (replace_buffer_in_windows_safely): Add prototype.
842
843 * window.c: Declare Qdelete_window static again. Move down
844 declaration of select_count.
845 (Fnext_window, Fprevious_window): Rewrite doc-strings.
846 (Fother_window): Move to window.el.
847 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
848 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
849 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
850 window.el.
851 (replace_buffer_in_windows): Implement by calling
852 Qreplace_buffer_in_windows.
853 (replace_buffer_in_all_windows): Remove with some functionality
854 moved into replace_buffer_in_windows_safely.
855 (replace_buffer_in_windows_safely): New function.
856 (select_window_norecord, select_frame_norecord): Move in front
857 of run_window_configuration_change_hook. Remove now obsolete
858 declarations.
859 (Fset_window_buffer): Rewrite doc-string. Call
860 Qrecord_window_buffer.
861 (keys_of_window): Move binding for other-window to window.el.
862
b50691aa
CY
8632011-06-11 Chong Yidong <cyd@stupidchicken.com>
864
865 * dispextern.h (struct image): Replace data member, whose int_val
866 and ptr_val fields were not used by anything, with a single
867 lisp_val object.
868
869 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
870 (gif_clear_image, gif_load, imagemagick_load_image)
871 (gs_clear_image, gs_load): Callers changed.
872
3f754b86
PE
8732011-06-10 Paul Eggert <eggert@cs.ucla.edu>
874
cca69397
PE
875 * buffer.h: Include <time.h>, for time_t.
876 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
877
109e28d0
PE
878 Fix minor problems found by static checking.
879
60737f02
PE
880 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
881
4b66faf3
PE
882 Make identifiers static if they are not used in other modules.
883 * data.c (Qcompiled_function, Qframe, Qvector):
884 * image.c (QimageMagick, Qsvg):
885 * minibuf.c (Qmetadata):
886 * window.c (resize_window_check, resize_root_window): Now static.
887 * window.h (resize_window_check, resize_root_window): Remove decls.
888
109e28d0
PE
889 * window.c (window_deletion_count, delete_deletable_window):
890 Remove; unused.
46a4ce9e
PE
891 (window_body_lines): Now static.
892 (Fdelete_other_windows_internal): Mark vars as initialized.
893 Make sure 'resize_failed' is initialized.
894 (run_window_configuration_change_hook): Rename local to avoid shadowing.
895 (resize_window_apply): Remove unused local.
896 * window.h (delete_deletable_window): Remove decl.
897
109e28d0 898 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
899 (imagemagick_load_image): Fix pointer signedness problem by changing
900 last arg from unsigned char * to char *. All uses changed.
901 Also, fix a local for similar reasons.
902 Remove unused locals. Remove locals to avoid shadowing.
903 (fn_rsvg_handle_free): Remove; unused.
904 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 905 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 906
3f754b86
PE
907 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
908
2547adb1
CY
9092011-06-10 Chong Yidong <cyd@stupidchicken.com>
910
911 * image.c (gif_load): Fix omitted cast error introduced by
912 2011-06-06 change.
913
2c8e37d4
MR
9142011-06-10 Martin Rudalics <rudalics@gmx.at>
915
916 * window.h (resize_proportionally, orig_total_lines)
917 (orig_top_line): Remove from window structure.
918 (set_window_height, set_window_width, change_window_heights)
919 (Fdelete_window): Remove prototypes.
920 (resize_frame_windows): Remove duplicate declaration.
921
440a42e3
EZ
9222011-06-10 Eli Zaretskii <eliz@gnu.org>
923
924 * window.h (resize_frame_windows, resize_window_check)
925 (delete_deletable_window, resize_root_window)
926 (resize_frame_windows): Declare prototypes.
927
928 * window.c (resize_window_apply): Make definition be "static" to
929 match the prototype.
930
562dd5e9
MR
9312011-06-10 Martin Rudalics <rudalics@gmx.at>
932
933 * window.c: Remove declarations of Qwindow_size_fixed,
934 window_min_size_1, window_min_size_2, window_min_size,
935 size_window, window_fixed_size_p, enlarge_window, delete_window.
936 Remove static from declaration of Qdelete_window, it's
937 temporarily needed by Fbury_buffer.
938 (replace_window): Don't assign orig_top_line and
939 orig_total_lines.
940 (Fdelete_window, delete_window): Remove. Window deletion is
941 handled by window.el.
942 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
943 Fdelete_window calls with calls to Qdelete_window.
944 (Fdelete_other_windows): Remove. Deleting other windows is
945 handled by window.el.
946 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
947 handled in window.el.
948 (window_min_size_2, window_min_size_1, window_min_size): Remove.
949 Window minimum sizes are handled in window.el.
950 (shrink_windows, size_window, set_window_height)
951 (set_window_width, change_window_heights, window_height)
952 (window_width, CURBEG, CURSIZE, enlarge_window)
953 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
954 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
955 handled in window.el.
956 (make_dummy_parent): Rename to make_parent_window and give it a
957 second argument horflag.
958 (make_window): Don't set resize_proportionally any more.
959 (Fsplit_window): Remove. Windows are split in window.el.
960 (save_restore_action, save_restore_orig_size)
961 (shrink_window_lowest_first, save_restore_orig_size): Remove.
962 Resize mini windows in window.el.
963 (grow_mini_window, shrink_mini_window): Implement by calling
964 Qresize_root_window_vertically, resize_window_check and
965 resize_window_apply.
966 (saved_window, Fset_window_configuration, save_window_save): Do
967 not handle orig_top_line, orig_total_lines, and
968 resize_proportionally.
969 (window_min_height, window_min_width): Move to window.el.
970 (keys_of_window): Move bindings for delete-other-windows,
971 split-window, delete-window and enlarge-window to window.el.
972
973 * buffer.c: Temporarily extern Qdelete_window.
974 (Fbury_buffer): Temporarily call Qdelete_window instead of
975 Fdelete_window (Fbury_buffer will move to window.el soon).
976
977 * frame.c (set_menu_bar_lines_1): Remove code handling
978 orig_top_line and orig_total_lines.
979
980 * dispnew.c (adjust_frame_glyphs_initially): Don't use
981 set_window_height but set heights directly.
982 (change_frame_size_1): Use resize_frame_windows.
983
984 * xdisp.c (init_xdisp): Don't use set_window_height but set
985 heights directly.
986
987 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
988 resize_frame_windows instead of change_window_heights and run
989 run_window_configuration_change_hook.
990
991 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
992 instead of change_window_heights and run
993 run_window_configuration_change_hook.
994
1a13852e
MR
9952011-06-09 Martin Rudalics <rudalics@gmx.at>
996
997 * window.c (replace_window): Rename second argument REPLACEMENT to
998 NEW. New third argument SETFLAG. Rewrite.
999 (delete_window, make_dummy_parent): Call replace_window with
1000 third argument 1.
1001 (window_list_1): Move down in code.
1002 (run_window_configuration_change_hook): Move set_buffer part
1003 before select_frame_norecord part in order to unwind correctly.
1004 Rename count1 to count.
1005 (recombine_windows, delete_deletable_window, resize_root_window)
1006 (Fdelete_other_windows_internal)
1007 (Frun_window_configuration_change_hook, make_parent_window)
1008 (resize_window_check, resize_window_apply, Fresize_window_apply)
1009 (resize_frame_windows, Fsplit_window_internal)
1010 (Fdelete_window_internal, Fresize_mini_window_internal): New
1011 functions.
1012 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1013
f3d1777e
MR
10142011-06-08 Martin Rudalics <rudalics@gmx.at>
1015
496e208e
MR
1016 * window.h (window): Add some new members to window structure -
1017 normal_lines, normal_cols, new_total, new_normal, clone_number,
1018 splits, nest, prev_buffers, next_buffers.
1019 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1020 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1021
f3d1777e
MR
1022 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1023 Remove.
496e208e
MR
1024 (make_dummy_parent): Set new members of windows structure.
1025 (make_window): Move down in code. Handle new members of window
1026 structure.
1027 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1028 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1029 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1030 (Fset_window_prev_buffers, Fwindow_next_buffers)
1031 (Fset_window_next_buffers, Fset_window_clone_number): New
1032 functions.
1033 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1034 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1035 Doc-string fixes.
1036 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1037 Argument WINDOW can be now internal window too.
1038 (Fwindow_use_time): Move up in code.
1039 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1040 Rewrite doc-string.
1041 (Fset_window_configuration, saved_window)
1042 (Fcurrent_window_configuration, save_window_save): Handle new
1043 members of window structure.
b9e809c2
MR
1044 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1045 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1046 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1047 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1048 Qget_mru_window, Qresize_root_window,
1049 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1050 Qauto_buffer_name; staticpro them.
f3d1777e 1051
abde8f8c
MR
10522011-06-07 Martin Rudalics <rudalics@gmx.at>
1053
1054 * window.c (Fwindow_total_size, Fwindow_left_column)
1055 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1056 (Fwindow_list_1): New functions.
1057 (window_box_text_cols): Replace with window_body_cols.
1058 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1059 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1060 (delete_window, Fset_window_configuration): Call
1061 delete_all_subwindows with window as argument.
1062 (delete_all_subwindows): Take a window as argument and not a
1063 structure. Rewrite.
190b47e6
MR
1064 (window_loop): Remove handling of GET_LRU_WINDOW and
1065 GET_LARGEST_WINDOW.
1066 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1067
1068 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1069 window_box_text_cols. delete_all_subwindows now takes a
1070 Lisp_Object as argument.
abde8f8c
MR
1071
1072 * indent.c (compute_motion, Fcompute_motion): Use
1073 window_body_cols instead of window_box_text_cols.
1074
fa8a67e6
MR
1075 * frame.c (delete_frame): Call delete_all_subwindows with root
1076 window as argument.
1077
a54e3482
DC
10782011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1079
1080 * fns.c (Fputhash): Document return value.
1081
60002bf5
CY
10822011-06-06 Chong Yidong <cyd@stupidchicken.com>
1083
1084 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1085
0c671da6 10862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1087
b862a52a 1088 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1089
be44ca6c
PE
1090 Check for overflow when converting integer to cons and back.
1091 * charset.c (Fdefine_charset_internal, Fdecode_char):
1092 Use cons_to_unsigned to catch overflow.
1093 (Fencode_char): Use INTEGER_TO_CONS.
1094 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1095 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1096 * data.c (long_to_cons, cons_to_long): Remove.
1097 (cons_to_unsigned, cons_to_signed): New functions.
1098 These signal an error for invalid or out-of-range values.
1099 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1100 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1101 * font.c (Ffont_variation_glyphs):
1102 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1103 * lisp.h: Include <intprops.h>.
1104 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1105 (cons_to_signed, cons_to_unsigned): New decls.
1106 (long_to_cons, cons_to_long): Remove decls.
1107 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1108 (Fprimitive_undo): Use CONS_TO_INTEGER.
1109 * xfns.c (Fx_window_property): Likewise.
1110 * xselect.c: Include <limits.h>.
1111 (x_own_selection, selection_data_to_lisp_data):
1112 Use INTEGER_TO_CONS.
1113 (x_handle_selection_request, x_handle_selection_clear)
1114 (x_get_foreign_selection, Fx_disown_selection_internal)
1115 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1116 (lisp_data_to_selection_data): Use cons_to_unsigned.
1117 (x_fill_property_data): Use cons_to_signed.
1118 Report values out of range.
1119
d1f3d2af
PE
1120 Check for buffer and string overflow more precisely.
1121 * buffer.h (BUF_BYTES_MAX): New macro.
1122 * lisp.h (STRING_BYTES_MAX): New macro.
1123 * alloc.c (Fmake_string):
1124 * character.c (string_escape_byte8):
1125 * coding.c (coding_alloc_by_realloc):
1126 * doprnt.c (doprnt):
1127 * editfns.c (Fformat):
1128 * eval.c (verror):
1129 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1130 since they may not be the same number.
1131 * editfns.c (Finsert_char):
1132 * fileio.c (Finsert_file_contents):
1133 Likewise for BUF_BYTES_MAX.
1134
dd52fcea
PE
1135 * image.c: Use ptrdiff_t, not int, for sizes.
1136 (slurp_file): Switch from int to ptrdiff_t.
1137 All uses changed.
1138 (slurp_file): Check that file size fits in both size_t (for
1139 malloc) and ptrdiff_t (for sanity and safety).
1140
7f9bbdbb
PE
1141 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1142 if b->modtime has its maximal value.
1143
dfe18f82
PE
1144 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1145
84acfcf0
PE
1146 Don't assume time_t can fit into int.
1147 * buffer.h (struct buffer.modtime): Now time_t, not int.
1148 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1149 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1150
ccd9a01a
PE
1151 Minor fixes for signed vs unsigned integers.
1152 * character.h (MAYBE_UNIFY_CHAR):
1153 * charset.c (maybe_unify_char):
1154 * keyboard.c (read_char, reorder_modifiers):
1155 XINT -> XFASTINT, since the integer must be nonnegative.
1156 * ftfont.c (ftfont_spec_pattern):
1157 * keymap.c (access_keymap, silly_event_symbol_error):
1158 XUINT -> XFASTINT, since the integer must be nonnegative.
1159 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1160 since it makes no difference and we prefer signed.
1161 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1162 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1163 nonnegative.
1164
d6d100dd
SM
11652011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1166
1167 * window.h (Fwindow_frame): Declare.
1168
2b6148e4
PE
11692011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1172 (SPARE_MEMORY): Always define.
1173 (LARGE_REQUEST): Remove.
1174 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1175
f230ecc9
MR
11762011-06-06 Martin Rudalics <rudalics@gmx.at>
1177
727e958e
MR
1178 * lisp.h: Move EXFUNS for Fframe_root_window,
1179 Fframe_first_window and Fset_frame_selected_window to window.h.
1180
1181 * window.h: Move EXFUNS for Fframe_root_window,
1182 Fframe_first_window and Fset_frame_selected_window here from
1183 lisp.h.
1184
1185 * frame.c (Fwindow_frame, Fframe_first_window)
1186 (Fframe_root_window, Fframe_selected_window)
1187 (Fset_frame_selected_window): Move to window.c.
1188 (Factive_minibuffer_window): Move to minibuf.c.
1189 (Fother_visible_frames_p): New function.
1190
1191 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1192
f230ecc9
MR
1193 * window.c (decode_window, decode_any_window): Move up in code.
1194 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1195 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1196 (Fwindow_buffer): Move up and rewrite doc-string.
1197 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1198 (Fwindow_prev): New functions.
727e958e
MR
1199 (Fwindow_frame): Move here from frame.c. Accept any window as
1200 argument.
1201 (Fframe_root_window, Fframe_first_window)
1202 (Fframe_selected_window): Move here from frame.c. Accept frame
1203 or arbitrary window as argument. Update doc-strings.
1204 (Fminibuffer_window): Move up in code.
1205 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1206 (Fset_frame_selected_window): Move here from frame.c.
1207 Marginal rewrite.
727e958e
MR
1208 (Fselected_window, select_window, Fselect_window): Move up in
1209 code. Minor doc-string fixes.
f230ecc9 1210
4d09bcf6
PE
12112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1214 Do not assume that spare memory exists; that assumption is valid
1215 only if SYSTEM_MALLOC.
1216 (LARGE_REQUEST): New macro, so that the issue of large requests
1217 is separated from the issue of spare memory.
1218
810928a2
AS
12192011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1220
172418ad
AS
1221 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1222 format. (Bug#8806)
1223
43f862f7
AS
1224 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1225
810928a2
AS
1226 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1227 before statements.
1228
a059fe24
JD
12292011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1230
1231 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1232
1233 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1234
1235 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1236 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1237
989bf368
JB
12382011-06-05 Juanma Barranquero <lekktu@gmail.com>
1239
1240 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1241
4b80f674
CY
12422011-06-04 Chong Yidong <cyd@stupidchicken.com>
1243
1244 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1245 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1246 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1247 New error handlers.
4b80f674
CY
1248 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1249 Obey Vx_select_enable_clipboard_manager. Catch errors in
1250 x_clipboard_manager_save (Bug#8779).
1251 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1252 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1253
99a33b77 12542011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1255
1256 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1257
99a33b77 12582011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1259
1260 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1261 in the current matrix if keep_current_p is non-zero.
1262
8264569d
EZ
12632011-06-04 Eli Zaretskii <eliz@gnu.org>
1264
1265 * bidi.c (bidi_level_of_next_char): Fix last change.
1266
57f97249
EZ
12672011-06-03 Eli Zaretskii <eliz@gnu.org>
1268
fec2107c 1269 Support bidi reordering of text covered by display properties.
57f97249 1270
fec2107c
EZ
1271 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1272 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1273 (bidi_cache_search, bidi_cache_iterator_state)
1274 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1275 (bidi_level_of_next_char, bidi_move_to_visually_next):
1276 Support character positions inside a run of characters covered by a
fec2107c
EZ
1277 display string.
1278 (bidi_paragraph_init, bidi_resolve_explicit_1)
1279 (bidi_level_of_next_char): Call bidi_fetch_char and
1280 bidi_fetch_char_advance instead of FETCH_CHAR and
1281 FETCH_CHAR_ADVANCE.
1282 (bidi_init_it): Initialize new members.
1283 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1284 definitions.
1285 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1286 instead of using explicit *_CHAR codes.
d6d100dd
SM
1287 (bidi_resolve_explicit, bidi_resolve_weak):
1288 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1289 bidirectional text is supported only in multibyte buffers.
1290 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1291 it to initialize the frame_window_p member of struct bidi_it.
1292 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1293 (bidi_resolve_explicit, bidi_resolve_weak)
1294 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1295 bidi_it->nchars is non-positive.
1296 (bidi_level_of_next_char): Don't try to lookup the cache for the
1297 next/previous character if nothing is cached there yet, or if we
1298 were just reseat()'ed to a new position.
c40e2fb2 1299
0e14fe90
EZ
1300 * xdisp.c (set_cursor_from_row): Set start and stop points
1301 according to the row's direction when priming the loop that looks
1302 for the glyph on which to display cursor.
1303 (single_display_spec_intangible_p): Function deleted.
1304 (display_prop_intangible_p): Reimplement to call
1305 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1306 Accept 3 additional arguments needed by handle_display_spec.
1307 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1308 values: lists, `(when COND...)' forms, etc.
1309 (single_display_spec_string_p): Support property values that are
1310 lists with the argument STRING its top-level element.
1311 (display_prop_string_p): Fix the condition for processing a
1312 property that is a list to be consistent with handle_display_spec.
fec2107c 1313 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1314 last portion of handle_display_prop.
1315 (compute_display_string_pos): Accept additional argument
1316 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1317 value of a `display' property is a "replacing spec".
1318 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1319 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1320 the display property, but just return a value indicating whether
1321 the display property will replace the characters it covers.
1322 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1323 frame_window_p members of struct bidi_it.
d6d100dd
SM
1324 (compute_display_string_pos, compute_display_string_end):
1325 New functions.
fec2107c
EZ
1326 (push_it): Accept second argument POSITION, where pop_it should
1327 jump to continue iteration.
1328 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1329
fec2107c
EZ
1330 * keyboard.c (adjust_point_for_property): Adjust the call to
1331 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1332
1333 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1334 (bidi_init_it): Update prototypes.
1335 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1336 (compute_display_string_pos, compute_display_string_end):
1337 Declare prototypes.
fec2107c
EZ
1338 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1339 EMACS_INT.
fc6f18ce 1340
40087514 13412011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1342
57f53182
PE
1343 Malloc failure behavior now depends on size of allocation.
1344 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1345 * lisp.h: Change signatures accordingly.
1346 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1347 All callers changed. (Bug#8762)
1348
1349 * gnutls.c: Use Emacs's memory allocators.
1350 Without this change, the gnutls library would invoke malloc etc.
1351 directly, which causes problems on non-SYNC_INPUT hosts, and which
1352 runs afoul of improving memory_full behavior. (Bug#8761)
1353 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1354 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1355 xfree instead of the default malloc, realloc, free.
1356 (Fgnutls_boot): No need to check for memory allocation failure,
1357 since xmalloc does that for us.
1358
ac32cd99 1359 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1360 * category.c (hash_get_category_set):
1361 * ccl.c (ccl_driver):
1362 * charset.c (Fdefine_charset_internal):
1363 * charset.h (struct charset.hash_index):
1364 * composite.c (get_composition_id, gstring_lookup_cache)
1365 (composition_gstring_put_cache):
1366 * composite.h (struct composition.hash_index):
1367 * dispextern.h (struct image.hash):
1368 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1369 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1370 (hashfn_equal, hashfn_user_defined, make_hash_table)
1371 (maybe_resize_hash_table, hash_lookup, hash_put)
1372 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1373 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1374 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1375 * image.c (make_image, search_image_cache, lookup_image)
1376 (xpm_put_color_table_h):
1377 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1378 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1379 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1380 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1381 * alloc.c (allocate_vectorlike):
1382 Check for overflow in vector size calculations.
1383 * ccl.c (ccl_driver):
1384 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1385 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1386 need to be updated by these changes.
40087514
PE
1387 * fns.c (make_hash_table, maybe_resize_hash_table):
1388 Check for integer overflow with large hash tables.
0de4bb68
PE
1389 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1390 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1391 (SXHASH_REDUCE): New macro.
1392 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1393 Use it instead of discarding useful hash info with large hash values.
1394 (sxhash_float): New function.
1395 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1396 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1397 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1398 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1399 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1400 Adjust signatures to match updated version of code.
1401 (consing_since_gc): Now EMACS_INT, since a single hash table can
1402 use more than INT_MAX bytes.
1403
698d32e2
DN
14042011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1405
1406 Make it possible to build with GCC-4.6+ -O2 -flto.
1407
1408 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1409
fd6fa53f
SM
14102011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1411
1412 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1413 Call minibuffer-inactive-mode.
1414
864db017
JB
14152011-05-31 Juanma Barranquero <lekktu@gmail.com>
1416
1417 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1418 Update dependencies.
1419
2ad0baf4
DN
14202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1421
1422 * data.c (init_data): Remove code for UTS, this system is not
1423 supported anymore.
1424
4fcc2638
DN
14252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1426
1427 Don't force ./temacs to start in terminal mode.
1428
1429 * frame.c (make_initial_frame): Initialize faces in all cases, not
1430 only when CANNOT_DUMP is defined.
1431 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1432
c56e0fd5
DN
14332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1434
1435 * dispnew.c (add_window_display_history): Use const for the string
1436 pointer. Remove declaration, not needed.
1437
333d54da 14382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1439
55d4c1b2 1440 Use 'inline', not 'INLINE'.
333d54da 1441 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1442 * alloc.c, fontset.c (INLINE): Remove.
1443 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1444 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1445 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1446 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1447 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1448
738db178
DN
14492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1450
1451 Make it possible to run ./temacs.
1452
1453 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1454 syms_of_callproc does the same thing. Remove test for
1455 "initialized", do it in the caller.
1456 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1457
620c53a6
SM
14582011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1459
1460 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1461 (read_minibuf): Use get_minibuffer.
1462 (syms_of_minibuf): Use DEFSYM.
1463 (Qmetadata): New var.
1464 * data.c (Qbuffer): Don't make it static.
1465 (syms_of_data): Use DEFSYM.
1466
e003a292
PE
14672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1468
1469 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1470 (CCL_CODE_MIN): New macro.
1471
ed008a6d
PE
14722011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1473
3687c2ef
PE
1474 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1475
ed008a6d
PE
1476 * eval.c (Qdebug): Now static.
1477 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1478 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1479 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1480
d66c4c7c
CY
14812011-05-29 Chong Yidong <cyd@stupidchicken.com>
1482
1483 * image.c: Various fixes to ImageMagick code comments.
1484 (Fimagemagick_types): Doc fix.
1485
5fbc2025
PE
14862011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1487
0196f88a
PE
1488 Minor fixes prompted by GCC 4.6.0 warnings.
1489
1490 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1491
5fbc2025
PE
1492 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1493 (x_clipboard_manager_save_all): Move extern decl to ...
1494 * xterm.h: ... here, so that it can be checked for consistency.
1495
1dd3c2d9
CY
14962011-05-29 Chong Yidong <cyd@stupidchicken.com>
1497
1498 * xselect.c (x_clipboard_manager_save_frame)
1499 (x_clipboard_manager_save_all): New functions.
1500 (Fx_clipboard_manager_save): Lisp function deleted.
1501
1502 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1503 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1504
1505 * xterm.h: Update prototype.
1506
5ba6571d
WX
15072011-05-28 William Xu <william.xwl@gmail.com>
1508
1509 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1510 exiting (Bug#8239).
1511
3eaff834
JM
15122011-05-28 Jim Meyering <meyering@redhat.com>
1513
e1900994 1514 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1515 * fns.c (to_uchar): Define.
1516 (crypto_hash_function): Use it to convert some newly-signed
1517 variables to unsigned, to avoid sign-extension bugs. For example,
1518 without this change, (md5 "truc") would evaluate to
1519 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1520 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1521 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1522
0f6990a7
PE
15232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 Integer overflow fixes.
c8a9ca5a 1526
08686060
PE
1527 * dbusbind.c: Serial number integer overflow fixes.
1528 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1529 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1530 to hold a serial number that is too large for a fixnum.
1531 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1532 Check for serial numbers out of range. Decode any serial number
59568bf0 1533 that was so large that it became a float. (Bug#8722)
08686060 1534
2d1fc3c7
PE
1535 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1536 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1537 Use XFASTINT rather than XUINT when numbers are nonnegative.
1538 (xd_append_arg, Fdbus_method_return_internal):
1539 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1540 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1541 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1542 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1543 (Bug#8722)
2d1fc3c7 1544
c8a9ca5a
PE
1545 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1546
519e1d69
PE
1547 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1548
30569699
PE
1549 ccl: add integer overflow checks
1550 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1551 (IN_INT_RANGE): New macros.
1552 (ccl_driver): Use them to check for integer overflow when
1553 decoding a CCL program. Many of the new checks are whether XINT (x)
1554 fits in int; it doesn't always, on 64-bit hosts. The new version
1555 doesn't catch all possible integer overflows, but it's an
847044ea 1556 improvement. (Bug#8719)
30569699 1557
c11285dc
PE
1558 * alloc.c (make_event_array): Use XINT, not XUINT.
1559 There's no need for unsigned here.
1560
fdccd48e
PE
1561 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1562 This follows up to the 2011-05-06 change that substituted uintptr_t
1563 for EMACS_INT. This case wasn't caught back then.
1564
37910ab2
PE
1565 Rework Fformat to avoid integer overflow issues.
1566 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1567 now (part of C89). Include <verify.h>.
1568 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1569 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1570 (Fformat): Avoid the prepass trying to compute sizes; it was only
1571 approximate and thus did not catch overflow reliably. Instead, walk
1572 through the format just once, formatting and computing sizes as we go,
1573 checking for integer overflow at every step, and allocating a larger
1574 buffer as needed. Keep track separately whether the format is
1575 multibyte. Keep only the most-recently calculated precision, rather
1576 than them all. Record whether each argument has been converted to
1577 string. Use EMACS_INT, not int, for byte and char and arg counts.
1578 Support field widths and precisions larger than INT_MAX. Avoid
1579 sprintf's undefined behavior with conversion specifications such as %#d
1580 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1581 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1582 formatting out-of-range floating point numbers with int
1583 formats. (Bug#8668)
1584
2e6578fb
PE
1585 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1586
0ae6bdee
PE
1587 * data.c: Avoid integer truncation in expressions involving floats.
1588 * data.c: Include <intprops.h>.
1589 (arith_driver): When there's an integer overflow in an expression
1590 involving floating point, convert the integers to floating point
1591 so that the resulting value does not suffer from catastrophic
1592 integer truncation. For example, on a 64-bit host (* 4
1593 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1594 Do not rely on undefined behavior after integer overflow.
1595
de883a70
PE
1596 merge count_size_as_multibyte, parse_str_to_multibyte
1597 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1598 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1599 Check for integer overflow.
1600 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1601 since it's now a duplicate of the other. This is more of
1602 a character than a buffer op, so better that it's in character.c.
1603 * fns.c, print.c: Adjust to above changes.
1604
2ff916cb
PE
16052011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1606
1607 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1608
f1b54466
PE
16092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1610
fb1ac845
PE
1611 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1612 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1613 (x_clipboard_manager_save): Now static.
1614 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1615
f1b54466
PE
1616 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1617 (crypto_hash_function): Now static.
1618 Fix pointer signedness problems. Avoid unnecessary initializations.
1619
a9f737ee
CY
16202011-05-27 Chong Yidong <cyd@stupidchicken.com>
1621
1622 * termhooks.h (Vselection_alist): Make it terminal-local.
1623
1624 * terminal.c (create_terminal): Initialize it.
1625
1626 * xselect.c: Support for clipboard managers.
1627 (Vselection_alist): Move to termhooks.h as terminal-local var.
1628 (LOCAL_SELECTION): New macro.
1629 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1630 (symbol_to_x_atom): Remove gratuitous arg.
1631 (x_handle_selection_request, lisp_data_to_selection_data)
1632 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1633 (x_own_selection, x_get_local_selection, x_convert_selection):
1634 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1635 (some_frame_on_display): Delete unused function.
1636 (Fx_own_selection_internal, Fx_get_selection_internal)
1637 (Fx_disown_selection_internal, Fx_selection_owner_p)
1638 (Fx_selection_exists_p): New optional frame arg.
1639 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1640 (x_handle_selection_clear): Don't treat other terminals with the
1641 same keyboard specially. Use the terminal-local Vselection_alist.
1642 (x_clear_frame_selections): Use Frun_hook_with_args.
1643
1644 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1645
1646 * xterm.h: Add support for those atoms.
1647
e067f0c1
CY
16482011-05-26 Chong Yidong <cyd@stupidchicken.com>
1649
1650 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1651 (converted_selections, conversion_fail_tag): New global variables.
1652 (x_selection_request_lisp_error): Free the above.
1653 (x_get_local_selection): Remove unnecessary code.
1654 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1655 of converted selections stored in converted_selections.
1656 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1657 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1658 (x_convert_selection): New function.
1659 (x_handle_selection_event): Simplify.
1660 (x_get_foreign_selection): Don't ignore incoming requests while
1661 waiting for an answer; this will fail when we implement
1662 SAVE_TARGETS, and seems unnecessary anyway.
1663 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1664 (Vx_sent_selection_functions): Doc fix.
1665
0f4aebc0
LL
16662011-05-26 Leo Liu <sdl.web@gmail.com>
1667
1668 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1669
e61124cd
YM
16702011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1671
1672 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1673
1674 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1675 for fringe update if it has periodic bitmap.
1676 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1677 and fringe_bitmap_periodic_p.
1678
1679 * fringe.c (get_fringe_bitmap_data): New function.
1680 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1681 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1682 row. Mark glyph row for fringe update if periodicity changed.
1683
1684 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1685 for fringe update unless it has periodic bitmap.
1686
f16d9837
KH
16872011-05-25 Kenichi Handa <handa@m17n.org>
1688
1689 * xdisp.c (get_next_display_element): Set correct it->face_id for
1690 a static composition.
1691
e1b90ef6
LL
16922011-05-24 Leo Liu <sdl.web@gmail.com>
1693
1694 * deps.mk (fns.o):
1695 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1696
1697 * fns.c (crypto_hash_function, Fsha1): New function.
1698 (Fmd5): Use crypto_hash_function.
1699 (syms_of_fns): Add Ssha1.
1700
7400048f
PE
17012011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 * gnutls.c: Remove unused macros.
1704 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1705 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1706 Remove macros that are defined and never used.
1707 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1708
abb71cf4
CY
17092011-05-22 Chong Yidong <cyd@stupidchicken.com>
1710
1711 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1712 (Fx_get_selection_internal): Minor cleanup.
1713 (Fx_own_selection_internal): Rename arguments for consistency with
1714 select.el.
1715
6307db39
PE
17162011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1719
f3d4e0a4
CY
17202011-05-22 Chong Yidong <cyd@stupidchicken.com>
1721
1722 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1723
4d8ade89
YM
17242011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1725
1726 * dispnew.c (scrolling_window): Don't exclude the case that the
1727 last enabled row in the desired matrix touches the bottom boundary.
1728
32078c8d
GM
17292011-05-21 Glenn Morris <rgm@gnu.org>
1730
1731 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1732 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1733 and add some more files.
32078c8d 1734
7285dc67
EZ
17352011-05-20 Eli Zaretskii <eliz@gnu.org>
1736
1737 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1738 report_file_error introduced by the change from 2011-05-07.
1739
89d1bd22
PE
17402011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1741
1742 * systime.h (Time): Define only if emacs is defined.
1743 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1744 where the include path doesn't have X11/X.h by default. See
1745 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1746
e23640bb 17472011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1748
1749 * composite.c (find_automatic_composition): Fix previous change.
1750
b9704ad9
GM
17512011-05-20 Glenn Morris <rgm@gnu.org>
1752
1753 * lisp.mk: New file, split from Makefile.in.
1754 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1755 (shortlisp): Remove.
1756 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1757
4a720484
GM
17582011-05-19 Glenn Morris <rgm@gnu.org>
1759
1760 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1761 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1762 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1763 (lisp): Set the order to that of loadup.el.
1764 (shortlisp): Make it a copy of $lisp.
1765 (SOME_MACHINE_LISP): Remove.
1766 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1767 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1768
a28d4396
KH
17692011-05-18 Kenichi Handa <handa@m17n.org>
1770
1771 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1772 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1773 (find_automatic_composition): Mostly rewrite for efficiency.
1774
a2b1fa8e
JB
17752011-05-18 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * makefile.w32-in: Update dependencies.
1778
8e1f5610
CS
17792011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1780
1781 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1782 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1783
7025ee00 17842011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1785
cdfa6eab
PE
1786 Fix some integer overflow issues, such as string length overflow.
1787
06d6db33
PE
1788 * insdel.c (count_size_as_multibyte): Check for string overflow.
1789
2b4560a8
PE
1790 * character.c (lisp_string_width): Check for string overflow.
1791 Use EMACS_INT, not int, for string indexes and lengths; in
1792 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1793 the resulting string length overflows an EMACS_INT; instead,
1794 report a string overflow if no precision given. When checking for
1795 precision exhaustion, use a check that cannot possibly have
1796 integer overflow. (Bug#8675)
1797 * character.h (lisp_string_width): Adjust to new signature.
1798
cb93f9be
PE
1799 * alloc.c (string_overflow): New function.
1800 (Fmake_string): Use it. This doesn't change behavior, but saves
1801 a few bytes and will simplify future changes.
1802 * character.c (string_escape_byte8): Likewise.
1803 * lisp.h (string_overflow): New decl.
1804
1a1f3366
PE
1805 Fixups, following up to the user-interface timestamp change.
1806 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1807 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1808 * msdos.c (mouse_get_pos): Likewise.
1809 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1810 * w32gui.h (Time): Define by including "systime.h" rather than by
1811 declaring it ourselves. (Bug#8664)
1812
d4e3e4d3
PE
1813 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1814 * image.c (clear_image_cache): Likewise.
1815
f6a24d19
PE
1816 * term.c (term_mouse_position): Don't assume time_t wraparound.
1817
08dc5ae6
PE
1818 Be more systematic about user-interface timestamps.
1819 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1820 and sometimes 'EMACS_UINT', to represent these timestamps.
1821 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1822 This makes the code easier to follow, and makes it easier to catch
1823 integer overflow bugs such as Bug#8664.
1824 * frame.c (Fmouse_position, Fmouse_pixel_position):
1825 Use Time, not unsigned long, for user-interface timestamps.
1826 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1827 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1828 * keyboard.h (last_event_timestamp): Likewise.
1829 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1830 * menu.h (xmenu_show): Likewise.
1831 * term.c (term_mouse_position): Likewise.
1832 * termhooks.h (struct input_event.timestamp): Likewise.
1833 (struct terminal.mouse_position_hook): Likewise.
1834 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1835 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1836 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1837 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1838 what it was before.
1839 * menu.h, termhooks.h: Include "systime.h", for Time.
1840
8e55734a
PE
1841 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1842 Don't assume that the difference between two unsigned long values
1843 can fit into an integer. At this point, we know button_down_time
1844 <= event->timestamp, so the difference must be nonnegative, so
1845 there's no need to cast the result if double-click-time is
1846 nonnegative, as it should be; check that it's nonnegative, just in
1847 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1848 apart (about 25 days). (Bug#8664)
8e55734a 1849
841f1b75 1850 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1851 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1852
3e26f69c
PE
1853 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1854 that always fit in int. Use a sentinel instead of a counter, to
1855 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1856 * frame.h (struct frame): Use int for menu_bar_items_used
1857 instead of EMACS_INT, since it always fits in int.
3e26f69c 1858
5cc152c0
PE
1859 * menu.c (grow_menu_items): Check for int overflow.
1860
d89eb65e
PE
1861 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1862
5235bd3e
PE
1863 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1864 Before, the code was not consistent. These values cannot exceed
1865 2**31 - 1 so there's no need to make them unsigned.
1866 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1867 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1868 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1869 as modifiers.
1870 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1871
bc827e23
PE
1872 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1873 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1874 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1875 presumably because the widths might not match.
1876
78eb494e
PE
1877 * window.c (size_window): Avoid needless test at loop start.
1878
04f2d78b
CB
18792011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1880
1881 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1882
d2fc7e3d 18832011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1884
1885 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1886
d2fc7e3d 18872011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1888
1889 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1890 `width' to `bar_area_x' and `bar_area_width', respectively.
1891 (x_scroll_run): Take account of fringe background extension.
1892
04f2d78b
CB
1893 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1894 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1895 `bar_area_width', respectively.
1896 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1897 background extension.
1898
79b70037
GM
18992011-05-10 Jim Meyering <meyering@redhat.com>
1900
1901 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1902
2f142cc5
JB
19032011-05-10 Juanma Barranquero <lekktu@gmail.com>
1904
1905 * image.c (Finit_image_library): Return t for built-in image types,
1906 like pbm and xbm. (Bug#8640)
1907
57679c86
AS
19082011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1909
1910 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1911
888c9e86
EZ
19122011-05-07 Eli Zaretskii <eliz@gnu.org>
1913
b0512a1d
EZ
1914 * w32console.c (Fset_screen_color): Doc fix.
1915 (Fget_screen_color): New function.
1916 (syms_of_ntterm): Defsubr it.
1917
7285dc67
EZ
1918 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1919 unlink the temporary file if Fcall_process didn't create it in the
1920 first place.
1921 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1922 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1923 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1924 cue to call_process_cleanup not to close that handle.
1925
4d3fcc8e
BK
19262011-05-07 Ben Key <bkey76@gmail.com>
1927
1928 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1929 one of two shell specific rules, either bootstrap-temacs-CMD or
1930 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1931 to the previous implementation of the bootstrap-temacs rule.
1932 The bootstrap-temacs-CMD rule is similar to the previous
1933 implementation of the bootstrap-temacs rule except that it
1934 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1935 variable.
1936
1937 These changes, along with some changes to nt/configure.bat,
1938 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1939 earlier fix to add support for --cflags and --ldflags options
1940 that include quotes so that it works whether make uses cmd or
1941 sh as the shell.
1942
b4289b64
MA
19432011-05-06 Michael Albinus <michael.albinus@gmx.de>
1944
1945 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1946 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1947 is a constant.
1948 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1949 a string. Handle both cases.
1950 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1951 (Fdbus_register_method): Use Qinvalid_function.
1952
af4c0e28
JB
19532011-05-06 Juanma Barranquero <lekktu@gmail.com>
1954
1955 * makefile.w32-in: Update dependencies.
1956 (LISP_H): Add inttypes.h and stdin.h.
1957 (PROCESS_H): Add unistd.h.
1958
c51453d9
EZ
19592011-05-06 Eli Zaretskii <eliz@gnu.org>
1960
1961 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1962 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1963
8ff0ac3c 19642011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1965
4c4b566b
PE
1966 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1967
aab2b9b5
PE
1968 * term.c (vfatal): Remove stray call to va_end.
1969 It's not needed and the C Standard doesn't allow it here anyway.
1970
c378da0b
PE
1971 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1972 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1973
288b08c7
PE
1974 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1975 bytes.
1976
e3601888
PE
1977 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1978
db6c0e74
PE
1979 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1980
dd5963ea
PE
1981 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1982
88c9450f
PE
1983 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1984
2f9442b8
PE
1985 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1986
c032b5f8
PE
1987 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1988 * charset.c (Fdefine_charset_internal): Don't initialize
1989 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1990 32-bit int (Bug#8600).
a108c10b
PE
1991
1992 * lread.c (read_integer): Be more consistent with string-to-number.
1993 Use string_to_number to do the actual conversion; this avoids
1994 rounding errors and fixes some other screwups. Without this fix,
1995 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1996 (digit_to_number): Move earlier, for benefit of read_integer.
1997 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1998 not a digit in any supported base. (Bug#8602)
a108c10b 1999
ad5f9eea
PE
2000 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2001
aec1708a
PE
2002 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2003 to match comment at start of function. This also removes a
2004 GCC warning about overflow in a 32+64-bit port.
2005
47be4ab5
PE
2006 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2007
371cac43
PE
2008 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2009 Reported by Stefan Monnier in
2010 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2011 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2012 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2013
d01a7826
PE
2014 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2015 (EMACS_UINTPTR): Likewise, with uintptr_t.
2016
7fd47d5c
PE
2017 * lisp.h: Prefer 64-bit EMACS_INT if available.
2018 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2019 on 32-bit hosts that have 64-bit int, so that they can access
2020 large files.
122b0c86
PE
2021 However, temporarily disable this change unless the temporary
2022 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2023
8727937b
PE
2024 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2025
8ac068ac
PE
2026 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2027 This removes an assumption that EMACS_INT and long are the same
2028 width as pointers. The assumption is true for Emacs porting targets
2029 now, but we want to make other targets possible.
2030 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2031 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2032 In the rest of the code, change types of integers that hold casted
2033 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2034 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2035 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2036 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2037 No need to cast type when ORing.
2038 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2039 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2040 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2041 assume EMACS_INT is the same width as char *.
2042 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2043 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2044 Remove no-longer-needed casts.
2045 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2046 (xg_tool_bar_help_callback, xg_make_tool_item):
2047 Use EMACS_INTPTR to hold an integer
2048 that will be cast to void *; this can avoid a GCC warning
2049 if EMACS_INT is not the same width as void *.
2050 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2051 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2052 (current_message_1, set_message_1):
2053 Use a local to convert to proper width without a cast.
2054 * xmenu.c (dialog_selection_callback): Likewise.
2055
ede49d71
PE
2056 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2057 Also, don't assume VALBITS / RAND_BITS is less than 5,
2058 and don't rely on undefined behavior when shifting a 1 left into
2059 the sign bit.
2060 * lisp.h (get_random): Change signature to match.
2061
2f30ecd0
PE
2062 * lread.c (hash_string): Use size_t, not int, for hash computation.
2063 Normally we prefer signed values; but hashing is special, because
2064 it's better to use unsigned division on hash table sizes so that
2065 the remainder is nonnegative. Also, size_t is the natural width
2066 for hashing into memory. The previous code used 'int', which doesn't
2067 retain enough info to hash well into very large tables.
2068 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2069
2a866e7b
PE
2070 * dbusbind.c: Don't possibly lose pointer info when converting.
2071 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2072 Use XPNTR rather than XHASH, so that the high-order bits of
2073 the pointer aren't lost when converting through void *.
2074
51639eac
PE
2075 * eval.c (Fautoload): Don't double-shift a pointer.
2076
92394119
PE
2077 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2078
dbdb9a7c
JB
20792011-05-06 Juanma Barranquero <lekktu@gmail.com>
2080
2081 * gnutls.c (DEF_GNUTLS_FN):
2082 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2083
db7a0b4f
AS
20842011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2085
2086 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2087 marker. (Bug#8610)
2088
f7ff1b0f 20892011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2090
2091 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2092 New version that can reserve upto 2GB of heap space.
2093
f7ff1b0f 20942011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2095
2096 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2097
639c109b
TZ
20982011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2099
2100 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2101 `gnutls_certificate_set_x509_key_file'.
2102
d2127135
JB
21032011-05-05 Juanma Barranquero <lekktu@gmail.com>
2104
2105 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2106 Update dependencies.
2107
e968f4f3
JB
21082011-05-04 Juanma Barranquero <lekktu@gmail.com>
2109
2110 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2111 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2112 Remove unused parameter `fildes'.
2113 * process.c (read_process_output, send_process): Don't pass it.
2114
84d358f0
JB
21152011-05-04 Juanma Barranquero <lekktu@gmail.com>
2116
2117 Fix previous change: the library cache is defined in w32.c.
2118 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2119 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2120
0898ca10
JB
21212011-05-04 Juanma Barranquero <lekktu@gmail.com>
2122
2123 Implement dynamic loading of GnuTLS on Windows.
2124
2125 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2126 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2127 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2128 Declare.
2129
2130 * gnutls.c (Qgnutls_dll): Define.
2131 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2132 (gnutls_*): Declare function pointers.
2133 (init_gnutls_functions): New function to initialize function pointers.
2134 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2135 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2136 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2137 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2138 (emacs_gnutls_write, emacs_gnutls_read)
2139 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2140 (Fgnutls_available_p): New function.
2141 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2142 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2143 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2144
2145 * image.c: Include w32.h.
2146 (Vimage_type_cache): Delete.
2147 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2148 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2149 (w32_delayed_load): Move to w32.c.
2150
2151 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2152
2153 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2154 (w32_delayed_load): Move from image.c. When loading a library, record
2155 its filename in the :loaded-from property of the library id.
2156 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2157 Initialize and staticpro them.
2158 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2159
2160 * process.c: Include lisp.h before w32.h, not after.
2161 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2162 instead of gnutls_record_check_pending.
2163
2164 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2165
ff4de4aa
TZ
21662011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2167
2168 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2169 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2170 as passed in.
2171
abe95abb
JD
21722011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2173
2174 * xterm.c (x_set_frame_alpha): Do not set property on anything
2175 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2176
e16e55d4
JB
21772011-05-02 Juanma Barranquero <lekktu@gmail.com>
2178
2179 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2180
bafcf6a5
JB
21812011-05-02 Juanma Barranquero <lekktu@gmail.com>
2182
2183 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2184 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2185 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2186 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2187 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2188 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2189 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2190 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2191 (Qgnutls_bootprop_callbacks_verify): Make static.
2192
e7a6747f
AS
21932011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2194
19ed11ba
AS
2195 * callproc.c: Indentation fixup.
2196
e7a6747f 2197 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2198 (wait_for_termination, interruptible_wait_for_termination):
2199 Move after wait_for_termination_1.
e7a6747f 2200
1ef14cb4
LMI
22012011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2202
2203 * sysdep.c (interruptible_wait_for_termination): New function
2204 which is like wait_for_termination, but allows keyboard
2205 interruptions.
2206
2207 * callproc.c (Fcall_process): Add (:file "file") as an option for
2208 the STDOUT buffer.
2209 (Fcall_process_region): Ditto.
2210
330d880c
EZ
22112011-04-30 Eli Zaretskii <eliz@gnu.org>
2212
8db90b73
EZ
2213 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2214 rather than `XVECTOR (FOO)->size'.
2215
330d880c
EZ
2216 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2217 inttypes.h, as a gnulib replacement is used if it not available in
2218 system headers.
2219
15cbd324
EZ
22202011-04-21 Eli Zaretskii <eliz@gnu.org>
2221
2222 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2223 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2224 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2225
2226 * coding.c (coding_alloc_by_realloc): Error out if destination
2227 will grow beyond MOST_POSITIVE_FIXNUM.
2228 (decode_coding_emacs_mule): Abort if there isn't enough place in
2229 charbuf for the composition carryover bytes. Reserve an extra
2230 space for up to 2 characters produced in a loop.
2231 (decode_coding_iso_2022): Abort if there isn't enough place in
2232 charbuf for the composition carryover bytes.
2233
22342011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2235
ae940cca
EZ
2236 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2237 aborting when %lld or %lll format is passed.
2238 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2239 %llo or %llx format is passed. (Bug#8545)
2240
03ab8921
EZ
2241 * window.c (window_scroll_line_based): Use a marker instead of
2242 simple variables to record original value of point. (Bug#7952)
2243
afda1437
EZ
2244 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2245 produced by %s or %c overflows available buffer space. (Bug#8545)
2246
f76dee0c
PE
22472011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2250 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2251
fdc5744d
JB
22522011-04-28 Juanma Barranquero <lekktu@gmail.com>
2253
2254 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2255
638f053a
JB
22562011-04-28 Juanma Barranquero <lekktu@gmail.com>
2257
2258 * keyboard.c (Qdelayed_warnings_hook): Define.
2259 (command_loop_1): Run `delayed-warnings-hook'
2260 if Vdelayed_warnings_list is non-nil.
2261 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2262 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2263
d178f871
EZ
22642011-04-28 Eli Zaretskii <eliz@gnu.org>
2265
2266 * doprnt.c (doprnt): Don't return value smaller than the buffer
2267 size if the message was truncated. (Bug#8545).
2268
b124fd93
JB
22692011-04-28 Juanma Barranquero <lekktu@gmail.com>
2270
2271 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2272 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2273
e810457d
PE
22742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2277
ea51cceb
JB
22782011-04-27 Juanma Barranquero <lekktu@gmail.com>
2279
2280 * makefile.w32-in: Update dependencies.
2281
94dcfacf
EZ
22822011-04-27 Eli Zaretskii <eliz@gnu.org>
2283
2284 Improve `doprnt' and its usage. (Bug#8545)
2285 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2286 `format_end'. Remove support for %l as a conversion specifier.
2287 Don't use xrealloc. Improve diagnostics when the %l size modifier
2288 is used. Update the commentary.
2289
2290 * eval.c (verror): Simplify calculation of size_t.
2291
2292 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2293 messages.
2294
f61f41d7
PE
22952011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2296
2297 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2298 change.
2299
96fb4434
PE
23002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2301
2302 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2303 This makes this file independent of the recent pseudovector change.
2304
671875da 23052011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2306
69e9b5a3
PE
2307 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2308
b5f869a7 2309 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2310 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2311 Remove unused local.
c8926152 2312 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2313
841a1577 2314 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2315 GCC 4.6.0 optimizes based on type-based alias analysis.
2316 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2317 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2318 != &v->size, and therefore "v->size = 1; b->size = 2; return
2319 v->size;" must therefore return 1. This assumption is incorrect
2320 for Emacs, since it type-puns struct Lisp_Vector * with many other
2321 types. To fix this problem, this patch adds a new type struct
f904488f 2322 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2323 and pseudovectors, and helps optimizing compilers not get fooled
2324 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2325 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2326 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2327 the size member.
eab3844f
PE
2328 (XSETPVECTYPE): Rewrite in terms of new macro.
2329 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2330 This is a bit clearer, and further avoids the possibility of
2331 undesirable aliasing.
2332 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2333 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2334 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2335 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2336 (ASIZE): Now uses header.size rather than size.
2337 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2338 to avoid the hassle of writing XVECTOR (foo)->header.size.
2339 (struct vectorlike_header): New type.
eab3844f
PE
2340 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2341 object, to help avoid aliasing.
2342 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2343 (SUBRP): Likewise, since Lisp_Subr is a special case.
2344 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2345 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2346 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2347 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2348 changed to be "header.size" and "header.next".
2349 * buffer.h (struct buffer): Likewise.
2350 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2351 * frame.h (struct frame): Likewise.
2352 * process.h (struct Lisp_Process): Likewise.
2353 * termhooks.h (struct terminal): Likewise.
2354 * window.c (struct save_window_data, struct saved_window): Likewise.
2355 * window.h (struct window): Likewise.
2356 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2357 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2358 * buffer.c (init_buffer_once): Likewise.
2359 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2360 special case.
2361 * process.c (Fformat_network_address): Use local var for size,
2362 for brevity.
2363
0df1eac5
PE
2364 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2365
847ab9d1 2366 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2367 * data.c (atof): Remove decl; no longer used or needed.
2368 (digit_to_number): Move to lread.c.
2369 (Fstring_to_number): Use new string_to_number function, to be
2370 consistent with how the Lisp reader treats infinities and NaNs.
2371 Do not assume that floating-point numbers represent EMACS_INT
2372 without losing information; this is not true on most 64-bit hosts.
2373 Avoid double-rounding errors, by insisting on integers when
2374 parsing non-base-10 numbers, as the documentation specifies.
2375 * lisp.h (string_to_number): New decl, replacing ...
2376 (isfloat_string): Remove.
bc0a5c13 2377 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2378 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2379 appears to have been a coding error. Similarly, do not accept
2380 strings like +-1e0 as floating point numbers. Do not report
2381 overflow for integer overflows unless the base is not 10 which
2382 means we have no simple and reliable way to continue.
2383 Break out the floating-point parsing into a new
2384 function string_to_number, so that Fstring_to_number parses
2385 floating point numbers consistently with the Lisp reader.
04f2d78b 2386 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2387 (E_CHAR, EXP_INT): Remove, replacing with ...
2388 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2389 (string_to_number): New function, replacing isfloat_string.
2390 This function checks for valid syntax and produces the resulting
2391 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2392 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2393 so that overflow for non-base-10 numbers is reported only when
2394 there's no portable and simple way to convert to floating point.
452f4150 2395
67769ffc
PE
2396 * textprop.c (set_text_properties_1): Rewrite for clarity,
2397 and to avoid GCC warning about integer overflow.
2398
c20db43f
PE
2399 * intervals.h (struct interval): Use EMACS_INT for members
2400 where EMACS_UINT might cause problems. See
2401 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2402 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2403 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2404 All uses changed.
37aa2f85
PE
2405 (offset_intervals): Tell GCC not to worry about length overflow
2406 when negating a negative length.
c20db43f 2407
2538aa2f
PE
2408 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2409 (overrun_check_free): Likewise.
2410
f2d3008d
PE
2411 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2412 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2413 word size.
2414
ec8df744
PE
2415 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2416 (gnutls_make_error): Rename local to avoid shadowing.
2417 (gnutls_emacs_global_deinit): ifdef out; not used.
2418 (Fgnutls_boot): Use const for pointer to readonly storage.
2419 Comment out unused local. Fix pointer signedness problems.
2420
640ee02d
PE
2421 * lread.c (openp): Don't stuff size_t into an 'int'.
2422 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2423 about possible signed overflow.
2424
6048fb2a
PE
2425 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2426 (GDK_KEY_g): Don't define if already defined.
2427 (xg_prepare_tooltip): Avoid pointer signedness problem.
2428 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2429
fa3c87e1
PE
2430 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2431 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2432
2172544b
PE
2433 * xfns.c (Fx_window_property): Simplify a bit,
2434 to make a bit faster and to avoid GCC 4.6.0 warning.
2435 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2436
9b821a21
PE
2437 * fns.c (internal_equal): Don't assume size_t fits in int.
2438
3c616cfa
PE
2439 * alloc.c (compact_small_strings): Tighten assertion a little.
2440
c2982e87
PE
2441 Replace pEd with more-general pI, and fix some printf arg casts.
2442 * lisp.h (pI): New macro, generalizing old pEd macro to other
2443 conversion specifiers. For example, use "...%"pI"d..." rather
2444 than "...%"pEd"...".
2445 (pEd): Remove. All uses replaced with similar uses of pI.
2446 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2447 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2448 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2449 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2450 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2451 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2452 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2453 64-bit hosts.
2454 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2455 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2456 * print.c (safe_debug_print, print_object): Likewise.
2457 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2458 to int.
6f04d126
PE
2459 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2460 avoiding the 0 flag, which is not portable.
c2982e87
PE
2461 * process.c (Fmake_network_process): Use pI to avoid cast.
2462 * region-cache.c (pp_cache): Likewise.
2463 * xdisp.c (decode_mode_spec): Likewise.
2464 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2465 behavior on 64-bit hosts with printf arg.
6f04d126 2466 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2467 (x_stop_queuing_selection_requests): Likewise.
2468 (x_get_window_property): Don't truncate byte count to an 'int'
2469 when tracing.
0b432f21 2470
5e073ec7
PE
2471 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2472 here, since it parses constructs like leading '-' and spaces,
2473 which are not wanted; and it overflows with large numbers.
2474 Instead, simply match F[0-9]+, which is what is wanted anyway.
2475
36372bf9
PE
2476 * alloc.c: Remove unportable assumptions about struct layout.
2477 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2478 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2479 (allocate_vectorlike, make_pure_vector): Use the new macros,
2480 plus offsetof, to remove unportable assumptions about struct layout.
2481 These assumptions hold on all porting targets that I know of, but
2482 they are not guaranteed, they're easy to remove, and removing them
2483 makes further changes easier.
2484
0b432f21
PE
2485 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2486 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2487 (string_overrun_cookie): Now const. Use initializers that
2488 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2489 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2490 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2491 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2492 multiple of sizeof (EMACS_INT); it need not be, if
2493 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2494 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2495
895009e1
JB
24962011-04-26 Juanma Barranquero <lekktu@gmail.com>
2497
2498 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2499
6a7a1b0b
TZ
25002011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2501
2502 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2503 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2504 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2505
841a1577 25062011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2507
2508 * lisp.h (Qdebug): List symbol.
895009e1 2509 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2510 * keyboard.c (debug-on-event): New variable.
2511 (handle_user_signal): Break into debugger when debug-on-event
2512 matches the current signal symbol.
2513
f2d3ba6f
DN
25142011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2515
2516 * alloc.c (check_sblock, check_string_bytes)
2517 (check_string_free_list): Convert to standard C.
2518
42ce4c63
TZ
25192011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2520
2521 * w32.c (emacs_gnutls_push): Fix typo.
2522
825cd63c
EZ
25232011-04-25 Eli Zaretskii <eliz@gnu.org>
2524
fb11d64d
EZ
2525 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2526 "cast to pointer from integer of different size".
2527
825cd63c
EZ
2528 Improve doprnt and its use in verror. (Bug#8545)
2529 * doprnt.c (doprnt): Document the set of format control sequences
2530 supported by the function. Use SAFE_ALLOCA instead of always
2531 using `alloca'.
2532
2533 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2534 is one byte too soon. Don't use xrealloc; instead xfree and
2535 xmalloc anew.
2536
e061a11b
TZ
25372011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2538
2539 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2540 callbacks stage.
2541
2542 * gnutls.c: Renamed global_initialized to
2543 gnutls_global_initialized. Added internals for the
2544 :verify-hostname-error, :verify-error, and :verify-flags
2545 parameters of `gnutls-boot' and documented those parameters in the
2546 docstring. Start callback support.
2547 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2548 unless a fatal error occured. Call gnutls_alert_send_appropriate
2549 on error. Return error code.
2550 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2551 (emacs_gnutls_read): Likewise.
2552 (Fgnutls_boot): Return handshake error code.
2553 (emacs_gnutls_handle_error): New function.
2554 (wsaerror_to_errno): Likewise.
2555
2556 * w32.h (emacs_gnutls_pull): Add prototype.
2557 (emacs_gnutls_push): Likewise.
2558
2559 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2560 (emacs_gnutls_push): Likewise.
2561
25622011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2563
2564 * process.c (wait_reading_process_output): Check if GnuTLS
2565 buffered some data internally if no FDs are set for TLS
2566 connections.
2567
2568 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2569 (LIBS): Link to USER_LIBS.
2570 ($(BLD)/gnutls.$(0)): New target.
2571
fa6996bc
EZ
25722011-04-24 Eli Zaretskii <eliz@gnu.org>
2573
eb35682e
EZ
2574 * xdisp.c (handle_single_display_spec): Rename the
2575 display_replaced_before_p argument into display_replaced_p, to
2576 make it consistent with the commentary. Fix typos in the
2577 commentary.
2578
e2ad650c
EZ
2579 * textprop.c (syms_of_textprop): Remove dead code.
2580 (copy_text_properties): Delete obsolete commentary about an
2581 interface that was deleted long ago. Fix typos in the description
2582 of arguments.
2583
1b2de274
EZ
2584 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2585 to changes in oldXMenu/XMenu.h from 2011-04-16.
2586 <menu_help_message, prev_menu_help_message>: Constify.
2587 (IT_menu_make_room): menu->help_text is now `const char **';
2588 adjust.
2589
2590 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2591 to changes in oldXMenu/XMenu.h from 2011-04-16.
2592 (struct XMenu): Declare `help_text' `const char **'.
2593
2594 * xfaces.c <Qunspecified>: Make extern again.
2595
2596 * syntax.c: Include sys/types.h before including regex.h, as
2597 required by Posix.
2598
762b15be
EZ
2599 * doc.c (get_doc_string): Improve the format passed to `error'.
2600
2601 * doprnt.c (doprnt): Improve commentary.
2602
2603 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2604
2605 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2606 them with etags.
2607
f1052e5d
EZ
2608 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2609 changes in globals.h immediately force recompilation.
762b15be
EZ
2610 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2611 $(CURDIR)/s/ms-w32.h.
2612 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2613
fa6996bc
EZ
2614 * character.c (Fchar_direction): Function deleted.
2615 (syms_of_character): Don't defsubr it.
2616 <char-direction-table>: Deleted.
2617
e6c3da20
EZ
26182011-04-23 Eli Zaretskii <eliz@gnu.org>
2619
2620 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2621 * doprnt.c: Include limits.h.
2622 (SIZE_MAX): New macro.
04f2d78b
CB
2623 (doprnt): Return a size_t value. 2nd arg is now size_t.
2624 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2625 Improve overflow protection. Support `l' modifier for integer
2626 conversions. Support %l conversion. Don't assume an EMACS_INT
2627 argument for integer conversions and for %c.
2628
2629 * lisp.h (doprnt): Restore prototype.
2630
2631 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2632 $(SRC)/character.h.
2633
2634 * Makefile.in (base_obj): Add back doprnt.o.
2635
2636 * deps.mk (doprnt.o): Add back prerequisites.
2637 (callint.o): Depend on character.h.
2638
2639 * eval.c (internal_lisp_condition_case): Include the handler
2640 representation in the error message.
2641 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2642 when breaking from the loop.
2643
2644 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2645
2646 * callint.c (Fcall_interactively): When displaying error message
2647 about invalid control letter, pass the character's codepoint, not
2648 a pointer to its multibyte form. Improve display of the character
2649 in octal and display also its hex code.
2650
2651 * character.c (char_string): Use %x to display the (unsigned)
2652 codepoint of an invalid character, to avoid displaying a bogus
2653 negative value.
2654
2655 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2656 `error', not SYMBOL_NAME itself.
2657
2658 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2659 character arguments to `error'.
2660
2661 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2662 to `error' in error message about FINAL_CHAR argument. Make sure
2663 FINAL_CHAR is a character, and use %c when it is passed as
2664 argument to `error'.
2665
4ffd0d6b 26662011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2667
2668 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2669
2670 * w32.c: Include <time.h>.
2671 (sys_localtime): New function.
2672
4ffd0d6b 26732011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2674
2675 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2676
4ffd0d6b 2677 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2678
4ffd0d6b 26792011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2680
4ffd0d6b
GM
2681 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2682 zombies (Bug#8467).
aac0c6e3 2683
04c56954
EZ
26842011-04-19 Eli Zaretskii <eliz@gnu.org>
2685
2686 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2687 gl_state.e_property when gl_state.object is Qt.
2688
2689 * insdel.c (make_gap_larger): Remove limitation of buffer size
2690 to <= INT_MAX.
2691
16a43933
CY
26922011-04-18 Chong Yidong <cyd@stupidchicken.com>
2693
2694 * xdisp.c (lookup_glyphless_char_display)
2695 (produce_glyphless_glyph): Handle cons cell entry in
2696 glyphless-char-display.
2697 (Vglyphless_char_display): Document it.
2698
2699 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2700 glyphless-char-display.
2701
4581706e
CY
27022011-04-17 Chong Yidong <cyd@stupidchicken.com>
2703
2704 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2705
2706 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2707
2708 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2709 definition for no-X builds.
2710
4887c6e2 27112011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2712
fd35b6f9
PE
2713 Static checks with GCC 4.6.0 and non-default toolkits.
2714
5c1ccb01
PE
2715 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2716
006c5daa
PE
2717 * process.c (keyboard_bit_set): Define only if SIGIO.
2718 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2719 (send_process): Repair possible setjmp clobbering.
2720
efc736d3
PE
2721 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2722
4e2fe2e6
PE
2723 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2724
f97334a2
PE
2725 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2726
4e75f29d
PE
2727 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2728 Define only if needed.
2729
90efadd1
PE
2730 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2731 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2732 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2733
3c647824
PE
2734 * dispextern.h (struct redisplay_interface): Rename param
2735 to avoid shadowing.
e264f262 2736 * termhooks.h (struct terminal): Likewise.
761383f4 2737 * xterm.c (xembed_send_message): Likewise.
3c647824 2738
b58c5c4a
PE
2739 * insdel.c (make_gap_smaller): Define only if
2740 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2741
cad59032
PE
2742 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2743 it.
2744
c339dc2e
PE
2745 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2746 so that we aren't warned about unused symbols.
2747
91a3e27b
PE
2748 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2749
399c71d3 2750 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2751
8ffc96f5
PE
2752 * xfns.c (x_real_positions): Mark locals as initialized.
2753
eef9bc79
PE
2754 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2755
098db9dd
PE
2756 * xterm.c: Fix problems found by static analysis with other toolkits.
2757 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2758 (x_dispatch_event): Declare static if USE_GTK, and
2759 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2760 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2761 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2762 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2763 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2764
eb18f6cc
PE
2765 * xmenu.c (menu_help_callback): Pointer type fixes.
2766 Use const pointers when pointing at readonly data. Avoid pointer
2767 signedness clashes.
2768 (FALSE): Remove unused macro.
2769 (update_frame_menubar): Remove unused decl.
2770
1fe72bf8
PE
2771 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2772
60d9e1db
PE
2773 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2774 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2775 (single_menu_item): Rename local to avoid shadowing.
2776
39261c26
PE
2777 * keyboard.c (make_lispy_event): Remove unused local var.
2778
018c5e19
PE
2779 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2780 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2781
63d2b86e
PE
2782 * bitmaps: Change bitmaps from unsigned char back to the X11
2783 compatible char. Avoid the old compiler warnings about
2784 out-of-range initializers by using, for example, '\xab' rather
2785 than 0xab.
2786
aefd87e1
PE
2787 * xgselect.c (xgselect_initialize): Check vs interface
2788 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2789
bf501fb9
PE
2790 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2791
e9829fdf
PE
2792 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2793 to read-only memory.
2794
1086c095
PE
2795 * fns.c (vector): Remove; this old hack is no longer needed.
2796
2baccd04 2797 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2798 Remove unused var.
dde42981 2799 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2800
72391843 2801 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2802
436c16df 2803 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2804 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2805 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2806
92bb796d 2807 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2808 (x_term_init): Remove local to avoid shadowing.
92bb796d 2809
764430a3 2810 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2811
2812 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2813 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2814
d1dfb56c
EZ
28152011-04-16 Eli Zaretskii <eliz@gnu.org>
2816
c4354cb4
EZ
2817 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2818
d1dfb56c
EZ
2819 Fix regex.c, syntax.c and friends for buffers > 2GB.
2820 * syntax.h (struct gl_state_s): Declare character position members
2821 EMACS_INT.
2822
2823 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2824
04f2d78b
CB
2825 * textprop.c (verify_interval_modification, interval_of):
2826 Declare arguments EMACS_INT.
d1dfb56c
EZ
2827
2828 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2829 EMACS_INT.
2830
2831 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2832
2833 * indent.c (Fvertical_motion): Local variable it_start is now
2834 EMACS_INT.
2835
2836 * regex.c (re_match, re_match_2, re_match_2_internal)
2837 (bcmp_translate, regcomp, regexec, print_double_string)
2838 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2839 (re_compile_pattern, re_exec): Declare arguments and local
2840 variables `size_t' and `ssize_t' and return values `regoff_t', as
2841 appropriate.
2842 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2843 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2844 <compile_stack_type>: `size' and `avail' are now `size_t'.
2845
2846 * regex.h <regoff_t>: Use ssize_t, not int.
2847 (re_search, re_search_2, re_match, re_match_2): Arguments that
2848 specify buffer/string position and length are now ssize_t and
2849 size_t. Return type is regoff_t.
2850
613052cd
BK
28512011-04-16 Ben Key <bkey76@gmail.com>
2852
2853 * nsfont.m: Fixed bugs in ns_get_family and
2854 ns_descriptor_to_entity that were caused by using free to
2855 deallocate memory blocks that were allocated by xmalloc (via
2856 xstrdup). This caused Emacs to crash when compiled with
2857 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2858 --enable-checking=xmallocoverrun). xfree is now used to
2859 deallocate these memory blocks.
2860
4170f62f 28612011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2862
71b41406
PE
2863 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2864
9587a89d
PE
2865 emacs_write: Accept and return EMACS_INT for sizes.
2866 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2867 et seq.
2868 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2869 Accept and return EMACS_INT.
2870 (emacs_gnutls_write): Return the number of bytes written on
2871 partial writes.
2872 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2873 (emacs_read, emacs_write): Remove check for negative size, as the
2874 Emacs source code has been audited now.
9587a89d
PE
2875 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2876 (emacs_read, emacs_write): Use it.
273a5f82
PE
2877 * process.c (send_process): Adjust to the new signatures of
2878 emacs_write and emacs_gnutls_write. Do not attempt to store
2879 a byte offset into an 'int'; it might overflow.
9587a89d 2880 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2881
3e047f51
PE
2882 * sound.c: Don't assume sizes fit in 'int'.
2883 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2884 Return EMACS_INT, not int.
3e047f51 2885 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2886 Accept EMACS_INT, not int.
2887 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2888 record read return values.
2889
cc39a9db
BK
28902011-04-15 Ben Key <bkey76@gmail.com>
2891
c9d0ec6d
JB
2892 * keyboard.c (Qundefined): Don't declare static since it is used
2893 in nsfns.m.
2894 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2895 static since they are used in nsfont.m.
cc39a9db 2896
6c60eb9f
SM
28972011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2898
2899 * process.c (Qprocessp): Don't declare static.
2900 * lisp.h (Qprocessp): Declare again.
2901
7990b61a
JB
29022011-04-15 Juanma Barranquero <lekktu@gmail.com>
2903
2904 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2905
5d4cb038
PE
29062011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2907
8bd7b830 2908 Improve C-level modularity by making more things 'static'.
cd64ea1d 2909
e3b27b31
PE
2910 Don't publish debugger-only interfaces to other modules.
2911 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2912 (verify_bytepos, count_markers): Move decls to the only modules
2913 that need them.
2914 * region-cache.h (pp_cache): Likewise.
2915 * window.h (check_all_windows): Likewise.
2916 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2917
5d4cb038
PE
2918 * sysdep.c (croak): Now static, if
2919 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2920 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2921
2922 * alloc.c (refill_memory_reserve): Now static if
2923 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2924 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2925
e87b6180
PE
2926 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2927 Define only if USE_LUCID.
2928
ac64929e
PE
2929 * xrdb.c (x_customization_string, x_rm_string): Now static.
2930
6f37259d
PE
2931 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2932 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2933
1683e3ab
PE
2934 * xdisp.c (draw_row_with_mouse_face): Now static.
2935 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2936
de9c2632
PE
2937 * window.h (check_all_windows): Mark externally visible.
2938
2b96acb7
PE
2939 * window.c (window_deletion_count): Now static.
2940
2941 * undo.c: Make symbols static if they're not exported.
2942 (last_undo_buffer, last_boundary_position, pending_boundary):
2943 Now static.
2944
50436f33
PE
2945 * textprop.c (interval_insert_behind_hooks): Now static.
2946 (interval_insert_in_front_hooks): Likewise.
2947
64520e5c
PE
2948 * term.c: Make symbols static if they're not exported.
2949 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2950 (max_frame_lines, tty_set_terminal_modes):
2951 (tty_reset_terminal_modes, tty_turn_off_highlight):
2952 (get_tty_terminal): Now static.
2953 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2954 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2955 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2956 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2957 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2958
1fa53021
PE
2959 * sysdep.c: Make symbols static if they're not exported.
2960 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2961 Now static.
2962 (sigprocmask_set, full_mask): Remove; unused.
2963 (wait_debugging): Mark as visible.
2964 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2965 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2966
d4b43b22
PE
2967 * syntax.c (syntax_temp): Define only if !__GNUC__.
2968
b7c513d0
PE
2969 * sound.c (current_sound_device, current_sound): Now static.
2970
989b29ad
PE
2971 * search.c (searchbufs, searchbuf_head): Now static.
2972
13a55a78
PE
2973 * scroll.c (scroll_cost): Remove; unused.
2974 * dispextern.h (scroll_cost): Remove decl.
2975
de68a1fc
PE
2976 * region-cache.h (pp_cache): Mark as externally visible.
2977
40ccffa6
PE
2978 * process.c: Make symbols static if they're not exported.
2979 (process_tick, update_tick, create_process, chan_process):
2980 (Vprocess_alist, proc_buffered_char, datagram_access):
2981 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2982 (deactivate_process): Mark defn as static, as well as decl.
2983 * lisp.h (create_process): Remove decl.
2984 * process.h (chan_process, Vprocess_alist): Remove decls.
2985
ad64fc97
PE
2986 * print.c: Make symbols static if they're not exported.
2987 (print_depth, new_backquote_output, being_printed, print_buffer):
2988 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2989 (print_interval, print_number_index, initial_stderr_stream):
2990 Now static.
2991 * lisp.h (Fprinc): Remove decl.
2992 (debug_output_compilation_hack): Mark as externally visible.
2993
adddb265
PE
2994 * sysdep.c (croak): Move decl from here to syssignal.h.
2995 * syssignal.h (croak): Put it here, so the API can be checked when
2996 'croak' is called from dissociate_if_controlling_tty.
2997
1717ede2
PE
2998 * minibuf.c: Make symbols static if they're not exported.
2999 (minibuf_save_list, choose_minibuf_frame): Now static.
3000 * lisp.h (choose_minibuf_frame): Remove decl.
3001
fa5fb2bc
PE
3002 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3003
1e3890d1
PE
3004 * lread.c: Make symbols static if they're not exported.
3005 (read_objects, initial_obarray, oblookup_last_bucket_number):
3006 Now static.
3007 (make_symbol): Remove; unused.
3008 * lisp.h (initial_obarray, make_symbol): Remove decls.
3009
8a1414fa
PE
3010 * keyboard.c: Make symbols static if they're not exported.
3011 (single_kboard, recent_keys_index, total_keys, recent_keys):
3012 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3013 (this_single_command_key_start, echoing, last_auto_save):
3014 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3015 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3016 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3017 (Vlispy_mouse_stem, double_click_count):
3018 Now static.
3019 (force_auto_save_soon): Define only if SIGDANGER.
3020 (ignore_mouse_drag_p): Now static if
3021 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3022 (print_help): Remove; unused.
3023 (stop_character, last_timer_event): Mark as externally visible.
3024 * keyboard.h (ignore_mouse_drag_p): Declare only if
3025 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3026 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3027 * lisp.h (echoing): Remove decl.
3028 (force_auto_save_soon): Declare only if SIGDANGER.
3029 * xdisp.c (redisplay_window): Simplify code, to make it more
3030 obvious that ignore_mouse_drag_p is not accessed if !defined
3031 USE_GTK && !defined HAVE_NS.
3032
93ea6e8f
PE
3033 * intervals.c: Make symbols static if they're not exported.
3034 (merge_properties_sticky, merge_interval_right, delete_interval):
3035 Now static.
3036 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3037
77382fcc
PE
3038 * insdel.c: Make symbols static if they're not exported.
3039 However, leave prepare_to_modify_buffer alone. It's never
3040 called from outside this function, but that appears to be a bug.
3041 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3042 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3043 (adjust_after_replace_noundo): Remove; unused.
3044 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3045 (signal_before_change): Remove decls.
77382fcc 3046
9306c32e
PE
3047 * indent.c (val_compute_motion, val_vmotion): Now static.
3048
cd44d2eb
PE
3049 * image.c: Make symbols static if they're not exported.
3050 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3051 if USE_GTK.
3052 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3053 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3054
ad9a7a06
PE
3055 * fringe.c (standard_bitmaps): Now static.
3056 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3057
81626931
PE
3058 * frame.c: Make symbols static if they're not exported.
3059 (x_report_frame_params, make_terminal_frame): Now static.
3060 (get_frame_param): Now static, unless HAVE_NS.
3061 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3062 (x_get_resource_string): Remove; not used.
3063 * frame.h (make_terminal_frame, x_report_frame_params):
3064 (x_get_resource_string); Remove decls.
3065 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3066 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3067
239f9db9
PE
3068 * font.c, fontset.c: Make symbols static if they're not exported.
3069 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3070 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3071 * font.c (font_close_object): Now static.
3072 * font.h (font_close_object): Remove.
3073 * fontset.c (FONTSET_OBJLIST): Remove.
3074 (free_realized_fontset) #if-0 the body, which does nothing.
3075 (face_suitable_for_char_p): #if-0, as it's never called.
3076 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3077 * xfaces.c (face_at_string_position):
3078 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3079 since 0 is always ASCII.
3080
dfcf3579
PE
3081 * fns.c (weak_hash_tables): Now static.
3082
5045092b
PE
3083 * fileio.c: Make symbols static if they're not exported.
3084 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3085 (Vwrite_region_annotation_buffers): Now static.
3086
57a96f5c
PE
3087 * eval.c: Make symbols static if they're not exported.
3088 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3089 * lisp.h (backtrace_list): Remove decl.
3090
35f08c38
PE
3091 * emacs.c: Make symbols static if they're not exported.
3092 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3093 (fatal_error_code, fatal_error_signal_hook, standard_args):
3094 Now static.
3095 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3096 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3097 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3098 * lisp.h (fatal_error_signal_hook): Remove decl.
3099 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3100
f44bd759
PE
3101 * editfns.c: Move a (normally-unused) function to its only use.
3102 * editfns.c, lisp.h (get_operating_system_release): Remove.
3103 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3104 worth the hassle of breaking this out.
3105
b532497d
PE
3106 * xterm.c: Make symbols static if they're not exported.
3107 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3108 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3109 (x_destroy_window, x_delete_display):
3110 Now static.
3111 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3112 (x_mouse_leave): Remove; unused.
3113 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3114 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3115 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3116 Remove decls.
3117 (x_mouse_leave): Declare only if WINDOWSNT.
3118 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3119 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3120 USE_X_TOOLKIT.
3121
1675728f
PE
3122 * ftxfont.c: Make symbols static if they're not exported.
3123 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3124 HAVE_FREETYPE.
3125 * font.h (ftxfont_driver): Likewise.
3126
e4cebfca
PE
3127 * xfns.c: Make symbols static if they're not exported.
3128 (x_last_font_name, x_display_info_for_name):
3129 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3130 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3131 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3132 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3133 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3134 (last_show_tip_args): Now static.
3135 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3136 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3137 (x_screen_planes): Remove; unused.
3138 * dispextern.h (x_screen_planes): Remove decl.
3139
5bf46f05
PE
3140 * dispnew.c: Make symbols static if they're not exported.
3141 * dispextern.h (redraw_garbaged_frames, scrolling):
3142 (increment_row_positions): Remove.
3143 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3144 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3145 Now static.
3146 (redraw_garbaged_frames): Remove; unused.
3147
435f4c28
PE
3148 * xfaces.c: Make symbols static if they're not exported.
3149 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3150 Remove decls.
3151 * xterm.h (defined_color): Remove decls.
3152 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3153 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3154 (menu_face_changed_default, defined_color, free_realized_face):
3155 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3156 (ascii_face_of_lisp_face): Remove; unused.
3157
8524aef3
PE
3158 * xdisp.c: Make symbols static if they're not exported.
3159 * dispextern.h (scratch_glyph_row, window_box_edges):
3160 (glyph_to_pixel_coords, set_cursor_from_row):
3161 (get_next_display_element, set_iterator_to_next):
3162 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3163 (show_mouse_face): Remove decls
3164 * frame.h (message_buf_print): Likewise.
3165 * lisp.h (pop_message, set_message, check_point_in_composition):
3166 Likewise.
3167 * xterm.h (set_vertical_scroll_bar): Likewise.
3168 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3169 (message_buf_print, scratch_glyph_row, displayed_buffer):
3170 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3171 (get_next_display_element, show_mouse_face, window_box_edges):
3172 (frame_to_window_pixel_xy, check_point_in_composition):
3173 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3174 (glyph_to_pixel_coords): Remove; unused.
3175
16390cd2
PE
3176 * dired.c (file_name_completion): Now static.
3177
3178 * dbusbind.c (xd_in_read_queued_messages): Now static.
3179
a25f4dfa
PE
3180 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3181 * data.c (circular_list_error): Remove.
3182
14a9c8df
PE
3183 * commands.h (last_point_position, last_point_position_buffer):
3184 (last_point_position_window): Remove decls.
3185 * keyboard.c: Make these variables static.
3186
04f2d78b
CB
3187 * coding.h (coding, code_convert_region, encode_coding_gap):
3188 Remove decls.
74ab6df5
PE
3189 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3190 (iso_code_class, detect_coding, code_convert_region): Now static.
3191 (encode_coding_gap): Remove; unused.
3192
38dfbee1
PE
3193 * chartab.c (chartab_chars, chartab_bits): Now static.
3194
a2cb4e63
PE
3195 * charset.h (charset_iso_8859_1): Remove decl.
3196 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3197 Now static.
3198
127198fd
PE
3199 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3200 * ccl.c (Vccl_program_table): Now static.
3201 (check_ccl_update): Remove; unused.
3202
d85b608f
PE
3203 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3204 * category.h: ... from here.
3205 * category.c (check_category_table, set_category_set): Now static.
3206
31cd66f3
PE
3207 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3208 * lisp.h: Remove these decls.
3209
c358e587
PE
3210 * buffer.c (buffer_count): Remove unused var.
3211
e78aecca
PE
3212 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3213 so that it's not optimized away.
3214 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3215 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3216 exported only to the debugger.
3217
e192d7d3 3218 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3219 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3220
92470028
PE
3221 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3222 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3223 was inaccessible from Lisp.
3224 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3225 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3226
244ed907
PE
3227 alloc.c: Import and export fewer symbols, and remove unused items.
3228 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3229 is defined.
3230 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3231 it's not optimized away by whole-program optimization.
3232 (message_enable_multibyte, free_misc): Remove.
3233 (catchlist, handlerlist, mark_backtrace):
3234 Declare only if BYTE_MARK_STACK.
3235 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3236 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3237 (message_enable_multibyte): Remove decl.
3238 (free_misc, interval_free_list, float_block, float_block_index):
3239 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3240 (cons_free_list, last_marked_index):
3241 Now static.
3242 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3243 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3244 (mark_backtrace): Define only if BYTE_MARK_STACK.
3245 * xdisp.c (message_enable_multibyte): Now static.
3246
61c2b50e 3247 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3248 This makes it easier for human readers (and static analyzers)
3249 to see whether these variables are used from other modules.
3250 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3251 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3252 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3253 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3254 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3255 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3256 * xmenu.c, xselect.c:
3257 Declare Q* vars static if they are not used in other modules.
3258 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3259 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3260 Remove decls of unexported vars.
3261 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3262
95c82688
PE
3263 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3264
16a97296
PE
3265 Make Emacs functions such as Fatom 'static' by default.
3266 This makes it easier for human readers (and static analyzers)
3267 to see whether these functions can be called from other modules.
3268 DEFUN now defines a static function. To make the function external
3269 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3270 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3271 (Finit_image_library):
16a97296
PE
3272 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3273 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3274 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3275 Remove decls, since these functions are now static.
3276 (Funintern, Fget_internal_run_time): New decls, since these functions
3277 were already external.
95c82688 3278
16a97296
PE
3279 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3280 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3281 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3282 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3283 * keyboard.c, keymap.c, lread.c:
3284 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3285 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3286 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3287 Mark functions with DEFUE instead of DEFUN,
3288 if they are used in other modules.
3289 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3290 decls for now-static functions.
3291 * buffer.h (Fdelete_overlay): Remove decl.
3292 * callproc.c (Fgetenv_internal): Mark as internal.
3293 * composite.c (Fremove_list_of_text_properties): Remove decl.
3294 (Fcomposition_get_gstring): New forward static decl.
3295 * composite.h (Fcomposite_get_gstring): Remove decl.
3296 * dired.c (Ffile_attributes): New forward static decl.
3297 * doc.c (Fdocumntation_property): New forward static decl.
3298 * eval.c (Ffetch_bytecode): New forward static decl.
3299 (Funintern): Remove extern decl; now in .h file where it belongs.
3300 * fileio.c (Fmake_symbolic_link): New forward static decl.
3301 * image.c (Finit_image_library): New forward static decl.
3302 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3303 * intervals.h (Fprevious_property_change):
3304 (Fremove_list_of_text_properties): Remove decls.
3305 * keyboard.c (Fthis_command_keys): Remove decl.
3306 (Fcommand_execute): New forward static decl.
3307 * keymap.c (Flookup_key): New forward static decl.
3308 (Fcopy_keymap): Now static.
3309 * keymap.h (Flookup_key): Remove decl.
3310 * process.c (Fget_process): New forward static decl.
3311 (Fprocess_datagram_address): Mark as internal.
3312 * syntax.c (Fsyntax_table_p): New forward static decl.
3313 (skip_chars): Remove duplicate decl.
3314 * textprop.c (Fprevious_property_change): New forward static decl.
3315 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3316 Now internal.
3317 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3318 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3319
785bbd42
PE
3320 * editfns.c (Fformat): Remove unreachable code.
3321
8b913b57
AS
33222011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3323
3324 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3325 change. (Bug#8496)
3326
a6744a35
EZ
33272011-04-13 Eli Zaretskii <eliz@gnu.org>
3328
3329 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3330 when at ZV. (Bug#8487)
3331
e7974947
AS
33322011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3333
baad03f0
AS
3334 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3335 (Bug#8437)
3336 * keyboard.c (parse_tool_bar_item): Likewise.
3337 * sound.c (sound_cleanup, alsa_close): Likewise.
3338 * termcap.c (tgetent): Likewise.
3339 * xfns.c (x_default_font_parameter): Likewise.
3340 * xsettings.c (read_and_apply_settings): Likewise.
3341
e7974947
AS
3342 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3343 (overrun_check_free): Protoize.
3344
28272684
PE
33452011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3346
3347 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3348 since callers should never pass a negative size.
3349 Change the signature to match that of plain 'read' and 'write'; see
3350 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3351 * lisp.h: Update prototypes of emacs_write and emacs_read.
3352
11997c76
EZ
33532011-04-11 Eli Zaretskii <eliz@gnu.org>
3354
3355 * xdisp.c (redisplay_window): Don't try to determine the character
3356 position of the scroll margin if the window start point w->startp
e896f03c 3357 is outside the buffer's accessible region. (Bug#8468)
11997c76 3358
8a2cbd72
EZ
33592011-04-10 Eli Zaretskii <eliz@gnu.org>
3360
3361 Fix write-region and its subroutines for buffers > 2GB.
3362 * fileio.c (a_write, e_write): Modify declaration of arguments and
3363 local variables to support buffers larger than 2GB.
3364 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3365
3366 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3367 argument, local variables, and return value.
3368
3369 * lisp.h: Update prototypes of emacs_write and emacs_read.
3370
3371 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3372
4073e537 33732011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3374
1ebfdcb6
PE
3375 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3376
b2ded58d
PE
3377 Fix more problems found by GCC 4.6.0's static checks.
3378
7d66342c
PE
3379 * xdisp.c (vmessage): Use a better test for character truncation.
3380
bbf47d44
PE
3381 * charset.c (load_charset_map): <, not <=, for optimization,
3382 and to avoid potential problems with integer overflow.
9248994d 3383 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3384 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3385 * editfns.c (Fformat): Likewise.
1e69125e 3386 * syntax.c (skip_chars): Likewise.
3befa583 3387
e3019616
PE
3388 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3389 This also lets GCC 4.6.0 generate slightly better loop code.
3390
becfa255
PE
3391 * callint.c (Fcall_interactively): <, not <=, for optimization.
3392 (Fcall_interactively): Count the number of arguments produced,
3393 not the number of arguments given. This is simpler and lets GCC
3394 4.6.0 generate slightly better code.
3395
dae0cd48
PE
3396 * ftfont.c: Distingish more carefully between FcChar8 and char.
3397 The previous code passed unsigned char * to a functions like
3398 strlen and xstrcasecmp that expect char *, which does not
3399 conform to the C standard.
3400 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3401 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3402 char * when the C standard requires it.
3403
76032d70
PE
3404 * keyboard.c (read_char): Remove unused var.
3405
eb3f1cc8
PE
3406 * eval.c: Port to Windows vsnprintf (Bug#8435).
3407 Include <limits.h>.
3408 (SIZE_MAX): Define if the headers do not.
3409 (verror): Do not give up if vsnprintf returns a negative count.
3410 Instead, grow the buffer. This ports to Windows vsnprintf, which
3411 does not conform to C99. Problem reported by Eli Zaretskii.
3412 Also, simplify the allocation scheme, by avoiding the need for
3413 calling realloc, and removing the ALLOCATED variable.
3414
70476b54
PE
3415 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3416
12020a9e
PE
3417 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3418 But keep the doprint source code for now, as we might revamp it
3419 and use it again (Bug#8435).
ea6c7ae6
PE
3420 * lisp.h (doprnt): Remove.
3421 * Makefile.in (base_obj): Remove doprnt.o.
3422 * deps.mk (doprnt.o): Remove.
3423
5fdb398c
PE
3424 error: Print 32- and 64-bit integers portably (Bug#8435).
3425 Without this change, on typical 64-bit hosts error ("...%d...", N)
3426 was used to print both 32- and 64-bit integers N, which relied on
3427 undefined behavior.
3428 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3429 New macro.
3430 * lisp.h (error, verror): Mark as printf-like functions.
3431 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3432 Report overflow in size calculations when allocating printf buffer.
3433 Do not truncate output string at its first null byte.
3434 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3435 Truncate the output at a character boundary, since vsnprintf does not
3436 do that.
3437 * charset.c (check_iso_charset_parameter): Convert internal
3438 character to string before calling 'error', since %c now has the
3439 printf meaning.
3440 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3441 overflow when computing char to be passed to 'error'. Do not
3442 pass Lisp_Object to 'error'; pass the integer instead.
3443 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3444 formatted with plain %d.
3445
b189fa66
PE
3446 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3447
bff87ef0
PE
3448 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3449
7e2cac20
PE
3450 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3451
ce4d90b5
PE
3452 * xterm.c (x_catch_errors): Remove duplicate declaration.
3453
266c9547
PE
3454 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3455
79c49ad2
PE
3456 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3457
368f4090
JM
34582011-04-10 Jim Meyering <meyering@redhat.com>
3459
3460 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3461 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3462 return ssize_t not "int", and use size_t as the buffer length.
3463 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3464 * gnutls.h: Update declarations.
3465 * process.c (read_process_output): Use ssize_t, to match.
3466 (send_process): Likewise.
3467
a32d4040
CY
34682011-04-09 Chong Yidong <cyd@stupidchicken.com>
3469
3470 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3471
8546720e 34722011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3473
04f2d78b
CB
3474 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3475 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3476
8546720e
GM
3477 * xterm.c (handle_one_xevent):
3478 * xmenu.c (create_and_show_popup_menu):
3479 * xselect.c (x_decline_selection_request)
3480 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3481
0a2f5c1a 34822011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3483
3484 Fix some uses of `int' instead of EMACS_INT.
3485 * search.c (string_match_1, fast_string_match)
3486 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3487 (scan_buffer, find_next_newline_no_quit)
3488 (find_before_next_newline, search_command, Freplace_match)
3489 (Fmatch_data): Make some `int' variables be EMACS_INT.
3490
3491 * xdisp.c (display_count_lines): 3rd argument and return value now
3492 EMACS_INT. All callers changed.
3493 (pint2hrstr): Last argument is now EMACS_INT.
3494
3495 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3496 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3497 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3498 (decode_coding_utf_16, decode_coding_emacs_mule)
3499 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3500 (decode_coding_ccl, decode_coding_charset)
3501 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3502 (decode_coding_iso_2022, decode_coding_emacs_mule)
3503 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3504 <char_offset, last_offset>: Declare EMACS_INT.
3505 (encode_coding_utf_8, encode_coding_utf_16)
3506 (encode_coding_emacs_mule, encode_invocation_designation)
3507 (encode_designation_at_bol, encode_coding_iso_2022)
3508 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3509 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3510 Declare EMACS_INT.
3511 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3512 (encode_invocation_designation): Last argument P_NCHARS is now
3513 EMACS_INT.
3514 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3515 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3516
3517 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3518 All users changed.
3519
3520 * ccl.c (Fccl_execute_on_string): Declare some variables
3521 EMACS_INT.
3522
8546720e 35232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3524
3525 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3526
4e19a977
CS
35272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3528
3529 * process.c (Fformat_network_address): Doc fix.
3530
87302331
R
35312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3532
3533 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3534
cbb59342
CY
35352011-04-08 Chong Yidong <cyd@stupidchicken.com>
3536
3537 * keyboard.c (read_char): Call Lisp function help-form-show,
3538 instead of using internal_with_output_to_temp_buffer.
3539 (Qhelp_form_show): New var.
e0d38eeb 3540 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3541
3542 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3543
3544 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3545
e67a13ab
CY
35462011-04-06 Chong Yidong <cyd@stupidchicken.com>
3547
04f2d78b
CB
3548 * process.c (Flist_processes): Remove to Lisp.
3549 (list_processes_1): Delete.
e67a13ab 3550
973f782d
EZ
35512011-04-06 Eli Zaretskii <eliz@gnu.org>
3552
7c106b1e
EZ
3553 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3554
973f782d
EZ
3555 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3556
41cf7d1a 35572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3558
ca23cc88
PE
3559 Fix more problems found by GCC 4.6.0's static checks.
3560
f390e2d5
PE
3561 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3562
42eea0d0
PE
3563 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3564
b69769da 3565 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3566
f9541e84
PE
3567 * xdisp.c (vmessage): Mark as a printf-like function.
3568
13841b55
PE
3569 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3570
c136c10f
PE
3571 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3572
5e2d4a30
PE
3573 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3574 printf-like functions.
3575 (tiff_load): Add casts to remove these marks before passing them
3576 to system-supplied API.
3577
583f48b9
PE
3578 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3579
b25d760e
PE
3580 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3581 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3582 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3583 directly, rather than having caller test rule sign. This avoids
3584 some unnecessary tests.
3585 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3586 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3587 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3588
bc7b6697 3589 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3590 (xfont_open): Avoid unnecessary tests.
bc7b6697 3591
27ccc379
PE
3592 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3593
dcd5c89a
PE
3594 * composite.h, composite.c (composition_gstring_put_cache):
3595 Use EMACS_INT, not int, for length.
3596
b13a45c6
PE
3597 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3598 breaking out part of COMPOSITION_DECODE_RULE.
3599 (COMPOSITION_DECODE_RULE): Use it.
3600 * composite.c (get_composition_id): Remove unused local vars,
3601 by using the new macro.
3602
1e792e4d
PE
3603 * textprop.c (set_text_properties_1): Change while to do-while,
3604 since the condition is always true at first.
3605
dc6c6455 3606 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3607 (interval_deletion_adjustment): Return unsigned value.
3608 All uses changed.
dc6c6455 3609
aba7731a
PE
3610 * process.c (list_processes_1, create_pty, read_process_output):
3611 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3612 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3613 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3614 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3615 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3616
fdfc4bf3
PE
3617 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3618
fca8fe46 3619 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3620 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3621
06a0259a 3622 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3623 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3624 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3625
e7b9e80f
PE
3626 * print.c (print_error_message): Avoid int overflow.
3627
56201685
PE
3628 * font.c (font_list_entities): Redo for clarity,
3629 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3630
78834453 3631 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3632 (font_score): Avoid potential overflow in diff calculation.
78834453 3633
0bc0b309 3634 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3635 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3636
e610eaca
PE
3637 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3638
b895abce
PE
3639 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3640 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3641 can always succeed if overflow has undefined behavior.
3642
1f1d9321 3643 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3644 (wordify): Omit three unnecessary tests.
1f1d9321 3645
c59478bc
PE
3646 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3647 All callers changed. This avoids the need for an unused var.
3648
79b73827
PE
3649 * casefiddle.c (casify_region): Remove var that is set but not used.
3650
a4db5dfe
PE
3651 * dired.c (file_name_completion): Remove var that is set but not used.
3652
43aae36e
PE
3653 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3654
2a47c44d 3655 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3656 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3657
a37c69bf
PE
3658 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3659 Check for integer overflow on size calculations.
3660
328ab8e7
PE
3661 * buffer.c (Fprevious_overlay_change): Remove var that is set
3662 but not used.
3663
e5a2a5cb
PE
3664 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3665 Remove vars that are set but not used.
8d84a6eb 3666 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3667 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3668
a60e5f68
PE
3669 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3670
f661cb61 3671 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3672 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3673
f0397f5a
PE
3674 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3675 that are set but not used.
3676
8664db06 3677 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3678 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3679
6abdaa4a
PE
3680 * xselect.c (x_get_local_selection, x_handle_property_notify):
3681 Remove vars that are set but not used.
3682
0ce7538d 3683 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3684 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3685
9ae848fc
PE
3686 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3687 Remove var that is set but not used.
0b918413
PE
3688 (scroll_bar_windows_size): Now size_t, not int.
3689 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3690 Check for overflow.
9ae848fc 3691
a5a62657
PE
3692 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3693 (map_tty_color) [!defined MSDOS]: Likewise.
3694
5c5cdd39
PE
3695 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3696
66ebf983
PE
3697 * coding.c: Remove vars that are set but not used.
3698 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3699 All callers changed.
3700 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3701 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3702 (decode_coding_charset): Remove vars that are set but not used.
3703
1be4d761
PE
3704 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3705 that is set but not used.
3706
47553fa8
PE
3707 * print.c (print_object): Remove var that is set but not used.
3708
1f7196bf 3709 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3710 The gnulib version avoids calling malloc in the usual case,
3711 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3712 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3713 * filelock.c (current_lock_owner): Likewise.
3714 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3715 * sysdep.c: Include allocator.h, careadlinkat.h.
3716 (emacs_no_realloc_allocator): New static constant.
3717 (emacs_readlink): New function.
fdb61804
PE
3718 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3719 ../lib/careadlinkat.h.
d1fdcab7 3720
f84c17c7
SM
37212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3722
3723 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3724 first non-nil return value).
3725
ef3862ad
JD
37262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3727
3728 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3729 if not defined (Bug#8403).
3730
376a7006
JB
37312011-04-02 Juanma Barranquero <lekktu@gmail.com>
3732
3733 * xdisp.c (display_count_lines): Remove parameter `start',
3734 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3735 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3736 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3737 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3738 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3739 and thereabouts. All callers changed.
3740 (get_per_char_metric): Remove parameter `f', unused since
3741 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3742
6ca3801d
JM
37432011-04-02 Jim Meyering <meyering@redhat.com>
3744
3745 do not dereference NULL upon failed strdup
3746 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3747 (ns_get_family): Likewise.
3748
d8e2b5ba
JB
37492011-04-02 Juanma Barranquero <lekktu@gmail.com>
3750
3751 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3752
8c74fcbd
JD
37532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3754
3755 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3756 later (Bug#8403).
3757
7200d79c
SM
37582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3759
03408648 3760 Add lexical binding.
7200d79c 3761
03408648
SM
3762 * window.c (Ftemp_output_buffer_show): New fun.
3763 (Fsave_window_excursion):
3764 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3765
3766 * lread.c (lisp_file_lexically_bound_p): New function.
3767 (Fload): Bind Qlexical_binding.
3768 (readevalloop): Remove `evalfun' arg.
3769 Bind Qinternal_interpreter_environment.
3770 (Feval_buffer): Bind Qlexical_binding.
3771 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3772 Mark as dynamic.
3773 (syms_of_lread): Declare `lexical-binding'.
3774
3775 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3776
3777 * keyboard.c (eval_dyn): New fun.
3778 (menu_item_eval_property): Use it.
ca105506
SM
3779
3780 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3781
03408648
SM
3782 * fns.c (concat, mapcar1): Accept byte-code-functions.
3783
3784 * eval.c (Fsetq): Handle lexical vars.
3785 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3786 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3787 (FletX, Flet): Obey lexical binding.
3788 (Fcommandp): Handle closures.
3789 (Feval): New `lexical' arg.
3790 (eval_sub): New function extracted from Feval. Use it almost
3791 everywhere where Feval was used. Look up vars in lexical env.
3792 Handle closures.
3793 (Ffunctionp): Move from subr.el.
3794 (Ffuncall): Handle closures.
3795 (apply_lambda): Remove `eval_flags'.
3796 (funcall_lambda): Handle closures and new byte-code-functions.
3797 (Fspecial_variable_p): New function.
3798 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3799 but without exporting it to Lisp.
23aba0ea 3800
23aba0ea 3801 * doc.c (Fdocumentation, store_function_docstring):
03408648 3802 * data.c (Finteractive_form): Handle closures.
23aba0ea 3803
03408648
SM
3804 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3805 interactive spec.
ba83908c 3806
04f2d78b
CB
3807 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3808 New byte-codes.
03408648
SM
3809 (exec_byte_code): New function extracted from Fbyte_code to handle new
3810 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3811
03408648 3812 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3813
03408648 3814 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3815
e2abce01
JB
38162011-03-31 Juanma Barranquero <lekktu@gmail.com>
3817
3818 * xdisp.c (redisplay_internal): Fix prototype.
3819
63696a73 38202011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3821
63696a73 3822 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3823 (try_scrolling): Use it when setting scroll_limit.
3824 Limit scrolling to 100 screen lines.
63696a73
EZ
3825 (redisplay_window): Even when falling back on "recentering",
3826 position point in the window according to scroll-conservatively,
3827 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3828
3829 (try_scrolling): When point is above the window, allow searching
3830 as far as scroll_max, or one screenful, to compute vertical
3831 distance from PT to the scroll margin position. This prevents
3832 try_scrolling from unnecessarily failing when
3833 scroll-conservatively is set to a value slightly larger than the
3834 window height. Clean up the case of PT below the margin at bottom
3835 of window: scroll_max can no longer be INT_MAX. When aggressive
3836 scrolling is in use, don't let point enter the opposite scroll
3837 margin as result of the scroll.
3838 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3839 threshold of 100 lines for never-recentering scrolling.
3840
e4cc2dfc
JB
38412011-03-31 Juanma Barranquero <lekktu@gmail.com>
3842
3843 * dispextern.h (move_it_by_lines):
3844 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3845 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3846 (message_log_check_duplicate): Remove parameters `prev_bol' and
3847 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3848 (redisplay_internal): Remove parameter `preserve_echo_area',
3849 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3850
3851 * indent.c (Fvertical_motion):
3852 * window.c (window_scroll_pixel_based, Frecenter):
3853 Don't pass `need_y_p' to `move_it_by_lines'.
3854
1c470562
SM
38552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3856
44f230aa
SM
3857 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3858 steal a few bits to be more compact.
3859 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3860 Remove unneeded casts.
3861
1c470562
SM
3862 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3863
888adce9
ZK
38642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3865
3866 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3867 binding" message (bug#7967).
3868
f838ed7b
PE
38692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3870
77861b95
PE
3871 Fix more problems found by GCC 4.6.0's static checks.
3872
de6dbc14
PE
3873 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3874 Remove unused local var.
3875
f838ed7b
PE
3876 * editfns.c (Fmessage_box): Remove unused local var.
3877
792c7b2b
PE
3878 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3879 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3880 Omit unused local vars.
c499e557 3881 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3882 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3883 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3884 Omit unused local var.
3885
ba0165e1
PE
3886 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3887 Don't assume string length fits in int.
32ad8845 3888 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3889 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3890
3c59b4c9
PE
3891 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3892 instead of alloca (Bug#8344).
3893
a3eed478 3894 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3895 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3896
eb4d412d
PE
3897 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3898
1658b401
PE
3899 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3900 concerns.
3901
3902 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3903
3904 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3905
9a2c6e05
PE
3906 * keyboard.c (syms_of_keyboard): Use the same style as later
3907 in this function when indexing through an array. This also
3908 works around GCC bug 48267.
3909
03d0a109
PE
3910 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3911
44f730c8
PE
3912 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3913
fe75f926
PE
3914 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3915 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3916
ffa8c828
PE
3917 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3918 This avoids undefined behavior on integer overflow, and is a bit
3919 more convenient anyway since it is compared to a size_t variable.
3920
c5101a77
PE
3921 Variadic C functions now count arguments with size_t, not int.
3922 This avoids an unnecessary limitation on 64-bit machines, which
3923 caused (substring ...) to crash on large vectors (Bug#8344).
3924 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3925 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3926 All variadic functions and their callers changed accordingly.
c5101a77
PE
3927 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3928 * data.c (arith_driver, float_arith_driver): Likewise.
3929 * editfns.c (general_insert_function): Likewise.
3930 * eval.c (struct backtrace.nargs, interactive_p)
3931 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3932 (funcall_lambda, mark_backtrace): Likewise.
3933 * fns.c (concat): Likewise.
3934 * frame.c (x_set_frame_parameters): Likewise.
3935 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3936 0 if not found, not -1. All callers changed.
3937
dd3f25f7
PE
3938 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3939 (stack_copy_size): Now size_t, not int.
3940 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3941
461c2ab9
JB
39422011-03-28 Juanma Barranquero <lekktu@gmail.com>
3943
3944 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3945 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3946 All callers changed.
3947
3948 * lisp.h (multibyte_char_to_unibyte):
3949 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3950 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3951 * character.h (CHAR_TO_BYTE8):
3952 * cmds.c (internal_self_insert):
3953 * editfns.c (general_insert_function):
3954 * keymap.c (push_key_description):
3955 * search.c (Freplace_match):
3956 * xdisp.c (message_dolog, set_message_1): All callers changed.
3957
f6d62986
SM
39582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3959
3960 * keyboard.c (safe_run_hook_funcall): New function.
3961 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3962 don't set the hook to nil, but remove the offending function instead.
3963 (Qcommand_hook_internal): Remove, unused.
3964 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3965 Vcommand_hook_internal.
3966
3967 * eval.c (enum run_hooks_condition): Remove.
3968 (funcall_nil, funcall_not): New functions.
3969 (run_hook_with_args): Call each function through a `funcall' argument.
3970 Remove `cond' argument, now redundant.
3971 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3972 (Frun_hook_with_args_until_failure): Adjust accordingly.
3973 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3974
1db5b1ad
JB
39752011-03-28 Juanma Barranquero <lekktu@gmail.com>
3976
3977 * dispextern.h (string_buffer_position): Remove declaration.
3978
3979 * print.c (strout): Remove parameter `multibyte', unused since
3980 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3981
3982 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3983 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3984 All callers changed.
3985
3986 * w32.c (_wsa_errlist): Use braces for struct initializers.
3987
3988 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3989 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3990 All callers changed.
3991 (string_buffer_position): Likewise. Also, make static (it's never
3992 used outside xdisp.c).
3993 (cursor_row_p): Remove parameter `w', unused since
3994 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3995 (decode_mode_spec): Remove parameter `precision', introduced during
3996 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3997 All callers changed.
3998
5ffb62aa
JD
39992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4000
4001 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4002
461c2ab9 40032011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4004
4005 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4006 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4007 (ns_update_auto_hide_menu_bar): New functions.
4008 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4009 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4010 ns_constrain_all_frames.
4011 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4012 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4013
5c380ffb
JD
40142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4015
4016 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4017
9af30bdf
GM
40182011-03-27 Glenn Morris <rgm@gnu.org>
4019
4020 * syssignal.h: Replace RETSIGTYPE with void.
4021 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4022 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4023 Replace SIGTYPE with void everywhere.
4024 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4025 * s/template.h (SIGTYPE): Remove commented out definition.
4026
e2abce01
JB
40272011-03-26 Eli Zaretskii <eliz@gnu.org>
4028
4029 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4030 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4031
f868cd8a
JB
40322011-03-26 Juanma Barranquero <lekktu@gmail.com>
4033
59eb0929
JB
4034 * w32.c (read_unc_volume): Use parameter `henum', instead of
4035 global variable `wget_enum_handle'.
4036
4037 * keymap.c (describe_vector): Remove parameters `indices' and
4038 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4039 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4040
f868cd8a
JB
4041 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4042
4043 * keyboard.c (timer_check): Remove parameter `do_it_now',
4044 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4045 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4046 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4047
4048 * keyboard.c (read_char):
4049 * w32menu.c (w32_menu_display_help):
4050 * xmenu.c (show_help_event, menu_help_callback):
4051 Adjust calls to `show_help_echo'.
4052
4053 * gtkutil.c (xg_maybe_add_timer):
4054 * keyboard.c (readable_events):
4055 * process.c (wait_reading_process_output):
4056 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4057
4058 * insdel.c (adjust_markers_gap_motion):
4059 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4060 (gap_left, gap_right): Don't call it.
4061
2ecf6fdb
CY
40622011-03-25 Chong Yidong <cyd@stupidchicken.com>
4063
4064 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4065 incurred during fontification.
4066
6b1f9ba4
JB
40672011-03-25 Juanma Barranquero <lekktu@gmail.com>
4068
4069 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4070 (DEFVAR_PER_BUFFER): Don't pass it.
4071
4072 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4073 (scrolling_window): Don't pass it.
4074
0f4a96b5
JB
40752011-03-25 Juanma Barranquero <lekktu@gmail.com>
4076
4077 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4078
4079 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4080 and `suffix'.
4081 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4082 of variables specific to SELinux and computation of `encoded_absname'.
4083
4084 * image.c (XPutPixel): Remove unused variable `height'.
4085
4086 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4087
4088 * unexw32.c (get_section_info): Remove unused variable `section'.
4089
4090 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4091 (system_process_attributes): Remove unused variable `sess'.
4092 (sys_read): Remove unused variable `err'.
4093
4094 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4095 (w32_wnd_proc): Remove unused variable `isdead'.
4096 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4097 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4098 (x_create_tip_frame): Remove unused variable `tem'.
4099
4100 * w32inevt.c (w32_console_read_socket):
4101 Remove unused variable `no_events'.
4102
4103 * w32term.c (x_draw_composite_glyph_string_foreground):
4104 Remove unused variable `width'.
4105
1149507c
JB
41062011-03-24 Juanma Barranquero <lekktu@gmail.com>
4107
4108 * w32term.c (x_set_glyph_string_clipping):
4109 Don't pass uninitialized region to CombineRgn.
4110
9c88f339
JB
41112011-03-23 Juanma Barranquero <lekktu@gmail.com>
4112
4113 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4114 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4115 (Fx_close_connection): Remove unused variable `i'.
4116
4117 * w32font.c (w32font_draw): Return number of glyphs.
4118 (w32font_open_internal): Remove unused variable `i'.
4119 (w32font_driver): Add missing initializer.
4120
4121 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4122 (fill_in_menu): Remove unused variable `items_added'.
4123
4124 * w32term.c (last_mouse_press_frame): Remove static global variable.
4125 (w32_clip_to_row): Remove unused variable `f'.
4126 (x_delete_terminal): Remove unused variable `i'.
4127
4128 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4129 (NOTHING): Remove unused static global variable.
4130 (uniscribe_check_otf): Remove unused variable `table'.
4131 (uniscribe_font_driver): Add missing initializers.
4132
dee091a3
JD
41332011-03-23 Julien Danjou <julien@danjou.info>
4134
4135 * term.c (Fsuspend_tty, Fresume_tty):
4136 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4137 * window.c (temp_output_buffer_show):
4138 * insdel.c (signal_before_change):
4139 * frame.c (Fhandle_switch_frame):
4140 * fileio.c (Fdo_auto_save):
4141 * emacs.c (Fkill_emacs):
4142 * editfns.c (save_excursion_restore):
4143 * cmds.c (internal_self_insert):
4144 * callint.c (Fcall_interactively):
4145 * buffer.c (Fkill_all_local_variables):
4146 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4147 Use Frun_hooks.
0f4a96b5 4148 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4149 unconditionnaly since it does the check itself.
4150
2c520ab5 41512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4152
c9c49752
PE
4153 Fix more problems found by GCC 4.5.2's static checks.
4154
8abc3f12
PE
4155 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4156 the first time through the loop, since we know p0 < p1 then.
4157 This also avoids a gcc -Wstrict-overflow warning.
4158
a2d26660
PE
4159 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4160 leading to a memory leak, possible in functions like
4161 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4162 of objects (Bug#8318).
a2d26660 4163
916c72e9
PE
4164 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4165 that could (at least in theory) be that large.
4166
19ab8a18
PE
4167 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4168 This is less likely to overflow, and avoids undefined behavior if
4169 overflow does occur. All callers changed. Use strtoul to scan
4170 for the unsigned long integer.
b7cbbd6f
PE
4171 (pint2hrstr): Simplify and tune code slightly.
4172 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4173
f0641eff
PE
4174 * scroll.c (do_scrolling): Work around GCC bug 48228.
4175 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4176
7f650bb9
PE
4177 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4178 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4179 (validate_x_resource_name): Simplify count usage.
4180 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4181
37dd57d1
PE
4182 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4183 fail (Bug#8306).
81e56e61 4184
699979fc 4185 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4186
401bf9b4
PE
4187 * process.c (Fmake_network_process): Use socklen_t, not int,
4188 where POSIX says socklen_t is required in portable programs.
4189 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4190 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4191 (Fmake_network_process, server_accept_connection):
4192 (wait_reading_process_output, read_process_output):
4193 Likewise.
4194
b93aacde
PE
4195 * process.c: Rename or move locals to avoid shadowing.
4196 (list_processes_1, Fmake_network_process):
4197 (read_process_output_error_handler, exec_sentinel_error_handler):
4198 Rename or move locals.
4dc343ee 4199 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4200 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4201 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4202 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4203 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4204
af8a867c 4205 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4206 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4207 Include tparam.h instead, since it declares them.
af8a867c
PE
4208 * cm.h (PC): Remove extern decl; tparam.h now does this.
4209 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4210 * terminfo.c: Include tparam.h, to check interfaces.
4211 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4212 (tparam): Adjust signature to match interface in tparam.h;
4213 this removes some undefined behavior. Check that outstring and len
4214 are zero, which they always are with Emacs.
4215 * tparam.h (PC, BC, UP): New extern decls.
4216
0248044d 4217 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4218 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4219
8ff096c1 4220 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4221 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4222 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4223 (ftfont_list): Remove unused local.
49eaafba
PE
4224 (get_adstyle_property, ftfont_pattern_entity):
4225 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4226 Rename locals to avoid shadowing.
8ff096c1 4227
e2be39f6
PE
4228 * xfont.c (xfont_list_family): Mark var as initialized.
4229
c9735e30
PE
4230 * xml.c (make_dom): Now static.
4231
8f5201ae
PE
4232 * composite.c (composition_compute_stop_pos): Rename local to
4233 avoid shadowing.
b246f932
PE
4234 (composition_reseat_it): Remove unused locals.
4235 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4236 (composition_update_it): Mark var as initialized.
11b61122
PE
4237 (find_automatic_composition): Mark vars as initialized,
4238 with a FIXME (Bug#8290).
8f5201ae 4239
760fbc2c
PE
4240 character.h: Rename locals to avoid shadowing.
4241 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4242 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4243 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4244 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4245 to avoid shadowing.
4246
ff08eb85
PE
4247 * textprop.c (property_change_between_p): Remove; unused.
4248
fc7bf025
PE
4249 * intervals.c (interval_start_pos): Now static.
4250
235d7abc
PE
4251 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4252
44f230aa
SM
4253 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4254 Rename locals to avoid shadowing.
3e7d6594 4255
50060332
PE
4256 * sound.c (wav_play, au_play, Fplay_sound_internal):
4257 Fix pointer signedness.
d01f234b 4258 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4259 (wav_play): Initialize a variable to 0, to prevent undefined
4260 behavior (Bug#8278).
50060332 4261
c4fc4e30
PE
4262 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4263
918436ed
PE
4264 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4265
c939f91b
PE
4266 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4267 clobbering (Bug#8298).
b9c7f648
PE
4268 * sysdep.c (sys_subshell): Likewise.
4269 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4270
6bd8c144
PE
4271 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4272 This should get cleaned up, so that child_setup has the
4273 same signature on all platforms.
4274
7710357c 4275 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4276 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4277
c59da222
CY
42782011-03-22 Chong Yidong <cyd@stupidchicken.com>
4279
4280 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4281 not to be necessary, and produces flickering.
4282
66b87493
GM
42832011-03-20 Glenn Morris <rgm@gnu.org>
4284
4285 * config.in: Remove file.
4286
45b6f6d5
JB
42872011-03-20 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4290 are now in src/globals.h.
4291 (syms_of_minibuf): Remove spurious & from previous change.
4292
3ec03f7e
LL
42932011-03-20 Leo <sdl.web@gmail.com>
4294
4295 * minibuf.c (completing-read-function): New variable.
4296 (completing-read-default): Rename from completing-read.
4297 (completing-read): Call completing-read-function.
4298
b14e3e21
CY
42992011-03-19 Juanma Barranquero <lekktu@gmail.com>
4300
4301 * xfaces.c (Fx_load_color_file):
4302 Read color file from absolute filename (bug#8250).
4303
f2b726e6
JB
43042011-03-19 Juanma Barranquero <lekktu@gmail.com>
4305
4306 * makefile.w32-in: Update dependencies.
4307
09f6ff02
EZ
43082011-03-17 Eli Zaretskii <eliz@gnu.org>
4309
4310 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4311
29a6015a
PE
43122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4313
a3a6c54e
PE
4314 Fix more problems found by GCC 4.5.2's static checks.
4315
b766f867
PE
4316 * process.c (make_serial_process_unwind, send_process_trap):
4317 (sigchld_handler): Now static.
4318
be02381c
PE
4319 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4320 That way, the code declares only the vars that it needs.
4321 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4322 * s/cygwin.h (PTY_ITERATION): Likewise.
4323 * s/darwin.h (PTY_ITERATION): Likewise.
4324 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4325
57048744
PE
4326 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4327 * process.c (allocate_pty): Don't declare stb unless it's needed.
4328
7914961c 4329 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4330 (CONSTANTLIM): Remove; unused.
4331 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4332 Define only if needed.
7914961c 4333
b3967b18
PE
4334 * unexelf.c (unexec): Name an expression,
4335 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4336 Use a different way to cause a compilation error if anyone uses
4337 n rather than nn, a way that does not involve shadowing.
73366a00 4338 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4339
29a6015a
PE
4340 * deps.mk (unexalpha.o): Remove; unused.
4341
43cfc33e 4342 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4343 * unexec.h: New file.
ce701a33
PE
4344 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4345 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4346 Depend on unexec.h.
4347 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4348 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4349 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4350 Change as necessary to match prototype in unexec.h.
ce701a33 4351
01f44d5a
PE
4352 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4353 shadowing.
4f63c6bb 4354 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4355
a6670b0b
PE
4356 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4357 Rename locals to avoid shadowing.
4358
cef2010d 4359 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4360 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4361
d4d7173a
PE
4362 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4363
f08b802a
PE
4364 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4365 warning when compiling print.c.
4366
3ddb0639
PE
4367 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4368 instead of using an uninitialized var.
5ad03b97 4369 (font_sort_entities): Mark var as initialized.
3ddb0639 4370
170a2692
PE
4371 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4372
e663c700
PE
4373 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4374 pointers to constants.
89bc529a 4375 (font_parse_fcname): Remove unused vars.
7b81e2d0 4376 (font_delete_unmatched): Now static.
ea838e10 4377 (font_get_spec): Remove; unused.
13a547c6
PE
4378 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4379 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4380 Rename or move locals to avoid shadowing.
e663c700 4381
2a80c887 4382 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4383 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4384
1384fa33 4385 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4386 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4387
8b2c52e9
PE
4388 * alloc.c (mark_backtrace): Move decl from here ...
4389 * lisp.h: ... to here, so that it can be checked.
4390
475545b5 4391 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4392 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4393 (lisp_indirect_variable): Name an expression,
4394 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4395 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4396
b1349114 4397 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4398 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4399 Use const pointer when appropriate.
b1349114 4400
a2928364
PE
4401 * lisp.h (get_system_name, get_operating_system_release):
4402 Move decls here, to check interfaces.
4403 * process.c (get_operating_system_release): Move decl to lisp.h.
4404 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4405 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4406 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4407 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4408 (Fformat_time_string, Fencode_time, Finsert_char):
4409 (Ftranslate_region_internal, Fformat):
4410 Rename or remove local vars to avoid shadowing.
9710023e 4411 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4412
a415e694
PE
4413 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4414 avoid shadowing.
4415
8ef4622d
PE
4416 * lisp.h (eassert): Check that the argument compiles, even if
4417 ENABLE_CHECKING is not defined.
4418
946f9a5b
PE
4419 * data.c (Findirect_variable): Name an expression, to avoid
4420 gcc -Wbad-function-cast warning.
112396d6 4421 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4422 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4423 (Fmake_variable_buffer_local, Fmake_local_variable):
4424 Mark variables as initialized.
52746918 4425 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4426
e5aab7e7 4427 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4428 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4429 Rename locals to avoid shadowing.
dff45157
PE
4430 (mark_stack): Move local variables into the #ifdef region where
4431 they're used.
7bc26fdb
PE
4432 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4433 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4434 needed otherwise.
4435 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4436 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4437 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4438
e5aab7e7
PE
4439 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4440 avoids undefined behavior in theory.
4441
4da60324
PE
4442 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4443
88043301
PE
4444 Use functions, not macros, for up- and down-casing (Bug#8254).
4445 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4446 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4447 to use the following functions instead of these macros.
4448 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4449 EMACS_INT, since callers assume the returned value fits in int.
4450 (upcase1): Likewise, for UPCASE_TABLE.
4451 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4452 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4453 the race-condition problem in the old DOWNCASE.
88043301 4454
19ed5445
PE
4455 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4456 Rename locals to avoid shadowing.
4457 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4458 (regex_compile, re_search_2, re_match_2_internal):
4459 Remove unused local vars.
952db0d7
PE
4460 (FREE_VAR): Rewrite so as not to use empty "else",
4461 which gcc can warn about.
da053e48 4462 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4463 (RETALLOC_IF): Define only if needed.
4464 (WORDCHAR_P): Likewise. This one is never needed, but is used
4465 only in a comment talking about a compiler bug, so put inside
4466 the #if 0 of that comment.
4467 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4468 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4469 Remove; unused.
19ed5445 4470
1f3561e4 4471 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4472 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4473 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4474
ded6f8f7
PE
4475 * search.c (simple_search): Remove unused var.
4476
dbd37a95
PE
4477 * dired.c (compile_pattern): Move decl from here ...
4478 * lisp.h: ... to here, so that it can be checked.
4479 (struct re_registers): New forward decl.
4480
7e47afad
PE
4481 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4482
85f24f61
PE
4483 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4484 All uses changed.
4485 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4486 Rename locals to avoid shadowing.
5671df8f 4487 (Fvertical_motion): Mark locals as initialized.
85f24f61 4488
181aa2be 4489 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4490 (casify_region): Mark local as initialized.
181aa2be 4491
930d429c
PE
4492 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4493
7082eac6
PE
4494 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4495 New macros, so that the caller can use some names other than
4496 gcpro1, gcpro2, etc.
4497 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4498 of the new macros.
4499 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4500 argument, for consistency with GCPRO2_VAR, etc: it is now the
4501 prefix of the variable, not the variable itself. All uses
4502 changed.
38b2c076
PE
4503 * dired.c (directory_files_internal, file_name_completion):
4504 Rename locals to avoid shadowing.
4505
15206ed9
PE
4506 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4507 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4508 dired.c's scmp function, had undefined behavior.
4509 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4510 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4511 * buffer.h: ... to here, because these macros use current_buffer,
4512 and the new implementation with inline functions needs to have
4513 current_buffer in scope now, rather than later when the macros
4514 are used.
4515 (downcase, upcase1): New static inline functions.
4516 (DOWNCASE, UPCASE1): Reimplement using these functions.
4517 This avoids undefined behavior in expressions like
4518 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4519 from race conditions in accessing the global variables
4520 case_temp1 and case_temp2.
4521 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4522 * lisp.h (case_temp1, case_temp2): Remove their decls.
4523 * character.h (ASCII_CHAR_P): Move from here ...
4524 * lisp.h: ... to here, so that the inline functions mentioned
4525 above can use them.
4526
4a6bea26
PE
4527 * dired.c (directory_files_internal_unwind): Now static.
4528
f14b7e14
PE
4529 * fileio.c (file_name_as_directory, directory_file_name):
4530 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4531 Now static.
2893f146
PE
4532 (file_name_as_directory): Use const pointers when appropriate.
4533 (Fexpand_file_name): Likewise. In particular, newdir might
4534 point at constant storage, so make it a const pointer.
fd4ead52 4535 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4536 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4537 signedness issues.
f839df0c
PE
4538 (Fset_file_times, Finsert_file_contents, auto_save_error):
4539 Rename locals to avoid shadowing.
f14b7e14 4540
5716756e 4541 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4542 (Ftry_completion, Fall_completions): Rename or remove locals
4543 to avoid shadowing.
5716756e 4544
b4c3046a
PE
4545 * marker.c (bytepos_to_charpos): Remove; unused.
4546
b45db522
PE
4547 * lisp.h (verify_bytepos, count_markers): New decls,
4548 so that gcc does not warn that these functions aren't declared.
4549
85876d07
PE
4550 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4551 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4552 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4553 (copy_text): Remove unused local var.
85876d07 4554
03d78a21 4555 * filelock.c (within_one_second): Now static.
b3dd38ab 4556 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4557
5df8f01b
PE
4558 * buffer.c (fix_overlays_before): Mark locals as initialized.
4559 (fix_start_end_in_overlays): Likewise. This function should be
4560 simplified by using pointers-to-pointers, but that's a different
4561 matter.
b1d876f1 4562 (switch_to_buffer_1): Now static.
8f54f30a
PE
4563 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4564 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4565
a70072c9 4566 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4567 Fix pointer signedness issue.
edced198
PE
4568 (sys_subshell): Mark local as volatile if checking for lint,
4569 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4570 (MAXPATHLEN): Define only if needed.
a70072c9 4571
a0977c44
PE
4572 * process.c (serial_open, serial_configure): Move decls from here ...
4573 * systty.h: ... to here, so that they can be checked.
4574
a884fdcc
PE
4575 * fns.c (get_random, seed_random): Move extern decls from here ...
4576 * lisp.h: ... to here, so that they can be checked.
4577
604efe86 4578 * sysdep.c (reset_io): Now static.
b8950c94 4579 (wait_for_termination_signal): Remove; unused.
604efe86 4580
38fc62d9
PE
4581 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4582 (copy_keymap_item, append_key, push_text_char_description):
4583 Now static.
1004a21a 4584 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4585 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4586 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4587 (describe_map_tree):
4588 Rename locals to avoid shadowing.
38fc62d9 4589
2f2650da
PE
4590 * keyboard.c: Declare functions static if they are not used elsewhere.
4591 (echo_char, echo_dash, cmd_error, top_level_2):
4592 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4593 (read_char, kbd_buffer_get_event, make_lispy_position):
4594 (make_lispy_event, make_lispy_movement, apply_modifiers):
4595 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4596 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4597 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4598 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4599 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4600
a053e86c 4601 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4602 (mark_kboards): Move decl here ...
4603 * alloc.c (mark_kboards): ... from here.
a053e86c 4604
4752793e
PE
4605 * lisp.h (force_auto_save_soon): New decl.
4606
74f10ca7 4607 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4608 (DEFINE_DUMMY_FUNCTION): New macro.
4609 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4610 Use it.
c03cd23f
PE
4611 (main): Add casts to avoid warnings
4612 if GCC considers string literals to be constants.
74f10ca7 4613
022e70d4
PE
4614 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4615
59d6fe83
PE
4616 * dbusbind.c: Pointer signedness fixes.
4617 (xd_signature, xd_append_arg, xd_initialize):
4618 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4619 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4620 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4621 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4622
78320123
PE
4623 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4624 if GCC considers string literals to be constants.
49cebcca 4625 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4626
35ac2a97
SM
46272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4628
fb103ca9
SM
4629 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4630 (print_preprocess, print_object): New macro to fix last change.
4631
35ac2a97
SM
4632 * print.c (print_preprocess): Don't forget font objects.
4633
62973b41
JB
46342011-03-16 Juanma Barranquero <lekktu@gmail.com>
4635
4636 * emacs.c (USAGE3): Doc fixes.
4637
0e48bb22
AS
46382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4639
4640 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4641 structure.
4642
7684e57b
JB
46432011-03-14 Juanma Barranquero <lekktu@gmail.com>
4644
4645 * lisp.h (VWindow_system, Qfile_name_history):
4646 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4647 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4648 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4649
4650 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4651 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4652
4653 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4654 * w32console.c (detect_input_pending, read_input_pending)
4655 (encode_terminal_code):
4656 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4657 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4658 (w32_system_caret_y, Qfile_name_history):
4659 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4660 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4661 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4662 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4663 * w32proc.c (Qlocal, report_file_error):
4664 * w32term.c (Vwindow_system, updating_frame):
4665 * w32uniscribe.c (initialized, uniscribe_font_driver):
4666 Remove unneeded extern declarations.
4667
2aa46d6c
CY
46682011-03-14 Chong Yidong <cyd@stupidchicken.com>
4669
c96bbc66 4670 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4671
cffc6f3b
CY
46722011-03-13 Chong Yidong <cyd@stupidchicken.com>
4673
4674 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4675 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4676 These macros can no longer be used for assignment.
4677
44f230aa
SM
4678 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4679 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4680 (record_buffer_markers, fetch_buffer_markers): New functions for
4681 recording and fetching special buffer markers.
4682 (set_buffer_internal_1, set_buffer_temp): Use them.
4683
4684 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4685
4686 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4687
4688 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4689 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4690
4691 * xdisp.c (hscroll_window_tree):
4692 (reconsider_clip_changes): Use PT instead of BUF_PT.
4693
d251f04b
EZ
46942011-03-13 Eli Zaretskii <eliz@gnu.org>
4695
4696 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4697 $(EMACS_ROOT)/lib/intprops.h.
4698
f0c77cd1
PE
46992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4700
3eca4629
PE
4701 Fix more problems found by GCC 4.5.2's static checks.
4702
7c86ee98
PE
4703 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4704 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4705 (xg_free_frame_widgets): Make it clear that a local variable is
4706 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4707 (gdk_window_get_screen): Make it clear that this macro is needed
4708 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4709 (int_gtk_range_get_value): New function, which avoids a diagnostic
4710 from gcc -Wbad-function-cast.
4711 (xg_set_toolkit_scroll_bar_thumb): Use it.
4712 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4713 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4714 (get_utf8_string, xg_get_file_with_chooser):
4715 Rename locals to avoid shadowing.
4716 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4717
41729b81
PE
4718 * xgselect.c (xg_select): Remove unused var.
4719
f0c77cd1
PE
4720 * image.c (four_corners_best): Mark locals as initialized.
4721 (gif_load): Initialize transparent_p to zero (Bug#8238).
4722 Mark another local as initialized.
ec6cf4c6 4723 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4724
ce0ad53d 4725 * image.c (clear_image_cache): Now static.
d5d5a617 4726 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4727 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4728 (x_edge_detection): Remove unnecessary cast that
4729 gcc -Wbad-function-cast diagnoses.
2037898d 4730 (gif_load): Fix pointer signedness.
6ae141d6
PE
4731 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4732 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4733
33383987 47342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4735
d32df629
PE
4736 Improve quality of tests for time stamp overflow.
4737 For example, without this patch (encode-time 0 0 0 1 1
4738 1152921504606846976) returns the obviously-bogus value (-948597
4739 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4740 reports time overflow. See
4741 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4742 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4743 * editfns.c: Include limits.h and intprops.h.
4744 (TIME_T_MIN, TIME_T_MAX): New macros.
4745 (time_overflow): Move earlier, to before first use.
4746 (hi_time, lo_time): New functions, for an accurate test for
4747 out-of-range times.
4748 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4749 (Fget_internal_run_time): Don't assume time_t fits in int.
4750 (make_time): Use list2 instead of Fcons twice.
4751 (Fdecode_time): More accurate test for out-of-range times.
4752 (check_tm_member): New function.
4753 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4754 (lisp_time_argument): Don't rely on undefined left-shift and
4755 right-shift behavior when checking for time stamp overflow.
8be6f318 4756
fe31d94c
PE
4757 * editfns.c (time_overflow): New function, refactoring common code.
4758 (Fformat_time_string, Fdecode_time, Fencode_time):
4759 (Fcurrent_time_string): Use it.
4760
8be6f318
PE
4761 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4762 * dired.c (make_time): Move to ...
4763 * editfns.c (make_time): ... here.
4764 * systime.h: Note the move.
4765
09d9db2c 47662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4767
126bc0dc
YM
4768 * fringe.c (update_window_fringes): Remove unused variables.
4769
c47cbdfd
YM
4770 * unexmacosx.c (copy_data_segment): Also copy __got section.
4771 (Bug#8223)
4772
7ac80be9
EZ
47732011-03-12 Eli Zaretskii <eliz@gnu.org>
4774
c96bbc66 4775 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4776 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4777 Constify `char *' arguments and their references according to
4778 prototypes in tparam.h.
4779
ecb0f94d 4780 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4781
7ac80be9
EZ
4782 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4783 Adapt all references accordingly.
4784
4785 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4786
ef1fd07e
TT
47872011-03-11 Tom Tromey <tromey@redhat.com>
4788
4789 * buffer.c (syms_of_buffer): Remove obsolete comment.
4790
7ef4b50c
EZ
47912011-03-11 Eli Zaretskii <eliz@gnu.org>
4792
4793 * termhooks.h (encode_terminal_code): Declare prototype.
4794
4795 * msdos.c (encode_terminal_code): Don't declare prototype.
4796
4797 * term.c (encode_terminal_code): Now external again, used by
4798 w32console.c and msdos.c.
4799
44f230aa
SM
4800 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4801 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4802
4b1ec863 48032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4804
1714f52b 4805 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4806
4b1ec863
PE
4807 * fringe.c (update_window_fringes): Mark locals as initialized
4808 (Bug#8227).
4809 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4810
524c7aa6
PE
4811 * alloc.c (mark_fringe_data): Move decl from here ...
4812 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4813 to check its interface.
4814 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4815
a5c0af81 4816 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4817 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4818 (fontset_font): Mark local as initialized.
a9a06e0b 4819 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4820
b4716021
PE
4821 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4822
811e9bac 4823 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4824 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4825 (x_own_selection, Fx_disown_selection_internal): Rename locals
4826 to avoid shadowing.
4827 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4828
7e3ab302
PE
4829 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4830 so that the caller can use some name other than gcpro1.
4831 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4832 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4833 (Fx_backspace_delete_keys_p):
4834 Use them to avoid shadowing, and rename vars to avoid shadowing.
4835 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4836 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4837 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4838 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4839 Remove unused locals.
7e3ab302
PE
4840 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4841 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4842 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4843 macros.
f78faa98 4844
e2b13473
PE
4845 * xterm.h (x_mouse_leave): New decl.
4846
77f23912
PE
4847 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4848 Remove unused functions.
cdf4ba58
PE
4849 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4850 (x_calc_absolute_position): Now static.
7411c686 4851 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4852 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4853 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4854 unless they are used.
38d0b34a
PE
4855 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4856 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4857 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4858 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4859 (x_error_catcher, x_connection_closed, x_error_handler):
4860 (x_error_quitter, xembed_send_message, x_iconify_frame):
4861 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4862 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4863 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4864
44f230aa
SM
4865 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4866 Rename or move locals to avoid shadowing.
6b463e58 4867 (tty_defined_color, merge_face_heights): Now static.
5967d051 4868 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4869 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4870 does not deduce is never used uninitialized.
73719eba
PE
4871 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4872 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4873
426994c3 4874 * terminal.c (store_terminal_param): Now static.
5489860b 4875
032f1620 4876 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4877 (set_frame_menubar): Remove unused local.
d4323972 4878 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4879 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4880 since they might point to immutable storage.
281585b0
PE
4881 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4882 since it's unused otherwise.
032f1620 4883
367c19e5 4884 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4885 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4886 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4887 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4888 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4889 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4890 does not deduce are never used uninitialized.
70739cbe 4891
07b48fa9
PE
4892 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4893
8868a238 4894 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4895 * window.c (window_loop, size_window):
4896 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4897
7e5cf297 4898 * window.c (display_buffer): Now static.
d6550a9f
PE
4899 (size_window): Mark variables that gcc -Wuninitialized
4900 does not deduce are never used uninitialized.
a586633d
PE
4901 * window.h (check_all_windows): New decl, to forestall
4902 gcc -Wmissing-prototypes diagnostic.
5b555da1 4903 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4904
f6095868
PE
4905 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4906 shadowing.
4907 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4908 Include <limits.h>.
4909 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4910 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4911 (load_charset_map): Mark variables that gcc -Wuninitialized
4912 does not deduce are never used uninitialized.
53df7c11 4913 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4914
f38b440c
PE
4915 * coding.c (coding_set_source, coding_set_destination):
4916 Use "else { /* comment */ }" rather than "else /* comment */;"
4917 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4918 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4919 a block, when the outer 'i' will do.
4920 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4921 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4922 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4923 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4924 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4925 Rename locals to avoid shadowing.
4926 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4927 * coding.c (emacs_mule_char, encode_invocation_designation):
4928 Now static, since they're not used elsewhere.
413bb2db 4929 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4930 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4931 (decode_coding_emacs_mule): Mark variables that gcc
4932 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4933 (detect_coding_iso_2022): Initialize a local variable that might
4934 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4935 this initialization is needed. (Bug#8211)
5f58e762
PE
4936 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4937 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4938 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4939 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4940 Remove unused macros.
f38b440c 4941
232b38b9 4942 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4943 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4944 * character.c (string_count_byte8): Likewise.
232b38b9 4945
fb90da1b
PE
4946 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4947 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4948
fb93dbc2
PE
4949 * chartab.c (copy_sub_char_table): Now static, since it's not used
4950 elsewhere.
5c156ace
PE
4951 (sub_char_table_ref_and_range, char_table_ref_and_range):
4952 Rename locals to avoid shadowing.
bbcd0949 4953 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4954
7d3b3862 4955 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4956 (BIDI_BOB): Remove unused macro.
7d3b3862 4957
6be7d3da
PE
4958 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4959 deduce are never used uninitialized.
c2ed9c8b 4960 * term.c (encode_terminal_code): Likewise.
6be7d3da 4961
75f8807f 4962 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4963
50938595
PE
4964 * tparam.h: New file.
4965 * term.c, tparam.h: Include it.
4966 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4967 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4968 Move these decls to tparam.h, and make them agree with what
4969 is actually in tparam.c. The previous trick of using incompatible
4970 decls in different modules does not conform to the C standard.
4971 All callers of tparam changed to use tparam's actual API.
4972 * tparam.c (tparam1, tparam, tgoto):
4973 Use const pointers where appropriate.
4974
fbceeba2
PE
4975 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4976 * cm.h (struct cm): Likewise.
4977 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4978 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4979 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4980 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4981 (turn_on_face, init_tty): Likewise.
4982 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4983
7f3f1250
PE
4984 * term.c (term_mouse_position): Rename local to avoid shadowing.
4985
e6ca6543
PE
4986 * alloc.c (mark_ttys): Move decl from here ...
4987 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4988
c40f8d15
AS
49892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4990
4991 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4992
cfe0661d
JB
49932011-03-09 Juanma Barranquero <lekktu@gmail.com>
4994
4995 * search.c (compile_pattern_1): Remove argument regp, unused since
4996 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4997 (compile_pattern): Don't pass it.
4998
0afb4571
J
49992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5000
5001 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5002 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5003 for ! HAVE_GTK3.
5004 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5005
5006 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5007
5008 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5009 gdk_window_get_screen, gdk_window_get_geometry,
5010 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5011 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5012 (xg_get_pixbuf_from_pixmap): New function.
5013 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5014 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5015 Call xg_get_pixbuf_from_pixmap instead of
5016 gdk_pixbuf_get_from_drawable.
5017 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5018 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5019 (xg_check_special_colors): Use GtkStyleContext and its functions
5020 for HAVE_GTK3.
5021 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5022 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5023 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5024 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5025 Call gtk_widget_get_preferred_size.
0afb4571
J
5026 (xg_frame_resized): gdk_window_get_geometry only takes 5
5027 parameters.
44f230aa
SM
5028 (xg_win_to_widget, xg_event_is_for_menubar):
5029 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5030 (xg_set_widget_bg): New function.
5031 (delete_cb): New function.
895009e1 5032 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5033 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5034 (xg_set_background_color): Call xg_set_widget_bg.
5035 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5036 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5037 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5038 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5039 if ! HAVE_GTK3.
5040 (update_frame_tool_bar): Call gtk_widget_hide.
5041 (xg_initialize): Use GDK_KEY_g.
5042
5043 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5044 if ! HAVE_GTK3
5045 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5046
5047 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5048 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5049 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5050
1c2cc4ef
JB
50512011-03-08 Juanma Barranquero <lekktu@gmail.com>
5052
5053 * w32xfns.c (select_palette): Check success of RealizePalette against
5054 GDI_ERROR, not zero.
5055
33383987 5056See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5057
5058;; Local Variables:
5059;; coding: utf-8
aac0c6e3
MR
5060;; End:
5061
33383987 5062 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5063
5064 This file is part of GNU Emacs.
5065
5066 GNU Emacs is free software: you can redistribute it and/or modify
5067 it under the terms of the GNU General Public License as published by
5068 the Free Software Foundation, either version 3 of the License, or
5069 (at your option) any later version.
5070
5071 GNU Emacs is distributed in the hope that it will be useful,
5072 but WITHOUT ANY WARRANTY; without even the implied warranty of
5073 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5074 GNU General Public License for more details.
5075
5076 You should have received a copy of the GNU General Public License
5077 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.