* process.c (Fsignal_process): Check for process-ids out of pid_t range rather than...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
682432fc 12011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2
682432fc 3 Fix integer width and related bugs.
eb106a49 4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 (mark_vectorlike):
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
d311d28c
PE
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
79cce3f2
PE
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
d311d28c
PE
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 117 Don't assume fixnum fits in int.
d311d28c
PE
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
c96e5d6a 146 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 178 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 182 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 184 Don't access memory outside of the args array.
d311d28c 185 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
d311d28c
PE
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
209 (Faref, Faset):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
224 (struct it):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
240 (get_doc_string):
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
243 * doprnt.c (doprnt):
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
268 (Fuser_login_name, Fuser_full_name): Signal an error
269 if a uid argument is out of range, rather than relying on
270 undefined behavior.
d311d28c
PE
271 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
272 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
273 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
274 (init_cmdargs, Fdump_emacs):
275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
276 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
277 the bottom (typically) 32 bits of the fixnum.
278 * eval.c (specpdl_size, call_debugger):
279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
280 (when_entered_debugger, Fbacktrace_debug):
281 Don't assume fixnum can fit in int.
282 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
283 the object just before a buffer; this is not portable.
284 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
285 (grow_specpdl, unbind_to):
286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
287 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
288 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 289 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
290 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
291 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
293 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
294 (a_write, e_write):
295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
296 (Fcopy_file, non_regular_nbytes, read_non_regular)
297 (Finsert_file_contents):
298 Use int, not EMACS_INT, where int is wide enough.
299 (READ_BUF_SIZE): Verify that it fits in int.
300 (Finsert_file_contents): Check that counts are in proper range,
301 rather than assuming fixnums fit into ptrdiff_t etc.
302 Don't assume fixnums fit into int.
125b3835 303 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
304 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
305 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
306 (string_char_to_byte, string_byte_to_char)
307 (string_make_multibyte, string_to_multibyte)
308 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
309 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
310 (substring_both, Fdelete, internal_equal, Ffillarray)
311 (Fclear_string, mapcar1)
312 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
313 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
314 (larger_vector, make_hash_table, maybe_resize_hash_table)
315 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
316 (Fmaphash, secure_hash):
317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
318 (concat): Check for string index and length overflow.
319 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
320 (Frequire):
321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
322 (larger_vector): New API (vec, incr_min, size_max) replaces old
323 one (vec, new_size, init). This catches size overflow.
324 INIT was removed because it was always Qnil.
325 All callers changed.
326 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
327 the upper bound on a hash table index size.
328 (make_hash_table, maybe_resize_hash_table): Use it.
329 (secure_hash): Computer start_byte and end_byte only after
330 they're known to be in ptrdiff_t range.
331 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
332 (Ffont_get_glyphs, Ffont_at):
333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
334 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
335 (Flist_fonts, Fopen_font):
336 Don't assume fixnum can fit in int.
337 (check_gstring): Don't assume index can fit in int.
338 (font_match_p): Check that fixnum is a character, not a nonnegative
339 fixnum, since the later code needs to stuff it into an int.
340 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
341 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
342 conversion overflow issues.
343 (Fopen_font): Check for integer out of range.
344 (Ffont_get_glyphs): Don't assume index can fit in int.
345 * font.h: Adjust decls to match defn changes elsewhere.
346 * fontset.c (reorder_font_vector): Redo score calculation to avoid
347 integer overflow.
348 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
349 printmax_t, where ptrdiff_t is wide enough.
350 (Finternal_char_font):
351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
352 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
353 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
354 (Fset_frame_position, x_set_frame_parameters)
355 (x_set_line_spacing, x_set_border_width)
356 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
357 Check that fixnums are in proper range for system types.
358 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
360 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
361 Use SAFE_ALLOCA_LISP, not alloca.
362 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
363 intptr_t is wide enough.
364 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
365 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
366 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
367 Check for fixnum out of range.
368 * ftfont.c (ftfont_list): Don't assume index fits in int.
369 Check that fixnums are in proper range for system types.
370 (ftfont_shape_by_flt):
371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
372 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
375 Check that fixnums are in proper range for system types.
376 * gnutls.h: Adjust decls to match defn changes elsewhere.
377 * gtkutil.c (xg_dialog_run):
378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
379 (update_frame_tool_bar):
380 Check that fixnums are in proper range for system types.
381 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 382 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
383 * indent.c (last_known_column, last_known_column_point):
384 (current_column_bol_cache):
385 (skip_invisible, current_column, check_display_width):
386 (check_display_width, scan_for_column, current_column_1)
387 (Findent_to, Fcurrent_indentation, position_indentation)
388 (indented_beyond_p, Fmove_to_column, compute_motion):
389 (Fcompute_motion, Fvertical_motion):
390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
391 (last_known_column_modified): Use EMACS_INT, not int.
392 (check_display_width):
393 (Fcompute_motion):
394 Check that fixnums and floats are in proper range for system types.
395 (compute_motion): Don't assume index or fixnum fits in int.
396 (compute_motion, Fcompute_motion):
397 Use int, not EMACS_INT, when it is wide enough.
398 (vmotion): Omit local var start_hpos that is always 0; that way
399 we don't need to worry about overflow in expressions involving it.
400 * indent.h: Adjust decls to match defn changes elsewhere.
401 (struct position):
402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
403 Use int, not EMACS_INT, where int is wide enough.
404 Remove unused members ovstring_chars_done and tab_offset;
405 all uses removed.
406 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
407 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
408 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
409 (make_gap, copy_text, insert, insert_and_inherit)
410 (insert_before_markers, insert_before_markers_and_inherit)
411 (insert_1, count_combining_before, count_combining_after)
412 (insert_1_both, insert_from_string)
413 (insert_from_string_before_markers, insert_from_string_1)
414 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
415 (adjust_after_replace, adjust_after_insert, replace_range)
416 (replace_range_2, del_range, del_range_1, del_range_byte)
417 (del_range_both, del_range_2, modify_region)
418 (prepare_to_modify_buffer, signal_before_change)
419 (signal_after_change, Fcombine_after_change_execute):
420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
421 * intervals.c (traverse_intervals, rotate_right, rotate_left)
422 (balance_an_interval, split_interval_right, split_interval_left)
423 (find_interval, next_interval, update_interval)
424 (adjust_intervals_for_insertion, delete_node, delete_interval)
425 (interval_deletion_adjustment, adjust_intervals_for_deletion)
426 (static_offset_intervals, offset_intervals)
427 (merge_interval_right, merge_interval_left, make_new_interval)
428 (graft_intervals_into_buffer, temp_set_point_both)
429 (temp_set_point, set_point, adjust_for_invis_intang)
430 (set_point_both, move_if_not_intangible, get_property_and_range)
431 (get_local_map, copy_intervals, copy_intervals_to_string)
432 (compare_string_intervals, set_intervals_multibyte_1):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 * intervals.h: Adjust decls to match defn changes elsewhere.
435 (struct interval):
436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
437 * keyboard.c (this_command_key_count, this_single_command_key_start)
438 (before_command_key_count, before_command_echo_length, echo_now)
439 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
440 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
441 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
442 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
444 (last_non_minibuf_size, last_point_position, echo_truncate)
445 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
446 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
447 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
448 (stuff_buffered_input):
449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
450 (last_auto_save, command_loop_1, read_char):
451 Use EMACS_INT, not int, to avoid integer overflow.
452 (record_char): Avoid overflow in total_keys computation.
453 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
454 * keyboard.h: Adjust decls to match defn changes elsewhere.
455 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
456 (Fkey_description, Fdescribe_vector, Flookup_key):
457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
458 (click_position): New function, to check that positions are in range.
459 (Fcurrent_active_maps):
460 (describe_command):
461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
462 (Faccessible_keymaps, Fkey_description):
463 (preferred_sequence_p):
464 Don't assume fixnum can fit into int.
465 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
466 Check for integer overflow in size calculations.
467 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
468 avoid mishandling large integers.
469 * lisp.h: Adjust decls to match defn changes elsewhere.
470 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
471 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
472 (struct Lisp_Marker):
473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
474 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
475 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
476 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
477 All callers changed.
478 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
479 Assume the arg has valid form, since it always does.
480 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
481 unsigned integer system type.
482 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
483 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
485 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
486 (duration_to_sec_usec): New decl.
487 * lread.c (read_from_string_index, read_from_string_index_byte)
488 (read_from_string_limit, readchar, unreadchar, openp)
489 (read_internal_start, read1, oblookup):
490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
491 (Fload, readevalloop, Feval_buffer, Feval_region):
492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
493 (openp): Check for out-of-range argument to 'access'.
494 (read1): Use int, not EMACS_INT, where int is wide enough.
495 Don't assume fixnum fits into int.
1ab7b8ac
PE
496 (read_filtered_event): Use duration_to_sec_usec
497 to do proper overflow checking on durations.
d311d28c
PE
498 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
499 in size calculation.
500 (Fexecute_kbd_macro):
501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
502 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
503 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
504 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
505 (set_marker_both, set_marker_restricted_both, marker_position)
506 (marker_byte_position, Fbuffer_has_markers_at):
507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
508 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
509 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
510 It now merely ensures that the menu is large enough, without
511 necessarily growing it, as this avoids some integer overflow issues.
512 All callers changed.
513 (keymap_panes, parse_single_submenu, Fx_popup_menu):
514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
515 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
516 Use SAFE_ALLOCA_LISP, not alloca.
517 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
518 to EMACS_INT. Check that fixnums are in proper range for system types.
519 * minibuf.c (minibuf_prompt_width, string_to_object)
520 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
521 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
523 (get_minibuffer, read_minibuf_unwind):
524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
525 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
526 this simplifies overflow checking. All callers changed.
527 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
528 (Ftest_completion):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
531 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
532 Check that fixnums are in proper range for system types.
533 (Fx_create_frame, Fx_show_tip):
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 * nsfont.m (ns_findfonts, nsfont_list_family):
536 Don't assume fixnum fits in long.
537 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
539 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
540 wide enough.
17fdb222 541 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
543 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
544 (PRINTDECLARE, PRINTPREPARE):
545 (strout, print_string):
546 (print, print_preprocess, print_check_string_charset_prop)
547 (print_object):
548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
549 (PRINTDECLARE):
550 (temp_output_buffer_setup, Fprin1_to_string, print_object):
551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
552 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
553 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
554 (printchar, strout): Use xpalloc to catch size calculation overflow.
555 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
556 to avoid mishandling large integers.
557 (print_error_message): Use SAFE_ALLOCA, not alloca.
558 (print_object): Use int, not EMACS_INT, where int is wide enough.
559 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
560 (Fset_process_window_size, Fformat_network_address)
561 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 562 (sigchld_handler):
d311d28c 563 Check that fixnums are in proper range for system types.
d44287d4 564 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
565 Check for process-ids out of pid_t range rather than relying on
566 undefined behavior.
d311d28c
PE
567 (Fformat_network_address, read_process_output, send_process)
568 (Fprocess_send_region, status_notify):
569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
570 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
571 (wait_reading_process_output, read_process_output, exec_sentinel):
572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
573 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
574 (Faccept_process_output): Use duration_to_sec_usec to do proper
575 overflow checking on durations.
b62b53e8
PE
576 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
577 configured --with-wide-int.
d311d28c
PE
578 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
579 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
580 * search.c (looking_at_1, string_match_1):
581 (fast_string_match, fast_c_string_match_ignore_case)
582 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
583 (scan_newline, find_before_next_newline, search_command)
584 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
585 (set_search_regs, wordify):
586 (Freplace_match):
587 (Fmatch_data):
588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
589 (string_match_1, search_buffer, set_search_regs):
590 (Fmatch_data):
591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
592 (wordify): Check for overflow in size calculation.
593 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
594 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
595 Check that fixnums are in proper range for system types.
596 * sound.c (struct sound_device)
597 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
599 (Fplay_sound_internal):
600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
601 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
602 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
603 for the respective integer ranges. This fixes a bug with
604 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
605 (struct lisp_parse_state, find_start_modiff)
606 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
607 (Fparse_partial_sexp):
608 Don't assume fixnums can fit in int.
609 (struct lisp_parse_state, find_start_pos, find_start_value)
610 (find_start_value_byte, find_start_begv)
611 (update_syntax_table, char_quoted, dec_bytepos)
612 (find_defun_start, prev_char_comend_first, back_comment):
613 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
614 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
616 (Finternal_describe_syntax_value): Check that match_lisp is a
617 character, not an integer, since the code stuffs it into int.
618 (scan_words, scan_sexps_forward):
619 Check that fixnums are in proper range for system types.
620 (Fforward_word):
621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
622 (scan_sexps_forward):
623 Use CHARACTERP, not INTEGERP, since the value must fit into int.
624 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
625 * syntax.h: Adjust decls to match defn changes elsewhere.
626 (struct gl_state_s):
627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
628 * sysdep.c (wait_for_termination_1, wait_for_termination)
629 (interruptible_wait_for_termination, mkdir):
630 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
631 (emacs_read, emacs_write):
632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
633 (system_process_attributes): Don't assume uid_t, gid_t, and
634 double all fit in int or even EMACS_INT.
635 * term.c (set_tty_color_mode):
636 Check that fixnums are in proper range for system types.
637 * termhooks.h (struct input_event):
638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
639 * textprop.c (validate_interval_range, interval_of)
640 (Fadd_text_properties, set_text_properties_1)
641 (Fremove_text_properties, Fremove_list_of_text_properties)
642 (Ftext_property_any, Ftext_property_not_all)
643 (copy_text_properties, text_property_list, extend_property_ranges)
644 (verify_interval_modification):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
646 (Fnext_single_char_property_change)
647 (Fprevious_single_char_property_change):
648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
649 (copy_text_properties):
650 Check for integer overflow in index calculation.
d311d28c
PE
651 * undo.c (last_boundary_position, record_point, record_insert)
652 (record_delete, record_marker_adjustment, record_change)
653 (record_property_change):
654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
655 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
657 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
658 (Fx_hide_tip, Fx_file_dialog):
659 * w32menu.c (set_frame_menubar):
660 Use ptrdiff_t, not int, for consistency with rest of code.
661 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
662 (select_window, Fdelete_other_windows_internal)
663 (window_scroll_pixel_based, window_scroll_line_based)
664 (Frecenter, Fset_window_configuration):
665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
666 (Fset_window_hscroll, run_window_configuration_change_hook)
667 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 668 (Fscroll_other_window, Frecenter):
d311d28c
PE
669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
670 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
671 Don't assume fixnum fits in int.
672 (Fset_window_scroll_bars):
673 Check that fixnums are in proper range for system types.
674 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
675 (string_pos, c_string_pos, number_of_chars, init_iterator)
676 (in_ellipses_for_invisible_text_p, init_from_display_pos)
677 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
678 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
679 (face_before_or_after_it_pos, handle_invisible_prop)
680 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
681 (display_prop_intangible_p, string_buffer_position_lim)
682 (string_buffer_position, handle_composition_prop, load_overlay_strings)
683 (get_overlay_strings_1, get_overlay_strings)
684 (iterate_out_of_display_property, forward_to_next_line_start)
685 (back_to_previous_visible_line_start, reseat, reseat_to_string)
686 (get_next_display_element, set_iterator_to_next)
687 (get_visually_first_element, compute_stop_pos_backwards)
688 (handle_stop_backwards, next_element_from_buffer)
689 (move_it_in_display_line_to, move_it_in_display_line)
690 (move_it_to, move_it_vertically_backward, move_it_by_lines)
691 (add_to_log, message_dolog, message_log_check_duplicate)
692 (message2, message2_nolog, message3, message3_nolog
693 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
694 (current_message_1, truncate_echo_area, truncate_message_1)
695 (set_message, set_message_1, store_mode_line_noprop)
696 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
697 (text_outside_line_unchanged_p, check_point_in_composition)
698 (reconsider_clip_changes)
699 (redisplay_internal, set_cursor_from_row, try_scrolling)
700 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
701 (redisplay_window, find_last_unchanged_at_beg_row)
702 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
703 (trailing_whitespace_p, find_row_edges, display_line)
704 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
705 (display_mode_element, store_mode_line_string)
706 (pint2str, pint2hrstr, decode_mode_spec)
707 (display_count_lines, display_string, draw_glyphs)
708 (x_produce_glyphs, x_insert_glyphs)
709 (rows_from_pos_range, mouse_face_from_buffer_pos)
710 (fast_find_string_pos, mouse_face_from_string_pos)
711 (note_mode_line_or_margin_highlight, note_mouse_highlight):
712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
713 (safe_call, init_from_display_pos, handle_fontified_prop)
714 (handle_single_display_spec, load_overlay_strings)
715 (with_echo_area_buffer, setup_echo_area_for_printing)
716 (display_echo_area, echo_area_display)
717 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
718 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
719 (redisplay_window, dump_glyph_row, display_mode_line)
720 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 721 (handle_display_spec, display_prop_string_p):
d311d28c
PE
722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
723 (handle_single_display_spec, build_desired_tool_bar_string)
724 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
725 (get_specified_cursor_type):
726 Check that fixnums are in proper range for system types.
727 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
728 (Flookup_image_map):
729 Don't assume fixnums fit in int.
730 (compare_overlay_entries):
731 Avoid mishandling comparisons due to subtraction overflow.
732 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
733 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
734 (handle_tool_bar_click):
735 Use int, not unsigned, since we prefer signed and the signedness
736 doesn't matter here.
737 (get_next_display_element, next_element_from_display_vector):
738 Use int, not EMACS_INT, when int is wide enough.
739 (start_hourglass): Use duration_to_sec_usec to do proper
740 overflow checking on durations.
741 * xfaces.c (Fbitmap_spec_p):
742 Check that fixnums are in proper range for system types.
743 (compare_fonts_by_sort_order):
744 Avoid mishandling comparisons due to subtraction overflow.
745 (Fx_family_fonts, realize_basic_faces):
746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
747 (Fx_family_fonts):
748 Don't assume fixnum fits in int.
749 Use SAFE_ALLOCA_LISP, not alloca.
750 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
751 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
752 (face_at_buffer_position, face_for_overlay_string)
753 (face_at_string_position):
754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
755 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
756 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
757 (Fx_show_tip):
758 Check that fixnums are in proper range for system types.
759 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
760 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
762 (Fx_change_window_property): Don't assume fixnums fit in int.
763 * xfont.c (xfont_chars_supported):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
765 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
766 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 * xml.c (parse_region):
769 * xrdb.c (magic_file_p):
770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
771 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
772 (x_get_local_selection, x_reply_selection_request)
773 (x_handle_selection_request, wait_for_property_change):
774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
775 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
776 short is wide enough.
777 (x_send_client_event): Don't assume fixnum fits in int.
778 * xterm.c (x_x_to_emacs_modifiers):
779 Don't assume EMACS_INT overflows nicely into int.
780 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
781 may come from Lisp.
782 (handle_one_xevent): NATNUMP can eval its arg twice.
783 (x_connection_closed):
784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
785 * xterm.h: Adjust decls to match defn changes elsewhere.
786 (struct scroll_bar): Use struct vectorlike_header
787 rather than rolling our own approximation.
788 (SCROLL_BAR_VEC_SIZE): Remove; not used.
789
0074aef2
EZ
7902011-10-12 Eli Zaretskii <eliz@gnu.org>
791
79beb178
EZ
792 * bidi.c (bidi_level_of_next_char):
793 * xdisp.c (get_visually_first_element): Remove old incorrect
794 comments regarding the Unicode Line Separator character.
795
0074aef2
EZ
796 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
797
6e4b3fbe
DA
7982011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
799
800 * alloc.c (Fgc_status): Do not access beyond zombies array
801 boundary if nzombies > MAX_ZOMBIES.
802 * alloc.c (dump_zombies): Add missing format specifier.
803
0324f3af
PE
8042011-10-12 Paul Eggert <eggert@cs.ucla.edu>
805
b5525cac
PE
806 * xdisp.c (set_cursor_from_row): Simplify conditionals,
807 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
808
0324f3af
PE
809 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
810 Some packages use them to denote characters with modifiers.
811
e9b5f888
AS
8122011-10-11 Andreas Schwab <schwab@linux-m68k.org>
813
814 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
815 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
816 matching a pp-number. Rename parameter var to var1.
817
127827c0
SM
8182011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
819
820 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
821
c8fd3bd0
GM
8222011-10-08 Glenn Morris <rgm@gnu.org>
823
824 * callint.c (Fcall_interactively): Give a more explicit error for the
825 'c' case with a non-character input. (Bug#8479)
826
352ec8ff
EZ
8272011-10-08 Eli Zaretskii <eliz@gnu.org>
828
03669ccb
EZ
829 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
830 lines.
7061c986
EZ
831 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
832 lines that are hscrolled on the left.
03669ccb 833
352ec8ff
EZ
834 * dispnew.c (buffer_posn_from_coords): Account for a possible
835 presence of header-line. (Bug#4426)
836
a66cfb1c
SM
8372011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
838
839 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
840 advertise functionality which we discourage or doesn't work.
841
7c5ee88e
PE
8422011-10-07 Paul Eggert <eggert@cs.ucla.edu>
843
844 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
845 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
846 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
847 this makes Emacs dump core during garbage collection on rare
848 occasions. sizeof is obviously inferior to offsetof here, so
849 stick with offsetof.
850 (GC_POINTER_ALIGNMENT): New macro.
851 (mark_memory): Omit 3rd (offset) arg; caller changed.
852 Don't assume EMACS_INT alignment is the same as pointer alignment.
853
df1bbe5b
SM
8542011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * keyboard.c (read_key_sequence_remapped): New var.
857 (read_key_sequence): Compute remapping in the right buffer.
858 (command_loop_1): Use read_key_sequence's remapping directly.
859
51553db6
SM
8602011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
861
32c1fffd
SM
862 * dired.c (file_name_completion): Don't expand file name.
863 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
864 before checking file name handler.
865
51553db6
SM
866 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
867 they've been requested explicitly (bug#9591).
868
b6bd1599 8692011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
870
871 * keymap.c (Fsingle_key_description): Use make_specified_string
872 instead of build_string to build string from push_key_description.
873 (Bug#5193)
874
f701dc2a
PE
8752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
876
4222c55d
PE
877 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
878 This fixes a Y2038 bug on 64-bit hosts.
879 * buffer.c (reset_buffer):
880 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
881 (Fclear_buffer_auto_save_failure):
882 Use 0, not -1, to represent an unset failure time, since time_t
883 might not be signed.
884
f701dc2a
PE
885 Remove dependency on glibc malloc internals.
886 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
887 Move back here from lisp.h, but with their new implementations.
888 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
889 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
890 * charset.c (charset_table_init): New static var.
891 (syms_of_charset): Use it instead of xmalloc. This removes a
892 dependency on glibc malloc internals. See Eli Zaretskii's comment in
893 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
894 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
895 Move back to alloc.c.
896 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
897 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
898
9ceebf39
JD
8992011-09-30 Jan Djärv <jan.h.d@swipnet.se>
900
901 * nsterm.m (windowDidResize): Call x_set_window_size only when
902 ns_in_resize is true. Otherwise set pixelwidth/height and
903 call change_frame_size (Bug#9628).
904
cb993c58
PE
9052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
906
3930c88b
PE
907 Port --enable-checking=all to Fedora 14 x86-64.
908 * charset.c (syms_of_charset): Also account for glibc malloc's
909 internal overhead when calculating the initial malloc maximum.
910
cb993c58
PE
911 Port --enable-checking=all to Fedora 14 x86.
912 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
913 Move to lisp.h.
914 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
915 (overrun_check_realloc, overrun_check_free):
916 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
917 That way, xmalloc returns a properly-aligned pointer even if
918 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
919 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
920 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
921 into account when calculating the initial malloc maximum.
922 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
923 Move here from alloc.c, so that charset.c can use it too.
924 Properly align; the old code wasn't right for common 32-bit hosts
925 when configured with --enable-checking=all.
926 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
927 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
928
31bed486
EZ
9292011-09-29 Eli Zaretskii <eliz@gnu.org>
930
04c70788 931 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
932 use EDOM.
933
fbcaa2f3
EZ
9342011-09-28 Eli Zaretskii <eliz@gnu.org>
935
936 * xdisp.c (compute_display_string_end): If there's no display
937 string at CHARPOS, return -1.
938
939 * bidi.c (bidi_fetch_char): When compute_display_string_end
940 returns a negative value, treat the character as a normal
941 character not covered by a display string. (Bug#9624)
942
a239d4e9
JB
9432011-09-28 Juanma Barranquero <lekktu@gmail.com>
944
945 * lread.c (Fread_from_string): Fix typo in docstring.
946
88652fd5
EZ
9472011-09-27 Eli Zaretskii <eliz@gnu.org>
948
949 * xdisp.c (handle_invisible_prop): If invisible text ends on a
950 newline, reseat the iterator instead of bidi-iterating there one
951 character at a time. (Bug#9610)
32c1fffd
SM
952 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
953 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 954
ed497dd4
AS
9552011-09-27 Andreas Schwab <schwab@linux-m68k.org>
956
957 * lread.c (readevalloop): Use correct code for NBSP.
958 (read1): Likewise. (Bug#9608)
959
b2bf61aa
MA
9602011-09-25 Michael Albinus <michael.albinus@gmx.de>
961
962 * dbusbind.c (Fdbus_register_signal): When service is not
963 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
964
32bbb17c
GM
9652011-09-25 Glenn Morris <rgm@gnu.org>
966
967 * buffer.c (truncate-lines): Doc fix.
968
94e0933e
CY
9692011-09-24 Chong Yidong <cyd@stupidchicken.com>
970
971 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
972 (Fset_window_next_buffers): Doc fix.
973
cddde921
GM
9742011-09-24 Glenn Morris <rgm@gnu.org>
975
976 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
977
1260aef1
PE
9782011-09-24 Paul Eggert <eggert@cs.ucla.edu>
979
25b4bfa0
PE
980 Fix minor problems found by static checking.
981 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
982 * indent.c (Fvertical_motion): Fix == vs = typo.
983
e3cbd34b
EZ
9842011-09-24 Eli Zaretskii <eliz@gnu.org>
985
a66cfb1c
SM
986 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
987 Default value is now t. Doc fix.
6bf7006f 988
e3cbd34b 989 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 990 logic when moving up, not only when moving down. Fix the
e3cbd34b 991 confusing name and values of the it_overshoot_expected variable;
32c1fffd 992 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
993
994 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
995 CHARPOS is covered by a display string which includes newlines.
996 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
997 is covered by a display string with embedded newlines.
998
a3de0cbd
MA
9992011-09-24 Michael Albinus <michael.albinus@gmx.de>
1000
1001 * dbusbind.c (Fdbus_register_signal): Add match rule to
1002 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1003 (Fdbus_register_method, Vdbus_registered_objects_table):
1004 Fix docstring.
a3de0cbd 1005
b260039d
JM
10062011-09-24 Jim Meyering <meyering@redhat.com>
1007
32c1fffd 1008 do not ignore write error for any output size
b260039d
JM
1009 The previous change was incomplete.
1010 While it makes emacs --batch detect the vast majority of stdout
1011 write failures, errors were still ignored whenever the output size is
1012 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1013 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1014 && echo FAIL: ignored write error
1015 FAIL: ignored write error
1016 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1017 && echo FAIL: ignored write error
1018 FAIL: ignored write error
1019 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1020
8eca8a7c
AS
10212011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1022
1023 * emacs.c (Fkill_emacs): In noninteractive mode exit
1024 non-successfully if a write error occurred on stdout. (Bug#9574)
1025
3341db62
EZ
10262011-09-21 Eli Zaretskii <eliz@gnu.org>
1027
1028 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1029 the xassert test.
1030
1031 * dispextern.h (struct it): Update the comment documenting what
1032 can it->OBJECT be.
1033
8c203dbf
EZ
10342011-09-20 Eli Zaretskii <eliz@gnu.org>
1035
1036 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1037 a display string, extend search for cursor position to end of row.
1038 (find_row_edges): If the row ends in a newline from a display
1039 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1040 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1041 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1042 non-empty line. Fixes confusing cursor motion with arrow keys at
1043 the beginning of a line that starts with whitespace.
8c203dbf 1044
a4824228
LMI
10452011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1046
1047 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1048 (bug#9493).
1049
33ed493b
CY
10502011-09-18 Chong Yidong <cyd@stupidchicken.com>
1051
1052 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1053 boolean (Bug#9154).
1054
56cd55c8
EZ
10552011-09-18 Eli Zaretskii <eliz@gnu.org>
1056
1057 * xdisp.c (display_line): Record maximum and minimum buffer
1058 positions even if no glyphs were produced (e.g., by a zero-width
1059 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1060 buffer positions that will be removed from the glyph row because
1061 they don't fit.
c02dcedf
EZ
1062 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1063 column is beyond frame width: don't subtract 1 "pixel" when
1064 computing width of the stretch.
3e62b7e0
EZ
1065 (reseat_at_next_visible_line_start): Undo the change made on
1066 2011-09-17 that saved paragraph information and restored it after
1067 the call to `reseat'. (Bug#9545)
56cd55c8 1068
5ed99d36 10692011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1070
1071 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1072 and turn window cursor on if cleared (Bug#9415).
1073
5ed99d36 10742011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1075
1076 * search.c (boyer_moore): Take unibyte characters from pattern
1077 literally. (Bug#9458)
1078
9bade7b2
EZ
10792011-09-18 Eli Zaretskii <eliz@gnu.org>
1080
1081 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1082
e5e9d610
PE
10832011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1084
87e4427a
PE
1085 Fix minor problem found by static checking.
1086 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1087 initialized, to pacify gcc -Wuninitialized.
1088
e5e9d610
PE
1089 * fileio.c: Report proper errno when syscall falls.
1090 (Finsert_file_contents): Save and restore errno,
1091 so that report_file_error outputs the correct diagnostic.
1092 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1093
a1674f0b
EZ
10942011-09-18 Eli Zaretskii <eliz@gnu.org>
1095
1096 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1097
fbfb6dd4
EZ
10982011-09-17 Eli Zaretskii <eliz@gnu.org>
1099
1100 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1101 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1102
bb187662
EZ
11032011-09-17 Eli Zaretskii <eliz@gnu.org>
1104
1137e8b8
EZ
1105 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1106 about the current paragraph and restore it after the call to
1107 reseat.
1108
1109 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1110 (bidi_find_paragraph_start): Search back for paragraph beginning
1111 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1112 (bidi_move_to_visually_next): Only trigger paragraph-related
1113 computations when the last character is a newline or at EOB, not
1114 just any NEUTRAL_B. (Bug#9470)
1115
bb187662
EZ
1116 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1117 truncated lines if point is covered by a display string. (Bug#9524)
1118
2e621251
PE
11192011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1122 (cons_to_x_long): New function.
1123 (lisp_data_to_selection_data): Use it. Correct the test for
1124 short-versus-long data; it was negated. Break out of vector
1125 loop, for efficiency, when a long datum is discovered.
1126
91a15bc6
SM
11272011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1128
1129 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1130
b41c3a35
EZ
11312011-09-16 Eli Zaretskii <eliz@gnu.org>
1132
1133 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1134 GCC PR/17406) by declaring this function with external scope.
1135
7812ba2d
PE
11362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1137
1138 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1139 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1140
cf7edc2a
AS
11412011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1142
1143 * editfns.c (Fformat): Correctly handle text properties on "%%".
1144
bd01620e
EZ
11452011-09-15 Eli Zaretskii <eliz@gnu.org>
1146
1147 * xterm.c (x_draw_composite_glyph_string_foreground):
1148 * w32term.c (x_draw_composite_glyph_string_foreground):
1149 * term.c (encode_terminal_code):
1150 * composite.c (composition_update_it, get_composition_id):
1151 * xdisp.c (get_next_display_element)
1152 (fill_composite_glyph_string): Add comments about special meaning
1153 of TAB characters in a composition.
1154
a02719a3
PE
11552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1158 This occurs when processing a multibyte format.
1159 Problem reported by Wolfgang Jenker.
a02719a3 1160
72589a3c
JB
11612011-09-15 Johan Bockgård <bojohan@gnu.org>
1162
1163 * xdisp.c (try_cursor_movement): Only check for exact match if
1164 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1165
1c14176c
PE
11662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1167
1168 Remove unused external symbols.
1169 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1170 * xdisp.c (calc_pixel_width_or_height): Now static.
1171 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1172 * indent.c (check_display_width):
1173 * w32term.c: Fix comment to match code.
1174 * xterm.c, xterm.h (x_catching_errors): Remove.
1175
d2eea5b5
PE
11762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 * xselect.c: Use signed conversions more consistently (Bug#9498).
1179 (selection_data_to_lisp_data): Assume incoming selection data are
1180 signed integers, not unsigned. This is to be consistent with
1181 outgoing selection data, which was modified to use signed integers
1182 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1183 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1184 expects long, not unsigned long.
1185
46888499
EZ
11862011-09-14 Eli Zaretskii <eliz@gnu.org>
1187
1188 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1189 computation of loop end. Reported by Johan Bockgård
1190 <bojohan@gnu.org>.
1191
ef8ef9fb
CY
11922011-09-13 Chong Yidong <cyd@stupidchicken.com>
1193
1194 * frame.c (Fother_visible_frames_p): Function deleted.
1195
fa819fed
EZ
11962011-09-12 Eli Zaretskii <eliz@gnu.org>
1197
1198 * indent.c (compute_motion): Process display vector front to back
1199 rather than the other way around. (Bug#2496)
1200
2ba8e008
SM
12012011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1202
1203 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1204
20f53c69
CY
12052011-09-11 Chong Yidong <cyd@stupidchicken.com>
1206
1207 * minibuf.c (Fread_from_minibuffer): Doc fix.
1208
d562d7a4
EZ
12092011-09-11 Eli Zaretskii <eliz@gnu.org>
1210
1211 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1212 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1213
1c4d7f3d
LMI
12142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1215
1216 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1217 value for non-existent files.
1218
b885bf36
EZ
12192011-09-11 Eli Zaretskii <eliz@gnu.org>
1220
1221 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1222 set its "size" to -1. This will set the modtime_size field of
1223 the corresponding buffer to -1, which is what
1224 verify-visited-file-modtime expects for files that do not exist.
1225 (Bug#9139)
1226
6612f0bf
PE
12272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1230 here ...
1231 * lisp.h: ... from here. push_key_description is no longer
1232 defined in keyboard.c, so its declaration should not be in
1233 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1234 logically belongs with push_key_description.
1235
dfb3f755
PE
12362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * buffer.h: Include <sys/types.h> instead of <time.h>.
1239 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1240 Problem reported by Herbert J. Skuhra.
1241
3134906c
LMI
12422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1243
1244 * xml.c (parse_region): Make the parsing work for
1245 non-comment-starting XML files again (bug#9144).
1246
8d903f4e
AS
12472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1248
1249 * image.c (gif_load): Fix calculation of bottom and right corner.
1250 (Bug#9468)
1251
80ad64f4
EZ
12522011-09-10 Eli Zaretskii <eliz@gnu.org>
1253
1254 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1255 redisplay in small windows.
1256
208a048d
EZ
12572011-09-09 Eli Zaretskii <eliz@gnu.org>
1258
1259 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1260
9b1c252e
MR
12612011-09-08 Martin Rudalics <rudalics@gmx.at>
1262
1263 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1264 Operate on live windows only.
1265
2949f33b
JB
12662011-09-08 Juanma Barranquero <lekktu@gmail.com>
1267
1268 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1269
e08dcafd
EZ
12702011-09-07 Eli Zaretskii <eliz@gnu.org>
1271
1272 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1273 only under bidi iteration.
1274
115b96bd
JD
12752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1276
1277 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1278
c8199d0f
PE
12792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1282 Without this fix, the command to link temacs failed due to an
1283 undefined symbol __builtin_isnan. This is because
1284 /usr/include/iso/math_c99.h #defines isnan(x) to
1285 __builtin_isnan(x), but the bundled gcc, which identifies itself
1286 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1287 a __builtin_isnan.
1288 * floatfns.c (isnan): #undef, and then #define to a clone of
1289 what's in data.c.
1290 (Fisnan): Always define, since it's always available now.
1291 (syms_of_floatfns): Always define isnan at the Lisp level.
1292
e39b275c 12932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1294
1295 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1296
b2db44d9 12972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1298
f4af5137 1299 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1300 The previous code assumed that file offsets (off_t values) fit in
1301 EMACS_INT variables, which is not true on typical 32-bit hosts.
1302 The code messed up by falsely reporting buffer overflow in cases
1303 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1304 when "big" contains more than 2**29 bytes, even though this
1305 inserts just one byte and does not overflow the buffer.
1306 (Finsert_file_contents): Store file offsets as off_t
1307 values, not as EMACS_INT values. Check for overflow when
1308 converting between EMACS_INT and off_t. When checking for
1309 buffer overflow or for overlap, take the offsets into account.
1310 Don't use EMACS_INT for small values where int suffices.
1311 When checking for overlap, fix a typo: ZV was used where
1312 ZV_BYTE was intended.
1313 (Fwrite_region): Don't assume off_t fits into 'long'.
1314 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1315
ecfc0a49
MA
13162011-09-05 Michael Albinus <michael.albinus@gmx.de>
1317
1318 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1319
6511acf2 13202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1321
0999621a 1322 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1323
1324 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1325 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1326 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1327 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1328 (modify_event_symbol): Do not assume that the length of
1329 name_alist_or_stem is safe to alloca and fits in int.
1330 (Fexecute_extended_command): Likewise for function name and binding.
1331 (Frecursion_depth): Wrap around reliably on integer overflow.
1332 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1333 since some callers pass EMACS_INT values.
1334 (Fsingle_key_description): Don't crash if symbol name contains more
1335 than MAX_ALLOCA bytes.
1336 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1337 (get_minibuffer): Arg is now EMACS_INT, not int.
1338 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1339 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1340 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1341
2be7d702
PE
1342 * dbusbind.c (signature_cat): New function.
1343 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1344 Do not overrun buffer; instead, report string overflow.
1345
9d1df220
PE
1346 * dispnew.c (add_window_display_history): Don't overrun buffer.
1347 Truncate instead; this is OK since it's just a log.
1348
33ef5c64
PE
1349 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1350 even if the time zone offset is outlandishly large.
1351 Don't mishandle offset == INT_MIN.
1352
66c6fdd5
PE
1353 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1354 when creating daemon; the previous buffer-overflow check was incorrect.
1355
d749b01b
PE
1356 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1357 which has the guts of the old verror function.
1358
b5cd1905
PE
1359 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1360 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1361
6e1a67fb
PE
1362 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1363 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1364 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1365 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1366 length of string rather than counting it via multiple sprintfs;
1367 that's simpler and more reliable.
c21721cc
PE
1368 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1369 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1370 sprintf, in case result does not fit in int.
1371
c57b67fc
PE
1372 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1373 (fontset_from_font): Print it.
1374
8a401434
PE
1375 * frame.c (tty_frame_count): Now printmax_t, not int.
1376 (make_terminal_frame, set_term_frame_name): Print it.
1377 (x_report_frame_params): In X, window IDs are unsigned long,
1378 not signed long, so print them as unsigned.
1379 (validate_x_resource_name): Check for implausibly long names,
1380 and don't assume name length fits in 'int'.
1381 (x_get_resource_string): Don't blindly alloca invocation name;
1382 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1383 not fit in int.
1384
6e1a67fb
PE
1385 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1386 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1387 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1388
0df02bf3
PE
1389 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1390 Use esprintf, not sprintf, in case result does not fit in int.
1391
48e30793
PE
1392 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1393 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1394 it as a large positive number.
1395 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1396 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1397
a66ff6d8
PE
1398 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1399 in case result does not fit in int.
1400
aca216ff
PE
1401 * print.c (float_to_string): Detect width overflow more reliably.
1402 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1403 buffer overrun. Don't assume list length fits in 'int'. Treat
1404 print length of 0 as 0, not as infinity; to be consistent with other
1405 uses of print length in this function. Don't overflow print length
1406 index. Don't assume hash table size fits in 'long', or that
1407 vectorlike size fits in 'unsigned long'.
1408
31c286f7
PE
1409 * process.c (make_process): Use printmax_t, not int, to format
1410 process-name gensyms.
1411
55e5faa1
PE
1412 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1413
80f2e268
PE
1414 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1415 to avoid potential buffer overrun.
1416
670741ab
PE
1417 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1418 if X resource line is longer than 512 bytes.
1419
b7163a50
PE
1420 * xfns.c (x_window): Make sprintf buffer a bit bigger
1421 to avoid potential buffer overrun.
1422
ae58ff1f
PE
1423 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1424
c43c8a6a
PE
1425 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1426
3f8236f4
PE
14272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1428
53e9fe90 1429 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1430 Without these, Emacs silently mishandles large integers sometimes.
1431 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1432 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1433
6511acf2
PE
1434 * xdisp.c (try_window_id): Check Emacs fixnum range before
1435 converting to 'int'.
806add1d 1436
6511acf2 1437 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1438 Check that an Emacs fixnum is in range before assigning it to 'int'.
1439 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1440 values converted from Emacs fixnums.
1441 (Frecenter): Don't wrap around a line count if it is out of 'int'
1442 range; instead, treat it as an extreme value.
1443 (Fset_window_configuration, compare_window_configurations):
1444 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1445
6511acf2
PE
1446 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1447 that can exceed INT_MAX. Check that EMACS_INT value is in range
1448 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1449 (match_limit): Don't assume that a fixnum can fit in 'int'.
1450
6511acf2 1451 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1452 exceed INT_MAX.
1453
6511acf2 1454 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1455 (Fvertical_motion): Don't wrap around LINES values that don't fit
1456 in 'int'. Instead, treat them as extreme values. This is good
1457 enough for windows, which can't have more than INT_MAX lines anyway.
1458
fcb901a7
LMI
14592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1460
0f2f6b6d
LMI
1461 * Require libxml/parser.h to avoid compilation warning.
1462
fcb901a7
LMI
1463 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1464
1465 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1466 since this reportedly can destroy thread storage.
1467
6e20a0d4
CY
14682011-08-30 Chong Yidong <cyd@stupidchicken.com>
1469
1470 * syntax.c (find_defun_start): Update all cache variables if
1471 exiting early (Bug#9401).
1472
148ae00e
EZ
14732011-08-30 Eli Zaretskii <eliz@gnu.org>
1474
f6cfbd8f
EZ
1475 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1476
148ae00e
EZ
1477 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1478 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1479 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1480
1481 * term.c (tty_append_glyph): New function.
1482 (produce_stretch_glyph): Static function and its prototype deleted.
1483
a66cfb1c
SM
1484 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1485 Add prototypes.
148ae00e 1486
c4a07a4c
PE
14872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1488
1489 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1490 when checking :margin (Bug#9390).
1491 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1492 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1493 so that the name doesn't mislead. All uses changed.
1494
6bc8cd65
JB
14952011-08-28 Johan Bockgård <bojohan@gnu.org>
1496
1497 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1498 set_tty_hooks.
1499
dca4927e
EZ
15002011-08-27 Eli Zaretskii <eliz@gnu.org>
1501
1502 * xdisp.c (move_it_to): Don't bail out early when reaching
1503 position beyond to_charpos, if we are scanning backwards.
1504 (move_it_vertically_backward): When DY == 0, make sure we get to
1505 the first character in the line after the newline.
1506
f2cad773
PE
15072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1510 (ccl_driver): Do not generate an out-of-range pointer.
1511 (Fccl_execute_on_string): Remove unnecessary check for
1512 integer overflow, noted by Stefan Monnier in
1513 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1514 Remove a FIXME that didn't need fixing.
1515 Simplify the newly-introduced buffer reallocation code.
1516
0cae2cdb
JB
15172011-08-27 Juanma Barranquero <lekktu@gmail.com>
1518
1519 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1520
5fc295a4 15212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1522
70c60eb2 1523 Integer and memory overflow issues (Bug#9196).
726e0ab1 1524
d31850da
PE
1525 * doc.c (get_doc_string): Rework so that
1526 get_doc_string_buffer_size is the actual buffer size, rather than
1527 being 1 less than the actual buffer size; this makes xpalloc more
1528 convenient.
1529
a69fbedb
PE
1530 * image.c (x_allocate_bitmap_record, cache_image):
1531 * xselect.c (Fx_register_dnd_atom):
1532 Simplify previous changes by using xpalloc.
1533
fe5c5d37
PE
1534 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1535 since either will do and ptrdiff_t is convenient with xpalloc.
1536
0065d054
PE
1537 * charset.c (charset_table_size)
1538 (struct charset_sort_data.priority): Now ptrdiff_t.
1539 (charset_compare): Don't overflow if priorities differ greatly.
1540 (Fsort_charsets): Don't assume list length fits in int.
1541 Check for size-calculation overflow when allocating sort data.
1542 (syms_of_charset): Allocate an initial charset table that is
1543 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1544
1545 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1546
1547 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1548 The actual value is always <= INT_MAX, and leaving it unsigned made
1549 overflow checking harder.
1550
1551 * dispextern.h (struct glyph_matrix.rows_allocated)
1552 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1553 with xpalloc. The values are still always <= INT_MAX.
1554
1555 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1556
1557 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1558 (SAFE_NALLOCA): New macro.
1559
1560 * region-cache.c (struct boundary.pos, find_cache_boundary)
1561 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1562 (set_cache_region, invalidate_region_cache)
1563 (revalidate_region_cache, know_region_cache, region_cache_forward)
1564 (region_cache_backward, pp_cache):
1565 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1566 so that ptrdiff_t * can be passed to xpalloc.
1567 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1568 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1569 (pp_cache): Don't assume cache_len fits in int.
1570 * region-cache.h: Adjust extern decls to match.
1571
1572 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1573 EMACS_INT, since either will do, for xpalloc.
1574
1575 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1576 (xnmalloc, xnrealloc, xpalloc): New functions.
1577
726e0ab1
PE
1578 * bidi.c (bidi_shelve_header_size): New constant.
1579 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1580 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1581
51f30bc5 1582 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1583 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1584 (overlay_strings):
1585 Don't update size of array until after memory allocation succeeds,
1586 because xmalloc/xrealloc may not return.
0065d054
PE
1587 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1588 now that we have proper integer overflow checking.
1589 (record_overlay_string, overlay_strings): Catch overflows when
1590 calculating size of overlay_str_buf.
726e0ab1 1591
0065d054
PE
1592 * callproc.c (Fcall_process): Check for size overflow when
1593 calculating size of args2.
1594 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1595 Normally we prefer signed values, but sticking with ptrdiff_t would
1596 require adding more-complicated checks.
726e0ab1
PE
1597
1598 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1599 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1600 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1601 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1602
1603 * character.c (Fstring): Check for size-calculation overflow.
1604
1605 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1606 unnecessary integer overflow. Check for size overflow.
1607 (encode_coding_object): Don't update size until xmalloc succeeds.
1608
1609 * composite.c (get_composition_id): Check for overflow in glyph
1610 length calculations.
1611
1612 Integer and memory overflow fixes for display code.
1613 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1614 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1615 (scrolling_window): Check for overflow in size calculations.
1616 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1617 Don't assume glyph table len fits in int.
1618 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1619 (row_table_size): Now ptrdiff_t, not int.
1620 (scrolling_window): Avoid overflow in size calculations.
1621 Don't update size until allocation succeeds.
1622 * fns.c (concat): Check for overflow in size calculations.
1623 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1624 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1625 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1626
1627 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1628 (get_doc_string): Check for size calculation overflow.
1629 Don't update size until allocation succeeds.
1630 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1631 EMACS_INT, where ptrdiff_t will do.
1632 (Fsubstitute_command_keys): Check for string overflow.
1633
1634 * editfns.c (set_time_zone_rule): Don't assume environment length
1635 fits in int.
1636 (message_length): Now ptrdiff_t, not int.
1637 (Fmessage_box): Don't update size until allocation succeeds.
1638 Don't assume message length fits in int.
1639 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1640
0065d054
PE
1641 * emacs.c (main): Do not reallocate argv, since there is a null at
1642 the end that can be overwritten, and this way there's no need to
1643 worry about size-calculation overflow.
1644 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1645
1646 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1647 alloc succeeds.
1648 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1649
1650 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1651 (x_set_scroll_bar_width, x_figure_window_size):
1652 Check for integer overflow.
1653 (x_set_alpha): Do not assume XINT fits in int.
1654
1655 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1656 This is for the members text_lines, text_cols, total_lines, total_cols,
1657 where the system imposes an 'int' limit.
1658
1659 * fringe.c (Fdefine_fringe_bitmap):
1660 Don't update size until alloc works.
1661
1662 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1663 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1664
1665 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1666 Check for size-calculation overflow.
1667 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1668 do, as we prefer signed integers.
1669 (id_to_widget.max_size, id_to_widget.used)
1670 (xg_store_widget_in_map, xg_remove_widget_from_map)
1671 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1672 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1673 Use and return ptrdiff_t, not int.
1674 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1675 * gtkutil.h: Change prototypes to match the above.
1676
1677 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1678 are duplicate now that they've been promoted to lisp.h.
1679 (x_allocate_bitmap_record, x_alloc_image_color)
1680 (make_image_cache, cache_image, xpm_load):
1681 Don't update size until alloc is done.
1682 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1683 (x_detect_edges):
3256efce 1684 Check for size calculation overflow.
726e0ab1
PE
1685 (ct_colors_allocated_max): New constant.
1686 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1687 overflow.
3256efce 1688
726e0ab1
PE
1689 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1690 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1691 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1692 Use ptrdiff_t, not int, to count maps.
1693 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1694 calculations. Don't update size until allocation succeeds.
1695 Redo calculations to avoid overflow.
726e0ab1
PE
1696 * keyboard.h: Change prototypes to match the above.
1697
1698 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1699 to count maps.
1700 (current_minor_maps): Check for size calculation overflow.
1701 * keymap.h: Change prototypes to match the above.
1702
1703 * lread.c (read1, init_obarray): Don't update size until alloc done.
1704
1705 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1706 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1707
726e0ab1
PE
1708 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1709 Now ptrdiff_t, not int.
1710 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1711 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1712
1713 * process.c (Fnetwork_interface_list): Check for overflow
1714 in size calculation.
1715
1716 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1717
1718 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1719 overflow. Don't bother calling xmalloc when xrealloc will do.
1720
1721 * search.c (Freplace_match): Check for size calculation overflow.
1722 (Fset_match_data): Don't assume list lengths fit in 'int'.
1723
1724 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1725 for command line length. Do not attempt to address one before the
1726 beginning of an array, as that's not portable.
1727
1728 * term.c (max_frame_lines): Remove; unused.
1729 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1730 not int.
1731 (encode_terminal_code, calculate_costs): Check for size
1732 calculation overflow.
1733 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1734 table lengths and related sizes. Don't update size until alloc
1735 done. Redo calculations to avoid overflow.
1736 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1737
1738 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1739 subtracting pointers.
1740 (gobble_line): Check for overflow more carefully. Don't update size
1741 until alloc done.
1742
1743 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1744 Don't update size until alloc done.
1745 Redo size calculations to avoid overflow.
1746 Check for size calculation overflow.
0065d054 1747 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1748
1749 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1750 Use ptrdiff_t, not int, for sizes.
1751 (store_mode_line_noprop_char): Don't update size until alloc done.
1752
0065d054
PE
1753 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1754 Use ptrdiff_t, not int, for sizes.
1755 (Finternal_make_lisp_face, cache_face):
1756 Check for size calculation overflow.
1757 (cache_face): Treat size calculation overflows as if they were
1758 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1759
1760 * xfns.c (x_encode_text, x_set_name_internal)
1761 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1762 sizes, since they can exceed INT_MAX in size. Check for size
1763 calculation overflow.
1764
0065d054
PE
1765 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1766 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1767 Don't update size until alloc done.
1768
0065d054 1769 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1770 as sprintf is limited to int lengths.
1d526e2f 1771
252c5ee1
PE
1772 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1773 (X_LONG_MIN): New macros.
864d7ce7
PE
1774 Use them to make the following changes clearer.
1775 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1776 This change doesn't affect the value now, but it may help remind
1777 future maintainers not to raise the value too much later.
1778 (SELECTION_QUANTUM): Remove, replacing with ...
1779 (selection_quantum): ... new function, which avoids overflow.
1780 All uses changed.
1781 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1782 assumption that selection length fits in 'int'.
1783 (x_reply_selection_request, x_handle_selection_request)
1784 (x_get_window_property, receive_incremental_selection)
1785 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1786 (lisp_data_to_selection_data, clean_local_selection_data):
1787 Use ptrdiff_t, not int, to record length of selection.
1788 (x_reply_selection_request, x_get_window_property)
1789 (receive_incremental_selection, x_property_data_to_lisp):
1790 Redo calculations to avoid overflow.
1791 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1792 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1793 something.
1794 (x_get_window_property, receive_incremental_selection)
1795 (lisp_data_to_selection_data, x_property_data_to_lisp):
1796 Check for size-calculation overflow.
1797 (x_get_window_property, receive_incremental_selection)
1798 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1799 Don't store size until memory allocation succeeds.
1800 (x_get_window_property): Plug memory leak on memory exhaustion.
1801 Don't double-block input; malloc is safe here. Don't assume 2**34
1802 - 4 fits in unsigned long. Add an xassert to check
1803 XGetWindowProperty overflow. Be more careful about overflow
1804 calculations, and distinguish size from memory overflow better.
1805 (receive_incremental_selection): When tracing, don't assume
1806 unsigned int is less than INT_MAX.
1807 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1808 harmful) conversions of unsigned short to int.
1809 (lisp_data_to_selection_data): Don't assume that integers
1810 in the range -65535 through -1 fit in an X unsigned short.
1811 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1812 result parameters unless successful. Rely on cons_to_unsigned
1813 to report problems with elements; the old code wasn't right anyway.
1814 (x_check_property_data): Check for int overflow; we cannot use
1815 a wider type due to X limits.
1816 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1817
726e0ab1 1818 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1819
0065d054
PE
1820 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1821 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1822 (x_color_cells): Don't store size until memory allocation succeeds.
1823 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1824 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1825 (x_term_init): Don't assume length fits in int (sprintf is limited
1826 to int size).
bc18e09d 1827
ebfa62c0
PE
1828 Use ptrdiff_t for composition IDs.
1829 * character.c (lisp_string_width):
1830 * composite.c (composition_table_size, n_compositions)
1831 (get_composition_id, composition_gstring_from_id):
1832 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1833 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1834 * window.c (Frecenter):
1835 Use ptrdiff_t, not int, for composition IDs.
1836 * composite.c (get_composition_id): Check for integer overflow.
1837 * composite.h: Adjust prototypes to match the above changes.
1838
d3411f89
PE
1839 Use ptrdiff_t for hash table indexes.
1840 * category.c (hash_get_category_set):
1841 * ccl.c (ccl_driver):
1842 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1843 * coding.c (coding_system_charset_list, detect_coding_system):
1844 * coding.h (struct coding_system.id):
1845 * composite.c (get_composition_id, gstring_lookup_cache):
1846 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1847 * image.c (xpm_get_color_table_h):
1848 * lisp.h (hash_lookup, hash_put):
1849 * minibuf.c (Ftest_completion):
1850 Use ptrdiff_t for hash table indexes, not int (which is too
1851 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1852 32-bit --with-wide-int hosts).
1853
e097a6fa
PE
1854 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1855 Add a FIXME comment about memory leaks.
1856 (syms_of_charset): Don't assume xmalloc returns.
1857
5637687f
PE
1858 Don't assume that stated character widths fit in int.
1859 * character.c (Fchar_width, c_string_width, lisp_string_width):
1860 * character.h (CHAR_WIDTH):
1861 * indent.c (MULTIBYTE_BYTES_WIDTH):
1862 Use sanitize_char_width to avoid undefined and/or bad behavior
1863 with outlandish widths.
a66cfb1c 1864 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1865 now that we have two such functions. All uses changed.
1866 (sanitize_char_width): New inline function.
1867
a2271ba2
PE
1868 Don't assume that tab-width fits in int.
1869 * character.h (sanitize_width): New inline function.
1870 (SANE_TAB_WIDTH): New macro.
1871 (ASCII_CHAR_WIDTH): Use it.
1872 * indent.c (sane_tab_width): Remove. All uses replaced by
1873 SANE_TAB_WIDTH (current_buffer).
1874 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1875
18c52557
PE
1876 * fileio.c: Integer overflow issues with file modes.
1877 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1878
caeeedc1
PE
1879 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1880 Remove unreachable code.
1881 (read_hex, load_charset_map_from_file): Check for integer overflow.
1882
50849c52
PE
1883 * xterm.c: don't go over XClientMessageEvent limit
1884 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1885 (x_send_scroll_bar_event): Likewise. Check that the size does not
1886 exceed limits imposed by XClientMessageEvent, as well as the usual
1887 ptrdiff_t and size_t limits.
1888
b13995db
PE
1889 * keyboard.c: Overflow, signedness and related fixes.
1890 (make_lispy_movement): Use same integer type in forward decl
1891 that is used in the definition.
1892 (read_key_sequence, keyremap_step):
1893 Change bufsize argument back to int, undoing my 2011-03-30 change.
1894 We prefer signed types, and int is wide enough here.
1895 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1896 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1897 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1898 length, not size_t. Use ptrdiff_t for index, not int.
1899 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1900 possibility of integer overflow.
1901
13464394
PE
1902 Overflow, signedness and related fixes for images.
1903
1904 * dispextern.h (struct it.stack[0].u.image.image_id)
1905 (struct_it.image_id, struct image.id, struct image_cache.size)
1906 (struct image_cache.used, struct image_cache.ref_count):
1907 * gtkutil.c (update_frame_tool_bar):
1908 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1909 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1910 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1911 * nsmenu.m (update_frame_tool_bar):
1912 * xdisp.c (calc_pixel_width_or_height):
1913 * xfns.c (image_cache_refcount):
1914 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1915 on typical 64-bit hosts.
1916
1917 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1918 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1919 Omit unnecessary casts to int.
1920 (parse_image_spec): Check that integers fall into 'int' range
1921 when the callers expect that.
1922 (image_ascent): Redo ascent calculation to avoid int overflow.
1923 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1924 (lookup_image): Remove unnecessary tests.
1925 (xbm_image_p): Locals are now of int, not EMACS_INT,
1926 since parse_image_check makes sure they fit into int.
1927 (png_load, gif_load, svg_load_image):
1928 Prefer int to unsigned where either will do.
1929 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1930 old tiff_error_handler and tiff_warning_handler.
1931 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1932 stack buffer overflows. It uses only the features of vsnprintf
1933 that are common to both POSIX and native Microsoft.
1934 (tiff_error_handler, tiff_warning_handler): Use it.
1935 (tiff_load, gif_load, imagemagick_load_image):
1936 Don't assume :index value fits in 'int'.
1937 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1938 (imagemagick_load_image): Check that crop parameters fit into
1939 the integer types that MagickCropImage accepts. Don't assume
1940 Vimagemagick_render_type has a nonnegative value. Don't assume
1941 size_t fits in 'long'.
1942 (gs_load): Use printmax_t to print the widest integers possible.
1943 Check for integer overflow when computing image height and width.
1944
c11821d4
EZ
19452011-08-26 Eli Zaretskii <eliz@gnu.org>
1946
1947 * xdisp.c (redisplay_window): Don't force window start if point
1948 will be invisible in the resulting window. (Bug#9324)
1949
0c95fcf7
EZ
19502011-08-25 Eli Zaretskii <eliz@gnu.org>
1951
1952 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1953 the display spec is of the form `(space ...)'.
1954 (handle_display_spec): Return the value returned by
1955 handle_single_display_spec, not just 1 or zero.
1956 (handle_single_display_spec): If the display spec is of the form
1957 `(space ...)', and specifies display in the text area, return 2
1958 rather than 1.
fee65a97 1959 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1960 accurately, and prefer exact match for point under bidi.
1961 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1962
1963 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1964 into disp_prop; all users changed.
1965
1966 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1967 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1968 for the text covered by the display property.
1969
e4ed06f1
CY
19702011-08-25 Chong Yidong <cyd@stupidchicken.com>
1971
1972 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1973 Change return value to nil.
1974 (Frecord_buffer): Delete unused function.
1975
f67cdd7f
EZ
19762011-08-24 Eli Zaretskii <eliz@gnu.org>
1977
5980d4c6
EZ
1978 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1979 buffers, return left-to-right.
8610fe8b
EZ
1980 (set_cursor_from_row): Consider candidate row a win if its glyph
1981 represents a newline and point is on that newline. Fixes cursor
1982 positioning on the newline at EOL of R2L text within L2R
1983 paragraph, and vice versa.
1984 (try_cursor_movement): Check continued rows, in addition to
1985 continuation rows. Fixes unwarranted scroll when point enters a
1986 continued line of R2L text within an L2R paragraph, or vice versa.
1987 (cursor_row_p): Consider the case of point being equal to
1988 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1989 from the end of a short line to the beginning of a continued line
1990 of R2L text within L2R paragraph.
1991 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1992 composed characters.
5980d4c6 1993
f67cdd7f
EZ
1994 * bidi.c (bidi_check_type): Use xassert.
1995 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1996 members.
1997
bca633fb
EZ
19982011-08-23 Eli Zaretskii <eliz@gnu.org>
1999
2000 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2001 a character.
2002
4a5885a7
CY
20032011-08-23 Chong Yidong <cyd@stupidchicken.com>
2004
2005 * nsfont.m (ns_otf_to_script): Fix typo.
2006
0902a04e
KH
20072011-08-22 Kenichi Handa <handa@m17n.org>
2008
2009 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2010 extra slot even if the purpose is char-code-property-table.
2011
1a2e6670
EZ
20122011-08-23 Eli Zaretskii <eliz@gnu.org>
2013
8ddde651
EZ
2014 * xdisp.c (redisplay_window): When computing centering_position,
2015 account for the height of the header line. (Bug#8874)
2016
425cc014
EZ
2017 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2018 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2019 candidate is selected by the mouse, and that candidate has a
2020 composed character under the mouse.
2021
1a2e6670
EZ
2022 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2023 coordinates reported by pos-visible-in-window-p for a composed
2024 character in column zero.
2025
8b76d6f8
SM
20262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2027
2028 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2029
dac347dd
EZ
20302011-08-22 Eli Zaretskii <eliz@gnu.org>
2031
2032 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2033 consider it a hit if to_charpos is anywhere in the range of the
2034 composed buffer positions.
2035
e013fb34
CY
20362011-08-22 Chong Yidong <cyd@stupidchicken.com>
2037
2038 * image.c (gif_load): Don't assume that each subimage has the same
2039 dimensions as the base image. Handle disposal method that is
2040 "undefined" by the gif spec (Bug#9335).
2041
bd1ba3e8
CY
20422011-08-20 Chong Yidong <cyd@stupidchicken.com>
2043
2044 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2045 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2046
54a1215b
EZ
20472011-08-19 Eli Zaretskii <eliz@gnu.org>
2048
823564e5
EZ
2049 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2050 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2051 from an Org mode buffer to a Speedbar frame.
2052
54a1215b
EZ
2053 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2054 a composition, take its buffer position from IT->cmp_it.charpos.
2055 Fixes cursor positioning at the beginning of a line that begins
2056 with a composed character.
2057
9778ebcc
EZ
20582011-08-18 Eli Zaretskii <eliz@gnu.org>
2059
0be6ee06
EZ
2060 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2061 character bidirectional type, use STRONG_L instead. Fixes crashes
2062 in a buffer produced by `describe-categories'.
2063
9778ebcc
EZ
2064 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2065 members before the level stack, so they would be saved and
2066 restored when copying iterator state. Fixes incorrect reordering
2067 around TABs covered by display properties.
2068
156bffbe
AS
20692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2070
2071 * process.c (Fnetwork_interface_list): Correctly determine buffer
2072 size.
2073
72ad093b
CY
20742011-08-17 Chong Yidong <cyd@stupidchicken.com>
2075
2076 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2077 (internal_condition_case_2, internal_condition_case_n):
2078 Remove unnecessary aborts (Bug#9081).
72ad093b 2079
35774242
EZ
20802011-08-17 Eli Zaretskii <eliz@gnu.org>
2081
2082 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2083 has no `load' handler, try opening the file locally. (Bug#9311)
2084
db76dd85
KB
20852011-08-16 Ken Brown <kbrown@cornell.edu>
2086
2087 * gmalloc.c: Expand comment.
2088
b215eee5
EZ
20892011-08-16 Eli Zaretskii <eliz@gnu.org>
2090
2091 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2092 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2093
a4579d33
KB
20942011-08-16 Ken Brown <kbrown@cornell.edu>
2095
2096 Fix memory allocation problems in Cygwin build (Bug#9273).
2097
2098 * unexcw.c ( __malloc_initialized): Declare external variable.
2099 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2100
8b76d6f8
SM
2101 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2102 New variables.
a4579d33
KB
2103 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2104 dumped emacs.
2105 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2106 in the static heap.
2107 [CYGWIN] (special_realloc): New function.
2108 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2109 requests to realloc storage in the static heap.
2110
3ebec551
PE
21112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2112
2113 * bidi.c (bidi_initialize): Remove unused local.
2114
9fd8be00
EZ
21152011-08-15 Eli Zaretskii <eliz@gnu.org>
2116
474a8465
EZ
2117 * biditype.h: File removed.
2118
2119 * bidimirror.h: File removed.
2120
2121 * deps.mk (bidi.o): Remove biditype.h and
2122 bidimirror.h.
2123
2124 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
2125 bidimirror.h.
2126
2127 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2128
2129 * chartab.c: Improve commentary for the uniprop_table API.
2130
32413314
EZ
2131 * bidi.c (bidi_paragraph_init): Support zero value of
2132 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2133 (bidi_initialize): Use uniprop_table instead of including
2134 biditype.h and bidimirror.h.
32413314 2135
9fd8be00
EZ
2136 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2137 coordinates of the iterator when restoring from ppos_it.
2138 (Bug#9296)
2139
5cf2b69b
KH
21402011-08-14 Kenichi Handa <handa@m17n.org>
2141
2142 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2143 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2144
daf17d00
EZ
21452011-08-14 Eli Zaretskii <eliz@gnu.org>
2146
2147 * xdisp.c (move_it_in_display_line_to): Don't invoke
2148 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2149 ppos_it. Fixes vertical cursor motion when line beginning is
2150 covered by an image. (Bug#9296)
2151
08e3161a
JD
21522011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2153
2154 * nsterm.h (ns_run_ascript): Declare.
2155 (NSAPP_DATA2_RUNASSCRIPT): Define.
2156
2157 * nsfns.m (as_script, as_result, as_status): New static variables.
2158 (ns_run_ascript): New function.
5e617bc2 2159 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2160 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2161 the event loop. Get status from as_status (Bug#7276).
2162
2163 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2164 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2165 the event loop (Bug#7276).
2166
a3720aa2
AS
21672011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2168
2169 * gnutls.c (QCgnutls_bootprop_priority)
2170 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2171 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2172 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2173 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2174 (QCgnutls_bootprop_verify_hostname_error)
2175 (QCgnutls_bootprop_callbacks_verify): Rename from
2176 Qgnutls_bootprop_..., all uses changed.
2177
2178 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2179 uses changed.
2180
0a0d27fb
PE
21812011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2182
19d5c50c
PE
2183 * xfaces.c (Qframe_set_background_mode): Now static.
2184 * dispextern.h (Qframe_set_background_mode): Remove decl.
2185
0a0d27fb
PE
2186 * process.c (Fnetwork_interface_info): Declare local only if needed.
2187
377538cb
JD
21882011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2189
2190 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2191 (Fnetwork_interface_list): Allocate in increments of bytes instead
2192 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2193 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2194 sockaddr.
2195 (struct ifflag_def): notrailers is smart on OSX.
2196 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2197 Get hardware address with getifaddrs if available.
2198
08fff70c
EZ
21992011-08-12 Eli Zaretskii <eliz@gnu.org>
2200
2201 * xdisp.c (iterate_out_of_display_property): xassert that
2202 IT->position is set to within IT->object's boundaries. Break from
2203 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2204 when IT->position is set up wrongly due to some bug.
2205 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2206 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2207 entry. Force push_it to save on the stack the current
2208 buffer/string position, to be restored by pop_it. Fix flags in
2209 the iterator structure wrt the object coming from a display
2210 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2211 properties. (Bug#9284)
2212
7be1c708 22132011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2214
7be1c708
CY
2215 * fontset.c (fontset_get_font_group): Add proper type checks.
2216 (Bug#9172)
aac0c6e3 2217
7be1c708 22182011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2219
7be1c708
CY
2220 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2221 and LC_VERSION_MIN_MACOSX.
2222 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2223 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2224
97bb72a6
EZ
22252011-08-08 Eli Zaretskii <eliz@gnu.org>
2226
2227 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2228 no-display-properties-and-no-overlays under bidi display.
2229 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2230 properties and overlays.
97bb72a6 2231
d5617611
CY
22322011-08-08 Chong Yidong <cyd@stupidchicken.com>
2233
37e11a63
CY
2234 * editfns.c (Fset_time_zone_rule): Document relationship with the
2235 setenv function.
2236
d5617611
CY
2237 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2238 the font entity extracted from the cache (Bug#8109).
2239
58872834
CY
22402011-08-07 Chong Yidong <cyd@stupidchicken.com>
2241
2242 * composite.c (autocmp_chars): Don't reset point. That is done by
2243 restore_point_unwind (Bug#5984).
2244
75bfc667
JL
22452011-08-07 Juri Linkov <juri@jurta.org>
2246
2247 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2248 to show the arg `TIME' instead of `TIMEVAL'.
2249
d1410150
EZ
22502011-08-06 Eli Zaretskii <eliz@gnu.org>
2251
2252 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2253 display property strides EOL and includes a newline, as in
2254 longlines-mode. (Bug#9254)
75b771e4
EZ
2255 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2256 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2257
2258 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2259 is non-zero, even if the data buffer is NULL. Fixes a crash in
2260 vertical-motion with longlines-mode. (Bug#9254)
2261
35928349
EZ
22622011-08-05 Eli Zaretskii <eliz@gnu.org>
2263
ec7cc85b
EZ
2264 * bidi.c <bidi_cache_total_alloc>: Now static.
2265 (bidi_initialize): Initialize bidi_cache_total_alloc.
2266
8b76d6f8 2267 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2268 cache. (Bug#9221)
2269
2270 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2271 amount allocated this far in `bidi_cache_total_alloc'.
2272 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2273 non-zero, only free the data buffer without restoring the cache
2274 contents. All callers changed.
2275
2276 * dispextern.h (bidi_unshelve_cache): Update prototype.
2277
2278 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2279 (move_it_in_display_line, move_it_to)
2280 (move_it_vertically_backward, move_it_by_lines): Replace the call
2281 to xfree to an equivalent call to bidi_unshelve_cache.
2282 (move_it_in_display_line_to): Fix logic of returning
412b6358 2283 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2284
e2e2423b
EZ
22852011-08-05 Eli Zaretskii <eliz@gnu.org>
2286
2287 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2288 came from a string character with a `cursor' property. (Bug#9229)
2289
ae9e757a
JD
22902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2291
2292 * Makefile.in (LIB_PTHREAD): New variable.
2293 (LIBES): Add LIB_PTHREAD (Bug#9216).
2294
2295 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2296 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2297
213bd7f2
AS
22982011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2299
2300 * regex.c (re_iswctype): Remove some redundant boolean
2301 conversions.
2302
99aaf75f
JD
23032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2304
2305 * xterm.c (x_find_topmost_parent): New function.
2306 (x_set_frame_alpha): Find topmost parent window with
2307 x_find_topmost_parent and set the property there also (bug#9181).
2308 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2309
c74e9d86
PE
23102011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * callproc.c (Fcall_process): Avoid vfork clobbering
2313 the local vars buffer, coding_systems, current_dir.
2314
640c8776
SM
23152011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2316
2317 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2318
f26d0e4c
PE
23192011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2320
8a10d76c
PE
2321 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2322 so that it is not optimized away.
2323
f26d0e4c
PE
2324 * xdisp.c (compute_display_string_pos): Remove unused local.
2325
55439c61
EZ
23262011-08-02 Eli Zaretskii <eliz@gnu.org>
2327
2328 Fix slow cursor motion and scrolling in large buffers with
2329 selective display, like Org Mode buffers. (Bug#9218)
2330
2331 * dispextern.h (struct bidi_it): New member disp_prop_p.
2332
2333 * xdisp.c: Remove one-slot cache of display string positions.
2334 (compute_display_string_pos): Accept an additional argument
5e617bc2 2335 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2336 for a display string or property. If found, set DISP_PROP_P
2337 non-zero.
2338
2339 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2340 DISP_PROP_P, and pass it to compute_display_string_pos.
2341 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2342 non-zero. All callers of bidi_fetch_char changed.
2343
fb33fa43
SM
23442011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2345
2346 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2347
b099e063
DM
23482010-12-03 Don March <don@ohspite.net>
2349
2350 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2351 last character M-[char] is translated to ESC [char] (bug#7541).
2352
5cc7f7af
KH
23532011-08-02 Kenichi Handa <handa@m17n.org>
2354
d0fffa3f 2355 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2356
2357 * chartab.c (uniprop_table): Make it non-static.
2358
525d5e6e
EZ
23592011-08-01 Eli Zaretskii <eliz@gnu.org>
2360
2361 * xdisp.c (forward_to_next_line_start): Accept additional argument
2362 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2363 on the newline.
2364 (reseat_at_next_visible_line_start): Use the bidi iterator state
2365 returned by forward_to_next_line_start to restore the state of
2366 it->bidi_it after backing up to previous newline. (Bug#9212)
2367
31011111
AS
23682011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2369
2370 * regex.c (re_comp): Protoize.
2371 (re_exec): Fix return type.
2372 (regexec): Fix type of `ret'. (Bug#9203)
2373
476371c4
PE
23742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2375
e5d76069
PE
2376 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2377 This is needed if max-image-size is a floating-point number.
2378
9a79b20c
AS
23792011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2380
2381 * print.c (print_object): Print empty symbol as ##.
2382
2383 * lread.c (read1): Read ## as empty symbol.
2384
d8c2fa78
AA
23852011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2386
2387 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2388 setting frame foreground color (Bug#9175).
2389 (x_set_background_color): Likewise.
2390
ffe57a7a
AA
2391 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2392 contents (Bug#9176).
2393 (EmacsTooltip -init): Remove bezels and add shadows to
2394 tooltip windows.
2395
bf3492a5
AA
2396 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2397 or scroll bar (Bug#8470).
2398
d55e9c53
AA
2399 * nsfont.m (nsfont_open): Remove assignment to voffset and
2400 unnecessary vars hshink, expand, hd, full_height, min_height.
2401 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2402
2403 * nsterm.h (nsfont_info): Remove voffset field.
2404
d8c2fa78 24052011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2406
2407 Implement strike-through and overline on NextStep (Bug#8863).
2408
2409 * nsfont.m (nsfont_open): Use underline position provided by font,
2410 instead of hard-coded value of 2.
2411 (nsfont_draw): Call ns_draw_text_decoration instead.
2412
2413 * nsterm.h: Add declaration for ns_draw_text_decoration.
2414
2415 * nsterm.m (ns_draw_text_decoration): New function for drawing
2416 underline, overline, and strike-through.
2417 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2418 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2419 accommodate underlining, etc.
4843aac3 2420
4cc60b9b
EZ
24212011-07-28 Eli Zaretskii <eliz@gnu.org>
2422
bc7ece87
EZ
2423 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2424 default.
4cc60b9b 2425
476371c4
PE
24262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2427
66606eea
PE
2428 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2429 Without this fix, if a signal arrives just after memory fills up,
2430 'malloc' might be invoked reentrantly.
2431
476371c4
PE
2432 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2433 In other words, assume that every image size is allowed, on non-X
2434 hosts. This assumption is probably wrong, but it lets Emacs compile.
2435
f3fcc40d
AS
24362011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2437
2438 * regex.c (re_iswctype): Convert return values to boolean.
2439
350c992f
EZ
24402011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2441
2442 * xdisp.c (compute_display_string_pos): Don't use cached display
2443 string position if the buffer had its restriction changed.
2444 (Bug#9184)
2445
5266b4bb
PE
24462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2447
2448 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2449
2573a837 24502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2451
41f55ccd 2452 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2453
39e378da
PE
2454 * bidi.c: Integer size and overflow fixes.
2455 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2456 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2457 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2458 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2459 (bidi_find_other_level_edge):
2460 Use ptrdiff_t instead of EMACS_INT where either will do.
2461 This works better on 32-bit hosts configured --with-wide-int.
2462 (bidi_cache_ensure_space): Check for size-calculation overflow.
2463 Use % rather than repeated addition, for better worst-case speed.
2464 Don't set bidi_cache_size until after xrealloc returns, because it
2465 might not return.
2466 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2467 (bidi_cache_ensure_space): Also check that the bidi cache size
2468 does not exceed that of the largest Lisp string or buffer. See Eli
2469 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2470
5e927815
PE
2471 * alloc.c (__malloc_size_t): Remove.
2472 All uses replaced by size_t. See Andreas Schwab's note
2473 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2474
ca4aa935
PE
2475 * image.c: Improve checking for integer overflow.
2476 (check_image_size): Assume that f is nonnull, since
2477 it is always nonnull in practice. This is one less thing to
2478 worry about when checking for integer overflow later.
2479 (x_check_image_size): New function, which checks for integer
2480 overflow issues inside X.
2481 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2482 This removes the need for a memory_full check.
2483 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2484 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2485 (xbm_read_bitmap_data): Change locals back to 'int', since
2486 their values must fit in 'int'.
2487 (xpm_load_image, png_load, tiff_load):
2488 Invoke x_create_x_image_and_pixmap earlier,
2489 to avoid much needless work if the image is too large.
2490 (tiff_load): Treat overly large images as if
2491 x_create_x_image_and_pixmap failed, not as malloc failures.
2492 (gs_load): Use x_check_image_size.
2493
5f8f9cc2
PE
2494 * gtkutil.c: Omit integer casts.
2495 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2496 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2497
5adf60bc
PE
2498 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2499
c8907a93
PE
2500 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2501 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2502 would wrongly return t on a 64-bit host.
2503
e3c25c68
PE
2504 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2505 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2506 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2507 and therefore cause GCC to emit a bogus diagnostic in some cases.
2508
3f791afe
PE
2509 * image.c: Integer signedness and overflow and related fixes.
2510 This is not an exhaustive set of fixes, but it's time to
2511 record what I've got.
2512 (lookup_pixel_color, check_image_size): Remove redundant decls.
2513 (check_image_size): Don't assume that arbitrary EMACS_INT values
2514 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2515 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2516 (tiff_load, imagemagick_load_image):
2517 Check for overflow in size calculations.
2518 (x_create_x_image_and_pixmap): Remove unnecessary test for
2519 xmalloc returning NULL; that can't happen.
2520 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2521 (xpm_color_bucket): Use better integer hashing function.
2522 (xpm_cache_color): Don't possibly over-allocate memory.
2523 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2524 (gif_memory_source):
2525 Use ptrdiff_t, not int or size_t, to record sizes.
2526 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2527 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2528 either works, as we prefer signed integers.
2529 (tiff_read_from_memory, tiff_write_from_memory):
2530 Return tsize_t, not size_t, since that's what the TIFF API wants.
2531 (tiff_read_from_memory): Don't fail simply because the read would
2532 go past EOF; instead, return a short read.
2533 (tiff_load): Omit no-longer-needed casts.
2534 (Fimagemagick_types): Don't assume size fits into 'int'.
2535
3cc5a532
PE
2536 Improve hashing quality when configured --with-wide-int.
2537 * fns.c (hash_string): New function, taken from sxhash_string.
2538 Do not discard information about ASCII character case; this
2539 discarding is no longer needed.
2540 (sxhash-string): Use it. Change sig to match it. Caller changed.
2541 * lisp.h: Declare it.
2542 * lread.c (hash_string): Remove, since we now use fns.c's version.
2543 The fns.c version returns a wider integer if --with-wide-int is
2544 specified, so this should help the quality of the hashing a bit.
2545
b312a492
PE
2546 * emacs.c: Integer overflow minor fix.
2547 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2548 Define only if GNU_LINUX.
2549 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2550
dfd153ae
PE
2551 * dispnew.c: Integer signedness and overflow fixes.
2552 Remove unnecessary forward decls, that were a maintenance hassle.
2553 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2554 All uses changed.
2555 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2556 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2557 (prepare_desired_row, line_draw_cost):
2558 Use int, not unsigned, where either works.
2559 (save_current_matrix, restore_current_matrix):
2560 Use ptrdiff_t, not size_t, where either works.
2561 (init_display): Check for overflow more accurately, and without
2562 relying on undefined behavior.
2563
a81d11a3
PE
2564 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2565 Remove, replacing with the new symbols in lisp.h. All uses changed.
2566 * fileio.c (make_temp_name):
2567 * filelock.c (lock_file_1, lock_file):
2568 * xdisp.c (message_dolog):
2569 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2570 Use pMd etc. instead.
2571 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2572 replacing the pWIDE etc. symbols removed from editfns.c.
2573
3300e6fd
PE
2574 * keyboard.h (num_input_events): Now uintmax_t.
2575 This is (very slightly) less likely to mess up due to wraparound.
2576 All uses changed.
2577
fd05c7e9
PE
2578 * buffer.c: Integer signedness fixes.
2579 (alloc_buffer_text, enlarge_buffer_text):
2580 Use ptrdiff_t rather than size_t when either will do, as we prefer
2581 signed integers.
2582
903fe15d
PE
2583 * alloc.c: Integer signedness and overflow fixes.
2584 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2585 (__malloc_size_t): Default to size_t, not to int.
2586 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2587 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2588 Prefer ptrdiff_t to size_t when either would do, as we prefer
2589 signed integers.
2590 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2591 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2592 Now const. Initialize with values that are in range even if char
2593 is signed.
2594 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2595 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2596 These functions do the right thing with sizes > 2**32.
2597 (check_depth): Now ptrdiff_t, not int.
2598 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2599 Adjust to new way of storing sizes. Check for size overflow bugs
2600 in rest of code.
2601 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2602 slightly wrong anyway, as it missed one instance of
2603 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2604 (refill_memory_reserve): Omit needless cast to size_t.
2605 (mark_object_loop_halt): Mark as externally visible.
2606
ac82cc6a
PE
2607 * xselect.c: Integer signedness and overflow fixes.
2608 (Fx_register_dnd_atom, x_handle_dnd_message):
2609 Use ptrdiff_t, not size_t, since we prefer signed.
2610 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2611 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2612 x_dnd_atoms_size and x_dnd_atoms_length.
2613
c2d1e36d
PE
2614 * doprnt.c: Prefer signed to unsigned when either works.
2615 * eval.c (verror):
2616 * doprnt.c (doprnt):
2617 * lisp.h (doprnt):
2618 * xdisp.c (vmessage):
2619 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2620 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2621 prefer signed arithmetic to avoid comparison confusion.
2622 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2623 but is a bit tricky.
2624
0e926e56
PE
2625 Assume freestanding C89 headers, string.h, stdlib.h.
2626 * data.c, doprnt.c, floatfns.c, print.c:
2627 Include float.h unconditionally.
2628 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2629 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2630 * regex.c: Likewise for stddef.h, string.h.
2631 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2632 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2633 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2634 (STDC_HEADERS): Remove obsolete defines.
2635 * sysdep.c: Include limits.h unconditionally.
2636
9cfdb3ec
PE
2637 Assume support for memcmp, memcpy, memmove, memset.
2638 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2639 * regex.c (memcmp, memcpy):
2640 Remove; we assume C89 now.
2641
2642 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2643 (__malloc_safe_bcopy): Remove; no longer needed.
2644
cf950e6b 2645 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2646 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2647 well either way, and we prefer signed to unsigned.
2648
dbf38e02
LMI
26492011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2650
2651 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2652 closes the connection while we're reading (bug#9182).
2653
d6f0886c 26542011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2655
d6f0886c
JD
2656 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2657 are specified (Bug#9168).
24e0f6b1 2658
2eb1f9e6
PE
26592011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2662 Found by GCC static checking and --with-wide-int on a 32-bit host.
2663
22381272 26642011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2665
2666 * xdisp.c (compute_display_string_pos): Fix logic of caching
2667 previous display string position. Initialize cached_prev_pos to
2668 -1. Fixes slow-down at the beginning of a buffer.
2669
f25e39b4
EZ
26702011-07-24 Eli Zaretskii <eliz@gnu.org>
2671
2672 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2673 for attrs[LFACE_FONTSET_INDEX].
2674
04c4b52e
PE
26752011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2676
2677 * xml.c (parse_region): Remove unused local
2678 that was recently introduced.
2679
c1734fbd
EZ
26802011-07-23 Eli Zaretskii <eliz@gnu.org>
2681
be18c5a5
EZ
2682 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2683 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2684
c1734fbd
EZ
2685 * xdisp.c (move_it_in_display_line_to): Record the best matching
2686 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2687 exit if none of the characters scanned was an exact match.
2688 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2689 when exact match is impossible due to invisible text, and the
2690 lines are truncated.
2691
a258d627
JD
26922011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2693
2694 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2695 for OSX >= 10.7.
2696
b6d5a689
EZ
26972011-07-22 Eli Zaretskii <eliz@gnu.org>
2698
0f74f785
EZ
2699 Fix a significant slow-down of cursor motion with C-n, C-p,
2700 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2701 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2702 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2703 (next_element_from_buffer): Call compute_stop_pos_backwards to
2704 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2705 base_level_stop.
2706 (reseat): Don't look for prev_stop, as that could mean a very long
2707 run.
2708 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2709 <cached_disp_overlay_modiff>: Cache for last found display string
2710 position.
551918c1 2711 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2712 about the same buffer in the same area of character positions, and
2713 the buffer wasn't changed since the time the display string
2714 position was cached.
551918c1 2715
b2d0c91a
EZ
27162011-07-22 Eli Zaretskii <eliz@gnu.org>
2717
2718 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2719 is an integer, which is important for empty lines. (Bug#9149)
2720
043604ee
CY
27212011-07-22 Chong Yidong <cyd@stupidchicken.com>
2722
2723 * frame.c (Fmodify_frame_parameters): In tty case, update the
2724 default face if necessary (Bug#4238).
2725
da4adb04
CY
27262011-07-21 Chong Yidong <cyd@stupidchicken.com>
2727
2728 * editfns.c (Fstring_to_char): No need to explain what a character
2729 is in the docstring (Bug#6576).
2730
9abd0532
LMI
27312011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2732
2733 * xml.c (parse_region): Make sure we always return a tree.
2734
36881d16
HK
27352011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2736
2737 * xml.c (parse_region): If a document contains only comments,
2738 return that, too.
2739
1e98674d
LMI
27402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2741
2742 * xml.c (make_dom): Return comments, too.
2743
590bd467
PE
27442011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 Port to OpenBSD.
2747 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2748 and the surrounding thread.
2749 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2750 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2751 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2752 timer goes off.
2753 * s/openbsd.h (BROKEN_SIGIO): Define.
2754 * unexelf.c (unexec) [__OpenBSD__]:
2755 Don't update the .mdebug section of the Alpha COFF symbol table.
2756
f41628b2
LMI
27572011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2758
2759 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2760 (bug#8460).
2761
b59b67c5
PE
27622011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2763
15e3a074
PE
2764 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2765 This fixes some race conditions on the permissions of any newly
2766 created file.
2767
41bed37d
PE
2768 * alloc.c (valid_pointer_p): Use pipe, not open.
2769 This fixes some permissions issues when debugging.
2770
b59b67c5
PE
2771 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2772 If fchown fails to set both uid and gid, try to set just gid,
2773 as that is sometimes allowed. Adjust the file's mode to eliminate
2774 setuid or setgid bits that are inappropriate if fchown fails.
2775
925a6be7
SM
27762011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2777
2778 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2779 to compare Lisp_Objects.
2780 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2781 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2782 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2783
52968808
AS
27842011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2785
0a6a104b
AS
2786 * lread.c (read_integer): Unread even EOF character.
2787 (read1): Likewise. Properly record start position of symbol.
2788
52968808
AS
2789 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2790 symbol character follows.
2791
9e381cdd
PE
27922011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2793
2794 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2795 This works around a problem with the previous change to Fcopy_file.
2796 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2797 and without this change, GCC might complain about discarding
2798 fchown's return value.
2799
b5641435
JB
28002011-07-16 Juanma Barranquero <lekktu@gmail.com>
2801
2802 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2803
a8031457
PE
28042011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2805
2806 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2807
dd889327
LMI
28082011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2809
750c33f7
LMI
2810 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2811 it's used from the C level.
2812
dd889327
LMI
2813 * process.c: Use the same condition for POLL_FOR_INPUT in both
2814 keyboard.c and process.c (bug#1858).
2815
87e86684
LM
28162011-07-09 Lawrence Mitchell <wence@gmx.li>
2817
2818 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2819 (Fgnutls_boot): Use it.
2820
64348f40
AS
28212011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2822
2823 * doc.c (Fsubstitute_command_keys): Revert last change.
2824
1d698799
LMI
28252011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2826
f863868c
LMI
2827 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2828 quotes the next character, and doesn't affect other longer
2829 sequences (bug#8935).
2830
1d698799
LMI
2831 * lread.c (syms_of_lread): Clarify that is isn't only
2832 `eval-buffer' and `eval-defun' that's affected by
2833 `lexical-binding' (bug#8460).
2834
aa4b6df6
EZ
28352011-07-15 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2838 bidi redisplay when a line includes both an image and is
2839 truncated.
2840
5d856da6
PE
28412011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2842
ad6042bb
PE
2843 Fix minor problems found by static checking.
2844 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2845 (elsz): Now a signed constant, not a size_t var. We prefer signed
2846 types to unsigned, to avoid integer comparison confusion. Without
2847 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2848 "cannot optimize loop, the loop counter may overflow", a symptom
2849 of the confusion.
f00bbb22 2850 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2851 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2852
6468f31c
LMI
28532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2854
49080b10
LMI
2855 * search.c (Fre_search_backward): Mention `case-fold-search' in
2856 all the re_search_* functions (bug#8138).
2857
6468f31c
LMI
2858 * keyboard.c (Fopen_dribble_file): Document when the file is
2859 closed (bug#8056).
2860
c965adc5
EZ
28612011-07-14 Eli Zaretskii <eliz@gnu.org>
2862
df9733bf
EZ
2863 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2864 bidi_cache_idx.
2865
0bb23927
EZ
2866 Support bidi reordering of display and overlay strings.
2867 * xdisp.c (compute_display_string_pos)
2868 (compute_display_string_end): Accept additional argument STRING.
2869 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2870 (reseat_to_string): Initialize bidi_it->string.s and
2871 bidi_it->string.schars.
2872 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2873 NULL (avoids a crash in bidi_paragraph_init).
2874 Initialize itb.string.lstring.
0bb23927
EZ
2875 (init_iterator): Call bidi_init_it only of a valid
2876 buffer position was specified. Initialize paragraph_embedding to
2877 L2R.
2878 (reseat_to_string): Initialize the bidi iterator.
2879 (display_string): If we need to ignore text properties of
2880 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2881 original value of -1 will not work with bidi.)
2882 (compute_display_string_pos): First arg is now struct
2883 `text_pos *'; all callers changed. Support display properties on
2884 Lisp strings.
2885 (compute_display_string_end): Support display properties on Lisp
2886 strings.
2887 (init_iterator, reseat_1, reseat_to_string): Initialize the
2888 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2889 when iterating on a string not from display properties).
640c8776
SM
2890 (compute_display_string_pos, compute_display_string_end):
2891 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2892 arrow keys.
2893 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2894 base_level_stop; instead, set base_level_stop to BEGV.
2895 Fixes crashes in vertical-motion.
0bb23927
EZ
2896 (next_element_from_buffer): Improve commentary for when
2897 the iterator is before prev_stop.
2898 (init_iterator): Initialize bidi_p from the default value of
2899 bidi-display-reordering, not from buffer-local value. Use the
2900 buffer-local value only if initializing for buffer iteration.
2901 (handle_invisible_prop): Support invisible properties on strings
2902 that are being bidi-reordered.
2903 (set_iterator_to_next): Support bidi reordering of C strings and
2904 Lisp strings.
2905 (next_element_from_string): Support bidi reordering of Lisp
2906 strings.
2907 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2908 (display_string): Support display of R2L glyph rows.
2909 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2910 (init_iterator): Don't initialize it->bidi_p for strings
2911 here.
2912 (reseat_to_string): Initialize it->bidi_p for strings here.
2913 (next_element_from_string, next_element_from_c_string)
2914 (next_element_from_buffer): Add xassert's for correspondence
2915 between IT's object being iterated and it->bidi_it.string
2916 structure.
2917 (face_before_or_after_it_pos): Support bidi iteration.
2918 (next_element_from_c_string): Handle the case of the first string
2919 character that is not the first one in the visual order.
2920 (get_visually_first_element): New function, refactored from common
2921 parts of next_element_from_buffer, next_element_from_string, and
2922 next_element_from_c_string.
2923 (tool_bar_lines_needed, redisplay_tool_bar)
2924 (display_menu_bar): Force left-to-right direction. Add a FIXME
2925 comment for making that be controlled by a user option.
2926 (push_it, pop_it): Save and restore the state of the
2927 bidi iterator. Save and restore the bidi_p flag.
2928 (pop_it): Iterate out of display property for string iteration as
2929 well.
2930 (iterate_out_of_display_property): Support iteration over strings.
2931 (handle_single_display_spec): Set up it->bidi_it for iteration
2932 over a display string, and call bidi_init_it.
2933 (handle_single_display_spec, next_overlay_string)
2934 (get_overlay_strings_1, push_display_prop): Set up the bidi
2935 iterator for displaying display or overlay strings.
2936 (forward_to_next_line_start): Don't use the shortcut if
2937 bidi-iterating.
2938 (back_to_previous_visible_line_start): If handle_display_prop
2939 pushed the iterator stack, restore the internal state of the bidi
2940 iterator by calling bidi_pop_it same number of times.
2941 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2942 and we are bidi-iterating, don't decrement the iterator position;
2943 instead, set the first_elt flag in the bidi iterator, to produce
2944 the same effect.
2945 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2946 (push_display_prop): xassert that we are iterating a buffer.
2947 (push_it, pop_it): Save and restore paragraph_embedding member.
2948 (handle_single_display_spec, next_overlay_string)
2949 (get_overlay_strings_1, reseat_1, reseat_to_string)
2950 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2951 correctly. Don't assume unibyte strings are not bidi-reordered.
2952 (compute_display_string_pos)
2953 (compute_display_string_end): Fix handling the case of C string.
2954 (push_it, pop_it): Save and restore from_disp_prop_p.
2955 (handle_single_display_spec, push_display_prop): Set the
2956 from_disp_prop_p flag.
2957 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2958 (pop_it): Call iterate_out_of_display_property only if we are
2959 popping after iteration over a string that came from a display
2960 property. Fix a typo in popping stretch info. Add an assertion
2961 for verifying that the iterator position is in sync with the bidi
2962 iterator.
2963 (handle_single_display_spec, get_overlay_strings_1)
2964 (push_display_prop): Fix initialization of paragraph direction for
2965 string when that of the parent object is not yet determined.
2966 (reseat_1): Call bidi_init_it to resync the bidi
2967 iterator with IT's position. (Bug#7616)
2968 (find_row_edges): If ROW->start.pos gives position
2969 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2970 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2971 Reset the from_disp_prop_p flag.
2972 (SAVE_IT, RESTORE_IT): New macros.
2973 (pos_visible_p, face_before_or_after_it_pos)
2974 (back_to_previous_visible_line_start)
2975 (move_it_in_display_line_to, move_it_in_display_line)
2976 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2977 (try_scrolling, redisplay_window, display_line): Use them when
2978 saving a temporary copy of the iterator and restoring it back.
2979 (back_to_previous_visible_line_start, reseat_1)
2980 (init_iterator): Empty the bidi cache "stack".
2981 (move_it_in_display_line_to): If iterator ended up at
2982 EOL, but we never saw any buffer positions smaller than
2983 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2984 motion in bidi-reordered lines.
2985 (move_it_in_display_line_to): Record prev_method and prev_pos
2986 immediately before the call to set_iterator_to_next. Fixes cursor
2987 motion in bidi-reordered lines with stretch glyphs and strings
2988 displayed in margins. (Bug#8133) (Bug#8867)
2989 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2990 TO_CHARPOS.
640c8776
SM
2991 (pos_visible_p): Support positions in bidi-reordered lines.
2992 Save and restore bidi cache.
0bb23927
EZ
2993
2994 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2995 (bidi_paragraph_info): Delete unused struct.
2996 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2997 (bidi_cache_start): New variable.
2998 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2999 to zero.
3000 (bidi_cache_fetch_state, bidi_cache_search)
3001 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3002 (bidi_cache_find, bidi_peek_at_next_level)
3003 (bidi_level_of_next_char, bidi_find_other_level_edge)
3004 (bidi_move_to_visually_next): Compare cache index with
3005 bidi_cache_start rather than with zero.
3006 (bidi_fetch_char): Accept new argument STRING; all callers
3007 changed. Support iteration over a string. Support strings with
3008 display properties. Support unibyte strings. Fix the type of
3009 `len' according to what STRING_CHAR_AND_LENGTH expects.
3010 (bidi_paragraph_init, bidi_resolve_explicit_1)
3011 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3012 (bidi_level_of_next_char, bidi_move_to_visually_next):
3013 Support iteration over a string.
0bb23927
EZ
3014 (bidi_set_sor_type, bidi_resolve_explicit_1)
3015 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3016 can now be zero (for strings); special values 0 and -1 were
3017 changed to -1 and -2, respectively.
3018 (bidi_char_at_pos): New function.
3019 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3020 Call it instead of FETCH_MULTIBYTE_CHAR.
3021 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3022 initialized to valid values.
3023 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3024 values.
3025 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3026 the test for valid cached positions. Fix the logic for looking up
3027 the sentinel state in the cache. GCPRO the Lisp string we are
3028 iterating.
3029 (bidi_push_it, bidi_pop_it): New functions.
3030 (bidi_initialize): Initialize the bidi cache start stack pointer.
3031 (bidi_cache_ensure_space): New function, refactored from part of
3032 bidi_cache_iterator_state. Don't assume the required size is just
3033 one BIDI_CACHE_CHUNK away.
3034 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3035 (bidi_count_bytes, bidi_char_at_pos): New functions.
3036 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3037 always valid if bidi_cache_idx is valid.
3038 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3039 is valid if it's going to be used.
3040 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3041 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3042 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3043 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3044 (bidi_find_other_level_edge, bidi_cache_start_stack):
3045 All variables related to cache indices are now EMACS_INT.
c965adc5 3046
0bb23927
EZ
3047 * dispextern.h (struct bidi_string_data): New structure.
3048 (struct bidi_it): New member `string'. Make flag members be 1-bit
3049 fields, and put them last in the struct.
640c8776
SM
3050 (compute_display_string_pos, compute_display_string_end):
3051 Update prototypes.
0bb23927
EZ
3052 (bidi_push_it, bidi_pop_it): Add prototypes.
3053 (struct iterator_stack_entry): New members bidi_p,
3054 paragraph_embedding, and from_disp_prop_p.
3055 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3056 (bidi_shelve_cache, bidi_unshelve_cache):
3057 Declare prototypes.
0bb23927
EZ
3058
3059 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3060 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3061 and vector-like objects.
3062
3063 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3064 cache around display iteration.
3065
3066 * window.c (Fwindow_end, window_scroll_pixel_based)
3067 (displayed_window_lines, Frecenter): Save and restore the bidi
3068 cache around display iteration.
3069
3bbd2265
LMI
30702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3071
3072 * editfns.c (Fdelete_region): Clarify the use of the named
3073 parameters (bug#6788).
3074
adc47434
MR
30752011-07-14 Martin Rudalics <rudalics@gmx.at>
3076
3077 * indent.c (Fvertical_motion): Set and restore w->pointm when
3078 saving and restoring the window's buffer (Bug#9006).
3079
837c31f8
LMI
30802011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3081
3082 * editfns.c (Fstring_to_char): Clarify just what is returned
3083 (bug#6576). Text by Eli Zaretskii.
3084
ac389d0c
JB
30852011-07-13 Juanma Barranquero <lekktu@gmail.com>
3086
3087 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3088
0be0ce47
EZ
30892011-07-13 Eli Zaretskii <eliz@gnu.org>
3090
3091 * buffer.c (mmap_find): Fix a typo.
3092
cd18e7e3
JB
30932011-07-13 Johan Bockgård <bojohan@gnu.org>
3094
3095 Fix execution of x selection hooks.
3096 * xselect.c (Qx_lost_selection_functions)
3097 (Qx_sent_selection_functions): New vars.
3098 (syms_of_xselect): DEFSYM them.
3099 (x_handle_selection_request): Pass Qx_sent_selection_functions
3100 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3101 (x_handle_selection_clear,x_clear_frame_selections):
3102 Pass Qx_lost_selection_functions rather than
3103 Vx_lost_selection_functions to Frun_hook_with_args.
3104
47ea7f44
PE
31052011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3106
ac389d0c 3107 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3108 The old code sometimes used this field without initializing it.
3109
47ea7f44
PE
3110 * alloc.c (gc_sweep): Don't read past end of array.
3111 In theory, the old code could also have corrupted Emacs internals,
3112 though it'd be very unlikely.
3113
bc985c87
AS
31142011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3115
3116 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3117 argument. (Bug#4026)
bc985c87 3118
0cf34688
LMI
31192011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3120
b3dadd76
LMI
3121 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3122 key" (bug#4257).
3123
0cf34688
LMI
3124 * window.c (Fset_window_start): Doc fix (bug#4199).
3125 (Fset_window_hscroll): Ditto.
3126
270768cd
PE
31272011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3128
077e3dda 3129 Fix minor new problems caught by GCC 4.6.1.
270768cd 3130 * term.c (init_tty): Remove unused local.
490011a6 3131 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3132 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3133 not used otherwise.
270768cd 3134
b1f58454
CY
31352011-07-12 Chong Yidong <cyd@stupidchicken.com>
3136
3137 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3138
22b9578d
LMI
31392011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3140
6e70ab07
LMI
3141 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3142 are the mini-buffer and the echo area (bug#3320).
3143
22b9578d
LMI
3144 * term.c (init_tty): Remove support for supdup, c10 and perq
3145 terminals, which are no longer supported (bug#1482).
3146
8974cc9f
JB
31472011-07-10 Johan Bockgård <bojohan@gnu.org>
3148
3149 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3150
a560d974
JD
31512011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3152
3153 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3154 for non-popups (Bug#3642).
3155
1dae0f0a
AS
31562011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3157
268c2c36 3158 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3159 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3160 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3161 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3162 * data.c (fmod): Likewise.
3163 * dispnew.c (swap_glyphs_in_rows): Likewise.
3164 * emacs.c (memory_warning_signal): Likewise.
3165 * floatfns.c (float_error): Likewise.
3166 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3167 (otf_open, font_otf_capability, generate_otf_features)
3168 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3169 Likewise.
3170 * image.c (pbm_read_file): Likewise.
3171 * indent.c (string_display_width): Likewise.
3172 * intervals.c (check_for_interval, search_for_interval)
3173 (inc_interval_count, count_intervals, root_interval)
3174 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3175 * lread.c (defalias): Likewise.
268c2c36 3176 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3177 * regex.c (set_image_of_range_1, set_image_of_range)
3178 (regex_grow_registers): Likewise.
3179 * sysdep.c (strerror): Likewise.
3180 * termcap.c (valid_filename_p, tprint, main): Likewise.
3181 * tparam.c (main): Likewise.
3182 * unexhp9k800.c (run_time_remap, save_data_space)
3183 (update_file_ptrs, read_header, write_header, calculate_checksum)
3184 (copy_file, copy_rest, display_header): Likewise.
3185 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3186 Likewise.
3187 * xdisp.c (check_it): Likewise.
3188 * xfaces.c (register_color, unregister_color, unregister_colors):
3189 Likewise.
3190 * xfns.c (print_fontset_result): Likewise.
3191 * xrdb.c (member, fatal, main): Likewise.
3192
99033785
PE
31932011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3194
3195 Fix minor problems found by static checking (Bug#9031).
3196 * chartab.c (char_table_set_range, map_sub_char_table):
3197 Remove unused locals.
3198 (uniprop_table): Now static.
3199 * composite.c (_work_char): Remove unused static var.
3200
9cb2ac56
JB
32012011-07-09 Juanma Barranquero <lekktu@gmail.com>
3202
3203 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3204
f25661f0
JD
32052011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3206
3207 * gtkutil.c (qttip_cb): Remove code without function.
3208
8278c4fe
EZ
32092011-07-09 Eli Zaretskii <eliz@gnu.org>
3210
3211 * w32.c (pthread_sigmask): New stub.
3212
1692ae2d 32132011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3214
8a6ebd58 3215 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3216 sigprocmask is portable only for single-threaded applications, and
3217 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3218 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3219 (LIBES): Use it.
3220 * callproc.c (Fcall_process):
3221 * process.c (create_process):
3222 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3223 Use pthread_sigmask, not sigprocmask.
123403e4 3224
1b854618
JD
32252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3226
3227 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3228 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3229 wrong (Bug#8591).
3230
3fe4b549
JD
32312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3232
0ce7e563
JD
3233 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3234 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3235 (xg_hide_tooltip): Fix comment.
3236
3fe4b549
JD
3237 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3238 in registerServicesMenuSendTypes.
3239 (validRequestorForSendType): Don't check ns_return_types.
3240
3241 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3242 ns_return_type.
3243
5df75e47
JR
32442011-07-08 Jason Rumney <jasonr@gnu.org>
3245
3246 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3247 frame struct members of non-existent frames (Bug#6284).
3248
699c10bd
JD
32492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3250
4393663b
JD
3251 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3252 variable firstTime not needed on OSX >= 10.6.
3253 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3254 >= 10.5. Use setKnobProportion, setDoubleValue.
3255
3256 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3257 (MAC_OS_X_VERSION_10_5): Define if not defined.
3258 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3259 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3260 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3261
3262 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3263 cString and lossyCString on OSX >= 10.4
3264
3265 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3266 sizeToFit on OSX >= 10.2.
3267
3268 * nsimage.m (allocInitFromFile): Don't use deprecated method
3269 bestRepresentationForDevice on OSX >= 10.6.
3270
3271 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3272 to avoid warning.
3273
3274 * emacs.c: Declare unexec_init_emacs_zone.
3275
a63e0781
JD
3276 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3277
699c10bd
JD
3278 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3279
3280 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3281 on svcsMenu (Bug#8842).
3282
3283 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3284 ns_return_types.
3285 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3286
3287 * nsterm.m (QUTF8_STRING): Declare.
3288 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3289 (validRequestorForSendType): Return type is (id).
3290 Change indexOfObjectIdenticalTo to indexOfObject.
3291 Check if we have local selection before returning self (Bug#8842).
3292 (writeSelectionToPasteboard): Put local selection into paste board
3293 if we have a local selection (Bug#8842).
3294 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3295
3296 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3297 (ns_get_local_selection): Declare.
3298
54e10184
LMI
32992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3300
9888ff71
LMI
3301 * keymap.c (describe_map_tree): Don't insert a double newline at
3302 the end of the buffer (bug#1169) and return whether we inserted
3303 something.
3304
54e10184
LMI
3305 * callint.c (Fcall_interactively): Change "reading args" to
3306 "providing args" to try to clarify what it does (bug#1010).
3307
15fa4783
KH
33082011-07-07 Kenichi Handa <handa@m17n.org>
3309
3310 * composite.c (composition_compute_stop_pos): Ignore a static
3311 composition starting before CHARPOS (Bug#8915).
3312
3313 * xdisp.c (handle_composition_prop): Likewise.
3314
a8815b00
EZ
33152011-07-07 Eli Zaretskii <eliz@gnu.org>
3316
3317 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3318 (Bug#9015)
3319
ef7b981d 33202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3321
3322 * character.h (unicode_category_t): New enum type.
3323
3324 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3325 (Qchar_code_property_table): New variable.
3326 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3327 (UNIPROP_COMPRESSED_FORM_P): New macros.
3328 (char_table_ascii): Uncompress the compressed values.
3329 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3330 Uncompress the compressed values.
ac389d0c 3331 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3332 (char_table_ref_and_range): Uncompress the compressed values.
3333 (sub_char_table_set): New arg is_uniprop. Callers changed.
3334 Uncompress the compressed values.
3335 (sub_char_table_set_range): Args changed. Callers changed.
3336 (char_table_set_range): Adjuted for the above change.
3337 (map_sub_char_table): Delete args default_val and parent. Add arg
3338 top. Give decoded values to a Lisp function.
640c8776 3339 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3340 values to a Lisp function. Gcpro more variables.
3341 (uniprop_table_uncompress)
3342 (uniprop_decode_value_run_length): New functions.
3343 (uniprop_decoder, uniprop_decoder_count): New variables.
3344 (uniprop_get_decoder, uniprop_encode_value_character)
3345 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3346 New functions.
3347 (uniprop_encoder, uniprop_encoder_count): New variables.
3348 (uniprop_get_encoder, uniprop_table)
3349 (Funicode_property_table_internal, Fget_unicode_property_internal)
3350 (Fput_unicode_property_internal): New functions.
3351 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3352 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3353 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3354 char-code-property-alist.
3355
640c8776 3356 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3357 Vunicode_category_table.
3358
640c8776 3359 * font.c (font_range): Adjust for the change of
c805dec0
KH
3360 Vunicode_category_table.
3361
76b397fb
DN
33622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3363
3364 * m/iris4d.h: Remove file, move contents ...
3365 * s/irix6-5.h: ... here.
3366
22b4128e
PE
33672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3368
3369 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3370 * alloc.c (mark_buffer):
3371 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3372 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3373 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3374 This isn't true in general, and it's particularly not true
3375 if Emacs is configured with --with-wide-int.
3376 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3377 New macros, used in the buffer.c change.
3378
869795d6
JD
33792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3380
3381 * xsettings.c: Use both GConf and GSettings if both are available.
3382 (store_config_changed_event): Add comment.
3383 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3384 (store_tool_bar_style_changed): New functions.
5e617bc2 3385 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3386 (struct xsettings): Move font inside HAVE_XFT.
3387 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3388 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3389 Move inside HAVE_XFT.
640c8776 3390 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3391 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3392 also.
3393 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3394 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3395 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3396 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3397 (parse_settings): Move check for font inside HAVE_XFT.
3398 (read_settings, apply_xft_settings): Add comment.
3399 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3400 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3401 call store_font_name_changed.
3402 (xft_settings_event): Add comment.
3403 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3404 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3405 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3406 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3407 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3408 (xsettings_get_system_font, xsettings_get_system_normal_font):
3409 Add comment.
869795d6 3410
d8ed26bd
PE
34112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3412
3413 Random fixes. E.g., (random) never returned negative values.
3414 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3415 subseconds part to the entropy, as that's a bit more random.
3416 Prefer signed to unsigned, since the signedness doesn't matter and
3417 in general we prefer signed. When given a limit, use a
3418 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3419 latter isn't right if USE_2_TAGS_FOR_INTS.
3420 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3421 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3422
cabf1cac
SM
34232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3424
3425 * textprop.c (text_property_stickiness):
3426 Obey Vtext_property_default_nonsticky.
3427 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3428 * w32fns.c (syms_of_w32fns):
3429 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3430
6e9b2be9
PE
34312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3432
3433 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3434 This is more efficient than Ffile_directory_p and avoids a minor race.
3435
90186c68
LMI
34362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3437
7c301272
LMI
3438 * buffer.c (Foverlay_put): Say what the return value is
3439 (bug#7835).
3440
c4f2d8d4
LMI
3441 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3442 is a directory before asking whether to use the file name
3443 (bug#7564).
ad637907
LMI
3444 (barf_or_query_if_file_exists): Make the "File is a directory"
3445 error be more correct.
c4f2d8d4 3446
90186c68
LMI
3447 * fns.c (Frequire): Remove the mention of the .gz files, since
3448 that's installation-specific, but keep the mention of
3449 `get-load-suffixes'.
3450
da64016e
PE
34512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3452
3453 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3454 Report string overflow if the output is too long.
3455
7d47b580
JB
34562011-07-04 Juanma Barranquero <lekktu@gmail.com>
3457
a555cb87
JB
3458 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3459 (syms_of_gnutls): Remove duplicate DEFSYM for
3460 Qgnutls_bootprop_verify_hostname_error, an error for
3461 Qgnutls_bootprop_verify_error (which is no longer used).
3462
7d47b580
JB
3463 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3464 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3465 Also (re)move comments that are misplaced or no longer relevant.
3466
1e49bfab
LMI
34672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3468
3469 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3470
1485f4c0
CY
34712011-07-03 Chong Yidong <cyd@stupidchicken.com>
3472
3473 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3474 and background color parameters if they have been changed.
3475
a9ab721e
LMI
34762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3477
3478 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3479
cf7cff57
PE
34802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3481
2e13213d
PE
3482 * xsettings.c (SYSTEM_FONT): Define only when used.
3483 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3484
cf7cff57
PE
3485 * keymap.c (access_keymap_1): Now static.
3486
7a8e04f7
CY
34872011-07-02 Chong Yidong <cyd@stupidchicken.com>
3488
3489 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3490 leave any prefix arg for the up event (Bug#1586).
3491
61352f62
LMI
34922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3493
69bb1ef7
LMI
3494 * lread.c (syms_of_lread): Mention single symbols defined by
3495 `defvar' or `defconst' (bug#7154).
3496
61352f62 3497 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3498 (Frequire): Mention get-load-suffixes.
61352f62 3499
28545e04
MR
35002011-07-02 Martin Rudalics <rudalics@gmx.at>
3501
3502 * window.h (window): Remove clone_number slot.
3503 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3504 Remove.
3505 (make_parent_window, make_window, saved_window)
3506 (Fset_window_configuration, save_window_save): Don't deal with
3507 clone numbers.
3508 * buffer.c (Qclone_number): Remove declaration.
3509 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3510
3349e122
SM
35112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3512
3513 Add multiple inheritance to keymaps.
3514 * keymap.c (Fmake_composed_keymap): New function.
3515 (Fset_keymap_parent): Simplify.
3516 (fix_submap_inheritance): Remove.
3517 (access_keymap_1): New function extracted from access_keymap to handle
3518 embedded parents and handle lists of maps.
3519 (access_keymap): Use it.
3520 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3521 (Fcopy_keymap): Handle embedded parents.
3522 (Fcommand_remapping, define_as_prefix): Simplify.
3523 (Fkey_binding): Simplify.
3524 (syms_of_keymap): Move minibuffer-local-completion-map,
3525 minibuffer-local-filename-completion-map,
3526 minibuffer-local-must-match-map, and
3527 minibuffer-local-filename-must-match-map to Elisp.
3528 (syms_of_keymap): Defsubr make-composed-keymap.
3529 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3530 (parse_menu_item): Trivial simplification.
3531
3279eb87
GM
35322011-07-01 Glenn Morris <rgm@gnu.org>
3533
3534 * Makefile.in (SETTINGS_LIBS): Fix typo.
3535
4550efdf
KI
35362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3537
3538 * coding.c (Fencode_coding_string): Record the last coding system
3539 used, as the function doc string says (bug#8738).
3540
0949d2b6
JD
35412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3542
3543 * xsettings.c (store_monospaced_changed): Take new font as arg and
3544 check for change against current_mono_font.
3545 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3546 (emacs_settings_constructor, emacs_settings_get_property)
3547 (emacs_settings_set_property, emacs_settings_class_init)
3548 (emacs_settings_init, gsettings_obj): Remove.
3549 (something_changedCB): New function for HAVE_GSETTINGS.
3550 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3551 with value as argument.
3552 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3553 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3554 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3555 "changed".
3556
3557 * xgselect.c: Add defined (HAVE_GSETTINGS).
3558 (xgselect_initialize): Ditto.
3559
3560 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3561 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3562 xg_select.
3563
bbc6b304
PE
35642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3565
3566 * eval.c (struct backtrace): Simplify and port the data structure.
3567 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3568 signed bit field, as this assumption is not portable and it makes
3569 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3570 "char debug_on_exit : 1" as this is not portable either; instead,
3571 use the portable "unsigned int debug_on_exit : 1". Remove unused
3572 member evalargs. Remove obsolete comments about cc bombing out.
3573
9851bfc5
JD
35742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3575
51bb811f 3576 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3577 Let HAVE_GSETTINGS override HAVE_GCONF.
3578 (store_monospaced_changed): New function.
3579 (EMACS_SETTINGS): A new type derived from GObject to handle
3580 GSettings notifications.
3581 (emacs_settings_constructor, emacs_settings_get_property)
3582 (emacs_settings_set_property, emacs_settings_class_init):
3583 New functions.
3584 (gsettings_client, gsettings_obj): New variables.
3585 (GSETTINGS_SCHEMA): New define.
3586 (something_changedCB): Call store_monospaced_changed.
3587 (init_gsettings): New function.
3588 (xsettings_initialize): Call init_gsettings.
3589 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3590 to NULL.
3591
640c8776 3592 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3593 GCONF_CFLAGS/LIBS.
3594
5386012d
MR
35952011-06-29 Martin Rudalics <rudalics@gmx.at>
3596
3597 * window.c (resize_root_window, grow_mini_window)
3598 (shrink_mini_window): Rename Qresize_root_window to
3599 Qwindow_resize_root_window and Qresize_root_window_vertically to
3600 Qwindow_resize_root_window_vertically.
3601
f13e0b08
PE
36022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3605
94515237
JB
36062011-06-27 Juanma Barranquero <lekktu@gmail.com>
3607
3608 * makefile.w32-in: Redesign dependencies so they reflect more
3609 clearly which files are directly included by each source file,
3610 and not through other includes.
3611
e43b6e43
MR
36122011-06-27 Martin Rudalics <rudalics@gmx.at>
3613
3614 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3615 (sort_overlays, overlay_strings): When an overlay's clone number
3616 matches the window's clone number process the overlay even if
3617 the overlay's window property doesn't match the current window.
3618
d68443dc
MR
3619 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3620 (Fwindow_hchild): Rename to Fwindow_left_child.
3621 (Fwindow_next): Rename to Fwindow_next_sibling.
3622 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3623 (resize_window_check): Rename to window_resize_check.
3624 (resize_window_apply): Rename to window_resize_apply.
3625 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3626 (Fdelete_other_windows_internal, resize_frame_windows)
3627 (Fsplit_window_internal, Fdelete_window_internal)
3628 (grow_mini_window, shrink_mini_window)
3629 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3630
c7e73be5
JD
36312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3632
3633 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3634 (emacs_fixed_set_min_size): Remove.
3635 (emacs_fixed_new): Take frame as argument.
3636
3637 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3638 (_EmacsFixedPrivate): Remove minwidth/height.
3639 Add struct frame *f.
3640 (emacs_fixed_init): Initialize priv->f.
3641 (get_parent_class, emacs_fixed_set_min_size): Remove.
3642 (emacs_fixed_new): Set priv->f to argument.
3643 (emacs_fixed_get_preferred_width)
3644 (emacs_fixed_get_preferred_height): Use min_width/height from
3645 frames size_hint to set minimum and natural (Bug#8919).
3646 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3647 and use min_width/height from frames size_hint to set
3648 min_width/height (Bug#8919).
3649
3650 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3651 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3652 Fix indentation.
c7e73be5 3653
cf99dcf8
EZ
36542011-06-26 Eli Zaretskii <eliz@gnu.org>
3655
3656 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3657 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3658 called at ZV.
3659
029529ac
CY
36602011-06-26 Chong Yidong <cyd@stupidchicken.com>
3661
3662 * process.c (wait_reading_process_output): Bypass select if
3663 waiting for a cell while ignoring keyboard input, and input is
3664 pending. Suggested by Jan Djärv (Bug#8869).
3665
7a7ef429
PE
36662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 Use gnulib's dup2 module instead of rolling our own.
3669 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3670
11fdef7d 36712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3672
3673 * dispnew.c (scrolling_window): Before scrolling, turn off a
3674 mouse-highlight in the window being scrolled.
3675
cd3520a4
JB
36762011-06-24 Juanma Barranquero <lekktu@gmail.com>
3677
3678 Move DEFSYM to lisp.h and use everywhere.
3679
3680 * character.h (DEFSYM): Move declaration...
3681 * lisp.h (DEFSYM): ...here.
3682
3683 * gnutls.c:
3684 * minibuf.c:
3685 * w32menu.c:
3686 * w32proc.c:
3687 * w32select.c: Don't include character.h.
3688
3689 * alloc.c (syms_of_alloc):
3690 * buffer.c (syms_of_buffer):
3691 * bytecode.c (syms_of_bytecode):
3692 * callint.c (syms_of_callint):
3693 * casefiddle.c (syms_of_casefiddle):
3694 * casetab.c (init_casetab_once):
3695 * category.c (init_category_once, syms_of_category):
3696 * ccl.c (syms_of_ccl):
3697 * cmds.c (syms_of_cmds):
3698 * composite.c (syms_of_composite):
3699 * dbusbind.c (syms_of_dbusbind):
3700 * dired.c (syms_of_dired):
3701 * dispnew.c (syms_of_display):
3702 * doc.c (syms_of_doc):
3703 * editfns.c (syms_of_editfns):
3704 * emacs.c (syms_of_emacs):
3705 * eval.c (syms_of_eval):
3706 * fileio.c (syms_of_fileio):
3707 * fns.c (syms_of_fns):
3708 * frame.c (syms_of_frame):
3709 * fringe.c (syms_of_fringe):
3710 * insdel.c (syms_of_insdel):
3711 * keymap.c (syms_of_keymap):
3712 * lread.c (init_obarray, syms_of_lread):
3713 * macros.c (syms_of_macros):
3714 * msdos.c (syms_of_msdos):
3715 * print.c (syms_of_print):
3716 * process.c (syms_of_process):
3717 * search.c (syms_of_search):
3718 * sound.c (syms_of_sound):
3719 * syntax.c (init_syntax_once, syms_of_syntax):
3720 * terminal.c (syms_of_terminal):
3721 * textprop.c (syms_of_textprop):
3722 * undo.c (syms_of_undo):
3723 * w32.c (globals_of_w32):
3724 * window.c (syms_of_window):
3725 * xdisp.c (syms_of_xdisp):
3726 * xfaces.c (syms_of_xfaces):
3727 * xfns.c (syms_of_xfns):
3728 * xmenu.c (syms_of_xmenu):
3729 * xsettings.c (syms_of_xsettings):
3730 * xterm.c (syms_of_xterm): Use DEFSYM.
3731
4228cf16
TZ
37322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3733
cd3520a4 3734 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3735
7fcccf1e
PE
37362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3737
7efb4e0e
PE
3738 Integer and buffer overflow fixes (Bug#8873).
3739
ff5844ad
PE
3740 * print.c (printchar, strout): Check for string overflow.
3741 (PRINTPREPARE, printchar, strout):
3742 Don't set size unless allocation succeeds.
3743
90532f02
PE
3744 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3745 for sizes. Check for string overflow more accurately.
3746 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3747
6d84508d
PE
3748 * macros.c: Integer and buffer overflow fixes.
3749 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3750 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3751 Use ptrdiff_t, not int, for sizes.
3752 Don't increment bufsize until after realloc succeeds.
3753 Check for size-calculation overflow.
3754 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3755
437b2cb4
PE
3756 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3757
8b9ac8b4
PE
3758 * lread.c: Integer overflow fixes.
3759 (read_integer): Radix is now EMACS_INT, not int,
3760 to improve quality of diagnostics for out-of-range radices.
3761 Calculate buffer size correctly for out-of-range radices.
3762 (read1): Check for integer overflow in radices, and in
3763 read-circle numbers.
82cb60d3
PE
3764 (read_escape): Avoid int overflow.
3765 (Fload, openp, read_buffer_size, read1)
3766 (substitute_object_recurse, read_vector, read_list, map_obarray):
3767 Use ptrdiff_t, not int, for sizes.
3768 (read1): Use EMACS_INT, not int, for sizes.
20270765 3769 Check for size overflow.
8b9ac8b4 3770
7fcccf1e
PE
3771 * image.c (cache_image): Check for size arithmetic overflow.
3772
bfbbd7e7
PE
3773 * lread.c: Integer overflow issues.
3774 (saved_doc_string_size, saved_doc_string_length)
3775 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3776 Now ptrdiff_t, not int.
3777 (read1): Don't assume doc string length fits in int. Check for
3778 out-of-range doc string lengths.
3779 (read_list): Don't assume file position fits in int.
39019e54 3780 (read_escape): Check for hex character overflow.
bfbbd7e7 3781
4e323265
LL
37822011-06-22 Leo Liu <sdl.web@gmail.com>
3783
3784 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3785 Move to minibuffer.el.
3786
85fece3e
PE
37872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3788
20b84ce9 3789 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3790 The following patches are for when GLYPH_DEBUG && !XASSERT.
3791 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3792 * dispnew.c (flush_stdout):
3793 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3794 Mark as externally visible.
3795 * dispnew.c (check_window_matrix_pointers): Now static.
3796 * dispnew.c (window_to_frame_vpos):
3797 * xfns.c (unwind_create_frame):
3798 * xterm.c (x_check_font): Remove unused local.
3799 * scroll.c (CHECK_BOUNDS):
3800 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3801 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3802 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3803 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3804 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3805 Now static.
3806 (debug_method_add): Use va_list and vsprintf rather than relying
3807 on undefined behavior with wrong number of arguments.
3808 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3809 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3810 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3811 since we're not interested in debugging glyphs with old libraries.
3812 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3813 GCC 4.6.0's static checking.
3814
0766b489
PE
38152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3816
31fd4b32
PE
3817 Integer overflow and signedness fixes (Bug#8873).
3818 A few related buffer overrun fixes, too.
3819
b79e8648
PE
3820 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3821
0766b489
PE
3822 * dispextern.h (struct face.stipple):
3823 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3824 (x_bitmap_mask, x_allocate_bitmap_record)
3825 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3826 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3827 (x_create_bitmap_from_xpm_data):
3828 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3829 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3830 (.bitmaps_last):
3831 * xfaces.c (load_pixmap):
3832 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3833 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3834 (.bitmaps_last, struct x_output.icon_bitmap):
3835 Use ptrdiff_t, not int, for bitmap indexes.
3836 (x_allocate_bitmap_record): Check for size overflow.
3837 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3838
b081724f
PE
3839 Use ptrdiff_t, not int, for overlay counts.
3840 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3841 * editfns.c (overlays_around, get_pos_property):
3842 * textprop.c (get_char_property_and_overlay):
3843 * xdisp.c (next_overlay_change, note_mouse_highlight):
3844 * xfaces.c (face_at_buffer_position):
21514da7
PE
3845 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3846 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3847 (Fnext_overlay_change, Fprevious_overlay_change)
3848 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3849 Use ptrdiff_t, not int, for sizes.
21514da7 3850 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3851
3de73e5e
PE
3852 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3853
2606c57b
PE
3854 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3855 (x_session_initialize): Do not assume string length fits in int.
3856
aaafe47a
PE
3857 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3858 This is unlikely, but can occur if DPI is outlandish.
3859
2674ddc8 3860 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3861 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3862
28154962
PE
3863 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3864 * xrdb.c (magic_file_p, search_magic_path):
3865 Omit last arg SUFFIX; it was always 0. All callers changed.
3866 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3867
7de51af5
PE
3868 * xfont.c (xfont_match): Avoid need for strlen.
3869
25ed6cc3
PE
3870 * xfns.c: Don't assume strlen fits in int.
3871 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3872
4eab31dd
PE
3873 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3874 not unsigned long, as we prefer signed integers. All callers changed.
3875 Detect integer overflow in repeat count.
3876 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3877 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3878
171e2a58
PE
3879 * termcap.c: Don't assume sizes fit in int and never overflow.
3880 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3881 (gobble_line): Check for size-calculation overflow.
3882
ad39faca 3883 * minibuf.c (Fread_buffer):
6e5bb2dc 3884 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3885 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3886 Don't assume string length fits in int.
3887
52c61c22 3888 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3889 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3890
b5b8c9e5
PE
3891 * font.c: Don't assume string length fits in int.
3892 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3893 Use ptrdiff_t, not int.
ccd6111c
PE
3894 (font_intern_prop): Don't assume string length fits in int.
3895 Don't assume integer property fits in fixnum.
3896 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3897
882f0d81 3898 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3899 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3900 Reformulate so as not to need the command string.
3901 Invoke gzip -cd rather than gunzip, as it's more portable.
3902 (lock_info_type, lock_file_1, lock_file):
3903 Don't assume pid_t and time_t fit in unsigned long.
3904 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3905 (current_lock_owner): Prefer signed type for sizes.
3906 Use memcpy, not strncpy, where memcpy is what is really wanted.
3907 Don't assume (via atoi) that time_t and pid_t fit in int.
3908 Check for time_t and/or pid_t out of range, e.g., via a network share.
3909 Don't alloca where an auto var works fine.
3910
93f4cf88
PE
3911 * fileio.c: Fix some integer overflow issues.
3912 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3913 Don't assume string length fits in int.
3914 (directory_file_name): Don't assume string length fits in long.
3915 (make_temp_name): Don't assume pid fits in int, or that its print
3916 length is less than 20.
3917
f3e92b69
PE
3918 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3919
1bfdaf10
PE
3920 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3921
35016e9a
PE
3922 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3923
3d1e65a1
PE
3924 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3925 We prefer signed integers, even for size calculations.
3926
0b963a93
PE
3927 * emacs.c: Don't assume string length fits in 'int'.
3928 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3929 (main): Don't invoke strlen when not needed.
3930
573f4b54
PE
3931 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3932 (XD_DEBUG_MESSAGE): Don't waste a byte.
3933
989f33ba
PE
3934 * callproc.c (getenv_internal_1, getenv_internal)
3935 (Fgetenv_internal):
965d34eb
PE
3936 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3937
e4d29b33
PE
3938 * lread.c (invalid_syntax): Omit length argument.
3939 All uses changed. This doesn't fix a bug, but it simplifies the
3940 code away from its former Hollerith-constant appearance, and it's
3941 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3942 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3943
eb49b136
PE
3944 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3945 This didn't break anything, but it didn't help either.
3946 It's confusing to put a bogus integer in a place where the actual
3947 value does not matter.
9f62aeb1 3948 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3949 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3950
15375a22
PE
3951 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3952 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3953 implementation.
b61cc01c
PE
3954 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3955 We prefer signed types, and the value cannot exceed the EMACS_INT
3956 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3957 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3958 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3959 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3960
53b2623d
PE
3961 * indent.c (sane_tab_width): New function.
3962 (current_column, scan_for_column, Findent_to, position_indentation)
3963 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3964 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3965
51cab52b 3966 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3967
f2ed8a70
PE
3968 * lisp.h (lint_assume): New macro.
3969 * composite.c (composition_gstring_put_cache):
3970 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3971
abe80cc6
PE
3972 * editfns.c, insdel.c:
3973 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3974
b02c740e
PE
3975 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3976
ebc96716
PE
3977 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3978
b4e50fa0 3979 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3980 Use much-faster test for byte-length change.
311d5d7c 3981 Don't assume string byte-length fits in 'int'.
a4cf38e4 3982 Check that character arg fits in 'int'.
85461888 3983 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3984
c0c1ee9f
PE
3985 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3986
a498d7f4
PE
3987 * fns.c (concat): Catch string overflow earlier.
3988 Do not rely on integer wraparound.
3989
51cab52b
PE
3990 * dispextern.h (struct it.overlay_strings_charpos)
3991 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3992 * xdisp.c (forward_to_next_line_start)
3993 (back_to_previous_visible_line_start)
3994 (reseat_at_next_visible_line_start, next_element_from_buffer):
3995 Don't arbitrarily truncate the value of 'selective' to int.
3996
76031fad
PE
3997 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3998
5eb55db9
PE
3999 * composite.c: Don't truncate sizes to 'int'.
4000 (composition_gstring_p, composition_reseat_it)
4001 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4002 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4003 not EMACS_UINT, for indexes.
5eb55db9 4004
0703a717
PE
4005 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4006
d6202519
PE
4007 * buffer.c: Include <verify.h>.
4008 (struct sortvec.priority, struct sortstr.priority):
8961a454 4009 Now EMACS_INT, not int.
c20998a7 4010 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4011 (struct sortstr.size, record_overlay_string)
4012 (struct sortstrlist.size, struct sortlist.used):
4013 Don't truncate size to int.
4014 (record_overlay_string): Check for size-calculation overflow.
d6202519 4015 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4016
d5a19415
JM
40172011-06-22 Jim Meyering <meyering@redhat.com>
4018
029529ac 4019 Don't leak an XBM-image-sized buffer
d5a19415
JM
4020 * image.c (xbm_load): Free the image buffer after using it.
4021
a9041e6c
PE
40222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4023
4024 Port to Sun C.
4025 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4026 that Sun C diagnosed.
4027 * fns.c (secure_hash): Fix pointer signedness issue.
4028 * intervals.c (static_offset_intervals): New function.
4029 (offset_intervals): Use it.
4030
7f3f739f
LL
40312011-06-21 Leo Liu <sdl.web@gmail.com>
4032
4033 * deps.mk (fns.o):
4034 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4035 sha512.h.
4036
4037 * fns.c (secure_hash): Rename from crypto_hash_function and change
4038 the first arg to accept symbols.
5b66d427 4039 (Fsecure_hash): New primitive.
7f3f739f
LL
4040 (syms_of_fns): New symbols.
4041
76147d94
DD
40422011-06-20 Deniz Dogan <deniz@dogan.se>
4043
4044 * process.c (Fset_process_buffer): Clarify return value in
4045 docstring.
4046
7d7d0045
CY
40472011-06-18 Chong Yidong <cyd@stupidchicken.com>
4048
4049 * dispnew.c (add_window_display_history): Use BVAR.
4050
4051 * xdisp.c (debug_method_add): Use BVAR.
4052 (check_window_end, dump_glyph_matrix, dump_glyph)
4053 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4054
4055 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4056 Likewise.
4057
4058 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4059 check till after the cache is created in init_frame_faces.
4060
ff2bc410
SM
40612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4062
4063 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4064
28177add
PE
40652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4066
dd3482fe
PE
4067 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4068 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4069 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4070
393d71f3 4071 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4072 * fileio.c (Finsert_file_contents):
4073 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4074 Remove the old (too-loose) buffer overflow checks.
4075 They weren't needed, since make_gap checks for buffer overflow.
4076 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4077 The old code merely checked for Emacs fixnum overflow, and relied
4078 on undefined (wraparound) behavior. The new code avoids undefined
4079 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4080
2e6813b0 4081 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4082 Tune. Don't use wider integers than needed. Don't use alloca.
4083 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4084
599a9e4f
PE
4085 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4086
99561444
PE
4087 * insdel.c, lisp.h (buffer_overflow): New function.
4088 (insert_from_buffer_1, replace_range, replace_range_2):
4089 * insdel.c (make_gap_larger):
4090 * editfns.c (Finsert_char):
4091 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4092
28177add
PE
4093 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4094
e69dafad
PE
40952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4096
a7af7fde 4097 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4098
b1c46f02
PE
4099 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4100 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4101
e69dafad
PE
4102 * fileio.c: Don't assume EMACS_INT fits in off_t.
4103 (emacs_lseek): New static function.
4104 (Finsert_file_contents, Fwrite_region): Use it.
4105 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4106
566684ea
PE
4107 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4108
e6966cd6
PE
4109 * fns.c: Don't overflow int when computing a list length.
4110 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4111 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4112 truncation on 64-bit hosts. Check for QUIT every
4113 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4114 faster and is responsive enough.
4115 (Flength): Report an error instead of overflowing an integer.
4116 (Fsafe_length): Return a float if the value is not representable
4117 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4118 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4119 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4120
dd0b0efb
PE
4121 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4122 (header_size, word_size): New constants.
4123 (allocate_vectorlike): Don't check size overflow here.
4124 (allocate_vector): Check it here instead, since this is the only
4125 caller of allocate_vectorlike that could cause overflow.
4126 Check that the new vector's length is representable as a fixnum.
4127
86fe5cfe
PE
4128 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4129 The previous code was bogus. For example, next_almost_prime (32)
4130 returned 39, which is undesirable as it is a multiple of 3; and
4131 next_almost_prime (24) returned 25, which is a multiple of 5 so
4132 why was the code bothering to check for multiples of 7?
4133
80e88859
PE
4134 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4135
4a2f0ad6
PE
4136 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4137
f66c7cf8
PE
4138 Variadic C functions now count arguments with ptrdiff_t.
4139 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4140 Back then I didn't know that the Emacs coding style prefers signed int.
4141 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4142 were being counted with int, which may truncate counts on 64-bit
4143 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4144 * lisp.h (struct Lisp_Subr.function.aMANY)
4145 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4146 Arg counts are now ptrdiff_t, not size_t.
4147 All variadic functions and their callers changed accordingly.
4148 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4149 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4150 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4151 * callint.c (Fcall_interactively): Check arg count for overflow,
4152 to avoid potential buffer overrun. Use signed char, not 'int',
4153 for 'varies' array, so that we needn't bother to check its size
4154 calculation for overflow.
4155 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4156 * eval.c (apply_lambda):
4157 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4158 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4159 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4160
a1759b76
PE
4161 * callint.c (Fcall_interactively): Don't use index var as event count.
4162
d96be9fc
PE
4163 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4164 * mem-limits.h (SIZE): Remove; no longer used.
4165
a690a978 4166 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4167
578c21e6
PE
4168 Remove unnecessary casts.
4169 * xterm.c (x_term_init):
4170 * xfns.c (x_set_border_pixel):
4171 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4172 These aren't needed now that we assume ANSI C.
4173
96f53c6c
PE
4174 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4175 It's more likely to cause problems (due to unsigned overflow)
4176 than to cure them.
4177
83c77d31
PE
4178 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4179
ee2079f1
PE
4180 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4181
6da65536
PE
4182 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4183
7147c4a4
PE
4184 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4185
193e32d9
PE
4186 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4187
e5533da6
PE
4188 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4189
9910e595
PE
4190 GLYPH_CODE_FACE returns EMACS_INT, not int.
4191 * dispextern.h (merge_faces):
4192 * xfaces.c (merge_faces):
01103c44
PE
4193 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4194 Don't assume EMACS_INT fits in int.
9910e595 4195
2638320e
PE
4196 * character.h (CHAR_VALID_P): Remove unused parameter.
4197 * fontset.c, lisp.h, xdisp.c: All uses changed.
4198
045eb8d9
PE
4199 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4200
c1f134b5
PE
4201 * fns.c (concat): Minor tuning based on overflow analysis.
4202 This doesn't fix any bugs. Use int to hold character, instead
4203 of constantly refetching from Emacs object. Use XFASTINT, not
4204 XINT, for value known to be a character. Don't bother comparing
4205 a single byte to 0400, as it's always less.
4206
395fcb93 4207 * floatfns.c (Fexpt):
327eeec8
PE
4208 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4209
abbd3d23
PE
4210 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4211 for characters.
4212
684a03ef
PE
4213 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4214
0fed43f3
PE
4215 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4216 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4217 incorrectly succeed when S was a string, because 4294967386 was
4218 truncated before it was used.
4219
8fd02eb7
PE
4220 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4221 Otherwise, an out-of-range integer could cause undefined behavior
4222 on a 64-bit host.
4223
f8c86b69
PE
4224 * composite.c: Use int, not EMACS_INT, for characters.
4225 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4226 EMACS_INT, for values that are known to be in character range.
4227 This doesn't fix any bugs but is the usual style inside Emacs and
4228 may generate better code on 32-bit machines.
4229
34206dd2
PE
4230 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4231 This is for reasons similar to the recent CHAR_STRING fix.
4232 * charset.c (Fencode_char): Check that character arg is actually
4233 a character. Pass an int to ENCODE_CHAR.
4234 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4235 wider than 'int', as a compile-time check to prevent future regressions
4236 in this area.
4237
c5958d4c 4238 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4239
4240 Make sure a 64-bit char is never passed to CHAR_STRING.
4241 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4242 by silently ignoring the top 32 bits, allowing some values
4243 that were far too large to be valid characters.
4244 * character.h: Include <verify.h>.
4245 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4246 arguments are no wider than unsigned, as a compile-time check
4247 to prevent future regressions in this area.
4248 * data.c (Faset):
01103c44 4249 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4250 (Fsubst_char_in_region):
4251 * fns.c (concat):
4252 * xdisp.c (decode_mode_spec_coding):
4253 Adjust to CHAR_STRING's new requirement.
4254 * editfns.c (Finsert_char, Fsubst_char_in_region):
4255 * fns.c (concat): Check that character args are actually
4256 characters. Without this test, these functions did the wrong
4257 thing with wildly out-of-range values on 64-bit hosts.
4258
d37ca623
PE
4259 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4260 These casts should not be needed on 32-bit hosts, either.
4261 * keyboard.c (read_char):
4262 * lread.c (Fload): Remove casts to unsigned.
4263
ea204efb
PE
4264 * lisp.h (UNSIGNED_CMP): New macro.
4265 This fixes comparison bugs on 64-bit hosts.
4266 (ASCII_CHAR_P): Use it.
4267 * casefiddle.c (casify_object):
01103c44 4268 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4269 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4270 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4271 * dispextern.h (FACE_FROM_ID):
4272 * keyboard.c (read_char): Use UNSIGNED_CMP.
4273
41cb286c
PE
4274 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4275 not to EMACS_INT, to avoid GCC warning.
4276
4a1b9832
PE
4277 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4278
55daad71
PE
4279 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4280 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4281 isn't needed on 32-bit machines.
8f95c75c 4282
01103c44
PE
4283 * buffer.c (Fgenerate_new_buffer_name):
4284 Use EMACS_INT for count, not int.
0ceccced 4285 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4286
4287 * data.c (Qcompiled_function): Now static.
4288
c6f072e7
PE
4289 * window.c (window_body_lines): Now static.
4290
20ce5912
PE
4291 * image.c (gif_load): Rename local to avoid shadowing.
4292
9c4c5f81
PE
4293 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4294 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4295 * alloc.c (make_save_value): Integer argument is now of type
4296 ptrdiff_t, not int.
4297 (mark_object): Use ptrdiff_t, not int.
4298 * lisp.h (pD): New macro.
4299 * print.c (print_object): Use it.
4300
c0c5c8ae
PE
4301 * alloc.c: Use EMACS_INT, not int, to count objects.
4302 (total_conses, total_markers, total_symbols, total_vector_size)
4303 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4304 (total_free_floats, total_floats, total_free_intervals)
4305 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4306 Now EMACS_INT, not int. All uses changed.
4307 (Fgarbage_collect): Compute overall total using a double, so that
4308 integer overflow is less likely to be a problem. Check for overflow
4309 when converting back to an integer.
5a25e253
PE
4310 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4311 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4312 These were 'int' variables that could overflow on 64-bit hosts;
4313 they were never used, so remove them instead of repairing them.
211a0b2a 4314 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4315 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4316 Previously, this ceilinged at INT_MAX, but that doesn't work on
4317 64-bit machines.
e46bb31a 4318 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4319
c78baabf 4320 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4321 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4322 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4323 when a (possibly-narrower) signed value would do just as well.
4324 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4325
c9d624c6
PE
4326 * alloc.c: Catch some string size overflows that we were missing.
4327 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4328 for convenience in STRING_BYTES_MAX.
4329 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4330 The definition here is exact; the one in lisp.h was approximate.
4331 (allocate_string_data): Check for string overflow. This catches
4332 some instances we weren't catching before. Also, it catches
4333 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4334 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4335 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4336
c9d624c6
PE
4337 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4338 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4339 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4340
353032ce
PE
4341 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4342
2bccce07
PE
4343 * alloc.c (Fmake_string): Check for out-of-range init.
4344
0ac30604
SM
43452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4346
4347 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4348
c195f2de
JD
43492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4350
4351 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4352 xg_get_default_scrollbar_width.
4353
4354 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4355 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4356 (style_changed_cb): Call update_theme_scrollbar_width and call
4357 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4358 all frames (Bug#8505).
4359 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4360 Call gtk_window_set_resizable if HAVE_GTK3.
4361 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4362 and height if HAVE_GTK3 (Bug#8505).
4363 (scroll_bar_width_for_theme): New variable.
4364 (update_theme_scrollbar_width): New function.
4365 (xg_get_default_scrollbar_width): Move code to
4366 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4367 (xg_initialize): Call update_theme_scrollbar_width.
4368
4369 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4370
4371 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4372
e10ac9f1
MR
43732011-06-12 Martin Rudalics <rudalics@gmx.at>
4374
4375 * frame.c (make_frame): Call other_buffer_safely instead of
4376 other_buffer.
4377
4378 * window.c (temp_output_buffer_show): Call display_buffer with
4379 second argument Vtemp_buffer_show_specifiers and reset latter
4380 immediately after the call.
4381 (Vtemp_buffer_show_specifiers): New variable.
4382 (auto_window_vscroll_p, next_screen_context_lines)
4383 (Vscroll_preserve_screen_position): Remove leading asterisks from
4384 doc-strings.
4385
2d3c217e 43862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4387
7b7f97e8 4388 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4389 * buffer.c (Qclone_number): Remove for now, as it's unused.
4390 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4391 (record_buffer): Remove unused local.
4392 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4393 (set_frame_buffer_list): Remove; unused.
4394 * frame.h (other_visible_frames): Remove decl.
4395 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4396 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4397 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4398 if HAVE_GPM.
4399 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4400 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4401 Define only if HAVE_GPM.
4402 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4403 (update_hints_inhibit): Remove; never set. All uses removed.
4404 * widgetprv.h (emacsFrameClassRec): Remove decl.
4405 * window.c (delete_deletable_window): Now returns void, since it
4406 wasn't returning anything.
4407 (compare_window_configurations): Remove unused locals.
4408 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4409 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4410 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4411 the same widths as pointers. This follows up on the 2011-05-06 patch.
4412 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4413 * xterm.h: Likewise.
4414 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4415
1384b89e
JB
44162011-06-12 Juanma Barranquero <lekktu@gmail.com>
4417
4418 * makefile.w32-in: Update dependencies.
4419 (LISP_H): Add lib/intprops.h.
4420
1100a63c
CY
44212011-06-11 Chong Yidong <cyd@stupidchicken.com>
4422
4423 * image.c (gif_load): Add animation frame delay to the metadata.
4424 (syms_of_image): Use DEFSYM. New symbol `delay'.
4425
6198ccd0
MR
44262011-06-11 Martin Rudalics <rudalics@gmx.at>
4427
4428 * window.c (delete_deletable_window): Re-add.
4429 (Fset_window_configuration): Rewrite to handle dead buffers and
4430 consequently deletable windows.
4431 (window_tree, Fwindow_tree): Remove. Supply functionality in
4432 window.el.
4433 (compare_window_configurations): Simplify code.
4434
b6e3633c
AS
44352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4436
1ab0dee5
AS
4437 * image.c (imagemagick_load_image): Fix type mismatch.
4438 (Fimagemagick_types): Likewise.
4439
b6e3633c
AS
4440 * window.h (replace_buffer_in_windows): Declare.
4441
9397e56f
MR
44422011-06-11 Martin Rudalics <rudalics@gmx.at>
4443
4444 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4445 Qclone_number. Remove external declaration of Qdelete_window.
4446 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4447 code.
640c8776
SM
4448 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4449 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4450 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4451 buffer list implementation.
4452 (other_buffer_safely): New function.
4453 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4454 calls to replace_buffer_in_windows and
4455 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4456 if allowed.
4457 (record_buffer): Inhibit quitting and rewrite using quittable
4458 functions. Run Qbuffer_list_update_hook if allowed.
4459 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4460 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4461 Move switch-to-buffer to window.el.
9397e56f
MR
4462 (bury-buffer): Move to window.el.
4463 (Vbuffer_list_update_hook): New variable.
4464
4465 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4466 section.
4467
4468 * window.h (resize_frame_windows): Move up in code.
4469 (Fwindow_frame): Remove EXFUN.
4470 (replace_buffer_in_all_windows): Remove prototype.
4471 (replace_buffer_in_windows_safely): Add prototype.
4472
4473 * window.c: Declare Qdelete_window static again. Move down
4474 declaration of select_count.
4475 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4476 (Fother_window): Move to window.el.
4477 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4478 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4479 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4480 window.el.
4481 (replace_buffer_in_windows): Implement by calling
4482 Qreplace_buffer_in_windows.
4483 (replace_buffer_in_all_windows): Remove with some functionality
4484 moved into replace_buffer_in_windows_safely.
4485 (replace_buffer_in_windows_safely): New function.
4486 (select_window_norecord, select_frame_norecord): Move in front
4487 of run_window_configuration_change_hook. Remove now obsolete
4488 declarations.
640c8776
SM
4489 (Fset_window_buffer): Rewrite doc-string.
4490 Call Qrecord_window_buffer.
9397e56f
MR
4491 (keys_of_window): Move binding for other-window to window.el.
4492
b50691aa
CY
44932011-06-11 Chong Yidong <cyd@stupidchicken.com>
4494
4495 * dispextern.h (struct image): Replace data member, whose int_val
4496 and ptr_val fields were not used by anything, with a single
4497 lisp_val object.
4498
4499 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4500 (gif_clear_image, gif_load, imagemagick_load_image)
4501 (gs_clear_image, gs_load): Callers changed.
4502
3f754b86
PE
45032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4504
cca69397
PE
4505 * buffer.h: Include <time.h>, for time_t.
4506 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4507
109e28d0
PE
4508 Fix minor problems found by static checking.
4509
60737f02
PE
4510 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4511
4b66faf3
PE
4512 Make identifiers static if they are not used in other modules.
4513 * data.c (Qcompiled_function, Qframe, Qvector):
4514 * image.c (QimageMagick, Qsvg):
4515 * minibuf.c (Qmetadata):
4516 * window.c (resize_window_check, resize_root_window): Now static.
4517 * window.h (resize_window_check, resize_root_window): Remove decls.
4518
109e28d0
PE
4519 * window.c (window_deletion_count, delete_deletable_window):
4520 Remove; unused.
46a4ce9e
PE
4521 (window_body_lines): Now static.
4522 (Fdelete_other_windows_internal): Mark vars as initialized.
4523 Make sure 'resize_failed' is initialized.
4524 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4525 (resize_window_apply): Remove unused local.
4526 * window.h (delete_deletable_window): Remove decl.
4527
109e28d0 4528 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4529 (imagemagick_load_image): Fix pointer signedness problem by changing
4530 last arg from unsigned char * to char *. All uses changed.
4531 Also, fix a local for similar reasons.
4532 Remove unused locals. Remove locals to avoid shadowing.
4533 (fn_rsvg_handle_free): Remove; unused.
4534 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4535 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4536
3f754b86
PE
4537 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4538
2547adb1
CY
45392011-06-10 Chong Yidong <cyd@stupidchicken.com>
4540
4541 * image.c (gif_load): Fix omitted cast error introduced by
4542 2011-06-06 change.
4543
2c8e37d4
MR
45442011-06-10 Martin Rudalics <rudalics@gmx.at>
4545
4546 * window.h (resize_proportionally, orig_total_lines)
4547 (orig_top_line): Remove from window structure.
4548 (set_window_height, set_window_width, change_window_heights)
4549 (Fdelete_window): Remove prototypes.
4550 (resize_frame_windows): Remove duplicate declaration.
4551
440a42e3
EZ
45522011-06-10 Eli Zaretskii <eliz@gnu.org>
4553
4554 * window.h (resize_frame_windows, resize_window_check)
4555 (delete_deletable_window, resize_root_window)
4556 (resize_frame_windows): Declare prototypes.
4557
4558 * window.c (resize_window_apply): Make definition be "static" to
4559 match the prototype.
4560
562dd5e9
MR
45612011-06-10 Martin Rudalics <rudalics@gmx.at>
4562
4563 * window.c: Remove declarations of Qwindow_size_fixed,
4564 window_min_size_1, window_min_size_2, window_min_size,
4565 size_window, window_fixed_size_p, enlarge_window, delete_window.
4566 Remove static from declaration of Qdelete_window, it's
4567 temporarily needed by Fbury_buffer.
4568 (replace_window): Don't assign orig_top_line and
4569 orig_total_lines.
4570 (Fdelete_window, delete_window): Remove. Window deletion is
4571 handled by window.el.
640c8776
SM
4572 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4573 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4574 (Fdelete_other_windows): Remove. Deleting other windows is
4575 handled by window.el.
4576 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4577 handled in window.el.
4578 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4579 Window minimum sizes are handled in window.el.
4580 (shrink_windows, size_window, set_window_height)
4581 (set_window_width, change_window_heights, window_height)
4582 (window_width, CURBEG, CURSIZE, enlarge_window)
4583 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4584 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4585 handled in window.el.
4586 (make_dummy_parent): Rename to make_parent_window and give it a
4587 second argument horflag.
4588 (make_window): Don't set resize_proportionally any more.
4589 (Fsplit_window): Remove. Windows are split in window.el.
4590 (save_restore_action, save_restore_orig_size)
4591 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4592 Resize mini windows in window.el.
4593 (grow_mini_window, shrink_mini_window): Implement by calling
4594 Qresize_root_window_vertically, resize_window_check and
4595 resize_window_apply.
640c8776
SM
4596 (saved_window, Fset_window_configuration, save_window_save):
4597 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4598 resize_proportionally.
4599 (window_min_height, window_min_width): Move to window.el.
4600 (keys_of_window): Move bindings for delete-other-windows,
4601 split-window, delete-window and enlarge-window to window.el.
4602
4603 * buffer.c: Temporarily extern Qdelete_window.
4604 (Fbury_buffer): Temporarily call Qdelete_window instead of
4605 Fdelete_window (Fbury_buffer will move to window.el soon).
4606
4607 * frame.c (set_menu_bar_lines_1): Remove code handling
4608 orig_top_line and orig_total_lines.
4609
4610 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4611 set_window_height but set heights directly.
4612 (change_frame_size_1): Use resize_frame_windows.
4613
4614 * xdisp.c (init_xdisp): Don't use set_window_height but set
4615 heights directly.
4616
640c8776
SM
4617 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4618 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4619 run_window_configuration_change_hook.
4620
4621 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4622 instead of change_window_heights and run
4623 run_window_configuration_change_hook.
4624
1a13852e
MR
46252011-06-09 Martin Rudalics <rudalics@gmx.at>
4626
4627 * window.c (replace_window): Rename second argument REPLACEMENT to
4628 NEW. New third argument SETFLAG. Rewrite.
4629 (delete_window, make_dummy_parent): Call replace_window with
4630 third argument 1.
4631 (window_list_1): Move down in code.
4632 (run_window_configuration_change_hook): Move set_buffer part
4633 before select_frame_norecord part in order to unwind correctly.
4634 Rename count1 to count.
4635 (recombine_windows, delete_deletable_window, resize_root_window)
4636 (Fdelete_other_windows_internal)
4637 (Frun_window_configuration_change_hook, make_parent_window)
4638 (resize_window_check, resize_window_apply, Fresize_window_apply)
4639 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4640 (Fdelete_window_internal, Fresize_mini_window_internal):
4641 New functions.
1a13852e
MR
4642 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4643
f3d1777e
MR
46442011-06-08 Martin Rudalics <rudalics@gmx.at>
4645
496e208e
MR
4646 * window.h (window): Add some new members to window structure -
4647 normal_lines, normal_cols, new_total, new_normal, clone_number,
4648 splits, nest, prev_buffers, next_buffers.
4649 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4650 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4651
f3d1777e
MR
4652 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4653 Remove.
496e208e
MR
4654 (make_dummy_parent): Set new members of windows structure.
4655 (make_window): Move down in code. Handle new members of window
4656 structure.
4657 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4658 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4659 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4660 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4661 (Fset_window_next_buffers, Fset_window_clone_number):
4662 New functions.
496e208e
MR
4663 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4664 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4665 Doc-string fixes.
4666 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4667 Argument WINDOW can be now internal window too.
4668 (Fwindow_use_time): Move up in code.
4669 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4670 Rewrite doc-string.
4671 (Fset_window_configuration, saved_window)
4672 (Fcurrent_window_configuration, save_window_save): Handle new
4673 members of window structure.
b9e809c2
MR
4674 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4675 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4676 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4677 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4678 Qget_mru_window, Qresize_root_window,
4679 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4680 Qauto_buffer_name; staticpro them.
f3d1777e 4681
abde8f8c
MR
46822011-06-07 Martin Rudalics <rudalics@gmx.at>
4683
4684 * window.c (Fwindow_total_size, Fwindow_left_column)
4685 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4686 (Fwindow_list_1): New functions.
4687 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4688 (Fwindow_width, Fscroll_left, Fscroll_right):
4689 Use window_body_cols instead of window_box_text_cols.
4690 (delete_window, Fset_window_configuration):
4691 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4692 (delete_all_subwindows): Take a window as argument and not a
4693 structure. Rewrite.
190b47e6
MR
4694 (window_loop): Remove handling of GET_LRU_WINDOW and
4695 GET_LARGEST_WINDOW.
4696 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4697
4698 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4699 window_box_text_cols. delete_all_subwindows now takes a
4700 Lisp_Object as argument.
abde8f8c 4701
640c8776
SM
4702 * indent.c (compute_motion, Fcompute_motion):
4703 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4704
fa8a67e6
MR
4705 * frame.c (delete_frame): Call delete_all_subwindows with root
4706 window as argument.
4707
a54e3482
DC
47082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4709
4710 * fns.c (Fputhash): Document return value.
4711
60002bf5
CY
47122011-06-06 Chong Yidong <cyd@stupidchicken.com>
4713
4714 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4715
0c671da6 47162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4717
b862a52a 4718 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4719
be44ca6c
PE
4720 Check for overflow when converting integer to cons and back.
4721 * charset.c (Fdefine_charset_internal, Fdecode_char):
4722 Use cons_to_unsigned to catch overflow.
4723 (Fencode_char): Use INTEGER_TO_CONS.
4724 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4725 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4726 * data.c (long_to_cons, cons_to_long): Remove.
4727 (cons_to_unsigned, cons_to_signed): New functions.
4728 These signal an error for invalid or out-of-range values.
4729 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4730 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4731 * font.c (Ffont_variation_glyphs):
4732 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4733 * lisp.h: Include <intprops.h>.
4734 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4735 (cons_to_signed, cons_to_unsigned): New decls.
4736 (long_to_cons, cons_to_long): Remove decls.
4737 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4738 (Fprimitive_undo): Use CONS_TO_INTEGER.
4739 * xfns.c (Fx_window_property): Likewise.
4740 * xselect.c: Include <limits.h>.
4741 (x_own_selection, selection_data_to_lisp_data):
4742 Use INTEGER_TO_CONS.
4743 (x_handle_selection_request, x_handle_selection_clear)
4744 (x_get_foreign_selection, Fx_disown_selection_internal)
4745 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4746 (lisp_data_to_selection_data): Use cons_to_unsigned.
4747 (x_fill_property_data): Use cons_to_signed.
4748 Report values out of range.
4749
d1f3d2af
PE
4750 Check for buffer and string overflow more precisely.
4751 * buffer.h (BUF_BYTES_MAX): New macro.
4752 * lisp.h (STRING_BYTES_MAX): New macro.
4753 * alloc.c (Fmake_string):
4754 * character.c (string_escape_byte8):
4755 * coding.c (coding_alloc_by_realloc):
4756 * doprnt.c (doprnt):
4757 * editfns.c (Fformat):
4758 * eval.c (verror):
4759 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4760 since they may not be the same number.
4761 * editfns.c (Finsert_char):
4762 * fileio.c (Finsert_file_contents):
4763 Likewise for BUF_BYTES_MAX.
4764
dd52fcea
PE
4765 * image.c: Use ptrdiff_t, not int, for sizes.
4766 (slurp_file): Switch from int to ptrdiff_t.
4767 All uses changed.
4768 (slurp_file): Check that file size fits in both size_t (for
4769 malloc) and ptrdiff_t (for sanity and safety).
4770
7f9bbdbb
PE
4771 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4772 if b->modtime has its maximal value.
4773
dfe18f82
PE
4774 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4775
84acfcf0
PE
4776 Don't assume time_t can fit into int.
4777 * buffer.h (struct buffer.modtime): Now time_t, not int.
4778 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4779 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4780
ccd9a01a
PE
4781 Minor fixes for signed vs unsigned integers.
4782 * character.h (MAYBE_UNIFY_CHAR):
4783 * charset.c (maybe_unify_char):
4784 * keyboard.c (read_char, reorder_modifiers):
4785 XINT -> XFASTINT, since the integer must be nonnegative.
4786 * ftfont.c (ftfont_spec_pattern):
4787 * keymap.c (access_keymap, silly_event_symbol_error):
4788 XUINT -> XFASTINT, since the integer must be nonnegative.
4789 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4790 since it makes no difference and we prefer signed.
4791 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4792 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4793 nonnegative.
4794
d6d100dd
SM
47952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4796
4797 * window.h (Fwindow_frame): Declare.
4798
2b6148e4
PE
47992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4800
4801 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4802 (SPARE_MEMORY): Always define.
4803 (LARGE_REQUEST): Remove.
4804 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4805
f230ecc9
MR
48062011-06-06 Martin Rudalics <rudalics@gmx.at>
4807
727e958e
MR
4808 * lisp.h: Move EXFUNS for Fframe_root_window,
4809 Fframe_first_window and Fset_frame_selected_window to window.h.
4810
4811 * window.h: Move EXFUNS for Fframe_root_window,
4812 Fframe_first_window and Fset_frame_selected_window here from
4813 lisp.h.
4814
4815 * frame.c (Fwindow_frame, Fframe_first_window)
4816 (Fframe_root_window, Fframe_selected_window)
4817 (Fset_frame_selected_window): Move to window.c.
4818 (Factive_minibuffer_window): Move to minibuf.c.
4819 (Fother_visible_frames_p): New function.
4820
4821 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4822
f230ecc9
MR
4823 * window.c (decode_window, decode_any_window): Move up in code.
4824 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4825 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4826 (Fwindow_buffer): Move up and rewrite doc-string.
4827 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4828 (Fwindow_prev): New functions.
727e958e
MR
4829 (Fwindow_frame): Move here from frame.c. Accept any window as
4830 argument.
4831 (Fframe_root_window, Fframe_first_window)
4832 (Fframe_selected_window): Move here from frame.c. Accept frame
4833 or arbitrary window as argument. Update doc-strings.
4834 (Fminibuffer_window): Move up in code.
4835 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4836 (Fset_frame_selected_window): Move here from frame.c.
4837 Marginal rewrite.
727e958e
MR
4838 (Fselected_window, select_window, Fselect_window): Move up in
4839 code. Minor doc-string fixes.
f230ecc9 4840
4d09bcf6
PE
48412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4842
4843 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4844 Do not assume that spare memory exists; that assumption is valid
4845 only if SYSTEM_MALLOC.
4846 (LARGE_REQUEST): New macro, so that the issue of large requests
4847 is separated from the issue of spare memory.
4848
810928a2
AS
48492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4850
172418ad
AS
4851 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4852 format. (Bug#8806)
4853
43f862f7
AS
4854 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4855
810928a2
AS
4856 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4857 before statements.
4858
a059fe24
JD
48592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4860
4861 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4862
4863 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4864
4865 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4866 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4867
989bf368
JB
48682011-06-05 Juanma Barranquero <lekktu@gmail.com>
4869
4870 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4871
4b80f674
CY
48722011-06-04 Chong Yidong <cyd@stupidchicken.com>
4873
4874 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4875 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4876 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4877 New error handlers.
4b80f674
CY
4878 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4879 Obey Vx_select_enable_clipboard_manager. Catch errors in
4880 x_clipboard_manager_save (Bug#8779).
4881 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4882 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4883
99a33b77 48842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4885
4886 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4887
99a33b77 48882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4889
4890 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4891 in the current matrix if keep_current_p is non-zero.
4892
8264569d
EZ
48932011-06-04 Eli Zaretskii <eliz@gnu.org>
4894
4895 * bidi.c (bidi_level_of_next_char): Fix last change.
4896
57f97249
EZ
48972011-06-03 Eli Zaretskii <eliz@gnu.org>
4898
fec2107c 4899 Support bidi reordering of text covered by display properties.
57f97249 4900
fec2107c
EZ
4901 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4902 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4903 (bidi_cache_search, bidi_cache_iterator_state)
4904 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4905 (bidi_level_of_next_char, bidi_move_to_visually_next):
4906 Support character positions inside a run of characters covered by a
fec2107c
EZ
4907 display string.
4908 (bidi_paragraph_init, bidi_resolve_explicit_1)
4909 (bidi_level_of_next_char): Call bidi_fetch_char and
4910 bidi_fetch_char_advance instead of FETCH_CHAR and
4911 FETCH_CHAR_ADVANCE.
4912 (bidi_init_it): Initialize new members.
4913 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4914 definitions.
4915 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4916 instead of using explicit *_CHAR codes.
d6d100dd
SM
4917 (bidi_resolve_explicit, bidi_resolve_weak):
4918 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4919 bidirectional text is supported only in multibyte buffers.
4920 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4921 it to initialize the frame_window_p member of struct bidi_it.
4922 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4923 (bidi_resolve_explicit, bidi_resolve_weak)
4924 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4925 bidi_it->nchars is non-positive.
4926 (bidi_level_of_next_char): Don't try to lookup the cache for the
4927 next/previous character if nothing is cached there yet, or if we
4928 were just reseat()'ed to a new position.
c40e2fb2 4929
0e14fe90
EZ
4930 * xdisp.c (set_cursor_from_row): Set start and stop points
4931 according to the row's direction when priming the loop that looks
4932 for the glyph on which to display cursor.
4933 (single_display_spec_intangible_p): Function deleted.
4934 (display_prop_intangible_p): Reimplement to call
4935 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4936 Accept 3 additional arguments needed by handle_display_spec.
4937 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4938 values: lists, `(when COND...)' forms, etc.
4939 (single_display_spec_string_p): Support property values that are
4940 lists with the argument STRING its top-level element.
4941 (display_prop_string_p): Fix the condition for processing a
4942 property that is a list to be consistent with handle_display_spec.
fec2107c 4943 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4944 last portion of handle_display_prop.
4945 (compute_display_string_pos): Accept additional argument
4946 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4947 value of a `display' property is a "replacing spec".
4948 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4949 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4950 the display property, but just return a value indicating whether
4951 the display property will replace the characters it covers.
4952 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4953 frame_window_p members of struct bidi_it.
d6d100dd
SM
4954 (compute_display_string_pos, compute_display_string_end):
4955 New functions.
fec2107c
EZ
4956 (push_it): Accept second argument POSITION, where pop_it should
4957 jump to continue iteration.
4958 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4959
fec2107c
EZ
4960 * keyboard.c (adjust_point_for_property): Adjust the call to
4961 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4962
4963 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4964 (bidi_init_it): Update prototypes.
4965 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4966 (compute_display_string_pos, compute_display_string_end):
4967 Declare prototypes.
fec2107c
EZ
4968 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4969 EMACS_INT.
fc6f18ce 4970
40087514 49712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4972
57f53182
PE
4973 Malloc failure behavior now depends on size of allocation.
4974 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4975 * lisp.h: Change signatures accordingly.
4976 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4977 All callers changed. (Bug#8762)
4978
4979 * gnutls.c: Use Emacs's memory allocators.
4980 Without this change, the gnutls library would invoke malloc etc.
4981 directly, which causes problems on non-SYNC_INPUT hosts, and which
4982 runs afoul of improving memory_full behavior. (Bug#8761)
4983 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4984 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4985 xfree instead of the default malloc, realloc, free.
4986 (Fgnutls_boot): No need to check for memory allocation failure,
4987 since xmalloc does that for us.
4988
ac32cd99 4989 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4990 * category.c (hash_get_category_set):
4991 * ccl.c (ccl_driver):
4992 * charset.c (Fdefine_charset_internal):
4993 * charset.h (struct charset.hash_index):
4994 * composite.c (get_composition_id, gstring_lookup_cache)
4995 (composition_gstring_put_cache):
4996 * composite.h (struct composition.hash_index):
4997 * dispextern.h (struct image.hash):
4998 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4999 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5000 (hashfn_equal, hashfn_user_defined, make_hash_table)
5001 (maybe_resize_hash_table, hash_lookup, hash_put)
5002 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5003 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5004 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5005 * image.c (make_image, search_image_cache, lookup_image)
5006 (xpm_put_color_table_h):
5007 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5008 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5009 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5010 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5011 * alloc.c (allocate_vectorlike):
5012 Check for overflow in vector size calculations.
5013 * ccl.c (ccl_driver):
5014 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5015 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5016 need to be updated by these changes.
40087514
PE
5017 * fns.c (make_hash_table, maybe_resize_hash_table):
5018 Check for integer overflow with large hash tables.
0de4bb68
PE
5019 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5020 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5021 (SXHASH_REDUCE): New macro.
5022 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5023 Use it instead of discarding useful hash info with large hash values.
5024 (sxhash_float): New function.
5025 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5026 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5027 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5028 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5029 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5030 Adjust signatures to match updated version of code.
5031 (consing_since_gc): Now EMACS_INT, since a single hash table can
5032 use more than INT_MAX bytes.
5033
698d32e2
DN
50342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5035
5036 Make it possible to build with GCC-4.6+ -O2 -flto.
5037
5038 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5039
fd6fa53f
SM
50402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5041
5042 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5043 Call minibuffer-inactive-mode.
5044
864db017
JB
50452011-05-31 Juanma Barranquero <lekktu@gmail.com>
5046
5047 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5048 Update dependencies.
5049
2ad0baf4
DN
50502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5051
5052 * data.c (init_data): Remove code for UTS, this system is not
5053 supported anymore.
5054
4fcc2638
DN
50552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5056
5057 Don't force ./temacs to start in terminal mode.
5058
5059 * frame.c (make_initial_frame): Initialize faces in all cases, not
5060 only when CANNOT_DUMP is defined.
5061 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5062
c56e0fd5
DN
50632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5064
5065 * dispnew.c (add_window_display_history): Use const for the string
5066 pointer. Remove declaration, not needed.
5067
333d54da 50682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5069
55d4c1b2 5070 Use 'inline', not 'INLINE'.
333d54da 5071 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5072 * alloc.c, fontset.c (INLINE): Remove.
5073 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5074 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5075 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5076 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5077 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5078
738db178
DN
50792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5080
5081 Make it possible to run ./temacs.
5082
5083 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5084 syms_of_callproc does the same thing. Remove test for
5085 "initialized", do it in the caller.
5086 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5087
620c53a6
SM
50882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5089
5090 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5091 (read_minibuf): Use get_minibuffer.
5092 (syms_of_minibuf): Use DEFSYM.
5093 (Qmetadata): New var.
5094 * data.c (Qbuffer): Don't make it static.
5095 (syms_of_data): Use DEFSYM.
5096
e003a292
PE
50972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5098
5099 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5100 (CCL_CODE_MIN): New macro.
5101
ed008a6d
PE
51022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5103
3687c2ef
PE
5104 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5105
ed008a6d
PE
5106 * eval.c (Qdebug): Now static.
5107 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5108 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5109 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5110
d66c4c7c
CY
51112011-05-29 Chong Yidong <cyd@stupidchicken.com>
5112
5113 * image.c: Various fixes to ImageMagick code comments.
5114 (Fimagemagick_types): Doc fix.
5115
5fbc2025
PE
51162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5117
0196f88a
PE
5118 Minor fixes prompted by GCC 4.6.0 warnings.
5119
5120 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5121
5fbc2025
PE
5122 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5123 (x_clipboard_manager_save_all): Move extern decl to ...
5124 * xterm.h: ... here, so that it can be checked for consistency.
5125
1dd3c2d9
CY
51262011-05-29 Chong Yidong <cyd@stupidchicken.com>
5127
5128 * xselect.c (x_clipboard_manager_save_frame)
5129 (x_clipboard_manager_save_all): New functions.
5130 (Fx_clipboard_manager_save): Lisp function deleted.
5131
5132 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5133 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5134
5135 * xterm.h: Update prototype.
5136
5ba6571d
WX
51372011-05-28 William Xu <william.xwl@gmail.com>
5138
5139 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5140 exiting (Bug#8239).
5141
3eaff834
JM
51422011-05-28 Jim Meyering <meyering@redhat.com>
5143
e1900994 5144 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5145 * fns.c (to_uchar): Define.
5146 (crypto_hash_function): Use it to convert some newly-signed
5147 variables to unsigned, to avoid sign-extension bugs. For example,
5148 without this change, (md5 "truc") would evaluate to
5149 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5150 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5151 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5152
0f6990a7
PE
51532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5154
5155 Integer overflow fixes.
c8a9ca5a 5156
08686060
PE
5157 * dbusbind.c: Serial number integer overflow fixes.
5158 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5159 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5160 to hold a serial number that is too large for a fixnum.
5161 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5162 Check for serial numbers out of range. Decode any serial number
59568bf0 5163 that was so large that it became a float. (Bug#8722)
08686060 5164
2d1fc3c7
PE
5165 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5166 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5167 Use XFASTINT rather than XUINT when numbers are nonnegative.
5168 (xd_append_arg, Fdbus_method_return_internal):
5169 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5170 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5171 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5172 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5173 (Bug#8722)
2d1fc3c7 5174
c8a9ca5a
PE
5175 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5176
519e1d69
PE
5177 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5178
30569699
PE
5179 ccl: add integer overflow checks
5180 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5181 (IN_INT_RANGE): New macros.
5182 (ccl_driver): Use them to check for integer overflow when
5183 decoding a CCL program. Many of the new checks are whether XINT (x)
5184 fits in int; it doesn't always, on 64-bit hosts. The new version
5185 doesn't catch all possible integer overflows, but it's an
847044ea 5186 improvement. (Bug#8719)
30569699 5187
c11285dc
PE
5188 * alloc.c (make_event_array): Use XINT, not XUINT.
5189 There's no need for unsigned here.
5190
fdccd48e
PE
5191 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5192 This follows up to the 2011-05-06 change that substituted uintptr_t
5193 for EMACS_INT. This case wasn't caught back then.
5194
37910ab2
PE
5195 Rework Fformat to avoid integer overflow issues.
5196 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5197 now (part of C89). Include <verify.h>.
5198 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5199 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5200 (Fformat): Avoid the prepass trying to compute sizes; it was only
5201 approximate and thus did not catch overflow reliably. Instead, walk
5202 through the format just once, formatting and computing sizes as we go,
5203 checking for integer overflow at every step, and allocating a larger
5204 buffer as needed. Keep track separately whether the format is
5205 multibyte. Keep only the most-recently calculated precision, rather
5206 than them all. Record whether each argument has been converted to
5207 string. Use EMACS_INT, not int, for byte and char and arg counts.
5208 Support field widths and precisions larger than INT_MAX. Avoid
5209 sprintf's undefined behavior with conversion specifications such as %#d
5210 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5211 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5212 formatting out-of-range floating point numbers with int
9173deec 5213 formats. (Bug#8668)
37910ab2 5214
2e6578fb
PE
5215 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5216
0ae6bdee
PE
5217 * data.c: Avoid integer truncation in expressions involving floats.
5218 * data.c: Include <intprops.h>.
5219 (arith_driver): When there's an integer overflow in an expression
5220 involving floating point, convert the integers to floating point
5221 so that the resulting value does not suffer from catastrophic
5222 integer truncation. For example, on a 64-bit host (* 4
5223 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5224 Do not rely on undefined behavior after integer overflow.
5225
de883a70
PE
5226 merge count_size_as_multibyte, parse_str_to_multibyte
5227 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5228 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5229 Check for integer overflow.
5230 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5231 since it's now a duplicate of the other. This is more of
5232 a character than a buffer op, so better that it's in character.c.
5233 * fns.c, print.c: Adjust to above changes.
5234
2ff916cb
PE
52352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5236
5237 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5238
f1b54466
PE
52392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5240
fb1ac845
PE
5241 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5242 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5243 (x_clipboard_manager_save): Now static.
5244 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5245
f1b54466
PE
5246 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5247 (crypto_hash_function): Now static.
5248 Fix pointer signedness problems. Avoid unnecessary initializations.
5249
a9f737ee
CY
52502011-05-27 Chong Yidong <cyd@stupidchicken.com>
5251
5252 * termhooks.h (Vselection_alist): Make it terminal-local.
5253
5254 * terminal.c (create_terminal): Initialize it.
5255
5256 * xselect.c: Support for clipboard managers.
5257 (Vselection_alist): Move to termhooks.h as terminal-local var.
5258 (LOCAL_SELECTION): New macro.
5259 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5260 (symbol_to_x_atom): Remove gratuitous arg.
5261 (x_handle_selection_request, lisp_data_to_selection_data)
5262 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5263 (x_own_selection, x_get_local_selection, x_convert_selection):
5264 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5265 (some_frame_on_display): Delete unused function.
5266 (Fx_own_selection_internal, Fx_get_selection_internal)
5267 (Fx_disown_selection_internal, Fx_selection_owner_p)
5268 (Fx_selection_exists_p): New optional frame arg.
5269 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5270 (x_handle_selection_clear): Don't treat other terminals with the
5271 same keyboard specially. Use the terminal-local Vselection_alist.
5272 (x_clear_frame_selections): Use Frun_hook_with_args.
5273
5274 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5275
5276 * xterm.h: Add support for those atoms.
5277
e067f0c1
CY
52782011-05-26 Chong Yidong <cyd@stupidchicken.com>
5279
5280 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5281 (converted_selections, conversion_fail_tag): New global variables.
5282 (x_selection_request_lisp_error): Free the above.
5283 (x_get_local_selection): Remove unnecessary code.
5284 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5285 of converted selections stored in converted_selections.
5286 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5287 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5288 (x_convert_selection): New function.
5289 (x_handle_selection_event): Simplify.
5290 (x_get_foreign_selection): Don't ignore incoming requests while
5291 waiting for an answer; this will fail when we implement
5292 SAVE_TARGETS, and seems unnecessary anyway.
5293 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5294 (Vx_sent_selection_functions): Doc fix.
5295
0f4aebc0
LL
52962011-05-26 Leo Liu <sdl.web@gmail.com>
5297
5298 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5299
e61124cd
YM
53002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5301
5302 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5303
5304 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5305 for fringe update if it has periodic bitmap.
ac389d0c 5306 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5307 and fringe_bitmap_periodic_p.
5308
5309 * fringe.c (get_fringe_bitmap_data): New function.
5310 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5311 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5312 row. Mark glyph row for fringe update if periodicity changed.
5313
5314 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5315 for fringe update unless it has periodic bitmap.
5316
f16d9837
KH
53172011-05-25 Kenichi Handa <handa@m17n.org>
5318
5319 * xdisp.c (get_next_display_element): Set correct it->face_id for
5320 a static composition.
5321
e1b90ef6
LL
53222011-05-24 Leo Liu <sdl.web@gmail.com>
5323
5324 * deps.mk (fns.o):
5325 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5326
5327 * fns.c (crypto_hash_function, Fsha1): New function.
5328 (Fmd5): Use crypto_hash_function.
5329 (syms_of_fns): Add Ssha1.
5330
7400048f
PE
53312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5332
5333 * gnutls.c: Remove unused macros.
5334 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5335 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5336 Remove macros that are defined and never used.
5337 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5338
abb71cf4
CY
53392011-05-22 Chong Yidong <cyd@stupidchicken.com>
5340
5341 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5342 (Fx_get_selection_internal): Minor cleanup.
5343 (Fx_own_selection_internal): Rename arguments for consistency with
5344 select.el.
5345
6307db39
PE
53462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5349
f3d4e0a4
CY
53502011-05-22 Chong Yidong <cyd@stupidchicken.com>
5351
5352 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5353
4d8ade89
YM
53542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5355
5356 * dispnew.c (scrolling_window): Don't exclude the case that the
5357 last enabled row in the desired matrix touches the bottom boundary.
5358
32078c8d
GM
53592011-05-21 Glenn Morris <rgm@gnu.org>
5360
5361 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5362 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5363 and add some more files.
32078c8d 5364
7285dc67
EZ
53652011-05-20 Eli Zaretskii <eliz@gnu.org>
5366
5367 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5368 report_file_error introduced by the change from 2011-05-07.
5369
89d1bd22
PE
53702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5371
5372 * systime.h (Time): Define only if emacs is defined.
5373 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5374 where the include path doesn't have X11/X.h by default. See
5375 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5376
e23640bb 53772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5378
5379 * composite.c (find_automatic_composition): Fix previous change.
5380
b9704ad9
GM
53812011-05-20 Glenn Morris <rgm@gnu.org>
5382
5383 * lisp.mk: New file, split from Makefile.in.
5384 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5385 (shortlisp): Remove.
5386 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5387
4a720484
GM
53882011-05-19 Glenn Morris <rgm@gnu.org>
5389
5390 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5391 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5392 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5393 (lisp): Set the order to that of loadup.el.
5394 (shortlisp): Make it a copy of $lisp.
5395 (SOME_MACHINE_LISP): Remove.
5396 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5397 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5398
a28d4396
KH
53992011-05-18 Kenichi Handa <handa@m17n.org>
5400
5401 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5402 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5403 (find_automatic_composition): Mostly rewrite for efficiency.
5404
a2b1fa8e
JB
54052011-05-18 Juanma Barranquero <lekktu@gmail.com>
5406
5407 * makefile.w32-in: Update dependencies.
5408
8e1f5610
CS
54092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5410
5411 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5412 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5413
7025ee00 54142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5415
cdfa6eab
PE
5416 Fix some integer overflow issues, such as string length overflow.
5417
06d6db33
PE
5418 * insdel.c (count_size_as_multibyte): Check for string overflow.
5419
2b4560a8
PE
5420 * character.c (lisp_string_width): Check for string overflow.
5421 Use EMACS_INT, not int, for string indexes and lengths; in
5422 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5423 the resulting string length overflows an EMACS_INT; instead,
5424 report a string overflow if no precision given. When checking for
5425 precision exhaustion, use a check that cannot possibly have
5426 integer overflow. (Bug#8675)
5427 * character.h (lisp_string_width): Adjust to new signature.
5428
cb93f9be
PE
5429 * alloc.c (string_overflow): New function.
5430 (Fmake_string): Use it. This doesn't change behavior, but saves
5431 a few bytes and will simplify future changes.
5432 * character.c (string_escape_byte8): Likewise.
5433 * lisp.h (string_overflow): New decl.
5434
1a1f3366
PE
5435 Fixups, following up to the user-interface timestamp change.
5436 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5437 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5438 * msdos.c (mouse_get_pos): Likewise.
5439 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5440 * w32gui.h (Time): Define by including "systime.h" rather than by
5441 declaring it ourselves. (Bug#8664)
5442
d4e3e4d3
PE
5443 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5444 * image.c (clear_image_cache): Likewise.
5445
f6a24d19
PE
5446 * term.c (term_mouse_position): Don't assume time_t wraparound.
5447
08dc5ae6
PE
5448 Be more systematic about user-interface timestamps.
5449 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5450 and sometimes 'EMACS_UINT', to represent these timestamps.
5451 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5452 This makes the code easier to follow, and makes it easier to catch
5453 integer overflow bugs such as Bug#8664.
5454 * frame.c (Fmouse_position, Fmouse_pixel_position):
5455 Use Time, not unsigned long, for user-interface timestamps.
5456 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5457 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5458 * keyboard.h (last_event_timestamp): Likewise.
5459 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5460 * menu.h (xmenu_show): Likewise.
5461 * term.c (term_mouse_position): Likewise.
5462 * termhooks.h (struct input_event.timestamp): Likewise.
5463 (struct terminal.mouse_position_hook): Likewise.
5464 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5465 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5466 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5467 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5468 what it was before.
5469 * menu.h, termhooks.h: Include "systime.h", for Time.
5470
8e55734a
PE
5471 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5472 Don't assume that the difference between two unsigned long values
5473 can fit into an integer. At this point, we know button_down_time
5474 <= event->timestamp, so the difference must be nonnegative, so
5475 there's no need to cast the result if double-click-time is
5476 nonnegative, as it should be; check that it's nonnegative, just in
5477 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5478 apart (about 25 days). (Bug#8664)
8e55734a 5479
841f1b75 5480 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5481 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5482
3e26f69c
PE
5483 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5484 that always fit in int. Use a sentinel instead of a counter, to
5485 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5486 * frame.h (struct frame): Use int for menu_bar_items_used
5487 instead of EMACS_INT, since it always fits in int.
3e26f69c 5488
5cc152c0
PE
5489 * menu.c (grow_menu_items): Check for int overflow.
5490
d89eb65e
PE
5491 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5492
5235bd3e
PE
5493 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5494 Before, the code was not consistent. These values cannot exceed
5495 2**31 - 1 so there's no need to make them unsigned.
5496 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5497 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5498 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5499 as modifiers.
5500 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5501
bc827e23
PE
5502 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5503 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5504 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5505 presumably because the widths might not match.
5506
78eb494e
PE
5507 * window.c (size_window): Avoid needless test at loop start.
5508
04f2d78b
CB
55092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5510
5511 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5512
d2fc7e3d 55132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5514
5515 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5516
d2fc7e3d 55172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5518
5519 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5520 `width' to `bar_area_x' and `bar_area_width', respectively.
5521 (x_scroll_run): Take account of fringe background extension.
5522
04f2d78b
CB
5523 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5524 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5525 `bar_area_width', respectively.
5526 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5527 background extension.
5528
79b70037
GM
55292011-05-10 Jim Meyering <meyering@redhat.com>
5530
5531 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5532
2f142cc5
JB
55332011-05-10 Juanma Barranquero <lekktu@gmail.com>
5534
5535 * image.c (Finit_image_library): Return t for built-in image types,
5536 like pbm and xbm. (Bug#8640)
5537
57679c86
AS
55382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5539
5540 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5541
888c9e86
EZ
55422011-05-07 Eli Zaretskii <eliz@gnu.org>
5543
b0512a1d
EZ
5544 * w32console.c (Fset_screen_color): Doc fix.
5545 (Fget_screen_color): New function.
5546 (syms_of_ntterm): Defsubr it.
5547
7285dc67
EZ
5548 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5549 unlink the temporary file if Fcall_process didn't create it in the
5550 first place.
5551 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5552 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5553 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5554 cue to call_process_cleanup not to close that handle.
5555
4d3fcc8e
BK
55562011-05-07 Ben Key <bkey76@gmail.com>
5557
5558 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5559 one of two shell specific rules, either bootstrap-temacs-CMD or
5560 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5561 to the previous implementation of the bootstrap-temacs rule.
5562 The bootstrap-temacs-CMD rule is similar to the previous
5563 implementation of the bootstrap-temacs rule except that it
5564 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5565 variable.
5566
5567 These changes, along with some changes to nt/configure.bat,
5568 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5569 earlier fix to add support for --cflags and --ldflags options
5570 that include quotes so that it works whether make uses cmd or
5571 sh as the shell.
5572
b4289b64
MA
55732011-05-06 Michael Albinus <michael.albinus@gmx.de>
5574
5575 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5576 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5577 is a constant.
5578 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5579 a string. Handle both cases.
5580 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5581 (Fdbus_register_method): Use Qinvalid_function.
5582
af4c0e28
JB
55832011-05-06 Juanma Barranquero <lekktu@gmail.com>
5584
5585 * makefile.w32-in: Update dependencies.
5586 (LISP_H): Add inttypes.h and stdin.h.
5587 (PROCESS_H): Add unistd.h.
5588
c51453d9
EZ
55892011-05-06 Eli Zaretskii <eliz@gnu.org>
5590
5591 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5592 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5593
8ff0ac3c 55942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5595
4c4b566b
PE
5596 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5597
aab2b9b5
PE
5598 * term.c (vfatal): Remove stray call to va_end.
5599 It's not needed and the C Standard doesn't allow it here anyway.
5600
c378da0b
PE
5601 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5602 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5603
288b08c7
PE
5604 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5605 bytes.
5606
e3601888
PE
5607 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5608
db6c0e74
PE
5609 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5610
dd5963ea
PE
5611 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5612
88c9450f
PE
5613 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5614
2f9442b8
PE
5615 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5616
c032b5f8
PE
5617 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5618 * charset.c (Fdefine_charset_internal): Don't initialize
5619 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5620 32-bit int (Bug#8600).
a108c10b
PE
5621
5622 * lread.c (read_integer): Be more consistent with string-to-number.
5623 Use string_to_number to do the actual conversion; this avoids
5624 rounding errors and fixes some other screwups. Without this fix,
5625 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5626 (digit_to_number): Move earlier, for benefit of read_integer.
5627 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5628 not a digit in any supported base. (Bug#8602)
a108c10b 5629
ad5f9eea
PE
5630 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5631
aec1708a
PE
5632 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5633 to match comment at start of function. This also removes a
5634 GCC warning about overflow in a 32+64-bit port.
5635
47be4ab5
PE
5636 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5637
371cac43
PE
5638 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5639 Reported by Stefan Monnier in
5640 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5641 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5642 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5643
d01a7826
PE
5644 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5645 (EMACS_UINTPTR): Likewise, with uintptr_t.
5646
7fd47d5c
PE
5647 * lisp.h: Prefer 64-bit EMACS_INT if available.
5648 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5649 on 32-bit hosts that have 64-bit int, so that they can access
5650 large files.
122b0c86
PE
5651 However, temporarily disable this change unless the temporary
5652 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5653
8727937b
PE
5654 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5655
8ac068ac
PE
5656 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5657 This removes an assumption that EMACS_INT and long are the same
5658 width as pointers. The assumption is true for Emacs porting targets
5659 now, but we want to make other targets possible.
5660 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5661 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5662 In the rest of the code, change types of integers that hold casted
5663 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5664 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5665 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5666 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5667 No need to cast type when ORing.
5668 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5669 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5670 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5671 assume EMACS_INT is the same width as char *.
5672 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5673 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5674 Remove no-longer-needed casts.
5675 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5676 (xg_tool_bar_help_callback, xg_make_tool_item):
5677 Use EMACS_INTPTR to hold an integer
5678 that will be cast to void *; this can avoid a GCC warning
5679 if EMACS_INT is not the same width as void *.
5680 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5681 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5682 (current_message_1, set_message_1):
5683 Use a local to convert to proper width without a cast.
5684 * xmenu.c (dialog_selection_callback): Likewise.
5685
ede49d71
PE
5686 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5687 Also, don't assume VALBITS / RAND_BITS is less than 5,
5688 and don't rely on undefined behavior when shifting a 1 left into
5689 the sign bit.
5690 * lisp.h (get_random): Change signature to match.
5691
2f30ecd0
PE
5692 * lread.c (hash_string): Use size_t, not int, for hash computation.
5693 Normally we prefer signed values; but hashing is special, because
5694 it's better to use unsigned division on hash table sizes so that
5695 the remainder is nonnegative. Also, size_t is the natural width
5696 for hashing into memory. The previous code used 'int', which doesn't
5697 retain enough info to hash well into very large tables.
5698 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5699
2a866e7b
PE
5700 * dbusbind.c: Don't possibly lose pointer info when converting.
5701 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5702 Use XPNTR rather than XHASH, so that the high-order bits of
5703 the pointer aren't lost when converting through void *.
5704
51639eac
PE
5705 * eval.c (Fautoload): Don't double-shift a pointer.
5706
92394119
PE
5707 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5708
dbdb9a7c
JB
57092011-05-06 Juanma Barranquero <lekktu@gmail.com>
5710
5711 * gnutls.c (DEF_GNUTLS_FN):
5712 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5713
db7a0b4f
AS
57142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5715
5716 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5717 marker. (Bug#8610)
5718
f7ff1b0f 57192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5720
5721 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5722 New version that can reserve upto 2GB of heap space.
5723
f7ff1b0f 57242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5725
5726 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5727
639c109b
TZ
57282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5729
5730 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5731 `gnutls_certificate_set_x509_key_file'.
5732
d2127135
JB
57332011-05-05 Juanma Barranquero <lekktu@gmail.com>
5734
5735 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5736 Update dependencies.
5737
e968f4f3
JB
57382011-05-04 Juanma Barranquero <lekktu@gmail.com>
5739
5740 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5741 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5742 Remove unused parameter `fildes'.
5743 * process.c (read_process_output, send_process): Don't pass it.
5744
84d358f0
JB
57452011-05-04 Juanma Barranquero <lekktu@gmail.com>
5746
5747 Fix previous change: the library cache is defined in w32.c.
5748 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5749 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5750
0898ca10
JB
57512011-05-04 Juanma Barranquero <lekktu@gmail.com>
5752
5753 Implement dynamic loading of GnuTLS on Windows.
5754
5755 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5756 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5757 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5758 Declare.
5759
5760 * gnutls.c (Qgnutls_dll): Define.
5761 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5762 (gnutls_*): Declare function pointers.
5763 (init_gnutls_functions): New function to initialize function pointers.
5764 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5765 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5766 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5767 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5768 (emacs_gnutls_write, emacs_gnutls_read)
5769 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5770 (Fgnutls_available_p): New function.
5771 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5772 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5773 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5774
5775 * image.c: Include w32.h.
5776 (Vimage_type_cache): Delete.
5777 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5778 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5779 (w32_delayed_load): Move to w32.c.
5780
5781 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5782
5783 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5784 (w32_delayed_load): Move from image.c. When loading a library, record
5785 its filename in the :loaded-from property of the library id.
5786 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5787 Initialize and staticpro them.
5788 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5789
5790 * process.c: Include lisp.h before w32.h, not after.
5791 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5792 instead of gnutls_record_check_pending.
5793
5794 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5795
ff4de4aa
TZ
57962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5797
5798 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5799 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5800 as passed in.
5801
abe95abb
JD
58022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5803
5804 * xterm.c (x_set_frame_alpha): Do not set property on anything
5805 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5806
e16e55d4
JB
58072011-05-02 Juanma Barranquero <lekktu@gmail.com>
5808
5809 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5810
bafcf6a5
JB
58112011-05-02 Juanma Barranquero <lekktu@gmail.com>
5812
5813 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5814 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5815 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5816 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5817 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5818 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5819 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5820 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5821 (Qgnutls_bootprop_callbacks_verify): Make static.
5822
e7a6747f
AS
58232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5824
19ed11ba
AS
5825 * callproc.c: Indentation fixup.
5826
e7a6747f 5827 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5828 (wait_for_termination, interruptible_wait_for_termination):
5829 Move after wait_for_termination_1.
e7a6747f 5830
1ef14cb4
LMI
58312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5832
5833 * sysdep.c (interruptible_wait_for_termination): New function
5834 which is like wait_for_termination, but allows keyboard
5835 interruptions.
5836
5837 * callproc.c (Fcall_process): Add (:file "file") as an option for
5838 the STDOUT buffer.
5839 (Fcall_process_region): Ditto.
5840
330d880c
EZ
58412011-04-30 Eli Zaretskii <eliz@gnu.org>
5842
8db90b73
EZ
5843 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5844 rather than `XVECTOR (FOO)->size'.
5845
330d880c
EZ
5846 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5847 inttypes.h, as a gnulib replacement is used if it not available in
5848 system headers.
5849
15cbd324
EZ
58502011-04-21 Eli Zaretskii <eliz@gnu.org>
5851
5852 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5853 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5854 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5855
5856 * coding.c (coding_alloc_by_realloc): Error out if destination
5857 will grow beyond MOST_POSITIVE_FIXNUM.
5858 (decode_coding_emacs_mule): Abort if there isn't enough place in
5859 charbuf for the composition carryover bytes. Reserve an extra
5860 space for up to 2 characters produced in a loop.
5861 (decode_coding_iso_2022): Abort if there isn't enough place in
5862 charbuf for the composition carryover bytes.
5863
58642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5865
ae940cca
EZ
5866 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5867 aborting when %lld or %lll format is passed.
5868 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5869 %llo or %llx format is passed. (Bug#8545)
5870
03ab8921
EZ
5871 * window.c (window_scroll_line_based): Use a marker instead of
5872 simple variables to record original value of point. (Bug#7952)
5873
afda1437
EZ
5874 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5875 produced by %s or %c overflows available buffer space. (Bug#8545)
5876
f76dee0c
PE
58772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5880 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5881
fdc5744d
JB
58822011-04-28 Juanma Barranquero <lekktu@gmail.com>
5883
5884 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5885
638f053a
JB
58862011-04-28 Juanma Barranquero <lekktu@gmail.com>
5887
5888 * keyboard.c (Qdelayed_warnings_hook): Define.
5889 (command_loop_1): Run `delayed-warnings-hook'
5890 if Vdelayed_warnings_list is non-nil.
5891 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5892 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5893
d178f871
EZ
58942011-04-28 Eli Zaretskii <eliz@gnu.org>
5895
5896 * doprnt.c (doprnt): Don't return value smaller than the buffer
5897 size if the message was truncated. (Bug#8545).
5898
b124fd93
JB
58992011-04-28 Juanma Barranquero <lekktu@gmail.com>
5900
5901 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5902 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5903
e810457d
PE
59042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5905
5906 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5907
ea51cceb
JB
59082011-04-27 Juanma Barranquero <lekktu@gmail.com>
5909
5910 * makefile.w32-in: Update dependencies.
5911
94dcfacf
EZ
59122011-04-27 Eli Zaretskii <eliz@gnu.org>
5913
5914 Improve `doprnt' and its usage. (Bug#8545)
5915 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5916 `format_end'. Remove support for %l as a conversion specifier.
5917 Don't use xrealloc. Improve diagnostics when the %l size modifier
5918 is used. Update the commentary.
5919
5920 * eval.c (verror): Simplify calculation of size_t.
5921
5922 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5923 messages.
5924
f61f41d7
PE
59252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5926
5927 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5928 change.
5929
96fb4434
PE
59302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5933 This makes this file independent of the recent pseudovector change.
5934
671875da 59352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5936
69e9b5a3
PE
5937 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5938
b5f869a7 5939 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5940 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5941 Remove unused local.
c8926152 5942 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5943
841a1577 5944 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5945 GCC 4.6.0 optimizes based on type-based alias analysis.
5946 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5947 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5948 != &v->size, and therefore "v->size = 1; b->size = 2; return
5949 v->size;" must therefore return 1. This assumption is incorrect
5950 for Emacs, since it type-puns struct Lisp_Vector * with many other
5951 types. To fix this problem, this patch adds a new type struct
f904488f 5952 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5953 and pseudovectors, and helps optimizing compilers not get fooled
5954 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5955 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5956 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5957 the size member.
eab3844f
PE
5958 (XSETPVECTYPE): Rewrite in terms of new macro.
5959 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5960 This is a bit clearer, and further avoids the possibility of
5961 undesirable aliasing.
5962 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5963 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5964 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5965 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5966 (ASIZE): Now uses header.size rather than size.
5967 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5968 to avoid the hassle of writing XVECTOR (foo)->header.size.
5969 (struct vectorlike_header): New type.
eab3844f
PE
5970 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5971 object, to help avoid aliasing.
5972 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5973 (SUBRP): Likewise, since Lisp_Subr is a special case.
5974 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5975 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5976 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5977 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5978 changed to be "header.size" and "header.next".
5979 * buffer.h (struct buffer): Likewise.
5980 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5981 * frame.h (struct frame): Likewise.
5982 * process.h (struct Lisp_Process): Likewise.
5983 * termhooks.h (struct terminal): Likewise.
5984 * window.c (struct save_window_data, struct saved_window): Likewise.
5985 * window.h (struct window): Likewise.
5986 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5987 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5988 * buffer.c (init_buffer_once): Likewise.
5989 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5990 special case.
5991 * process.c (Fformat_network_address): Use local var for size,
5992 for brevity.
5993
0df1eac5
PE
5994 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5995
847ab9d1 5996 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5997 * data.c (atof): Remove decl; no longer used or needed.
5998 (digit_to_number): Move to lread.c.
5999 (Fstring_to_number): Use new string_to_number function, to be
6000 consistent with how the Lisp reader treats infinities and NaNs.
6001 Do not assume that floating-point numbers represent EMACS_INT
6002 without losing information; this is not true on most 64-bit hosts.
6003 Avoid double-rounding errors, by insisting on integers when
6004 parsing non-base-10 numbers, as the documentation specifies.
6005 * lisp.h (string_to_number): New decl, replacing ...
6006 (isfloat_string): Remove.
bc0a5c13 6007 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6008 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6009 appears to have been a coding error. Similarly, do not accept
6010 strings like +-1e0 as floating point numbers. Do not report
6011 overflow for integer overflows unless the base is not 10 which
6012 means we have no simple and reliable way to continue.
6013 Break out the floating-point parsing into a new
6014 function string_to_number, so that Fstring_to_number parses
6015 floating point numbers consistently with the Lisp reader.
04f2d78b 6016 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6017 (E_CHAR, EXP_INT): Remove, replacing with ...
6018 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6019 (string_to_number): New function, replacing isfloat_string.
6020 This function checks for valid syntax and produces the resulting
6021 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6022 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6023 so that overflow for non-base-10 numbers is reported only when
6024 there's no portable and simple way to convert to floating point.
452f4150 6025
67769ffc
PE
6026 * textprop.c (set_text_properties_1): Rewrite for clarity,
6027 and to avoid GCC warning about integer overflow.
6028
c20db43f
PE
6029 * intervals.h (struct interval): Use EMACS_INT for members
6030 where EMACS_UINT might cause problems. See
6031 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6032 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6033 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6034 All uses changed.
37aa2f85
PE
6035 (offset_intervals): Tell GCC not to worry about length overflow
6036 when negating a negative length.
c20db43f 6037
2538aa2f
PE
6038 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6039 (overrun_check_free): Likewise.
6040
f2d3008d
PE
6041 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6042 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6043 word size.
6044
ec8df744
PE
6045 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6046 (gnutls_make_error): Rename local to avoid shadowing.
6047 (gnutls_emacs_global_deinit): ifdef out; not used.
6048 (Fgnutls_boot): Use const for pointer to readonly storage.
6049 Comment out unused local. Fix pointer signedness problems.
6050
640ee02d
PE
6051 * lread.c (openp): Don't stuff size_t into an 'int'.
6052 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6053 about possible signed overflow.
6054
6048fb2a
PE
6055 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6056 (GDK_KEY_g): Don't define if already defined.
6057 (xg_prepare_tooltip): Avoid pointer signedness problem.
6058 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6059
fa3c87e1
PE
6060 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6061 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6062
2172544b
PE
6063 * xfns.c (Fx_window_property): Simplify a bit,
6064 to make a bit faster and to avoid GCC 4.6.0 warning.
6065 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6066
9b821a21
PE
6067 * fns.c (internal_equal): Don't assume size_t fits in int.
6068
3c616cfa
PE
6069 * alloc.c (compact_small_strings): Tighten assertion a little.
6070
c2982e87
PE
6071 Replace pEd with more-general pI, and fix some printf arg casts.
6072 * lisp.h (pI): New macro, generalizing old pEd macro to other
6073 conversion specifiers. For example, use "...%"pI"d..." rather
6074 than "...%"pEd"...".
6075 (pEd): Remove. All uses replaced with similar uses of pI.
6076 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6077 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6078 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6079 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6080 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6081 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6082 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6083 64-bit hosts.
6084 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6085 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6086 * print.c (safe_debug_print, print_object): Likewise.
6087 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6088 to int.
6f04d126
PE
6089 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6090 avoiding the 0 flag, which is not portable.
c2982e87
PE
6091 * process.c (Fmake_network_process): Use pI to avoid cast.
6092 * region-cache.c (pp_cache): Likewise.
6093 * xdisp.c (decode_mode_spec): Likewise.
6094 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6095 behavior on 64-bit hosts with printf arg.
6f04d126 6096 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6097 (x_stop_queuing_selection_requests): Likewise.
6098 (x_get_window_property): Don't truncate byte count to an 'int'
6099 when tracing.
0b432f21 6100
5e073ec7
PE
6101 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6102 here, since it parses constructs like leading '-' and spaces,
6103 which are not wanted; and it overflows with large numbers.
6104 Instead, simply match F[0-9]+, which is what is wanted anyway.
6105
36372bf9
PE
6106 * alloc.c: Remove unportable assumptions about struct layout.
6107 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6108 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6109 (allocate_vectorlike, make_pure_vector): Use the new macros,
6110 plus offsetof, to remove unportable assumptions about struct layout.
6111 These assumptions hold on all porting targets that I know of, but
6112 they are not guaranteed, they're easy to remove, and removing them
6113 makes further changes easier.
6114
0b432f21
PE
6115 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6116 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6117 (string_overrun_cookie): Now const. Use initializers that
6118 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6119 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6120 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6121 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6122 multiple of sizeof (EMACS_INT); it need not be, if
6123 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6124 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6125
895009e1
JB
61262011-04-26 Juanma Barranquero <lekktu@gmail.com>
6127
6128 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6129
6a7a1b0b
TZ
61302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6131
6132 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6133 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6134 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6135
841a1577 61362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6137
6138 * lisp.h (Qdebug): List symbol.
895009e1 6139 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6140 * keyboard.c (debug-on-event): New variable.
6141 (handle_user_signal): Break into debugger when debug-on-event
6142 matches the current signal symbol.
6143
f2d3ba6f
DN
61442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6145
6146 * alloc.c (check_sblock, check_string_bytes)
6147 (check_string_free_list): Convert to standard C.
6148
42ce4c63
TZ
61492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6150
6151 * w32.c (emacs_gnutls_push): Fix typo.
6152
825cd63c
EZ
61532011-04-25 Eli Zaretskii <eliz@gnu.org>
6154
fb11d64d
EZ
6155 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6156 "cast to pointer from integer of different size".
6157
825cd63c
EZ
6158 Improve doprnt and its use in verror. (Bug#8545)
6159 * doprnt.c (doprnt): Document the set of format control sequences
6160 supported by the function. Use SAFE_ALLOCA instead of always
6161 using `alloca'.
6162
6163 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6164 is one byte too soon. Don't use xrealloc; instead xfree and
6165 xmalloc anew.
6166
e061a11b
TZ
61672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6168
6169 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6170 callbacks stage.
6171
6172 * gnutls.c: Renamed global_initialized to
6173 gnutls_global_initialized. Added internals for the
6174 :verify-hostname-error, :verify-error, and :verify-flags
6175 parameters of `gnutls-boot' and documented those parameters in the
6176 docstring. Start callback support.
9173deec
JB
6177 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6178 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6179 on error. Return error code.
e061a11b
TZ
6180 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6181 (emacs_gnutls_read): Likewise.
6182 (Fgnutls_boot): Return handshake error code.
6183 (emacs_gnutls_handle_error): New function.
6184 (wsaerror_to_errno): Likewise.
6185
6186 * w32.h (emacs_gnutls_pull): Add prototype.
6187 (emacs_gnutls_push): Likewise.
6188
6189 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6190 (emacs_gnutls_push): Likewise.
6191
61922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6193
6194 * process.c (wait_reading_process_output): Check if GnuTLS
6195 buffered some data internally if no FDs are set for TLS
6196 connections.
6197
6198 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6199 (LIBS): Link to USER_LIBS.
6200 ($(BLD)/gnutls.$(0)): New target.
6201
fa6996bc
EZ
62022011-04-24 Eli Zaretskii <eliz@gnu.org>
6203
eb35682e
EZ
6204 * xdisp.c (handle_single_display_spec): Rename the
6205 display_replaced_before_p argument into display_replaced_p, to
6206 make it consistent with the commentary. Fix typos in the
6207 commentary.
6208
e2ad650c
EZ
6209 * textprop.c (syms_of_textprop): Remove dead code.
6210 (copy_text_properties): Delete obsolete commentary about an
6211 interface that was deleted long ago. Fix typos in the description
6212 of arguments.
6213
1b2de274
EZ
6214 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6215 to changes in oldXMenu/XMenu.h from 2011-04-16.
6216 <menu_help_message, prev_menu_help_message>: Constify.
6217 (IT_menu_make_room): menu->help_text is now `const char **';
6218 adjust.
6219
6220 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6221 to changes in oldXMenu/XMenu.h from 2011-04-16.
6222 (struct XMenu): Declare `help_text' `const char **'.
6223
6224 * xfaces.c <Qunspecified>: Make extern again.
6225
6226 * syntax.c: Include sys/types.h before including regex.h, as
6227 required by Posix.
6228
762b15be
EZ
6229 * doc.c (get_doc_string): Improve the format passed to `error'.
6230
6231 * doprnt.c (doprnt): Improve commentary.
6232
6233 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6234
6235 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6236 them with etags.
6237
f1052e5d
EZ
6238 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6239 changes in globals.h immediately force recompilation.
762b15be
EZ
6240 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6241 $(CURDIR)/s/ms-w32.h.
6242 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6243
fa6996bc
EZ
6244 * character.c (Fchar_direction): Function deleted.
6245 (syms_of_character): Don't defsubr it.
6246 <char-direction-table>: Deleted.
6247
e6c3da20
EZ
62482011-04-23 Eli Zaretskii <eliz@gnu.org>
6249
6250 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6251 * doprnt.c: Include limits.h.
6252 (SIZE_MAX): New macro.
04f2d78b
CB
6253 (doprnt): Return a size_t value. 2nd arg is now size_t.
6254 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6255 Improve overflow protection. Support `l' modifier for integer
6256 conversions. Support %l conversion. Don't assume an EMACS_INT
6257 argument for integer conversions and for %c.
6258
6259 * lisp.h (doprnt): Restore prototype.
6260
6261 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6262 $(SRC)/character.h.
6263
6264 * Makefile.in (base_obj): Add back doprnt.o.
6265
6266 * deps.mk (doprnt.o): Add back prerequisites.
6267 (callint.o): Depend on character.h.
6268
6269 * eval.c (internal_lisp_condition_case): Include the handler
6270 representation in the error message.
6271 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6272 when breaking from the loop.
6273
6274 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6275
6276 * callint.c (Fcall_interactively): When displaying error message
6277 about invalid control letter, pass the character's codepoint, not
6278 a pointer to its multibyte form. Improve display of the character
6279 in octal and display also its hex code.
6280
6281 * character.c (char_string): Use %x to display the (unsigned)
6282 codepoint of an invalid character, to avoid displaying a bogus
6283 negative value.
6284
6285 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6286 `error', not SYMBOL_NAME itself.
6287
6288 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6289 character arguments to `error'.
6290
6291 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6292 to `error' in error message about FINAL_CHAR argument. Make sure
6293 FINAL_CHAR is a character, and use %c when it is passed as
6294 argument to `error'.
6295
4ffd0d6b 62962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6297
6298 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6299
6300 * w32.c: Include <time.h>.
6301 (sys_localtime): New function.
6302
4ffd0d6b 63032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6304
6305 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6306
4ffd0d6b 6307 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6308
4ffd0d6b 63092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6310
4ffd0d6b
GM
6311 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6312 zombies (Bug#8467).
aac0c6e3 6313
04c56954
EZ
63142011-04-19 Eli Zaretskii <eliz@gnu.org>
6315
6316 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6317 gl_state.e_property when gl_state.object is Qt.
6318
6319 * insdel.c (make_gap_larger): Remove limitation of buffer size
6320 to <= INT_MAX.
6321
16a43933
CY
63222011-04-18 Chong Yidong <cyd@stupidchicken.com>
6323
6324 * xdisp.c (lookup_glyphless_char_display)
6325 (produce_glyphless_glyph): Handle cons cell entry in
6326 glyphless-char-display.
6327 (Vglyphless_char_display): Document it.
6328
6329 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6330 glyphless-char-display.
6331
4581706e
CY
63322011-04-17 Chong Yidong <cyd@stupidchicken.com>
6333
6334 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6335
6336 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6337
6338 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6339 definition for no-X builds.
6340
4887c6e2 63412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6342
fd35b6f9
PE
6343 Static checks with GCC 4.6.0 and non-default toolkits.
6344
5c1ccb01
PE
6345 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6346
006c5daa
PE
6347 * process.c (keyboard_bit_set): Define only if SIGIO.
6348 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6349 (send_process): Repair possible setjmp clobbering.
6350
efc736d3
PE
6351 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6352
4e2fe2e6
PE
6353 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6354
f97334a2
PE
6355 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6356
4e75f29d
PE
6357 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6358 Define only if needed.
6359
90efadd1
PE
6360 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6361 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6362 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6363
3c647824
PE
6364 * dispextern.h (struct redisplay_interface): Rename param
6365 to avoid shadowing.
e264f262 6366 * termhooks.h (struct terminal): Likewise.
761383f4 6367 * xterm.c (xembed_send_message): Likewise.
3c647824 6368
b58c5c4a
PE
6369 * insdel.c (make_gap_smaller): Define only if
6370 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6371
cad59032
PE
6372 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6373 it.
6374
c339dc2e
PE
6375 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6376 so that we aren't warned about unused symbols.
6377
91a3e27b
PE
6378 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6379
399c71d3 6380 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6381
8ffc96f5
PE
6382 * xfns.c (x_real_positions): Mark locals as initialized.
6383
eef9bc79
PE
6384 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6385
098db9dd
PE
6386 * xterm.c: Fix problems found by static analysis with other toolkits.
6387 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6388 (x_dispatch_event): Declare static if USE_GTK, and
6389 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6390 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6391 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6392 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6393 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6394
eb18f6cc
PE
6395 * xmenu.c (menu_help_callback): Pointer type fixes.
6396 Use const pointers when pointing at readonly data. Avoid pointer
6397 signedness clashes.
6398 (FALSE): Remove unused macro.
6399 (update_frame_menubar): Remove unused decl.
6400
1fe72bf8
PE
6401 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6402
60d9e1db
PE
6403 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6404 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6405 (single_menu_item): Rename local to avoid shadowing.
6406
39261c26
PE
6407 * keyboard.c (make_lispy_event): Remove unused local var.
6408
018c5e19
PE
6409 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6410 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6411
63d2b86e
PE
6412 * bitmaps: Change bitmaps from unsigned char back to the X11
6413 compatible char. Avoid the old compiler warnings about
6414 out-of-range initializers by using, for example, '\xab' rather
6415 than 0xab.
6416
aefd87e1
PE
6417 * xgselect.c (xgselect_initialize): Check vs interface
6418 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6419
bf501fb9
PE
6420 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6421
e9829fdf
PE
6422 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6423 to read-only memory.
6424
1086c095
PE
6425 * fns.c (vector): Remove; this old hack is no longer needed.
6426
2baccd04 6427 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6428 Remove unused var.
dde42981 6429 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6430
72391843 6431 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6432
436c16df 6433 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6434 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6435 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6436
92bb796d 6437 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6438 (x_term_init): Remove local to avoid shadowing.
92bb796d 6439
764430a3 6440 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6441
6442 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6443 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6444
d1dfb56c
EZ
64452011-04-16 Eli Zaretskii <eliz@gnu.org>
6446
c4354cb4
EZ
6447 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6448
d1dfb56c
EZ
6449 Fix regex.c, syntax.c and friends for buffers > 2GB.
6450 * syntax.h (struct gl_state_s): Declare character position members
6451 EMACS_INT.
6452
6453 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6454
04f2d78b
CB
6455 * textprop.c (verify_interval_modification, interval_of):
6456 Declare arguments EMACS_INT.
d1dfb56c
EZ
6457
6458 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6459 EMACS_INT.
6460
6461 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6462
6463 * indent.c (Fvertical_motion): Local variable it_start is now
6464 EMACS_INT.
6465
6466 * regex.c (re_match, re_match_2, re_match_2_internal)
6467 (bcmp_translate, regcomp, regexec, print_double_string)
6468 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6469 (re_compile_pattern, re_exec): Declare arguments and local
6470 variables `size_t' and `ssize_t' and return values `regoff_t', as
6471 appropriate.
6472 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6473 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6474 <compile_stack_type>: `size' and `avail' are now `size_t'.
6475
6476 * regex.h <regoff_t>: Use ssize_t, not int.
6477 (re_search, re_search_2, re_match, re_match_2): Arguments that
6478 specify buffer/string position and length are now ssize_t and
6479 size_t. Return type is regoff_t.
6480
613052cd
BK
64812011-04-16 Ben Key <bkey76@gmail.com>
6482
6483 * nsfont.m: Fixed bugs in ns_get_family and
6484 ns_descriptor_to_entity that were caused by using free to
6485 deallocate memory blocks that were allocated by xmalloc (via
6486 xstrdup). This caused Emacs to crash when compiled with
6487 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6488 --enable-checking=xmallocoverrun). xfree is now used to
6489 deallocate these memory blocks.
6490
4170f62f 64912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6492
71b41406
PE
6493 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6494
9587a89d
PE
6495 emacs_write: Accept and return EMACS_INT for sizes.
6496 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6497 et seq.
6498 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6499 Accept and return EMACS_INT.
6500 (emacs_gnutls_write): Return the number of bytes written on
6501 partial writes.
6502 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6503 (emacs_read, emacs_write): Remove check for negative size, as the
6504 Emacs source code has been audited now.
9587a89d
PE
6505 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6506 (emacs_read, emacs_write): Use it.
273a5f82
PE
6507 * process.c (send_process): Adjust to the new signatures of
6508 emacs_write and emacs_gnutls_write. Do not attempt to store
6509 a byte offset into an 'int'; it might overflow.
9587a89d 6510 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6511
3e047f51
PE
6512 * sound.c: Don't assume sizes fit in 'int'.
6513 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6514 Return EMACS_INT, not int.
3e047f51 6515 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6516 Accept EMACS_INT, not int.
6517 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6518 record read return values.
6519
cc39a9db
BK
65202011-04-15 Ben Key <bkey76@gmail.com>
6521
c9d0ec6d
JB
6522 * keyboard.c (Qundefined): Don't declare static since it is used
6523 in nsfns.m.
6524 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6525 static since they are used in nsfont.m.
cc39a9db 6526
6c60eb9f
SM
65272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6528
6529 * process.c (Qprocessp): Don't declare static.
6530 * lisp.h (Qprocessp): Declare again.
6531
7990b61a
JB
65322011-04-15 Juanma Barranquero <lekktu@gmail.com>
6533
6534 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6535
5d4cb038
PE
65362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6537
8bd7b830 6538 Improve C-level modularity by making more things 'static'.
cd64ea1d 6539
e3b27b31
PE
6540 Don't publish debugger-only interfaces to other modules.
6541 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6542 (verify_bytepos, count_markers): Move decls to the only modules
6543 that need them.
6544 * region-cache.h (pp_cache): Likewise.
6545 * window.h (check_all_windows): Likewise.
6546 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6547
5d4cb038
PE
6548 * sysdep.c (croak): Now static, if
6549 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6550 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6551
6552 * alloc.c (refill_memory_reserve): Now static if
6553 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6554 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6555
e87b6180
PE
6556 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6557 Define only if USE_LUCID.
6558
ac64929e
PE
6559 * xrdb.c (x_customization_string, x_rm_string): Now static.
6560
6f37259d
PE
6561 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6562 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6563
1683e3ab
PE
6564 * xdisp.c (draw_row_with_mouse_face): Now static.
6565 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6566
de9c2632
PE
6567 * window.h (check_all_windows): Mark externally visible.
6568
2b96acb7
PE
6569 * window.c (window_deletion_count): Now static.
6570
6571 * undo.c: Make symbols static if they're not exported.
6572 (last_undo_buffer, last_boundary_position, pending_boundary):
6573 Now static.
6574
50436f33
PE
6575 * textprop.c (interval_insert_behind_hooks): Now static.
6576 (interval_insert_in_front_hooks): Likewise.
6577
64520e5c
PE
6578 * term.c: Make symbols static if they're not exported.
6579 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6580 (max_frame_lines, tty_set_terminal_modes):
6581 (tty_reset_terminal_modes, tty_turn_off_highlight):
6582 (get_tty_terminal): Now static.
6583 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6584 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6585 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6586 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6587 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6588
1fa53021
PE
6589 * sysdep.c: Make symbols static if they're not exported.
6590 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6591 Now static.
6592 (sigprocmask_set, full_mask): Remove; unused.
6593 (wait_debugging): Mark as visible.
6594 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6595 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6596
d4b43b22
PE
6597 * syntax.c (syntax_temp): Define only if !__GNUC__.
6598
b7c513d0
PE
6599 * sound.c (current_sound_device, current_sound): Now static.
6600
989b29ad
PE
6601 * search.c (searchbufs, searchbuf_head): Now static.
6602
13a55a78
PE
6603 * scroll.c (scroll_cost): Remove; unused.
6604 * dispextern.h (scroll_cost): Remove decl.
6605
de68a1fc
PE
6606 * region-cache.h (pp_cache): Mark as externally visible.
6607
40ccffa6
PE
6608 * process.c: Make symbols static if they're not exported.
6609 (process_tick, update_tick, create_process, chan_process):
6610 (Vprocess_alist, proc_buffered_char, datagram_access):
6611 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6612 (deactivate_process): Mark defn as static, as well as decl.
6613 * lisp.h (create_process): Remove decl.
6614 * process.h (chan_process, Vprocess_alist): Remove decls.
6615
ad64fc97
PE
6616 * print.c: Make symbols static if they're not exported.
6617 (print_depth, new_backquote_output, being_printed, print_buffer):
6618 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6619 (print_interval, print_number_index, initial_stderr_stream):
6620 Now static.
6621 * lisp.h (Fprinc): Remove decl.
6622 (debug_output_compilation_hack): Mark as externally visible.
6623
adddb265
PE
6624 * sysdep.c (croak): Move decl from here to syssignal.h.
6625 * syssignal.h (croak): Put it here, so the API can be checked when
6626 'croak' is called from dissociate_if_controlling_tty.
6627
1717ede2
PE
6628 * minibuf.c: Make symbols static if they're not exported.
6629 (minibuf_save_list, choose_minibuf_frame): Now static.
6630 * lisp.h (choose_minibuf_frame): Remove decl.
6631
fa5fb2bc
PE
6632 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6633
1e3890d1
PE
6634 * lread.c: Make symbols static if they're not exported.
6635 (read_objects, initial_obarray, oblookup_last_bucket_number):
6636 Now static.
6637 (make_symbol): Remove; unused.
6638 * lisp.h (initial_obarray, make_symbol): Remove decls.
6639
8a1414fa
PE
6640 * keyboard.c: Make symbols static if they're not exported.
6641 (single_kboard, recent_keys_index, total_keys, recent_keys):
6642 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6643 (this_single_command_key_start, echoing, last_auto_save):
6644 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6645 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6646 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6647 (Vlispy_mouse_stem, double_click_count):
6648 Now static.
6649 (force_auto_save_soon): Define only if SIGDANGER.
6650 (ignore_mouse_drag_p): Now static if
6651 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6652 (print_help): Remove; unused.
6653 (stop_character, last_timer_event): Mark as externally visible.
6654 * keyboard.h (ignore_mouse_drag_p): Declare only if
6655 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6656 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6657 * lisp.h (echoing): Remove decl.
6658 (force_auto_save_soon): Declare only if SIGDANGER.
6659 * xdisp.c (redisplay_window): Simplify code, to make it more
6660 obvious that ignore_mouse_drag_p is not accessed if !defined
6661 USE_GTK && !defined HAVE_NS.
6662
93ea6e8f
PE
6663 * intervals.c: Make symbols static if they're not exported.
6664 (merge_properties_sticky, merge_interval_right, delete_interval):
6665 Now static.
6666 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6667
77382fcc
PE
6668 * insdel.c: Make symbols static if they're not exported.
6669 However, leave prepare_to_modify_buffer alone. It's never
6670 called from outside this function, but that appears to be a bug.
6671 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6672 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6673 (adjust_after_replace_noundo): Remove; unused.
6674 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6675 (signal_before_change): Remove decls.
77382fcc 6676
9306c32e
PE
6677 * indent.c (val_compute_motion, val_vmotion): Now static.
6678
cd44d2eb
PE
6679 * image.c: Make symbols static if they're not exported.
6680 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6681 if USE_GTK.
6682 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6683 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6684
ad9a7a06
PE
6685 * fringe.c (standard_bitmaps): Now static.
6686 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6687
81626931
PE
6688 * frame.c: Make symbols static if they're not exported.
6689 (x_report_frame_params, make_terminal_frame): Now static.
6690 (get_frame_param): Now static, unless HAVE_NS.
6691 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6692 (x_get_resource_string): Remove; not used.
6693 * frame.h (make_terminal_frame, x_report_frame_params):
6694 (x_get_resource_string); Remove decls.
6695 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6696 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6697
239f9db9
PE
6698 * font.c, fontset.c: Make symbols static if they're not exported.
6699 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6700 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6701 * font.c (font_close_object): Now static.
6702 * font.h (font_close_object): Remove.
6703 * fontset.c (FONTSET_OBJLIST): Remove.
6704 (free_realized_fontset) #if-0 the body, which does nothing.
6705 (face_suitable_for_char_p): #if-0, as it's never called.
6706 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6707 * xfaces.c (face_at_string_position):
6708 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6709 since 0 is always ASCII.
6710
dfcf3579
PE
6711 * fns.c (weak_hash_tables): Now static.
6712
5045092b
PE
6713 * fileio.c: Make symbols static if they're not exported.
6714 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6715 (Vwrite_region_annotation_buffers): Now static.
6716
57a96f5c
PE
6717 * eval.c: Make symbols static if they're not exported.
6718 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6719 * lisp.h (backtrace_list): Remove decl.
6720
35f08c38
PE
6721 * emacs.c: Make symbols static if they're not exported.
6722 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6723 (fatal_error_code, fatal_error_signal_hook, standard_args):
6724 Now static.
6725 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6726 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6727 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6728 * lisp.h (fatal_error_signal_hook): Remove decl.
6729 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6730
f44bd759
PE
6731 * editfns.c: Move a (normally-unused) function to its only use.
6732 * editfns.c, lisp.h (get_operating_system_release): Remove.
6733 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6734 worth the hassle of breaking this out.
6735
b532497d
PE
6736 * xterm.c: Make symbols static if they're not exported.
6737 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6738 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6739 (x_destroy_window, x_delete_display):
6740 Now static.
6741 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6742 (x_mouse_leave): Remove; unused.
6743 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6744 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6745 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6746 Remove decls.
6747 (x_mouse_leave): Declare only if WINDOWSNT.
6748 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6749 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6750 USE_X_TOOLKIT.
6751
1675728f
PE
6752 * ftxfont.c: Make symbols static if they're not exported.
6753 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6754 HAVE_FREETYPE.
6755 * font.h (ftxfont_driver): Likewise.
6756
e4cebfca
PE
6757 * xfns.c: Make symbols static if they're not exported.
6758 (x_last_font_name, x_display_info_for_name):
6759 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6760 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6761 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6762 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6763 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6764 (last_show_tip_args): Now static.
6765 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6766 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6767 (x_screen_planes): Remove; unused.
6768 * dispextern.h (x_screen_planes): Remove decl.
6769
5bf46f05
PE
6770 * dispnew.c: Make symbols static if they're not exported.
6771 * dispextern.h (redraw_garbaged_frames, scrolling):
6772 (increment_row_positions): Remove.
6773 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6774 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6775 Now static.
6776 (redraw_garbaged_frames): Remove; unused.
6777
435f4c28
PE
6778 * xfaces.c: Make symbols static if they're not exported.
6779 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6780 Remove decls.
6781 * xterm.h (defined_color): Remove decls.
6782 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6783 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6784 (menu_face_changed_default, defined_color, free_realized_face):
6785 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6786 (ascii_face_of_lisp_face): Remove; unused.
6787
8524aef3
PE
6788 * xdisp.c: Make symbols static if they're not exported.
6789 * dispextern.h (scratch_glyph_row, window_box_edges):
6790 (glyph_to_pixel_coords, set_cursor_from_row):
6791 (get_next_display_element, set_iterator_to_next):
6792 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6793 (show_mouse_face): Remove decls
6794 * frame.h (message_buf_print): Likewise.
6795 * lisp.h (pop_message, set_message, check_point_in_composition):
6796 Likewise.
6797 * xterm.h (set_vertical_scroll_bar): Likewise.
6798 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6799 (message_buf_print, scratch_glyph_row, displayed_buffer):
6800 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6801 (get_next_display_element, show_mouse_face, window_box_edges):
6802 (frame_to_window_pixel_xy, check_point_in_composition):
6803 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6804 (glyph_to_pixel_coords): Remove; unused.
6805
16390cd2
PE
6806 * dired.c (file_name_completion): Now static.
6807
6808 * dbusbind.c (xd_in_read_queued_messages): Now static.
6809
a25f4dfa
PE
6810 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6811 * data.c (circular_list_error): Remove.
6812
14a9c8df
PE
6813 * commands.h (last_point_position, last_point_position_buffer):
6814 (last_point_position_window): Remove decls.
6815 * keyboard.c: Make these variables static.
6816
04f2d78b
CB
6817 * coding.h (coding, code_convert_region, encode_coding_gap):
6818 Remove decls.
74ab6df5
PE
6819 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6820 (iso_code_class, detect_coding, code_convert_region): Now static.
6821 (encode_coding_gap): Remove; unused.
6822
38dfbee1
PE
6823 * chartab.c (chartab_chars, chartab_bits): Now static.
6824
a2cb4e63
PE
6825 * charset.h (charset_iso_8859_1): Remove decl.
6826 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6827 Now static.
6828
127198fd
PE
6829 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6830 * ccl.c (Vccl_program_table): Now static.
6831 (check_ccl_update): Remove; unused.
6832
d85b608f
PE
6833 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6834 * category.h: ... from here.
6835 * category.c (check_category_table, set_category_set): Now static.
6836
31cd66f3
PE
6837 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6838 * lisp.h: Remove these decls.
6839
c358e587
PE
6840 * buffer.c (buffer_count): Remove unused var.
6841
e78aecca
PE
6842 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6843 so that it's not optimized away.
6844 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6845 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6846 exported only to the debugger.
6847
e192d7d3 6848 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6849 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6850
92470028
PE
6851 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6852 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6853 was inaccessible from Lisp.
6854 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6855 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6856
244ed907
PE
6857 alloc.c: Import and export fewer symbols, and remove unused items.
6858 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6859 is defined.
6860 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6861 it's not optimized away by whole-program optimization.
6862 (message_enable_multibyte, free_misc): Remove.
6863 (catchlist, handlerlist, mark_backtrace):
6864 Declare only if BYTE_MARK_STACK.
6865 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6866 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6867 (message_enable_multibyte): Remove decl.
6868 (free_misc, interval_free_list, float_block, float_block_index):
6869 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6870 (cons_free_list, last_marked_index):
6871 Now static.
6872 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6873 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6874 (mark_backtrace): Define only if BYTE_MARK_STACK.
6875 * xdisp.c (message_enable_multibyte): Now static.
6876
61c2b50e 6877 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6878 This makes it easier for human readers (and static analyzers)
6879 to see whether these variables are used from other modules.
6880 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6881 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6882 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6883 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6884 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6885 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6886 * xmenu.c, xselect.c:
6887 Declare Q* vars static if they are not used in other modules.
6888 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6889 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6890 Remove decls of unexported vars.
6891 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6892
95c82688
PE
6893 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6894
16a97296
PE
6895 Make Emacs functions such as Fatom 'static' by default.
6896 This makes it easier for human readers (and static analyzers)
6897 to see whether these functions can be called from other modules.
6898 DEFUN now defines a static function. To make the function external
6899 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6900 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6901 (Finit_image_library):
16a97296
PE
6902 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6903 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6904 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6905 Remove decls, since these functions are now static.
6906 (Funintern, Fget_internal_run_time): New decls, since these functions
6907 were already external.
95c82688 6908
16a97296
PE
6909 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6910 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6911 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6912 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6913 * keyboard.c, keymap.c, lread.c:
6914 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6915 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6916 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6917 Mark functions with DEFUE instead of DEFUN,
6918 if they are used in other modules.
6919 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6920 decls for now-static functions.
6921 * buffer.h (Fdelete_overlay): Remove decl.
6922 * callproc.c (Fgetenv_internal): Mark as internal.
6923 * composite.c (Fremove_list_of_text_properties): Remove decl.
6924 (Fcomposition_get_gstring): New forward static decl.
6925 * composite.h (Fcomposite_get_gstring): Remove decl.
6926 * dired.c (Ffile_attributes): New forward static decl.
6927 * doc.c (Fdocumntation_property): New forward static decl.
6928 * eval.c (Ffetch_bytecode): New forward static decl.
6929 (Funintern): Remove extern decl; now in .h file where it belongs.
6930 * fileio.c (Fmake_symbolic_link): New forward static decl.
6931 * image.c (Finit_image_library): New forward static decl.
6932 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6933 * intervals.h (Fprevious_property_change):
6934 (Fremove_list_of_text_properties): Remove decls.
6935 * keyboard.c (Fthis_command_keys): Remove decl.
6936 (Fcommand_execute): New forward static decl.
6937 * keymap.c (Flookup_key): New forward static decl.
6938 (Fcopy_keymap): Now static.
6939 * keymap.h (Flookup_key): Remove decl.
6940 * process.c (Fget_process): New forward static decl.
6941 (Fprocess_datagram_address): Mark as internal.
6942 * syntax.c (Fsyntax_table_p): New forward static decl.
6943 (skip_chars): Remove duplicate decl.
6944 * textprop.c (Fprevious_property_change): New forward static decl.
6945 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6946 Now internal.
6947 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6948 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6949
785bbd42
PE
6950 * editfns.c (Fformat): Remove unreachable code.
6951
8b913b57
AS
69522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6953
6954 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6955 change. (Bug#8496)
6956
a6744a35
EZ
69572011-04-13 Eli Zaretskii <eliz@gnu.org>
6958
6959 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6960 when at ZV. (Bug#8487)
6961
e7974947
AS
69622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6963
baad03f0
AS
6964 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6965 (Bug#8437)
6966 * keyboard.c (parse_tool_bar_item): Likewise.
6967 * sound.c (sound_cleanup, alsa_close): Likewise.
6968 * termcap.c (tgetent): Likewise.
6969 * xfns.c (x_default_font_parameter): Likewise.
6970 * xsettings.c (read_and_apply_settings): Likewise.
6971
e7974947
AS
6972 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6973 (overrun_check_free): Protoize.
6974
28272684
PE
69752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6976
6977 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6978 since callers should never pass a negative size.
6979 Change the signature to match that of plain 'read' and 'write'; see
6980 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6981 * lisp.h: Update prototypes of emacs_write and emacs_read.
6982
11997c76
EZ
69832011-04-11 Eli Zaretskii <eliz@gnu.org>
6984
6985 * xdisp.c (redisplay_window): Don't try to determine the character
6986 position of the scroll margin if the window start point w->startp
e896f03c 6987 is outside the buffer's accessible region. (Bug#8468)
11997c76 6988
8a2cbd72
EZ
69892011-04-10 Eli Zaretskii <eliz@gnu.org>
6990
6991 Fix write-region and its subroutines for buffers > 2GB.
6992 * fileio.c (a_write, e_write): Modify declaration of arguments and
6993 local variables to support buffers larger than 2GB.
6994 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6995
6996 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6997 argument, local variables, and return value.
6998
6999 * lisp.h: Update prototypes of emacs_write and emacs_read.
7000
7001 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7002
4073e537 70032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7004
1ebfdcb6
PE
7005 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7006
b2ded58d
PE
7007 Fix more problems found by GCC 4.6.0's static checks.
7008
7d66342c
PE
7009 * xdisp.c (vmessage): Use a better test for character truncation.
7010
bbf47d44
PE
7011 * charset.c (load_charset_map): <, not <=, for optimization,
7012 and to avoid potential problems with integer overflow.
9248994d 7013 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7014 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7015 * editfns.c (Fformat): Likewise.
1e69125e 7016 * syntax.c (skip_chars): Likewise.
3befa583 7017
e3019616
PE
7018 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7019 This also lets GCC 4.6.0 generate slightly better loop code.
7020
becfa255
PE
7021 * callint.c (Fcall_interactively): <, not <=, for optimization.
7022 (Fcall_interactively): Count the number of arguments produced,
7023 not the number of arguments given. This is simpler and lets GCC
7024 4.6.0 generate slightly better code.
7025
dae0cd48
PE
7026 * ftfont.c: Distingish more carefully between FcChar8 and char.
7027 The previous code passed unsigned char * to a functions like
7028 strlen and xstrcasecmp that expect char *, which does not
7029 conform to the C standard.
7030 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7031 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7032 char * when the C standard requires it.
7033
76032d70
PE
7034 * keyboard.c (read_char): Remove unused var.
7035
eb3f1cc8
PE
7036 * eval.c: Port to Windows vsnprintf (Bug#8435).
7037 Include <limits.h>.
7038 (SIZE_MAX): Define if the headers do not.
7039 (verror): Do not give up if vsnprintf returns a negative count.
7040 Instead, grow the buffer. This ports to Windows vsnprintf, which
7041 does not conform to C99. Problem reported by Eli Zaretskii.
7042 Also, simplify the allocation scheme, by avoiding the need for
7043 calling realloc, and removing the ALLOCATED variable.
7044
70476b54
PE
7045 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7046
12020a9e
PE
7047 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7048 But keep the doprint source code for now, as we might revamp it
7049 and use it again (Bug#8435).
ea6c7ae6
PE
7050 * lisp.h (doprnt): Remove.
7051 * Makefile.in (base_obj): Remove doprnt.o.
7052 * deps.mk (doprnt.o): Remove.
7053
5fdb398c
PE
7054 error: Print 32- and 64-bit integers portably (Bug#8435).
7055 Without this change, on typical 64-bit hosts error ("...%d...", N)
7056 was used to print both 32- and 64-bit integers N, which relied on
7057 undefined behavior.
7058 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7059 New macro.
7060 * lisp.h (error, verror): Mark as printf-like functions.
7061 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7062 Report overflow in size calculations when allocating printf buffer.
7063 Do not truncate output string at its first null byte.
7064 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7065 Truncate the output at a character boundary, since vsnprintf does not
7066 do that.
7067 * charset.c (check_iso_charset_parameter): Convert internal
7068 character to string before calling 'error', since %c now has the
7069 printf meaning.
7070 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7071 overflow when computing char to be passed to 'error'. Do not
7072 pass Lisp_Object to 'error'; pass the integer instead.
7073 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7074 formatted with plain %d.
7075
b189fa66
PE
7076 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7077
bff87ef0
PE
7078 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7079
7e2cac20
PE
7080 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7081
ce4d90b5
PE
7082 * xterm.c (x_catch_errors): Remove duplicate declaration.
7083
266c9547
PE
7084 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7085
79c49ad2
PE
7086 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7087
368f4090
JM
70882011-04-10 Jim Meyering <meyering@redhat.com>
7089
7090 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7091 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7092 return ssize_t not "int", and use size_t as the buffer length.
7093 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7094 * gnutls.h: Update declarations.
7095 * process.c (read_process_output): Use ssize_t, to match.
7096 (send_process): Likewise.
7097
a32d4040
CY
70982011-04-09 Chong Yidong <cyd@stupidchicken.com>
7099
7100 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7101
8546720e 71022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7103
04f2d78b
CB
7104 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7105 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7106
8546720e
GM
7107 * xterm.c (handle_one_xevent):
7108 * xmenu.c (create_and_show_popup_menu):
7109 * xselect.c (x_decline_selection_request)
7110 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7111
0a2f5c1a 71122011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7113
7114 Fix some uses of `int' instead of EMACS_INT.
7115 * search.c (string_match_1, fast_string_match)
7116 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7117 (scan_buffer, find_next_newline_no_quit)
7118 (find_before_next_newline, search_command, Freplace_match)
7119 (Fmatch_data): Make some `int' variables be EMACS_INT.
7120
7121 * xdisp.c (display_count_lines): 3rd argument and return value now
7122 EMACS_INT. All callers changed.
7123 (pint2hrstr): Last argument is now EMACS_INT.
7124
7125 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7126 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7127 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7128 (decode_coding_utf_16, decode_coding_emacs_mule)
7129 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7130 (decode_coding_ccl, decode_coding_charset)
7131 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7132 (decode_coding_iso_2022, decode_coding_emacs_mule)
7133 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7134 <char_offset, last_offset>: Declare EMACS_INT.
7135 (encode_coding_utf_8, encode_coding_utf_16)
7136 (encode_coding_emacs_mule, encode_invocation_designation)
7137 (encode_designation_at_bol, encode_coding_iso_2022)
7138 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7139 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7140 Declare EMACS_INT.
7141 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7142 (encode_invocation_designation): Last argument P_NCHARS is now
7143 EMACS_INT.
7144 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7145 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7146
7147 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7148 All users changed.
7149
7150 * ccl.c (Fccl_execute_on_string): Declare some variables
7151 EMACS_INT.
7152
8546720e 71532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7154
7155 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7156
4e19a977
CS
71572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7158
7159 * process.c (Fformat_network_address): Doc fix.
7160
87302331
R
71612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7162
7163 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7164
cbb59342
CY
71652011-04-08 Chong Yidong <cyd@stupidchicken.com>
7166
7167 * keyboard.c (read_char): Call Lisp function help-form-show,
7168 instead of using internal_with_output_to_temp_buffer.
7169 (Qhelp_form_show): New var.
e0d38eeb 7170 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7171
7172 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7173
7174 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7175
e67a13ab
CY
71762011-04-06 Chong Yidong <cyd@stupidchicken.com>
7177
04f2d78b
CB
7178 * process.c (Flist_processes): Remove to Lisp.
7179 (list_processes_1): Delete.
e67a13ab 7180
973f782d
EZ
71812011-04-06 Eli Zaretskii <eliz@gnu.org>
7182
7c106b1e
EZ
7183 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7184
973f782d
EZ
7185 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7186
41cf7d1a 71872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7188
ca23cc88
PE
7189 Fix more problems found by GCC 4.6.0's static checks.
7190
f390e2d5
PE
7191 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7192
42eea0d0
PE
7193 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7194
b69769da 7195 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7196
f9541e84
PE
7197 * xdisp.c (vmessage): Mark as a printf-like function.
7198
13841b55
PE
7199 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7200
c136c10f
PE
7201 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7202
5e2d4a30
PE
7203 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7204 printf-like functions.
7205 (tiff_load): Add casts to remove these marks before passing them
7206 to system-supplied API.
7207
583f48b9
PE
7208 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7209
b25d760e
PE
7210 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7211 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7212 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7213 directly, rather than having caller test rule sign. This avoids
7214 some unnecessary tests.
7215 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7216 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7217 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7218
bc7b6697 7219 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7220 (xfont_open): Avoid unnecessary tests.
bc7b6697 7221
27ccc379
PE
7222 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7223
dcd5c89a
PE
7224 * composite.h, composite.c (composition_gstring_put_cache):
7225 Use EMACS_INT, not int, for length.
7226
b13a45c6
PE
7227 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7228 breaking out part of COMPOSITION_DECODE_RULE.
7229 (COMPOSITION_DECODE_RULE): Use it.
7230 * composite.c (get_composition_id): Remove unused local vars,
7231 by using the new macro.
7232
1e792e4d
PE
7233 * textprop.c (set_text_properties_1): Change while to do-while,
7234 since the condition is always true at first.
7235
dc6c6455 7236 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7237 (interval_deletion_adjustment): Return unsigned value.
7238 All uses changed.
dc6c6455 7239
aba7731a
PE
7240 * process.c (list_processes_1, create_pty, read_process_output):
7241 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7242 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7243 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7244 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7245 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7246
fdfc4bf3
PE
7247 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7248
fca8fe46 7249 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7250 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7251
06a0259a 7252 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7253 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7254 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7255
e7b9e80f
PE
7256 * print.c (print_error_message): Avoid int overflow.
7257
56201685
PE
7258 * font.c (font_list_entities): Redo for clarity,
7259 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7260
78834453 7261 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7262 (font_score): Avoid potential overflow in diff calculation.
78834453 7263
0bc0b309 7264 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7265 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7266
e610eaca
PE
7267 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7268
b895abce
PE
7269 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7270 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7271 can always succeed if overflow has undefined behavior.
7272
1f1d9321 7273 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7274 (wordify): Omit three unnecessary tests.
1f1d9321 7275
c59478bc
PE
7276 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7277 All callers changed. This avoids the need for an unused var.
7278
79b73827
PE
7279 * casefiddle.c (casify_region): Remove var that is set but not used.
7280
a4db5dfe
PE
7281 * dired.c (file_name_completion): Remove var that is set but not used.
7282
43aae36e
PE
7283 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7284
2a47c44d 7285 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7286 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7287
a37c69bf
PE
7288 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7289 Check for integer overflow on size calculations.
7290
328ab8e7
PE
7291 * buffer.c (Fprevious_overlay_change): Remove var that is set
7292 but not used.
7293
e5a2a5cb
PE
7294 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7295 Remove vars that are set but not used.
8d84a6eb 7296 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7297 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7298
a60e5f68
PE
7299 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7300
f661cb61 7301 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7302 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7303
f0397f5a
PE
7304 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7305 that are set but not used.
7306
8664db06 7307 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7308 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7309
6abdaa4a
PE
7310 * xselect.c (x_get_local_selection, x_handle_property_notify):
7311 Remove vars that are set but not used.
7312
0ce7538d 7313 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7314 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7315
9ae848fc
PE
7316 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7317 Remove var that is set but not used.
0b918413
PE
7318 (scroll_bar_windows_size): Now size_t, not int.
7319 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7320 Check for overflow.
9ae848fc 7321
a5a62657
PE
7322 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7323 (map_tty_color) [!defined MSDOS]: Likewise.
7324
5c5cdd39
PE
7325 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7326
66ebf983
PE
7327 * coding.c: Remove vars that are set but not used.
7328 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7329 All callers changed.
7330 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7331 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7332 (decode_coding_charset): Remove vars that are set but not used.
7333
1be4d761
PE
7334 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7335 that is set but not used.
7336
47553fa8
PE
7337 * print.c (print_object): Remove var that is set but not used.
7338
1f7196bf 7339 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7340 The gnulib version avoids calling malloc in the usual case,
7341 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7342 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7343 * filelock.c (current_lock_owner): Likewise.
7344 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7345 * sysdep.c: Include allocator.h, careadlinkat.h.
7346 (emacs_no_realloc_allocator): New static constant.
7347 (emacs_readlink): New function.
fdb61804
PE
7348 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7349 ../lib/careadlinkat.h.
d1fdcab7 7350
f84c17c7
SM
73512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7352
7353 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7354 first non-nil return value).
7355
ef3862ad
JD
73562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7357
7358 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7359 if not defined (Bug#8403).
7360
376a7006
JB
73612011-04-02 Juanma Barranquero <lekktu@gmail.com>
7362
7363 * xdisp.c (display_count_lines): Remove parameter `start',
7364 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7365 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7366 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7367 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7368 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7369 and thereabouts. All callers changed.
7370 (get_per_char_metric): Remove parameter `f', unused since
7371 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7372
6ca3801d
JM
73732011-04-02 Jim Meyering <meyering@redhat.com>
7374
7375 do not dereference NULL upon failed strdup
7376 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7377 (ns_get_family): Likewise.
7378
d8e2b5ba
JB
73792011-04-02 Juanma Barranquero <lekktu@gmail.com>
7380
7381 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7382
8c74fcbd
JD
73832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7384
7385 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7386 later (Bug#8403).
7387
7200d79c
SM
73882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7389
03408648 7390 Add lexical binding.
7200d79c 7391
03408648
SM
7392 * window.c (Ftemp_output_buffer_show): New fun.
7393 (Fsave_window_excursion):
7394 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7395
7396 * lread.c (lisp_file_lexically_bound_p): New function.
7397 (Fload): Bind Qlexical_binding.
7398 (readevalloop): Remove `evalfun' arg.
7399 Bind Qinternal_interpreter_environment.
7400 (Feval_buffer): Bind Qlexical_binding.
7401 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7402 Mark as dynamic.
7403 (syms_of_lread): Declare `lexical-binding'.
7404
7405 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7406
7407 * keyboard.c (eval_dyn): New fun.
7408 (menu_item_eval_property): Use it.
ca105506
SM
7409
7410 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7411
03408648
SM
7412 * fns.c (concat, mapcar1): Accept byte-code-functions.
7413
7414 * eval.c (Fsetq): Handle lexical vars.
7415 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7416 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7417 (FletX, Flet): Obey lexical binding.
7418 (Fcommandp): Handle closures.
7419 (Feval): New `lexical' arg.
7420 (eval_sub): New function extracted from Feval. Use it almost
7421 everywhere where Feval was used. Look up vars in lexical env.
7422 Handle closures.
7423 (Ffunctionp): Move from subr.el.
7424 (Ffuncall): Handle closures.
7425 (apply_lambda): Remove `eval_flags'.
7426 (funcall_lambda): Handle closures and new byte-code-functions.
7427 (Fspecial_variable_p): New function.
7428 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7429 but without exporting it to Lisp.
23aba0ea 7430
23aba0ea 7431 * doc.c (Fdocumentation, store_function_docstring):
03408648 7432 * data.c (Finteractive_form): Handle closures.
23aba0ea 7433
03408648
SM
7434 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7435 interactive spec.
ba83908c 7436
04f2d78b
CB
7437 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7438 New byte-codes.
03408648
SM
7439 (exec_byte_code): New function extracted from Fbyte_code to handle new
7440 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7441
03408648 7442 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7443
03408648 7444 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7445
e2abce01
JB
74462011-03-31 Juanma Barranquero <lekktu@gmail.com>
7447
7448 * xdisp.c (redisplay_internal): Fix prototype.
7449
63696a73 74502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7451
63696a73 7452 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7453 (try_scrolling): Use it when setting scroll_limit.
7454 Limit scrolling to 100 screen lines.
63696a73
EZ
7455 (redisplay_window): Even when falling back on "recentering",
7456 position point in the window according to scroll-conservatively,
7457 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7458
7459 (try_scrolling): When point is above the window, allow searching
7460 as far as scroll_max, or one screenful, to compute vertical
7461 distance from PT to the scroll margin position. This prevents
7462 try_scrolling from unnecessarily failing when
7463 scroll-conservatively is set to a value slightly larger than the
7464 window height. Clean up the case of PT below the margin at bottom
7465 of window: scroll_max can no longer be INT_MAX. When aggressive
7466 scrolling is in use, don't let point enter the opposite scroll
7467 margin as result of the scroll.
7468 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7469 threshold of 100 lines for never-recentering scrolling.
7470
e4cc2dfc
JB
74712011-03-31 Juanma Barranquero <lekktu@gmail.com>
7472
7473 * dispextern.h (move_it_by_lines):
7474 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7475 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7476 (message_log_check_duplicate): Remove parameters `prev_bol' and
7477 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7478 (redisplay_internal): Remove parameter `preserve_echo_area',
7479 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7480
7481 * indent.c (Fvertical_motion):
7482 * window.c (window_scroll_pixel_based, Frecenter):
7483 Don't pass `need_y_p' to `move_it_by_lines'.
7484
1c470562
SM
74852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7486
44f230aa
SM
7487 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7488 steal a few bits to be more compact.
7489 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7490 Remove unneeded casts.
7491
1c470562
SM
7492 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7493
888adce9
ZK
74942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7495
7496 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7497 binding" message (bug#7967).
7498
f838ed7b
PE
74992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7500
77861b95
PE
7501 Fix more problems found by GCC 4.6.0's static checks.
7502
de6dbc14
PE
7503 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7504 Remove unused local var.
7505
f838ed7b
PE
7506 * editfns.c (Fmessage_box): Remove unused local var.
7507
792c7b2b
PE
7508 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7509 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7510 Omit unused local vars.
c499e557 7511 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7512 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7513 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7514 Omit unused local var.
7515
ba0165e1
PE
7516 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7517 Don't assume string length fits in int.
32ad8845 7518 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7519 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7520
3c59b4c9
PE
7521 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7522 instead of alloca (Bug#8344).
7523
a3eed478 7524 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7525 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7526
eb4d412d
PE
7527 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7528
1658b401
PE
7529 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7530 concerns.
7531
7532 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7533
7534 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7535
9a2c6e05
PE
7536 * keyboard.c (syms_of_keyboard): Use the same style as later
7537 in this function when indexing through an array. This also
7538 works around GCC bug 48267.
7539
03d0a109
PE
7540 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7541
44f730c8
PE
7542 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7543
fe75f926
PE
7544 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7545 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7546
ffa8c828
PE
7547 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7548 This avoids undefined behavior on integer overflow, and is a bit
7549 more convenient anyway since it is compared to a size_t variable.
7550
c5101a77
PE
7551 Variadic C functions now count arguments with size_t, not int.
7552 This avoids an unnecessary limitation on 64-bit machines, which
7553 caused (substring ...) to crash on large vectors (Bug#8344).
7554 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7555 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7556 All variadic functions and their callers changed accordingly.
c5101a77
PE
7557 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7558 * data.c (arith_driver, float_arith_driver): Likewise.
7559 * editfns.c (general_insert_function): Likewise.
7560 * eval.c (struct backtrace.nargs, interactive_p)
7561 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7562 (funcall_lambda, mark_backtrace): Likewise.
7563 * fns.c (concat): Likewise.
7564 * frame.c (x_set_frame_parameters): Likewise.
7565 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7566 0 if not found, not -1. All callers changed.
7567
dd3f25f7
PE
7568 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7569 (stack_copy_size): Now size_t, not int.
7570 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7571
461c2ab9
JB
75722011-03-28 Juanma Barranquero <lekktu@gmail.com>
7573
7574 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7575 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7576 All callers changed.
7577
7578 * lisp.h (multibyte_char_to_unibyte):
7579 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7580 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7581 * character.h (CHAR_TO_BYTE8):
7582 * cmds.c (internal_self_insert):
7583 * editfns.c (general_insert_function):
7584 * keymap.c (push_key_description):
7585 * search.c (Freplace_match):
7586 * xdisp.c (message_dolog, set_message_1): All callers changed.
7587
f6d62986
SM
75882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7589
7590 * keyboard.c (safe_run_hook_funcall): New function.
7591 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7592 don't set the hook to nil, but remove the offending function instead.
7593 (Qcommand_hook_internal): Remove, unused.
7594 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7595 Vcommand_hook_internal.
7596
7597 * eval.c (enum run_hooks_condition): Remove.
7598 (funcall_nil, funcall_not): New functions.
7599 (run_hook_with_args): Call each function through a `funcall' argument.
7600 Remove `cond' argument, now redundant.
7601 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7602 (Frun_hook_with_args_until_failure): Adjust accordingly.
7603 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7604
1db5b1ad
JB
76052011-03-28 Juanma Barranquero <lekktu@gmail.com>
7606
7607 * dispextern.h (string_buffer_position): Remove declaration.
7608
7609 * print.c (strout): Remove parameter `multibyte', unused since
7610 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7611
7612 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7613 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7614 All callers changed.
7615
7616 * w32.c (_wsa_errlist): Use braces for struct initializers.
7617
7618 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7619 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7620 All callers changed.
7621 (string_buffer_position): Likewise. Also, make static (it's never
7622 used outside xdisp.c).
7623 (cursor_row_p): Remove parameter `w', unused since
7624 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7625 (decode_mode_spec): Remove parameter `precision', introduced during
7626 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7627 All callers changed.
7628
5ffb62aa
JD
76292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7630
7631 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7632
461c2ab9 76332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7634
7635 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7636 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7637 (ns_update_auto_hide_menu_bar): New functions.
7638 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7639 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7640 ns_constrain_all_frames.
7641 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7642 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7643
5c380ffb
JD
76442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7645
7646 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7647
9af30bdf
GM
76482011-03-27 Glenn Morris <rgm@gnu.org>
7649
7650 * syssignal.h: Replace RETSIGTYPE with void.
7651 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7652 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7653 Replace SIGTYPE with void everywhere.
7654 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7655 * s/template.h (SIGTYPE): Remove commented out definition.
7656
e2abce01
JB
76572011-03-26 Eli Zaretskii <eliz@gnu.org>
7658
7659 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7660 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7661
f868cd8a
JB
76622011-03-26 Juanma Barranquero <lekktu@gmail.com>
7663
59eb0929
JB
7664 * w32.c (read_unc_volume): Use parameter `henum', instead of
7665 global variable `wget_enum_handle'.
7666
7667 * keymap.c (describe_vector): Remove parameters `indices' and
7668 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7669 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7670
f868cd8a
JB
7671 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7672
7673 * keyboard.c (timer_check): Remove parameter `do_it_now',
7674 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7675 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7676 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7677
7678 * keyboard.c (read_char):
7679 * w32menu.c (w32_menu_display_help):
7680 * xmenu.c (show_help_event, menu_help_callback):
7681 Adjust calls to `show_help_echo'.
7682
7683 * gtkutil.c (xg_maybe_add_timer):
7684 * keyboard.c (readable_events):
7685 * process.c (wait_reading_process_output):
7686 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7687
7688 * insdel.c (adjust_markers_gap_motion):
7689 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7690 (gap_left, gap_right): Don't call it.
7691
2ecf6fdb
CY
76922011-03-25 Chong Yidong <cyd@stupidchicken.com>
7693
7694 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7695 incurred during fontification.
7696
6b1f9ba4
JB
76972011-03-25 Juanma Barranquero <lekktu@gmail.com>
7698
7699 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7700 (DEFVAR_PER_BUFFER): Don't pass it.
7701
7702 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7703 (scrolling_window): Don't pass it.
7704
0f4a96b5
JB
77052011-03-25 Juanma Barranquero <lekktu@gmail.com>
7706
7707 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7708
7709 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7710 and `suffix'.
7711 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7712 of variables specific to SELinux and computation of `encoded_absname'.
7713
7714 * image.c (XPutPixel): Remove unused variable `height'.
7715
7716 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7717
7718 * unexw32.c (get_section_info): Remove unused variable `section'.
7719
7720 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7721 (system_process_attributes): Remove unused variable `sess'.
7722 (sys_read): Remove unused variable `err'.
7723
7724 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7725 (w32_wnd_proc): Remove unused variable `isdead'.
7726 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7727 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7728 (x_create_tip_frame): Remove unused variable `tem'.
7729
7730 * w32inevt.c (w32_console_read_socket):
7731 Remove unused variable `no_events'.
7732
7733 * w32term.c (x_draw_composite_glyph_string_foreground):
7734 Remove unused variable `width'.
7735
1149507c
JB
77362011-03-24 Juanma Barranquero <lekktu@gmail.com>
7737
7738 * w32term.c (x_set_glyph_string_clipping):
7739 Don't pass uninitialized region to CombineRgn.
7740
9c88f339
JB
77412011-03-23 Juanma Barranquero <lekktu@gmail.com>
7742
7743 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7744 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7745 (Fx_close_connection): Remove unused variable `i'.
7746
7747 * w32font.c (w32font_draw): Return number of glyphs.
7748 (w32font_open_internal): Remove unused variable `i'.
7749 (w32font_driver): Add missing initializer.
7750
7751 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7752 (fill_in_menu): Remove unused variable `items_added'.
7753
7754 * w32term.c (last_mouse_press_frame): Remove static global variable.
7755 (w32_clip_to_row): Remove unused variable `f'.
7756 (x_delete_terminal): Remove unused variable `i'.
7757
7758 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7759 (NOTHING): Remove unused static global variable.
7760 (uniscribe_check_otf): Remove unused variable `table'.
7761 (uniscribe_font_driver): Add missing initializers.
7762
dee091a3
JD
77632011-03-23 Julien Danjou <julien@danjou.info>
7764
7765 * term.c (Fsuspend_tty, Fresume_tty):
7766 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7767 * window.c (temp_output_buffer_show):
7768 * insdel.c (signal_before_change):
7769 * frame.c (Fhandle_switch_frame):
7770 * fileio.c (Fdo_auto_save):
7771 * emacs.c (Fkill_emacs):
7772 * editfns.c (save_excursion_restore):
7773 * cmds.c (internal_self_insert):
7774 * callint.c (Fcall_interactively):
7775 * buffer.c (Fkill_all_local_variables):
7776 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7777 Use Frun_hooks.
0f4a96b5 7778 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7779 unconditionnaly since it does the check itself.
7780
2c520ab5 77812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7782
c9c49752
PE
7783 Fix more problems found by GCC 4.5.2's static checks.
7784
8abc3f12
PE
7785 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7786 the first time through the loop, since we know p0 < p1 then.
7787 This also avoids a gcc -Wstrict-overflow warning.
7788
a2d26660
PE
7789 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7790 leading to a memory leak, possible in functions like
7791 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7792 of objects (Bug#8318).
a2d26660 7793
916c72e9
PE
7794 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7795 that could (at least in theory) be that large.
7796
19ab8a18
PE
7797 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7798 This is less likely to overflow, and avoids undefined behavior if
7799 overflow does occur. All callers changed. Use strtoul to scan
7800 for the unsigned long integer.
b7cbbd6f
PE
7801 (pint2hrstr): Simplify and tune code slightly.
7802 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7803
f0641eff
PE
7804 * scroll.c (do_scrolling): Work around GCC bug 48228.
7805 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7806
7f650bb9
PE
7807 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7808 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7809 (validate_x_resource_name): Simplify count usage.
7810 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7811
37dd57d1
PE
7812 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7813 fail (Bug#8306).
81e56e61 7814
699979fc 7815 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7816
401bf9b4
PE
7817 * process.c (Fmake_network_process): Use socklen_t, not int,
7818 where POSIX says socklen_t is required in portable programs.
7819 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7820 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7821 (Fmake_network_process, server_accept_connection):
7822 (wait_reading_process_output, read_process_output):
7823 Likewise.
7824
b93aacde
PE
7825 * process.c: Rename or move locals to avoid shadowing.
7826 (list_processes_1, Fmake_network_process):
7827 (read_process_output_error_handler, exec_sentinel_error_handler):
7828 Rename or move locals.
4dc343ee 7829 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7830 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7831 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7832 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7833 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7834
af8a867c 7835 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7836 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7837 Include tparam.h instead, since it declares them.
af8a867c
PE
7838 * cm.h (PC): Remove extern decl; tparam.h now does this.
7839 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7840 * terminfo.c: Include tparam.h, to check interfaces.
7841 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7842 (tparam): Adjust signature to match interface in tparam.h;
7843 this removes some undefined behavior. Check that outstring and len
7844 are zero, which they always are with Emacs.
7845 * tparam.h (PC, BC, UP): New extern decls.
7846
0248044d 7847 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7848 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7849
8ff096c1 7850 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7851 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7852 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7853 (ftfont_list): Remove unused local.
49eaafba
PE
7854 (get_adstyle_property, ftfont_pattern_entity):
7855 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7856 Rename locals to avoid shadowing.
8ff096c1 7857
e2be39f6
PE
7858 * xfont.c (xfont_list_family): Mark var as initialized.
7859
c9735e30
PE
7860 * xml.c (make_dom): Now static.
7861
8f5201ae
PE
7862 * composite.c (composition_compute_stop_pos): Rename local to
7863 avoid shadowing.
b246f932
PE
7864 (composition_reseat_it): Remove unused locals.
7865 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7866 (composition_update_it): Mark var as initialized.
11b61122
PE
7867 (find_automatic_composition): Mark vars as initialized,
7868 with a FIXME (Bug#8290).
8f5201ae 7869
760fbc2c
PE
7870 character.h: Rename locals to avoid shadowing.
7871 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7872 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7873 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7874 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7875 to avoid shadowing.
7876
ff08eb85
PE
7877 * textprop.c (property_change_between_p): Remove; unused.
7878
fc7bf025
PE
7879 * intervals.c (interval_start_pos): Now static.
7880
235d7abc
PE
7881 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7882
44f230aa
SM
7883 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7884 Rename locals to avoid shadowing.
3e7d6594 7885
50060332
PE
7886 * sound.c (wav_play, au_play, Fplay_sound_internal):
7887 Fix pointer signedness.
d01f234b 7888 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7889 (wav_play): Initialize a variable to 0, to prevent undefined
7890 behavior (Bug#8278).
50060332 7891
c4fc4e30
PE
7892 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7893
918436ed
PE
7894 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7895
c939f91b
PE
7896 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7897 clobbering (Bug#8298).
b9c7f648
PE
7898 * sysdep.c (sys_subshell): Likewise.
7899 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7900
6bd8c144
PE
7901 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7902 This should get cleaned up, so that child_setup has the
7903 same signature on all platforms.
7904
7710357c 7905 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7906 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7907
c59da222
CY
79082011-03-22 Chong Yidong <cyd@stupidchicken.com>
7909
7910 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7911 not to be necessary, and produces flickering.
7912
66b87493
GM
79132011-03-20 Glenn Morris <rgm@gnu.org>
7914
7915 * config.in: Remove file.
7916
45b6f6d5
JB
79172011-03-20 Juanma Barranquero <lekktu@gmail.com>
7918
7919 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7920 are now in src/globals.h.
7921 (syms_of_minibuf): Remove spurious & from previous change.
7922
3ec03f7e
LL
79232011-03-20 Leo <sdl.web@gmail.com>
7924
7925 * minibuf.c (completing-read-function): New variable.
7926 (completing-read-default): Rename from completing-read.
7927 (completing-read): Call completing-read-function.
7928
b14e3e21
CY
79292011-03-19 Juanma Barranquero <lekktu@gmail.com>
7930
7931 * xfaces.c (Fx_load_color_file):
7932 Read color file from absolute filename (bug#8250).
7933
f2b726e6
JB
79342011-03-19 Juanma Barranquero <lekktu@gmail.com>
7935
7936 * makefile.w32-in: Update dependencies.
7937
09f6ff02
EZ
79382011-03-17 Eli Zaretskii <eliz@gnu.org>
7939
7940 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7941
29a6015a
PE
79422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7943
a3a6c54e
PE
7944 Fix more problems found by GCC 4.5.2's static checks.
7945
b766f867
PE
7946 * process.c (make_serial_process_unwind, send_process_trap):
7947 (sigchld_handler): Now static.
7948
be02381c
PE
7949 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7950 That way, the code declares only the vars that it needs.
7951 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7952 * s/cygwin.h (PTY_ITERATION): Likewise.
7953 * s/darwin.h (PTY_ITERATION): Likewise.
7954 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7955
57048744
PE
7956 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7957 * process.c (allocate_pty): Don't declare stb unless it's needed.
7958
7914961c 7959 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7960 (CONSTANTLIM): Remove; unused.
7961 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7962 Define only if needed.
7914961c 7963
b3967b18
PE
7964 * unexelf.c (unexec): Name an expression,
7965 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7966 Use a different way to cause a compilation error if anyone uses
7967 n rather than nn, a way that does not involve shadowing.
73366a00 7968 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7969
29a6015a
PE
7970 * deps.mk (unexalpha.o): Remove; unused.
7971
43cfc33e 7972 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7973 * unexec.h: New file.
ce701a33
PE
7974 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7975 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7976 Depend on unexec.h.
7977 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7978 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7979 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7980 Change as necessary to match prototype in unexec.h.
ce701a33 7981
01f44d5a
PE
7982 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7983 shadowing.
4f63c6bb 7984 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7985
a6670b0b
PE
7986 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7987 Rename locals to avoid shadowing.
7988
cef2010d 7989 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7990 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7991
d4d7173a
PE
7992 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7993
f08b802a
PE
7994 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7995 warning when compiling print.c.
7996
3ddb0639
PE
7997 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7998 instead of using an uninitialized var.
5ad03b97 7999 (font_sort_entities): Mark var as initialized.
3ddb0639 8000
170a2692
PE
8001 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8002
e663c700
PE
8003 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8004 pointers to constants.
89bc529a 8005 (font_parse_fcname): Remove unused vars.
7b81e2d0 8006 (font_delete_unmatched): Now static.
ea838e10 8007 (font_get_spec): Remove; unused.
13a547c6
PE
8008 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8009 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8010 Rename or move locals to avoid shadowing.
e663c700 8011
2a80c887 8012 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8013 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8014
1384fa33 8015 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8016 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8017
8b2c52e9
PE
8018 * alloc.c (mark_backtrace): Move decl from here ...
8019 * lisp.h: ... to here, so that it can be checked.
8020
475545b5 8021 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8022 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8023 (lisp_indirect_variable): Name an expression,
8024 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8025 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8026
b1349114 8027 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8028 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8029 Use const pointer when appropriate.
b1349114 8030
a2928364
PE
8031 * lisp.h (get_system_name, get_operating_system_release):
8032 Move decls here, to check interfaces.
8033 * process.c (get_operating_system_release): Move decl to lisp.h.
8034 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8035 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8036 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8037 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8038 (Fformat_time_string, Fencode_time, Finsert_char):
8039 (Ftranslate_region_internal, Fformat):
8040 Rename or remove local vars to avoid shadowing.
9710023e 8041 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8042
a415e694
PE
8043 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8044 avoid shadowing.
8045
8ef4622d
PE
8046 * lisp.h (eassert): Check that the argument compiles, even if
8047 ENABLE_CHECKING is not defined.
8048
946f9a5b
PE
8049 * data.c (Findirect_variable): Name an expression, to avoid
8050 gcc -Wbad-function-cast warning.
112396d6 8051 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8052 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8053 (Fmake_variable_buffer_local, Fmake_local_variable):
8054 Mark variables as initialized.
52746918 8055 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8056
e5aab7e7 8057 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8058 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8059 Rename locals to avoid shadowing.
dff45157
PE
8060 (mark_stack): Move local variables into the #ifdef region where
8061 they're used.
7bc26fdb
PE
8062 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8063 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8064 needed otherwise.
8065 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8066 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8067 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8068
e5aab7e7
PE
8069 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8070 avoids undefined behavior in theory.
8071
4da60324
PE
8072 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8073
88043301
PE
8074 Use functions, not macros, for up- and down-casing (Bug#8254).
8075 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8076 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8077 to use the following functions instead of these macros.
8078 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8079 EMACS_INT, since callers assume the returned value fits in int.
8080 (upcase1): Likewise, for UPCASE_TABLE.
8081 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8082 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8083 the race-condition problem in the old DOWNCASE.
88043301 8084
19ed5445
PE
8085 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8086 Rename locals to avoid shadowing.
8087 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8088 (regex_compile, re_search_2, re_match_2_internal):
8089 Remove unused local vars.
952db0d7
PE
8090 (FREE_VAR): Rewrite so as not to use empty "else",
8091 which gcc can warn about.
da053e48 8092 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8093 (RETALLOC_IF): Define only if needed.
8094 (WORDCHAR_P): Likewise. This one is never needed, but is used
8095 only in a comment talking about a compiler bug, so put inside
8096 the #if 0 of that comment.
8097 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8098 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8099 Remove; unused.
19ed5445 8100
1f3561e4 8101 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8102 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8103 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8104
ded6f8f7
PE
8105 * search.c (simple_search): Remove unused var.
8106
dbd37a95
PE
8107 * dired.c (compile_pattern): Move decl from here ...
8108 * lisp.h: ... to here, so that it can be checked.
8109 (struct re_registers): New forward decl.
8110
7e47afad
PE
8111 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8112
85f24f61
PE
8113 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8114 All uses changed.
8115 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8116 Rename locals to avoid shadowing.
5671df8f 8117 (Fvertical_motion): Mark locals as initialized.
85f24f61 8118
181aa2be 8119 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8120 (casify_region): Mark local as initialized.
181aa2be 8121
930d429c
PE
8122 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8123
7082eac6
PE
8124 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8125 New macros, so that the caller can use some names other than
8126 gcpro1, gcpro2, etc.
8127 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8128 of the new macros.
8129 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8130 argument, for consistency with GCPRO2_VAR, etc: it is now the
8131 prefix of the variable, not the variable itself. All uses
8132 changed.
38b2c076
PE
8133 * dired.c (directory_files_internal, file_name_completion):
8134 Rename locals to avoid shadowing.
8135
15206ed9
PE
8136 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8137 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8138 dired.c's scmp function, had undefined behavior.
8139 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8140 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8141 * buffer.h: ... to here, because these macros use current_buffer,
8142 and the new implementation with inline functions needs to have
8143 current_buffer in scope now, rather than later when the macros
8144 are used.
8145 (downcase, upcase1): New static inline functions.
8146 (DOWNCASE, UPCASE1): Reimplement using these functions.
8147 This avoids undefined behavior in expressions like
8148 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8149 from race conditions in accessing the global variables
8150 case_temp1 and case_temp2.
8151 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8152 * lisp.h (case_temp1, case_temp2): Remove their decls.
8153 * character.h (ASCII_CHAR_P): Move from here ...
8154 * lisp.h: ... to here, so that the inline functions mentioned
8155 above can use them.
8156
4a6bea26
PE
8157 * dired.c (directory_files_internal_unwind): Now static.
8158
f14b7e14
PE
8159 * fileio.c (file_name_as_directory, directory_file_name):
8160 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8161 Now static.
2893f146
PE
8162 (file_name_as_directory): Use const pointers when appropriate.
8163 (Fexpand_file_name): Likewise. In particular, newdir might
8164 point at constant storage, so make it a const pointer.
fd4ead52 8165 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8166 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8167 signedness issues.
f839df0c
PE
8168 (Fset_file_times, Finsert_file_contents, auto_save_error):
8169 Rename locals to avoid shadowing.
f14b7e14 8170
5716756e 8171 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8172 (Ftry_completion, Fall_completions): Rename or remove locals
8173 to avoid shadowing.
5716756e 8174
b4c3046a
PE
8175 * marker.c (bytepos_to_charpos): Remove; unused.
8176
b45db522
PE
8177 * lisp.h (verify_bytepos, count_markers): New decls,
8178 so that gcc does not warn that these functions aren't declared.
8179
85876d07
PE
8180 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8181 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8182 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8183 (copy_text): Remove unused local var.
85876d07 8184
03d78a21 8185 * filelock.c (within_one_second): Now static.
b3dd38ab 8186 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8187
5df8f01b
PE
8188 * buffer.c (fix_overlays_before): Mark locals as initialized.
8189 (fix_start_end_in_overlays): Likewise. This function should be
8190 simplified by using pointers-to-pointers, but that's a different
8191 matter.
b1d876f1 8192 (switch_to_buffer_1): Now static.
8f54f30a
PE
8193 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8194 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8195
a70072c9 8196 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8197 Fix pointer signedness issue.
edced198
PE
8198 (sys_subshell): Mark local as volatile if checking for lint,
8199 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8200 (MAXPATHLEN): Define only if needed.
a70072c9 8201
a0977c44
PE
8202 * process.c (serial_open, serial_configure): Move decls from here ...
8203 * systty.h: ... to here, so that they can be checked.
8204
a884fdcc
PE
8205 * fns.c (get_random, seed_random): Move extern decls from here ...
8206 * lisp.h: ... to here, so that they can be checked.
8207
604efe86 8208 * sysdep.c (reset_io): Now static.
b8950c94 8209 (wait_for_termination_signal): Remove; unused.
604efe86 8210
38fc62d9
PE
8211 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8212 (copy_keymap_item, append_key, push_text_char_description):
8213 Now static.
1004a21a 8214 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8215 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8216 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8217 (describe_map_tree):
8218 Rename locals to avoid shadowing.
38fc62d9 8219
2f2650da
PE
8220 * keyboard.c: Declare functions static if they are not used elsewhere.
8221 (echo_char, echo_dash, cmd_error, top_level_2):
8222 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8223 (read_char, kbd_buffer_get_event, make_lispy_position):
8224 (make_lispy_event, make_lispy_movement, apply_modifiers):
8225 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8226 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8227 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8228 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8229 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8230
a053e86c 8231 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8232 (mark_kboards): Move decl here ...
8233 * alloc.c (mark_kboards): ... from here.
a053e86c 8234
4752793e
PE
8235 * lisp.h (force_auto_save_soon): New decl.
8236
74f10ca7 8237 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8238 (DEFINE_DUMMY_FUNCTION): New macro.
8239 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8240 Use it.
c03cd23f
PE
8241 (main): Add casts to avoid warnings
8242 if GCC considers string literals to be constants.
74f10ca7 8243
022e70d4
PE
8244 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8245
59d6fe83
PE
8246 * dbusbind.c: Pointer signedness fixes.
8247 (xd_signature, xd_append_arg, xd_initialize):
8248 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8249 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8250 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8251 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8252
78320123
PE
8253 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8254 if GCC considers string literals to be constants.
49cebcca 8255 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8256
35ac2a97
SM
82572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8258
fb103ca9
SM
8259 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8260 (print_preprocess, print_object): New macro to fix last change.
8261
35ac2a97
SM
8262 * print.c (print_preprocess): Don't forget font objects.
8263
62973b41
JB
82642011-03-16 Juanma Barranquero <lekktu@gmail.com>
8265
8266 * emacs.c (USAGE3): Doc fixes.
8267
0e48bb22
AS
82682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8269
8270 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8271 structure.
8272
7684e57b
JB
82732011-03-14 Juanma Barranquero <lekktu@gmail.com>
8274
8275 * lisp.h (VWindow_system, Qfile_name_history):
8276 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8277 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8278 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8279
8280 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8281 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8282
8283 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8284 * w32console.c (detect_input_pending, read_input_pending)
8285 (encode_terminal_code):
8286 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8287 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8288 (w32_system_caret_y, Qfile_name_history):
8289 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8290 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8291 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8292 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8293 * w32proc.c (Qlocal, report_file_error):
8294 * w32term.c (Vwindow_system, updating_frame):
8295 * w32uniscribe.c (initialized, uniscribe_font_driver):
8296 Remove unneeded extern declarations.
8297
2aa46d6c
CY
82982011-03-14 Chong Yidong <cyd@stupidchicken.com>
8299
c96bbc66 8300 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8301
cffc6f3b
CY
83022011-03-13 Chong Yidong <cyd@stupidchicken.com>
8303
8304 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8305 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8306 These macros can no longer be used for assignment.
8307
44f230aa
SM
8308 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8309 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8310 (record_buffer_markers, fetch_buffer_markers): New functions for
8311 recording and fetching special buffer markers.
8312 (set_buffer_internal_1, set_buffer_temp): Use them.
8313
8314 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8315
8316 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8317
8318 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8319 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8320
8321 * xdisp.c (hscroll_window_tree):
8322 (reconsider_clip_changes): Use PT instead of BUF_PT.
8323
d251f04b
EZ
83242011-03-13 Eli Zaretskii <eliz@gnu.org>
8325
8326 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8327 $(EMACS_ROOT)/lib/intprops.h.
8328
f0c77cd1
PE
83292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8330
3eca4629
PE
8331 Fix more problems found by GCC 4.5.2's static checks.
8332
7c86ee98
PE
8333 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8334 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8335 (xg_free_frame_widgets): Make it clear that a local variable is
8336 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8337 (gdk_window_get_screen): Make it clear that this macro is needed
8338 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8339 (int_gtk_range_get_value): New function, which avoids a diagnostic
8340 from gcc -Wbad-function-cast.
8341 (xg_set_toolkit_scroll_bar_thumb): Use it.
8342 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8343 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8344 (get_utf8_string, xg_get_file_with_chooser):
8345 Rename locals to avoid shadowing.
8346 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8347
41729b81
PE
8348 * xgselect.c (xg_select): Remove unused var.
8349
f0c77cd1
PE
8350 * image.c (four_corners_best): Mark locals as initialized.
8351 (gif_load): Initialize transparent_p to zero (Bug#8238).
8352 Mark another local as initialized.
ec6cf4c6 8353 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8354
ce0ad53d 8355 * image.c (clear_image_cache): Now static.
d5d5a617 8356 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8357 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8358 (x_edge_detection): Remove unnecessary cast that
8359 gcc -Wbad-function-cast diagnoses.
2037898d 8360 (gif_load): Fix pointer signedness.
6ae141d6
PE
8361 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8362 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8363
33383987 83642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8365
d32df629
PE
8366 Improve quality of tests for time stamp overflow.
8367 For example, without this patch (encode-time 0 0 0 1 1
8368 1152921504606846976) returns the obviously-bogus value (-948597
8369 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8370 reports time overflow. See
8371 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8372 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8373 * editfns.c: Include limits.h and intprops.h.
8374 (TIME_T_MIN, TIME_T_MAX): New macros.
8375 (time_overflow): Move earlier, to before first use.
8376 (hi_time, lo_time): New functions, for an accurate test for
8377 out-of-range times.
8378 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8379 (Fget_internal_run_time): Don't assume time_t fits in int.
8380 (make_time): Use list2 instead of Fcons twice.
8381 (Fdecode_time): More accurate test for out-of-range times.
8382 (check_tm_member): New function.
8383 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8384 (lisp_time_argument): Don't rely on undefined left-shift and
8385 right-shift behavior when checking for time stamp overflow.
8be6f318 8386
fe31d94c
PE
8387 * editfns.c (time_overflow): New function, refactoring common code.
8388 (Fformat_time_string, Fdecode_time, Fencode_time):
8389 (Fcurrent_time_string): Use it.
8390
8be6f318
PE
8391 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8392 * dired.c (make_time): Move to ...
8393 * editfns.c (make_time): ... here.
8394 * systime.h: Note the move.
8395
09d9db2c 83962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8397
126bc0dc
YM
8398 * fringe.c (update_window_fringes): Remove unused variables.
8399
c47cbdfd
YM
8400 * unexmacosx.c (copy_data_segment): Also copy __got section.
8401 (Bug#8223)
8402
7ac80be9
EZ
84032011-03-12 Eli Zaretskii <eliz@gnu.org>
8404
c96bbc66 8405 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8406 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8407 Constify `char *' arguments and their references according to
8408 prototypes in tparam.h.
8409
ecb0f94d 8410 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8411
7ac80be9
EZ
8412 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8413 Adapt all references accordingly.
8414
8415 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8416
ef1fd07e
TT
84172011-03-11 Tom Tromey <tromey@redhat.com>
8418
8419 * buffer.c (syms_of_buffer): Remove obsolete comment.
8420
7ef4b50c
EZ
84212011-03-11 Eli Zaretskii <eliz@gnu.org>
8422
8423 * termhooks.h (encode_terminal_code): Declare prototype.
8424
8425 * msdos.c (encode_terminal_code): Don't declare prototype.
8426
8427 * term.c (encode_terminal_code): Now external again, used by
8428 w32console.c and msdos.c.
8429
44f230aa
SM
8430 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8431 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8432
4b1ec863 84332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8434
1714f52b 8435 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8436
4b1ec863
PE
8437 * fringe.c (update_window_fringes): Mark locals as initialized
8438 (Bug#8227).
8439 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8440
524c7aa6
PE
8441 * alloc.c (mark_fringe_data): Move decl from here ...
8442 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8443 to check its interface.
8444 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8445
a5c0af81 8446 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8447 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8448 (fontset_font): Mark local as initialized.
a9a06e0b 8449 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8450
b4716021
PE
8451 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8452
811e9bac 8453 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8454 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8455 (x_own_selection, Fx_disown_selection_internal): Rename locals
8456 to avoid shadowing.
8457 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8458
7e3ab302
PE
8459 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8460 so that the caller can use some name other than gcpro1.
8461 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8462 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8463 (Fx_backspace_delete_keys_p):
8464 Use them to avoid shadowing, and rename vars to avoid shadowing.
8465 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8466 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8467 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8468 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8469 Remove unused locals.
7e3ab302
PE
8470 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8471 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8472 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8473 macros.
f78faa98 8474
e2b13473
PE
8475 * xterm.h (x_mouse_leave): New decl.
8476
77f23912
PE
8477 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8478 Remove unused functions.
cdf4ba58
PE
8479 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8480 (x_calc_absolute_position): Now static.
7411c686 8481 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8482 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8483 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8484 unless they are used.
38d0b34a
PE
8485 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8486 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8487 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8488 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8489 (x_error_catcher, x_connection_closed, x_error_handler):
8490 (x_error_quitter, xembed_send_message, x_iconify_frame):
8491 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8492 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8493 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8494
44f230aa
SM
8495 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8496 Rename or move locals to avoid shadowing.
6b463e58 8497 (tty_defined_color, merge_face_heights): Now static.
5967d051 8498 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8499 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8500 does not deduce is never used uninitialized.
73719eba
PE
8501 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8502 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8503
426994c3 8504 * terminal.c (store_terminal_param): Now static.
5489860b 8505
032f1620 8506 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8507 (set_frame_menubar): Remove unused local.
d4323972 8508 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8509 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8510 since they might point to immutable storage.
281585b0
PE
8511 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8512 since it's unused otherwise.
032f1620 8513
367c19e5 8514 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8515 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8516 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8517 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8518 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8519 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8520 does not deduce are never used uninitialized.
70739cbe 8521
07b48fa9
PE
8522 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8523
8868a238 8524 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8525 * window.c (window_loop, size_window):
8526 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8527
7e5cf297 8528 * window.c (display_buffer): Now static.
d6550a9f
PE
8529 (size_window): Mark variables that gcc -Wuninitialized
8530 does not deduce are never used uninitialized.
a586633d
PE
8531 * window.h (check_all_windows): New decl, to forestall
8532 gcc -Wmissing-prototypes diagnostic.
5b555da1 8533 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8534
f6095868
PE
8535 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8536 shadowing.
8537 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8538 Include <limits.h>.
8539 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8540 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8541 (load_charset_map): Mark variables that gcc -Wuninitialized
8542 does not deduce are never used uninitialized.
53df7c11 8543 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8544
f38b440c
PE
8545 * coding.c (coding_set_source, coding_set_destination):
8546 Use "else { /* comment */ }" rather than "else /* comment */;"
8547 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8548 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8549 a block, when the outer 'i' will do.
8550 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8551 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8552 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8553 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8554 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8555 Rename locals to avoid shadowing.
8556 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8557 * coding.c (emacs_mule_char, encode_invocation_designation):
8558 Now static, since they're not used elsewhere.
413bb2db 8559 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8560 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8561 (decode_coding_emacs_mule): Mark variables that gcc
8562 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8563 (detect_coding_iso_2022): Initialize a local variable that might
8564 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8565 this initialization is needed. (Bug#8211)
5f58e762
PE
8566 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8567 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8568 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8569 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8570 Remove unused macros.
f38b440c 8571
232b38b9 8572 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8573 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8574 * character.c (string_count_byte8): Likewise.
232b38b9 8575
fb90da1b
PE
8576 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8577 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8578
fb93dbc2
PE
8579 * chartab.c (copy_sub_char_table): Now static, since it's not used
8580 elsewhere.
5c156ace
PE
8581 (sub_char_table_ref_and_range, char_table_ref_and_range):
8582 Rename locals to avoid shadowing.
bbcd0949 8583 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8584
7d3b3862 8585 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8586 (BIDI_BOB): Remove unused macro.
7d3b3862 8587
6be7d3da
PE
8588 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8589 deduce are never used uninitialized.
c2ed9c8b 8590 * term.c (encode_terminal_code): Likewise.
6be7d3da 8591
75f8807f 8592 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8593
50938595
PE
8594 * tparam.h: New file.
8595 * term.c, tparam.h: Include it.
8596 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8597 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8598 Move these decls to tparam.h, and make them agree with what
8599 is actually in tparam.c. The previous trick of using incompatible
8600 decls in different modules does not conform to the C standard.
8601 All callers of tparam changed to use tparam's actual API.
8602 * tparam.c (tparam1, tparam, tgoto):
8603 Use const pointers where appropriate.
8604
fbceeba2
PE
8605 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8606 * cm.h (struct cm): Likewise.
8607 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8608 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8609 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8610 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8611 (turn_on_face, init_tty): Likewise.
8612 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8613
7f3f1250
PE
8614 * term.c (term_mouse_position): Rename local to avoid shadowing.
8615
e6ca6543
PE
8616 * alloc.c (mark_ttys): Move decl from here ...
8617 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8618
c40f8d15
AS
86192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8620
8621 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8622
cfe0661d
JB
86232011-03-09 Juanma Barranquero <lekktu@gmail.com>
8624
8625 * search.c (compile_pattern_1): Remove argument regp, unused since
8626 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8627 (compile_pattern): Don't pass it.
8628
0afb4571
J
86292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8630
8631 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8632 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8633 for ! HAVE_GTK3.
8634 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8635
8636 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8637
8638 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8639 gdk_window_get_screen, gdk_window_get_geometry,
8640 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8641 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8642 (xg_get_pixbuf_from_pixmap): New function.
8643 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8644 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8645 Call xg_get_pixbuf_from_pixmap instead of
8646 gdk_pixbuf_get_from_drawable.
8647 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8648 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8649 (xg_check_special_colors): Use GtkStyleContext and its functions
8650 for HAVE_GTK3.
8651 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8652 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8653 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8654 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8655 Call gtk_widget_get_preferred_size.
0afb4571
J
8656 (xg_frame_resized): gdk_window_get_geometry only takes 5
8657 parameters.
44f230aa
SM
8658 (xg_win_to_widget, xg_event_is_for_menubar):
8659 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8660 (xg_set_widget_bg): New function.
8661 (delete_cb): New function.
895009e1 8662 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8663 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8664 (xg_set_background_color): Call xg_set_widget_bg.
8665 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8666 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8667 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8668 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8669 if ! HAVE_GTK3.
8670 (update_frame_tool_bar): Call gtk_widget_hide.
8671 (xg_initialize): Use GDK_KEY_g.
8672
8673 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8674 if ! HAVE_GTK3
8675 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8676
8677 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8678 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8679 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8680
1c2cc4ef
JB
86812011-03-08 Juanma Barranquero <lekktu@gmail.com>
8682
8683 * w32xfns.c (select_palette): Check success of RealizePalette against
8684 GDI_ERROR, not zero.
8685
33383987 8686See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8687
8688;; Local Variables:
8689;; coding: utf-8
aac0c6e3
MR
8690;; End:
8691
33383987 8692 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8693
8694 This file is part of GNU Emacs.
8695
8696 GNU Emacs is free software: you can redistribute it and/or modify
8697 it under the terms of the GNU General Public License as published by
8698 the Free Software Foundation, either version 3 of the License, or
8699 (at your option) any later version.
8700
8701 GNU Emacs is distributed in the hope that it will be useful,
8702 but WITHOUT ANY WARRANTY; without even the implied warranty of
8703 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8704 GNU General Public License for more details.
8705
8706 You should have received a copy of the GNU General Public License
8707 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.