Move completing-read-function and completing-read-default to elisp
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4e323265
LL
12011-06-22 Leo Liu <sdl.web@gmail.com>
2
3 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4 Move to minibuffer.el.
5
85fece3e
PE
62011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7
20b84ce9 8 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9 The following patches are for when GLYPH_DEBUG && !XASSERT.
10 * dispextern.h (trace_redisplay_p, dump_glyph_string):
11 * dispnew.c (flush_stdout):
12 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13 Mark as externally visible.
14 * dispnew.c (check_window_matrix_pointers): Now static.
15 * dispnew.c (window_to_frame_vpos):
16 * xfns.c (unwind_create_frame):
17 * xterm.c (x_check_font): Remove unused local.
18 * scroll.c (CHECK_BOUNDS):
19 * xfaces.c (cache_fache): Rename local to avoid shadowing.
20 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
21 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
22 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
23 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
24 Now static.
25 (debug_method_add): Use va_list and vsprintf rather than relying
26 on undefined behavior with wrong number of arguments.
27 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
28 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
29 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
30 since we're not interested in debugging glyphs with old libraries.
31 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
32 GCC 4.6.0's static checking.
33
0766b489
PE
342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
35
31fd4b32
PE
36 Integer overflow and signedness fixes (Bug#8873).
37 A few related buffer overrun fixes, too.
38
b79e8648
PE
39 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
40
0766b489
PE
41 * dispextern.h (struct face.stipple):
42 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
43 (x_bitmap_mask, x_allocate_bitmap_record)
44 (x_create_bitmap_from_data, x_create_bitmap_from_file)
45 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
46 (x_create_bitmap_from_xpm_data):
47 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
48 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
49 (.bitmaps_last):
50 * xfaces.c (load_pixmap):
51 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
52 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
53 (.bitmaps_last, struct x_output.icon_bitmap):
54 Use ptrdiff_t, not int, for bitmap indexes.
55 (x_allocate_bitmap_record): Check for size overflow.
56 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
57
b081724f
PE
58 Use ptrdiff_t, not int, for overlay counts.
59 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
60 * editfns.c (overlays_around, get_pos_property):
61 * textprop.c (get_char_property_and_overlay):
62 * xdisp.c (next_overlay_change, note_mouse_highlight):
63 * xfaces.c (face_at_buffer_position):
21514da7
PE
64 * buffer.c (OVERLAY_COUNT_MAX): New macro.
65 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
66 (Fnext_overlay_change, Fprevious_overlay_change)
67 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 68 Use ptrdiff_t, not int, for sizes.
21514da7 69 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 70
3de73e5e
PE
71 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
72
2606c57b
PE
73 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
74 (x_session_initialize): Do not assume string length fits in int.
75
aaafe47a
PE
76 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
77 This is unlikely, but can occur if DPI is outlandish.
78
2674ddc8 79 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
80 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
81
28154962
PE
82 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
83 * xrdb.c (magic_file_p, search_magic_path):
84 Omit last arg SUFFIX; it was always 0. All callers changed.
85 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
86
7de51af5
PE
87 * xfont.c (xfont_match): Avoid need for strlen.
88
25ed6cc3
PE
89 * xfns.c: Don't assume strlen fits in int.
90 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
91
4eab31dd
PE
92 * xdisp.c (message_log_check_duplicate): Return intmax_t,
93 not unsigned long, as we prefer signed integers. All callers changed.
94 Detect integer overflow in repeat count.
95 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 96 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 97
171e2a58
PE
98 * termcap.c: Don't assume sizes fit in int and never overflow.
99 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
100 (gobble_line): Check for size-calculation overflow.
101
ad39faca 102 * minibuf.c (Fread_buffer):
6e5bb2dc 103 * lread.c (intern, intern_c_string):
74ca2eb3
PE
104 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
105 Don't assume string length fits in int.
106
52c61c22 107 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
108 * gtkutil.c (style_changed_cb): Avoid need for strlen.
109
b5b8c9e5
PE
110 * font.c: Don't assume string length fits in int.
111 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
112 Use ptrdiff_t, not int.
ccd6111c
PE
113 (font_intern_prop): Don't assume string length fits in int.
114 Don't assume integer property fits in fixnum.
115 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 116
882f0d81 117 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 118 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
119 Reformulate so as not to need the command string.
120 Invoke gzip -cd rather than gunzip, as it's more portable.
121 (lock_info_type, lock_file_1, lock_file):
122 Don't assume pid_t and time_t fit in unsigned long.
123 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
124 (current_lock_owner): Prefer signed type for sizes.
125 Use memcpy, not strncpy, where memcpy is what is really wanted.
126 Don't assume (via atoi) that time_t and pid_t fit in int.
127 Check for time_t and/or pid_t out of range, e.g., via a network share.
128 Don't alloca where an auto var works fine.
129
93f4cf88
PE
130 * fileio.c: Fix some integer overflow issues.
131 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
132 Don't assume string length fits in int.
133 (directory_file_name): Don't assume string length fits in long.
134 (make_temp_name): Don't assume pid fits in int, or that its print
135 length is less than 20.
136
f3e92b69
PE
137 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
138
1bfdaf10
PE
139 * coding.c (make_subsidiaries): Don't assume string length fits in int.
140
35016e9a
PE
141 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
142
3d1e65a1
PE
143 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
144 We prefer signed integers, even for size calculations.
145
0b963a93
PE
146 * emacs.c: Don't assume string length fits in 'int'.
147 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
148 (main): Don't invoke strlen when not needed.
149
573f4b54
PE
150 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
151 (XD_DEBUG_MESSAGE): Don't waste a byte.
152
989f33ba
PE
153 * callproc.c (getenv_internal_1, getenv_internal)
154 (Fgetenv_internal):
965d34eb
PE
155 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
156
e4d29b33
PE
157 * lread.c (invalid_syntax): Omit length argument.
158 All uses changed. This doesn't fix a bug, but it simplifies the
159 code away from its former Hollerith-constant appearance, and it's
160 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 161 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 162
eb49b136
PE
163 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
164 This didn't break anything, but it didn't help either.
165 It's confusing to put a bogus integer in a place where the actual
166 value does not matter.
9f62aeb1 167 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 168 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 169
15375a22
PE
170 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
171 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
172 implementation.
b61cc01c
PE
173 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
174 We prefer signed types, and the value cannot exceed the EMACS_INT
175 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
176 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
177 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
178 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 179
53b2623d
PE
180 * indent.c (sane_tab_width): New function.
181 (current_column, scan_for_column, Findent_to, position_indentation)
182 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 183 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 184
51cab52b 185 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 186
f2ed8a70
PE
187 * lisp.h (lint_assume): New macro.
188 * composite.c (composition_gstring_put_cache):
189 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
190
abe80cc6
PE
191 * editfns.c, insdel.c:
192 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 193
b02c740e
PE
194 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
195
ebc96716
PE
196 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
197
b4e50fa0 198 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 199 Use much-faster test for byte-length change.
311d5d7c 200 Don't assume string byte-length fits in 'int'.
a4cf38e4 201 Check that character arg fits in 'int'.
85461888 202 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 203
c0c1ee9f
PE
204 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
205
a498d7f4
PE
206 * fns.c (concat): Catch string overflow earlier.
207 Do not rely on integer wraparound.
208
51cab52b
PE
209 * dispextern.h (struct it.overlay_strings_charpos)
210 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
211 * xdisp.c (forward_to_next_line_start)
212 (back_to_previous_visible_line_start)
213 (reseat_at_next_visible_line_start, next_element_from_buffer):
214 Don't arbitrarily truncate the value of 'selective' to int.
215
76031fad
PE
216 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
217
5eb55db9
PE
218 * composite.c: Don't truncate sizes to 'int'.
219 (composition_gstring_p, composition_reseat_it)
220 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
221 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
222 not EMACS_UINT, for indexes.
5eb55db9 223
0703a717
PE
224 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
225
d6202519
PE
226 * buffer.c: Include <verify.h>.
227 (struct sortvec.priority, struct sortstr.priority):
8961a454 228 Now EMACS_INT, not int.
c20998a7 229 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
230 (struct sortstr.size, record_overlay_string)
231 (struct sortstrlist.size, struct sortlist.used):
232 Don't truncate size to int.
233 (record_overlay_string): Check for size-calculation overflow.
d6202519 234 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 235
d5a19415
JM
2362011-06-22 Jim Meyering <meyering@redhat.com>
237
238 don't leak an XBM-image-sized buffer
239 * image.c (xbm_load): Free the image buffer after using it.
240
a9041e6c
PE
2412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
242
243 Port to Sun C.
244 * composite.c (find_automatic_composition): Omit needless 'return 0;'
245 that Sun C diagnosed.
246 * fns.c (secure_hash): Fix pointer signedness issue.
247 * intervals.c (static_offset_intervals): New function.
248 (offset_intervals): Use it.
249
7f3f739f
LL
2502011-06-21 Leo Liu <sdl.web@gmail.com>
251
252 * deps.mk (fns.o):
253 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
254 sha512.h.
255
256 * fns.c (secure_hash): Rename from crypto_hash_function and change
257 the first arg to accept symbols.
258 (Fsecure_hash): New primtive.
259 (syms_of_fns): New symbols.
260
76147d94
DD
2612011-06-20 Deniz Dogan <deniz@dogan.se>
262
263 * process.c (Fset_process_buffer): Clarify return value in
264 docstring.
265
7d7d0045
CY
2662011-06-18 Chong Yidong <cyd@stupidchicken.com>
267
268 * dispnew.c (add_window_display_history): Use BVAR.
269
270 * xdisp.c (debug_method_add): Use BVAR.
271 (check_window_end, dump_glyph_matrix, dump_glyph)
272 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
273
274 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
275 Likewise.
276
277 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
278 check till after the cache is created in init_frame_faces.
279
ff2bc410
SM
2802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
281
282 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
283
28177add
PE
2842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
285
dd3482fe
PE
286 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
287 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
288 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
289
393d71f3 290 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
291 * fileio.c (Finsert_file_contents):
292 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
293 Remove the old (too-loose) buffer overflow checks.
294 They weren't needed, since make_gap checks for buffer overflow.
295 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
296 The old code merely checked for Emacs fixnum overflow, and relied
297 on undefined (wraparound) behavior. The new code avoids undefined
298 behavior, and also checks for ptrdiff_t and/or size_t overflow.
299
2e6813b0 300 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
301 Tune. Don't use wider integers than needed. Don't use alloca.
302 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 303
599a9e4f
PE
304 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
305
99561444
PE
306 * insdel.c, lisp.h (buffer_overflow): New function.
307 (insert_from_buffer_1, replace_range, replace_range_2):
308 * insdel.c (make_gap_larger):
309 * editfns.c (Finsert_char):
310 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
311
28177add
PE
312 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
313
e69dafad
PE
3142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
315
a7af7fde 316 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 317
b1c46f02
PE
318 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
319 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
320
e69dafad
PE
321 * fileio.c: Don't assume EMACS_INT fits in off_t.
322 (emacs_lseek): New static function.
323 (Finsert_file_contents, Fwrite_region): Use it.
324 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
325
566684ea
PE
326 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
327
e6966cd6
PE
328 * fns.c: Don't overflow int when computing a list length.
329 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
330 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
331 truncation on 64-bit hosts. Check for QUIT every
332 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
333 faster and is responsive enough.
334 (Flength): Report an error instead of overflowing an integer.
335 (Fsafe_length): Return a float if the value is not representable
336 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 337 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 338 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 339
dd0b0efb
PE
340 * alloc.c: Check that resized vectors' lengths fit in fixnums.
341 (header_size, word_size): New constants.
342 (allocate_vectorlike): Don't check size overflow here.
343 (allocate_vector): Check it here instead, since this is the only
344 caller of allocate_vectorlike that could cause overflow.
345 Check that the new vector's length is representable as a fixnum.
346
86fe5cfe
PE
347 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
348 The previous code was bogus. For example, next_almost_prime (32)
349 returned 39, which is undesirable as it is a multiple of 3; and
350 next_almost_prime (24) returned 25, which is a multiple of 5 so
351 why was the code bothering to check for multiples of 7?
352
80e88859
PE
353 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
354
4a2f0ad6
PE
355 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
356
f66c7cf8
PE
357 Variadic C functions now count arguments with ptrdiff_t.
358 This partly undoes my 2011-03-30 change, which replaced int with size_t.
359 Back then I didn't know that the Emacs coding style prefers signed int.
360 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
361 were being counted with int, which may truncate counts on 64-bit
362 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
363 * lisp.h (struct Lisp_Subr.function.aMANY)
364 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
365 Arg counts are now ptrdiff_t, not size_t.
366 All variadic functions and their callers changed accordingly.
367 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
368 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
369 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
370 * callint.c (Fcall_interactively): Check arg count for overflow,
371 to avoid potential buffer overrun. Use signed char, not 'int',
372 for 'varies' array, so that we needn't bother to check its size
373 calculation for overflow.
374 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
375 * eval.c (apply_lambda):
376 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
377 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
378 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
379
a1759b76
PE
380 * callint.c (Fcall_interactively): Don't use index var as event count.
381
d96be9fc
PE
382 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
383 * mem-limits.h (SIZE): Remove; no longer used.
384
a690a978 385 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 386
578c21e6
PE
387 Remove unnecessary casts.
388 * xterm.c (x_term_init):
389 * xfns.c (x_set_border_pixel):
390 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
391 These aren't needed now that we assume ANSI C.
392
96f53c6c
PE
393 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
394 It's more likely to cause problems (due to unsigned overflow)
395 than to cure them.
396
83c77d31
PE
397 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
398
ee2079f1
PE
399 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
400
6da65536
PE
401 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
402
7147c4a4
PE
403 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
404
193e32d9
PE
405 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
406
e5533da6
PE
407 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
408
9910e595
PE
409 GLYPH_CODE_FACE returns EMACS_INT, not int.
410 * dispextern.h (merge_faces):
411 * xfaces.c (merge_faces):
01103c44
PE
412 * xdisp.c (get_next_display_element, next_element_from_display_vector):
413 Don't assume EMACS_INT fits in int.
9910e595 414
2638320e
PE
415 * character.h (CHAR_VALID_P): Remove unused parameter.
416 * fontset.c, lisp.h, xdisp.c: All uses changed.
417
045eb8d9
PE
418 * editfns.c (Ftranslate_region_internal): Omit redundant test.
419
c1f134b5
PE
420 * fns.c (concat): Minor tuning based on overflow analysis.
421 This doesn't fix any bugs. Use int to hold character, instead
422 of constantly refetching from Emacs object. Use XFASTINT, not
423 XINT, for value known to be a character. Don't bother comparing
424 a single byte to 0400, as it's always less.
425
395fcb93 426 * floatfns.c (Fexpt):
327eeec8
PE
427 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
428
abbd3d23
PE
429 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
430 for characters.
431
684a03ef
PE
432 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
433
0fed43f3
PE
434 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
435 Without this fix, on a 64-bit host (aset S 0 4294967386) would
436 incorrectly succeed when S was a string, because 4294967386 was
437 truncated before it was used.
438
8fd02eb7
PE
439 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
440 Otherwise, an out-of-range integer could cause undefined behavior
441 on a 64-bit host.
442
f8c86b69
PE
443 * composite.c: Use int, not EMACS_INT, for characters.
444 (fill_gstring_body, composition_compute_stop_pos): Use int, not
445 EMACS_INT, for values that are known to be in character range.
446 This doesn't fix any bugs but is the usual style inside Emacs and
447 may generate better code on 32-bit machines.
448
34206dd2
PE
449 Make sure a 64-bit char is never passed to ENCODE_CHAR.
450 This is for reasons similar to the recent CHAR_STRING fix.
451 * charset.c (Fencode_char): Check that character arg is actually
452 a character. Pass an int to ENCODE_CHAR.
453 * charset.h (ENCODE_CHAR): Verify that the character argument is no
454 wider than 'int', as a compile-time check to prevent future regressions
455 in this area.
456
c5958d4c 457 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
458
459 Make sure a 64-bit char is never passed to CHAR_STRING.
460 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
461 by silently ignoring the top 32 bits, allowing some values
462 that were far too large to be valid characters.
463 * character.h: Include <verify.h>.
464 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
465 arguments are no wider than unsigned, as a compile-time check
466 to prevent future regressions in this area.
467 * data.c (Faset):
01103c44 468 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
469 (Fsubst_char_in_region):
470 * fns.c (concat):
471 * xdisp.c (decode_mode_spec_coding):
472 Adjust to CHAR_STRING's new requirement.
473 * editfns.c (Finsert_char, Fsubst_char_in_region):
474 * fns.c (concat): Check that character args are actually
475 characters. Without this test, these functions did the wrong
476 thing with wildly out-of-range values on 64-bit hosts.
477
d37ca623
PE
478 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
479 These casts should not be needed on 32-bit hosts, either.
480 * keyboard.c (read_char):
481 * lread.c (Fload): Remove casts to unsigned.
482
ea204efb
PE
483 * lisp.h (UNSIGNED_CMP): New macro.
484 This fixes comparison bugs on 64-bit hosts.
485 (ASCII_CHAR_P): Use it.
486 * casefiddle.c (casify_object):
01103c44 487 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
488 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
489 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
490 * dispextern.h (FACE_FROM_ID):
491 * keyboard.c (read_char): Use UNSIGNED_CMP.
492
41cb286c
PE
493 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
494 not to EMACS_INT, to avoid GCC warning.
495
4a1b9832
PE
496 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
497
55daad71
PE
498 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
499 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
500 isn't needed on 32-bit machines.
8f95c75c 501
01103c44
PE
502 * buffer.c (Fgenerate_new_buffer_name):
503 Use EMACS_INT for count, not int.
0ceccced 504 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
505
506 * data.c (Qcompiled_function): Now static.
507
c6f072e7
PE
508 * window.c (window_body_lines): Now static.
509
20ce5912
PE
510 * image.c (gif_load): Rename local to avoid shadowing.
511
9c4c5f81
PE
512 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
513 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
514 * alloc.c (make_save_value): Integer argument is now of type
515 ptrdiff_t, not int.
516 (mark_object): Use ptrdiff_t, not int.
517 * lisp.h (pD): New macro.
518 * print.c (print_object): Use it.
519
c0c5c8ae
PE
520 * alloc.c: Use EMACS_INT, not int, to count objects.
521 (total_conses, total_markers, total_symbols, total_vector_size)
522 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
523 (total_free_floats, total_floats, total_free_intervals)
524 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
525 Now EMACS_INT, not int. All uses changed.
526 (Fgarbage_collect): Compute overall total using a double, so that
527 integer overflow is less likely to be a problem. Check for overflow
528 when converting back to an integer.
5a25e253
PE
529 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
530 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
531 These were 'int' variables that could overflow on 64-bit hosts;
532 they were never used, so remove them instead of repairing them.
211a0b2a 533 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
534 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
535 Previously, this ceilinged at INT_MAX, but that doesn't work on
536 64-bit machines.
e46bb31a 537 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 538
c78baabf 539 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 540 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
541 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
542 when a (possibly-narrower) signed value would do just as well.
543 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 544
c9d624c6
PE
545 * alloc.c: Catch some string size overflows that we were missing.
546 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
547 for convenience in STRING_BYTES_MAX.
548 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
549 The definition here is exact; the one in lisp.h was approximate.
550 (allocate_string_data): Check for string overflow. This catches
551 some instances we weren't catching before. Also, it catches
552 size_t overflow on (unusual) hosts where SIZE_MAX <= min
553 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
554 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 555
c9d624c6
PE
556 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
557 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
558 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
559
353032ce
PE
560 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
561
2bccce07
PE
562 * alloc.c (Fmake_string): Check for out-of-range init.
563
0ac30604
SM
5642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
565
566 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
567
c195f2de
JD
5682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
569
570 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
571 xg_get_default_scrollbar_width.
572
573 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
574 (int_gtk_range_get_value): Move to the scroll bar part of the file.
575 (style_changed_cb): Call update_theme_scrollbar_width and call
576 x_set_scroll_bar_default_width and xg_frame_set_char_size for
577 all frames (Bug#8505).
578 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
579 Call gtk_window_set_resizable if HAVE_GTK3.
580 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
581 and height if HAVE_GTK3 (Bug#8505).
582 (scroll_bar_width_for_theme): New variable.
583 (update_theme_scrollbar_width): New function.
584 (xg_get_default_scrollbar_width): Move code to
585 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
586 (xg_initialize): Call update_theme_scrollbar_width.
587
588 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
589
590 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
591
e10ac9f1
MR
5922011-06-12 Martin Rudalics <rudalics@gmx.at>
593
594 * frame.c (make_frame): Call other_buffer_safely instead of
595 other_buffer.
596
597 * window.c (temp_output_buffer_show): Call display_buffer with
598 second argument Vtemp_buffer_show_specifiers and reset latter
599 immediately after the call.
600 (Vtemp_buffer_show_specifiers): New variable.
601 (auto_window_vscroll_p, next_screen_context_lines)
602 (Vscroll_preserve_screen_position): Remove leading asterisks from
603 doc-strings.
604
2d3c217e 6052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 606
7b7f97e8 607 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
608 * buffer.c (Qclone_number): Remove for now, as it's unused.
609 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
610 (record_buffer): Remove unused local.
611 * frame.c (other_visible_frames, frame_buffer_list): Now static.
612 (set_frame_buffer_list): Remove; unused.
613 * frame.h (other_visible_frames): Remove decl.
614 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
615 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
616 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
617 if HAVE_GPM.
618 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
619 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
620 Define only if HAVE_GPM.
621 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
622 (update_hints_inhibit): Remove; never set. All uses removed.
623 * widgetprv.h (emacsFrameClassRec): Remove decl.
624 * window.c (delete_deletable_window): Now returns void, since it
625 wasn't returning anything.
626 (compare_window_configurations): Remove unused locals.
627 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
628 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
629 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
630 the same widths as pointers. This follows up on the 2011-05-06 patch.
631 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
632 * xterm.h: Likewise.
633 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
634
1384b89e
JB
6352011-06-12 Juanma Barranquero <lekktu@gmail.com>
636
637 * makefile.w32-in: Update dependencies.
638 (LISP_H): Add lib/intprops.h.
639
1100a63c
CY
6402011-06-11 Chong Yidong <cyd@stupidchicken.com>
641
642 * image.c (gif_load): Add animation frame delay to the metadata.
643 (syms_of_image): Use DEFSYM. New symbol `delay'.
644
6198ccd0
MR
6452011-06-11 Martin Rudalics <rudalics@gmx.at>
646
647 * window.c (delete_deletable_window): Re-add.
648 (Fset_window_configuration): Rewrite to handle dead buffers and
649 consequently deletable windows.
650 (window_tree, Fwindow_tree): Remove. Supply functionality in
651 window.el.
652 (compare_window_configurations): Simplify code.
653
b6e3633c
AS
6542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
655
1ab0dee5
AS
656 * image.c (imagemagick_load_image): Fix type mismatch.
657 (Fimagemagick_types): Likewise.
658
b6e3633c
AS
659 * window.h (replace_buffer_in_windows): Declare.
660
9397e56f
MR
6612011-06-11 Martin Rudalics <rudalics@gmx.at>
662
663 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
664 Qclone_number. Remove external declaration of Qdelete_window.
665 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
666 code.
667 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
668 Qbuffer_list_update_hook if allowed.
669 (Fother_buffer): Rewrite doc-string. Major rewrite for new
670 buffer list implementation.
671 (other_buffer_safely): New function.
672 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
673 calls to replace_buffer_in_windows and
674 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
675 if allowed.
676 (record_buffer): Inhibit quitting and rewrite using quittable
677 functions. Run Qbuffer_list_update_hook if allowed.
678 (Frecord_buffer, Funrecord_buffer): New functions.
679 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
680 switch-to-buffer to window.el.
681 (bury-buffer): Move to window.el.
682 (Vbuffer_list_update_hook): New variable.
683
684 * lisp.h (other_buffer_safely): Add prototype in buffer.c
685 section.
686
687 * window.h (resize_frame_windows): Move up in code.
688 (Fwindow_frame): Remove EXFUN.
689 (replace_buffer_in_all_windows): Remove prototype.
690 (replace_buffer_in_windows_safely): Add prototype.
691
692 * window.c: Declare Qdelete_window static again. Move down
693 declaration of select_count.
694 (Fnext_window, Fprevious_window): Rewrite doc-strings.
695 (Fother_window): Move to window.el.
696 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
697 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
698 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
699 window.el.
700 (replace_buffer_in_windows): Implement by calling
701 Qreplace_buffer_in_windows.
702 (replace_buffer_in_all_windows): Remove with some functionality
703 moved into replace_buffer_in_windows_safely.
704 (replace_buffer_in_windows_safely): New function.
705 (select_window_norecord, select_frame_norecord): Move in front
706 of run_window_configuration_change_hook. Remove now obsolete
707 declarations.
708 (Fset_window_buffer): Rewrite doc-string. Call
709 Qrecord_window_buffer.
710 (keys_of_window): Move binding for other-window to window.el.
711
b50691aa
CY
7122011-06-11 Chong Yidong <cyd@stupidchicken.com>
713
714 * dispextern.h (struct image): Replace data member, whose int_val
715 and ptr_val fields were not used by anything, with a single
716 lisp_val object.
717
718 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
719 (gif_clear_image, gif_load, imagemagick_load_image)
720 (gs_clear_image, gs_load): Callers changed.
721
3f754b86
PE
7222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
723
cca69397
PE
724 * buffer.h: Include <time.h>, for time_t.
725 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
726
109e28d0
PE
727 Fix minor problems found by static checking.
728
60737f02
PE
729 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
730
4b66faf3
PE
731 Make identifiers static if they are not used in other modules.
732 * data.c (Qcompiled_function, Qframe, Qvector):
733 * image.c (QimageMagick, Qsvg):
734 * minibuf.c (Qmetadata):
735 * window.c (resize_window_check, resize_root_window): Now static.
736 * window.h (resize_window_check, resize_root_window): Remove decls.
737
109e28d0
PE
738 * window.c (window_deletion_count, delete_deletable_window):
739 Remove; unused.
46a4ce9e
PE
740 (window_body_lines): Now static.
741 (Fdelete_other_windows_internal): Mark vars as initialized.
742 Make sure 'resize_failed' is initialized.
743 (run_window_configuration_change_hook): Rename local to avoid shadowing.
744 (resize_window_apply): Remove unused local.
745 * window.h (delete_deletable_window): Remove decl.
746
109e28d0 747 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
748 (imagemagick_load_image): Fix pointer signedness problem by changing
749 last arg from unsigned char * to char *. All uses changed.
750 Also, fix a local for similar reasons.
751 Remove unused locals. Remove locals to avoid shadowing.
752 (fn_rsvg_handle_free): Remove; unused.
753 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 754 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 755
3f754b86
PE
756 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
757
2547adb1
CY
7582011-06-10 Chong Yidong <cyd@stupidchicken.com>
759
760 * image.c (gif_load): Fix omitted cast error introduced by
761 2011-06-06 change.
762
2c8e37d4
MR
7632011-06-10 Martin Rudalics <rudalics@gmx.at>
764
765 * window.h (resize_proportionally, orig_total_lines)
766 (orig_top_line): Remove from window structure.
767 (set_window_height, set_window_width, change_window_heights)
768 (Fdelete_window): Remove prototypes.
769 (resize_frame_windows): Remove duplicate declaration.
770
440a42e3
EZ
7712011-06-10 Eli Zaretskii <eliz@gnu.org>
772
773 * window.h (resize_frame_windows, resize_window_check)
774 (delete_deletable_window, resize_root_window)
775 (resize_frame_windows): Declare prototypes.
776
777 * window.c (resize_window_apply): Make definition be "static" to
778 match the prototype.
779
562dd5e9
MR
7802011-06-10 Martin Rudalics <rudalics@gmx.at>
781
782 * window.c: Remove declarations of Qwindow_size_fixed,
783 window_min_size_1, window_min_size_2, window_min_size,
784 size_window, window_fixed_size_p, enlarge_window, delete_window.
785 Remove static from declaration of Qdelete_window, it's
786 temporarily needed by Fbury_buffer.
787 (replace_window): Don't assign orig_top_line and
788 orig_total_lines.
789 (Fdelete_window, delete_window): Remove. Window deletion is
790 handled by window.el.
791 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
792 Fdelete_window calls with calls to Qdelete_window.
793 (Fdelete_other_windows): Remove. Deleting other windows is
794 handled by window.el.
795 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
796 handled in window.el.
797 (window_min_size_2, window_min_size_1, window_min_size): Remove.
798 Window minimum sizes are handled in window.el.
799 (shrink_windows, size_window, set_window_height)
800 (set_window_width, change_window_heights, window_height)
801 (window_width, CURBEG, CURSIZE, enlarge_window)
802 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
803 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
804 handled in window.el.
805 (make_dummy_parent): Rename to make_parent_window and give it a
806 second argument horflag.
807 (make_window): Don't set resize_proportionally any more.
808 (Fsplit_window): Remove. Windows are split in window.el.
809 (save_restore_action, save_restore_orig_size)
810 (shrink_window_lowest_first, save_restore_orig_size): Remove.
811 Resize mini windows in window.el.
812 (grow_mini_window, shrink_mini_window): Implement by calling
813 Qresize_root_window_vertically, resize_window_check and
814 resize_window_apply.
815 (saved_window, Fset_window_configuration, save_window_save): Do
816 not handle orig_top_line, orig_total_lines, and
817 resize_proportionally.
818 (window_min_height, window_min_width): Move to window.el.
819 (keys_of_window): Move bindings for delete-other-windows,
820 split-window, delete-window and enlarge-window to window.el.
821
822 * buffer.c: Temporarily extern Qdelete_window.
823 (Fbury_buffer): Temporarily call Qdelete_window instead of
824 Fdelete_window (Fbury_buffer will move to window.el soon).
825
826 * frame.c (set_menu_bar_lines_1): Remove code handling
827 orig_top_line and orig_total_lines.
828
829 * dispnew.c (adjust_frame_glyphs_initially): Don't use
830 set_window_height but set heights directly.
831 (change_frame_size_1): Use resize_frame_windows.
832
833 * xdisp.c (init_xdisp): Don't use set_window_height but set
834 heights directly.
835
836 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
837 resize_frame_windows instead of change_window_heights and run
838 run_window_configuration_change_hook.
839
840 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
841 instead of change_window_heights and run
842 run_window_configuration_change_hook.
843
1a13852e
MR
8442011-06-09 Martin Rudalics <rudalics@gmx.at>
845
846 * window.c (replace_window): Rename second argument REPLACEMENT to
847 NEW. New third argument SETFLAG. Rewrite.
848 (delete_window, make_dummy_parent): Call replace_window with
849 third argument 1.
850 (window_list_1): Move down in code.
851 (run_window_configuration_change_hook): Move set_buffer part
852 before select_frame_norecord part in order to unwind correctly.
853 Rename count1 to count.
854 (recombine_windows, delete_deletable_window, resize_root_window)
855 (Fdelete_other_windows_internal)
856 (Frun_window_configuration_change_hook, make_parent_window)
857 (resize_window_check, resize_window_apply, Fresize_window_apply)
858 (resize_frame_windows, Fsplit_window_internal)
859 (Fdelete_window_internal, Fresize_mini_window_internal): New
860 functions.
861 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
862
f3d1777e
MR
8632011-06-08 Martin Rudalics <rudalics@gmx.at>
864
496e208e
MR
865 * window.h (window): Add some new members to window structure -
866 normal_lines, normal_cols, new_total, new_normal, clone_number,
867 splits, nest, prev_buffers, next_buffers.
868 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 869 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 870
f3d1777e
MR
871 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
872 Remove.
496e208e
MR
873 (make_dummy_parent): Set new members of windows structure.
874 (make_window): Move down in code. Handle new members of window
875 structure.
876 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
877 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
878 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
879 (Fset_window_prev_buffers, Fwindow_next_buffers)
880 (Fset_window_next_buffers, Fset_window_clone_number): New
881 functions.
882 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
883 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
884 Doc-string fixes.
885 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
886 Argument WINDOW can be now internal window too.
887 (Fwindow_use_time): Move up in code.
888 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
889 Rewrite doc-string.
890 (Fset_window_configuration, saved_window)
891 (Fcurrent_window_configuration, save_window_save): Handle new
892 members of window structure.
b9e809c2
MR
893 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
894 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
895 (syms_of_window): New Lisp objects Qrecord_window_buffer,
896 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
897 Qget_mru_window, Qresize_root_window,
898 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
899 Qauto_buffer_name; staticpro them.
f3d1777e 900
abde8f8c
MR
9012011-06-07 Martin Rudalics <rudalics@gmx.at>
902
903 * window.c (Fwindow_total_size, Fwindow_left_column)
904 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
905 (Fwindow_list_1): New functions.
906 (window_box_text_cols): Replace with window_body_cols.
907 (Fwindow_width, Fscroll_left, Fscroll_right): Use
908 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
909 (delete_window, Fset_window_configuration): Call
910 delete_all_subwindows with window as argument.
911 (delete_all_subwindows): Take a window as argument and not a
912 structure. Rewrite.
190b47e6
MR
913 (window_loop): Remove handling of GET_LRU_WINDOW and
914 GET_LARGEST_WINDOW.
915 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
916
917 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
918 window_box_text_cols. delete_all_subwindows now takes a
919 Lisp_Object as argument.
abde8f8c
MR
920
921 * indent.c (compute_motion, Fcompute_motion): Use
922 window_body_cols instead of window_box_text_cols.
923
fa8a67e6
MR
924 * frame.c (delete_frame): Call delete_all_subwindows with root
925 window as argument.
926
a54e3482
DC
9272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
928
929 * fns.c (Fputhash): Document return value.
930
60002bf5
CY
9312011-06-06 Chong Yidong <cyd@stupidchicken.com>
932
933 * image.c (gif_load): Implement gif89a spec "no disposal" method.
934
0c671da6 9352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 936
b862a52a 937 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 938
be44ca6c
PE
939 Check for overflow when converting integer to cons and back.
940 * charset.c (Fdefine_charset_internal, Fdecode_char):
941 Use cons_to_unsigned to catch overflow.
942 (Fencode_char): Use INTEGER_TO_CONS.
943 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
944 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
945 * data.c (long_to_cons, cons_to_long): Remove.
946 (cons_to_unsigned, cons_to_signed): New functions.
947 These signal an error for invalid or out-of-range values.
948 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
949 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
950 * font.c (Ffont_variation_glyphs):
951 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
952 * lisp.h: Include <intprops.h>.
953 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
954 (cons_to_signed, cons_to_unsigned): New decls.
955 (long_to_cons, cons_to_long): Remove decls.
956 * undo.c (record_first_change): Use INTEGER_TO_CONS.
957 (Fprimitive_undo): Use CONS_TO_INTEGER.
958 * xfns.c (Fx_window_property): Likewise.
959 * xselect.c: Include <limits.h>.
960 (x_own_selection, selection_data_to_lisp_data):
961 Use INTEGER_TO_CONS.
962 (x_handle_selection_request, x_handle_selection_clear)
963 (x_get_foreign_selection, Fx_disown_selection_internal)
964 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
965 (lisp_data_to_selection_data): Use cons_to_unsigned.
966 (x_fill_property_data): Use cons_to_signed.
967 Report values out of range.
968
d1f3d2af
PE
969 Check for buffer and string overflow more precisely.
970 * buffer.h (BUF_BYTES_MAX): New macro.
971 * lisp.h (STRING_BYTES_MAX): New macro.
972 * alloc.c (Fmake_string):
973 * character.c (string_escape_byte8):
974 * coding.c (coding_alloc_by_realloc):
975 * doprnt.c (doprnt):
976 * editfns.c (Fformat):
977 * eval.c (verror):
978 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
979 since they may not be the same number.
980 * editfns.c (Finsert_char):
981 * fileio.c (Finsert_file_contents):
982 Likewise for BUF_BYTES_MAX.
983
dd52fcea
PE
984 * image.c: Use ptrdiff_t, not int, for sizes.
985 (slurp_file): Switch from int to ptrdiff_t.
986 All uses changed.
987 (slurp_file): Check that file size fits in both size_t (for
988 malloc) and ptrdiff_t (for sanity and safety).
989
7f9bbdbb
PE
990 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
991 if b->modtime has its maximal value.
992
dfe18f82
PE
993 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
994
84acfcf0
PE
995 Don't assume time_t can fit into int.
996 * buffer.h (struct buffer.modtime): Now time_t, not int.
997 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
998 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
999
ccd9a01a
PE
1000 Minor fixes for signed vs unsigned integers.
1001 * character.h (MAYBE_UNIFY_CHAR):
1002 * charset.c (maybe_unify_char):
1003 * keyboard.c (read_char, reorder_modifiers):
1004 XINT -> XFASTINT, since the integer must be nonnegative.
1005 * ftfont.c (ftfont_spec_pattern):
1006 * keymap.c (access_keymap, silly_event_symbol_error):
1007 XUINT -> XFASTINT, since the integer must be nonnegative.
1008 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1009 since it makes no difference and we prefer signed.
1010 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1011 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1012 nonnegative.
1013
d6d100dd
SM
10142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1015
1016 * window.h (Fwindow_frame): Declare.
1017
2b6148e4
PE
10182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1021 (SPARE_MEMORY): Always define.
1022 (LARGE_REQUEST): Remove.
1023 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1024
f230ecc9
MR
10252011-06-06 Martin Rudalics <rudalics@gmx.at>
1026
727e958e
MR
1027 * lisp.h: Move EXFUNS for Fframe_root_window,
1028 Fframe_first_window and Fset_frame_selected_window to window.h.
1029
1030 * window.h: Move EXFUNS for Fframe_root_window,
1031 Fframe_first_window and Fset_frame_selected_window here from
1032 lisp.h.
1033
1034 * frame.c (Fwindow_frame, Fframe_first_window)
1035 (Fframe_root_window, Fframe_selected_window)
1036 (Fset_frame_selected_window): Move to window.c.
1037 (Factive_minibuffer_window): Move to minibuf.c.
1038 (Fother_visible_frames_p): New function.
1039
1040 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1041
f230ecc9
MR
1042 * window.c (decode_window, decode_any_window): Move up in code.
1043 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1044 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1045 (Fwindow_buffer): Move up and rewrite doc-string.
1046 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1047 (Fwindow_prev): New functions.
727e958e
MR
1048 (Fwindow_frame): Move here from frame.c. Accept any window as
1049 argument.
1050 (Fframe_root_window, Fframe_first_window)
1051 (Fframe_selected_window): Move here from frame.c. Accept frame
1052 or arbitrary window as argument. Update doc-strings.
1053 (Fminibuffer_window): Move up in code.
1054 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1055 (Fset_frame_selected_window): Move here from frame.c.
1056 Marginal rewrite.
727e958e
MR
1057 (Fselected_window, select_window, Fselect_window): Move up in
1058 code. Minor doc-string fixes.
f230ecc9 1059
4d09bcf6
PE
10602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1063 Do not assume that spare memory exists; that assumption is valid
1064 only if SYSTEM_MALLOC.
1065 (LARGE_REQUEST): New macro, so that the issue of large requests
1066 is separated from the issue of spare memory.
1067
810928a2
AS
10682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1069
172418ad
AS
1070 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1071 format. (Bug#8806)
1072
43f862f7
AS
1073 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1074
810928a2
AS
1075 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1076 before statements.
1077
a059fe24
JD
10782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1079
1080 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1081
1082 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1083
1084 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1085 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1086
989bf368
JB
10872011-06-05 Juanma Barranquero <lekktu@gmail.com>
1088
1089 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1090
4b80f674
CY
10912011-06-04 Chong Yidong <cyd@stupidchicken.com>
1092
1093 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1094 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1095 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1096 New error handlers.
4b80f674
CY
1097 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1098 Obey Vx_select_enable_clipboard_manager. Catch errors in
1099 x_clipboard_manager_save (Bug#8779).
1100 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1101 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1102
99a33b77 11032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1104
1105 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1106
99a33b77 11072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1108
1109 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1110 in the current matrix if keep_current_p is non-zero.
1111
8264569d
EZ
11122011-06-04 Eli Zaretskii <eliz@gnu.org>
1113
1114 * bidi.c (bidi_level_of_next_char): Fix last change.
1115
57f97249
EZ
11162011-06-03 Eli Zaretskii <eliz@gnu.org>
1117
fec2107c 1118 Support bidi reordering of text covered by display properties.
57f97249 1119
fec2107c
EZ
1120 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1121 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1122 (bidi_cache_search, bidi_cache_iterator_state)
1123 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1124 (bidi_level_of_next_char, bidi_move_to_visually_next):
1125 Support character positions inside a run of characters covered by a
fec2107c
EZ
1126 display string.
1127 (bidi_paragraph_init, bidi_resolve_explicit_1)
1128 (bidi_level_of_next_char): Call bidi_fetch_char and
1129 bidi_fetch_char_advance instead of FETCH_CHAR and
1130 FETCH_CHAR_ADVANCE.
1131 (bidi_init_it): Initialize new members.
1132 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1133 definitions.
1134 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1135 instead of using explicit *_CHAR codes.
d6d100dd
SM
1136 (bidi_resolve_explicit, bidi_resolve_weak):
1137 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1138 bidirectional text is supported only in multibyte buffers.
1139 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1140 it to initialize the frame_window_p member of struct bidi_it.
1141 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1142 (bidi_resolve_explicit, bidi_resolve_weak)
1143 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1144 bidi_it->nchars is non-positive.
1145 (bidi_level_of_next_char): Don't try to lookup the cache for the
1146 next/previous character if nothing is cached there yet, or if we
1147 were just reseat()'ed to a new position.
c40e2fb2 1148
0e14fe90
EZ
1149 * xdisp.c (set_cursor_from_row): Set start and stop points
1150 according to the row's direction when priming the loop that looks
1151 for the glyph on which to display cursor.
1152 (single_display_spec_intangible_p): Function deleted.
1153 (display_prop_intangible_p): Reimplement to call
1154 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1155 Accept 3 additional arguments needed by handle_display_spec.
1156 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1157 values: lists, `(when COND...)' forms, etc.
1158 (single_display_spec_string_p): Support property values that are
1159 lists with the argument STRING its top-level element.
1160 (display_prop_string_p): Fix the condition for processing a
1161 property that is a list to be consistent with handle_display_spec.
fec2107c 1162 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1163 last portion of handle_display_prop.
1164 (compute_display_string_pos): Accept additional argument
1165 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1166 value of a `display' property is a "replacing spec".
1167 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1168 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1169 the display property, but just return a value indicating whether
1170 the display property will replace the characters it covers.
1171 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1172 frame_window_p members of struct bidi_it.
d6d100dd
SM
1173 (compute_display_string_pos, compute_display_string_end):
1174 New functions.
fec2107c
EZ
1175 (push_it): Accept second argument POSITION, where pop_it should
1176 jump to continue iteration.
1177 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1178
fec2107c
EZ
1179 * keyboard.c (adjust_point_for_property): Adjust the call to
1180 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1181
1182 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1183 (bidi_init_it): Update prototypes.
1184 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1185 (compute_display_string_pos, compute_display_string_end):
1186 Declare prototypes.
fec2107c
EZ
1187 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1188 EMACS_INT.
fc6f18ce 1189
40087514 11902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1191
57f53182
PE
1192 Malloc failure behavior now depends on size of allocation.
1193 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1194 * lisp.h: Change signatures accordingly.
1195 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1196 All callers changed. (Bug#8762)
1197
1198 * gnutls.c: Use Emacs's memory allocators.
1199 Without this change, the gnutls library would invoke malloc etc.
1200 directly, which causes problems on non-SYNC_INPUT hosts, and which
1201 runs afoul of improving memory_full behavior. (Bug#8761)
1202 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1203 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1204 xfree instead of the default malloc, realloc, free.
1205 (Fgnutls_boot): No need to check for memory allocation failure,
1206 since xmalloc does that for us.
1207
ac32cd99 1208 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1209 * category.c (hash_get_category_set):
1210 * ccl.c (ccl_driver):
1211 * charset.c (Fdefine_charset_internal):
1212 * charset.h (struct charset.hash_index):
1213 * composite.c (get_composition_id, gstring_lookup_cache)
1214 (composition_gstring_put_cache):
1215 * composite.h (struct composition.hash_index):
1216 * dispextern.h (struct image.hash):
1217 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1218 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1219 (hashfn_equal, hashfn_user_defined, make_hash_table)
1220 (maybe_resize_hash_table, hash_lookup, hash_put)
1221 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1222 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1223 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1224 * image.c (make_image, search_image_cache, lookup_image)
1225 (xpm_put_color_table_h):
1226 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1227 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1228 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1229 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1230 * alloc.c (allocate_vectorlike):
1231 Check for overflow in vector size calculations.
1232 * ccl.c (ccl_driver):
1233 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1234 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1235 need to be updated by these changes.
40087514
PE
1236 * fns.c (make_hash_table, maybe_resize_hash_table):
1237 Check for integer overflow with large hash tables.
0de4bb68
PE
1238 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1239 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1240 (SXHASH_REDUCE): New macro.
1241 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1242 Use it instead of discarding useful hash info with large hash values.
1243 (sxhash_float): New function.
1244 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1245 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1246 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1247 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1248 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1249 Adjust signatures to match updated version of code.
1250 (consing_since_gc): Now EMACS_INT, since a single hash table can
1251 use more than INT_MAX bytes.
1252
698d32e2
DN
12532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1254
1255 Make it possible to build with GCC-4.6+ -O2 -flto.
1256
1257 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1258
fd6fa53f
SM
12592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1260
1261 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1262 Call minibuffer-inactive-mode.
1263
864db017
JB
12642011-05-31 Juanma Barranquero <lekktu@gmail.com>
1265
1266 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1267 Update dependencies.
1268
2ad0baf4
DN
12692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1270
1271 * data.c (init_data): Remove code for UTS, this system is not
1272 supported anymore.
1273
4fcc2638
DN
12742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1275
1276 Don't force ./temacs to start in terminal mode.
1277
1278 * frame.c (make_initial_frame): Initialize faces in all cases, not
1279 only when CANNOT_DUMP is defined.
1280 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1281
c56e0fd5
DN
12822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1283
1284 * dispnew.c (add_window_display_history): Use const for the string
1285 pointer. Remove declaration, not needed.
1286
333d54da 12872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1288
55d4c1b2 1289 Use 'inline', not 'INLINE'.
333d54da 1290 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1291 * alloc.c, fontset.c (INLINE): Remove.
1292 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1293 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1294 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1295 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1296 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1297
738db178
DN
12982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1299
1300 Make it possible to run ./temacs.
1301
1302 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1303 syms_of_callproc does the same thing. Remove test for
1304 "initialized", do it in the caller.
1305 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1306
620c53a6
SM
13072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1308
1309 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1310 (read_minibuf): Use get_minibuffer.
1311 (syms_of_minibuf): Use DEFSYM.
1312 (Qmetadata): New var.
1313 * data.c (Qbuffer): Don't make it static.
1314 (syms_of_data): Use DEFSYM.
1315
e003a292
PE
13162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1319 (CCL_CODE_MIN): New macro.
1320
ed008a6d
PE
13212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1322
3687c2ef
PE
1323 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1324
ed008a6d
PE
1325 * eval.c (Qdebug): Now static.
1326 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1327 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1328 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1329
d66c4c7c
CY
13302011-05-29 Chong Yidong <cyd@stupidchicken.com>
1331
1332 * image.c: Various fixes to ImageMagick code comments.
1333 (Fimagemagick_types): Doc fix.
1334
5fbc2025
PE
13352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1336
0196f88a
PE
1337 Minor fixes prompted by GCC 4.6.0 warnings.
1338
1339 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1340
5fbc2025
PE
1341 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1342 (x_clipboard_manager_save_all): Move extern decl to ...
1343 * xterm.h: ... here, so that it can be checked for consistency.
1344
1dd3c2d9
CY
13452011-05-29 Chong Yidong <cyd@stupidchicken.com>
1346
1347 * xselect.c (x_clipboard_manager_save_frame)
1348 (x_clipboard_manager_save_all): New functions.
1349 (Fx_clipboard_manager_save): Lisp function deleted.
1350
1351 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1352 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1353
1354 * xterm.h: Update prototype.
1355
5ba6571d
WX
13562011-05-28 William Xu <william.xwl@gmail.com>
1357
1358 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1359 exiting (Bug#8239).
1360
3eaff834
JM
13612011-05-28 Jim Meyering <meyering@redhat.com>
1362
e1900994 1363 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1364 * fns.c (to_uchar): Define.
1365 (crypto_hash_function): Use it to convert some newly-signed
1366 variables to unsigned, to avoid sign-extension bugs. For example,
1367 without this change, (md5 "truc") would evaluate to
1368 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1369 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1370 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1371
0f6990a7
PE
13722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1373
1374 Integer overflow fixes.
c8a9ca5a 1375
08686060
PE
1376 * dbusbind.c: Serial number integer overflow fixes.
1377 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1378 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1379 to hold a serial number that is too large for a fixnum.
1380 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1381 Check for serial numbers out of range. Decode any serial number
59568bf0 1382 that was so large that it became a float. (Bug#8722)
08686060 1383
2d1fc3c7
PE
1384 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1385 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1386 Use XFASTINT rather than XUINT when numbers are nonnegative.
1387 (xd_append_arg, Fdbus_method_return_internal):
1388 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1389 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1390 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1391 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1392 (Bug#8722)
2d1fc3c7 1393
c8a9ca5a
PE
1394 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1395
519e1d69
PE
1396 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1397
30569699
PE
1398 ccl: add integer overflow checks
1399 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1400 (IN_INT_RANGE): New macros.
1401 (ccl_driver): Use them to check for integer overflow when
1402 decoding a CCL program. Many of the new checks are whether XINT (x)
1403 fits in int; it doesn't always, on 64-bit hosts. The new version
1404 doesn't catch all possible integer overflows, but it's an
847044ea 1405 improvement. (Bug#8719)
30569699 1406
c11285dc
PE
1407 * alloc.c (make_event_array): Use XINT, not XUINT.
1408 There's no need for unsigned here.
1409
fdccd48e
PE
1410 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1411 This follows up to the 2011-05-06 change that substituted uintptr_t
1412 for EMACS_INT. This case wasn't caught back then.
1413
37910ab2
PE
1414 Rework Fformat to avoid integer overflow issues.
1415 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1416 now (part of C89). Include <verify.h>.
1417 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1418 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1419 (Fformat): Avoid the prepass trying to compute sizes; it was only
1420 approximate and thus did not catch overflow reliably. Instead, walk
1421 through the format just once, formatting and computing sizes as we go,
1422 checking for integer overflow at every step, and allocating a larger
1423 buffer as needed. Keep track separately whether the format is
1424 multibyte. Keep only the most-recently calculated precision, rather
1425 than them all. Record whether each argument has been converted to
1426 string. Use EMACS_INT, not int, for byte and char and arg counts.
1427 Support field widths and precisions larger than INT_MAX. Avoid
1428 sprintf's undefined behavior with conversion specifications such as %#d
1429 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1430 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1431 formatting out-of-range floating point numbers with int
1432 formats. (Bug#8668)
1433
2e6578fb
PE
1434 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1435
0ae6bdee
PE
1436 * data.c: Avoid integer truncation in expressions involving floats.
1437 * data.c: Include <intprops.h>.
1438 (arith_driver): When there's an integer overflow in an expression
1439 involving floating point, convert the integers to floating point
1440 so that the resulting value does not suffer from catastrophic
1441 integer truncation. For example, on a 64-bit host (* 4
1442 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1443 Do not rely on undefined behavior after integer overflow.
1444
de883a70
PE
1445 merge count_size_as_multibyte, parse_str_to_multibyte
1446 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1447 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1448 Check for integer overflow.
1449 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1450 since it's now a duplicate of the other. This is more of
1451 a character than a buffer op, so better that it's in character.c.
1452 * fns.c, print.c: Adjust to above changes.
1453
2ff916cb
PE
14542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1455
1456 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1457
f1b54466
PE
14582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1459
fb1ac845
PE
1460 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1461 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1462 (x_clipboard_manager_save): Now static.
1463 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1464
f1b54466
PE
1465 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1466 (crypto_hash_function): Now static.
1467 Fix pointer signedness problems. Avoid unnecessary initializations.
1468
a9f737ee
CY
14692011-05-27 Chong Yidong <cyd@stupidchicken.com>
1470
1471 * termhooks.h (Vselection_alist): Make it terminal-local.
1472
1473 * terminal.c (create_terminal): Initialize it.
1474
1475 * xselect.c: Support for clipboard managers.
1476 (Vselection_alist): Move to termhooks.h as terminal-local var.
1477 (LOCAL_SELECTION): New macro.
1478 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1479 (symbol_to_x_atom): Remove gratuitous arg.
1480 (x_handle_selection_request, lisp_data_to_selection_data)
1481 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1482 (x_own_selection, x_get_local_selection, x_convert_selection):
1483 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1484 (some_frame_on_display): Delete unused function.
1485 (Fx_own_selection_internal, Fx_get_selection_internal)
1486 (Fx_disown_selection_internal, Fx_selection_owner_p)
1487 (Fx_selection_exists_p): New optional frame arg.
1488 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1489 (x_handle_selection_clear): Don't treat other terminals with the
1490 same keyboard specially. Use the terminal-local Vselection_alist.
1491 (x_clear_frame_selections): Use Frun_hook_with_args.
1492
1493 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1494
1495 * xterm.h: Add support for those atoms.
1496
e067f0c1
CY
14972011-05-26 Chong Yidong <cyd@stupidchicken.com>
1498
1499 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1500 (converted_selections, conversion_fail_tag): New global variables.
1501 (x_selection_request_lisp_error): Free the above.
1502 (x_get_local_selection): Remove unnecessary code.
1503 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1504 of converted selections stored in converted_selections.
1505 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1506 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1507 (x_convert_selection): New function.
1508 (x_handle_selection_event): Simplify.
1509 (x_get_foreign_selection): Don't ignore incoming requests while
1510 waiting for an answer; this will fail when we implement
1511 SAVE_TARGETS, and seems unnecessary anyway.
1512 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1513 (Vx_sent_selection_functions): Doc fix.
1514
0f4aebc0
LL
15152011-05-26 Leo Liu <sdl.web@gmail.com>
1516
1517 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1518
e61124cd
YM
15192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1520
1521 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1522
1523 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1524 for fringe update if it has periodic bitmap.
1525 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1526 and fringe_bitmap_periodic_p.
1527
1528 * fringe.c (get_fringe_bitmap_data): New function.
1529 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1530 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1531 row. Mark glyph row for fringe update if periodicity changed.
1532
1533 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1534 for fringe update unless it has periodic bitmap.
1535
f16d9837
KH
15362011-05-25 Kenichi Handa <handa@m17n.org>
1537
1538 * xdisp.c (get_next_display_element): Set correct it->face_id for
1539 a static composition.
1540
e1b90ef6
LL
15412011-05-24 Leo Liu <sdl.web@gmail.com>
1542
1543 * deps.mk (fns.o):
1544 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1545
1546 * fns.c (crypto_hash_function, Fsha1): New function.
1547 (Fmd5): Use crypto_hash_function.
1548 (syms_of_fns): Add Ssha1.
1549
7400048f
PE
15502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1551
1552 * gnutls.c: Remove unused macros.
1553 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1554 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1555 Remove macros that are defined and never used.
1556 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1557
abb71cf4
CY
15582011-05-22 Chong Yidong <cyd@stupidchicken.com>
1559
1560 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1561 (Fx_get_selection_internal): Minor cleanup.
1562 (Fx_own_selection_internal): Rename arguments for consistency with
1563 select.el.
1564
6307db39
PE
15652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1566
1567 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1568
f3d4e0a4
CY
15692011-05-22 Chong Yidong <cyd@stupidchicken.com>
1570
1571 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1572
4d8ade89
YM
15732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1574
1575 * dispnew.c (scrolling_window): Don't exclude the case that the
1576 last enabled row in the desired matrix touches the bottom boundary.
1577
32078c8d
GM
15782011-05-21 Glenn Morris <rgm@gnu.org>
1579
1580 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1581 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1582 and add some more files.
32078c8d 1583
7285dc67
EZ
15842011-05-20 Eli Zaretskii <eliz@gnu.org>
1585
1586 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1587 report_file_error introduced by the change from 2011-05-07.
1588
89d1bd22
PE
15892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 * systime.h (Time): Define only if emacs is defined.
1592 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1593 where the include path doesn't have X11/X.h by default. See
1594 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1595
e23640bb 15962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1597
1598 * composite.c (find_automatic_composition): Fix previous change.
1599
b9704ad9
GM
16002011-05-20 Glenn Morris <rgm@gnu.org>
1601
1602 * lisp.mk: New file, split from Makefile.in.
1603 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1604 (shortlisp): Remove.
1605 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1606
4a720484
GM
16072011-05-19 Glenn Morris <rgm@gnu.org>
1608
1609 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1610 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1611 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1612 (lisp): Set the order to that of loadup.el.
1613 (shortlisp): Make it a copy of $lisp.
1614 (SOME_MACHINE_LISP): Remove.
1615 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1616 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1617
a28d4396
KH
16182011-05-18 Kenichi Handa <handa@m17n.org>
1619
1620 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1621 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1622 (find_automatic_composition): Mostly rewrite for efficiency.
1623
a2b1fa8e
JB
16242011-05-18 Juanma Barranquero <lekktu@gmail.com>
1625
1626 * makefile.w32-in: Update dependencies.
1627
8e1f5610
CS
16282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1629
1630 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1631 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1632
7025ee00 16332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1634
cdfa6eab
PE
1635 Fix some integer overflow issues, such as string length overflow.
1636
06d6db33
PE
1637 * insdel.c (count_size_as_multibyte): Check for string overflow.
1638
2b4560a8
PE
1639 * character.c (lisp_string_width): Check for string overflow.
1640 Use EMACS_INT, not int, for string indexes and lengths; in
1641 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1642 the resulting string length overflows an EMACS_INT; instead,
1643 report a string overflow if no precision given. When checking for
1644 precision exhaustion, use a check that cannot possibly have
1645 integer overflow. (Bug#8675)
1646 * character.h (lisp_string_width): Adjust to new signature.
1647
cb93f9be
PE
1648 * alloc.c (string_overflow): New function.
1649 (Fmake_string): Use it. This doesn't change behavior, but saves
1650 a few bytes and will simplify future changes.
1651 * character.c (string_escape_byte8): Likewise.
1652 * lisp.h (string_overflow): New decl.
1653
1a1f3366
PE
1654 Fixups, following up to the user-interface timestamp change.
1655 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1656 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1657 * msdos.c (mouse_get_pos): Likewise.
1658 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1659 * w32gui.h (Time): Define by including "systime.h" rather than by
1660 declaring it ourselves. (Bug#8664)
1661
d4e3e4d3
PE
1662 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1663 * image.c (clear_image_cache): Likewise.
1664
f6a24d19
PE
1665 * term.c (term_mouse_position): Don't assume time_t wraparound.
1666
08dc5ae6
PE
1667 Be more systematic about user-interface timestamps.
1668 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1669 and sometimes 'EMACS_UINT', to represent these timestamps.
1670 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1671 This makes the code easier to follow, and makes it easier to catch
1672 integer overflow bugs such as Bug#8664.
1673 * frame.c (Fmouse_position, Fmouse_pixel_position):
1674 Use Time, not unsigned long, for user-interface timestamps.
1675 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1676 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1677 * keyboard.h (last_event_timestamp): Likewise.
1678 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1679 * menu.h (xmenu_show): Likewise.
1680 * term.c (term_mouse_position): Likewise.
1681 * termhooks.h (struct input_event.timestamp): Likewise.
1682 (struct terminal.mouse_position_hook): Likewise.
1683 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1684 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1685 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1686 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1687 what it was before.
1688 * menu.h, termhooks.h: Include "systime.h", for Time.
1689
8e55734a
PE
1690 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1691 Don't assume that the difference between two unsigned long values
1692 can fit into an integer. At this point, we know button_down_time
1693 <= event->timestamp, so the difference must be nonnegative, so
1694 there's no need to cast the result if double-click-time is
1695 nonnegative, as it should be; check that it's nonnegative, just in
1696 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1697 apart (about 25 days). (Bug#8664)
8e55734a 1698
841f1b75 1699 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1700 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1701
3e26f69c
PE
1702 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1703 that always fit in int. Use a sentinel instead of a counter, to
1704 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1705 * frame.h (struct frame): Use int for menu_bar_items_used
1706 instead of EMACS_INT, since it always fits in int.
3e26f69c 1707
5cc152c0
PE
1708 * menu.c (grow_menu_items): Check for int overflow.
1709
d89eb65e
PE
1710 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1711
5235bd3e
PE
1712 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1713 Before, the code was not consistent. These values cannot exceed
1714 2**31 - 1 so there's no need to make them unsigned.
1715 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1716 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1717 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1718 as modifiers.
1719 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1720
bc827e23
PE
1721 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1722 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1723 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1724 presumably because the widths might not match.
1725
78eb494e
PE
1726 * window.c (size_window): Avoid needless test at loop start.
1727
04f2d78b
CB
17282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1729
1730 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1731
d2fc7e3d 17322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1733
1734 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1735
d2fc7e3d 17362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1737
1738 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1739 `width' to `bar_area_x' and `bar_area_width', respectively.
1740 (x_scroll_run): Take account of fringe background extension.
1741
04f2d78b
CB
1742 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1743 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1744 `bar_area_width', respectively.
1745 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1746 background extension.
1747
79b70037
GM
17482011-05-10 Jim Meyering <meyering@redhat.com>
1749
1750 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1751
2f142cc5
JB
17522011-05-10 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * image.c (Finit_image_library): Return t for built-in image types,
1755 like pbm and xbm. (Bug#8640)
1756
57679c86
AS
17572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1758
1759 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1760
888c9e86
EZ
17612011-05-07 Eli Zaretskii <eliz@gnu.org>
1762
b0512a1d
EZ
1763 * w32console.c (Fset_screen_color): Doc fix.
1764 (Fget_screen_color): New function.
1765 (syms_of_ntterm): Defsubr it.
1766
7285dc67
EZ
1767 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1768 unlink the temporary file if Fcall_process didn't create it in the
1769 first place.
1770 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1771 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1772 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1773 cue to call_process_cleanup not to close that handle.
1774
4d3fcc8e
BK
17752011-05-07 Ben Key <bkey76@gmail.com>
1776
1777 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1778 one of two shell specific rules, either bootstrap-temacs-CMD or
1779 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1780 to the previous implementation of the bootstrap-temacs rule.
1781 The bootstrap-temacs-CMD rule is similar to the previous
1782 implementation of the bootstrap-temacs rule except that it
1783 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1784 variable.
1785
1786 These changes, along with some changes to nt/configure.bat,
1787 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1788 earlier fix to add support for --cflags and --ldflags options
1789 that include quotes so that it works whether make uses cmd or
1790 sh as the shell.
1791
b4289b64
MA
17922011-05-06 Michael Albinus <michael.albinus@gmx.de>
1793
1794 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1795 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1796 is a constant.
1797 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1798 a string. Handle both cases.
1799 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1800 (Fdbus_register_method): Use Qinvalid_function.
1801
af4c0e28
JB
18022011-05-06 Juanma Barranquero <lekktu@gmail.com>
1803
1804 * makefile.w32-in: Update dependencies.
1805 (LISP_H): Add inttypes.h and stdin.h.
1806 (PROCESS_H): Add unistd.h.
1807
c51453d9
EZ
18082011-05-06 Eli Zaretskii <eliz@gnu.org>
1809
1810 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1811 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1812
8ff0ac3c 18132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1814
4c4b566b
PE
1815 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1816
aab2b9b5
PE
1817 * term.c (vfatal): Remove stray call to va_end.
1818 It's not needed and the C Standard doesn't allow it here anyway.
1819
c378da0b
PE
1820 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1821 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1822
288b08c7
PE
1823 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1824 bytes.
1825
e3601888
PE
1826 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1827
db6c0e74
PE
1828 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1829
dd5963ea
PE
1830 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1831
88c9450f
PE
1832 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1833
2f9442b8
PE
1834 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1835
c032b5f8
PE
1836 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1837 * charset.c (Fdefine_charset_internal): Don't initialize
1838 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1839 32-bit int (Bug#8600).
a108c10b
PE
1840
1841 * lread.c (read_integer): Be more consistent with string-to-number.
1842 Use string_to_number to do the actual conversion; this avoids
1843 rounding errors and fixes some other screwups. Without this fix,
1844 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1845 (digit_to_number): Move earlier, for benefit of read_integer.
1846 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1847 not a digit in any supported base. (Bug#8602)
a108c10b 1848
ad5f9eea
PE
1849 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1850
aec1708a
PE
1851 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1852 to match comment at start of function. This also removes a
1853 GCC warning about overflow in a 32+64-bit port.
1854
47be4ab5
PE
1855 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1856
371cac43
PE
1857 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1858 Reported by Stefan Monnier in
1859 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1860 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1861 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1862
d01a7826
PE
1863 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1864 (EMACS_UINTPTR): Likewise, with uintptr_t.
1865
7fd47d5c
PE
1866 * lisp.h: Prefer 64-bit EMACS_INT if available.
1867 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1868 on 32-bit hosts that have 64-bit int, so that they can access
1869 large files.
122b0c86
PE
1870 However, temporarily disable this change unless the temporary
1871 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1872
8727937b
PE
1873 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1874
8ac068ac
PE
1875 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1876 This removes an assumption that EMACS_INT and long are the same
1877 width as pointers. The assumption is true for Emacs porting targets
1878 now, but we want to make other targets possible.
1879 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1880 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1881 In the rest of the code, change types of integers that hold casted
1882 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1883 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1884 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1885 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1886 No need to cast type when ORing.
1887 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1888 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1889 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1890 assume EMACS_INT is the same width as char *.
1891 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1892 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1893 Remove no-longer-needed casts.
1894 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1895 (xg_tool_bar_help_callback, xg_make_tool_item):
1896 Use EMACS_INTPTR to hold an integer
1897 that will be cast to void *; this can avoid a GCC warning
1898 if EMACS_INT is not the same width as void *.
1899 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1900 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1901 (current_message_1, set_message_1):
1902 Use a local to convert to proper width without a cast.
1903 * xmenu.c (dialog_selection_callback): Likewise.
1904
ede49d71
PE
1905 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1906 Also, don't assume VALBITS / RAND_BITS is less than 5,
1907 and don't rely on undefined behavior when shifting a 1 left into
1908 the sign bit.
1909 * lisp.h (get_random): Change signature to match.
1910
2f30ecd0
PE
1911 * lread.c (hash_string): Use size_t, not int, for hash computation.
1912 Normally we prefer signed values; but hashing is special, because
1913 it's better to use unsigned division on hash table sizes so that
1914 the remainder is nonnegative. Also, size_t is the natural width
1915 for hashing into memory. The previous code used 'int', which doesn't
1916 retain enough info to hash well into very large tables.
1917 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1918
2a866e7b
PE
1919 * dbusbind.c: Don't possibly lose pointer info when converting.
1920 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1921 Use XPNTR rather than XHASH, so that the high-order bits of
1922 the pointer aren't lost when converting through void *.
1923
51639eac
PE
1924 * eval.c (Fautoload): Don't double-shift a pointer.
1925
92394119
PE
1926 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1927
dbdb9a7c
JB
19282011-05-06 Juanma Barranquero <lekktu@gmail.com>
1929
1930 * gnutls.c (DEF_GNUTLS_FN):
1931 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1932
db7a0b4f
AS
19332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1934
1935 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1936 marker. (Bug#8610)
1937
f7ff1b0f 19382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1939
1940 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1941 New version that can reserve upto 2GB of heap space.
1942
f7ff1b0f 19432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1944
1945 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1946
639c109b
TZ
19472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1948
1949 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1950 `gnutls_certificate_set_x509_key_file'.
1951
d2127135
JB
19522011-05-05 Juanma Barranquero <lekktu@gmail.com>
1953
1954 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1955 Update dependencies.
1956
e968f4f3
JB
19572011-05-04 Juanma Barranquero <lekktu@gmail.com>
1958
1959 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1960 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1961 Remove unused parameter `fildes'.
1962 * process.c (read_process_output, send_process): Don't pass it.
1963
84d358f0
JB
19642011-05-04 Juanma Barranquero <lekktu@gmail.com>
1965
1966 Fix previous change: the library cache is defined in w32.c.
1967 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1968 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1969
0898ca10
JB
19702011-05-04 Juanma Barranquero <lekktu@gmail.com>
1971
1972 Implement dynamic loading of GnuTLS on Windows.
1973
1974 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1975 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1976 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1977 Declare.
1978
1979 * gnutls.c (Qgnutls_dll): Define.
1980 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1981 (gnutls_*): Declare function pointers.
1982 (init_gnutls_functions): New function to initialize function pointers.
1983 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1984 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1985 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1986 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1987 (emacs_gnutls_write, emacs_gnutls_read)
1988 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1989 (Fgnutls_available_p): New function.
1990 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1991 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1992 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1993
1994 * image.c: Include w32.h.
1995 (Vimage_type_cache): Delete.
1996 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1997 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1998 (w32_delayed_load): Move to w32.c.
1999
2000 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2001
2002 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2003 (w32_delayed_load): Move from image.c. When loading a library, record
2004 its filename in the :loaded-from property of the library id.
2005 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2006 Initialize and staticpro them.
2007 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2008
2009 * process.c: Include lisp.h before w32.h, not after.
2010 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2011 instead of gnutls_record_check_pending.
2012
2013 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2014
ff4de4aa
TZ
20152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2016
2017 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2018 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2019 as passed in.
2020
abe95abb
JD
20212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2022
2023 * xterm.c (x_set_frame_alpha): Do not set property on anything
2024 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2025
e16e55d4
JB
20262011-05-02 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2029
bafcf6a5
JB
20302011-05-02 Juanma Barranquero <lekktu@gmail.com>
2031
2032 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2033 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2034 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2035 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2036 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2037 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2038 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2039 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2040 (Qgnutls_bootprop_callbacks_verify): Make static.
2041
e7a6747f
AS
20422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2043
19ed11ba
AS
2044 * callproc.c: Indentation fixup.
2045
e7a6747f 2046 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2047 (wait_for_termination, interruptible_wait_for_termination):
2048 Move after wait_for_termination_1.
e7a6747f 2049
1ef14cb4
LMI
20502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2051
2052 * sysdep.c (interruptible_wait_for_termination): New function
2053 which is like wait_for_termination, but allows keyboard
2054 interruptions.
2055
2056 * callproc.c (Fcall_process): Add (:file "file") as an option for
2057 the STDOUT buffer.
2058 (Fcall_process_region): Ditto.
2059
330d880c
EZ
20602011-04-30 Eli Zaretskii <eliz@gnu.org>
2061
8db90b73
EZ
2062 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2063 rather than `XVECTOR (FOO)->size'.
2064
330d880c
EZ
2065 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2066 inttypes.h, as a gnulib replacement is used if it not available in
2067 system headers.
2068
15cbd324
EZ
20692011-04-21 Eli Zaretskii <eliz@gnu.org>
2070
2071 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2072 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2073 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2074
2075 * coding.c (coding_alloc_by_realloc): Error out if destination
2076 will grow beyond MOST_POSITIVE_FIXNUM.
2077 (decode_coding_emacs_mule): Abort if there isn't enough place in
2078 charbuf for the composition carryover bytes. Reserve an extra
2079 space for up to 2 characters produced in a loop.
2080 (decode_coding_iso_2022): Abort if there isn't enough place in
2081 charbuf for the composition carryover bytes.
2082
20832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2084
ae940cca
EZ
2085 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2086 aborting when %lld or %lll format is passed.
2087 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2088 %llo or %llx format is passed. (Bug#8545)
2089
03ab8921
EZ
2090 * window.c (window_scroll_line_based): Use a marker instead of
2091 simple variables to record original value of point. (Bug#7952)
2092
afda1437
EZ
2093 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2094 produced by %s or %c overflows available buffer space. (Bug#8545)
2095
f76dee0c
PE
20962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2099 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2100
fdc5744d
JB
21012011-04-28 Juanma Barranquero <lekktu@gmail.com>
2102
2103 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2104
638f053a
JB
21052011-04-28 Juanma Barranquero <lekktu@gmail.com>
2106
2107 * keyboard.c (Qdelayed_warnings_hook): Define.
2108 (command_loop_1): Run `delayed-warnings-hook'
2109 if Vdelayed_warnings_list is non-nil.
2110 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2111 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2112
d178f871
EZ
21132011-04-28 Eli Zaretskii <eliz@gnu.org>
2114
2115 * doprnt.c (doprnt): Don't return value smaller than the buffer
2116 size if the message was truncated. (Bug#8545).
2117
b124fd93
JB
21182011-04-28 Juanma Barranquero <lekktu@gmail.com>
2119
2120 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2121 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2122
e810457d
PE
21232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2126
ea51cceb
JB
21272011-04-27 Juanma Barranquero <lekktu@gmail.com>
2128
2129 * makefile.w32-in: Update dependencies.
2130
94dcfacf
EZ
21312011-04-27 Eli Zaretskii <eliz@gnu.org>
2132
2133 Improve `doprnt' and its usage. (Bug#8545)
2134 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2135 `format_end'. Remove support for %l as a conversion specifier.
2136 Don't use xrealloc. Improve diagnostics when the %l size modifier
2137 is used. Update the commentary.
2138
2139 * eval.c (verror): Simplify calculation of size_t.
2140
2141 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2142 messages.
2143
f61f41d7
PE
21442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2145
2146 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2147 change.
2148
96fb4434
PE
21492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2150
2151 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2152 This makes this file independent of the recent pseudovector change.
2153
671875da 21542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2155
69e9b5a3
PE
2156 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2157
b5f869a7 2158 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2159 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2160 Remove unused local.
c8926152 2161 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2162
841a1577 2163 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2164 GCC 4.6.0 optimizes based on type-based alias analysis.
2165 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2166 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2167 != &v->size, and therefore "v->size = 1; b->size = 2; return
2168 v->size;" must therefore return 1. This assumption is incorrect
2169 for Emacs, since it type-puns struct Lisp_Vector * with many other
2170 types. To fix this problem, this patch adds a new type struct
f904488f 2171 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2172 and pseudovectors, and helps optimizing compilers not get fooled
2173 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2174 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2175 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2176 the size member.
eab3844f
PE
2177 (XSETPVECTYPE): Rewrite in terms of new macro.
2178 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2179 This is a bit clearer, and further avoids the possibility of
2180 undesirable aliasing.
2181 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2182 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2183 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2184 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2185 (ASIZE): Now uses header.size rather than size.
2186 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2187 to avoid the hassle of writing XVECTOR (foo)->header.size.
2188 (struct vectorlike_header): New type.
eab3844f
PE
2189 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2190 object, to help avoid aliasing.
2191 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2192 (SUBRP): Likewise, since Lisp_Subr is a special case.
2193 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2194 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2195 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2196 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2197 changed to be "header.size" and "header.next".
2198 * buffer.h (struct buffer): Likewise.
2199 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2200 * frame.h (struct frame): Likewise.
2201 * process.h (struct Lisp_Process): Likewise.
2202 * termhooks.h (struct terminal): Likewise.
2203 * window.c (struct save_window_data, struct saved_window): Likewise.
2204 * window.h (struct window): Likewise.
2205 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2206 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2207 * buffer.c (init_buffer_once): Likewise.
2208 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2209 special case.
2210 * process.c (Fformat_network_address): Use local var for size,
2211 for brevity.
2212
0df1eac5
PE
2213 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2214
847ab9d1 2215 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2216 * data.c (atof): Remove decl; no longer used or needed.
2217 (digit_to_number): Move to lread.c.
2218 (Fstring_to_number): Use new string_to_number function, to be
2219 consistent with how the Lisp reader treats infinities and NaNs.
2220 Do not assume that floating-point numbers represent EMACS_INT
2221 without losing information; this is not true on most 64-bit hosts.
2222 Avoid double-rounding errors, by insisting on integers when
2223 parsing non-base-10 numbers, as the documentation specifies.
2224 * lisp.h (string_to_number): New decl, replacing ...
2225 (isfloat_string): Remove.
bc0a5c13 2226 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2227 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2228 appears to have been a coding error. Similarly, do not accept
2229 strings like +-1e0 as floating point numbers. Do not report
2230 overflow for integer overflows unless the base is not 10 which
2231 means we have no simple and reliable way to continue.
2232 Break out the floating-point parsing into a new
2233 function string_to_number, so that Fstring_to_number parses
2234 floating point numbers consistently with the Lisp reader.
04f2d78b 2235 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2236 (E_CHAR, EXP_INT): Remove, replacing with ...
2237 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2238 (string_to_number): New function, replacing isfloat_string.
2239 This function checks for valid syntax and produces the resulting
2240 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2241 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2242 so that overflow for non-base-10 numbers is reported only when
2243 there's no portable and simple way to convert to floating point.
452f4150 2244
67769ffc
PE
2245 * textprop.c (set_text_properties_1): Rewrite for clarity,
2246 and to avoid GCC warning about integer overflow.
2247
c20db43f
PE
2248 * intervals.h (struct interval): Use EMACS_INT for members
2249 where EMACS_UINT might cause problems. See
2250 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2251 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2252 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2253 All uses changed.
37aa2f85
PE
2254 (offset_intervals): Tell GCC not to worry about length overflow
2255 when negating a negative length.
c20db43f 2256
2538aa2f
PE
2257 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2258 (overrun_check_free): Likewise.
2259
f2d3008d
PE
2260 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2261 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2262 word size.
2263
ec8df744
PE
2264 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2265 (gnutls_make_error): Rename local to avoid shadowing.
2266 (gnutls_emacs_global_deinit): ifdef out; not used.
2267 (Fgnutls_boot): Use const for pointer to readonly storage.
2268 Comment out unused local. Fix pointer signedness problems.
2269
640ee02d
PE
2270 * lread.c (openp): Don't stuff size_t into an 'int'.
2271 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2272 about possible signed overflow.
2273
6048fb2a
PE
2274 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2275 (GDK_KEY_g): Don't define if already defined.
2276 (xg_prepare_tooltip): Avoid pointer signedness problem.
2277 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2278
fa3c87e1
PE
2279 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2280 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2281
2172544b
PE
2282 * xfns.c (Fx_window_property): Simplify a bit,
2283 to make a bit faster and to avoid GCC 4.6.0 warning.
2284 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2285
9b821a21
PE
2286 * fns.c (internal_equal): Don't assume size_t fits in int.
2287
3c616cfa
PE
2288 * alloc.c (compact_small_strings): Tighten assertion a little.
2289
c2982e87
PE
2290 Replace pEd with more-general pI, and fix some printf arg casts.
2291 * lisp.h (pI): New macro, generalizing old pEd macro to other
2292 conversion specifiers. For example, use "...%"pI"d..." rather
2293 than "...%"pEd"...".
2294 (pEd): Remove. All uses replaced with similar uses of pI.
2295 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2296 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2297 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2298 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2299 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2300 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2301 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2302 64-bit hosts.
2303 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2304 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2305 * print.c (safe_debug_print, print_object): Likewise.
2306 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2307 to int.
6f04d126
PE
2308 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2309 avoiding the 0 flag, which is not portable.
c2982e87
PE
2310 * process.c (Fmake_network_process): Use pI to avoid cast.
2311 * region-cache.c (pp_cache): Likewise.
2312 * xdisp.c (decode_mode_spec): Likewise.
2313 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2314 behavior on 64-bit hosts with printf arg.
6f04d126 2315 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2316 (x_stop_queuing_selection_requests): Likewise.
2317 (x_get_window_property): Don't truncate byte count to an 'int'
2318 when tracing.
0b432f21 2319
5e073ec7
PE
2320 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2321 here, since it parses constructs like leading '-' and spaces,
2322 which are not wanted; and it overflows with large numbers.
2323 Instead, simply match F[0-9]+, which is what is wanted anyway.
2324
36372bf9
PE
2325 * alloc.c: Remove unportable assumptions about struct layout.
2326 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2327 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2328 (allocate_vectorlike, make_pure_vector): Use the new macros,
2329 plus offsetof, to remove unportable assumptions about struct layout.
2330 These assumptions hold on all porting targets that I know of, but
2331 they are not guaranteed, they're easy to remove, and removing them
2332 makes further changes easier.
2333
0b432f21
PE
2334 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2335 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2336 (string_overrun_cookie): Now const. Use initializers that
2337 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2338 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2339 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2340 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2341 multiple of sizeof (EMACS_INT); it need not be, if
2342 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2343 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2344
895009e1
JB
23452011-04-26 Juanma Barranquero <lekktu@gmail.com>
2346
2347 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2348
6a7a1b0b
TZ
23492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2350
2351 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2352 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2353 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2354
841a1577 23552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2356
2357 * lisp.h (Qdebug): List symbol.
895009e1 2358 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2359 * keyboard.c (debug-on-event): New variable.
2360 (handle_user_signal): Break into debugger when debug-on-event
2361 matches the current signal symbol.
2362
f2d3ba6f
DN
23632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2364
2365 * alloc.c (check_sblock, check_string_bytes)
2366 (check_string_free_list): Convert to standard C.
2367
42ce4c63
TZ
23682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2369
2370 * w32.c (emacs_gnutls_push): Fix typo.
2371
825cd63c
EZ
23722011-04-25 Eli Zaretskii <eliz@gnu.org>
2373
fb11d64d
EZ
2374 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2375 "cast to pointer from integer of different size".
2376
825cd63c
EZ
2377 Improve doprnt and its use in verror. (Bug#8545)
2378 * doprnt.c (doprnt): Document the set of format control sequences
2379 supported by the function. Use SAFE_ALLOCA instead of always
2380 using `alloca'.
2381
2382 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2383 is one byte too soon. Don't use xrealloc; instead xfree and
2384 xmalloc anew.
2385
e061a11b
TZ
23862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2387
2388 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2389 callbacks stage.
2390
2391 * gnutls.c: Renamed global_initialized to
2392 gnutls_global_initialized. Added internals for the
2393 :verify-hostname-error, :verify-error, and :verify-flags
2394 parameters of `gnutls-boot' and documented those parameters in the
2395 docstring. Start callback support.
2396 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2397 unless a fatal error occured. Call gnutls_alert_send_appropriate
2398 on error. Return error code.
2399 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2400 (emacs_gnutls_read): Likewise.
2401 (Fgnutls_boot): Return handshake error code.
2402 (emacs_gnutls_handle_error): New function.
2403 (wsaerror_to_errno): Likewise.
2404
2405 * w32.h (emacs_gnutls_pull): Add prototype.
2406 (emacs_gnutls_push): Likewise.
2407
2408 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2409 (emacs_gnutls_push): Likewise.
2410
24112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2412
2413 * process.c (wait_reading_process_output): Check if GnuTLS
2414 buffered some data internally if no FDs are set for TLS
2415 connections.
2416
2417 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2418 (LIBS): Link to USER_LIBS.
2419 ($(BLD)/gnutls.$(0)): New target.
2420
fa6996bc
EZ
24212011-04-24 Eli Zaretskii <eliz@gnu.org>
2422
eb35682e
EZ
2423 * xdisp.c (handle_single_display_spec): Rename the
2424 display_replaced_before_p argument into display_replaced_p, to
2425 make it consistent with the commentary. Fix typos in the
2426 commentary.
2427
e2ad650c
EZ
2428 * textprop.c (syms_of_textprop): Remove dead code.
2429 (copy_text_properties): Delete obsolete commentary about an
2430 interface that was deleted long ago. Fix typos in the description
2431 of arguments.
2432
1b2de274
EZ
2433 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2434 to changes in oldXMenu/XMenu.h from 2011-04-16.
2435 <menu_help_message, prev_menu_help_message>: Constify.
2436 (IT_menu_make_room): menu->help_text is now `const char **';
2437 adjust.
2438
2439 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2440 to changes in oldXMenu/XMenu.h from 2011-04-16.
2441 (struct XMenu): Declare `help_text' `const char **'.
2442
2443 * xfaces.c <Qunspecified>: Make extern again.
2444
2445 * syntax.c: Include sys/types.h before including regex.h, as
2446 required by Posix.
2447
762b15be
EZ
2448 * doc.c (get_doc_string): Improve the format passed to `error'.
2449
2450 * doprnt.c (doprnt): Improve commentary.
2451
2452 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2453
2454 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2455 them with etags.
2456
f1052e5d
EZ
2457 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2458 changes in globals.h immediately force recompilation.
762b15be
EZ
2459 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2460 $(CURDIR)/s/ms-w32.h.
2461 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2462
fa6996bc
EZ
2463 * character.c (Fchar_direction): Function deleted.
2464 (syms_of_character): Don't defsubr it.
2465 <char-direction-table>: Deleted.
2466
e6c3da20
EZ
24672011-04-23 Eli Zaretskii <eliz@gnu.org>
2468
2469 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2470 * doprnt.c: Include limits.h.
2471 (SIZE_MAX): New macro.
04f2d78b
CB
2472 (doprnt): Return a size_t value. 2nd arg is now size_t.
2473 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2474 Improve overflow protection. Support `l' modifier for integer
2475 conversions. Support %l conversion. Don't assume an EMACS_INT
2476 argument for integer conversions and for %c.
2477
2478 * lisp.h (doprnt): Restore prototype.
2479
2480 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2481 $(SRC)/character.h.
2482
2483 * Makefile.in (base_obj): Add back doprnt.o.
2484
2485 * deps.mk (doprnt.o): Add back prerequisites.
2486 (callint.o): Depend on character.h.
2487
2488 * eval.c (internal_lisp_condition_case): Include the handler
2489 representation in the error message.
2490 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2491 when breaking from the loop.
2492
2493 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2494
2495 * callint.c (Fcall_interactively): When displaying error message
2496 about invalid control letter, pass the character's codepoint, not
2497 a pointer to its multibyte form. Improve display of the character
2498 in octal and display also its hex code.
2499
2500 * character.c (char_string): Use %x to display the (unsigned)
2501 codepoint of an invalid character, to avoid displaying a bogus
2502 negative value.
2503
2504 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2505 `error', not SYMBOL_NAME itself.
2506
2507 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2508 character arguments to `error'.
2509
2510 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2511 to `error' in error message about FINAL_CHAR argument. Make sure
2512 FINAL_CHAR is a character, and use %c when it is passed as
2513 argument to `error'.
2514
4ffd0d6b 25152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2516
2517 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2518
2519 * w32.c: Include <time.h>.
2520 (sys_localtime): New function.
2521
4ffd0d6b 25222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2523
2524 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2525
4ffd0d6b 2526 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2527
4ffd0d6b 25282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2529
4ffd0d6b
GM
2530 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2531 zombies (Bug#8467).
aac0c6e3 2532
04c56954
EZ
25332011-04-19 Eli Zaretskii <eliz@gnu.org>
2534
2535 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2536 gl_state.e_property when gl_state.object is Qt.
2537
2538 * insdel.c (make_gap_larger): Remove limitation of buffer size
2539 to <= INT_MAX.
2540
16a43933
CY
25412011-04-18 Chong Yidong <cyd@stupidchicken.com>
2542
2543 * xdisp.c (lookup_glyphless_char_display)
2544 (produce_glyphless_glyph): Handle cons cell entry in
2545 glyphless-char-display.
2546 (Vglyphless_char_display): Document it.
2547
2548 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2549 glyphless-char-display.
2550
4581706e
CY
25512011-04-17 Chong Yidong <cyd@stupidchicken.com>
2552
2553 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2554
2555 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2556
2557 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2558 definition for no-X builds.
2559
4887c6e2 25602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2561
fd35b6f9
PE
2562 Static checks with GCC 4.6.0 and non-default toolkits.
2563
5c1ccb01
PE
2564 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2565
006c5daa
PE
2566 * process.c (keyboard_bit_set): Define only if SIGIO.
2567 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2568 (send_process): Repair possible setjmp clobbering.
2569
efc736d3
PE
2570 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2571
4e2fe2e6
PE
2572 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2573
f97334a2
PE
2574 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2575
4e75f29d
PE
2576 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2577 Define only if needed.
2578
90efadd1
PE
2579 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2580 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2581 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2582
3c647824
PE
2583 * dispextern.h (struct redisplay_interface): Rename param
2584 to avoid shadowing.
e264f262 2585 * termhooks.h (struct terminal): Likewise.
761383f4 2586 * xterm.c (xembed_send_message): Likewise.
3c647824 2587
b58c5c4a
PE
2588 * insdel.c (make_gap_smaller): Define only if
2589 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2590
cad59032
PE
2591 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2592 it.
2593
c339dc2e
PE
2594 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2595 so that we aren't warned about unused symbols.
2596
91a3e27b
PE
2597 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2598
399c71d3 2599 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2600
8ffc96f5
PE
2601 * xfns.c (x_real_positions): Mark locals as initialized.
2602
eef9bc79
PE
2603 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2604
098db9dd
PE
2605 * xterm.c: Fix problems found by static analysis with other toolkits.
2606 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2607 (x_dispatch_event): Declare static if USE_GTK, and
2608 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2609 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2610 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2611 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2612 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2613
eb18f6cc
PE
2614 * xmenu.c (menu_help_callback): Pointer type fixes.
2615 Use const pointers when pointing at readonly data. Avoid pointer
2616 signedness clashes.
2617 (FALSE): Remove unused macro.
2618 (update_frame_menubar): Remove unused decl.
2619
1fe72bf8
PE
2620 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2621
60d9e1db
PE
2622 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2623 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2624 (single_menu_item): Rename local to avoid shadowing.
2625
39261c26
PE
2626 * keyboard.c (make_lispy_event): Remove unused local var.
2627
018c5e19
PE
2628 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2629 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2630
63d2b86e
PE
2631 * bitmaps: Change bitmaps from unsigned char back to the X11
2632 compatible char. Avoid the old compiler warnings about
2633 out-of-range initializers by using, for example, '\xab' rather
2634 than 0xab.
2635
aefd87e1
PE
2636 * xgselect.c (xgselect_initialize): Check vs interface
2637 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2638
bf501fb9
PE
2639 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2640
e9829fdf
PE
2641 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2642 to read-only memory.
2643
1086c095
PE
2644 * fns.c (vector): Remove; this old hack is no longer needed.
2645
2baccd04 2646 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2647 Remove unused var.
dde42981 2648 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2649
72391843 2650 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2651
436c16df 2652 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2653 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2654 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2655
92bb796d 2656 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2657 (x_term_init): Remove local to avoid shadowing.
92bb796d 2658
764430a3 2659 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2660
2661 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2662 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2663
d1dfb56c
EZ
26642011-04-16 Eli Zaretskii <eliz@gnu.org>
2665
c4354cb4
EZ
2666 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2667
d1dfb56c
EZ
2668 Fix regex.c, syntax.c and friends for buffers > 2GB.
2669 * syntax.h (struct gl_state_s): Declare character position members
2670 EMACS_INT.
2671
2672 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2673
04f2d78b
CB
2674 * textprop.c (verify_interval_modification, interval_of):
2675 Declare arguments EMACS_INT.
d1dfb56c
EZ
2676
2677 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2678 EMACS_INT.
2679
2680 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2681
2682 * indent.c (Fvertical_motion): Local variable it_start is now
2683 EMACS_INT.
2684
2685 * regex.c (re_match, re_match_2, re_match_2_internal)
2686 (bcmp_translate, regcomp, regexec, print_double_string)
2687 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2688 (re_compile_pattern, re_exec): Declare arguments and local
2689 variables `size_t' and `ssize_t' and return values `regoff_t', as
2690 appropriate.
2691 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2692 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2693 <compile_stack_type>: `size' and `avail' are now `size_t'.
2694
2695 * regex.h <regoff_t>: Use ssize_t, not int.
2696 (re_search, re_search_2, re_match, re_match_2): Arguments that
2697 specify buffer/string position and length are now ssize_t and
2698 size_t. Return type is regoff_t.
2699
613052cd
BK
27002011-04-16 Ben Key <bkey76@gmail.com>
2701
2702 * nsfont.m: Fixed bugs in ns_get_family and
2703 ns_descriptor_to_entity that were caused by using free to
2704 deallocate memory blocks that were allocated by xmalloc (via
2705 xstrdup). This caused Emacs to crash when compiled with
2706 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2707 --enable-checking=xmallocoverrun). xfree is now used to
2708 deallocate these memory blocks.
2709
4170f62f 27102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2711
71b41406
PE
2712 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2713
9587a89d
PE
2714 emacs_write: Accept and return EMACS_INT for sizes.
2715 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2716 et seq.
2717 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2718 Accept and return EMACS_INT.
2719 (emacs_gnutls_write): Return the number of bytes written on
2720 partial writes.
2721 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2722 (emacs_read, emacs_write): Remove check for negative size, as the
2723 Emacs source code has been audited now.
9587a89d
PE
2724 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2725 (emacs_read, emacs_write): Use it.
273a5f82
PE
2726 * process.c (send_process): Adjust to the new signatures of
2727 emacs_write and emacs_gnutls_write. Do not attempt to store
2728 a byte offset into an 'int'; it might overflow.
9587a89d 2729 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2730
3e047f51
PE
2731 * sound.c: Don't assume sizes fit in 'int'.
2732 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2733 Return EMACS_INT, not int.
3e047f51 2734 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2735 Accept EMACS_INT, not int.
2736 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2737 record read return values.
2738
cc39a9db
BK
27392011-04-15 Ben Key <bkey76@gmail.com>
2740
c9d0ec6d
JB
2741 * keyboard.c (Qundefined): Don't declare static since it is used
2742 in nsfns.m.
2743 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2744 static since they are used in nsfont.m.
cc39a9db 2745
6c60eb9f
SM
27462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2747
2748 * process.c (Qprocessp): Don't declare static.
2749 * lisp.h (Qprocessp): Declare again.
2750
7990b61a
JB
27512011-04-15 Juanma Barranquero <lekktu@gmail.com>
2752
2753 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2754
5d4cb038
PE
27552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2756
8bd7b830 2757 Improve C-level modularity by making more things 'static'.
cd64ea1d 2758
e3b27b31
PE
2759 Don't publish debugger-only interfaces to other modules.
2760 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2761 (verify_bytepos, count_markers): Move decls to the only modules
2762 that need them.
2763 * region-cache.h (pp_cache): Likewise.
2764 * window.h (check_all_windows): Likewise.
2765 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2766
5d4cb038
PE
2767 * sysdep.c (croak): Now static, if
2768 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2769 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2770
2771 * alloc.c (refill_memory_reserve): Now static if
2772 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2773 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2774
e87b6180
PE
2775 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2776 Define only if USE_LUCID.
2777
ac64929e
PE
2778 * xrdb.c (x_customization_string, x_rm_string): Now static.
2779
6f37259d
PE
2780 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2781 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2782
1683e3ab
PE
2783 * xdisp.c (draw_row_with_mouse_face): Now static.
2784 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2785
de9c2632
PE
2786 * window.h (check_all_windows): Mark externally visible.
2787
2b96acb7
PE
2788 * window.c (window_deletion_count): Now static.
2789
2790 * undo.c: Make symbols static if they're not exported.
2791 (last_undo_buffer, last_boundary_position, pending_boundary):
2792 Now static.
2793
50436f33
PE
2794 * textprop.c (interval_insert_behind_hooks): Now static.
2795 (interval_insert_in_front_hooks): Likewise.
2796
64520e5c
PE
2797 * term.c: Make symbols static if they're not exported.
2798 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2799 (max_frame_lines, tty_set_terminal_modes):
2800 (tty_reset_terminal_modes, tty_turn_off_highlight):
2801 (get_tty_terminal): Now static.
2802 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2803 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2804 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2805 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2806 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2807
1fa53021
PE
2808 * sysdep.c: Make symbols static if they're not exported.
2809 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2810 Now static.
2811 (sigprocmask_set, full_mask): Remove; unused.
2812 (wait_debugging): Mark as visible.
2813 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2814 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2815
d4b43b22
PE
2816 * syntax.c (syntax_temp): Define only if !__GNUC__.
2817
b7c513d0
PE
2818 * sound.c (current_sound_device, current_sound): Now static.
2819
989b29ad
PE
2820 * search.c (searchbufs, searchbuf_head): Now static.
2821
13a55a78
PE
2822 * scroll.c (scroll_cost): Remove; unused.
2823 * dispextern.h (scroll_cost): Remove decl.
2824
de68a1fc
PE
2825 * region-cache.h (pp_cache): Mark as externally visible.
2826
40ccffa6
PE
2827 * process.c: Make symbols static if they're not exported.
2828 (process_tick, update_tick, create_process, chan_process):
2829 (Vprocess_alist, proc_buffered_char, datagram_access):
2830 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2831 (deactivate_process): Mark defn as static, as well as decl.
2832 * lisp.h (create_process): Remove decl.
2833 * process.h (chan_process, Vprocess_alist): Remove decls.
2834
ad64fc97
PE
2835 * print.c: Make symbols static if they're not exported.
2836 (print_depth, new_backquote_output, being_printed, print_buffer):
2837 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2838 (print_interval, print_number_index, initial_stderr_stream):
2839 Now static.
2840 * lisp.h (Fprinc): Remove decl.
2841 (debug_output_compilation_hack): Mark as externally visible.
2842
adddb265
PE
2843 * sysdep.c (croak): Move decl from here to syssignal.h.
2844 * syssignal.h (croak): Put it here, so the API can be checked when
2845 'croak' is called from dissociate_if_controlling_tty.
2846
1717ede2
PE
2847 * minibuf.c: Make symbols static if they're not exported.
2848 (minibuf_save_list, choose_minibuf_frame): Now static.
2849 * lisp.h (choose_minibuf_frame): Remove decl.
2850
fa5fb2bc
PE
2851 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2852
1e3890d1
PE
2853 * lread.c: Make symbols static if they're not exported.
2854 (read_objects, initial_obarray, oblookup_last_bucket_number):
2855 Now static.
2856 (make_symbol): Remove; unused.
2857 * lisp.h (initial_obarray, make_symbol): Remove decls.
2858
8a1414fa
PE
2859 * keyboard.c: Make symbols static if they're not exported.
2860 (single_kboard, recent_keys_index, total_keys, recent_keys):
2861 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2862 (this_single_command_key_start, echoing, last_auto_save):
2863 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2864 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2865 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2866 (Vlispy_mouse_stem, double_click_count):
2867 Now static.
2868 (force_auto_save_soon): Define only if SIGDANGER.
2869 (ignore_mouse_drag_p): Now static if
2870 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2871 (print_help): Remove; unused.
2872 (stop_character, last_timer_event): Mark as externally visible.
2873 * keyboard.h (ignore_mouse_drag_p): Declare only if
2874 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2875 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2876 * lisp.h (echoing): Remove decl.
2877 (force_auto_save_soon): Declare only if SIGDANGER.
2878 * xdisp.c (redisplay_window): Simplify code, to make it more
2879 obvious that ignore_mouse_drag_p is not accessed if !defined
2880 USE_GTK && !defined HAVE_NS.
2881
93ea6e8f
PE
2882 * intervals.c: Make symbols static if they're not exported.
2883 (merge_properties_sticky, merge_interval_right, delete_interval):
2884 Now static.
2885 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2886
77382fcc
PE
2887 * insdel.c: Make symbols static if they're not exported.
2888 However, leave prepare_to_modify_buffer alone. It's never
2889 called from outside this function, but that appears to be a bug.
2890 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2891 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2892 (adjust_after_replace_noundo): Remove; unused.
2893 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2894 (signal_before_change): Remove decls.
77382fcc 2895
9306c32e
PE
2896 * indent.c (val_compute_motion, val_vmotion): Now static.
2897
cd44d2eb
PE
2898 * image.c: Make symbols static if they're not exported.
2899 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2900 if USE_GTK.
2901 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2902 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2903
ad9a7a06
PE
2904 * fringe.c (standard_bitmaps): Now static.
2905 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2906
81626931
PE
2907 * frame.c: Make symbols static if they're not exported.
2908 (x_report_frame_params, make_terminal_frame): Now static.
2909 (get_frame_param): Now static, unless HAVE_NS.
2910 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2911 (x_get_resource_string): Remove; not used.
2912 * frame.h (make_terminal_frame, x_report_frame_params):
2913 (x_get_resource_string); Remove decls.
2914 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2915 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2916
239f9db9
PE
2917 * font.c, fontset.c: Make symbols static if they're not exported.
2918 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2919 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2920 * font.c (font_close_object): Now static.
2921 * font.h (font_close_object): Remove.
2922 * fontset.c (FONTSET_OBJLIST): Remove.
2923 (free_realized_fontset) #if-0 the body, which does nothing.
2924 (face_suitable_for_char_p): #if-0, as it's never called.
2925 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2926 * xfaces.c (face_at_string_position):
2927 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2928 since 0 is always ASCII.
2929
dfcf3579
PE
2930 * fns.c (weak_hash_tables): Now static.
2931
5045092b
PE
2932 * fileio.c: Make symbols static if they're not exported.
2933 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2934 (Vwrite_region_annotation_buffers): Now static.
2935
57a96f5c
PE
2936 * eval.c: Make symbols static if they're not exported.
2937 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2938 * lisp.h (backtrace_list): Remove decl.
2939
35f08c38
PE
2940 * emacs.c: Make symbols static if they're not exported.
2941 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2942 (fatal_error_code, fatal_error_signal_hook, standard_args):
2943 Now static.
2944 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2945 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2946 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2947 * lisp.h (fatal_error_signal_hook): Remove decl.
2948 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2949
f44bd759
PE
2950 * editfns.c: Move a (normally-unused) function to its only use.
2951 * editfns.c, lisp.h (get_operating_system_release): Remove.
2952 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2953 worth the hassle of breaking this out.
2954
b532497d
PE
2955 * xterm.c: Make symbols static if they're not exported.
2956 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2957 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2958 (x_destroy_window, x_delete_display):
2959 Now static.
2960 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2961 (x_mouse_leave): Remove; unused.
2962 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2963 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2964 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2965 Remove decls.
2966 (x_mouse_leave): Declare only if WINDOWSNT.
2967 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2968 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2969 USE_X_TOOLKIT.
2970
1675728f
PE
2971 * ftxfont.c: Make symbols static if they're not exported.
2972 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2973 HAVE_FREETYPE.
2974 * font.h (ftxfont_driver): Likewise.
2975
e4cebfca
PE
2976 * xfns.c: Make symbols static if they're not exported.
2977 (x_last_font_name, x_display_info_for_name):
2978 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2979 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2980 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2981 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2982 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2983 (last_show_tip_args): Now static.
2984 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2985 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2986 (x_screen_planes): Remove; unused.
2987 * dispextern.h (x_screen_planes): Remove decl.
2988
5bf46f05
PE
2989 * dispnew.c: Make symbols static if they're not exported.
2990 * dispextern.h (redraw_garbaged_frames, scrolling):
2991 (increment_row_positions): Remove.
2992 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2993 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2994 Now static.
2995 (redraw_garbaged_frames): Remove; unused.
2996
435f4c28
PE
2997 * xfaces.c: Make symbols static if they're not exported.
2998 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2999 Remove decls.
3000 * xterm.h (defined_color): Remove decls.
3001 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3002 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3003 (menu_face_changed_default, defined_color, free_realized_face):
3004 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3005 (ascii_face_of_lisp_face): Remove; unused.
3006
8524aef3
PE
3007 * xdisp.c: Make symbols static if they're not exported.
3008 * dispextern.h (scratch_glyph_row, window_box_edges):
3009 (glyph_to_pixel_coords, set_cursor_from_row):
3010 (get_next_display_element, set_iterator_to_next):
3011 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3012 (show_mouse_face): Remove decls
3013 * frame.h (message_buf_print): Likewise.
3014 * lisp.h (pop_message, set_message, check_point_in_composition):
3015 Likewise.
3016 * xterm.h (set_vertical_scroll_bar): Likewise.
3017 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3018 (message_buf_print, scratch_glyph_row, displayed_buffer):
3019 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3020 (get_next_display_element, show_mouse_face, window_box_edges):
3021 (frame_to_window_pixel_xy, check_point_in_composition):
3022 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3023 (glyph_to_pixel_coords): Remove; unused.
3024
16390cd2
PE
3025 * dired.c (file_name_completion): Now static.
3026
3027 * dbusbind.c (xd_in_read_queued_messages): Now static.
3028
a25f4dfa
PE
3029 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3030 * data.c (circular_list_error): Remove.
3031
14a9c8df
PE
3032 * commands.h (last_point_position, last_point_position_buffer):
3033 (last_point_position_window): Remove decls.
3034 * keyboard.c: Make these variables static.
3035
04f2d78b
CB
3036 * coding.h (coding, code_convert_region, encode_coding_gap):
3037 Remove decls.
74ab6df5
PE
3038 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3039 (iso_code_class, detect_coding, code_convert_region): Now static.
3040 (encode_coding_gap): Remove; unused.
3041
38dfbee1
PE
3042 * chartab.c (chartab_chars, chartab_bits): Now static.
3043
a2cb4e63
PE
3044 * charset.h (charset_iso_8859_1): Remove decl.
3045 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3046 Now static.
3047
127198fd
PE
3048 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3049 * ccl.c (Vccl_program_table): Now static.
3050 (check_ccl_update): Remove; unused.
3051
d85b608f
PE
3052 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3053 * category.h: ... from here.
3054 * category.c (check_category_table, set_category_set): Now static.
3055
31cd66f3
PE
3056 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3057 * lisp.h: Remove these decls.
3058
c358e587
PE
3059 * buffer.c (buffer_count): Remove unused var.
3060
e78aecca
PE
3061 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3062 so that it's not optimized away.
3063 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3064 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3065 exported only to the debugger.
3066
e192d7d3 3067 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3068 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3069
92470028
PE
3070 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3071 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3072 was inaccessible from Lisp.
3073 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3074 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3075
244ed907
PE
3076 alloc.c: Import and export fewer symbols, and remove unused items.
3077 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3078 is defined.
3079 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3080 it's not optimized away by whole-program optimization.
3081 (message_enable_multibyte, free_misc): Remove.
3082 (catchlist, handlerlist, mark_backtrace):
3083 Declare only if BYTE_MARK_STACK.
3084 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3085 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3086 (message_enable_multibyte): Remove decl.
3087 (free_misc, interval_free_list, float_block, float_block_index):
3088 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3089 (cons_free_list, last_marked_index):
3090 Now static.
3091 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3092 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3093 (mark_backtrace): Define only if BYTE_MARK_STACK.
3094 * xdisp.c (message_enable_multibyte): Now static.
3095
61c2b50e 3096 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3097 This makes it easier for human readers (and static analyzers)
3098 to see whether these variables are used from other modules.
3099 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3100 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3101 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3102 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3103 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3104 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3105 * xmenu.c, xselect.c:
3106 Declare Q* vars static if they are not used in other modules.
3107 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3108 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3109 Remove decls of unexported vars.
3110 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3111
95c82688
PE
3112 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3113
16a97296
PE
3114 Make Emacs functions such as Fatom 'static' by default.
3115 This makes it easier for human readers (and static analyzers)
3116 to see whether these functions can be called from other modules.
3117 DEFUN now defines a static function. To make the function external
3118 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3119 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3120 (Finit_image_library):
16a97296
PE
3121 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3122 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3123 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3124 Remove decls, since these functions are now static.
3125 (Funintern, Fget_internal_run_time): New decls, since these functions
3126 were already external.
95c82688 3127
16a97296
PE
3128 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3129 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3130 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3131 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3132 * keyboard.c, keymap.c, lread.c:
3133 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3134 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3135 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3136 Mark functions with DEFUE instead of DEFUN,
3137 if they are used in other modules.
3138 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3139 decls for now-static functions.
3140 * buffer.h (Fdelete_overlay): Remove decl.
3141 * callproc.c (Fgetenv_internal): Mark as internal.
3142 * composite.c (Fremove_list_of_text_properties): Remove decl.
3143 (Fcomposition_get_gstring): New forward static decl.
3144 * composite.h (Fcomposite_get_gstring): Remove decl.
3145 * dired.c (Ffile_attributes): New forward static decl.
3146 * doc.c (Fdocumntation_property): New forward static decl.
3147 * eval.c (Ffetch_bytecode): New forward static decl.
3148 (Funintern): Remove extern decl; now in .h file where it belongs.
3149 * fileio.c (Fmake_symbolic_link): New forward static decl.
3150 * image.c (Finit_image_library): New forward static decl.
3151 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3152 * intervals.h (Fprevious_property_change):
3153 (Fremove_list_of_text_properties): Remove decls.
3154 * keyboard.c (Fthis_command_keys): Remove decl.
3155 (Fcommand_execute): New forward static decl.
3156 * keymap.c (Flookup_key): New forward static decl.
3157 (Fcopy_keymap): Now static.
3158 * keymap.h (Flookup_key): Remove decl.
3159 * process.c (Fget_process): New forward static decl.
3160 (Fprocess_datagram_address): Mark as internal.
3161 * syntax.c (Fsyntax_table_p): New forward static decl.
3162 (skip_chars): Remove duplicate decl.
3163 * textprop.c (Fprevious_property_change): New forward static decl.
3164 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3165 Now internal.
3166 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3167 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3168
785bbd42
PE
3169 * editfns.c (Fformat): Remove unreachable code.
3170
8b913b57
AS
31712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3172
3173 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3174 change. (Bug#8496)
3175
a6744a35
EZ
31762011-04-13 Eli Zaretskii <eliz@gnu.org>
3177
3178 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3179 when at ZV. (Bug#8487)
3180
e7974947
AS
31812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3182
baad03f0
AS
3183 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3184 (Bug#8437)
3185 * keyboard.c (parse_tool_bar_item): Likewise.
3186 * sound.c (sound_cleanup, alsa_close): Likewise.
3187 * termcap.c (tgetent): Likewise.
3188 * xfns.c (x_default_font_parameter): Likewise.
3189 * xsettings.c (read_and_apply_settings): Likewise.
3190
e7974947
AS
3191 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3192 (overrun_check_free): Protoize.
3193
28272684
PE
31942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3197 since callers should never pass a negative size.
3198 Change the signature to match that of plain 'read' and 'write'; see
3199 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3200 * lisp.h: Update prototypes of emacs_write and emacs_read.
3201
11997c76
EZ
32022011-04-11 Eli Zaretskii <eliz@gnu.org>
3203
3204 * xdisp.c (redisplay_window): Don't try to determine the character
3205 position of the scroll margin if the window start point w->startp
e896f03c 3206 is outside the buffer's accessible region. (Bug#8468)
11997c76 3207
8a2cbd72
EZ
32082011-04-10 Eli Zaretskii <eliz@gnu.org>
3209
3210 Fix write-region and its subroutines for buffers > 2GB.
3211 * fileio.c (a_write, e_write): Modify declaration of arguments and
3212 local variables to support buffers larger than 2GB.
3213 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3214
3215 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3216 argument, local variables, and return value.
3217
3218 * lisp.h: Update prototypes of emacs_write and emacs_read.
3219
3220 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3221
4073e537 32222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3223
1ebfdcb6
PE
3224 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3225
b2ded58d
PE
3226 Fix more problems found by GCC 4.6.0's static checks.
3227
7d66342c
PE
3228 * xdisp.c (vmessage): Use a better test for character truncation.
3229
bbf47d44
PE
3230 * charset.c (load_charset_map): <, not <=, for optimization,
3231 and to avoid potential problems with integer overflow.
9248994d 3232 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3233 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3234 * editfns.c (Fformat): Likewise.
1e69125e 3235 * syntax.c (skip_chars): Likewise.
3befa583 3236
e3019616
PE
3237 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3238 This also lets GCC 4.6.0 generate slightly better loop code.
3239
becfa255
PE
3240 * callint.c (Fcall_interactively): <, not <=, for optimization.
3241 (Fcall_interactively): Count the number of arguments produced,
3242 not the number of arguments given. This is simpler and lets GCC
3243 4.6.0 generate slightly better code.
3244
dae0cd48
PE
3245 * ftfont.c: Distingish more carefully between FcChar8 and char.
3246 The previous code passed unsigned char * to a functions like
3247 strlen and xstrcasecmp that expect char *, which does not
3248 conform to the C standard.
3249 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3250 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3251 char * when the C standard requires it.
3252
76032d70
PE
3253 * keyboard.c (read_char): Remove unused var.
3254
eb3f1cc8
PE
3255 * eval.c: Port to Windows vsnprintf (Bug#8435).
3256 Include <limits.h>.
3257 (SIZE_MAX): Define if the headers do not.
3258 (verror): Do not give up if vsnprintf returns a negative count.
3259 Instead, grow the buffer. This ports to Windows vsnprintf, which
3260 does not conform to C99. Problem reported by Eli Zaretskii.
3261 Also, simplify the allocation scheme, by avoiding the need for
3262 calling realloc, and removing the ALLOCATED variable.
3263
70476b54
PE
3264 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3265
12020a9e
PE
3266 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3267 But keep the doprint source code for now, as we might revamp it
3268 and use it again (Bug#8435).
ea6c7ae6
PE
3269 * lisp.h (doprnt): Remove.
3270 * Makefile.in (base_obj): Remove doprnt.o.
3271 * deps.mk (doprnt.o): Remove.
3272
5fdb398c
PE
3273 error: Print 32- and 64-bit integers portably (Bug#8435).
3274 Without this change, on typical 64-bit hosts error ("...%d...", N)
3275 was used to print both 32- and 64-bit integers N, which relied on
3276 undefined behavior.
3277 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3278 New macro.
3279 * lisp.h (error, verror): Mark as printf-like functions.
3280 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3281 Report overflow in size calculations when allocating printf buffer.
3282 Do not truncate output string at its first null byte.
3283 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3284 Truncate the output at a character boundary, since vsnprintf does not
3285 do that.
3286 * charset.c (check_iso_charset_parameter): Convert internal
3287 character to string before calling 'error', since %c now has the
3288 printf meaning.
3289 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3290 overflow when computing char to be passed to 'error'. Do not
3291 pass Lisp_Object to 'error'; pass the integer instead.
3292 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3293 formatted with plain %d.
3294
b189fa66
PE
3295 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3296
bff87ef0
PE
3297 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3298
7e2cac20
PE
3299 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3300
ce4d90b5
PE
3301 * xterm.c (x_catch_errors): Remove duplicate declaration.
3302
266c9547
PE
3303 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3304
79c49ad2
PE
3305 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3306
368f4090
JM
33072011-04-10 Jim Meyering <meyering@redhat.com>
3308
3309 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3310 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3311 return ssize_t not "int", and use size_t as the buffer length.
3312 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3313 * gnutls.h: Update declarations.
3314 * process.c (read_process_output): Use ssize_t, to match.
3315 (send_process): Likewise.
3316
a32d4040
CY
33172011-04-09 Chong Yidong <cyd@stupidchicken.com>
3318
3319 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3320
8546720e 33212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3322
04f2d78b
CB
3323 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3324 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3325
8546720e
GM
3326 * xterm.c (handle_one_xevent):
3327 * xmenu.c (create_and_show_popup_menu):
3328 * xselect.c (x_decline_selection_request)
3329 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3330
0a2f5c1a 33312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3332
3333 Fix some uses of `int' instead of EMACS_INT.
3334 * search.c (string_match_1, fast_string_match)
3335 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3336 (scan_buffer, find_next_newline_no_quit)
3337 (find_before_next_newline, search_command, Freplace_match)
3338 (Fmatch_data): Make some `int' variables be EMACS_INT.
3339
3340 * xdisp.c (display_count_lines): 3rd argument and return value now
3341 EMACS_INT. All callers changed.
3342 (pint2hrstr): Last argument is now EMACS_INT.
3343
3344 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3345 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3346 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3347 (decode_coding_utf_16, decode_coding_emacs_mule)
3348 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3349 (decode_coding_ccl, decode_coding_charset)
3350 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3351 (decode_coding_iso_2022, decode_coding_emacs_mule)
3352 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3353 <char_offset, last_offset>: Declare EMACS_INT.
3354 (encode_coding_utf_8, encode_coding_utf_16)
3355 (encode_coding_emacs_mule, encode_invocation_designation)
3356 (encode_designation_at_bol, encode_coding_iso_2022)
3357 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3358 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3359 Declare EMACS_INT.
3360 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3361 (encode_invocation_designation): Last argument P_NCHARS is now
3362 EMACS_INT.
3363 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3364 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3365
3366 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3367 All users changed.
3368
3369 * ccl.c (Fccl_execute_on_string): Declare some variables
3370 EMACS_INT.
3371
8546720e 33722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3373
3374 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3375
4e19a977
CS
33762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3377
3378 * process.c (Fformat_network_address): Doc fix.
3379
87302331
R
33802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3381
3382 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3383
cbb59342
CY
33842011-04-08 Chong Yidong <cyd@stupidchicken.com>
3385
3386 * keyboard.c (read_char): Call Lisp function help-form-show,
3387 instead of using internal_with_output_to_temp_buffer.
3388 (Qhelp_form_show): New var.
e0d38eeb 3389 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3390
3391 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3392
3393 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3394
e67a13ab
CY
33952011-04-06 Chong Yidong <cyd@stupidchicken.com>
3396
04f2d78b
CB
3397 * process.c (Flist_processes): Remove to Lisp.
3398 (list_processes_1): Delete.
e67a13ab 3399
973f782d
EZ
34002011-04-06 Eli Zaretskii <eliz@gnu.org>
3401
7c106b1e
EZ
3402 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3403
973f782d
EZ
3404 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3405
41cf7d1a 34062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3407
ca23cc88
PE
3408 Fix more problems found by GCC 4.6.0's static checks.
3409
f390e2d5
PE
3410 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3411
42eea0d0
PE
3412 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3413
b69769da 3414 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3415
f9541e84
PE
3416 * xdisp.c (vmessage): Mark as a printf-like function.
3417
13841b55
PE
3418 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3419
c136c10f
PE
3420 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3421
5e2d4a30
PE
3422 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3423 printf-like functions.
3424 (tiff_load): Add casts to remove these marks before passing them
3425 to system-supplied API.
3426
583f48b9
PE
3427 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3428
b25d760e
PE
3429 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3430 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3431 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3432 directly, rather than having caller test rule sign. This avoids
3433 some unnecessary tests.
3434 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3435 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3436 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3437
bc7b6697 3438 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3439 (xfont_open): Avoid unnecessary tests.
bc7b6697 3440
27ccc379
PE
3441 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3442
dcd5c89a
PE
3443 * composite.h, composite.c (composition_gstring_put_cache):
3444 Use EMACS_INT, not int, for length.
3445
b13a45c6
PE
3446 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3447 breaking out part of COMPOSITION_DECODE_RULE.
3448 (COMPOSITION_DECODE_RULE): Use it.
3449 * composite.c (get_composition_id): Remove unused local vars,
3450 by using the new macro.
3451
1e792e4d
PE
3452 * textprop.c (set_text_properties_1): Change while to do-while,
3453 since the condition is always true at first.
3454
dc6c6455 3455 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3456 (interval_deletion_adjustment): Return unsigned value.
3457 All uses changed.
dc6c6455 3458
aba7731a
PE
3459 * process.c (list_processes_1, create_pty, read_process_output):
3460 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3461 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3462 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3463 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3464 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3465
fdfc4bf3
PE
3466 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3467
fca8fe46 3468 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3469 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3470
06a0259a 3471 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3472 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3473 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3474
e7b9e80f
PE
3475 * print.c (print_error_message): Avoid int overflow.
3476
56201685
PE
3477 * font.c (font_list_entities): Redo for clarity,
3478 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3479
78834453 3480 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3481 (font_score): Avoid potential overflow in diff calculation.
78834453 3482
0bc0b309 3483 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3484 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3485
e610eaca
PE
3486 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3487
b895abce
PE
3488 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3489 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3490 can always succeed if overflow has undefined behavior.
3491
1f1d9321 3492 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3493 (wordify): Omit three unnecessary tests.
1f1d9321 3494
c59478bc
PE
3495 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3496 All callers changed. This avoids the need for an unused var.
3497
79b73827
PE
3498 * casefiddle.c (casify_region): Remove var that is set but not used.
3499
a4db5dfe
PE
3500 * dired.c (file_name_completion): Remove var that is set but not used.
3501
43aae36e
PE
3502 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3503
2a47c44d 3504 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3505 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3506
a37c69bf
PE
3507 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3508 Check for integer overflow on size calculations.
3509
328ab8e7
PE
3510 * buffer.c (Fprevious_overlay_change): Remove var that is set
3511 but not used.
3512
e5a2a5cb
PE
3513 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3514 Remove vars that are set but not used.
8d84a6eb 3515 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3516 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3517
a60e5f68
PE
3518 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3519
f661cb61 3520 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3521 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3522
f0397f5a
PE
3523 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3524 that are set but not used.
3525
8664db06 3526 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3527 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3528
6abdaa4a
PE
3529 * xselect.c (x_get_local_selection, x_handle_property_notify):
3530 Remove vars that are set but not used.
3531
0ce7538d 3532 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3533 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3534
9ae848fc
PE
3535 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3536 Remove var that is set but not used.
0b918413
PE
3537 (scroll_bar_windows_size): Now size_t, not int.
3538 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3539 Check for overflow.
9ae848fc 3540
a5a62657
PE
3541 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3542 (map_tty_color) [!defined MSDOS]: Likewise.
3543
5c5cdd39
PE
3544 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3545
66ebf983
PE
3546 * coding.c: Remove vars that are set but not used.
3547 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3548 All callers changed.
3549 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3550 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3551 (decode_coding_charset): Remove vars that are set but not used.
3552
1be4d761
PE
3553 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3554 that is set but not used.
3555
47553fa8
PE
3556 * print.c (print_object): Remove var that is set but not used.
3557
1f7196bf 3558 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3559 The gnulib version avoids calling malloc in the usual case,
3560 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3561 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3562 * filelock.c (current_lock_owner): Likewise.
3563 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3564 * sysdep.c: Include allocator.h, careadlinkat.h.
3565 (emacs_no_realloc_allocator): New static constant.
3566 (emacs_readlink): New function.
fdb61804
PE
3567 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3568 ../lib/careadlinkat.h.
d1fdcab7 3569
f84c17c7
SM
35702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3571
3572 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3573 first non-nil return value).
3574
ef3862ad
JD
35752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3576
3577 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3578 if not defined (Bug#8403).
3579
376a7006
JB
35802011-04-02 Juanma Barranquero <lekktu@gmail.com>
3581
3582 * xdisp.c (display_count_lines): Remove parameter `start',
3583 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3584 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3585 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3586 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3587 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3588 and thereabouts. All callers changed.
3589 (get_per_char_metric): Remove parameter `f', unused since
3590 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3591
6ca3801d
JM
35922011-04-02 Jim Meyering <meyering@redhat.com>
3593
3594 do not dereference NULL upon failed strdup
3595 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3596 (ns_get_family): Likewise.
3597
d8e2b5ba
JB
35982011-04-02 Juanma Barranquero <lekktu@gmail.com>
3599
3600 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3601
8c74fcbd
JD
36022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3603
3604 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3605 later (Bug#8403).
3606
7200d79c
SM
36072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3608
03408648 3609 Add lexical binding.
7200d79c 3610
03408648
SM
3611 * window.c (Ftemp_output_buffer_show): New fun.
3612 (Fsave_window_excursion):
3613 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3614
3615 * lread.c (lisp_file_lexically_bound_p): New function.
3616 (Fload): Bind Qlexical_binding.
3617 (readevalloop): Remove `evalfun' arg.
3618 Bind Qinternal_interpreter_environment.
3619 (Feval_buffer): Bind Qlexical_binding.
3620 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3621 Mark as dynamic.
3622 (syms_of_lread): Declare `lexical-binding'.
3623
3624 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3625
3626 * keyboard.c (eval_dyn): New fun.
3627 (menu_item_eval_property): Use it.
ca105506
SM
3628
3629 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3630
03408648
SM
3631 * fns.c (concat, mapcar1): Accept byte-code-functions.
3632
3633 * eval.c (Fsetq): Handle lexical vars.
3634 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3635 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3636 (FletX, Flet): Obey lexical binding.
3637 (Fcommandp): Handle closures.
3638 (Feval): New `lexical' arg.
3639 (eval_sub): New function extracted from Feval. Use it almost
3640 everywhere where Feval was used. Look up vars in lexical env.
3641 Handle closures.
3642 (Ffunctionp): Move from subr.el.
3643 (Ffuncall): Handle closures.
3644 (apply_lambda): Remove `eval_flags'.
3645 (funcall_lambda): Handle closures and new byte-code-functions.
3646 (Fspecial_variable_p): New function.
3647 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3648 but without exporting it to Lisp.
23aba0ea 3649
23aba0ea 3650 * doc.c (Fdocumentation, store_function_docstring):
03408648 3651 * data.c (Finteractive_form): Handle closures.
23aba0ea 3652
03408648
SM
3653 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3654 interactive spec.
ba83908c 3655
04f2d78b
CB
3656 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3657 New byte-codes.
03408648
SM
3658 (exec_byte_code): New function extracted from Fbyte_code to handle new
3659 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3660
03408648 3661 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3662
03408648 3663 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3664
e2abce01
JB
36652011-03-31 Juanma Barranquero <lekktu@gmail.com>
3666
3667 * xdisp.c (redisplay_internal): Fix prototype.
3668
63696a73 36692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3670
63696a73 3671 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3672 (try_scrolling): Use it when setting scroll_limit.
3673 Limit scrolling to 100 screen lines.
63696a73
EZ
3674 (redisplay_window): Even when falling back on "recentering",
3675 position point in the window according to scroll-conservatively,
3676 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3677
3678 (try_scrolling): When point is above the window, allow searching
3679 as far as scroll_max, or one screenful, to compute vertical
3680 distance from PT to the scroll margin position. This prevents
3681 try_scrolling from unnecessarily failing when
3682 scroll-conservatively is set to a value slightly larger than the
3683 window height. Clean up the case of PT below the margin at bottom
3684 of window: scroll_max can no longer be INT_MAX. When aggressive
3685 scrolling is in use, don't let point enter the opposite scroll
3686 margin as result of the scroll.
3687 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3688 threshold of 100 lines for never-recentering scrolling.
3689
e4cc2dfc
JB
36902011-03-31 Juanma Barranquero <lekktu@gmail.com>
3691
3692 * dispextern.h (move_it_by_lines):
3693 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3694 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3695 (message_log_check_duplicate): Remove parameters `prev_bol' and
3696 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3697 (redisplay_internal): Remove parameter `preserve_echo_area',
3698 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3699
3700 * indent.c (Fvertical_motion):
3701 * window.c (window_scroll_pixel_based, Frecenter):
3702 Don't pass `need_y_p' to `move_it_by_lines'.
3703
1c470562
SM
37042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3705
44f230aa
SM
3706 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3707 steal a few bits to be more compact.
3708 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3709 Remove unneeded casts.
3710
1c470562
SM
3711 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3712
888adce9
ZK
37132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3714
3715 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3716 binding" message (bug#7967).
3717
f838ed7b
PE
37182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3719
77861b95
PE
3720 Fix more problems found by GCC 4.6.0's static checks.
3721
de6dbc14
PE
3722 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3723 Remove unused local var.
3724
f838ed7b
PE
3725 * editfns.c (Fmessage_box): Remove unused local var.
3726
792c7b2b
PE
3727 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3728 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3729 Omit unused local vars.
c499e557 3730 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3731 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3732 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3733 Omit unused local var.
3734
ba0165e1
PE
3735 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3736 Don't assume string length fits in int.
32ad8845 3737 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3738 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3739
3c59b4c9
PE
3740 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3741 instead of alloca (Bug#8344).
3742
a3eed478 3743 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3744 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3745
eb4d412d
PE
3746 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3747
1658b401
PE
3748 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3749 concerns.
3750
3751 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3752
3753 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3754
9a2c6e05
PE
3755 * keyboard.c (syms_of_keyboard): Use the same style as later
3756 in this function when indexing through an array. This also
3757 works around GCC bug 48267.
3758
03d0a109
PE
3759 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3760
44f730c8
PE
3761 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3762
fe75f926
PE
3763 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3764 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3765
ffa8c828
PE
3766 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3767 This avoids undefined behavior on integer overflow, and is a bit
3768 more convenient anyway since it is compared to a size_t variable.
3769
c5101a77
PE
3770 Variadic C functions now count arguments with size_t, not int.
3771 This avoids an unnecessary limitation on 64-bit machines, which
3772 caused (substring ...) to crash on large vectors (Bug#8344).
3773 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3774 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3775 All variadic functions and their callers changed accordingly.
c5101a77
PE
3776 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3777 * data.c (arith_driver, float_arith_driver): Likewise.
3778 * editfns.c (general_insert_function): Likewise.
3779 * eval.c (struct backtrace.nargs, interactive_p)
3780 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3781 (funcall_lambda, mark_backtrace): Likewise.
3782 * fns.c (concat): Likewise.
3783 * frame.c (x_set_frame_parameters): Likewise.
3784 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3785 0 if not found, not -1. All callers changed.
3786
dd3f25f7
PE
3787 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3788 (stack_copy_size): Now size_t, not int.
3789 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3790
461c2ab9
JB
37912011-03-28 Juanma Barranquero <lekktu@gmail.com>
3792
3793 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3794 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3795 All callers changed.
3796
3797 * lisp.h (multibyte_char_to_unibyte):
3798 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3799 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3800 * character.h (CHAR_TO_BYTE8):
3801 * cmds.c (internal_self_insert):
3802 * editfns.c (general_insert_function):
3803 * keymap.c (push_key_description):
3804 * search.c (Freplace_match):
3805 * xdisp.c (message_dolog, set_message_1): All callers changed.
3806
f6d62986
SM
38072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3808
3809 * keyboard.c (safe_run_hook_funcall): New function.
3810 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3811 don't set the hook to nil, but remove the offending function instead.
3812 (Qcommand_hook_internal): Remove, unused.
3813 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3814 Vcommand_hook_internal.
3815
3816 * eval.c (enum run_hooks_condition): Remove.
3817 (funcall_nil, funcall_not): New functions.
3818 (run_hook_with_args): Call each function through a `funcall' argument.
3819 Remove `cond' argument, now redundant.
3820 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3821 (Frun_hook_with_args_until_failure): Adjust accordingly.
3822 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3823
1db5b1ad
JB
38242011-03-28 Juanma Barranquero <lekktu@gmail.com>
3825
3826 * dispextern.h (string_buffer_position): Remove declaration.
3827
3828 * print.c (strout): Remove parameter `multibyte', unused since
3829 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3830
3831 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3832 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3833 All callers changed.
3834
3835 * w32.c (_wsa_errlist): Use braces for struct initializers.
3836
3837 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3838 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3839 All callers changed.
3840 (string_buffer_position): Likewise. Also, make static (it's never
3841 used outside xdisp.c).
3842 (cursor_row_p): Remove parameter `w', unused since
3843 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3844 (decode_mode_spec): Remove parameter `precision', introduced during
3845 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3846 All callers changed.
3847
5ffb62aa
JD
38482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3849
3850 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3851
461c2ab9 38522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3853
3854 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3855 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3856 (ns_update_auto_hide_menu_bar): New functions.
3857 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3858 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3859 ns_constrain_all_frames.
3860 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3861 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3862
5c380ffb
JD
38632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3864
3865 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3866
9af30bdf
GM
38672011-03-27 Glenn Morris <rgm@gnu.org>
3868
3869 * syssignal.h: Replace RETSIGTYPE with void.
3870 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3871 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3872 Replace SIGTYPE with void everywhere.
3873 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3874 * s/template.h (SIGTYPE): Remove commented out definition.
3875
e2abce01
JB
38762011-03-26 Eli Zaretskii <eliz@gnu.org>
3877
3878 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3879 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3880
f868cd8a
JB
38812011-03-26 Juanma Barranquero <lekktu@gmail.com>
3882
59eb0929
JB
3883 * w32.c (read_unc_volume): Use parameter `henum', instead of
3884 global variable `wget_enum_handle'.
3885
3886 * keymap.c (describe_vector): Remove parameters `indices' and
3887 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3888 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3889
f868cd8a
JB
3890 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3891
3892 * keyboard.c (timer_check): Remove parameter `do_it_now',
3893 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3894 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3895 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3896
3897 * keyboard.c (read_char):
3898 * w32menu.c (w32_menu_display_help):
3899 * xmenu.c (show_help_event, menu_help_callback):
3900 Adjust calls to `show_help_echo'.
3901
3902 * gtkutil.c (xg_maybe_add_timer):
3903 * keyboard.c (readable_events):
3904 * process.c (wait_reading_process_output):
3905 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3906
3907 * insdel.c (adjust_markers_gap_motion):
3908 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3909 (gap_left, gap_right): Don't call it.
3910
2ecf6fdb
CY
39112011-03-25 Chong Yidong <cyd@stupidchicken.com>
3912
3913 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3914 incurred during fontification.
3915
6b1f9ba4
JB
39162011-03-25 Juanma Barranquero <lekktu@gmail.com>
3917
3918 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3919 (DEFVAR_PER_BUFFER): Don't pass it.
3920
3921 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3922 (scrolling_window): Don't pass it.
3923
0f4a96b5
JB
39242011-03-25 Juanma Barranquero <lekktu@gmail.com>
3925
3926 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3927
3928 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3929 and `suffix'.
3930 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3931 of variables specific to SELinux and computation of `encoded_absname'.
3932
3933 * image.c (XPutPixel): Remove unused variable `height'.
3934
3935 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3936
3937 * unexw32.c (get_section_info): Remove unused variable `section'.
3938
3939 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3940 (system_process_attributes): Remove unused variable `sess'.
3941 (sys_read): Remove unused variable `err'.
3942
3943 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3944 (w32_wnd_proc): Remove unused variable `isdead'.
3945 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3946 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3947 (x_create_tip_frame): Remove unused variable `tem'.
3948
3949 * w32inevt.c (w32_console_read_socket):
3950 Remove unused variable `no_events'.
3951
3952 * w32term.c (x_draw_composite_glyph_string_foreground):
3953 Remove unused variable `width'.
3954
1149507c
JB
39552011-03-24 Juanma Barranquero <lekktu@gmail.com>
3956
3957 * w32term.c (x_set_glyph_string_clipping):
3958 Don't pass uninitialized region to CombineRgn.
3959
9c88f339
JB
39602011-03-23 Juanma Barranquero <lekktu@gmail.com>
3961
3962 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3963 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3964 (Fx_close_connection): Remove unused variable `i'.
3965
3966 * w32font.c (w32font_draw): Return number of glyphs.
3967 (w32font_open_internal): Remove unused variable `i'.
3968 (w32font_driver): Add missing initializer.
3969
3970 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3971 (fill_in_menu): Remove unused variable `items_added'.
3972
3973 * w32term.c (last_mouse_press_frame): Remove static global variable.
3974 (w32_clip_to_row): Remove unused variable `f'.
3975 (x_delete_terminal): Remove unused variable `i'.
3976
3977 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3978 (NOTHING): Remove unused static global variable.
3979 (uniscribe_check_otf): Remove unused variable `table'.
3980 (uniscribe_font_driver): Add missing initializers.
3981
dee091a3
JD
39822011-03-23 Julien Danjou <julien@danjou.info>
3983
3984 * term.c (Fsuspend_tty, Fresume_tty):
3985 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3986 * window.c (temp_output_buffer_show):
3987 * insdel.c (signal_before_change):
3988 * frame.c (Fhandle_switch_frame):
3989 * fileio.c (Fdo_auto_save):
3990 * emacs.c (Fkill_emacs):
3991 * editfns.c (save_excursion_restore):
3992 * cmds.c (internal_self_insert):
3993 * callint.c (Fcall_interactively):
3994 * buffer.c (Fkill_all_local_variables):
3995 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3996 Use Frun_hooks.
0f4a96b5 3997 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3998 unconditionnaly since it does the check itself.
3999
2c520ab5 40002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4001
c9c49752
PE
4002 Fix more problems found by GCC 4.5.2's static checks.
4003
8abc3f12
PE
4004 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4005 the first time through the loop, since we know p0 < p1 then.
4006 This also avoids a gcc -Wstrict-overflow warning.
4007
a2d26660
PE
4008 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4009 leading to a memory leak, possible in functions like
4010 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4011 of objects (Bug#8318).
a2d26660 4012
916c72e9
PE
4013 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4014 that could (at least in theory) be that large.
4015
19ab8a18
PE
4016 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4017 This is less likely to overflow, and avoids undefined behavior if
4018 overflow does occur. All callers changed. Use strtoul to scan
4019 for the unsigned long integer.
b7cbbd6f
PE
4020 (pint2hrstr): Simplify and tune code slightly.
4021 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4022
f0641eff
PE
4023 * scroll.c (do_scrolling): Work around GCC bug 48228.
4024 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4025
7f650bb9
PE
4026 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4027 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4028 (validate_x_resource_name): Simplify count usage.
4029 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4030
37dd57d1
PE
4031 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4032 fail (Bug#8306).
81e56e61 4033
699979fc 4034 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4035
401bf9b4
PE
4036 * process.c (Fmake_network_process): Use socklen_t, not int,
4037 where POSIX says socklen_t is required in portable programs.
4038 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4039 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4040 (Fmake_network_process, server_accept_connection):
4041 (wait_reading_process_output, read_process_output):
4042 Likewise.
4043
b93aacde
PE
4044 * process.c: Rename or move locals to avoid shadowing.
4045 (list_processes_1, Fmake_network_process):
4046 (read_process_output_error_handler, exec_sentinel_error_handler):
4047 Rename or move locals.
4dc343ee 4048 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4049 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4050 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4051 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4052 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4053
af8a867c 4054 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4055 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4056 Include tparam.h instead, since it declares them.
af8a867c
PE
4057 * cm.h (PC): Remove extern decl; tparam.h now does this.
4058 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4059 * terminfo.c: Include tparam.h, to check interfaces.
4060 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4061 (tparam): Adjust signature to match interface in tparam.h;
4062 this removes some undefined behavior. Check that outstring and len
4063 are zero, which they always are with Emacs.
4064 * tparam.h (PC, BC, UP): New extern decls.
4065
0248044d 4066 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4067 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4068
8ff096c1 4069 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4070 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4071 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4072 (ftfont_list): Remove unused local.
49eaafba
PE
4073 (get_adstyle_property, ftfont_pattern_entity):
4074 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4075 Rename locals to avoid shadowing.
8ff096c1 4076
e2be39f6
PE
4077 * xfont.c (xfont_list_family): Mark var as initialized.
4078
c9735e30
PE
4079 * xml.c (make_dom): Now static.
4080
8f5201ae
PE
4081 * composite.c (composition_compute_stop_pos): Rename local to
4082 avoid shadowing.
b246f932
PE
4083 (composition_reseat_it): Remove unused locals.
4084 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4085 (composition_update_it): Mark var as initialized.
11b61122
PE
4086 (find_automatic_composition): Mark vars as initialized,
4087 with a FIXME (Bug#8290).
8f5201ae 4088
760fbc2c
PE
4089 character.h: Rename locals to avoid shadowing.
4090 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4091 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4092 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4093 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4094 to avoid shadowing.
4095
ff08eb85
PE
4096 * textprop.c (property_change_between_p): Remove; unused.
4097
fc7bf025
PE
4098 * intervals.c (interval_start_pos): Now static.
4099
235d7abc
PE
4100 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4101
44f230aa
SM
4102 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4103 Rename locals to avoid shadowing.
3e7d6594 4104
50060332
PE
4105 * sound.c (wav_play, au_play, Fplay_sound_internal):
4106 Fix pointer signedness.
d01f234b 4107 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4108 (wav_play): Initialize a variable to 0, to prevent undefined
4109 behavior (Bug#8278).
50060332 4110
c4fc4e30
PE
4111 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4112
918436ed
PE
4113 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4114
c939f91b
PE
4115 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4116 clobbering (Bug#8298).
b9c7f648
PE
4117 * sysdep.c (sys_subshell): Likewise.
4118 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4119
6bd8c144
PE
4120 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4121 This should get cleaned up, so that child_setup has the
4122 same signature on all platforms.
4123
7710357c 4124 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4125 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4126
c59da222
CY
41272011-03-22 Chong Yidong <cyd@stupidchicken.com>
4128
4129 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4130 not to be necessary, and produces flickering.
4131
66b87493
GM
41322011-03-20 Glenn Morris <rgm@gnu.org>
4133
4134 * config.in: Remove file.
4135
45b6f6d5
JB
41362011-03-20 Juanma Barranquero <lekktu@gmail.com>
4137
4138 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4139 are now in src/globals.h.
4140 (syms_of_minibuf): Remove spurious & from previous change.
4141
3ec03f7e
LL
41422011-03-20 Leo <sdl.web@gmail.com>
4143
4144 * minibuf.c (completing-read-function): New variable.
4145 (completing-read-default): Rename from completing-read.
4146 (completing-read): Call completing-read-function.
4147
b14e3e21
CY
41482011-03-19 Juanma Barranquero <lekktu@gmail.com>
4149
4150 * xfaces.c (Fx_load_color_file):
4151 Read color file from absolute filename (bug#8250).
4152
f2b726e6
JB
41532011-03-19 Juanma Barranquero <lekktu@gmail.com>
4154
4155 * makefile.w32-in: Update dependencies.
4156
09f6ff02
EZ
41572011-03-17 Eli Zaretskii <eliz@gnu.org>
4158
4159 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4160
29a6015a
PE
41612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4162
a3a6c54e
PE
4163 Fix more problems found by GCC 4.5.2's static checks.
4164
b766f867
PE
4165 * process.c (make_serial_process_unwind, send_process_trap):
4166 (sigchld_handler): Now static.
4167
be02381c
PE
4168 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4169 That way, the code declares only the vars that it needs.
4170 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4171 * s/cygwin.h (PTY_ITERATION): Likewise.
4172 * s/darwin.h (PTY_ITERATION): Likewise.
4173 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4174
57048744
PE
4175 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4176 * process.c (allocate_pty): Don't declare stb unless it's needed.
4177
7914961c 4178 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4179 (CONSTANTLIM): Remove; unused.
4180 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4181 Define only if needed.
7914961c 4182
b3967b18
PE
4183 * unexelf.c (unexec): Name an expression,
4184 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4185 Use a different way to cause a compilation error if anyone uses
4186 n rather than nn, a way that does not involve shadowing.
73366a00 4187 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4188
29a6015a
PE
4189 * deps.mk (unexalpha.o): Remove; unused.
4190
43cfc33e 4191 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4192 * unexec.h: New file.
ce701a33
PE
4193 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4194 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4195 Depend on unexec.h.
4196 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4197 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4198 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4199 Change as necessary to match prototype in unexec.h.
ce701a33 4200
01f44d5a
PE
4201 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4202 shadowing.
4f63c6bb 4203 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4204
a6670b0b
PE
4205 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4206 Rename locals to avoid shadowing.
4207
cef2010d 4208 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4209 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4210
d4d7173a
PE
4211 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4212
f08b802a
PE
4213 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4214 warning when compiling print.c.
4215
3ddb0639
PE
4216 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4217 instead of using an uninitialized var.
5ad03b97 4218 (font_sort_entities): Mark var as initialized.
3ddb0639 4219
170a2692
PE
4220 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4221
e663c700
PE
4222 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4223 pointers to constants.
89bc529a 4224 (font_parse_fcname): Remove unused vars.
7b81e2d0 4225 (font_delete_unmatched): Now static.
ea838e10 4226 (font_get_spec): Remove; unused.
13a547c6
PE
4227 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4228 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4229 Rename or move locals to avoid shadowing.
e663c700 4230
2a80c887 4231 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4232 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4233
1384fa33 4234 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4235 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4236
8b2c52e9
PE
4237 * alloc.c (mark_backtrace): Move decl from here ...
4238 * lisp.h: ... to here, so that it can be checked.
4239
475545b5 4240 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4241 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4242 (lisp_indirect_variable): Name an expression,
4243 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4244 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4245
b1349114 4246 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4247 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4248 Use const pointer when appropriate.
b1349114 4249
a2928364
PE
4250 * lisp.h (get_system_name, get_operating_system_release):
4251 Move decls here, to check interfaces.
4252 * process.c (get_operating_system_release): Move decl to lisp.h.
4253 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4254 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4255 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4256 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4257 (Fformat_time_string, Fencode_time, Finsert_char):
4258 (Ftranslate_region_internal, Fformat):
4259 Rename or remove local vars to avoid shadowing.
9710023e 4260 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4261
a415e694
PE
4262 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4263 avoid shadowing.
4264
8ef4622d
PE
4265 * lisp.h (eassert): Check that the argument compiles, even if
4266 ENABLE_CHECKING is not defined.
4267
946f9a5b
PE
4268 * data.c (Findirect_variable): Name an expression, to avoid
4269 gcc -Wbad-function-cast warning.
112396d6 4270 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4271 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4272 (Fmake_variable_buffer_local, Fmake_local_variable):
4273 Mark variables as initialized.
52746918 4274 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4275
e5aab7e7 4276 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4277 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4278 Rename locals to avoid shadowing.
dff45157
PE
4279 (mark_stack): Move local variables into the #ifdef region where
4280 they're used.
7bc26fdb
PE
4281 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4282 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4283 needed otherwise.
4284 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4285 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4286 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4287
e5aab7e7
PE
4288 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4289 avoids undefined behavior in theory.
4290
4da60324
PE
4291 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4292
88043301
PE
4293 Use functions, not macros, for up- and down-casing (Bug#8254).
4294 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4295 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4296 to use the following functions instead of these macros.
4297 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4298 EMACS_INT, since callers assume the returned value fits in int.
4299 (upcase1): Likewise, for UPCASE_TABLE.
4300 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4301 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4302 the race-condition problem in the old DOWNCASE.
88043301 4303
19ed5445
PE
4304 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4305 Rename locals to avoid shadowing.
4306 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4307 (regex_compile, re_search_2, re_match_2_internal):
4308 Remove unused local vars.
952db0d7
PE
4309 (FREE_VAR): Rewrite so as not to use empty "else",
4310 which gcc can warn about.
da053e48 4311 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4312 (RETALLOC_IF): Define only if needed.
4313 (WORDCHAR_P): Likewise. This one is never needed, but is used
4314 only in a comment talking about a compiler bug, so put inside
4315 the #if 0 of that comment.
4316 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4317 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4318 Remove; unused.
19ed5445 4319
1f3561e4 4320 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4321 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4322 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4323
ded6f8f7
PE
4324 * search.c (simple_search): Remove unused var.
4325
dbd37a95
PE
4326 * dired.c (compile_pattern): Move decl from here ...
4327 * lisp.h: ... to here, so that it can be checked.
4328 (struct re_registers): New forward decl.
4329
7e47afad
PE
4330 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4331
85f24f61
PE
4332 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4333 All uses changed.
4334 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4335 Rename locals to avoid shadowing.
5671df8f 4336 (Fvertical_motion): Mark locals as initialized.
85f24f61 4337
181aa2be 4338 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4339 (casify_region): Mark local as initialized.
181aa2be 4340
930d429c
PE
4341 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4342
7082eac6
PE
4343 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4344 New macros, so that the caller can use some names other than
4345 gcpro1, gcpro2, etc.
4346 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4347 of the new macros.
4348 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4349 argument, for consistency with GCPRO2_VAR, etc: it is now the
4350 prefix of the variable, not the variable itself. All uses
4351 changed.
38b2c076
PE
4352 * dired.c (directory_files_internal, file_name_completion):
4353 Rename locals to avoid shadowing.
4354
15206ed9
PE
4355 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4356 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4357 dired.c's scmp function, had undefined behavior.
4358 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4359 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4360 * buffer.h: ... to here, because these macros use current_buffer,
4361 and the new implementation with inline functions needs to have
4362 current_buffer in scope now, rather than later when the macros
4363 are used.
4364 (downcase, upcase1): New static inline functions.
4365 (DOWNCASE, UPCASE1): Reimplement using these functions.
4366 This avoids undefined behavior in expressions like
4367 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4368 from race conditions in accessing the global variables
4369 case_temp1 and case_temp2.
4370 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4371 * lisp.h (case_temp1, case_temp2): Remove their decls.
4372 * character.h (ASCII_CHAR_P): Move from here ...
4373 * lisp.h: ... to here, so that the inline functions mentioned
4374 above can use them.
4375
4a6bea26
PE
4376 * dired.c (directory_files_internal_unwind): Now static.
4377
f14b7e14
PE
4378 * fileio.c (file_name_as_directory, directory_file_name):
4379 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4380 Now static.
2893f146
PE
4381 (file_name_as_directory): Use const pointers when appropriate.
4382 (Fexpand_file_name): Likewise. In particular, newdir might
4383 point at constant storage, so make it a const pointer.
fd4ead52 4384 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4385 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4386 signedness issues.
f839df0c
PE
4387 (Fset_file_times, Finsert_file_contents, auto_save_error):
4388 Rename locals to avoid shadowing.
f14b7e14 4389
5716756e 4390 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4391 (Ftry_completion, Fall_completions): Rename or remove locals
4392 to avoid shadowing.
5716756e 4393
b4c3046a
PE
4394 * marker.c (bytepos_to_charpos): Remove; unused.
4395
b45db522
PE
4396 * lisp.h (verify_bytepos, count_markers): New decls,
4397 so that gcc does not warn that these functions aren't declared.
4398
85876d07
PE
4399 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4400 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4401 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4402 (copy_text): Remove unused local var.
85876d07 4403
03d78a21 4404 * filelock.c (within_one_second): Now static.
b3dd38ab 4405 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4406
5df8f01b
PE
4407 * buffer.c (fix_overlays_before): Mark locals as initialized.
4408 (fix_start_end_in_overlays): Likewise. This function should be
4409 simplified by using pointers-to-pointers, but that's a different
4410 matter.
b1d876f1 4411 (switch_to_buffer_1): Now static.
8f54f30a
PE
4412 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4413 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4414
a70072c9 4415 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4416 Fix pointer signedness issue.
edced198
PE
4417 (sys_subshell): Mark local as volatile if checking for lint,
4418 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4419 (MAXPATHLEN): Define only if needed.
a70072c9 4420
a0977c44
PE
4421 * process.c (serial_open, serial_configure): Move decls from here ...
4422 * systty.h: ... to here, so that they can be checked.
4423
a884fdcc
PE
4424 * fns.c (get_random, seed_random): Move extern decls from here ...
4425 * lisp.h: ... to here, so that they can be checked.
4426
604efe86 4427 * sysdep.c (reset_io): Now static.
b8950c94 4428 (wait_for_termination_signal): Remove; unused.
604efe86 4429
38fc62d9
PE
4430 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4431 (copy_keymap_item, append_key, push_text_char_description):
4432 Now static.
1004a21a 4433 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4434 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4435 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4436 (describe_map_tree):
4437 Rename locals to avoid shadowing.
38fc62d9 4438
2f2650da
PE
4439 * keyboard.c: Declare functions static if they are not used elsewhere.
4440 (echo_char, echo_dash, cmd_error, top_level_2):
4441 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4442 (read_char, kbd_buffer_get_event, make_lispy_position):
4443 (make_lispy_event, make_lispy_movement, apply_modifiers):
4444 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4445 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4446 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4447 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4448 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4449
a053e86c 4450 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4451 (mark_kboards): Move decl here ...
4452 * alloc.c (mark_kboards): ... from here.
a053e86c 4453
4752793e
PE
4454 * lisp.h (force_auto_save_soon): New decl.
4455
74f10ca7 4456 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4457 (DEFINE_DUMMY_FUNCTION): New macro.
4458 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4459 Use it.
c03cd23f
PE
4460 (main): Add casts to avoid warnings
4461 if GCC considers string literals to be constants.
74f10ca7 4462
022e70d4
PE
4463 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4464
59d6fe83
PE
4465 * dbusbind.c: Pointer signedness fixes.
4466 (xd_signature, xd_append_arg, xd_initialize):
4467 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4468 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4469 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4470 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4471
78320123
PE
4472 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4473 if GCC considers string literals to be constants.
49cebcca 4474 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4475
35ac2a97
SM
44762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4477
fb103ca9
SM
4478 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4479 (print_preprocess, print_object): New macro to fix last change.
4480
35ac2a97
SM
4481 * print.c (print_preprocess): Don't forget font objects.
4482
62973b41
JB
44832011-03-16 Juanma Barranquero <lekktu@gmail.com>
4484
4485 * emacs.c (USAGE3): Doc fixes.
4486
0e48bb22
AS
44872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4488
4489 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4490 structure.
4491
7684e57b
JB
44922011-03-14 Juanma Barranquero <lekktu@gmail.com>
4493
4494 * lisp.h (VWindow_system, Qfile_name_history):
4495 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4496 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4497 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4498
4499 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4500 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4501
4502 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4503 * w32console.c (detect_input_pending, read_input_pending)
4504 (encode_terminal_code):
4505 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4506 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4507 (w32_system_caret_y, Qfile_name_history):
4508 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4509 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4510 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4511 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4512 * w32proc.c (Qlocal, report_file_error):
4513 * w32term.c (Vwindow_system, updating_frame):
4514 * w32uniscribe.c (initialized, uniscribe_font_driver):
4515 Remove unneeded extern declarations.
4516
2aa46d6c
CY
45172011-03-14 Chong Yidong <cyd@stupidchicken.com>
4518
c96bbc66 4519 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4520
cffc6f3b
CY
45212011-03-13 Chong Yidong <cyd@stupidchicken.com>
4522
4523 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4524 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4525 These macros can no longer be used for assignment.
4526
44f230aa
SM
4527 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4528 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4529 (record_buffer_markers, fetch_buffer_markers): New functions for
4530 recording and fetching special buffer markers.
4531 (set_buffer_internal_1, set_buffer_temp): Use them.
4532
4533 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4534
4535 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4536
4537 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4538 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4539
4540 * xdisp.c (hscroll_window_tree):
4541 (reconsider_clip_changes): Use PT instead of BUF_PT.
4542
d251f04b
EZ
45432011-03-13 Eli Zaretskii <eliz@gnu.org>
4544
4545 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4546 $(EMACS_ROOT)/lib/intprops.h.
4547
f0c77cd1
PE
45482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4549
3eca4629
PE
4550 Fix more problems found by GCC 4.5.2's static checks.
4551
7c86ee98
PE
4552 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4553 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4554 (xg_free_frame_widgets): Make it clear that a local variable is
4555 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4556 (gdk_window_get_screen): Make it clear that this macro is needed
4557 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4558 (int_gtk_range_get_value): New function, which avoids a diagnostic
4559 from gcc -Wbad-function-cast.
4560 (xg_set_toolkit_scroll_bar_thumb): Use it.
4561 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4562 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4563 (get_utf8_string, xg_get_file_with_chooser):
4564 Rename locals to avoid shadowing.
4565 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4566
41729b81
PE
4567 * xgselect.c (xg_select): Remove unused var.
4568
f0c77cd1
PE
4569 * image.c (four_corners_best): Mark locals as initialized.
4570 (gif_load): Initialize transparent_p to zero (Bug#8238).
4571 Mark another local as initialized.
ec6cf4c6 4572 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4573
ce0ad53d 4574 * image.c (clear_image_cache): Now static.
d5d5a617 4575 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4576 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4577 (x_edge_detection): Remove unnecessary cast that
4578 gcc -Wbad-function-cast diagnoses.
2037898d 4579 (gif_load): Fix pointer signedness.
6ae141d6
PE
4580 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4581 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4582
33383987 45832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4584
d32df629
PE
4585 Improve quality of tests for time stamp overflow.
4586 For example, without this patch (encode-time 0 0 0 1 1
4587 1152921504606846976) returns the obviously-bogus value (-948597
4588 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4589 reports time overflow. See
4590 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4591 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4592 * editfns.c: Include limits.h and intprops.h.
4593 (TIME_T_MIN, TIME_T_MAX): New macros.
4594 (time_overflow): Move earlier, to before first use.
4595 (hi_time, lo_time): New functions, for an accurate test for
4596 out-of-range times.
4597 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4598 (Fget_internal_run_time): Don't assume time_t fits in int.
4599 (make_time): Use list2 instead of Fcons twice.
4600 (Fdecode_time): More accurate test for out-of-range times.
4601 (check_tm_member): New function.
4602 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4603 (lisp_time_argument): Don't rely on undefined left-shift and
4604 right-shift behavior when checking for time stamp overflow.
8be6f318 4605
fe31d94c
PE
4606 * editfns.c (time_overflow): New function, refactoring common code.
4607 (Fformat_time_string, Fdecode_time, Fencode_time):
4608 (Fcurrent_time_string): Use it.
4609
8be6f318
PE
4610 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4611 * dired.c (make_time): Move to ...
4612 * editfns.c (make_time): ... here.
4613 * systime.h: Note the move.
4614
09d9db2c 46152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4616
126bc0dc
YM
4617 * fringe.c (update_window_fringes): Remove unused variables.
4618
c47cbdfd
YM
4619 * unexmacosx.c (copy_data_segment): Also copy __got section.
4620 (Bug#8223)
4621
7ac80be9
EZ
46222011-03-12 Eli Zaretskii <eliz@gnu.org>
4623
c96bbc66 4624 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4625 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4626 Constify `char *' arguments and their references according to
4627 prototypes in tparam.h.
4628
ecb0f94d 4629 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4630
7ac80be9
EZ
4631 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4632 Adapt all references accordingly.
4633
4634 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4635
ef1fd07e
TT
46362011-03-11 Tom Tromey <tromey@redhat.com>
4637
4638 * buffer.c (syms_of_buffer): Remove obsolete comment.
4639
7ef4b50c
EZ
46402011-03-11 Eli Zaretskii <eliz@gnu.org>
4641
4642 * termhooks.h (encode_terminal_code): Declare prototype.
4643
4644 * msdos.c (encode_terminal_code): Don't declare prototype.
4645
4646 * term.c (encode_terminal_code): Now external again, used by
4647 w32console.c and msdos.c.
4648
44f230aa
SM
4649 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4650 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4651
4b1ec863 46522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4653
1714f52b 4654 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4655
4b1ec863
PE
4656 * fringe.c (update_window_fringes): Mark locals as initialized
4657 (Bug#8227).
4658 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4659
524c7aa6
PE
4660 * alloc.c (mark_fringe_data): Move decl from here ...
4661 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4662 to check its interface.
4663 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4664
a5c0af81 4665 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4666 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4667 (fontset_font): Mark local as initialized.
a9a06e0b 4668 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4669
b4716021
PE
4670 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4671
811e9bac 4672 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4673 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4674 (x_own_selection, Fx_disown_selection_internal): Rename locals
4675 to avoid shadowing.
4676 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4677
7e3ab302
PE
4678 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4679 so that the caller can use some name other than gcpro1.
4680 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4681 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4682 (Fx_backspace_delete_keys_p):
4683 Use them to avoid shadowing, and rename vars to avoid shadowing.
4684 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4685 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4686 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4687 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4688 Remove unused locals.
7e3ab302
PE
4689 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4690 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4691 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4692 macros.
f78faa98 4693
e2b13473
PE
4694 * xterm.h (x_mouse_leave): New decl.
4695
77f23912
PE
4696 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4697 Remove unused functions.
cdf4ba58
PE
4698 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4699 (x_calc_absolute_position): Now static.
7411c686 4700 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4701 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4702 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4703 unless they are used.
38d0b34a
PE
4704 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4705 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4706 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4707 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4708 (x_error_catcher, x_connection_closed, x_error_handler):
4709 (x_error_quitter, xembed_send_message, x_iconify_frame):
4710 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4711 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4712 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4713
44f230aa
SM
4714 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4715 Rename or move locals to avoid shadowing.
6b463e58 4716 (tty_defined_color, merge_face_heights): Now static.
5967d051 4717 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4718 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4719 does not deduce is never used uninitialized.
73719eba
PE
4720 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4721 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4722
426994c3 4723 * terminal.c (store_terminal_param): Now static.
5489860b 4724
032f1620 4725 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4726 (set_frame_menubar): Remove unused local.
d4323972 4727 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4728 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4729 since they might point to immutable storage.
281585b0
PE
4730 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4731 since it's unused otherwise.
032f1620 4732
367c19e5 4733 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4734 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4735 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4736 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4737 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4738 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4739 does not deduce are never used uninitialized.
70739cbe 4740
07b48fa9
PE
4741 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4742
8868a238 4743 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4744 * window.c (window_loop, size_window):
4745 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4746
7e5cf297 4747 * window.c (display_buffer): Now static.
d6550a9f
PE
4748 (size_window): Mark variables that gcc -Wuninitialized
4749 does not deduce are never used uninitialized.
a586633d
PE
4750 * window.h (check_all_windows): New decl, to forestall
4751 gcc -Wmissing-prototypes diagnostic.
5b555da1 4752 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4753
f6095868
PE
4754 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4755 shadowing.
4756 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4757 Include <limits.h>.
4758 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4759 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4760 (load_charset_map): Mark variables that gcc -Wuninitialized
4761 does not deduce are never used uninitialized.
53df7c11 4762 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4763
f38b440c
PE
4764 * coding.c (coding_set_source, coding_set_destination):
4765 Use "else { /* comment */ }" rather than "else /* comment */;"
4766 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4767 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4768 a block, when the outer 'i' will do.
4769 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4770 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4771 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4772 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4773 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4774 Rename locals to avoid shadowing.
4775 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4776 * coding.c (emacs_mule_char, encode_invocation_designation):
4777 Now static, since they're not used elsewhere.
413bb2db 4778 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4779 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4780 (decode_coding_emacs_mule): Mark variables that gcc
4781 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4782 (detect_coding_iso_2022): Initialize a local variable that might
4783 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4784 this initialization is needed. (Bug#8211)
5f58e762
PE
4785 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4786 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4787 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4788 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4789 Remove unused macros.
f38b440c 4790
232b38b9 4791 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4792 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4793 * character.c (string_count_byte8): Likewise.
232b38b9 4794
fb90da1b
PE
4795 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4796 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4797
fb93dbc2
PE
4798 * chartab.c (copy_sub_char_table): Now static, since it's not used
4799 elsewhere.
5c156ace
PE
4800 (sub_char_table_ref_and_range, char_table_ref_and_range):
4801 Rename locals to avoid shadowing.
bbcd0949 4802 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4803
7d3b3862 4804 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4805 (BIDI_BOB): Remove unused macro.
7d3b3862 4806
6be7d3da
PE
4807 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4808 deduce are never used uninitialized.
c2ed9c8b 4809 * term.c (encode_terminal_code): Likewise.
6be7d3da 4810
75f8807f 4811 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4812
50938595
PE
4813 * tparam.h: New file.
4814 * term.c, tparam.h: Include it.
4815 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4816 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4817 Move these decls to tparam.h, and make them agree with what
4818 is actually in tparam.c. The previous trick of using incompatible
4819 decls in different modules does not conform to the C standard.
4820 All callers of tparam changed to use tparam's actual API.
4821 * tparam.c (tparam1, tparam, tgoto):
4822 Use const pointers where appropriate.
4823
fbceeba2
PE
4824 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4825 * cm.h (struct cm): Likewise.
4826 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4827 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4828 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4829 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4830 (turn_on_face, init_tty): Likewise.
4831 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4832
7f3f1250
PE
4833 * term.c (term_mouse_position): Rename local to avoid shadowing.
4834
e6ca6543
PE
4835 * alloc.c (mark_ttys): Move decl from here ...
4836 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4837
c40f8d15
AS
48382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4839
4840 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4841
cfe0661d
JB
48422011-03-09 Juanma Barranquero <lekktu@gmail.com>
4843
4844 * search.c (compile_pattern_1): Remove argument regp, unused since
4845 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4846 (compile_pattern): Don't pass it.
4847
0afb4571
J
48482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4849
4850 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4851 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4852 for ! HAVE_GTK3.
4853 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4854
4855 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4856
4857 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4858 gdk_window_get_screen, gdk_window_get_geometry,
4859 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4860 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4861 (xg_get_pixbuf_from_pixmap): New function.
4862 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4863 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4864 Call xg_get_pixbuf_from_pixmap instead of
4865 gdk_pixbuf_get_from_drawable.
4866 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4867 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4868 (xg_check_special_colors): Use GtkStyleContext and its functions
4869 for HAVE_GTK3.
4870 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4871 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4872 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4873 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4874 Call gtk_widget_get_preferred_size.
0afb4571
J
4875 (xg_frame_resized): gdk_window_get_geometry only takes 5
4876 parameters.
44f230aa
SM
4877 (xg_win_to_widget, xg_event_is_for_menubar):
4878 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4879 (xg_set_widget_bg): New function.
4880 (delete_cb): New function.
895009e1 4881 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4882 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4883 (xg_set_background_color): Call xg_set_widget_bg.
4884 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4885 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4886 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4887 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4888 if ! HAVE_GTK3.
4889 (update_frame_tool_bar): Call gtk_widget_hide.
4890 (xg_initialize): Use GDK_KEY_g.
4891
4892 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4893 if ! HAVE_GTK3
4894 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4895
4896 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4897 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4898 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4899
1c2cc4ef
JB
49002011-03-08 Juanma Barranquero <lekktu@gmail.com>
4901
4902 * w32xfns.c (select_palette): Check success of RealizePalette against
4903 GDI_ERROR, not zero.
4904
33383987 4905See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4906
4907;; Local Variables:
4908;; coding: utf-8
aac0c6e3
MR
4909;; End:
4910
33383987 4911 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4912
4913 This file is part of GNU Emacs.
4914
4915 GNU Emacs is free software: you can redistribute it and/or modify
4916 it under the terms of the GNU General Public License as published by
4917 the Free Software Foundation, either version 3 of the License, or
4918 (at your option) any later version.
4919
4920 GNU Emacs is distributed in the hope that it will be useful,
4921 but WITHOUT ANY WARRANTY; without even the implied warranty of
4922 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4923 GNU General Public License for more details.
4924
4925 You should have received a copy of the GNU General Public License
4926 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.