Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0766b489
PE
12011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2
b79e8648
PE
3 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4
0766b489
PE
5 * dispextern.h (struct face.stipple):
6 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7 (x_bitmap_mask, x_allocate_bitmap_record)
8 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10 (x_create_bitmap_from_xpm_data):
11 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
12 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13 (.bitmaps_last):
14 * xfaces.c (load_pixmap):
15 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
16 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
17 (.bitmaps_last, struct x_output.icon_bitmap):
18 Use ptrdiff_t, not int, for bitmap indexes.
19 (x_allocate_bitmap_record): Check for size overflow.
20 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
21
b081724f
PE
22 Use ptrdiff_t, not int, for overlay counts.
23 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
24 * editfns.c (overlays_around, get_pos_property):
25 * textprop.c (get_char_property_and_overlay):
26 * xdisp.c (next_overlay_change, note_mouse_highlight):
27 * xfaces.c (face_at_buffer_position):
21514da7
PE
28 * buffer.c (OVERLAY_COUNT_MAX): New macro.
29 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
30 (Fnext_overlay_change, Fprevious_overlay_change)
31 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 32 Use ptrdiff_t, not int, for sizes.
21514da7 33 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 34
3de73e5e
PE
35 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
36
2606c57b
PE
37 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
38 (x_session_initialize): Do not assume string length fits in int.
39
aaafe47a
PE
40 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
41 This is unlikely, but can occur if DPI is outlandish.
42
2674ddc8 43 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
44 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
45
28154962
PE
46 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
47 * xrdb.c (magic_file_p, search_magic_path):
48 Omit last arg SUFFIX; it was always 0. All callers changed.
49 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
50
7de51af5
PE
51 * xfont.c (xfont_match): Avoid need for strlen.
52
25ed6cc3
PE
53 * xfns.c: Don't assume strlen fits in int.
54 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
55
4eab31dd
PE
56 * xdisp.c (message_log_check_duplicate): Return intmax_t,
57 not unsigned long, as we prefer signed integers. All callers changed.
58 Detect integer overflow in repeat count.
59 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 60 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 61
171e2a58
PE
62 * termcap.c: Don't assume sizes fit in int and never overflow.
63 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
64 (gobble_line): Check for size-calculation overflow.
65
ad39faca 66 * minibuf.c (Fread_buffer):
6e5bb2dc 67 * lread.c (intern, intern_c_string):
74ca2eb3
PE
68 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
69 Don't assume string length fits in int.
70
52c61c22 71 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
72 * gtkutil.c (style_changed_cb): Avoid need for strlen.
73
b5b8c9e5
PE
74 * font.c: Don't assume string length fits in int.
75 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
76 Use ptrdiff_t, not int.
ccd6111c
PE
77 (font_intern_prop): Don't assume string length fits in int.
78 Don't assume integer property fits in fixnum.
79 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 80
882f0d81 81 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 82 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
83 Reformulate so as not to need the command string.
84 Invoke gzip -cd rather than gunzip, as it's more portable.
85 (lock_info_type, lock_file_1, lock_file):
86 Don't assume pid_t and time_t fit in unsigned long.
87 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
88 (current_lock_owner): Prefer signed type for sizes.
89 Use memcpy, not strncpy, where memcpy is what is really wanted.
90 Don't assume (via atoi) that time_t and pid_t fit in int.
91 Check for time_t and/or pid_t out of range, e.g., via a network share.
92 Don't alloca where an auto var works fine.
93
93f4cf88
PE
94 * fileio.c: Fix some integer overflow issues.
95 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
96 Don't assume string length fits in int.
97 (directory_file_name): Don't assume string length fits in long.
98 (make_temp_name): Don't assume pid fits in int, or that its print
99 length is less than 20.
100
f3e92b69
PE
101 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
102
1bfdaf10
PE
103 * coding.c (make_subsidiaries): Don't assume string length fits in int.
104
35016e9a
PE
105 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
106
3d1e65a1
PE
107 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
108 We prefer signed integers, even for size calculations.
109
0b963a93
PE
110 * emacs.c: Don't assume string length fits in 'int'.
111 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
112 (main): Don't invoke strlen when not needed.
113
573f4b54
PE
114 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
115 (XD_DEBUG_MESSAGE): Don't waste a byte.
116
989f33ba
PE
117 * callproc.c (getenv_internal_1, getenv_internal)
118 (Fgetenv_internal):
965d34eb
PE
119 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
120
e4d29b33
PE
121 * lread.c (invalid_syntax): Omit length argument.
122 All uses changed. This doesn't fix a bug, but it simplifies the
123 code away from its former Hollerith-constant appearance, and it's
124 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 125 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 126
eb49b136
PE
127 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
128 This didn't break anything, but it didn't help either.
129 It's confusing to put a bogus integer in a place where the actual
130 value does not matter.
9f62aeb1 131 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 132 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 133
15375a22
PE
134 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
135 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
136 implementation.
b61cc01c
PE
137 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
138 We prefer signed types, and the value cannot exceed the EMACS_INT
139 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
140 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
141 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
142 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 143
53b2623d
PE
144 * indent.c (sane_tab_width): New function.
145 (current_column, scan_for_column, Findent_to, position_indentation)
146 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 147 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 148
51cab52b 149 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 150
f2ed8a70
PE
151 * lisp.h (lint_assume): New macro.
152 * composite.c (composition_gstring_put_cache):
153 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
154
abe80cc6
PE
155 * editfns.c, insdel.c:
156 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 157
b02c740e
PE
158 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
159
ebc96716
PE
160 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
161
b4e50fa0 162 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 163 Use much-faster test for byte-length change.
311d5d7c 164 Don't assume string byte-length fits in 'int'.
a4cf38e4 165 Check that character arg fits in 'int'.
85461888 166 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 167
c0c1ee9f
PE
168 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
169
a498d7f4
PE
170 * fns.c (concat): Catch string overflow earlier.
171 Do not rely on integer wraparound.
172
51cab52b
PE
173 * dispextern.h (struct it.overlay_strings_charpos)
174 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
175 * xdisp.c (forward_to_next_line_start)
176 (back_to_previous_visible_line_start)
177 (reseat_at_next_visible_line_start, next_element_from_buffer):
178 Don't arbitrarily truncate the value of 'selective' to int.
179
76031fad
PE
180 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
181
5eb55db9
PE
182 * composite.c: Don't truncate sizes to 'int'.
183 (composition_gstring_p, composition_reseat_it)
184 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
185 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
186 not EMACS_UINT, for indexes.
5eb55db9 187
0703a717
PE
188 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
189
d6202519
PE
190 * buffer.c: Include <verify.h>.
191 (struct sortvec.priority, struct sortstr.priority):
8961a454 192 Now EMACS_INT, not int.
c20998a7 193 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
194 (struct sortstr.size, record_overlay_string)
195 (struct sortstrlist.size, struct sortlist.used):
196 Don't truncate size to int.
197 (record_overlay_string): Check for size-calculation overflow.
d6202519 198 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 199
d5a19415
JM
2002011-06-22 Jim Meyering <meyering@redhat.com>
201
202 don't leak an XBM-image-sized buffer
203 * image.c (xbm_load): Free the image buffer after using it.
204
a9041e6c
PE
2052011-06-21 Paul Eggert <eggert@cs.ucla.edu>
206
207 Port to Sun C.
208 * composite.c (find_automatic_composition): Omit needless 'return 0;'
209 that Sun C diagnosed.
210 * fns.c (secure_hash): Fix pointer signedness issue.
211 * intervals.c (static_offset_intervals): New function.
212 (offset_intervals): Use it.
213
7f3f739f
LL
2142011-06-21 Leo Liu <sdl.web@gmail.com>
215
216 * deps.mk (fns.o):
217 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
218 sha512.h.
219
220 * fns.c (secure_hash): Rename from crypto_hash_function and change
221 the first arg to accept symbols.
222 (Fsecure_hash): New primtive.
223 (syms_of_fns): New symbols.
224
76147d94
DD
2252011-06-20 Deniz Dogan <deniz@dogan.se>
226
227 * process.c (Fset_process_buffer): Clarify return value in
228 docstring.
229
7d7d0045
CY
2302011-06-18 Chong Yidong <cyd@stupidchicken.com>
231
232 * dispnew.c (add_window_display_history): Use BVAR.
233
234 * xdisp.c (debug_method_add): Use BVAR.
235 (check_window_end, dump_glyph_matrix, dump_glyph)
236 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
237
238 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
239 Likewise.
240
241 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
242 check till after the cache is created in init_frame_faces.
243
ff2bc410
SM
2442011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
245
246 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
247
28177add
PE
2482011-06-16 Paul Eggert <eggert@cs.ucla.edu>
249
dd3482fe
PE
250 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
251 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
252 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
253
393d71f3 254 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
255 * fileio.c (Finsert_file_contents):
256 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
257 Remove the old (too-loose) buffer overflow checks.
258 They weren't needed, since make_gap checks for buffer overflow.
259 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
260 The old code merely checked for Emacs fixnum overflow, and relied
261 on undefined (wraparound) behavior. The new code avoids undefined
262 behavior, and also checks for ptrdiff_t and/or size_t overflow.
263
2e6813b0 264 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
265 Tune. Don't use wider integers than needed. Don't use alloca.
266 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 267
599a9e4f
PE
268 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
269
99561444
PE
270 * insdel.c, lisp.h (buffer_overflow): New function.
271 (insert_from_buffer_1, replace_range, replace_range_2):
272 * insdel.c (make_gap_larger):
273 * editfns.c (Finsert_char):
274 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
275
28177add
PE
276 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
277
e69dafad
PE
2782011-06-15 Paul Eggert <eggert@cs.ucla.edu>
279
a7af7fde 280 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 281
b1c46f02
PE
282 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
283 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
284
e69dafad
PE
285 * fileio.c: Don't assume EMACS_INT fits in off_t.
286 (emacs_lseek): New static function.
287 (Finsert_file_contents, Fwrite_region): Use it.
288 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
289
566684ea
PE
290 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
291
e6966cd6
PE
292 * fns.c: Don't overflow int when computing a list length.
293 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
294 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
295 truncation on 64-bit hosts. Check for QUIT every
296 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
297 faster and is responsive enough.
298 (Flength): Report an error instead of overflowing an integer.
299 (Fsafe_length): Return a float if the value is not representable
300 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 301 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 302 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 303
dd0b0efb
PE
304 * alloc.c: Check that resized vectors' lengths fit in fixnums.
305 (header_size, word_size): New constants.
306 (allocate_vectorlike): Don't check size overflow here.
307 (allocate_vector): Check it here instead, since this is the only
308 caller of allocate_vectorlike that could cause overflow.
309 Check that the new vector's length is representable as a fixnum.
310
86fe5cfe
PE
311 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
312 The previous code was bogus. For example, next_almost_prime (32)
313 returned 39, which is undesirable as it is a multiple of 3; and
314 next_almost_prime (24) returned 25, which is a multiple of 5 so
315 why was the code bothering to check for multiples of 7?
316
80e88859
PE
317 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
318
4a2f0ad6
PE
319 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
320
f66c7cf8
PE
321 Variadic C functions now count arguments with ptrdiff_t.
322 This partly undoes my 2011-03-30 change, which replaced int with size_t.
323 Back then I didn't know that the Emacs coding style prefers signed int.
324 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
325 were being counted with int, which may truncate counts on 64-bit
326 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
327 * lisp.h (struct Lisp_Subr.function.aMANY)
328 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
329 Arg counts are now ptrdiff_t, not size_t.
330 All variadic functions and their callers changed accordingly.
331 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
332 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
333 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
334 * callint.c (Fcall_interactively): Check arg count for overflow,
335 to avoid potential buffer overrun. Use signed char, not 'int',
336 for 'varies' array, so that we needn't bother to check its size
337 calculation for overflow.
338 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
339 * eval.c (apply_lambda):
340 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
341 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
342 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
343
a1759b76
PE
344 * callint.c (Fcall_interactively): Don't use index var as event count.
345
d96be9fc
PE
346 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
347 * mem-limits.h (SIZE): Remove; no longer used.
348
a690a978 349 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 350
578c21e6
PE
351 Remove unnecessary casts.
352 * xterm.c (x_term_init):
353 * xfns.c (x_set_border_pixel):
354 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
355 These aren't needed now that we assume ANSI C.
356
96f53c6c
PE
357 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
358 It's more likely to cause problems (due to unsigned overflow)
359 than to cure them.
360
83c77d31
PE
361 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
362
ee2079f1
PE
363 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
364
6da65536
PE
365 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
366
7147c4a4
PE
367 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
368
193e32d9
PE
369 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
370
e5533da6
PE
371 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
372
9910e595
PE
373 GLYPH_CODE_FACE returns EMACS_INT, not int.
374 * dispextern.h (merge_faces):
375 * xfaces.c (merge_faces):
01103c44
PE
376 * xdisp.c (get_next_display_element, next_element_from_display_vector):
377 Don't assume EMACS_INT fits in int.
9910e595 378
2638320e
PE
379 * character.h (CHAR_VALID_P): Remove unused parameter.
380 * fontset.c, lisp.h, xdisp.c: All uses changed.
381
045eb8d9
PE
382 * editfns.c (Ftranslate_region_internal): Omit redundant test.
383
c1f134b5
PE
384 * fns.c (concat): Minor tuning based on overflow analysis.
385 This doesn't fix any bugs. Use int to hold character, instead
386 of constantly refetching from Emacs object. Use XFASTINT, not
387 XINT, for value known to be a character. Don't bother comparing
388 a single byte to 0400, as it's always less.
389
395fcb93 390 * floatfns.c (Fexpt):
327eeec8
PE
391 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
392
abbd3d23
PE
393 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
394 for characters.
395
684a03ef
PE
396 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
397
0fed43f3
PE
398 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
399 Without this fix, on a 64-bit host (aset S 0 4294967386) would
400 incorrectly succeed when S was a string, because 4294967386 was
401 truncated before it was used.
402
8fd02eb7
PE
403 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
404 Otherwise, an out-of-range integer could cause undefined behavior
405 on a 64-bit host.
406
f8c86b69
PE
407 * composite.c: Use int, not EMACS_INT, for characters.
408 (fill_gstring_body, composition_compute_stop_pos): Use int, not
409 EMACS_INT, for values that are known to be in character range.
410 This doesn't fix any bugs but is the usual style inside Emacs and
411 may generate better code on 32-bit machines.
412
34206dd2
PE
413 Make sure a 64-bit char is never passed to ENCODE_CHAR.
414 This is for reasons similar to the recent CHAR_STRING fix.
415 * charset.c (Fencode_char): Check that character arg is actually
416 a character. Pass an int to ENCODE_CHAR.
417 * charset.h (ENCODE_CHAR): Verify that the character argument is no
418 wider than 'int', as a compile-time check to prevent future regressions
419 in this area.
420
c5958d4c 421 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
422
423 Make sure a 64-bit char is never passed to CHAR_STRING.
424 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
425 by silently ignoring the top 32 bits, allowing some values
426 that were far too large to be valid characters.
427 * character.h: Include <verify.h>.
428 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
429 arguments are no wider than unsigned, as a compile-time check
430 to prevent future regressions in this area.
431 * data.c (Faset):
01103c44 432 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
433 (Fsubst_char_in_region):
434 * fns.c (concat):
435 * xdisp.c (decode_mode_spec_coding):
436 Adjust to CHAR_STRING's new requirement.
437 * editfns.c (Finsert_char, Fsubst_char_in_region):
438 * fns.c (concat): Check that character args are actually
439 characters. Without this test, these functions did the wrong
440 thing with wildly out-of-range values on 64-bit hosts.
441
d37ca623
PE
442 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
443 These casts should not be needed on 32-bit hosts, either.
444 * keyboard.c (read_char):
445 * lread.c (Fload): Remove casts to unsigned.
446
ea204efb
PE
447 * lisp.h (UNSIGNED_CMP): New macro.
448 This fixes comparison bugs on 64-bit hosts.
449 (ASCII_CHAR_P): Use it.
450 * casefiddle.c (casify_object):
01103c44 451 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
452 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
453 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
454 * dispextern.h (FACE_FROM_ID):
455 * keyboard.c (read_char): Use UNSIGNED_CMP.
456
41cb286c
PE
457 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
458 not to EMACS_INT, to avoid GCC warning.
459
4a1b9832
PE
460 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
461
55daad71
PE
462 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
463 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
464 isn't needed on 32-bit machines.
8f95c75c 465
01103c44
PE
466 * buffer.c (Fgenerate_new_buffer_name):
467 Use EMACS_INT for count, not int.
0ceccced 468 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
469
470 * data.c (Qcompiled_function): Now static.
471
c6f072e7
PE
472 * window.c (window_body_lines): Now static.
473
20ce5912
PE
474 * image.c (gif_load): Rename local to avoid shadowing.
475
9c4c5f81
PE
476 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
477 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
478 * alloc.c (make_save_value): Integer argument is now of type
479 ptrdiff_t, not int.
480 (mark_object): Use ptrdiff_t, not int.
481 * lisp.h (pD): New macro.
482 * print.c (print_object): Use it.
483
c0c5c8ae
PE
484 * alloc.c: Use EMACS_INT, not int, to count objects.
485 (total_conses, total_markers, total_symbols, total_vector_size)
486 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
487 (total_free_floats, total_floats, total_free_intervals)
488 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
489 Now EMACS_INT, not int. All uses changed.
490 (Fgarbage_collect): Compute overall total using a double, so that
491 integer overflow is less likely to be a problem. Check for overflow
492 when converting back to an integer.
5a25e253
PE
493 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
494 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
495 These were 'int' variables that could overflow on 64-bit hosts;
496 they were never used, so remove them instead of repairing them.
211a0b2a 497 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
498 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
499 Previously, this ceilinged at INT_MAX, but that doesn't work on
500 64-bit machines.
e46bb31a 501 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 502
c78baabf 503 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 504 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
505 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
506 when a (possibly-narrower) signed value would do just as well.
507 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 508
c9d624c6
PE
509 * alloc.c: Catch some string size overflows that we were missing.
510 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
511 for convenience in STRING_BYTES_MAX.
512 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
513 The definition here is exact; the one in lisp.h was approximate.
514 (allocate_string_data): Check for string overflow. This catches
515 some instances we weren't catching before. Also, it catches
516 size_t overflow on (unusual) hosts where SIZE_MAX <= min
517 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
518 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 519
c9d624c6
PE
520 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
521 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
522 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
523
353032ce
PE
524 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
525
2bccce07
PE
526 * alloc.c (Fmake_string): Check for out-of-range init.
527
0ac30604
SM
5282011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
529
530 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
531
c195f2de
JD
5322011-06-14 Jan Djärv <jan.h.d@swipnet.se>
533
534 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
535 xg_get_default_scrollbar_width.
536
537 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
538 (int_gtk_range_get_value): Move to the scroll bar part of the file.
539 (style_changed_cb): Call update_theme_scrollbar_width and call
540 x_set_scroll_bar_default_width and xg_frame_set_char_size for
541 all frames (Bug#8505).
542 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
543 Call gtk_window_set_resizable if HAVE_GTK3.
544 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
545 and height if HAVE_GTK3 (Bug#8505).
546 (scroll_bar_width_for_theme): New variable.
547 (update_theme_scrollbar_width): New function.
548 (xg_get_default_scrollbar_width): Move code to
549 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
550 (xg_initialize): Call update_theme_scrollbar_width.
551
552 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
553
554 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
555
e10ac9f1
MR
5562011-06-12 Martin Rudalics <rudalics@gmx.at>
557
558 * frame.c (make_frame): Call other_buffer_safely instead of
559 other_buffer.
560
561 * window.c (temp_output_buffer_show): Call display_buffer with
562 second argument Vtemp_buffer_show_specifiers and reset latter
563 immediately after the call.
564 (Vtemp_buffer_show_specifiers): New variable.
565 (auto_window_vscroll_p, next_screen_context_lines)
566 (Vscroll_preserve_screen_position): Remove leading asterisks from
567 doc-strings.
568
2d3c217e 5692011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 570
7b7f97e8 571 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
572 * buffer.c (Qclone_number): Remove for now, as it's unused.
573 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
574 (record_buffer): Remove unused local.
575 * frame.c (other_visible_frames, frame_buffer_list): Now static.
576 (set_frame_buffer_list): Remove; unused.
577 * frame.h (other_visible_frames): Remove decl.
578 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
579 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
580 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
581 if HAVE_GPM.
582 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
583 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
584 Define only if HAVE_GPM.
585 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
586 (update_hints_inhibit): Remove; never set. All uses removed.
587 * widgetprv.h (emacsFrameClassRec): Remove decl.
588 * window.c (delete_deletable_window): Now returns void, since it
589 wasn't returning anything.
590 (compare_window_configurations): Remove unused locals.
591 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
592 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
593 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
594 the same widths as pointers. This follows up on the 2011-05-06 patch.
595 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
596 * xterm.h: Likewise.
597 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
598
1384b89e
JB
5992011-06-12 Juanma Barranquero <lekktu@gmail.com>
600
601 * makefile.w32-in: Update dependencies.
602 (LISP_H): Add lib/intprops.h.
603
1100a63c
CY
6042011-06-11 Chong Yidong <cyd@stupidchicken.com>
605
606 * image.c (gif_load): Add animation frame delay to the metadata.
607 (syms_of_image): Use DEFSYM. New symbol `delay'.
608
6198ccd0
MR
6092011-06-11 Martin Rudalics <rudalics@gmx.at>
610
611 * window.c (delete_deletable_window): Re-add.
612 (Fset_window_configuration): Rewrite to handle dead buffers and
613 consequently deletable windows.
614 (window_tree, Fwindow_tree): Remove. Supply functionality in
615 window.el.
616 (compare_window_configurations): Simplify code.
617
b6e3633c
AS
6182011-06-11 Andreas Schwab <schwab@linux-m68k.org>
619
1ab0dee5
AS
620 * image.c (imagemagick_load_image): Fix type mismatch.
621 (Fimagemagick_types): Likewise.
622
b6e3633c
AS
623 * window.h (replace_buffer_in_windows): Declare.
624
9397e56f
MR
6252011-06-11 Martin Rudalics <rudalics@gmx.at>
626
627 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
628 Qclone_number. Remove external declaration of Qdelete_window.
629 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
630 code.
631 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
632 Qbuffer_list_update_hook if allowed.
633 (Fother_buffer): Rewrite doc-string. Major rewrite for new
634 buffer list implementation.
635 (other_buffer_safely): New function.
636 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
637 calls to replace_buffer_in_windows and
638 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
639 if allowed.
640 (record_buffer): Inhibit quitting and rewrite using quittable
641 functions. Run Qbuffer_list_update_hook if allowed.
642 (Frecord_buffer, Funrecord_buffer): New functions.
643 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
644 switch-to-buffer to window.el.
645 (bury-buffer): Move to window.el.
646 (Vbuffer_list_update_hook): New variable.
647
648 * lisp.h (other_buffer_safely): Add prototype in buffer.c
649 section.
650
651 * window.h (resize_frame_windows): Move up in code.
652 (Fwindow_frame): Remove EXFUN.
653 (replace_buffer_in_all_windows): Remove prototype.
654 (replace_buffer_in_windows_safely): Add prototype.
655
656 * window.c: Declare Qdelete_window static again. Move down
657 declaration of select_count.
658 (Fnext_window, Fprevious_window): Rewrite doc-strings.
659 (Fother_window): Move to window.el.
660 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
661 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
662 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
663 window.el.
664 (replace_buffer_in_windows): Implement by calling
665 Qreplace_buffer_in_windows.
666 (replace_buffer_in_all_windows): Remove with some functionality
667 moved into replace_buffer_in_windows_safely.
668 (replace_buffer_in_windows_safely): New function.
669 (select_window_norecord, select_frame_norecord): Move in front
670 of run_window_configuration_change_hook. Remove now obsolete
671 declarations.
672 (Fset_window_buffer): Rewrite doc-string. Call
673 Qrecord_window_buffer.
674 (keys_of_window): Move binding for other-window to window.el.
675
b50691aa
CY
6762011-06-11 Chong Yidong <cyd@stupidchicken.com>
677
678 * dispextern.h (struct image): Replace data member, whose int_val
679 and ptr_val fields were not used by anything, with a single
680 lisp_val object.
681
682 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
683 (gif_clear_image, gif_load, imagemagick_load_image)
684 (gs_clear_image, gs_load): Callers changed.
685
3f754b86
PE
6862011-06-10 Paul Eggert <eggert@cs.ucla.edu>
687
cca69397
PE
688 * buffer.h: Include <time.h>, for time_t.
689 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
690
109e28d0
PE
691 Fix minor problems found by static checking.
692
60737f02
PE
693 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
694
4b66faf3
PE
695 Make identifiers static if they are not used in other modules.
696 * data.c (Qcompiled_function, Qframe, Qvector):
697 * image.c (QimageMagick, Qsvg):
698 * minibuf.c (Qmetadata):
699 * window.c (resize_window_check, resize_root_window): Now static.
700 * window.h (resize_window_check, resize_root_window): Remove decls.
701
109e28d0
PE
702 * window.c (window_deletion_count, delete_deletable_window):
703 Remove; unused.
46a4ce9e
PE
704 (window_body_lines): Now static.
705 (Fdelete_other_windows_internal): Mark vars as initialized.
706 Make sure 'resize_failed' is initialized.
707 (run_window_configuration_change_hook): Rename local to avoid shadowing.
708 (resize_window_apply): Remove unused local.
709 * window.h (delete_deletable_window): Remove decl.
710
109e28d0 711 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
712 (imagemagick_load_image): Fix pointer signedness problem by changing
713 last arg from unsigned char * to char *. All uses changed.
714 Also, fix a local for similar reasons.
715 Remove unused locals. Remove locals to avoid shadowing.
716 (fn_rsvg_handle_free): Remove; unused.
717 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 718 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 719
3f754b86
PE
720 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
721
2547adb1
CY
7222011-06-10 Chong Yidong <cyd@stupidchicken.com>
723
724 * image.c (gif_load): Fix omitted cast error introduced by
725 2011-06-06 change.
726
2c8e37d4
MR
7272011-06-10 Martin Rudalics <rudalics@gmx.at>
728
729 * window.h (resize_proportionally, orig_total_lines)
730 (orig_top_line): Remove from window structure.
731 (set_window_height, set_window_width, change_window_heights)
732 (Fdelete_window): Remove prototypes.
733 (resize_frame_windows): Remove duplicate declaration.
734
440a42e3
EZ
7352011-06-10 Eli Zaretskii <eliz@gnu.org>
736
737 * window.h (resize_frame_windows, resize_window_check)
738 (delete_deletable_window, resize_root_window)
739 (resize_frame_windows): Declare prototypes.
740
741 * window.c (resize_window_apply): Make definition be "static" to
742 match the prototype.
743
562dd5e9
MR
7442011-06-10 Martin Rudalics <rudalics@gmx.at>
745
746 * window.c: Remove declarations of Qwindow_size_fixed,
747 window_min_size_1, window_min_size_2, window_min_size,
748 size_window, window_fixed_size_p, enlarge_window, delete_window.
749 Remove static from declaration of Qdelete_window, it's
750 temporarily needed by Fbury_buffer.
751 (replace_window): Don't assign orig_top_line and
752 orig_total_lines.
753 (Fdelete_window, delete_window): Remove. Window deletion is
754 handled by window.el.
755 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
756 Fdelete_window calls with calls to Qdelete_window.
757 (Fdelete_other_windows): Remove. Deleting other windows is
758 handled by window.el.
759 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
760 handled in window.el.
761 (window_min_size_2, window_min_size_1, window_min_size): Remove.
762 Window minimum sizes are handled in window.el.
763 (shrink_windows, size_window, set_window_height)
764 (set_window_width, change_window_heights, window_height)
765 (window_width, CURBEG, CURSIZE, enlarge_window)
766 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
767 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
768 handled in window.el.
769 (make_dummy_parent): Rename to make_parent_window and give it a
770 second argument horflag.
771 (make_window): Don't set resize_proportionally any more.
772 (Fsplit_window): Remove. Windows are split in window.el.
773 (save_restore_action, save_restore_orig_size)
774 (shrink_window_lowest_first, save_restore_orig_size): Remove.
775 Resize mini windows in window.el.
776 (grow_mini_window, shrink_mini_window): Implement by calling
777 Qresize_root_window_vertically, resize_window_check and
778 resize_window_apply.
779 (saved_window, Fset_window_configuration, save_window_save): Do
780 not handle orig_top_line, orig_total_lines, and
781 resize_proportionally.
782 (window_min_height, window_min_width): Move to window.el.
783 (keys_of_window): Move bindings for delete-other-windows,
784 split-window, delete-window and enlarge-window to window.el.
785
786 * buffer.c: Temporarily extern Qdelete_window.
787 (Fbury_buffer): Temporarily call Qdelete_window instead of
788 Fdelete_window (Fbury_buffer will move to window.el soon).
789
790 * frame.c (set_menu_bar_lines_1): Remove code handling
791 orig_top_line and orig_total_lines.
792
793 * dispnew.c (adjust_frame_glyphs_initially): Don't use
794 set_window_height but set heights directly.
795 (change_frame_size_1): Use resize_frame_windows.
796
797 * xdisp.c (init_xdisp): Don't use set_window_height but set
798 heights directly.
799
800 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
801 resize_frame_windows instead of change_window_heights and run
802 run_window_configuration_change_hook.
803
804 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
805 instead of change_window_heights and run
806 run_window_configuration_change_hook.
807
1a13852e
MR
8082011-06-09 Martin Rudalics <rudalics@gmx.at>
809
810 * window.c (replace_window): Rename second argument REPLACEMENT to
811 NEW. New third argument SETFLAG. Rewrite.
812 (delete_window, make_dummy_parent): Call replace_window with
813 third argument 1.
814 (window_list_1): Move down in code.
815 (run_window_configuration_change_hook): Move set_buffer part
816 before select_frame_norecord part in order to unwind correctly.
817 Rename count1 to count.
818 (recombine_windows, delete_deletable_window, resize_root_window)
819 (Fdelete_other_windows_internal)
820 (Frun_window_configuration_change_hook, make_parent_window)
821 (resize_window_check, resize_window_apply, Fresize_window_apply)
822 (resize_frame_windows, Fsplit_window_internal)
823 (Fdelete_window_internal, Fresize_mini_window_internal): New
824 functions.
825 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
826
f3d1777e
MR
8272011-06-08 Martin Rudalics <rudalics@gmx.at>
828
496e208e
MR
829 * window.h (window): Add some new members to window structure -
830 normal_lines, normal_cols, new_total, new_normal, clone_number,
831 splits, nest, prev_buffers, next_buffers.
832 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 833 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 834
f3d1777e
MR
835 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
836 Remove.
496e208e
MR
837 (make_dummy_parent): Set new members of windows structure.
838 (make_window): Move down in code. Handle new members of window
839 structure.
840 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
841 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
842 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
843 (Fset_window_prev_buffers, Fwindow_next_buffers)
844 (Fset_window_next_buffers, Fset_window_clone_number): New
845 functions.
846 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
847 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
848 Doc-string fixes.
849 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
850 Argument WINDOW can be now internal window too.
851 (Fwindow_use_time): Move up in code.
852 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
853 Rewrite doc-string.
854 (Fset_window_configuration, saved_window)
855 (Fcurrent_window_configuration, save_window_save): Handle new
856 members of window structure.
b9e809c2
MR
857 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
858 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
859 (syms_of_window): New Lisp objects Qrecord_window_buffer,
860 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
861 Qget_mru_window, Qresize_root_window,
862 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
863 Qauto_buffer_name; staticpro them.
f3d1777e 864
abde8f8c
MR
8652011-06-07 Martin Rudalics <rudalics@gmx.at>
866
867 * window.c (Fwindow_total_size, Fwindow_left_column)
868 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
869 (Fwindow_list_1): New functions.
870 (window_box_text_cols): Replace with window_body_cols.
871 (Fwindow_width, Fscroll_left, Fscroll_right): Use
872 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
873 (delete_window, Fset_window_configuration): Call
874 delete_all_subwindows with window as argument.
875 (delete_all_subwindows): Take a window as argument and not a
876 structure. Rewrite.
190b47e6
MR
877 (window_loop): Remove handling of GET_LRU_WINDOW and
878 GET_LARGEST_WINDOW.
879 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
880
881 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
882 window_box_text_cols. delete_all_subwindows now takes a
883 Lisp_Object as argument.
abde8f8c
MR
884
885 * indent.c (compute_motion, Fcompute_motion): Use
886 window_body_cols instead of window_box_text_cols.
887
fa8a67e6
MR
888 * frame.c (delete_frame): Call delete_all_subwindows with root
889 window as argument.
890
a54e3482
DC
8912011-06-07 Daniel Colascione <dan.colascione@gmail.com>
892
893 * fns.c (Fputhash): Document return value.
894
60002bf5
CY
8952011-06-06 Chong Yidong <cyd@stupidchicken.com>
896
897 * image.c (gif_load): Implement gif89a spec "no disposal" method.
898
0c671da6 8992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 900
b862a52a 901 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 902
be44ca6c
PE
903 Check for overflow when converting integer to cons and back.
904 * charset.c (Fdefine_charset_internal, Fdecode_char):
905 Use cons_to_unsigned to catch overflow.
906 (Fencode_char): Use INTEGER_TO_CONS.
907 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
908 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
909 * data.c (long_to_cons, cons_to_long): Remove.
910 (cons_to_unsigned, cons_to_signed): New functions.
911 These signal an error for invalid or out-of-range values.
912 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
913 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
914 * font.c (Ffont_variation_glyphs):
915 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
916 * lisp.h: Include <intprops.h>.
917 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
918 (cons_to_signed, cons_to_unsigned): New decls.
919 (long_to_cons, cons_to_long): Remove decls.
920 * undo.c (record_first_change): Use INTEGER_TO_CONS.
921 (Fprimitive_undo): Use CONS_TO_INTEGER.
922 * xfns.c (Fx_window_property): Likewise.
923 * xselect.c: Include <limits.h>.
924 (x_own_selection, selection_data_to_lisp_data):
925 Use INTEGER_TO_CONS.
926 (x_handle_selection_request, x_handle_selection_clear)
927 (x_get_foreign_selection, Fx_disown_selection_internal)
928 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
929 (lisp_data_to_selection_data): Use cons_to_unsigned.
930 (x_fill_property_data): Use cons_to_signed.
931 Report values out of range.
932
d1f3d2af
PE
933 Check for buffer and string overflow more precisely.
934 * buffer.h (BUF_BYTES_MAX): New macro.
935 * lisp.h (STRING_BYTES_MAX): New macro.
936 * alloc.c (Fmake_string):
937 * character.c (string_escape_byte8):
938 * coding.c (coding_alloc_by_realloc):
939 * doprnt.c (doprnt):
940 * editfns.c (Fformat):
941 * eval.c (verror):
942 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
943 since they may not be the same number.
944 * editfns.c (Finsert_char):
945 * fileio.c (Finsert_file_contents):
946 Likewise for BUF_BYTES_MAX.
947
dd52fcea
PE
948 * image.c: Use ptrdiff_t, not int, for sizes.
949 (slurp_file): Switch from int to ptrdiff_t.
950 All uses changed.
951 (slurp_file): Check that file size fits in both size_t (for
952 malloc) and ptrdiff_t (for sanity and safety).
953
7f9bbdbb
PE
954 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
955 if b->modtime has its maximal value.
956
dfe18f82
PE
957 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
958
84acfcf0
PE
959 Don't assume time_t can fit into int.
960 * buffer.h (struct buffer.modtime): Now time_t, not int.
961 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
962 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
963
ccd9a01a
PE
964 Minor fixes for signed vs unsigned integers.
965 * character.h (MAYBE_UNIFY_CHAR):
966 * charset.c (maybe_unify_char):
967 * keyboard.c (read_char, reorder_modifiers):
968 XINT -> XFASTINT, since the integer must be nonnegative.
969 * ftfont.c (ftfont_spec_pattern):
970 * keymap.c (access_keymap, silly_event_symbol_error):
971 XUINT -> XFASTINT, since the integer must be nonnegative.
972 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
973 since it makes no difference and we prefer signed.
974 * keyboard.c (record_char): Use XUINT when all the neighbors do.
975 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
976 nonnegative.
977
d6d100dd
SM
9782011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
979
980 * window.h (Fwindow_frame): Declare.
981
2b6148e4
PE
9822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
983
984 * alloc.c: Simplify handling of large-request failures (Bug#8800).
985 (SPARE_MEMORY): Always define.
986 (LARGE_REQUEST): Remove.
987 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
988
f230ecc9
MR
9892011-06-06 Martin Rudalics <rudalics@gmx.at>
990
727e958e
MR
991 * lisp.h: Move EXFUNS for Fframe_root_window,
992 Fframe_first_window and Fset_frame_selected_window to window.h.
993
994 * window.h: Move EXFUNS for Fframe_root_window,
995 Fframe_first_window and Fset_frame_selected_window here from
996 lisp.h.
997
998 * frame.c (Fwindow_frame, Fframe_first_window)
999 (Fframe_root_window, Fframe_selected_window)
1000 (Fset_frame_selected_window): Move to window.c.
1001 (Factive_minibuffer_window): Move to minibuf.c.
1002 (Fother_visible_frames_p): New function.
1003
1004 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1005
f230ecc9
MR
1006 * window.c (decode_window, decode_any_window): Move up in code.
1007 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1008 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1009 (Fwindow_buffer): Move up and rewrite doc-string.
1010 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1011 (Fwindow_prev): New functions.
727e958e
MR
1012 (Fwindow_frame): Move here from frame.c. Accept any window as
1013 argument.
1014 (Fframe_root_window, Fframe_first_window)
1015 (Fframe_selected_window): Move here from frame.c. Accept frame
1016 or arbitrary window as argument. Update doc-strings.
1017 (Fminibuffer_window): Move up in code.
1018 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1019 (Fset_frame_selected_window): Move here from frame.c.
1020 Marginal rewrite.
727e958e
MR
1021 (Fselected_window, select_window, Fselect_window): Move up in
1022 code. Minor doc-string fixes.
f230ecc9 1023
4d09bcf6
PE
10242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1027 Do not assume that spare memory exists; that assumption is valid
1028 only if SYSTEM_MALLOC.
1029 (LARGE_REQUEST): New macro, so that the issue of large requests
1030 is separated from the issue of spare memory.
1031
810928a2
AS
10322011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1033
172418ad
AS
1034 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1035 format. (Bug#8806)
1036
43f862f7
AS
1037 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1038
810928a2
AS
1039 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1040 before statements.
1041
a059fe24
JD
10422011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1043
1044 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1045
1046 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1047
1048 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1049 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1050
989bf368
JB
10512011-06-05 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1054
4b80f674
CY
10552011-06-04 Chong Yidong <cyd@stupidchicken.com>
1056
1057 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1058 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1059 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1060 New error handlers.
4b80f674
CY
1061 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1062 Obey Vx_select_enable_clipboard_manager. Catch errors in
1063 x_clipboard_manager_save (Bug#8779).
1064 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1065 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1066
99a33b77 10672011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1068
1069 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1070
99a33b77 10712011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1072
1073 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1074 in the current matrix if keep_current_p is non-zero.
1075
8264569d
EZ
10762011-06-04 Eli Zaretskii <eliz@gnu.org>
1077
1078 * bidi.c (bidi_level_of_next_char): Fix last change.
1079
57f97249
EZ
10802011-06-03 Eli Zaretskii <eliz@gnu.org>
1081
fec2107c 1082 Support bidi reordering of text covered by display properties.
57f97249 1083
fec2107c
EZ
1084 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1085 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1086 (bidi_cache_search, bidi_cache_iterator_state)
1087 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1088 (bidi_level_of_next_char, bidi_move_to_visually_next):
1089 Support character positions inside a run of characters covered by a
fec2107c
EZ
1090 display string.
1091 (bidi_paragraph_init, bidi_resolve_explicit_1)
1092 (bidi_level_of_next_char): Call bidi_fetch_char and
1093 bidi_fetch_char_advance instead of FETCH_CHAR and
1094 FETCH_CHAR_ADVANCE.
1095 (bidi_init_it): Initialize new members.
1096 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1097 definitions.
1098 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1099 instead of using explicit *_CHAR codes.
d6d100dd
SM
1100 (bidi_resolve_explicit, bidi_resolve_weak):
1101 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1102 bidirectional text is supported only in multibyte buffers.
1103 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1104 it to initialize the frame_window_p member of struct bidi_it.
1105 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1106 (bidi_resolve_explicit, bidi_resolve_weak)
1107 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1108 bidi_it->nchars is non-positive.
1109 (bidi_level_of_next_char): Don't try to lookup the cache for the
1110 next/previous character if nothing is cached there yet, or if we
1111 were just reseat()'ed to a new position.
c40e2fb2 1112
0e14fe90
EZ
1113 * xdisp.c (set_cursor_from_row): Set start and stop points
1114 according to the row's direction when priming the loop that looks
1115 for the glyph on which to display cursor.
1116 (single_display_spec_intangible_p): Function deleted.
1117 (display_prop_intangible_p): Reimplement to call
1118 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1119 Accept 3 additional arguments needed by handle_display_spec.
1120 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1121 values: lists, `(when COND...)' forms, etc.
1122 (single_display_spec_string_p): Support property values that are
1123 lists with the argument STRING its top-level element.
1124 (display_prop_string_p): Fix the condition for processing a
1125 property that is a list to be consistent with handle_display_spec.
fec2107c 1126 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1127 last portion of handle_display_prop.
1128 (compute_display_string_pos): Accept additional argument
1129 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1130 value of a `display' property is a "replacing spec".
1131 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1132 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1133 the display property, but just return a value indicating whether
1134 the display property will replace the characters it covers.
1135 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1136 frame_window_p members of struct bidi_it.
d6d100dd
SM
1137 (compute_display_string_pos, compute_display_string_end):
1138 New functions.
fec2107c
EZ
1139 (push_it): Accept second argument POSITION, where pop_it should
1140 jump to continue iteration.
1141 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1142
fec2107c
EZ
1143 * keyboard.c (adjust_point_for_property): Adjust the call to
1144 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1145
1146 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1147 (bidi_init_it): Update prototypes.
1148 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1149 (compute_display_string_pos, compute_display_string_end):
1150 Declare prototypes.
fec2107c
EZ
1151 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1152 EMACS_INT.
fc6f18ce 1153
40087514 11542011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1155
57f53182
PE
1156 Malloc failure behavior now depends on size of allocation.
1157 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1158 * lisp.h: Change signatures accordingly.
1159 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1160 All callers changed. (Bug#8762)
1161
1162 * gnutls.c: Use Emacs's memory allocators.
1163 Without this change, the gnutls library would invoke malloc etc.
1164 directly, which causes problems on non-SYNC_INPUT hosts, and which
1165 runs afoul of improving memory_full behavior. (Bug#8761)
1166 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1167 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1168 xfree instead of the default malloc, realloc, free.
1169 (Fgnutls_boot): No need to check for memory allocation failure,
1170 since xmalloc does that for us.
1171
ac32cd99 1172 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1173 * category.c (hash_get_category_set):
1174 * ccl.c (ccl_driver):
1175 * charset.c (Fdefine_charset_internal):
1176 * charset.h (struct charset.hash_index):
1177 * composite.c (get_composition_id, gstring_lookup_cache)
1178 (composition_gstring_put_cache):
1179 * composite.h (struct composition.hash_index):
1180 * dispextern.h (struct image.hash):
1181 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1182 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1183 (hashfn_equal, hashfn_user_defined, make_hash_table)
1184 (maybe_resize_hash_table, hash_lookup, hash_put)
1185 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1186 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1187 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1188 * image.c (make_image, search_image_cache, lookup_image)
1189 (xpm_put_color_table_h):
1190 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1191 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1192 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1193 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1194 * alloc.c (allocate_vectorlike):
1195 Check for overflow in vector size calculations.
1196 * ccl.c (ccl_driver):
1197 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1198 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1199 need to be updated by these changes.
40087514
PE
1200 * fns.c (make_hash_table, maybe_resize_hash_table):
1201 Check for integer overflow with large hash tables.
0de4bb68
PE
1202 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1203 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1204 (SXHASH_REDUCE): New macro.
1205 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1206 Use it instead of discarding useful hash info with large hash values.
1207 (sxhash_float): New function.
1208 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1209 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1210 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1211 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1212 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1213 Adjust signatures to match updated version of code.
1214 (consing_since_gc): Now EMACS_INT, since a single hash table can
1215 use more than INT_MAX bytes.
1216
698d32e2
DN
12172011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1218
1219 Make it possible to build with GCC-4.6+ -O2 -flto.
1220
1221 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1222
fd6fa53f
SM
12232011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1224
1225 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1226 Call minibuffer-inactive-mode.
1227
864db017
JB
12282011-05-31 Juanma Barranquero <lekktu@gmail.com>
1229
1230 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1231 Update dependencies.
1232
2ad0baf4
DN
12332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1234
1235 * data.c (init_data): Remove code for UTS, this system is not
1236 supported anymore.
1237
4fcc2638
DN
12382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1239
1240 Don't force ./temacs to start in terminal mode.
1241
1242 * frame.c (make_initial_frame): Initialize faces in all cases, not
1243 only when CANNOT_DUMP is defined.
1244 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1245
c56e0fd5
DN
12462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1247
1248 * dispnew.c (add_window_display_history): Use const for the string
1249 pointer. Remove declaration, not needed.
1250
333d54da 12512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1252
55d4c1b2 1253 Use 'inline', not 'INLINE'.
333d54da 1254 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1255 * alloc.c, fontset.c (INLINE): Remove.
1256 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1257 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1258 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1259 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1260 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1261
738db178
DN
12622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1263
1264 Make it possible to run ./temacs.
1265
1266 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1267 syms_of_callproc does the same thing. Remove test for
1268 "initialized", do it in the caller.
1269 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1270
620c53a6
SM
12712011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1272
1273 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1274 (read_minibuf): Use get_minibuffer.
1275 (syms_of_minibuf): Use DEFSYM.
1276 (Qmetadata): New var.
1277 * data.c (Qbuffer): Don't make it static.
1278 (syms_of_data): Use DEFSYM.
1279
e003a292
PE
12802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1283 (CCL_CODE_MIN): New macro.
1284
ed008a6d
PE
12852011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1286
3687c2ef
PE
1287 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1288
ed008a6d
PE
1289 * eval.c (Qdebug): Now static.
1290 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1291 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1292 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1293
d66c4c7c
CY
12942011-05-29 Chong Yidong <cyd@stupidchicken.com>
1295
1296 * image.c: Various fixes to ImageMagick code comments.
1297 (Fimagemagick_types): Doc fix.
1298
5fbc2025
PE
12992011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1300
0196f88a
PE
1301 Minor fixes prompted by GCC 4.6.0 warnings.
1302
1303 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1304
5fbc2025
PE
1305 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1306 (x_clipboard_manager_save_all): Move extern decl to ...
1307 * xterm.h: ... here, so that it can be checked for consistency.
1308
1dd3c2d9
CY
13092011-05-29 Chong Yidong <cyd@stupidchicken.com>
1310
1311 * xselect.c (x_clipboard_manager_save_frame)
1312 (x_clipboard_manager_save_all): New functions.
1313 (Fx_clipboard_manager_save): Lisp function deleted.
1314
1315 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1316 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1317
1318 * xterm.h: Update prototype.
1319
5ba6571d
WX
13202011-05-28 William Xu <william.xwl@gmail.com>
1321
1322 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1323 exiting (Bug#8239).
1324
3eaff834
JM
13252011-05-28 Jim Meyering <meyering@redhat.com>
1326
e1900994 1327 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1328 * fns.c (to_uchar): Define.
1329 (crypto_hash_function): Use it to convert some newly-signed
1330 variables to unsigned, to avoid sign-extension bugs. For example,
1331 without this change, (md5 "truc") would evaluate to
1332 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1333 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1334 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1335
0f6990a7
PE
13362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 Integer overflow fixes.
c8a9ca5a 1339
08686060
PE
1340 * dbusbind.c: Serial number integer overflow fixes.
1341 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1342 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1343 to hold a serial number that is too large for a fixnum.
1344 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1345 Check for serial numbers out of range. Decode any serial number
59568bf0 1346 that was so large that it became a float. (Bug#8722)
08686060 1347
2d1fc3c7
PE
1348 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1349 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1350 Use XFASTINT rather than XUINT when numbers are nonnegative.
1351 (xd_append_arg, Fdbus_method_return_internal):
1352 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1353 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1354 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1355 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1356 (Bug#8722)
2d1fc3c7 1357
c8a9ca5a
PE
1358 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1359
519e1d69
PE
1360 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1361
30569699
PE
1362 ccl: add integer overflow checks
1363 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1364 (IN_INT_RANGE): New macros.
1365 (ccl_driver): Use them to check for integer overflow when
1366 decoding a CCL program. Many of the new checks are whether XINT (x)
1367 fits in int; it doesn't always, on 64-bit hosts. The new version
1368 doesn't catch all possible integer overflows, but it's an
847044ea 1369 improvement. (Bug#8719)
30569699 1370
c11285dc
PE
1371 * alloc.c (make_event_array): Use XINT, not XUINT.
1372 There's no need for unsigned here.
1373
fdccd48e
PE
1374 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1375 This follows up to the 2011-05-06 change that substituted uintptr_t
1376 for EMACS_INT. This case wasn't caught back then.
1377
37910ab2
PE
1378 Rework Fformat to avoid integer overflow issues.
1379 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1380 now (part of C89). Include <verify.h>.
1381 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1382 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1383 (Fformat): Avoid the prepass trying to compute sizes; it was only
1384 approximate and thus did not catch overflow reliably. Instead, walk
1385 through the format just once, formatting and computing sizes as we go,
1386 checking for integer overflow at every step, and allocating a larger
1387 buffer as needed. Keep track separately whether the format is
1388 multibyte. Keep only the most-recently calculated precision, rather
1389 than them all. Record whether each argument has been converted to
1390 string. Use EMACS_INT, not int, for byte and char and arg counts.
1391 Support field widths and precisions larger than INT_MAX. Avoid
1392 sprintf's undefined behavior with conversion specifications such as %#d
1393 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1394 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1395 formatting out-of-range floating point numbers with int
1396 formats. (Bug#8668)
1397
2e6578fb
PE
1398 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1399
0ae6bdee
PE
1400 * data.c: Avoid integer truncation in expressions involving floats.
1401 * data.c: Include <intprops.h>.
1402 (arith_driver): When there's an integer overflow in an expression
1403 involving floating point, convert the integers to floating point
1404 so that the resulting value does not suffer from catastrophic
1405 integer truncation. For example, on a 64-bit host (* 4
1406 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1407 Do not rely on undefined behavior after integer overflow.
1408
de883a70
PE
1409 merge count_size_as_multibyte, parse_str_to_multibyte
1410 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1411 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1412 Check for integer overflow.
1413 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1414 since it's now a duplicate of the other. This is more of
1415 a character than a buffer op, so better that it's in character.c.
1416 * fns.c, print.c: Adjust to above changes.
1417
2ff916cb
PE
14182011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1419
1420 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1421
f1b54466
PE
14222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1423
fb1ac845
PE
1424 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1425 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1426 (x_clipboard_manager_save): Now static.
1427 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1428
f1b54466
PE
1429 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1430 (crypto_hash_function): Now static.
1431 Fix pointer signedness problems. Avoid unnecessary initializations.
1432
a9f737ee
CY
14332011-05-27 Chong Yidong <cyd@stupidchicken.com>
1434
1435 * termhooks.h (Vselection_alist): Make it terminal-local.
1436
1437 * terminal.c (create_terminal): Initialize it.
1438
1439 * xselect.c: Support for clipboard managers.
1440 (Vselection_alist): Move to termhooks.h as terminal-local var.
1441 (LOCAL_SELECTION): New macro.
1442 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1443 (symbol_to_x_atom): Remove gratuitous arg.
1444 (x_handle_selection_request, lisp_data_to_selection_data)
1445 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1446 (x_own_selection, x_get_local_selection, x_convert_selection):
1447 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1448 (some_frame_on_display): Delete unused function.
1449 (Fx_own_selection_internal, Fx_get_selection_internal)
1450 (Fx_disown_selection_internal, Fx_selection_owner_p)
1451 (Fx_selection_exists_p): New optional frame arg.
1452 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1453 (x_handle_selection_clear): Don't treat other terminals with the
1454 same keyboard specially. Use the terminal-local Vselection_alist.
1455 (x_clear_frame_selections): Use Frun_hook_with_args.
1456
1457 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1458
1459 * xterm.h: Add support for those atoms.
1460
e067f0c1
CY
14612011-05-26 Chong Yidong <cyd@stupidchicken.com>
1462
1463 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1464 (converted_selections, conversion_fail_tag): New global variables.
1465 (x_selection_request_lisp_error): Free the above.
1466 (x_get_local_selection): Remove unnecessary code.
1467 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1468 of converted selections stored in converted_selections.
1469 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1470 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1471 (x_convert_selection): New function.
1472 (x_handle_selection_event): Simplify.
1473 (x_get_foreign_selection): Don't ignore incoming requests while
1474 waiting for an answer; this will fail when we implement
1475 SAVE_TARGETS, and seems unnecessary anyway.
1476 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1477 (Vx_sent_selection_functions): Doc fix.
1478
0f4aebc0
LL
14792011-05-26 Leo Liu <sdl.web@gmail.com>
1480
1481 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1482
e61124cd
YM
14832011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1484
1485 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1486
1487 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1488 for fringe update if it has periodic bitmap.
1489 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1490 and fringe_bitmap_periodic_p.
1491
1492 * fringe.c (get_fringe_bitmap_data): New function.
1493 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1494 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1495 row. Mark glyph row for fringe update if periodicity changed.
1496
1497 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1498 for fringe update unless it has periodic bitmap.
1499
f16d9837
KH
15002011-05-25 Kenichi Handa <handa@m17n.org>
1501
1502 * xdisp.c (get_next_display_element): Set correct it->face_id for
1503 a static composition.
1504
e1b90ef6
LL
15052011-05-24 Leo Liu <sdl.web@gmail.com>
1506
1507 * deps.mk (fns.o):
1508 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1509
1510 * fns.c (crypto_hash_function, Fsha1): New function.
1511 (Fmd5): Use crypto_hash_function.
1512 (syms_of_fns): Add Ssha1.
1513
7400048f
PE
15142011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * gnutls.c: Remove unused macros.
1517 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1518 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1519 Remove macros that are defined and never used.
1520 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1521
abb71cf4
CY
15222011-05-22 Chong Yidong <cyd@stupidchicken.com>
1523
1524 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1525 (Fx_get_selection_internal): Minor cleanup.
1526 (Fx_own_selection_internal): Rename arguments for consistency with
1527 select.el.
1528
6307db39
PE
15292011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1532
f3d4e0a4
CY
15332011-05-22 Chong Yidong <cyd@stupidchicken.com>
1534
1535 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1536
4d8ade89
YM
15372011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1538
1539 * dispnew.c (scrolling_window): Don't exclude the case that the
1540 last enabled row in the desired matrix touches the bottom boundary.
1541
32078c8d
GM
15422011-05-21 Glenn Morris <rgm@gnu.org>
1543
1544 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1545 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1546 and add some more files.
32078c8d 1547
7285dc67
EZ
15482011-05-20 Eli Zaretskii <eliz@gnu.org>
1549
1550 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1551 report_file_error introduced by the change from 2011-05-07.
1552
89d1bd22
PE
15532011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * systime.h (Time): Define only if emacs is defined.
1556 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1557 where the include path doesn't have X11/X.h by default. See
1558 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1559
e23640bb 15602011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1561
1562 * composite.c (find_automatic_composition): Fix previous change.
1563
b9704ad9
GM
15642011-05-20 Glenn Morris <rgm@gnu.org>
1565
1566 * lisp.mk: New file, split from Makefile.in.
1567 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1568 (shortlisp): Remove.
1569 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1570
4a720484
GM
15712011-05-19 Glenn Morris <rgm@gnu.org>
1572
1573 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1574 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1575 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1576 (lisp): Set the order to that of loadup.el.
1577 (shortlisp): Make it a copy of $lisp.
1578 (SOME_MACHINE_LISP): Remove.
1579 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1580 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1581
a28d4396
KH
15822011-05-18 Kenichi Handa <handa@m17n.org>
1583
1584 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1585 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1586 (find_automatic_composition): Mostly rewrite for efficiency.
1587
a2b1fa8e
JB
15882011-05-18 Juanma Barranquero <lekktu@gmail.com>
1589
1590 * makefile.w32-in: Update dependencies.
1591
8e1f5610
CS
15922011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1593
1594 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1595 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1596
7025ee00 15972011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1598
cdfa6eab
PE
1599 Fix some integer overflow issues, such as string length overflow.
1600
06d6db33
PE
1601 * insdel.c (count_size_as_multibyte): Check for string overflow.
1602
2b4560a8
PE
1603 * character.c (lisp_string_width): Check for string overflow.
1604 Use EMACS_INT, not int, for string indexes and lengths; in
1605 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1606 the resulting string length overflows an EMACS_INT; instead,
1607 report a string overflow if no precision given. When checking for
1608 precision exhaustion, use a check that cannot possibly have
1609 integer overflow. (Bug#8675)
1610 * character.h (lisp_string_width): Adjust to new signature.
1611
cb93f9be
PE
1612 * alloc.c (string_overflow): New function.
1613 (Fmake_string): Use it. This doesn't change behavior, but saves
1614 a few bytes and will simplify future changes.
1615 * character.c (string_escape_byte8): Likewise.
1616 * lisp.h (string_overflow): New decl.
1617
1a1f3366
PE
1618 Fixups, following up to the user-interface timestamp change.
1619 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1620 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1621 * msdos.c (mouse_get_pos): Likewise.
1622 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1623 * w32gui.h (Time): Define by including "systime.h" rather than by
1624 declaring it ourselves. (Bug#8664)
1625
d4e3e4d3
PE
1626 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1627 * image.c (clear_image_cache): Likewise.
1628
f6a24d19
PE
1629 * term.c (term_mouse_position): Don't assume time_t wraparound.
1630
08dc5ae6
PE
1631 Be more systematic about user-interface timestamps.
1632 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1633 and sometimes 'EMACS_UINT', to represent these timestamps.
1634 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1635 This makes the code easier to follow, and makes it easier to catch
1636 integer overflow bugs such as Bug#8664.
1637 * frame.c (Fmouse_position, Fmouse_pixel_position):
1638 Use Time, not unsigned long, for user-interface timestamps.
1639 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1640 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1641 * keyboard.h (last_event_timestamp): Likewise.
1642 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1643 * menu.h (xmenu_show): Likewise.
1644 * term.c (term_mouse_position): Likewise.
1645 * termhooks.h (struct input_event.timestamp): Likewise.
1646 (struct terminal.mouse_position_hook): Likewise.
1647 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1648 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1649 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1650 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1651 what it was before.
1652 * menu.h, termhooks.h: Include "systime.h", for Time.
1653
8e55734a
PE
1654 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1655 Don't assume that the difference between two unsigned long values
1656 can fit into an integer. At this point, we know button_down_time
1657 <= event->timestamp, so the difference must be nonnegative, so
1658 there's no need to cast the result if double-click-time is
1659 nonnegative, as it should be; check that it's nonnegative, just in
1660 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1661 apart (about 25 days). (Bug#8664)
8e55734a 1662
841f1b75 1663 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1664 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1665
3e26f69c
PE
1666 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1667 that always fit in int. Use a sentinel instead of a counter, to
1668 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1669 * frame.h (struct frame): Use int for menu_bar_items_used
1670 instead of EMACS_INT, since it always fits in int.
3e26f69c 1671
5cc152c0
PE
1672 * menu.c (grow_menu_items): Check for int overflow.
1673
d89eb65e
PE
1674 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1675
5235bd3e
PE
1676 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1677 Before, the code was not consistent. These values cannot exceed
1678 2**31 - 1 so there's no need to make them unsigned.
1679 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1680 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1681 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1682 as modifiers.
1683 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1684
bc827e23
PE
1685 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1686 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1687 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1688 presumably because the widths might not match.
1689
78eb494e
PE
1690 * window.c (size_window): Avoid needless test at loop start.
1691
04f2d78b
CB
16922011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1693
1694 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1695
d2fc7e3d 16962011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1697
1698 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1699
d2fc7e3d 17002011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1701
1702 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1703 `width' to `bar_area_x' and `bar_area_width', respectively.
1704 (x_scroll_run): Take account of fringe background extension.
1705
04f2d78b
CB
1706 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1707 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1708 `bar_area_width', respectively.
1709 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1710 background extension.
1711
79b70037
GM
17122011-05-10 Jim Meyering <meyering@redhat.com>
1713
1714 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1715
2f142cc5
JB
17162011-05-10 Juanma Barranquero <lekktu@gmail.com>
1717
1718 * image.c (Finit_image_library): Return t for built-in image types,
1719 like pbm and xbm. (Bug#8640)
1720
57679c86
AS
17212011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1722
1723 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1724
888c9e86
EZ
17252011-05-07 Eli Zaretskii <eliz@gnu.org>
1726
b0512a1d
EZ
1727 * w32console.c (Fset_screen_color): Doc fix.
1728 (Fget_screen_color): New function.
1729 (syms_of_ntterm): Defsubr it.
1730
7285dc67
EZ
1731 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1732 unlink the temporary file if Fcall_process didn't create it in the
1733 first place.
1734 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1735 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1736 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1737 cue to call_process_cleanup not to close that handle.
1738
4d3fcc8e
BK
17392011-05-07 Ben Key <bkey76@gmail.com>
1740
1741 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1742 one of two shell specific rules, either bootstrap-temacs-CMD or
1743 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1744 to the previous implementation of the bootstrap-temacs rule.
1745 The bootstrap-temacs-CMD rule is similar to the previous
1746 implementation of the bootstrap-temacs rule except that it
1747 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1748 variable.
1749
1750 These changes, along with some changes to nt/configure.bat,
1751 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1752 earlier fix to add support for --cflags and --ldflags options
1753 that include quotes so that it works whether make uses cmd or
1754 sh as the shell.
1755
b4289b64
MA
17562011-05-06 Michael Albinus <michael.albinus@gmx.de>
1757
1758 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1759 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1760 is a constant.
1761 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1762 a string. Handle both cases.
1763 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1764 (Fdbus_register_method): Use Qinvalid_function.
1765
af4c0e28
JB
17662011-05-06 Juanma Barranquero <lekktu@gmail.com>
1767
1768 * makefile.w32-in: Update dependencies.
1769 (LISP_H): Add inttypes.h and stdin.h.
1770 (PROCESS_H): Add unistd.h.
1771
c51453d9
EZ
17722011-05-06 Eli Zaretskii <eliz@gnu.org>
1773
1774 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1775 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1776
8ff0ac3c 17772011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1778
4c4b566b
PE
1779 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1780
aab2b9b5
PE
1781 * term.c (vfatal): Remove stray call to va_end.
1782 It's not needed and the C Standard doesn't allow it here anyway.
1783
c378da0b
PE
1784 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1785 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1786
288b08c7
PE
1787 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1788 bytes.
1789
e3601888
PE
1790 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1791
db6c0e74
PE
1792 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1793
dd5963ea
PE
1794 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1795
88c9450f
PE
1796 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1797
2f9442b8
PE
1798 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1799
c032b5f8
PE
1800 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1801 * charset.c (Fdefine_charset_internal): Don't initialize
1802 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1803 32-bit int (Bug#8600).
a108c10b
PE
1804
1805 * lread.c (read_integer): Be more consistent with string-to-number.
1806 Use string_to_number to do the actual conversion; this avoids
1807 rounding errors and fixes some other screwups. Without this fix,
1808 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1809 (digit_to_number): Move earlier, for benefit of read_integer.
1810 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1811 not a digit in any supported base. (Bug#8602)
a108c10b 1812
ad5f9eea
PE
1813 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1814
aec1708a
PE
1815 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1816 to match comment at start of function. This also removes a
1817 GCC warning about overflow in a 32+64-bit port.
1818
47be4ab5
PE
1819 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1820
371cac43
PE
1821 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1822 Reported by Stefan Monnier in
1823 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1824 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1825 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1826
d01a7826
PE
1827 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1828 (EMACS_UINTPTR): Likewise, with uintptr_t.
1829
7fd47d5c
PE
1830 * lisp.h: Prefer 64-bit EMACS_INT if available.
1831 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1832 on 32-bit hosts that have 64-bit int, so that they can access
1833 large files.
122b0c86
PE
1834 However, temporarily disable this change unless the temporary
1835 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1836
8727937b
PE
1837 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1838
8ac068ac
PE
1839 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1840 This removes an assumption that EMACS_INT and long are the same
1841 width as pointers. The assumption is true for Emacs porting targets
1842 now, but we want to make other targets possible.
1843 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1844 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1845 In the rest of the code, change types of integers that hold casted
1846 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1847 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1848 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1849 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1850 No need to cast type when ORing.
1851 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1852 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1853 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1854 assume EMACS_INT is the same width as char *.
1855 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1856 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1857 Remove no-longer-needed casts.
1858 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1859 (xg_tool_bar_help_callback, xg_make_tool_item):
1860 Use EMACS_INTPTR to hold an integer
1861 that will be cast to void *; this can avoid a GCC warning
1862 if EMACS_INT is not the same width as void *.
1863 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1864 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1865 (current_message_1, set_message_1):
1866 Use a local to convert to proper width without a cast.
1867 * xmenu.c (dialog_selection_callback): Likewise.
1868
ede49d71
PE
1869 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1870 Also, don't assume VALBITS / RAND_BITS is less than 5,
1871 and don't rely on undefined behavior when shifting a 1 left into
1872 the sign bit.
1873 * lisp.h (get_random): Change signature to match.
1874
2f30ecd0
PE
1875 * lread.c (hash_string): Use size_t, not int, for hash computation.
1876 Normally we prefer signed values; but hashing is special, because
1877 it's better to use unsigned division on hash table sizes so that
1878 the remainder is nonnegative. Also, size_t is the natural width
1879 for hashing into memory. The previous code used 'int', which doesn't
1880 retain enough info to hash well into very large tables.
1881 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1882
2a866e7b
PE
1883 * dbusbind.c: Don't possibly lose pointer info when converting.
1884 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1885 Use XPNTR rather than XHASH, so that the high-order bits of
1886 the pointer aren't lost when converting through void *.
1887
51639eac
PE
1888 * eval.c (Fautoload): Don't double-shift a pointer.
1889
92394119
PE
1890 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1891
dbdb9a7c
JB
18922011-05-06 Juanma Barranquero <lekktu@gmail.com>
1893
1894 * gnutls.c (DEF_GNUTLS_FN):
1895 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1896
db7a0b4f
AS
18972011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1898
1899 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1900 marker. (Bug#8610)
1901
f7ff1b0f 19022011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1903
1904 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1905 New version that can reserve upto 2GB of heap space.
1906
f7ff1b0f 19072011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1908
1909 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1910
639c109b
TZ
19112011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1912
1913 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1914 `gnutls_certificate_set_x509_key_file'.
1915
d2127135
JB
19162011-05-05 Juanma Barranquero <lekktu@gmail.com>
1917
1918 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1919 Update dependencies.
1920
e968f4f3
JB
19212011-05-04 Juanma Barranquero <lekktu@gmail.com>
1922
1923 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1924 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1925 Remove unused parameter `fildes'.
1926 * process.c (read_process_output, send_process): Don't pass it.
1927
84d358f0
JB
19282011-05-04 Juanma Barranquero <lekktu@gmail.com>
1929
1930 Fix previous change: the library cache is defined in w32.c.
1931 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1932 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1933
0898ca10
JB
19342011-05-04 Juanma Barranquero <lekktu@gmail.com>
1935
1936 Implement dynamic loading of GnuTLS on Windows.
1937
1938 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1939 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1940 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1941 Declare.
1942
1943 * gnutls.c (Qgnutls_dll): Define.
1944 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1945 (gnutls_*): Declare function pointers.
1946 (init_gnutls_functions): New function to initialize function pointers.
1947 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1948 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1949 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1950 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1951 (emacs_gnutls_write, emacs_gnutls_read)
1952 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1953 (Fgnutls_available_p): New function.
1954 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1955 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1956 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1957
1958 * image.c: Include w32.h.
1959 (Vimage_type_cache): Delete.
1960 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1961 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1962 (w32_delayed_load): Move to w32.c.
1963
1964 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1965
1966 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1967 (w32_delayed_load): Move from image.c. When loading a library, record
1968 its filename in the :loaded-from property of the library id.
1969 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1970 Initialize and staticpro them.
1971 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1972
1973 * process.c: Include lisp.h before w32.h, not after.
1974 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1975 instead of gnutls_record_check_pending.
1976
1977 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1978
ff4de4aa
TZ
19792011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1980
1981 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1982 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1983 as passed in.
1984
abe95abb
JD
19852011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1986
1987 * xterm.c (x_set_frame_alpha): Do not set property on anything
1988 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1989
e16e55d4
JB
19902011-05-02 Juanma Barranquero <lekktu@gmail.com>
1991
1992 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1993
bafcf6a5
JB
19942011-05-02 Juanma Barranquero <lekktu@gmail.com>
1995
1996 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1997 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1998 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1999 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2000 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2001 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2002 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2003 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2004 (Qgnutls_bootprop_callbacks_verify): Make static.
2005
e7a6747f
AS
20062011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2007
19ed11ba
AS
2008 * callproc.c: Indentation fixup.
2009
e7a6747f 2010 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2011 (wait_for_termination, interruptible_wait_for_termination):
2012 Move after wait_for_termination_1.
e7a6747f 2013
1ef14cb4
LMI
20142011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2015
2016 * sysdep.c (interruptible_wait_for_termination): New function
2017 which is like wait_for_termination, but allows keyboard
2018 interruptions.
2019
2020 * callproc.c (Fcall_process): Add (:file "file") as an option for
2021 the STDOUT buffer.
2022 (Fcall_process_region): Ditto.
2023
330d880c
EZ
20242011-04-30 Eli Zaretskii <eliz@gnu.org>
2025
8db90b73
EZ
2026 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2027 rather than `XVECTOR (FOO)->size'.
2028
330d880c
EZ
2029 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2030 inttypes.h, as a gnulib replacement is used if it not available in
2031 system headers.
2032
15cbd324
EZ
20332011-04-21 Eli Zaretskii <eliz@gnu.org>
2034
2035 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2036 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2037 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2038
2039 * coding.c (coding_alloc_by_realloc): Error out if destination
2040 will grow beyond MOST_POSITIVE_FIXNUM.
2041 (decode_coding_emacs_mule): Abort if there isn't enough place in
2042 charbuf for the composition carryover bytes. Reserve an extra
2043 space for up to 2 characters produced in a loop.
2044 (decode_coding_iso_2022): Abort if there isn't enough place in
2045 charbuf for the composition carryover bytes.
2046
20472011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2048
ae940cca
EZ
2049 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2050 aborting when %lld or %lll format is passed.
2051 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2052 %llo or %llx format is passed. (Bug#8545)
2053
03ab8921
EZ
2054 * window.c (window_scroll_line_based): Use a marker instead of
2055 simple variables to record original value of point. (Bug#7952)
2056
afda1437
EZ
2057 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2058 produced by %s or %c overflows available buffer space. (Bug#8545)
2059
f76dee0c
PE
20602011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2061
2062 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2063 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2064
fdc5744d
JB
20652011-04-28 Juanma Barranquero <lekktu@gmail.com>
2066
2067 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2068
638f053a
JB
20692011-04-28 Juanma Barranquero <lekktu@gmail.com>
2070
2071 * keyboard.c (Qdelayed_warnings_hook): Define.
2072 (command_loop_1): Run `delayed-warnings-hook'
2073 if Vdelayed_warnings_list is non-nil.
2074 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2075 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2076
d178f871
EZ
20772011-04-28 Eli Zaretskii <eliz@gnu.org>
2078
2079 * doprnt.c (doprnt): Don't return value smaller than the buffer
2080 size if the message was truncated. (Bug#8545).
2081
b124fd93
JB
20822011-04-28 Juanma Barranquero <lekktu@gmail.com>
2083
2084 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2085 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2086
e810457d
PE
20872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2088
2089 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2090
ea51cceb
JB
20912011-04-27 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * makefile.w32-in: Update dependencies.
2094
94dcfacf
EZ
20952011-04-27 Eli Zaretskii <eliz@gnu.org>
2096
2097 Improve `doprnt' and its usage. (Bug#8545)
2098 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2099 `format_end'. Remove support for %l as a conversion specifier.
2100 Don't use xrealloc. Improve diagnostics when the %l size modifier
2101 is used. Update the commentary.
2102
2103 * eval.c (verror): Simplify calculation of size_t.
2104
2105 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2106 messages.
2107
f61f41d7
PE
21082011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2109
2110 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2111 change.
2112
96fb4434
PE
21132011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2114
2115 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2116 This makes this file independent of the recent pseudovector change.
2117
671875da 21182011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2119
69e9b5a3
PE
2120 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2121
b5f869a7 2122 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2123 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2124 Remove unused local.
c8926152 2125 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2126
841a1577 2127 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2128 GCC 4.6.0 optimizes based on type-based alias analysis.
2129 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2130 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2131 != &v->size, and therefore "v->size = 1; b->size = 2; return
2132 v->size;" must therefore return 1. This assumption is incorrect
2133 for Emacs, since it type-puns struct Lisp_Vector * with many other
2134 types. To fix this problem, this patch adds a new type struct
f904488f 2135 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2136 and pseudovectors, and helps optimizing compilers not get fooled
2137 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2138 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2139 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2140 the size member.
eab3844f
PE
2141 (XSETPVECTYPE): Rewrite in terms of new macro.
2142 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2143 This is a bit clearer, and further avoids the possibility of
2144 undesirable aliasing.
2145 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2146 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2147 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2148 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2149 (ASIZE): Now uses header.size rather than size.
2150 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2151 to avoid the hassle of writing XVECTOR (foo)->header.size.
2152 (struct vectorlike_header): New type.
eab3844f
PE
2153 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2154 object, to help avoid aliasing.
2155 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2156 (SUBRP): Likewise, since Lisp_Subr is a special case.
2157 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2158 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2159 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2160 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2161 changed to be "header.size" and "header.next".
2162 * buffer.h (struct buffer): Likewise.
2163 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2164 * frame.h (struct frame): Likewise.
2165 * process.h (struct Lisp_Process): Likewise.
2166 * termhooks.h (struct terminal): Likewise.
2167 * window.c (struct save_window_data, struct saved_window): Likewise.
2168 * window.h (struct window): Likewise.
2169 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2170 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2171 * buffer.c (init_buffer_once): Likewise.
2172 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2173 special case.
2174 * process.c (Fformat_network_address): Use local var for size,
2175 for brevity.
2176
0df1eac5
PE
2177 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2178
847ab9d1 2179 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2180 * data.c (atof): Remove decl; no longer used or needed.
2181 (digit_to_number): Move to lread.c.
2182 (Fstring_to_number): Use new string_to_number function, to be
2183 consistent with how the Lisp reader treats infinities and NaNs.
2184 Do not assume that floating-point numbers represent EMACS_INT
2185 without losing information; this is not true on most 64-bit hosts.
2186 Avoid double-rounding errors, by insisting on integers when
2187 parsing non-base-10 numbers, as the documentation specifies.
2188 * lisp.h (string_to_number): New decl, replacing ...
2189 (isfloat_string): Remove.
bc0a5c13 2190 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2191 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2192 appears to have been a coding error. Similarly, do not accept
2193 strings like +-1e0 as floating point numbers. Do not report
2194 overflow for integer overflows unless the base is not 10 which
2195 means we have no simple and reliable way to continue.
2196 Break out the floating-point parsing into a new
2197 function string_to_number, so that Fstring_to_number parses
2198 floating point numbers consistently with the Lisp reader.
04f2d78b 2199 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2200 (E_CHAR, EXP_INT): Remove, replacing with ...
2201 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2202 (string_to_number): New function, replacing isfloat_string.
2203 This function checks for valid syntax and produces the resulting
2204 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2205 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2206 so that overflow for non-base-10 numbers is reported only when
2207 there's no portable and simple way to convert to floating point.
452f4150 2208
67769ffc
PE
2209 * textprop.c (set_text_properties_1): Rewrite for clarity,
2210 and to avoid GCC warning about integer overflow.
2211
c20db43f
PE
2212 * intervals.h (struct interval): Use EMACS_INT for members
2213 where EMACS_UINT might cause problems. See
2214 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2215 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2216 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2217 All uses changed.
37aa2f85
PE
2218 (offset_intervals): Tell GCC not to worry about length overflow
2219 when negating a negative length.
c20db43f 2220
2538aa2f
PE
2221 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2222 (overrun_check_free): Likewise.
2223
f2d3008d
PE
2224 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2225 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2226 word size.
2227
ec8df744
PE
2228 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2229 (gnutls_make_error): Rename local to avoid shadowing.
2230 (gnutls_emacs_global_deinit): ifdef out; not used.
2231 (Fgnutls_boot): Use const for pointer to readonly storage.
2232 Comment out unused local. Fix pointer signedness problems.
2233
640ee02d
PE
2234 * lread.c (openp): Don't stuff size_t into an 'int'.
2235 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2236 about possible signed overflow.
2237
6048fb2a
PE
2238 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2239 (GDK_KEY_g): Don't define if already defined.
2240 (xg_prepare_tooltip): Avoid pointer signedness problem.
2241 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2242
fa3c87e1
PE
2243 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2244 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2245
2172544b
PE
2246 * xfns.c (Fx_window_property): Simplify a bit,
2247 to make a bit faster and to avoid GCC 4.6.0 warning.
2248 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2249
9b821a21
PE
2250 * fns.c (internal_equal): Don't assume size_t fits in int.
2251
3c616cfa
PE
2252 * alloc.c (compact_small_strings): Tighten assertion a little.
2253
c2982e87
PE
2254 Replace pEd with more-general pI, and fix some printf arg casts.
2255 * lisp.h (pI): New macro, generalizing old pEd macro to other
2256 conversion specifiers. For example, use "...%"pI"d..." rather
2257 than "...%"pEd"...".
2258 (pEd): Remove. All uses replaced with similar uses of pI.
2259 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2260 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2261 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2262 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2263 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2264 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2265 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2266 64-bit hosts.
2267 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2268 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2269 * print.c (safe_debug_print, print_object): Likewise.
2270 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2271 to int.
6f04d126
PE
2272 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2273 avoiding the 0 flag, which is not portable.
c2982e87
PE
2274 * process.c (Fmake_network_process): Use pI to avoid cast.
2275 * region-cache.c (pp_cache): Likewise.
2276 * xdisp.c (decode_mode_spec): Likewise.
2277 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2278 behavior on 64-bit hosts with printf arg.
6f04d126 2279 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2280 (x_stop_queuing_selection_requests): Likewise.
2281 (x_get_window_property): Don't truncate byte count to an 'int'
2282 when tracing.
0b432f21 2283
5e073ec7
PE
2284 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2285 here, since it parses constructs like leading '-' and spaces,
2286 which are not wanted; and it overflows with large numbers.
2287 Instead, simply match F[0-9]+, which is what is wanted anyway.
2288
36372bf9
PE
2289 * alloc.c: Remove unportable assumptions about struct layout.
2290 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2291 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2292 (allocate_vectorlike, make_pure_vector): Use the new macros,
2293 plus offsetof, to remove unportable assumptions about struct layout.
2294 These assumptions hold on all porting targets that I know of, but
2295 they are not guaranteed, they're easy to remove, and removing them
2296 makes further changes easier.
2297
0b432f21
PE
2298 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2299 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2300 (string_overrun_cookie): Now const. Use initializers that
2301 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2302 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2303 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2304 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2305 multiple of sizeof (EMACS_INT); it need not be, if
2306 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2307 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2308
895009e1
JB
23092011-04-26 Juanma Barranquero <lekktu@gmail.com>
2310
2311 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2312
6a7a1b0b
TZ
23132011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2314
2315 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2316 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2317 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2318
841a1577 23192011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2320
2321 * lisp.h (Qdebug): List symbol.
895009e1 2322 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2323 * keyboard.c (debug-on-event): New variable.
2324 (handle_user_signal): Break into debugger when debug-on-event
2325 matches the current signal symbol.
2326
f2d3ba6f
DN
23272011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2328
2329 * alloc.c (check_sblock, check_string_bytes)
2330 (check_string_free_list): Convert to standard C.
2331
42ce4c63
TZ
23322011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2333
2334 * w32.c (emacs_gnutls_push): Fix typo.
2335
825cd63c
EZ
23362011-04-25 Eli Zaretskii <eliz@gnu.org>
2337
fb11d64d
EZ
2338 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2339 "cast to pointer from integer of different size".
2340
825cd63c
EZ
2341 Improve doprnt and its use in verror. (Bug#8545)
2342 * doprnt.c (doprnt): Document the set of format control sequences
2343 supported by the function. Use SAFE_ALLOCA instead of always
2344 using `alloca'.
2345
2346 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2347 is one byte too soon. Don't use xrealloc; instead xfree and
2348 xmalloc anew.
2349
e061a11b
TZ
23502011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2351
2352 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2353 callbacks stage.
2354
2355 * gnutls.c: Renamed global_initialized to
2356 gnutls_global_initialized. Added internals for the
2357 :verify-hostname-error, :verify-error, and :verify-flags
2358 parameters of `gnutls-boot' and documented those parameters in the
2359 docstring. Start callback support.
2360 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2361 unless a fatal error occured. Call gnutls_alert_send_appropriate
2362 on error. Return error code.
2363 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2364 (emacs_gnutls_read): Likewise.
2365 (Fgnutls_boot): Return handshake error code.
2366 (emacs_gnutls_handle_error): New function.
2367 (wsaerror_to_errno): Likewise.
2368
2369 * w32.h (emacs_gnutls_pull): Add prototype.
2370 (emacs_gnutls_push): Likewise.
2371
2372 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2373 (emacs_gnutls_push): Likewise.
2374
23752011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2376
2377 * process.c (wait_reading_process_output): Check if GnuTLS
2378 buffered some data internally if no FDs are set for TLS
2379 connections.
2380
2381 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2382 (LIBS): Link to USER_LIBS.
2383 ($(BLD)/gnutls.$(0)): New target.
2384
fa6996bc
EZ
23852011-04-24 Eli Zaretskii <eliz@gnu.org>
2386
eb35682e
EZ
2387 * xdisp.c (handle_single_display_spec): Rename the
2388 display_replaced_before_p argument into display_replaced_p, to
2389 make it consistent with the commentary. Fix typos in the
2390 commentary.
2391
e2ad650c
EZ
2392 * textprop.c (syms_of_textprop): Remove dead code.
2393 (copy_text_properties): Delete obsolete commentary about an
2394 interface that was deleted long ago. Fix typos in the description
2395 of arguments.
2396
1b2de274
EZ
2397 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2398 to changes in oldXMenu/XMenu.h from 2011-04-16.
2399 <menu_help_message, prev_menu_help_message>: Constify.
2400 (IT_menu_make_room): menu->help_text is now `const char **';
2401 adjust.
2402
2403 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2404 to changes in oldXMenu/XMenu.h from 2011-04-16.
2405 (struct XMenu): Declare `help_text' `const char **'.
2406
2407 * xfaces.c <Qunspecified>: Make extern again.
2408
2409 * syntax.c: Include sys/types.h before including regex.h, as
2410 required by Posix.
2411
762b15be
EZ
2412 * doc.c (get_doc_string): Improve the format passed to `error'.
2413
2414 * doprnt.c (doprnt): Improve commentary.
2415
2416 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2417
2418 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2419 them with etags.
2420
f1052e5d
EZ
2421 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2422 changes in globals.h immediately force recompilation.
762b15be
EZ
2423 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2424 $(CURDIR)/s/ms-w32.h.
2425 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2426
fa6996bc
EZ
2427 * character.c (Fchar_direction): Function deleted.
2428 (syms_of_character): Don't defsubr it.
2429 <char-direction-table>: Deleted.
2430
e6c3da20
EZ
24312011-04-23 Eli Zaretskii <eliz@gnu.org>
2432
2433 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2434 * doprnt.c: Include limits.h.
2435 (SIZE_MAX): New macro.
04f2d78b
CB
2436 (doprnt): Return a size_t value. 2nd arg is now size_t.
2437 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2438 Improve overflow protection. Support `l' modifier for integer
2439 conversions. Support %l conversion. Don't assume an EMACS_INT
2440 argument for integer conversions and for %c.
2441
2442 * lisp.h (doprnt): Restore prototype.
2443
2444 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2445 $(SRC)/character.h.
2446
2447 * Makefile.in (base_obj): Add back doprnt.o.
2448
2449 * deps.mk (doprnt.o): Add back prerequisites.
2450 (callint.o): Depend on character.h.
2451
2452 * eval.c (internal_lisp_condition_case): Include the handler
2453 representation in the error message.
2454 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2455 when breaking from the loop.
2456
2457 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2458
2459 * callint.c (Fcall_interactively): When displaying error message
2460 about invalid control letter, pass the character's codepoint, not
2461 a pointer to its multibyte form. Improve display of the character
2462 in octal and display also its hex code.
2463
2464 * character.c (char_string): Use %x to display the (unsigned)
2465 codepoint of an invalid character, to avoid displaying a bogus
2466 negative value.
2467
2468 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2469 `error', not SYMBOL_NAME itself.
2470
2471 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2472 character arguments to `error'.
2473
2474 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2475 to `error' in error message about FINAL_CHAR argument. Make sure
2476 FINAL_CHAR is a character, and use %c when it is passed as
2477 argument to `error'.
2478
4ffd0d6b 24792011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2480
2481 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2482
2483 * w32.c: Include <time.h>.
2484 (sys_localtime): New function.
2485
4ffd0d6b 24862011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2487
2488 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2489
4ffd0d6b 2490 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2491
4ffd0d6b 24922011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2493
4ffd0d6b
GM
2494 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2495 zombies (Bug#8467).
aac0c6e3 2496
04c56954
EZ
24972011-04-19 Eli Zaretskii <eliz@gnu.org>
2498
2499 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2500 gl_state.e_property when gl_state.object is Qt.
2501
2502 * insdel.c (make_gap_larger): Remove limitation of buffer size
2503 to <= INT_MAX.
2504
16a43933
CY
25052011-04-18 Chong Yidong <cyd@stupidchicken.com>
2506
2507 * xdisp.c (lookup_glyphless_char_display)
2508 (produce_glyphless_glyph): Handle cons cell entry in
2509 glyphless-char-display.
2510 (Vglyphless_char_display): Document it.
2511
2512 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2513 glyphless-char-display.
2514
4581706e
CY
25152011-04-17 Chong Yidong <cyd@stupidchicken.com>
2516
2517 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2518
2519 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2520
2521 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2522 definition for no-X builds.
2523
4887c6e2 25242011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2525
fd35b6f9
PE
2526 Static checks with GCC 4.6.0 and non-default toolkits.
2527
5c1ccb01
PE
2528 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2529
006c5daa
PE
2530 * process.c (keyboard_bit_set): Define only if SIGIO.
2531 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2532 (send_process): Repair possible setjmp clobbering.
2533
efc736d3
PE
2534 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2535
4e2fe2e6
PE
2536 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2537
f97334a2
PE
2538 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2539
4e75f29d
PE
2540 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2541 Define only if needed.
2542
90efadd1
PE
2543 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2544 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2545 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2546
3c647824
PE
2547 * dispextern.h (struct redisplay_interface): Rename param
2548 to avoid shadowing.
e264f262 2549 * termhooks.h (struct terminal): Likewise.
761383f4 2550 * xterm.c (xembed_send_message): Likewise.
3c647824 2551
b58c5c4a
PE
2552 * insdel.c (make_gap_smaller): Define only if
2553 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2554
cad59032
PE
2555 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2556 it.
2557
c339dc2e
PE
2558 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2559 so that we aren't warned about unused symbols.
2560
91a3e27b
PE
2561 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2562
399c71d3 2563 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2564
8ffc96f5
PE
2565 * xfns.c (x_real_positions): Mark locals as initialized.
2566
eef9bc79
PE
2567 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2568
098db9dd
PE
2569 * xterm.c: Fix problems found by static analysis with other toolkits.
2570 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2571 (x_dispatch_event): Declare static if USE_GTK, and
2572 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2573 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2574 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2575 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2576 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2577
eb18f6cc
PE
2578 * xmenu.c (menu_help_callback): Pointer type fixes.
2579 Use const pointers when pointing at readonly data. Avoid pointer
2580 signedness clashes.
2581 (FALSE): Remove unused macro.
2582 (update_frame_menubar): Remove unused decl.
2583
1fe72bf8
PE
2584 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2585
60d9e1db
PE
2586 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2587 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2588 (single_menu_item): Rename local to avoid shadowing.
2589
39261c26
PE
2590 * keyboard.c (make_lispy_event): Remove unused local var.
2591
018c5e19
PE
2592 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2593 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2594
63d2b86e
PE
2595 * bitmaps: Change bitmaps from unsigned char back to the X11
2596 compatible char. Avoid the old compiler warnings about
2597 out-of-range initializers by using, for example, '\xab' rather
2598 than 0xab.
2599
aefd87e1
PE
2600 * xgselect.c (xgselect_initialize): Check vs interface
2601 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2602
bf501fb9
PE
2603 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2604
e9829fdf
PE
2605 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2606 to read-only memory.
2607
1086c095
PE
2608 * fns.c (vector): Remove; this old hack is no longer needed.
2609
2baccd04 2610 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2611 Remove unused var.
dde42981 2612 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2613
72391843 2614 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2615
436c16df 2616 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2617 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2618 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2619
92bb796d 2620 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2621 (x_term_init): Remove local to avoid shadowing.
92bb796d 2622
764430a3 2623 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2624
2625 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2626 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2627
d1dfb56c
EZ
26282011-04-16 Eli Zaretskii <eliz@gnu.org>
2629
c4354cb4
EZ
2630 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2631
d1dfb56c
EZ
2632 Fix regex.c, syntax.c and friends for buffers > 2GB.
2633 * syntax.h (struct gl_state_s): Declare character position members
2634 EMACS_INT.
2635
2636 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2637
04f2d78b
CB
2638 * textprop.c (verify_interval_modification, interval_of):
2639 Declare arguments EMACS_INT.
d1dfb56c
EZ
2640
2641 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2642 EMACS_INT.
2643
2644 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2645
2646 * indent.c (Fvertical_motion): Local variable it_start is now
2647 EMACS_INT.
2648
2649 * regex.c (re_match, re_match_2, re_match_2_internal)
2650 (bcmp_translate, regcomp, regexec, print_double_string)
2651 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2652 (re_compile_pattern, re_exec): Declare arguments and local
2653 variables `size_t' and `ssize_t' and return values `regoff_t', as
2654 appropriate.
2655 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2656 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2657 <compile_stack_type>: `size' and `avail' are now `size_t'.
2658
2659 * regex.h <regoff_t>: Use ssize_t, not int.
2660 (re_search, re_search_2, re_match, re_match_2): Arguments that
2661 specify buffer/string position and length are now ssize_t and
2662 size_t. Return type is regoff_t.
2663
613052cd
BK
26642011-04-16 Ben Key <bkey76@gmail.com>
2665
2666 * nsfont.m: Fixed bugs in ns_get_family and
2667 ns_descriptor_to_entity that were caused by using free to
2668 deallocate memory blocks that were allocated by xmalloc (via
2669 xstrdup). This caused Emacs to crash when compiled with
2670 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2671 --enable-checking=xmallocoverrun). xfree is now used to
2672 deallocate these memory blocks.
2673
4170f62f 26742011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2675
71b41406
PE
2676 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2677
9587a89d
PE
2678 emacs_write: Accept and return EMACS_INT for sizes.
2679 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2680 et seq.
2681 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2682 Accept and return EMACS_INT.
2683 (emacs_gnutls_write): Return the number of bytes written on
2684 partial writes.
2685 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2686 (emacs_read, emacs_write): Remove check for negative size, as the
2687 Emacs source code has been audited now.
9587a89d
PE
2688 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2689 (emacs_read, emacs_write): Use it.
273a5f82
PE
2690 * process.c (send_process): Adjust to the new signatures of
2691 emacs_write and emacs_gnutls_write. Do not attempt to store
2692 a byte offset into an 'int'; it might overflow.
9587a89d 2693 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2694
3e047f51
PE
2695 * sound.c: Don't assume sizes fit in 'int'.
2696 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2697 Return EMACS_INT, not int.
3e047f51 2698 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2699 Accept EMACS_INT, not int.
2700 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2701 record read return values.
2702
cc39a9db
BK
27032011-04-15 Ben Key <bkey76@gmail.com>
2704
c9d0ec6d
JB
2705 * keyboard.c (Qundefined): Don't declare static since it is used
2706 in nsfns.m.
2707 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2708 static since they are used in nsfont.m.
cc39a9db 2709
6c60eb9f
SM
27102011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2711
2712 * process.c (Qprocessp): Don't declare static.
2713 * lisp.h (Qprocessp): Declare again.
2714
7990b61a
JB
27152011-04-15 Juanma Barranquero <lekktu@gmail.com>
2716
2717 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2718
5d4cb038
PE
27192011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2720
8bd7b830 2721 Improve C-level modularity by making more things 'static'.
cd64ea1d 2722
e3b27b31
PE
2723 Don't publish debugger-only interfaces to other modules.
2724 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2725 (verify_bytepos, count_markers): Move decls to the only modules
2726 that need them.
2727 * region-cache.h (pp_cache): Likewise.
2728 * window.h (check_all_windows): Likewise.
2729 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2730
5d4cb038
PE
2731 * sysdep.c (croak): Now static, if
2732 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2733 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2734
2735 * alloc.c (refill_memory_reserve): Now static if
2736 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2737 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2738
e87b6180
PE
2739 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2740 Define only if USE_LUCID.
2741
ac64929e
PE
2742 * xrdb.c (x_customization_string, x_rm_string): Now static.
2743
6f37259d
PE
2744 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2745 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2746
1683e3ab
PE
2747 * xdisp.c (draw_row_with_mouse_face): Now static.
2748 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2749
de9c2632
PE
2750 * window.h (check_all_windows): Mark externally visible.
2751
2b96acb7
PE
2752 * window.c (window_deletion_count): Now static.
2753
2754 * undo.c: Make symbols static if they're not exported.
2755 (last_undo_buffer, last_boundary_position, pending_boundary):
2756 Now static.
2757
50436f33
PE
2758 * textprop.c (interval_insert_behind_hooks): Now static.
2759 (interval_insert_in_front_hooks): Likewise.
2760
64520e5c
PE
2761 * term.c: Make symbols static if they're not exported.
2762 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2763 (max_frame_lines, tty_set_terminal_modes):
2764 (tty_reset_terminal_modes, tty_turn_off_highlight):
2765 (get_tty_terminal): Now static.
2766 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2767 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2768 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2769 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2770 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2771
1fa53021
PE
2772 * sysdep.c: Make symbols static if they're not exported.
2773 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2774 Now static.
2775 (sigprocmask_set, full_mask): Remove; unused.
2776 (wait_debugging): Mark as visible.
2777 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2778 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2779
d4b43b22
PE
2780 * syntax.c (syntax_temp): Define only if !__GNUC__.
2781
b7c513d0
PE
2782 * sound.c (current_sound_device, current_sound): Now static.
2783
989b29ad
PE
2784 * search.c (searchbufs, searchbuf_head): Now static.
2785
13a55a78
PE
2786 * scroll.c (scroll_cost): Remove; unused.
2787 * dispextern.h (scroll_cost): Remove decl.
2788
de68a1fc
PE
2789 * region-cache.h (pp_cache): Mark as externally visible.
2790
40ccffa6
PE
2791 * process.c: Make symbols static if they're not exported.
2792 (process_tick, update_tick, create_process, chan_process):
2793 (Vprocess_alist, proc_buffered_char, datagram_access):
2794 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2795 (deactivate_process): Mark defn as static, as well as decl.
2796 * lisp.h (create_process): Remove decl.
2797 * process.h (chan_process, Vprocess_alist): Remove decls.
2798
ad64fc97
PE
2799 * print.c: Make symbols static if they're not exported.
2800 (print_depth, new_backquote_output, being_printed, print_buffer):
2801 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2802 (print_interval, print_number_index, initial_stderr_stream):
2803 Now static.
2804 * lisp.h (Fprinc): Remove decl.
2805 (debug_output_compilation_hack): Mark as externally visible.
2806
adddb265
PE
2807 * sysdep.c (croak): Move decl from here to syssignal.h.
2808 * syssignal.h (croak): Put it here, so the API can be checked when
2809 'croak' is called from dissociate_if_controlling_tty.
2810
1717ede2
PE
2811 * minibuf.c: Make symbols static if they're not exported.
2812 (minibuf_save_list, choose_minibuf_frame): Now static.
2813 * lisp.h (choose_minibuf_frame): Remove decl.
2814
fa5fb2bc
PE
2815 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2816
1e3890d1
PE
2817 * lread.c: Make symbols static if they're not exported.
2818 (read_objects, initial_obarray, oblookup_last_bucket_number):
2819 Now static.
2820 (make_symbol): Remove; unused.
2821 * lisp.h (initial_obarray, make_symbol): Remove decls.
2822
8a1414fa
PE
2823 * keyboard.c: Make symbols static if they're not exported.
2824 (single_kboard, recent_keys_index, total_keys, recent_keys):
2825 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2826 (this_single_command_key_start, echoing, last_auto_save):
2827 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2828 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2829 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2830 (Vlispy_mouse_stem, double_click_count):
2831 Now static.
2832 (force_auto_save_soon): Define only if SIGDANGER.
2833 (ignore_mouse_drag_p): Now static if
2834 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2835 (print_help): Remove; unused.
2836 (stop_character, last_timer_event): Mark as externally visible.
2837 * keyboard.h (ignore_mouse_drag_p): Declare only if
2838 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2839 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2840 * lisp.h (echoing): Remove decl.
2841 (force_auto_save_soon): Declare only if SIGDANGER.
2842 * xdisp.c (redisplay_window): Simplify code, to make it more
2843 obvious that ignore_mouse_drag_p is not accessed if !defined
2844 USE_GTK && !defined HAVE_NS.
2845
93ea6e8f
PE
2846 * intervals.c: Make symbols static if they're not exported.
2847 (merge_properties_sticky, merge_interval_right, delete_interval):
2848 Now static.
2849 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2850
77382fcc
PE
2851 * insdel.c: Make symbols static if they're not exported.
2852 However, leave prepare_to_modify_buffer alone. It's never
2853 called from outside this function, but that appears to be a bug.
2854 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2855 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2856 (adjust_after_replace_noundo): Remove; unused.
2857 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2858 (signal_before_change): Remove decls.
77382fcc 2859
9306c32e
PE
2860 * indent.c (val_compute_motion, val_vmotion): Now static.
2861
cd44d2eb
PE
2862 * image.c: Make symbols static if they're not exported.
2863 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2864 if USE_GTK.
2865 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2866 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2867
ad9a7a06
PE
2868 * fringe.c (standard_bitmaps): Now static.
2869 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2870
81626931
PE
2871 * frame.c: Make symbols static if they're not exported.
2872 (x_report_frame_params, make_terminal_frame): Now static.
2873 (get_frame_param): Now static, unless HAVE_NS.
2874 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2875 (x_get_resource_string): Remove; not used.
2876 * frame.h (make_terminal_frame, x_report_frame_params):
2877 (x_get_resource_string); Remove decls.
2878 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2879 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2880
239f9db9
PE
2881 * font.c, fontset.c: Make symbols static if they're not exported.
2882 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2883 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2884 * font.c (font_close_object): Now static.
2885 * font.h (font_close_object): Remove.
2886 * fontset.c (FONTSET_OBJLIST): Remove.
2887 (free_realized_fontset) #if-0 the body, which does nothing.
2888 (face_suitable_for_char_p): #if-0, as it's never called.
2889 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2890 * xfaces.c (face_at_string_position):
2891 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2892 since 0 is always ASCII.
2893
dfcf3579
PE
2894 * fns.c (weak_hash_tables): Now static.
2895
5045092b
PE
2896 * fileio.c: Make symbols static if they're not exported.
2897 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2898 (Vwrite_region_annotation_buffers): Now static.
2899
57a96f5c
PE
2900 * eval.c: Make symbols static if they're not exported.
2901 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2902 * lisp.h (backtrace_list): Remove decl.
2903
35f08c38
PE
2904 * emacs.c: Make symbols static if they're not exported.
2905 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2906 (fatal_error_code, fatal_error_signal_hook, standard_args):
2907 Now static.
2908 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2909 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2910 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2911 * lisp.h (fatal_error_signal_hook): Remove decl.
2912 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2913
f44bd759
PE
2914 * editfns.c: Move a (normally-unused) function to its only use.
2915 * editfns.c, lisp.h (get_operating_system_release): Remove.
2916 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2917 worth the hassle of breaking this out.
2918
b532497d
PE
2919 * xterm.c: Make symbols static if they're not exported.
2920 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2921 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2922 (x_destroy_window, x_delete_display):
2923 Now static.
2924 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2925 (x_mouse_leave): Remove; unused.
2926 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2927 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2928 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2929 Remove decls.
2930 (x_mouse_leave): Declare only if WINDOWSNT.
2931 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2932 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2933 USE_X_TOOLKIT.
2934
1675728f
PE
2935 * ftxfont.c: Make symbols static if they're not exported.
2936 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2937 HAVE_FREETYPE.
2938 * font.h (ftxfont_driver): Likewise.
2939
e4cebfca
PE
2940 * xfns.c: Make symbols static if they're not exported.
2941 (x_last_font_name, x_display_info_for_name):
2942 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2943 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2944 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2945 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2946 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2947 (last_show_tip_args): Now static.
2948 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2949 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2950 (x_screen_planes): Remove; unused.
2951 * dispextern.h (x_screen_planes): Remove decl.
2952
5bf46f05
PE
2953 * dispnew.c: Make symbols static if they're not exported.
2954 * dispextern.h (redraw_garbaged_frames, scrolling):
2955 (increment_row_positions): Remove.
2956 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2957 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2958 Now static.
2959 (redraw_garbaged_frames): Remove; unused.
2960
435f4c28
PE
2961 * xfaces.c: Make symbols static if they're not exported.
2962 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2963 Remove decls.
2964 * xterm.h (defined_color): Remove decls.
2965 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2966 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2967 (menu_face_changed_default, defined_color, free_realized_face):
2968 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2969 (ascii_face_of_lisp_face): Remove; unused.
2970
8524aef3
PE
2971 * xdisp.c: Make symbols static if they're not exported.
2972 * dispextern.h (scratch_glyph_row, window_box_edges):
2973 (glyph_to_pixel_coords, set_cursor_from_row):
2974 (get_next_display_element, set_iterator_to_next):
2975 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2976 (show_mouse_face): Remove decls
2977 * frame.h (message_buf_print): Likewise.
2978 * lisp.h (pop_message, set_message, check_point_in_composition):
2979 Likewise.
2980 * xterm.h (set_vertical_scroll_bar): Likewise.
2981 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2982 (message_buf_print, scratch_glyph_row, displayed_buffer):
2983 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2984 (get_next_display_element, show_mouse_face, window_box_edges):
2985 (frame_to_window_pixel_xy, check_point_in_composition):
2986 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2987 (glyph_to_pixel_coords): Remove; unused.
2988
16390cd2
PE
2989 * dired.c (file_name_completion): Now static.
2990
2991 * dbusbind.c (xd_in_read_queued_messages): Now static.
2992
a25f4dfa
PE
2993 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2994 * data.c (circular_list_error): Remove.
2995
14a9c8df
PE
2996 * commands.h (last_point_position, last_point_position_buffer):
2997 (last_point_position_window): Remove decls.
2998 * keyboard.c: Make these variables static.
2999
04f2d78b
CB
3000 * coding.h (coding, code_convert_region, encode_coding_gap):
3001 Remove decls.
74ab6df5
PE
3002 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3003 (iso_code_class, detect_coding, code_convert_region): Now static.
3004 (encode_coding_gap): Remove; unused.
3005
38dfbee1
PE
3006 * chartab.c (chartab_chars, chartab_bits): Now static.
3007
a2cb4e63
PE
3008 * charset.h (charset_iso_8859_1): Remove decl.
3009 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3010 Now static.
3011
127198fd
PE
3012 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3013 * ccl.c (Vccl_program_table): Now static.
3014 (check_ccl_update): Remove; unused.
3015
d85b608f
PE
3016 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3017 * category.h: ... from here.
3018 * category.c (check_category_table, set_category_set): Now static.
3019
31cd66f3
PE
3020 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3021 * lisp.h: Remove these decls.
3022
c358e587
PE
3023 * buffer.c (buffer_count): Remove unused var.
3024
e78aecca
PE
3025 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3026 so that it's not optimized away.
3027 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3028 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3029 exported only to the debugger.
3030
e192d7d3 3031 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3032 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3033
92470028
PE
3034 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3035 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3036 was inaccessible from Lisp.
3037 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3038 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3039
244ed907
PE
3040 alloc.c: Import and export fewer symbols, and remove unused items.
3041 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3042 is defined.
3043 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3044 it's not optimized away by whole-program optimization.
3045 (message_enable_multibyte, free_misc): Remove.
3046 (catchlist, handlerlist, mark_backtrace):
3047 Declare only if BYTE_MARK_STACK.
3048 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3049 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3050 (message_enable_multibyte): Remove decl.
3051 (free_misc, interval_free_list, float_block, float_block_index):
3052 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3053 (cons_free_list, last_marked_index):
3054 Now static.
3055 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3056 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3057 (mark_backtrace): Define only if BYTE_MARK_STACK.
3058 * xdisp.c (message_enable_multibyte): Now static.
3059
61c2b50e 3060 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3061 This makes it easier for human readers (and static analyzers)
3062 to see whether these variables are used from other modules.
3063 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3064 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3065 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3066 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3067 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3068 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3069 * xmenu.c, xselect.c:
3070 Declare Q* vars static if they are not used in other modules.
3071 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3072 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3073 Remove decls of unexported vars.
3074 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3075
95c82688
PE
3076 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3077
16a97296
PE
3078 Make Emacs functions such as Fatom 'static' by default.
3079 This makes it easier for human readers (and static analyzers)
3080 to see whether these functions can be called from other modules.
3081 DEFUN now defines a static function. To make the function external
3082 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3083 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3084 (Finit_image_library):
16a97296
PE
3085 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3086 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3087 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3088 Remove decls, since these functions are now static.
3089 (Funintern, Fget_internal_run_time): New decls, since these functions
3090 were already external.
95c82688 3091
16a97296
PE
3092 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3093 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3094 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3095 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3096 * keyboard.c, keymap.c, lread.c:
3097 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3098 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3099 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3100 Mark functions with DEFUE instead of DEFUN,
3101 if they are used in other modules.
3102 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3103 decls for now-static functions.
3104 * buffer.h (Fdelete_overlay): Remove decl.
3105 * callproc.c (Fgetenv_internal): Mark as internal.
3106 * composite.c (Fremove_list_of_text_properties): Remove decl.
3107 (Fcomposition_get_gstring): New forward static decl.
3108 * composite.h (Fcomposite_get_gstring): Remove decl.
3109 * dired.c (Ffile_attributes): New forward static decl.
3110 * doc.c (Fdocumntation_property): New forward static decl.
3111 * eval.c (Ffetch_bytecode): New forward static decl.
3112 (Funintern): Remove extern decl; now in .h file where it belongs.
3113 * fileio.c (Fmake_symbolic_link): New forward static decl.
3114 * image.c (Finit_image_library): New forward static decl.
3115 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3116 * intervals.h (Fprevious_property_change):
3117 (Fremove_list_of_text_properties): Remove decls.
3118 * keyboard.c (Fthis_command_keys): Remove decl.
3119 (Fcommand_execute): New forward static decl.
3120 * keymap.c (Flookup_key): New forward static decl.
3121 (Fcopy_keymap): Now static.
3122 * keymap.h (Flookup_key): Remove decl.
3123 * process.c (Fget_process): New forward static decl.
3124 (Fprocess_datagram_address): Mark as internal.
3125 * syntax.c (Fsyntax_table_p): New forward static decl.
3126 (skip_chars): Remove duplicate decl.
3127 * textprop.c (Fprevious_property_change): New forward static decl.
3128 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3129 Now internal.
3130 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3131 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3132
785bbd42
PE
3133 * editfns.c (Fformat): Remove unreachable code.
3134
8b913b57
AS
31352011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3136
3137 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3138 change. (Bug#8496)
3139
a6744a35
EZ
31402011-04-13 Eli Zaretskii <eliz@gnu.org>
3141
3142 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3143 when at ZV. (Bug#8487)
3144
e7974947
AS
31452011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3146
baad03f0
AS
3147 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3148 (Bug#8437)
3149 * keyboard.c (parse_tool_bar_item): Likewise.
3150 * sound.c (sound_cleanup, alsa_close): Likewise.
3151 * termcap.c (tgetent): Likewise.
3152 * xfns.c (x_default_font_parameter): Likewise.
3153 * xsettings.c (read_and_apply_settings): Likewise.
3154
e7974947
AS
3155 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3156 (overrun_check_free): Protoize.
3157
28272684
PE
31582011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3161 since callers should never pass a negative size.
3162 Change the signature to match that of plain 'read' and 'write'; see
3163 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3164 * lisp.h: Update prototypes of emacs_write and emacs_read.
3165
11997c76
EZ
31662011-04-11 Eli Zaretskii <eliz@gnu.org>
3167
3168 * xdisp.c (redisplay_window): Don't try to determine the character
3169 position of the scroll margin if the window start point w->startp
e896f03c 3170 is outside the buffer's accessible region. (Bug#8468)
11997c76 3171
8a2cbd72
EZ
31722011-04-10 Eli Zaretskii <eliz@gnu.org>
3173
3174 Fix write-region and its subroutines for buffers > 2GB.
3175 * fileio.c (a_write, e_write): Modify declaration of arguments and
3176 local variables to support buffers larger than 2GB.
3177 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3178
3179 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3180 argument, local variables, and return value.
3181
3182 * lisp.h: Update prototypes of emacs_write and emacs_read.
3183
3184 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3185
4073e537 31862011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3187
1ebfdcb6
PE
3188 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3189
b2ded58d
PE
3190 Fix more problems found by GCC 4.6.0's static checks.
3191
7d66342c
PE
3192 * xdisp.c (vmessage): Use a better test for character truncation.
3193
bbf47d44
PE
3194 * charset.c (load_charset_map): <, not <=, for optimization,
3195 and to avoid potential problems with integer overflow.
9248994d 3196 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3197 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3198 * editfns.c (Fformat): Likewise.
1e69125e 3199 * syntax.c (skip_chars): Likewise.
3befa583 3200
e3019616
PE
3201 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3202 This also lets GCC 4.6.0 generate slightly better loop code.
3203
becfa255
PE
3204 * callint.c (Fcall_interactively): <, not <=, for optimization.
3205 (Fcall_interactively): Count the number of arguments produced,
3206 not the number of arguments given. This is simpler and lets GCC
3207 4.6.0 generate slightly better code.
3208
dae0cd48
PE
3209 * ftfont.c: Distingish more carefully between FcChar8 and char.
3210 The previous code passed unsigned char * to a functions like
3211 strlen and xstrcasecmp that expect char *, which does not
3212 conform to the C standard.
3213 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3214 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3215 char * when the C standard requires it.
3216
76032d70
PE
3217 * keyboard.c (read_char): Remove unused var.
3218
eb3f1cc8
PE
3219 * eval.c: Port to Windows vsnprintf (Bug#8435).
3220 Include <limits.h>.
3221 (SIZE_MAX): Define if the headers do not.
3222 (verror): Do not give up if vsnprintf returns a negative count.
3223 Instead, grow the buffer. This ports to Windows vsnprintf, which
3224 does not conform to C99. Problem reported by Eli Zaretskii.
3225 Also, simplify the allocation scheme, by avoiding the need for
3226 calling realloc, and removing the ALLOCATED variable.
3227
70476b54
PE
3228 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3229
12020a9e
PE
3230 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3231 But keep the doprint source code for now, as we might revamp it
3232 and use it again (Bug#8435).
ea6c7ae6
PE
3233 * lisp.h (doprnt): Remove.
3234 * Makefile.in (base_obj): Remove doprnt.o.
3235 * deps.mk (doprnt.o): Remove.
3236
5fdb398c
PE
3237 error: Print 32- and 64-bit integers portably (Bug#8435).
3238 Without this change, on typical 64-bit hosts error ("...%d...", N)
3239 was used to print both 32- and 64-bit integers N, which relied on
3240 undefined behavior.
3241 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3242 New macro.
3243 * lisp.h (error, verror): Mark as printf-like functions.
3244 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3245 Report overflow in size calculations when allocating printf buffer.
3246 Do not truncate output string at its first null byte.
3247 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3248 Truncate the output at a character boundary, since vsnprintf does not
3249 do that.
3250 * charset.c (check_iso_charset_parameter): Convert internal
3251 character to string before calling 'error', since %c now has the
3252 printf meaning.
3253 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3254 overflow when computing char to be passed to 'error'. Do not
3255 pass Lisp_Object to 'error'; pass the integer instead.
3256 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3257 formatted with plain %d.
3258
b189fa66
PE
3259 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3260
bff87ef0
PE
3261 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3262
7e2cac20
PE
3263 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3264
ce4d90b5
PE
3265 * xterm.c (x_catch_errors): Remove duplicate declaration.
3266
266c9547
PE
3267 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3268
79c49ad2
PE
3269 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3270
368f4090
JM
32712011-04-10 Jim Meyering <meyering@redhat.com>
3272
3273 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3274 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3275 return ssize_t not "int", and use size_t as the buffer length.
3276 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3277 * gnutls.h: Update declarations.
3278 * process.c (read_process_output): Use ssize_t, to match.
3279 (send_process): Likewise.
3280
a32d4040
CY
32812011-04-09 Chong Yidong <cyd@stupidchicken.com>
3282
3283 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3284
8546720e 32852011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3286
04f2d78b
CB
3287 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3288 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3289
8546720e
GM
3290 * xterm.c (handle_one_xevent):
3291 * xmenu.c (create_and_show_popup_menu):
3292 * xselect.c (x_decline_selection_request)
3293 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3294
0a2f5c1a 32952011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3296
3297 Fix some uses of `int' instead of EMACS_INT.
3298 * search.c (string_match_1, fast_string_match)
3299 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3300 (scan_buffer, find_next_newline_no_quit)
3301 (find_before_next_newline, search_command, Freplace_match)
3302 (Fmatch_data): Make some `int' variables be EMACS_INT.
3303
3304 * xdisp.c (display_count_lines): 3rd argument and return value now
3305 EMACS_INT. All callers changed.
3306 (pint2hrstr): Last argument is now EMACS_INT.
3307
3308 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3309 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3310 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3311 (decode_coding_utf_16, decode_coding_emacs_mule)
3312 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3313 (decode_coding_ccl, decode_coding_charset)
3314 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3315 (decode_coding_iso_2022, decode_coding_emacs_mule)
3316 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3317 <char_offset, last_offset>: Declare EMACS_INT.
3318 (encode_coding_utf_8, encode_coding_utf_16)
3319 (encode_coding_emacs_mule, encode_invocation_designation)
3320 (encode_designation_at_bol, encode_coding_iso_2022)
3321 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3322 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3323 Declare EMACS_INT.
3324 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3325 (encode_invocation_designation): Last argument P_NCHARS is now
3326 EMACS_INT.
3327 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3328 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3329
3330 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3331 All users changed.
3332
3333 * ccl.c (Fccl_execute_on_string): Declare some variables
3334 EMACS_INT.
3335
8546720e 33362011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3337
3338 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3339
4e19a977
CS
33402011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3341
3342 * process.c (Fformat_network_address): Doc fix.
3343
87302331
R
33442011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3345
3346 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3347
cbb59342
CY
33482011-04-08 Chong Yidong <cyd@stupidchicken.com>
3349
3350 * keyboard.c (read_char): Call Lisp function help-form-show,
3351 instead of using internal_with_output_to_temp_buffer.
3352 (Qhelp_form_show): New var.
e0d38eeb 3353 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3354
3355 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3356
3357 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3358
e67a13ab
CY
33592011-04-06 Chong Yidong <cyd@stupidchicken.com>
3360
04f2d78b
CB
3361 * process.c (Flist_processes): Remove to Lisp.
3362 (list_processes_1): Delete.
e67a13ab 3363
973f782d
EZ
33642011-04-06 Eli Zaretskii <eliz@gnu.org>
3365
7c106b1e
EZ
3366 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3367
973f782d
EZ
3368 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3369
41cf7d1a 33702011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3371
ca23cc88
PE
3372 Fix more problems found by GCC 4.6.0's static checks.
3373
f390e2d5
PE
3374 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3375
42eea0d0
PE
3376 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3377
b69769da 3378 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3379
f9541e84
PE
3380 * xdisp.c (vmessage): Mark as a printf-like function.
3381
13841b55
PE
3382 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3383
c136c10f
PE
3384 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3385
5e2d4a30
PE
3386 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3387 printf-like functions.
3388 (tiff_load): Add casts to remove these marks before passing them
3389 to system-supplied API.
3390
583f48b9
PE
3391 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3392
b25d760e
PE
3393 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3394 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3395 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3396 directly, rather than having caller test rule sign. This avoids
3397 some unnecessary tests.
3398 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3399 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3400 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3401
bc7b6697 3402 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3403 (xfont_open): Avoid unnecessary tests.
bc7b6697 3404
27ccc379
PE
3405 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3406
dcd5c89a
PE
3407 * composite.h, composite.c (composition_gstring_put_cache):
3408 Use EMACS_INT, not int, for length.
3409
b13a45c6
PE
3410 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3411 breaking out part of COMPOSITION_DECODE_RULE.
3412 (COMPOSITION_DECODE_RULE): Use it.
3413 * composite.c (get_composition_id): Remove unused local vars,
3414 by using the new macro.
3415
1e792e4d
PE
3416 * textprop.c (set_text_properties_1): Change while to do-while,
3417 since the condition is always true at first.
3418
dc6c6455 3419 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3420 (interval_deletion_adjustment): Return unsigned value.
3421 All uses changed.
dc6c6455 3422
aba7731a
PE
3423 * process.c (list_processes_1, create_pty, read_process_output):
3424 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3425 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3426 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3427 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3428 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3429
fdfc4bf3
PE
3430 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3431
fca8fe46 3432 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3433 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3434
06a0259a 3435 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3436 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3437 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3438
e7b9e80f
PE
3439 * print.c (print_error_message): Avoid int overflow.
3440
56201685
PE
3441 * font.c (font_list_entities): Redo for clarity,
3442 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3443
78834453 3444 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3445 (font_score): Avoid potential overflow in diff calculation.
78834453 3446
0bc0b309 3447 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3448 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3449
e610eaca
PE
3450 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3451
b895abce
PE
3452 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3453 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3454 can always succeed if overflow has undefined behavior.
3455
1f1d9321 3456 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3457 (wordify): Omit three unnecessary tests.
1f1d9321 3458
c59478bc
PE
3459 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3460 All callers changed. This avoids the need for an unused var.
3461
79b73827
PE
3462 * casefiddle.c (casify_region): Remove var that is set but not used.
3463
a4db5dfe
PE
3464 * dired.c (file_name_completion): Remove var that is set but not used.
3465
43aae36e
PE
3466 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3467
2a47c44d 3468 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3469 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3470
a37c69bf
PE
3471 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3472 Check for integer overflow on size calculations.
3473
328ab8e7
PE
3474 * buffer.c (Fprevious_overlay_change): Remove var that is set
3475 but not used.
3476
e5a2a5cb
PE
3477 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3478 Remove vars that are set but not used.
8d84a6eb 3479 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3480 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3481
a60e5f68
PE
3482 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3483
f661cb61 3484 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3485 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3486
f0397f5a
PE
3487 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3488 that are set but not used.
3489
8664db06 3490 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3491 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3492
6abdaa4a
PE
3493 * xselect.c (x_get_local_selection, x_handle_property_notify):
3494 Remove vars that are set but not used.
3495
0ce7538d 3496 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3497 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3498
9ae848fc
PE
3499 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3500 Remove var that is set but not used.
0b918413
PE
3501 (scroll_bar_windows_size): Now size_t, not int.
3502 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3503 Check for overflow.
9ae848fc 3504
a5a62657
PE
3505 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3506 (map_tty_color) [!defined MSDOS]: Likewise.
3507
5c5cdd39
PE
3508 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3509
66ebf983
PE
3510 * coding.c: Remove vars that are set but not used.
3511 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3512 All callers changed.
3513 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3514 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3515 (decode_coding_charset): Remove vars that are set but not used.
3516
1be4d761
PE
3517 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3518 that is set but not used.
3519
47553fa8
PE
3520 * print.c (print_object): Remove var that is set but not used.
3521
1f7196bf 3522 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3523 The gnulib version avoids calling malloc in the usual case,
3524 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3525 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3526 * filelock.c (current_lock_owner): Likewise.
3527 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3528 * sysdep.c: Include allocator.h, careadlinkat.h.
3529 (emacs_no_realloc_allocator): New static constant.
3530 (emacs_readlink): New function.
fdb61804
PE
3531 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3532 ../lib/careadlinkat.h.
d1fdcab7 3533
f84c17c7
SM
35342011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3535
3536 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3537 first non-nil return value).
3538
ef3862ad
JD
35392011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3540
3541 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3542 if not defined (Bug#8403).
3543
376a7006
JB
35442011-04-02 Juanma Barranquero <lekktu@gmail.com>
3545
3546 * xdisp.c (display_count_lines): Remove parameter `start',
3547 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3548 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3549 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3550 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3551 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3552 and thereabouts. All callers changed.
3553 (get_per_char_metric): Remove parameter `f', unused since
3554 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3555
6ca3801d
JM
35562011-04-02 Jim Meyering <meyering@redhat.com>
3557
3558 do not dereference NULL upon failed strdup
3559 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3560 (ns_get_family): Likewise.
3561
d8e2b5ba
JB
35622011-04-02 Juanma Barranquero <lekktu@gmail.com>
3563
3564 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3565
8c74fcbd
JD
35662011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3567
3568 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3569 later (Bug#8403).
3570
7200d79c
SM
35712011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3572
03408648 3573 Add lexical binding.
7200d79c 3574
03408648
SM
3575 * window.c (Ftemp_output_buffer_show): New fun.
3576 (Fsave_window_excursion):
3577 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3578
3579 * lread.c (lisp_file_lexically_bound_p): New function.
3580 (Fload): Bind Qlexical_binding.
3581 (readevalloop): Remove `evalfun' arg.
3582 Bind Qinternal_interpreter_environment.
3583 (Feval_buffer): Bind Qlexical_binding.
3584 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3585 Mark as dynamic.
3586 (syms_of_lread): Declare `lexical-binding'.
3587
3588 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3589
3590 * keyboard.c (eval_dyn): New fun.
3591 (menu_item_eval_property): Use it.
ca105506
SM
3592
3593 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3594
03408648
SM
3595 * fns.c (concat, mapcar1): Accept byte-code-functions.
3596
3597 * eval.c (Fsetq): Handle lexical vars.
3598 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3599 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3600 (FletX, Flet): Obey lexical binding.
3601 (Fcommandp): Handle closures.
3602 (Feval): New `lexical' arg.
3603 (eval_sub): New function extracted from Feval. Use it almost
3604 everywhere where Feval was used. Look up vars in lexical env.
3605 Handle closures.
3606 (Ffunctionp): Move from subr.el.
3607 (Ffuncall): Handle closures.
3608 (apply_lambda): Remove `eval_flags'.
3609 (funcall_lambda): Handle closures and new byte-code-functions.
3610 (Fspecial_variable_p): New function.
3611 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3612 but without exporting it to Lisp.
23aba0ea 3613
23aba0ea 3614 * doc.c (Fdocumentation, store_function_docstring):
03408648 3615 * data.c (Finteractive_form): Handle closures.
23aba0ea 3616
03408648
SM
3617 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3618 interactive spec.
ba83908c 3619
04f2d78b
CB
3620 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3621 New byte-codes.
03408648
SM
3622 (exec_byte_code): New function extracted from Fbyte_code to handle new
3623 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3624
03408648 3625 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3626
03408648 3627 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3628
e2abce01
JB
36292011-03-31 Juanma Barranquero <lekktu@gmail.com>
3630
3631 * xdisp.c (redisplay_internal): Fix prototype.
3632
63696a73 36332011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3634
63696a73 3635 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3636 (try_scrolling): Use it when setting scroll_limit.
3637 Limit scrolling to 100 screen lines.
63696a73
EZ
3638 (redisplay_window): Even when falling back on "recentering",
3639 position point in the window according to scroll-conservatively,
3640 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3641
3642 (try_scrolling): When point is above the window, allow searching
3643 as far as scroll_max, or one screenful, to compute vertical
3644 distance from PT to the scroll margin position. This prevents
3645 try_scrolling from unnecessarily failing when
3646 scroll-conservatively is set to a value slightly larger than the
3647 window height. Clean up the case of PT below the margin at bottom
3648 of window: scroll_max can no longer be INT_MAX. When aggressive
3649 scrolling is in use, don't let point enter the opposite scroll
3650 margin as result of the scroll.
3651 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3652 threshold of 100 lines for never-recentering scrolling.
3653
e4cc2dfc
JB
36542011-03-31 Juanma Barranquero <lekktu@gmail.com>
3655
3656 * dispextern.h (move_it_by_lines):
3657 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3658 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3659 (message_log_check_duplicate): Remove parameters `prev_bol' and
3660 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3661 (redisplay_internal): Remove parameter `preserve_echo_area',
3662 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3663
3664 * indent.c (Fvertical_motion):
3665 * window.c (window_scroll_pixel_based, Frecenter):
3666 Don't pass `need_y_p' to `move_it_by_lines'.
3667
1c470562
SM
36682011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3669
44f230aa
SM
3670 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3671 steal a few bits to be more compact.
3672 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3673 Remove unneeded casts.
3674
1c470562
SM
3675 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3676
888adce9
ZK
36772011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3678
3679 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3680 binding" message (bug#7967).
3681
f838ed7b
PE
36822011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3683
77861b95
PE
3684 Fix more problems found by GCC 4.6.0's static checks.
3685
de6dbc14
PE
3686 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3687 Remove unused local var.
3688
f838ed7b
PE
3689 * editfns.c (Fmessage_box): Remove unused local var.
3690
792c7b2b
PE
3691 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3692 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3693 Omit unused local vars.
c499e557 3694 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3695 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3696 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3697 Omit unused local var.
3698
ba0165e1
PE
3699 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3700 Don't assume string length fits in int.
32ad8845 3701 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3702 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3703
3c59b4c9
PE
3704 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3705 instead of alloca (Bug#8344).
3706
a3eed478 3707 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3708 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3709
eb4d412d
PE
3710 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3711
1658b401
PE
3712 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3713 concerns.
3714
3715 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3716
3717 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3718
9a2c6e05
PE
3719 * keyboard.c (syms_of_keyboard): Use the same style as later
3720 in this function when indexing through an array. This also
3721 works around GCC bug 48267.
3722
03d0a109
PE
3723 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3724
44f730c8
PE
3725 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3726
fe75f926
PE
3727 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3728 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3729
ffa8c828
PE
3730 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3731 This avoids undefined behavior on integer overflow, and is a bit
3732 more convenient anyway since it is compared to a size_t variable.
3733
c5101a77
PE
3734 Variadic C functions now count arguments with size_t, not int.
3735 This avoids an unnecessary limitation on 64-bit machines, which
3736 caused (substring ...) to crash on large vectors (Bug#8344).
3737 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3738 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3739 All variadic functions and their callers changed accordingly.
c5101a77
PE
3740 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3741 * data.c (arith_driver, float_arith_driver): Likewise.
3742 * editfns.c (general_insert_function): Likewise.
3743 * eval.c (struct backtrace.nargs, interactive_p)
3744 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3745 (funcall_lambda, mark_backtrace): Likewise.
3746 * fns.c (concat): Likewise.
3747 * frame.c (x_set_frame_parameters): Likewise.
3748 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3749 0 if not found, not -1. All callers changed.
3750
dd3f25f7
PE
3751 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3752 (stack_copy_size): Now size_t, not int.
3753 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3754
461c2ab9
JB
37552011-03-28 Juanma Barranquero <lekktu@gmail.com>
3756
3757 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3758 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3759 All callers changed.
3760
3761 * lisp.h (multibyte_char_to_unibyte):
3762 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3763 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3764 * character.h (CHAR_TO_BYTE8):
3765 * cmds.c (internal_self_insert):
3766 * editfns.c (general_insert_function):
3767 * keymap.c (push_key_description):
3768 * search.c (Freplace_match):
3769 * xdisp.c (message_dolog, set_message_1): All callers changed.
3770
f6d62986
SM
37712011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3772
3773 * keyboard.c (safe_run_hook_funcall): New function.
3774 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3775 don't set the hook to nil, but remove the offending function instead.
3776 (Qcommand_hook_internal): Remove, unused.
3777 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3778 Vcommand_hook_internal.
3779
3780 * eval.c (enum run_hooks_condition): Remove.
3781 (funcall_nil, funcall_not): New functions.
3782 (run_hook_with_args): Call each function through a `funcall' argument.
3783 Remove `cond' argument, now redundant.
3784 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3785 (Frun_hook_with_args_until_failure): Adjust accordingly.
3786 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3787
1db5b1ad
JB
37882011-03-28 Juanma Barranquero <lekktu@gmail.com>
3789
3790 * dispextern.h (string_buffer_position): Remove declaration.
3791
3792 * print.c (strout): Remove parameter `multibyte', unused since
3793 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3794
3795 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3796 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3797 All callers changed.
3798
3799 * w32.c (_wsa_errlist): Use braces for struct initializers.
3800
3801 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3802 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3803 All callers changed.
3804 (string_buffer_position): Likewise. Also, make static (it's never
3805 used outside xdisp.c).
3806 (cursor_row_p): Remove parameter `w', unused since
3807 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3808 (decode_mode_spec): Remove parameter `precision', introduced during
3809 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3810 All callers changed.
3811
5ffb62aa
JD
38122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3813
3814 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3815
461c2ab9 38162011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3817
3818 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3819 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3820 (ns_update_auto_hide_menu_bar): New functions.
3821 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3822 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3823 ns_constrain_all_frames.
3824 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3825 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3826
5c380ffb
JD
38272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3828
3829 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3830
9af30bdf
GM
38312011-03-27 Glenn Morris <rgm@gnu.org>
3832
3833 * syssignal.h: Replace RETSIGTYPE with void.
3834 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3835 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3836 Replace SIGTYPE with void everywhere.
3837 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3838 * s/template.h (SIGTYPE): Remove commented out definition.
3839
e2abce01
JB
38402011-03-26 Eli Zaretskii <eliz@gnu.org>
3841
3842 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3843 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3844
f868cd8a
JB
38452011-03-26 Juanma Barranquero <lekktu@gmail.com>
3846
59eb0929
JB
3847 * w32.c (read_unc_volume): Use parameter `henum', instead of
3848 global variable `wget_enum_handle'.
3849
3850 * keymap.c (describe_vector): Remove parameters `indices' and
3851 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3852 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3853
f868cd8a
JB
3854 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3855
3856 * keyboard.c (timer_check): Remove parameter `do_it_now',
3857 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3858 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3859 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3860
3861 * keyboard.c (read_char):
3862 * w32menu.c (w32_menu_display_help):
3863 * xmenu.c (show_help_event, menu_help_callback):
3864 Adjust calls to `show_help_echo'.
3865
3866 * gtkutil.c (xg_maybe_add_timer):
3867 * keyboard.c (readable_events):
3868 * process.c (wait_reading_process_output):
3869 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3870
3871 * insdel.c (adjust_markers_gap_motion):
3872 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3873 (gap_left, gap_right): Don't call it.
3874
2ecf6fdb
CY
38752011-03-25 Chong Yidong <cyd@stupidchicken.com>
3876
3877 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3878 incurred during fontification.
3879
6b1f9ba4
JB
38802011-03-25 Juanma Barranquero <lekktu@gmail.com>
3881
3882 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3883 (DEFVAR_PER_BUFFER): Don't pass it.
3884
3885 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3886 (scrolling_window): Don't pass it.
3887
0f4a96b5
JB
38882011-03-25 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3891
3892 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3893 and `suffix'.
3894 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3895 of variables specific to SELinux and computation of `encoded_absname'.
3896
3897 * image.c (XPutPixel): Remove unused variable `height'.
3898
3899 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3900
3901 * unexw32.c (get_section_info): Remove unused variable `section'.
3902
3903 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3904 (system_process_attributes): Remove unused variable `sess'.
3905 (sys_read): Remove unused variable `err'.
3906
3907 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3908 (w32_wnd_proc): Remove unused variable `isdead'.
3909 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3910 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3911 (x_create_tip_frame): Remove unused variable `tem'.
3912
3913 * w32inevt.c (w32_console_read_socket):
3914 Remove unused variable `no_events'.
3915
3916 * w32term.c (x_draw_composite_glyph_string_foreground):
3917 Remove unused variable `width'.
3918
1149507c
JB
39192011-03-24 Juanma Barranquero <lekktu@gmail.com>
3920
3921 * w32term.c (x_set_glyph_string_clipping):
3922 Don't pass uninitialized region to CombineRgn.
3923
9c88f339
JB
39242011-03-23 Juanma Barranquero <lekktu@gmail.com>
3925
3926 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3927 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3928 (Fx_close_connection): Remove unused variable `i'.
3929
3930 * w32font.c (w32font_draw): Return number of glyphs.
3931 (w32font_open_internal): Remove unused variable `i'.
3932 (w32font_driver): Add missing initializer.
3933
3934 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3935 (fill_in_menu): Remove unused variable `items_added'.
3936
3937 * w32term.c (last_mouse_press_frame): Remove static global variable.
3938 (w32_clip_to_row): Remove unused variable `f'.
3939 (x_delete_terminal): Remove unused variable `i'.
3940
3941 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3942 (NOTHING): Remove unused static global variable.
3943 (uniscribe_check_otf): Remove unused variable `table'.
3944 (uniscribe_font_driver): Add missing initializers.
3945
dee091a3
JD
39462011-03-23 Julien Danjou <julien@danjou.info>
3947
3948 * term.c (Fsuspend_tty, Fresume_tty):
3949 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3950 * window.c (temp_output_buffer_show):
3951 * insdel.c (signal_before_change):
3952 * frame.c (Fhandle_switch_frame):
3953 * fileio.c (Fdo_auto_save):
3954 * emacs.c (Fkill_emacs):
3955 * editfns.c (save_excursion_restore):
3956 * cmds.c (internal_self_insert):
3957 * callint.c (Fcall_interactively):
3958 * buffer.c (Fkill_all_local_variables):
3959 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3960 Use Frun_hooks.
0f4a96b5 3961 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3962 unconditionnaly since it does the check itself.
3963
2c520ab5 39642011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3965
c9c49752
PE
3966 Fix more problems found by GCC 4.5.2's static checks.
3967
8abc3f12
PE
3968 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3969 the first time through the loop, since we know p0 < p1 then.
3970 This also avoids a gcc -Wstrict-overflow warning.
3971
a2d26660
PE
3972 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3973 leading to a memory leak, possible in functions like
3974 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3975 of objects (Bug#8318).
a2d26660 3976
916c72e9
PE
3977 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3978 that could (at least in theory) be that large.
3979
19ab8a18
PE
3980 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3981 This is less likely to overflow, and avoids undefined behavior if
3982 overflow does occur. All callers changed. Use strtoul to scan
3983 for the unsigned long integer.
b7cbbd6f
PE
3984 (pint2hrstr): Simplify and tune code slightly.
3985 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3986
f0641eff
PE
3987 * scroll.c (do_scrolling): Work around GCC bug 48228.
3988 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3989
7f650bb9
PE
3990 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3991 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3992 (validate_x_resource_name): Simplify count usage.
3993 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3994
37dd57d1
PE
3995 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3996 fail (Bug#8306).
81e56e61 3997
699979fc 3998 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3999
401bf9b4
PE
4000 * process.c (Fmake_network_process): Use socklen_t, not int,
4001 where POSIX says socklen_t is required in portable programs.
4002 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4003 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4004 (Fmake_network_process, server_accept_connection):
4005 (wait_reading_process_output, read_process_output):
4006 Likewise.
4007
b93aacde
PE
4008 * process.c: Rename or move locals to avoid shadowing.
4009 (list_processes_1, Fmake_network_process):
4010 (read_process_output_error_handler, exec_sentinel_error_handler):
4011 Rename or move locals.
4dc343ee 4012 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4013 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4014 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4015 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4016 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4017
af8a867c 4018 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4019 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4020 Include tparam.h instead, since it declares them.
af8a867c
PE
4021 * cm.h (PC): Remove extern decl; tparam.h now does this.
4022 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4023 * terminfo.c: Include tparam.h, to check interfaces.
4024 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4025 (tparam): Adjust signature to match interface in tparam.h;
4026 this removes some undefined behavior. Check that outstring and len
4027 are zero, which they always are with Emacs.
4028 * tparam.h (PC, BC, UP): New extern decls.
4029
0248044d 4030 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4031 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4032
8ff096c1 4033 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4034 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4035 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4036 (ftfont_list): Remove unused local.
49eaafba
PE
4037 (get_adstyle_property, ftfont_pattern_entity):
4038 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4039 Rename locals to avoid shadowing.
8ff096c1 4040
e2be39f6
PE
4041 * xfont.c (xfont_list_family): Mark var as initialized.
4042
c9735e30
PE
4043 * xml.c (make_dom): Now static.
4044
8f5201ae
PE
4045 * composite.c (composition_compute_stop_pos): Rename local to
4046 avoid shadowing.
b246f932
PE
4047 (composition_reseat_it): Remove unused locals.
4048 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4049 (composition_update_it): Mark var as initialized.
11b61122
PE
4050 (find_automatic_composition): Mark vars as initialized,
4051 with a FIXME (Bug#8290).
8f5201ae 4052
760fbc2c
PE
4053 character.h: Rename locals to avoid shadowing.
4054 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4055 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4056 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4057 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4058 to avoid shadowing.
4059
ff08eb85
PE
4060 * textprop.c (property_change_between_p): Remove; unused.
4061
fc7bf025
PE
4062 * intervals.c (interval_start_pos): Now static.
4063
235d7abc
PE
4064 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4065
44f230aa
SM
4066 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4067 Rename locals to avoid shadowing.
3e7d6594 4068
50060332
PE
4069 * sound.c (wav_play, au_play, Fplay_sound_internal):
4070 Fix pointer signedness.
d01f234b 4071 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4072 (wav_play): Initialize a variable to 0, to prevent undefined
4073 behavior (Bug#8278).
50060332 4074
c4fc4e30
PE
4075 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4076
918436ed
PE
4077 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4078
c939f91b
PE
4079 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4080 clobbering (Bug#8298).
b9c7f648
PE
4081 * sysdep.c (sys_subshell): Likewise.
4082 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4083
6bd8c144
PE
4084 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4085 This should get cleaned up, so that child_setup has the
4086 same signature on all platforms.
4087
7710357c 4088 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4089 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4090
c59da222
CY
40912011-03-22 Chong Yidong <cyd@stupidchicken.com>
4092
4093 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4094 not to be necessary, and produces flickering.
4095
66b87493
GM
40962011-03-20 Glenn Morris <rgm@gnu.org>
4097
4098 * config.in: Remove file.
4099
45b6f6d5
JB
41002011-03-20 Juanma Barranquero <lekktu@gmail.com>
4101
4102 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4103 are now in src/globals.h.
4104 (syms_of_minibuf): Remove spurious & from previous change.
4105
3ec03f7e
LL
41062011-03-20 Leo <sdl.web@gmail.com>
4107
4108 * minibuf.c (completing-read-function): New variable.
4109 (completing-read-default): Rename from completing-read.
4110 (completing-read): Call completing-read-function.
4111
b14e3e21
CY
41122011-03-19 Juanma Barranquero <lekktu@gmail.com>
4113
4114 * xfaces.c (Fx_load_color_file):
4115 Read color file from absolute filename (bug#8250).
4116
f2b726e6
JB
41172011-03-19 Juanma Barranquero <lekktu@gmail.com>
4118
4119 * makefile.w32-in: Update dependencies.
4120
09f6ff02
EZ
41212011-03-17 Eli Zaretskii <eliz@gnu.org>
4122
4123 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4124
29a6015a
PE
41252011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4126
a3a6c54e
PE
4127 Fix more problems found by GCC 4.5.2's static checks.
4128
b766f867
PE
4129 * process.c (make_serial_process_unwind, send_process_trap):
4130 (sigchld_handler): Now static.
4131
be02381c
PE
4132 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4133 That way, the code declares only the vars that it needs.
4134 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4135 * s/cygwin.h (PTY_ITERATION): Likewise.
4136 * s/darwin.h (PTY_ITERATION): Likewise.
4137 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4138
57048744
PE
4139 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4140 * process.c (allocate_pty): Don't declare stb unless it's needed.
4141
7914961c 4142 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4143 (CONSTANTLIM): Remove; unused.
4144 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4145 Define only if needed.
7914961c 4146
b3967b18
PE
4147 * unexelf.c (unexec): Name an expression,
4148 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4149 Use a different way to cause a compilation error if anyone uses
4150 n rather than nn, a way that does not involve shadowing.
73366a00 4151 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4152
29a6015a
PE
4153 * deps.mk (unexalpha.o): Remove; unused.
4154
43cfc33e 4155 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4156 * unexec.h: New file.
ce701a33
PE
4157 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4158 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4159 Depend on unexec.h.
4160 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4161 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4162 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4163 Change as necessary to match prototype in unexec.h.
ce701a33 4164
01f44d5a
PE
4165 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4166 shadowing.
4f63c6bb 4167 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4168
a6670b0b
PE
4169 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4170 Rename locals to avoid shadowing.
4171
cef2010d 4172 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4173 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4174
d4d7173a
PE
4175 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4176
f08b802a
PE
4177 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4178 warning when compiling print.c.
4179
3ddb0639
PE
4180 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4181 instead of using an uninitialized var.
5ad03b97 4182 (font_sort_entities): Mark var as initialized.
3ddb0639 4183
170a2692
PE
4184 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4185
e663c700
PE
4186 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4187 pointers to constants.
89bc529a 4188 (font_parse_fcname): Remove unused vars.
7b81e2d0 4189 (font_delete_unmatched): Now static.
ea838e10 4190 (font_get_spec): Remove; unused.
13a547c6
PE
4191 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4192 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4193 Rename or move locals to avoid shadowing.
e663c700 4194
2a80c887 4195 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4196 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4197
1384fa33 4198 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4199 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4200
8b2c52e9
PE
4201 * alloc.c (mark_backtrace): Move decl from here ...
4202 * lisp.h: ... to here, so that it can be checked.
4203
475545b5 4204 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4205 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4206 (lisp_indirect_variable): Name an expression,
4207 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4208 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4209
b1349114 4210 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4211 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4212 Use const pointer when appropriate.
b1349114 4213
a2928364
PE
4214 * lisp.h (get_system_name, get_operating_system_release):
4215 Move decls here, to check interfaces.
4216 * process.c (get_operating_system_release): Move decl to lisp.h.
4217 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4218 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4219 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4220 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4221 (Fformat_time_string, Fencode_time, Finsert_char):
4222 (Ftranslate_region_internal, Fformat):
4223 Rename or remove local vars to avoid shadowing.
9710023e 4224 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4225
a415e694
PE
4226 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4227 avoid shadowing.
4228
8ef4622d
PE
4229 * lisp.h (eassert): Check that the argument compiles, even if
4230 ENABLE_CHECKING is not defined.
4231
946f9a5b
PE
4232 * data.c (Findirect_variable): Name an expression, to avoid
4233 gcc -Wbad-function-cast warning.
112396d6 4234 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4235 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4236 (Fmake_variable_buffer_local, Fmake_local_variable):
4237 Mark variables as initialized.
52746918 4238 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4239
e5aab7e7 4240 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4241 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4242 Rename locals to avoid shadowing.
dff45157
PE
4243 (mark_stack): Move local variables into the #ifdef region where
4244 they're used.
7bc26fdb
PE
4245 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4246 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4247 needed otherwise.
4248 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4249 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4250 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4251
e5aab7e7
PE
4252 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4253 avoids undefined behavior in theory.
4254
4da60324
PE
4255 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4256
88043301
PE
4257 Use functions, not macros, for up- and down-casing (Bug#8254).
4258 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4259 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4260 to use the following functions instead of these macros.
4261 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4262 EMACS_INT, since callers assume the returned value fits in int.
4263 (upcase1): Likewise, for UPCASE_TABLE.
4264 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4265 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4266 the race-condition problem in the old DOWNCASE.
88043301 4267
19ed5445
PE
4268 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4269 Rename locals to avoid shadowing.
4270 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4271 (regex_compile, re_search_2, re_match_2_internal):
4272 Remove unused local vars.
952db0d7
PE
4273 (FREE_VAR): Rewrite so as not to use empty "else",
4274 which gcc can warn about.
da053e48 4275 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4276 (RETALLOC_IF): Define only if needed.
4277 (WORDCHAR_P): Likewise. This one is never needed, but is used
4278 only in a comment talking about a compiler bug, so put inside
4279 the #if 0 of that comment.
4280 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4281 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4282 Remove; unused.
19ed5445 4283
1f3561e4 4284 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4285 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4286 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4287
ded6f8f7
PE
4288 * search.c (simple_search): Remove unused var.
4289
dbd37a95
PE
4290 * dired.c (compile_pattern): Move decl from here ...
4291 * lisp.h: ... to here, so that it can be checked.
4292 (struct re_registers): New forward decl.
4293
7e47afad
PE
4294 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4295
85f24f61
PE
4296 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4297 All uses changed.
4298 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4299 Rename locals to avoid shadowing.
5671df8f 4300 (Fvertical_motion): Mark locals as initialized.
85f24f61 4301
181aa2be 4302 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4303 (casify_region): Mark local as initialized.
181aa2be 4304
930d429c
PE
4305 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4306
7082eac6
PE
4307 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4308 New macros, so that the caller can use some names other than
4309 gcpro1, gcpro2, etc.
4310 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4311 of the new macros.
4312 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4313 argument, for consistency with GCPRO2_VAR, etc: it is now the
4314 prefix of the variable, not the variable itself. All uses
4315 changed.
38b2c076
PE
4316 * dired.c (directory_files_internal, file_name_completion):
4317 Rename locals to avoid shadowing.
4318
15206ed9
PE
4319 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4320 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4321 dired.c's scmp function, had undefined behavior.
4322 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4323 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4324 * buffer.h: ... to here, because these macros use current_buffer,
4325 and the new implementation with inline functions needs to have
4326 current_buffer in scope now, rather than later when the macros
4327 are used.
4328 (downcase, upcase1): New static inline functions.
4329 (DOWNCASE, UPCASE1): Reimplement using these functions.
4330 This avoids undefined behavior in expressions like
4331 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4332 from race conditions in accessing the global variables
4333 case_temp1 and case_temp2.
4334 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4335 * lisp.h (case_temp1, case_temp2): Remove their decls.
4336 * character.h (ASCII_CHAR_P): Move from here ...
4337 * lisp.h: ... to here, so that the inline functions mentioned
4338 above can use them.
4339
4a6bea26
PE
4340 * dired.c (directory_files_internal_unwind): Now static.
4341
f14b7e14
PE
4342 * fileio.c (file_name_as_directory, directory_file_name):
4343 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4344 Now static.
2893f146
PE
4345 (file_name_as_directory): Use const pointers when appropriate.
4346 (Fexpand_file_name): Likewise. In particular, newdir might
4347 point at constant storage, so make it a const pointer.
fd4ead52 4348 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4349 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4350 signedness issues.
f839df0c
PE
4351 (Fset_file_times, Finsert_file_contents, auto_save_error):
4352 Rename locals to avoid shadowing.
f14b7e14 4353
5716756e 4354 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4355 (Ftry_completion, Fall_completions): Rename or remove locals
4356 to avoid shadowing.
5716756e 4357
b4c3046a
PE
4358 * marker.c (bytepos_to_charpos): Remove; unused.
4359
b45db522
PE
4360 * lisp.h (verify_bytepos, count_markers): New decls,
4361 so that gcc does not warn that these functions aren't declared.
4362
85876d07
PE
4363 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4364 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4365 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4366 (copy_text): Remove unused local var.
85876d07 4367
03d78a21 4368 * filelock.c (within_one_second): Now static.
b3dd38ab 4369 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4370
5df8f01b
PE
4371 * buffer.c (fix_overlays_before): Mark locals as initialized.
4372 (fix_start_end_in_overlays): Likewise. This function should be
4373 simplified by using pointers-to-pointers, but that's a different
4374 matter.
b1d876f1 4375 (switch_to_buffer_1): Now static.
8f54f30a
PE
4376 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4377 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4378
a70072c9 4379 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4380 Fix pointer signedness issue.
edced198
PE
4381 (sys_subshell): Mark local as volatile if checking for lint,
4382 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4383 (MAXPATHLEN): Define only if needed.
a70072c9 4384
a0977c44
PE
4385 * process.c (serial_open, serial_configure): Move decls from here ...
4386 * systty.h: ... to here, so that they can be checked.
4387
a884fdcc
PE
4388 * fns.c (get_random, seed_random): Move extern decls from here ...
4389 * lisp.h: ... to here, so that they can be checked.
4390
604efe86 4391 * sysdep.c (reset_io): Now static.
b8950c94 4392 (wait_for_termination_signal): Remove; unused.
604efe86 4393
38fc62d9
PE
4394 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4395 (copy_keymap_item, append_key, push_text_char_description):
4396 Now static.
1004a21a 4397 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4398 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4399 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4400 (describe_map_tree):
4401 Rename locals to avoid shadowing.
38fc62d9 4402
2f2650da
PE
4403 * keyboard.c: Declare functions static if they are not used elsewhere.
4404 (echo_char, echo_dash, cmd_error, top_level_2):
4405 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4406 (read_char, kbd_buffer_get_event, make_lispy_position):
4407 (make_lispy_event, make_lispy_movement, apply_modifiers):
4408 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4409 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4410 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4411 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4412 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4413
a053e86c 4414 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4415 (mark_kboards): Move decl here ...
4416 * alloc.c (mark_kboards): ... from here.
a053e86c 4417
4752793e
PE
4418 * lisp.h (force_auto_save_soon): New decl.
4419
74f10ca7 4420 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4421 (DEFINE_DUMMY_FUNCTION): New macro.
4422 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4423 Use it.
c03cd23f
PE
4424 (main): Add casts to avoid warnings
4425 if GCC considers string literals to be constants.
74f10ca7 4426
022e70d4
PE
4427 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4428
59d6fe83
PE
4429 * dbusbind.c: Pointer signedness fixes.
4430 (xd_signature, xd_append_arg, xd_initialize):
4431 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4432 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4433 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4434 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4435
78320123
PE
4436 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4437 if GCC considers string literals to be constants.
49cebcca 4438 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4439
35ac2a97
SM
44402011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4441
fb103ca9
SM
4442 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4443 (print_preprocess, print_object): New macro to fix last change.
4444
35ac2a97
SM
4445 * print.c (print_preprocess): Don't forget font objects.
4446
62973b41
JB
44472011-03-16 Juanma Barranquero <lekktu@gmail.com>
4448
4449 * emacs.c (USAGE3): Doc fixes.
4450
0e48bb22
AS
44512011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4452
4453 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4454 structure.
4455
7684e57b
JB
44562011-03-14 Juanma Barranquero <lekktu@gmail.com>
4457
4458 * lisp.h (VWindow_system, Qfile_name_history):
4459 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4460 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4461 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4462
4463 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4464 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4465
4466 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4467 * w32console.c (detect_input_pending, read_input_pending)
4468 (encode_terminal_code):
4469 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4470 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4471 (w32_system_caret_y, Qfile_name_history):
4472 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4473 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4474 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4475 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4476 * w32proc.c (Qlocal, report_file_error):
4477 * w32term.c (Vwindow_system, updating_frame):
4478 * w32uniscribe.c (initialized, uniscribe_font_driver):
4479 Remove unneeded extern declarations.
4480
2aa46d6c
CY
44812011-03-14 Chong Yidong <cyd@stupidchicken.com>
4482
c96bbc66 4483 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4484
cffc6f3b
CY
44852011-03-13 Chong Yidong <cyd@stupidchicken.com>
4486
4487 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4488 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4489 These macros can no longer be used for assignment.
4490
44f230aa
SM
4491 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4492 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4493 (record_buffer_markers, fetch_buffer_markers): New functions for
4494 recording and fetching special buffer markers.
4495 (set_buffer_internal_1, set_buffer_temp): Use them.
4496
4497 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4498
4499 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4500
4501 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4502 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4503
4504 * xdisp.c (hscroll_window_tree):
4505 (reconsider_clip_changes): Use PT instead of BUF_PT.
4506
d251f04b
EZ
45072011-03-13 Eli Zaretskii <eliz@gnu.org>
4508
4509 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4510 $(EMACS_ROOT)/lib/intprops.h.
4511
f0c77cd1
PE
45122011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4513
3eca4629
PE
4514 Fix more problems found by GCC 4.5.2's static checks.
4515
7c86ee98
PE
4516 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4517 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4518 (xg_free_frame_widgets): Make it clear that a local variable is
4519 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4520 (gdk_window_get_screen): Make it clear that this macro is needed
4521 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4522 (int_gtk_range_get_value): New function, which avoids a diagnostic
4523 from gcc -Wbad-function-cast.
4524 (xg_set_toolkit_scroll_bar_thumb): Use it.
4525 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4526 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4527 (get_utf8_string, xg_get_file_with_chooser):
4528 Rename locals to avoid shadowing.
4529 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4530
41729b81
PE
4531 * xgselect.c (xg_select): Remove unused var.
4532
f0c77cd1
PE
4533 * image.c (four_corners_best): Mark locals as initialized.
4534 (gif_load): Initialize transparent_p to zero (Bug#8238).
4535 Mark another local as initialized.
ec6cf4c6 4536 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4537
ce0ad53d 4538 * image.c (clear_image_cache): Now static.
d5d5a617 4539 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4540 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4541 (x_edge_detection): Remove unnecessary cast that
4542 gcc -Wbad-function-cast diagnoses.
2037898d 4543 (gif_load): Fix pointer signedness.
6ae141d6
PE
4544 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4545 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4546
33383987 45472011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4548
d32df629
PE
4549 Improve quality of tests for time stamp overflow.
4550 For example, without this patch (encode-time 0 0 0 1 1
4551 1152921504606846976) returns the obviously-bogus value (-948597
4552 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4553 reports time overflow. See
4554 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4555 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4556 * editfns.c: Include limits.h and intprops.h.
4557 (TIME_T_MIN, TIME_T_MAX): New macros.
4558 (time_overflow): Move earlier, to before first use.
4559 (hi_time, lo_time): New functions, for an accurate test for
4560 out-of-range times.
4561 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4562 (Fget_internal_run_time): Don't assume time_t fits in int.
4563 (make_time): Use list2 instead of Fcons twice.
4564 (Fdecode_time): More accurate test for out-of-range times.
4565 (check_tm_member): New function.
4566 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4567 (lisp_time_argument): Don't rely on undefined left-shift and
4568 right-shift behavior when checking for time stamp overflow.
8be6f318 4569
fe31d94c
PE
4570 * editfns.c (time_overflow): New function, refactoring common code.
4571 (Fformat_time_string, Fdecode_time, Fencode_time):
4572 (Fcurrent_time_string): Use it.
4573
8be6f318
PE
4574 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4575 * dired.c (make_time): Move to ...
4576 * editfns.c (make_time): ... here.
4577 * systime.h: Note the move.
4578
09d9db2c 45792011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4580
126bc0dc
YM
4581 * fringe.c (update_window_fringes): Remove unused variables.
4582
c47cbdfd
YM
4583 * unexmacosx.c (copy_data_segment): Also copy __got section.
4584 (Bug#8223)
4585
7ac80be9
EZ
45862011-03-12 Eli Zaretskii <eliz@gnu.org>
4587
c96bbc66 4588 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4589 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4590 Constify `char *' arguments and their references according to
4591 prototypes in tparam.h.
4592
ecb0f94d 4593 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4594
7ac80be9
EZ
4595 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4596 Adapt all references accordingly.
4597
4598 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4599
ef1fd07e
TT
46002011-03-11 Tom Tromey <tromey@redhat.com>
4601
4602 * buffer.c (syms_of_buffer): Remove obsolete comment.
4603
7ef4b50c
EZ
46042011-03-11 Eli Zaretskii <eliz@gnu.org>
4605
4606 * termhooks.h (encode_terminal_code): Declare prototype.
4607
4608 * msdos.c (encode_terminal_code): Don't declare prototype.
4609
4610 * term.c (encode_terminal_code): Now external again, used by
4611 w32console.c and msdos.c.
4612
44f230aa
SM
4613 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4614 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4615
4b1ec863 46162011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4617
1714f52b 4618 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4619
4b1ec863
PE
4620 * fringe.c (update_window_fringes): Mark locals as initialized
4621 (Bug#8227).
4622 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4623
524c7aa6
PE
4624 * alloc.c (mark_fringe_data): Move decl from here ...
4625 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4626 to check its interface.
4627 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4628
a5c0af81 4629 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4630 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4631 (fontset_font): Mark local as initialized.
a9a06e0b 4632 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4633
b4716021
PE
4634 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4635
811e9bac 4636 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4637 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4638 (x_own_selection, Fx_disown_selection_internal): Rename locals
4639 to avoid shadowing.
4640 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4641
7e3ab302
PE
4642 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4643 so that the caller can use some name other than gcpro1.
4644 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4645 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4646 (Fx_backspace_delete_keys_p):
4647 Use them to avoid shadowing, and rename vars to avoid shadowing.
4648 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4649 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4650 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4651 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4652 Remove unused locals.
7e3ab302
PE
4653 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4654 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4655 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4656 macros.
f78faa98 4657
e2b13473
PE
4658 * xterm.h (x_mouse_leave): New decl.
4659
77f23912
PE
4660 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4661 Remove unused functions.
cdf4ba58
PE
4662 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4663 (x_calc_absolute_position): Now static.
7411c686 4664 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4665 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4666 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4667 unless they are used.
38d0b34a
PE
4668 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4669 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4670 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4671 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4672 (x_error_catcher, x_connection_closed, x_error_handler):
4673 (x_error_quitter, xembed_send_message, x_iconify_frame):
4674 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4675 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4676 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4677
44f230aa
SM
4678 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4679 Rename or move locals to avoid shadowing.
6b463e58 4680 (tty_defined_color, merge_face_heights): Now static.
5967d051 4681 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4682 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4683 does not deduce is never used uninitialized.
73719eba
PE
4684 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4685 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4686
426994c3 4687 * terminal.c (store_terminal_param): Now static.
5489860b 4688
032f1620 4689 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4690 (set_frame_menubar): Remove unused local.
d4323972 4691 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4692 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4693 since they might point to immutable storage.
281585b0
PE
4694 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4695 since it's unused otherwise.
032f1620 4696
367c19e5 4697 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4698 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4699 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4700 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4701 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4702 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4703 does not deduce are never used uninitialized.
70739cbe 4704
07b48fa9
PE
4705 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4706
8868a238 4707 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4708 * window.c (window_loop, size_window):
4709 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4710
7e5cf297 4711 * window.c (display_buffer): Now static.
d6550a9f
PE
4712 (size_window): Mark variables that gcc -Wuninitialized
4713 does not deduce are never used uninitialized.
a586633d
PE
4714 * window.h (check_all_windows): New decl, to forestall
4715 gcc -Wmissing-prototypes diagnostic.
5b555da1 4716 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4717
f6095868
PE
4718 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4719 shadowing.
4720 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4721 Include <limits.h>.
4722 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4723 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4724 (load_charset_map): Mark variables that gcc -Wuninitialized
4725 does not deduce are never used uninitialized.
53df7c11 4726 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4727
f38b440c
PE
4728 * coding.c (coding_set_source, coding_set_destination):
4729 Use "else { /* comment */ }" rather than "else /* comment */;"
4730 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4731 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4732 a block, when the outer 'i' will do.
4733 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4734 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4735 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4736 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4737 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4738 Rename locals to avoid shadowing.
4739 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4740 * coding.c (emacs_mule_char, encode_invocation_designation):
4741 Now static, since they're not used elsewhere.
413bb2db 4742 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4743 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4744 (decode_coding_emacs_mule): Mark variables that gcc
4745 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4746 (detect_coding_iso_2022): Initialize a local variable that might
4747 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4748 this initialization is needed. (Bug#8211)
5f58e762
PE
4749 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4750 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4751 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4752 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4753 Remove unused macros.
f38b440c 4754
232b38b9 4755 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4756 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4757 * character.c (string_count_byte8): Likewise.
232b38b9 4758
fb90da1b
PE
4759 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4760 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4761
fb93dbc2
PE
4762 * chartab.c (copy_sub_char_table): Now static, since it's not used
4763 elsewhere.
5c156ace
PE
4764 (sub_char_table_ref_and_range, char_table_ref_and_range):
4765 Rename locals to avoid shadowing.
bbcd0949 4766 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4767
7d3b3862 4768 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4769 (BIDI_BOB): Remove unused macro.
7d3b3862 4770
6be7d3da
PE
4771 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4772 deduce are never used uninitialized.
c2ed9c8b 4773 * term.c (encode_terminal_code): Likewise.
6be7d3da 4774
75f8807f 4775 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4776
50938595
PE
4777 * tparam.h: New file.
4778 * term.c, tparam.h: Include it.
4779 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4780 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4781 Move these decls to tparam.h, and make them agree with what
4782 is actually in tparam.c. The previous trick of using incompatible
4783 decls in different modules does not conform to the C standard.
4784 All callers of tparam changed to use tparam's actual API.
4785 * tparam.c (tparam1, tparam, tgoto):
4786 Use const pointers where appropriate.
4787
fbceeba2
PE
4788 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4789 * cm.h (struct cm): Likewise.
4790 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4791 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4792 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4793 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4794 (turn_on_face, init_tty): Likewise.
4795 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4796
7f3f1250
PE
4797 * term.c (term_mouse_position): Rename local to avoid shadowing.
4798
e6ca6543
PE
4799 * alloc.c (mark_ttys): Move decl from here ...
4800 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4801
c40f8d15
AS
48022011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4803
4804 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4805
cfe0661d
JB
48062011-03-09 Juanma Barranquero <lekktu@gmail.com>
4807
4808 * search.c (compile_pattern_1): Remove argument regp, unused since
4809 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4810 (compile_pattern): Don't pass it.
4811
0afb4571
J
48122011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4813
4814 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4815 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4816 for ! HAVE_GTK3.
4817 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4818
4819 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4820
4821 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4822 gdk_window_get_screen, gdk_window_get_geometry,
4823 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4824 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4825 (xg_get_pixbuf_from_pixmap): New function.
4826 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4827 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4828 Call xg_get_pixbuf_from_pixmap instead of
4829 gdk_pixbuf_get_from_drawable.
4830 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4831 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4832 (xg_check_special_colors): Use GtkStyleContext and its functions
4833 for HAVE_GTK3.
4834 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4835 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4836 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4837 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4838 Call gtk_widget_get_preferred_size.
0afb4571
J
4839 (xg_frame_resized): gdk_window_get_geometry only takes 5
4840 parameters.
44f230aa
SM
4841 (xg_win_to_widget, xg_event_is_for_menubar):
4842 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4843 (xg_set_widget_bg): New function.
4844 (delete_cb): New function.
895009e1 4845 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4846 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4847 (xg_set_background_color): Call xg_set_widget_bg.
4848 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4849 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4850 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4851 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4852 if ! HAVE_GTK3.
4853 (update_frame_tool_bar): Call gtk_widget_hide.
4854 (xg_initialize): Use GDK_KEY_g.
4855
4856 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4857 if ! HAVE_GTK3
4858 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4859
4860 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4861 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4862 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4863
1c2cc4ef
JB
48642011-03-08 Juanma Barranquero <lekktu@gmail.com>
4865
4866 * w32xfns.c (select_palette): Check success of RealizePalette against
4867 GDI_ERROR, not zero.
4868
33383987 4869See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4870
4871;; Local Variables:
4872;; coding: utf-8
aac0c6e3
MR
4873;; End:
4874
33383987 4875 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4876
4877 This file is part of GNU Emacs.
4878
4879 GNU Emacs is free software: you can redistribute it and/or modify
4880 it under the terms of the GNU General Public License as published by
4881 the Free Software Foundation, either version 3 of the License, or
4882 (at your option) any later version.
4883
4884 GNU Emacs is distributed in the hope that it will be useful,
4885 but WITHOUT ANY WARRANTY; without even the implied warranty of
4886 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4887 GNU General Public License for more details.
4888
4889 You should have received a copy of the GNU General Public License
4890 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.