* dbusbind.c (signature_cat): New function.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2be7d702 12011-08-30 Paul Eggert <eggert@cs.ucla.edu>
62f19c19
PE
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2be7d702
PE
23 * dbusbind.c (signature_cat): New function.
24 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
25 Do not overrun buffer; instead, report string overflow.
26
9d1df220
PE
27 * dispnew.c (add_window_display_history): Don't overrun buffer.
28 Truncate instead; this is OK since it's just a log.
29
33ef5c64
PE
30 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
31 even if the time zone offset is outlandishly large.
32 Don't mishandle offset == INT_MIN.
33
66c6fdd5
PE
34 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
35 when creating daemon; the previous buffer-overflow check was incorrect.
36
d749b01b
PE
37 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
38 which has the guts of the old verror function.
39
b5cd1905
PE
40 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
41 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
42
6e1a67fb
PE
43 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
44 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc
PE
45 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
46 fits in int, when using sprintf. Use single snprintf to count
47 length of string rather than counting it via multiple sprintfs;
48 that's simpler and more reliable.
49 (APPEND_SPRINTF): New macro.
50 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
51 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
52 sprintf, in case result does not fit in int.
53
c57b67fc
PE
54 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
55 (fontset_from_font): Print it.
56
8a401434
PE
57 * frame.c (tty_frame_count): Now printmax_t, not int.
58 (make_terminal_frame, set_term_frame_name): Print it.
59 (x_report_frame_params): In X, window IDs are unsigned long,
60 not signed long, so print them as unsigned.
61 (validate_x_resource_name): Check for implausibly long names,
62 and don't assume name length fits in 'int'.
63 (x_get_resource_string): Don't blindly alloca invocation name;
64 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
65 not fit in int.
66
6e1a67fb
PE
67 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
68 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
69 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
70
0df02bf3
PE
71 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
72 Use esprintf, not sprintf, in case result does not fit in int.
73
48e30793
PE
74 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
75 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
76 it as a large positive number.
77 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
78 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
79
a66ff6d8
PE
80 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
81 in case result does not fit in int.
82
aca216ff
PE
83 * print.c (float_to_string): Detect width overflow more reliably.
84 (print_object): Make sprintf buffer a bit bigger, to avoid potential
85 buffer overrun. Don't assume list length fits in 'int'. Treat
86 print length of 0 as 0, not as infinity; to be consistent with other
87 uses of print length in this function. Don't overflow print length
88 index. Don't assume hash table size fits in 'long', or that
89 vectorlike size fits in 'unsigned long'.
90
31c286f7
PE
91 * process.c (make_process): Use printmax_t, not int, to format
92 process-name gensyms.
93
80f2e268
PE
94 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
95 to avoid potential buffer overrun.
96
670741ab
PE
97 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
98 if X resource line is longer than 512 bytes.
99
b7163a50
PE
100 * xfns.c (x_window): Make sprintf buffer a bit bigger
101 to avoid potential buffer overrun.
102
ae58ff1f
PE
103 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
104
c43c8a6a
PE
105 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
106
c4a07a4c
PE
1072011-08-29 Paul Eggert <eggert@cs.ucla.edu>
108
109 * image.c (parse_image_spec): Check for nonnegative, not for positive,
110 when checking :margin (Bug#9390).
111 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
112 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
113 so that the name doesn't mislead. All uses changed.
114
6bc8cd65
JB
1152011-08-28 Johan Bockgård <bojohan@gnu.org>
116
117 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
118 set_tty_hooks.
119
dca4927e
EZ
1202011-08-27 Eli Zaretskii <eliz@gnu.org>
121
122 * xdisp.c (move_it_to): Don't bail out early when reaching
123 position beyond to_charpos, if we are scanning backwards.
124 (move_it_vertically_backward): When DY == 0, make sure we get to
125 the first character in the line after the newline.
126
f2cad773
PE
1272011-08-27 Paul Eggert <eggert@cs.ucla.edu>
128
129 * ccl.c: Improve and simplify overflow checking (Bug#9196).
130 (ccl_driver): Do not generate an out-of-range pointer.
131 (Fccl_execute_on_string): Remove unnecessary check for
132 integer overflow, noted by Stefan Monnier in
133 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
134 Remove a FIXME that didn't need fixing.
135 Simplify the newly-introduced buffer reallocation code.
136
0cae2cdb
JB
1372011-08-27 Juanma Barranquero <lekktu@gmail.com>
138
139 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
140
5fc295a4 1412011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 142
70c60eb2 143 Integer and memory overflow issues (Bug#9196).
726e0ab1 144
d31850da
PE
145 * doc.c (get_doc_string): Rework so that
146 get_doc_string_buffer_size is the actual buffer size, rather than
147 being 1 less than the actual buffer size; this makes xpalloc more
148 convenient.
149
a69fbedb
PE
150 * image.c (x_allocate_bitmap_record, cache_image):
151 * xselect.c (Fx_register_dnd_atom):
152 Simplify previous changes by using xpalloc.
153
fe5c5d37
PE
154 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
155 since either will do and ptrdiff_t is convenient with xpalloc.
156
0065d054
PE
157 * charset.c (charset_table_size)
158 (struct charset_sort_data.priority): Now ptrdiff_t.
159 (charset_compare): Don't overflow if priorities differ greatly.
160 (Fsort_charsets): Don't assume list length fits in int.
161 Check for size-calculation overflow when allocating sort data.
162 (syms_of_charset): Allocate an initial charset table that is
163 just under 64 KiB, to avoid problems with glibc malloc and mmap.
164
165 * cmds.c (internal_self_insert): Check for size-calculation overflow.
166
167 * composite.h (struct composition.glyph_len): Now int, not unsigned.
168 The actual value is always <= INT_MAX, and leaving it unsigned made
169 overflow checking harder.
170
171 * dispextern.h (struct glyph_matrix.rows_allocated)
172 (struct face_cache.size): Now ptrdiff_t, for convenience in use
173 with xpalloc. The values are still always <= INT_MAX.
174
175 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
176
177 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
178 (SAFE_NALLOCA): New macro.
179
180 * region-cache.c (struct boundary.pos, find_cache_boundary)
181 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
182 (set_cache_region, invalidate_region_cache)
183 (revalidate_region_cache, know_region_cache, region_cache_forward)
184 (region_cache_backward, pp_cache):
185 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
186 so that ptrdiff_t * can be passed to xpalloc.
187 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
188 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
189 (pp_cache): Don't assume cache_len fits in int.
190 * region-cache.h: Adjust extern decls to match.
191
192 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
193 EMACS_INT, since either will do, for xpalloc.
194
195 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
196 (xnmalloc, xnrealloc, xpalloc): New functions.
197
726e0ab1
PE
198 * bidi.c (bidi_shelve_header_size): New constant.
199 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
200 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
201
51f30bc5 202 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
203 * buffer.c (overlays_at, overlays_in, record_overlay_string)
204 (overlay_strings):
205 Don't update size of array until after memory allocation succeeds,
206 because xmalloc/xrealloc may not return.
0065d054
PE
207 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
208 now that we have proper integer overflow checking.
209 (record_overlay_string, overlay_strings): Catch overflows when
210 calculating size of overlay_str_buf.
726e0ab1 211
0065d054
PE
212 * callproc.c (Fcall_process): Check for size overflow when
213 calculating size of args2.
214 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
215 Normally we prefer signed values, but sticking with ptrdiff_t would
216 require adding more-complicated checks.
726e0ab1
PE
217
218 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
219 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
220 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 221 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
222
223 * character.c (Fstring): Check for size-calculation overflow.
224
225 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
226 unnecessary integer overflow. Check for size overflow.
227 (encode_coding_object): Don't update size until xmalloc succeeds.
228
229 * composite.c (get_composition_id): Check for overflow in glyph
230 length calculations.
231
232 Integer and memory overflow fixes for display code.
233 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
234 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
235 (scrolling_window): Check for overflow in size calculations.
236 (line_draw_cost, realloc_glyph_pool, add_row_entry):
237 Don't assume glyph table len fits in int.
238 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
239 (row_table_size): Now ptrdiff_t, not int.
240 (scrolling_window): Avoid overflow in size calculations.
241 Don't update size until allocation succeeds.
242 * fns.c (concat): Check for overflow in size calculations.
243 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
244 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
245 (NEXT_ALMOST_PRIME_LIMIT): New constant.
246
247 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
248 (get_doc_string): Check for size calculation overflow.
249 Don't update size until allocation succeeds.
250 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
251 EMACS_INT, where ptrdiff_t will do.
252 (Fsubstitute_command_keys): Check for string overflow.
253
254 * editfns.c (set_time_zone_rule): Don't assume environment length
255 fits in int.
256 (message_length): Now ptrdiff_t, not int.
257 (Fmessage_box): Don't update size until allocation succeeds.
258 Don't assume message length fits in int.
259 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
260
0065d054
PE
261 * emacs.c (main): Do not reallocate argv, since there is a null at
262 the end that can be overwritten, and this way there's no need to
263 worry about size-calculation overflow.
264 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
265
266 * eval.c (init_eval_once, grow_specpdl): Don't update size until
267 alloc succeeds.
268 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
269
270 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
271 (x_set_scroll_bar_width, x_figure_window_size):
272 Check for integer overflow.
273 (x_set_alpha): Do not assume XINT fits in int.
274
275 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
276 This is for the members text_lines, text_cols, total_lines, total_cols,
277 where the system imposes an 'int' limit.
278
279 * fringe.c (Fdefine_fringe_bitmap):
280 Don't update size until alloc works.
281
282 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
283 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
284
285 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
286 Check for size-calculation overflow.
287 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
288 do, as we prefer signed integers.
289 (id_to_widget.max_size, id_to_widget.used)
290 (xg_store_widget_in_map, xg_remove_widget_from_map)
291 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
292 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
293 Use and return ptrdiff_t, not int.
294 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
295 * gtkutil.h: Change prototypes to match the above.
296
297 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
298 are duplicate now that they've been promoted to lisp.h.
299 (x_allocate_bitmap_record, x_alloc_image_color)
300 (make_image_cache, cache_image, xpm_load):
301 Don't update size until alloc is done.
302 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
303 (x_detect_edges):
3256efce 304 Check for size calculation overflow.
726e0ab1
PE
305 (ct_colors_allocated_max): New constant.
306 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
307 overflow.
3256efce 308
726e0ab1
PE
309 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
310 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
311 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
312 Use ptrdiff_t, not int, to count maps.
313 (read_char_minibuf_menu_prompt): Check for overflow in size
314 calculations. Don't update size until allocation succeeds. Redo
315 calculations to avoid overflow.
316 * keyboard.h: Change prototypes to match the above.
317
318 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
319 to count maps.
320 (current_minor_maps): Check for size calculation overflow.
321 * keymap.h: Change prototypes to match the above.
322
323 * lread.c (read1, init_obarray): Don't update size until alloc done.
324
325 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
326 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
327
726e0ab1
PE
328 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
329 Now ptrdiff_t, not int.
330 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
331 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
332
333 * process.c (Fnetwork_interface_list): Check for overflow
334 in size calculation.
335
336 * region-cache.c (move_cache_gap): Check for size calculation overflow.
337
338 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
339 overflow. Don't bother calling xmalloc when xrealloc will do.
340
341 * search.c (Freplace_match): Check for size calculation overflow.
342 (Fset_match_data): Don't assume list lengths fit in 'int'.
343
344 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
345 for command line length. Do not attempt to address one before the
346 beginning of an array, as that's not portable.
347
348 * term.c (max_frame_lines): Remove; unused.
349 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
350 not int.
351 (encode_terminal_code, calculate_costs): Check for size
352 calculation overflow.
353 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
354 table lengths and related sizes. Don't update size until alloc
355 done. Redo calculations to avoid overflow.
356 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
357
358 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
359 subtracting pointers.
360 (gobble_line): Check for overflow more carefully. Don't update size
361 until alloc done.
362
363 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
364 Don't update size until alloc done.
365 Redo size calculations to avoid overflow.
366 Check for size calculation overflow.
0065d054 367 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
368
369 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
370 Use ptrdiff_t, not int, for sizes.
371 (store_mode_line_noprop_char): Don't update size until alloc done.
372
0065d054
PE
373 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
374 Use ptrdiff_t, not int, for sizes.
375 (Finternal_make_lisp_face, cache_face):
376 Check for size calculation overflow.
377 (cache_face): Treat size calculation overflows as if they were
378 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
379
380 * xfns.c (x_encode_text, x_set_name_internal)
381 (Fx_change_window_property): Use ptrdiff_t, not int, to count
382 sizes, since they can exceed INT_MAX in size. Check for size
383 calculation overflow.
384
0065d054
PE
385 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
386 (xg_select): Check for size calculation overflow.
726e0ab1
PE
387 Don't update size until alloc done.
388
0065d054 389 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 390 as sprintf is limited to int lengths.
1d526e2f 391
252c5ee1
PE
392 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
393 (X_LONG_MIN): New macros.
864d7ce7
PE
394 Use them to make the following changes clearer.
395 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
396 This change doesn't affect the value now, but it may help remind
397 future maintainers not to raise the value too much later.
398 (SELECTION_QUANTUM): Remove, replacing with ...
399 (selection_quantum): ... new function, which avoids overflow.
400 All uses changed.
401 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
402 assumption that selection length fits in 'int'.
403 (x_reply_selection_request, x_handle_selection_request)
404 (x_get_window_property, receive_incremental_selection)
405 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
406 (lisp_data_to_selection_data, clean_local_selection_data):
407 Use ptrdiff_t, not int, to record length of selection.
408 (x_reply_selection_request, x_get_window_property)
409 (receive_incremental_selection, x_property_data_to_lisp):
410 Redo calculations to avoid overflow.
411 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 412 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
413 something.
414 (x_get_window_property, receive_incremental_selection)
415 (lisp_data_to_selection_data, x_property_data_to_lisp):
416 Check for size-calculation overflow.
417 (x_get_window_property, receive_incremental_selection)
418 (lisp_data_to_selection_data, Fx_register_dnd_atom):
419 Don't store size until memory allocation succeeds.
420 (x_get_window_property): Plug memory leak on memory exhaustion.
421 Don't double-block input; malloc is safe here. Don't assume 2**34
422 - 4 fits in unsigned long. Add an xassert to check
423 XGetWindowProperty overflow. Be more careful about overflow
424 calculations, and distinguish size from memory overflow better.
425 (receive_incremental_selection): When tracing, don't assume
426 unsigned int is less than INT_MAX.
427 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
428 harmful) conversions of unsigned short to int.
429 (lisp_data_to_selection_data): Don't assume that integers
430 in the range -65535 through -1 fit in an X unsigned short.
431 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
432 result parameters unless successful. Rely on cons_to_unsigned
433 to report problems with elements; the old code wasn't right anyway.
434 (x_check_property_data): Check for int overflow; we cannot use
435 a wider type due to X limits.
436 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
437
726e0ab1 438 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 439
0065d054
PE
440 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
441 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
442 (x_color_cells): Don't store size until memory allocation succeeds.
443 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 444 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
445 (x_term_init): Don't assume length fits in int (sprintf is limited
446 to int size).
bc18e09d 447
ebfa62c0
PE
448 Use ptrdiff_t for composition IDs.
449 * character.c (lisp_string_width):
450 * composite.c (composition_table_size, n_compositions)
451 (get_composition_id, composition_gstring_from_id):
452 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
453 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
454 * window.c (Frecenter):
455 Use ptrdiff_t, not int, for composition IDs.
456 * composite.c (get_composition_id): Check for integer overflow.
457 * composite.h: Adjust prototypes to match the above changes.
458
d3411f89
PE
459 Use ptrdiff_t for hash table indexes.
460 * category.c (hash_get_category_set):
461 * ccl.c (ccl_driver):
462 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
463 * coding.c (coding_system_charset_list, detect_coding_system):
464 * coding.h (struct coding_system.id):
465 * composite.c (get_composition_id, gstring_lookup_cache):
466 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
467 * image.c (xpm_get_color_table_h):
468 * lisp.h (hash_lookup, hash_put):
469 * minibuf.c (Ftest_completion):
470 Use ptrdiff_t for hash table indexes, not int (which is too
471 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
472 32-bit --with-wide-int hosts).
473
e097a6fa
PE
474 * charset.c (Fdefine_charset_internal): Check for integer overflow.
475 Add a FIXME comment about memory leaks.
476 (syms_of_charset): Don't assume xmalloc returns.
477
5637687f
PE
478 Don't assume that stated character widths fit in int.
479 * character.c (Fchar_width, c_string_width, lisp_string_width):
480 * character.h (CHAR_WIDTH):
481 * indent.c (MULTIBYTE_BYTES_WIDTH):
482 Use sanitize_char_width to avoid undefined and/or bad behavior
483 with outlandish widths.
484 * character.h (sanitize_tab_width): Renamed from sanitize_width,
485 now that we have two such functions. All uses changed.
486 (sanitize_char_width): New inline function.
487
a2271ba2
PE
488 Don't assume that tab-width fits in int.
489 * character.h (sanitize_width): New inline function.
490 (SANE_TAB_WIDTH): New macro.
491 (ASCII_CHAR_WIDTH): Use it.
492 * indent.c (sane_tab_width): Remove. All uses replaced by
493 SANE_TAB_WIDTH (current_buffer).
494 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
495
18c52557
PE
496 * fileio.c: Integer overflow issues with file modes.
497 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
498
caeeedc1
PE
499 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
500 Remove unreachable code.
501 (read_hex, load_charset_map_from_file): Check for integer overflow.
502
50849c52
PE
503 * xterm.c: don't go over XClientMessageEvent limit
504 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
505 (x_send_scroll_bar_event): Likewise. Check that the size does not
506 exceed limits imposed by XClientMessageEvent, as well as the usual
507 ptrdiff_t and size_t limits.
508
b13995db
PE
509 * keyboard.c: Overflow, signedness and related fixes.
510 (make_lispy_movement): Use same integer type in forward decl
511 that is used in the definition.
512 (read_key_sequence, keyremap_step):
513 Change bufsize argument back to int, undoing my 2011-03-30 change.
514 We prefer signed types, and int is wide enough here.
515 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
516 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
517 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
518 length, not size_t. Use ptrdiff_t for index, not int.
519 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
520 possibility of integer overflow.
521
13464394
PE
522 Overflow, signedness and related fixes for images.
523
524 * dispextern.h (struct it.stack[0].u.image.image_id)
525 (struct_it.image_id, struct image.id, struct image_cache.size)
526 (struct image_cache.used, struct image_cache.ref_count):
527 * gtkutil.c (update_frame_tool_bar):
528 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
529 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
530 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
531 * nsmenu.m (update_frame_tool_bar):
532 * xdisp.c (calc_pixel_width_or_height):
533 * xfns.c (image_cache_refcount):
534 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
535 on typical 64-bit hosts.
536
537 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
538 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
539 Omit unnecessary casts to int.
540 (parse_image_spec): Check that integers fall into 'int' range
541 when the callers expect that.
542 (image_ascent): Redo ascent calculation to avoid int overflow.
543 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
544 (lookup_image): Remove unnecessary tests.
545 (xbm_image_p): Locals are now of int, not EMACS_INT,
546 since parse_image_check makes sure they fit into int.
547 (png_load, gif_load, svg_load_image):
548 Prefer int to unsigned where either will do.
549 (tiff_handler): New function, combining the cores of the
550 old tiff_error_handler and tiff_warning_handler. This
551 function is rewritten to use vsnprintf and thereby avoid
552 stack buffer overflows. It uses only the features of vsnprintf
553 that are common to both POSIX and native Microsoft.
554 (tiff_error_handler, tiff_warning_handler): Use it.
555 (tiff_load, gif_load, imagemagick_load_image):
556 Don't assume :index value fits in 'int'.
557 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
558 (imagemagick_load_image): Check that crop parameters fit into
559 the integer types that MagickCropImage accepts. Don't assume
560 Vimagemagick_render_type has a nonnegative value. Don't assume
561 size_t fits in 'long'.
562 (gs_load): Use printmax_t to print the widest integers possible.
563 Check for integer overflow when computing image height and width.
564
c11821d4
EZ
5652011-08-26 Eli Zaretskii <eliz@gnu.org>
566
567 * xdisp.c (redisplay_window): Don't force window start if point
568 will be invisible in the resulting window. (Bug#9324)
569
0c95fcf7
EZ
5702011-08-25 Eli Zaretskii <eliz@gnu.org>
571
572 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
573 the display spec is of the form `(space ...)'.
574 (handle_display_spec): Return the value returned by
575 handle_single_display_spec, not just 1 or zero.
576 (handle_single_display_spec): If the display spec is of the form
577 `(space ...)', and specifies display in the text area, return 2
578 rather than 1.
fee65a97 579 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
580 accurately, and prefer exact match for point under bidi. Don't
581 advance `row' beyond the last row of the window.
0c95fcf7
EZ
582
583 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
584 into disp_prop; all users changed.
585
586 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
587 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
588 for the text covered by the display property.
589
e4ed06f1
CY
5902011-08-25 Chong Yidong <cyd@stupidchicken.com>
591
592 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
593 Change return value to nil.
594 (Frecord_buffer): Delete unused function.
595
f67cdd7f
EZ
5962011-08-24 Eli Zaretskii <eliz@gnu.org>
597
5980d4c6
EZ
598 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
599 buffers, return left-to-right.
8610fe8b
EZ
600 (set_cursor_from_row): Consider candidate row a win if its glyph
601 represents a newline and point is on that newline. Fixes cursor
602 positioning on the newline at EOL of R2L text within L2R
603 paragraph, and vice versa.
604 (try_cursor_movement): Check continued rows, in addition to
605 continuation rows. Fixes unwarranted scroll when point enters a
606 continued line of R2L text within an L2R paragraph, or vice versa.
607 (cursor_row_p): Consider the case of point being equal to
608 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
609 from the end of a short line to the beginning of a continued line
610 of R2L text within L2R paragraph.
611 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
612 composed characters.
5980d4c6 613
f67cdd7f
EZ
614 * bidi.c (bidi_check_type): Use xassert.
615 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
616 members.
617
bca633fb
EZ
6182011-08-23 Eli Zaretskii <eliz@gnu.org>
619
620 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
621 a character.
622
4a5885a7
CY
6232011-08-23 Chong Yidong <cyd@stupidchicken.com>
624
625 * nsfont.m (ns_otf_to_script): Fix typo.
626
0902a04e
KH
6272011-08-22 Kenichi Handa <handa@m17n.org>
628
629 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
630 extra slot even if the purpose is char-code-property-table.
631
1a2e6670
EZ
6322011-08-23 Eli Zaretskii <eliz@gnu.org>
633
8ddde651
EZ
634 * xdisp.c (redisplay_window): When computing centering_position,
635 account for the height of the header line. (Bug#8874)
636
425cc014
EZ
637 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
638 instead of CHAR_TO_BYTE. Fixes a crash when a completion
639 candidate is selected by the mouse, and that candidate has a
640 composed character under the mouse.
641
1a2e6670
EZ
642 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
643 coordinates reported by pos-visible-in-window-p for a composed
644 character in column zero.
645
8b76d6f8
SM
6462011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
647
648 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
649
dac347dd
EZ
6502011-08-22 Eli Zaretskii <eliz@gnu.org>
651
652 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
653 consider it a hit if to_charpos is anywhere in the range of the
654 composed buffer positions.
655
e013fb34
CY
6562011-08-22 Chong Yidong <cyd@stupidchicken.com>
657
658 * image.c (gif_load): Don't assume that each subimage has the same
659 dimensions as the base image. Handle disposal method that is
660 "undefined" by the gif spec (Bug#9335).
661
bd1ba3e8
CY
6622011-08-20 Chong Yidong <cyd@stupidchicken.com>
663
664 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 665 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 666
54a1215b
EZ
6672011-08-19 Eli Zaretskii <eliz@gnu.org>
668
823564e5
EZ
669 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
670 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
671 from an Org mode buffer to a Speedbar frame.
672
54a1215b
EZ
673 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
674 a composition, take its buffer position from IT->cmp_it.charpos.
675 Fixes cursor positioning at the beginning of a line that begins
676 with a composed character.
677
9778ebcc
EZ
6782011-08-18 Eli Zaretskii <eliz@gnu.org>
679
0be6ee06
EZ
680 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
681 character bidirectional type, use STRONG_L instead. Fixes crashes
682 in a buffer produced by `describe-categories'.
683
9778ebcc
EZ
684 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
685 members before the level stack, so they would be saved and
686 restored when copying iterator state. Fixes incorrect reordering
687 around TABs covered by display properties.
688
156bffbe
AS
6892011-08-18 Andreas Schwab <schwab@linux-m68k.org>
690
691 * process.c (Fnetwork_interface_list): Correctly determine buffer
692 size.
693
72ad093b
CY
6942011-08-17 Chong Yidong <cyd@stupidchicken.com>
695
696 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
697 (internal_condition_case_2, internal_condition_case_n):
698 Remove unnecessary aborts (Bug#9081).
72ad093b 699
35774242
EZ
7002011-08-17 Eli Zaretskii <eliz@gnu.org>
701
702 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
703 has no `load' handler, try opening the file locally. (Bug#9311)
704
db76dd85
KB
7052011-08-16 Ken Brown <kbrown@cornell.edu>
706
707 * gmalloc.c: Expand comment.
708
b215eee5
EZ
7092011-08-16 Eli Zaretskii <eliz@gnu.org>
710
711 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
712 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
713
a4579d33
KB
7142011-08-16 Ken Brown <kbrown@cornell.edu>
715
716 Fix memory allocation problems in Cygwin build (Bug#9273).
717
718 * unexcw.c ( __malloc_initialized): Declare external variable.
719 (fixup_executable): Force the dumped emacs to reinitialize malloc.
720
8b76d6f8
SM
721 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
722 New variables.
a4579d33
KB
723 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
724 dumped emacs.
725 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
726 in the static heap.
727 [CYGWIN] (special_realloc): New function.
728 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
729 requests to realloc storage in the static heap.
730
3ebec551
PE
7312011-08-15 Paul Eggert <eggert@cs.ucla.edu>
732
733 * bidi.c (bidi_initialize): Remove unused local.
734
9fd8be00
EZ
7352011-08-15 Eli Zaretskii <eliz@gnu.org>
736
474a8465
EZ
737 * biditype.h: File removed.
738
739 * bidimirror.h: File removed.
740
741 * deps.mk (bidi.o): Remove biditype.h and
742 bidimirror.h.
743
744 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
745 bidimirror.h.
746
747 * dispextern.h: Fix a typo in the comment to bidi_type_t.
748
749 * chartab.c: Improve commentary for the uniprop_table API.
750
32413314
EZ
751 * bidi.c (bidi_paragraph_init): Support zero value of
752 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
753 (bidi_initialize): Use uniprop_table instead of including
754 biditype.h and bidimirror.h.
32413314 755
9fd8be00
EZ
756 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
757 coordinates of the iterator when restoring from ppos_it.
758 (Bug#9296)
759
5cf2b69b
KH
7602011-08-14 Kenichi Handa <handa@m17n.org>
761
762 * process.c (create_process): Call setup_process_coding_systems
72ad093b 763 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 764
daf17d00
EZ
7652011-08-14 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (move_it_in_display_line_to): Don't invoke
768 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
769 ppos_it. Fixes vertical cursor motion when line beginning is
770 covered by an image. (Bug#9296)
771
08e3161a
JD
7722011-08-14 Jan Djärv <jan.h.d@swipnet.se>
773
774 * nsterm.h (ns_run_ascript): Declare.
775 (NSAPP_DATA2_RUNASSCRIPT): Define.
776
777 * nsfns.m (as_script, as_result, as_status): New static variables.
778 (ns_run_ascript): New function.
779 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
780 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
781 the event loop. Get status from as_status (Bug#7276).
782
783 * nsterm.m (sendEvent): If event is NSApplicationDefined and
784 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
785 the event loop (Bug#7276).
786
a3720aa2
AS
7872011-08-14 Andreas Schwab <schwab@linux-m68k.org>
788
789 * gnutls.c (QCgnutls_bootprop_priority)
790 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
791 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
792 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
793 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
794 (QCgnutls_bootprop_verify_hostname_error)
795 (QCgnutls_bootprop_callbacks_verify): Rename from
796 Qgnutls_bootprop_..., all uses changed.
797
798 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
799 uses changed.
800
0a0d27fb
PE
8012011-08-14 Paul Eggert <eggert@cs.ucla.edu>
802
19d5c50c
PE
803 * xfaces.c (Qframe_set_background_mode): Now static.
804 * dispextern.h (Qframe_set_background_mode): Remove decl.
805
0a0d27fb
PE
806 * process.c (Fnetwork_interface_info): Declare local only if needed.
807
377538cb
JD
8082011-08-13 Jan Djärv <jan.h.d@swipnet.se>
809
810 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
811 (Fnetwork_interface_list): Allocate in increments of bytes instead
812 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
813 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
814 sockaddr.
815 (struct ifflag_def): notrailers is smart on OSX.
816 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
817 Get hardware address with getifaddrs if available.
818
08fff70c
EZ
8192011-08-12 Eli Zaretskii <eliz@gnu.org>
820
821 * xdisp.c (iterate_out_of_display_property): xassert that
822 IT->position is set to within IT->object's boundaries. Break from
823 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
824 when IT->position is set up wrongly due to some bug.
825 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
826 (push_display_prop): Allow GET_FROM_STRING as IT->method on
827 entry. Force push_it to save on the stack the current
828 buffer/string position, to be restored by pop_it. Fix flags in
829 the iterator structure wrt the object coming from a display
830 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
831 properties. (Bug#9284)
832
7be1c708 8332011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 834
7be1c708
CY
835 * fontset.c (fontset_get_font_group): Add proper type checks.
836 (Bug#9172)
aac0c6e3 837
7be1c708 8382011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 839
7be1c708
CY
840 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
841 and LC_VERSION_MIN_MACOSX.
842 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
843 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 844
97bb72a6
EZ
8452011-08-08 Eli Zaretskii <eliz@gnu.org>
846
847 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
848 no-display-properties-and-no-overlays under bidi display.
849 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 850 properties and overlays.
97bb72a6 851
d5617611
CY
8522011-08-08 Chong Yidong <cyd@stupidchicken.com>
853
37e11a63
CY
854 * editfns.c (Fset_time_zone_rule): Document relationship with the
855 setenv function.
856
d5617611
CY
857 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
858 the font entity extracted from the cache (Bug#8109).
859
58872834
CY
8602011-08-07 Chong Yidong <cyd@stupidchicken.com>
861
862 * composite.c (autocmp_chars): Don't reset point. That is done by
863 restore_point_unwind (Bug#5984).
864
75bfc667
JL
8652011-08-07 Juri Linkov <juri@jurta.org>
866
867 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
868 to show the arg `TIME' instead of `TIMEVAL'.
869
d1410150
EZ
8702011-08-06 Eli Zaretskii <eliz@gnu.org>
871
872 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
873 display property strides EOL and includes a newline, as in
874 longlines-mode. (Bug#9254)
75b771e4
EZ
875 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
876 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
877
878 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
879 is non-zero, even if the data buffer is NULL. Fixes a crash in
880 vertical-motion with longlines-mode. (Bug#9254)
881
35928349
EZ
8822011-08-05 Eli Zaretskii <eliz@gnu.org>
883
ec7cc85b
EZ
884 * bidi.c <bidi_cache_total_alloc>: Now static.
885 (bidi_initialize): Initialize bidi_cache_total_alloc.
886
8b76d6f8 887 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
888 cache. (Bug#9221)
889
890 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
891 amount allocated this far in `bidi_cache_total_alloc'.
892 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
893 non-zero, only free the data buffer without restoring the cache
894 contents. All callers changed.
895
896 * dispextern.h (bidi_unshelve_cache): Update prototype.
897
898 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
899 (move_it_in_display_line, move_it_to)
900 (move_it_vertically_backward, move_it_by_lines): Replace the call
901 to xfree to an equivalent call to bidi_unshelve_cache.
902 (move_it_in_display_line_to): Fix logic of returning
412b6358 903 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 904
e2e2423b
EZ
9052011-08-05 Eli Zaretskii <eliz@gnu.org>
906
907 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
908 came from a string character with a `cursor' property. (Bug#9229)
909
ae9e757a
JD
9102011-08-04 Jan Djärv <jan.h.d@swipnet.se>
911
912 * Makefile.in (LIB_PTHREAD): New variable.
913 (LIBES): Add LIB_PTHREAD (Bug#9216).
914
915 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
916 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
917
213bd7f2
AS
9182011-08-04 Andreas Schwab <schwab@linux-m68k.org>
919
920 * regex.c (re_iswctype): Remove some redundant boolean
921 conversions.
922
99aaf75f
JD
9232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
924
925 * xterm.c (x_find_topmost_parent): New function.
926 (x_set_frame_alpha): Find topmost parent window with
927 x_find_topmost_parent and set the property there also (bug#9181).
928 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
929
c74e9d86
PE
9302011-08-04 Paul Eggert <eggert@cs.ucla.edu>
931
932 * callproc.c (Fcall_process): Avoid vfork clobbering
933 the local vars buffer, coding_systems, current_dir.
934
640c8776
SM
9352011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 * keymap.c (Fmake_composed_keymap): Move to subr.el.
938
f26d0e4c
PE
9392011-08-03 Paul Eggert <eggert@cs.ucla.edu>
940
8a10d76c
PE
941 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
942 so that it is not optimized away.
943
f26d0e4c
PE
944 * xdisp.c (compute_display_string_pos): Remove unused local.
945
55439c61
EZ
9462011-08-02 Eli Zaretskii <eliz@gnu.org>
947
948 Fix slow cursor motion and scrolling in large buffers with
949 selective display, like Org Mode buffers. (Bug#9218)
950
951 * dispextern.h (struct bidi_it): New member disp_prop_p.
952
953 * xdisp.c: Remove one-slot cache of display string positions.
954 (compute_display_string_pos): Accept an additional argument
955 DISP_PROP_P; callers changed. Scan at most 5K characters forward
956 for a display string or property. If found, set DISP_PROP_P
957 non-zero.
958
959 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
960 DISP_PROP_P, and pass it to compute_display_string_pos.
961 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
962 non-zero. All callers of bidi_fetch_char changed.
963
fb33fa43
SM
9642011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
965
966 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
967
b099e063
DM
9682010-12-03 Don March <don@ohspite.net>
969
970 * keymap.c (Fdefine_key): Fix non-prefix key error message when
971 last character M-[char] is translated to ESC [char] (bug#7541).
972
5cc7f7af
KH
9732011-08-02 Kenichi Handa <handa@m17n.org>
974
d0fffa3f 975 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
976
977 * chartab.c (uniprop_table): Make it non-static.
978
525d5e6e
EZ
9792011-08-01 Eli Zaretskii <eliz@gnu.org>
980
981 * xdisp.c (forward_to_next_line_start): Accept additional argument
982 BIDI_IT_PREV, and store into it the state of the bidi iterator had
983 on the newline.
984 (reseat_at_next_visible_line_start): Use the bidi iterator state
985 returned by forward_to_next_line_start to restore the state of
986 it->bidi_it after backing up to previous newline. (Bug#9212)
987
31011111
AS
9882011-07-30 Andreas Schwab <schwab@linux-m68k.org>
989
990 * regex.c (re_comp): Protoize.
991 (re_exec): Fix return type.
992 (regexec): Fix type of `ret'. (Bug#9203)
993
e5d76069
PE
9942011-07-29 Paul Eggert <eggert@cs.ucla.edu>
995
996 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
997 This is needed if max-image-size is a floating-point number.
998
9a79b20c
AS
9992011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1000
1001 * print.c (print_object): Print empty symbol as ##.
1002
1003 * lread.c (read1): Read ## as empty symbol.
1004
d8c2fa78
AA
10052011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1006
1007 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1008 setting frame foreground color (Bug#9175).
1009 (x_set_background_color): Likewise.
1010
ffe57a7a
AA
1011 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1012 contents (Bug#9176).
1013 (EmacsTooltip -init): Remove bezels and add shadows to
1014 tooltip windows.
1015
bf3492a5
AA
1016 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1017 or scroll bar (Bug#8470).
1018
d55e9c53
AA
1019 * nsfont.m (nsfont_open): Remove assignment to voffset and
1020 unnecessary vars hshink, expand, hd, full_height, min_height.
1021 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1022
1023 * nsterm.h (nsfont_info): Remove voffset field.
1024
d8c2fa78 10252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1026
1027 Implement strike-through and overline on NextStep (Bug#8863).
1028
1029 * nsfont.m (nsfont_open): Use underline position provided by font,
1030 instead of hard-coded value of 2.
1031 (nsfont_draw): Call ns_draw_text_decoration instead.
1032
1033 * nsterm.h: Add declaration for ns_draw_text_decoration.
1034
1035 * nsterm.m (ns_draw_text_decoration): New function for drawing
1036 underline, overline, and strike-through.
1037 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1038 ns_draw_text_decoration. Change treatment of cursor drawing to
1039 accomodate underlining, etc.
1040
4cc60b9b
EZ
10412011-07-28 Eli Zaretskii <eliz@gnu.org>
1042
bc7ece87
EZ
1043 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1044 default.
4cc60b9b 1045
476371c4
PE
10462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1047
66606eea
PE
1048 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1049 Without this fix, if a signal arrives just after memory fills up,
1050 'malloc' might be invoked reentrantly.
1051
476371c4
PE
1052 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1053 In other words, assume that every image size is allowed, on non-X
1054 hosts. This assumption is probably wrong, but it lets Emacs compile.
1055
f3fcc40d
AS
10562011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1057
1058 * regex.c (re_iswctype): Convert return values to boolean.
1059
350c992f
EZ
10602011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1061
1062 * xdisp.c (compute_display_string_pos): Don't use cached display
1063 string position if the buffer had its restriction changed.
1064 (Bug#9184)
1065
5266b4bb
PE
10662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1069
2573a837 10702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1071
41f55ccd 1072 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1073
39e378da
PE
1074 * bidi.c: Integer size and overflow fixes.
1075 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1076 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1077 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1078 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1079 (bidi_find_other_level_edge):
1080 Use ptrdiff_t instead of EMACS_INT where either will do.
1081 This works better on 32-bit hosts configured --with-wide-int.
1082 (bidi_cache_ensure_space): Check for size-calculation overflow.
1083 Use % rather than repeated addition, for better worst-case speed.
1084 Don't set bidi_cache_size until after xrealloc returns, because it
1085 might not return.
1086 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1087 (bidi_cache_ensure_space): Also check that the bidi cache size
1088 does not exceed that of the largest Lisp string or buffer. See Eli
1089 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1090
5e927815
PE
1091 * alloc.c (__malloc_size_t): Remove.
1092 All uses replaced by size_t. See Andreas Schwab's note
1093 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1094
ca4aa935
PE
1095 * image.c: Improve checking for integer overflow.
1096 (check_image_size): Assume that f is nonnull, since
1097 it is always nonnull in practice. This is one less thing to
1098 worry about when checking for integer overflow later.
1099 (x_check_image_size): New function, which checks for integer
1100 overflow issues inside X.
1101 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1102 This removes the need for a memory_full check.
1103 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1104 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1105 (xbm_read_bitmap_data): Change locals back to 'int', since
1106 their values must fit in 'int'.
1107 (xpm_load_image, png_load, tiff_load):
1108 Invoke x_create_x_image_and_pixmap earlier,
1109 to avoid much needless work if the image is too large.
1110 (tiff_load): Treat overly large images as if
1111 x_create_x_image_and_pixmap failed, not as malloc failures.
1112 (gs_load): Use x_check_image_size.
1113
5f8f9cc2
PE
1114 * gtkutil.c: Omit integer casts.
1115 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1116 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1117
5adf60bc
PE
1118 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1119
c8907a93
PE
1120 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1121 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1122 would wrongly return t on a 64-bit host.
1123
e3c25c68
PE
1124 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1125 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1126 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1127 and therefore cause GCC to emit a bogus diagnostic in some cases.
1128
3f791afe
PE
1129 * image.c: Integer signedness and overflow and related fixes.
1130 This is not an exhaustive set of fixes, but it's time to
1131 record what I've got.
1132 (lookup_pixel_color, check_image_size): Remove redundant decls.
1133 (check_image_size): Don't assume that arbitrary EMACS_INT values
1134 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1135 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1136 (tiff_load, imagemagick_load_image):
1137 Check for overflow in size calculations.
1138 (x_create_x_image_and_pixmap): Remove unnecessary test for
1139 xmalloc returning NULL; that can't happen.
1140 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1141 (xpm_color_bucket): Use better integer hashing function.
1142 (xpm_cache_color): Don't possibly over-allocate memory.
1143 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1144 (gif_memory_source):
1145 Use ptrdiff_t, not int or size_t, to record sizes.
1146 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1147 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1148 either works, as we prefer signed integers.
1149 (tiff_read_from_memory, tiff_write_from_memory):
1150 Return tsize_t, not size_t, since that's what the TIFF API wants.
1151 (tiff_read_from_memory): Don't fail simply because the read would
1152 go past EOF; instead, return a short read.
1153 (tiff_load): Omit no-longer-needed casts.
1154 (Fimagemagick_types): Don't assume size fits into 'int'.
1155
3cc5a532
PE
1156 Improve hashing quality when configured --with-wide-int.
1157 * fns.c (hash_string): New function, taken from sxhash_string.
1158 Do not discard information about ASCII character case; this
1159 discarding is no longer needed.
1160 (sxhash-string): Use it. Change sig to match it. Caller changed.
1161 * lisp.h: Declare it.
1162 * lread.c (hash_string): Remove, since we now use fns.c's version.
1163 The fns.c version returns a wider integer if --with-wide-int is
1164 specified, so this should help the quality of the hashing a bit.
1165
b312a492
PE
1166 * emacs.c: Integer overflow minor fix.
1167 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1168 Define only if GNU_LINUX.
1169 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1170
dfd153ae
PE
1171 * dispnew.c: Integer signedness and overflow fixes.
1172 Remove unnecessary forward decls, that were a maintenance hassle.
1173 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1174 All uses changed.
1175 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1176 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1177 (prepare_desired_row, line_draw_cost):
1178 Use int, not unsigned, where either works.
1179 (save_current_matrix, restore_current_matrix):
1180 Use ptrdiff_t, not size_t, where either works.
1181 (init_display): Check for overflow more accurately, and without
1182 relying on undefined behavior.
1183
a81d11a3
PE
1184 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1185 Remove, replacing with the new symbols in lisp.h. All uses changed.
1186 * fileio.c (make_temp_name):
1187 * filelock.c (lock_file_1, lock_file):
1188 * xdisp.c (message_dolog):
1189 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1190 Use pMd etc. instead.
1191 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1192 replacing the pWIDE etc. symbols removed from editfns.c.
1193
3300e6fd
PE
1194 * keyboard.h (num_input_events): Now uintmax_t.
1195 This is (very slightly) less likely to mess up due to wraparound.
1196 All uses changed.
1197
fd05c7e9
PE
1198 * buffer.c: Integer signedness fixes.
1199 (alloc_buffer_text, enlarge_buffer_text):
1200 Use ptrdiff_t rather than size_t when either will do, as we prefer
1201 signed integers.
1202
903fe15d
PE
1203 * alloc.c: Integer signedness and overflow fixes.
1204 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1205 (__malloc_size_t): Default to size_t, not to int.
1206 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1207 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1208 Prefer ptrdiff_t to size_t when either would do, as we prefer
1209 signed integers.
1210 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1211 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1212 Now const. Initialize with values that are in range even if char
1213 is signed.
1214 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1215 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1216 These functions do the right thing with sizes > 2**32.
1217 (check_depth): Now ptrdiff_t, not int.
1218 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1219 Adjust to new way of storing sizes. Check for size overflow bugs
1220 in rest of code.
1221 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1222 slightly wrong anyway, as it missed one instance of
1223 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1224 (refill_memory_reserve): Omit needless cast to size_t.
1225 (mark_object_loop_halt): Mark as externally visible.
1226
ac82cc6a
PE
1227 * xselect.c: Integer signedness and overflow fixes.
1228 (Fx_register_dnd_atom, x_handle_dnd_message):
1229 Use ptrdiff_t, not size_t, since we prefer signed.
1230 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1231 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1232 x_dnd_atoms_size and x_dnd_atoms_length.
1233
c2d1e36d
PE
1234 * doprnt.c: Prefer signed to unsigned when either works.
1235 * eval.c (verror):
1236 * doprnt.c (doprnt):
1237 * lisp.h (doprnt):
1238 * xdisp.c (vmessage):
1239 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1240 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1241 prefer signed arithmetic to avoid comparison confusion.
1242 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1243 but is a bit tricky.
1244
0e926e56
PE
1245 Assume freestanding C89 headers, string.h, stdlib.h.
1246 * data.c, doprnt.c, floatfns.c, print.c:
1247 Include float.h unconditionally.
1248 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1249 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1250 * regex.c: Likewise for stddef.h, string.h.
1251 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1252 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1253 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1254 (STDC_HEADERS): Remove obsolete defines.
1255 * sysdep.c: Include limits.h unconditionally.
1256
9cfdb3ec
PE
1257 Assume support for memcmp, memcpy, memmove, memset.
1258 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1259 * regex.c (memcmp, memcpy):
1260 Remove; we assume C89 now.
1261
1262 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1263 (__malloc_safe_bcopy): Remove; no longer needed.
1264
cf950e6b 1265 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1266 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1267 well either way, and we prefer signed to unsigned.
1268
dbf38e02
LMI
12692011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1270
1271 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1272 closes the connection while we're reading (bug#9182).
1273
d6f0886c
JD
12742011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1275
1276 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1277 are specified (Bug#9168).
1278
2eb1f9e6
PE
12792011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1282 Found by GCC static checking and --with-wide-int on a 32-bit host.
1283
22381272 12842011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1285
1286 * xdisp.c (compute_display_string_pos): Fix logic of caching
1287 previous display string position. Initialize cached_prev_pos to
1288 -1. Fixes slow-down at the beginning of a buffer.
1289
f25e39b4
EZ
12902011-07-24 Eli Zaretskii <eliz@gnu.org>
1291
1292 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1293 for attrs[LFACE_FONTSET_INDEX].
1294
04c4b52e
PE
12952011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1296
1297 * xml.c (parse_region): Remove unused local
1298 that was recently introduced.
1299
c1734fbd
EZ
13002011-07-23 Eli Zaretskii <eliz@gnu.org>
1301
be18c5a5
EZ
1302 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1303 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1304
c1734fbd
EZ
1305 * xdisp.c (move_it_in_display_line_to): Record the best matching
1306 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1307 exit if none of the characters scanned was an exact match.
1308 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1309 when exact match is impossible due to invisible text, and the
1310 lines are truncated.
1311
a258d627
JD
13122011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1313
1314 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1315 for OSX >= 10.7.
1316
b6d5a689
EZ
13172011-07-22 Eli Zaretskii <eliz@gnu.org>
1318
0f74f785
EZ
1319 Fix a significant slow-down of cursor motion with C-n, C-p,
1320 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1321 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1322 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1323 (next_element_from_buffer): Call compute_stop_pos_backwards to
1324 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1325 base_level_stop.
1326 (reseat): Don't look for prev_stop, as that could mean a very long
1327 run.
1328 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1329 <cached_disp_overlay_modiff>: Cache for last found display string
1330 position.
551918c1 1331 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1332 about the same buffer in the same area of character positions, and
1333 the buffer wasn't changed since the time the display string
1334 position was cached.
551918c1 1335
b2d0c91a
EZ
13362011-07-22 Eli Zaretskii <eliz@gnu.org>
1337
1338 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1339 is an integer, which is important for empty lines. (Bug#9149)
1340
043604ee
CY
13412011-07-22 Chong Yidong <cyd@stupidchicken.com>
1342
1343 * frame.c (Fmodify_frame_parameters): In tty case, update the
1344 default face if necessary (Bug#4238).
1345
da4adb04
CY
13462011-07-21 Chong Yidong <cyd@stupidchicken.com>
1347
1348 * editfns.c (Fstring_to_char): No need to explain what a character
1349 is in the docstring (Bug#6576).
1350
9abd0532
LMI
13512011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1352
1353 * xml.c (parse_region): Make sure we always return a tree.
1354
36881d16
HK
13552011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1356
1357 * xml.c (parse_region): If a document contains only comments,
1358 return that, too.
1359
1e98674d
LMI
13602011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1361
1362 * xml.c (make_dom): Return comments, too.
1363
590bd467
PE
13642011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 Port to OpenBSD.
1367 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1368 and the surrounding thread.
1369 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1370 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1371 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1372 timer goes off.
1373 * s/openbsd.h (BROKEN_SIGIO): Define.
1374 * unexelf.c (unexec) [__OpenBSD__]:
1375 Don't update the .mdebug section of the Alpha COFF symbol table.
1376
f41628b2
LMI
13772011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1378
1379 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1380 (bug#8460).
1381
b59b67c5
PE
13822011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1383
15e3a074
PE
1384 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1385 This fixes some race conditions on the permissions of any newly
1386 created file.
1387
41bed37d
PE
1388 * alloc.c (valid_pointer_p): Use pipe, not open.
1389 This fixes some permissions issues when debugging.
1390
b59b67c5
PE
1391 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1392 If fchown fails to set both uid and gid, try to set just gid,
1393 as that is sometimes allowed. Adjust the file's mode to eliminate
1394 setuid or setgid bits that are inappropriate if fchown fails.
1395
925a6be7
SM
13962011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1397
1398 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1399 to compare Lisp_Objects.
1400 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1401 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1402 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1403
52968808
AS
14042011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1405
0a6a104b
AS
1406 * lread.c (read_integer): Unread even EOF character.
1407 (read1): Likewise. Properly record start position of symbol.
1408
52968808
AS
1409 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1410 symbol character follows.
1411
9e381cdd
PE
14122011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1415 This works around a problem with the previous change to Fcopy_file.
1416 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1417 and without this change, GCC might complain about discarding
1418 fchown's return value.
1419
b5641435
JB
14202011-07-16 Juanma Barranquero <lekktu@gmail.com>
1421
1422 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1423
a8031457
PE
14242011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1427
dd889327
LMI
14282011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1429
750c33f7
LMI
1430 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1431 it's used from the C level.
1432
dd889327
LMI
1433 * process.c: Use the same condition for POLL_FOR_INPUT in both
1434 keyboard.c and process.c (bug#1858).
1435
87e86684
LM
14362011-07-09 Lawrence Mitchell <wence@gmx.li>
1437
1438 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1439 (Fgnutls_boot): Use it.
1440
64348f40
AS
14412011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1442
1443 * doc.c (Fsubstitute_command_keys): Revert last change.
1444
1d698799
LMI
14452011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1446
f863868c
LMI
1447 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1448 quotes the next character, and doesn't affect other longer
1449 sequences (bug#8935).
1450
1d698799
LMI
1451 * lread.c (syms_of_lread): Clarify that is isn't only
1452 `eval-buffer' and `eval-defun' that's affected by
1453 `lexical-binding' (bug#8460).
1454
aa4b6df6
EZ
14552011-07-15 Eli Zaretskii <eliz@gnu.org>
1456
1457 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1458 bidi redisplay when a line includes both an image and is
1459 truncated.
1460
5d856da6
PE
14612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1462
ad6042bb
PE
1463 Fix minor problems found by static checking.
1464 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1465 (elsz): Now a signed constant, not a size_t var. We prefer signed
1466 types to unsigned, to avoid integer comparison confusion. Without
1467 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1468 "cannot optimize loop, the loop counter may overflow", a symptom
1469 of the confusion.
f00bbb22 1470 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1471 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1472
6468f31c
LMI
14732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1474
49080b10
LMI
1475 * search.c (Fre_search_backward): Mention `case-fold-search' in
1476 all the re_search_* functions (bug#8138).
1477
6468f31c
LMI
1478 * keyboard.c (Fopen_dribble_file): Document when the file is
1479 closed (bug#8056).
1480
c965adc5
EZ
14812011-07-14 Eli Zaretskii <eliz@gnu.org>
1482
df9733bf
EZ
1483 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1484 bidi_cache_idx.
1485
0bb23927
EZ
1486 Support bidi reordering of display and overlay strings.
1487 * xdisp.c (compute_display_string_pos)
1488 (compute_display_string_end): Accept additional argument STRING.
1489 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1490 (reseat_to_string): Initialize bidi_it->string.s and
1491 bidi_it->string.schars.
1492 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1493 NULL (avoids a crash in bidi_paragraph_init).
1494 Initialize itb.string.lstring.
0bb23927
EZ
1495 (init_iterator): Call bidi_init_it only of a valid
1496 buffer position was specified. Initialize paragraph_embedding to
1497 L2R.
1498 (reseat_to_string): Initialize the bidi iterator.
1499 (display_string): If we need to ignore text properties of
1500 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1501 original value of -1 will not work with bidi.)
1502 (compute_display_string_pos): First arg is now struct
1503 `text_pos *'; all callers changed. Support display properties on
1504 Lisp strings.
1505 (compute_display_string_end): Support display properties on Lisp
1506 strings.
1507 (init_iterator, reseat_1, reseat_to_string): Initialize the
1508 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1509 when iterating on a string not from display properties).
640c8776
SM
1510 (compute_display_string_pos, compute_display_string_end):
1511 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1512 arrow keys.
1513 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1514 base_level_stop; instead, set base_level_stop to BEGV.
1515 Fixes crashes in vertical-motion.
0bb23927
EZ
1516 (next_element_from_buffer): Improve commentary for when
1517 the iterator is before prev_stop.
1518 (init_iterator): Initialize bidi_p from the default value of
1519 bidi-display-reordering, not from buffer-local value. Use the
1520 buffer-local value only if initializing for buffer iteration.
1521 (handle_invisible_prop): Support invisible properties on strings
1522 that are being bidi-reordered.
1523 (set_iterator_to_next): Support bidi reordering of C strings and
1524 Lisp strings.
1525 (next_element_from_string): Support bidi reordering of Lisp
1526 strings.
1527 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1528 (display_string): Support display of R2L glyph rows.
1529 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1530 (init_iterator): Don't initialize it->bidi_p for strings
1531 here.
1532 (reseat_to_string): Initialize it->bidi_p for strings here.
1533 (next_element_from_string, next_element_from_c_string)
1534 (next_element_from_buffer): Add xassert's for correspondence
1535 between IT's object being iterated and it->bidi_it.string
1536 structure.
1537 (face_before_or_after_it_pos): Support bidi iteration.
1538 (next_element_from_c_string): Handle the case of the first string
1539 character that is not the first one in the visual order.
1540 (get_visually_first_element): New function, refactored from common
1541 parts of next_element_from_buffer, next_element_from_string, and
1542 next_element_from_c_string.
1543 (tool_bar_lines_needed, redisplay_tool_bar)
1544 (display_menu_bar): Force left-to-right direction. Add a FIXME
1545 comment for making that be controlled by a user option.
1546 (push_it, pop_it): Save and restore the state of the
1547 bidi iterator. Save and restore the bidi_p flag.
1548 (pop_it): Iterate out of display property for string iteration as
1549 well.
1550 (iterate_out_of_display_property): Support iteration over strings.
1551 (handle_single_display_spec): Set up it->bidi_it for iteration
1552 over a display string, and call bidi_init_it.
1553 (handle_single_display_spec, next_overlay_string)
1554 (get_overlay_strings_1, push_display_prop): Set up the bidi
1555 iterator for displaying display or overlay strings.
1556 (forward_to_next_line_start): Don't use the shortcut if
1557 bidi-iterating.
1558 (back_to_previous_visible_line_start): If handle_display_prop
1559 pushed the iterator stack, restore the internal state of the bidi
1560 iterator by calling bidi_pop_it same number of times.
1561 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1562 and we are bidi-iterating, don't decrement the iterator position;
1563 instead, set the first_elt flag in the bidi iterator, to produce
1564 the same effect.
1565 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1566 (push_display_prop): xassert that we are iterating a buffer.
1567 (push_it, pop_it): Save and restore paragraph_embedding member.
1568 (handle_single_display_spec, next_overlay_string)
1569 (get_overlay_strings_1, reseat_1, reseat_to_string)
1570 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1571 correctly. Don't assume unibyte strings are not bidi-reordered.
1572 (compute_display_string_pos)
1573 (compute_display_string_end): Fix handling the case of C string.
1574 (push_it, pop_it): Save and restore from_disp_prop_p.
1575 (handle_single_display_spec, push_display_prop): Set the
1576 from_disp_prop_p flag.
1577 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1578 (pop_it): Call iterate_out_of_display_property only if we are
1579 popping after iteration over a string that came from a display
1580 property. Fix a typo in popping stretch info. Add an assertion
1581 for verifying that the iterator position is in sync with the bidi
1582 iterator.
1583 (handle_single_display_spec, get_overlay_strings_1)
1584 (push_display_prop): Fix initialization of paragraph direction for
1585 string when that of the parent object is not yet determined.
1586 (reseat_1): Call bidi_init_it to resync the bidi
1587 iterator with IT's position. (Bug#7616)
1588 (find_row_edges): If ROW->start.pos gives position
1589 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1590 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1591 Reset the from_disp_prop_p flag.
1592 (SAVE_IT, RESTORE_IT): New macros.
1593 (pos_visible_p, face_before_or_after_it_pos)
1594 (back_to_previous_visible_line_start)
1595 (move_it_in_display_line_to, move_it_in_display_line)
1596 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1597 (try_scrolling, redisplay_window, display_line): Use them when
1598 saving a temporary copy of the iterator and restoring it back.
1599 (back_to_previous_visible_line_start, reseat_1)
1600 (init_iterator): Empty the bidi cache "stack".
1601 (move_it_in_display_line_to): If iterator ended up at
1602 EOL, but we never saw any buffer positions smaller than
1603 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1604 motion in bidi-reordered lines.
1605 (move_it_in_display_line_to): Record prev_method and prev_pos
1606 immediately before the call to set_iterator_to_next. Fixes cursor
1607 motion in bidi-reordered lines with stretch glyphs and strings
1608 displayed in margins. (Bug#8133) (Bug#8867)
1609 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1610 TO_CHARPOS.
640c8776
SM
1611 (pos_visible_p): Support positions in bidi-reordered lines.
1612 Save and restore bidi cache.
0bb23927
EZ
1613
1614 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1615 (bidi_paragraph_info): Delete unused struct.
1616 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1617 (bidi_cache_start): New variable.
1618 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1619 to zero.
1620 (bidi_cache_fetch_state, bidi_cache_search)
1621 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1622 (bidi_cache_find, bidi_peek_at_next_level)
1623 (bidi_level_of_next_char, bidi_find_other_level_edge)
1624 (bidi_move_to_visually_next): Compare cache index with
1625 bidi_cache_start rather than with zero.
1626 (bidi_fetch_char): Accept new argument STRING; all callers
1627 changed. Support iteration over a string. Support strings with
1628 display properties. Support unibyte strings. Fix the type of
1629 `len' according to what STRING_CHAR_AND_LENGTH expects.
1630 (bidi_paragraph_init, bidi_resolve_explicit_1)
1631 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1632 (bidi_level_of_next_char, bidi_move_to_visually_next):
1633 Support iteration over a string.
0bb23927
EZ
1634 (bidi_set_sor_type, bidi_resolve_explicit_1)
1635 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1636 can now be zero (for strings); special values 0 and -1 were
1637 changed to -1 and -2, respectively.
1638 (bidi_char_at_pos): New function.
1639 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1640 Call it instead of FETCH_MULTIBYTE_CHAR.
1641 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1642 initialized to valid values.
1643 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1644 values.
1645 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1646 the test for valid cached positions. Fix the logic for looking up
1647 the sentinel state in the cache. GCPRO the Lisp string we are
1648 iterating.
1649 (bidi_push_it, bidi_pop_it): New functions.
1650 (bidi_initialize): Initialize the bidi cache start stack pointer.
1651 (bidi_cache_ensure_space): New function, refactored from part of
1652 bidi_cache_iterator_state. Don't assume the required size is just
1653 one BIDI_CACHE_CHUNK away.
1654 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1655 (bidi_count_bytes, bidi_char_at_pos): New functions.
1656 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1657 always valid if bidi_cache_idx is valid.
1658 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1659 is valid if it's going to be used.
1660 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1661 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1662 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1663 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1664 (bidi_find_other_level_edge, bidi_cache_start_stack):
1665 All variables related to cache indices are now EMACS_INT.
c965adc5 1666
0bb23927
EZ
1667 * dispextern.h (struct bidi_string_data): New structure.
1668 (struct bidi_it): New member `string'. Make flag members be 1-bit
1669 fields, and put them last in the struct.
640c8776
SM
1670 (compute_display_string_pos, compute_display_string_end):
1671 Update prototypes.
0bb23927
EZ
1672 (bidi_push_it, bidi_pop_it): Add prototypes.
1673 (struct iterator_stack_entry): New members bidi_p,
1674 paragraph_embedding, and from_disp_prop_p.
1675 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1676 (bidi_shelve_cache, bidi_unshelve_cache):
1677 Declare prototypes.
0bb23927
EZ
1678
1679 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1680 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1681 and vector-like objects.
1682
1683 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1684 cache around display iteration.
1685
1686 * window.c (Fwindow_end, window_scroll_pixel_based)
1687 (displayed_window_lines, Frecenter): Save and restore the bidi
1688 cache around display iteration.
1689
3bbd2265
LMI
16902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1691
1692 * editfns.c (Fdelete_region): Clarify the use of the named
1693 parameters (bug#6788).
1694
adc47434
MR
16952011-07-14 Martin Rudalics <rudalics@gmx.at>
1696
1697 * indent.c (Fvertical_motion): Set and restore w->pointm when
1698 saving and restoring the window's buffer (Bug#9006).
1699
837c31f8
LMI
17002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1701
1702 * editfns.c (Fstring_to_char): Clarify just what is returned
1703 (bug#6576). Text by Eli Zaretskii.
1704
ac389d0c
JB
17052011-07-13 Juanma Barranquero <lekktu@gmail.com>
1706
1707 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1708
0be0ce47
EZ
17092011-07-13 Eli Zaretskii <eliz@gnu.org>
1710
1711 * buffer.c (mmap_find): Fix a typo.
1712
cd18e7e3
JB
17132011-07-13 Johan Bockgård <bojohan@gnu.org>
1714
1715 Fix execution of x selection hooks.
1716 * xselect.c (Qx_lost_selection_functions)
1717 (Qx_sent_selection_functions): New vars.
1718 (syms_of_xselect): DEFSYM them.
1719 (x_handle_selection_request): Pass Qx_sent_selection_functions
1720 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1721 (x_handle_selection_clear,x_clear_frame_selections):
1722 Pass Qx_lost_selection_functions rather than
1723 Vx_lost_selection_functions to Frun_hook_with_args.
1724
47ea7f44
PE
17252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1726
ac389d0c 1727 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1728 The old code sometimes used this field without initializing it.
1729
47ea7f44
PE
1730 * alloc.c (gc_sweep): Don't read past end of array.
1731 In theory, the old code could also have corrupted Emacs internals,
1732 though it'd be very unlikely.
1733
bc985c87
AS
17342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1735
1736 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1737 argument. (Bug#4026)
bc985c87 1738
0cf34688
LMI
17392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1740
b3dadd76
LMI
1741 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1742 key" (bug#4257).
1743
0cf34688
LMI
1744 * window.c (Fset_window_start): Doc fix (bug#4199).
1745 (Fset_window_hscroll): Ditto.
1746
270768cd
PE
17472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1748
077e3dda 1749 Fix minor new problems caught by GCC 4.6.1.
270768cd 1750 * term.c (init_tty): Remove unused local.
490011a6 1751 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1752 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1753 not used otherwise.
270768cd 1754
b1f58454
CY
17552011-07-12 Chong Yidong <cyd@stupidchicken.com>
1756
1757 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1758
22b9578d
LMI
17592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1760
6e70ab07
LMI
1761 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1762 are the mini-buffer and the echo area (bug#3320).
1763
22b9578d
LMI
1764 * term.c (init_tty): Remove support for supdup, c10 and perq
1765 terminals, which are no longer supported (bug#1482).
1766
8974cc9f
JB
17672011-07-10 Johan Bockgård <bojohan@gnu.org>
1768
1769 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1770
a560d974
JD
17712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1772
1773 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1774 for non-popups (Bug#3642).
1775
1dae0f0a
AS
17762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1777
268c2c36 1778 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1779 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1780 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1781 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1782 * data.c (fmod): Likewise.
1783 * dispnew.c (swap_glyphs_in_rows): Likewise.
1784 * emacs.c (memory_warning_signal): Likewise.
1785 * floatfns.c (float_error): Likewise.
1786 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1787 (otf_open, font_otf_capability, generate_otf_features)
1788 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1789 Likewise.
1790 * image.c (pbm_read_file): Likewise.
1791 * indent.c (string_display_width): Likewise.
1792 * intervals.c (check_for_interval, search_for_interval)
1793 (inc_interval_count, count_intervals, root_interval)
1794 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1795 * lread.c (defalias): Likewise.
268c2c36 1796 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1797 * regex.c (set_image_of_range_1, set_image_of_range)
1798 (regex_grow_registers): Likewise.
1799 * sysdep.c (strerror): Likewise.
1800 * termcap.c (valid_filename_p, tprint, main): Likewise.
1801 * tparam.c (main): Likewise.
1802 * unexhp9k800.c (run_time_remap, save_data_space)
1803 (update_file_ptrs, read_header, write_header, calculate_checksum)
1804 (copy_file, copy_rest, display_header): Likewise.
1805 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1806 Likewise.
1807 * xdisp.c (check_it): Likewise.
1808 * xfaces.c (register_color, unregister_color, unregister_colors):
1809 Likewise.
1810 * xfns.c (print_fontset_result): Likewise.
1811 * xrdb.c (member, fatal, main): Likewise.
1812
99033785
PE
18132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1814
1815 Fix minor problems found by static checking (Bug#9031).
1816 * chartab.c (char_table_set_range, map_sub_char_table):
1817 Remove unused locals.
1818 (uniprop_table): Now static.
1819 * composite.c (_work_char): Remove unused static var.
1820
9cb2ac56
JB
18212011-07-09 Juanma Barranquero <lekktu@gmail.com>
1822
1823 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1824
f25661f0
JD
18252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1826
1827 * gtkutil.c (qttip_cb): Remove code without function.
1828
8278c4fe
EZ
18292011-07-09 Eli Zaretskii <eliz@gnu.org>
1830
1831 * w32.c (pthread_sigmask): New stub.
1832
1692ae2d 18332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1834
8a6ebd58 1835 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1836 sigprocmask is portable only for single-threaded applications, and
1837 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1838 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1839 (LIBES): Use it.
1840 * callproc.c (Fcall_process):
1841 * process.c (create_process):
1842 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1843 Use pthread_sigmask, not sigprocmask.
123403e4 1844
1b854618
JD
18452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1846
1847 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1848 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1849 wrong (Bug#8591).
1850
3fe4b549
JD
18512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1852
0ce7e563
JD
1853 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1854 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1855 (xg_hide_tooltip): Fix comment.
1856
3fe4b549
JD
1857 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1858 in registerServicesMenuSendTypes.
1859 (validRequestorForSendType): Don't check ns_return_types.
1860
1861 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1862 ns_return_type.
1863
5df75e47
JR
18642011-07-08 Jason Rumney <jasonr@gnu.org>
1865
1866 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1867 frame struct members of non-existent frames (Bug#6284).
1868
699c10bd
JD
18692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1870
4393663b
JD
1871 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1872 variable firstTime not needed on OSX >= 10.6.
1873 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1874 >= 10.5. Use setKnobProportion, setDoubleValue.
1875
1876 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1877 (MAC_OS_X_VERSION_10_5): Define if not defined.
1878 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1879 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1880 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1881
1882 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1883 cString and lossyCString on OSX >= 10.4
1884
1885 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1886 sizeToFit on OSX >= 10.2.
1887
1888 * nsimage.m (allocInitFromFile): Don't use deprecated method
1889 bestRepresentationForDevice on OSX >= 10.6.
1890
1891 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1892 to avoid warning.
1893
1894 * emacs.c: Declare unexec_init_emacs_zone.
1895
a63e0781
JD
1896 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1897
699c10bd
JD
1898 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1899
1900 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1901 on svcsMenu (Bug#8842).
1902
1903 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1904 ns_return_types.
1905 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1906
1907 * nsterm.m (QUTF8_STRING): Declare.
1908 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1909 (validRequestorForSendType): Return type is (id).
1910 Change indexOfObjectIdenticalTo to indexOfObject.
1911 Check if we have local selection before returning self (Bug#8842).
1912 (writeSelectionToPasteboard): Put local selection into paste board
1913 if we have a local selection (Bug#8842).
1914 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1915
1916 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1917 (ns_get_local_selection): Declare.
1918
54e10184
LMI
19192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1920
9888ff71
LMI
1921 * keymap.c (describe_map_tree): Don't insert a double newline at
1922 the end of the buffer (bug#1169) and return whether we inserted
1923 something.
1924
54e10184
LMI
1925 * callint.c (Fcall_interactively): Change "reading args" to
1926 "providing args" to try to clarify what it does (bug#1010).
1927
15fa4783
KH
19282011-07-07 Kenichi Handa <handa@m17n.org>
1929
1930 * composite.c (composition_compute_stop_pos): Ignore a static
1931 composition starting before CHARPOS (Bug#8915).
1932
1933 * xdisp.c (handle_composition_prop): Likewise.
1934
a8815b00
EZ
19352011-07-07 Eli Zaretskii <eliz@gnu.org>
1936
1937 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1938 (Bug#9015)
1939
ef7b981d 19402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1941
1942 * character.h (unicode_category_t): New enum type.
1943
1944 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1945 (Qchar_code_property_table): New variable.
1946 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1947 (UNIPROP_COMPRESSED_FORM_P): New macros.
1948 (char_table_ascii): Uncompress the compressed values.
1949 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1950 Uncompress the compressed values.
ac389d0c 1951 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1952 (char_table_ref_and_range): Uncompress the compressed values.
1953 (sub_char_table_set): New arg is_uniprop. Callers changed.
1954 Uncompress the compressed values.
1955 (sub_char_table_set_range): Args changed. Callers changed.
1956 (char_table_set_range): Adjuted for the above change.
1957 (map_sub_char_table): Delete args default_val and parent. Add arg
1958 top. Give decoded values to a Lisp function.
640c8776 1959 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1960 values to a Lisp function. Gcpro more variables.
1961 (uniprop_table_uncompress)
1962 (uniprop_decode_value_run_length): New functions.
1963 (uniprop_decoder, uniprop_decoder_count): New variables.
1964 (uniprop_get_decoder, uniprop_encode_value_character)
1965 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1966 New functions.
1967 (uniprop_encoder, uniprop_encoder_count): New variables.
1968 (uniprop_get_encoder, uniprop_table)
1969 (Funicode_property_table_internal, Fget_unicode_property_internal)
1970 (Fput_unicode_property_internal): New functions.
1971 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1972 Sunicode_property_table_internal, Sget_unicode_property_internal,
1973 and Sput_unicode_property_internal. Defvar_lisp
1974 char-code-property-alist.
1975
640c8776 1976 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1977 Vunicode_category_table.
1978
640c8776 1979 * font.c (font_range): Adjust for the change of
c805dec0
KH
1980 Vunicode_category_table.
1981
76b397fb
DN
19822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1983
1984 * m/iris4d.h: Remove file, move contents ...
1985 * s/irix6-5.h: ... here.
1986
22b4128e
PE
19872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1990 * alloc.c (mark_buffer):
1991 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1992 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1993 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1994 This isn't true in general, and it's particularly not true
1995 if Emacs is configured with --with-wide-int.
1996 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1997 New macros, used in the buffer.c change.
1998
869795d6
JD
19992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2000
2001 * xsettings.c: Use both GConf and GSettings if both are available.
2002 (store_config_changed_event): Add comment.
2003 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2004 (store_tool_bar_style_changed): New functions.
2005 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2006 (struct xsettings): Move font inside HAVE_XFT.
2007 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2008 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2009 Move inside HAVE_XFT.
640c8776 2010 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2011 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2012 also.
2013 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
2014 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2015 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2016 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2017 (parse_settings): Move check for font inside HAVE_XFT.
2018 (read_settings, apply_xft_settings): Add comment.
2019 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2020 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2021 call store_font_name_changed.
2022 (xft_settings_event): Add comment.
2023 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2024 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2025 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2026 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2027 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2028 (xsettings_get_system_font, xsettings_get_system_normal_font):
2029 Add comment.
869795d6 2030
d8ed26bd
PE
20312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 Random fixes. E.g., (random) never returned negative values.
2034 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2035 subseconds part to the entropy, as that's a bit more random.
2036 Prefer signed to unsigned, since the signedness doesn't matter and
2037 in general we prefer signed. When given a limit, use a
2038 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2039 latter isn't right if USE_2_TAGS_FOR_INTS.
2040 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2041 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2042
cabf1cac
SM
20432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2044
2045 * textprop.c (text_property_stickiness):
2046 Obey Vtext_property_default_nonsticky.
2047 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2048 * w32fns.c (syms_of_w32fns):
2049 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2050
6e9b2be9
PE
20512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2052
2053 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2054 This is more efficient than Ffile_directory_p and avoids a minor race.
2055
90186c68
LMI
20562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2057
7c301272
LMI
2058 * buffer.c (Foverlay_put): Say what the return value is
2059 (bug#7835).
2060
c4f2d8d4
LMI
2061 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2062 is a directory before asking whether to use the file name
2063 (bug#7564).
ad637907
LMI
2064 (barf_or_query_if_file_exists): Make the "File is a directory"
2065 error be more correct.
c4f2d8d4 2066
90186c68
LMI
2067 * fns.c (Frequire): Remove the mention of the .gz files, since
2068 that's installation-specific, but keep the mention of
2069 `get-load-suffixes'.
2070
da64016e
PE
20712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2074 Report string overflow if the output is too long.
2075
7d47b580
JB
20762011-07-04 Juanma Barranquero <lekktu@gmail.com>
2077
a555cb87
JB
2078 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2079 (syms_of_gnutls): Remove duplicate DEFSYM for
2080 Qgnutls_bootprop_verify_hostname_error, an error for
2081 Qgnutls_bootprop_verify_error (which is no longer used).
2082
7d47b580
JB
2083 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2084 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2085 Also (re)move comments that are misplaced or no longer relevant.
2086
1e49bfab
LMI
20872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2088
2089 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2090
1485f4c0
CY
20912011-07-03 Chong Yidong <cyd@stupidchicken.com>
2092
2093 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2094 and background color parameters if they have been changed.
2095
a9ab721e
LMI
20962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2097
2098 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2099
cf7cff57
PE
21002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2101
2e13213d
PE
2102 * xsettings.c (SYSTEM_FONT): Define only when used.
2103 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2104
cf7cff57
PE
2105 * keymap.c (access_keymap_1): Now static.
2106
7a8e04f7
CY
21072011-07-02 Chong Yidong <cyd@stupidchicken.com>
2108
2109 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2110 leave any prefix arg for the up event (Bug#1586).
2111
61352f62
LMI
21122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2113
69bb1ef7
LMI
2114 * lread.c (syms_of_lread): Mention single symbols defined by
2115 `defvar' or `defconst' (bug#7154).
2116
61352f62 2117 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2118 (Frequire): Mention get-load-suffixes.
61352f62 2119
28545e04
MR
21202011-07-02 Martin Rudalics <rudalics@gmx.at>
2121
2122 * window.h (window): Remove clone_number slot.
2123 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2124 Remove.
2125 (make_parent_window, make_window, saved_window)
2126 (Fset_window_configuration, save_window_save): Don't deal with
2127 clone numbers.
2128 * buffer.c (Qclone_number): Remove declaration.
2129 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2130
3349e122
SM
21312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2132
2133 Add multiple inheritance to keymaps.
2134 * keymap.c (Fmake_composed_keymap): New function.
2135 (Fset_keymap_parent): Simplify.
2136 (fix_submap_inheritance): Remove.
2137 (access_keymap_1): New function extracted from access_keymap to handle
2138 embedded parents and handle lists of maps.
2139 (access_keymap): Use it.
2140 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2141 (Fcopy_keymap): Handle embedded parents.
2142 (Fcommand_remapping, define_as_prefix): Simplify.
2143 (Fkey_binding): Simplify.
2144 (syms_of_keymap): Move minibuffer-local-completion-map,
2145 minibuffer-local-filename-completion-map,
2146 minibuffer-local-must-match-map, and
2147 minibuffer-local-filename-must-match-map to Elisp.
2148 (syms_of_keymap): Defsubr make-composed-keymap.
2149 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2150 (parse_menu_item): Trivial simplification.
2151
3279eb87
GM
21522011-07-01 Glenn Morris <rgm@gnu.org>
2153
2154 * Makefile.in (SETTINGS_LIBS): Fix typo.
2155
4550efdf
KI
21562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2157
2158 * coding.c (Fencode_coding_string): Record the last coding system
2159 used, as the function doc string says (bug#8738).
2160
0949d2b6
JD
21612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2162
2163 * xsettings.c (store_monospaced_changed): Take new font as arg and
2164 check for change against current_mono_font.
2165 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2166 (emacs_settings_constructor, emacs_settings_get_property)
2167 (emacs_settings_set_property, emacs_settings_class_init)
2168 (emacs_settings_init, gsettings_obj): Remove.
2169 (something_changedCB): New function for HAVE_GSETTINGS.
2170 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2171 with value as argument.
2172 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2173 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2174 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2175 "changed".
2176
2177 * xgselect.c: Add defined (HAVE_GSETTINGS).
2178 (xgselect_initialize): Ditto.
2179
2180 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2181 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2182 xg_select.
2183
bbc6b304
PE
21842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 * eval.c (struct backtrace): Simplify and port the data structure.
2187 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2188 signed bit field, as this assumption is not portable and it makes
2189 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2190 "char debug_on_exit : 1" as this is not portable either; instead,
2191 use the portable "unsigned int debug_on_exit : 1". Remove unused
2192 member evalargs. Remove obsolete comments about cc bombing out.
2193
9851bfc5
JD
21942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2195
51bb811f 2196 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2197 Let HAVE_GSETTINGS override HAVE_GCONF.
2198 (store_monospaced_changed): New function.
2199 (EMACS_SETTINGS): A new type derived from GObject to handle
2200 GSettings notifications.
2201 (emacs_settings_constructor, emacs_settings_get_property)
2202 (emacs_settings_set_property, emacs_settings_class_init):
2203 New functions.
2204 (gsettings_client, gsettings_obj): New variables.
2205 (GSETTINGS_SCHEMA): New define.
2206 (something_changedCB): Call store_monospaced_changed.
2207 (init_gsettings): New function.
2208 (xsettings_initialize): Call init_gsettings.
2209 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2210 to NULL.
2211
640c8776 2212 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2213 GCONF_CFLAGS/LIBS.
2214
5386012d
MR
22152011-06-29 Martin Rudalics <rudalics@gmx.at>
2216
2217 * window.c (resize_root_window, grow_mini_window)
2218 (shrink_mini_window): Rename Qresize_root_window to
2219 Qwindow_resize_root_window and Qresize_root_window_vertically to
2220 Qwindow_resize_root_window_vertically.
2221
f13e0b08
PE
22222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2223
2224 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2225
94515237
JB
22262011-06-27 Juanma Barranquero <lekktu@gmail.com>
2227
2228 * makefile.w32-in: Redesign dependencies so they reflect more
2229 clearly which files are directly included by each source file,
2230 and not through other includes.
2231
e43b6e43
MR
22322011-06-27 Martin Rudalics <rudalics@gmx.at>
2233
2234 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2235 (sort_overlays, overlay_strings): When an overlay's clone number
2236 matches the window's clone number process the overlay even if
2237 the overlay's window property doesn't match the current window.
2238
d68443dc
MR
2239 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2240 (Fwindow_hchild): Rename to Fwindow_left_child.
2241 (Fwindow_next): Rename to Fwindow_next_sibling.
2242 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2243 (resize_window_check): Rename to window_resize_check.
2244 (resize_window_apply): Rename to window_resize_apply.
2245 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2246 (Fdelete_other_windows_internal, resize_frame_windows)
2247 (Fsplit_window_internal, Fdelete_window_internal)
2248 (grow_mini_window, shrink_mini_window)
2249 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2250
c7e73be5
JD
22512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2252
2253 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2254 (emacs_fixed_set_min_size): Remove.
2255 (emacs_fixed_new): Take frame as argument.
2256
2257 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2258 (_EmacsFixedPrivate): Remove minwidth/height.
2259 Add struct frame *f.
2260 (emacs_fixed_init): Initialize priv->f.
2261 (get_parent_class, emacs_fixed_set_min_size): Remove.
2262 (emacs_fixed_new): Set priv->f to argument.
2263 (emacs_fixed_get_preferred_width)
2264 (emacs_fixed_get_preferred_height): Use min_width/height from
2265 frames size_hint to set minimum and natural (Bug#8919).
2266 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2267 and use min_width/height from frames size_hint to set
2268 min_width/height (Bug#8919).
2269
2270 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2271 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2272 Fix indentation.
c7e73be5 2273
cf99dcf8
EZ
22742011-06-26 Eli Zaretskii <eliz@gnu.org>
2275
2276 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2277 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2278 called at ZV.
2279
029529ac
CY
22802011-06-26 Chong Yidong <cyd@stupidchicken.com>
2281
2282 * process.c (wait_reading_process_output): Bypass select if
2283 waiting for a cell while ignoring keyboard input, and input is
2284 pending. Suggested by Jan Djärv (Bug#8869).
2285
7a7ef429
PE
22862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 Use gnulib's dup2 module instead of rolling our own.
2289 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2290
11fdef7d 22912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2292
2293 * dispnew.c (scrolling_window): Before scrolling, turn off a
2294 mouse-highlight in the window being scrolled.
2295
cd3520a4
JB
22962011-06-24 Juanma Barranquero <lekktu@gmail.com>
2297
2298 Move DEFSYM to lisp.h and use everywhere.
2299
2300 * character.h (DEFSYM): Move declaration...
2301 * lisp.h (DEFSYM): ...here.
2302
2303 * gnutls.c:
2304 * minibuf.c:
2305 * w32menu.c:
2306 * w32proc.c:
2307 * w32select.c: Don't include character.h.
2308
2309 * alloc.c (syms_of_alloc):
2310 * buffer.c (syms_of_buffer):
2311 * bytecode.c (syms_of_bytecode):
2312 * callint.c (syms_of_callint):
2313 * casefiddle.c (syms_of_casefiddle):
2314 * casetab.c (init_casetab_once):
2315 * category.c (init_category_once, syms_of_category):
2316 * ccl.c (syms_of_ccl):
2317 * cmds.c (syms_of_cmds):
2318 * composite.c (syms_of_composite):
2319 * dbusbind.c (syms_of_dbusbind):
2320 * dired.c (syms_of_dired):
2321 * dispnew.c (syms_of_display):
2322 * doc.c (syms_of_doc):
2323 * editfns.c (syms_of_editfns):
2324 * emacs.c (syms_of_emacs):
2325 * eval.c (syms_of_eval):
2326 * fileio.c (syms_of_fileio):
2327 * fns.c (syms_of_fns):
2328 * frame.c (syms_of_frame):
2329 * fringe.c (syms_of_fringe):
2330 * insdel.c (syms_of_insdel):
2331 * keymap.c (syms_of_keymap):
2332 * lread.c (init_obarray, syms_of_lread):
2333 * macros.c (syms_of_macros):
2334 * msdos.c (syms_of_msdos):
2335 * print.c (syms_of_print):
2336 * process.c (syms_of_process):
2337 * search.c (syms_of_search):
2338 * sound.c (syms_of_sound):
2339 * syntax.c (init_syntax_once, syms_of_syntax):
2340 * terminal.c (syms_of_terminal):
2341 * textprop.c (syms_of_textprop):
2342 * undo.c (syms_of_undo):
2343 * w32.c (globals_of_w32):
2344 * window.c (syms_of_window):
2345 * xdisp.c (syms_of_xdisp):
2346 * xfaces.c (syms_of_xfaces):
2347 * xfns.c (syms_of_xfns):
2348 * xmenu.c (syms_of_xmenu):
2349 * xsettings.c (syms_of_xsettings):
2350 * xterm.c (syms_of_xterm): Use DEFSYM.
2351
4228cf16
TZ
23522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2353
cd3520a4 2354 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2355
7fcccf1e
PE
23562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2357
7efb4e0e
PE
2358 Integer and buffer overflow fixes (Bug#8873).
2359
ff5844ad
PE
2360 * print.c (printchar, strout): Check for string overflow.
2361 (PRINTPREPARE, printchar, strout):
2362 Don't set size unless allocation succeeds.
2363
90532f02
PE
2364 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2365 for sizes. Check for string overflow more accurately.
2366 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2367
6d84508d
PE
2368 * macros.c: Integer and buffer overflow fixes.
2369 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2370 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2371 Use ptrdiff_t, not int, for sizes.
2372 Don't increment bufsize until after realloc succeeds.
2373 Check for size-calculation overflow.
2374 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2375
437b2cb4
PE
2376 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2377
8b9ac8b4
PE
2378 * lread.c: Integer overflow fixes.
2379 (read_integer): Radix is now EMACS_INT, not int,
2380 to improve quality of diagnostics for out-of-range radices.
2381 Calculate buffer size correctly for out-of-range radices.
2382 (read1): Check for integer overflow in radices, and in
2383 read-circle numbers.
82cb60d3
PE
2384 (read_escape): Avoid int overflow.
2385 (Fload, openp, read_buffer_size, read1)
2386 (substitute_object_recurse, read_vector, read_list, map_obarray):
2387 Use ptrdiff_t, not int, for sizes.
2388 (read1): Use EMACS_INT, not int, for sizes.
20270765 2389 Check for size overflow.
8b9ac8b4 2390
7fcccf1e
PE
2391 * image.c (cache_image): Check for size arithmetic overflow.
2392
bfbbd7e7
PE
2393 * lread.c: Integer overflow issues.
2394 (saved_doc_string_size, saved_doc_string_length)
2395 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2396 Now ptrdiff_t, not int.
2397 (read1): Don't assume doc string length fits in int. Check for
2398 out-of-range doc string lengths.
2399 (read_list): Don't assume file position fits in int.
39019e54 2400 (read_escape): Check for hex character overflow.
bfbbd7e7 2401
4e323265
LL
24022011-06-22 Leo Liu <sdl.web@gmail.com>
2403
2404 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2405 Move to minibuffer.el.
2406
85fece3e
PE
24072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2408
20b84ce9 2409 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2410 The following patches are for when GLYPH_DEBUG && !XASSERT.
2411 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2412 * dispnew.c (flush_stdout):
2413 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2414 Mark as externally visible.
2415 * dispnew.c (check_window_matrix_pointers): Now static.
2416 * dispnew.c (window_to_frame_vpos):
2417 * xfns.c (unwind_create_frame):
2418 * xterm.c (x_check_font): Remove unused local.
2419 * scroll.c (CHECK_BOUNDS):
2420 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2421 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2422 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2423 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2424 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2425 Now static.
2426 (debug_method_add): Use va_list and vsprintf rather than relying
2427 on undefined behavior with wrong number of arguments.
2428 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2429 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2430 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2431 since we're not interested in debugging glyphs with old libraries.
2432 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2433 GCC 4.6.0's static checking.
2434
0766b489
PE
24352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2436
31fd4b32
PE
2437 Integer overflow and signedness fixes (Bug#8873).
2438 A few related buffer overrun fixes, too.
2439
b79e8648
PE
2440 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2441
0766b489
PE
2442 * dispextern.h (struct face.stipple):
2443 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2444 (x_bitmap_mask, x_allocate_bitmap_record)
2445 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2446 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2447 (x_create_bitmap_from_xpm_data):
2448 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2449 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2450 (.bitmaps_last):
2451 * xfaces.c (load_pixmap):
2452 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2453 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2454 (.bitmaps_last, struct x_output.icon_bitmap):
2455 Use ptrdiff_t, not int, for bitmap indexes.
2456 (x_allocate_bitmap_record): Check for size overflow.
2457 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2458
b081724f
PE
2459 Use ptrdiff_t, not int, for overlay counts.
2460 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2461 * editfns.c (overlays_around, get_pos_property):
2462 * textprop.c (get_char_property_and_overlay):
2463 * xdisp.c (next_overlay_change, note_mouse_highlight):
2464 * xfaces.c (face_at_buffer_position):
21514da7
PE
2465 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2466 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2467 (Fnext_overlay_change, Fprevious_overlay_change)
2468 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2469 Use ptrdiff_t, not int, for sizes.
21514da7 2470 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2471
3de73e5e
PE
2472 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2473
2606c57b
PE
2474 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2475 (x_session_initialize): Do not assume string length fits in int.
2476
aaafe47a
PE
2477 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2478 This is unlikely, but can occur if DPI is outlandish.
2479
2674ddc8 2480 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2481 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2482
28154962
PE
2483 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2484 * xrdb.c (magic_file_p, search_magic_path):
2485 Omit last arg SUFFIX; it was always 0. All callers changed.
2486 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2487
7de51af5
PE
2488 * xfont.c (xfont_match): Avoid need for strlen.
2489
25ed6cc3
PE
2490 * xfns.c: Don't assume strlen fits in int.
2491 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2492
4eab31dd
PE
2493 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2494 not unsigned long, as we prefer signed integers. All callers changed.
2495 Detect integer overflow in repeat count.
2496 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2497 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2498
171e2a58
PE
2499 * termcap.c: Don't assume sizes fit in int and never overflow.
2500 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2501 (gobble_line): Check for size-calculation overflow.
2502
ad39faca 2503 * minibuf.c (Fread_buffer):
6e5bb2dc 2504 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2505 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2506 Don't assume string length fits in int.
2507
52c61c22 2508 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2509 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2510
b5b8c9e5
PE
2511 * font.c: Don't assume string length fits in int.
2512 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2513 Use ptrdiff_t, not int.
ccd6111c
PE
2514 (font_intern_prop): Don't assume string length fits in int.
2515 Don't assume integer property fits in fixnum.
2516 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2517
882f0d81 2518 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2519 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2520 Reformulate so as not to need the command string.
2521 Invoke gzip -cd rather than gunzip, as it's more portable.
2522 (lock_info_type, lock_file_1, lock_file):
2523 Don't assume pid_t and time_t fit in unsigned long.
2524 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2525 (current_lock_owner): Prefer signed type for sizes.
2526 Use memcpy, not strncpy, where memcpy is what is really wanted.
2527 Don't assume (via atoi) that time_t and pid_t fit in int.
2528 Check for time_t and/or pid_t out of range, e.g., via a network share.
2529 Don't alloca where an auto var works fine.
2530
93f4cf88
PE
2531 * fileio.c: Fix some integer overflow issues.
2532 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2533 Don't assume string length fits in int.
2534 (directory_file_name): Don't assume string length fits in long.
2535 (make_temp_name): Don't assume pid fits in int, or that its print
2536 length is less than 20.
2537
f3e92b69
PE
2538 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2539
1bfdaf10
PE
2540 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2541
35016e9a
PE
2542 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2543
3d1e65a1
PE
2544 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2545 We prefer signed integers, even for size calculations.
2546
0b963a93
PE
2547 * emacs.c: Don't assume string length fits in 'int'.
2548 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2549 (main): Don't invoke strlen when not needed.
2550
573f4b54
PE
2551 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2552 (XD_DEBUG_MESSAGE): Don't waste a byte.
2553
989f33ba
PE
2554 * callproc.c (getenv_internal_1, getenv_internal)
2555 (Fgetenv_internal):
965d34eb
PE
2556 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2557
e4d29b33
PE
2558 * lread.c (invalid_syntax): Omit length argument.
2559 All uses changed. This doesn't fix a bug, but it simplifies the
2560 code away from its former Hollerith-constant appearance, and it's
2561 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2562 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2563
eb49b136
PE
2564 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2565 This didn't break anything, but it didn't help either.
2566 It's confusing to put a bogus integer in a place where the actual
2567 value does not matter.
9f62aeb1 2568 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2569 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2570
15375a22
PE
2571 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2572 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2573 implementation.
b61cc01c
PE
2574 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2575 We prefer signed types, and the value cannot exceed the EMACS_INT
2576 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2577 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2578 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2579 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2580
53b2623d
PE
2581 * indent.c (sane_tab_width): New function.
2582 (current_column, scan_for_column, Findent_to, position_indentation)
2583 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2584 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2585
51cab52b 2586 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2587
f2ed8a70
PE
2588 * lisp.h (lint_assume): New macro.
2589 * composite.c (composition_gstring_put_cache):
2590 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2591
abe80cc6
PE
2592 * editfns.c, insdel.c:
2593 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2594
b02c740e
PE
2595 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2596
ebc96716
PE
2597 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2598
b4e50fa0 2599 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2600 Use much-faster test for byte-length change.
311d5d7c 2601 Don't assume string byte-length fits in 'int'.
a4cf38e4 2602 Check that character arg fits in 'int'.
85461888 2603 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2604
c0c1ee9f
PE
2605 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2606
a498d7f4
PE
2607 * fns.c (concat): Catch string overflow earlier.
2608 Do not rely on integer wraparound.
2609
51cab52b
PE
2610 * dispextern.h (struct it.overlay_strings_charpos)
2611 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2612 * xdisp.c (forward_to_next_line_start)
2613 (back_to_previous_visible_line_start)
2614 (reseat_at_next_visible_line_start, next_element_from_buffer):
2615 Don't arbitrarily truncate the value of 'selective' to int.
2616
76031fad
PE
2617 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2618
5eb55db9
PE
2619 * composite.c: Don't truncate sizes to 'int'.
2620 (composition_gstring_p, composition_reseat_it)
2621 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2622 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2623 not EMACS_UINT, for indexes.
5eb55db9 2624
0703a717
PE
2625 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2626
d6202519
PE
2627 * buffer.c: Include <verify.h>.
2628 (struct sortvec.priority, struct sortstr.priority):
8961a454 2629 Now EMACS_INT, not int.
c20998a7 2630 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2631 (struct sortstr.size, record_overlay_string)
2632 (struct sortstrlist.size, struct sortlist.used):
2633 Don't truncate size to int.
2634 (record_overlay_string): Check for size-calculation overflow.
d6202519 2635 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2636
d5a19415
JM
26372011-06-22 Jim Meyering <meyering@redhat.com>
2638
029529ac 2639 Don't leak an XBM-image-sized buffer
d5a19415
JM
2640 * image.c (xbm_load): Free the image buffer after using it.
2641
a9041e6c
PE
26422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 Port to Sun C.
2645 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2646 that Sun C diagnosed.
2647 * fns.c (secure_hash): Fix pointer signedness issue.
2648 * intervals.c (static_offset_intervals): New function.
2649 (offset_intervals): Use it.
2650
7f3f739f
LL
26512011-06-21 Leo Liu <sdl.web@gmail.com>
2652
2653 * deps.mk (fns.o):
2654 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2655 sha512.h.
2656
2657 * fns.c (secure_hash): Rename from crypto_hash_function and change
2658 the first arg to accept symbols.
5b66d427 2659 (Fsecure_hash): New primitive.
7f3f739f
LL
2660 (syms_of_fns): New symbols.
2661
76147d94
DD
26622011-06-20 Deniz Dogan <deniz@dogan.se>
2663
2664 * process.c (Fset_process_buffer): Clarify return value in
2665 docstring.
2666
7d7d0045
CY
26672011-06-18 Chong Yidong <cyd@stupidchicken.com>
2668
2669 * dispnew.c (add_window_display_history): Use BVAR.
2670
2671 * xdisp.c (debug_method_add): Use BVAR.
2672 (check_window_end, dump_glyph_matrix, dump_glyph)
2673 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2674
2675 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2676 Likewise.
2677
2678 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2679 check till after the cache is created in init_frame_faces.
2680
ff2bc410
SM
26812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2682
2683 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2684
28177add
PE
26852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2686
dd3482fe
PE
2687 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2688 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2689 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2690
393d71f3 2691 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2692 * fileio.c (Finsert_file_contents):
2693 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2694 Remove the old (too-loose) buffer overflow checks.
2695 They weren't needed, since make_gap checks for buffer overflow.
2696 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2697 The old code merely checked for Emacs fixnum overflow, and relied
2698 on undefined (wraparound) behavior. The new code avoids undefined
2699 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2700
2e6813b0 2701 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2702 Tune. Don't use wider integers than needed. Don't use alloca.
2703 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2704
599a9e4f
PE
2705 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2706
99561444
PE
2707 * insdel.c, lisp.h (buffer_overflow): New function.
2708 (insert_from_buffer_1, replace_range, replace_range_2):
2709 * insdel.c (make_gap_larger):
2710 * editfns.c (Finsert_char):
2711 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2712
28177add
PE
2713 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2714
e69dafad
PE
27152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2716
a7af7fde 2717 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2718
b1c46f02
PE
2719 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2720 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2721
e69dafad
PE
2722 * fileio.c: Don't assume EMACS_INT fits in off_t.
2723 (emacs_lseek): New static function.
2724 (Finsert_file_contents, Fwrite_region): Use it.
2725 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2726
566684ea
PE
2727 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2728
e6966cd6
PE
2729 * fns.c: Don't overflow int when computing a list length.
2730 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2731 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2732 truncation on 64-bit hosts. Check for QUIT every
2733 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2734 faster and is responsive enough.
2735 (Flength): Report an error instead of overflowing an integer.
2736 (Fsafe_length): Return a float if the value is not representable
2737 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2738 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2739 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2740
dd0b0efb
PE
2741 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2742 (header_size, word_size): New constants.
2743 (allocate_vectorlike): Don't check size overflow here.
2744 (allocate_vector): Check it here instead, since this is the only
2745 caller of allocate_vectorlike that could cause overflow.
2746 Check that the new vector's length is representable as a fixnum.
2747
86fe5cfe
PE
2748 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2749 The previous code was bogus. For example, next_almost_prime (32)
2750 returned 39, which is undesirable as it is a multiple of 3; and
2751 next_almost_prime (24) returned 25, which is a multiple of 5 so
2752 why was the code bothering to check for multiples of 7?
2753
80e88859
PE
2754 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2755
4a2f0ad6
PE
2756 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2757
f66c7cf8
PE
2758 Variadic C functions now count arguments with ptrdiff_t.
2759 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2760 Back then I didn't know that the Emacs coding style prefers signed int.
2761 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2762 were being counted with int, which may truncate counts on 64-bit
2763 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2764 * lisp.h (struct Lisp_Subr.function.aMANY)
2765 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2766 Arg counts are now ptrdiff_t, not size_t.
2767 All variadic functions and their callers changed accordingly.
2768 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2769 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2770 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2771 * callint.c (Fcall_interactively): Check arg count for overflow,
2772 to avoid potential buffer overrun. Use signed char, not 'int',
2773 for 'varies' array, so that we needn't bother to check its size
2774 calculation for overflow.
2775 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2776 * eval.c (apply_lambda):
2777 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2778 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2779 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2780
a1759b76
PE
2781 * callint.c (Fcall_interactively): Don't use index var as event count.
2782
d96be9fc
PE
2783 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2784 * mem-limits.h (SIZE): Remove; no longer used.
2785
a690a978 2786 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2787
578c21e6
PE
2788 Remove unnecessary casts.
2789 * xterm.c (x_term_init):
2790 * xfns.c (x_set_border_pixel):
2791 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2792 These aren't needed now that we assume ANSI C.
2793
96f53c6c
PE
2794 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2795 It's more likely to cause problems (due to unsigned overflow)
2796 than to cure them.
2797
83c77d31
PE
2798 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2799
ee2079f1
PE
2800 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2801
6da65536
PE
2802 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2803
7147c4a4
PE
2804 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2805
193e32d9
PE
2806 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2807
e5533da6
PE
2808 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2809
9910e595
PE
2810 GLYPH_CODE_FACE returns EMACS_INT, not int.
2811 * dispextern.h (merge_faces):
2812 * xfaces.c (merge_faces):
01103c44
PE
2813 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2814 Don't assume EMACS_INT fits in int.
9910e595 2815
2638320e
PE
2816 * character.h (CHAR_VALID_P): Remove unused parameter.
2817 * fontset.c, lisp.h, xdisp.c: All uses changed.
2818
045eb8d9
PE
2819 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2820
c1f134b5
PE
2821 * fns.c (concat): Minor tuning based on overflow analysis.
2822 This doesn't fix any bugs. Use int to hold character, instead
2823 of constantly refetching from Emacs object. Use XFASTINT, not
2824 XINT, for value known to be a character. Don't bother comparing
2825 a single byte to 0400, as it's always less.
2826
395fcb93 2827 * floatfns.c (Fexpt):
327eeec8
PE
2828 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2829
abbd3d23
PE
2830 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2831 for characters.
2832
684a03ef
PE
2833 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2834
0fed43f3
PE
2835 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2836 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2837 incorrectly succeed when S was a string, because 4294967386 was
2838 truncated before it was used.
2839
8fd02eb7
PE
2840 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2841 Otherwise, an out-of-range integer could cause undefined behavior
2842 on a 64-bit host.
2843
f8c86b69
PE
2844 * composite.c: Use int, not EMACS_INT, for characters.
2845 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2846 EMACS_INT, for values that are known to be in character range.
2847 This doesn't fix any bugs but is the usual style inside Emacs and
2848 may generate better code on 32-bit machines.
2849
34206dd2
PE
2850 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2851 This is for reasons similar to the recent CHAR_STRING fix.
2852 * charset.c (Fencode_char): Check that character arg is actually
2853 a character. Pass an int to ENCODE_CHAR.
2854 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2855 wider than 'int', as a compile-time check to prevent future regressions
2856 in this area.
2857
c5958d4c 2858 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2859
2860 Make sure a 64-bit char is never passed to CHAR_STRING.
2861 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2862 by silently ignoring the top 32 bits, allowing some values
2863 that were far too large to be valid characters.
2864 * character.h: Include <verify.h>.
2865 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2866 arguments are no wider than unsigned, as a compile-time check
2867 to prevent future regressions in this area.
2868 * data.c (Faset):
01103c44 2869 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2870 (Fsubst_char_in_region):
2871 * fns.c (concat):
2872 * xdisp.c (decode_mode_spec_coding):
2873 Adjust to CHAR_STRING's new requirement.
2874 * editfns.c (Finsert_char, Fsubst_char_in_region):
2875 * fns.c (concat): Check that character args are actually
2876 characters. Without this test, these functions did the wrong
2877 thing with wildly out-of-range values on 64-bit hosts.
2878
d37ca623
PE
2879 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2880 These casts should not be needed on 32-bit hosts, either.
2881 * keyboard.c (read_char):
2882 * lread.c (Fload): Remove casts to unsigned.
2883
ea204efb
PE
2884 * lisp.h (UNSIGNED_CMP): New macro.
2885 This fixes comparison bugs on 64-bit hosts.
2886 (ASCII_CHAR_P): Use it.
2887 * casefiddle.c (casify_object):
01103c44 2888 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2889 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2890 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2891 * dispextern.h (FACE_FROM_ID):
2892 * keyboard.c (read_char): Use UNSIGNED_CMP.
2893
41cb286c
PE
2894 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2895 not to EMACS_INT, to avoid GCC warning.
2896
4a1b9832
PE
2897 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2898
55daad71
PE
2899 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2900 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2901 isn't needed on 32-bit machines.
8f95c75c 2902
01103c44
PE
2903 * buffer.c (Fgenerate_new_buffer_name):
2904 Use EMACS_INT for count, not int.
0ceccced 2905 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2906
2907 * data.c (Qcompiled_function): Now static.
2908
c6f072e7
PE
2909 * window.c (window_body_lines): Now static.
2910
20ce5912
PE
2911 * image.c (gif_load): Rename local to avoid shadowing.
2912
9c4c5f81
PE
2913 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2914 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2915 * alloc.c (make_save_value): Integer argument is now of type
2916 ptrdiff_t, not int.
2917 (mark_object): Use ptrdiff_t, not int.
2918 * lisp.h (pD): New macro.
2919 * print.c (print_object): Use it.
2920
c0c5c8ae
PE
2921 * alloc.c: Use EMACS_INT, not int, to count objects.
2922 (total_conses, total_markers, total_symbols, total_vector_size)
2923 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2924 (total_free_floats, total_floats, total_free_intervals)
2925 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2926 Now EMACS_INT, not int. All uses changed.
2927 (Fgarbage_collect): Compute overall total using a double, so that
2928 integer overflow is less likely to be a problem. Check for overflow
2929 when converting back to an integer.
5a25e253
PE
2930 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2931 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2932 These were 'int' variables that could overflow on 64-bit hosts;
2933 they were never used, so remove them instead of repairing them.
211a0b2a 2934 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2935 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2936 Previously, this ceilinged at INT_MAX, but that doesn't work on
2937 64-bit machines.
e46bb31a 2938 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2939
c78baabf 2940 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2941 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2942 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2943 when a (possibly-narrower) signed value would do just as well.
2944 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2945
c9d624c6
PE
2946 * alloc.c: Catch some string size overflows that we were missing.
2947 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2948 for convenience in STRING_BYTES_MAX.
2949 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2950 The definition here is exact; the one in lisp.h was approximate.
2951 (allocate_string_data): Check for string overflow. This catches
2952 some instances we weren't catching before. Also, it catches
2953 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2954 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2955 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2956
c9d624c6
PE
2957 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2958 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2959 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2960
353032ce
PE
2961 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2962
2bccce07
PE
2963 * alloc.c (Fmake_string): Check for out-of-range init.
2964
0ac30604
SM
29652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2966
2967 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2968
c195f2de
JD
29692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2970
2971 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2972 xg_get_default_scrollbar_width.
2973
2974 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2975 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2976 (style_changed_cb): Call update_theme_scrollbar_width and call
2977 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2978 all frames (Bug#8505).
2979 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2980 Call gtk_window_set_resizable if HAVE_GTK3.
2981 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2982 and height if HAVE_GTK3 (Bug#8505).
2983 (scroll_bar_width_for_theme): New variable.
2984 (update_theme_scrollbar_width): New function.
2985 (xg_get_default_scrollbar_width): Move code to
2986 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2987 (xg_initialize): Call update_theme_scrollbar_width.
2988
2989 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2990
2991 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2992
e10ac9f1
MR
29932011-06-12 Martin Rudalics <rudalics@gmx.at>
2994
2995 * frame.c (make_frame): Call other_buffer_safely instead of
2996 other_buffer.
2997
2998 * window.c (temp_output_buffer_show): Call display_buffer with
2999 second argument Vtemp_buffer_show_specifiers and reset latter
3000 immediately after the call.
3001 (Vtemp_buffer_show_specifiers): New variable.
3002 (auto_window_vscroll_p, next_screen_context_lines)
3003 (Vscroll_preserve_screen_position): Remove leading asterisks from
3004 doc-strings.
3005
2d3c217e 30062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3007
7b7f97e8 3008 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3009 * buffer.c (Qclone_number): Remove for now, as it's unused.
3010 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3011 (record_buffer): Remove unused local.
3012 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3013 (set_frame_buffer_list): Remove; unused.
3014 * frame.h (other_visible_frames): Remove decl.
3015 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3016 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3017 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3018 if HAVE_GPM.
3019 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3020 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3021 Define only if HAVE_GPM.
3022 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3023 (update_hints_inhibit): Remove; never set. All uses removed.
3024 * widgetprv.h (emacsFrameClassRec): Remove decl.
3025 * window.c (delete_deletable_window): Now returns void, since it
3026 wasn't returning anything.
3027 (compare_window_configurations): Remove unused locals.
3028 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3029 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3030 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3031 the same widths as pointers. This follows up on the 2011-05-06 patch.
3032 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3033 * xterm.h: Likewise.
3034 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3035
1384b89e
JB
30362011-06-12 Juanma Barranquero <lekktu@gmail.com>
3037
3038 * makefile.w32-in: Update dependencies.
3039 (LISP_H): Add lib/intprops.h.
3040
1100a63c
CY
30412011-06-11 Chong Yidong <cyd@stupidchicken.com>
3042
3043 * image.c (gif_load): Add animation frame delay to the metadata.
3044 (syms_of_image): Use DEFSYM. New symbol `delay'.
3045
6198ccd0
MR
30462011-06-11 Martin Rudalics <rudalics@gmx.at>
3047
3048 * window.c (delete_deletable_window): Re-add.
3049 (Fset_window_configuration): Rewrite to handle dead buffers and
3050 consequently deletable windows.
3051 (window_tree, Fwindow_tree): Remove. Supply functionality in
3052 window.el.
3053 (compare_window_configurations): Simplify code.
3054
b6e3633c
AS
30552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3056
1ab0dee5
AS
3057 * image.c (imagemagick_load_image): Fix type mismatch.
3058 (Fimagemagick_types): Likewise.
3059
b6e3633c
AS
3060 * window.h (replace_buffer_in_windows): Declare.
3061
9397e56f
MR
30622011-06-11 Martin Rudalics <rudalics@gmx.at>
3063
3064 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3065 Qclone_number. Remove external declaration of Qdelete_window.
3066 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3067 code.
640c8776
SM
3068 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3069 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3070 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3071 buffer list implementation.
3072 (other_buffer_safely): New function.
3073 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3074 calls to replace_buffer_in_windows and
3075 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3076 if allowed.
3077 (record_buffer): Inhibit quitting and rewrite using quittable
3078 functions. Run Qbuffer_list_update_hook if allowed.
3079 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3080 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3081 Move switch-to-buffer to window.el.
9397e56f
MR
3082 (bury-buffer): Move to window.el.
3083 (Vbuffer_list_update_hook): New variable.
3084
3085 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3086 section.
3087
3088 * window.h (resize_frame_windows): Move up in code.
3089 (Fwindow_frame): Remove EXFUN.
3090 (replace_buffer_in_all_windows): Remove prototype.
3091 (replace_buffer_in_windows_safely): Add prototype.
3092
3093 * window.c: Declare Qdelete_window static again. Move down
3094 declaration of select_count.
3095 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3096 (Fother_window): Move to window.el.
3097 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3098 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3099 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3100 window.el.
3101 (replace_buffer_in_windows): Implement by calling
3102 Qreplace_buffer_in_windows.
3103 (replace_buffer_in_all_windows): Remove with some functionality
3104 moved into replace_buffer_in_windows_safely.
3105 (replace_buffer_in_windows_safely): New function.
3106 (select_window_norecord, select_frame_norecord): Move in front
3107 of run_window_configuration_change_hook. Remove now obsolete
3108 declarations.
640c8776
SM
3109 (Fset_window_buffer): Rewrite doc-string.
3110 Call Qrecord_window_buffer.
9397e56f
MR
3111 (keys_of_window): Move binding for other-window to window.el.
3112
b50691aa
CY
31132011-06-11 Chong Yidong <cyd@stupidchicken.com>
3114
3115 * dispextern.h (struct image): Replace data member, whose int_val
3116 and ptr_val fields were not used by anything, with a single
3117 lisp_val object.
3118
3119 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3120 (gif_clear_image, gif_load, imagemagick_load_image)
3121 (gs_clear_image, gs_load): Callers changed.
3122
3f754b86
PE
31232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3124
cca69397
PE
3125 * buffer.h: Include <time.h>, for time_t.
3126 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3127
109e28d0
PE
3128 Fix minor problems found by static checking.
3129
60737f02
PE
3130 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3131
4b66faf3
PE
3132 Make identifiers static if they are not used in other modules.
3133 * data.c (Qcompiled_function, Qframe, Qvector):
3134 * image.c (QimageMagick, Qsvg):
3135 * minibuf.c (Qmetadata):
3136 * window.c (resize_window_check, resize_root_window): Now static.
3137 * window.h (resize_window_check, resize_root_window): Remove decls.
3138
109e28d0
PE
3139 * window.c (window_deletion_count, delete_deletable_window):
3140 Remove; unused.
46a4ce9e
PE
3141 (window_body_lines): Now static.
3142 (Fdelete_other_windows_internal): Mark vars as initialized.
3143 Make sure 'resize_failed' is initialized.
3144 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3145 (resize_window_apply): Remove unused local.
3146 * window.h (delete_deletable_window): Remove decl.
3147
109e28d0 3148 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3149 (imagemagick_load_image): Fix pointer signedness problem by changing
3150 last arg from unsigned char * to char *. All uses changed.
3151 Also, fix a local for similar reasons.
3152 Remove unused locals. Remove locals to avoid shadowing.
3153 (fn_rsvg_handle_free): Remove; unused.
3154 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3155 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3156
3f754b86
PE
3157 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3158
2547adb1
CY
31592011-06-10 Chong Yidong <cyd@stupidchicken.com>
3160
3161 * image.c (gif_load): Fix omitted cast error introduced by
3162 2011-06-06 change.
3163
2c8e37d4
MR
31642011-06-10 Martin Rudalics <rudalics@gmx.at>
3165
3166 * window.h (resize_proportionally, orig_total_lines)
3167 (orig_top_line): Remove from window structure.
3168 (set_window_height, set_window_width, change_window_heights)
3169 (Fdelete_window): Remove prototypes.
3170 (resize_frame_windows): Remove duplicate declaration.
3171
440a42e3
EZ
31722011-06-10 Eli Zaretskii <eliz@gnu.org>
3173
3174 * window.h (resize_frame_windows, resize_window_check)
3175 (delete_deletable_window, resize_root_window)
3176 (resize_frame_windows): Declare prototypes.
3177
3178 * window.c (resize_window_apply): Make definition be "static" to
3179 match the prototype.
3180
562dd5e9
MR
31812011-06-10 Martin Rudalics <rudalics@gmx.at>
3182
3183 * window.c: Remove declarations of Qwindow_size_fixed,
3184 window_min_size_1, window_min_size_2, window_min_size,
3185 size_window, window_fixed_size_p, enlarge_window, delete_window.
3186 Remove static from declaration of Qdelete_window, it's
3187 temporarily needed by Fbury_buffer.
3188 (replace_window): Don't assign orig_top_line and
3189 orig_total_lines.
3190 (Fdelete_window, delete_window): Remove. Window deletion is
3191 handled by window.el.
640c8776
SM
3192 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3193 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3194 (Fdelete_other_windows): Remove. Deleting other windows is
3195 handled by window.el.
3196 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3197 handled in window.el.
3198 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3199 Window minimum sizes are handled in window.el.
3200 (shrink_windows, size_window, set_window_height)
3201 (set_window_width, change_window_heights, window_height)
3202 (window_width, CURBEG, CURSIZE, enlarge_window)
3203 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3204 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3205 handled in window.el.
3206 (make_dummy_parent): Rename to make_parent_window and give it a
3207 second argument horflag.
3208 (make_window): Don't set resize_proportionally any more.
3209 (Fsplit_window): Remove. Windows are split in window.el.
3210 (save_restore_action, save_restore_orig_size)
3211 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3212 Resize mini windows in window.el.
3213 (grow_mini_window, shrink_mini_window): Implement by calling
3214 Qresize_root_window_vertically, resize_window_check and
3215 resize_window_apply.
640c8776
SM
3216 (saved_window, Fset_window_configuration, save_window_save):
3217 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3218 resize_proportionally.
3219 (window_min_height, window_min_width): Move to window.el.
3220 (keys_of_window): Move bindings for delete-other-windows,
3221 split-window, delete-window and enlarge-window to window.el.
3222
3223 * buffer.c: Temporarily extern Qdelete_window.
3224 (Fbury_buffer): Temporarily call Qdelete_window instead of
3225 Fdelete_window (Fbury_buffer will move to window.el soon).
3226
3227 * frame.c (set_menu_bar_lines_1): Remove code handling
3228 orig_top_line and orig_total_lines.
3229
3230 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3231 set_window_height but set heights directly.
3232 (change_frame_size_1): Use resize_frame_windows.
3233
3234 * xdisp.c (init_xdisp): Don't use set_window_height but set
3235 heights directly.
3236
640c8776
SM
3237 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3238 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3239 run_window_configuration_change_hook.
3240
3241 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3242 instead of change_window_heights and run
3243 run_window_configuration_change_hook.
3244
1a13852e
MR
32452011-06-09 Martin Rudalics <rudalics@gmx.at>
3246
3247 * window.c (replace_window): Rename second argument REPLACEMENT to
3248 NEW. New third argument SETFLAG. Rewrite.
3249 (delete_window, make_dummy_parent): Call replace_window with
3250 third argument 1.
3251 (window_list_1): Move down in code.
3252 (run_window_configuration_change_hook): Move set_buffer part
3253 before select_frame_norecord part in order to unwind correctly.
3254 Rename count1 to count.
3255 (recombine_windows, delete_deletable_window, resize_root_window)
3256 (Fdelete_other_windows_internal)
3257 (Frun_window_configuration_change_hook, make_parent_window)
3258 (resize_window_check, resize_window_apply, Fresize_window_apply)
3259 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3260 (Fdelete_window_internal, Fresize_mini_window_internal):
3261 New functions.
1a13852e
MR
3262 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3263
f3d1777e
MR
32642011-06-08 Martin Rudalics <rudalics@gmx.at>
3265
496e208e
MR
3266 * window.h (window): Add some new members to window structure -
3267 normal_lines, normal_cols, new_total, new_normal, clone_number,
3268 splits, nest, prev_buffers, next_buffers.
3269 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3270 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3271
f3d1777e
MR
3272 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3273 Remove.
496e208e
MR
3274 (make_dummy_parent): Set new members of windows structure.
3275 (make_window): Move down in code. Handle new members of window
3276 structure.
3277 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3278 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3279 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3280 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3281 (Fset_window_next_buffers, Fset_window_clone_number):
3282 New functions.
496e208e
MR
3283 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3284 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3285 Doc-string fixes.
3286 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3287 Argument WINDOW can be now internal window too.
3288 (Fwindow_use_time): Move up in code.
3289 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3290 Rewrite doc-string.
3291 (Fset_window_configuration, saved_window)
3292 (Fcurrent_window_configuration, save_window_save): Handle new
3293 members of window structure.
b9e809c2
MR
3294 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3295 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3296 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3297 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3298 Qget_mru_window, Qresize_root_window,
3299 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3300 Qauto_buffer_name; staticpro them.
f3d1777e 3301
abde8f8c
MR
33022011-06-07 Martin Rudalics <rudalics@gmx.at>
3303
3304 * window.c (Fwindow_total_size, Fwindow_left_column)
3305 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3306 (Fwindow_list_1): New functions.
3307 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3308 (Fwindow_width, Fscroll_left, Fscroll_right):
3309 Use window_body_cols instead of window_box_text_cols.
3310 (delete_window, Fset_window_configuration):
3311 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3312 (delete_all_subwindows): Take a window as argument and not a
3313 structure. Rewrite.
190b47e6
MR
3314 (window_loop): Remove handling of GET_LRU_WINDOW and
3315 GET_LARGEST_WINDOW.
3316 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3317
3318 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3319 window_box_text_cols. delete_all_subwindows now takes a
3320 Lisp_Object as argument.
abde8f8c 3321
640c8776
SM
3322 * indent.c (compute_motion, Fcompute_motion):
3323 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3324
fa8a67e6
MR
3325 * frame.c (delete_frame): Call delete_all_subwindows with root
3326 window as argument.
3327
a54e3482
DC
33282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3329
3330 * fns.c (Fputhash): Document return value.
3331
60002bf5
CY
33322011-06-06 Chong Yidong <cyd@stupidchicken.com>
3333
3334 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3335
0c671da6 33362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3337
b862a52a 3338 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3339
be44ca6c
PE
3340 Check for overflow when converting integer to cons and back.
3341 * charset.c (Fdefine_charset_internal, Fdecode_char):
3342 Use cons_to_unsigned to catch overflow.
3343 (Fencode_char): Use INTEGER_TO_CONS.
3344 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3345 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3346 * data.c (long_to_cons, cons_to_long): Remove.
3347 (cons_to_unsigned, cons_to_signed): New functions.
3348 These signal an error for invalid or out-of-range values.
3349 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3350 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3351 * font.c (Ffont_variation_glyphs):
3352 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3353 * lisp.h: Include <intprops.h>.
3354 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3355 (cons_to_signed, cons_to_unsigned): New decls.
3356 (long_to_cons, cons_to_long): Remove decls.
3357 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3358 (Fprimitive_undo): Use CONS_TO_INTEGER.
3359 * xfns.c (Fx_window_property): Likewise.
3360 * xselect.c: Include <limits.h>.
3361 (x_own_selection, selection_data_to_lisp_data):
3362 Use INTEGER_TO_CONS.
3363 (x_handle_selection_request, x_handle_selection_clear)
3364 (x_get_foreign_selection, Fx_disown_selection_internal)
3365 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3366 (lisp_data_to_selection_data): Use cons_to_unsigned.
3367 (x_fill_property_data): Use cons_to_signed.
3368 Report values out of range.
3369
d1f3d2af
PE
3370 Check for buffer and string overflow more precisely.
3371 * buffer.h (BUF_BYTES_MAX): New macro.
3372 * lisp.h (STRING_BYTES_MAX): New macro.
3373 * alloc.c (Fmake_string):
3374 * character.c (string_escape_byte8):
3375 * coding.c (coding_alloc_by_realloc):
3376 * doprnt.c (doprnt):
3377 * editfns.c (Fformat):
3378 * eval.c (verror):
3379 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3380 since they may not be the same number.
3381 * editfns.c (Finsert_char):
3382 * fileio.c (Finsert_file_contents):
3383 Likewise for BUF_BYTES_MAX.
3384
dd52fcea
PE
3385 * image.c: Use ptrdiff_t, not int, for sizes.
3386 (slurp_file): Switch from int to ptrdiff_t.
3387 All uses changed.
3388 (slurp_file): Check that file size fits in both size_t (for
3389 malloc) and ptrdiff_t (for sanity and safety).
3390
7f9bbdbb
PE
3391 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3392 if b->modtime has its maximal value.
3393
dfe18f82
PE
3394 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3395
84acfcf0
PE
3396 Don't assume time_t can fit into int.
3397 * buffer.h (struct buffer.modtime): Now time_t, not int.
3398 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3399 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3400
ccd9a01a
PE
3401 Minor fixes for signed vs unsigned integers.
3402 * character.h (MAYBE_UNIFY_CHAR):
3403 * charset.c (maybe_unify_char):
3404 * keyboard.c (read_char, reorder_modifiers):
3405 XINT -> XFASTINT, since the integer must be nonnegative.
3406 * ftfont.c (ftfont_spec_pattern):
3407 * keymap.c (access_keymap, silly_event_symbol_error):
3408 XUINT -> XFASTINT, since the integer must be nonnegative.
3409 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3410 since it makes no difference and we prefer signed.
3411 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3412 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3413 nonnegative.
3414
d6d100dd
SM
34152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3416
3417 * window.h (Fwindow_frame): Declare.
3418
2b6148e4
PE
34192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3422 (SPARE_MEMORY): Always define.
3423 (LARGE_REQUEST): Remove.
3424 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3425
f230ecc9
MR
34262011-06-06 Martin Rudalics <rudalics@gmx.at>
3427
727e958e
MR
3428 * lisp.h: Move EXFUNS for Fframe_root_window,
3429 Fframe_first_window and Fset_frame_selected_window to window.h.
3430
3431 * window.h: Move EXFUNS for Fframe_root_window,
3432 Fframe_first_window and Fset_frame_selected_window here from
3433 lisp.h.
3434
3435 * frame.c (Fwindow_frame, Fframe_first_window)
3436 (Fframe_root_window, Fframe_selected_window)
3437 (Fset_frame_selected_window): Move to window.c.
3438 (Factive_minibuffer_window): Move to minibuf.c.
3439 (Fother_visible_frames_p): New function.
3440
3441 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3442
f230ecc9
MR
3443 * window.c (decode_window, decode_any_window): Move up in code.
3444 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3445 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3446 (Fwindow_buffer): Move up and rewrite doc-string.
3447 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3448 (Fwindow_prev): New functions.
727e958e
MR
3449 (Fwindow_frame): Move here from frame.c. Accept any window as
3450 argument.
3451 (Fframe_root_window, Fframe_first_window)
3452 (Fframe_selected_window): Move here from frame.c. Accept frame
3453 or arbitrary window as argument. Update doc-strings.
3454 (Fminibuffer_window): Move up in code.
3455 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3456 (Fset_frame_selected_window): Move here from frame.c.
3457 Marginal rewrite.
727e958e
MR
3458 (Fselected_window, select_window, Fselect_window): Move up in
3459 code. Minor doc-string fixes.
f230ecc9 3460
4d09bcf6
PE
34612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3462
3463 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3464 Do not assume that spare memory exists; that assumption is valid
3465 only if SYSTEM_MALLOC.
3466 (LARGE_REQUEST): New macro, so that the issue of large requests
3467 is separated from the issue of spare memory.
3468
810928a2
AS
34692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3470
172418ad
AS
3471 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3472 format. (Bug#8806)
3473
43f862f7
AS
3474 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3475
810928a2
AS
3476 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3477 before statements.
3478
a059fe24
JD
34792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3480
3481 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3482
3483 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3484
3485 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3486 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3487
989bf368
JB
34882011-06-05 Juanma Barranquero <lekktu@gmail.com>
3489
3490 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3491
4b80f674
CY
34922011-06-04 Chong Yidong <cyd@stupidchicken.com>
3493
3494 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3495 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3496 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3497 New error handlers.
4b80f674
CY
3498 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3499 Obey Vx_select_enable_clipboard_manager. Catch errors in
3500 x_clipboard_manager_save (Bug#8779).
3501 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3502 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3503
99a33b77 35042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3505
3506 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3507
99a33b77 35082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3509
3510 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3511 in the current matrix if keep_current_p is non-zero.
3512
8264569d
EZ
35132011-06-04 Eli Zaretskii <eliz@gnu.org>
3514
3515 * bidi.c (bidi_level_of_next_char): Fix last change.
3516
57f97249
EZ
35172011-06-03 Eli Zaretskii <eliz@gnu.org>
3518
fec2107c 3519 Support bidi reordering of text covered by display properties.
57f97249 3520
fec2107c
EZ
3521 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3522 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3523 (bidi_cache_search, bidi_cache_iterator_state)
3524 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3525 (bidi_level_of_next_char, bidi_move_to_visually_next):
3526 Support character positions inside a run of characters covered by a
fec2107c
EZ
3527 display string.
3528 (bidi_paragraph_init, bidi_resolve_explicit_1)
3529 (bidi_level_of_next_char): Call bidi_fetch_char and
3530 bidi_fetch_char_advance instead of FETCH_CHAR and
3531 FETCH_CHAR_ADVANCE.
3532 (bidi_init_it): Initialize new members.
3533 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3534 definitions.
3535 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3536 instead of using explicit *_CHAR codes.
d6d100dd
SM
3537 (bidi_resolve_explicit, bidi_resolve_weak):
3538 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3539 bidirectional text is supported only in multibyte buffers.
3540 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3541 it to initialize the frame_window_p member of struct bidi_it.
3542 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3543 (bidi_resolve_explicit, bidi_resolve_weak)
3544 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3545 bidi_it->nchars is non-positive.
3546 (bidi_level_of_next_char): Don't try to lookup the cache for the
3547 next/previous character if nothing is cached there yet, or if we
3548 were just reseat()'ed to a new position.
c40e2fb2 3549
0e14fe90
EZ
3550 * xdisp.c (set_cursor_from_row): Set start and stop points
3551 according to the row's direction when priming the loop that looks
3552 for the glyph on which to display cursor.
3553 (single_display_spec_intangible_p): Function deleted.
3554 (display_prop_intangible_p): Reimplement to call
3555 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3556 Accept 3 additional arguments needed by handle_display_spec.
3557 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3558 values: lists, `(when COND...)' forms, etc.
3559 (single_display_spec_string_p): Support property values that are
3560 lists with the argument STRING its top-level element.
3561 (display_prop_string_p): Fix the condition for processing a
3562 property that is a list to be consistent with handle_display_spec.
fec2107c 3563 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3564 last portion of handle_display_prop.
3565 (compute_display_string_pos): Accept additional argument
3566 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3567 value of a `display' property is a "replacing spec".
3568 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3569 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3570 the display property, but just return a value indicating whether
3571 the display property will replace the characters it covers.
3572 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3573 frame_window_p members of struct bidi_it.
d6d100dd
SM
3574 (compute_display_string_pos, compute_display_string_end):
3575 New functions.
fec2107c
EZ
3576 (push_it): Accept second argument POSITION, where pop_it should
3577 jump to continue iteration.
3578 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3579
fec2107c
EZ
3580 * keyboard.c (adjust_point_for_property): Adjust the call to
3581 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3582
3583 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3584 (bidi_init_it): Update prototypes.
3585 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3586 (compute_display_string_pos, compute_display_string_end):
3587 Declare prototypes.
fec2107c
EZ
3588 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3589 EMACS_INT.
fc6f18ce 3590
40087514 35912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3592
57f53182
PE
3593 Malloc failure behavior now depends on size of allocation.
3594 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3595 * lisp.h: Change signatures accordingly.
3596 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3597 All callers changed. (Bug#8762)
3598
3599 * gnutls.c: Use Emacs's memory allocators.
3600 Without this change, the gnutls library would invoke malloc etc.
3601 directly, which causes problems on non-SYNC_INPUT hosts, and which
3602 runs afoul of improving memory_full behavior. (Bug#8761)
3603 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3604 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3605 xfree instead of the default malloc, realloc, free.
3606 (Fgnutls_boot): No need to check for memory allocation failure,
3607 since xmalloc does that for us.
3608
ac32cd99 3609 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3610 * category.c (hash_get_category_set):
3611 * ccl.c (ccl_driver):
3612 * charset.c (Fdefine_charset_internal):
3613 * charset.h (struct charset.hash_index):
3614 * composite.c (get_composition_id, gstring_lookup_cache)
3615 (composition_gstring_put_cache):
3616 * composite.h (struct composition.hash_index):
3617 * dispextern.h (struct image.hash):
3618 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3619 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3620 (hashfn_equal, hashfn_user_defined, make_hash_table)
3621 (maybe_resize_hash_table, hash_lookup, hash_put)
3622 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3623 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3624 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3625 * image.c (make_image, search_image_cache, lookup_image)
3626 (xpm_put_color_table_h):
3627 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3628 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3629 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3630 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3631 * alloc.c (allocate_vectorlike):
3632 Check for overflow in vector size calculations.
3633 * ccl.c (ccl_driver):
3634 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3635 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3636 need to be updated by these changes.
40087514
PE
3637 * fns.c (make_hash_table, maybe_resize_hash_table):
3638 Check for integer overflow with large hash tables.
0de4bb68
PE
3639 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3640 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3641 (SXHASH_REDUCE): New macro.
3642 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3643 Use it instead of discarding useful hash info with large hash values.
3644 (sxhash_float): New function.
3645 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3646 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3647 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3648 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3649 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3650 Adjust signatures to match updated version of code.
3651 (consing_since_gc): Now EMACS_INT, since a single hash table can
3652 use more than INT_MAX bytes.
3653
698d32e2
DN
36542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3655
3656 Make it possible to build with GCC-4.6+ -O2 -flto.
3657
3658 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3659
fd6fa53f
SM
36602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3661
3662 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3663 Call minibuffer-inactive-mode.
3664
864db017
JB
36652011-05-31 Juanma Barranquero <lekktu@gmail.com>
3666
3667 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3668 Update dependencies.
3669
2ad0baf4
DN
36702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3671
3672 * data.c (init_data): Remove code for UTS, this system is not
3673 supported anymore.
3674
4fcc2638
DN
36752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3676
3677 Don't force ./temacs to start in terminal mode.
3678
3679 * frame.c (make_initial_frame): Initialize faces in all cases, not
3680 only when CANNOT_DUMP is defined.
3681 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3682
c56e0fd5
DN
36832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3684
3685 * dispnew.c (add_window_display_history): Use const for the string
3686 pointer. Remove declaration, not needed.
3687
333d54da 36882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3689
55d4c1b2 3690 Use 'inline', not 'INLINE'.
333d54da 3691 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3692 * alloc.c, fontset.c (INLINE): Remove.
3693 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3694 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3695 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3696 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3697 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3698
738db178
DN
36992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3700
3701 Make it possible to run ./temacs.
3702
3703 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3704 syms_of_callproc does the same thing. Remove test for
3705 "initialized", do it in the caller.
3706 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3707
620c53a6
SM
37082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3709
3710 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3711 (read_minibuf): Use get_minibuffer.
3712 (syms_of_minibuf): Use DEFSYM.
3713 (Qmetadata): New var.
3714 * data.c (Qbuffer): Don't make it static.
3715 (syms_of_data): Use DEFSYM.
3716
e003a292
PE
37172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3718
3719 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3720 (CCL_CODE_MIN): New macro.
3721
ed008a6d
PE
37222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3723
3687c2ef
PE
3724 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3725
ed008a6d
PE
3726 * eval.c (Qdebug): Now static.
3727 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3728 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3729 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3730
d66c4c7c
CY
37312011-05-29 Chong Yidong <cyd@stupidchicken.com>
3732
3733 * image.c: Various fixes to ImageMagick code comments.
3734 (Fimagemagick_types): Doc fix.
3735
5fbc2025
PE
37362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3737
0196f88a
PE
3738 Minor fixes prompted by GCC 4.6.0 warnings.
3739
3740 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3741
5fbc2025
PE
3742 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3743 (x_clipboard_manager_save_all): Move extern decl to ...
3744 * xterm.h: ... here, so that it can be checked for consistency.
3745
1dd3c2d9
CY
37462011-05-29 Chong Yidong <cyd@stupidchicken.com>
3747
3748 * xselect.c (x_clipboard_manager_save_frame)
3749 (x_clipboard_manager_save_all): New functions.
3750 (Fx_clipboard_manager_save): Lisp function deleted.
3751
3752 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3753 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3754
3755 * xterm.h: Update prototype.
3756
5ba6571d
WX
37572011-05-28 William Xu <william.xwl@gmail.com>
3758
3759 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3760 exiting (Bug#8239).
3761
3eaff834
JM
37622011-05-28 Jim Meyering <meyering@redhat.com>
3763
e1900994 3764 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3765 * fns.c (to_uchar): Define.
3766 (crypto_hash_function): Use it to convert some newly-signed
3767 variables to unsigned, to avoid sign-extension bugs. For example,
3768 without this change, (md5 "truc") would evaluate to
3769 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3770 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3771 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3772
0f6990a7
PE
37732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3774
3775 Integer overflow fixes.
c8a9ca5a 3776
08686060
PE
3777 * dbusbind.c: Serial number integer overflow fixes.
3778 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3779 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3780 to hold a serial number that is too large for a fixnum.
3781 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3782 Check for serial numbers out of range. Decode any serial number
59568bf0 3783 that was so large that it became a float. (Bug#8722)
08686060 3784
2d1fc3c7
PE
3785 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3786 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3787 Use XFASTINT rather than XUINT when numbers are nonnegative.
3788 (xd_append_arg, Fdbus_method_return_internal):
3789 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3790 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3791 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3792 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3793 (Bug#8722)
2d1fc3c7 3794
c8a9ca5a
PE
3795 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3796
519e1d69
PE
3797 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3798
30569699
PE
3799 ccl: add integer overflow checks
3800 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3801 (IN_INT_RANGE): New macros.
3802 (ccl_driver): Use them to check for integer overflow when
3803 decoding a CCL program. Many of the new checks are whether XINT (x)
3804 fits in int; it doesn't always, on 64-bit hosts. The new version
3805 doesn't catch all possible integer overflows, but it's an
847044ea 3806 improvement. (Bug#8719)
30569699 3807
c11285dc
PE
3808 * alloc.c (make_event_array): Use XINT, not XUINT.
3809 There's no need for unsigned here.
3810
fdccd48e
PE
3811 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3812 This follows up to the 2011-05-06 change that substituted uintptr_t
3813 for EMACS_INT. This case wasn't caught back then.
3814
37910ab2
PE
3815 Rework Fformat to avoid integer overflow issues.
3816 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3817 now (part of C89). Include <verify.h>.
3818 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3819 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3820 (Fformat): Avoid the prepass trying to compute sizes; it was only
3821 approximate and thus did not catch overflow reliably. Instead, walk
3822 through the format just once, formatting and computing sizes as we go,
3823 checking for integer overflow at every step, and allocating a larger
3824 buffer as needed. Keep track separately whether the format is
3825 multibyte. Keep only the most-recently calculated precision, rather
3826 than them all. Record whether each argument has been converted to
3827 string. Use EMACS_INT, not int, for byte and char and arg counts.
3828 Support field widths and precisions larger than INT_MAX. Avoid
3829 sprintf's undefined behavior with conversion specifications such as %#d
3830 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3831 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3832 formatting out-of-range floating point numbers with int
9173deec 3833 formats. (Bug#8668)
37910ab2 3834
2e6578fb
PE
3835 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3836
0ae6bdee
PE
3837 * data.c: Avoid integer truncation in expressions involving floats.
3838 * data.c: Include <intprops.h>.
3839 (arith_driver): When there's an integer overflow in an expression
3840 involving floating point, convert the integers to floating point
3841 so that the resulting value does not suffer from catastrophic
3842 integer truncation. For example, on a 64-bit host (* 4
3843 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3844 Do not rely on undefined behavior after integer overflow.
3845
de883a70
PE
3846 merge count_size_as_multibyte, parse_str_to_multibyte
3847 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3848 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3849 Check for integer overflow.
3850 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3851 since it's now a duplicate of the other. This is more of
3852 a character than a buffer op, so better that it's in character.c.
3853 * fns.c, print.c: Adjust to above changes.
3854
2ff916cb
PE
38552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3856
3857 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3858
f1b54466
PE
38592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3860
fb1ac845
PE
3861 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3862 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3863 (x_clipboard_manager_save): Now static.
3864 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3865
f1b54466
PE
3866 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3867 (crypto_hash_function): Now static.
3868 Fix pointer signedness problems. Avoid unnecessary initializations.
3869
a9f737ee
CY
38702011-05-27 Chong Yidong <cyd@stupidchicken.com>
3871
3872 * termhooks.h (Vselection_alist): Make it terminal-local.
3873
3874 * terminal.c (create_terminal): Initialize it.
3875
3876 * xselect.c: Support for clipboard managers.
3877 (Vselection_alist): Move to termhooks.h as terminal-local var.
3878 (LOCAL_SELECTION): New macro.
3879 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3880 (symbol_to_x_atom): Remove gratuitous arg.
3881 (x_handle_selection_request, lisp_data_to_selection_data)
3882 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3883 (x_own_selection, x_get_local_selection, x_convert_selection):
3884 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3885 (some_frame_on_display): Delete unused function.
3886 (Fx_own_selection_internal, Fx_get_selection_internal)
3887 (Fx_disown_selection_internal, Fx_selection_owner_p)
3888 (Fx_selection_exists_p): New optional frame arg.
3889 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3890 (x_handle_selection_clear): Don't treat other terminals with the
3891 same keyboard specially. Use the terminal-local Vselection_alist.
3892 (x_clear_frame_selections): Use Frun_hook_with_args.
3893
3894 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3895
3896 * xterm.h: Add support for those atoms.
3897
e067f0c1
CY
38982011-05-26 Chong Yidong <cyd@stupidchicken.com>
3899
3900 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3901 (converted_selections, conversion_fail_tag): New global variables.
3902 (x_selection_request_lisp_error): Free the above.
3903 (x_get_local_selection): Remove unnecessary code.
3904 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3905 of converted selections stored in converted_selections.
3906 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3907 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3908 (x_convert_selection): New function.
3909 (x_handle_selection_event): Simplify.
3910 (x_get_foreign_selection): Don't ignore incoming requests while
3911 waiting for an answer; this will fail when we implement
3912 SAVE_TARGETS, and seems unnecessary anyway.
3913 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3914 (Vx_sent_selection_functions): Doc fix.
3915
0f4aebc0
LL
39162011-05-26 Leo Liu <sdl.web@gmail.com>
3917
3918 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3919
e61124cd
YM
39202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3921
3922 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3923
3924 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3925 for fringe update if it has periodic bitmap.
ac389d0c 3926 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3927 and fringe_bitmap_periodic_p.
3928
3929 * fringe.c (get_fringe_bitmap_data): New function.
3930 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3931 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3932 row. Mark glyph row for fringe update if periodicity changed.
3933
3934 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3935 for fringe update unless it has periodic bitmap.
3936
f16d9837
KH
39372011-05-25 Kenichi Handa <handa@m17n.org>
3938
3939 * xdisp.c (get_next_display_element): Set correct it->face_id for
3940 a static composition.
3941
e1b90ef6
LL
39422011-05-24 Leo Liu <sdl.web@gmail.com>
3943
3944 * deps.mk (fns.o):
3945 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3946
3947 * fns.c (crypto_hash_function, Fsha1): New function.
3948 (Fmd5): Use crypto_hash_function.
3949 (syms_of_fns): Add Ssha1.
3950
7400048f
PE
39512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3952
3953 * gnutls.c: Remove unused macros.
3954 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3955 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3956 Remove macros that are defined and never used.
3957 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3958
abb71cf4
CY
39592011-05-22 Chong Yidong <cyd@stupidchicken.com>
3960
3961 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3962 (Fx_get_selection_internal): Minor cleanup.
3963 (Fx_own_selection_internal): Rename arguments for consistency with
3964 select.el.
3965
6307db39
PE
39662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3967
3968 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3969
f3d4e0a4
CY
39702011-05-22 Chong Yidong <cyd@stupidchicken.com>
3971
3972 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3973
4d8ade89
YM
39742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3975
3976 * dispnew.c (scrolling_window): Don't exclude the case that the
3977 last enabled row in the desired matrix touches the bottom boundary.
3978
32078c8d
GM
39792011-05-21 Glenn Morris <rgm@gnu.org>
3980
3981 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3982 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3983 and add some more files.
32078c8d 3984
7285dc67
EZ
39852011-05-20 Eli Zaretskii <eliz@gnu.org>
3986
3987 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3988 report_file_error introduced by the change from 2011-05-07.
3989
89d1bd22
PE
39902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 * systime.h (Time): Define only if emacs is defined.
3993 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3994 where the include path doesn't have X11/X.h by default. See
3995 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3996
e23640bb 39972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3998
3999 * composite.c (find_automatic_composition): Fix previous change.
4000
b9704ad9
GM
40012011-05-20 Glenn Morris <rgm@gnu.org>
4002
4003 * lisp.mk: New file, split from Makefile.in.
4004 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4005 (shortlisp): Remove.
4006 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4007
4a720484
GM
40082011-05-19 Glenn Morris <rgm@gnu.org>
4009
4010 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4011 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4012 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4013 (lisp): Set the order to that of loadup.el.
4014 (shortlisp): Make it a copy of $lisp.
4015 (SOME_MACHINE_LISP): Remove.
4016 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4017 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4018
a28d4396
KH
40192011-05-18 Kenichi Handa <handa@m17n.org>
4020
4021 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4022 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4023 (find_automatic_composition): Mostly rewrite for efficiency.
4024
a2b1fa8e
JB
40252011-05-18 Juanma Barranquero <lekktu@gmail.com>
4026
4027 * makefile.w32-in: Update dependencies.
4028
8e1f5610
CS
40292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4030
4031 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4032 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4033
7025ee00 40342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4035
cdfa6eab
PE
4036 Fix some integer overflow issues, such as string length overflow.
4037
06d6db33
PE
4038 * insdel.c (count_size_as_multibyte): Check for string overflow.
4039
2b4560a8
PE
4040 * character.c (lisp_string_width): Check for string overflow.
4041 Use EMACS_INT, not int, for string indexes and lengths; in
4042 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4043 the resulting string length overflows an EMACS_INT; instead,
4044 report a string overflow if no precision given. When checking for
4045 precision exhaustion, use a check that cannot possibly have
4046 integer overflow. (Bug#8675)
4047 * character.h (lisp_string_width): Adjust to new signature.
4048
cb93f9be
PE
4049 * alloc.c (string_overflow): New function.
4050 (Fmake_string): Use it. This doesn't change behavior, but saves
4051 a few bytes and will simplify future changes.
4052 * character.c (string_escape_byte8): Likewise.
4053 * lisp.h (string_overflow): New decl.
4054
1a1f3366
PE
4055 Fixups, following up to the user-interface timestamp change.
4056 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4057 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4058 * msdos.c (mouse_get_pos): Likewise.
4059 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4060 * w32gui.h (Time): Define by including "systime.h" rather than by
4061 declaring it ourselves. (Bug#8664)
4062
d4e3e4d3
PE
4063 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4064 * image.c (clear_image_cache): Likewise.
4065
f6a24d19
PE
4066 * term.c (term_mouse_position): Don't assume time_t wraparound.
4067
08dc5ae6
PE
4068 Be more systematic about user-interface timestamps.
4069 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4070 and sometimes 'EMACS_UINT', to represent these timestamps.
4071 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4072 This makes the code easier to follow, and makes it easier to catch
4073 integer overflow bugs such as Bug#8664.
4074 * frame.c (Fmouse_position, Fmouse_pixel_position):
4075 Use Time, not unsigned long, for user-interface timestamps.
4076 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4077 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4078 * keyboard.h (last_event_timestamp): Likewise.
4079 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4080 * menu.h (xmenu_show): Likewise.
4081 * term.c (term_mouse_position): Likewise.
4082 * termhooks.h (struct input_event.timestamp): Likewise.
4083 (struct terminal.mouse_position_hook): Likewise.
4084 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4085 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4086 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4087 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4088 what it was before.
4089 * menu.h, termhooks.h: Include "systime.h", for Time.
4090
8e55734a
PE
4091 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4092 Don't assume that the difference between two unsigned long values
4093 can fit into an integer. At this point, we know button_down_time
4094 <= event->timestamp, so the difference must be nonnegative, so
4095 there's no need to cast the result if double-click-time is
4096 nonnegative, as it should be; check that it's nonnegative, just in
4097 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4098 apart (about 25 days). (Bug#8664)
8e55734a 4099
841f1b75 4100 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4101 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4102
3e26f69c
PE
4103 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4104 that always fit in int. Use a sentinel instead of a counter, to
4105 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4106 * frame.h (struct frame): Use int for menu_bar_items_used
4107 instead of EMACS_INT, since it always fits in int.
3e26f69c 4108
5cc152c0
PE
4109 * menu.c (grow_menu_items): Check for int overflow.
4110
d89eb65e
PE
4111 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4112
5235bd3e
PE
4113 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4114 Before, the code was not consistent. These values cannot exceed
4115 2**31 - 1 so there's no need to make them unsigned.
4116 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4117 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4118 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4119 as modifiers.
4120 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4121
bc827e23
PE
4122 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4123 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4124 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4125 presumably because the widths might not match.
4126
78eb494e
PE
4127 * window.c (size_window): Avoid needless test at loop start.
4128
04f2d78b
CB
41292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4130
4131 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4132
d2fc7e3d 41332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4134
4135 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4136
d2fc7e3d 41372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4138
4139 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4140 `width' to `bar_area_x' and `bar_area_width', respectively.
4141 (x_scroll_run): Take account of fringe background extension.
4142
04f2d78b
CB
4143 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4144 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4145 `bar_area_width', respectively.
4146 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4147 background extension.
4148
79b70037
GM
41492011-05-10 Jim Meyering <meyering@redhat.com>
4150
4151 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4152
2f142cc5
JB
41532011-05-10 Juanma Barranquero <lekktu@gmail.com>
4154
4155 * image.c (Finit_image_library): Return t for built-in image types,
4156 like pbm and xbm. (Bug#8640)
4157
57679c86
AS
41582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4159
4160 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4161
888c9e86
EZ
41622011-05-07 Eli Zaretskii <eliz@gnu.org>
4163
b0512a1d
EZ
4164 * w32console.c (Fset_screen_color): Doc fix.
4165 (Fget_screen_color): New function.
4166 (syms_of_ntterm): Defsubr it.
4167
7285dc67
EZ
4168 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4169 unlink the temporary file if Fcall_process didn't create it in the
4170 first place.
4171 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4172 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4173 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4174 cue to call_process_cleanup not to close that handle.
4175
4d3fcc8e
BK
41762011-05-07 Ben Key <bkey76@gmail.com>
4177
4178 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4179 one of two shell specific rules, either bootstrap-temacs-CMD or
4180 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4181 to the previous implementation of the bootstrap-temacs rule.
4182 The bootstrap-temacs-CMD rule is similar to the previous
4183 implementation of the bootstrap-temacs rule except that it
4184 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4185 variable.
4186
4187 These changes, along with some changes to nt/configure.bat,
4188 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4189 earlier fix to add support for --cflags and --ldflags options
4190 that include quotes so that it works whether make uses cmd or
4191 sh as the shell.
4192
b4289b64
MA
41932011-05-06 Michael Albinus <michael.albinus@gmx.de>
4194
4195 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4196 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4197 is a constant.
4198 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4199 a string. Handle both cases.
4200 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4201 (Fdbus_register_method): Use Qinvalid_function.
4202
af4c0e28
JB
42032011-05-06 Juanma Barranquero <lekktu@gmail.com>
4204
4205 * makefile.w32-in: Update dependencies.
4206 (LISP_H): Add inttypes.h and stdin.h.
4207 (PROCESS_H): Add unistd.h.
4208
c51453d9
EZ
42092011-05-06 Eli Zaretskii <eliz@gnu.org>
4210
4211 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4212 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4213
8ff0ac3c 42142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4215
4c4b566b
PE
4216 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4217
aab2b9b5
PE
4218 * term.c (vfatal): Remove stray call to va_end.
4219 It's not needed and the C Standard doesn't allow it here anyway.
4220
c378da0b
PE
4221 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4222 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4223
288b08c7
PE
4224 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4225 bytes.
4226
e3601888
PE
4227 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4228
db6c0e74
PE
4229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4230
dd5963ea
PE
4231 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4232
88c9450f
PE
4233 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4234
2f9442b8
PE
4235 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4236
c032b5f8
PE
4237 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4238 * charset.c (Fdefine_charset_internal): Don't initialize
4239 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4240 32-bit int (Bug#8600).
a108c10b
PE
4241
4242 * lread.c (read_integer): Be more consistent with string-to-number.
4243 Use string_to_number to do the actual conversion; this avoids
4244 rounding errors and fixes some other screwups. Without this fix,
4245 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4246 (digit_to_number): Move earlier, for benefit of read_integer.
4247 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4248 not a digit in any supported base. (Bug#8602)
a108c10b 4249
ad5f9eea
PE
4250 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4251
aec1708a
PE
4252 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4253 to match comment at start of function. This also removes a
4254 GCC warning about overflow in a 32+64-bit port.
4255
47be4ab5
PE
4256 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4257
371cac43
PE
4258 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4259 Reported by Stefan Monnier in
4260 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4261 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4262 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4263
d01a7826
PE
4264 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4265 (EMACS_UINTPTR): Likewise, with uintptr_t.
4266
7fd47d5c
PE
4267 * lisp.h: Prefer 64-bit EMACS_INT if available.
4268 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4269 on 32-bit hosts that have 64-bit int, so that they can access
4270 large files.
122b0c86
PE
4271 However, temporarily disable this change unless the temporary
4272 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4273
8727937b
PE
4274 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4275
8ac068ac
PE
4276 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4277 This removes an assumption that EMACS_INT and long are the same
4278 width as pointers. The assumption is true for Emacs porting targets
4279 now, but we want to make other targets possible.
4280 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4281 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4282 In the rest of the code, change types of integers that hold casted
4283 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4284 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4285 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4286 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4287 No need to cast type when ORing.
4288 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4289 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4290 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4291 assume EMACS_INT is the same width as char *.
4292 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4293 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4294 Remove no-longer-needed casts.
4295 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4296 (xg_tool_bar_help_callback, xg_make_tool_item):
4297 Use EMACS_INTPTR to hold an integer
4298 that will be cast to void *; this can avoid a GCC warning
4299 if EMACS_INT is not the same width as void *.
4300 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4301 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4302 (current_message_1, set_message_1):
4303 Use a local to convert to proper width without a cast.
4304 * xmenu.c (dialog_selection_callback): Likewise.
4305
ede49d71
PE
4306 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4307 Also, don't assume VALBITS / RAND_BITS is less than 5,
4308 and don't rely on undefined behavior when shifting a 1 left into
4309 the sign bit.
4310 * lisp.h (get_random): Change signature to match.
4311
2f30ecd0
PE
4312 * lread.c (hash_string): Use size_t, not int, for hash computation.
4313 Normally we prefer signed values; but hashing is special, because
4314 it's better to use unsigned division on hash table sizes so that
4315 the remainder is nonnegative. Also, size_t is the natural width
4316 for hashing into memory. The previous code used 'int', which doesn't
4317 retain enough info to hash well into very large tables.
4318 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4319
2a866e7b
PE
4320 * dbusbind.c: Don't possibly lose pointer info when converting.
4321 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4322 Use XPNTR rather than XHASH, so that the high-order bits of
4323 the pointer aren't lost when converting through void *.
4324
51639eac
PE
4325 * eval.c (Fautoload): Don't double-shift a pointer.
4326
92394119
PE
4327 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4328
dbdb9a7c
JB
43292011-05-06 Juanma Barranquero <lekktu@gmail.com>
4330
4331 * gnutls.c (DEF_GNUTLS_FN):
4332 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4333
db7a0b4f
AS
43342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4335
4336 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4337 marker. (Bug#8610)
4338
f7ff1b0f 43392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4340
4341 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4342 New version that can reserve upto 2GB of heap space.
4343
f7ff1b0f 43442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4345
4346 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4347
639c109b
TZ
43482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4349
4350 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4351 `gnutls_certificate_set_x509_key_file'.
4352
d2127135
JB
43532011-05-05 Juanma Barranquero <lekktu@gmail.com>
4354
4355 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4356 Update dependencies.
4357
e968f4f3
JB
43582011-05-04 Juanma Barranquero <lekktu@gmail.com>
4359
4360 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4361 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4362 Remove unused parameter `fildes'.
4363 * process.c (read_process_output, send_process): Don't pass it.
4364
84d358f0
JB
43652011-05-04 Juanma Barranquero <lekktu@gmail.com>
4366
4367 Fix previous change: the library cache is defined in w32.c.
4368 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4369 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4370
0898ca10
JB
43712011-05-04 Juanma Barranquero <lekktu@gmail.com>
4372
4373 Implement dynamic loading of GnuTLS on Windows.
4374
4375 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4376 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4377 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4378 Declare.
4379
4380 * gnutls.c (Qgnutls_dll): Define.
4381 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4382 (gnutls_*): Declare function pointers.
4383 (init_gnutls_functions): New function to initialize function pointers.
4384 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4385 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4386 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4387 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4388 (emacs_gnutls_write, emacs_gnutls_read)
4389 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4390 (Fgnutls_available_p): New function.
4391 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4392 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4393 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4394
4395 * image.c: Include w32.h.
4396 (Vimage_type_cache): Delete.
4397 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4398 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4399 (w32_delayed_load): Move to w32.c.
4400
4401 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4402
4403 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4404 (w32_delayed_load): Move from image.c. When loading a library, record
4405 its filename in the :loaded-from property of the library id.
4406 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4407 Initialize and staticpro them.
4408 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4409
4410 * process.c: Include lisp.h before w32.h, not after.
4411 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4412 instead of gnutls_record_check_pending.
4413
4414 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4415
ff4de4aa
TZ
44162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4417
4418 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4419 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4420 as passed in.
4421
abe95abb
JD
44222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4423
4424 * xterm.c (x_set_frame_alpha): Do not set property on anything
4425 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4426
e16e55d4
JB
44272011-05-02 Juanma Barranquero <lekktu@gmail.com>
4428
4429 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4430
bafcf6a5
JB
44312011-05-02 Juanma Barranquero <lekktu@gmail.com>
4432
4433 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4434 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4435 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4436 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4437 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4438 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4439 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4440 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4441 (Qgnutls_bootprop_callbacks_verify): Make static.
4442
e7a6747f
AS
44432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4444
19ed11ba
AS
4445 * callproc.c: Indentation fixup.
4446
e7a6747f 4447 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4448 (wait_for_termination, interruptible_wait_for_termination):
4449 Move after wait_for_termination_1.
e7a6747f 4450
1ef14cb4
LMI
44512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4452
4453 * sysdep.c (interruptible_wait_for_termination): New function
4454 which is like wait_for_termination, but allows keyboard
4455 interruptions.
4456
4457 * callproc.c (Fcall_process): Add (:file "file") as an option for
4458 the STDOUT buffer.
4459 (Fcall_process_region): Ditto.
4460
330d880c
EZ
44612011-04-30 Eli Zaretskii <eliz@gnu.org>
4462
8db90b73
EZ
4463 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4464 rather than `XVECTOR (FOO)->size'.
4465
330d880c
EZ
4466 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4467 inttypes.h, as a gnulib replacement is used if it not available in
4468 system headers.
4469
15cbd324
EZ
44702011-04-21 Eli Zaretskii <eliz@gnu.org>
4471
4472 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4473 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4474 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4475
4476 * coding.c (coding_alloc_by_realloc): Error out if destination
4477 will grow beyond MOST_POSITIVE_FIXNUM.
4478 (decode_coding_emacs_mule): Abort if there isn't enough place in
4479 charbuf for the composition carryover bytes. Reserve an extra
4480 space for up to 2 characters produced in a loop.
4481 (decode_coding_iso_2022): Abort if there isn't enough place in
4482 charbuf for the composition carryover bytes.
4483
44842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4485
ae940cca
EZ
4486 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4487 aborting when %lld or %lll format is passed.
4488 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4489 %llo or %llx format is passed. (Bug#8545)
4490
03ab8921
EZ
4491 * window.c (window_scroll_line_based): Use a marker instead of
4492 simple variables to record original value of point. (Bug#7952)
4493
afda1437
EZ
4494 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4495 produced by %s or %c overflows available buffer space. (Bug#8545)
4496
f76dee0c
PE
44972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4500 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4501
fdc5744d
JB
45022011-04-28 Juanma Barranquero <lekktu@gmail.com>
4503
4504 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4505
638f053a
JB
45062011-04-28 Juanma Barranquero <lekktu@gmail.com>
4507
4508 * keyboard.c (Qdelayed_warnings_hook): Define.
4509 (command_loop_1): Run `delayed-warnings-hook'
4510 if Vdelayed_warnings_list is non-nil.
4511 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4512 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4513
d178f871
EZ
45142011-04-28 Eli Zaretskii <eliz@gnu.org>
4515
4516 * doprnt.c (doprnt): Don't return value smaller than the buffer
4517 size if the message was truncated. (Bug#8545).
4518
b124fd93
JB
45192011-04-28 Juanma Barranquero <lekktu@gmail.com>
4520
4521 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4522 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4523
e810457d
PE
45242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4525
4526 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4527
ea51cceb
JB
45282011-04-27 Juanma Barranquero <lekktu@gmail.com>
4529
4530 * makefile.w32-in: Update dependencies.
4531
94dcfacf
EZ
45322011-04-27 Eli Zaretskii <eliz@gnu.org>
4533
4534 Improve `doprnt' and its usage. (Bug#8545)
4535 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4536 `format_end'. Remove support for %l as a conversion specifier.
4537 Don't use xrealloc. Improve diagnostics when the %l size modifier
4538 is used. Update the commentary.
4539
4540 * eval.c (verror): Simplify calculation of size_t.
4541
4542 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4543 messages.
4544
f61f41d7
PE
45452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4546
4547 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4548 change.
4549
96fb4434
PE
45502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4553 This makes this file independent of the recent pseudovector change.
4554
671875da 45552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4556
69e9b5a3
PE
4557 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4558
b5f869a7 4559 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4560 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4561 Remove unused local.
c8926152 4562 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4563
841a1577 4564 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4565 GCC 4.6.0 optimizes based on type-based alias analysis.
4566 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4567 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4568 != &v->size, and therefore "v->size = 1; b->size = 2; return
4569 v->size;" must therefore return 1. This assumption is incorrect
4570 for Emacs, since it type-puns struct Lisp_Vector * with many other
4571 types. To fix this problem, this patch adds a new type struct
f904488f 4572 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4573 and pseudovectors, and helps optimizing compilers not get fooled
4574 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4575 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4576 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4577 the size member.
eab3844f
PE
4578 (XSETPVECTYPE): Rewrite in terms of new macro.
4579 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4580 This is a bit clearer, and further avoids the possibility of
4581 undesirable aliasing.
4582 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4583 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4584 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4585 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4586 (ASIZE): Now uses header.size rather than size.
4587 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4588 to avoid the hassle of writing XVECTOR (foo)->header.size.
4589 (struct vectorlike_header): New type.
eab3844f
PE
4590 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4591 object, to help avoid aliasing.
4592 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4593 (SUBRP): Likewise, since Lisp_Subr is a special case.
4594 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4595 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4596 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4597 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4598 changed to be "header.size" and "header.next".
4599 * buffer.h (struct buffer): Likewise.
4600 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4601 * frame.h (struct frame): Likewise.
4602 * process.h (struct Lisp_Process): Likewise.
4603 * termhooks.h (struct terminal): Likewise.
4604 * window.c (struct save_window_data, struct saved_window): Likewise.
4605 * window.h (struct window): Likewise.
4606 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4607 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4608 * buffer.c (init_buffer_once): Likewise.
4609 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4610 special case.
4611 * process.c (Fformat_network_address): Use local var for size,
4612 for brevity.
4613
0df1eac5
PE
4614 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4615
847ab9d1 4616 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4617 * data.c (atof): Remove decl; no longer used or needed.
4618 (digit_to_number): Move to lread.c.
4619 (Fstring_to_number): Use new string_to_number function, to be
4620 consistent with how the Lisp reader treats infinities and NaNs.
4621 Do not assume that floating-point numbers represent EMACS_INT
4622 without losing information; this is not true on most 64-bit hosts.
4623 Avoid double-rounding errors, by insisting on integers when
4624 parsing non-base-10 numbers, as the documentation specifies.
4625 * lisp.h (string_to_number): New decl, replacing ...
4626 (isfloat_string): Remove.
bc0a5c13 4627 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4628 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4629 appears to have been a coding error. Similarly, do not accept
4630 strings like +-1e0 as floating point numbers. Do not report
4631 overflow for integer overflows unless the base is not 10 which
4632 means we have no simple and reliable way to continue.
4633 Break out the floating-point parsing into a new
4634 function string_to_number, so that Fstring_to_number parses
4635 floating point numbers consistently with the Lisp reader.
04f2d78b 4636 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4637 (E_CHAR, EXP_INT): Remove, replacing with ...
4638 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4639 (string_to_number): New function, replacing isfloat_string.
4640 This function checks for valid syntax and produces the resulting
4641 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4642 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4643 so that overflow for non-base-10 numbers is reported only when
4644 there's no portable and simple way to convert to floating point.
452f4150 4645
67769ffc
PE
4646 * textprop.c (set_text_properties_1): Rewrite for clarity,
4647 and to avoid GCC warning about integer overflow.
4648
c20db43f
PE
4649 * intervals.h (struct interval): Use EMACS_INT for members
4650 where EMACS_UINT might cause problems. See
4651 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4652 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4653 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4654 All uses changed.
37aa2f85
PE
4655 (offset_intervals): Tell GCC not to worry about length overflow
4656 when negating a negative length.
c20db43f 4657
2538aa2f
PE
4658 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4659 (overrun_check_free): Likewise.
4660
f2d3008d
PE
4661 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4662 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4663 word size.
4664
ec8df744
PE
4665 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4666 (gnutls_make_error): Rename local to avoid shadowing.
4667 (gnutls_emacs_global_deinit): ifdef out; not used.
4668 (Fgnutls_boot): Use const for pointer to readonly storage.
4669 Comment out unused local. Fix pointer signedness problems.
4670
640ee02d
PE
4671 * lread.c (openp): Don't stuff size_t into an 'int'.
4672 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4673 about possible signed overflow.
4674
6048fb2a
PE
4675 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4676 (GDK_KEY_g): Don't define if already defined.
4677 (xg_prepare_tooltip): Avoid pointer signedness problem.
4678 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4679
fa3c87e1
PE
4680 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4681 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4682
2172544b
PE
4683 * xfns.c (Fx_window_property): Simplify a bit,
4684 to make a bit faster and to avoid GCC 4.6.0 warning.
4685 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4686
9b821a21
PE
4687 * fns.c (internal_equal): Don't assume size_t fits in int.
4688
3c616cfa
PE
4689 * alloc.c (compact_small_strings): Tighten assertion a little.
4690
c2982e87
PE
4691 Replace pEd with more-general pI, and fix some printf arg casts.
4692 * lisp.h (pI): New macro, generalizing old pEd macro to other
4693 conversion specifiers. For example, use "...%"pI"d..." rather
4694 than "...%"pEd"...".
4695 (pEd): Remove. All uses replaced with similar uses of pI.
4696 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4697 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4698 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4699 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4700 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4701 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4702 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4703 64-bit hosts.
4704 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4705 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4706 * print.c (safe_debug_print, print_object): Likewise.
4707 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4708 to int.
6f04d126
PE
4709 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4710 avoiding the 0 flag, which is not portable.
c2982e87
PE
4711 * process.c (Fmake_network_process): Use pI to avoid cast.
4712 * region-cache.c (pp_cache): Likewise.
4713 * xdisp.c (decode_mode_spec): Likewise.
4714 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4715 behavior on 64-bit hosts with printf arg.
6f04d126 4716 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4717 (x_stop_queuing_selection_requests): Likewise.
4718 (x_get_window_property): Don't truncate byte count to an 'int'
4719 when tracing.
0b432f21 4720
5e073ec7
PE
4721 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4722 here, since it parses constructs like leading '-' and spaces,
4723 which are not wanted; and it overflows with large numbers.
4724 Instead, simply match F[0-9]+, which is what is wanted anyway.
4725
36372bf9
PE
4726 * alloc.c: Remove unportable assumptions about struct layout.
4727 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4728 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4729 (allocate_vectorlike, make_pure_vector): Use the new macros,
4730 plus offsetof, to remove unportable assumptions about struct layout.
4731 These assumptions hold on all porting targets that I know of, but
4732 they are not guaranteed, they're easy to remove, and removing them
4733 makes further changes easier.
4734
0b432f21
PE
4735 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4736 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4737 (string_overrun_cookie): Now const. Use initializers that
4738 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4739 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4740 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4741 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4742 multiple of sizeof (EMACS_INT); it need not be, if
4743 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4744 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4745
895009e1
JB
47462011-04-26 Juanma Barranquero <lekktu@gmail.com>
4747
4748 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4749
6a7a1b0b
TZ
47502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4751
4752 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4753 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4754 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4755
841a1577 47562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4757
4758 * lisp.h (Qdebug): List symbol.
895009e1 4759 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4760 * keyboard.c (debug-on-event): New variable.
4761 (handle_user_signal): Break into debugger when debug-on-event
4762 matches the current signal symbol.
4763
f2d3ba6f
DN
47642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4765
4766 * alloc.c (check_sblock, check_string_bytes)
4767 (check_string_free_list): Convert to standard C.
4768
42ce4c63
TZ
47692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4770
4771 * w32.c (emacs_gnutls_push): Fix typo.
4772
825cd63c
EZ
47732011-04-25 Eli Zaretskii <eliz@gnu.org>
4774
fb11d64d
EZ
4775 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4776 "cast to pointer from integer of different size".
4777
825cd63c
EZ
4778 Improve doprnt and its use in verror. (Bug#8545)
4779 * doprnt.c (doprnt): Document the set of format control sequences
4780 supported by the function. Use SAFE_ALLOCA instead of always
4781 using `alloca'.
4782
4783 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4784 is one byte too soon. Don't use xrealloc; instead xfree and
4785 xmalloc anew.
4786
e061a11b
TZ
47872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4788
4789 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4790 callbacks stage.
4791
4792 * gnutls.c: Renamed global_initialized to
4793 gnutls_global_initialized. Added internals for the
4794 :verify-hostname-error, :verify-error, and :verify-flags
4795 parameters of `gnutls-boot' and documented those parameters in the
4796 docstring. Start callback support.
9173deec
JB
4797 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4798 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4799 on error. Return error code.
e061a11b
TZ
4800 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4801 (emacs_gnutls_read): Likewise.
4802 (Fgnutls_boot): Return handshake error code.
4803 (emacs_gnutls_handle_error): New function.
4804 (wsaerror_to_errno): Likewise.
4805
4806 * w32.h (emacs_gnutls_pull): Add prototype.
4807 (emacs_gnutls_push): Likewise.
4808
4809 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4810 (emacs_gnutls_push): Likewise.
4811
48122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4813
4814 * process.c (wait_reading_process_output): Check if GnuTLS
4815 buffered some data internally if no FDs are set for TLS
4816 connections.
4817
4818 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4819 (LIBS): Link to USER_LIBS.
4820 ($(BLD)/gnutls.$(0)): New target.
4821
fa6996bc
EZ
48222011-04-24 Eli Zaretskii <eliz@gnu.org>
4823
eb35682e
EZ
4824 * xdisp.c (handle_single_display_spec): Rename the
4825 display_replaced_before_p argument into display_replaced_p, to
4826 make it consistent with the commentary. Fix typos in the
4827 commentary.
4828
e2ad650c
EZ
4829 * textprop.c (syms_of_textprop): Remove dead code.
4830 (copy_text_properties): Delete obsolete commentary about an
4831 interface that was deleted long ago. Fix typos in the description
4832 of arguments.
4833
1b2de274
EZ
4834 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4835 to changes in oldXMenu/XMenu.h from 2011-04-16.
4836 <menu_help_message, prev_menu_help_message>: Constify.
4837 (IT_menu_make_room): menu->help_text is now `const char **';
4838 adjust.
4839
4840 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4841 to changes in oldXMenu/XMenu.h from 2011-04-16.
4842 (struct XMenu): Declare `help_text' `const char **'.
4843
4844 * xfaces.c <Qunspecified>: Make extern again.
4845
4846 * syntax.c: Include sys/types.h before including regex.h, as
4847 required by Posix.
4848
762b15be
EZ
4849 * doc.c (get_doc_string): Improve the format passed to `error'.
4850
4851 * doprnt.c (doprnt): Improve commentary.
4852
4853 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4854
4855 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4856 them with etags.
4857
f1052e5d
EZ
4858 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4859 changes in globals.h immediately force recompilation.
762b15be
EZ
4860 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4861 $(CURDIR)/s/ms-w32.h.
4862 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4863
fa6996bc
EZ
4864 * character.c (Fchar_direction): Function deleted.
4865 (syms_of_character): Don't defsubr it.
4866 <char-direction-table>: Deleted.
4867
e6c3da20
EZ
48682011-04-23 Eli Zaretskii <eliz@gnu.org>
4869
4870 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4871 * doprnt.c: Include limits.h.
4872 (SIZE_MAX): New macro.
04f2d78b
CB
4873 (doprnt): Return a size_t value. 2nd arg is now size_t.
4874 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4875 Improve overflow protection. Support `l' modifier for integer
4876 conversions. Support %l conversion. Don't assume an EMACS_INT
4877 argument for integer conversions and for %c.
4878
4879 * lisp.h (doprnt): Restore prototype.
4880
4881 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4882 $(SRC)/character.h.
4883
4884 * Makefile.in (base_obj): Add back doprnt.o.
4885
4886 * deps.mk (doprnt.o): Add back prerequisites.
4887 (callint.o): Depend on character.h.
4888
4889 * eval.c (internal_lisp_condition_case): Include the handler
4890 representation in the error message.
4891 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4892 when breaking from the loop.
4893
4894 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4895
4896 * callint.c (Fcall_interactively): When displaying error message
4897 about invalid control letter, pass the character's codepoint, not
4898 a pointer to its multibyte form. Improve display of the character
4899 in octal and display also its hex code.
4900
4901 * character.c (char_string): Use %x to display the (unsigned)
4902 codepoint of an invalid character, to avoid displaying a bogus
4903 negative value.
4904
4905 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4906 `error', not SYMBOL_NAME itself.
4907
4908 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4909 character arguments to `error'.
4910
4911 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4912 to `error' in error message about FINAL_CHAR argument. Make sure
4913 FINAL_CHAR is a character, and use %c when it is passed as
4914 argument to `error'.
4915
4ffd0d6b 49162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4917
4918 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4919
4920 * w32.c: Include <time.h>.
4921 (sys_localtime): New function.
4922
4ffd0d6b 49232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4924
4925 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4926
4ffd0d6b 4927 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4928
4ffd0d6b 49292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4930
4ffd0d6b
GM
4931 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4932 zombies (Bug#8467).
aac0c6e3 4933
04c56954
EZ
49342011-04-19 Eli Zaretskii <eliz@gnu.org>
4935
4936 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4937 gl_state.e_property when gl_state.object is Qt.
4938
4939 * insdel.c (make_gap_larger): Remove limitation of buffer size
4940 to <= INT_MAX.
4941
16a43933
CY
49422011-04-18 Chong Yidong <cyd@stupidchicken.com>
4943
4944 * xdisp.c (lookup_glyphless_char_display)
4945 (produce_glyphless_glyph): Handle cons cell entry in
4946 glyphless-char-display.
4947 (Vglyphless_char_display): Document it.
4948
4949 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4950 glyphless-char-display.
4951
4581706e
CY
49522011-04-17 Chong Yidong <cyd@stupidchicken.com>
4953
4954 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4955
4956 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4957
4958 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4959 definition for no-X builds.
4960
4887c6e2 49612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4962
fd35b6f9
PE
4963 Static checks with GCC 4.6.0 and non-default toolkits.
4964
5c1ccb01
PE
4965 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4966
006c5daa
PE
4967 * process.c (keyboard_bit_set): Define only if SIGIO.
4968 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4969 (send_process): Repair possible setjmp clobbering.
4970
efc736d3
PE
4971 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4972
4e2fe2e6
PE
4973 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4974
f97334a2
PE
4975 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4976
4e75f29d
PE
4977 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4978 Define only if needed.
4979
90efadd1
PE
4980 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4981 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4982 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4983
3c647824
PE
4984 * dispextern.h (struct redisplay_interface): Rename param
4985 to avoid shadowing.
e264f262 4986 * termhooks.h (struct terminal): Likewise.
761383f4 4987 * xterm.c (xembed_send_message): Likewise.
3c647824 4988
b58c5c4a
PE
4989 * insdel.c (make_gap_smaller): Define only if
4990 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4991
cad59032
PE
4992 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4993 it.
4994
c339dc2e
PE
4995 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4996 so that we aren't warned about unused symbols.
4997
91a3e27b
PE
4998 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4999
399c71d3 5000 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5001
8ffc96f5
PE
5002 * xfns.c (x_real_positions): Mark locals as initialized.
5003
eef9bc79
PE
5004 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5005
098db9dd
PE
5006 * xterm.c: Fix problems found by static analysis with other toolkits.
5007 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5008 (x_dispatch_event): Declare static if USE_GTK, and
5009 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5010 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5011 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5012 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5013 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5014
eb18f6cc
PE
5015 * xmenu.c (menu_help_callback): Pointer type fixes.
5016 Use const pointers when pointing at readonly data. Avoid pointer
5017 signedness clashes.
5018 (FALSE): Remove unused macro.
5019 (update_frame_menubar): Remove unused decl.
5020
1fe72bf8
PE
5021 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5022
60d9e1db
PE
5023 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5024 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5025 (single_menu_item): Rename local to avoid shadowing.
5026
39261c26
PE
5027 * keyboard.c (make_lispy_event): Remove unused local var.
5028
018c5e19
PE
5029 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5030 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5031
63d2b86e
PE
5032 * bitmaps: Change bitmaps from unsigned char back to the X11
5033 compatible char. Avoid the old compiler warnings about
5034 out-of-range initializers by using, for example, '\xab' rather
5035 than 0xab.
5036
aefd87e1
PE
5037 * xgselect.c (xgselect_initialize): Check vs interface
5038 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5039
bf501fb9
PE
5040 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5041
e9829fdf
PE
5042 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5043 to read-only memory.
5044
1086c095
PE
5045 * fns.c (vector): Remove; this old hack is no longer needed.
5046
2baccd04 5047 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5048 Remove unused var.
dde42981 5049 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5050
72391843 5051 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5052
436c16df 5053 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5054 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5055 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5056
92bb796d 5057 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5058 (x_term_init): Remove local to avoid shadowing.
92bb796d 5059
764430a3 5060 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5061
5062 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5063 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5064
d1dfb56c
EZ
50652011-04-16 Eli Zaretskii <eliz@gnu.org>
5066
c4354cb4
EZ
5067 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5068
d1dfb56c
EZ
5069 Fix regex.c, syntax.c and friends for buffers > 2GB.
5070 * syntax.h (struct gl_state_s): Declare character position members
5071 EMACS_INT.
5072
5073 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5074
04f2d78b
CB
5075 * textprop.c (verify_interval_modification, interval_of):
5076 Declare arguments EMACS_INT.
d1dfb56c
EZ
5077
5078 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5079 EMACS_INT.
5080
5081 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5082
5083 * indent.c (Fvertical_motion): Local variable it_start is now
5084 EMACS_INT.
5085
5086 * regex.c (re_match, re_match_2, re_match_2_internal)
5087 (bcmp_translate, regcomp, regexec, print_double_string)
5088 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5089 (re_compile_pattern, re_exec): Declare arguments and local
5090 variables `size_t' and `ssize_t' and return values `regoff_t', as
5091 appropriate.
5092 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5093 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5094 <compile_stack_type>: `size' and `avail' are now `size_t'.
5095
5096 * regex.h <regoff_t>: Use ssize_t, not int.
5097 (re_search, re_search_2, re_match, re_match_2): Arguments that
5098 specify buffer/string position and length are now ssize_t and
5099 size_t. Return type is regoff_t.
5100
613052cd
BK
51012011-04-16 Ben Key <bkey76@gmail.com>
5102
5103 * nsfont.m: Fixed bugs in ns_get_family and
5104 ns_descriptor_to_entity that were caused by using free to
5105 deallocate memory blocks that were allocated by xmalloc (via
5106 xstrdup). This caused Emacs to crash when compiled with
5107 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5108 --enable-checking=xmallocoverrun). xfree is now used to
5109 deallocate these memory blocks.
5110
4170f62f 51112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5112
71b41406
PE
5113 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5114
9587a89d
PE
5115 emacs_write: Accept and return EMACS_INT for sizes.
5116 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5117 et seq.
5118 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5119 Accept and return EMACS_INT.
5120 (emacs_gnutls_write): Return the number of bytes written on
5121 partial writes.
5122 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5123 (emacs_read, emacs_write): Remove check for negative size, as the
5124 Emacs source code has been audited now.
9587a89d
PE
5125 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5126 (emacs_read, emacs_write): Use it.
273a5f82
PE
5127 * process.c (send_process): Adjust to the new signatures of
5128 emacs_write and emacs_gnutls_write. Do not attempt to store
5129 a byte offset into an 'int'; it might overflow.
9587a89d 5130 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5131
3e047f51
PE
5132 * sound.c: Don't assume sizes fit in 'int'.
5133 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5134 Return EMACS_INT, not int.
3e047f51 5135 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5136 Accept EMACS_INT, not int.
5137 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5138 record read return values.
5139
cc39a9db
BK
51402011-04-15 Ben Key <bkey76@gmail.com>
5141
c9d0ec6d
JB
5142 * keyboard.c (Qundefined): Don't declare static since it is used
5143 in nsfns.m.
5144 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5145 static since they are used in nsfont.m.
cc39a9db 5146
6c60eb9f
SM
51472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5148
5149 * process.c (Qprocessp): Don't declare static.
5150 * lisp.h (Qprocessp): Declare again.
5151
7990b61a
JB
51522011-04-15 Juanma Barranquero <lekktu@gmail.com>
5153
5154 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5155
5d4cb038
PE
51562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5157
8bd7b830 5158 Improve C-level modularity by making more things 'static'.
cd64ea1d 5159
e3b27b31
PE
5160 Don't publish debugger-only interfaces to other modules.
5161 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5162 (verify_bytepos, count_markers): Move decls to the only modules
5163 that need them.
5164 * region-cache.h (pp_cache): Likewise.
5165 * window.h (check_all_windows): Likewise.
5166 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5167
5d4cb038
PE
5168 * sysdep.c (croak): Now static, if
5169 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5170 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5171
5172 * alloc.c (refill_memory_reserve): Now static if
5173 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5174 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5175
e87b6180
PE
5176 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5177 Define only if USE_LUCID.
5178
ac64929e
PE
5179 * xrdb.c (x_customization_string, x_rm_string): Now static.
5180
6f37259d
PE
5181 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5182 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5183
1683e3ab
PE
5184 * xdisp.c (draw_row_with_mouse_face): Now static.
5185 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5186
de9c2632
PE
5187 * window.h (check_all_windows): Mark externally visible.
5188
2b96acb7
PE
5189 * window.c (window_deletion_count): Now static.
5190
5191 * undo.c: Make symbols static if they're not exported.
5192 (last_undo_buffer, last_boundary_position, pending_boundary):
5193 Now static.
5194
50436f33
PE
5195 * textprop.c (interval_insert_behind_hooks): Now static.
5196 (interval_insert_in_front_hooks): Likewise.
5197
64520e5c
PE
5198 * term.c: Make symbols static if they're not exported.
5199 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5200 (max_frame_lines, tty_set_terminal_modes):
5201 (tty_reset_terminal_modes, tty_turn_off_highlight):
5202 (get_tty_terminal): Now static.
5203 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5204 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5205 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5206 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5207 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5208
1fa53021
PE
5209 * sysdep.c: Make symbols static if they're not exported.
5210 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5211 Now static.
5212 (sigprocmask_set, full_mask): Remove; unused.
5213 (wait_debugging): Mark as visible.
5214 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5215 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5216
d4b43b22
PE
5217 * syntax.c (syntax_temp): Define only if !__GNUC__.
5218
b7c513d0
PE
5219 * sound.c (current_sound_device, current_sound): Now static.
5220
989b29ad
PE
5221 * search.c (searchbufs, searchbuf_head): Now static.
5222
13a55a78
PE
5223 * scroll.c (scroll_cost): Remove; unused.
5224 * dispextern.h (scroll_cost): Remove decl.
5225
de68a1fc
PE
5226 * region-cache.h (pp_cache): Mark as externally visible.
5227
40ccffa6
PE
5228 * process.c: Make symbols static if they're not exported.
5229 (process_tick, update_tick, create_process, chan_process):
5230 (Vprocess_alist, proc_buffered_char, datagram_access):
5231 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5232 (deactivate_process): Mark defn as static, as well as decl.
5233 * lisp.h (create_process): Remove decl.
5234 * process.h (chan_process, Vprocess_alist): Remove decls.
5235
ad64fc97
PE
5236 * print.c: Make symbols static if they're not exported.
5237 (print_depth, new_backquote_output, being_printed, print_buffer):
5238 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5239 (print_interval, print_number_index, initial_stderr_stream):
5240 Now static.
5241 * lisp.h (Fprinc): Remove decl.
5242 (debug_output_compilation_hack): Mark as externally visible.
5243
adddb265
PE
5244 * sysdep.c (croak): Move decl from here to syssignal.h.
5245 * syssignal.h (croak): Put it here, so the API can be checked when
5246 'croak' is called from dissociate_if_controlling_tty.
5247
1717ede2
PE
5248 * minibuf.c: Make symbols static if they're not exported.
5249 (minibuf_save_list, choose_minibuf_frame): Now static.
5250 * lisp.h (choose_minibuf_frame): Remove decl.
5251
fa5fb2bc
PE
5252 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5253
1e3890d1
PE
5254 * lread.c: Make symbols static if they're not exported.
5255 (read_objects, initial_obarray, oblookup_last_bucket_number):
5256 Now static.
5257 (make_symbol): Remove; unused.
5258 * lisp.h (initial_obarray, make_symbol): Remove decls.
5259
8a1414fa
PE
5260 * keyboard.c: Make symbols static if they're not exported.
5261 (single_kboard, recent_keys_index, total_keys, recent_keys):
5262 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5263 (this_single_command_key_start, echoing, last_auto_save):
5264 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5265 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5266 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5267 (Vlispy_mouse_stem, double_click_count):
5268 Now static.
5269 (force_auto_save_soon): Define only if SIGDANGER.
5270 (ignore_mouse_drag_p): Now static if
5271 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5272 (print_help): Remove; unused.
5273 (stop_character, last_timer_event): Mark as externally visible.
5274 * keyboard.h (ignore_mouse_drag_p): Declare only if
5275 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5276 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5277 * lisp.h (echoing): Remove decl.
5278 (force_auto_save_soon): Declare only if SIGDANGER.
5279 * xdisp.c (redisplay_window): Simplify code, to make it more
5280 obvious that ignore_mouse_drag_p is not accessed if !defined
5281 USE_GTK && !defined HAVE_NS.
5282
93ea6e8f
PE
5283 * intervals.c: Make symbols static if they're not exported.
5284 (merge_properties_sticky, merge_interval_right, delete_interval):
5285 Now static.
5286 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5287
77382fcc
PE
5288 * insdel.c: Make symbols static if they're not exported.
5289 However, leave prepare_to_modify_buffer alone. It's never
5290 called from outside this function, but that appears to be a bug.
5291 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5292 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5293 (adjust_after_replace_noundo): Remove; unused.
5294 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5295 (signal_before_change): Remove decls.
77382fcc 5296
9306c32e
PE
5297 * indent.c (val_compute_motion, val_vmotion): Now static.
5298
cd44d2eb
PE
5299 * image.c: Make symbols static if they're not exported.
5300 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5301 if USE_GTK.
5302 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5303 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5304
ad9a7a06
PE
5305 * fringe.c (standard_bitmaps): Now static.
5306 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5307
81626931
PE
5308 * frame.c: Make symbols static if they're not exported.
5309 (x_report_frame_params, make_terminal_frame): Now static.
5310 (get_frame_param): Now static, unless HAVE_NS.
5311 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5312 (x_get_resource_string): Remove; not used.
5313 * frame.h (make_terminal_frame, x_report_frame_params):
5314 (x_get_resource_string); Remove decls.
5315 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5316 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5317
239f9db9
PE
5318 * font.c, fontset.c: Make symbols static if they're not exported.
5319 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5320 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5321 * font.c (font_close_object): Now static.
5322 * font.h (font_close_object): Remove.
5323 * fontset.c (FONTSET_OBJLIST): Remove.
5324 (free_realized_fontset) #if-0 the body, which does nothing.
5325 (face_suitable_for_char_p): #if-0, as it's never called.
5326 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5327 * xfaces.c (face_at_string_position):
5328 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5329 since 0 is always ASCII.
5330
dfcf3579
PE
5331 * fns.c (weak_hash_tables): Now static.
5332
5045092b
PE
5333 * fileio.c: Make symbols static if they're not exported.
5334 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5335 (Vwrite_region_annotation_buffers): Now static.
5336
57a96f5c
PE
5337 * eval.c: Make symbols static if they're not exported.
5338 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5339 * lisp.h (backtrace_list): Remove decl.
5340
35f08c38
PE
5341 * emacs.c: Make symbols static if they're not exported.
5342 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5343 (fatal_error_code, fatal_error_signal_hook, standard_args):
5344 Now static.
5345 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5346 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5347 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5348 * lisp.h (fatal_error_signal_hook): Remove decl.
5349 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5350
f44bd759
PE
5351 * editfns.c: Move a (normally-unused) function to its only use.
5352 * editfns.c, lisp.h (get_operating_system_release): Remove.
5353 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5354 worth the hassle of breaking this out.
5355
b532497d
PE
5356 * xterm.c: Make symbols static if they're not exported.
5357 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5358 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5359 (x_destroy_window, x_delete_display):
5360 Now static.
5361 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5362 (x_mouse_leave): Remove; unused.
5363 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5364 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5365 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5366 Remove decls.
5367 (x_mouse_leave): Declare only if WINDOWSNT.
5368 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5369 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5370 USE_X_TOOLKIT.
5371
1675728f
PE
5372 * ftxfont.c: Make symbols static if they're not exported.
5373 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5374 HAVE_FREETYPE.
5375 * font.h (ftxfont_driver): Likewise.
5376
e4cebfca
PE
5377 * xfns.c: Make symbols static if they're not exported.
5378 (x_last_font_name, x_display_info_for_name):
5379 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5380 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5381 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5382 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5383 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5384 (last_show_tip_args): Now static.
5385 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5386 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5387 (x_screen_planes): Remove; unused.
5388 * dispextern.h (x_screen_planes): Remove decl.
5389
5bf46f05
PE
5390 * dispnew.c: Make symbols static if they're not exported.
5391 * dispextern.h (redraw_garbaged_frames, scrolling):
5392 (increment_row_positions): Remove.
5393 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5394 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5395 Now static.
5396 (redraw_garbaged_frames): Remove; unused.
5397
435f4c28
PE
5398 * xfaces.c: Make symbols static if they're not exported.
5399 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5400 Remove decls.
5401 * xterm.h (defined_color): Remove decls.
5402 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5403 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5404 (menu_face_changed_default, defined_color, free_realized_face):
5405 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5406 (ascii_face_of_lisp_face): Remove; unused.
5407
8524aef3
PE
5408 * xdisp.c: Make symbols static if they're not exported.
5409 * dispextern.h (scratch_glyph_row, window_box_edges):
5410 (glyph_to_pixel_coords, set_cursor_from_row):
5411 (get_next_display_element, set_iterator_to_next):
5412 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5413 (show_mouse_face): Remove decls
5414 * frame.h (message_buf_print): Likewise.
5415 * lisp.h (pop_message, set_message, check_point_in_composition):
5416 Likewise.
5417 * xterm.h (set_vertical_scroll_bar): Likewise.
5418 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5419 (message_buf_print, scratch_glyph_row, displayed_buffer):
5420 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5421 (get_next_display_element, show_mouse_face, window_box_edges):
5422 (frame_to_window_pixel_xy, check_point_in_composition):
5423 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5424 (glyph_to_pixel_coords): Remove; unused.
5425
16390cd2
PE
5426 * dired.c (file_name_completion): Now static.
5427
5428 * dbusbind.c (xd_in_read_queued_messages): Now static.
5429
a25f4dfa
PE
5430 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5431 * data.c (circular_list_error): Remove.
5432
14a9c8df
PE
5433 * commands.h (last_point_position, last_point_position_buffer):
5434 (last_point_position_window): Remove decls.
5435 * keyboard.c: Make these variables static.
5436
04f2d78b
CB
5437 * coding.h (coding, code_convert_region, encode_coding_gap):
5438 Remove decls.
74ab6df5
PE
5439 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5440 (iso_code_class, detect_coding, code_convert_region): Now static.
5441 (encode_coding_gap): Remove; unused.
5442
38dfbee1
PE
5443 * chartab.c (chartab_chars, chartab_bits): Now static.
5444
a2cb4e63
PE
5445 * charset.h (charset_iso_8859_1): Remove decl.
5446 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5447 Now static.
5448
127198fd
PE
5449 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5450 * ccl.c (Vccl_program_table): Now static.
5451 (check_ccl_update): Remove; unused.
5452
d85b608f
PE
5453 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5454 * category.h: ... from here.
5455 * category.c (check_category_table, set_category_set): Now static.
5456
31cd66f3
PE
5457 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5458 * lisp.h: Remove these decls.
5459
c358e587
PE
5460 * buffer.c (buffer_count): Remove unused var.
5461
e78aecca
PE
5462 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5463 so that it's not optimized away.
5464 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5465 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5466 exported only to the debugger.
5467
e192d7d3 5468 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5469 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5470
92470028
PE
5471 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5472 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5473 was inaccessible from Lisp.
5474 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5475 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5476
244ed907
PE
5477 alloc.c: Import and export fewer symbols, and remove unused items.
5478 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5479 is defined.
5480 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5481 it's not optimized away by whole-program optimization.
5482 (message_enable_multibyte, free_misc): Remove.
5483 (catchlist, handlerlist, mark_backtrace):
5484 Declare only if BYTE_MARK_STACK.
5485 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5486 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5487 (message_enable_multibyte): Remove decl.
5488 (free_misc, interval_free_list, float_block, float_block_index):
5489 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5490 (cons_free_list, last_marked_index):
5491 Now static.
5492 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5493 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5494 (mark_backtrace): Define only if BYTE_MARK_STACK.
5495 * xdisp.c (message_enable_multibyte): Now static.
5496
61c2b50e 5497 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5498 This makes it easier for human readers (and static analyzers)
5499 to see whether these variables are used from other modules.
5500 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5501 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5502 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5503 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5504 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5505 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5506 * xmenu.c, xselect.c:
5507 Declare Q* vars static if they are not used in other modules.
5508 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5509 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5510 Remove decls of unexported vars.
5511 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5512
95c82688
PE
5513 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5514
16a97296
PE
5515 Make Emacs functions such as Fatom 'static' by default.
5516 This makes it easier for human readers (and static analyzers)
5517 to see whether these functions can be called from other modules.
5518 DEFUN now defines a static function. To make the function external
5519 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5520 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5521 (Finit_image_library):
16a97296
PE
5522 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5523 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5524 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5525 Remove decls, since these functions are now static.
5526 (Funintern, Fget_internal_run_time): New decls, since these functions
5527 were already external.
95c82688 5528
16a97296
PE
5529 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5530 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5531 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5532 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5533 * keyboard.c, keymap.c, lread.c:
5534 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5535 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5536 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5537 Mark functions with DEFUE instead of DEFUN,
5538 if they are used in other modules.
5539 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5540 decls for now-static functions.
5541 * buffer.h (Fdelete_overlay): Remove decl.
5542 * callproc.c (Fgetenv_internal): Mark as internal.
5543 * composite.c (Fremove_list_of_text_properties): Remove decl.
5544 (Fcomposition_get_gstring): New forward static decl.
5545 * composite.h (Fcomposite_get_gstring): Remove decl.
5546 * dired.c (Ffile_attributes): New forward static decl.
5547 * doc.c (Fdocumntation_property): New forward static decl.
5548 * eval.c (Ffetch_bytecode): New forward static decl.
5549 (Funintern): Remove extern decl; now in .h file where it belongs.
5550 * fileio.c (Fmake_symbolic_link): New forward static decl.
5551 * image.c (Finit_image_library): New forward static decl.
5552 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5553 * intervals.h (Fprevious_property_change):
5554 (Fremove_list_of_text_properties): Remove decls.
5555 * keyboard.c (Fthis_command_keys): Remove decl.
5556 (Fcommand_execute): New forward static decl.
5557 * keymap.c (Flookup_key): New forward static decl.
5558 (Fcopy_keymap): Now static.
5559 * keymap.h (Flookup_key): Remove decl.
5560 * process.c (Fget_process): New forward static decl.
5561 (Fprocess_datagram_address): Mark as internal.
5562 * syntax.c (Fsyntax_table_p): New forward static decl.
5563 (skip_chars): Remove duplicate decl.
5564 * textprop.c (Fprevious_property_change): New forward static decl.
5565 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5566 Now internal.
5567 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5568 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5569
785bbd42
PE
5570 * editfns.c (Fformat): Remove unreachable code.
5571
8b913b57
AS
55722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5573
5574 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5575 change. (Bug#8496)
5576
a6744a35
EZ
55772011-04-13 Eli Zaretskii <eliz@gnu.org>
5578
5579 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5580 when at ZV. (Bug#8487)
5581
e7974947
AS
55822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5583
baad03f0
AS
5584 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5585 (Bug#8437)
5586 * keyboard.c (parse_tool_bar_item): Likewise.
5587 * sound.c (sound_cleanup, alsa_close): Likewise.
5588 * termcap.c (tgetent): Likewise.
5589 * xfns.c (x_default_font_parameter): Likewise.
5590 * xsettings.c (read_and_apply_settings): Likewise.
5591
e7974947
AS
5592 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5593 (overrun_check_free): Protoize.
5594
28272684
PE
55952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5596
5597 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5598 since callers should never pass a negative size.
5599 Change the signature to match that of plain 'read' and 'write'; see
5600 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5601 * lisp.h: Update prototypes of emacs_write and emacs_read.
5602
11997c76
EZ
56032011-04-11 Eli Zaretskii <eliz@gnu.org>
5604
5605 * xdisp.c (redisplay_window): Don't try to determine the character
5606 position of the scroll margin if the window start point w->startp
e896f03c 5607 is outside the buffer's accessible region. (Bug#8468)
11997c76 5608
8a2cbd72
EZ
56092011-04-10 Eli Zaretskii <eliz@gnu.org>
5610
5611 Fix write-region and its subroutines for buffers > 2GB.
5612 * fileio.c (a_write, e_write): Modify declaration of arguments and
5613 local variables to support buffers larger than 2GB.
5614 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5615
5616 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5617 argument, local variables, and return value.
5618
5619 * lisp.h: Update prototypes of emacs_write and emacs_read.
5620
5621 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5622
4073e537 56232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5624
1ebfdcb6
PE
5625 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5626
b2ded58d
PE
5627 Fix more problems found by GCC 4.6.0's static checks.
5628
7d66342c
PE
5629 * xdisp.c (vmessage): Use a better test for character truncation.
5630
bbf47d44
PE
5631 * charset.c (load_charset_map): <, not <=, for optimization,
5632 and to avoid potential problems with integer overflow.
9248994d 5633 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5634 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5635 * editfns.c (Fformat): Likewise.
1e69125e 5636 * syntax.c (skip_chars): Likewise.
3befa583 5637
e3019616
PE
5638 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5639 This also lets GCC 4.6.0 generate slightly better loop code.
5640
becfa255
PE
5641 * callint.c (Fcall_interactively): <, not <=, for optimization.
5642 (Fcall_interactively): Count the number of arguments produced,
5643 not the number of arguments given. This is simpler and lets GCC
5644 4.6.0 generate slightly better code.
5645
dae0cd48
PE
5646 * ftfont.c: Distingish more carefully between FcChar8 and char.
5647 The previous code passed unsigned char * to a functions like
5648 strlen and xstrcasecmp that expect char *, which does not
5649 conform to the C standard.
5650 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5651 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5652 char * when the C standard requires it.
5653
76032d70
PE
5654 * keyboard.c (read_char): Remove unused var.
5655
eb3f1cc8
PE
5656 * eval.c: Port to Windows vsnprintf (Bug#8435).
5657 Include <limits.h>.
5658 (SIZE_MAX): Define if the headers do not.
5659 (verror): Do not give up if vsnprintf returns a negative count.
5660 Instead, grow the buffer. This ports to Windows vsnprintf, which
5661 does not conform to C99. Problem reported by Eli Zaretskii.
5662 Also, simplify the allocation scheme, by avoiding the need for
5663 calling realloc, and removing the ALLOCATED variable.
5664
70476b54
PE
5665 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5666
12020a9e
PE
5667 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5668 But keep the doprint source code for now, as we might revamp it
5669 and use it again (Bug#8435).
ea6c7ae6
PE
5670 * lisp.h (doprnt): Remove.
5671 * Makefile.in (base_obj): Remove doprnt.o.
5672 * deps.mk (doprnt.o): Remove.
5673
5fdb398c
PE
5674 error: Print 32- and 64-bit integers portably (Bug#8435).
5675 Without this change, on typical 64-bit hosts error ("...%d...", N)
5676 was used to print both 32- and 64-bit integers N, which relied on
5677 undefined behavior.
5678 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5679 New macro.
5680 * lisp.h (error, verror): Mark as printf-like functions.
5681 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5682 Report overflow in size calculations when allocating printf buffer.
5683 Do not truncate output string at its first null byte.
5684 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5685 Truncate the output at a character boundary, since vsnprintf does not
5686 do that.
5687 * charset.c (check_iso_charset_parameter): Convert internal
5688 character to string before calling 'error', since %c now has the
5689 printf meaning.
5690 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5691 overflow when computing char to be passed to 'error'. Do not
5692 pass Lisp_Object to 'error'; pass the integer instead.
5693 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5694 formatted with plain %d.
5695
b189fa66
PE
5696 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5697
bff87ef0
PE
5698 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5699
7e2cac20
PE
5700 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5701
ce4d90b5
PE
5702 * xterm.c (x_catch_errors): Remove duplicate declaration.
5703
266c9547
PE
5704 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5705
79c49ad2
PE
5706 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5707
368f4090
JM
57082011-04-10 Jim Meyering <meyering@redhat.com>
5709
5710 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5711 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5712 return ssize_t not "int", and use size_t as the buffer length.
5713 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5714 * gnutls.h: Update declarations.
5715 * process.c (read_process_output): Use ssize_t, to match.
5716 (send_process): Likewise.
5717
a32d4040
CY
57182011-04-09 Chong Yidong <cyd@stupidchicken.com>
5719
5720 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5721
8546720e 57222011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5723
04f2d78b
CB
5724 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5725 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5726
8546720e
GM
5727 * xterm.c (handle_one_xevent):
5728 * xmenu.c (create_and_show_popup_menu):
5729 * xselect.c (x_decline_selection_request)
5730 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5731
0a2f5c1a 57322011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5733
5734 Fix some uses of `int' instead of EMACS_INT.
5735 * search.c (string_match_1, fast_string_match)
5736 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5737 (scan_buffer, find_next_newline_no_quit)
5738 (find_before_next_newline, search_command, Freplace_match)
5739 (Fmatch_data): Make some `int' variables be EMACS_INT.
5740
5741 * xdisp.c (display_count_lines): 3rd argument and return value now
5742 EMACS_INT. All callers changed.
5743 (pint2hrstr): Last argument is now EMACS_INT.
5744
5745 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5746 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5747 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5748 (decode_coding_utf_16, decode_coding_emacs_mule)
5749 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5750 (decode_coding_ccl, decode_coding_charset)
5751 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5752 (decode_coding_iso_2022, decode_coding_emacs_mule)
5753 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5754 <char_offset, last_offset>: Declare EMACS_INT.
5755 (encode_coding_utf_8, encode_coding_utf_16)
5756 (encode_coding_emacs_mule, encode_invocation_designation)
5757 (encode_designation_at_bol, encode_coding_iso_2022)
5758 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5759 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5760 Declare EMACS_INT.
5761 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5762 (encode_invocation_designation): Last argument P_NCHARS is now
5763 EMACS_INT.
5764 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5765 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5766
5767 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5768 All users changed.
5769
5770 * ccl.c (Fccl_execute_on_string): Declare some variables
5771 EMACS_INT.
5772
8546720e 57732011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5774
5775 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5776
4e19a977
CS
57772011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5778
5779 * process.c (Fformat_network_address): Doc fix.
5780
87302331
R
57812011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5782
5783 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5784
cbb59342
CY
57852011-04-08 Chong Yidong <cyd@stupidchicken.com>
5786
5787 * keyboard.c (read_char): Call Lisp function help-form-show,
5788 instead of using internal_with_output_to_temp_buffer.
5789 (Qhelp_form_show): New var.
e0d38eeb 5790 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5791
5792 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5793
5794 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5795
e67a13ab
CY
57962011-04-06 Chong Yidong <cyd@stupidchicken.com>
5797
04f2d78b
CB
5798 * process.c (Flist_processes): Remove to Lisp.
5799 (list_processes_1): Delete.
e67a13ab 5800
973f782d
EZ
58012011-04-06 Eli Zaretskii <eliz@gnu.org>
5802
7c106b1e
EZ
5803 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5804
973f782d
EZ
5805 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5806
41cf7d1a 58072011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5808
ca23cc88
PE
5809 Fix more problems found by GCC 4.6.0's static checks.
5810
f390e2d5
PE
5811 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5812
42eea0d0
PE
5813 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5814
b69769da 5815 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5816
f9541e84
PE
5817 * xdisp.c (vmessage): Mark as a printf-like function.
5818
13841b55
PE
5819 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5820
c136c10f
PE
5821 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5822
5e2d4a30
PE
5823 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5824 printf-like functions.
5825 (tiff_load): Add casts to remove these marks before passing them
5826 to system-supplied API.
5827
583f48b9
PE
5828 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5829
b25d760e
PE
5830 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5831 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5832 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5833 directly, rather than having caller test rule sign. This avoids
5834 some unnecessary tests.
5835 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5836 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5837 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5838
bc7b6697 5839 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5840 (xfont_open): Avoid unnecessary tests.
bc7b6697 5841
27ccc379
PE
5842 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5843
dcd5c89a
PE
5844 * composite.h, composite.c (composition_gstring_put_cache):
5845 Use EMACS_INT, not int, for length.
5846
b13a45c6
PE
5847 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5848 breaking out part of COMPOSITION_DECODE_RULE.
5849 (COMPOSITION_DECODE_RULE): Use it.
5850 * composite.c (get_composition_id): Remove unused local vars,
5851 by using the new macro.
5852
1e792e4d
PE
5853 * textprop.c (set_text_properties_1): Change while to do-while,
5854 since the condition is always true at first.
5855
dc6c6455 5856 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5857 (interval_deletion_adjustment): Return unsigned value.
5858 All uses changed.
dc6c6455 5859
aba7731a
PE
5860 * process.c (list_processes_1, create_pty, read_process_output):
5861 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5862 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5863 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5864 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5865 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5866
fdfc4bf3
PE
5867 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5868
fca8fe46 5869 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5870 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5871
06a0259a 5872 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5873 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5874 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5875
e7b9e80f
PE
5876 * print.c (print_error_message): Avoid int overflow.
5877
56201685
PE
5878 * font.c (font_list_entities): Redo for clarity,
5879 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5880
78834453 5881 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5882 (font_score): Avoid potential overflow in diff calculation.
78834453 5883
0bc0b309 5884 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5885 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5886
e610eaca
PE
5887 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5888
b895abce
PE
5889 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5890 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5891 can always succeed if overflow has undefined behavior.
5892
1f1d9321 5893 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5894 (wordify): Omit three unnecessary tests.
1f1d9321 5895
c59478bc
PE
5896 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5897 All callers changed. This avoids the need for an unused var.
5898
79b73827
PE
5899 * casefiddle.c (casify_region): Remove var that is set but not used.
5900
a4db5dfe
PE
5901 * dired.c (file_name_completion): Remove var that is set but not used.
5902
43aae36e
PE
5903 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5904
2a47c44d 5905 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5906 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5907
a37c69bf
PE
5908 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5909 Check for integer overflow on size calculations.
5910
328ab8e7
PE
5911 * buffer.c (Fprevious_overlay_change): Remove var that is set
5912 but not used.
5913
e5a2a5cb
PE
5914 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5915 Remove vars that are set but not used.
8d84a6eb 5916 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5917 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5918
a60e5f68
PE
5919 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5920
f661cb61 5921 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5922 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5923
f0397f5a
PE
5924 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5925 that are set but not used.
5926
8664db06 5927 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5928 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5929
6abdaa4a
PE
5930 * xselect.c (x_get_local_selection, x_handle_property_notify):
5931 Remove vars that are set but not used.
5932
0ce7538d 5933 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5934 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5935
9ae848fc
PE
5936 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5937 Remove var that is set but not used.
0b918413
PE
5938 (scroll_bar_windows_size): Now size_t, not int.
5939 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5940 Check for overflow.
9ae848fc 5941
a5a62657
PE
5942 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5943 (map_tty_color) [!defined MSDOS]: Likewise.
5944
5c5cdd39
PE
5945 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5946
66ebf983
PE
5947 * coding.c: Remove vars that are set but not used.
5948 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5949 All callers changed.
5950 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5951 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5952 (decode_coding_charset): Remove vars that are set but not used.
5953
1be4d761
PE
5954 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5955 that is set but not used.
5956
47553fa8
PE
5957 * print.c (print_object): Remove var that is set but not used.
5958
1f7196bf 5959 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5960 The gnulib version avoids calling malloc in the usual case,
5961 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5962 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5963 * filelock.c (current_lock_owner): Likewise.
5964 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5965 * sysdep.c: Include allocator.h, careadlinkat.h.
5966 (emacs_no_realloc_allocator): New static constant.
5967 (emacs_readlink): New function.
fdb61804
PE
5968 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5969 ../lib/careadlinkat.h.
d1fdcab7 5970
f84c17c7
SM
59712011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5972
5973 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5974 first non-nil return value).
5975
ef3862ad
JD
59762011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5977
5978 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5979 if not defined (Bug#8403).
5980
376a7006
JB
59812011-04-02 Juanma Barranquero <lekktu@gmail.com>
5982
5983 * xdisp.c (display_count_lines): Remove parameter `start',
5984 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5985 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5986 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5987 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5988 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5989 and thereabouts. All callers changed.
5990 (get_per_char_metric): Remove parameter `f', unused since
5991 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5992
6ca3801d
JM
59932011-04-02 Jim Meyering <meyering@redhat.com>
5994
5995 do not dereference NULL upon failed strdup
5996 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5997 (ns_get_family): Likewise.
5998
d8e2b5ba
JB
59992011-04-02 Juanma Barranquero <lekktu@gmail.com>
6000
6001 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6002
8c74fcbd
JD
60032011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6004
6005 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6006 later (Bug#8403).
6007
7200d79c
SM
60082011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6009
03408648 6010 Add lexical binding.
7200d79c 6011
03408648
SM
6012 * window.c (Ftemp_output_buffer_show): New fun.
6013 (Fsave_window_excursion):
6014 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6015
6016 * lread.c (lisp_file_lexically_bound_p): New function.
6017 (Fload): Bind Qlexical_binding.
6018 (readevalloop): Remove `evalfun' arg.
6019 Bind Qinternal_interpreter_environment.
6020 (Feval_buffer): Bind Qlexical_binding.
6021 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6022 Mark as dynamic.
6023 (syms_of_lread): Declare `lexical-binding'.
6024
6025 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6026
6027 * keyboard.c (eval_dyn): New fun.
6028 (menu_item_eval_property): Use it.
ca105506
SM
6029
6030 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6031
03408648
SM
6032 * fns.c (concat, mapcar1): Accept byte-code-functions.
6033
6034 * eval.c (Fsetq): Handle lexical vars.
6035 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6036 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6037 (FletX, Flet): Obey lexical binding.
6038 (Fcommandp): Handle closures.
6039 (Feval): New `lexical' arg.
6040 (eval_sub): New function extracted from Feval. Use it almost
6041 everywhere where Feval was used. Look up vars in lexical env.
6042 Handle closures.
6043 (Ffunctionp): Move from subr.el.
6044 (Ffuncall): Handle closures.
6045 (apply_lambda): Remove `eval_flags'.
6046 (funcall_lambda): Handle closures and new byte-code-functions.
6047 (Fspecial_variable_p): New function.
6048 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6049 but without exporting it to Lisp.
23aba0ea 6050
23aba0ea 6051 * doc.c (Fdocumentation, store_function_docstring):
03408648 6052 * data.c (Finteractive_form): Handle closures.
23aba0ea 6053
03408648
SM
6054 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6055 interactive spec.
ba83908c 6056
04f2d78b
CB
6057 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6058 New byte-codes.
03408648
SM
6059 (exec_byte_code): New function extracted from Fbyte_code to handle new
6060 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6061
03408648 6062 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6063
03408648 6064 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6065
e2abce01
JB
60662011-03-31 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * xdisp.c (redisplay_internal): Fix prototype.
6069
63696a73 60702011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6071
63696a73 6072 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6073 (try_scrolling): Use it when setting scroll_limit.
6074 Limit scrolling to 100 screen lines.
63696a73
EZ
6075 (redisplay_window): Even when falling back on "recentering",
6076 position point in the window according to scroll-conservatively,
6077 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6078
6079 (try_scrolling): When point is above the window, allow searching
6080 as far as scroll_max, or one screenful, to compute vertical
6081 distance from PT to the scroll margin position. This prevents
6082 try_scrolling from unnecessarily failing when
6083 scroll-conservatively is set to a value slightly larger than the
6084 window height. Clean up the case of PT below the margin at bottom
6085 of window: scroll_max can no longer be INT_MAX. When aggressive
6086 scrolling is in use, don't let point enter the opposite scroll
6087 margin as result of the scroll.
6088 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6089 threshold of 100 lines for never-recentering scrolling.
6090
e4cc2dfc
JB
60912011-03-31 Juanma Barranquero <lekktu@gmail.com>
6092
6093 * dispextern.h (move_it_by_lines):
6094 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6095 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6096 (message_log_check_duplicate): Remove parameters `prev_bol' and
6097 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6098 (redisplay_internal): Remove parameter `preserve_echo_area',
6099 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6100
6101 * indent.c (Fvertical_motion):
6102 * window.c (window_scroll_pixel_based, Frecenter):
6103 Don't pass `need_y_p' to `move_it_by_lines'.
6104
1c470562
SM
61052011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6106
44f230aa
SM
6107 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6108 steal a few bits to be more compact.
6109 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6110 Remove unneeded casts.
6111
1c470562
SM
6112 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6113
888adce9
ZK
61142011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6115
6116 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6117 binding" message (bug#7967).
6118
f838ed7b
PE
61192011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6120
77861b95
PE
6121 Fix more problems found by GCC 4.6.0's static checks.
6122
de6dbc14
PE
6123 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6124 Remove unused local var.
6125
f838ed7b
PE
6126 * editfns.c (Fmessage_box): Remove unused local var.
6127
792c7b2b
PE
6128 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6129 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6130 Omit unused local vars.
c499e557 6131 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6132 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6133 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6134 Omit unused local var.
6135
ba0165e1
PE
6136 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6137 Don't assume string length fits in int.
32ad8845 6138 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6139 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6140
3c59b4c9
PE
6141 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6142 instead of alloca (Bug#8344).
6143
a3eed478 6144 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6145 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6146
eb4d412d
PE
6147 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6148
1658b401
PE
6149 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6150 concerns.
6151
6152 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6153
6154 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6155
9a2c6e05
PE
6156 * keyboard.c (syms_of_keyboard): Use the same style as later
6157 in this function when indexing through an array. This also
6158 works around GCC bug 48267.
6159
03d0a109
PE
6160 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6161
44f730c8
PE
6162 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6163
fe75f926
PE
6164 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6165 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6166
ffa8c828
PE
6167 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6168 This avoids undefined behavior on integer overflow, and is a bit
6169 more convenient anyway since it is compared to a size_t variable.
6170
c5101a77
PE
6171 Variadic C functions now count arguments with size_t, not int.
6172 This avoids an unnecessary limitation on 64-bit machines, which
6173 caused (substring ...) to crash on large vectors (Bug#8344).
6174 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6175 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6176 All variadic functions and their callers changed accordingly.
c5101a77
PE
6177 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6178 * data.c (arith_driver, float_arith_driver): Likewise.
6179 * editfns.c (general_insert_function): Likewise.
6180 * eval.c (struct backtrace.nargs, interactive_p)
6181 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6182 (funcall_lambda, mark_backtrace): Likewise.
6183 * fns.c (concat): Likewise.
6184 * frame.c (x_set_frame_parameters): Likewise.
6185 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6186 0 if not found, not -1. All callers changed.
6187
dd3f25f7
PE
6188 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6189 (stack_copy_size): Now size_t, not int.
6190 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6191
461c2ab9
JB
61922011-03-28 Juanma Barranquero <lekktu@gmail.com>
6193
6194 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6195 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6196 All callers changed.
6197
6198 * lisp.h (multibyte_char_to_unibyte):
6199 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6200 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6201 * character.h (CHAR_TO_BYTE8):
6202 * cmds.c (internal_self_insert):
6203 * editfns.c (general_insert_function):
6204 * keymap.c (push_key_description):
6205 * search.c (Freplace_match):
6206 * xdisp.c (message_dolog, set_message_1): All callers changed.
6207
f6d62986
SM
62082011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6209
6210 * keyboard.c (safe_run_hook_funcall): New function.
6211 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6212 don't set the hook to nil, but remove the offending function instead.
6213 (Qcommand_hook_internal): Remove, unused.
6214 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6215 Vcommand_hook_internal.
6216
6217 * eval.c (enum run_hooks_condition): Remove.
6218 (funcall_nil, funcall_not): New functions.
6219 (run_hook_with_args): Call each function through a `funcall' argument.
6220 Remove `cond' argument, now redundant.
6221 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6222 (Frun_hook_with_args_until_failure): Adjust accordingly.
6223 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6224
1db5b1ad
JB
62252011-03-28 Juanma Barranquero <lekktu@gmail.com>
6226
6227 * dispextern.h (string_buffer_position): Remove declaration.
6228
6229 * print.c (strout): Remove parameter `multibyte', unused since
6230 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6231
6232 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6233 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6234 All callers changed.
6235
6236 * w32.c (_wsa_errlist): Use braces for struct initializers.
6237
6238 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6239 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6240 All callers changed.
6241 (string_buffer_position): Likewise. Also, make static (it's never
6242 used outside xdisp.c).
6243 (cursor_row_p): Remove parameter `w', unused since
6244 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6245 (decode_mode_spec): Remove parameter `precision', introduced during
6246 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6247 All callers changed.
6248
5ffb62aa
JD
62492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6250
6251 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6252
461c2ab9 62532011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6254
6255 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6256 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6257 (ns_update_auto_hide_menu_bar): New functions.
6258 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6259 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6260 ns_constrain_all_frames.
6261 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6262 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6263
5c380ffb
JD
62642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6265
6266 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6267
9af30bdf
GM
62682011-03-27 Glenn Morris <rgm@gnu.org>
6269
6270 * syssignal.h: Replace RETSIGTYPE with void.
6271 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6272 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6273 Replace SIGTYPE with void everywhere.
6274 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6275 * s/template.h (SIGTYPE): Remove commented out definition.
6276
e2abce01
JB
62772011-03-26 Eli Zaretskii <eliz@gnu.org>
6278
6279 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6280 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6281
f868cd8a
JB
62822011-03-26 Juanma Barranquero <lekktu@gmail.com>
6283
59eb0929
JB
6284 * w32.c (read_unc_volume): Use parameter `henum', instead of
6285 global variable `wget_enum_handle'.
6286
6287 * keymap.c (describe_vector): Remove parameters `indices' and
6288 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6289 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6290
f868cd8a
JB
6291 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6292
6293 * keyboard.c (timer_check): Remove parameter `do_it_now',
6294 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6295 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6296 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6297
6298 * keyboard.c (read_char):
6299 * w32menu.c (w32_menu_display_help):
6300 * xmenu.c (show_help_event, menu_help_callback):
6301 Adjust calls to `show_help_echo'.
6302
6303 * gtkutil.c (xg_maybe_add_timer):
6304 * keyboard.c (readable_events):
6305 * process.c (wait_reading_process_output):
6306 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6307
6308 * insdel.c (adjust_markers_gap_motion):
6309 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6310 (gap_left, gap_right): Don't call it.
6311
2ecf6fdb
CY
63122011-03-25 Chong Yidong <cyd@stupidchicken.com>
6313
6314 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6315 incurred during fontification.
6316
6b1f9ba4
JB
63172011-03-25 Juanma Barranquero <lekktu@gmail.com>
6318
6319 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6320 (DEFVAR_PER_BUFFER): Don't pass it.
6321
6322 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6323 (scrolling_window): Don't pass it.
6324
0f4a96b5
JB
63252011-03-25 Juanma Barranquero <lekktu@gmail.com>
6326
6327 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6328
6329 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6330 and `suffix'.
6331 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6332 of variables specific to SELinux and computation of `encoded_absname'.
6333
6334 * image.c (XPutPixel): Remove unused variable `height'.
6335
6336 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6337
6338 * unexw32.c (get_section_info): Remove unused variable `section'.
6339
6340 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6341 (system_process_attributes): Remove unused variable `sess'.
6342 (sys_read): Remove unused variable `err'.
6343
6344 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6345 (w32_wnd_proc): Remove unused variable `isdead'.
6346 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6347 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6348 (x_create_tip_frame): Remove unused variable `tem'.
6349
6350 * w32inevt.c (w32_console_read_socket):
6351 Remove unused variable `no_events'.
6352
6353 * w32term.c (x_draw_composite_glyph_string_foreground):
6354 Remove unused variable `width'.
6355
1149507c
JB
63562011-03-24 Juanma Barranquero <lekktu@gmail.com>
6357
6358 * w32term.c (x_set_glyph_string_clipping):
6359 Don't pass uninitialized region to CombineRgn.
6360
9c88f339
JB
63612011-03-23 Juanma Barranquero <lekktu@gmail.com>
6362
6363 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6364 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6365 (Fx_close_connection): Remove unused variable `i'.
6366
6367 * w32font.c (w32font_draw): Return number of glyphs.
6368 (w32font_open_internal): Remove unused variable `i'.
6369 (w32font_driver): Add missing initializer.
6370
6371 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6372 (fill_in_menu): Remove unused variable `items_added'.
6373
6374 * w32term.c (last_mouse_press_frame): Remove static global variable.
6375 (w32_clip_to_row): Remove unused variable `f'.
6376 (x_delete_terminal): Remove unused variable `i'.
6377
6378 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6379 (NOTHING): Remove unused static global variable.
6380 (uniscribe_check_otf): Remove unused variable `table'.
6381 (uniscribe_font_driver): Add missing initializers.
6382
dee091a3
JD
63832011-03-23 Julien Danjou <julien@danjou.info>
6384
6385 * term.c (Fsuspend_tty, Fresume_tty):
6386 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6387 * window.c (temp_output_buffer_show):
6388 * insdel.c (signal_before_change):
6389 * frame.c (Fhandle_switch_frame):
6390 * fileio.c (Fdo_auto_save):
6391 * emacs.c (Fkill_emacs):
6392 * editfns.c (save_excursion_restore):
6393 * cmds.c (internal_self_insert):
6394 * callint.c (Fcall_interactively):
6395 * buffer.c (Fkill_all_local_variables):
6396 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6397 Use Frun_hooks.
0f4a96b5 6398 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6399 unconditionnaly since it does the check itself.
6400
2c520ab5 64012011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6402
c9c49752
PE
6403 Fix more problems found by GCC 4.5.2's static checks.
6404
8abc3f12
PE
6405 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6406 the first time through the loop, since we know p0 < p1 then.
6407 This also avoids a gcc -Wstrict-overflow warning.
6408
a2d26660
PE
6409 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6410 leading to a memory leak, possible in functions like
6411 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6412 of objects (Bug#8318).
a2d26660 6413
916c72e9
PE
6414 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6415 that could (at least in theory) be that large.
6416
19ab8a18
PE
6417 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6418 This is less likely to overflow, and avoids undefined behavior if
6419 overflow does occur. All callers changed. Use strtoul to scan
6420 for the unsigned long integer.
b7cbbd6f
PE
6421 (pint2hrstr): Simplify and tune code slightly.
6422 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6423
f0641eff
PE
6424 * scroll.c (do_scrolling): Work around GCC bug 48228.
6425 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6426
7f650bb9
PE
6427 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6428 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6429 (validate_x_resource_name): Simplify count usage.
6430 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6431
37dd57d1
PE
6432 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6433 fail (Bug#8306).
81e56e61 6434
699979fc 6435 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6436
401bf9b4
PE
6437 * process.c (Fmake_network_process): Use socklen_t, not int,
6438 where POSIX says socklen_t is required in portable programs.
6439 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6440 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6441 (Fmake_network_process, server_accept_connection):
6442 (wait_reading_process_output, read_process_output):
6443 Likewise.
6444
b93aacde
PE
6445 * process.c: Rename or move locals to avoid shadowing.
6446 (list_processes_1, Fmake_network_process):
6447 (read_process_output_error_handler, exec_sentinel_error_handler):
6448 Rename or move locals.
4dc343ee 6449 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6450 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6451 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6452 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6453 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6454
af8a867c 6455 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6456 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6457 Include tparam.h instead, since it declares them.
af8a867c
PE
6458 * cm.h (PC): Remove extern decl; tparam.h now does this.
6459 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6460 * terminfo.c: Include tparam.h, to check interfaces.
6461 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6462 (tparam): Adjust signature to match interface in tparam.h;
6463 this removes some undefined behavior. Check that outstring and len
6464 are zero, which they always are with Emacs.
6465 * tparam.h (PC, BC, UP): New extern decls.
6466
0248044d 6467 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6468 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6469
8ff096c1 6470 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6471 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6472 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6473 (ftfont_list): Remove unused local.
49eaafba
PE
6474 (get_adstyle_property, ftfont_pattern_entity):
6475 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6476 Rename locals to avoid shadowing.
8ff096c1 6477
e2be39f6
PE
6478 * xfont.c (xfont_list_family): Mark var as initialized.
6479
c9735e30
PE
6480 * xml.c (make_dom): Now static.
6481
8f5201ae
PE
6482 * composite.c (composition_compute_stop_pos): Rename local to
6483 avoid shadowing.
b246f932
PE
6484 (composition_reseat_it): Remove unused locals.
6485 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6486 (composition_update_it): Mark var as initialized.
11b61122
PE
6487 (find_automatic_composition): Mark vars as initialized,
6488 with a FIXME (Bug#8290).
8f5201ae 6489
760fbc2c
PE
6490 character.h: Rename locals to avoid shadowing.
6491 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6492 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6493 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6494 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6495 to avoid shadowing.
6496
ff08eb85
PE
6497 * textprop.c (property_change_between_p): Remove; unused.
6498
fc7bf025
PE
6499 * intervals.c (interval_start_pos): Now static.
6500
235d7abc
PE
6501 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6502
44f230aa
SM
6503 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6504 Rename locals to avoid shadowing.
3e7d6594 6505
50060332
PE
6506 * sound.c (wav_play, au_play, Fplay_sound_internal):
6507 Fix pointer signedness.
d01f234b 6508 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6509 (wav_play): Initialize a variable to 0, to prevent undefined
6510 behavior (Bug#8278).
50060332 6511
c4fc4e30
PE
6512 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6513
918436ed
PE
6514 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6515
c939f91b
PE
6516 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6517 clobbering (Bug#8298).
b9c7f648
PE
6518 * sysdep.c (sys_subshell): Likewise.
6519 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6520
6bd8c144
PE
6521 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6522 This should get cleaned up, so that child_setup has the
6523 same signature on all platforms.
6524
7710357c 6525 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6526 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6527
c59da222
CY
65282011-03-22 Chong Yidong <cyd@stupidchicken.com>
6529
6530 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6531 not to be necessary, and produces flickering.
6532
66b87493
GM
65332011-03-20 Glenn Morris <rgm@gnu.org>
6534
6535 * config.in: Remove file.
6536
45b6f6d5
JB
65372011-03-20 Juanma Barranquero <lekktu@gmail.com>
6538
6539 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6540 are now in src/globals.h.
6541 (syms_of_minibuf): Remove spurious & from previous change.
6542
3ec03f7e
LL
65432011-03-20 Leo <sdl.web@gmail.com>
6544
6545 * minibuf.c (completing-read-function): New variable.
6546 (completing-read-default): Rename from completing-read.
6547 (completing-read): Call completing-read-function.
6548
b14e3e21
CY
65492011-03-19 Juanma Barranquero <lekktu@gmail.com>
6550
6551 * xfaces.c (Fx_load_color_file):
6552 Read color file from absolute filename (bug#8250).
6553
f2b726e6
JB
65542011-03-19 Juanma Barranquero <lekktu@gmail.com>
6555
6556 * makefile.w32-in: Update dependencies.
6557
09f6ff02
EZ
65582011-03-17 Eli Zaretskii <eliz@gnu.org>
6559
6560 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6561
29a6015a
PE
65622011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6563
a3a6c54e
PE
6564 Fix more problems found by GCC 4.5.2's static checks.
6565
b766f867
PE
6566 * process.c (make_serial_process_unwind, send_process_trap):
6567 (sigchld_handler): Now static.
6568
be02381c
PE
6569 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6570 That way, the code declares only the vars that it needs.
6571 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6572 * s/cygwin.h (PTY_ITERATION): Likewise.
6573 * s/darwin.h (PTY_ITERATION): Likewise.
6574 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6575
57048744
PE
6576 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6577 * process.c (allocate_pty): Don't declare stb unless it's needed.
6578
7914961c 6579 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6580 (CONSTANTLIM): Remove; unused.
6581 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6582 Define only if needed.
7914961c 6583
b3967b18
PE
6584 * unexelf.c (unexec): Name an expression,
6585 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6586 Use a different way to cause a compilation error if anyone uses
6587 n rather than nn, a way that does not involve shadowing.
73366a00 6588 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6589
29a6015a
PE
6590 * deps.mk (unexalpha.o): Remove; unused.
6591
43cfc33e 6592 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6593 * unexec.h: New file.
ce701a33
PE
6594 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6595 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6596 Depend on unexec.h.
6597 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6598 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6599 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6600 Change as necessary to match prototype in unexec.h.
ce701a33 6601
01f44d5a
PE
6602 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6603 shadowing.
4f63c6bb 6604 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6605
a6670b0b
PE
6606 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6607 Rename locals to avoid shadowing.
6608
cef2010d 6609 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6610 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6611
d4d7173a
PE
6612 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6613
f08b802a
PE
6614 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6615 warning when compiling print.c.
6616
3ddb0639
PE
6617 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6618 instead of using an uninitialized var.
5ad03b97 6619 (font_sort_entities): Mark var as initialized.
3ddb0639 6620
170a2692
PE
6621 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6622
e663c700
PE
6623 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6624 pointers to constants.
89bc529a 6625 (font_parse_fcname): Remove unused vars.
7b81e2d0 6626 (font_delete_unmatched): Now static.
ea838e10 6627 (font_get_spec): Remove; unused.
13a547c6
PE
6628 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6629 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6630 Rename or move locals to avoid shadowing.
e663c700 6631
2a80c887 6632 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6633 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6634
1384fa33 6635 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6636 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6637
8b2c52e9
PE
6638 * alloc.c (mark_backtrace): Move decl from here ...
6639 * lisp.h: ... to here, so that it can be checked.
6640
475545b5 6641 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6642 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6643 (lisp_indirect_variable): Name an expression,
6644 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6645 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6646
b1349114 6647 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6648 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6649 Use const pointer when appropriate.
b1349114 6650
a2928364
PE
6651 * lisp.h (get_system_name, get_operating_system_release):
6652 Move decls here, to check interfaces.
6653 * process.c (get_operating_system_release): Move decl to lisp.h.
6654 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6655 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6656 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6657 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6658 (Fformat_time_string, Fencode_time, Finsert_char):
6659 (Ftranslate_region_internal, Fformat):
6660 Rename or remove local vars to avoid shadowing.
9710023e 6661 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6662
a415e694
PE
6663 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6664 avoid shadowing.
6665
8ef4622d
PE
6666 * lisp.h (eassert): Check that the argument compiles, even if
6667 ENABLE_CHECKING is not defined.
6668
946f9a5b
PE
6669 * data.c (Findirect_variable): Name an expression, to avoid
6670 gcc -Wbad-function-cast warning.
112396d6 6671 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6672 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6673 (Fmake_variable_buffer_local, Fmake_local_variable):
6674 Mark variables as initialized.
52746918 6675 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6676
e5aab7e7 6677 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6678 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6679 Rename locals to avoid shadowing.
dff45157
PE
6680 (mark_stack): Move local variables into the #ifdef region where
6681 they're used.
7bc26fdb
PE
6682 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6683 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6684 needed otherwise.
6685 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6686 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6687 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6688
e5aab7e7
PE
6689 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6690 avoids undefined behavior in theory.
6691
4da60324
PE
6692 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6693
88043301
PE
6694 Use functions, not macros, for up- and down-casing (Bug#8254).
6695 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6696 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6697 to use the following functions instead of these macros.
6698 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6699 EMACS_INT, since callers assume the returned value fits in int.
6700 (upcase1): Likewise, for UPCASE_TABLE.
6701 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6702 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6703 the race-condition problem in the old DOWNCASE.
88043301 6704
19ed5445
PE
6705 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6706 Rename locals to avoid shadowing.
6707 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6708 (regex_compile, re_search_2, re_match_2_internal):
6709 Remove unused local vars.
952db0d7
PE
6710 (FREE_VAR): Rewrite so as not to use empty "else",
6711 which gcc can warn about.
da053e48 6712 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6713 (RETALLOC_IF): Define only if needed.
6714 (WORDCHAR_P): Likewise. This one is never needed, but is used
6715 only in a comment talking about a compiler bug, so put inside
6716 the #if 0 of that comment.
6717 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6718 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6719 Remove; unused.
19ed5445 6720
1f3561e4 6721 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6722 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6723 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6724
ded6f8f7
PE
6725 * search.c (simple_search): Remove unused var.
6726
dbd37a95
PE
6727 * dired.c (compile_pattern): Move decl from here ...
6728 * lisp.h: ... to here, so that it can be checked.
6729 (struct re_registers): New forward decl.
6730
7e47afad
PE
6731 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6732
85f24f61
PE
6733 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6734 All uses changed.
6735 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6736 Rename locals to avoid shadowing.
5671df8f 6737 (Fvertical_motion): Mark locals as initialized.
85f24f61 6738
181aa2be 6739 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6740 (casify_region): Mark local as initialized.
181aa2be 6741
930d429c
PE
6742 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6743
7082eac6
PE
6744 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6745 New macros, so that the caller can use some names other than
6746 gcpro1, gcpro2, etc.
6747 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6748 of the new macros.
6749 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6750 argument, for consistency with GCPRO2_VAR, etc: it is now the
6751 prefix of the variable, not the variable itself. All uses
6752 changed.
38b2c076
PE
6753 * dired.c (directory_files_internal, file_name_completion):
6754 Rename locals to avoid shadowing.
6755
15206ed9
PE
6756 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6757 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6758 dired.c's scmp function, had undefined behavior.
6759 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6760 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6761 * buffer.h: ... to here, because these macros use current_buffer,
6762 and the new implementation with inline functions needs to have
6763 current_buffer in scope now, rather than later when the macros
6764 are used.
6765 (downcase, upcase1): New static inline functions.
6766 (DOWNCASE, UPCASE1): Reimplement using these functions.
6767 This avoids undefined behavior in expressions like
6768 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6769 from race conditions in accessing the global variables
6770 case_temp1 and case_temp2.
6771 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6772 * lisp.h (case_temp1, case_temp2): Remove their decls.
6773 * character.h (ASCII_CHAR_P): Move from here ...
6774 * lisp.h: ... to here, so that the inline functions mentioned
6775 above can use them.
6776
4a6bea26
PE
6777 * dired.c (directory_files_internal_unwind): Now static.
6778
f14b7e14
PE
6779 * fileio.c (file_name_as_directory, directory_file_name):
6780 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6781 Now static.
2893f146
PE
6782 (file_name_as_directory): Use const pointers when appropriate.
6783 (Fexpand_file_name): Likewise. In particular, newdir might
6784 point at constant storage, so make it a const pointer.
fd4ead52 6785 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6786 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6787 signedness issues.
f839df0c
PE
6788 (Fset_file_times, Finsert_file_contents, auto_save_error):
6789 Rename locals to avoid shadowing.
f14b7e14 6790
5716756e 6791 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6792 (Ftry_completion, Fall_completions): Rename or remove locals
6793 to avoid shadowing.
5716756e 6794
b4c3046a
PE
6795 * marker.c (bytepos_to_charpos): Remove; unused.
6796
b45db522
PE
6797 * lisp.h (verify_bytepos, count_markers): New decls,
6798 so that gcc does not warn that these functions aren't declared.
6799
85876d07
PE
6800 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6801 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6802 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6803 (copy_text): Remove unused local var.
85876d07 6804
03d78a21 6805 * filelock.c (within_one_second): Now static.
b3dd38ab 6806 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6807
5df8f01b
PE
6808 * buffer.c (fix_overlays_before): Mark locals as initialized.
6809 (fix_start_end_in_overlays): Likewise. This function should be
6810 simplified by using pointers-to-pointers, but that's a different
6811 matter.
b1d876f1 6812 (switch_to_buffer_1): Now static.
8f54f30a
PE
6813 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6814 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6815
a70072c9 6816 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6817 Fix pointer signedness issue.
edced198
PE
6818 (sys_subshell): Mark local as volatile if checking for lint,
6819 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6820 (MAXPATHLEN): Define only if needed.
a70072c9 6821
a0977c44
PE
6822 * process.c (serial_open, serial_configure): Move decls from here ...
6823 * systty.h: ... to here, so that they can be checked.
6824
a884fdcc
PE
6825 * fns.c (get_random, seed_random): Move extern decls from here ...
6826 * lisp.h: ... to here, so that they can be checked.
6827
604efe86 6828 * sysdep.c (reset_io): Now static.
b8950c94 6829 (wait_for_termination_signal): Remove; unused.
604efe86 6830
38fc62d9
PE
6831 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6832 (copy_keymap_item, append_key, push_text_char_description):
6833 Now static.
1004a21a 6834 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6835 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6836 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6837 (describe_map_tree):
6838 Rename locals to avoid shadowing.
38fc62d9 6839
2f2650da
PE
6840 * keyboard.c: Declare functions static if they are not used elsewhere.
6841 (echo_char, echo_dash, cmd_error, top_level_2):
6842 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6843 (read_char, kbd_buffer_get_event, make_lispy_position):
6844 (make_lispy_event, make_lispy_movement, apply_modifiers):
6845 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6846 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6847 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6848 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6849 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6850
a053e86c 6851 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6852 (mark_kboards): Move decl here ...
6853 * alloc.c (mark_kboards): ... from here.
a053e86c 6854
4752793e
PE
6855 * lisp.h (force_auto_save_soon): New decl.
6856
74f10ca7 6857 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6858 (DEFINE_DUMMY_FUNCTION): New macro.
6859 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6860 Use it.
c03cd23f
PE
6861 (main): Add casts to avoid warnings
6862 if GCC considers string literals to be constants.
74f10ca7 6863
022e70d4
PE
6864 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6865
59d6fe83
PE
6866 * dbusbind.c: Pointer signedness fixes.
6867 (xd_signature, xd_append_arg, xd_initialize):
6868 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6869 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6870 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6871 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6872
78320123
PE
6873 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6874 if GCC considers string literals to be constants.
49cebcca 6875 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6876
35ac2a97
SM
68772011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6878
fb103ca9
SM
6879 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6880 (print_preprocess, print_object): New macro to fix last change.
6881
35ac2a97
SM
6882 * print.c (print_preprocess): Don't forget font objects.
6883
62973b41
JB
68842011-03-16 Juanma Barranquero <lekktu@gmail.com>
6885
6886 * emacs.c (USAGE3): Doc fixes.
6887
0e48bb22
AS
68882011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6889
6890 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6891 structure.
6892
7684e57b
JB
68932011-03-14 Juanma Barranquero <lekktu@gmail.com>
6894
6895 * lisp.h (VWindow_system, Qfile_name_history):
6896 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6897 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6898 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6899
6900 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6901 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6902
6903 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6904 * w32console.c (detect_input_pending, read_input_pending)
6905 (encode_terminal_code):
6906 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6907 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6908 (w32_system_caret_y, Qfile_name_history):
6909 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6910 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6911 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6912 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6913 * w32proc.c (Qlocal, report_file_error):
6914 * w32term.c (Vwindow_system, updating_frame):
6915 * w32uniscribe.c (initialized, uniscribe_font_driver):
6916 Remove unneeded extern declarations.
6917
2aa46d6c
CY
69182011-03-14 Chong Yidong <cyd@stupidchicken.com>
6919
c96bbc66 6920 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6921
cffc6f3b
CY
69222011-03-13 Chong Yidong <cyd@stupidchicken.com>
6923
6924 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6925 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6926 These macros can no longer be used for assignment.
6927
44f230aa
SM
6928 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6929 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6930 (record_buffer_markers, fetch_buffer_markers): New functions for
6931 recording and fetching special buffer markers.
6932 (set_buffer_internal_1, set_buffer_temp): Use them.
6933
6934 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6935
6936 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6937
6938 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6939 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6940
6941 * xdisp.c (hscroll_window_tree):
6942 (reconsider_clip_changes): Use PT instead of BUF_PT.
6943
d251f04b
EZ
69442011-03-13 Eli Zaretskii <eliz@gnu.org>
6945
6946 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6947 $(EMACS_ROOT)/lib/intprops.h.
6948
f0c77cd1
PE
69492011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6950
3eca4629
PE
6951 Fix more problems found by GCC 4.5.2's static checks.
6952
7c86ee98
PE
6953 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6954 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6955 (xg_free_frame_widgets): Make it clear that a local variable is
6956 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6957 (gdk_window_get_screen): Make it clear that this macro is needed
6958 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6959 (int_gtk_range_get_value): New function, which avoids a diagnostic
6960 from gcc -Wbad-function-cast.
6961 (xg_set_toolkit_scroll_bar_thumb): Use it.
6962 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6963 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6964 (get_utf8_string, xg_get_file_with_chooser):
6965 Rename locals to avoid shadowing.
6966 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6967
41729b81
PE
6968 * xgselect.c (xg_select): Remove unused var.
6969
f0c77cd1
PE
6970 * image.c (four_corners_best): Mark locals as initialized.
6971 (gif_load): Initialize transparent_p to zero (Bug#8238).
6972 Mark another local as initialized.
ec6cf4c6 6973 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6974
ce0ad53d 6975 * image.c (clear_image_cache): Now static.
d5d5a617 6976 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6977 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6978 (x_edge_detection): Remove unnecessary cast that
6979 gcc -Wbad-function-cast diagnoses.
2037898d 6980 (gif_load): Fix pointer signedness.
6ae141d6
PE
6981 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6982 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6983
33383987 69842011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6985
d32df629
PE
6986 Improve quality of tests for time stamp overflow.
6987 For example, without this patch (encode-time 0 0 0 1 1
6988 1152921504606846976) returns the obviously-bogus value (-948597
6989 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6990 reports time overflow. See
6991 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6992 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6993 * editfns.c: Include limits.h and intprops.h.
6994 (TIME_T_MIN, TIME_T_MAX): New macros.
6995 (time_overflow): Move earlier, to before first use.
6996 (hi_time, lo_time): New functions, for an accurate test for
6997 out-of-range times.
6998 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6999 (Fget_internal_run_time): Don't assume time_t fits in int.
7000 (make_time): Use list2 instead of Fcons twice.
7001 (Fdecode_time): More accurate test for out-of-range times.
7002 (check_tm_member): New function.
7003 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7004 (lisp_time_argument): Don't rely on undefined left-shift and
7005 right-shift behavior when checking for time stamp overflow.
8be6f318 7006
fe31d94c
PE
7007 * editfns.c (time_overflow): New function, refactoring common code.
7008 (Fformat_time_string, Fdecode_time, Fencode_time):
7009 (Fcurrent_time_string): Use it.
7010
8be6f318
PE
7011 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7012 * dired.c (make_time): Move to ...
7013 * editfns.c (make_time): ... here.
7014 * systime.h: Note the move.
7015
09d9db2c 70162011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7017
126bc0dc
YM
7018 * fringe.c (update_window_fringes): Remove unused variables.
7019
c47cbdfd
YM
7020 * unexmacosx.c (copy_data_segment): Also copy __got section.
7021 (Bug#8223)
7022
7ac80be9
EZ
70232011-03-12 Eli Zaretskii <eliz@gnu.org>
7024
c96bbc66 7025 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7026 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7027 Constify `char *' arguments and their references according to
7028 prototypes in tparam.h.
7029
ecb0f94d 7030 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7031
7ac80be9
EZ
7032 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7033 Adapt all references accordingly.
7034
7035 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7036
ef1fd07e
TT
70372011-03-11 Tom Tromey <tromey@redhat.com>
7038
7039 * buffer.c (syms_of_buffer): Remove obsolete comment.
7040
7ef4b50c
EZ
70412011-03-11 Eli Zaretskii <eliz@gnu.org>
7042
7043 * termhooks.h (encode_terminal_code): Declare prototype.
7044
7045 * msdos.c (encode_terminal_code): Don't declare prototype.
7046
7047 * term.c (encode_terminal_code): Now external again, used by
7048 w32console.c and msdos.c.
7049
44f230aa
SM
7050 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7051 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7052
4b1ec863 70532011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7054
1714f52b 7055 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7056
4b1ec863
PE
7057 * fringe.c (update_window_fringes): Mark locals as initialized
7058 (Bug#8227).
7059 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7060
524c7aa6
PE
7061 * alloc.c (mark_fringe_data): Move decl from here ...
7062 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7063 to check its interface.
7064 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7065
a5c0af81 7066 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7067 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7068 (fontset_font): Mark local as initialized.
a9a06e0b 7069 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7070
b4716021
PE
7071 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7072
811e9bac 7073 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7074 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7075 (x_own_selection, Fx_disown_selection_internal): Rename locals
7076 to avoid shadowing.
7077 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7078
7e3ab302
PE
7079 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7080 so that the caller can use some name other than gcpro1.
7081 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7082 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7083 (Fx_backspace_delete_keys_p):
7084 Use them to avoid shadowing, and rename vars to avoid shadowing.
7085 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7086 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7087 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7088 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7089 Remove unused locals.
7e3ab302
PE
7090 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7091 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7092 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7093 macros.
f78faa98 7094
e2b13473
PE
7095 * xterm.h (x_mouse_leave): New decl.
7096
77f23912
PE
7097 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7098 Remove unused functions.
cdf4ba58
PE
7099 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7100 (x_calc_absolute_position): Now static.
7411c686 7101 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7102 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7103 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7104 unless they are used.
38d0b34a
PE
7105 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7106 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7107 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7108 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7109 (x_error_catcher, x_connection_closed, x_error_handler):
7110 (x_error_quitter, xembed_send_message, x_iconify_frame):
7111 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7112 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7113 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7114
44f230aa
SM
7115 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7116 Rename or move locals to avoid shadowing.
6b463e58 7117 (tty_defined_color, merge_face_heights): Now static.
5967d051 7118 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7119 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7120 does not deduce is never used uninitialized.
73719eba
PE
7121 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7122 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7123
426994c3 7124 * terminal.c (store_terminal_param): Now static.
5489860b 7125
032f1620 7126 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7127 (set_frame_menubar): Remove unused local.
d4323972 7128 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7129 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7130 since they might point to immutable storage.
281585b0
PE
7131 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7132 since it's unused otherwise.
032f1620 7133
367c19e5 7134 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7135 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7136 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7137 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7138 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7139 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7140 does not deduce are never used uninitialized.
70739cbe 7141
07b48fa9
PE
7142 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7143
8868a238 7144 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7145 * window.c (window_loop, size_window):
7146 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7147
7e5cf297 7148 * window.c (display_buffer): Now static.
d6550a9f
PE
7149 (size_window): Mark variables that gcc -Wuninitialized
7150 does not deduce are never used uninitialized.
a586633d
PE
7151 * window.h (check_all_windows): New decl, to forestall
7152 gcc -Wmissing-prototypes diagnostic.
5b555da1 7153 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7154
f6095868
PE
7155 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7156 shadowing.
7157 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7158 Include <limits.h>.
7159 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7160 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7161 (load_charset_map): Mark variables that gcc -Wuninitialized
7162 does not deduce are never used uninitialized.
53df7c11 7163 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7164
f38b440c
PE
7165 * coding.c (coding_set_source, coding_set_destination):
7166 Use "else { /* comment */ }" rather than "else /* comment */;"
7167 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7168 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7169 a block, when the outer 'i' will do.
7170 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7171 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7172 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7173 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7174 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7175 Rename locals to avoid shadowing.
7176 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7177 * coding.c (emacs_mule_char, encode_invocation_designation):
7178 Now static, since they're not used elsewhere.
413bb2db 7179 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7180 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7181 (decode_coding_emacs_mule): Mark variables that gcc
7182 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7183 (detect_coding_iso_2022): Initialize a local variable that might
7184 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7185 this initialization is needed. (Bug#8211)
5f58e762
PE
7186 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7187 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7188 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7189 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7190 Remove unused macros.
f38b440c 7191
232b38b9 7192 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7193 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7194 * character.c (string_count_byte8): Likewise.
232b38b9 7195
fb90da1b
PE
7196 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7197 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7198
fb93dbc2
PE
7199 * chartab.c (copy_sub_char_table): Now static, since it's not used
7200 elsewhere.
5c156ace
PE
7201 (sub_char_table_ref_and_range, char_table_ref_and_range):
7202 Rename locals to avoid shadowing.
bbcd0949 7203 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7204
7d3b3862 7205 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7206 (BIDI_BOB): Remove unused macro.
7d3b3862 7207
6be7d3da
PE
7208 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7209 deduce are never used uninitialized.
c2ed9c8b 7210 * term.c (encode_terminal_code): Likewise.
6be7d3da 7211
75f8807f 7212 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7213
50938595
PE
7214 * tparam.h: New file.
7215 * term.c, tparam.h: Include it.
7216 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7217 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7218 Move these decls to tparam.h, and make them agree with what
7219 is actually in tparam.c. The previous trick of using incompatible
7220 decls in different modules does not conform to the C standard.
7221 All callers of tparam changed to use tparam's actual API.
7222 * tparam.c (tparam1, tparam, tgoto):
7223 Use const pointers where appropriate.
7224
fbceeba2
PE
7225 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7226 * cm.h (struct cm): Likewise.
7227 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7228 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7229 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7230 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7231 (turn_on_face, init_tty): Likewise.
7232 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7233
7f3f1250
PE
7234 * term.c (term_mouse_position): Rename local to avoid shadowing.
7235
e6ca6543
PE
7236 * alloc.c (mark_ttys): Move decl from here ...
7237 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7238
c40f8d15
AS
72392011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7240
7241 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7242
cfe0661d
JB
72432011-03-09 Juanma Barranquero <lekktu@gmail.com>
7244
7245 * search.c (compile_pattern_1): Remove argument regp, unused since
7246 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7247 (compile_pattern): Don't pass it.
7248
0afb4571
J
72492011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7250
7251 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7252 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7253 for ! HAVE_GTK3.
7254 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7255
7256 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7257
7258 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7259 gdk_window_get_screen, gdk_window_get_geometry,
7260 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7261 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7262 (xg_get_pixbuf_from_pixmap): New function.
7263 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7264 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7265 Call xg_get_pixbuf_from_pixmap instead of
7266 gdk_pixbuf_get_from_drawable.
7267 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7268 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7269 (xg_check_special_colors): Use GtkStyleContext and its functions
7270 for HAVE_GTK3.
7271 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7272 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7273 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7274 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7275 Call gtk_widget_get_preferred_size.
0afb4571
J
7276 (xg_frame_resized): gdk_window_get_geometry only takes 5
7277 parameters.
44f230aa
SM
7278 (xg_win_to_widget, xg_event_is_for_menubar):
7279 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7280 (xg_set_widget_bg): New function.
7281 (delete_cb): New function.
895009e1 7282 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7283 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7284 (xg_set_background_color): Call xg_set_widget_bg.
7285 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7286 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7287 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7288 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7289 if ! HAVE_GTK3.
7290 (update_frame_tool_bar): Call gtk_widget_hide.
7291 (xg_initialize): Use GDK_KEY_g.
7292
7293 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7294 if ! HAVE_GTK3
7295 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7296
7297 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7298 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7299 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7300
1c2cc4ef
JB
73012011-03-08 Juanma Barranquero <lekktu@gmail.com>
7302
7303 * w32xfns.c (select_palette): Check success of RealizePalette against
7304 GDI_ERROR, not zero.
7305
33383987 7306See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7307
7308;; Local Variables:
7309;; coding: utf-8
aac0c6e3
MR
7310;; End:
7311
33383987 7312 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7313
7314 This file is part of GNU Emacs.
7315
7316 GNU Emacs is free software: you can redistribute it and/or modify
7317 it under the terms of the GNU General Public License as published by
7318 the Free Software Foundation, either version 3 of the License, or
7319 (at your option) any later version.
7320
7321 GNU Emacs is distributed in the hope that it will be useful,
7322 but WITHOUT ANY WARRANTY; without even the implied warranty of
7323 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7324 GNU General Public License for more details.
7325
7326 You should have received a copy of the GNU General Public License
7327 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.