* image.c (parse_image_spec): Check for nonnegative, not for positive,
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c4a07a4c
PE
12011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4 when checking :margin (Bug#9390).
5 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7 so that the name doesn't mislead. All uses changed.
8
6bc8cd65
JB
92011-08-28 Johan Bockgård <bojohan@gnu.org>
10
11 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
12 set_tty_hooks.
13
dca4927e
EZ
142011-08-27 Eli Zaretskii <eliz@gnu.org>
15
16 * xdisp.c (move_it_to): Don't bail out early when reaching
17 position beyond to_charpos, if we are scanning backwards.
18 (move_it_vertically_backward): When DY == 0, make sure we get to
19 the first character in the line after the newline.
20
f2cad773
PE
212011-08-27 Paul Eggert <eggert@cs.ucla.edu>
22
23 * ccl.c: Improve and simplify overflow checking (Bug#9196).
24 (ccl_driver): Do not generate an out-of-range pointer.
25 (Fccl_execute_on_string): Remove unnecessary check for
26 integer overflow, noted by Stefan Monnier in
27 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
28 Remove a FIXME that didn't need fixing.
29 Simplify the newly-introduced buffer reallocation code.
30
0cae2cdb
JB
312011-08-27 Juanma Barranquero <lekktu@gmail.com>
32
33 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
34
5fc295a4 352011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 36
70c60eb2 37 Integer and memory overflow issues (Bug#9196).
726e0ab1 38
d31850da
PE
39 * doc.c (get_doc_string): Rework so that
40 get_doc_string_buffer_size is the actual buffer size, rather than
41 being 1 less than the actual buffer size; this makes xpalloc more
42 convenient.
43
a69fbedb
PE
44 * image.c (x_allocate_bitmap_record, cache_image):
45 * xselect.c (Fx_register_dnd_atom):
46 Simplify previous changes by using xpalloc.
47
fe5c5d37
PE
48 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
49 since either will do and ptrdiff_t is convenient with xpalloc.
50
0065d054
PE
51 * charset.c (charset_table_size)
52 (struct charset_sort_data.priority): Now ptrdiff_t.
53 (charset_compare): Don't overflow if priorities differ greatly.
54 (Fsort_charsets): Don't assume list length fits in int.
55 Check for size-calculation overflow when allocating sort data.
56 (syms_of_charset): Allocate an initial charset table that is
57 just under 64 KiB, to avoid problems with glibc malloc and mmap.
58
59 * cmds.c (internal_self_insert): Check for size-calculation overflow.
60
61 * composite.h (struct composition.glyph_len): Now int, not unsigned.
62 The actual value is always <= INT_MAX, and leaving it unsigned made
63 overflow checking harder.
64
65 * dispextern.h (struct glyph_matrix.rows_allocated)
66 (struct face_cache.size): Now ptrdiff_t, for convenience in use
67 with xpalloc. The values are still always <= INT_MAX.
68
69 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
70
71 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
72 (SAFE_NALLOCA): New macro.
73
74 * region-cache.c (struct boundary.pos, find_cache_boundary)
75 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
76 (set_cache_region, invalidate_region_cache)
77 (revalidate_region_cache, know_region_cache, region_cache_forward)
78 (region_cache_backward, pp_cache):
79 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
80 so that ptrdiff_t * can be passed to xpalloc.
81 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
82 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
83 (pp_cache): Don't assume cache_len fits in int.
84 * region-cache.h: Adjust extern decls to match.
85
86 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
87 EMACS_INT, since either will do, for xpalloc.
88
89 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
90 (xnmalloc, xnrealloc, xpalloc): New functions.
91
726e0ab1
PE
92 * bidi.c (bidi_shelve_header_size): New constant.
93 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
94 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
95
51f30bc5 96 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
97 * buffer.c (overlays_at, overlays_in, record_overlay_string)
98 (overlay_strings):
99 Don't update size of array until after memory allocation succeeds,
100 because xmalloc/xrealloc may not return.
0065d054
PE
101 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
102 now that we have proper integer overflow checking.
103 (record_overlay_string, overlay_strings): Catch overflows when
104 calculating size of overlay_str_buf.
726e0ab1 105
0065d054
PE
106 * callproc.c (Fcall_process): Check for size overflow when
107 calculating size of args2.
108 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
109 Normally we prefer signed values, but sticking with ptrdiff_t would
110 require adding more-complicated checks.
726e0ab1
PE
111
112 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
113 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
114 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 115 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
116
117 * character.c (Fstring): Check for size-calculation overflow.
118
119 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
120 unnecessary integer overflow. Check for size overflow.
121 (encode_coding_object): Don't update size until xmalloc succeeds.
122
123 * composite.c (get_composition_id): Check for overflow in glyph
124 length calculations.
125
126 Integer and memory overflow fixes for display code.
127 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
128 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
129 (scrolling_window): Check for overflow in size calculations.
130 (line_draw_cost, realloc_glyph_pool, add_row_entry):
131 Don't assume glyph table len fits in int.
132 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
133 (row_table_size): Now ptrdiff_t, not int.
134 (scrolling_window): Avoid overflow in size calculations.
135 Don't update size until allocation succeeds.
136 * fns.c (concat): Check for overflow in size calculations.
137 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
138 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
139 (NEXT_ALMOST_PRIME_LIMIT): New constant.
140
141 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
142 (get_doc_string): Check for size calculation overflow.
143 Don't update size until allocation succeeds.
144 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
145 EMACS_INT, where ptrdiff_t will do.
146 (Fsubstitute_command_keys): Check for string overflow.
147
148 * editfns.c (set_time_zone_rule): Don't assume environment length
149 fits in int.
150 (message_length): Now ptrdiff_t, not int.
151 (Fmessage_box): Don't update size until allocation succeeds.
152 Don't assume message length fits in int.
153 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
154
0065d054
PE
155 * emacs.c (main): Do not reallocate argv, since there is a null at
156 the end that can be overwritten, and this way there's no need to
157 worry about size-calculation overflow.
158 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
159
160 * eval.c (init_eval_once, grow_specpdl): Don't update size until
161 alloc succeeds.
162 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
163
164 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
165 (x_set_scroll_bar_width, x_figure_window_size):
166 Check for integer overflow.
167 (x_set_alpha): Do not assume XINT fits in int.
168
169 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
170 This is for the members text_lines, text_cols, total_lines, total_cols,
171 where the system imposes an 'int' limit.
172
173 * fringe.c (Fdefine_fringe_bitmap):
174 Don't update size until alloc works.
175
176 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
177 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
178
179 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
180 Check for size-calculation overflow.
181 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
182 do, as we prefer signed integers.
183 (id_to_widget.max_size, id_to_widget.used)
184 (xg_store_widget_in_map, xg_remove_widget_from_map)
185 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
186 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
187 Use and return ptrdiff_t, not int.
188 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
189 * gtkutil.h: Change prototypes to match the above.
190
191 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
192 are duplicate now that they've been promoted to lisp.h.
193 (x_allocate_bitmap_record, x_alloc_image_color)
194 (make_image_cache, cache_image, xpm_load):
195 Don't update size until alloc is done.
196 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
197 (x_detect_edges):
3256efce 198 Check for size calculation overflow.
726e0ab1
PE
199 (ct_colors_allocated_max): New constant.
200 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
201 overflow.
3256efce 202
726e0ab1
PE
203 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
204 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
205 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
206 Use ptrdiff_t, not int, to count maps.
207 (read_char_minibuf_menu_prompt): Check for overflow in size
208 calculations. Don't update size until allocation succeeds. Redo
209 calculations to avoid overflow.
210 * keyboard.h: Change prototypes to match the above.
211
212 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
213 to count maps.
214 (current_minor_maps): Check for size calculation overflow.
215 * keymap.h: Change prototypes to match the above.
216
217 * lread.c (read1, init_obarray): Don't update size until alloc done.
218
219 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
220 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
221
726e0ab1
PE
222 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
223 Now ptrdiff_t, not int.
224 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
225 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
226
227 * process.c (Fnetwork_interface_list): Check for overflow
228 in size calculation.
229
230 * region-cache.c (move_cache_gap): Check for size calculation overflow.
231
232 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
233 overflow. Don't bother calling xmalloc when xrealloc will do.
234
235 * search.c (Freplace_match): Check for size calculation overflow.
236 (Fset_match_data): Don't assume list lengths fit in 'int'.
237
238 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
239 for command line length. Do not attempt to address one before the
240 beginning of an array, as that's not portable.
241
242 * term.c (max_frame_lines): Remove; unused.
243 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
244 not int.
245 (encode_terminal_code, calculate_costs): Check for size
246 calculation overflow.
247 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
248 table lengths and related sizes. Don't update size until alloc
249 done. Redo calculations to avoid overflow.
250 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
251
252 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
253 subtracting pointers.
254 (gobble_line): Check for overflow more carefully. Don't update size
255 until alloc done.
256
257 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
258 Don't update size until alloc done.
259 Redo size calculations to avoid overflow.
260 Check for size calculation overflow.
0065d054 261 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
262
263 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
264 Use ptrdiff_t, not int, for sizes.
265 (store_mode_line_noprop_char): Don't update size until alloc done.
266
0065d054
PE
267 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
268 Use ptrdiff_t, not int, for sizes.
269 (Finternal_make_lisp_face, cache_face):
270 Check for size calculation overflow.
271 (cache_face): Treat size calculation overflows as if they were
272 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
273
274 * xfns.c (x_encode_text, x_set_name_internal)
275 (Fx_change_window_property): Use ptrdiff_t, not int, to count
276 sizes, since they can exceed INT_MAX in size. Check for size
277 calculation overflow.
278
0065d054
PE
279 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
280 (xg_select): Check for size calculation overflow.
726e0ab1
PE
281 Don't update size until alloc done.
282
0065d054 283 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 284 as sprintf is limited to int lengths.
1d526e2f 285
252c5ee1
PE
286 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
287 (X_LONG_MIN): New macros.
864d7ce7
PE
288 Use them to make the following changes clearer.
289 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
290 This change doesn't affect the value now, but it may help remind
291 future maintainers not to raise the value too much later.
292 (SELECTION_QUANTUM): Remove, replacing with ...
293 (selection_quantum): ... new function, which avoids overflow.
294 All uses changed.
295 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
296 assumption that selection length fits in 'int'.
297 (x_reply_selection_request, x_handle_selection_request)
298 (x_get_window_property, receive_incremental_selection)
299 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
300 (lisp_data_to_selection_data, clean_local_selection_data):
301 Use ptrdiff_t, not int, to record length of selection.
302 (x_reply_selection_request, x_get_window_property)
303 (receive_incremental_selection, x_property_data_to_lisp):
304 Redo calculations to avoid overflow.
305 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 306 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
307 something.
308 (x_get_window_property, receive_incremental_selection)
309 (lisp_data_to_selection_data, x_property_data_to_lisp):
310 Check for size-calculation overflow.
311 (x_get_window_property, receive_incremental_selection)
312 (lisp_data_to_selection_data, Fx_register_dnd_atom):
313 Don't store size until memory allocation succeeds.
314 (x_get_window_property): Plug memory leak on memory exhaustion.
315 Don't double-block input; malloc is safe here. Don't assume 2**34
316 - 4 fits in unsigned long. Add an xassert to check
317 XGetWindowProperty overflow. Be more careful about overflow
318 calculations, and distinguish size from memory overflow better.
319 (receive_incremental_selection): When tracing, don't assume
320 unsigned int is less than INT_MAX.
321 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
322 harmful) conversions of unsigned short to int.
323 (lisp_data_to_selection_data): Don't assume that integers
324 in the range -65535 through -1 fit in an X unsigned short.
325 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
326 result parameters unless successful. Rely on cons_to_unsigned
327 to report problems with elements; the old code wasn't right anyway.
328 (x_check_property_data): Check for int overflow; we cannot use
329 a wider type due to X limits.
330 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
331
726e0ab1 332 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 333
0065d054
PE
334 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
335 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
336 (x_color_cells): Don't store size until memory allocation succeeds.
337 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 338 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
339 (x_term_init): Don't assume length fits in int (sprintf is limited
340 to int size).
bc18e09d 341
ebfa62c0
PE
342 Use ptrdiff_t for composition IDs.
343 * character.c (lisp_string_width):
344 * composite.c (composition_table_size, n_compositions)
345 (get_composition_id, composition_gstring_from_id):
346 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
347 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
348 * window.c (Frecenter):
349 Use ptrdiff_t, not int, for composition IDs.
350 * composite.c (get_composition_id): Check for integer overflow.
351 * composite.h: Adjust prototypes to match the above changes.
352
d3411f89
PE
353 Use ptrdiff_t for hash table indexes.
354 * category.c (hash_get_category_set):
355 * ccl.c (ccl_driver):
356 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
357 * coding.c (coding_system_charset_list, detect_coding_system):
358 * coding.h (struct coding_system.id):
359 * composite.c (get_composition_id, gstring_lookup_cache):
360 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
361 * image.c (xpm_get_color_table_h):
362 * lisp.h (hash_lookup, hash_put):
363 * minibuf.c (Ftest_completion):
364 Use ptrdiff_t for hash table indexes, not int (which is too
365 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
366 32-bit --with-wide-int hosts).
367
e097a6fa
PE
368 * charset.c (Fdefine_charset_internal): Check for integer overflow.
369 Add a FIXME comment about memory leaks.
370 (syms_of_charset): Don't assume xmalloc returns.
371
5637687f
PE
372 Don't assume that stated character widths fit in int.
373 * character.c (Fchar_width, c_string_width, lisp_string_width):
374 * character.h (CHAR_WIDTH):
375 * indent.c (MULTIBYTE_BYTES_WIDTH):
376 Use sanitize_char_width to avoid undefined and/or bad behavior
377 with outlandish widths.
378 * character.h (sanitize_tab_width): Renamed from sanitize_width,
379 now that we have two such functions. All uses changed.
380 (sanitize_char_width): New inline function.
381
a2271ba2
PE
382 Don't assume that tab-width fits in int.
383 * character.h (sanitize_width): New inline function.
384 (SANE_TAB_WIDTH): New macro.
385 (ASCII_CHAR_WIDTH): Use it.
386 * indent.c (sane_tab_width): Remove. All uses replaced by
387 SANE_TAB_WIDTH (current_buffer).
388 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
389
18c52557
PE
390 * fileio.c: Integer overflow issues with file modes.
391 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
392
caeeedc1
PE
393 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
394 Remove unreachable code.
395 (read_hex, load_charset_map_from_file): Check for integer overflow.
396
50849c52
PE
397 * xterm.c: don't go over XClientMessageEvent limit
398 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
399 (x_send_scroll_bar_event): Likewise. Check that the size does not
400 exceed limits imposed by XClientMessageEvent, as well as the usual
401 ptrdiff_t and size_t limits.
402
b13995db
PE
403 * keyboard.c: Overflow, signedness and related fixes.
404 (make_lispy_movement): Use same integer type in forward decl
405 that is used in the definition.
406 (read_key_sequence, keyremap_step):
407 Change bufsize argument back to int, undoing my 2011-03-30 change.
408 We prefer signed types, and int is wide enough here.
409 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
410 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
411 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
412 length, not size_t. Use ptrdiff_t for index, not int.
413 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
414 possibility of integer overflow.
415
13464394
PE
416 Overflow, signedness and related fixes for images.
417
418 * dispextern.h (struct it.stack[0].u.image.image_id)
419 (struct_it.image_id, struct image.id, struct image_cache.size)
420 (struct image_cache.used, struct image_cache.ref_count):
421 * gtkutil.c (update_frame_tool_bar):
422 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
423 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
424 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
425 * nsmenu.m (update_frame_tool_bar):
426 * xdisp.c (calc_pixel_width_or_height):
427 * xfns.c (image_cache_refcount):
428 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
429 on typical 64-bit hosts.
430
431 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
432 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
433 Omit unnecessary casts to int.
434 (parse_image_spec): Check that integers fall into 'int' range
435 when the callers expect that.
436 (image_ascent): Redo ascent calculation to avoid int overflow.
437 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
438 (lookup_image): Remove unnecessary tests.
439 (xbm_image_p): Locals are now of int, not EMACS_INT,
440 since parse_image_check makes sure they fit into int.
441 (png_load, gif_load, svg_load_image):
442 Prefer int to unsigned where either will do.
443 (tiff_handler): New function, combining the cores of the
444 old tiff_error_handler and tiff_warning_handler. This
445 function is rewritten to use vsnprintf and thereby avoid
446 stack buffer overflows. It uses only the features of vsnprintf
447 that are common to both POSIX and native Microsoft.
448 (tiff_error_handler, tiff_warning_handler): Use it.
449 (tiff_load, gif_load, imagemagick_load_image):
450 Don't assume :index value fits in 'int'.
451 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
452 (imagemagick_load_image): Check that crop parameters fit into
453 the integer types that MagickCropImage accepts. Don't assume
454 Vimagemagick_render_type has a nonnegative value. Don't assume
455 size_t fits in 'long'.
456 (gs_load): Use printmax_t to print the widest integers possible.
457 Check for integer overflow when computing image height and width.
458
c11821d4
EZ
4592011-08-26 Eli Zaretskii <eliz@gnu.org>
460
461 * xdisp.c (redisplay_window): Don't force window start if point
462 will be invisible in the resulting window. (Bug#9324)
463
0c95fcf7
EZ
4642011-08-25 Eli Zaretskii <eliz@gnu.org>
465
466 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
467 the display spec is of the form `(space ...)'.
468 (handle_display_spec): Return the value returned by
469 handle_single_display_spec, not just 1 or zero.
470 (handle_single_display_spec): If the display spec is of the form
471 `(space ...)', and specifies display in the text area, return 2
472 rather than 1.
fee65a97 473 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
474 accurately, and prefer exact match for point under bidi. Don't
475 advance `row' beyond the last row of the window.
0c95fcf7
EZ
476
477 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
478 into disp_prop; all users changed.
479
480 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
481 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
482 for the text covered by the display property.
483
e4ed06f1
CY
4842011-08-25 Chong Yidong <cyd@stupidchicken.com>
485
486 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
487 Change return value to nil.
488 (Frecord_buffer): Delete unused function.
489
f67cdd7f
EZ
4902011-08-24 Eli Zaretskii <eliz@gnu.org>
491
5980d4c6
EZ
492 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
493 buffers, return left-to-right.
8610fe8b
EZ
494 (set_cursor_from_row): Consider candidate row a win if its glyph
495 represents a newline and point is on that newline. Fixes cursor
496 positioning on the newline at EOL of R2L text within L2R
497 paragraph, and vice versa.
498 (try_cursor_movement): Check continued rows, in addition to
499 continuation rows. Fixes unwarranted scroll when point enters a
500 continued line of R2L text within an L2R paragraph, or vice versa.
501 (cursor_row_p): Consider the case of point being equal to
502 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
503 from the end of a short line to the beginning of a continued line
504 of R2L text within L2R paragraph.
505 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
506 composed characters.
5980d4c6 507
f67cdd7f
EZ
508 * bidi.c (bidi_check_type): Use xassert.
509 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
510 members.
511
bca633fb
EZ
5122011-08-23 Eli Zaretskii <eliz@gnu.org>
513
514 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
515 a character.
516
4a5885a7
CY
5172011-08-23 Chong Yidong <cyd@stupidchicken.com>
518
519 * nsfont.m (ns_otf_to_script): Fix typo.
520
0902a04e
KH
5212011-08-22 Kenichi Handa <handa@m17n.org>
522
523 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
524 extra slot even if the purpose is char-code-property-table.
525
1a2e6670
EZ
5262011-08-23 Eli Zaretskii <eliz@gnu.org>
527
8ddde651
EZ
528 * xdisp.c (redisplay_window): When computing centering_position,
529 account for the height of the header line. (Bug#8874)
530
425cc014
EZ
531 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
532 instead of CHAR_TO_BYTE. Fixes a crash when a completion
533 candidate is selected by the mouse, and that candidate has a
534 composed character under the mouse.
535
1a2e6670
EZ
536 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
537 coordinates reported by pos-visible-in-window-p for a composed
538 character in column zero.
539
8b76d6f8
SM
5402011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
541
542 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
543
dac347dd
EZ
5442011-08-22 Eli Zaretskii <eliz@gnu.org>
545
546 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
547 consider it a hit if to_charpos is anywhere in the range of the
548 composed buffer positions.
549
e013fb34
CY
5502011-08-22 Chong Yidong <cyd@stupidchicken.com>
551
552 * image.c (gif_load): Don't assume that each subimage has the same
553 dimensions as the base image. Handle disposal method that is
554 "undefined" by the gif spec (Bug#9335).
555
bd1ba3e8
CY
5562011-08-20 Chong Yidong <cyd@stupidchicken.com>
557
558 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 559 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 560
54a1215b
EZ
5612011-08-19 Eli Zaretskii <eliz@gnu.org>
562
823564e5
EZ
563 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
564 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
565 from an Org mode buffer to a Speedbar frame.
566
54a1215b
EZ
567 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
568 a composition, take its buffer position from IT->cmp_it.charpos.
569 Fixes cursor positioning at the beginning of a line that begins
570 with a composed character.
571
9778ebcc
EZ
5722011-08-18 Eli Zaretskii <eliz@gnu.org>
573
0be6ee06
EZ
574 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
575 character bidirectional type, use STRONG_L instead. Fixes crashes
576 in a buffer produced by `describe-categories'.
577
9778ebcc
EZ
578 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
579 members before the level stack, so they would be saved and
580 restored when copying iterator state. Fixes incorrect reordering
581 around TABs covered by display properties.
582
156bffbe
AS
5832011-08-18 Andreas Schwab <schwab@linux-m68k.org>
584
585 * process.c (Fnetwork_interface_list): Correctly determine buffer
586 size.
587
72ad093b
CY
5882011-08-17 Chong Yidong <cyd@stupidchicken.com>
589
590 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
591 (internal_condition_case_2, internal_condition_case_n):
592 Remove unnecessary aborts (Bug#9081).
72ad093b 593
35774242
EZ
5942011-08-17 Eli Zaretskii <eliz@gnu.org>
595
596 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
597 has no `load' handler, try opening the file locally. (Bug#9311)
598
db76dd85
KB
5992011-08-16 Ken Brown <kbrown@cornell.edu>
600
601 * gmalloc.c: Expand comment.
602
b215eee5
EZ
6032011-08-16 Eli Zaretskii <eliz@gnu.org>
604
605 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
606 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
607
a4579d33
KB
6082011-08-16 Ken Brown <kbrown@cornell.edu>
609
610 Fix memory allocation problems in Cygwin build (Bug#9273).
611
612 * unexcw.c ( __malloc_initialized): Declare external variable.
613 (fixup_executable): Force the dumped emacs to reinitialize malloc.
614
8b76d6f8
SM
615 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
616 New variables.
a4579d33
KB
617 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
618 dumped emacs.
619 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
620 in the static heap.
621 [CYGWIN] (special_realloc): New function.
622 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
623 requests to realloc storage in the static heap.
624
3ebec551
PE
6252011-08-15 Paul Eggert <eggert@cs.ucla.edu>
626
627 * bidi.c (bidi_initialize): Remove unused local.
628
9fd8be00
EZ
6292011-08-15 Eli Zaretskii <eliz@gnu.org>
630
474a8465
EZ
631 * biditype.h: File removed.
632
633 * bidimirror.h: File removed.
634
635 * deps.mk (bidi.o): Remove biditype.h and
636 bidimirror.h.
637
638 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
639 bidimirror.h.
640
641 * dispextern.h: Fix a typo in the comment to bidi_type_t.
642
643 * chartab.c: Improve commentary for the uniprop_table API.
644
32413314
EZ
645 * bidi.c (bidi_paragraph_init): Support zero value of
646 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
647 (bidi_initialize): Use uniprop_table instead of including
648 biditype.h and bidimirror.h.
32413314 649
9fd8be00
EZ
650 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
651 coordinates of the iterator when restoring from ppos_it.
652 (Bug#9296)
653
5cf2b69b
KH
6542011-08-14 Kenichi Handa <handa@m17n.org>
655
656 * process.c (create_process): Call setup_process_coding_systems
72ad093b 657 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 658
daf17d00
EZ
6592011-08-14 Eli Zaretskii <eliz@gnu.org>
660
661 * xdisp.c (move_it_in_display_line_to): Don't invoke
662 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
663 ppos_it. Fixes vertical cursor motion when line beginning is
664 covered by an image. (Bug#9296)
665
08e3161a
JD
6662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
667
668 * nsterm.h (ns_run_ascript): Declare.
669 (NSAPP_DATA2_RUNASSCRIPT): Define.
670
671 * nsfns.m (as_script, as_result, as_status): New static variables.
672 (ns_run_ascript): New function.
673 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
674 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
675 the event loop. Get status from as_status (Bug#7276).
676
677 * nsterm.m (sendEvent): If event is NSApplicationDefined and
678 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
679 the event loop (Bug#7276).
680
a3720aa2
AS
6812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
682
683 * gnutls.c (QCgnutls_bootprop_priority)
684 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
685 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
686 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
687 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
688 (QCgnutls_bootprop_verify_hostname_error)
689 (QCgnutls_bootprop_callbacks_verify): Rename from
690 Qgnutls_bootprop_..., all uses changed.
691
692 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
693 uses changed.
694
0a0d27fb
PE
6952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
696
19d5c50c
PE
697 * xfaces.c (Qframe_set_background_mode): Now static.
698 * dispextern.h (Qframe_set_background_mode): Remove decl.
699
0a0d27fb
PE
700 * process.c (Fnetwork_interface_info): Declare local only if needed.
701
377538cb
JD
7022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
703
704 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
705 (Fnetwork_interface_list): Allocate in increments of bytes instead
706 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
707 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
708 sockaddr.
709 (struct ifflag_def): notrailers is smart on OSX.
710 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
711 Get hardware address with getifaddrs if available.
712
08fff70c
EZ
7132011-08-12 Eli Zaretskii <eliz@gnu.org>
714
715 * xdisp.c (iterate_out_of_display_property): xassert that
716 IT->position is set to within IT->object's boundaries. Break from
717 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
718 when IT->position is set up wrongly due to some bug.
719 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
720 (push_display_prop): Allow GET_FROM_STRING as IT->method on
721 entry. Force push_it to save on the stack the current
722 buffer/string position, to be restored by pop_it. Fix flags in
723 the iterator structure wrt the object coming from a display
724 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
725 properties. (Bug#9284)
726
7be1c708 7272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 728
7be1c708
CY
729 * fontset.c (fontset_get_font_group): Add proper type checks.
730 (Bug#9172)
aac0c6e3 731
7be1c708 7322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 733
7be1c708
CY
734 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
735 and LC_VERSION_MIN_MACOSX.
736 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
737 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 738
97bb72a6
EZ
7392011-08-08 Eli Zaretskii <eliz@gnu.org>
740
741 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
742 no-display-properties-and-no-overlays under bidi display.
743 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 744 properties and overlays.
97bb72a6 745
d5617611
CY
7462011-08-08 Chong Yidong <cyd@stupidchicken.com>
747
37e11a63
CY
748 * editfns.c (Fset_time_zone_rule): Document relationship with the
749 setenv function.
750
d5617611
CY
751 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
752 the font entity extracted from the cache (Bug#8109).
753
58872834
CY
7542011-08-07 Chong Yidong <cyd@stupidchicken.com>
755
756 * composite.c (autocmp_chars): Don't reset point. That is done by
757 restore_point_unwind (Bug#5984).
758
75bfc667
JL
7592011-08-07 Juri Linkov <juri@jurta.org>
760
761 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
762 to show the arg `TIME' instead of `TIMEVAL'.
763
d1410150
EZ
7642011-08-06 Eli Zaretskii <eliz@gnu.org>
765
766 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
767 display property strides EOL and includes a newline, as in
768 longlines-mode. (Bug#9254)
75b771e4
EZ
769 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
770 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
771
772 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
773 is non-zero, even if the data buffer is NULL. Fixes a crash in
774 vertical-motion with longlines-mode. (Bug#9254)
775
35928349
EZ
7762011-08-05 Eli Zaretskii <eliz@gnu.org>
777
ec7cc85b
EZ
778 * bidi.c <bidi_cache_total_alloc>: Now static.
779 (bidi_initialize): Initialize bidi_cache_total_alloc.
780
8b76d6f8 781 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
782 cache. (Bug#9221)
783
784 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
785 amount allocated this far in `bidi_cache_total_alloc'.
786 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
787 non-zero, only free the data buffer without restoring the cache
788 contents. All callers changed.
789
790 * dispextern.h (bidi_unshelve_cache): Update prototype.
791
792 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
793 (move_it_in_display_line, move_it_to)
794 (move_it_vertically_backward, move_it_by_lines): Replace the call
795 to xfree to an equivalent call to bidi_unshelve_cache.
796 (move_it_in_display_line_to): Fix logic of returning
412b6358 797 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 798
e2e2423b
EZ
7992011-08-05 Eli Zaretskii <eliz@gnu.org>
800
801 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
802 came from a string character with a `cursor' property. (Bug#9229)
803
ae9e757a
JD
8042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
805
806 * Makefile.in (LIB_PTHREAD): New variable.
807 (LIBES): Add LIB_PTHREAD (Bug#9216).
808
809 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
810 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
811
213bd7f2
AS
8122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
813
814 * regex.c (re_iswctype): Remove some redundant boolean
815 conversions.
816
99aaf75f
JD
8172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
818
819 * xterm.c (x_find_topmost_parent): New function.
820 (x_set_frame_alpha): Find topmost parent window with
821 x_find_topmost_parent and set the property there also (bug#9181).
822 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
823
c74e9d86
PE
8242011-08-04 Paul Eggert <eggert@cs.ucla.edu>
825
826 * callproc.c (Fcall_process): Avoid vfork clobbering
827 the local vars buffer, coding_systems, current_dir.
828
640c8776
SM
8292011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
830
831 * keymap.c (Fmake_composed_keymap): Move to subr.el.
832
f26d0e4c
PE
8332011-08-03 Paul Eggert <eggert@cs.ucla.edu>
834
8a10d76c
PE
835 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
836 so that it is not optimized away.
837
f26d0e4c
PE
838 * xdisp.c (compute_display_string_pos): Remove unused local.
839
55439c61
EZ
8402011-08-02 Eli Zaretskii <eliz@gnu.org>
841
842 Fix slow cursor motion and scrolling in large buffers with
843 selective display, like Org Mode buffers. (Bug#9218)
844
845 * dispextern.h (struct bidi_it): New member disp_prop_p.
846
847 * xdisp.c: Remove one-slot cache of display string positions.
848 (compute_display_string_pos): Accept an additional argument
849 DISP_PROP_P; callers changed. Scan at most 5K characters forward
850 for a display string or property. If found, set DISP_PROP_P
851 non-zero.
852
853 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
854 DISP_PROP_P, and pass it to compute_display_string_pos.
855 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
856 non-zero. All callers of bidi_fetch_char changed.
857
fb33fa43
SM
8582011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
859
860 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
861
b099e063
DM
8622010-12-03 Don March <don@ohspite.net>
863
864 * keymap.c (Fdefine_key): Fix non-prefix key error message when
865 last character M-[char] is translated to ESC [char] (bug#7541).
866
5cc7f7af
KH
8672011-08-02 Kenichi Handa <handa@m17n.org>
868
d0fffa3f 869 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
870
871 * chartab.c (uniprop_table): Make it non-static.
872
525d5e6e
EZ
8732011-08-01 Eli Zaretskii <eliz@gnu.org>
874
875 * xdisp.c (forward_to_next_line_start): Accept additional argument
876 BIDI_IT_PREV, and store into it the state of the bidi iterator had
877 on the newline.
878 (reseat_at_next_visible_line_start): Use the bidi iterator state
879 returned by forward_to_next_line_start to restore the state of
880 it->bidi_it after backing up to previous newline. (Bug#9212)
881
31011111
AS
8822011-07-30 Andreas Schwab <schwab@linux-m68k.org>
883
884 * regex.c (re_comp): Protoize.
885 (re_exec): Fix return type.
886 (regexec): Fix type of `ret'. (Bug#9203)
887
e5d76069
PE
8882011-07-29 Paul Eggert <eggert@cs.ucla.edu>
889
890 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
891 This is needed if max-image-size is a floating-point number.
892
9a79b20c
AS
8932011-07-28 Andreas Schwab <schwab@linux-m68k.org>
894
895 * print.c (print_object): Print empty symbol as ##.
896
897 * lread.c (read1): Read ## as empty symbol.
898
d8c2fa78
AA
8992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
900
901 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
902 setting frame foreground color (Bug#9175).
903 (x_set_background_color): Likewise.
904
ffe57a7a
AA
905 * nsmenu.m (-setText): Size tooltip dimensions precisely to
906 contents (Bug#9176).
907 (EmacsTooltip -init): Remove bezels and add shadows to
908 tooltip windows.
909
bf3492a5
AA
910 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
911 or scroll bar (Bug#8470).
912
d55e9c53
AA
913 * nsfont.m (nsfont_open): Remove assignment to voffset and
914 unnecessary vars hshink, expand, hd, full_height, min_height.
915 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
916
917 * nsterm.h (nsfont_info): Remove voffset field.
918
d8c2fa78 9192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
920
921 Implement strike-through and overline on NextStep (Bug#8863).
922
923 * nsfont.m (nsfont_open): Use underline position provided by font,
924 instead of hard-coded value of 2.
925 (nsfont_draw): Call ns_draw_text_decoration instead.
926
927 * nsterm.h: Add declaration for ns_draw_text_decoration.
928
929 * nsterm.m (ns_draw_text_decoration): New function for drawing
930 underline, overline, and strike-through.
931 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
932 ns_draw_text_decoration. Change treatment of cursor drawing to
933 accomodate underlining, etc.
934
4cc60b9b
EZ
9352011-07-28 Eli Zaretskii <eliz@gnu.org>
936
bc7ece87
EZ
937 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
938 default.
4cc60b9b 939
476371c4
PE
9402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
941
66606eea
PE
942 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
943 Without this fix, if a signal arrives just after memory fills up,
944 'malloc' might be invoked reentrantly.
945
476371c4
PE
946 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
947 In other words, assume that every image size is allowed, on non-X
948 hosts. This assumption is probably wrong, but it lets Emacs compile.
949
f3fcc40d
AS
9502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
951
952 * regex.c (re_iswctype): Convert return values to boolean.
953
350c992f
EZ
9542011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
955
956 * xdisp.c (compute_display_string_pos): Don't use cached display
957 string position if the buffer had its restriction changed.
958 (Bug#9184)
959
5266b4bb
PE
9602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
961
962 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
963
2573a837 9642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 965
41f55ccd 966 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 967
39e378da
PE
968 * bidi.c: Integer size and overflow fixes.
969 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
970 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
971 (bidi_cache_find_level_change, bidi_cache_ensure_space)
972 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
973 (bidi_find_other_level_edge):
974 Use ptrdiff_t instead of EMACS_INT where either will do.
975 This works better on 32-bit hosts configured --with-wide-int.
976 (bidi_cache_ensure_space): Check for size-calculation overflow.
977 Use % rather than repeated addition, for better worst-case speed.
978 Don't set bidi_cache_size until after xrealloc returns, because it
979 might not return.
980 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
981 (bidi_cache_ensure_space): Also check that the bidi cache size
982 does not exceed that of the largest Lisp string or buffer. See Eli
983 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 984
5e927815
PE
985 * alloc.c (__malloc_size_t): Remove.
986 All uses replaced by size_t. See Andreas Schwab's note
987 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
988
ca4aa935
PE
989 * image.c: Improve checking for integer overflow.
990 (check_image_size): Assume that f is nonnull, since
991 it is always nonnull in practice. This is one less thing to
992 worry about when checking for integer overflow later.
993 (x_check_image_size): New function, which checks for integer
994 overflow issues inside X.
995 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
996 This removes the need for a memory_full check.
997 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
998 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
999 (xbm_read_bitmap_data): Change locals back to 'int', since
1000 their values must fit in 'int'.
1001 (xpm_load_image, png_load, tiff_load):
1002 Invoke x_create_x_image_and_pixmap earlier,
1003 to avoid much needless work if the image is too large.
1004 (tiff_load): Treat overly large images as if
1005 x_create_x_image_and_pixmap failed, not as malloc failures.
1006 (gs_load): Use x_check_image_size.
1007
5f8f9cc2
PE
1008 * gtkutil.c: Omit integer casts.
1009 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1010 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1011
5adf60bc
PE
1012 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1013
c8907a93
PE
1014 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1015 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1016 would wrongly return t on a 64-bit host.
1017
e3c25c68
PE
1018 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1019 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1020 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1021 and therefore cause GCC to emit a bogus diagnostic in some cases.
1022
3f791afe
PE
1023 * image.c: Integer signedness and overflow and related fixes.
1024 This is not an exhaustive set of fixes, but it's time to
1025 record what I've got.
1026 (lookup_pixel_color, check_image_size): Remove redundant decls.
1027 (check_image_size): Don't assume that arbitrary EMACS_INT values
1028 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1029 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1030 (tiff_load, imagemagick_load_image):
1031 Check for overflow in size calculations.
1032 (x_create_x_image_and_pixmap): Remove unnecessary test for
1033 xmalloc returning NULL; that can't happen.
1034 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1035 (xpm_color_bucket): Use better integer hashing function.
1036 (xpm_cache_color): Don't possibly over-allocate memory.
1037 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1038 (gif_memory_source):
1039 Use ptrdiff_t, not int or size_t, to record sizes.
1040 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1041 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1042 either works, as we prefer signed integers.
1043 (tiff_read_from_memory, tiff_write_from_memory):
1044 Return tsize_t, not size_t, since that's what the TIFF API wants.
1045 (tiff_read_from_memory): Don't fail simply because the read would
1046 go past EOF; instead, return a short read.
1047 (tiff_load): Omit no-longer-needed casts.
1048 (Fimagemagick_types): Don't assume size fits into 'int'.
1049
3cc5a532
PE
1050 Improve hashing quality when configured --with-wide-int.
1051 * fns.c (hash_string): New function, taken from sxhash_string.
1052 Do not discard information about ASCII character case; this
1053 discarding is no longer needed.
1054 (sxhash-string): Use it. Change sig to match it. Caller changed.
1055 * lisp.h: Declare it.
1056 * lread.c (hash_string): Remove, since we now use fns.c's version.
1057 The fns.c version returns a wider integer if --with-wide-int is
1058 specified, so this should help the quality of the hashing a bit.
1059
b312a492
PE
1060 * emacs.c: Integer overflow minor fix.
1061 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1062 Define only if GNU_LINUX.
1063 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1064
dfd153ae
PE
1065 * dispnew.c: Integer signedness and overflow fixes.
1066 Remove unnecessary forward decls, that were a maintenance hassle.
1067 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1068 All uses changed.
1069 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1070 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1071 (prepare_desired_row, line_draw_cost):
1072 Use int, not unsigned, where either works.
1073 (save_current_matrix, restore_current_matrix):
1074 Use ptrdiff_t, not size_t, where either works.
1075 (init_display): Check for overflow more accurately, and without
1076 relying on undefined behavior.
1077
a81d11a3
PE
1078 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1079 Remove, replacing with the new symbols in lisp.h. All uses changed.
1080 * fileio.c (make_temp_name):
1081 * filelock.c (lock_file_1, lock_file):
1082 * xdisp.c (message_dolog):
1083 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1084 Use pMd etc. instead.
1085 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1086 replacing the pWIDE etc. symbols removed from editfns.c.
1087
3300e6fd
PE
1088 * keyboard.h (num_input_events): Now uintmax_t.
1089 This is (very slightly) less likely to mess up due to wraparound.
1090 All uses changed.
1091
fd05c7e9
PE
1092 * buffer.c: Integer signedness fixes.
1093 (alloc_buffer_text, enlarge_buffer_text):
1094 Use ptrdiff_t rather than size_t when either will do, as we prefer
1095 signed integers.
1096
903fe15d
PE
1097 * alloc.c: Integer signedness and overflow fixes.
1098 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1099 (__malloc_size_t): Default to size_t, not to int.
1100 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1101 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1102 Prefer ptrdiff_t to size_t when either would do, as we prefer
1103 signed integers.
1104 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1105 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1106 Now const. Initialize with values that are in range even if char
1107 is signed.
1108 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1109 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1110 These functions do the right thing with sizes > 2**32.
1111 (check_depth): Now ptrdiff_t, not int.
1112 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1113 Adjust to new way of storing sizes. Check for size overflow bugs
1114 in rest of code.
1115 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1116 slightly wrong anyway, as it missed one instance of
1117 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1118 (refill_memory_reserve): Omit needless cast to size_t.
1119 (mark_object_loop_halt): Mark as externally visible.
1120
ac82cc6a
PE
1121 * xselect.c: Integer signedness and overflow fixes.
1122 (Fx_register_dnd_atom, x_handle_dnd_message):
1123 Use ptrdiff_t, not size_t, since we prefer signed.
1124 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1125 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1126 x_dnd_atoms_size and x_dnd_atoms_length.
1127
c2d1e36d
PE
1128 * doprnt.c: Prefer signed to unsigned when either works.
1129 * eval.c (verror):
1130 * doprnt.c (doprnt):
1131 * lisp.h (doprnt):
1132 * xdisp.c (vmessage):
1133 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1134 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1135 prefer signed arithmetic to avoid comparison confusion.
1136 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1137 but is a bit tricky.
1138
0e926e56
PE
1139 Assume freestanding C89 headers, string.h, stdlib.h.
1140 * data.c, doprnt.c, floatfns.c, print.c:
1141 Include float.h unconditionally.
1142 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1143 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1144 * regex.c: Likewise for stddef.h, string.h.
1145 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1146 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1147 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1148 (STDC_HEADERS): Remove obsolete defines.
1149 * sysdep.c: Include limits.h unconditionally.
1150
9cfdb3ec
PE
1151 Assume support for memcmp, memcpy, memmove, memset.
1152 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1153 * regex.c (memcmp, memcpy):
1154 Remove; we assume C89 now.
1155
1156 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1157 (__malloc_safe_bcopy): Remove; no longer needed.
1158
cf950e6b 1159 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1160 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1161 well either way, and we prefer signed to unsigned.
1162
dbf38e02
LMI
11632011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1164
1165 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1166 closes the connection while we're reading (bug#9182).
1167
d6f0886c
JD
11682011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1169
1170 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1171 are specified (Bug#9168).
1172
2eb1f9e6
PE
11732011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1176 Found by GCC static checking and --with-wide-int on a 32-bit host.
1177
22381272 11782011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1179
1180 * xdisp.c (compute_display_string_pos): Fix logic of caching
1181 previous display string position. Initialize cached_prev_pos to
1182 -1. Fixes slow-down at the beginning of a buffer.
1183
f25e39b4
EZ
11842011-07-24 Eli Zaretskii <eliz@gnu.org>
1185
1186 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1187 for attrs[LFACE_FONTSET_INDEX].
1188
04c4b52e
PE
11892011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 * xml.c (parse_region): Remove unused local
1192 that was recently introduced.
1193
c1734fbd
EZ
11942011-07-23 Eli Zaretskii <eliz@gnu.org>
1195
be18c5a5
EZ
1196 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1197 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1198
c1734fbd
EZ
1199 * xdisp.c (move_it_in_display_line_to): Record the best matching
1200 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1201 exit if none of the characters scanned was an exact match.
1202 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1203 when exact match is impossible due to invisible text, and the
1204 lines are truncated.
1205
a258d627
JD
12062011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1207
1208 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1209 for OSX >= 10.7.
1210
b6d5a689
EZ
12112011-07-22 Eli Zaretskii <eliz@gnu.org>
1212
0f74f785
EZ
1213 Fix a significant slow-down of cursor motion with C-n, C-p,
1214 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1215 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1216 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1217 (next_element_from_buffer): Call compute_stop_pos_backwards to
1218 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1219 base_level_stop.
1220 (reseat): Don't look for prev_stop, as that could mean a very long
1221 run.
1222 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1223 <cached_disp_overlay_modiff>: Cache for last found display string
1224 position.
551918c1 1225 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1226 about the same buffer in the same area of character positions, and
1227 the buffer wasn't changed since the time the display string
1228 position was cached.
551918c1 1229
b2d0c91a
EZ
12302011-07-22 Eli Zaretskii <eliz@gnu.org>
1231
1232 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1233 is an integer, which is important for empty lines. (Bug#9149)
1234
043604ee
CY
12352011-07-22 Chong Yidong <cyd@stupidchicken.com>
1236
1237 * frame.c (Fmodify_frame_parameters): In tty case, update the
1238 default face if necessary (Bug#4238).
1239
da4adb04
CY
12402011-07-21 Chong Yidong <cyd@stupidchicken.com>
1241
1242 * editfns.c (Fstring_to_char): No need to explain what a character
1243 is in the docstring (Bug#6576).
1244
9abd0532
LMI
12452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1246
1247 * xml.c (parse_region): Make sure we always return a tree.
1248
36881d16
HK
12492011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1250
1251 * xml.c (parse_region): If a document contains only comments,
1252 return that, too.
1253
1e98674d
LMI
12542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1255
1256 * xml.c (make_dom): Return comments, too.
1257
590bd467
PE
12582011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 Port to OpenBSD.
1261 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1262 and the surrounding thread.
1263 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1264 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1265 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1266 timer goes off.
1267 * s/openbsd.h (BROKEN_SIGIO): Define.
1268 * unexelf.c (unexec) [__OpenBSD__]:
1269 Don't update the .mdebug section of the Alpha COFF symbol table.
1270
f41628b2
LMI
12712011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1272
1273 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1274 (bug#8460).
1275
b59b67c5
PE
12762011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1277
15e3a074
PE
1278 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1279 This fixes some race conditions on the permissions of any newly
1280 created file.
1281
41bed37d
PE
1282 * alloc.c (valid_pointer_p): Use pipe, not open.
1283 This fixes some permissions issues when debugging.
1284
b59b67c5
PE
1285 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1286 If fchown fails to set both uid and gid, try to set just gid,
1287 as that is sometimes allowed. Adjust the file's mode to eliminate
1288 setuid or setgid bits that are inappropriate if fchown fails.
1289
925a6be7
SM
12902011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1291
1292 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1293 to compare Lisp_Objects.
1294 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1295 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1296 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1297
52968808
AS
12982011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1299
0a6a104b
AS
1300 * lread.c (read_integer): Unread even EOF character.
1301 (read1): Likewise. Properly record start position of symbol.
1302
52968808
AS
1303 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1304 symbol character follows.
1305
9e381cdd
PE
13062011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1309 This works around a problem with the previous change to Fcopy_file.
1310 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1311 and without this change, GCC might complain about discarding
1312 fchown's return value.
1313
b5641435
JB
13142011-07-16 Juanma Barranquero <lekktu@gmail.com>
1315
1316 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1317
a8031457
PE
13182011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1321
dd889327
LMI
13222011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1323
750c33f7
LMI
1324 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1325 it's used from the C level.
1326
dd889327
LMI
1327 * process.c: Use the same condition for POLL_FOR_INPUT in both
1328 keyboard.c and process.c (bug#1858).
1329
87e86684
LM
13302011-07-09 Lawrence Mitchell <wence@gmx.li>
1331
1332 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1333 (Fgnutls_boot): Use it.
1334
64348f40
AS
13352011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1336
1337 * doc.c (Fsubstitute_command_keys): Revert last change.
1338
1d698799
LMI
13392011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1340
f863868c
LMI
1341 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1342 quotes the next character, and doesn't affect other longer
1343 sequences (bug#8935).
1344
1d698799
LMI
1345 * lread.c (syms_of_lread): Clarify that is isn't only
1346 `eval-buffer' and `eval-defun' that's affected by
1347 `lexical-binding' (bug#8460).
1348
aa4b6df6
EZ
13492011-07-15 Eli Zaretskii <eliz@gnu.org>
1350
1351 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1352 bidi redisplay when a line includes both an image and is
1353 truncated.
1354
5d856da6
PE
13552011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1356
ad6042bb
PE
1357 Fix minor problems found by static checking.
1358 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1359 (elsz): Now a signed constant, not a size_t var. We prefer signed
1360 types to unsigned, to avoid integer comparison confusion. Without
1361 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1362 "cannot optimize loop, the loop counter may overflow", a symptom
1363 of the confusion.
f00bbb22 1364 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1365 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1366
6468f31c
LMI
13672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1368
49080b10
LMI
1369 * search.c (Fre_search_backward): Mention `case-fold-search' in
1370 all the re_search_* functions (bug#8138).
1371
6468f31c
LMI
1372 * keyboard.c (Fopen_dribble_file): Document when the file is
1373 closed (bug#8056).
1374
c965adc5
EZ
13752011-07-14 Eli Zaretskii <eliz@gnu.org>
1376
df9733bf
EZ
1377 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1378 bidi_cache_idx.
1379
0bb23927
EZ
1380 Support bidi reordering of display and overlay strings.
1381 * xdisp.c (compute_display_string_pos)
1382 (compute_display_string_end): Accept additional argument STRING.
1383 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1384 (reseat_to_string): Initialize bidi_it->string.s and
1385 bidi_it->string.schars.
1386 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1387 NULL (avoids a crash in bidi_paragraph_init).
1388 Initialize itb.string.lstring.
0bb23927
EZ
1389 (init_iterator): Call bidi_init_it only of a valid
1390 buffer position was specified. Initialize paragraph_embedding to
1391 L2R.
1392 (reseat_to_string): Initialize the bidi iterator.
1393 (display_string): If we need to ignore text properties of
1394 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1395 original value of -1 will not work with bidi.)
1396 (compute_display_string_pos): First arg is now struct
1397 `text_pos *'; all callers changed. Support display properties on
1398 Lisp strings.
1399 (compute_display_string_end): Support display properties on Lisp
1400 strings.
1401 (init_iterator, reseat_1, reseat_to_string): Initialize the
1402 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1403 when iterating on a string not from display properties).
640c8776
SM
1404 (compute_display_string_pos, compute_display_string_end):
1405 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1406 arrow keys.
1407 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1408 base_level_stop; instead, set base_level_stop to BEGV.
1409 Fixes crashes in vertical-motion.
0bb23927
EZ
1410 (next_element_from_buffer): Improve commentary for when
1411 the iterator is before prev_stop.
1412 (init_iterator): Initialize bidi_p from the default value of
1413 bidi-display-reordering, not from buffer-local value. Use the
1414 buffer-local value only if initializing for buffer iteration.
1415 (handle_invisible_prop): Support invisible properties on strings
1416 that are being bidi-reordered.
1417 (set_iterator_to_next): Support bidi reordering of C strings and
1418 Lisp strings.
1419 (next_element_from_string): Support bidi reordering of Lisp
1420 strings.
1421 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1422 (display_string): Support display of R2L glyph rows.
1423 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1424 (init_iterator): Don't initialize it->bidi_p for strings
1425 here.
1426 (reseat_to_string): Initialize it->bidi_p for strings here.
1427 (next_element_from_string, next_element_from_c_string)
1428 (next_element_from_buffer): Add xassert's for correspondence
1429 between IT's object being iterated and it->bidi_it.string
1430 structure.
1431 (face_before_or_after_it_pos): Support bidi iteration.
1432 (next_element_from_c_string): Handle the case of the first string
1433 character that is not the first one in the visual order.
1434 (get_visually_first_element): New function, refactored from common
1435 parts of next_element_from_buffer, next_element_from_string, and
1436 next_element_from_c_string.
1437 (tool_bar_lines_needed, redisplay_tool_bar)
1438 (display_menu_bar): Force left-to-right direction. Add a FIXME
1439 comment for making that be controlled by a user option.
1440 (push_it, pop_it): Save and restore the state of the
1441 bidi iterator. Save and restore the bidi_p flag.
1442 (pop_it): Iterate out of display property for string iteration as
1443 well.
1444 (iterate_out_of_display_property): Support iteration over strings.
1445 (handle_single_display_spec): Set up it->bidi_it for iteration
1446 over a display string, and call bidi_init_it.
1447 (handle_single_display_spec, next_overlay_string)
1448 (get_overlay_strings_1, push_display_prop): Set up the bidi
1449 iterator for displaying display or overlay strings.
1450 (forward_to_next_line_start): Don't use the shortcut if
1451 bidi-iterating.
1452 (back_to_previous_visible_line_start): If handle_display_prop
1453 pushed the iterator stack, restore the internal state of the bidi
1454 iterator by calling bidi_pop_it same number of times.
1455 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1456 and we are bidi-iterating, don't decrement the iterator position;
1457 instead, set the first_elt flag in the bidi iterator, to produce
1458 the same effect.
1459 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1460 (push_display_prop): xassert that we are iterating a buffer.
1461 (push_it, pop_it): Save and restore paragraph_embedding member.
1462 (handle_single_display_spec, next_overlay_string)
1463 (get_overlay_strings_1, reseat_1, reseat_to_string)
1464 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1465 correctly. Don't assume unibyte strings are not bidi-reordered.
1466 (compute_display_string_pos)
1467 (compute_display_string_end): Fix handling the case of C string.
1468 (push_it, pop_it): Save and restore from_disp_prop_p.
1469 (handle_single_display_spec, push_display_prop): Set the
1470 from_disp_prop_p flag.
1471 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1472 (pop_it): Call iterate_out_of_display_property only if we are
1473 popping after iteration over a string that came from a display
1474 property. Fix a typo in popping stretch info. Add an assertion
1475 for verifying that the iterator position is in sync with the bidi
1476 iterator.
1477 (handle_single_display_spec, get_overlay_strings_1)
1478 (push_display_prop): Fix initialization of paragraph direction for
1479 string when that of the parent object is not yet determined.
1480 (reseat_1): Call bidi_init_it to resync the bidi
1481 iterator with IT's position. (Bug#7616)
1482 (find_row_edges): If ROW->start.pos gives position
1483 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1484 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1485 Reset the from_disp_prop_p flag.
1486 (SAVE_IT, RESTORE_IT): New macros.
1487 (pos_visible_p, face_before_or_after_it_pos)
1488 (back_to_previous_visible_line_start)
1489 (move_it_in_display_line_to, move_it_in_display_line)
1490 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1491 (try_scrolling, redisplay_window, display_line): Use them when
1492 saving a temporary copy of the iterator and restoring it back.
1493 (back_to_previous_visible_line_start, reseat_1)
1494 (init_iterator): Empty the bidi cache "stack".
1495 (move_it_in_display_line_to): If iterator ended up at
1496 EOL, but we never saw any buffer positions smaller than
1497 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1498 motion in bidi-reordered lines.
1499 (move_it_in_display_line_to): Record prev_method and prev_pos
1500 immediately before the call to set_iterator_to_next. Fixes cursor
1501 motion in bidi-reordered lines with stretch glyphs and strings
1502 displayed in margins. (Bug#8133) (Bug#8867)
1503 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1504 TO_CHARPOS.
640c8776
SM
1505 (pos_visible_p): Support positions in bidi-reordered lines.
1506 Save and restore bidi cache.
0bb23927
EZ
1507
1508 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1509 (bidi_paragraph_info): Delete unused struct.
1510 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1511 (bidi_cache_start): New variable.
1512 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1513 to zero.
1514 (bidi_cache_fetch_state, bidi_cache_search)
1515 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1516 (bidi_cache_find, bidi_peek_at_next_level)
1517 (bidi_level_of_next_char, bidi_find_other_level_edge)
1518 (bidi_move_to_visually_next): Compare cache index with
1519 bidi_cache_start rather than with zero.
1520 (bidi_fetch_char): Accept new argument STRING; all callers
1521 changed. Support iteration over a string. Support strings with
1522 display properties. Support unibyte strings. Fix the type of
1523 `len' according to what STRING_CHAR_AND_LENGTH expects.
1524 (bidi_paragraph_init, bidi_resolve_explicit_1)
1525 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1526 (bidi_level_of_next_char, bidi_move_to_visually_next):
1527 Support iteration over a string.
0bb23927
EZ
1528 (bidi_set_sor_type, bidi_resolve_explicit_1)
1529 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1530 can now be zero (for strings); special values 0 and -1 were
1531 changed to -1 and -2, respectively.
1532 (bidi_char_at_pos): New function.
1533 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1534 Call it instead of FETCH_MULTIBYTE_CHAR.
1535 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1536 initialized to valid values.
1537 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1538 values.
1539 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1540 the test for valid cached positions. Fix the logic for looking up
1541 the sentinel state in the cache. GCPRO the Lisp string we are
1542 iterating.
1543 (bidi_push_it, bidi_pop_it): New functions.
1544 (bidi_initialize): Initialize the bidi cache start stack pointer.
1545 (bidi_cache_ensure_space): New function, refactored from part of
1546 bidi_cache_iterator_state. Don't assume the required size is just
1547 one BIDI_CACHE_CHUNK away.
1548 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1549 (bidi_count_bytes, bidi_char_at_pos): New functions.
1550 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1551 always valid if bidi_cache_idx is valid.
1552 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1553 is valid if it's going to be used.
1554 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1555 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1556 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1557 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1558 (bidi_find_other_level_edge, bidi_cache_start_stack):
1559 All variables related to cache indices are now EMACS_INT.
c965adc5 1560
0bb23927
EZ
1561 * dispextern.h (struct bidi_string_data): New structure.
1562 (struct bidi_it): New member `string'. Make flag members be 1-bit
1563 fields, and put them last in the struct.
640c8776
SM
1564 (compute_display_string_pos, compute_display_string_end):
1565 Update prototypes.
0bb23927
EZ
1566 (bidi_push_it, bidi_pop_it): Add prototypes.
1567 (struct iterator_stack_entry): New members bidi_p,
1568 paragraph_embedding, and from_disp_prop_p.
1569 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1570 (bidi_shelve_cache, bidi_unshelve_cache):
1571 Declare prototypes.
0bb23927
EZ
1572
1573 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1574 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1575 and vector-like objects.
1576
1577 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1578 cache around display iteration.
1579
1580 * window.c (Fwindow_end, window_scroll_pixel_based)
1581 (displayed_window_lines, Frecenter): Save and restore the bidi
1582 cache around display iteration.
1583
3bbd2265
LMI
15842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1585
1586 * editfns.c (Fdelete_region): Clarify the use of the named
1587 parameters (bug#6788).
1588
adc47434
MR
15892011-07-14 Martin Rudalics <rudalics@gmx.at>
1590
1591 * indent.c (Fvertical_motion): Set and restore w->pointm when
1592 saving and restoring the window's buffer (Bug#9006).
1593
837c31f8
LMI
15942011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1595
1596 * editfns.c (Fstring_to_char): Clarify just what is returned
1597 (bug#6576). Text by Eli Zaretskii.
1598
ac389d0c
JB
15992011-07-13 Juanma Barranquero <lekktu@gmail.com>
1600
1601 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1602
0be0ce47
EZ
16032011-07-13 Eli Zaretskii <eliz@gnu.org>
1604
1605 * buffer.c (mmap_find): Fix a typo.
1606
cd18e7e3
JB
16072011-07-13 Johan Bockgård <bojohan@gnu.org>
1608
1609 Fix execution of x selection hooks.
1610 * xselect.c (Qx_lost_selection_functions)
1611 (Qx_sent_selection_functions): New vars.
1612 (syms_of_xselect): DEFSYM them.
1613 (x_handle_selection_request): Pass Qx_sent_selection_functions
1614 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1615 (x_handle_selection_clear,x_clear_frame_selections):
1616 Pass Qx_lost_selection_functions rather than
1617 Vx_lost_selection_functions to Frun_hook_with_args.
1618
47ea7f44
PE
16192011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1620
ac389d0c 1621 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1622 The old code sometimes used this field without initializing it.
1623
47ea7f44
PE
1624 * alloc.c (gc_sweep): Don't read past end of array.
1625 In theory, the old code could also have corrupted Emacs internals,
1626 though it'd be very unlikely.
1627
bc985c87
AS
16282011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1629
1630 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1631 argument. (Bug#4026)
bc985c87 1632
0cf34688
LMI
16332011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1634
b3dadd76
LMI
1635 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1636 key" (bug#4257).
1637
0cf34688
LMI
1638 * window.c (Fset_window_start): Doc fix (bug#4199).
1639 (Fset_window_hscroll): Ditto.
1640
270768cd
PE
16412011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1642
077e3dda 1643 Fix minor new problems caught by GCC 4.6.1.
270768cd 1644 * term.c (init_tty): Remove unused local.
490011a6 1645 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1646 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1647 not used otherwise.
270768cd 1648
b1f58454
CY
16492011-07-12 Chong Yidong <cyd@stupidchicken.com>
1650
1651 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1652
22b9578d
LMI
16532011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1654
6e70ab07
LMI
1655 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1656 are the mini-buffer and the echo area (bug#3320).
1657
22b9578d
LMI
1658 * term.c (init_tty): Remove support for supdup, c10 and perq
1659 terminals, which are no longer supported (bug#1482).
1660
8974cc9f
JB
16612011-07-10 Johan Bockgård <bojohan@gnu.org>
1662
1663 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1664
a560d974
JD
16652011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1666
1667 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1668 for non-popups (Bug#3642).
1669
1dae0f0a
AS
16702011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1671
268c2c36 1672 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1673 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1674 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1675 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1676 * data.c (fmod): Likewise.
1677 * dispnew.c (swap_glyphs_in_rows): Likewise.
1678 * emacs.c (memory_warning_signal): Likewise.
1679 * floatfns.c (float_error): Likewise.
1680 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1681 (otf_open, font_otf_capability, generate_otf_features)
1682 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1683 Likewise.
1684 * image.c (pbm_read_file): Likewise.
1685 * indent.c (string_display_width): Likewise.
1686 * intervals.c (check_for_interval, search_for_interval)
1687 (inc_interval_count, count_intervals, root_interval)
1688 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1689 * lread.c (defalias): Likewise.
268c2c36 1690 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1691 * regex.c (set_image_of_range_1, set_image_of_range)
1692 (regex_grow_registers): Likewise.
1693 * sysdep.c (strerror): Likewise.
1694 * termcap.c (valid_filename_p, tprint, main): Likewise.
1695 * tparam.c (main): Likewise.
1696 * unexhp9k800.c (run_time_remap, save_data_space)
1697 (update_file_ptrs, read_header, write_header, calculate_checksum)
1698 (copy_file, copy_rest, display_header): Likewise.
1699 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1700 Likewise.
1701 * xdisp.c (check_it): Likewise.
1702 * xfaces.c (register_color, unregister_color, unregister_colors):
1703 Likewise.
1704 * xfns.c (print_fontset_result): Likewise.
1705 * xrdb.c (member, fatal, main): Likewise.
1706
99033785
PE
17072011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 Fix minor problems found by static checking (Bug#9031).
1710 * chartab.c (char_table_set_range, map_sub_char_table):
1711 Remove unused locals.
1712 (uniprop_table): Now static.
1713 * composite.c (_work_char): Remove unused static var.
1714
9cb2ac56
JB
17152011-07-09 Juanma Barranquero <lekktu@gmail.com>
1716
1717 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1718
f25661f0
JD
17192011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1720
1721 * gtkutil.c (qttip_cb): Remove code without function.
1722
8278c4fe
EZ
17232011-07-09 Eli Zaretskii <eliz@gnu.org>
1724
1725 * w32.c (pthread_sigmask): New stub.
1726
1692ae2d 17272011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1728
8a6ebd58 1729 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1730 sigprocmask is portable only for single-threaded applications, and
1731 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1732 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1733 (LIBES): Use it.
1734 * callproc.c (Fcall_process):
1735 * process.c (create_process):
1736 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1737 Use pthread_sigmask, not sigprocmask.
123403e4 1738
1b854618
JD
17392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1740
1741 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1742 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1743 wrong (Bug#8591).
1744
3fe4b549
JD
17452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1746
0ce7e563
JD
1747 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1748 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1749 (xg_hide_tooltip): Fix comment.
1750
3fe4b549
JD
1751 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1752 in registerServicesMenuSendTypes.
1753 (validRequestorForSendType): Don't check ns_return_types.
1754
1755 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1756 ns_return_type.
1757
5df75e47
JR
17582011-07-08 Jason Rumney <jasonr@gnu.org>
1759
1760 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1761 frame struct members of non-existent frames (Bug#6284).
1762
699c10bd
JD
17632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1764
4393663b
JD
1765 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1766 variable firstTime not needed on OSX >= 10.6.
1767 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1768 >= 10.5. Use setKnobProportion, setDoubleValue.
1769
1770 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1771 (MAC_OS_X_VERSION_10_5): Define if not defined.
1772 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1773 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1774 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1775
1776 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1777 cString and lossyCString on OSX >= 10.4
1778
1779 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1780 sizeToFit on OSX >= 10.2.
1781
1782 * nsimage.m (allocInitFromFile): Don't use deprecated method
1783 bestRepresentationForDevice on OSX >= 10.6.
1784
1785 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1786 to avoid warning.
1787
1788 * emacs.c: Declare unexec_init_emacs_zone.
1789
a63e0781
JD
1790 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1791
699c10bd
JD
1792 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1793
1794 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1795 on svcsMenu (Bug#8842).
1796
1797 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1798 ns_return_types.
1799 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1800
1801 * nsterm.m (QUTF8_STRING): Declare.
1802 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1803 (validRequestorForSendType): Return type is (id).
1804 Change indexOfObjectIdenticalTo to indexOfObject.
1805 Check if we have local selection before returning self (Bug#8842).
1806 (writeSelectionToPasteboard): Put local selection into paste board
1807 if we have a local selection (Bug#8842).
1808 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1809
1810 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1811 (ns_get_local_selection): Declare.
1812
54e10184
LMI
18132011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1814
9888ff71
LMI
1815 * keymap.c (describe_map_tree): Don't insert a double newline at
1816 the end of the buffer (bug#1169) and return whether we inserted
1817 something.
1818
54e10184
LMI
1819 * callint.c (Fcall_interactively): Change "reading args" to
1820 "providing args" to try to clarify what it does (bug#1010).
1821
15fa4783
KH
18222011-07-07 Kenichi Handa <handa@m17n.org>
1823
1824 * composite.c (composition_compute_stop_pos): Ignore a static
1825 composition starting before CHARPOS (Bug#8915).
1826
1827 * xdisp.c (handle_composition_prop): Likewise.
1828
a8815b00
EZ
18292011-07-07 Eli Zaretskii <eliz@gnu.org>
1830
1831 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1832 (Bug#9015)
1833
ef7b981d 18342011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1835
1836 * character.h (unicode_category_t): New enum type.
1837
1838 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1839 (Qchar_code_property_table): New variable.
1840 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1841 (UNIPROP_COMPRESSED_FORM_P): New macros.
1842 (char_table_ascii): Uncompress the compressed values.
1843 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1844 Uncompress the compressed values.
ac389d0c 1845 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1846 (char_table_ref_and_range): Uncompress the compressed values.
1847 (sub_char_table_set): New arg is_uniprop. Callers changed.
1848 Uncompress the compressed values.
1849 (sub_char_table_set_range): Args changed. Callers changed.
1850 (char_table_set_range): Adjuted for the above change.
1851 (map_sub_char_table): Delete args default_val and parent. Add arg
1852 top. Give decoded values to a Lisp function.
640c8776 1853 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1854 values to a Lisp function. Gcpro more variables.
1855 (uniprop_table_uncompress)
1856 (uniprop_decode_value_run_length): New functions.
1857 (uniprop_decoder, uniprop_decoder_count): New variables.
1858 (uniprop_get_decoder, uniprop_encode_value_character)
1859 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1860 New functions.
1861 (uniprop_encoder, uniprop_encoder_count): New variables.
1862 (uniprop_get_encoder, uniprop_table)
1863 (Funicode_property_table_internal, Fget_unicode_property_internal)
1864 (Fput_unicode_property_internal): New functions.
1865 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1866 Sunicode_property_table_internal, Sget_unicode_property_internal,
1867 and Sput_unicode_property_internal. Defvar_lisp
1868 char-code-property-alist.
1869
640c8776 1870 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1871 Vunicode_category_table.
1872
640c8776 1873 * font.c (font_range): Adjust for the change of
c805dec0
KH
1874 Vunicode_category_table.
1875
76b397fb
DN
18762011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1877
1878 * m/iris4d.h: Remove file, move contents ...
1879 * s/irix6-5.h: ... here.
1880
22b4128e
PE
18812011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1884 * alloc.c (mark_buffer):
1885 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1886 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1887 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1888 This isn't true in general, and it's particularly not true
1889 if Emacs is configured with --with-wide-int.
1890 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1891 New macros, used in the buffer.c change.
1892
869795d6
JD
18932011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1894
1895 * xsettings.c: Use both GConf and GSettings if both are available.
1896 (store_config_changed_event): Add comment.
1897 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1898 (store_tool_bar_style_changed): New functions.
1899 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1900 (struct xsettings): Move font inside HAVE_XFT.
1901 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1902 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1903 Move inside HAVE_XFT.
640c8776 1904 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1905 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1906 also.
1907 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1908 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1909 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1910 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1911 (parse_settings): Move check for font inside HAVE_XFT.
1912 (read_settings, apply_xft_settings): Add comment.
1913 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1914 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1915 call store_font_name_changed.
1916 (xft_settings_event): Add comment.
1917 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1918 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1919 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1920 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1921 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1922 (xsettings_get_system_font, xsettings_get_system_normal_font):
1923 Add comment.
869795d6 1924
d8ed26bd
PE
19252011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 Random fixes. E.g., (random) never returned negative values.
1928 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1929 subseconds part to the entropy, as that's a bit more random.
1930 Prefer signed to unsigned, since the signedness doesn't matter and
1931 in general we prefer signed. When given a limit, use a
1932 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1933 latter isn't right if USE_2_TAGS_FOR_INTS.
1934 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1935 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1936
cabf1cac
SM
19372011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1938
1939 * textprop.c (text_property_stickiness):
1940 Obey Vtext_property_default_nonsticky.
1941 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1942 * w32fns.c (syms_of_w32fns):
1943 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1944
6e9b2be9
PE
19452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1948 This is more efficient than Ffile_directory_p and avoids a minor race.
1949
90186c68
LMI
19502011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1951
7c301272
LMI
1952 * buffer.c (Foverlay_put): Say what the return value is
1953 (bug#7835).
1954
c4f2d8d4
LMI
1955 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1956 is a directory before asking whether to use the file name
1957 (bug#7564).
ad637907
LMI
1958 (barf_or_query_if_file_exists): Make the "File is a directory"
1959 error be more correct.
c4f2d8d4 1960
90186c68
LMI
1961 * fns.c (Frequire): Remove the mention of the .gz files, since
1962 that's installation-specific, but keep the mention of
1963 `get-load-suffixes'.
1964
da64016e
PE
19652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1968 Report string overflow if the output is too long.
1969
7d47b580
JB
19702011-07-04 Juanma Barranquero <lekktu@gmail.com>
1971
a555cb87
JB
1972 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1973 (syms_of_gnutls): Remove duplicate DEFSYM for
1974 Qgnutls_bootprop_verify_hostname_error, an error for
1975 Qgnutls_bootprop_verify_error (which is no longer used).
1976
7d47b580
JB
1977 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1978 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1979 Also (re)move comments that are misplaced or no longer relevant.
1980
1e49bfab
LMI
19812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1982
1983 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1984
1485f4c0
CY
19852011-07-03 Chong Yidong <cyd@stupidchicken.com>
1986
1987 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1988 and background color parameters if they have been changed.
1989
a9ab721e
LMI
19902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1991
1992 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1993
cf7cff57
PE
19942011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1995
2e13213d
PE
1996 * xsettings.c (SYSTEM_FONT): Define only when used.
1997 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1998
cf7cff57
PE
1999 * keymap.c (access_keymap_1): Now static.
2000
7a8e04f7
CY
20012011-07-02 Chong Yidong <cyd@stupidchicken.com>
2002
2003 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2004 leave any prefix arg for the up event (Bug#1586).
2005
61352f62
LMI
20062011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2007
69bb1ef7
LMI
2008 * lread.c (syms_of_lread): Mention single symbols defined by
2009 `defvar' or `defconst' (bug#7154).
2010
61352f62 2011 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2012 (Frequire): Mention get-load-suffixes.
61352f62 2013
28545e04
MR
20142011-07-02 Martin Rudalics <rudalics@gmx.at>
2015
2016 * window.h (window): Remove clone_number slot.
2017 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2018 Remove.
2019 (make_parent_window, make_window, saved_window)
2020 (Fset_window_configuration, save_window_save): Don't deal with
2021 clone numbers.
2022 * buffer.c (Qclone_number): Remove declaration.
2023 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2024
3349e122
SM
20252011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2026
2027 Add multiple inheritance to keymaps.
2028 * keymap.c (Fmake_composed_keymap): New function.
2029 (Fset_keymap_parent): Simplify.
2030 (fix_submap_inheritance): Remove.
2031 (access_keymap_1): New function extracted from access_keymap to handle
2032 embedded parents and handle lists of maps.
2033 (access_keymap): Use it.
2034 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2035 (Fcopy_keymap): Handle embedded parents.
2036 (Fcommand_remapping, define_as_prefix): Simplify.
2037 (Fkey_binding): Simplify.
2038 (syms_of_keymap): Move minibuffer-local-completion-map,
2039 minibuffer-local-filename-completion-map,
2040 minibuffer-local-must-match-map, and
2041 minibuffer-local-filename-must-match-map to Elisp.
2042 (syms_of_keymap): Defsubr make-composed-keymap.
2043 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2044 (parse_menu_item): Trivial simplification.
2045
3279eb87
GM
20462011-07-01 Glenn Morris <rgm@gnu.org>
2047
2048 * Makefile.in (SETTINGS_LIBS): Fix typo.
2049
4550efdf
KI
20502011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2051
2052 * coding.c (Fencode_coding_string): Record the last coding system
2053 used, as the function doc string says (bug#8738).
2054
0949d2b6
JD
20552011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2056
2057 * xsettings.c (store_monospaced_changed): Take new font as arg and
2058 check for change against current_mono_font.
2059 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2060 (emacs_settings_constructor, emacs_settings_get_property)
2061 (emacs_settings_set_property, emacs_settings_class_init)
2062 (emacs_settings_init, gsettings_obj): Remove.
2063 (something_changedCB): New function for HAVE_GSETTINGS.
2064 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2065 with value as argument.
2066 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2067 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2068 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2069 "changed".
2070
2071 * xgselect.c: Add defined (HAVE_GSETTINGS).
2072 (xgselect_initialize): Ditto.
2073
2074 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2075 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2076 xg_select.
2077
bbc6b304
PE
20782011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2079
2080 * eval.c (struct backtrace): Simplify and port the data structure.
2081 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2082 signed bit field, as this assumption is not portable and it makes
2083 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2084 "char debug_on_exit : 1" as this is not portable either; instead,
2085 use the portable "unsigned int debug_on_exit : 1". Remove unused
2086 member evalargs. Remove obsolete comments about cc bombing out.
2087
9851bfc5
JD
20882011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2089
51bb811f 2090 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2091 Let HAVE_GSETTINGS override HAVE_GCONF.
2092 (store_monospaced_changed): New function.
2093 (EMACS_SETTINGS): A new type derived from GObject to handle
2094 GSettings notifications.
2095 (emacs_settings_constructor, emacs_settings_get_property)
2096 (emacs_settings_set_property, emacs_settings_class_init):
2097 New functions.
2098 (gsettings_client, gsettings_obj): New variables.
2099 (GSETTINGS_SCHEMA): New define.
2100 (something_changedCB): Call store_monospaced_changed.
2101 (init_gsettings): New function.
2102 (xsettings_initialize): Call init_gsettings.
2103 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2104 to NULL.
2105
640c8776 2106 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2107 GCONF_CFLAGS/LIBS.
2108
5386012d
MR
21092011-06-29 Martin Rudalics <rudalics@gmx.at>
2110
2111 * window.c (resize_root_window, grow_mini_window)
2112 (shrink_mini_window): Rename Qresize_root_window to
2113 Qwindow_resize_root_window and Qresize_root_window_vertically to
2114 Qwindow_resize_root_window_vertically.
2115
f13e0b08
PE
21162011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2119
94515237
JB
21202011-06-27 Juanma Barranquero <lekktu@gmail.com>
2121
2122 * makefile.w32-in: Redesign dependencies so they reflect more
2123 clearly which files are directly included by each source file,
2124 and not through other includes.
2125
e43b6e43
MR
21262011-06-27 Martin Rudalics <rudalics@gmx.at>
2127
2128 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2129 (sort_overlays, overlay_strings): When an overlay's clone number
2130 matches the window's clone number process the overlay even if
2131 the overlay's window property doesn't match the current window.
2132
d68443dc
MR
2133 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2134 (Fwindow_hchild): Rename to Fwindow_left_child.
2135 (Fwindow_next): Rename to Fwindow_next_sibling.
2136 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2137 (resize_window_check): Rename to window_resize_check.
2138 (resize_window_apply): Rename to window_resize_apply.
2139 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2140 (Fdelete_other_windows_internal, resize_frame_windows)
2141 (Fsplit_window_internal, Fdelete_window_internal)
2142 (grow_mini_window, shrink_mini_window)
2143 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2144
c7e73be5
JD
21452011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2146
2147 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2148 (emacs_fixed_set_min_size): Remove.
2149 (emacs_fixed_new): Take frame as argument.
2150
2151 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2152 (_EmacsFixedPrivate): Remove minwidth/height.
2153 Add struct frame *f.
2154 (emacs_fixed_init): Initialize priv->f.
2155 (get_parent_class, emacs_fixed_set_min_size): Remove.
2156 (emacs_fixed_new): Set priv->f to argument.
2157 (emacs_fixed_get_preferred_width)
2158 (emacs_fixed_get_preferred_height): Use min_width/height from
2159 frames size_hint to set minimum and natural (Bug#8919).
2160 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2161 and use min_width/height from frames size_hint to set
2162 min_width/height (Bug#8919).
2163
2164 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2165 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2166 Fix indentation.
c7e73be5 2167
cf99dcf8
EZ
21682011-06-26 Eli Zaretskii <eliz@gnu.org>
2169
2170 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2171 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2172 called at ZV.
2173
029529ac
CY
21742011-06-26 Chong Yidong <cyd@stupidchicken.com>
2175
2176 * process.c (wait_reading_process_output): Bypass select if
2177 waiting for a cell while ignoring keyboard input, and input is
2178 pending. Suggested by Jan Djärv (Bug#8869).
2179
7a7ef429
PE
21802011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 Use gnulib's dup2 module instead of rolling our own.
2183 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2184
11fdef7d 21852011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2186
2187 * dispnew.c (scrolling_window): Before scrolling, turn off a
2188 mouse-highlight in the window being scrolled.
2189
cd3520a4
JB
21902011-06-24 Juanma Barranquero <lekktu@gmail.com>
2191
2192 Move DEFSYM to lisp.h and use everywhere.
2193
2194 * character.h (DEFSYM): Move declaration...
2195 * lisp.h (DEFSYM): ...here.
2196
2197 * gnutls.c:
2198 * minibuf.c:
2199 * w32menu.c:
2200 * w32proc.c:
2201 * w32select.c: Don't include character.h.
2202
2203 * alloc.c (syms_of_alloc):
2204 * buffer.c (syms_of_buffer):
2205 * bytecode.c (syms_of_bytecode):
2206 * callint.c (syms_of_callint):
2207 * casefiddle.c (syms_of_casefiddle):
2208 * casetab.c (init_casetab_once):
2209 * category.c (init_category_once, syms_of_category):
2210 * ccl.c (syms_of_ccl):
2211 * cmds.c (syms_of_cmds):
2212 * composite.c (syms_of_composite):
2213 * dbusbind.c (syms_of_dbusbind):
2214 * dired.c (syms_of_dired):
2215 * dispnew.c (syms_of_display):
2216 * doc.c (syms_of_doc):
2217 * editfns.c (syms_of_editfns):
2218 * emacs.c (syms_of_emacs):
2219 * eval.c (syms_of_eval):
2220 * fileio.c (syms_of_fileio):
2221 * fns.c (syms_of_fns):
2222 * frame.c (syms_of_frame):
2223 * fringe.c (syms_of_fringe):
2224 * insdel.c (syms_of_insdel):
2225 * keymap.c (syms_of_keymap):
2226 * lread.c (init_obarray, syms_of_lread):
2227 * macros.c (syms_of_macros):
2228 * msdos.c (syms_of_msdos):
2229 * print.c (syms_of_print):
2230 * process.c (syms_of_process):
2231 * search.c (syms_of_search):
2232 * sound.c (syms_of_sound):
2233 * syntax.c (init_syntax_once, syms_of_syntax):
2234 * terminal.c (syms_of_terminal):
2235 * textprop.c (syms_of_textprop):
2236 * undo.c (syms_of_undo):
2237 * w32.c (globals_of_w32):
2238 * window.c (syms_of_window):
2239 * xdisp.c (syms_of_xdisp):
2240 * xfaces.c (syms_of_xfaces):
2241 * xfns.c (syms_of_xfns):
2242 * xmenu.c (syms_of_xmenu):
2243 * xsettings.c (syms_of_xsettings):
2244 * xterm.c (syms_of_xterm): Use DEFSYM.
2245
4228cf16
TZ
22462011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2247
cd3520a4 2248 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2249
7fcccf1e
PE
22502011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2251
7efb4e0e
PE
2252 Integer and buffer overflow fixes (Bug#8873).
2253
ff5844ad
PE
2254 * print.c (printchar, strout): Check for string overflow.
2255 (PRINTPREPARE, printchar, strout):
2256 Don't set size unless allocation succeeds.
2257
90532f02
PE
2258 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2259 for sizes. Check for string overflow more accurately.
2260 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2261
6d84508d
PE
2262 * macros.c: Integer and buffer overflow fixes.
2263 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2264 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2265 Use ptrdiff_t, not int, for sizes.
2266 Don't increment bufsize until after realloc succeeds.
2267 Check for size-calculation overflow.
2268 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2269
437b2cb4
PE
2270 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2271
8b9ac8b4
PE
2272 * lread.c: Integer overflow fixes.
2273 (read_integer): Radix is now EMACS_INT, not int,
2274 to improve quality of diagnostics for out-of-range radices.
2275 Calculate buffer size correctly for out-of-range radices.
2276 (read1): Check for integer overflow in radices, and in
2277 read-circle numbers.
82cb60d3
PE
2278 (read_escape): Avoid int overflow.
2279 (Fload, openp, read_buffer_size, read1)
2280 (substitute_object_recurse, read_vector, read_list, map_obarray):
2281 Use ptrdiff_t, not int, for sizes.
2282 (read1): Use EMACS_INT, not int, for sizes.
20270765 2283 Check for size overflow.
8b9ac8b4 2284
7fcccf1e
PE
2285 * image.c (cache_image): Check for size arithmetic overflow.
2286
bfbbd7e7
PE
2287 * lread.c: Integer overflow issues.
2288 (saved_doc_string_size, saved_doc_string_length)
2289 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2290 Now ptrdiff_t, not int.
2291 (read1): Don't assume doc string length fits in int. Check for
2292 out-of-range doc string lengths.
2293 (read_list): Don't assume file position fits in int.
39019e54 2294 (read_escape): Check for hex character overflow.
bfbbd7e7 2295
4e323265
LL
22962011-06-22 Leo Liu <sdl.web@gmail.com>
2297
2298 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2299 Move to minibuffer.el.
2300
85fece3e
PE
23012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2302
20b84ce9 2303 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2304 The following patches are for when GLYPH_DEBUG && !XASSERT.
2305 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2306 * dispnew.c (flush_stdout):
2307 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2308 Mark as externally visible.
2309 * dispnew.c (check_window_matrix_pointers): Now static.
2310 * dispnew.c (window_to_frame_vpos):
2311 * xfns.c (unwind_create_frame):
2312 * xterm.c (x_check_font): Remove unused local.
2313 * scroll.c (CHECK_BOUNDS):
2314 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2315 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2316 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2317 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2318 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2319 Now static.
2320 (debug_method_add): Use va_list and vsprintf rather than relying
2321 on undefined behavior with wrong number of arguments.
2322 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2323 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2324 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2325 since we're not interested in debugging glyphs with old libraries.
2326 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2327 GCC 4.6.0's static checking.
2328
0766b489
PE
23292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2330
31fd4b32
PE
2331 Integer overflow and signedness fixes (Bug#8873).
2332 A few related buffer overrun fixes, too.
2333
b79e8648
PE
2334 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2335
0766b489
PE
2336 * dispextern.h (struct face.stipple):
2337 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2338 (x_bitmap_mask, x_allocate_bitmap_record)
2339 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2340 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2341 (x_create_bitmap_from_xpm_data):
2342 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2343 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2344 (.bitmaps_last):
2345 * xfaces.c (load_pixmap):
2346 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2347 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2348 (.bitmaps_last, struct x_output.icon_bitmap):
2349 Use ptrdiff_t, not int, for bitmap indexes.
2350 (x_allocate_bitmap_record): Check for size overflow.
2351 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2352
b081724f
PE
2353 Use ptrdiff_t, not int, for overlay counts.
2354 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2355 * editfns.c (overlays_around, get_pos_property):
2356 * textprop.c (get_char_property_and_overlay):
2357 * xdisp.c (next_overlay_change, note_mouse_highlight):
2358 * xfaces.c (face_at_buffer_position):
21514da7
PE
2359 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2360 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2361 (Fnext_overlay_change, Fprevious_overlay_change)
2362 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2363 Use ptrdiff_t, not int, for sizes.
21514da7 2364 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2365
3de73e5e
PE
2366 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2367
2606c57b
PE
2368 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2369 (x_session_initialize): Do not assume string length fits in int.
2370
aaafe47a
PE
2371 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2372 This is unlikely, but can occur if DPI is outlandish.
2373
2674ddc8 2374 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2375 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2376
28154962
PE
2377 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2378 * xrdb.c (magic_file_p, search_magic_path):
2379 Omit last arg SUFFIX; it was always 0. All callers changed.
2380 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2381
7de51af5
PE
2382 * xfont.c (xfont_match): Avoid need for strlen.
2383
25ed6cc3
PE
2384 * xfns.c: Don't assume strlen fits in int.
2385 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2386
4eab31dd
PE
2387 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2388 not unsigned long, as we prefer signed integers. All callers changed.
2389 Detect integer overflow in repeat count.
2390 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2391 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2392
171e2a58
PE
2393 * termcap.c: Don't assume sizes fit in int and never overflow.
2394 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2395 (gobble_line): Check for size-calculation overflow.
2396
ad39faca 2397 * minibuf.c (Fread_buffer):
6e5bb2dc 2398 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2399 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2400 Don't assume string length fits in int.
2401
52c61c22 2402 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2403 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2404
b5b8c9e5
PE
2405 * font.c: Don't assume string length fits in int.
2406 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2407 Use ptrdiff_t, not int.
ccd6111c
PE
2408 (font_intern_prop): Don't assume string length fits in int.
2409 Don't assume integer property fits in fixnum.
2410 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2411
882f0d81 2412 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2413 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2414 Reformulate so as not to need the command string.
2415 Invoke gzip -cd rather than gunzip, as it's more portable.
2416 (lock_info_type, lock_file_1, lock_file):
2417 Don't assume pid_t and time_t fit in unsigned long.
2418 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2419 (current_lock_owner): Prefer signed type for sizes.
2420 Use memcpy, not strncpy, where memcpy is what is really wanted.
2421 Don't assume (via atoi) that time_t and pid_t fit in int.
2422 Check for time_t and/or pid_t out of range, e.g., via a network share.
2423 Don't alloca where an auto var works fine.
2424
93f4cf88
PE
2425 * fileio.c: Fix some integer overflow issues.
2426 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2427 Don't assume string length fits in int.
2428 (directory_file_name): Don't assume string length fits in long.
2429 (make_temp_name): Don't assume pid fits in int, or that its print
2430 length is less than 20.
2431
f3e92b69
PE
2432 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2433
1bfdaf10
PE
2434 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2435
35016e9a
PE
2436 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2437
3d1e65a1
PE
2438 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2439 We prefer signed integers, even for size calculations.
2440
0b963a93
PE
2441 * emacs.c: Don't assume string length fits in 'int'.
2442 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2443 (main): Don't invoke strlen when not needed.
2444
573f4b54
PE
2445 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2446 (XD_DEBUG_MESSAGE): Don't waste a byte.
2447
989f33ba
PE
2448 * callproc.c (getenv_internal_1, getenv_internal)
2449 (Fgetenv_internal):
965d34eb
PE
2450 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2451
e4d29b33
PE
2452 * lread.c (invalid_syntax): Omit length argument.
2453 All uses changed. This doesn't fix a bug, but it simplifies the
2454 code away from its former Hollerith-constant appearance, and it's
2455 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2456 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2457
eb49b136
PE
2458 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2459 This didn't break anything, but it didn't help either.
2460 It's confusing to put a bogus integer in a place where the actual
2461 value does not matter.
9f62aeb1 2462 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2463 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2464
15375a22
PE
2465 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2466 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2467 implementation.
b61cc01c
PE
2468 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2469 We prefer signed types, and the value cannot exceed the EMACS_INT
2470 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2471 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2472 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2473 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2474
53b2623d
PE
2475 * indent.c (sane_tab_width): New function.
2476 (current_column, scan_for_column, Findent_to, position_indentation)
2477 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2478 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2479
51cab52b 2480 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2481
f2ed8a70
PE
2482 * lisp.h (lint_assume): New macro.
2483 * composite.c (composition_gstring_put_cache):
2484 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2485
abe80cc6
PE
2486 * editfns.c, insdel.c:
2487 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2488
b02c740e
PE
2489 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2490
ebc96716
PE
2491 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2492
b4e50fa0 2493 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2494 Use much-faster test for byte-length change.
311d5d7c 2495 Don't assume string byte-length fits in 'int'.
a4cf38e4 2496 Check that character arg fits in 'int'.
85461888 2497 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2498
c0c1ee9f
PE
2499 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2500
a498d7f4
PE
2501 * fns.c (concat): Catch string overflow earlier.
2502 Do not rely on integer wraparound.
2503
51cab52b
PE
2504 * dispextern.h (struct it.overlay_strings_charpos)
2505 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2506 * xdisp.c (forward_to_next_line_start)
2507 (back_to_previous_visible_line_start)
2508 (reseat_at_next_visible_line_start, next_element_from_buffer):
2509 Don't arbitrarily truncate the value of 'selective' to int.
2510
76031fad
PE
2511 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2512
5eb55db9
PE
2513 * composite.c: Don't truncate sizes to 'int'.
2514 (composition_gstring_p, composition_reseat_it)
2515 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2516 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2517 not EMACS_UINT, for indexes.
5eb55db9 2518
0703a717
PE
2519 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2520
d6202519
PE
2521 * buffer.c: Include <verify.h>.
2522 (struct sortvec.priority, struct sortstr.priority):
8961a454 2523 Now EMACS_INT, not int.
c20998a7 2524 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2525 (struct sortstr.size, record_overlay_string)
2526 (struct sortstrlist.size, struct sortlist.used):
2527 Don't truncate size to int.
2528 (record_overlay_string): Check for size-calculation overflow.
d6202519 2529 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2530
d5a19415
JM
25312011-06-22 Jim Meyering <meyering@redhat.com>
2532
029529ac 2533 Don't leak an XBM-image-sized buffer
d5a19415
JM
2534 * image.c (xbm_load): Free the image buffer after using it.
2535
a9041e6c
PE
25362011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 Port to Sun C.
2539 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2540 that Sun C diagnosed.
2541 * fns.c (secure_hash): Fix pointer signedness issue.
2542 * intervals.c (static_offset_intervals): New function.
2543 (offset_intervals): Use it.
2544
7f3f739f
LL
25452011-06-21 Leo Liu <sdl.web@gmail.com>
2546
2547 * deps.mk (fns.o):
2548 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2549 sha512.h.
2550
2551 * fns.c (secure_hash): Rename from crypto_hash_function and change
2552 the first arg to accept symbols.
5b66d427 2553 (Fsecure_hash): New primitive.
7f3f739f
LL
2554 (syms_of_fns): New symbols.
2555
76147d94
DD
25562011-06-20 Deniz Dogan <deniz@dogan.se>
2557
2558 * process.c (Fset_process_buffer): Clarify return value in
2559 docstring.
2560
7d7d0045
CY
25612011-06-18 Chong Yidong <cyd@stupidchicken.com>
2562
2563 * dispnew.c (add_window_display_history): Use BVAR.
2564
2565 * xdisp.c (debug_method_add): Use BVAR.
2566 (check_window_end, dump_glyph_matrix, dump_glyph)
2567 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2568
2569 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2570 Likewise.
2571
2572 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2573 check till after the cache is created in init_frame_faces.
2574
ff2bc410
SM
25752011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2576
2577 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2578
28177add
PE
25792011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2580
dd3482fe
PE
2581 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2582 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2583 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2584
393d71f3 2585 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2586 * fileio.c (Finsert_file_contents):
2587 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2588 Remove the old (too-loose) buffer overflow checks.
2589 They weren't needed, since make_gap checks for buffer overflow.
2590 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2591 The old code merely checked for Emacs fixnum overflow, and relied
2592 on undefined (wraparound) behavior. The new code avoids undefined
2593 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2594
2e6813b0 2595 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2596 Tune. Don't use wider integers than needed. Don't use alloca.
2597 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2598
599a9e4f
PE
2599 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2600
99561444
PE
2601 * insdel.c, lisp.h (buffer_overflow): New function.
2602 (insert_from_buffer_1, replace_range, replace_range_2):
2603 * insdel.c (make_gap_larger):
2604 * editfns.c (Finsert_char):
2605 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2606
28177add
PE
2607 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2608
e69dafad
PE
26092011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2610
a7af7fde 2611 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2612
b1c46f02
PE
2613 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2614 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2615
e69dafad
PE
2616 * fileio.c: Don't assume EMACS_INT fits in off_t.
2617 (emacs_lseek): New static function.
2618 (Finsert_file_contents, Fwrite_region): Use it.
2619 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2620
566684ea
PE
2621 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2622
e6966cd6
PE
2623 * fns.c: Don't overflow int when computing a list length.
2624 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2625 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2626 truncation on 64-bit hosts. Check for QUIT every
2627 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2628 faster and is responsive enough.
2629 (Flength): Report an error instead of overflowing an integer.
2630 (Fsafe_length): Return a float if the value is not representable
2631 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2632 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2633 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2634
dd0b0efb
PE
2635 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2636 (header_size, word_size): New constants.
2637 (allocate_vectorlike): Don't check size overflow here.
2638 (allocate_vector): Check it here instead, since this is the only
2639 caller of allocate_vectorlike that could cause overflow.
2640 Check that the new vector's length is representable as a fixnum.
2641
86fe5cfe
PE
2642 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2643 The previous code was bogus. For example, next_almost_prime (32)
2644 returned 39, which is undesirable as it is a multiple of 3; and
2645 next_almost_prime (24) returned 25, which is a multiple of 5 so
2646 why was the code bothering to check for multiples of 7?
2647
80e88859
PE
2648 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2649
4a2f0ad6
PE
2650 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2651
f66c7cf8
PE
2652 Variadic C functions now count arguments with ptrdiff_t.
2653 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2654 Back then I didn't know that the Emacs coding style prefers signed int.
2655 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2656 were being counted with int, which may truncate counts on 64-bit
2657 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2658 * lisp.h (struct Lisp_Subr.function.aMANY)
2659 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2660 Arg counts are now ptrdiff_t, not size_t.
2661 All variadic functions and their callers changed accordingly.
2662 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2663 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2664 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2665 * callint.c (Fcall_interactively): Check arg count for overflow,
2666 to avoid potential buffer overrun. Use signed char, not 'int',
2667 for 'varies' array, so that we needn't bother to check its size
2668 calculation for overflow.
2669 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2670 * eval.c (apply_lambda):
2671 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2672 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2673 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2674
a1759b76
PE
2675 * callint.c (Fcall_interactively): Don't use index var as event count.
2676
d96be9fc
PE
2677 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2678 * mem-limits.h (SIZE): Remove; no longer used.
2679
a690a978 2680 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2681
578c21e6
PE
2682 Remove unnecessary casts.
2683 * xterm.c (x_term_init):
2684 * xfns.c (x_set_border_pixel):
2685 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2686 These aren't needed now that we assume ANSI C.
2687
96f53c6c
PE
2688 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2689 It's more likely to cause problems (due to unsigned overflow)
2690 than to cure them.
2691
83c77d31
PE
2692 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2693
ee2079f1
PE
2694 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2695
6da65536
PE
2696 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2697
7147c4a4
PE
2698 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2699
193e32d9
PE
2700 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2701
e5533da6
PE
2702 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2703
9910e595
PE
2704 GLYPH_CODE_FACE returns EMACS_INT, not int.
2705 * dispextern.h (merge_faces):
2706 * xfaces.c (merge_faces):
01103c44
PE
2707 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2708 Don't assume EMACS_INT fits in int.
9910e595 2709
2638320e
PE
2710 * character.h (CHAR_VALID_P): Remove unused parameter.
2711 * fontset.c, lisp.h, xdisp.c: All uses changed.
2712
045eb8d9
PE
2713 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2714
c1f134b5
PE
2715 * fns.c (concat): Minor tuning based on overflow analysis.
2716 This doesn't fix any bugs. Use int to hold character, instead
2717 of constantly refetching from Emacs object. Use XFASTINT, not
2718 XINT, for value known to be a character. Don't bother comparing
2719 a single byte to 0400, as it's always less.
2720
395fcb93 2721 * floatfns.c (Fexpt):
327eeec8
PE
2722 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2723
abbd3d23
PE
2724 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2725 for characters.
2726
684a03ef
PE
2727 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2728
0fed43f3
PE
2729 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2730 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2731 incorrectly succeed when S was a string, because 4294967386 was
2732 truncated before it was used.
2733
8fd02eb7
PE
2734 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2735 Otherwise, an out-of-range integer could cause undefined behavior
2736 on a 64-bit host.
2737
f8c86b69
PE
2738 * composite.c: Use int, not EMACS_INT, for characters.
2739 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2740 EMACS_INT, for values that are known to be in character range.
2741 This doesn't fix any bugs but is the usual style inside Emacs and
2742 may generate better code on 32-bit machines.
2743
34206dd2
PE
2744 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2745 This is for reasons similar to the recent CHAR_STRING fix.
2746 * charset.c (Fencode_char): Check that character arg is actually
2747 a character. Pass an int to ENCODE_CHAR.
2748 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2749 wider than 'int', as a compile-time check to prevent future regressions
2750 in this area.
2751
c5958d4c 2752 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2753
2754 Make sure a 64-bit char is never passed to CHAR_STRING.
2755 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2756 by silently ignoring the top 32 bits, allowing some values
2757 that were far too large to be valid characters.
2758 * character.h: Include <verify.h>.
2759 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2760 arguments are no wider than unsigned, as a compile-time check
2761 to prevent future regressions in this area.
2762 * data.c (Faset):
01103c44 2763 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2764 (Fsubst_char_in_region):
2765 * fns.c (concat):
2766 * xdisp.c (decode_mode_spec_coding):
2767 Adjust to CHAR_STRING's new requirement.
2768 * editfns.c (Finsert_char, Fsubst_char_in_region):
2769 * fns.c (concat): Check that character args are actually
2770 characters. Without this test, these functions did the wrong
2771 thing with wildly out-of-range values on 64-bit hosts.
2772
d37ca623
PE
2773 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2774 These casts should not be needed on 32-bit hosts, either.
2775 * keyboard.c (read_char):
2776 * lread.c (Fload): Remove casts to unsigned.
2777
ea204efb
PE
2778 * lisp.h (UNSIGNED_CMP): New macro.
2779 This fixes comparison bugs on 64-bit hosts.
2780 (ASCII_CHAR_P): Use it.
2781 * casefiddle.c (casify_object):
01103c44 2782 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2783 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2784 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2785 * dispextern.h (FACE_FROM_ID):
2786 * keyboard.c (read_char): Use UNSIGNED_CMP.
2787
41cb286c
PE
2788 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2789 not to EMACS_INT, to avoid GCC warning.
2790
4a1b9832
PE
2791 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2792
55daad71
PE
2793 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2794 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2795 isn't needed on 32-bit machines.
8f95c75c 2796
01103c44
PE
2797 * buffer.c (Fgenerate_new_buffer_name):
2798 Use EMACS_INT for count, not int.
0ceccced 2799 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2800
2801 * data.c (Qcompiled_function): Now static.
2802
c6f072e7
PE
2803 * window.c (window_body_lines): Now static.
2804
20ce5912
PE
2805 * image.c (gif_load): Rename local to avoid shadowing.
2806
9c4c5f81
PE
2807 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2808 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2809 * alloc.c (make_save_value): Integer argument is now of type
2810 ptrdiff_t, not int.
2811 (mark_object): Use ptrdiff_t, not int.
2812 * lisp.h (pD): New macro.
2813 * print.c (print_object): Use it.
2814
c0c5c8ae
PE
2815 * alloc.c: Use EMACS_INT, not int, to count objects.
2816 (total_conses, total_markers, total_symbols, total_vector_size)
2817 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2818 (total_free_floats, total_floats, total_free_intervals)
2819 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2820 Now EMACS_INT, not int. All uses changed.
2821 (Fgarbage_collect): Compute overall total using a double, so that
2822 integer overflow is less likely to be a problem. Check for overflow
2823 when converting back to an integer.
5a25e253
PE
2824 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2825 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2826 These were 'int' variables that could overflow on 64-bit hosts;
2827 they were never used, so remove them instead of repairing them.
211a0b2a 2828 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2829 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2830 Previously, this ceilinged at INT_MAX, but that doesn't work on
2831 64-bit machines.
e46bb31a 2832 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2833
c78baabf 2834 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2835 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2836 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2837 when a (possibly-narrower) signed value would do just as well.
2838 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2839
c9d624c6
PE
2840 * alloc.c: Catch some string size overflows that we were missing.
2841 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2842 for convenience in STRING_BYTES_MAX.
2843 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2844 The definition here is exact; the one in lisp.h was approximate.
2845 (allocate_string_data): Check for string overflow. This catches
2846 some instances we weren't catching before. Also, it catches
2847 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2848 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2849 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2850
c9d624c6
PE
2851 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2852 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2853 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2854
353032ce
PE
2855 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2856
2bccce07
PE
2857 * alloc.c (Fmake_string): Check for out-of-range init.
2858
0ac30604
SM
28592011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2860
2861 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2862
c195f2de
JD
28632011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2864
2865 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2866 xg_get_default_scrollbar_width.
2867
2868 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2869 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2870 (style_changed_cb): Call update_theme_scrollbar_width and call
2871 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2872 all frames (Bug#8505).
2873 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2874 Call gtk_window_set_resizable if HAVE_GTK3.
2875 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2876 and height if HAVE_GTK3 (Bug#8505).
2877 (scroll_bar_width_for_theme): New variable.
2878 (update_theme_scrollbar_width): New function.
2879 (xg_get_default_scrollbar_width): Move code to
2880 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2881 (xg_initialize): Call update_theme_scrollbar_width.
2882
2883 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2884
2885 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2886
e10ac9f1
MR
28872011-06-12 Martin Rudalics <rudalics@gmx.at>
2888
2889 * frame.c (make_frame): Call other_buffer_safely instead of
2890 other_buffer.
2891
2892 * window.c (temp_output_buffer_show): Call display_buffer with
2893 second argument Vtemp_buffer_show_specifiers and reset latter
2894 immediately after the call.
2895 (Vtemp_buffer_show_specifiers): New variable.
2896 (auto_window_vscroll_p, next_screen_context_lines)
2897 (Vscroll_preserve_screen_position): Remove leading asterisks from
2898 doc-strings.
2899
2d3c217e 29002011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2901
7b7f97e8 2902 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2903 * buffer.c (Qclone_number): Remove for now, as it's unused.
2904 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2905 (record_buffer): Remove unused local.
2906 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2907 (set_frame_buffer_list): Remove; unused.
2908 * frame.h (other_visible_frames): Remove decl.
2909 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2910 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2911 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2912 if HAVE_GPM.
2913 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2914 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2915 Define only if HAVE_GPM.
2916 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2917 (update_hints_inhibit): Remove; never set. All uses removed.
2918 * widgetprv.h (emacsFrameClassRec): Remove decl.
2919 * window.c (delete_deletable_window): Now returns void, since it
2920 wasn't returning anything.
2921 (compare_window_configurations): Remove unused locals.
2922 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2923 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2924 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2925 the same widths as pointers. This follows up on the 2011-05-06 patch.
2926 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2927 * xterm.h: Likewise.
2928 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2929
1384b89e
JB
29302011-06-12 Juanma Barranquero <lekktu@gmail.com>
2931
2932 * makefile.w32-in: Update dependencies.
2933 (LISP_H): Add lib/intprops.h.
2934
1100a63c
CY
29352011-06-11 Chong Yidong <cyd@stupidchicken.com>
2936
2937 * image.c (gif_load): Add animation frame delay to the metadata.
2938 (syms_of_image): Use DEFSYM. New symbol `delay'.
2939
6198ccd0
MR
29402011-06-11 Martin Rudalics <rudalics@gmx.at>
2941
2942 * window.c (delete_deletable_window): Re-add.
2943 (Fset_window_configuration): Rewrite to handle dead buffers and
2944 consequently deletable windows.
2945 (window_tree, Fwindow_tree): Remove. Supply functionality in
2946 window.el.
2947 (compare_window_configurations): Simplify code.
2948
b6e3633c
AS
29492011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2950
1ab0dee5
AS
2951 * image.c (imagemagick_load_image): Fix type mismatch.
2952 (Fimagemagick_types): Likewise.
2953
b6e3633c
AS
2954 * window.h (replace_buffer_in_windows): Declare.
2955
9397e56f
MR
29562011-06-11 Martin Rudalics <rudalics@gmx.at>
2957
2958 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2959 Qclone_number. Remove external declaration of Qdelete_window.
2960 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2961 code.
640c8776
SM
2962 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2963 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2964 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2965 buffer list implementation.
2966 (other_buffer_safely): New function.
2967 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2968 calls to replace_buffer_in_windows and
2969 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2970 if allowed.
2971 (record_buffer): Inhibit quitting and rewrite using quittable
2972 functions. Run Qbuffer_list_update_hook if allowed.
2973 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2974 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2975 Move switch-to-buffer to window.el.
9397e56f
MR
2976 (bury-buffer): Move to window.el.
2977 (Vbuffer_list_update_hook): New variable.
2978
2979 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2980 section.
2981
2982 * window.h (resize_frame_windows): Move up in code.
2983 (Fwindow_frame): Remove EXFUN.
2984 (replace_buffer_in_all_windows): Remove prototype.
2985 (replace_buffer_in_windows_safely): Add prototype.
2986
2987 * window.c: Declare Qdelete_window static again. Move down
2988 declaration of select_count.
2989 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2990 (Fother_window): Move to window.el.
2991 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2992 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2993 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2994 window.el.
2995 (replace_buffer_in_windows): Implement by calling
2996 Qreplace_buffer_in_windows.
2997 (replace_buffer_in_all_windows): Remove with some functionality
2998 moved into replace_buffer_in_windows_safely.
2999 (replace_buffer_in_windows_safely): New function.
3000 (select_window_norecord, select_frame_norecord): Move in front
3001 of run_window_configuration_change_hook. Remove now obsolete
3002 declarations.
640c8776
SM
3003 (Fset_window_buffer): Rewrite doc-string.
3004 Call Qrecord_window_buffer.
9397e56f
MR
3005 (keys_of_window): Move binding for other-window to window.el.
3006
b50691aa
CY
30072011-06-11 Chong Yidong <cyd@stupidchicken.com>
3008
3009 * dispextern.h (struct image): Replace data member, whose int_val
3010 and ptr_val fields were not used by anything, with a single
3011 lisp_val object.
3012
3013 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3014 (gif_clear_image, gif_load, imagemagick_load_image)
3015 (gs_clear_image, gs_load): Callers changed.
3016
3f754b86
PE
30172011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3018
cca69397
PE
3019 * buffer.h: Include <time.h>, for time_t.
3020 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3021
109e28d0
PE
3022 Fix minor problems found by static checking.
3023
60737f02
PE
3024 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3025
4b66faf3
PE
3026 Make identifiers static if they are not used in other modules.
3027 * data.c (Qcompiled_function, Qframe, Qvector):
3028 * image.c (QimageMagick, Qsvg):
3029 * minibuf.c (Qmetadata):
3030 * window.c (resize_window_check, resize_root_window): Now static.
3031 * window.h (resize_window_check, resize_root_window): Remove decls.
3032
109e28d0
PE
3033 * window.c (window_deletion_count, delete_deletable_window):
3034 Remove; unused.
46a4ce9e
PE
3035 (window_body_lines): Now static.
3036 (Fdelete_other_windows_internal): Mark vars as initialized.
3037 Make sure 'resize_failed' is initialized.
3038 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3039 (resize_window_apply): Remove unused local.
3040 * window.h (delete_deletable_window): Remove decl.
3041
109e28d0 3042 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3043 (imagemagick_load_image): Fix pointer signedness problem by changing
3044 last arg from unsigned char * to char *. All uses changed.
3045 Also, fix a local for similar reasons.
3046 Remove unused locals. Remove locals to avoid shadowing.
3047 (fn_rsvg_handle_free): Remove; unused.
3048 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3049 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3050
3f754b86
PE
3051 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3052
2547adb1
CY
30532011-06-10 Chong Yidong <cyd@stupidchicken.com>
3054
3055 * image.c (gif_load): Fix omitted cast error introduced by
3056 2011-06-06 change.
3057
2c8e37d4
MR
30582011-06-10 Martin Rudalics <rudalics@gmx.at>
3059
3060 * window.h (resize_proportionally, orig_total_lines)
3061 (orig_top_line): Remove from window structure.
3062 (set_window_height, set_window_width, change_window_heights)
3063 (Fdelete_window): Remove prototypes.
3064 (resize_frame_windows): Remove duplicate declaration.
3065
440a42e3
EZ
30662011-06-10 Eli Zaretskii <eliz@gnu.org>
3067
3068 * window.h (resize_frame_windows, resize_window_check)
3069 (delete_deletable_window, resize_root_window)
3070 (resize_frame_windows): Declare prototypes.
3071
3072 * window.c (resize_window_apply): Make definition be "static" to
3073 match the prototype.
3074
562dd5e9
MR
30752011-06-10 Martin Rudalics <rudalics@gmx.at>
3076
3077 * window.c: Remove declarations of Qwindow_size_fixed,
3078 window_min_size_1, window_min_size_2, window_min_size,
3079 size_window, window_fixed_size_p, enlarge_window, delete_window.
3080 Remove static from declaration of Qdelete_window, it's
3081 temporarily needed by Fbury_buffer.
3082 (replace_window): Don't assign orig_top_line and
3083 orig_total_lines.
3084 (Fdelete_window, delete_window): Remove. Window deletion is
3085 handled by window.el.
640c8776
SM
3086 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3087 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3088 (Fdelete_other_windows): Remove. Deleting other windows is
3089 handled by window.el.
3090 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3091 handled in window.el.
3092 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3093 Window minimum sizes are handled in window.el.
3094 (shrink_windows, size_window, set_window_height)
3095 (set_window_width, change_window_heights, window_height)
3096 (window_width, CURBEG, CURSIZE, enlarge_window)
3097 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3098 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3099 handled in window.el.
3100 (make_dummy_parent): Rename to make_parent_window and give it a
3101 second argument horflag.
3102 (make_window): Don't set resize_proportionally any more.
3103 (Fsplit_window): Remove. Windows are split in window.el.
3104 (save_restore_action, save_restore_orig_size)
3105 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3106 Resize mini windows in window.el.
3107 (grow_mini_window, shrink_mini_window): Implement by calling
3108 Qresize_root_window_vertically, resize_window_check and
3109 resize_window_apply.
640c8776
SM
3110 (saved_window, Fset_window_configuration, save_window_save):
3111 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3112 resize_proportionally.
3113 (window_min_height, window_min_width): Move to window.el.
3114 (keys_of_window): Move bindings for delete-other-windows,
3115 split-window, delete-window and enlarge-window to window.el.
3116
3117 * buffer.c: Temporarily extern Qdelete_window.
3118 (Fbury_buffer): Temporarily call Qdelete_window instead of
3119 Fdelete_window (Fbury_buffer will move to window.el soon).
3120
3121 * frame.c (set_menu_bar_lines_1): Remove code handling
3122 orig_top_line and orig_total_lines.
3123
3124 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3125 set_window_height but set heights directly.
3126 (change_frame_size_1): Use resize_frame_windows.
3127
3128 * xdisp.c (init_xdisp): Don't use set_window_height but set
3129 heights directly.
3130
640c8776
SM
3131 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3132 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3133 run_window_configuration_change_hook.
3134
3135 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3136 instead of change_window_heights and run
3137 run_window_configuration_change_hook.
3138
1a13852e
MR
31392011-06-09 Martin Rudalics <rudalics@gmx.at>
3140
3141 * window.c (replace_window): Rename second argument REPLACEMENT to
3142 NEW. New third argument SETFLAG. Rewrite.
3143 (delete_window, make_dummy_parent): Call replace_window with
3144 third argument 1.
3145 (window_list_1): Move down in code.
3146 (run_window_configuration_change_hook): Move set_buffer part
3147 before select_frame_norecord part in order to unwind correctly.
3148 Rename count1 to count.
3149 (recombine_windows, delete_deletable_window, resize_root_window)
3150 (Fdelete_other_windows_internal)
3151 (Frun_window_configuration_change_hook, make_parent_window)
3152 (resize_window_check, resize_window_apply, Fresize_window_apply)
3153 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3154 (Fdelete_window_internal, Fresize_mini_window_internal):
3155 New functions.
1a13852e
MR
3156 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3157
f3d1777e
MR
31582011-06-08 Martin Rudalics <rudalics@gmx.at>
3159
496e208e
MR
3160 * window.h (window): Add some new members to window structure -
3161 normal_lines, normal_cols, new_total, new_normal, clone_number,
3162 splits, nest, prev_buffers, next_buffers.
3163 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3164 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3165
f3d1777e
MR
3166 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3167 Remove.
496e208e
MR
3168 (make_dummy_parent): Set new members of windows structure.
3169 (make_window): Move down in code. Handle new members of window
3170 structure.
3171 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3172 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3173 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3174 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3175 (Fset_window_next_buffers, Fset_window_clone_number):
3176 New functions.
496e208e
MR
3177 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3178 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3179 Doc-string fixes.
3180 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3181 Argument WINDOW can be now internal window too.
3182 (Fwindow_use_time): Move up in code.
3183 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3184 Rewrite doc-string.
3185 (Fset_window_configuration, saved_window)
3186 (Fcurrent_window_configuration, save_window_save): Handle new
3187 members of window structure.
b9e809c2
MR
3188 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3189 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3190 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3191 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3192 Qget_mru_window, Qresize_root_window,
3193 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3194 Qauto_buffer_name; staticpro them.
f3d1777e 3195
abde8f8c
MR
31962011-06-07 Martin Rudalics <rudalics@gmx.at>
3197
3198 * window.c (Fwindow_total_size, Fwindow_left_column)
3199 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3200 (Fwindow_list_1): New functions.
3201 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3202 (Fwindow_width, Fscroll_left, Fscroll_right):
3203 Use window_body_cols instead of window_box_text_cols.
3204 (delete_window, Fset_window_configuration):
3205 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3206 (delete_all_subwindows): Take a window as argument and not a
3207 structure. Rewrite.
190b47e6
MR
3208 (window_loop): Remove handling of GET_LRU_WINDOW and
3209 GET_LARGEST_WINDOW.
3210 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3211
3212 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3213 window_box_text_cols. delete_all_subwindows now takes a
3214 Lisp_Object as argument.
abde8f8c 3215
640c8776
SM
3216 * indent.c (compute_motion, Fcompute_motion):
3217 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3218
fa8a67e6
MR
3219 * frame.c (delete_frame): Call delete_all_subwindows with root
3220 window as argument.
3221
a54e3482
DC
32222011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3223
3224 * fns.c (Fputhash): Document return value.
3225
60002bf5
CY
32262011-06-06 Chong Yidong <cyd@stupidchicken.com>
3227
3228 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3229
0c671da6 32302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3231
b862a52a 3232 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3233
be44ca6c
PE
3234 Check for overflow when converting integer to cons and back.
3235 * charset.c (Fdefine_charset_internal, Fdecode_char):
3236 Use cons_to_unsigned to catch overflow.
3237 (Fencode_char): Use INTEGER_TO_CONS.
3238 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3239 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3240 * data.c (long_to_cons, cons_to_long): Remove.
3241 (cons_to_unsigned, cons_to_signed): New functions.
3242 These signal an error for invalid or out-of-range values.
3243 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3244 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3245 * font.c (Ffont_variation_glyphs):
3246 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3247 * lisp.h: Include <intprops.h>.
3248 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3249 (cons_to_signed, cons_to_unsigned): New decls.
3250 (long_to_cons, cons_to_long): Remove decls.
3251 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3252 (Fprimitive_undo): Use CONS_TO_INTEGER.
3253 * xfns.c (Fx_window_property): Likewise.
3254 * xselect.c: Include <limits.h>.
3255 (x_own_selection, selection_data_to_lisp_data):
3256 Use INTEGER_TO_CONS.
3257 (x_handle_selection_request, x_handle_selection_clear)
3258 (x_get_foreign_selection, Fx_disown_selection_internal)
3259 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3260 (lisp_data_to_selection_data): Use cons_to_unsigned.
3261 (x_fill_property_data): Use cons_to_signed.
3262 Report values out of range.
3263
d1f3d2af
PE
3264 Check for buffer and string overflow more precisely.
3265 * buffer.h (BUF_BYTES_MAX): New macro.
3266 * lisp.h (STRING_BYTES_MAX): New macro.
3267 * alloc.c (Fmake_string):
3268 * character.c (string_escape_byte8):
3269 * coding.c (coding_alloc_by_realloc):
3270 * doprnt.c (doprnt):
3271 * editfns.c (Fformat):
3272 * eval.c (verror):
3273 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3274 since they may not be the same number.
3275 * editfns.c (Finsert_char):
3276 * fileio.c (Finsert_file_contents):
3277 Likewise for BUF_BYTES_MAX.
3278
dd52fcea
PE
3279 * image.c: Use ptrdiff_t, not int, for sizes.
3280 (slurp_file): Switch from int to ptrdiff_t.
3281 All uses changed.
3282 (slurp_file): Check that file size fits in both size_t (for
3283 malloc) and ptrdiff_t (for sanity and safety).
3284
7f9bbdbb
PE
3285 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3286 if b->modtime has its maximal value.
3287
dfe18f82
PE
3288 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3289
84acfcf0
PE
3290 Don't assume time_t can fit into int.
3291 * buffer.h (struct buffer.modtime): Now time_t, not int.
3292 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3293 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3294
ccd9a01a
PE
3295 Minor fixes for signed vs unsigned integers.
3296 * character.h (MAYBE_UNIFY_CHAR):
3297 * charset.c (maybe_unify_char):
3298 * keyboard.c (read_char, reorder_modifiers):
3299 XINT -> XFASTINT, since the integer must be nonnegative.
3300 * ftfont.c (ftfont_spec_pattern):
3301 * keymap.c (access_keymap, silly_event_symbol_error):
3302 XUINT -> XFASTINT, since the integer must be nonnegative.
3303 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3304 since it makes no difference and we prefer signed.
3305 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3306 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3307 nonnegative.
3308
d6d100dd
SM
33092011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3310
3311 * window.h (Fwindow_frame): Declare.
3312
2b6148e4
PE
33132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3314
3315 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3316 (SPARE_MEMORY): Always define.
3317 (LARGE_REQUEST): Remove.
3318 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3319
f230ecc9
MR
33202011-06-06 Martin Rudalics <rudalics@gmx.at>
3321
727e958e
MR
3322 * lisp.h: Move EXFUNS for Fframe_root_window,
3323 Fframe_first_window and Fset_frame_selected_window to window.h.
3324
3325 * window.h: Move EXFUNS for Fframe_root_window,
3326 Fframe_first_window and Fset_frame_selected_window here from
3327 lisp.h.
3328
3329 * frame.c (Fwindow_frame, Fframe_first_window)
3330 (Fframe_root_window, Fframe_selected_window)
3331 (Fset_frame_selected_window): Move to window.c.
3332 (Factive_minibuffer_window): Move to minibuf.c.
3333 (Fother_visible_frames_p): New function.
3334
3335 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3336
f230ecc9
MR
3337 * window.c (decode_window, decode_any_window): Move up in code.
3338 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3339 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3340 (Fwindow_buffer): Move up and rewrite doc-string.
3341 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3342 (Fwindow_prev): New functions.
727e958e
MR
3343 (Fwindow_frame): Move here from frame.c. Accept any window as
3344 argument.
3345 (Fframe_root_window, Fframe_first_window)
3346 (Fframe_selected_window): Move here from frame.c. Accept frame
3347 or arbitrary window as argument. Update doc-strings.
3348 (Fminibuffer_window): Move up in code.
3349 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3350 (Fset_frame_selected_window): Move here from frame.c.
3351 Marginal rewrite.
727e958e
MR
3352 (Fselected_window, select_window, Fselect_window): Move up in
3353 code. Minor doc-string fixes.
f230ecc9 3354
4d09bcf6
PE
33552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3356
3357 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3358 Do not assume that spare memory exists; that assumption is valid
3359 only if SYSTEM_MALLOC.
3360 (LARGE_REQUEST): New macro, so that the issue of large requests
3361 is separated from the issue of spare memory.
3362
810928a2
AS
33632011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3364
172418ad
AS
3365 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3366 format. (Bug#8806)
3367
43f862f7
AS
3368 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3369
810928a2
AS
3370 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3371 before statements.
3372
a059fe24
JD
33732011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3374
3375 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3376
3377 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3378
3379 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3380 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3381
989bf368
JB
33822011-06-05 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3385
4b80f674
CY
33862011-06-04 Chong Yidong <cyd@stupidchicken.com>
3387
3388 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3389 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3390 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3391 New error handlers.
4b80f674
CY
3392 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3393 Obey Vx_select_enable_clipboard_manager. Catch errors in
3394 x_clipboard_manager_save (Bug#8779).
3395 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3396 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3397
99a33b77 33982011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3399
3400 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3401
99a33b77 34022011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3403
3404 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3405 in the current matrix if keep_current_p is non-zero.
3406
8264569d
EZ
34072011-06-04 Eli Zaretskii <eliz@gnu.org>
3408
3409 * bidi.c (bidi_level_of_next_char): Fix last change.
3410
57f97249
EZ
34112011-06-03 Eli Zaretskii <eliz@gnu.org>
3412
fec2107c 3413 Support bidi reordering of text covered by display properties.
57f97249 3414
fec2107c
EZ
3415 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3416 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3417 (bidi_cache_search, bidi_cache_iterator_state)
3418 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3419 (bidi_level_of_next_char, bidi_move_to_visually_next):
3420 Support character positions inside a run of characters covered by a
fec2107c
EZ
3421 display string.
3422 (bidi_paragraph_init, bidi_resolve_explicit_1)
3423 (bidi_level_of_next_char): Call bidi_fetch_char and
3424 bidi_fetch_char_advance instead of FETCH_CHAR and
3425 FETCH_CHAR_ADVANCE.
3426 (bidi_init_it): Initialize new members.
3427 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3428 definitions.
3429 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3430 instead of using explicit *_CHAR codes.
d6d100dd
SM
3431 (bidi_resolve_explicit, bidi_resolve_weak):
3432 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3433 bidirectional text is supported only in multibyte buffers.
3434 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3435 it to initialize the frame_window_p member of struct bidi_it.
3436 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3437 (bidi_resolve_explicit, bidi_resolve_weak)
3438 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3439 bidi_it->nchars is non-positive.
3440 (bidi_level_of_next_char): Don't try to lookup the cache for the
3441 next/previous character if nothing is cached there yet, or if we
3442 were just reseat()'ed to a new position.
c40e2fb2 3443
0e14fe90
EZ
3444 * xdisp.c (set_cursor_from_row): Set start and stop points
3445 according to the row's direction when priming the loop that looks
3446 for the glyph on which to display cursor.
3447 (single_display_spec_intangible_p): Function deleted.
3448 (display_prop_intangible_p): Reimplement to call
3449 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3450 Accept 3 additional arguments needed by handle_display_spec.
3451 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3452 values: lists, `(when COND...)' forms, etc.
3453 (single_display_spec_string_p): Support property values that are
3454 lists with the argument STRING its top-level element.
3455 (display_prop_string_p): Fix the condition for processing a
3456 property that is a list to be consistent with handle_display_spec.
fec2107c 3457 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3458 last portion of handle_display_prop.
3459 (compute_display_string_pos): Accept additional argument
3460 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3461 value of a `display' property is a "replacing spec".
3462 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3463 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3464 the display property, but just return a value indicating whether
3465 the display property will replace the characters it covers.
3466 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3467 frame_window_p members of struct bidi_it.
d6d100dd
SM
3468 (compute_display_string_pos, compute_display_string_end):
3469 New functions.
fec2107c
EZ
3470 (push_it): Accept second argument POSITION, where pop_it should
3471 jump to continue iteration.
3472 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3473
fec2107c
EZ
3474 * keyboard.c (adjust_point_for_property): Adjust the call to
3475 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3476
3477 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3478 (bidi_init_it): Update prototypes.
3479 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3480 (compute_display_string_pos, compute_display_string_end):
3481 Declare prototypes.
fec2107c
EZ
3482 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3483 EMACS_INT.
fc6f18ce 3484
40087514 34852011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3486
57f53182
PE
3487 Malloc failure behavior now depends on size of allocation.
3488 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3489 * lisp.h: Change signatures accordingly.
3490 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3491 All callers changed. (Bug#8762)
3492
3493 * gnutls.c: Use Emacs's memory allocators.
3494 Without this change, the gnutls library would invoke malloc etc.
3495 directly, which causes problems on non-SYNC_INPUT hosts, and which
3496 runs afoul of improving memory_full behavior. (Bug#8761)
3497 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3498 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3499 xfree instead of the default malloc, realloc, free.
3500 (Fgnutls_boot): No need to check for memory allocation failure,
3501 since xmalloc does that for us.
3502
ac32cd99 3503 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3504 * category.c (hash_get_category_set):
3505 * ccl.c (ccl_driver):
3506 * charset.c (Fdefine_charset_internal):
3507 * charset.h (struct charset.hash_index):
3508 * composite.c (get_composition_id, gstring_lookup_cache)
3509 (composition_gstring_put_cache):
3510 * composite.h (struct composition.hash_index):
3511 * dispextern.h (struct image.hash):
3512 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3513 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3514 (hashfn_equal, hashfn_user_defined, make_hash_table)
3515 (maybe_resize_hash_table, hash_lookup, hash_put)
3516 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3517 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3518 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3519 * image.c (make_image, search_image_cache, lookup_image)
3520 (xpm_put_color_table_h):
3521 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3522 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3523 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3524 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3525 * alloc.c (allocate_vectorlike):
3526 Check for overflow in vector size calculations.
3527 * ccl.c (ccl_driver):
3528 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3529 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3530 need to be updated by these changes.
40087514
PE
3531 * fns.c (make_hash_table, maybe_resize_hash_table):
3532 Check for integer overflow with large hash tables.
0de4bb68
PE
3533 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3534 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3535 (SXHASH_REDUCE): New macro.
3536 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3537 Use it instead of discarding useful hash info with large hash values.
3538 (sxhash_float): New function.
3539 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3540 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3541 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3542 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3543 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3544 Adjust signatures to match updated version of code.
3545 (consing_since_gc): Now EMACS_INT, since a single hash table can
3546 use more than INT_MAX bytes.
3547
698d32e2
DN
35482011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3549
3550 Make it possible to build with GCC-4.6+ -O2 -flto.
3551
3552 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3553
fd6fa53f
SM
35542011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3555
3556 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3557 Call minibuffer-inactive-mode.
3558
864db017
JB
35592011-05-31 Juanma Barranquero <lekktu@gmail.com>
3560
3561 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3562 Update dependencies.
3563
2ad0baf4
DN
35642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3565
3566 * data.c (init_data): Remove code for UTS, this system is not
3567 supported anymore.
3568
4fcc2638
DN
35692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3570
3571 Don't force ./temacs to start in terminal mode.
3572
3573 * frame.c (make_initial_frame): Initialize faces in all cases, not
3574 only when CANNOT_DUMP is defined.
3575 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3576
c56e0fd5
DN
35772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3578
3579 * dispnew.c (add_window_display_history): Use const for the string
3580 pointer. Remove declaration, not needed.
3581
333d54da 35822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3583
55d4c1b2 3584 Use 'inline', not 'INLINE'.
333d54da 3585 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3586 * alloc.c, fontset.c (INLINE): Remove.
3587 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3588 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3589 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3590 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3591 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3592
738db178
DN
35932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3594
3595 Make it possible to run ./temacs.
3596
3597 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3598 syms_of_callproc does the same thing. Remove test for
3599 "initialized", do it in the caller.
3600 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3601
620c53a6
SM
36022011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3603
3604 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3605 (read_minibuf): Use get_minibuffer.
3606 (syms_of_minibuf): Use DEFSYM.
3607 (Qmetadata): New var.
3608 * data.c (Qbuffer): Don't make it static.
3609 (syms_of_data): Use DEFSYM.
3610
e003a292
PE
36112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3612
3613 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3614 (CCL_CODE_MIN): New macro.
3615
ed008a6d
PE
36162011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3617
3687c2ef
PE
3618 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3619
ed008a6d
PE
3620 * eval.c (Qdebug): Now static.
3621 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3622 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3623 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3624
d66c4c7c
CY
36252011-05-29 Chong Yidong <cyd@stupidchicken.com>
3626
3627 * image.c: Various fixes to ImageMagick code comments.
3628 (Fimagemagick_types): Doc fix.
3629
5fbc2025
PE
36302011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3631
0196f88a
PE
3632 Minor fixes prompted by GCC 4.6.0 warnings.
3633
3634 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3635
5fbc2025
PE
3636 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3637 (x_clipboard_manager_save_all): Move extern decl to ...
3638 * xterm.h: ... here, so that it can be checked for consistency.
3639
1dd3c2d9
CY
36402011-05-29 Chong Yidong <cyd@stupidchicken.com>
3641
3642 * xselect.c (x_clipboard_manager_save_frame)
3643 (x_clipboard_manager_save_all): New functions.
3644 (Fx_clipboard_manager_save): Lisp function deleted.
3645
3646 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3647 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3648
3649 * xterm.h: Update prototype.
3650
5ba6571d
WX
36512011-05-28 William Xu <william.xwl@gmail.com>
3652
3653 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3654 exiting (Bug#8239).
3655
3eaff834
JM
36562011-05-28 Jim Meyering <meyering@redhat.com>
3657
e1900994 3658 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3659 * fns.c (to_uchar): Define.
3660 (crypto_hash_function): Use it to convert some newly-signed
3661 variables to unsigned, to avoid sign-extension bugs. For example,
3662 without this change, (md5 "truc") would evaluate to
3663 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3664 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3665 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3666
0f6990a7
PE
36672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3668
3669 Integer overflow fixes.
c8a9ca5a 3670
08686060
PE
3671 * dbusbind.c: Serial number integer overflow fixes.
3672 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3673 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3674 to hold a serial number that is too large for a fixnum.
3675 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3676 Check for serial numbers out of range. Decode any serial number
59568bf0 3677 that was so large that it became a float. (Bug#8722)
08686060 3678
2d1fc3c7
PE
3679 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3680 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3681 Use XFASTINT rather than XUINT when numbers are nonnegative.
3682 (xd_append_arg, Fdbus_method_return_internal):
3683 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3684 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3685 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3686 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3687 (Bug#8722)
2d1fc3c7 3688
c8a9ca5a
PE
3689 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3690
519e1d69
PE
3691 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3692
30569699
PE
3693 ccl: add integer overflow checks
3694 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3695 (IN_INT_RANGE): New macros.
3696 (ccl_driver): Use them to check for integer overflow when
3697 decoding a CCL program. Many of the new checks are whether XINT (x)
3698 fits in int; it doesn't always, on 64-bit hosts. The new version
3699 doesn't catch all possible integer overflows, but it's an
847044ea 3700 improvement. (Bug#8719)
30569699 3701
c11285dc
PE
3702 * alloc.c (make_event_array): Use XINT, not XUINT.
3703 There's no need for unsigned here.
3704
fdccd48e
PE
3705 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3706 This follows up to the 2011-05-06 change that substituted uintptr_t
3707 for EMACS_INT. This case wasn't caught back then.
3708
37910ab2
PE
3709 Rework Fformat to avoid integer overflow issues.
3710 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3711 now (part of C89). Include <verify.h>.
3712 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3713 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3714 (Fformat): Avoid the prepass trying to compute sizes; it was only
3715 approximate and thus did not catch overflow reliably. Instead, walk
3716 through the format just once, formatting and computing sizes as we go,
3717 checking for integer overflow at every step, and allocating a larger
3718 buffer as needed. Keep track separately whether the format is
3719 multibyte. Keep only the most-recently calculated precision, rather
3720 than them all. Record whether each argument has been converted to
3721 string. Use EMACS_INT, not int, for byte and char and arg counts.
3722 Support field widths and precisions larger than INT_MAX. Avoid
3723 sprintf's undefined behavior with conversion specifications such as %#d
3724 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3725 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3726 formatting out-of-range floating point numbers with int
9173deec 3727 formats. (Bug#8668)
37910ab2 3728
2e6578fb
PE
3729 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3730
0ae6bdee
PE
3731 * data.c: Avoid integer truncation in expressions involving floats.
3732 * data.c: Include <intprops.h>.
3733 (arith_driver): When there's an integer overflow in an expression
3734 involving floating point, convert the integers to floating point
3735 so that the resulting value does not suffer from catastrophic
3736 integer truncation. For example, on a 64-bit host (* 4
3737 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3738 Do not rely on undefined behavior after integer overflow.
3739
de883a70
PE
3740 merge count_size_as_multibyte, parse_str_to_multibyte
3741 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3742 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3743 Check for integer overflow.
3744 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3745 since it's now a duplicate of the other. This is more of
3746 a character than a buffer op, so better that it's in character.c.
3747 * fns.c, print.c: Adjust to above changes.
3748
2ff916cb
PE
37492011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3750
3751 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3752
f1b54466
PE
37532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3754
fb1ac845
PE
3755 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3756 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3757 (x_clipboard_manager_save): Now static.
3758 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3759
f1b54466
PE
3760 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3761 (crypto_hash_function): Now static.
3762 Fix pointer signedness problems. Avoid unnecessary initializations.
3763
a9f737ee
CY
37642011-05-27 Chong Yidong <cyd@stupidchicken.com>
3765
3766 * termhooks.h (Vselection_alist): Make it terminal-local.
3767
3768 * terminal.c (create_terminal): Initialize it.
3769
3770 * xselect.c: Support for clipboard managers.
3771 (Vselection_alist): Move to termhooks.h as terminal-local var.
3772 (LOCAL_SELECTION): New macro.
3773 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3774 (symbol_to_x_atom): Remove gratuitous arg.
3775 (x_handle_selection_request, lisp_data_to_selection_data)
3776 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3777 (x_own_selection, x_get_local_selection, x_convert_selection):
3778 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3779 (some_frame_on_display): Delete unused function.
3780 (Fx_own_selection_internal, Fx_get_selection_internal)
3781 (Fx_disown_selection_internal, Fx_selection_owner_p)
3782 (Fx_selection_exists_p): New optional frame arg.
3783 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3784 (x_handle_selection_clear): Don't treat other terminals with the
3785 same keyboard specially. Use the terminal-local Vselection_alist.
3786 (x_clear_frame_selections): Use Frun_hook_with_args.
3787
3788 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3789
3790 * xterm.h: Add support for those atoms.
3791
e067f0c1
CY
37922011-05-26 Chong Yidong <cyd@stupidchicken.com>
3793
3794 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3795 (converted_selections, conversion_fail_tag): New global variables.
3796 (x_selection_request_lisp_error): Free the above.
3797 (x_get_local_selection): Remove unnecessary code.
3798 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3799 of converted selections stored in converted_selections.
3800 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3801 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3802 (x_convert_selection): New function.
3803 (x_handle_selection_event): Simplify.
3804 (x_get_foreign_selection): Don't ignore incoming requests while
3805 waiting for an answer; this will fail when we implement
3806 SAVE_TARGETS, and seems unnecessary anyway.
3807 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3808 (Vx_sent_selection_functions): Doc fix.
3809
0f4aebc0
LL
38102011-05-26 Leo Liu <sdl.web@gmail.com>
3811
3812 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3813
e61124cd
YM
38142011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3815
3816 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3817
3818 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3819 for fringe update if it has periodic bitmap.
ac389d0c 3820 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3821 and fringe_bitmap_periodic_p.
3822
3823 * fringe.c (get_fringe_bitmap_data): New function.
3824 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3825 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3826 row. Mark glyph row for fringe update if periodicity changed.
3827
3828 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3829 for fringe update unless it has periodic bitmap.
3830
f16d9837
KH
38312011-05-25 Kenichi Handa <handa@m17n.org>
3832
3833 * xdisp.c (get_next_display_element): Set correct it->face_id for
3834 a static composition.
3835
e1b90ef6
LL
38362011-05-24 Leo Liu <sdl.web@gmail.com>
3837
3838 * deps.mk (fns.o):
3839 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3840
3841 * fns.c (crypto_hash_function, Fsha1): New function.
3842 (Fmd5): Use crypto_hash_function.
3843 (syms_of_fns): Add Ssha1.
3844
7400048f
PE
38452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 * gnutls.c: Remove unused macros.
3848 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3849 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3850 Remove macros that are defined and never used.
3851 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3852
abb71cf4
CY
38532011-05-22 Chong Yidong <cyd@stupidchicken.com>
3854
3855 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3856 (Fx_get_selection_internal): Minor cleanup.
3857 (Fx_own_selection_internal): Rename arguments for consistency with
3858 select.el.
3859
6307db39
PE
38602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3861
3862 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3863
f3d4e0a4
CY
38642011-05-22 Chong Yidong <cyd@stupidchicken.com>
3865
3866 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3867
4d8ade89
YM
38682011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3869
3870 * dispnew.c (scrolling_window): Don't exclude the case that the
3871 last enabled row in the desired matrix touches the bottom boundary.
3872
32078c8d
GM
38732011-05-21 Glenn Morris <rgm@gnu.org>
3874
3875 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3876 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3877 and add some more files.
32078c8d 3878
7285dc67
EZ
38792011-05-20 Eli Zaretskii <eliz@gnu.org>
3880
3881 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3882 report_file_error introduced by the change from 2011-05-07.
3883
89d1bd22
PE
38842011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 * systime.h (Time): Define only if emacs is defined.
3887 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3888 where the include path doesn't have X11/X.h by default. See
3889 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3890
e23640bb 38912011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3892
3893 * composite.c (find_automatic_composition): Fix previous change.
3894
b9704ad9
GM
38952011-05-20 Glenn Morris <rgm@gnu.org>
3896
3897 * lisp.mk: New file, split from Makefile.in.
3898 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3899 (shortlisp): Remove.
3900 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3901
4a720484
GM
39022011-05-19 Glenn Morris <rgm@gnu.org>
3903
3904 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3905 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3906 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3907 (lisp): Set the order to that of loadup.el.
3908 (shortlisp): Make it a copy of $lisp.
3909 (SOME_MACHINE_LISP): Remove.
3910 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3911 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3912
a28d4396
KH
39132011-05-18 Kenichi Handa <handa@m17n.org>
3914
3915 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3916 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3917 (find_automatic_composition): Mostly rewrite for efficiency.
3918
a2b1fa8e
JB
39192011-05-18 Juanma Barranquero <lekktu@gmail.com>
3920
3921 * makefile.w32-in: Update dependencies.
3922
8e1f5610
CS
39232011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3924
3925 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3926 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3927
7025ee00 39282011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3929
cdfa6eab
PE
3930 Fix some integer overflow issues, such as string length overflow.
3931
06d6db33
PE
3932 * insdel.c (count_size_as_multibyte): Check for string overflow.
3933
2b4560a8
PE
3934 * character.c (lisp_string_width): Check for string overflow.
3935 Use EMACS_INT, not int, for string indexes and lengths; in
3936 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3937 the resulting string length overflows an EMACS_INT; instead,
3938 report a string overflow if no precision given. When checking for
3939 precision exhaustion, use a check that cannot possibly have
3940 integer overflow. (Bug#8675)
3941 * character.h (lisp_string_width): Adjust to new signature.
3942
cb93f9be
PE
3943 * alloc.c (string_overflow): New function.
3944 (Fmake_string): Use it. This doesn't change behavior, but saves
3945 a few bytes and will simplify future changes.
3946 * character.c (string_escape_byte8): Likewise.
3947 * lisp.h (string_overflow): New decl.
3948
1a1f3366
PE
3949 Fixups, following up to the user-interface timestamp change.
3950 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3951 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3952 * msdos.c (mouse_get_pos): Likewise.
3953 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3954 * w32gui.h (Time): Define by including "systime.h" rather than by
3955 declaring it ourselves. (Bug#8664)
3956
d4e3e4d3
PE
3957 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3958 * image.c (clear_image_cache): Likewise.
3959
f6a24d19
PE
3960 * term.c (term_mouse_position): Don't assume time_t wraparound.
3961
08dc5ae6
PE
3962 Be more systematic about user-interface timestamps.
3963 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3964 and sometimes 'EMACS_UINT', to represent these timestamps.
3965 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3966 This makes the code easier to follow, and makes it easier to catch
3967 integer overflow bugs such as Bug#8664.
3968 * frame.c (Fmouse_position, Fmouse_pixel_position):
3969 Use Time, not unsigned long, for user-interface timestamps.
3970 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3971 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3972 * keyboard.h (last_event_timestamp): Likewise.
3973 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3974 * menu.h (xmenu_show): Likewise.
3975 * term.c (term_mouse_position): Likewise.
3976 * termhooks.h (struct input_event.timestamp): Likewise.
3977 (struct terminal.mouse_position_hook): Likewise.
3978 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3979 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3980 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3981 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3982 what it was before.
3983 * menu.h, termhooks.h: Include "systime.h", for Time.
3984
8e55734a
PE
3985 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3986 Don't assume that the difference between two unsigned long values
3987 can fit into an integer. At this point, we know button_down_time
3988 <= event->timestamp, so the difference must be nonnegative, so
3989 there's no need to cast the result if double-click-time is
3990 nonnegative, as it should be; check that it's nonnegative, just in
3991 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3992 apart (about 25 days). (Bug#8664)
8e55734a 3993
841f1b75 3994 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3995 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3996
3e26f69c
PE
3997 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3998 that always fit in int. Use a sentinel instead of a counter, to
3999 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4000 * frame.h (struct frame): Use int for menu_bar_items_used
4001 instead of EMACS_INT, since it always fits in int.
3e26f69c 4002
5cc152c0
PE
4003 * menu.c (grow_menu_items): Check for int overflow.
4004
d89eb65e
PE
4005 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4006
5235bd3e
PE
4007 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4008 Before, the code was not consistent. These values cannot exceed
4009 2**31 - 1 so there's no need to make them unsigned.
4010 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4011 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4012 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4013 as modifiers.
4014 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4015
bc827e23
PE
4016 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4017 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4018 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4019 presumably because the widths might not match.
4020
78eb494e
PE
4021 * window.c (size_window): Avoid needless test at loop start.
4022
04f2d78b
CB
40232011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4024
4025 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4026
d2fc7e3d 40272011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4028
4029 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4030
d2fc7e3d 40312011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4032
4033 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4034 `width' to `bar_area_x' and `bar_area_width', respectively.
4035 (x_scroll_run): Take account of fringe background extension.
4036
04f2d78b
CB
4037 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4038 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4039 `bar_area_width', respectively.
4040 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4041 background extension.
4042
79b70037
GM
40432011-05-10 Jim Meyering <meyering@redhat.com>
4044
4045 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4046
2f142cc5
JB
40472011-05-10 Juanma Barranquero <lekktu@gmail.com>
4048
4049 * image.c (Finit_image_library): Return t for built-in image types,
4050 like pbm and xbm. (Bug#8640)
4051
57679c86
AS
40522011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4053
4054 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4055
888c9e86
EZ
40562011-05-07 Eli Zaretskii <eliz@gnu.org>
4057
b0512a1d
EZ
4058 * w32console.c (Fset_screen_color): Doc fix.
4059 (Fget_screen_color): New function.
4060 (syms_of_ntterm): Defsubr it.
4061
7285dc67
EZ
4062 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4063 unlink the temporary file if Fcall_process didn't create it in the
4064 first place.
4065 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4066 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4067 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4068 cue to call_process_cleanup not to close that handle.
4069
4d3fcc8e
BK
40702011-05-07 Ben Key <bkey76@gmail.com>
4071
4072 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4073 one of two shell specific rules, either bootstrap-temacs-CMD or
4074 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4075 to the previous implementation of the bootstrap-temacs rule.
4076 The bootstrap-temacs-CMD rule is similar to the previous
4077 implementation of the bootstrap-temacs rule except that it
4078 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4079 variable.
4080
4081 These changes, along with some changes to nt/configure.bat,
4082 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4083 earlier fix to add support for --cflags and --ldflags options
4084 that include quotes so that it works whether make uses cmd or
4085 sh as the shell.
4086
b4289b64
MA
40872011-05-06 Michael Albinus <michael.albinus@gmx.de>
4088
4089 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4090 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4091 is a constant.
4092 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4093 a string. Handle both cases.
4094 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4095 (Fdbus_register_method): Use Qinvalid_function.
4096
af4c0e28
JB
40972011-05-06 Juanma Barranquero <lekktu@gmail.com>
4098
4099 * makefile.w32-in: Update dependencies.
4100 (LISP_H): Add inttypes.h and stdin.h.
4101 (PROCESS_H): Add unistd.h.
4102
c51453d9
EZ
41032011-05-06 Eli Zaretskii <eliz@gnu.org>
4104
4105 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4106 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4107
8ff0ac3c 41082011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4109
4c4b566b
PE
4110 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4111
aab2b9b5
PE
4112 * term.c (vfatal): Remove stray call to va_end.
4113 It's not needed and the C Standard doesn't allow it here anyway.
4114
c378da0b
PE
4115 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4116 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4117
288b08c7
PE
4118 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4119 bytes.
4120
e3601888
PE
4121 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4122
db6c0e74
PE
4123 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4124
dd5963ea
PE
4125 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4126
88c9450f
PE
4127 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4128
2f9442b8
PE
4129 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4130
c032b5f8
PE
4131 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4132 * charset.c (Fdefine_charset_internal): Don't initialize
4133 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4134 32-bit int (Bug#8600).
a108c10b
PE
4135
4136 * lread.c (read_integer): Be more consistent with string-to-number.
4137 Use string_to_number to do the actual conversion; this avoids
4138 rounding errors and fixes some other screwups. Without this fix,
4139 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4140 (digit_to_number): Move earlier, for benefit of read_integer.
4141 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4142 not a digit in any supported base. (Bug#8602)
a108c10b 4143
ad5f9eea
PE
4144 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4145
aec1708a
PE
4146 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4147 to match comment at start of function. This also removes a
4148 GCC warning about overflow in a 32+64-bit port.
4149
47be4ab5
PE
4150 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4151
371cac43
PE
4152 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4153 Reported by Stefan Monnier in
4154 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4155 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4156 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4157
d01a7826
PE
4158 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4159 (EMACS_UINTPTR): Likewise, with uintptr_t.
4160
7fd47d5c
PE
4161 * lisp.h: Prefer 64-bit EMACS_INT if available.
4162 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4163 on 32-bit hosts that have 64-bit int, so that they can access
4164 large files.
122b0c86
PE
4165 However, temporarily disable this change unless the temporary
4166 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4167
8727937b
PE
4168 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4169
8ac068ac
PE
4170 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4171 This removes an assumption that EMACS_INT and long are the same
4172 width as pointers. The assumption is true for Emacs porting targets
4173 now, but we want to make other targets possible.
4174 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4175 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4176 In the rest of the code, change types of integers that hold casted
4177 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4178 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4179 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4180 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4181 No need to cast type when ORing.
4182 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4183 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4184 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4185 assume EMACS_INT is the same width as char *.
4186 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4187 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4188 Remove no-longer-needed casts.
4189 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4190 (xg_tool_bar_help_callback, xg_make_tool_item):
4191 Use EMACS_INTPTR to hold an integer
4192 that will be cast to void *; this can avoid a GCC warning
4193 if EMACS_INT is not the same width as void *.
4194 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4195 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4196 (current_message_1, set_message_1):
4197 Use a local to convert to proper width without a cast.
4198 * xmenu.c (dialog_selection_callback): Likewise.
4199
ede49d71
PE
4200 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4201 Also, don't assume VALBITS / RAND_BITS is less than 5,
4202 and don't rely on undefined behavior when shifting a 1 left into
4203 the sign bit.
4204 * lisp.h (get_random): Change signature to match.
4205
2f30ecd0
PE
4206 * lread.c (hash_string): Use size_t, not int, for hash computation.
4207 Normally we prefer signed values; but hashing is special, because
4208 it's better to use unsigned division on hash table sizes so that
4209 the remainder is nonnegative. Also, size_t is the natural width
4210 for hashing into memory. The previous code used 'int', which doesn't
4211 retain enough info to hash well into very large tables.
4212 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4213
2a866e7b
PE
4214 * dbusbind.c: Don't possibly lose pointer info when converting.
4215 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4216 Use XPNTR rather than XHASH, so that the high-order bits of
4217 the pointer aren't lost when converting through void *.
4218
51639eac
PE
4219 * eval.c (Fautoload): Don't double-shift a pointer.
4220
92394119
PE
4221 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4222
dbdb9a7c
JB
42232011-05-06 Juanma Barranquero <lekktu@gmail.com>
4224
4225 * gnutls.c (DEF_GNUTLS_FN):
4226 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4227
db7a0b4f
AS
42282011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4229
4230 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4231 marker. (Bug#8610)
4232
f7ff1b0f 42332011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4234
4235 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4236 New version that can reserve upto 2GB of heap space.
4237
f7ff1b0f 42382011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4239
4240 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4241
639c109b
TZ
42422011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4243
4244 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4245 `gnutls_certificate_set_x509_key_file'.
4246
d2127135
JB
42472011-05-05 Juanma Barranquero <lekktu@gmail.com>
4248
4249 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4250 Update dependencies.
4251
e968f4f3
JB
42522011-05-04 Juanma Barranquero <lekktu@gmail.com>
4253
4254 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4255 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4256 Remove unused parameter `fildes'.
4257 * process.c (read_process_output, send_process): Don't pass it.
4258
84d358f0
JB
42592011-05-04 Juanma Barranquero <lekktu@gmail.com>
4260
4261 Fix previous change: the library cache is defined in w32.c.
4262 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4263 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4264
0898ca10
JB
42652011-05-04 Juanma Barranquero <lekktu@gmail.com>
4266
4267 Implement dynamic loading of GnuTLS on Windows.
4268
4269 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4270 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4271 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4272 Declare.
4273
4274 * gnutls.c (Qgnutls_dll): Define.
4275 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4276 (gnutls_*): Declare function pointers.
4277 (init_gnutls_functions): New function to initialize function pointers.
4278 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4279 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4280 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4281 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4282 (emacs_gnutls_write, emacs_gnutls_read)
4283 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4284 (Fgnutls_available_p): New function.
4285 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4286 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4287 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4288
4289 * image.c: Include w32.h.
4290 (Vimage_type_cache): Delete.
4291 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4292 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4293 (w32_delayed_load): Move to w32.c.
4294
4295 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4296
4297 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4298 (w32_delayed_load): Move from image.c. When loading a library, record
4299 its filename in the :loaded-from property of the library id.
4300 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4301 Initialize and staticpro them.
4302 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4303
4304 * process.c: Include lisp.h before w32.h, not after.
4305 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4306 instead of gnutls_record_check_pending.
4307
4308 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4309
ff4de4aa
TZ
43102011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4311
4312 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4313 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4314 as passed in.
4315
abe95abb
JD
43162011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4317
4318 * xterm.c (x_set_frame_alpha): Do not set property on anything
4319 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4320
e16e55d4
JB
43212011-05-02 Juanma Barranquero <lekktu@gmail.com>
4322
4323 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4324
bafcf6a5
JB
43252011-05-02 Juanma Barranquero <lekktu@gmail.com>
4326
4327 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4328 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4329 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4330 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4331 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4332 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4333 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4334 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4335 (Qgnutls_bootprop_callbacks_verify): Make static.
4336
e7a6747f
AS
43372011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4338
19ed11ba
AS
4339 * callproc.c: Indentation fixup.
4340
e7a6747f 4341 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4342 (wait_for_termination, interruptible_wait_for_termination):
4343 Move after wait_for_termination_1.
e7a6747f 4344
1ef14cb4
LMI
43452011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4346
4347 * sysdep.c (interruptible_wait_for_termination): New function
4348 which is like wait_for_termination, but allows keyboard
4349 interruptions.
4350
4351 * callproc.c (Fcall_process): Add (:file "file") as an option for
4352 the STDOUT buffer.
4353 (Fcall_process_region): Ditto.
4354
330d880c
EZ
43552011-04-30 Eli Zaretskii <eliz@gnu.org>
4356
8db90b73
EZ
4357 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4358 rather than `XVECTOR (FOO)->size'.
4359
330d880c
EZ
4360 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4361 inttypes.h, as a gnulib replacement is used if it not available in
4362 system headers.
4363
15cbd324
EZ
43642011-04-21 Eli Zaretskii <eliz@gnu.org>
4365
4366 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4367 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4368 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4369
4370 * coding.c (coding_alloc_by_realloc): Error out if destination
4371 will grow beyond MOST_POSITIVE_FIXNUM.
4372 (decode_coding_emacs_mule): Abort if there isn't enough place in
4373 charbuf for the composition carryover bytes. Reserve an extra
4374 space for up to 2 characters produced in a loop.
4375 (decode_coding_iso_2022): Abort if there isn't enough place in
4376 charbuf for the composition carryover bytes.
4377
43782011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4379
ae940cca
EZ
4380 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4381 aborting when %lld or %lll format is passed.
4382 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4383 %llo or %llx format is passed. (Bug#8545)
4384
03ab8921
EZ
4385 * window.c (window_scroll_line_based): Use a marker instead of
4386 simple variables to record original value of point. (Bug#7952)
4387
afda1437
EZ
4388 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4389 produced by %s or %c overflows available buffer space. (Bug#8545)
4390
f76dee0c
PE
43912011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4392
4393 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4394 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4395
fdc5744d
JB
43962011-04-28 Juanma Barranquero <lekktu@gmail.com>
4397
4398 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4399
638f053a
JB
44002011-04-28 Juanma Barranquero <lekktu@gmail.com>
4401
4402 * keyboard.c (Qdelayed_warnings_hook): Define.
4403 (command_loop_1): Run `delayed-warnings-hook'
4404 if Vdelayed_warnings_list is non-nil.
4405 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4406 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4407
d178f871
EZ
44082011-04-28 Eli Zaretskii <eliz@gnu.org>
4409
4410 * doprnt.c (doprnt): Don't return value smaller than the buffer
4411 size if the message was truncated. (Bug#8545).
4412
b124fd93
JB
44132011-04-28 Juanma Barranquero <lekktu@gmail.com>
4414
4415 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4416 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4417
e810457d
PE
44182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4419
4420 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4421
ea51cceb
JB
44222011-04-27 Juanma Barranquero <lekktu@gmail.com>
4423
4424 * makefile.w32-in: Update dependencies.
4425
94dcfacf
EZ
44262011-04-27 Eli Zaretskii <eliz@gnu.org>
4427
4428 Improve `doprnt' and its usage. (Bug#8545)
4429 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4430 `format_end'. Remove support for %l as a conversion specifier.
4431 Don't use xrealloc. Improve diagnostics when the %l size modifier
4432 is used. Update the commentary.
4433
4434 * eval.c (verror): Simplify calculation of size_t.
4435
4436 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4437 messages.
4438
f61f41d7
PE
44392011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4440
4441 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4442 change.
4443
96fb4434
PE
44442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4445
4446 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4447 This makes this file independent of the recent pseudovector change.
4448
671875da 44492011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4450
69e9b5a3
PE
4451 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4452
b5f869a7 4453 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4454 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4455 Remove unused local.
c8926152 4456 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4457
841a1577 4458 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4459 GCC 4.6.0 optimizes based on type-based alias analysis.
4460 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4461 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4462 != &v->size, and therefore "v->size = 1; b->size = 2; return
4463 v->size;" must therefore return 1. This assumption is incorrect
4464 for Emacs, since it type-puns struct Lisp_Vector * with many other
4465 types. To fix this problem, this patch adds a new type struct
f904488f 4466 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4467 and pseudovectors, and helps optimizing compilers not get fooled
4468 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4469 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4470 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4471 the size member.
eab3844f
PE
4472 (XSETPVECTYPE): Rewrite in terms of new macro.
4473 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4474 This is a bit clearer, and further avoids the possibility of
4475 undesirable aliasing.
4476 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4477 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4478 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4479 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4480 (ASIZE): Now uses header.size rather than size.
4481 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4482 to avoid the hassle of writing XVECTOR (foo)->header.size.
4483 (struct vectorlike_header): New type.
eab3844f
PE
4484 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4485 object, to help avoid aliasing.
4486 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4487 (SUBRP): Likewise, since Lisp_Subr is a special case.
4488 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4489 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4490 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4491 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4492 changed to be "header.size" and "header.next".
4493 * buffer.h (struct buffer): Likewise.
4494 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4495 * frame.h (struct frame): Likewise.
4496 * process.h (struct Lisp_Process): Likewise.
4497 * termhooks.h (struct terminal): Likewise.
4498 * window.c (struct save_window_data, struct saved_window): Likewise.
4499 * window.h (struct window): Likewise.
4500 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4501 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4502 * buffer.c (init_buffer_once): Likewise.
4503 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4504 special case.
4505 * process.c (Fformat_network_address): Use local var for size,
4506 for brevity.
4507
0df1eac5
PE
4508 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4509
847ab9d1 4510 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4511 * data.c (atof): Remove decl; no longer used or needed.
4512 (digit_to_number): Move to lread.c.
4513 (Fstring_to_number): Use new string_to_number function, to be
4514 consistent with how the Lisp reader treats infinities and NaNs.
4515 Do not assume that floating-point numbers represent EMACS_INT
4516 without losing information; this is not true on most 64-bit hosts.
4517 Avoid double-rounding errors, by insisting on integers when
4518 parsing non-base-10 numbers, as the documentation specifies.
4519 * lisp.h (string_to_number): New decl, replacing ...
4520 (isfloat_string): Remove.
bc0a5c13 4521 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4522 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4523 appears to have been a coding error. Similarly, do not accept
4524 strings like +-1e0 as floating point numbers. Do not report
4525 overflow for integer overflows unless the base is not 10 which
4526 means we have no simple and reliable way to continue.
4527 Break out the floating-point parsing into a new
4528 function string_to_number, so that Fstring_to_number parses
4529 floating point numbers consistently with the Lisp reader.
04f2d78b 4530 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4531 (E_CHAR, EXP_INT): Remove, replacing with ...
4532 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4533 (string_to_number): New function, replacing isfloat_string.
4534 This function checks for valid syntax and produces the resulting
4535 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4536 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4537 so that overflow for non-base-10 numbers is reported only when
4538 there's no portable and simple way to convert to floating point.
452f4150 4539
67769ffc
PE
4540 * textprop.c (set_text_properties_1): Rewrite for clarity,
4541 and to avoid GCC warning about integer overflow.
4542
c20db43f
PE
4543 * intervals.h (struct interval): Use EMACS_INT for members
4544 where EMACS_UINT might cause problems. See
4545 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4546 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4547 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4548 All uses changed.
37aa2f85
PE
4549 (offset_intervals): Tell GCC not to worry about length overflow
4550 when negating a negative length.
c20db43f 4551
2538aa2f
PE
4552 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4553 (overrun_check_free): Likewise.
4554
f2d3008d
PE
4555 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4556 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4557 word size.
4558
ec8df744
PE
4559 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4560 (gnutls_make_error): Rename local to avoid shadowing.
4561 (gnutls_emacs_global_deinit): ifdef out; not used.
4562 (Fgnutls_boot): Use const for pointer to readonly storage.
4563 Comment out unused local. Fix pointer signedness problems.
4564
640ee02d
PE
4565 * lread.c (openp): Don't stuff size_t into an 'int'.
4566 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4567 about possible signed overflow.
4568
6048fb2a
PE
4569 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4570 (GDK_KEY_g): Don't define if already defined.
4571 (xg_prepare_tooltip): Avoid pointer signedness problem.
4572 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4573
fa3c87e1
PE
4574 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4575 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4576
2172544b
PE
4577 * xfns.c (Fx_window_property): Simplify a bit,
4578 to make a bit faster and to avoid GCC 4.6.0 warning.
4579 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4580
9b821a21
PE
4581 * fns.c (internal_equal): Don't assume size_t fits in int.
4582
3c616cfa
PE
4583 * alloc.c (compact_small_strings): Tighten assertion a little.
4584
c2982e87
PE
4585 Replace pEd with more-general pI, and fix some printf arg casts.
4586 * lisp.h (pI): New macro, generalizing old pEd macro to other
4587 conversion specifiers. For example, use "...%"pI"d..." rather
4588 than "...%"pEd"...".
4589 (pEd): Remove. All uses replaced with similar uses of pI.
4590 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4591 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4592 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4593 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4594 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4595 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4596 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4597 64-bit hosts.
4598 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4599 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4600 * print.c (safe_debug_print, print_object): Likewise.
4601 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4602 to int.
6f04d126
PE
4603 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4604 avoiding the 0 flag, which is not portable.
c2982e87
PE
4605 * process.c (Fmake_network_process): Use pI to avoid cast.
4606 * region-cache.c (pp_cache): Likewise.
4607 * xdisp.c (decode_mode_spec): Likewise.
4608 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4609 behavior on 64-bit hosts with printf arg.
6f04d126 4610 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4611 (x_stop_queuing_selection_requests): Likewise.
4612 (x_get_window_property): Don't truncate byte count to an 'int'
4613 when tracing.
0b432f21 4614
5e073ec7
PE
4615 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4616 here, since it parses constructs like leading '-' and spaces,
4617 which are not wanted; and it overflows with large numbers.
4618 Instead, simply match F[0-9]+, which is what is wanted anyway.
4619
36372bf9
PE
4620 * alloc.c: Remove unportable assumptions about struct layout.
4621 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4622 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4623 (allocate_vectorlike, make_pure_vector): Use the new macros,
4624 plus offsetof, to remove unportable assumptions about struct layout.
4625 These assumptions hold on all porting targets that I know of, but
4626 they are not guaranteed, they're easy to remove, and removing them
4627 makes further changes easier.
4628
0b432f21
PE
4629 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4630 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4631 (string_overrun_cookie): Now const. Use initializers that
4632 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4633 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4634 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4635 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4636 multiple of sizeof (EMACS_INT); it need not be, if
4637 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4638 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4639
895009e1
JB
46402011-04-26 Juanma Barranquero <lekktu@gmail.com>
4641
4642 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4643
6a7a1b0b
TZ
46442011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4645
4646 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4647 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4648 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4649
841a1577 46502011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4651
4652 * lisp.h (Qdebug): List symbol.
895009e1 4653 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4654 * keyboard.c (debug-on-event): New variable.
4655 (handle_user_signal): Break into debugger when debug-on-event
4656 matches the current signal symbol.
4657
f2d3ba6f
DN
46582011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4659
4660 * alloc.c (check_sblock, check_string_bytes)
4661 (check_string_free_list): Convert to standard C.
4662
42ce4c63
TZ
46632011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4664
4665 * w32.c (emacs_gnutls_push): Fix typo.
4666
825cd63c
EZ
46672011-04-25 Eli Zaretskii <eliz@gnu.org>
4668
fb11d64d
EZ
4669 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4670 "cast to pointer from integer of different size".
4671
825cd63c
EZ
4672 Improve doprnt and its use in verror. (Bug#8545)
4673 * doprnt.c (doprnt): Document the set of format control sequences
4674 supported by the function. Use SAFE_ALLOCA instead of always
4675 using `alloca'.
4676
4677 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4678 is one byte too soon. Don't use xrealloc; instead xfree and
4679 xmalloc anew.
4680
e061a11b
TZ
46812011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4682
4683 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4684 callbacks stage.
4685
4686 * gnutls.c: Renamed global_initialized to
4687 gnutls_global_initialized. Added internals for the
4688 :verify-hostname-error, :verify-error, and :verify-flags
4689 parameters of `gnutls-boot' and documented those parameters in the
4690 docstring. Start callback support.
9173deec
JB
4691 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4692 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4693 on error. Return error code.
e061a11b
TZ
4694 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4695 (emacs_gnutls_read): Likewise.
4696 (Fgnutls_boot): Return handshake error code.
4697 (emacs_gnutls_handle_error): New function.
4698 (wsaerror_to_errno): Likewise.
4699
4700 * w32.h (emacs_gnutls_pull): Add prototype.
4701 (emacs_gnutls_push): Likewise.
4702
4703 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4704 (emacs_gnutls_push): Likewise.
4705
47062011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4707
4708 * process.c (wait_reading_process_output): Check if GnuTLS
4709 buffered some data internally if no FDs are set for TLS
4710 connections.
4711
4712 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4713 (LIBS): Link to USER_LIBS.
4714 ($(BLD)/gnutls.$(0)): New target.
4715
fa6996bc
EZ
47162011-04-24 Eli Zaretskii <eliz@gnu.org>
4717
eb35682e
EZ
4718 * xdisp.c (handle_single_display_spec): Rename the
4719 display_replaced_before_p argument into display_replaced_p, to
4720 make it consistent with the commentary. Fix typos in the
4721 commentary.
4722
e2ad650c
EZ
4723 * textprop.c (syms_of_textprop): Remove dead code.
4724 (copy_text_properties): Delete obsolete commentary about an
4725 interface that was deleted long ago. Fix typos in the description
4726 of arguments.
4727
1b2de274
EZ
4728 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4729 to changes in oldXMenu/XMenu.h from 2011-04-16.
4730 <menu_help_message, prev_menu_help_message>: Constify.
4731 (IT_menu_make_room): menu->help_text is now `const char **';
4732 adjust.
4733
4734 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4735 to changes in oldXMenu/XMenu.h from 2011-04-16.
4736 (struct XMenu): Declare `help_text' `const char **'.
4737
4738 * xfaces.c <Qunspecified>: Make extern again.
4739
4740 * syntax.c: Include sys/types.h before including regex.h, as
4741 required by Posix.
4742
762b15be
EZ
4743 * doc.c (get_doc_string): Improve the format passed to `error'.
4744
4745 * doprnt.c (doprnt): Improve commentary.
4746
4747 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4748
4749 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4750 them with etags.
4751
f1052e5d
EZ
4752 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4753 changes in globals.h immediately force recompilation.
762b15be
EZ
4754 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4755 $(CURDIR)/s/ms-w32.h.
4756 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4757
fa6996bc
EZ
4758 * character.c (Fchar_direction): Function deleted.
4759 (syms_of_character): Don't defsubr it.
4760 <char-direction-table>: Deleted.
4761
e6c3da20
EZ
47622011-04-23 Eli Zaretskii <eliz@gnu.org>
4763
4764 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4765 * doprnt.c: Include limits.h.
4766 (SIZE_MAX): New macro.
04f2d78b
CB
4767 (doprnt): Return a size_t value. 2nd arg is now size_t.
4768 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4769 Improve overflow protection. Support `l' modifier for integer
4770 conversions. Support %l conversion. Don't assume an EMACS_INT
4771 argument for integer conversions and for %c.
4772
4773 * lisp.h (doprnt): Restore prototype.
4774
4775 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4776 $(SRC)/character.h.
4777
4778 * Makefile.in (base_obj): Add back doprnt.o.
4779
4780 * deps.mk (doprnt.o): Add back prerequisites.
4781 (callint.o): Depend on character.h.
4782
4783 * eval.c (internal_lisp_condition_case): Include the handler
4784 representation in the error message.
4785 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4786 when breaking from the loop.
4787
4788 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4789
4790 * callint.c (Fcall_interactively): When displaying error message
4791 about invalid control letter, pass the character's codepoint, not
4792 a pointer to its multibyte form. Improve display of the character
4793 in octal and display also its hex code.
4794
4795 * character.c (char_string): Use %x to display the (unsigned)
4796 codepoint of an invalid character, to avoid displaying a bogus
4797 negative value.
4798
4799 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4800 `error', not SYMBOL_NAME itself.
4801
4802 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4803 character arguments to `error'.
4804
4805 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4806 to `error' in error message about FINAL_CHAR argument. Make sure
4807 FINAL_CHAR is a character, and use %c when it is passed as
4808 argument to `error'.
4809
4ffd0d6b 48102011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4811
4812 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4813
4814 * w32.c: Include <time.h>.
4815 (sys_localtime): New function.
4816
4ffd0d6b 48172011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4818
4819 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4820
4ffd0d6b 4821 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4822
4ffd0d6b 48232011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4824
4ffd0d6b
GM
4825 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4826 zombies (Bug#8467).
aac0c6e3 4827
04c56954
EZ
48282011-04-19 Eli Zaretskii <eliz@gnu.org>
4829
4830 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4831 gl_state.e_property when gl_state.object is Qt.
4832
4833 * insdel.c (make_gap_larger): Remove limitation of buffer size
4834 to <= INT_MAX.
4835
16a43933
CY
48362011-04-18 Chong Yidong <cyd@stupidchicken.com>
4837
4838 * xdisp.c (lookup_glyphless_char_display)
4839 (produce_glyphless_glyph): Handle cons cell entry in
4840 glyphless-char-display.
4841 (Vglyphless_char_display): Document it.
4842
4843 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4844 glyphless-char-display.
4845
4581706e
CY
48462011-04-17 Chong Yidong <cyd@stupidchicken.com>
4847
4848 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4849
4850 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4851
4852 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4853 definition for no-X builds.
4854
4887c6e2 48552011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4856
fd35b6f9
PE
4857 Static checks with GCC 4.6.0 and non-default toolkits.
4858
5c1ccb01
PE
4859 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4860
006c5daa
PE
4861 * process.c (keyboard_bit_set): Define only if SIGIO.
4862 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4863 (send_process): Repair possible setjmp clobbering.
4864
efc736d3
PE
4865 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4866
4e2fe2e6
PE
4867 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4868
f97334a2
PE
4869 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4870
4e75f29d
PE
4871 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4872 Define only if needed.
4873
90efadd1
PE
4874 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4875 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4876 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4877
3c647824
PE
4878 * dispextern.h (struct redisplay_interface): Rename param
4879 to avoid shadowing.
e264f262 4880 * termhooks.h (struct terminal): Likewise.
761383f4 4881 * xterm.c (xembed_send_message): Likewise.
3c647824 4882
b58c5c4a
PE
4883 * insdel.c (make_gap_smaller): Define only if
4884 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4885
cad59032
PE
4886 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4887 it.
4888
c339dc2e
PE
4889 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4890 so that we aren't warned about unused symbols.
4891
91a3e27b
PE
4892 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4893
399c71d3 4894 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4895
8ffc96f5
PE
4896 * xfns.c (x_real_positions): Mark locals as initialized.
4897
eef9bc79
PE
4898 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4899
098db9dd
PE
4900 * xterm.c: Fix problems found by static analysis with other toolkits.
4901 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4902 (x_dispatch_event): Declare static if USE_GTK, and
4903 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4904 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4905 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4906 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4907 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4908
eb18f6cc
PE
4909 * xmenu.c (menu_help_callback): Pointer type fixes.
4910 Use const pointers when pointing at readonly data. Avoid pointer
4911 signedness clashes.
4912 (FALSE): Remove unused macro.
4913 (update_frame_menubar): Remove unused decl.
4914
1fe72bf8
PE
4915 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4916
60d9e1db
PE
4917 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4918 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4919 (single_menu_item): Rename local to avoid shadowing.
4920
39261c26
PE
4921 * keyboard.c (make_lispy_event): Remove unused local var.
4922
018c5e19
PE
4923 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4924 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4925
63d2b86e
PE
4926 * bitmaps: Change bitmaps from unsigned char back to the X11
4927 compatible char. Avoid the old compiler warnings about
4928 out-of-range initializers by using, for example, '\xab' rather
4929 than 0xab.
4930
aefd87e1
PE
4931 * xgselect.c (xgselect_initialize): Check vs interface
4932 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4933
bf501fb9
PE
4934 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4935
e9829fdf
PE
4936 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4937 to read-only memory.
4938
1086c095
PE
4939 * fns.c (vector): Remove; this old hack is no longer needed.
4940
2baccd04 4941 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4942 Remove unused var.
dde42981 4943 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4944
72391843 4945 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4946
436c16df 4947 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4948 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4949 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4950
92bb796d 4951 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4952 (x_term_init): Remove local to avoid shadowing.
92bb796d 4953
764430a3 4954 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4955
4956 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4957 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4958
d1dfb56c
EZ
49592011-04-16 Eli Zaretskii <eliz@gnu.org>
4960
c4354cb4
EZ
4961 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4962
d1dfb56c
EZ
4963 Fix regex.c, syntax.c and friends for buffers > 2GB.
4964 * syntax.h (struct gl_state_s): Declare character position members
4965 EMACS_INT.
4966
4967 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4968
04f2d78b
CB
4969 * textprop.c (verify_interval_modification, interval_of):
4970 Declare arguments EMACS_INT.
d1dfb56c
EZ
4971
4972 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4973 EMACS_INT.
4974
4975 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4976
4977 * indent.c (Fvertical_motion): Local variable it_start is now
4978 EMACS_INT.
4979
4980 * regex.c (re_match, re_match_2, re_match_2_internal)
4981 (bcmp_translate, regcomp, regexec, print_double_string)
4982 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4983 (re_compile_pattern, re_exec): Declare arguments and local
4984 variables `size_t' and `ssize_t' and return values `regoff_t', as
4985 appropriate.
4986 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4987 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4988 <compile_stack_type>: `size' and `avail' are now `size_t'.
4989
4990 * regex.h <regoff_t>: Use ssize_t, not int.
4991 (re_search, re_search_2, re_match, re_match_2): Arguments that
4992 specify buffer/string position and length are now ssize_t and
4993 size_t. Return type is regoff_t.
4994
613052cd
BK
49952011-04-16 Ben Key <bkey76@gmail.com>
4996
4997 * nsfont.m: Fixed bugs in ns_get_family and
4998 ns_descriptor_to_entity that were caused by using free to
4999 deallocate memory blocks that were allocated by xmalloc (via
5000 xstrdup). This caused Emacs to crash when compiled with
5001 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5002 --enable-checking=xmallocoverrun). xfree is now used to
5003 deallocate these memory blocks.
5004
4170f62f 50052011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5006
71b41406
PE
5007 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5008
9587a89d
PE
5009 emacs_write: Accept and return EMACS_INT for sizes.
5010 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5011 et seq.
5012 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5013 Accept and return EMACS_INT.
5014 (emacs_gnutls_write): Return the number of bytes written on
5015 partial writes.
5016 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5017 (emacs_read, emacs_write): Remove check for negative size, as the
5018 Emacs source code has been audited now.
9587a89d
PE
5019 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5020 (emacs_read, emacs_write): Use it.
273a5f82
PE
5021 * process.c (send_process): Adjust to the new signatures of
5022 emacs_write and emacs_gnutls_write. Do not attempt to store
5023 a byte offset into an 'int'; it might overflow.
9587a89d 5024 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5025
3e047f51
PE
5026 * sound.c: Don't assume sizes fit in 'int'.
5027 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5028 Return EMACS_INT, not int.
3e047f51 5029 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5030 Accept EMACS_INT, not int.
5031 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5032 record read return values.
5033
cc39a9db
BK
50342011-04-15 Ben Key <bkey76@gmail.com>
5035
c9d0ec6d
JB
5036 * keyboard.c (Qundefined): Don't declare static since it is used
5037 in nsfns.m.
5038 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5039 static since they are used in nsfont.m.
cc39a9db 5040
6c60eb9f
SM
50412011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5042
5043 * process.c (Qprocessp): Don't declare static.
5044 * lisp.h (Qprocessp): Declare again.
5045
7990b61a
JB
50462011-04-15 Juanma Barranquero <lekktu@gmail.com>
5047
5048 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5049
5d4cb038
PE
50502011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5051
8bd7b830 5052 Improve C-level modularity by making more things 'static'.
cd64ea1d 5053
e3b27b31
PE
5054 Don't publish debugger-only interfaces to other modules.
5055 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5056 (verify_bytepos, count_markers): Move decls to the only modules
5057 that need them.
5058 * region-cache.h (pp_cache): Likewise.
5059 * window.h (check_all_windows): Likewise.
5060 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5061
5d4cb038
PE
5062 * sysdep.c (croak): Now static, if
5063 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5064 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5065
5066 * alloc.c (refill_memory_reserve): Now static if
5067 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5068 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5069
e87b6180
PE
5070 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5071 Define only if USE_LUCID.
5072
ac64929e
PE
5073 * xrdb.c (x_customization_string, x_rm_string): Now static.
5074
6f37259d
PE
5075 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5076 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5077
1683e3ab
PE
5078 * xdisp.c (draw_row_with_mouse_face): Now static.
5079 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5080
de9c2632
PE
5081 * window.h (check_all_windows): Mark externally visible.
5082
2b96acb7
PE
5083 * window.c (window_deletion_count): Now static.
5084
5085 * undo.c: Make symbols static if they're not exported.
5086 (last_undo_buffer, last_boundary_position, pending_boundary):
5087 Now static.
5088
50436f33
PE
5089 * textprop.c (interval_insert_behind_hooks): Now static.
5090 (interval_insert_in_front_hooks): Likewise.
5091
64520e5c
PE
5092 * term.c: Make symbols static if they're not exported.
5093 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5094 (max_frame_lines, tty_set_terminal_modes):
5095 (tty_reset_terminal_modes, tty_turn_off_highlight):
5096 (get_tty_terminal): Now static.
5097 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5098 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5099 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5100 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5101 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5102
1fa53021
PE
5103 * sysdep.c: Make symbols static if they're not exported.
5104 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5105 Now static.
5106 (sigprocmask_set, full_mask): Remove; unused.
5107 (wait_debugging): Mark as visible.
5108 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5109 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5110
d4b43b22
PE
5111 * syntax.c (syntax_temp): Define only if !__GNUC__.
5112
b7c513d0
PE
5113 * sound.c (current_sound_device, current_sound): Now static.
5114
989b29ad
PE
5115 * search.c (searchbufs, searchbuf_head): Now static.
5116
13a55a78
PE
5117 * scroll.c (scroll_cost): Remove; unused.
5118 * dispextern.h (scroll_cost): Remove decl.
5119
de68a1fc
PE
5120 * region-cache.h (pp_cache): Mark as externally visible.
5121
40ccffa6
PE
5122 * process.c: Make symbols static if they're not exported.
5123 (process_tick, update_tick, create_process, chan_process):
5124 (Vprocess_alist, proc_buffered_char, datagram_access):
5125 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5126 (deactivate_process): Mark defn as static, as well as decl.
5127 * lisp.h (create_process): Remove decl.
5128 * process.h (chan_process, Vprocess_alist): Remove decls.
5129
ad64fc97
PE
5130 * print.c: Make symbols static if they're not exported.
5131 (print_depth, new_backquote_output, being_printed, print_buffer):
5132 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5133 (print_interval, print_number_index, initial_stderr_stream):
5134 Now static.
5135 * lisp.h (Fprinc): Remove decl.
5136 (debug_output_compilation_hack): Mark as externally visible.
5137
adddb265
PE
5138 * sysdep.c (croak): Move decl from here to syssignal.h.
5139 * syssignal.h (croak): Put it here, so the API can be checked when
5140 'croak' is called from dissociate_if_controlling_tty.
5141
1717ede2
PE
5142 * minibuf.c: Make symbols static if they're not exported.
5143 (minibuf_save_list, choose_minibuf_frame): Now static.
5144 * lisp.h (choose_minibuf_frame): Remove decl.
5145
fa5fb2bc
PE
5146 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5147
1e3890d1
PE
5148 * lread.c: Make symbols static if they're not exported.
5149 (read_objects, initial_obarray, oblookup_last_bucket_number):
5150 Now static.
5151 (make_symbol): Remove; unused.
5152 * lisp.h (initial_obarray, make_symbol): Remove decls.
5153
8a1414fa
PE
5154 * keyboard.c: Make symbols static if they're not exported.
5155 (single_kboard, recent_keys_index, total_keys, recent_keys):
5156 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5157 (this_single_command_key_start, echoing, last_auto_save):
5158 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5159 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5160 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5161 (Vlispy_mouse_stem, double_click_count):
5162 Now static.
5163 (force_auto_save_soon): Define only if SIGDANGER.
5164 (ignore_mouse_drag_p): Now static if
5165 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5166 (print_help): Remove; unused.
5167 (stop_character, last_timer_event): Mark as externally visible.
5168 * keyboard.h (ignore_mouse_drag_p): Declare only if
5169 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5170 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5171 * lisp.h (echoing): Remove decl.
5172 (force_auto_save_soon): Declare only if SIGDANGER.
5173 * xdisp.c (redisplay_window): Simplify code, to make it more
5174 obvious that ignore_mouse_drag_p is not accessed if !defined
5175 USE_GTK && !defined HAVE_NS.
5176
93ea6e8f
PE
5177 * intervals.c: Make symbols static if they're not exported.
5178 (merge_properties_sticky, merge_interval_right, delete_interval):
5179 Now static.
5180 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5181
77382fcc
PE
5182 * insdel.c: Make symbols static if they're not exported.
5183 However, leave prepare_to_modify_buffer alone. It's never
5184 called from outside this function, but that appears to be a bug.
5185 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5186 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5187 (adjust_after_replace_noundo): Remove; unused.
5188 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5189 (signal_before_change): Remove decls.
77382fcc 5190
9306c32e
PE
5191 * indent.c (val_compute_motion, val_vmotion): Now static.
5192
cd44d2eb
PE
5193 * image.c: Make symbols static if they're not exported.
5194 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5195 if USE_GTK.
5196 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5197 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5198
ad9a7a06
PE
5199 * fringe.c (standard_bitmaps): Now static.
5200 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5201
81626931
PE
5202 * frame.c: Make symbols static if they're not exported.
5203 (x_report_frame_params, make_terminal_frame): Now static.
5204 (get_frame_param): Now static, unless HAVE_NS.
5205 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5206 (x_get_resource_string): Remove; not used.
5207 * frame.h (make_terminal_frame, x_report_frame_params):
5208 (x_get_resource_string); Remove decls.
5209 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5210 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5211
239f9db9
PE
5212 * font.c, fontset.c: Make symbols static if they're not exported.
5213 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5214 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5215 * font.c (font_close_object): Now static.
5216 * font.h (font_close_object): Remove.
5217 * fontset.c (FONTSET_OBJLIST): Remove.
5218 (free_realized_fontset) #if-0 the body, which does nothing.
5219 (face_suitable_for_char_p): #if-0, as it's never called.
5220 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5221 * xfaces.c (face_at_string_position):
5222 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5223 since 0 is always ASCII.
5224
dfcf3579
PE
5225 * fns.c (weak_hash_tables): Now static.
5226
5045092b
PE
5227 * fileio.c: Make symbols static if they're not exported.
5228 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5229 (Vwrite_region_annotation_buffers): Now static.
5230
57a96f5c
PE
5231 * eval.c: Make symbols static if they're not exported.
5232 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5233 * lisp.h (backtrace_list): Remove decl.
5234
35f08c38
PE
5235 * emacs.c: Make symbols static if they're not exported.
5236 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5237 (fatal_error_code, fatal_error_signal_hook, standard_args):
5238 Now static.
5239 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5240 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5241 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5242 * lisp.h (fatal_error_signal_hook): Remove decl.
5243 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5244
f44bd759
PE
5245 * editfns.c: Move a (normally-unused) function to its only use.
5246 * editfns.c, lisp.h (get_operating_system_release): Remove.
5247 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5248 worth the hassle of breaking this out.
5249
b532497d
PE
5250 * xterm.c: Make symbols static if they're not exported.
5251 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5252 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5253 (x_destroy_window, x_delete_display):
5254 Now static.
5255 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5256 (x_mouse_leave): Remove; unused.
5257 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5258 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5259 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5260 Remove decls.
5261 (x_mouse_leave): Declare only if WINDOWSNT.
5262 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5263 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5264 USE_X_TOOLKIT.
5265
1675728f
PE
5266 * ftxfont.c: Make symbols static if they're not exported.
5267 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5268 HAVE_FREETYPE.
5269 * font.h (ftxfont_driver): Likewise.
5270
e4cebfca
PE
5271 * xfns.c: Make symbols static if they're not exported.
5272 (x_last_font_name, x_display_info_for_name):
5273 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5274 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5275 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5276 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5277 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5278 (last_show_tip_args): Now static.
5279 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5280 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5281 (x_screen_planes): Remove; unused.
5282 * dispextern.h (x_screen_planes): Remove decl.
5283
5bf46f05
PE
5284 * dispnew.c: Make symbols static if they're not exported.
5285 * dispextern.h (redraw_garbaged_frames, scrolling):
5286 (increment_row_positions): Remove.
5287 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5288 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5289 Now static.
5290 (redraw_garbaged_frames): Remove; unused.
5291
435f4c28
PE
5292 * xfaces.c: Make symbols static if they're not exported.
5293 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5294 Remove decls.
5295 * xterm.h (defined_color): Remove decls.
5296 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5297 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5298 (menu_face_changed_default, defined_color, free_realized_face):
5299 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5300 (ascii_face_of_lisp_face): Remove; unused.
5301
8524aef3
PE
5302 * xdisp.c: Make symbols static if they're not exported.
5303 * dispextern.h (scratch_glyph_row, window_box_edges):
5304 (glyph_to_pixel_coords, set_cursor_from_row):
5305 (get_next_display_element, set_iterator_to_next):
5306 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5307 (show_mouse_face): Remove decls
5308 * frame.h (message_buf_print): Likewise.
5309 * lisp.h (pop_message, set_message, check_point_in_composition):
5310 Likewise.
5311 * xterm.h (set_vertical_scroll_bar): Likewise.
5312 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5313 (message_buf_print, scratch_glyph_row, displayed_buffer):
5314 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5315 (get_next_display_element, show_mouse_face, window_box_edges):
5316 (frame_to_window_pixel_xy, check_point_in_composition):
5317 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5318 (glyph_to_pixel_coords): Remove; unused.
5319
16390cd2
PE
5320 * dired.c (file_name_completion): Now static.
5321
5322 * dbusbind.c (xd_in_read_queued_messages): Now static.
5323
a25f4dfa
PE
5324 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5325 * data.c (circular_list_error): Remove.
5326
14a9c8df
PE
5327 * commands.h (last_point_position, last_point_position_buffer):
5328 (last_point_position_window): Remove decls.
5329 * keyboard.c: Make these variables static.
5330
04f2d78b
CB
5331 * coding.h (coding, code_convert_region, encode_coding_gap):
5332 Remove decls.
74ab6df5
PE
5333 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5334 (iso_code_class, detect_coding, code_convert_region): Now static.
5335 (encode_coding_gap): Remove; unused.
5336
38dfbee1
PE
5337 * chartab.c (chartab_chars, chartab_bits): Now static.
5338
a2cb4e63
PE
5339 * charset.h (charset_iso_8859_1): Remove decl.
5340 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5341 Now static.
5342
127198fd
PE
5343 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5344 * ccl.c (Vccl_program_table): Now static.
5345 (check_ccl_update): Remove; unused.
5346
d85b608f
PE
5347 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5348 * category.h: ... from here.
5349 * category.c (check_category_table, set_category_set): Now static.
5350
31cd66f3
PE
5351 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5352 * lisp.h: Remove these decls.
5353
c358e587
PE
5354 * buffer.c (buffer_count): Remove unused var.
5355
e78aecca
PE
5356 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5357 so that it's not optimized away.
5358 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5359 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5360 exported only to the debugger.
5361
e192d7d3 5362 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5363 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5364
92470028
PE
5365 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5366 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5367 was inaccessible from Lisp.
5368 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5369 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5370
244ed907
PE
5371 alloc.c: Import and export fewer symbols, and remove unused items.
5372 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5373 is defined.
5374 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5375 it's not optimized away by whole-program optimization.
5376 (message_enable_multibyte, free_misc): Remove.
5377 (catchlist, handlerlist, mark_backtrace):
5378 Declare only if BYTE_MARK_STACK.
5379 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5380 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5381 (message_enable_multibyte): Remove decl.
5382 (free_misc, interval_free_list, float_block, float_block_index):
5383 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5384 (cons_free_list, last_marked_index):
5385 Now static.
5386 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5387 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5388 (mark_backtrace): Define only if BYTE_MARK_STACK.
5389 * xdisp.c (message_enable_multibyte): Now static.
5390
61c2b50e 5391 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5392 This makes it easier for human readers (and static analyzers)
5393 to see whether these variables are used from other modules.
5394 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5395 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5396 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5397 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5398 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5399 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5400 * xmenu.c, xselect.c:
5401 Declare Q* vars static if they are not used in other modules.
5402 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5403 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5404 Remove decls of unexported vars.
5405 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5406
95c82688
PE
5407 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5408
16a97296
PE
5409 Make Emacs functions such as Fatom 'static' by default.
5410 This makes it easier for human readers (and static analyzers)
5411 to see whether these functions can be called from other modules.
5412 DEFUN now defines a static function. To make the function external
5413 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5414 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5415 (Finit_image_library):
16a97296
PE
5416 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5417 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5418 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5419 Remove decls, since these functions are now static.
5420 (Funintern, Fget_internal_run_time): New decls, since these functions
5421 were already external.
95c82688 5422
16a97296
PE
5423 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5424 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5425 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5426 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5427 * keyboard.c, keymap.c, lread.c:
5428 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5429 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5430 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5431 Mark functions with DEFUE instead of DEFUN,
5432 if they are used in other modules.
5433 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5434 decls for now-static functions.
5435 * buffer.h (Fdelete_overlay): Remove decl.
5436 * callproc.c (Fgetenv_internal): Mark as internal.
5437 * composite.c (Fremove_list_of_text_properties): Remove decl.
5438 (Fcomposition_get_gstring): New forward static decl.
5439 * composite.h (Fcomposite_get_gstring): Remove decl.
5440 * dired.c (Ffile_attributes): New forward static decl.
5441 * doc.c (Fdocumntation_property): New forward static decl.
5442 * eval.c (Ffetch_bytecode): New forward static decl.
5443 (Funintern): Remove extern decl; now in .h file where it belongs.
5444 * fileio.c (Fmake_symbolic_link): New forward static decl.
5445 * image.c (Finit_image_library): New forward static decl.
5446 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5447 * intervals.h (Fprevious_property_change):
5448 (Fremove_list_of_text_properties): Remove decls.
5449 * keyboard.c (Fthis_command_keys): Remove decl.
5450 (Fcommand_execute): New forward static decl.
5451 * keymap.c (Flookup_key): New forward static decl.
5452 (Fcopy_keymap): Now static.
5453 * keymap.h (Flookup_key): Remove decl.
5454 * process.c (Fget_process): New forward static decl.
5455 (Fprocess_datagram_address): Mark as internal.
5456 * syntax.c (Fsyntax_table_p): New forward static decl.
5457 (skip_chars): Remove duplicate decl.
5458 * textprop.c (Fprevious_property_change): New forward static decl.
5459 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5460 Now internal.
5461 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5462 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5463
785bbd42
PE
5464 * editfns.c (Fformat): Remove unreachable code.
5465
8b913b57
AS
54662011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5467
5468 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5469 change. (Bug#8496)
5470
a6744a35
EZ
54712011-04-13 Eli Zaretskii <eliz@gnu.org>
5472
5473 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5474 when at ZV. (Bug#8487)
5475
e7974947
AS
54762011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5477
baad03f0
AS
5478 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5479 (Bug#8437)
5480 * keyboard.c (parse_tool_bar_item): Likewise.
5481 * sound.c (sound_cleanup, alsa_close): Likewise.
5482 * termcap.c (tgetent): Likewise.
5483 * xfns.c (x_default_font_parameter): Likewise.
5484 * xsettings.c (read_and_apply_settings): Likewise.
5485
e7974947
AS
5486 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5487 (overrun_check_free): Protoize.
5488
28272684
PE
54892011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5490
5491 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5492 since callers should never pass a negative size.
5493 Change the signature to match that of plain 'read' and 'write'; see
5494 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5495 * lisp.h: Update prototypes of emacs_write and emacs_read.
5496
11997c76
EZ
54972011-04-11 Eli Zaretskii <eliz@gnu.org>
5498
5499 * xdisp.c (redisplay_window): Don't try to determine the character
5500 position of the scroll margin if the window start point w->startp
e896f03c 5501 is outside the buffer's accessible region. (Bug#8468)
11997c76 5502
8a2cbd72
EZ
55032011-04-10 Eli Zaretskii <eliz@gnu.org>
5504
5505 Fix write-region and its subroutines for buffers > 2GB.
5506 * fileio.c (a_write, e_write): Modify declaration of arguments and
5507 local variables to support buffers larger than 2GB.
5508 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5509
5510 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5511 argument, local variables, and return value.
5512
5513 * lisp.h: Update prototypes of emacs_write and emacs_read.
5514
5515 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5516
4073e537 55172011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5518
1ebfdcb6
PE
5519 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5520
b2ded58d
PE
5521 Fix more problems found by GCC 4.6.0's static checks.
5522
7d66342c
PE
5523 * xdisp.c (vmessage): Use a better test for character truncation.
5524
bbf47d44
PE
5525 * charset.c (load_charset_map): <, not <=, for optimization,
5526 and to avoid potential problems with integer overflow.
9248994d 5527 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5528 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5529 * editfns.c (Fformat): Likewise.
1e69125e 5530 * syntax.c (skip_chars): Likewise.
3befa583 5531
e3019616
PE
5532 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5533 This also lets GCC 4.6.0 generate slightly better loop code.
5534
becfa255
PE
5535 * callint.c (Fcall_interactively): <, not <=, for optimization.
5536 (Fcall_interactively): Count the number of arguments produced,
5537 not the number of arguments given. This is simpler and lets GCC
5538 4.6.0 generate slightly better code.
5539
dae0cd48
PE
5540 * ftfont.c: Distingish more carefully between FcChar8 and char.
5541 The previous code passed unsigned char * to a functions like
5542 strlen and xstrcasecmp that expect char *, which does not
5543 conform to the C standard.
5544 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5545 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5546 char * when the C standard requires it.
5547
76032d70
PE
5548 * keyboard.c (read_char): Remove unused var.
5549
eb3f1cc8
PE
5550 * eval.c: Port to Windows vsnprintf (Bug#8435).
5551 Include <limits.h>.
5552 (SIZE_MAX): Define if the headers do not.
5553 (verror): Do not give up if vsnprintf returns a negative count.
5554 Instead, grow the buffer. This ports to Windows vsnprintf, which
5555 does not conform to C99. Problem reported by Eli Zaretskii.
5556 Also, simplify the allocation scheme, by avoiding the need for
5557 calling realloc, and removing the ALLOCATED variable.
5558
70476b54
PE
5559 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5560
12020a9e
PE
5561 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5562 But keep the doprint source code for now, as we might revamp it
5563 and use it again (Bug#8435).
ea6c7ae6
PE
5564 * lisp.h (doprnt): Remove.
5565 * Makefile.in (base_obj): Remove doprnt.o.
5566 * deps.mk (doprnt.o): Remove.
5567
5fdb398c
PE
5568 error: Print 32- and 64-bit integers portably (Bug#8435).
5569 Without this change, on typical 64-bit hosts error ("...%d...", N)
5570 was used to print both 32- and 64-bit integers N, which relied on
5571 undefined behavior.
5572 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5573 New macro.
5574 * lisp.h (error, verror): Mark as printf-like functions.
5575 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5576 Report overflow in size calculations when allocating printf buffer.
5577 Do not truncate output string at its first null byte.
5578 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5579 Truncate the output at a character boundary, since vsnprintf does not
5580 do that.
5581 * charset.c (check_iso_charset_parameter): Convert internal
5582 character to string before calling 'error', since %c now has the
5583 printf meaning.
5584 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5585 overflow when computing char to be passed to 'error'. Do not
5586 pass Lisp_Object to 'error'; pass the integer instead.
5587 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5588 formatted with plain %d.
5589
b189fa66
PE
5590 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5591
bff87ef0
PE
5592 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5593
7e2cac20
PE
5594 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5595
ce4d90b5
PE
5596 * xterm.c (x_catch_errors): Remove duplicate declaration.
5597
266c9547
PE
5598 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5599
79c49ad2
PE
5600 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5601
368f4090
JM
56022011-04-10 Jim Meyering <meyering@redhat.com>
5603
5604 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5605 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5606 return ssize_t not "int", and use size_t as the buffer length.
5607 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5608 * gnutls.h: Update declarations.
5609 * process.c (read_process_output): Use ssize_t, to match.
5610 (send_process): Likewise.
5611
a32d4040
CY
56122011-04-09 Chong Yidong <cyd@stupidchicken.com>
5613
5614 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5615
8546720e 56162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5617
04f2d78b
CB
5618 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5619 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5620
8546720e
GM
5621 * xterm.c (handle_one_xevent):
5622 * xmenu.c (create_and_show_popup_menu):
5623 * xselect.c (x_decline_selection_request)
5624 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5625
0a2f5c1a 56262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5627
5628 Fix some uses of `int' instead of EMACS_INT.
5629 * search.c (string_match_1, fast_string_match)
5630 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5631 (scan_buffer, find_next_newline_no_quit)
5632 (find_before_next_newline, search_command, Freplace_match)
5633 (Fmatch_data): Make some `int' variables be EMACS_INT.
5634
5635 * xdisp.c (display_count_lines): 3rd argument and return value now
5636 EMACS_INT. All callers changed.
5637 (pint2hrstr): Last argument is now EMACS_INT.
5638
5639 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5640 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5641 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5642 (decode_coding_utf_16, decode_coding_emacs_mule)
5643 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5644 (decode_coding_ccl, decode_coding_charset)
5645 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5646 (decode_coding_iso_2022, decode_coding_emacs_mule)
5647 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5648 <char_offset, last_offset>: Declare EMACS_INT.
5649 (encode_coding_utf_8, encode_coding_utf_16)
5650 (encode_coding_emacs_mule, encode_invocation_designation)
5651 (encode_designation_at_bol, encode_coding_iso_2022)
5652 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5653 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5654 Declare EMACS_INT.
5655 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5656 (encode_invocation_designation): Last argument P_NCHARS is now
5657 EMACS_INT.
5658 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5659 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5660
5661 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5662 All users changed.
5663
5664 * ccl.c (Fccl_execute_on_string): Declare some variables
5665 EMACS_INT.
5666
8546720e 56672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5668
5669 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5670
4e19a977
CS
56712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5672
5673 * process.c (Fformat_network_address): Doc fix.
5674
87302331
R
56752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5676
5677 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5678
cbb59342
CY
56792011-04-08 Chong Yidong <cyd@stupidchicken.com>
5680
5681 * keyboard.c (read_char): Call Lisp function help-form-show,
5682 instead of using internal_with_output_to_temp_buffer.
5683 (Qhelp_form_show): New var.
e0d38eeb 5684 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5685
5686 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5687
5688 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5689
e67a13ab
CY
56902011-04-06 Chong Yidong <cyd@stupidchicken.com>
5691
04f2d78b
CB
5692 * process.c (Flist_processes): Remove to Lisp.
5693 (list_processes_1): Delete.
e67a13ab 5694
973f782d
EZ
56952011-04-06 Eli Zaretskii <eliz@gnu.org>
5696
7c106b1e
EZ
5697 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5698
973f782d
EZ
5699 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5700
41cf7d1a 57012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5702
ca23cc88
PE
5703 Fix more problems found by GCC 4.6.0's static checks.
5704
f390e2d5
PE
5705 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5706
42eea0d0
PE
5707 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5708
b69769da 5709 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5710
f9541e84
PE
5711 * xdisp.c (vmessage): Mark as a printf-like function.
5712
13841b55
PE
5713 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5714
c136c10f
PE
5715 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5716
5e2d4a30
PE
5717 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5718 printf-like functions.
5719 (tiff_load): Add casts to remove these marks before passing them
5720 to system-supplied API.
5721
583f48b9
PE
5722 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5723
b25d760e
PE
5724 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5725 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5726 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5727 directly, rather than having caller test rule sign. This avoids
5728 some unnecessary tests.
5729 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5730 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5731 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5732
bc7b6697 5733 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5734 (xfont_open): Avoid unnecessary tests.
bc7b6697 5735
27ccc379
PE
5736 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5737
dcd5c89a
PE
5738 * composite.h, composite.c (composition_gstring_put_cache):
5739 Use EMACS_INT, not int, for length.
5740
b13a45c6
PE
5741 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5742 breaking out part of COMPOSITION_DECODE_RULE.
5743 (COMPOSITION_DECODE_RULE): Use it.
5744 * composite.c (get_composition_id): Remove unused local vars,
5745 by using the new macro.
5746
1e792e4d
PE
5747 * textprop.c (set_text_properties_1): Change while to do-while,
5748 since the condition is always true at first.
5749
dc6c6455 5750 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5751 (interval_deletion_adjustment): Return unsigned value.
5752 All uses changed.
dc6c6455 5753
aba7731a
PE
5754 * process.c (list_processes_1, create_pty, read_process_output):
5755 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5756 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5757 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5758 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5759 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5760
fdfc4bf3
PE
5761 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5762
fca8fe46 5763 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5764 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5765
06a0259a 5766 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5767 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5768 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5769
e7b9e80f
PE
5770 * print.c (print_error_message): Avoid int overflow.
5771
56201685
PE
5772 * font.c (font_list_entities): Redo for clarity,
5773 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5774
78834453 5775 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5776 (font_score): Avoid potential overflow in diff calculation.
78834453 5777
0bc0b309 5778 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5779 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5780
e610eaca
PE
5781 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5782
b895abce
PE
5783 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5784 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5785 can always succeed if overflow has undefined behavior.
5786
1f1d9321 5787 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5788 (wordify): Omit three unnecessary tests.
1f1d9321 5789
c59478bc
PE
5790 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5791 All callers changed. This avoids the need for an unused var.
5792
79b73827
PE
5793 * casefiddle.c (casify_region): Remove var that is set but not used.
5794
a4db5dfe
PE
5795 * dired.c (file_name_completion): Remove var that is set but not used.
5796
43aae36e
PE
5797 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5798
2a47c44d 5799 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5800 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5801
a37c69bf
PE
5802 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5803 Check for integer overflow on size calculations.
5804
328ab8e7
PE
5805 * buffer.c (Fprevious_overlay_change): Remove var that is set
5806 but not used.
5807
e5a2a5cb
PE
5808 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5809 Remove vars that are set but not used.
8d84a6eb 5810 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5811 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5812
a60e5f68
PE
5813 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5814
f661cb61 5815 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5816 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5817
f0397f5a
PE
5818 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5819 that are set but not used.
5820
8664db06 5821 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5822 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5823
6abdaa4a
PE
5824 * xselect.c (x_get_local_selection, x_handle_property_notify):
5825 Remove vars that are set but not used.
5826
0ce7538d 5827 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5828 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5829
9ae848fc
PE
5830 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5831 Remove var that is set but not used.
0b918413
PE
5832 (scroll_bar_windows_size): Now size_t, not int.
5833 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5834 Check for overflow.
9ae848fc 5835
a5a62657
PE
5836 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5837 (map_tty_color) [!defined MSDOS]: Likewise.
5838
5c5cdd39
PE
5839 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5840
66ebf983
PE
5841 * coding.c: Remove vars that are set but not used.
5842 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5843 All callers changed.
5844 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5845 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5846 (decode_coding_charset): Remove vars that are set but not used.
5847
1be4d761
PE
5848 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5849 that is set but not used.
5850
47553fa8
PE
5851 * print.c (print_object): Remove var that is set but not used.
5852
1f7196bf 5853 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5854 The gnulib version avoids calling malloc in the usual case,
5855 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5856 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5857 * filelock.c (current_lock_owner): Likewise.
5858 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5859 * sysdep.c: Include allocator.h, careadlinkat.h.
5860 (emacs_no_realloc_allocator): New static constant.
5861 (emacs_readlink): New function.
fdb61804
PE
5862 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5863 ../lib/careadlinkat.h.
d1fdcab7 5864
f84c17c7
SM
58652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5866
5867 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5868 first non-nil return value).
5869
ef3862ad
JD
58702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5871
5872 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5873 if not defined (Bug#8403).
5874
376a7006
JB
58752011-04-02 Juanma Barranquero <lekktu@gmail.com>
5876
5877 * xdisp.c (display_count_lines): Remove parameter `start',
5878 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5879 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5880 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5881 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5882 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5883 and thereabouts. All callers changed.
5884 (get_per_char_metric): Remove parameter `f', unused since
5885 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5886
6ca3801d
JM
58872011-04-02 Jim Meyering <meyering@redhat.com>
5888
5889 do not dereference NULL upon failed strdup
5890 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5891 (ns_get_family): Likewise.
5892
d8e2b5ba
JB
58932011-04-02 Juanma Barranquero <lekktu@gmail.com>
5894
5895 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5896
8c74fcbd
JD
58972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5898
5899 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5900 later (Bug#8403).
5901
7200d79c
SM
59022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5903
03408648 5904 Add lexical binding.
7200d79c 5905
03408648
SM
5906 * window.c (Ftemp_output_buffer_show): New fun.
5907 (Fsave_window_excursion):
5908 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5909
5910 * lread.c (lisp_file_lexically_bound_p): New function.
5911 (Fload): Bind Qlexical_binding.
5912 (readevalloop): Remove `evalfun' arg.
5913 Bind Qinternal_interpreter_environment.
5914 (Feval_buffer): Bind Qlexical_binding.
5915 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5916 Mark as dynamic.
5917 (syms_of_lread): Declare `lexical-binding'.
5918
5919 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5920
5921 * keyboard.c (eval_dyn): New fun.
5922 (menu_item_eval_property): Use it.
ca105506
SM
5923
5924 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5925
03408648
SM
5926 * fns.c (concat, mapcar1): Accept byte-code-functions.
5927
5928 * eval.c (Fsetq): Handle lexical vars.
5929 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5930 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5931 (FletX, Flet): Obey lexical binding.
5932 (Fcommandp): Handle closures.
5933 (Feval): New `lexical' arg.
5934 (eval_sub): New function extracted from Feval. Use it almost
5935 everywhere where Feval was used. Look up vars in lexical env.
5936 Handle closures.
5937 (Ffunctionp): Move from subr.el.
5938 (Ffuncall): Handle closures.
5939 (apply_lambda): Remove `eval_flags'.
5940 (funcall_lambda): Handle closures and new byte-code-functions.
5941 (Fspecial_variable_p): New function.
5942 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5943 but without exporting it to Lisp.
23aba0ea 5944
23aba0ea 5945 * doc.c (Fdocumentation, store_function_docstring):
03408648 5946 * data.c (Finteractive_form): Handle closures.
23aba0ea 5947
03408648
SM
5948 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5949 interactive spec.
ba83908c 5950
04f2d78b
CB
5951 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5952 New byte-codes.
03408648
SM
5953 (exec_byte_code): New function extracted from Fbyte_code to handle new
5954 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5955
03408648 5956 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5957
03408648 5958 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5959
e2abce01
JB
59602011-03-31 Juanma Barranquero <lekktu@gmail.com>
5961
5962 * xdisp.c (redisplay_internal): Fix prototype.
5963
63696a73 59642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5965
63696a73 5966 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5967 (try_scrolling): Use it when setting scroll_limit.
5968 Limit scrolling to 100 screen lines.
63696a73
EZ
5969 (redisplay_window): Even when falling back on "recentering",
5970 position point in the window according to scroll-conservatively,
5971 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5972
5973 (try_scrolling): When point is above the window, allow searching
5974 as far as scroll_max, or one screenful, to compute vertical
5975 distance from PT to the scroll margin position. This prevents
5976 try_scrolling from unnecessarily failing when
5977 scroll-conservatively is set to a value slightly larger than the
5978 window height. Clean up the case of PT below the margin at bottom
5979 of window: scroll_max can no longer be INT_MAX. When aggressive
5980 scrolling is in use, don't let point enter the opposite scroll
5981 margin as result of the scroll.
5982 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5983 threshold of 100 lines for never-recentering scrolling.
5984
e4cc2dfc
JB
59852011-03-31 Juanma Barranquero <lekktu@gmail.com>
5986
5987 * dispextern.h (move_it_by_lines):
5988 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5989 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5990 (message_log_check_duplicate): Remove parameters `prev_bol' and
5991 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5992 (redisplay_internal): Remove parameter `preserve_echo_area',
5993 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5994
5995 * indent.c (Fvertical_motion):
5996 * window.c (window_scroll_pixel_based, Frecenter):
5997 Don't pass `need_y_p' to `move_it_by_lines'.
5998
1c470562
SM
59992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6000
44f230aa
SM
6001 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6002 steal a few bits to be more compact.
6003 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6004 Remove unneeded casts.
6005
1c470562
SM
6006 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6007
888adce9
ZK
60082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6009
6010 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6011 binding" message (bug#7967).
6012
f838ed7b
PE
60132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6014
77861b95
PE
6015 Fix more problems found by GCC 4.6.0's static checks.
6016
de6dbc14
PE
6017 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6018 Remove unused local var.
6019
f838ed7b
PE
6020 * editfns.c (Fmessage_box): Remove unused local var.
6021
792c7b2b
PE
6022 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6023 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6024 Omit unused local vars.
c499e557 6025 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6026 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6027 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6028 Omit unused local var.
6029
ba0165e1
PE
6030 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6031 Don't assume string length fits in int.
32ad8845 6032 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6033 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6034
3c59b4c9
PE
6035 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6036 instead of alloca (Bug#8344).
6037
a3eed478 6038 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6039 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6040
eb4d412d
PE
6041 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6042
1658b401
PE
6043 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6044 concerns.
6045
6046 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6047
6048 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6049
9a2c6e05
PE
6050 * keyboard.c (syms_of_keyboard): Use the same style as later
6051 in this function when indexing through an array. This also
6052 works around GCC bug 48267.
6053
03d0a109
PE
6054 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6055
44f730c8
PE
6056 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6057
fe75f926
PE
6058 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6059 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6060
ffa8c828
PE
6061 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6062 This avoids undefined behavior on integer overflow, and is a bit
6063 more convenient anyway since it is compared to a size_t variable.
6064
c5101a77
PE
6065 Variadic C functions now count arguments with size_t, not int.
6066 This avoids an unnecessary limitation on 64-bit machines, which
6067 caused (substring ...) to crash on large vectors (Bug#8344).
6068 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6069 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6070 All variadic functions and their callers changed accordingly.
c5101a77
PE
6071 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6072 * data.c (arith_driver, float_arith_driver): Likewise.
6073 * editfns.c (general_insert_function): Likewise.
6074 * eval.c (struct backtrace.nargs, interactive_p)
6075 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6076 (funcall_lambda, mark_backtrace): Likewise.
6077 * fns.c (concat): Likewise.
6078 * frame.c (x_set_frame_parameters): Likewise.
6079 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6080 0 if not found, not -1. All callers changed.
6081
dd3f25f7
PE
6082 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6083 (stack_copy_size): Now size_t, not int.
6084 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6085
461c2ab9
JB
60862011-03-28 Juanma Barranquero <lekktu@gmail.com>
6087
6088 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6089 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6090 All callers changed.
6091
6092 * lisp.h (multibyte_char_to_unibyte):
6093 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6094 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6095 * character.h (CHAR_TO_BYTE8):
6096 * cmds.c (internal_self_insert):
6097 * editfns.c (general_insert_function):
6098 * keymap.c (push_key_description):
6099 * search.c (Freplace_match):
6100 * xdisp.c (message_dolog, set_message_1): All callers changed.
6101
f6d62986
SM
61022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6103
6104 * keyboard.c (safe_run_hook_funcall): New function.
6105 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6106 don't set the hook to nil, but remove the offending function instead.
6107 (Qcommand_hook_internal): Remove, unused.
6108 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6109 Vcommand_hook_internal.
6110
6111 * eval.c (enum run_hooks_condition): Remove.
6112 (funcall_nil, funcall_not): New functions.
6113 (run_hook_with_args): Call each function through a `funcall' argument.
6114 Remove `cond' argument, now redundant.
6115 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6116 (Frun_hook_with_args_until_failure): Adjust accordingly.
6117 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6118
1db5b1ad
JB
61192011-03-28 Juanma Barranquero <lekktu@gmail.com>
6120
6121 * dispextern.h (string_buffer_position): Remove declaration.
6122
6123 * print.c (strout): Remove parameter `multibyte', unused since
6124 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6125
6126 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6127 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6128 All callers changed.
6129
6130 * w32.c (_wsa_errlist): Use braces for struct initializers.
6131
6132 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6133 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6134 All callers changed.
6135 (string_buffer_position): Likewise. Also, make static (it's never
6136 used outside xdisp.c).
6137 (cursor_row_p): Remove parameter `w', unused since
6138 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6139 (decode_mode_spec): Remove parameter `precision', introduced during
6140 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6141 All callers changed.
6142
5ffb62aa
JD
61432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6144
6145 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6146
461c2ab9 61472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6148
6149 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6150 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6151 (ns_update_auto_hide_menu_bar): New functions.
6152 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6153 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6154 ns_constrain_all_frames.
6155 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6156 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6157
5c380ffb
JD
61582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6159
6160 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6161
9af30bdf
GM
61622011-03-27 Glenn Morris <rgm@gnu.org>
6163
6164 * syssignal.h: Replace RETSIGTYPE with void.
6165 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6166 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6167 Replace SIGTYPE with void everywhere.
6168 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6169 * s/template.h (SIGTYPE): Remove commented out definition.
6170
e2abce01
JB
61712011-03-26 Eli Zaretskii <eliz@gnu.org>
6172
6173 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6174 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6175
f868cd8a
JB
61762011-03-26 Juanma Barranquero <lekktu@gmail.com>
6177
59eb0929
JB
6178 * w32.c (read_unc_volume): Use parameter `henum', instead of
6179 global variable `wget_enum_handle'.
6180
6181 * keymap.c (describe_vector): Remove parameters `indices' and
6182 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6183 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6184
f868cd8a
JB
6185 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6186
6187 * keyboard.c (timer_check): Remove parameter `do_it_now',
6188 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6189 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6190 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6191
6192 * keyboard.c (read_char):
6193 * w32menu.c (w32_menu_display_help):
6194 * xmenu.c (show_help_event, menu_help_callback):
6195 Adjust calls to `show_help_echo'.
6196
6197 * gtkutil.c (xg_maybe_add_timer):
6198 * keyboard.c (readable_events):
6199 * process.c (wait_reading_process_output):
6200 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6201
6202 * insdel.c (adjust_markers_gap_motion):
6203 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6204 (gap_left, gap_right): Don't call it.
6205
2ecf6fdb
CY
62062011-03-25 Chong Yidong <cyd@stupidchicken.com>
6207
6208 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6209 incurred during fontification.
6210
6b1f9ba4
JB
62112011-03-25 Juanma Barranquero <lekktu@gmail.com>
6212
6213 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6214 (DEFVAR_PER_BUFFER): Don't pass it.
6215
6216 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6217 (scrolling_window): Don't pass it.
6218
0f4a96b5
JB
62192011-03-25 Juanma Barranquero <lekktu@gmail.com>
6220
6221 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6222
6223 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6224 and `suffix'.
6225 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6226 of variables specific to SELinux and computation of `encoded_absname'.
6227
6228 * image.c (XPutPixel): Remove unused variable `height'.
6229
6230 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6231
6232 * unexw32.c (get_section_info): Remove unused variable `section'.
6233
6234 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6235 (system_process_attributes): Remove unused variable `sess'.
6236 (sys_read): Remove unused variable `err'.
6237
6238 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6239 (w32_wnd_proc): Remove unused variable `isdead'.
6240 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6241 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6242 (x_create_tip_frame): Remove unused variable `tem'.
6243
6244 * w32inevt.c (w32_console_read_socket):
6245 Remove unused variable `no_events'.
6246
6247 * w32term.c (x_draw_composite_glyph_string_foreground):
6248 Remove unused variable `width'.
6249
1149507c
JB
62502011-03-24 Juanma Barranquero <lekktu@gmail.com>
6251
6252 * w32term.c (x_set_glyph_string_clipping):
6253 Don't pass uninitialized region to CombineRgn.
6254
9c88f339
JB
62552011-03-23 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6258 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6259 (Fx_close_connection): Remove unused variable `i'.
6260
6261 * w32font.c (w32font_draw): Return number of glyphs.
6262 (w32font_open_internal): Remove unused variable `i'.
6263 (w32font_driver): Add missing initializer.
6264
6265 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6266 (fill_in_menu): Remove unused variable `items_added'.
6267
6268 * w32term.c (last_mouse_press_frame): Remove static global variable.
6269 (w32_clip_to_row): Remove unused variable `f'.
6270 (x_delete_terminal): Remove unused variable `i'.
6271
6272 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6273 (NOTHING): Remove unused static global variable.
6274 (uniscribe_check_otf): Remove unused variable `table'.
6275 (uniscribe_font_driver): Add missing initializers.
6276
dee091a3
JD
62772011-03-23 Julien Danjou <julien@danjou.info>
6278
6279 * term.c (Fsuspend_tty, Fresume_tty):
6280 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6281 * window.c (temp_output_buffer_show):
6282 * insdel.c (signal_before_change):
6283 * frame.c (Fhandle_switch_frame):
6284 * fileio.c (Fdo_auto_save):
6285 * emacs.c (Fkill_emacs):
6286 * editfns.c (save_excursion_restore):
6287 * cmds.c (internal_self_insert):
6288 * callint.c (Fcall_interactively):
6289 * buffer.c (Fkill_all_local_variables):
6290 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6291 Use Frun_hooks.
0f4a96b5 6292 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6293 unconditionnaly since it does the check itself.
6294
2c520ab5 62952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6296
c9c49752
PE
6297 Fix more problems found by GCC 4.5.2's static checks.
6298
8abc3f12
PE
6299 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6300 the first time through the loop, since we know p0 < p1 then.
6301 This also avoids a gcc -Wstrict-overflow warning.
6302
a2d26660
PE
6303 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6304 leading to a memory leak, possible in functions like
6305 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6306 of objects (Bug#8318).
a2d26660 6307
916c72e9
PE
6308 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6309 that could (at least in theory) be that large.
6310
19ab8a18
PE
6311 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6312 This is less likely to overflow, and avoids undefined behavior if
6313 overflow does occur. All callers changed. Use strtoul to scan
6314 for the unsigned long integer.
b7cbbd6f
PE
6315 (pint2hrstr): Simplify and tune code slightly.
6316 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6317
f0641eff
PE
6318 * scroll.c (do_scrolling): Work around GCC bug 48228.
6319 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6320
7f650bb9
PE
6321 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6322 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6323 (validate_x_resource_name): Simplify count usage.
6324 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6325
37dd57d1
PE
6326 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6327 fail (Bug#8306).
81e56e61 6328
699979fc 6329 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6330
401bf9b4
PE
6331 * process.c (Fmake_network_process): Use socklen_t, not int,
6332 where POSIX says socklen_t is required in portable programs.
6333 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6334 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6335 (Fmake_network_process, server_accept_connection):
6336 (wait_reading_process_output, read_process_output):
6337 Likewise.
6338
b93aacde
PE
6339 * process.c: Rename or move locals to avoid shadowing.
6340 (list_processes_1, Fmake_network_process):
6341 (read_process_output_error_handler, exec_sentinel_error_handler):
6342 Rename or move locals.
4dc343ee 6343 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6344 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6345 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6346 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6347 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6348
af8a867c 6349 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6350 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6351 Include tparam.h instead, since it declares them.
af8a867c
PE
6352 * cm.h (PC): Remove extern decl; tparam.h now does this.
6353 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6354 * terminfo.c: Include tparam.h, to check interfaces.
6355 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6356 (tparam): Adjust signature to match interface in tparam.h;
6357 this removes some undefined behavior. Check that outstring and len
6358 are zero, which they always are with Emacs.
6359 * tparam.h (PC, BC, UP): New extern decls.
6360
0248044d 6361 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6362 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6363
8ff096c1 6364 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6365 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6366 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6367 (ftfont_list): Remove unused local.
49eaafba
PE
6368 (get_adstyle_property, ftfont_pattern_entity):
6369 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6370 Rename locals to avoid shadowing.
8ff096c1 6371
e2be39f6
PE
6372 * xfont.c (xfont_list_family): Mark var as initialized.
6373
c9735e30
PE
6374 * xml.c (make_dom): Now static.
6375
8f5201ae
PE
6376 * composite.c (composition_compute_stop_pos): Rename local to
6377 avoid shadowing.
b246f932
PE
6378 (composition_reseat_it): Remove unused locals.
6379 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6380 (composition_update_it): Mark var as initialized.
11b61122
PE
6381 (find_automatic_composition): Mark vars as initialized,
6382 with a FIXME (Bug#8290).
8f5201ae 6383
760fbc2c
PE
6384 character.h: Rename locals to avoid shadowing.
6385 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6386 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6387 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6388 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6389 to avoid shadowing.
6390
ff08eb85
PE
6391 * textprop.c (property_change_between_p): Remove; unused.
6392
fc7bf025
PE
6393 * intervals.c (interval_start_pos): Now static.
6394
235d7abc
PE
6395 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6396
44f230aa
SM
6397 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6398 Rename locals to avoid shadowing.
3e7d6594 6399
50060332
PE
6400 * sound.c (wav_play, au_play, Fplay_sound_internal):
6401 Fix pointer signedness.
d01f234b 6402 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6403 (wav_play): Initialize a variable to 0, to prevent undefined
6404 behavior (Bug#8278).
50060332 6405
c4fc4e30
PE
6406 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6407
918436ed
PE
6408 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6409
c939f91b
PE
6410 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6411 clobbering (Bug#8298).
b9c7f648
PE
6412 * sysdep.c (sys_subshell): Likewise.
6413 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6414
6bd8c144
PE
6415 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6416 This should get cleaned up, so that child_setup has the
6417 same signature on all platforms.
6418
7710357c 6419 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6420 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6421
c59da222
CY
64222011-03-22 Chong Yidong <cyd@stupidchicken.com>
6423
6424 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6425 not to be necessary, and produces flickering.
6426
66b87493
GM
64272011-03-20 Glenn Morris <rgm@gnu.org>
6428
6429 * config.in: Remove file.
6430
45b6f6d5
JB
64312011-03-20 Juanma Barranquero <lekktu@gmail.com>
6432
6433 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6434 are now in src/globals.h.
6435 (syms_of_minibuf): Remove spurious & from previous change.
6436
3ec03f7e
LL
64372011-03-20 Leo <sdl.web@gmail.com>
6438
6439 * minibuf.c (completing-read-function): New variable.
6440 (completing-read-default): Rename from completing-read.
6441 (completing-read): Call completing-read-function.
6442
b14e3e21
CY
64432011-03-19 Juanma Barranquero <lekktu@gmail.com>
6444
6445 * xfaces.c (Fx_load_color_file):
6446 Read color file from absolute filename (bug#8250).
6447
f2b726e6
JB
64482011-03-19 Juanma Barranquero <lekktu@gmail.com>
6449
6450 * makefile.w32-in: Update dependencies.
6451
09f6ff02
EZ
64522011-03-17 Eli Zaretskii <eliz@gnu.org>
6453
6454 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6455
29a6015a
PE
64562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6457
a3a6c54e
PE
6458 Fix more problems found by GCC 4.5.2's static checks.
6459
b766f867
PE
6460 * process.c (make_serial_process_unwind, send_process_trap):
6461 (sigchld_handler): Now static.
6462
be02381c
PE
6463 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6464 That way, the code declares only the vars that it needs.
6465 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6466 * s/cygwin.h (PTY_ITERATION): Likewise.
6467 * s/darwin.h (PTY_ITERATION): Likewise.
6468 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6469
57048744
PE
6470 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6471 * process.c (allocate_pty): Don't declare stb unless it's needed.
6472
7914961c 6473 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6474 (CONSTANTLIM): Remove; unused.
6475 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6476 Define only if needed.
7914961c 6477
b3967b18
PE
6478 * unexelf.c (unexec): Name an expression,
6479 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6480 Use a different way to cause a compilation error if anyone uses
6481 n rather than nn, a way that does not involve shadowing.
73366a00 6482 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6483
29a6015a
PE
6484 * deps.mk (unexalpha.o): Remove; unused.
6485
43cfc33e 6486 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6487 * unexec.h: New file.
ce701a33
PE
6488 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6489 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6490 Depend on unexec.h.
6491 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6492 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6493 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6494 Change as necessary to match prototype in unexec.h.
ce701a33 6495
01f44d5a
PE
6496 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6497 shadowing.
4f63c6bb 6498 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6499
a6670b0b
PE
6500 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6501 Rename locals to avoid shadowing.
6502
cef2010d 6503 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6504 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6505
d4d7173a
PE
6506 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6507
f08b802a
PE
6508 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6509 warning when compiling print.c.
6510
3ddb0639
PE
6511 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6512 instead of using an uninitialized var.
5ad03b97 6513 (font_sort_entities): Mark var as initialized.
3ddb0639 6514
170a2692
PE
6515 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6516
e663c700
PE
6517 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6518 pointers to constants.
89bc529a 6519 (font_parse_fcname): Remove unused vars.
7b81e2d0 6520 (font_delete_unmatched): Now static.
ea838e10 6521 (font_get_spec): Remove; unused.
13a547c6
PE
6522 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6523 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6524 Rename or move locals to avoid shadowing.
e663c700 6525
2a80c887 6526 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6527 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6528
1384fa33 6529 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6530 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6531
8b2c52e9
PE
6532 * alloc.c (mark_backtrace): Move decl from here ...
6533 * lisp.h: ... to here, so that it can be checked.
6534
475545b5 6535 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6536 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6537 (lisp_indirect_variable): Name an expression,
6538 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6539 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6540
b1349114 6541 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6542 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6543 Use const pointer when appropriate.
b1349114 6544
a2928364
PE
6545 * lisp.h (get_system_name, get_operating_system_release):
6546 Move decls here, to check interfaces.
6547 * process.c (get_operating_system_release): Move decl to lisp.h.
6548 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6549 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6550 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6551 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6552 (Fformat_time_string, Fencode_time, Finsert_char):
6553 (Ftranslate_region_internal, Fformat):
6554 Rename or remove local vars to avoid shadowing.
9710023e 6555 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6556
a415e694
PE
6557 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6558 avoid shadowing.
6559
8ef4622d
PE
6560 * lisp.h (eassert): Check that the argument compiles, even if
6561 ENABLE_CHECKING is not defined.
6562
946f9a5b
PE
6563 * data.c (Findirect_variable): Name an expression, to avoid
6564 gcc -Wbad-function-cast warning.
112396d6 6565 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6566 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6567 (Fmake_variable_buffer_local, Fmake_local_variable):
6568 Mark variables as initialized.
52746918 6569 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6570
e5aab7e7 6571 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6572 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6573 Rename locals to avoid shadowing.
dff45157
PE
6574 (mark_stack): Move local variables into the #ifdef region where
6575 they're used.
7bc26fdb
PE
6576 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6577 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6578 needed otherwise.
6579 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6580 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6581 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6582
e5aab7e7
PE
6583 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6584 avoids undefined behavior in theory.
6585
4da60324
PE
6586 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6587
88043301
PE
6588 Use functions, not macros, for up- and down-casing (Bug#8254).
6589 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6590 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6591 to use the following functions instead of these macros.
6592 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6593 EMACS_INT, since callers assume the returned value fits in int.
6594 (upcase1): Likewise, for UPCASE_TABLE.
6595 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6596 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6597 the race-condition problem in the old DOWNCASE.
88043301 6598
19ed5445
PE
6599 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6600 Rename locals to avoid shadowing.
6601 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6602 (regex_compile, re_search_2, re_match_2_internal):
6603 Remove unused local vars.
952db0d7
PE
6604 (FREE_VAR): Rewrite so as not to use empty "else",
6605 which gcc can warn about.
da053e48 6606 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6607 (RETALLOC_IF): Define only if needed.
6608 (WORDCHAR_P): Likewise. This one is never needed, but is used
6609 only in a comment talking about a compiler bug, so put inside
6610 the #if 0 of that comment.
6611 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6612 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6613 Remove; unused.
19ed5445 6614
1f3561e4 6615 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6616 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6617 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6618
ded6f8f7
PE
6619 * search.c (simple_search): Remove unused var.
6620
dbd37a95
PE
6621 * dired.c (compile_pattern): Move decl from here ...
6622 * lisp.h: ... to here, so that it can be checked.
6623 (struct re_registers): New forward decl.
6624
7e47afad
PE
6625 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6626
85f24f61
PE
6627 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6628 All uses changed.
6629 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6630 Rename locals to avoid shadowing.
5671df8f 6631 (Fvertical_motion): Mark locals as initialized.
85f24f61 6632
181aa2be 6633 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6634 (casify_region): Mark local as initialized.
181aa2be 6635
930d429c
PE
6636 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6637
7082eac6
PE
6638 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6639 New macros, so that the caller can use some names other than
6640 gcpro1, gcpro2, etc.
6641 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6642 of the new macros.
6643 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6644 argument, for consistency with GCPRO2_VAR, etc: it is now the
6645 prefix of the variable, not the variable itself. All uses
6646 changed.
38b2c076
PE
6647 * dired.c (directory_files_internal, file_name_completion):
6648 Rename locals to avoid shadowing.
6649
15206ed9
PE
6650 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6651 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6652 dired.c's scmp function, had undefined behavior.
6653 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6654 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6655 * buffer.h: ... to here, because these macros use current_buffer,
6656 and the new implementation with inline functions needs to have
6657 current_buffer in scope now, rather than later when the macros
6658 are used.
6659 (downcase, upcase1): New static inline functions.
6660 (DOWNCASE, UPCASE1): Reimplement using these functions.
6661 This avoids undefined behavior in expressions like
6662 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6663 from race conditions in accessing the global variables
6664 case_temp1 and case_temp2.
6665 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6666 * lisp.h (case_temp1, case_temp2): Remove their decls.
6667 * character.h (ASCII_CHAR_P): Move from here ...
6668 * lisp.h: ... to here, so that the inline functions mentioned
6669 above can use them.
6670
4a6bea26
PE
6671 * dired.c (directory_files_internal_unwind): Now static.
6672
f14b7e14
PE
6673 * fileio.c (file_name_as_directory, directory_file_name):
6674 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6675 Now static.
2893f146
PE
6676 (file_name_as_directory): Use const pointers when appropriate.
6677 (Fexpand_file_name): Likewise. In particular, newdir might
6678 point at constant storage, so make it a const pointer.
fd4ead52 6679 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6680 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6681 signedness issues.
f839df0c
PE
6682 (Fset_file_times, Finsert_file_contents, auto_save_error):
6683 Rename locals to avoid shadowing.
f14b7e14 6684
5716756e 6685 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6686 (Ftry_completion, Fall_completions): Rename or remove locals
6687 to avoid shadowing.
5716756e 6688
b4c3046a
PE
6689 * marker.c (bytepos_to_charpos): Remove; unused.
6690
b45db522
PE
6691 * lisp.h (verify_bytepos, count_markers): New decls,
6692 so that gcc does not warn that these functions aren't declared.
6693
85876d07
PE
6694 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6695 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6696 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6697 (copy_text): Remove unused local var.
85876d07 6698
03d78a21 6699 * filelock.c (within_one_second): Now static.
b3dd38ab 6700 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6701
5df8f01b
PE
6702 * buffer.c (fix_overlays_before): Mark locals as initialized.
6703 (fix_start_end_in_overlays): Likewise. This function should be
6704 simplified by using pointers-to-pointers, but that's a different
6705 matter.
b1d876f1 6706 (switch_to_buffer_1): Now static.
8f54f30a
PE
6707 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6708 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6709
a70072c9 6710 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6711 Fix pointer signedness issue.
edced198
PE
6712 (sys_subshell): Mark local as volatile if checking for lint,
6713 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6714 (MAXPATHLEN): Define only if needed.
a70072c9 6715
a0977c44
PE
6716 * process.c (serial_open, serial_configure): Move decls from here ...
6717 * systty.h: ... to here, so that they can be checked.
6718
a884fdcc
PE
6719 * fns.c (get_random, seed_random): Move extern decls from here ...
6720 * lisp.h: ... to here, so that they can be checked.
6721
604efe86 6722 * sysdep.c (reset_io): Now static.
b8950c94 6723 (wait_for_termination_signal): Remove; unused.
604efe86 6724
38fc62d9
PE
6725 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6726 (copy_keymap_item, append_key, push_text_char_description):
6727 Now static.
1004a21a 6728 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6729 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6730 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6731 (describe_map_tree):
6732 Rename locals to avoid shadowing.
38fc62d9 6733
2f2650da
PE
6734 * keyboard.c: Declare functions static if they are not used elsewhere.
6735 (echo_char, echo_dash, cmd_error, top_level_2):
6736 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6737 (read_char, kbd_buffer_get_event, make_lispy_position):
6738 (make_lispy_event, make_lispy_movement, apply_modifiers):
6739 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6740 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6741 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6742 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6743 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6744
a053e86c 6745 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6746 (mark_kboards): Move decl here ...
6747 * alloc.c (mark_kboards): ... from here.
a053e86c 6748
4752793e
PE
6749 * lisp.h (force_auto_save_soon): New decl.
6750
74f10ca7 6751 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6752 (DEFINE_DUMMY_FUNCTION): New macro.
6753 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6754 Use it.
c03cd23f
PE
6755 (main): Add casts to avoid warnings
6756 if GCC considers string literals to be constants.
74f10ca7 6757
022e70d4
PE
6758 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6759
59d6fe83
PE
6760 * dbusbind.c: Pointer signedness fixes.
6761 (xd_signature, xd_append_arg, xd_initialize):
6762 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6763 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6764 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6765 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6766
78320123
PE
6767 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6768 if GCC considers string literals to be constants.
49cebcca 6769 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6770
35ac2a97
SM
67712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6772
fb103ca9
SM
6773 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6774 (print_preprocess, print_object): New macro to fix last change.
6775
35ac2a97
SM
6776 * print.c (print_preprocess): Don't forget font objects.
6777
62973b41
JB
67782011-03-16 Juanma Barranquero <lekktu@gmail.com>
6779
6780 * emacs.c (USAGE3): Doc fixes.
6781
0e48bb22
AS
67822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6783
6784 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6785 structure.
6786
7684e57b
JB
67872011-03-14 Juanma Barranquero <lekktu@gmail.com>
6788
6789 * lisp.h (VWindow_system, Qfile_name_history):
6790 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6791 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6792 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6793
6794 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6795 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6796
6797 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6798 * w32console.c (detect_input_pending, read_input_pending)
6799 (encode_terminal_code):
6800 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6801 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6802 (w32_system_caret_y, Qfile_name_history):
6803 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6804 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6805 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6806 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6807 * w32proc.c (Qlocal, report_file_error):
6808 * w32term.c (Vwindow_system, updating_frame):
6809 * w32uniscribe.c (initialized, uniscribe_font_driver):
6810 Remove unneeded extern declarations.
6811
2aa46d6c
CY
68122011-03-14 Chong Yidong <cyd@stupidchicken.com>
6813
c96bbc66 6814 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6815
cffc6f3b
CY
68162011-03-13 Chong Yidong <cyd@stupidchicken.com>
6817
6818 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6819 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6820 These macros can no longer be used for assignment.
6821
44f230aa
SM
6822 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6823 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6824 (record_buffer_markers, fetch_buffer_markers): New functions for
6825 recording and fetching special buffer markers.
6826 (set_buffer_internal_1, set_buffer_temp): Use them.
6827
6828 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6829
6830 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6831
6832 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6833 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6834
6835 * xdisp.c (hscroll_window_tree):
6836 (reconsider_clip_changes): Use PT instead of BUF_PT.
6837
d251f04b
EZ
68382011-03-13 Eli Zaretskii <eliz@gnu.org>
6839
6840 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6841 $(EMACS_ROOT)/lib/intprops.h.
6842
f0c77cd1
PE
68432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6844
3eca4629
PE
6845 Fix more problems found by GCC 4.5.2's static checks.
6846
7c86ee98
PE
6847 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6848 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6849 (xg_free_frame_widgets): Make it clear that a local variable is
6850 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6851 (gdk_window_get_screen): Make it clear that this macro is needed
6852 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6853 (int_gtk_range_get_value): New function, which avoids a diagnostic
6854 from gcc -Wbad-function-cast.
6855 (xg_set_toolkit_scroll_bar_thumb): Use it.
6856 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6857 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6858 (get_utf8_string, xg_get_file_with_chooser):
6859 Rename locals to avoid shadowing.
6860 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6861
41729b81
PE
6862 * xgselect.c (xg_select): Remove unused var.
6863
f0c77cd1
PE
6864 * image.c (four_corners_best): Mark locals as initialized.
6865 (gif_load): Initialize transparent_p to zero (Bug#8238).
6866 Mark another local as initialized.
ec6cf4c6 6867 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6868
ce0ad53d 6869 * image.c (clear_image_cache): Now static.
d5d5a617 6870 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6871 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6872 (x_edge_detection): Remove unnecessary cast that
6873 gcc -Wbad-function-cast diagnoses.
2037898d 6874 (gif_load): Fix pointer signedness.
6ae141d6
PE
6875 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6876 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6877
33383987 68782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6879
d32df629
PE
6880 Improve quality of tests for time stamp overflow.
6881 For example, without this patch (encode-time 0 0 0 1 1
6882 1152921504606846976) returns the obviously-bogus value (-948597
6883 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6884 reports time overflow. See
6885 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6886 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6887 * editfns.c: Include limits.h and intprops.h.
6888 (TIME_T_MIN, TIME_T_MAX): New macros.
6889 (time_overflow): Move earlier, to before first use.
6890 (hi_time, lo_time): New functions, for an accurate test for
6891 out-of-range times.
6892 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6893 (Fget_internal_run_time): Don't assume time_t fits in int.
6894 (make_time): Use list2 instead of Fcons twice.
6895 (Fdecode_time): More accurate test for out-of-range times.
6896 (check_tm_member): New function.
6897 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6898 (lisp_time_argument): Don't rely on undefined left-shift and
6899 right-shift behavior when checking for time stamp overflow.
8be6f318 6900
fe31d94c
PE
6901 * editfns.c (time_overflow): New function, refactoring common code.
6902 (Fformat_time_string, Fdecode_time, Fencode_time):
6903 (Fcurrent_time_string): Use it.
6904
8be6f318
PE
6905 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6906 * dired.c (make_time): Move to ...
6907 * editfns.c (make_time): ... here.
6908 * systime.h: Note the move.
6909
09d9db2c 69102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6911
126bc0dc
YM
6912 * fringe.c (update_window_fringes): Remove unused variables.
6913
c47cbdfd
YM
6914 * unexmacosx.c (copy_data_segment): Also copy __got section.
6915 (Bug#8223)
6916
7ac80be9
EZ
69172011-03-12 Eli Zaretskii <eliz@gnu.org>
6918
c96bbc66 6919 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6920 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6921 Constify `char *' arguments and their references according to
6922 prototypes in tparam.h.
6923
ecb0f94d 6924 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6925
7ac80be9
EZ
6926 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6927 Adapt all references accordingly.
6928
6929 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6930
ef1fd07e
TT
69312011-03-11 Tom Tromey <tromey@redhat.com>
6932
6933 * buffer.c (syms_of_buffer): Remove obsolete comment.
6934
7ef4b50c
EZ
69352011-03-11 Eli Zaretskii <eliz@gnu.org>
6936
6937 * termhooks.h (encode_terminal_code): Declare prototype.
6938
6939 * msdos.c (encode_terminal_code): Don't declare prototype.
6940
6941 * term.c (encode_terminal_code): Now external again, used by
6942 w32console.c and msdos.c.
6943
44f230aa
SM
6944 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6945 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6946
4b1ec863 69472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6948
1714f52b 6949 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6950
4b1ec863
PE
6951 * fringe.c (update_window_fringes): Mark locals as initialized
6952 (Bug#8227).
6953 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6954
524c7aa6
PE
6955 * alloc.c (mark_fringe_data): Move decl from here ...
6956 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6957 to check its interface.
6958 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6959
a5c0af81 6960 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6961 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6962 (fontset_font): Mark local as initialized.
a9a06e0b 6963 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6964
b4716021
PE
6965 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6966
811e9bac 6967 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6968 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6969 (x_own_selection, Fx_disown_selection_internal): Rename locals
6970 to avoid shadowing.
6971 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6972
7e3ab302
PE
6973 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6974 so that the caller can use some name other than gcpro1.
6975 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6976 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6977 (Fx_backspace_delete_keys_p):
6978 Use them to avoid shadowing, and rename vars to avoid shadowing.
6979 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6980 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6981 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6982 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6983 Remove unused locals.
7e3ab302
PE
6984 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6985 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6986 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6987 macros.
f78faa98 6988
e2b13473
PE
6989 * xterm.h (x_mouse_leave): New decl.
6990
77f23912
PE
6991 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6992 Remove unused functions.
cdf4ba58
PE
6993 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6994 (x_calc_absolute_position): Now static.
7411c686 6995 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6996 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6997 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6998 unless they are used.
38d0b34a
PE
6999 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7000 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7001 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7002 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7003 (x_error_catcher, x_connection_closed, x_error_handler):
7004 (x_error_quitter, xembed_send_message, x_iconify_frame):
7005 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7006 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7007 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7008
44f230aa
SM
7009 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7010 Rename or move locals to avoid shadowing.
6b463e58 7011 (tty_defined_color, merge_face_heights): Now static.
5967d051 7012 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7013 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7014 does not deduce is never used uninitialized.
73719eba
PE
7015 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7016 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7017
426994c3 7018 * terminal.c (store_terminal_param): Now static.
5489860b 7019
032f1620 7020 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7021 (set_frame_menubar): Remove unused local.
d4323972 7022 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7023 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7024 since they might point to immutable storage.
281585b0
PE
7025 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7026 since it's unused otherwise.
032f1620 7027
367c19e5 7028 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7029 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7030 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7031 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7032 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7033 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7034 does not deduce are never used uninitialized.
70739cbe 7035
07b48fa9
PE
7036 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7037
8868a238 7038 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7039 * window.c (window_loop, size_window):
7040 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7041
7e5cf297 7042 * window.c (display_buffer): Now static.
d6550a9f
PE
7043 (size_window): Mark variables that gcc -Wuninitialized
7044 does not deduce are never used uninitialized.
a586633d
PE
7045 * window.h (check_all_windows): New decl, to forestall
7046 gcc -Wmissing-prototypes diagnostic.
5b555da1 7047 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7048
f6095868
PE
7049 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7050 shadowing.
7051 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7052 Include <limits.h>.
7053 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7054 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7055 (load_charset_map): Mark variables that gcc -Wuninitialized
7056 does not deduce are never used uninitialized.
53df7c11 7057 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7058
f38b440c
PE
7059 * coding.c (coding_set_source, coding_set_destination):
7060 Use "else { /* comment */ }" rather than "else /* comment */;"
7061 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7062 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7063 a block, when the outer 'i' will do.
7064 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7065 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7066 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7067 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7068 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7069 Rename locals to avoid shadowing.
7070 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7071 * coding.c (emacs_mule_char, encode_invocation_designation):
7072 Now static, since they're not used elsewhere.
413bb2db 7073 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7074 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7075 (decode_coding_emacs_mule): Mark variables that gcc
7076 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7077 (detect_coding_iso_2022): Initialize a local variable that might
7078 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7079 this initialization is needed. (Bug#8211)
5f58e762
PE
7080 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7081 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7082 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7083 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7084 Remove unused macros.
f38b440c 7085
232b38b9 7086 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7087 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7088 * character.c (string_count_byte8): Likewise.
232b38b9 7089
fb90da1b
PE
7090 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7091 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7092
fb93dbc2
PE
7093 * chartab.c (copy_sub_char_table): Now static, since it's not used
7094 elsewhere.
5c156ace
PE
7095 (sub_char_table_ref_and_range, char_table_ref_and_range):
7096 Rename locals to avoid shadowing.
bbcd0949 7097 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7098
7d3b3862 7099 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7100 (BIDI_BOB): Remove unused macro.
7d3b3862 7101
6be7d3da
PE
7102 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7103 deduce are never used uninitialized.
c2ed9c8b 7104 * term.c (encode_terminal_code): Likewise.
6be7d3da 7105
75f8807f 7106 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7107
50938595
PE
7108 * tparam.h: New file.
7109 * term.c, tparam.h: Include it.
7110 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7111 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7112 Move these decls to tparam.h, and make them agree with what
7113 is actually in tparam.c. The previous trick of using incompatible
7114 decls in different modules does not conform to the C standard.
7115 All callers of tparam changed to use tparam's actual API.
7116 * tparam.c (tparam1, tparam, tgoto):
7117 Use const pointers where appropriate.
7118
fbceeba2
PE
7119 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7120 * cm.h (struct cm): Likewise.
7121 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7122 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7123 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7124 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7125 (turn_on_face, init_tty): Likewise.
7126 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7127
7f3f1250
PE
7128 * term.c (term_mouse_position): Rename local to avoid shadowing.
7129
e6ca6543
PE
7130 * alloc.c (mark_ttys): Move decl from here ...
7131 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7132
c40f8d15
AS
71332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7134
7135 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7136
cfe0661d
JB
71372011-03-09 Juanma Barranquero <lekktu@gmail.com>
7138
7139 * search.c (compile_pattern_1): Remove argument regp, unused since
7140 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7141 (compile_pattern): Don't pass it.
7142
0afb4571
J
71432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7144
7145 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7146 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7147 for ! HAVE_GTK3.
7148 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7149
7150 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7151
7152 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7153 gdk_window_get_screen, gdk_window_get_geometry,
7154 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7155 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7156 (xg_get_pixbuf_from_pixmap): New function.
7157 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7158 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7159 Call xg_get_pixbuf_from_pixmap instead of
7160 gdk_pixbuf_get_from_drawable.
7161 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7162 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7163 (xg_check_special_colors): Use GtkStyleContext and its functions
7164 for HAVE_GTK3.
7165 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7166 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7167 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7168 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7169 Call gtk_widget_get_preferred_size.
0afb4571
J
7170 (xg_frame_resized): gdk_window_get_geometry only takes 5
7171 parameters.
44f230aa
SM
7172 (xg_win_to_widget, xg_event_is_for_menubar):
7173 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7174 (xg_set_widget_bg): New function.
7175 (delete_cb): New function.
895009e1 7176 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7177 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7178 (xg_set_background_color): Call xg_set_widget_bg.
7179 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7180 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7181 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7182 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7183 if ! HAVE_GTK3.
7184 (update_frame_tool_bar): Call gtk_widget_hide.
7185 (xg_initialize): Use GDK_KEY_g.
7186
7187 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7188 if ! HAVE_GTK3
7189 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7190
7191 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7192 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7193 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7194
1c2cc4ef
JB
71952011-03-08 Juanma Barranquero <lekktu@gmail.com>
7196
7197 * w32xfns.c (select_palette): Check success of RealizePalette against
7198 GDI_ERROR, not zero.
7199
33383987 7200See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7201
7202;; Local Variables:
7203;; coding: utf-8
aac0c6e3
MR
7204;; End:
7205
33383987 7206 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7207
7208 This file is part of GNU Emacs.
7209
7210 GNU Emacs is free software: you can redistribute it and/or modify
7211 it under the terms of the GNU General Public License as published by
7212 the Free Software Foundation, either version 3 of the License, or
7213 (at your option) any later version.
7214
7215 GNU Emacs is distributed in the hope that it will be useful,
7216 but WITHOUT ANY WARRANTY; without even the implied warranty of
7217 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7218 GNU General Public License for more details.
7219
7220 You should have received a copy of the GNU General Public License
7221 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.