Followup for character properties in 2011-08-23T11:48:07Z!handa@m17n.org.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bca633fb
EZ
12011-08-23 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4 a character.
5
4a5885a7
CY
62011-08-23 Chong Yidong <cyd@stupidchicken.com>
7
8 * nsfont.m (ns_otf_to_script): Fix typo.
9
0902a04e
KH
102011-08-22 Kenichi Handa <handa@m17n.org>
11
12 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
13 extra slot even if the purpose is char-code-property-table.
14
1a2e6670
EZ
152011-08-23 Eli Zaretskii <eliz@gnu.org>
16
8ddde651
EZ
17 * xdisp.c (redisplay_window): When computing centering_position,
18 account for the height of the header line. (Bug#8874)
19
425cc014
EZ
20 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
21 instead of CHAR_TO_BYTE. Fixes a crash when a completion
22 candidate is selected by the mouse, and that candidate has a
23 composed character under the mouse.
24
1a2e6670
EZ
25 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
26 coordinates reported by pos-visible-in-window-p for a composed
27 character in column zero.
28
8b76d6f8
SM
292011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
30
31 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
32
dac347dd
EZ
332011-08-22 Eli Zaretskii <eliz@gnu.org>
34
35 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
36 consider it a hit if to_charpos is anywhere in the range of the
37 composed buffer positions.
38
e013fb34
CY
392011-08-22 Chong Yidong <cyd@stupidchicken.com>
40
41 * image.c (gif_load): Don't assume that each subimage has the same
42 dimensions as the base image. Handle disposal method that is
43 "undefined" by the gif spec (Bug#9335).
44
bd1ba3e8
CY
452011-08-20 Chong Yidong <cyd@stupidchicken.com>
46
47 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 48 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 49
54a1215b
EZ
502011-08-19 Eli Zaretskii <eliz@gnu.org>
51
823564e5
EZ
52 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
53 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
54 from an Org mode buffer to a Speedbar frame.
55
54a1215b
EZ
56 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
57 a composition, take its buffer position from IT->cmp_it.charpos.
58 Fixes cursor positioning at the beginning of a line that begins
59 with a composed character.
60
9778ebcc
EZ
612011-08-18 Eli Zaretskii <eliz@gnu.org>
62
0be6ee06
EZ
63 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
64 character bidirectional type, use STRONG_L instead. Fixes crashes
65 in a buffer produced by `describe-categories'.
66
9778ebcc
EZ
67 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
68 members before the level stack, so they would be saved and
69 restored when copying iterator state. Fixes incorrect reordering
70 around TABs covered by display properties.
71
156bffbe
AS
722011-08-18 Andreas Schwab <schwab@linux-m68k.org>
73
74 * process.c (Fnetwork_interface_list): Correctly determine buffer
75 size.
76
72ad093b
CY
772011-08-17 Chong Yidong <cyd@stupidchicken.com>
78
79 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
80 (internal_condition_case_2, internal_condition_case_n):
81 Remove unnecessary aborts (Bug#9081).
72ad093b 82
35774242
EZ
832011-08-17 Eli Zaretskii <eliz@gnu.org>
84
85 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
86 has no `load' handler, try opening the file locally. (Bug#9311)
87
db76dd85
KB
882011-08-16 Ken Brown <kbrown@cornell.edu>
89
90 * gmalloc.c: Expand comment.
91
b215eee5
EZ
922011-08-16 Eli Zaretskii <eliz@gnu.org>
93
94 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
95 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
96
a4579d33
KB
972011-08-16 Ken Brown <kbrown@cornell.edu>
98
99 Fix memory allocation problems in Cygwin build (Bug#9273).
100
101 * unexcw.c ( __malloc_initialized): Declare external variable.
102 (fixup_executable): Force the dumped emacs to reinitialize malloc.
103
8b76d6f8
SM
104 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
105 New variables.
a4579d33
KB
106 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
107 dumped emacs.
108 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
109 in the static heap.
110 [CYGWIN] (special_realloc): New function.
111 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
112 requests to realloc storage in the static heap.
113
3ebec551
PE
1142011-08-15 Paul Eggert <eggert@cs.ucla.edu>
115
116 * bidi.c (bidi_initialize): Remove unused local.
117
9fd8be00
EZ
1182011-08-15 Eli Zaretskii <eliz@gnu.org>
119
474a8465
EZ
120 * biditype.h: File removed.
121
122 * bidimirror.h: File removed.
123
124 * deps.mk (bidi.o): Remove biditype.h and
125 bidimirror.h.
126
127 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
128 bidimirror.h.
129
130 * dispextern.h: Fix a typo in the comment to bidi_type_t.
131
132 * chartab.c: Improve commentary for the uniprop_table API.
133
32413314
EZ
134 * bidi.c (bidi_paragraph_init): Support zero value of
135 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
136 (bidi_initialize): Use uniprop_table instead of including
137 biditype.h and bidimirror.h.
32413314 138
9fd8be00
EZ
139 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
140 coordinates of the iterator when restoring from ppos_it.
141 (Bug#9296)
142
5cf2b69b
KH
1432011-08-14 Kenichi Handa <handa@m17n.org>
144
145 * process.c (create_process): Call setup_process_coding_systems
72ad093b 146 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 147
daf17d00
EZ
1482011-08-14 Eli Zaretskii <eliz@gnu.org>
149
150 * xdisp.c (move_it_in_display_line_to): Don't invoke
151 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
152 ppos_it. Fixes vertical cursor motion when line beginning is
153 covered by an image. (Bug#9296)
154
08e3161a
JD
1552011-08-14 Jan Djärv <jan.h.d@swipnet.se>
156
157 * nsterm.h (ns_run_ascript): Declare.
158 (NSAPP_DATA2_RUNASSCRIPT): Define.
159
160 * nsfns.m (as_script, as_result, as_status): New static variables.
161 (ns_run_ascript): New function.
162 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
163 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
164 the event loop. Get status from as_status (Bug#7276).
165
166 * nsterm.m (sendEvent): If event is NSApplicationDefined and
167 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
168 the event loop (Bug#7276).
169
a3720aa2
AS
1702011-08-14 Andreas Schwab <schwab@linux-m68k.org>
171
172 * gnutls.c (QCgnutls_bootprop_priority)
173 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
174 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
175 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
176 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
177 (QCgnutls_bootprop_verify_hostname_error)
178 (QCgnutls_bootprop_callbacks_verify): Rename from
179 Qgnutls_bootprop_..., all uses changed.
180
181 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
182 uses changed.
183
0a0d27fb
PE
1842011-08-14 Paul Eggert <eggert@cs.ucla.edu>
185
19d5c50c
PE
186 * xfaces.c (Qframe_set_background_mode): Now static.
187 * dispextern.h (Qframe_set_background_mode): Remove decl.
188
0a0d27fb
PE
189 * process.c (Fnetwork_interface_info): Declare local only if needed.
190
377538cb
JD
1912011-08-13 Jan Djärv <jan.h.d@swipnet.se>
192
193 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
194 (Fnetwork_interface_list): Allocate in increments of bytes instead
195 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
196 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
197 sockaddr.
198 (struct ifflag_def): notrailers is smart on OSX.
199 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
200 Get hardware address with getifaddrs if available.
201
08fff70c
EZ
2022011-08-12 Eli Zaretskii <eliz@gnu.org>
203
204 * xdisp.c (iterate_out_of_display_property): xassert that
205 IT->position is set to within IT->object's boundaries. Break from
206 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
207 when IT->position is set up wrongly due to some bug.
208 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
209 (push_display_prop): Allow GET_FROM_STRING as IT->method on
210 entry. Force push_it to save on the stack the current
211 buffer/string position, to be restored by pop_it. Fix flags in
212 the iterator structure wrt the object coming from a display
213 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
214 properties. (Bug#9284)
215
7be1c708 2162011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 217
7be1c708
CY
218 * fontset.c (fontset_get_font_group): Add proper type checks.
219 (Bug#9172)
aac0c6e3 220
7be1c708 2212011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 222
7be1c708
CY
223 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
224 and LC_VERSION_MIN_MACOSX.
225 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
226 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 227
97bb72a6
EZ
2282011-08-08 Eli Zaretskii <eliz@gnu.org>
229
230 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
231 no-display-properties-and-no-overlays under bidi display.
232 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 233 properties and overlays.
97bb72a6 234
d5617611
CY
2352011-08-08 Chong Yidong <cyd@stupidchicken.com>
236
37e11a63
CY
237 * editfns.c (Fset_time_zone_rule): Document relationship with the
238 setenv function.
239
d5617611
CY
240 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
241 the font entity extracted from the cache (Bug#8109).
242
58872834
CY
2432011-08-07 Chong Yidong <cyd@stupidchicken.com>
244
245 * composite.c (autocmp_chars): Don't reset point. That is done by
246 restore_point_unwind (Bug#5984).
247
75bfc667
JL
2482011-08-07 Juri Linkov <juri@jurta.org>
249
250 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
251 to show the arg `TIME' instead of `TIMEVAL'.
252
d1410150
EZ
2532011-08-06 Eli Zaretskii <eliz@gnu.org>
254
255 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
256 display property strides EOL and includes a newline, as in
257 longlines-mode. (Bug#9254)
75b771e4
EZ
258 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
259 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
260
261 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
262 is non-zero, even if the data buffer is NULL. Fixes a crash in
263 vertical-motion with longlines-mode. (Bug#9254)
264
35928349
EZ
2652011-08-05 Eli Zaretskii <eliz@gnu.org>
266
ec7cc85b
EZ
267 * bidi.c <bidi_cache_total_alloc>: Now static.
268 (bidi_initialize): Initialize bidi_cache_total_alloc.
269
8b76d6f8 270 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
271 cache. (Bug#9221)
272
273 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
274 amount allocated this far in `bidi_cache_total_alloc'.
275 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
276 non-zero, only free the data buffer without restoring the cache
277 contents. All callers changed.
278
279 * dispextern.h (bidi_unshelve_cache): Update prototype.
280
281 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
282 (move_it_in_display_line, move_it_to)
283 (move_it_vertically_backward, move_it_by_lines): Replace the call
284 to xfree to an equivalent call to bidi_unshelve_cache.
285 (move_it_in_display_line_to): Fix logic of returning
412b6358 286 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 287
e2e2423b
EZ
2882011-08-05 Eli Zaretskii <eliz@gnu.org>
289
290 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
291 came from a string character with a `cursor' property. (Bug#9229)
292
ae9e757a
JD
2932011-08-04 Jan Djärv <jan.h.d@swipnet.se>
294
295 * Makefile.in (LIB_PTHREAD): New variable.
296 (LIBES): Add LIB_PTHREAD (Bug#9216).
297
298 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
299 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
300
213bd7f2
AS
3012011-08-04 Andreas Schwab <schwab@linux-m68k.org>
302
303 * regex.c (re_iswctype): Remove some redundant boolean
304 conversions.
305
99aaf75f
JD
3062011-08-04 Jan Djärv <jan.h.d@swipnet.se>
307
308 * xterm.c (x_find_topmost_parent): New function.
309 (x_set_frame_alpha): Find topmost parent window with
310 x_find_topmost_parent and set the property there also (bug#9181).
311 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
312
c74e9d86
PE
3132011-08-04 Paul Eggert <eggert@cs.ucla.edu>
314
315 * callproc.c (Fcall_process): Avoid vfork clobbering
316 the local vars buffer, coding_systems, current_dir.
317
640c8776
SM
3182011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
319
320 * keymap.c (Fmake_composed_keymap): Move to subr.el.
321
f26d0e4c
PE
3222011-08-03 Paul Eggert <eggert@cs.ucla.edu>
323
8a10d76c
PE
324 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
325 so that it is not optimized away.
326
f26d0e4c
PE
327 * xdisp.c (compute_display_string_pos): Remove unused local.
328
55439c61
EZ
3292011-08-02 Eli Zaretskii <eliz@gnu.org>
330
331 Fix slow cursor motion and scrolling in large buffers with
332 selective display, like Org Mode buffers. (Bug#9218)
333
334 * dispextern.h (struct bidi_it): New member disp_prop_p.
335
336 * xdisp.c: Remove one-slot cache of display string positions.
337 (compute_display_string_pos): Accept an additional argument
338 DISP_PROP_P; callers changed. Scan at most 5K characters forward
339 for a display string or property. If found, set DISP_PROP_P
340 non-zero.
341
342 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
343 DISP_PROP_P, and pass it to compute_display_string_pos.
344 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
345 non-zero. All callers of bidi_fetch_char changed.
346
fb33fa43
SM
3472011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
348
349 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
350
b099e063
DM
3512010-12-03 Don March <don@ohspite.net>
352
353 * keymap.c (Fdefine_key): Fix non-prefix key error message when
354 last character M-[char] is translated to ESC [char] (bug#7541).
355
5cc7f7af
KH
3562011-08-02 Kenichi Handa <handa@m17n.org>
357
d0fffa3f 358 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
359
360 * chartab.c (uniprop_table): Make it non-static.
361
525d5e6e
EZ
3622011-08-01 Eli Zaretskii <eliz@gnu.org>
363
364 * xdisp.c (forward_to_next_line_start): Accept additional argument
365 BIDI_IT_PREV, and store into it the state of the bidi iterator had
366 on the newline.
367 (reseat_at_next_visible_line_start): Use the bidi iterator state
368 returned by forward_to_next_line_start to restore the state of
369 it->bidi_it after backing up to previous newline. (Bug#9212)
370
31011111
AS
3712011-07-30 Andreas Schwab <schwab@linux-m68k.org>
372
373 * regex.c (re_comp): Protoize.
374 (re_exec): Fix return type.
375 (regexec): Fix type of `ret'. (Bug#9203)
376
e5d76069
PE
3772011-07-29 Paul Eggert <eggert@cs.ucla.edu>
378
379 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
380 This is needed if max-image-size is a floating-point number.
381
9a79b20c
AS
3822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
383
384 * print.c (print_object): Print empty symbol as ##.
385
386 * lread.c (read1): Read ## as empty symbol.
387
d8c2fa78
AA
3882011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
389
390 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
391 setting frame foreground color (Bug#9175).
392 (x_set_background_color): Likewise.
393
ffe57a7a
AA
394 * nsmenu.m (-setText): Size tooltip dimensions precisely to
395 contents (Bug#9176).
396 (EmacsTooltip -init): Remove bezels and add shadows to
397 tooltip windows.
398
bf3492a5
AA
399 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
400 or scroll bar (Bug#8470).
401
d55e9c53
AA
402 * nsfont.m (nsfont_open): Remove assignment to voffset and
403 unnecessary vars hshink, expand, hd, full_height, min_height.
404 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
405
406 * nsterm.h (nsfont_info): Remove voffset field.
407
d8c2fa78 4082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
409
410 Implement strike-through and overline on NextStep (Bug#8863).
411
412 * nsfont.m (nsfont_open): Use underline position provided by font,
413 instead of hard-coded value of 2.
414 (nsfont_draw): Call ns_draw_text_decoration instead.
415
416 * nsterm.h: Add declaration for ns_draw_text_decoration.
417
418 * nsterm.m (ns_draw_text_decoration): New function for drawing
419 underline, overline, and strike-through.
420 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
421 ns_draw_text_decoration. Change treatment of cursor drawing to
422 accomodate underlining, etc.
423
4cc60b9b
EZ
4242011-07-28 Eli Zaretskii <eliz@gnu.org>
425
bc7ece87
EZ
426 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
427 default.
4cc60b9b 428
476371c4
PE
4292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
430
66606eea
PE
431 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
432 Without this fix, if a signal arrives just after memory fills up,
433 'malloc' might be invoked reentrantly.
434
476371c4
PE
435 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
436 In other words, assume that every image size is allowed, on non-X
437 hosts. This assumption is probably wrong, but it lets Emacs compile.
438
f3fcc40d
AS
4392011-07-28 Andreas Schwab <schwab@linux-m68k.org>
440
441 * regex.c (re_iswctype): Convert return values to boolean.
442
350c992f
EZ
4432011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
444
445 * xdisp.c (compute_display_string_pos): Don't use cached display
446 string position if the buffer had its restriction changed.
447 (Bug#9184)
448
5266b4bb
PE
4492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
450
451 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
452
2573a837 4532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 454
41f55ccd 455 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 456
39e378da
PE
457 * bidi.c: Integer size and overflow fixes.
458 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
459 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
460 (bidi_cache_find_level_change, bidi_cache_ensure_space)
461 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
462 (bidi_find_other_level_edge):
463 Use ptrdiff_t instead of EMACS_INT where either will do.
464 This works better on 32-bit hosts configured --with-wide-int.
465 (bidi_cache_ensure_space): Check for size-calculation overflow.
466 Use % rather than repeated addition, for better worst-case speed.
467 Don't set bidi_cache_size until after xrealloc returns, because it
468 might not return.
469 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
470 (bidi_cache_ensure_space): Also check that the bidi cache size
471 does not exceed that of the largest Lisp string or buffer. See Eli
472 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 473
5e927815
PE
474 * alloc.c (__malloc_size_t): Remove.
475 All uses replaced by size_t. See Andreas Schwab's note
476 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
477
ca4aa935
PE
478 * image.c: Improve checking for integer overflow.
479 (check_image_size): Assume that f is nonnull, since
480 it is always nonnull in practice. This is one less thing to
481 worry about when checking for integer overflow later.
482 (x_check_image_size): New function, which checks for integer
483 overflow issues inside X.
484 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
485 This removes the need for a memory_full check.
486 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
487 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
488 (xbm_read_bitmap_data): Change locals back to 'int', since
489 their values must fit in 'int'.
490 (xpm_load_image, png_load, tiff_load):
491 Invoke x_create_x_image_and_pixmap earlier,
492 to avoid much needless work if the image is too large.
493 (tiff_load): Treat overly large images as if
494 x_create_x_image_and_pixmap failed, not as malloc failures.
495 (gs_load): Use x_check_image_size.
496
5f8f9cc2
PE
497 * gtkutil.c: Omit integer casts.
498 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
499 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
500
5adf60bc
PE
501 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
502
c8907a93
PE
503 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
504 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
505 would wrongly return t on a 64-bit host.
506
e3c25c68
PE
507 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
508 The plain *_OVERFLOW macros run afoul of GCC bug 49705
509 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
510 and therefore cause GCC to emit a bogus diagnostic in some cases.
511
3f791afe
PE
512 * image.c: Integer signedness and overflow and related fixes.
513 This is not an exhaustive set of fixes, but it's time to
514 record what I've got.
515 (lookup_pixel_color, check_image_size): Remove redundant decls.
516 (check_image_size): Don't assume that arbitrary EMACS_INT values
517 fit in 'int', or that arbitrary 'double' values fit in 'int'.
518 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
519 (tiff_load, imagemagick_load_image):
520 Check for overflow in size calculations.
521 (x_create_x_image_and_pixmap): Remove unnecessary test for
522 xmalloc returning NULL; that can't happen.
523 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
524 (xpm_color_bucket): Use better integer hashing function.
525 (xpm_cache_color): Don't possibly over-allocate memory.
526 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
527 (gif_memory_source):
528 Use ptrdiff_t, not int or size_t, to record sizes.
529 (png_load): Don't assume values greater than 2**31 fit in 'int'.
530 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
531 either works, as we prefer signed integers.
532 (tiff_read_from_memory, tiff_write_from_memory):
533 Return tsize_t, not size_t, since that's what the TIFF API wants.
534 (tiff_read_from_memory): Don't fail simply because the read would
535 go past EOF; instead, return a short read.
536 (tiff_load): Omit no-longer-needed casts.
537 (Fimagemagick_types): Don't assume size fits into 'int'.
538
3cc5a532
PE
539 Improve hashing quality when configured --with-wide-int.
540 * fns.c (hash_string): New function, taken from sxhash_string.
541 Do not discard information about ASCII character case; this
542 discarding is no longer needed.
543 (sxhash-string): Use it. Change sig to match it. Caller changed.
544 * lisp.h: Declare it.
545 * lread.c (hash_string): Remove, since we now use fns.c's version.
546 The fns.c version returns a wider integer if --with-wide-int is
547 specified, so this should help the quality of the hashing a bit.
548
b312a492
PE
549 * emacs.c: Integer overflow minor fix.
550 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
551 Define only if GNU_LINUX.
552 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
553
dfd153ae
PE
554 * dispnew.c: Integer signedness and overflow fixes.
555 Remove unnecessary forward decls, that were a maintenance hassle.
556 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
557 All uses changed.
558 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
559 (scrolling_window): Use ptrdiff_t, not int, for byte count.
560 (prepare_desired_row, line_draw_cost):
561 Use int, not unsigned, where either works.
562 (save_current_matrix, restore_current_matrix):
563 Use ptrdiff_t, not size_t, where either works.
564 (init_display): Check for overflow more accurately, and without
565 relying on undefined behavior.
566
a81d11a3
PE
567 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
568 Remove, replacing with the new symbols in lisp.h. All uses changed.
569 * fileio.c (make_temp_name):
570 * filelock.c (lock_file_1, lock_file):
571 * xdisp.c (message_dolog):
572 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
573 Use pMd etc. instead.
574 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
575 replacing the pWIDE etc. symbols removed from editfns.c.
576
3300e6fd
PE
577 * keyboard.h (num_input_events): Now uintmax_t.
578 This is (very slightly) less likely to mess up due to wraparound.
579 All uses changed.
580
fd05c7e9
PE
581 * buffer.c: Integer signedness fixes.
582 (alloc_buffer_text, enlarge_buffer_text):
583 Use ptrdiff_t rather than size_t when either will do, as we prefer
584 signed integers.
585
903fe15d
PE
586 * alloc.c: Integer signedness and overflow fixes.
587 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
588 (__malloc_size_t): Default to size_t, not to int.
589 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
590 (Fgarbage_collect, mark_object_loop_halt, mark_object):
591 Prefer ptrdiff_t to size_t when either would do, as we prefer
592 signed integers.
593 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
594 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
595 Now const. Initialize with values that are in range even if char
596 is signed.
597 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
598 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
599 These functions do the right thing with sizes > 2**32.
600 (check_depth): Now ptrdiff_t, not int.
601 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
602 Adjust to new way of storing sizes. Check for size overflow bugs
603 in rest of code.
604 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
605 slightly wrong anyway, as it missed one instance of
606 XMALLOC_OVERRUN_CHECK_OVERHEAD.
607 (refill_memory_reserve): Omit needless cast to size_t.
608 (mark_object_loop_halt): Mark as externally visible.
609
ac82cc6a
PE
610 * xselect.c: Integer signedness and overflow fixes.
611 (Fx_register_dnd_atom, x_handle_dnd_message):
612 Use ptrdiff_t, not size_t, since we prefer signed.
613 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
614 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
615 x_dnd_atoms_size and x_dnd_atoms_length.
616
c2d1e36d
PE
617 * doprnt.c: Prefer signed to unsigned when either works.
618 * eval.c (verror):
619 * doprnt.c (doprnt):
620 * lisp.h (doprnt):
621 * xdisp.c (vmessage):
622 Use ptrdiff_t, not size_t, when using or implementing doprnt,
623 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
624 prefer signed arithmetic to avoid comparison confusion.
625 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
626 but is a bit tricky.
627
0e926e56
PE
628 Assume freestanding C89 headers, string.h, stdlib.h.
629 * data.c, doprnt.c, floatfns.c, print.c:
630 Include float.h unconditionally.
631 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
632 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
633 * regex.c: Likewise for stddef.h, string.h.
634 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
635 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
636 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
637 (STDC_HEADERS): Remove obsolete defines.
638 * sysdep.c: Include limits.h unconditionally.
639
9cfdb3ec
PE
640 Assume support for memcmp, memcpy, memmove, memset.
641 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
642 * regex.c (memcmp, memcpy):
643 Remove; we assume C89 now.
644
645 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
646 (__malloc_safe_bcopy): Remove; no longer needed.
647
cf950e6b 648 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
649 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
650 well either way, and we prefer signed to unsigned.
651
dbf38e02
LMI
6522011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
653
654 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
655 closes the connection while we're reading (bug#9182).
656
d6f0886c
JD
6572011-07-25 Jan Djärv <jan.h.d@swipnet.se>
658
659 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
660 are specified (Bug#9168).
661
2eb1f9e6
PE
6622011-07-25 Paul Eggert <eggert@cs.ucla.edu>
663
664 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
665 Found by GCC static checking and --with-wide-int on a 32-bit host.
666
22381272 6672011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
668
669 * xdisp.c (compute_display_string_pos): Fix logic of caching
670 previous display string position. Initialize cached_prev_pos to
671 -1. Fixes slow-down at the beginning of a buffer.
672
f25e39b4
EZ
6732011-07-24 Eli Zaretskii <eliz@gnu.org>
674
675 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
676 for attrs[LFACE_FONTSET_INDEX].
677
04c4b52e
PE
6782011-07-23 Paul Eggert <eggert@cs.ucla.edu>
679
680 * xml.c (parse_region): Remove unused local
681 that was recently introduced.
682
c1734fbd
EZ
6832011-07-23 Eli Zaretskii <eliz@gnu.org>
684
be18c5a5
EZ
685 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
686 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
687
c1734fbd
EZ
688 * xdisp.c (move_it_in_display_line_to): Record the best matching
689 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
690 exit if none of the characters scanned was an exact match.
691 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
692 when exact match is impossible due to invisible text, and the
693 lines are truncated.
694
a258d627
JD
6952011-07-23 Jan Djärv <jan.h.d@swipnet.se>
696
697 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
698 for OSX >= 10.7.
699
b6d5a689
EZ
7002011-07-22 Eli Zaretskii <eliz@gnu.org>
701
0f74f785
EZ
702 Fix a significant slow-down of cursor motion with C-n, C-p,
703 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
704 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 705 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
706 (next_element_from_buffer): Call compute_stop_pos_backwards to
707 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
708 base_level_stop.
709 (reseat): Don't look for prev_stop, as that could mean a very long
710 run.
711 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
712 <cached_disp_overlay_modiff>: Cache for last found display string
713 position.
551918c1 714 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
715 about the same buffer in the same area of character positions, and
716 the buffer wasn't changed since the time the display string
717 position was cached.
551918c1 718
b2d0c91a
EZ
7192011-07-22 Eli Zaretskii <eliz@gnu.org>
720
721 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
722 is an integer, which is important for empty lines. (Bug#9149)
723
043604ee
CY
7242011-07-22 Chong Yidong <cyd@stupidchicken.com>
725
726 * frame.c (Fmodify_frame_parameters): In tty case, update the
727 default face if necessary (Bug#4238).
728
da4adb04
CY
7292011-07-21 Chong Yidong <cyd@stupidchicken.com>
730
731 * editfns.c (Fstring_to_char): No need to explain what a character
732 is in the docstring (Bug#6576).
733
9abd0532
LMI
7342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
735
736 * xml.c (parse_region): Make sure we always return a tree.
737
36881d16
HK
7382011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
739
740 * xml.c (parse_region): If a document contains only comments,
741 return that, too.
742
1e98674d
LMI
7432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
744
745 * xml.c (make_dom): Return comments, too.
746
590bd467
PE
7472011-07-19 Paul Eggert <eggert@cs.ucla.edu>
748
749 Port to OpenBSD.
750 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
751 and the surrounding thread.
752 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
753 rather than fgets, and retry after EINTR. Otherwise, 'emacs
754 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
755 timer goes off.
756 * s/openbsd.h (BROKEN_SIGIO): Define.
757 * unexelf.c (unexec) [__OpenBSD__]:
758 Don't update the .mdebug section of the Alpha COFF symbol table.
759
f41628b2
LMI
7602011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
761
762 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
763 (bug#8460).
764
b59b67c5
PE
7652011-07-18 Paul Eggert <eggert@cs.ucla.edu>
766
15e3a074
PE
767 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
768 This fixes some race conditions on the permissions of any newly
769 created file.
770
41bed37d
PE
771 * alloc.c (valid_pointer_p): Use pipe, not open.
772 This fixes some permissions issues when debugging.
773
b59b67c5
PE
774 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
775 If fchown fails to set both uid and gid, try to set just gid,
776 as that is sometimes allowed. Adjust the file's mode to eliminate
777 setuid or setgid bits that are inappropriate if fchown fails.
778
925a6be7
SM
7792011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
780
781 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
782 to compare Lisp_Objects.
783 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
784 global_gnutls_log_level, don't mistake it for a Lisp_Object.
785 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
786
52968808
AS
7872011-07-17 Andreas Schwab <schwab@linux-m68k.org>
788
0a6a104b
AS
789 * lread.c (read_integer): Unread even EOF character.
790 (read1): Likewise. Properly record start position of symbol.
791
52968808
AS
792 * lread.c (read1): Read `#:' as empty uninterned symbol if no
793 symbol character follows.
794
9e381cdd
PE
7952011-07-17 Paul Eggert <eggert@cs.ucla.edu>
796
797 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
798 This works around a problem with the previous change to Fcopy_file.
799 Recent glibc declares fchown with __attribute__((warn_unused_result)),
800 and without this change, GCC might complain about discarding
801 fchown's return value.
802
b5641435
JB
8032011-07-16 Juanma Barranquero <lekktu@gmail.com>
804
805 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
806
a8031457
PE
8072011-07-16 Paul Eggert <eggert@cs.ucla.edu>
808
809 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
810
dd889327
LMI
8112011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
812
750c33f7
LMI
813 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
814 it's used from the C level.
815
dd889327
LMI
816 * process.c: Use the same condition for POLL_FOR_INPUT in both
817 keyboard.c and process.c (bug#1858).
818
87e86684
LM
8192011-07-09 Lawrence Mitchell <wence@gmx.li>
820
821 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
822 (Fgnutls_boot): Use it.
823
64348f40
AS
8242011-07-15 Andreas Schwab <schwab@linux-m68k.org>
825
826 * doc.c (Fsubstitute_command_keys): Revert last change.
827
1d698799
LMI
8282011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
829
f863868c
LMI
830 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
831 quotes the next character, and doesn't affect other longer
832 sequences (bug#8935).
833
1d698799
LMI
834 * lread.c (syms_of_lread): Clarify that is isn't only
835 `eval-buffer' and `eval-defun' that's affected by
836 `lexical-binding' (bug#8460).
837
aa4b6df6
EZ
8382011-07-15 Eli Zaretskii <eliz@gnu.org>
839
840 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
841 bidi redisplay when a line includes both an image and is
842 truncated.
843
5d856da6
PE
8442011-07-14 Paul Eggert <eggert@cs.ucla.edu>
845
ad6042bb
PE
846 Fix minor problems found by static checking.
847 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
848 (elsz): Now a signed constant, not a size_t var. We prefer signed
849 types to unsigned, to avoid integer comparison confusion. Without
850 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
851 "cannot optimize loop, the loop counter may overflow", a symptom
852 of the confusion.
f00bbb22 853 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
854 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
855
6468f31c
LMI
8562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
857
49080b10
LMI
858 * search.c (Fre_search_backward): Mention `case-fold-search' in
859 all the re_search_* functions (bug#8138).
860
6468f31c
LMI
861 * keyboard.c (Fopen_dribble_file): Document when the file is
862 closed (bug#8056).
863
c965adc5
EZ
8642011-07-14 Eli Zaretskii <eliz@gnu.org>
865
df9733bf
EZ
866 * bidi.c (bidi_dump_cached_states): Fix format of displaying
867 bidi_cache_idx.
868
0bb23927
EZ
869 Support bidi reordering of display and overlay strings.
870 * xdisp.c (compute_display_string_pos)
871 (compute_display_string_end): Accept additional argument STRING.
872 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
873 (reseat_to_string): Initialize bidi_it->string.s and
874 bidi_it->string.schars.
875 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
876 NULL (avoids a crash in bidi_paragraph_init).
877 Initialize itb.string.lstring.
0bb23927
EZ
878 (init_iterator): Call bidi_init_it only of a valid
879 buffer position was specified. Initialize paragraph_embedding to
880 L2R.
881 (reseat_to_string): Initialize the bidi iterator.
882 (display_string): If we need to ignore text properties of
883 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
884 original value of -1 will not work with bidi.)
885 (compute_display_string_pos): First arg is now struct
886 `text_pos *'; all callers changed. Support display properties on
887 Lisp strings.
888 (compute_display_string_end): Support display properties on Lisp
889 strings.
890 (init_iterator, reseat_1, reseat_to_string): Initialize the
891 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
892 when iterating on a string not from display properties).
640c8776
SM
893 (compute_display_string_pos, compute_display_string_end):
894 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
895 arrow keys.
896 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
897 base_level_stop; instead, set base_level_stop to BEGV.
898 Fixes crashes in vertical-motion.
0bb23927
EZ
899 (next_element_from_buffer): Improve commentary for when
900 the iterator is before prev_stop.
901 (init_iterator): Initialize bidi_p from the default value of
902 bidi-display-reordering, not from buffer-local value. Use the
903 buffer-local value only if initializing for buffer iteration.
904 (handle_invisible_prop): Support invisible properties on strings
905 that are being bidi-reordered.
906 (set_iterator_to_next): Support bidi reordering of C strings and
907 Lisp strings.
908 (next_element_from_string): Support bidi reordering of Lisp
909 strings.
910 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
911 (display_string): Support display of R2L glyph rows.
912 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
913 (init_iterator): Don't initialize it->bidi_p for strings
914 here.
915 (reseat_to_string): Initialize it->bidi_p for strings here.
916 (next_element_from_string, next_element_from_c_string)
917 (next_element_from_buffer): Add xassert's for correspondence
918 between IT's object being iterated and it->bidi_it.string
919 structure.
920 (face_before_or_after_it_pos): Support bidi iteration.
921 (next_element_from_c_string): Handle the case of the first string
922 character that is not the first one in the visual order.
923 (get_visually_first_element): New function, refactored from common
924 parts of next_element_from_buffer, next_element_from_string, and
925 next_element_from_c_string.
926 (tool_bar_lines_needed, redisplay_tool_bar)
927 (display_menu_bar): Force left-to-right direction. Add a FIXME
928 comment for making that be controlled by a user option.
929 (push_it, pop_it): Save and restore the state of the
930 bidi iterator. Save and restore the bidi_p flag.
931 (pop_it): Iterate out of display property for string iteration as
932 well.
933 (iterate_out_of_display_property): Support iteration over strings.
934 (handle_single_display_spec): Set up it->bidi_it for iteration
935 over a display string, and call bidi_init_it.
936 (handle_single_display_spec, next_overlay_string)
937 (get_overlay_strings_1, push_display_prop): Set up the bidi
938 iterator for displaying display or overlay strings.
939 (forward_to_next_line_start): Don't use the shortcut if
940 bidi-iterating.
941 (back_to_previous_visible_line_start): If handle_display_prop
942 pushed the iterator stack, restore the internal state of the bidi
943 iterator by calling bidi_pop_it same number of times.
944 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
945 and we are bidi-iterating, don't decrement the iterator position;
946 instead, set the first_elt flag in the bidi iterator, to produce
947 the same effect.
948 (reseat_1): Remove redundant setting of string_from_display_prop_p.
949 (push_display_prop): xassert that we are iterating a buffer.
950 (push_it, pop_it): Save and restore paragraph_embedding member.
951 (handle_single_display_spec, next_overlay_string)
952 (get_overlay_strings_1, reseat_1, reseat_to_string)
953 (push_display_prop): Set up the `unibyte' member of bidi_it.string
954 correctly. Don't assume unibyte strings are not bidi-reordered.
955 (compute_display_string_pos)
956 (compute_display_string_end): Fix handling the case of C string.
957 (push_it, pop_it): Save and restore from_disp_prop_p.
958 (handle_single_display_spec, push_display_prop): Set the
959 from_disp_prop_p flag.
960 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
961 (pop_it): Call iterate_out_of_display_property only if we are
962 popping after iteration over a string that came from a display
963 property. Fix a typo in popping stretch info. Add an assertion
964 for verifying that the iterator position is in sync with the bidi
965 iterator.
966 (handle_single_display_spec, get_overlay_strings_1)
967 (push_display_prop): Fix initialization of paragraph direction for
968 string when that of the parent object is not yet determined.
969 (reseat_1): Call bidi_init_it to resync the bidi
970 iterator with IT's position. (Bug#7616)
971 (find_row_edges): If ROW->start.pos gives position
972 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
973 (handle_stop, back_to_previous_visible_line_start, reseat_1):
974 Reset the from_disp_prop_p flag.
975 (SAVE_IT, RESTORE_IT): New macros.
976 (pos_visible_p, face_before_or_after_it_pos)
977 (back_to_previous_visible_line_start)
978 (move_it_in_display_line_to, move_it_in_display_line)
979 (move_it_to, move_it_vertically_backward, move_it_by_lines)
980 (try_scrolling, redisplay_window, display_line): Use them when
981 saving a temporary copy of the iterator and restoring it back.
982 (back_to_previous_visible_line_start, reseat_1)
983 (init_iterator): Empty the bidi cache "stack".
984 (move_it_in_display_line_to): If iterator ended up at
985 EOL, but we never saw any buffer positions smaller than
986 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
987 motion in bidi-reordered lines.
988 (move_it_in_display_line_to): Record prev_method and prev_pos
989 immediately before the call to set_iterator_to_next. Fixes cursor
990 motion in bidi-reordered lines with stretch glyphs and strings
991 displayed in margins. (Bug#8133) (Bug#8867)
992 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
993 TO_CHARPOS.
640c8776
SM
994 (pos_visible_p): Support positions in bidi-reordered lines.
995 Save and restore bidi cache.
0bb23927
EZ
996
997 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
998 (bidi_paragraph_info): Delete unused struct.
999 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1000 (bidi_cache_start): New variable.
1001 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1002 to zero.
1003 (bidi_cache_fetch_state, bidi_cache_search)
1004 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1005 (bidi_cache_find, bidi_peek_at_next_level)
1006 (bidi_level_of_next_char, bidi_find_other_level_edge)
1007 (bidi_move_to_visually_next): Compare cache index with
1008 bidi_cache_start rather than with zero.
1009 (bidi_fetch_char): Accept new argument STRING; all callers
1010 changed. Support iteration over a string. Support strings with
1011 display properties. Support unibyte strings. Fix the type of
1012 `len' according to what STRING_CHAR_AND_LENGTH expects.
1013 (bidi_paragraph_init, bidi_resolve_explicit_1)
1014 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1015 (bidi_level_of_next_char, bidi_move_to_visually_next):
1016 Support iteration over a string.
0bb23927
EZ
1017 (bidi_set_sor_type, bidi_resolve_explicit_1)
1018 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1019 can now be zero (for strings); special values 0 and -1 were
1020 changed to -1 and -2, respectively.
1021 (bidi_char_at_pos): New function.
1022 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1023 Call it instead of FETCH_MULTIBYTE_CHAR.
1024 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1025 initialized to valid values.
1026 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1027 values.
1028 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1029 the test for valid cached positions. Fix the logic for looking up
1030 the sentinel state in the cache. GCPRO the Lisp string we are
1031 iterating.
1032 (bidi_push_it, bidi_pop_it): New functions.
1033 (bidi_initialize): Initialize the bidi cache start stack pointer.
1034 (bidi_cache_ensure_space): New function, refactored from part of
1035 bidi_cache_iterator_state. Don't assume the required size is just
1036 one BIDI_CACHE_CHUNK away.
1037 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1038 (bidi_count_bytes, bidi_char_at_pos): New functions.
1039 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1040 always valid if bidi_cache_idx is valid.
1041 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1042 is valid if it's going to be used.
1043 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1044 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1045 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1046 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1047 (bidi_find_other_level_edge, bidi_cache_start_stack):
1048 All variables related to cache indices are now EMACS_INT.
c965adc5 1049
0bb23927
EZ
1050 * dispextern.h (struct bidi_string_data): New structure.
1051 (struct bidi_it): New member `string'. Make flag members be 1-bit
1052 fields, and put them last in the struct.
640c8776
SM
1053 (compute_display_string_pos, compute_display_string_end):
1054 Update prototypes.
0bb23927
EZ
1055 (bidi_push_it, bidi_pop_it): Add prototypes.
1056 (struct iterator_stack_entry): New members bidi_p,
1057 paragraph_embedding, and from_disp_prop_p.
1058 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1059 (bidi_shelve_cache, bidi_unshelve_cache):
1060 Declare prototypes.
0bb23927
EZ
1061
1062 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1063 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1064 and vector-like objects.
1065
1066 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1067 cache around display iteration.
1068
1069 * window.c (Fwindow_end, window_scroll_pixel_based)
1070 (displayed_window_lines, Frecenter): Save and restore the bidi
1071 cache around display iteration.
1072
3bbd2265
LMI
10732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1074
1075 * editfns.c (Fdelete_region): Clarify the use of the named
1076 parameters (bug#6788).
1077
adc47434
MR
10782011-07-14 Martin Rudalics <rudalics@gmx.at>
1079
1080 * indent.c (Fvertical_motion): Set and restore w->pointm when
1081 saving and restoring the window's buffer (Bug#9006).
1082
837c31f8
LMI
10832011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1084
1085 * editfns.c (Fstring_to_char): Clarify just what is returned
1086 (bug#6576). Text by Eli Zaretskii.
1087
ac389d0c
JB
10882011-07-13 Juanma Barranquero <lekktu@gmail.com>
1089
1090 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1091
0be0ce47
EZ
10922011-07-13 Eli Zaretskii <eliz@gnu.org>
1093
1094 * buffer.c (mmap_find): Fix a typo.
1095
cd18e7e3
JB
10962011-07-13 Johan Bockgård <bojohan@gnu.org>
1097
1098 Fix execution of x selection hooks.
1099 * xselect.c (Qx_lost_selection_functions)
1100 (Qx_sent_selection_functions): New vars.
1101 (syms_of_xselect): DEFSYM them.
1102 (x_handle_selection_request): Pass Qx_sent_selection_functions
1103 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1104 (x_handle_selection_clear,x_clear_frame_selections):
1105 Pass Qx_lost_selection_functions rather than
1106 Vx_lost_selection_functions to Frun_hook_with_args.
1107
47ea7f44
PE
11082011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1109
ac389d0c 1110 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1111 The old code sometimes used this field without initializing it.
1112
47ea7f44
PE
1113 * alloc.c (gc_sweep): Don't read past end of array.
1114 In theory, the old code could also have corrupted Emacs internals,
1115 though it'd be very unlikely.
1116
bc985c87
AS
11172011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1118
1119 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1120 argument. (Bug#4026)
bc985c87 1121
0cf34688
LMI
11222011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1123
b3dadd76
LMI
1124 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1125 key" (bug#4257).
1126
0cf34688
LMI
1127 * window.c (Fset_window_start): Doc fix (bug#4199).
1128 (Fset_window_hscroll): Ditto.
1129
270768cd
PE
11302011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1131
077e3dda 1132 Fix minor new problems caught by GCC 4.6.1.
270768cd 1133 * term.c (init_tty): Remove unused local.
490011a6 1134 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1135 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1136 not used otherwise.
270768cd 1137
b1f58454
CY
11382011-07-12 Chong Yidong <cyd@stupidchicken.com>
1139
1140 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1141
22b9578d
LMI
11422011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1143
6e70ab07
LMI
1144 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1145 are the mini-buffer and the echo area (bug#3320).
1146
22b9578d
LMI
1147 * term.c (init_tty): Remove support for supdup, c10 and perq
1148 terminals, which are no longer supported (bug#1482).
1149
8974cc9f
JB
11502011-07-10 Johan Bockgård <bojohan@gnu.org>
1151
1152 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1153
a560d974
JD
11542011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1155
1156 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1157 for non-popups (Bug#3642).
1158
1dae0f0a
AS
11592011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1160
268c2c36 1161 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1162 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1163 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1164 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1165 * data.c (fmod): Likewise.
1166 * dispnew.c (swap_glyphs_in_rows): Likewise.
1167 * emacs.c (memory_warning_signal): Likewise.
1168 * floatfns.c (float_error): Likewise.
1169 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1170 (otf_open, font_otf_capability, generate_otf_features)
1171 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1172 Likewise.
1173 * image.c (pbm_read_file): Likewise.
1174 * indent.c (string_display_width): Likewise.
1175 * intervals.c (check_for_interval, search_for_interval)
1176 (inc_interval_count, count_intervals, root_interval)
1177 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1178 * lread.c (defalias): Likewise.
268c2c36 1179 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1180 * regex.c (set_image_of_range_1, set_image_of_range)
1181 (regex_grow_registers): Likewise.
1182 * sysdep.c (strerror): Likewise.
1183 * termcap.c (valid_filename_p, tprint, main): Likewise.
1184 * tparam.c (main): Likewise.
1185 * unexhp9k800.c (run_time_remap, save_data_space)
1186 (update_file_ptrs, read_header, write_header, calculate_checksum)
1187 (copy_file, copy_rest, display_header): Likewise.
1188 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1189 Likewise.
1190 * xdisp.c (check_it): Likewise.
1191 * xfaces.c (register_color, unregister_color, unregister_colors):
1192 Likewise.
1193 * xfns.c (print_fontset_result): Likewise.
1194 * xrdb.c (member, fatal, main): Likewise.
1195
99033785
PE
11962011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 Fix minor problems found by static checking (Bug#9031).
1199 * chartab.c (char_table_set_range, map_sub_char_table):
1200 Remove unused locals.
1201 (uniprop_table): Now static.
1202 * composite.c (_work_char): Remove unused static var.
1203
9cb2ac56
JB
12042011-07-09 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1207
f25661f0
JD
12082011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1209
1210 * gtkutil.c (qttip_cb): Remove code without function.
1211
8278c4fe
EZ
12122011-07-09 Eli Zaretskii <eliz@gnu.org>
1213
1214 * w32.c (pthread_sigmask): New stub.
1215
1692ae2d 12162011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1217
8a6ebd58 1218 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1219 sigprocmask is portable only for single-threaded applications, and
1220 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1221 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1222 (LIBES): Use it.
1223 * callproc.c (Fcall_process):
1224 * process.c (create_process):
1225 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1226 Use pthread_sigmask, not sigprocmask.
123403e4 1227
1b854618
JD
12282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1229
1230 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1231 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1232 wrong (Bug#8591).
1233
3fe4b549
JD
12342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1235
0ce7e563
JD
1236 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1237 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1238 (xg_hide_tooltip): Fix comment.
1239
3fe4b549
JD
1240 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1241 in registerServicesMenuSendTypes.
1242 (validRequestorForSendType): Don't check ns_return_types.
1243
1244 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1245 ns_return_type.
1246
5df75e47
JR
12472011-07-08 Jason Rumney <jasonr@gnu.org>
1248
1249 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1250 frame struct members of non-existent frames (Bug#6284).
1251
699c10bd
JD
12522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1253
4393663b
JD
1254 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1255 variable firstTime not needed on OSX >= 10.6.
1256 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1257 >= 10.5. Use setKnobProportion, setDoubleValue.
1258
1259 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1260 (MAC_OS_X_VERSION_10_5): Define if not defined.
1261 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1262 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1263 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1264
1265 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1266 cString and lossyCString on OSX >= 10.4
1267
1268 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1269 sizeToFit on OSX >= 10.2.
1270
1271 * nsimage.m (allocInitFromFile): Don't use deprecated method
1272 bestRepresentationForDevice on OSX >= 10.6.
1273
1274 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1275 to avoid warning.
1276
1277 * emacs.c: Declare unexec_init_emacs_zone.
1278
a63e0781
JD
1279 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1280
699c10bd
JD
1281 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1282
1283 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1284 on svcsMenu (Bug#8842).
1285
1286 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1287 ns_return_types.
1288 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1289
1290 * nsterm.m (QUTF8_STRING): Declare.
1291 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1292 (validRequestorForSendType): Return type is (id).
1293 Change indexOfObjectIdenticalTo to indexOfObject.
1294 Check if we have local selection before returning self (Bug#8842).
1295 (writeSelectionToPasteboard): Put local selection into paste board
1296 if we have a local selection (Bug#8842).
1297 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1298
1299 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1300 (ns_get_local_selection): Declare.
1301
54e10184
LMI
13022011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1303
9888ff71
LMI
1304 * keymap.c (describe_map_tree): Don't insert a double newline at
1305 the end of the buffer (bug#1169) and return whether we inserted
1306 something.
1307
54e10184
LMI
1308 * callint.c (Fcall_interactively): Change "reading args" to
1309 "providing args" to try to clarify what it does (bug#1010).
1310
15fa4783
KH
13112011-07-07 Kenichi Handa <handa@m17n.org>
1312
1313 * composite.c (composition_compute_stop_pos): Ignore a static
1314 composition starting before CHARPOS (Bug#8915).
1315
1316 * xdisp.c (handle_composition_prop): Likewise.
1317
a8815b00
EZ
13182011-07-07 Eli Zaretskii <eliz@gnu.org>
1319
1320 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1321 (Bug#9015)
1322
ef7b981d 13232011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1324
1325 * character.h (unicode_category_t): New enum type.
1326
1327 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1328 (Qchar_code_property_table): New variable.
1329 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1330 (UNIPROP_COMPRESSED_FORM_P): New macros.
1331 (char_table_ascii): Uncompress the compressed values.
1332 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1333 Uncompress the compressed values.
ac389d0c 1334 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1335 (char_table_ref_and_range): Uncompress the compressed values.
1336 (sub_char_table_set): New arg is_uniprop. Callers changed.
1337 Uncompress the compressed values.
1338 (sub_char_table_set_range): Args changed. Callers changed.
1339 (char_table_set_range): Adjuted for the above change.
1340 (map_sub_char_table): Delete args default_val and parent. Add arg
1341 top. Give decoded values to a Lisp function.
640c8776 1342 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1343 values to a Lisp function. Gcpro more variables.
1344 (uniprop_table_uncompress)
1345 (uniprop_decode_value_run_length): New functions.
1346 (uniprop_decoder, uniprop_decoder_count): New variables.
1347 (uniprop_get_decoder, uniprop_encode_value_character)
1348 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1349 New functions.
1350 (uniprop_encoder, uniprop_encoder_count): New variables.
1351 (uniprop_get_encoder, uniprop_table)
1352 (Funicode_property_table_internal, Fget_unicode_property_internal)
1353 (Fput_unicode_property_internal): New functions.
1354 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1355 Sunicode_property_table_internal, Sget_unicode_property_internal,
1356 and Sput_unicode_property_internal. Defvar_lisp
1357 char-code-property-alist.
1358
640c8776 1359 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1360 Vunicode_category_table.
1361
640c8776 1362 * font.c (font_range): Adjust for the change of
c805dec0
KH
1363 Vunicode_category_table.
1364
76b397fb
DN
13652011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1366
1367 * m/iris4d.h: Remove file, move contents ...
1368 * s/irix6-5.h: ... here.
1369
22b4128e
PE
13702011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1373 * alloc.c (mark_buffer):
1374 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1375 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1376 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1377 This isn't true in general, and it's particularly not true
1378 if Emacs is configured with --with-wide-int.
1379 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1380 New macros, used in the buffer.c change.
1381
869795d6
JD
13822011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1383
1384 * xsettings.c: Use both GConf and GSettings if both are available.
1385 (store_config_changed_event): Add comment.
1386 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1387 (store_tool_bar_style_changed): New functions.
1388 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1389 (struct xsettings): Move font inside HAVE_XFT.
1390 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1391 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1392 Move inside HAVE_XFT.
640c8776 1393 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1394 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1395 also.
1396 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1397 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1398 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1399 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1400 (parse_settings): Move check for font inside HAVE_XFT.
1401 (read_settings, apply_xft_settings): Add comment.
1402 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1403 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1404 call store_font_name_changed.
1405 (xft_settings_event): Add comment.
1406 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1407 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1408 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1409 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1410 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1411 (xsettings_get_system_font, xsettings_get_system_normal_font):
1412 Add comment.
869795d6 1413
d8ed26bd
PE
14142011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1415
1416 Random fixes. E.g., (random) never returned negative values.
1417 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1418 subseconds part to the entropy, as that's a bit more random.
1419 Prefer signed to unsigned, since the signedness doesn't matter and
1420 in general we prefer signed. When given a limit, use a
1421 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1422 latter isn't right if USE_2_TAGS_FOR_INTS.
1423 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1424 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1425
cabf1cac
SM
14262011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1427
1428 * textprop.c (text_property_stickiness):
1429 Obey Vtext_property_default_nonsticky.
1430 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1431 * w32fns.c (syms_of_w32fns):
1432 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1433
6e9b2be9
PE
14342011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1437 This is more efficient than Ffile_directory_p and avoids a minor race.
1438
90186c68
LMI
14392011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1440
7c301272
LMI
1441 * buffer.c (Foverlay_put): Say what the return value is
1442 (bug#7835).
1443
c4f2d8d4
LMI
1444 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1445 is a directory before asking whether to use the file name
1446 (bug#7564).
ad637907
LMI
1447 (barf_or_query_if_file_exists): Make the "File is a directory"
1448 error be more correct.
c4f2d8d4 1449
90186c68
LMI
1450 * fns.c (Frequire): Remove the mention of the .gz files, since
1451 that's installation-specific, but keep the mention of
1452 `get-load-suffixes'.
1453
da64016e
PE
14542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1457 Report string overflow if the output is too long.
1458
7d47b580
JB
14592011-07-04 Juanma Barranquero <lekktu@gmail.com>
1460
a555cb87
JB
1461 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1462 (syms_of_gnutls): Remove duplicate DEFSYM for
1463 Qgnutls_bootprop_verify_hostname_error, an error for
1464 Qgnutls_bootprop_verify_error (which is no longer used).
1465
7d47b580
JB
1466 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1467 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1468 Also (re)move comments that are misplaced or no longer relevant.
1469
1e49bfab
LMI
14702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1471
1472 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1473
1485f4c0
CY
14742011-07-03 Chong Yidong <cyd@stupidchicken.com>
1475
1476 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1477 and background color parameters if they have been changed.
1478
a9ab721e
LMI
14792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1480
1481 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1482
cf7cff57
PE
14832011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1484
2e13213d
PE
1485 * xsettings.c (SYSTEM_FONT): Define only when used.
1486 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1487
cf7cff57
PE
1488 * keymap.c (access_keymap_1): Now static.
1489
7a8e04f7
CY
14902011-07-02 Chong Yidong <cyd@stupidchicken.com>
1491
1492 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1493 leave any prefix arg for the up event (Bug#1586).
1494
61352f62
LMI
14952011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1496
69bb1ef7
LMI
1497 * lread.c (syms_of_lread): Mention single symbols defined by
1498 `defvar' or `defconst' (bug#7154).
1499
61352f62 1500 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1501 (Frequire): Mention get-load-suffixes.
61352f62 1502
28545e04
MR
15032011-07-02 Martin Rudalics <rudalics@gmx.at>
1504
1505 * window.h (window): Remove clone_number slot.
1506 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1507 Remove.
1508 (make_parent_window, make_window, saved_window)
1509 (Fset_window_configuration, save_window_save): Don't deal with
1510 clone numbers.
1511 * buffer.c (Qclone_number): Remove declaration.
1512 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1513
3349e122
SM
15142011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1515
1516 Add multiple inheritance to keymaps.
1517 * keymap.c (Fmake_composed_keymap): New function.
1518 (Fset_keymap_parent): Simplify.
1519 (fix_submap_inheritance): Remove.
1520 (access_keymap_1): New function extracted from access_keymap to handle
1521 embedded parents and handle lists of maps.
1522 (access_keymap): Use it.
1523 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1524 (Fcopy_keymap): Handle embedded parents.
1525 (Fcommand_remapping, define_as_prefix): Simplify.
1526 (Fkey_binding): Simplify.
1527 (syms_of_keymap): Move minibuffer-local-completion-map,
1528 minibuffer-local-filename-completion-map,
1529 minibuffer-local-must-match-map, and
1530 minibuffer-local-filename-must-match-map to Elisp.
1531 (syms_of_keymap): Defsubr make-composed-keymap.
1532 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1533 (parse_menu_item): Trivial simplification.
1534
3279eb87
GM
15352011-07-01 Glenn Morris <rgm@gnu.org>
1536
1537 * Makefile.in (SETTINGS_LIBS): Fix typo.
1538
4550efdf
KI
15392011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1540
1541 * coding.c (Fencode_coding_string): Record the last coding system
1542 used, as the function doc string says (bug#8738).
1543
0949d2b6
JD
15442011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1545
1546 * xsettings.c (store_monospaced_changed): Take new font as arg and
1547 check for change against current_mono_font.
1548 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1549 (emacs_settings_constructor, emacs_settings_get_property)
1550 (emacs_settings_set_property, emacs_settings_class_init)
1551 (emacs_settings_init, gsettings_obj): Remove.
1552 (something_changedCB): New function for HAVE_GSETTINGS.
1553 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1554 with value as argument.
1555 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1556 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1557 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1558 "changed".
1559
1560 * xgselect.c: Add defined (HAVE_GSETTINGS).
1561 (xgselect_initialize): Ditto.
1562
1563 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1564 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1565 xg_select.
1566
bbc6b304
PE
15672011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 * eval.c (struct backtrace): Simplify and port the data structure.
1570 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1571 signed bit field, as this assumption is not portable and it makes
1572 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1573 "char debug_on_exit : 1" as this is not portable either; instead,
1574 use the portable "unsigned int debug_on_exit : 1". Remove unused
1575 member evalargs. Remove obsolete comments about cc bombing out.
1576
9851bfc5
JD
15772011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1578
51bb811f 1579 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1580 Let HAVE_GSETTINGS override HAVE_GCONF.
1581 (store_monospaced_changed): New function.
1582 (EMACS_SETTINGS): A new type derived from GObject to handle
1583 GSettings notifications.
1584 (emacs_settings_constructor, emacs_settings_get_property)
1585 (emacs_settings_set_property, emacs_settings_class_init):
1586 New functions.
1587 (gsettings_client, gsettings_obj): New variables.
1588 (GSETTINGS_SCHEMA): New define.
1589 (something_changedCB): Call store_monospaced_changed.
1590 (init_gsettings): New function.
1591 (xsettings_initialize): Call init_gsettings.
1592 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1593 to NULL.
1594
640c8776 1595 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1596 GCONF_CFLAGS/LIBS.
1597
5386012d
MR
15982011-06-29 Martin Rudalics <rudalics@gmx.at>
1599
1600 * window.c (resize_root_window, grow_mini_window)
1601 (shrink_mini_window): Rename Qresize_root_window to
1602 Qwindow_resize_root_window and Qresize_root_window_vertically to
1603 Qwindow_resize_root_window_vertically.
1604
f13e0b08
PE
16052011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1608
94515237
JB
16092011-06-27 Juanma Barranquero <lekktu@gmail.com>
1610
1611 * makefile.w32-in: Redesign dependencies so they reflect more
1612 clearly which files are directly included by each source file,
1613 and not through other includes.
1614
e43b6e43
MR
16152011-06-27 Martin Rudalics <rudalics@gmx.at>
1616
1617 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1618 (sort_overlays, overlay_strings): When an overlay's clone number
1619 matches the window's clone number process the overlay even if
1620 the overlay's window property doesn't match the current window.
1621
d68443dc
MR
1622 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1623 (Fwindow_hchild): Rename to Fwindow_left_child.
1624 (Fwindow_next): Rename to Fwindow_next_sibling.
1625 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1626 (resize_window_check): Rename to window_resize_check.
1627 (resize_window_apply): Rename to window_resize_apply.
1628 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1629 (Fdelete_other_windows_internal, resize_frame_windows)
1630 (Fsplit_window_internal, Fdelete_window_internal)
1631 (grow_mini_window, shrink_mini_window)
1632 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1633
c7e73be5
JD
16342011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1635
1636 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1637 (emacs_fixed_set_min_size): Remove.
1638 (emacs_fixed_new): Take frame as argument.
1639
1640 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1641 (_EmacsFixedPrivate): Remove minwidth/height.
1642 Add struct frame *f.
1643 (emacs_fixed_init): Initialize priv->f.
1644 (get_parent_class, emacs_fixed_set_min_size): Remove.
1645 (emacs_fixed_new): Set priv->f to argument.
1646 (emacs_fixed_get_preferred_width)
1647 (emacs_fixed_get_preferred_height): Use min_width/height from
1648 frames size_hint to set minimum and natural (Bug#8919).
1649 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1650 and use min_width/height from frames size_hint to set
1651 min_width/height (Bug#8919).
1652
1653 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1654 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1655 Fix indentation.
c7e73be5 1656
cf99dcf8
EZ
16572011-06-26 Eli Zaretskii <eliz@gnu.org>
1658
1659 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1660 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1661 called at ZV.
1662
029529ac
CY
16632011-06-26 Chong Yidong <cyd@stupidchicken.com>
1664
1665 * process.c (wait_reading_process_output): Bypass select if
1666 waiting for a cell while ignoring keyboard input, and input is
1667 pending. Suggested by Jan Djärv (Bug#8869).
1668
7a7ef429
PE
16692011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1670
1671 Use gnulib's dup2 module instead of rolling our own.
1672 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1673
11fdef7d 16742011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1675
1676 * dispnew.c (scrolling_window): Before scrolling, turn off a
1677 mouse-highlight in the window being scrolled.
1678
cd3520a4
JB
16792011-06-24 Juanma Barranquero <lekktu@gmail.com>
1680
1681 Move DEFSYM to lisp.h and use everywhere.
1682
1683 * character.h (DEFSYM): Move declaration...
1684 * lisp.h (DEFSYM): ...here.
1685
1686 * gnutls.c:
1687 * minibuf.c:
1688 * w32menu.c:
1689 * w32proc.c:
1690 * w32select.c: Don't include character.h.
1691
1692 * alloc.c (syms_of_alloc):
1693 * buffer.c (syms_of_buffer):
1694 * bytecode.c (syms_of_bytecode):
1695 * callint.c (syms_of_callint):
1696 * casefiddle.c (syms_of_casefiddle):
1697 * casetab.c (init_casetab_once):
1698 * category.c (init_category_once, syms_of_category):
1699 * ccl.c (syms_of_ccl):
1700 * cmds.c (syms_of_cmds):
1701 * composite.c (syms_of_composite):
1702 * dbusbind.c (syms_of_dbusbind):
1703 * dired.c (syms_of_dired):
1704 * dispnew.c (syms_of_display):
1705 * doc.c (syms_of_doc):
1706 * editfns.c (syms_of_editfns):
1707 * emacs.c (syms_of_emacs):
1708 * eval.c (syms_of_eval):
1709 * fileio.c (syms_of_fileio):
1710 * fns.c (syms_of_fns):
1711 * frame.c (syms_of_frame):
1712 * fringe.c (syms_of_fringe):
1713 * insdel.c (syms_of_insdel):
1714 * keymap.c (syms_of_keymap):
1715 * lread.c (init_obarray, syms_of_lread):
1716 * macros.c (syms_of_macros):
1717 * msdos.c (syms_of_msdos):
1718 * print.c (syms_of_print):
1719 * process.c (syms_of_process):
1720 * search.c (syms_of_search):
1721 * sound.c (syms_of_sound):
1722 * syntax.c (init_syntax_once, syms_of_syntax):
1723 * terminal.c (syms_of_terminal):
1724 * textprop.c (syms_of_textprop):
1725 * undo.c (syms_of_undo):
1726 * w32.c (globals_of_w32):
1727 * window.c (syms_of_window):
1728 * xdisp.c (syms_of_xdisp):
1729 * xfaces.c (syms_of_xfaces):
1730 * xfns.c (syms_of_xfns):
1731 * xmenu.c (syms_of_xmenu):
1732 * xsettings.c (syms_of_xsettings):
1733 * xterm.c (syms_of_xterm): Use DEFSYM.
1734
4228cf16
TZ
17352011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1736
cd3520a4 1737 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1738
7fcccf1e
PE
17392011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1740
7efb4e0e
PE
1741 Integer and buffer overflow fixes (Bug#8873).
1742
ff5844ad
PE
1743 * print.c (printchar, strout): Check for string overflow.
1744 (PRINTPREPARE, printchar, strout):
1745 Don't set size unless allocation succeeds.
1746
90532f02
PE
1747 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1748 for sizes. Check for string overflow more accurately.
1749 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1750
6d84508d
PE
1751 * macros.c: Integer and buffer overflow fixes.
1752 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1753 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1754 Use ptrdiff_t, not int, for sizes.
1755 Don't increment bufsize until after realloc succeeds.
1756 Check for size-calculation overflow.
1757 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1758
437b2cb4
PE
1759 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1760
8b9ac8b4
PE
1761 * lread.c: Integer overflow fixes.
1762 (read_integer): Radix is now EMACS_INT, not int,
1763 to improve quality of diagnostics for out-of-range radices.
1764 Calculate buffer size correctly for out-of-range radices.
1765 (read1): Check for integer overflow in radices, and in
1766 read-circle numbers.
82cb60d3
PE
1767 (read_escape): Avoid int overflow.
1768 (Fload, openp, read_buffer_size, read1)
1769 (substitute_object_recurse, read_vector, read_list, map_obarray):
1770 Use ptrdiff_t, not int, for sizes.
1771 (read1): Use EMACS_INT, not int, for sizes.
20270765 1772 Check for size overflow.
8b9ac8b4 1773
7fcccf1e
PE
1774 * image.c (cache_image): Check for size arithmetic overflow.
1775
bfbbd7e7
PE
1776 * lread.c: Integer overflow issues.
1777 (saved_doc_string_size, saved_doc_string_length)
1778 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1779 Now ptrdiff_t, not int.
1780 (read1): Don't assume doc string length fits in int. Check for
1781 out-of-range doc string lengths.
1782 (read_list): Don't assume file position fits in int.
39019e54 1783 (read_escape): Check for hex character overflow.
bfbbd7e7 1784
4e323265
LL
17852011-06-22 Leo Liu <sdl.web@gmail.com>
1786
1787 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1788 Move to minibuffer.el.
1789
85fece3e
PE
17902011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1791
20b84ce9 1792 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1793 The following patches are for when GLYPH_DEBUG && !XASSERT.
1794 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1795 * dispnew.c (flush_stdout):
1796 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1797 Mark as externally visible.
1798 * dispnew.c (check_window_matrix_pointers): Now static.
1799 * dispnew.c (window_to_frame_vpos):
1800 * xfns.c (unwind_create_frame):
1801 * xterm.c (x_check_font): Remove unused local.
1802 * scroll.c (CHECK_BOUNDS):
1803 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1804 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1805 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1806 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1807 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1808 Now static.
1809 (debug_method_add): Use va_list and vsprintf rather than relying
1810 on undefined behavior with wrong number of arguments.
1811 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1812 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1813 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1814 since we're not interested in debugging glyphs with old libraries.
1815 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1816 GCC 4.6.0's static checking.
1817
0766b489
PE
18182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1819
31fd4b32
PE
1820 Integer overflow and signedness fixes (Bug#8873).
1821 A few related buffer overrun fixes, too.
1822
b79e8648
PE
1823 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1824
0766b489
PE
1825 * dispextern.h (struct face.stipple):
1826 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1827 (x_bitmap_mask, x_allocate_bitmap_record)
1828 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1829 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1830 (x_create_bitmap_from_xpm_data):
1831 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1832 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1833 (.bitmaps_last):
1834 * xfaces.c (load_pixmap):
1835 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1836 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1837 (.bitmaps_last, struct x_output.icon_bitmap):
1838 Use ptrdiff_t, not int, for bitmap indexes.
1839 (x_allocate_bitmap_record): Check for size overflow.
1840 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1841
b081724f
PE
1842 Use ptrdiff_t, not int, for overlay counts.
1843 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1844 * editfns.c (overlays_around, get_pos_property):
1845 * textprop.c (get_char_property_and_overlay):
1846 * xdisp.c (next_overlay_change, note_mouse_highlight):
1847 * xfaces.c (face_at_buffer_position):
21514da7
PE
1848 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1849 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1850 (Fnext_overlay_change, Fprevious_overlay_change)
1851 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1852 Use ptrdiff_t, not int, for sizes.
21514da7 1853 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1854
3de73e5e
PE
1855 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1856
2606c57b
PE
1857 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1858 (x_session_initialize): Do not assume string length fits in int.
1859
aaafe47a
PE
1860 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1861 This is unlikely, but can occur if DPI is outlandish.
1862
2674ddc8 1863 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1864 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1865
28154962
PE
1866 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1867 * xrdb.c (magic_file_p, search_magic_path):
1868 Omit last arg SUFFIX; it was always 0. All callers changed.
1869 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1870
7de51af5
PE
1871 * xfont.c (xfont_match): Avoid need for strlen.
1872
25ed6cc3
PE
1873 * xfns.c: Don't assume strlen fits in int.
1874 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1875
4eab31dd
PE
1876 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1877 not unsigned long, as we prefer signed integers. All callers changed.
1878 Detect integer overflow in repeat count.
1879 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1880 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1881
171e2a58
PE
1882 * termcap.c: Don't assume sizes fit in int and never overflow.
1883 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1884 (gobble_line): Check for size-calculation overflow.
1885
ad39faca 1886 * minibuf.c (Fread_buffer):
6e5bb2dc 1887 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1888 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1889 Don't assume string length fits in int.
1890
52c61c22 1891 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1892 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1893
b5b8c9e5
PE
1894 * font.c: Don't assume string length fits in int.
1895 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1896 Use ptrdiff_t, not int.
ccd6111c
PE
1897 (font_intern_prop): Don't assume string length fits in int.
1898 Don't assume integer property fits in fixnum.
1899 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1900
882f0d81 1901 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1902 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1903 Reformulate so as not to need the command string.
1904 Invoke gzip -cd rather than gunzip, as it's more portable.
1905 (lock_info_type, lock_file_1, lock_file):
1906 Don't assume pid_t and time_t fit in unsigned long.
1907 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1908 (current_lock_owner): Prefer signed type for sizes.
1909 Use memcpy, not strncpy, where memcpy is what is really wanted.
1910 Don't assume (via atoi) that time_t and pid_t fit in int.
1911 Check for time_t and/or pid_t out of range, e.g., via a network share.
1912 Don't alloca where an auto var works fine.
1913
93f4cf88
PE
1914 * fileio.c: Fix some integer overflow issues.
1915 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1916 Don't assume string length fits in int.
1917 (directory_file_name): Don't assume string length fits in long.
1918 (make_temp_name): Don't assume pid fits in int, or that its print
1919 length is less than 20.
1920
f3e92b69
PE
1921 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1922
1bfdaf10
PE
1923 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1924
35016e9a
PE
1925 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1926
3d1e65a1
PE
1927 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1928 We prefer signed integers, even for size calculations.
1929
0b963a93
PE
1930 * emacs.c: Don't assume string length fits in 'int'.
1931 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1932 (main): Don't invoke strlen when not needed.
1933
573f4b54
PE
1934 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1935 (XD_DEBUG_MESSAGE): Don't waste a byte.
1936
989f33ba
PE
1937 * callproc.c (getenv_internal_1, getenv_internal)
1938 (Fgetenv_internal):
965d34eb
PE
1939 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1940
e4d29b33
PE
1941 * lread.c (invalid_syntax): Omit length argument.
1942 All uses changed. This doesn't fix a bug, but it simplifies the
1943 code away from its former Hollerith-constant appearance, and it's
1944 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1945 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1946
eb49b136
PE
1947 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1948 This didn't break anything, but it didn't help either.
1949 It's confusing to put a bogus integer in a place where the actual
1950 value does not matter.
9f62aeb1 1951 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1952 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1953
15375a22
PE
1954 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1955 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1956 implementation.
b61cc01c
PE
1957 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1958 We prefer signed types, and the value cannot exceed the EMACS_INT
1959 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1960 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1961 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1962 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1963
53b2623d
PE
1964 * indent.c (sane_tab_width): New function.
1965 (current_column, scan_for_column, Findent_to, position_indentation)
1966 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1967 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1968
51cab52b 1969 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1970
f2ed8a70
PE
1971 * lisp.h (lint_assume): New macro.
1972 * composite.c (composition_gstring_put_cache):
1973 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1974
abe80cc6
PE
1975 * editfns.c, insdel.c:
1976 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1977
b02c740e
PE
1978 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1979
ebc96716
PE
1980 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1981
b4e50fa0 1982 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1983 Use much-faster test for byte-length change.
311d5d7c 1984 Don't assume string byte-length fits in 'int'.
a4cf38e4 1985 Check that character arg fits in 'int'.
85461888 1986 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1987
c0c1ee9f
PE
1988 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1989
a498d7f4
PE
1990 * fns.c (concat): Catch string overflow earlier.
1991 Do not rely on integer wraparound.
1992
51cab52b
PE
1993 * dispextern.h (struct it.overlay_strings_charpos)
1994 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1995 * xdisp.c (forward_to_next_line_start)
1996 (back_to_previous_visible_line_start)
1997 (reseat_at_next_visible_line_start, next_element_from_buffer):
1998 Don't arbitrarily truncate the value of 'selective' to int.
1999
76031fad
PE
2000 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2001
5eb55db9
PE
2002 * composite.c: Don't truncate sizes to 'int'.
2003 (composition_gstring_p, composition_reseat_it)
2004 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2005 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2006 not EMACS_UINT, for indexes.
5eb55db9 2007
0703a717
PE
2008 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2009
d6202519
PE
2010 * buffer.c: Include <verify.h>.
2011 (struct sortvec.priority, struct sortstr.priority):
8961a454 2012 Now EMACS_INT, not int.
c20998a7 2013 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2014 (struct sortstr.size, record_overlay_string)
2015 (struct sortstrlist.size, struct sortlist.used):
2016 Don't truncate size to int.
2017 (record_overlay_string): Check for size-calculation overflow.
d6202519 2018 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2019
d5a19415
JM
20202011-06-22 Jim Meyering <meyering@redhat.com>
2021
029529ac 2022 Don't leak an XBM-image-sized buffer
d5a19415
JM
2023 * image.c (xbm_load): Free the image buffer after using it.
2024
a9041e6c
PE
20252011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 Port to Sun C.
2028 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2029 that Sun C diagnosed.
2030 * fns.c (secure_hash): Fix pointer signedness issue.
2031 * intervals.c (static_offset_intervals): New function.
2032 (offset_intervals): Use it.
2033
7f3f739f
LL
20342011-06-21 Leo Liu <sdl.web@gmail.com>
2035
2036 * deps.mk (fns.o):
2037 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2038 sha512.h.
2039
2040 * fns.c (secure_hash): Rename from crypto_hash_function and change
2041 the first arg to accept symbols.
5b66d427 2042 (Fsecure_hash): New primitive.
7f3f739f
LL
2043 (syms_of_fns): New symbols.
2044
76147d94
DD
20452011-06-20 Deniz Dogan <deniz@dogan.se>
2046
2047 * process.c (Fset_process_buffer): Clarify return value in
2048 docstring.
2049
7d7d0045
CY
20502011-06-18 Chong Yidong <cyd@stupidchicken.com>
2051
2052 * dispnew.c (add_window_display_history): Use BVAR.
2053
2054 * xdisp.c (debug_method_add): Use BVAR.
2055 (check_window_end, dump_glyph_matrix, dump_glyph)
2056 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2057
2058 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2059 Likewise.
2060
2061 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2062 check till after the cache is created in init_frame_faces.
2063
ff2bc410
SM
20642011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2065
2066 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2067
28177add
PE
20682011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2069
dd3482fe
PE
2070 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2071 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2072 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2073
393d71f3 2074 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2075 * fileio.c (Finsert_file_contents):
2076 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2077 Remove the old (too-loose) buffer overflow checks.
2078 They weren't needed, since make_gap checks for buffer overflow.
2079 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2080 The old code merely checked for Emacs fixnum overflow, and relied
2081 on undefined (wraparound) behavior. The new code avoids undefined
2082 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2083
2e6813b0 2084 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2085 Tune. Don't use wider integers than needed. Don't use alloca.
2086 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2087
599a9e4f
PE
2088 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2089
99561444
PE
2090 * insdel.c, lisp.h (buffer_overflow): New function.
2091 (insert_from_buffer_1, replace_range, replace_range_2):
2092 * insdel.c (make_gap_larger):
2093 * editfns.c (Finsert_char):
2094 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2095
28177add
PE
2096 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2097
e69dafad
PE
20982011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2099
a7af7fde 2100 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2101
b1c46f02
PE
2102 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2103 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2104
e69dafad
PE
2105 * fileio.c: Don't assume EMACS_INT fits in off_t.
2106 (emacs_lseek): New static function.
2107 (Finsert_file_contents, Fwrite_region): Use it.
2108 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2109
566684ea
PE
2110 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2111
e6966cd6
PE
2112 * fns.c: Don't overflow int when computing a list length.
2113 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2114 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2115 truncation on 64-bit hosts. Check for QUIT every
2116 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2117 faster and is responsive enough.
2118 (Flength): Report an error instead of overflowing an integer.
2119 (Fsafe_length): Return a float if the value is not representable
2120 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2121 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2122 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2123
dd0b0efb
PE
2124 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2125 (header_size, word_size): New constants.
2126 (allocate_vectorlike): Don't check size overflow here.
2127 (allocate_vector): Check it here instead, since this is the only
2128 caller of allocate_vectorlike that could cause overflow.
2129 Check that the new vector's length is representable as a fixnum.
2130
86fe5cfe
PE
2131 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2132 The previous code was bogus. For example, next_almost_prime (32)
2133 returned 39, which is undesirable as it is a multiple of 3; and
2134 next_almost_prime (24) returned 25, which is a multiple of 5 so
2135 why was the code bothering to check for multiples of 7?
2136
80e88859
PE
2137 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2138
4a2f0ad6
PE
2139 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2140
f66c7cf8
PE
2141 Variadic C functions now count arguments with ptrdiff_t.
2142 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2143 Back then I didn't know that the Emacs coding style prefers signed int.
2144 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2145 were being counted with int, which may truncate counts on 64-bit
2146 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2147 * lisp.h (struct Lisp_Subr.function.aMANY)
2148 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2149 Arg counts are now ptrdiff_t, not size_t.
2150 All variadic functions and their callers changed accordingly.
2151 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2152 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2153 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2154 * callint.c (Fcall_interactively): Check arg count for overflow,
2155 to avoid potential buffer overrun. Use signed char, not 'int',
2156 for 'varies' array, so that we needn't bother to check its size
2157 calculation for overflow.
2158 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2159 * eval.c (apply_lambda):
2160 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2161 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2162 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2163
a1759b76
PE
2164 * callint.c (Fcall_interactively): Don't use index var as event count.
2165
d96be9fc
PE
2166 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2167 * mem-limits.h (SIZE): Remove; no longer used.
2168
a690a978 2169 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2170
578c21e6
PE
2171 Remove unnecessary casts.
2172 * xterm.c (x_term_init):
2173 * xfns.c (x_set_border_pixel):
2174 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2175 These aren't needed now that we assume ANSI C.
2176
96f53c6c
PE
2177 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2178 It's more likely to cause problems (due to unsigned overflow)
2179 than to cure them.
2180
83c77d31
PE
2181 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2182
ee2079f1
PE
2183 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2184
6da65536
PE
2185 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2186
7147c4a4
PE
2187 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2188
193e32d9
PE
2189 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2190
e5533da6
PE
2191 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2192
9910e595
PE
2193 GLYPH_CODE_FACE returns EMACS_INT, not int.
2194 * dispextern.h (merge_faces):
2195 * xfaces.c (merge_faces):
01103c44
PE
2196 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2197 Don't assume EMACS_INT fits in int.
9910e595 2198
2638320e
PE
2199 * character.h (CHAR_VALID_P): Remove unused parameter.
2200 * fontset.c, lisp.h, xdisp.c: All uses changed.
2201
045eb8d9
PE
2202 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2203
c1f134b5
PE
2204 * fns.c (concat): Minor tuning based on overflow analysis.
2205 This doesn't fix any bugs. Use int to hold character, instead
2206 of constantly refetching from Emacs object. Use XFASTINT, not
2207 XINT, for value known to be a character. Don't bother comparing
2208 a single byte to 0400, as it's always less.
2209
395fcb93 2210 * floatfns.c (Fexpt):
327eeec8
PE
2211 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2212
abbd3d23
PE
2213 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2214 for characters.
2215
684a03ef
PE
2216 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2217
0fed43f3
PE
2218 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2219 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2220 incorrectly succeed when S was a string, because 4294967386 was
2221 truncated before it was used.
2222
8fd02eb7
PE
2223 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2224 Otherwise, an out-of-range integer could cause undefined behavior
2225 on a 64-bit host.
2226
f8c86b69
PE
2227 * composite.c: Use int, not EMACS_INT, for characters.
2228 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2229 EMACS_INT, for values that are known to be in character range.
2230 This doesn't fix any bugs but is the usual style inside Emacs and
2231 may generate better code on 32-bit machines.
2232
34206dd2
PE
2233 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2234 This is for reasons similar to the recent CHAR_STRING fix.
2235 * charset.c (Fencode_char): Check that character arg is actually
2236 a character. Pass an int to ENCODE_CHAR.
2237 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2238 wider than 'int', as a compile-time check to prevent future regressions
2239 in this area.
2240
c5958d4c 2241 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2242
2243 Make sure a 64-bit char is never passed to CHAR_STRING.
2244 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2245 by silently ignoring the top 32 bits, allowing some values
2246 that were far too large to be valid characters.
2247 * character.h: Include <verify.h>.
2248 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2249 arguments are no wider than unsigned, as a compile-time check
2250 to prevent future regressions in this area.
2251 * data.c (Faset):
01103c44 2252 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2253 (Fsubst_char_in_region):
2254 * fns.c (concat):
2255 * xdisp.c (decode_mode_spec_coding):
2256 Adjust to CHAR_STRING's new requirement.
2257 * editfns.c (Finsert_char, Fsubst_char_in_region):
2258 * fns.c (concat): Check that character args are actually
2259 characters. Without this test, these functions did the wrong
2260 thing with wildly out-of-range values on 64-bit hosts.
2261
d37ca623
PE
2262 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2263 These casts should not be needed on 32-bit hosts, either.
2264 * keyboard.c (read_char):
2265 * lread.c (Fload): Remove casts to unsigned.
2266
ea204efb
PE
2267 * lisp.h (UNSIGNED_CMP): New macro.
2268 This fixes comparison bugs on 64-bit hosts.
2269 (ASCII_CHAR_P): Use it.
2270 * casefiddle.c (casify_object):
01103c44 2271 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2272 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2273 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2274 * dispextern.h (FACE_FROM_ID):
2275 * keyboard.c (read_char): Use UNSIGNED_CMP.
2276
41cb286c
PE
2277 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2278 not to EMACS_INT, to avoid GCC warning.
2279
4a1b9832
PE
2280 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2281
55daad71
PE
2282 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2283 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2284 isn't needed on 32-bit machines.
8f95c75c 2285
01103c44
PE
2286 * buffer.c (Fgenerate_new_buffer_name):
2287 Use EMACS_INT for count, not int.
0ceccced 2288 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2289
2290 * data.c (Qcompiled_function): Now static.
2291
c6f072e7
PE
2292 * window.c (window_body_lines): Now static.
2293
20ce5912
PE
2294 * image.c (gif_load): Rename local to avoid shadowing.
2295
9c4c5f81
PE
2296 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2297 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2298 * alloc.c (make_save_value): Integer argument is now of type
2299 ptrdiff_t, not int.
2300 (mark_object): Use ptrdiff_t, not int.
2301 * lisp.h (pD): New macro.
2302 * print.c (print_object): Use it.
2303
c0c5c8ae
PE
2304 * alloc.c: Use EMACS_INT, not int, to count objects.
2305 (total_conses, total_markers, total_symbols, total_vector_size)
2306 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2307 (total_free_floats, total_floats, total_free_intervals)
2308 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2309 Now EMACS_INT, not int. All uses changed.
2310 (Fgarbage_collect): Compute overall total using a double, so that
2311 integer overflow is less likely to be a problem. Check for overflow
2312 when converting back to an integer.
5a25e253
PE
2313 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2314 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2315 These were 'int' variables that could overflow on 64-bit hosts;
2316 they were never used, so remove them instead of repairing them.
211a0b2a 2317 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2318 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2319 Previously, this ceilinged at INT_MAX, but that doesn't work on
2320 64-bit machines.
e46bb31a 2321 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2322
c78baabf 2323 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2324 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2325 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2326 when a (possibly-narrower) signed value would do just as well.
2327 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2328
c9d624c6
PE
2329 * alloc.c: Catch some string size overflows that we were missing.
2330 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2331 for convenience in STRING_BYTES_MAX.
2332 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2333 The definition here is exact; the one in lisp.h was approximate.
2334 (allocate_string_data): Check for string overflow. This catches
2335 some instances we weren't catching before. Also, it catches
2336 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2337 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2338 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2339
c9d624c6
PE
2340 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2341 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2342 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2343
353032ce
PE
2344 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2345
2bccce07
PE
2346 * alloc.c (Fmake_string): Check for out-of-range init.
2347
0ac30604
SM
23482011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2349
2350 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2351
c195f2de
JD
23522011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2353
2354 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2355 xg_get_default_scrollbar_width.
2356
2357 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2358 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2359 (style_changed_cb): Call update_theme_scrollbar_width and call
2360 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2361 all frames (Bug#8505).
2362 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2363 Call gtk_window_set_resizable if HAVE_GTK3.
2364 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2365 and height if HAVE_GTK3 (Bug#8505).
2366 (scroll_bar_width_for_theme): New variable.
2367 (update_theme_scrollbar_width): New function.
2368 (xg_get_default_scrollbar_width): Move code to
2369 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2370 (xg_initialize): Call update_theme_scrollbar_width.
2371
2372 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2373
2374 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2375
e10ac9f1
MR
23762011-06-12 Martin Rudalics <rudalics@gmx.at>
2377
2378 * frame.c (make_frame): Call other_buffer_safely instead of
2379 other_buffer.
2380
2381 * window.c (temp_output_buffer_show): Call display_buffer with
2382 second argument Vtemp_buffer_show_specifiers and reset latter
2383 immediately after the call.
2384 (Vtemp_buffer_show_specifiers): New variable.
2385 (auto_window_vscroll_p, next_screen_context_lines)
2386 (Vscroll_preserve_screen_position): Remove leading asterisks from
2387 doc-strings.
2388
2d3c217e 23892011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2390
7b7f97e8 2391 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2392 * buffer.c (Qclone_number): Remove for now, as it's unused.
2393 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2394 (record_buffer): Remove unused local.
2395 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2396 (set_frame_buffer_list): Remove; unused.
2397 * frame.h (other_visible_frames): Remove decl.
2398 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2399 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2400 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2401 if HAVE_GPM.
2402 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2403 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2404 Define only if HAVE_GPM.
2405 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2406 (update_hints_inhibit): Remove; never set. All uses removed.
2407 * widgetprv.h (emacsFrameClassRec): Remove decl.
2408 * window.c (delete_deletable_window): Now returns void, since it
2409 wasn't returning anything.
2410 (compare_window_configurations): Remove unused locals.
2411 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2412 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2413 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2414 the same widths as pointers. This follows up on the 2011-05-06 patch.
2415 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2416 * xterm.h: Likewise.
2417 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2418
1384b89e
JB
24192011-06-12 Juanma Barranquero <lekktu@gmail.com>
2420
2421 * makefile.w32-in: Update dependencies.
2422 (LISP_H): Add lib/intprops.h.
2423
1100a63c
CY
24242011-06-11 Chong Yidong <cyd@stupidchicken.com>
2425
2426 * image.c (gif_load): Add animation frame delay to the metadata.
2427 (syms_of_image): Use DEFSYM. New symbol `delay'.
2428
6198ccd0
MR
24292011-06-11 Martin Rudalics <rudalics@gmx.at>
2430
2431 * window.c (delete_deletable_window): Re-add.
2432 (Fset_window_configuration): Rewrite to handle dead buffers and
2433 consequently deletable windows.
2434 (window_tree, Fwindow_tree): Remove. Supply functionality in
2435 window.el.
2436 (compare_window_configurations): Simplify code.
2437
b6e3633c
AS
24382011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2439
1ab0dee5
AS
2440 * image.c (imagemagick_load_image): Fix type mismatch.
2441 (Fimagemagick_types): Likewise.
2442
b6e3633c
AS
2443 * window.h (replace_buffer_in_windows): Declare.
2444
9397e56f
MR
24452011-06-11 Martin Rudalics <rudalics@gmx.at>
2446
2447 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2448 Qclone_number. Remove external declaration of Qdelete_window.
2449 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2450 code.
640c8776
SM
2451 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2452 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2453 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2454 buffer list implementation.
2455 (other_buffer_safely): New function.
2456 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2457 calls to replace_buffer_in_windows and
2458 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2459 if allowed.
2460 (record_buffer): Inhibit quitting and rewrite using quittable
2461 functions. Run Qbuffer_list_update_hook if allowed.
2462 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2463 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2464 Move switch-to-buffer to window.el.
9397e56f
MR
2465 (bury-buffer): Move to window.el.
2466 (Vbuffer_list_update_hook): New variable.
2467
2468 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2469 section.
2470
2471 * window.h (resize_frame_windows): Move up in code.
2472 (Fwindow_frame): Remove EXFUN.
2473 (replace_buffer_in_all_windows): Remove prototype.
2474 (replace_buffer_in_windows_safely): Add prototype.
2475
2476 * window.c: Declare Qdelete_window static again. Move down
2477 declaration of select_count.
2478 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2479 (Fother_window): Move to window.el.
2480 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2481 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2482 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2483 window.el.
2484 (replace_buffer_in_windows): Implement by calling
2485 Qreplace_buffer_in_windows.
2486 (replace_buffer_in_all_windows): Remove with some functionality
2487 moved into replace_buffer_in_windows_safely.
2488 (replace_buffer_in_windows_safely): New function.
2489 (select_window_norecord, select_frame_norecord): Move in front
2490 of run_window_configuration_change_hook. Remove now obsolete
2491 declarations.
640c8776
SM
2492 (Fset_window_buffer): Rewrite doc-string.
2493 Call Qrecord_window_buffer.
9397e56f
MR
2494 (keys_of_window): Move binding for other-window to window.el.
2495
b50691aa
CY
24962011-06-11 Chong Yidong <cyd@stupidchicken.com>
2497
2498 * dispextern.h (struct image): Replace data member, whose int_val
2499 and ptr_val fields were not used by anything, with a single
2500 lisp_val object.
2501
2502 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2503 (gif_clear_image, gif_load, imagemagick_load_image)
2504 (gs_clear_image, gs_load): Callers changed.
2505
3f754b86
PE
25062011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2507
cca69397
PE
2508 * buffer.h: Include <time.h>, for time_t.
2509 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2510
109e28d0
PE
2511 Fix minor problems found by static checking.
2512
60737f02
PE
2513 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2514
4b66faf3
PE
2515 Make identifiers static if they are not used in other modules.
2516 * data.c (Qcompiled_function, Qframe, Qvector):
2517 * image.c (QimageMagick, Qsvg):
2518 * minibuf.c (Qmetadata):
2519 * window.c (resize_window_check, resize_root_window): Now static.
2520 * window.h (resize_window_check, resize_root_window): Remove decls.
2521
109e28d0
PE
2522 * window.c (window_deletion_count, delete_deletable_window):
2523 Remove; unused.
46a4ce9e
PE
2524 (window_body_lines): Now static.
2525 (Fdelete_other_windows_internal): Mark vars as initialized.
2526 Make sure 'resize_failed' is initialized.
2527 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2528 (resize_window_apply): Remove unused local.
2529 * window.h (delete_deletable_window): Remove decl.
2530
109e28d0 2531 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2532 (imagemagick_load_image): Fix pointer signedness problem by changing
2533 last arg from unsigned char * to char *. All uses changed.
2534 Also, fix a local for similar reasons.
2535 Remove unused locals. Remove locals to avoid shadowing.
2536 (fn_rsvg_handle_free): Remove; unused.
2537 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2538 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2539
3f754b86
PE
2540 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2541
2547adb1
CY
25422011-06-10 Chong Yidong <cyd@stupidchicken.com>
2543
2544 * image.c (gif_load): Fix omitted cast error introduced by
2545 2011-06-06 change.
2546
2c8e37d4
MR
25472011-06-10 Martin Rudalics <rudalics@gmx.at>
2548
2549 * window.h (resize_proportionally, orig_total_lines)
2550 (orig_top_line): Remove from window structure.
2551 (set_window_height, set_window_width, change_window_heights)
2552 (Fdelete_window): Remove prototypes.
2553 (resize_frame_windows): Remove duplicate declaration.
2554
440a42e3
EZ
25552011-06-10 Eli Zaretskii <eliz@gnu.org>
2556
2557 * window.h (resize_frame_windows, resize_window_check)
2558 (delete_deletable_window, resize_root_window)
2559 (resize_frame_windows): Declare prototypes.
2560
2561 * window.c (resize_window_apply): Make definition be "static" to
2562 match the prototype.
2563
562dd5e9
MR
25642011-06-10 Martin Rudalics <rudalics@gmx.at>
2565
2566 * window.c: Remove declarations of Qwindow_size_fixed,
2567 window_min_size_1, window_min_size_2, window_min_size,
2568 size_window, window_fixed_size_p, enlarge_window, delete_window.
2569 Remove static from declaration of Qdelete_window, it's
2570 temporarily needed by Fbury_buffer.
2571 (replace_window): Don't assign orig_top_line and
2572 orig_total_lines.
2573 (Fdelete_window, delete_window): Remove. Window deletion is
2574 handled by window.el.
640c8776
SM
2575 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2576 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2577 (Fdelete_other_windows): Remove. Deleting other windows is
2578 handled by window.el.
2579 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2580 handled in window.el.
2581 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2582 Window minimum sizes are handled in window.el.
2583 (shrink_windows, size_window, set_window_height)
2584 (set_window_width, change_window_heights, window_height)
2585 (window_width, CURBEG, CURSIZE, enlarge_window)
2586 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2587 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2588 handled in window.el.
2589 (make_dummy_parent): Rename to make_parent_window and give it a
2590 second argument horflag.
2591 (make_window): Don't set resize_proportionally any more.
2592 (Fsplit_window): Remove. Windows are split in window.el.
2593 (save_restore_action, save_restore_orig_size)
2594 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2595 Resize mini windows in window.el.
2596 (grow_mini_window, shrink_mini_window): Implement by calling
2597 Qresize_root_window_vertically, resize_window_check and
2598 resize_window_apply.
640c8776
SM
2599 (saved_window, Fset_window_configuration, save_window_save):
2600 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2601 resize_proportionally.
2602 (window_min_height, window_min_width): Move to window.el.
2603 (keys_of_window): Move bindings for delete-other-windows,
2604 split-window, delete-window and enlarge-window to window.el.
2605
2606 * buffer.c: Temporarily extern Qdelete_window.
2607 (Fbury_buffer): Temporarily call Qdelete_window instead of
2608 Fdelete_window (Fbury_buffer will move to window.el soon).
2609
2610 * frame.c (set_menu_bar_lines_1): Remove code handling
2611 orig_top_line and orig_total_lines.
2612
2613 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2614 set_window_height but set heights directly.
2615 (change_frame_size_1): Use resize_frame_windows.
2616
2617 * xdisp.c (init_xdisp): Don't use set_window_height but set
2618 heights directly.
2619
640c8776
SM
2620 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2621 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2622 run_window_configuration_change_hook.
2623
2624 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2625 instead of change_window_heights and run
2626 run_window_configuration_change_hook.
2627
1a13852e
MR
26282011-06-09 Martin Rudalics <rudalics@gmx.at>
2629
2630 * window.c (replace_window): Rename second argument REPLACEMENT to
2631 NEW. New third argument SETFLAG. Rewrite.
2632 (delete_window, make_dummy_parent): Call replace_window with
2633 third argument 1.
2634 (window_list_1): Move down in code.
2635 (run_window_configuration_change_hook): Move set_buffer part
2636 before select_frame_norecord part in order to unwind correctly.
2637 Rename count1 to count.
2638 (recombine_windows, delete_deletable_window, resize_root_window)
2639 (Fdelete_other_windows_internal)
2640 (Frun_window_configuration_change_hook, make_parent_window)
2641 (resize_window_check, resize_window_apply, Fresize_window_apply)
2642 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2643 (Fdelete_window_internal, Fresize_mini_window_internal):
2644 New functions.
1a13852e
MR
2645 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2646
f3d1777e
MR
26472011-06-08 Martin Rudalics <rudalics@gmx.at>
2648
496e208e
MR
2649 * window.h (window): Add some new members to window structure -
2650 normal_lines, normal_cols, new_total, new_normal, clone_number,
2651 splits, nest, prev_buffers, next_buffers.
2652 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2653 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2654
f3d1777e
MR
2655 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2656 Remove.
496e208e
MR
2657 (make_dummy_parent): Set new members of windows structure.
2658 (make_window): Move down in code. Handle new members of window
2659 structure.
2660 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2661 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2662 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2663 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2664 (Fset_window_next_buffers, Fset_window_clone_number):
2665 New functions.
496e208e
MR
2666 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2667 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2668 Doc-string fixes.
2669 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2670 Argument WINDOW can be now internal window too.
2671 (Fwindow_use_time): Move up in code.
2672 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2673 Rewrite doc-string.
2674 (Fset_window_configuration, saved_window)
2675 (Fcurrent_window_configuration, save_window_save): Handle new
2676 members of window structure.
b9e809c2
MR
2677 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2678 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2679 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2680 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2681 Qget_mru_window, Qresize_root_window,
2682 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2683 Qauto_buffer_name; staticpro them.
f3d1777e 2684
abde8f8c
MR
26852011-06-07 Martin Rudalics <rudalics@gmx.at>
2686
2687 * window.c (Fwindow_total_size, Fwindow_left_column)
2688 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2689 (Fwindow_list_1): New functions.
2690 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2691 (Fwindow_width, Fscroll_left, Fscroll_right):
2692 Use window_body_cols instead of window_box_text_cols.
2693 (delete_window, Fset_window_configuration):
2694 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2695 (delete_all_subwindows): Take a window as argument and not a
2696 structure. Rewrite.
190b47e6
MR
2697 (window_loop): Remove handling of GET_LRU_WINDOW and
2698 GET_LARGEST_WINDOW.
2699 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2700
2701 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2702 window_box_text_cols. delete_all_subwindows now takes a
2703 Lisp_Object as argument.
abde8f8c 2704
640c8776
SM
2705 * indent.c (compute_motion, Fcompute_motion):
2706 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2707
fa8a67e6
MR
2708 * frame.c (delete_frame): Call delete_all_subwindows with root
2709 window as argument.
2710
a54e3482
DC
27112011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2712
2713 * fns.c (Fputhash): Document return value.
2714
60002bf5
CY
27152011-06-06 Chong Yidong <cyd@stupidchicken.com>
2716
2717 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2718
0c671da6 27192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2720
b862a52a 2721 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2722
be44ca6c
PE
2723 Check for overflow when converting integer to cons and back.
2724 * charset.c (Fdefine_charset_internal, Fdecode_char):
2725 Use cons_to_unsigned to catch overflow.
2726 (Fencode_char): Use INTEGER_TO_CONS.
2727 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2728 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2729 * data.c (long_to_cons, cons_to_long): Remove.
2730 (cons_to_unsigned, cons_to_signed): New functions.
2731 These signal an error for invalid or out-of-range values.
2732 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2733 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2734 * font.c (Ffont_variation_glyphs):
2735 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2736 * lisp.h: Include <intprops.h>.
2737 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2738 (cons_to_signed, cons_to_unsigned): New decls.
2739 (long_to_cons, cons_to_long): Remove decls.
2740 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2741 (Fprimitive_undo): Use CONS_TO_INTEGER.
2742 * xfns.c (Fx_window_property): Likewise.
2743 * xselect.c: Include <limits.h>.
2744 (x_own_selection, selection_data_to_lisp_data):
2745 Use INTEGER_TO_CONS.
2746 (x_handle_selection_request, x_handle_selection_clear)
2747 (x_get_foreign_selection, Fx_disown_selection_internal)
2748 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2749 (lisp_data_to_selection_data): Use cons_to_unsigned.
2750 (x_fill_property_data): Use cons_to_signed.
2751 Report values out of range.
2752
d1f3d2af
PE
2753 Check for buffer and string overflow more precisely.
2754 * buffer.h (BUF_BYTES_MAX): New macro.
2755 * lisp.h (STRING_BYTES_MAX): New macro.
2756 * alloc.c (Fmake_string):
2757 * character.c (string_escape_byte8):
2758 * coding.c (coding_alloc_by_realloc):
2759 * doprnt.c (doprnt):
2760 * editfns.c (Fformat):
2761 * eval.c (verror):
2762 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2763 since they may not be the same number.
2764 * editfns.c (Finsert_char):
2765 * fileio.c (Finsert_file_contents):
2766 Likewise for BUF_BYTES_MAX.
2767
dd52fcea
PE
2768 * image.c: Use ptrdiff_t, not int, for sizes.
2769 (slurp_file): Switch from int to ptrdiff_t.
2770 All uses changed.
2771 (slurp_file): Check that file size fits in both size_t (for
2772 malloc) and ptrdiff_t (for sanity and safety).
2773
7f9bbdbb
PE
2774 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2775 if b->modtime has its maximal value.
2776
dfe18f82
PE
2777 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2778
84acfcf0
PE
2779 Don't assume time_t can fit into int.
2780 * buffer.h (struct buffer.modtime): Now time_t, not int.
2781 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2782 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2783
ccd9a01a
PE
2784 Minor fixes for signed vs unsigned integers.
2785 * character.h (MAYBE_UNIFY_CHAR):
2786 * charset.c (maybe_unify_char):
2787 * keyboard.c (read_char, reorder_modifiers):
2788 XINT -> XFASTINT, since the integer must be nonnegative.
2789 * ftfont.c (ftfont_spec_pattern):
2790 * keymap.c (access_keymap, silly_event_symbol_error):
2791 XUINT -> XFASTINT, since the integer must be nonnegative.
2792 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2793 since it makes no difference and we prefer signed.
2794 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2795 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2796 nonnegative.
2797
d6d100dd
SM
27982011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2799
2800 * window.h (Fwindow_frame): Declare.
2801
2b6148e4
PE
28022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2805 (SPARE_MEMORY): Always define.
2806 (LARGE_REQUEST): Remove.
2807 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2808
f230ecc9
MR
28092011-06-06 Martin Rudalics <rudalics@gmx.at>
2810
727e958e
MR
2811 * lisp.h: Move EXFUNS for Fframe_root_window,
2812 Fframe_first_window and Fset_frame_selected_window to window.h.
2813
2814 * window.h: Move EXFUNS for Fframe_root_window,
2815 Fframe_first_window and Fset_frame_selected_window here from
2816 lisp.h.
2817
2818 * frame.c (Fwindow_frame, Fframe_first_window)
2819 (Fframe_root_window, Fframe_selected_window)
2820 (Fset_frame_selected_window): Move to window.c.
2821 (Factive_minibuffer_window): Move to minibuf.c.
2822 (Fother_visible_frames_p): New function.
2823
2824 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2825
f230ecc9
MR
2826 * window.c (decode_window, decode_any_window): Move up in code.
2827 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2828 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2829 (Fwindow_buffer): Move up and rewrite doc-string.
2830 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2831 (Fwindow_prev): New functions.
727e958e
MR
2832 (Fwindow_frame): Move here from frame.c. Accept any window as
2833 argument.
2834 (Fframe_root_window, Fframe_first_window)
2835 (Fframe_selected_window): Move here from frame.c. Accept frame
2836 or arbitrary window as argument. Update doc-strings.
2837 (Fminibuffer_window): Move up in code.
2838 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2839 (Fset_frame_selected_window): Move here from frame.c.
2840 Marginal rewrite.
727e958e
MR
2841 (Fselected_window, select_window, Fselect_window): Move up in
2842 code. Minor doc-string fixes.
f230ecc9 2843
4d09bcf6
PE
28442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2845
2846 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2847 Do not assume that spare memory exists; that assumption is valid
2848 only if SYSTEM_MALLOC.
2849 (LARGE_REQUEST): New macro, so that the issue of large requests
2850 is separated from the issue of spare memory.
2851
810928a2
AS
28522011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2853
172418ad
AS
2854 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2855 format. (Bug#8806)
2856
43f862f7
AS
2857 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2858
810928a2
AS
2859 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2860 before statements.
2861
a059fe24
JD
28622011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2863
2864 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2865
2866 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2867
2868 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2869 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2870
989bf368
JB
28712011-06-05 Juanma Barranquero <lekktu@gmail.com>
2872
2873 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2874
4b80f674
CY
28752011-06-04 Chong Yidong <cyd@stupidchicken.com>
2876
2877 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2878 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2879 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2880 New error handlers.
4b80f674
CY
2881 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2882 Obey Vx_select_enable_clipboard_manager. Catch errors in
2883 x_clipboard_manager_save (Bug#8779).
2884 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2885 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2886
99a33b77 28872011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2888
2889 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2890
99a33b77 28912011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2892
2893 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2894 in the current matrix if keep_current_p is non-zero.
2895
8264569d
EZ
28962011-06-04 Eli Zaretskii <eliz@gnu.org>
2897
2898 * bidi.c (bidi_level_of_next_char): Fix last change.
2899
57f97249
EZ
29002011-06-03 Eli Zaretskii <eliz@gnu.org>
2901
fec2107c 2902 Support bidi reordering of text covered by display properties.
57f97249 2903
fec2107c
EZ
2904 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2905 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2906 (bidi_cache_search, bidi_cache_iterator_state)
2907 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2908 (bidi_level_of_next_char, bidi_move_to_visually_next):
2909 Support character positions inside a run of characters covered by a
fec2107c
EZ
2910 display string.
2911 (bidi_paragraph_init, bidi_resolve_explicit_1)
2912 (bidi_level_of_next_char): Call bidi_fetch_char and
2913 bidi_fetch_char_advance instead of FETCH_CHAR and
2914 FETCH_CHAR_ADVANCE.
2915 (bidi_init_it): Initialize new members.
2916 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2917 definitions.
2918 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2919 instead of using explicit *_CHAR codes.
d6d100dd
SM
2920 (bidi_resolve_explicit, bidi_resolve_weak):
2921 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2922 bidirectional text is supported only in multibyte buffers.
2923 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2924 it to initialize the frame_window_p member of struct bidi_it.
2925 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2926 (bidi_resolve_explicit, bidi_resolve_weak)
2927 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2928 bidi_it->nchars is non-positive.
2929 (bidi_level_of_next_char): Don't try to lookup the cache for the
2930 next/previous character if nothing is cached there yet, or if we
2931 were just reseat()'ed to a new position.
c40e2fb2 2932
0e14fe90
EZ
2933 * xdisp.c (set_cursor_from_row): Set start and stop points
2934 according to the row's direction when priming the loop that looks
2935 for the glyph on which to display cursor.
2936 (single_display_spec_intangible_p): Function deleted.
2937 (display_prop_intangible_p): Reimplement to call
2938 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2939 Accept 3 additional arguments needed by handle_display_spec.
2940 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2941 values: lists, `(when COND...)' forms, etc.
2942 (single_display_spec_string_p): Support property values that are
2943 lists with the argument STRING its top-level element.
2944 (display_prop_string_p): Fix the condition for processing a
2945 property that is a list to be consistent with handle_display_spec.
fec2107c 2946 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2947 last portion of handle_display_prop.
2948 (compute_display_string_pos): Accept additional argument
2949 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2950 value of a `display' property is a "replacing spec".
2951 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2952 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2953 the display property, but just return a value indicating whether
2954 the display property will replace the characters it covers.
2955 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2956 frame_window_p members of struct bidi_it.
d6d100dd
SM
2957 (compute_display_string_pos, compute_display_string_end):
2958 New functions.
fec2107c
EZ
2959 (push_it): Accept second argument POSITION, where pop_it should
2960 jump to continue iteration.
2961 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2962
fec2107c
EZ
2963 * keyboard.c (adjust_point_for_property): Adjust the call to
2964 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2965
2966 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2967 (bidi_init_it): Update prototypes.
2968 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2969 (compute_display_string_pos, compute_display_string_end):
2970 Declare prototypes.
fec2107c
EZ
2971 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2972 EMACS_INT.
fc6f18ce 2973
40087514 29742011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2975
57f53182
PE
2976 Malloc failure behavior now depends on size of allocation.
2977 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2978 * lisp.h: Change signatures accordingly.
2979 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2980 All callers changed. (Bug#8762)
2981
2982 * gnutls.c: Use Emacs's memory allocators.
2983 Without this change, the gnutls library would invoke malloc etc.
2984 directly, which causes problems on non-SYNC_INPUT hosts, and which
2985 runs afoul of improving memory_full behavior. (Bug#8761)
2986 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2987 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2988 xfree instead of the default malloc, realloc, free.
2989 (Fgnutls_boot): No need to check for memory allocation failure,
2990 since xmalloc does that for us.
2991
ac32cd99 2992 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2993 * category.c (hash_get_category_set):
2994 * ccl.c (ccl_driver):
2995 * charset.c (Fdefine_charset_internal):
2996 * charset.h (struct charset.hash_index):
2997 * composite.c (get_composition_id, gstring_lookup_cache)
2998 (composition_gstring_put_cache):
2999 * composite.h (struct composition.hash_index):
3000 * dispextern.h (struct image.hash):
3001 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3002 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3003 (hashfn_equal, hashfn_user_defined, make_hash_table)
3004 (maybe_resize_hash_table, hash_lookup, hash_put)
3005 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3006 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3007 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3008 * image.c (make_image, search_image_cache, lookup_image)
3009 (xpm_put_color_table_h):
3010 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3011 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3012 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3013 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3014 * alloc.c (allocate_vectorlike):
3015 Check for overflow in vector size calculations.
3016 * ccl.c (ccl_driver):
3017 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3018 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3019 need to be updated by these changes.
40087514
PE
3020 * fns.c (make_hash_table, maybe_resize_hash_table):
3021 Check for integer overflow with large hash tables.
0de4bb68
PE
3022 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3023 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3024 (SXHASH_REDUCE): New macro.
3025 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3026 Use it instead of discarding useful hash info with large hash values.
3027 (sxhash_float): New function.
3028 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3029 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3030 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3031 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3032 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3033 Adjust signatures to match updated version of code.
3034 (consing_since_gc): Now EMACS_INT, since a single hash table can
3035 use more than INT_MAX bytes.
3036
698d32e2
DN
30372011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3038
3039 Make it possible to build with GCC-4.6+ -O2 -flto.
3040
3041 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3042
fd6fa53f
SM
30432011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3044
3045 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3046 Call minibuffer-inactive-mode.
3047
864db017
JB
30482011-05-31 Juanma Barranquero <lekktu@gmail.com>
3049
3050 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3051 Update dependencies.
3052
2ad0baf4
DN
30532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3054
3055 * data.c (init_data): Remove code for UTS, this system is not
3056 supported anymore.
3057
4fcc2638
DN
30582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3059
3060 Don't force ./temacs to start in terminal mode.
3061
3062 * frame.c (make_initial_frame): Initialize faces in all cases, not
3063 only when CANNOT_DUMP is defined.
3064 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3065
c56e0fd5
DN
30662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3067
3068 * dispnew.c (add_window_display_history): Use const for the string
3069 pointer. Remove declaration, not needed.
3070
333d54da 30712011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3072
55d4c1b2 3073 Use 'inline', not 'INLINE'.
333d54da 3074 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3075 * alloc.c, fontset.c (INLINE): Remove.
3076 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3077 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3078 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3079 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3080 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3081
738db178
DN
30822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3083
3084 Make it possible to run ./temacs.
3085
3086 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3087 syms_of_callproc does the same thing. Remove test for
3088 "initialized", do it in the caller.
3089 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3090
620c53a6
SM
30912011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3092
3093 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3094 (read_minibuf): Use get_minibuffer.
3095 (syms_of_minibuf): Use DEFSYM.
3096 (Qmetadata): New var.
3097 * data.c (Qbuffer): Don't make it static.
3098 (syms_of_data): Use DEFSYM.
3099
e003a292
PE
31002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3101
3102 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3103 (CCL_CODE_MIN): New macro.
3104
ed008a6d
PE
31052011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3106
3687c2ef
PE
3107 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3108
ed008a6d
PE
3109 * eval.c (Qdebug): Now static.
3110 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3111 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3112 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3113
d66c4c7c
CY
31142011-05-29 Chong Yidong <cyd@stupidchicken.com>
3115
3116 * image.c: Various fixes to ImageMagick code comments.
3117 (Fimagemagick_types): Doc fix.
3118
5fbc2025
PE
31192011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3120
0196f88a
PE
3121 Minor fixes prompted by GCC 4.6.0 warnings.
3122
3123 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3124
5fbc2025
PE
3125 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3126 (x_clipboard_manager_save_all): Move extern decl to ...
3127 * xterm.h: ... here, so that it can be checked for consistency.
3128
1dd3c2d9
CY
31292011-05-29 Chong Yidong <cyd@stupidchicken.com>
3130
3131 * xselect.c (x_clipboard_manager_save_frame)
3132 (x_clipboard_manager_save_all): New functions.
3133 (Fx_clipboard_manager_save): Lisp function deleted.
3134
3135 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3136 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3137
3138 * xterm.h: Update prototype.
3139
5ba6571d
WX
31402011-05-28 William Xu <william.xwl@gmail.com>
3141
3142 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3143 exiting (Bug#8239).
3144
3eaff834
JM
31452011-05-28 Jim Meyering <meyering@redhat.com>
3146
e1900994 3147 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3148 * fns.c (to_uchar): Define.
3149 (crypto_hash_function): Use it to convert some newly-signed
3150 variables to unsigned, to avoid sign-extension bugs. For example,
3151 without this change, (md5 "truc") would evaluate to
3152 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3153 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3154 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3155
0f6990a7
PE
31562011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3157
3158 Integer overflow fixes.
c8a9ca5a 3159
08686060
PE
3160 * dbusbind.c: Serial number integer overflow fixes.
3161 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3162 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3163 to hold a serial number that is too large for a fixnum.
3164 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3165 Check for serial numbers out of range. Decode any serial number
59568bf0 3166 that was so large that it became a float. (Bug#8722)
08686060 3167
2d1fc3c7
PE
3168 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3169 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3170 Use XFASTINT rather than XUINT when numbers are nonnegative.
3171 (xd_append_arg, Fdbus_method_return_internal):
3172 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3173 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3174 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3175 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3176 (Bug#8722)
2d1fc3c7 3177
c8a9ca5a
PE
3178 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3179
519e1d69
PE
3180 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3181
30569699
PE
3182 ccl: add integer overflow checks
3183 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3184 (IN_INT_RANGE): New macros.
3185 (ccl_driver): Use them to check for integer overflow when
3186 decoding a CCL program. Many of the new checks are whether XINT (x)
3187 fits in int; it doesn't always, on 64-bit hosts. The new version
3188 doesn't catch all possible integer overflows, but it's an
847044ea 3189 improvement. (Bug#8719)
30569699 3190
c11285dc
PE
3191 * alloc.c (make_event_array): Use XINT, not XUINT.
3192 There's no need for unsigned here.
3193
fdccd48e
PE
3194 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3195 This follows up to the 2011-05-06 change that substituted uintptr_t
3196 for EMACS_INT. This case wasn't caught back then.
3197
37910ab2
PE
3198 Rework Fformat to avoid integer overflow issues.
3199 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3200 now (part of C89). Include <verify.h>.
3201 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3202 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3203 (Fformat): Avoid the prepass trying to compute sizes; it was only
3204 approximate and thus did not catch overflow reliably. Instead, walk
3205 through the format just once, formatting and computing sizes as we go,
3206 checking for integer overflow at every step, and allocating a larger
3207 buffer as needed. Keep track separately whether the format is
3208 multibyte. Keep only the most-recently calculated precision, rather
3209 than them all. Record whether each argument has been converted to
3210 string. Use EMACS_INT, not int, for byte and char and arg counts.
3211 Support field widths and precisions larger than INT_MAX. Avoid
3212 sprintf's undefined behavior with conversion specifications such as %#d
3213 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3214 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3215 formatting out-of-range floating point numbers with int
9173deec 3216 formats. (Bug#8668)
37910ab2 3217
2e6578fb
PE
3218 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3219
0ae6bdee
PE
3220 * data.c: Avoid integer truncation in expressions involving floats.
3221 * data.c: Include <intprops.h>.
3222 (arith_driver): When there's an integer overflow in an expression
3223 involving floating point, convert the integers to floating point
3224 so that the resulting value does not suffer from catastrophic
3225 integer truncation. For example, on a 64-bit host (* 4
3226 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3227 Do not rely on undefined behavior after integer overflow.
3228
de883a70
PE
3229 merge count_size_as_multibyte, parse_str_to_multibyte
3230 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3231 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3232 Check for integer overflow.
3233 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3234 since it's now a duplicate of the other. This is more of
3235 a character than a buffer op, so better that it's in character.c.
3236 * fns.c, print.c: Adjust to above changes.
3237
2ff916cb
PE
32382011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3239
3240 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3241
f1b54466
PE
32422011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3243
fb1ac845
PE
3244 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3245 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3246 (x_clipboard_manager_save): Now static.
3247 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3248
f1b54466
PE
3249 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3250 (crypto_hash_function): Now static.
3251 Fix pointer signedness problems. Avoid unnecessary initializations.
3252
a9f737ee
CY
32532011-05-27 Chong Yidong <cyd@stupidchicken.com>
3254
3255 * termhooks.h (Vselection_alist): Make it terminal-local.
3256
3257 * terminal.c (create_terminal): Initialize it.
3258
3259 * xselect.c: Support for clipboard managers.
3260 (Vselection_alist): Move to termhooks.h as terminal-local var.
3261 (LOCAL_SELECTION): New macro.
3262 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3263 (symbol_to_x_atom): Remove gratuitous arg.
3264 (x_handle_selection_request, lisp_data_to_selection_data)
3265 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3266 (x_own_selection, x_get_local_selection, x_convert_selection):
3267 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3268 (some_frame_on_display): Delete unused function.
3269 (Fx_own_selection_internal, Fx_get_selection_internal)
3270 (Fx_disown_selection_internal, Fx_selection_owner_p)
3271 (Fx_selection_exists_p): New optional frame arg.
3272 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3273 (x_handle_selection_clear): Don't treat other terminals with the
3274 same keyboard specially. Use the terminal-local Vselection_alist.
3275 (x_clear_frame_selections): Use Frun_hook_with_args.
3276
3277 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3278
3279 * xterm.h: Add support for those atoms.
3280
e067f0c1
CY
32812011-05-26 Chong Yidong <cyd@stupidchicken.com>
3282
3283 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3284 (converted_selections, conversion_fail_tag): New global variables.
3285 (x_selection_request_lisp_error): Free the above.
3286 (x_get_local_selection): Remove unnecessary code.
3287 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3288 of converted selections stored in converted_selections.
3289 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3290 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3291 (x_convert_selection): New function.
3292 (x_handle_selection_event): Simplify.
3293 (x_get_foreign_selection): Don't ignore incoming requests while
3294 waiting for an answer; this will fail when we implement
3295 SAVE_TARGETS, and seems unnecessary anyway.
3296 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3297 (Vx_sent_selection_functions): Doc fix.
3298
0f4aebc0
LL
32992011-05-26 Leo Liu <sdl.web@gmail.com>
3300
3301 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3302
e61124cd
YM
33032011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3304
3305 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3306
3307 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3308 for fringe update if it has periodic bitmap.
ac389d0c 3309 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3310 and fringe_bitmap_periodic_p.
3311
3312 * fringe.c (get_fringe_bitmap_data): New function.
3313 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3314 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3315 row. Mark glyph row for fringe update if periodicity changed.
3316
3317 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3318 for fringe update unless it has periodic bitmap.
3319
f16d9837
KH
33202011-05-25 Kenichi Handa <handa@m17n.org>
3321
3322 * xdisp.c (get_next_display_element): Set correct it->face_id for
3323 a static composition.
3324
e1b90ef6
LL
33252011-05-24 Leo Liu <sdl.web@gmail.com>
3326
3327 * deps.mk (fns.o):
3328 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3329
3330 * fns.c (crypto_hash_function, Fsha1): New function.
3331 (Fmd5): Use crypto_hash_function.
3332 (syms_of_fns): Add Ssha1.
3333
7400048f
PE
33342011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 * gnutls.c: Remove unused macros.
3337 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3338 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3339 Remove macros that are defined and never used.
3340 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3341
abb71cf4
CY
33422011-05-22 Chong Yidong <cyd@stupidchicken.com>
3343
3344 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3345 (Fx_get_selection_internal): Minor cleanup.
3346 (Fx_own_selection_internal): Rename arguments for consistency with
3347 select.el.
3348
6307db39
PE
33492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3352
f3d4e0a4
CY
33532011-05-22 Chong Yidong <cyd@stupidchicken.com>
3354
3355 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3356
4d8ade89
YM
33572011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3358
3359 * dispnew.c (scrolling_window): Don't exclude the case that the
3360 last enabled row in the desired matrix touches the bottom boundary.
3361
32078c8d
GM
33622011-05-21 Glenn Morris <rgm@gnu.org>
3363
3364 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3365 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3366 and add some more files.
32078c8d 3367
7285dc67
EZ
33682011-05-20 Eli Zaretskii <eliz@gnu.org>
3369
3370 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3371 report_file_error introduced by the change from 2011-05-07.
3372
89d1bd22
PE
33732011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3374
3375 * systime.h (Time): Define only if emacs is defined.
3376 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3377 where the include path doesn't have X11/X.h by default. See
3378 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3379
e23640bb 33802011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3381
3382 * composite.c (find_automatic_composition): Fix previous change.
3383
b9704ad9
GM
33842011-05-20 Glenn Morris <rgm@gnu.org>
3385
3386 * lisp.mk: New file, split from Makefile.in.
3387 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3388 (shortlisp): Remove.
3389 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3390
4a720484
GM
33912011-05-19 Glenn Morris <rgm@gnu.org>
3392
3393 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3394 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3395 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3396 (lisp): Set the order to that of loadup.el.
3397 (shortlisp): Make it a copy of $lisp.
3398 (SOME_MACHINE_LISP): Remove.
3399 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3400 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3401
a28d4396
KH
34022011-05-18 Kenichi Handa <handa@m17n.org>
3403
3404 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3405 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3406 (find_automatic_composition): Mostly rewrite for efficiency.
3407
a2b1fa8e
JB
34082011-05-18 Juanma Barranquero <lekktu@gmail.com>
3409
3410 * makefile.w32-in: Update dependencies.
3411
8e1f5610
CS
34122011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3413
3414 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3415 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3416
7025ee00 34172011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3418
cdfa6eab
PE
3419 Fix some integer overflow issues, such as string length overflow.
3420
06d6db33
PE
3421 * insdel.c (count_size_as_multibyte): Check for string overflow.
3422
2b4560a8
PE
3423 * character.c (lisp_string_width): Check for string overflow.
3424 Use EMACS_INT, not int, for string indexes and lengths; in
3425 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3426 the resulting string length overflows an EMACS_INT; instead,
3427 report a string overflow if no precision given. When checking for
3428 precision exhaustion, use a check that cannot possibly have
3429 integer overflow. (Bug#8675)
3430 * character.h (lisp_string_width): Adjust to new signature.
3431
cb93f9be
PE
3432 * alloc.c (string_overflow): New function.
3433 (Fmake_string): Use it. This doesn't change behavior, but saves
3434 a few bytes and will simplify future changes.
3435 * character.c (string_escape_byte8): Likewise.
3436 * lisp.h (string_overflow): New decl.
3437
1a1f3366
PE
3438 Fixups, following up to the user-interface timestamp change.
3439 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3440 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3441 * msdos.c (mouse_get_pos): Likewise.
3442 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3443 * w32gui.h (Time): Define by including "systime.h" rather than by
3444 declaring it ourselves. (Bug#8664)
3445
d4e3e4d3
PE
3446 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3447 * image.c (clear_image_cache): Likewise.
3448
f6a24d19
PE
3449 * term.c (term_mouse_position): Don't assume time_t wraparound.
3450
08dc5ae6
PE
3451 Be more systematic about user-interface timestamps.
3452 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3453 and sometimes 'EMACS_UINT', to represent these timestamps.
3454 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3455 This makes the code easier to follow, and makes it easier to catch
3456 integer overflow bugs such as Bug#8664.
3457 * frame.c (Fmouse_position, Fmouse_pixel_position):
3458 Use Time, not unsigned long, for user-interface timestamps.
3459 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3460 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3461 * keyboard.h (last_event_timestamp): Likewise.
3462 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3463 * menu.h (xmenu_show): Likewise.
3464 * term.c (term_mouse_position): Likewise.
3465 * termhooks.h (struct input_event.timestamp): Likewise.
3466 (struct terminal.mouse_position_hook): Likewise.
3467 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3468 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3469 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3470 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3471 what it was before.
3472 * menu.h, termhooks.h: Include "systime.h", for Time.
3473
8e55734a
PE
3474 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3475 Don't assume that the difference between two unsigned long values
3476 can fit into an integer. At this point, we know button_down_time
3477 <= event->timestamp, so the difference must be nonnegative, so
3478 there's no need to cast the result if double-click-time is
3479 nonnegative, as it should be; check that it's nonnegative, just in
3480 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3481 apart (about 25 days). (Bug#8664)
8e55734a 3482
841f1b75 3483 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3484 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3485
3e26f69c
PE
3486 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3487 that always fit in int. Use a sentinel instead of a counter, to
3488 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3489 * frame.h (struct frame): Use int for menu_bar_items_used
3490 instead of EMACS_INT, since it always fits in int.
3e26f69c 3491
5cc152c0
PE
3492 * menu.c (grow_menu_items): Check for int overflow.
3493
d89eb65e
PE
3494 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3495
5235bd3e
PE
3496 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3497 Before, the code was not consistent. These values cannot exceed
3498 2**31 - 1 so there's no need to make them unsigned.
3499 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3500 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3501 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3502 as modifiers.
3503 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3504
bc827e23
PE
3505 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3506 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3507 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3508 presumably because the widths might not match.
3509
78eb494e
PE
3510 * window.c (size_window): Avoid needless test at loop start.
3511
04f2d78b
CB
35122011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3513
3514 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3515
d2fc7e3d 35162011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3517
3518 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3519
d2fc7e3d 35202011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3521
3522 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3523 `width' to `bar_area_x' and `bar_area_width', respectively.
3524 (x_scroll_run): Take account of fringe background extension.
3525
04f2d78b
CB
3526 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3527 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3528 `bar_area_width', respectively.
3529 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3530 background extension.
3531
79b70037
GM
35322011-05-10 Jim Meyering <meyering@redhat.com>
3533
3534 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3535
2f142cc5
JB
35362011-05-10 Juanma Barranquero <lekktu@gmail.com>
3537
3538 * image.c (Finit_image_library): Return t for built-in image types,
3539 like pbm and xbm. (Bug#8640)
3540
57679c86
AS
35412011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3542
3543 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3544
888c9e86
EZ
35452011-05-07 Eli Zaretskii <eliz@gnu.org>
3546
b0512a1d
EZ
3547 * w32console.c (Fset_screen_color): Doc fix.
3548 (Fget_screen_color): New function.
3549 (syms_of_ntterm): Defsubr it.
3550
7285dc67
EZ
3551 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3552 unlink the temporary file if Fcall_process didn't create it in the
3553 first place.
3554 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3555 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3556 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3557 cue to call_process_cleanup not to close that handle.
3558
4d3fcc8e
BK
35592011-05-07 Ben Key <bkey76@gmail.com>
3560
3561 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3562 one of two shell specific rules, either bootstrap-temacs-CMD or
3563 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3564 to the previous implementation of the bootstrap-temacs rule.
3565 The bootstrap-temacs-CMD rule is similar to the previous
3566 implementation of the bootstrap-temacs rule except that it
3567 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3568 variable.
3569
3570 These changes, along with some changes to nt/configure.bat,
3571 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3572 earlier fix to add support for --cflags and --ldflags options
3573 that include quotes so that it works whether make uses cmd or
3574 sh as the shell.
3575
b4289b64
MA
35762011-05-06 Michael Albinus <michael.albinus@gmx.de>
3577
3578 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3579 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3580 is a constant.
3581 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3582 a string. Handle both cases.
3583 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3584 (Fdbus_register_method): Use Qinvalid_function.
3585
af4c0e28
JB
35862011-05-06 Juanma Barranquero <lekktu@gmail.com>
3587
3588 * makefile.w32-in: Update dependencies.
3589 (LISP_H): Add inttypes.h and stdin.h.
3590 (PROCESS_H): Add unistd.h.
3591
c51453d9
EZ
35922011-05-06 Eli Zaretskii <eliz@gnu.org>
3593
3594 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3595 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3596
8ff0ac3c 35972011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3598
4c4b566b
PE
3599 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3600
aab2b9b5
PE
3601 * term.c (vfatal): Remove stray call to va_end.
3602 It's not needed and the C Standard doesn't allow it here anyway.
3603
c378da0b
PE
3604 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3605 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3606
288b08c7
PE
3607 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3608 bytes.
3609
e3601888
PE
3610 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3611
db6c0e74
PE
3612 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3613
dd5963ea
PE
3614 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3615
88c9450f
PE
3616 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3617
2f9442b8
PE
3618 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3619
c032b5f8
PE
3620 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3621 * charset.c (Fdefine_charset_internal): Don't initialize
3622 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3623 32-bit int (Bug#8600).
a108c10b
PE
3624
3625 * lread.c (read_integer): Be more consistent with string-to-number.
3626 Use string_to_number to do the actual conversion; this avoids
3627 rounding errors and fixes some other screwups. Without this fix,
3628 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3629 (digit_to_number): Move earlier, for benefit of read_integer.
3630 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3631 not a digit in any supported base. (Bug#8602)
a108c10b 3632
ad5f9eea
PE
3633 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3634
aec1708a
PE
3635 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3636 to match comment at start of function. This also removes a
3637 GCC warning about overflow in a 32+64-bit port.
3638
47be4ab5
PE
3639 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3640
371cac43
PE
3641 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3642 Reported by Stefan Monnier in
3643 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3644 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3645 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3646
d01a7826
PE
3647 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3648 (EMACS_UINTPTR): Likewise, with uintptr_t.
3649
7fd47d5c
PE
3650 * lisp.h: Prefer 64-bit EMACS_INT if available.
3651 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3652 on 32-bit hosts that have 64-bit int, so that they can access
3653 large files.
122b0c86
PE
3654 However, temporarily disable this change unless the temporary
3655 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3656
8727937b
PE
3657 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3658
8ac068ac
PE
3659 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3660 This removes an assumption that EMACS_INT and long are the same
3661 width as pointers. The assumption is true for Emacs porting targets
3662 now, but we want to make other targets possible.
3663 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3664 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3665 In the rest of the code, change types of integers that hold casted
3666 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3667 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3668 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3669 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3670 No need to cast type when ORing.
3671 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3672 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3673 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3674 assume EMACS_INT is the same width as char *.
3675 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3676 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3677 Remove no-longer-needed casts.
3678 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3679 (xg_tool_bar_help_callback, xg_make_tool_item):
3680 Use EMACS_INTPTR to hold an integer
3681 that will be cast to void *; this can avoid a GCC warning
3682 if EMACS_INT is not the same width as void *.
3683 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3684 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3685 (current_message_1, set_message_1):
3686 Use a local to convert to proper width without a cast.
3687 * xmenu.c (dialog_selection_callback): Likewise.
3688
ede49d71
PE
3689 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3690 Also, don't assume VALBITS / RAND_BITS is less than 5,
3691 and don't rely on undefined behavior when shifting a 1 left into
3692 the sign bit.
3693 * lisp.h (get_random): Change signature to match.
3694
2f30ecd0
PE
3695 * lread.c (hash_string): Use size_t, not int, for hash computation.
3696 Normally we prefer signed values; but hashing is special, because
3697 it's better to use unsigned division on hash table sizes so that
3698 the remainder is nonnegative. Also, size_t is the natural width
3699 for hashing into memory. The previous code used 'int', which doesn't
3700 retain enough info to hash well into very large tables.
3701 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3702
2a866e7b
PE
3703 * dbusbind.c: Don't possibly lose pointer info when converting.
3704 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3705 Use XPNTR rather than XHASH, so that the high-order bits of
3706 the pointer aren't lost when converting through void *.
3707
51639eac
PE
3708 * eval.c (Fautoload): Don't double-shift a pointer.
3709
92394119
PE
3710 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3711
dbdb9a7c
JB
37122011-05-06 Juanma Barranquero <lekktu@gmail.com>
3713
3714 * gnutls.c (DEF_GNUTLS_FN):
3715 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3716
db7a0b4f
AS
37172011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3718
3719 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3720 marker. (Bug#8610)
3721
f7ff1b0f 37222011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3723
3724 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3725 New version that can reserve upto 2GB of heap space.
3726
f7ff1b0f 37272011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3728
3729 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3730
639c109b
TZ
37312011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3732
3733 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3734 `gnutls_certificate_set_x509_key_file'.
3735
d2127135
JB
37362011-05-05 Juanma Barranquero <lekktu@gmail.com>
3737
3738 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3739 Update dependencies.
3740
e968f4f3
JB
37412011-05-04 Juanma Barranquero <lekktu@gmail.com>
3742
3743 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3744 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3745 Remove unused parameter `fildes'.
3746 * process.c (read_process_output, send_process): Don't pass it.
3747
84d358f0
JB
37482011-05-04 Juanma Barranquero <lekktu@gmail.com>
3749
3750 Fix previous change: the library cache is defined in w32.c.
3751 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3752 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3753
0898ca10
JB
37542011-05-04 Juanma Barranquero <lekktu@gmail.com>
3755
3756 Implement dynamic loading of GnuTLS on Windows.
3757
3758 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3759 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3760 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3761 Declare.
3762
3763 * gnutls.c (Qgnutls_dll): Define.
3764 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3765 (gnutls_*): Declare function pointers.
3766 (init_gnutls_functions): New function to initialize function pointers.
3767 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3768 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3769 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3770 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3771 (emacs_gnutls_write, emacs_gnutls_read)
3772 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3773 (Fgnutls_available_p): New function.
3774 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3775 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3776 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3777
3778 * image.c: Include w32.h.
3779 (Vimage_type_cache): Delete.
3780 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3781 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3782 (w32_delayed_load): Move to w32.c.
3783
3784 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3785
3786 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3787 (w32_delayed_load): Move from image.c. When loading a library, record
3788 its filename in the :loaded-from property of the library id.
3789 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3790 Initialize and staticpro them.
3791 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3792
3793 * process.c: Include lisp.h before w32.h, not after.
3794 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3795 instead of gnutls_record_check_pending.
3796
3797 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3798
ff4de4aa
TZ
37992011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3800
3801 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3802 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3803 as passed in.
3804
abe95abb
JD
38052011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3806
3807 * xterm.c (x_set_frame_alpha): Do not set property on anything
3808 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3809
e16e55d4
JB
38102011-05-02 Juanma Barranquero <lekktu@gmail.com>
3811
3812 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3813
bafcf6a5
JB
38142011-05-02 Juanma Barranquero <lekktu@gmail.com>
3815
3816 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3817 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3818 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3819 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3820 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3821 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3822 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3823 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3824 (Qgnutls_bootprop_callbacks_verify): Make static.
3825
e7a6747f
AS
38262011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3827
19ed11ba
AS
3828 * callproc.c: Indentation fixup.
3829
e7a6747f 3830 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3831 (wait_for_termination, interruptible_wait_for_termination):
3832 Move after wait_for_termination_1.
e7a6747f 3833
1ef14cb4
LMI
38342011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3835
3836 * sysdep.c (interruptible_wait_for_termination): New function
3837 which is like wait_for_termination, but allows keyboard
3838 interruptions.
3839
3840 * callproc.c (Fcall_process): Add (:file "file") as an option for
3841 the STDOUT buffer.
3842 (Fcall_process_region): Ditto.
3843
330d880c
EZ
38442011-04-30 Eli Zaretskii <eliz@gnu.org>
3845
8db90b73
EZ
3846 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3847 rather than `XVECTOR (FOO)->size'.
3848
330d880c
EZ
3849 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3850 inttypes.h, as a gnulib replacement is used if it not available in
3851 system headers.
3852
15cbd324
EZ
38532011-04-21 Eli Zaretskii <eliz@gnu.org>
3854
3855 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3856 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3857 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3858
3859 * coding.c (coding_alloc_by_realloc): Error out if destination
3860 will grow beyond MOST_POSITIVE_FIXNUM.
3861 (decode_coding_emacs_mule): Abort if there isn't enough place in
3862 charbuf for the composition carryover bytes. Reserve an extra
3863 space for up to 2 characters produced in a loop.
3864 (decode_coding_iso_2022): Abort if there isn't enough place in
3865 charbuf for the composition carryover bytes.
3866
38672011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3868
ae940cca
EZ
3869 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3870 aborting when %lld or %lll format is passed.
3871 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3872 %llo or %llx format is passed. (Bug#8545)
3873
03ab8921
EZ
3874 * window.c (window_scroll_line_based): Use a marker instead of
3875 simple variables to record original value of point. (Bug#7952)
3876
afda1437
EZ
3877 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3878 produced by %s or %c overflows available buffer space. (Bug#8545)
3879
f76dee0c
PE
38802011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3881
3882 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3883 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3884
fdc5744d
JB
38852011-04-28 Juanma Barranquero <lekktu@gmail.com>
3886
3887 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3888
638f053a
JB
38892011-04-28 Juanma Barranquero <lekktu@gmail.com>
3890
3891 * keyboard.c (Qdelayed_warnings_hook): Define.
3892 (command_loop_1): Run `delayed-warnings-hook'
3893 if Vdelayed_warnings_list is non-nil.
3894 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3895 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3896
d178f871
EZ
38972011-04-28 Eli Zaretskii <eliz@gnu.org>
3898
3899 * doprnt.c (doprnt): Don't return value smaller than the buffer
3900 size if the message was truncated. (Bug#8545).
3901
b124fd93
JB
39022011-04-28 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3905 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3906
e810457d
PE
39072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3910
ea51cceb
JB
39112011-04-27 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * makefile.w32-in: Update dependencies.
3914
94dcfacf
EZ
39152011-04-27 Eli Zaretskii <eliz@gnu.org>
3916
3917 Improve `doprnt' and its usage. (Bug#8545)
3918 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3919 `format_end'. Remove support for %l as a conversion specifier.
3920 Don't use xrealloc. Improve diagnostics when the %l size modifier
3921 is used. Update the commentary.
3922
3923 * eval.c (verror): Simplify calculation of size_t.
3924
3925 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3926 messages.
3927
f61f41d7
PE
39282011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3929
3930 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3931 change.
3932
96fb4434
PE
39332011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3936 This makes this file independent of the recent pseudovector change.
3937
671875da 39382011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3939
69e9b5a3
PE
3940 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3941
b5f869a7 3942 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3943 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3944 Remove unused local.
c8926152 3945 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3946
841a1577 3947 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3948 GCC 4.6.0 optimizes based on type-based alias analysis.
3949 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3950 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3951 != &v->size, and therefore "v->size = 1; b->size = 2; return
3952 v->size;" must therefore return 1. This assumption is incorrect
3953 for Emacs, since it type-puns struct Lisp_Vector * with many other
3954 types. To fix this problem, this patch adds a new type struct
f904488f 3955 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3956 and pseudovectors, and helps optimizing compilers not get fooled
3957 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3958 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3959 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3960 the size member.
eab3844f
PE
3961 (XSETPVECTYPE): Rewrite in terms of new macro.
3962 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3963 This is a bit clearer, and further avoids the possibility of
3964 undesirable aliasing.
3965 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3966 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3967 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3968 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3969 (ASIZE): Now uses header.size rather than size.
3970 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3971 to avoid the hassle of writing XVECTOR (foo)->header.size.
3972 (struct vectorlike_header): New type.
eab3844f
PE
3973 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3974 object, to help avoid aliasing.
3975 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3976 (SUBRP): Likewise, since Lisp_Subr is a special case.
3977 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3978 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3979 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3980 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3981 changed to be "header.size" and "header.next".
3982 * buffer.h (struct buffer): Likewise.
3983 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3984 * frame.h (struct frame): Likewise.
3985 * process.h (struct Lisp_Process): Likewise.
3986 * termhooks.h (struct terminal): Likewise.
3987 * window.c (struct save_window_data, struct saved_window): Likewise.
3988 * window.h (struct window): Likewise.
3989 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3990 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3991 * buffer.c (init_buffer_once): Likewise.
3992 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3993 special case.
3994 * process.c (Fformat_network_address): Use local var for size,
3995 for brevity.
3996
0df1eac5
PE
3997 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3998
847ab9d1 3999 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4000 * data.c (atof): Remove decl; no longer used or needed.
4001 (digit_to_number): Move to lread.c.
4002 (Fstring_to_number): Use new string_to_number function, to be
4003 consistent with how the Lisp reader treats infinities and NaNs.
4004 Do not assume that floating-point numbers represent EMACS_INT
4005 without losing information; this is not true on most 64-bit hosts.
4006 Avoid double-rounding errors, by insisting on integers when
4007 parsing non-base-10 numbers, as the documentation specifies.
4008 * lisp.h (string_to_number): New decl, replacing ...
4009 (isfloat_string): Remove.
bc0a5c13 4010 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4011 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4012 appears to have been a coding error. Similarly, do not accept
4013 strings like +-1e0 as floating point numbers. Do not report
4014 overflow for integer overflows unless the base is not 10 which
4015 means we have no simple and reliable way to continue.
4016 Break out the floating-point parsing into a new
4017 function string_to_number, so that Fstring_to_number parses
4018 floating point numbers consistently with the Lisp reader.
04f2d78b 4019 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4020 (E_CHAR, EXP_INT): Remove, replacing with ...
4021 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4022 (string_to_number): New function, replacing isfloat_string.
4023 This function checks for valid syntax and produces the resulting
4024 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4025 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4026 so that overflow for non-base-10 numbers is reported only when
4027 there's no portable and simple way to convert to floating point.
452f4150 4028
67769ffc
PE
4029 * textprop.c (set_text_properties_1): Rewrite for clarity,
4030 and to avoid GCC warning about integer overflow.
4031
c20db43f
PE
4032 * intervals.h (struct interval): Use EMACS_INT for members
4033 where EMACS_UINT might cause problems. See
4034 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4035 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4036 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4037 All uses changed.
37aa2f85
PE
4038 (offset_intervals): Tell GCC not to worry about length overflow
4039 when negating a negative length.
c20db43f 4040
2538aa2f
PE
4041 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4042 (overrun_check_free): Likewise.
4043
f2d3008d
PE
4044 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4045 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4046 word size.
4047
ec8df744
PE
4048 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4049 (gnutls_make_error): Rename local to avoid shadowing.
4050 (gnutls_emacs_global_deinit): ifdef out; not used.
4051 (Fgnutls_boot): Use const for pointer to readonly storage.
4052 Comment out unused local. Fix pointer signedness problems.
4053
640ee02d
PE
4054 * lread.c (openp): Don't stuff size_t into an 'int'.
4055 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4056 about possible signed overflow.
4057
6048fb2a
PE
4058 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4059 (GDK_KEY_g): Don't define if already defined.
4060 (xg_prepare_tooltip): Avoid pointer signedness problem.
4061 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4062
fa3c87e1
PE
4063 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4064 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4065
2172544b
PE
4066 * xfns.c (Fx_window_property): Simplify a bit,
4067 to make a bit faster and to avoid GCC 4.6.0 warning.
4068 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4069
9b821a21
PE
4070 * fns.c (internal_equal): Don't assume size_t fits in int.
4071
3c616cfa
PE
4072 * alloc.c (compact_small_strings): Tighten assertion a little.
4073
c2982e87
PE
4074 Replace pEd with more-general pI, and fix some printf arg casts.
4075 * lisp.h (pI): New macro, generalizing old pEd macro to other
4076 conversion specifiers. For example, use "...%"pI"d..." rather
4077 than "...%"pEd"...".
4078 (pEd): Remove. All uses replaced with similar uses of pI.
4079 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4080 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4081 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4082 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4083 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4084 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4085 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4086 64-bit hosts.
4087 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4088 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4089 * print.c (safe_debug_print, print_object): Likewise.
4090 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4091 to int.
6f04d126
PE
4092 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4093 avoiding the 0 flag, which is not portable.
c2982e87
PE
4094 * process.c (Fmake_network_process): Use pI to avoid cast.
4095 * region-cache.c (pp_cache): Likewise.
4096 * xdisp.c (decode_mode_spec): Likewise.
4097 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4098 behavior on 64-bit hosts with printf arg.
6f04d126 4099 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4100 (x_stop_queuing_selection_requests): Likewise.
4101 (x_get_window_property): Don't truncate byte count to an 'int'
4102 when tracing.
0b432f21 4103
5e073ec7
PE
4104 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4105 here, since it parses constructs like leading '-' and spaces,
4106 which are not wanted; and it overflows with large numbers.
4107 Instead, simply match F[0-9]+, which is what is wanted anyway.
4108
36372bf9
PE
4109 * alloc.c: Remove unportable assumptions about struct layout.
4110 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4111 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4112 (allocate_vectorlike, make_pure_vector): Use the new macros,
4113 plus offsetof, to remove unportable assumptions about struct layout.
4114 These assumptions hold on all porting targets that I know of, but
4115 they are not guaranteed, they're easy to remove, and removing them
4116 makes further changes easier.
4117
0b432f21
PE
4118 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4119 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4120 (string_overrun_cookie): Now const. Use initializers that
4121 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4122 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4123 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4124 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4125 multiple of sizeof (EMACS_INT); it need not be, if
4126 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4127 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4128
895009e1
JB
41292011-04-26 Juanma Barranquero <lekktu@gmail.com>
4130
4131 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4132
6a7a1b0b
TZ
41332011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4134
4135 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4136 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4137 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4138
841a1577 41392011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4140
4141 * lisp.h (Qdebug): List symbol.
895009e1 4142 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4143 * keyboard.c (debug-on-event): New variable.
4144 (handle_user_signal): Break into debugger when debug-on-event
4145 matches the current signal symbol.
4146
f2d3ba6f
DN
41472011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4148
4149 * alloc.c (check_sblock, check_string_bytes)
4150 (check_string_free_list): Convert to standard C.
4151
42ce4c63
TZ
41522011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4153
4154 * w32.c (emacs_gnutls_push): Fix typo.
4155
825cd63c
EZ
41562011-04-25 Eli Zaretskii <eliz@gnu.org>
4157
fb11d64d
EZ
4158 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4159 "cast to pointer from integer of different size".
4160
825cd63c
EZ
4161 Improve doprnt and its use in verror. (Bug#8545)
4162 * doprnt.c (doprnt): Document the set of format control sequences
4163 supported by the function. Use SAFE_ALLOCA instead of always
4164 using `alloca'.
4165
4166 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4167 is one byte too soon. Don't use xrealloc; instead xfree and
4168 xmalloc anew.
4169
e061a11b
TZ
41702011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4171
4172 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4173 callbacks stage.
4174
4175 * gnutls.c: Renamed global_initialized to
4176 gnutls_global_initialized. Added internals for the
4177 :verify-hostname-error, :verify-error, and :verify-flags
4178 parameters of `gnutls-boot' and documented those parameters in the
4179 docstring. Start callback support.
9173deec
JB
4180 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4181 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4182 on error. Return error code.
e061a11b
TZ
4183 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4184 (emacs_gnutls_read): Likewise.
4185 (Fgnutls_boot): Return handshake error code.
4186 (emacs_gnutls_handle_error): New function.
4187 (wsaerror_to_errno): Likewise.
4188
4189 * w32.h (emacs_gnutls_pull): Add prototype.
4190 (emacs_gnutls_push): Likewise.
4191
4192 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4193 (emacs_gnutls_push): Likewise.
4194
41952011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4196
4197 * process.c (wait_reading_process_output): Check if GnuTLS
4198 buffered some data internally if no FDs are set for TLS
4199 connections.
4200
4201 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4202 (LIBS): Link to USER_LIBS.
4203 ($(BLD)/gnutls.$(0)): New target.
4204
fa6996bc
EZ
42052011-04-24 Eli Zaretskii <eliz@gnu.org>
4206
eb35682e
EZ
4207 * xdisp.c (handle_single_display_spec): Rename the
4208 display_replaced_before_p argument into display_replaced_p, to
4209 make it consistent with the commentary. Fix typos in the
4210 commentary.
4211
e2ad650c
EZ
4212 * textprop.c (syms_of_textprop): Remove dead code.
4213 (copy_text_properties): Delete obsolete commentary about an
4214 interface that was deleted long ago. Fix typos in the description
4215 of arguments.
4216
1b2de274
EZ
4217 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4218 to changes in oldXMenu/XMenu.h from 2011-04-16.
4219 <menu_help_message, prev_menu_help_message>: Constify.
4220 (IT_menu_make_room): menu->help_text is now `const char **';
4221 adjust.
4222
4223 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4224 to changes in oldXMenu/XMenu.h from 2011-04-16.
4225 (struct XMenu): Declare `help_text' `const char **'.
4226
4227 * xfaces.c <Qunspecified>: Make extern again.
4228
4229 * syntax.c: Include sys/types.h before including regex.h, as
4230 required by Posix.
4231
762b15be
EZ
4232 * doc.c (get_doc_string): Improve the format passed to `error'.
4233
4234 * doprnt.c (doprnt): Improve commentary.
4235
4236 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4237
4238 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4239 them with etags.
4240
f1052e5d
EZ
4241 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4242 changes in globals.h immediately force recompilation.
762b15be
EZ
4243 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4244 $(CURDIR)/s/ms-w32.h.
4245 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4246
fa6996bc
EZ
4247 * character.c (Fchar_direction): Function deleted.
4248 (syms_of_character): Don't defsubr it.
4249 <char-direction-table>: Deleted.
4250
e6c3da20
EZ
42512011-04-23 Eli Zaretskii <eliz@gnu.org>
4252
4253 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4254 * doprnt.c: Include limits.h.
4255 (SIZE_MAX): New macro.
04f2d78b
CB
4256 (doprnt): Return a size_t value. 2nd arg is now size_t.
4257 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4258 Improve overflow protection. Support `l' modifier for integer
4259 conversions. Support %l conversion. Don't assume an EMACS_INT
4260 argument for integer conversions and for %c.
4261
4262 * lisp.h (doprnt): Restore prototype.
4263
4264 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4265 $(SRC)/character.h.
4266
4267 * Makefile.in (base_obj): Add back doprnt.o.
4268
4269 * deps.mk (doprnt.o): Add back prerequisites.
4270 (callint.o): Depend on character.h.
4271
4272 * eval.c (internal_lisp_condition_case): Include the handler
4273 representation in the error message.
4274 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4275 when breaking from the loop.
4276
4277 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4278
4279 * callint.c (Fcall_interactively): When displaying error message
4280 about invalid control letter, pass the character's codepoint, not
4281 a pointer to its multibyte form. Improve display of the character
4282 in octal and display also its hex code.
4283
4284 * character.c (char_string): Use %x to display the (unsigned)
4285 codepoint of an invalid character, to avoid displaying a bogus
4286 negative value.
4287
4288 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4289 `error', not SYMBOL_NAME itself.
4290
4291 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4292 character arguments to `error'.
4293
4294 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4295 to `error' in error message about FINAL_CHAR argument. Make sure
4296 FINAL_CHAR is a character, and use %c when it is passed as
4297 argument to `error'.
4298
4ffd0d6b 42992011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4300
4301 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4302
4303 * w32.c: Include <time.h>.
4304 (sys_localtime): New function.
4305
4ffd0d6b 43062011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4307
4308 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4309
4ffd0d6b 4310 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4311
4ffd0d6b 43122011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4313
4ffd0d6b
GM
4314 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4315 zombies (Bug#8467).
aac0c6e3 4316
04c56954
EZ
43172011-04-19 Eli Zaretskii <eliz@gnu.org>
4318
4319 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4320 gl_state.e_property when gl_state.object is Qt.
4321
4322 * insdel.c (make_gap_larger): Remove limitation of buffer size
4323 to <= INT_MAX.
4324
16a43933
CY
43252011-04-18 Chong Yidong <cyd@stupidchicken.com>
4326
4327 * xdisp.c (lookup_glyphless_char_display)
4328 (produce_glyphless_glyph): Handle cons cell entry in
4329 glyphless-char-display.
4330 (Vglyphless_char_display): Document it.
4331
4332 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4333 glyphless-char-display.
4334
4581706e
CY
43352011-04-17 Chong Yidong <cyd@stupidchicken.com>
4336
4337 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4338
4339 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4340
4341 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4342 definition for no-X builds.
4343
4887c6e2 43442011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4345
fd35b6f9
PE
4346 Static checks with GCC 4.6.0 and non-default toolkits.
4347
5c1ccb01
PE
4348 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4349
006c5daa
PE
4350 * process.c (keyboard_bit_set): Define only if SIGIO.
4351 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4352 (send_process): Repair possible setjmp clobbering.
4353
efc736d3
PE
4354 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4355
4e2fe2e6
PE
4356 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4357
f97334a2
PE
4358 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4359
4e75f29d
PE
4360 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4361 Define only if needed.
4362
90efadd1
PE
4363 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4364 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4365 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4366
3c647824
PE
4367 * dispextern.h (struct redisplay_interface): Rename param
4368 to avoid shadowing.
e264f262 4369 * termhooks.h (struct terminal): Likewise.
761383f4 4370 * xterm.c (xembed_send_message): Likewise.
3c647824 4371
b58c5c4a
PE
4372 * insdel.c (make_gap_smaller): Define only if
4373 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4374
cad59032
PE
4375 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4376 it.
4377
c339dc2e
PE
4378 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4379 so that we aren't warned about unused symbols.
4380
91a3e27b
PE
4381 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4382
399c71d3 4383 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4384
8ffc96f5
PE
4385 * xfns.c (x_real_positions): Mark locals as initialized.
4386
eef9bc79
PE
4387 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4388
098db9dd
PE
4389 * xterm.c: Fix problems found by static analysis with other toolkits.
4390 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4391 (x_dispatch_event): Declare static if USE_GTK, and
4392 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4393 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4394 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4395 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4396 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4397
eb18f6cc
PE
4398 * xmenu.c (menu_help_callback): Pointer type fixes.
4399 Use const pointers when pointing at readonly data. Avoid pointer
4400 signedness clashes.
4401 (FALSE): Remove unused macro.
4402 (update_frame_menubar): Remove unused decl.
4403
1fe72bf8
PE
4404 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4405
60d9e1db
PE
4406 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4407 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4408 (single_menu_item): Rename local to avoid shadowing.
4409
39261c26
PE
4410 * keyboard.c (make_lispy_event): Remove unused local var.
4411
018c5e19
PE
4412 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4413 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4414
63d2b86e
PE
4415 * bitmaps: Change bitmaps from unsigned char back to the X11
4416 compatible char. Avoid the old compiler warnings about
4417 out-of-range initializers by using, for example, '\xab' rather
4418 than 0xab.
4419
aefd87e1
PE
4420 * xgselect.c (xgselect_initialize): Check vs interface
4421 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4422
bf501fb9
PE
4423 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4424
e9829fdf
PE
4425 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4426 to read-only memory.
4427
1086c095
PE
4428 * fns.c (vector): Remove; this old hack is no longer needed.
4429
2baccd04 4430 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4431 Remove unused var.
dde42981 4432 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4433
72391843 4434 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4435
436c16df 4436 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4437 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4438 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4439
92bb796d 4440 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4441 (x_term_init): Remove local to avoid shadowing.
92bb796d 4442
764430a3 4443 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4444
4445 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4446 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4447
d1dfb56c
EZ
44482011-04-16 Eli Zaretskii <eliz@gnu.org>
4449
c4354cb4
EZ
4450 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4451
d1dfb56c
EZ
4452 Fix regex.c, syntax.c and friends for buffers > 2GB.
4453 * syntax.h (struct gl_state_s): Declare character position members
4454 EMACS_INT.
4455
4456 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4457
04f2d78b
CB
4458 * textprop.c (verify_interval_modification, interval_of):
4459 Declare arguments EMACS_INT.
d1dfb56c
EZ
4460
4461 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4462 EMACS_INT.
4463
4464 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4465
4466 * indent.c (Fvertical_motion): Local variable it_start is now
4467 EMACS_INT.
4468
4469 * regex.c (re_match, re_match_2, re_match_2_internal)
4470 (bcmp_translate, regcomp, regexec, print_double_string)
4471 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4472 (re_compile_pattern, re_exec): Declare arguments and local
4473 variables `size_t' and `ssize_t' and return values `regoff_t', as
4474 appropriate.
4475 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4476 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4477 <compile_stack_type>: `size' and `avail' are now `size_t'.
4478
4479 * regex.h <regoff_t>: Use ssize_t, not int.
4480 (re_search, re_search_2, re_match, re_match_2): Arguments that
4481 specify buffer/string position and length are now ssize_t and
4482 size_t. Return type is regoff_t.
4483
613052cd
BK
44842011-04-16 Ben Key <bkey76@gmail.com>
4485
4486 * nsfont.m: Fixed bugs in ns_get_family and
4487 ns_descriptor_to_entity that were caused by using free to
4488 deallocate memory blocks that were allocated by xmalloc (via
4489 xstrdup). This caused Emacs to crash when compiled with
4490 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4491 --enable-checking=xmallocoverrun). xfree is now used to
4492 deallocate these memory blocks.
4493
4170f62f 44942011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4495
71b41406
PE
4496 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4497
9587a89d
PE
4498 emacs_write: Accept and return EMACS_INT for sizes.
4499 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4500 et seq.
4501 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4502 Accept and return EMACS_INT.
4503 (emacs_gnutls_write): Return the number of bytes written on
4504 partial writes.
4505 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4506 (emacs_read, emacs_write): Remove check for negative size, as the
4507 Emacs source code has been audited now.
9587a89d
PE
4508 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4509 (emacs_read, emacs_write): Use it.
273a5f82
PE
4510 * process.c (send_process): Adjust to the new signatures of
4511 emacs_write and emacs_gnutls_write. Do not attempt to store
4512 a byte offset into an 'int'; it might overflow.
9587a89d 4513 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4514
3e047f51
PE
4515 * sound.c: Don't assume sizes fit in 'int'.
4516 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4517 Return EMACS_INT, not int.
3e047f51 4518 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4519 Accept EMACS_INT, not int.
4520 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4521 record read return values.
4522
cc39a9db
BK
45232011-04-15 Ben Key <bkey76@gmail.com>
4524
c9d0ec6d
JB
4525 * keyboard.c (Qundefined): Don't declare static since it is used
4526 in nsfns.m.
4527 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4528 static since they are used in nsfont.m.
cc39a9db 4529
6c60eb9f
SM
45302011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4531
4532 * process.c (Qprocessp): Don't declare static.
4533 * lisp.h (Qprocessp): Declare again.
4534
7990b61a
JB
45352011-04-15 Juanma Barranquero <lekktu@gmail.com>
4536
4537 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4538
5d4cb038
PE
45392011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4540
8bd7b830 4541 Improve C-level modularity by making more things 'static'.
cd64ea1d 4542
e3b27b31
PE
4543 Don't publish debugger-only interfaces to other modules.
4544 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4545 (verify_bytepos, count_markers): Move decls to the only modules
4546 that need them.
4547 * region-cache.h (pp_cache): Likewise.
4548 * window.h (check_all_windows): Likewise.
4549 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4550
5d4cb038
PE
4551 * sysdep.c (croak): Now static, if
4552 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4553 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4554
4555 * alloc.c (refill_memory_reserve): Now static if
4556 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4557 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4558
e87b6180
PE
4559 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4560 Define only if USE_LUCID.
4561
ac64929e
PE
4562 * xrdb.c (x_customization_string, x_rm_string): Now static.
4563
6f37259d
PE
4564 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4565 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4566
1683e3ab
PE
4567 * xdisp.c (draw_row_with_mouse_face): Now static.
4568 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4569
de9c2632
PE
4570 * window.h (check_all_windows): Mark externally visible.
4571
2b96acb7
PE
4572 * window.c (window_deletion_count): Now static.
4573
4574 * undo.c: Make symbols static if they're not exported.
4575 (last_undo_buffer, last_boundary_position, pending_boundary):
4576 Now static.
4577
50436f33
PE
4578 * textprop.c (interval_insert_behind_hooks): Now static.
4579 (interval_insert_in_front_hooks): Likewise.
4580
64520e5c
PE
4581 * term.c: Make symbols static if they're not exported.
4582 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4583 (max_frame_lines, tty_set_terminal_modes):
4584 (tty_reset_terminal_modes, tty_turn_off_highlight):
4585 (get_tty_terminal): Now static.
4586 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4587 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4588 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4589 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4590 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4591
1fa53021
PE
4592 * sysdep.c: Make symbols static if they're not exported.
4593 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4594 Now static.
4595 (sigprocmask_set, full_mask): Remove; unused.
4596 (wait_debugging): Mark as visible.
4597 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4598 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4599
d4b43b22
PE
4600 * syntax.c (syntax_temp): Define only if !__GNUC__.
4601
b7c513d0
PE
4602 * sound.c (current_sound_device, current_sound): Now static.
4603
989b29ad
PE
4604 * search.c (searchbufs, searchbuf_head): Now static.
4605
13a55a78
PE
4606 * scroll.c (scroll_cost): Remove; unused.
4607 * dispextern.h (scroll_cost): Remove decl.
4608
de68a1fc
PE
4609 * region-cache.h (pp_cache): Mark as externally visible.
4610
40ccffa6
PE
4611 * process.c: Make symbols static if they're not exported.
4612 (process_tick, update_tick, create_process, chan_process):
4613 (Vprocess_alist, proc_buffered_char, datagram_access):
4614 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4615 (deactivate_process): Mark defn as static, as well as decl.
4616 * lisp.h (create_process): Remove decl.
4617 * process.h (chan_process, Vprocess_alist): Remove decls.
4618
ad64fc97
PE
4619 * print.c: Make symbols static if they're not exported.
4620 (print_depth, new_backquote_output, being_printed, print_buffer):
4621 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4622 (print_interval, print_number_index, initial_stderr_stream):
4623 Now static.
4624 * lisp.h (Fprinc): Remove decl.
4625 (debug_output_compilation_hack): Mark as externally visible.
4626
adddb265
PE
4627 * sysdep.c (croak): Move decl from here to syssignal.h.
4628 * syssignal.h (croak): Put it here, so the API can be checked when
4629 'croak' is called from dissociate_if_controlling_tty.
4630
1717ede2
PE
4631 * minibuf.c: Make symbols static if they're not exported.
4632 (minibuf_save_list, choose_minibuf_frame): Now static.
4633 * lisp.h (choose_minibuf_frame): Remove decl.
4634
fa5fb2bc
PE
4635 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4636
1e3890d1
PE
4637 * lread.c: Make symbols static if they're not exported.
4638 (read_objects, initial_obarray, oblookup_last_bucket_number):
4639 Now static.
4640 (make_symbol): Remove; unused.
4641 * lisp.h (initial_obarray, make_symbol): Remove decls.
4642
8a1414fa
PE
4643 * keyboard.c: Make symbols static if they're not exported.
4644 (single_kboard, recent_keys_index, total_keys, recent_keys):
4645 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4646 (this_single_command_key_start, echoing, last_auto_save):
4647 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4648 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4649 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4650 (Vlispy_mouse_stem, double_click_count):
4651 Now static.
4652 (force_auto_save_soon): Define only if SIGDANGER.
4653 (ignore_mouse_drag_p): Now static if
4654 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4655 (print_help): Remove; unused.
4656 (stop_character, last_timer_event): Mark as externally visible.
4657 * keyboard.h (ignore_mouse_drag_p): Declare only if
4658 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4659 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4660 * lisp.h (echoing): Remove decl.
4661 (force_auto_save_soon): Declare only if SIGDANGER.
4662 * xdisp.c (redisplay_window): Simplify code, to make it more
4663 obvious that ignore_mouse_drag_p is not accessed if !defined
4664 USE_GTK && !defined HAVE_NS.
4665
93ea6e8f
PE
4666 * intervals.c: Make symbols static if they're not exported.
4667 (merge_properties_sticky, merge_interval_right, delete_interval):
4668 Now static.
4669 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4670
77382fcc
PE
4671 * insdel.c: Make symbols static if they're not exported.
4672 However, leave prepare_to_modify_buffer alone. It's never
4673 called from outside this function, but that appears to be a bug.
4674 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4675 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4676 (adjust_after_replace_noundo): Remove; unused.
4677 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4678 (signal_before_change): Remove decls.
77382fcc 4679
9306c32e
PE
4680 * indent.c (val_compute_motion, val_vmotion): Now static.
4681
cd44d2eb
PE
4682 * image.c: Make symbols static if they're not exported.
4683 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4684 if USE_GTK.
4685 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4686 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4687
ad9a7a06
PE
4688 * fringe.c (standard_bitmaps): Now static.
4689 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4690
81626931
PE
4691 * frame.c: Make symbols static if they're not exported.
4692 (x_report_frame_params, make_terminal_frame): Now static.
4693 (get_frame_param): Now static, unless HAVE_NS.
4694 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4695 (x_get_resource_string): Remove; not used.
4696 * frame.h (make_terminal_frame, x_report_frame_params):
4697 (x_get_resource_string); Remove decls.
4698 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4699 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4700
239f9db9
PE
4701 * font.c, fontset.c: Make symbols static if they're not exported.
4702 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4703 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4704 * font.c (font_close_object): Now static.
4705 * font.h (font_close_object): Remove.
4706 * fontset.c (FONTSET_OBJLIST): Remove.
4707 (free_realized_fontset) #if-0 the body, which does nothing.
4708 (face_suitable_for_char_p): #if-0, as it's never called.
4709 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4710 * xfaces.c (face_at_string_position):
4711 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4712 since 0 is always ASCII.
4713
dfcf3579
PE
4714 * fns.c (weak_hash_tables): Now static.
4715
5045092b
PE
4716 * fileio.c: Make symbols static if they're not exported.
4717 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4718 (Vwrite_region_annotation_buffers): Now static.
4719
57a96f5c
PE
4720 * eval.c: Make symbols static if they're not exported.
4721 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4722 * lisp.h (backtrace_list): Remove decl.
4723
35f08c38
PE
4724 * emacs.c: Make symbols static if they're not exported.
4725 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4726 (fatal_error_code, fatal_error_signal_hook, standard_args):
4727 Now static.
4728 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4729 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4730 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4731 * lisp.h (fatal_error_signal_hook): Remove decl.
4732 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4733
f44bd759
PE
4734 * editfns.c: Move a (normally-unused) function to its only use.
4735 * editfns.c, lisp.h (get_operating_system_release): Remove.
4736 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4737 worth the hassle of breaking this out.
4738
b532497d
PE
4739 * xterm.c: Make symbols static if they're not exported.
4740 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4741 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4742 (x_destroy_window, x_delete_display):
4743 Now static.
4744 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4745 (x_mouse_leave): Remove; unused.
4746 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4747 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4748 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4749 Remove decls.
4750 (x_mouse_leave): Declare only if WINDOWSNT.
4751 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4752 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4753 USE_X_TOOLKIT.
4754
1675728f
PE
4755 * ftxfont.c: Make symbols static if they're not exported.
4756 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4757 HAVE_FREETYPE.
4758 * font.h (ftxfont_driver): Likewise.
4759
e4cebfca
PE
4760 * xfns.c: Make symbols static if they're not exported.
4761 (x_last_font_name, x_display_info_for_name):
4762 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4763 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4764 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4765 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4766 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4767 (last_show_tip_args): Now static.
4768 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4769 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4770 (x_screen_planes): Remove; unused.
4771 * dispextern.h (x_screen_planes): Remove decl.
4772
5bf46f05
PE
4773 * dispnew.c: Make symbols static if they're not exported.
4774 * dispextern.h (redraw_garbaged_frames, scrolling):
4775 (increment_row_positions): Remove.
4776 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4777 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4778 Now static.
4779 (redraw_garbaged_frames): Remove; unused.
4780
435f4c28
PE
4781 * xfaces.c: Make symbols static if they're not exported.
4782 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4783 Remove decls.
4784 * xterm.h (defined_color): Remove decls.
4785 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4786 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4787 (menu_face_changed_default, defined_color, free_realized_face):
4788 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4789 (ascii_face_of_lisp_face): Remove; unused.
4790
8524aef3
PE
4791 * xdisp.c: Make symbols static if they're not exported.
4792 * dispextern.h (scratch_glyph_row, window_box_edges):
4793 (glyph_to_pixel_coords, set_cursor_from_row):
4794 (get_next_display_element, set_iterator_to_next):
4795 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4796 (show_mouse_face): Remove decls
4797 * frame.h (message_buf_print): Likewise.
4798 * lisp.h (pop_message, set_message, check_point_in_composition):
4799 Likewise.
4800 * xterm.h (set_vertical_scroll_bar): Likewise.
4801 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4802 (message_buf_print, scratch_glyph_row, displayed_buffer):
4803 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4804 (get_next_display_element, show_mouse_face, window_box_edges):
4805 (frame_to_window_pixel_xy, check_point_in_composition):
4806 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4807 (glyph_to_pixel_coords): Remove; unused.
4808
16390cd2
PE
4809 * dired.c (file_name_completion): Now static.
4810
4811 * dbusbind.c (xd_in_read_queued_messages): Now static.
4812
a25f4dfa
PE
4813 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4814 * data.c (circular_list_error): Remove.
4815
14a9c8df
PE
4816 * commands.h (last_point_position, last_point_position_buffer):
4817 (last_point_position_window): Remove decls.
4818 * keyboard.c: Make these variables static.
4819
04f2d78b
CB
4820 * coding.h (coding, code_convert_region, encode_coding_gap):
4821 Remove decls.
74ab6df5
PE
4822 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4823 (iso_code_class, detect_coding, code_convert_region): Now static.
4824 (encode_coding_gap): Remove; unused.
4825
38dfbee1
PE
4826 * chartab.c (chartab_chars, chartab_bits): Now static.
4827
a2cb4e63
PE
4828 * charset.h (charset_iso_8859_1): Remove decl.
4829 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4830 Now static.
4831
127198fd
PE
4832 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4833 * ccl.c (Vccl_program_table): Now static.
4834 (check_ccl_update): Remove; unused.
4835
d85b608f
PE
4836 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4837 * category.h: ... from here.
4838 * category.c (check_category_table, set_category_set): Now static.
4839
31cd66f3
PE
4840 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4841 * lisp.h: Remove these decls.
4842
c358e587
PE
4843 * buffer.c (buffer_count): Remove unused var.
4844
e78aecca
PE
4845 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4846 so that it's not optimized away.
4847 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4848 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4849 exported only to the debugger.
4850
e192d7d3 4851 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4852 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4853
92470028
PE
4854 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4855 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4856 was inaccessible from Lisp.
4857 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4858 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4859
244ed907
PE
4860 alloc.c: Import and export fewer symbols, and remove unused items.
4861 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4862 is defined.
4863 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4864 it's not optimized away by whole-program optimization.
4865 (message_enable_multibyte, free_misc): Remove.
4866 (catchlist, handlerlist, mark_backtrace):
4867 Declare only if BYTE_MARK_STACK.
4868 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4869 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4870 (message_enable_multibyte): Remove decl.
4871 (free_misc, interval_free_list, float_block, float_block_index):
4872 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4873 (cons_free_list, last_marked_index):
4874 Now static.
4875 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4876 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4877 (mark_backtrace): Define only if BYTE_MARK_STACK.
4878 * xdisp.c (message_enable_multibyte): Now static.
4879
61c2b50e 4880 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4881 This makes it easier for human readers (and static analyzers)
4882 to see whether these variables are used from other modules.
4883 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4884 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4885 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4886 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4887 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4888 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4889 * xmenu.c, xselect.c:
4890 Declare Q* vars static if they are not used in other modules.
4891 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4892 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4893 Remove decls of unexported vars.
4894 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4895
95c82688
PE
4896 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4897
16a97296
PE
4898 Make Emacs functions such as Fatom 'static' by default.
4899 This makes it easier for human readers (and static analyzers)
4900 to see whether these functions can be called from other modules.
4901 DEFUN now defines a static function. To make the function external
4902 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4903 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4904 (Finit_image_library):
16a97296
PE
4905 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4906 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4907 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4908 Remove decls, since these functions are now static.
4909 (Funintern, Fget_internal_run_time): New decls, since these functions
4910 were already external.
95c82688 4911
16a97296
PE
4912 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4913 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4914 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4915 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4916 * keyboard.c, keymap.c, lread.c:
4917 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4918 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4919 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4920 Mark functions with DEFUE instead of DEFUN,
4921 if they are used in other modules.
4922 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4923 decls for now-static functions.
4924 * buffer.h (Fdelete_overlay): Remove decl.
4925 * callproc.c (Fgetenv_internal): Mark as internal.
4926 * composite.c (Fremove_list_of_text_properties): Remove decl.
4927 (Fcomposition_get_gstring): New forward static decl.
4928 * composite.h (Fcomposite_get_gstring): Remove decl.
4929 * dired.c (Ffile_attributes): New forward static decl.
4930 * doc.c (Fdocumntation_property): New forward static decl.
4931 * eval.c (Ffetch_bytecode): New forward static decl.
4932 (Funintern): Remove extern decl; now in .h file where it belongs.
4933 * fileio.c (Fmake_symbolic_link): New forward static decl.
4934 * image.c (Finit_image_library): New forward static decl.
4935 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4936 * intervals.h (Fprevious_property_change):
4937 (Fremove_list_of_text_properties): Remove decls.
4938 * keyboard.c (Fthis_command_keys): Remove decl.
4939 (Fcommand_execute): New forward static decl.
4940 * keymap.c (Flookup_key): New forward static decl.
4941 (Fcopy_keymap): Now static.
4942 * keymap.h (Flookup_key): Remove decl.
4943 * process.c (Fget_process): New forward static decl.
4944 (Fprocess_datagram_address): Mark as internal.
4945 * syntax.c (Fsyntax_table_p): New forward static decl.
4946 (skip_chars): Remove duplicate decl.
4947 * textprop.c (Fprevious_property_change): New forward static decl.
4948 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4949 Now internal.
4950 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4951 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4952
785bbd42
PE
4953 * editfns.c (Fformat): Remove unreachable code.
4954
8b913b57
AS
49552011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4956
4957 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4958 change. (Bug#8496)
4959
a6744a35
EZ
49602011-04-13 Eli Zaretskii <eliz@gnu.org>
4961
4962 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4963 when at ZV. (Bug#8487)
4964
e7974947
AS
49652011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4966
baad03f0
AS
4967 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4968 (Bug#8437)
4969 * keyboard.c (parse_tool_bar_item): Likewise.
4970 * sound.c (sound_cleanup, alsa_close): Likewise.
4971 * termcap.c (tgetent): Likewise.
4972 * xfns.c (x_default_font_parameter): Likewise.
4973 * xsettings.c (read_and_apply_settings): Likewise.
4974
e7974947
AS
4975 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4976 (overrun_check_free): Protoize.
4977
28272684
PE
49782011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4979
4980 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4981 since callers should never pass a negative size.
4982 Change the signature to match that of plain 'read' and 'write'; see
4983 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4984 * lisp.h: Update prototypes of emacs_write and emacs_read.
4985
11997c76
EZ
49862011-04-11 Eli Zaretskii <eliz@gnu.org>
4987
4988 * xdisp.c (redisplay_window): Don't try to determine the character
4989 position of the scroll margin if the window start point w->startp
e896f03c 4990 is outside the buffer's accessible region. (Bug#8468)
11997c76 4991
8a2cbd72
EZ
49922011-04-10 Eli Zaretskii <eliz@gnu.org>
4993
4994 Fix write-region and its subroutines for buffers > 2GB.
4995 * fileio.c (a_write, e_write): Modify declaration of arguments and
4996 local variables to support buffers larger than 2GB.
4997 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4998
4999 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5000 argument, local variables, and return value.
5001
5002 * lisp.h: Update prototypes of emacs_write and emacs_read.
5003
5004 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5005
4073e537 50062011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5007
1ebfdcb6
PE
5008 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5009
b2ded58d
PE
5010 Fix more problems found by GCC 4.6.0's static checks.
5011
7d66342c
PE
5012 * xdisp.c (vmessage): Use a better test for character truncation.
5013
bbf47d44
PE
5014 * charset.c (load_charset_map): <, not <=, for optimization,
5015 and to avoid potential problems with integer overflow.
9248994d 5016 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5017 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5018 * editfns.c (Fformat): Likewise.
1e69125e 5019 * syntax.c (skip_chars): Likewise.
3befa583 5020
e3019616
PE
5021 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5022 This also lets GCC 4.6.0 generate slightly better loop code.
5023
becfa255
PE
5024 * callint.c (Fcall_interactively): <, not <=, for optimization.
5025 (Fcall_interactively): Count the number of arguments produced,
5026 not the number of arguments given. This is simpler and lets GCC
5027 4.6.0 generate slightly better code.
5028
dae0cd48
PE
5029 * ftfont.c: Distingish more carefully between FcChar8 and char.
5030 The previous code passed unsigned char * to a functions like
5031 strlen and xstrcasecmp that expect char *, which does not
5032 conform to the C standard.
5033 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5034 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5035 char * when the C standard requires it.
5036
76032d70
PE
5037 * keyboard.c (read_char): Remove unused var.
5038
eb3f1cc8
PE
5039 * eval.c: Port to Windows vsnprintf (Bug#8435).
5040 Include <limits.h>.
5041 (SIZE_MAX): Define if the headers do not.
5042 (verror): Do not give up if vsnprintf returns a negative count.
5043 Instead, grow the buffer. This ports to Windows vsnprintf, which
5044 does not conform to C99. Problem reported by Eli Zaretskii.
5045 Also, simplify the allocation scheme, by avoiding the need for
5046 calling realloc, and removing the ALLOCATED variable.
5047
70476b54
PE
5048 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5049
12020a9e
PE
5050 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5051 But keep the doprint source code for now, as we might revamp it
5052 and use it again (Bug#8435).
ea6c7ae6
PE
5053 * lisp.h (doprnt): Remove.
5054 * Makefile.in (base_obj): Remove doprnt.o.
5055 * deps.mk (doprnt.o): Remove.
5056
5fdb398c
PE
5057 error: Print 32- and 64-bit integers portably (Bug#8435).
5058 Without this change, on typical 64-bit hosts error ("...%d...", N)
5059 was used to print both 32- and 64-bit integers N, which relied on
5060 undefined behavior.
5061 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5062 New macro.
5063 * lisp.h (error, verror): Mark as printf-like functions.
5064 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5065 Report overflow in size calculations when allocating printf buffer.
5066 Do not truncate output string at its first null byte.
5067 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5068 Truncate the output at a character boundary, since vsnprintf does not
5069 do that.
5070 * charset.c (check_iso_charset_parameter): Convert internal
5071 character to string before calling 'error', since %c now has the
5072 printf meaning.
5073 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5074 overflow when computing char to be passed to 'error'. Do not
5075 pass Lisp_Object to 'error'; pass the integer instead.
5076 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5077 formatted with plain %d.
5078
b189fa66
PE
5079 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5080
bff87ef0
PE
5081 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5082
7e2cac20
PE
5083 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5084
ce4d90b5
PE
5085 * xterm.c (x_catch_errors): Remove duplicate declaration.
5086
266c9547
PE
5087 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5088
79c49ad2
PE
5089 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5090
368f4090
JM
50912011-04-10 Jim Meyering <meyering@redhat.com>
5092
5093 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5094 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5095 return ssize_t not "int", and use size_t as the buffer length.
5096 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5097 * gnutls.h: Update declarations.
5098 * process.c (read_process_output): Use ssize_t, to match.
5099 (send_process): Likewise.
5100
a32d4040
CY
51012011-04-09 Chong Yidong <cyd@stupidchicken.com>
5102
5103 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5104
8546720e 51052011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5106
04f2d78b
CB
5107 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5108 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5109
8546720e
GM
5110 * xterm.c (handle_one_xevent):
5111 * xmenu.c (create_and_show_popup_menu):
5112 * xselect.c (x_decline_selection_request)
5113 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5114
0a2f5c1a 51152011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5116
5117 Fix some uses of `int' instead of EMACS_INT.
5118 * search.c (string_match_1, fast_string_match)
5119 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5120 (scan_buffer, find_next_newline_no_quit)
5121 (find_before_next_newline, search_command, Freplace_match)
5122 (Fmatch_data): Make some `int' variables be EMACS_INT.
5123
5124 * xdisp.c (display_count_lines): 3rd argument and return value now
5125 EMACS_INT. All callers changed.
5126 (pint2hrstr): Last argument is now EMACS_INT.
5127
5128 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5129 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5130 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5131 (decode_coding_utf_16, decode_coding_emacs_mule)
5132 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5133 (decode_coding_ccl, decode_coding_charset)
5134 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5135 (decode_coding_iso_2022, decode_coding_emacs_mule)
5136 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5137 <char_offset, last_offset>: Declare EMACS_INT.
5138 (encode_coding_utf_8, encode_coding_utf_16)
5139 (encode_coding_emacs_mule, encode_invocation_designation)
5140 (encode_designation_at_bol, encode_coding_iso_2022)
5141 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5142 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5143 Declare EMACS_INT.
5144 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5145 (encode_invocation_designation): Last argument P_NCHARS is now
5146 EMACS_INT.
5147 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5148 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5149
5150 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5151 All users changed.
5152
5153 * ccl.c (Fccl_execute_on_string): Declare some variables
5154 EMACS_INT.
5155
8546720e 51562011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5157
5158 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5159
4e19a977
CS
51602011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5161
5162 * process.c (Fformat_network_address): Doc fix.
5163
87302331
R
51642011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5165
5166 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5167
cbb59342
CY
51682011-04-08 Chong Yidong <cyd@stupidchicken.com>
5169
5170 * keyboard.c (read_char): Call Lisp function help-form-show,
5171 instead of using internal_with_output_to_temp_buffer.
5172 (Qhelp_form_show): New var.
e0d38eeb 5173 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5174
5175 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5176
5177 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5178
e67a13ab
CY
51792011-04-06 Chong Yidong <cyd@stupidchicken.com>
5180
04f2d78b
CB
5181 * process.c (Flist_processes): Remove to Lisp.
5182 (list_processes_1): Delete.
e67a13ab 5183
973f782d
EZ
51842011-04-06 Eli Zaretskii <eliz@gnu.org>
5185
7c106b1e
EZ
5186 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5187
973f782d
EZ
5188 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5189
41cf7d1a 51902011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5191
ca23cc88
PE
5192 Fix more problems found by GCC 4.6.0's static checks.
5193
f390e2d5
PE
5194 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5195
42eea0d0
PE
5196 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5197
b69769da 5198 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5199
f9541e84
PE
5200 * xdisp.c (vmessage): Mark as a printf-like function.
5201
13841b55
PE
5202 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5203
c136c10f
PE
5204 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5205
5e2d4a30
PE
5206 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5207 printf-like functions.
5208 (tiff_load): Add casts to remove these marks before passing them
5209 to system-supplied API.
5210
583f48b9
PE
5211 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5212
b25d760e
PE
5213 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5214 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5215 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5216 directly, rather than having caller test rule sign. This avoids
5217 some unnecessary tests.
5218 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5219 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5220 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5221
bc7b6697 5222 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5223 (xfont_open): Avoid unnecessary tests.
bc7b6697 5224
27ccc379
PE
5225 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5226
dcd5c89a
PE
5227 * composite.h, composite.c (composition_gstring_put_cache):
5228 Use EMACS_INT, not int, for length.
5229
b13a45c6
PE
5230 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5231 breaking out part of COMPOSITION_DECODE_RULE.
5232 (COMPOSITION_DECODE_RULE): Use it.
5233 * composite.c (get_composition_id): Remove unused local vars,
5234 by using the new macro.
5235
1e792e4d
PE
5236 * textprop.c (set_text_properties_1): Change while to do-while,
5237 since the condition is always true at first.
5238
dc6c6455 5239 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5240 (interval_deletion_adjustment): Return unsigned value.
5241 All uses changed.
dc6c6455 5242
aba7731a
PE
5243 * process.c (list_processes_1, create_pty, read_process_output):
5244 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5245 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5246 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5247 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5248 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5249
fdfc4bf3
PE
5250 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5251
fca8fe46 5252 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5253 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5254
06a0259a 5255 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5256 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5257 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5258
e7b9e80f
PE
5259 * print.c (print_error_message): Avoid int overflow.
5260
56201685
PE
5261 * font.c (font_list_entities): Redo for clarity,
5262 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5263
78834453 5264 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5265 (font_score): Avoid potential overflow in diff calculation.
78834453 5266
0bc0b309 5267 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5268 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5269
e610eaca
PE
5270 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5271
b895abce
PE
5272 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5273 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5274 can always succeed if overflow has undefined behavior.
5275
1f1d9321 5276 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5277 (wordify): Omit three unnecessary tests.
1f1d9321 5278
c59478bc
PE
5279 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5280 All callers changed. This avoids the need for an unused var.
5281
79b73827
PE
5282 * casefiddle.c (casify_region): Remove var that is set but not used.
5283
a4db5dfe
PE
5284 * dired.c (file_name_completion): Remove var that is set but not used.
5285
43aae36e
PE
5286 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5287
2a47c44d 5288 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5289 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5290
a37c69bf
PE
5291 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5292 Check for integer overflow on size calculations.
5293
328ab8e7
PE
5294 * buffer.c (Fprevious_overlay_change): Remove var that is set
5295 but not used.
5296
e5a2a5cb
PE
5297 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5298 Remove vars that are set but not used.
8d84a6eb 5299 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5300 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5301
a60e5f68
PE
5302 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5303
f661cb61 5304 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5305 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5306
f0397f5a
PE
5307 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5308 that are set but not used.
5309
8664db06 5310 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5311 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5312
6abdaa4a
PE
5313 * xselect.c (x_get_local_selection, x_handle_property_notify):
5314 Remove vars that are set but not used.
5315
0ce7538d 5316 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5317 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5318
9ae848fc
PE
5319 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5320 Remove var that is set but not used.
0b918413
PE
5321 (scroll_bar_windows_size): Now size_t, not int.
5322 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5323 Check for overflow.
9ae848fc 5324
a5a62657
PE
5325 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5326 (map_tty_color) [!defined MSDOS]: Likewise.
5327
5c5cdd39
PE
5328 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5329
66ebf983
PE
5330 * coding.c: Remove vars that are set but not used.
5331 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5332 All callers changed.
5333 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5334 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5335 (decode_coding_charset): Remove vars that are set but not used.
5336
1be4d761
PE
5337 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5338 that is set but not used.
5339
47553fa8
PE
5340 * print.c (print_object): Remove var that is set but not used.
5341
1f7196bf 5342 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5343 The gnulib version avoids calling malloc in the usual case,
5344 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5345 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5346 * filelock.c (current_lock_owner): Likewise.
5347 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5348 * sysdep.c: Include allocator.h, careadlinkat.h.
5349 (emacs_no_realloc_allocator): New static constant.
5350 (emacs_readlink): New function.
fdb61804
PE
5351 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5352 ../lib/careadlinkat.h.
d1fdcab7 5353
f84c17c7
SM
53542011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5355
5356 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5357 first non-nil return value).
5358
ef3862ad
JD
53592011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5360
5361 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5362 if not defined (Bug#8403).
5363
376a7006
JB
53642011-04-02 Juanma Barranquero <lekktu@gmail.com>
5365
5366 * xdisp.c (display_count_lines): Remove parameter `start',
5367 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5368 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5369 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5370 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5371 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5372 and thereabouts. All callers changed.
5373 (get_per_char_metric): Remove parameter `f', unused since
5374 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5375
6ca3801d
JM
53762011-04-02 Jim Meyering <meyering@redhat.com>
5377
5378 do not dereference NULL upon failed strdup
5379 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5380 (ns_get_family): Likewise.
5381
d8e2b5ba
JB
53822011-04-02 Juanma Barranquero <lekktu@gmail.com>
5383
5384 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5385
8c74fcbd
JD
53862011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5387
5388 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5389 later (Bug#8403).
5390
7200d79c
SM
53912011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5392
03408648 5393 Add lexical binding.
7200d79c 5394
03408648
SM
5395 * window.c (Ftemp_output_buffer_show): New fun.
5396 (Fsave_window_excursion):
5397 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5398
5399 * lread.c (lisp_file_lexically_bound_p): New function.
5400 (Fload): Bind Qlexical_binding.
5401 (readevalloop): Remove `evalfun' arg.
5402 Bind Qinternal_interpreter_environment.
5403 (Feval_buffer): Bind Qlexical_binding.
5404 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5405 Mark as dynamic.
5406 (syms_of_lread): Declare `lexical-binding'.
5407
5408 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5409
5410 * keyboard.c (eval_dyn): New fun.
5411 (menu_item_eval_property): Use it.
ca105506
SM
5412
5413 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5414
03408648
SM
5415 * fns.c (concat, mapcar1): Accept byte-code-functions.
5416
5417 * eval.c (Fsetq): Handle lexical vars.
5418 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5419 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5420 (FletX, Flet): Obey lexical binding.
5421 (Fcommandp): Handle closures.
5422 (Feval): New `lexical' arg.
5423 (eval_sub): New function extracted from Feval. Use it almost
5424 everywhere where Feval was used. Look up vars in lexical env.
5425 Handle closures.
5426 (Ffunctionp): Move from subr.el.
5427 (Ffuncall): Handle closures.
5428 (apply_lambda): Remove `eval_flags'.
5429 (funcall_lambda): Handle closures and new byte-code-functions.
5430 (Fspecial_variable_p): New function.
5431 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5432 but without exporting it to Lisp.
23aba0ea 5433
23aba0ea 5434 * doc.c (Fdocumentation, store_function_docstring):
03408648 5435 * data.c (Finteractive_form): Handle closures.
23aba0ea 5436
03408648
SM
5437 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5438 interactive spec.
ba83908c 5439
04f2d78b
CB
5440 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5441 New byte-codes.
03408648
SM
5442 (exec_byte_code): New function extracted from Fbyte_code to handle new
5443 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5444
03408648 5445 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5446
03408648 5447 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5448
e2abce01
JB
54492011-03-31 Juanma Barranquero <lekktu@gmail.com>
5450
5451 * xdisp.c (redisplay_internal): Fix prototype.
5452
63696a73 54532011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5454
63696a73 5455 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5456 (try_scrolling): Use it when setting scroll_limit.
5457 Limit scrolling to 100 screen lines.
63696a73
EZ
5458 (redisplay_window): Even when falling back on "recentering",
5459 position point in the window according to scroll-conservatively,
5460 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5461
5462 (try_scrolling): When point is above the window, allow searching
5463 as far as scroll_max, or one screenful, to compute vertical
5464 distance from PT to the scroll margin position. This prevents
5465 try_scrolling from unnecessarily failing when
5466 scroll-conservatively is set to a value slightly larger than the
5467 window height. Clean up the case of PT below the margin at bottom
5468 of window: scroll_max can no longer be INT_MAX. When aggressive
5469 scrolling is in use, don't let point enter the opposite scroll
5470 margin as result of the scroll.
5471 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5472 threshold of 100 lines for never-recentering scrolling.
5473
e4cc2dfc
JB
54742011-03-31 Juanma Barranquero <lekktu@gmail.com>
5475
5476 * dispextern.h (move_it_by_lines):
5477 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5478 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5479 (message_log_check_duplicate): Remove parameters `prev_bol' and
5480 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5481 (redisplay_internal): Remove parameter `preserve_echo_area',
5482 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5483
5484 * indent.c (Fvertical_motion):
5485 * window.c (window_scroll_pixel_based, Frecenter):
5486 Don't pass `need_y_p' to `move_it_by_lines'.
5487
1c470562
SM
54882011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5489
44f230aa
SM
5490 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5491 steal a few bits to be more compact.
5492 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5493 Remove unneeded casts.
5494
1c470562
SM
5495 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5496
888adce9
ZK
54972011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5498
5499 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5500 binding" message (bug#7967).
5501
f838ed7b
PE
55022011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5503
77861b95
PE
5504 Fix more problems found by GCC 4.6.0's static checks.
5505
de6dbc14
PE
5506 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5507 Remove unused local var.
5508
f838ed7b
PE
5509 * editfns.c (Fmessage_box): Remove unused local var.
5510
792c7b2b
PE
5511 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5512 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5513 Omit unused local vars.
c499e557 5514 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5515 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5516 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5517 Omit unused local var.
5518
ba0165e1
PE
5519 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5520 Don't assume string length fits in int.
32ad8845 5521 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5522 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5523
3c59b4c9
PE
5524 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5525 instead of alloca (Bug#8344).
5526
a3eed478 5527 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5528 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5529
eb4d412d
PE
5530 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5531
1658b401
PE
5532 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5533 concerns.
5534
5535 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5536
5537 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5538
9a2c6e05
PE
5539 * keyboard.c (syms_of_keyboard): Use the same style as later
5540 in this function when indexing through an array. This also
5541 works around GCC bug 48267.
5542
03d0a109
PE
5543 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5544
44f730c8
PE
5545 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5546
fe75f926
PE
5547 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5548 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5549
ffa8c828
PE
5550 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5551 This avoids undefined behavior on integer overflow, and is a bit
5552 more convenient anyway since it is compared to a size_t variable.
5553
c5101a77
PE
5554 Variadic C functions now count arguments with size_t, not int.
5555 This avoids an unnecessary limitation on 64-bit machines, which
5556 caused (substring ...) to crash on large vectors (Bug#8344).
5557 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5558 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5559 All variadic functions and their callers changed accordingly.
c5101a77
PE
5560 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5561 * data.c (arith_driver, float_arith_driver): Likewise.
5562 * editfns.c (general_insert_function): Likewise.
5563 * eval.c (struct backtrace.nargs, interactive_p)
5564 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5565 (funcall_lambda, mark_backtrace): Likewise.
5566 * fns.c (concat): Likewise.
5567 * frame.c (x_set_frame_parameters): Likewise.
5568 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5569 0 if not found, not -1. All callers changed.
5570
dd3f25f7
PE
5571 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5572 (stack_copy_size): Now size_t, not int.
5573 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5574
461c2ab9
JB
55752011-03-28 Juanma Barranquero <lekktu@gmail.com>
5576
5577 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5578 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5579 All callers changed.
5580
5581 * lisp.h (multibyte_char_to_unibyte):
5582 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5583 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5584 * character.h (CHAR_TO_BYTE8):
5585 * cmds.c (internal_self_insert):
5586 * editfns.c (general_insert_function):
5587 * keymap.c (push_key_description):
5588 * search.c (Freplace_match):
5589 * xdisp.c (message_dolog, set_message_1): All callers changed.
5590
f6d62986
SM
55912011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5592
5593 * keyboard.c (safe_run_hook_funcall): New function.
5594 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5595 don't set the hook to nil, but remove the offending function instead.
5596 (Qcommand_hook_internal): Remove, unused.
5597 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5598 Vcommand_hook_internal.
5599
5600 * eval.c (enum run_hooks_condition): Remove.
5601 (funcall_nil, funcall_not): New functions.
5602 (run_hook_with_args): Call each function through a `funcall' argument.
5603 Remove `cond' argument, now redundant.
5604 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5605 (Frun_hook_with_args_until_failure): Adjust accordingly.
5606 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5607
1db5b1ad
JB
56082011-03-28 Juanma Barranquero <lekktu@gmail.com>
5609
5610 * dispextern.h (string_buffer_position): Remove declaration.
5611
5612 * print.c (strout): Remove parameter `multibyte', unused since
5613 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5614
5615 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5616 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5617 All callers changed.
5618
5619 * w32.c (_wsa_errlist): Use braces for struct initializers.
5620
5621 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5622 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5623 All callers changed.
5624 (string_buffer_position): Likewise. Also, make static (it's never
5625 used outside xdisp.c).
5626 (cursor_row_p): Remove parameter `w', unused since
5627 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5628 (decode_mode_spec): Remove parameter `precision', introduced during
5629 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5630 All callers changed.
5631
5ffb62aa
JD
56322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5633
5634 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5635
461c2ab9 56362011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5637
5638 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5639 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5640 (ns_update_auto_hide_menu_bar): New functions.
5641 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5642 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5643 ns_constrain_all_frames.
5644 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5645 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5646
5c380ffb
JD
56472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5648
5649 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5650
9af30bdf
GM
56512011-03-27 Glenn Morris <rgm@gnu.org>
5652
5653 * syssignal.h: Replace RETSIGTYPE with void.
5654 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5655 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5656 Replace SIGTYPE with void everywhere.
5657 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5658 * s/template.h (SIGTYPE): Remove commented out definition.
5659
e2abce01
JB
56602011-03-26 Eli Zaretskii <eliz@gnu.org>
5661
5662 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5663 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5664
f868cd8a
JB
56652011-03-26 Juanma Barranquero <lekktu@gmail.com>
5666
59eb0929
JB
5667 * w32.c (read_unc_volume): Use parameter `henum', instead of
5668 global variable `wget_enum_handle'.
5669
5670 * keymap.c (describe_vector): Remove parameters `indices' and
5671 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5672 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5673
f868cd8a
JB
5674 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5675
5676 * keyboard.c (timer_check): Remove parameter `do_it_now',
5677 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5678 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5679 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5680
5681 * keyboard.c (read_char):
5682 * w32menu.c (w32_menu_display_help):
5683 * xmenu.c (show_help_event, menu_help_callback):
5684 Adjust calls to `show_help_echo'.
5685
5686 * gtkutil.c (xg_maybe_add_timer):
5687 * keyboard.c (readable_events):
5688 * process.c (wait_reading_process_output):
5689 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5690
5691 * insdel.c (adjust_markers_gap_motion):
5692 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5693 (gap_left, gap_right): Don't call it.
5694
2ecf6fdb
CY
56952011-03-25 Chong Yidong <cyd@stupidchicken.com>
5696
5697 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5698 incurred during fontification.
5699
6b1f9ba4
JB
57002011-03-25 Juanma Barranquero <lekktu@gmail.com>
5701
5702 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5703 (DEFVAR_PER_BUFFER): Don't pass it.
5704
5705 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5706 (scrolling_window): Don't pass it.
5707
0f4a96b5
JB
57082011-03-25 Juanma Barranquero <lekktu@gmail.com>
5709
5710 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5711
5712 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5713 and `suffix'.
5714 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5715 of variables specific to SELinux and computation of `encoded_absname'.
5716
5717 * image.c (XPutPixel): Remove unused variable `height'.
5718
5719 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5720
5721 * unexw32.c (get_section_info): Remove unused variable `section'.
5722
5723 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5724 (system_process_attributes): Remove unused variable `sess'.
5725 (sys_read): Remove unused variable `err'.
5726
5727 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5728 (w32_wnd_proc): Remove unused variable `isdead'.
5729 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5730 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5731 (x_create_tip_frame): Remove unused variable `tem'.
5732
5733 * w32inevt.c (w32_console_read_socket):
5734 Remove unused variable `no_events'.
5735
5736 * w32term.c (x_draw_composite_glyph_string_foreground):
5737 Remove unused variable `width'.
5738
1149507c
JB
57392011-03-24 Juanma Barranquero <lekktu@gmail.com>
5740
5741 * w32term.c (x_set_glyph_string_clipping):
5742 Don't pass uninitialized region to CombineRgn.
5743
9c88f339
JB
57442011-03-23 Juanma Barranquero <lekktu@gmail.com>
5745
5746 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5747 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5748 (Fx_close_connection): Remove unused variable `i'.
5749
5750 * w32font.c (w32font_draw): Return number of glyphs.
5751 (w32font_open_internal): Remove unused variable `i'.
5752 (w32font_driver): Add missing initializer.
5753
5754 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5755 (fill_in_menu): Remove unused variable `items_added'.
5756
5757 * w32term.c (last_mouse_press_frame): Remove static global variable.
5758 (w32_clip_to_row): Remove unused variable `f'.
5759 (x_delete_terminal): Remove unused variable `i'.
5760
5761 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5762 (NOTHING): Remove unused static global variable.
5763 (uniscribe_check_otf): Remove unused variable `table'.
5764 (uniscribe_font_driver): Add missing initializers.
5765
dee091a3
JD
57662011-03-23 Julien Danjou <julien@danjou.info>
5767
5768 * term.c (Fsuspend_tty, Fresume_tty):
5769 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5770 * window.c (temp_output_buffer_show):
5771 * insdel.c (signal_before_change):
5772 * frame.c (Fhandle_switch_frame):
5773 * fileio.c (Fdo_auto_save):
5774 * emacs.c (Fkill_emacs):
5775 * editfns.c (save_excursion_restore):
5776 * cmds.c (internal_self_insert):
5777 * callint.c (Fcall_interactively):
5778 * buffer.c (Fkill_all_local_variables):
5779 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5780 Use Frun_hooks.
0f4a96b5 5781 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5782 unconditionnaly since it does the check itself.
5783
2c520ab5 57842011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5785
c9c49752
PE
5786 Fix more problems found by GCC 4.5.2's static checks.
5787
8abc3f12
PE
5788 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5789 the first time through the loop, since we know p0 < p1 then.
5790 This also avoids a gcc -Wstrict-overflow warning.
5791
a2d26660
PE
5792 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5793 leading to a memory leak, possible in functions like
5794 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5795 of objects (Bug#8318).
a2d26660 5796
916c72e9
PE
5797 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5798 that could (at least in theory) be that large.
5799
19ab8a18
PE
5800 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5801 This is less likely to overflow, and avoids undefined behavior if
5802 overflow does occur. All callers changed. Use strtoul to scan
5803 for the unsigned long integer.
b7cbbd6f
PE
5804 (pint2hrstr): Simplify and tune code slightly.
5805 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5806
f0641eff
PE
5807 * scroll.c (do_scrolling): Work around GCC bug 48228.
5808 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5809
7f650bb9
PE
5810 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5811 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5812 (validate_x_resource_name): Simplify count usage.
5813 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5814
37dd57d1
PE
5815 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5816 fail (Bug#8306).
81e56e61 5817
699979fc 5818 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5819
401bf9b4
PE
5820 * process.c (Fmake_network_process): Use socklen_t, not int,
5821 where POSIX says socklen_t is required in portable programs.
5822 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5823 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5824 (Fmake_network_process, server_accept_connection):
5825 (wait_reading_process_output, read_process_output):
5826 Likewise.
5827
b93aacde
PE
5828 * process.c: Rename or move locals to avoid shadowing.
5829 (list_processes_1, Fmake_network_process):
5830 (read_process_output_error_handler, exec_sentinel_error_handler):
5831 Rename or move locals.
4dc343ee 5832 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5833 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5834 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5835 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5836 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5837
af8a867c 5838 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5839 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5840 Include tparam.h instead, since it declares them.
af8a867c
PE
5841 * cm.h (PC): Remove extern decl; tparam.h now does this.
5842 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5843 * terminfo.c: Include tparam.h, to check interfaces.
5844 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5845 (tparam): Adjust signature to match interface in tparam.h;
5846 this removes some undefined behavior. Check that outstring and len
5847 are zero, which they always are with Emacs.
5848 * tparam.h (PC, BC, UP): New extern decls.
5849
0248044d 5850 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5851 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5852
8ff096c1 5853 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5854 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5855 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5856 (ftfont_list): Remove unused local.
49eaafba
PE
5857 (get_adstyle_property, ftfont_pattern_entity):
5858 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5859 Rename locals to avoid shadowing.
8ff096c1 5860
e2be39f6
PE
5861 * xfont.c (xfont_list_family): Mark var as initialized.
5862
c9735e30
PE
5863 * xml.c (make_dom): Now static.
5864
8f5201ae
PE
5865 * composite.c (composition_compute_stop_pos): Rename local to
5866 avoid shadowing.
b246f932
PE
5867 (composition_reseat_it): Remove unused locals.
5868 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5869 (composition_update_it): Mark var as initialized.
11b61122
PE
5870 (find_automatic_composition): Mark vars as initialized,
5871 with a FIXME (Bug#8290).
8f5201ae 5872
760fbc2c
PE
5873 character.h: Rename locals to avoid shadowing.
5874 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5875 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5876 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5877 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5878 to avoid shadowing.
5879
ff08eb85
PE
5880 * textprop.c (property_change_between_p): Remove; unused.
5881
fc7bf025
PE
5882 * intervals.c (interval_start_pos): Now static.
5883
235d7abc
PE
5884 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5885
44f230aa
SM
5886 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5887 Rename locals to avoid shadowing.
3e7d6594 5888
50060332
PE
5889 * sound.c (wav_play, au_play, Fplay_sound_internal):
5890 Fix pointer signedness.
d01f234b 5891 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5892 (wav_play): Initialize a variable to 0, to prevent undefined
5893 behavior (Bug#8278).
50060332 5894
c4fc4e30
PE
5895 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5896
918436ed
PE
5897 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5898
c939f91b
PE
5899 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5900 clobbering (Bug#8298).
b9c7f648
PE
5901 * sysdep.c (sys_subshell): Likewise.
5902 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5903
6bd8c144
PE
5904 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5905 This should get cleaned up, so that child_setup has the
5906 same signature on all platforms.
5907
7710357c 5908 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5909 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5910
c59da222
CY
59112011-03-22 Chong Yidong <cyd@stupidchicken.com>
5912
5913 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5914 not to be necessary, and produces flickering.
5915
66b87493
GM
59162011-03-20 Glenn Morris <rgm@gnu.org>
5917
5918 * config.in: Remove file.
5919
45b6f6d5
JB
59202011-03-20 Juanma Barranquero <lekktu@gmail.com>
5921
5922 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5923 are now in src/globals.h.
5924 (syms_of_minibuf): Remove spurious & from previous change.
5925
3ec03f7e
LL
59262011-03-20 Leo <sdl.web@gmail.com>
5927
5928 * minibuf.c (completing-read-function): New variable.
5929 (completing-read-default): Rename from completing-read.
5930 (completing-read): Call completing-read-function.
5931
b14e3e21
CY
59322011-03-19 Juanma Barranquero <lekktu@gmail.com>
5933
5934 * xfaces.c (Fx_load_color_file):
5935 Read color file from absolute filename (bug#8250).
5936
f2b726e6
JB
59372011-03-19 Juanma Barranquero <lekktu@gmail.com>
5938
5939 * makefile.w32-in: Update dependencies.
5940
09f6ff02
EZ
59412011-03-17 Eli Zaretskii <eliz@gnu.org>
5942
5943 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5944
29a6015a
PE
59452011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5946
a3a6c54e
PE
5947 Fix more problems found by GCC 4.5.2's static checks.
5948
b766f867
PE
5949 * process.c (make_serial_process_unwind, send_process_trap):
5950 (sigchld_handler): Now static.
5951
be02381c
PE
5952 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5953 That way, the code declares only the vars that it needs.
5954 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5955 * s/cygwin.h (PTY_ITERATION): Likewise.
5956 * s/darwin.h (PTY_ITERATION): Likewise.
5957 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5958
57048744
PE
5959 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5960 * process.c (allocate_pty): Don't declare stb unless it's needed.
5961
7914961c 5962 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5963 (CONSTANTLIM): Remove; unused.
5964 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5965 Define only if needed.
7914961c 5966
b3967b18
PE
5967 * unexelf.c (unexec): Name an expression,
5968 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5969 Use a different way to cause a compilation error if anyone uses
5970 n rather than nn, a way that does not involve shadowing.
73366a00 5971 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5972
29a6015a
PE
5973 * deps.mk (unexalpha.o): Remove; unused.
5974
43cfc33e 5975 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5976 * unexec.h: New file.
ce701a33
PE
5977 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5978 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5979 Depend on unexec.h.
5980 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5981 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5982 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5983 Change as necessary to match prototype in unexec.h.
ce701a33 5984
01f44d5a
PE
5985 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5986 shadowing.
4f63c6bb 5987 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5988
a6670b0b
PE
5989 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5990 Rename locals to avoid shadowing.
5991
cef2010d 5992 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5993 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5994
d4d7173a
PE
5995 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5996
f08b802a
PE
5997 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5998 warning when compiling print.c.
5999
3ddb0639
PE
6000 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6001 instead of using an uninitialized var.
5ad03b97 6002 (font_sort_entities): Mark var as initialized.
3ddb0639 6003
170a2692
PE
6004 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6005
e663c700
PE
6006 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6007 pointers to constants.
89bc529a 6008 (font_parse_fcname): Remove unused vars.
7b81e2d0 6009 (font_delete_unmatched): Now static.
ea838e10 6010 (font_get_spec): Remove; unused.
13a547c6
PE
6011 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6012 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6013 Rename or move locals to avoid shadowing.
e663c700 6014
2a80c887 6015 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6016 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6017
1384fa33 6018 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6019 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6020
8b2c52e9
PE
6021 * alloc.c (mark_backtrace): Move decl from here ...
6022 * lisp.h: ... to here, so that it can be checked.
6023
475545b5 6024 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6025 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6026 (lisp_indirect_variable): Name an expression,
6027 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6028 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6029
b1349114 6030 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6031 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6032 Use const pointer when appropriate.
b1349114 6033
a2928364
PE
6034 * lisp.h (get_system_name, get_operating_system_release):
6035 Move decls here, to check interfaces.
6036 * process.c (get_operating_system_release): Move decl to lisp.h.
6037 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6038 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6039 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6040 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6041 (Fformat_time_string, Fencode_time, Finsert_char):
6042 (Ftranslate_region_internal, Fformat):
6043 Rename or remove local vars to avoid shadowing.
9710023e 6044 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6045
a415e694
PE
6046 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6047 avoid shadowing.
6048
8ef4622d
PE
6049 * lisp.h (eassert): Check that the argument compiles, even if
6050 ENABLE_CHECKING is not defined.
6051
946f9a5b
PE
6052 * data.c (Findirect_variable): Name an expression, to avoid
6053 gcc -Wbad-function-cast warning.
112396d6 6054 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6055 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6056 (Fmake_variable_buffer_local, Fmake_local_variable):
6057 Mark variables as initialized.
52746918 6058 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6059
e5aab7e7 6060 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6061 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6062 Rename locals to avoid shadowing.
dff45157
PE
6063 (mark_stack): Move local variables into the #ifdef region where
6064 they're used.
7bc26fdb
PE
6065 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6066 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6067 needed otherwise.
6068 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6069 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6070 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6071
e5aab7e7
PE
6072 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6073 avoids undefined behavior in theory.
6074
4da60324
PE
6075 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6076
88043301
PE
6077 Use functions, not macros, for up- and down-casing (Bug#8254).
6078 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6079 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6080 to use the following functions instead of these macros.
6081 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6082 EMACS_INT, since callers assume the returned value fits in int.
6083 (upcase1): Likewise, for UPCASE_TABLE.
6084 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6085 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6086 the race-condition problem in the old DOWNCASE.
88043301 6087
19ed5445
PE
6088 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6089 Rename locals to avoid shadowing.
6090 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6091 (regex_compile, re_search_2, re_match_2_internal):
6092 Remove unused local vars.
952db0d7
PE
6093 (FREE_VAR): Rewrite so as not to use empty "else",
6094 which gcc can warn about.
da053e48 6095 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6096 (RETALLOC_IF): Define only if needed.
6097 (WORDCHAR_P): Likewise. This one is never needed, but is used
6098 only in a comment talking about a compiler bug, so put inside
6099 the #if 0 of that comment.
6100 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6101 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6102 Remove; unused.
19ed5445 6103
1f3561e4 6104 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6105 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6106 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6107
ded6f8f7
PE
6108 * search.c (simple_search): Remove unused var.
6109
dbd37a95
PE
6110 * dired.c (compile_pattern): Move decl from here ...
6111 * lisp.h: ... to here, so that it can be checked.
6112 (struct re_registers): New forward decl.
6113
7e47afad
PE
6114 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6115
85f24f61
PE
6116 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6117 All uses changed.
6118 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6119 Rename locals to avoid shadowing.
5671df8f 6120 (Fvertical_motion): Mark locals as initialized.
85f24f61 6121
181aa2be 6122 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6123 (casify_region): Mark local as initialized.
181aa2be 6124
930d429c
PE
6125 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6126
7082eac6
PE
6127 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6128 New macros, so that the caller can use some names other than
6129 gcpro1, gcpro2, etc.
6130 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6131 of the new macros.
6132 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6133 argument, for consistency with GCPRO2_VAR, etc: it is now the
6134 prefix of the variable, not the variable itself. All uses
6135 changed.
38b2c076
PE
6136 * dired.c (directory_files_internal, file_name_completion):
6137 Rename locals to avoid shadowing.
6138
15206ed9
PE
6139 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6140 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6141 dired.c's scmp function, had undefined behavior.
6142 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6143 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6144 * buffer.h: ... to here, because these macros use current_buffer,
6145 and the new implementation with inline functions needs to have
6146 current_buffer in scope now, rather than later when the macros
6147 are used.
6148 (downcase, upcase1): New static inline functions.
6149 (DOWNCASE, UPCASE1): Reimplement using these functions.
6150 This avoids undefined behavior in expressions like
6151 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6152 from race conditions in accessing the global variables
6153 case_temp1 and case_temp2.
6154 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6155 * lisp.h (case_temp1, case_temp2): Remove their decls.
6156 * character.h (ASCII_CHAR_P): Move from here ...
6157 * lisp.h: ... to here, so that the inline functions mentioned
6158 above can use them.
6159
4a6bea26
PE
6160 * dired.c (directory_files_internal_unwind): Now static.
6161
f14b7e14
PE
6162 * fileio.c (file_name_as_directory, directory_file_name):
6163 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6164 Now static.
2893f146
PE
6165 (file_name_as_directory): Use const pointers when appropriate.
6166 (Fexpand_file_name): Likewise. In particular, newdir might
6167 point at constant storage, so make it a const pointer.
fd4ead52 6168 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6169 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6170 signedness issues.
f839df0c
PE
6171 (Fset_file_times, Finsert_file_contents, auto_save_error):
6172 Rename locals to avoid shadowing.
f14b7e14 6173
5716756e 6174 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6175 (Ftry_completion, Fall_completions): Rename or remove locals
6176 to avoid shadowing.
5716756e 6177
b4c3046a
PE
6178 * marker.c (bytepos_to_charpos): Remove; unused.
6179
b45db522
PE
6180 * lisp.h (verify_bytepos, count_markers): New decls,
6181 so that gcc does not warn that these functions aren't declared.
6182
85876d07
PE
6183 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6184 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6185 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6186 (copy_text): Remove unused local var.
85876d07 6187
03d78a21 6188 * filelock.c (within_one_second): Now static.
b3dd38ab 6189 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6190
5df8f01b
PE
6191 * buffer.c (fix_overlays_before): Mark locals as initialized.
6192 (fix_start_end_in_overlays): Likewise. This function should be
6193 simplified by using pointers-to-pointers, but that's a different
6194 matter.
b1d876f1 6195 (switch_to_buffer_1): Now static.
8f54f30a
PE
6196 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6197 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6198
a70072c9 6199 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6200 Fix pointer signedness issue.
edced198
PE
6201 (sys_subshell): Mark local as volatile if checking for lint,
6202 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6203 (MAXPATHLEN): Define only if needed.
a70072c9 6204
a0977c44
PE
6205 * process.c (serial_open, serial_configure): Move decls from here ...
6206 * systty.h: ... to here, so that they can be checked.
6207
a884fdcc
PE
6208 * fns.c (get_random, seed_random): Move extern decls from here ...
6209 * lisp.h: ... to here, so that they can be checked.
6210
604efe86 6211 * sysdep.c (reset_io): Now static.
b8950c94 6212 (wait_for_termination_signal): Remove; unused.
604efe86 6213
38fc62d9
PE
6214 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6215 (copy_keymap_item, append_key, push_text_char_description):
6216 Now static.
1004a21a 6217 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6218 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6219 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6220 (describe_map_tree):
6221 Rename locals to avoid shadowing.
38fc62d9 6222
2f2650da
PE
6223 * keyboard.c: Declare functions static if they are not used elsewhere.
6224 (echo_char, echo_dash, cmd_error, top_level_2):
6225 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6226 (read_char, kbd_buffer_get_event, make_lispy_position):
6227 (make_lispy_event, make_lispy_movement, apply_modifiers):
6228 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6229 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6230 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6231 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6232 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6233
a053e86c 6234 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6235 (mark_kboards): Move decl here ...
6236 * alloc.c (mark_kboards): ... from here.
a053e86c 6237
4752793e
PE
6238 * lisp.h (force_auto_save_soon): New decl.
6239
74f10ca7 6240 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6241 (DEFINE_DUMMY_FUNCTION): New macro.
6242 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6243 Use it.
c03cd23f
PE
6244 (main): Add casts to avoid warnings
6245 if GCC considers string literals to be constants.
74f10ca7 6246
022e70d4
PE
6247 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6248
59d6fe83
PE
6249 * dbusbind.c: Pointer signedness fixes.
6250 (xd_signature, xd_append_arg, xd_initialize):
6251 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6252 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6253 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6254 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6255
78320123
PE
6256 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6257 if GCC considers string literals to be constants.
49cebcca 6258 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6259
35ac2a97
SM
62602011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6261
fb103ca9
SM
6262 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6263 (print_preprocess, print_object): New macro to fix last change.
6264
35ac2a97
SM
6265 * print.c (print_preprocess): Don't forget font objects.
6266
62973b41
JB
62672011-03-16 Juanma Barranquero <lekktu@gmail.com>
6268
6269 * emacs.c (USAGE3): Doc fixes.
6270
0e48bb22
AS
62712011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6272
6273 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6274 structure.
6275
7684e57b
JB
62762011-03-14 Juanma Barranquero <lekktu@gmail.com>
6277
6278 * lisp.h (VWindow_system, Qfile_name_history):
6279 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6280 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6281 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6282
6283 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6284 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6285
6286 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6287 * w32console.c (detect_input_pending, read_input_pending)
6288 (encode_terminal_code):
6289 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6290 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6291 (w32_system_caret_y, Qfile_name_history):
6292 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6293 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6294 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6295 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6296 * w32proc.c (Qlocal, report_file_error):
6297 * w32term.c (Vwindow_system, updating_frame):
6298 * w32uniscribe.c (initialized, uniscribe_font_driver):
6299 Remove unneeded extern declarations.
6300
2aa46d6c
CY
63012011-03-14 Chong Yidong <cyd@stupidchicken.com>
6302
c96bbc66 6303 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6304
cffc6f3b
CY
63052011-03-13 Chong Yidong <cyd@stupidchicken.com>
6306
6307 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6308 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6309 These macros can no longer be used for assignment.
6310
44f230aa
SM
6311 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6312 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6313 (record_buffer_markers, fetch_buffer_markers): New functions for
6314 recording and fetching special buffer markers.
6315 (set_buffer_internal_1, set_buffer_temp): Use them.
6316
6317 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6318
6319 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6320
6321 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6322 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6323
6324 * xdisp.c (hscroll_window_tree):
6325 (reconsider_clip_changes): Use PT instead of BUF_PT.
6326
d251f04b
EZ
63272011-03-13 Eli Zaretskii <eliz@gnu.org>
6328
6329 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6330 $(EMACS_ROOT)/lib/intprops.h.
6331
f0c77cd1
PE
63322011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6333
3eca4629
PE
6334 Fix more problems found by GCC 4.5.2's static checks.
6335
7c86ee98
PE
6336 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6337 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6338 (xg_free_frame_widgets): Make it clear that a local variable is
6339 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6340 (gdk_window_get_screen): Make it clear that this macro is needed
6341 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6342 (int_gtk_range_get_value): New function, which avoids a diagnostic
6343 from gcc -Wbad-function-cast.
6344 (xg_set_toolkit_scroll_bar_thumb): Use it.
6345 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6346 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6347 (get_utf8_string, xg_get_file_with_chooser):
6348 Rename locals to avoid shadowing.
6349 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6350
41729b81
PE
6351 * xgselect.c (xg_select): Remove unused var.
6352
f0c77cd1
PE
6353 * image.c (four_corners_best): Mark locals as initialized.
6354 (gif_load): Initialize transparent_p to zero (Bug#8238).
6355 Mark another local as initialized.
ec6cf4c6 6356 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6357
ce0ad53d 6358 * image.c (clear_image_cache): Now static.
d5d5a617 6359 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6360 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6361 (x_edge_detection): Remove unnecessary cast that
6362 gcc -Wbad-function-cast diagnoses.
2037898d 6363 (gif_load): Fix pointer signedness.
6ae141d6
PE
6364 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6365 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6366
33383987 63672011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6368
d32df629
PE
6369 Improve quality of tests for time stamp overflow.
6370 For example, without this patch (encode-time 0 0 0 1 1
6371 1152921504606846976) returns the obviously-bogus value (-948597
6372 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6373 reports time overflow. See
6374 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6375 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6376 * editfns.c: Include limits.h and intprops.h.
6377 (TIME_T_MIN, TIME_T_MAX): New macros.
6378 (time_overflow): Move earlier, to before first use.
6379 (hi_time, lo_time): New functions, for an accurate test for
6380 out-of-range times.
6381 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6382 (Fget_internal_run_time): Don't assume time_t fits in int.
6383 (make_time): Use list2 instead of Fcons twice.
6384 (Fdecode_time): More accurate test for out-of-range times.
6385 (check_tm_member): New function.
6386 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6387 (lisp_time_argument): Don't rely on undefined left-shift and
6388 right-shift behavior when checking for time stamp overflow.
8be6f318 6389
fe31d94c
PE
6390 * editfns.c (time_overflow): New function, refactoring common code.
6391 (Fformat_time_string, Fdecode_time, Fencode_time):
6392 (Fcurrent_time_string): Use it.
6393
8be6f318
PE
6394 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6395 * dired.c (make_time): Move to ...
6396 * editfns.c (make_time): ... here.
6397 * systime.h: Note the move.
6398
09d9db2c 63992011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6400
126bc0dc
YM
6401 * fringe.c (update_window_fringes): Remove unused variables.
6402
c47cbdfd
YM
6403 * unexmacosx.c (copy_data_segment): Also copy __got section.
6404 (Bug#8223)
6405
7ac80be9
EZ
64062011-03-12 Eli Zaretskii <eliz@gnu.org>
6407
c96bbc66 6408 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6409 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6410 Constify `char *' arguments and their references according to
6411 prototypes in tparam.h.
6412
ecb0f94d 6413 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6414
7ac80be9
EZ
6415 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6416 Adapt all references accordingly.
6417
6418 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6419
ef1fd07e
TT
64202011-03-11 Tom Tromey <tromey@redhat.com>
6421
6422 * buffer.c (syms_of_buffer): Remove obsolete comment.
6423
7ef4b50c
EZ
64242011-03-11 Eli Zaretskii <eliz@gnu.org>
6425
6426 * termhooks.h (encode_terminal_code): Declare prototype.
6427
6428 * msdos.c (encode_terminal_code): Don't declare prototype.
6429
6430 * term.c (encode_terminal_code): Now external again, used by
6431 w32console.c and msdos.c.
6432
44f230aa
SM
6433 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6434 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6435
4b1ec863 64362011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6437
1714f52b 6438 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6439
4b1ec863
PE
6440 * fringe.c (update_window_fringes): Mark locals as initialized
6441 (Bug#8227).
6442 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6443
524c7aa6
PE
6444 * alloc.c (mark_fringe_data): Move decl from here ...
6445 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6446 to check its interface.
6447 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6448
a5c0af81 6449 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6450 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6451 (fontset_font): Mark local as initialized.
a9a06e0b 6452 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6453
b4716021
PE
6454 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6455
811e9bac 6456 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6457 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6458 (x_own_selection, Fx_disown_selection_internal): Rename locals
6459 to avoid shadowing.
6460 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6461
7e3ab302
PE
6462 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6463 so that the caller can use some name other than gcpro1.
6464 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6465 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6466 (Fx_backspace_delete_keys_p):
6467 Use them to avoid shadowing, and rename vars to avoid shadowing.
6468 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6469 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6470 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6471 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6472 Remove unused locals.
7e3ab302
PE
6473 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6474 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6475 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6476 macros.
f78faa98 6477
e2b13473
PE
6478 * xterm.h (x_mouse_leave): New decl.
6479
77f23912
PE
6480 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6481 Remove unused functions.
cdf4ba58
PE
6482 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6483 (x_calc_absolute_position): Now static.
7411c686 6484 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6485 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6486 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6487 unless they are used.
38d0b34a
PE
6488 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6489 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6490 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6491 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6492 (x_error_catcher, x_connection_closed, x_error_handler):
6493 (x_error_quitter, xembed_send_message, x_iconify_frame):
6494 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6495 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6496 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6497
44f230aa
SM
6498 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6499 Rename or move locals to avoid shadowing.
6b463e58 6500 (tty_defined_color, merge_face_heights): Now static.
5967d051 6501 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6502 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6503 does not deduce is never used uninitialized.
73719eba
PE
6504 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6505 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6506
426994c3 6507 * terminal.c (store_terminal_param): Now static.
5489860b 6508
032f1620 6509 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6510 (set_frame_menubar): Remove unused local.
d4323972 6511 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6512 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6513 since they might point to immutable storage.
281585b0
PE
6514 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6515 since it's unused otherwise.
032f1620 6516
367c19e5 6517 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6518 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6519 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6520 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6521 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6522 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6523 does not deduce are never used uninitialized.
70739cbe 6524
07b48fa9
PE
6525 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6526
8868a238 6527 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6528 * window.c (window_loop, size_window):
6529 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6530
7e5cf297 6531 * window.c (display_buffer): Now static.
d6550a9f
PE
6532 (size_window): Mark variables that gcc -Wuninitialized
6533 does not deduce are never used uninitialized.
a586633d
PE
6534 * window.h (check_all_windows): New decl, to forestall
6535 gcc -Wmissing-prototypes diagnostic.
5b555da1 6536 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6537
f6095868
PE
6538 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6539 shadowing.
6540 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6541 Include <limits.h>.
6542 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6543 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6544 (load_charset_map): Mark variables that gcc -Wuninitialized
6545 does not deduce are never used uninitialized.
53df7c11 6546 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6547
f38b440c
PE
6548 * coding.c (coding_set_source, coding_set_destination):
6549 Use "else { /* comment */ }" rather than "else /* comment */;"
6550 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6551 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6552 a block, when the outer 'i' will do.
6553 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6554 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6555 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6556 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6557 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6558 Rename locals to avoid shadowing.
6559 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6560 * coding.c (emacs_mule_char, encode_invocation_designation):
6561 Now static, since they're not used elsewhere.
413bb2db 6562 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6563 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6564 (decode_coding_emacs_mule): Mark variables that gcc
6565 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6566 (detect_coding_iso_2022): Initialize a local variable that might
6567 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6568 this initialization is needed. (Bug#8211)
5f58e762
PE
6569 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6570 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6571 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6572 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6573 Remove unused macros.
f38b440c 6574
232b38b9 6575 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6576 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6577 * character.c (string_count_byte8): Likewise.
232b38b9 6578
fb90da1b
PE
6579 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6580 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6581
fb93dbc2
PE
6582 * chartab.c (copy_sub_char_table): Now static, since it's not used
6583 elsewhere.
5c156ace
PE
6584 (sub_char_table_ref_and_range, char_table_ref_and_range):
6585 Rename locals to avoid shadowing.
bbcd0949 6586 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6587
7d3b3862 6588 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6589 (BIDI_BOB): Remove unused macro.
7d3b3862 6590
6be7d3da
PE
6591 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6592 deduce are never used uninitialized.
c2ed9c8b 6593 * term.c (encode_terminal_code): Likewise.
6be7d3da 6594
75f8807f 6595 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6596
50938595
PE
6597 * tparam.h: New file.
6598 * term.c, tparam.h: Include it.
6599 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6600 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6601 Move these decls to tparam.h, and make them agree with what
6602 is actually in tparam.c. The previous trick of using incompatible
6603 decls in different modules does not conform to the C standard.
6604 All callers of tparam changed to use tparam's actual API.
6605 * tparam.c (tparam1, tparam, tgoto):
6606 Use const pointers where appropriate.
6607
fbceeba2
PE
6608 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6609 * cm.h (struct cm): Likewise.
6610 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6611 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6612 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6613 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6614 (turn_on_face, init_tty): Likewise.
6615 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6616
7f3f1250
PE
6617 * term.c (term_mouse_position): Rename local to avoid shadowing.
6618
e6ca6543
PE
6619 * alloc.c (mark_ttys): Move decl from here ...
6620 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6621
c40f8d15
AS
66222011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6623
6624 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6625
cfe0661d
JB
66262011-03-09 Juanma Barranquero <lekktu@gmail.com>
6627
6628 * search.c (compile_pattern_1): Remove argument regp, unused since
6629 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6630 (compile_pattern): Don't pass it.
6631
0afb4571
J
66322011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6633
6634 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6635 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6636 for ! HAVE_GTK3.
6637 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6638
6639 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6640
6641 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6642 gdk_window_get_screen, gdk_window_get_geometry,
6643 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6644 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6645 (xg_get_pixbuf_from_pixmap): New function.
6646 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6647 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6648 Call xg_get_pixbuf_from_pixmap instead of
6649 gdk_pixbuf_get_from_drawable.
6650 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6651 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6652 (xg_check_special_colors): Use GtkStyleContext and its functions
6653 for HAVE_GTK3.
6654 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6655 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6656 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6657 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6658 Call gtk_widget_get_preferred_size.
0afb4571
J
6659 (xg_frame_resized): gdk_window_get_geometry only takes 5
6660 parameters.
44f230aa
SM
6661 (xg_win_to_widget, xg_event_is_for_menubar):
6662 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6663 (xg_set_widget_bg): New function.
6664 (delete_cb): New function.
895009e1 6665 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6666 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6667 (xg_set_background_color): Call xg_set_widget_bg.
6668 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6669 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6670 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6671 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6672 if ! HAVE_GTK3.
6673 (update_frame_tool_bar): Call gtk_widget_hide.
6674 (xg_initialize): Use GDK_KEY_g.
6675
6676 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6677 if ! HAVE_GTK3
6678 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6679
6680 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6681 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6682 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6683
1c2cc4ef
JB
66842011-03-08 Juanma Barranquero <lekktu@gmail.com>
6685
6686 * w32xfns.c (select_palette): Check success of RealizePalette against
6687 GDI_ERROR, not zero.
6688
33383987 6689See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6690
6691;; Local Variables:
6692;; coding: utf-8
aac0c6e3
MR
6693;; End:
6694
33383987 6695 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6696
6697 This file is part of GNU Emacs.
6698
6699 GNU Emacs is free software: you can redistribute it and/or modify
6700 it under the terms of the GNU General Public License as published by
6701 the Free Software Foundation, either version 3 of the License, or
6702 (at your option) any later version.
6703
6704 GNU Emacs is distributed in the hope that it will be useful,
6705 but WITHOUT ANY WARRANTY; without even the implied warranty of
6706 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6707 GNU General Public License for more details.
6708
6709 You should have received a copy of the GNU General Public License
6710 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.