1 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5 from an Org mode buffer to a Speedbar frame.
7 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8 a composition, take its buffer position from IT->cmp_it.charpos.
9 Fixes cursor positioning at the beginning of a line that begins
10 with a composed character.
12 2011-08-18 Eli Zaretskii <eliz@gnu.org>
14 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
15 character bidirectional type, use STRONG_L instead. Fixes crashes
16 in a buffer produced by `describe-categories'.
18 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
19 members before the level stack, so they would be saved and
20 restored when copying iterator state. Fixes incorrect reordering
21 around TABs covered by display properties.
23 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
25 * process.c (Fnetwork_interface_list): Correctly determine buffer
28 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
30 * eval.c (internal_condition_case, internal_condition_case_1)
31 (internal_condition_case_2, internal_condition_case_n): Remove
32 unnecessary aborts (Bug#9081).
34 2011-08-17 Eli Zaretskii <eliz@gnu.org>
36 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
37 has no `load' handler, try opening the file locally. (Bug#9311)
39 2011-08-16 Ken Brown <kbrown@cornell.edu>
41 * gmalloc.c: Expand comment.
43 2011-08-16 Eli Zaretskii <eliz@gnu.org>
45 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
46 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
48 2011-08-16 Ken Brown <kbrown@cornell.edu>
50 Fix memory allocation problems in Cygwin build (Bug#9273).
52 * unexcw.c ( __malloc_initialized): Declare external variable.
53 (fixup_executable): Force the dumped emacs to reinitialize malloc.
55 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
57 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
59 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
61 [CYGWIN] (special_realloc): New function.
62 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
63 requests to realloc storage in the static heap.
65 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
67 * bidi.c (bidi_initialize): Remove unused local.
69 2011-08-15 Eli Zaretskii <eliz@gnu.org>
71 * biditype.h: File removed.
73 * bidimirror.h: File removed.
75 * deps.mk (bidi.o): Remove biditype.h and
78 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
81 * dispextern.h: Fix a typo in the comment to bidi_type_t.
83 * chartab.c: Improve commentary for the uniprop_table API.
85 * bidi.c (bidi_paragraph_init): Support zero value of
86 bidi_ignore_explicit_marks_for_paragraph_level.
87 (bidi_initialize): Use uniprop_table instead of including
88 biditype.h and bidimirror.h.
90 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
91 coordinates of the iterator when restoring from ppos_it.
94 2011-08-14 Kenichi Handa <handa@m17n.org>
96 * process.c (create_process): Call setup_process_coding_systems
97 after the pid of the process is set to -1 (Bug#8162).
99 2011-08-14 Eli Zaretskii <eliz@gnu.org>
101 * xdisp.c (move_it_in_display_line_to): Don't invoke
102 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
103 ppos_it. Fixes vertical cursor motion when line beginning is
104 covered by an image. (Bug#9296)
106 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
108 * nsterm.h (ns_run_ascript): Declare.
109 (NSAPP_DATA2_RUNASSCRIPT): Define.
111 * nsfns.m (as_script, as_result, as_status): New static variables.
112 (ns_run_ascript): New function.
113 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
114 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
115 the event loop. Get status from as_status (Bug#7276).
117 * nsterm.m (sendEvent): If event is NSApplicationDefined and
118 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
119 the event loop (Bug#7276).
121 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
123 * gnutls.c (QCgnutls_bootprop_priority)
124 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
125 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
126 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
127 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
128 (QCgnutls_bootprop_verify_hostname_error)
129 (QCgnutls_bootprop_callbacks_verify): Rename from
130 Qgnutls_bootprop_..., all uses changed.
132 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
135 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
137 * xfaces.c (Qframe_set_background_mode): Now static.
138 * dispextern.h (Qframe_set_background_mode): Remove decl.
140 * process.c (Fnetwork_interface_info): Declare local only if needed.
142 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
144 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
145 (Fnetwork_interface_list): Allocate in increments of bytes instead
146 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
147 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
149 (struct ifflag_def): notrailers is smart on OSX.
150 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
151 Get hardware address with getifaddrs if available.
153 2011-08-12 Eli Zaretskii <eliz@gnu.org>
155 * xdisp.c (iterate_out_of_display_property): xassert that
156 IT->position is set to within IT->object's boundaries. Break from
157 the loop as soon as EOB is reached; avoids infloops in redisplay
158 when IT->position is set up wrongly due to some bug. Set
159 IT->current to match the bidi iterator unconditionally.
160 (push_display_prop): Allow GET_FROM_STRING as IT->method on
161 entry. Force push_it to save on the stack the current
162 buffer/string position, to be restored by pop_it. Fix flags in
163 the iterator structure wrt the object coming from a display
164 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
165 properties. (Bug#9284)
167 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
169 * fontset.c (fontset_get_font_group): Add proper type checks.
172 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
174 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
175 and LC_VERSION_MIN_MACOSX.
176 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
177 (dump_it) [LC_FUNCTION_STARTS]: Use it.
179 2011-08-08 Eli Zaretskii <eliz@gnu.org>
181 * xdisp.c (forward_to_next_line_start): Allow to use the
182 no-display-properties-and-no-overlays under bidi display. Set
183 disp_pos in the bidi iterator to avoid searches for display
184 properties and overlays.
186 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
188 * editfns.c (Fset_time_zone_rule): Document relationship with the
191 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
192 the font entity extracted from the cache (Bug#8109).
194 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
196 * composite.c (autocmp_chars): Don't reset point. That is done by
197 restore_point_unwind (Bug#5984).
199 2011-08-07 Juri Linkov <juri@jurta.org>
201 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
202 to show the arg `TIME' instead of `TIMEVAL'.
204 2011-08-06 Eli Zaretskii <eliz@gnu.org>
206 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
207 display property strides EOL and includes a newline, as in
208 longlines-mode. (Bug#9254)
209 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
210 word-wrap under bidirectional display. (Bug#9224)
212 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
213 is non-zero, even if the data buffer is NULL. Fixes a crash in
214 vertical-motion with longlines-mode. (Bug#9254)
216 2011-08-05 Eli Zaretskii <eliz@gnu.org>
218 * bidi.c <bidi_cache_total_alloc>: Now static.
219 (bidi_initialize): Initialize bidi_cache_total_alloc.
221 *xdisp.c (display_line): Release buffer allocated for shelved bidi
224 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
225 amount allocated this far in `bidi_cache_total_alloc'.
226 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
227 non-zero, only free the data buffer without restoring the cache
228 contents. All callers changed.
230 * dispextern.h (bidi_unshelve_cache): Update prototype.
232 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
233 (move_it_in_display_line, move_it_to)
234 (move_it_vertically_backward, move_it_by_lines): Replace the call
235 to xfree to an equivalent call to bidi_unshelve_cache.
236 (move_it_in_display_line_to): Fix logic of returning
237 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
239 2011-08-05 Eli Zaretskii <eliz@gnu.org>
241 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
242 came from a string character with a `cursor' property. (Bug#9229)
244 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
246 * Makefile.in (LIB_PTHREAD): New variable.
247 (LIBES): Add LIB_PTHREAD (Bug#9216).
249 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
250 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
252 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
254 * regex.c (re_iswctype): Remove some redundant boolean
257 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
259 * xterm.c (x_find_topmost_parent): New function.
260 (x_set_frame_alpha): Find topmost parent window with
261 x_find_topmost_parent and set the property there also (bug#9181).
262 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
264 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
266 * callproc.c (Fcall_process): Avoid vfork clobbering
267 the local vars buffer, coding_systems, current_dir.
269 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
271 * keymap.c (Fmake_composed_keymap): Move to subr.el.
273 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
275 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
276 so that it is not optimized away.
278 * xdisp.c (compute_display_string_pos): Remove unused local.
280 2011-08-02 Eli Zaretskii <eliz@gnu.org>
282 Fix slow cursor motion and scrolling in large buffers with
283 selective display, like Org Mode buffers. (Bug#9218)
285 * dispextern.h (struct bidi_it): New member disp_prop_p.
287 * xdisp.c: Remove one-slot cache of display string positions.
288 (compute_display_string_pos): Accept an additional argument
289 DISP_PROP_P; callers changed. Scan at most 5K characters forward
290 for a display string or property. If found, set DISP_PROP_P
293 * bidi.c (bidi_fetch_char): Accept an additional argument
294 DISP_PROP_P, and pass it to compute_display_string_pos.
295 Only handle text covered by a display string if DISP_PROP_P is returned
296 non-zero. All callers of bidi_fetch_char changed.
298 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
300 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
302 2010-12-03 Don March <don@ohspite.net>
304 * keymap.c (Fdefine_key): Fix non-prefix key error message when
305 last character M-[char] is translated to ESC [char] (bug#7541).
307 2011-08-02 Kenichi Handa <handa@m17n.org>
309 * lisp.h (uniprop_table): Extern it.
311 * chartab.c (uniprop_table): Make it non-static.
313 2011-08-01 Eli Zaretskii <eliz@gnu.org>
315 * xdisp.c (forward_to_next_line_start): Accept additional argument
316 BIDI_IT_PREV, and store into it the state of the bidi iterator had
318 (reseat_at_next_visible_line_start): Use the bidi iterator state
319 returned by forward_to_next_line_start to restore the state of
320 it->bidi_it after backing up to previous newline. (Bug#9212)
322 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
324 * regex.c (re_comp): Protoize.
325 (re_exec): Fix return type.
326 (regexec): Fix type of `ret'. (Bug#9203)
328 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
330 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
331 This is needed if max-image-size is a floating-point number.
333 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
335 * print.c (print_object): Print empty symbol as ##.
337 * lread.c (read1): Read ## as empty symbol.
339 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
341 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
342 setting frame foreground color (Bug#9175).
343 (x_set_background_color): Likewise.
345 * nsmenu.m (-setText): Size tooltip dimensions precisely to
347 (EmacsTooltip -init): Remove bezels and add shadows to
350 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
351 or scroll bar (Bug#8470).
353 * nsfont.m (nsfont_open): Remove assignment to voffset and
354 unnecessary vars hshink, expand, hd, full_height, min_height.
355 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
357 * nsterm.h (nsfont_info): Remove voffset field.
359 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
361 Implement strike-through and overline on NextStep (Bug#8863).
363 * nsfont.m (nsfont_open): Use underline position provided by font,
364 instead of hard-coded value of 2.
365 (nsfont_draw): Call ns_draw_text_decoration instead.
367 * nsterm.h: Add declaration for ns_draw_text_decoration.
369 * nsterm.m (ns_draw_text_decoration): New function for drawing
370 underline, overline, and strike-through.
371 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
372 ns_draw_text_decoration. Change treatment of cursor drawing to
373 accomodate underlining, etc.
375 2011-07-28 Eli Zaretskii <eliz@gnu.org>
377 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
380 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
382 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
383 Without this fix, if a signal arrives just after memory fills up,
384 'malloc' might be invoked reentrantly.
386 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
387 In other words, assume that every image size is allowed, on non-X
388 hosts. This assumption is probably wrong, but it lets Emacs compile.
390 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
392 * regex.c (re_iswctype): Convert return values to boolean.
394 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
396 * xdisp.c (compute_display_string_pos): Don't use cached display
397 string position if the buffer had its restriction changed.
400 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
402 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
404 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
406 Integer signedness and overflow and related fixes. (Bug#9079)
408 * bidi.c: Integer size and overflow fixes.
409 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
410 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
411 (bidi_cache_find_level_change, bidi_cache_ensure_space)
412 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
413 (bidi_find_other_level_edge):
414 Use ptrdiff_t instead of EMACS_INT where either will do.
415 This works better on 32-bit hosts configured --with-wide-int.
416 (bidi_cache_ensure_space): Check for size-calculation overflow.
417 Use % rather than repeated addition, for better worst-case speed.
418 Don't set bidi_cache_size until after xrealloc returns, because it
420 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
421 (bidi_cache_ensure_space): Also check that the bidi cache size
422 does not exceed that of the largest Lisp string or buffer. See Eli
423 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
425 * alloc.c (__malloc_size_t): Remove.
426 All uses replaced by size_t. See Andreas Schwab's note
427 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
429 * image.c: Improve checking for integer overflow.
430 (check_image_size): Assume that f is nonnull, since
431 it is always nonnull in practice. This is one less thing to
432 worry about when checking for integer overflow later.
433 (x_check_image_size): New function, which checks for integer
434 overflow issues inside X.
435 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
436 This removes the need for a memory_full check.
437 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
438 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
439 (xbm_read_bitmap_data): Change locals back to 'int', since
440 their values must fit in 'int'.
441 (xpm_load_image, png_load, tiff_load):
442 Invoke x_create_x_image_and_pixmap earlier,
443 to avoid much needless work if the image is too large.
444 (tiff_load): Treat overly large images as if
445 x_create_x_image_and_pixmap failed, not as malloc failures.
446 (gs_load): Use x_check_image_size.
448 * gtkutil.c: Omit integer casts.
449 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
450 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
452 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
454 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
455 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
456 would wrongly return t on a 64-bit host.
458 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
459 The plain *_OVERFLOW macros run afoul of GCC bug 49705
460 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
461 and therefore cause GCC to emit a bogus diagnostic in some cases.
463 * image.c: Integer signedness and overflow and related fixes.
464 This is not an exhaustive set of fixes, but it's time to
465 record what I've got.
466 (lookup_pixel_color, check_image_size): Remove redundant decls.
467 (check_image_size): Don't assume that arbitrary EMACS_INT values
468 fit in 'int', or that arbitrary 'double' values fit in 'int'.
469 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
470 (tiff_load, imagemagick_load_image):
471 Check for overflow in size calculations.
472 (x_create_x_image_and_pixmap): Remove unnecessary test for
473 xmalloc returning NULL; that can't happen.
474 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
475 (xpm_color_bucket): Use better integer hashing function.
476 (xpm_cache_color): Don't possibly over-allocate memory.
477 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
479 Use ptrdiff_t, not int or size_t, to record sizes.
480 (png_load): Don't assume values greater than 2**31 fit in 'int'.
481 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
482 either works, as we prefer signed integers.
483 (tiff_read_from_memory, tiff_write_from_memory):
484 Return tsize_t, not size_t, since that's what the TIFF API wants.
485 (tiff_read_from_memory): Don't fail simply because the read would
486 go past EOF; instead, return a short read.
487 (tiff_load): Omit no-longer-needed casts.
488 (Fimagemagick_types): Don't assume size fits into 'int'.
490 Improve hashing quality when configured --with-wide-int.
491 * fns.c (hash_string): New function, taken from sxhash_string.
492 Do not discard information about ASCII character case; this
493 discarding is no longer needed.
494 (sxhash-string): Use it. Change sig to match it. Caller changed.
495 * lisp.h: Declare it.
496 * lread.c (hash_string): Remove, since we now use fns.c's version.
497 The fns.c version returns a wider integer if --with-wide-int is
498 specified, so this should help the quality of the hashing a bit.
500 * emacs.c: Integer overflow minor fix.
501 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
502 Define only if GNU_LINUX.
503 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
505 * dispnew.c: Integer signedness and overflow fixes.
506 Remove unnecessary forward decls, that were a maintenance hassle.
507 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
509 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
510 (scrolling_window): Use ptrdiff_t, not int, for byte count.
511 (prepare_desired_row, line_draw_cost):
512 Use int, not unsigned, where either works.
513 (save_current_matrix, restore_current_matrix):
514 Use ptrdiff_t, not size_t, where either works.
515 (init_display): Check for overflow more accurately, and without
516 relying on undefined behavior.
518 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
519 Remove, replacing with the new symbols in lisp.h. All uses changed.
520 * fileio.c (make_temp_name):
521 * filelock.c (lock_file_1, lock_file):
522 * xdisp.c (message_dolog):
523 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
524 Use pMd etc. instead.
525 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
526 replacing the pWIDE etc. symbols removed from editfns.c.
528 * keyboard.h (num_input_events): Now uintmax_t.
529 This is (very slightly) less likely to mess up due to wraparound.
532 * buffer.c: Integer signedness fixes.
533 (alloc_buffer_text, enlarge_buffer_text):
534 Use ptrdiff_t rather than size_t when either will do, as we prefer
537 * alloc.c: Integer signedness and overflow fixes.
538 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
539 (__malloc_size_t): Default to size_t, not to int.
540 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
541 (Fgarbage_collect, mark_object_loop_halt, mark_object):
542 Prefer ptrdiff_t to size_t when either would do, as we prefer
544 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
545 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
546 Now const. Initialize with values that are in range even if char
548 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
549 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
550 These functions do the right thing with sizes > 2**32.
551 (check_depth): Now ptrdiff_t, not int.
552 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
553 Adjust to new way of storing sizes. Check for size overflow bugs
555 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
556 slightly wrong anyway, as it missed one instance of
557 XMALLOC_OVERRUN_CHECK_OVERHEAD.
558 (refill_memory_reserve): Omit needless cast to size_t.
559 (mark_object_loop_halt): Mark as externally visible.
561 * xselect.c: Integer signedness and overflow fixes.
562 (Fx_register_dnd_atom, x_handle_dnd_message):
563 Use ptrdiff_t, not size_t, since we prefer signed.
564 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
565 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
566 x_dnd_atoms_size and x_dnd_atoms_length.
568 * doprnt.c: Prefer signed to unsigned when either works.
572 * xdisp.c (vmessage):
573 Use ptrdiff_t, not size_t, when using or implementing doprnt,
574 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
575 prefer signed arithmetic to avoid comparison confusion.
576 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
579 Assume freestanding C89 headers, string.h, stdlib.h.
580 * data.c, doprnt.c, floatfns.c, print.c:
581 Include float.h unconditionally.
582 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
583 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
584 * regex.c: Likewise for stddef.h, string.h.
585 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
586 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
587 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
588 (STDC_HEADERS): Remove obsolete defines.
589 * sysdep.c: Include limits.h unconditionally.
591 Assume support for memcmp, memcpy, memmove, memset.
592 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
593 * regex.c (memcmp, memcpy):
594 Remove; we assume C89 now.
596 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
597 (__malloc_safe_bcopy): Remove; no longer needed.
599 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
600 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
601 well either way, and we prefer signed to unsigned.
603 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
605 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
606 closes the connection while we're reading (bug#9182).
608 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
610 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
611 are specified (Bug#9168).
613 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
615 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
616 Found by GCC static checking and --with-wide-int on a 32-bit host.
618 2011-07-25 Eli Zaretskii <eliz@gnu.org>
620 * xdisp.c (compute_display_string_pos): Fix logic of caching
621 previous display string position. Initialize cached_prev_pos to
622 -1. Fixes slow-down at the beginning of a buffer.
624 2011-07-24 Eli Zaretskii <eliz@gnu.org>
626 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
627 for attrs[LFACE_FONTSET_INDEX].
629 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
631 * xml.c (parse_region): Remove unused local
632 that was recently introduced.
634 2011-07-23 Eli Zaretskii <eliz@gnu.org>
636 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
637 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
639 * xdisp.c (move_it_in_display_line_to): Record the best matching
640 position for TO_CHARPOS while scanning the line, and restore it on
641 exit if none of the characters scanned was an exact match.
642 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
643 when exact match is impossible due to invisible text, and the
646 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
648 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
651 2011-07-22 Eli Zaretskii <eliz@gnu.org>
653 Fix a significant slow-down of cursor motion with C-n, C-p,
654 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
655 auto-repeat under bidi redisplay in fontified buffers.
656 * xdisp.c (compute_stop_pos_backwards): New function.
657 (next_element_from_buffer): Call compute_stop_pos_backwards to
658 find a suitable prev_stop when we find ourselves before
660 (reseat): Don't look for prev_stop, as that could mean a very long
662 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
663 <cached_disp_overlay_modiff>: Cache for last found display string
665 (compute_display_string_pos): Return the cached position if asked
666 about the same buffer in the same area of character positions, and
667 the buffer wasn't changed since the time the display string
670 2011-07-22 Eli Zaretskii <eliz@gnu.org>
672 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
673 is an integer, which is important for empty lines. (Bug#9149)
675 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
677 * frame.c (Fmodify_frame_parameters): In tty case, update the
678 default face if necessary (Bug#4238).
680 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
682 * editfns.c (Fstring_to_char): No need to explain what a character
683 is in the docstring (Bug#6576).
685 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
687 * xml.c (parse_region): Make sure we always return a tree.
689 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
691 * xml.c (parse_region): If a document contains only comments,
694 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
696 * xml.c (make_dom): Return comments, too.
698 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
701 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
702 and the surrounding thread.
703 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
704 rather than fgets, and retry after EINTR. Otherwise, 'emacs
705 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
707 * s/openbsd.h (BROKEN_SIGIO): Define.
708 * unexelf.c (unexec) [__OpenBSD__]:
709 Don't update the .mdebug section of the Alpha COFF symbol table.
711 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
713 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
716 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
718 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
719 This fixes some race conditions on the permissions of any newly
722 * alloc.c (valid_pointer_p): Use pipe, not open.
723 This fixes some permissions issues when debugging.
725 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
726 If fchown fails to set both uid and gid, try to set just gid,
727 as that is sometimes allowed. Adjust the file's mode to eliminate
728 setuid or setgid bits that are inappropriate if fchown fails.
730 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
732 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
733 to compare Lisp_Objects.
734 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
735 global_gnutls_log_level, don't mistake it for a Lisp_Object.
736 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
738 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
740 * lread.c (read_integer): Unread even EOF character.
741 (read1): Likewise. Properly record start position of symbol.
743 * lread.c (read1): Read `#:' as empty uninterned symbol if no
744 symbol character follows.
746 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
748 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
749 This works around a problem with the previous change to Fcopy_file.
750 Recent glibc declares fchown with __attribute__((warn_unused_result)),
751 and without this change, GCC might complain about discarding
752 fchown's return value.
754 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
756 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
758 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
760 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
762 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
764 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
765 it's used from the C level.
767 * process.c: Use the same condition for POLL_FOR_INPUT in both
768 keyboard.c and process.c (bug#1858).
770 2011-07-09 Lawrence Mitchell <wence@gmx.li>
772 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
773 (Fgnutls_boot): Use it.
775 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
777 * doc.c (Fsubstitute_command_keys): Revert last change.
779 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
781 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
782 quotes the next character, and doesn't affect other longer
783 sequences (bug#8935).
785 * lread.c (syms_of_lread): Clarify that is isn't only
786 `eval-buffer' and `eval-defun' that's affected by
787 `lexical-binding' (bug#8460).
789 2011-07-15 Eli Zaretskii <eliz@gnu.org>
791 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
792 bidi redisplay when a line includes both an image and is
795 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
797 Fix minor problems found by static checking.
798 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
799 (elsz): Now a signed constant, not a size_t var. We prefer signed
800 types to unsigned, to avoid integer comparison confusion. Without
801 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
802 "cannot optimize loop, the loop counter may overflow", a symptom
804 * indent.c (Fvertical_motion): Mark locals as initialized.
805 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
807 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
809 * search.c (Fre_search_backward): Mention `case-fold-search' in
810 all the re_search_* functions (bug#8138).
812 * keyboard.c (Fopen_dribble_file): Document when the file is
815 2011-07-14 Eli Zaretskii <eliz@gnu.org>
817 * bidi.c (bidi_dump_cached_states): Fix format of displaying
820 Support bidi reordering of display and overlay strings.
821 * xdisp.c (compute_display_string_pos)
822 (compute_display_string_end): Accept additional argument STRING.
823 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
824 (reseat_to_string): Initialize bidi_it->string.s and
825 bidi_it->string.schars.
826 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
827 NULL (avoids a crash in bidi_paragraph_init).
828 Initialize itb.string.lstring.
829 (init_iterator): Call bidi_init_it only of a valid
830 buffer position was specified. Initialize paragraph_embedding to
832 (reseat_to_string): Initialize the bidi iterator.
833 (display_string): If we need to ignore text properties of
834 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
835 original value of -1 will not work with bidi.)
836 (compute_display_string_pos): First arg is now struct
837 `text_pos *'; all callers changed. Support display properties on
839 (compute_display_string_end): Support display properties on Lisp
841 (init_iterator, reseat_1, reseat_to_string): Initialize the
842 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
843 when iterating on a string not from display properties).
844 (compute_display_string_pos, compute_display_string_end):
845 Fix calculation of the object to scan. Fixes an error when using
847 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
848 base_level_stop; instead, set base_level_stop to BEGV.
849 Fixes crashes in vertical-motion.
850 (next_element_from_buffer): Improve commentary for when
851 the iterator is before prev_stop.
852 (init_iterator): Initialize bidi_p from the default value of
853 bidi-display-reordering, not from buffer-local value. Use the
854 buffer-local value only if initializing for buffer iteration.
855 (handle_invisible_prop): Support invisible properties on strings
856 that are being bidi-reordered.
857 (set_iterator_to_next): Support bidi reordering of C strings and
859 (next_element_from_string): Support bidi reordering of Lisp
861 (handle_stop_backwards): Support Lisp strings as well.
862 (display_string): Support display of R2L glyph rows.
863 Use IT_STRING_CHARPOS when displaying from a Lisp string.
864 (init_iterator): Don't initialize it->bidi_p for strings
866 (reseat_to_string): Initialize it->bidi_p for strings here.
867 (next_element_from_string, next_element_from_c_string)
868 (next_element_from_buffer): Add xassert's for correspondence
869 between IT's object being iterated and it->bidi_it.string
871 (face_before_or_after_it_pos): Support bidi iteration.
872 (next_element_from_c_string): Handle the case of the first string
873 character that is not the first one in the visual order.
874 (get_visually_first_element): New function, refactored from common
875 parts of next_element_from_buffer, next_element_from_string, and
876 next_element_from_c_string.
877 (tool_bar_lines_needed, redisplay_tool_bar)
878 (display_menu_bar): Force left-to-right direction. Add a FIXME
879 comment for making that be controlled by a user option.
880 (push_it, pop_it): Save and restore the state of the
881 bidi iterator. Save and restore the bidi_p flag.
882 (pop_it): Iterate out of display property for string iteration as
884 (iterate_out_of_display_property): Support iteration over strings.
885 (handle_single_display_spec): Set up it->bidi_it for iteration
886 over a display string, and call bidi_init_it.
887 (handle_single_display_spec, next_overlay_string)
888 (get_overlay_strings_1, push_display_prop): Set up the bidi
889 iterator for displaying display or overlay strings.
890 (forward_to_next_line_start): Don't use the shortcut if
892 (back_to_previous_visible_line_start): If handle_display_prop
893 pushed the iterator stack, restore the internal state of the bidi
894 iterator by calling bidi_pop_it same number of times.
895 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
896 and we are bidi-iterating, don't decrement the iterator position;
897 instead, set the first_elt flag in the bidi iterator, to produce
899 (reseat_1): Remove redundant setting of string_from_display_prop_p.
900 (push_display_prop): xassert that we are iterating a buffer.
901 (push_it, pop_it): Save and restore paragraph_embedding member.
902 (handle_single_display_spec, next_overlay_string)
903 (get_overlay_strings_1, reseat_1, reseat_to_string)
904 (push_display_prop): Set up the `unibyte' member of bidi_it.string
905 correctly. Don't assume unibyte strings are not bidi-reordered.
906 (compute_display_string_pos)
907 (compute_display_string_end): Fix handling the case of C string.
908 (push_it, pop_it): Save and restore from_disp_prop_p.
909 (handle_single_display_spec, push_display_prop): Set the
910 from_disp_prop_p flag.
911 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
912 (pop_it): Call iterate_out_of_display_property only if we are
913 popping after iteration over a string that came from a display
914 property. Fix a typo in popping stretch info. Add an assertion
915 for verifying that the iterator position is in sync with the bidi
917 (handle_single_display_spec, get_overlay_strings_1)
918 (push_display_prop): Fix initialization of paragraph direction for
919 string when that of the parent object is not yet determined.
920 (reseat_1): Call bidi_init_it to resync the bidi
921 iterator with IT's position. (Bug#7616)
922 (find_row_edges): If ROW->start.pos gives position
923 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
924 (handle_stop, back_to_previous_visible_line_start, reseat_1):
925 Reset the from_disp_prop_p flag.
926 (SAVE_IT, RESTORE_IT): New macros.
927 (pos_visible_p, face_before_or_after_it_pos)
928 (back_to_previous_visible_line_start)
929 (move_it_in_display_line_to, move_it_in_display_line)
930 (move_it_to, move_it_vertically_backward, move_it_by_lines)
931 (try_scrolling, redisplay_window, display_line): Use them when
932 saving a temporary copy of the iterator and restoring it back.
933 (back_to_previous_visible_line_start, reseat_1)
934 (init_iterator): Empty the bidi cache "stack".
935 (move_it_in_display_line_to): If iterator ended up at
936 EOL, but we never saw any buffer positions smaller than
937 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
938 motion in bidi-reordered lines.
939 (move_it_in_display_line_to): Record prev_method and prev_pos
940 immediately before the call to set_iterator_to_next. Fixes cursor
941 motion in bidi-reordered lines with stretch glyphs and strings
942 displayed in margins. (Bug#8133) (Bug#8867)
943 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
945 (pos_visible_p): Support positions in bidi-reordered lines.
946 Save and restore bidi cache.
948 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
949 (bidi_paragraph_info): Delete unused struct.
950 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
951 (bidi_cache_start): New variable.
952 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
954 (bidi_cache_fetch_state, bidi_cache_search)
955 (bidi_cache_find_level_change, bidi_cache_iterator_state)
956 (bidi_cache_find, bidi_peek_at_next_level)
957 (bidi_level_of_next_char, bidi_find_other_level_edge)
958 (bidi_move_to_visually_next): Compare cache index with
959 bidi_cache_start rather than with zero.
960 (bidi_fetch_char): Accept new argument STRING; all callers
961 changed. Support iteration over a string. Support strings with
962 display properties. Support unibyte strings. Fix the type of
963 `len' according to what STRING_CHAR_AND_LENGTH expects.
964 (bidi_paragraph_init, bidi_resolve_explicit_1)
965 (bidi_resolve_explicit, bidi_resolve_weak)
966 (bidi_level_of_next_char, bidi_move_to_visually_next):
967 Support iteration over a string.
968 (bidi_set_sor_type, bidi_resolve_explicit_1)
969 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
970 can now be zero (for strings); special values 0 and -1 were
971 changed to -1 and -2, respectively.
972 (bidi_char_at_pos): New function.
973 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
974 Call it instead of FETCH_MULTIBYTE_CHAR.
975 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
976 initialized to valid values.
977 (bidi_init_it): Don't initialize charpos and bytepos with invalid
979 (bidi_level_of_next_char): Allow the sentinel "position" to pass
980 the test for valid cached positions. Fix the logic for looking up
981 the sentinel state in the cache. GCPRO the Lisp string we are
983 (bidi_push_it, bidi_pop_it): New functions.
984 (bidi_initialize): Initialize the bidi cache start stack pointer.
985 (bidi_cache_ensure_space): New function, refactored from part of
986 bidi_cache_iterator_state. Don't assume the required size is just
987 one BIDI_CACHE_CHUNK away.
988 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
989 (bidi_count_bytes, bidi_char_at_pos): New functions.
990 (bidi_cache_search): Don't assume bidi_cache_last_idx is
991 always valid if bidi_cache_idx is valid.
992 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
993 is valid if it's going to be used.
994 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
995 (bidi_cache_fetch_state, bidi_cache_search)
996 (bidi_cache_find_level_change, bidi_cache_ensure_space)
997 (bidi_cache_iterator_state, bidi_cache_find)
998 (bidi_find_other_level_edge, bidi_cache_start_stack):
999 All variables related to cache indices are now EMACS_INT.
1001 * dispextern.h (struct bidi_string_data): New structure.
1002 (struct bidi_it): New member `string'. Make flag members be 1-bit
1003 fields, and put them last in the struct.
1004 (compute_display_string_pos, compute_display_string_end):
1006 (bidi_push_it, bidi_pop_it): Add prototypes.
1007 (struct iterator_stack_entry): New members bidi_p,
1008 paragraph_embedding, and from_disp_prop_p.
1009 (struct it): Member bidi_p is now a bit field 1 bit wide.
1010 (bidi_shelve_cache, bidi_unshelve_cache):
1013 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1014 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1015 and vector-like objects.
1017 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1018 cache around display iteration.
1020 * window.c (Fwindow_end, window_scroll_pixel_based)
1021 (displayed_window_lines, Frecenter): Save and restore the bidi
1022 cache around display iteration.
1024 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1026 * editfns.c (Fdelete_region): Clarify the use of the named
1027 parameters (bug#6788).
1029 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1031 * indent.c (Fvertical_motion): Set and restore w->pointm when
1032 saving and restoring the window's buffer (Bug#9006).
1034 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1036 * editfns.c (Fstring_to_char): Clarify just what is returned
1037 (bug#6576). Text by Eli Zaretskii.
1039 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1041 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1043 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1045 * buffer.c (mmap_find): Fix a typo.
1047 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1049 Fix execution of x selection hooks.
1050 * xselect.c (Qx_lost_selection_functions)
1051 (Qx_sent_selection_functions): New vars.
1052 (syms_of_xselect): DEFSYM them.
1053 (x_handle_selection_request): Pass Qx_sent_selection_functions
1054 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1055 (x_handle_selection_clear,x_clear_frame_selections):
1056 Pass Qx_lost_selection_functions rather than
1057 Vx_lost_selection_functions to Frun_hook_with_args.
1059 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1061 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1062 The old code sometimes used this field without initializing it.
1064 * alloc.c (gc_sweep): Don't read past end of array.
1065 In theory, the old code could also have corrupted Emacs internals,
1066 though it'd be very unlikely.
1068 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1070 * character.c (Fcharacterp): Don't advertise optional ignored
1071 argument. (Bug#4026)
1073 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1075 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1078 * window.c (Fset_window_start): Doc fix (bug#4199).
1079 (Fset_window_hscroll): Ditto.
1081 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1083 Fix minor new problems caught by GCC 4.6.1.
1084 * term.c (init_tty): Remove unused local.
1085 * xsettings.c (store_monospaced_changed): Define this function only
1086 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1089 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1091 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1093 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1095 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1096 are the mini-buffer and the echo area (bug#3320).
1098 * term.c (init_tty): Remove support for supdup, c10 and perq
1099 terminals, which are no longer supported (bug#1482).
1101 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1103 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1105 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1107 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1108 for non-popups (Bug#3642).
1110 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1112 * alloc.c (reset_malloc_hooks): Protoize.
1113 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1114 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1115 * cm.c (losecursor): Likewise.
1116 * data.c (fmod): Likewise.
1117 * dispnew.c (swap_glyphs_in_rows): Likewise.
1118 * emacs.c (memory_warning_signal): Likewise.
1119 * floatfns.c (float_error): Likewise.
1120 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1121 (otf_open, font_otf_capability, generate_otf_features)
1122 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1124 * image.c (pbm_read_file): Likewise.
1125 * indent.c (string_display_width): Likewise.
1126 * intervals.c (check_for_interval, search_for_interval)
1127 (inc_interval_count, count_intervals, root_interval)
1128 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1129 * lread.c (defalias): Likewise.
1130 * ralloc.c (r_alloc_check): Likewise.
1131 * regex.c (set_image_of_range_1, set_image_of_range)
1132 (regex_grow_registers): Likewise.
1133 * sysdep.c (strerror): Likewise.
1134 * termcap.c (valid_filename_p, tprint, main): Likewise.
1135 * tparam.c (main): Likewise.
1136 * unexhp9k800.c (run_time_remap, save_data_space)
1137 (update_file_ptrs, read_header, write_header, calculate_checksum)
1138 (copy_file, copy_rest, display_header): Likewise.
1139 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1141 * xdisp.c (check_it): Likewise.
1142 * xfaces.c (register_color, unregister_color, unregister_colors):
1144 * xfns.c (print_fontset_result): Likewise.
1145 * xrdb.c (member, fatal, main): Likewise.
1147 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1149 Fix minor problems found by static checking (Bug#9031).
1150 * chartab.c (char_table_set_range, map_sub_char_table):
1151 Remove unused locals.
1152 (uniprop_table): Now static.
1153 * composite.c (_work_char): Remove unused static var.
1155 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1157 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1159 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1161 * gtkutil.c (qttip_cb): Remove code without function.
1163 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1165 * w32.c (pthread_sigmask): New stub.
1167 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1169 Use pthread_sigmask, not sigprocmask (Bug#9010).
1170 sigprocmask is portable only for single-threaded applications, and
1171 Emacs can be multi-threaded when it uses GTK.
1172 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1174 * callproc.c (Fcall_process):
1175 * process.c (create_process):
1176 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1177 Use pthread_sigmask, not sigprocmask.
1179 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1181 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1182 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1185 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1187 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1188 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1189 (xg_hide_tooltip): Fix comment.
1191 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1192 in registerServicesMenuSendTypes.
1193 (validRequestorForSendType): Don't check ns_return_types.
1195 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1198 2011-07-08 Jason Rumney <jasonr@gnu.org>
1200 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1201 frame struct members of non-existent frames (Bug#6284).
1203 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1205 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1206 variable firstTime not needed on OSX >= 10.6.
1207 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1208 >= 10.5. Use setKnobProportion, setDoubleValue.
1210 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1211 (MAC_OS_X_VERSION_10_5): Define if not defined.
1212 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1213 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1214 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1216 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1217 cString and lossyCString on OSX >= 10.4
1219 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1220 sizeToFit on OSX >= 10.2.
1222 * nsimage.m (allocInitFromFile): Don't use deprecated method
1223 bestRepresentationForDevice on OSX >= 10.6.
1225 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1228 * emacs.c: Declare unexec_init_emacs_zone.
1230 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1232 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1234 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1235 on svcsMenu (Bug#8842).
1237 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1239 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1241 * nsterm.m (QUTF8_STRING): Declare.
1242 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1243 (validRequestorForSendType): Return type is (id).
1244 Change indexOfObjectIdenticalTo to indexOfObject.
1245 Check if we have local selection before returning self (Bug#8842).
1246 (writeSelectionToPasteboard): Put local selection into paste board
1247 if we have a local selection (Bug#8842).
1248 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1250 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1251 (ns_get_local_selection): Declare.
1253 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1255 * keymap.c (describe_map_tree): Don't insert a double newline at
1256 the end of the buffer (bug#1169) and return whether we inserted
1259 * callint.c (Fcall_interactively): Change "reading args" to
1260 "providing args" to try to clarify what it does (bug#1010).
1262 2011-07-07 Kenichi Handa <handa@m17n.org>
1264 * composite.c (composition_compute_stop_pos): Ignore a static
1265 composition starting before CHARPOS (Bug#8915).
1267 * xdisp.c (handle_composition_prop): Likewise.
1269 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1271 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1274 2011-07-07 Kenichi Handa <handa@m17n.org>
1276 * character.h (unicode_category_t): New enum type.
1278 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1279 (Qchar_code_property_table): New variable.
1280 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1281 (UNIPROP_COMPRESSED_FORM_P): New macros.
1282 (char_table_ascii): Uncompress the compressed values.
1283 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1284 Uncompress the compressed values.
1285 (sub_char_table_ref_and_range): Likewise.
1286 (char_table_ref_and_range): Uncompress the compressed values.
1287 (sub_char_table_set): New arg is_uniprop. Callers changed.
1288 Uncompress the compressed values.
1289 (sub_char_table_set_range): Args changed. Callers changed.
1290 (char_table_set_range): Adjuted for the above change.
1291 (map_sub_char_table): Delete args default_val and parent. Add arg
1292 top. Give decoded values to a Lisp function.
1293 (map_char_table): Adjust for the above change. Give decoded
1294 values to a Lisp function. Gcpro more variables.
1295 (uniprop_table_uncompress)
1296 (uniprop_decode_value_run_length): New functions.
1297 (uniprop_decoder, uniprop_decoder_count): New variables.
1298 (uniprop_get_decoder, uniprop_encode_value_character)
1299 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1301 (uniprop_encoder, uniprop_encoder_count): New variables.
1302 (uniprop_get_encoder, uniprop_table)
1303 (Funicode_property_table_internal, Fget_unicode_property_internal)
1304 (Fput_unicode_property_internal): New functions.
1305 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1306 Sunicode_property_table_internal, Sget_unicode_property_internal,
1307 and Sput_unicode_property_internal. Defvar_lisp
1308 char-code-property-alist.
1310 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1311 Vunicode_category_table.
1313 * font.c (font_range): Adjust for the change of
1314 Vunicode_category_table.
1316 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1318 * m/iris4d.h: Remove file, move contents ...
1319 * s/irix6-5.h: ... here.
1321 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1323 Remove unportable assumption about struct layout (Bug#8884).
1324 * alloc.c (mark_buffer):
1325 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1326 (clone_per_buffer_values): Don't assume that
1327 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1328 This isn't true in general, and it's particularly not true
1329 if Emacs is configured with --with-wide-int.
1330 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1331 New macros, used in the buffer.c change.
1333 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1335 * xsettings.c: Use both GConf and GSettings if both are available.
1336 (store_config_changed_event): Add comment.
1337 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1338 (store_tool_bar_style_changed): New functions.
1339 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1340 (struct xsettings): Move font inside HAVE_XFT.
1341 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1342 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1343 Move inside HAVE_XFT.
1344 (something_changed_gsettingsCB): Rename from something_changedCB.
1345 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1347 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1348 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1349 (something_changed_gconfCB): Rename from something_changedCB.
1350 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1351 (parse_settings): Move check for font inside HAVE_XFT.
1352 (read_settings, apply_xft_settings): Add comment.
1353 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1354 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1355 call store_font_name_changed.
1356 (xft_settings_event): Add comment.
1357 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1358 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1359 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1360 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1361 (xsettings_initialize): Call init_gsettings last.
1362 (xsettings_get_system_font, xsettings_get_system_normal_font):
1365 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1367 Random fixes. E.g., (random) never returned negative values.
1368 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1369 subseconds part to the entropy, as that's a bit more random.
1370 Prefer signed to unsigned, since the signedness doesn't matter and
1371 in general we prefer signed. When given a limit, use a
1372 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1373 latter isn't right if USE_2_TAGS_FOR_INTS.
1374 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1375 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1377 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1379 * textprop.c (text_property_stickiness):
1380 Obey Vtext_property_default_nonsticky.
1381 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1382 * w32fns.c (syms_of_w32fns):
1383 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1385 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1387 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1388 This is more efficient than Ffile_directory_p and avoids a minor race.
1390 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1392 * buffer.c (Foverlay_put): Say what the return value is
1395 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1396 is a directory before asking whether to use the file name
1398 (barf_or_query_if_file_exists): Make the "File is a directory"
1399 error be more correct.
1401 * fns.c (Frequire): Remove the mention of the .gz files, since
1402 that's installation-specific, but keep the mention of
1403 `get-load-suffixes'.
1405 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1407 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1408 Report string overflow if the output is too long.
1410 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1412 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1413 (syms_of_gnutls): Remove duplicate DEFSYM for
1414 Qgnutls_bootprop_verify_hostname_error, an error for
1415 Qgnutls_bootprop_verify_error (which is no longer used).
1417 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1418 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1419 Also (re)move comments that are misplaced or no longer relevant.
1421 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1423 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1425 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1427 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1428 and background color parameters if they have been changed.
1430 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1432 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1434 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1436 * xsettings.c (SYSTEM_FONT): Define only when used.
1437 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1439 * keymap.c (access_keymap_1): Now static.
1441 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1443 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1444 leave any prefix arg for the up event (Bug#1586).
1446 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1448 * lread.c (syms_of_lread): Mention single symbols defined by
1449 `defvar' or `defconst' (bug#7154).
1451 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1452 (Frequire): Mention get-load-suffixes.
1454 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1456 * window.h (window): Remove clone_number slot.
1457 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1459 (make_parent_window, make_window, saved_window)
1460 (Fset_window_configuration, save_window_save): Don't deal with
1462 * buffer.c (Qclone_number): Remove declaration.
1463 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1465 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1467 Add multiple inheritance to keymaps.
1468 * keymap.c (Fmake_composed_keymap): New function.
1469 (Fset_keymap_parent): Simplify.
1470 (fix_submap_inheritance): Remove.
1471 (access_keymap_1): New function extracted from access_keymap to handle
1472 embedded parents and handle lists of maps.
1473 (access_keymap): Use it.
1474 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1475 (Fcopy_keymap): Handle embedded parents.
1476 (Fcommand_remapping, define_as_prefix): Simplify.
1477 (Fkey_binding): Simplify.
1478 (syms_of_keymap): Move minibuffer-local-completion-map,
1479 minibuffer-local-filename-completion-map,
1480 minibuffer-local-must-match-map, and
1481 minibuffer-local-filename-must-match-map to Elisp.
1482 (syms_of_keymap): Defsubr make-composed-keymap.
1483 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1484 (parse_menu_item): Trivial simplification.
1486 2011-07-01 Glenn Morris <rgm@gnu.org>
1488 * Makefile.in (SETTINGS_LIBS): Fix typo.
1490 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1492 * coding.c (Fencode_coding_string): Record the last coding system
1493 used, as the function doc string says (bug#8738).
1495 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1497 * xsettings.c (store_monospaced_changed): Take new font as arg and
1498 check for change against current_mono_font.
1499 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1500 (emacs_settings_constructor, emacs_settings_get_property)
1501 (emacs_settings_set_property, emacs_settings_class_init)
1502 (emacs_settings_init, gsettings_obj): Remove.
1503 (something_changedCB): New function for HAVE_GSETTINGS.
1504 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1505 with value as argument.
1506 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1507 g_settings_new (Bug#8967). Do not create gsettings_obj.
1508 Remove calls to g_settings_bind. Connect something_changedCB to
1511 * xgselect.c: Add defined (HAVE_GSETTINGS).
1512 (xgselect_initialize): Ditto.
1514 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1515 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1518 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1520 * eval.c (struct backtrace): Simplify and port the data structure.
1521 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1522 signed bit field, as this assumption is not portable and it makes
1523 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1524 "char debug_on_exit : 1" as this is not portable either; instead,
1525 use the portable "unsigned int debug_on_exit : 1". Remove unused
1526 member evalargs. Remove obsolete comments about cc bombing out.
1528 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1530 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1531 Let HAVE_GSETTINGS override HAVE_GCONF.
1532 (store_monospaced_changed): New function.
1533 (EMACS_SETTINGS): A new type derived from GObject to handle
1534 GSettings notifications.
1535 (emacs_settings_constructor, emacs_settings_get_property)
1536 (emacs_settings_set_property, emacs_settings_class_init):
1538 (gsettings_client, gsettings_obj): New variables.
1539 (GSETTINGS_SCHEMA): New define.
1540 (something_changedCB): Call store_monospaced_changed.
1541 (init_gsettings): New function.
1542 (xsettings_initialize): Call init_gsettings.
1543 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1546 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1549 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1551 * window.c (resize_root_window, grow_mini_window)
1552 (shrink_mini_window): Rename Qresize_root_window to
1553 Qwindow_resize_root_window and Qresize_root_window_vertically to
1554 Qwindow_resize_root_window_vertically.
1556 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1558 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1560 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1562 * makefile.w32-in: Redesign dependencies so they reflect more
1563 clearly which files are directly included by each source file,
1564 and not through other includes.
1566 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1568 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1569 (sort_overlays, overlay_strings): When an overlay's clone number
1570 matches the window's clone number process the overlay even if
1571 the overlay's window property doesn't match the current window.
1573 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1574 (Fwindow_hchild): Rename to Fwindow_left_child.
1575 (Fwindow_next): Rename to Fwindow_next_sibling.
1576 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1577 (resize_window_check): Rename to window_resize_check.
1578 (resize_window_apply): Rename to window_resize_apply.
1579 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1580 (Fdelete_other_windows_internal, resize_frame_windows)
1581 (Fsplit_window_internal, Fdelete_window_internal)
1582 (grow_mini_window, shrink_mini_window)
1583 (Fresize_mini_window_internal): Fix callers accordingly.
1585 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1587 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1588 (emacs_fixed_set_min_size): Remove.
1589 (emacs_fixed_new): Take frame as argument.
1591 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1592 (_EmacsFixedPrivate): Remove minwidth/height.
1593 Add struct frame *f.
1594 (emacs_fixed_init): Initialize priv->f.
1595 (get_parent_class, emacs_fixed_set_min_size): Remove.
1596 (emacs_fixed_new): Set priv->f to argument.
1597 (emacs_fixed_get_preferred_width)
1598 (emacs_fixed_get_preferred_height): Use min_width/height from
1599 frames size_hint to set minimum and natural (Bug#8919).
1600 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1601 and use min_width/height from frames size_hint to set
1602 min_width/height (Bug#8919).
1604 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1605 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1608 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1610 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1611 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1614 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1616 * process.c (wait_reading_process_output): Bypass select if
1617 waiting for a cell while ignoring keyboard input, and input is
1618 pending. Suggested by Jan Djärv (Bug#8869).
1620 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1622 Use gnulib's dup2 module instead of rolling our own.
1623 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1625 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1627 * dispnew.c (scrolling_window): Before scrolling, turn off a
1628 mouse-highlight in the window being scrolled.
1630 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1632 Move DEFSYM to lisp.h and use everywhere.
1634 * character.h (DEFSYM): Move declaration...
1635 * lisp.h (DEFSYM): ...here.
1641 * w32select.c: Don't include character.h.
1643 * alloc.c (syms_of_alloc):
1644 * buffer.c (syms_of_buffer):
1645 * bytecode.c (syms_of_bytecode):
1646 * callint.c (syms_of_callint):
1647 * casefiddle.c (syms_of_casefiddle):
1648 * casetab.c (init_casetab_once):
1649 * category.c (init_category_once, syms_of_category):
1650 * ccl.c (syms_of_ccl):
1651 * cmds.c (syms_of_cmds):
1652 * composite.c (syms_of_composite):
1653 * dbusbind.c (syms_of_dbusbind):
1654 * dired.c (syms_of_dired):
1655 * dispnew.c (syms_of_display):
1656 * doc.c (syms_of_doc):
1657 * editfns.c (syms_of_editfns):
1658 * emacs.c (syms_of_emacs):
1659 * eval.c (syms_of_eval):
1660 * fileio.c (syms_of_fileio):
1661 * fns.c (syms_of_fns):
1662 * frame.c (syms_of_frame):
1663 * fringe.c (syms_of_fringe):
1664 * insdel.c (syms_of_insdel):
1665 * keymap.c (syms_of_keymap):
1666 * lread.c (init_obarray, syms_of_lread):
1667 * macros.c (syms_of_macros):
1668 * msdos.c (syms_of_msdos):
1669 * print.c (syms_of_print):
1670 * process.c (syms_of_process):
1671 * search.c (syms_of_search):
1672 * sound.c (syms_of_sound):
1673 * syntax.c (init_syntax_once, syms_of_syntax):
1674 * terminal.c (syms_of_terminal):
1675 * textprop.c (syms_of_textprop):
1676 * undo.c (syms_of_undo):
1677 * w32.c (globals_of_w32):
1678 * window.c (syms_of_window):
1679 * xdisp.c (syms_of_xdisp):
1680 * xfaces.c (syms_of_xfaces):
1681 * xfns.c (syms_of_xfns):
1682 * xmenu.c (syms_of_xmenu):
1683 * xsettings.c (syms_of_xsettings):
1684 * xterm.c (syms_of_xterm): Use DEFSYM.
1686 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1688 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1690 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1692 Integer and buffer overflow fixes (Bug#8873).
1694 * print.c (printchar, strout): Check for string overflow.
1695 (PRINTPREPARE, printchar, strout):
1696 Don't set size unless allocation succeeds.
1698 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1699 for sizes. Check for string overflow more accurately.
1700 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1702 * macros.c: Integer and buffer overflow fixes.
1703 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1704 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1705 Use ptrdiff_t, not int, for sizes.
1706 Don't increment bufsize until after realloc succeeds.
1707 Check for size-calculation overflow.
1708 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1710 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1712 * lread.c: Integer overflow fixes.
1713 (read_integer): Radix is now EMACS_INT, not int,
1714 to improve quality of diagnostics for out-of-range radices.
1715 Calculate buffer size correctly for out-of-range radices.
1716 (read1): Check for integer overflow in radices, and in
1717 read-circle numbers.
1718 (read_escape): Avoid int overflow.
1719 (Fload, openp, read_buffer_size, read1)
1720 (substitute_object_recurse, read_vector, read_list, map_obarray):
1721 Use ptrdiff_t, not int, for sizes.
1722 (read1): Use EMACS_INT, not int, for sizes.
1723 Check for size overflow.
1725 * image.c (cache_image): Check for size arithmetic overflow.
1727 * lread.c: Integer overflow issues.
1728 (saved_doc_string_size, saved_doc_string_length)
1729 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1730 Now ptrdiff_t, not int.
1731 (read1): Don't assume doc string length fits in int. Check for
1732 out-of-range doc string lengths.
1733 (read_list): Don't assume file position fits in int.
1734 (read_escape): Check for hex character overflow.
1736 2011-06-22 Leo Liu <sdl.web@gmail.com>
1738 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1739 Move to minibuffer.el.
1741 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1743 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1744 The following patches are for when GLYPH_DEBUG && !XASSERT.
1745 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1746 * dispnew.c (flush_stdout):
1747 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1748 Mark as externally visible.
1749 * dispnew.c (check_window_matrix_pointers): Now static.
1750 * dispnew.c (window_to_frame_vpos):
1751 * xfns.c (unwind_create_frame):
1752 * xterm.c (x_check_font): Remove unused local.
1753 * scroll.c (CHECK_BOUNDS):
1754 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1755 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1756 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1757 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1758 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1760 (debug_method_add): Use va_list and vsprintf rather than relying
1761 on undefined behavior with wrong number of arguments.
1762 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1763 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1764 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1765 since we're not interested in debugging glyphs with old libraries.
1766 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1767 GCC 4.6.0's static checking.
1769 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1771 Integer overflow and signedness fixes (Bug#8873).
1772 A few related buffer overrun fixes, too.
1774 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1776 * dispextern.h (struct face.stipple):
1777 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1778 (x_bitmap_mask, x_allocate_bitmap_record)
1779 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1780 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1781 (x_create_bitmap_from_xpm_data):
1782 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1783 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1785 * xfaces.c (load_pixmap):
1786 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1787 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1788 (.bitmaps_last, struct x_output.icon_bitmap):
1789 Use ptrdiff_t, not int, for bitmap indexes.
1790 (x_allocate_bitmap_record): Check for size overflow.
1791 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1793 Use ptrdiff_t, not int, for overlay counts.
1794 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1795 * editfns.c (overlays_around, get_pos_property):
1796 * textprop.c (get_char_property_and_overlay):
1797 * xdisp.c (next_overlay_change, note_mouse_highlight):
1798 * xfaces.c (face_at_buffer_position):
1799 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1800 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1801 (Fnext_overlay_change, Fprevious_overlay_change)
1802 (mouse_face_overlay_overlaps, Foverlays_in):
1803 Use ptrdiff_t, not int, for sizes.
1804 (overlays_at, overlays_in): Check for size-calculation overflow.
1806 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1808 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1809 (x_session_initialize): Do not assume string length fits in int.
1811 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1812 This is unlikely, but can occur if DPI is outlandish.
1814 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1815 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1817 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1818 * xrdb.c (magic_file_p, search_magic_path):
1819 Omit last arg SUFFIX; it was always 0. All callers changed.
1820 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1822 * xfont.c (xfont_match): Avoid need for strlen.
1824 * xfns.c: Don't assume strlen fits in int.
1825 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1827 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1828 not unsigned long, as we prefer signed integers. All callers changed.
1829 Detect integer overflow in repeat count.
1830 (message_dolog): Don't assume print length fits in 39 bytes.
1831 (display_mode_element): Don't assume strlen fits in int.
1833 * termcap.c: Don't assume sizes fit in int and never overflow.
1834 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1835 (gobble_line): Check for size-calculation overflow.
1837 * minibuf.c (Fread_buffer):
1838 * lread.c (intern, intern_c_string):
1839 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1840 Don't assume string length fits in int.
1842 * keyboard.c (parse_tool_bar_item):
1843 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1845 * font.c: Don't assume string length fits in int.
1846 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1847 Use ptrdiff_t, not int.
1848 (font_intern_prop): Don't assume string length fits in int.
1849 Don't assume integer property fits in fixnum.
1850 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1852 * filelock.c: Fix some buffer overrun and integer overflow issues.
1853 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1854 Reformulate so as not to need the command string.
1855 Invoke gzip -cd rather than gunzip, as it's more portable.
1856 (lock_info_type, lock_file_1, lock_file):
1857 Don't assume pid_t and time_t fit in unsigned long.
1858 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1859 (current_lock_owner): Prefer signed type for sizes.
1860 Use memcpy, not strncpy, where memcpy is what is really wanted.
1861 Don't assume (via atoi) that time_t and pid_t fit in int.
1862 Check for time_t and/or pid_t out of range, e.g., via a network share.
1863 Don't alloca where an auto var works fine.
1865 * fileio.c: Fix some integer overflow issues.
1866 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1867 Don't assume string length fits in int.
1868 (directory_file_name): Don't assume string length fits in long.
1869 (make_temp_name): Don't assume pid fits in int, or that its print
1870 length is less than 20.
1872 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1874 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1876 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1878 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1879 We prefer signed integers, even for size calculations.
1881 * emacs.c: Don't assume string length fits in 'int'.
1882 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1883 (main): Don't invoke strlen when not needed.
1885 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1886 (XD_DEBUG_MESSAGE): Don't waste a byte.
1888 * callproc.c (getenv_internal_1, getenv_internal)
1890 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1892 * lread.c (invalid_syntax): Omit length argument.
1893 All uses changed. This doesn't fix a bug, but it simplifies the
1894 code away from its former Hollerith-constant appearance, and it's
1895 one less 'int' to worry about when looking at integer-overflow issues.
1896 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1898 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1899 This didn't break anything, but it didn't help either.
1900 It's confusing to put a bogus integer in a place where the actual
1901 value does not matter.
1902 (LIST_END_P): Remove unused macro and its bogus comment.
1903 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1905 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1906 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1908 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1909 We prefer signed types, and the value cannot exceed the EMACS_INT
1910 range anyway (because otherwise the length would not be representable).
1911 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1912 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1913 This avoids a GCC warning when WIDE_EMACS_INT.
1915 * indent.c (sane_tab_width): New function.
1916 (current_column, scan_for_column, Findent_to, position_indentation)
1917 (compute_motion): Use it. This is just for clarity.
1918 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1920 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1922 * lisp.h (lint_assume): New macro.
1923 * composite.c (composition_gstring_put_cache):
1924 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1926 * editfns.c, insdel.c:
1927 Omit unnecessary forward decls, to simplify future changes.
1929 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1931 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1933 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1934 Use much-faster test for byte-length change.
1935 Don't assume string byte-length fits in 'int'.
1936 Check that character arg fits in 'int'.
1937 (mapcar1): Declare byte as byte, for clarity.
1939 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1941 * fns.c (concat): Catch string overflow earlier.
1942 Do not rely on integer wraparound.
1944 * dispextern.h (struct it.overlay_strings_charpos)
1945 (struct it.selective): Now EMACS_INT, not int.
1946 * xdisp.c (forward_to_next_line_start)
1947 (back_to_previous_visible_line_start)
1948 (reseat_at_next_visible_line_start, next_element_from_buffer):
1949 Don't arbitrarily truncate the value of 'selective' to int.
1951 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1953 * composite.c: Don't truncate sizes to 'int'.
1954 (composition_gstring_p, composition_reseat_it)
1955 (composition_adjust_point): Use EMACS_INT, not int.
1956 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1957 not EMACS_UINT, for indexes.
1959 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1961 * buffer.c: Include <verify.h>.
1962 (struct sortvec.priority, struct sortstr.priority):
1963 Now EMACS_INT, not int.
1964 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1965 (struct sortstr.size, record_overlay_string)
1966 (struct sortstrlist.size, struct sortlist.used):
1967 Don't truncate size to int.
1968 (record_overlay_string): Check for size-calculation overflow.
1969 (init_buffer_once): Check at compile-time, not run-time.
1971 2011-06-22 Jim Meyering <meyering@redhat.com>
1973 Don't leak an XBM-image-sized buffer
1974 * image.c (xbm_load): Free the image buffer after using it.
1976 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1979 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1980 that Sun C diagnosed.
1981 * fns.c (secure_hash): Fix pointer signedness issue.
1982 * intervals.c (static_offset_intervals): New function.
1983 (offset_intervals): Use it.
1985 2011-06-21 Leo Liu <sdl.web@gmail.com>
1988 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1991 * fns.c (secure_hash): Rename from crypto_hash_function and change
1992 the first arg to accept symbols.
1993 (Fsecure_hash): New primitive.
1994 (syms_of_fns): New symbols.
1996 2011-06-20 Deniz Dogan <deniz@dogan.se>
1998 * process.c (Fset_process_buffer): Clarify return value in
2001 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2003 * dispnew.c (add_window_display_history): Use BVAR.
2005 * xdisp.c (debug_method_add): Use BVAR.
2006 (check_window_end, dump_glyph_matrix, dump_glyph)
2007 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2009 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2012 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2013 check till after the cache is created in init_frame_faces.
2015 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2017 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2019 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2021 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2022 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2023 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2025 Improve buffer-overflow checking (Bug#8873).
2026 * fileio.c (Finsert_file_contents):
2027 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2028 Remove the old (too-loose) buffer overflow checks.
2029 They weren't needed, since make_gap checks for buffer overflow.
2030 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2031 The old code merely checked for Emacs fixnum overflow, and relied
2032 on undefined (wraparound) behavior. The new code avoids undefined
2033 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2035 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2036 Tune. Don't use wider integers than needed. Don't use alloca.
2037 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2039 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2041 * insdel.c, lisp.h (buffer_overflow): New function.
2042 (insert_from_buffer_1, replace_range, replace_range_2):
2043 * insdel.c (make_gap_larger):
2044 * editfns.c (Finsert_char):
2045 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2047 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2049 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2051 Integer overflow and signedness fixes (Bug#8873).
2053 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2054 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2056 * fileio.c: Don't assume EMACS_INT fits in off_t.
2057 (emacs_lseek): New static function.
2058 (Finsert_file_contents, Fwrite_region): Use it.
2059 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2061 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2063 * fns.c: Don't overflow int when computing a list length.
2064 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2065 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2066 truncation on 64-bit hosts. Check for QUIT every
2067 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2068 faster and is responsive enough.
2069 (Flength): Report an error instead of overflowing an integer.
2070 (Fsafe_length): Return a float if the value is not representable
2071 as a fixnum. This shouldn't happen except in contrived situations.
2072 (Fnthcdr, Fsort): Don't assume list length fits in int.
2073 (Fcopy_sequence): Don't assume vector length fits in int.
2075 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2076 (header_size, word_size): New constants.
2077 (allocate_vectorlike): Don't check size overflow here.
2078 (allocate_vector): Check it here instead, since this is the only
2079 caller of allocate_vectorlike that could cause overflow.
2080 Check that the new vector's length is representable as a fixnum.
2082 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2083 The previous code was bogus. For example, next_almost_prime (32)
2084 returned 39, which is undesirable as it is a multiple of 3; and
2085 next_almost_prime (24) returned 25, which is a multiple of 5 so
2086 why was the code bothering to check for multiples of 7?
2088 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2090 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2092 Variadic C functions now count arguments with ptrdiff_t.
2093 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2094 Back then I didn't know that the Emacs coding style prefers signed int.
2095 Also, in the meantime I found a few more instances where arguments
2096 were being counted with int, which may truncate counts on 64-bit
2097 machines, or EMACS_INT, which may be unnecessarily wide.
2098 * lisp.h (struct Lisp_Subr.function.aMANY)
2099 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2100 Arg counts are now ptrdiff_t, not size_t.
2101 All variadic functions and their callers changed accordingly.
2102 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2103 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2104 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2105 * callint.c (Fcall_interactively): Check arg count for overflow,
2106 to avoid potential buffer overrun. Use signed char, not 'int',
2107 for 'varies' array, so that we needn't bother to check its size
2108 calculation for overflow.
2109 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2110 * eval.c (apply_lambda):
2111 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2112 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2113 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2115 * callint.c (Fcall_interactively): Don't use index var as event count.
2117 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2118 * mem-limits.h (SIZE): Remove; no longer used.
2120 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2122 Remove unnecessary casts.
2123 * xterm.c (x_term_init):
2124 * xfns.c (x_set_border_pixel):
2125 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2126 These aren't needed now that we assume ANSI C.
2128 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2129 It's more likely to cause problems (due to unsigned overflow)
2132 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2134 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2136 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2138 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2140 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2142 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2144 GLYPH_CODE_FACE returns EMACS_INT, not int.
2145 * dispextern.h (merge_faces):
2146 * xfaces.c (merge_faces):
2147 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2148 Don't assume EMACS_INT fits in int.
2150 * character.h (CHAR_VALID_P): Remove unused parameter.
2151 * fontset.c, lisp.h, xdisp.c: All uses changed.
2153 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2155 * fns.c (concat): Minor tuning based on overflow analysis.
2156 This doesn't fix any bugs. Use int to hold character, instead
2157 of constantly refetching from Emacs object. Use XFASTINT, not
2158 XINT, for value known to be a character. Don't bother comparing
2159 a single byte to 0400, as it's always less.
2161 * floatfns.c (Fexpt):
2162 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2164 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2167 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2169 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2170 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2171 incorrectly succeed when S was a string, because 4294967386 was
2172 truncated before it was used.
2174 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2175 Otherwise, an out-of-range integer could cause undefined behavior
2178 * composite.c: Use int, not EMACS_INT, for characters.
2179 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2180 EMACS_INT, for values that are known to be in character range.
2181 This doesn't fix any bugs but is the usual style inside Emacs and
2182 may generate better code on 32-bit machines.
2184 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2185 This is for reasons similar to the recent CHAR_STRING fix.
2186 * charset.c (Fencode_char): Check that character arg is actually
2187 a character. Pass an int to ENCODE_CHAR.
2188 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2189 wider than 'int', as a compile-time check to prevent future regressions
2192 * character.c (char_string): Remove unnecessary casts.
2194 Make sure a 64-bit char is never passed to CHAR_STRING.
2195 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2196 by silently ignoring the top 32 bits, allowing some values
2197 that were far too large to be valid characters.
2198 * character.h: Include <verify.h>.
2199 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2200 arguments are no wider than unsigned, as a compile-time check
2201 to prevent future regressions in this area.
2203 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2204 (Fsubst_char_in_region):
2206 * xdisp.c (decode_mode_spec_coding):
2207 Adjust to CHAR_STRING's new requirement.
2208 * editfns.c (Finsert_char, Fsubst_char_in_region):
2209 * fns.c (concat): Check that character args are actually
2210 characters. Without this test, these functions did the wrong
2211 thing with wildly out-of-range values on 64-bit hosts.
2213 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2214 These casts should not be needed on 32-bit hosts, either.
2215 * keyboard.c (read_char):
2216 * lread.c (Fload): Remove casts to unsigned.
2218 * lisp.h (UNSIGNED_CMP): New macro.
2219 This fixes comparison bugs on 64-bit hosts.
2220 (ASCII_CHAR_P): Use it.
2221 * casefiddle.c (casify_object):
2222 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2223 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2224 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2225 * dispextern.h (FACE_FROM_ID):
2226 * keyboard.c (read_char): Use UNSIGNED_CMP.
2228 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2229 not to EMACS_INT, to avoid GCC warning.
2231 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2233 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2234 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2235 isn't needed on 32-bit machines.
2237 * buffer.c (Fgenerate_new_buffer_name):
2238 Use EMACS_INT for count, not int.
2239 (advance_to_char_boundary): Return EMACS_INT, not int.
2241 * data.c (Qcompiled_function): Now static.
2243 * window.c (window_body_lines): Now static.
2245 * image.c (gif_load): Rename local to avoid shadowing.
2247 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2248 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2249 * alloc.c (make_save_value): Integer argument is now of type
2251 (mark_object): Use ptrdiff_t, not int.
2252 * lisp.h (pD): New macro.
2253 * print.c (print_object): Use it.
2255 * alloc.c: Use EMACS_INT, not int, to count objects.
2256 (total_conses, total_markers, total_symbols, total_vector_size)
2257 (total_free_conses, total_free_markers, total_free_symbols)
2258 (total_free_floats, total_floats, total_free_intervals)
2259 (total_intervals, total_strings, total_free_strings):
2260 Now EMACS_INT, not int. All uses changed.
2261 (Fgarbage_collect): Compute overall total using a double, so that
2262 integer overflow is less likely to be a problem. Check for overflow
2263 when converting back to an integer.
2264 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2265 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2266 These were 'int' variables that could overflow on 64-bit hosts;
2267 they were never used, so remove them instead of repairing them.
2268 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2269 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2270 Previously, this ceilinged at INT_MAX, but that doesn't work on
2272 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2274 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2275 (allocate_vectorlike): Check for ptrdiff_t overflow.
2276 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2277 when a (possibly-narrower) signed value would do just as well.
2278 We prefer using signed arithmetic, to avoid comparison confusion.
2280 * alloc.c: Catch some string size overflows that we were missing.
2281 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2282 for convenience in STRING_BYTES_MAX.
2283 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2284 The definition here is exact; the one in lisp.h was approximate.
2285 (allocate_string_data): Check for string overflow. This catches
2286 some instances we weren't catching before. Also, it catches
2287 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2288 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2289 and ptrdiff_t and EMACS_INT are both 64 bits.
2291 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2292 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2293 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2295 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2297 * alloc.c (Fmake_string): Check for out-of-range init.
2299 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2301 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2303 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2305 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2306 xg_get_default_scrollbar_width.
2308 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2309 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2310 (style_changed_cb): Call update_theme_scrollbar_width and call
2311 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2312 all frames (Bug#8505).
2313 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2314 Call gtk_window_set_resizable if HAVE_GTK3.
2315 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2316 and height if HAVE_GTK3 (Bug#8505).
2317 (scroll_bar_width_for_theme): New variable.
2318 (update_theme_scrollbar_width): New function.
2319 (xg_get_default_scrollbar_width): Move code to
2320 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2321 (xg_initialize): Call update_theme_scrollbar_width.
2323 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2325 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2327 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2329 * frame.c (make_frame): Call other_buffer_safely instead of
2332 * window.c (temp_output_buffer_show): Call display_buffer with
2333 second argument Vtemp_buffer_show_specifiers and reset latter
2334 immediately after the call.
2335 (Vtemp_buffer_show_specifiers): New variable.
2336 (auto_window_vscroll_p, next_screen_context_lines)
2337 (Vscroll_preserve_screen_position): Remove leading asterisks from
2340 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2342 Fix minor problems found by GCC 4.6.0 static checking.
2343 * buffer.c (Qclone_number): Remove for now, as it's unused.
2344 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2345 (record_buffer): Remove unused local.
2346 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2347 (set_frame_buffer_list): Remove; unused.
2348 * frame.h (other_visible_frames): Remove decl.
2349 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2350 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2351 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2353 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2354 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2355 Define only if HAVE_GPM.
2356 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2357 (update_hints_inhibit): Remove; never set. All uses removed.
2358 * widgetprv.h (emacsFrameClassRec): Remove decl.
2359 * window.c (delete_deletable_window): Now returns void, since it
2360 wasn't returning anything.
2361 (compare_window_configurations): Remove unused locals.
2362 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2363 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2364 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2365 the same widths as pointers. This follows up on the 2011-05-06 patch.
2366 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2367 * xterm.h: Likewise.
2368 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2370 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2372 * makefile.w32-in: Update dependencies.
2373 (LISP_H): Add lib/intprops.h.
2375 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2377 * image.c (gif_load): Add animation frame delay to the metadata.
2378 (syms_of_image): Use DEFSYM. New symbol `delay'.
2380 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2382 * window.c (delete_deletable_window): Re-add.
2383 (Fset_window_configuration): Rewrite to handle dead buffers and
2384 consequently deletable windows.
2385 (window_tree, Fwindow_tree): Remove. Supply functionality in
2387 (compare_window_configurations): Simplify code.
2389 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2391 * image.c (imagemagick_load_image): Fix type mismatch.
2392 (Fimagemagick_types): Likewise.
2394 * window.h (replace_buffer_in_windows): Declare.
2396 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2398 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2399 Qclone_number. Remove external declaration of Qdelete_window.
2400 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2402 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2403 Run Qbuffer_list_update_hook if allowed.
2404 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2405 buffer list implementation.
2406 (other_buffer_safely): New function.
2407 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2408 calls to replace_buffer_in_windows and
2409 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2411 (record_buffer): Inhibit quitting and rewrite using quittable
2412 functions. Run Qbuffer_list_update_hook if allowed.
2413 (Frecord_buffer, Funrecord_buffer): New functions.
2414 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2415 Move switch-to-buffer to window.el.
2416 (bury-buffer): Move to window.el.
2417 (Vbuffer_list_update_hook): New variable.
2419 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2422 * window.h (resize_frame_windows): Move up in code.
2423 (Fwindow_frame): Remove EXFUN.
2424 (replace_buffer_in_all_windows): Remove prototype.
2425 (replace_buffer_in_windows_safely): Add prototype.
2427 * window.c: Declare Qdelete_window static again. Move down
2428 declaration of select_count.
2429 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2430 (Fother_window): Move to window.el.
2431 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2432 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2433 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2435 (replace_buffer_in_windows): Implement by calling
2436 Qreplace_buffer_in_windows.
2437 (replace_buffer_in_all_windows): Remove with some functionality
2438 moved into replace_buffer_in_windows_safely.
2439 (replace_buffer_in_windows_safely): New function.
2440 (select_window_norecord, select_frame_norecord): Move in front
2441 of run_window_configuration_change_hook. Remove now obsolete
2443 (Fset_window_buffer): Rewrite doc-string.
2444 Call Qrecord_window_buffer.
2445 (keys_of_window): Move binding for other-window to window.el.
2447 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2449 * dispextern.h (struct image): Replace data member, whose int_val
2450 and ptr_val fields were not used by anything, with a single
2453 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2454 (gif_clear_image, gif_load, imagemagick_load_image)
2455 (gs_clear_image, gs_load): Callers changed.
2457 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2459 * buffer.h: Include <time.h>, for time_t.
2460 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2462 Fix minor problems found by static checking.
2464 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2466 Make identifiers static if they are not used in other modules.
2467 * data.c (Qcompiled_function, Qframe, Qvector):
2468 * image.c (QimageMagick, Qsvg):
2469 * minibuf.c (Qmetadata):
2470 * window.c (resize_window_check, resize_root_window): Now static.
2471 * window.h (resize_window_check, resize_root_window): Remove decls.
2473 * window.c (window_deletion_count, delete_deletable_window):
2475 (window_body_lines): Now static.
2476 (Fdelete_other_windows_internal): Mark vars as initialized.
2477 Make sure 'resize_failed' is initialized.
2478 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2479 (resize_window_apply): Remove unused local.
2480 * window.h (delete_deletable_window): Remove decl.
2482 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2483 (imagemagick_load_image): Fix pointer signedness problem by changing
2484 last arg from unsigned char * to char *. All uses changed.
2485 Also, fix a local for similar reasons.
2486 Remove unused locals. Remove locals to avoid shadowing.
2487 (fn_rsvg_handle_free): Remove; unused.
2488 (svg_load, svg_load_image): Fix pointer signedness problem.
2489 (imagemagick_load_image): Don't use garbage pointer image_wand.
2491 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2493 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2495 * image.c (gif_load): Fix omitted cast error introduced by
2498 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2500 * window.h (resize_proportionally, orig_total_lines)
2501 (orig_top_line): Remove from window structure.
2502 (set_window_height, set_window_width, change_window_heights)
2503 (Fdelete_window): Remove prototypes.
2504 (resize_frame_windows): Remove duplicate declaration.
2506 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2508 * window.h (resize_frame_windows, resize_window_check)
2509 (delete_deletable_window, resize_root_window)
2510 (resize_frame_windows): Declare prototypes.
2512 * window.c (resize_window_apply): Make definition be "static" to
2513 match the prototype.
2515 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2517 * window.c: Remove declarations of Qwindow_size_fixed,
2518 window_min_size_1, window_min_size_2, window_min_size,
2519 size_window, window_fixed_size_p, enlarge_window, delete_window.
2520 Remove static from declaration of Qdelete_window, it's
2521 temporarily needed by Fbury_buffer.
2522 (replace_window): Don't assign orig_top_line and
2524 (Fdelete_window, delete_window): Remove. Window deletion is
2525 handled by window.el.
2526 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2527 Replace Fdelete_window calls with calls to Qdelete_window.
2528 (Fdelete_other_windows): Remove. Deleting other windows is
2529 handled by window.el.
2530 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2531 handled in window.el.
2532 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2533 Window minimum sizes are handled in window.el.
2534 (shrink_windows, size_window, set_window_height)
2535 (set_window_width, change_window_heights, window_height)
2536 (window_width, CURBEG, CURSIZE, enlarge_window)
2537 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2538 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2539 handled in window.el.
2540 (make_dummy_parent): Rename to make_parent_window and give it a
2541 second argument horflag.
2542 (make_window): Don't set resize_proportionally any more.
2543 (Fsplit_window): Remove. Windows are split in window.el.
2544 (save_restore_action, save_restore_orig_size)
2545 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2546 Resize mini windows in window.el.
2547 (grow_mini_window, shrink_mini_window): Implement by calling
2548 Qresize_root_window_vertically, resize_window_check and
2549 resize_window_apply.
2550 (saved_window, Fset_window_configuration, save_window_save):
2551 Do not handle orig_top_line, orig_total_lines, and
2552 resize_proportionally.
2553 (window_min_height, window_min_width): Move to window.el.
2554 (keys_of_window): Move bindings for delete-other-windows,
2555 split-window, delete-window and enlarge-window to window.el.
2557 * buffer.c: Temporarily extern Qdelete_window.
2558 (Fbury_buffer): Temporarily call Qdelete_window instead of
2559 Fdelete_window (Fbury_buffer will move to window.el soon).
2561 * frame.c (set_menu_bar_lines_1): Remove code handling
2562 orig_top_line and orig_total_lines.
2564 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2565 set_window_height but set heights directly.
2566 (change_frame_size_1): Use resize_frame_windows.
2568 * xdisp.c (init_xdisp): Don't use set_window_height but set
2571 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2572 Use resize_frame_windows instead of change_window_heights and run
2573 run_window_configuration_change_hook.
2575 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2576 instead of change_window_heights and run
2577 run_window_configuration_change_hook.
2579 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2581 * window.c (replace_window): Rename second argument REPLACEMENT to
2582 NEW. New third argument SETFLAG. Rewrite.
2583 (delete_window, make_dummy_parent): Call replace_window with
2585 (window_list_1): Move down in code.
2586 (run_window_configuration_change_hook): Move set_buffer part
2587 before select_frame_norecord part in order to unwind correctly.
2588 Rename count1 to count.
2589 (recombine_windows, delete_deletable_window, resize_root_window)
2590 (Fdelete_other_windows_internal)
2591 (Frun_window_configuration_change_hook, make_parent_window)
2592 (resize_window_check, resize_window_apply, Fresize_window_apply)
2593 (resize_frame_windows, Fsplit_window_internal)
2594 (Fdelete_window_internal, Fresize_mini_window_internal):
2596 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2598 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2600 * window.h (window): Add some new members to window structure -
2601 normal_lines, normal_cols, new_total, new_normal, clone_number,
2602 splits, nest, prev_buffers, next_buffers.
2603 (WINDOW_TOTAL_SIZE): Move here from window.c.
2604 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2606 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2608 (make_dummy_parent): Set new members of windows structure.
2609 (make_window): Move down in code. Handle new members of window
2611 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2612 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2613 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2614 (Fset_window_prev_buffers, Fwindow_next_buffers)
2615 (Fset_window_next_buffers, Fset_window_clone_number):
2617 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2618 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2620 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2621 Argument WINDOW can be now internal window too.
2622 (Fwindow_use_time): Move up in code.
2623 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2625 (Fset_window_configuration, saved_window)
2626 (Fcurrent_window_configuration, save_window_save): Handle new
2627 members of window structure.
2628 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2629 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2630 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2631 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2632 Qget_mru_window, Qresize_root_window,
2633 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2634 Qauto_buffer_name; staticpro them.
2636 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2638 * window.c (Fwindow_total_size, Fwindow_left_column)
2639 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2640 (Fwindow_list_1): New functions.
2641 (window_box_text_cols): Replace with window_body_cols.
2642 (Fwindow_width, Fscroll_left, Fscroll_right):
2643 Use window_body_cols instead of window_box_text_cols.
2644 (delete_window, Fset_window_configuration):
2645 Call delete_all_subwindows with window as argument.
2646 (delete_all_subwindows): Take a window as argument and not a
2648 (window_loop): Remove handling of GET_LRU_WINDOW and
2650 (Fget_lru_window, Fget_largest_window): Move to window.el.
2652 * window.h: Extern window_body_cols instead of
2653 window_box_text_cols. delete_all_subwindows now takes a
2654 Lisp_Object as argument.
2656 * indent.c (compute_motion, Fcompute_motion):
2657 Use window_body_cols instead of window_box_text_cols.
2659 * frame.c (delete_frame): Call delete_all_subwindows with root
2662 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2664 * fns.c (Fputhash): Document return value.
2666 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2668 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2670 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2672 Cons<->int and similar integer overflow fixes (Bug#8794).
2674 Check for overflow when converting integer to cons and back.
2675 * charset.c (Fdefine_charset_internal, Fdecode_char):
2676 Use cons_to_unsigned to catch overflow.
2677 (Fencode_char): Use INTEGER_TO_CONS.
2678 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2679 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2680 * data.c (long_to_cons, cons_to_long): Remove.
2681 (cons_to_unsigned, cons_to_signed): New functions.
2682 These signal an error for invalid or out-of-range values.
2683 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2684 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2685 * font.c (Ffont_variation_glyphs):
2686 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2687 * lisp.h: Include <intprops.h>.
2688 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2689 (cons_to_signed, cons_to_unsigned): New decls.
2690 (long_to_cons, cons_to_long): Remove decls.
2691 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2692 (Fprimitive_undo): Use CONS_TO_INTEGER.
2693 * xfns.c (Fx_window_property): Likewise.
2694 * xselect.c: Include <limits.h>.
2695 (x_own_selection, selection_data_to_lisp_data):
2696 Use INTEGER_TO_CONS.
2697 (x_handle_selection_request, x_handle_selection_clear)
2698 (x_get_foreign_selection, Fx_disown_selection_internal)
2699 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2700 (lisp_data_to_selection_data): Use cons_to_unsigned.
2701 (x_fill_property_data): Use cons_to_signed.
2702 Report values out of range.
2704 Check for buffer and string overflow more precisely.
2705 * buffer.h (BUF_BYTES_MAX): New macro.
2706 * lisp.h (STRING_BYTES_MAX): New macro.
2707 * alloc.c (Fmake_string):
2708 * character.c (string_escape_byte8):
2709 * coding.c (coding_alloc_by_realloc):
2710 * doprnt.c (doprnt):
2711 * editfns.c (Fformat):
2713 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2714 since they may not be the same number.
2715 * editfns.c (Finsert_char):
2716 * fileio.c (Finsert_file_contents):
2717 Likewise for BUF_BYTES_MAX.
2719 * image.c: Use ptrdiff_t, not int, for sizes.
2720 (slurp_file): Switch from int to ptrdiff_t.
2722 (slurp_file): Check that file size fits in both size_t (for
2723 malloc) and ptrdiff_t (for sanity and safety).
2725 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2726 if b->modtime has its maximal value.
2728 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2730 Don't assume time_t can fit into int.
2731 * buffer.h (struct buffer.modtime): Now time_t, not int.
2732 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2733 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2735 Minor fixes for signed vs unsigned integers.
2736 * character.h (MAYBE_UNIFY_CHAR):
2737 * charset.c (maybe_unify_char):
2738 * keyboard.c (read_char, reorder_modifiers):
2739 XINT -> XFASTINT, since the integer must be nonnegative.
2740 * ftfont.c (ftfont_spec_pattern):
2741 * keymap.c (access_keymap, silly_event_symbol_error):
2742 XUINT -> XFASTINT, since the integer must be nonnegative.
2743 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2744 since it makes no difference and we prefer signed.
2745 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2746 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2749 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2751 * window.h (Fwindow_frame): Declare.
2753 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2755 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2756 (SPARE_MEMORY): Always define.
2757 (LARGE_REQUEST): Remove.
2758 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2760 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2762 * lisp.h: Move EXFUNS for Fframe_root_window,
2763 Fframe_first_window and Fset_frame_selected_window to window.h.
2765 * window.h: Move EXFUNS for Fframe_root_window,
2766 Fframe_first_window and Fset_frame_selected_window here from
2769 * frame.c (Fwindow_frame, Fframe_first_window)
2770 (Fframe_root_window, Fframe_selected_window)
2771 (Fset_frame_selected_window): Move to window.c.
2772 (Factive_minibuffer_window): Move to minibuf.c.
2773 (Fother_visible_frames_p): New function.
2775 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2777 * window.c (decode_window, decode_any_window): Move up in code.
2778 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2779 (inhibit_frame_unsplittable): Remove unused variable.
2780 (Fwindow_buffer): Move up and rewrite doc-string.
2781 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2782 (Fwindow_prev): New functions.
2783 (Fwindow_frame): Move here from frame.c. Accept any window as
2785 (Fframe_root_window, Fframe_first_window)
2786 (Fframe_selected_window): Move here from frame.c. Accept frame
2787 or arbitrary window as argument. Update doc-strings.
2788 (Fminibuffer_window): Move up in code.
2789 (Fwindow_minibuffer_p): Move up in code and simplify.
2790 (Fset_frame_selected_window): Move here from frame.c.
2792 (Fselected_window, select_window, Fselect_window): Move up in
2793 code. Minor doc-string fixes.
2795 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2797 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2798 Do not assume that spare memory exists; that assumption is valid
2799 only if SYSTEM_MALLOC.
2800 (LARGE_REQUEST): New macro, so that the issue of large requests
2801 is separated from the issue of spare memory.
2803 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2805 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2808 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2810 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2813 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2815 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2817 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2819 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2820 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2822 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2824 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2826 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2828 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2829 (x_clipboard_manager_save): Add return value.
2830 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2832 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2833 Obey Vx_select_enable_clipboard_manager. Catch errors in
2834 x_clipboard_manager_save (Bug#8779).
2835 (Vx_select_enable_clipboard_manager): New variable.
2836 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2838 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2840 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2842 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2844 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2845 in the current matrix if keep_current_p is non-zero.
2847 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2849 * bidi.c (bidi_level_of_next_char): Fix last change.
2851 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2853 Support bidi reordering of text covered by display properties.
2855 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2856 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2857 (bidi_cache_search, bidi_cache_iterator_state)
2858 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2859 (bidi_level_of_next_char, bidi_move_to_visually_next):
2860 Support character positions inside a run of characters covered by a
2862 (bidi_paragraph_init, bidi_resolve_explicit_1)
2863 (bidi_level_of_next_char): Call bidi_fetch_char and
2864 bidi_fetch_char_advance instead of FETCH_CHAR and
2866 (bidi_init_it): Initialize new members.
2867 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2869 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2870 instead of using explicit *_CHAR codes.
2871 (bidi_resolve_explicit, bidi_resolve_weak):
2872 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2873 bidirectional text is supported only in multibyte buffers.
2874 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2875 it to initialize the frame_window_p member of struct bidi_it.
2876 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2877 (bidi_resolve_explicit, bidi_resolve_weak)
2878 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2879 bidi_it->nchars is non-positive.
2880 (bidi_level_of_next_char): Don't try to lookup the cache for the
2881 next/previous character if nothing is cached there yet, or if we
2882 were just reseat()'ed to a new position.
2884 * xdisp.c (set_cursor_from_row): Set start and stop points
2885 according to the row's direction when priming the loop that looks
2886 for the glyph on which to display cursor.
2887 (single_display_spec_intangible_p): Function deleted.
2888 (display_prop_intangible_p): Reimplement to call
2889 handle_display_spec instead of single_display_spec_intangible_p.
2890 Accept 3 additional arguments needed by handle_display_spec.
2891 This fixes incorrect cursor motion across display property with complex
2892 values: lists, `(when COND...)' forms, etc.
2893 (single_display_spec_string_p): Support property values that are
2894 lists with the argument STRING its top-level element.
2895 (display_prop_string_p): Fix the condition for processing a
2896 property that is a list to be consistent with handle_display_spec.
2897 (handle_display_spec): New function, refactored from the
2898 last portion of handle_display_prop.
2899 (compute_display_string_pos): Accept additional argument
2900 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2901 value of a `display' property is a "replacing spec".
2902 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2903 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2904 the display property, but just return a value indicating whether
2905 the display property will replace the characters it covers.
2906 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2907 frame_window_p members of struct bidi_it.
2908 (compute_display_string_pos, compute_display_string_end):
2910 (push_it): Accept second argument POSITION, where pop_it should
2911 jump to continue iteration.
2912 (reseat_1): Initialize bidi_it.disp_pos.
2914 * keyboard.c (adjust_point_for_property): Adjust the call to
2915 display_prop_intangible_p to its new signature.
2917 * dispextern.h (struct bidi_it): New member frame_window_p.
2918 (bidi_init_it): Update prototypes.
2919 (display_prop_intangible_p): Update prototype.
2920 (compute_display_string_pos, compute_display_string_end):
2922 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2925 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2927 Malloc failure behavior now depends on size of allocation.
2928 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2929 * lisp.h: Change signatures accordingly.
2930 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2931 All callers changed. (Bug#8762)
2933 * gnutls.c: Use Emacs's memory allocators.
2934 Without this change, the gnutls library would invoke malloc etc.
2935 directly, which causes problems on non-SYNC_INPUT hosts, and which
2936 runs afoul of improving memory_full behavior. (Bug#8761)
2937 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2938 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2939 xfree instead of the default malloc, realloc, free.
2940 (Fgnutls_boot): No need to check for memory allocation failure,
2941 since xmalloc does that for us.
2943 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2944 * category.c (hash_get_category_set):
2945 * ccl.c (ccl_driver):
2946 * charset.c (Fdefine_charset_internal):
2947 * charset.h (struct charset.hash_index):
2948 * composite.c (get_composition_id, gstring_lookup_cache)
2949 (composition_gstring_put_cache):
2950 * composite.h (struct composition.hash_index):
2951 * dispextern.h (struct image.hash):
2952 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2953 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2954 (hashfn_equal, hashfn_user_defined, make_hash_table)
2955 (maybe_resize_hash_table, hash_lookup, hash_put)
2956 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2957 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2958 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2959 * image.c (make_image, search_image_cache, lookup_image)
2960 (xpm_put_color_table_h):
2961 * lisp.h (struct Lisp_Hash_Table):
2962 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2963 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2964 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2965 * alloc.c (allocate_vectorlike):
2966 Check for overflow in vector size calculations.
2967 * ccl.c (ccl_driver):
2968 Check for overflow when converting EMACS_INT to int.
2969 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2970 need to be updated by these changes.
2971 * fns.c (make_hash_table, maybe_resize_hash_table):
2972 Check for integer overflow with large hash tables.
2973 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2974 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2975 (SXHASH_REDUCE): New macro.
2976 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2977 Use it instead of discarding useful hash info with large hash values.
2978 (sxhash_float): New function.
2979 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2980 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2981 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2982 Rewrite to use FIXNUM_BITS, as this simplifies things.
2983 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2984 Adjust signatures to match updated version of code.
2985 (consing_since_gc): Now EMACS_INT, since a single hash table can
2986 use more than INT_MAX bytes.
2988 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2990 Make it possible to build with GCC-4.6+ -O2 -flto.
2992 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2994 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2996 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2997 Call minibuffer-inactive-mode.
2999 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3001 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3002 Update dependencies.
3004 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3006 * data.c (init_data): Remove code for UTS, this system is not
3009 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3011 Don't force ./temacs to start in terminal mode.
3013 * frame.c (make_initial_frame): Initialize faces in all cases, not
3014 only when CANNOT_DUMP is defined.
3015 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3017 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3019 * dispnew.c (add_window_display_history): Use const for the string
3020 pointer. Remove declaration, not needed.
3022 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3024 Use 'inline', not 'INLINE'.
3025 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3026 * alloc.c, fontset.c (INLINE): Remove.
3027 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3028 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3029 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3030 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3031 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3033 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3035 Make it possible to run ./temacs.
3037 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3038 syms_of_callproc does the same thing. Remove test for
3039 "initialized", do it in the caller.
3040 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3042 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3044 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3045 (read_minibuf): Use get_minibuffer.
3046 (syms_of_minibuf): Use DEFSYM.
3047 (Qmetadata): New var.
3048 * data.c (Qbuffer): Don't make it static.
3049 (syms_of_data): Use DEFSYM.
3051 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3053 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3054 (CCL_CODE_MIN): New macro.
3056 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3058 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3060 * eval.c (Qdebug): Now static.
3061 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3062 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3063 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3065 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3067 * image.c: Various fixes to ImageMagick code comments.
3068 (Fimagemagick_types): Doc fix.
3070 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3072 Minor fixes prompted by GCC 4.6.0 warnings.
3074 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3076 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3077 (x_clipboard_manager_save_all): Move extern decl to ...
3078 * xterm.h: ... here, so that it can be checked for consistency.
3080 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3082 * xselect.c (x_clipboard_manager_save_frame)
3083 (x_clipboard_manager_save_all): New functions.
3084 (Fx_clipboard_manager_save): Lisp function deleted.
3086 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3087 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3089 * xterm.h: Update prototype.
3091 2011-05-28 William Xu <william.xwl@gmail.com>
3093 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3096 2011-05-28 Jim Meyering <meyering@redhat.com>
3098 Avoid a sign-extension bug in crypto_hash_function.
3099 * fns.c (to_uchar): Define.
3100 (crypto_hash_function): Use it to convert some newly-signed
3101 variables to unsigned, to avoid sign-extension bugs. For example,
3102 without this change, (md5 "truc") would evaluate to
3103 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3104 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3105 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3107 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3109 Integer overflow fixes.
3111 * dbusbind.c: Serial number integer overflow fixes.
3112 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3113 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3114 to hold a serial number that is too large for a fixnum.
3115 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3116 Check for serial numbers out of range. Decode any serial number
3117 that was so large that it became a float. (Bug#8722)
3119 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3120 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3121 Use XFASTINT rather than XUINT when numbers are nonnegative.
3122 (xd_append_arg, Fdbus_method_return_internal):
3123 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3124 arguments, check that Lisp number is nonnegative, rather than
3125 silently wrapping negative numbers around. (Bug#8722)
3126 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3129 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3131 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3133 ccl: add integer overflow checks
3134 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3135 (IN_INT_RANGE): New macros.
3136 (ccl_driver): Use them to check for integer overflow when
3137 decoding a CCL program. Many of the new checks are whether XINT (x)
3138 fits in int; it doesn't always, on 64-bit hosts. The new version
3139 doesn't catch all possible integer overflows, but it's an
3140 improvement. (Bug#8719)
3142 * alloc.c (make_event_array): Use XINT, not XUINT.
3143 There's no need for unsigned here.
3145 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3146 This follows up to the 2011-05-06 change that substituted uintptr_t
3147 for EMACS_INT. This case wasn't caught back then.
3149 Rework Fformat to avoid integer overflow issues.
3150 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3151 now (part of C89). Include <verify.h>.
3152 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3153 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3154 (Fformat): Avoid the prepass trying to compute sizes; it was only
3155 approximate and thus did not catch overflow reliably. Instead, walk
3156 through the format just once, formatting and computing sizes as we go,
3157 checking for integer overflow at every step, and allocating a larger
3158 buffer as needed. Keep track separately whether the format is
3159 multibyte. Keep only the most-recently calculated precision, rather
3160 than them all. Record whether each argument has been converted to
3161 string. Use EMACS_INT, not int, for byte and char and arg counts.
3162 Support field widths and precisions larger than INT_MAX. Avoid
3163 sprintf's undefined behavior with conversion specifications such as %#d
3164 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3165 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3166 formatting out-of-range floating point numbers with int
3169 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3171 * data.c: Avoid integer truncation in expressions involving floats.
3172 * data.c: Include <intprops.h>.
3173 (arith_driver): When there's an integer overflow in an expression
3174 involving floating point, convert the integers to floating point
3175 so that the resulting value does not suffer from catastrophic
3176 integer truncation. For example, on a 64-bit host (* 4
3177 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3178 Do not rely on undefined behavior after integer overflow.
3180 merge count_size_as_multibyte, parse_str_to_multibyte
3181 * character.c, character.h (count_size_as_multibyte):
3182 Rename from parse_str_to_multibyte; all uses changed.
3183 Check for integer overflow.
3184 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3185 since it's now a duplicate of the other. This is more of
3186 a character than a buffer op, so better that it's in character.c.
3187 * fns.c, print.c: Adjust to above changes.
3189 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3191 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3193 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3195 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3196 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3197 (x_clipboard_manager_save): Now static.
3198 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3200 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3201 (crypto_hash_function): Now static.
3202 Fix pointer signedness problems. Avoid unnecessary initializations.
3204 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3206 * termhooks.h (Vselection_alist): Make it terminal-local.
3208 * terminal.c (create_terminal): Initialize it.
3210 * xselect.c: Support for clipboard managers.
3211 (Vselection_alist): Move to termhooks.h as terminal-local var.
3212 (LOCAL_SELECTION): New macro.
3213 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3214 (symbol_to_x_atom): Remove gratuitous arg.
3215 (x_handle_selection_request, lisp_data_to_selection_data)
3216 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3217 (x_own_selection, x_get_local_selection, x_convert_selection):
3218 New arg, specifying work frame. Use terminal-local Vselection_alist.
3219 (some_frame_on_display): Delete unused function.
3220 (Fx_own_selection_internal, Fx_get_selection_internal)
3221 (Fx_disown_selection_internal, Fx_selection_owner_p)
3222 (Fx_selection_exists_p): New optional frame arg.
3223 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3224 (x_handle_selection_clear): Don't treat other terminals with the
3225 same keyboard specially. Use the terminal-local Vselection_alist.
3226 (x_clear_frame_selections): Use Frun_hook_with_args.
3228 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3230 * xterm.h: Add support for those atoms.
3232 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3234 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3235 (converted_selections, conversion_fail_tag): New global variables.
3236 (x_selection_request_lisp_error): Free the above.
3237 (x_get_local_selection): Remove unnecessary code.
3238 (x_reply_selection_request): Args changed; handle arbitrary array
3239 of converted selections stored in converted_selections.
3240 Separate the XChangeProperty and SelectionNotify steps.
3241 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3242 (x_convert_selection): New function.
3243 (x_handle_selection_event): Simplify.
3244 (x_get_foreign_selection): Don't ignore incoming requests while
3245 waiting for an answer; this will fail when we implement
3246 SAVE_TARGETS, and seems unnecessary anyway.
3247 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3248 (Vx_sent_selection_functions): Doc fix.
3250 2011-05-26 Leo Liu <sdl.web@gmail.com>
3252 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3254 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3256 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3258 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3259 for fringe update if it has periodic bitmap.
3260 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3261 and fringe_bitmap_periodic_p.
3263 * fringe.c (get_fringe_bitmap_data): New function.
3264 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3265 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3266 row. Mark glyph row for fringe update if periodicity changed.
3268 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3269 for fringe update unless it has periodic bitmap.
3271 2011-05-25 Kenichi Handa <handa@m17n.org>
3273 * xdisp.c (get_next_display_element): Set correct it->face_id for
3274 a static composition.
3276 2011-05-24 Leo Liu <sdl.web@gmail.com>
3279 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3281 * fns.c (crypto_hash_function, Fsha1): New function.
3282 (Fmd5): Use crypto_hash_function.
3283 (syms_of_fns): Add Ssha1.
3285 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3287 * gnutls.c: Remove unused macros.
3288 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3289 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3290 Remove macros that are defined and never used.
3291 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3293 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3295 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3296 (Fx_get_selection_internal): Minor cleanup.
3297 (Fx_own_selection_internal): Rename arguments for consistency with
3300 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3302 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3304 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3306 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3308 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3310 * dispnew.c (scrolling_window): Don't exclude the case that the
3311 last enabled row in the desired matrix touches the bottom boundary.
3313 2011-05-21 Glenn Morris <rgm@gnu.org>
3315 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3316 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3317 and add some more files.
3319 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3321 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3322 report_file_error introduced by the change from 2011-05-07.
3324 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3326 * systime.h (Time): Define only if emacs is defined.
3327 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3328 where the include path doesn't have X11/X.h by default. See
3329 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3331 2011-05-20 Kenichi Handa <handa@m17n.org>
3333 * composite.c (find_automatic_composition): Fix previous change.
3335 2011-05-20 Glenn Morris <rgm@gnu.org>
3337 * lisp.mk: New file, split from Makefile.in.
3338 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3339 (shortlisp): Remove.
3340 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3342 2011-05-19 Glenn Morris <rgm@gnu.org>
3344 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3345 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3346 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3347 (lisp): Set the order to that of loadup.el.
3348 (shortlisp): Make it a copy of $lisp.
3349 (SOME_MACHINE_LISP): Remove.
3350 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3351 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3353 2011-05-18 Kenichi Handa <handa@m17n.org>
3355 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3356 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3357 (find_automatic_composition): Mostly rewrite for efficiency.
3359 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3361 * makefile.w32-in: Update dependencies.
3363 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3365 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3366 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3368 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3370 Fix some integer overflow issues, such as string length overflow.
3372 * insdel.c (count_size_as_multibyte): Check for string overflow.
3374 * character.c (lisp_string_width): Check for string overflow.
3375 Use EMACS_INT, not int, for string indexes and lengths; in
3376 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3377 the resulting string length overflows an EMACS_INT; instead,
3378 report a string overflow if no precision given. When checking for
3379 precision exhaustion, use a check that cannot possibly have
3380 integer overflow. (Bug#8675)
3381 * character.h (lisp_string_width): Adjust to new signature.
3383 * alloc.c (string_overflow): New function.
3384 (Fmake_string): Use it. This doesn't change behavior, but saves
3385 a few bytes and will simplify future changes.
3386 * character.c (string_escape_byte8): Likewise.
3387 * lisp.h (string_overflow): New decl.
3389 Fixups, following up to the user-interface timestamp change.
3390 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3391 for UI timestamps, instead of unsigned long.
3392 * msdos.c (mouse_get_pos): Likewise.
3393 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3394 * w32gui.h (Time): Define by including "systime.h" rather than by
3395 declaring it ourselves. (Bug#8664)
3397 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3398 * image.c (clear_image_cache): Likewise.
3400 * term.c (term_mouse_position): Don't assume time_t wraparound.
3402 Be more systematic about user-interface timestamps.
3403 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3404 and sometimes 'EMACS_UINT', to represent these timestamps.
3405 This change causes it to use 'Time' uniformly, as that's what X uses.
3406 This makes the code easier to follow, and makes it easier to catch
3407 integer overflow bugs such as Bug#8664.
3408 * frame.c (Fmouse_position, Fmouse_pixel_position):
3409 Use Time, not unsigned long, for user-interface timestamps.
3410 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3411 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3412 * keyboard.h (last_event_timestamp): Likewise.
3413 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3414 * menu.h (xmenu_show): Likewise.
3415 * term.c (term_mouse_position): Likewise.
3416 * termhooks.h (struct input_event.timestamp): Likewise.
3417 (struct terminal.mouse_position_hook): Likewise.
3418 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3419 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3420 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3421 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3423 * menu.h, termhooks.h: Include "systime.h", for Time.
3425 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3426 Don't assume that the difference between two unsigned long values
3427 can fit into an integer. At this point, we know button_down_time
3428 <= event->timestamp, so the difference must be nonnegative, so
3429 there's no need to cast the result if double-click-time is
3430 nonnegative, as it should be; check that it's nonnegative, just in
3431 case. This bug is triggered when events are more than 2**31 ms
3432 apart (about 25 days). (Bug#8664)
3434 * xselect.c (last_event_timestamp): Remove duplicate decl.
3435 (x_own_selection): Remove needless cast to unsigned long.
3437 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3438 that always fit in int. Use a sentinel instead of a counter, to
3439 avoid a temp and to allay GCC's concerns about possible int overflow.
3440 * frame.h (struct frame): Use int for menu_bar_items_used
3441 instead of EMACS_INT, since it always fits in int.
3443 * menu.c (grow_menu_items): Check for int overflow.
3445 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3447 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3448 Before, the code was not consistent. These values cannot exceed
3449 2**31 - 1 so there's no need to make them unsigned.
3450 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3451 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3452 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3454 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3456 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3457 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3458 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3459 presumably because the widths might not match.
3461 * window.c (size_window): Avoid needless test at loop start.
3463 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3465 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3467 2011-05-12 Drew Adams <drew.adams@oracle.com>
3469 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3471 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3473 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3474 `width' to `bar_area_x' and `bar_area_width', respectively.
3475 (x_scroll_run): Take account of fringe background extension.
3477 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3478 Rename local vars `left' and `width' to `bar_area_x' and
3479 `bar_area_width', respectively.
3480 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3481 background extension.
3483 2011-05-10 Jim Meyering <meyering@redhat.com>
3485 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3487 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3489 * image.c (Finit_image_library): Return t for built-in image types,
3490 like pbm and xbm. (Bug#8640)
3492 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3494 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3496 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3498 * w32console.c (Fset_screen_color): Doc fix.
3499 (Fget_screen_color): New function.
3500 (syms_of_ntterm): Defsubr it.
3502 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3503 unlink the temporary file if Fcall_process didn't create it in the
3505 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3506 child process will be redirected to a file specified with `:file'.
3507 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3508 cue to call_process_cleanup not to close that handle.
3510 2011-05-07 Ben Key <bkey76@gmail.com>
3512 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3513 one of two shell specific rules, either bootstrap-temacs-CMD or
3514 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3515 to the previous implementation of the bootstrap-temacs rule.
3516 The bootstrap-temacs-CMD rule is similar to the previous
3517 implementation of the bootstrap-temacs rule except that it
3518 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3521 These changes, along with some changes to nt/configure.bat,
3522 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3523 earlier fix to add support for --cflags and --ldflags options
3524 that include quotes so that it works whether make uses cmd or
3527 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3529 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3530 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3532 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3533 a string. Handle both cases.
3534 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3535 (Fdbus_register_method): Use Qinvalid_function.
3537 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3539 * makefile.w32-in: Update dependencies.
3540 (LISP_H): Add inttypes.h and stdin.h.
3541 (PROCESS_H): Add unistd.h.
3543 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3545 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3546 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3548 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3550 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3552 * term.c (vfatal): Remove stray call to va_end.
3553 It's not needed and the C Standard doesn't allow it here anyway.
3555 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3556 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3558 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3561 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3563 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3565 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3567 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3569 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3571 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3572 * charset.c (Fdefine_charset_internal): Don't initialize
3573 charset.code_space[15]. The value was garbage, on hosts with
3574 32-bit int (Bug#8600).
3576 * lread.c (read_integer): Be more consistent with string-to-number.
3577 Use string_to_number to do the actual conversion; this avoids
3578 rounding errors and fixes some other screwups. Without this fix,
3579 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3580 (digit_to_number): Move earlier, for benefit of read_integer.
3581 Return -1 if the digit is out of range for the base, -2 if it is
3582 not a digit in any supported base. (Bug#8602)
3584 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3586 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3587 to match comment at start of function. This also removes a
3588 GCC warning about overflow in a 32+64-bit port.
3590 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3592 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3593 Reported by Stefan Monnier in
3594 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3595 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3596 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3598 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3599 (EMACS_UINTPTR): Likewise, with uintptr_t.
3601 * lisp.h: Prefer 64-bit EMACS_INT if available.
3602 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3603 on 32-bit hosts that have 64-bit int, so that they can access
3605 However, temporarily disable this change unless the temporary
3606 symbol WIDE_EMACS_INT is defined.
3608 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3610 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3611 This removes an assumption that EMACS_INT and long are the same
3612 width as pointers. The assumption is true for Emacs porting targets
3613 now, but we want to make other targets possible.
3614 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3615 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3616 In the rest of the code, change types of integers that hold casted
3617 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3618 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3619 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3620 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3621 No need to cast type when ORing.
3622 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3623 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3624 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3625 assume EMACS_INT is the same width as char *.
3626 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3627 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3628 Remove no-longer-needed casts.
3629 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3630 (xg_tool_bar_help_callback, xg_make_tool_item):
3631 Use EMACS_INTPTR to hold an integer
3632 that will be cast to void *; this can avoid a GCC warning
3633 if EMACS_INT is not the same width as void *.
3634 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3635 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3636 (current_message_1, set_message_1):
3637 Use a local to convert to proper width without a cast.
3638 * xmenu.c (dialog_selection_callback): Likewise.
3640 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3641 Also, don't assume VALBITS / RAND_BITS is less than 5,
3642 and don't rely on undefined behavior when shifting a 1 left into
3644 * lisp.h (get_random): Change signature to match.
3646 * lread.c (hash_string): Use size_t, not int, for hash computation.
3647 Normally we prefer signed values; but hashing is special, because
3648 it's better to use unsigned division on hash table sizes so that
3649 the remainder is nonnegative. Also, size_t is the natural width
3650 for hashing into memory. The previous code used 'int', which doesn't
3651 retain enough info to hash well into very large tables.
3652 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3654 * dbusbind.c: Don't possibly lose pointer info when converting.
3655 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3656 Use XPNTR rather than XHASH, so that the high-order bits of
3657 the pointer aren't lost when converting through void *.
3659 * eval.c (Fautoload): Don't double-shift a pointer.
3661 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3663 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3665 * gnutls.c (DEF_GNUTLS_FN):
3666 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3668 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3670 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3673 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3675 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3676 New version that can reserve upto 2GB of heap space.
3678 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3680 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3682 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3684 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3685 `gnutls_certificate_set_x509_key_file'.
3687 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3689 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3690 Update dependencies.
3692 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3694 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3695 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3696 Remove unused parameter `fildes'.
3697 * process.c (read_process_output, send_process): Don't pass it.
3699 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3701 Fix previous change: the library cache is defined in w32.c.
3702 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3703 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3705 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3707 Implement dynamic loading of GnuTLS on Windows.
3709 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3710 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3711 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3714 * gnutls.c (Qgnutls_dll): Define.
3715 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3716 (gnutls_*): Declare function pointers.
3717 (init_gnutls_functions): New function to initialize function pointers.
3718 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3719 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3720 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3721 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3722 (emacs_gnutls_write, emacs_gnutls_read)
3723 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3724 (Fgnutls_available_p): New function.
3725 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3726 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3727 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3729 * image.c: Include w32.h.
3730 (Vimage_type_cache): Delete.
3731 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3732 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3733 (w32_delayed_load): Move to w32.c.
3735 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3737 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3738 (w32_delayed_load): Move from image.c. When loading a library, record
3739 its filename in the :loaded-from property of the library id.
3740 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3741 Initialize and staticpro them.
3742 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3744 * process.c: Include lisp.h before w32.h, not after.
3745 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3746 instead of gnutls_record_check_pending.
3748 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3750 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3752 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3753 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3756 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3758 * xterm.c (x_set_frame_alpha): Do not set property on anything
3759 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3761 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3763 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3765 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3767 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3768 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3769 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3770 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3771 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3772 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3773 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3774 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3775 (Qgnutls_bootprop_callbacks_verify): Make static.
3777 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3779 * callproc.c: Indentation fixup.
3781 * sysdep.c (wait_for_termination_1): Make static.
3782 (wait_for_termination, interruptible_wait_for_termination):
3783 Move after wait_for_termination_1.
3785 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3787 * sysdep.c (interruptible_wait_for_termination): New function
3788 which is like wait_for_termination, but allows keyboard
3791 * callproc.c (Fcall_process): Add (:file "file") as an option for
3793 (Fcall_process_region): Ditto.
3795 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3797 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3798 rather than `XVECTOR (FOO)->size'.
3800 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3801 inttypes.h, as a gnulib replacement is used if it not available in
3804 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3806 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3807 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3808 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3810 * coding.c (coding_alloc_by_realloc): Error out if destination
3811 will grow beyond MOST_POSITIVE_FIXNUM.
3812 (decode_coding_emacs_mule): Abort if there isn't enough place in
3813 charbuf for the composition carryover bytes. Reserve an extra
3814 space for up to 2 characters produced in a loop.
3815 (decode_coding_iso_2022): Abort if there isn't enough place in
3816 charbuf for the composition carryover bytes.
3818 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3820 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3821 aborting when %lld or %lll format is passed.
3822 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3823 %llo or %llx format is passed. (Bug#8545)
3825 * window.c (window_scroll_line_based): Use a marker instead of
3826 simple variables to record original value of point. (Bug#7952)
3828 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3829 produced by %s or %c overflows available buffer space. (Bug#8545)
3831 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3833 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3834 (SIZE_MAX): Move defn after all includes, as they might #define it.
3836 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3838 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3840 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3842 * keyboard.c (Qdelayed_warnings_hook): Define.
3843 (command_loop_1): Run `delayed-warnings-hook'
3844 if Vdelayed_warnings_list is non-nil.
3845 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3846 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3848 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3850 * doprnt.c (doprnt): Don't return value smaller than the buffer
3851 size if the message was truncated. (Bug#8545).
3853 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3855 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3856 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3858 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3860 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3862 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3864 * makefile.w32-in: Update dependencies.
3866 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3868 Improve `doprnt' and its usage. (Bug#8545)
3869 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3870 `format_end'. Remove support for %l as a conversion specifier.
3871 Don't use xrealloc. Improve diagnostics when the %l size modifier
3872 is used. Update the commentary.
3874 * eval.c (verror): Simplify calculation of size_t.
3876 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3879 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3881 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3884 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3886 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3887 This makes this file independent of the recent pseudovector change.
3889 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3891 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3893 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3894 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3895 Remove unused local.
3896 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3898 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3899 GCC 4.6.0 optimizes based on type-based alias analysis.
3900 For example, if b is of type struct buffer * and v of type struct
3901 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3902 != &v->size, and therefore "v->size = 1; b->size = 2; return
3903 v->size;" must therefore return 1. This assumption is incorrect
3904 for Emacs, since it type-puns struct Lisp_Vector * with many other
3905 types. To fix this problem, this patch adds a new type struct
3906 vectorlike_header that documents the constraints on layout of vectors
3907 and pseudovectors, and helps optimizing compilers not get fooled
3908 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3909 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3910 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3912 (XSETPVECTYPE): Rewrite in terms of new macro.
3913 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3914 This is a bit clearer, and further avoids the possibility of
3915 undesirable aliasing.
3916 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3917 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3918 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3919 since Lisp_Subr is a special case (no "next" field).
3920 (ASIZE): Now uses header.size rather than size.
3921 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3922 to avoid the hassle of writing XVECTOR (foo)->header.size.
3923 (struct vectorlike_header): New type.
3924 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3925 object, to help avoid aliasing.
3926 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3927 (SUBRP): Likewise, since Lisp_Subr is a special case.
3928 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3929 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3930 (struct Lisp_Hash_Table): Combine first two members into a single
3931 struct vectorlike_header member. All uses of "size" and "next" members
3932 changed to be "header.size" and "header.next".
3933 * buffer.h (struct buffer): Likewise.
3934 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3935 * frame.h (struct frame): Likewise.
3936 * process.h (struct Lisp_Process): Likewise.
3937 * termhooks.h (struct terminal): Likewise.
3938 * window.c (struct save_window_data, struct saved_window): Likewise.
3939 * window.h (struct window): Likewise.
3940 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3941 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3942 * buffer.c (init_buffer_once): Likewise.
3943 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3945 * process.c (Fformat_network_address): Use local var for size,
3948 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3950 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3951 * data.c (atof): Remove decl; no longer used or needed.
3952 (digit_to_number): Move to lread.c.
3953 (Fstring_to_number): Use new string_to_number function, to be
3954 consistent with how the Lisp reader treats infinities and NaNs.
3955 Do not assume that floating-point numbers represent EMACS_INT
3956 without losing information; this is not true on most 64-bit hosts.
3957 Avoid double-rounding errors, by insisting on integers when
3958 parsing non-base-10 numbers, as the documentation specifies.
3959 * lisp.h (string_to_number): New decl, replacing ...
3960 (isfloat_string): Remove.
3961 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3962 (read1): Do not accept +. and -. as integers; this
3963 appears to have been a coding error. Similarly, do not accept
3964 strings like +-1e0 as floating point numbers. Do not report
3965 overflow for integer overflows unless the base is not 10 which
3966 means we have no simple and reliable way to continue.
3967 Break out the floating-point parsing into a new
3968 function string_to_number, so that Fstring_to_number parses
3969 floating point numbers consistently with the Lisp reader.
3970 (digit_to_number): Move here from data.c. Make it static inline.
3971 (E_CHAR, EXP_INT): Remove, replacing with ...
3972 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3973 (string_to_number): New function, replacing isfloat_string.
3974 This function checks for valid syntax and produces the resulting
3975 Lisp float number too. Rework it so that string-to-number
3976 no longer mishandles examples like "1.0e+". Use strtoumax,
3977 so that overflow for non-base-10 numbers is reported only when
3978 there's no portable and simple way to convert to floating point.
3980 * textprop.c (set_text_properties_1): Rewrite for clarity,
3981 and to avoid GCC warning about integer overflow.
3983 * intervals.h (struct interval): Use EMACS_INT for members
3984 where EMACS_UINT might cause problems. See
3985 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3986 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3987 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3989 (offset_intervals): Tell GCC not to worry about length overflow
3990 when negating a negative length.
3992 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3993 (overrun_check_free): Likewise.
3995 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3996 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3999 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4000 (gnutls_make_error): Rename local to avoid shadowing.
4001 (gnutls_emacs_global_deinit): ifdef out; not used.
4002 (Fgnutls_boot): Use const for pointer to readonly storage.
4003 Comment out unused local. Fix pointer signedness problems.
4005 * lread.c (openp): Don't stuff size_t into an 'int'.
4006 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4007 about possible signed overflow.
4009 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4010 (GDK_KEY_g): Don't define if already defined.
4011 (xg_prepare_tooltip): Avoid pointer signedness problem.
4012 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4014 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4015 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4017 * xfns.c (Fx_window_property): Simplify a bit,
4018 to make a bit faster and to avoid GCC 4.6.0 warning.
4019 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4021 * fns.c (internal_equal): Don't assume size_t fits in int.
4023 * alloc.c (compact_small_strings): Tighten assertion a little.
4025 Replace pEd with more-general pI, and fix some printf arg casts.
4026 * lisp.h (pI): New macro, generalizing old pEd macro to other
4027 conversion specifiers. For example, use "...%"pI"d..." rather
4028 than "...%"pEd"...".
4029 (pEd): Remove. All uses replaced with similar uses of pI.
4030 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4031 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4032 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4033 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4034 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4035 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4036 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4038 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4039 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4040 * print.c (safe_debug_print, print_object): Likewise.
4041 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4043 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4044 avoiding the 0 flag, which is not portable.
4045 * process.c (Fmake_network_process): Use pI to avoid cast.
4046 * region-cache.c (pp_cache): Likewise.
4047 * xdisp.c (decode_mode_spec): Likewise.
4048 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4049 behavior on 64-bit hosts with printf arg.
4050 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4051 (x_stop_queuing_selection_requests): Likewise.
4052 (x_get_window_property): Don't truncate byte count to an 'int'
4055 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4056 here, since it parses constructs like leading '-' and spaces,
4057 which are not wanted; and it overflows with large numbers.
4058 Instead, simply match F[0-9]+, which is what is wanted anyway.
4060 * alloc.c: Remove unportable assumptions about struct layout.
4061 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4062 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4063 (allocate_vectorlike, make_pure_vector): Use the new macros,
4064 plus offsetof, to remove unportable assumptions about struct layout.
4065 These assumptions hold on all porting targets that I know of, but
4066 they are not guaranteed, they're easy to remove, and removing them
4067 makes further changes easier.
4069 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4070 This doesn't fix a bug but makes the code clearer.
4071 (string_overrun_cookie): Now const. Use initializers that
4072 don't formally overflow signed char, to avoid warnings.
4073 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4074 can cause Emacs to crash when string overrun checking is enabled.
4075 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4076 multiple of sizeof (EMACS_INT); it need not be, if
4077 alignof(EMACS_INT) < sizeof (EMACS_INT).
4078 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4080 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4082 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4084 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4086 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4087 supposed to be handshaking. (Bug#8556)
4088 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4090 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4092 * lisp.h (Qdebug): List symbol.
4093 * eval.c (Qdebug): Restore global linkage.
4094 * keyboard.c (debug-on-event): New variable.
4095 (handle_user_signal): Break into debugger when debug-on-event
4096 matches the current signal symbol.
4098 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4100 * alloc.c (check_sblock, check_string_bytes)
4101 (check_string_free_list): Convert to standard C.
4103 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4105 * w32.c (emacs_gnutls_push): Fix typo.
4107 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4109 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4110 "cast to pointer from integer of different size".
4112 Improve doprnt and its use in verror. (Bug#8545)
4113 * doprnt.c (doprnt): Document the set of format control sequences
4114 supported by the function. Use SAFE_ALLOCA instead of always
4117 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4118 is one byte too soon. Don't use xrealloc; instead xfree and
4121 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4123 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4126 * gnutls.c: Renamed global_initialized to
4127 gnutls_global_initialized. Added internals for the
4128 :verify-hostname-error, :verify-error, and :verify-flags
4129 parameters of `gnutls-boot' and documented those parameters in the
4130 docstring. Start callback support.
4131 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4132 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4133 on error. Return error code.
4134 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4135 (emacs_gnutls_read): Likewise.
4136 (Fgnutls_boot): Return handshake error code.
4137 (emacs_gnutls_handle_error): New function.
4138 (wsaerror_to_errno): Likewise.
4140 * w32.h (emacs_gnutls_pull): Add prototype.
4141 (emacs_gnutls_push): Likewise.
4143 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4144 (emacs_gnutls_push): Likewise.
4146 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4148 * process.c (wait_reading_process_output): Check if GnuTLS
4149 buffered some data internally if no FDs are set for TLS
4152 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4153 (LIBS): Link to USER_LIBS.
4154 ($(BLD)/gnutls.$(0)): New target.
4156 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4158 * xdisp.c (handle_single_display_spec): Rename the
4159 display_replaced_before_p argument into display_replaced_p, to
4160 make it consistent with the commentary. Fix typos in the
4163 * textprop.c (syms_of_textprop): Remove dead code.
4164 (copy_text_properties): Delete obsolete commentary about an
4165 interface that was deleted long ago. Fix typos in the description
4168 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4169 to changes in oldXMenu/XMenu.h from 2011-04-16.
4170 <menu_help_message, prev_menu_help_message>: Constify.
4171 (IT_menu_make_room): menu->help_text is now `const char **';
4174 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4175 to changes in oldXMenu/XMenu.h from 2011-04-16.
4176 (struct XMenu): Declare `help_text' `const char **'.
4178 * xfaces.c <Qunspecified>: Make extern again.
4180 * syntax.c: Include sys/types.h before including regex.h, as
4183 * doc.c (get_doc_string): Improve the format passed to `error'.
4185 * doprnt.c (doprnt): Improve commentary.
4187 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4189 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4192 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4193 changes in globals.h immediately force recompilation.
4194 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4195 $(CURDIR)/s/ms-w32.h.
4196 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4198 * character.c (Fchar_direction): Function deleted.
4199 (syms_of_character): Don't defsubr it.
4200 <char-direction-table>: Deleted.
4202 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4204 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4205 * doprnt.c: Include limits.h.
4206 (SIZE_MAX): New macro.
4207 (doprnt): Return a size_t value. 2nd arg is now size_t.
4208 Many local variables are now size_t instead of int or unsigned.
4209 Improve overflow protection. Support `l' modifier for integer
4210 conversions. Support %l conversion. Don't assume an EMACS_INT
4211 argument for integer conversions and for %c.
4213 * lisp.h (doprnt): Restore prototype.
4215 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4218 * Makefile.in (base_obj): Add back doprnt.o.
4220 * deps.mk (doprnt.o): Add back prerequisites.
4221 (callint.o): Depend on character.h.
4223 * eval.c (internal_lisp_condition_case): Include the handler
4224 representation in the error message.
4225 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4226 when breaking from the loop.
4228 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4230 * callint.c (Fcall_interactively): When displaying error message
4231 about invalid control letter, pass the character's codepoint, not
4232 a pointer to its multibyte form. Improve display of the character
4233 in octal and display also its hex code.
4235 * character.c (char_string): Use %x to display the (unsigned)
4236 codepoint of an invalid character, to avoid displaying a bogus
4239 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4240 `error', not SYMBOL_NAME itself.
4242 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4243 character arguments to `error'.
4245 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4246 to `error' in error message about FINAL_CHAR argument. Make sure
4247 FINAL_CHAR is a character, and use %c when it is passed as
4248 argument to `error'.
4250 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4252 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4254 * w32.c: Include <time.h>.
4255 (sys_localtime): New function.
4257 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4259 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4261 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4263 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4265 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4268 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4270 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4271 gl_state.e_property when gl_state.object is Qt.
4273 * insdel.c (make_gap_larger): Remove limitation of buffer size
4276 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4278 * xdisp.c (lookup_glyphless_char_display)
4279 (produce_glyphless_glyph): Handle cons cell entry in
4280 glyphless-char-display.
4281 (Vglyphless_char_display): Document it.
4283 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4284 glyphless-char-display.
4286 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4288 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4290 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4292 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4293 definition for no-X builds.
4295 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4297 Static checks with GCC 4.6.0 and non-default toolkits.
4299 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4301 * process.c (keyboard_bit_set): Define only if SIGIO.
4302 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4303 (send_process): Repair possible setjmp clobbering.
4305 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4307 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4309 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4311 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4312 Define only if needed.
4314 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4315 by pacifying GCC about it. Maybe it's time to retire it?
4316 * xfaces.c (USG, __TIMEVAL__): Likewise.
4318 * dispextern.h (struct redisplay_interface): Rename param
4320 * termhooks.h (struct terminal): Likewise.
4321 * xterm.c (xembed_send_message): Likewise.
4323 * insdel.c (make_gap_smaller): Define only if
4324 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4326 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4329 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4330 so that we aren't warned about unused symbols.
4332 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4334 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4336 * xfns.c (x_real_positions): Mark locals as initialized.
4338 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4340 * xterm.c: Fix problems found by static analysis with other toolkits.
4341 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4342 (x_dispatch_event): Declare static if USE_GTK, and
4343 define if USE_GTK || USE_X_TOOLKIT.
4344 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4345 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4346 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4347 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4349 * xmenu.c (menu_help_callback): Pointer type fixes.
4350 Use const pointers when pointing at readonly data. Avoid pointer
4352 (FALSE): Remove unused macro.
4353 (update_frame_menubar): Remove unused decl.
4355 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4357 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4358 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4359 (single_menu_item): Rename local to avoid shadowing.
4361 * keyboard.c (make_lispy_event): Remove unused local var.
4363 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4364 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4366 * bitmaps: Change bitmaps from unsigned char back to the X11
4367 compatible char. Avoid the old compiler warnings about
4368 out-of-range initializers by using, for example, '\xab' rather
4371 * xgselect.c (xgselect_initialize): Check vs interface
4372 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4374 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4376 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4377 to read-only memory.
4379 * fns.c (vector): Remove; this old hack is no longer needed.
4381 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4383 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4385 * xrdb.c (x_load_resources): Omit unused local.
4387 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4388 (x_window): Rename locals to avoid shadowing.
4389 (USG): Use the kludged USG macro, to pacify gcc.
4391 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4392 (x_term_init): Remove local to avoid shadowing.
4394 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4396 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4397 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4399 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4401 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4403 Fix regex.c, syntax.c and friends for buffers > 2GB.
4404 * syntax.h (struct gl_state_s): Declare character position members
4407 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4409 * textprop.c (verify_interval_modification, interval_of):
4410 Declare arguments EMACS_INT.
4412 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4415 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4417 * indent.c (Fvertical_motion): Local variable it_start is now
4420 * regex.c (re_match, re_match_2, re_match_2_internal)
4421 (bcmp_translate, regcomp, regexec, print_double_string)
4422 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4423 (re_compile_pattern, re_exec): Declare arguments and local
4424 variables `size_t' and `ssize_t' and return values `regoff_t', as
4426 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4427 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4428 <compile_stack_type>: `size' and `avail' are now `size_t'.
4430 * regex.h <regoff_t>: Use ssize_t, not int.
4431 (re_search, re_search_2, re_match, re_match_2): Arguments that
4432 specify buffer/string position and length are now ssize_t and
4433 size_t. Return type is regoff_t.
4435 2011-04-16 Ben Key <bkey76@gmail.com>
4437 * nsfont.m: Fixed bugs in ns_get_family and
4438 ns_descriptor_to_entity that were caused by using free to
4439 deallocate memory blocks that were allocated by xmalloc (via
4440 xstrdup). This caused Emacs to crash when compiled with
4441 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4442 --enable-checking=xmallocoverrun). xfree is now used to
4443 deallocate these memory blocks.
4445 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4447 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4449 emacs_write: Accept and return EMACS_INT for sizes.
4450 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4452 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4453 Accept and return EMACS_INT.
4454 (emacs_gnutls_write): Return the number of bytes written on
4456 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4457 (emacs_read, emacs_write): Remove check for negative size, as the
4458 Emacs source code has been audited now.
4459 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4460 (emacs_read, emacs_write): Use it.
4461 * process.c (send_process): Adjust to the new signatures of
4462 emacs_write and emacs_gnutls_write. Do not attempt to store
4463 a byte offset into an 'int'; it might overflow.
4464 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4466 * sound.c: Don't assume sizes fit in 'int'.
4467 (struct sound_device.period_size, alsa_period_size):
4468 Return EMACS_INT, not int.
4469 (struct sound_device.write, vox_write, alsa_write):
4470 Accept EMACS_INT, not int.
4471 (wav_play, au_play): Use EMACS_INT to store sizes and to
4472 record read return values.
4474 2011-04-15 Ben Key <bkey76@gmail.com>
4476 * keyboard.c (Qundefined): Don't declare static since it is used
4478 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4479 static since they are used in nsfont.m.
4481 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4483 * process.c (Qprocessp): Don't declare static.
4484 * lisp.h (Qprocessp): Declare again.
4486 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4488 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4490 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4492 Improve C-level modularity by making more things 'static'.
4494 Don't publish debugger-only interfaces to other modules.
4495 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4496 (verify_bytepos, count_markers): Move decls to the only modules
4498 * region-cache.h (pp_cache): Likewise.
4499 * window.h (check_all_windows): Likewise.
4500 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4502 * sysdep.c (croak): Now static, if
4503 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4504 * syssignal.h (croak): Declare only if not static.
4506 * alloc.c (refill_memory_reserve): Now static if
4507 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4508 * lisp.h (refill_memory_reserve): Declare only if not static.
4510 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4511 Define only if USE_LUCID.
4513 * xrdb.c (x_customization_string, x_rm_string): Now static.
4515 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4516 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4518 * xdisp.c (draw_row_with_mouse_face): Now static.
4519 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4521 * window.h (check_all_windows): Mark externally visible.
4523 * window.c (window_deletion_count): Now static.
4525 * undo.c: Make symbols static if they're not exported.
4526 (last_undo_buffer, last_boundary_position, pending_boundary):
4529 * textprop.c (interval_insert_behind_hooks): Now static.
4530 (interval_insert_in_front_hooks): Likewise.
4532 * term.c: Make symbols static if they're not exported.
4533 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4534 (max_frame_lines, tty_set_terminal_modes):
4535 (tty_reset_terminal_modes, tty_turn_off_highlight):
4536 (get_tty_terminal): Now static.
4537 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4538 * termhooks.h (term_mouse_moveto): Do not declare if
4540 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4541 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4543 * sysdep.c: Make symbols static if they're not exported.
4544 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4546 (sigprocmask_set, full_mask): Remove; unused.
4547 (wait_debugging): Mark as visible.
4548 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4549 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4551 * syntax.c (syntax_temp): Define only if !__GNUC__.
4553 * sound.c (current_sound_device, current_sound): Now static.
4555 * search.c (searchbufs, searchbuf_head): Now static.
4557 * scroll.c (scroll_cost): Remove; unused.
4558 * dispextern.h (scroll_cost): Remove decl.
4560 * region-cache.h (pp_cache): Mark as externally visible.
4562 * process.c: Make symbols static if they're not exported.
4563 (process_tick, update_tick, create_process, chan_process):
4564 (Vprocess_alist, proc_buffered_char, datagram_access):
4565 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4566 (deactivate_process): Mark defn as static, as well as decl.
4567 * lisp.h (create_process): Remove decl.
4568 * process.h (chan_process, Vprocess_alist): Remove decls.
4570 * print.c: Make symbols static if they're not exported.
4571 (print_depth, new_backquote_output, being_printed, print_buffer):
4572 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4573 (print_interval, print_number_index, initial_stderr_stream):
4575 * lisp.h (Fprinc): Remove decl.
4576 (debug_output_compilation_hack): Mark as externally visible.
4578 * sysdep.c (croak): Move decl from here to syssignal.h.
4579 * syssignal.h (croak): Put it here, so the API can be checked when
4580 'croak' is called from dissociate_if_controlling_tty.
4582 * minibuf.c: Make symbols static if they're not exported.
4583 (minibuf_save_list, choose_minibuf_frame): Now static.
4584 * lisp.h (choose_minibuf_frame): Remove decl.
4586 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4588 * lread.c: Make symbols static if they're not exported.
4589 (read_objects, initial_obarray, oblookup_last_bucket_number):
4591 (make_symbol): Remove; unused.
4592 * lisp.h (initial_obarray, make_symbol): Remove decls.
4594 * keyboard.c: Make symbols static if they're not exported.
4595 (single_kboard, recent_keys_index, total_keys, recent_keys):
4596 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4597 (this_single_command_key_start, echoing, last_auto_save):
4598 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4599 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4600 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4601 (Vlispy_mouse_stem, double_click_count):
4603 (force_auto_save_soon): Define only if SIGDANGER.
4604 (ignore_mouse_drag_p): Now static if
4605 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4606 (print_help): Remove; unused.
4607 (stop_character, last_timer_event): Mark as externally visible.
4608 * keyboard.h (ignore_mouse_drag_p): Declare only if
4609 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4610 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4611 * lisp.h (echoing): Remove decl.
4612 (force_auto_save_soon): Declare only if SIGDANGER.
4613 * xdisp.c (redisplay_window): Simplify code, to make it more
4614 obvious that ignore_mouse_drag_p is not accessed if !defined
4615 USE_GTK && !defined HAVE_NS.
4617 * intervals.c: Make symbols static if they're not exported.
4618 (merge_properties_sticky, merge_interval_right, delete_interval):
4620 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4622 * insdel.c: Make symbols static if they're not exported.
4623 However, leave prepare_to_modify_buffer alone. It's never
4624 called from outside this function, but that appears to be a bug.
4625 (combine_after_change_list, combine_after_change_buffer):
4626 (adjust_after_replace, signal_before_change): Now static.
4627 (adjust_after_replace_noundo): Remove; unused.
4628 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4629 (signal_before_change): Remove decls.
4631 * indent.c (val_compute_motion, val_vmotion): Now static.
4633 * image.c: Make symbols static if they're not exported.
4634 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4636 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4637 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4639 * fringe.c (standard_bitmaps): Now static.
4640 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4642 * frame.c: Make symbols static if they're not exported.
4643 (x_report_frame_params, make_terminal_frame): Now static.
4644 (get_frame_param): Now static, unless HAVE_NS.
4645 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4646 (x_get_resource_string): Remove; not used.
4647 * frame.h (make_terminal_frame, x_report_frame_params):
4648 (x_get_resource_string); Remove decls.
4649 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4650 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4652 * font.c, fontset.c: Make symbols static if they're not exported.
4653 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4654 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4655 * font.c (font_close_object): Now static.
4656 * font.h (font_close_object): Remove.
4657 * fontset.c (FONTSET_OBJLIST): Remove.
4658 (free_realized_fontset) #if-0 the body, which does nothing.
4659 (face_suitable_for_char_p): #if-0, as it's never called.
4660 * fontset.h (face_suitable_for_char_p): Remove decl.
4661 * xfaces.c (face_at_string_position):
4662 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4663 since 0 is always ASCII.
4665 * fns.c (weak_hash_tables): Now static.
4667 * fileio.c: Make symbols static if they're not exported.
4668 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4669 (Vwrite_region_annotation_buffers): Now static.
4671 * eval.c: Make symbols static if they're not exported.
4672 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4673 * lisp.h (backtrace_list): Remove decl.
4675 * emacs.c: Make symbols static if they're not exported.
4676 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4677 (fatal_error_code, fatal_error_signal_hook, standard_args):
4679 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4680 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4681 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4682 * lisp.h (fatal_error_signal_hook): Remove decl.
4683 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4685 * editfns.c: Move a (normally-unused) function to its only use.
4686 * editfns.c, lisp.h (get_operating_system_release): Remove.
4687 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4688 worth the hassle of breaking this out.
4690 * xterm.c: Make symbols static if they're not exported.
4691 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4692 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4693 (x_destroy_window, x_delete_display):
4695 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4696 (x_mouse_leave): Remove; unused.
4697 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4698 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4699 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4701 (x_mouse_leave): Declare only if WINDOWSNT.
4702 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4703 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4706 * ftxfont.c: Make symbols static if they're not exported.
4707 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4709 * font.h (ftxfont_driver): Likewise.
4711 * xfns.c: Make symbols static if they're not exported.
4712 (x_last_font_name, x_display_info_for_name):
4713 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4714 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4715 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4716 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4717 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4718 (last_show_tip_args): Now static.
4719 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4720 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4721 (x_screen_planes): Remove; unused.
4722 * dispextern.h (x_screen_planes): Remove decl.
4724 * dispnew.c: Make symbols static if they're not exported.
4725 * dispextern.h (redraw_garbaged_frames, scrolling):
4726 (increment_row_positions): Remove.
4727 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4728 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4730 (redraw_garbaged_frames): Remove; unused.
4732 * xfaces.c: Make symbols static if they're not exported.
4733 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4735 * xterm.h (defined_color): Remove decls.
4736 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4737 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4738 (menu_face_changed_default, defined_color, free_realized_face):
4739 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4740 (ascii_face_of_lisp_face): Remove; unused.
4742 * xdisp.c: Make symbols static if they're not exported.
4743 * dispextern.h (scratch_glyph_row, window_box_edges):
4744 (glyph_to_pixel_coords, set_cursor_from_row):
4745 (get_next_display_element, set_iterator_to_next):
4746 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4747 (show_mouse_face): Remove decls
4748 * frame.h (message_buf_print): Likewise.
4749 * lisp.h (pop_message, set_message, check_point_in_composition):
4751 * xterm.h (set_vertical_scroll_bar): Likewise.
4752 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4753 (message_buf_print, scratch_glyph_row, displayed_buffer):
4754 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4755 (get_next_display_element, show_mouse_face, window_box_edges):
4756 (frame_to_window_pixel_xy, check_point_in_composition):
4757 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4758 (glyph_to_pixel_coords): Remove; unused.
4760 * dired.c (file_name_completion): Now static.
4762 * dbusbind.c (xd_in_read_queued_messages): Now static.
4764 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4765 * data.c (circular_list_error): Remove.
4767 * commands.h (last_point_position, last_point_position_buffer):
4768 (last_point_position_window): Remove decls.
4769 * keyboard.c: Make these variables static.
4771 * coding.h (coding, code_convert_region, encode_coding_gap):
4773 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4774 (iso_code_class, detect_coding, code_convert_region): Now static.
4775 (encode_coding_gap): Remove; unused.
4777 * chartab.c (chartab_chars, chartab_bits): Now static.
4779 * charset.h (charset_iso_8859_1): Remove decl.
4780 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4783 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4784 * ccl.c (Vccl_program_table): Now static.
4785 (check_ccl_update): Remove; unused.
4787 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4788 * category.h: ... from here.
4789 * category.c (check_category_table, set_category_set): Now static.
4791 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4792 * lisp.h: Remove these decls.
4794 * buffer.c (buffer_count): Remove unused var.
4796 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4797 so that it's not optimized away.
4798 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4799 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4800 exported only to the debugger.
4802 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4803 * atimer.h (run_all_atimers): Remove; not exported.
4805 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4806 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4807 was inaccessible from Lisp.
4808 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4809 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4811 alloc.c: Import and export fewer symbols, and remove unused items.
4812 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4814 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4815 it's not optimized away by whole-program optimization.
4816 (message_enable_multibyte, free_misc): Remove.
4817 (catchlist, handlerlist, mark_backtrace):
4818 Declare only if BYTE_MARK_STACK.
4819 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4820 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4821 (message_enable_multibyte): Remove decl.
4822 (free_misc, interval_free_list, float_block, float_block_index):
4823 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4824 (cons_free_list, last_marked_index):
4826 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4827 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4828 (mark_backtrace): Define only if BYTE_MARK_STACK.
4829 * xdisp.c (message_enable_multibyte): Now static.
4831 Declare Lisp_Object Q* variables to be 'static' if not exported.
4832 This makes it easier for human readers (and static analyzers)
4833 to see whether these variables are used from other modules.
4834 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4835 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4836 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4837 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4838 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4839 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4840 * xmenu.c, xselect.c:
4841 Declare Q* vars static if they are not used in other modules.
4842 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4843 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4844 Remove decls of unexported vars.
4845 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4847 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4849 Make Emacs functions such as Fatom 'static' by default.
4850 This makes it easier for human readers (and static analyzers)
4851 to see whether these functions can be called from other modules.
4852 DEFUN now defines a static function. To make the function external
4853 so that it can be used in other C modules, use the new macro DEFUE.
4854 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4855 (Finit_image_library):
4856 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4857 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4858 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4859 Remove decls, since these functions are now static.
4860 (Funintern, Fget_internal_run_time): New decls, since these functions
4861 were already external.
4863 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4864 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4865 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4866 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4867 * keyboard.c, keymap.c, lread.c:
4868 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4869 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4870 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4871 Mark functions with DEFUE instead of DEFUN,
4872 if they are used in other modules.
4873 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4874 decls for now-static functions.
4875 * buffer.h (Fdelete_overlay): Remove decl.
4876 * callproc.c (Fgetenv_internal): Mark as internal.
4877 * composite.c (Fremove_list_of_text_properties): Remove decl.
4878 (Fcomposition_get_gstring): New forward static decl.
4879 * composite.h (Fcomposite_get_gstring): Remove decl.
4880 * dired.c (Ffile_attributes): New forward static decl.
4881 * doc.c (Fdocumntation_property): New forward static decl.
4882 * eval.c (Ffetch_bytecode): New forward static decl.
4883 (Funintern): Remove extern decl; now in .h file where it belongs.
4884 * fileio.c (Fmake_symbolic_link): New forward static decl.
4885 * image.c (Finit_image_library): New forward static decl.
4886 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4887 * intervals.h (Fprevious_property_change):
4888 (Fremove_list_of_text_properties): Remove decls.
4889 * keyboard.c (Fthis_command_keys): Remove decl.
4890 (Fcommand_execute): New forward static decl.
4891 * keymap.c (Flookup_key): New forward static decl.
4892 (Fcopy_keymap): Now static.
4893 * keymap.h (Flookup_key): Remove decl.
4894 * process.c (Fget_process): New forward static decl.
4895 (Fprocess_datagram_address): Mark as internal.
4896 * syntax.c (Fsyntax_table_p): New forward static decl.
4897 (skip_chars): Remove duplicate decl.
4898 * textprop.c (Fprevious_property_change): New forward static decl.
4899 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4901 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4902 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4904 * editfns.c (Fformat): Remove unreachable code.
4906 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4908 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4911 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4913 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4914 when at ZV. (Bug#8487)
4916 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4918 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4920 * keyboard.c (parse_tool_bar_item): Likewise.
4921 * sound.c (sound_cleanup, alsa_close): Likewise.
4922 * termcap.c (tgetent): Likewise.
4923 * xfns.c (x_default_font_parameter): Likewise.
4924 * xsettings.c (read_and_apply_settings): Likewise.
4926 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4927 (overrun_check_free): Protoize.
4929 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4931 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4932 since callers should never pass a negative size.
4933 Change the signature to match that of plain 'read' and 'write'; see
4934 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4935 * lisp.h: Update prototypes of emacs_write and emacs_read.
4937 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4939 * xdisp.c (redisplay_window): Don't try to determine the character
4940 position of the scroll margin if the window start point w->startp
4941 is outside the buffer's accessible region. (Bug#8468)
4943 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4945 Fix write-region and its subroutines for buffers > 2GB.
4946 * fileio.c (a_write, e_write): Modify declaration of arguments and
4947 local variables to support buffers larger than 2GB.
4948 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4950 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4951 argument, local variables, and return value.
4953 * lisp.h: Update prototypes of emacs_write and emacs_read.
4955 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4957 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4959 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4961 Fix more problems found by GCC 4.6.0's static checks.
4963 * xdisp.c (vmessage): Use a better test for character truncation.
4965 * charset.c (load_charset_map): <, not <=, for optimization,
4966 and to avoid potential problems with integer overflow.
4967 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4968 * casetab.c (set_identity, shuffle): Likewise.
4969 * editfns.c (Fformat): Likewise.
4970 * syntax.c (skip_chars): Likewise.
4972 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4973 This also lets GCC 4.6.0 generate slightly better loop code.
4975 * callint.c (Fcall_interactively): <, not <=, for optimization.
4976 (Fcall_interactively): Count the number of arguments produced,
4977 not the number of arguments given. This is simpler and lets GCC
4978 4.6.0 generate slightly better code.
4980 * ftfont.c: Distingish more carefully between FcChar8 and char.
4981 The previous code passed unsigned char * to a functions like
4982 strlen and xstrcasecmp that expect char *, which does not
4983 conform to the C standard.
4984 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4985 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4986 char * when the C standard requires it.
4988 * keyboard.c (read_char): Remove unused var.
4990 * eval.c: Port to Windows vsnprintf (Bug#8435).
4992 (SIZE_MAX): Define if the headers do not.
4993 (verror): Do not give up if vsnprintf returns a negative count.
4994 Instead, grow the buffer. This ports to Windows vsnprintf, which
4995 does not conform to C99. Problem reported by Eli Zaretskii.
4996 Also, simplify the allocation scheme, by avoiding the need for
4997 calling realloc, and removing the ALLOCATED variable.
4999 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5001 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5002 But keep the doprint source code for now, as we might revamp it
5003 and use it again (Bug#8435).
5004 * lisp.h (doprnt): Remove.
5005 * Makefile.in (base_obj): Remove doprnt.o.
5006 * deps.mk (doprnt.o): Remove.
5008 error: Print 32- and 64-bit integers portably (Bug#8435).
5009 Without this change, on typical 64-bit hosts error ("...%d...", N)
5010 was used to print both 32- and 64-bit integers N, which relied on
5012 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5014 * lisp.h (error, verror): Mark as printf-like functions.
5015 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5016 Report overflow in size calculations when allocating printf buffer.
5017 Do not truncate output string at its first null byte.
5018 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5019 Truncate the output at a character boundary, since vsnprintf does not
5021 * charset.c (check_iso_charset_parameter): Convert internal
5022 character to string before calling 'error', since %c now has the
5024 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5025 overflow when computing char to be passed to 'error'. Do not
5026 pass Lisp_Object to 'error'; pass the integer instead.
5027 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5028 formatted with plain %d.
5030 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5032 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5034 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5036 * xterm.c (x_catch_errors): Remove duplicate declaration.
5038 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5040 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5042 2011-04-10 Jim Meyering <meyering@redhat.com>
5044 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5045 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5046 return ssize_t not "int", and use size_t as the buffer length.
5047 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5048 * gnutls.h: Update declarations.
5049 * process.c (read_process_output): Use ssize_t, to match.
5050 (send_process): Likewise.
5052 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5054 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5056 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5058 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5059 Use unsigned char, to match FcChar8 type definition.
5061 * xterm.c (handle_one_xevent):
5062 * xmenu.c (create_and_show_popup_menu):
5063 * xselect.c (x_decline_selection_request)
5064 (x_reply_selection_request): Avoid type-punned deref of X events.
5066 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5068 Fix some uses of `int' instead of EMACS_INT.
5069 * search.c (string_match_1, fast_string_match)
5070 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5071 (scan_buffer, find_next_newline_no_quit)
5072 (find_before_next_newline, search_command, Freplace_match)
5073 (Fmatch_data): Make some `int' variables be EMACS_INT.
5075 * xdisp.c (display_count_lines): 3rd argument and return value now
5076 EMACS_INT. All callers changed.
5077 (pint2hrstr): Last argument is now EMACS_INT.
5079 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5080 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5081 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5082 (decode_coding_utf_16, decode_coding_emacs_mule)
5083 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5084 (decode_coding_ccl, decode_coding_charset)
5085 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5086 (decode_coding_iso_2022, decode_coding_emacs_mule)
5087 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5088 <char_offset, last_offset>: Declare EMACS_INT.
5089 (encode_coding_utf_8, encode_coding_utf_16)
5090 (encode_coding_emacs_mule, encode_invocation_designation)
5091 (encode_designation_at_bol, encode_coding_iso_2022)
5092 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5093 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5095 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5096 (encode_invocation_designation): Last argument P_NCHARS is now
5098 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5099 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5101 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5104 * ccl.c (Fccl_execute_on_string): Declare some variables
5107 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5109 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5111 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5113 * process.c (Fformat_network_address): Doc fix.
5115 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5117 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5119 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5121 * keyboard.c (read_char): Call Lisp function help-form-show,
5122 instead of using internal_with_output_to_temp_buffer.
5123 (Qhelp_form_show): New var.
5124 (syms_of_keyboard): Use DEFSYM macro.
5126 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5128 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5130 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5132 * process.c (Flist_processes): Remove to Lisp.
5133 (list_processes_1): Delete.
5135 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5137 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5139 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5141 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5143 Fix more problems found by GCC 4.6.0's static checks.
5145 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5147 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5149 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5151 * xdisp.c (vmessage): Mark as a printf-like function.
5153 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5155 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5157 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5158 printf-like functions.
5159 (tiff_load): Add casts to remove these marks before passing them
5160 to system-supplied API.
5162 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5164 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5165 This avoids several warnings with gcc -Wstrict-overflow.
5166 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5167 directly, rather than having caller test rule sign. This avoids
5168 some unnecessary tests.
5169 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5170 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5171 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5173 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5174 (xfont_open): Avoid unnecessary tests.
5176 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5178 * composite.h, composite.c (composition_gstring_put_cache):
5179 Use EMACS_INT, not int, for length.
5181 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5182 breaking out part of COMPOSITION_DECODE_RULE.
5183 (COMPOSITION_DECODE_RULE): Use it.
5184 * composite.c (get_composition_id): Remove unused local vars,
5185 by using the new macro.
5187 * textprop.c (set_text_properties_1): Change while to do-while,
5188 since the condition is always true at first.
5190 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5191 (interval_deletion_adjustment): Return unsigned value.
5194 * process.c (list_processes_1, create_pty, read_process_output):
5195 (exec_sentinel): Remove vars that were set but not used.
5196 (create_pty): Remove unnecessary "volatile"s.
5197 (Fnetwork_interface_info): Avoid possibility of int overflow.
5198 (read_process_output): Do adaptive read buffering even if carryover.
5199 (read_process_output): Simplify nbytes computation if buffered.
5201 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5203 * syntax.c (scan_words): Remove var that was set but not used.
5204 (update_syntax_table): Use unsigned instead of int.
5206 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5207 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5208 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5210 * print.c (print_error_message): Avoid int overflow.
5212 * font.c (font_list_entities): Redo for clarity,
5213 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5215 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5216 (font_score): Avoid potential overflow in diff calculation.
5218 * fns.c (substring_both): Remove var that is set but not used.
5219 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5221 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5223 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5224 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5225 can always succeed if overflow has undefined behavior.
5227 * search.c (boyer_moore, wordify): Remove vars set but not used.
5228 (wordify): Omit three unnecessary tests.
5230 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5231 All callers changed. This avoids the need for an unused var.
5233 * casefiddle.c (casify_region): Remove var that is set but not used.
5235 * dired.c (file_name_completion): Remove var that is set but not used.
5237 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5239 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5240 (Finsert_file_contents): Remove unnecessary code checking fd.
5242 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5243 Check for integer overflow on size calculations.
5245 * buffer.c (Fprevious_overlay_change): Remove var that is set
5248 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5249 Remove vars that are set but not used.
5250 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5251 (timer_check_2): Mark vars as initialized.
5253 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5255 * image.c (lookup_image): Remove var that is set but not used.
5256 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5258 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5259 that are set but not used.
5261 * xfns.c (make_invisible_cursor): Don't return garbage
5262 if XCreateBitmapFromData fails (Bug#8410).
5264 * xselect.c (x_get_local_selection, x_handle_property_notify):
5265 Remove vars that are set but not used.
5267 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5268 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5270 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5271 Remove var that is set but not used.
5272 (scroll_bar_windows_size): Now size_t, not int.
5273 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5276 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5277 (map_tty_color) [!defined MSDOS]: Likewise.
5279 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5281 * coding.c: Remove vars that are set but not used.
5282 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5283 All callers changed.
5284 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5285 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5286 (decode_coding_charset): Remove vars that are set but not used.
5288 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5289 that is set but not used.
5291 * print.c (print_object): Remove var that is set but not used.
5293 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5294 The gnulib version avoids calling malloc in the usual case,
5295 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5296 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5297 * filelock.c (current_lock_owner): Likewise.
5298 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5299 * sysdep.c: Include allocator.h, careadlinkat.h.
5300 (emacs_no_realloc_allocator): New static constant.
5301 (emacs_readlink): New function.
5302 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5303 ../lib/careadlinkat.h.
5305 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5307 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5308 first non-nil return value).
5310 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5312 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5313 if not defined (Bug#8403).
5315 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5317 * xdisp.c (display_count_lines): Remove parameter `start',
5318 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5319 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5320 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5321 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5322 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5323 and thereabouts. All callers changed.
5324 (get_per_char_metric): Remove parameter `f', unused since
5325 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5327 2011-04-02 Jim Meyering <meyering@redhat.com>
5329 do not dereference NULL upon failed strdup
5330 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5331 (ns_get_family): Likewise.
5333 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5335 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5337 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5339 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5342 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5344 Add lexical binding.
5346 * window.c (Ftemp_output_buffer_show): New fun.
5347 (Fsave_window_excursion):
5348 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5350 * lread.c (lisp_file_lexically_bound_p): New function.
5351 (Fload): Bind Qlexical_binding.
5352 (readevalloop): Remove `evalfun' arg.
5353 Bind Qinternal_interpreter_environment.
5354 (Feval_buffer): Bind Qlexical_binding.
5355 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5357 (syms_of_lread): Declare `lexical-binding'.
5359 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5361 * keyboard.c (eval_dyn): New fun.
5362 (menu_item_eval_property): Use it.
5364 * image.c (parse_image_spec): Use Ffunctionp.
5366 * fns.c (concat, mapcar1): Accept byte-code-functions.
5368 * eval.c (Fsetq): Handle lexical vars.
5369 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5370 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5371 (FletX, Flet): Obey lexical binding.
5372 (Fcommandp): Handle closures.
5373 (Feval): New `lexical' arg.
5374 (eval_sub): New function extracted from Feval. Use it almost
5375 everywhere where Feval was used. Look up vars in lexical env.
5377 (Ffunctionp): Move from subr.el.
5378 (Ffuncall): Handle closures.
5379 (apply_lambda): Remove `eval_flags'.
5380 (funcall_lambda): Handle closures and new byte-code-functions.
5381 (Fspecial_variable_p): New function.
5382 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5383 but without exporting it to Lisp.
5385 * doc.c (Fdocumentation, store_function_docstring):
5386 * data.c (Finteractive_form): Handle closures.
5388 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5391 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5393 (exec_byte_code): New function extracted from Fbyte_code to handle new
5394 calling convention for byte-code-functions. Add new byte-codes.
5396 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5398 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5400 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5402 * xdisp.c (redisplay_internal): Fix prototype.
5404 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5406 * xdisp.c (SCROLL_LIMIT): New macro.
5407 (try_scrolling): Use it when setting scroll_limit.
5408 Limit scrolling to 100 screen lines.
5409 (redisplay_window): Even when falling back on "recentering",
5410 position point in the window according to scroll-conservatively,
5411 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5413 (try_scrolling): When point is above the window, allow searching
5414 as far as scroll_max, or one screenful, to compute vertical
5415 distance from PT to the scroll margin position. This prevents
5416 try_scrolling from unnecessarily failing when
5417 scroll-conservatively is set to a value slightly larger than the
5418 window height. Clean up the case of PT below the margin at bottom
5419 of window: scroll_max can no longer be INT_MAX. When aggressive
5420 scrolling is in use, don't let point enter the opposite scroll
5421 margin as result of the scroll.
5422 (syms_of_xdisp) <scroll-conservatively>: Document the
5423 threshold of 100 lines for never-recentering scrolling.
5425 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5427 * dispextern.h (move_it_by_lines):
5428 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5429 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5430 (message_log_check_duplicate): Remove parameters `prev_bol' and
5431 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5432 (redisplay_internal): Remove parameter `preserve_echo_area',
5433 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5435 * indent.c (Fvertical_motion):
5436 * window.c (window_scroll_pixel_based, Frecenter):
5437 Don't pass `need_y_p' to `move_it_by_lines'.
5439 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5441 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5442 steal a few bits to be more compact.
5443 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5444 Remove unneeded casts.
5446 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5448 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5450 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5451 binding" message (bug#7967).
5453 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5455 Fix more problems found by GCC 4.6.0's static checks.
5457 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5458 Remove unused local var.
5460 * editfns.c (Fmessage_box): Remove unused local var.
5462 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5463 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5464 Omit unused local vars.
5465 * window.c (shrink_windows): Omit unused local var.
5466 * menu.c (digest_single_submenu): Omit unused local var.
5467 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5468 Omit unused local var.
5470 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5471 Don't assume string length fits in int.
5472 (keyremap_step, read_key_sequence): Use size_t for sizes.
5473 (read_key_sequence): Don't check last_real_key_start redundantly.
5475 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5476 instead of alloca (Bug#8344).
5478 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5479 (Fbacktrace_frame): Don't assume nframes fits in int.
5481 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5483 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5486 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5488 * cm.c (calccost): Turn while-do into do-while, for clarity.
5490 * keyboard.c (syms_of_keyboard): Use the same style as later
5491 in this function when indexing through an array. This also
5492 works around GCC bug 48267.
5494 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5496 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5498 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5499 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5501 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5502 This avoids undefined behavior on integer overflow, and is a bit
5503 more convenient anyway since it is compared to a size_t variable.
5505 Variadic C functions now count arguments with size_t, not int.
5506 This avoids an unnecessary limitation on 64-bit machines, which
5507 caused (substring ...) to crash on large vectors (Bug#8344).
5508 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5509 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5510 All variadic functions and their callers changed accordingly.
5511 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5512 * data.c (arith_driver, float_arith_driver): Likewise.
5513 * editfns.c (general_insert_function): Likewise.
5514 * eval.c (struct backtrace.nargs, interactive_p)
5515 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5516 (funcall_lambda, mark_backtrace): Likewise.
5517 * fns.c (concat): Likewise.
5518 * frame.c (x_set_frame_parameters): Likewise.
5519 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5520 0 if not found, not -1. All callers changed.
5522 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5523 (stack_copy_size): Now size_t, not int.
5524 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5526 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5528 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5529 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5530 All callers changed.
5532 * lisp.h (multibyte_char_to_unibyte):
5533 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5534 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5535 * character.h (CHAR_TO_BYTE8):
5536 * cmds.c (internal_self_insert):
5537 * editfns.c (general_insert_function):
5538 * keymap.c (push_key_description):
5539 * search.c (Freplace_match):
5540 * xdisp.c (message_dolog, set_message_1): All callers changed.
5542 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5544 * keyboard.c (safe_run_hook_funcall): New function.
5545 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5546 don't set the hook to nil, but remove the offending function instead.
5547 (Qcommand_hook_internal): Remove, unused.
5548 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5549 Vcommand_hook_internal.
5551 * eval.c (enum run_hooks_condition): Remove.
5552 (funcall_nil, funcall_not): New functions.
5553 (run_hook_with_args): Call each function through a `funcall' argument.
5554 Remove `cond' argument, now redundant.
5555 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5556 (Frun_hook_with_args_until_failure): Adjust accordingly.
5557 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5559 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5561 * dispextern.h (string_buffer_position): Remove declaration.
5563 * print.c (strout): Remove parameter `multibyte', unused since
5564 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5566 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5567 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5568 All callers changed.
5570 * w32.c (_wsa_errlist): Use braces for struct initializers.
5572 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5573 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5574 All callers changed.
5575 (string_buffer_position): Likewise. Also, make static (it's never
5576 used outside xdisp.c).
5577 (cursor_row_p): Remove parameter `w', unused since
5578 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5579 (decode_mode_spec): Remove parameter `precision', introduced during
5580 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5581 All callers changed.
5583 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5585 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5587 2011-03-27 Anders Lindgren <andlind@gmail.com>
5589 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5590 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5591 (ns_update_auto_hide_menu_bar): New functions.
5592 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5593 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5594 ns_constrain_all_frames.
5595 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5596 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5598 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5600 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5602 2011-03-27 Glenn Morris <rgm@gnu.org>
5604 * syssignal.h: Replace RETSIGTYPE with void.
5605 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5606 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5607 Replace SIGTYPE with void everywhere.
5608 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5609 * s/template.h (SIGTYPE): Remove commented out definition.
5611 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5613 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5614 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5616 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5618 * w32.c (read_unc_volume): Use parameter `henum', instead of
5619 global variable `wget_enum_handle'.
5621 * keymap.c (describe_vector): Remove parameters `indices' and
5622 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5623 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5625 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5627 * keyboard.c (timer_check): Remove parameter `do_it_now',
5628 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5629 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5630 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5632 * keyboard.c (read_char):
5633 * w32menu.c (w32_menu_display_help):
5634 * xmenu.c (show_help_event, menu_help_callback):
5635 Adjust calls to `show_help_echo'.
5637 * gtkutil.c (xg_maybe_add_timer):
5638 * keyboard.c (readable_events):
5639 * process.c (wait_reading_process_output):
5640 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5642 * insdel.c (adjust_markers_gap_motion):
5643 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5644 (gap_left, gap_right): Don't call it.
5646 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5648 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5649 incurred during fontification.
5651 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5653 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5654 (DEFVAR_PER_BUFFER): Don't pass it.
5656 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5657 (scrolling_window): Don't pass it.
5659 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5661 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5663 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5665 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5666 of variables specific to SELinux and computation of `encoded_absname'.
5668 * image.c (XPutPixel): Remove unused variable `height'.
5670 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5672 * unexw32.c (get_section_info): Remove unused variable `section'.
5674 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5675 (system_process_attributes): Remove unused variable `sess'.
5676 (sys_read): Remove unused variable `err'.
5678 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5679 (w32_wnd_proc): Remove unused variable `isdead'.
5680 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5681 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5682 (x_create_tip_frame): Remove unused variable `tem'.
5684 * w32inevt.c (w32_console_read_socket):
5685 Remove unused variable `no_events'.
5687 * w32term.c (x_draw_composite_glyph_string_foreground):
5688 Remove unused variable `width'.
5690 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5692 * w32term.c (x_set_glyph_string_clipping):
5693 Don't pass uninitialized region to CombineRgn.
5695 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5697 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5698 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5699 (Fx_close_connection): Remove unused variable `i'.
5701 * w32font.c (w32font_draw): Return number of glyphs.
5702 (w32font_open_internal): Remove unused variable `i'.
5703 (w32font_driver): Add missing initializer.
5705 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5706 (fill_in_menu): Remove unused variable `items_added'.
5708 * w32term.c (last_mouse_press_frame): Remove static global variable.
5709 (w32_clip_to_row): Remove unused variable `f'.
5710 (x_delete_terminal): Remove unused variable `i'.
5712 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5713 (NOTHING): Remove unused static global variable.
5714 (uniscribe_check_otf): Remove unused variable `table'.
5715 (uniscribe_font_driver): Add missing initializers.
5717 2011-03-23 Julien Danjou <julien@danjou.info>
5719 * term.c (Fsuspend_tty, Fresume_tty):
5720 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5721 * window.c (temp_output_buffer_show):
5722 * insdel.c (signal_before_change):
5723 * frame.c (Fhandle_switch_frame):
5724 * fileio.c (Fdo_auto_save):
5725 * emacs.c (Fkill_emacs):
5726 * editfns.c (save_excursion_restore):
5727 * cmds.c (internal_self_insert):
5728 * callint.c (Fcall_interactively):
5729 * buffer.c (Fkill_all_local_variables):
5730 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5732 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5733 unconditionnaly since it does the check itself.
5735 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5737 Fix more problems found by GCC 4.5.2's static checks.
5739 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5740 the first time through the loop, since we know p0 < p1 then.
5741 This also avoids a gcc -Wstrict-overflow warning.
5743 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5744 leading to a memory leak, possible in functions like
5745 load_charset_map_from_file that can allocate an unbounded number
5746 of objects (Bug#8318).
5748 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5749 that could (at least in theory) be that large.
5751 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5752 This is less likely to overflow, and avoids undefined behavior if
5753 overflow does occur. All callers changed. Use strtoul to scan
5754 for the unsigned long integer.
5755 (pint2hrstr): Simplify and tune code slightly.
5756 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5758 * scroll.c (do_scrolling): Work around GCC bug 48228.
5759 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5761 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5762 This also avoids a warning with gcc -Wstrict-overflow.
5763 (validate_x_resource_name): Simplify count usage.
5764 This also avoids a warning with gcc -Wstrict-overflow.
5766 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5769 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5771 * process.c (Fmake_network_process): Use socklen_t, not int,
5772 where POSIX says socklen_t is required in portable programs.
5773 This fixes a porting bug on hosts like 64-bit HP-UX, where
5774 socklen_t is wider than int (Bug#8277).
5775 (Fmake_network_process, server_accept_connection):
5776 (wait_reading_process_output, read_process_output):
5779 * process.c: Rename or move locals to avoid shadowing.
5780 (list_processes_1, Fmake_network_process):
5781 (read_process_output_error_handler, exec_sentinel_error_handler):
5782 Rename or move locals.
5783 (Fmake_network_process): Define label "retry_connect" only if needed.
5784 (Fnetwork_interface_info): Fix pointer signedness.
5785 (process_send_signal): Add cast to avoid pointer signedness problem.
5786 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5787 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5789 Make tparam.h and terminfo.c consistent.
5790 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5791 Include tparam.h instead, since it declares them.
5792 * cm.h (PC): Remove extern decl; tparam.h now does this.
5793 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5794 * terminfo.c: Include tparam.h, to check interfaces.
5795 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5796 (tparam): Adjust signature to match interface in tparam.h;
5797 this removes some undefined behavior. Check that outstring and len
5798 are zero, which they always are with Emacs.
5799 * tparam.h (PC, BC, UP): New extern decls.
5801 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5802 (xftfont_open): Rename locals to avoid shadowing.
5804 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5805 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5806 (OTF_TAG_SYM): Omit macro if not needed.
5807 (ftfont_list): Remove unused local.
5808 (get_adstyle_property, ftfont_pattern_entity):
5809 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5810 Rename locals to avoid shadowing.
5812 * xfont.c (xfont_list_family): Mark var as initialized.
5814 * xml.c (make_dom): Now static.
5816 * composite.c (composition_compute_stop_pos): Rename local to
5818 (composition_reseat_it): Remove unused locals.
5819 (find_automatic_composition, composition_adjust_point): Likewise.
5820 (composition_update_it): Mark var as initialized.
5821 (find_automatic_composition): Mark vars as initialized,
5822 with a FIXME (Bug#8290).
5824 character.h: Rename locals to avoid shadowing.
5825 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5826 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5827 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5828 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5831 * textprop.c (property_change_between_p): Remove; unused.
5833 * intervals.c (interval_start_pos): Now static.
5835 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5837 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5838 Rename locals to avoid shadowing.
5840 * sound.c (wav_play, au_play, Fplay_sound_internal):
5841 Fix pointer signedness.
5842 (alsa_choose_format): Remove unused local var.
5843 (wav_play): Initialize a variable to 0, to prevent undefined
5844 behavior (Bug#8278).
5846 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5848 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5850 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5851 clobbering (Bug#8298).
5852 * sysdep.c (sys_subshell): Likewise.
5853 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5855 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5856 This should get cleaned up, so that child_setup has the
5857 same signature on all platforms.
5859 * callproc.c (call_process_cleanup): Now static.
5860 (relocate_fd): Rename locals to avoid shadowing.
5862 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5864 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5865 not to be necessary, and produces flickering.
5867 2011-03-20 Glenn Morris <rgm@gnu.org>
5869 * config.in: Remove file.
5871 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5873 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5874 are now in src/globals.h.
5875 (syms_of_minibuf): Remove spurious & from previous change.
5877 2011-03-20 Leo <sdl.web@gmail.com>
5879 * minibuf.c (completing-read-function): New variable.
5880 (completing-read-default): Rename from completing-read.
5881 (completing-read): Call completing-read-function.
5883 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5885 * xfaces.c (Fx_load_color_file):
5886 Read color file from absolute filename (bug#8250).
5888 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5890 * makefile.w32-in: Update dependencies.
5892 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5894 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5896 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5898 Fix more problems found by GCC 4.5.2's static checks.
5900 * process.c (make_serial_process_unwind, send_process_trap):
5901 (sigchld_handler): Now static.
5903 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5904 That way, the code declares only the vars that it needs.
5905 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5906 * s/cygwin.h (PTY_ITERATION): Likewise.
5907 * s/darwin.h (PTY_ITERATION): Likewise.
5908 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5910 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5911 * process.c (allocate_pty): Don't declare stb unless it's needed.
5913 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5914 (CONSTANTLIM): Remove; unused.
5915 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5916 Define only if needed.
5918 * unexelf.c (unexec): Name an expression,
5919 to avoid gcc -Wbad-function-cast warning.
5920 Use a different way to cause a compilation error if anyone uses
5921 n rather than nn, a way that does not involve shadowing.
5922 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5924 * deps.mk (unexalpha.o): Remove; unused.
5926 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5927 * unexec.h: New file.
5928 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5929 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5931 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5932 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5933 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5934 Change as necessary to match prototype in unexec.h.
5936 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5938 (back_comment, skip_chars): Mark vars as initialized.
5940 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5941 Rename locals to avoid shadowing.
5943 * lread.c (read1): Rewrite so as not to use empty "else".
5944 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5946 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5948 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5949 warning when compiling print.c.
5951 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5952 instead of using an uninitialized var.
5953 (font_sort_entities): Mark var as initialized.
5955 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5957 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5958 pointers to constants.
5959 (font_parse_fcname): Remove unused vars.
5960 (font_delete_unmatched): Now static.
5961 (font_get_spec): Remove; unused.
5962 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5963 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5964 Rename or move locals to avoid shadowing.
5966 * fns.c (require_nesting_list, require_unwind): Now static.
5967 (Ffillarray): Rename locals to avoid shadowing.
5969 * floatfns.c (domain_error2): Define only if needed.
5970 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5972 * alloc.c (mark_backtrace): Move decl from here ...
5973 * lisp.h: ... to here, so that it can be checked.
5975 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5976 (Fdefvar): Rewrite so as not to use empty "else".
5977 (lisp_indirect_variable): Name an expression,
5978 to avoid gcc -Wbad-function-cast warning.
5979 (Fdefvar): Rename locals to avoid shadowing.
5981 * callint.c (quotify_arg, quotify_args): Now static.
5982 (Fcall_interactively): Rename locals to avoid shadowing.
5983 Use const pointer when appropriate.
5985 * lisp.h (get_system_name, get_operating_system_release):
5986 Move decls here, to check interfaces.
5987 * process.c (get_operating_system_release): Move decl to lisp.h.
5988 * xrdb.c (get_system_name): Likewise.
5989 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5990 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5991 some of which prompt warnings from gcc -Wbad-function-cast.
5992 (Fformat_time_string, Fencode_time, Finsert_char):
5993 (Ftranslate_region_internal, Fformat):
5994 Rename or remove local vars to avoid shadowing.
5995 (Ftranslate_region_internal): Mark var as initialized.
5997 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6000 * lisp.h (eassert): Check that the argument compiles, even if
6001 ENABLE_CHECKING is not defined.
6003 * data.c (Findirect_variable): Name an expression, to avoid
6004 gcc -Wbad-function-cast warning.
6005 (default_value, arithcompare, arith_driver, arith_error): Now static.
6006 (store_symval_forwarding): Rename local to avoid shadowing.
6007 (Fmake_variable_buffer_local, Fmake_local_variable):
6008 Mark variables as initialized.
6009 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6011 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6012 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6013 Rename locals to avoid shadowing.
6014 (mark_stack): Move local variables into the #ifdef region where
6016 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6017 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6019 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6020 (GC_STRING_CHARS): Remove; not used.
6021 (Fmemory_limit): Cast sbrk's returned value to char *.
6023 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6024 avoids undefined behavior in theory.
6026 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6028 Use functions, not macros, for up- and down-casing (Bug#8254).
6029 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6030 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6031 to use the following functions instead of these macros.
6032 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6033 EMACS_INT, since callers assume the returned value fits in int.
6034 (upcase1): Likewise, for UPCASE_TABLE.
6035 (uppercasep, lowercasep, upcase): New static inline functions.
6036 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6037 the race-condition problem in the old DOWNCASE.
6039 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6040 Rename locals to avoid shadowing.
6041 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6042 (regex_compile, re_search_2, re_match_2_internal):
6043 Remove unused local vars.
6044 (FREE_VAR): Rewrite so as not to use empty "else",
6045 which gcc can warn about.
6046 (regex_compile, re_match_2_internal): Mark locals as initialized.
6047 (RETALLOC_IF): Define only if needed.
6048 (WORDCHAR_P): Likewise. This one is never needed, but is used
6049 only in a comment talking about a compiler bug, so put inside
6050 the #if 0 of that comment.
6051 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6052 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6055 * search.c (boyer_moore): Rename locals to avoid shadowing.
6056 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6057 (PREV_CHAR_BOUNDARY): Likewise.
6059 * search.c (simple_search): Remove unused var.
6061 * dired.c (compile_pattern): Move decl from here ...
6062 * lisp.h: ... to here, so that it can be checked.
6063 (struct re_registers): New forward decl.
6065 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6067 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6069 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6070 Rename locals to avoid shadowing.
6071 (Fvertical_motion): Mark locals as initialized.
6073 * casefiddle.c (casify_object, casify_region): Now static.
6074 (casify_region): Mark local as initialized.
6076 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6078 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6079 New macros, so that the caller can use some names other than
6080 gcpro1, gcpro2, etc.
6081 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6083 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6084 argument, for consistency with GCPRO2_VAR, etc: it is now the
6085 prefix of the variable, not the variable itself. All uses
6087 * dired.c (directory_files_internal, file_name_completion):
6088 Rename locals to avoid shadowing.
6090 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6091 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6092 dired.c's scmp function, had undefined behavior.
6093 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6095 * buffer.h: ... to here, because these macros use current_buffer,
6096 and the new implementation with inline functions needs to have
6097 current_buffer in scope now, rather than later when the macros
6099 (downcase, upcase1): New static inline functions.
6100 (DOWNCASE, UPCASE1): Reimplement using these functions.
6101 This avoids undefined behavior in expressions like
6102 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6103 from race conditions in accessing the global variables
6104 case_temp1 and case_temp2.
6105 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6106 * lisp.h (case_temp1, case_temp2): Remove their decls.
6107 * character.h (ASCII_CHAR_P): Move from here ...
6108 * lisp.h: ... to here, so that the inline functions mentioned
6111 * dired.c (directory_files_internal_unwind): Now static.
6113 * fileio.c (file_name_as_directory, directory_file_name):
6114 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6116 (file_name_as_directory): Use const pointers when appropriate.
6117 (Fexpand_file_name): Likewise. In particular, newdir might
6118 point at constant storage, so make it a const pointer.
6119 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6120 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6122 (Fset_file_times, Finsert_file_contents, auto_save_error):
6123 Rename locals to avoid shadowing.
6125 * minibuf.c (choose_minibuf_frame_1): Now static.
6126 (Ftry_completion, Fall_completions): Rename or remove locals
6129 * marker.c (bytepos_to_charpos): Remove; unused.
6131 * lisp.h (verify_bytepos, count_markers): New decls,
6132 so that gcc does not warn that these functions aren't declared.
6134 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6135 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6136 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6137 (copy_text): Remove unused local var.
6139 * filelock.c (within_one_second): Now static.
6140 (lock_file_1): Rename local to avoid shadowing.
6142 * buffer.c (fix_overlays_before): Mark locals as initialized.
6143 (fix_start_end_in_overlays): Likewise. This function should be
6144 simplified by using pointers-to-pointers, but that's a different
6146 (switch_to_buffer_1): Now static.
6147 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6148 (report_overlay_modification): Rename locals to avoid shadowing.
6150 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6151 Fix pointer signedness issue.
6152 (sys_subshell): Mark local as volatile if checking for lint,
6153 to suppress a gcc -Wclobbered warning that does not seem to be right.
6154 (MAXPATHLEN): Define only if needed.
6156 * process.c (serial_open, serial_configure): Move decls from here ...
6157 * systty.h: ... to here, so that they can be checked.
6159 * fns.c (get_random, seed_random): Move extern decls from here ...
6160 * lisp.h: ... to here, so that they can be checked.
6162 * sysdep.c (reset_io): Now static.
6163 (wait_for_termination_signal): Remove; unused.
6165 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6166 (copy_keymap_item, append_key, push_text_char_description):
6168 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6169 (DENSE_TABLE_SIZE): Remove; unused.
6170 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6171 (describe_map_tree):
6172 Rename locals to avoid shadowing.
6174 * keyboard.c: Declare functions static if they are not used elsewhere.
6175 (echo_char, echo_dash, cmd_error, top_level_2):
6176 (poll_for_input, handle_async_input): Now static.
6177 (read_char, kbd_buffer_get_event, make_lispy_position):
6178 (make_lispy_event, make_lispy_movement, apply_modifiers):
6179 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6180 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6181 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6182 (read_key_sequence, read_char): Mark locals as initialized.
6183 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6185 * keyboard.h (make_ctrl_char): New decl.
6186 (mark_kboards): Move decl here ...
6187 * alloc.c (mark_kboards): ... from here.
6189 * lisp.h (force_auto_save_soon): New decl.
6191 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6192 (DEFINE_DUMMY_FUNCTION): New macro.
6193 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6195 (main): Add casts to avoid warnings
6196 if GCC considers string literals to be constants.
6198 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6200 * dbusbind.c: Pointer signedness fixes.
6201 (xd_signature, xd_append_arg, xd_initialize):
6202 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6203 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6204 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6205 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6207 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6208 if GCC considers string literals to be constants.
6209 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6211 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6213 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6214 (print_preprocess, print_object): New macro to fix last change.
6216 * print.c (print_preprocess): Don't forget font objects.
6218 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6220 * emacs.c (USAGE3): Doc fixes.
6222 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6224 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6227 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6229 * lisp.h (VWindow_system, Qfile_name_history):
6230 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6231 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6232 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6234 * w32select.c: Don't #include "keyboard.h".
6235 (run_protected): Add extern declaration for waiting_for_input.
6237 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6238 * w32console.c (detect_input_pending, read_input_pending)
6239 (encode_terminal_code):
6240 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6241 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6242 (w32_system_caret_y, Qfile_name_history):
6243 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6244 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6245 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6246 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6247 * w32proc.c (Qlocal, report_file_error):
6248 * w32term.c (Vwindow_system, updating_frame):
6249 * w32uniscribe.c (initialized, uniscribe_font_driver):
6250 Remove unneeded extern declarations.
6252 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6254 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6256 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6258 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6259 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6260 These macros can no longer be used for assignment.
6262 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6263 Assign struct members directly, instead of using BUF_BEGV etc.
6264 (record_buffer_markers, fetch_buffer_markers): New functions for
6265 recording and fetching special buffer markers.
6266 (set_buffer_internal_1, set_buffer_temp): Use them.
6268 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6270 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6272 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6273 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6275 * xdisp.c (hscroll_window_tree):
6276 (reconsider_clip_changes): Use PT instead of BUF_PT.
6278 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6280 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6281 $(EMACS_ROOT)/lib/intprops.h.
6283 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6285 Fix more problems found by GCC 4.5.2's static checks.
6287 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6288 to unsigned char * to avoid compiler diagnostic.
6289 (xg_free_frame_widgets): Make it clear that a local variable is
6290 needed only if USE_GTK_TOOLTIP.
6291 (gdk_window_get_screen): Make it clear that this macro is needed
6292 only if USE_GTK_TOOLTIP.
6293 (int_gtk_range_get_value): New function, which avoids a diagnostic
6294 from gcc -Wbad-function-cast.
6295 (xg_set_toolkit_scroll_bar_thumb): Use it.
6296 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6297 diagnostic from gcc -Wbad-function-cast.
6298 (get_utf8_string, xg_get_file_with_chooser):
6299 Rename locals to avoid shadowing.
6300 (create_dialog): Move locals to avoid shadowing.
6302 * xgselect.c (xg_select): Remove unused var.
6304 * image.c (four_corners_best): Mark locals as initialized.
6305 (gif_load): Initialize transparent_p to zero (Bug#8238).
6306 Mark another local as initialized.
6307 (my_png_error, my_error_exit): Mark with NO_RETURN.
6309 * image.c (clear_image_cache): Now static.
6310 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6311 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6312 (x_edge_detection): Remove unnecessary cast that
6313 gcc -Wbad-function-cast diagnoses.
6314 (gif_load): Fix pointer signedness.
6315 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6316 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6318 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6320 Improve quality of tests for time stamp overflow.
6321 For example, without this patch (encode-time 0 0 0 1 1
6322 1152921504606846976) returns the obviously-bogus value (-948597
6323 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6324 reports time overflow. See
6325 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6326 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6327 * editfns.c: Include limits.h and intprops.h.
6328 (TIME_T_MIN, TIME_T_MAX): New macros.
6329 (time_overflow): Move earlier, to before first use.
6330 (hi_time, lo_time): New functions, for an accurate test for
6332 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6333 (Fget_internal_run_time): Don't assume time_t fits in int.
6334 (make_time): Use list2 instead of Fcons twice.
6335 (Fdecode_time): More accurate test for out-of-range times.
6336 (check_tm_member): New function.
6337 (Fencode_time): Use it, to test for out-of-range times.
6338 (lisp_time_argument): Don't rely on undefined left-shift and
6339 right-shift behavior when checking for time stamp overflow.
6341 * editfns.c (time_overflow): New function, refactoring common code.
6342 (Fformat_time_string, Fdecode_time, Fencode_time):
6343 (Fcurrent_time_string): Use it.
6345 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6346 * dired.c (make_time): Move to ...
6347 * editfns.c (make_time): ... here.
6348 * systime.h: Note the move.
6350 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6352 * fringe.c (update_window_fringes): Remove unused variables.
6354 * unexmacosx.c (copy_data_segment): Also copy __got section.
6357 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6359 * termcap.c [MSDOS]: Include "msdos.h".
6360 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6361 Constify `char *' arguments and their references according to
6362 prototypes in tparam.h.
6364 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6366 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6367 Adapt all references accordingly.
6369 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6371 2011-03-11 Tom Tromey <tromey@redhat.com>
6373 * buffer.c (syms_of_buffer): Remove obsolete comment.
6375 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6377 * termhooks.h (encode_terminal_code): Declare prototype.
6379 * msdos.c (encode_terminal_code): Don't declare prototype.
6381 * term.c (encode_terminal_code): Now external again, used by
6382 w32console.c and msdos.c.
6384 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6385 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6387 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6389 Fix some minor problems found by GCC 4.5.2's static checks.
6391 * fringe.c (update_window_fringes): Mark locals as initialized
6393 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6395 * alloc.c (mark_fringe_data): Move decl from here ...
6396 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6397 to check its interface.
6398 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6400 * fontset.c (free_realized_fontset): Now static.
6401 (Fset_fontset_font): Rename local to avoid shadowing.
6402 (fontset_font): Mark local as initialized.
6403 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6405 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6407 * xselect.c (x_disown_buffer_selections): Remove; not used.
6408 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6409 (x_own_selection, Fx_disown_selection_internal): Rename locals
6411 (x_handle_dnd_message): Remove local to avoid shadowing.
6413 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6414 so that the caller can use some name other than gcpro1.
6415 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6416 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6417 (Fx_backspace_delete_keys_p):
6418 Use them to avoid shadowing, and rename vars to avoid shadowing.
6419 (x_decode_color, x_set_name, x_window): Now static.
6420 (Fx_create_frame): Add braces to silence GCC warning.
6421 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6422 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6423 Remove unused locals.
6424 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6425 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6426 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6429 * xterm.h (x_mouse_leave): New decl.
6431 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6432 Remove unused functions.
6433 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6434 (x_calc_absolute_position): Now static.
6435 (XTread_socket): Don't define label "out" unless it's used.
6436 Don't declare local "event" unless it's used.
6437 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6438 unless they are used.
6439 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6440 (x_fatal_error_signal): Remove; not used.
6441 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6442 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6443 (x_error_catcher, x_connection_closed, x_error_handler):
6444 (x_error_quitter, xembed_send_message, x_iconify_frame):
6445 (my_log_handler): Rename locals to avoid shadowing.
6446 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6447 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6449 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6450 Rename or move locals to avoid shadowing.
6451 (tty_defined_color, merge_face_heights): Now static.
6452 (free_realized_faces_for_fontset): Remove; not used.
6453 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6454 does not deduce is never used uninitialized.
6455 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6456 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6458 * terminal.c (store_terminal_param): Now static.
6460 * xmenu.c (menu_highlight_callback): Now static.
6461 (set_frame_menubar): Remove unused local.
6462 (xmenu_show): Rename parameter to avoid shadowing.
6463 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6464 since they might point to immutable storage.
6465 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6466 since it's unused otherwise.
6468 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6469 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6470 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6471 avoids a gcc -Wuninitialized diagnostic.
6472 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6473 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6474 does not deduce are never used uninitialized.
6476 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6478 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6479 * window.c (window_loop, size_window):
6480 (run_window_configuration_change_hook, enlarge_window): Likewise.
6482 * window.c (display_buffer): Now static.
6483 (size_window): Mark variables that gcc -Wuninitialized
6484 does not deduce are never used uninitialized.
6485 * window.h (check_all_windows): New decl, to forestall
6486 gcc -Wmissing-prototypes diagnostic.
6487 * dispextern.h (bidi_dump_cached_states): Likewise.
6489 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6491 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6493 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6494 and to avoid gcc -Wuninitialized warning.
6495 (load_charset_map): Mark variables that gcc -Wuninitialized
6496 does not deduce are never used uninitialized.
6497 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6499 * coding.c (coding_set_source, coding_set_destination):
6500 Use "else { /* comment */ }" rather than "else /* comment */;"
6501 for clarity, and to avoid gcc -Wempty-body warning.
6502 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6503 a block, when the outer 'i' will do.
6504 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6505 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6506 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6507 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6508 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6509 Rename locals to avoid shadowing.
6510 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6511 * coding.c (emacs_mule_char, encode_invocation_designation):
6512 Now static, since they're not used elsewhere.
6513 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6514 (decode_coding_object, encode_coding_object, detect_coding_system):
6515 (decode_coding_emacs_mule): Mark variables that gcc
6516 -Wuninitialized does not deduce are never used uninitialized.
6517 (detect_coding_iso_2022): Initialize a local variable that might
6518 be used uninitialized. Leave a FIXME because it's not clear that
6519 this initialization is needed. (Bug#8211)
6520 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6521 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6522 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6523 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6524 Remove unused macros.
6526 * category.c (hash_get_category_set): Remove unused local var.
6527 (copy_category_table): Now static, since it's not used elsewhere.
6528 * character.c (string_count_byte8): Likewise.
6530 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6531 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6533 * chartab.c (copy_sub_char_table): Now static, since it's not used
6535 (sub_char_table_ref_and_range, char_table_ref_and_range):
6536 Rename locals to avoid shadowing.
6537 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6539 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6540 (BIDI_BOB): Remove unused macro.
6542 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6543 deduce are never used uninitialized.
6544 * term.c (encode_terminal_code): Likewise.
6546 * term.c (encode_terminal_code): Now static. Remove unused local.
6548 * tparam.h: New file.
6549 * term.c, tparam.h: Include it.
6550 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6551 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6552 Move these decls to tparam.h, and make them agree with what
6553 is actually in tparam.c. The previous trick of using incompatible
6554 decls in different modules does not conform to the C standard.
6555 All callers of tparam changed to use tparam's actual API.
6556 * tparam.c (tparam1, tparam, tgoto):
6557 Use const pointers where appropriate.
6559 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6560 * cm.h (struct cm): Likewise.
6561 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6562 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6563 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6564 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6565 (turn_on_face, init_tty): Likewise.
6566 * termchar.h (struct tty_display_info): Likewise.
6568 * term.c (term_mouse_position): Rename local to avoid shadowing.
6570 * alloc.c (mark_ttys): Move decl from here ...
6571 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6573 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6575 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6577 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6579 * search.c (compile_pattern_1): Remove argument regp, unused since
6580 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6581 (compile_pattern): Don't pass it.
6583 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6585 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6586 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6588 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6590 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6592 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6593 gdk_window_get_screen, gdk_window_get_geometry,
6594 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6595 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6596 (xg_get_pixbuf_from_pixmap): New function.
6597 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6598 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6599 Call xg_get_pixbuf_from_pixmap instead of
6600 gdk_pixbuf_get_from_drawable.
6601 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6602 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6603 (xg_check_special_colors): Use GtkStyleContext and its functions
6605 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6606 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6607 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6608 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6609 Call gtk_widget_get_preferred_size.
6610 (xg_frame_resized): gdk_window_get_geometry only takes 5
6612 (xg_win_to_widget, xg_event_is_for_menubar):
6613 Call gdk_x11_window_lookup_for_display.
6614 (xg_set_widget_bg): New function.
6615 (delete_cb): New function.
6616 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6617 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6618 (xg_set_background_color): Call xg_set_widget_bg.
6619 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6620 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6621 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6622 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6624 (update_frame_tool_bar): Call gtk_widget_hide.
6625 (xg_initialize): Use GDK_KEY_g.
6627 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6629 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6631 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6632 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6633 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6635 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6637 * w32xfns.c (select_palette): Check success of RealizePalette against
6638 GDI_ERROR, not zero.
6640 See ChangeLog.11 for earlier changes.
6646 Copyright (C) 2011 Free Software Foundation, Inc.
6648 This file is part of GNU Emacs.
6650 GNU Emacs is free software: you can redistribute it and/or modify
6651 it under the terms of the GNU General Public License as published by
6652 the Free Software Foundation, either version 3 of the License, or
6653 (at your option) any later version.
6655 GNU Emacs is distributed in the hope that it will be useful,
6656 but WITHOUT ANY WARRANTY; without even the implied warranty of
6657 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6658 GNU General Public License for more details.
6660 You should have received a copy of the GNU General Public License
6661 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.