Fix --reverse-video on ttys.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
043604ee
CY
12011-07-22 Chong Yidong <cyd@stupidchicken.com>
2
3 * frame.c (Fmodify_frame_parameters): In tty case, update the
4 default face if necessary (Bug#4238).
5
da4adb04
CY
62011-07-21 Chong Yidong <cyd@stupidchicken.com>
7
8 * editfns.c (Fstring_to_char): No need to explain what a character
9 is in the docstring (Bug#6576).
10
9abd0532
LMI
112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12
13 * xml.c (parse_region): Make sure we always return a tree.
14
36881d16
HK
152011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
16
17 * xml.c (parse_region): If a document contains only comments,
18 return that, too.
19
1e98674d
LMI
202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
21
22 * xml.c (make_dom): Return comments, too.
23
590bd467
PE
242011-07-19 Paul Eggert <eggert@cs.ucla.edu>
25
26 Port to OpenBSD.
27 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
28 and the surrounding thread.
29 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
30 rather than fgets, and retry after EINTR. Otherwise, 'emacs
31 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
32 timer goes off.
33 * s/openbsd.h (BROKEN_SIGIO): Define.
34 * unexelf.c (unexec) [__OpenBSD__]:
35 Don't update the .mdebug section of the Alpha COFF symbol table.
36
f41628b2
LMI
372011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
38
39 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
40 (bug#8460).
41
b59b67c5
PE
422011-07-18 Paul Eggert <eggert@cs.ucla.edu>
43
15e3a074
PE
44 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
45 This fixes some race conditions on the permissions of any newly
46 created file.
47
41bed37d
PE
48 * alloc.c (valid_pointer_p): Use pipe, not open.
49 This fixes some permissions issues when debugging.
50
b59b67c5
PE
51 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
52 If fchown fails to set both uid and gid, try to set just gid,
53 as that is sometimes allowed. Adjust the file's mode to eliminate
54 setuid or setgid bits that are inappropriate if fchown fails.
55
925a6be7
SM
562011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
57
58 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
59 to compare Lisp_Objects.
60 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
61 global_gnutls_log_level, don't mistake it for a Lisp_Object.
62 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
63
52968808
AS
642011-07-17 Andreas Schwab <schwab@linux-m68k.org>
65
0a6a104b
AS
66 * lread.c (read_integer): Unread even EOF character.
67 (read1): Likewise. Properly record start position of symbol.
68
52968808
AS
69 * lread.c (read1): Read `#:' as empty uninterned symbol if no
70 symbol character follows.
71
9e381cdd
PE
722011-07-17 Paul Eggert <eggert@cs.ucla.edu>
73
74 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
75 This works around a problem with the previous change to Fcopy_file.
76 Recent glibc declares fchown with __attribute__((warn_unused_result)),
77 and without this change, GCC might complain about discarding
78 fchown's return value.
79
b5641435
JB
802011-07-16 Juanma Barranquero <lekktu@gmail.com>
81
82 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
83
a8031457
PE
842011-07-16 Paul Eggert <eggert@cs.ucla.edu>
85
86 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
87
dd889327
LMI
882011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
89
750c33f7
LMI
90 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
91 it's used from the C level.
92
dd889327
LMI
93 * process.c: Use the same condition for POLL_FOR_INPUT in both
94 keyboard.c and process.c (bug#1858).
95
87e86684
LM
962011-07-09 Lawrence Mitchell <wence@gmx.li>
97
98 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
99 (Fgnutls_boot): Use it.
100
64348f40
AS
1012011-07-15 Andreas Schwab <schwab@linux-m68k.org>
102
103 * doc.c (Fsubstitute_command_keys): Revert last change.
104
1d698799
LMI
1052011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
106
f863868c
LMI
107 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
108 quotes the next character, and doesn't affect other longer
109 sequences (bug#8935).
110
1d698799
LMI
111 * lread.c (syms_of_lread): Clarify that is isn't only
112 `eval-buffer' and `eval-defun' that's affected by
113 `lexical-binding' (bug#8460).
114
aa4b6df6
EZ
1152011-07-15 Eli Zaretskii <eliz@gnu.org>
116
117 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
118 bidi redisplay when a line includes both an image and is
119 truncated.
120
5d856da6
PE
1212011-07-14 Paul Eggert <eggert@cs.ucla.edu>
122
ad6042bb
PE
123 Fix minor problems found by static checking.
124 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
125 (elsz): Now a signed constant, not a size_t var. We prefer signed
126 types to unsigned, to avoid integer comparison confusion. Without
127 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
128 "cannot optimize loop, the loop counter may overflow", a symptom
129 of the confusion.
f00bbb22 130 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
131 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
132
6468f31c
LMI
1332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
134
49080b10
LMI
135 * search.c (Fre_search_backward): Mention `case-fold-search' in
136 all the re_search_* functions (bug#8138).
137
6468f31c
LMI
138 * keyboard.c (Fopen_dribble_file): Document when the file is
139 closed (bug#8056).
140
c965adc5
EZ
1412011-07-14 Eli Zaretskii <eliz@gnu.org>
142
df9733bf
EZ
143 * bidi.c (bidi_dump_cached_states): Fix format of displaying
144 bidi_cache_idx.
145
0bb23927
EZ
146 Support bidi reordering of display and overlay strings.
147 * xdisp.c (compute_display_string_pos)
148 (compute_display_string_end): Accept additional argument STRING.
149 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
150 (reseat_to_string): Initialize bidi_it->string.s and
151 bidi_it->string.schars.
152 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
153 NULL (avoids a crash in bidi_paragraph_init). Initialize
154 itb.string.lstring.
155 (init_iterator): Call bidi_init_it only of a valid
156 buffer position was specified. Initialize paragraph_embedding to
157 L2R.
158 (reseat_to_string): Initialize the bidi iterator.
159 (display_string): If we need to ignore text properties of
160 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
161 original value of -1 will not work with bidi.)
162 (compute_display_string_pos): First arg is now struct
163 `text_pos *'; all callers changed. Support display properties on
164 Lisp strings.
165 (compute_display_string_end): Support display properties on Lisp
166 strings.
167 (init_iterator, reseat_1, reseat_to_string): Initialize the
168 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
169 when iterating on a string not from display properties).
170 (compute_display_string_pos, compute_display_string_end): Fix
171 calculation of the object to scan. Fixes an error when using
172 arrow keys.
173 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
174 base_level_stop; instead, set base_level_stop to BEGV. Fixes
175 crashes in vertical-motion.
176 (next_element_from_buffer): Improve commentary for when
177 the iterator is before prev_stop.
178 (init_iterator): Initialize bidi_p from the default value of
179 bidi-display-reordering, not from buffer-local value. Use the
180 buffer-local value only if initializing for buffer iteration.
181 (handle_invisible_prop): Support invisible properties on strings
182 that are being bidi-reordered.
183 (set_iterator_to_next): Support bidi reordering of C strings and
184 Lisp strings.
185 (next_element_from_string): Support bidi reordering of Lisp
186 strings.
187 (handle_stop_backwards): Support Lisp strings as well.
188 (display_string): Support display of R2L glyph rows. Use
189 IT_STRING_CHARPOS when displaying from a Lisp string.
190 (init_iterator): Don't initialize it->bidi_p for strings
191 here.
192 (reseat_to_string): Initialize it->bidi_p for strings here.
193 (next_element_from_string, next_element_from_c_string)
194 (next_element_from_buffer): Add xassert's for correspondence
195 between IT's object being iterated and it->bidi_it.string
196 structure.
197 (face_before_or_after_it_pos): Support bidi iteration.
198 (next_element_from_c_string): Handle the case of the first string
199 character that is not the first one in the visual order.
200 (get_visually_first_element): New function, refactored from common
201 parts of next_element_from_buffer, next_element_from_string, and
202 next_element_from_c_string.
203 (tool_bar_lines_needed, redisplay_tool_bar)
204 (display_menu_bar): Force left-to-right direction. Add a FIXME
205 comment for making that be controlled by a user option.
206 (push_it, pop_it): Save and restore the state of the
207 bidi iterator. Save and restore the bidi_p flag.
208 (pop_it): Iterate out of display property for string iteration as
209 well.
210 (iterate_out_of_display_property): Support iteration over strings.
211 (handle_single_display_spec): Set up it->bidi_it for iteration
212 over a display string, and call bidi_init_it.
213 (handle_single_display_spec, next_overlay_string)
214 (get_overlay_strings_1, push_display_prop): Set up the bidi
215 iterator for displaying display or overlay strings.
216 (forward_to_next_line_start): Don't use the shortcut if
217 bidi-iterating.
218 (back_to_previous_visible_line_start): If handle_display_prop
219 pushed the iterator stack, restore the internal state of the bidi
220 iterator by calling bidi_pop_it same number of times.
221 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
222 and we are bidi-iterating, don't decrement the iterator position;
223 instead, set the first_elt flag in the bidi iterator, to produce
224 the same effect.
225 (reseat_1): Remove redundant setting of string_from_display_prop_p.
226 (push_display_prop): xassert that we are iterating a buffer.
227 (push_it, pop_it): Save and restore paragraph_embedding member.
228 (handle_single_display_spec, next_overlay_string)
229 (get_overlay_strings_1, reseat_1, reseat_to_string)
230 (push_display_prop): Set up the `unibyte' member of bidi_it.string
231 correctly. Don't assume unibyte strings are not bidi-reordered.
232 (compute_display_string_pos)
233 (compute_display_string_end): Fix handling the case of C string.
234 (push_it, pop_it): Save and restore from_disp_prop_p.
235 (handle_single_display_spec, push_display_prop): Set the
236 from_disp_prop_p flag.
237 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
238 (pop_it): Call iterate_out_of_display_property only if we are
239 popping after iteration over a string that came from a display
240 property. Fix a typo in popping stretch info. Add an assertion
241 for verifying that the iterator position is in sync with the bidi
242 iterator.
243 (handle_single_display_spec, get_overlay_strings_1)
244 (push_display_prop): Fix initialization of paragraph direction for
245 string when that of the parent object is not yet determined.
246 (reseat_1): Call bidi_init_it to resync the bidi
247 iterator with IT's position. (Bug#7616)
248 (find_row_edges): If ROW->start.pos gives position
249 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
250 (handle_stop, back_to_previous_visible_line_start, reseat_1):
251 Reset the from_disp_prop_p flag.
252 (SAVE_IT, RESTORE_IT): New macros.
253 (pos_visible_p, face_before_or_after_it_pos)
254 (back_to_previous_visible_line_start)
255 (move_it_in_display_line_to, move_it_in_display_line)
256 (move_it_to, move_it_vertically_backward, move_it_by_lines)
257 (try_scrolling, redisplay_window, display_line): Use them when
258 saving a temporary copy of the iterator and restoring it back.
259 (back_to_previous_visible_line_start, reseat_1)
260 (init_iterator): Empty the bidi cache "stack".
261 (move_it_in_display_line_to): If iterator ended up at
262 EOL, but we never saw any buffer positions smaller than
263 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
264 motion in bidi-reordered lines.
265 (move_it_in_display_line_to): Record prev_method and prev_pos
266 immediately before the call to set_iterator_to_next. Fixes cursor
267 motion in bidi-reordered lines with stretch glyphs and strings
268 displayed in margins. (Bug#8133) (Bug#8867)
269 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
270 TO_CHARPOS.
271 (pos_visible_p): Support positions in bidi-reordered lines. Save
272 and restore bidi cache.
273
274 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
275 (bidi_paragraph_info): Delete unused struct.
276 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
277 (bidi_cache_start): New variable.
278 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
279 to zero.
280 (bidi_cache_fetch_state, bidi_cache_search)
281 (bidi_cache_find_level_change, bidi_cache_iterator_state)
282 (bidi_cache_find, bidi_peek_at_next_level)
283 (bidi_level_of_next_char, bidi_find_other_level_edge)
284 (bidi_move_to_visually_next): Compare cache index with
285 bidi_cache_start rather than with zero.
286 (bidi_fetch_char): Accept new argument STRING; all callers
287 changed. Support iteration over a string. Support strings with
288 display properties. Support unibyte strings. Fix the type of
289 `len' according to what STRING_CHAR_AND_LENGTH expects.
290 (bidi_paragraph_init, bidi_resolve_explicit_1)
291 (bidi_resolve_explicit, bidi_resolve_weak)
292 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
293 iteration over a string.
294 (bidi_set_sor_type, bidi_resolve_explicit_1)
295 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
296 can now be zero (for strings); special values 0 and -1 were
297 changed to -1 and -2, respectively.
298 (bidi_char_at_pos): New function.
299 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
300 Call it instead of FETCH_MULTIBYTE_CHAR.
301 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
302 initialized to valid values.
303 (bidi_init_it): Don't initialize charpos and bytepos with invalid
304 values.
305 (bidi_level_of_next_char): Allow the sentinel "position" to pass
306 the test for valid cached positions. Fix the logic for looking up
307 the sentinel state in the cache. GCPRO the Lisp string we are
308 iterating.
309 (bidi_push_it, bidi_pop_it): New functions.
310 (bidi_initialize): Initialize the bidi cache start stack pointer.
311 (bidi_cache_ensure_space): New function, refactored from part of
312 bidi_cache_iterator_state. Don't assume the required size is just
313 one BIDI_CACHE_CHUNK away.
314 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
315 (bidi_count_bytes, bidi_char_at_pos): New functions.
316 (bidi_cache_search): Don't assume bidi_cache_last_idx is
317 always valid if bidi_cache_idx is valid.
318 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
319 is valid if it's going to be used.
320 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
321 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
322 (bidi_cache_find_level_change, bidi_cache_ensure_space)
323 (bidi_cache_iterator_state, bidi_cache_find)
324 (bidi_find_other_level_edge, bidi_cache_start_stack): All
325 variables related to cache indices are now EMACS_INT.
326
0bb23927
EZ
327 * dispextern.h (struct bidi_string_data): New structure.
328 (struct bidi_it): New member `string'. Make flag members be 1-bit
329 fields, and put them last in the struct.
330 (compute_display_string_pos, compute_display_string_end): Update
331 prototypes.
332 (bidi_push_it, bidi_pop_it): Add prototypes.
333 (struct iterator_stack_entry): New members bidi_p,
334 paragraph_embedding, and from_disp_prop_p.
335 (struct it): Member bidi_p is now a bit field 1 bit wide.
336 (bidi_shelve_cache, bidi_unshelve_cache): Declare
337 prototypes.
338
339 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
340 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
341 and vector-like objects.
342
343 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
344 cache around display iteration.
345
346 * window.c (Fwindow_end, window_scroll_pixel_based)
347 (displayed_window_lines, Frecenter): Save and restore the bidi
348 cache around display iteration.
349
3bbd2265
LMI
3502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
351
352 * editfns.c (Fdelete_region): Clarify the use of the named
353 parameters (bug#6788).
354
adc47434
MR
3552011-07-14 Martin Rudalics <rudalics@gmx.at>
356
357 * indent.c (Fvertical_motion): Set and restore w->pointm when
358 saving and restoring the window's buffer (Bug#9006).
359
837c31f8
LMI
3602011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
361
362 * editfns.c (Fstring_to_char): Clarify just what is returned
363 (bug#6576). Text by Eli Zaretskii.
364
ac389d0c
JB
3652011-07-13 Juanma Barranquero <lekktu@gmail.com>
366
367 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
368
0be0ce47
EZ
3692011-07-13 Eli Zaretskii <eliz@gnu.org>
370
371 * buffer.c (mmap_find): Fix a typo.
372
cd18e7e3
JB
3732011-07-13 Johan Bockgård <bojohan@gnu.org>
374
375 Fix execution of x selection hooks.
376 * xselect.c (Qx_lost_selection_functions)
377 (Qx_sent_selection_functions): New vars.
378 (syms_of_xselect): DEFSYM them.
379 (x_handle_selection_request): Pass Qx_sent_selection_functions
380 rather than Vx_sent_selection_functions to Frun_hook_with_args.
381 (x_handle_selection_clear,x_clear_frame_selections):
382 Pass Qx_lost_selection_functions rather than
383 Vx_lost_selection_functions to Frun_hook_with_args.
384
47ea7f44
PE
3852011-07-13 Paul Eggert <eggert@cs.ucla.edu>
386
ac389d0c 387 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
388 The old code sometimes used this field without initializing it.
389
47ea7f44
PE
390 * alloc.c (gc_sweep): Don't read past end of array.
391 In theory, the old code could also have corrupted Emacs internals,
392 though it'd be very unlikely.
393
bc985c87
AS
3942011-07-12 Andreas Schwab <schwab@linux-m68k.org>
395
396 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 397 argument. (Bug#4026)
bc985c87 398
0cf34688
LMI
3992011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
400
b3dadd76
LMI
401 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
402 key" (bug#4257).
403
0cf34688
LMI
404 * window.c (Fset_window_start): Doc fix (bug#4199).
405 (Fset_window_hscroll): Ditto.
406
270768cd
PE
4072011-07-12 Paul Eggert <eggert@cs.ucla.edu>
408
077e3dda 409 Fix minor new problems caught by GCC 4.6.1.
270768cd 410 * term.c (init_tty): Remove unused local.
490011a6 411 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 412 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 413 not used otherwise.
270768cd 414
b1f58454
CY
4152011-07-12 Chong Yidong <cyd@stupidchicken.com>
416
417 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
418
22b9578d
LMI
4192011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
420
6e70ab07
LMI
421 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
422 are the mini-buffer and the echo area (bug#3320).
423
22b9578d
LMI
424 * term.c (init_tty): Remove support for supdup, c10 and perq
425 terminals, which are no longer supported (bug#1482).
426
8974cc9f
JB
4272011-07-10 Johan Bockgård <bojohan@gnu.org>
428
429 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
430
a560d974
JD
4312011-07-10 Jan Djärv <jan.h.d@swipnet.se>
432
433 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
434 for non-popups (Bug#3642).
435
1dae0f0a
AS
4362011-07-10 Andreas Schwab <schwab@linux-m68k.org>
437
268c2c36 438 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 439 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
440 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
441 * cm.c (losecursor): Likewise.
1dae0f0a
AS
442 * data.c (fmod): Likewise.
443 * dispnew.c (swap_glyphs_in_rows): Likewise.
444 * emacs.c (memory_warning_signal): Likewise.
445 * floatfns.c (float_error): Likewise.
446 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
447 (otf_open, font_otf_capability, generate_otf_features)
448 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
449 Likewise.
450 * image.c (pbm_read_file): Likewise.
451 * indent.c (string_display_width): Likewise.
452 * intervals.c (check_for_interval, search_for_interval)
453 (inc_interval_count, count_intervals, root_interval)
454 (adjust_intervals_for_insertion, make_new_interval): Likewise.
455 * lread.c (defalias): Likewise.
268c2c36 456 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
457 * regex.c (set_image_of_range_1, set_image_of_range)
458 (regex_grow_registers): Likewise.
459 * sysdep.c (strerror): Likewise.
460 * termcap.c (valid_filename_p, tprint, main): Likewise.
461 * tparam.c (main): Likewise.
462 * unexhp9k800.c (run_time_remap, save_data_space)
463 (update_file_ptrs, read_header, write_header, calculate_checksum)
464 (copy_file, copy_rest, display_header): Likewise.
465 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
466 Likewise.
467 * xdisp.c (check_it): Likewise.
468 * xfaces.c (register_color, unregister_color, unregister_colors):
469 Likewise.
470 * xfns.c (print_fontset_result): Likewise.
471 * xrdb.c (member, fatal, main): Likewise.
472
99033785
PE
4732011-07-10 Paul Eggert <eggert@cs.ucla.edu>
474
475 Fix minor problems found by static checking (Bug#9031).
476 * chartab.c (char_table_set_range, map_sub_char_table):
477 Remove unused locals.
478 (uniprop_table): Now static.
479 * composite.c (_work_char): Remove unused static var.
480
9cb2ac56
JB
4812011-07-09 Juanma Barranquero <lekktu@gmail.com>
482
483 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
484
f25661f0
JD
4852011-07-09 Jan Djärv <jan.h.d@swipnet.se>
486
487 * gtkutil.c (qttip_cb): Remove code without function.
488
8278c4fe
EZ
4892011-07-09 Eli Zaretskii <eliz@gnu.org>
490
491 * w32.c (pthread_sigmask): New stub.
492
1692ae2d 4932011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 494
8a6ebd58 495 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
496 sigprocmask is portable only for single-threaded applications, and
497 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
498 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
499 (LIBES): Use it.
500 * callproc.c (Fcall_process):
501 * process.c (create_process):
502 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
503 Use pthread_sigmask, not sigprocmask.
123403e4 504
1b854618
JD
5052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
506
507 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
508 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
509 wrong (Bug#8591).
510
3fe4b549
JD
5112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
512
0ce7e563
JD
513 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
514 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
515 (xg_hide_tooltip): Fix comment.
516
3fe4b549
JD
517 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
518 in registerServicesMenuSendTypes.
519 (validRequestorForSendType): Don't check ns_return_types.
520
521 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
522 ns_return_type.
523
5df75e47
JR
5242011-07-08 Jason Rumney <jasonr@gnu.org>
525
526 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
527 frame struct members of non-existent frames (Bug#6284).
528
699c10bd
JD
5292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
530
4393663b
JD
531 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
532 variable firstTime not needed on OSX >= 10.6.
533 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
534 >= 10.5. Use setKnobProportion, setDoubleValue.
535
536 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
537 (MAC_OS_X_VERSION_10_5): Define if not defined.
538 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
539 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
540 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
541
542 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
543 cString and lossyCString on OSX >= 10.4
544
545 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
546 sizeToFit on OSX >= 10.2.
547
548 * nsimage.m (allocInitFromFile): Don't use deprecated method
549 bestRepresentationForDevice on OSX >= 10.6.
550
551 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
552 to avoid warning.
553
554 * emacs.c: Declare unexec_init_emacs_zone.
555
a63e0781
JD
556 * nsgui.h: Fix compiler warning about gnulib redefining verify.
557
699c10bd
JD
558 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
559
560 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
561 on svcsMenu (Bug#8842).
562
563 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
564 ns_return_types.
565 (Fns_list_services): Just return Qnil on 10.6, code not working there.
566
567 * nsterm.m (QUTF8_STRING): Declare.
568 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
569 (validRequestorForSendType): Return type is (id).
570 Change indexOfObjectIdenticalTo to indexOfObject.
571 Check if we have local selection before returning self (Bug#8842).
572 (writeSelectionToPasteboard): Put local selection into paste board
573 if we have a local selection (Bug#8842).
574 (syms_of_nsterm): DEFSYM QUTF8_STRING.
575
576 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
577 (ns_get_local_selection): Declare.
578
54e10184
LMI
5792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
580
9888ff71
LMI
581 * keymap.c (describe_map_tree): Don't insert a double newline at
582 the end of the buffer (bug#1169) and return whether we inserted
583 something.
584
54e10184
LMI
585 * callint.c (Fcall_interactively): Change "reading args" to
586 "providing args" to try to clarify what it does (bug#1010).
587
15fa4783
KH
5882011-07-07 Kenichi Handa <handa@m17n.org>
589
590 * composite.c (composition_compute_stop_pos): Ignore a static
591 composition starting before CHARPOS (Bug#8915).
592
593 * xdisp.c (handle_composition_prop): Likewise.
594
a8815b00
EZ
5952011-07-07 Eli Zaretskii <eliz@gnu.org>
596
597 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
598 (Bug#9015)
599
ef7b981d 6002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
601
602 * character.h (unicode_category_t): New enum type.
603
604 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
605 (Qchar_code_property_table): New variable.
606 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
607 (UNIPROP_COMPRESSED_FORM_P): New macros.
608 (char_table_ascii): Uncompress the compressed values.
609 (sub_char_table_ref): New arg is_uniprop. Callers changed.
610 Uncompress the compressed values.
ac389d0c 611 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
612 (char_table_ref_and_range): Uncompress the compressed values.
613 (sub_char_table_set): New arg is_uniprop. Callers changed.
614 Uncompress the compressed values.
615 (sub_char_table_set_range): Args changed. Callers changed.
616 (char_table_set_range): Adjuted for the above change.
617 (map_sub_char_table): Delete args default_val and parent. Add arg
618 top. Give decoded values to a Lisp function.
619 (map_char_table): Adjusted for the above change. Give decoded
620 values to a Lisp function. Gcpro more variables.
621 (uniprop_table_uncompress)
622 (uniprop_decode_value_run_length): New functions.
623 (uniprop_decoder, uniprop_decoder_count): New variables.
624 (uniprop_get_decoder, uniprop_encode_value_character)
625 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
626 New functions.
627 (uniprop_encoder, uniprop_encoder_count): New variables.
628 (uniprop_get_encoder, uniprop_table)
629 (Funicode_property_table_internal, Fget_unicode_property_internal)
630 (Fput_unicode_property_internal): New functions.
631 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
632 Sunicode_property_table_internal, Sget_unicode_property_internal,
633 and Sput_unicode_property_internal. Defvar_lisp
634 char-code-property-alist.
635
636 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
637 Vunicode_category_table.
638
639 * font.c (font_range): Adjusted for the change of
640 Vunicode_category_table.
641
76b397fb
DN
6422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
643
644 * m/iris4d.h: Remove file, move contents ...
645 * s/irix6-5.h: ... here.
646
22b4128e
PE
6472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
648
649 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
650 * alloc.c (mark_buffer):
651 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
652 (clone_per_buffer_values): Don't assume that
22b4128e
PE
653 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
654 This isn't true in general, and it's particularly not true
655 if Emacs is configured with --with-wide-int.
656 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
657 New macros, used in the buffer.c change.
658
869795d6
JD
6592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
660
661 * xsettings.c: Use both GConf and GSettings if both are available.
662 (store_config_changed_event): Add comment.
663 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
664 (store_tool_bar_style_changed): New functions.
665 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
666 (struct xsettings): Move font inside HAVE_XFT.
667 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
668 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
669 Move inside HAVE_XFT.
670 (something_changed_gsettingsCB): Renamed from something_changedCB.
671 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
672 also.
673 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
674 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
675 (something_changed_gconfCB): Renamed from something_changedCB.
676 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
677 (parse_settings): Move check for font inside HAVE_XFT.
678 (read_settings, apply_xft_settings): Add comment.
679 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
680 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
681 call store_font_name_changed.
682 (xft_settings_event): Add comment.
683 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
684 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
685 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
686 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
687 (xsettings_initialize): Call init_gsettings last.
688 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
689 comment.
690
d8ed26bd
PE
6912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
692
693 Random fixes. E.g., (random) never returned negative values.
694 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
695 subseconds part to the entropy, as that's a bit more random.
696 Prefer signed to unsigned, since the signedness doesn't matter and
697 in general we prefer signed. When given a limit, use a
698 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
699 latter isn't right if USE_2_TAGS_FOR_INTS.
700 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
701 not 0..VALMASK. Don't discard "excess" bits that random () returns.
702
cabf1cac
SM
7032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
704
705 * textprop.c (text_property_stickiness):
706 Obey Vtext_property_default_nonsticky.
707 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
708 * w32fns.c (syms_of_w32fns):
709 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
710
6e9b2be9
PE
7112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
712
713 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
714 This is more efficient than Ffile_directory_p and avoids a minor race.
715
90186c68
LMI
7162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
717
7c301272
LMI
718 * buffer.c (Foverlay_put): Say what the return value is
719 (bug#7835).
720
c4f2d8d4
LMI
721 * fileio.c (barf_or_query_if_file_exists): Check first if the file
722 is a directory before asking whether to use the file name
723 (bug#7564).
ad637907
LMI
724 (barf_or_query_if_file_exists): Make the "File is a directory"
725 error be more correct.
c4f2d8d4 726
90186c68
LMI
727 * fns.c (Frequire): Remove the mention of the .gz files, since
728 that's installation-specific, but keep the mention of
729 `get-load-suffixes'.
730
da64016e
PE
7312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
732
733 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
734 Report string overflow if the output is too long.
735
7d47b580
JB
7362011-07-04 Juanma Barranquero <lekktu@gmail.com>
737
a555cb87
JB
738 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
739 (syms_of_gnutls): Remove duplicate DEFSYM for
740 Qgnutls_bootprop_verify_hostname_error, an error for
741 Qgnutls_bootprop_verify_error (which is no longer used).
742
7d47b580
JB
743 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
744 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
745 Also (re)move comments that are misplaced or no longer relevant.
746
1e49bfab
LMI
7472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
748
749 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
750
1485f4c0
CY
7512011-07-03 Chong Yidong <cyd@stupidchicken.com>
752
753 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
754 and background color parameters if they have been changed.
755
a9ab721e
LMI
7562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
757
758 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
759
cf7cff57
PE
7602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
761
2e13213d
PE
762 * xsettings.c (SYSTEM_FONT): Define only when used.
763 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
764
cf7cff57
PE
765 * keymap.c (access_keymap_1): Now static.
766
7a8e04f7
CY
7672011-07-02 Chong Yidong <cyd@stupidchicken.com>
768
769 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
770 leave any prefix arg for the up event (Bug#1586).
771
61352f62
LMI
7722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
773
69bb1ef7
LMI
774 * lread.c (syms_of_lread): Mention single symbols defined by
775 `defvar' or `defconst' (bug#7154).
776
61352f62 777 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 778 (Frequire): Mention get-load-suffixes.
61352f62 779
28545e04
MR
7802011-07-02 Martin Rudalics <rudalics@gmx.at>
781
782 * window.h (window): Remove clone_number slot.
783 * window.c (Fwindow_clone_number, Fset_window_clone_number):
784 Remove.
785 (make_parent_window, make_window, saved_window)
786 (Fset_window_configuration, save_window_save): Don't deal with
787 clone numbers.
788 * buffer.c (Qclone_number): Remove declaration.
789 (sort_overlays, overlay_strings): Don't deal with clone numbers.
790
3349e122
SM
7912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 Add multiple inheritance to keymaps.
794 * keymap.c (Fmake_composed_keymap): New function.
795 (Fset_keymap_parent): Simplify.
796 (fix_submap_inheritance): Remove.
797 (access_keymap_1): New function extracted from access_keymap to handle
798 embedded parents and handle lists of maps.
799 (access_keymap): Use it.
800 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
801 (Fcopy_keymap): Handle embedded parents.
802 (Fcommand_remapping, define_as_prefix): Simplify.
803 (Fkey_binding): Simplify.
804 (syms_of_keymap): Move minibuffer-local-completion-map,
805 minibuffer-local-filename-completion-map,
806 minibuffer-local-must-match-map, and
807 minibuffer-local-filename-must-match-map to Elisp.
808 (syms_of_keymap): Defsubr make-composed-keymap.
809 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
810 (parse_menu_item): Trivial simplification.
811
3279eb87
GM
8122011-07-01 Glenn Morris <rgm@gnu.org>
813
814 * Makefile.in (SETTINGS_LIBS): Fix typo.
815
4550efdf
KI
8162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
817
818 * coding.c (Fencode_coding_string): Record the last coding system
819 used, as the function doc string says (bug#8738).
820
0949d2b6
JD
8212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
822
823 * xsettings.c (store_monospaced_changed): Take new font as arg and
824 check for change against current_mono_font.
825 (EMACS_TYPE_SETTINGS): Remove this and related defines.
826 (emacs_settings_constructor, emacs_settings_get_property)
827 (emacs_settings_set_property, emacs_settings_class_init)
828 (emacs_settings_init, gsettings_obj): Remove.
829 (something_changedCB): New function for HAVE_GSETTINGS.
830 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
831 with value as argument.
832 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
833 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 834 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
835 "changed".
836
837 * xgselect.c: Add defined (HAVE_GSETTINGS).
838 (xgselect_initialize): Ditto.
839
840 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
841 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
842 xg_select.
843
bbc6b304
PE
8442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
845
846 * eval.c (struct backtrace): Simplify and port the data structure.
847 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
848 signed bit field, as this assumption is not portable and it makes
849 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
850 "char debug_on_exit : 1" as this is not portable either; instead,
851 use the portable "unsigned int debug_on_exit : 1". Remove unused
852 member evalargs. Remove obsolete comments about cc bombing out.
853
9851bfc5
JD
8542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
855
51bb811f 856 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
857 Let HAVE_GSETTINGS override HAVE_GCONF.
858 (store_monospaced_changed): New function.
859 (EMACS_SETTINGS): A new type derived from GObject to handle
860 GSettings notifications.
861 (emacs_settings_constructor, emacs_settings_get_property)
862 (emacs_settings_set_property, emacs_settings_class_init):
863 New functions.
864 (gsettings_client, gsettings_obj): New variables.
865 (GSETTINGS_SCHEMA): New define.
866 (something_changedCB): Call store_monospaced_changed.
867 (init_gsettings): New function.
868 (xsettings_initialize): Call init_gsettings.
869 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
870 to NULL.
871
872 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
873 GCONF_CFLAGS/LIBS.
874
5386012d
MR
8752011-06-29 Martin Rudalics <rudalics@gmx.at>
876
877 * window.c (resize_root_window, grow_mini_window)
878 (shrink_mini_window): Rename Qresize_root_window to
879 Qwindow_resize_root_window and Qresize_root_window_vertically to
880 Qwindow_resize_root_window_vertically.
881
f13e0b08
PE
8822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
883
884 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
885
94515237
JB
8862011-06-27 Juanma Barranquero <lekktu@gmail.com>
887
888 * makefile.w32-in: Redesign dependencies so they reflect more
889 clearly which files are directly included by each source file,
890 and not through other includes.
891
e43b6e43
MR
8922011-06-27 Martin Rudalics <rudalics@gmx.at>
893
894 * buffer.c (Qclone_number): Declare static and DEFSYM it.
895 (sort_overlays, overlay_strings): When an overlay's clone number
896 matches the window's clone number process the overlay even if
897 the overlay's window property doesn't match the current window.
898
d68443dc
MR
899 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
900 (Fwindow_hchild): Rename to Fwindow_left_child.
901 (Fwindow_next): Rename to Fwindow_next_sibling.
902 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
903 (resize_window_check): Rename to window_resize_check.
904 (resize_window_apply): Rename to window_resize_apply.
905 (Fresize_window_apply): Rename to Fwindow_resize_apply.
906 (Fdelete_other_windows_internal, resize_frame_windows)
907 (Fsplit_window_internal, Fdelete_window_internal)
908 (grow_mini_window, shrink_mini_window)
909 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 910
c7e73be5
JD
9112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
912
913 * emacsgtkfixed.h: State that this is only used with Gtk+3.
914 (emacs_fixed_set_min_size): Remove.
915 (emacs_fixed_new): Take frame as argument.
916
917 * emacsgtkfixed.c: State that this is only used with Gtk+3.
918 (_EmacsFixedPrivate): Remove minwidth/height.
919 Add struct frame *f.
920 (emacs_fixed_init): Initialize priv->f.
921 (get_parent_class, emacs_fixed_set_min_size): Remove.
922 (emacs_fixed_new): Set priv->f to argument.
923 (emacs_fixed_get_preferred_width)
924 (emacs_fixed_get_preferred_height): Use min_width/height from
925 frames size_hint to set minimum and natural (Bug#8919).
926 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
927 and use min_width/height from frames size_hint to set
928 min_width/height (Bug#8919).
929
930 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
931 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
932 Fix indentation.
c7e73be5 933
cf99dcf8
EZ
9342011-06-26 Eli Zaretskii <eliz@gnu.org>
935
936 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
937 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
938 called at ZV.
939
029529ac
CY
9402011-06-26 Chong Yidong <cyd@stupidchicken.com>
941
942 * process.c (wait_reading_process_output): Bypass select if
943 waiting for a cell while ignoring keyboard input, and input is
944 pending. Suggested by Jan Djärv (Bug#8869).
945
7a7ef429
PE
9462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
947
948 Use gnulib's dup2 module instead of rolling our own.
949 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
950
11fdef7d 9512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
952
953 * dispnew.c (scrolling_window): Before scrolling, turn off a
954 mouse-highlight in the window being scrolled.
955
cd3520a4
JB
9562011-06-24 Juanma Barranquero <lekktu@gmail.com>
957
958 Move DEFSYM to lisp.h and use everywhere.
959
960 * character.h (DEFSYM): Move declaration...
961 * lisp.h (DEFSYM): ...here.
962
963 * gnutls.c:
964 * minibuf.c:
965 * w32menu.c:
966 * w32proc.c:
967 * w32select.c: Don't include character.h.
968
969 * alloc.c (syms_of_alloc):
970 * buffer.c (syms_of_buffer):
971 * bytecode.c (syms_of_bytecode):
972 * callint.c (syms_of_callint):
973 * casefiddle.c (syms_of_casefiddle):
974 * casetab.c (init_casetab_once):
975 * category.c (init_category_once, syms_of_category):
976 * ccl.c (syms_of_ccl):
977 * cmds.c (syms_of_cmds):
978 * composite.c (syms_of_composite):
979 * dbusbind.c (syms_of_dbusbind):
980 * dired.c (syms_of_dired):
981 * dispnew.c (syms_of_display):
982 * doc.c (syms_of_doc):
983 * editfns.c (syms_of_editfns):
984 * emacs.c (syms_of_emacs):
985 * eval.c (syms_of_eval):
986 * fileio.c (syms_of_fileio):
987 * fns.c (syms_of_fns):
988 * frame.c (syms_of_frame):
989 * fringe.c (syms_of_fringe):
990 * insdel.c (syms_of_insdel):
991 * keymap.c (syms_of_keymap):
992 * lread.c (init_obarray, syms_of_lread):
993 * macros.c (syms_of_macros):
994 * msdos.c (syms_of_msdos):
995 * print.c (syms_of_print):
996 * process.c (syms_of_process):
997 * search.c (syms_of_search):
998 * sound.c (syms_of_sound):
999 * syntax.c (init_syntax_once, syms_of_syntax):
1000 * terminal.c (syms_of_terminal):
1001 * textprop.c (syms_of_textprop):
1002 * undo.c (syms_of_undo):
1003 * w32.c (globals_of_w32):
1004 * window.c (syms_of_window):
1005 * xdisp.c (syms_of_xdisp):
1006 * xfaces.c (syms_of_xfaces):
1007 * xfns.c (syms_of_xfns):
1008 * xmenu.c (syms_of_xmenu):
1009 * xsettings.c (syms_of_xsettings):
1010 * xterm.c (syms_of_xterm): Use DEFSYM.
1011
4228cf16
TZ
10122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1013
cd3520a4 1014 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1015
7fcccf1e
PE
10162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1017
7efb4e0e
PE
1018 Integer and buffer overflow fixes (Bug#8873).
1019
ff5844ad
PE
1020 * print.c (printchar, strout): Check for string overflow.
1021 (PRINTPREPARE, printchar, strout):
1022 Don't set size unless allocation succeeds.
1023
90532f02
PE
1024 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1025 for sizes. Check for string overflow more accurately.
1026 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1027
6d84508d
PE
1028 * macros.c: Integer and buffer overflow fixes.
1029 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1030 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1031 Use ptrdiff_t, not int, for sizes.
1032 Don't increment bufsize until after realloc succeeds.
1033 Check for size-calculation overflow.
1034 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1035
437b2cb4
PE
1036 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1037
8b9ac8b4
PE
1038 * lread.c: Integer overflow fixes.
1039 (read_integer): Radix is now EMACS_INT, not int,
1040 to improve quality of diagnostics for out-of-range radices.
1041 Calculate buffer size correctly for out-of-range radices.
1042 (read1): Check for integer overflow in radices, and in
1043 read-circle numbers.
82cb60d3
PE
1044 (read_escape): Avoid int overflow.
1045 (Fload, openp, read_buffer_size, read1)
1046 (substitute_object_recurse, read_vector, read_list, map_obarray):
1047 Use ptrdiff_t, not int, for sizes.
1048 (read1): Use EMACS_INT, not int, for sizes.
20270765 1049 Check for size overflow.
8b9ac8b4 1050
7fcccf1e
PE
1051 * image.c (cache_image): Check for size arithmetic overflow.
1052
bfbbd7e7
PE
1053 * lread.c: Integer overflow issues.
1054 (saved_doc_string_size, saved_doc_string_length)
1055 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1056 Now ptrdiff_t, not int.
1057 (read1): Don't assume doc string length fits in int. Check for
1058 out-of-range doc string lengths.
1059 (read_list): Don't assume file position fits in int.
39019e54 1060 (read_escape): Check for hex character overflow.
bfbbd7e7 1061
4e323265
LL
10622011-06-22 Leo Liu <sdl.web@gmail.com>
1063
1064 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1065 Move to minibuffer.el.
1066
85fece3e
PE
10672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1068
20b84ce9 1069 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1070 The following patches are for when GLYPH_DEBUG && !XASSERT.
1071 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1072 * dispnew.c (flush_stdout):
1073 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1074 Mark as externally visible.
1075 * dispnew.c (check_window_matrix_pointers): Now static.
1076 * dispnew.c (window_to_frame_vpos):
1077 * xfns.c (unwind_create_frame):
1078 * xterm.c (x_check_font): Remove unused local.
1079 * scroll.c (CHECK_BOUNDS):
1080 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1081 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1082 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1083 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1084 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1085 Now static.
1086 (debug_method_add): Use va_list and vsprintf rather than relying
1087 on undefined behavior with wrong number of arguments.
1088 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1089 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1090 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1091 since we're not interested in debugging glyphs with old libraries.
1092 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1093 GCC 4.6.0's static checking.
1094
0766b489
PE
10952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1096
31fd4b32
PE
1097 Integer overflow and signedness fixes (Bug#8873).
1098 A few related buffer overrun fixes, too.
1099
b79e8648
PE
1100 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1101
0766b489
PE
1102 * dispextern.h (struct face.stipple):
1103 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1104 (x_bitmap_mask, x_allocate_bitmap_record)
1105 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1106 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1107 (x_create_bitmap_from_xpm_data):
1108 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1109 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1110 (.bitmaps_last):
1111 * xfaces.c (load_pixmap):
1112 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1113 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1114 (.bitmaps_last, struct x_output.icon_bitmap):
1115 Use ptrdiff_t, not int, for bitmap indexes.
1116 (x_allocate_bitmap_record): Check for size overflow.
1117 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1118
b081724f
PE
1119 Use ptrdiff_t, not int, for overlay counts.
1120 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1121 * editfns.c (overlays_around, get_pos_property):
1122 * textprop.c (get_char_property_and_overlay):
1123 * xdisp.c (next_overlay_change, note_mouse_highlight):
1124 * xfaces.c (face_at_buffer_position):
21514da7
PE
1125 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1126 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1127 (Fnext_overlay_change, Fprevious_overlay_change)
1128 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1129 Use ptrdiff_t, not int, for sizes.
21514da7 1130 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1131
3de73e5e
PE
1132 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1133
2606c57b
PE
1134 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1135 (x_session_initialize): Do not assume string length fits in int.
1136
aaafe47a
PE
1137 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1138 This is unlikely, but can occur if DPI is outlandish.
1139
2674ddc8 1140 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1141 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1142
28154962
PE
1143 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1144 * xrdb.c (magic_file_p, search_magic_path):
1145 Omit last arg SUFFIX; it was always 0. All callers changed.
1146 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1147
7de51af5
PE
1148 * xfont.c (xfont_match): Avoid need for strlen.
1149
25ed6cc3
PE
1150 * xfns.c: Don't assume strlen fits in int.
1151 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1152
4eab31dd
PE
1153 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1154 not unsigned long, as we prefer signed integers. All callers changed.
1155 Detect integer overflow in repeat count.
1156 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1157 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1158
171e2a58
PE
1159 * termcap.c: Don't assume sizes fit in int and never overflow.
1160 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1161 (gobble_line): Check for size-calculation overflow.
1162
ad39faca 1163 * minibuf.c (Fread_buffer):
6e5bb2dc 1164 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1165 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1166 Don't assume string length fits in int.
1167
52c61c22 1168 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1169 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1170
b5b8c9e5
PE
1171 * font.c: Don't assume string length fits in int.
1172 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1173 Use ptrdiff_t, not int.
ccd6111c
PE
1174 (font_intern_prop): Don't assume string length fits in int.
1175 Don't assume integer property fits in fixnum.
1176 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1177
882f0d81 1178 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1179 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1180 Reformulate so as not to need the command string.
1181 Invoke gzip -cd rather than gunzip, as it's more portable.
1182 (lock_info_type, lock_file_1, lock_file):
1183 Don't assume pid_t and time_t fit in unsigned long.
1184 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1185 (current_lock_owner): Prefer signed type for sizes.
1186 Use memcpy, not strncpy, where memcpy is what is really wanted.
1187 Don't assume (via atoi) that time_t and pid_t fit in int.
1188 Check for time_t and/or pid_t out of range, e.g., via a network share.
1189 Don't alloca where an auto var works fine.
1190
93f4cf88
PE
1191 * fileio.c: Fix some integer overflow issues.
1192 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1193 Don't assume string length fits in int.
1194 (directory_file_name): Don't assume string length fits in long.
1195 (make_temp_name): Don't assume pid fits in int, or that its print
1196 length is less than 20.
1197
f3e92b69
PE
1198 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1199
1bfdaf10
PE
1200 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1201
35016e9a
PE
1202 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1203
3d1e65a1
PE
1204 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1205 We prefer signed integers, even for size calculations.
1206
0b963a93
PE
1207 * emacs.c: Don't assume string length fits in 'int'.
1208 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1209 (main): Don't invoke strlen when not needed.
1210
573f4b54
PE
1211 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1212 (XD_DEBUG_MESSAGE): Don't waste a byte.
1213
989f33ba
PE
1214 * callproc.c (getenv_internal_1, getenv_internal)
1215 (Fgetenv_internal):
965d34eb
PE
1216 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1217
e4d29b33
PE
1218 * lread.c (invalid_syntax): Omit length argument.
1219 All uses changed. This doesn't fix a bug, but it simplifies the
1220 code away from its former Hollerith-constant appearance, and it's
1221 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1222 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1223
eb49b136
PE
1224 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1225 This didn't break anything, but it didn't help either.
1226 It's confusing to put a bogus integer in a place where the actual
1227 value does not matter.
9f62aeb1 1228 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1229 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1230
15375a22
PE
1231 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1232 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1233 implementation.
b61cc01c
PE
1234 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1235 We prefer signed types, and the value cannot exceed the EMACS_INT
1236 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1237 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1238 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1239 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1240
53b2623d
PE
1241 * indent.c (sane_tab_width): New function.
1242 (current_column, scan_for_column, Findent_to, position_indentation)
1243 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1244 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1245
51cab52b 1246 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1247
f2ed8a70
PE
1248 * lisp.h (lint_assume): New macro.
1249 * composite.c (composition_gstring_put_cache):
1250 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1251
abe80cc6
PE
1252 * editfns.c, insdel.c:
1253 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1254
b02c740e
PE
1255 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1256
ebc96716
PE
1257 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1258
b4e50fa0 1259 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1260 Use much-faster test for byte-length change.
311d5d7c 1261 Don't assume string byte-length fits in 'int'.
a4cf38e4 1262 Check that character arg fits in 'int'.
85461888 1263 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1264
c0c1ee9f
PE
1265 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1266
a498d7f4
PE
1267 * fns.c (concat): Catch string overflow earlier.
1268 Do not rely on integer wraparound.
1269
51cab52b
PE
1270 * dispextern.h (struct it.overlay_strings_charpos)
1271 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1272 * xdisp.c (forward_to_next_line_start)
1273 (back_to_previous_visible_line_start)
1274 (reseat_at_next_visible_line_start, next_element_from_buffer):
1275 Don't arbitrarily truncate the value of 'selective' to int.
1276
76031fad
PE
1277 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1278
5eb55db9
PE
1279 * composite.c: Don't truncate sizes to 'int'.
1280 (composition_gstring_p, composition_reseat_it)
1281 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1282 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1283 not EMACS_UINT, for indexes.
5eb55db9 1284
0703a717
PE
1285 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1286
d6202519
PE
1287 * buffer.c: Include <verify.h>.
1288 (struct sortvec.priority, struct sortstr.priority):
8961a454 1289 Now EMACS_INT, not int.
c20998a7 1290 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1291 (struct sortstr.size, record_overlay_string)
1292 (struct sortstrlist.size, struct sortlist.used):
1293 Don't truncate size to int.
1294 (record_overlay_string): Check for size-calculation overflow.
d6202519 1295 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1296
d5a19415
JM
12972011-06-22 Jim Meyering <meyering@redhat.com>
1298
029529ac 1299 Don't leak an XBM-image-sized buffer
d5a19415
JM
1300 * image.c (xbm_load): Free the image buffer after using it.
1301
a9041e6c
PE
13022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 Port to Sun C.
1305 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1306 that Sun C diagnosed.
1307 * fns.c (secure_hash): Fix pointer signedness issue.
1308 * intervals.c (static_offset_intervals): New function.
1309 (offset_intervals): Use it.
1310
7f3f739f
LL
13112011-06-21 Leo Liu <sdl.web@gmail.com>
1312
1313 * deps.mk (fns.o):
1314 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1315 sha512.h.
1316
1317 * fns.c (secure_hash): Rename from crypto_hash_function and change
1318 the first arg to accept symbols.
5b66d427 1319 (Fsecure_hash): New primitive.
7f3f739f
LL
1320 (syms_of_fns): New symbols.
1321
76147d94
DD
13222011-06-20 Deniz Dogan <deniz@dogan.se>
1323
1324 * process.c (Fset_process_buffer): Clarify return value in
1325 docstring.
1326
7d7d0045
CY
13272011-06-18 Chong Yidong <cyd@stupidchicken.com>
1328
1329 * dispnew.c (add_window_display_history): Use BVAR.
1330
1331 * xdisp.c (debug_method_add): Use BVAR.
1332 (check_window_end, dump_glyph_matrix, dump_glyph)
1333 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1334
1335 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1336 Likewise.
1337
1338 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1339 check till after the cache is created in init_frame_faces.
1340
ff2bc410
SM
13412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1342
1343 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1344
28177add
PE
13452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1346
dd3482fe
PE
1347 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1348 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1349 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1350
393d71f3 1351 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1352 * fileio.c (Finsert_file_contents):
1353 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1354 Remove the old (too-loose) buffer overflow checks.
1355 They weren't needed, since make_gap checks for buffer overflow.
1356 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1357 The old code merely checked for Emacs fixnum overflow, and relied
1358 on undefined (wraparound) behavior. The new code avoids undefined
1359 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1360
2e6813b0 1361 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1362 Tune. Don't use wider integers than needed. Don't use alloca.
1363 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1364
599a9e4f
PE
1365 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1366
99561444
PE
1367 * insdel.c, lisp.h (buffer_overflow): New function.
1368 (insert_from_buffer_1, replace_range, replace_range_2):
1369 * insdel.c (make_gap_larger):
1370 * editfns.c (Finsert_char):
1371 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1372
28177add
PE
1373 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1374
e69dafad
PE
13752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1376
a7af7fde 1377 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1378
b1c46f02
PE
1379 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1380 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1381
e69dafad
PE
1382 * fileio.c: Don't assume EMACS_INT fits in off_t.
1383 (emacs_lseek): New static function.
1384 (Finsert_file_contents, Fwrite_region): Use it.
1385 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1386
566684ea
PE
1387 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1388
e6966cd6
PE
1389 * fns.c: Don't overflow int when computing a list length.
1390 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1391 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1392 truncation on 64-bit hosts. Check for QUIT every
1393 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1394 faster and is responsive enough.
1395 (Flength): Report an error instead of overflowing an integer.
1396 (Fsafe_length): Return a float if the value is not representable
1397 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1398 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1399 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1400
dd0b0efb
PE
1401 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1402 (header_size, word_size): New constants.
1403 (allocate_vectorlike): Don't check size overflow here.
1404 (allocate_vector): Check it here instead, since this is the only
1405 caller of allocate_vectorlike that could cause overflow.
1406 Check that the new vector's length is representable as a fixnum.
1407
86fe5cfe
PE
1408 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1409 The previous code was bogus. For example, next_almost_prime (32)
1410 returned 39, which is undesirable as it is a multiple of 3; and
1411 next_almost_prime (24) returned 25, which is a multiple of 5 so
1412 why was the code bothering to check for multiples of 7?
1413
80e88859
PE
1414 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1415
4a2f0ad6
PE
1416 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1417
f66c7cf8
PE
1418 Variadic C functions now count arguments with ptrdiff_t.
1419 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1420 Back then I didn't know that the Emacs coding style prefers signed int.
1421 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1422 were being counted with int, which may truncate counts on 64-bit
1423 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1424 * lisp.h (struct Lisp_Subr.function.aMANY)
1425 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1426 Arg counts are now ptrdiff_t, not size_t.
1427 All variadic functions and their callers changed accordingly.
1428 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1429 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1430 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1431 * callint.c (Fcall_interactively): Check arg count for overflow,
1432 to avoid potential buffer overrun. Use signed char, not 'int',
1433 for 'varies' array, so that we needn't bother to check its size
1434 calculation for overflow.
1435 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1436 * eval.c (apply_lambda):
1437 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1438 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1439 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1440
a1759b76
PE
1441 * callint.c (Fcall_interactively): Don't use index var as event count.
1442
d96be9fc
PE
1443 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1444 * mem-limits.h (SIZE): Remove; no longer used.
1445
a690a978 1446 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1447
578c21e6
PE
1448 Remove unnecessary casts.
1449 * xterm.c (x_term_init):
1450 * xfns.c (x_set_border_pixel):
1451 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1452 These aren't needed now that we assume ANSI C.
1453
96f53c6c
PE
1454 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1455 It's more likely to cause problems (due to unsigned overflow)
1456 than to cure them.
1457
83c77d31
PE
1458 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1459
ee2079f1
PE
1460 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1461
6da65536
PE
1462 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1463
7147c4a4
PE
1464 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1465
193e32d9
PE
1466 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1467
e5533da6
PE
1468 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1469
9910e595
PE
1470 GLYPH_CODE_FACE returns EMACS_INT, not int.
1471 * dispextern.h (merge_faces):
1472 * xfaces.c (merge_faces):
01103c44
PE
1473 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1474 Don't assume EMACS_INT fits in int.
9910e595 1475
2638320e
PE
1476 * character.h (CHAR_VALID_P): Remove unused parameter.
1477 * fontset.c, lisp.h, xdisp.c: All uses changed.
1478
045eb8d9
PE
1479 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1480
c1f134b5
PE
1481 * fns.c (concat): Minor tuning based on overflow analysis.
1482 This doesn't fix any bugs. Use int to hold character, instead
1483 of constantly refetching from Emacs object. Use XFASTINT, not
1484 XINT, for value known to be a character. Don't bother comparing
1485 a single byte to 0400, as it's always less.
1486
395fcb93 1487 * floatfns.c (Fexpt):
327eeec8
PE
1488 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1489
abbd3d23
PE
1490 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1491 for characters.
1492
684a03ef
PE
1493 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1494
0fed43f3
PE
1495 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1496 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1497 incorrectly succeed when S was a string, because 4294967386 was
1498 truncated before it was used.
1499
8fd02eb7
PE
1500 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1501 Otherwise, an out-of-range integer could cause undefined behavior
1502 on a 64-bit host.
1503
f8c86b69
PE
1504 * composite.c: Use int, not EMACS_INT, for characters.
1505 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1506 EMACS_INT, for values that are known to be in character range.
1507 This doesn't fix any bugs but is the usual style inside Emacs and
1508 may generate better code on 32-bit machines.
1509
34206dd2
PE
1510 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1511 This is for reasons similar to the recent CHAR_STRING fix.
1512 * charset.c (Fencode_char): Check that character arg is actually
1513 a character. Pass an int to ENCODE_CHAR.
1514 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1515 wider than 'int', as a compile-time check to prevent future regressions
1516 in this area.
1517
c5958d4c 1518 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1519
1520 Make sure a 64-bit char is never passed to CHAR_STRING.
1521 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1522 by silently ignoring the top 32 bits, allowing some values
1523 that were far too large to be valid characters.
1524 * character.h: Include <verify.h>.
1525 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1526 arguments are no wider than unsigned, as a compile-time check
1527 to prevent future regressions in this area.
1528 * data.c (Faset):
01103c44 1529 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1530 (Fsubst_char_in_region):
1531 * fns.c (concat):
1532 * xdisp.c (decode_mode_spec_coding):
1533 Adjust to CHAR_STRING's new requirement.
1534 * editfns.c (Finsert_char, Fsubst_char_in_region):
1535 * fns.c (concat): Check that character args are actually
1536 characters. Without this test, these functions did the wrong
1537 thing with wildly out-of-range values on 64-bit hosts.
1538
d37ca623
PE
1539 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1540 These casts should not be needed on 32-bit hosts, either.
1541 * keyboard.c (read_char):
1542 * lread.c (Fload): Remove casts to unsigned.
1543
ea204efb
PE
1544 * lisp.h (UNSIGNED_CMP): New macro.
1545 This fixes comparison bugs on 64-bit hosts.
1546 (ASCII_CHAR_P): Use it.
1547 * casefiddle.c (casify_object):
01103c44 1548 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1549 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1550 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1551 * dispextern.h (FACE_FROM_ID):
1552 * keyboard.c (read_char): Use UNSIGNED_CMP.
1553
41cb286c
PE
1554 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1555 not to EMACS_INT, to avoid GCC warning.
1556
4a1b9832
PE
1557 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1558
55daad71
PE
1559 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1560 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1561 isn't needed on 32-bit machines.
8f95c75c 1562
01103c44
PE
1563 * buffer.c (Fgenerate_new_buffer_name):
1564 Use EMACS_INT for count, not int.
0ceccced 1565 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1566
1567 * data.c (Qcompiled_function): Now static.
1568
c6f072e7
PE
1569 * window.c (window_body_lines): Now static.
1570
20ce5912
PE
1571 * image.c (gif_load): Rename local to avoid shadowing.
1572
9c4c5f81
PE
1573 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1574 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1575 * alloc.c (make_save_value): Integer argument is now of type
1576 ptrdiff_t, not int.
1577 (mark_object): Use ptrdiff_t, not int.
1578 * lisp.h (pD): New macro.
1579 * print.c (print_object): Use it.
1580
c0c5c8ae
PE
1581 * alloc.c: Use EMACS_INT, not int, to count objects.
1582 (total_conses, total_markers, total_symbols, total_vector_size)
1583 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1584 (total_free_floats, total_floats, total_free_intervals)
1585 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1586 Now EMACS_INT, not int. All uses changed.
1587 (Fgarbage_collect): Compute overall total using a double, so that
1588 integer overflow is less likely to be a problem. Check for overflow
1589 when converting back to an integer.
5a25e253
PE
1590 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1591 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1592 These were 'int' variables that could overflow on 64-bit hosts;
1593 they were never used, so remove them instead of repairing them.
211a0b2a 1594 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1595 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1596 Previously, this ceilinged at INT_MAX, but that doesn't work on
1597 64-bit machines.
e46bb31a 1598 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1599
c78baabf 1600 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1601 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1602 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1603 when a (possibly-narrower) signed value would do just as well.
1604 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1605
c9d624c6
PE
1606 * alloc.c: Catch some string size overflows that we were missing.
1607 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1608 for convenience in STRING_BYTES_MAX.
1609 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1610 The definition here is exact; the one in lisp.h was approximate.
1611 (allocate_string_data): Check for string overflow. This catches
1612 some instances we weren't catching before. Also, it catches
1613 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1614 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1615 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1616
c9d624c6
PE
1617 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1618 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1619 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1620
353032ce
PE
1621 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1622
2bccce07
PE
1623 * alloc.c (Fmake_string): Check for out-of-range init.
1624
0ac30604
SM
16252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1626
1627 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1628
c195f2de
JD
16292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1630
1631 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1632 xg_get_default_scrollbar_width.
1633
1634 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1635 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1636 (style_changed_cb): Call update_theme_scrollbar_width and call
1637 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1638 all frames (Bug#8505).
1639 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1640 Call gtk_window_set_resizable if HAVE_GTK3.
1641 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1642 and height if HAVE_GTK3 (Bug#8505).
1643 (scroll_bar_width_for_theme): New variable.
1644 (update_theme_scrollbar_width): New function.
1645 (xg_get_default_scrollbar_width): Move code to
1646 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1647 (xg_initialize): Call update_theme_scrollbar_width.
1648
1649 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1650
1651 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1652
e10ac9f1
MR
16532011-06-12 Martin Rudalics <rudalics@gmx.at>
1654
1655 * frame.c (make_frame): Call other_buffer_safely instead of
1656 other_buffer.
1657
1658 * window.c (temp_output_buffer_show): Call display_buffer with
1659 second argument Vtemp_buffer_show_specifiers and reset latter
1660 immediately after the call.
1661 (Vtemp_buffer_show_specifiers): New variable.
1662 (auto_window_vscroll_p, next_screen_context_lines)
1663 (Vscroll_preserve_screen_position): Remove leading asterisks from
1664 doc-strings.
1665
2d3c217e 16662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1667
7b7f97e8 1668 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1669 * buffer.c (Qclone_number): Remove for now, as it's unused.
1670 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1671 (record_buffer): Remove unused local.
1672 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1673 (set_frame_buffer_list): Remove; unused.
1674 * frame.h (other_visible_frames): Remove decl.
1675 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1676 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1677 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1678 if HAVE_GPM.
1679 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1680 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1681 Define only if HAVE_GPM.
1682 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1683 (update_hints_inhibit): Remove; never set. All uses removed.
1684 * widgetprv.h (emacsFrameClassRec): Remove decl.
1685 * window.c (delete_deletable_window): Now returns void, since it
1686 wasn't returning anything.
1687 (compare_window_configurations): Remove unused locals.
1688 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1689 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1690 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1691 the same widths as pointers. This follows up on the 2011-05-06 patch.
1692 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1693 * xterm.h: Likewise.
1694 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1695
1384b89e
JB
16962011-06-12 Juanma Barranquero <lekktu@gmail.com>
1697
1698 * makefile.w32-in: Update dependencies.
1699 (LISP_H): Add lib/intprops.h.
1700
1100a63c
CY
17012011-06-11 Chong Yidong <cyd@stupidchicken.com>
1702
1703 * image.c (gif_load): Add animation frame delay to the metadata.
1704 (syms_of_image): Use DEFSYM. New symbol `delay'.
1705
6198ccd0
MR
17062011-06-11 Martin Rudalics <rudalics@gmx.at>
1707
1708 * window.c (delete_deletable_window): Re-add.
1709 (Fset_window_configuration): Rewrite to handle dead buffers and
1710 consequently deletable windows.
1711 (window_tree, Fwindow_tree): Remove. Supply functionality in
1712 window.el.
1713 (compare_window_configurations): Simplify code.
1714
b6e3633c
AS
17152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1716
1ab0dee5
AS
1717 * image.c (imagemagick_load_image): Fix type mismatch.
1718 (Fimagemagick_types): Likewise.
1719
b6e3633c
AS
1720 * window.h (replace_buffer_in_windows): Declare.
1721
9397e56f
MR
17222011-06-11 Martin Rudalics <rudalics@gmx.at>
1723
1724 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1725 Qclone_number. Remove external declaration of Qdelete_window.
1726 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1727 code.
1728 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1729 Qbuffer_list_update_hook if allowed.
1730 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1731 buffer list implementation.
1732 (other_buffer_safely): New function.
1733 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1734 calls to replace_buffer_in_windows and
1735 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1736 if allowed.
1737 (record_buffer): Inhibit quitting and rewrite using quittable
1738 functions. Run Qbuffer_list_update_hook if allowed.
1739 (Frecord_buffer, Funrecord_buffer): New functions.
1740 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1741 switch-to-buffer to window.el.
1742 (bury-buffer): Move to window.el.
1743 (Vbuffer_list_update_hook): New variable.
1744
1745 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1746 section.
1747
1748 * window.h (resize_frame_windows): Move up in code.
1749 (Fwindow_frame): Remove EXFUN.
1750 (replace_buffer_in_all_windows): Remove prototype.
1751 (replace_buffer_in_windows_safely): Add prototype.
1752
1753 * window.c: Declare Qdelete_window static again. Move down
1754 declaration of select_count.
1755 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1756 (Fother_window): Move to window.el.
1757 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1758 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1759 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1760 window.el.
1761 (replace_buffer_in_windows): Implement by calling
1762 Qreplace_buffer_in_windows.
1763 (replace_buffer_in_all_windows): Remove with some functionality
1764 moved into replace_buffer_in_windows_safely.
1765 (replace_buffer_in_windows_safely): New function.
1766 (select_window_norecord, select_frame_norecord): Move in front
1767 of run_window_configuration_change_hook. Remove now obsolete
1768 declarations.
1769 (Fset_window_buffer): Rewrite doc-string. Call
1770 Qrecord_window_buffer.
1771 (keys_of_window): Move binding for other-window to window.el.
1772
b50691aa
CY
17732011-06-11 Chong Yidong <cyd@stupidchicken.com>
1774
1775 * dispextern.h (struct image): Replace data member, whose int_val
1776 and ptr_val fields were not used by anything, with a single
1777 lisp_val object.
1778
1779 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1780 (gif_clear_image, gif_load, imagemagick_load_image)
1781 (gs_clear_image, gs_load): Callers changed.
1782
3f754b86
PE
17832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1784
cca69397
PE
1785 * buffer.h: Include <time.h>, for time_t.
1786 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1787
109e28d0
PE
1788 Fix minor problems found by static checking.
1789
60737f02
PE
1790 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1791
4b66faf3
PE
1792 Make identifiers static if they are not used in other modules.
1793 * data.c (Qcompiled_function, Qframe, Qvector):
1794 * image.c (QimageMagick, Qsvg):
1795 * minibuf.c (Qmetadata):
1796 * window.c (resize_window_check, resize_root_window): Now static.
1797 * window.h (resize_window_check, resize_root_window): Remove decls.
1798
109e28d0
PE
1799 * window.c (window_deletion_count, delete_deletable_window):
1800 Remove; unused.
46a4ce9e
PE
1801 (window_body_lines): Now static.
1802 (Fdelete_other_windows_internal): Mark vars as initialized.
1803 Make sure 'resize_failed' is initialized.
1804 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1805 (resize_window_apply): Remove unused local.
1806 * window.h (delete_deletable_window): Remove decl.
1807
109e28d0 1808 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1809 (imagemagick_load_image): Fix pointer signedness problem by changing
1810 last arg from unsigned char * to char *. All uses changed.
1811 Also, fix a local for similar reasons.
1812 Remove unused locals. Remove locals to avoid shadowing.
1813 (fn_rsvg_handle_free): Remove; unused.
1814 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1815 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1816
3f754b86
PE
1817 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1818
2547adb1
CY
18192011-06-10 Chong Yidong <cyd@stupidchicken.com>
1820
1821 * image.c (gif_load): Fix omitted cast error introduced by
1822 2011-06-06 change.
1823
2c8e37d4
MR
18242011-06-10 Martin Rudalics <rudalics@gmx.at>
1825
1826 * window.h (resize_proportionally, orig_total_lines)
1827 (orig_top_line): Remove from window structure.
1828 (set_window_height, set_window_width, change_window_heights)
1829 (Fdelete_window): Remove prototypes.
1830 (resize_frame_windows): Remove duplicate declaration.
1831
440a42e3
EZ
18322011-06-10 Eli Zaretskii <eliz@gnu.org>
1833
1834 * window.h (resize_frame_windows, resize_window_check)
1835 (delete_deletable_window, resize_root_window)
1836 (resize_frame_windows): Declare prototypes.
1837
1838 * window.c (resize_window_apply): Make definition be "static" to
1839 match the prototype.
1840
562dd5e9
MR
18412011-06-10 Martin Rudalics <rudalics@gmx.at>
1842
1843 * window.c: Remove declarations of Qwindow_size_fixed,
1844 window_min_size_1, window_min_size_2, window_min_size,
1845 size_window, window_fixed_size_p, enlarge_window, delete_window.
1846 Remove static from declaration of Qdelete_window, it's
1847 temporarily needed by Fbury_buffer.
1848 (replace_window): Don't assign orig_top_line and
1849 orig_total_lines.
1850 (Fdelete_window, delete_window): Remove. Window deletion is
1851 handled by window.el.
1852 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1853 Fdelete_window calls with calls to Qdelete_window.
1854 (Fdelete_other_windows): Remove. Deleting other windows is
1855 handled by window.el.
1856 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1857 handled in window.el.
1858 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1859 Window minimum sizes are handled in window.el.
1860 (shrink_windows, size_window, set_window_height)
1861 (set_window_width, change_window_heights, window_height)
1862 (window_width, CURBEG, CURSIZE, enlarge_window)
1863 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1864 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1865 handled in window.el.
1866 (make_dummy_parent): Rename to make_parent_window and give it a
1867 second argument horflag.
1868 (make_window): Don't set resize_proportionally any more.
1869 (Fsplit_window): Remove. Windows are split in window.el.
1870 (save_restore_action, save_restore_orig_size)
1871 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1872 Resize mini windows in window.el.
1873 (grow_mini_window, shrink_mini_window): Implement by calling
1874 Qresize_root_window_vertically, resize_window_check and
1875 resize_window_apply.
1876 (saved_window, Fset_window_configuration, save_window_save): Do
1877 not handle orig_top_line, orig_total_lines, and
1878 resize_proportionally.
1879 (window_min_height, window_min_width): Move to window.el.
1880 (keys_of_window): Move bindings for delete-other-windows,
1881 split-window, delete-window and enlarge-window to window.el.
1882
1883 * buffer.c: Temporarily extern Qdelete_window.
1884 (Fbury_buffer): Temporarily call Qdelete_window instead of
1885 Fdelete_window (Fbury_buffer will move to window.el soon).
1886
1887 * frame.c (set_menu_bar_lines_1): Remove code handling
1888 orig_top_line and orig_total_lines.
1889
1890 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1891 set_window_height but set heights directly.
1892 (change_frame_size_1): Use resize_frame_windows.
1893
1894 * xdisp.c (init_xdisp): Don't use set_window_height but set
1895 heights directly.
1896
1897 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1898 resize_frame_windows instead of change_window_heights and run
1899 run_window_configuration_change_hook.
1900
1901 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1902 instead of change_window_heights and run
1903 run_window_configuration_change_hook.
1904
1a13852e
MR
19052011-06-09 Martin Rudalics <rudalics@gmx.at>
1906
1907 * window.c (replace_window): Rename second argument REPLACEMENT to
1908 NEW. New third argument SETFLAG. Rewrite.
1909 (delete_window, make_dummy_parent): Call replace_window with
1910 third argument 1.
1911 (window_list_1): Move down in code.
1912 (run_window_configuration_change_hook): Move set_buffer part
1913 before select_frame_norecord part in order to unwind correctly.
1914 Rename count1 to count.
1915 (recombine_windows, delete_deletable_window, resize_root_window)
1916 (Fdelete_other_windows_internal)
1917 (Frun_window_configuration_change_hook, make_parent_window)
1918 (resize_window_check, resize_window_apply, Fresize_window_apply)
1919 (resize_frame_windows, Fsplit_window_internal)
1920 (Fdelete_window_internal, Fresize_mini_window_internal): New
1921 functions.
1922 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1923
f3d1777e
MR
19242011-06-08 Martin Rudalics <rudalics@gmx.at>
1925
496e208e
MR
1926 * window.h (window): Add some new members to window structure -
1927 normal_lines, normal_cols, new_total, new_normal, clone_number,
1928 splits, nest, prev_buffers, next_buffers.
1929 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1930 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1931
f3d1777e
MR
1932 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1933 Remove.
496e208e
MR
1934 (make_dummy_parent): Set new members of windows structure.
1935 (make_window): Move down in code. Handle new members of window
1936 structure.
1937 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1938 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1939 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1940 (Fset_window_prev_buffers, Fwindow_next_buffers)
1941 (Fset_window_next_buffers, Fset_window_clone_number): New
1942 functions.
1943 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1944 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1945 Doc-string fixes.
1946 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1947 Argument WINDOW can be now internal window too.
1948 (Fwindow_use_time): Move up in code.
1949 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1950 Rewrite doc-string.
1951 (Fset_window_configuration, saved_window)
1952 (Fcurrent_window_configuration, save_window_save): Handle new
1953 members of window structure.
b9e809c2
MR
1954 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1955 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1956 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1957 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1958 Qget_mru_window, Qresize_root_window,
1959 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1960 Qauto_buffer_name; staticpro them.
f3d1777e 1961
abde8f8c
MR
19622011-06-07 Martin Rudalics <rudalics@gmx.at>
1963
1964 * window.c (Fwindow_total_size, Fwindow_left_column)
1965 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1966 (Fwindow_list_1): New functions.
1967 (window_box_text_cols): Replace with window_body_cols.
1968 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1969 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1970 (delete_window, Fset_window_configuration): Call
1971 delete_all_subwindows with window as argument.
1972 (delete_all_subwindows): Take a window as argument and not a
1973 structure. Rewrite.
190b47e6
MR
1974 (window_loop): Remove handling of GET_LRU_WINDOW and
1975 GET_LARGEST_WINDOW.
1976 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1977
1978 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1979 window_box_text_cols. delete_all_subwindows now takes a
1980 Lisp_Object as argument.
abde8f8c
MR
1981
1982 * indent.c (compute_motion, Fcompute_motion): Use
1983 window_body_cols instead of window_box_text_cols.
1984
fa8a67e6
MR
1985 * frame.c (delete_frame): Call delete_all_subwindows with root
1986 window as argument.
1987
a54e3482
DC
19882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1989
1990 * fns.c (Fputhash): Document return value.
1991
60002bf5
CY
19922011-06-06 Chong Yidong <cyd@stupidchicken.com>
1993
1994 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1995
0c671da6 19962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1997
b862a52a 1998 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1999
be44ca6c
PE
2000 Check for overflow when converting integer to cons and back.
2001 * charset.c (Fdefine_charset_internal, Fdecode_char):
2002 Use cons_to_unsigned to catch overflow.
2003 (Fencode_char): Use INTEGER_TO_CONS.
2004 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2005 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2006 * data.c (long_to_cons, cons_to_long): Remove.
2007 (cons_to_unsigned, cons_to_signed): New functions.
2008 These signal an error for invalid or out-of-range values.
2009 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2010 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2011 * font.c (Ffont_variation_glyphs):
2012 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2013 * lisp.h: Include <intprops.h>.
2014 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2015 (cons_to_signed, cons_to_unsigned): New decls.
2016 (long_to_cons, cons_to_long): Remove decls.
2017 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2018 (Fprimitive_undo): Use CONS_TO_INTEGER.
2019 * xfns.c (Fx_window_property): Likewise.
2020 * xselect.c: Include <limits.h>.
2021 (x_own_selection, selection_data_to_lisp_data):
2022 Use INTEGER_TO_CONS.
2023 (x_handle_selection_request, x_handle_selection_clear)
2024 (x_get_foreign_selection, Fx_disown_selection_internal)
2025 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2026 (lisp_data_to_selection_data): Use cons_to_unsigned.
2027 (x_fill_property_data): Use cons_to_signed.
2028 Report values out of range.
2029
d1f3d2af
PE
2030 Check for buffer and string overflow more precisely.
2031 * buffer.h (BUF_BYTES_MAX): New macro.
2032 * lisp.h (STRING_BYTES_MAX): New macro.
2033 * alloc.c (Fmake_string):
2034 * character.c (string_escape_byte8):
2035 * coding.c (coding_alloc_by_realloc):
2036 * doprnt.c (doprnt):
2037 * editfns.c (Fformat):
2038 * eval.c (verror):
2039 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2040 since they may not be the same number.
2041 * editfns.c (Finsert_char):
2042 * fileio.c (Finsert_file_contents):
2043 Likewise for BUF_BYTES_MAX.
2044
dd52fcea
PE
2045 * image.c: Use ptrdiff_t, not int, for sizes.
2046 (slurp_file): Switch from int to ptrdiff_t.
2047 All uses changed.
2048 (slurp_file): Check that file size fits in both size_t (for
2049 malloc) and ptrdiff_t (for sanity and safety).
2050
7f9bbdbb
PE
2051 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2052 if b->modtime has its maximal value.
2053
dfe18f82
PE
2054 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2055
84acfcf0
PE
2056 Don't assume time_t can fit into int.
2057 * buffer.h (struct buffer.modtime): Now time_t, not int.
2058 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2059 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2060
ccd9a01a
PE
2061 Minor fixes for signed vs unsigned integers.
2062 * character.h (MAYBE_UNIFY_CHAR):
2063 * charset.c (maybe_unify_char):
2064 * keyboard.c (read_char, reorder_modifiers):
2065 XINT -> XFASTINT, since the integer must be nonnegative.
2066 * ftfont.c (ftfont_spec_pattern):
2067 * keymap.c (access_keymap, silly_event_symbol_error):
2068 XUINT -> XFASTINT, since the integer must be nonnegative.
2069 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2070 since it makes no difference and we prefer signed.
2071 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2072 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2073 nonnegative.
2074
d6d100dd
SM
20752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2076
2077 * window.h (Fwindow_frame): Declare.
2078
2b6148e4
PE
20792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2080
2081 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2082 (SPARE_MEMORY): Always define.
2083 (LARGE_REQUEST): Remove.
2084 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2085
f230ecc9
MR
20862011-06-06 Martin Rudalics <rudalics@gmx.at>
2087
727e958e
MR
2088 * lisp.h: Move EXFUNS for Fframe_root_window,
2089 Fframe_first_window and Fset_frame_selected_window to window.h.
2090
2091 * window.h: Move EXFUNS for Fframe_root_window,
2092 Fframe_first_window and Fset_frame_selected_window here from
2093 lisp.h.
2094
2095 * frame.c (Fwindow_frame, Fframe_first_window)
2096 (Fframe_root_window, Fframe_selected_window)
2097 (Fset_frame_selected_window): Move to window.c.
2098 (Factive_minibuffer_window): Move to minibuf.c.
2099 (Fother_visible_frames_p): New function.
2100
2101 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2102
f230ecc9
MR
2103 * window.c (decode_window, decode_any_window): Move up in code.
2104 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2105 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2106 (Fwindow_buffer): Move up and rewrite doc-string.
2107 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2108 (Fwindow_prev): New functions.
727e958e
MR
2109 (Fwindow_frame): Move here from frame.c. Accept any window as
2110 argument.
2111 (Fframe_root_window, Fframe_first_window)
2112 (Fframe_selected_window): Move here from frame.c. Accept frame
2113 or arbitrary window as argument. Update doc-strings.
2114 (Fminibuffer_window): Move up in code.
2115 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2116 (Fset_frame_selected_window): Move here from frame.c.
2117 Marginal rewrite.
727e958e
MR
2118 (Fselected_window, select_window, Fselect_window): Move up in
2119 code. Minor doc-string fixes.
f230ecc9 2120
4d09bcf6
PE
21212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2124 Do not assume that spare memory exists; that assumption is valid
2125 only if SYSTEM_MALLOC.
2126 (LARGE_REQUEST): New macro, so that the issue of large requests
2127 is separated from the issue of spare memory.
2128
810928a2
AS
21292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2130
172418ad
AS
2131 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2132 format. (Bug#8806)
2133
43f862f7
AS
2134 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2135
810928a2
AS
2136 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2137 before statements.
2138
a059fe24
JD
21392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2140
2141 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2142
2143 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2144
2145 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2146 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2147
989bf368
JB
21482011-06-05 Juanma Barranquero <lekktu@gmail.com>
2149
2150 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2151
4b80f674
CY
21522011-06-04 Chong Yidong <cyd@stupidchicken.com>
2153
2154 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2155 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2156 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2157 New error handlers.
4b80f674
CY
2158 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2159 Obey Vx_select_enable_clipboard_manager. Catch errors in
2160 x_clipboard_manager_save (Bug#8779).
2161 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2162 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2163
99a33b77 21642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2165
2166 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2167
99a33b77 21682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2169
2170 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2171 in the current matrix if keep_current_p is non-zero.
2172
8264569d
EZ
21732011-06-04 Eli Zaretskii <eliz@gnu.org>
2174
2175 * bidi.c (bidi_level_of_next_char): Fix last change.
2176
57f97249
EZ
21772011-06-03 Eli Zaretskii <eliz@gnu.org>
2178
fec2107c 2179 Support bidi reordering of text covered by display properties.
57f97249 2180
fec2107c
EZ
2181 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2182 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2183 (bidi_cache_search, bidi_cache_iterator_state)
2184 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2185 (bidi_level_of_next_char, bidi_move_to_visually_next):
2186 Support character positions inside a run of characters covered by a
fec2107c
EZ
2187 display string.
2188 (bidi_paragraph_init, bidi_resolve_explicit_1)
2189 (bidi_level_of_next_char): Call bidi_fetch_char and
2190 bidi_fetch_char_advance instead of FETCH_CHAR and
2191 FETCH_CHAR_ADVANCE.
2192 (bidi_init_it): Initialize new members.
2193 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2194 definitions.
2195 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2196 instead of using explicit *_CHAR codes.
d6d100dd
SM
2197 (bidi_resolve_explicit, bidi_resolve_weak):
2198 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2199 bidirectional text is supported only in multibyte buffers.
2200 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2201 it to initialize the frame_window_p member of struct bidi_it.
2202 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2203 (bidi_resolve_explicit, bidi_resolve_weak)
2204 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2205 bidi_it->nchars is non-positive.
2206 (bidi_level_of_next_char): Don't try to lookup the cache for the
2207 next/previous character if nothing is cached there yet, or if we
2208 were just reseat()'ed to a new position.
c40e2fb2 2209
0e14fe90
EZ
2210 * xdisp.c (set_cursor_from_row): Set start and stop points
2211 according to the row's direction when priming the loop that looks
2212 for the glyph on which to display cursor.
2213 (single_display_spec_intangible_p): Function deleted.
2214 (display_prop_intangible_p): Reimplement to call
2215 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2216 Accept 3 additional arguments needed by handle_display_spec.
2217 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2218 values: lists, `(when COND...)' forms, etc.
2219 (single_display_spec_string_p): Support property values that are
2220 lists with the argument STRING its top-level element.
2221 (display_prop_string_p): Fix the condition for processing a
2222 property that is a list to be consistent with handle_display_spec.
fec2107c 2223 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2224 last portion of handle_display_prop.
2225 (compute_display_string_pos): Accept additional argument
2226 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2227 value of a `display' property is a "replacing spec".
2228 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2229 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2230 the display property, but just return a value indicating whether
2231 the display property will replace the characters it covers.
2232 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2233 frame_window_p members of struct bidi_it.
d6d100dd
SM
2234 (compute_display_string_pos, compute_display_string_end):
2235 New functions.
fec2107c
EZ
2236 (push_it): Accept second argument POSITION, where pop_it should
2237 jump to continue iteration.
2238 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2239
fec2107c
EZ
2240 * keyboard.c (adjust_point_for_property): Adjust the call to
2241 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2242
2243 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2244 (bidi_init_it): Update prototypes.
2245 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2246 (compute_display_string_pos, compute_display_string_end):
2247 Declare prototypes.
fec2107c
EZ
2248 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2249 EMACS_INT.
fc6f18ce 2250
40087514 22512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2252
57f53182
PE
2253 Malloc failure behavior now depends on size of allocation.
2254 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2255 * lisp.h: Change signatures accordingly.
2256 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2257 All callers changed. (Bug#8762)
2258
2259 * gnutls.c: Use Emacs's memory allocators.
2260 Without this change, the gnutls library would invoke malloc etc.
2261 directly, which causes problems on non-SYNC_INPUT hosts, and which
2262 runs afoul of improving memory_full behavior. (Bug#8761)
2263 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2264 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2265 xfree instead of the default malloc, realloc, free.
2266 (Fgnutls_boot): No need to check for memory allocation failure,
2267 since xmalloc does that for us.
2268
ac32cd99 2269 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2270 * category.c (hash_get_category_set):
2271 * ccl.c (ccl_driver):
2272 * charset.c (Fdefine_charset_internal):
2273 * charset.h (struct charset.hash_index):
2274 * composite.c (get_composition_id, gstring_lookup_cache)
2275 (composition_gstring_put_cache):
2276 * composite.h (struct composition.hash_index):
2277 * dispextern.h (struct image.hash):
2278 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2279 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2280 (hashfn_equal, hashfn_user_defined, make_hash_table)
2281 (maybe_resize_hash_table, hash_lookup, hash_put)
2282 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2283 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2284 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2285 * image.c (make_image, search_image_cache, lookup_image)
2286 (xpm_put_color_table_h):
2287 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2288 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2289 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2290 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2291 * alloc.c (allocate_vectorlike):
2292 Check for overflow in vector size calculations.
2293 * ccl.c (ccl_driver):
2294 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2295 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2296 need to be updated by these changes.
40087514
PE
2297 * fns.c (make_hash_table, maybe_resize_hash_table):
2298 Check for integer overflow with large hash tables.
0de4bb68
PE
2299 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2300 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2301 (SXHASH_REDUCE): New macro.
2302 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2303 Use it instead of discarding useful hash info with large hash values.
2304 (sxhash_float): New function.
2305 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2306 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2307 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2308 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2309 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2310 Adjust signatures to match updated version of code.
2311 (consing_since_gc): Now EMACS_INT, since a single hash table can
2312 use more than INT_MAX bytes.
2313
698d32e2
DN
23142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2315
2316 Make it possible to build with GCC-4.6+ -O2 -flto.
2317
2318 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2319
fd6fa53f
SM
23202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2321
2322 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2323 Call minibuffer-inactive-mode.
2324
864db017
JB
23252011-05-31 Juanma Barranquero <lekktu@gmail.com>
2326
2327 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2328 Update dependencies.
2329
2ad0baf4
DN
23302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2331
2332 * data.c (init_data): Remove code for UTS, this system is not
2333 supported anymore.
2334
4fcc2638
DN
23352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2336
2337 Don't force ./temacs to start in terminal mode.
2338
2339 * frame.c (make_initial_frame): Initialize faces in all cases, not
2340 only when CANNOT_DUMP is defined.
2341 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2342
c56e0fd5
DN
23432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2344
2345 * dispnew.c (add_window_display_history): Use const for the string
2346 pointer. Remove declaration, not needed.
2347
333d54da 23482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2349
55d4c1b2 2350 Use 'inline', not 'INLINE'.
333d54da 2351 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2352 * alloc.c, fontset.c (INLINE): Remove.
2353 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2354 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2355 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2356 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2357 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2358
738db178
DN
23592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2360
2361 Make it possible to run ./temacs.
2362
2363 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2364 syms_of_callproc does the same thing. Remove test for
2365 "initialized", do it in the caller.
2366 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2367
620c53a6
SM
23682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2369
2370 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2371 (read_minibuf): Use get_minibuffer.
2372 (syms_of_minibuf): Use DEFSYM.
2373 (Qmetadata): New var.
2374 * data.c (Qbuffer): Don't make it static.
2375 (syms_of_data): Use DEFSYM.
2376
e003a292
PE
23772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2378
2379 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2380 (CCL_CODE_MIN): New macro.
2381
ed008a6d
PE
23822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2383
3687c2ef
PE
2384 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2385
ed008a6d
PE
2386 * eval.c (Qdebug): Now static.
2387 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2388 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2389 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2390
d66c4c7c
CY
23912011-05-29 Chong Yidong <cyd@stupidchicken.com>
2392
2393 * image.c: Various fixes to ImageMagick code comments.
2394 (Fimagemagick_types): Doc fix.
2395
5fbc2025
PE
23962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2397
0196f88a
PE
2398 Minor fixes prompted by GCC 4.6.0 warnings.
2399
2400 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2401
5fbc2025
PE
2402 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2403 (x_clipboard_manager_save_all): Move extern decl to ...
2404 * xterm.h: ... here, so that it can be checked for consistency.
2405
1dd3c2d9
CY
24062011-05-29 Chong Yidong <cyd@stupidchicken.com>
2407
2408 * xselect.c (x_clipboard_manager_save_frame)
2409 (x_clipboard_manager_save_all): New functions.
2410 (Fx_clipboard_manager_save): Lisp function deleted.
2411
2412 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2413 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2414
2415 * xterm.h: Update prototype.
2416
5ba6571d
WX
24172011-05-28 William Xu <william.xwl@gmail.com>
2418
2419 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2420 exiting (Bug#8239).
2421
3eaff834
JM
24222011-05-28 Jim Meyering <meyering@redhat.com>
2423
e1900994 2424 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2425 * fns.c (to_uchar): Define.
2426 (crypto_hash_function): Use it to convert some newly-signed
2427 variables to unsigned, to avoid sign-extension bugs. For example,
2428 without this change, (md5 "truc") would evaluate to
2429 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2430 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2431 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2432
0f6990a7
PE
24332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2434
2435 Integer overflow fixes.
c8a9ca5a 2436
08686060
PE
2437 * dbusbind.c: Serial number integer overflow fixes.
2438 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2439 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2440 to hold a serial number that is too large for a fixnum.
2441 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2442 Check for serial numbers out of range. Decode any serial number
59568bf0 2443 that was so large that it became a float. (Bug#8722)
08686060 2444
2d1fc3c7
PE
2445 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2446 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2447 Use XFASTINT rather than XUINT when numbers are nonnegative.
2448 (xd_append_arg, Fdbus_method_return_internal):
2449 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2450 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2451 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2452 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2453 (Bug#8722)
2d1fc3c7 2454
c8a9ca5a
PE
2455 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2456
519e1d69
PE
2457 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2458
30569699
PE
2459 ccl: add integer overflow checks
2460 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2461 (IN_INT_RANGE): New macros.
2462 (ccl_driver): Use them to check for integer overflow when
2463 decoding a CCL program. Many of the new checks are whether XINT (x)
2464 fits in int; it doesn't always, on 64-bit hosts. The new version
2465 doesn't catch all possible integer overflows, but it's an
847044ea 2466 improvement. (Bug#8719)
30569699 2467
c11285dc
PE
2468 * alloc.c (make_event_array): Use XINT, not XUINT.
2469 There's no need for unsigned here.
2470
fdccd48e
PE
2471 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2472 This follows up to the 2011-05-06 change that substituted uintptr_t
2473 for EMACS_INT. This case wasn't caught back then.
2474
37910ab2
PE
2475 Rework Fformat to avoid integer overflow issues.
2476 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2477 now (part of C89). Include <verify.h>.
2478 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2479 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2480 (Fformat): Avoid the prepass trying to compute sizes; it was only
2481 approximate and thus did not catch overflow reliably. Instead, walk
2482 through the format just once, formatting and computing sizes as we go,
2483 checking for integer overflow at every step, and allocating a larger
2484 buffer as needed. Keep track separately whether the format is
2485 multibyte. Keep only the most-recently calculated precision, rather
2486 than them all. Record whether each argument has been converted to
2487 string. Use EMACS_INT, not int, for byte and char and arg counts.
2488 Support field widths and precisions larger than INT_MAX. Avoid
2489 sprintf's undefined behavior with conversion specifications such as %#d
2490 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2491 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2492 formatting out-of-range floating point numbers with int
9173deec 2493 formats. (Bug#8668)
37910ab2 2494
2e6578fb
PE
2495 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2496
0ae6bdee
PE
2497 * data.c: Avoid integer truncation in expressions involving floats.
2498 * data.c: Include <intprops.h>.
2499 (arith_driver): When there's an integer overflow in an expression
2500 involving floating point, convert the integers to floating point
2501 so that the resulting value does not suffer from catastrophic
2502 integer truncation. For example, on a 64-bit host (* 4
2503 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2504 Do not rely on undefined behavior after integer overflow.
2505
de883a70
PE
2506 merge count_size_as_multibyte, parse_str_to_multibyte
2507 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2508 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2509 Check for integer overflow.
2510 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2511 since it's now a duplicate of the other. This is more of
2512 a character than a buffer op, so better that it's in character.c.
2513 * fns.c, print.c: Adjust to above changes.
2514
2ff916cb
PE
25152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2516
2517 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2518
f1b54466
PE
25192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2520
fb1ac845
PE
2521 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2522 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2523 (x_clipboard_manager_save): Now static.
2524 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2525
f1b54466
PE
2526 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2527 (crypto_hash_function): Now static.
2528 Fix pointer signedness problems. Avoid unnecessary initializations.
2529
a9f737ee
CY
25302011-05-27 Chong Yidong <cyd@stupidchicken.com>
2531
2532 * termhooks.h (Vselection_alist): Make it terminal-local.
2533
2534 * terminal.c (create_terminal): Initialize it.
2535
2536 * xselect.c: Support for clipboard managers.
2537 (Vselection_alist): Move to termhooks.h as terminal-local var.
2538 (LOCAL_SELECTION): New macro.
2539 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2540 (symbol_to_x_atom): Remove gratuitous arg.
2541 (x_handle_selection_request, lisp_data_to_selection_data)
2542 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2543 (x_own_selection, x_get_local_selection, x_convert_selection):
2544 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2545 (some_frame_on_display): Delete unused function.
2546 (Fx_own_selection_internal, Fx_get_selection_internal)
2547 (Fx_disown_selection_internal, Fx_selection_owner_p)
2548 (Fx_selection_exists_p): New optional frame arg.
2549 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2550 (x_handle_selection_clear): Don't treat other terminals with the
2551 same keyboard specially. Use the terminal-local Vselection_alist.
2552 (x_clear_frame_selections): Use Frun_hook_with_args.
2553
2554 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2555
2556 * xterm.h: Add support for those atoms.
2557
e067f0c1
CY
25582011-05-26 Chong Yidong <cyd@stupidchicken.com>
2559
2560 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2561 (converted_selections, conversion_fail_tag): New global variables.
2562 (x_selection_request_lisp_error): Free the above.
2563 (x_get_local_selection): Remove unnecessary code.
2564 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2565 of converted selections stored in converted_selections.
2566 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2567 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2568 (x_convert_selection): New function.
2569 (x_handle_selection_event): Simplify.
2570 (x_get_foreign_selection): Don't ignore incoming requests while
2571 waiting for an answer; this will fail when we implement
2572 SAVE_TARGETS, and seems unnecessary anyway.
2573 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2574 (Vx_sent_selection_functions): Doc fix.
2575
0f4aebc0
LL
25762011-05-26 Leo Liu <sdl.web@gmail.com>
2577
2578 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2579
e61124cd
YM
25802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2581
2582 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2583
2584 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2585 for fringe update if it has periodic bitmap.
ac389d0c 2586 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2587 and fringe_bitmap_periodic_p.
2588
2589 * fringe.c (get_fringe_bitmap_data): New function.
2590 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2591 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2592 row. Mark glyph row for fringe update if periodicity changed.
2593
2594 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2595 for fringe update unless it has periodic bitmap.
2596
f16d9837
KH
25972011-05-25 Kenichi Handa <handa@m17n.org>
2598
2599 * xdisp.c (get_next_display_element): Set correct it->face_id for
2600 a static composition.
2601
e1b90ef6
LL
26022011-05-24 Leo Liu <sdl.web@gmail.com>
2603
2604 * deps.mk (fns.o):
2605 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2606
2607 * fns.c (crypto_hash_function, Fsha1): New function.
2608 (Fmd5): Use crypto_hash_function.
2609 (syms_of_fns): Add Ssha1.
2610
7400048f
PE
26112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * gnutls.c: Remove unused macros.
2614 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2615 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2616 Remove macros that are defined and never used.
2617 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2618
abb71cf4
CY
26192011-05-22 Chong Yidong <cyd@stupidchicken.com>
2620
2621 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2622 (Fx_get_selection_internal): Minor cleanup.
2623 (Fx_own_selection_internal): Rename arguments for consistency with
2624 select.el.
2625
6307db39
PE
26262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2629
f3d4e0a4
CY
26302011-05-22 Chong Yidong <cyd@stupidchicken.com>
2631
2632 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2633
4d8ade89
YM
26342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2635
2636 * dispnew.c (scrolling_window): Don't exclude the case that the
2637 last enabled row in the desired matrix touches the bottom boundary.
2638
32078c8d
GM
26392011-05-21 Glenn Morris <rgm@gnu.org>
2640
2641 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2642 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2643 and add some more files.
32078c8d 2644
7285dc67
EZ
26452011-05-20 Eli Zaretskii <eliz@gnu.org>
2646
2647 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2648 report_file_error introduced by the change from 2011-05-07.
2649
89d1bd22
PE
26502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2651
2652 * systime.h (Time): Define only if emacs is defined.
2653 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2654 where the include path doesn't have X11/X.h by default. See
2655 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2656
e23640bb 26572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2658
2659 * composite.c (find_automatic_composition): Fix previous change.
2660
b9704ad9
GM
26612011-05-20 Glenn Morris <rgm@gnu.org>
2662
2663 * lisp.mk: New file, split from Makefile.in.
2664 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2665 (shortlisp): Remove.
2666 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2667
4a720484
GM
26682011-05-19 Glenn Morris <rgm@gnu.org>
2669
2670 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2671 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2672 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2673 (lisp): Set the order to that of loadup.el.
2674 (shortlisp): Make it a copy of $lisp.
2675 (SOME_MACHINE_LISP): Remove.
2676 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2677 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2678
a28d4396
KH
26792011-05-18 Kenichi Handa <handa@m17n.org>
2680
2681 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2682 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2683 (find_automatic_composition): Mostly rewrite for efficiency.
2684
a2b1fa8e
JB
26852011-05-18 Juanma Barranquero <lekktu@gmail.com>
2686
2687 * makefile.w32-in: Update dependencies.
2688
8e1f5610
CS
26892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2690
2691 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2692 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2693
7025ee00 26942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2695
cdfa6eab
PE
2696 Fix some integer overflow issues, such as string length overflow.
2697
06d6db33
PE
2698 * insdel.c (count_size_as_multibyte): Check for string overflow.
2699
2b4560a8
PE
2700 * character.c (lisp_string_width): Check for string overflow.
2701 Use EMACS_INT, not int, for string indexes and lengths; in
2702 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2703 the resulting string length overflows an EMACS_INT; instead,
2704 report a string overflow if no precision given. When checking for
2705 precision exhaustion, use a check that cannot possibly have
2706 integer overflow. (Bug#8675)
2707 * character.h (lisp_string_width): Adjust to new signature.
2708
cb93f9be
PE
2709 * alloc.c (string_overflow): New function.
2710 (Fmake_string): Use it. This doesn't change behavior, but saves
2711 a few bytes and will simplify future changes.
2712 * character.c (string_escape_byte8): Likewise.
2713 * lisp.h (string_overflow): New decl.
2714
1a1f3366
PE
2715 Fixups, following up to the user-interface timestamp change.
2716 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2717 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2718 * msdos.c (mouse_get_pos): Likewise.
2719 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2720 * w32gui.h (Time): Define by including "systime.h" rather than by
2721 declaring it ourselves. (Bug#8664)
2722
d4e3e4d3
PE
2723 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2724 * image.c (clear_image_cache): Likewise.
2725
f6a24d19
PE
2726 * term.c (term_mouse_position): Don't assume time_t wraparound.
2727
08dc5ae6
PE
2728 Be more systematic about user-interface timestamps.
2729 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2730 and sometimes 'EMACS_UINT', to represent these timestamps.
2731 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2732 This makes the code easier to follow, and makes it easier to catch
2733 integer overflow bugs such as Bug#8664.
2734 * frame.c (Fmouse_position, Fmouse_pixel_position):
2735 Use Time, not unsigned long, for user-interface timestamps.
2736 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2737 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2738 * keyboard.h (last_event_timestamp): Likewise.
2739 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2740 * menu.h (xmenu_show): Likewise.
2741 * term.c (term_mouse_position): Likewise.
2742 * termhooks.h (struct input_event.timestamp): Likewise.
2743 (struct terminal.mouse_position_hook): Likewise.
2744 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2745 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2746 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2747 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2748 what it was before.
2749 * menu.h, termhooks.h: Include "systime.h", for Time.
2750
8e55734a
PE
2751 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2752 Don't assume that the difference between two unsigned long values
2753 can fit into an integer. At this point, we know button_down_time
2754 <= event->timestamp, so the difference must be nonnegative, so
2755 there's no need to cast the result if double-click-time is
2756 nonnegative, as it should be; check that it's nonnegative, just in
2757 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2758 apart (about 25 days). (Bug#8664)
8e55734a 2759
841f1b75 2760 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2761 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2762
3e26f69c
PE
2763 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2764 that always fit in int. Use a sentinel instead of a counter, to
2765 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2766 * frame.h (struct frame): Use int for menu_bar_items_used
2767 instead of EMACS_INT, since it always fits in int.
3e26f69c 2768
5cc152c0
PE
2769 * menu.c (grow_menu_items): Check for int overflow.
2770
d89eb65e
PE
2771 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2772
5235bd3e
PE
2773 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2774 Before, the code was not consistent. These values cannot exceed
2775 2**31 - 1 so there's no need to make them unsigned.
2776 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2777 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2778 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2779 as modifiers.
2780 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2781
bc827e23
PE
2782 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2783 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2784 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2785 presumably because the widths might not match.
2786
78eb494e
PE
2787 * window.c (size_window): Avoid needless test at loop start.
2788
04f2d78b
CB
27892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2790
2791 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2792
d2fc7e3d 27932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2794
2795 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2796
d2fc7e3d 27972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2798
2799 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2800 `width' to `bar_area_x' and `bar_area_width', respectively.
2801 (x_scroll_run): Take account of fringe background extension.
2802
04f2d78b
CB
2803 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2804 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2805 `bar_area_width', respectively.
2806 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2807 background extension.
2808
79b70037
GM
28092011-05-10 Jim Meyering <meyering@redhat.com>
2810
2811 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2812
2f142cc5
JB
28132011-05-10 Juanma Barranquero <lekktu@gmail.com>
2814
2815 * image.c (Finit_image_library): Return t for built-in image types,
2816 like pbm and xbm. (Bug#8640)
2817
57679c86
AS
28182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2819
2820 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2821
888c9e86
EZ
28222011-05-07 Eli Zaretskii <eliz@gnu.org>
2823
b0512a1d
EZ
2824 * w32console.c (Fset_screen_color): Doc fix.
2825 (Fget_screen_color): New function.
2826 (syms_of_ntterm): Defsubr it.
2827
7285dc67
EZ
2828 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2829 unlink the temporary file if Fcall_process didn't create it in the
2830 first place.
2831 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2832 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2833 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2834 cue to call_process_cleanup not to close that handle.
2835
4d3fcc8e
BK
28362011-05-07 Ben Key <bkey76@gmail.com>
2837
2838 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2839 one of two shell specific rules, either bootstrap-temacs-CMD or
2840 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2841 to the previous implementation of the bootstrap-temacs rule.
2842 The bootstrap-temacs-CMD rule is similar to the previous
2843 implementation of the bootstrap-temacs rule except that it
2844 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2845 variable.
2846
2847 These changes, along with some changes to nt/configure.bat,
2848 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2849 earlier fix to add support for --cflags and --ldflags options
2850 that include quotes so that it works whether make uses cmd or
2851 sh as the shell.
2852
b4289b64
MA
28532011-05-06 Michael Albinus <michael.albinus@gmx.de>
2854
2855 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2856 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2857 is a constant.
2858 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2859 a string. Handle both cases.
2860 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2861 (Fdbus_register_method): Use Qinvalid_function.
2862
af4c0e28
JB
28632011-05-06 Juanma Barranquero <lekktu@gmail.com>
2864
2865 * makefile.w32-in: Update dependencies.
2866 (LISP_H): Add inttypes.h and stdin.h.
2867 (PROCESS_H): Add unistd.h.
2868
c51453d9
EZ
28692011-05-06 Eli Zaretskii <eliz@gnu.org>
2870
2871 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2872 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2873
8ff0ac3c 28742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2875
4c4b566b
PE
2876 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2877
aab2b9b5
PE
2878 * term.c (vfatal): Remove stray call to va_end.
2879 It's not needed and the C Standard doesn't allow it here anyway.
2880
c378da0b
PE
2881 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2882 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2883
288b08c7
PE
2884 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2885 bytes.
2886
e3601888
PE
2887 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2888
db6c0e74
PE
2889 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2890
dd5963ea
PE
2891 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2892
88c9450f
PE
2893 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2894
2f9442b8
PE
2895 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2896
c032b5f8
PE
2897 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2898 * charset.c (Fdefine_charset_internal): Don't initialize
2899 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2900 32-bit int (Bug#8600).
a108c10b
PE
2901
2902 * lread.c (read_integer): Be more consistent with string-to-number.
2903 Use string_to_number to do the actual conversion; this avoids
2904 rounding errors and fixes some other screwups. Without this fix,
2905 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2906 (digit_to_number): Move earlier, for benefit of read_integer.
2907 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2908 not a digit in any supported base. (Bug#8602)
a108c10b 2909
ad5f9eea
PE
2910 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2911
aec1708a
PE
2912 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2913 to match comment at start of function. This also removes a
2914 GCC warning about overflow in a 32+64-bit port.
2915
47be4ab5
PE
2916 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2917
371cac43
PE
2918 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2919 Reported by Stefan Monnier in
2920 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2921 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2922 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2923
d01a7826
PE
2924 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2925 (EMACS_UINTPTR): Likewise, with uintptr_t.
2926
7fd47d5c
PE
2927 * lisp.h: Prefer 64-bit EMACS_INT if available.
2928 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2929 on 32-bit hosts that have 64-bit int, so that they can access
2930 large files.
122b0c86
PE
2931 However, temporarily disable this change unless the temporary
2932 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2933
8727937b
PE
2934 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2935
8ac068ac
PE
2936 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2937 This removes an assumption that EMACS_INT and long are the same
2938 width as pointers. The assumption is true for Emacs porting targets
2939 now, but we want to make other targets possible.
2940 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2941 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2942 In the rest of the code, change types of integers that hold casted
2943 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2944 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2945 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2946 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2947 No need to cast type when ORing.
2948 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2949 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2950 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2951 assume EMACS_INT is the same width as char *.
2952 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2953 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2954 Remove no-longer-needed casts.
2955 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2956 (xg_tool_bar_help_callback, xg_make_tool_item):
2957 Use EMACS_INTPTR to hold an integer
2958 that will be cast to void *; this can avoid a GCC warning
2959 if EMACS_INT is not the same width as void *.
2960 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2961 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2962 (current_message_1, set_message_1):
2963 Use a local to convert to proper width without a cast.
2964 * xmenu.c (dialog_selection_callback): Likewise.
2965
ede49d71
PE
2966 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2967 Also, don't assume VALBITS / RAND_BITS is less than 5,
2968 and don't rely on undefined behavior when shifting a 1 left into
2969 the sign bit.
2970 * lisp.h (get_random): Change signature to match.
2971
2f30ecd0
PE
2972 * lread.c (hash_string): Use size_t, not int, for hash computation.
2973 Normally we prefer signed values; but hashing is special, because
2974 it's better to use unsigned division on hash table sizes so that
2975 the remainder is nonnegative. Also, size_t is the natural width
2976 for hashing into memory. The previous code used 'int', which doesn't
2977 retain enough info to hash well into very large tables.
2978 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2979
2a866e7b
PE
2980 * dbusbind.c: Don't possibly lose pointer info when converting.
2981 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2982 Use XPNTR rather than XHASH, so that the high-order bits of
2983 the pointer aren't lost when converting through void *.
2984
51639eac
PE
2985 * eval.c (Fautoload): Don't double-shift a pointer.
2986
92394119
PE
2987 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2988
dbdb9a7c
JB
29892011-05-06 Juanma Barranquero <lekktu@gmail.com>
2990
2991 * gnutls.c (DEF_GNUTLS_FN):
2992 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2993
db7a0b4f
AS
29942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2995
2996 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2997 marker. (Bug#8610)
2998
f7ff1b0f 29992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3000
3001 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3002 New version that can reserve upto 2GB of heap space.
3003
f7ff1b0f 30042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3005
3006 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3007
639c109b
TZ
30082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3009
3010 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3011 `gnutls_certificate_set_x509_key_file'.
3012
d2127135
JB
30132011-05-05 Juanma Barranquero <lekktu@gmail.com>
3014
3015 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3016 Update dependencies.
3017
e968f4f3
JB
30182011-05-04 Juanma Barranquero <lekktu@gmail.com>
3019
3020 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3021 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3022 Remove unused parameter `fildes'.
3023 * process.c (read_process_output, send_process): Don't pass it.
3024
84d358f0
JB
30252011-05-04 Juanma Barranquero <lekktu@gmail.com>
3026
3027 Fix previous change: the library cache is defined in w32.c.
3028 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3029 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3030
0898ca10
JB
30312011-05-04 Juanma Barranquero <lekktu@gmail.com>
3032
3033 Implement dynamic loading of GnuTLS on Windows.
3034
3035 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3036 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3037 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3038 Declare.
3039
3040 * gnutls.c (Qgnutls_dll): Define.
3041 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3042 (gnutls_*): Declare function pointers.
3043 (init_gnutls_functions): New function to initialize function pointers.
3044 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3045 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3046 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3047 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3048 (emacs_gnutls_write, emacs_gnutls_read)
3049 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3050 (Fgnutls_available_p): New function.
3051 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3052 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3053 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3054
3055 * image.c: Include w32.h.
3056 (Vimage_type_cache): Delete.
3057 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3058 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3059 (w32_delayed_load): Move to w32.c.
3060
3061 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3062
3063 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3064 (w32_delayed_load): Move from image.c. When loading a library, record
3065 its filename in the :loaded-from property of the library id.
3066 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3067 Initialize and staticpro them.
3068 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3069
3070 * process.c: Include lisp.h before w32.h, not after.
3071 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3072 instead of gnutls_record_check_pending.
3073
3074 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3075
ff4de4aa
TZ
30762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3077
3078 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3079 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3080 as passed in.
3081
abe95abb
JD
30822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3083
3084 * xterm.c (x_set_frame_alpha): Do not set property on anything
3085 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3086
e16e55d4
JB
30872011-05-02 Juanma Barranquero <lekktu@gmail.com>
3088
3089 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3090
bafcf6a5
JB
30912011-05-02 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3094 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3095 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3096 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3097 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3098 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3099 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3100 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3101 (Qgnutls_bootprop_callbacks_verify): Make static.
3102
e7a6747f
AS
31032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3104
19ed11ba
AS
3105 * callproc.c: Indentation fixup.
3106
e7a6747f 3107 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3108 (wait_for_termination, interruptible_wait_for_termination):
3109 Move after wait_for_termination_1.
e7a6747f 3110
1ef14cb4
LMI
31112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3112
3113 * sysdep.c (interruptible_wait_for_termination): New function
3114 which is like wait_for_termination, but allows keyboard
3115 interruptions.
3116
3117 * callproc.c (Fcall_process): Add (:file "file") as an option for
3118 the STDOUT buffer.
3119 (Fcall_process_region): Ditto.
3120
330d880c
EZ
31212011-04-30 Eli Zaretskii <eliz@gnu.org>
3122
8db90b73
EZ
3123 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3124 rather than `XVECTOR (FOO)->size'.
3125
330d880c
EZ
3126 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3127 inttypes.h, as a gnulib replacement is used if it not available in
3128 system headers.
3129
15cbd324
EZ
31302011-04-21 Eli Zaretskii <eliz@gnu.org>
3131
3132 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3133 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3134 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3135
3136 * coding.c (coding_alloc_by_realloc): Error out if destination
3137 will grow beyond MOST_POSITIVE_FIXNUM.
3138 (decode_coding_emacs_mule): Abort if there isn't enough place in
3139 charbuf for the composition carryover bytes. Reserve an extra
3140 space for up to 2 characters produced in a loop.
3141 (decode_coding_iso_2022): Abort if there isn't enough place in
3142 charbuf for the composition carryover bytes.
3143
31442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3145
ae940cca
EZ
3146 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3147 aborting when %lld or %lll format is passed.
3148 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3149 %llo or %llx format is passed. (Bug#8545)
3150
03ab8921
EZ
3151 * window.c (window_scroll_line_based): Use a marker instead of
3152 simple variables to record original value of point. (Bug#7952)
3153
afda1437
EZ
3154 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3155 produced by %s or %c overflows available buffer space. (Bug#8545)
3156
f76dee0c
PE
31572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3158
3159 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3160 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3161
fdc5744d
JB
31622011-04-28 Juanma Barranquero <lekktu@gmail.com>
3163
3164 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3165
638f053a
JB
31662011-04-28 Juanma Barranquero <lekktu@gmail.com>
3167
3168 * keyboard.c (Qdelayed_warnings_hook): Define.
3169 (command_loop_1): Run `delayed-warnings-hook'
3170 if Vdelayed_warnings_list is non-nil.
3171 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3172 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3173
d178f871
EZ
31742011-04-28 Eli Zaretskii <eliz@gnu.org>
3175
3176 * doprnt.c (doprnt): Don't return value smaller than the buffer
3177 size if the message was truncated. (Bug#8545).
3178
b124fd93
JB
31792011-04-28 Juanma Barranquero <lekktu@gmail.com>
3180
3181 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3182 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3183
e810457d
PE
31842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3187
ea51cceb
JB
31882011-04-27 Juanma Barranquero <lekktu@gmail.com>
3189
3190 * makefile.w32-in: Update dependencies.
3191
94dcfacf
EZ
31922011-04-27 Eli Zaretskii <eliz@gnu.org>
3193
3194 Improve `doprnt' and its usage. (Bug#8545)
3195 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3196 `format_end'. Remove support for %l as a conversion specifier.
3197 Don't use xrealloc. Improve diagnostics when the %l size modifier
3198 is used. Update the commentary.
3199
3200 * eval.c (verror): Simplify calculation of size_t.
3201
3202 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3203 messages.
3204
f61f41d7
PE
32052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3206
3207 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3208 change.
3209
96fb4434
PE
32102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3213 This makes this file independent of the recent pseudovector change.
3214
671875da 32152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3216
69e9b5a3
PE
3217 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3218
b5f869a7 3219 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3220 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3221 Remove unused local.
c8926152 3222 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3223
841a1577 3224 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3225 GCC 4.6.0 optimizes based on type-based alias analysis.
3226 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3227 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3228 != &v->size, and therefore "v->size = 1; b->size = 2; return
3229 v->size;" must therefore return 1. This assumption is incorrect
3230 for Emacs, since it type-puns struct Lisp_Vector * with many other
3231 types. To fix this problem, this patch adds a new type struct
f904488f 3232 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3233 and pseudovectors, and helps optimizing compilers not get fooled
3234 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3235 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3236 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3237 the size member.
eab3844f
PE
3238 (XSETPVECTYPE): Rewrite in terms of new macro.
3239 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3240 This is a bit clearer, and further avoids the possibility of
3241 undesirable aliasing.
3242 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3243 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3244 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3245 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3246 (ASIZE): Now uses header.size rather than size.
3247 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3248 to avoid the hassle of writing XVECTOR (foo)->header.size.
3249 (struct vectorlike_header): New type.
eab3844f
PE
3250 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3251 object, to help avoid aliasing.
3252 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3253 (SUBRP): Likewise, since Lisp_Subr is a special case.
3254 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3255 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3256 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3257 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3258 changed to be "header.size" and "header.next".
3259 * buffer.h (struct buffer): Likewise.
3260 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3261 * frame.h (struct frame): Likewise.
3262 * process.h (struct Lisp_Process): Likewise.
3263 * termhooks.h (struct terminal): Likewise.
3264 * window.c (struct save_window_data, struct saved_window): Likewise.
3265 * window.h (struct window): Likewise.
3266 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3267 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3268 * buffer.c (init_buffer_once): Likewise.
3269 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3270 special case.
3271 * process.c (Fformat_network_address): Use local var for size,
3272 for brevity.
3273
0df1eac5
PE
3274 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3275
847ab9d1 3276 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3277 * data.c (atof): Remove decl; no longer used or needed.
3278 (digit_to_number): Move to lread.c.
3279 (Fstring_to_number): Use new string_to_number function, to be
3280 consistent with how the Lisp reader treats infinities and NaNs.
3281 Do not assume that floating-point numbers represent EMACS_INT
3282 without losing information; this is not true on most 64-bit hosts.
3283 Avoid double-rounding errors, by insisting on integers when
3284 parsing non-base-10 numbers, as the documentation specifies.
3285 * lisp.h (string_to_number): New decl, replacing ...
3286 (isfloat_string): Remove.
bc0a5c13 3287 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3288 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3289 appears to have been a coding error. Similarly, do not accept
3290 strings like +-1e0 as floating point numbers. Do not report
3291 overflow for integer overflows unless the base is not 10 which
3292 means we have no simple and reliable way to continue.
3293 Break out the floating-point parsing into a new
3294 function string_to_number, so that Fstring_to_number parses
3295 floating point numbers consistently with the Lisp reader.
04f2d78b 3296 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3297 (E_CHAR, EXP_INT): Remove, replacing with ...
3298 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3299 (string_to_number): New function, replacing isfloat_string.
3300 This function checks for valid syntax and produces the resulting
3301 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3302 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3303 so that overflow for non-base-10 numbers is reported only when
3304 there's no portable and simple way to convert to floating point.
452f4150 3305
67769ffc
PE
3306 * textprop.c (set_text_properties_1): Rewrite for clarity,
3307 and to avoid GCC warning about integer overflow.
3308
c20db43f
PE
3309 * intervals.h (struct interval): Use EMACS_INT for members
3310 where EMACS_UINT might cause problems. See
3311 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3312 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3313 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3314 All uses changed.
37aa2f85
PE
3315 (offset_intervals): Tell GCC not to worry about length overflow
3316 when negating a negative length.
c20db43f 3317
2538aa2f
PE
3318 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3319 (overrun_check_free): Likewise.
3320
f2d3008d
PE
3321 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3322 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3323 word size.
3324
ec8df744
PE
3325 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3326 (gnutls_make_error): Rename local to avoid shadowing.
3327 (gnutls_emacs_global_deinit): ifdef out; not used.
3328 (Fgnutls_boot): Use const for pointer to readonly storage.
3329 Comment out unused local. Fix pointer signedness problems.
3330
640ee02d
PE
3331 * lread.c (openp): Don't stuff size_t into an 'int'.
3332 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3333 about possible signed overflow.
3334
6048fb2a
PE
3335 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3336 (GDK_KEY_g): Don't define if already defined.
3337 (xg_prepare_tooltip): Avoid pointer signedness problem.
3338 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3339
fa3c87e1
PE
3340 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3341 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3342
2172544b
PE
3343 * xfns.c (Fx_window_property): Simplify a bit,
3344 to make a bit faster and to avoid GCC 4.6.0 warning.
3345 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3346
9b821a21
PE
3347 * fns.c (internal_equal): Don't assume size_t fits in int.
3348
3c616cfa
PE
3349 * alloc.c (compact_small_strings): Tighten assertion a little.
3350
c2982e87
PE
3351 Replace pEd with more-general pI, and fix some printf arg casts.
3352 * lisp.h (pI): New macro, generalizing old pEd macro to other
3353 conversion specifiers. For example, use "...%"pI"d..." rather
3354 than "...%"pEd"...".
3355 (pEd): Remove. All uses replaced with similar uses of pI.
3356 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3357 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3358 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3359 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3360 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3361 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3362 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3363 64-bit hosts.
3364 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3365 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3366 * print.c (safe_debug_print, print_object): Likewise.
3367 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3368 to int.
6f04d126
PE
3369 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3370 avoiding the 0 flag, which is not portable.
c2982e87
PE
3371 * process.c (Fmake_network_process): Use pI to avoid cast.
3372 * region-cache.c (pp_cache): Likewise.
3373 * xdisp.c (decode_mode_spec): Likewise.
3374 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3375 behavior on 64-bit hosts with printf arg.
6f04d126 3376 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3377 (x_stop_queuing_selection_requests): Likewise.
3378 (x_get_window_property): Don't truncate byte count to an 'int'
3379 when tracing.
0b432f21 3380
5e073ec7
PE
3381 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3382 here, since it parses constructs like leading '-' and spaces,
3383 which are not wanted; and it overflows with large numbers.
3384 Instead, simply match F[0-9]+, which is what is wanted anyway.
3385
36372bf9
PE
3386 * alloc.c: Remove unportable assumptions about struct layout.
3387 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3388 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3389 (allocate_vectorlike, make_pure_vector): Use the new macros,
3390 plus offsetof, to remove unportable assumptions about struct layout.
3391 These assumptions hold on all porting targets that I know of, but
3392 they are not guaranteed, they're easy to remove, and removing them
3393 makes further changes easier.
3394
0b432f21
PE
3395 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3396 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3397 (string_overrun_cookie): Now const. Use initializers that
3398 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3399 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3400 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3401 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3402 multiple of sizeof (EMACS_INT); it need not be, if
3403 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3404 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3405
895009e1
JB
34062011-04-26 Juanma Barranquero <lekktu@gmail.com>
3407
3408 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3409
6a7a1b0b
TZ
34102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3411
3412 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3413 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3414 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3415
841a1577 34162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3417
3418 * lisp.h (Qdebug): List symbol.
895009e1 3419 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3420 * keyboard.c (debug-on-event): New variable.
3421 (handle_user_signal): Break into debugger when debug-on-event
3422 matches the current signal symbol.
3423
f2d3ba6f
DN
34242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3425
3426 * alloc.c (check_sblock, check_string_bytes)
3427 (check_string_free_list): Convert to standard C.
3428
42ce4c63
TZ
34292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3430
3431 * w32.c (emacs_gnutls_push): Fix typo.
3432
825cd63c
EZ
34332011-04-25 Eli Zaretskii <eliz@gnu.org>
3434
fb11d64d
EZ
3435 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3436 "cast to pointer from integer of different size".
3437
825cd63c
EZ
3438 Improve doprnt and its use in verror. (Bug#8545)
3439 * doprnt.c (doprnt): Document the set of format control sequences
3440 supported by the function. Use SAFE_ALLOCA instead of always
3441 using `alloca'.
3442
3443 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3444 is one byte too soon. Don't use xrealloc; instead xfree and
3445 xmalloc anew.
3446
e061a11b
TZ
34472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3448
3449 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3450 callbacks stage.
3451
3452 * gnutls.c: Renamed global_initialized to
3453 gnutls_global_initialized. Added internals for the
3454 :verify-hostname-error, :verify-error, and :verify-flags
3455 parameters of `gnutls-boot' and documented those parameters in the
3456 docstring. Start callback support.
9173deec
JB
3457 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3458 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3459 on error. Return error code.
e061a11b
TZ
3460 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3461 (emacs_gnutls_read): Likewise.
3462 (Fgnutls_boot): Return handshake error code.
3463 (emacs_gnutls_handle_error): New function.
3464 (wsaerror_to_errno): Likewise.
3465
3466 * w32.h (emacs_gnutls_pull): Add prototype.
3467 (emacs_gnutls_push): Likewise.
3468
3469 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3470 (emacs_gnutls_push): Likewise.
3471
34722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3473
3474 * process.c (wait_reading_process_output): Check if GnuTLS
3475 buffered some data internally if no FDs are set for TLS
3476 connections.
3477
3478 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3479 (LIBS): Link to USER_LIBS.
3480 ($(BLD)/gnutls.$(0)): New target.
3481
fa6996bc
EZ
34822011-04-24 Eli Zaretskii <eliz@gnu.org>
3483
eb35682e
EZ
3484 * xdisp.c (handle_single_display_spec): Rename the
3485 display_replaced_before_p argument into display_replaced_p, to
3486 make it consistent with the commentary. Fix typos in the
3487 commentary.
3488
e2ad650c
EZ
3489 * textprop.c (syms_of_textprop): Remove dead code.
3490 (copy_text_properties): Delete obsolete commentary about an
3491 interface that was deleted long ago. Fix typos in the description
3492 of arguments.
3493
1b2de274
EZ
3494 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3495 to changes in oldXMenu/XMenu.h from 2011-04-16.
3496 <menu_help_message, prev_menu_help_message>: Constify.
3497 (IT_menu_make_room): menu->help_text is now `const char **';
3498 adjust.
3499
3500 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3501 to changes in oldXMenu/XMenu.h from 2011-04-16.
3502 (struct XMenu): Declare `help_text' `const char **'.
3503
3504 * xfaces.c <Qunspecified>: Make extern again.
3505
3506 * syntax.c: Include sys/types.h before including regex.h, as
3507 required by Posix.
3508
762b15be
EZ
3509 * doc.c (get_doc_string): Improve the format passed to `error'.
3510
3511 * doprnt.c (doprnt): Improve commentary.
3512
3513 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3514
3515 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3516 them with etags.
3517
f1052e5d
EZ
3518 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3519 changes in globals.h immediately force recompilation.
762b15be
EZ
3520 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3521 $(CURDIR)/s/ms-w32.h.
3522 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3523
fa6996bc
EZ
3524 * character.c (Fchar_direction): Function deleted.
3525 (syms_of_character): Don't defsubr it.
3526 <char-direction-table>: Deleted.
3527
e6c3da20
EZ
35282011-04-23 Eli Zaretskii <eliz@gnu.org>
3529
3530 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3531 * doprnt.c: Include limits.h.
3532 (SIZE_MAX): New macro.
04f2d78b
CB
3533 (doprnt): Return a size_t value. 2nd arg is now size_t.
3534 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3535 Improve overflow protection. Support `l' modifier for integer
3536 conversions. Support %l conversion. Don't assume an EMACS_INT
3537 argument for integer conversions and for %c.
3538
3539 * lisp.h (doprnt): Restore prototype.
3540
3541 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3542 $(SRC)/character.h.
3543
3544 * Makefile.in (base_obj): Add back doprnt.o.
3545
3546 * deps.mk (doprnt.o): Add back prerequisites.
3547 (callint.o): Depend on character.h.
3548
3549 * eval.c (internal_lisp_condition_case): Include the handler
3550 representation in the error message.
3551 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3552 when breaking from the loop.
3553
3554 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3555
3556 * callint.c (Fcall_interactively): When displaying error message
3557 about invalid control letter, pass the character's codepoint, not
3558 a pointer to its multibyte form. Improve display of the character
3559 in octal and display also its hex code.
3560
3561 * character.c (char_string): Use %x to display the (unsigned)
3562 codepoint of an invalid character, to avoid displaying a bogus
3563 negative value.
3564
3565 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3566 `error', not SYMBOL_NAME itself.
3567
3568 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3569 character arguments to `error'.
3570
3571 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3572 to `error' in error message about FINAL_CHAR argument. Make sure
3573 FINAL_CHAR is a character, and use %c when it is passed as
3574 argument to `error'.
3575
4ffd0d6b 35762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3577
3578 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3579
3580 * w32.c: Include <time.h>.
3581 (sys_localtime): New function.
3582
4ffd0d6b 35832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3584
3585 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3586
4ffd0d6b 3587 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3588
4ffd0d6b 35892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3590
4ffd0d6b
GM
3591 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3592 zombies (Bug#8467).
aac0c6e3 3593
04c56954
EZ
35942011-04-19 Eli Zaretskii <eliz@gnu.org>
3595
3596 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3597 gl_state.e_property when gl_state.object is Qt.
3598
3599 * insdel.c (make_gap_larger): Remove limitation of buffer size
3600 to <= INT_MAX.
3601
16a43933
CY
36022011-04-18 Chong Yidong <cyd@stupidchicken.com>
3603
3604 * xdisp.c (lookup_glyphless_char_display)
3605 (produce_glyphless_glyph): Handle cons cell entry in
3606 glyphless-char-display.
3607 (Vglyphless_char_display): Document it.
3608
3609 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3610 glyphless-char-display.
3611
4581706e
CY
36122011-04-17 Chong Yidong <cyd@stupidchicken.com>
3613
3614 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3615
3616 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3617
3618 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3619 definition for no-X builds.
3620
4887c6e2 36212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3622
fd35b6f9
PE
3623 Static checks with GCC 4.6.0 and non-default toolkits.
3624
5c1ccb01
PE
3625 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3626
006c5daa
PE
3627 * process.c (keyboard_bit_set): Define only if SIGIO.
3628 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3629 (send_process): Repair possible setjmp clobbering.
3630
efc736d3
PE
3631 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3632
4e2fe2e6
PE
3633 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3634
f97334a2
PE
3635 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3636
4e75f29d
PE
3637 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3638 Define only if needed.
3639
90efadd1
PE
3640 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3641 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3642 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3643
3c647824
PE
3644 * dispextern.h (struct redisplay_interface): Rename param
3645 to avoid shadowing.
e264f262 3646 * termhooks.h (struct terminal): Likewise.
761383f4 3647 * xterm.c (xembed_send_message): Likewise.
3c647824 3648
b58c5c4a
PE
3649 * insdel.c (make_gap_smaller): Define only if
3650 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3651
cad59032
PE
3652 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3653 it.
3654
c339dc2e
PE
3655 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3656 so that we aren't warned about unused symbols.
3657
91a3e27b
PE
3658 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3659
399c71d3 3660 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3661
8ffc96f5
PE
3662 * xfns.c (x_real_positions): Mark locals as initialized.
3663
eef9bc79
PE
3664 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3665
098db9dd
PE
3666 * xterm.c: Fix problems found by static analysis with other toolkits.
3667 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3668 (x_dispatch_event): Declare static if USE_GTK, and
3669 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3670 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3671 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3672 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3673 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3674
eb18f6cc
PE
3675 * xmenu.c (menu_help_callback): Pointer type fixes.
3676 Use const pointers when pointing at readonly data. Avoid pointer
3677 signedness clashes.
3678 (FALSE): Remove unused macro.
3679 (update_frame_menubar): Remove unused decl.
3680
1fe72bf8
PE
3681 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3682
60d9e1db
PE
3683 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3684 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3685 (single_menu_item): Rename local to avoid shadowing.
3686
39261c26
PE
3687 * keyboard.c (make_lispy_event): Remove unused local var.
3688
018c5e19
PE
3689 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3690 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3691
63d2b86e
PE
3692 * bitmaps: Change bitmaps from unsigned char back to the X11
3693 compatible char. Avoid the old compiler warnings about
3694 out-of-range initializers by using, for example, '\xab' rather
3695 than 0xab.
3696
aefd87e1
PE
3697 * xgselect.c (xgselect_initialize): Check vs interface
3698 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3699
bf501fb9
PE
3700 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3701
e9829fdf
PE
3702 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3703 to read-only memory.
3704
1086c095
PE
3705 * fns.c (vector): Remove; this old hack is no longer needed.
3706
2baccd04 3707 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3708 Remove unused var.
dde42981 3709 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3710
72391843 3711 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3712
436c16df 3713 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3714 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3715 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3716
92bb796d 3717 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3718 (x_term_init): Remove local to avoid shadowing.
92bb796d 3719
764430a3 3720 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3721
3722 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3723 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3724
d1dfb56c
EZ
37252011-04-16 Eli Zaretskii <eliz@gnu.org>
3726
c4354cb4
EZ
3727 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3728
d1dfb56c
EZ
3729 Fix regex.c, syntax.c and friends for buffers > 2GB.
3730 * syntax.h (struct gl_state_s): Declare character position members
3731 EMACS_INT.
3732
3733 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3734
04f2d78b
CB
3735 * textprop.c (verify_interval_modification, interval_of):
3736 Declare arguments EMACS_INT.
d1dfb56c
EZ
3737
3738 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3739 EMACS_INT.
3740
3741 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3742
3743 * indent.c (Fvertical_motion): Local variable it_start is now
3744 EMACS_INT.
3745
3746 * regex.c (re_match, re_match_2, re_match_2_internal)
3747 (bcmp_translate, regcomp, regexec, print_double_string)
3748 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3749 (re_compile_pattern, re_exec): Declare arguments and local
3750 variables `size_t' and `ssize_t' and return values `regoff_t', as
3751 appropriate.
3752 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3753 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3754 <compile_stack_type>: `size' and `avail' are now `size_t'.
3755
3756 * regex.h <regoff_t>: Use ssize_t, not int.
3757 (re_search, re_search_2, re_match, re_match_2): Arguments that
3758 specify buffer/string position and length are now ssize_t and
3759 size_t. Return type is regoff_t.
3760
613052cd
BK
37612011-04-16 Ben Key <bkey76@gmail.com>
3762
3763 * nsfont.m: Fixed bugs in ns_get_family and
3764 ns_descriptor_to_entity that were caused by using free to
3765 deallocate memory blocks that were allocated by xmalloc (via
3766 xstrdup). This caused Emacs to crash when compiled with
3767 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3768 --enable-checking=xmallocoverrun). xfree is now used to
3769 deallocate these memory blocks.
3770
4170f62f 37712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3772
71b41406
PE
3773 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3774
9587a89d
PE
3775 emacs_write: Accept and return EMACS_INT for sizes.
3776 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3777 et seq.
3778 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3779 Accept and return EMACS_INT.
3780 (emacs_gnutls_write): Return the number of bytes written on
3781 partial writes.
3782 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3783 (emacs_read, emacs_write): Remove check for negative size, as the
3784 Emacs source code has been audited now.
9587a89d
PE
3785 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3786 (emacs_read, emacs_write): Use it.
273a5f82
PE
3787 * process.c (send_process): Adjust to the new signatures of
3788 emacs_write and emacs_gnutls_write. Do not attempt to store
3789 a byte offset into an 'int'; it might overflow.
9587a89d 3790 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3791
3e047f51
PE
3792 * sound.c: Don't assume sizes fit in 'int'.
3793 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3794 Return EMACS_INT, not int.
3e047f51 3795 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3796 Accept EMACS_INT, not int.
3797 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3798 record read return values.
3799
cc39a9db
BK
38002011-04-15 Ben Key <bkey76@gmail.com>
3801
c9d0ec6d
JB
3802 * keyboard.c (Qundefined): Don't declare static since it is used
3803 in nsfns.m.
3804 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3805 static since they are used in nsfont.m.
cc39a9db 3806
6c60eb9f
SM
38072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3808
3809 * process.c (Qprocessp): Don't declare static.
3810 * lisp.h (Qprocessp): Declare again.
3811
7990b61a
JB
38122011-04-15 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3815
5d4cb038
PE
38162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3817
8bd7b830 3818 Improve C-level modularity by making more things 'static'.
cd64ea1d 3819
e3b27b31
PE
3820 Don't publish debugger-only interfaces to other modules.
3821 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3822 (verify_bytepos, count_markers): Move decls to the only modules
3823 that need them.
3824 * region-cache.h (pp_cache): Likewise.
3825 * window.h (check_all_windows): Likewise.
3826 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3827
5d4cb038
PE
3828 * sysdep.c (croak): Now static, if
3829 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3830 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3831
3832 * alloc.c (refill_memory_reserve): Now static if
3833 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3834 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3835
e87b6180
PE
3836 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3837 Define only if USE_LUCID.
3838
ac64929e
PE
3839 * xrdb.c (x_customization_string, x_rm_string): Now static.
3840
6f37259d
PE
3841 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3842 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3843
1683e3ab
PE
3844 * xdisp.c (draw_row_with_mouse_face): Now static.
3845 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3846
de9c2632
PE
3847 * window.h (check_all_windows): Mark externally visible.
3848
2b96acb7
PE
3849 * window.c (window_deletion_count): Now static.
3850
3851 * undo.c: Make symbols static if they're not exported.
3852 (last_undo_buffer, last_boundary_position, pending_boundary):
3853 Now static.
3854
50436f33
PE
3855 * textprop.c (interval_insert_behind_hooks): Now static.
3856 (interval_insert_in_front_hooks): Likewise.
3857
64520e5c
PE
3858 * term.c: Make symbols static if they're not exported.
3859 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3860 (max_frame_lines, tty_set_terminal_modes):
3861 (tty_reset_terminal_modes, tty_turn_off_highlight):
3862 (get_tty_terminal): Now static.
3863 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3864 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3865 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3866 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3867 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3868
1fa53021
PE
3869 * sysdep.c: Make symbols static if they're not exported.
3870 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3871 Now static.
3872 (sigprocmask_set, full_mask): Remove; unused.
3873 (wait_debugging): Mark as visible.
3874 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3875 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3876
d4b43b22
PE
3877 * syntax.c (syntax_temp): Define only if !__GNUC__.
3878
b7c513d0
PE
3879 * sound.c (current_sound_device, current_sound): Now static.
3880
989b29ad
PE
3881 * search.c (searchbufs, searchbuf_head): Now static.
3882
13a55a78
PE
3883 * scroll.c (scroll_cost): Remove; unused.
3884 * dispextern.h (scroll_cost): Remove decl.
3885
de68a1fc
PE
3886 * region-cache.h (pp_cache): Mark as externally visible.
3887
40ccffa6
PE
3888 * process.c: Make symbols static if they're not exported.
3889 (process_tick, update_tick, create_process, chan_process):
3890 (Vprocess_alist, proc_buffered_char, datagram_access):
3891 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3892 (deactivate_process): Mark defn as static, as well as decl.
3893 * lisp.h (create_process): Remove decl.
3894 * process.h (chan_process, Vprocess_alist): Remove decls.
3895
ad64fc97
PE
3896 * print.c: Make symbols static if they're not exported.
3897 (print_depth, new_backquote_output, being_printed, print_buffer):
3898 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3899 (print_interval, print_number_index, initial_stderr_stream):
3900 Now static.
3901 * lisp.h (Fprinc): Remove decl.
3902 (debug_output_compilation_hack): Mark as externally visible.
3903
adddb265
PE
3904 * sysdep.c (croak): Move decl from here to syssignal.h.
3905 * syssignal.h (croak): Put it here, so the API can be checked when
3906 'croak' is called from dissociate_if_controlling_tty.
3907
1717ede2
PE
3908 * minibuf.c: Make symbols static if they're not exported.
3909 (minibuf_save_list, choose_minibuf_frame): Now static.
3910 * lisp.h (choose_minibuf_frame): Remove decl.
3911
fa5fb2bc
PE
3912 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3913
1e3890d1
PE
3914 * lread.c: Make symbols static if they're not exported.
3915 (read_objects, initial_obarray, oblookup_last_bucket_number):
3916 Now static.
3917 (make_symbol): Remove; unused.
3918 * lisp.h (initial_obarray, make_symbol): Remove decls.
3919
8a1414fa
PE
3920 * keyboard.c: Make symbols static if they're not exported.
3921 (single_kboard, recent_keys_index, total_keys, recent_keys):
3922 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3923 (this_single_command_key_start, echoing, last_auto_save):
3924 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3925 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3926 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3927 (Vlispy_mouse_stem, double_click_count):
3928 Now static.
3929 (force_auto_save_soon): Define only if SIGDANGER.
3930 (ignore_mouse_drag_p): Now static if
3931 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3932 (print_help): Remove; unused.
3933 (stop_character, last_timer_event): Mark as externally visible.
3934 * keyboard.h (ignore_mouse_drag_p): Declare only if
3935 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3936 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3937 * lisp.h (echoing): Remove decl.
3938 (force_auto_save_soon): Declare only if SIGDANGER.
3939 * xdisp.c (redisplay_window): Simplify code, to make it more
3940 obvious that ignore_mouse_drag_p is not accessed if !defined
3941 USE_GTK && !defined HAVE_NS.
3942
93ea6e8f
PE
3943 * intervals.c: Make symbols static if they're not exported.
3944 (merge_properties_sticky, merge_interval_right, delete_interval):
3945 Now static.
3946 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3947
77382fcc
PE
3948 * insdel.c: Make symbols static if they're not exported.
3949 However, leave prepare_to_modify_buffer alone. It's never
3950 called from outside this function, but that appears to be a bug.
3951 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3952 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3953 (adjust_after_replace_noundo): Remove; unused.
3954 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3955 (signal_before_change): Remove decls.
77382fcc 3956
9306c32e
PE
3957 * indent.c (val_compute_motion, val_vmotion): Now static.
3958
cd44d2eb
PE
3959 * image.c: Make symbols static if they're not exported.
3960 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3961 if USE_GTK.
3962 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3963 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3964
ad9a7a06
PE
3965 * fringe.c (standard_bitmaps): Now static.
3966 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3967
81626931
PE
3968 * frame.c: Make symbols static if they're not exported.
3969 (x_report_frame_params, make_terminal_frame): Now static.
3970 (get_frame_param): Now static, unless HAVE_NS.
3971 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3972 (x_get_resource_string): Remove; not used.
3973 * frame.h (make_terminal_frame, x_report_frame_params):
3974 (x_get_resource_string); Remove decls.
3975 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3976 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3977
239f9db9
PE
3978 * font.c, fontset.c: Make symbols static if they're not exported.
3979 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3980 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3981 * font.c (font_close_object): Now static.
3982 * font.h (font_close_object): Remove.
3983 * fontset.c (FONTSET_OBJLIST): Remove.
3984 (free_realized_fontset) #if-0 the body, which does nothing.
3985 (face_suitable_for_char_p): #if-0, as it's never called.
3986 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3987 * xfaces.c (face_at_string_position):
3988 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3989 since 0 is always ASCII.
3990
dfcf3579
PE
3991 * fns.c (weak_hash_tables): Now static.
3992
5045092b
PE
3993 * fileio.c: Make symbols static if they're not exported.
3994 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3995 (Vwrite_region_annotation_buffers): Now static.
3996
57a96f5c
PE
3997 * eval.c: Make symbols static if they're not exported.
3998 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3999 * lisp.h (backtrace_list): Remove decl.
4000
35f08c38
PE
4001 * emacs.c: Make symbols static if they're not exported.
4002 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4003 (fatal_error_code, fatal_error_signal_hook, standard_args):
4004 Now static.
4005 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4006 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4007 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4008 * lisp.h (fatal_error_signal_hook): Remove decl.
4009 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4010
f44bd759
PE
4011 * editfns.c: Move a (normally-unused) function to its only use.
4012 * editfns.c, lisp.h (get_operating_system_release): Remove.
4013 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4014 worth the hassle of breaking this out.
4015
b532497d
PE
4016 * xterm.c: Make symbols static if they're not exported.
4017 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4018 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4019 (x_destroy_window, x_delete_display):
4020 Now static.
4021 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4022 (x_mouse_leave): Remove; unused.
4023 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4024 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4025 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4026 Remove decls.
4027 (x_mouse_leave): Declare only if WINDOWSNT.
4028 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4029 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4030 USE_X_TOOLKIT.
4031
1675728f
PE
4032 * ftxfont.c: Make symbols static if they're not exported.
4033 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4034 HAVE_FREETYPE.
4035 * font.h (ftxfont_driver): Likewise.
4036
e4cebfca
PE
4037 * xfns.c: Make symbols static if they're not exported.
4038 (x_last_font_name, x_display_info_for_name):
4039 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4040 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4041 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4042 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4043 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4044 (last_show_tip_args): Now static.
4045 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4046 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4047 (x_screen_planes): Remove; unused.
4048 * dispextern.h (x_screen_planes): Remove decl.
4049
5bf46f05
PE
4050 * dispnew.c: Make symbols static if they're not exported.
4051 * dispextern.h (redraw_garbaged_frames, scrolling):
4052 (increment_row_positions): Remove.
4053 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4054 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4055 Now static.
4056 (redraw_garbaged_frames): Remove; unused.
4057
435f4c28
PE
4058 * xfaces.c: Make symbols static if they're not exported.
4059 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4060 Remove decls.
4061 * xterm.h (defined_color): Remove decls.
4062 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4063 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4064 (menu_face_changed_default, defined_color, free_realized_face):
4065 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4066 (ascii_face_of_lisp_face): Remove; unused.
4067
8524aef3
PE
4068 * xdisp.c: Make symbols static if they're not exported.
4069 * dispextern.h (scratch_glyph_row, window_box_edges):
4070 (glyph_to_pixel_coords, set_cursor_from_row):
4071 (get_next_display_element, set_iterator_to_next):
4072 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4073 (show_mouse_face): Remove decls
4074 * frame.h (message_buf_print): Likewise.
4075 * lisp.h (pop_message, set_message, check_point_in_composition):
4076 Likewise.
4077 * xterm.h (set_vertical_scroll_bar): Likewise.
4078 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4079 (message_buf_print, scratch_glyph_row, displayed_buffer):
4080 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4081 (get_next_display_element, show_mouse_face, window_box_edges):
4082 (frame_to_window_pixel_xy, check_point_in_composition):
4083 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4084 (glyph_to_pixel_coords): Remove; unused.
4085
16390cd2
PE
4086 * dired.c (file_name_completion): Now static.
4087
4088 * dbusbind.c (xd_in_read_queued_messages): Now static.
4089
a25f4dfa
PE
4090 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4091 * data.c (circular_list_error): Remove.
4092
14a9c8df
PE
4093 * commands.h (last_point_position, last_point_position_buffer):
4094 (last_point_position_window): Remove decls.
4095 * keyboard.c: Make these variables static.
4096
04f2d78b
CB
4097 * coding.h (coding, code_convert_region, encode_coding_gap):
4098 Remove decls.
74ab6df5
PE
4099 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4100 (iso_code_class, detect_coding, code_convert_region): Now static.
4101 (encode_coding_gap): Remove; unused.
4102
38dfbee1
PE
4103 * chartab.c (chartab_chars, chartab_bits): Now static.
4104
a2cb4e63
PE
4105 * charset.h (charset_iso_8859_1): Remove decl.
4106 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4107 Now static.
4108
127198fd
PE
4109 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4110 * ccl.c (Vccl_program_table): Now static.
4111 (check_ccl_update): Remove; unused.
4112
d85b608f
PE
4113 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4114 * category.h: ... from here.
4115 * category.c (check_category_table, set_category_set): Now static.
4116
31cd66f3
PE
4117 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4118 * lisp.h: Remove these decls.
4119
c358e587
PE
4120 * buffer.c (buffer_count): Remove unused var.
4121
e78aecca
PE
4122 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4123 so that it's not optimized away.
4124 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4125 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4126 exported only to the debugger.
4127
e192d7d3 4128 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4129 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4130
92470028
PE
4131 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4132 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4133 was inaccessible from Lisp.
4134 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4135 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4136
244ed907
PE
4137 alloc.c: Import and export fewer symbols, and remove unused items.
4138 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4139 is defined.
4140 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4141 it's not optimized away by whole-program optimization.
4142 (message_enable_multibyte, free_misc): Remove.
4143 (catchlist, handlerlist, mark_backtrace):
4144 Declare only if BYTE_MARK_STACK.
4145 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4146 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4147 (message_enable_multibyte): Remove decl.
4148 (free_misc, interval_free_list, float_block, float_block_index):
4149 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4150 (cons_free_list, last_marked_index):
4151 Now static.
4152 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4153 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4154 (mark_backtrace): Define only if BYTE_MARK_STACK.
4155 * xdisp.c (message_enable_multibyte): Now static.
4156
61c2b50e 4157 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4158 This makes it easier for human readers (and static analyzers)
4159 to see whether these variables are used from other modules.
4160 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4161 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4162 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4163 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4164 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4165 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4166 * xmenu.c, xselect.c:
4167 Declare Q* vars static if they are not used in other modules.
4168 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4169 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4170 Remove decls of unexported vars.
4171 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4172
95c82688
PE
4173 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4174
16a97296
PE
4175 Make Emacs functions such as Fatom 'static' by default.
4176 This makes it easier for human readers (and static analyzers)
4177 to see whether these functions can be called from other modules.
4178 DEFUN now defines a static function. To make the function external
4179 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4180 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4181 (Finit_image_library):
16a97296
PE
4182 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4183 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4184 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4185 Remove decls, since these functions are now static.
4186 (Funintern, Fget_internal_run_time): New decls, since these functions
4187 were already external.
95c82688 4188
16a97296
PE
4189 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4190 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4191 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4192 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4193 * keyboard.c, keymap.c, lread.c:
4194 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4195 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4196 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4197 Mark functions with DEFUE instead of DEFUN,
4198 if they are used in other modules.
4199 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4200 decls for now-static functions.
4201 * buffer.h (Fdelete_overlay): Remove decl.
4202 * callproc.c (Fgetenv_internal): Mark as internal.
4203 * composite.c (Fremove_list_of_text_properties): Remove decl.
4204 (Fcomposition_get_gstring): New forward static decl.
4205 * composite.h (Fcomposite_get_gstring): Remove decl.
4206 * dired.c (Ffile_attributes): New forward static decl.
4207 * doc.c (Fdocumntation_property): New forward static decl.
4208 * eval.c (Ffetch_bytecode): New forward static decl.
4209 (Funintern): Remove extern decl; now in .h file where it belongs.
4210 * fileio.c (Fmake_symbolic_link): New forward static decl.
4211 * image.c (Finit_image_library): New forward static decl.
4212 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4213 * intervals.h (Fprevious_property_change):
4214 (Fremove_list_of_text_properties): Remove decls.
4215 * keyboard.c (Fthis_command_keys): Remove decl.
4216 (Fcommand_execute): New forward static decl.
4217 * keymap.c (Flookup_key): New forward static decl.
4218 (Fcopy_keymap): Now static.
4219 * keymap.h (Flookup_key): Remove decl.
4220 * process.c (Fget_process): New forward static decl.
4221 (Fprocess_datagram_address): Mark as internal.
4222 * syntax.c (Fsyntax_table_p): New forward static decl.
4223 (skip_chars): Remove duplicate decl.
4224 * textprop.c (Fprevious_property_change): New forward static decl.
4225 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4226 Now internal.
4227 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4228 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4229
785bbd42
PE
4230 * editfns.c (Fformat): Remove unreachable code.
4231
8b913b57
AS
42322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4233
4234 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4235 change. (Bug#8496)
4236
a6744a35
EZ
42372011-04-13 Eli Zaretskii <eliz@gnu.org>
4238
4239 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4240 when at ZV. (Bug#8487)
4241
e7974947
AS
42422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4243
baad03f0
AS
4244 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4245 (Bug#8437)
4246 * keyboard.c (parse_tool_bar_item): Likewise.
4247 * sound.c (sound_cleanup, alsa_close): Likewise.
4248 * termcap.c (tgetent): Likewise.
4249 * xfns.c (x_default_font_parameter): Likewise.
4250 * xsettings.c (read_and_apply_settings): Likewise.
4251
e7974947
AS
4252 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4253 (overrun_check_free): Protoize.
4254
28272684
PE
42552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4258 since callers should never pass a negative size.
4259 Change the signature to match that of plain 'read' and 'write'; see
4260 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4261 * lisp.h: Update prototypes of emacs_write and emacs_read.
4262
11997c76
EZ
42632011-04-11 Eli Zaretskii <eliz@gnu.org>
4264
4265 * xdisp.c (redisplay_window): Don't try to determine the character
4266 position of the scroll margin if the window start point w->startp
e896f03c 4267 is outside the buffer's accessible region. (Bug#8468)
11997c76 4268
8a2cbd72
EZ
42692011-04-10 Eli Zaretskii <eliz@gnu.org>
4270
4271 Fix write-region and its subroutines for buffers > 2GB.
4272 * fileio.c (a_write, e_write): Modify declaration of arguments and
4273 local variables to support buffers larger than 2GB.
4274 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4275
4276 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4277 argument, local variables, and return value.
4278
4279 * lisp.h: Update prototypes of emacs_write and emacs_read.
4280
4281 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4282
4073e537 42832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4284
1ebfdcb6
PE
4285 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4286
b2ded58d
PE
4287 Fix more problems found by GCC 4.6.0's static checks.
4288
7d66342c
PE
4289 * xdisp.c (vmessage): Use a better test for character truncation.
4290
bbf47d44
PE
4291 * charset.c (load_charset_map): <, not <=, for optimization,
4292 and to avoid potential problems with integer overflow.
9248994d 4293 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4294 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4295 * editfns.c (Fformat): Likewise.
1e69125e 4296 * syntax.c (skip_chars): Likewise.
3befa583 4297
e3019616
PE
4298 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4299 This also lets GCC 4.6.0 generate slightly better loop code.
4300
becfa255
PE
4301 * callint.c (Fcall_interactively): <, not <=, for optimization.
4302 (Fcall_interactively): Count the number of arguments produced,
4303 not the number of arguments given. This is simpler and lets GCC
4304 4.6.0 generate slightly better code.
4305
dae0cd48
PE
4306 * ftfont.c: Distingish more carefully between FcChar8 and char.
4307 The previous code passed unsigned char * to a functions like
4308 strlen and xstrcasecmp that expect char *, which does not
4309 conform to the C standard.
4310 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4311 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4312 char * when the C standard requires it.
4313
76032d70
PE
4314 * keyboard.c (read_char): Remove unused var.
4315
eb3f1cc8
PE
4316 * eval.c: Port to Windows vsnprintf (Bug#8435).
4317 Include <limits.h>.
4318 (SIZE_MAX): Define if the headers do not.
4319 (verror): Do not give up if vsnprintf returns a negative count.
4320 Instead, grow the buffer. This ports to Windows vsnprintf, which
4321 does not conform to C99. Problem reported by Eli Zaretskii.
4322 Also, simplify the allocation scheme, by avoiding the need for
4323 calling realloc, and removing the ALLOCATED variable.
4324
70476b54
PE
4325 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4326
12020a9e
PE
4327 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4328 But keep the doprint source code for now, as we might revamp it
4329 and use it again (Bug#8435).
ea6c7ae6
PE
4330 * lisp.h (doprnt): Remove.
4331 * Makefile.in (base_obj): Remove doprnt.o.
4332 * deps.mk (doprnt.o): Remove.
4333
5fdb398c
PE
4334 error: Print 32- and 64-bit integers portably (Bug#8435).
4335 Without this change, on typical 64-bit hosts error ("...%d...", N)
4336 was used to print both 32- and 64-bit integers N, which relied on
4337 undefined behavior.
4338 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4339 New macro.
4340 * lisp.h (error, verror): Mark as printf-like functions.
4341 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4342 Report overflow in size calculations when allocating printf buffer.
4343 Do not truncate output string at its first null byte.
4344 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4345 Truncate the output at a character boundary, since vsnprintf does not
4346 do that.
4347 * charset.c (check_iso_charset_parameter): Convert internal
4348 character to string before calling 'error', since %c now has the
4349 printf meaning.
4350 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4351 overflow when computing char to be passed to 'error'. Do not
4352 pass Lisp_Object to 'error'; pass the integer instead.
4353 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4354 formatted with plain %d.
4355
b189fa66
PE
4356 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4357
bff87ef0
PE
4358 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4359
7e2cac20
PE
4360 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4361
ce4d90b5
PE
4362 * xterm.c (x_catch_errors): Remove duplicate declaration.
4363
266c9547
PE
4364 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4365
79c49ad2
PE
4366 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4367
368f4090
JM
43682011-04-10 Jim Meyering <meyering@redhat.com>
4369
4370 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4371 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4372 return ssize_t not "int", and use size_t as the buffer length.
4373 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4374 * gnutls.h: Update declarations.
4375 * process.c (read_process_output): Use ssize_t, to match.
4376 (send_process): Likewise.
4377
a32d4040
CY
43782011-04-09 Chong Yidong <cyd@stupidchicken.com>
4379
4380 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4381
8546720e 43822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4383
04f2d78b
CB
4384 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4385 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4386
8546720e
GM
4387 * xterm.c (handle_one_xevent):
4388 * xmenu.c (create_and_show_popup_menu):
4389 * xselect.c (x_decline_selection_request)
4390 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4391
0a2f5c1a 43922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4393
4394 Fix some uses of `int' instead of EMACS_INT.
4395 * search.c (string_match_1, fast_string_match)
4396 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4397 (scan_buffer, find_next_newline_no_quit)
4398 (find_before_next_newline, search_command, Freplace_match)
4399 (Fmatch_data): Make some `int' variables be EMACS_INT.
4400
4401 * xdisp.c (display_count_lines): 3rd argument and return value now
4402 EMACS_INT. All callers changed.
4403 (pint2hrstr): Last argument is now EMACS_INT.
4404
4405 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4406 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4407 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4408 (decode_coding_utf_16, decode_coding_emacs_mule)
4409 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4410 (decode_coding_ccl, decode_coding_charset)
4411 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4412 (decode_coding_iso_2022, decode_coding_emacs_mule)
4413 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4414 <char_offset, last_offset>: Declare EMACS_INT.
4415 (encode_coding_utf_8, encode_coding_utf_16)
4416 (encode_coding_emacs_mule, encode_invocation_designation)
4417 (encode_designation_at_bol, encode_coding_iso_2022)
4418 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4419 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4420 Declare EMACS_INT.
4421 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4422 (encode_invocation_designation): Last argument P_NCHARS is now
4423 EMACS_INT.
4424 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4425 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4426
4427 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4428 All users changed.
4429
4430 * ccl.c (Fccl_execute_on_string): Declare some variables
4431 EMACS_INT.
4432
8546720e 44332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4434
4435 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4436
4e19a977
CS
44372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4438
4439 * process.c (Fformat_network_address): Doc fix.
4440
87302331
R
44412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4442
4443 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4444
cbb59342
CY
44452011-04-08 Chong Yidong <cyd@stupidchicken.com>
4446
4447 * keyboard.c (read_char): Call Lisp function help-form-show,
4448 instead of using internal_with_output_to_temp_buffer.
4449 (Qhelp_form_show): New var.
e0d38eeb 4450 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4451
4452 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4453
4454 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4455
e67a13ab
CY
44562011-04-06 Chong Yidong <cyd@stupidchicken.com>
4457
04f2d78b
CB
4458 * process.c (Flist_processes): Remove to Lisp.
4459 (list_processes_1): Delete.
e67a13ab 4460
973f782d
EZ
44612011-04-06 Eli Zaretskii <eliz@gnu.org>
4462
7c106b1e
EZ
4463 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4464
973f782d
EZ
4465 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4466
41cf7d1a 44672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4468
ca23cc88
PE
4469 Fix more problems found by GCC 4.6.0's static checks.
4470
f390e2d5
PE
4471 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4472
42eea0d0
PE
4473 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4474
b69769da 4475 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4476
f9541e84
PE
4477 * xdisp.c (vmessage): Mark as a printf-like function.
4478
13841b55
PE
4479 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4480
c136c10f
PE
4481 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4482
5e2d4a30
PE
4483 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4484 printf-like functions.
4485 (tiff_load): Add casts to remove these marks before passing them
4486 to system-supplied API.
4487
583f48b9
PE
4488 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4489
b25d760e
PE
4490 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4491 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4492 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4493 directly, rather than having caller test rule sign. This avoids
4494 some unnecessary tests.
4495 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4496 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4497 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4498
bc7b6697 4499 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4500 (xfont_open): Avoid unnecessary tests.
bc7b6697 4501
27ccc379
PE
4502 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4503
dcd5c89a
PE
4504 * composite.h, composite.c (composition_gstring_put_cache):
4505 Use EMACS_INT, not int, for length.
4506
b13a45c6
PE
4507 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4508 breaking out part of COMPOSITION_DECODE_RULE.
4509 (COMPOSITION_DECODE_RULE): Use it.
4510 * composite.c (get_composition_id): Remove unused local vars,
4511 by using the new macro.
4512
1e792e4d
PE
4513 * textprop.c (set_text_properties_1): Change while to do-while,
4514 since the condition is always true at first.
4515
dc6c6455 4516 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4517 (interval_deletion_adjustment): Return unsigned value.
4518 All uses changed.
dc6c6455 4519
aba7731a
PE
4520 * process.c (list_processes_1, create_pty, read_process_output):
4521 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4522 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4523 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4524 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4525 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4526
fdfc4bf3
PE
4527 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4528
fca8fe46 4529 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4530 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4531
06a0259a 4532 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4533 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4534 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4535
e7b9e80f
PE
4536 * print.c (print_error_message): Avoid int overflow.
4537
56201685
PE
4538 * font.c (font_list_entities): Redo for clarity,
4539 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4540
78834453 4541 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4542 (font_score): Avoid potential overflow in diff calculation.
78834453 4543
0bc0b309 4544 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4545 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4546
e610eaca
PE
4547 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4548
b895abce
PE
4549 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4550 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4551 can always succeed if overflow has undefined behavior.
4552
1f1d9321 4553 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4554 (wordify): Omit three unnecessary tests.
1f1d9321 4555
c59478bc
PE
4556 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4557 All callers changed. This avoids the need for an unused var.
4558
79b73827
PE
4559 * casefiddle.c (casify_region): Remove var that is set but not used.
4560
a4db5dfe
PE
4561 * dired.c (file_name_completion): Remove var that is set but not used.
4562
43aae36e
PE
4563 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4564
2a47c44d 4565 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4566 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4567
a37c69bf
PE
4568 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4569 Check for integer overflow on size calculations.
4570
328ab8e7
PE
4571 * buffer.c (Fprevious_overlay_change): Remove var that is set
4572 but not used.
4573
e5a2a5cb
PE
4574 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4575 Remove vars that are set but not used.
8d84a6eb 4576 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4577 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4578
a60e5f68
PE
4579 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4580
f661cb61 4581 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4582 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4583
f0397f5a
PE
4584 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4585 that are set but not used.
4586
8664db06 4587 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4588 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4589
6abdaa4a
PE
4590 * xselect.c (x_get_local_selection, x_handle_property_notify):
4591 Remove vars that are set but not used.
4592
0ce7538d 4593 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4594 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4595
9ae848fc
PE
4596 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4597 Remove var that is set but not used.
0b918413
PE
4598 (scroll_bar_windows_size): Now size_t, not int.
4599 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4600 Check for overflow.
9ae848fc 4601
a5a62657
PE
4602 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4603 (map_tty_color) [!defined MSDOS]: Likewise.
4604
5c5cdd39
PE
4605 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4606
66ebf983
PE
4607 * coding.c: Remove vars that are set but not used.
4608 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4609 All callers changed.
4610 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4611 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4612 (decode_coding_charset): Remove vars that are set but not used.
4613
1be4d761
PE
4614 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4615 that is set but not used.
4616
47553fa8
PE
4617 * print.c (print_object): Remove var that is set but not used.
4618
1f7196bf 4619 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4620 The gnulib version avoids calling malloc in the usual case,
4621 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4622 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4623 * filelock.c (current_lock_owner): Likewise.
4624 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4625 * sysdep.c: Include allocator.h, careadlinkat.h.
4626 (emacs_no_realloc_allocator): New static constant.
4627 (emacs_readlink): New function.
fdb61804
PE
4628 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4629 ../lib/careadlinkat.h.
d1fdcab7 4630
f84c17c7
SM
46312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4632
4633 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4634 first non-nil return value).
4635
ef3862ad
JD
46362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4637
4638 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4639 if not defined (Bug#8403).
4640
376a7006
JB
46412011-04-02 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * xdisp.c (display_count_lines): Remove parameter `start',
4644 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4645 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4646 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4647 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4648 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4649 and thereabouts. All callers changed.
4650 (get_per_char_metric): Remove parameter `f', unused since
4651 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4652
6ca3801d
JM
46532011-04-02 Jim Meyering <meyering@redhat.com>
4654
4655 do not dereference NULL upon failed strdup
4656 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4657 (ns_get_family): Likewise.
4658
d8e2b5ba
JB
46592011-04-02 Juanma Barranquero <lekktu@gmail.com>
4660
4661 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4662
8c74fcbd
JD
46632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4664
4665 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4666 later (Bug#8403).
4667
7200d79c
SM
46682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4669
03408648 4670 Add lexical binding.
7200d79c 4671
03408648
SM
4672 * window.c (Ftemp_output_buffer_show): New fun.
4673 (Fsave_window_excursion):
4674 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4675
4676 * lread.c (lisp_file_lexically_bound_p): New function.
4677 (Fload): Bind Qlexical_binding.
4678 (readevalloop): Remove `evalfun' arg.
4679 Bind Qinternal_interpreter_environment.
4680 (Feval_buffer): Bind Qlexical_binding.
4681 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4682 Mark as dynamic.
4683 (syms_of_lread): Declare `lexical-binding'.
4684
4685 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4686
4687 * keyboard.c (eval_dyn): New fun.
4688 (menu_item_eval_property): Use it.
ca105506
SM
4689
4690 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4691
03408648
SM
4692 * fns.c (concat, mapcar1): Accept byte-code-functions.
4693
4694 * eval.c (Fsetq): Handle lexical vars.
4695 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4696 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4697 (FletX, Flet): Obey lexical binding.
4698 (Fcommandp): Handle closures.
4699 (Feval): New `lexical' arg.
4700 (eval_sub): New function extracted from Feval. Use it almost
4701 everywhere where Feval was used. Look up vars in lexical env.
4702 Handle closures.
4703 (Ffunctionp): Move from subr.el.
4704 (Ffuncall): Handle closures.
4705 (apply_lambda): Remove `eval_flags'.
4706 (funcall_lambda): Handle closures and new byte-code-functions.
4707 (Fspecial_variable_p): New function.
4708 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4709 but without exporting it to Lisp.
23aba0ea 4710
23aba0ea 4711 * doc.c (Fdocumentation, store_function_docstring):
03408648 4712 * data.c (Finteractive_form): Handle closures.
23aba0ea 4713
03408648
SM
4714 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4715 interactive spec.
ba83908c 4716
04f2d78b
CB
4717 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4718 New byte-codes.
03408648
SM
4719 (exec_byte_code): New function extracted from Fbyte_code to handle new
4720 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4721
03408648 4722 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4723
03408648 4724 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4725
e2abce01
JB
47262011-03-31 Juanma Barranquero <lekktu@gmail.com>
4727
4728 * xdisp.c (redisplay_internal): Fix prototype.
4729
63696a73 47302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4731
63696a73 4732 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4733 (try_scrolling): Use it when setting scroll_limit.
4734 Limit scrolling to 100 screen lines.
63696a73
EZ
4735 (redisplay_window): Even when falling back on "recentering",
4736 position point in the window according to scroll-conservatively,
4737 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4738
4739 (try_scrolling): When point is above the window, allow searching
4740 as far as scroll_max, or one screenful, to compute vertical
4741 distance from PT to the scroll margin position. This prevents
4742 try_scrolling from unnecessarily failing when
4743 scroll-conservatively is set to a value slightly larger than the
4744 window height. Clean up the case of PT below the margin at bottom
4745 of window: scroll_max can no longer be INT_MAX. When aggressive
4746 scrolling is in use, don't let point enter the opposite scroll
4747 margin as result of the scroll.
4748 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4749 threshold of 100 lines for never-recentering scrolling.
4750
e4cc2dfc
JB
47512011-03-31 Juanma Barranquero <lekktu@gmail.com>
4752
4753 * dispextern.h (move_it_by_lines):
4754 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4755 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4756 (message_log_check_duplicate): Remove parameters `prev_bol' and
4757 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4758 (redisplay_internal): Remove parameter `preserve_echo_area',
4759 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4760
4761 * indent.c (Fvertical_motion):
4762 * window.c (window_scroll_pixel_based, Frecenter):
4763 Don't pass `need_y_p' to `move_it_by_lines'.
4764
1c470562
SM
47652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4766
44f230aa
SM
4767 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4768 steal a few bits to be more compact.
4769 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4770 Remove unneeded casts.
4771
1c470562
SM
4772 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4773
888adce9
ZK
47742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4775
4776 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4777 binding" message (bug#7967).
4778
f838ed7b
PE
47792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4780
77861b95
PE
4781 Fix more problems found by GCC 4.6.0's static checks.
4782
de6dbc14
PE
4783 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4784 Remove unused local var.
4785
f838ed7b
PE
4786 * editfns.c (Fmessage_box): Remove unused local var.
4787
792c7b2b
PE
4788 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4789 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4790 Omit unused local vars.
c499e557 4791 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4792 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4793 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4794 Omit unused local var.
4795
ba0165e1
PE
4796 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4797 Don't assume string length fits in int.
32ad8845 4798 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4799 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4800
3c59b4c9
PE
4801 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4802 instead of alloca (Bug#8344).
4803
a3eed478 4804 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4805 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4806
eb4d412d
PE
4807 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4808
1658b401
PE
4809 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4810 concerns.
4811
4812 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4813
4814 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4815
9a2c6e05
PE
4816 * keyboard.c (syms_of_keyboard): Use the same style as later
4817 in this function when indexing through an array. This also
4818 works around GCC bug 48267.
4819
03d0a109
PE
4820 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4821
44f730c8
PE
4822 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4823
fe75f926
PE
4824 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4825 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4826
ffa8c828
PE
4827 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4828 This avoids undefined behavior on integer overflow, and is a bit
4829 more convenient anyway since it is compared to a size_t variable.
4830
c5101a77
PE
4831 Variadic C functions now count arguments with size_t, not int.
4832 This avoids an unnecessary limitation on 64-bit machines, which
4833 caused (substring ...) to crash on large vectors (Bug#8344).
4834 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4835 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4836 All variadic functions and their callers changed accordingly.
c5101a77
PE
4837 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4838 * data.c (arith_driver, float_arith_driver): Likewise.
4839 * editfns.c (general_insert_function): Likewise.
4840 * eval.c (struct backtrace.nargs, interactive_p)
4841 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4842 (funcall_lambda, mark_backtrace): Likewise.
4843 * fns.c (concat): Likewise.
4844 * frame.c (x_set_frame_parameters): Likewise.
4845 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4846 0 if not found, not -1. All callers changed.
4847
dd3f25f7
PE
4848 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4849 (stack_copy_size): Now size_t, not int.
4850 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4851
461c2ab9
JB
48522011-03-28 Juanma Barranquero <lekktu@gmail.com>
4853
4854 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4855 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4856 All callers changed.
4857
4858 * lisp.h (multibyte_char_to_unibyte):
4859 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4860 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4861 * character.h (CHAR_TO_BYTE8):
4862 * cmds.c (internal_self_insert):
4863 * editfns.c (general_insert_function):
4864 * keymap.c (push_key_description):
4865 * search.c (Freplace_match):
4866 * xdisp.c (message_dolog, set_message_1): All callers changed.
4867
f6d62986
SM
48682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4869
4870 * keyboard.c (safe_run_hook_funcall): New function.
4871 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4872 don't set the hook to nil, but remove the offending function instead.
4873 (Qcommand_hook_internal): Remove, unused.
4874 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4875 Vcommand_hook_internal.
4876
4877 * eval.c (enum run_hooks_condition): Remove.
4878 (funcall_nil, funcall_not): New functions.
4879 (run_hook_with_args): Call each function through a `funcall' argument.
4880 Remove `cond' argument, now redundant.
4881 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4882 (Frun_hook_with_args_until_failure): Adjust accordingly.
4883 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4884
1db5b1ad
JB
48852011-03-28 Juanma Barranquero <lekktu@gmail.com>
4886
4887 * dispextern.h (string_buffer_position): Remove declaration.
4888
4889 * print.c (strout): Remove parameter `multibyte', unused since
4890 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4891
4892 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4893 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4894 All callers changed.
4895
4896 * w32.c (_wsa_errlist): Use braces for struct initializers.
4897
4898 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4899 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4900 All callers changed.
4901 (string_buffer_position): Likewise. Also, make static (it's never
4902 used outside xdisp.c).
4903 (cursor_row_p): Remove parameter `w', unused since
4904 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4905 (decode_mode_spec): Remove parameter `precision', introduced during
4906 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4907 All callers changed.
4908
5ffb62aa
JD
49092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4910
4911 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4912
461c2ab9 49132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4914
4915 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4916 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4917 (ns_update_auto_hide_menu_bar): New functions.
4918 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4919 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4920 ns_constrain_all_frames.
4921 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4922 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4923
5c380ffb
JD
49242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4925
4926 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4927
9af30bdf
GM
49282011-03-27 Glenn Morris <rgm@gnu.org>
4929
4930 * syssignal.h: Replace RETSIGTYPE with void.
4931 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4932 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4933 Replace SIGTYPE with void everywhere.
4934 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4935 * s/template.h (SIGTYPE): Remove commented out definition.
4936
e2abce01
JB
49372011-03-26 Eli Zaretskii <eliz@gnu.org>
4938
4939 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4940 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4941
f868cd8a
JB
49422011-03-26 Juanma Barranquero <lekktu@gmail.com>
4943
59eb0929
JB
4944 * w32.c (read_unc_volume): Use parameter `henum', instead of
4945 global variable `wget_enum_handle'.
4946
4947 * keymap.c (describe_vector): Remove parameters `indices' and
4948 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4949 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4950
f868cd8a
JB
4951 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4952
4953 * keyboard.c (timer_check): Remove parameter `do_it_now',
4954 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4955 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4956 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4957
4958 * keyboard.c (read_char):
4959 * w32menu.c (w32_menu_display_help):
4960 * xmenu.c (show_help_event, menu_help_callback):
4961 Adjust calls to `show_help_echo'.
4962
4963 * gtkutil.c (xg_maybe_add_timer):
4964 * keyboard.c (readable_events):
4965 * process.c (wait_reading_process_output):
4966 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4967
4968 * insdel.c (adjust_markers_gap_motion):
4969 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4970 (gap_left, gap_right): Don't call it.
4971
2ecf6fdb
CY
49722011-03-25 Chong Yidong <cyd@stupidchicken.com>
4973
4974 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4975 incurred during fontification.
4976
6b1f9ba4
JB
49772011-03-25 Juanma Barranquero <lekktu@gmail.com>
4978
4979 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4980 (DEFVAR_PER_BUFFER): Don't pass it.
4981
4982 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4983 (scrolling_window): Don't pass it.
4984
0f4a96b5
JB
49852011-03-25 Juanma Barranquero <lekktu@gmail.com>
4986
4987 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4988
4989 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4990 and `suffix'.
4991 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4992 of variables specific to SELinux and computation of `encoded_absname'.
4993
4994 * image.c (XPutPixel): Remove unused variable `height'.
4995
4996 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4997
4998 * unexw32.c (get_section_info): Remove unused variable `section'.
4999
5000 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5001 (system_process_attributes): Remove unused variable `sess'.
5002 (sys_read): Remove unused variable `err'.
5003
5004 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5005 (w32_wnd_proc): Remove unused variable `isdead'.
5006 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5007 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5008 (x_create_tip_frame): Remove unused variable `tem'.
5009
5010 * w32inevt.c (w32_console_read_socket):
5011 Remove unused variable `no_events'.
5012
5013 * w32term.c (x_draw_composite_glyph_string_foreground):
5014 Remove unused variable `width'.
5015
1149507c
JB
50162011-03-24 Juanma Barranquero <lekktu@gmail.com>
5017
5018 * w32term.c (x_set_glyph_string_clipping):
5019 Don't pass uninitialized region to CombineRgn.
5020
9c88f339
JB
50212011-03-23 Juanma Barranquero <lekktu@gmail.com>
5022
5023 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5024 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5025 (Fx_close_connection): Remove unused variable `i'.
5026
5027 * w32font.c (w32font_draw): Return number of glyphs.
5028 (w32font_open_internal): Remove unused variable `i'.
5029 (w32font_driver): Add missing initializer.
5030
5031 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5032 (fill_in_menu): Remove unused variable `items_added'.
5033
5034 * w32term.c (last_mouse_press_frame): Remove static global variable.
5035 (w32_clip_to_row): Remove unused variable `f'.
5036 (x_delete_terminal): Remove unused variable `i'.
5037
5038 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5039 (NOTHING): Remove unused static global variable.
5040 (uniscribe_check_otf): Remove unused variable `table'.
5041 (uniscribe_font_driver): Add missing initializers.
5042
dee091a3
JD
50432011-03-23 Julien Danjou <julien@danjou.info>
5044
5045 * term.c (Fsuspend_tty, Fresume_tty):
5046 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5047 * window.c (temp_output_buffer_show):
5048 * insdel.c (signal_before_change):
5049 * frame.c (Fhandle_switch_frame):
5050 * fileio.c (Fdo_auto_save):
5051 * emacs.c (Fkill_emacs):
5052 * editfns.c (save_excursion_restore):
5053 * cmds.c (internal_self_insert):
5054 * callint.c (Fcall_interactively):
5055 * buffer.c (Fkill_all_local_variables):
5056 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5057 Use Frun_hooks.
0f4a96b5 5058 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5059 unconditionnaly since it does the check itself.
5060
2c520ab5 50612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5062
c9c49752
PE
5063 Fix more problems found by GCC 4.5.2's static checks.
5064
8abc3f12
PE
5065 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5066 the first time through the loop, since we know p0 < p1 then.
5067 This also avoids a gcc -Wstrict-overflow warning.
5068
a2d26660
PE
5069 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5070 leading to a memory leak, possible in functions like
5071 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5072 of objects (Bug#8318).
a2d26660 5073
916c72e9
PE
5074 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5075 that could (at least in theory) be that large.
5076
19ab8a18
PE
5077 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5078 This is less likely to overflow, and avoids undefined behavior if
5079 overflow does occur. All callers changed. Use strtoul to scan
5080 for the unsigned long integer.
b7cbbd6f
PE
5081 (pint2hrstr): Simplify and tune code slightly.
5082 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5083
f0641eff
PE
5084 * scroll.c (do_scrolling): Work around GCC bug 48228.
5085 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5086
7f650bb9
PE
5087 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5088 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5089 (validate_x_resource_name): Simplify count usage.
5090 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5091
37dd57d1
PE
5092 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5093 fail (Bug#8306).
81e56e61 5094
699979fc 5095 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5096
401bf9b4
PE
5097 * process.c (Fmake_network_process): Use socklen_t, not int,
5098 where POSIX says socklen_t is required in portable programs.
5099 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5100 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5101 (Fmake_network_process, server_accept_connection):
5102 (wait_reading_process_output, read_process_output):
5103 Likewise.
5104
b93aacde
PE
5105 * process.c: Rename or move locals to avoid shadowing.
5106 (list_processes_1, Fmake_network_process):
5107 (read_process_output_error_handler, exec_sentinel_error_handler):
5108 Rename or move locals.
4dc343ee 5109 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5110 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5111 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5112 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5113 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5114
af8a867c 5115 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5116 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5117 Include tparam.h instead, since it declares them.
af8a867c
PE
5118 * cm.h (PC): Remove extern decl; tparam.h now does this.
5119 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5120 * terminfo.c: Include tparam.h, to check interfaces.
5121 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5122 (tparam): Adjust signature to match interface in tparam.h;
5123 this removes some undefined behavior. Check that outstring and len
5124 are zero, which they always are with Emacs.
5125 * tparam.h (PC, BC, UP): New extern decls.
5126
0248044d 5127 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5128 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5129
8ff096c1 5130 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5131 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5132 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5133 (ftfont_list): Remove unused local.
49eaafba
PE
5134 (get_adstyle_property, ftfont_pattern_entity):
5135 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5136 Rename locals to avoid shadowing.
8ff096c1 5137
e2be39f6
PE
5138 * xfont.c (xfont_list_family): Mark var as initialized.
5139
c9735e30
PE
5140 * xml.c (make_dom): Now static.
5141
8f5201ae
PE
5142 * composite.c (composition_compute_stop_pos): Rename local to
5143 avoid shadowing.
b246f932
PE
5144 (composition_reseat_it): Remove unused locals.
5145 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5146 (composition_update_it): Mark var as initialized.
11b61122
PE
5147 (find_automatic_composition): Mark vars as initialized,
5148 with a FIXME (Bug#8290).
8f5201ae 5149
760fbc2c
PE
5150 character.h: Rename locals to avoid shadowing.
5151 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5152 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5153 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5154 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5155 to avoid shadowing.
5156
ff08eb85
PE
5157 * textprop.c (property_change_between_p): Remove; unused.
5158
fc7bf025
PE
5159 * intervals.c (interval_start_pos): Now static.
5160
235d7abc
PE
5161 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5162
44f230aa
SM
5163 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5164 Rename locals to avoid shadowing.
3e7d6594 5165
50060332
PE
5166 * sound.c (wav_play, au_play, Fplay_sound_internal):
5167 Fix pointer signedness.
d01f234b 5168 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5169 (wav_play): Initialize a variable to 0, to prevent undefined
5170 behavior (Bug#8278).
50060332 5171
c4fc4e30
PE
5172 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5173
918436ed
PE
5174 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5175
c939f91b
PE
5176 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5177 clobbering (Bug#8298).
b9c7f648
PE
5178 * sysdep.c (sys_subshell): Likewise.
5179 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5180
6bd8c144
PE
5181 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5182 This should get cleaned up, so that child_setup has the
5183 same signature on all platforms.
5184
7710357c 5185 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5186 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5187
c59da222
CY
51882011-03-22 Chong Yidong <cyd@stupidchicken.com>
5189
5190 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5191 not to be necessary, and produces flickering.
5192
66b87493
GM
51932011-03-20 Glenn Morris <rgm@gnu.org>
5194
5195 * config.in: Remove file.
5196
45b6f6d5
JB
51972011-03-20 Juanma Barranquero <lekktu@gmail.com>
5198
5199 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5200 are now in src/globals.h.
5201 (syms_of_minibuf): Remove spurious & from previous change.
5202
3ec03f7e
LL
52032011-03-20 Leo <sdl.web@gmail.com>
5204
5205 * minibuf.c (completing-read-function): New variable.
5206 (completing-read-default): Rename from completing-read.
5207 (completing-read): Call completing-read-function.
5208
b14e3e21
CY
52092011-03-19 Juanma Barranquero <lekktu@gmail.com>
5210
5211 * xfaces.c (Fx_load_color_file):
5212 Read color file from absolute filename (bug#8250).
5213
f2b726e6
JB
52142011-03-19 Juanma Barranquero <lekktu@gmail.com>
5215
5216 * makefile.w32-in: Update dependencies.
5217
09f6ff02
EZ
52182011-03-17 Eli Zaretskii <eliz@gnu.org>
5219
5220 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5221
29a6015a
PE
52222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5223
a3a6c54e
PE
5224 Fix more problems found by GCC 4.5.2's static checks.
5225
b766f867
PE
5226 * process.c (make_serial_process_unwind, send_process_trap):
5227 (sigchld_handler): Now static.
5228
be02381c
PE
5229 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5230 That way, the code declares only the vars that it needs.
5231 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5232 * s/cygwin.h (PTY_ITERATION): Likewise.
5233 * s/darwin.h (PTY_ITERATION): Likewise.
5234 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5235
57048744
PE
5236 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5237 * process.c (allocate_pty): Don't declare stb unless it's needed.
5238
7914961c 5239 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5240 (CONSTANTLIM): Remove; unused.
5241 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5242 Define only if needed.
7914961c 5243
b3967b18
PE
5244 * unexelf.c (unexec): Name an expression,
5245 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5246 Use a different way to cause a compilation error if anyone uses
5247 n rather than nn, a way that does not involve shadowing.
73366a00 5248 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5249
29a6015a
PE
5250 * deps.mk (unexalpha.o): Remove; unused.
5251
43cfc33e 5252 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5253 * unexec.h: New file.
ce701a33
PE
5254 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5255 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5256 Depend on unexec.h.
5257 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5258 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5259 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5260 Change as necessary to match prototype in unexec.h.
ce701a33 5261
01f44d5a
PE
5262 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5263 shadowing.
4f63c6bb 5264 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5265
a6670b0b
PE
5266 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5267 Rename locals to avoid shadowing.
5268
cef2010d 5269 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5270 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5271
d4d7173a
PE
5272 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5273
f08b802a
PE
5274 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5275 warning when compiling print.c.
5276
3ddb0639
PE
5277 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5278 instead of using an uninitialized var.
5ad03b97 5279 (font_sort_entities): Mark var as initialized.
3ddb0639 5280
170a2692
PE
5281 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5282
e663c700
PE
5283 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5284 pointers to constants.
89bc529a 5285 (font_parse_fcname): Remove unused vars.
7b81e2d0 5286 (font_delete_unmatched): Now static.
ea838e10 5287 (font_get_spec): Remove; unused.
13a547c6
PE
5288 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5289 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5290 Rename or move locals to avoid shadowing.
e663c700 5291
2a80c887 5292 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5293 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5294
1384fa33 5295 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5296 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5297
8b2c52e9
PE
5298 * alloc.c (mark_backtrace): Move decl from here ...
5299 * lisp.h: ... to here, so that it can be checked.
5300
475545b5 5301 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5302 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5303 (lisp_indirect_variable): Name an expression,
5304 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5305 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5306
b1349114 5307 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5308 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5309 Use const pointer when appropriate.
b1349114 5310
a2928364
PE
5311 * lisp.h (get_system_name, get_operating_system_release):
5312 Move decls here, to check interfaces.
5313 * process.c (get_operating_system_release): Move decl to lisp.h.
5314 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5315 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5316 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5317 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5318 (Fformat_time_string, Fencode_time, Finsert_char):
5319 (Ftranslate_region_internal, Fformat):
5320 Rename or remove local vars to avoid shadowing.
9710023e 5321 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5322
a415e694
PE
5323 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5324 avoid shadowing.
5325
8ef4622d
PE
5326 * lisp.h (eassert): Check that the argument compiles, even if
5327 ENABLE_CHECKING is not defined.
5328
946f9a5b
PE
5329 * data.c (Findirect_variable): Name an expression, to avoid
5330 gcc -Wbad-function-cast warning.
112396d6 5331 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5332 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5333 (Fmake_variable_buffer_local, Fmake_local_variable):
5334 Mark variables as initialized.
52746918 5335 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5336
e5aab7e7 5337 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5338 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5339 Rename locals to avoid shadowing.
dff45157
PE
5340 (mark_stack): Move local variables into the #ifdef region where
5341 they're used.
7bc26fdb
PE
5342 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5343 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5344 needed otherwise.
5345 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5346 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5347 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5348
e5aab7e7
PE
5349 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5350 avoids undefined behavior in theory.
5351
4da60324
PE
5352 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5353
88043301
PE
5354 Use functions, not macros, for up- and down-casing (Bug#8254).
5355 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5356 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5357 to use the following functions instead of these macros.
5358 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5359 EMACS_INT, since callers assume the returned value fits in int.
5360 (upcase1): Likewise, for UPCASE_TABLE.
5361 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5362 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5363 the race-condition problem in the old DOWNCASE.
88043301 5364
19ed5445
PE
5365 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5366 Rename locals to avoid shadowing.
5367 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5368 (regex_compile, re_search_2, re_match_2_internal):
5369 Remove unused local vars.
952db0d7
PE
5370 (FREE_VAR): Rewrite so as not to use empty "else",
5371 which gcc can warn about.
da053e48 5372 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5373 (RETALLOC_IF): Define only if needed.
5374 (WORDCHAR_P): Likewise. This one is never needed, but is used
5375 only in a comment talking about a compiler bug, so put inside
5376 the #if 0 of that comment.
5377 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5378 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5379 Remove; unused.
19ed5445 5380
1f3561e4 5381 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5382 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5383 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5384
ded6f8f7
PE
5385 * search.c (simple_search): Remove unused var.
5386
dbd37a95
PE
5387 * dired.c (compile_pattern): Move decl from here ...
5388 * lisp.h: ... to here, so that it can be checked.
5389 (struct re_registers): New forward decl.
5390
7e47afad
PE
5391 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5392
85f24f61
PE
5393 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5394 All uses changed.
5395 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5396 Rename locals to avoid shadowing.
5671df8f 5397 (Fvertical_motion): Mark locals as initialized.
85f24f61 5398
181aa2be 5399 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5400 (casify_region): Mark local as initialized.
181aa2be 5401
930d429c
PE
5402 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5403
7082eac6
PE
5404 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5405 New macros, so that the caller can use some names other than
5406 gcpro1, gcpro2, etc.
5407 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5408 of the new macros.
5409 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5410 argument, for consistency with GCPRO2_VAR, etc: it is now the
5411 prefix of the variable, not the variable itself. All uses
5412 changed.
38b2c076
PE
5413 * dired.c (directory_files_internal, file_name_completion):
5414 Rename locals to avoid shadowing.
5415
15206ed9
PE
5416 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5417 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5418 dired.c's scmp function, had undefined behavior.
5419 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5420 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5421 * buffer.h: ... to here, because these macros use current_buffer,
5422 and the new implementation with inline functions needs to have
5423 current_buffer in scope now, rather than later when the macros
5424 are used.
5425 (downcase, upcase1): New static inline functions.
5426 (DOWNCASE, UPCASE1): Reimplement using these functions.
5427 This avoids undefined behavior in expressions like
5428 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5429 from race conditions in accessing the global variables
5430 case_temp1 and case_temp2.
5431 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5432 * lisp.h (case_temp1, case_temp2): Remove their decls.
5433 * character.h (ASCII_CHAR_P): Move from here ...
5434 * lisp.h: ... to here, so that the inline functions mentioned
5435 above can use them.
5436
4a6bea26
PE
5437 * dired.c (directory_files_internal_unwind): Now static.
5438
f14b7e14
PE
5439 * fileio.c (file_name_as_directory, directory_file_name):
5440 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5441 Now static.
2893f146
PE
5442 (file_name_as_directory): Use const pointers when appropriate.
5443 (Fexpand_file_name): Likewise. In particular, newdir might
5444 point at constant storage, so make it a const pointer.
fd4ead52 5445 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5446 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5447 signedness issues.
f839df0c
PE
5448 (Fset_file_times, Finsert_file_contents, auto_save_error):
5449 Rename locals to avoid shadowing.
f14b7e14 5450
5716756e 5451 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5452 (Ftry_completion, Fall_completions): Rename or remove locals
5453 to avoid shadowing.
5716756e 5454
b4c3046a
PE
5455 * marker.c (bytepos_to_charpos): Remove; unused.
5456
b45db522
PE
5457 * lisp.h (verify_bytepos, count_markers): New decls,
5458 so that gcc does not warn that these functions aren't declared.
5459
85876d07
PE
5460 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5461 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5462 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5463 (copy_text): Remove unused local var.
85876d07 5464
03d78a21 5465 * filelock.c (within_one_second): Now static.
b3dd38ab 5466 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5467
5df8f01b
PE
5468 * buffer.c (fix_overlays_before): Mark locals as initialized.
5469 (fix_start_end_in_overlays): Likewise. This function should be
5470 simplified by using pointers-to-pointers, but that's a different
5471 matter.
b1d876f1 5472 (switch_to_buffer_1): Now static.
8f54f30a
PE
5473 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5474 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5475
a70072c9 5476 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5477 Fix pointer signedness issue.
edced198
PE
5478 (sys_subshell): Mark local as volatile if checking for lint,
5479 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5480 (MAXPATHLEN): Define only if needed.
a70072c9 5481
a0977c44
PE
5482 * process.c (serial_open, serial_configure): Move decls from here ...
5483 * systty.h: ... to here, so that they can be checked.
5484
a884fdcc
PE
5485 * fns.c (get_random, seed_random): Move extern decls from here ...
5486 * lisp.h: ... to here, so that they can be checked.
5487
604efe86 5488 * sysdep.c (reset_io): Now static.
b8950c94 5489 (wait_for_termination_signal): Remove; unused.
604efe86 5490
38fc62d9
PE
5491 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5492 (copy_keymap_item, append_key, push_text_char_description):
5493 Now static.
1004a21a 5494 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5495 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5496 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5497 (describe_map_tree):
5498 Rename locals to avoid shadowing.
38fc62d9 5499
2f2650da
PE
5500 * keyboard.c: Declare functions static if they are not used elsewhere.
5501 (echo_char, echo_dash, cmd_error, top_level_2):
5502 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5503 (read_char, kbd_buffer_get_event, make_lispy_position):
5504 (make_lispy_event, make_lispy_movement, apply_modifiers):
5505 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5506 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5507 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5508 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5509 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5510
a053e86c 5511 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5512 (mark_kboards): Move decl here ...
5513 * alloc.c (mark_kboards): ... from here.
a053e86c 5514
4752793e
PE
5515 * lisp.h (force_auto_save_soon): New decl.
5516
74f10ca7 5517 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5518 (DEFINE_DUMMY_FUNCTION): New macro.
5519 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5520 Use it.
c03cd23f
PE
5521 (main): Add casts to avoid warnings
5522 if GCC considers string literals to be constants.
74f10ca7 5523
022e70d4
PE
5524 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5525
59d6fe83
PE
5526 * dbusbind.c: Pointer signedness fixes.
5527 (xd_signature, xd_append_arg, xd_initialize):
5528 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5529 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5530 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5531 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5532
78320123
PE
5533 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5534 if GCC considers string literals to be constants.
49cebcca 5535 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5536
35ac2a97
SM
55372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5538
fb103ca9
SM
5539 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5540 (print_preprocess, print_object): New macro to fix last change.
5541
35ac2a97
SM
5542 * print.c (print_preprocess): Don't forget font objects.
5543
62973b41
JB
55442011-03-16 Juanma Barranquero <lekktu@gmail.com>
5545
5546 * emacs.c (USAGE3): Doc fixes.
5547
0e48bb22
AS
55482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5549
5550 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5551 structure.
5552
7684e57b
JB
55532011-03-14 Juanma Barranquero <lekktu@gmail.com>
5554
5555 * lisp.h (VWindow_system, Qfile_name_history):
5556 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5557 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5558 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5559
5560 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5561 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5562
5563 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5564 * w32console.c (detect_input_pending, read_input_pending)
5565 (encode_terminal_code):
5566 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5567 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5568 (w32_system_caret_y, Qfile_name_history):
5569 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5570 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5571 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5572 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5573 * w32proc.c (Qlocal, report_file_error):
5574 * w32term.c (Vwindow_system, updating_frame):
5575 * w32uniscribe.c (initialized, uniscribe_font_driver):
5576 Remove unneeded extern declarations.
5577
2aa46d6c
CY
55782011-03-14 Chong Yidong <cyd@stupidchicken.com>
5579
c96bbc66 5580 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5581
cffc6f3b
CY
55822011-03-13 Chong Yidong <cyd@stupidchicken.com>
5583
5584 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5585 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5586 These macros can no longer be used for assignment.
5587
44f230aa
SM
5588 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5589 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5590 (record_buffer_markers, fetch_buffer_markers): New functions for
5591 recording and fetching special buffer markers.
5592 (set_buffer_internal_1, set_buffer_temp): Use them.
5593
5594 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5595
5596 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5597
5598 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5599 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5600
5601 * xdisp.c (hscroll_window_tree):
5602 (reconsider_clip_changes): Use PT instead of BUF_PT.
5603
d251f04b
EZ
56042011-03-13 Eli Zaretskii <eliz@gnu.org>
5605
5606 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5607 $(EMACS_ROOT)/lib/intprops.h.
5608
f0c77cd1
PE
56092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5610
3eca4629
PE
5611 Fix more problems found by GCC 4.5.2's static checks.
5612
7c86ee98
PE
5613 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5614 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5615 (xg_free_frame_widgets): Make it clear that a local variable is
5616 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5617 (gdk_window_get_screen): Make it clear that this macro is needed
5618 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5619 (int_gtk_range_get_value): New function, which avoids a diagnostic
5620 from gcc -Wbad-function-cast.
5621 (xg_set_toolkit_scroll_bar_thumb): Use it.
5622 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5623 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5624 (get_utf8_string, xg_get_file_with_chooser):
5625 Rename locals to avoid shadowing.
5626 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5627
41729b81
PE
5628 * xgselect.c (xg_select): Remove unused var.
5629
f0c77cd1
PE
5630 * image.c (four_corners_best): Mark locals as initialized.
5631 (gif_load): Initialize transparent_p to zero (Bug#8238).
5632 Mark another local as initialized.
ec6cf4c6 5633 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5634
ce0ad53d 5635 * image.c (clear_image_cache): Now static.
d5d5a617 5636 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5637 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5638 (x_edge_detection): Remove unnecessary cast that
5639 gcc -Wbad-function-cast diagnoses.
2037898d 5640 (gif_load): Fix pointer signedness.
6ae141d6
PE
5641 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5642 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5643
33383987 56442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5645
d32df629
PE
5646 Improve quality of tests for time stamp overflow.
5647 For example, without this patch (encode-time 0 0 0 1 1
5648 1152921504606846976) returns the obviously-bogus value (-948597
5649 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5650 reports time overflow. See
5651 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5652 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5653 * editfns.c: Include limits.h and intprops.h.
5654 (TIME_T_MIN, TIME_T_MAX): New macros.
5655 (time_overflow): Move earlier, to before first use.
5656 (hi_time, lo_time): New functions, for an accurate test for
5657 out-of-range times.
5658 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5659 (Fget_internal_run_time): Don't assume time_t fits in int.
5660 (make_time): Use list2 instead of Fcons twice.
5661 (Fdecode_time): More accurate test for out-of-range times.
5662 (check_tm_member): New function.
5663 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5664 (lisp_time_argument): Don't rely on undefined left-shift and
5665 right-shift behavior when checking for time stamp overflow.
8be6f318 5666
fe31d94c
PE
5667 * editfns.c (time_overflow): New function, refactoring common code.
5668 (Fformat_time_string, Fdecode_time, Fencode_time):
5669 (Fcurrent_time_string): Use it.
5670
8be6f318
PE
5671 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5672 * dired.c (make_time): Move to ...
5673 * editfns.c (make_time): ... here.
5674 * systime.h: Note the move.
5675
09d9db2c 56762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5677
126bc0dc
YM
5678 * fringe.c (update_window_fringes): Remove unused variables.
5679
c47cbdfd
YM
5680 * unexmacosx.c (copy_data_segment): Also copy __got section.
5681 (Bug#8223)
5682
7ac80be9
EZ
56832011-03-12 Eli Zaretskii <eliz@gnu.org>
5684
c96bbc66 5685 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5686 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5687 Constify `char *' arguments and their references according to
5688 prototypes in tparam.h.
5689
ecb0f94d 5690 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5691
7ac80be9
EZ
5692 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5693 Adapt all references accordingly.
5694
5695 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5696
ef1fd07e
TT
56972011-03-11 Tom Tromey <tromey@redhat.com>
5698
5699 * buffer.c (syms_of_buffer): Remove obsolete comment.
5700
7ef4b50c
EZ
57012011-03-11 Eli Zaretskii <eliz@gnu.org>
5702
5703 * termhooks.h (encode_terminal_code): Declare prototype.
5704
5705 * msdos.c (encode_terminal_code): Don't declare prototype.
5706
5707 * term.c (encode_terminal_code): Now external again, used by
5708 w32console.c and msdos.c.
5709
44f230aa
SM
5710 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5711 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5712
4b1ec863 57132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5714
1714f52b 5715 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5716
4b1ec863
PE
5717 * fringe.c (update_window_fringes): Mark locals as initialized
5718 (Bug#8227).
5719 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5720
524c7aa6
PE
5721 * alloc.c (mark_fringe_data): Move decl from here ...
5722 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5723 to check its interface.
5724 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5725
a5c0af81 5726 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5727 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5728 (fontset_font): Mark local as initialized.
a9a06e0b 5729 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5730
b4716021
PE
5731 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5732
811e9bac 5733 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5734 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5735 (x_own_selection, Fx_disown_selection_internal): Rename locals
5736 to avoid shadowing.
5737 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5738
7e3ab302
PE
5739 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5740 so that the caller can use some name other than gcpro1.
5741 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5742 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5743 (Fx_backspace_delete_keys_p):
5744 Use them to avoid shadowing, and rename vars to avoid shadowing.
5745 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5746 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5747 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5748 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5749 Remove unused locals.
7e3ab302
PE
5750 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5751 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5752 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5753 macros.
f78faa98 5754
e2b13473
PE
5755 * xterm.h (x_mouse_leave): New decl.
5756
77f23912
PE
5757 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5758 Remove unused functions.
cdf4ba58
PE
5759 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5760 (x_calc_absolute_position): Now static.
7411c686 5761 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5762 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5763 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5764 unless they are used.
38d0b34a
PE
5765 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5766 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5767 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5768 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5769 (x_error_catcher, x_connection_closed, x_error_handler):
5770 (x_error_quitter, xembed_send_message, x_iconify_frame):
5771 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5772 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5773 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5774
44f230aa
SM
5775 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5776 Rename or move locals to avoid shadowing.
6b463e58 5777 (tty_defined_color, merge_face_heights): Now static.
5967d051 5778 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5779 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5780 does not deduce is never used uninitialized.
73719eba
PE
5781 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5782 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5783
426994c3 5784 * terminal.c (store_terminal_param): Now static.
5489860b 5785
032f1620 5786 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5787 (set_frame_menubar): Remove unused local.
d4323972 5788 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5789 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5790 since they might point to immutable storage.
281585b0
PE
5791 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5792 since it's unused otherwise.
032f1620 5793
367c19e5 5794 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5795 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5796 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5797 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5798 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5799 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5800 does not deduce are never used uninitialized.
70739cbe 5801
07b48fa9
PE
5802 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5803
8868a238 5804 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5805 * window.c (window_loop, size_window):
5806 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5807
7e5cf297 5808 * window.c (display_buffer): Now static.
d6550a9f
PE
5809 (size_window): Mark variables that gcc -Wuninitialized
5810 does not deduce are never used uninitialized.
a586633d
PE
5811 * window.h (check_all_windows): New decl, to forestall
5812 gcc -Wmissing-prototypes diagnostic.
5b555da1 5813 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5814
f6095868
PE
5815 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5816 shadowing.
5817 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5818 Include <limits.h>.
5819 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5820 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5821 (load_charset_map): Mark variables that gcc -Wuninitialized
5822 does not deduce are never used uninitialized.
53df7c11 5823 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5824
f38b440c
PE
5825 * coding.c (coding_set_source, coding_set_destination):
5826 Use "else { /* comment */ }" rather than "else /* comment */;"
5827 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5828 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5829 a block, when the outer 'i' will do.
5830 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5831 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5832 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5833 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5834 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5835 Rename locals to avoid shadowing.
5836 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5837 * coding.c (emacs_mule_char, encode_invocation_designation):
5838 Now static, since they're not used elsewhere.
413bb2db 5839 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5840 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5841 (decode_coding_emacs_mule): Mark variables that gcc
5842 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5843 (detect_coding_iso_2022): Initialize a local variable that might
5844 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5845 this initialization is needed. (Bug#8211)
5f58e762
PE
5846 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5847 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5848 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5849 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5850 Remove unused macros.
f38b440c 5851
232b38b9 5852 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5853 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5854 * character.c (string_count_byte8): Likewise.
232b38b9 5855
fb90da1b
PE
5856 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5857 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5858
fb93dbc2
PE
5859 * chartab.c (copy_sub_char_table): Now static, since it's not used
5860 elsewhere.
5c156ace
PE
5861 (sub_char_table_ref_and_range, char_table_ref_and_range):
5862 Rename locals to avoid shadowing.
bbcd0949 5863 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5864
7d3b3862 5865 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5866 (BIDI_BOB): Remove unused macro.
7d3b3862 5867
6be7d3da
PE
5868 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5869 deduce are never used uninitialized.
c2ed9c8b 5870 * term.c (encode_terminal_code): Likewise.
6be7d3da 5871
75f8807f 5872 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5873
50938595
PE
5874 * tparam.h: New file.
5875 * term.c, tparam.h: Include it.
5876 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5877 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5878 Move these decls to tparam.h, and make them agree with what
5879 is actually in tparam.c. The previous trick of using incompatible
5880 decls in different modules does not conform to the C standard.
5881 All callers of tparam changed to use tparam's actual API.
5882 * tparam.c (tparam1, tparam, tgoto):
5883 Use const pointers where appropriate.
5884
fbceeba2
PE
5885 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5886 * cm.h (struct cm): Likewise.
5887 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5888 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5889 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5890 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5891 (turn_on_face, init_tty): Likewise.
5892 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5893
7f3f1250
PE
5894 * term.c (term_mouse_position): Rename local to avoid shadowing.
5895
e6ca6543
PE
5896 * alloc.c (mark_ttys): Move decl from here ...
5897 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5898
c40f8d15
AS
58992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5900
5901 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5902
cfe0661d
JB
59032011-03-09 Juanma Barranquero <lekktu@gmail.com>
5904
5905 * search.c (compile_pattern_1): Remove argument regp, unused since
5906 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5907 (compile_pattern): Don't pass it.
5908
0afb4571
J
59092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5910
5911 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5912 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5913 for ! HAVE_GTK3.
5914 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5915
5916 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5917
5918 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5919 gdk_window_get_screen, gdk_window_get_geometry,
5920 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5921 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5922 (xg_get_pixbuf_from_pixmap): New function.
5923 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5924 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5925 Call xg_get_pixbuf_from_pixmap instead of
5926 gdk_pixbuf_get_from_drawable.
5927 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5928 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5929 (xg_check_special_colors): Use GtkStyleContext and its functions
5930 for HAVE_GTK3.
5931 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5932 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5933 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5934 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5935 Call gtk_widget_get_preferred_size.
0afb4571
J
5936 (xg_frame_resized): gdk_window_get_geometry only takes 5
5937 parameters.
44f230aa
SM
5938 (xg_win_to_widget, xg_event_is_for_menubar):
5939 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5940 (xg_set_widget_bg): New function.
5941 (delete_cb): New function.
895009e1 5942 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5943 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5944 (xg_set_background_color): Call xg_set_widget_bg.
5945 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5946 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5947 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5948 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5949 if ! HAVE_GTK3.
5950 (update_frame_tool_bar): Call gtk_widget_hide.
5951 (xg_initialize): Use GDK_KEY_g.
5952
5953 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5954 if ! HAVE_GTK3
5955 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5956
5957 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5958 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5959 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5960
1c2cc4ef
JB
59612011-03-08 Juanma Barranquero <lekktu@gmail.com>
5962
5963 * w32xfns.c (select_palette): Check success of RealizePalette against
5964 GDI_ERROR, not zero.
5965
33383987 5966See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5967
5968;; Local Variables:
5969;; coding: utf-8
aac0c6e3
MR
5970;; End:
5971
33383987 5972 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5973
5974 This file is part of GNU Emacs.
5975
5976 GNU Emacs is free software: you can redistribute it and/or modify
5977 it under the terms of the GNU General Public License as published by
5978 the Free Software Foundation, either version 3 of the License, or
5979 (at your option) any later version.
5980
5981 GNU Emacs is distributed in the hope that it will be useful,
5982 but WITHOUT ANY WARRANTY; without even the implied warranty of
5983 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5984 GNU General Public License for more details.
5985
5986 You should have received a copy of the GNU General Public License
5987 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.