Handle gif subimage animation delay correctly.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1100a63c
CY
12011-06-11 Chong Yidong <cyd@stupidchicken.com>
2
3 * image.c (gif_load): Add animation frame delay to the metadata.
4 (syms_of_image): Use DEFSYM. New symbol `delay'.
5
6198ccd0
MR
62011-06-11 Martin Rudalics <rudalics@gmx.at>
7
8 * window.c (delete_deletable_window): Re-add.
9 (Fset_window_configuration): Rewrite to handle dead buffers and
10 consequently deletable windows.
11 (window_tree, Fwindow_tree): Remove. Supply functionality in
12 window.el.
13 (compare_window_configurations): Simplify code.
14
b6e3633c
AS
152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
16
1ab0dee5
AS
17 * image.c (imagemagick_load_image): Fix type mismatch.
18 (Fimagemagick_types): Likewise.
19
b6e3633c
AS
20 * window.h (replace_buffer_in_windows): Declare.
21
9397e56f
MR
222011-06-11 Martin Rudalics <rudalics@gmx.at>
23
24 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
25 Qclone_number. Remove external declaration of Qdelete_window.
26 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
27 code.
28 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
29 Qbuffer_list_update_hook if allowed.
30 (Fother_buffer): Rewrite doc-string. Major rewrite for new
31 buffer list implementation.
32 (other_buffer_safely): New function.
33 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
34 calls to replace_buffer_in_windows and
35 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
36 if allowed.
37 (record_buffer): Inhibit quitting and rewrite using quittable
38 functions. Run Qbuffer_list_update_hook if allowed.
39 (Frecord_buffer, Funrecord_buffer): New functions.
40 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
41 switch-to-buffer to window.el.
42 (bury-buffer): Move to window.el.
43 (Vbuffer_list_update_hook): New variable.
44
45 * lisp.h (other_buffer_safely): Add prototype in buffer.c
46 section.
47
48 * window.h (resize_frame_windows): Move up in code.
49 (Fwindow_frame): Remove EXFUN.
50 (replace_buffer_in_all_windows): Remove prototype.
51 (replace_buffer_in_windows_safely): Add prototype.
52
53 * window.c: Declare Qdelete_window static again. Move down
54 declaration of select_count.
55 (Fnext_window, Fprevious_window): Rewrite doc-strings.
56 (Fother_window): Move to window.el.
57 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
58 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
59 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
60 window.el.
61 (replace_buffer_in_windows): Implement by calling
62 Qreplace_buffer_in_windows.
63 (replace_buffer_in_all_windows): Remove with some functionality
64 moved into replace_buffer_in_windows_safely.
65 (replace_buffer_in_windows_safely): New function.
66 (select_window_norecord, select_frame_norecord): Move in front
67 of run_window_configuration_change_hook. Remove now obsolete
68 declarations.
69 (Fset_window_buffer): Rewrite doc-string. Call
70 Qrecord_window_buffer.
71 (keys_of_window): Move binding for other-window to window.el.
72
b50691aa
CY
732011-06-11 Chong Yidong <cyd@stupidchicken.com>
74
75 * dispextern.h (struct image): Replace data member, whose int_val
76 and ptr_val fields were not used by anything, with a single
77 lisp_val object.
78
79 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
80 (gif_clear_image, gif_load, imagemagick_load_image)
81 (gs_clear_image, gs_load): Callers changed.
82
3f754b86
PE
832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
84
cca69397
PE
85 * buffer.h: Include <time.h>, for time_t.
86 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
87
109e28d0
PE
88 Fix minor problems found by static checking.
89
60737f02
PE
90 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
91
4b66faf3
PE
92 Make identifiers static if they are not used in other modules.
93 * data.c (Qcompiled_function, Qframe, Qvector):
94 * image.c (QimageMagick, Qsvg):
95 * minibuf.c (Qmetadata):
96 * window.c (resize_window_check, resize_root_window): Now static.
97 * window.h (resize_window_check, resize_root_window): Remove decls.
98
109e28d0
PE
99 * window.c (window_deletion_count, delete_deletable_window):
100 Remove; unused.
46a4ce9e
PE
101 (window_body_lines): Now static.
102 (Fdelete_other_windows_internal): Mark vars as initialized.
103 Make sure 'resize_failed' is initialized.
104 (run_window_configuration_change_hook): Rename local to avoid shadowing.
105 (resize_window_apply): Remove unused local.
106 * window.h (delete_deletable_window): Remove decl.
107
109e28d0 108 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
109 (imagemagick_load_image): Fix pointer signedness problem by changing
110 last arg from unsigned char * to char *. All uses changed.
111 Also, fix a local for similar reasons.
112 Remove unused locals. Remove locals to avoid shadowing.
113 (fn_rsvg_handle_free): Remove; unused.
114 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 115 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 116
3f754b86
PE
117 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
118
2547adb1
CY
1192011-06-10 Chong Yidong <cyd@stupidchicken.com>
120
121 * image.c (gif_load): Fix omitted cast error introduced by
122 2011-06-06 change.
123
2c8e37d4
MR
1242011-06-10 Martin Rudalics <rudalics@gmx.at>
125
126 * window.h (resize_proportionally, orig_total_lines)
127 (orig_top_line): Remove from window structure.
128 (set_window_height, set_window_width, change_window_heights)
129 (Fdelete_window): Remove prototypes.
130 (resize_frame_windows): Remove duplicate declaration.
131
440a42e3
EZ
1322011-06-10 Eli Zaretskii <eliz@gnu.org>
133
134 * window.h (resize_frame_windows, resize_window_check)
135 (delete_deletable_window, resize_root_window)
136 (resize_frame_windows): Declare prototypes.
137
138 * window.c (resize_window_apply): Make definition be "static" to
139 match the prototype.
140
562dd5e9
MR
1412011-06-10 Martin Rudalics <rudalics@gmx.at>
142
143 * window.c: Remove declarations of Qwindow_size_fixed,
144 window_min_size_1, window_min_size_2, window_min_size,
145 size_window, window_fixed_size_p, enlarge_window, delete_window.
146 Remove static from declaration of Qdelete_window, it's
147 temporarily needed by Fbury_buffer.
148 (replace_window): Don't assign orig_top_line and
149 orig_total_lines.
150 (Fdelete_window, delete_window): Remove. Window deletion is
151 handled by window.el.
152 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
153 Fdelete_window calls with calls to Qdelete_window.
154 (Fdelete_other_windows): Remove. Deleting other windows is
155 handled by window.el.
156 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
157 handled in window.el.
158 (window_min_size_2, window_min_size_1, window_min_size): Remove.
159 Window minimum sizes are handled in window.el.
160 (shrink_windows, size_window, set_window_height)
161 (set_window_width, change_window_heights, window_height)
162 (window_width, CURBEG, CURSIZE, enlarge_window)
163 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
164 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
165 handled in window.el.
166 (make_dummy_parent): Rename to make_parent_window and give it a
167 second argument horflag.
168 (make_window): Don't set resize_proportionally any more.
169 (Fsplit_window): Remove. Windows are split in window.el.
170 (save_restore_action, save_restore_orig_size)
171 (shrink_window_lowest_first, save_restore_orig_size): Remove.
172 Resize mini windows in window.el.
173 (grow_mini_window, shrink_mini_window): Implement by calling
174 Qresize_root_window_vertically, resize_window_check and
175 resize_window_apply.
176 (saved_window, Fset_window_configuration, save_window_save): Do
177 not handle orig_top_line, orig_total_lines, and
178 resize_proportionally.
179 (window_min_height, window_min_width): Move to window.el.
180 (keys_of_window): Move bindings for delete-other-windows,
181 split-window, delete-window and enlarge-window to window.el.
182
183 * buffer.c: Temporarily extern Qdelete_window.
184 (Fbury_buffer): Temporarily call Qdelete_window instead of
185 Fdelete_window (Fbury_buffer will move to window.el soon).
186
187 * frame.c (set_menu_bar_lines_1): Remove code handling
188 orig_top_line and orig_total_lines.
189
190 * dispnew.c (adjust_frame_glyphs_initially): Don't use
191 set_window_height but set heights directly.
192 (change_frame_size_1): Use resize_frame_windows.
193
194 * xdisp.c (init_xdisp): Don't use set_window_height but set
195 heights directly.
196
197 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
198 resize_frame_windows instead of change_window_heights and run
199 run_window_configuration_change_hook.
200
201 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
202 instead of change_window_heights and run
203 run_window_configuration_change_hook.
204
1a13852e
MR
2052011-06-09 Martin Rudalics <rudalics@gmx.at>
206
207 * window.c (replace_window): Rename second argument REPLACEMENT to
208 NEW. New third argument SETFLAG. Rewrite.
209 (delete_window, make_dummy_parent): Call replace_window with
210 third argument 1.
211 (window_list_1): Move down in code.
212 (run_window_configuration_change_hook): Move set_buffer part
213 before select_frame_norecord part in order to unwind correctly.
214 Rename count1 to count.
215 (recombine_windows, delete_deletable_window, resize_root_window)
216 (Fdelete_other_windows_internal)
217 (Frun_window_configuration_change_hook, make_parent_window)
218 (resize_window_check, resize_window_apply, Fresize_window_apply)
219 (resize_frame_windows, Fsplit_window_internal)
220 (Fdelete_window_internal, Fresize_mini_window_internal): New
221 functions.
222 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
223
f3d1777e
MR
2242011-06-08 Martin Rudalics <rudalics@gmx.at>
225
496e208e
MR
226 * window.h (window): Add some new members to window structure -
227 normal_lines, normal_cols, new_total, new_normal, clone_number,
228 splits, nest, prev_buffers, next_buffers.
229 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 230 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 231
f3d1777e
MR
232 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
233 Remove.
496e208e
MR
234 (make_dummy_parent): Set new members of windows structure.
235 (make_window): Move down in code. Handle new members of window
236 structure.
237 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
238 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
239 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
240 (Fset_window_prev_buffers, Fwindow_next_buffers)
241 (Fset_window_next_buffers, Fset_window_clone_number): New
242 functions.
243 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
244 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
245 Doc-string fixes.
246 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
247 Argument WINDOW can be now internal window too.
248 (Fwindow_use_time): Move up in code.
249 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
250 Rewrite doc-string.
251 (Fset_window_configuration, saved_window)
252 (Fcurrent_window_configuration, save_window_save): Handle new
253 members of window structure.
b9e809c2
MR
254 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
255 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
256 (syms_of_window): New Lisp objects Qrecord_window_buffer,
257 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
258 Qget_mru_window, Qresize_root_window,
259 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
260 Qauto_buffer_name; staticpro them.
f3d1777e 261
abde8f8c
MR
2622011-06-07 Martin Rudalics <rudalics@gmx.at>
263
264 * window.c (Fwindow_total_size, Fwindow_left_column)
265 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
266 (Fwindow_list_1): New functions.
267 (window_box_text_cols): Replace with window_body_cols.
268 (Fwindow_width, Fscroll_left, Fscroll_right): Use
269 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
270 (delete_window, Fset_window_configuration): Call
271 delete_all_subwindows with window as argument.
272 (delete_all_subwindows): Take a window as argument and not a
273 structure. Rewrite.
190b47e6
MR
274 (window_loop): Remove handling of GET_LRU_WINDOW and
275 GET_LARGEST_WINDOW.
276 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
277
278 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
279 window_box_text_cols. delete_all_subwindows now takes a
280 Lisp_Object as argument.
abde8f8c
MR
281
282 * indent.c (compute_motion, Fcompute_motion): Use
283 window_body_cols instead of window_box_text_cols.
284
fa8a67e6
MR
285 * frame.c (delete_frame): Call delete_all_subwindows with root
286 window as argument.
287
a54e3482
DC
2882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
289
290 * fns.c (Fputhash): Document return value.
291
60002bf5
CY
2922011-06-06 Chong Yidong <cyd@stupidchicken.com>
293
294 * image.c (gif_load): Implement gif89a spec "no disposal" method.
295
0c671da6 2962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 297
b862a52a 298 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 299
be44ca6c
PE
300 Check for overflow when converting integer to cons and back.
301 * charset.c (Fdefine_charset_internal, Fdecode_char):
302 Use cons_to_unsigned to catch overflow.
303 (Fencode_char): Use INTEGER_TO_CONS.
304 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
305 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
306 * data.c (long_to_cons, cons_to_long): Remove.
307 (cons_to_unsigned, cons_to_signed): New functions.
308 These signal an error for invalid or out-of-range values.
309 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
310 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
311 * font.c (Ffont_variation_glyphs):
312 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
313 * lisp.h: Include <intprops.h>.
314 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
315 (cons_to_signed, cons_to_unsigned): New decls.
316 (long_to_cons, cons_to_long): Remove decls.
317 * undo.c (record_first_change): Use INTEGER_TO_CONS.
318 (Fprimitive_undo): Use CONS_TO_INTEGER.
319 * xfns.c (Fx_window_property): Likewise.
320 * xselect.c: Include <limits.h>.
321 (x_own_selection, selection_data_to_lisp_data):
322 Use INTEGER_TO_CONS.
323 (x_handle_selection_request, x_handle_selection_clear)
324 (x_get_foreign_selection, Fx_disown_selection_internal)
325 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
326 (lisp_data_to_selection_data): Use cons_to_unsigned.
327 (x_fill_property_data): Use cons_to_signed.
328 Report values out of range.
329
d1f3d2af
PE
330 Check for buffer and string overflow more precisely.
331 * buffer.h (BUF_BYTES_MAX): New macro.
332 * lisp.h (STRING_BYTES_MAX): New macro.
333 * alloc.c (Fmake_string):
334 * character.c (string_escape_byte8):
335 * coding.c (coding_alloc_by_realloc):
336 * doprnt.c (doprnt):
337 * editfns.c (Fformat):
338 * eval.c (verror):
339 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
340 since they may not be the same number.
341 * editfns.c (Finsert_char):
342 * fileio.c (Finsert_file_contents):
343 Likewise for BUF_BYTES_MAX.
344
dd52fcea
PE
345 * image.c: Use ptrdiff_t, not int, for sizes.
346 (slurp_file): Switch from int to ptrdiff_t.
347 All uses changed.
348 (slurp_file): Check that file size fits in both size_t (for
349 malloc) and ptrdiff_t (for sanity and safety).
350
7f9bbdbb
PE
351 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
352 if b->modtime has its maximal value.
353
dfe18f82
PE
354 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
355
84acfcf0
PE
356 Don't assume time_t can fit into int.
357 * buffer.h (struct buffer.modtime): Now time_t, not int.
358 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
359 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
360
ccd9a01a
PE
361 Minor fixes for signed vs unsigned integers.
362 * character.h (MAYBE_UNIFY_CHAR):
363 * charset.c (maybe_unify_char):
364 * keyboard.c (read_char, reorder_modifiers):
365 XINT -> XFASTINT, since the integer must be nonnegative.
366 * ftfont.c (ftfont_spec_pattern):
367 * keymap.c (access_keymap, silly_event_symbol_error):
368 XUINT -> XFASTINT, since the integer must be nonnegative.
369 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
370 since it makes no difference and we prefer signed.
371 * keyboard.c (record_char): Use XUINT when all the neighbors do.
372 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
373 nonnegative.
374
d6d100dd
SM
3752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
376
377 * window.h (Fwindow_frame): Declare.
378
2b6148e4
PE
3792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
380
381 * alloc.c: Simplify handling of large-request failures (Bug#8800).
382 (SPARE_MEMORY): Always define.
383 (LARGE_REQUEST): Remove.
384 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
385
f230ecc9
MR
3862011-06-06 Martin Rudalics <rudalics@gmx.at>
387
727e958e
MR
388 * lisp.h: Move EXFUNS for Fframe_root_window,
389 Fframe_first_window and Fset_frame_selected_window to window.h.
390
391 * window.h: Move EXFUNS for Fframe_root_window,
392 Fframe_first_window and Fset_frame_selected_window here from
393 lisp.h.
394
395 * frame.c (Fwindow_frame, Fframe_first_window)
396 (Fframe_root_window, Fframe_selected_window)
397 (Fset_frame_selected_window): Move to window.c.
398 (Factive_minibuffer_window): Move to minibuf.c.
399 (Fother_visible_frames_p): New function.
400
401 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
402
f230ecc9
MR
403 * window.c (decode_window, decode_any_window): Move up in code.
404 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
405 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
406 (Fwindow_buffer): Move up and rewrite doc-string.
407 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
408 (Fwindow_prev): New functions.
727e958e
MR
409 (Fwindow_frame): Move here from frame.c. Accept any window as
410 argument.
411 (Fframe_root_window, Fframe_first_window)
412 (Fframe_selected_window): Move here from frame.c. Accept frame
413 or arbitrary window as argument. Update doc-strings.
414 (Fminibuffer_window): Move up in code.
415 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
416 (Fset_frame_selected_window): Move here from frame.c.
417 Marginal rewrite.
727e958e
MR
418 (Fselected_window, select_window, Fselect_window): Move up in
419 code. Minor doc-string fixes.
f230ecc9 420
4d09bcf6
PE
4212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
422
423 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
424 Do not assume that spare memory exists; that assumption is valid
425 only if SYSTEM_MALLOC.
426 (LARGE_REQUEST): New macro, so that the issue of large requests
427 is separated from the issue of spare memory.
428
810928a2
AS
4292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
430
172418ad
AS
431 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
432 format. (Bug#8806)
433
43f862f7
AS
434 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
435
810928a2
AS
436 * xfns.c (x_set_scroll_bar_default_width): Move declarations
437 before statements.
438
a059fe24
JD
4392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
440
441 * gtkutil.c (xg_get_default_scrollbar_width): New function.
442
443 * gtkutil.h: Declare xg_get_default_scrollbar_width.
444
445 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
446 min width by calling x_set_scroll_bar_default_width (Bug#8505).
447
989bf368
JB
4482011-06-05 Juanma Barranquero <lekktu@gmail.com>
449
450 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
451
4b80f674
CY
4522011-06-04 Chong Yidong <cyd@stupidchicken.com>
453
454 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
455 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
456 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
457 New error handlers.
4b80f674
CY
458 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
459 Obey Vx_select_enable_clipboard_manager. Catch errors in
460 x_clipboard_manager_save (Bug#8779).
461 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 462 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 463
99a33b77 4642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
465
466 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
467
99a33b77 4682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
469
470 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
471 in the current matrix if keep_current_p is non-zero.
472
8264569d
EZ
4732011-06-04 Eli Zaretskii <eliz@gnu.org>
474
475 * bidi.c (bidi_level_of_next_char): Fix last change.
476
57f97249
EZ
4772011-06-03 Eli Zaretskii <eliz@gnu.org>
478
fec2107c 479 Support bidi reordering of text covered by display properties.
57f97249 480
fec2107c
EZ
481 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
482 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
483 (bidi_cache_search, bidi_cache_iterator_state)
484 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
485 (bidi_level_of_next_char, bidi_move_to_visually_next):
486 Support character positions inside a run of characters covered by a
fec2107c
EZ
487 display string.
488 (bidi_paragraph_init, bidi_resolve_explicit_1)
489 (bidi_level_of_next_char): Call bidi_fetch_char and
490 bidi_fetch_char_advance instead of FETCH_CHAR and
491 FETCH_CHAR_ADVANCE.
492 (bidi_init_it): Initialize new members.
493 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
494 definitions.
495 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
496 instead of using explicit *_CHAR codes.
d6d100dd
SM
497 (bidi_resolve_explicit, bidi_resolve_weak):
498 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
499 bidirectional text is supported only in multibyte buffers.
500 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
501 it to initialize the frame_window_p member of struct bidi_it.
502 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
503 (bidi_resolve_explicit, bidi_resolve_weak)
504 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
505 bidi_it->nchars is non-positive.
506 (bidi_level_of_next_char): Don't try to lookup the cache for the
507 next/previous character if nothing is cached there yet, or if we
508 were just reseat()'ed to a new position.
c40e2fb2 509
0e14fe90
EZ
510 * xdisp.c (set_cursor_from_row): Set start and stop points
511 according to the row's direction when priming the loop that looks
512 for the glyph on which to display cursor.
513 (single_display_spec_intangible_p): Function deleted.
514 (display_prop_intangible_p): Reimplement to call
515 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
516 Accept 3 additional arguments needed by handle_display_spec.
517 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
518 values: lists, `(when COND...)' forms, etc.
519 (single_display_spec_string_p): Support property values that are
520 lists with the argument STRING its top-level element.
521 (display_prop_string_p): Fix the condition for processing a
522 property that is a list to be consistent with handle_display_spec.
fec2107c 523 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
524 last portion of handle_display_prop.
525 (compute_display_string_pos): Accept additional argument
526 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
527 value of a `display' property is a "replacing spec".
528 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
529 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
530 the display property, but just return a value indicating whether
531 the display property will replace the characters it covers.
532 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
533 frame_window_p members of struct bidi_it.
d6d100dd
SM
534 (compute_display_string_pos, compute_display_string_end):
535 New functions.
fec2107c
EZ
536 (push_it): Accept second argument POSITION, where pop_it should
537 jump to continue iteration.
538 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 539
fec2107c
EZ
540 * keyboard.c (adjust_point_for_property): Adjust the call to
541 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
542
543 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
544 (bidi_init_it): Update prototypes.
545 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
546 (compute_display_string_pos, compute_display_string_end):
547 Declare prototypes.
fec2107c
EZ
548 (struct bidi_it): New members nchars and disp_pos. ch_len is now
549 EMACS_INT.
fc6f18ce 550
40087514 5512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 552
57f53182
PE
553 Malloc failure behavior now depends on size of allocation.
554 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
555 * lisp.h: Change signatures accordingly.
556 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
557 All callers changed. (Bug#8762)
558
559 * gnutls.c: Use Emacs's memory allocators.
560 Without this change, the gnutls library would invoke malloc etc.
561 directly, which causes problems on non-SYNC_INPUT hosts, and which
562 runs afoul of improving memory_full behavior. (Bug#8761)
563 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
564 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
565 xfree instead of the default malloc, realloc, free.
566 (Fgnutls_boot): No need to check for memory allocation failure,
567 since xmalloc does that for us.
568
ac32cd99 569 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
570 * category.c (hash_get_category_set):
571 * ccl.c (ccl_driver):
572 * charset.c (Fdefine_charset_internal):
573 * charset.h (struct charset.hash_index):
574 * composite.c (get_composition_id, gstring_lookup_cache)
575 (composition_gstring_put_cache):
576 * composite.h (struct composition.hash_index):
577 * dispextern.h (struct image.hash):
578 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
579 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
580 (hashfn_equal, hashfn_user_defined, make_hash_table)
581 (maybe_resize_hash_table, hash_lookup, hash_put)
582 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
583 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
584 (Fsxhash, Fgethash, Fputhash, Fmaphash):
585 * image.c (make_image, search_image_cache, lookup_image)
586 (xpm_put_color_table_h):
587 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 588 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
589 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
590 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
591 * alloc.c (allocate_vectorlike):
592 Check for overflow in vector size calculations.
593 * ccl.c (ccl_driver):
594 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
595 * fns.c, image.c: Remove unnecessary static decls that would otherwise
596 need to be updated by these changes.
40087514
PE
597 * fns.c (make_hash_table, maybe_resize_hash_table):
598 Check for integer overflow with large hash tables.
0de4bb68
PE
599 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
600 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
601 (SXHASH_REDUCE): New macro.
602 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
603 Use it instead of discarding useful hash info with large hash values.
604 (sxhash_float): New function.
605 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
606 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
607 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
608 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
609 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
610 Adjust signatures to match updated version of code.
611 (consing_since_gc): Now EMACS_INT, since a single hash table can
612 use more than INT_MAX bytes.
613
698d32e2
DN
6142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
615
616 Make it possible to build with GCC-4.6+ -O2 -flto.
617
618 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
619
fd6fa53f
SM
6202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
621
622 * minibuf.c (get_minibuffer, read_minibuf_unwind):
623 Call minibuffer-inactive-mode.
624
864db017
JB
6252011-05-31 Juanma Barranquero <lekktu@gmail.com>
626
627 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
628 Update dependencies.
629
2ad0baf4
DN
6302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
631
632 * data.c (init_data): Remove code for UTS, this system is not
633 supported anymore.
634
4fcc2638
DN
6352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
636
637 Don't force ./temacs to start in terminal mode.
638
639 * frame.c (make_initial_frame): Initialize faces in all cases, not
640 only when CANNOT_DUMP is defined.
641 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
642
c56e0fd5
DN
6432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
644
645 * dispnew.c (add_window_display_history): Use const for the string
646 pointer. Remove declaration, not needed.
647
333d54da 6482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 649
55d4c1b2 650 Use 'inline', not 'INLINE'.
333d54da 651 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
652 * alloc.c, fontset.c (INLINE): Remove.
653 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
654 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
655 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
656 * gmalloc.c (register_heapinfo): Use inline unconditionally.
657 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
658
738db178
DN
6592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
660
661 Make it possible to run ./temacs.
662
663 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
664 syms_of_callproc does the same thing. Remove test for
665 "initialized", do it in the caller.
666 * emacs.c (main): Avoid calling set_initial_environment when dumping.
667
620c53a6
SM
6682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
669
670 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
671 (read_minibuf): Use get_minibuffer.
672 (syms_of_minibuf): Use DEFSYM.
673 (Qmetadata): New var.
674 * data.c (Qbuffer): Don't make it static.
675 (syms_of_data): Use DEFSYM.
676
e003a292
PE
6772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
678
679 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
680 (CCL_CODE_MIN): New macro.
681
ed008a6d
PE
6822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
683
3687c2ef
PE
684 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
685
ed008a6d
PE
686 * eval.c (Qdebug): Now static.
687 * lisp.h (Qdebug): Remove decl. This reverts a part of the
688 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
689 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
690
d66c4c7c
CY
6912011-05-29 Chong Yidong <cyd@stupidchicken.com>
692
693 * image.c: Various fixes to ImageMagick code comments.
694 (Fimagemagick_types): Doc fix.
695
5fbc2025
PE
6962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
697
0196f88a
PE
698 Minor fixes prompted by GCC 4.6.0 warnings.
699
700 * xselect.c (converted_selections, conversion_fail_tag): Now static.
701
5fbc2025
PE
702 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
703 (x_clipboard_manager_save_all): Move extern decl to ...
704 * xterm.h: ... here, so that it can be checked for consistency.
705
1dd3c2d9
CY
7062011-05-29 Chong Yidong <cyd@stupidchicken.com>
707
708 * xselect.c (x_clipboard_manager_save_frame)
709 (x_clipboard_manager_save_all): New functions.
710 (Fx_clipboard_manager_save): Lisp function deleted.
711
712 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
713 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
714
715 * xterm.h: Update prototype.
716
5ba6571d
WX
7172011-05-28 William Xu <william.xwl@gmail.com>
718
719 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
720 exiting (Bug#8239).
721
3eaff834
JM
7222011-05-28 Jim Meyering <meyering@redhat.com>
723
e1900994 724 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
725 * fns.c (to_uchar): Define.
726 (crypto_hash_function): Use it to convert some newly-signed
727 variables to unsigned, to avoid sign-extension bugs. For example,
728 without this change, (md5 "truc") would evaluate to
729 45723a2aff78ff4fff7fff1114760e62 rather than the expected
730 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 731 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 732
0f6990a7
PE
7332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
734
735 Integer overflow fixes.
c8a9ca5a 736
08686060
PE
737 * dbusbind.c: Serial number integer overflow fixes.
738 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
739 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
740 to hold a serial number that is too large for a fixnum.
741 (Fdbus_method_return_internal, Fdbus_method_error_internal):
742 Check for serial numbers out of range. Decode any serial number
59568bf0 743 that was so large that it became a float. (Bug#8722)
08686060 744
2d1fc3c7
PE
745 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
746 (Fdbus_call_method, Fdbus_call_method_asynchronously):
747 Use XFASTINT rather than XUINT when numbers are nonnegative.
748 (xd_append_arg, Fdbus_method_return_internal):
749 (Fdbus_method_error_internal): Likewise. Also, for unsigned
750 arguments, check that Lisp number is nonnegative, rather than
59568bf0 751 silently wrapping negative numbers around. (Bug#8722)
30217ff0 752 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 753 (Bug#8722)
2d1fc3c7 754
c8a9ca5a
PE
755 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
756
519e1d69
PE
757 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
758
30569699
PE
759 ccl: add integer overflow checks
760 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
761 (IN_INT_RANGE): New macros.
762 (ccl_driver): Use them to check for integer overflow when
763 decoding a CCL program. Many of the new checks are whether XINT (x)
764 fits in int; it doesn't always, on 64-bit hosts. The new version
765 doesn't catch all possible integer overflows, but it's an
847044ea 766 improvement. (Bug#8719)
30569699 767
c11285dc
PE
768 * alloc.c (make_event_array): Use XINT, not XUINT.
769 There's no need for unsigned here.
770
fdccd48e
PE
771 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
772 This follows up to the 2011-05-06 change that substituted uintptr_t
773 for EMACS_INT. This case wasn't caught back then.
774
37910ab2
PE
775 Rework Fformat to avoid integer overflow issues.
776 * editfns.c: Include <float.h> unconditionally, as it's everywhere
777 now (part of C89). Include <verify.h>.
778 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
779 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
780 (Fformat): Avoid the prepass trying to compute sizes; it was only
781 approximate and thus did not catch overflow reliably. Instead, walk
782 through the format just once, formatting and computing sizes as we go,
783 checking for integer overflow at every step, and allocating a larger
784 buffer as needed. Keep track separately whether the format is
785 multibyte. Keep only the most-recently calculated precision, rather
786 than them all. Record whether each argument has been converted to
787 string. Use EMACS_INT, not int, for byte and char and arg counts.
788 Support field widths and precisions larger than INT_MAX. Avoid
789 sprintf's undefined behavior with conversion specifications such as %#d
790 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
791 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
792 formatting out-of-range floating point numbers with int
793 formats. (Bug#8668)
794
2e6578fb
PE
795 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
796
0ae6bdee
PE
797 * data.c: Avoid integer truncation in expressions involving floats.
798 * data.c: Include <intprops.h>.
799 (arith_driver): When there's an integer overflow in an expression
800 involving floating point, convert the integers to floating point
801 so that the resulting value does not suffer from catastrophic
802 integer truncation. For example, on a 64-bit host (* 4
803 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
804 Do not rely on undefined behavior after integer overflow.
805
de883a70
PE
806 merge count_size_as_multibyte, parse_str_to_multibyte
807 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 808 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
809 Check for integer overflow.
810 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
811 since it's now a duplicate of the other. This is more of
812 a character than a buffer op, so better that it's in character.c.
813 * fns.c, print.c: Adjust to above changes.
814
2ff916cb
PE
8152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
816
817 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
818
f1b54466
PE
8192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
820
fb1ac845
PE
821 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
822 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
823 (x_clipboard_manager_save): Now static.
824 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
825
f1b54466
PE
826 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
827 (crypto_hash_function): Now static.
828 Fix pointer signedness problems. Avoid unnecessary initializations.
829
a9f737ee
CY
8302011-05-27 Chong Yidong <cyd@stupidchicken.com>
831
832 * termhooks.h (Vselection_alist): Make it terminal-local.
833
834 * terminal.c (create_terminal): Initialize it.
835
836 * xselect.c: Support for clipboard managers.
837 (Vselection_alist): Move to termhooks.h as terminal-local var.
838 (LOCAL_SELECTION): New macro.
839 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
840 (symbol_to_x_atom): Remove gratuitous arg.
841 (x_handle_selection_request, lisp_data_to_selection_data)
842 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
843 (x_own_selection, x_get_local_selection, x_convert_selection):
844 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
845 (some_frame_on_display): Delete unused function.
846 (Fx_own_selection_internal, Fx_get_selection_internal)
847 (Fx_disown_selection_internal, Fx_selection_owner_p)
848 (Fx_selection_exists_p): New optional frame arg.
849 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
850 (x_handle_selection_clear): Don't treat other terminals with the
851 same keyboard specially. Use the terminal-local Vselection_alist.
852 (x_clear_frame_selections): Use Frun_hook_with_args.
853
854 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
855
856 * xterm.h: Add support for those atoms.
857
e067f0c1
CY
8582011-05-26 Chong Yidong <cyd@stupidchicken.com>
859
860 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
861 (converted_selections, conversion_fail_tag): New global variables.
862 (x_selection_request_lisp_error): Free the above.
863 (x_get_local_selection): Remove unnecessary code.
864 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
865 of converted selections stored in converted_selections.
866 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
867 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
868 (x_convert_selection): New function.
869 (x_handle_selection_event): Simplify.
870 (x_get_foreign_selection): Don't ignore incoming requests while
871 waiting for an answer; this will fail when we implement
872 SAVE_TARGETS, and seems unnecessary anyway.
873 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
874 (Vx_sent_selection_functions): Doc fix.
875
0f4aebc0
LL
8762011-05-26 Leo Liu <sdl.web@gmail.com>
877
878 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
879
e61124cd
YM
8802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
881
882 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
883
884 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
885 for fringe update if it has periodic bitmap.
886 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
887 and fringe_bitmap_periodic_p.
888
889 * fringe.c (get_fringe_bitmap_data): New function.
890 (draw_fringe_bitmap_1, update_window_fringes): Use it.
891 (update_window_fringes): Record periodicity of fringe bitmap in glyph
892 row. Mark glyph row for fringe update if periodicity changed.
893
894 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
895 for fringe update unless it has periodic bitmap.
896
f16d9837
KH
8972011-05-25 Kenichi Handa <handa@m17n.org>
898
899 * xdisp.c (get_next_display_element): Set correct it->face_id for
900 a static composition.
901
e1b90ef6
LL
9022011-05-24 Leo Liu <sdl.web@gmail.com>
903
904 * deps.mk (fns.o):
905 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
906
907 * fns.c (crypto_hash_function, Fsha1): New function.
908 (Fmd5): Use crypto_hash_function.
909 (syms_of_fns): Add Ssha1.
910
7400048f
PE
9112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
912
913 * gnutls.c: Remove unused macros.
914 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
915 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
916 Remove macros that are defined and never used.
917 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
918
abb71cf4
CY
9192011-05-22 Chong Yidong <cyd@stupidchicken.com>
920
921 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
922 (Fx_get_selection_internal): Minor cleanup.
923 (Fx_own_selection_internal): Rename arguments for consistency with
924 select.el.
925
6307db39
PE
9262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
927
928 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
929
f3d4e0a4
CY
9302011-05-22 Chong Yidong <cyd@stupidchicken.com>
931
932 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
933
4d8ade89
YM
9342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
935
936 * dispnew.c (scrolling_window): Don't exclude the case that the
937 last enabled row in the desired matrix touches the bottom boundary.
938
32078c8d
GM
9392011-05-21 Glenn Morris <rgm@gnu.org>
940
941 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
942 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
943 and add some more files.
32078c8d 944
7285dc67
EZ
9452011-05-20 Eli Zaretskii <eliz@gnu.org>
946
947 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
948 report_file_error introduced by the change from 2011-05-07.
949
89d1bd22
PE
9502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
951
952 * systime.h (Time): Define only if emacs is defined.
953 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
954 where the include path doesn't have X11/X.h by default. See
955 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
956
e23640bb 9572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
958
959 * composite.c (find_automatic_composition): Fix previous change.
960
b9704ad9
GM
9612011-05-20 Glenn Morris <rgm@gnu.org>
962
963 * lisp.mk: New file, split from Makefile.in.
964 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
965 (shortlisp): Remove.
966 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
967
4a720484
GM
9682011-05-19 Glenn Morris <rgm@gnu.org>
969
970 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
971 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
972 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
973 (lisp): Set the order to that of loadup.el.
974 (shortlisp): Make it a copy of $lisp.
975 (SOME_MACHINE_LISP): Remove.
976 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
977 Use just $shortlisp, not $SOME_MACHINE_LISP too.
978
a28d4396
KH
9792011-05-18 Kenichi Handa <handa@m17n.org>
980
981 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
982 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
983 (find_automatic_composition): Mostly rewrite for efficiency.
984
a2b1fa8e
JB
9852011-05-18 Juanma Barranquero <lekktu@gmail.com>
986
987 * makefile.w32-in: Update dependencies.
988
8e1f5610
CS
9892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
990
991 * menu.c: Include limits.h (fixes the MS-Windows build broken by
992 revision 104625).
993
7025ee00 9942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 995
cdfa6eab
PE
996 Fix some integer overflow issues, such as string length overflow.
997
06d6db33
PE
998 * insdel.c (count_size_as_multibyte): Check for string overflow.
999
2b4560a8
PE
1000 * character.c (lisp_string_width): Check for string overflow.
1001 Use EMACS_INT, not int, for string indexes and lengths; in
1002 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1003 the resulting string length overflows an EMACS_INT; instead,
1004 report a string overflow if no precision given. When checking for
1005 precision exhaustion, use a check that cannot possibly have
1006 integer overflow. (Bug#8675)
1007 * character.h (lisp_string_width): Adjust to new signature.
1008
cb93f9be
PE
1009 * alloc.c (string_overflow): New function.
1010 (Fmake_string): Use it. This doesn't change behavior, but saves
1011 a few bytes and will simplify future changes.
1012 * character.c (string_escape_byte8): Likewise.
1013 * lisp.h (string_overflow): New decl.
1014
1a1f3366
PE
1015 Fixups, following up to the user-interface timestamp change.
1016 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1017 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1018 * msdos.c (mouse_get_pos): Likewise.
1019 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1020 * w32gui.h (Time): Define by including "systime.h" rather than by
1021 declaring it ourselves. (Bug#8664)
1022
d4e3e4d3
PE
1023 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1024 * image.c (clear_image_cache): Likewise.
1025
f6a24d19
PE
1026 * term.c (term_mouse_position): Don't assume time_t wraparound.
1027
08dc5ae6
PE
1028 Be more systematic about user-interface timestamps.
1029 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1030 and sometimes 'EMACS_UINT', to represent these timestamps.
1031 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1032 This makes the code easier to follow, and makes it easier to catch
1033 integer overflow bugs such as Bug#8664.
1034 * frame.c (Fmouse_position, Fmouse_pixel_position):
1035 Use Time, not unsigned long, for user-interface timestamps.
1036 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1037 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1038 * keyboard.h (last_event_timestamp): Likewise.
1039 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1040 * menu.h (xmenu_show): Likewise.
1041 * term.c (term_mouse_position): Likewise.
1042 * termhooks.h (struct input_event.timestamp): Likewise.
1043 (struct terminal.mouse_position_hook): Likewise.
1044 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1045 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1046 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1047 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1048 what it was before.
1049 * menu.h, termhooks.h: Include "systime.h", for Time.
1050
8e55734a
PE
1051 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1052 Don't assume that the difference between two unsigned long values
1053 can fit into an integer. At this point, we know button_down_time
1054 <= event->timestamp, so the difference must be nonnegative, so
1055 there's no need to cast the result if double-click-time is
1056 nonnegative, as it should be; check that it's nonnegative, just in
1057 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1058 apart (about 25 days). (Bug#8664)
8e55734a 1059
841f1b75 1060 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1061 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1062
3e26f69c
PE
1063 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1064 that always fit in int. Use a sentinel instead of a counter, to
1065 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1066 * frame.h (struct frame): Use int for menu_bar_items_used
1067 instead of EMACS_INT, since it always fits in int.
3e26f69c 1068
5cc152c0
PE
1069 * menu.c (grow_menu_items): Check for int overflow.
1070
d89eb65e
PE
1071 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1072
5235bd3e
PE
1073 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1074 Before, the code was not consistent. These values cannot exceed
1075 2**31 - 1 so there's no need to make them unsigned.
1076 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1077 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1078 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1079 as modifiers.
1080 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1081
bc827e23
PE
1082 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1083 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1084 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1085 presumably because the widths might not match.
1086
78eb494e
PE
1087 * window.c (size_window): Avoid needless test at loop start.
1088
04f2d78b
CB
10892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1090
1091 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1092
d2fc7e3d 10932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1094
1095 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1096
d2fc7e3d 10972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1098
1099 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1100 `width' to `bar_area_x' and `bar_area_width', respectively.
1101 (x_scroll_run): Take account of fringe background extension.
1102
04f2d78b
CB
1103 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1104 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1105 `bar_area_width', respectively.
1106 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1107 background extension.
1108
79b70037
GM
11092011-05-10 Jim Meyering <meyering@redhat.com>
1110
1111 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1112
2f142cc5
JB
11132011-05-10 Juanma Barranquero <lekktu@gmail.com>
1114
1115 * image.c (Finit_image_library): Return t for built-in image types,
1116 like pbm and xbm. (Bug#8640)
1117
57679c86
AS
11182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1119
1120 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1121
888c9e86
EZ
11222011-05-07 Eli Zaretskii <eliz@gnu.org>
1123
b0512a1d
EZ
1124 * w32console.c (Fset_screen_color): Doc fix.
1125 (Fget_screen_color): New function.
1126 (syms_of_ntterm): Defsubr it.
1127
7285dc67
EZ
1128 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1129 unlink the temporary file if Fcall_process didn't create it in the
1130 first place.
1131 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1132 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1133 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1134 cue to call_process_cleanup not to close that handle.
1135
4d3fcc8e
BK
11362011-05-07 Ben Key <bkey76@gmail.com>
1137
1138 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1139 one of two shell specific rules, either bootstrap-temacs-CMD or
1140 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1141 to the previous implementation of the bootstrap-temacs rule.
1142 The bootstrap-temacs-CMD rule is similar to the previous
1143 implementation of the bootstrap-temacs rule except that it
1144 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1145 variable.
1146
1147 These changes, along with some changes to nt/configure.bat,
1148 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1149 earlier fix to add support for --cflags and --ldflags options
1150 that include quotes so that it works whether make uses cmd or
1151 sh as the shell.
1152
b4289b64
MA
11532011-05-06 Michael Albinus <michael.albinus@gmx.de>
1154
1155 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1156 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1157 is a constant.
1158 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1159 a string. Handle both cases.
1160 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1161 (Fdbus_register_method): Use Qinvalid_function.
1162
af4c0e28
JB
11632011-05-06 Juanma Barranquero <lekktu@gmail.com>
1164
1165 * makefile.w32-in: Update dependencies.
1166 (LISP_H): Add inttypes.h and stdin.h.
1167 (PROCESS_H): Add unistd.h.
1168
c51453d9
EZ
11692011-05-06 Eli Zaretskii <eliz@gnu.org>
1170
1171 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1172 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1173
8ff0ac3c 11742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1175
4c4b566b
PE
1176 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1177
aab2b9b5
PE
1178 * term.c (vfatal): Remove stray call to va_end.
1179 It's not needed and the C Standard doesn't allow it here anyway.
1180
c378da0b
PE
1181 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1182 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1183
288b08c7
PE
1184 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1185 bytes.
1186
e3601888
PE
1187 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1188
db6c0e74
PE
1189 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1190
dd5963ea
PE
1191 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1192
88c9450f
PE
1193 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1194
2f9442b8
PE
1195 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1196
c032b5f8
PE
1197 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1198 * charset.c (Fdefine_charset_internal): Don't initialize
1199 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1200 32-bit int (Bug#8600).
a108c10b
PE
1201
1202 * lread.c (read_integer): Be more consistent with string-to-number.
1203 Use string_to_number to do the actual conversion; this avoids
1204 rounding errors and fixes some other screwups. Without this fix,
1205 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1206 (digit_to_number): Move earlier, for benefit of read_integer.
1207 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1208 not a digit in any supported base. (Bug#8602)
a108c10b 1209
ad5f9eea
PE
1210 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1211
aec1708a
PE
1212 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1213 to match comment at start of function. This also removes a
1214 GCC warning about overflow in a 32+64-bit port.
1215
47be4ab5
PE
1216 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1217
371cac43
PE
1218 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1219 Reported by Stefan Monnier in
1220 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1221 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1222 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1223
d01a7826
PE
1224 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1225 (EMACS_UINTPTR): Likewise, with uintptr_t.
1226
7fd47d5c
PE
1227 * lisp.h: Prefer 64-bit EMACS_INT if available.
1228 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1229 on 32-bit hosts that have 64-bit int, so that they can access
1230 large files.
122b0c86
PE
1231 However, temporarily disable this change unless the temporary
1232 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1233
8727937b
PE
1234 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1235
8ac068ac
PE
1236 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1237 This removes an assumption that EMACS_INT and long are the same
1238 width as pointers. The assumption is true for Emacs porting targets
1239 now, but we want to make other targets possible.
1240 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1241 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1242 In the rest of the code, change types of integers that hold casted
1243 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1244 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1245 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1246 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1247 No need to cast type when ORing.
1248 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1249 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1250 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1251 assume EMACS_INT is the same width as char *.
1252 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1253 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1254 Remove no-longer-needed casts.
1255 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1256 (xg_tool_bar_help_callback, xg_make_tool_item):
1257 Use EMACS_INTPTR to hold an integer
1258 that will be cast to void *; this can avoid a GCC warning
1259 if EMACS_INT is not the same width as void *.
1260 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1261 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1262 (current_message_1, set_message_1):
1263 Use a local to convert to proper width without a cast.
1264 * xmenu.c (dialog_selection_callback): Likewise.
1265
ede49d71
PE
1266 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1267 Also, don't assume VALBITS / RAND_BITS is less than 5,
1268 and don't rely on undefined behavior when shifting a 1 left into
1269 the sign bit.
1270 * lisp.h (get_random): Change signature to match.
1271
2f30ecd0
PE
1272 * lread.c (hash_string): Use size_t, not int, for hash computation.
1273 Normally we prefer signed values; but hashing is special, because
1274 it's better to use unsigned division on hash table sizes so that
1275 the remainder is nonnegative. Also, size_t is the natural width
1276 for hashing into memory. The previous code used 'int', which doesn't
1277 retain enough info to hash well into very large tables.
1278 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1279
2a866e7b
PE
1280 * dbusbind.c: Don't possibly lose pointer info when converting.
1281 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1282 Use XPNTR rather than XHASH, so that the high-order bits of
1283 the pointer aren't lost when converting through void *.
1284
51639eac
PE
1285 * eval.c (Fautoload): Don't double-shift a pointer.
1286
92394119
PE
1287 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1288
dbdb9a7c
JB
12892011-05-06 Juanma Barranquero <lekktu@gmail.com>
1290
1291 * gnutls.c (DEF_GNUTLS_FN):
1292 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1293
db7a0b4f
AS
12942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1295
1296 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1297 marker. (Bug#8610)
1298
f7ff1b0f 12992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1300
1301 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1302 New version that can reserve upto 2GB of heap space.
1303
f7ff1b0f 13042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1305
1306 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1307
639c109b
TZ
13082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1309
1310 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1311 `gnutls_certificate_set_x509_key_file'.
1312
d2127135
JB
13132011-05-05 Juanma Barranquero <lekktu@gmail.com>
1314
1315 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1316 Update dependencies.
1317
e968f4f3
JB
13182011-05-04 Juanma Barranquero <lekktu@gmail.com>
1319
1320 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1321 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1322 Remove unused parameter `fildes'.
1323 * process.c (read_process_output, send_process): Don't pass it.
1324
84d358f0
JB
13252011-05-04 Juanma Barranquero <lekktu@gmail.com>
1326
1327 Fix previous change: the library cache is defined in w32.c.
1328 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1329 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1330
0898ca10
JB
13312011-05-04 Juanma Barranquero <lekktu@gmail.com>
1332
1333 Implement dynamic loading of GnuTLS on Windows.
1334
1335 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1336 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1337 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1338 Declare.
1339
1340 * gnutls.c (Qgnutls_dll): Define.
1341 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1342 (gnutls_*): Declare function pointers.
1343 (init_gnutls_functions): New function to initialize function pointers.
1344 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1345 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1346 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1347 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1348 (emacs_gnutls_write, emacs_gnutls_read)
1349 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1350 (Fgnutls_available_p): New function.
1351 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1352 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1353 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1354
1355 * image.c: Include w32.h.
1356 (Vimage_type_cache): Delete.
1357 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1358 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1359 (w32_delayed_load): Move to w32.c.
1360
1361 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1362
1363 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1364 (w32_delayed_load): Move from image.c. When loading a library, record
1365 its filename in the :loaded-from property of the library id.
1366 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1367 Initialize and staticpro them.
1368 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1369
1370 * process.c: Include lisp.h before w32.h, not after.
1371 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1372 instead of gnutls_record_check_pending.
1373
1374 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1375
ff4de4aa
TZ
13762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1377
1378 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1379 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1380 as passed in.
1381
abe95abb
JD
13822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1383
1384 * xterm.c (x_set_frame_alpha): Do not set property on anything
1385 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1386
e16e55d4
JB
13872011-05-02 Juanma Barranquero <lekktu@gmail.com>
1388
1389 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1390
bafcf6a5
JB
13912011-05-02 Juanma Barranquero <lekktu@gmail.com>
1392
1393 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1394 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1395 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1396 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1397 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1398 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1399 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1400 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1401 (Qgnutls_bootprop_callbacks_verify): Make static.
1402
e7a6747f
AS
14032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1404
19ed11ba
AS
1405 * callproc.c: Indentation fixup.
1406
e7a6747f 1407 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1408 (wait_for_termination, interruptible_wait_for_termination):
1409 Move after wait_for_termination_1.
e7a6747f 1410
1ef14cb4
LMI
14112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1412
1413 * sysdep.c (interruptible_wait_for_termination): New function
1414 which is like wait_for_termination, but allows keyboard
1415 interruptions.
1416
1417 * callproc.c (Fcall_process): Add (:file "file") as an option for
1418 the STDOUT buffer.
1419 (Fcall_process_region): Ditto.
1420
330d880c
EZ
14212011-04-30 Eli Zaretskii <eliz@gnu.org>
1422
8db90b73
EZ
1423 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1424 rather than `XVECTOR (FOO)->size'.
1425
330d880c
EZ
1426 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1427 inttypes.h, as a gnulib replacement is used if it not available in
1428 system headers.
1429
15cbd324
EZ
14302011-04-21 Eli Zaretskii <eliz@gnu.org>
1431
1432 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1433 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1434 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1435
1436 * coding.c (coding_alloc_by_realloc): Error out if destination
1437 will grow beyond MOST_POSITIVE_FIXNUM.
1438 (decode_coding_emacs_mule): Abort if there isn't enough place in
1439 charbuf for the composition carryover bytes. Reserve an extra
1440 space for up to 2 characters produced in a loop.
1441 (decode_coding_iso_2022): Abort if there isn't enough place in
1442 charbuf for the composition carryover bytes.
1443
14442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1445
ae940cca
EZ
1446 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1447 aborting when %lld or %lll format is passed.
1448 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1449 %llo or %llx format is passed. (Bug#8545)
1450
03ab8921
EZ
1451 * window.c (window_scroll_line_based): Use a marker instead of
1452 simple variables to record original value of point. (Bug#7952)
1453
afda1437
EZ
1454 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1455 produced by %s or %c overflows available buffer space. (Bug#8545)
1456
f76dee0c
PE
14572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1460 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1461
fdc5744d
JB
14622011-04-28 Juanma Barranquero <lekktu@gmail.com>
1463
1464 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1465
638f053a
JB
14662011-04-28 Juanma Barranquero <lekktu@gmail.com>
1467
1468 * keyboard.c (Qdelayed_warnings_hook): Define.
1469 (command_loop_1): Run `delayed-warnings-hook'
1470 if Vdelayed_warnings_list is non-nil.
1471 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1472 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1473
d178f871
EZ
14742011-04-28 Eli Zaretskii <eliz@gnu.org>
1475
1476 * doprnt.c (doprnt): Don't return value smaller than the buffer
1477 size if the message was truncated. (Bug#8545).
1478
b124fd93
JB
14792011-04-28 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1482 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1483
e810457d
PE
14842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1485
1486 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1487
ea51cceb
JB
14882011-04-27 Juanma Barranquero <lekktu@gmail.com>
1489
1490 * makefile.w32-in: Update dependencies.
1491
94dcfacf
EZ
14922011-04-27 Eli Zaretskii <eliz@gnu.org>
1493
1494 Improve `doprnt' and its usage. (Bug#8545)
1495 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1496 `format_end'. Remove support for %l as a conversion specifier.
1497 Don't use xrealloc. Improve diagnostics when the %l size modifier
1498 is used. Update the commentary.
1499
1500 * eval.c (verror): Simplify calculation of size_t.
1501
1502 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1503 messages.
1504
f61f41d7
PE
15052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1506
1507 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1508 change.
1509
96fb4434
PE
15102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1513 This makes this file independent of the recent pseudovector change.
1514
671875da 15152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1516
69e9b5a3
PE
1517 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1518
b5f869a7 1519 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1520 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1521 Remove unused local.
c8926152 1522 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1523
841a1577 1524 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1525 GCC 4.6.0 optimizes based on type-based alias analysis.
1526 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1527 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1528 != &v->size, and therefore "v->size = 1; b->size = 2; return
1529 v->size;" must therefore return 1. This assumption is incorrect
1530 for Emacs, since it type-puns struct Lisp_Vector * with many other
1531 types. To fix this problem, this patch adds a new type struct
f904488f 1532 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1533 and pseudovectors, and helps optimizing compilers not get fooled
1534 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1535 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1536 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1537 the size member.
eab3844f
PE
1538 (XSETPVECTYPE): Rewrite in terms of new macro.
1539 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1540 This is a bit clearer, and further avoids the possibility of
1541 undesirable aliasing.
1542 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1543 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1544 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1545 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1546 (ASIZE): Now uses header.size rather than size.
1547 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1548 to avoid the hassle of writing XVECTOR (foo)->header.size.
1549 (struct vectorlike_header): New type.
eab3844f
PE
1550 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1551 object, to help avoid aliasing.
1552 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1553 (SUBRP): Likewise, since Lisp_Subr is a special case.
1554 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1555 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1556 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1557 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1558 changed to be "header.size" and "header.next".
1559 * buffer.h (struct buffer): Likewise.
1560 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1561 * frame.h (struct frame): Likewise.
1562 * process.h (struct Lisp_Process): Likewise.
1563 * termhooks.h (struct terminal): Likewise.
1564 * window.c (struct save_window_data, struct saved_window): Likewise.
1565 * window.h (struct window): Likewise.
1566 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1567 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1568 * buffer.c (init_buffer_once): Likewise.
1569 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1570 special case.
1571 * process.c (Fformat_network_address): Use local var for size,
1572 for brevity.
1573
0df1eac5
PE
1574 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1575
847ab9d1 1576 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1577 * data.c (atof): Remove decl; no longer used or needed.
1578 (digit_to_number): Move to lread.c.
1579 (Fstring_to_number): Use new string_to_number function, to be
1580 consistent with how the Lisp reader treats infinities and NaNs.
1581 Do not assume that floating-point numbers represent EMACS_INT
1582 without losing information; this is not true on most 64-bit hosts.
1583 Avoid double-rounding errors, by insisting on integers when
1584 parsing non-base-10 numbers, as the documentation specifies.
1585 * lisp.h (string_to_number): New decl, replacing ...
1586 (isfloat_string): Remove.
bc0a5c13 1587 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1588 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1589 appears to have been a coding error. Similarly, do not accept
1590 strings like +-1e0 as floating point numbers. Do not report
1591 overflow for integer overflows unless the base is not 10 which
1592 means we have no simple and reliable way to continue.
1593 Break out the floating-point parsing into a new
1594 function string_to_number, so that Fstring_to_number parses
1595 floating point numbers consistently with the Lisp reader.
04f2d78b 1596 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1597 (E_CHAR, EXP_INT): Remove, replacing with ...
1598 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1599 (string_to_number): New function, replacing isfloat_string.
1600 This function checks for valid syntax and produces the resulting
1601 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1602 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1603 so that overflow for non-base-10 numbers is reported only when
1604 there's no portable and simple way to convert to floating point.
452f4150 1605
67769ffc
PE
1606 * textprop.c (set_text_properties_1): Rewrite for clarity,
1607 and to avoid GCC warning about integer overflow.
1608
c20db43f
PE
1609 * intervals.h (struct interval): Use EMACS_INT for members
1610 where EMACS_UINT might cause problems. See
1611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1612 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1613 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1614 All uses changed.
37aa2f85
PE
1615 (offset_intervals): Tell GCC not to worry about length overflow
1616 when negating a negative length.
c20db43f 1617
2538aa2f
PE
1618 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1619 (overrun_check_free): Likewise.
1620
f2d3008d
PE
1621 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1622 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1623 word size.
1624
ec8df744
PE
1625 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1626 (gnutls_make_error): Rename local to avoid shadowing.
1627 (gnutls_emacs_global_deinit): ifdef out; not used.
1628 (Fgnutls_boot): Use const for pointer to readonly storage.
1629 Comment out unused local. Fix pointer signedness problems.
1630
640ee02d
PE
1631 * lread.c (openp): Don't stuff size_t into an 'int'.
1632 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1633 about possible signed overflow.
1634
6048fb2a
PE
1635 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1636 (GDK_KEY_g): Don't define if already defined.
1637 (xg_prepare_tooltip): Avoid pointer signedness problem.
1638 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1639
fa3c87e1
PE
1640 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1641 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1642
2172544b
PE
1643 * xfns.c (Fx_window_property): Simplify a bit,
1644 to make a bit faster and to avoid GCC 4.6.0 warning.
1645 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1646
9b821a21
PE
1647 * fns.c (internal_equal): Don't assume size_t fits in int.
1648
3c616cfa
PE
1649 * alloc.c (compact_small_strings): Tighten assertion a little.
1650
c2982e87
PE
1651 Replace pEd with more-general pI, and fix some printf arg casts.
1652 * lisp.h (pI): New macro, generalizing old pEd macro to other
1653 conversion specifiers. For example, use "...%"pI"d..." rather
1654 than "...%"pEd"...".
1655 (pEd): Remove. All uses replaced with similar uses of pI.
1656 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1657 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1658 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1659 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1660 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1661 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1662 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1663 64-bit hosts.
1664 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1665 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1666 * print.c (safe_debug_print, print_object): Likewise.
1667 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1668 to int.
6f04d126
PE
1669 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1670 avoiding the 0 flag, which is not portable.
c2982e87
PE
1671 * process.c (Fmake_network_process): Use pI to avoid cast.
1672 * region-cache.c (pp_cache): Likewise.
1673 * xdisp.c (decode_mode_spec): Likewise.
1674 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1675 behavior on 64-bit hosts with printf arg.
6f04d126 1676 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1677 (x_stop_queuing_selection_requests): Likewise.
1678 (x_get_window_property): Don't truncate byte count to an 'int'
1679 when tracing.
0b432f21 1680
5e073ec7
PE
1681 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1682 here, since it parses constructs like leading '-' and spaces,
1683 which are not wanted; and it overflows with large numbers.
1684 Instead, simply match F[0-9]+, which is what is wanted anyway.
1685
36372bf9
PE
1686 * alloc.c: Remove unportable assumptions about struct layout.
1687 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1688 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1689 (allocate_vectorlike, make_pure_vector): Use the new macros,
1690 plus offsetof, to remove unportable assumptions about struct layout.
1691 These assumptions hold on all porting targets that I know of, but
1692 they are not guaranteed, they're easy to remove, and removing them
1693 makes further changes easier.
1694
0b432f21
PE
1695 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1696 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1697 (string_overrun_cookie): Now const. Use initializers that
1698 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1699 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1700 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1701 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1702 multiple of sizeof (EMACS_INT); it need not be, if
1703 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1704 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1705
895009e1
JB
17062011-04-26 Juanma Barranquero <lekktu@gmail.com>
1707
1708 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1709
6a7a1b0b
TZ
17102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1711
1712 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1713 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1714 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1715
841a1577 17162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1717
1718 * lisp.h (Qdebug): List symbol.
895009e1 1719 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1720 * keyboard.c (debug-on-event): New variable.
1721 (handle_user_signal): Break into debugger when debug-on-event
1722 matches the current signal symbol.
1723
f2d3ba6f
DN
17242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1725
1726 * alloc.c (check_sblock, check_string_bytes)
1727 (check_string_free_list): Convert to standard C.
1728
42ce4c63
TZ
17292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1730
1731 * w32.c (emacs_gnutls_push): Fix typo.
1732
825cd63c
EZ
17332011-04-25 Eli Zaretskii <eliz@gnu.org>
1734
fb11d64d
EZ
1735 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1736 "cast to pointer from integer of different size".
1737
825cd63c
EZ
1738 Improve doprnt and its use in verror. (Bug#8545)
1739 * doprnt.c (doprnt): Document the set of format control sequences
1740 supported by the function. Use SAFE_ALLOCA instead of always
1741 using `alloca'.
1742
1743 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1744 is one byte too soon. Don't use xrealloc; instead xfree and
1745 xmalloc anew.
1746
e061a11b
TZ
17472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1748
1749 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1750 callbacks stage.
1751
1752 * gnutls.c: Renamed global_initialized to
1753 gnutls_global_initialized. Added internals for the
1754 :verify-hostname-error, :verify-error, and :verify-flags
1755 parameters of `gnutls-boot' and documented those parameters in the
1756 docstring. Start callback support.
1757 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1758 unless a fatal error occured. Call gnutls_alert_send_appropriate
1759 on error. Return error code.
1760 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1761 (emacs_gnutls_read): Likewise.
1762 (Fgnutls_boot): Return handshake error code.
1763 (emacs_gnutls_handle_error): New function.
1764 (wsaerror_to_errno): Likewise.
1765
1766 * w32.h (emacs_gnutls_pull): Add prototype.
1767 (emacs_gnutls_push): Likewise.
1768
1769 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1770 (emacs_gnutls_push): Likewise.
1771
17722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1773
1774 * process.c (wait_reading_process_output): Check if GnuTLS
1775 buffered some data internally if no FDs are set for TLS
1776 connections.
1777
1778 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1779 (LIBS): Link to USER_LIBS.
1780 ($(BLD)/gnutls.$(0)): New target.
1781
fa6996bc
EZ
17822011-04-24 Eli Zaretskii <eliz@gnu.org>
1783
eb35682e
EZ
1784 * xdisp.c (handle_single_display_spec): Rename the
1785 display_replaced_before_p argument into display_replaced_p, to
1786 make it consistent with the commentary. Fix typos in the
1787 commentary.
1788
e2ad650c
EZ
1789 * textprop.c (syms_of_textprop): Remove dead code.
1790 (copy_text_properties): Delete obsolete commentary about an
1791 interface that was deleted long ago. Fix typos in the description
1792 of arguments.
1793
1b2de274
EZ
1794 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1795 to changes in oldXMenu/XMenu.h from 2011-04-16.
1796 <menu_help_message, prev_menu_help_message>: Constify.
1797 (IT_menu_make_room): menu->help_text is now `const char **';
1798 adjust.
1799
1800 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1801 to changes in oldXMenu/XMenu.h from 2011-04-16.
1802 (struct XMenu): Declare `help_text' `const char **'.
1803
1804 * xfaces.c <Qunspecified>: Make extern again.
1805
1806 * syntax.c: Include sys/types.h before including regex.h, as
1807 required by Posix.
1808
762b15be
EZ
1809 * doc.c (get_doc_string): Improve the format passed to `error'.
1810
1811 * doprnt.c (doprnt): Improve commentary.
1812
1813 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1814
1815 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1816 them with etags.
1817
f1052e5d
EZ
1818 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1819 changes in globals.h immediately force recompilation.
762b15be
EZ
1820 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1821 $(CURDIR)/s/ms-w32.h.
1822 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1823
fa6996bc
EZ
1824 * character.c (Fchar_direction): Function deleted.
1825 (syms_of_character): Don't defsubr it.
1826 <char-direction-table>: Deleted.
1827
e6c3da20
EZ
18282011-04-23 Eli Zaretskii <eliz@gnu.org>
1829
1830 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1831 * doprnt.c: Include limits.h.
1832 (SIZE_MAX): New macro.
04f2d78b
CB
1833 (doprnt): Return a size_t value. 2nd arg is now size_t.
1834 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1835 Improve overflow protection. Support `l' modifier for integer
1836 conversions. Support %l conversion. Don't assume an EMACS_INT
1837 argument for integer conversions and for %c.
1838
1839 * lisp.h (doprnt): Restore prototype.
1840
1841 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1842 $(SRC)/character.h.
1843
1844 * Makefile.in (base_obj): Add back doprnt.o.
1845
1846 * deps.mk (doprnt.o): Add back prerequisites.
1847 (callint.o): Depend on character.h.
1848
1849 * eval.c (internal_lisp_condition_case): Include the handler
1850 representation in the error message.
1851 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1852 when breaking from the loop.
1853
1854 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1855
1856 * callint.c (Fcall_interactively): When displaying error message
1857 about invalid control letter, pass the character's codepoint, not
1858 a pointer to its multibyte form. Improve display of the character
1859 in octal and display also its hex code.
1860
1861 * character.c (char_string): Use %x to display the (unsigned)
1862 codepoint of an invalid character, to avoid displaying a bogus
1863 negative value.
1864
1865 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1866 `error', not SYMBOL_NAME itself.
1867
1868 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1869 character arguments to `error'.
1870
1871 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1872 to `error' in error message about FINAL_CHAR argument. Make sure
1873 FINAL_CHAR is a character, and use %c when it is passed as
1874 argument to `error'.
1875
4ffd0d6b 18762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1877
1878 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1879
1880 * w32.c: Include <time.h>.
1881 (sys_localtime): New function.
1882
4ffd0d6b 18832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1884
1885 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1886
4ffd0d6b 1887 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1888
4ffd0d6b 18892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1890
4ffd0d6b
GM
1891 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1892 zombies (Bug#8467).
aac0c6e3 1893
04c56954
EZ
18942011-04-19 Eli Zaretskii <eliz@gnu.org>
1895
1896 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1897 gl_state.e_property when gl_state.object is Qt.
1898
1899 * insdel.c (make_gap_larger): Remove limitation of buffer size
1900 to <= INT_MAX.
1901
16a43933
CY
19022011-04-18 Chong Yidong <cyd@stupidchicken.com>
1903
1904 * xdisp.c (lookup_glyphless_char_display)
1905 (produce_glyphless_glyph): Handle cons cell entry in
1906 glyphless-char-display.
1907 (Vglyphless_char_display): Document it.
1908
1909 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1910 glyphless-char-display.
1911
4581706e
CY
19122011-04-17 Chong Yidong <cyd@stupidchicken.com>
1913
1914 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1915
1916 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1917
1918 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1919 definition for no-X builds.
1920
4887c6e2 19212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1922
fd35b6f9
PE
1923 Static checks with GCC 4.6.0 and non-default toolkits.
1924
5c1ccb01
PE
1925 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1926
006c5daa
PE
1927 * process.c (keyboard_bit_set): Define only if SIGIO.
1928 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1929 (send_process): Repair possible setjmp clobbering.
1930
efc736d3
PE
1931 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1932
4e2fe2e6
PE
1933 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1934
f97334a2
PE
1935 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1936
4e75f29d
PE
1937 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1938 Define only if needed.
1939
90efadd1
PE
1940 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1941 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1942 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1943
3c647824
PE
1944 * dispextern.h (struct redisplay_interface): Rename param
1945 to avoid shadowing.
e264f262 1946 * termhooks.h (struct terminal): Likewise.
761383f4 1947 * xterm.c (xembed_send_message): Likewise.
3c647824 1948
b58c5c4a
PE
1949 * insdel.c (make_gap_smaller): Define only if
1950 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1951
cad59032
PE
1952 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1953 it.
1954
c339dc2e
PE
1955 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1956 so that we aren't warned about unused symbols.
1957
91a3e27b
PE
1958 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1959
399c71d3 1960 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1961
8ffc96f5
PE
1962 * xfns.c (x_real_positions): Mark locals as initialized.
1963
eef9bc79
PE
1964 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1965
098db9dd
PE
1966 * xterm.c: Fix problems found by static analysis with other toolkits.
1967 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1968 (x_dispatch_event): Declare static if USE_GTK, and
1969 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1970 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1971 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1972 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1973 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1974
eb18f6cc
PE
1975 * xmenu.c (menu_help_callback): Pointer type fixes.
1976 Use const pointers when pointing at readonly data. Avoid pointer
1977 signedness clashes.
1978 (FALSE): Remove unused macro.
1979 (update_frame_menubar): Remove unused decl.
1980
1fe72bf8
PE
1981 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1982
60d9e1db
PE
1983 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1984 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1985 (single_menu_item): Rename local to avoid shadowing.
1986
39261c26
PE
1987 * keyboard.c (make_lispy_event): Remove unused local var.
1988
018c5e19
PE
1989 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1990 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1991
63d2b86e
PE
1992 * bitmaps: Change bitmaps from unsigned char back to the X11
1993 compatible char. Avoid the old compiler warnings about
1994 out-of-range initializers by using, for example, '\xab' rather
1995 than 0xab.
1996
aefd87e1
PE
1997 * xgselect.c (xgselect_initialize): Check vs interface
1998 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1999
bf501fb9
PE
2000 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2001
e9829fdf
PE
2002 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2003 to read-only memory.
2004
1086c095
PE
2005 * fns.c (vector): Remove; this old hack is no longer needed.
2006
2baccd04 2007 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2008 Remove unused var.
dde42981 2009 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2010
72391843 2011 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2012
436c16df 2013 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2014 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2015 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2016
92bb796d 2017 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2018 (x_term_init): Remove local to avoid shadowing.
92bb796d 2019
764430a3 2020 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2021
2022 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2023 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2024
d1dfb56c
EZ
20252011-04-16 Eli Zaretskii <eliz@gnu.org>
2026
c4354cb4
EZ
2027 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2028
d1dfb56c
EZ
2029 Fix regex.c, syntax.c and friends for buffers > 2GB.
2030 * syntax.h (struct gl_state_s): Declare character position members
2031 EMACS_INT.
2032
2033 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2034
04f2d78b
CB
2035 * textprop.c (verify_interval_modification, interval_of):
2036 Declare arguments EMACS_INT.
d1dfb56c
EZ
2037
2038 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2039 EMACS_INT.
2040
2041 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2042
2043 * indent.c (Fvertical_motion): Local variable it_start is now
2044 EMACS_INT.
2045
2046 * regex.c (re_match, re_match_2, re_match_2_internal)
2047 (bcmp_translate, regcomp, regexec, print_double_string)
2048 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2049 (re_compile_pattern, re_exec): Declare arguments and local
2050 variables `size_t' and `ssize_t' and return values `regoff_t', as
2051 appropriate.
2052 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2053 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2054 <compile_stack_type>: `size' and `avail' are now `size_t'.
2055
2056 * regex.h <regoff_t>: Use ssize_t, not int.
2057 (re_search, re_search_2, re_match, re_match_2): Arguments that
2058 specify buffer/string position and length are now ssize_t and
2059 size_t. Return type is regoff_t.
2060
613052cd
BK
20612011-04-16 Ben Key <bkey76@gmail.com>
2062
2063 * nsfont.m: Fixed bugs in ns_get_family and
2064 ns_descriptor_to_entity that were caused by using free to
2065 deallocate memory blocks that were allocated by xmalloc (via
2066 xstrdup). This caused Emacs to crash when compiled with
2067 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2068 --enable-checking=xmallocoverrun). xfree is now used to
2069 deallocate these memory blocks.
2070
4170f62f 20712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2072
71b41406
PE
2073 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2074
9587a89d
PE
2075 emacs_write: Accept and return EMACS_INT for sizes.
2076 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2077 et seq.
2078 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2079 Accept and return EMACS_INT.
2080 (emacs_gnutls_write): Return the number of bytes written on
2081 partial writes.
2082 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2083 (emacs_read, emacs_write): Remove check for negative size, as the
2084 Emacs source code has been audited now.
9587a89d
PE
2085 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2086 (emacs_read, emacs_write): Use it.
273a5f82
PE
2087 * process.c (send_process): Adjust to the new signatures of
2088 emacs_write and emacs_gnutls_write. Do not attempt to store
2089 a byte offset into an 'int'; it might overflow.
9587a89d 2090 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2091
3e047f51
PE
2092 * sound.c: Don't assume sizes fit in 'int'.
2093 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2094 Return EMACS_INT, not int.
3e047f51 2095 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2096 Accept EMACS_INT, not int.
2097 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2098 record read return values.
2099
cc39a9db
BK
21002011-04-15 Ben Key <bkey76@gmail.com>
2101
c9d0ec6d
JB
2102 * keyboard.c (Qundefined): Don't declare static since it is used
2103 in nsfns.m.
2104 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2105 static since they are used in nsfont.m.
cc39a9db 2106
6c60eb9f
SM
21072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2108
2109 * process.c (Qprocessp): Don't declare static.
2110 * lisp.h (Qprocessp): Declare again.
2111
7990b61a
JB
21122011-04-15 Juanma Barranquero <lekktu@gmail.com>
2113
2114 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2115
5d4cb038
PE
21162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2117
8bd7b830 2118 Improve C-level modularity by making more things 'static'.
cd64ea1d 2119
e3b27b31
PE
2120 Don't publish debugger-only interfaces to other modules.
2121 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2122 (verify_bytepos, count_markers): Move decls to the only modules
2123 that need them.
2124 * region-cache.h (pp_cache): Likewise.
2125 * window.h (check_all_windows): Likewise.
2126 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2127
5d4cb038
PE
2128 * sysdep.c (croak): Now static, if
2129 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2130 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2131
2132 * alloc.c (refill_memory_reserve): Now static if
2133 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2134 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2135
e87b6180
PE
2136 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2137 Define only if USE_LUCID.
2138
ac64929e
PE
2139 * xrdb.c (x_customization_string, x_rm_string): Now static.
2140
6f37259d
PE
2141 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2142 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2143
1683e3ab
PE
2144 * xdisp.c (draw_row_with_mouse_face): Now static.
2145 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2146
de9c2632
PE
2147 * window.h (check_all_windows): Mark externally visible.
2148
2b96acb7
PE
2149 * window.c (window_deletion_count): Now static.
2150
2151 * undo.c: Make symbols static if they're not exported.
2152 (last_undo_buffer, last_boundary_position, pending_boundary):
2153 Now static.
2154
50436f33
PE
2155 * textprop.c (interval_insert_behind_hooks): Now static.
2156 (interval_insert_in_front_hooks): Likewise.
2157
64520e5c
PE
2158 * term.c: Make symbols static if they're not exported.
2159 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2160 (max_frame_lines, tty_set_terminal_modes):
2161 (tty_reset_terminal_modes, tty_turn_off_highlight):
2162 (get_tty_terminal): Now static.
2163 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2164 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2165 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2166 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2167 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2168
1fa53021
PE
2169 * sysdep.c: Make symbols static if they're not exported.
2170 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2171 Now static.
2172 (sigprocmask_set, full_mask): Remove; unused.
2173 (wait_debugging): Mark as visible.
2174 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2175 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2176
d4b43b22
PE
2177 * syntax.c (syntax_temp): Define only if !__GNUC__.
2178
b7c513d0
PE
2179 * sound.c (current_sound_device, current_sound): Now static.
2180
989b29ad
PE
2181 * search.c (searchbufs, searchbuf_head): Now static.
2182
13a55a78
PE
2183 * scroll.c (scroll_cost): Remove; unused.
2184 * dispextern.h (scroll_cost): Remove decl.
2185
de68a1fc
PE
2186 * region-cache.h (pp_cache): Mark as externally visible.
2187
40ccffa6
PE
2188 * process.c: Make symbols static if they're not exported.
2189 (process_tick, update_tick, create_process, chan_process):
2190 (Vprocess_alist, proc_buffered_char, datagram_access):
2191 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2192 (deactivate_process): Mark defn as static, as well as decl.
2193 * lisp.h (create_process): Remove decl.
2194 * process.h (chan_process, Vprocess_alist): Remove decls.
2195
ad64fc97
PE
2196 * print.c: Make symbols static if they're not exported.
2197 (print_depth, new_backquote_output, being_printed, print_buffer):
2198 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2199 (print_interval, print_number_index, initial_stderr_stream):
2200 Now static.
2201 * lisp.h (Fprinc): Remove decl.
2202 (debug_output_compilation_hack): Mark as externally visible.
2203
adddb265
PE
2204 * sysdep.c (croak): Move decl from here to syssignal.h.
2205 * syssignal.h (croak): Put it here, so the API can be checked when
2206 'croak' is called from dissociate_if_controlling_tty.
2207
1717ede2
PE
2208 * minibuf.c: Make symbols static if they're not exported.
2209 (minibuf_save_list, choose_minibuf_frame): Now static.
2210 * lisp.h (choose_minibuf_frame): Remove decl.
2211
fa5fb2bc
PE
2212 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2213
1e3890d1
PE
2214 * lread.c: Make symbols static if they're not exported.
2215 (read_objects, initial_obarray, oblookup_last_bucket_number):
2216 Now static.
2217 (make_symbol): Remove; unused.
2218 * lisp.h (initial_obarray, make_symbol): Remove decls.
2219
8a1414fa
PE
2220 * keyboard.c: Make symbols static if they're not exported.
2221 (single_kboard, recent_keys_index, total_keys, recent_keys):
2222 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2223 (this_single_command_key_start, echoing, last_auto_save):
2224 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2225 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2226 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2227 (Vlispy_mouse_stem, double_click_count):
2228 Now static.
2229 (force_auto_save_soon): Define only if SIGDANGER.
2230 (ignore_mouse_drag_p): Now static if
2231 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2232 (print_help): Remove; unused.
2233 (stop_character, last_timer_event): Mark as externally visible.
2234 * keyboard.h (ignore_mouse_drag_p): Declare only if
2235 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2236 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2237 * lisp.h (echoing): Remove decl.
2238 (force_auto_save_soon): Declare only if SIGDANGER.
2239 * xdisp.c (redisplay_window): Simplify code, to make it more
2240 obvious that ignore_mouse_drag_p is not accessed if !defined
2241 USE_GTK && !defined HAVE_NS.
2242
93ea6e8f
PE
2243 * intervals.c: Make symbols static if they're not exported.
2244 (merge_properties_sticky, merge_interval_right, delete_interval):
2245 Now static.
2246 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2247
77382fcc
PE
2248 * insdel.c: Make symbols static if they're not exported.
2249 However, leave prepare_to_modify_buffer alone. It's never
2250 called from outside this function, but that appears to be a bug.
2251 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2252 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2253 (adjust_after_replace_noundo): Remove; unused.
2254 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2255 (signal_before_change): Remove decls.
77382fcc 2256
9306c32e
PE
2257 * indent.c (val_compute_motion, val_vmotion): Now static.
2258
cd44d2eb
PE
2259 * image.c: Make symbols static if they're not exported.
2260 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2261 if USE_GTK.
2262 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2263 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2264
ad9a7a06
PE
2265 * fringe.c (standard_bitmaps): Now static.
2266 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2267
81626931
PE
2268 * frame.c: Make symbols static if they're not exported.
2269 (x_report_frame_params, make_terminal_frame): Now static.
2270 (get_frame_param): Now static, unless HAVE_NS.
2271 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2272 (x_get_resource_string): Remove; not used.
2273 * frame.h (make_terminal_frame, x_report_frame_params):
2274 (x_get_resource_string); Remove decls.
2275 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2276 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2277
239f9db9
PE
2278 * font.c, fontset.c: Make symbols static if they're not exported.
2279 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2280 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2281 * font.c (font_close_object): Now static.
2282 * font.h (font_close_object): Remove.
2283 * fontset.c (FONTSET_OBJLIST): Remove.
2284 (free_realized_fontset) #if-0 the body, which does nothing.
2285 (face_suitable_for_char_p): #if-0, as it's never called.
2286 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2287 * xfaces.c (face_at_string_position):
2288 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2289 since 0 is always ASCII.
2290
dfcf3579
PE
2291 * fns.c (weak_hash_tables): Now static.
2292
5045092b
PE
2293 * fileio.c: Make symbols static if they're not exported.
2294 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2295 (Vwrite_region_annotation_buffers): Now static.
2296
57a96f5c
PE
2297 * eval.c: Make symbols static if they're not exported.
2298 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2299 * lisp.h (backtrace_list): Remove decl.
2300
35f08c38
PE
2301 * emacs.c: Make symbols static if they're not exported.
2302 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2303 (fatal_error_code, fatal_error_signal_hook, standard_args):
2304 Now static.
2305 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2306 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2307 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2308 * lisp.h (fatal_error_signal_hook): Remove decl.
2309 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2310
f44bd759
PE
2311 * editfns.c: Move a (normally-unused) function to its only use.
2312 * editfns.c, lisp.h (get_operating_system_release): Remove.
2313 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2314 worth the hassle of breaking this out.
2315
b532497d
PE
2316 * xterm.c: Make symbols static if they're not exported.
2317 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2318 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2319 (x_destroy_window, x_delete_display):
2320 Now static.
2321 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2322 (x_mouse_leave): Remove; unused.
2323 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2324 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2325 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2326 Remove decls.
2327 (x_mouse_leave): Declare only if WINDOWSNT.
2328 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2329 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2330 USE_X_TOOLKIT.
2331
1675728f
PE
2332 * ftxfont.c: Make symbols static if they're not exported.
2333 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2334 HAVE_FREETYPE.
2335 * font.h (ftxfont_driver): Likewise.
2336
e4cebfca
PE
2337 * xfns.c: Make symbols static if they're not exported.
2338 (x_last_font_name, x_display_info_for_name):
2339 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2340 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2341 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2342 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2343 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2344 (last_show_tip_args): Now static.
2345 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2346 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2347 (x_screen_planes): Remove; unused.
2348 * dispextern.h (x_screen_planes): Remove decl.
2349
5bf46f05
PE
2350 * dispnew.c: Make symbols static if they're not exported.
2351 * dispextern.h (redraw_garbaged_frames, scrolling):
2352 (increment_row_positions): Remove.
2353 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2354 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2355 Now static.
2356 (redraw_garbaged_frames): Remove; unused.
2357
435f4c28
PE
2358 * xfaces.c: Make symbols static if they're not exported.
2359 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2360 Remove decls.
2361 * xterm.h (defined_color): Remove decls.
2362 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2363 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2364 (menu_face_changed_default, defined_color, free_realized_face):
2365 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2366 (ascii_face_of_lisp_face): Remove; unused.
2367
8524aef3
PE
2368 * xdisp.c: Make symbols static if they're not exported.
2369 * dispextern.h (scratch_glyph_row, window_box_edges):
2370 (glyph_to_pixel_coords, set_cursor_from_row):
2371 (get_next_display_element, set_iterator_to_next):
2372 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2373 (show_mouse_face): Remove decls
2374 * frame.h (message_buf_print): Likewise.
2375 * lisp.h (pop_message, set_message, check_point_in_composition):
2376 Likewise.
2377 * xterm.h (set_vertical_scroll_bar): Likewise.
2378 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2379 (message_buf_print, scratch_glyph_row, displayed_buffer):
2380 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2381 (get_next_display_element, show_mouse_face, window_box_edges):
2382 (frame_to_window_pixel_xy, check_point_in_composition):
2383 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2384 (glyph_to_pixel_coords): Remove; unused.
2385
16390cd2
PE
2386 * dired.c (file_name_completion): Now static.
2387
2388 * dbusbind.c (xd_in_read_queued_messages): Now static.
2389
a25f4dfa
PE
2390 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2391 * data.c (circular_list_error): Remove.
2392
14a9c8df
PE
2393 * commands.h (last_point_position, last_point_position_buffer):
2394 (last_point_position_window): Remove decls.
2395 * keyboard.c: Make these variables static.
2396
04f2d78b
CB
2397 * coding.h (coding, code_convert_region, encode_coding_gap):
2398 Remove decls.
74ab6df5
PE
2399 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2400 (iso_code_class, detect_coding, code_convert_region): Now static.
2401 (encode_coding_gap): Remove; unused.
2402
38dfbee1
PE
2403 * chartab.c (chartab_chars, chartab_bits): Now static.
2404
a2cb4e63
PE
2405 * charset.h (charset_iso_8859_1): Remove decl.
2406 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2407 Now static.
2408
127198fd
PE
2409 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2410 * ccl.c (Vccl_program_table): Now static.
2411 (check_ccl_update): Remove; unused.
2412
d85b608f
PE
2413 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2414 * category.h: ... from here.
2415 * category.c (check_category_table, set_category_set): Now static.
2416
31cd66f3
PE
2417 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2418 * lisp.h: Remove these decls.
2419
c358e587
PE
2420 * buffer.c (buffer_count): Remove unused var.
2421
e78aecca
PE
2422 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2423 so that it's not optimized away.
2424 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2425 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2426 exported only to the debugger.
2427
e192d7d3 2428 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2429 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2430
92470028
PE
2431 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2432 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2433 was inaccessible from Lisp.
2434 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2435 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2436
244ed907
PE
2437 alloc.c: Import and export fewer symbols, and remove unused items.
2438 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2439 is defined.
2440 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2441 it's not optimized away by whole-program optimization.
2442 (message_enable_multibyte, free_misc): Remove.
2443 (catchlist, handlerlist, mark_backtrace):
2444 Declare only if BYTE_MARK_STACK.
2445 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2446 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2447 (message_enable_multibyte): Remove decl.
2448 (free_misc, interval_free_list, float_block, float_block_index):
2449 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2450 (cons_free_list, last_marked_index):
2451 Now static.
2452 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2453 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2454 (mark_backtrace): Define only if BYTE_MARK_STACK.
2455 * xdisp.c (message_enable_multibyte): Now static.
2456
61c2b50e 2457 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2458 This makes it easier for human readers (and static analyzers)
2459 to see whether these variables are used from other modules.
2460 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2461 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2462 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2463 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2464 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2465 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2466 * xmenu.c, xselect.c:
2467 Declare Q* vars static if they are not used in other modules.
2468 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2469 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2470 Remove decls of unexported vars.
2471 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2472
95c82688
PE
2473 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2474
16a97296
PE
2475 Make Emacs functions such as Fatom 'static' by default.
2476 This makes it easier for human readers (and static analyzers)
2477 to see whether these functions can be called from other modules.
2478 DEFUN now defines a static function. To make the function external
2479 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2480 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2481 (Finit_image_library):
16a97296
PE
2482 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2483 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2484 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2485 Remove decls, since these functions are now static.
2486 (Funintern, Fget_internal_run_time): New decls, since these functions
2487 were already external.
95c82688 2488
16a97296
PE
2489 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2490 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2491 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2492 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2493 * keyboard.c, keymap.c, lread.c:
2494 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2495 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2496 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2497 Mark functions with DEFUE instead of DEFUN,
2498 if they are used in other modules.
2499 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2500 decls for now-static functions.
2501 * buffer.h (Fdelete_overlay): Remove decl.
2502 * callproc.c (Fgetenv_internal): Mark as internal.
2503 * composite.c (Fremove_list_of_text_properties): Remove decl.
2504 (Fcomposition_get_gstring): New forward static decl.
2505 * composite.h (Fcomposite_get_gstring): Remove decl.
2506 * dired.c (Ffile_attributes): New forward static decl.
2507 * doc.c (Fdocumntation_property): New forward static decl.
2508 * eval.c (Ffetch_bytecode): New forward static decl.
2509 (Funintern): Remove extern decl; now in .h file where it belongs.
2510 * fileio.c (Fmake_symbolic_link): New forward static decl.
2511 * image.c (Finit_image_library): New forward static decl.
2512 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2513 * intervals.h (Fprevious_property_change):
2514 (Fremove_list_of_text_properties): Remove decls.
2515 * keyboard.c (Fthis_command_keys): Remove decl.
2516 (Fcommand_execute): New forward static decl.
2517 * keymap.c (Flookup_key): New forward static decl.
2518 (Fcopy_keymap): Now static.
2519 * keymap.h (Flookup_key): Remove decl.
2520 * process.c (Fget_process): New forward static decl.
2521 (Fprocess_datagram_address): Mark as internal.
2522 * syntax.c (Fsyntax_table_p): New forward static decl.
2523 (skip_chars): Remove duplicate decl.
2524 * textprop.c (Fprevious_property_change): New forward static decl.
2525 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2526 Now internal.
2527 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2528 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2529
785bbd42
PE
2530 * editfns.c (Fformat): Remove unreachable code.
2531
8b913b57
AS
25322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2533
2534 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2535 change. (Bug#8496)
2536
a6744a35
EZ
25372011-04-13 Eli Zaretskii <eliz@gnu.org>
2538
2539 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2540 when at ZV. (Bug#8487)
2541
e7974947
AS
25422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2543
baad03f0
AS
2544 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2545 (Bug#8437)
2546 * keyboard.c (parse_tool_bar_item): Likewise.
2547 * sound.c (sound_cleanup, alsa_close): Likewise.
2548 * termcap.c (tgetent): Likewise.
2549 * xfns.c (x_default_font_parameter): Likewise.
2550 * xsettings.c (read_and_apply_settings): Likewise.
2551
e7974947
AS
2552 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2553 (overrun_check_free): Protoize.
2554
28272684
PE
25552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2558 since callers should never pass a negative size.
2559 Change the signature to match that of plain 'read' and 'write'; see
2560 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2561 * lisp.h: Update prototypes of emacs_write and emacs_read.
2562
11997c76
EZ
25632011-04-11 Eli Zaretskii <eliz@gnu.org>
2564
2565 * xdisp.c (redisplay_window): Don't try to determine the character
2566 position of the scroll margin if the window start point w->startp
e896f03c 2567 is outside the buffer's accessible region. (Bug#8468)
11997c76 2568
8a2cbd72
EZ
25692011-04-10 Eli Zaretskii <eliz@gnu.org>
2570
2571 Fix write-region and its subroutines for buffers > 2GB.
2572 * fileio.c (a_write, e_write): Modify declaration of arguments and
2573 local variables to support buffers larger than 2GB.
2574 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2575
2576 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2577 argument, local variables, and return value.
2578
2579 * lisp.h: Update prototypes of emacs_write and emacs_read.
2580
2581 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2582
4073e537 25832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2584
1ebfdcb6
PE
2585 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2586
b2ded58d
PE
2587 Fix more problems found by GCC 4.6.0's static checks.
2588
7d66342c
PE
2589 * xdisp.c (vmessage): Use a better test for character truncation.
2590
bbf47d44
PE
2591 * charset.c (load_charset_map): <, not <=, for optimization,
2592 and to avoid potential problems with integer overflow.
9248994d 2593 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2594 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2595 * editfns.c (Fformat): Likewise.
1e69125e 2596 * syntax.c (skip_chars): Likewise.
3befa583 2597
e3019616
PE
2598 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2599 This also lets GCC 4.6.0 generate slightly better loop code.
2600
becfa255
PE
2601 * callint.c (Fcall_interactively): <, not <=, for optimization.
2602 (Fcall_interactively): Count the number of arguments produced,
2603 not the number of arguments given. This is simpler and lets GCC
2604 4.6.0 generate slightly better code.
2605
dae0cd48
PE
2606 * ftfont.c: Distingish more carefully between FcChar8 and char.
2607 The previous code passed unsigned char * to a functions like
2608 strlen and xstrcasecmp that expect char *, which does not
2609 conform to the C standard.
2610 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2611 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2612 char * when the C standard requires it.
2613
76032d70
PE
2614 * keyboard.c (read_char): Remove unused var.
2615
eb3f1cc8
PE
2616 * eval.c: Port to Windows vsnprintf (Bug#8435).
2617 Include <limits.h>.
2618 (SIZE_MAX): Define if the headers do not.
2619 (verror): Do not give up if vsnprintf returns a negative count.
2620 Instead, grow the buffer. This ports to Windows vsnprintf, which
2621 does not conform to C99. Problem reported by Eli Zaretskii.
2622 Also, simplify the allocation scheme, by avoiding the need for
2623 calling realloc, and removing the ALLOCATED variable.
2624
70476b54
PE
2625 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2626
12020a9e
PE
2627 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2628 But keep the doprint source code for now, as we might revamp it
2629 and use it again (Bug#8435).
ea6c7ae6
PE
2630 * lisp.h (doprnt): Remove.
2631 * Makefile.in (base_obj): Remove doprnt.o.
2632 * deps.mk (doprnt.o): Remove.
2633
5fdb398c
PE
2634 error: Print 32- and 64-bit integers portably (Bug#8435).
2635 Without this change, on typical 64-bit hosts error ("...%d...", N)
2636 was used to print both 32- and 64-bit integers N, which relied on
2637 undefined behavior.
2638 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2639 New macro.
2640 * lisp.h (error, verror): Mark as printf-like functions.
2641 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2642 Report overflow in size calculations when allocating printf buffer.
2643 Do not truncate output string at its first null byte.
2644 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2645 Truncate the output at a character boundary, since vsnprintf does not
2646 do that.
2647 * charset.c (check_iso_charset_parameter): Convert internal
2648 character to string before calling 'error', since %c now has the
2649 printf meaning.
2650 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2651 overflow when computing char to be passed to 'error'. Do not
2652 pass Lisp_Object to 'error'; pass the integer instead.
2653 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2654 formatted with plain %d.
2655
b189fa66
PE
2656 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2657
bff87ef0
PE
2658 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2659
7e2cac20
PE
2660 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2661
ce4d90b5
PE
2662 * xterm.c (x_catch_errors): Remove duplicate declaration.
2663
266c9547
PE
2664 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2665
79c49ad2
PE
2666 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2667
368f4090
JM
26682011-04-10 Jim Meyering <meyering@redhat.com>
2669
2670 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2671 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2672 return ssize_t not "int", and use size_t as the buffer length.
2673 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2674 * gnutls.h: Update declarations.
2675 * process.c (read_process_output): Use ssize_t, to match.
2676 (send_process): Likewise.
2677
a32d4040
CY
26782011-04-09 Chong Yidong <cyd@stupidchicken.com>
2679
2680 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2681
8546720e 26822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2683
04f2d78b
CB
2684 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2685 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2686
8546720e
GM
2687 * xterm.c (handle_one_xevent):
2688 * xmenu.c (create_and_show_popup_menu):
2689 * xselect.c (x_decline_selection_request)
2690 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2691
0a2f5c1a 26922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2693
2694 Fix some uses of `int' instead of EMACS_INT.
2695 * search.c (string_match_1, fast_string_match)
2696 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2697 (scan_buffer, find_next_newline_no_quit)
2698 (find_before_next_newline, search_command, Freplace_match)
2699 (Fmatch_data): Make some `int' variables be EMACS_INT.
2700
2701 * xdisp.c (display_count_lines): 3rd argument and return value now
2702 EMACS_INT. All callers changed.
2703 (pint2hrstr): Last argument is now EMACS_INT.
2704
2705 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2706 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2707 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2708 (decode_coding_utf_16, decode_coding_emacs_mule)
2709 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2710 (decode_coding_ccl, decode_coding_charset)
2711 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2712 (decode_coding_iso_2022, decode_coding_emacs_mule)
2713 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2714 <char_offset, last_offset>: Declare EMACS_INT.
2715 (encode_coding_utf_8, encode_coding_utf_16)
2716 (encode_coding_emacs_mule, encode_invocation_designation)
2717 (encode_designation_at_bol, encode_coding_iso_2022)
2718 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2719 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2720 Declare EMACS_INT.
2721 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2722 (encode_invocation_designation): Last argument P_NCHARS is now
2723 EMACS_INT.
2724 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2725 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2726
2727 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2728 All users changed.
2729
2730 * ccl.c (Fccl_execute_on_string): Declare some variables
2731 EMACS_INT.
2732
8546720e 27332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2734
2735 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2736
4e19a977
CS
27372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2738
2739 * process.c (Fformat_network_address): Doc fix.
2740
87302331
R
27412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2742
2743 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2744
cbb59342
CY
27452011-04-08 Chong Yidong <cyd@stupidchicken.com>
2746
2747 * keyboard.c (read_char): Call Lisp function help-form-show,
2748 instead of using internal_with_output_to_temp_buffer.
2749 (Qhelp_form_show): New var.
e0d38eeb 2750 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2751
2752 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2753
2754 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2755
e67a13ab
CY
27562011-04-06 Chong Yidong <cyd@stupidchicken.com>
2757
04f2d78b
CB
2758 * process.c (Flist_processes): Remove to Lisp.
2759 (list_processes_1): Delete.
e67a13ab 2760
973f782d
EZ
27612011-04-06 Eli Zaretskii <eliz@gnu.org>
2762
7c106b1e
EZ
2763 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2764
973f782d
EZ
2765 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2766
41cf7d1a 27672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2768
ca23cc88
PE
2769 Fix more problems found by GCC 4.6.0's static checks.
2770
f390e2d5
PE
2771 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2772
42eea0d0
PE
2773 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2774
b69769da 2775 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2776
f9541e84
PE
2777 * xdisp.c (vmessage): Mark as a printf-like function.
2778
13841b55
PE
2779 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2780
c136c10f
PE
2781 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2782
5e2d4a30
PE
2783 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2784 printf-like functions.
2785 (tiff_load): Add casts to remove these marks before passing them
2786 to system-supplied API.
2787
583f48b9
PE
2788 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2789
b25d760e
PE
2790 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2791 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2792 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2793 directly, rather than having caller test rule sign. This avoids
2794 some unnecessary tests.
2795 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2796 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2797 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2798
bc7b6697 2799 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2800 (xfont_open): Avoid unnecessary tests.
bc7b6697 2801
27ccc379
PE
2802 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2803
dcd5c89a
PE
2804 * composite.h, composite.c (composition_gstring_put_cache):
2805 Use EMACS_INT, not int, for length.
2806
b13a45c6
PE
2807 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2808 breaking out part of COMPOSITION_DECODE_RULE.
2809 (COMPOSITION_DECODE_RULE): Use it.
2810 * composite.c (get_composition_id): Remove unused local vars,
2811 by using the new macro.
2812
1e792e4d
PE
2813 * textprop.c (set_text_properties_1): Change while to do-while,
2814 since the condition is always true at first.
2815
dc6c6455 2816 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2817 (interval_deletion_adjustment): Return unsigned value.
2818 All uses changed.
dc6c6455 2819
aba7731a
PE
2820 * process.c (list_processes_1, create_pty, read_process_output):
2821 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2822 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2823 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2824 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2825 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2826
fdfc4bf3
PE
2827 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2828
fca8fe46 2829 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2830 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2831
06a0259a 2832 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2833 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2834 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2835
e7b9e80f
PE
2836 * print.c (print_error_message): Avoid int overflow.
2837
56201685
PE
2838 * font.c (font_list_entities): Redo for clarity,
2839 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2840
78834453 2841 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2842 (font_score): Avoid potential overflow in diff calculation.
78834453 2843
0bc0b309 2844 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2845 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2846
e610eaca
PE
2847 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2848
b895abce
PE
2849 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2850 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2851 can always succeed if overflow has undefined behavior.
2852
1f1d9321 2853 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2854 (wordify): Omit three unnecessary tests.
1f1d9321 2855
c59478bc
PE
2856 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2857 All callers changed. This avoids the need for an unused var.
2858
79b73827
PE
2859 * casefiddle.c (casify_region): Remove var that is set but not used.
2860
a4db5dfe
PE
2861 * dired.c (file_name_completion): Remove var that is set but not used.
2862
43aae36e
PE
2863 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2864
2a47c44d 2865 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2866 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2867
a37c69bf
PE
2868 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2869 Check for integer overflow on size calculations.
2870
328ab8e7
PE
2871 * buffer.c (Fprevious_overlay_change): Remove var that is set
2872 but not used.
2873
e5a2a5cb
PE
2874 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2875 Remove vars that are set but not used.
8d84a6eb 2876 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2877 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2878
a60e5f68
PE
2879 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2880
f661cb61 2881 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2882 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2883
f0397f5a
PE
2884 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2885 that are set but not used.
2886
8664db06 2887 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2888 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2889
6abdaa4a
PE
2890 * xselect.c (x_get_local_selection, x_handle_property_notify):
2891 Remove vars that are set but not used.
2892
0ce7538d 2893 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2894 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2895
9ae848fc
PE
2896 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2897 Remove var that is set but not used.
0b918413
PE
2898 (scroll_bar_windows_size): Now size_t, not int.
2899 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2900 Check for overflow.
9ae848fc 2901
a5a62657
PE
2902 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2903 (map_tty_color) [!defined MSDOS]: Likewise.
2904
5c5cdd39
PE
2905 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2906
66ebf983
PE
2907 * coding.c: Remove vars that are set but not used.
2908 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2909 All callers changed.
2910 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2911 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2912 (decode_coding_charset): Remove vars that are set but not used.
2913
1be4d761
PE
2914 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2915 that is set but not used.
2916
47553fa8
PE
2917 * print.c (print_object): Remove var that is set but not used.
2918
1f7196bf 2919 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2920 The gnulib version avoids calling malloc in the usual case,
2921 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2922 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2923 * filelock.c (current_lock_owner): Likewise.
2924 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2925 * sysdep.c: Include allocator.h, careadlinkat.h.
2926 (emacs_no_realloc_allocator): New static constant.
2927 (emacs_readlink): New function.
fdb61804
PE
2928 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2929 ../lib/careadlinkat.h.
d1fdcab7 2930
f84c17c7
SM
29312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2932
2933 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2934 first non-nil return value).
2935
ef3862ad
JD
29362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2937
2938 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2939 if not defined (Bug#8403).
2940
376a7006
JB
29412011-04-02 Juanma Barranquero <lekktu@gmail.com>
2942
2943 * xdisp.c (display_count_lines): Remove parameter `start',
2944 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2945 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2946 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2947 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2948 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2949 and thereabouts. All callers changed.
2950 (get_per_char_metric): Remove parameter `f', unused since
2951 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2952
6ca3801d
JM
29532011-04-02 Jim Meyering <meyering@redhat.com>
2954
2955 do not dereference NULL upon failed strdup
2956 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2957 (ns_get_family): Likewise.
2958
d8e2b5ba
JB
29592011-04-02 Juanma Barranquero <lekktu@gmail.com>
2960
2961 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2962
8c74fcbd
JD
29632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2964
2965 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2966 later (Bug#8403).
2967
7200d79c
SM
29682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2969
03408648 2970 Add lexical binding.
7200d79c 2971
03408648
SM
2972 * window.c (Ftemp_output_buffer_show): New fun.
2973 (Fsave_window_excursion):
2974 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2975
2976 * lread.c (lisp_file_lexically_bound_p): New function.
2977 (Fload): Bind Qlexical_binding.
2978 (readevalloop): Remove `evalfun' arg.
2979 Bind Qinternal_interpreter_environment.
2980 (Feval_buffer): Bind Qlexical_binding.
2981 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2982 Mark as dynamic.
2983 (syms_of_lread): Declare `lexical-binding'.
2984
2985 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2986
2987 * keyboard.c (eval_dyn): New fun.
2988 (menu_item_eval_property): Use it.
ca105506
SM
2989
2990 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2991
03408648
SM
2992 * fns.c (concat, mapcar1): Accept byte-code-functions.
2993
2994 * eval.c (Fsetq): Handle lexical vars.
2995 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2996 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2997 (FletX, Flet): Obey lexical binding.
2998 (Fcommandp): Handle closures.
2999 (Feval): New `lexical' arg.
3000 (eval_sub): New function extracted from Feval. Use it almost
3001 everywhere where Feval was used. Look up vars in lexical env.
3002 Handle closures.
3003 (Ffunctionp): Move from subr.el.
3004 (Ffuncall): Handle closures.
3005 (apply_lambda): Remove `eval_flags'.
3006 (funcall_lambda): Handle closures and new byte-code-functions.
3007 (Fspecial_variable_p): New function.
3008 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3009 but without exporting it to Lisp.
23aba0ea 3010
23aba0ea 3011 * doc.c (Fdocumentation, store_function_docstring):
03408648 3012 * data.c (Finteractive_form): Handle closures.
23aba0ea 3013
03408648
SM
3014 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3015 interactive spec.
ba83908c 3016
04f2d78b
CB
3017 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3018 New byte-codes.
03408648
SM
3019 (exec_byte_code): New function extracted from Fbyte_code to handle new
3020 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3021
03408648 3022 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3023
03408648 3024 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3025
e2abce01
JB
30262011-03-31 Juanma Barranquero <lekktu@gmail.com>
3027
3028 * xdisp.c (redisplay_internal): Fix prototype.
3029
63696a73 30302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3031
63696a73 3032 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3033 (try_scrolling): Use it when setting scroll_limit.
3034 Limit scrolling to 100 screen lines.
63696a73
EZ
3035 (redisplay_window): Even when falling back on "recentering",
3036 position point in the window according to scroll-conservatively,
3037 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3038
3039 (try_scrolling): When point is above the window, allow searching
3040 as far as scroll_max, or one screenful, to compute vertical
3041 distance from PT to the scroll margin position. This prevents
3042 try_scrolling from unnecessarily failing when
3043 scroll-conservatively is set to a value slightly larger than the
3044 window height. Clean up the case of PT below the margin at bottom
3045 of window: scroll_max can no longer be INT_MAX. When aggressive
3046 scrolling is in use, don't let point enter the opposite scroll
3047 margin as result of the scroll.
3048 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3049 threshold of 100 lines for never-recentering scrolling.
3050
e4cc2dfc
JB
30512011-03-31 Juanma Barranquero <lekktu@gmail.com>
3052
3053 * dispextern.h (move_it_by_lines):
3054 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3055 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3056 (message_log_check_duplicate): Remove parameters `prev_bol' and
3057 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3058 (redisplay_internal): Remove parameter `preserve_echo_area',
3059 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3060
3061 * indent.c (Fvertical_motion):
3062 * window.c (window_scroll_pixel_based, Frecenter):
3063 Don't pass `need_y_p' to `move_it_by_lines'.
3064
1c470562
SM
30652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3066
44f230aa
SM
3067 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3068 steal a few bits to be more compact.
3069 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3070 Remove unneeded casts.
3071
1c470562
SM
3072 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3073
888adce9
ZK
30742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3075
3076 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3077 binding" message (bug#7967).
3078
f838ed7b
PE
30792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3080
77861b95
PE
3081 Fix more problems found by GCC 4.6.0's static checks.
3082
de6dbc14
PE
3083 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3084 Remove unused local var.
3085
f838ed7b
PE
3086 * editfns.c (Fmessage_box): Remove unused local var.
3087
792c7b2b
PE
3088 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3089 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3090 Omit unused local vars.
c499e557 3091 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3092 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3093 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3094 Omit unused local var.
3095
ba0165e1
PE
3096 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3097 Don't assume string length fits in int.
32ad8845 3098 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3099 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3100
3c59b4c9
PE
3101 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3102 instead of alloca (Bug#8344).
3103
a3eed478 3104 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3105 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3106
eb4d412d
PE
3107 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3108
1658b401
PE
3109 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3110 concerns.
3111
3112 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3113
3114 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3115
9a2c6e05
PE
3116 * keyboard.c (syms_of_keyboard): Use the same style as later
3117 in this function when indexing through an array. This also
3118 works around GCC bug 48267.
3119
03d0a109
PE
3120 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3121
44f730c8
PE
3122 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3123
fe75f926
PE
3124 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3125 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3126
ffa8c828
PE
3127 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3128 This avoids undefined behavior on integer overflow, and is a bit
3129 more convenient anyway since it is compared to a size_t variable.
3130
c5101a77
PE
3131 Variadic C functions now count arguments with size_t, not int.
3132 This avoids an unnecessary limitation on 64-bit machines, which
3133 caused (substring ...) to crash on large vectors (Bug#8344).
3134 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3135 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3136 All variadic functions and their callers changed accordingly.
c5101a77
PE
3137 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3138 * data.c (arith_driver, float_arith_driver): Likewise.
3139 * editfns.c (general_insert_function): Likewise.
3140 * eval.c (struct backtrace.nargs, interactive_p)
3141 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3142 (funcall_lambda, mark_backtrace): Likewise.
3143 * fns.c (concat): Likewise.
3144 * frame.c (x_set_frame_parameters): Likewise.
3145 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3146 0 if not found, not -1. All callers changed.
3147
dd3f25f7
PE
3148 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3149 (stack_copy_size): Now size_t, not int.
3150 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3151
461c2ab9
JB
31522011-03-28 Juanma Barranquero <lekktu@gmail.com>
3153
3154 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3155 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3156 All callers changed.
3157
3158 * lisp.h (multibyte_char_to_unibyte):
3159 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3160 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3161 * character.h (CHAR_TO_BYTE8):
3162 * cmds.c (internal_self_insert):
3163 * editfns.c (general_insert_function):
3164 * keymap.c (push_key_description):
3165 * search.c (Freplace_match):
3166 * xdisp.c (message_dolog, set_message_1): All callers changed.
3167
f6d62986
SM
31682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3169
3170 * keyboard.c (safe_run_hook_funcall): New function.
3171 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3172 don't set the hook to nil, but remove the offending function instead.
3173 (Qcommand_hook_internal): Remove, unused.
3174 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3175 Vcommand_hook_internal.
3176
3177 * eval.c (enum run_hooks_condition): Remove.
3178 (funcall_nil, funcall_not): New functions.
3179 (run_hook_with_args): Call each function through a `funcall' argument.
3180 Remove `cond' argument, now redundant.
3181 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3182 (Frun_hook_with_args_until_failure): Adjust accordingly.
3183 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3184
1db5b1ad
JB
31852011-03-28 Juanma Barranquero <lekktu@gmail.com>
3186
3187 * dispextern.h (string_buffer_position): Remove declaration.
3188
3189 * print.c (strout): Remove parameter `multibyte', unused since
3190 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3191
3192 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3193 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3194 All callers changed.
3195
3196 * w32.c (_wsa_errlist): Use braces for struct initializers.
3197
3198 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3199 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3200 All callers changed.
3201 (string_buffer_position): Likewise. Also, make static (it's never
3202 used outside xdisp.c).
3203 (cursor_row_p): Remove parameter `w', unused since
3204 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3205 (decode_mode_spec): Remove parameter `precision', introduced during
3206 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3207 All callers changed.
3208
5ffb62aa
JD
32092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3210
3211 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3212
461c2ab9 32132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3214
3215 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3216 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3217 (ns_update_auto_hide_menu_bar): New functions.
3218 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3219 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3220 ns_constrain_all_frames.
3221 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3222 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3223
5c380ffb
JD
32242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3225
3226 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3227
9af30bdf
GM
32282011-03-27 Glenn Morris <rgm@gnu.org>
3229
3230 * syssignal.h: Replace RETSIGTYPE with void.
3231 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3232 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3233 Replace SIGTYPE with void everywhere.
3234 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3235 * s/template.h (SIGTYPE): Remove commented out definition.
3236
e2abce01
JB
32372011-03-26 Eli Zaretskii <eliz@gnu.org>
3238
3239 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3240 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3241
f868cd8a
JB
32422011-03-26 Juanma Barranquero <lekktu@gmail.com>
3243
59eb0929
JB
3244 * w32.c (read_unc_volume): Use parameter `henum', instead of
3245 global variable `wget_enum_handle'.
3246
3247 * keymap.c (describe_vector): Remove parameters `indices' and
3248 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3249 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3250
f868cd8a
JB
3251 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3252
3253 * keyboard.c (timer_check): Remove parameter `do_it_now',
3254 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3255 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3256 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3257
3258 * keyboard.c (read_char):
3259 * w32menu.c (w32_menu_display_help):
3260 * xmenu.c (show_help_event, menu_help_callback):
3261 Adjust calls to `show_help_echo'.
3262
3263 * gtkutil.c (xg_maybe_add_timer):
3264 * keyboard.c (readable_events):
3265 * process.c (wait_reading_process_output):
3266 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3267
3268 * insdel.c (adjust_markers_gap_motion):
3269 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3270 (gap_left, gap_right): Don't call it.
3271
2ecf6fdb
CY
32722011-03-25 Chong Yidong <cyd@stupidchicken.com>
3273
3274 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3275 incurred during fontification.
3276
6b1f9ba4
JB
32772011-03-25 Juanma Barranquero <lekktu@gmail.com>
3278
3279 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3280 (DEFVAR_PER_BUFFER): Don't pass it.
3281
3282 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3283 (scrolling_window): Don't pass it.
3284
0f4a96b5
JB
32852011-03-25 Juanma Barranquero <lekktu@gmail.com>
3286
3287 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3288
3289 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3290 and `suffix'.
3291 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3292 of variables specific to SELinux and computation of `encoded_absname'.
3293
3294 * image.c (XPutPixel): Remove unused variable `height'.
3295
3296 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3297
3298 * unexw32.c (get_section_info): Remove unused variable `section'.
3299
3300 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3301 (system_process_attributes): Remove unused variable `sess'.
3302 (sys_read): Remove unused variable `err'.
3303
3304 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3305 (w32_wnd_proc): Remove unused variable `isdead'.
3306 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3307 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3308 (x_create_tip_frame): Remove unused variable `tem'.
3309
3310 * w32inevt.c (w32_console_read_socket):
3311 Remove unused variable `no_events'.
3312
3313 * w32term.c (x_draw_composite_glyph_string_foreground):
3314 Remove unused variable `width'.
3315
1149507c
JB
33162011-03-24 Juanma Barranquero <lekktu@gmail.com>
3317
3318 * w32term.c (x_set_glyph_string_clipping):
3319 Don't pass uninitialized region to CombineRgn.
3320
9c88f339
JB
33212011-03-23 Juanma Barranquero <lekktu@gmail.com>
3322
3323 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3324 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3325 (Fx_close_connection): Remove unused variable `i'.
3326
3327 * w32font.c (w32font_draw): Return number of glyphs.
3328 (w32font_open_internal): Remove unused variable `i'.
3329 (w32font_driver): Add missing initializer.
3330
3331 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3332 (fill_in_menu): Remove unused variable `items_added'.
3333
3334 * w32term.c (last_mouse_press_frame): Remove static global variable.
3335 (w32_clip_to_row): Remove unused variable `f'.
3336 (x_delete_terminal): Remove unused variable `i'.
3337
3338 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3339 (NOTHING): Remove unused static global variable.
3340 (uniscribe_check_otf): Remove unused variable `table'.
3341 (uniscribe_font_driver): Add missing initializers.
3342
dee091a3
JD
33432011-03-23 Julien Danjou <julien@danjou.info>
3344
3345 * term.c (Fsuspend_tty, Fresume_tty):
3346 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3347 * window.c (temp_output_buffer_show):
3348 * insdel.c (signal_before_change):
3349 * frame.c (Fhandle_switch_frame):
3350 * fileio.c (Fdo_auto_save):
3351 * emacs.c (Fkill_emacs):
3352 * editfns.c (save_excursion_restore):
3353 * cmds.c (internal_self_insert):
3354 * callint.c (Fcall_interactively):
3355 * buffer.c (Fkill_all_local_variables):
3356 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3357 Use Frun_hooks.
0f4a96b5 3358 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3359 unconditionnaly since it does the check itself.
3360
2c520ab5 33612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3362
c9c49752
PE
3363 Fix more problems found by GCC 4.5.2's static checks.
3364
8abc3f12
PE
3365 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3366 the first time through the loop, since we know p0 < p1 then.
3367 This also avoids a gcc -Wstrict-overflow warning.
3368
a2d26660
PE
3369 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3370 leading to a memory leak, possible in functions like
3371 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3372 of objects (Bug#8318).
a2d26660 3373
916c72e9
PE
3374 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3375 that could (at least in theory) be that large.
3376
19ab8a18
PE
3377 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3378 This is less likely to overflow, and avoids undefined behavior if
3379 overflow does occur. All callers changed. Use strtoul to scan
3380 for the unsigned long integer.
b7cbbd6f
PE
3381 (pint2hrstr): Simplify and tune code slightly.
3382 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3383
f0641eff
PE
3384 * scroll.c (do_scrolling): Work around GCC bug 48228.
3385 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3386
7f650bb9
PE
3387 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3388 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3389 (validate_x_resource_name): Simplify count usage.
3390 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3391
37dd57d1
PE
3392 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3393 fail (Bug#8306).
81e56e61 3394
699979fc 3395 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3396
401bf9b4
PE
3397 * process.c (Fmake_network_process): Use socklen_t, not int,
3398 where POSIX says socklen_t is required in portable programs.
3399 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3400 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3401 (Fmake_network_process, server_accept_connection):
3402 (wait_reading_process_output, read_process_output):
3403 Likewise.
3404
b93aacde
PE
3405 * process.c: Rename or move locals to avoid shadowing.
3406 (list_processes_1, Fmake_network_process):
3407 (read_process_output_error_handler, exec_sentinel_error_handler):
3408 Rename or move locals.
4dc343ee 3409 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3410 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3411 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3412 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3413 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3414
af8a867c 3415 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3416 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3417 Include tparam.h instead, since it declares them.
af8a867c
PE
3418 * cm.h (PC): Remove extern decl; tparam.h now does this.
3419 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3420 * terminfo.c: Include tparam.h, to check interfaces.
3421 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3422 (tparam): Adjust signature to match interface in tparam.h;
3423 this removes some undefined behavior. Check that outstring and len
3424 are zero, which they always are with Emacs.
3425 * tparam.h (PC, BC, UP): New extern decls.
3426
0248044d 3427 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3428 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3429
8ff096c1 3430 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3431 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3432 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3433 (ftfont_list): Remove unused local.
49eaafba
PE
3434 (get_adstyle_property, ftfont_pattern_entity):
3435 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3436 Rename locals to avoid shadowing.
8ff096c1 3437
e2be39f6
PE
3438 * xfont.c (xfont_list_family): Mark var as initialized.
3439
c9735e30
PE
3440 * xml.c (make_dom): Now static.
3441
8f5201ae
PE
3442 * composite.c (composition_compute_stop_pos): Rename local to
3443 avoid shadowing.
b246f932
PE
3444 (composition_reseat_it): Remove unused locals.
3445 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3446 (composition_update_it): Mark var as initialized.
11b61122
PE
3447 (find_automatic_composition): Mark vars as initialized,
3448 with a FIXME (Bug#8290).
8f5201ae 3449
760fbc2c
PE
3450 character.h: Rename locals to avoid shadowing.
3451 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3452 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3453 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3454 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3455 to avoid shadowing.
3456
ff08eb85
PE
3457 * textprop.c (property_change_between_p): Remove; unused.
3458
fc7bf025
PE
3459 * intervals.c (interval_start_pos): Now static.
3460
235d7abc
PE
3461 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3462
44f230aa
SM
3463 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3464 Rename locals to avoid shadowing.
3e7d6594 3465
50060332
PE
3466 * sound.c (wav_play, au_play, Fplay_sound_internal):
3467 Fix pointer signedness.
d01f234b 3468 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3469 (wav_play): Initialize a variable to 0, to prevent undefined
3470 behavior (Bug#8278).
50060332 3471
c4fc4e30
PE
3472 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3473
918436ed
PE
3474 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3475
c939f91b
PE
3476 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3477 clobbering (Bug#8298).
b9c7f648
PE
3478 * sysdep.c (sys_subshell): Likewise.
3479 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3480
6bd8c144
PE
3481 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3482 This should get cleaned up, so that child_setup has the
3483 same signature on all platforms.
3484
7710357c 3485 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3486 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3487
c59da222
CY
34882011-03-22 Chong Yidong <cyd@stupidchicken.com>
3489
3490 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3491 not to be necessary, and produces flickering.
3492
66b87493
GM
34932011-03-20 Glenn Morris <rgm@gnu.org>
3494
3495 * config.in: Remove file.
3496
45b6f6d5
JB
34972011-03-20 Juanma Barranquero <lekktu@gmail.com>
3498
3499 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3500 are now in src/globals.h.
3501 (syms_of_minibuf): Remove spurious & from previous change.
3502
3ec03f7e
LL
35032011-03-20 Leo <sdl.web@gmail.com>
3504
3505 * minibuf.c (completing-read-function): New variable.
3506 (completing-read-default): Rename from completing-read.
3507 (completing-read): Call completing-read-function.
3508
b14e3e21
CY
35092011-03-19 Juanma Barranquero <lekktu@gmail.com>
3510
3511 * xfaces.c (Fx_load_color_file):
3512 Read color file from absolute filename (bug#8250).
3513
f2b726e6
JB
35142011-03-19 Juanma Barranquero <lekktu@gmail.com>
3515
3516 * makefile.w32-in: Update dependencies.
3517
09f6ff02
EZ
35182011-03-17 Eli Zaretskii <eliz@gnu.org>
3519
3520 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3521
29a6015a
PE
35222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3523
a3a6c54e
PE
3524 Fix more problems found by GCC 4.5.2's static checks.
3525
b766f867
PE
3526 * process.c (make_serial_process_unwind, send_process_trap):
3527 (sigchld_handler): Now static.
3528
be02381c
PE
3529 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3530 That way, the code declares only the vars that it needs.
3531 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3532 * s/cygwin.h (PTY_ITERATION): Likewise.
3533 * s/darwin.h (PTY_ITERATION): Likewise.
3534 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3535
57048744
PE
3536 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3537 * process.c (allocate_pty): Don't declare stb unless it's needed.
3538
7914961c 3539 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3540 (CONSTANTLIM): Remove; unused.
3541 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3542 Define only if needed.
7914961c 3543
b3967b18
PE
3544 * unexelf.c (unexec): Name an expression,
3545 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3546 Use a different way to cause a compilation error if anyone uses
3547 n rather than nn, a way that does not involve shadowing.
73366a00 3548 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3549
29a6015a
PE
3550 * deps.mk (unexalpha.o): Remove; unused.
3551
43cfc33e 3552 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3553 * unexec.h: New file.
ce701a33
PE
3554 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3555 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3556 Depend on unexec.h.
3557 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3558 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3559 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3560 Change as necessary to match prototype in unexec.h.
ce701a33 3561
01f44d5a
PE
3562 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3563 shadowing.
4f63c6bb 3564 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3565
a6670b0b
PE
3566 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3567 Rename locals to avoid shadowing.
3568
cef2010d 3569 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3570 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3571
d4d7173a
PE
3572 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3573
f08b802a
PE
3574 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3575 warning when compiling print.c.
3576
3ddb0639
PE
3577 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3578 instead of using an uninitialized var.
5ad03b97 3579 (font_sort_entities): Mark var as initialized.
3ddb0639 3580
170a2692
PE
3581 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3582
e663c700
PE
3583 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3584 pointers to constants.
89bc529a 3585 (font_parse_fcname): Remove unused vars.
7b81e2d0 3586 (font_delete_unmatched): Now static.
ea838e10 3587 (font_get_spec): Remove; unused.
13a547c6
PE
3588 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3589 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3590 Rename or move locals to avoid shadowing.
e663c700 3591
2a80c887 3592 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3593 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3594
1384fa33 3595 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3596 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3597
8b2c52e9
PE
3598 * alloc.c (mark_backtrace): Move decl from here ...
3599 * lisp.h: ... to here, so that it can be checked.
3600
475545b5 3601 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3602 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3603 (lisp_indirect_variable): Name an expression,
3604 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3605 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3606
b1349114 3607 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3608 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3609 Use const pointer when appropriate.
b1349114 3610
a2928364
PE
3611 * lisp.h (get_system_name, get_operating_system_release):
3612 Move decls here, to check interfaces.
3613 * process.c (get_operating_system_release): Move decl to lisp.h.
3614 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3615 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3616 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3617 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3618 (Fformat_time_string, Fencode_time, Finsert_char):
3619 (Ftranslate_region_internal, Fformat):
3620 Rename or remove local vars to avoid shadowing.
9710023e 3621 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3622
a415e694
PE
3623 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3624 avoid shadowing.
3625
8ef4622d
PE
3626 * lisp.h (eassert): Check that the argument compiles, even if
3627 ENABLE_CHECKING is not defined.
3628
946f9a5b
PE
3629 * data.c (Findirect_variable): Name an expression, to avoid
3630 gcc -Wbad-function-cast warning.
112396d6 3631 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3632 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3633 (Fmake_variable_buffer_local, Fmake_local_variable):
3634 Mark variables as initialized.
52746918 3635 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3636
e5aab7e7 3637 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3638 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3639 Rename locals to avoid shadowing.
dff45157
PE
3640 (mark_stack): Move local variables into the #ifdef region where
3641 they're used.
7bc26fdb
PE
3642 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3643 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3644 needed otherwise.
3645 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3646 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3647 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3648
e5aab7e7
PE
3649 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3650 avoids undefined behavior in theory.
3651
4da60324
PE
3652 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3653
88043301
PE
3654 Use functions, not macros, for up- and down-casing (Bug#8254).
3655 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3656 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3657 to use the following functions instead of these macros.
3658 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3659 EMACS_INT, since callers assume the returned value fits in int.
3660 (upcase1): Likewise, for UPCASE_TABLE.
3661 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3662 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3663 the race-condition problem in the old DOWNCASE.
88043301 3664
19ed5445
PE
3665 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3666 Rename locals to avoid shadowing.
3667 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3668 (regex_compile, re_search_2, re_match_2_internal):
3669 Remove unused local vars.
952db0d7
PE
3670 (FREE_VAR): Rewrite so as not to use empty "else",
3671 which gcc can warn about.
da053e48 3672 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3673 (RETALLOC_IF): Define only if needed.
3674 (WORDCHAR_P): Likewise. This one is never needed, but is used
3675 only in a comment talking about a compiler bug, so put inside
3676 the #if 0 of that comment.
3677 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3678 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3679 Remove; unused.
19ed5445 3680
1f3561e4 3681 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3682 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3683 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3684
ded6f8f7
PE
3685 * search.c (simple_search): Remove unused var.
3686
dbd37a95
PE
3687 * dired.c (compile_pattern): Move decl from here ...
3688 * lisp.h: ... to here, so that it can be checked.
3689 (struct re_registers): New forward decl.
3690
7e47afad
PE
3691 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3692
85f24f61
PE
3693 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3694 All uses changed.
3695 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3696 Rename locals to avoid shadowing.
5671df8f 3697 (Fvertical_motion): Mark locals as initialized.
85f24f61 3698
181aa2be 3699 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3700 (casify_region): Mark local as initialized.
181aa2be 3701
930d429c
PE
3702 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3703
7082eac6
PE
3704 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3705 New macros, so that the caller can use some names other than
3706 gcpro1, gcpro2, etc.
3707 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3708 of the new macros.
3709 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3710 argument, for consistency with GCPRO2_VAR, etc: it is now the
3711 prefix of the variable, not the variable itself. All uses
3712 changed.
38b2c076
PE
3713 * dired.c (directory_files_internal, file_name_completion):
3714 Rename locals to avoid shadowing.
3715
15206ed9
PE
3716 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3717 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3718 dired.c's scmp function, had undefined behavior.
3719 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3720 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3721 * buffer.h: ... to here, because these macros use current_buffer,
3722 and the new implementation with inline functions needs to have
3723 current_buffer in scope now, rather than later when the macros
3724 are used.
3725 (downcase, upcase1): New static inline functions.
3726 (DOWNCASE, UPCASE1): Reimplement using these functions.
3727 This avoids undefined behavior in expressions like
3728 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3729 from race conditions in accessing the global variables
3730 case_temp1 and case_temp2.
3731 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3732 * lisp.h (case_temp1, case_temp2): Remove their decls.
3733 * character.h (ASCII_CHAR_P): Move from here ...
3734 * lisp.h: ... to here, so that the inline functions mentioned
3735 above can use them.
3736
4a6bea26
PE
3737 * dired.c (directory_files_internal_unwind): Now static.
3738
f14b7e14
PE
3739 * fileio.c (file_name_as_directory, directory_file_name):
3740 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3741 Now static.
2893f146
PE
3742 (file_name_as_directory): Use const pointers when appropriate.
3743 (Fexpand_file_name): Likewise. In particular, newdir might
3744 point at constant storage, so make it a const pointer.
fd4ead52 3745 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3746 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3747 signedness issues.
f839df0c
PE
3748 (Fset_file_times, Finsert_file_contents, auto_save_error):
3749 Rename locals to avoid shadowing.
f14b7e14 3750
5716756e 3751 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3752 (Ftry_completion, Fall_completions): Rename or remove locals
3753 to avoid shadowing.
5716756e 3754
b4c3046a
PE
3755 * marker.c (bytepos_to_charpos): Remove; unused.
3756
b45db522
PE
3757 * lisp.h (verify_bytepos, count_markers): New decls,
3758 so that gcc does not warn that these functions aren't declared.
3759
85876d07
PE
3760 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3761 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3762 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3763 (copy_text): Remove unused local var.
85876d07 3764
03d78a21 3765 * filelock.c (within_one_second): Now static.
b3dd38ab 3766 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3767
5df8f01b
PE
3768 * buffer.c (fix_overlays_before): Mark locals as initialized.
3769 (fix_start_end_in_overlays): Likewise. This function should be
3770 simplified by using pointers-to-pointers, but that's a different
3771 matter.
b1d876f1 3772 (switch_to_buffer_1): Now static.
8f54f30a
PE
3773 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3774 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3775
a70072c9 3776 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3777 Fix pointer signedness issue.
edced198
PE
3778 (sys_subshell): Mark local as volatile if checking for lint,
3779 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3780 (MAXPATHLEN): Define only if needed.
a70072c9 3781
a0977c44
PE
3782 * process.c (serial_open, serial_configure): Move decls from here ...
3783 * systty.h: ... to here, so that they can be checked.
3784
a884fdcc
PE
3785 * fns.c (get_random, seed_random): Move extern decls from here ...
3786 * lisp.h: ... to here, so that they can be checked.
3787
604efe86 3788 * sysdep.c (reset_io): Now static.
b8950c94 3789 (wait_for_termination_signal): Remove; unused.
604efe86 3790
38fc62d9
PE
3791 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3792 (copy_keymap_item, append_key, push_text_char_description):
3793 Now static.
1004a21a 3794 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3795 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3796 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3797 (describe_map_tree):
3798 Rename locals to avoid shadowing.
38fc62d9 3799
2f2650da
PE
3800 * keyboard.c: Declare functions static if they are not used elsewhere.
3801 (echo_char, echo_dash, cmd_error, top_level_2):
3802 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3803 (read_char, kbd_buffer_get_event, make_lispy_position):
3804 (make_lispy_event, make_lispy_movement, apply_modifiers):
3805 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3806 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3807 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3808 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3809 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3810
a053e86c 3811 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3812 (mark_kboards): Move decl here ...
3813 * alloc.c (mark_kboards): ... from here.
a053e86c 3814
4752793e
PE
3815 * lisp.h (force_auto_save_soon): New decl.
3816
74f10ca7 3817 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3818 (DEFINE_DUMMY_FUNCTION): New macro.
3819 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3820 Use it.
c03cd23f
PE
3821 (main): Add casts to avoid warnings
3822 if GCC considers string literals to be constants.
74f10ca7 3823
022e70d4
PE
3824 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3825
59d6fe83
PE
3826 * dbusbind.c: Pointer signedness fixes.
3827 (xd_signature, xd_append_arg, xd_initialize):
3828 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3829 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3830 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3831 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3832
78320123
PE
3833 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3834 if GCC considers string literals to be constants.
49cebcca 3835 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3836
35ac2a97
SM
38372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3838
fb103ca9
SM
3839 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3840 (print_preprocess, print_object): New macro to fix last change.
3841
35ac2a97
SM
3842 * print.c (print_preprocess): Don't forget font objects.
3843
62973b41
JB
38442011-03-16 Juanma Barranquero <lekktu@gmail.com>
3845
3846 * emacs.c (USAGE3): Doc fixes.
3847
0e48bb22
AS
38482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3849
3850 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3851 structure.
3852
7684e57b
JB
38532011-03-14 Juanma Barranquero <lekktu@gmail.com>
3854
3855 * lisp.h (VWindow_system, Qfile_name_history):
3856 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3857 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3858 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3859
3860 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3861 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3862
3863 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3864 * w32console.c (detect_input_pending, read_input_pending)
3865 (encode_terminal_code):
3866 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3867 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3868 (w32_system_caret_y, Qfile_name_history):
3869 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3870 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3871 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3872 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3873 * w32proc.c (Qlocal, report_file_error):
3874 * w32term.c (Vwindow_system, updating_frame):
3875 * w32uniscribe.c (initialized, uniscribe_font_driver):
3876 Remove unneeded extern declarations.
3877
2aa46d6c
CY
38782011-03-14 Chong Yidong <cyd@stupidchicken.com>
3879
c96bbc66 3880 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3881
cffc6f3b
CY
38822011-03-13 Chong Yidong <cyd@stupidchicken.com>
3883
3884 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3885 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3886 These macros can no longer be used for assignment.
3887
44f230aa
SM
3888 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3889 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3890 (record_buffer_markers, fetch_buffer_markers): New functions for
3891 recording and fetching special buffer markers.
3892 (set_buffer_internal_1, set_buffer_temp): Use them.
3893
3894 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3895
3896 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3897
3898 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3899 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3900
3901 * xdisp.c (hscroll_window_tree):
3902 (reconsider_clip_changes): Use PT instead of BUF_PT.
3903
d251f04b
EZ
39042011-03-13 Eli Zaretskii <eliz@gnu.org>
3905
3906 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3907 $(EMACS_ROOT)/lib/intprops.h.
3908
f0c77cd1
PE
39092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3910
3eca4629
PE
3911 Fix more problems found by GCC 4.5.2's static checks.
3912
7c86ee98
PE
3913 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3914 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3915 (xg_free_frame_widgets): Make it clear that a local variable is
3916 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3917 (gdk_window_get_screen): Make it clear that this macro is needed
3918 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3919 (int_gtk_range_get_value): New function, which avoids a diagnostic
3920 from gcc -Wbad-function-cast.
3921 (xg_set_toolkit_scroll_bar_thumb): Use it.
3922 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3923 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3924 (get_utf8_string, xg_get_file_with_chooser):
3925 Rename locals to avoid shadowing.
3926 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3927
41729b81
PE
3928 * xgselect.c (xg_select): Remove unused var.
3929
f0c77cd1
PE
3930 * image.c (four_corners_best): Mark locals as initialized.
3931 (gif_load): Initialize transparent_p to zero (Bug#8238).
3932 Mark another local as initialized.
ec6cf4c6 3933 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3934
ce0ad53d 3935 * image.c (clear_image_cache): Now static.
d5d5a617 3936 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3937 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3938 (x_edge_detection): Remove unnecessary cast that
3939 gcc -Wbad-function-cast diagnoses.
2037898d 3940 (gif_load): Fix pointer signedness.
6ae141d6
PE
3941 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3942 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3943
33383987 39442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3945
d32df629
PE
3946 Improve quality of tests for time stamp overflow.
3947 For example, without this patch (encode-time 0 0 0 1 1
3948 1152921504606846976) returns the obviously-bogus value (-948597
3949 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3950 reports time overflow. See
3951 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3952 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3953 * editfns.c: Include limits.h and intprops.h.
3954 (TIME_T_MIN, TIME_T_MAX): New macros.
3955 (time_overflow): Move earlier, to before first use.
3956 (hi_time, lo_time): New functions, for an accurate test for
3957 out-of-range times.
3958 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3959 (Fget_internal_run_time): Don't assume time_t fits in int.
3960 (make_time): Use list2 instead of Fcons twice.
3961 (Fdecode_time): More accurate test for out-of-range times.
3962 (check_tm_member): New function.
3963 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3964 (lisp_time_argument): Don't rely on undefined left-shift and
3965 right-shift behavior when checking for time stamp overflow.
8be6f318 3966
fe31d94c
PE
3967 * editfns.c (time_overflow): New function, refactoring common code.
3968 (Fformat_time_string, Fdecode_time, Fencode_time):
3969 (Fcurrent_time_string): Use it.
3970
8be6f318
PE
3971 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3972 * dired.c (make_time): Move to ...
3973 * editfns.c (make_time): ... here.
3974 * systime.h: Note the move.
3975
09d9db2c 39762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3977
126bc0dc
YM
3978 * fringe.c (update_window_fringes): Remove unused variables.
3979
c47cbdfd
YM
3980 * unexmacosx.c (copy_data_segment): Also copy __got section.
3981 (Bug#8223)
3982
7ac80be9
EZ
39832011-03-12 Eli Zaretskii <eliz@gnu.org>
3984
c96bbc66 3985 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3986 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3987 Constify `char *' arguments and their references according to
3988 prototypes in tparam.h.
3989
ecb0f94d 3990 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3991
7ac80be9
EZ
3992 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3993 Adapt all references accordingly.
3994
3995 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3996
ef1fd07e
TT
39972011-03-11 Tom Tromey <tromey@redhat.com>
3998
3999 * buffer.c (syms_of_buffer): Remove obsolete comment.
4000
7ef4b50c
EZ
40012011-03-11 Eli Zaretskii <eliz@gnu.org>
4002
4003 * termhooks.h (encode_terminal_code): Declare prototype.
4004
4005 * msdos.c (encode_terminal_code): Don't declare prototype.
4006
4007 * term.c (encode_terminal_code): Now external again, used by
4008 w32console.c and msdos.c.
4009
44f230aa
SM
4010 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4011 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4012
4b1ec863 40132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4014
1714f52b 4015 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4016
4b1ec863
PE
4017 * fringe.c (update_window_fringes): Mark locals as initialized
4018 (Bug#8227).
4019 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4020
524c7aa6
PE
4021 * alloc.c (mark_fringe_data): Move decl from here ...
4022 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4023 to check its interface.
4024 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4025
a5c0af81 4026 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4027 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4028 (fontset_font): Mark local as initialized.
a9a06e0b 4029 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4030
b4716021
PE
4031 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4032
811e9bac 4033 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4034 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4035 (x_own_selection, Fx_disown_selection_internal): Rename locals
4036 to avoid shadowing.
4037 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4038
7e3ab302
PE
4039 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4040 so that the caller can use some name other than gcpro1.
4041 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4042 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4043 (Fx_backspace_delete_keys_p):
4044 Use them to avoid shadowing, and rename vars to avoid shadowing.
4045 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4046 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4047 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4048 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4049 Remove unused locals.
7e3ab302
PE
4050 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4051 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4052 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4053 macros.
f78faa98 4054
e2b13473
PE
4055 * xterm.h (x_mouse_leave): New decl.
4056
77f23912
PE
4057 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4058 Remove unused functions.
cdf4ba58
PE
4059 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4060 (x_calc_absolute_position): Now static.
7411c686 4061 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4062 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4063 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4064 unless they are used.
38d0b34a
PE
4065 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4066 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4067 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4068 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4069 (x_error_catcher, x_connection_closed, x_error_handler):
4070 (x_error_quitter, xembed_send_message, x_iconify_frame):
4071 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4072 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4073 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4074
44f230aa
SM
4075 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4076 Rename or move locals to avoid shadowing.
6b463e58 4077 (tty_defined_color, merge_face_heights): Now static.
5967d051 4078 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4079 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4080 does not deduce is never used uninitialized.
73719eba
PE
4081 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4082 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4083
426994c3 4084 * terminal.c (store_terminal_param): Now static.
5489860b 4085
032f1620 4086 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4087 (set_frame_menubar): Remove unused local.
d4323972 4088 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4089 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4090 since they might point to immutable storage.
281585b0
PE
4091 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4092 since it's unused otherwise.
032f1620 4093
367c19e5 4094 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4095 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4096 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4097 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4098 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4099 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4100 does not deduce are never used uninitialized.
70739cbe 4101
07b48fa9
PE
4102 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4103
8868a238 4104 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4105 * window.c (window_loop, size_window):
4106 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4107
7e5cf297 4108 * window.c (display_buffer): Now static.
d6550a9f
PE
4109 (size_window): Mark variables that gcc -Wuninitialized
4110 does not deduce are never used uninitialized.
a586633d
PE
4111 * window.h (check_all_windows): New decl, to forestall
4112 gcc -Wmissing-prototypes diagnostic.
5b555da1 4113 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4114
f6095868
PE
4115 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4116 shadowing.
4117 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4118 Include <limits.h>.
4119 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4120 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4121 (load_charset_map): Mark variables that gcc -Wuninitialized
4122 does not deduce are never used uninitialized.
53df7c11 4123 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4124
f38b440c
PE
4125 * coding.c (coding_set_source, coding_set_destination):
4126 Use "else { /* comment */ }" rather than "else /* comment */;"
4127 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4128 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4129 a block, when the outer 'i' will do.
4130 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4131 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4132 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4133 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4134 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4135 Rename locals to avoid shadowing.
4136 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4137 * coding.c (emacs_mule_char, encode_invocation_designation):
4138 Now static, since they're not used elsewhere.
413bb2db 4139 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4140 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4141 (decode_coding_emacs_mule): Mark variables that gcc
4142 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4143 (detect_coding_iso_2022): Initialize a local variable that might
4144 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4145 this initialization is needed. (Bug#8211)
5f58e762
PE
4146 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4147 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4148 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4149 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4150 Remove unused macros.
f38b440c 4151
232b38b9 4152 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4153 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4154 * character.c (string_count_byte8): Likewise.
232b38b9 4155
fb90da1b
PE
4156 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4157 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4158
fb93dbc2
PE
4159 * chartab.c (copy_sub_char_table): Now static, since it's not used
4160 elsewhere.
5c156ace
PE
4161 (sub_char_table_ref_and_range, char_table_ref_and_range):
4162 Rename locals to avoid shadowing.
bbcd0949 4163 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4164
7d3b3862 4165 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4166 (BIDI_BOB): Remove unused macro.
7d3b3862 4167
6be7d3da
PE
4168 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4169 deduce are never used uninitialized.
c2ed9c8b 4170 * term.c (encode_terminal_code): Likewise.
6be7d3da 4171
75f8807f 4172 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4173
50938595
PE
4174 * tparam.h: New file.
4175 * term.c, tparam.h: Include it.
4176 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4177 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4178 Move these decls to tparam.h, and make them agree with what
4179 is actually in tparam.c. The previous trick of using incompatible
4180 decls in different modules does not conform to the C standard.
4181 All callers of tparam changed to use tparam's actual API.
4182 * tparam.c (tparam1, tparam, tgoto):
4183 Use const pointers where appropriate.
4184
fbceeba2
PE
4185 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4186 * cm.h (struct cm): Likewise.
4187 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4188 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4189 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4190 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4191 (turn_on_face, init_tty): Likewise.
4192 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4193
7f3f1250
PE
4194 * term.c (term_mouse_position): Rename local to avoid shadowing.
4195
e6ca6543
PE
4196 * alloc.c (mark_ttys): Move decl from here ...
4197 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4198
c40f8d15
AS
41992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4200
4201 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4202
cfe0661d
JB
42032011-03-09 Juanma Barranquero <lekktu@gmail.com>
4204
4205 * search.c (compile_pattern_1): Remove argument regp, unused since
4206 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4207 (compile_pattern): Don't pass it.
4208
0afb4571
J
42092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4210
4211 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4212 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4213 for ! HAVE_GTK3.
4214 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4215
4216 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4217
4218 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4219 gdk_window_get_screen, gdk_window_get_geometry,
4220 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4221 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4222 (xg_get_pixbuf_from_pixmap): New function.
4223 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4224 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4225 Call xg_get_pixbuf_from_pixmap instead of
4226 gdk_pixbuf_get_from_drawable.
4227 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4228 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4229 (xg_check_special_colors): Use GtkStyleContext and its functions
4230 for HAVE_GTK3.
4231 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4232 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4233 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4234 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4235 Call gtk_widget_get_preferred_size.
0afb4571
J
4236 (xg_frame_resized): gdk_window_get_geometry only takes 5
4237 parameters.
44f230aa
SM
4238 (xg_win_to_widget, xg_event_is_for_menubar):
4239 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4240 (xg_set_widget_bg): New function.
4241 (delete_cb): New function.
895009e1 4242 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4243 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4244 (xg_set_background_color): Call xg_set_widget_bg.
4245 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4246 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4247 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4248 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4249 if ! HAVE_GTK3.
4250 (update_frame_tool_bar): Call gtk_widget_hide.
4251 (xg_initialize): Use GDK_KEY_g.
4252
4253 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4254 if ! HAVE_GTK3
4255 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4256
4257 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4258 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4259 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4260
1c2cc4ef
JB
42612011-03-08 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * w32xfns.c (select_palette): Check success of RealizePalette against
4264 GDI_ERROR, not zero.
4265
33383987 4266See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4267
4268;; Local Variables:
4269;; coding: utf-8
aac0c6e3
MR
4270;; End:
4271
33383987 4272 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4273
4274 This file is part of GNU Emacs.
4275
4276 GNU Emacs is free software: you can redistribute it and/or modify
4277 it under the terms of the GNU General Public License as published by
4278 the Free Software Foundation, either version 3 of the License, or
4279 (at your option) any later version.
4280
4281 GNU Emacs is distributed in the hope that it will be useful,
4282 but WITHOUT ANY WARRANTY; without even the implied warranty of
4283 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4284 GNU General Public License for more details.
4285
4286 You should have received a copy of the GNU General Public License
4287 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.