Add C interface for Unicode character property table.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c805dec0
KH
12011-07-06 Kenichi Handa <handa@m17n.org>
2
3 * character.h (unicode_category_t): New enum type.
4
5 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6 (Qchar_code_property_table): New variable.
7 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8 (UNIPROP_COMPRESSED_FORM_P): New macros.
9 (char_table_ascii): Uncompress the compressed values.
10 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11 Uncompress the compressed values.
12 (sub_char_table_ref_and_range): Likewise.
13 (char_table_ref_and_range): Uncompress the compressed values.
14 (sub_char_table_set): New arg is_uniprop. Callers changed.
15 Uncompress the compressed values.
16 (sub_char_table_set_range): Args changed. Callers changed.
17 (char_table_set_range): Adjuted for the above change.
18 (map_sub_char_table): Delete args default_val and parent. Add arg
19 top. Give decoded values to a Lisp function.
20 (map_char_table): Adjusted for the above change. Give decoded
21 values to a Lisp function. Gcpro more variables.
22 (uniprop_table_uncompress)
23 (uniprop_decode_value_run_length): New functions.
24 (uniprop_decoder, uniprop_decoder_count): New variables.
25 (uniprop_get_decoder, uniprop_encode_value_character)
26 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
27 New functions.
28 (uniprop_encoder, uniprop_encoder_count): New variables.
29 (uniprop_get_encoder, uniprop_table)
30 (Funicode_property_table_internal, Fget_unicode_property_internal)
31 (Fput_unicode_property_internal): New functions.
32 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
33 Sunicode_property_table_internal, Sget_unicode_property_internal,
34 and Sput_unicode_property_internal. Defvar_lisp
35 char-code-property-alist.
36
37 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
38 Vunicode_category_table.
39
40 * font.c (font_range): Adjusted for the change of
41 Vunicode_category_table.
42
85fece3e
PE
432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
44
20b84ce9 45 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
46 The following patches are for when GLYPH_DEBUG && !XASSERT.
47 * dispextern.h (trace_redisplay_p, dump_glyph_string):
48 * dispnew.c (flush_stdout):
49 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
50 Mark as externally visible.
51 * dispnew.c (check_window_matrix_pointers): Now static.
52 * dispnew.c (window_to_frame_vpos):
53 * xfns.c (unwind_create_frame):
54 * xterm.c (x_check_font): Remove unused local.
55 * scroll.c (CHECK_BOUNDS):
56 * xfaces.c (cache_fache): Rename local to avoid shadowing.
57 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
58 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
59 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
60 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
61 Now static.
62 (debug_method_add): Use va_list and vsprintf rather than relying
63 on undefined behavior with wrong number of arguments.
64 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
65 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
66 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
67 since we're not interested in debugging glyphs with old libraries.
68 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
69 GCC 4.6.0's static checking.
70
0766b489
PE
712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
72
31fd4b32
PE
73 Integer overflow and signedness fixes (Bug#8873).
74 A few related buffer overrun fixes, too.
75
b79e8648
PE
76 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
77
0766b489
PE
78 * dispextern.h (struct face.stipple):
79 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
80 (x_bitmap_mask, x_allocate_bitmap_record)
81 (x_create_bitmap_from_data, x_create_bitmap_from_file)
82 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
83 (x_create_bitmap_from_xpm_data):
84 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
85 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
86 (.bitmaps_last):
87 * xfaces.c (load_pixmap):
88 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
89 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
90 (.bitmaps_last, struct x_output.icon_bitmap):
91 Use ptrdiff_t, not int, for bitmap indexes.
92 (x_allocate_bitmap_record): Check for size overflow.
93 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
94
b081724f
PE
95 Use ptrdiff_t, not int, for overlay counts.
96 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
97 * editfns.c (overlays_around, get_pos_property):
98 * textprop.c (get_char_property_and_overlay):
99 * xdisp.c (next_overlay_change, note_mouse_highlight):
100 * xfaces.c (face_at_buffer_position):
21514da7
PE
101 * buffer.c (OVERLAY_COUNT_MAX): New macro.
102 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
103 (Fnext_overlay_change, Fprevious_overlay_change)
104 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 105 Use ptrdiff_t, not int, for sizes.
21514da7 106 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 107
3de73e5e
PE
108 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
109
2606c57b
PE
110 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
111 (x_session_initialize): Do not assume string length fits in int.
112
aaafe47a
PE
113 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
114 This is unlikely, but can occur if DPI is outlandish.
115
2674ddc8 116 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
117 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
118
28154962
PE
119 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
120 * xrdb.c (magic_file_p, search_magic_path):
121 Omit last arg SUFFIX; it was always 0. All callers changed.
122 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
123
7de51af5
PE
124 * xfont.c (xfont_match): Avoid need for strlen.
125
25ed6cc3
PE
126 * xfns.c: Don't assume strlen fits in int.
127 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
128
4eab31dd
PE
129 * xdisp.c (message_log_check_duplicate): Return intmax_t,
130 not unsigned long, as we prefer signed integers. All callers changed.
131 Detect integer overflow in repeat count.
132 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 133 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 134
171e2a58
PE
135 * termcap.c: Don't assume sizes fit in int and never overflow.
136 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
137 (gobble_line): Check for size-calculation overflow.
138
ad39faca 139 * minibuf.c (Fread_buffer):
6e5bb2dc 140 * lread.c (intern, intern_c_string):
74ca2eb3
PE
141 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
142 Don't assume string length fits in int.
143
52c61c22 144 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
145 * gtkutil.c (style_changed_cb): Avoid need for strlen.
146
b5b8c9e5
PE
147 * font.c: Don't assume string length fits in int.
148 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
149 Use ptrdiff_t, not int.
ccd6111c
PE
150 (font_intern_prop): Don't assume string length fits in int.
151 Don't assume integer property fits in fixnum.
152 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 153
882f0d81 154 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 155 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
156 Reformulate so as not to need the command string.
157 Invoke gzip -cd rather than gunzip, as it's more portable.
158 (lock_info_type, lock_file_1, lock_file):
159 Don't assume pid_t and time_t fit in unsigned long.
160 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
161 (current_lock_owner): Prefer signed type for sizes.
162 Use memcpy, not strncpy, where memcpy is what is really wanted.
163 Don't assume (via atoi) that time_t and pid_t fit in int.
164 Check for time_t and/or pid_t out of range, e.g., via a network share.
165 Don't alloca where an auto var works fine.
166
93f4cf88
PE
167 * fileio.c: Fix some integer overflow issues.
168 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
169 Don't assume string length fits in int.
170 (directory_file_name): Don't assume string length fits in long.
171 (make_temp_name): Don't assume pid fits in int, or that its print
172 length is less than 20.
173
f3e92b69
PE
174 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
175
1bfdaf10
PE
176 * coding.c (make_subsidiaries): Don't assume string length fits in int.
177
35016e9a
PE
178 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
179
3d1e65a1
PE
180 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
181 We prefer signed integers, even for size calculations.
182
0b963a93
PE
183 * emacs.c: Don't assume string length fits in 'int'.
184 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
185 (main): Don't invoke strlen when not needed.
186
573f4b54
PE
187 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
188 (XD_DEBUG_MESSAGE): Don't waste a byte.
189
989f33ba
PE
190 * callproc.c (getenv_internal_1, getenv_internal)
191 (Fgetenv_internal):
965d34eb
PE
192 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
193
e4d29b33
PE
194 * lread.c (invalid_syntax): Omit length argument.
195 All uses changed. This doesn't fix a bug, but it simplifies the
196 code away from its former Hollerith-constant appearance, and it's
197 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 198 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 199
eb49b136
PE
200 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
201 This didn't break anything, but it didn't help either.
202 It's confusing to put a bogus integer in a place where the actual
203 value does not matter.
9f62aeb1 204 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 205 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 206
15375a22
PE
207 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
208 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
209 implementation.
b61cc01c
PE
210 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
211 We prefer signed types, and the value cannot exceed the EMACS_INT
212 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
213 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
214 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
215 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 216
53b2623d
PE
217 * indent.c (sane_tab_width): New function.
218 (current_column, scan_for_column, Findent_to, position_indentation)
219 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 220 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 221
51cab52b 222 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 223
f2ed8a70
PE
224 * lisp.h (lint_assume): New macro.
225 * composite.c (composition_gstring_put_cache):
226 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
227
abe80cc6
PE
228 * editfns.c, insdel.c:
229 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 230
b02c740e
PE
231 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
232
ebc96716
PE
233 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
234
b4e50fa0 235 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 236 Use much-faster test for byte-length change.
311d5d7c 237 Don't assume string byte-length fits in 'int'.
a4cf38e4 238 Check that character arg fits in 'int'.
85461888 239 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 240
c0c1ee9f
PE
241 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
242
a498d7f4
PE
243 * fns.c (concat): Catch string overflow earlier.
244 Do not rely on integer wraparound.
245
51cab52b
PE
246 * dispextern.h (struct it.overlay_strings_charpos)
247 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
248 * xdisp.c (forward_to_next_line_start)
249 (back_to_previous_visible_line_start)
250 (reseat_at_next_visible_line_start, next_element_from_buffer):
251 Don't arbitrarily truncate the value of 'selective' to int.
252
76031fad
PE
253 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
254
5eb55db9
PE
255 * composite.c: Don't truncate sizes to 'int'.
256 (composition_gstring_p, composition_reseat_it)
257 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
258 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
259 not EMACS_UINT, for indexes.
5eb55db9 260
0703a717
PE
261 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
262
d6202519
PE
263 * buffer.c: Include <verify.h>.
264 (struct sortvec.priority, struct sortstr.priority):
8961a454 265 Now EMACS_INT, not int.
c20998a7 266 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
267 (struct sortstr.size, record_overlay_string)
268 (struct sortstrlist.size, struct sortlist.used):
269 Don't truncate size to int.
270 (record_overlay_string): Check for size-calculation overflow.
d6202519 271 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 272
d5a19415
JM
2732011-06-22 Jim Meyering <meyering@redhat.com>
274
275 don't leak an XBM-image-sized buffer
276 * image.c (xbm_load): Free the image buffer after using it.
277
a9041e6c
PE
2782011-06-21 Paul Eggert <eggert@cs.ucla.edu>
279
280 Port to Sun C.
281 * composite.c (find_automatic_composition): Omit needless 'return 0;'
282 that Sun C diagnosed.
283 * fns.c (secure_hash): Fix pointer signedness issue.
284 * intervals.c (static_offset_intervals): New function.
285 (offset_intervals): Use it.
286
7f3f739f
LL
2872011-06-21 Leo Liu <sdl.web@gmail.com>
288
289 * deps.mk (fns.o):
290 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
291 sha512.h.
292
293 * fns.c (secure_hash): Rename from crypto_hash_function and change
294 the first arg to accept symbols.
295 (Fsecure_hash): New primtive.
296 (syms_of_fns): New symbols.
297
76147d94
DD
2982011-06-20 Deniz Dogan <deniz@dogan.se>
299
300 * process.c (Fset_process_buffer): Clarify return value in
301 docstring.
302
7d7d0045
CY
3032011-06-18 Chong Yidong <cyd@stupidchicken.com>
304
305 * dispnew.c (add_window_display_history): Use BVAR.
306
307 * xdisp.c (debug_method_add): Use BVAR.
308 (check_window_end, dump_glyph_matrix, dump_glyph)
309 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
310
311 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
312 Likewise.
313
314 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
315 check till after the cache is created in init_frame_faces.
316
ff2bc410
SM
3172011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
318
319 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
320
28177add
PE
3212011-06-16 Paul Eggert <eggert@cs.ucla.edu>
322
dd3482fe
PE
323 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
324 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
325 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
326
393d71f3 327 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
328 * fileio.c (Finsert_file_contents):
329 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
330 Remove the old (too-loose) buffer overflow checks.
331 They weren't needed, since make_gap checks for buffer overflow.
332 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
333 The old code merely checked for Emacs fixnum overflow, and relied
334 on undefined (wraparound) behavior. The new code avoids undefined
335 behavior, and also checks for ptrdiff_t and/or size_t overflow.
336
2e6813b0 337 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
338 Tune. Don't use wider integers than needed. Don't use alloca.
339 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 340
599a9e4f
PE
341 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
342
99561444
PE
343 * insdel.c, lisp.h (buffer_overflow): New function.
344 (insert_from_buffer_1, replace_range, replace_range_2):
345 * insdel.c (make_gap_larger):
346 * editfns.c (Finsert_char):
347 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
348
28177add
PE
349 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
350
e69dafad
PE
3512011-06-15 Paul Eggert <eggert@cs.ucla.edu>
352
a7af7fde 353 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 354
b1c46f02
PE
355 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
356 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
357
e69dafad
PE
358 * fileio.c: Don't assume EMACS_INT fits in off_t.
359 (emacs_lseek): New static function.
360 (Finsert_file_contents, Fwrite_region): Use it.
361 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
362
566684ea
PE
363 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
364
e6966cd6
PE
365 * fns.c: Don't overflow int when computing a list length.
366 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
367 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
368 truncation on 64-bit hosts. Check for QUIT every
369 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
370 faster and is responsive enough.
371 (Flength): Report an error instead of overflowing an integer.
372 (Fsafe_length): Return a float if the value is not representable
373 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 374 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 375 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 376
dd0b0efb
PE
377 * alloc.c: Check that resized vectors' lengths fit in fixnums.
378 (header_size, word_size): New constants.
379 (allocate_vectorlike): Don't check size overflow here.
380 (allocate_vector): Check it here instead, since this is the only
381 caller of allocate_vectorlike that could cause overflow.
382 Check that the new vector's length is representable as a fixnum.
383
86fe5cfe
PE
384 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
385 The previous code was bogus. For example, next_almost_prime (32)
386 returned 39, which is undesirable as it is a multiple of 3; and
387 next_almost_prime (24) returned 25, which is a multiple of 5 so
388 why was the code bothering to check for multiples of 7?
389
80e88859
PE
390 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
391
4a2f0ad6
PE
392 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
393
f66c7cf8
PE
394 Variadic C functions now count arguments with ptrdiff_t.
395 This partly undoes my 2011-03-30 change, which replaced int with size_t.
396 Back then I didn't know that the Emacs coding style prefers signed int.
397 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
398 were being counted with int, which may truncate counts on 64-bit
399 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
400 * lisp.h (struct Lisp_Subr.function.aMANY)
401 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
402 Arg counts are now ptrdiff_t, not size_t.
403 All variadic functions and their callers changed accordingly.
404 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
405 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
406 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
407 * callint.c (Fcall_interactively): Check arg count for overflow,
408 to avoid potential buffer overrun. Use signed char, not 'int',
409 for 'varies' array, so that we needn't bother to check its size
410 calculation for overflow.
411 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
412 * eval.c (apply_lambda):
413 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
414 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
415 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
416
a1759b76
PE
417 * callint.c (Fcall_interactively): Don't use index var as event count.
418
d96be9fc
PE
419 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
420 * mem-limits.h (SIZE): Remove; no longer used.
421
a690a978 422 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 423
578c21e6
PE
424 Remove unnecessary casts.
425 * xterm.c (x_term_init):
426 * xfns.c (x_set_border_pixel):
427 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
428 These aren't needed now that we assume ANSI C.
429
96f53c6c
PE
430 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
431 It's more likely to cause problems (due to unsigned overflow)
432 than to cure them.
433
83c77d31
PE
434 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
435
ee2079f1
PE
436 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
437
6da65536
PE
438 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
439
7147c4a4
PE
440 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
441
193e32d9
PE
442 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
443
e5533da6
PE
444 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
445
9910e595
PE
446 GLYPH_CODE_FACE returns EMACS_INT, not int.
447 * dispextern.h (merge_faces):
448 * xfaces.c (merge_faces):
01103c44
PE
449 * xdisp.c (get_next_display_element, next_element_from_display_vector):
450 Don't assume EMACS_INT fits in int.
9910e595 451
2638320e
PE
452 * character.h (CHAR_VALID_P): Remove unused parameter.
453 * fontset.c, lisp.h, xdisp.c: All uses changed.
454
045eb8d9
PE
455 * editfns.c (Ftranslate_region_internal): Omit redundant test.
456
c1f134b5
PE
457 * fns.c (concat): Minor tuning based on overflow analysis.
458 This doesn't fix any bugs. Use int to hold character, instead
459 of constantly refetching from Emacs object. Use XFASTINT, not
460 XINT, for value known to be a character. Don't bother comparing
461 a single byte to 0400, as it's always less.
462
395fcb93 463 * floatfns.c (Fexpt):
327eeec8
PE
464 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
465
abbd3d23
PE
466 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
467 for characters.
468
684a03ef
PE
469 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
470
0fed43f3
PE
471 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
472 Without this fix, on a 64-bit host (aset S 0 4294967386) would
473 incorrectly succeed when S was a string, because 4294967386 was
474 truncated before it was used.
475
8fd02eb7
PE
476 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
477 Otherwise, an out-of-range integer could cause undefined behavior
478 on a 64-bit host.
479
f8c86b69
PE
480 * composite.c: Use int, not EMACS_INT, for characters.
481 (fill_gstring_body, composition_compute_stop_pos): Use int, not
482 EMACS_INT, for values that are known to be in character range.
483 This doesn't fix any bugs but is the usual style inside Emacs and
484 may generate better code on 32-bit machines.
485
34206dd2
PE
486 Make sure a 64-bit char is never passed to ENCODE_CHAR.
487 This is for reasons similar to the recent CHAR_STRING fix.
488 * charset.c (Fencode_char): Check that character arg is actually
489 a character. Pass an int to ENCODE_CHAR.
490 * charset.h (ENCODE_CHAR): Verify that the character argument is no
491 wider than 'int', as a compile-time check to prevent future regressions
492 in this area.
493
c5958d4c 494 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
495
496 Make sure a 64-bit char is never passed to CHAR_STRING.
497 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
498 by silently ignoring the top 32 bits, allowing some values
499 that were far too large to be valid characters.
500 * character.h: Include <verify.h>.
501 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
502 arguments are no wider than unsigned, as a compile-time check
503 to prevent future regressions in this area.
504 * data.c (Faset):
01103c44 505 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
506 (Fsubst_char_in_region):
507 * fns.c (concat):
508 * xdisp.c (decode_mode_spec_coding):
509 Adjust to CHAR_STRING's new requirement.
510 * editfns.c (Finsert_char, Fsubst_char_in_region):
511 * fns.c (concat): Check that character args are actually
512 characters. Without this test, these functions did the wrong
513 thing with wildly out-of-range values on 64-bit hosts.
514
d37ca623
PE
515 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
516 These casts should not be needed on 32-bit hosts, either.
517 * keyboard.c (read_char):
518 * lread.c (Fload): Remove casts to unsigned.
519
ea204efb
PE
520 * lisp.h (UNSIGNED_CMP): New macro.
521 This fixes comparison bugs on 64-bit hosts.
522 (ASCII_CHAR_P): Use it.
523 * casefiddle.c (casify_object):
01103c44 524 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
525 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
526 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
527 * dispextern.h (FACE_FROM_ID):
528 * keyboard.c (read_char): Use UNSIGNED_CMP.
529
41cb286c
PE
530 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
531 not to EMACS_INT, to avoid GCC warning.
532
4a1b9832
PE
533 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
534
55daad71
PE
535 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
536 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
537 isn't needed on 32-bit machines.
8f95c75c 538
01103c44
PE
539 * buffer.c (Fgenerate_new_buffer_name):
540 Use EMACS_INT for count, not int.
0ceccced 541 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
542
543 * data.c (Qcompiled_function): Now static.
544
c6f072e7
PE
545 * window.c (window_body_lines): Now static.
546
20ce5912
PE
547 * image.c (gif_load): Rename local to avoid shadowing.
548
9c4c5f81
PE
549 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
550 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
551 * alloc.c (make_save_value): Integer argument is now of type
552 ptrdiff_t, not int.
553 (mark_object): Use ptrdiff_t, not int.
554 * lisp.h (pD): New macro.
555 * print.c (print_object): Use it.
556
c0c5c8ae
PE
557 * alloc.c: Use EMACS_INT, not int, to count objects.
558 (total_conses, total_markers, total_symbols, total_vector_size)
559 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
560 (total_free_floats, total_floats, total_free_intervals)
561 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
562 Now EMACS_INT, not int. All uses changed.
563 (Fgarbage_collect): Compute overall total using a double, so that
564 integer overflow is less likely to be a problem. Check for overflow
565 when converting back to an integer.
5a25e253
PE
566 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
567 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
568 These were 'int' variables that could overflow on 64-bit hosts;
569 they were never used, so remove them instead of repairing them.
211a0b2a 570 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
571 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
572 Previously, this ceilinged at INT_MAX, but that doesn't work on
573 64-bit machines.
e46bb31a 574 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 575
c78baabf 576 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 577 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
578 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
579 when a (possibly-narrower) signed value would do just as well.
580 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 581
c9d624c6
PE
582 * alloc.c: Catch some string size overflows that we were missing.
583 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
584 for convenience in STRING_BYTES_MAX.
585 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
586 The definition here is exact; the one in lisp.h was approximate.
587 (allocate_string_data): Check for string overflow. This catches
588 some instances we weren't catching before. Also, it catches
589 size_t overflow on (unusual) hosts where SIZE_MAX <= min
590 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
591 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 592
c9d624c6
PE
593 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
594 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
595 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
596
353032ce
PE
597 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
598
2bccce07
PE
599 * alloc.c (Fmake_string): Check for out-of-range init.
600
0ac30604
SM
6012011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
602
603 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
604
c195f2de
JD
6052011-06-14 Jan Djärv <jan.h.d@swipnet.se>
606
607 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
608 xg_get_default_scrollbar_width.
609
610 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
611 (int_gtk_range_get_value): Move to the scroll bar part of the file.
612 (style_changed_cb): Call update_theme_scrollbar_width and call
613 x_set_scroll_bar_default_width and xg_frame_set_char_size for
614 all frames (Bug#8505).
615 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
616 Call gtk_window_set_resizable if HAVE_GTK3.
617 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
618 and height if HAVE_GTK3 (Bug#8505).
619 (scroll_bar_width_for_theme): New variable.
620 (update_theme_scrollbar_width): New function.
621 (xg_get_default_scrollbar_width): Move code to
622 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
623 (xg_initialize): Call update_theme_scrollbar_width.
624
625 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
626
627 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
628
e10ac9f1
MR
6292011-06-12 Martin Rudalics <rudalics@gmx.at>
630
631 * frame.c (make_frame): Call other_buffer_safely instead of
632 other_buffer.
633
634 * window.c (temp_output_buffer_show): Call display_buffer with
635 second argument Vtemp_buffer_show_specifiers and reset latter
636 immediately after the call.
637 (Vtemp_buffer_show_specifiers): New variable.
638 (auto_window_vscroll_p, next_screen_context_lines)
639 (Vscroll_preserve_screen_position): Remove leading asterisks from
640 doc-strings.
641
2d3c217e 6422011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 643
7b7f97e8 644 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
645 * buffer.c (Qclone_number): Remove for now, as it's unused.
646 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
647 (record_buffer): Remove unused local.
648 * frame.c (other_visible_frames, frame_buffer_list): Now static.
649 (set_frame_buffer_list): Remove; unused.
650 * frame.h (other_visible_frames): Remove decl.
651 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
652 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
653 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
654 if HAVE_GPM.
655 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
656 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
657 Define only if HAVE_GPM.
658 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
659 (update_hints_inhibit): Remove; never set. All uses removed.
660 * widgetprv.h (emacsFrameClassRec): Remove decl.
661 * window.c (delete_deletable_window): Now returns void, since it
662 wasn't returning anything.
663 (compare_window_configurations): Remove unused locals.
664 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
665 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
666 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
667 the same widths as pointers. This follows up on the 2011-05-06 patch.
668 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
669 * xterm.h: Likewise.
670 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
671
1384b89e
JB
6722011-06-12 Juanma Barranquero <lekktu@gmail.com>
673
674 * makefile.w32-in: Update dependencies.
675 (LISP_H): Add lib/intprops.h.
676
1100a63c
CY
6772011-06-11 Chong Yidong <cyd@stupidchicken.com>
678
679 * image.c (gif_load): Add animation frame delay to the metadata.
680 (syms_of_image): Use DEFSYM. New symbol `delay'.
681
6198ccd0
MR
6822011-06-11 Martin Rudalics <rudalics@gmx.at>
683
684 * window.c (delete_deletable_window): Re-add.
685 (Fset_window_configuration): Rewrite to handle dead buffers and
686 consequently deletable windows.
687 (window_tree, Fwindow_tree): Remove. Supply functionality in
688 window.el.
689 (compare_window_configurations): Simplify code.
690
b6e3633c
AS
6912011-06-11 Andreas Schwab <schwab@linux-m68k.org>
692
1ab0dee5
AS
693 * image.c (imagemagick_load_image): Fix type mismatch.
694 (Fimagemagick_types): Likewise.
695
b6e3633c
AS
696 * window.h (replace_buffer_in_windows): Declare.
697
9397e56f
MR
6982011-06-11 Martin Rudalics <rudalics@gmx.at>
699
700 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
701 Qclone_number. Remove external declaration of Qdelete_window.
702 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
703 code.
704 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
705 Qbuffer_list_update_hook if allowed.
706 (Fother_buffer): Rewrite doc-string. Major rewrite for new
707 buffer list implementation.
708 (other_buffer_safely): New function.
709 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
710 calls to replace_buffer_in_windows and
711 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
712 if allowed.
713 (record_buffer): Inhibit quitting and rewrite using quittable
714 functions. Run Qbuffer_list_update_hook if allowed.
715 (Frecord_buffer, Funrecord_buffer): New functions.
716 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
717 switch-to-buffer to window.el.
718 (bury-buffer): Move to window.el.
719 (Vbuffer_list_update_hook): New variable.
720
721 * lisp.h (other_buffer_safely): Add prototype in buffer.c
722 section.
723
724 * window.h (resize_frame_windows): Move up in code.
725 (Fwindow_frame): Remove EXFUN.
726 (replace_buffer_in_all_windows): Remove prototype.
727 (replace_buffer_in_windows_safely): Add prototype.
728
729 * window.c: Declare Qdelete_window static again. Move down
730 declaration of select_count.
731 (Fnext_window, Fprevious_window): Rewrite doc-strings.
732 (Fother_window): Move to window.el.
733 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
734 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
735 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
736 window.el.
737 (replace_buffer_in_windows): Implement by calling
738 Qreplace_buffer_in_windows.
739 (replace_buffer_in_all_windows): Remove with some functionality
740 moved into replace_buffer_in_windows_safely.
741 (replace_buffer_in_windows_safely): New function.
742 (select_window_norecord, select_frame_norecord): Move in front
743 of run_window_configuration_change_hook. Remove now obsolete
744 declarations.
745 (Fset_window_buffer): Rewrite doc-string. Call
746 Qrecord_window_buffer.
747 (keys_of_window): Move binding for other-window to window.el.
748
b50691aa
CY
7492011-06-11 Chong Yidong <cyd@stupidchicken.com>
750
751 * dispextern.h (struct image): Replace data member, whose int_val
752 and ptr_val fields were not used by anything, with a single
753 lisp_val object.
754
755 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
756 (gif_clear_image, gif_load, imagemagick_load_image)
757 (gs_clear_image, gs_load): Callers changed.
758
3f754b86
PE
7592011-06-10 Paul Eggert <eggert@cs.ucla.edu>
760
cca69397
PE
761 * buffer.h: Include <time.h>, for time_t.
762 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
763
109e28d0
PE
764 Fix minor problems found by static checking.
765
60737f02
PE
766 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
767
4b66faf3
PE
768 Make identifiers static if they are not used in other modules.
769 * data.c (Qcompiled_function, Qframe, Qvector):
770 * image.c (QimageMagick, Qsvg):
771 * minibuf.c (Qmetadata):
772 * window.c (resize_window_check, resize_root_window): Now static.
773 * window.h (resize_window_check, resize_root_window): Remove decls.
774
109e28d0
PE
775 * window.c (window_deletion_count, delete_deletable_window):
776 Remove; unused.
46a4ce9e
PE
777 (window_body_lines): Now static.
778 (Fdelete_other_windows_internal): Mark vars as initialized.
779 Make sure 'resize_failed' is initialized.
780 (run_window_configuration_change_hook): Rename local to avoid shadowing.
781 (resize_window_apply): Remove unused local.
782 * window.h (delete_deletable_window): Remove decl.
783
109e28d0 784 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
785 (imagemagick_load_image): Fix pointer signedness problem by changing
786 last arg from unsigned char * to char *. All uses changed.
787 Also, fix a local for similar reasons.
788 Remove unused locals. Remove locals to avoid shadowing.
789 (fn_rsvg_handle_free): Remove; unused.
790 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 791 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 792
3f754b86
PE
793 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
794
2547adb1
CY
7952011-06-10 Chong Yidong <cyd@stupidchicken.com>
796
797 * image.c (gif_load): Fix omitted cast error introduced by
798 2011-06-06 change.
799
2c8e37d4
MR
8002011-06-10 Martin Rudalics <rudalics@gmx.at>
801
802 * window.h (resize_proportionally, orig_total_lines)
803 (orig_top_line): Remove from window structure.
804 (set_window_height, set_window_width, change_window_heights)
805 (Fdelete_window): Remove prototypes.
806 (resize_frame_windows): Remove duplicate declaration.
807
440a42e3
EZ
8082011-06-10 Eli Zaretskii <eliz@gnu.org>
809
810 * window.h (resize_frame_windows, resize_window_check)
811 (delete_deletable_window, resize_root_window)
812 (resize_frame_windows): Declare prototypes.
813
814 * window.c (resize_window_apply): Make definition be "static" to
815 match the prototype.
816
562dd5e9
MR
8172011-06-10 Martin Rudalics <rudalics@gmx.at>
818
819 * window.c: Remove declarations of Qwindow_size_fixed,
820 window_min_size_1, window_min_size_2, window_min_size,
821 size_window, window_fixed_size_p, enlarge_window, delete_window.
822 Remove static from declaration of Qdelete_window, it's
823 temporarily needed by Fbury_buffer.
824 (replace_window): Don't assign orig_top_line and
825 orig_total_lines.
826 (Fdelete_window, delete_window): Remove. Window deletion is
827 handled by window.el.
828 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
829 Fdelete_window calls with calls to Qdelete_window.
830 (Fdelete_other_windows): Remove. Deleting other windows is
831 handled by window.el.
832 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
833 handled in window.el.
834 (window_min_size_2, window_min_size_1, window_min_size): Remove.
835 Window minimum sizes are handled in window.el.
836 (shrink_windows, size_window, set_window_height)
837 (set_window_width, change_window_heights, window_height)
838 (window_width, CURBEG, CURSIZE, enlarge_window)
839 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
840 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
841 handled in window.el.
842 (make_dummy_parent): Rename to make_parent_window and give it a
843 second argument horflag.
844 (make_window): Don't set resize_proportionally any more.
845 (Fsplit_window): Remove. Windows are split in window.el.
846 (save_restore_action, save_restore_orig_size)
847 (shrink_window_lowest_first, save_restore_orig_size): Remove.
848 Resize mini windows in window.el.
849 (grow_mini_window, shrink_mini_window): Implement by calling
850 Qresize_root_window_vertically, resize_window_check and
851 resize_window_apply.
852 (saved_window, Fset_window_configuration, save_window_save): Do
853 not handle orig_top_line, orig_total_lines, and
854 resize_proportionally.
855 (window_min_height, window_min_width): Move to window.el.
856 (keys_of_window): Move bindings for delete-other-windows,
857 split-window, delete-window and enlarge-window to window.el.
858
859 * buffer.c: Temporarily extern Qdelete_window.
860 (Fbury_buffer): Temporarily call Qdelete_window instead of
861 Fdelete_window (Fbury_buffer will move to window.el soon).
862
863 * frame.c (set_menu_bar_lines_1): Remove code handling
864 orig_top_line and orig_total_lines.
865
866 * dispnew.c (adjust_frame_glyphs_initially): Don't use
867 set_window_height but set heights directly.
868 (change_frame_size_1): Use resize_frame_windows.
869
870 * xdisp.c (init_xdisp): Don't use set_window_height but set
871 heights directly.
872
873 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
874 resize_frame_windows instead of change_window_heights and run
875 run_window_configuration_change_hook.
876
877 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
878 instead of change_window_heights and run
879 run_window_configuration_change_hook.
880
1a13852e
MR
8812011-06-09 Martin Rudalics <rudalics@gmx.at>
882
883 * window.c (replace_window): Rename second argument REPLACEMENT to
884 NEW. New third argument SETFLAG. Rewrite.
885 (delete_window, make_dummy_parent): Call replace_window with
886 third argument 1.
887 (window_list_1): Move down in code.
888 (run_window_configuration_change_hook): Move set_buffer part
889 before select_frame_norecord part in order to unwind correctly.
890 Rename count1 to count.
891 (recombine_windows, delete_deletable_window, resize_root_window)
892 (Fdelete_other_windows_internal)
893 (Frun_window_configuration_change_hook, make_parent_window)
894 (resize_window_check, resize_window_apply, Fresize_window_apply)
895 (resize_frame_windows, Fsplit_window_internal)
896 (Fdelete_window_internal, Fresize_mini_window_internal): New
897 functions.
898 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
899
f3d1777e
MR
9002011-06-08 Martin Rudalics <rudalics@gmx.at>
901
496e208e
MR
902 * window.h (window): Add some new members to window structure -
903 normal_lines, normal_cols, new_total, new_normal, clone_number,
904 splits, nest, prev_buffers, next_buffers.
905 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 906 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 907
f3d1777e
MR
908 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
909 Remove.
496e208e
MR
910 (make_dummy_parent): Set new members of windows structure.
911 (make_window): Move down in code. Handle new members of window
912 structure.
913 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
914 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
915 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
916 (Fset_window_prev_buffers, Fwindow_next_buffers)
917 (Fset_window_next_buffers, Fset_window_clone_number): New
918 functions.
919 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
920 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
921 Doc-string fixes.
922 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
923 Argument WINDOW can be now internal window too.
924 (Fwindow_use_time): Move up in code.
925 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
926 Rewrite doc-string.
927 (Fset_window_configuration, saved_window)
928 (Fcurrent_window_configuration, save_window_save): Handle new
929 members of window structure.
b9e809c2
MR
930 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
931 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
932 (syms_of_window): New Lisp objects Qrecord_window_buffer,
933 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
934 Qget_mru_window, Qresize_root_window,
935 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
936 Qauto_buffer_name; staticpro them.
f3d1777e 937
abde8f8c
MR
9382011-06-07 Martin Rudalics <rudalics@gmx.at>
939
940 * window.c (Fwindow_total_size, Fwindow_left_column)
941 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
942 (Fwindow_list_1): New functions.
943 (window_box_text_cols): Replace with window_body_cols.
944 (Fwindow_width, Fscroll_left, Fscroll_right): Use
945 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
946 (delete_window, Fset_window_configuration): Call
947 delete_all_subwindows with window as argument.
948 (delete_all_subwindows): Take a window as argument and not a
949 structure. Rewrite.
190b47e6
MR
950 (window_loop): Remove handling of GET_LRU_WINDOW and
951 GET_LARGEST_WINDOW.
952 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
953
954 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
955 window_box_text_cols. delete_all_subwindows now takes a
956 Lisp_Object as argument.
abde8f8c
MR
957
958 * indent.c (compute_motion, Fcompute_motion): Use
959 window_body_cols instead of window_box_text_cols.
960
fa8a67e6
MR
961 * frame.c (delete_frame): Call delete_all_subwindows with root
962 window as argument.
963
a54e3482
DC
9642011-06-07 Daniel Colascione <dan.colascione@gmail.com>
965
966 * fns.c (Fputhash): Document return value.
967
60002bf5
CY
9682011-06-06 Chong Yidong <cyd@stupidchicken.com>
969
970 * image.c (gif_load): Implement gif89a spec "no disposal" method.
971
0c671da6 9722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 973
b862a52a 974 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 975
be44ca6c
PE
976 Check for overflow when converting integer to cons and back.
977 * charset.c (Fdefine_charset_internal, Fdecode_char):
978 Use cons_to_unsigned to catch overflow.
979 (Fencode_char): Use INTEGER_TO_CONS.
980 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
981 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
982 * data.c (long_to_cons, cons_to_long): Remove.
983 (cons_to_unsigned, cons_to_signed): New functions.
984 These signal an error for invalid or out-of-range values.
985 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
986 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
987 * font.c (Ffont_variation_glyphs):
988 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
989 * lisp.h: Include <intprops.h>.
990 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
991 (cons_to_signed, cons_to_unsigned): New decls.
992 (long_to_cons, cons_to_long): Remove decls.
993 * undo.c (record_first_change): Use INTEGER_TO_CONS.
994 (Fprimitive_undo): Use CONS_TO_INTEGER.
995 * xfns.c (Fx_window_property): Likewise.
996 * xselect.c: Include <limits.h>.
997 (x_own_selection, selection_data_to_lisp_data):
998 Use INTEGER_TO_CONS.
999 (x_handle_selection_request, x_handle_selection_clear)
1000 (x_get_foreign_selection, Fx_disown_selection_internal)
1001 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1002 (lisp_data_to_selection_data): Use cons_to_unsigned.
1003 (x_fill_property_data): Use cons_to_signed.
1004 Report values out of range.
1005
d1f3d2af
PE
1006 Check for buffer and string overflow more precisely.
1007 * buffer.h (BUF_BYTES_MAX): New macro.
1008 * lisp.h (STRING_BYTES_MAX): New macro.
1009 * alloc.c (Fmake_string):
1010 * character.c (string_escape_byte8):
1011 * coding.c (coding_alloc_by_realloc):
1012 * doprnt.c (doprnt):
1013 * editfns.c (Fformat):
1014 * eval.c (verror):
1015 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1016 since they may not be the same number.
1017 * editfns.c (Finsert_char):
1018 * fileio.c (Finsert_file_contents):
1019 Likewise for BUF_BYTES_MAX.
1020
dd52fcea
PE
1021 * image.c: Use ptrdiff_t, not int, for sizes.
1022 (slurp_file): Switch from int to ptrdiff_t.
1023 All uses changed.
1024 (slurp_file): Check that file size fits in both size_t (for
1025 malloc) and ptrdiff_t (for sanity and safety).
1026
7f9bbdbb
PE
1027 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1028 if b->modtime has its maximal value.
1029
dfe18f82
PE
1030 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1031
84acfcf0
PE
1032 Don't assume time_t can fit into int.
1033 * buffer.h (struct buffer.modtime): Now time_t, not int.
1034 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1035 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1036
ccd9a01a
PE
1037 Minor fixes for signed vs unsigned integers.
1038 * character.h (MAYBE_UNIFY_CHAR):
1039 * charset.c (maybe_unify_char):
1040 * keyboard.c (read_char, reorder_modifiers):
1041 XINT -> XFASTINT, since the integer must be nonnegative.
1042 * ftfont.c (ftfont_spec_pattern):
1043 * keymap.c (access_keymap, silly_event_symbol_error):
1044 XUINT -> XFASTINT, since the integer must be nonnegative.
1045 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1046 since it makes no difference and we prefer signed.
1047 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1048 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1049 nonnegative.
1050
d6d100dd
SM
10512011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1052
1053 * window.h (Fwindow_frame): Declare.
1054
2b6148e4
PE
10552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1056
1057 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1058 (SPARE_MEMORY): Always define.
1059 (LARGE_REQUEST): Remove.
1060 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1061
f230ecc9
MR
10622011-06-06 Martin Rudalics <rudalics@gmx.at>
1063
727e958e
MR
1064 * lisp.h: Move EXFUNS for Fframe_root_window,
1065 Fframe_first_window and Fset_frame_selected_window to window.h.
1066
1067 * window.h: Move EXFUNS for Fframe_root_window,
1068 Fframe_first_window and Fset_frame_selected_window here from
1069 lisp.h.
1070
1071 * frame.c (Fwindow_frame, Fframe_first_window)
1072 (Fframe_root_window, Fframe_selected_window)
1073 (Fset_frame_selected_window): Move to window.c.
1074 (Factive_minibuffer_window): Move to minibuf.c.
1075 (Fother_visible_frames_p): New function.
1076
1077 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1078
f230ecc9
MR
1079 * window.c (decode_window, decode_any_window): Move up in code.
1080 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1081 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1082 (Fwindow_buffer): Move up and rewrite doc-string.
1083 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1084 (Fwindow_prev): New functions.
727e958e
MR
1085 (Fwindow_frame): Move here from frame.c. Accept any window as
1086 argument.
1087 (Fframe_root_window, Fframe_first_window)
1088 (Fframe_selected_window): Move here from frame.c. Accept frame
1089 or arbitrary window as argument. Update doc-strings.
1090 (Fminibuffer_window): Move up in code.
1091 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1092 (Fset_frame_selected_window): Move here from frame.c.
1093 Marginal rewrite.
727e958e
MR
1094 (Fselected_window, select_window, Fselect_window): Move up in
1095 code. Minor doc-string fixes.
f230ecc9 1096
4d09bcf6
PE
10972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1098
1099 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1100 Do not assume that spare memory exists; that assumption is valid
1101 only if SYSTEM_MALLOC.
1102 (LARGE_REQUEST): New macro, so that the issue of large requests
1103 is separated from the issue of spare memory.
1104
810928a2
AS
11052011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1106
172418ad
AS
1107 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1108 format. (Bug#8806)
1109
43f862f7
AS
1110 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1111
810928a2
AS
1112 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1113 before statements.
1114
a059fe24
JD
11152011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1116
1117 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1118
1119 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1120
1121 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1122 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1123
989bf368
JB
11242011-06-05 Juanma Barranquero <lekktu@gmail.com>
1125
1126 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1127
4b80f674
CY
11282011-06-04 Chong Yidong <cyd@stupidchicken.com>
1129
1130 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1131 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1132 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1133 New error handlers.
4b80f674
CY
1134 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1135 Obey Vx_select_enable_clipboard_manager. Catch errors in
1136 x_clipboard_manager_save (Bug#8779).
1137 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1138 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1139
99a33b77 11402011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1141
1142 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1143
99a33b77 11442011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1145
1146 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1147 in the current matrix if keep_current_p is non-zero.
1148
8264569d
EZ
11492011-06-04 Eli Zaretskii <eliz@gnu.org>
1150
1151 * bidi.c (bidi_level_of_next_char): Fix last change.
1152
57f97249
EZ
11532011-06-03 Eli Zaretskii <eliz@gnu.org>
1154
fec2107c 1155 Support bidi reordering of text covered by display properties.
57f97249 1156
fec2107c
EZ
1157 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1158 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1159 (bidi_cache_search, bidi_cache_iterator_state)
1160 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1161 (bidi_level_of_next_char, bidi_move_to_visually_next):
1162 Support character positions inside a run of characters covered by a
fec2107c
EZ
1163 display string.
1164 (bidi_paragraph_init, bidi_resolve_explicit_1)
1165 (bidi_level_of_next_char): Call bidi_fetch_char and
1166 bidi_fetch_char_advance instead of FETCH_CHAR and
1167 FETCH_CHAR_ADVANCE.
1168 (bidi_init_it): Initialize new members.
1169 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1170 definitions.
1171 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1172 instead of using explicit *_CHAR codes.
d6d100dd
SM
1173 (bidi_resolve_explicit, bidi_resolve_weak):
1174 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1175 bidirectional text is supported only in multibyte buffers.
1176 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1177 it to initialize the frame_window_p member of struct bidi_it.
1178 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1179 (bidi_resolve_explicit, bidi_resolve_weak)
1180 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1181 bidi_it->nchars is non-positive.
1182 (bidi_level_of_next_char): Don't try to lookup the cache for the
1183 next/previous character if nothing is cached there yet, or if we
1184 were just reseat()'ed to a new position.
c40e2fb2 1185
0e14fe90
EZ
1186 * xdisp.c (set_cursor_from_row): Set start and stop points
1187 according to the row's direction when priming the loop that looks
1188 for the glyph on which to display cursor.
1189 (single_display_spec_intangible_p): Function deleted.
1190 (display_prop_intangible_p): Reimplement to call
1191 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1192 Accept 3 additional arguments needed by handle_display_spec.
1193 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1194 values: lists, `(when COND...)' forms, etc.
1195 (single_display_spec_string_p): Support property values that are
1196 lists with the argument STRING its top-level element.
1197 (display_prop_string_p): Fix the condition for processing a
1198 property that is a list to be consistent with handle_display_spec.
fec2107c 1199 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1200 last portion of handle_display_prop.
1201 (compute_display_string_pos): Accept additional argument
1202 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1203 value of a `display' property is a "replacing spec".
1204 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1205 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1206 the display property, but just return a value indicating whether
1207 the display property will replace the characters it covers.
1208 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1209 frame_window_p members of struct bidi_it.
d6d100dd
SM
1210 (compute_display_string_pos, compute_display_string_end):
1211 New functions.
fec2107c
EZ
1212 (push_it): Accept second argument POSITION, where pop_it should
1213 jump to continue iteration.
1214 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1215
fec2107c
EZ
1216 * keyboard.c (adjust_point_for_property): Adjust the call to
1217 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1218
1219 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1220 (bidi_init_it): Update prototypes.
1221 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1222 (compute_display_string_pos, compute_display_string_end):
1223 Declare prototypes.
fec2107c
EZ
1224 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1225 EMACS_INT.
fc6f18ce 1226
40087514 12272011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1228
57f53182
PE
1229 Malloc failure behavior now depends on size of allocation.
1230 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1231 * lisp.h: Change signatures accordingly.
1232 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1233 All callers changed. (Bug#8762)
1234
1235 * gnutls.c: Use Emacs's memory allocators.
1236 Without this change, the gnutls library would invoke malloc etc.
1237 directly, which causes problems on non-SYNC_INPUT hosts, and which
1238 runs afoul of improving memory_full behavior. (Bug#8761)
1239 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1240 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1241 xfree instead of the default malloc, realloc, free.
1242 (Fgnutls_boot): No need to check for memory allocation failure,
1243 since xmalloc does that for us.
1244
ac32cd99 1245 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1246 * category.c (hash_get_category_set):
1247 * ccl.c (ccl_driver):
1248 * charset.c (Fdefine_charset_internal):
1249 * charset.h (struct charset.hash_index):
1250 * composite.c (get_composition_id, gstring_lookup_cache)
1251 (composition_gstring_put_cache):
1252 * composite.h (struct composition.hash_index):
1253 * dispextern.h (struct image.hash):
1254 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1255 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1256 (hashfn_equal, hashfn_user_defined, make_hash_table)
1257 (maybe_resize_hash_table, hash_lookup, hash_put)
1258 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1259 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1260 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1261 * image.c (make_image, search_image_cache, lookup_image)
1262 (xpm_put_color_table_h):
1263 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1264 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1265 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1266 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1267 * alloc.c (allocate_vectorlike):
1268 Check for overflow in vector size calculations.
1269 * ccl.c (ccl_driver):
1270 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1271 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1272 need to be updated by these changes.
40087514
PE
1273 * fns.c (make_hash_table, maybe_resize_hash_table):
1274 Check for integer overflow with large hash tables.
0de4bb68
PE
1275 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1276 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1277 (SXHASH_REDUCE): New macro.
1278 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1279 Use it instead of discarding useful hash info with large hash values.
1280 (sxhash_float): New function.
1281 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1282 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1283 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1284 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1285 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1286 Adjust signatures to match updated version of code.
1287 (consing_since_gc): Now EMACS_INT, since a single hash table can
1288 use more than INT_MAX bytes.
1289
698d32e2
DN
12902011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1291
1292 Make it possible to build with GCC-4.6+ -O2 -flto.
1293
1294 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1295
fd6fa53f
SM
12962011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1297
1298 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1299 Call minibuffer-inactive-mode.
1300
864db017
JB
13012011-05-31 Juanma Barranquero <lekktu@gmail.com>
1302
1303 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1304 Update dependencies.
1305
2ad0baf4
DN
13062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1307
1308 * data.c (init_data): Remove code for UTS, this system is not
1309 supported anymore.
1310
4fcc2638
DN
13112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1312
1313 Don't force ./temacs to start in terminal mode.
1314
1315 * frame.c (make_initial_frame): Initialize faces in all cases, not
1316 only when CANNOT_DUMP is defined.
1317 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1318
c56e0fd5
DN
13192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1320
1321 * dispnew.c (add_window_display_history): Use const for the string
1322 pointer. Remove declaration, not needed.
1323
333d54da 13242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1325
55d4c1b2 1326 Use 'inline', not 'INLINE'.
333d54da 1327 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1328 * alloc.c, fontset.c (INLINE): Remove.
1329 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1330 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1331 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1332 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1333 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1334
738db178
DN
13352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1336
1337 Make it possible to run ./temacs.
1338
1339 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1340 syms_of_callproc does the same thing. Remove test for
1341 "initialized", do it in the caller.
1342 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1343
620c53a6
SM
13442011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1345
1346 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1347 (read_minibuf): Use get_minibuffer.
1348 (syms_of_minibuf): Use DEFSYM.
1349 (Qmetadata): New var.
1350 * data.c (Qbuffer): Don't make it static.
1351 (syms_of_data): Use DEFSYM.
1352
e003a292
PE
13532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1356 (CCL_CODE_MIN): New macro.
1357
ed008a6d
PE
13582011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1359
3687c2ef
PE
1360 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1361
ed008a6d
PE
1362 * eval.c (Qdebug): Now static.
1363 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1364 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1365 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1366
d66c4c7c
CY
13672011-05-29 Chong Yidong <cyd@stupidchicken.com>
1368
1369 * image.c: Various fixes to ImageMagick code comments.
1370 (Fimagemagick_types): Doc fix.
1371
5fbc2025
PE
13722011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1373
0196f88a
PE
1374 Minor fixes prompted by GCC 4.6.0 warnings.
1375
1376 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1377
5fbc2025
PE
1378 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1379 (x_clipboard_manager_save_all): Move extern decl to ...
1380 * xterm.h: ... here, so that it can be checked for consistency.
1381
1dd3c2d9
CY
13822011-05-29 Chong Yidong <cyd@stupidchicken.com>
1383
1384 * xselect.c (x_clipboard_manager_save_frame)
1385 (x_clipboard_manager_save_all): New functions.
1386 (Fx_clipboard_manager_save): Lisp function deleted.
1387
1388 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1389 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1390
1391 * xterm.h: Update prototype.
1392
5ba6571d
WX
13932011-05-28 William Xu <william.xwl@gmail.com>
1394
1395 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1396 exiting (Bug#8239).
1397
3eaff834
JM
13982011-05-28 Jim Meyering <meyering@redhat.com>
1399
e1900994 1400 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1401 * fns.c (to_uchar): Define.
1402 (crypto_hash_function): Use it to convert some newly-signed
1403 variables to unsigned, to avoid sign-extension bugs. For example,
1404 without this change, (md5 "truc") would evaluate to
1405 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1406 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1407 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1408
0f6990a7
PE
14092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 Integer overflow fixes.
c8a9ca5a 1412
08686060
PE
1413 * dbusbind.c: Serial number integer overflow fixes.
1414 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1415 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1416 to hold a serial number that is too large for a fixnum.
1417 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1418 Check for serial numbers out of range. Decode any serial number
59568bf0 1419 that was so large that it became a float. (Bug#8722)
08686060 1420
2d1fc3c7
PE
1421 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1422 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1423 Use XFASTINT rather than XUINT when numbers are nonnegative.
1424 (xd_append_arg, Fdbus_method_return_internal):
1425 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1426 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1427 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1428 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1429 (Bug#8722)
2d1fc3c7 1430
c8a9ca5a
PE
1431 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1432
519e1d69
PE
1433 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1434
30569699
PE
1435 ccl: add integer overflow checks
1436 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1437 (IN_INT_RANGE): New macros.
1438 (ccl_driver): Use them to check for integer overflow when
1439 decoding a CCL program. Many of the new checks are whether XINT (x)
1440 fits in int; it doesn't always, on 64-bit hosts. The new version
1441 doesn't catch all possible integer overflows, but it's an
847044ea 1442 improvement. (Bug#8719)
30569699 1443
c11285dc
PE
1444 * alloc.c (make_event_array): Use XINT, not XUINT.
1445 There's no need for unsigned here.
1446
fdccd48e
PE
1447 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1448 This follows up to the 2011-05-06 change that substituted uintptr_t
1449 for EMACS_INT. This case wasn't caught back then.
1450
37910ab2
PE
1451 Rework Fformat to avoid integer overflow issues.
1452 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1453 now (part of C89). Include <verify.h>.
1454 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1455 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1456 (Fformat): Avoid the prepass trying to compute sizes; it was only
1457 approximate and thus did not catch overflow reliably. Instead, walk
1458 through the format just once, formatting and computing sizes as we go,
1459 checking for integer overflow at every step, and allocating a larger
1460 buffer as needed. Keep track separately whether the format is
1461 multibyte. Keep only the most-recently calculated precision, rather
1462 than them all. Record whether each argument has been converted to
1463 string. Use EMACS_INT, not int, for byte and char and arg counts.
1464 Support field widths and precisions larger than INT_MAX. Avoid
1465 sprintf's undefined behavior with conversion specifications such as %#d
1466 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1467 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1468 formatting out-of-range floating point numbers with int
1469 formats. (Bug#8668)
1470
2e6578fb
PE
1471 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1472
0ae6bdee
PE
1473 * data.c: Avoid integer truncation in expressions involving floats.
1474 * data.c: Include <intprops.h>.
1475 (arith_driver): When there's an integer overflow in an expression
1476 involving floating point, convert the integers to floating point
1477 so that the resulting value does not suffer from catastrophic
1478 integer truncation. For example, on a 64-bit host (* 4
1479 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1480 Do not rely on undefined behavior after integer overflow.
1481
de883a70
PE
1482 merge count_size_as_multibyte, parse_str_to_multibyte
1483 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1484 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1485 Check for integer overflow.
1486 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1487 since it's now a duplicate of the other. This is more of
1488 a character than a buffer op, so better that it's in character.c.
1489 * fns.c, print.c: Adjust to above changes.
1490
2ff916cb
PE
14912011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1492
1493 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1494
f1b54466
PE
14952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1496
fb1ac845
PE
1497 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1498 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1499 (x_clipboard_manager_save): Now static.
1500 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1501
f1b54466
PE
1502 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1503 (crypto_hash_function): Now static.
1504 Fix pointer signedness problems. Avoid unnecessary initializations.
1505
a9f737ee
CY
15062011-05-27 Chong Yidong <cyd@stupidchicken.com>
1507
1508 * termhooks.h (Vselection_alist): Make it terminal-local.
1509
1510 * terminal.c (create_terminal): Initialize it.
1511
1512 * xselect.c: Support for clipboard managers.
1513 (Vselection_alist): Move to termhooks.h as terminal-local var.
1514 (LOCAL_SELECTION): New macro.
1515 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1516 (symbol_to_x_atom): Remove gratuitous arg.
1517 (x_handle_selection_request, lisp_data_to_selection_data)
1518 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1519 (x_own_selection, x_get_local_selection, x_convert_selection):
1520 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1521 (some_frame_on_display): Delete unused function.
1522 (Fx_own_selection_internal, Fx_get_selection_internal)
1523 (Fx_disown_selection_internal, Fx_selection_owner_p)
1524 (Fx_selection_exists_p): New optional frame arg.
1525 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1526 (x_handle_selection_clear): Don't treat other terminals with the
1527 same keyboard specially. Use the terminal-local Vselection_alist.
1528 (x_clear_frame_selections): Use Frun_hook_with_args.
1529
1530 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1531
1532 * xterm.h: Add support for those atoms.
1533
e067f0c1
CY
15342011-05-26 Chong Yidong <cyd@stupidchicken.com>
1535
1536 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1537 (converted_selections, conversion_fail_tag): New global variables.
1538 (x_selection_request_lisp_error): Free the above.
1539 (x_get_local_selection): Remove unnecessary code.
1540 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1541 of converted selections stored in converted_selections.
1542 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1543 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1544 (x_convert_selection): New function.
1545 (x_handle_selection_event): Simplify.
1546 (x_get_foreign_selection): Don't ignore incoming requests while
1547 waiting for an answer; this will fail when we implement
1548 SAVE_TARGETS, and seems unnecessary anyway.
1549 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1550 (Vx_sent_selection_functions): Doc fix.
1551
0f4aebc0
LL
15522011-05-26 Leo Liu <sdl.web@gmail.com>
1553
1554 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1555
e61124cd
YM
15562011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1557
1558 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1559
1560 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1561 for fringe update if it has periodic bitmap.
1562 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1563 and fringe_bitmap_periodic_p.
1564
1565 * fringe.c (get_fringe_bitmap_data): New function.
1566 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1567 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1568 row. Mark glyph row for fringe update if periodicity changed.
1569
1570 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1571 for fringe update unless it has periodic bitmap.
1572
f16d9837
KH
15732011-05-25 Kenichi Handa <handa@m17n.org>
1574
1575 * xdisp.c (get_next_display_element): Set correct it->face_id for
1576 a static composition.
1577
e1b90ef6
LL
15782011-05-24 Leo Liu <sdl.web@gmail.com>
1579
1580 * deps.mk (fns.o):
1581 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1582
1583 * fns.c (crypto_hash_function, Fsha1): New function.
1584 (Fmd5): Use crypto_hash_function.
1585 (syms_of_fns): Add Ssha1.
1586
7400048f
PE
15872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 * gnutls.c: Remove unused macros.
1590 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1591 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1592 Remove macros that are defined and never used.
1593 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1594
abb71cf4
CY
15952011-05-22 Chong Yidong <cyd@stupidchicken.com>
1596
1597 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1598 (Fx_get_selection_internal): Minor cleanup.
1599 (Fx_own_selection_internal): Rename arguments for consistency with
1600 select.el.
1601
6307db39
PE
16022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1603
1604 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1605
f3d4e0a4
CY
16062011-05-22 Chong Yidong <cyd@stupidchicken.com>
1607
1608 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1609
4d8ade89
YM
16102011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1611
1612 * dispnew.c (scrolling_window): Don't exclude the case that the
1613 last enabled row in the desired matrix touches the bottom boundary.
1614
32078c8d
GM
16152011-05-21 Glenn Morris <rgm@gnu.org>
1616
1617 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1618 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1619 and add some more files.
32078c8d 1620
7285dc67
EZ
16212011-05-20 Eli Zaretskii <eliz@gnu.org>
1622
1623 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1624 report_file_error introduced by the change from 2011-05-07.
1625
89d1bd22
PE
16262011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 * systime.h (Time): Define only if emacs is defined.
1629 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1630 where the include path doesn't have X11/X.h by default. See
1631 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1632
e23640bb 16332011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1634
1635 * composite.c (find_automatic_composition): Fix previous change.
1636
b9704ad9
GM
16372011-05-20 Glenn Morris <rgm@gnu.org>
1638
1639 * lisp.mk: New file, split from Makefile.in.
1640 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1641 (shortlisp): Remove.
1642 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1643
4a720484
GM
16442011-05-19 Glenn Morris <rgm@gnu.org>
1645
1646 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1647 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1648 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1649 (lisp): Set the order to that of loadup.el.
1650 (shortlisp): Make it a copy of $lisp.
1651 (SOME_MACHINE_LISP): Remove.
1652 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1653 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1654
a28d4396
KH
16552011-05-18 Kenichi Handa <handa@m17n.org>
1656
1657 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1658 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1659 (find_automatic_composition): Mostly rewrite for efficiency.
1660
a2b1fa8e
JB
16612011-05-18 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * makefile.w32-in: Update dependencies.
1664
8e1f5610
CS
16652011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1666
1667 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1668 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1669
7025ee00 16702011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1671
cdfa6eab
PE
1672 Fix some integer overflow issues, such as string length overflow.
1673
06d6db33
PE
1674 * insdel.c (count_size_as_multibyte): Check for string overflow.
1675
2b4560a8
PE
1676 * character.c (lisp_string_width): Check for string overflow.
1677 Use EMACS_INT, not int, for string indexes and lengths; in
1678 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1679 the resulting string length overflows an EMACS_INT; instead,
1680 report a string overflow if no precision given. When checking for
1681 precision exhaustion, use a check that cannot possibly have
1682 integer overflow. (Bug#8675)
1683 * character.h (lisp_string_width): Adjust to new signature.
1684
cb93f9be
PE
1685 * alloc.c (string_overflow): New function.
1686 (Fmake_string): Use it. This doesn't change behavior, but saves
1687 a few bytes and will simplify future changes.
1688 * character.c (string_escape_byte8): Likewise.
1689 * lisp.h (string_overflow): New decl.
1690
1a1f3366
PE
1691 Fixups, following up to the user-interface timestamp change.
1692 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1693 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1694 * msdos.c (mouse_get_pos): Likewise.
1695 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1696 * w32gui.h (Time): Define by including "systime.h" rather than by
1697 declaring it ourselves. (Bug#8664)
1698
d4e3e4d3
PE
1699 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1700 * image.c (clear_image_cache): Likewise.
1701
f6a24d19
PE
1702 * term.c (term_mouse_position): Don't assume time_t wraparound.
1703
08dc5ae6
PE
1704 Be more systematic about user-interface timestamps.
1705 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1706 and sometimes 'EMACS_UINT', to represent these timestamps.
1707 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1708 This makes the code easier to follow, and makes it easier to catch
1709 integer overflow bugs such as Bug#8664.
1710 * frame.c (Fmouse_position, Fmouse_pixel_position):
1711 Use Time, not unsigned long, for user-interface timestamps.
1712 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1713 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1714 * keyboard.h (last_event_timestamp): Likewise.
1715 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1716 * menu.h (xmenu_show): Likewise.
1717 * term.c (term_mouse_position): Likewise.
1718 * termhooks.h (struct input_event.timestamp): Likewise.
1719 (struct terminal.mouse_position_hook): Likewise.
1720 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1721 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1722 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1723 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1724 what it was before.
1725 * menu.h, termhooks.h: Include "systime.h", for Time.
1726
8e55734a
PE
1727 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1728 Don't assume that the difference between two unsigned long values
1729 can fit into an integer. At this point, we know button_down_time
1730 <= event->timestamp, so the difference must be nonnegative, so
1731 there's no need to cast the result if double-click-time is
1732 nonnegative, as it should be; check that it's nonnegative, just in
1733 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1734 apart (about 25 days). (Bug#8664)
8e55734a 1735
841f1b75 1736 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1737 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1738
3e26f69c
PE
1739 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1740 that always fit in int. Use a sentinel instead of a counter, to
1741 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1742 * frame.h (struct frame): Use int for menu_bar_items_used
1743 instead of EMACS_INT, since it always fits in int.
3e26f69c 1744
5cc152c0
PE
1745 * menu.c (grow_menu_items): Check for int overflow.
1746
d89eb65e
PE
1747 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1748
5235bd3e
PE
1749 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1750 Before, the code was not consistent. These values cannot exceed
1751 2**31 - 1 so there's no need to make them unsigned.
1752 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1753 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1754 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1755 as modifiers.
1756 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1757
bc827e23
PE
1758 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1759 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1760 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1761 presumably because the widths might not match.
1762
78eb494e
PE
1763 * window.c (size_window): Avoid needless test at loop start.
1764
04f2d78b
CB
17652011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1766
1767 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1768
d2fc7e3d 17692011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1770
1771 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1772
d2fc7e3d 17732011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1774
1775 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1776 `width' to `bar_area_x' and `bar_area_width', respectively.
1777 (x_scroll_run): Take account of fringe background extension.
1778
04f2d78b
CB
1779 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1780 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1781 `bar_area_width', respectively.
1782 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1783 background extension.
1784
79b70037
GM
17852011-05-10 Jim Meyering <meyering@redhat.com>
1786
1787 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1788
2f142cc5
JB
17892011-05-10 Juanma Barranquero <lekktu@gmail.com>
1790
1791 * image.c (Finit_image_library): Return t for built-in image types,
1792 like pbm and xbm. (Bug#8640)
1793
57679c86
AS
17942011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1795
1796 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1797
888c9e86
EZ
17982011-05-07 Eli Zaretskii <eliz@gnu.org>
1799
b0512a1d
EZ
1800 * w32console.c (Fset_screen_color): Doc fix.
1801 (Fget_screen_color): New function.
1802 (syms_of_ntterm): Defsubr it.
1803
7285dc67
EZ
1804 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1805 unlink the temporary file if Fcall_process didn't create it in the
1806 first place.
1807 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1808 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1809 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1810 cue to call_process_cleanup not to close that handle.
1811
4d3fcc8e
BK
18122011-05-07 Ben Key <bkey76@gmail.com>
1813
1814 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1815 one of two shell specific rules, either bootstrap-temacs-CMD or
1816 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1817 to the previous implementation of the bootstrap-temacs rule.
1818 The bootstrap-temacs-CMD rule is similar to the previous
1819 implementation of the bootstrap-temacs rule except that it
1820 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1821 variable.
1822
1823 These changes, along with some changes to nt/configure.bat,
1824 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1825 earlier fix to add support for --cflags and --ldflags options
1826 that include quotes so that it works whether make uses cmd or
1827 sh as the shell.
1828
b4289b64
MA
18292011-05-06 Michael Albinus <michael.albinus@gmx.de>
1830
1831 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1832 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1833 is a constant.
1834 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1835 a string. Handle both cases.
1836 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1837 (Fdbus_register_method): Use Qinvalid_function.
1838
af4c0e28
JB
18392011-05-06 Juanma Barranquero <lekktu@gmail.com>
1840
1841 * makefile.w32-in: Update dependencies.
1842 (LISP_H): Add inttypes.h and stdin.h.
1843 (PROCESS_H): Add unistd.h.
1844
c51453d9
EZ
18452011-05-06 Eli Zaretskii <eliz@gnu.org>
1846
1847 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1848 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1849
8ff0ac3c 18502011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1851
4c4b566b
PE
1852 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1853
aab2b9b5
PE
1854 * term.c (vfatal): Remove stray call to va_end.
1855 It's not needed and the C Standard doesn't allow it here anyway.
1856
c378da0b
PE
1857 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1858 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1859
288b08c7
PE
1860 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1861 bytes.
1862
e3601888
PE
1863 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1864
db6c0e74
PE
1865 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1866
dd5963ea
PE
1867 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1868
88c9450f
PE
1869 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1870
2f9442b8
PE
1871 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1872
c032b5f8
PE
1873 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1874 * charset.c (Fdefine_charset_internal): Don't initialize
1875 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1876 32-bit int (Bug#8600).
a108c10b
PE
1877
1878 * lread.c (read_integer): Be more consistent with string-to-number.
1879 Use string_to_number to do the actual conversion; this avoids
1880 rounding errors and fixes some other screwups. Without this fix,
1881 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1882 (digit_to_number): Move earlier, for benefit of read_integer.
1883 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1884 not a digit in any supported base. (Bug#8602)
a108c10b 1885
ad5f9eea
PE
1886 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1887
aec1708a
PE
1888 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1889 to match comment at start of function. This also removes a
1890 GCC warning about overflow in a 32+64-bit port.
1891
47be4ab5
PE
1892 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1893
371cac43
PE
1894 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1895 Reported by Stefan Monnier in
1896 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1897 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1898 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1899
d01a7826
PE
1900 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1901 (EMACS_UINTPTR): Likewise, with uintptr_t.
1902
7fd47d5c
PE
1903 * lisp.h: Prefer 64-bit EMACS_INT if available.
1904 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1905 on 32-bit hosts that have 64-bit int, so that they can access
1906 large files.
122b0c86
PE
1907 However, temporarily disable this change unless the temporary
1908 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1909
8727937b
PE
1910 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1911
8ac068ac
PE
1912 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1913 This removes an assumption that EMACS_INT and long are the same
1914 width as pointers. The assumption is true for Emacs porting targets
1915 now, but we want to make other targets possible.
1916 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1917 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1918 In the rest of the code, change types of integers that hold casted
1919 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1920 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1921 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1922 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1923 No need to cast type when ORing.
1924 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1925 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1926 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1927 assume EMACS_INT is the same width as char *.
1928 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1929 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1930 Remove no-longer-needed casts.
1931 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1932 (xg_tool_bar_help_callback, xg_make_tool_item):
1933 Use EMACS_INTPTR to hold an integer
1934 that will be cast to void *; this can avoid a GCC warning
1935 if EMACS_INT is not the same width as void *.
1936 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1937 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1938 (current_message_1, set_message_1):
1939 Use a local to convert to proper width without a cast.
1940 * xmenu.c (dialog_selection_callback): Likewise.
1941
ede49d71
PE
1942 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1943 Also, don't assume VALBITS / RAND_BITS is less than 5,
1944 and don't rely on undefined behavior when shifting a 1 left into
1945 the sign bit.
1946 * lisp.h (get_random): Change signature to match.
1947
2f30ecd0
PE
1948 * lread.c (hash_string): Use size_t, not int, for hash computation.
1949 Normally we prefer signed values; but hashing is special, because
1950 it's better to use unsigned division on hash table sizes so that
1951 the remainder is nonnegative. Also, size_t is the natural width
1952 for hashing into memory. The previous code used 'int', which doesn't
1953 retain enough info to hash well into very large tables.
1954 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1955
2a866e7b
PE
1956 * dbusbind.c: Don't possibly lose pointer info when converting.
1957 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1958 Use XPNTR rather than XHASH, so that the high-order bits of
1959 the pointer aren't lost when converting through void *.
1960
51639eac
PE
1961 * eval.c (Fautoload): Don't double-shift a pointer.
1962
92394119
PE
1963 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1964
dbdb9a7c
JB
19652011-05-06 Juanma Barranquero <lekktu@gmail.com>
1966
1967 * gnutls.c (DEF_GNUTLS_FN):
1968 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1969
db7a0b4f
AS
19702011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1971
1972 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1973 marker. (Bug#8610)
1974
f7ff1b0f 19752011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1976
1977 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1978 New version that can reserve upto 2GB of heap space.
1979
f7ff1b0f 19802011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1981
1982 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1983
639c109b
TZ
19842011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1985
1986 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1987 `gnutls_certificate_set_x509_key_file'.
1988
d2127135
JB
19892011-05-05 Juanma Barranquero <lekktu@gmail.com>
1990
1991 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1992 Update dependencies.
1993
e968f4f3
JB
19942011-05-04 Juanma Barranquero <lekktu@gmail.com>
1995
1996 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1997 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1998 Remove unused parameter `fildes'.
1999 * process.c (read_process_output, send_process): Don't pass it.
2000
84d358f0
JB
20012011-05-04 Juanma Barranquero <lekktu@gmail.com>
2002
2003 Fix previous change: the library cache is defined in w32.c.
2004 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2005 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2006
0898ca10
JB
20072011-05-04 Juanma Barranquero <lekktu@gmail.com>
2008
2009 Implement dynamic loading of GnuTLS on Windows.
2010
2011 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2012 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2013 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2014 Declare.
2015
2016 * gnutls.c (Qgnutls_dll): Define.
2017 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2018 (gnutls_*): Declare function pointers.
2019 (init_gnutls_functions): New function to initialize function pointers.
2020 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2021 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2022 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2023 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2024 (emacs_gnutls_write, emacs_gnutls_read)
2025 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2026 (Fgnutls_available_p): New function.
2027 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2028 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2029 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2030
2031 * image.c: Include w32.h.
2032 (Vimage_type_cache): Delete.
2033 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2034 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2035 (w32_delayed_load): Move to w32.c.
2036
2037 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2038
2039 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2040 (w32_delayed_load): Move from image.c. When loading a library, record
2041 its filename in the :loaded-from property of the library id.
2042 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2043 Initialize and staticpro them.
2044 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2045
2046 * process.c: Include lisp.h before w32.h, not after.
2047 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2048 instead of gnutls_record_check_pending.
2049
2050 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2051
ff4de4aa
TZ
20522011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2053
2054 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2055 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2056 as passed in.
2057
abe95abb
JD
20582011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2059
2060 * xterm.c (x_set_frame_alpha): Do not set property on anything
2061 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2062
e16e55d4
JB
20632011-05-02 Juanma Barranquero <lekktu@gmail.com>
2064
2065 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2066
bafcf6a5
JB
20672011-05-02 Juanma Barranquero <lekktu@gmail.com>
2068
2069 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2070 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2071 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2072 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2073 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2074 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2075 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2076 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2077 (Qgnutls_bootprop_callbacks_verify): Make static.
2078
e7a6747f
AS
20792011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2080
19ed11ba
AS
2081 * callproc.c: Indentation fixup.
2082
e7a6747f 2083 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2084 (wait_for_termination, interruptible_wait_for_termination):
2085 Move after wait_for_termination_1.
e7a6747f 2086
1ef14cb4
LMI
20872011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2088
2089 * sysdep.c (interruptible_wait_for_termination): New function
2090 which is like wait_for_termination, but allows keyboard
2091 interruptions.
2092
2093 * callproc.c (Fcall_process): Add (:file "file") as an option for
2094 the STDOUT buffer.
2095 (Fcall_process_region): Ditto.
2096
330d880c
EZ
20972011-04-30 Eli Zaretskii <eliz@gnu.org>
2098
8db90b73
EZ
2099 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2100 rather than `XVECTOR (FOO)->size'.
2101
330d880c
EZ
2102 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2103 inttypes.h, as a gnulib replacement is used if it not available in
2104 system headers.
2105
15cbd324
EZ
21062011-04-21 Eli Zaretskii <eliz@gnu.org>
2107
2108 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2109 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2110 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2111
2112 * coding.c (coding_alloc_by_realloc): Error out if destination
2113 will grow beyond MOST_POSITIVE_FIXNUM.
2114 (decode_coding_emacs_mule): Abort if there isn't enough place in
2115 charbuf for the composition carryover bytes. Reserve an extra
2116 space for up to 2 characters produced in a loop.
2117 (decode_coding_iso_2022): Abort if there isn't enough place in
2118 charbuf for the composition carryover bytes.
2119
21202011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2121
ae940cca
EZ
2122 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2123 aborting when %lld or %lll format is passed.
2124 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2125 %llo or %llx format is passed. (Bug#8545)
2126
03ab8921
EZ
2127 * window.c (window_scroll_line_based): Use a marker instead of
2128 simple variables to record original value of point. (Bug#7952)
2129
afda1437
EZ
2130 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2131 produced by %s or %c overflows available buffer space. (Bug#8545)
2132
f76dee0c
PE
21332011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2134
2135 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2136 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2137
fdc5744d
JB
21382011-04-28 Juanma Barranquero <lekktu@gmail.com>
2139
2140 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2141
638f053a
JB
21422011-04-28 Juanma Barranquero <lekktu@gmail.com>
2143
2144 * keyboard.c (Qdelayed_warnings_hook): Define.
2145 (command_loop_1): Run `delayed-warnings-hook'
2146 if Vdelayed_warnings_list is non-nil.
2147 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2148 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2149
d178f871
EZ
21502011-04-28 Eli Zaretskii <eliz@gnu.org>
2151
2152 * doprnt.c (doprnt): Don't return value smaller than the buffer
2153 size if the message was truncated. (Bug#8545).
2154
b124fd93
JB
21552011-04-28 Juanma Barranquero <lekktu@gmail.com>
2156
2157 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2158 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2159
e810457d
PE
21602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2161
2162 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2163
ea51cceb
JB
21642011-04-27 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * makefile.w32-in: Update dependencies.
2167
94dcfacf
EZ
21682011-04-27 Eli Zaretskii <eliz@gnu.org>
2169
2170 Improve `doprnt' and its usage. (Bug#8545)
2171 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2172 `format_end'. Remove support for %l as a conversion specifier.
2173 Don't use xrealloc. Improve diagnostics when the %l size modifier
2174 is used. Update the commentary.
2175
2176 * eval.c (verror): Simplify calculation of size_t.
2177
2178 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2179 messages.
2180
f61f41d7
PE
21812011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2182
2183 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2184 change.
2185
96fb4434
PE
21862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2189 This makes this file independent of the recent pseudovector change.
2190
671875da 21912011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2192
69e9b5a3
PE
2193 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2194
b5f869a7 2195 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2196 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2197 Remove unused local.
c8926152 2198 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2199
841a1577 2200 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2201 GCC 4.6.0 optimizes based on type-based alias analysis.
2202 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2203 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2204 != &v->size, and therefore "v->size = 1; b->size = 2; return
2205 v->size;" must therefore return 1. This assumption is incorrect
2206 for Emacs, since it type-puns struct Lisp_Vector * with many other
2207 types. To fix this problem, this patch adds a new type struct
f904488f 2208 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2209 and pseudovectors, and helps optimizing compilers not get fooled
2210 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2211 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2212 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2213 the size member.
eab3844f
PE
2214 (XSETPVECTYPE): Rewrite in terms of new macro.
2215 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2216 This is a bit clearer, and further avoids the possibility of
2217 undesirable aliasing.
2218 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2219 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2220 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2221 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2222 (ASIZE): Now uses header.size rather than size.
2223 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2224 to avoid the hassle of writing XVECTOR (foo)->header.size.
2225 (struct vectorlike_header): New type.
eab3844f
PE
2226 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2227 object, to help avoid aliasing.
2228 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2229 (SUBRP): Likewise, since Lisp_Subr is a special case.
2230 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2231 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2232 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2233 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2234 changed to be "header.size" and "header.next".
2235 * buffer.h (struct buffer): Likewise.
2236 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2237 * frame.h (struct frame): Likewise.
2238 * process.h (struct Lisp_Process): Likewise.
2239 * termhooks.h (struct terminal): Likewise.
2240 * window.c (struct save_window_data, struct saved_window): Likewise.
2241 * window.h (struct window): Likewise.
2242 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2243 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2244 * buffer.c (init_buffer_once): Likewise.
2245 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2246 special case.
2247 * process.c (Fformat_network_address): Use local var for size,
2248 for brevity.
2249
0df1eac5
PE
2250 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2251
847ab9d1 2252 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2253 * data.c (atof): Remove decl; no longer used or needed.
2254 (digit_to_number): Move to lread.c.
2255 (Fstring_to_number): Use new string_to_number function, to be
2256 consistent with how the Lisp reader treats infinities and NaNs.
2257 Do not assume that floating-point numbers represent EMACS_INT
2258 without losing information; this is not true on most 64-bit hosts.
2259 Avoid double-rounding errors, by insisting on integers when
2260 parsing non-base-10 numbers, as the documentation specifies.
2261 * lisp.h (string_to_number): New decl, replacing ...
2262 (isfloat_string): Remove.
bc0a5c13 2263 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2264 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2265 appears to have been a coding error. Similarly, do not accept
2266 strings like +-1e0 as floating point numbers. Do not report
2267 overflow for integer overflows unless the base is not 10 which
2268 means we have no simple and reliable way to continue.
2269 Break out the floating-point parsing into a new
2270 function string_to_number, so that Fstring_to_number parses
2271 floating point numbers consistently with the Lisp reader.
04f2d78b 2272 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2273 (E_CHAR, EXP_INT): Remove, replacing with ...
2274 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2275 (string_to_number): New function, replacing isfloat_string.
2276 This function checks for valid syntax and produces the resulting
2277 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2278 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2279 so that overflow for non-base-10 numbers is reported only when
2280 there's no portable and simple way to convert to floating point.
452f4150 2281
67769ffc
PE
2282 * textprop.c (set_text_properties_1): Rewrite for clarity,
2283 and to avoid GCC warning about integer overflow.
2284
c20db43f
PE
2285 * intervals.h (struct interval): Use EMACS_INT for members
2286 where EMACS_UINT might cause problems. See
2287 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2288 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2289 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2290 All uses changed.
37aa2f85
PE
2291 (offset_intervals): Tell GCC not to worry about length overflow
2292 when negating a negative length.
c20db43f 2293
2538aa2f
PE
2294 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2295 (overrun_check_free): Likewise.
2296
f2d3008d
PE
2297 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2298 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2299 word size.
2300
ec8df744
PE
2301 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2302 (gnutls_make_error): Rename local to avoid shadowing.
2303 (gnutls_emacs_global_deinit): ifdef out; not used.
2304 (Fgnutls_boot): Use const for pointer to readonly storage.
2305 Comment out unused local. Fix pointer signedness problems.
2306
640ee02d
PE
2307 * lread.c (openp): Don't stuff size_t into an 'int'.
2308 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2309 about possible signed overflow.
2310
6048fb2a
PE
2311 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2312 (GDK_KEY_g): Don't define if already defined.
2313 (xg_prepare_tooltip): Avoid pointer signedness problem.
2314 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2315
fa3c87e1
PE
2316 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2317 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2318
2172544b
PE
2319 * xfns.c (Fx_window_property): Simplify a bit,
2320 to make a bit faster and to avoid GCC 4.6.0 warning.
2321 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2322
9b821a21
PE
2323 * fns.c (internal_equal): Don't assume size_t fits in int.
2324
3c616cfa
PE
2325 * alloc.c (compact_small_strings): Tighten assertion a little.
2326
c2982e87
PE
2327 Replace pEd with more-general pI, and fix some printf arg casts.
2328 * lisp.h (pI): New macro, generalizing old pEd macro to other
2329 conversion specifiers. For example, use "...%"pI"d..." rather
2330 than "...%"pEd"...".
2331 (pEd): Remove. All uses replaced with similar uses of pI.
2332 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2333 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2334 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2335 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2336 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2337 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2338 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2339 64-bit hosts.
2340 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2341 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2342 * print.c (safe_debug_print, print_object): Likewise.
2343 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2344 to int.
6f04d126
PE
2345 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2346 avoiding the 0 flag, which is not portable.
c2982e87
PE
2347 * process.c (Fmake_network_process): Use pI to avoid cast.
2348 * region-cache.c (pp_cache): Likewise.
2349 * xdisp.c (decode_mode_spec): Likewise.
2350 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2351 behavior on 64-bit hosts with printf arg.
6f04d126 2352 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2353 (x_stop_queuing_selection_requests): Likewise.
2354 (x_get_window_property): Don't truncate byte count to an 'int'
2355 when tracing.
0b432f21 2356
5e073ec7
PE
2357 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2358 here, since it parses constructs like leading '-' and spaces,
2359 which are not wanted; and it overflows with large numbers.
2360 Instead, simply match F[0-9]+, which is what is wanted anyway.
2361
36372bf9
PE
2362 * alloc.c: Remove unportable assumptions about struct layout.
2363 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2364 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2365 (allocate_vectorlike, make_pure_vector): Use the new macros,
2366 plus offsetof, to remove unportable assumptions about struct layout.
2367 These assumptions hold on all porting targets that I know of, but
2368 they are not guaranteed, they're easy to remove, and removing them
2369 makes further changes easier.
2370
0b432f21
PE
2371 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2372 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2373 (string_overrun_cookie): Now const. Use initializers that
2374 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2375 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2376 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2377 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2378 multiple of sizeof (EMACS_INT); it need not be, if
2379 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2380 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2381
895009e1
JB
23822011-04-26 Juanma Barranquero <lekktu@gmail.com>
2383
2384 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2385
6a7a1b0b
TZ
23862011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2387
2388 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2389 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2390 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2391
841a1577 23922011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2393
2394 * lisp.h (Qdebug): List symbol.
895009e1 2395 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2396 * keyboard.c (debug-on-event): New variable.
2397 (handle_user_signal): Break into debugger when debug-on-event
2398 matches the current signal symbol.
2399
f2d3ba6f
DN
24002011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2401
2402 * alloc.c (check_sblock, check_string_bytes)
2403 (check_string_free_list): Convert to standard C.
2404
42ce4c63
TZ
24052011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2406
2407 * w32.c (emacs_gnutls_push): Fix typo.
2408
825cd63c
EZ
24092011-04-25 Eli Zaretskii <eliz@gnu.org>
2410
fb11d64d
EZ
2411 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2412 "cast to pointer from integer of different size".
2413
825cd63c
EZ
2414 Improve doprnt and its use in verror. (Bug#8545)
2415 * doprnt.c (doprnt): Document the set of format control sequences
2416 supported by the function. Use SAFE_ALLOCA instead of always
2417 using `alloca'.
2418
2419 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2420 is one byte too soon. Don't use xrealloc; instead xfree and
2421 xmalloc anew.
2422
e061a11b
TZ
24232011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2424
2425 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2426 callbacks stage.
2427
2428 * gnutls.c: Renamed global_initialized to
2429 gnutls_global_initialized. Added internals for the
2430 :verify-hostname-error, :verify-error, and :verify-flags
2431 parameters of `gnutls-boot' and documented those parameters in the
2432 docstring. Start callback support.
2433 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2434 unless a fatal error occured. Call gnutls_alert_send_appropriate
2435 on error. Return error code.
2436 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2437 (emacs_gnutls_read): Likewise.
2438 (Fgnutls_boot): Return handshake error code.
2439 (emacs_gnutls_handle_error): New function.
2440 (wsaerror_to_errno): Likewise.
2441
2442 * w32.h (emacs_gnutls_pull): Add prototype.
2443 (emacs_gnutls_push): Likewise.
2444
2445 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2446 (emacs_gnutls_push): Likewise.
2447
24482011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2449
2450 * process.c (wait_reading_process_output): Check if GnuTLS
2451 buffered some data internally if no FDs are set for TLS
2452 connections.
2453
2454 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2455 (LIBS): Link to USER_LIBS.
2456 ($(BLD)/gnutls.$(0)): New target.
2457
fa6996bc
EZ
24582011-04-24 Eli Zaretskii <eliz@gnu.org>
2459
eb35682e
EZ
2460 * xdisp.c (handle_single_display_spec): Rename the
2461 display_replaced_before_p argument into display_replaced_p, to
2462 make it consistent with the commentary. Fix typos in the
2463 commentary.
2464
e2ad650c
EZ
2465 * textprop.c (syms_of_textprop): Remove dead code.
2466 (copy_text_properties): Delete obsolete commentary about an
2467 interface that was deleted long ago. Fix typos in the description
2468 of arguments.
2469
1b2de274
EZ
2470 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2471 to changes in oldXMenu/XMenu.h from 2011-04-16.
2472 <menu_help_message, prev_menu_help_message>: Constify.
2473 (IT_menu_make_room): menu->help_text is now `const char **';
2474 adjust.
2475
2476 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2477 to changes in oldXMenu/XMenu.h from 2011-04-16.
2478 (struct XMenu): Declare `help_text' `const char **'.
2479
2480 * xfaces.c <Qunspecified>: Make extern again.
2481
2482 * syntax.c: Include sys/types.h before including regex.h, as
2483 required by Posix.
2484
762b15be
EZ
2485 * doc.c (get_doc_string): Improve the format passed to `error'.
2486
2487 * doprnt.c (doprnt): Improve commentary.
2488
2489 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2490
2491 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2492 them with etags.
2493
f1052e5d
EZ
2494 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2495 changes in globals.h immediately force recompilation.
762b15be
EZ
2496 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2497 $(CURDIR)/s/ms-w32.h.
2498 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2499
fa6996bc
EZ
2500 * character.c (Fchar_direction): Function deleted.
2501 (syms_of_character): Don't defsubr it.
2502 <char-direction-table>: Deleted.
2503
e6c3da20
EZ
25042011-04-23 Eli Zaretskii <eliz@gnu.org>
2505
2506 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2507 * doprnt.c: Include limits.h.
2508 (SIZE_MAX): New macro.
04f2d78b
CB
2509 (doprnt): Return a size_t value. 2nd arg is now size_t.
2510 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2511 Improve overflow protection. Support `l' modifier for integer
2512 conversions. Support %l conversion. Don't assume an EMACS_INT
2513 argument for integer conversions and for %c.
2514
2515 * lisp.h (doprnt): Restore prototype.
2516
2517 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2518 $(SRC)/character.h.
2519
2520 * Makefile.in (base_obj): Add back doprnt.o.
2521
2522 * deps.mk (doprnt.o): Add back prerequisites.
2523 (callint.o): Depend on character.h.
2524
2525 * eval.c (internal_lisp_condition_case): Include the handler
2526 representation in the error message.
2527 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2528 when breaking from the loop.
2529
2530 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2531
2532 * callint.c (Fcall_interactively): When displaying error message
2533 about invalid control letter, pass the character's codepoint, not
2534 a pointer to its multibyte form. Improve display of the character
2535 in octal and display also its hex code.
2536
2537 * character.c (char_string): Use %x to display the (unsigned)
2538 codepoint of an invalid character, to avoid displaying a bogus
2539 negative value.
2540
2541 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2542 `error', not SYMBOL_NAME itself.
2543
2544 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2545 character arguments to `error'.
2546
2547 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2548 to `error' in error message about FINAL_CHAR argument. Make sure
2549 FINAL_CHAR is a character, and use %c when it is passed as
2550 argument to `error'.
2551
4ffd0d6b 25522011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2553
2554 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2555
2556 * w32.c: Include <time.h>.
2557 (sys_localtime): New function.
2558
4ffd0d6b 25592011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2560
2561 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2562
4ffd0d6b 2563 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2564
4ffd0d6b 25652011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2566
4ffd0d6b
GM
2567 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2568 zombies (Bug#8467).
aac0c6e3 2569
04c56954
EZ
25702011-04-19 Eli Zaretskii <eliz@gnu.org>
2571
2572 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2573 gl_state.e_property when gl_state.object is Qt.
2574
2575 * insdel.c (make_gap_larger): Remove limitation of buffer size
2576 to <= INT_MAX.
2577
16a43933
CY
25782011-04-18 Chong Yidong <cyd@stupidchicken.com>
2579
2580 * xdisp.c (lookup_glyphless_char_display)
2581 (produce_glyphless_glyph): Handle cons cell entry in
2582 glyphless-char-display.
2583 (Vglyphless_char_display): Document it.
2584
2585 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2586 glyphless-char-display.
2587
4581706e
CY
25882011-04-17 Chong Yidong <cyd@stupidchicken.com>
2589
2590 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2591
2592 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2593
2594 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2595 definition for no-X builds.
2596
4887c6e2 25972011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2598
fd35b6f9
PE
2599 Static checks with GCC 4.6.0 and non-default toolkits.
2600
5c1ccb01
PE
2601 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2602
006c5daa
PE
2603 * process.c (keyboard_bit_set): Define only if SIGIO.
2604 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2605 (send_process): Repair possible setjmp clobbering.
2606
efc736d3
PE
2607 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2608
4e2fe2e6
PE
2609 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2610
f97334a2
PE
2611 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2612
4e75f29d
PE
2613 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2614 Define only if needed.
2615
90efadd1
PE
2616 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2617 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2618 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2619
3c647824
PE
2620 * dispextern.h (struct redisplay_interface): Rename param
2621 to avoid shadowing.
e264f262 2622 * termhooks.h (struct terminal): Likewise.
761383f4 2623 * xterm.c (xembed_send_message): Likewise.
3c647824 2624
b58c5c4a
PE
2625 * insdel.c (make_gap_smaller): Define only if
2626 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2627
cad59032
PE
2628 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2629 it.
2630
c339dc2e
PE
2631 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2632 so that we aren't warned about unused symbols.
2633
91a3e27b
PE
2634 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2635
399c71d3 2636 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2637
8ffc96f5
PE
2638 * xfns.c (x_real_positions): Mark locals as initialized.
2639
eef9bc79
PE
2640 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2641
098db9dd
PE
2642 * xterm.c: Fix problems found by static analysis with other toolkits.
2643 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2644 (x_dispatch_event): Declare static if USE_GTK, and
2645 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2646 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2647 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2648 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2649 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2650
eb18f6cc
PE
2651 * xmenu.c (menu_help_callback): Pointer type fixes.
2652 Use const pointers when pointing at readonly data. Avoid pointer
2653 signedness clashes.
2654 (FALSE): Remove unused macro.
2655 (update_frame_menubar): Remove unused decl.
2656
1fe72bf8
PE
2657 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2658
60d9e1db
PE
2659 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2660 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2661 (single_menu_item): Rename local to avoid shadowing.
2662
39261c26
PE
2663 * keyboard.c (make_lispy_event): Remove unused local var.
2664
018c5e19
PE
2665 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2666 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2667
63d2b86e
PE
2668 * bitmaps: Change bitmaps from unsigned char back to the X11
2669 compatible char. Avoid the old compiler warnings about
2670 out-of-range initializers by using, for example, '\xab' rather
2671 than 0xab.
2672
aefd87e1
PE
2673 * xgselect.c (xgselect_initialize): Check vs interface
2674 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2675
bf501fb9
PE
2676 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2677
e9829fdf
PE
2678 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2679 to read-only memory.
2680
1086c095
PE
2681 * fns.c (vector): Remove; this old hack is no longer needed.
2682
2baccd04 2683 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2684 Remove unused var.
dde42981 2685 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2686
72391843 2687 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2688
436c16df 2689 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2690 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2691 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2692
92bb796d 2693 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2694 (x_term_init): Remove local to avoid shadowing.
92bb796d 2695
764430a3 2696 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2697
2698 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2699 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2700
d1dfb56c
EZ
27012011-04-16 Eli Zaretskii <eliz@gnu.org>
2702
c4354cb4
EZ
2703 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2704
d1dfb56c
EZ
2705 Fix regex.c, syntax.c and friends for buffers > 2GB.
2706 * syntax.h (struct gl_state_s): Declare character position members
2707 EMACS_INT.
2708
2709 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2710
04f2d78b
CB
2711 * textprop.c (verify_interval_modification, interval_of):
2712 Declare arguments EMACS_INT.
d1dfb56c
EZ
2713
2714 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2715 EMACS_INT.
2716
2717 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2718
2719 * indent.c (Fvertical_motion): Local variable it_start is now
2720 EMACS_INT.
2721
2722 * regex.c (re_match, re_match_2, re_match_2_internal)
2723 (bcmp_translate, regcomp, regexec, print_double_string)
2724 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2725 (re_compile_pattern, re_exec): Declare arguments and local
2726 variables `size_t' and `ssize_t' and return values `regoff_t', as
2727 appropriate.
2728 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2729 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2730 <compile_stack_type>: `size' and `avail' are now `size_t'.
2731
2732 * regex.h <regoff_t>: Use ssize_t, not int.
2733 (re_search, re_search_2, re_match, re_match_2): Arguments that
2734 specify buffer/string position and length are now ssize_t and
2735 size_t. Return type is regoff_t.
2736
613052cd
BK
27372011-04-16 Ben Key <bkey76@gmail.com>
2738
2739 * nsfont.m: Fixed bugs in ns_get_family and
2740 ns_descriptor_to_entity that were caused by using free to
2741 deallocate memory blocks that were allocated by xmalloc (via
2742 xstrdup). This caused Emacs to crash when compiled with
2743 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2744 --enable-checking=xmallocoverrun). xfree is now used to
2745 deallocate these memory blocks.
2746
4170f62f 27472011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2748
71b41406
PE
2749 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2750
9587a89d
PE
2751 emacs_write: Accept and return EMACS_INT for sizes.
2752 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2753 et seq.
2754 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2755 Accept and return EMACS_INT.
2756 (emacs_gnutls_write): Return the number of bytes written on
2757 partial writes.
2758 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2759 (emacs_read, emacs_write): Remove check for negative size, as the
2760 Emacs source code has been audited now.
9587a89d
PE
2761 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2762 (emacs_read, emacs_write): Use it.
273a5f82
PE
2763 * process.c (send_process): Adjust to the new signatures of
2764 emacs_write and emacs_gnutls_write. Do not attempt to store
2765 a byte offset into an 'int'; it might overflow.
9587a89d 2766 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2767
3e047f51
PE
2768 * sound.c: Don't assume sizes fit in 'int'.
2769 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2770 Return EMACS_INT, not int.
3e047f51 2771 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2772 Accept EMACS_INT, not int.
2773 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2774 record read return values.
2775
cc39a9db
BK
27762011-04-15 Ben Key <bkey76@gmail.com>
2777
c9d0ec6d
JB
2778 * keyboard.c (Qundefined): Don't declare static since it is used
2779 in nsfns.m.
2780 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2781 static since they are used in nsfont.m.
cc39a9db 2782
6c60eb9f
SM
27832011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2784
2785 * process.c (Qprocessp): Don't declare static.
2786 * lisp.h (Qprocessp): Declare again.
2787
7990b61a
JB
27882011-04-15 Juanma Barranquero <lekktu@gmail.com>
2789
2790 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2791
5d4cb038
PE
27922011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2793
8bd7b830 2794 Improve C-level modularity by making more things 'static'.
cd64ea1d 2795
e3b27b31
PE
2796 Don't publish debugger-only interfaces to other modules.
2797 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2798 (verify_bytepos, count_markers): Move decls to the only modules
2799 that need them.
2800 * region-cache.h (pp_cache): Likewise.
2801 * window.h (check_all_windows): Likewise.
2802 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2803
5d4cb038
PE
2804 * sysdep.c (croak): Now static, if
2805 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2806 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2807
2808 * alloc.c (refill_memory_reserve): Now static if
2809 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2810 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2811
e87b6180
PE
2812 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2813 Define only if USE_LUCID.
2814
ac64929e
PE
2815 * xrdb.c (x_customization_string, x_rm_string): Now static.
2816
6f37259d
PE
2817 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2818 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2819
1683e3ab
PE
2820 * xdisp.c (draw_row_with_mouse_face): Now static.
2821 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2822
de9c2632
PE
2823 * window.h (check_all_windows): Mark externally visible.
2824
2b96acb7
PE
2825 * window.c (window_deletion_count): Now static.
2826
2827 * undo.c: Make symbols static if they're not exported.
2828 (last_undo_buffer, last_boundary_position, pending_boundary):
2829 Now static.
2830
50436f33
PE
2831 * textprop.c (interval_insert_behind_hooks): Now static.
2832 (interval_insert_in_front_hooks): Likewise.
2833
64520e5c
PE
2834 * term.c: Make symbols static if they're not exported.
2835 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2836 (max_frame_lines, tty_set_terminal_modes):
2837 (tty_reset_terminal_modes, tty_turn_off_highlight):
2838 (get_tty_terminal): Now static.
2839 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2840 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2841 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2842 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2843 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2844
1fa53021
PE
2845 * sysdep.c: Make symbols static if they're not exported.
2846 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2847 Now static.
2848 (sigprocmask_set, full_mask): Remove; unused.
2849 (wait_debugging): Mark as visible.
2850 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2851 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2852
d4b43b22
PE
2853 * syntax.c (syntax_temp): Define only if !__GNUC__.
2854
b7c513d0
PE
2855 * sound.c (current_sound_device, current_sound): Now static.
2856
989b29ad
PE
2857 * search.c (searchbufs, searchbuf_head): Now static.
2858
13a55a78
PE
2859 * scroll.c (scroll_cost): Remove; unused.
2860 * dispextern.h (scroll_cost): Remove decl.
2861
de68a1fc
PE
2862 * region-cache.h (pp_cache): Mark as externally visible.
2863
40ccffa6
PE
2864 * process.c: Make symbols static if they're not exported.
2865 (process_tick, update_tick, create_process, chan_process):
2866 (Vprocess_alist, proc_buffered_char, datagram_access):
2867 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2868 (deactivate_process): Mark defn as static, as well as decl.
2869 * lisp.h (create_process): Remove decl.
2870 * process.h (chan_process, Vprocess_alist): Remove decls.
2871
ad64fc97
PE
2872 * print.c: Make symbols static if they're not exported.
2873 (print_depth, new_backquote_output, being_printed, print_buffer):
2874 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2875 (print_interval, print_number_index, initial_stderr_stream):
2876 Now static.
2877 * lisp.h (Fprinc): Remove decl.
2878 (debug_output_compilation_hack): Mark as externally visible.
2879
adddb265
PE
2880 * sysdep.c (croak): Move decl from here to syssignal.h.
2881 * syssignal.h (croak): Put it here, so the API can be checked when
2882 'croak' is called from dissociate_if_controlling_tty.
2883
1717ede2
PE
2884 * minibuf.c: Make symbols static if they're not exported.
2885 (minibuf_save_list, choose_minibuf_frame): Now static.
2886 * lisp.h (choose_minibuf_frame): Remove decl.
2887
fa5fb2bc
PE
2888 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2889
1e3890d1
PE
2890 * lread.c: Make symbols static if they're not exported.
2891 (read_objects, initial_obarray, oblookup_last_bucket_number):
2892 Now static.
2893 (make_symbol): Remove; unused.
2894 * lisp.h (initial_obarray, make_symbol): Remove decls.
2895
8a1414fa
PE
2896 * keyboard.c: Make symbols static if they're not exported.
2897 (single_kboard, recent_keys_index, total_keys, recent_keys):
2898 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2899 (this_single_command_key_start, echoing, last_auto_save):
2900 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2901 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2902 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2903 (Vlispy_mouse_stem, double_click_count):
2904 Now static.
2905 (force_auto_save_soon): Define only if SIGDANGER.
2906 (ignore_mouse_drag_p): Now static if
2907 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2908 (print_help): Remove; unused.
2909 (stop_character, last_timer_event): Mark as externally visible.
2910 * keyboard.h (ignore_mouse_drag_p): Declare only if
2911 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2912 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2913 * lisp.h (echoing): Remove decl.
2914 (force_auto_save_soon): Declare only if SIGDANGER.
2915 * xdisp.c (redisplay_window): Simplify code, to make it more
2916 obvious that ignore_mouse_drag_p is not accessed if !defined
2917 USE_GTK && !defined HAVE_NS.
2918
93ea6e8f
PE
2919 * intervals.c: Make symbols static if they're not exported.
2920 (merge_properties_sticky, merge_interval_right, delete_interval):
2921 Now static.
2922 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2923
77382fcc
PE
2924 * insdel.c: Make symbols static if they're not exported.
2925 However, leave prepare_to_modify_buffer alone. It's never
2926 called from outside this function, but that appears to be a bug.
2927 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2928 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2929 (adjust_after_replace_noundo): Remove; unused.
2930 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2931 (signal_before_change): Remove decls.
77382fcc 2932
9306c32e
PE
2933 * indent.c (val_compute_motion, val_vmotion): Now static.
2934
cd44d2eb
PE
2935 * image.c: Make symbols static if they're not exported.
2936 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2937 if USE_GTK.
2938 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2939 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2940
ad9a7a06
PE
2941 * fringe.c (standard_bitmaps): Now static.
2942 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2943
81626931
PE
2944 * frame.c: Make symbols static if they're not exported.
2945 (x_report_frame_params, make_terminal_frame): Now static.
2946 (get_frame_param): Now static, unless HAVE_NS.
2947 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2948 (x_get_resource_string): Remove; not used.
2949 * frame.h (make_terminal_frame, x_report_frame_params):
2950 (x_get_resource_string); Remove decls.
2951 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2952 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2953
239f9db9
PE
2954 * font.c, fontset.c: Make symbols static if they're not exported.
2955 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2956 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2957 * font.c (font_close_object): Now static.
2958 * font.h (font_close_object): Remove.
2959 * fontset.c (FONTSET_OBJLIST): Remove.
2960 (free_realized_fontset) #if-0 the body, which does nothing.
2961 (face_suitable_for_char_p): #if-0, as it's never called.
2962 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2963 * xfaces.c (face_at_string_position):
2964 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2965 since 0 is always ASCII.
2966
dfcf3579
PE
2967 * fns.c (weak_hash_tables): Now static.
2968
5045092b
PE
2969 * fileio.c: Make symbols static if they're not exported.
2970 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2971 (Vwrite_region_annotation_buffers): Now static.
2972
57a96f5c
PE
2973 * eval.c: Make symbols static if they're not exported.
2974 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2975 * lisp.h (backtrace_list): Remove decl.
2976
35f08c38
PE
2977 * emacs.c: Make symbols static if they're not exported.
2978 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2979 (fatal_error_code, fatal_error_signal_hook, standard_args):
2980 Now static.
2981 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2982 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2983 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2984 * lisp.h (fatal_error_signal_hook): Remove decl.
2985 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2986
f44bd759
PE
2987 * editfns.c: Move a (normally-unused) function to its only use.
2988 * editfns.c, lisp.h (get_operating_system_release): Remove.
2989 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2990 worth the hassle of breaking this out.
2991
b532497d
PE
2992 * xterm.c: Make symbols static if they're not exported.
2993 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2994 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2995 (x_destroy_window, x_delete_display):
2996 Now static.
2997 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2998 (x_mouse_leave): Remove; unused.
2999 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3000 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3001 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3002 Remove decls.
3003 (x_mouse_leave): Declare only if WINDOWSNT.
3004 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3005 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3006 USE_X_TOOLKIT.
3007
1675728f
PE
3008 * ftxfont.c: Make symbols static if they're not exported.
3009 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3010 HAVE_FREETYPE.
3011 * font.h (ftxfont_driver): Likewise.
3012
e4cebfca
PE
3013 * xfns.c: Make symbols static if they're not exported.
3014 (x_last_font_name, x_display_info_for_name):
3015 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3016 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3017 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3018 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3019 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3020 (last_show_tip_args): Now static.
3021 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3022 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3023 (x_screen_planes): Remove; unused.
3024 * dispextern.h (x_screen_planes): Remove decl.
3025
5bf46f05
PE
3026 * dispnew.c: Make symbols static if they're not exported.
3027 * dispextern.h (redraw_garbaged_frames, scrolling):
3028 (increment_row_positions): Remove.
3029 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3030 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3031 Now static.
3032 (redraw_garbaged_frames): Remove; unused.
3033
435f4c28
PE
3034 * xfaces.c: Make symbols static if they're not exported.
3035 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3036 Remove decls.
3037 * xterm.h (defined_color): Remove decls.
3038 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3039 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3040 (menu_face_changed_default, defined_color, free_realized_face):
3041 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3042 (ascii_face_of_lisp_face): Remove; unused.
3043
8524aef3
PE
3044 * xdisp.c: Make symbols static if they're not exported.
3045 * dispextern.h (scratch_glyph_row, window_box_edges):
3046 (glyph_to_pixel_coords, set_cursor_from_row):
3047 (get_next_display_element, set_iterator_to_next):
3048 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3049 (show_mouse_face): Remove decls
3050 * frame.h (message_buf_print): Likewise.
3051 * lisp.h (pop_message, set_message, check_point_in_composition):
3052 Likewise.
3053 * xterm.h (set_vertical_scroll_bar): Likewise.
3054 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3055 (message_buf_print, scratch_glyph_row, displayed_buffer):
3056 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3057 (get_next_display_element, show_mouse_face, window_box_edges):
3058 (frame_to_window_pixel_xy, check_point_in_composition):
3059 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3060 (glyph_to_pixel_coords): Remove; unused.
3061
16390cd2
PE
3062 * dired.c (file_name_completion): Now static.
3063
3064 * dbusbind.c (xd_in_read_queued_messages): Now static.
3065
a25f4dfa
PE
3066 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3067 * data.c (circular_list_error): Remove.
3068
14a9c8df
PE
3069 * commands.h (last_point_position, last_point_position_buffer):
3070 (last_point_position_window): Remove decls.
3071 * keyboard.c: Make these variables static.
3072
04f2d78b
CB
3073 * coding.h (coding, code_convert_region, encode_coding_gap):
3074 Remove decls.
74ab6df5
PE
3075 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3076 (iso_code_class, detect_coding, code_convert_region): Now static.
3077 (encode_coding_gap): Remove; unused.
3078
38dfbee1
PE
3079 * chartab.c (chartab_chars, chartab_bits): Now static.
3080
a2cb4e63
PE
3081 * charset.h (charset_iso_8859_1): Remove decl.
3082 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3083 Now static.
3084
127198fd
PE
3085 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3086 * ccl.c (Vccl_program_table): Now static.
3087 (check_ccl_update): Remove; unused.
3088
d85b608f
PE
3089 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3090 * category.h: ... from here.
3091 * category.c (check_category_table, set_category_set): Now static.
3092
31cd66f3
PE
3093 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3094 * lisp.h: Remove these decls.
3095
c358e587
PE
3096 * buffer.c (buffer_count): Remove unused var.
3097
e78aecca
PE
3098 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3099 so that it's not optimized away.
3100 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3101 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3102 exported only to the debugger.
3103
e192d7d3 3104 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3105 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3106
92470028
PE
3107 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3108 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3109 was inaccessible from Lisp.
3110 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3111 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3112
244ed907
PE
3113 alloc.c: Import and export fewer symbols, and remove unused items.
3114 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3115 is defined.
3116 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3117 it's not optimized away by whole-program optimization.
3118 (message_enable_multibyte, free_misc): Remove.
3119 (catchlist, handlerlist, mark_backtrace):
3120 Declare only if BYTE_MARK_STACK.
3121 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3122 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3123 (message_enable_multibyte): Remove decl.
3124 (free_misc, interval_free_list, float_block, float_block_index):
3125 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3126 (cons_free_list, last_marked_index):
3127 Now static.
3128 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3129 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3130 (mark_backtrace): Define only if BYTE_MARK_STACK.
3131 * xdisp.c (message_enable_multibyte): Now static.
3132
61c2b50e 3133 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3134 This makes it easier for human readers (and static analyzers)
3135 to see whether these variables are used from other modules.
3136 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3137 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3138 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3139 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3140 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3141 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3142 * xmenu.c, xselect.c:
3143 Declare Q* vars static if they are not used in other modules.
3144 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3145 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3146 Remove decls of unexported vars.
3147 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3148
95c82688
PE
3149 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3150
16a97296
PE
3151 Make Emacs functions such as Fatom 'static' by default.
3152 This makes it easier for human readers (and static analyzers)
3153 to see whether these functions can be called from other modules.
3154 DEFUN now defines a static function. To make the function external
3155 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3156 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3157 (Finit_image_library):
16a97296
PE
3158 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3159 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3160 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3161 Remove decls, since these functions are now static.
3162 (Funintern, Fget_internal_run_time): New decls, since these functions
3163 were already external.
95c82688 3164
16a97296
PE
3165 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3166 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3167 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3168 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3169 * keyboard.c, keymap.c, lread.c:
3170 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3171 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3172 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3173 Mark functions with DEFUE instead of DEFUN,
3174 if they are used in other modules.
3175 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3176 decls for now-static functions.
3177 * buffer.h (Fdelete_overlay): Remove decl.
3178 * callproc.c (Fgetenv_internal): Mark as internal.
3179 * composite.c (Fremove_list_of_text_properties): Remove decl.
3180 (Fcomposition_get_gstring): New forward static decl.
3181 * composite.h (Fcomposite_get_gstring): Remove decl.
3182 * dired.c (Ffile_attributes): New forward static decl.
3183 * doc.c (Fdocumntation_property): New forward static decl.
3184 * eval.c (Ffetch_bytecode): New forward static decl.
3185 (Funintern): Remove extern decl; now in .h file where it belongs.
3186 * fileio.c (Fmake_symbolic_link): New forward static decl.
3187 * image.c (Finit_image_library): New forward static decl.
3188 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3189 * intervals.h (Fprevious_property_change):
3190 (Fremove_list_of_text_properties): Remove decls.
3191 * keyboard.c (Fthis_command_keys): Remove decl.
3192 (Fcommand_execute): New forward static decl.
3193 * keymap.c (Flookup_key): New forward static decl.
3194 (Fcopy_keymap): Now static.
3195 * keymap.h (Flookup_key): Remove decl.
3196 * process.c (Fget_process): New forward static decl.
3197 (Fprocess_datagram_address): Mark as internal.
3198 * syntax.c (Fsyntax_table_p): New forward static decl.
3199 (skip_chars): Remove duplicate decl.
3200 * textprop.c (Fprevious_property_change): New forward static decl.
3201 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3202 Now internal.
3203 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3204 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3205
785bbd42
PE
3206 * editfns.c (Fformat): Remove unreachable code.
3207
8b913b57
AS
32082011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3209
3210 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3211 change. (Bug#8496)
3212
a6744a35
EZ
32132011-04-13 Eli Zaretskii <eliz@gnu.org>
3214
3215 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3216 when at ZV. (Bug#8487)
3217
e7974947
AS
32182011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3219
baad03f0
AS
3220 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3221 (Bug#8437)
3222 * keyboard.c (parse_tool_bar_item): Likewise.
3223 * sound.c (sound_cleanup, alsa_close): Likewise.
3224 * termcap.c (tgetent): Likewise.
3225 * xfns.c (x_default_font_parameter): Likewise.
3226 * xsettings.c (read_and_apply_settings): Likewise.
3227
e7974947
AS
3228 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3229 (overrun_check_free): Protoize.
3230
28272684
PE
32312011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3234 since callers should never pass a negative size.
3235 Change the signature to match that of plain 'read' and 'write'; see
3236 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3237 * lisp.h: Update prototypes of emacs_write and emacs_read.
3238
11997c76
EZ
32392011-04-11 Eli Zaretskii <eliz@gnu.org>
3240
3241 * xdisp.c (redisplay_window): Don't try to determine the character
3242 position of the scroll margin if the window start point w->startp
e896f03c 3243 is outside the buffer's accessible region. (Bug#8468)
11997c76 3244
8a2cbd72
EZ
32452011-04-10 Eli Zaretskii <eliz@gnu.org>
3246
3247 Fix write-region and its subroutines for buffers > 2GB.
3248 * fileio.c (a_write, e_write): Modify declaration of arguments and
3249 local variables to support buffers larger than 2GB.
3250 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3251
3252 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3253 argument, local variables, and return value.
3254
3255 * lisp.h: Update prototypes of emacs_write and emacs_read.
3256
3257 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3258
4073e537 32592011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3260
1ebfdcb6
PE
3261 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3262
b2ded58d
PE
3263 Fix more problems found by GCC 4.6.0's static checks.
3264
7d66342c
PE
3265 * xdisp.c (vmessage): Use a better test for character truncation.
3266
bbf47d44
PE
3267 * charset.c (load_charset_map): <, not <=, for optimization,
3268 and to avoid potential problems with integer overflow.
9248994d 3269 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3270 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3271 * editfns.c (Fformat): Likewise.
1e69125e 3272 * syntax.c (skip_chars): Likewise.
3befa583 3273
e3019616
PE
3274 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3275 This also lets GCC 4.6.0 generate slightly better loop code.
3276
becfa255
PE
3277 * callint.c (Fcall_interactively): <, not <=, for optimization.
3278 (Fcall_interactively): Count the number of arguments produced,
3279 not the number of arguments given. This is simpler and lets GCC
3280 4.6.0 generate slightly better code.
3281
dae0cd48
PE
3282 * ftfont.c: Distingish more carefully between FcChar8 and char.
3283 The previous code passed unsigned char * to a functions like
3284 strlen and xstrcasecmp that expect char *, which does not
3285 conform to the C standard.
3286 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3287 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3288 char * when the C standard requires it.
3289
76032d70
PE
3290 * keyboard.c (read_char): Remove unused var.
3291
eb3f1cc8
PE
3292 * eval.c: Port to Windows vsnprintf (Bug#8435).
3293 Include <limits.h>.
3294 (SIZE_MAX): Define if the headers do not.
3295 (verror): Do not give up if vsnprintf returns a negative count.
3296 Instead, grow the buffer. This ports to Windows vsnprintf, which
3297 does not conform to C99. Problem reported by Eli Zaretskii.
3298 Also, simplify the allocation scheme, by avoiding the need for
3299 calling realloc, and removing the ALLOCATED variable.
3300
70476b54
PE
3301 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3302
12020a9e
PE
3303 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3304 But keep the doprint source code for now, as we might revamp it
3305 and use it again (Bug#8435).
ea6c7ae6
PE
3306 * lisp.h (doprnt): Remove.
3307 * Makefile.in (base_obj): Remove doprnt.o.
3308 * deps.mk (doprnt.o): Remove.
3309
5fdb398c
PE
3310 error: Print 32- and 64-bit integers portably (Bug#8435).
3311 Without this change, on typical 64-bit hosts error ("...%d...", N)
3312 was used to print both 32- and 64-bit integers N, which relied on
3313 undefined behavior.
3314 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3315 New macro.
3316 * lisp.h (error, verror): Mark as printf-like functions.
3317 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3318 Report overflow in size calculations when allocating printf buffer.
3319 Do not truncate output string at its first null byte.
3320 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3321 Truncate the output at a character boundary, since vsnprintf does not
3322 do that.
3323 * charset.c (check_iso_charset_parameter): Convert internal
3324 character to string before calling 'error', since %c now has the
3325 printf meaning.
3326 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3327 overflow when computing char to be passed to 'error'. Do not
3328 pass Lisp_Object to 'error'; pass the integer instead.
3329 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3330 formatted with plain %d.
3331
b189fa66
PE
3332 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3333
bff87ef0
PE
3334 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3335
7e2cac20
PE
3336 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3337
ce4d90b5
PE
3338 * xterm.c (x_catch_errors): Remove duplicate declaration.
3339
266c9547
PE
3340 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3341
79c49ad2
PE
3342 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3343
368f4090
JM
33442011-04-10 Jim Meyering <meyering@redhat.com>
3345
3346 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3347 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3348 return ssize_t not "int", and use size_t as the buffer length.
3349 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3350 * gnutls.h: Update declarations.
3351 * process.c (read_process_output): Use ssize_t, to match.
3352 (send_process): Likewise.
3353
a32d4040
CY
33542011-04-09 Chong Yidong <cyd@stupidchicken.com>
3355
3356 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3357
8546720e 33582011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3359
04f2d78b
CB
3360 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3361 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3362
8546720e
GM
3363 * xterm.c (handle_one_xevent):
3364 * xmenu.c (create_and_show_popup_menu):
3365 * xselect.c (x_decline_selection_request)
3366 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3367
0a2f5c1a 33682011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3369
3370 Fix some uses of `int' instead of EMACS_INT.
3371 * search.c (string_match_1, fast_string_match)
3372 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3373 (scan_buffer, find_next_newline_no_quit)
3374 (find_before_next_newline, search_command, Freplace_match)
3375 (Fmatch_data): Make some `int' variables be EMACS_INT.
3376
3377 * xdisp.c (display_count_lines): 3rd argument and return value now
3378 EMACS_INT. All callers changed.
3379 (pint2hrstr): Last argument is now EMACS_INT.
3380
3381 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3382 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3383 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3384 (decode_coding_utf_16, decode_coding_emacs_mule)
3385 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3386 (decode_coding_ccl, decode_coding_charset)
3387 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3388 (decode_coding_iso_2022, decode_coding_emacs_mule)
3389 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3390 <char_offset, last_offset>: Declare EMACS_INT.
3391 (encode_coding_utf_8, encode_coding_utf_16)
3392 (encode_coding_emacs_mule, encode_invocation_designation)
3393 (encode_designation_at_bol, encode_coding_iso_2022)
3394 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3395 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3396 Declare EMACS_INT.
3397 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3398 (encode_invocation_designation): Last argument P_NCHARS is now
3399 EMACS_INT.
3400 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3401 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3402
3403 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3404 All users changed.
3405
3406 * ccl.c (Fccl_execute_on_string): Declare some variables
3407 EMACS_INT.
3408
8546720e 34092011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3410
3411 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3412
4e19a977
CS
34132011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3414
3415 * process.c (Fformat_network_address): Doc fix.
3416
87302331
R
34172011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3418
3419 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3420
cbb59342
CY
34212011-04-08 Chong Yidong <cyd@stupidchicken.com>
3422
3423 * keyboard.c (read_char): Call Lisp function help-form-show,
3424 instead of using internal_with_output_to_temp_buffer.
3425 (Qhelp_form_show): New var.
e0d38eeb 3426 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3427
3428 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3429
3430 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3431
e67a13ab
CY
34322011-04-06 Chong Yidong <cyd@stupidchicken.com>
3433
04f2d78b
CB
3434 * process.c (Flist_processes): Remove to Lisp.
3435 (list_processes_1): Delete.
e67a13ab 3436
973f782d
EZ
34372011-04-06 Eli Zaretskii <eliz@gnu.org>
3438
7c106b1e
EZ
3439 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3440
973f782d
EZ
3441 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3442
41cf7d1a 34432011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3444
ca23cc88
PE
3445 Fix more problems found by GCC 4.6.0's static checks.
3446
f390e2d5
PE
3447 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3448
42eea0d0
PE
3449 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3450
b69769da 3451 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3452
f9541e84
PE
3453 * xdisp.c (vmessage): Mark as a printf-like function.
3454
13841b55
PE
3455 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3456
c136c10f
PE
3457 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3458
5e2d4a30
PE
3459 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3460 printf-like functions.
3461 (tiff_load): Add casts to remove these marks before passing them
3462 to system-supplied API.
3463
583f48b9
PE
3464 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3465
b25d760e
PE
3466 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3467 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3468 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3469 directly, rather than having caller test rule sign. This avoids
3470 some unnecessary tests.
3471 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3472 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3473 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3474
bc7b6697 3475 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3476 (xfont_open): Avoid unnecessary tests.
bc7b6697 3477
27ccc379
PE
3478 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3479
dcd5c89a
PE
3480 * composite.h, composite.c (composition_gstring_put_cache):
3481 Use EMACS_INT, not int, for length.
3482
b13a45c6
PE
3483 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3484 breaking out part of COMPOSITION_DECODE_RULE.
3485 (COMPOSITION_DECODE_RULE): Use it.
3486 * composite.c (get_composition_id): Remove unused local vars,
3487 by using the new macro.
3488
1e792e4d
PE
3489 * textprop.c (set_text_properties_1): Change while to do-while,
3490 since the condition is always true at first.
3491
dc6c6455 3492 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3493 (interval_deletion_adjustment): Return unsigned value.
3494 All uses changed.
dc6c6455 3495
aba7731a
PE
3496 * process.c (list_processes_1, create_pty, read_process_output):
3497 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3498 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3499 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3500 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3501 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3502
fdfc4bf3
PE
3503 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3504
fca8fe46 3505 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3506 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3507
06a0259a 3508 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3509 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3510 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3511
e7b9e80f
PE
3512 * print.c (print_error_message): Avoid int overflow.
3513
56201685
PE
3514 * font.c (font_list_entities): Redo for clarity,
3515 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3516
78834453 3517 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3518 (font_score): Avoid potential overflow in diff calculation.
78834453 3519
0bc0b309 3520 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3521 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3522
e610eaca
PE
3523 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3524
b895abce
PE
3525 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3526 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3527 can always succeed if overflow has undefined behavior.
3528
1f1d9321 3529 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3530 (wordify): Omit three unnecessary tests.
1f1d9321 3531
c59478bc
PE
3532 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3533 All callers changed. This avoids the need for an unused var.
3534
79b73827
PE
3535 * casefiddle.c (casify_region): Remove var that is set but not used.
3536
a4db5dfe
PE
3537 * dired.c (file_name_completion): Remove var that is set but not used.
3538
43aae36e
PE
3539 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3540
2a47c44d 3541 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3542 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3543
a37c69bf
PE
3544 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3545 Check for integer overflow on size calculations.
3546
328ab8e7
PE
3547 * buffer.c (Fprevious_overlay_change): Remove var that is set
3548 but not used.
3549
e5a2a5cb
PE
3550 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3551 Remove vars that are set but not used.
8d84a6eb 3552 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3553 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3554
a60e5f68
PE
3555 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3556
f661cb61 3557 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3558 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3559
f0397f5a
PE
3560 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3561 that are set but not used.
3562
8664db06 3563 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3564 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3565
6abdaa4a
PE
3566 * xselect.c (x_get_local_selection, x_handle_property_notify):
3567 Remove vars that are set but not used.
3568
0ce7538d 3569 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3570 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3571
9ae848fc
PE
3572 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3573 Remove var that is set but not used.
0b918413
PE
3574 (scroll_bar_windows_size): Now size_t, not int.
3575 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3576 Check for overflow.
9ae848fc 3577
a5a62657
PE
3578 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3579 (map_tty_color) [!defined MSDOS]: Likewise.
3580
5c5cdd39
PE
3581 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3582
66ebf983
PE
3583 * coding.c: Remove vars that are set but not used.
3584 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3585 All callers changed.
3586 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3587 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3588 (decode_coding_charset): Remove vars that are set but not used.
3589
1be4d761
PE
3590 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3591 that is set but not used.
3592
47553fa8
PE
3593 * print.c (print_object): Remove var that is set but not used.
3594
1f7196bf 3595 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3596 The gnulib version avoids calling malloc in the usual case,
3597 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3598 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3599 * filelock.c (current_lock_owner): Likewise.
3600 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3601 * sysdep.c: Include allocator.h, careadlinkat.h.
3602 (emacs_no_realloc_allocator): New static constant.
3603 (emacs_readlink): New function.
fdb61804
PE
3604 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3605 ../lib/careadlinkat.h.
d1fdcab7 3606
f84c17c7
SM
36072011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3608
3609 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3610 first non-nil return value).
3611
ef3862ad
JD
36122011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3613
3614 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3615 if not defined (Bug#8403).
3616
376a7006
JB
36172011-04-02 Juanma Barranquero <lekktu@gmail.com>
3618
3619 * xdisp.c (display_count_lines): Remove parameter `start',
3620 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3621 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3622 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3623 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3624 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3625 and thereabouts. All callers changed.
3626 (get_per_char_metric): Remove parameter `f', unused since
3627 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3628
6ca3801d
JM
36292011-04-02 Jim Meyering <meyering@redhat.com>
3630
3631 do not dereference NULL upon failed strdup
3632 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3633 (ns_get_family): Likewise.
3634
d8e2b5ba
JB
36352011-04-02 Juanma Barranquero <lekktu@gmail.com>
3636
3637 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3638
8c74fcbd
JD
36392011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3640
3641 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3642 later (Bug#8403).
3643
7200d79c
SM
36442011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3645
03408648 3646 Add lexical binding.
7200d79c 3647
03408648
SM
3648 * window.c (Ftemp_output_buffer_show): New fun.
3649 (Fsave_window_excursion):
3650 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3651
3652 * lread.c (lisp_file_lexically_bound_p): New function.
3653 (Fload): Bind Qlexical_binding.
3654 (readevalloop): Remove `evalfun' arg.
3655 Bind Qinternal_interpreter_environment.
3656 (Feval_buffer): Bind Qlexical_binding.
3657 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3658 Mark as dynamic.
3659 (syms_of_lread): Declare `lexical-binding'.
3660
3661 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3662
3663 * keyboard.c (eval_dyn): New fun.
3664 (menu_item_eval_property): Use it.
ca105506
SM
3665
3666 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3667
03408648
SM
3668 * fns.c (concat, mapcar1): Accept byte-code-functions.
3669
3670 * eval.c (Fsetq): Handle lexical vars.
3671 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3672 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3673 (FletX, Flet): Obey lexical binding.
3674 (Fcommandp): Handle closures.
3675 (Feval): New `lexical' arg.
3676 (eval_sub): New function extracted from Feval. Use it almost
3677 everywhere where Feval was used. Look up vars in lexical env.
3678 Handle closures.
3679 (Ffunctionp): Move from subr.el.
3680 (Ffuncall): Handle closures.
3681 (apply_lambda): Remove `eval_flags'.
3682 (funcall_lambda): Handle closures and new byte-code-functions.
3683 (Fspecial_variable_p): New function.
3684 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3685 but without exporting it to Lisp.
23aba0ea 3686
23aba0ea 3687 * doc.c (Fdocumentation, store_function_docstring):
03408648 3688 * data.c (Finteractive_form): Handle closures.
23aba0ea 3689
03408648
SM
3690 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3691 interactive spec.
ba83908c 3692
04f2d78b
CB
3693 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3694 New byte-codes.
03408648
SM
3695 (exec_byte_code): New function extracted from Fbyte_code to handle new
3696 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3697
03408648 3698 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3699
03408648 3700 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3701
e2abce01
JB
37022011-03-31 Juanma Barranquero <lekktu@gmail.com>
3703
3704 * xdisp.c (redisplay_internal): Fix prototype.
3705
63696a73 37062011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3707
63696a73 3708 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3709 (try_scrolling): Use it when setting scroll_limit.
3710 Limit scrolling to 100 screen lines.
63696a73
EZ
3711 (redisplay_window): Even when falling back on "recentering",
3712 position point in the window according to scroll-conservatively,
3713 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3714
3715 (try_scrolling): When point is above the window, allow searching
3716 as far as scroll_max, or one screenful, to compute vertical
3717 distance from PT to the scroll margin position. This prevents
3718 try_scrolling from unnecessarily failing when
3719 scroll-conservatively is set to a value slightly larger than the
3720 window height. Clean up the case of PT below the margin at bottom
3721 of window: scroll_max can no longer be INT_MAX. When aggressive
3722 scrolling is in use, don't let point enter the opposite scroll
3723 margin as result of the scroll.
3724 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3725 threshold of 100 lines for never-recentering scrolling.
3726
e4cc2dfc
JB
37272011-03-31 Juanma Barranquero <lekktu@gmail.com>
3728
3729 * dispextern.h (move_it_by_lines):
3730 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3731 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3732 (message_log_check_duplicate): Remove parameters `prev_bol' and
3733 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3734 (redisplay_internal): Remove parameter `preserve_echo_area',
3735 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3736
3737 * indent.c (Fvertical_motion):
3738 * window.c (window_scroll_pixel_based, Frecenter):
3739 Don't pass `need_y_p' to `move_it_by_lines'.
3740
1c470562
SM
37412011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3742
44f230aa
SM
3743 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3744 steal a few bits to be more compact.
3745 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3746 Remove unneeded casts.
3747
1c470562
SM
3748 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3749
888adce9
ZK
37502011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3751
3752 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3753 binding" message (bug#7967).
3754
f838ed7b
PE
37552011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3756
77861b95
PE
3757 Fix more problems found by GCC 4.6.0's static checks.
3758
de6dbc14
PE
3759 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3760 Remove unused local var.
3761
f838ed7b
PE
3762 * editfns.c (Fmessage_box): Remove unused local var.
3763
792c7b2b
PE
3764 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3765 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3766 Omit unused local vars.
c499e557 3767 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3768 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3769 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3770 Omit unused local var.
3771
ba0165e1
PE
3772 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3773 Don't assume string length fits in int.
32ad8845 3774 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3775 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3776
3c59b4c9
PE
3777 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3778 instead of alloca (Bug#8344).
3779
a3eed478 3780 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3781 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3782
eb4d412d
PE
3783 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3784
1658b401
PE
3785 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3786 concerns.
3787
3788 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3789
3790 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3791
9a2c6e05
PE
3792 * keyboard.c (syms_of_keyboard): Use the same style as later
3793 in this function when indexing through an array. This also
3794 works around GCC bug 48267.
3795
03d0a109
PE
3796 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3797
44f730c8
PE
3798 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3799
fe75f926
PE
3800 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3801 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3802
ffa8c828
PE
3803 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3804 This avoids undefined behavior on integer overflow, and is a bit
3805 more convenient anyway since it is compared to a size_t variable.
3806
c5101a77
PE
3807 Variadic C functions now count arguments with size_t, not int.
3808 This avoids an unnecessary limitation on 64-bit machines, which
3809 caused (substring ...) to crash on large vectors (Bug#8344).
3810 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3811 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3812 All variadic functions and their callers changed accordingly.
c5101a77
PE
3813 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3814 * data.c (arith_driver, float_arith_driver): Likewise.
3815 * editfns.c (general_insert_function): Likewise.
3816 * eval.c (struct backtrace.nargs, interactive_p)
3817 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3818 (funcall_lambda, mark_backtrace): Likewise.
3819 * fns.c (concat): Likewise.
3820 * frame.c (x_set_frame_parameters): Likewise.
3821 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3822 0 if not found, not -1. All callers changed.
3823
dd3f25f7
PE
3824 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3825 (stack_copy_size): Now size_t, not int.
3826 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3827
461c2ab9
JB
38282011-03-28 Juanma Barranquero <lekktu@gmail.com>
3829
3830 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3831 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3832 All callers changed.
3833
3834 * lisp.h (multibyte_char_to_unibyte):
3835 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3836 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3837 * character.h (CHAR_TO_BYTE8):
3838 * cmds.c (internal_self_insert):
3839 * editfns.c (general_insert_function):
3840 * keymap.c (push_key_description):
3841 * search.c (Freplace_match):
3842 * xdisp.c (message_dolog, set_message_1): All callers changed.
3843
f6d62986
SM
38442011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3845
3846 * keyboard.c (safe_run_hook_funcall): New function.
3847 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3848 don't set the hook to nil, but remove the offending function instead.
3849 (Qcommand_hook_internal): Remove, unused.
3850 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3851 Vcommand_hook_internal.
3852
3853 * eval.c (enum run_hooks_condition): Remove.
3854 (funcall_nil, funcall_not): New functions.
3855 (run_hook_with_args): Call each function through a `funcall' argument.
3856 Remove `cond' argument, now redundant.
3857 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3858 (Frun_hook_with_args_until_failure): Adjust accordingly.
3859 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3860
1db5b1ad
JB
38612011-03-28 Juanma Barranquero <lekktu@gmail.com>
3862
3863 * dispextern.h (string_buffer_position): Remove declaration.
3864
3865 * print.c (strout): Remove parameter `multibyte', unused since
3866 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3867
3868 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3869 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3870 All callers changed.
3871
3872 * w32.c (_wsa_errlist): Use braces for struct initializers.
3873
3874 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3875 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3876 All callers changed.
3877 (string_buffer_position): Likewise. Also, make static (it's never
3878 used outside xdisp.c).
3879 (cursor_row_p): Remove parameter `w', unused since
3880 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3881 (decode_mode_spec): Remove parameter `precision', introduced during
3882 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3883 All callers changed.
3884
5ffb62aa
JD
38852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3886
3887 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3888
461c2ab9 38892011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3890
3891 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3892 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3893 (ns_update_auto_hide_menu_bar): New functions.
3894 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3895 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3896 ns_constrain_all_frames.
3897 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3898 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3899
5c380ffb
JD
39002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3901
3902 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3903
9af30bdf
GM
39042011-03-27 Glenn Morris <rgm@gnu.org>
3905
3906 * syssignal.h: Replace RETSIGTYPE with void.
3907 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3908 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3909 Replace SIGTYPE with void everywhere.
3910 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3911 * s/template.h (SIGTYPE): Remove commented out definition.
3912
e2abce01
JB
39132011-03-26 Eli Zaretskii <eliz@gnu.org>
3914
3915 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3916 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3917
f868cd8a
JB
39182011-03-26 Juanma Barranquero <lekktu@gmail.com>
3919
59eb0929
JB
3920 * w32.c (read_unc_volume): Use parameter `henum', instead of
3921 global variable `wget_enum_handle'.
3922
3923 * keymap.c (describe_vector): Remove parameters `indices' and
3924 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3925 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3926
f868cd8a
JB
3927 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3928
3929 * keyboard.c (timer_check): Remove parameter `do_it_now',
3930 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3931 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3932 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3933
3934 * keyboard.c (read_char):
3935 * w32menu.c (w32_menu_display_help):
3936 * xmenu.c (show_help_event, menu_help_callback):
3937 Adjust calls to `show_help_echo'.
3938
3939 * gtkutil.c (xg_maybe_add_timer):
3940 * keyboard.c (readable_events):
3941 * process.c (wait_reading_process_output):
3942 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3943
3944 * insdel.c (adjust_markers_gap_motion):
3945 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3946 (gap_left, gap_right): Don't call it.
3947
2ecf6fdb
CY
39482011-03-25 Chong Yidong <cyd@stupidchicken.com>
3949
3950 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3951 incurred during fontification.
3952
6b1f9ba4
JB
39532011-03-25 Juanma Barranquero <lekktu@gmail.com>
3954
3955 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3956 (DEFVAR_PER_BUFFER): Don't pass it.
3957
3958 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3959 (scrolling_window): Don't pass it.
3960
0f4a96b5
JB
39612011-03-25 Juanma Barranquero <lekktu@gmail.com>
3962
3963 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3964
3965 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3966 and `suffix'.
3967 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3968 of variables specific to SELinux and computation of `encoded_absname'.
3969
3970 * image.c (XPutPixel): Remove unused variable `height'.
3971
3972 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3973
3974 * unexw32.c (get_section_info): Remove unused variable `section'.
3975
3976 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3977 (system_process_attributes): Remove unused variable `sess'.
3978 (sys_read): Remove unused variable `err'.
3979
3980 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3981 (w32_wnd_proc): Remove unused variable `isdead'.
3982 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3983 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3984 (x_create_tip_frame): Remove unused variable `tem'.
3985
3986 * w32inevt.c (w32_console_read_socket):
3987 Remove unused variable `no_events'.
3988
3989 * w32term.c (x_draw_composite_glyph_string_foreground):
3990 Remove unused variable `width'.
3991
1149507c
JB
39922011-03-24 Juanma Barranquero <lekktu@gmail.com>
3993
3994 * w32term.c (x_set_glyph_string_clipping):
3995 Don't pass uninitialized region to CombineRgn.
3996
9c88f339
JB
39972011-03-23 Juanma Barranquero <lekktu@gmail.com>
3998
3999 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4000 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4001 (Fx_close_connection): Remove unused variable `i'.
4002
4003 * w32font.c (w32font_draw): Return number of glyphs.
4004 (w32font_open_internal): Remove unused variable `i'.
4005 (w32font_driver): Add missing initializer.
4006
4007 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4008 (fill_in_menu): Remove unused variable `items_added'.
4009
4010 * w32term.c (last_mouse_press_frame): Remove static global variable.
4011 (w32_clip_to_row): Remove unused variable `f'.
4012 (x_delete_terminal): Remove unused variable `i'.
4013
4014 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4015 (NOTHING): Remove unused static global variable.
4016 (uniscribe_check_otf): Remove unused variable `table'.
4017 (uniscribe_font_driver): Add missing initializers.
4018
dee091a3
JD
40192011-03-23 Julien Danjou <julien@danjou.info>
4020
4021 * term.c (Fsuspend_tty, Fresume_tty):
4022 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4023 * window.c (temp_output_buffer_show):
4024 * insdel.c (signal_before_change):
4025 * frame.c (Fhandle_switch_frame):
4026 * fileio.c (Fdo_auto_save):
4027 * emacs.c (Fkill_emacs):
4028 * editfns.c (save_excursion_restore):
4029 * cmds.c (internal_self_insert):
4030 * callint.c (Fcall_interactively):
4031 * buffer.c (Fkill_all_local_variables):
4032 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4033 Use Frun_hooks.
0f4a96b5 4034 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4035 unconditionnaly since it does the check itself.
4036
2c520ab5 40372011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4038
c9c49752
PE
4039 Fix more problems found by GCC 4.5.2's static checks.
4040
8abc3f12
PE
4041 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4042 the first time through the loop, since we know p0 < p1 then.
4043 This also avoids a gcc -Wstrict-overflow warning.
4044
a2d26660
PE
4045 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4046 leading to a memory leak, possible in functions like
4047 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4048 of objects (Bug#8318).
a2d26660 4049
916c72e9
PE
4050 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4051 that could (at least in theory) be that large.
4052
19ab8a18
PE
4053 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4054 This is less likely to overflow, and avoids undefined behavior if
4055 overflow does occur. All callers changed. Use strtoul to scan
4056 for the unsigned long integer.
b7cbbd6f
PE
4057 (pint2hrstr): Simplify and tune code slightly.
4058 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4059
f0641eff
PE
4060 * scroll.c (do_scrolling): Work around GCC bug 48228.
4061 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4062
7f650bb9
PE
4063 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4064 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4065 (validate_x_resource_name): Simplify count usage.
4066 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4067
37dd57d1
PE
4068 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4069 fail (Bug#8306).
81e56e61 4070
699979fc 4071 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4072
401bf9b4
PE
4073 * process.c (Fmake_network_process): Use socklen_t, not int,
4074 where POSIX says socklen_t is required in portable programs.
4075 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4076 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4077 (Fmake_network_process, server_accept_connection):
4078 (wait_reading_process_output, read_process_output):
4079 Likewise.
4080
b93aacde
PE
4081 * process.c: Rename or move locals to avoid shadowing.
4082 (list_processes_1, Fmake_network_process):
4083 (read_process_output_error_handler, exec_sentinel_error_handler):
4084 Rename or move locals.
4dc343ee 4085 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4086 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4087 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4088 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4089 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4090
af8a867c 4091 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4092 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4093 Include tparam.h instead, since it declares them.
af8a867c
PE
4094 * cm.h (PC): Remove extern decl; tparam.h now does this.
4095 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4096 * terminfo.c: Include tparam.h, to check interfaces.
4097 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4098 (tparam): Adjust signature to match interface in tparam.h;
4099 this removes some undefined behavior. Check that outstring and len
4100 are zero, which they always are with Emacs.
4101 * tparam.h (PC, BC, UP): New extern decls.
4102
0248044d 4103 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4104 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4105
8ff096c1 4106 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4107 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4108 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4109 (ftfont_list): Remove unused local.
49eaafba
PE
4110 (get_adstyle_property, ftfont_pattern_entity):
4111 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4112 Rename locals to avoid shadowing.
8ff096c1 4113
e2be39f6
PE
4114 * xfont.c (xfont_list_family): Mark var as initialized.
4115
c9735e30
PE
4116 * xml.c (make_dom): Now static.
4117
8f5201ae
PE
4118 * composite.c (composition_compute_stop_pos): Rename local to
4119 avoid shadowing.
b246f932
PE
4120 (composition_reseat_it): Remove unused locals.
4121 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4122 (composition_update_it): Mark var as initialized.
11b61122
PE
4123 (find_automatic_composition): Mark vars as initialized,
4124 with a FIXME (Bug#8290).
8f5201ae 4125
760fbc2c
PE
4126 character.h: Rename locals to avoid shadowing.
4127 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4128 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4129 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4130 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4131 to avoid shadowing.
4132
ff08eb85
PE
4133 * textprop.c (property_change_between_p): Remove; unused.
4134
fc7bf025
PE
4135 * intervals.c (interval_start_pos): Now static.
4136
235d7abc
PE
4137 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4138
44f230aa
SM
4139 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4140 Rename locals to avoid shadowing.
3e7d6594 4141
50060332
PE
4142 * sound.c (wav_play, au_play, Fplay_sound_internal):
4143 Fix pointer signedness.
d01f234b 4144 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4145 (wav_play): Initialize a variable to 0, to prevent undefined
4146 behavior (Bug#8278).
50060332 4147
c4fc4e30
PE
4148 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4149
918436ed
PE
4150 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4151
c939f91b
PE
4152 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4153 clobbering (Bug#8298).
b9c7f648
PE
4154 * sysdep.c (sys_subshell): Likewise.
4155 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4156
6bd8c144
PE
4157 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4158 This should get cleaned up, so that child_setup has the
4159 same signature on all platforms.
4160
7710357c 4161 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4162 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4163
c59da222
CY
41642011-03-22 Chong Yidong <cyd@stupidchicken.com>
4165
4166 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4167 not to be necessary, and produces flickering.
4168
66b87493
GM
41692011-03-20 Glenn Morris <rgm@gnu.org>
4170
4171 * config.in: Remove file.
4172
45b6f6d5
JB
41732011-03-20 Juanma Barranquero <lekktu@gmail.com>
4174
4175 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4176 are now in src/globals.h.
4177 (syms_of_minibuf): Remove spurious & from previous change.
4178
3ec03f7e
LL
41792011-03-20 Leo <sdl.web@gmail.com>
4180
4181 * minibuf.c (completing-read-function): New variable.
4182 (completing-read-default): Rename from completing-read.
4183 (completing-read): Call completing-read-function.
4184
b14e3e21
CY
41852011-03-19 Juanma Barranquero <lekktu@gmail.com>
4186
4187 * xfaces.c (Fx_load_color_file):
4188 Read color file from absolute filename (bug#8250).
4189
f2b726e6
JB
41902011-03-19 Juanma Barranquero <lekktu@gmail.com>
4191
4192 * makefile.w32-in: Update dependencies.
4193
09f6ff02
EZ
41942011-03-17 Eli Zaretskii <eliz@gnu.org>
4195
4196 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4197
29a6015a
PE
41982011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4199
a3a6c54e
PE
4200 Fix more problems found by GCC 4.5.2's static checks.
4201
b766f867
PE
4202 * process.c (make_serial_process_unwind, send_process_trap):
4203 (sigchld_handler): Now static.
4204
be02381c
PE
4205 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4206 That way, the code declares only the vars that it needs.
4207 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4208 * s/cygwin.h (PTY_ITERATION): Likewise.
4209 * s/darwin.h (PTY_ITERATION): Likewise.
4210 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4211
57048744
PE
4212 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4213 * process.c (allocate_pty): Don't declare stb unless it's needed.
4214
7914961c 4215 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4216 (CONSTANTLIM): Remove; unused.
4217 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4218 Define only if needed.
7914961c 4219
b3967b18
PE
4220 * unexelf.c (unexec): Name an expression,
4221 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4222 Use a different way to cause a compilation error if anyone uses
4223 n rather than nn, a way that does not involve shadowing.
73366a00 4224 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4225
29a6015a
PE
4226 * deps.mk (unexalpha.o): Remove; unused.
4227
43cfc33e 4228 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4229 * unexec.h: New file.
ce701a33
PE
4230 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4231 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4232 Depend on unexec.h.
4233 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4234 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4235 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4236 Change as necessary to match prototype in unexec.h.
ce701a33 4237
01f44d5a
PE
4238 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4239 shadowing.
4f63c6bb 4240 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4241
a6670b0b
PE
4242 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4243 Rename locals to avoid shadowing.
4244
cef2010d 4245 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4246 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4247
d4d7173a
PE
4248 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4249
f08b802a
PE
4250 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4251 warning when compiling print.c.
4252
3ddb0639
PE
4253 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4254 instead of using an uninitialized var.
5ad03b97 4255 (font_sort_entities): Mark var as initialized.
3ddb0639 4256
170a2692
PE
4257 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4258
e663c700
PE
4259 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4260 pointers to constants.
89bc529a 4261 (font_parse_fcname): Remove unused vars.
7b81e2d0 4262 (font_delete_unmatched): Now static.
ea838e10 4263 (font_get_spec): Remove; unused.
13a547c6
PE
4264 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4265 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4266 Rename or move locals to avoid shadowing.
e663c700 4267
2a80c887 4268 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4269 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4270
1384fa33 4271 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4272 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4273
8b2c52e9
PE
4274 * alloc.c (mark_backtrace): Move decl from here ...
4275 * lisp.h: ... to here, so that it can be checked.
4276
475545b5 4277 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4278 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4279 (lisp_indirect_variable): Name an expression,
4280 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4281 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4282
b1349114 4283 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4284 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4285 Use const pointer when appropriate.
b1349114 4286
a2928364
PE
4287 * lisp.h (get_system_name, get_operating_system_release):
4288 Move decls here, to check interfaces.
4289 * process.c (get_operating_system_release): Move decl to lisp.h.
4290 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4291 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4292 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4293 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4294 (Fformat_time_string, Fencode_time, Finsert_char):
4295 (Ftranslate_region_internal, Fformat):
4296 Rename or remove local vars to avoid shadowing.
9710023e 4297 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4298
a415e694
PE
4299 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4300 avoid shadowing.
4301
8ef4622d
PE
4302 * lisp.h (eassert): Check that the argument compiles, even if
4303 ENABLE_CHECKING is not defined.
4304
946f9a5b
PE
4305 * data.c (Findirect_variable): Name an expression, to avoid
4306 gcc -Wbad-function-cast warning.
112396d6 4307 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4308 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4309 (Fmake_variable_buffer_local, Fmake_local_variable):
4310 Mark variables as initialized.
52746918 4311 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4312
e5aab7e7 4313 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4314 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4315 Rename locals to avoid shadowing.
dff45157
PE
4316 (mark_stack): Move local variables into the #ifdef region where
4317 they're used.
7bc26fdb
PE
4318 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4319 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4320 needed otherwise.
4321 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4322 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4323 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4324
e5aab7e7
PE
4325 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4326 avoids undefined behavior in theory.
4327
4da60324
PE
4328 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4329
88043301
PE
4330 Use functions, not macros, for up- and down-casing (Bug#8254).
4331 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4332 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4333 to use the following functions instead of these macros.
4334 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4335 EMACS_INT, since callers assume the returned value fits in int.
4336 (upcase1): Likewise, for UPCASE_TABLE.
4337 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4338 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4339 the race-condition problem in the old DOWNCASE.
88043301 4340
19ed5445
PE
4341 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4342 Rename locals to avoid shadowing.
4343 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4344 (regex_compile, re_search_2, re_match_2_internal):
4345 Remove unused local vars.
952db0d7
PE
4346 (FREE_VAR): Rewrite so as not to use empty "else",
4347 which gcc can warn about.
da053e48 4348 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4349 (RETALLOC_IF): Define only if needed.
4350 (WORDCHAR_P): Likewise. This one is never needed, but is used
4351 only in a comment talking about a compiler bug, so put inside
4352 the #if 0 of that comment.
4353 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4354 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4355 Remove; unused.
19ed5445 4356
1f3561e4 4357 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4358 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4359 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4360
ded6f8f7
PE
4361 * search.c (simple_search): Remove unused var.
4362
dbd37a95
PE
4363 * dired.c (compile_pattern): Move decl from here ...
4364 * lisp.h: ... to here, so that it can be checked.
4365 (struct re_registers): New forward decl.
4366
7e47afad
PE
4367 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4368
85f24f61
PE
4369 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4370 All uses changed.
4371 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4372 Rename locals to avoid shadowing.
5671df8f 4373 (Fvertical_motion): Mark locals as initialized.
85f24f61 4374
181aa2be 4375 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4376 (casify_region): Mark local as initialized.
181aa2be 4377
930d429c
PE
4378 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4379
7082eac6
PE
4380 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4381 New macros, so that the caller can use some names other than
4382 gcpro1, gcpro2, etc.
4383 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4384 of the new macros.
4385 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4386 argument, for consistency with GCPRO2_VAR, etc: it is now the
4387 prefix of the variable, not the variable itself. All uses
4388 changed.
38b2c076
PE
4389 * dired.c (directory_files_internal, file_name_completion):
4390 Rename locals to avoid shadowing.
4391
15206ed9
PE
4392 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4393 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4394 dired.c's scmp function, had undefined behavior.
4395 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4396 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4397 * buffer.h: ... to here, because these macros use current_buffer,
4398 and the new implementation with inline functions needs to have
4399 current_buffer in scope now, rather than later when the macros
4400 are used.
4401 (downcase, upcase1): New static inline functions.
4402 (DOWNCASE, UPCASE1): Reimplement using these functions.
4403 This avoids undefined behavior in expressions like
4404 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4405 from race conditions in accessing the global variables
4406 case_temp1 and case_temp2.
4407 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4408 * lisp.h (case_temp1, case_temp2): Remove their decls.
4409 * character.h (ASCII_CHAR_P): Move from here ...
4410 * lisp.h: ... to here, so that the inline functions mentioned
4411 above can use them.
4412
4a6bea26
PE
4413 * dired.c (directory_files_internal_unwind): Now static.
4414
f14b7e14
PE
4415 * fileio.c (file_name_as_directory, directory_file_name):
4416 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4417 Now static.
2893f146
PE
4418 (file_name_as_directory): Use const pointers when appropriate.
4419 (Fexpand_file_name): Likewise. In particular, newdir might
4420 point at constant storage, so make it a const pointer.
fd4ead52 4421 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4422 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4423 signedness issues.
f839df0c
PE
4424 (Fset_file_times, Finsert_file_contents, auto_save_error):
4425 Rename locals to avoid shadowing.
f14b7e14 4426
5716756e 4427 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4428 (Ftry_completion, Fall_completions): Rename or remove locals
4429 to avoid shadowing.
5716756e 4430
b4c3046a
PE
4431 * marker.c (bytepos_to_charpos): Remove; unused.
4432
b45db522
PE
4433 * lisp.h (verify_bytepos, count_markers): New decls,
4434 so that gcc does not warn that these functions aren't declared.
4435
85876d07
PE
4436 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4437 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4438 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4439 (copy_text): Remove unused local var.
85876d07 4440
03d78a21 4441 * filelock.c (within_one_second): Now static.
b3dd38ab 4442 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4443
5df8f01b
PE
4444 * buffer.c (fix_overlays_before): Mark locals as initialized.
4445 (fix_start_end_in_overlays): Likewise. This function should be
4446 simplified by using pointers-to-pointers, but that's a different
4447 matter.
b1d876f1 4448 (switch_to_buffer_1): Now static.
8f54f30a
PE
4449 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4450 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4451
a70072c9 4452 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4453 Fix pointer signedness issue.
edced198
PE
4454 (sys_subshell): Mark local as volatile if checking for lint,
4455 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4456 (MAXPATHLEN): Define only if needed.
a70072c9 4457
a0977c44
PE
4458 * process.c (serial_open, serial_configure): Move decls from here ...
4459 * systty.h: ... to here, so that they can be checked.
4460
a884fdcc
PE
4461 * fns.c (get_random, seed_random): Move extern decls from here ...
4462 * lisp.h: ... to here, so that they can be checked.
4463
604efe86 4464 * sysdep.c (reset_io): Now static.
b8950c94 4465 (wait_for_termination_signal): Remove; unused.
604efe86 4466
38fc62d9
PE
4467 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4468 (copy_keymap_item, append_key, push_text_char_description):
4469 Now static.
1004a21a 4470 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4471 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4472 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4473 (describe_map_tree):
4474 Rename locals to avoid shadowing.
38fc62d9 4475
2f2650da
PE
4476 * keyboard.c: Declare functions static if they are not used elsewhere.
4477 (echo_char, echo_dash, cmd_error, top_level_2):
4478 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4479 (read_char, kbd_buffer_get_event, make_lispy_position):
4480 (make_lispy_event, make_lispy_movement, apply_modifiers):
4481 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4482 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4483 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4484 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4485 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4486
a053e86c 4487 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4488 (mark_kboards): Move decl here ...
4489 * alloc.c (mark_kboards): ... from here.
a053e86c 4490
4752793e
PE
4491 * lisp.h (force_auto_save_soon): New decl.
4492
74f10ca7 4493 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4494 (DEFINE_DUMMY_FUNCTION): New macro.
4495 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4496 Use it.
c03cd23f
PE
4497 (main): Add casts to avoid warnings
4498 if GCC considers string literals to be constants.
74f10ca7 4499
022e70d4
PE
4500 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4501
59d6fe83
PE
4502 * dbusbind.c: Pointer signedness fixes.
4503 (xd_signature, xd_append_arg, xd_initialize):
4504 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4505 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4506 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4507 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4508
78320123
PE
4509 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4510 if GCC considers string literals to be constants.
49cebcca 4511 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4512
35ac2a97
SM
45132011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4514
fb103ca9
SM
4515 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4516 (print_preprocess, print_object): New macro to fix last change.
4517
35ac2a97
SM
4518 * print.c (print_preprocess): Don't forget font objects.
4519
62973b41
JB
45202011-03-16 Juanma Barranquero <lekktu@gmail.com>
4521
4522 * emacs.c (USAGE3): Doc fixes.
4523
0e48bb22
AS
45242011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4525
4526 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4527 structure.
4528
7684e57b
JB
45292011-03-14 Juanma Barranquero <lekktu@gmail.com>
4530
4531 * lisp.h (VWindow_system, Qfile_name_history):
4532 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4533 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4534 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4535
4536 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4537 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4538
4539 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4540 * w32console.c (detect_input_pending, read_input_pending)
4541 (encode_terminal_code):
4542 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4543 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4544 (w32_system_caret_y, Qfile_name_history):
4545 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4546 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4547 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4548 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4549 * w32proc.c (Qlocal, report_file_error):
4550 * w32term.c (Vwindow_system, updating_frame):
4551 * w32uniscribe.c (initialized, uniscribe_font_driver):
4552 Remove unneeded extern declarations.
4553
2aa46d6c
CY
45542011-03-14 Chong Yidong <cyd@stupidchicken.com>
4555
c96bbc66 4556 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4557
cffc6f3b
CY
45582011-03-13 Chong Yidong <cyd@stupidchicken.com>
4559
4560 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4561 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4562 These macros can no longer be used for assignment.
4563
44f230aa
SM
4564 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4565 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4566 (record_buffer_markers, fetch_buffer_markers): New functions for
4567 recording and fetching special buffer markers.
4568 (set_buffer_internal_1, set_buffer_temp): Use them.
4569
4570 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4571
4572 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4573
4574 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4575 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4576
4577 * xdisp.c (hscroll_window_tree):
4578 (reconsider_clip_changes): Use PT instead of BUF_PT.
4579
d251f04b
EZ
45802011-03-13 Eli Zaretskii <eliz@gnu.org>
4581
4582 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4583 $(EMACS_ROOT)/lib/intprops.h.
4584
f0c77cd1
PE
45852011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4586
3eca4629
PE
4587 Fix more problems found by GCC 4.5.2's static checks.
4588
7c86ee98
PE
4589 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4590 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4591 (xg_free_frame_widgets): Make it clear that a local variable is
4592 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4593 (gdk_window_get_screen): Make it clear that this macro is needed
4594 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4595 (int_gtk_range_get_value): New function, which avoids a diagnostic
4596 from gcc -Wbad-function-cast.
4597 (xg_set_toolkit_scroll_bar_thumb): Use it.
4598 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4599 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4600 (get_utf8_string, xg_get_file_with_chooser):
4601 Rename locals to avoid shadowing.
4602 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4603
41729b81
PE
4604 * xgselect.c (xg_select): Remove unused var.
4605
f0c77cd1
PE
4606 * image.c (four_corners_best): Mark locals as initialized.
4607 (gif_load): Initialize transparent_p to zero (Bug#8238).
4608 Mark another local as initialized.
ec6cf4c6 4609 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4610
ce0ad53d 4611 * image.c (clear_image_cache): Now static.
d5d5a617 4612 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4613 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4614 (x_edge_detection): Remove unnecessary cast that
4615 gcc -Wbad-function-cast diagnoses.
2037898d 4616 (gif_load): Fix pointer signedness.
6ae141d6
PE
4617 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4618 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4619
33383987 46202011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4621
d32df629
PE
4622 Improve quality of tests for time stamp overflow.
4623 For example, without this patch (encode-time 0 0 0 1 1
4624 1152921504606846976) returns the obviously-bogus value (-948597
4625 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4626 reports time overflow. See
4627 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4628 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4629 * editfns.c: Include limits.h and intprops.h.
4630 (TIME_T_MIN, TIME_T_MAX): New macros.
4631 (time_overflow): Move earlier, to before first use.
4632 (hi_time, lo_time): New functions, for an accurate test for
4633 out-of-range times.
4634 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4635 (Fget_internal_run_time): Don't assume time_t fits in int.
4636 (make_time): Use list2 instead of Fcons twice.
4637 (Fdecode_time): More accurate test for out-of-range times.
4638 (check_tm_member): New function.
4639 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4640 (lisp_time_argument): Don't rely on undefined left-shift and
4641 right-shift behavior when checking for time stamp overflow.
8be6f318 4642
fe31d94c
PE
4643 * editfns.c (time_overflow): New function, refactoring common code.
4644 (Fformat_time_string, Fdecode_time, Fencode_time):
4645 (Fcurrent_time_string): Use it.
4646
8be6f318
PE
4647 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4648 * dired.c (make_time): Move to ...
4649 * editfns.c (make_time): ... here.
4650 * systime.h: Note the move.
4651
09d9db2c 46522011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4653
126bc0dc
YM
4654 * fringe.c (update_window_fringes): Remove unused variables.
4655
c47cbdfd
YM
4656 * unexmacosx.c (copy_data_segment): Also copy __got section.
4657 (Bug#8223)
4658
7ac80be9
EZ
46592011-03-12 Eli Zaretskii <eliz@gnu.org>
4660
c96bbc66 4661 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4662 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4663 Constify `char *' arguments and their references according to
4664 prototypes in tparam.h.
4665
ecb0f94d 4666 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4667
7ac80be9
EZ
4668 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4669 Adapt all references accordingly.
4670
4671 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4672
ef1fd07e
TT
46732011-03-11 Tom Tromey <tromey@redhat.com>
4674
4675 * buffer.c (syms_of_buffer): Remove obsolete comment.
4676
7ef4b50c
EZ
46772011-03-11 Eli Zaretskii <eliz@gnu.org>
4678
4679 * termhooks.h (encode_terminal_code): Declare prototype.
4680
4681 * msdos.c (encode_terminal_code): Don't declare prototype.
4682
4683 * term.c (encode_terminal_code): Now external again, used by
4684 w32console.c and msdos.c.
4685
44f230aa
SM
4686 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4687 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4688
4b1ec863 46892011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4690
1714f52b 4691 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4692
4b1ec863
PE
4693 * fringe.c (update_window_fringes): Mark locals as initialized
4694 (Bug#8227).
4695 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4696
524c7aa6
PE
4697 * alloc.c (mark_fringe_data): Move decl from here ...
4698 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4699 to check its interface.
4700 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4701
a5c0af81 4702 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4703 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4704 (fontset_font): Mark local as initialized.
a9a06e0b 4705 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4706
b4716021
PE
4707 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4708
811e9bac 4709 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4710 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4711 (x_own_selection, Fx_disown_selection_internal): Rename locals
4712 to avoid shadowing.
4713 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4714
7e3ab302
PE
4715 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4716 so that the caller can use some name other than gcpro1.
4717 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4718 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4719 (Fx_backspace_delete_keys_p):
4720 Use them to avoid shadowing, and rename vars to avoid shadowing.
4721 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4722 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4723 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4724 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4725 Remove unused locals.
7e3ab302
PE
4726 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4727 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4728 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4729 macros.
f78faa98 4730
e2b13473
PE
4731 * xterm.h (x_mouse_leave): New decl.
4732
77f23912
PE
4733 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4734 Remove unused functions.
cdf4ba58
PE
4735 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4736 (x_calc_absolute_position): Now static.
7411c686 4737 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4738 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4739 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4740 unless they are used.
38d0b34a
PE
4741 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4742 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4743 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4744 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4745 (x_error_catcher, x_connection_closed, x_error_handler):
4746 (x_error_quitter, xembed_send_message, x_iconify_frame):
4747 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4748 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4749 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4750
44f230aa
SM
4751 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4752 Rename or move locals to avoid shadowing.
6b463e58 4753 (tty_defined_color, merge_face_heights): Now static.
5967d051 4754 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4755 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4756 does not deduce is never used uninitialized.
73719eba
PE
4757 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4758 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4759
426994c3 4760 * terminal.c (store_terminal_param): Now static.
5489860b 4761
032f1620 4762 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4763 (set_frame_menubar): Remove unused local.
d4323972 4764 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4765 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4766 since they might point to immutable storage.
281585b0
PE
4767 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4768 since it's unused otherwise.
032f1620 4769
367c19e5 4770 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4771 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4772 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4773 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4774 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4775 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4776 does not deduce are never used uninitialized.
70739cbe 4777
07b48fa9
PE
4778 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4779
8868a238 4780 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4781 * window.c (window_loop, size_window):
4782 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4783
7e5cf297 4784 * window.c (display_buffer): Now static.
d6550a9f
PE
4785 (size_window): Mark variables that gcc -Wuninitialized
4786 does not deduce are never used uninitialized.
a586633d
PE
4787 * window.h (check_all_windows): New decl, to forestall
4788 gcc -Wmissing-prototypes diagnostic.
5b555da1 4789 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4790
f6095868
PE
4791 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4792 shadowing.
4793 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4794 Include <limits.h>.
4795 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4796 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4797 (load_charset_map): Mark variables that gcc -Wuninitialized
4798 does not deduce are never used uninitialized.
53df7c11 4799 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4800
f38b440c
PE
4801 * coding.c (coding_set_source, coding_set_destination):
4802 Use "else { /* comment */ }" rather than "else /* comment */;"
4803 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4804 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4805 a block, when the outer 'i' will do.
4806 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4807 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4808 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4809 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4810 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4811 Rename locals to avoid shadowing.
4812 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4813 * coding.c (emacs_mule_char, encode_invocation_designation):
4814 Now static, since they're not used elsewhere.
413bb2db 4815 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4816 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4817 (decode_coding_emacs_mule): Mark variables that gcc
4818 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4819 (detect_coding_iso_2022): Initialize a local variable that might
4820 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4821 this initialization is needed. (Bug#8211)
5f58e762
PE
4822 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4823 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4824 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4825 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4826 Remove unused macros.
f38b440c 4827
232b38b9 4828 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4829 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4830 * character.c (string_count_byte8): Likewise.
232b38b9 4831
fb90da1b
PE
4832 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4833 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4834
fb93dbc2
PE
4835 * chartab.c (copy_sub_char_table): Now static, since it's not used
4836 elsewhere.
5c156ace
PE
4837 (sub_char_table_ref_and_range, char_table_ref_and_range):
4838 Rename locals to avoid shadowing.
bbcd0949 4839 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4840
7d3b3862 4841 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4842 (BIDI_BOB): Remove unused macro.
7d3b3862 4843
6be7d3da
PE
4844 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4845 deduce are never used uninitialized.
c2ed9c8b 4846 * term.c (encode_terminal_code): Likewise.
6be7d3da 4847
75f8807f 4848 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4849
50938595
PE
4850 * tparam.h: New file.
4851 * term.c, tparam.h: Include it.
4852 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4853 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4854 Move these decls to tparam.h, and make them agree with what
4855 is actually in tparam.c. The previous trick of using incompatible
4856 decls in different modules does not conform to the C standard.
4857 All callers of tparam changed to use tparam's actual API.
4858 * tparam.c (tparam1, tparam, tgoto):
4859 Use const pointers where appropriate.
4860
fbceeba2
PE
4861 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4862 * cm.h (struct cm): Likewise.
4863 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4864 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4865 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4866 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4867 (turn_on_face, init_tty): Likewise.
4868 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4869
7f3f1250
PE
4870 * term.c (term_mouse_position): Rename local to avoid shadowing.
4871
e6ca6543
PE
4872 * alloc.c (mark_ttys): Move decl from here ...
4873 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4874
c40f8d15
AS
48752011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4876
4877 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4878
cfe0661d
JB
48792011-03-09 Juanma Barranquero <lekktu@gmail.com>
4880
4881 * search.c (compile_pattern_1): Remove argument regp, unused since
4882 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4883 (compile_pattern): Don't pass it.
4884
0afb4571
J
48852011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4886
4887 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4888 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4889 for ! HAVE_GTK3.
4890 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4891
4892 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4893
4894 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4895 gdk_window_get_screen, gdk_window_get_geometry,
4896 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4897 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4898 (xg_get_pixbuf_from_pixmap): New function.
4899 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4900 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4901 Call xg_get_pixbuf_from_pixmap instead of
4902 gdk_pixbuf_get_from_drawable.
4903 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4904 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4905 (xg_check_special_colors): Use GtkStyleContext and its functions
4906 for HAVE_GTK3.
4907 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4908 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4909 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4910 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4911 Call gtk_widget_get_preferred_size.
0afb4571
J
4912 (xg_frame_resized): gdk_window_get_geometry only takes 5
4913 parameters.
44f230aa
SM
4914 (xg_win_to_widget, xg_event_is_for_menubar):
4915 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4916 (xg_set_widget_bg): New function.
4917 (delete_cb): New function.
895009e1 4918 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4919 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4920 (xg_set_background_color): Call xg_set_widget_bg.
4921 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4922 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4923 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4924 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4925 if ! HAVE_GTK3.
4926 (update_frame_tool_bar): Call gtk_widget_hide.
4927 (xg_initialize): Use GDK_KEY_g.
4928
4929 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4930 if ! HAVE_GTK3
4931 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4932
4933 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4934 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4935 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4936
1c2cc4ef
JB
49372011-03-08 Juanma Barranquero <lekktu@gmail.com>
4938
4939 * w32xfns.c (select_palette): Check success of RealizePalette against
4940 GDI_ERROR, not zero.
4941
33383987 4942See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4943
4944;; Local Variables:
4945;; coding: utf-8
aac0c6e3
MR
4946;; End:
4947
33383987 4948 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4949
4950 This file is part of GNU Emacs.
4951
4952 GNU Emacs is free software: you can redistribute it and/or modify
4953 it under the terms of the GNU General Public License as published by
4954 the Free Software Foundation, either version 3 of the License, or
4955 (at your option) any later version.
4956
4957 GNU Emacs is distributed in the hope that it will be useful,
4958 but WITHOUT ANY WARRANTY; without even the implied warranty of
4959 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4960 GNU General Public License for more details.
4961
4962 You should have received a copy of the GNU General Public License
4963 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.