Move clipboard-manager functionality out of hooks.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1dd3c2d9
CY
12011-05-29 Chong Yidong <cyd@stupidchicken.com>
2
3 * xselect.c (x_clipboard_manager_save_frame)
4 (x_clipboard_manager_save_all): New functions.
5 (Fx_clipboard_manager_save): Lisp function deleted.
6
7 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9
10 * xterm.h: Update prototype.
11
5ba6571d
WX
122011-05-28 William Xu <william.xwl@gmail.com>
13
14 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
15 exiting (Bug#8239).
16
3eaff834
JM
172011-05-28 Jim Meyering <meyering@redhat.com>
18
e1900994 19 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
20 * fns.c (to_uchar): Define.
21 (crypto_hash_function): Use it to convert some newly-signed
22 variables to unsigned, to avoid sign-extension bugs. For example,
23 without this change, (md5 "truc") would evaluate to
24 45723a2aff78ff4fff7fff1114760e62 rather than the expected
25 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 26 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 27
0f6990a7
PE
282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
29
30 Integer overflow fixes.
c8a9ca5a 31
08686060
PE
32 * dbusbind.c: Serial number integer overflow fixes.
33 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
34 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
35 to hold a serial number that is too large for a fixnum.
36 (Fdbus_method_return_internal, Fdbus_method_error_internal):
37 Check for serial numbers out of range. Decode any serial number
59568bf0 38 that was so large that it became a float. (Bug#8722)
08686060 39
2d1fc3c7
PE
40 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
41 (Fdbus_call_method, Fdbus_call_method_asynchronously):
42 Use XFASTINT rather than XUINT when numbers are nonnegative.
43 (xd_append_arg, Fdbus_method_return_internal):
44 (Fdbus_method_error_internal): Likewise. Also, for unsigned
45 arguments, check that Lisp number is nonnegative, rather than
59568bf0 46 silently wrapping negative numbers around. (Bug#8722)
30217ff0 47 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 48 (Bug#8722)
2d1fc3c7 49
c8a9ca5a
PE
50 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
51
519e1d69
PE
52 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
53
30569699
PE
54 ccl: add integer overflow checks
55 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
56 (IN_INT_RANGE): New macros.
57 (ccl_driver): Use them to check for integer overflow when
58 decoding a CCL program. Many of the new checks are whether XINT (x)
59 fits in int; it doesn't always, on 64-bit hosts. The new version
60 doesn't catch all possible integer overflows, but it's an
847044ea 61 improvement. (Bug#8719)
30569699 62
c11285dc
PE
63 * alloc.c (make_event_array): Use XINT, not XUINT.
64 There's no need for unsigned here.
65
fdccd48e
PE
66 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
67 This follows up to the 2011-05-06 change that substituted uintptr_t
68 for EMACS_INT. This case wasn't caught back then.
69
37910ab2
PE
70 Rework Fformat to avoid integer overflow issues.
71 * editfns.c: Include <float.h> unconditionally, as it's everywhere
72 now (part of C89). Include <verify.h>.
73 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
74 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
75 (Fformat): Avoid the prepass trying to compute sizes; it was only
76 approximate and thus did not catch overflow reliably. Instead, walk
77 through the format just once, formatting and computing sizes as we go,
78 checking for integer overflow at every step, and allocating a larger
79 buffer as needed. Keep track separately whether the format is
80 multibyte. Keep only the most-recently calculated precision, rather
81 than them all. Record whether each argument has been converted to
82 string. Use EMACS_INT, not int, for byte and char and arg counts.
83 Support field widths and precisions larger than INT_MAX. Avoid
84 sprintf's undefined behavior with conversion specifications such as %#d
85 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
86 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
87 formatting out-of-range floating point numbers with int
88 formats. (Bug#8668)
89
2e6578fb
PE
90 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
91
0ae6bdee
PE
92 * data.c: Avoid integer truncation in expressions involving floats.
93 * data.c: Include <intprops.h>.
94 (arith_driver): When there's an integer overflow in an expression
95 involving floating point, convert the integers to floating point
96 so that the resulting value does not suffer from catastrophic
97 integer truncation. For example, on a 64-bit host (* 4
98 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
99 Do not rely on undefined behavior after integer overflow.
100
de883a70
PE
101 merge count_size_as_multibyte, parse_str_to_multibyte
102 * character.c, character.h (count_size_as_multibyte):
103 Renamed from parse_str_to_multibyte; all uses changed.
104 Check for integer overflow.
105 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
106 since it's now a duplicate of the other. This is more of
107 a character than a buffer op, so better that it's in character.c.
108 * fns.c, print.c: Adjust to above changes.
109
2ff916cb
PE
1102011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
111
112 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
113
f1b54466
PE
1142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
115
fb1ac845
PE
116 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
117 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
118 (x_clipboard_manager_save): Now static.
119 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
120
f1b54466
PE
121 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
122 (crypto_hash_function): Now static.
123 Fix pointer signedness problems. Avoid unnecessary initializations.
124
a9f737ee
CY
1252011-05-27 Chong Yidong <cyd@stupidchicken.com>
126
127 * termhooks.h (Vselection_alist): Make it terminal-local.
128
129 * terminal.c (create_terminal): Initialize it.
130
131 * xselect.c: Support for clipboard managers.
132 (Vselection_alist): Move to termhooks.h as terminal-local var.
133 (LOCAL_SELECTION): New macro.
134 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
135 (symbol_to_x_atom): Remove gratuitous arg.
136 (x_handle_selection_request, lisp_data_to_selection_data)
137 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
138 (x_own_selection, x_get_local_selection, x_convert_selection): New
139 arg, specifying work frame. Use terminal-local Vselection_alist.
140 (some_frame_on_display): Delete unused function.
141 (Fx_own_selection_internal, Fx_get_selection_internal)
142 (Fx_disown_selection_internal, Fx_selection_owner_p)
143 (Fx_selection_exists_p): New optional frame arg.
144 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
145 (x_handle_selection_clear): Don't treat other terminals with the
146 same keyboard specially. Use the terminal-local Vselection_alist.
147 (x_clear_frame_selections): Use Frun_hook_with_args.
148
149 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
150
151 * xterm.h: Add support for those atoms.
152
e067f0c1
CY
1532011-05-26 Chong Yidong <cyd@stupidchicken.com>
154
155 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
156 (converted_selections, conversion_fail_tag): New global variables.
157 (x_selection_request_lisp_error): Free the above.
158 (x_get_local_selection): Remove unnecessary code.
159 (x_reply_selection_request): Args changed; handle arbitrary array
160 of converted selections stored in converted_selections. Separate
161 the XChangeProperty and SelectionNotify steps.
162 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
163 (x_convert_selection): New function.
164 (x_handle_selection_event): Simplify.
165 (x_get_foreign_selection): Don't ignore incoming requests while
166 waiting for an answer; this will fail when we implement
167 SAVE_TARGETS, and seems unnecessary anyway.
168 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
169 (Vx_sent_selection_functions): Doc fix.
170
0f4aebc0
LL
1712011-05-26 Leo Liu <sdl.web@gmail.com>
172
173 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
174
e61124cd
YM
1752011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
176
177 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
178
179 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
180 for fringe update if it has periodic bitmap.
181 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
182 and fringe_bitmap_periodic_p.
183
184 * fringe.c (get_fringe_bitmap_data): New function.
185 (draw_fringe_bitmap_1, update_window_fringes): Use it.
186 (update_window_fringes): Record periodicity of fringe bitmap in glyph
187 row. Mark glyph row for fringe update if periodicity changed.
188
189 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
190 for fringe update unless it has periodic bitmap.
191
f16d9837
KH
1922011-05-25 Kenichi Handa <handa@m17n.org>
193
194 * xdisp.c (get_next_display_element): Set correct it->face_id for
195 a static composition.
196
e1b90ef6
LL
1972011-05-24 Leo Liu <sdl.web@gmail.com>
198
199 * deps.mk (fns.o):
200 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
201
202 * fns.c (crypto_hash_function, Fsha1): New function.
203 (Fmd5): Use crypto_hash_function.
204 (syms_of_fns): Add Ssha1.
205
7400048f
PE
2062011-05-22 Paul Eggert <eggert@cs.ucla.edu>
207
208 * gnutls.c: Remove unused macros.
209 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
210 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
211 Remove macros that are defined and never used.
212 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
213
abb71cf4
CY
2142011-05-22 Chong Yidong <cyd@stupidchicken.com>
215
216 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
217 (Fx_get_selection_internal): Minor cleanup.
218 (Fx_own_selection_internal): Rename arguments for consistency with
219 select.el.
220
6307db39
PE
2212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
222
223 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
224
f3d4e0a4
CY
2252011-05-22 Chong Yidong <cyd@stupidchicken.com>
226
227 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
228
4d8ade89
YM
2292011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
230
231 * dispnew.c (scrolling_window): Don't exclude the case that the
232 last enabled row in the desired matrix touches the bottom boundary.
233
32078c8d
GM
2342011-05-21 Glenn Morris <rgm@gnu.org>
235
236 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
237 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
238 and add some more files.
32078c8d 239
7285dc67
EZ
2402011-05-20 Eli Zaretskii <eliz@gnu.org>
241
242 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
243 report_file_error introduced by the change from 2011-05-07.
244
89d1bd22
PE
2452011-05-20 Paul Eggert <eggert@cs.ucla.edu>
246
247 * systime.h (Time): Define only if emacs is defined.
248 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
249 where the include path doesn't have X11/X.h by default. See
250 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
251
e23640bb 2522011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
253
254 * composite.c (find_automatic_composition): Fix previous change.
255
b9704ad9
GM
2562011-05-20 Glenn Morris <rgm@gnu.org>
257
258 * lisp.mk: New file, split from Makefile.in.
259 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
260 (shortlisp): Remove.
261 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
262
4a720484
GM
2632011-05-19 Glenn Morris <rgm@gnu.org>
264
265 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
266 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
267 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
268 (lisp): Set the order to that of loadup.el.
269 (shortlisp): Make it a copy of $lisp.
270 (SOME_MACHINE_LISP): Remove.
271 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
272 Use just $shortlisp, not $SOME_MACHINE_LISP too.
273
a28d4396
KH
2742011-05-18 Kenichi Handa <handa@m17n.org>
275
276 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
277 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
278 (find_automatic_composition): Mostly rewrite for efficiency.
279
a2b1fa8e
JB
2802011-05-18 Juanma Barranquero <lekktu@gmail.com>
281
282 * makefile.w32-in: Update dependencies.
283
8e1f5610
CS
2842011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
285
286 * menu.c: Include limits.h (fixes the MS-Windows build broken by
287 revision 104625).
288
7025ee00 2892011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 290
cdfa6eab
PE
291 Fix some integer overflow issues, such as string length overflow.
292
06d6db33
PE
293 * insdel.c (count_size_as_multibyte): Check for string overflow.
294
2b4560a8
PE
295 * character.c (lisp_string_width): Check for string overflow.
296 Use EMACS_INT, not int, for string indexes and lengths; in
297 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
298 the resulting string length overflows an EMACS_INT; instead,
299 report a string overflow if no precision given. When checking for
300 precision exhaustion, use a check that cannot possibly have
301 integer overflow. (Bug#8675)
302 * character.h (lisp_string_width): Adjust to new signature.
303
cb93f9be
PE
304 * alloc.c (string_overflow): New function.
305 (Fmake_string): Use it. This doesn't change behavior, but saves
306 a few bytes and will simplify future changes.
307 * character.c (string_escape_byte8): Likewise.
308 * lisp.h (string_overflow): New decl.
309
1a1f3366
PE
310 Fixups, following up to the user-interface timestamp change.
311 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
312 for UI timestamps, instead of unsigned long.
9fbd6841
PE
313 * msdos.c (mouse_get_pos): Likewise.
314 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
315 * w32gui.h (Time): Define by including "systime.h" rather than by
316 declaring it ourselves. (Bug#8664)
317
d4e3e4d3
PE
318 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
319 * image.c (clear_image_cache): Likewise.
320
f6a24d19
PE
321 * term.c (term_mouse_position): Don't assume time_t wraparound.
322
08dc5ae6
PE
323 Be more systematic about user-interface timestamps.
324 Before, the code sometimes used 'Time', sometimes 'unsigned long',
325 and sometimes 'EMACS_UINT', to represent these timestamps. This
326 change causes it to use 'Time' uniformly, as that's what X uses.
327 This makes the code easier to follow, and makes it easier to catch
328 integer overflow bugs such as Bug#8664.
329 * frame.c (Fmouse_position, Fmouse_pixel_position):
330 Use Time, not unsigned long, for user-interface timestamps.
331 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
332 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
333 * keyboard.h (last_event_timestamp): Likewise.
334 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
335 * menu.h (xmenu_show): Likewise.
336 * term.c (term_mouse_position): Likewise.
337 * termhooks.h (struct input_event.timestamp): Likewise.
338 (struct terminal.mouse_position_hook): Likewise.
339 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
340 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
341 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
342 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
343 what it was before.
344 * menu.h, termhooks.h: Include "systime.h", for Time.
345
8e55734a
PE
346 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
347 Don't assume that the difference between two unsigned long values
348 can fit into an integer. At this point, we know button_down_time
349 <= event->timestamp, so the difference must be nonnegative, so
350 there's no need to cast the result if double-click-time is
351 nonnegative, as it should be; check that it's nonnegative, just in
352 case. This bug is triggered when events are more than 2**31 ms
86db42d2 353 apart (about 25 days). (Bug#8664)
8e55734a 354
841f1b75 355 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 356 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 357
3e26f69c
PE
358 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
359 that always fit in int. Use a sentinel instead of a counter, to
360 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
361 * frame.h (struct frame): Use int for menu_bar_items_used
362 instead of EMACS_INT, since it always fits in int.
3e26f69c 363
5cc152c0
PE
364 * menu.c (grow_menu_items): Check for int overflow.
365
d89eb65e
PE
366 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
367
5235bd3e
PE
368 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
369 Before, the code was not consistent. These values cannot exceed
370 2**31 - 1 so there's no need to make them unsigned.
371 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
372 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
373 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
374 as modifiers.
375 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
376
bc827e23
PE
377 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
378 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
379 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
380 presumably because the widths might not match.
381
78eb494e
PE
382 * window.c (size_window): Avoid needless test at loop start.
383
04f2d78b
CB
3842011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
385
386 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
387
d2fc7e3d 3882011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
389
390 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
391
d2fc7e3d 3922011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
393
394 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
395 `width' to `bar_area_x' and `bar_area_width', respectively.
396 (x_scroll_run): Take account of fringe background extension.
397
04f2d78b
CB
398 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
399 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
400 `bar_area_width', respectively.
401 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
402 background extension.
403
79b70037
GM
4042011-05-10 Jim Meyering <meyering@redhat.com>
405
406 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
407
2f142cc5
JB
4082011-05-10 Juanma Barranquero <lekktu@gmail.com>
409
410 * image.c (Finit_image_library): Return t for built-in image types,
411 like pbm and xbm. (Bug#8640)
412
57679c86
AS
4132011-05-09 Andreas Schwab <schwab@linux-m68k.org>
414
415 * w32menu.c (set_frame_menubar): Fix submenu allocation.
416
888c9e86
EZ
4172011-05-07 Eli Zaretskii <eliz@gnu.org>
418
b0512a1d
EZ
419 * w32console.c (Fset_screen_color): Doc fix.
420 (Fget_screen_color): New function.
421 (syms_of_ntterm): Defsubr it.
422
7285dc67
EZ
423 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
424 unlink the temporary file if Fcall_process didn't create it in the
425 first place.
426 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
427 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
428 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
429 cue to call_process_cleanup not to close that handle.
430
4d3fcc8e
BK
4312011-05-07 Ben Key <bkey76@gmail.com>
432
433 * makefile.w32-in: The bootstrap-temacs rule now makes use of
434 one of two shell specific rules, either bootstrap-temacs-CMD or
435 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
436 to the previous implementation of the bootstrap-temacs rule.
437 The bootstrap-temacs-CMD rule is similar to the previous
438 implementation of the bootstrap-temacs rule except that it
439 makes use of the ESC_CFLAGS variable instead of the CFLAGS
440 variable.
441
442 These changes, along with some changes to nt/configure.bat,
443 nt/gmake.defs, and nt/nmake.defs, are required to extend my
444 earlier fix to add support for --cflags and --ldflags options
445 that include quotes so that it works whether make uses cmd or
446 sh as the shell.
447
b4289b64
MA
4482011-05-06 Michael Albinus <michael.albinus@gmx.de>
449
450 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
451 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
452 is a constant.
453 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
454 a string. Handle both cases.
455 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
456 (Fdbus_register_method): Use Qinvalid_function.
457
af4c0e28
JB
4582011-05-06 Juanma Barranquero <lekktu@gmail.com>
459
460 * makefile.w32-in: Update dependencies.
461 (LISP_H): Add inttypes.h and stdin.h.
462 (PROCESS_H): Add unistd.h.
463
c51453d9
EZ
4642011-05-06 Eli Zaretskii <eliz@gnu.org>
465
466 * lread.c: Include limits.h (fixes the MS-Windows build broken by
467 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
468
8ff0ac3c 4692011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 470
4c4b566b
PE
471 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
472
aab2b9b5
PE
473 * term.c (vfatal): Remove stray call to va_end.
474 It's not needed and the C Standard doesn't allow it here anyway.
475
c378da0b
PE
476 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
477 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
478
288b08c7
PE
479 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
480 bytes.
481
e3601888
PE
482 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
483
db6c0e74
PE
484 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
485
dd5963ea
PE
486 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
487
88c9450f
PE
488 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
489
2f9442b8
PE
490 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
491
c032b5f8
PE
492 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
493 * charset.c (Fdefine_charset_internal): Don't initialize
494 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 495 32-bit int (Bug#8600).
a108c10b
PE
496
497 * lread.c (read_integer): Be more consistent with string-to-number.
498 Use string_to_number to do the actual conversion; this avoids
499 rounding errors and fixes some other screwups. Without this fix,
500 for example, #x1fffffffffffffff was misread as -2305843009213693952.
501 (digit_to_number): Move earlier, for benefit of read_integer.
502 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 503 not a digit in any supported base. (Bug#8602)
a108c10b 504
ad5f9eea
PE
505 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
506
aec1708a
PE
507 * dispnew.c (scrolling_window): Return 1 if we scrolled,
508 to match comment at start of function. This also removes a
509 GCC warning about overflow in a 32+64-bit port.
510
47be4ab5
PE
511 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
512
371cac43
PE
513 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
514 Reported by Stefan Monnier in
515 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
516 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
517 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 518
d01a7826
PE
519 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
520 (EMACS_UINTPTR): Likewise, with uintptr_t.
521
7fd47d5c
PE
522 * lisp.h: Prefer 64-bit EMACS_INT if available.
523 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
524 on 32-bit hosts that have 64-bit int, so that they can access
525 large files.
122b0c86
PE
526 However, temporarily disable this change unless the temporary
527 symbol WIDE_EMACS_INT is defined.
7fd47d5c 528
8727937b
PE
529 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
530
8ac068ac
PE
531 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
532 This removes an assumption that EMACS_INT and long are the same
533 width as pointers. The assumption is true for Emacs porting targets
534 now, but we want to make other targets possible.
535 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
536 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
537 In the rest of the code, change types of integers that hold casted
538 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
539 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
540 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
541 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
542 No need to cast type when ORing.
543 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
544 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
545 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
546 assume EMACS_INT is the same width as char *.
547 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
548 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
549 Remove no-longer-needed casts.
550 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
551 (xg_tool_bar_help_callback, xg_make_tool_item):
552 Use EMACS_INTPTR to hold an integer
553 that will be cast to void *; this can avoid a GCC warning
554 if EMACS_INT is not the same width as void *.
555 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
556 * xdisp.c (display_echo_area_1, resize_mini_window_1):
557 (current_message_1, set_message_1):
558 Use a local to convert to proper width without a cast.
559 * xmenu.c (dialog_selection_callback): Likewise.
560
ede49d71
PE
561 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
562 Also, don't assume VALBITS / RAND_BITS is less than 5,
563 and don't rely on undefined behavior when shifting a 1 left into
564 the sign bit.
565 * lisp.h (get_random): Change signature to match.
566
2f30ecd0
PE
567 * lread.c (hash_string): Use size_t, not int, for hash computation.
568 Normally we prefer signed values; but hashing is special, because
569 it's better to use unsigned division on hash table sizes so that
570 the remainder is nonnegative. Also, size_t is the natural width
571 for hashing into memory. The previous code used 'int', which doesn't
572 retain enough info to hash well into very large tables.
573 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
574
2a866e7b
PE
575 * dbusbind.c: Don't possibly lose pointer info when converting.
576 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
577 Use XPNTR rather than XHASH, so that the high-order bits of
578 the pointer aren't lost when converting through void *.
579
51639eac
PE
580 * eval.c (Fautoload): Don't double-shift a pointer.
581
92394119
PE
582 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
583
dbdb9a7c
JB
5842011-05-06 Juanma Barranquero <lekktu@gmail.com>
585
586 * gnutls.c (DEF_GNUTLS_FN):
587 * image.c (DEF_IMGLIB_FN): Make function pointers static.
588
db7a0b4f
AS
5892011-05-05 Andreas Schwab <schwab@linux-m68k.org>
590
591 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
592 marker. (Bug#8610)
593
f7ff1b0f 5942011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
595
596 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
597 New version that can reserve upto 2GB of heap space.
598
f7ff1b0f 5992011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
600
601 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
602
639c109b
TZ
6032011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
604
605 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
606 `gnutls_certificate_set_x509_key_file'.
607
d2127135
JB
6082011-05-05 Juanma Barranquero <lekktu@gmail.com>
609
610 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
611 Update dependencies.
612
e968f4f3
JB
6132011-05-04 Juanma Barranquero <lekktu@gmail.com>
614
615 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
616 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
617 Remove unused parameter `fildes'.
618 * process.c (read_process_output, send_process): Don't pass it.
619
84d358f0
JB
6202011-05-04 Juanma Barranquero <lekktu@gmail.com>
621
622 Fix previous change: the library cache is defined in w32.c.
623 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
624 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
625
0898ca10
JB
6262011-05-04 Juanma Barranquero <lekktu@gmail.com>
627
628 Implement dynamic loading of GnuTLS on Windows.
629
630 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
631 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
632 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
633 Declare.
634
635 * gnutls.c (Qgnutls_dll): Define.
636 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
637 (gnutls_*): Declare function pointers.
638 (init_gnutls_functions): New function to initialize function pointers.
639 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
640 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
641 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
642 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
643 (emacs_gnutls_write, emacs_gnutls_read)
644 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
645 (Fgnutls_available_p): New function.
646 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
647 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
648 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
649
650 * image.c: Include w32.h.
651 (Vimage_type_cache): Delete.
652 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
653 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
654 (w32_delayed_load): Move to w32.c.
655
656 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
657
658 * w32.c (QCloaded_from, Vlibrary_cache): Define.
659 (w32_delayed_load): Move from image.c. When loading a library, record
660 its filename in the :loaded-from property of the library id.
661 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
662 Initialize and staticpro them.
663 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
664
665 * process.c: Include lisp.h before w32.h, not after.
666 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
667 instead of gnutls_record_check_pending.
668
669 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
670
ff4de4aa
TZ
6712011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
672
673 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
674 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
675 as passed in.
676
abe95abb
JD
6772011-05-03 Jan Djärv <jan.h.d@swipnet.se>
678
679 * xterm.c (x_set_frame_alpha): Do not set property on anything
680 else than FRAME_X_OUTER_WINDOW (Bug#8608).
681
e16e55d4
JB
6822011-05-02 Juanma Barranquero <lekktu@gmail.com>
683
684 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
685
bafcf6a5
JB
6862011-05-02 Juanma Barranquero <lekktu@gmail.com>
687
688 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
689 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
690 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
691 (gnutls_global_initialized, Qgnutls_bootprop_priority)
692 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
693 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
694 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
695 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
696 (Qgnutls_bootprop_callbacks_verify): Make static.
697
e7a6747f
AS
6982011-05-01 Andreas Schwab <schwab@linux-m68k.org>
699
19ed11ba
AS
700 * callproc.c: Indentation fixup.
701
e7a6747f 702 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
703 (wait_for_termination, interruptible_wait_for_termination):
704 Move after wait_for_termination_1.
e7a6747f 705
1ef14cb4
LMI
7062011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
707
708 * sysdep.c (interruptible_wait_for_termination): New function
709 which is like wait_for_termination, but allows keyboard
710 interruptions.
711
712 * callproc.c (Fcall_process): Add (:file "file") as an option for
713 the STDOUT buffer.
714 (Fcall_process_region): Ditto.
715
330d880c
EZ
7162011-04-30 Eli Zaretskii <eliz@gnu.org>
717
8db90b73
EZ
718 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
719 rather than `XVECTOR (FOO)->size'.
720
330d880c
EZ
721 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
722 inttypes.h, as a gnulib replacement is used if it not available in
723 system headers.
724
15cbd324
EZ
7252011-04-21 Eli Zaretskii <eliz@gnu.org>
726
727 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
728 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
729 of MOST_POSITIVE_FIXNUM. (Bug#8528)
730
731 * coding.c (coding_alloc_by_realloc): Error out if destination
732 will grow beyond MOST_POSITIVE_FIXNUM.
733 (decode_coding_emacs_mule): Abort if there isn't enough place in
734 charbuf for the composition carryover bytes. Reserve an extra
735 space for up to 2 characters produced in a loop.
736 (decode_coding_iso_2022): Abort if there isn't enough place in
737 charbuf for the composition carryover bytes.
738
7392011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 740
ae940cca
EZ
741 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
742 aborting when %lld or %lll format is passed.
743 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
744 %llo or %llx format is passed. (Bug#8545)
745
03ab8921
EZ
746 * window.c (window_scroll_line_based): Use a marker instead of
747 simple variables to record original value of point. (Bug#7952)
748
afda1437
EZ
749 * doprnt.c (doprnt): Fix the case where a multibyte sequence
750 produced by %s or %c overflows available buffer space. (Bug#8545)
751
f76dee0c
PE
7522011-04-28 Paul Eggert <eggert@cs.ucla.edu>
753
754 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 755 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 756
fdc5744d
JB
7572011-04-28 Juanma Barranquero <lekktu@gmail.com>
758
759 * w32.c (init_environment): Warn about defaulting HOME to C:\.
760
638f053a
JB
7612011-04-28 Juanma Barranquero <lekktu@gmail.com>
762
763 * keyboard.c (Qdelayed_warnings_hook): Define.
764 (command_loop_1): Run `delayed-warnings-hook'
765 if Vdelayed_warnings_list is non-nil.
766 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
767 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
768
d178f871
EZ
7692011-04-28 Eli Zaretskii <eliz@gnu.org>
770
771 * doprnt.c (doprnt): Don't return value smaller than the buffer
772 size if the message was truncated. (Bug#8545).
773
b124fd93
JB
7742011-04-28 Juanma Barranquero <lekktu@gmail.com>
775
776 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
777 (Fx_window_property): #if-0 the whole functions, not just the bodies.
778
e810457d
PE
7792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
780
781 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
782
ea51cceb
JB
7832011-04-27 Juanma Barranquero <lekktu@gmail.com>
784
785 * makefile.w32-in: Update dependencies.
786
94dcfacf
EZ
7872011-04-27 Eli Zaretskii <eliz@gnu.org>
788
789 Improve `doprnt' and its usage. (Bug#8545)
790 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
791 `format_end'. Remove support for %l as a conversion specifier.
792 Don't use xrealloc. Improve diagnostics when the %l size modifier
793 is used. Update the commentary.
794
795 * eval.c (verror): Simplify calculation of size_t.
796
797 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
798 messages.
799
f61f41d7
PE
8002011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
801
802 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
803 change.
804
96fb4434
PE
8052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
806
807 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
808 This makes this file independent of the recent pseudovector change.
809
671875da 8102011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 811
69e9b5a3
PE
812 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
813
b5f869a7 814 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 815 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 816 Remove unused local.
c8926152 817 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 818
841a1577 819 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
820 GCC 4.6.0 optimizes based on type-based alias analysis.
821 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
822 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
823 != &v->size, and therefore "v->size = 1; b->size = 2; return
824 v->size;" must therefore return 1. This assumption is incorrect
825 for Emacs, since it type-puns struct Lisp_Vector * with many other
826 types. To fix this problem, this patch adds a new type struct
f904488f 827 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
828 and pseudovectors, and helps optimizing compilers not get fooled
829 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
830 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
831 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
832 the size member.
eab3844f
PE
833 (XSETPVECTYPE): Rewrite in terms of new macro.
834 (XSETPVECTYPESIZE): New macro, specifying both type and size.
835 This is a bit clearer, and further avoids the possibility of
836 undesirable aliasing.
837 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 838 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
839 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
840 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
841 (ASIZE): Now uses header.size rather than size.
842 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
843 to avoid the hassle of writing XVECTOR (foo)->header.size.
844 (struct vectorlike_header): New type.
eab3844f
PE
845 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
846 object, to help avoid aliasing.
847 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
848 (SUBRP): Likewise, since Lisp_Subr is a special case.
849 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
850 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
851 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 852 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
853 changed to be "header.size" and "header.next".
854 * buffer.h (struct buffer): Likewise.
855 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
856 * frame.h (struct frame): Likewise.
857 * process.h (struct Lisp_Process): Likewise.
858 * termhooks.h (struct terminal): Likewise.
859 * window.c (struct save_window_data, struct saved_window): Likewise.
860 * window.h (struct window): Likewise.
861 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
862 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
863 * buffer.c (init_buffer_once): Likewise.
864 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
865 special case.
866 * process.c (Fformat_network_address): Use local var for size,
867 for brevity.
868
0df1eac5
PE
869 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
870
847ab9d1 871 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
872 * data.c (atof): Remove decl; no longer used or needed.
873 (digit_to_number): Move to lread.c.
874 (Fstring_to_number): Use new string_to_number function, to be
875 consistent with how the Lisp reader treats infinities and NaNs.
876 Do not assume that floating-point numbers represent EMACS_INT
877 without losing information; this is not true on most 64-bit hosts.
878 Avoid double-rounding errors, by insisting on integers when
879 parsing non-base-10 numbers, as the documentation specifies.
880 * lisp.h (string_to_number): New decl, replacing ...
881 (isfloat_string): Remove.
bc0a5c13 882 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 883 (read1): Do not accept +. and -. as integers; this
452f4150
PE
884 appears to have been a coding error. Similarly, do not accept
885 strings like +-1e0 as floating point numbers. Do not report
886 overflow for integer overflows unless the base is not 10 which
887 means we have no simple and reliable way to continue.
888 Break out the floating-point parsing into a new
889 function string_to_number, so that Fstring_to_number parses
890 floating point numbers consistently with the Lisp reader.
04f2d78b 891 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
892 (E_CHAR, EXP_INT): Remove, replacing with ...
893 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
894 (string_to_number): New function, replacing isfloat_string.
895 This function checks for valid syntax and produces the resulting
896 Lisp float number too. Rework it so that string-to-number
bc0a5c13 897 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
898 so that overflow for non-base-10 numbers is reported only when
899 there's no portable and simple way to convert to floating point.
452f4150 900
67769ffc
PE
901 * textprop.c (set_text_properties_1): Rewrite for clarity,
902 and to avoid GCC warning about integer overflow.
903
c20db43f
PE
904 * intervals.h (struct interval): Use EMACS_INT for members
905 where EMACS_UINT might cause problems. See
906 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
907 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
908 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
909 All uses changed.
37aa2f85
PE
910 (offset_intervals): Tell GCC not to worry about length overflow
911 when negating a negative length.
c20db43f 912
2538aa2f
PE
913 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
914 (overrun_check_free): Likewise.
915
f2d3008d
PE
916 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
917 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
918 word size.
919
ec8df744
PE
920 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
921 (gnutls_make_error): Rename local to avoid shadowing.
922 (gnutls_emacs_global_deinit): ifdef out; not used.
923 (Fgnutls_boot): Use const for pointer to readonly storage.
924 Comment out unused local. Fix pointer signedness problems.
925
640ee02d
PE
926 * lread.c (openp): Don't stuff size_t into an 'int'.
927 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
928 about possible signed overflow.
929
6048fb2a
PE
930 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
931 (GDK_KEY_g): Don't define if already defined.
932 (xg_prepare_tooltip): Avoid pointer signedness problem.
933 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
934
fa3c87e1
PE
935 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
936 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
937
2172544b
PE
938 * xfns.c (Fx_window_property): Simplify a bit,
939 to make a bit faster and to avoid GCC 4.6.0 warning.
940 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
941
9b821a21
PE
942 * fns.c (internal_equal): Don't assume size_t fits in int.
943
3c616cfa
PE
944 * alloc.c (compact_small_strings): Tighten assertion a little.
945
c2982e87
PE
946 Replace pEd with more-general pI, and fix some printf arg casts.
947 * lisp.h (pI): New macro, generalizing old pEd macro to other
948 conversion specifiers. For example, use "...%"pI"d..." rather
949 than "...%"pEd"...".
950 (pEd): Remove. All uses replaced with similar uses of pI.
951 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
952 * alloc.c (check_pure_size): Don't overflow by converting size to int.
953 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
954 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
955 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
956 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
957 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
958 64-bit hosts.
959 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
960 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
961 * print.c (safe_debug_print, print_object): Likewise.
962 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
963 to int.
6f04d126
PE
964 Use pI instead of if-then-else-abort. Use %p to avoid casts,
965 avoiding the 0 flag, which is not portable.
c2982e87
PE
966 * process.c (Fmake_network_process): Use pI to avoid cast.
967 * region-cache.c (pp_cache): Likewise.
968 * xdisp.c (decode_mode_spec): Likewise.
969 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
970 behavior on 64-bit hosts with printf arg.
6f04d126 971 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
972 (x_stop_queuing_selection_requests): Likewise.
973 (x_get_window_property): Don't truncate byte count to an 'int'
974 when tracing.
0b432f21 975
5e073ec7
PE
976 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
977 here, since it parses constructs like leading '-' and spaces,
978 which are not wanted; and it overflows with large numbers.
979 Instead, simply match F[0-9]+, which is what is wanted anyway.
980
36372bf9
PE
981 * alloc.c: Remove unportable assumptions about struct layout.
982 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
983 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
984 (allocate_vectorlike, make_pure_vector): Use the new macros,
985 plus offsetof, to remove unportable assumptions about struct layout.
986 These assumptions hold on all porting targets that I know of, but
987 they are not guaranteed, they're easy to remove, and removing them
988 makes further changes easier.
989
0b432f21
PE
990 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
991 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
992 (string_overrun_cookie): Now const. Use initializers that
993 don't formally overflow signed char, to avoid warnings.
000098c1
PE
994 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
995 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
996 (allocate_buffer): Don't assume sizeof (struct buffer) is a
997 multiple of sizeof (EMACS_INT); it need not be, if
998 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 999 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1000
895009e1
JB
10012011-04-26 Juanma Barranquero <lekktu@gmail.com>
1002
1003 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1004
6a7a1b0b
TZ
10052011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1006
1007 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1008 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1009 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1010
841a1577 10112011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1012
1013 * lisp.h (Qdebug): List symbol.
895009e1 1014 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1015 * keyboard.c (debug-on-event): New variable.
1016 (handle_user_signal): Break into debugger when debug-on-event
1017 matches the current signal symbol.
1018
f2d3ba6f
DN
10192011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1020
1021 * alloc.c (check_sblock, check_string_bytes)
1022 (check_string_free_list): Convert to standard C.
1023
42ce4c63
TZ
10242011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1025
1026 * w32.c (emacs_gnutls_push): Fix typo.
1027
825cd63c
EZ
10282011-04-25 Eli Zaretskii <eliz@gnu.org>
1029
fb11d64d
EZ
1030 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1031 "cast to pointer from integer of different size".
1032
825cd63c
EZ
1033 Improve doprnt and its use in verror. (Bug#8545)
1034 * doprnt.c (doprnt): Document the set of format control sequences
1035 supported by the function. Use SAFE_ALLOCA instead of always
1036 using `alloca'.
1037
1038 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1039 is one byte too soon. Don't use xrealloc; instead xfree and
1040 xmalloc anew.
1041
e061a11b
TZ
10422011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1043
1044 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1045 callbacks stage.
1046
1047 * gnutls.c: Renamed global_initialized to
1048 gnutls_global_initialized. Added internals for the
1049 :verify-hostname-error, :verify-error, and :verify-flags
1050 parameters of `gnutls-boot' and documented those parameters in the
1051 docstring. Start callback support.
1052 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1053 unless a fatal error occured. Call gnutls_alert_send_appropriate
1054 on error. Return error code.
1055 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1056 (emacs_gnutls_read): Likewise.
1057 (Fgnutls_boot): Return handshake error code.
1058 (emacs_gnutls_handle_error): New function.
1059 (wsaerror_to_errno): Likewise.
1060
1061 * w32.h (emacs_gnutls_pull): Add prototype.
1062 (emacs_gnutls_push): Likewise.
1063
1064 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1065 (emacs_gnutls_push): Likewise.
1066
10672011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1068
1069 * process.c (wait_reading_process_output): Check if GnuTLS
1070 buffered some data internally if no FDs are set for TLS
1071 connections.
1072
1073 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1074 (LIBS): Link to USER_LIBS.
1075 ($(BLD)/gnutls.$(0)): New target.
1076
fa6996bc
EZ
10772011-04-24 Eli Zaretskii <eliz@gnu.org>
1078
eb35682e
EZ
1079 * xdisp.c (handle_single_display_spec): Rename the
1080 display_replaced_before_p argument into display_replaced_p, to
1081 make it consistent with the commentary. Fix typos in the
1082 commentary.
1083
e2ad650c
EZ
1084 * textprop.c (syms_of_textprop): Remove dead code.
1085 (copy_text_properties): Delete obsolete commentary about an
1086 interface that was deleted long ago. Fix typos in the description
1087 of arguments.
1088
1b2de274
EZ
1089 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1090 to changes in oldXMenu/XMenu.h from 2011-04-16.
1091 <menu_help_message, prev_menu_help_message>: Constify.
1092 (IT_menu_make_room): menu->help_text is now `const char **';
1093 adjust.
1094
1095 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1096 to changes in oldXMenu/XMenu.h from 2011-04-16.
1097 (struct XMenu): Declare `help_text' `const char **'.
1098
1099 * xfaces.c <Qunspecified>: Make extern again.
1100
1101 * syntax.c: Include sys/types.h before including regex.h, as
1102 required by Posix.
1103
762b15be
EZ
1104 * doc.c (get_doc_string): Improve the format passed to `error'.
1105
1106 * doprnt.c (doprnt): Improve commentary.
1107
1108 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1109
1110 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1111 them with etags.
1112
f1052e5d
EZ
1113 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1114 changes in globals.h immediately force recompilation.
762b15be
EZ
1115 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1116 $(CURDIR)/s/ms-w32.h.
1117 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1118
fa6996bc
EZ
1119 * character.c (Fchar_direction): Function deleted.
1120 (syms_of_character): Don't defsubr it.
1121 <char-direction-table>: Deleted.
1122
e6c3da20
EZ
11232011-04-23 Eli Zaretskii <eliz@gnu.org>
1124
1125 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1126 * doprnt.c: Include limits.h.
1127 (SIZE_MAX): New macro.
04f2d78b
CB
1128 (doprnt): Return a size_t value. 2nd arg is now size_t.
1129 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1130 Improve overflow protection. Support `l' modifier for integer
1131 conversions. Support %l conversion. Don't assume an EMACS_INT
1132 argument for integer conversions and for %c.
1133
1134 * lisp.h (doprnt): Restore prototype.
1135
1136 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1137 $(SRC)/character.h.
1138
1139 * Makefile.in (base_obj): Add back doprnt.o.
1140
1141 * deps.mk (doprnt.o): Add back prerequisites.
1142 (callint.o): Depend on character.h.
1143
1144 * eval.c (internal_lisp_condition_case): Include the handler
1145 representation in the error message.
1146 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1147 when breaking from the loop.
1148
1149 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1150
1151 * callint.c (Fcall_interactively): When displaying error message
1152 about invalid control letter, pass the character's codepoint, not
1153 a pointer to its multibyte form. Improve display of the character
1154 in octal and display also its hex code.
1155
1156 * character.c (char_string): Use %x to display the (unsigned)
1157 codepoint of an invalid character, to avoid displaying a bogus
1158 negative value.
1159
1160 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1161 `error', not SYMBOL_NAME itself.
1162
1163 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1164 character arguments to `error'.
1165
1166 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1167 to `error' in error message about FINAL_CHAR argument. Make sure
1168 FINAL_CHAR is a character, and use %c when it is passed as
1169 argument to `error'.
1170
4ffd0d6b 11712011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1172
1173 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1174
1175 * w32.c: Include <time.h>.
1176 (sys_localtime): New function.
1177
4ffd0d6b 11782011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1179
1180 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1181
4ffd0d6b 1182 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1183
4ffd0d6b 11842011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1185
4ffd0d6b
GM
1186 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1187 zombies (Bug#8467).
aac0c6e3 1188
04c56954
EZ
11892011-04-19 Eli Zaretskii <eliz@gnu.org>
1190
1191 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1192 gl_state.e_property when gl_state.object is Qt.
1193
1194 * insdel.c (make_gap_larger): Remove limitation of buffer size
1195 to <= INT_MAX.
1196
16a43933
CY
11972011-04-18 Chong Yidong <cyd@stupidchicken.com>
1198
1199 * xdisp.c (lookup_glyphless_char_display)
1200 (produce_glyphless_glyph): Handle cons cell entry in
1201 glyphless-char-display.
1202 (Vglyphless_char_display): Document it.
1203
1204 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1205 glyphless-char-display.
1206
4581706e
CY
12072011-04-17 Chong Yidong <cyd@stupidchicken.com>
1208
1209 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1210
1211 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1212
1213 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1214 definition for no-X builds.
1215
4887c6e2 12162011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1217
fd35b6f9
PE
1218 Static checks with GCC 4.6.0 and non-default toolkits.
1219
5c1ccb01
PE
1220 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1221
006c5daa
PE
1222 * process.c (keyboard_bit_set): Define only if SIGIO.
1223 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1224 (send_process): Repair possible setjmp clobbering.
1225
efc736d3
PE
1226 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1227
4e2fe2e6
PE
1228 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1229
f97334a2
PE
1230 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1231
4e75f29d
PE
1232 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1233 Define only if needed.
1234
90efadd1
PE
1235 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1236 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1237 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1238
3c647824
PE
1239 * dispextern.h (struct redisplay_interface): Rename param
1240 to avoid shadowing.
e264f262 1241 * termhooks.h (struct terminal): Likewise.
761383f4 1242 * xterm.c (xembed_send_message): Likewise.
3c647824 1243
b58c5c4a
PE
1244 * insdel.c (make_gap_smaller): Define only if
1245 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1246
cad59032
PE
1247 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1248 it.
1249
c339dc2e
PE
1250 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1251 so that we aren't warned about unused symbols.
1252
91a3e27b
PE
1253 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1254
399c71d3 1255 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1256
8ffc96f5
PE
1257 * xfns.c (x_real_positions): Mark locals as initialized.
1258
eef9bc79
PE
1259 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1260
098db9dd
PE
1261 * xterm.c: Fix problems found by static analysis with other toolkits.
1262 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1263 (x_dispatch_event): Declare static if USE_GTK, and
1264 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1265 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1266 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1267 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1268 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1269
eb18f6cc
PE
1270 * xmenu.c (menu_help_callback): Pointer type fixes.
1271 Use const pointers when pointing at readonly data. Avoid pointer
1272 signedness clashes.
1273 (FALSE): Remove unused macro.
1274 (update_frame_menubar): Remove unused decl.
1275
1fe72bf8
PE
1276 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1277
60d9e1db
PE
1278 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1279 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1280 (single_menu_item): Rename local to avoid shadowing.
1281
39261c26
PE
1282 * keyboard.c (make_lispy_event): Remove unused local var.
1283
018c5e19
PE
1284 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1285 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1286
63d2b86e
PE
1287 * bitmaps: Change bitmaps from unsigned char back to the X11
1288 compatible char. Avoid the old compiler warnings about
1289 out-of-range initializers by using, for example, '\xab' rather
1290 than 0xab.
1291
aefd87e1
PE
1292 * xgselect.c (xgselect_initialize): Check vs interface
1293 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1294
bf501fb9
PE
1295 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1296
e9829fdf
PE
1297 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1298 to read-only memory.
1299
1086c095
PE
1300 * fns.c (vector): Remove; this old hack is no longer needed.
1301
2baccd04 1302 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1303 Remove unused var.
dde42981 1304 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1305
72391843 1306 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1307
436c16df 1308 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1309 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1310 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1311
92bb796d 1312 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1313 (x_term_init): Remove local to avoid shadowing.
92bb796d 1314
764430a3 1315 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1316
1317 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1318 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1319
d1dfb56c
EZ
13202011-04-16 Eli Zaretskii <eliz@gnu.org>
1321
c4354cb4
EZ
1322 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1323
d1dfb56c
EZ
1324 Fix regex.c, syntax.c and friends for buffers > 2GB.
1325 * syntax.h (struct gl_state_s): Declare character position members
1326 EMACS_INT.
1327
1328 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1329
04f2d78b
CB
1330 * textprop.c (verify_interval_modification, interval_of):
1331 Declare arguments EMACS_INT.
d1dfb56c
EZ
1332
1333 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1334 EMACS_INT.
1335
1336 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1337
1338 * indent.c (Fvertical_motion): Local variable it_start is now
1339 EMACS_INT.
1340
1341 * regex.c (re_match, re_match_2, re_match_2_internal)
1342 (bcmp_translate, regcomp, regexec, print_double_string)
1343 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1344 (re_compile_pattern, re_exec): Declare arguments and local
1345 variables `size_t' and `ssize_t' and return values `regoff_t', as
1346 appropriate.
1347 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1348 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1349 <compile_stack_type>: `size' and `avail' are now `size_t'.
1350
1351 * regex.h <regoff_t>: Use ssize_t, not int.
1352 (re_search, re_search_2, re_match, re_match_2): Arguments that
1353 specify buffer/string position and length are now ssize_t and
1354 size_t. Return type is regoff_t.
1355
613052cd
BK
13562011-04-16 Ben Key <bkey76@gmail.com>
1357
1358 * nsfont.m: Fixed bugs in ns_get_family and
1359 ns_descriptor_to_entity that were caused by using free to
1360 deallocate memory blocks that were allocated by xmalloc (via
1361 xstrdup). This caused Emacs to crash when compiled with
1362 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1363 --enable-checking=xmallocoverrun). xfree is now used to
1364 deallocate these memory blocks.
1365
4170f62f 13662011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1367
71b41406
PE
1368 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1369
9587a89d
PE
1370 emacs_write: Accept and return EMACS_INT for sizes.
1371 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1372 et seq.
1373 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1374 Accept and return EMACS_INT.
1375 (emacs_gnutls_write): Return the number of bytes written on
1376 partial writes.
1377 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1378 (emacs_read, emacs_write): Remove check for negative size, as the
1379 Emacs source code has been audited now.
9587a89d
PE
1380 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1381 (emacs_read, emacs_write): Use it.
273a5f82
PE
1382 * process.c (send_process): Adjust to the new signatures of
1383 emacs_write and emacs_gnutls_write. Do not attempt to store
1384 a byte offset into an 'int'; it might overflow.
9587a89d 1385 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1386
3e047f51
PE
1387 * sound.c: Don't assume sizes fit in 'int'.
1388 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1389 Return EMACS_INT, not int.
3e047f51 1390 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1391 Accept EMACS_INT, not int.
1392 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1393 record read return values.
1394
cc39a9db
BK
13952011-04-15 Ben Key <bkey76@gmail.com>
1396
c9d0ec6d
JB
1397 * keyboard.c (Qundefined): Don't declare static since it is used
1398 in nsfns.m.
1399 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1400 static since they are used in nsfont.m.
cc39a9db 1401
6c60eb9f
SM
14022011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1403
1404 * process.c (Qprocessp): Don't declare static.
1405 * lisp.h (Qprocessp): Declare again.
1406
7990b61a
JB
14072011-04-15 Juanma Barranquero <lekktu@gmail.com>
1408
1409 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1410
5d4cb038
PE
14112011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1412
8bd7b830 1413 Improve C-level modularity by making more things 'static'.
cd64ea1d 1414
e3b27b31
PE
1415 Don't publish debugger-only interfaces to other modules.
1416 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1417 (verify_bytepos, count_markers): Move decls to the only modules
1418 that need them.
1419 * region-cache.h (pp_cache): Likewise.
1420 * window.h (check_all_windows): Likewise.
1421 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1422
5d4cb038
PE
1423 * sysdep.c (croak): Now static, if
1424 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1425 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1426
1427 * alloc.c (refill_memory_reserve): Now static if
1428 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1429 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1430
e87b6180
PE
1431 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1432 Define only if USE_LUCID.
1433
ac64929e
PE
1434 * xrdb.c (x_customization_string, x_rm_string): Now static.
1435
6f37259d
PE
1436 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1437 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1438
1683e3ab
PE
1439 * xdisp.c (draw_row_with_mouse_face): Now static.
1440 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1441
de9c2632
PE
1442 * window.h (check_all_windows): Mark externally visible.
1443
2b96acb7
PE
1444 * window.c (window_deletion_count): Now static.
1445
1446 * undo.c: Make symbols static if they're not exported.
1447 (last_undo_buffer, last_boundary_position, pending_boundary):
1448 Now static.
1449
50436f33
PE
1450 * textprop.c (interval_insert_behind_hooks): Now static.
1451 (interval_insert_in_front_hooks): Likewise.
1452
64520e5c
PE
1453 * term.c: Make symbols static if they're not exported.
1454 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1455 (max_frame_lines, tty_set_terminal_modes):
1456 (tty_reset_terminal_modes, tty_turn_off_highlight):
1457 (get_tty_terminal): Now static.
1458 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1459 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1460 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1461 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1462 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1463
1fa53021
PE
1464 * sysdep.c: Make symbols static if they're not exported.
1465 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1466 Now static.
1467 (sigprocmask_set, full_mask): Remove; unused.
1468 (wait_debugging): Mark as visible.
1469 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1470 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1471
d4b43b22
PE
1472 * syntax.c (syntax_temp): Define only if !__GNUC__.
1473
b7c513d0
PE
1474 * sound.c (current_sound_device, current_sound): Now static.
1475
989b29ad
PE
1476 * search.c (searchbufs, searchbuf_head): Now static.
1477
13a55a78
PE
1478 * scroll.c (scroll_cost): Remove; unused.
1479 * dispextern.h (scroll_cost): Remove decl.
1480
de68a1fc
PE
1481 * region-cache.h (pp_cache): Mark as externally visible.
1482
40ccffa6
PE
1483 * process.c: Make symbols static if they're not exported.
1484 (process_tick, update_tick, create_process, chan_process):
1485 (Vprocess_alist, proc_buffered_char, datagram_access):
1486 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1487 (deactivate_process): Mark defn as static, as well as decl.
1488 * lisp.h (create_process): Remove decl.
1489 * process.h (chan_process, Vprocess_alist): Remove decls.
1490
ad64fc97
PE
1491 * print.c: Make symbols static if they're not exported.
1492 (print_depth, new_backquote_output, being_printed, print_buffer):
1493 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1494 (print_interval, print_number_index, initial_stderr_stream):
1495 Now static.
1496 * lisp.h (Fprinc): Remove decl.
1497 (debug_output_compilation_hack): Mark as externally visible.
1498
adddb265
PE
1499 * sysdep.c (croak): Move decl from here to syssignal.h.
1500 * syssignal.h (croak): Put it here, so the API can be checked when
1501 'croak' is called from dissociate_if_controlling_tty.
1502
1717ede2
PE
1503 * minibuf.c: Make symbols static if they're not exported.
1504 (minibuf_save_list, choose_minibuf_frame): Now static.
1505 * lisp.h (choose_minibuf_frame): Remove decl.
1506
fa5fb2bc
PE
1507 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1508
1e3890d1
PE
1509 * lread.c: Make symbols static if they're not exported.
1510 (read_objects, initial_obarray, oblookup_last_bucket_number):
1511 Now static.
1512 (make_symbol): Remove; unused.
1513 * lisp.h (initial_obarray, make_symbol): Remove decls.
1514
8a1414fa
PE
1515 * keyboard.c: Make symbols static if they're not exported.
1516 (single_kboard, recent_keys_index, total_keys, recent_keys):
1517 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1518 (this_single_command_key_start, echoing, last_auto_save):
1519 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1520 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1521 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1522 (Vlispy_mouse_stem, double_click_count):
1523 Now static.
1524 (force_auto_save_soon): Define only if SIGDANGER.
1525 (ignore_mouse_drag_p): Now static if
1526 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1527 (print_help): Remove; unused.
1528 (stop_character, last_timer_event): Mark as externally visible.
1529 * keyboard.h (ignore_mouse_drag_p): Declare only if
1530 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1531 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1532 * lisp.h (echoing): Remove decl.
1533 (force_auto_save_soon): Declare only if SIGDANGER.
1534 * xdisp.c (redisplay_window): Simplify code, to make it more
1535 obvious that ignore_mouse_drag_p is not accessed if !defined
1536 USE_GTK && !defined HAVE_NS.
1537
93ea6e8f
PE
1538 * intervals.c: Make symbols static if they're not exported.
1539 (merge_properties_sticky, merge_interval_right, delete_interval):
1540 Now static.
1541 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1542
77382fcc
PE
1543 * insdel.c: Make symbols static if they're not exported.
1544 However, leave prepare_to_modify_buffer alone. It's never
1545 called from outside this function, but that appears to be a bug.
1546 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1547 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1548 (adjust_after_replace_noundo): Remove; unused.
1549 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1550 (signal_before_change): Remove decls.
77382fcc 1551
9306c32e
PE
1552 * indent.c (val_compute_motion, val_vmotion): Now static.
1553
cd44d2eb
PE
1554 * image.c: Make symbols static if they're not exported.
1555 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1556 if USE_GTK.
1557 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1558 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1559
ad9a7a06
PE
1560 * fringe.c (standard_bitmaps): Now static.
1561 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1562
81626931
PE
1563 * frame.c: Make symbols static if they're not exported.
1564 (x_report_frame_params, make_terminal_frame): Now static.
1565 (get_frame_param): Now static, unless HAVE_NS.
1566 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1567 (x_get_resource_string): Remove; not used.
1568 * frame.h (make_terminal_frame, x_report_frame_params):
1569 (x_get_resource_string); Remove decls.
1570 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1571 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1572
239f9db9
PE
1573 * font.c, fontset.c: Make symbols static if they're not exported.
1574 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1575 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1576 * font.c (font_close_object): Now static.
1577 * font.h (font_close_object): Remove.
1578 * fontset.c (FONTSET_OBJLIST): Remove.
1579 (free_realized_fontset) #if-0 the body, which does nothing.
1580 (face_suitable_for_char_p): #if-0, as it's never called.
1581 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1582 * xfaces.c (face_at_string_position):
1583 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1584 since 0 is always ASCII.
1585
dfcf3579
PE
1586 * fns.c (weak_hash_tables): Now static.
1587
5045092b
PE
1588 * fileio.c: Make symbols static if they're not exported.
1589 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1590 (Vwrite_region_annotation_buffers): Now static.
1591
57a96f5c
PE
1592 * eval.c: Make symbols static if they're not exported.
1593 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1594 * lisp.h (backtrace_list): Remove decl.
1595
35f08c38
PE
1596 * emacs.c: Make symbols static if they're not exported.
1597 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1598 (fatal_error_code, fatal_error_signal_hook, standard_args):
1599 Now static.
1600 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1601 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1602 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1603 * lisp.h (fatal_error_signal_hook): Remove decl.
1604 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1605
f44bd759
PE
1606 * editfns.c: Move a (normally-unused) function to its only use.
1607 * editfns.c, lisp.h (get_operating_system_release): Remove.
1608 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1609 worth the hassle of breaking this out.
1610
b532497d
PE
1611 * xterm.c: Make symbols static if they're not exported.
1612 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1613 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1614 (x_destroy_window, x_delete_display):
1615 Now static.
1616 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1617 (x_mouse_leave): Remove; unused.
1618 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1619 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1620 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1621 Remove decls.
1622 (x_mouse_leave): Declare only if WINDOWSNT.
1623 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1624 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1625 USE_X_TOOLKIT.
1626
1675728f
PE
1627 * ftxfont.c: Make symbols static if they're not exported.
1628 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1629 HAVE_FREETYPE.
1630 * font.h (ftxfont_driver): Likewise.
1631
e4cebfca
PE
1632 * xfns.c: Make symbols static if they're not exported.
1633 (x_last_font_name, x_display_info_for_name):
1634 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1635 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1636 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1637 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1638 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1639 (last_show_tip_args): Now static.
1640 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1641 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1642 (x_screen_planes): Remove; unused.
1643 * dispextern.h (x_screen_planes): Remove decl.
1644
5bf46f05
PE
1645 * dispnew.c: Make symbols static if they're not exported.
1646 * dispextern.h (redraw_garbaged_frames, scrolling):
1647 (increment_row_positions): Remove.
1648 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1649 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1650 Now static.
1651 (redraw_garbaged_frames): Remove; unused.
1652
435f4c28
PE
1653 * xfaces.c: Make symbols static if they're not exported.
1654 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1655 Remove decls.
1656 * xterm.h (defined_color): Remove decls.
1657 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1658 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1659 (menu_face_changed_default, defined_color, free_realized_face):
1660 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1661 (ascii_face_of_lisp_face): Remove; unused.
1662
8524aef3
PE
1663 * xdisp.c: Make symbols static if they're not exported.
1664 * dispextern.h (scratch_glyph_row, window_box_edges):
1665 (glyph_to_pixel_coords, set_cursor_from_row):
1666 (get_next_display_element, set_iterator_to_next):
1667 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1668 (show_mouse_face): Remove decls
1669 * frame.h (message_buf_print): Likewise.
1670 * lisp.h (pop_message, set_message, check_point_in_composition):
1671 Likewise.
1672 * xterm.h (set_vertical_scroll_bar): Likewise.
1673 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1674 (message_buf_print, scratch_glyph_row, displayed_buffer):
1675 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1676 (get_next_display_element, show_mouse_face, window_box_edges):
1677 (frame_to_window_pixel_xy, check_point_in_composition):
1678 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1679 (glyph_to_pixel_coords): Remove; unused.
1680
16390cd2
PE
1681 * dired.c (file_name_completion): Now static.
1682
1683 * dbusbind.c (xd_in_read_queued_messages): Now static.
1684
a25f4dfa
PE
1685 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1686 * data.c (circular_list_error): Remove.
1687
14a9c8df
PE
1688 * commands.h (last_point_position, last_point_position_buffer):
1689 (last_point_position_window): Remove decls.
1690 * keyboard.c: Make these variables static.
1691
04f2d78b
CB
1692 * coding.h (coding, code_convert_region, encode_coding_gap):
1693 Remove decls.
74ab6df5
PE
1694 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1695 (iso_code_class, detect_coding, code_convert_region): Now static.
1696 (encode_coding_gap): Remove; unused.
1697
38dfbee1
PE
1698 * chartab.c (chartab_chars, chartab_bits): Now static.
1699
a2cb4e63
PE
1700 * charset.h (charset_iso_8859_1): Remove decl.
1701 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1702 Now static.
1703
127198fd
PE
1704 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1705 * ccl.c (Vccl_program_table): Now static.
1706 (check_ccl_update): Remove; unused.
1707
d85b608f
PE
1708 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1709 * category.h: ... from here.
1710 * category.c (check_category_table, set_category_set): Now static.
1711
31cd66f3
PE
1712 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1713 * lisp.h: Remove these decls.
1714
c358e587
PE
1715 * buffer.c (buffer_count): Remove unused var.
1716
e78aecca
PE
1717 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1718 so that it's not optimized away.
1719 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1720 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1721 exported only to the debugger.
1722
e192d7d3 1723 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1724 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1725
92470028
PE
1726 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1727 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1728 was inaccessible from Lisp.
1729 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1730 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1731
244ed907
PE
1732 alloc.c: Import and export fewer symbols, and remove unused items.
1733 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1734 is defined.
1735 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1736 it's not optimized away by whole-program optimization.
1737 (message_enable_multibyte, free_misc): Remove.
1738 (catchlist, handlerlist, mark_backtrace):
1739 Declare only if BYTE_MARK_STACK.
1740 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1741 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1742 (message_enable_multibyte): Remove decl.
1743 (free_misc, interval_free_list, float_block, float_block_index):
1744 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1745 (cons_free_list, last_marked_index):
1746 Now static.
1747 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1748 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1749 (mark_backtrace): Define only if BYTE_MARK_STACK.
1750 * xdisp.c (message_enable_multibyte): Now static.
1751
61c2b50e 1752 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1753 This makes it easier for human readers (and static analyzers)
1754 to see whether these variables are used from other modules.
1755 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1756 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1757 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1758 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1759 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1760 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1761 * xmenu.c, xselect.c:
1762 Declare Q* vars static if they are not used in other modules.
1763 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1764 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1765 Remove decls of unexported vars.
1766 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1767
95c82688
PE
1768 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1769
16a97296
PE
1770 Make Emacs functions such as Fatom 'static' by default.
1771 This makes it easier for human readers (and static analyzers)
1772 to see whether these functions can be called from other modules.
1773 DEFUN now defines a static function. To make the function external
1774 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1775 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1776 (Finit_image_library):
16a97296
PE
1777 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1778 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1779 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1780 Remove decls, since these functions are now static.
1781 (Funintern, Fget_internal_run_time): New decls, since these functions
1782 were already external.
95c82688 1783
16a97296
PE
1784 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1785 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1786 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1787 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1788 * keyboard.c, keymap.c, lread.c:
1789 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1790 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1791 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1792 Mark functions with DEFUE instead of DEFUN,
1793 if they are used in other modules.
1794 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1795 decls for now-static functions.
1796 * buffer.h (Fdelete_overlay): Remove decl.
1797 * callproc.c (Fgetenv_internal): Mark as internal.
1798 * composite.c (Fremove_list_of_text_properties): Remove decl.
1799 (Fcomposition_get_gstring): New forward static decl.
1800 * composite.h (Fcomposite_get_gstring): Remove decl.
1801 * dired.c (Ffile_attributes): New forward static decl.
1802 * doc.c (Fdocumntation_property): New forward static decl.
1803 * eval.c (Ffetch_bytecode): New forward static decl.
1804 (Funintern): Remove extern decl; now in .h file where it belongs.
1805 * fileio.c (Fmake_symbolic_link): New forward static decl.
1806 * image.c (Finit_image_library): New forward static decl.
1807 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1808 * intervals.h (Fprevious_property_change):
1809 (Fremove_list_of_text_properties): Remove decls.
1810 * keyboard.c (Fthis_command_keys): Remove decl.
1811 (Fcommand_execute): New forward static decl.
1812 * keymap.c (Flookup_key): New forward static decl.
1813 (Fcopy_keymap): Now static.
1814 * keymap.h (Flookup_key): Remove decl.
1815 * process.c (Fget_process): New forward static decl.
1816 (Fprocess_datagram_address): Mark as internal.
1817 * syntax.c (Fsyntax_table_p): New forward static decl.
1818 (skip_chars): Remove duplicate decl.
1819 * textprop.c (Fprevious_property_change): New forward static decl.
1820 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1821 Now internal.
1822 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1823 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1824
785bbd42
PE
1825 * editfns.c (Fformat): Remove unreachable code.
1826
8b913b57
AS
18272011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1828
1829 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1830 change. (Bug#8496)
1831
a6744a35
EZ
18322011-04-13 Eli Zaretskii <eliz@gnu.org>
1833
1834 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1835 when at ZV. (Bug#8487)
1836
e7974947
AS
18372011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1838
baad03f0
AS
1839 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1840 (Bug#8437)
1841 * keyboard.c (parse_tool_bar_item): Likewise.
1842 * sound.c (sound_cleanup, alsa_close): Likewise.
1843 * termcap.c (tgetent): Likewise.
1844 * xfns.c (x_default_font_parameter): Likewise.
1845 * xsettings.c (read_and_apply_settings): Likewise.
1846
e7974947
AS
1847 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1848 (overrun_check_free): Protoize.
1849
28272684
PE
18502011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1853 since callers should never pass a negative size.
1854 Change the signature to match that of plain 'read' and 'write'; see
1855 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1856 * lisp.h: Update prototypes of emacs_write and emacs_read.
1857
11997c76
EZ
18582011-04-11 Eli Zaretskii <eliz@gnu.org>
1859
1860 * xdisp.c (redisplay_window): Don't try to determine the character
1861 position of the scroll margin if the window start point w->startp
e896f03c 1862 is outside the buffer's accessible region. (Bug#8468)
11997c76 1863
8a2cbd72
EZ
18642011-04-10 Eli Zaretskii <eliz@gnu.org>
1865
1866 Fix write-region and its subroutines for buffers > 2GB.
1867 * fileio.c (a_write, e_write): Modify declaration of arguments and
1868 local variables to support buffers larger than 2GB.
1869 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1870
1871 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1872 argument, local variables, and return value.
1873
1874 * lisp.h: Update prototypes of emacs_write and emacs_read.
1875
1876 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1877
4073e537 18782011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1879
1ebfdcb6
PE
1880 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1881
b2ded58d
PE
1882 Fix more problems found by GCC 4.6.0's static checks.
1883
7d66342c
PE
1884 * xdisp.c (vmessage): Use a better test for character truncation.
1885
bbf47d44
PE
1886 * charset.c (load_charset_map): <, not <=, for optimization,
1887 and to avoid potential problems with integer overflow.
9248994d 1888 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1889 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1890 * editfns.c (Fformat): Likewise.
1e69125e 1891 * syntax.c (skip_chars): Likewise.
3befa583 1892
e3019616
PE
1893 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1894 This also lets GCC 4.6.0 generate slightly better loop code.
1895
becfa255
PE
1896 * callint.c (Fcall_interactively): <, not <=, for optimization.
1897 (Fcall_interactively): Count the number of arguments produced,
1898 not the number of arguments given. This is simpler and lets GCC
1899 4.6.0 generate slightly better code.
1900
dae0cd48
PE
1901 * ftfont.c: Distingish more carefully between FcChar8 and char.
1902 The previous code passed unsigned char * to a functions like
1903 strlen and xstrcasecmp that expect char *, which does not
1904 conform to the C standard.
1905 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1906 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1907 char * when the C standard requires it.
1908
76032d70
PE
1909 * keyboard.c (read_char): Remove unused var.
1910
eb3f1cc8
PE
1911 * eval.c: Port to Windows vsnprintf (Bug#8435).
1912 Include <limits.h>.
1913 (SIZE_MAX): Define if the headers do not.
1914 (verror): Do not give up if vsnprintf returns a negative count.
1915 Instead, grow the buffer. This ports to Windows vsnprintf, which
1916 does not conform to C99. Problem reported by Eli Zaretskii.
1917 Also, simplify the allocation scheme, by avoiding the need for
1918 calling realloc, and removing the ALLOCATED variable.
1919
70476b54
PE
1920 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1921
12020a9e
PE
1922 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1923 But keep the doprint source code for now, as we might revamp it
1924 and use it again (Bug#8435).
ea6c7ae6
PE
1925 * lisp.h (doprnt): Remove.
1926 * Makefile.in (base_obj): Remove doprnt.o.
1927 * deps.mk (doprnt.o): Remove.
1928
5fdb398c
PE
1929 error: Print 32- and 64-bit integers portably (Bug#8435).
1930 Without this change, on typical 64-bit hosts error ("...%d...", N)
1931 was used to print both 32- and 64-bit integers N, which relied on
1932 undefined behavior.
1933 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1934 New macro.
1935 * lisp.h (error, verror): Mark as printf-like functions.
1936 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1937 Report overflow in size calculations when allocating printf buffer.
1938 Do not truncate output string at its first null byte.
1939 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1940 Truncate the output at a character boundary, since vsnprintf does not
1941 do that.
1942 * charset.c (check_iso_charset_parameter): Convert internal
1943 character to string before calling 'error', since %c now has the
1944 printf meaning.
1945 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1946 overflow when computing char to be passed to 'error'. Do not
1947 pass Lisp_Object to 'error'; pass the integer instead.
1948 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1949 formatted with plain %d.
1950
b189fa66
PE
1951 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1952
bff87ef0
PE
1953 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1954
7e2cac20
PE
1955 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1956
ce4d90b5
PE
1957 * xterm.c (x_catch_errors): Remove duplicate declaration.
1958
266c9547
PE
1959 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1960
79c49ad2
PE
1961 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1962
368f4090
JM
19632011-04-10 Jim Meyering <meyering@redhat.com>
1964
1965 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1966 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1967 return ssize_t not "int", and use size_t as the buffer length.
1968 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1969 * gnutls.h: Update declarations.
1970 * process.c (read_process_output): Use ssize_t, to match.
1971 (send_process): Likewise.
1972
a32d4040
CY
19732011-04-09 Chong Yidong <cyd@stupidchicken.com>
1974
1975 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1976
8546720e 19772011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1978
04f2d78b
CB
1979 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1980 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1981
8546720e
GM
1982 * xterm.c (handle_one_xevent):
1983 * xmenu.c (create_and_show_popup_menu):
1984 * xselect.c (x_decline_selection_request)
1985 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1986
0a2f5c1a 19872011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1988
1989 Fix some uses of `int' instead of EMACS_INT.
1990 * search.c (string_match_1, fast_string_match)
1991 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1992 (scan_buffer, find_next_newline_no_quit)
1993 (find_before_next_newline, search_command, Freplace_match)
1994 (Fmatch_data): Make some `int' variables be EMACS_INT.
1995
1996 * xdisp.c (display_count_lines): 3rd argument and return value now
1997 EMACS_INT. All callers changed.
1998 (pint2hrstr): Last argument is now EMACS_INT.
1999
2000 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2001 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2002 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2003 (decode_coding_utf_16, decode_coding_emacs_mule)
2004 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2005 (decode_coding_ccl, decode_coding_charset)
2006 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2007 (decode_coding_iso_2022, decode_coding_emacs_mule)
2008 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2009 <char_offset, last_offset>: Declare EMACS_INT.
2010 (encode_coding_utf_8, encode_coding_utf_16)
2011 (encode_coding_emacs_mule, encode_invocation_designation)
2012 (encode_designation_at_bol, encode_coding_iso_2022)
2013 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2014 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2015 Declare EMACS_INT.
2016 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2017 (encode_invocation_designation): Last argument P_NCHARS is now
2018 EMACS_INT.
2019 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2020 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2021
2022 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2023 All users changed.
2024
2025 * ccl.c (Fccl_execute_on_string): Declare some variables
2026 EMACS_INT.
2027
8546720e 20282011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2029
2030 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2031
4e19a977
CS
20322011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2033
2034 * process.c (Fformat_network_address): Doc fix.
2035
87302331
R
20362011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2037
2038 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2039
cbb59342
CY
20402011-04-08 Chong Yidong <cyd@stupidchicken.com>
2041
2042 * keyboard.c (read_char): Call Lisp function help-form-show,
2043 instead of using internal_with_output_to_temp_buffer.
2044 (Qhelp_form_show): New var.
e0d38eeb 2045 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2046
2047 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2048
2049 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2050
e67a13ab
CY
20512011-04-06 Chong Yidong <cyd@stupidchicken.com>
2052
04f2d78b
CB
2053 * process.c (Flist_processes): Remove to Lisp.
2054 (list_processes_1): Delete.
e67a13ab 2055
973f782d
EZ
20562011-04-06 Eli Zaretskii <eliz@gnu.org>
2057
7c106b1e
EZ
2058 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2059
973f782d
EZ
2060 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2061
41cf7d1a 20622011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2063
ca23cc88
PE
2064 Fix more problems found by GCC 4.6.0's static checks.
2065
f390e2d5
PE
2066 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2067
42eea0d0
PE
2068 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2069
b69769da 2070 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2071
f9541e84
PE
2072 * xdisp.c (vmessage): Mark as a printf-like function.
2073
13841b55
PE
2074 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2075
c136c10f
PE
2076 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2077
5e2d4a30
PE
2078 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2079 printf-like functions.
2080 (tiff_load): Add casts to remove these marks before passing them
2081 to system-supplied API.
2082
583f48b9
PE
2083 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2084
b25d760e
PE
2085 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2086 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2087 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2088 directly, rather than having caller test rule sign. This avoids
2089 some unnecessary tests.
2090 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2091 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2092 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2093
bc7b6697 2094 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2095 (xfont_open): Avoid unnecessary tests.
bc7b6697 2096
27ccc379
PE
2097 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2098
dcd5c89a
PE
2099 * composite.h, composite.c (composition_gstring_put_cache):
2100 Use EMACS_INT, not int, for length.
2101
b13a45c6
PE
2102 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2103 breaking out part of COMPOSITION_DECODE_RULE.
2104 (COMPOSITION_DECODE_RULE): Use it.
2105 * composite.c (get_composition_id): Remove unused local vars,
2106 by using the new macro.
2107
1e792e4d
PE
2108 * textprop.c (set_text_properties_1): Change while to do-while,
2109 since the condition is always true at first.
2110
dc6c6455 2111 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2112 (interval_deletion_adjustment): Return unsigned value.
2113 All uses changed.
dc6c6455 2114
aba7731a
PE
2115 * process.c (list_processes_1, create_pty, read_process_output):
2116 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2117 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2118 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2119 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2120 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2121
fdfc4bf3
PE
2122 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2123
fca8fe46 2124 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2125 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2126
06a0259a 2127 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2128 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2129 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2130
e7b9e80f
PE
2131 * print.c (print_error_message): Avoid int overflow.
2132
56201685
PE
2133 * font.c (font_list_entities): Redo for clarity,
2134 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2135
78834453 2136 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2137 (font_score): Avoid potential overflow in diff calculation.
78834453 2138
0bc0b309 2139 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2140 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2141
e610eaca
PE
2142 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2143
b895abce
PE
2144 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2145 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2146 can always succeed if overflow has undefined behavior.
2147
1f1d9321 2148 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2149 (wordify): Omit three unnecessary tests.
1f1d9321 2150
c59478bc
PE
2151 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2152 All callers changed. This avoids the need for an unused var.
2153
79b73827
PE
2154 * casefiddle.c (casify_region): Remove var that is set but not used.
2155
a4db5dfe
PE
2156 * dired.c (file_name_completion): Remove var that is set but not used.
2157
43aae36e
PE
2158 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2159
2a47c44d 2160 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2161 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2162
a37c69bf
PE
2163 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2164 Check for integer overflow on size calculations.
2165
328ab8e7
PE
2166 * buffer.c (Fprevious_overlay_change): Remove var that is set
2167 but not used.
2168
e5a2a5cb
PE
2169 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2170 Remove vars that are set but not used.
8d84a6eb 2171 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2172 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2173
a60e5f68
PE
2174 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2175
f661cb61 2176 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2177 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2178
f0397f5a
PE
2179 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2180 that are set but not used.
2181
8664db06 2182 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2183 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2184
6abdaa4a
PE
2185 * xselect.c (x_get_local_selection, x_handle_property_notify):
2186 Remove vars that are set but not used.
2187
0ce7538d 2188 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2189 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2190
9ae848fc
PE
2191 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2192 Remove var that is set but not used.
0b918413
PE
2193 (scroll_bar_windows_size): Now size_t, not int.
2194 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2195 Check for overflow.
9ae848fc 2196
a5a62657
PE
2197 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2198 (map_tty_color) [!defined MSDOS]: Likewise.
2199
5c5cdd39
PE
2200 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2201
66ebf983
PE
2202 * coding.c: Remove vars that are set but not used.
2203 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2204 All callers changed.
2205 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2206 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2207 (decode_coding_charset): Remove vars that are set but not used.
2208
1be4d761
PE
2209 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2210 that is set but not used.
2211
47553fa8
PE
2212 * print.c (print_object): Remove var that is set but not used.
2213
1f7196bf 2214 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2215 The gnulib version avoids calling malloc in the usual case,
2216 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2217 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2218 * filelock.c (current_lock_owner): Likewise.
2219 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2220 * sysdep.c: Include allocator.h, careadlinkat.h.
2221 (emacs_no_realloc_allocator): New static constant.
2222 (emacs_readlink): New function.
fdb61804
PE
2223 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2224 ../lib/careadlinkat.h.
d1fdcab7 2225
f84c17c7
SM
22262011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2227
2228 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2229 first non-nil return value).
2230
ef3862ad
JD
22312011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2232
2233 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2234 if not defined (Bug#8403).
2235
376a7006
JB
22362011-04-02 Juanma Barranquero <lekktu@gmail.com>
2237
2238 * xdisp.c (display_count_lines): Remove parameter `start',
2239 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2240 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2241 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2242 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2243 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2244 and thereabouts. All callers changed.
2245 (get_per_char_metric): Remove parameter `f', unused since
2246 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2247
6ca3801d
JM
22482011-04-02 Jim Meyering <meyering@redhat.com>
2249
2250 do not dereference NULL upon failed strdup
2251 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2252 (ns_get_family): Likewise.
2253
d8e2b5ba
JB
22542011-04-02 Juanma Barranquero <lekktu@gmail.com>
2255
2256 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2257
8c74fcbd
JD
22582011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2259
2260 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2261 later (Bug#8403).
2262
7200d79c
SM
22632011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2264
03408648 2265 Add lexical binding.
7200d79c 2266
03408648
SM
2267 * window.c (Ftemp_output_buffer_show): New fun.
2268 (Fsave_window_excursion):
2269 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2270
2271 * lread.c (lisp_file_lexically_bound_p): New function.
2272 (Fload): Bind Qlexical_binding.
2273 (readevalloop): Remove `evalfun' arg.
2274 Bind Qinternal_interpreter_environment.
2275 (Feval_buffer): Bind Qlexical_binding.
2276 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2277 Mark as dynamic.
2278 (syms_of_lread): Declare `lexical-binding'.
2279
2280 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2281
2282 * keyboard.c (eval_dyn): New fun.
2283 (menu_item_eval_property): Use it.
ca105506
SM
2284
2285 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2286
03408648
SM
2287 * fns.c (concat, mapcar1): Accept byte-code-functions.
2288
2289 * eval.c (Fsetq): Handle lexical vars.
2290 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2291 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2292 (FletX, Flet): Obey lexical binding.
2293 (Fcommandp): Handle closures.
2294 (Feval): New `lexical' arg.
2295 (eval_sub): New function extracted from Feval. Use it almost
2296 everywhere where Feval was used. Look up vars in lexical env.
2297 Handle closures.
2298 (Ffunctionp): Move from subr.el.
2299 (Ffuncall): Handle closures.
2300 (apply_lambda): Remove `eval_flags'.
2301 (funcall_lambda): Handle closures and new byte-code-functions.
2302 (Fspecial_variable_p): New function.
2303 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2304 but without exporting it to Lisp.
23aba0ea 2305
23aba0ea 2306 * doc.c (Fdocumentation, store_function_docstring):
03408648 2307 * data.c (Finteractive_form): Handle closures.
23aba0ea 2308
03408648
SM
2309 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2310 interactive spec.
ba83908c 2311
04f2d78b
CB
2312 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2313 New byte-codes.
03408648
SM
2314 (exec_byte_code): New function extracted from Fbyte_code to handle new
2315 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2316
03408648 2317 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2318
03408648 2319 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2320
e2abce01
JB
23212011-03-31 Juanma Barranquero <lekktu@gmail.com>
2322
2323 * xdisp.c (redisplay_internal): Fix prototype.
2324
63696a73 23252011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2326
63696a73 2327 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2328 (try_scrolling): Use it when setting scroll_limit.
2329 Limit scrolling to 100 screen lines.
63696a73
EZ
2330 (redisplay_window): Even when falling back on "recentering",
2331 position point in the window according to scroll-conservatively,
2332 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2333
2334 (try_scrolling): When point is above the window, allow searching
2335 as far as scroll_max, or one screenful, to compute vertical
2336 distance from PT to the scroll margin position. This prevents
2337 try_scrolling from unnecessarily failing when
2338 scroll-conservatively is set to a value slightly larger than the
2339 window height. Clean up the case of PT below the margin at bottom
2340 of window: scroll_max can no longer be INT_MAX. When aggressive
2341 scrolling is in use, don't let point enter the opposite scroll
2342 margin as result of the scroll.
2343 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2344 threshold of 100 lines for never-recentering scrolling.
2345
e4cc2dfc
JB
23462011-03-31 Juanma Barranquero <lekktu@gmail.com>
2347
2348 * dispextern.h (move_it_by_lines):
2349 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2350 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2351 (message_log_check_duplicate): Remove parameters `prev_bol' and
2352 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2353 (redisplay_internal): Remove parameter `preserve_echo_area',
2354 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2355
2356 * indent.c (Fvertical_motion):
2357 * window.c (window_scroll_pixel_based, Frecenter):
2358 Don't pass `need_y_p' to `move_it_by_lines'.
2359
1c470562
SM
23602011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2361
44f230aa
SM
2362 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2363 steal a few bits to be more compact.
2364 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2365 Remove unneeded casts.
2366
1c470562
SM
2367 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2368
888adce9
ZK
23692011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2370
2371 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2372 binding" message (bug#7967).
2373
f838ed7b
PE
23742011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2375
77861b95
PE
2376 Fix more problems found by GCC 4.6.0's static checks.
2377
de6dbc14
PE
2378 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2379 Remove unused local var.
2380
f838ed7b
PE
2381 * editfns.c (Fmessage_box): Remove unused local var.
2382
792c7b2b
PE
2383 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2384 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2385 Omit unused local vars.
c499e557 2386 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2387 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2388 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2389 Omit unused local var.
2390
ba0165e1
PE
2391 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2392 Don't assume string length fits in int.
32ad8845 2393 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2394 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2395
3c59b4c9
PE
2396 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2397 instead of alloca (Bug#8344).
2398
a3eed478 2399 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2400 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2401
eb4d412d
PE
2402 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2403
1658b401
PE
2404 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2405 concerns.
2406
2407 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2408
2409 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2410
9a2c6e05
PE
2411 * keyboard.c (syms_of_keyboard): Use the same style as later
2412 in this function when indexing through an array. This also
2413 works around GCC bug 48267.
2414
03d0a109
PE
2415 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2416
44f730c8
PE
2417 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2418
fe75f926
PE
2419 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2420 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2421
ffa8c828
PE
2422 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2423 This avoids undefined behavior on integer overflow, and is a bit
2424 more convenient anyway since it is compared to a size_t variable.
2425
c5101a77
PE
2426 Variadic C functions now count arguments with size_t, not int.
2427 This avoids an unnecessary limitation on 64-bit machines, which
2428 caused (substring ...) to crash on large vectors (Bug#8344).
2429 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2430 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2431 All variadic functions and their callers changed accordingly.
c5101a77
PE
2432 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2433 * data.c (arith_driver, float_arith_driver): Likewise.
2434 * editfns.c (general_insert_function): Likewise.
2435 * eval.c (struct backtrace.nargs, interactive_p)
2436 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2437 (funcall_lambda, mark_backtrace): Likewise.
2438 * fns.c (concat): Likewise.
2439 * frame.c (x_set_frame_parameters): Likewise.
2440 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2441 0 if not found, not -1. All callers changed.
2442
dd3f25f7
PE
2443 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2444 (stack_copy_size): Now size_t, not int.
2445 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2446
461c2ab9
JB
24472011-03-28 Juanma Barranquero <lekktu@gmail.com>
2448
2449 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2450 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2451 All callers changed.
2452
2453 * lisp.h (multibyte_char_to_unibyte):
2454 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2455 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2456 * character.h (CHAR_TO_BYTE8):
2457 * cmds.c (internal_self_insert):
2458 * editfns.c (general_insert_function):
2459 * keymap.c (push_key_description):
2460 * search.c (Freplace_match):
2461 * xdisp.c (message_dolog, set_message_1): All callers changed.
2462
f6d62986
SM
24632011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2464
2465 * keyboard.c (safe_run_hook_funcall): New function.
2466 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2467 don't set the hook to nil, but remove the offending function instead.
2468 (Qcommand_hook_internal): Remove, unused.
2469 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2470 Vcommand_hook_internal.
2471
2472 * eval.c (enum run_hooks_condition): Remove.
2473 (funcall_nil, funcall_not): New functions.
2474 (run_hook_with_args): Call each function through a `funcall' argument.
2475 Remove `cond' argument, now redundant.
2476 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2477 (Frun_hook_with_args_until_failure): Adjust accordingly.
2478 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2479
1db5b1ad
JB
24802011-03-28 Juanma Barranquero <lekktu@gmail.com>
2481
2482 * dispextern.h (string_buffer_position): Remove declaration.
2483
2484 * print.c (strout): Remove parameter `multibyte', unused since
2485 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2486
2487 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2488 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2489 All callers changed.
2490
2491 * w32.c (_wsa_errlist): Use braces for struct initializers.
2492
2493 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2494 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2495 All callers changed.
2496 (string_buffer_position): Likewise. Also, make static (it's never
2497 used outside xdisp.c).
2498 (cursor_row_p): Remove parameter `w', unused since
2499 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2500 (decode_mode_spec): Remove parameter `precision', introduced during
2501 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2502 All callers changed.
2503
5ffb62aa
JD
25042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2505
2506 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2507
461c2ab9 25082011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2509
2510 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2511 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2512 (ns_update_auto_hide_menu_bar): New functions.
2513 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2514 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2515 ns_constrain_all_frames.
2516 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2517 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2518
5c380ffb
JD
25192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2520
2521 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2522
9af30bdf
GM
25232011-03-27 Glenn Morris <rgm@gnu.org>
2524
2525 * syssignal.h: Replace RETSIGTYPE with void.
2526 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2527 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2528 Replace SIGTYPE with void everywhere.
2529 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2530 * s/template.h (SIGTYPE): Remove commented out definition.
2531
e2abce01
JB
25322011-03-26 Eli Zaretskii <eliz@gnu.org>
2533
2534 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2535 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2536
f868cd8a
JB
25372011-03-26 Juanma Barranquero <lekktu@gmail.com>
2538
59eb0929
JB
2539 * w32.c (read_unc_volume): Use parameter `henum', instead of
2540 global variable `wget_enum_handle'.
2541
2542 * keymap.c (describe_vector): Remove parameters `indices' and
2543 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2544 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2545
f868cd8a
JB
2546 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2547
2548 * keyboard.c (timer_check): Remove parameter `do_it_now',
2549 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2550 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2551 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2552
2553 * keyboard.c (read_char):
2554 * w32menu.c (w32_menu_display_help):
2555 * xmenu.c (show_help_event, menu_help_callback):
2556 Adjust calls to `show_help_echo'.
2557
2558 * gtkutil.c (xg_maybe_add_timer):
2559 * keyboard.c (readable_events):
2560 * process.c (wait_reading_process_output):
2561 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2562
2563 * insdel.c (adjust_markers_gap_motion):
2564 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2565 (gap_left, gap_right): Don't call it.
2566
2ecf6fdb
CY
25672011-03-25 Chong Yidong <cyd@stupidchicken.com>
2568
2569 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2570 incurred during fontification.
2571
6b1f9ba4
JB
25722011-03-25 Juanma Barranquero <lekktu@gmail.com>
2573
2574 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2575 (DEFVAR_PER_BUFFER): Don't pass it.
2576
2577 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2578 (scrolling_window): Don't pass it.
2579
0f4a96b5
JB
25802011-03-25 Juanma Barranquero <lekktu@gmail.com>
2581
2582 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2583
2584 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2585 and `suffix'.
2586 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2587 of variables specific to SELinux and computation of `encoded_absname'.
2588
2589 * image.c (XPutPixel): Remove unused variable `height'.
2590
2591 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2592
2593 * unexw32.c (get_section_info): Remove unused variable `section'.
2594
2595 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2596 (system_process_attributes): Remove unused variable `sess'.
2597 (sys_read): Remove unused variable `err'.
2598
2599 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2600 (w32_wnd_proc): Remove unused variable `isdead'.
2601 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2602 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2603 (x_create_tip_frame): Remove unused variable `tem'.
2604
2605 * w32inevt.c (w32_console_read_socket):
2606 Remove unused variable `no_events'.
2607
2608 * w32term.c (x_draw_composite_glyph_string_foreground):
2609 Remove unused variable `width'.
2610
1149507c
JB
26112011-03-24 Juanma Barranquero <lekktu@gmail.com>
2612
2613 * w32term.c (x_set_glyph_string_clipping):
2614 Don't pass uninitialized region to CombineRgn.
2615
9c88f339
JB
26162011-03-23 Juanma Barranquero <lekktu@gmail.com>
2617
2618 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2619 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2620 (Fx_close_connection): Remove unused variable `i'.
2621
2622 * w32font.c (w32font_draw): Return number of glyphs.
2623 (w32font_open_internal): Remove unused variable `i'.
2624 (w32font_driver): Add missing initializer.
2625
2626 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2627 (fill_in_menu): Remove unused variable `items_added'.
2628
2629 * w32term.c (last_mouse_press_frame): Remove static global variable.
2630 (w32_clip_to_row): Remove unused variable `f'.
2631 (x_delete_terminal): Remove unused variable `i'.
2632
2633 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2634 (NOTHING): Remove unused static global variable.
2635 (uniscribe_check_otf): Remove unused variable `table'.
2636 (uniscribe_font_driver): Add missing initializers.
2637
dee091a3
JD
26382011-03-23 Julien Danjou <julien@danjou.info>
2639
2640 * term.c (Fsuspend_tty, Fresume_tty):
2641 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2642 * window.c (temp_output_buffer_show):
2643 * insdel.c (signal_before_change):
2644 * frame.c (Fhandle_switch_frame):
2645 * fileio.c (Fdo_auto_save):
2646 * emacs.c (Fkill_emacs):
2647 * editfns.c (save_excursion_restore):
2648 * cmds.c (internal_self_insert):
2649 * callint.c (Fcall_interactively):
2650 * buffer.c (Fkill_all_local_variables):
2651 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2652 Use Frun_hooks.
0f4a96b5 2653 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2654 unconditionnaly since it does the check itself.
2655
2c520ab5 26562011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2657
c9c49752
PE
2658 Fix more problems found by GCC 4.5.2's static checks.
2659
8abc3f12
PE
2660 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2661 the first time through the loop, since we know p0 < p1 then.
2662 This also avoids a gcc -Wstrict-overflow warning.
2663
a2d26660
PE
2664 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2665 leading to a memory leak, possible in functions like
2666 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2667 of objects (Bug#8318).
a2d26660 2668
916c72e9
PE
2669 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2670 that could (at least in theory) be that large.
2671
19ab8a18
PE
2672 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2673 This is less likely to overflow, and avoids undefined behavior if
2674 overflow does occur. All callers changed. Use strtoul to scan
2675 for the unsigned long integer.
b7cbbd6f
PE
2676 (pint2hrstr): Simplify and tune code slightly.
2677 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2678
f0641eff
PE
2679 * scroll.c (do_scrolling): Work around GCC bug 48228.
2680 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2681
7f650bb9
PE
2682 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2683 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2684 (validate_x_resource_name): Simplify count usage.
2685 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2686
37dd57d1
PE
2687 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2688 fail (Bug#8306).
81e56e61 2689
699979fc 2690 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2691
401bf9b4
PE
2692 * process.c (Fmake_network_process): Use socklen_t, not int,
2693 where POSIX says socklen_t is required in portable programs.
2694 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2695 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2696 (Fmake_network_process, server_accept_connection):
2697 (wait_reading_process_output, read_process_output):
2698 Likewise.
2699
b93aacde
PE
2700 * process.c: Rename or move locals to avoid shadowing.
2701 (list_processes_1, Fmake_network_process):
2702 (read_process_output_error_handler, exec_sentinel_error_handler):
2703 Rename or move locals.
4dc343ee 2704 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2705 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2706 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2707 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2708 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2709
af8a867c 2710 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2711 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2712 Include tparam.h instead, since it declares them.
af8a867c
PE
2713 * cm.h (PC): Remove extern decl; tparam.h now does this.
2714 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2715 * terminfo.c: Include tparam.h, to check interfaces.
2716 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2717 (tparam): Adjust signature to match interface in tparam.h;
2718 this removes some undefined behavior. Check that outstring and len
2719 are zero, which they always are with Emacs.
2720 * tparam.h (PC, BC, UP): New extern decls.
2721
0248044d 2722 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2723 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2724
8ff096c1 2725 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2726 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2727 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2728 (ftfont_list): Remove unused local.
49eaafba
PE
2729 (get_adstyle_property, ftfont_pattern_entity):
2730 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2731 Rename locals to avoid shadowing.
8ff096c1 2732
e2be39f6
PE
2733 * xfont.c (xfont_list_family): Mark var as initialized.
2734
c9735e30
PE
2735 * xml.c (make_dom): Now static.
2736
8f5201ae
PE
2737 * composite.c (composition_compute_stop_pos): Rename local to
2738 avoid shadowing.
b246f932
PE
2739 (composition_reseat_it): Remove unused locals.
2740 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2741 (composition_update_it): Mark var as initialized.
11b61122
PE
2742 (find_automatic_composition): Mark vars as initialized,
2743 with a FIXME (Bug#8290).
8f5201ae 2744
760fbc2c
PE
2745 character.h: Rename locals to avoid shadowing.
2746 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2747 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2748 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2749 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2750 to avoid shadowing.
2751
ff08eb85
PE
2752 * textprop.c (property_change_between_p): Remove; unused.
2753
fc7bf025
PE
2754 * intervals.c (interval_start_pos): Now static.
2755
235d7abc
PE
2756 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2757
44f230aa
SM
2758 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2759 Rename locals to avoid shadowing.
3e7d6594 2760
50060332
PE
2761 * sound.c (wav_play, au_play, Fplay_sound_internal):
2762 Fix pointer signedness.
d01f234b 2763 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2764 (wav_play): Initialize a variable to 0, to prevent undefined
2765 behavior (Bug#8278).
50060332 2766
c4fc4e30
PE
2767 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2768
918436ed
PE
2769 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2770
c939f91b
PE
2771 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2772 clobbering (Bug#8298).
b9c7f648
PE
2773 * sysdep.c (sys_subshell): Likewise.
2774 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2775
6bd8c144
PE
2776 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2777 This should get cleaned up, so that child_setup has the
2778 same signature on all platforms.
2779
7710357c 2780 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2781 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2782
c59da222
CY
27832011-03-22 Chong Yidong <cyd@stupidchicken.com>
2784
2785 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2786 not to be necessary, and produces flickering.
2787
66b87493
GM
27882011-03-20 Glenn Morris <rgm@gnu.org>
2789
2790 * config.in: Remove file.
2791
45b6f6d5
JB
27922011-03-20 Juanma Barranquero <lekktu@gmail.com>
2793
2794 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2795 are now in src/globals.h.
2796 (syms_of_minibuf): Remove spurious & from previous change.
2797
3ec03f7e
LL
27982011-03-20 Leo <sdl.web@gmail.com>
2799
2800 * minibuf.c (completing-read-function): New variable.
2801 (completing-read-default): Rename from completing-read.
2802 (completing-read): Call completing-read-function.
2803
b14e3e21
CY
28042011-03-19 Juanma Barranquero <lekktu@gmail.com>
2805
2806 * xfaces.c (Fx_load_color_file):
2807 Read color file from absolute filename (bug#8250).
2808
f2b726e6
JB
28092011-03-19 Juanma Barranquero <lekktu@gmail.com>
2810
2811 * makefile.w32-in: Update dependencies.
2812
09f6ff02
EZ
28132011-03-17 Eli Zaretskii <eliz@gnu.org>
2814
2815 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2816
29a6015a
PE
28172011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2818
a3a6c54e
PE
2819 Fix more problems found by GCC 4.5.2's static checks.
2820
b766f867
PE
2821 * process.c (make_serial_process_unwind, send_process_trap):
2822 (sigchld_handler): Now static.
2823
be02381c
PE
2824 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2825 That way, the code declares only the vars that it needs.
2826 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2827 * s/cygwin.h (PTY_ITERATION): Likewise.
2828 * s/darwin.h (PTY_ITERATION): Likewise.
2829 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2830
57048744
PE
2831 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2832 * process.c (allocate_pty): Don't declare stb unless it's needed.
2833
7914961c 2834 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2835 (CONSTANTLIM): Remove; unused.
2836 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2837 Define only if needed.
7914961c 2838
b3967b18
PE
2839 * unexelf.c (unexec): Name an expression,
2840 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2841 Use a different way to cause a compilation error if anyone uses
2842 n rather than nn, a way that does not involve shadowing.
73366a00 2843 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2844
29a6015a
PE
2845 * deps.mk (unexalpha.o): Remove; unused.
2846
43cfc33e 2847 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2848 * unexec.h: New file.
ce701a33
PE
2849 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2850 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2851 Depend on unexec.h.
2852 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2853 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2854 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2855 Change as necessary to match prototype in unexec.h.
ce701a33 2856
01f44d5a
PE
2857 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2858 shadowing.
4f63c6bb 2859 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2860
a6670b0b
PE
2861 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2862 Rename locals to avoid shadowing.
2863
cef2010d 2864 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2865 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2866
d4d7173a
PE
2867 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2868
f08b802a
PE
2869 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2870 warning when compiling print.c.
2871
3ddb0639
PE
2872 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2873 instead of using an uninitialized var.
5ad03b97 2874 (font_sort_entities): Mark var as initialized.
3ddb0639 2875
170a2692
PE
2876 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2877
e663c700
PE
2878 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2879 pointers to constants.
89bc529a 2880 (font_parse_fcname): Remove unused vars.
7b81e2d0 2881 (font_delete_unmatched): Now static.
ea838e10 2882 (font_get_spec): Remove; unused.
13a547c6
PE
2883 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2884 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2885 Rename or move locals to avoid shadowing.
e663c700 2886
2a80c887 2887 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2888 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2889
1384fa33 2890 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2891 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2892
8b2c52e9
PE
2893 * alloc.c (mark_backtrace): Move decl from here ...
2894 * lisp.h: ... to here, so that it can be checked.
2895
475545b5 2896 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2897 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2898 (lisp_indirect_variable): Name an expression,
2899 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2900 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2901
b1349114 2902 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2903 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2904 Use const pointer when appropriate.
b1349114 2905
a2928364
PE
2906 * lisp.h (get_system_name, get_operating_system_release):
2907 Move decls here, to check interfaces.
2908 * process.c (get_operating_system_release): Move decl to lisp.h.
2909 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2910 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2911 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2912 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2913 (Fformat_time_string, Fencode_time, Finsert_char):
2914 (Ftranslate_region_internal, Fformat):
2915 Rename or remove local vars to avoid shadowing.
9710023e 2916 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2917
a415e694
PE
2918 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2919 avoid shadowing.
2920
8ef4622d
PE
2921 * lisp.h (eassert): Check that the argument compiles, even if
2922 ENABLE_CHECKING is not defined.
2923
946f9a5b
PE
2924 * data.c (Findirect_variable): Name an expression, to avoid
2925 gcc -Wbad-function-cast warning.
112396d6 2926 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2927 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2928 (Fmake_variable_buffer_local, Fmake_local_variable):
2929 Mark variables as initialized.
52746918 2930 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2931
e5aab7e7 2932 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2933 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2934 Rename locals to avoid shadowing.
dff45157
PE
2935 (mark_stack): Move local variables into the #ifdef region where
2936 they're used.
7bc26fdb
PE
2937 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2938 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2939 needed otherwise.
2940 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2941 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2942 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2943
e5aab7e7
PE
2944 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2945 avoids undefined behavior in theory.
2946
4da60324
PE
2947 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2948
88043301
PE
2949 Use functions, not macros, for up- and down-casing (Bug#8254).
2950 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2951 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2952 to use the following functions instead of these macros.
2953 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2954 EMACS_INT, since callers assume the returned value fits in int.
2955 (upcase1): Likewise, for UPCASE_TABLE.
2956 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2957 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2958 the race-condition problem in the old DOWNCASE.
88043301 2959
19ed5445
PE
2960 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2961 Rename locals to avoid shadowing.
2962 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2963 (regex_compile, re_search_2, re_match_2_internal):
2964 Remove unused local vars.
952db0d7
PE
2965 (FREE_VAR): Rewrite so as not to use empty "else",
2966 which gcc can warn about.
da053e48 2967 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2968 (RETALLOC_IF): Define only if needed.
2969 (WORDCHAR_P): Likewise. This one is never needed, but is used
2970 only in a comment talking about a compiler bug, so put inside
2971 the #if 0 of that comment.
2972 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2973 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2974 Remove; unused.
19ed5445 2975
1f3561e4 2976 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2977 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2978 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2979
ded6f8f7
PE
2980 * search.c (simple_search): Remove unused var.
2981
dbd37a95
PE
2982 * dired.c (compile_pattern): Move decl from here ...
2983 * lisp.h: ... to here, so that it can be checked.
2984 (struct re_registers): New forward decl.
2985
7e47afad
PE
2986 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2987
85f24f61
PE
2988 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2989 All uses changed.
2990 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2991 Rename locals to avoid shadowing.
5671df8f 2992 (Fvertical_motion): Mark locals as initialized.
85f24f61 2993
181aa2be 2994 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2995 (casify_region): Mark local as initialized.
181aa2be 2996
930d429c
PE
2997 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2998
7082eac6
PE
2999 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3000 New macros, so that the caller can use some names other than
3001 gcpro1, gcpro2, etc.
3002 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3003 of the new macros.
3004 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3005 argument, for consistency with GCPRO2_VAR, etc: it is now the
3006 prefix of the variable, not the variable itself. All uses
3007 changed.
38b2c076
PE
3008 * dired.c (directory_files_internal, file_name_completion):
3009 Rename locals to avoid shadowing.
3010
15206ed9
PE
3011 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3012 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3013 dired.c's scmp function, had undefined behavior.
3014 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3015 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3016 * buffer.h: ... to here, because these macros use current_buffer,
3017 and the new implementation with inline functions needs to have
3018 current_buffer in scope now, rather than later when the macros
3019 are used.
3020 (downcase, upcase1): New static inline functions.
3021 (DOWNCASE, UPCASE1): Reimplement using these functions.
3022 This avoids undefined behavior in expressions like
3023 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3024 from race conditions in accessing the global variables
3025 case_temp1 and case_temp2.
3026 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3027 * lisp.h (case_temp1, case_temp2): Remove their decls.
3028 * character.h (ASCII_CHAR_P): Move from here ...
3029 * lisp.h: ... to here, so that the inline functions mentioned
3030 above can use them.
3031
4a6bea26
PE
3032 * dired.c (directory_files_internal_unwind): Now static.
3033
f14b7e14
PE
3034 * fileio.c (file_name_as_directory, directory_file_name):
3035 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3036 Now static.
2893f146
PE
3037 (file_name_as_directory): Use const pointers when appropriate.
3038 (Fexpand_file_name): Likewise. In particular, newdir might
3039 point at constant storage, so make it a const pointer.
fd4ead52 3040 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3041 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3042 signedness issues.
f839df0c
PE
3043 (Fset_file_times, Finsert_file_contents, auto_save_error):
3044 Rename locals to avoid shadowing.
f14b7e14 3045
5716756e 3046 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3047 (Ftry_completion, Fall_completions): Rename or remove locals
3048 to avoid shadowing.
5716756e 3049
b4c3046a
PE
3050 * marker.c (bytepos_to_charpos): Remove; unused.
3051
b45db522
PE
3052 * lisp.h (verify_bytepos, count_markers): New decls,
3053 so that gcc does not warn that these functions aren't declared.
3054
85876d07
PE
3055 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3056 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3057 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3058 (copy_text): Remove unused local var.
85876d07 3059
03d78a21 3060 * filelock.c (within_one_second): Now static.
b3dd38ab 3061 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3062
5df8f01b
PE
3063 * buffer.c (fix_overlays_before): Mark locals as initialized.
3064 (fix_start_end_in_overlays): Likewise. This function should be
3065 simplified by using pointers-to-pointers, but that's a different
3066 matter.
b1d876f1 3067 (switch_to_buffer_1): Now static.
8f54f30a
PE
3068 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3069 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3070
a70072c9 3071 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3072 Fix pointer signedness issue.
edced198
PE
3073 (sys_subshell): Mark local as volatile if checking for lint,
3074 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3075 (MAXPATHLEN): Define only if needed.
a70072c9 3076
a0977c44
PE
3077 * process.c (serial_open, serial_configure): Move decls from here ...
3078 * systty.h: ... to here, so that they can be checked.
3079
a884fdcc
PE
3080 * fns.c (get_random, seed_random): Move extern decls from here ...
3081 * lisp.h: ... to here, so that they can be checked.
3082
604efe86 3083 * sysdep.c (reset_io): Now static.
b8950c94 3084 (wait_for_termination_signal): Remove; unused.
604efe86 3085
38fc62d9
PE
3086 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3087 (copy_keymap_item, append_key, push_text_char_description):
3088 Now static.
1004a21a 3089 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3090 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3091 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3092 (describe_map_tree):
3093 Rename locals to avoid shadowing.
38fc62d9 3094
2f2650da
PE
3095 * keyboard.c: Declare functions static if they are not used elsewhere.
3096 (echo_char, echo_dash, cmd_error, top_level_2):
3097 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3098 (read_char, kbd_buffer_get_event, make_lispy_position):
3099 (make_lispy_event, make_lispy_movement, apply_modifiers):
3100 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3101 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3102 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3103 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3104 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3105
a053e86c 3106 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3107 (mark_kboards): Move decl here ...
3108 * alloc.c (mark_kboards): ... from here.
a053e86c 3109
4752793e
PE
3110 * lisp.h (force_auto_save_soon): New decl.
3111
74f10ca7 3112 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3113 (DEFINE_DUMMY_FUNCTION): New macro.
3114 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3115 Use it.
c03cd23f
PE
3116 (main): Add casts to avoid warnings
3117 if GCC considers string literals to be constants.
74f10ca7 3118
022e70d4
PE
3119 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3120
59d6fe83
PE
3121 * dbusbind.c: Pointer signedness fixes.
3122 (xd_signature, xd_append_arg, xd_initialize):
3123 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3124 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3125 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3126 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3127
78320123
PE
3128 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3129 if GCC considers string literals to be constants.
49cebcca 3130 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3131
35ac2a97
SM
31322011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3133
fb103ca9
SM
3134 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3135 (print_preprocess, print_object): New macro to fix last change.
3136
35ac2a97
SM
3137 * print.c (print_preprocess): Don't forget font objects.
3138
62973b41
JB
31392011-03-16 Juanma Barranquero <lekktu@gmail.com>
3140
3141 * emacs.c (USAGE3): Doc fixes.
3142
0e48bb22
AS
31432011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3144
3145 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3146 structure.
3147
7684e57b
JB
31482011-03-14 Juanma Barranquero <lekktu@gmail.com>
3149
3150 * lisp.h (VWindow_system, Qfile_name_history):
3151 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3152 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3153 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3154
3155 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3156 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3157
3158 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3159 * w32console.c (detect_input_pending, read_input_pending)
3160 (encode_terminal_code):
3161 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3162 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3163 (w32_system_caret_y, Qfile_name_history):
3164 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3165 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3166 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3167 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3168 * w32proc.c (Qlocal, report_file_error):
3169 * w32term.c (Vwindow_system, updating_frame):
3170 * w32uniscribe.c (initialized, uniscribe_font_driver):
3171 Remove unneeded extern declarations.
3172
2aa46d6c
CY
31732011-03-14 Chong Yidong <cyd@stupidchicken.com>
3174
c96bbc66 3175 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3176
cffc6f3b
CY
31772011-03-13 Chong Yidong <cyd@stupidchicken.com>
3178
3179 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3180 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3181 These macros can no longer be used for assignment.
3182
44f230aa
SM
3183 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3184 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3185 (record_buffer_markers, fetch_buffer_markers): New functions for
3186 recording and fetching special buffer markers.
3187 (set_buffer_internal_1, set_buffer_temp): Use them.
3188
3189 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3190
3191 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3192
3193 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3194 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3195
3196 * xdisp.c (hscroll_window_tree):
3197 (reconsider_clip_changes): Use PT instead of BUF_PT.
3198
d251f04b
EZ
31992011-03-13 Eli Zaretskii <eliz@gnu.org>
3200
3201 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3202 $(EMACS_ROOT)/lib/intprops.h.
3203
f0c77cd1
PE
32042011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3205
3eca4629
PE
3206 Fix more problems found by GCC 4.5.2's static checks.
3207
7c86ee98
PE
3208 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3209 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3210 (xg_free_frame_widgets): Make it clear that a local variable is
3211 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3212 (gdk_window_get_screen): Make it clear that this macro is needed
3213 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3214 (int_gtk_range_get_value): New function, which avoids a diagnostic
3215 from gcc -Wbad-function-cast.
3216 (xg_set_toolkit_scroll_bar_thumb): Use it.
3217 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3218 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3219 (get_utf8_string, xg_get_file_with_chooser):
3220 Rename locals to avoid shadowing.
3221 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3222
41729b81
PE
3223 * xgselect.c (xg_select): Remove unused var.
3224
f0c77cd1
PE
3225 * image.c (four_corners_best): Mark locals as initialized.
3226 (gif_load): Initialize transparent_p to zero (Bug#8238).
3227 Mark another local as initialized.
ec6cf4c6 3228 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3229
ce0ad53d 3230 * image.c (clear_image_cache): Now static.
d5d5a617 3231 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3232 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3233 (x_edge_detection): Remove unnecessary cast that
3234 gcc -Wbad-function-cast diagnoses.
2037898d 3235 (gif_load): Fix pointer signedness.
6ae141d6
PE
3236 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3237 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3238
33383987 32392011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3240
d32df629
PE
3241 Improve quality of tests for time stamp overflow.
3242 For example, without this patch (encode-time 0 0 0 1 1
3243 1152921504606846976) returns the obviously-bogus value (-948597
3244 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3245 reports time overflow. See
3246 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3247 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3248 * editfns.c: Include limits.h and intprops.h.
3249 (TIME_T_MIN, TIME_T_MAX): New macros.
3250 (time_overflow): Move earlier, to before first use.
3251 (hi_time, lo_time): New functions, for an accurate test for
3252 out-of-range times.
3253 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3254 (Fget_internal_run_time): Don't assume time_t fits in int.
3255 (make_time): Use list2 instead of Fcons twice.
3256 (Fdecode_time): More accurate test for out-of-range times.
3257 (check_tm_member): New function.
3258 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3259 (lisp_time_argument): Don't rely on undefined left-shift and
3260 right-shift behavior when checking for time stamp overflow.
8be6f318 3261
fe31d94c
PE
3262 * editfns.c (time_overflow): New function, refactoring common code.
3263 (Fformat_time_string, Fdecode_time, Fencode_time):
3264 (Fcurrent_time_string): Use it.
3265
8be6f318
PE
3266 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3267 * dired.c (make_time): Move to ...
3268 * editfns.c (make_time): ... here.
3269 * systime.h: Note the move.
3270
09d9db2c 32712011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3272
126bc0dc
YM
3273 * fringe.c (update_window_fringes): Remove unused variables.
3274
c47cbdfd
YM
3275 * unexmacosx.c (copy_data_segment): Also copy __got section.
3276 (Bug#8223)
3277
7ac80be9
EZ
32782011-03-12 Eli Zaretskii <eliz@gnu.org>
3279
c96bbc66 3280 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3281 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3282 Constify `char *' arguments and their references according to
3283 prototypes in tparam.h.
3284
ecb0f94d 3285 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3286
7ac80be9
EZ
3287 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3288 Adapt all references accordingly.
3289
3290 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3291
ef1fd07e
TT
32922011-03-11 Tom Tromey <tromey@redhat.com>
3293
3294 * buffer.c (syms_of_buffer): Remove obsolete comment.
3295
7ef4b50c
EZ
32962011-03-11 Eli Zaretskii <eliz@gnu.org>
3297
3298 * termhooks.h (encode_terminal_code): Declare prototype.
3299
3300 * msdos.c (encode_terminal_code): Don't declare prototype.
3301
3302 * term.c (encode_terminal_code): Now external again, used by
3303 w32console.c and msdos.c.
3304
44f230aa
SM
3305 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3306 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3307
4b1ec863 33082011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3309
1714f52b 3310 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3311
4b1ec863
PE
3312 * fringe.c (update_window_fringes): Mark locals as initialized
3313 (Bug#8227).
3314 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3315
524c7aa6
PE
3316 * alloc.c (mark_fringe_data): Move decl from here ...
3317 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3318 to check its interface.
3319 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3320
a5c0af81 3321 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3322 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3323 (fontset_font): Mark local as initialized.
a9a06e0b 3324 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3325
b4716021
PE
3326 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3327
811e9bac 3328 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3329 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3330 (x_own_selection, Fx_disown_selection_internal): Rename locals
3331 to avoid shadowing.
3332 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3333
7e3ab302
PE
3334 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3335 so that the caller can use some name other than gcpro1.
3336 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3337 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3338 (Fx_backspace_delete_keys_p):
3339 Use them to avoid shadowing, and rename vars to avoid shadowing.
3340 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3341 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3342 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3343 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3344 Remove unused locals.
7e3ab302
PE
3345 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3346 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3347 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3348 macros.
f78faa98 3349
e2b13473
PE
3350 * xterm.h (x_mouse_leave): New decl.
3351
77f23912
PE
3352 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3353 Remove unused functions.
cdf4ba58
PE
3354 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3355 (x_calc_absolute_position): Now static.
7411c686 3356 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3357 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3358 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3359 unless they are used.
38d0b34a
PE
3360 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3361 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3362 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3363 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3364 (x_error_catcher, x_connection_closed, x_error_handler):
3365 (x_error_quitter, xembed_send_message, x_iconify_frame):
3366 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3367 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3368 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3369
44f230aa
SM
3370 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3371 Rename or move locals to avoid shadowing.
6b463e58 3372 (tty_defined_color, merge_face_heights): Now static.
5967d051 3373 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3374 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3375 does not deduce is never used uninitialized.
73719eba
PE
3376 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3377 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3378
426994c3 3379 * terminal.c (store_terminal_param): Now static.
5489860b 3380
032f1620 3381 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3382 (set_frame_menubar): Remove unused local.
d4323972 3383 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3384 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3385 since they might point to immutable storage.
281585b0
PE
3386 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3387 since it's unused otherwise.
032f1620 3388
367c19e5 3389 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3390 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3391 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3392 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3393 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3394 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3395 does not deduce are never used uninitialized.
70739cbe 3396
07b48fa9
PE
3397 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3398
8868a238 3399 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3400 * window.c (window_loop, size_window):
3401 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3402
7e5cf297 3403 * window.c (display_buffer): Now static.
d6550a9f
PE
3404 (size_window): Mark variables that gcc -Wuninitialized
3405 does not deduce are never used uninitialized.
a586633d
PE
3406 * window.h (check_all_windows): New decl, to forestall
3407 gcc -Wmissing-prototypes diagnostic.
5b555da1 3408 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3409
f6095868
PE
3410 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3411 shadowing.
3412 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3413 Include <limits.h>.
3414 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3415 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3416 (load_charset_map): Mark variables that gcc -Wuninitialized
3417 does not deduce are never used uninitialized.
53df7c11 3418 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3419
f38b440c
PE
3420 * coding.c (coding_set_source, coding_set_destination):
3421 Use "else { /* comment */ }" rather than "else /* comment */;"
3422 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3423 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3424 a block, when the outer 'i' will do.
3425 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3426 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3427 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3428 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3429 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3430 Rename locals to avoid shadowing.
3431 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3432 * coding.c (emacs_mule_char, encode_invocation_designation):
3433 Now static, since they're not used elsewhere.
413bb2db 3434 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3435 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3436 (decode_coding_emacs_mule): Mark variables that gcc
3437 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3438 (detect_coding_iso_2022): Initialize a local variable that might
3439 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3440 this initialization is needed. (Bug#8211)
5f58e762
PE
3441 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3442 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3443 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3444 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3445 Remove unused macros.
f38b440c 3446
232b38b9 3447 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3448 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3449 * character.c (string_count_byte8): Likewise.
232b38b9 3450
fb90da1b
PE
3451 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3452 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3453
fb93dbc2
PE
3454 * chartab.c (copy_sub_char_table): Now static, since it's not used
3455 elsewhere.
5c156ace
PE
3456 (sub_char_table_ref_and_range, char_table_ref_and_range):
3457 Rename locals to avoid shadowing.
bbcd0949 3458 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3459
7d3b3862 3460 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3461 (BIDI_BOB): Remove unused macro.
7d3b3862 3462
6be7d3da
PE
3463 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3464 deduce are never used uninitialized.
c2ed9c8b 3465 * term.c (encode_terminal_code): Likewise.
6be7d3da 3466
75f8807f 3467 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3468
50938595
PE
3469 * tparam.h: New file.
3470 * term.c, tparam.h: Include it.
3471 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3472 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3473 Move these decls to tparam.h, and make them agree with what
3474 is actually in tparam.c. The previous trick of using incompatible
3475 decls in different modules does not conform to the C standard.
3476 All callers of tparam changed to use tparam's actual API.
3477 * tparam.c (tparam1, tparam, tgoto):
3478 Use const pointers where appropriate.
3479
fbceeba2
PE
3480 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3481 * cm.h (struct cm): Likewise.
3482 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3483 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3484 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3485 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3486 (turn_on_face, init_tty): Likewise.
3487 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3488
7f3f1250
PE
3489 * term.c (term_mouse_position): Rename local to avoid shadowing.
3490
e6ca6543
PE
3491 * alloc.c (mark_ttys): Move decl from here ...
3492 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3493
c40f8d15
AS
34942011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3495
3496 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3497
cfe0661d
JB
34982011-03-09 Juanma Barranquero <lekktu@gmail.com>
3499
3500 * search.c (compile_pattern_1): Remove argument regp, unused since
3501 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3502 (compile_pattern): Don't pass it.
3503
0afb4571
J
35042011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3505
3506 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3507 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3508 for ! HAVE_GTK3.
3509 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3510
3511 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3512
3513 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3514 gdk_window_get_screen, gdk_window_get_geometry,
3515 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3516 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3517 (xg_get_pixbuf_from_pixmap): New function.
3518 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3519 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3520 Call xg_get_pixbuf_from_pixmap instead of
3521 gdk_pixbuf_get_from_drawable.
3522 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3523 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3524 (xg_check_special_colors): Use GtkStyleContext and its functions
3525 for HAVE_GTK3.
3526 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3527 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3528 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3529 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3530 Call gtk_widget_get_preferred_size.
0afb4571
J
3531 (xg_frame_resized): gdk_window_get_geometry only takes 5
3532 parameters.
44f230aa
SM
3533 (xg_win_to_widget, xg_event_is_for_menubar):
3534 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3535 (xg_set_widget_bg): New function.
3536 (delete_cb): New function.
895009e1 3537 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3538 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3539 (xg_set_background_color): Call xg_set_widget_bg.
3540 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3541 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3542 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3543 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3544 if ! HAVE_GTK3.
3545 (update_frame_tool_bar): Call gtk_widget_hide.
3546 (xg_initialize): Use GDK_KEY_g.
3547
3548 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3549 if ! HAVE_GTK3
3550 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3551
3552 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3553 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3554 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3555
1c2cc4ef
JB
35562011-03-08 Juanma Barranquero <lekktu@gmail.com>
3557
3558 * w32xfns.c (select_palette): Check success of RealizePalette against
3559 GDI_ERROR, not zero.
3560
33383987 3561See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3562
3563;; Local Variables:
3564;; coding: utf-8
aac0c6e3
MR
3565;; End:
3566
33383987 3567 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3568
3569 This file is part of GNU Emacs.
3570
3571 GNU Emacs is free software: you can redistribute it and/or modify
3572 it under the terms of the GNU General Public License as published by
3573 the Free Software Foundation, either version 3 of the License, or
3574 (at your option) any later version.
3575
3576 GNU Emacs is distributed in the hope that it will be useful,
3577 but WITHOUT ANY WARRANTY; without even the implied warranty of
3578 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3579 GNU General Public License for more details.
3580
3581 You should have received a copy of the GNU General Public License
3582 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.