merge trunk
[bpt/emacs.git] / src / ChangeLog
1 2011-05-18 Kenichi Handa <handa@m17n.org>
2
3 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5 (find_automatic_composition): Mostly rewrite for efficiency.
6
7 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8
9 * makefile.w32-in: Update dependencies.
10
11 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12
13 * menu.c: Include limits.h (fixes the MS-Windows build broken by
14 revision 104625).
15
16 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
17
18 Fix some integer overflow issues, such as string length overflow.
19
20 * insdel.c (count_size_as_multibyte): Check for string overflow.
21
22 * character.c (lisp_string_width): Check for string overflow.
23 Use EMACS_INT, not int, for string indexes and lengths; in
24 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
25 the resulting string length overflows an EMACS_INT; instead,
26 report a string overflow if no precision given. When checking for
27 precision exhaustion, use a check that cannot possibly have
28 integer overflow. (Bug#8675)
29 * character.h (lisp_string_width): Adjust to new signature.
30
31 * alloc.c (string_overflow): New function.
32 (Fmake_string): Use it. This doesn't change behavior, but saves
33 a few bytes and will simplify future changes.
34 * character.c (string_escape_byte8): Likewise.
35 * lisp.h (string_overflow): New decl.
36
37 Fixups, following up to the user-interface timestamp change.
38 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
39 for UI timestamps, instead of unsigned long.
40 * msdos.c (mouse_get_pos): Likewise.
41 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
42 * w32gui.h (Time): Define by including "systime.h" rather than by
43 declaring it ourselves. (Bug#8664)
44
45 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
46 * image.c (clear_image_cache): Likewise.
47
48 * term.c (term_mouse_position): Don't assume time_t wraparound.
49
50 Be more systematic about user-interface timestamps.
51 Before, the code sometimes used 'Time', sometimes 'unsigned long',
52 and sometimes 'EMACS_UINT', to represent these timestamps. This
53 change causes it to use 'Time' uniformly, as that's what X uses.
54 This makes the code easier to follow, and makes it easier to catch
55 integer overflow bugs such as Bug#8664.
56 * frame.c (Fmouse_position, Fmouse_pixel_position):
57 Use Time, not unsigned long, for user-interface timestamps.
58 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
59 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
60 * keyboard.h (last_event_timestamp): Likewise.
61 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
62 * menu.h (xmenu_show): Likewise.
63 * term.c (term_mouse_position): Likewise.
64 * termhooks.h (struct input_event.timestamp): Likewise.
65 (struct terminal.mouse_position_hook): Likewise.
66 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
67 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
68 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
69 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
70 what it was before.
71 * menu.h, termhooks.h: Include "systime.h", for Time.
72
73 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
74 Don't assume that the difference between two unsigned long values
75 can fit into an integer. At this point, we know button_down_time
76 <= event->timestamp, so the difference must be nonnegative, so
77 there's no need to cast the result if double-click-time is
78 nonnegative, as it should be; check that it's nonnegative, just in
79 case. This bug is triggered when events are more than 2**31 ms
80 apart (about 25 days). (Bug#8664)
81
82 * xselect.c (last_event_timestamp): Remove duplicate decl.
83 (x_own_selection): Remove needless cast to unsigned long.
84
85 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
86 that always fit in int. Use a sentinel instead of a counter, to
87 avoid a temp and to allay GCC's concerns about possible int overflow.
88 * frame.h (struct frame): Use int for menu_bar_items_used
89 instead of EMACS_INT, since it always fits in int.
90
91 * menu.c (grow_menu_items): Check for int overflow.
92
93 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
94
95 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
96 Before, the code was not consistent. These values cannot exceed
97 2**31 - 1 so there's no need to make them unsigned.
98 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
99 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
100 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
101 as modifiers.
102 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
103
104 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
105 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
106 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
107 presumably because the widths might not match.
108
109 * window.c (size_window): Avoid needless test at loop start.
110
111 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
112
113 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
114
115 2011-05-12 Drew Adams <drew.adams@oracle.com>
116
117 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
118
119 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
120
121 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
122 `width' to `bar_area_x' and `bar_area_width', respectively.
123 (x_scroll_run): Take account of fringe background extension.
124
125 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
126 Rename local vars `left' and `width' to `bar_area_x' and
127 `bar_area_width', respectively.
128 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
129 background extension.
130
131 2011-05-10 Jim Meyering <meyering@redhat.com>
132
133 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
134
135 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
136
137 * image.c (Finit_image_library): Return t for built-in image types,
138 like pbm and xbm. (Bug#8640)
139
140 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
141
142 * w32menu.c (set_frame_menubar): Fix submenu allocation.
143
144 2011-05-07 Eli Zaretskii <eliz@gnu.org>
145
146 * w32console.c (Fset_screen_color): Doc fix.
147 (Fget_screen_color): New function.
148 (syms_of_ntterm): Defsubr it.
149
150 * callproc.c (call_process_cleanup): Don't close and unlink the
151 temporary file if Fcall_process didn't create it in the first
152 place.
153 (Fcall_process): Don't create tempfile if stdout of the child
154 process will be redirected to a file specified with `:file'.
155 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
156 cue to call_process_cleanup not to close that handle.
157
158 2011-05-07 Ben Key <bkey76@gmail.com>
159
160 * makefile.w32-in: The bootstrap-temacs rule now makes use of
161 one of two shell specific rules, either bootstrap-temacs-CMD or
162 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
163 to the previous implementation of the bootstrap-temacs rule.
164 The bootstrap-temacs-CMD rule is similar to the previous
165 implementation of the bootstrap-temacs rule except that it
166 makes use of the ESC_CFLAGS variable instead of the CFLAGS
167 variable.
168
169 These changes, along with some changes to nt/configure.bat,
170 nt/gmake.defs, and nt/nmake.defs, are required to extend my
171 earlier fix to add support for --cflags and --ldflags options
172 that include quotes so that it works whether make uses cmd or
173 sh as the shell.
174
175 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
176
177 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
178 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
179 is a constant.
180 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
181 a string. Handle both cases.
182 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
183 (Fdbus_register_method): Use Qinvalid_function.
184
185 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
186
187 * makefile.w32-in: Update dependencies.
188 (LISP_H): Add inttypes.h and stdin.h.
189 (PROCESS_H): Add unistd.h.
190
191 2011-05-06 Eli Zaretskii <eliz@gnu.org>
192
193 * lread.c: Include limits.h (fixes the MS-Windows build broken by
194 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
195
196 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
197
198 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
199
200 * term.c (vfatal): Remove stray call to va_end.
201 It's not needed and the C Standard doesn't allow it here anyway.
202
203 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
204 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
205
206 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
207 bytes.
208
209 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
210
211 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
212
213 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
214
215 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
216
217 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
218
219 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
220 * charset.c (Fdefine_charset_internal): Don't initialize
221 charset.code_space[15]. The value was garbage, on hosts with
222 32-bit int (Bug#8600).
223
224 * lread.c (read_integer): Be more consistent with string-to-number.
225 Use string_to_number to do the actual conversion; this avoids
226 rounding errors and fixes some other screwups. Without this fix,
227 for example, #x1fffffffffffffff was misread as -2305843009213693952.
228 (digit_to_number): Move earlier, for benefit of read_integer.
229 Return -1 if the digit is out of range for the base, -2 if it is
230 not a digit in any supported base. (Bug#8602)
231
232 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
233
234 * dispnew.c (scrolling_window): Return 1 if we scrolled,
235 to match comment at start of function. This also removes a
236 GCC warning about overflow in a 32+64-bit port.
237
238 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
239
240 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
241 Reported by Stefan Monnier in
242 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
243 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
244 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
245
246 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
247 (EMACS_UINTPTR): Likewise, with uintptr_t.
248
249 * lisp.h: Prefer 64-bit EMACS_INT if available.
250 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
251 on 32-bit hosts that have 64-bit int, so that they can access
252 large files.
253 However, temporarily disable this change unless the temporary
254 symbol WIDE_EMACS_INT is defined.
255
256 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
257
258 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
259 This removes an assumption that EMACS_INT and long are the same
260 width as pointers. The assumption is true for Emacs porting targets
261 now, but we want to make other targets possible.
262 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
263 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
264 In the rest of the code, change types of integers that hold casted
265 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
266 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
267 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
268 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
269 No need to cast type when ORing.
270 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
271 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
272 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
273 assume EMACS_INT is the same width as char *.
274 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
275 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
276 Remove no-longer-needed casts.
277 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
278 (xg_tool_bar_help_callback, xg_make_tool_item):
279 Use EMACS_INTPTR to hold an integer
280 that will be cast to void *; this can avoid a GCC warning
281 if EMACS_INT is not the same width as void *.
282 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
283 * xdisp.c (display_echo_area_1, resize_mini_window_1):
284 (current_message_1, set_message_1):
285 Use a local to convert to proper width without a cast.
286 * xmenu.c (dialog_selection_callback): Likewise.
287
288 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
289 Also, don't assume VALBITS / RAND_BITS is less than 5,
290 and don't rely on undefined behavior when shifting a 1 left into
291 the sign bit.
292 * lisp.h (get_random): Change signature to match.
293
294 * lread.c (hash_string): Use size_t, not int, for hash computation.
295 Normally we prefer signed values; but hashing is special, because
296 it's better to use unsigned division on hash table sizes so that
297 the remainder is nonnegative. Also, size_t is the natural width
298 for hashing into memory. The previous code used 'int', which doesn't
299 retain enough info to hash well into very large tables.
300 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
301
302 * dbusbind.c: Don't possibly lose pointer info when converting.
303 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
304 Use XPNTR rather than XHASH, so that the high-order bits of
305 the pointer aren't lost when converting through void *.
306
307 * eval.c (Fautoload): Don't double-shift a pointer.
308
309 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
310
311 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
312
313 * gnutls.c (DEF_GNUTLS_FN):
314 * image.c (DEF_IMGLIB_FN): Make function pointers static.
315
316 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
317
318 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
319 marker. (Bug#8610)
320
321 2011-05-05 Eli Zaretskii <eliz@gnu.org>
322
323 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
324 New version that can reserve upto 2GB of heap space.
325
326 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
327
328 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
329
330 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
331
332 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
333 `gnutls_certificate_set_x509_key_file'.
334
335 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
336
337 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
338 Update dependencies.
339
340 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
341
342 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
343 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
344 Remove unused parameter `fildes'.
345 * process.c (read_process_output, send_process): Don't pass it.
346
347 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
348
349 Fix previous change: the library cache is defined in w32.c.
350 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
351 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
352
353 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
354
355 Implement dynamic loading of GnuTLS on Windows.
356
357 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
358 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
359 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
360 Declare.
361
362 * gnutls.c (Qgnutls_dll): Define.
363 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
364 (gnutls_*): Declare function pointers.
365 (init_gnutls_functions): New function to initialize function pointers.
366 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
367 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
368 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
369 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
370 (emacs_gnutls_write, emacs_gnutls_read)
371 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
372 (Fgnutls_available_p): New function.
373 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
374 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
375 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
376
377 * image.c: Include w32.h.
378 (Vimage_type_cache): Delete.
379 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
380 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
381 (w32_delayed_load): Move to w32.c.
382
383 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
384
385 * w32.c (QCloaded_from, Vlibrary_cache): Define.
386 (w32_delayed_load): Move from image.c. When loading a library, record
387 its filename in the :loaded-from property of the library id.
388 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
389 Initialize and staticpro them.
390 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
391
392 * process.c: Include lisp.h before w32.h, not after.
393 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
394 instead of gnutls_record_check_pending.
395
396 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
397
398 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
399
400 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
401 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
402 as passed in.
403
404 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
405
406 * xterm.c (x_set_frame_alpha): Do not set property on anything
407 else than FRAME_X_OUTER_WINDOW (Bug#8608).
408
409 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
410
411 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
412
413 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
414
415 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
416 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
417 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
418 (gnutls_global_initialized, Qgnutls_bootprop_priority)
419 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
420 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
421 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
422 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
423 (Qgnutls_bootprop_callbacks_verify): Make static.
424
425 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
426
427 * callproc.c: Indentation fixup.
428
429 * sysdep.c (wait_for_termination_1): Make static.
430 (wait_for_termination, interruptible_wait_for_termination):
431 Move after wait_for_termination_1.
432
433 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
434
435 * sysdep.c (interruptible_wait_for_termination): New function
436 which is like wait_for_termination, but allows keyboard
437 interruptions.
438
439 * callproc.c (Fcall_process): Add (:file "file") as an option for
440 the STDOUT buffer.
441 (Fcall_process_region): Ditto.
442
443 2011-04-30 Eli Zaretskii <eliz@gnu.org>
444
445 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
446 rather than `XVECTOR (FOO)->size'.
447
448 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
449 inttypes.h, as a gnulib replacement is used if it not available in
450 system headers.
451
452 2011-04-21 Eli Zaretskii <eliz@gnu.org>
453
454 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
455 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
456 of MOST_POSITIVE_FIXNUM. (Bug#8528)
457
458 * coding.c (coding_alloc_by_realloc): Error out if destination
459 will grow beyond MOST_POSITIVE_FIXNUM.
460 (decode_coding_emacs_mule): Abort if there isn't enough place in
461 charbuf for the composition carryover bytes. Reserve an extra
462 space for up to 2 characters produced in a loop.
463 (decode_coding_iso_2022): Abort if there isn't enough place in
464 charbuf for the composition carryover bytes.
465
466 2011-04-21 Eli Zaretskii <eliz@gnu.org>
467
468 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
469 aborting when %lld or %lll format is passed.
470 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
471 %llo or %llx format is passed. (Bug#8545)
472
473 * window.c (window_scroll_line_based): Use a marker instead of
474 simple variables to record original value of point. (Bug#7952)
475
476 * doprnt.c (doprnt): Fix the case where a multibyte sequence
477 produced by %s or %c overflows available buffer space. (Bug#8545)
478
479 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
480
481 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
482 (SIZE_MAX): Move defn after all includes, as they might #define it.
483
484 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
485
486 * w32.c (init_environment): Warn about defaulting HOME to C:\.
487
488 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
489
490 * keyboard.c (Qdelayed_warnings_hook): Define.
491 (command_loop_1): Run `delayed-warnings-hook'
492 if Vdelayed_warnings_list is non-nil.
493 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
494 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
495
496 2011-04-28 Eli Zaretskii <eliz@gnu.org>
497
498 * doprnt.c (doprnt): Don't return value smaller than the buffer
499 size if the message was truncated. (Bug#8545).
500
501 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
502
503 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
504 (Fx_window_property): #if-0 the whole functions, not just the bodies.
505
506 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
507
508 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
509
510 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
511
512 * makefile.w32-in: Update dependencies.
513
514 2011-04-27 Eli Zaretskii <eliz@gnu.org>
515
516 Improve `doprnt' and its usage. (Bug#8545)
517 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
518 `format_end'. Remove support for %l as a conversion specifier.
519 Don't use xrealloc. Improve diagnostics when the %l size modifier
520 is used. Update the commentary.
521
522 * eval.c (verror): Simplify calculation of size_t.
523
524 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
525 messages.
526
527 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
528
529 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
530 change.
531
532 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
533
534 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
535 This makes this file independent of the recent pseudovector change.
536
537 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
538
539 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
540
541 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
542 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
543 Remove unused local.
544 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
545
546 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
547 GCC 4.6.0 optimizes based on type-based alias analysis.
548 For example, if b is of type struct buffer * and v of type struct
549 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
550 != &v->size, and therefore "v->size = 1; b->size = 2; return
551 v->size;" must therefore return 1. This assumption is incorrect
552 for Emacs, since it type-puns struct Lisp_Vector * with many other
553 types. To fix this problem, this patch adds a new type struct
554 vectorlike_header that documents the constraints on layout of vectors
555 and pseudovectors, and helps optimizing compilers not get fooled
556 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
557 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
558 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
559 the size member.
560 (XSETPVECTYPE): Rewrite in terms of new macro.
561 (XSETPVECTYPESIZE): New macro, specifying both type and size.
562 This is a bit clearer, and further avoids the possibility of
563 undesirable aliasing.
564 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
565 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
566 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
567 since Lisp_Subr is a special case (no "next" field).
568 (ASIZE): Now uses header.size rather than size.
569 All previous uses of XVECTOR (foo)->size replaced to use this macro,
570 to avoid the hassle of writing XVECTOR (foo)->header.size.
571 (struct vectorlike_header): New type.
572 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
573 object, to help avoid aliasing.
574 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
575 (SUBRP): Likewise, since Lisp_Subr is a special case.
576 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
577 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
578 (struct Lisp_Hash_Table): Combine first two members into a single
579 struct vectorlike_header member. All uses of "size" and "next" members
580 changed to be "header.size" and "header.next".
581 * buffer.h (struct buffer): Likewise.
582 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
583 * frame.h (struct frame): Likewise.
584 * process.h (struct Lisp_Process): Likewise.
585 * termhooks.h (struct terminal): Likewise.
586 * window.c (struct save_window_data, struct saved_window): Likewise.
587 * window.h (struct window): Likewise.
588 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
589 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
590 * buffer.c (init_buffer_once): Likewise.
591 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
592 special case.
593 * process.c (Fformat_network_address): Use local var for size,
594 for brevity.
595
596 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
597
598 Make the Lisp reader and string-to-float more consistent (Bug#8525)
599 * data.c (atof): Remove decl; no longer used or needed.
600 (digit_to_number): Move to lread.c.
601 (Fstring_to_number): Use new string_to_number function, to be
602 consistent with how the Lisp reader treats infinities and NaNs.
603 Do not assume that floating-point numbers represent EMACS_INT
604 without losing information; this is not true on most 64-bit hosts.
605 Avoid double-rounding errors, by insisting on integers when
606 parsing non-base-10 numbers, as the documentation specifies.
607 * lisp.h (string_to_number): New decl, replacing ...
608 (isfloat_string): Remove.
609 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
610 (read1): Do not accept +. and -. as integers; this
611 appears to have been a coding error. Similarly, do not accept
612 strings like +-1e0 as floating point numbers. Do not report
613 overflow for integer overflows unless the base is not 10 which
614 means we have no simple and reliable way to continue.
615 Break out the floating-point parsing into a new
616 function string_to_number, so that Fstring_to_number parses
617 floating point numbers consistently with the Lisp reader.
618 (digit_to_number): Move here from data.c. Make it static inline.
619 (E_CHAR, EXP_INT): Remove, replacing with ...
620 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
621 (string_to_number): New function, replacing isfloat_string.
622 This function checks for valid syntax and produces the resulting
623 Lisp float number too. Rework it so that string-to-number
624 no longer mishandles examples like "1.0e+". Use strtoumax,
625 so that overflow for non-base-10 numbers is reported only when
626 there's no portable and simple way to convert to floating point.
627
628 * textprop.c (set_text_properties_1): Rewrite for clarity,
629 and to avoid GCC warning about integer overflow.
630
631 * intervals.h (struct interval): Use EMACS_INT for members
632 where EMACS_UINT might cause problems. See
633 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
634 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
635 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
636 All uses changed.
637 (offset_intervals): Tell GCC not to worry about length overflow
638 when negating a negative length.
639
640 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
641 (overrun_check_free): Likewise.
642
643 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
644 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
645 word size.
646
647 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
648 (gnutls_make_error): Rename local to avoid shadowing.
649 (gnutls_emacs_global_deinit): ifdef out; not used.
650 (Fgnutls_boot): Use const for pointer to readonly storage.
651 Comment out unused local. Fix pointer signedness problems.
652
653 * lread.c (openp): Don't stuff size_t into an 'int'.
654 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
655 about possible signed overflow.
656
657 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
658 (GDK_KEY_g): Don't define if already defined.
659 (xg_prepare_tooltip): Avoid pointer signedness problem.
660 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
661
662 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
663 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
664
665 * xfns.c (Fx_window_property): Simplify a bit,
666 to make a bit faster and to avoid GCC 4.6.0 warning.
667 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
668
669 * fns.c (internal_equal): Don't assume size_t fits in int.
670
671 * alloc.c (compact_small_strings): Tighten assertion a little.
672
673 Replace pEd with more-general pI, and fix some printf arg casts.
674 * lisp.h (pI): New macro, generalizing old pEd macro to other
675 conversion specifiers. For example, use "...%"pI"d..." rather
676 than "...%"pEd"...".
677 (pEd): Remove. All uses replaced with similar uses of pI.
678 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
679 * alloc.c (check_pure_size): Don't overflow by converting size to int.
680 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
681 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
682 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
683 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
684 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
685 64-bit hosts.
686 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
687 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
688 * print.c (safe_debug_print, print_object): Likewise.
689 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
690 to int.
691 Use pI instead of if-then-else-abort. Use %p to avoid casts,
692 avoiding the 0 flag, which is not portable.
693 * process.c (Fmake_network_process): Use pI to avoid cast.
694 * region-cache.c (pp_cache): Likewise.
695 * xdisp.c (decode_mode_spec): Likewise.
696 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
697 behavior on 64-bit hosts with printf arg.
698 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
699 (x_stop_queuing_selection_requests): Likewise.
700 (x_get_window_property): Don't truncate byte count to an 'int'
701 when tracing.
702
703 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
704 here, since it parses constructs like leading '-' and spaces,
705 which are not wanted; and it overflows with large numbers.
706 Instead, simply match F[0-9]+, which is what is wanted anyway.
707
708 * alloc.c: Remove unportable assumptions about struct layout.
709 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
710 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
711 (allocate_vectorlike, make_pure_vector): Use the new macros,
712 plus offsetof, to remove unportable assumptions about struct layout.
713 These assumptions hold on all porting targets that I know of, but
714 they are not guaranteed, they're easy to remove, and removing them
715 makes further changes easier.
716
717 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
718 This doesn't fix a bug but makes the code clearer.
719 (string_overrun_cookie): Now const. Use initializers that
720 don't formally overflow signed char, to avoid warnings.
721 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
722 can cause Emacs to crash when string overrun checking is enabled.
723 (allocate_buffer): Don't assume sizeof (struct buffer) is a
724 multiple of sizeof (EMACS_INT); it need not be, if
725 alignof(EMACS_INT) < sizeof (EMACS_INT).
726 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
727
728 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
729
730 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
731
732 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
733
734 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
735 supposed to be handshaking. (Bug#8556)
736 Reported by Paul Eggert <eggert@cs.ucla.edu>.
737
738 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
739
740 * lisp.h (Qdebug): List symbol.
741 * eval.c (Qdebug): Restore global linkage.
742 * keyboard.c (debug-on-event): New variable.
743 (handle_user_signal): Break into debugger when debug-on-event
744 matches the current signal symbol.
745
746 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
747
748 * alloc.c (check_sblock, check_string_bytes)
749 (check_string_free_list): Convert to standard C.
750
751 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
752
753 * w32.c (emacs_gnutls_push): Fix typo.
754
755 2011-04-25 Eli Zaretskii <eliz@gnu.org>
756
757 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
758 "cast to pointer from integer of different size".
759
760 Improve doprnt and its use in verror. (Bug#8545)
761 * doprnt.c (doprnt): Document the set of format control sequences
762 supported by the function. Use SAFE_ALLOCA instead of always
763 using `alloca'.
764
765 * eval.c (verror): Don't limit the buffer size at size_max-1, that
766 is one byte too soon. Don't use xrealloc; instead xfree and
767 xmalloc anew.
768
769 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
770
771 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
772 callbacks stage.
773
774 * gnutls.c: Renamed global_initialized to
775 gnutls_global_initialized. Added internals for the
776 :verify-hostname-error, :verify-error, and :verify-flags
777 parameters of `gnutls-boot' and documented those parameters in the
778 docstring. Start callback support.
779 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
780 unless a fatal error occured. Call gnutls_alert_send_appropriate
781 on error. Return error code.
782 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
783 (emacs_gnutls_read): Likewise.
784 (Fgnutls_boot): Return handshake error code.
785 (emacs_gnutls_handle_error): New function.
786 (wsaerror_to_errno): Likewise.
787
788 * w32.h (emacs_gnutls_pull): Add prototype.
789 (emacs_gnutls_push): Likewise.
790
791 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
792 (emacs_gnutls_push): Likewise.
793
794 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
795
796 * process.c (wait_reading_process_output): Check if GnuTLS
797 buffered some data internally if no FDs are set for TLS
798 connections.
799
800 * makefile.w32-in (OBJ2): Add gnutls.$(O).
801 (LIBS): Link to USER_LIBS.
802 ($(BLD)/gnutls.$(0)): New target.
803
804 2011-04-24 Eli Zaretskii <eliz@gnu.org>
805
806 * xdisp.c (handle_single_display_spec): Rename the
807 display_replaced_before_p argument into display_replaced_p, to
808 make it consistent with the commentary. Fix typos in the
809 commentary.
810
811 * textprop.c (syms_of_textprop): Remove dead code.
812 (copy_text_properties): Delete obsolete commentary about an
813 interface that was deleted long ago. Fix typos in the description
814 of arguments.
815
816 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
817 to changes in oldXMenu/XMenu.h from 2011-04-16.
818 <menu_help_message, prev_menu_help_message>: Constify.
819 (IT_menu_make_room): menu->help_text is now `const char **';
820 adjust.
821
822 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
823 to changes in oldXMenu/XMenu.h from 2011-04-16.
824 (struct XMenu): Declare `help_text' `const char **'.
825
826 * xfaces.c <Qunspecified>: Make extern again.
827
828 * syntax.c: Include sys/types.h before including regex.h, as
829 required by Posix.
830
831 * doc.c (get_doc_string): Improve the format passed to `error'.
832
833 * doprnt.c (doprnt): Improve commentary.
834
835 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
836
837 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
838 them with etags.
839
840 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
841 changes in globals.h immediately force recompilation.
842 (TAGS): Depend on $(CURDIR)/m/intel386.h and
843 $(CURDIR)/s/ms-w32.h.
844 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
845
846 * character.c (Fchar_direction): Function deleted.
847 (syms_of_character): Don't defsubr it.
848 <char-direction-table>: Deleted.
849
850 2011-04-23 Eli Zaretskii <eliz@gnu.org>
851
852 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
853 * doprnt.c: Include limits.h.
854 (SIZE_MAX): New macro.
855 (doprnt): Return a size_t value. 2nd arg is now size_t.
856 Many local variables are now size_t instead of int or unsigned.
857 Improve overflow protection. Support `l' modifier for integer
858 conversions. Support %l conversion. Don't assume an EMACS_INT
859 argument for integer conversions and for %c.
860
861 * lisp.h (doprnt): Restore prototype.
862
863 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
864 $(SRC)/character.h.
865
866 * Makefile.in (base_obj): Add back doprnt.o.
867
868 * deps.mk (doprnt.o): Add back prerequisites.
869 (callint.o): Depend on character.h.
870
871 * eval.c (internal_lisp_condition_case): Include the handler
872 representation in the error message.
873 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
874 when breaking from the loop.
875
876 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
877
878 * callint.c (Fcall_interactively): When displaying error message
879 about invalid control letter, pass the character's codepoint, not
880 a pointer to its multibyte form. Improve display of the character
881 in octal and display also its hex code.
882
883 * character.c (char_string): Use %x to display the (unsigned)
884 codepoint of an invalid character, to avoid displaying a bogus
885 negative value.
886
887 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
888 `error', not SYMBOL_NAME itself.
889
890 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
891 character arguments to `error'.
892
893 * charset.c (check_iso_charset_parameter): Fix incorrect argument
894 to `error' in error message about FINAL_CHAR argument. Make sure
895 FINAL_CHAR is a character, and use %c when it is passed as
896 argument to `error'.
897
898 2011-04-23 Eli Zaretskii <eliz@gnu.org>
899
900 * s/ms-w32.h (localtime): Redirect to sys_localtime.
901
902 * w32.c: Include <time.h>.
903 (sys_localtime): New function.
904
905 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
906
907 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
908
909 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
910
911 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
912
913 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
914 zombies (Bug#8467).
915
916 2011-04-19 Eli Zaretskii <eliz@gnu.org>
917
918 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
919 gl_state.e_property when gl_state.object is Qt.
920
921 * insdel.c (make_gap_larger): Remove limitation of buffer size
922 to <= INT_MAX.
923
924 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
925
926 * xdisp.c (lookup_glyphless_char_display)
927 (produce_glyphless_glyph): Handle cons cell entry in
928 glyphless-char-display.
929 (Vglyphless_char_display): Document it.
930
931 * term.c (produce_glyphless_glyph): Handle cons cell entry in
932 glyphless-char-display.
933
934 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
935
936 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
937
938 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
939
940 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
941 definition for no-X builds.
942
943 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
944
945 Static checks with GCC 4.6.0 and non-default toolkits.
946
947 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
948
949 * process.c (keyboard_bit_set): Define only if SIGIO.
950 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
951 (send_process): Repair possible setjmp clobbering.
952
953 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
954
955 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
956
957 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
958
959 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
960 Define only if needed.
961
962 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
963 by pacifying GCC about it. Maybe it's time to retire it?
964 * xfaces.c (USG, __TIMEVAL__): Likewise.
965
966 * dispextern.h (struct redisplay_interface): Rename param
967 to avoid shadowing.
968 * termhooks.h (struct terminal): Likewise.
969 * xterm.c (xembed_send_message): Likewise.
970
971 * insdel.c (make_gap_smaller): Define only if
972 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
973
974 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
975 it.
976
977 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
978 so that we aren't warned about unused symbols.
979
980 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
981
982 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
983
984 * xfns.c (x_real_positions): Mark locals as initialized.
985
986 * xmenu.c (xmenu_show): Don't use uninitialized vars.
987
988 * xterm.c: Fix problems found by static analysis with other toolkits.
989 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
990 (x_dispatch_event): Declare static if USE_GTK, and
991 define if USE_GTK || USE_X_TOOLKIT.
992 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
993 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
994 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
995 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
996
997 * xmenu.c (menu_help_callback): Pointer type fixes.
998 Use const pointers when pointing at readonly data. Avoid pointer
999 signedness clashes.
1000 (FALSE): Remove unused macro.
1001 (update_frame_menubar): Remove unused decl.
1002
1003 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1004
1005 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1006 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1007 (single_menu_item): Rename local to avoid shadowing.
1008
1009 * keyboard.c (make_lispy_event): Remove unused local var.
1010
1011 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1012 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1013
1014 * bitmaps: Change bitmaps from unsigned char back to the X11
1015 compatible char. Avoid the old compiler warnings about
1016 out-of-range initializers by using, for example, '\xab' rather
1017 than 0xab.
1018
1019 * xgselect.c (xgselect_initialize): Check vs interface
1020 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1021
1022 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1023
1024 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1025 to read-only memory.
1026
1027 * fns.c (vector): Remove; this old hack is no longer needed.
1028
1029 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1030 Remove unused var.
1031 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1032
1033 * xrdb.c (x_load_resources): Omit unused local.
1034
1035 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1036 (x_window): Rename locals to avoid shadowing.
1037 (USG): Use the kludged USG macro, to pacify gcc.
1038
1039 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1040 (x_term_init): Remove local to avoid shadowing.
1041
1042 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1043
1044 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1045 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1046
1047 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1048
1049 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1050
1051 Fix regex.c, syntax.c and friends for buffers > 2GB.
1052 * syntax.h (struct gl_state_s): Declare character position members
1053 EMACS_INT.
1054
1055 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1056
1057 * textprop.c (verify_interval_modification, interval_of):
1058 Declare arguments EMACS_INT.
1059
1060 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1061 EMACS_INT.
1062
1063 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1064
1065 * indent.c (Fvertical_motion): Local variable it_start is now
1066 EMACS_INT.
1067
1068 * regex.c (re_match, re_match_2, re_match_2_internal)
1069 (bcmp_translate, regcomp, regexec, print_double_string)
1070 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1071 (re_compile_pattern, re_exec): Declare arguments and local
1072 variables `size_t' and `ssize_t' and return values `regoff_t', as
1073 appropriate.
1074 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1075 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1076 <compile_stack_type>: `size' and `avail' are now `size_t'.
1077
1078 * regex.h <regoff_t>: Use ssize_t, not int.
1079 (re_search, re_search_2, re_match, re_match_2): Arguments that
1080 specify buffer/string position and length are now ssize_t and
1081 size_t. Return type is regoff_t.
1082
1083 2011-04-16 Ben Key <bkey76@gmail.com>
1084
1085 * nsfont.m: Fixed bugs in ns_get_family and
1086 ns_descriptor_to_entity that were caused by using free to
1087 deallocate memory blocks that were allocated by xmalloc (via
1088 xstrdup). This caused Emacs to crash when compiled with
1089 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1090 --enable-checking=xmallocoverrun). xfree is now used to
1091 deallocate these memory blocks.
1092
1093 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1096
1097 emacs_write: Accept and return EMACS_INT for sizes.
1098 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1099 et seq.
1100 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1101 Accept and return EMACS_INT.
1102 (emacs_gnutls_write): Return the number of bytes written on
1103 partial writes.
1104 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1105 (emacs_read, emacs_write): Remove check for negative size, as the
1106 Emacs source code has been audited now.
1107 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1108 (emacs_read, emacs_write): Use it.
1109 * process.c (send_process): Adjust to the new signatures of
1110 emacs_write and emacs_gnutls_write. Do not attempt to store
1111 a byte offset into an 'int'; it might overflow.
1112 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1113
1114 * sound.c: Don't assume sizes fit in 'int'.
1115 (struct sound_device.period_size, alsa_period_size):
1116 Return EMACS_INT, not int.
1117 (struct sound_device.write, vox_write, alsa_write):
1118 Accept EMACS_INT, not int.
1119 (wav_play, au_play): Use EMACS_INT to store sizes and to
1120 record read return values.
1121
1122 2011-04-15 Ben Key <bkey76@gmail.com>
1123
1124 * keyboard.c (Qundefined): Don't declare static since it is used
1125 in nsfns.m.
1126 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1127 static since they are used in nsfont.m.
1128
1129 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1130
1131 * process.c (Qprocessp): Don't declare static.
1132 * lisp.h (Qprocessp): Declare again.
1133
1134 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1135
1136 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1137
1138 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 Improve C-level modularity by making more things 'static'.
1141
1142 Don't publish debugger-only interfaces to other modules.
1143 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1144 (verify_bytepos, count_markers): Move decls to the only modules
1145 that need them.
1146 * region-cache.h (pp_cache): Likewise.
1147 * window.h (check_all_windows): Likewise.
1148 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1149
1150 * sysdep.c (croak): Now static, if
1151 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1152 * syssignal.h (croak): Declare only if not static.
1153
1154 * alloc.c (refill_memory_reserve): Now static if
1155 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1156 * lisp.h (refill_memory_reserve): Declare only if not static.
1157
1158 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1159 Define only if USE_LUCID.
1160
1161 * xrdb.c (x_customization_string, x_rm_string): Now static.
1162
1163 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1164 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1165
1166 * xdisp.c (draw_row_with_mouse_face): Now static.
1167 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1168
1169 * window.h (check_all_windows): Mark externally visible.
1170
1171 * window.c (window_deletion_count): Now static.
1172
1173 * undo.c: Make symbols static if they're not exported.
1174 (last_undo_buffer, last_boundary_position, pending_boundary):
1175 Now static.
1176
1177 * textprop.c (interval_insert_behind_hooks): Now static.
1178 (interval_insert_in_front_hooks): Likewise.
1179
1180 * term.c: Make symbols static if they're not exported.
1181 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1182 (max_frame_lines, tty_set_terminal_modes):
1183 (tty_reset_terminal_modes, tty_turn_off_highlight):
1184 (get_tty_terminal): Now static.
1185 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1186 * termhooks.h (term_mouse_moveto): Do not declare if
1187 HAVE_WINDOW_SYSTEM.
1188 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1189 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1190
1191 * sysdep.c: Make symbols static if they're not exported.
1192 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1193 Now static.
1194 (sigprocmask_set, full_mask): Remove; unused.
1195 (wait_debugging): Mark as visible.
1196 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1197 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1198
1199 * syntax.c (syntax_temp): Define only if !__GNUC__.
1200
1201 * sound.c (current_sound_device, current_sound): Now static.
1202
1203 * search.c (searchbufs, searchbuf_head): Now static.
1204
1205 * scroll.c (scroll_cost): Remove; unused.
1206 * dispextern.h (scroll_cost): Remove decl.
1207
1208 * region-cache.h (pp_cache): Mark as externally visible.
1209
1210 * process.c: Make symbols static if they're not exported.
1211 (process_tick, update_tick, create_process, chan_process):
1212 (Vprocess_alist, proc_buffered_char, datagram_access):
1213 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1214 (deactivate_process): Mark defn as static, as well as decl.
1215 * lisp.h (create_process): Remove decl.
1216 * process.h (chan_process, Vprocess_alist): Remove decls.
1217
1218 * print.c: Make symbols static if they're not exported.
1219 (print_depth, new_backquote_output, being_printed, print_buffer):
1220 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1221 (print_interval, print_number_index, initial_stderr_stream):
1222 Now static.
1223 * lisp.h (Fprinc): Remove decl.
1224 (debug_output_compilation_hack): Mark as externally visible.
1225
1226 * sysdep.c (croak): Move decl from here to syssignal.h.
1227 * syssignal.h (croak): Put it here, so the API can be checked when
1228 'croak' is called from dissociate_if_controlling_tty.
1229
1230 * minibuf.c: Make symbols static if they're not exported.
1231 (minibuf_save_list, choose_minibuf_frame): Now static.
1232 * lisp.h (choose_minibuf_frame): Remove decl.
1233
1234 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1235
1236 * lread.c: Make symbols static if they're not exported.
1237 (read_objects, initial_obarray, oblookup_last_bucket_number):
1238 Now static.
1239 (make_symbol): Remove; unused.
1240 * lisp.h (initial_obarray, make_symbol): Remove decls.
1241
1242 * keyboard.c: Make symbols static if they're not exported.
1243 (single_kboard, recent_keys_index, total_keys, recent_keys):
1244 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1245 (this_single_command_key_start, echoing, last_auto_save):
1246 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1247 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1248 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1249 (Vlispy_mouse_stem, double_click_count):
1250 Now static.
1251 (force_auto_save_soon): Define only if SIGDANGER.
1252 (ignore_mouse_drag_p): Now static if
1253 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1254 (print_help): Remove; unused.
1255 (stop_character, last_timer_event): Mark as externally visible.
1256 * keyboard.h (ignore_mouse_drag_p): Declare only if
1257 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1258 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1259 * lisp.h (echoing): Remove decl.
1260 (force_auto_save_soon): Declare only if SIGDANGER.
1261 * xdisp.c (redisplay_window): Simplify code, to make it more
1262 obvious that ignore_mouse_drag_p is not accessed if !defined
1263 USE_GTK && !defined HAVE_NS.
1264
1265 * intervals.c: Make symbols static if they're not exported.
1266 (merge_properties_sticky, merge_interval_right, delete_interval):
1267 Now static.
1268 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1269
1270 * insdel.c: Make symbols static if they're not exported.
1271 However, leave prepare_to_modify_buffer alone. It's never
1272 called from outside this function, but that appears to be a bug.
1273 (combine_after_change_list, combine_after_change_buffer):
1274 (adjust_after_replace, signal_before_change): Now static.
1275 (adjust_after_replace_noundo): Remove; unused.
1276 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1277 (signal_before_change): Remove decls.
1278
1279 * indent.c (val_compute_motion, val_vmotion): Now static.
1280
1281 * image.c: Make symbols static if they're not exported.
1282 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1283 if USE_GTK.
1284 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1285 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1286
1287 * fringe.c (standard_bitmaps): Now static.
1288 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1289
1290 * frame.c: Make symbols static if they're not exported.
1291 (x_report_frame_params, make_terminal_frame): Now static.
1292 (get_frame_param): Now static, unless HAVE_NS.
1293 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1294 (x_get_resource_string): Remove; not used.
1295 * frame.h (make_terminal_frame, x_report_frame_params):
1296 (x_get_resource_string); Remove decls.
1297 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1298 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1299
1300 * font.c, fontset.c: Make symbols static if they're not exported.
1301 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1302 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1303 * font.c (font_close_object): Now static.
1304 * font.h (font_close_object): Remove.
1305 * fontset.c (FONTSET_OBJLIST): Remove.
1306 (free_realized_fontset) #if-0 the body, which does nothing.
1307 (face_suitable_for_char_p): #if-0, as it's never called.
1308 * fontset.h (face_suitable_for_char_p): Remove decl.
1309 * xfaces.c (face_at_string_position):
1310 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1311 since 0 is always ASCII.
1312
1313 * fns.c (weak_hash_tables): Now static.
1314
1315 * fileio.c: Make symbols static if they're not exported.
1316 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1317 (Vwrite_region_annotation_buffers): Now static.
1318
1319 * eval.c: Make symbols static if they're not exported.
1320 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1321 * lisp.h (backtrace_list): Remove decl.
1322
1323 * emacs.c: Make symbols static if they're not exported.
1324 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1325 (fatal_error_code, fatal_error_signal_hook, standard_args):
1326 Now static.
1327 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1328 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1329 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1330 * lisp.h (fatal_error_signal_hook): Remove decl.
1331 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1332
1333 * editfns.c: Move a (normally-unused) function to its only use.
1334 * editfns.c, lisp.h (get_operating_system_release): Remove.
1335 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1336 worth the hassle of breaking this out.
1337
1338 * xterm.c: Make symbols static if they're not exported.
1339 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1340 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1341 (x_destroy_window, x_delete_display):
1342 Now static.
1343 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1344 (x_mouse_leave): Remove; unused.
1345 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1346 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1347 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1348 Remove decls.
1349 (x_mouse_leave): Declare only if WINDOWSNT.
1350 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1351 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1352 USE_X_TOOLKIT.
1353
1354 * ftxfont.c: Make symbols static if they're not exported.
1355 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1356 HAVE_FREETYPE.
1357 * font.h (ftxfont_driver): Likewise.
1358
1359 * xfns.c: Make symbols static if they're not exported.
1360 (x_last_font_name, x_display_info_for_name):
1361 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1362 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1363 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1364 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1365 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1366 (last_show_tip_args): Now static.
1367 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1368 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1369 (x_screen_planes): Remove; unused.
1370 * dispextern.h (x_screen_planes): Remove decl.
1371
1372 * dispnew.c: Make symbols static if they're not exported.
1373 * dispextern.h (redraw_garbaged_frames, scrolling):
1374 (increment_row_positions): Remove.
1375 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1376 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1377 Now static.
1378 (redraw_garbaged_frames): Remove; unused.
1379
1380 * xfaces.c: Make symbols static if they're not exported.
1381 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1382 Remove decls.
1383 * xterm.h (defined_color): Remove decls.
1384 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1385 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1386 (menu_face_changed_default, defined_color, free_realized_face):
1387 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1388 (ascii_face_of_lisp_face): Remove; unused.
1389
1390 * xdisp.c: Make symbols static if they're not exported.
1391 * dispextern.h (scratch_glyph_row, window_box_edges):
1392 (glyph_to_pixel_coords, set_cursor_from_row):
1393 (get_next_display_element, set_iterator_to_next):
1394 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1395 (show_mouse_face): Remove decls
1396 * frame.h (message_buf_print): Likewise.
1397 * lisp.h (pop_message, set_message, check_point_in_composition):
1398 Likewise.
1399 * xterm.h (set_vertical_scroll_bar): Likewise.
1400 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1401 (message_buf_print, scratch_glyph_row, displayed_buffer):
1402 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1403 (get_next_display_element, show_mouse_face, window_box_edges):
1404 (frame_to_window_pixel_xy, check_point_in_composition):
1405 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1406 (glyph_to_pixel_coords): Remove; unused.
1407
1408 * dired.c (file_name_completion): Now static.
1409
1410 * dbusbind.c (xd_in_read_queued_messages): Now static.
1411
1412 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1413 * data.c (circular_list_error): Remove.
1414
1415 * commands.h (last_point_position, last_point_position_buffer):
1416 (last_point_position_window): Remove decls.
1417 * keyboard.c: Make these variables static.
1418
1419 * coding.h (coding, code_convert_region, encode_coding_gap):
1420 Remove decls.
1421 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1422 (iso_code_class, detect_coding, code_convert_region): Now static.
1423 (encode_coding_gap): Remove; unused.
1424
1425 * chartab.c (chartab_chars, chartab_bits): Now static.
1426
1427 * charset.h (charset_iso_8859_1): Remove decl.
1428 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1429 Now static.
1430
1431 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1432 * ccl.c (Vccl_program_table): Now static.
1433 (check_ccl_update): Remove; unused.
1434
1435 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1436 * category.h: ... from here.
1437 * category.c (check_category_table, set_category_set): Now static.
1438
1439 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1440 * lisp.h: Remove these decls.
1441
1442 * buffer.c (buffer_count): Remove unused var.
1443
1444 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1445 so that it's not optimized away.
1446 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1447 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1448 exported only to the debugger.
1449
1450 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1451 * atimer.h (run_all_atimers): Remove; not exported.
1452
1453 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1454 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1455 was inaccessible from Lisp.
1456 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1457 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1458
1459 alloc.c: Import and export fewer symbols, and remove unused items.
1460 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1461 is defined.
1462 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1463 it's not optimized away by whole-program optimization.
1464 (message_enable_multibyte, free_misc): Remove.
1465 (catchlist, handlerlist, mark_backtrace):
1466 Declare only if BYTE_MARK_STACK.
1467 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1468 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1469 (message_enable_multibyte): Remove decl.
1470 (free_misc, interval_free_list, float_block, float_block_index):
1471 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1472 (cons_free_list, last_marked_index):
1473 Now static.
1474 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1475 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1476 (mark_backtrace): Define only if BYTE_MARK_STACK.
1477 * xdisp.c (message_enable_multibyte): Now static.
1478
1479 Declare Lisp_Object Q* variables to be 'static' if not exported.
1480 This makes it easier for human readers (and static analyzers)
1481 to see whether these variables are used from other modules.
1482 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1483 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1484 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1485 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1486 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1487 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1488 * xmenu.c, xselect.c:
1489 Declare Q* vars static if they are not used in other modules.
1490 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1491 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1492 Remove decls of unexported vars.
1493 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1494
1495 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1496
1497 Make Emacs functions such as Fatom 'static' by default.
1498 This makes it easier for human readers (and static analyzers)
1499 to see whether these functions can be called from other modules.
1500 DEFUN now defines a static function. To make the function external
1501 so that it can be used in other C modules, use the new macro DEFUE.
1502 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1503 (Finit_image_library):
1504 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1505 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1506 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1507 Remove decls, since these functions are now static.
1508 (Funintern, Fget_internal_run_time): New decls, since these functions
1509 were already external.
1510
1511 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1512 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1513 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1514 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1515 * keyboard.c, keymap.c, lread.c:
1516 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1517 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1518 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1519 Mark functions with DEFUE instead of DEFUN,
1520 if they are used in other modules.
1521 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1522 decls for now-static functions.
1523 * buffer.h (Fdelete_overlay): Remove decl.
1524 * callproc.c (Fgetenv_internal): Mark as internal.
1525 * composite.c (Fremove_list_of_text_properties): Remove decl.
1526 (Fcomposition_get_gstring): New forward static decl.
1527 * composite.h (Fcomposite_get_gstring): Remove decl.
1528 * dired.c (Ffile_attributes): New forward static decl.
1529 * doc.c (Fdocumntation_property): New forward static decl.
1530 * eval.c (Ffetch_bytecode): New forward static decl.
1531 (Funintern): Remove extern decl; now in .h file where it belongs.
1532 * fileio.c (Fmake_symbolic_link): New forward static decl.
1533 * image.c (Finit_image_library): New forward static decl.
1534 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1535 * intervals.h (Fprevious_property_change):
1536 (Fremove_list_of_text_properties): Remove decls.
1537 * keyboard.c (Fthis_command_keys): Remove decl.
1538 (Fcommand_execute): New forward static decl.
1539 * keymap.c (Flookup_key): New forward static decl.
1540 (Fcopy_keymap): Now static.
1541 * keymap.h (Flookup_key): Remove decl.
1542 * process.c (Fget_process): New forward static decl.
1543 (Fprocess_datagram_address): Mark as internal.
1544 * syntax.c (Fsyntax_table_p): New forward static decl.
1545 (skip_chars): Remove duplicate decl.
1546 * textprop.c (Fprevious_property_change): New forward static decl.
1547 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1548 Now internal.
1549 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1550 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1551
1552 * editfns.c (Fformat): Remove unreachable code.
1553
1554 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1555
1556 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1557 change. (Bug#8496)
1558
1559 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1560
1561 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1562 when at ZV. (Bug#8487)
1563
1564 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1565
1566 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1567 (Bug#8437)
1568 * keyboard.c (parse_tool_bar_item): Likewise.
1569 * sound.c (sound_cleanup, alsa_close): Likewise.
1570 * termcap.c (tgetent): Likewise.
1571 * xfns.c (x_default_font_parameter): Likewise.
1572 * xsettings.c (read_and_apply_settings): Likewise.
1573
1574 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1575 (overrun_check_free): Protoize.
1576
1577 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1578
1579 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1580 since callers should never pass a negative size.
1581 Change the signature to match that of plain 'read' and 'write'; see
1582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1583 * lisp.h: Update prototypes of emacs_write and emacs_read.
1584
1585 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1586
1587 * xdisp.c (redisplay_window): Don't try to determine the character
1588 position of the scroll margin if the window start point w->startp
1589 is outside the buffer's accessible region. (Bug#8468)
1590
1591 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1592
1593 Fix write-region and its subroutines for buffers > 2GB.
1594 * fileio.c (a_write, e_write): Modify declaration of arguments and
1595 local variables to support buffers larger than 2GB.
1596 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1597
1598 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1599 argument, local variables, and return value.
1600
1601 * lisp.h: Update prototypes of emacs_write and emacs_read.
1602
1603 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1604
1605 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1608
1609 Fix more problems found by GCC 4.6.0's static checks.
1610
1611 * xdisp.c (vmessage): Use a better test for character truncation.
1612
1613 * charset.c (load_charset_map): <, not <=, for optimization,
1614 and to avoid potential problems with integer overflow.
1615 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1616 * casetab.c (set_identity, shuffle): Likewise.
1617 * editfns.c (Fformat): Likewise.
1618 * syntax.c (skip_chars): Likewise.
1619
1620 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1621 This also lets GCC 4.6.0 generate slightly better loop code.
1622
1623 * callint.c (Fcall_interactively): <, not <=, for optimization.
1624 (Fcall_interactively): Count the number of arguments produced,
1625 not the number of arguments given. This is simpler and lets GCC
1626 4.6.0 generate slightly better code.
1627
1628 * ftfont.c: Distingish more carefully between FcChar8 and char.
1629 The previous code passed unsigned char * to a functions like
1630 strlen and xstrcasecmp that expect char *, which does not
1631 conform to the C standard.
1632 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1633 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1634 char * when the C standard requires it.
1635
1636 * keyboard.c (read_char): Remove unused var.
1637
1638 * eval.c: Port to Windows vsnprintf (Bug#8435).
1639 Include <limits.h>.
1640 (SIZE_MAX): Define if the headers do not.
1641 (verror): Do not give up if vsnprintf returns a negative count.
1642 Instead, grow the buffer. This ports to Windows vsnprintf, which
1643 does not conform to C99. Problem reported by Eli Zaretskii.
1644 Also, simplify the allocation scheme, by avoiding the need for
1645 calling realloc, and removing the ALLOCATED variable.
1646
1647 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1648
1649 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1650 But keep the doprint source code for now, as we might revamp it
1651 and use it again (Bug#8435).
1652 * lisp.h (doprnt): Remove.
1653 * Makefile.in (base_obj): Remove doprnt.o.
1654 * deps.mk (doprnt.o): Remove.
1655
1656 error: Print 32- and 64-bit integers portably (Bug#8435).
1657 Without this change, on typical 64-bit hosts error ("...%d...", N)
1658 was used to print both 32- and 64-bit integers N, which relied on
1659 undefined behavior.
1660 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1661 New macro.
1662 * lisp.h (error, verror): Mark as printf-like functions.
1663 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1664 Report overflow in size calculations when allocating printf buffer.
1665 Do not truncate output string at its first null byte.
1666 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1667 Truncate the output at a character boundary, since vsnprintf does not
1668 do that.
1669 * charset.c (check_iso_charset_parameter): Convert internal
1670 character to string before calling 'error', since %c now has the
1671 printf meaning.
1672 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1673 overflow when computing char to be passed to 'error'. Do not
1674 pass Lisp_Object to 'error'; pass the integer instead.
1675 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1676 formatted with plain %d.
1677
1678 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1679
1680 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1681
1682 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1683
1684 * xterm.c (x_catch_errors): Remove duplicate declaration.
1685
1686 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1687
1688 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1689
1690 2011-04-10 Jim Meyering <meyering@redhat.com>
1691
1692 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1693 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1694 return ssize_t not "int", and use size_t as the buffer length.
1695 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1696 * gnutls.h: Update declarations.
1697 * process.c (read_process_output): Use ssize_t, to match.
1698 (send_process): Likewise.
1699
1700 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1701
1702 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1703
1704 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1705
1706 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1707 Use unsigned char, to match FcChar8 type definition.
1708
1709 * xterm.c (handle_one_xevent):
1710 * xmenu.c (create_and_show_popup_menu):
1711 * xselect.c (x_decline_selection_request)
1712 (x_reply_selection_request): Avoid type-punned deref of X events.
1713
1714 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1715
1716 Fix some uses of `int' instead of EMACS_INT.
1717 * search.c (string_match_1, fast_string_match)
1718 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1719 (scan_buffer, find_next_newline_no_quit)
1720 (find_before_next_newline, search_command, Freplace_match)
1721 (Fmatch_data): Make some `int' variables be EMACS_INT.
1722
1723 * xdisp.c (display_count_lines): 3rd argument and return value now
1724 EMACS_INT. All callers changed.
1725 (pint2hrstr): Last argument is now EMACS_INT.
1726
1727 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1728 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1729 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1730 (decode_coding_utf_16, decode_coding_emacs_mule)
1731 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1732 (decode_coding_ccl, decode_coding_charset)
1733 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1734 (decode_coding_iso_2022, decode_coding_emacs_mule)
1735 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1736 <char_offset, last_offset>: Declare EMACS_INT.
1737 (encode_coding_utf_8, encode_coding_utf_16)
1738 (encode_coding_emacs_mule, encode_invocation_designation)
1739 (encode_designation_at_bol, encode_coding_iso_2022)
1740 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1741 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1742 Declare EMACS_INT.
1743 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1744 (encode_invocation_designation): Last argument P_NCHARS is now
1745 EMACS_INT.
1746 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1747 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1748
1749 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1750 All users changed.
1751
1752 * ccl.c (Fccl_execute_on_string): Declare some variables
1753 EMACS_INT.
1754
1755 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1756
1757 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1758
1759 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1760
1761 * process.c (Fformat_network_address): Doc fix.
1762
1763 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1764
1765 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1766
1767 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1768
1769 * keyboard.c (read_char): Call Lisp function help-form-show,
1770 instead of using internal_with_output_to_temp_buffer.
1771 (Qhelp_form_show): New var.
1772 (syms_of_keyboard): Use DEFSYM macro.
1773
1774 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1775
1776 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1777
1778 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1779
1780 * process.c (Flist_processes): Remove to Lisp.
1781 (list_processes_1): Delete.
1782
1783 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1784
1785 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1786
1787 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1788
1789 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 Fix more problems found by GCC 4.6.0's static checks.
1792
1793 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1794
1795 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1796
1797 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1798
1799 * xdisp.c (vmessage): Mark as a printf-like function.
1800
1801 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1802
1803 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1804
1805 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1806 printf-like functions.
1807 (tiff_load): Add casts to remove these marks before passing them
1808 to system-supplied API.
1809
1810 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1811
1812 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1813 This avoids several warnings with gcc -Wstrict-overflow.
1814 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1815 directly, rather than having caller test rule sign. This avoids
1816 some unnecessary tests.
1817 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1818 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1819 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1820
1821 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1822 (xfont_open): Avoid unnecessary tests.
1823
1824 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1825
1826 * composite.h, composite.c (composition_gstring_put_cache):
1827 Use EMACS_INT, not int, for length.
1828
1829 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1830 breaking out part of COMPOSITION_DECODE_RULE.
1831 (COMPOSITION_DECODE_RULE): Use it.
1832 * composite.c (get_composition_id): Remove unused local vars,
1833 by using the new macro.
1834
1835 * textprop.c (set_text_properties_1): Change while to do-while,
1836 since the condition is always true at first.
1837
1838 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1839 (interval_deletion_adjustment): Return unsigned value.
1840 All uses changed.
1841
1842 * process.c (list_processes_1, create_pty, read_process_output):
1843 (exec_sentinel): Remove vars that were set but not used.
1844 (create_pty): Remove unnecessary "volatile"s.
1845 (Fnetwork_interface_info): Avoid possibility of int overflow.
1846 (read_process_output): Do adaptive read buffering even if carryover.
1847 (read_process_output): Simplify nbytes computation if buffered.
1848
1849 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1850
1851 * syntax.c (scan_words): Remove var that was set but not used.
1852 (update_syntax_table): Use unsigned instead of int.
1853
1854 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1855 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1856 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1857
1858 * print.c (print_error_message): Avoid int overflow.
1859
1860 * font.c (font_list_entities): Redo for clarity,
1861 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1862
1863 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1864 (font_score): Avoid potential overflow in diff calculation.
1865
1866 * fns.c (substring_both): Remove var that is set but not used.
1867 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1868
1869 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1870
1871 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1872 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1873 can always succeed if overflow has undefined behavior.
1874
1875 * search.c (boyer_moore, wordify): Remove vars set but not used.
1876 (wordify): Omit three unnecessary tests.
1877
1878 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1879 All callers changed. This avoids the need for an unused var.
1880
1881 * casefiddle.c (casify_region): Remove var that is set but not used.
1882
1883 * dired.c (file_name_completion): Remove var that is set but not used.
1884
1885 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1886
1887 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1888 (Finsert_file_contents): Remove unnecessary code checking fd.
1889
1890 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1891 Check for integer overflow on size calculations.
1892
1893 * buffer.c (Fprevious_overlay_change): Remove var that is set
1894 but not used.
1895
1896 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1897 Remove vars that are set but not used.
1898 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1899 (timer_check_2): Mark vars as initialized.
1900
1901 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1902
1903 * image.c (lookup_image): Remove var that is set but not used.
1904 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1905
1906 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1907 that are set but not used.
1908
1909 * xfns.c (make_invisible_cursor): Don't return garbage
1910 if XCreateBitmapFromData fails (Bug#8410).
1911
1912 * xselect.c (x_get_local_selection, x_handle_property_notify):
1913 Remove vars that are set but not used.
1914
1915 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1916 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1917
1918 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1919 Remove var that is set but not used.
1920 (scroll_bar_windows_size): Now size_t, not int.
1921 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1922 Check for overflow.
1923
1924 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1925 (map_tty_color) [!defined MSDOS]: Likewise.
1926
1927 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1928
1929 * coding.c: Remove vars that are set but not used.
1930 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1931 All callers changed.
1932 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1933 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1934 (decode_coding_charset): Remove vars that are set but not used.
1935
1936 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1937 that is set but not used.
1938
1939 * print.c (print_object): Remove var that is set but not used.
1940
1941 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1942 The gnulib version avoids calling malloc in the usual case,
1943 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1944 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1945 * filelock.c (current_lock_owner): Likewise.
1946 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1947 * sysdep.c: Include allocator.h, careadlinkat.h.
1948 (emacs_no_realloc_allocator): New static constant.
1949 (emacs_readlink): New function.
1950 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1951 ../lib/careadlinkat.h.
1952
1953 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1954
1955 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1956 first non-nil return value).
1957
1958 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1959
1960 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1961 if not defined (Bug#8403).
1962
1963 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1964
1965 * xdisp.c (display_count_lines): Remove parameter `start',
1966 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1967 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1968 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1969 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1970 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1971 and thereabouts. All callers changed.
1972 (get_per_char_metric): Remove parameter `f', unused since
1973 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1974
1975 2011-04-02 Jim Meyering <meyering@redhat.com>
1976
1977 do not dereference NULL upon failed strdup
1978 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1979 (ns_get_family): Likewise.
1980
1981 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1982
1983 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1984
1985 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1986
1987 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1988 later (Bug#8403).
1989
1990 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1991
1992 Add lexical binding.
1993
1994 * window.c (Ftemp_output_buffer_show): New fun.
1995 (Fsave_window_excursion):
1996 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1997
1998 * lread.c (lisp_file_lexically_bound_p): New function.
1999 (Fload): Bind Qlexical_binding.
2000 (readevalloop): Remove `evalfun' arg.
2001 Bind Qinternal_interpreter_environment.
2002 (Feval_buffer): Bind Qlexical_binding.
2003 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2004 Mark as dynamic.
2005 (syms_of_lread): Declare `lexical-binding'.
2006
2007 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2008
2009 * keyboard.c (eval_dyn): New fun.
2010 (menu_item_eval_property): Use it.
2011
2012 * image.c (parse_image_spec): Use Ffunctionp.
2013
2014 * fns.c (concat, mapcar1): Accept byte-code-functions.
2015
2016 * eval.c (Fsetq): Handle lexical vars.
2017 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2018 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2019 (FletX, Flet): Obey lexical binding.
2020 (Fcommandp): Handle closures.
2021 (Feval): New `lexical' arg.
2022 (eval_sub): New function extracted from Feval. Use it almost
2023 everywhere where Feval was used. Look up vars in lexical env.
2024 Handle closures.
2025 (Ffunctionp): Move from subr.el.
2026 (Ffuncall): Handle closures.
2027 (apply_lambda): Remove `eval_flags'.
2028 (funcall_lambda): Handle closures and new byte-code-functions.
2029 (Fspecial_variable_p): New function.
2030 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2031 but without exporting it to Lisp.
2032
2033 * doc.c (Fdocumentation, store_function_docstring):
2034 * data.c (Finteractive_form): Handle closures.
2035
2036 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2037 interactive spec.
2038
2039 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2040 New byte-codes.
2041 (exec_byte_code): New function extracted from Fbyte_code to handle new
2042 calling convention for byte-code-functions. Add new byte-codes.
2043
2044 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2045
2046 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2047
2048 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * xdisp.c (redisplay_internal): Fix prototype.
2051
2052 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2053
2054 * xdisp.c (SCROLL_LIMIT): New macro.
2055 (try_scrolling): Use it when setting scroll_limit.
2056 Limit scrolling to 100 screen lines.
2057 (redisplay_window): Even when falling back on "recentering",
2058 position point in the window according to scroll-conservatively,
2059 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2060
2061 (try_scrolling): When point is above the window, allow searching
2062 as far as scroll_max, or one screenful, to compute vertical
2063 distance from PT to the scroll margin position. This prevents
2064 try_scrolling from unnecessarily failing when
2065 scroll-conservatively is set to a value slightly larger than the
2066 window height. Clean up the case of PT below the margin at bottom
2067 of window: scroll_max can no longer be INT_MAX. When aggressive
2068 scrolling is in use, don't let point enter the opposite scroll
2069 margin as result of the scroll.
2070 (syms_of_xdisp) <scroll-conservatively>: Document the
2071 threshold of 100 lines for never-recentering scrolling.
2072
2073 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * dispextern.h (move_it_by_lines):
2076 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2077 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2078 (message_log_check_duplicate): Remove parameters `prev_bol' and
2079 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2080 (redisplay_internal): Remove parameter `preserve_echo_area',
2081 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2082
2083 * indent.c (Fvertical_motion):
2084 * window.c (window_scroll_pixel_based, Frecenter):
2085 Don't pass `need_y_p' to `move_it_by_lines'.
2086
2087 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2088
2089 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2090 steal a few bits to be more compact.
2091 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2092 Remove unneeded casts.
2093
2094 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2095
2096 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2097
2098 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2099 binding" message (bug#7967).
2100
2101 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2102
2103 Fix more problems found by GCC 4.6.0's static checks.
2104
2105 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2106 Remove unused local var.
2107
2108 * editfns.c (Fmessage_box): Remove unused local var.
2109
2110 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2111 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2112 Omit unused local vars.
2113 * window.c (shrink_windows): Omit unused local var.
2114 * menu.c (digest_single_submenu): Omit unused local var.
2115 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2116 Omit unused local var.
2117
2118 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2119 Don't assume string length fits in int.
2120 (keyremap_step, read_key_sequence): Use size_t for sizes.
2121 (read_key_sequence): Don't check last_real_key_start redundantly.
2122
2123 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2124 instead of alloca (Bug#8344).
2125
2126 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2127 (Fbacktrace_frame): Don't assume nframes fits in int.
2128
2129 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2130
2131 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2132 concerns.
2133
2134 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2135
2136 * cm.c (calccost): Turn while-do into do-while, for clarity.
2137
2138 * keyboard.c (syms_of_keyboard): Use the same style as later
2139 in this function when indexing through an array. This also
2140 works around GCC bug 48267.
2141
2142 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2143
2144 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2145
2146 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2147 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2148
2149 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2150 This avoids undefined behavior on integer overflow, and is a bit
2151 more convenient anyway since it is compared to a size_t variable.
2152
2153 Variadic C functions now count arguments with size_t, not int.
2154 This avoids an unnecessary limitation on 64-bit machines, which
2155 caused (substring ...) to crash on large vectors (Bug#8344).
2156 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2157 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2158 All variadic functions and their callers changed accordingly.
2159 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2160 * data.c (arith_driver, float_arith_driver): Likewise.
2161 * editfns.c (general_insert_function): Likewise.
2162 * eval.c (struct backtrace.nargs, interactive_p)
2163 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2164 (funcall_lambda, mark_backtrace): Likewise.
2165 * fns.c (concat): Likewise.
2166 * frame.c (x_set_frame_parameters): Likewise.
2167 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2168 0 if not found, not -1. All callers changed.
2169
2170 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2171 (stack_copy_size): Now size_t, not int.
2172 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2173
2174 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2175
2176 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2177 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2178 All callers changed.
2179
2180 * lisp.h (multibyte_char_to_unibyte):
2181 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2182 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2183 * character.h (CHAR_TO_BYTE8):
2184 * cmds.c (internal_self_insert):
2185 * editfns.c (general_insert_function):
2186 * keymap.c (push_key_description):
2187 * search.c (Freplace_match):
2188 * xdisp.c (message_dolog, set_message_1): All callers changed.
2189
2190 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2191
2192 * keyboard.c (safe_run_hook_funcall): New function.
2193 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2194 don't set the hook to nil, but remove the offending function instead.
2195 (Qcommand_hook_internal): Remove, unused.
2196 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2197 Vcommand_hook_internal.
2198
2199 * eval.c (enum run_hooks_condition): Remove.
2200 (funcall_nil, funcall_not): New functions.
2201 (run_hook_with_args): Call each function through a `funcall' argument.
2202 Remove `cond' argument, now redundant.
2203 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2204 (Frun_hook_with_args_until_failure): Adjust accordingly.
2205 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2206
2207 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2208
2209 * dispextern.h (string_buffer_position): Remove declaration.
2210
2211 * print.c (strout): Remove parameter `multibyte', unused since
2212 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2213
2214 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2215 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2216 All callers changed.
2217
2218 * w32.c (_wsa_errlist): Use braces for struct initializers.
2219
2220 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2221 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2222 All callers changed.
2223 (string_buffer_position): Likewise. Also, make static (it's never
2224 used outside xdisp.c).
2225 (cursor_row_p): Remove parameter `w', unused since
2226 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2227 (decode_mode_spec): Remove parameter `precision', introduced during
2228 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2229 All callers changed.
2230
2231 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2232
2233 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2234
2235 2011-03-27 Anders Lindgren <andlind@gmail.com>
2236
2237 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2238 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2239 (ns_update_auto_hide_menu_bar): New functions.
2240 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2241 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2242 ns_constrain_all_frames.
2243 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2244 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2245
2246 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2247
2248 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2249
2250 2011-03-27 Glenn Morris <rgm@gnu.org>
2251
2252 * syssignal.h: Replace RETSIGTYPE with void.
2253 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2254 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2255 Replace SIGTYPE with void everywhere.
2256 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2257 * s/template.h (SIGTYPE): Remove commented out definition.
2258
2259 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2260
2261 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2262 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2263
2264 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2265
2266 * w32.c (read_unc_volume): Use parameter `henum', instead of
2267 global variable `wget_enum_handle'.
2268
2269 * keymap.c (describe_vector): Remove parameters `indices' and
2270 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2271 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2272
2273 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2274
2275 * keyboard.c (timer_check): Remove parameter `do_it_now',
2276 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2277 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2278 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2279
2280 * keyboard.c (read_char):
2281 * w32menu.c (w32_menu_display_help):
2282 * xmenu.c (show_help_event, menu_help_callback):
2283 Adjust calls to `show_help_echo'.
2284
2285 * gtkutil.c (xg_maybe_add_timer):
2286 * keyboard.c (readable_events):
2287 * process.c (wait_reading_process_output):
2288 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2289
2290 * insdel.c (adjust_markers_gap_motion):
2291 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2292 (gap_left, gap_right): Don't call it.
2293
2294 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2295
2296 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2297 incurred during fontification.
2298
2299 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2300
2301 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2302 (DEFVAR_PER_BUFFER): Don't pass it.
2303
2304 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2305 (scrolling_window): Don't pass it.
2306
2307 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2308
2309 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2310
2311 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2312 and `suffix'.
2313 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2314 of variables specific to SELinux and computation of `encoded_absname'.
2315
2316 * image.c (XPutPixel): Remove unused variable `height'.
2317
2318 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2319
2320 * unexw32.c (get_section_info): Remove unused variable `section'.
2321
2322 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2323 (system_process_attributes): Remove unused variable `sess'.
2324 (sys_read): Remove unused variable `err'.
2325
2326 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2327 (w32_wnd_proc): Remove unused variable `isdead'.
2328 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2329 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2330 (x_create_tip_frame): Remove unused variable `tem'.
2331
2332 * w32inevt.c (w32_console_read_socket):
2333 Remove unused variable `no_events'.
2334
2335 * w32term.c (x_draw_composite_glyph_string_foreground):
2336 Remove unused variable `width'.
2337
2338 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2339
2340 * w32term.c (x_set_glyph_string_clipping):
2341 Don't pass uninitialized region to CombineRgn.
2342
2343 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2344
2345 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2346 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2347 (Fx_close_connection): Remove unused variable `i'.
2348
2349 * w32font.c (w32font_draw): Return number of glyphs.
2350 (w32font_open_internal): Remove unused variable `i'.
2351 (w32font_driver): Add missing initializer.
2352
2353 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2354 (fill_in_menu): Remove unused variable `items_added'.
2355
2356 * w32term.c (last_mouse_press_frame): Remove static global variable.
2357 (w32_clip_to_row): Remove unused variable `f'.
2358 (x_delete_terminal): Remove unused variable `i'.
2359
2360 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2361 (NOTHING): Remove unused static global variable.
2362 (uniscribe_check_otf): Remove unused variable `table'.
2363 (uniscribe_font_driver): Add missing initializers.
2364
2365 2011-03-23 Julien Danjou <julien@danjou.info>
2366
2367 * term.c (Fsuspend_tty, Fresume_tty):
2368 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2369 * window.c (temp_output_buffer_show):
2370 * insdel.c (signal_before_change):
2371 * frame.c (Fhandle_switch_frame):
2372 * fileio.c (Fdo_auto_save):
2373 * emacs.c (Fkill_emacs):
2374 * editfns.c (save_excursion_restore):
2375 * cmds.c (internal_self_insert):
2376 * callint.c (Fcall_interactively):
2377 * buffer.c (Fkill_all_local_variables):
2378 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2379 Use Frun_hooks.
2380 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2381 unconditionnaly since it does the check itself.
2382
2383 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2384
2385 Fix more problems found by GCC 4.5.2's static checks.
2386
2387 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2388 the first time through the loop, since we know p0 < p1 then.
2389 This also avoids a gcc -Wstrict-overflow warning.
2390
2391 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2392 leading to a memory leak, possible in functions like
2393 load_charset_map_from_file that can allocate an unbounded number
2394 of objects (Bug#8318).
2395
2396 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2397 that could (at least in theory) be that large.
2398
2399 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2400 This is less likely to overflow, and avoids undefined behavior if
2401 overflow does occur. All callers changed. Use strtoul to scan
2402 for the unsigned long integer.
2403 (pint2hrstr): Simplify and tune code slightly.
2404 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2405
2406 * scroll.c (do_scrolling): Work around GCC bug 48228.
2407 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2408
2409 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2410 This also avoids a warning with gcc -Wstrict-overflow.
2411 (validate_x_resource_name): Simplify count usage.
2412 This also avoids a warning with gcc -Wstrict-overflow.
2413
2414 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2415 fail (Bug#8306).
2416
2417 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2418
2419 * process.c (Fmake_network_process): Use socklen_t, not int,
2420 where POSIX says socklen_t is required in portable programs.
2421 This fixes a porting bug on hosts like 64-bit HP-UX, where
2422 socklen_t is wider than int (Bug#8277).
2423 (Fmake_network_process, server_accept_connection):
2424 (wait_reading_process_output, read_process_output):
2425 Likewise.
2426
2427 * process.c: Rename or move locals to avoid shadowing.
2428 (list_processes_1, Fmake_network_process):
2429 (read_process_output_error_handler, exec_sentinel_error_handler):
2430 Rename or move locals.
2431 (Fmake_network_process): Define label "retry_connect" only if needed.
2432 (Fnetwork_interface_info): Fix pointer signedness.
2433 (process_send_signal): Add cast to avoid pointer signedness problem.
2434 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2435 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2436
2437 Make tparam.h and terminfo.c consistent.
2438 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2439 Include tparam.h instead, since it declares them.
2440 * cm.h (PC): Remove extern decl; tparam.h now does this.
2441 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2442 * terminfo.c: Include tparam.h, to check interfaces.
2443 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2444 (tparam): Adjust signature to match interface in tparam.h;
2445 this removes some undefined behavior. Check that outstring and len
2446 are zero, which they always are with Emacs.
2447 * tparam.h (PC, BC, UP): New extern decls.
2448
2449 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2450 (xftfont_open): Rename locals to avoid shadowing.
2451
2452 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2453 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2454 (OTF_TAG_SYM): Omit macro if not needed.
2455 (ftfont_list): Remove unused local.
2456 (get_adstyle_property, ftfont_pattern_entity):
2457 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2458 Rename locals to avoid shadowing.
2459
2460 * xfont.c (xfont_list_family): Mark var as initialized.
2461
2462 * xml.c (make_dom): Now static.
2463
2464 * composite.c (composition_compute_stop_pos): Rename local to
2465 avoid shadowing.
2466 (composition_reseat_it): Remove unused locals.
2467 (find_automatic_composition, composition_adjust_point): Likewise.
2468 (composition_update_it): Mark var as initialized.
2469 (find_automatic_composition): Mark vars as initialized,
2470 with a FIXME (Bug#8290).
2471
2472 character.h: Rename locals to avoid shadowing.
2473 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2474 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2475 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2476 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2477 to avoid shadowing.
2478
2479 * textprop.c (property_change_between_p): Remove; unused.
2480
2481 * intervals.c (interval_start_pos): Now static.
2482
2483 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2484
2485 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2486 Rename locals to avoid shadowing.
2487
2488 * sound.c (wav_play, au_play, Fplay_sound_internal):
2489 Fix pointer signedness.
2490 (alsa_choose_format): Remove unused local var.
2491 (wav_play): Initialize a variable to 0, to prevent undefined
2492 behavior (Bug#8278).
2493
2494 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2495
2496 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2497
2498 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2499 clobbering (Bug#8298).
2500 * sysdep.c (sys_subshell): Likewise.
2501 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2502
2503 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2504 This should get cleaned up, so that child_setup has the
2505 same signature on all platforms.
2506
2507 * callproc.c (call_process_cleanup): Now static.
2508 (relocate_fd): Rename locals to avoid shadowing.
2509
2510 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2511
2512 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2513 not to be necessary, and produces flickering.
2514
2515 2011-03-20 Glenn Morris <rgm@gnu.org>
2516
2517 * config.in: Remove file.
2518
2519 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2520
2521 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2522 are now in src/globals.h.
2523 (syms_of_minibuf): Remove spurious & from previous change.
2524
2525 2011-03-20 Leo <sdl.web@gmail.com>
2526
2527 * minibuf.c (completing-read-function): New variable.
2528 (completing-read-default): Rename from completing-read.
2529 (completing-read): Call completing-read-function.
2530
2531 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2532
2533 * xfaces.c (Fx_load_color_file):
2534 Read color file from absolute filename (bug#8250).
2535
2536 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2537
2538 * makefile.w32-in: Update dependencies.
2539
2540 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2541
2542 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2543
2544 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2545
2546 Fix more problems found by GCC 4.5.2's static checks.
2547
2548 * process.c (make_serial_process_unwind, send_process_trap):
2549 (sigchld_handler): Now static.
2550
2551 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2552 That way, the code declares only the vars that it needs.
2553 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2554 * s/cygwin.h (PTY_ITERATION): Likewise.
2555 * s/darwin.h (PTY_ITERATION): Likewise.
2556 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2557
2558 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2559 * process.c (allocate_pty): Don't declare stb unless it's needed.
2560
2561 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2562 (CONSTANTLIM): Remove; unused.
2563 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2564 Define only if needed.
2565
2566 * unexelf.c (unexec): Name an expression,
2567 to avoid gcc -Wbad-function-cast warning.
2568 Use a different way to cause a compilation error if anyone uses
2569 n rather than nn, a way that does not involve shadowing.
2570 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2571
2572 * deps.mk (unexalpha.o): Remove; unused.
2573
2574 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2575 * unexec.h: New file.
2576 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2577 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2578 Depend on unexec.h.
2579 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2580 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2581 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2582 Change as necessary to match prototype in unexec.h.
2583
2584 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2585 shadowing.
2586 (back_comment, skip_chars): Mark vars as initialized.
2587
2588 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2589 Rename locals to avoid shadowing.
2590
2591 * lread.c (read1): Rewrite so as not to use empty "else".
2592 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2593
2594 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2595
2596 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2597 warning when compiling print.c.
2598
2599 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2600 instead of using an uninitialized var.
2601 (font_sort_entities): Mark var as initialized.
2602
2603 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2604
2605 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2606 pointers to constants.
2607 (font_parse_fcname): Remove unused vars.
2608 (font_delete_unmatched): Now static.
2609 (font_get_spec): Remove; unused.
2610 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2611 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2612 Rename or move locals to avoid shadowing.
2613
2614 * fns.c (require_nesting_list, require_unwind): Now static.
2615 (Ffillarray): Rename locals to avoid shadowing.
2616
2617 * floatfns.c (domain_error2): Define only if needed.
2618 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2619
2620 * alloc.c (mark_backtrace): Move decl from here ...
2621 * lisp.h: ... to here, so that it can be checked.
2622
2623 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2624 (Fdefvar): Rewrite so as not to use empty "else".
2625 (lisp_indirect_variable): Name an expression,
2626 to avoid gcc -Wbad-function-cast warning.
2627 (Fdefvar): Rename locals to avoid shadowing.
2628
2629 * callint.c (quotify_arg, quotify_args): Now static.
2630 (Fcall_interactively): Rename locals to avoid shadowing.
2631 Use const pointer when appropriate.
2632
2633 * lisp.h (get_system_name, get_operating_system_release):
2634 Move decls here, to check interfaces.
2635 * process.c (get_operating_system_release): Move decl to lisp.h.
2636 * xrdb.c (get_system_name): Likewise.
2637 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2638 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2639 some of which prompt warnings from gcc -Wbad-function-cast.
2640 (Fformat_time_string, Fencode_time, Finsert_char):
2641 (Ftranslate_region_internal, Fformat):
2642 Rename or remove local vars to avoid shadowing.
2643 (Ftranslate_region_internal): Mark var as initialized.
2644
2645 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2646 avoid shadowing.
2647
2648 * lisp.h (eassert): Check that the argument compiles, even if
2649 ENABLE_CHECKING is not defined.
2650
2651 * data.c (Findirect_variable): Name an expression, to avoid
2652 gcc -Wbad-function-cast warning.
2653 (default_value, arithcompare, arith_driver, arith_error): Now static.
2654 (store_symval_forwarding): Rename local to avoid shadowing.
2655 (Fmake_variable_buffer_local, Fmake_local_variable):
2656 Mark variables as initialized.
2657 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2658
2659 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2660 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2661 Rename locals to avoid shadowing.
2662 (mark_stack): Move local variables into the #ifdef region where
2663 they're used.
2664 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2665 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2666 needed otherwise.
2667 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2668 (GC_STRING_CHARS): Remove; not used.
2669 (Fmemory_limit): Cast sbrk's returned value to char *.
2670
2671 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2672 avoids undefined behavior in theory.
2673
2674 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2675
2676 Use functions, not macros, for up- and down-casing (Bug#8254).
2677 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2678 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2679 to use the following functions instead of these macros.
2680 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2681 EMACS_INT, since callers assume the returned value fits in int.
2682 (upcase1): Likewise, for UPCASE_TABLE.
2683 (uppercasep, lowercasep, upcase): New static inline functions.
2684 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2685 the race-condition problem in the old DOWNCASE.
2686
2687 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2688 Rename locals to avoid shadowing.
2689 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2690 (regex_compile, re_search_2, re_match_2_internal):
2691 Remove unused local vars.
2692 (FREE_VAR): Rewrite so as not to use empty "else",
2693 which gcc can warn about.
2694 (regex_compile, re_match_2_internal): Mark locals as initialized.
2695 (RETALLOC_IF): Define only if needed.
2696 (WORDCHAR_P): Likewise. This one is never needed, but is used
2697 only in a comment talking about a compiler bug, so put inside
2698 the #if 0 of that comment.
2699 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2700 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2701 Remove; unused.
2702
2703 * search.c (boyer_moore): Rename locals to avoid shadowing.
2704 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2705 (PREV_CHAR_BOUNDARY): Likewise.
2706
2707 * search.c (simple_search): Remove unused var.
2708
2709 * dired.c (compile_pattern): Move decl from here ...
2710 * lisp.h: ... to here, so that it can be checked.
2711 (struct re_registers): New forward decl.
2712
2713 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2714
2715 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2716 All uses changed.
2717 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2718 Rename locals to avoid shadowing.
2719 (Fvertical_motion): Mark locals as initialized.
2720
2721 * casefiddle.c (casify_object, casify_region): Now static.
2722 (casify_region): Mark local as initialized.
2723
2724 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2725
2726 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2727 New macros, so that the caller can use some names other than
2728 gcpro1, gcpro2, etc.
2729 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2730 of the new macros.
2731 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2732 argument, for consistency with GCPRO2_VAR, etc: it is now the
2733 prefix of the variable, not the variable itself. All uses
2734 changed.
2735 * dired.c (directory_files_internal, file_name_completion):
2736 Rename locals to avoid shadowing.
2737
2738 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2739 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2740 dired.c's scmp function, had undefined behavior.
2741 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2742 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2743 * buffer.h: ... to here, because these macros use current_buffer,
2744 and the new implementation with inline functions needs to have
2745 current_buffer in scope now, rather than later when the macros
2746 are used.
2747 (downcase, upcase1): New static inline functions.
2748 (DOWNCASE, UPCASE1): Reimplement using these functions.
2749 This avoids undefined behavior in expressions like
2750 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2751 from race conditions in accessing the global variables
2752 case_temp1 and case_temp2.
2753 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2754 * lisp.h (case_temp1, case_temp2): Remove their decls.
2755 * character.h (ASCII_CHAR_P): Move from here ...
2756 * lisp.h: ... to here, so that the inline functions mentioned
2757 above can use them.
2758
2759 * dired.c (directory_files_internal_unwind): Now static.
2760
2761 * fileio.c (file_name_as_directory, directory_file_name):
2762 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2763 Now static.
2764 (file_name_as_directory): Use const pointers when appropriate.
2765 (Fexpand_file_name): Likewise. In particular, newdir might
2766 point at constant storage, so make it a const pointer.
2767 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2768 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2769 signedness issues.
2770 (Fset_file_times, Finsert_file_contents, auto_save_error):
2771 Rename locals to avoid shadowing.
2772
2773 * minibuf.c (choose_minibuf_frame_1): Now static.
2774 (Ftry_completion, Fall_completions): Rename or remove locals
2775 to avoid shadowing.
2776
2777 * marker.c (bytepos_to_charpos): Remove; unused.
2778
2779 * lisp.h (verify_bytepos, count_markers): New decls,
2780 so that gcc does not warn that these functions aren't declared.
2781
2782 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2783 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2784 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2785 (copy_text): Remove unused local var.
2786
2787 * filelock.c (within_one_second): Now static.
2788 (lock_file_1): Rename local to avoid shadowing.
2789
2790 * buffer.c (fix_overlays_before): Mark locals as initialized.
2791 (fix_start_end_in_overlays): Likewise. This function should be
2792 simplified by using pointers-to-pointers, but that's a different
2793 matter.
2794 (switch_to_buffer_1): Now static.
2795 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2796 (report_overlay_modification): Rename locals to avoid shadowing.
2797
2798 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2799 Fix pointer signedness issue.
2800 (sys_subshell): Mark local as volatile if checking for lint,
2801 to suppress a gcc -Wclobbered warning that does not seem to be right.
2802 (MAXPATHLEN): Define only if needed.
2803
2804 * process.c (serial_open, serial_configure): Move decls from here ...
2805 * systty.h: ... to here, so that they can be checked.
2806
2807 * fns.c (get_random, seed_random): Move extern decls from here ...
2808 * lisp.h: ... to here, so that they can be checked.
2809
2810 * sysdep.c (reset_io): Now static.
2811 (wait_for_termination_signal): Remove; unused.
2812
2813 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2814 (copy_keymap_item, append_key, push_text_char_description):
2815 Now static.
2816 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2817 (DENSE_TABLE_SIZE): Remove; unused.
2818 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2819 (describe_map_tree):
2820 Rename locals to avoid shadowing.
2821
2822 * keyboard.c: Declare functions static if they are not used elsewhere.
2823 (echo_char, echo_dash, cmd_error, top_level_2):
2824 (poll_for_input, handle_async_input): Now static.
2825 (read_char, kbd_buffer_get_event, make_lispy_position):
2826 (make_lispy_event, make_lispy_movement, apply_modifiers):
2827 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2828 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2829 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2830 (read_key_sequence, read_char): Mark locals as initialized.
2831 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2832
2833 * keyboard.h (make_ctrl_char): New decl.
2834 (mark_kboards): Move decl here ...
2835 * alloc.c (mark_kboards): ... from here.
2836
2837 * lisp.h (force_auto_save_soon): New decl.
2838
2839 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2840 (DEFINE_DUMMY_FUNCTION): New macro.
2841 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2842 Use it.
2843 (main): Add casts to avoid warnings
2844 if GCC considers string literals to be constants.
2845
2846 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2847
2848 * dbusbind.c: Pointer signedness fixes.
2849 (xd_signature, xd_append_arg, xd_initialize):
2850 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2851 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2852 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2853 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2854
2855 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2856 if GCC considers string literals to be constants.
2857 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2858
2859 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2860
2861 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2862 (print_preprocess, print_object): New macro to fix last change.
2863
2864 * print.c (print_preprocess): Don't forget font objects.
2865
2866 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2867
2868 * emacs.c (USAGE3): Doc fixes.
2869
2870 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2871
2872 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2873 structure.
2874
2875 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * lisp.h (VWindow_system, Qfile_name_history):
2878 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2879 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2880 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2881
2882 * w32select.c: Don't #include "keyboard.h".
2883 (run_protected): Add extern declaration for waiting_for_input.
2884
2885 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2886 * w32console.c (detect_input_pending, read_input_pending)
2887 (encode_terminal_code):
2888 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2889 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2890 (w32_system_caret_y, Qfile_name_history):
2891 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2892 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2893 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2894 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2895 * w32proc.c (Qlocal, report_file_error):
2896 * w32term.c (Vwindow_system, updating_frame):
2897 * w32uniscribe.c (initialized, uniscribe_font_driver):
2898 Remove unneeded extern declarations.
2899
2900 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2901
2902 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2903
2904 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2905
2906 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2907 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2908 These macros can no longer be used for assignment.
2909
2910 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2911 Assign struct members directly, instead of using BUF_BEGV etc.
2912 (record_buffer_markers, fetch_buffer_markers): New functions for
2913 recording and fetching special buffer markers.
2914 (set_buffer_internal_1, set_buffer_temp): Use them.
2915
2916 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2917
2918 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2919
2920 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2921 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2922
2923 * xdisp.c (hscroll_window_tree):
2924 (reconsider_clip_changes): Use PT instead of BUF_PT.
2925
2926 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2927
2928 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2929 $(EMACS_ROOT)/lib/intprops.h.
2930
2931 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 Fix more problems found by GCC 4.5.2's static checks.
2934
2935 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2936 to unsigned char * to avoid compiler diagnostic.
2937 (xg_free_frame_widgets): Make it clear that a local variable is
2938 needed only if USE_GTK_TOOLTIP.
2939 (gdk_window_get_screen): Make it clear that this macro is needed
2940 only if USE_GTK_TOOLTIP.
2941 (int_gtk_range_get_value): New function, which avoids a diagnostic
2942 from gcc -Wbad-function-cast.
2943 (xg_set_toolkit_scroll_bar_thumb): Use it.
2944 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2945 diagnostic from gcc -Wbad-function-cast.
2946 (get_utf8_string, xg_get_file_with_chooser):
2947 Rename locals to avoid shadowing.
2948 (create_dialog): Move locals to avoid shadowing.
2949
2950 * xgselect.c (xg_select): Remove unused var.
2951
2952 * image.c (four_corners_best): Mark locals as initialized.
2953 (gif_load): Initialize transparent_p to zero (Bug#8238).
2954 Mark another local as initialized.
2955 (my_png_error, my_error_exit): Mark with NO_RETURN.
2956
2957 * image.c (clear_image_cache): Now static.
2958 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2959 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2960 (x_edge_detection): Remove unnecessary cast that
2961 gcc -Wbad-function-cast diagnoses.
2962 (gif_load): Fix pointer signedness.
2963 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2964 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2965
2966 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 Improve quality of tests for time stamp overflow.
2969 For example, without this patch (encode-time 0 0 0 1 1
2970 1152921504606846976) returns the obviously-bogus value (-948597
2971 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2972 reports time overflow. See
2973 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2974 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2975 * editfns.c: Include limits.h and intprops.h.
2976 (TIME_T_MIN, TIME_T_MAX): New macros.
2977 (time_overflow): Move earlier, to before first use.
2978 (hi_time, lo_time): New functions, for an accurate test for
2979 out-of-range times.
2980 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2981 (Fget_internal_run_time): Don't assume time_t fits in int.
2982 (make_time): Use list2 instead of Fcons twice.
2983 (Fdecode_time): More accurate test for out-of-range times.
2984 (check_tm_member): New function.
2985 (Fencode_time): Use it, to test for out-of-range times.
2986 (lisp_time_argument): Don't rely on undefined left-shift and
2987 right-shift behavior when checking for time stamp overflow.
2988
2989 * editfns.c (time_overflow): New function, refactoring common code.
2990 (Fformat_time_string, Fdecode_time, Fencode_time):
2991 (Fcurrent_time_string): Use it.
2992
2993 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2994 * dired.c (make_time): Move to ...
2995 * editfns.c (make_time): ... here.
2996 * systime.h: Note the move.
2997
2998 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2999
3000 * fringe.c (update_window_fringes): Remove unused variables.
3001
3002 * unexmacosx.c (copy_data_segment): Also copy __got section.
3003 (Bug#8223)
3004
3005 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3006
3007 * termcap.c [MSDOS]: Include "msdos.h".
3008 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3009 Constify `char *' arguments and their references according to
3010 prototypes in tparam.h.
3011
3012 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3013
3014 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3015 Adapt all references accordingly.
3016
3017 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3018
3019 2011-03-11 Tom Tromey <tromey@redhat.com>
3020
3021 * buffer.c (syms_of_buffer): Remove obsolete comment.
3022
3023 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3024
3025 * termhooks.h (encode_terminal_code): Declare prototype.
3026
3027 * msdos.c (encode_terminal_code): Don't declare prototype.
3028
3029 * term.c (encode_terminal_code): Now external again, used by
3030 w32console.c and msdos.c.
3031
3032 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3033 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3034
3035 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3036
3037 Fix some minor problems found by GCC 4.5.2's static checks.
3038
3039 * fringe.c (update_window_fringes): Mark locals as initialized
3040 (Bug#8227).
3041 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3042
3043 * alloc.c (mark_fringe_data): Move decl from here ...
3044 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3045 to check its interface.
3046 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3047
3048 * fontset.c (free_realized_fontset): Now static.
3049 (Fset_fontset_font): Rename local to avoid shadowing.
3050 (fontset_font): Mark local as initialized.
3051 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3052
3053 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3054
3055 * xselect.c (x_disown_buffer_selections): Remove; not used.
3056 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3057 (x_own_selection, Fx_disown_selection_internal): Rename locals
3058 to avoid shadowing.
3059 (x_handle_dnd_message): Remove local to avoid shadowing.
3060
3061 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3062 so that the caller can use some name other than gcpro1.
3063 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3064 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3065 (Fx_backspace_delete_keys_p):
3066 Use them to avoid shadowing, and rename vars to avoid shadowing.
3067 (x_decode_color, x_set_name, x_window): Now static.
3068 (Fx_create_frame): Add braces to silence GCC warning.
3069 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3070 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3071 Remove unused locals.
3072 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3073 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3074 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3075 macros.
3076
3077 * xterm.h (x_mouse_leave): New decl.
3078
3079 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3080 Remove unused functions.
3081 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3082 (x_calc_absolute_position): Now static.
3083 (XTread_socket): Don't define label "out" unless it's used.
3084 Don't declare local "event" unless it's used.
3085 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3086 unless they are used.
3087 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3088 (x_fatal_error_signal): Remove; not used.
3089 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3090 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3091 (x_error_catcher, x_connection_closed, x_error_handler):
3092 (x_error_quitter, xembed_send_message, x_iconify_frame):
3093 (my_log_handler): Rename locals to avoid shadowing.
3094 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3095 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3096
3097 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3098 Rename or move locals to avoid shadowing.
3099 (tty_defined_color, merge_face_heights): Now static.
3100 (free_realized_faces_for_fontset): Remove; not used.
3101 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3102 does not deduce is never used uninitialized.
3103 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3104 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3105
3106 * terminal.c (store_terminal_param): Now static.
3107
3108 * xmenu.c (menu_highlight_callback): Now static.
3109 (set_frame_menubar): Remove unused local.
3110 (xmenu_show): Rename parameter to avoid shadowing.
3111 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3112 since they might point to immutable storage.
3113 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3114 since it's unused otherwise.
3115
3116 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3117 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3118 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3119 avoids a gcc -Wuninitialized diagnostic.
3120 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3121 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3122 does not deduce are never used uninitialized.
3123
3124 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3125
3126 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3127 * window.c (window_loop, size_window):
3128 (run_window_configuration_change_hook, enlarge_window): Likewise.
3129
3130 * window.c (display_buffer): Now static.
3131 (size_window): Mark variables that gcc -Wuninitialized
3132 does not deduce are never used uninitialized.
3133 * window.h (check_all_windows): New decl, to forestall
3134 gcc -Wmissing-prototypes diagnostic.
3135 * dispextern.h (bidi_dump_cached_states): Likewise.
3136
3137 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3138 shadowing.
3139 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3140 Include <limits.h>.
3141 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3142 and to avoid gcc -Wuninitialized warning.
3143 (load_charset_map): Mark variables that gcc -Wuninitialized
3144 does not deduce are never used uninitialized.
3145 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3146
3147 * coding.c (coding_set_source, coding_set_destination):
3148 Use "else { /* comment */ }" rather than "else /* comment */;"
3149 for clarity, and to avoid gcc -Wempty-body warning.
3150 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3151 a block, when the outer 'i' will do.
3152 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3153 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3154 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3155 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3156 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3157 Rename locals to avoid shadowing.
3158 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3159 * coding.c (emacs_mule_char, encode_invocation_designation):
3160 Now static, since they're not used elsewhere.
3161 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3162 (decode_coding_object, encode_coding_object, detect_coding_system):
3163 (decode_coding_emacs_mule): Mark variables that gcc
3164 -Wuninitialized does not deduce are never used uninitialized.
3165 (detect_coding_iso_2022): Initialize a local variable that might
3166 be used uninitialized. Leave a FIXME because it's not clear that
3167 this initialization is needed. (Bug#8211)
3168 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3169 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3170 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3171 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3172 Remove unused macros.
3173
3174 * category.c (hash_get_category_set): Remove unused local var.
3175 (copy_category_table): Now static, since it's not used elsewhere.
3176 * character.c (string_count_byte8): Likewise.
3177
3178 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3179 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3180
3181 * chartab.c (copy_sub_char_table): Now static, since it's not used
3182 elsewhere.
3183 (sub_char_table_ref_and_range, char_table_ref_and_range):
3184 Rename locals to avoid shadowing.
3185 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3186
3187 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3188 (BIDI_BOB): Remove unused macro.
3189
3190 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3191 deduce are never used uninitialized.
3192 * term.c (encode_terminal_code): Likewise.
3193
3194 * term.c (encode_terminal_code): Now static. Remove unused local.
3195
3196 * tparam.h: New file.
3197 * term.c, tparam.h: Include it.
3198 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3199 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3200 Move these decls to tparam.h, and make them agree with what
3201 is actually in tparam.c. The previous trick of using incompatible
3202 decls in different modules does not conform to the C standard.
3203 All callers of tparam changed to use tparam's actual API.
3204 * tparam.c (tparam1, tparam, tgoto):
3205 Use const pointers where appropriate.
3206
3207 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3208 * cm.h (struct cm): Likewise.
3209 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3210 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3211 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3212 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3213 (turn_on_face, init_tty): Likewise.
3214 * termchar.h (struct tty_display_info): Likewise.
3215
3216 * term.c (term_mouse_position): Rename local to avoid shadowing.
3217
3218 * alloc.c (mark_ttys): Move decl from here ...
3219 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3220
3221 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3222
3223 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3224
3225 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * search.c (compile_pattern_1): Remove argument regp, unused since
3228 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3229 (compile_pattern): Don't pass it.
3230
3231 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3232
3233 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3234 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3235 for ! HAVE_GTK3.
3236 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3237
3238 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3239
3240 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3241 gdk_window_get_screen, gdk_window_get_geometry,
3242 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3243 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3244 (xg_get_pixbuf_from_pixmap): New function.
3245 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3246 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3247 Call xg_get_pixbuf_from_pixmap instead of
3248 gdk_pixbuf_get_from_drawable.
3249 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3250 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3251 (xg_check_special_colors): Use GtkStyleContext and its functions
3252 for HAVE_GTK3.
3253 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3254 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3255 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3256 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3257 Call gtk_widget_get_preferred_size.
3258 (xg_frame_resized): gdk_window_get_geometry only takes 5
3259 parameters.
3260 (xg_win_to_widget, xg_event_is_for_menubar):
3261 Call gdk_x11_window_lookup_for_display.
3262 (xg_set_widget_bg): New function.
3263 (delete_cb): New function.
3264 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3265 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3266 (xg_set_background_color): Call xg_set_widget_bg.
3267 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3268 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3269 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3270 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3271 if ! HAVE_GTK3.
3272 (update_frame_tool_bar): Call gtk_widget_hide.
3273 (xg_initialize): Use GDK_KEY_g.
3274
3275 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3276 if ! HAVE_GTK3
3277 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3278
3279 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3280 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3281 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3282
3283 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3284
3285 * w32xfns.c (select_palette): Check success of RealizePalette against
3286 GDI_ERROR, not zero.
3287
3288 See ChangeLog.11 for earlier changes.
3289
3290 ;; Local Variables:
3291 ;; coding: utf-8
3292 ;; End:
3293
3294 Copyright (C) 2011 Free Software Foundation, Inc.
3295
3296 This file is part of GNU Emacs.
3297
3298 GNU Emacs is free software: you can redistribute it and/or modify
3299 it under the terms of the GNU General Public License as published by
3300 the Free Software Foundation, either version 3 of the License, or
3301 (at your option) any later version.
3302
3303 GNU Emacs is distributed in the hope that it will be useful,
3304 but WITHOUT ANY WARRANTY; without even the implied warranty of
3305 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3306 GNU General Public License for more details.
3307
3308 You should have received a copy of the GNU General Public License
3309 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.