Fixes: debbugs:8806
[bpt/emacs.git] / src / ChangeLog
CommitLineData
810928a2
AS
12011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2
172418ad
AS
3 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4 format. (Bug#8806)
5
43f862f7
AS
6 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7
810928a2
AS
8 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9 before statements.
10
a059fe24
JD
112011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12
13 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14
15 * gtkutil.h: Declare xg_get_default_scrollbar_width.
16
17 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
18 min width by calling x_set_scroll_bar_default_width (Bug#8505).
19
989bf368
JB
202011-06-05 Juanma Barranquero <lekktu@gmail.com>
21
22 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
23
4b80f674
CY
242011-06-04 Chong Yidong <cyd@stupidchicken.com>
25
26 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
27 (x_clipboard_manager_save): Add return value.
28 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
29 error handlers.
30 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
31 Obey Vx_select_enable_clipboard_manager. Catch errors in
32 x_clipboard_manager_save (Bug#8779).
33 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 34 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 35
99a33b77 362011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
37
38 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
39
99a33b77 402011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
41
42 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
43 in the current matrix if keep_current_p is non-zero.
44
8264569d
EZ
452011-06-04 Eli Zaretskii <eliz@gnu.org>
46
47 * bidi.c (bidi_level_of_next_char): Fix last change.
48
57f97249
EZ
492011-06-03 Eli Zaretskii <eliz@gnu.org>
50
fec2107c 51 Support bidi reordering of text covered by display properties.
57f97249 52
fec2107c
EZ
53 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
54 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
55 (bidi_cache_search, bidi_cache_iterator_state)
56 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
57 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
58 character positions inside a run of characters covered by a
59 display string.
60 (bidi_paragraph_init, bidi_resolve_explicit_1)
61 (bidi_level_of_next_char): Call bidi_fetch_char and
62 bidi_fetch_char_advance instead of FETCH_CHAR and
63 FETCH_CHAR_ADVANCE.
64 (bidi_init_it): Initialize new members.
65 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
66 definitions.
67 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
68 instead of using explicit *_CHAR codes.
69 (bidi_resolve_explicit, bidi_resolve_weak): Use
70 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
71 bidirectional text is supported only in multibyte buffers.
72 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
73 it to initialize the frame_window_p member of struct bidi_it.
74 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
75 (bidi_resolve_explicit, bidi_resolve_weak)
76 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
77 bidi_it->nchars is non-positive.
78 (bidi_level_of_next_char): Don't try to lookup the cache for the
79 next/previous character if nothing is cached there yet, or if we
80 were just reseat()'ed to a new position.
c40e2fb2 81
0e14fe90
EZ
82 * xdisp.c (set_cursor_from_row): Set start and stop points
83 according to the row's direction when priming the loop that looks
84 for the glyph on which to display cursor.
85 (single_display_spec_intangible_p): Function deleted.
86 (display_prop_intangible_p): Reimplement to call
87 handle_display_spec instead of single_display_spec_intangible_p.
88 Accept 3 additional arguments needed by handle_display_spec. This
89 fixes incorrect cursor motion across display property with complex
90 values: lists, `(when COND...)' forms, etc.
91 (single_display_spec_string_p): Support property values that are
92 lists with the argument STRING its top-level element.
93 (display_prop_string_p): Fix the condition for processing a
94 property that is a list to be consistent with handle_display_spec.
fec2107c 95 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
96 last portion of handle_display_prop.
97 (compute_display_string_pos): Accept additional argument
98 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
99 value of a `display' property is a "replacing spec".
100 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
101 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
102 the display property, but just return a value indicating whether
103 the display property will replace the characters it covers.
104 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
105 frame_window_p members of struct bidi_it.
fec2107c
EZ
106 (compute_display_string_pos, compute_display_string_end): New
107 functions.
108 (push_it): Accept second argument POSITION, where pop_it should
109 jump to continue iteration.
110 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 111
fec2107c
EZ
112 * keyboard.c (adjust_point_for_property): Adjust the call to
113 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
114
115 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
116 (bidi_init_it): Update prototypes.
117 (display_prop_intangible_p): Update prototype.
118 (compute_display_string_pos, compute_display_string_end): Declare
119 prototypes.
120 (struct bidi_it): New members nchars and disp_pos. ch_len is now
121 EMACS_INT.
fc6f18ce 122
40087514 1232011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 124
57f53182
PE
125 Malloc failure behavior now depends on size of allocation.
126 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
127 * lisp.h: Change signatures accordingly.
128 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
129 All callers changed. (Bug#8762)
130
131 * gnutls.c: Use Emacs's memory allocators.
132 Without this change, the gnutls library would invoke malloc etc.
133 directly, which causes problems on non-SYNC_INPUT hosts, and which
134 runs afoul of improving memory_full behavior. (Bug#8761)
135 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
136 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
137 xfree instead of the default malloc, realloc, free.
138 (Fgnutls_boot): No need to check for memory allocation failure,
139 since xmalloc does that for us.
140
ac32cd99 141 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
142 * category.c (hash_get_category_set):
143 * ccl.c (ccl_driver):
144 * charset.c (Fdefine_charset_internal):
145 * charset.h (struct charset.hash_index):
146 * composite.c (get_composition_id, gstring_lookup_cache)
147 (composition_gstring_put_cache):
148 * composite.h (struct composition.hash_index):
149 * dispextern.h (struct image.hash):
150 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
151 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
152 (hashfn_equal, hashfn_user_defined, make_hash_table)
153 (maybe_resize_hash_table, hash_lookup, hash_put)
154 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
155 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
156 (Fsxhash, Fgethash, Fputhash, Fmaphash):
157 * image.c (make_image, search_image_cache, lookup_image)
158 (xpm_put_color_table_h):
159 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 160 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
161 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
162 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
163 * alloc.c (allocate_vectorlike):
164 Check for overflow in vector size calculations.
165 * ccl.c (ccl_driver):
166 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
167 * fns.c, image.c: Remove unnecessary static decls that would otherwise
168 need to be updated by these changes.
40087514
PE
169 * fns.c (make_hash_table, maybe_resize_hash_table):
170 Check for integer overflow with large hash tables.
0de4bb68
PE
171 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
172 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
173 (SXHASH_REDUCE): New macro.
174 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
175 Use it instead of discarding useful hash info with large hash values.
176 (sxhash_float): New function.
177 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
178 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
179 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
180 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
181 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
182 Adjust signatures to match updated version of code.
183 (consing_since_gc): Now EMACS_INT, since a single hash table can
184 use more than INT_MAX bytes.
185
698d32e2
DN
1862011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
187
188 Make it possible to build with GCC-4.6+ -O2 -flto.
189
190 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
191
fd6fa53f
SM
1922011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
193
194 * minibuf.c (get_minibuffer, read_minibuf_unwind):
195 Call minibuffer-inactive-mode.
196
864db017
JB
1972011-05-31 Juanma Barranquero <lekktu@gmail.com>
198
199 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
200 Update dependencies.
201
2ad0baf4
DN
2022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
203
204 * data.c (init_data): Remove code for UTS, this system is not
205 supported anymore.
206
4fcc2638
DN
2072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
208
209 Don't force ./temacs to start in terminal mode.
210
211 * frame.c (make_initial_frame): Initialize faces in all cases, not
212 only when CANNOT_DUMP is defined.
213 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
214
c56e0fd5
DN
2152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
216
217 * dispnew.c (add_window_display_history): Use const for the string
218 pointer. Remove declaration, not needed.
219
333d54da 2202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 221
55d4c1b2 222 Use 'inline', not 'INLINE'.
333d54da 223 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
224 * alloc.c, fontset.c (INLINE): Remove.
225 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
226 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
227 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
228 * gmalloc.c (register_heapinfo): Use inline unconditionally.
229 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
230
738db178
DN
2312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
232
233 Make it possible to run ./temacs.
234
235 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
236 syms_of_callproc does the same thing. Remove test for
237 "initialized", do it in the caller.
238 * emacs.c (main): Avoid calling set_initial_environment when dumping.
239
620c53a6
SM
2402011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
241
242 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
243 (read_minibuf): Use get_minibuffer.
244 (syms_of_minibuf): Use DEFSYM.
245 (Qmetadata): New var.
246 * data.c (Qbuffer): Don't make it static.
247 (syms_of_data): Use DEFSYM.
248
e003a292
PE
2492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
250
251 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
252 (CCL_CODE_MIN): New macro.
253
ed008a6d
PE
2542011-05-30 Paul Eggert <eggert@cs.ucla.edu>
255
3687c2ef
PE
256 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
257
ed008a6d
PE
258 * eval.c (Qdebug): Now static.
259 * lisp.h (Qdebug): Remove decl. This reverts a part of the
260 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
261 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
262
d66c4c7c
CY
2632011-05-29 Chong Yidong <cyd@stupidchicken.com>
264
265 * image.c: Various fixes to ImageMagick code comments.
266 (Fimagemagick_types): Doc fix.
267
5fbc2025
PE
2682011-05-29 Paul Eggert <eggert@cs.ucla.edu>
269
0196f88a
PE
270 Minor fixes prompted by GCC 4.6.0 warnings.
271
272 * xselect.c (converted_selections, conversion_fail_tag): Now static.
273
5fbc2025
PE
274 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
275 (x_clipboard_manager_save_all): Move extern decl to ...
276 * xterm.h: ... here, so that it can be checked for consistency.
277
1dd3c2d9
CY
2782011-05-29 Chong Yidong <cyd@stupidchicken.com>
279
280 * xselect.c (x_clipboard_manager_save_frame)
281 (x_clipboard_manager_save_all): New functions.
282 (Fx_clipboard_manager_save): Lisp function deleted.
283
284 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
285 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
286
287 * xterm.h: Update prototype.
288
5ba6571d
WX
2892011-05-28 William Xu <william.xwl@gmail.com>
290
291 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
292 exiting (Bug#8239).
293
3eaff834
JM
2942011-05-28 Jim Meyering <meyering@redhat.com>
295
e1900994 296 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
297 * fns.c (to_uchar): Define.
298 (crypto_hash_function): Use it to convert some newly-signed
299 variables to unsigned, to avoid sign-extension bugs. For example,
300 without this change, (md5 "truc") would evaluate to
301 45723a2aff78ff4fff7fff1114760e62 rather than the expected
302 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 303 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 304
0f6990a7
PE
3052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
306
307 Integer overflow fixes.
c8a9ca5a 308
08686060
PE
309 * dbusbind.c: Serial number integer overflow fixes.
310 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
311 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
312 to hold a serial number that is too large for a fixnum.
313 (Fdbus_method_return_internal, Fdbus_method_error_internal):
314 Check for serial numbers out of range. Decode any serial number
59568bf0 315 that was so large that it became a float. (Bug#8722)
08686060 316
2d1fc3c7
PE
317 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
318 (Fdbus_call_method, Fdbus_call_method_asynchronously):
319 Use XFASTINT rather than XUINT when numbers are nonnegative.
320 (xd_append_arg, Fdbus_method_return_internal):
321 (Fdbus_method_error_internal): Likewise. Also, for unsigned
322 arguments, check that Lisp number is nonnegative, rather than
59568bf0 323 silently wrapping negative numbers around. (Bug#8722)
30217ff0 324 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 325 (Bug#8722)
2d1fc3c7 326
c8a9ca5a
PE
327 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
328
519e1d69
PE
329 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
330
30569699
PE
331 ccl: add integer overflow checks
332 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
333 (IN_INT_RANGE): New macros.
334 (ccl_driver): Use them to check for integer overflow when
335 decoding a CCL program. Many of the new checks are whether XINT (x)
336 fits in int; it doesn't always, on 64-bit hosts. The new version
337 doesn't catch all possible integer overflows, but it's an
847044ea 338 improvement. (Bug#8719)
30569699 339
c11285dc
PE
340 * alloc.c (make_event_array): Use XINT, not XUINT.
341 There's no need for unsigned here.
342
fdccd48e
PE
343 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
344 This follows up to the 2011-05-06 change that substituted uintptr_t
345 for EMACS_INT. This case wasn't caught back then.
346
37910ab2
PE
347 Rework Fformat to avoid integer overflow issues.
348 * editfns.c: Include <float.h> unconditionally, as it's everywhere
349 now (part of C89). Include <verify.h>.
350 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
351 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
352 (Fformat): Avoid the prepass trying to compute sizes; it was only
353 approximate and thus did not catch overflow reliably. Instead, walk
354 through the format just once, formatting and computing sizes as we go,
355 checking for integer overflow at every step, and allocating a larger
356 buffer as needed. Keep track separately whether the format is
357 multibyte. Keep only the most-recently calculated precision, rather
358 than them all. Record whether each argument has been converted to
359 string. Use EMACS_INT, not int, for byte and char and arg counts.
360 Support field widths and precisions larger than INT_MAX. Avoid
361 sprintf's undefined behavior with conversion specifications such as %#d
362 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
363 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
364 formatting out-of-range floating point numbers with int
365 formats. (Bug#8668)
366
2e6578fb
PE
367 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
368
0ae6bdee
PE
369 * data.c: Avoid integer truncation in expressions involving floats.
370 * data.c: Include <intprops.h>.
371 (arith_driver): When there's an integer overflow in an expression
372 involving floating point, convert the integers to floating point
373 so that the resulting value does not suffer from catastrophic
374 integer truncation. For example, on a 64-bit host (* 4
375 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
376 Do not rely on undefined behavior after integer overflow.
377
de883a70
PE
378 merge count_size_as_multibyte, parse_str_to_multibyte
379 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 380 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
381 Check for integer overflow.
382 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
383 since it's now a duplicate of the other. This is more of
384 a character than a buffer op, so better that it's in character.c.
385 * fns.c, print.c: Adjust to above changes.
386
2ff916cb
PE
3872011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
388
389 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
390
f1b54466
PE
3912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
392
fb1ac845
PE
393 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
394 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
395 (x_clipboard_manager_save): Now static.
396 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
397
f1b54466
PE
398 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
399 (crypto_hash_function): Now static.
400 Fix pointer signedness problems. Avoid unnecessary initializations.
401
a9f737ee
CY
4022011-05-27 Chong Yidong <cyd@stupidchicken.com>
403
404 * termhooks.h (Vselection_alist): Make it terminal-local.
405
406 * terminal.c (create_terminal): Initialize it.
407
408 * xselect.c: Support for clipboard managers.
409 (Vselection_alist): Move to termhooks.h as terminal-local var.
410 (LOCAL_SELECTION): New macro.
411 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
412 (symbol_to_x_atom): Remove gratuitous arg.
413 (x_handle_selection_request, lisp_data_to_selection_data)
414 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
415 (x_own_selection, x_get_local_selection, x_convert_selection):
416 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
417 (some_frame_on_display): Delete unused function.
418 (Fx_own_selection_internal, Fx_get_selection_internal)
419 (Fx_disown_selection_internal, Fx_selection_owner_p)
420 (Fx_selection_exists_p): New optional frame arg.
421 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
422 (x_handle_selection_clear): Don't treat other terminals with the
423 same keyboard specially. Use the terminal-local Vselection_alist.
424 (x_clear_frame_selections): Use Frun_hook_with_args.
425
426 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
427
428 * xterm.h: Add support for those atoms.
429
e067f0c1
CY
4302011-05-26 Chong Yidong <cyd@stupidchicken.com>
431
432 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
433 (converted_selections, conversion_fail_tag): New global variables.
434 (x_selection_request_lisp_error): Free the above.
435 (x_get_local_selection): Remove unnecessary code.
436 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
437 of converted selections stored in converted_selections.
438 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
439 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
440 (x_convert_selection): New function.
441 (x_handle_selection_event): Simplify.
442 (x_get_foreign_selection): Don't ignore incoming requests while
443 waiting for an answer; this will fail when we implement
444 SAVE_TARGETS, and seems unnecessary anyway.
445 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
446 (Vx_sent_selection_functions): Doc fix.
447
0f4aebc0
LL
4482011-05-26 Leo Liu <sdl.web@gmail.com>
449
450 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
451
e61124cd
YM
4522011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
453
454 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
455
456 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
457 for fringe update if it has periodic bitmap.
458 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
459 and fringe_bitmap_periodic_p.
460
461 * fringe.c (get_fringe_bitmap_data): New function.
462 (draw_fringe_bitmap_1, update_window_fringes): Use it.
463 (update_window_fringes): Record periodicity of fringe bitmap in glyph
464 row. Mark glyph row for fringe update if periodicity changed.
465
466 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
467 for fringe update unless it has periodic bitmap.
468
f16d9837
KH
4692011-05-25 Kenichi Handa <handa@m17n.org>
470
471 * xdisp.c (get_next_display_element): Set correct it->face_id for
472 a static composition.
473
e1b90ef6
LL
4742011-05-24 Leo Liu <sdl.web@gmail.com>
475
476 * deps.mk (fns.o):
477 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
478
479 * fns.c (crypto_hash_function, Fsha1): New function.
480 (Fmd5): Use crypto_hash_function.
481 (syms_of_fns): Add Ssha1.
482
7400048f
PE
4832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
484
485 * gnutls.c: Remove unused macros.
486 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
487 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
488 Remove macros that are defined and never used.
489 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
490
abb71cf4
CY
4912011-05-22 Chong Yidong <cyd@stupidchicken.com>
492
493 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
494 (Fx_get_selection_internal): Minor cleanup.
495 (Fx_own_selection_internal): Rename arguments for consistency with
496 select.el.
497
6307db39
PE
4982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
499
500 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
501
f3d4e0a4
CY
5022011-05-22 Chong Yidong <cyd@stupidchicken.com>
503
504 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
505
4d8ade89
YM
5062011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
507
508 * dispnew.c (scrolling_window): Don't exclude the case that the
509 last enabled row in the desired matrix touches the bottom boundary.
510
32078c8d
GM
5112011-05-21 Glenn Morris <rgm@gnu.org>
512
513 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
514 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
515 and add some more files.
32078c8d 516
7285dc67
EZ
5172011-05-20 Eli Zaretskii <eliz@gnu.org>
518
519 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
520 report_file_error introduced by the change from 2011-05-07.
521
89d1bd22
PE
5222011-05-20 Paul Eggert <eggert@cs.ucla.edu>
523
524 * systime.h (Time): Define only if emacs is defined.
525 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
526 where the include path doesn't have X11/X.h by default. See
527 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
528
e23640bb 5292011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
530
531 * composite.c (find_automatic_composition): Fix previous change.
532
b9704ad9
GM
5332011-05-20 Glenn Morris <rgm@gnu.org>
534
535 * lisp.mk: New file, split from Makefile.in.
536 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
537 (shortlisp): Remove.
538 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
539
4a720484
GM
5402011-05-19 Glenn Morris <rgm@gnu.org>
541
542 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
543 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
544 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
545 (lisp): Set the order to that of loadup.el.
546 (shortlisp): Make it a copy of $lisp.
547 (SOME_MACHINE_LISP): Remove.
548 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
549 Use just $shortlisp, not $SOME_MACHINE_LISP too.
550
a28d4396
KH
5512011-05-18 Kenichi Handa <handa@m17n.org>
552
553 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
554 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
555 (find_automatic_composition): Mostly rewrite for efficiency.
556
a2b1fa8e
JB
5572011-05-18 Juanma Barranquero <lekktu@gmail.com>
558
559 * makefile.w32-in: Update dependencies.
560
8e1f5610
CS
5612011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
562
563 * menu.c: Include limits.h (fixes the MS-Windows build broken by
564 revision 104625).
565
7025ee00 5662011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 567
cdfa6eab
PE
568 Fix some integer overflow issues, such as string length overflow.
569
06d6db33
PE
570 * insdel.c (count_size_as_multibyte): Check for string overflow.
571
2b4560a8
PE
572 * character.c (lisp_string_width): Check for string overflow.
573 Use EMACS_INT, not int, for string indexes and lengths; in
574 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
575 the resulting string length overflows an EMACS_INT; instead,
576 report a string overflow if no precision given. When checking for
577 precision exhaustion, use a check that cannot possibly have
578 integer overflow. (Bug#8675)
579 * character.h (lisp_string_width): Adjust to new signature.
580
cb93f9be
PE
581 * alloc.c (string_overflow): New function.
582 (Fmake_string): Use it. This doesn't change behavior, but saves
583 a few bytes and will simplify future changes.
584 * character.c (string_escape_byte8): Likewise.
585 * lisp.h (string_overflow): New decl.
586
1a1f3366
PE
587 Fixups, following up to the user-interface timestamp change.
588 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
589 for UI timestamps, instead of unsigned long.
9fbd6841
PE
590 * msdos.c (mouse_get_pos): Likewise.
591 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
592 * w32gui.h (Time): Define by including "systime.h" rather than by
593 declaring it ourselves. (Bug#8664)
594
d4e3e4d3
PE
595 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
596 * image.c (clear_image_cache): Likewise.
597
f6a24d19
PE
598 * term.c (term_mouse_position): Don't assume time_t wraparound.
599
08dc5ae6
PE
600 Be more systematic about user-interface timestamps.
601 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
602 and sometimes 'EMACS_UINT', to represent these timestamps.
603 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
604 This makes the code easier to follow, and makes it easier to catch
605 integer overflow bugs such as Bug#8664.
606 * frame.c (Fmouse_position, Fmouse_pixel_position):
607 Use Time, not unsigned long, for user-interface timestamps.
608 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
609 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
610 * keyboard.h (last_event_timestamp): Likewise.
611 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
612 * menu.h (xmenu_show): Likewise.
613 * term.c (term_mouse_position): Likewise.
614 * termhooks.h (struct input_event.timestamp): Likewise.
615 (struct terminal.mouse_position_hook): Likewise.
616 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
617 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
618 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
619 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
620 what it was before.
621 * menu.h, termhooks.h: Include "systime.h", for Time.
622
8e55734a
PE
623 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
624 Don't assume that the difference between two unsigned long values
625 can fit into an integer. At this point, we know button_down_time
626 <= event->timestamp, so the difference must be nonnegative, so
627 there's no need to cast the result if double-click-time is
628 nonnegative, as it should be; check that it's nonnegative, just in
629 case. This bug is triggered when events are more than 2**31 ms
86db42d2 630 apart (about 25 days). (Bug#8664)
8e55734a 631
841f1b75 632 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 633 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 634
3e26f69c
PE
635 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
636 that always fit in int. Use a sentinel instead of a counter, to
637 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
638 * frame.h (struct frame): Use int for menu_bar_items_used
639 instead of EMACS_INT, since it always fits in int.
3e26f69c 640
5cc152c0
PE
641 * menu.c (grow_menu_items): Check for int overflow.
642
d89eb65e
PE
643 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
644
5235bd3e
PE
645 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
646 Before, the code was not consistent. These values cannot exceed
647 2**31 - 1 so there's no need to make them unsigned.
648 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
649 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
650 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
651 as modifiers.
652 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
653
bc827e23
PE
654 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
655 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
656 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
657 presumably because the widths might not match.
658
78eb494e
PE
659 * window.c (size_window): Avoid needless test at loop start.
660
04f2d78b
CB
6612011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
662
663 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
664
d2fc7e3d 6652011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
666
667 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
668
d2fc7e3d 6692011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
670
671 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
672 `width' to `bar_area_x' and `bar_area_width', respectively.
673 (x_scroll_run): Take account of fringe background extension.
674
04f2d78b
CB
675 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
676 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
677 `bar_area_width', respectively.
678 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
679 background extension.
680
79b70037
GM
6812011-05-10 Jim Meyering <meyering@redhat.com>
682
683 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
684
2f142cc5
JB
6852011-05-10 Juanma Barranquero <lekktu@gmail.com>
686
687 * image.c (Finit_image_library): Return t for built-in image types,
688 like pbm and xbm. (Bug#8640)
689
57679c86
AS
6902011-05-09 Andreas Schwab <schwab@linux-m68k.org>
691
692 * w32menu.c (set_frame_menubar): Fix submenu allocation.
693
888c9e86
EZ
6942011-05-07 Eli Zaretskii <eliz@gnu.org>
695
b0512a1d
EZ
696 * w32console.c (Fset_screen_color): Doc fix.
697 (Fget_screen_color): New function.
698 (syms_of_ntterm): Defsubr it.
699
7285dc67
EZ
700 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
701 unlink the temporary file if Fcall_process didn't create it in the
702 first place.
703 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
704 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
705 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
706 cue to call_process_cleanup not to close that handle.
707
4d3fcc8e
BK
7082011-05-07 Ben Key <bkey76@gmail.com>
709
710 * makefile.w32-in: The bootstrap-temacs rule now makes use of
711 one of two shell specific rules, either bootstrap-temacs-CMD or
712 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
713 to the previous implementation of the bootstrap-temacs rule.
714 The bootstrap-temacs-CMD rule is similar to the previous
715 implementation of the bootstrap-temacs rule except that it
716 makes use of the ESC_CFLAGS variable instead of the CFLAGS
717 variable.
718
719 These changes, along with some changes to nt/configure.bat,
720 nt/gmake.defs, and nt/nmake.defs, are required to extend my
721 earlier fix to add support for --cflags and --ldflags options
722 that include quotes so that it works whether make uses cmd or
723 sh as the shell.
724
b4289b64
MA
7252011-05-06 Michael Albinus <michael.albinus@gmx.de>
726
727 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
728 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
729 is a constant.
730 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
731 a string. Handle both cases.
732 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
733 (Fdbus_register_method): Use Qinvalid_function.
734
af4c0e28
JB
7352011-05-06 Juanma Barranquero <lekktu@gmail.com>
736
737 * makefile.w32-in: Update dependencies.
738 (LISP_H): Add inttypes.h and stdin.h.
739 (PROCESS_H): Add unistd.h.
740
c51453d9
EZ
7412011-05-06 Eli Zaretskii <eliz@gnu.org>
742
743 * lread.c: Include limits.h (fixes the MS-Windows build broken by
744 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
745
8ff0ac3c 7462011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 747
4c4b566b
PE
748 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
749
aab2b9b5
PE
750 * term.c (vfatal): Remove stray call to va_end.
751 It's not needed and the C Standard doesn't allow it here anyway.
752
c378da0b
PE
753 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
754 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
755
288b08c7
PE
756 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
757 bytes.
758
e3601888
PE
759 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
760
db6c0e74
PE
761 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
762
dd5963ea
PE
763 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
764
88c9450f
PE
765 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
766
2f9442b8
PE
767 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
768
c032b5f8
PE
769 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
770 * charset.c (Fdefine_charset_internal): Don't initialize
771 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 772 32-bit int (Bug#8600).
a108c10b
PE
773
774 * lread.c (read_integer): Be more consistent with string-to-number.
775 Use string_to_number to do the actual conversion; this avoids
776 rounding errors and fixes some other screwups. Without this fix,
777 for example, #x1fffffffffffffff was misread as -2305843009213693952.
778 (digit_to_number): Move earlier, for benefit of read_integer.
779 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 780 not a digit in any supported base. (Bug#8602)
a108c10b 781
ad5f9eea
PE
782 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
783
aec1708a
PE
784 * dispnew.c (scrolling_window): Return 1 if we scrolled,
785 to match comment at start of function. This also removes a
786 GCC warning about overflow in a 32+64-bit port.
787
47be4ab5
PE
788 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
789
371cac43
PE
790 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
791 Reported by Stefan Monnier in
792 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
793 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
794 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 795
d01a7826
PE
796 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
797 (EMACS_UINTPTR): Likewise, with uintptr_t.
798
7fd47d5c
PE
799 * lisp.h: Prefer 64-bit EMACS_INT if available.
800 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
801 on 32-bit hosts that have 64-bit int, so that they can access
802 large files.
122b0c86
PE
803 However, temporarily disable this change unless the temporary
804 symbol WIDE_EMACS_INT is defined.
7fd47d5c 805
8727937b
PE
806 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
807
8ac068ac
PE
808 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
809 This removes an assumption that EMACS_INT and long are the same
810 width as pointers. The assumption is true for Emacs porting targets
811 now, but we want to make other targets possible.
812 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
813 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
814 In the rest of the code, change types of integers that hold casted
815 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
816 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
817 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
818 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
819 No need to cast type when ORing.
820 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
821 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
822 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
823 assume EMACS_INT is the same width as char *.
824 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
825 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
826 Remove no-longer-needed casts.
827 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
828 (xg_tool_bar_help_callback, xg_make_tool_item):
829 Use EMACS_INTPTR to hold an integer
830 that will be cast to void *; this can avoid a GCC warning
831 if EMACS_INT is not the same width as void *.
832 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
833 * xdisp.c (display_echo_area_1, resize_mini_window_1):
834 (current_message_1, set_message_1):
835 Use a local to convert to proper width without a cast.
836 * xmenu.c (dialog_selection_callback): Likewise.
837
ede49d71
PE
838 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
839 Also, don't assume VALBITS / RAND_BITS is less than 5,
840 and don't rely on undefined behavior when shifting a 1 left into
841 the sign bit.
842 * lisp.h (get_random): Change signature to match.
843
2f30ecd0
PE
844 * lread.c (hash_string): Use size_t, not int, for hash computation.
845 Normally we prefer signed values; but hashing is special, because
846 it's better to use unsigned division on hash table sizes so that
847 the remainder is nonnegative. Also, size_t is the natural width
848 for hashing into memory. The previous code used 'int', which doesn't
849 retain enough info to hash well into very large tables.
850 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
851
2a866e7b
PE
852 * dbusbind.c: Don't possibly lose pointer info when converting.
853 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
854 Use XPNTR rather than XHASH, so that the high-order bits of
855 the pointer aren't lost when converting through void *.
856
51639eac
PE
857 * eval.c (Fautoload): Don't double-shift a pointer.
858
92394119
PE
859 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
860
dbdb9a7c
JB
8612011-05-06 Juanma Barranquero <lekktu@gmail.com>
862
863 * gnutls.c (DEF_GNUTLS_FN):
864 * image.c (DEF_IMGLIB_FN): Make function pointers static.
865
db7a0b4f
AS
8662011-05-05 Andreas Schwab <schwab@linux-m68k.org>
867
868 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
869 marker. (Bug#8610)
870
f7ff1b0f 8712011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
872
873 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
874 New version that can reserve upto 2GB of heap space.
875
f7ff1b0f 8762011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
877
878 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
879
639c109b
TZ
8802011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
881
882 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
883 `gnutls_certificate_set_x509_key_file'.
884
d2127135
JB
8852011-05-05 Juanma Barranquero <lekktu@gmail.com>
886
887 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
888 Update dependencies.
889
e968f4f3
JB
8902011-05-04 Juanma Barranquero <lekktu@gmail.com>
891
892 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
893 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
894 Remove unused parameter `fildes'.
895 * process.c (read_process_output, send_process): Don't pass it.
896
84d358f0
JB
8972011-05-04 Juanma Barranquero <lekktu@gmail.com>
898
899 Fix previous change: the library cache is defined in w32.c.
900 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
901 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
902
0898ca10
JB
9032011-05-04 Juanma Barranquero <lekktu@gmail.com>
904
905 Implement dynamic loading of GnuTLS on Windows.
906
907 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
908 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
909 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
910 Declare.
911
912 * gnutls.c (Qgnutls_dll): Define.
913 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
914 (gnutls_*): Declare function pointers.
915 (init_gnutls_functions): New function to initialize function pointers.
916 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
917 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
918 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
919 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
920 (emacs_gnutls_write, emacs_gnutls_read)
921 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
922 (Fgnutls_available_p): New function.
923 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
924 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
925 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
926
927 * image.c: Include w32.h.
928 (Vimage_type_cache): Delete.
929 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
930 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
931 (w32_delayed_load): Move to w32.c.
932
933 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
934
935 * w32.c (QCloaded_from, Vlibrary_cache): Define.
936 (w32_delayed_load): Move from image.c. When loading a library, record
937 its filename in the :loaded-from property of the library id.
938 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
939 Initialize and staticpro them.
940 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
941
942 * process.c: Include lisp.h before w32.h, not after.
943 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
944 instead of gnutls_record_check_pending.
945
946 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
947
ff4de4aa
TZ
9482011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
949
950 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
951 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
952 as passed in.
953
abe95abb
JD
9542011-05-03 Jan Djärv <jan.h.d@swipnet.se>
955
956 * xterm.c (x_set_frame_alpha): Do not set property on anything
957 else than FRAME_X_OUTER_WINDOW (Bug#8608).
958
e16e55d4
JB
9592011-05-02 Juanma Barranquero <lekktu@gmail.com>
960
961 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
962
bafcf6a5
JB
9632011-05-02 Juanma Barranquero <lekktu@gmail.com>
964
965 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
966 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
967 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
968 (gnutls_global_initialized, Qgnutls_bootprop_priority)
969 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
970 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
971 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
972 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
973 (Qgnutls_bootprop_callbacks_verify): Make static.
974
e7a6747f
AS
9752011-05-01 Andreas Schwab <schwab@linux-m68k.org>
976
19ed11ba
AS
977 * callproc.c: Indentation fixup.
978
e7a6747f 979 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
980 (wait_for_termination, interruptible_wait_for_termination):
981 Move after wait_for_termination_1.
e7a6747f 982
1ef14cb4
LMI
9832011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
984
985 * sysdep.c (interruptible_wait_for_termination): New function
986 which is like wait_for_termination, but allows keyboard
987 interruptions.
988
989 * callproc.c (Fcall_process): Add (:file "file") as an option for
990 the STDOUT buffer.
991 (Fcall_process_region): Ditto.
992
330d880c
EZ
9932011-04-30 Eli Zaretskii <eliz@gnu.org>
994
8db90b73
EZ
995 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
996 rather than `XVECTOR (FOO)->size'.
997
330d880c
EZ
998 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
999 inttypes.h, as a gnulib replacement is used if it not available in
1000 system headers.
1001
15cbd324
EZ
10022011-04-21 Eli Zaretskii <eliz@gnu.org>
1003
1004 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1005 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1006 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1007
1008 * coding.c (coding_alloc_by_realloc): Error out if destination
1009 will grow beyond MOST_POSITIVE_FIXNUM.
1010 (decode_coding_emacs_mule): Abort if there isn't enough place in
1011 charbuf for the composition carryover bytes. Reserve an extra
1012 space for up to 2 characters produced in a loop.
1013 (decode_coding_iso_2022): Abort if there isn't enough place in
1014 charbuf for the composition carryover bytes.
1015
10162011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1017
ae940cca
EZ
1018 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1019 aborting when %lld or %lll format is passed.
1020 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1021 %llo or %llx format is passed. (Bug#8545)
1022
03ab8921
EZ
1023 * window.c (window_scroll_line_based): Use a marker instead of
1024 simple variables to record original value of point. (Bug#7952)
1025
afda1437
EZ
1026 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1027 produced by %s or %c overflows available buffer space. (Bug#8545)
1028
f76dee0c
PE
10292011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1030
1031 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1032 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1033
fdc5744d
JB
10342011-04-28 Juanma Barranquero <lekktu@gmail.com>
1035
1036 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1037
638f053a
JB
10382011-04-28 Juanma Barranquero <lekktu@gmail.com>
1039
1040 * keyboard.c (Qdelayed_warnings_hook): Define.
1041 (command_loop_1): Run `delayed-warnings-hook'
1042 if Vdelayed_warnings_list is non-nil.
1043 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1044 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1045
d178f871
EZ
10462011-04-28 Eli Zaretskii <eliz@gnu.org>
1047
1048 * doprnt.c (doprnt): Don't return value smaller than the buffer
1049 size if the message was truncated. (Bug#8545).
1050
b124fd93
JB
10512011-04-28 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1054 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1055
e810457d
PE
10562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1059
ea51cceb
JB
10602011-04-27 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * makefile.w32-in: Update dependencies.
1063
94dcfacf
EZ
10642011-04-27 Eli Zaretskii <eliz@gnu.org>
1065
1066 Improve `doprnt' and its usage. (Bug#8545)
1067 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1068 `format_end'. Remove support for %l as a conversion specifier.
1069 Don't use xrealloc. Improve diagnostics when the %l size modifier
1070 is used. Update the commentary.
1071
1072 * eval.c (verror): Simplify calculation of size_t.
1073
1074 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1075 messages.
1076
f61f41d7
PE
10772011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1078
1079 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1080 change.
1081
96fb4434
PE
10822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1085 This makes this file independent of the recent pseudovector change.
1086
671875da 10872011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1088
69e9b5a3
PE
1089 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1090
b5f869a7 1091 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1092 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1093 Remove unused local.
c8926152 1094 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1095
841a1577 1096 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1097 GCC 4.6.0 optimizes based on type-based alias analysis.
1098 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1099 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1100 != &v->size, and therefore "v->size = 1; b->size = 2; return
1101 v->size;" must therefore return 1. This assumption is incorrect
1102 for Emacs, since it type-puns struct Lisp_Vector * with many other
1103 types. To fix this problem, this patch adds a new type struct
f904488f 1104 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1105 and pseudovectors, and helps optimizing compilers not get fooled
1106 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1107 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1108 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1109 the size member.
eab3844f
PE
1110 (XSETPVECTYPE): Rewrite in terms of new macro.
1111 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1112 This is a bit clearer, and further avoids the possibility of
1113 undesirable aliasing.
1114 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1115 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1116 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1117 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1118 (ASIZE): Now uses header.size rather than size.
1119 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1120 to avoid the hassle of writing XVECTOR (foo)->header.size.
1121 (struct vectorlike_header): New type.
eab3844f
PE
1122 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1123 object, to help avoid aliasing.
1124 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1125 (SUBRP): Likewise, since Lisp_Subr is a special case.
1126 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1127 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1128 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1129 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1130 changed to be "header.size" and "header.next".
1131 * buffer.h (struct buffer): Likewise.
1132 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1133 * frame.h (struct frame): Likewise.
1134 * process.h (struct Lisp_Process): Likewise.
1135 * termhooks.h (struct terminal): Likewise.
1136 * window.c (struct save_window_data, struct saved_window): Likewise.
1137 * window.h (struct window): Likewise.
1138 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1139 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1140 * buffer.c (init_buffer_once): Likewise.
1141 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1142 special case.
1143 * process.c (Fformat_network_address): Use local var for size,
1144 for brevity.
1145
0df1eac5
PE
1146 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1147
847ab9d1 1148 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1149 * data.c (atof): Remove decl; no longer used or needed.
1150 (digit_to_number): Move to lread.c.
1151 (Fstring_to_number): Use new string_to_number function, to be
1152 consistent with how the Lisp reader treats infinities and NaNs.
1153 Do not assume that floating-point numbers represent EMACS_INT
1154 without losing information; this is not true on most 64-bit hosts.
1155 Avoid double-rounding errors, by insisting on integers when
1156 parsing non-base-10 numbers, as the documentation specifies.
1157 * lisp.h (string_to_number): New decl, replacing ...
1158 (isfloat_string): Remove.
bc0a5c13 1159 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1160 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1161 appears to have been a coding error. Similarly, do not accept
1162 strings like +-1e0 as floating point numbers. Do not report
1163 overflow for integer overflows unless the base is not 10 which
1164 means we have no simple and reliable way to continue.
1165 Break out the floating-point parsing into a new
1166 function string_to_number, so that Fstring_to_number parses
1167 floating point numbers consistently with the Lisp reader.
04f2d78b 1168 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1169 (E_CHAR, EXP_INT): Remove, replacing with ...
1170 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1171 (string_to_number): New function, replacing isfloat_string.
1172 This function checks for valid syntax and produces the resulting
1173 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1174 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1175 so that overflow for non-base-10 numbers is reported only when
1176 there's no portable and simple way to convert to floating point.
452f4150 1177
67769ffc
PE
1178 * textprop.c (set_text_properties_1): Rewrite for clarity,
1179 and to avoid GCC warning about integer overflow.
1180
c20db43f
PE
1181 * intervals.h (struct interval): Use EMACS_INT for members
1182 where EMACS_UINT might cause problems. See
1183 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1184 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1185 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1186 All uses changed.
37aa2f85
PE
1187 (offset_intervals): Tell GCC not to worry about length overflow
1188 when negating a negative length.
c20db43f 1189
2538aa2f
PE
1190 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1191 (overrun_check_free): Likewise.
1192
f2d3008d
PE
1193 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1194 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1195 word size.
1196
ec8df744
PE
1197 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1198 (gnutls_make_error): Rename local to avoid shadowing.
1199 (gnutls_emacs_global_deinit): ifdef out; not used.
1200 (Fgnutls_boot): Use const for pointer to readonly storage.
1201 Comment out unused local. Fix pointer signedness problems.
1202
640ee02d
PE
1203 * lread.c (openp): Don't stuff size_t into an 'int'.
1204 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1205 about possible signed overflow.
1206
6048fb2a
PE
1207 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1208 (GDK_KEY_g): Don't define if already defined.
1209 (xg_prepare_tooltip): Avoid pointer signedness problem.
1210 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1211
fa3c87e1
PE
1212 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1213 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1214
2172544b
PE
1215 * xfns.c (Fx_window_property): Simplify a bit,
1216 to make a bit faster and to avoid GCC 4.6.0 warning.
1217 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1218
9b821a21
PE
1219 * fns.c (internal_equal): Don't assume size_t fits in int.
1220
3c616cfa
PE
1221 * alloc.c (compact_small_strings): Tighten assertion a little.
1222
c2982e87
PE
1223 Replace pEd with more-general pI, and fix some printf arg casts.
1224 * lisp.h (pI): New macro, generalizing old pEd macro to other
1225 conversion specifiers. For example, use "...%"pI"d..." rather
1226 than "...%"pEd"...".
1227 (pEd): Remove. All uses replaced with similar uses of pI.
1228 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1229 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1230 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1231 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1232 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1233 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1234 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1235 64-bit hosts.
1236 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1237 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1238 * print.c (safe_debug_print, print_object): Likewise.
1239 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1240 to int.
6f04d126
PE
1241 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1242 avoiding the 0 flag, which is not portable.
c2982e87
PE
1243 * process.c (Fmake_network_process): Use pI to avoid cast.
1244 * region-cache.c (pp_cache): Likewise.
1245 * xdisp.c (decode_mode_spec): Likewise.
1246 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1247 behavior on 64-bit hosts with printf arg.
6f04d126 1248 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1249 (x_stop_queuing_selection_requests): Likewise.
1250 (x_get_window_property): Don't truncate byte count to an 'int'
1251 when tracing.
0b432f21 1252
5e073ec7
PE
1253 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1254 here, since it parses constructs like leading '-' and spaces,
1255 which are not wanted; and it overflows with large numbers.
1256 Instead, simply match F[0-9]+, which is what is wanted anyway.
1257
36372bf9
PE
1258 * alloc.c: Remove unportable assumptions about struct layout.
1259 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1260 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1261 (allocate_vectorlike, make_pure_vector): Use the new macros,
1262 plus offsetof, to remove unportable assumptions about struct layout.
1263 These assumptions hold on all porting targets that I know of, but
1264 they are not guaranteed, they're easy to remove, and removing them
1265 makes further changes easier.
1266
0b432f21
PE
1267 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1268 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1269 (string_overrun_cookie): Now const. Use initializers that
1270 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1271 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1272 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1273 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1274 multiple of sizeof (EMACS_INT); it need not be, if
1275 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1276 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1277
895009e1
JB
12782011-04-26 Juanma Barranquero <lekktu@gmail.com>
1279
1280 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1281
6a7a1b0b
TZ
12822011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1283
1284 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1285 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1286 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1287
841a1577 12882011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1289
1290 * lisp.h (Qdebug): List symbol.
895009e1 1291 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1292 * keyboard.c (debug-on-event): New variable.
1293 (handle_user_signal): Break into debugger when debug-on-event
1294 matches the current signal symbol.
1295
f2d3ba6f
DN
12962011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1297
1298 * alloc.c (check_sblock, check_string_bytes)
1299 (check_string_free_list): Convert to standard C.
1300
42ce4c63
TZ
13012011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1302
1303 * w32.c (emacs_gnutls_push): Fix typo.
1304
825cd63c
EZ
13052011-04-25 Eli Zaretskii <eliz@gnu.org>
1306
fb11d64d
EZ
1307 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1308 "cast to pointer from integer of different size".
1309
825cd63c
EZ
1310 Improve doprnt and its use in verror. (Bug#8545)
1311 * doprnt.c (doprnt): Document the set of format control sequences
1312 supported by the function. Use SAFE_ALLOCA instead of always
1313 using `alloca'.
1314
1315 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1316 is one byte too soon. Don't use xrealloc; instead xfree and
1317 xmalloc anew.
1318
e061a11b
TZ
13192011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1320
1321 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1322 callbacks stage.
1323
1324 * gnutls.c: Renamed global_initialized to
1325 gnutls_global_initialized. Added internals for the
1326 :verify-hostname-error, :verify-error, and :verify-flags
1327 parameters of `gnutls-boot' and documented those parameters in the
1328 docstring. Start callback support.
1329 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1330 unless a fatal error occured. Call gnutls_alert_send_appropriate
1331 on error. Return error code.
1332 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1333 (emacs_gnutls_read): Likewise.
1334 (Fgnutls_boot): Return handshake error code.
1335 (emacs_gnutls_handle_error): New function.
1336 (wsaerror_to_errno): Likewise.
1337
1338 * w32.h (emacs_gnutls_pull): Add prototype.
1339 (emacs_gnutls_push): Likewise.
1340
1341 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1342 (emacs_gnutls_push): Likewise.
1343
13442011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1345
1346 * process.c (wait_reading_process_output): Check if GnuTLS
1347 buffered some data internally if no FDs are set for TLS
1348 connections.
1349
1350 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1351 (LIBS): Link to USER_LIBS.
1352 ($(BLD)/gnutls.$(0)): New target.
1353
fa6996bc
EZ
13542011-04-24 Eli Zaretskii <eliz@gnu.org>
1355
eb35682e
EZ
1356 * xdisp.c (handle_single_display_spec): Rename the
1357 display_replaced_before_p argument into display_replaced_p, to
1358 make it consistent with the commentary. Fix typos in the
1359 commentary.
1360
e2ad650c
EZ
1361 * textprop.c (syms_of_textprop): Remove dead code.
1362 (copy_text_properties): Delete obsolete commentary about an
1363 interface that was deleted long ago. Fix typos in the description
1364 of arguments.
1365
1b2de274
EZ
1366 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1367 to changes in oldXMenu/XMenu.h from 2011-04-16.
1368 <menu_help_message, prev_menu_help_message>: Constify.
1369 (IT_menu_make_room): menu->help_text is now `const char **';
1370 adjust.
1371
1372 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1373 to changes in oldXMenu/XMenu.h from 2011-04-16.
1374 (struct XMenu): Declare `help_text' `const char **'.
1375
1376 * xfaces.c <Qunspecified>: Make extern again.
1377
1378 * syntax.c: Include sys/types.h before including regex.h, as
1379 required by Posix.
1380
762b15be
EZ
1381 * doc.c (get_doc_string): Improve the format passed to `error'.
1382
1383 * doprnt.c (doprnt): Improve commentary.
1384
1385 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1386
1387 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1388 them with etags.
1389
f1052e5d
EZ
1390 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1391 changes in globals.h immediately force recompilation.
762b15be
EZ
1392 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1393 $(CURDIR)/s/ms-w32.h.
1394 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1395
fa6996bc
EZ
1396 * character.c (Fchar_direction): Function deleted.
1397 (syms_of_character): Don't defsubr it.
1398 <char-direction-table>: Deleted.
1399
e6c3da20
EZ
14002011-04-23 Eli Zaretskii <eliz@gnu.org>
1401
1402 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1403 * doprnt.c: Include limits.h.
1404 (SIZE_MAX): New macro.
04f2d78b
CB
1405 (doprnt): Return a size_t value. 2nd arg is now size_t.
1406 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1407 Improve overflow protection. Support `l' modifier for integer
1408 conversions. Support %l conversion. Don't assume an EMACS_INT
1409 argument for integer conversions and for %c.
1410
1411 * lisp.h (doprnt): Restore prototype.
1412
1413 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1414 $(SRC)/character.h.
1415
1416 * Makefile.in (base_obj): Add back doprnt.o.
1417
1418 * deps.mk (doprnt.o): Add back prerequisites.
1419 (callint.o): Depend on character.h.
1420
1421 * eval.c (internal_lisp_condition_case): Include the handler
1422 representation in the error message.
1423 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1424 when breaking from the loop.
1425
1426 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1427
1428 * callint.c (Fcall_interactively): When displaying error message
1429 about invalid control letter, pass the character's codepoint, not
1430 a pointer to its multibyte form. Improve display of the character
1431 in octal and display also its hex code.
1432
1433 * character.c (char_string): Use %x to display the (unsigned)
1434 codepoint of an invalid character, to avoid displaying a bogus
1435 negative value.
1436
1437 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1438 `error', not SYMBOL_NAME itself.
1439
1440 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1441 character arguments to `error'.
1442
1443 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1444 to `error' in error message about FINAL_CHAR argument. Make sure
1445 FINAL_CHAR is a character, and use %c when it is passed as
1446 argument to `error'.
1447
4ffd0d6b 14482011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1449
1450 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1451
1452 * w32.c: Include <time.h>.
1453 (sys_localtime): New function.
1454
4ffd0d6b 14552011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1456
1457 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1458
4ffd0d6b 1459 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1460
4ffd0d6b 14612011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1462
4ffd0d6b
GM
1463 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1464 zombies (Bug#8467).
aac0c6e3 1465
04c56954
EZ
14662011-04-19 Eli Zaretskii <eliz@gnu.org>
1467
1468 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1469 gl_state.e_property when gl_state.object is Qt.
1470
1471 * insdel.c (make_gap_larger): Remove limitation of buffer size
1472 to <= INT_MAX.
1473
16a43933
CY
14742011-04-18 Chong Yidong <cyd@stupidchicken.com>
1475
1476 * xdisp.c (lookup_glyphless_char_display)
1477 (produce_glyphless_glyph): Handle cons cell entry in
1478 glyphless-char-display.
1479 (Vglyphless_char_display): Document it.
1480
1481 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1482 glyphless-char-display.
1483
4581706e
CY
14842011-04-17 Chong Yidong <cyd@stupidchicken.com>
1485
1486 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1487
1488 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1489
1490 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1491 definition for no-X builds.
1492
4887c6e2 14932011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1494
fd35b6f9
PE
1495 Static checks with GCC 4.6.0 and non-default toolkits.
1496
5c1ccb01
PE
1497 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1498
006c5daa
PE
1499 * process.c (keyboard_bit_set): Define only if SIGIO.
1500 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1501 (send_process): Repair possible setjmp clobbering.
1502
efc736d3
PE
1503 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1504
4e2fe2e6
PE
1505 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1506
f97334a2
PE
1507 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1508
4e75f29d
PE
1509 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1510 Define only if needed.
1511
90efadd1
PE
1512 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1513 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1514 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1515
3c647824
PE
1516 * dispextern.h (struct redisplay_interface): Rename param
1517 to avoid shadowing.
e264f262 1518 * termhooks.h (struct terminal): Likewise.
761383f4 1519 * xterm.c (xembed_send_message): Likewise.
3c647824 1520
b58c5c4a
PE
1521 * insdel.c (make_gap_smaller): Define only if
1522 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1523
cad59032
PE
1524 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1525 it.
1526
c339dc2e
PE
1527 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1528 so that we aren't warned about unused symbols.
1529
91a3e27b
PE
1530 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1531
399c71d3 1532 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1533
8ffc96f5
PE
1534 * xfns.c (x_real_positions): Mark locals as initialized.
1535
eef9bc79
PE
1536 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1537
098db9dd
PE
1538 * xterm.c: Fix problems found by static analysis with other toolkits.
1539 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1540 (x_dispatch_event): Declare static if USE_GTK, and
1541 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1542 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1543 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1544 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1545 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1546
eb18f6cc
PE
1547 * xmenu.c (menu_help_callback): Pointer type fixes.
1548 Use const pointers when pointing at readonly data. Avoid pointer
1549 signedness clashes.
1550 (FALSE): Remove unused macro.
1551 (update_frame_menubar): Remove unused decl.
1552
1fe72bf8
PE
1553 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1554
60d9e1db
PE
1555 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1556 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1557 (single_menu_item): Rename local to avoid shadowing.
1558
39261c26
PE
1559 * keyboard.c (make_lispy_event): Remove unused local var.
1560
018c5e19
PE
1561 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1562 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1563
63d2b86e
PE
1564 * bitmaps: Change bitmaps from unsigned char back to the X11
1565 compatible char. Avoid the old compiler warnings about
1566 out-of-range initializers by using, for example, '\xab' rather
1567 than 0xab.
1568
aefd87e1
PE
1569 * xgselect.c (xgselect_initialize): Check vs interface
1570 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1571
bf501fb9
PE
1572 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1573
e9829fdf
PE
1574 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1575 to read-only memory.
1576
1086c095
PE
1577 * fns.c (vector): Remove; this old hack is no longer needed.
1578
2baccd04 1579 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1580 Remove unused var.
dde42981 1581 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1582
72391843 1583 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1584
436c16df 1585 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1586 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1587 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1588
92bb796d 1589 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1590 (x_term_init): Remove local to avoid shadowing.
92bb796d 1591
764430a3 1592 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1593
1594 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1595 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1596
d1dfb56c
EZ
15972011-04-16 Eli Zaretskii <eliz@gnu.org>
1598
c4354cb4
EZ
1599 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1600
d1dfb56c
EZ
1601 Fix regex.c, syntax.c and friends for buffers > 2GB.
1602 * syntax.h (struct gl_state_s): Declare character position members
1603 EMACS_INT.
1604
1605 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1606
04f2d78b
CB
1607 * textprop.c (verify_interval_modification, interval_of):
1608 Declare arguments EMACS_INT.
d1dfb56c
EZ
1609
1610 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1611 EMACS_INT.
1612
1613 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1614
1615 * indent.c (Fvertical_motion): Local variable it_start is now
1616 EMACS_INT.
1617
1618 * regex.c (re_match, re_match_2, re_match_2_internal)
1619 (bcmp_translate, regcomp, regexec, print_double_string)
1620 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1621 (re_compile_pattern, re_exec): Declare arguments and local
1622 variables `size_t' and `ssize_t' and return values `regoff_t', as
1623 appropriate.
1624 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1625 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1626 <compile_stack_type>: `size' and `avail' are now `size_t'.
1627
1628 * regex.h <regoff_t>: Use ssize_t, not int.
1629 (re_search, re_search_2, re_match, re_match_2): Arguments that
1630 specify buffer/string position and length are now ssize_t and
1631 size_t. Return type is regoff_t.
1632
613052cd
BK
16332011-04-16 Ben Key <bkey76@gmail.com>
1634
1635 * nsfont.m: Fixed bugs in ns_get_family and
1636 ns_descriptor_to_entity that were caused by using free to
1637 deallocate memory blocks that were allocated by xmalloc (via
1638 xstrdup). This caused Emacs to crash when compiled with
1639 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1640 --enable-checking=xmallocoverrun). xfree is now used to
1641 deallocate these memory blocks.
1642
4170f62f 16432011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1644
71b41406
PE
1645 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1646
9587a89d
PE
1647 emacs_write: Accept and return EMACS_INT for sizes.
1648 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1649 et seq.
1650 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1651 Accept and return EMACS_INT.
1652 (emacs_gnutls_write): Return the number of bytes written on
1653 partial writes.
1654 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1655 (emacs_read, emacs_write): Remove check for negative size, as the
1656 Emacs source code has been audited now.
9587a89d
PE
1657 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1658 (emacs_read, emacs_write): Use it.
273a5f82
PE
1659 * process.c (send_process): Adjust to the new signatures of
1660 emacs_write and emacs_gnutls_write. Do not attempt to store
1661 a byte offset into an 'int'; it might overflow.
9587a89d 1662 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1663
3e047f51
PE
1664 * sound.c: Don't assume sizes fit in 'int'.
1665 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1666 Return EMACS_INT, not int.
3e047f51 1667 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1668 Accept EMACS_INT, not int.
1669 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1670 record read return values.
1671
cc39a9db
BK
16722011-04-15 Ben Key <bkey76@gmail.com>
1673
c9d0ec6d
JB
1674 * keyboard.c (Qundefined): Don't declare static since it is used
1675 in nsfns.m.
1676 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1677 static since they are used in nsfont.m.
cc39a9db 1678
6c60eb9f
SM
16792011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1680
1681 * process.c (Qprocessp): Don't declare static.
1682 * lisp.h (Qprocessp): Declare again.
1683
7990b61a
JB
16842011-04-15 Juanma Barranquero <lekktu@gmail.com>
1685
1686 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1687
5d4cb038
PE
16882011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1689
8bd7b830 1690 Improve C-level modularity by making more things 'static'.
cd64ea1d 1691
e3b27b31
PE
1692 Don't publish debugger-only interfaces to other modules.
1693 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1694 (verify_bytepos, count_markers): Move decls to the only modules
1695 that need them.
1696 * region-cache.h (pp_cache): Likewise.
1697 * window.h (check_all_windows): Likewise.
1698 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1699
5d4cb038
PE
1700 * sysdep.c (croak): Now static, if
1701 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1702 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1703
1704 * alloc.c (refill_memory_reserve): Now static if
1705 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1706 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1707
e87b6180
PE
1708 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1709 Define only if USE_LUCID.
1710
ac64929e
PE
1711 * xrdb.c (x_customization_string, x_rm_string): Now static.
1712
6f37259d
PE
1713 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1714 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1715
1683e3ab
PE
1716 * xdisp.c (draw_row_with_mouse_face): Now static.
1717 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1718
de9c2632
PE
1719 * window.h (check_all_windows): Mark externally visible.
1720
2b96acb7
PE
1721 * window.c (window_deletion_count): Now static.
1722
1723 * undo.c: Make symbols static if they're not exported.
1724 (last_undo_buffer, last_boundary_position, pending_boundary):
1725 Now static.
1726
50436f33
PE
1727 * textprop.c (interval_insert_behind_hooks): Now static.
1728 (interval_insert_in_front_hooks): Likewise.
1729
64520e5c
PE
1730 * term.c: Make symbols static if they're not exported.
1731 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1732 (max_frame_lines, tty_set_terminal_modes):
1733 (tty_reset_terminal_modes, tty_turn_off_highlight):
1734 (get_tty_terminal): Now static.
1735 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1736 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1737 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1738 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1739 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1740
1fa53021
PE
1741 * sysdep.c: Make symbols static if they're not exported.
1742 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1743 Now static.
1744 (sigprocmask_set, full_mask): Remove; unused.
1745 (wait_debugging): Mark as visible.
1746 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1747 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1748
d4b43b22
PE
1749 * syntax.c (syntax_temp): Define only if !__GNUC__.
1750
b7c513d0
PE
1751 * sound.c (current_sound_device, current_sound): Now static.
1752
989b29ad
PE
1753 * search.c (searchbufs, searchbuf_head): Now static.
1754
13a55a78
PE
1755 * scroll.c (scroll_cost): Remove; unused.
1756 * dispextern.h (scroll_cost): Remove decl.
1757
de68a1fc
PE
1758 * region-cache.h (pp_cache): Mark as externally visible.
1759
40ccffa6
PE
1760 * process.c: Make symbols static if they're not exported.
1761 (process_tick, update_tick, create_process, chan_process):
1762 (Vprocess_alist, proc_buffered_char, datagram_access):
1763 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1764 (deactivate_process): Mark defn as static, as well as decl.
1765 * lisp.h (create_process): Remove decl.
1766 * process.h (chan_process, Vprocess_alist): Remove decls.
1767
ad64fc97
PE
1768 * print.c: Make symbols static if they're not exported.
1769 (print_depth, new_backquote_output, being_printed, print_buffer):
1770 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1771 (print_interval, print_number_index, initial_stderr_stream):
1772 Now static.
1773 * lisp.h (Fprinc): Remove decl.
1774 (debug_output_compilation_hack): Mark as externally visible.
1775
adddb265
PE
1776 * sysdep.c (croak): Move decl from here to syssignal.h.
1777 * syssignal.h (croak): Put it here, so the API can be checked when
1778 'croak' is called from dissociate_if_controlling_tty.
1779
1717ede2
PE
1780 * minibuf.c: Make symbols static if they're not exported.
1781 (minibuf_save_list, choose_minibuf_frame): Now static.
1782 * lisp.h (choose_minibuf_frame): Remove decl.
1783
fa5fb2bc
PE
1784 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1785
1e3890d1
PE
1786 * lread.c: Make symbols static if they're not exported.
1787 (read_objects, initial_obarray, oblookup_last_bucket_number):
1788 Now static.
1789 (make_symbol): Remove; unused.
1790 * lisp.h (initial_obarray, make_symbol): Remove decls.
1791
8a1414fa
PE
1792 * keyboard.c: Make symbols static if they're not exported.
1793 (single_kboard, recent_keys_index, total_keys, recent_keys):
1794 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1795 (this_single_command_key_start, echoing, last_auto_save):
1796 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1797 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1798 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1799 (Vlispy_mouse_stem, double_click_count):
1800 Now static.
1801 (force_auto_save_soon): Define only if SIGDANGER.
1802 (ignore_mouse_drag_p): Now static if
1803 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1804 (print_help): Remove; unused.
1805 (stop_character, last_timer_event): Mark as externally visible.
1806 * keyboard.h (ignore_mouse_drag_p): Declare only if
1807 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1808 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1809 * lisp.h (echoing): Remove decl.
1810 (force_auto_save_soon): Declare only if SIGDANGER.
1811 * xdisp.c (redisplay_window): Simplify code, to make it more
1812 obvious that ignore_mouse_drag_p is not accessed if !defined
1813 USE_GTK && !defined HAVE_NS.
1814
93ea6e8f
PE
1815 * intervals.c: Make symbols static if they're not exported.
1816 (merge_properties_sticky, merge_interval_right, delete_interval):
1817 Now static.
1818 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1819
77382fcc
PE
1820 * insdel.c: Make symbols static if they're not exported.
1821 However, leave prepare_to_modify_buffer alone. It's never
1822 called from outside this function, but that appears to be a bug.
1823 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1824 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1825 (adjust_after_replace_noundo): Remove; unused.
1826 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1827 (signal_before_change): Remove decls.
77382fcc 1828
9306c32e
PE
1829 * indent.c (val_compute_motion, val_vmotion): Now static.
1830
cd44d2eb
PE
1831 * image.c: Make symbols static if they're not exported.
1832 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1833 if USE_GTK.
1834 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1835 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1836
ad9a7a06
PE
1837 * fringe.c (standard_bitmaps): Now static.
1838 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1839
81626931
PE
1840 * frame.c: Make symbols static if they're not exported.
1841 (x_report_frame_params, make_terminal_frame): Now static.
1842 (get_frame_param): Now static, unless HAVE_NS.
1843 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1844 (x_get_resource_string): Remove; not used.
1845 * frame.h (make_terminal_frame, x_report_frame_params):
1846 (x_get_resource_string); Remove decls.
1847 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1848 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1849
239f9db9
PE
1850 * font.c, fontset.c: Make symbols static if they're not exported.
1851 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1852 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1853 * font.c (font_close_object): Now static.
1854 * font.h (font_close_object): Remove.
1855 * fontset.c (FONTSET_OBJLIST): Remove.
1856 (free_realized_fontset) #if-0 the body, which does nothing.
1857 (face_suitable_for_char_p): #if-0, as it's never called.
1858 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1859 * xfaces.c (face_at_string_position):
1860 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1861 since 0 is always ASCII.
1862
dfcf3579
PE
1863 * fns.c (weak_hash_tables): Now static.
1864
5045092b
PE
1865 * fileio.c: Make symbols static if they're not exported.
1866 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1867 (Vwrite_region_annotation_buffers): Now static.
1868
57a96f5c
PE
1869 * eval.c: Make symbols static if they're not exported.
1870 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1871 * lisp.h (backtrace_list): Remove decl.
1872
35f08c38
PE
1873 * emacs.c: Make symbols static if they're not exported.
1874 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1875 (fatal_error_code, fatal_error_signal_hook, standard_args):
1876 Now static.
1877 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1878 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1879 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1880 * lisp.h (fatal_error_signal_hook): Remove decl.
1881 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1882
f44bd759
PE
1883 * editfns.c: Move a (normally-unused) function to its only use.
1884 * editfns.c, lisp.h (get_operating_system_release): Remove.
1885 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1886 worth the hassle of breaking this out.
1887
b532497d
PE
1888 * xterm.c: Make symbols static if they're not exported.
1889 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1890 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1891 (x_destroy_window, x_delete_display):
1892 Now static.
1893 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1894 (x_mouse_leave): Remove; unused.
1895 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1896 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1897 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1898 Remove decls.
1899 (x_mouse_leave): Declare only if WINDOWSNT.
1900 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1901 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1902 USE_X_TOOLKIT.
1903
1675728f
PE
1904 * ftxfont.c: Make symbols static if they're not exported.
1905 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1906 HAVE_FREETYPE.
1907 * font.h (ftxfont_driver): Likewise.
1908
e4cebfca
PE
1909 * xfns.c: Make symbols static if they're not exported.
1910 (x_last_font_name, x_display_info_for_name):
1911 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1912 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1913 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1914 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1915 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1916 (last_show_tip_args): Now static.
1917 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1918 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1919 (x_screen_planes): Remove; unused.
1920 * dispextern.h (x_screen_planes): Remove decl.
1921
5bf46f05
PE
1922 * dispnew.c: Make symbols static if they're not exported.
1923 * dispextern.h (redraw_garbaged_frames, scrolling):
1924 (increment_row_positions): Remove.
1925 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1926 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1927 Now static.
1928 (redraw_garbaged_frames): Remove; unused.
1929
435f4c28
PE
1930 * xfaces.c: Make symbols static if they're not exported.
1931 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1932 Remove decls.
1933 * xterm.h (defined_color): Remove decls.
1934 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1935 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1936 (menu_face_changed_default, defined_color, free_realized_face):
1937 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1938 (ascii_face_of_lisp_face): Remove; unused.
1939
8524aef3
PE
1940 * xdisp.c: Make symbols static if they're not exported.
1941 * dispextern.h (scratch_glyph_row, window_box_edges):
1942 (glyph_to_pixel_coords, set_cursor_from_row):
1943 (get_next_display_element, set_iterator_to_next):
1944 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1945 (show_mouse_face): Remove decls
1946 * frame.h (message_buf_print): Likewise.
1947 * lisp.h (pop_message, set_message, check_point_in_composition):
1948 Likewise.
1949 * xterm.h (set_vertical_scroll_bar): Likewise.
1950 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1951 (message_buf_print, scratch_glyph_row, displayed_buffer):
1952 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1953 (get_next_display_element, show_mouse_face, window_box_edges):
1954 (frame_to_window_pixel_xy, check_point_in_composition):
1955 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1956 (glyph_to_pixel_coords): Remove; unused.
1957
16390cd2
PE
1958 * dired.c (file_name_completion): Now static.
1959
1960 * dbusbind.c (xd_in_read_queued_messages): Now static.
1961
a25f4dfa
PE
1962 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1963 * data.c (circular_list_error): Remove.
1964
14a9c8df
PE
1965 * commands.h (last_point_position, last_point_position_buffer):
1966 (last_point_position_window): Remove decls.
1967 * keyboard.c: Make these variables static.
1968
04f2d78b
CB
1969 * coding.h (coding, code_convert_region, encode_coding_gap):
1970 Remove decls.
74ab6df5
PE
1971 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1972 (iso_code_class, detect_coding, code_convert_region): Now static.
1973 (encode_coding_gap): Remove; unused.
1974
38dfbee1
PE
1975 * chartab.c (chartab_chars, chartab_bits): Now static.
1976
a2cb4e63
PE
1977 * charset.h (charset_iso_8859_1): Remove decl.
1978 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1979 Now static.
1980
127198fd
PE
1981 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1982 * ccl.c (Vccl_program_table): Now static.
1983 (check_ccl_update): Remove; unused.
1984
d85b608f
PE
1985 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1986 * category.h: ... from here.
1987 * category.c (check_category_table, set_category_set): Now static.
1988
31cd66f3
PE
1989 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1990 * lisp.h: Remove these decls.
1991
c358e587
PE
1992 * buffer.c (buffer_count): Remove unused var.
1993
e78aecca
PE
1994 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1995 so that it's not optimized away.
1996 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1997 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1998 exported only to the debugger.
1999
e192d7d3 2000 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2001 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2002
92470028
PE
2003 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2004 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2005 was inaccessible from Lisp.
2006 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2007 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2008
244ed907
PE
2009 alloc.c: Import and export fewer symbols, and remove unused items.
2010 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2011 is defined.
2012 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2013 it's not optimized away by whole-program optimization.
2014 (message_enable_multibyte, free_misc): Remove.
2015 (catchlist, handlerlist, mark_backtrace):
2016 Declare only if BYTE_MARK_STACK.
2017 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2018 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2019 (message_enable_multibyte): Remove decl.
2020 (free_misc, interval_free_list, float_block, float_block_index):
2021 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2022 (cons_free_list, last_marked_index):
2023 Now static.
2024 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2025 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2026 (mark_backtrace): Define only if BYTE_MARK_STACK.
2027 * xdisp.c (message_enable_multibyte): Now static.
2028
61c2b50e 2029 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2030 This makes it easier for human readers (and static analyzers)
2031 to see whether these variables are used from other modules.
2032 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2033 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2034 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2035 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2036 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2037 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2038 * xmenu.c, xselect.c:
2039 Declare Q* vars static if they are not used in other modules.
2040 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2041 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2042 Remove decls of unexported vars.
2043 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2044
95c82688
PE
2045 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2046
16a97296
PE
2047 Make Emacs functions such as Fatom 'static' by default.
2048 This makes it easier for human readers (and static analyzers)
2049 to see whether these functions can be called from other modules.
2050 DEFUN now defines a static function. To make the function external
2051 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2052 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2053 (Finit_image_library):
16a97296
PE
2054 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2055 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2056 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2057 Remove decls, since these functions are now static.
2058 (Funintern, Fget_internal_run_time): New decls, since these functions
2059 were already external.
95c82688 2060
16a97296
PE
2061 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2062 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2063 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2064 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2065 * keyboard.c, keymap.c, lread.c:
2066 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2067 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2068 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2069 Mark functions with DEFUE instead of DEFUN,
2070 if they are used in other modules.
2071 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2072 decls for now-static functions.
2073 * buffer.h (Fdelete_overlay): Remove decl.
2074 * callproc.c (Fgetenv_internal): Mark as internal.
2075 * composite.c (Fremove_list_of_text_properties): Remove decl.
2076 (Fcomposition_get_gstring): New forward static decl.
2077 * composite.h (Fcomposite_get_gstring): Remove decl.
2078 * dired.c (Ffile_attributes): New forward static decl.
2079 * doc.c (Fdocumntation_property): New forward static decl.
2080 * eval.c (Ffetch_bytecode): New forward static decl.
2081 (Funintern): Remove extern decl; now in .h file where it belongs.
2082 * fileio.c (Fmake_symbolic_link): New forward static decl.
2083 * image.c (Finit_image_library): New forward static decl.
2084 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2085 * intervals.h (Fprevious_property_change):
2086 (Fremove_list_of_text_properties): Remove decls.
2087 * keyboard.c (Fthis_command_keys): Remove decl.
2088 (Fcommand_execute): New forward static decl.
2089 * keymap.c (Flookup_key): New forward static decl.
2090 (Fcopy_keymap): Now static.
2091 * keymap.h (Flookup_key): Remove decl.
2092 * process.c (Fget_process): New forward static decl.
2093 (Fprocess_datagram_address): Mark as internal.
2094 * syntax.c (Fsyntax_table_p): New forward static decl.
2095 (skip_chars): Remove duplicate decl.
2096 * textprop.c (Fprevious_property_change): New forward static decl.
2097 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2098 Now internal.
2099 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2100 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2101
785bbd42
PE
2102 * editfns.c (Fformat): Remove unreachable code.
2103
8b913b57
AS
21042011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2105
2106 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2107 change. (Bug#8496)
2108
a6744a35
EZ
21092011-04-13 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2112 when at ZV. (Bug#8487)
2113
e7974947
AS
21142011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2115
baad03f0
AS
2116 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2117 (Bug#8437)
2118 * keyboard.c (parse_tool_bar_item): Likewise.
2119 * sound.c (sound_cleanup, alsa_close): Likewise.
2120 * termcap.c (tgetent): Likewise.
2121 * xfns.c (x_default_font_parameter): Likewise.
2122 * xsettings.c (read_and_apply_settings): Likewise.
2123
e7974947
AS
2124 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2125 (overrun_check_free): Protoize.
2126
28272684
PE
21272011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2128
2129 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2130 since callers should never pass a negative size.
2131 Change the signature to match that of plain 'read' and 'write'; see
2132 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2133 * lisp.h: Update prototypes of emacs_write and emacs_read.
2134
11997c76
EZ
21352011-04-11 Eli Zaretskii <eliz@gnu.org>
2136
2137 * xdisp.c (redisplay_window): Don't try to determine the character
2138 position of the scroll margin if the window start point w->startp
e896f03c 2139 is outside the buffer's accessible region. (Bug#8468)
11997c76 2140
8a2cbd72
EZ
21412011-04-10 Eli Zaretskii <eliz@gnu.org>
2142
2143 Fix write-region and its subroutines for buffers > 2GB.
2144 * fileio.c (a_write, e_write): Modify declaration of arguments and
2145 local variables to support buffers larger than 2GB.
2146 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2147
2148 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2149 argument, local variables, and return value.
2150
2151 * lisp.h: Update prototypes of emacs_write and emacs_read.
2152
2153 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2154
4073e537 21552011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2156
1ebfdcb6
PE
2157 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2158
b2ded58d
PE
2159 Fix more problems found by GCC 4.6.0's static checks.
2160
7d66342c
PE
2161 * xdisp.c (vmessage): Use a better test for character truncation.
2162
bbf47d44
PE
2163 * charset.c (load_charset_map): <, not <=, for optimization,
2164 and to avoid potential problems with integer overflow.
9248994d 2165 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2166 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2167 * editfns.c (Fformat): Likewise.
1e69125e 2168 * syntax.c (skip_chars): Likewise.
3befa583 2169
e3019616
PE
2170 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2171 This also lets GCC 4.6.0 generate slightly better loop code.
2172
becfa255
PE
2173 * callint.c (Fcall_interactively): <, not <=, for optimization.
2174 (Fcall_interactively): Count the number of arguments produced,
2175 not the number of arguments given. This is simpler and lets GCC
2176 4.6.0 generate slightly better code.
2177
dae0cd48
PE
2178 * ftfont.c: Distingish more carefully between FcChar8 and char.
2179 The previous code passed unsigned char * to a functions like
2180 strlen and xstrcasecmp that expect char *, which does not
2181 conform to the C standard.
2182 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2183 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2184 char * when the C standard requires it.
2185
76032d70
PE
2186 * keyboard.c (read_char): Remove unused var.
2187
eb3f1cc8
PE
2188 * eval.c: Port to Windows vsnprintf (Bug#8435).
2189 Include <limits.h>.
2190 (SIZE_MAX): Define if the headers do not.
2191 (verror): Do not give up if vsnprintf returns a negative count.
2192 Instead, grow the buffer. This ports to Windows vsnprintf, which
2193 does not conform to C99. Problem reported by Eli Zaretskii.
2194 Also, simplify the allocation scheme, by avoiding the need for
2195 calling realloc, and removing the ALLOCATED variable.
2196
70476b54
PE
2197 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2198
12020a9e
PE
2199 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2200 But keep the doprint source code for now, as we might revamp it
2201 and use it again (Bug#8435).
ea6c7ae6
PE
2202 * lisp.h (doprnt): Remove.
2203 * Makefile.in (base_obj): Remove doprnt.o.
2204 * deps.mk (doprnt.o): Remove.
2205
5fdb398c
PE
2206 error: Print 32- and 64-bit integers portably (Bug#8435).
2207 Without this change, on typical 64-bit hosts error ("...%d...", N)
2208 was used to print both 32- and 64-bit integers N, which relied on
2209 undefined behavior.
2210 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2211 New macro.
2212 * lisp.h (error, verror): Mark as printf-like functions.
2213 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2214 Report overflow in size calculations when allocating printf buffer.
2215 Do not truncate output string at its first null byte.
2216 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2217 Truncate the output at a character boundary, since vsnprintf does not
2218 do that.
2219 * charset.c (check_iso_charset_parameter): Convert internal
2220 character to string before calling 'error', since %c now has the
2221 printf meaning.
2222 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2223 overflow when computing char to be passed to 'error'. Do not
2224 pass Lisp_Object to 'error'; pass the integer instead.
2225 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2226 formatted with plain %d.
2227
b189fa66
PE
2228 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2229
bff87ef0
PE
2230 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2231
7e2cac20
PE
2232 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2233
ce4d90b5
PE
2234 * xterm.c (x_catch_errors): Remove duplicate declaration.
2235
266c9547
PE
2236 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2237
79c49ad2
PE
2238 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2239
368f4090
JM
22402011-04-10 Jim Meyering <meyering@redhat.com>
2241
2242 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2243 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2244 return ssize_t not "int", and use size_t as the buffer length.
2245 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2246 * gnutls.h: Update declarations.
2247 * process.c (read_process_output): Use ssize_t, to match.
2248 (send_process): Likewise.
2249
a32d4040
CY
22502011-04-09 Chong Yidong <cyd@stupidchicken.com>
2251
2252 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2253
8546720e 22542011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2255
04f2d78b
CB
2256 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2257 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2258
8546720e
GM
2259 * xterm.c (handle_one_xevent):
2260 * xmenu.c (create_and_show_popup_menu):
2261 * xselect.c (x_decline_selection_request)
2262 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2263
0a2f5c1a 22642011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2265
2266 Fix some uses of `int' instead of EMACS_INT.
2267 * search.c (string_match_1, fast_string_match)
2268 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2269 (scan_buffer, find_next_newline_no_quit)
2270 (find_before_next_newline, search_command, Freplace_match)
2271 (Fmatch_data): Make some `int' variables be EMACS_INT.
2272
2273 * xdisp.c (display_count_lines): 3rd argument and return value now
2274 EMACS_INT. All callers changed.
2275 (pint2hrstr): Last argument is now EMACS_INT.
2276
2277 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2278 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2279 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2280 (decode_coding_utf_16, decode_coding_emacs_mule)
2281 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2282 (decode_coding_ccl, decode_coding_charset)
2283 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2284 (decode_coding_iso_2022, decode_coding_emacs_mule)
2285 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2286 <char_offset, last_offset>: Declare EMACS_INT.
2287 (encode_coding_utf_8, encode_coding_utf_16)
2288 (encode_coding_emacs_mule, encode_invocation_designation)
2289 (encode_designation_at_bol, encode_coding_iso_2022)
2290 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2291 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2292 Declare EMACS_INT.
2293 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2294 (encode_invocation_designation): Last argument P_NCHARS is now
2295 EMACS_INT.
2296 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2297 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2298
2299 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2300 All users changed.
2301
2302 * ccl.c (Fccl_execute_on_string): Declare some variables
2303 EMACS_INT.
2304
8546720e 23052011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2306
2307 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2308
4e19a977
CS
23092011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2310
2311 * process.c (Fformat_network_address): Doc fix.
2312
87302331
R
23132011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2314
2315 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2316
cbb59342
CY
23172011-04-08 Chong Yidong <cyd@stupidchicken.com>
2318
2319 * keyboard.c (read_char): Call Lisp function help-form-show,
2320 instead of using internal_with_output_to_temp_buffer.
2321 (Qhelp_form_show): New var.
e0d38eeb 2322 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2323
2324 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2325
2326 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2327
e67a13ab
CY
23282011-04-06 Chong Yidong <cyd@stupidchicken.com>
2329
04f2d78b
CB
2330 * process.c (Flist_processes): Remove to Lisp.
2331 (list_processes_1): Delete.
e67a13ab 2332
973f782d
EZ
23332011-04-06 Eli Zaretskii <eliz@gnu.org>
2334
7c106b1e
EZ
2335 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2336
973f782d
EZ
2337 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2338
41cf7d1a 23392011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2340
ca23cc88
PE
2341 Fix more problems found by GCC 4.6.0's static checks.
2342
f390e2d5
PE
2343 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2344
42eea0d0
PE
2345 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2346
b69769da 2347 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2348
f9541e84
PE
2349 * xdisp.c (vmessage): Mark as a printf-like function.
2350
13841b55
PE
2351 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2352
c136c10f
PE
2353 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2354
5e2d4a30
PE
2355 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2356 printf-like functions.
2357 (tiff_load): Add casts to remove these marks before passing them
2358 to system-supplied API.
2359
583f48b9
PE
2360 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2361
b25d760e
PE
2362 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2363 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2364 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2365 directly, rather than having caller test rule sign. This avoids
2366 some unnecessary tests.
2367 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2368 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2369 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2370
bc7b6697 2371 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2372 (xfont_open): Avoid unnecessary tests.
bc7b6697 2373
27ccc379
PE
2374 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2375
dcd5c89a
PE
2376 * composite.h, composite.c (composition_gstring_put_cache):
2377 Use EMACS_INT, not int, for length.
2378
b13a45c6
PE
2379 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2380 breaking out part of COMPOSITION_DECODE_RULE.
2381 (COMPOSITION_DECODE_RULE): Use it.
2382 * composite.c (get_composition_id): Remove unused local vars,
2383 by using the new macro.
2384
1e792e4d
PE
2385 * textprop.c (set_text_properties_1): Change while to do-while,
2386 since the condition is always true at first.
2387
dc6c6455 2388 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2389 (interval_deletion_adjustment): Return unsigned value.
2390 All uses changed.
dc6c6455 2391
aba7731a
PE
2392 * process.c (list_processes_1, create_pty, read_process_output):
2393 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2394 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2395 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2396 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2397 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2398
fdfc4bf3
PE
2399 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2400
fca8fe46 2401 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2402 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2403
06a0259a 2404 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2405 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2406 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2407
e7b9e80f
PE
2408 * print.c (print_error_message): Avoid int overflow.
2409
56201685
PE
2410 * font.c (font_list_entities): Redo for clarity,
2411 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2412
78834453 2413 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2414 (font_score): Avoid potential overflow in diff calculation.
78834453 2415
0bc0b309 2416 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2417 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2418
e610eaca
PE
2419 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2420
b895abce
PE
2421 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2422 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2423 can always succeed if overflow has undefined behavior.
2424
1f1d9321 2425 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2426 (wordify): Omit three unnecessary tests.
1f1d9321 2427
c59478bc
PE
2428 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2429 All callers changed. This avoids the need for an unused var.
2430
79b73827
PE
2431 * casefiddle.c (casify_region): Remove var that is set but not used.
2432
a4db5dfe
PE
2433 * dired.c (file_name_completion): Remove var that is set but not used.
2434
43aae36e
PE
2435 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2436
2a47c44d 2437 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2438 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2439
a37c69bf
PE
2440 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2441 Check for integer overflow on size calculations.
2442
328ab8e7
PE
2443 * buffer.c (Fprevious_overlay_change): Remove var that is set
2444 but not used.
2445
e5a2a5cb
PE
2446 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2447 Remove vars that are set but not used.
8d84a6eb 2448 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2449 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2450
a60e5f68
PE
2451 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2452
f661cb61 2453 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2454 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2455
f0397f5a
PE
2456 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2457 that are set but not used.
2458
8664db06 2459 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2460 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2461
6abdaa4a
PE
2462 * xselect.c (x_get_local_selection, x_handle_property_notify):
2463 Remove vars that are set but not used.
2464
0ce7538d 2465 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2466 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2467
9ae848fc
PE
2468 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2469 Remove var that is set but not used.
0b918413
PE
2470 (scroll_bar_windows_size): Now size_t, not int.
2471 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2472 Check for overflow.
9ae848fc 2473
a5a62657
PE
2474 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2475 (map_tty_color) [!defined MSDOS]: Likewise.
2476
5c5cdd39
PE
2477 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2478
66ebf983
PE
2479 * coding.c: Remove vars that are set but not used.
2480 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2481 All callers changed.
2482 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2483 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2484 (decode_coding_charset): Remove vars that are set but not used.
2485
1be4d761
PE
2486 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2487 that is set but not used.
2488
47553fa8
PE
2489 * print.c (print_object): Remove var that is set but not used.
2490
1f7196bf 2491 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2492 The gnulib version avoids calling malloc in the usual case,
2493 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2494 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2495 * filelock.c (current_lock_owner): Likewise.
2496 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2497 * sysdep.c: Include allocator.h, careadlinkat.h.
2498 (emacs_no_realloc_allocator): New static constant.
2499 (emacs_readlink): New function.
fdb61804
PE
2500 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2501 ../lib/careadlinkat.h.
d1fdcab7 2502
f84c17c7
SM
25032011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2504
2505 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2506 first non-nil return value).
2507
ef3862ad
JD
25082011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2509
2510 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2511 if not defined (Bug#8403).
2512
376a7006
JB
25132011-04-02 Juanma Barranquero <lekktu@gmail.com>
2514
2515 * xdisp.c (display_count_lines): Remove parameter `start',
2516 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2517 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2518 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2519 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2520 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2521 and thereabouts. All callers changed.
2522 (get_per_char_metric): Remove parameter `f', unused since
2523 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2524
6ca3801d
JM
25252011-04-02 Jim Meyering <meyering@redhat.com>
2526
2527 do not dereference NULL upon failed strdup
2528 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2529 (ns_get_family): Likewise.
2530
d8e2b5ba
JB
25312011-04-02 Juanma Barranquero <lekktu@gmail.com>
2532
2533 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2534
8c74fcbd
JD
25352011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2536
2537 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2538 later (Bug#8403).
2539
7200d79c
SM
25402011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2541
03408648 2542 Add lexical binding.
7200d79c 2543
03408648
SM
2544 * window.c (Ftemp_output_buffer_show): New fun.
2545 (Fsave_window_excursion):
2546 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2547
2548 * lread.c (lisp_file_lexically_bound_p): New function.
2549 (Fload): Bind Qlexical_binding.
2550 (readevalloop): Remove `evalfun' arg.
2551 Bind Qinternal_interpreter_environment.
2552 (Feval_buffer): Bind Qlexical_binding.
2553 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2554 Mark as dynamic.
2555 (syms_of_lread): Declare `lexical-binding'.
2556
2557 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2558
2559 * keyboard.c (eval_dyn): New fun.
2560 (menu_item_eval_property): Use it.
ca105506
SM
2561
2562 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2563
03408648
SM
2564 * fns.c (concat, mapcar1): Accept byte-code-functions.
2565
2566 * eval.c (Fsetq): Handle lexical vars.
2567 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2568 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2569 (FletX, Flet): Obey lexical binding.
2570 (Fcommandp): Handle closures.
2571 (Feval): New `lexical' arg.
2572 (eval_sub): New function extracted from Feval. Use it almost
2573 everywhere where Feval was used. Look up vars in lexical env.
2574 Handle closures.
2575 (Ffunctionp): Move from subr.el.
2576 (Ffuncall): Handle closures.
2577 (apply_lambda): Remove `eval_flags'.
2578 (funcall_lambda): Handle closures and new byte-code-functions.
2579 (Fspecial_variable_p): New function.
2580 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2581 but without exporting it to Lisp.
23aba0ea 2582
23aba0ea 2583 * doc.c (Fdocumentation, store_function_docstring):
03408648 2584 * data.c (Finteractive_form): Handle closures.
23aba0ea 2585
03408648
SM
2586 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2587 interactive spec.
ba83908c 2588
04f2d78b
CB
2589 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2590 New byte-codes.
03408648
SM
2591 (exec_byte_code): New function extracted from Fbyte_code to handle new
2592 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2593
03408648 2594 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2595
03408648 2596 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2597
e2abce01
JB
25982011-03-31 Juanma Barranquero <lekktu@gmail.com>
2599
2600 * xdisp.c (redisplay_internal): Fix prototype.
2601
63696a73 26022011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2603
63696a73 2604 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2605 (try_scrolling): Use it when setting scroll_limit.
2606 Limit scrolling to 100 screen lines.
63696a73
EZ
2607 (redisplay_window): Even when falling back on "recentering",
2608 position point in the window according to scroll-conservatively,
2609 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2610
2611 (try_scrolling): When point is above the window, allow searching
2612 as far as scroll_max, or one screenful, to compute vertical
2613 distance from PT to the scroll margin position. This prevents
2614 try_scrolling from unnecessarily failing when
2615 scroll-conservatively is set to a value slightly larger than the
2616 window height. Clean up the case of PT below the margin at bottom
2617 of window: scroll_max can no longer be INT_MAX. When aggressive
2618 scrolling is in use, don't let point enter the opposite scroll
2619 margin as result of the scroll.
2620 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2621 threshold of 100 lines for never-recentering scrolling.
2622
e4cc2dfc
JB
26232011-03-31 Juanma Barranquero <lekktu@gmail.com>
2624
2625 * dispextern.h (move_it_by_lines):
2626 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2627 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2628 (message_log_check_duplicate): Remove parameters `prev_bol' and
2629 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2630 (redisplay_internal): Remove parameter `preserve_echo_area',
2631 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2632
2633 * indent.c (Fvertical_motion):
2634 * window.c (window_scroll_pixel_based, Frecenter):
2635 Don't pass `need_y_p' to `move_it_by_lines'.
2636
1c470562
SM
26372011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2638
44f230aa
SM
2639 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2640 steal a few bits to be more compact.
2641 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2642 Remove unneeded casts.
2643
1c470562
SM
2644 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2645
888adce9
ZK
26462011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2647
2648 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2649 binding" message (bug#7967).
2650
f838ed7b
PE
26512011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2652
77861b95
PE
2653 Fix more problems found by GCC 4.6.0's static checks.
2654
de6dbc14
PE
2655 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2656 Remove unused local var.
2657
f838ed7b
PE
2658 * editfns.c (Fmessage_box): Remove unused local var.
2659
792c7b2b
PE
2660 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2661 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2662 Omit unused local vars.
c499e557 2663 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2664 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2665 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2666 Omit unused local var.
2667
ba0165e1
PE
2668 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2669 Don't assume string length fits in int.
32ad8845 2670 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2671 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2672
3c59b4c9
PE
2673 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2674 instead of alloca (Bug#8344).
2675
a3eed478 2676 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2677 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2678
eb4d412d
PE
2679 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2680
1658b401
PE
2681 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2682 concerns.
2683
2684 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2685
2686 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2687
9a2c6e05
PE
2688 * keyboard.c (syms_of_keyboard): Use the same style as later
2689 in this function when indexing through an array. This also
2690 works around GCC bug 48267.
2691
03d0a109
PE
2692 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2693
44f730c8
PE
2694 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2695
fe75f926
PE
2696 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2697 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2698
ffa8c828
PE
2699 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2700 This avoids undefined behavior on integer overflow, and is a bit
2701 more convenient anyway since it is compared to a size_t variable.
2702
c5101a77
PE
2703 Variadic C functions now count arguments with size_t, not int.
2704 This avoids an unnecessary limitation on 64-bit machines, which
2705 caused (substring ...) to crash on large vectors (Bug#8344).
2706 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2707 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2708 All variadic functions and their callers changed accordingly.
c5101a77
PE
2709 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2710 * data.c (arith_driver, float_arith_driver): Likewise.
2711 * editfns.c (general_insert_function): Likewise.
2712 * eval.c (struct backtrace.nargs, interactive_p)
2713 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2714 (funcall_lambda, mark_backtrace): Likewise.
2715 * fns.c (concat): Likewise.
2716 * frame.c (x_set_frame_parameters): Likewise.
2717 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2718 0 if not found, not -1. All callers changed.
2719
dd3f25f7
PE
2720 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2721 (stack_copy_size): Now size_t, not int.
2722 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2723
461c2ab9
JB
27242011-03-28 Juanma Barranquero <lekktu@gmail.com>
2725
2726 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2727 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2728 All callers changed.
2729
2730 * lisp.h (multibyte_char_to_unibyte):
2731 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2732 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2733 * character.h (CHAR_TO_BYTE8):
2734 * cmds.c (internal_self_insert):
2735 * editfns.c (general_insert_function):
2736 * keymap.c (push_key_description):
2737 * search.c (Freplace_match):
2738 * xdisp.c (message_dolog, set_message_1): All callers changed.
2739
f6d62986
SM
27402011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2741
2742 * keyboard.c (safe_run_hook_funcall): New function.
2743 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2744 don't set the hook to nil, but remove the offending function instead.
2745 (Qcommand_hook_internal): Remove, unused.
2746 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2747 Vcommand_hook_internal.
2748
2749 * eval.c (enum run_hooks_condition): Remove.
2750 (funcall_nil, funcall_not): New functions.
2751 (run_hook_with_args): Call each function through a `funcall' argument.
2752 Remove `cond' argument, now redundant.
2753 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2754 (Frun_hook_with_args_until_failure): Adjust accordingly.
2755 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2756
1db5b1ad
JB
27572011-03-28 Juanma Barranquero <lekktu@gmail.com>
2758
2759 * dispextern.h (string_buffer_position): Remove declaration.
2760
2761 * print.c (strout): Remove parameter `multibyte', unused since
2762 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2763
2764 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2765 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2766 All callers changed.
2767
2768 * w32.c (_wsa_errlist): Use braces for struct initializers.
2769
2770 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2771 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2772 All callers changed.
2773 (string_buffer_position): Likewise. Also, make static (it's never
2774 used outside xdisp.c).
2775 (cursor_row_p): Remove parameter `w', unused since
2776 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2777 (decode_mode_spec): Remove parameter `precision', introduced during
2778 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2779 All callers changed.
2780
5ffb62aa
JD
27812011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2782
2783 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2784
461c2ab9 27852011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2786
2787 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2788 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2789 (ns_update_auto_hide_menu_bar): New functions.
2790 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2791 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2792 ns_constrain_all_frames.
2793 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2794 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2795
5c380ffb
JD
27962011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2797
2798 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2799
9af30bdf
GM
28002011-03-27 Glenn Morris <rgm@gnu.org>
2801
2802 * syssignal.h: Replace RETSIGTYPE with void.
2803 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2804 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2805 Replace SIGTYPE with void everywhere.
2806 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2807 * s/template.h (SIGTYPE): Remove commented out definition.
2808
e2abce01
JB
28092011-03-26 Eli Zaretskii <eliz@gnu.org>
2810
2811 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2812 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2813
f868cd8a
JB
28142011-03-26 Juanma Barranquero <lekktu@gmail.com>
2815
59eb0929
JB
2816 * w32.c (read_unc_volume): Use parameter `henum', instead of
2817 global variable `wget_enum_handle'.
2818
2819 * keymap.c (describe_vector): Remove parameters `indices' and
2820 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2821 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2822
f868cd8a
JB
2823 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2824
2825 * keyboard.c (timer_check): Remove parameter `do_it_now',
2826 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2827 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2828 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2829
2830 * keyboard.c (read_char):
2831 * w32menu.c (w32_menu_display_help):
2832 * xmenu.c (show_help_event, menu_help_callback):
2833 Adjust calls to `show_help_echo'.
2834
2835 * gtkutil.c (xg_maybe_add_timer):
2836 * keyboard.c (readable_events):
2837 * process.c (wait_reading_process_output):
2838 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2839
2840 * insdel.c (adjust_markers_gap_motion):
2841 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2842 (gap_left, gap_right): Don't call it.
2843
2ecf6fdb
CY
28442011-03-25 Chong Yidong <cyd@stupidchicken.com>
2845
2846 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2847 incurred during fontification.
2848
6b1f9ba4
JB
28492011-03-25 Juanma Barranquero <lekktu@gmail.com>
2850
2851 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2852 (DEFVAR_PER_BUFFER): Don't pass it.
2853
2854 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2855 (scrolling_window): Don't pass it.
2856
0f4a96b5
JB
28572011-03-25 Juanma Barranquero <lekktu@gmail.com>
2858
2859 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2860
2861 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2862 and `suffix'.
2863 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2864 of variables specific to SELinux and computation of `encoded_absname'.
2865
2866 * image.c (XPutPixel): Remove unused variable `height'.
2867
2868 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2869
2870 * unexw32.c (get_section_info): Remove unused variable `section'.
2871
2872 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2873 (system_process_attributes): Remove unused variable `sess'.
2874 (sys_read): Remove unused variable `err'.
2875
2876 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2877 (w32_wnd_proc): Remove unused variable `isdead'.
2878 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2879 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2880 (x_create_tip_frame): Remove unused variable `tem'.
2881
2882 * w32inevt.c (w32_console_read_socket):
2883 Remove unused variable `no_events'.
2884
2885 * w32term.c (x_draw_composite_glyph_string_foreground):
2886 Remove unused variable `width'.
2887
1149507c
JB
28882011-03-24 Juanma Barranquero <lekktu@gmail.com>
2889
2890 * w32term.c (x_set_glyph_string_clipping):
2891 Don't pass uninitialized region to CombineRgn.
2892
9c88f339
JB
28932011-03-23 Juanma Barranquero <lekktu@gmail.com>
2894
2895 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2896 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2897 (Fx_close_connection): Remove unused variable `i'.
2898
2899 * w32font.c (w32font_draw): Return number of glyphs.
2900 (w32font_open_internal): Remove unused variable `i'.
2901 (w32font_driver): Add missing initializer.
2902
2903 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2904 (fill_in_menu): Remove unused variable `items_added'.
2905
2906 * w32term.c (last_mouse_press_frame): Remove static global variable.
2907 (w32_clip_to_row): Remove unused variable `f'.
2908 (x_delete_terminal): Remove unused variable `i'.
2909
2910 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2911 (NOTHING): Remove unused static global variable.
2912 (uniscribe_check_otf): Remove unused variable `table'.
2913 (uniscribe_font_driver): Add missing initializers.
2914
dee091a3
JD
29152011-03-23 Julien Danjou <julien@danjou.info>
2916
2917 * term.c (Fsuspend_tty, Fresume_tty):
2918 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2919 * window.c (temp_output_buffer_show):
2920 * insdel.c (signal_before_change):
2921 * frame.c (Fhandle_switch_frame):
2922 * fileio.c (Fdo_auto_save):
2923 * emacs.c (Fkill_emacs):
2924 * editfns.c (save_excursion_restore):
2925 * cmds.c (internal_self_insert):
2926 * callint.c (Fcall_interactively):
2927 * buffer.c (Fkill_all_local_variables):
2928 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2929 Use Frun_hooks.
0f4a96b5 2930 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2931 unconditionnaly since it does the check itself.
2932
2c520ab5 29332011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2934
c9c49752
PE
2935 Fix more problems found by GCC 4.5.2's static checks.
2936
8abc3f12
PE
2937 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2938 the first time through the loop, since we know p0 < p1 then.
2939 This also avoids a gcc -Wstrict-overflow warning.
2940
a2d26660
PE
2941 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2942 leading to a memory leak, possible in functions like
2943 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2944 of objects (Bug#8318).
a2d26660 2945
916c72e9
PE
2946 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2947 that could (at least in theory) be that large.
2948
19ab8a18
PE
2949 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2950 This is less likely to overflow, and avoids undefined behavior if
2951 overflow does occur. All callers changed. Use strtoul to scan
2952 for the unsigned long integer.
b7cbbd6f
PE
2953 (pint2hrstr): Simplify and tune code slightly.
2954 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2955
f0641eff
PE
2956 * scroll.c (do_scrolling): Work around GCC bug 48228.
2957 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2958
7f650bb9
PE
2959 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2960 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2961 (validate_x_resource_name): Simplify count usage.
2962 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2963
37dd57d1
PE
2964 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2965 fail (Bug#8306).
81e56e61 2966
699979fc 2967 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2968
401bf9b4
PE
2969 * process.c (Fmake_network_process): Use socklen_t, not int,
2970 where POSIX says socklen_t is required in portable programs.
2971 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2972 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2973 (Fmake_network_process, server_accept_connection):
2974 (wait_reading_process_output, read_process_output):
2975 Likewise.
2976
b93aacde
PE
2977 * process.c: Rename or move locals to avoid shadowing.
2978 (list_processes_1, Fmake_network_process):
2979 (read_process_output_error_handler, exec_sentinel_error_handler):
2980 Rename or move locals.
4dc343ee 2981 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2982 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2983 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2984 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2985 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2986
af8a867c 2987 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2988 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2989 Include tparam.h instead, since it declares them.
af8a867c
PE
2990 * cm.h (PC): Remove extern decl; tparam.h now does this.
2991 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2992 * terminfo.c: Include tparam.h, to check interfaces.
2993 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2994 (tparam): Adjust signature to match interface in tparam.h;
2995 this removes some undefined behavior. Check that outstring and len
2996 are zero, which they always are with Emacs.
2997 * tparam.h (PC, BC, UP): New extern decls.
2998
0248044d 2999 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3000 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3001
8ff096c1 3002 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3003 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3004 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3005 (ftfont_list): Remove unused local.
49eaafba
PE
3006 (get_adstyle_property, ftfont_pattern_entity):
3007 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3008 Rename locals to avoid shadowing.
8ff096c1 3009
e2be39f6
PE
3010 * xfont.c (xfont_list_family): Mark var as initialized.
3011
c9735e30
PE
3012 * xml.c (make_dom): Now static.
3013
8f5201ae
PE
3014 * composite.c (composition_compute_stop_pos): Rename local to
3015 avoid shadowing.
b246f932
PE
3016 (composition_reseat_it): Remove unused locals.
3017 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3018 (composition_update_it): Mark var as initialized.
11b61122
PE
3019 (find_automatic_composition): Mark vars as initialized,
3020 with a FIXME (Bug#8290).
8f5201ae 3021
760fbc2c
PE
3022 character.h: Rename locals to avoid shadowing.
3023 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3024 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3025 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3026 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3027 to avoid shadowing.
3028
ff08eb85
PE
3029 * textprop.c (property_change_between_p): Remove; unused.
3030
fc7bf025
PE
3031 * intervals.c (interval_start_pos): Now static.
3032
235d7abc
PE
3033 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3034
44f230aa
SM
3035 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3036 Rename locals to avoid shadowing.
3e7d6594 3037
50060332
PE
3038 * sound.c (wav_play, au_play, Fplay_sound_internal):
3039 Fix pointer signedness.
d01f234b 3040 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3041 (wav_play): Initialize a variable to 0, to prevent undefined
3042 behavior (Bug#8278).
50060332 3043
c4fc4e30
PE
3044 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3045
918436ed
PE
3046 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3047
c939f91b
PE
3048 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3049 clobbering (Bug#8298).
b9c7f648
PE
3050 * sysdep.c (sys_subshell): Likewise.
3051 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3052
6bd8c144
PE
3053 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3054 This should get cleaned up, so that child_setup has the
3055 same signature on all platforms.
3056
7710357c 3057 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3058 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3059
c59da222
CY
30602011-03-22 Chong Yidong <cyd@stupidchicken.com>
3061
3062 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3063 not to be necessary, and produces flickering.
3064
66b87493
GM
30652011-03-20 Glenn Morris <rgm@gnu.org>
3066
3067 * config.in: Remove file.
3068
45b6f6d5
JB
30692011-03-20 Juanma Barranquero <lekktu@gmail.com>
3070
3071 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3072 are now in src/globals.h.
3073 (syms_of_minibuf): Remove spurious & from previous change.
3074
3ec03f7e
LL
30752011-03-20 Leo <sdl.web@gmail.com>
3076
3077 * minibuf.c (completing-read-function): New variable.
3078 (completing-read-default): Rename from completing-read.
3079 (completing-read): Call completing-read-function.
3080
b14e3e21
CY
30812011-03-19 Juanma Barranquero <lekktu@gmail.com>
3082
3083 * xfaces.c (Fx_load_color_file):
3084 Read color file from absolute filename (bug#8250).
3085
f2b726e6
JB
30862011-03-19 Juanma Barranquero <lekktu@gmail.com>
3087
3088 * makefile.w32-in: Update dependencies.
3089
09f6ff02
EZ
30902011-03-17 Eli Zaretskii <eliz@gnu.org>
3091
3092 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3093
29a6015a
PE
30942011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3095
a3a6c54e
PE
3096 Fix more problems found by GCC 4.5.2's static checks.
3097
b766f867
PE
3098 * process.c (make_serial_process_unwind, send_process_trap):
3099 (sigchld_handler): Now static.
3100
be02381c
PE
3101 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3102 That way, the code declares only the vars that it needs.
3103 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3104 * s/cygwin.h (PTY_ITERATION): Likewise.
3105 * s/darwin.h (PTY_ITERATION): Likewise.
3106 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3107
57048744
PE
3108 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3109 * process.c (allocate_pty): Don't declare stb unless it's needed.
3110
7914961c 3111 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3112 (CONSTANTLIM): Remove; unused.
3113 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3114 Define only if needed.
7914961c 3115
b3967b18
PE
3116 * unexelf.c (unexec): Name an expression,
3117 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3118 Use a different way to cause a compilation error if anyone uses
3119 n rather than nn, a way that does not involve shadowing.
73366a00 3120 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3121
29a6015a
PE
3122 * deps.mk (unexalpha.o): Remove; unused.
3123
43cfc33e 3124 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3125 * unexec.h: New file.
ce701a33
PE
3126 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3127 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3128 Depend on unexec.h.
3129 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3130 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3131 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3132 Change as necessary to match prototype in unexec.h.
ce701a33 3133
01f44d5a
PE
3134 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3135 shadowing.
4f63c6bb 3136 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3137
a6670b0b
PE
3138 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3139 Rename locals to avoid shadowing.
3140
cef2010d 3141 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3142 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3143
d4d7173a
PE
3144 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3145
f08b802a
PE
3146 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3147 warning when compiling print.c.
3148
3ddb0639
PE
3149 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3150 instead of using an uninitialized var.
5ad03b97 3151 (font_sort_entities): Mark var as initialized.
3ddb0639 3152
170a2692
PE
3153 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3154
e663c700
PE
3155 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3156 pointers to constants.
89bc529a 3157 (font_parse_fcname): Remove unused vars.
7b81e2d0 3158 (font_delete_unmatched): Now static.
ea838e10 3159 (font_get_spec): Remove; unused.
13a547c6
PE
3160 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3161 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3162 Rename or move locals to avoid shadowing.
e663c700 3163
2a80c887 3164 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3165 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3166
1384fa33 3167 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3168 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3169
8b2c52e9
PE
3170 * alloc.c (mark_backtrace): Move decl from here ...
3171 * lisp.h: ... to here, so that it can be checked.
3172
475545b5 3173 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3174 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3175 (lisp_indirect_variable): Name an expression,
3176 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3177 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3178
b1349114 3179 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3180 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3181 Use const pointer when appropriate.
b1349114 3182
a2928364
PE
3183 * lisp.h (get_system_name, get_operating_system_release):
3184 Move decls here, to check interfaces.
3185 * process.c (get_operating_system_release): Move decl to lisp.h.
3186 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3187 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3188 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3189 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3190 (Fformat_time_string, Fencode_time, Finsert_char):
3191 (Ftranslate_region_internal, Fformat):
3192 Rename or remove local vars to avoid shadowing.
9710023e 3193 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3194
a415e694
PE
3195 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3196 avoid shadowing.
3197
8ef4622d
PE
3198 * lisp.h (eassert): Check that the argument compiles, even if
3199 ENABLE_CHECKING is not defined.
3200
946f9a5b
PE
3201 * data.c (Findirect_variable): Name an expression, to avoid
3202 gcc -Wbad-function-cast warning.
112396d6 3203 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3204 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3205 (Fmake_variable_buffer_local, Fmake_local_variable):
3206 Mark variables as initialized.
52746918 3207 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3208
e5aab7e7 3209 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3210 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3211 Rename locals to avoid shadowing.
dff45157
PE
3212 (mark_stack): Move local variables into the #ifdef region where
3213 they're used.
7bc26fdb
PE
3214 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3215 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3216 needed otherwise.
3217 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3218 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3219 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3220
e5aab7e7
PE
3221 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3222 avoids undefined behavior in theory.
3223
4da60324
PE
3224 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3225
88043301
PE
3226 Use functions, not macros, for up- and down-casing (Bug#8254).
3227 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3228 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3229 to use the following functions instead of these macros.
3230 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3231 EMACS_INT, since callers assume the returned value fits in int.
3232 (upcase1): Likewise, for UPCASE_TABLE.
3233 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3234 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3235 the race-condition problem in the old DOWNCASE.
88043301 3236
19ed5445
PE
3237 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3238 Rename locals to avoid shadowing.
3239 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3240 (regex_compile, re_search_2, re_match_2_internal):
3241 Remove unused local vars.
952db0d7
PE
3242 (FREE_VAR): Rewrite so as not to use empty "else",
3243 which gcc can warn about.
da053e48 3244 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3245 (RETALLOC_IF): Define only if needed.
3246 (WORDCHAR_P): Likewise. This one is never needed, but is used
3247 only in a comment talking about a compiler bug, so put inside
3248 the #if 0 of that comment.
3249 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3250 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3251 Remove; unused.
19ed5445 3252
1f3561e4 3253 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3254 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3255 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3256
ded6f8f7
PE
3257 * search.c (simple_search): Remove unused var.
3258
dbd37a95
PE
3259 * dired.c (compile_pattern): Move decl from here ...
3260 * lisp.h: ... to here, so that it can be checked.
3261 (struct re_registers): New forward decl.
3262
7e47afad
PE
3263 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3264
85f24f61
PE
3265 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3266 All uses changed.
3267 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3268 Rename locals to avoid shadowing.
5671df8f 3269 (Fvertical_motion): Mark locals as initialized.
85f24f61 3270
181aa2be 3271 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3272 (casify_region): Mark local as initialized.
181aa2be 3273
930d429c
PE
3274 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3275
7082eac6
PE
3276 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3277 New macros, so that the caller can use some names other than
3278 gcpro1, gcpro2, etc.
3279 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3280 of the new macros.
3281 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3282 argument, for consistency with GCPRO2_VAR, etc: it is now the
3283 prefix of the variable, not the variable itself. All uses
3284 changed.
38b2c076
PE
3285 * dired.c (directory_files_internal, file_name_completion):
3286 Rename locals to avoid shadowing.
3287
15206ed9
PE
3288 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3289 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3290 dired.c's scmp function, had undefined behavior.
3291 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3292 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3293 * buffer.h: ... to here, because these macros use current_buffer,
3294 and the new implementation with inline functions needs to have
3295 current_buffer in scope now, rather than later when the macros
3296 are used.
3297 (downcase, upcase1): New static inline functions.
3298 (DOWNCASE, UPCASE1): Reimplement using these functions.
3299 This avoids undefined behavior in expressions like
3300 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3301 from race conditions in accessing the global variables
3302 case_temp1 and case_temp2.
3303 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3304 * lisp.h (case_temp1, case_temp2): Remove their decls.
3305 * character.h (ASCII_CHAR_P): Move from here ...
3306 * lisp.h: ... to here, so that the inline functions mentioned
3307 above can use them.
3308
4a6bea26
PE
3309 * dired.c (directory_files_internal_unwind): Now static.
3310
f14b7e14
PE
3311 * fileio.c (file_name_as_directory, directory_file_name):
3312 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3313 Now static.
2893f146
PE
3314 (file_name_as_directory): Use const pointers when appropriate.
3315 (Fexpand_file_name): Likewise. In particular, newdir might
3316 point at constant storage, so make it a const pointer.
fd4ead52 3317 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3318 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3319 signedness issues.
f839df0c
PE
3320 (Fset_file_times, Finsert_file_contents, auto_save_error):
3321 Rename locals to avoid shadowing.
f14b7e14 3322
5716756e 3323 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3324 (Ftry_completion, Fall_completions): Rename or remove locals
3325 to avoid shadowing.
5716756e 3326
b4c3046a
PE
3327 * marker.c (bytepos_to_charpos): Remove; unused.
3328
b45db522
PE
3329 * lisp.h (verify_bytepos, count_markers): New decls,
3330 so that gcc does not warn that these functions aren't declared.
3331
85876d07
PE
3332 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3333 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3334 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3335 (copy_text): Remove unused local var.
85876d07 3336
03d78a21 3337 * filelock.c (within_one_second): Now static.
b3dd38ab 3338 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3339
5df8f01b
PE
3340 * buffer.c (fix_overlays_before): Mark locals as initialized.
3341 (fix_start_end_in_overlays): Likewise. This function should be
3342 simplified by using pointers-to-pointers, but that's a different
3343 matter.
b1d876f1 3344 (switch_to_buffer_1): Now static.
8f54f30a
PE
3345 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3346 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3347
a70072c9 3348 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3349 Fix pointer signedness issue.
edced198
PE
3350 (sys_subshell): Mark local as volatile if checking for lint,
3351 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3352 (MAXPATHLEN): Define only if needed.
a70072c9 3353
a0977c44
PE
3354 * process.c (serial_open, serial_configure): Move decls from here ...
3355 * systty.h: ... to here, so that they can be checked.
3356
a884fdcc
PE
3357 * fns.c (get_random, seed_random): Move extern decls from here ...
3358 * lisp.h: ... to here, so that they can be checked.
3359
604efe86 3360 * sysdep.c (reset_io): Now static.
b8950c94 3361 (wait_for_termination_signal): Remove; unused.
604efe86 3362
38fc62d9
PE
3363 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3364 (copy_keymap_item, append_key, push_text_char_description):
3365 Now static.
1004a21a 3366 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3367 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3368 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3369 (describe_map_tree):
3370 Rename locals to avoid shadowing.
38fc62d9 3371
2f2650da
PE
3372 * keyboard.c: Declare functions static if they are not used elsewhere.
3373 (echo_char, echo_dash, cmd_error, top_level_2):
3374 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3375 (read_char, kbd_buffer_get_event, make_lispy_position):
3376 (make_lispy_event, make_lispy_movement, apply_modifiers):
3377 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3378 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3379 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3380 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3381 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3382
a053e86c 3383 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3384 (mark_kboards): Move decl here ...
3385 * alloc.c (mark_kboards): ... from here.
a053e86c 3386
4752793e
PE
3387 * lisp.h (force_auto_save_soon): New decl.
3388
74f10ca7 3389 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3390 (DEFINE_DUMMY_FUNCTION): New macro.
3391 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3392 Use it.
c03cd23f
PE
3393 (main): Add casts to avoid warnings
3394 if GCC considers string literals to be constants.
74f10ca7 3395
022e70d4
PE
3396 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3397
59d6fe83
PE
3398 * dbusbind.c: Pointer signedness fixes.
3399 (xd_signature, xd_append_arg, xd_initialize):
3400 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3401 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3402 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3403 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3404
78320123
PE
3405 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3406 if GCC considers string literals to be constants.
49cebcca 3407 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3408
35ac2a97
SM
34092011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3410
fb103ca9
SM
3411 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3412 (print_preprocess, print_object): New macro to fix last change.
3413
35ac2a97
SM
3414 * print.c (print_preprocess): Don't forget font objects.
3415
62973b41
JB
34162011-03-16 Juanma Barranquero <lekktu@gmail.com>
3417
3418 * emacs.c (USAGE3): Doc fixes.
3419
0e48bb22
AS
34202011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3421
3422 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3423 structure.
3424
7684e57b
JB
34252011-03-14 Juanma Barranquero <lekktu@gmail.com>
3426
3427 * lisp.h (VWindow_system, Qfile_name_history):
3428 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3429 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3430 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3431
3432 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3433 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3434
3435 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3436 * w32console.c (detect_input_pending, read_input_pending)
3437 (encode_terminal_code):
3438 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3439 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3440 (w32_system_caret_y, Qfile_name_history):
3441 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3442 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3443 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3444 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3445 * w32proc.c (Qlocal, report_file_error):
3446 * w32term.c (Vwindow_system, updating_frame):
3447 * w32uniscribe.c (initialized, uniscribe_font_driver):
3448 Remove unneeded extern declarations.
3449
2aa46d6c
CY
34502011-03-14 Chong Yidong <cyd@stupidchicken.com>
3451
c96bbc66 3452 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3453
cffc6f3b
CY
34542011-03-13 Chong Yidong <cyd@stupidchicken.com>
3455
3456 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3457 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3458 These macros can no longer be used for assignment.
3459
44f230aa
SM
3460 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3461 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3462 (record_buffer_markers, fetch_buffer_markers): New functions for
3463 recording and fetching special buffer markers.
3464 (set_buffer_internal_1, set_buffer_temp): Use them.
3465
3466 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3467
3468 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3469
3470 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3471 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3472
3473 * xdisp.c (hscroll_window_tree):
3474 (reconsider_clip_changes): Use PT instead of BUF_PT.
3475
d251f04b
EZ
34762011-03-13 Eli Zaretskii <eliz@gnu.org>
3477
3478 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3479 $(EMACS_ROOT)/lib/intprops.h.
3480
f0c77cd1
PE
34812011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3482
3eca4629
PE
3483 Fix more problems found by GCC 4.5.2's static checks.
3484
7c86ee98
PE
3485 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3486 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3487 (xg_free_frame_widgets): Make it clear that a local variable is
3488 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3489 (gdk_window_get_screen): Make it clear that this macro is needed
3490 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3491 (int_gtk_range_get_value): New function, which avoids a diagnostic
3492 from gcc -Wbad-function-cast.
3493 (xg_set_toolkit_scroll_bar_thumb): Use it.
3494 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3495 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3496 (get_utf8_string, xg_get_file_with_chooser):
3497 Rename locals to avoid shadowing.
3498 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3499
41729b81
PE
3500 * xgselect.c (xg_select): Remove unused var.
3501
f0c77cd1
PE
3502 * image.c (four_corners_best): Mark locals as initialized.
3503 (gif_load): Initialize transparent_p to zero (Bug#8238).
3504 Mark another local as initialized.
ec6cf4c6 3505 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3506
ce0ad53d 3507 * image.c (clear_image_cache): Now static.
d5d5a617 3508 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3509 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3510 (x_edge_detection): Remove unnecessary cast that
3511 gcc -Wbad-function-cast diagnoses.
2037898d 3512 (gif_load): Fix pointer signedness.
6ae141d6
PE
3513 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3514 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3515
33383987 35162011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3517
d32df629
PE
3518 Improve quality of tests for time stamp overflow.
3519 For example, without this patch (encode-time 0 0 0 1 1
3520 1152921504606846976) returns the obviously-bogus value (-948597
3521 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3522 reports time overflow. See
3523 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3524 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3525 * editfns.c: Include limits.h and intprops.h.
3526 (TIME_T_MIN, TIME_T_MAX): New macros.
3527 (time_overflow): Move earlier, to before first use.
3528 (hi_time, lo_time): New functions, for an accurate test for
3529 out-of-range times.
3530 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3531 (Fget_internal_run_time): Don't assume time_t fits in int.
3532 (make_time): Use list2 instead of Fcons twice.
3533 (Fdecode_time): More accurate test for out-of-range times.
3534 (check_tm_member): New function.
3535 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3536 (lisp_time_argument): Don't rely on undefined left-shift and
3537 right-shift behavior when checking for time stamp overflow.
8be6f318 3538
fe31d94c
PE
3539 * editfns.c (time_overflow): New function, refactoring common code.
3540 (Fformat_time_string, Fdecode_time, Fencode_time):
3541 (Fcurrent_time_string): Use it.
3542
8be6f318
PE
3543 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3544 * dired.c (make_time): Move to ...
3545 * editfns.c (make_time): ... here.
3546 * systime.h: Note the move.
3547
09d9db2c 35482011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3549
126bc0dc
YM
3550 * fringe.c (update_window_fringes): Remove unused variables.
3551
c47cbdfd
YM
3552 * unexmacosx.c (copy_data_segment): Also copy __got section.
3553 (Bug#8223)
3554
7ac80be9
EZ
35552011-03-12 Eli Zaretskii <eliz@gnu.org>
3556
c96bbc66 3557 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3558 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3559 Constify `char *' arguments and their references according to
3560 prototypes in tparam.h.
3561
ecb0f94d 3562 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3563
7ac80be9
EZ
3564 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3565 Adapt all references accordingly.
3566
3567 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3568
ef1fd07e
TT
35692011-03-11 Tom Tromey <tromey@redhat.com>
3570
3571 * buffer.c (syms_of_buffer): Remove obsolete comment.
3572
7ef4b50c
EZ
35732011-03-11 Eli Zaretskii <eliz@gnu.org>
3574
3575 * termhooks.h (encode_terminal_code): Declare prototype.
3576
3577 * msdos.c (encode_terminal_code): Don't declare prototype.
3578
3579 * term.c (encode_terminal_code): Now external again, used by
3580 w32console.c and msdos.c.
3581
44f230aa
SM
3582 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3583 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3584
4b1ec863 35852011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3586
1714f52b 3587 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3588
4b1ec863
PE
3589 * fringe.c (update_window_fringes): Mark locals as initialized
3590 (Bug#8227).
3591 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3592
524c7aa6
PE
3593 * alloc.c (mark_fringe_data): Move decl from here ...
3594 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3595 to check its interface.
3596 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3597
a5c0af81 3598 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3599 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3600 (fontset_font): Mark local as initialized.
a9a06e0b 3601 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3602
b4716021
PE
3603 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3604
811e9bac 3605 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3606 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3607 (x_own_selection, Fx_disown_selection_internal): Rename locals
3608 to avoid shadowing.
3609 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3610
7e3ab302
PE
3611 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3612 so that the caller can use some name other than gcpro1.
3613 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3614 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3615 (Fx_backspace_delete_keys_p):
3616 Use them to avoid shadowing, and rename vars to avoid shadowing.
3617 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3618 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3619 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3620 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3621 Remove unused locals.
7e3ab302
PE
3622 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3623 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3624 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3625 macros.
f78faa98 3626
e2b13473
PE
3627 * xterm.h (x_mouse_leave): New decl.
3628
77f23912
PE
3629 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3630 Remove unused functions.
cdf4ba58
PE
3631 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3632 (x_calc_absolute_position): Now static.
7411c686 3633 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3634 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3635 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3636 unless they are used.
38d0b34a
PE
3637 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3638 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3639 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3640 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3641 (x_error_catcher, x_connection_closed, x_error_handler):
3642 (x_error_quitter, xembed_send_message, x_iconify_frame):
3643 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3644 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3645 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3646
44f230aa
SM
3647 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3648 Rename or move locals to avoid shadowing.
6b463e58 3649 (tty_defined_color, merge_face_heights): Now static.
5967d051 3650 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3651 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3652 does not deduce is never used uninitialized.
73719eba
PE
3653 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3654 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3655
426994c3 3656 * terminal.c (store_terminal_param): Now static.
5489860b 3657
032f1620 3658 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3659 (set_frame_menubar): Remove unused local.
d4323972 3660 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3661 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3662 since they might point to immutable storage.
281585b0
PE
3663 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3664 since it's unused otherwise.
032f1620 3665
367c19e5 3666 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3667 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3668 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3669 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3670 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3671 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3672 does not deduce are never used uninitialized.
70739cbe 3673
07b48fa9
PE
3674 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3675
8868a238 3676 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3677 * window.c (window_loop, size_window):
3678 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3679
7e5cf297 3680 * window.c (display_buffer): Now static.
d6550a9f
PE
3681 (size_window): Mark variables that gcc -Wuninitialized
3682 does not deduce are never used uninitialized.
a586633d
PE
3683 * window.h (check_all_windows): New decl, to forestall
3684 gcc -Wmissing-prototypes diagnostic.
5b555da1 3685 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3686
f6095868
PE
3687 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3688 shadowing.
3689 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3690 Include <limits.h>.
3691 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3692 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3693 (load_charset_map): Mark variables that gcc -Wuninitialized
3694 does not deduce are never used uninitialized.
53df7c11 3695 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3696
f38b440c
PE
3697 * coding.c (coding_set_source, coding_set_destination):
3698 Use "else { /* comment */ }" rather than "else /* comment */;"
3699 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3700 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3701 a block, when the outer 'i' will do.
3702 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3703 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3704 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3705 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3706 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3707 Rename locals to avoid shadowing.
3708 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3709 * coding.c (emacs_mule_char, encode_invocation_designation):
3710 Now static, since they're not used elsewhere.
413bb2db 3711 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3712 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3713 (decode_coding_emacs_mule): Mark variables that gcc
3714 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3715 (detect_coding_iso_2022): Initialize a local variable that might
3716 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3717 this initialization is needed. (Bug#8211)
5f58e762
PE
3718 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3719 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3720 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3721 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3722 Remove unused macros.
f38b440c 3723
232b38b9 3724 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3725 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3726 * character.c (string_count_byte8): Likewise.
232b38b9 3727
fb90da1b
PE
3728 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3729 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3730
fb93dbc2
PE
3731 * chartab.c (copy_sub_char_table): Now static, since it's not used
3732 elsewhere.
5c156ace
PE
3733 (sub_char_table_ref_and_range, char_table_ref_and_range):
3734 Rename locals to avoid shadowing.
bbcd0949 3735 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3736
7d3b3862 3737 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3738 (BIDI_BOB): Remove unused macro.
7d3b3862 3739
6be7d3da
PE
3740 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3741 deduce are never used uninitialized.
c2ed9c8b 3742 * term.c (encode_terminal_code): Likewise.
6be7d3da 3743
75f8807f 3744 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3745
50938595
PE
3746 * tparam.h: New file.
3747 * term.c, tparam.h: Include it.
3748 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3749 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3750 Move these decls to tparam.h, and make them agree with what
3751 is actually in tparam.c. The previous trick of using incompatible
3752 decls in different modules does not conform to the C standard.
3753 All callers of tparam changed to use tparam's actual API.
3754 * tparam.c (tparam1, tparam, tgoto):
3755 Use const pointers where appropriate.
3756
fbceeba2
PE
3757 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3758 * cm.h (struct cm): Likewise.
3759 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3760 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3761 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3762 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3763 (turn_on_face, init_tty): Likewise.
3764 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3765
7f3f1250
PE
3766 * term.c (term_mouse_position): Rename local to avoid shadowing.
3767
e6ca6543
PE
3768 * alloc.c (mark_ttys): Move decl from here ...
3769 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3770
c40f8d15
AS
37712011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3772
3773 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3774
cfe0661d
JB
37752011-03-09 Juanma Barranquero <lekktu@gmail.com>
3776
3777 * search.c (compile_pattern_1): Remove argument regp, unused since
3778 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3779 (compile_pattern): Don't pass it.
3780
0afb4571
J
37812011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3782
3783 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3784 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3785 for ! HAVE_GTK3.
3786 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3787
3788 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3789
3790 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3791 gdk_window_get_screen, gdk_window_get_geometry,
3792 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3793 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3794 (xg_get_pixbuf_from_pixmap): New function.
3795 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3796 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3797 Call xg_get_pixbuf_from_pixmap instead of
3798 gdk_pixbuf_get_from_drawable.
3799 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3800 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3801 (xg_check_special_colors): Use GtkStyleContext and its functions
3802 for HAVE_GTK3.
3803 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3804 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3805 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3806 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3807 Call gtk_widget_get_preferred_size.
0afb4571
J
3808 (xg_frame_resized): gdk_window_get_geometry only takes 5
3809 parameters.
44f230aa
SM
3810 (xg_win_to_widget, xg_event_is_for_menubar):
3811 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3812 (xg_set_widget_bg): New function.
3813 (delete_cb): New function.
895009e1 3814 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3815 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3816 (xg_set_background_color): Call xg_set_widget_bg.
3817 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3818 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3819 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3820 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3821 if ! HAVE_GTK3.
3822 (update_frame_tool_bar): Call gtk_widget_hide.
3823 (xg_initialize): Use GDK_KEY_g.
3824
3825 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3826 if ! HAVE_GTK3
3827 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3828
3829 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3830 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3831 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3832
1c2cc4ef
JB
38332011-03-08 Juanma Barranquero <lekktu@gmail.com>
3834
3835 * w32xfns.c (select_palette): Check success of RealizePalette against
3836 GDI_ERROR, not zero.
3837
33383987 3838See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3839
3840;; Local Variables:
3841;; coding: utf-8
aac0c6e3
MR
3842;; End:
3843
33383987 3844 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3845
3846 This file is part of GNU Emacs.
3847
3848 GNU Emacs is free software: you can redistribute it and/or modify
3849 it under the terms of the GNU General Public License as published by
3850 the Free Software Foundation, either version 3 of the License, or
3851 (at your option) any later version.
3852
3853 GNU Emacs is distributed in the hope that it will be useful,
3854 but WITHOUT ANY WARRANTY; without even the implied warranty of
3855 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3856 GNU General Public License for more details.
3857
3858 You should have received a copy of the GNU General Public License
3859 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.