Fixes: debbugs:8806
[bpt/emacs.git] / src / ChangeLog
1 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2
3 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4 format. (Bug#8806)
5
6 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7
8 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9 before statements.
10
11 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12
13 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14
15 * gtkutil.h: Declare xg_get_default_scrollbar_width.
16
17 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
18 min width by calling x_set_scroll_bar_default_width (Bug#8505).
19
20 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
21
22 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
23
24 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
25
26 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
27 (x_clipboard_manager_save): Add return value.
28 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
29 error handlers.
30 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
31 Obey Vx_select_enable_clipboard_manager. Catch errors in
32 x_clipboard_manager_save (Bug#8779).
33 (Vx_select_enable_clipboard_manager): New variable.
34 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
35
36 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
37
38 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
39
40 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
41
42 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
43 in the current matrix if keep_current_p is non-zero.
44
45 2011-06-04 Eli Zaretskii <eliz@gnu.org>
46
47 * bidi.c (bidi_level_of_next_char): Fix last change.
48
49 2011-06-03 Eli Zaretskii <eliz@gnu.org>
50
51 Support bidi reordering of text covered by display properties.
52
53 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
54 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
55 (bidi_cache_search, bidi_cache_iterator_state)
56 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
57 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
58 character positions inside a run of characters covered by a
59 display string.
60 (bidi_paragraph_init, bidi_resolve_explicit_1)
61 (bidi_level_of_next_char): Call bidi_fetch_char and
62 bidi_fetch_char_advance instead of FETCH_CHAR and
63 FETCH_CHAR_ADVANCE.
64 (bidi_init_it): Initialize new members.
65 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
66 definitions.
67 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
68 instead of using explicit *_CHAR codes.
69 (bidi_resolve_explicit, bidi_resolve_weak): Use
70 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
71 bidirectional text is supported only in multibyte buffers.
72 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
73 it to initialize the frame_window_p member of struct bidi_it.
74 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
75 (bidi_resolve_explicit, bidi_resolve_weak)
76 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
77 bidi_it->nchars is non-positive.
78 (bidi_level_of_next_char): Don't try to lookup the cache for the
79 next/previous character if nothing is cached there yet, or if we
80 were just reseat()'ed to a new position.
81
82 * xdisp.c (set_cursor_from_row): Set start and stop points
83 according to the row's direction when priming the loop that looks
84 for the glyph on which to display cursor.
85 (single_display_spec_intangible_p): Function deleted.
86 (display_prop_intangible_p): Reimplement to call
87 handle_display_spec instead of single_display_spec_intangible_p.
88 Accept 3 additional arguments needed by handle_display_spec. This
89 fixes incorrect cursor motion across display property with complex
90 values: lists, `(when COND...)' forms, etc.
91 (single_display_spec_string_p): Support property values that are
92 lists with the argument STRING its top-level element.
93 (display_prop_string_p): Fix the condition for processing a
94 property that is a list to be consistent with handle_display_spec.
95 (handle_display_spec): New function, refactored from the
96 last portion of handle_display_prop.
97 (compute_display_string_pos): Accept additional argument
98 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
99 value of a `display' property is a "replacing spec".
100 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
101 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
102 the display property, but just return a value indicating whether
103 the display property will replace the characters it covers.
104 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
105 frame_window_p members of struct bidi_it.
106 (compute_display_string_pos, compute_display_string_end): New
107 functions.
108 (push_it): Accept second argument POSITION, where pop_it should
109 jump to continue iteration.
110 (reseat_1): Initialize bidi_it.disp_pos.
111
112 * keyboard.c (adjust_point_for_property): Adjust the call to
113 display_prop_intangible_p to its new signature.
114
115 * dispextern.h (struct bidi_it): New member frame_window_p.
116 (bidi_init_it): Update prototypes.
117 (display_prop_intangible_p): Update prototype.
118 (compute_display_string_pos, compute_display_string_end): Declare
119 prototypes.
120 (struct bidi_it): New members nchars and disp_pos. ch_len is now
121 EMACS_INT.
122
123 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
124
125 Malloc failure behavior now depends on size of allocation.
126 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
127 * lisp.h: Change signatures accordingly.
128 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
129 All callers changed. (Bug#8762)
130
131 * gnutls.c: Use Emacs's memory allocators.
132 Without this change, the gnutls library would invoke malloc etc.
133 directly, which causes problems on non-SYNC_INPUT hosts, and which
134 runs afoul of improving memory_full behavior. (Bug#8761)
135 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
136 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
137 xfree instead of the default malloc, realloc, free.
138 (Fgnutls_boot): No need to check for memory allocation failure,
139 since xmalloc does that for us.
140
141 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
142 * category.c (hash_get_category_set):
143 * ccl.c (ccl_driver):
144 * charset.c (Fdefine_charset_internal):
145 * charset.h (struct charset.hash_index):
146 * composite.c (get_composition_id, gstring_lookup_cache)
147 (composition_gstring_put_cache):
148 * composite.h (struct composition.hash_index):
149 * dispextern.h (struct image.hash):
150 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
151 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
152 (hashfn_equal, hashfn_user_defined, make_hash_table)
153 (maybe_resize_hash_table, hash_lookup, hash_put)
154 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
155 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
156 (Fsxhash, Fgethash, Fputhash, Fmaphash):
157 * image.c (make_image, search_image_cache, lookup_image)
158 (xpm_put_color_table_h):
159 * lisp.h (struct Lisp_Hash_Table):
160 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
161 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
162 for hashes and hash indexes, instead of 'unsigned' and 'int'.
163 * alloc.c (allocate_vectorlike):
164 Check for overflow in vector size calculations.
165 * ccl.c (ccl_driver):
166 Check for overflow when converting EMACS_INT to int.
167 * fns.c, image.c: Remove unnecessary static decls that would otherwise
168 need to be updated by these changes.
169 * fns.c (make_hash_table, maybe_resize_hash_table):
170 Check for integer overflow with large hash tables.
171 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
172 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
173 (SXHASH_REDUCE): New macro.
174 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
175 Use it instead of discarding useful hash info with large hash values.
176 (sxhash_float): New function.
177 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
178 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
179 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
180 Rewrite to use FIXNUM_BITS, as this simplifies things.
181 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
182 Adjust signatures to match updated version of code.
183 (consing_since_gc): Now EMACS_INT, since a single hash table can
184 use more than INT_MAX bytes.
185
186 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
187
188 Make it possible to build with GCC-4.6+ -O2 -flto.
189
190 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
191
192 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
193
194 * minibuf.c (get_minibuffer, read_minibuf_unwind):
195 Call minibuffer-inactive-mode.
196
197 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
198
199 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
200 Update dependencies.
201
202 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
203
204 * data.c (init_data): Remove code for UTS, this system is not
205 supported anymore.
206
207 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
208
209 Don't force ./temacs to start in terminal mode.
210
211 * frame.c (make_initial_frame): Initialize faces in all cases, not
212 only when CANNOT_DUMP is defined.
213 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
214
215 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
216
217 * dispnew.c (add_window_display_history): Use const for the string
218 pointer. Remove declaration, not needed.
219
220 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
221
222 Use 'inline', not 'INLINE'.
223 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
224 * alloc.c, fontset.c (INLINE): Remove.
225 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
226 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
227 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
228 * gmalloc.c (register_heapinfo): Use inline unconditionally.
229 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
230
231 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
232
233 Make it possible to run ./temacs.
234
235 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
236 syms_of_callproc does the same thing. Remove test for
237 "initialized", do it in the caller.
238 * emacs.c (main): Avoid calling set_initial_environment when dumping.
239
240 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
241
242 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
243 (read_minibuf): Use get_minibuffer.
244 (syms_of_minibuf): Use DEFSYM.
245 (Qmetadata): New var.
246 * data.c (Qbuffer): Don't make it static.
247 (syms_of_data): Use DEFSYM.
248
249 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
250
251 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
252 (CCL_CODE_MIN): New macro.
253
254 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
255
256 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
257
258 * eval.c (Qdebug): Now static.
259 * lisp.h (Qdebug): Remove decl. This reverts a part of the
260 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
261 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
262
263 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
264
265 * image.c: Various fixes to ImageMagick code comments.
266 (Fimagemagick_types): Doc fix.
267
268 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
269
270 Minor fixes prompted by GCC 4.6.0 warnings.
271
272 * xselect.c (converted_selections, conversion_fail_tag): Now static.
273
274 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
275 (x_clipboard_manager_save_all): Move extern decl to ...
276 * xterm.h: ... here, so that it can be checked for consistency.
277
278 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
279
280 * xselect.c (x_clipboard_manager_save_frame)
281 (x_clipboard_manager_save_all): New functions.
282 (Fx_clipboard_manager_save): Lisp function deleted.
283
284 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
285 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
286
287 * xterm.h: Update prototype.
288
289 2011-05-28 William Xu <william.xwl@gmail.com>
290
291 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
292 exiting (Bug#8239).
293
294 2011-05-28 Jim Meyering <meyering@redhat.com>
295
296 Avoid a sign-extension bug in crypto_hash_function.
297 * fns.c (to_uchar): Define.
298 (crypto_hash_function): Use it to convert some newly-signed
299 variables to unsigned, to avoid sign-extension bugs. For example,
300 without this change, (md5 "truc") would evaluate to
301 45723a2aff78ff4fff7fff1114760e62 rather than the expected
302 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
303 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
304
305 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
306
307 Integer overflow fixes.
308
309 * dbusbind.c: Serial number integer overflow fixes.
310 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
311 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
312 to hold a serial number that is too large for a fixnum.
313 (Fdbus_method_return_internal, Fdbus_method_error_internal):
314 Check for serial numbers out of range. Decode any serial number
315 that was so large that it became a float. (Bug#8722)
316
317 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
318 (Fdbus_call_method, Fdbus_call_method_asynchronously):
319 Use XFASTINT rather than XUINT when numbers are nonnegative.
320 (xd_append_arg, Fdbus_method_return_internal):
321 (Fdbus_method_error_internal): Likewise. Also, for unsigned
322 arguments, check that Lisp number is nonnegative, rather than
323 silently wrapping negative numbers around. (Bug#8722)
324 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
325 (Bug#8722)
326
327 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
328
329 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
330
331 ccl: add integer overflow checks
332 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
333 (IN_INT_RANGE): New macros.
334 (ccl_driver): Use them to check for integer overflow when
335 decoding a CCL program. Many of the new checks are whether XINT (x)
336 fits in int; it doesn't always, on 64-bit hosts. The new version
337 doesn't catch all possible integer overflows, but it's an
338 improvement. (Bug#8719)
339
340 * alloc.c (make_event_array): Use XINT, not XUINT.
341 There's no need for unsigned here.
342
343 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
344 This follows up to the 2011-05-06 change that substituted uintptr_t
345 for EMACS_INT. This case wasn't caught back then.
346
347 Rework Fformat to avoid integer overflow issues.
348 * editfns.c: Include <float.h> unconditionally, as it's everywhere
349 now (part of C89). Include <verify.h>.
350 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
351 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
352 (Fformat): Avoid the prepass trying to compute sizes; it was only
353 approximate and thus did not catch overflow reliably. Instead, walk
354 through the format just once, formatting and computing sizes as we go,
355 checking for integer overflow at every step, and allocating a larger
356 buffer as needed. Keep track separately whether the format is
357 multibyte. Keep only the most-recently calculated precision, rather
358 than them all. Record whether each argument has been converted to
359 string. Use EMACS_INT, not int, for byte and char and arg counts.
360 Support field widths and precisions larger than INT_MAX. Avoid
361 sprintf's undefined behavior with conversion specifications such as %#d
362 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
363 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
364 formatting out-of-range floating point numbers with int
365 formats. (Bug#8668)
366
367 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
368
369 * data.c: Avoid integer truncation in expressions involving floats.
370 * data.c: Include <intprops.h>.
371 (arith_driver): When there's an integer overflow in an expression
372 involving floating point, convert the integers to floating point
373 so that the resulting value does not suffer from catastrophic
374 integer truncation. For example, on a 64-bit host (* 4
375 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
376 Do not rely on undefined behavior after integer overflow.
377
378 merge count_size_as_multibyte, parse_str_to_multibyte
379 * character.c, character.h (count_size_as_multibyte):
380 Rename from parse_str_to_multibyte; all uses changed.
381 Check for integer overflow.
382 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
383 since it's now a duplicate of the other. This is more of
384 a character than a buffer op, so better that it's in character.c.
385 * fns.c, print.c: Adjust to above changes.
386
387 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
388
389 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
390
391 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
392
393 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
394 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
395 (x_clipboard_manager_save): Now static.
396 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
397
398 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
399 (crypto_hash_function): Now static.
400 Fix pointer signedness problems. Avoid unnecessary initializations.
401
402 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
403
404 * termhooks.h (Vselection_alist): Make it terminal-local.
405
406 * terminal.c (create_terminal): Initialize it.
407
408 * xselect.c: Support for clipboard managers.
409 (Vselection_alist): Move to termhooks.h as terminal-local var.
410 (LOCAL_SELECTION): New macro.
411 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
412 (symbol_to_x_atom): Remove gratuitous arg.
413 (x_handle_selection_request, lisp_data_to_selection_data)
414 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
415 (x_own_selection, x_get_local_selection, x_convert_selection):
416 New arg, specifying work frame. Use terminal-local Vselection_alist.
417 (some_frame_on_display): Delete unused function.
418 (Fx_own_selection_internal, Fx_get_selection_internal)
419 (Fx_disown_selection_internal, Fx_selection_owner_p)
420 (Fx_selection_exists_p): New optional frame arg.
421 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
422 (x_handle_selection_clear): Don't treat other terminals with the
423 same keyboard specially. Use the terminal-local Vselection_alist.
424 (x_clear_frame_selections): Use Frun_hook_with_args.
425
426 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
427
428 * xterm.h: Add support for those atoms.
429
430 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
431
432 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
433 (converted_selections, conversion_fail_tag): New global variables.
434 (x_selection_request_lisp_error): Free the above.
435 (x_get_local_selection): Remove unnecessary code.
436 (x_reply_selection_request): Args changed; handle arbitrary array
437 of converted selections stored in converted_selections.
438 Separate the XChangeProperty and SelectionNotify steps.
439 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
440 (x_convert_selection): New function.
441 (x_handle_selection_event): Simplify.
442 (x_get_foreign_selection): Don't ignore incoming requests while
443 waiting for an answer; this will fail when we implement
444 SAVE_TARGETS, and seems unnecessary anyway.
445 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
446 (Vx_sent_selection_functions): Doc fix.
447
448 2011-05-26 Leo Liu <sdl.web@gmail.com>
449
450 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
451
452 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
453
454 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
455
456 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
457 for fringe update if it has periodic bitmap.
458 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
459 and fringe_bitmap_periodic_p.
460
461 * fringe.c (get_fringe_bitmap_data): New function.
462 (draw_fringe_bitmap_1, update_window_fringes): Use it.
463 (update_window_fringes): Record periodicity of fringe bitmap in glyph
464 row. Mark glyph row for fringe update if periodicity changed.
465
466 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
467 for fringe update unless it has periodic bitmap.
468
469 2011-05-25 Kenichi Handa <handa@m17n.org>
470
471 * xdisp.c (get_next_display_element): Set correct it->face_id for
472 a static composition.
473
474 2011-05-24 Leo Liu <sdl.web@gmail.com>
475
476 * deps.mk (fns.o):
477 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
478
479 * fns.c (crypto_hash_function, Fsha1): New function.
480 (Fmd5): Use crypto_hash_function.
481 (syms_of_fns): Add Ssha1.
482
483 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
484
485 * gnutls.c: Remove unused macros.
486 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
487 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
488 Remove macros that are defined and never used.
489 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
490
491 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
492
493 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
494 (Fx_get_selection_internal): Minor cleanup.
495 (Fx_own_selection_internal): Rename arguments for consistency with
496 select.el.
497
498 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
499
500 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
501
502 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
503
504 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
505
506 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
507
508 * dispnew.c (scrolling_window): Don't exclude the case that the
509 last enabled row in the desired matrix touches the bottom boundary.
510
511 2011-05-21 Glenn Morris <rgm@gnu.org>
512
513 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
514 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
515 and add some more files.
516
517 2011-05-20 Eli Zaretskii <eliz@gnu.org>
518
519 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
520 report_file_error introduced by the change from 2011-05-07.
521
522 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
523
524 * systime.h (Time): Define only if emacs is defined.
525 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
526 where the include path doesn't have X11/X.h by default. See
527 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
528
529 2011-05-20 Kenichi Handa <handa@m17n.org>
530
531 * composite.c (find_automatic_composition): Fix previous change.
532
533 2011-05-20 Glenn Morris <rgm@gnu.org>
534
535 * lisp.mk: New file, split from Makefile.in.
536 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
537 (shortlisp): Remove.
538 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
539
540 2011-05-19 Glenn Morris <rgm@gnu.org>
541
542 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
543 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
544 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
545 (lisp): Set the order to that of loadup.el.
546 (shortlisp): Make it a copy of $lisp.
547 (SOME_MACHINE_LISP): Remove.
548 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
549 Use just $shortlisp, not $SOME_MACHINE_LISP too.
550
551 2011-05-18 Kenichi Handa <handa@m17n.org>
552
553 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
554 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
555 (find_automatic_composition): Mostly rewrite for efficiency.
556
557 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
558
559 * makefile.w32-in: Update dependencies.
560
561 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
562
563 * menu.c: Include limits.h (fixes the MS-Windows build broken by
564 revision 104625).
565
566 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
567
568 Fix some integer overflow issues, such as string length overflow.
569
570 * insdel.c (count_size_as_multibyte): Check for string overflow.
571
572 * character.c (lisp_string_width): Check for string overflow.
573 Use EMACS_INT, not int, for string indexes and lengths; in
574 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
575 the resulting string length overflows an EMACS_INT; instead,
576 report a string overflow if no precision given. When checking for
577 precision exhaustion, use a check that cannot possibly have
578 integer overflow. (Bug#8675)
579 * character.h (lisp_string_width): Adjust to new signature.
580
581 * alloc.c (string_overflow): New function.
582 (Fmake_string): Use it. This doesn't change behavior, but saves
583 a few bytes and will simplify future changes.
584 * character.c (string_escape_byte8): Likewise.
585 * lisp.h (string_overflow): New decl.
586
587 Fixups, following up to the user-interface timestamp change.
588 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
589 for UI timestamps, instead of unsigned long.
590 * msdos.c (mouse_get_pos): Likewise.
591 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
592 * w32gui.h (Time): Define by including "systime.h" rather than by
593 declaring it ourselves. (Bug#8664)
594
595 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
596 * image.c (clear_image_cache): Likewise.
597
598 * term.c (term_mouse_position): Don't assume time_t wraparound.
599
600 Be more systematic about user-interface timestamps.
601 Before, the code sometimes used 'Time', sometimes 'unsigned long',
602 and sometimes 'EMACS_UINT', to represent these timestamps.
603 This change causes it to use 'Time' uniformly, as that's what X uses.
604 This makes the code easier to follow, and makes it easier to catch
605 integer overflow bugs such as Bug#8664.
606 * frame.c (Fmouse_position, Fmouse_pixel_position):
607 Use Time, not unsigned long, for user-interface timestamps.
608 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
609 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
610 * keyboard.h (last_event_timestamp): Likewise.
611 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
612 * menu.h (xmenu_show): Likewise.
613 * term.c (term_mouse_position): Likewise.
614 * termhooks.h (struct input_event.timestamp): Likewise.
615 (struct terminal.mouse_position_hook): Likewise.
616 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
617 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
618 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
619 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
620 what it was before.
621 * menu.h, termhooks.h: Include "systime.h", for Time.
622
623 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
624 Don't assume that the difference between two unsigned long values
625 can fit into an integer. At this point, we know button_down_time
626 <= event->timestamp, so the difference must be nonnegative, so
627 there's no need to cast the result if double-click-time is
628 nonnegative, as it should be; check that it's nonnegative, just in
629 case. This bug is triggered when events are more than 2**31 ms
630 apart (about 25 days). (Bug#8664)
631
632 * xselect.c (last_event_timestamp): Remove duplicate decl.
633 (x_own_selection): Remove needless cast to unsigned long.
634
635 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
636 that always fit in int. Use a sentinel instead of a counter, to
637 avoid a temp and to allay GCC's concerns about possible int overflow.
638 * frame.h (struct frame): Use int for menu_bar_items_used
639 instead of EMACS_INT, since it always fits in int.
640
641 * menu.c (grow_menu_items): Check for int overflow.
642
643 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
644
645 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
646 Before, the code was not consistent. These values cannot exceed
647 2**31 - 1 so there's no need to make them unsigned.
648 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
649 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
650 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
651 as modifiers.
652 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
653
654 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
655 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
656 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
657 presumably because the widths might not match.
658
659 * window.c (size_window): Avoid needless test at loop start.
660
661 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
662
663 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
664
665 2011-05-12 Drew Adams <drew.adams@oracle.com>
666
667 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
668
669 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
670
671 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
672 `width' to `bar_area_x' and `bar_area_width', respectively.
673 (x_scroll_run): Take account of fringe background extension.
674
675 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
676 Rename local vars `left' and `width' to `bar_area_x' and
677 `bar_area_width', respectively.
678 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
679 background extension.
680
681 2011-05-10 Jim Meyering <meyering@redhat.com>
682
683 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
684
685 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
686
687 * image.c (Finit_image_library): Return t for built-in image types,
688 like pbm and xbm. (Bug#8640)
689
690 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
691
692 * w32menu.c (set_frame_menubar): Fix submenu allocation.
693
694 2011-05-07 Eli Zaretskii <eliz@gnu.org>
695
696 * w32console.c (Fset_screen_color): Doc fix.
697 (Fget_screen_color): New function.
698 (syms_of_ntterm): Defsubr it.
699
700 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
701 unlink the temporary file if Fcall_process didn't create it in the
702 first place.
703 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
704 child process will be redirected to a file specified with `:file'.
705 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
706 cue to call_process_cleanup not to close that handle.
707
708 2011-05-07 Ben Key <bkey76@gmail.com>
709
710 * makefile.w32-in: The bootstrap-temacs rule now makes use of
711 one of two shell specific rules, either bootstrap-temacs-CMD or
712 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
713 to the previous implementation of the bootstrap-temacs rule.
714 The bootstrap-temacs-CMD rule is similar to the previous
715 implementation of the bootstrap-temacs rule except that it
716 makes use of the ESC_CFLAGS variable instead of the CFLAGS
717 variable.
718
719 These changes, along with some changes to nt/configure.bat,
720 nt/gmake.defs, and nt/nmake.defs, are required to extend my
721 earlier fix to add support for --cflags and --ldflags options
722 that include quotes so that it works whether make uses cmd or
723 sh as the shell.
724
725 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
726
727 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
728 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
729 is a constant.
730 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
731 a string. Handle both cases.
732 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
733 (Fdbus_register_method): Use Qinvalid_function.
734
735 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
736
737 * makefile.w32-in: Update dependencies.
738 (LISP_H): Add inttypes.h and stdin.h.
739 (PROCESS_H): Add unistd.h.
740
741 2011-05-06 Eli Zaretskii <eliz@gnu.org>
742
743 * lread.c: Include limits.h (fixes the MS-Windows build broken by
744 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
745
746 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
747
748 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
749
750 * term.c (vfatal): Remove stray call to va_end.
751 It's not needed and the C Standard doesn't allow it here anyway.
752
753 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
754 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
755
756 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
757 bytes.
758
759 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
760
761 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
762
763 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
764
765 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
766
767 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
768
769 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
770 * charset.c (Fdefine_charset_internal): Don't initialize
771 charset.code_space[15]. The value was garbage, on hosts with
772 32-bit int (Bug#8600).
773
774 * lread.c (read_integer): Be more consistent with string-to-number.
775 Use string_to_number to do the actual conversion; this avoids
776 rounding errors and fixes some other screwups. Without this fix,
777 for example, #x1fffffffffffffff was misread as -2305843009213693952.
778 (digit_to_number): Move earlier, for benefit of read_integer.
779 Return -1 if the digit is out of range for the base, -2 if it is
780 not a digit in any supported base. (Bug#8602)
781
782 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
783
784 * dispnew.c (scrolling_window): Return 1 if we scrolled,
785 to match comment at start of function. This also removes a
786 GCC warning about overflow in a 32+64-bit port.
787
788 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
789
790 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
791 Reported by Stefan Monnier in
792 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
793 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
794 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
795
796 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
797 (EMACS_UINTPTR): Likewise, with uintptr_t.
798
799 * lisp.h: Prefer 64-bit EMACS_INT if available.
800 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
801 on 32-bit hosts that have 64-bit int, so that they can access
802 large files.
803 However, temporarily disable this change unless the temporary
804 symbol WIDE_EMACS_INT is defined.
805
806 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
807
808 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
809 This removes an assumption that EMACS_INT and long are the same
810 width as pointers. The assumption is true for Emacs porting targets
811 now, but we want to make other targets possible.
812 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
813 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
814 In the rest of the code, change types of integers that hold casted
815 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
816 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
817 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
818 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
819 No need to cast type when ORing.
820 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
821 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
822 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
823 assume EMACS_INT is the same width as char *.
824 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
825 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
826 Remove no-longer-needed casts.
827 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
828 (xg_tool_bar_help_callback, xg_make_tool_item):
829 Use EMACS_INTPTR to hold an integer
830 that will be cast to void *; this can avoid a GCC warning
831 if EMACS_INT is not the same width as void *.
832 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
833 * xdisp.c (display_echo_area_1, resize_mini_window_1):
834 (current_message_1, set_message_1):
835 Use a local to convert to proper width without a cast.
836 * xmenu.c (dialog_selection_callback): Likewise.
837
838 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
839 Also, don't assume VALBITS / RAND_BITS is less than 5,
840 and don't rely on undefined behavior when shifting a 1 left into
841 the sign bit.
842 * lisp.h (get_random): Change signature to match.
843
844 * lread.c (hash_string): Use size_t, not int, for hash computation.
845 Normally we prefer signed values; but hashing is special, because
846 it's better to use unsigned division on hash table sizes so that
847 the remainder is nonnegative. Also, size_t is the natural width
848 for hashing into memory. The previous code used 'int', which doesn't
849 retain enough info to hash well into very large tables.
850 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
851
852 * dbusbind.c: Don't possibly lose pointer info when converting.
853 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
854 Use XPNTR rather than XHASH, so that the high-order bits of
855 the pointer aren't lost when converting through void *.
856
857 * eval.c (Fautoload): Don't double-shift a pointer.
858
859 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
860
861 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
862
863 * gnutls.c (DEF_GNUTLS_FN):
864 * image.c (DEF_IMGLIB_FN): Make function pointers static.
865
866 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
867
868 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
869 marker. (Bug#8610)
870
871 2011-05-05 Eli Zaretskii <eliz@gnu.org>
872
873 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
874 New version that can reserve upto 2GB of heap space.
875
876 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
877
878 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
879
880 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
881
882 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
883 `gnutls_certificate_set_x509_key_file'.
884
885 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
886
887 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
888 Update dependencies.
889
890 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
891
892 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
893 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
894 Remove unused parameter `fildes'.
895 * process.c (read_process_output, send_process): Don't pass it.
896
897 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
898
899 Fix previous change: the library cache is defined in w32.c.
900 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
901 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
902
903 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
904
905 Implement dynamic loading of GnuTLS on Windows.
906
907 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
908 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
909 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
910 Declare.
911
912 * gnutls.c (Qgnutls_dll): Define.
913 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
914 (gnutls_*): Declare function pointers.
915 (init_gnutls_functions): New function to initialize function pointers.
916 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
917 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
918 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
919 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
920 (emacs_gnutls_write, emacs_gnutls_read)
921 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
922 (Fgnutls_available_p): New function.
923 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
924 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
925 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
926
927 * image.c: Include w32.h.
928 (Vimage_type_cache): Delete.
929 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
930 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
931 (w32_delayed_load): Move to w32.c.
932
933 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
934
935 * w32.c (QCloaded_from, Vlibrary_cache): Define.
936 (w32_delayed_load): Move from image.c. When loading a library, record
937 its filename in the :loaded-from property of the library id.
938 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
939 Initialize and staticpro them.
940 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
941
942 * process.c: Include lisp.h before w32.h, not after.
943 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
944 instead of gnutls_record_check_pending.
945
946 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
947
948 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
949
950 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
951 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
952 as passed in.
953
954 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
955
956 * xterm.c (x_set_frame_alpha): Do not set property on anything
957 else than FRAME_X_OUTER_WINDOW (Bug#8608).
958
959 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
960
961 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
962
963 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
964
965 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
966 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
967 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
968 (gnutls_global_initialized, Qgnutls_bootprop_priority)
969 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
970 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
971 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
972 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
973 (Qgnutls_bootprop_callbacks_verify): Make static.
974
975 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
976
977 * callproc.c: Indentation fixup.
978
979 * sysdep.c (wait_for_termination_1): Make static.
980 (wait_for_termination, interruptible_wait_for_termination):
981 Move after wait_for_termination_1.
982
983 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
984
985 * sysdep.c (interruptible_wait_for_termination): New function
986 which is like wait_for_termination, but allows keyboard
987 interruptions.
988
989 * callproc.c (Fcall_process): Add (:file "file") as an option for
990 the STDOUT buffer.
991 (Fcall_process_region): Ditto.
992
993 2011-04-30 Eli Zaretskii <eliz@gnu.org>
994
995 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
996 rather than `XVECTOR (FOO)->size'.
997
998 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
999 inttypes.h, as a gnulib replacement is used if it not available in
1000 system headers.
1001
1002 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1003
1004 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1005 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1006 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1007
1008 * coding.c (coding_alloc_by_realloc): Error out if destination
1009 will grow beyond MOST_POSITIVE_FIXNUM.
1010 (decode_coding_emacs_mule): Abort if there isn't enough place in
1011 charbuf for the composition carryover bytes. Reserve an extra
1012 space for up to 2 characters produced in a loop.
1013 (decode_coding_iso_2022): Abort if there isn't enough place in
1014 charbuf for the composition carryover bytes.
1015
1016 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1017
1018 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1019 aborting when %lld or %lll format is passed.
1020 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1021 %llo or %llx format is passed. (Bug#8545)
1022
1023 * window.c (window_scroll_line_based): Use a marker instead of
1024 simple variables to record original value of point. (Bug#7952)
1025
1026 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1027 produced by %s or %c overflows available buffer space. (Bug#8545)
1028
1029 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1030
1031 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1032 (SIZE_MAX): Move defn after all includes, as they might #define it.
1033
1034 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1035
1036 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1037
1038 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1039
1040 * keyboard.c (Qdelayed_warnings_hook): Define.
1041 (command_loop_1): Run `delayed-warnings-hook'
1042 if Vdelayed_warnings_list is non-nil.
1043 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1044 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1045
1046 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1047
1048 * doprnt.c (doprnt): Don't return value smaller than the buffer
1049 size if the message was truncated. (Bug#8545).
1050
1051 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1054 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1055
1056 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1059
1060 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * makefile.w32-in: Update dependencies.
1063
1064 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1065
1066 Improve `doprnt' and its usage. (Bug#8545)
1067 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1068 `format_end'. Remove support for %l as a conversion specifier.
1069 Don't use xrealloc. Improve diagnostics when the %l size modifier
1070 is used. Update the commentary.
1071
1072 * eval.c (verror): Simplify calculation of size_t.
1073
1074 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1075 messages.
1076
1077 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1078
1079 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1080 change.
1081
1082 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1085 This makes this file independent of the recent pseudovector change.
1086
1087 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1090
1091 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1092 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1093 Remove unused local.
1094 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1095
1096 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1097 GCC 4.6.0 optimizes based on type-based alias analysis.
1098 For example, if b is of type struct buffer * and v of type struct
1099 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1100 != &v->size, and therefore "v->size = 1; b->size = 2; return
1101 v->size;" must therefore return 1. This assumption is incorrect
1102 for Emacs, since it type-puns struct Lisp_Vector * with many other
1103 types. To fix this problem, this patch adds a new type struct
1104 vectorlike_header that documents the constraints on layout of vectors
1105 and pseudovectors, and helps optimizing compilers not get fooled
1106 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1107 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1108 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1109 the size member.
1110 (XSETPVECTYPE): Rewrite in terms of new macro.
1111 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1112 This is a bit clearer, and further avoids the possibility of
1113 undesirable aliasing.
1114 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1115 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1116 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1117 since Lisp_Subr is a special case (no "next" field).
1118 (ASIZE): Now uses header.size rather than size.
1119 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1120 to avoid the hassle of writing XVECTOR (foo)->header.size.
1121 (struct vectorlike_header): New type.
1122 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1123 object, to help avoid aliasing.
1124 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1125 (SUBRP): Likewise, since Lisp_Subr is a special case.
1126 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1127 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1128 (struct Lisp_Hash_Table): Combine first two members into a single
1129 struct vectorlike_header member. All uses of "size" and "next" members
1130 changed to be "header.size" and "header.next".
1131 * buffer.h (struct buffer): Likewise.
1132 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1133 * frame.h (struct frame): Likewise.
1134 * process.h (struct Lisp_Process): Likewise.
1135 * termhooks.h (struct terminal): Likewise.
1136 * window.c (struct save_window_data, struct saved_window): Likewise.
1137 * window.h (struct window): Likewise.
1138 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1139 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1140 * buffer.c (init_buffer_once): Likewise.
1141 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1142 special case.
1143 * process.c (Fformat_network_address): Use local var for size,
1144 for brevity.
1145
1146 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1147
1148 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1149 * data.c (atof): Remove decl; no longer used or needed.
1150 (digit_to_number): Move to lread.c.
1151 (Fstring_to_number): Use new string_to_number function, to be
1152 consistent with how the Lisp reader treats infinities and NaNs.
1153 Do not assume that floating-point numbers represent EMACS_INT
1154 without losing information; this is not true on most 64-bit hosts.
1155 Avoid double-rounding errors, by insisting on integers when
1156 parsing non-base-10 numbers, as the documentation specifies.
1157 * lisp.h (string_to_number): New decl, replacing ...
1158 (isfloat_string): Remove.
1159 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1160 (read1): Do not accept +. and -. as integers; this
1161 appears to have been a coding error. Similarly, do not accept
1162 strings like +-1e0 as floating point numbers. Do not report
1163 overflow for integer overflows unless the base is not 10 which
1164 means we have no simple and reliable way to continue.
1165 Break out the floating-point parsing into a new
1166 function string_to_number, so that Fstring_to_number parses
1167 floating point numbers consistently with the Lisp reader.
1168 (digit_to_number): Move here from data.c. Make it static inline.
1169 (E_CHAR, EXP_INT): Remove, replacing with ...
1170 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1171 (string_to_number): New function, replacing isfloat_string.
1172 This function checks for valid syntax and produces the resulting
1173 Lisp float number too. Rework it so that string-to-number
1174 no longer mishandles examples like "1.0e+". Use strtoumax,
1175 so that overflow for non-base-10 numbers is reported only when
1176 there's no portable and simple way to convert to floating point.
1177
1178 * textprop.c (set_text_properties_1): Rewrite for clarity,
1179 and to avoid GCC warning about integer overflow.
1180
1181 * intervals.h (struct interval): Use EMACS_INT for members
1182 where EMACS_UINT might cause problems. See
1183 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1184 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1185 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1186 All uses changed.
1187 (offset_intervals): Tell GCC not to worry about length overflow
1188 when negating a negative length.
1189
1190 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1191 (overrun_check_free): Likewise.
1192
1193 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1194 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1195 word size.
1196
1197 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1198 (gnutls_make_error): Rename local to avoid shadowing.
1199 (gnutls_emacs_global_deinit): ifdef out; not used.
1200 (Fgnutls_boot): Use const for pointer to readonly storage.
1201 Comment out unused local. Fix pointer signedness problems.
1202
1203 * lread.c (openp): Don't stuff size_t into an 'int'.
1204 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1205 about possible signed overflow.
1206
1207 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1208 (GDK_KEY_g): Don't define if already defined.
1209 (xg_prepare_tooltip): Avoid pointer signedness problem.
1210 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1211
1212 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1213 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1214
1215 * xfns.c (Fx_window_property): Simplify a bit,
1216 to make a bit faster and to avoid GCC 4.6.0 warning.
1217 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1218
1219 * fns.c (internal_equal): Don't assume size_t fits in int.
1220
1221 * alloc.c (compact_small_strings): Tighten assertion a little.
1222
1223 Replace pEd with more-general pI, and fix some printf arg casts.
1224 * lisp.h (pI): New macro, generalizing old pEd macro to other
1225 conversion specifiers. For example, use "...%"pI"d..." rather
1226 than "...%"pEd"...".
1227 (pEd): Remove. All uses replaced with similar uses of pI.
1228 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1229 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1230 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1231 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1232 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1233 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1234 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1235 64-bit hosts.
1236 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1237 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1238 * print.c (safe_debug_print, print_object): Likewise.
1239 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1240 to int.
1241 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1242 avoiding the 0 flag, which is not portable.
1243 * process.c (Fmake_network_process): Use pI to avoid cast.
1244 * region-cache.c (pp_cache): Likewise.
1245 * xdisp.c (decode_mode_spec): Likewise.
1246 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1247 behavior on 64-bit hosts with printf arg.
1248 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1249 (x_stop_queuing_selection_requests): Likewise.
1250 (x_get_window_property): Don't truncate byte count to an 'int'
1251 when tracing.
1252
1253 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1254 here, since it parses constructs like leading '-' and spaces,
1255 which are not wanted; and it overflows with large numbers.
1256 Instead, simply match F[0-9]+, which is what is wanted anyway.
1257
1258 * alloc.c: Remove unportable assumptions about struct layout.
1259 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1260 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1261 (allocate_vectorlike, make_pure_vector): Use the new macros,
1262 plus offsetof, to remove unportable assumptions about struct layout.
1263 These assumptions hold on all porting targets that I know of, but
1264 they are not guaranteed, they're easy to remove, and removing them
1265 makes further changes easier.
1266
1267 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1268 This doesn't fix a bug but makes the code clearer.
1269 (string_overrun_cookie): Now const. Use initializers that
1270 don't formally overflow signed char, to avoid warnings.
1271 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1272 can cause Emacs to crash when string overrun checking is enabled.
1273 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1274 multiple of sizeof (EMACS_INT); it need not be, if
1275 alignof(EMACS_INT) < sizeof (EMACS_INT).
1276 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1277
1278 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1279
1280 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1281
1282 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1283
1284 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1285 supposed to be handshaking. (Bug#8556)
1286 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1287
1288 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1289
1290 * lisp.h (Qdebug): List symbol.
1291 * eval.c (Qdebug): Restore global linkage.
1292 * keyboard.c (debug-on-event): New variable.
1293 (handle_user_signal): Break into debugger when debug-on-event
1294 matches the current signal symbol.
1295
1296 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1297
1298 * alloc.c (check_sblock, check_string_bytes)
1299 (check_string_free_list): Convert to standard C.
1300
1301 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1302
1303 * w32.c (emacs_gnutls_push): Fix typo.
1304
1305 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1306
1307 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1308 "cast to pointer from integer of different size".
1309
1310 Improve doprnt and its use in verror. (Bug#8545)
1311 * doprnt.c (doprnt): Document the set of format control sequences
1312 supported by the function. Use SAFE_ALLOCA instead of always
1313 using `alloca'.
1314
1315 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1316 is one byte too soon. Don't use xrealloc; instead xfree and
1317 xmalloc anew.
1318
1319 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1320
1321 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1322 callbacks stage.
1323
1324 * gnutls.c: Renamed global_initialized to
1325 gnutls_global_initialized. Added internals for the
1326 :verify-hostname-error, :verify-error, and :verify-flags
1327 parameters of `gnutls-boot' and documented those parameters in the
1328 docstring. Start callback support.
1329 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1330 unless a fatal error occured. Call gnutls_alert_send_appropriate
1331 on error. Return error code.
1332 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1333 (emacs_gnutls_read): Likewise.
1334 (Fgnutls_boot): Return handshake error code.
1335 (emacs_gnutls_handle_error): New function.
1336 (wsaerror_to_errno): Likewise.
1337
1338 * w32.h (emacs_gnutls_pull): Add prototype.
1339 (emacs_gnutls_push): Likewise.
1340
1341 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1342 (emacs_gnutls_push): Likewise.
1343
1344 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1345
1346 * process.c (wait_reading_process_output): Check if GnuTLS
1347 buffered some data internally if no FDs are set for TLS
1348 connections.
1349
1350 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1351 (LIBS): Link to USER_LIBS.
1352 ($(BLD)/gnutls.$(0)): New target.
1353
1354 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1355
1356 * xdisp.c (handle_single_display_spec): Rename the
1357 display_replaced_before_p argument into display_replaced_p, to
1358 make it consistent with the commentary. Fix typos in the
1359 commentary.
1360
1361 * textprop.c (syms_of_textprop): Remove dead code.
1362 (copy_text_properties): Delete obsolete commentary about an
1363 interface that was deleted long ago. Fix typos in the description
1364 of arguments.
1365
1366 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1367 to changes in oldXMenu/XMenu.h from 2011-04-16.
1368 <menu_help_message, prev_menu_help_message>: Constify.
1369 (IT_menu_make_room): menu->help_text is now `const char **';
1370 adjust.
1371
1372 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1373 to changes in oldXMenu/XMenu.h from 2011-04-16.
1374 (struct XMenu): Declare `help_text' `const char **'.
1375
1376 * xfaces.c <Qunspecified>: Make extern again.
1377
1378 * syntax.c: Include sys/types.h before including regex.h, as
1379 required by Posix.
1380
1381 * doc.c (get_doc_string): Improve the format passed to `error'.
1382
1383 * doprnt.c (doprnt): Improve commentary.
1384
1385 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1386
1387 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1388 them with etags.
1389
1390 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1391 changes in globals.h immediately force recompilation.
1392 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1393 $(CURDIR)/s/ms-w32.h.
1394 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1395
1396 * character.c (Fchar_direction): Function deleted.
1397 (syms_of_character): Don't defsubr it.
1398 <char-direction-table>: Deleted.
1399
1400 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1401
1402 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1403 * doprnt.c: Include limits.h.
1404 (SIZE_MAX): New macro.
1405 (doprnt): Return a size_t value. 2nd arg is now size_t.
1406 Many local variables are now size_t instead of int or unsigned.
1407 Improve overflow protection. Support `l' modifier for integer
1408 conversions. Support %l conversion. Don't assume an EMACS_INT
1409 argument for integer conversions and for %c.
1410
1411 * lisp.h (doprnt): Restore prototype.
1412
1413 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1414 $(SRC)/character.h.
1415
1416 * Makefile.in (base_obj): Add back doprnt.o.
1417
1418 * deps.mk (doprnt.o): Add back prerequisites.
1419 (callint.o): Depend on character.h.
1420
1421 * eval.c (internal_lisp_condition_case): Include the handler
1422 representation in the error message.
1423 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1424 when breaking from the loop.
1425
1426 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1427
1428 * callint.c (Fcall_interactively): When displaying error message
1429 about invalid control letter, pass the character's codepoint, not
1430 a pointer to its multibyte form. Improve display of the character
1431 in octal and display also its hex code.
1432
1433 * character.c (char_string): Use %x to display the (unsigned)
1434 codepoint of an invalid character, to avoid displaying a bogus
1435 negative value.
1436
1437 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1438 `error', not SYMBOL_NAME itself.
1439
1440 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1441 character arguments to `error'.
1442
1443 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1444 to `error' in error message about FINAL_CHAR argument. Make sure
1445 FINAL_CHAR is a character, and use %c when it is passed as
1446 argument to `error'.
1447
1448 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1449
1450 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1451
1452 * w32.c: Include <time.h>.
1453 (sys_localtime): New function.
1454
1455 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1456
1457 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1458
1459 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1460
1461 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1462
1463 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1464 zombies (Bug#8467).
1465
1466 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1467
1468 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1469 gl_state.e_property when gl_state.object is Qt.
1470
1471 * insdel.c (make_gap_larger): Remove limitation of buffer size
1472 to <= INT_MAX.
1473
1474 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1475
1476 * xdisp.c (lookup_glyphless_char_display)
1477 (produce_glyphless_glyph): Handle cons cell entry in
1478 glyphless-char-display.
1479 (Vglyphless_char_display): Document it.
1480
1481 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1482 glyphless-char-display.
1483
1484 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1485
1486 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1487
1488 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1489
1490 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1491 definition for no-X builds.
1492
1493 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 Static checks with GCC 4.6.0 and non-default toolkits.
1496
1497 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1498
1499 * process.c (keyboard_bit_set): Define only if SIGIO.
1500 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1501 (send_process): Repair possible setjmp clobbering.
1502
1503 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1504
1505 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1506
1507 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1508
1509 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1510 Define only if needed.
1511
1512 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1513 by pacifying GCC about it. Maybe it's time to retire it?
1514 * xfaces.c (USG, __TIMEVAL__): Likewise.
1515
1516 * dispextern.h (struct redisplay_interface): Rename param
1517 to avoid shadowing.
1518 * termhooks.h (struct terminal): Likewise.
1519 * xterm.c (xembed_send_message): Likewise.
1520
1521 * insdel.c (make_gap_smaller): Define only if
1522 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1523
1524 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1525 it.
1526
1527 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1528 so that we aren't warned about unused symbols.
1529
1530 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1531
1532 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1533
1534 * xfns.c (x_real_positions): Mark locals as initialized.
1535
1536 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1537
1538 * xterm.c: Fix problems found by static analysis with other toolkits.
1539 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1540 (x_dispatch_event): Declare static if USE_GTK, and
1541 define if USE_GTK || USE_X_TOOLKIT.
1542 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1543 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1544 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1545 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1546
1547 * xmenu.c (menu_help_callback): Pointer type fixes.
1548 Use const pointers when pointing at readonly data. Avoid pointer
1549 signedness clashes.
1550 (FALSE): Remove unused macro.
1551 (update_frame_menubar): Remove unused decl.
1552
1553 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1554
1555 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1556 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1557 (single_menu_item): Rename local to avoid shadowing.
1558
1559 * keyboard.c (make_lispy_event): Remove unused local var.
1560
1561 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1562 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1563
1564 * bitmaps: Change bitmaps from unsigned char back to the X11
1565 compatible char. Avoid the old compiler warnings about
1566 out-of-range initializers by using, for example, '\xab' rather
1567 than 0xab.
1568
1569 * xgselect.c (xgselect_initialize): Check vs interface
1570 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1571
1572 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1573
1574 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1575 to read-only memory.
1576
1577 * fns.c (vector): Remove; this old hack is no longer needed.
1578
1579 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1580 Remove unused var.
1581 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1582
1583 * xrdb.c (x_load_resources): Omit unused local.
1584
1585 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1586 (x_window): Rename locals to avoid shadowing.
1587 (USG): Use the kludged USG macro, to pacify gcc.
1588
1589 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1590 (x_term_init): Remove local to avoid shadowing.
1591
1592 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1593
1594 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1595 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1596
1597 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1598
1599 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1600
1601 Fix regex.c, syntax.c and friends for buffers > 2GB.
1602 * syntax.h (struct gl_state_s): Declare character position members
1603 EMACS_INT.
1604
1605 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1606
1607 * textprop.c (verify_interval_modification, interval_of):
1608 Declare arguments EMACS_INT.
1609
1610 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1611 EMACS_INT.
1612
1613 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1614
1615 * indent.c (Fvertical_motion): Local variable it_start is now
1616 EMACS_INT.
1617
1618 * regex.c (re_match, re_match_2, re_match_2_internal)
1619 (bcmp_translate, regcomp, regexec, print_double_string)
1620 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1621 (re_compile_pattern, re_exec): Declare arguments and local
1622 variables `size_t' and `ssize_t' and return values `regoff_t', as
1623 appropriate.
1624 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1625 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1626 <compile_stack_type>: `size' and `avail' are now `size_t'.
1627
1628 * regex.h <regoff_t>: Use ssize_t, not int.
1629 (re_search, re_search_2, re_match, re_match_2): Arguments that
1630 specify buffer/string position and length are now ssize_t and
1631 size_t. Return type is regoff_t.
1632
1633 2011-04-16 Ben Key <bkey76@gmail.com>
1634
1635 * nsfont.m: Fixed bugs in ns_get_family and
1636 ns_descriptor_to_entity that were caused by using free to
1637 deallocate memory blocks that were allocated by xmalloc (via
1638 xstrdup). This caused Emacs to crash when compiled with
1639 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1640 --enable-checking=xmallocoverrun). xfree is now used to
1641 deallocate these memory blocks.
1642
1643 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1646
1647 emacs_write: Accept and return EMACS_INT for sizes.
1648 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1649 et seq.
1650 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1651 Accept and return EMACS_INT.
1652 (emacs_gnutls_write): Return the number of bytes written on
1653 partial writes.
1654 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1655 (emacs_read, emacs_write): Remove check for negative size, as the
1656 Emacs source code has been audited now.
1657 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1658 (emacs_read, emacs_write): Use it.
1659 * process.c (send_process): Adjust to the new signatures of
1660 emacs_write and emacs_gnutls_write. Do not attempt to store
1661 a byte offset into an 'int'; it might overflow.
1662 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1663
1664 * sound.c: Don't assume sizes fit in 'int'.
1665 (struct sound_device.period_size, alsa_period_size):
1666 Return EMACS_INT, not int.
1667 (struct sound_device.write, vox_write, alsa_write):
1668 Accept EMACS_INT, not int.
1669 (wav_play, au_play): Use EMACS_INT to store sizes and to
1670 record read return values.
1671
1672 2011-04-15 Ben Key <bkey76@gmail.com>
1673
1674 * keyboard.c (Qundefined): Don't declare static since it is used
1675 in nsfns.m.
1676 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1677 static since they are used in nsfont.m.
1678
1679 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1680
1681 * process.c (Qprocessp): Don't declare static.
1682 * lisp.h (Qprocessp): Declare again.
1683
1684 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1685
1686 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1687
1688 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 Improve C-level modularity by making more things 'static'.
1691
1692 Don't publish debugger-only interfaces to other modules.
1693 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1694 (verify_bytepos, count_markers): Move decls to the only modules
1695 that need them.
1696 * region-cache.h (pp_cache): Likewise.
1697 * window.h (check_all_windows): Likewise.
1698 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1699
1700 * sysdep.c (croak): Now static, if
1701 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1702 * syssignal.h (croak): Declare only if not static.
1703
1704 * alloc.c (refill_memory_reserve): Now static if
1705 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1706 * lisp.h (refill_memory_reserve): Declare only if not static.
1707
1708 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1709 Define only if USE_LUCID.
1710
1711 * xrdb.c (x_customization_string, x_rm_string): Now static.
1712
1713 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1714 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1715
1716 * xdisp.c (draw_row_with_mouse_face): Now static.
1717 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1718
1719 * window.h (check_all_windows): Mark externally visible.
1720
1721 * window.c (window_deletion_count): Now static.
1722
1723 * undo.c: Make symbols static if they're not exported.
1724 (last_undo_buffer, last_boundary_position, pending_boundary):
1725 Now static.
1726
1727 * textprop.c (interval_insert_behind_hooks): Now static.
1728 (interval_insert_in_front_hooks): Likewise.
1729
1730 * term.c: Make symbols static if they're not exported.
1731 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1732 (max_frame_lines, tty_set_terminal_modes):
1733 (tty_reset_terminal_modes, tty_turn_off_highlight):
1734 (get_tty_terminal): Now static.
1735 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1736 * termhooks.h (term_mouse_moveto): Do not declare if
1737 HAVE_WINDOW_SYSTEM.
1738 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1739 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1740
1741 * sysdep.c: Make symbols static if they're not exported.
1742 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1743 Now static.
1744 (sigprocmask_set, full_mask): Remove; unused.
1745 (wait_debugging): Mark as visible.
1746 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1747 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1748
1749 * syntax.c (syntax_temp): Define only if !__GNUC__.
1750
1751 * sound.c (current_sound_device, current_sound): Now static.
1752
1753 * search.c (searchbufs, searchbuf_head): Now static.
1754
1755 * scroll.c (scroll_cost): Remove; unused.
1756 * dispextern.h (scroll_cost): Remove decl.
1757
1758 * region-cache.h (pp_cache): Mark as externally visible.
1759
1760 * process.c: Make symbols static if they're not exported.
1761 (process_tick, update_tick, create_process, chan_process):
1762 (Vprocess_alist, proc_buffered_char, datagram_access):
1763 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1764 (deactivate_process): Mark defn as static, as well as decl.
1765 * lisp.h (create_process): Remove decl.
1766 * process.h (chan_process, Vprocess_alist): Remove decls.
1767
1768 * print.c: Make symbols static if they're not exported.
1769 (print_depth, new_backquote_output, being_printed, print_buffer):
1770 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1771 (print_interval, print_number_index, initial_stderr_stream):
1772 Now static.
1773 * lisp.h (Fprinc): Remove decl.
1774 (debug_output_compilation_hack): Mark as externally visible.
1775
1776 * sysdep.c (croak): Move decl from here to syssignal.h.
1777 * syssignal.h (croak): Put it here, so the API can be checked when
1778 'croak' is called from dissociate_if_controlling_tty.
1779
1780 * minibuf.c: Make symbols static if they're not exported.
1781 (minibuf_save_list, choose_minibuf_frame): Now static.
1782 * lisp.h (choose_minibuf_frame): Remove decl.
1783
1784 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1785
1786 * lread.c: Make symbols static if they're not exported.
1787 (read_objects, initial_obarray, oblookup_last_bucket_number):
1788 Now static.
1789 (make_symbol): Remove; unused.
1790 * lisp.h (initial_obarray, make_symbol): Remove decls.
1791
1792 * keyboard.c: Make symbols static if they're not exported.
1793 (single_kboard, recent_keys_index, total_keys, recent_keys):
1794 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1795 (this_single_command_key_start, echoing, last_auto_save):
1796 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1797 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1798 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1799 (Vlispy_mouse_stem, double_click_count):
1800 Now static.
1801 (force_auto_save_soon): Define only if SIGDANGER.
1802 (ignore_mouse_drag_p): Now static if
1803 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1804 (print_help): Remove; unused.
1805 (stop_character, last_timer_event): Mark as externally visible.
1806 * keyboard.h (ignore_mouse_drag_p): Declare only if
1807 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1808 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1809 * lisp.h (echoing): Remove decl.
1810 (force_auto_save_soon): Declare only if SIGDANGER.
1811 * xdisp.c (redisplay_window): Simplify code, to make it more
1812 obvious that ignore_mouse_drag_p is not accessed if !defined
1813 USE_GTK && !defined HAVE_NS.
1814
1815 * intervals.c: Make symbols static if they're not exported.
1816 (merge_properties_sticky, merge_interval_right, delete_interval):
1817 Now static.
1818 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1819
1820 * insdel.c: Make symbols static if they're not exported.
1821 However, leave prepare_to_modify_buffer alone. It's never
1822 called from outside this function, but that appears to be a bug.
1823 (combine_after_change_list, combine_after_change_buffer):
1824 (adjust_after_replace, signal_before_change): Now static.
1825 (adjust_after_replace_noundo): Remove; unused.
1826 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1827 (signal_before_change): Remove decls.
1828
1829 * indent.c (val_compute_motion, val_vmotion): Now static.
1830
1831 * image.c: Make symbols static if they're not exported.
1832 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1833 if USE_GTK.
1834 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1835 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1836
1837 * fringe.c (standard_bitmaps): Now static.
1838 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1839
1840 * frame.c: Make symbols static if they're not exported.
1841 (x_report_frame_params, make_terminal_frame): Now static.
1842 (get_frame_param): Now static, unless HAVE_NS.
1843 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1844 (x_get_resource_string): Remove; not used.
1845 * frame.h (make_terminal_frame, x_report_frame_params):
1846 (x_get_resource_string); Remove decls.
1847 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1848 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1849
1850 * font.c, fontset.c: Make symbols static if they're not exported.
1851 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1852 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1853 * font.c (font_close_object): Now static.
1854 * font.h (font_close_object): Remove.
1855 * fontset.c (FONTSET_OBJLIST): Remove.
1856 (free_realized_fontset) #if-0 the body, which does nothing.
1857 (face_suitable_for_char_p): #if-0, as it's never called.
1858 * fontset.h (face_suitable_for_char_p): Remove decl.
1859 * xfaces.c (face_at_string_position):
1860 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1861 since 0 is always ASCII.
1862
1863 * fns.c (weak_hash_tables): Now static.
1864
1865 * fileio.c: Make symbols static if they're not exported.
1866 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1867 (Vwrite_region_annotation_buffers): Now static.
1868
1869 * eval.c: Make symbols static if they're not exported.
1870 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1871 * lisp.h (backtrace_list): Remove decl.
1872
1873 * emacs.c: Make symbols static if they're not exported.
1874 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1875 (fatal_error_code, fatal_error_signal_hook, standard_args):
1876 Now static.
1877 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1878 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1879 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1880 * lisp.h (fatal_error_signal_hook): Remove decl.
1881 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1882
1883 * editfns.c: Move a (normally-unused) function to its only use.
1884 * editfns.c, lisp.h (get_operating_system_release): Remove.
1885 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1886 worth the hassle of breaking this out.
1887
1888 * xterm.c: Make symbols static if they're not exported.
1889 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1890 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1891 (x_destroy_window, x_delete_display):
1892 Now static.
1893 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1894 (x_mouse_leave): Remove; unused.
1895 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1896 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1897 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1898 Remove decls.
1899 (x_mouse_leave): Declare only if WINDOWSNT.
1900 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1901 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1902 USE_X_TOOLKIT.
1903
1904 * ftxfont.c: Make symbols static if they're not exported.
1905 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1906 HAVE_FREETYPE.
1907 * font.h (ftxfont_driver): Likewise.
1908
1909 * xfns.c: Make symbols static if they're not exported.
1910 (x_last_font_name, x_display_info_for_name):
1911 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1912 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1913 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1914 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1915 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1916 (last_show_tip_args): Now static.
1917 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1918 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1919 (x_screen_planes): Remove; unused.
1920 * dispextern.h (x_screen_planes): Remove decl.
1921
1922 * dispnew.c: Make symbols static if they're not exported.
1923 * dispextern.h (redraw_garbaged_frames, scrolling):
1924 (increment_row_positions): Remove.
1925 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1926 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1927 Now static.
1928 (redraw_garbaged_frames): Remove; unused.
1929
1930 * xfaces.c: Make symbols static if they're not exported.
1931 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1932 Remove decls.
1933 * xterm.h (defined_color): Remove decls.
1934 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1935 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1936 (menu_face_changed_default, defined_color, free_realized_face):
1937 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1938 (ascii_face_of_lisp_face): Remove; unused.
1939
1940 * xdisp.c: Make symbols static if they're not exported.
1941 * dispextern.h (scratch_glyph_row, window_box_edges):
1942 (glyph_to_pixel_coords, set_cursor_from_row):
1943 (get_next_display_element, set_iterator_to_next):
1944 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1945 (show_mouse_face): Remove decls
1946 * frame.h (message_buf_print): Likewise.
1947 * lisp.h (pop_message, set_message, check_point_in_composition):
1948 Likewise.
1949 * xterm.h (set_vertical_scroll_bar): Likewise.
1950 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1951 (message_buf_print, scratch_glyph_row, displayed_buffer):
1952 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1953 (get_next_display_element, show_mouse_face, window_box_edges):
1954 (frame_to_window_pixel_xy, check_point_in_composition):
1955 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1956 (glyph_to_pixel_coords): Remove; unused.
1957
1958 * dired.c (file_name_completion): Now static.
1959
1960 * dbusbind.c (xd_in_read_queued_messages): Now static.
1961
1962 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1963 * data.c (circular_list_error): Remove.
1964
1965 * commands.h (last_point_position, last_point_position_buffer):
1966 (last_point_position_window): Remove decls.
1967 * keyboard.c: Make these variables static.
1968
1969 * coding.h (coding, code_convert_region, encode_coding_gap):
1970 Remove decls.
1971 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1972 (iso_code_class, detect_coding, code_convert_region): Now static.
1973 (encode_coding_gap): Remove; unused.
1974
1975 * chartab.c (chartab_chars, chartab_bits): Now static.
1976
1977 * charset.h (charset_iso_8859_1): Remove decl.
1978 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1979 Now static.
1980
1981 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1982 * ccl.c (Vccl_program_table): Now static.
1983 (check_ccl_update): Remove; unused.
1984
1985 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1986 * category.h: ... from here.
1987 * category.c (check_category_table, set_category_set): Now static.
1988
1989 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1990 * lisp.h: Remove these decls.
1991
1992 * buffer.c (buffer_count): Remove unused var.
1993
1994 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1995 so that it's not optimized away.
1996 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1997 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1998 exported only to the debugger.
1999
2000 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2001 * atimer.h (run_all_atimers): Remove; not exported.
2002
2003 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2004 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2005 was inaccessible from Lisp.
2006 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2007 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2008
2009 alloc.c: Import and export fewer symbols, and remove unused items.
2010 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2011 is defined.
2012 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2013 it's not optimized away by whole-program optimization.
2014 (message_enable_multibyte, free_misc): Remove.
2015 (catchlist, handlerlist, mark_backtrace):
2016 Declare only if BYTE_MARK_STACK.
2017 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2018 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2019 (message_enable_multibyte): Remove decl.
2020 (free_misc, interval_free_list, float_block, float_block_index):
2021 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2022 (cons_free_list, last_marked_index):
2023 Now static.
2024 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2025 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2026 (mark_backtrace): Define only if BYTE_MARK_STACK.
2027 * xdisp.c (message_enable_multibyte): Now static.
2028
2029 Declare Lisp_Object Q* variables to be 'static' if not exported.
2030 This makes it easier for human readers (and static analyzers)
2031 to see whether these variables are used from other modules.
2032 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2033 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2034 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2035 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2036 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2037 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2038 * xmenu.c, xselect.c:
2039 Declare Q* vars static if they are not used in other modules.
2040 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2041 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2042 Remove decls of unexported vars.
2043 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2044
2045 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2046
2047 Make Emacs functions such as Fatom 'static' by default.
2048 This makes it easier for human readers (and static analyzers)
2049 to see whether these functions can be called from other modules.
2050 DEFUN now defines a static function. To make the function external
2051 so that it can be used in other C modules, use the new macro DEFUE.
2052 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2053 (Finit_image_library):
2054 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2055 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2056 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2057 Remove decls, since these functions are now static.
2058 (Funintern, Fget_internal_run_time): New decls, since these functions
2059 were already external.
2060
2061 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2062 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2063 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2064 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2065 * keyboard.c, keymap.c, lread.c:
2066 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2067 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2068 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2069 Mark functions with DEFUE instead of DEFUN,
2070 if they are used in other modules.
2071 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2072 decls for now-static functions.
2073 * buffer.h (Fdelete_overlay): Remove decl.
2074 * callproc.c (Fgetenv_internal): Mark as internal.
2075 * composite.c (Fremove_list_of_text_properties): Remove decl.
2076 (Fcomposition_get_gstring): New forward static decl.
2077 * composite.h (Fcomposite_get_gstring): Remove decl.
2078 * dired.c (Ffile_attributes): New forward static decl.
2079 * doc.c (Fdocumntation_property): New forward static decl.
2080 * eval.c (Ffetch_bytecode): New forward static decl.
2081 (Funintern): Remove extern decl; now in .h file where it belongs.
2082 * fileio.c (Fmake_symbolic_link): New forward static decl.
2083 * image.c (Finit_image_library): New forward static decl.
2084 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2085 * intervals.h (Fprevious_property_change):
2086 (Fremove_list_of_text_properties): Remove decls.
2087 * keyboard.c (Fthis_command_keys): Remove decl.
2088 (Fcommand_execute): New forward static decl.
2089 * keymap.c (Flookup_key): New forward static decl.
2090 (Fcopy_keymap): Now static.
2091 * keymap.h (Flookup_key): Remove decl.
2092 * process.c (Fget_process): New forward static decl.
2093 (Fprocess_datagram_address): Mark as internal.
2094 * syntax.c (Fsyntax_table_p): New forward static decl.
2095 (skip_chars): Remove duplicate decl.
2096 * textprop.c (Fprevious_property_change): New forward static decl.
2097 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2098 Now internal.
2099 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2100 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2101
2102 * editfns.c (Fformat): Remove unreachable code.
2103
2104 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2105
2106 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2107 change. (Bug#8496)
2108
2109 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2112 when at ZV. (Bug#8487)
2113
2114 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2115
2116 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2117 (Bug#8437)
2118 * keyboard.c (parse_tool_bar_item): Likewise.
2119 * sound.c (sound_cleanup, alsa_close): Likewise.
2120 * termcap.c (tgetent): Likewise.
2121 * xfns.c (x_default_font_parameter): Likewise.
2122 * xsettings.c (read_and_apply_settings): Likewise.
2123
2124 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2125 (overrun_check_free): Protoize.
2126
2127 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2128
2129 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2130 since callers should never pass a negative size.
2131 Change the signature to match that of plain 'read' and 'write'; see
2132 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2133 * lisp.h: Update prototypes of emacs_write and emacs_read.
2134
2135 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2136
2137 * xdisp.c (redisplay_window): Don't try to determine the character
2138 position of the scroll margin if the window start point w->startp
2139 is outside the buffer's accessible region. (Bug#8468)
2140
2141 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2142
2143 Fix write-region and its subroutines for buffers > 2GB.
2144 * fileio.c (a_write, e_write): Modify declaration of arguments and
2145 local variables to support buffers larger than 2GB.
2146 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2147
2148 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2149 argument, local variables, and return value.
2150
2151 * lisp.h: Update prototypes of emacs_write and emacs_read.
2152
2153 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2154
2155 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2158
2159 Fix more problems found by GCC 4.6.0's static checks.
2160
2161 * xdisp.c (vmessage): Use a better test for character truncation.
2162
2163 * charset.c (load_charset_map): <, not <=, for optimization,
2164 and to avoid potential problems with integer overflow.
2165 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2166 * casetab.c (set_identity, shuffle): Likewise.
2167 * editfns.c (Fformat): Likewise.
2168 * syntax.c (skip_chars): Likewise.
2169
2170 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2171 This also lets GCC 4.6.0 generate slightly better loop code.
2172
2173 * callint.c (Fcall_interactively): <, not <=, for optimization.
2174 (Fcall_interactively): Count the number of arguments produced,
2175 not the number of arguments given. This is simpler and lets GCC
2176 4.6.0 generate slightly better code.
2177
2178 * ftfont.c: Distingish more carefully between FcChar8 and char.
2179 The previous code passed unsigned char * to a functions like
2180 strlen and xstrcasecmp that expect char *, which does not
2181 conform to the C standard.
2182 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2183 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2184 char * when the C standard requires it.
2185
2186 * keyboard.c (read_char): Remove unused var.
2187
2188 * eval.c: Port to Windows vsnprintf (Bug#8435).
2189 Include <limits.h>.
2190 (SIZE_MAX): Define if the headers do not.
2191 (verror): Do not give up if vsnprintf returns a negative count.
2192 Instead, grow the buffer. This ports to Windows vsnprintf, which
2193 does not conform to C99. Problem reported by Eli Zaretskii.
2194 Also, simplify the allocation scheme, by avoiding the need for
2195 calling realloc, and removing the ALLOCATED variable.
2196
2197 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2198
2199 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2200 But keep the doprint source code for now, as we might revamp it
2201 and use it again (Bug#8435).
2202 * lisp.h (doprnt): Remove.
2203 * Makefile.in (base_obj): Remove doprnt.o.
2204 * deps.mk (doprnt.o): Remove.
2205
2206 error: Print 32- and 64-bit integers portably (Bug#8435).
2207 Without this change, on typical 64-bit hosts error ("...%d...", N)
2208 was used to print both 32- and 64-bit integers N, which relied on
2209 undefined behavior.
2210 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2211 New macro.
2212 * lisp.h (error, verror): Mark as printf-like functions.
2213 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2214 Report overflow in size calculations when allocating printf buffer.
2215 Do not truncate output string at its first null byte.
2216 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2217 Truncate the output at a character boundary, since vsnprintf does not
2218 do that.
2219 * charset.c (check_iso_charset_parameter): Convert internal
2220 character to string before calling 'error', since %c now has the
2221 printf meaning.
2222 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2223 overflow when computing char to be passed to 'error'. Do not
2224 pass Lisp_Object to 'error'; pass the integer instead.
2225 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2226 formatted with plain %d.
2227
2228 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2229
2230 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2231
2232 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2233
2234 * xterm.c (x_catch_errors): Remove duplicate declaration.
2235
2236 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2237
2238 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2239
2240 2011-04-10 Jim Meyering <meyering@redhat.com>
2241
2242 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2243 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2244 return ssize_t not "int", and use size_t as the buffer length.
2245 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2246 * gnutls.h: Update declarations.
2247 * process.c (read_process_output): Use ssize_t, to match.
2248 (send_process): Likewise.
2249
2250 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2251
2252 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2253
2254 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2255
2256 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2257 Use unsigned char, to match FcChar8 type definition.
2258
2259 * xterm.c (handle_one_xevent):
2260 * xmenu.c (create_and_show_popup_menu):
2261 * xselect.c (x_decline_selection_request)
2262 (x_reply_selection_request): Avoid type-punned deref of X events.
2263
2264 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2265
2266 Fix some uses of `int' instead of EMACS_INT.
2267 * search.c (string_match_1, fast_string_match)
2268 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2269 (scan_buffer, find_next_newline_no_quit)
2270 (find_before_next_newline, search_command, Freplace_match)
2271 (Fmatch_data): Make some `int' variables be EMACS_INT.
2272
2273 * xdisp.c (display_count_lines): 3rd argument and return value now
2274 EMACS_INT. All callers changed.
2275 (pint2hrstr): Last argument is now EMACS_INT.
2276
2277 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2278 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2279 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2280 (decode_coding_utf_16, decode_coding_emacs_mule)
2281 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2282 (decode_coding_ccl, decode_coding_charset)
2283 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2284 (decode_coding_iso_2022, decode_coding_emacs_mule)
2285 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2286 <char_offset, last_offset>: Declare EMACS_INT.
2287 (encode_coding_utf_8, encode_coding_utf_16)
2288 (encode_coding_emacs_mule, encode_invocation_designation)
2289 (encode_designation_at_bol, encode_coding_iso_2022)
2290 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2291 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2292 Declare EMACS_INT.
2293 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2294 (encode_invocation_designation): Last argument P_NCHARS is now
2295 EMACS_INT.
2296 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2297 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2298
2299 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2300 All users changed.
2301
2302 * ccl.c (Fccl_execute_on_string): Declare some variables
2303 EMACS_INT.
2304
2305 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2306
2307 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2308
2309 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2310
2311 * process.c (Fformat_network_address): Doc fix.
2312
2313 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2314
2315 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2316
2317 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2318
2319 * keyboard.c (read_char): Call Lisp function help-form-show,
2320 instead of using internal_with_output_to_temp_buffer.
2321 (Qhelp_form_show): New var.
2322 (syms_of_keyboard): Use DEFSYM macro.
2323
2324 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2325
2326 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2327
2328 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2329
2330 * process.c (Flist_processes): Remove to Lisp.
2331 (list_processes_1): Delete.
2332
2333 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2334
2335 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2336
2337 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2338
2339 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2340
2341 Fix more problems found by GCC 4.6.0's static checks.
2342
2343 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2344
2345 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2346
2347 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2348
2349 * xdisp.c (vmessage): Mark as a printf-like function.
2350
2351 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2352
2353 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2354
2355 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2356 printf-like functions.
2357 (tiff_load): Add casts to remove these marks before passing them
2358 to system-supplied API.
2359
2360 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2361
2362 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2363 This avoids several warnings with gcc -Wstrict-overflow.
2364 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2365 directly, rather than having caller test rule sign. This avoids
2366 some unnecessary tests.
2367 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2368 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2369 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2370
2371 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2372 (xfont_open): Avoid unnecessary tests.
2373
2374 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2375
2376 * composite.h, composite.c (composition_gstring_put_cache):
2377 Use EMACS_INT, not int, for length.
2378
2379 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2380 breaking out part of COMPOSITION_DECODE_RULE.
2381 (COMPOSITION_DECODE_RULE): Use it.
2382 * composite.c (get_composition_id): Remove unused local vars,
2383 by using the new macro.
2384
2385 * textprop.c (set_text_properties_1): Change while to do-while,
2386 since the condition is always true at first.
2387
2388 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2389 (interval_deletion_adjustment): Return unsigned value.
2390 All uses changed.
2391
2392 * process.c (list_processes_1, create_pty, read_process_output):
2393 (exec_sentinel): Remove vars that were set but not used.
2394 (create_pty): Remove unnecessary "volatile"s.
2395 (Fnetwork_interface_info): Avoid possibility of int overflow.
2396 (read_process_output): Do adaptive read buffering even if carryover.
2397 (read_process_output): Simplify nbytes computation if buffered.
2398
2399 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2400
2401 * syntax.c (scan_words): Remove var that was set but not used.
2402 (update_syntax_table): Use unsigned instead of int.
2403
2404 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2405 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2406 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2407
2408 * print.c (print_error_message): Avoid int overflow.
2409
2410 * font.c (font_list_entities): Redo for clarity,
2411 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2412
2413 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2414 (font_score): Avoid potential overflow in diff calculation.
2415
2416 * fns.c (substring_both): Remove var that is set but not used.
2417 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2418
2419 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2420
2421 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2422 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2423 can always succeed if overflow has undefined behavior.
2424
2425 * search.c (boyer_moore, wordify): Remove vars set but not used.
2426 (wordify): Omit three unnecessary tests.
2427
2428 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2429 All callers changed. This avoids the need for an unused var.
2430
2431 * casefiddle.c (casify_region): Remove var that is set but not used.
2432
2433 * dired.c (file_name_completion): Remove var that is set but not used.
2434
2435 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2436
2437 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2438 (Finsert_file_contents): Remove unnecessary code checking fd.
2439
2440 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2441 Check for integer overflow on size calculations.
2442
2443 * buffer.c (Fprevious_overlay_change): Remove var that is set
2444 but not used.
2445
2446 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2447 Remove vars that are set but not used.
2448 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2449 (timer_check_2): Mark vars as initialized.
2450
2451 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2452
2453 * image.c (lookup_image): Remove var that is set but not used.
2454 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2455
2456 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2457 that are set but not used.
2458
2459 * xfns.c (make_invisible_cursor): Don't return garbage
2460 if XCreateBitmapFromData fails (Bug#8410).
2461
2462 * xselect.c (x_get_local_selection, x_handle_property_notify):
2463 Remove vars that are set but not used.
2464
2465 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2466 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2467
2468 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2469 Remove var that is set but not used.
2470 (scroll_bar_windows_size): Now size_t, not int.
2471 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2472 Check for overflow.
2473
2474 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2475 (map_tty_color) [!defined MSDOS]: Likewise.
2476
2477 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2478
2479 * coding.c: Remove vars that are set but not used.
2480 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2481 All callers changed.
2482 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2483 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2484 (decode_coding_charset): Remove vars that are set but not used.
2485
2486 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2487 that is set but not used.
2488
2489 * print.c (print_object): Remove var that is set but not used.
2490
2491 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2492 The gnulib version avoids calling malloc in the usual case,
2493 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2494 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2495 * filelock.c (current_lock_owner): Likewise.
2496 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2497 * sysdep.c: Include allocator.h, careadlinkat.h.
2498 (emacs_no_realloc_allocator): New static constant.
2499 (emacs_readlink): New function.
2500 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2501 ../lib/careadlinkat.h.
2502
2503 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2504
2505 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2506 first non-nil return value).
2507
2508 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2509
2510 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2511 if not defined (Bug#8403).
2512
2513 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2514
2515 * xdisp.c (display_count_lines): Remove parameter `start',
2516 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2517 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2518 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2519 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2520 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2521 and thereabouts. All callers changed.
2522 (get_per_char_metric): Remove parameter `f', unused since
2523 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2524
2525 2011-04-02 Jim Meyering <meyering@redhat.com>
2526
2527 do not dereference NULL upon failed strdup
2528 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2529 (ns_get_family): Likewise.
2530
2531 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2532
2533 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2534
2535 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2536
2537 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2538 later (Bug#8403).
2539
2540 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2541
2542 Add lexical binding.
2543
2544 * window.c (Ftemp_output_buffer_show): New fun.
2545 (Fsave_window_excursion):
2546 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2547
2548 * lread.c (lisp_file_lexically_bound_p): New function.
2549 (Fload): Bind Qlexical_binding.
2550 (readevalloop): Remove `evalfun' arg.
2551 Bind Qinternal_interpreter_environment.
2552 (Feval_buffer): Bind Qlexical_binding.
2553 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2554 Mark as dynamic.
2555 (syms_of_lread): Declare `lexical-binding'.
2556
2557 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2558
2559 * keyboard.c (eval_dyn): New fun.
2560 (menu_item_eval_property): Use it.
2561
2562 * image.c (parse_image_spec): Use Ffunctionp.
2563
2564 * fns.c (concat, mapcar1): Accept byte-code-functions.
2565
2566 * eval.c (Fsetq): Handle lexical vars.
2567 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2568 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2569 (FletX, Flet): Obey lexical binding.
2570 (Fcommandp): Handle closures.
2571 (Feval): New `lexical' arg.
2572 (eval_sub): New function extracted from Feval. Use it almost
2573 everywhere where Feval was used. Look up vars in lexical env.
2574 Handle closures.
2575 (Ffunctionp): Move from subr.el.
2576 (Ffuncall): Handle closures.
2577 (apply_lambda): Remove `eval_flags'.
2578 (funcall_lambda): Handle closures and new byte-code-functions.
2579 (Fspecial_variable_p): New function.
2580 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2581 but without exporting it to Lisp.
2582
2583 * doc.c (Fdocumentation, store_function_docstring):
2584 * data.c (Finteractive_form): Handle closures.
2585
2586 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2587 interactive spec.
2588
2589 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2590 New byte-codes.
2591 (exec_byte_code): New function extracted from Fbyte_code to handle new
2592 calling convention for byte-code-functions. Add new byte-codes.
2593
2594 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2595
2596 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2597
2598 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2599
2600 * xdisp.c (redisplay_internal): Fix prototype.
2601
2602 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2603
2604 * xdisp.c (SCROLL_LIMIT): New macro.
2605 (try_scrolling): Use it when setting scroll_limit.
2606 Limit scrolling to 100 screen lines.
2607 (redisplay_window): Even when falling back on "recentering",
2608 position point in the window according to scroll-conservatively,
2609 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2610
2611 (try_scrolling): When point is above the window, allow searching
2612 as far as scroll_max, or one screenful, to compute vertical
2613 distance from PT to the scroll margin position. This prevents
2614 try_scrolling from unnecessarily failing when
2615 scroll-conservatively is set to a value slightly larger than the
2616 window height. Clean up the case of PT below the margin at bottom
2617 of window: scroll_max can no longer be INT_MAX. When aggressive
2618 scrolling is in use, don't let point enter the opposite scroll
2619 margin as result of the scroll.
2620 (syms_of_xdisp) <scroll-conservatively>: Document the
2621 threshold of 100 lines for never-recentering scrolling.
2622
2623 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2624
2625 * dispextern.h (move_it_by_lines):
2626 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2627 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2628 (message_log_check_duplicate): Remove parameters `prev_bol' and
2629 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2630 (redisplay_internal): Remove parameter `preserve_echo_area',
2631 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2632
2633 * indent.c (Fvertical_motion):
2634 * window.c (window_scroll_pixel_based, Frecenter):
2635 Don't pass `need_y_p' to `move_it_by_lines'.
2636
2637 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2638
2639 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2640 steal a few bits to be more compact.
2641 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2642 Remove unneeded casts.
2643
2644 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2645
2646 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2647
2648 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2649 binding" message (bug#7967).
2650
2651 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2652
2653 Fix more problems found by GCC 4.6.0's static checks.
2654
2655 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2656 Remove unused local var.
2657
2658 * editfns.c (Fmessage_box): Remove unused local var.
2659
2660 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2661 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2662 Omit unused local vars.
2663 * window.c (shrink_windows): Omit unused local var.
2664 * menu.c (digest_single_submenu): Omit unused local var.
2665 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2666 Omit unused local var.
2667
2668 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2669 Don't assume string length fits in int.
2670 (keyremap_step, read_key_sequence): Use size_t for sizes.
2671 (read_key_sequence): Don't check last_real_key_start redundantly.
2672
2673 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2674 instead of alloca (Bug#8344).
2675
2676 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2677 (Fbacktrace_frame): Don't assume nframes fits in int.
2678
2679 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2680
2681 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2682 concerns.
2683
2684 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2685
2686 * cm.c (calccost): Turn while-do into do-while, for clarity.
2687
2688 * keyboard.c (syms_of_keyboard): Use the same style as later
2689 in this function when indexing through an array. This also
2690 works around GCC bug 48267.
2691
2692 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2693
2694 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2695
2696 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2697 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2698
2699 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2700 This avoids undefined behavior on integer overflow, and is a bit
2701 more convenient anyway since it is compared to a size_t variable.
2702
2703 Variadic C functions now count arguments with size_t, not int.
2704 This avoids an unnecessary limitation on 64-bit machines, which
2705 caused (substring ...) to crash on large vectors (Bug#8344).
2706 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2707 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2708 All variadic functions and their callers changed accordingly.
2709 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2710 * data.c (arith_driver, float_arith_driver): Likewise.
2711 * editfns.c (general_insert_function): Likewise.
2712 * eval.c (struct backtrace.nargs, interactive_p)
2713 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2714 (funcall_lambda, mark_backtrace): Likewise.
2715 * fns.c (concat): Likewise.
2716 * frame.c (x_set_frame_parameters): Likewise.
2717 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2718 0 if not found, not -1. All callers changed.
2719
2720 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2721 (stack_copy_size): Now size_t, not int.
2722 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2723
2724 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2725
2726 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2727 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2728 All callers changed.
2729
2730 * lisp.h (multibyte_char_to_unibyte):
2731 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2732 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2733 * character.h (CHAR_TO_BYTE8):
2734 * cmds.c (internal_self_insert):
2735 * editfns.c (general_insert_function):
2736 * keymap.c (push_key_description):
2737 * search.c (Freplace_match):
2738 * xdisp.c (message_dolog, set_message_1): All callers changed.
2739
2740 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2741
2742 * keyboard.c (safe_run_hook_funcall): New function.
2743 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2744 don't set the hook to nil, but remove the offending function instead.
2745 (Qcommand_hook_internal): Remove, unused.
2746 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2747 Vcommand_hook_internal.
2748
2749 * eval.c (enum run_hooks_condition): Remove.
2750 (funcall_nil, funcall_not): New functions.
2751 (run_hook_with_args): Call each function through a `funcall' argument.
2752 Remove `cond' argument, now redundant.
2753 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2754 (Frun_hook_with_args_until_failure): Adjust accordingly.
2755 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2756
2757 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2758
2759 * dispextern.h (string_buffer_position): Remove declaration.
2760
2761 * print.c (strout): Remove parameter `multibyte', unused since
2762 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2763
2764 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2765 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2766 All callers changed.
2767
2768 * w32.c (_wsa_errlist): Use braces for struct initializers.
2769
2770 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2771 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2772 All callers changed.
2773 (string_buffer_position): Likewise. Also, make static (it's never
2774 used outside xdisp.c).
2775 (cursor_row_p): Remove parameter `w', unused since
2776 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2777 (decode_mode_spec): Remove parameter `precision', introduced during
2778 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2779 All callers changed.
2780
2781 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2782
2783 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2784
2785 2011-03-27 Anders Lindgren <andlind@gmail.com>
2786
2787 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2788 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2789 (ns_update_auto_hide_menu_bar): New functions.
2790 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2791 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2792 ns_constrain_all_frames.
2793 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2794 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2795
2796 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2797
2798 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2799
2800 2011-03-27 Glenn Morris <rgm@gnu.org>
2801
2802 * syssignal.h: Replace RETSIGTYPE with void.
2803 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2804 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2805 Replace SIGTYPE with void everywhere.
2806 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2807 * s/template.h (SIGTYPE): Remove commented out definition.
2808
2809 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2810
2811 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2812 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2813
2814 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2815
2816 * w32.c (read_unc_volume): Use parameter `henum', instead of
2817 global variable `wget_enum_handle'.
2818
2819 * keymap.c (describe_vector): Remove parameters `indices' and
2820 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2821 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2822
2823 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2824
2825 * keyboard.c (timer_check): Remove parameter `do_it_now',
2826 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2827 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2828 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2829
2830 * keyboard.c (read_char):
2831 * w32menu.c (w32_menu_display_help):
2832 * xmenu.c (show_help_event, menu_help_callback):
2833 Adjust calls to `show_help_echo'.
2834
2835 * gtkutil.c (xg_maybe_add_timer):
2836 * keyboard.c (readable_events):
2837 * process.c (wait_reading_process_output):
2838 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2839
2840 * insdel.c (adjust_markers_gap_motion):
2841 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2842 (gap_left, gap_right): Don't call it.
2843
2844 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2845
2846 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2847 incurred during fontification.
2848
2849 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2850
2851 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2852 (DEFVAR_PER_BUFFER): Don't pass it.
2853
2854 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2855 (scrolling_window): Don't pass it.
2856
2857 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2858
2859 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2860
2861 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2862 and `suffix'.
2863 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2864 of variables specific to SELinux and computation of `encoded_absname'.
2865
2866 * image.c (XPutPixel): Remove unused variable `height'.
2867
2868 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2869
2870 * unexw32.c (get_section_info): Remove unused variable `section'.
2871
2872 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2873 (system_process_attributes): Remove unused variable `sess'.
2874 (sys_read): Remove unused variable `err'.
2875
2876 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2877 (w32_wnd_proc): Remove unused variable `isdead'.
2878 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2879 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2880 (x_create_tip_frame): Remove unused variable `tem'.
2881
2882 * w32inevt.c (w32_console_read_socket):
2883 Remove unused variable `no_events'.
2884
2885 * w32term.c (x_draw_composite_glyph_string_foreground):
2886 Remove unused variable `width'.
2887
2888 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2889
2890 * w32term.c (x_set_glyph_string_clipping):
2891 Don't pass uninitialized region to CombineRgn.
2892
2893 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2894
2895 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2896 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2897 (Fx_close_connection): Remove unused variable `i'.
2898
2899 * w32font.c (w32font_draw): Return number of glyphs.
2900 (w32font_open_internal): Remove unused variable `i'.
2901 (w32font_driver): Add missing initializer.
2902
2903 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2904 (fill_in_menu): Remove unused variable `items_added'.
2905
2906 * w32term.c (last_mouse_press_frame): Remove static global variable.
2907 (w32_clip_to_row): Remove unused variable `f'.
2908 (x_delete_terminal): Remove unused variable `i'.
2909
2910 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2911 (NOTHING): Remove unused static global variable.
2912 (uniscribe_check_otf): Remove unused variable `table'.
2913 (uniscribe_font_driver): Add missing initializers.
2914
2915 2011-03-23 Julien Danjou <julien@danjou.info>
2916
2917 * term.c (Fsuspend_tty, Fresume_tty):
2918 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2919 * window.c (temp_output_buffer_show):
2920 * insdel.c (signal_before_change):
2921 * frame.c (Fhandle_switch_frame):
2922 * fileio.c (Fdo_auto_save):
2923 * emacs.c (Fkill_emacs):
2924 * editfns.c (save_excursion_restore):
2925 * cmds.c (internal_self_insert):
2926 * callint.c (Fcall_interactively):
2927 * buffer.c (Fkill_all_local_variables):
2928 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2929 Use Frun_hooks.
2930 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2931 unconditionnaly since it does the check itself.
2932
2933 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2934
2935 Fix more problems found by GCC 4.5.2's static checks.
2936
2937 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2938 the first time through the loop, since we know p0 < p1 then.
2939 This also avoids a gcc -Wstrict-overflow warning.
2940
2941 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2942 leading to a memory leak, possible in functions like
2943 load_charset_map_from_file that can allocate an unbounded number
2944 of objects (Bug#8318).
2945
2946 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2947 that could (at least in theory) be that large.
2948
2949 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2950 This is less likely to overflow, and avoids undefined behavior if
2951 overflow does occur. All callers changed. Use strtoul to scan
2952 for the unsigned long integer.
2953 (pint2hrstr): Simplify and tune code slightly.
2954 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2955
2956 * scroll.c (do_scrolling): Work around GCC bug 48228.
2957 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2958
2959 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2960 This also avoids a warning with gcc -Wstrict-overflow.
2961 (validate_x_resource_name): Simplify count usage.
2962 This also avoids a warning with gcc -Wstrict-overflow.
2963
2964 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2965 fail (Bug#8306).
2966
2967 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2968
2969 * process.c (Fmake_network_process): Use socklen_t, not int,
2970 where POSIX says socklen_t is required in portable programs.
2971 This fixes a porting bug on hosts like 64-bit HP-UX, where
2972 socklen_t is wider than int (Bug#8277).
2973 (Fmake_network_process, server_accept_connection):
2974 (wait_reading_process_output, read_process_output):
2975 Likewise.
2976
2977 * process.c: Rename or move locals to avoid shadowing.
2978 (list_processes_1, Fmake_network_process):
2979 (read_process_output_error_handler, exec_sentinel_error_handler):
2980 Rename or move locals.
2981 (Fmake_network_process): Define label "retry_connect" only if needed.
2982 (Fnetwork_interface_info): Fix pointer signedness.
2983 (process_send_signal): Add cast to avoid pointer signedness problem.
2984 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2985 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2986
2987 Make tparam.h and terminfo.c consistent.
2988 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2989 Include tparam.h instead, since it declares them.
2990 * cm.h (PC): Remove extern decl; tparam.h now does this.
2991 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2992 * terminfo.c: Include tparam.h, to check interfaces.
2993 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2994 (tparam): Adjust signature to match interface in tparam.h;
2995 this removes some undefined behavior. Check that outstring and len
2996 are zero, which they always are with Emacs.
2997 * tparam.h (PC, BC, UP): New extern decls.
2998
2999 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3000 (xftfont_open): Rename locals to avoid shadowing.
3001
3002 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3003 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3004 (OTF_TAG_SYM): Omit macro if not needed.
3005 (ftfont_list): Remove unused local.
3006 (get_adstyle_property, ftfont_pattern_entity):
3007 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3008 Rename locals to avoid shadowing.
3009
3010 * xfont.c (xfont_list_family): Mark var as initialized.
3011
3012 * xml.c (make_dom): Now static.
3013
3014 * composite.c (composition_compute_stop_pos): Rename local to
3015 avoid shadowing.
3016 (composition_reseat_it): Remove unused locals.
3017 (find_automatic_composition, composition_adjust_point): Likewise.
3018 (composition_update_it): Mark var as initialized.
3019 (find_automatic_composition): Mark vars as initialized,
3020 with a FIXME (Bug#8290).
3021
3022 character.h: Rename locals to avoid shadowing.
3023 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3024 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3025 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3026 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3027 to avoid shadowing.
3028
3029 * textprop.c (property_change_between_p): Remove; unused.
3030
3031 * intervals.c (interval_start_pos): Now static.
3032
3033 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3034
3035 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3036 Rename locals to avoid shadowing.
3037
3038 * sound.c (wav_play, au_play, Fplay_sound_internal):
3039 Fix pointer signedness.
3040 (alsa_choose_format): Remove unused local var.
3041 (wav_play): Initialize a variable to 0, to prevent undefined
3042 behavior (Bug#8278).
3043
3044 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3045
3046 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3047
3048 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3049 clobbering (Bug#8298).
3050 * sysdep.c (sys_subshell): Likewise.
3051 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3052
3053 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3054 This should get cleaned up, so that child_setup has the
3055 same signature on all platforms.
3056
3057 * callproc.c (call_process_cleanup): Now static.
3058 (relocate_fd): Rename locals to avoid shadowing.
3059
3060 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3061
3062 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3063 not to be necessary, and produces flickering.
3064
3065 2011-03-20 Glenn Morris <rgm@gnu.org>
3066
3067 * config.in: Remove file.
3068
3069 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3070
3071 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3072 are now in src/globals.h.
3073 (syms_of_minibuf): Remove spurious & from previous change.
3074
3075 2011-03-20 Leo <sdl.web@gmail.com>
3076
3077 * minibuf.c (completing-read-function): New variable.
3078 (completing-read-default): Rename from completing-read.
3079 (completing-read): Call completing-read-function.
3080
3081 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3082
3083 * xfaces.c (Fx_load_color_file):
3084 Read color file from absolute filename (bug#8250).
3085
3086 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3087
3088 * makefile.w32-in: Update dependencies.
3089
3090 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3091
3092 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3093
3094 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 Fix more problems found by GCC 4.5.2's static checks.
3097
3098 * process.c (make_serial_process_unwind, send_process_trap):
3099 (sigchld_handler): Now static.
3100
3101 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3102 That way, the code declares only the vars that it needs.
3103 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3104 * s/cygwin.h (PTY_ITERATION): Likewise.
3105 * s/darwin.h (PTY_ITERATION): Likewise.
3106 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3107
3108 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3109 * process.c (allocate_pty): Don't declare stb unless it's needed.
3110
3111 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3112 (CONSTANTLIM): Remove; unused.
3113 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3114 Define only if needed.
3115
3116 * unexelf.c (unexec): Name an expression,
3117 to avoid gcc -Wbad-function-cast warning.
3118 Use a different way to cause a compilation error if anyone uses
3119 n rather than nn, a way that does not involve shadowing.
3120 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3121
3122 * deps.mk (unexalpha.o): Remove; unused.
3123
3124 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3125 * unexec.h: New file.
3126 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3127 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3128 Depend on unexec.h.
3129 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3130 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3131 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3132 Change as necessary to match prototype in unexec.h.
3133
3134 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3135 shadowing.
3136 (back_comment, skip_chars): Mark vars as initialized.
3137
3138 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3139 Rename locals to avoid shadowing.
3140
3141 * lread.c (read1): Rewrite so as not to use empty "else".
3142 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3143
3144 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3145
3146 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3147 warning when compiling print.c.
3148
3149 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3150 instead of using an uninitialized var.
3151 (font_sort_entities): Mark var as initialized.
3152
3153 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3154
3155 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3156 pointers to constants.
3157 (font_parse_fcname): Remove unused vars.
3158 (font_delete_unmatched): Now static.
3159 (font_get_spec): Remove; unused.
3160 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3161 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3162 Rename or move locals to avoid shadowing.
3163
3164 * fns.c (require_nesting_list, require_unwind): Now static.
3165 (Ffillarray): Rename locals to avoid shadowing.
3166
3167 * floatfns.c (domain_error2): Define only if needed.
3168 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3169
3170 * alloc.c (mark_backtrace): Move decl from here ...
3171 * lisp.h: ... to here, so that it can be checked.
3172
3173 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3174 (Fdefvar): Rewrite so as not to use empty "else".
3175 (lisp_indirect_variable): Name an expression,
3176 to avoid gcc -Wbad-function-cast warning.
3177 (Fdefvar): Rename locals to avoid shadowing.
3178
3179 * callint.c (quotify_arg, quotify_args): Now static.
3180 (Fcall_interactively): Rename locals to avoid shadowing.
3181 Use const pointer when appropriate.
3182
3183 * lisp.h (get_system_name, get_operating_system_release):
3184 Move decls here, to check interfaces.
3185 * process.c (get_operating_system_release): Move decl to lisp.h.
3186 * xrdb.c (get_system_name): Likewise.
3187 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3188 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3189 some of which prompt warnings from gcc -Wbad-function-cast.
3190 (Fformat_time_string, Fencode_time, Finsert_char):
3191 (Ftranslate_region_internal, Fformat):
3192 Rename or remove local vars to avoid shadowing.
3193 (Ftranslate_region_internal): Mark var as initialized.
3194
3195 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3196 avoid shadowing.
3197
3198 * lisp.h (eassert): Check that the argument compiles, even if
3199 ENABLE_CHECKING is not defined.
3200
3201 * data.c (Findirect_variable): Name an expression, to avoid
3202 gcc -Wbad-function-cast warning.
3203 (default_value, arithcompare, arith_driver, arith_error): Now static.
3204 (store_symval_forwarding): Rename local to avoid shadowing.
3205 (Fmake_variable_buffer_local, Fmake_local_variable):
3206 Mark variables as initialized.
3207 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3208
3209 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3210 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3211 Rename locals to avoid shadowing.
3212 (mark_stack): Move local variables into the #ifdef region where
3213 they're used.
3214 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3215 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3216 needed otherwise.
3217 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3218 (GC_STRING_CHARS): Remove; not used.
3219 (Fmemory_limit): Cast sbrk's returned value to char *.
3220
3221 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3222 avoids undefined behavior in theory.
3223
3224 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3225
3226 Use functions, not macros, for up- and down-casing (Bug#8254).
3227 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3228 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3229 to use the following functions instead of these macros.
3230 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3231 EMACS_INT, since callers assume the returned value fits in int.
3232 (upcase1): Likewise, for UPCASE_TABLE.
3233 (uppercasep, lowercasep, upcase): New static inline functions.
3234 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3235 the race-condition problem in the old DOWNCASE.
3236
3237 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3238 Rename locals to avoid shadowing.
3239 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3240 (regex_compile, re_search_2, re_match_2_internal):
3241 Remove unused local vars.
3242 (FREE_VAR): Rewrite so as not to use empty "else",
3243 which gcc can warn about.
3244 (regex_compile, re_match_2_internal): Mark locals as initialized.
3245 (RETALLOC_IF): Define only if needed.
3246 (WORDCHAR_P): Likewise. This one is never needed, but is used
3247 only in a comment talking about a compiler bug, so put inside
3248 the #if 0 of that comment.
3249 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3250 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3251 Remove; unused.
3252
3253 * search.c (boyer_moore): Rename locals to avoid shadowing.
3254 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3255 (PREV_CHAR_BOUNDARY): Likewise.
3256
3257 * search.c (simple_search): Remove unused var.
3258
3259 * dired.c (compile_pattern): Move decl from here ...
3260 * lisp.h: ... to here, so that it can be checked.
3261 (struct re_registers): New forward decl.
3262
3263 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3264
3265 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3266 All uses changed.
3267 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3268 Rename locals to avoid shadowing.
3269 (Fvertical_motion): Mark locals as initialized.
3270
3271 * casefiddle.c (casify_object, casify_region): Now static.
3272 (casify_region): Mark local as initialized.
3273
3274 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3275
3276 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3277 New macros, so that the caller can use some names other than
3278 gcpro1, gcpro2, etc.
3279 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3280 of the new macros.
3281 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3282 argument, for consistency with GCPRO2_VAR, etc: it is now the
3283 prefix of the variable, not the variable itself. All uses
3284 changed.
3285 * dired.c (directory_files_internal, file_name_completion):
3286 Rename locals to avoid shadowing.
3287
3288 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3289 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3290 dired.c's scmp function, had undefined behavior.
3291 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3292 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3293 * buffer.h: ... to here, because these macros use current_buffer,
3294 and the new implementation with inline functions needs to have
3295 current_buffer in scope now, rather than later when the macros
3296 are used.
3297 (downcase, upcase1): New static inline functions.
3298 (DOWNCASE, UPCASE1): Reimplement using these functions.
3299 This avoids undefined behavior in expressions like
3300 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3301 from race conditions in accessing the global variables
3302 case_temp1 and case_temp2.
3303 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3304 * lisp.h (case_temp1, case_temp2): Remove their decls.
3305 * character.h (ASCII_CHAR_P): Move from here ...
3306 * lisp.h: ... to here, so that the inline functions mentioned
3307 above can use them.
3308
3309 * dired.c (directory_files_internal_unwind): Now static.
3310
3311 * fileio.c (file_name_as_directory, directory_file_name):
3312 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3313 Now static.
3314 (file_name_as_directory): Use const pointers when appropriate.
3315 (Fexpand_file_name): Likewise. In particular, newdir might
3316 point at constant storage, so make it a const pointer.
3317 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3318 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3319 signedness issues.
3320 (Fset_file_times, Finsert_file_contents, auto_save_error):
3321 Rename locals to avoid shadowing.
3322
3323 * minibuf.c (choose_minibuf_frame_1): Now static.
3324 (Ftry_completion, Fall_completions): Rename or remove locals
3325 to avoid shadowing.
3326
3327 * marker.c (bytepos_to_charpos): Remove; unused.
3328
3329 * lisp.h (verify_bytepos, count_markers): New decls,
3330 so that gcc does not warn that these functions aren't declared.
3331
3332 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3333 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3334 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3335 (copy_text): Remove unused local var.
3336
3337 * filelock.c (within_one_second): Now static.
3338 (lock_file_1): Rename local to avoid shadowing.
3339
3340 * buffer.c (fix_overlays_before): Mark locals as initialized.
3341 (fix_start_end_in_overlays): Likewise. This function should be
3342 simplified by using pointers-to-pointers, but that's a different
3343 matter.
3344 (switch_to_buffer_1): Now static.
3345 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3346 (report_overlay_modification): Rename locals to avoid shadowing.
3347
3348 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3349 Fix pointer signedness issue.
3350 (sys_subshell): Mark local as volatile if checking for lint,
3351 to suppress a gcc -Wclobbered warning that does not seem to be right.
3352 (MAXPATHLEN): Define only if needed.
3353
3354 * process.c (serial_open, serial_configure): Move decls from here ...
3355 * systty.h: ... to here, so that they can be checked.
3356
3357 * fns.c (get_random, seed_random): Move extern decls from here ...
3358 * lisp.h: ... to here, so that they can be checked.
3359
3360 * sysdep.c (reset_io): Now static.
3361 (wait_for_termination_signal): Remove; unused.
3362
3363 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3364 (copy_keymap_item, append_key, push_text_char_description):
3365 Now static.
3366 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3367 (DENSE_TABLE_SIZE): Remove; unused.
3368 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3369 (describe_map_tree):
3370 Rename locals to avoid shadowing.
3371
3372 * keyboard.c: Declare functions static if they are not used elsewhere.
3373 (echo_char, echo_dash, cmd_error, top_level_2):
3374 (poll_for_input, handle_async_input): Now static.
3375 (read_char, kbd_buffer_get_event, make_lispy_position):
3376 (make_lispy_event, make_lispy_movement, apply_modifiers):
3377 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3378 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3379 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3380 (read_key_sequence, read_char): Mark locals as initialized.
3381 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3382
3383 * keyboard.h (make_ctrl_char): New decl.
3384 (mark_kboards): Move decl here ...
3385 * alloc.c (mark_kboards): ... from here.
3386
3387 * lisp.h (force_auto_save_soon): New decl.
3388
3389 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3390 (DEFINE_DUMMY_FUNCTION): New macro.
3391 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3392 Use it.
3393 (main): Add casts to avoid warnings
3394 if GCC considers string literals to be constants.
3395
3396 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3397
3398 * dbusbind.c: Pointer signedness fixes.
3399 (xd_signature, xd_append_arg, xd_initialize):
3400 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3401 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3402 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3403 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3404
3405 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3406 if GCC considers string literals to be constants.
3407 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3408
3409 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3410
3411 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3412 (print_preprocess, print_object): New macro to fix last change.
3413
3414 * print.c (print_preprocess): Don't forget font objects.
3415
3416 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3417
3418 * emacs.c (USAGE3): Doc fixes.
3419
3420 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3421
3422 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3423 structure.
3424
3425 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3426
3427 * lisp.h (VWindow_system, Qfile_name_history):
3428 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3429 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3430 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3431
3432 * w32select.c: Don't #include "keyboard.h".
3433 (run_protected): Add extern declaration for waiting_for_input.
3434
3435 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3436 * w32console.c (detect_input_pending, read_input_pending)
3437 (encode_terminal_code):
3438 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3439 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3440 (w32_system_caret_y, Qfile_name_history):
3441 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3442 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3443 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3444 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3445 * w32proc.c (Qlocal, report_file_error):
3446 * w32term.c (Vwindow_system, updating_frame):
3447 * w32uniscribe.c (initialized, uniscribe_font_driver):
3448 Remove unneeded extern declarations.
3449
3450 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3451
3452 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3453
3454 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3455
3456 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3457 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3458 These macros can no longer be used for assignment.
3459
3460 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3461 Assign struct members directly, instead of using BUF_BEGV etc.
3462 (record_buffer_markers, fetch_buffer_markers): New functions for
3463 recording and fetching special buffer markers.
3464 (set_buffer_internal_1, set_buffer_temp): Use them.
3465
3466 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3467
3468 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3469
3470 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3471 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3472
3473 * xdisp.c (hscroll_window_tree):
3474 (reconsider_clip_changes): Use PT instead of BUF_PT.
3475
3476 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3477
3478 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3479 $(EMACS_ROOT)/lib/intprops.h.
3480
3481 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3482
3483 Fix more problems found by GCC 4.5.2's static checks.
3484
3485 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3486 to unsigned char * to avoid compiler diagnostic.
3487 (xg_free_frame_widgets): Make it clear that a local variable is
3488 needed only if USE_GTK_TOOLTIP.
3489 (gdk_window_get_screen): Make it clear that this macro is needed
3490 only if USE_GTK_TOOLTIP.
3491 (int_gtk_range_get_value): New function, which avoids a diagnostic
3492 from gcc -Wbad-function-cast.
3493 (xg_set_toolkit_scroll_bar_thumb): Use it.
3494 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3495 diagnostic from gcc -Wbad-function-cast.
3496 (get_utf8_string, xg_get_file_with_chooser):
3497 Rename locals to avoid shadowing.
3498 (create_dialog): Move locals to avoid shadowing.
3499
3500 * xgselect.c (xg_select): Remove unused var.
3501
3502 * image.c (four_corners_best): Mark locals as initialized.
3503 (gif_load): Initialize transparent_p to zero (Bug#8238).
3504 Mark another local as initialized.
3505 (my_png_error, my_error_exit): Mark with NO_RETURN.
3506
3507 * image.c (clear_image_cache): Now static.
3508 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3509 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3510 (x_edge_detection): Remove unnecessary cast that
3511 gcc -Wbad-function-cast diagnoses.
3512 (gif_load): Fix pointer signedness.
3513 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3514 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3515
3516 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3517
3518 Improve quality of tests for time stamp overflow.
3519 For example, without this patch (encode-time 0 0 0 1 1
3520 1152921504606846976) returns the obviously-bogus value (-948597
3521 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3522 reports time overflow. See
3523 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3524 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3525 * editfns.c: Include limits.h and intprops.h.
3526 (TIME_T_MIN, TIME_T_MAX): New macros.
3527 (time_overflow): Move earlier, to before first use.
3528 (hi_time, lo_time): New functions, for an accurate test for
3529 out-of-range times.
3530 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3531 (Fget_internal_run_time): Don't assume time_t fits in int.
3532 (make_time): Use list2 instead of Fcons twice.
3533 (Fdecode_time): More accurate test for out-of-range times.
3534 (check_tm_member): New function.
3535 (Fencode_time): Use it, to test for out-of-range times.
3536 (lisp_time_argument): Don't rely on undefined left-shift and
3537 right-shift behavior when checking for time stamp overflow.
3538
3539 * editfns.c (time_overflow): New function, refactoring common code.
3540 (Fformat_time_string, Fdecode_time, Fencode_time):
3541 (Fcurrent_time_string): Use it.
3542
3543 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3544 * dired.c (make_time): Move to ...
3545 * editfns.c (make_time): ... here.
3546 * systime.h: Note the move.
3547
3548 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3549
3550 * fringe.c (update_window_fringes): Remove unused variables.
3551
3552 * unexmacosx.c (copy_data_segment): Also copy __got section.
3553 (Bug#8223)
3554
3555 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3556
3557 * termcap.c [MSDOS]: Include "msdos.h".
3558 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3559 Constify `char *' arguments and their references according to
3560 prototypes in tparam.h.
3561
3562 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3563
3564 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3565 Adapt all references accordingly.
3566
3567 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3568
3569 2011-03-11 Tom Tromey <tromey@redhat.com>
3570
3571 * buffer.c (syms_of_buffer): Remove obsolete comment.
3572
3573 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3574
3575 * termhooks.h (encode_terminal_code): Declare prototype.
3576
3577 * msdos.c (encode_terminal_code): Don't declare prototype.
3578
3579 * term.c (encode_terminal_code): Now external again, used by
3580 w32console.c and msdos.c.
3581
3582 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3583 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3584
3585 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3586
3587 Fix some minor problems found by GCC 4.5.2's static checks.
3588
3589 * fringe.c (update_window_fringes): Mark locals as initialized
3590 (Bug#8227).
3591 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3592
3593 * alloc.c (mark_fringe_data): Move decl from here ...
3594 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3595 to check its interface.
3596 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3597
3598 * fontset.c (free_realized_fontset): Now static.
3599 (Fset_fontset_font): Rename local to avoid shadowing.
3600 (fontset_font): Mark local as initialized.
3601 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3602
3603 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3604
3605 * xselect.c (x_disown_buffer_selections): Remove; not used.
3606 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3607 (x_own_selection, Fx_disown_selection_internal): Rename locals
3608 to avoid shadowing.
3609 (x_handle_dnd_message): Remove local to avoid shadowing.
3610
3611 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3612 so that the caller can use some name other than gcpro1.
3613 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3614 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3615 (Fx_backspace_delete_keys_p):
3616 Use them to avoid shadowing, and rename vars to avoid shadowing.
3617 (x_decode_color, x_set_name, x_window): Now static.
3618 (Fx_create_frame): Add braces to silence GCC warning.
3619 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3620 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3621 Remove unused locals.
3622 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3623 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3624 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3625 macros.
3626
3627 * xterm.h (x_mouse_leave): New decl.
3628
3629 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3630 Remove unused functions.
3631 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3632 (x_calc_absolute_position): Now static.
3633 (XTread_socket): Don't define label "out" unless it's used.
3634 Don't declare local "event" unless it's used.
3635 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3636 unless they are used.
3637 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3638 (x_fatal_error_signal): Remove; not used.
3639 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3640 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3641 (x_error_catcher, x_connection_closed, x_error_handler):
3642 (x_error_quitter, xembed_send_message, x_iconify_frame):
3643 (my_log_handler): Rename locals to avoid shadowing.
3644 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3645 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3646
3647 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3648 Rename or move locals to avoid shadowing.
3649 (tty_defined_color, merge_face_heights): Now static.
3650 (free_realized_faces_for_fontset): Remove; not used.
3651 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3652 does not deduce is never used uninitialized.
3653 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3654 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3655
3656 * terminal.c (store_terminal_param): Now static.
3657
3658 * xmenu.c (menu_highlight_callback): Now static.
3659 (set_frame_menubar): Remove unused local.
3660 (xmenu_show): Rename parameter to avoid shadowing.
3661 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3662 since they might point to immutable storage.
3663 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3664 since it's unused otherwise.
3665
3666 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3667 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3668 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3669 avoids a gcc -Wuninitialized diagnostic.
3670 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3671 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3672 does not deduce are never used uninitialized.
3673
3674 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3675
3676 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3677 * window.c (window_loop, size_window):
3678 (run_window_configuration_change_hook, enlarge_window): Likewise.
3679
3680 * window.c (display_buffer): Now static.
3681 (size_window): Mark variables that gcc -Wuninitialized
3682 does not deduce are never used uninitialized.
3683 * window.h (check_all_windows): New decl, to forestall
3684 gcc -Wmissing-prototypes diagnostic.
3685 * dispextern.h (bidi_dump_cached_states): Likewise.
3686
3687 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3688 shadowing.
3689 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3690 Include <limits.h>.
3691 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3692 and to avoid gcc -Wuninitialized warning.
3693 (load_charset_map): Mark variables that gcc -Wuninitialized
3694 does not deduce are never used uninitialized.
3695 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3696
3697 * coding.c (coding_set_source, coding_set_destination):
3698 Use "else { /* comment */ }" rather than "else /* comment */;"
3699 for clarity, and to avoid gcc -Wempty-body warning.
3700 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3701 a block, when the outer 'i' will do.
3702 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3703 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3704 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3705 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3706 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3707 Rename locals to avoid shadowing.
3708 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3709 * coding.c (emacs_mule_char, encode_invocation_designation):
3710 Now static, since they're not used elsewhere.
3711 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3712 (decode_coding_object, encode_coding_object, detect_coding_system):
3713 (decode_coding_emacs_mule): Mark variables that gcc
3714 -Wuninitialized does not deduce are never used uninitialized.
3715 (detect_coding_iso_2022): Initialize a local variable that might
3716 be used uninitialized. Leave a FIXME because it's not clear that
3717 this initialization is needed. (Bug#8211)
3718 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3719 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3720 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3721 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3722 Remove unused macros.
3723
3724 * category.c (hash_get_category_set): Remove unused local var.
3725 (copy_category_table): Now static, since it's not used elsewhere.
3726 * character.c (string_count_byte8): Likewise.
3727
3728 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3729 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3730
3731 * chartab.c (copy_sub_char_table): Now static, since it's not used
3732 elsewhere.
3733 (sub_char_table_ref_and_range, char_table_ref_and_range):
3734 Rename locals to avoid shadowing.
3735 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3736
3737 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3738 (BIDI_BOB): Remove unused macro.
3739
3740 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3741 deduce are never used uninitialized.
3742 * term.c (encode_terminal_code): Likewise.
3743
3744 * term.c (encode_terminal_code): Now static. Remove unused local.
3745
3746 * tparam.h: New file.
3747 * term.c, tparam.h: Include it.
3748 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3749 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3750 Move these decls to tparam.h, and make them agree with what
3751 is actually in tparam.c. The previous trick of using incompatible
3752 decls in different modules does not conform to the C standard.
3753 All callers of tparam changed to use tparam's actual API.
3754 * tparam.c (tparam1, tparam, tgoto):
3755 Use const pointers where appropriate.
3756
3757 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3758 * cm.h (struct cm): Likewise.
3759 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3760 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3761 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3762 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3763 (turn_on_face, init_tty): Likewise.
3764 * termchar.h (struct tty_display_info): Likewise.
3765
3766 * term.c (term_mouse_position): Rename local to avoid shadowing.
3767
3768 * alloc.c (mark_ttys): Move decl from here ...
3769 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3770
3771 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3772
3773 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3774
3775 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3776
3777 * search.c (compile_pattern_1): Remove argument regp, unused since
3778 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3779 (compile_pattern): Don't pass it.
3780
3781 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3782
3783 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3784 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3785 for ! HAVE_GTK3.
3786 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3787
3788 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3789
3790 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3791 gdk_window_get_screen, gdk_window_get_geometry,
3792 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3793 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3794 (xg_get_pixbuf_from_pixmap): New function.
3795 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3796 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3797 Call xg_get_pixbuf_from_pixmap instead of
3798 gdk_pixbuf_get_from_drawable.
3799 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3800 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3801 (xg_check_special_colors): Use GtkStyleContext and its functions
3802 for HAVE_GTK3.
3803 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3804 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3805 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3806 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3807 Call gtk_widget_get_preferred_size.
3808 (xg_frame_resized): gdk_window_get_geometry only takes 5
3809 parameters.
3810 (xg_win_to_widget, xg_event_is_for_menubar):
3811 Call gdk_x11_window_lookup_for_display.
3812 (xg_set_widget_bg): New function.
3813 (delete_cb): New function.
3814 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3815 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3816 (xg_set_background_color): Call xg_set_widget_bg.
3817 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3818 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3819 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3820 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3821 if ! HAVE_GTK3.
3822 (update_frame_tool_bar): Call gtk_widget_hide.
3823 (xg_initialize): Use GDK_KEY_g.
3824
3825 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3826 if ! HAVE_GTK3
3827 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3828
3829 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3830 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3831 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3832
3833 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3834
3835 * w32xfns.c (select_palette): Check success of RealizePalette against
3836 GDI_ERROR, not zero.
3837
3838 See ChangeLog.11 for earlier changes.
3839
3840 ;; Local Variables:
3841 ;; coding: utf-8
3842 ;; End:
3843
3844 Copyright (C) 2011 Free Software Foundation, Inc.
3845
3846 This file is part of GNU Emacs.
3847
3848 GNU Emacs is free software: you can redistribute it and/or modify
3849 it under the terms of the GNU General Public License as published by
3850 the Free Software Foundation, either version 3 of the License, or
3851 (at your option) any later version.
3852
3853 GNU Emacs is distributed in the hope that it will be useful,
3854 but WITHOUT ANY WARRANTY; without even the implied warranty of
3855 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3856 GNU General Public License for more details.
3857
3858 You should have received a copy of the GNU General Public License
3859 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.