Save and restore bidi cache when saving and restoring the iterator.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ed94e6d7
EZ
12011-07-03 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4
5 * dispextern.h (bidi_shelve_cache, bidi_unshelve_cache): Declare
6 prototypes.
7
8 * xdisp.c (SAVE_IT, RESTORE_IT): New macros.
9 (pos_visible_p, face_before_or_after_it_pos)
10 (back_to_previous_visible_line_start)
11 (move_it_in_display_line_to, move_it_in_display_line)
12 (move_it_to, move_it_vertically_backward, move_it_by_lines)
13 (try_scrolling, redisplay_window, display_line): Use them when
14 saving a temporary copy of the iterator and restoring it back.
15
a2eaa31d
EZ
162011-07-02 Eli Zaretskii <eliz@gnu.org>
17
6eec7596
EZ
18 * xdisp.c (reseat_1): Call bidi_init_it to resync the bidi
19 iterator with IT's position.
20 (handle_stop, back_to_previous_visible_line_start, reseat_1):
21 Reset the from_disp_prop_p flag.
22
23 * bidi.c (bidi_cache_search): Don't assume bidi_cache_last_idx is
24 always valid if bidi_cache_idx is valid.
25 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
26 is valid if it's going to be used.
27
a2eaa31d
EZ
28 * dispextern.h (struct iterator_stack_entry, struct it): New
29 member from_disp_prop_p.
30
31 * xdisp.c (push_it, pop_it): Save and restore from_disp_prop_p.
32 (handle_single_display_spec, push_display_prop): Set the
33 from_disp_prop_p flag.
34 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
35 (pop_it): Call iterate_out_of_display_property only if we are
36 popping after iteration over a string that came from a display
37 property. Fix a typo in popping stretch info. Add an assertion
38 for verifying that the iterator position is in sync with the bidi
39 iterator.
40 (handle_single_display_spec, get_overlay_strings_1)
41 (push_display_prop): Fix initialization of paragraph direction for
42 string when that of the parent object is not yet determined.
43
f3014ef5
EZ
442011-07-01 Eli Zaretskii <eliz@gnu.org>
45
46 * dispextern.h (struct bidi_string_data): New member `unibyte'.
47
48 * xdisp.c (handle_single_display_spec, next_overlay_string)
49 (get_overlay_strings_1, reseat_1, reseat_to_string)
50 (push_display_prop): Set up the `unibyte' member of bidi_it.string
51 correctly. Don't assume unibyte strings are not bidi-reordered.
52 (compute_display_string_pos)
53 (compute_display_string_end): Fix handling the case of C string.
54
55 * bidi.c (bidi_count_bytes, bidi_char_at_pos): Accept an
56 additional argument UNIBYTE, and support unibyte strings. All
57 callers changed.
58 (bidi_fetch_char): Support unibyte strings.
59
0c22566f
EZ
602011-06-25 Eli Zaretskii <eliz@gnu.org>
61
a1344e7d
EZ
62 * xdisp.c (set_iterator_to_next, get_visually_first_element): Use
63 it->bidi_it.string.schars rather than it->string_nchars when
64 testing whether we're beyond string end, because string_nchars is
65 zero for strings that come from overlays and display properties.
66
67 * bidi.c (bidi_cache_iterator_state): Fix a bug with testing
68 character positions against the cached range, when we use a
69 stacked cache.
70
71 * xdisp.c (push_it, pop_it): Save and restore it.
72
73 * dispextern.h (struct iterator_stack_entry): New member
74 paragraph_embedding.
75
0c22566f
EZ
76 * xdisp.c (handle_single_display_spec, next_overlay_string)
77 (get_overlay_strings_1, push_display_prop): Set up the bidi
78 iterator for displaying display or overlay strings.
79 (forward_to_next_line_start): Don't use the shortcut if
80 bidi-iterating.
81 (back_to_previous_visible_line_start): If handle_display_prop
82 pushed the iterator stack, restore the internal state of the bidi
83 iterator by calling bidi_pop_it same number of times.
84 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
85 and we are bidi-iterating, don't decrement the iterator position;
86 instead, set the first_elt flag in the bidi iterator, to produce
87 the same effect.
88 (reseat_1): Remove redundant setting of string_from_display_prop_p.
89 (push_display_prop): xassert that we are iterating a buffer.
90
91 * bidi.c (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
92
932011-06-24 Eli Zaretskii <eliz@gnu.org>
94
95 * xdisp.c (push_it, pop_it): Save and restore the state of the
96 bidi iterator. Save and restore the bidi_p flag.
97 (pop_it): Iterate out of display property for string iteration as
98 well.
99 (iterate_out_of_display_property): Support iteration over strings.
100 (handle_single_display_spec): Set up it->bidi_it for iteration
101 over a display string, and call bidi_init_it.
102
103 * dispextern.h (struct iterator_stack_entry): New member bidi_p.
104 (struct it): Member bidi_p is now a bit field 1 bit wide.
105
58b9f433
EZ
1062011-06-23 Eli Zaretskii <eliz@gnu.org>
107
108 * dispextern.h (bidi_push_it, bidi_pop_it): Add prototypes.
109
110 * bidi.c (bidi_push_it, bidi_pop_it): New functions.
111 (bidi_initialize): Initialize the bidi cache start stack pointer.
112 (bidi_cache_ensure_space): New function, refactored from part of
113 bidi_cache_iterator_state.
114
40eb66c4
EZ
1152011-06-18 Eli Zaretskii <eliz@gnu.org>
116
acb28818
EZ
117 * xdisp.c (tool_bar_lines_needed, redisplay_tool_bar)
118 (display_menu_bar): Force left-to-right direction. Add a FIXME
119 comment for making that be controlled by a user option.
120
121 * bidi.c (bidi_move_to_visually_next): GCPRO the Lisp string we
122 are iterating.
123
ca3122a0
EZ
124 * term.c (produce_glyphs): Add IT_GLYPHLESS to the values of
125 it->what accepted by the xassert. Fixes a gratuitous crash in an
126 Emacs built with -DXASSERTS.
127
cc7245e4
EZ
128 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
129 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
130 and vector-like objects.
131
4d3a8bb4 132 * xdisp.c (face_before_or_after_it_pos): Support bidi iteration.
40eb66c4
EZ
133 (next_element_from_c_string): Handle the case of the first string
134 character that is not the first one in the visual order.
1ace7267
EZ
135 (get_visually_first_element): New function, refactored from common
136 parts of next_element_from_buffer, next_element_from_string, and
137 next_element_from_c_string.
40eb66c4 138
578b494e
EZ
1392011-06-16 Eli Zaretskii <eliz@gnu.org>
140
141 * xdisp.c (init_iterator): Don't initialize it->bidi_p for strings
142 here.
143 (reseat_to_string): Initialize it->bidi_p for strings here.
144 (next_element_from_string, next_element_from_c_string)
145 (next_element_from_buffer): Add xassert's for correspondence
146 between IT's object being iterated and it->bidi_it.string
147 structure.
148
149 * bidi.c (bidi_level_of_next_char): Fix the logic for looking up
150 the sentinel state in the cache.
151
9f257352
EZ
1522011-06-13 Eli Zaretskii <eliz@gnu.org>
153
154 * xdisp.c (compute_display_string_pos)
155 (compute_display_string_end, reseat_to_string): Don't assume
156 it->bidi_it.string.s always points to string.lstring's data.
157
158 * bidi.c (bidi_fetch_char, bidi_paragraph_init)
159 (bidi_resolve_explicit_1, bidi_resolve_explicit)
160 (bidi_resolve_weak, bidi_level_of_next_char): Don't assume
161 string.s always points to string.lstring's data.
162
f23590cc
EZ
1632011-06-11 Eli Zaretskii <eliz@gnu.org>
164
165 * xdisp.c (set_iterator_to_next): Advance string position
166 correctly when padding it with blanks.
167
4b988f8b
EZ
1682011-06-11 Eli Zaretskii <eliz@gnu.org>
169
170 * xdisp.c (next_element_from_buffer): Improve commentary for when
171 the iterator is before prev_stop.
34c48e57
EZ
172 (init_iterator): Initialize bidi_p from the default value of
173 bidi-display-reordering, not from buffer-local value. Use the
174 buffer-local value only if initializing for buffer iteration.
175 (handle_invisible_prop): Support invisible properties on strings
176 that are being bidi-reordered.
177 (reseat_to_string): Enable bidi-related code.
178 (set_iterator_to_next): Support bidi reordering of C strings and
179 Lisp strings.
180 (next_element_from_string): Support bidi reordering of Lisp
181 strings.
182 (handle_stop_backwards): Support Lisp strings as well.
183 (display_mode_line, display_mode_element): Temporarily force L2R
184 paragraph direction.
185 (display_string): Support display of R2L glyph rows. Use
186 IT_STRING_CHARPOS when displaying from a Lisp string.
4b988f8b 187
9f4ef500
EZ
1882011-06-10 Eli Zaretskii <eliz@gnu.org>
189
190 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
191 itb.string.lstring.
192 (compute_display_string_pos, compute_display_string_end):
193 Fix calculation of the object to scan. Fixes an error when using
194 arrow keys.
195 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
196 base_level_stop; instead, set base_level_stop to BEGV. Fixes
197 crashes in vertical-motion.
198
6db161be
EZ
1992011-06-09 Eli Zaretskii <eliz@gnu.org>
200
201 * xdisp.c (compute_display_string_pos): First arg is now struct
202 `text_pos *'; all callers changed. Support display properties on
203 Lisp strings.
204 (compute_display_string_end): Support display properties on Lisp
205 strings.
206 (init_iterator, reseat_1, reseat_to_string): Initialize the
207 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
208 when iterating on a string not from display properties).
209
210 * bidi.c (bidi_fetch_char): Support strings with display
211 properties.
212
213 * dispextern.h (struct bidi_string_data): New member bufpos.
214 (compute_display_string_pos): Update prototype.
215
bb269206
EZ
2162011-06-09 Eli Zaretskii <eliz@gnu.org>
217
218 * bidi.c (bidi_level_of_next_char): Allow the sentinel "position"
219 to pass the test for valid cached positions.
220
221 * xdisp.c (init_iterator): Call bidi_init_it only of a valid
222 buffer position was specified. Initialize paragraph_embedding to
223 L2R.
224 (reseat_to_string): Initialize the bidi iterator (for now ifdef'ed
225 out).
226 (display_string): If we need to ignore text properties of
227 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
228 original value of -1 will not work with bidi.)
229
230 * dispextern.h (struct bidi_string_data): New member lstring.
231
d9334cb7
EZ
2322011-06-09 Eli Zaretskii <eliz@gnu.org>
233
234 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
235 itb.string.s to NULL (avoids a crash in bidi_paragraph_init).
236
87e67904
EZ
2372011-06-08 Eli Zaretskii <eliz@gnu.org>
238
239 * bidi.c (bidi_paragraph_info): Delete unused struct.
240 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
241 (bidi_cache_start): New variable.
242 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
243 to zero.
244 (bidi_cache_fetch_state, bidi_cache_search)
245 (bidi_cache_find_level_change, bidi_cache_iterator_state)
246 (bidi_cache_find, bidi_peek_at_next_level)
247 (bidi_level_of_next_char, bidi_find_other_level_edge)
248 (bidi_move_to_visually_next): Compare cache index with
249 bidi_cache_start rather than with zero.
250 (bidi_fetch_char): Accept new argument STRING; all callers
251 changed. Support iteration over a string.
252 (bidi_paragraph_init, bidi_resolve_explicit_1)
253 (bidi_resolve_explicit, bidi_resolve_weak)
254 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
255 iteration over a string.
256 (bidi_set_sor_type, bidi_resolve_explicit_1)
257 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
258 can now be zero (for strings); special values 0 and -1 were
259 changed to -1 and -2, respectively.
260 (bidi_char_at_pos): New function.
261 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
262 Call it instead of FETCH_MULTIBYTE_CHAR.
263 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
264 initialized to valid values.
265 (bidi_init_it): Don't initialize charpos and bytepos with invalid
266 values.
267
268 * xdisp.c (compute_display_string_pos)
269 (compute_display_string_end): Accept additional argument STRING.
270 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
271 (reseat_to_string): Initialize bidi_it->string.s and
272 bidi_it->string.schars.
273
274 * dispextern.h (struct bidi_string_data): New structure.
275 (struct bidi_it): New member `string'. Make flag members be 1-bit
276 fields, and put them last in the struct.
277 (compute_display_string_pos, compute_display_string_end): Update
278 prototypes.
279
9d68c2a9
EZ
2802011-06-04 Eli Zaretskii <eliz@gnu.org>
281
282 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
283
57f97249
EZ
2842011-06-03 Eli Zaretskii <eliz@gnu.org>
285
286 * bidi.c (bidi_fetch_char_advance): Remove unused and
287 unimplemented function.
288
c40e2fb2
EZ
2892011-05-28 Eli Zaretskii <eliz@gnu.org>
290
0e14fe90
EZ
291 * xdisp.c (set_cursor_from_row): Set start and stop points
292 according to the row's direction when priming the loop that looks
293 for the glyph on which to display cursor.
294 (single_display_spec_intangible_p): Function deleted.
295 (display_prop_intangible_p): Reimplement to call
296 handle_display_spec instead of single_display_spec_intangible_p.
297 Accept 3 additional arguments needed by handle_display_spec. This
298 fixes incorrect cursor motion across display property with complex
299 values: lists, `(when COND...)' forms, etc.
300 (single_display_spec_string_p): Support property values that are
301 lists with the argument STRING its top-level element.
302 (display_prop_string_p): Fix the condition for processing a
303 property that is a list to be consistent with handle_display_spec.
304
305 * keyboard.c (adjust_point_for_property): Adjust the call to
306 display_prop_intangible_p to its new signature.
307
308 * dispextern.h (display_prop_intangible_p): Adjust prototype.
c40e2fb2 309
fc6f18ce
EZ
3102011-05-21 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (handle_display_spec): New function, refactored from the
313 last portion of handle_display_prop.
314 (compute_display_string_pos): Accept additional argument
315 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
316 value of a `display' property is a "replacing spec".
317 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
318 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
319 the display property, but just return a value indicating whether
320 the display property will replace the characters it covers.
321 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
322 frame_window_p members of struct bidi_it.
323
324 * bidi.c (bidi_fetch_char): Accept additional argument
325 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
326 callers changed.
327 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
328 it to initialize the frame_window_p member of struct bidi_it.
329
330 * dispextern.h (struct bidi_it): New member frame_window_p.
331 (bidi_init_it, compute_display_string_pos): Update prototypes.
332
102ebb00
EZ
3332011-05-14 Eli Zaretskii <eliz@gnu.org>
334
7b600102
EZ
335 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
336 (compute_display_string_end): New function.
683a44f7
EZ
337 (push_it): Accept second argument POSITION, where pop_it should
338 jump to continue iteration.
7b600102
EZ
339
340 * dispextern.h (compute_display_string_end): Declare prototype.
341
342 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
343 (bidi_fetch_char): Implement support for runs of characters
344 covered by display strings.
345
102ebb00 346 * bidi.c (bidi_fetch_char): Accept also character position
7b600102
EZ
347 corresponding to BYTEPOS. DISP_POS is now a character position,
348 not a byte position. All callers changed.
102ebb00
EZ
349 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
350 (bidi_resolve_explicit, bidi_resolve_weak)
351 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
352 bidi_it->nchars is non-positive.
353 (bidi_level_of_next_char): Don't try to lookup the cache for the
354 next/previous character if nothing is cached there yet, or if we
355 were just reseat()'ed to a new position.
356 (bidi_paragraph_init, bidi_resolve_explicit_1)
357 (bidi_level_of_next_char): Fix arguments in the calls to
358 bidi_fetch_char.
359
182ce2d2
EZ
3602011-05-10 Eli Zaretskii <eliz@gnu.org>
361
362 * xdisp.c (compute_display_string_pos): New function.
363 (reseat_1): Initialize bidi_it.disp_pos.
364
365 * bidi.c (bidi_copy_it): Use offsetof.
366 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
367 (bidi_cache_search, bidi_cache_iterator_state)
368 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
369 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
370 character positions inside a run of characters covered by a
371 display string.
372 (bidi_paragraph_init, bidi_resolve_explicit_1)
373 (bidi_level_of_next_char): Call bidi_fetch_char and
374 bidi_fetch_char_advance instead of FETCH_CHAR and
375 FETCH_CHAR_ADVANCE.
376 (bidi_init_it): Initialize new members.
377 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
378 definitions.
379 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
380 instead of using explicit *_CHAR codes.
381 (bidi_resolve_explicit, bidi_resolve_weak): Use
382 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
383 bidirectional text is supported only in multibyte buffers.
384
385 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
386 ch_len is now EMACS_INT.
387 (compute_display_string_pos): Declare prototype.
388
57679c86
AS
3892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
390
391 * w32menu.c (set_frame_menubar): Fix submenu allocation.
392
888c9e86
EZ
3932011-05-07 Eli Zaretskii <eliz@gnu.org>
394
b0512a1d
EZ
395 * w32console.c (Fset_screen_color): Doc fix.
396 (Fget_screen_color): New function.
397 (syms_of_ntterm): Defsubr it.
398
888c9e86
EZ
399 * callproc.c (call_process_cleanup): Don't close and unlink the
400 temporary file if Fcall_process didn't create it in the first
401 place.
402 (Fcall_process): Don't create tempfile if stdout of the child
403 process will be redirected to a file specified with `:file'.
404 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
405 cue to call_process_cleanup not to close that handle.
406
4d3fcc8e
BK
4072011-05-07 Ben Key <bkey76@gmail.com>
408
409 * makefile.w32-in: The bootstrap-temacs rule now makes use of
410 one of two shell specific rules, either bootstrap-temacs-CMD or
411 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
412 to the previous implementation of the bootstrap-temacs rule.
413 The bootstrap-temacs-CMD rule is similar to the previous
414 implementation of the bootstrap-temacs rule except that it
415 makes use of the ESC_CFLAGS variable instead of the CFLAGS
416 variable.
417
418 These changes, along with some changes to nt/configure.bat,
419 nt/gmake.defs, and nt/nmake.defs, are required to extend my
420 earlier fix to add support for --cflags and --ldflags options
421 that include quotes so that it works whether make uses cmd or
422 sh as the shell.
423
b4289b64
MA
4242011-05-06 Michael Albinus <michael.albinus@gmx.de>
425
426 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
427 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
428 is a constant.
429 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
430 a string. Handle both cases.
431 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
432 (Fdbus_register_method): Use Qinvalid_function.
433
af4c0e28
JB
4342011-05-06 Juanma Barranquero <lekktu@gmail.com>
435
436 * makefile.w32-in: Update dependencies.
437 (LISP_H): Add inttypes.h and stdin.h.
438 (PROCESS_H): Add unistd.h.
439
c51453d9
EZ
4402011-05-06 Eli Zaretskii <eliz@gnu.org>
441
442 * lread.c: Include limits.h (fixes the MS-Windows build broken by
443 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
444
8ff0ac3c 4452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 446
4c4b566b
PE
447 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
448
aab2b9b5
PE
449 * term.c (vfatal): Remove stray call to va_end.
450 It's not needed and the C Standard doesn't allow it here anyway.
451
c378da0b
PE
452 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
453 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
454
288b08c7
PE
455 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
456 bytes.
457
e3601888
PE
458 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
459
db6c0e74
PE
460 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
461
dd5963ea
PE
462 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
463
88c9450f
PE
464 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
465
2f9442b8
PE
466 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
467
c032b5f8
PE
468 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
469 * charset.c (Fdefine_charset_internal): Don't initialize
470 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 471 32-bit int (Bug#8600).
a108c10b
PE
472
473 * lread.c (read_integer): Be more consistent with string-to-number.
474 Use string_to_number to do the actual conversion; this avoids
475 rounding errors and fixes some other screwups. Without this fix,
476 for example, #x1fffffffffffffff was misread as -2305843009213693952.
477 (digit_to_number): Move earlier, for benefit of read_integer.
478 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 479 not a digit in any supported base. (Bug#8602)
a108c10b 480
ad5f9eea
PE
481 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
482
aec1708a
PE
483 * dispnew.c (scrolling_window): Return 1 if we scrolled,
484 to match comment at start of function. This also removes a
485 GCC warning about overflow in a 32+64-bit port.
486
47be4ab5
PE
487 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
488
371cac43
PE
489 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
490 Reported by Stefan Monnier in
491 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
492 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
493 SYMBOLP-guarded XSYMBOL, not XPNTR.
494
d01a7826
PE
495 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
496 (EMACS_UINTPTR): Likewise, with uintptr_t.
497
7fd47d5c
PE
498 * lisp.h: Prefer 64-bit EMACS_INT if available.
499 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
500 on 32-bit hosts that have 64-bit int, so that they can access
501 large files.
122b0c86
PE
502 However, temporarily disable this change unless the temporary
503 symbol WIDE_EMACS_INT is defined.
7fd47d5c 504
8727937b
PE
505 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
506
8ac068ac
PE
507 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
508 This removes an assumption that EMACS_INT and long are the same
509 width as pointers. The assumption is true for Emacs porting targets
510 now, but we want to make other targets possible.
511 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
512 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
513 In the rest of the code, change types of integers that hold casted
514 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
515 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
516 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
517 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
518 No need to cast type when ORing.
519 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
520 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
521 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
522 assume EMACS_INT is the same width as char *.
523 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
524 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
525 Remove no-longer-needed casts.
526 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
527 (xg_tool_bar_help_callback, xg_make_tool_item):
528 Use EMACS_INTPTR to hold an integer
529 that will be cast to void *; this can avoid a GCC warning
530 if EMACS_INT is not the same width as void *.
531 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
532 * xdisp.c (display_echo_area_1, resize_mini_window_1):
533 (current_message_1, set_message_1):
534 Use a local to convert to proper width without a cast.
535 * xmenu.c (dialog_selection_callback): Likewise.
536
ede49d71
PE
537 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
538 Also, don't assume VALBITS / RAND_BITS is less than 5,
539 and don't rely on undefined behavior when shifting a 1 left into
540 the sign bit.
541 * lisp.h (get_random): Change signature to match.
542
2f30ecd0
PE
543 * lread.c (hash_string): Use size_t, not int, for hash computation.
544 Normally we prefer signed values; but hashing is special, because
545 it's better to use unsigned division on hash table sizes so that
546 the remainder is nonnegative. Also, size_t is the natural width
547 for hashing into memory. The previous code used 'int', which doesn't
548 retain enough info to hash well into very large tables.
549 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
550
2a866e7b
PE
551 * dbusbind.c: Don't possibly lose pointer info when converting.
552 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
553 Use XPNTR rather than XHASH, so that the high-order bits of
554 the pointer aren't lost when converting through void *.
555
51639eac
PE
556 * eval.c (Fautoload): Don't double-shift a pointer.
557
92394119
PE
558 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
559
dbdb9a7c
JB
5602011-05-06 Juanma Barranquero <lekktu@gmail.com>
561
562 * gnutls.c (DEF_GNUTLS_FN):
563 * image.c (DEF_IMGLIB_FN): Make function pointers static.
564
db7a0b4f
AS
5652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
566
567 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
568 marker. (Bug#8610)
569
f7ff1b0f 5702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
571
572 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
573 New version that can reserve upto 2GB of heap space.
574
f7ff1b0f 5752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
576
577 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
578
639c109b
TZ
5792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
580
581 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
582 `gnutls_certificate_set_x509_key_file'.
583
d2127135
JB
5842011-05-05 Juanma Barranquero <lekktu@gmail.com>
585
586 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
587 Update dependencies.
588
e968f4f3
JB
5892011-05-04 Juanma Barranquero <lekktu@gmail.com>
590
591 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
592 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
593 Remove unused parameter `fildes'.
594 * process.c (read_process_output, send_process): Don't pass it.
595
84d358f0
JB
5962011-05-04 Juanma Barranquero <lekktu@gmail.com>
597
598 Fix previous change: the library cache is defined in w32.c.
599 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
600 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
601
0898ca10
JB
6022011-05-04 Juanma Barranquero <lekktu@gmail.com>
603
604 Implement dynamic loading of GnuTLS on Windows.
605
606 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
607 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
608 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
609 Declare.
610
611 * gnutls.c (Qgnutls_dll): Define.
612 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
613 (gnutls_*): Declare function pointers.
614 (init_gnutls_functions): New function to initialize function pointers.
615 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
616 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
617 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
618 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
619 (emacs_gnutls_write, emacs_gnutls_read)
620 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
621 (Fgnutls_available_p): New function.
622 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
623 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
624 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
625
626 * image.c: Include w32.h.
627 (Vimage_type_cache): Delete.
628 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
629 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
630 (w32_delayed_load): Move to w32.c.
631
632 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
633
634 * w32.c (QCloaded_from, Vlibrary_cache): Define.
635 (w32_delayed_load): Move from image.c. When loading a library, record
636 its filename in the :loaded-from property of the library id.
637 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
638 Initialize and staticpro them.
639 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
640
641 * process.c: Include lisp.h before w32.h, not after.
642 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
643 instead of gnutls_record_check_pending.
644
645 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
646
ff4de4aa
TZ
6472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
648
649 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
650 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
651 as passed in.
652
abe95abb
JD
6532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
654
655 * xterm.c (x_set_frame_alpha): Do not set property on anything
656 else than FRAME_X_OUTER_WINDOW (Bug#8608).
657
e16e55d4
JB
6582011-05-02 Juanma Barranquero <lekktu@gmail.com>
659
660 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
661
bafcf6a5
JB
6622011-05-02 Juanma Barranquero <lekktu@gmail.com>
663
664 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
665 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
666 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
667 (gnutls_global_initialized, Qgnutls_bootprop_priority)
668 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
669 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
670 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
671 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
672 (Qgnutls_bootprop_callbacks_verify): Make static.
673
e7a6747f
AS
6742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
675
19ed11ba
AS
676 * callproc.c: Indentation fixup.
677
e7a6747f
AS
678 * sysdep.c (wait_for_termination_1): Make static.
679 (wait_for_termination, interruptible_wait_for_termination): Move
680 after wait_for_termination_1.
681
1ef14cb4
LMI
6822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
683
684 * sysdep.c (interruptible_wait_for_termination): New function
685 which is like wait_for_termination, but allows keyboard
686 interruptions.
687
688 * callproc.c (Fcall_process): Add (:file "file") as an option for
689 the STDOUT buffer.
690 (Fcall_process_region): Ditto.
691
330d880c
EZ
6922011-04-30 Eli Zaretskii <eliz@gnu.org>
693
8db90b73
EZ
694 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
695 rather than `XVECTOR (FOO)->size'.
696
330d880c
EZ
697 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
698 inttypes.h, as a gnulib replacement is used if it not available in
699 system headers.
700
15cbd324
EZ
7012011-04-21 Eli Zaretskii <eliz@gnu.org>
702
703 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
704 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
705 of MOST_POSITIVE_FIXNUM. (Bug#8528)
706
707 * coding.c (coding_alloc_by_realloc): Error out if destination
708 will grow beyond MOST_POSITIVE_FIXNUM.
709 (decode_coding_emacs_mule): Abort if there isn't enough place in
710 charbuf for the composition carryover bytes. Reserve an extra
711 space for up to 2 characters produced in a loop.
712 (decode_coding_iso_2022): Abort if there isn't enough place in
713 charbuf for the composition carryover bytes.
714
7152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 716
ae940cca
EZ
717 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
718 aborting when %lld or %lll format is passed.
719 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
720 %llo or %llx format is passed. (Bug#8545)
721
03ab8921
EZ
722 * window.c (window_scroll_line_based): Use a marker instead of
723 simple variables to record original value of point. (Bug#7952)
724
afda1437
EZ
725 * doprnt.c (doprnt): Fix the case where a multibyte sequence
726 produced by %s or %c overflows available buffer space. (Bug#8545)
727
f76dee0c
PE
7282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
729
730 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 731 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 732
fdc5744d
JB
7332011-04-28 Juanma Barranquero <lekktu@gmail.com>
734
735 * w32.c (init_environment): Warn about defaulting HOME to C:\.
736
638f053a
JB
7372011-04-28 Juanma Barranquero <lekktu@gmail.com>
738
739 * keyboard.c (Qdelayed_warnings_hook): Define.
740 (command_loop_1): Run `delayed-warnings-hook'
741 if Vdelayed_warnings_list is non-nil.
742 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
743 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
744
d178f871
EZ
7452011-04-28 Eli Zaretskii <eliz@gnu.org>
746
747 * doprnt.c (doprnt): Don't return value smaller than the buffer
748 size if the message was truncated. (Bug#8545).
749
b124fd93
JB
7502011-04-28 Juanma Barranquero <lekktu@gmail.com>
751
752 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
753 (Fx_window_property): #if-0 the whole functions, not just the bodies.
754
e810457d
PE
7552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
756
757 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
758
ea51cceb
JB
7592011-04-27 Juanma Barranquero <lekktu@gmail.com>
760
761 * makefile.w32-in: Update dependencies.
762
94dcfacf
EZ
7632011-04-27 Eli Zaretskii <eliz@gnu.org>
764
765 Improve `doprnt' and its usage. (Bug#8545)
766 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
767 `format_end'. Remove support for %l as a conversion specifier.
768 Don't use xrealloc. Improve diagnostics when the %l size modifier
769 is used. Update the commentary.
770
771 * eval.c (verror): Simplify calculation of size_t.
772
773 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
774 messages.
775
f61f41d7
PE
7762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
777
778 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
779 change.
780
96fb4434
PE
7812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
782
783 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
784 This makes this file independent of the recent pseudovector change.
785
671875da 7862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 787
69e9b5a3
PE
788 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
789
b5f869a7 790 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 791 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 792 Remove unused local.
c8926152 793 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 794
841a1577 795 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
796 GCC 4.6.0 optimizes based on type-based alias analysis. For
797 example, if b is of type struct buffer * and v of type struct
798 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
799 != &v->size, and therefore "v->size = 1; b->size = 2; return
800 v->size;" must therefore return 1. This assumption is incorrect
801 for Emacs, since it type-puns struct Lisp_Vector * with many other
802 types. To fix this problem, this patch adds a new type struct
f904488f 803 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
804 and pseudovectors, and helps optimizing compilers not get fooled
805 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
806 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
807 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
808 the size member.
eab3844f
PE
809 (XSETPVECTYPE): Rewrite in terms of new macro.
810 (XSETPVECTYPESIZE): New macro, specifying both type and size.
811 This is a bit clearer, and further avoids the possibility of
812 undesirable aliasing.
813 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 814 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
815 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
816 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
817 (ASIZE): Now uses header.size rather than size. All
818 previous uses of XVECTOR (foo)->size replaced to use this macro,
819 to avoid the hassle of writing XVECTOR (foo)->header.size.
820 (struct vectorlike_header): New type.
eab3844f
PE
821 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
822 object, to help avoid aliasing.
823 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
824 (SUBRP): Likewise, since Lisp_Subr is a special case.
825 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
826 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
827 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 828 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
829 changed to be "header.size" and "header.next".
830 * buffer.h (struct buffer): Likewise.
831 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
832 * frame.h (struct frame): Likewise.
833 * process.h (struct Lisp_Process): Likewise.
834 * termhooks.h (struct terminal): Likewise.
835 * window.c (struct save_window_data, struct saved_window): Likewise.
836 * window.h (struct window): Likewise.
837 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
838 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
839 * buffer.c (init_buffer_once): Likewise.
840 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
841 special case.
842 * process.c (Fformat_network_address): Use local var for size,
843 for brevity.
844
0df1eac5
PE
845 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
846
847ab9d1 847 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
848 * data.c (atof): Remove decl; no longer used or needed.
849 (digit_to_number): Move to lread.c.
850 (Fstring_to_number): Use new string_to_number function, to be
851 consistent with how the Lisp reader treats infinities and NaNs.
852 Do not assume that floating-point numbers represent EMACS_INT
853 without losing information; this is not true on most 64-bit hosts.
854 Avoid double-rounding errors, by insisting on integers when
855 parsing non-base-10 numbers, as the documentation specifies.
856 * lisp.h (string_to_number): New decl, replacing ...
857 (isfloat_string): Remove.
bc0a5c13 858 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 859 (read1): Do not accept +. and -. as integers; this
452f4150
PE
860 appears to have been a coding error. Similarly, do not accept
861 strings like +-1e0 as floating point numbers. Do not report
862 overflow for integer overflows unless the base is not 10 which
863 means we have no simple and reliable way to continue.
864 Break out the floating-point parsing into a new
865 function string_to_number, so that Fstring_to_number parses
866 floating point numbers consistently with the Lisp reader.
867 (digit_to_number): Moved here from data.c. Make it static inline.
868 (E_CHAR, EXP_INT): Remove, replacing with ...
869 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
870 (string_to_number): New function, replacing isfloat_string.
871 This function checks for valid syntax and produces the resulting
872 Lisp float number too. Rework it so that string-to-number
bc0a5c13 873 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
874 so that overflow for non-base-10 numbers is reported only when
875 there's no portable and simple way to convert to floating point.
452f4150 876
67769ffc
PE
877 * textprop.c (set_text_properties_1): Rewrite for clarity,
878 and to avoid GCC warning about integer overflow.
879
c20db43f
PE
880 * intervals.h (struct interval): Use EMACS_INT for members
881 where EMACS_UINT might cause problems. See
882 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
883 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
884 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
885 All uses changed.
37aa2f85
PE
886 (offset_intervals): Tell GCC not to worry about length overflow
887 when negating a negative length.
c20db43f 888
2538aa2f
PE
889 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
890 (overrun_check_free): Likewise.
891
f2d3008d
PE
892 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
893 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
894 word size.
895
ec8df744
PE
896 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
897 (gnutls_make_error): Rename local to avoid shadowing.
898 (gnutls_emacs_global_deinit): ifdef out; not used.
899 (Fgnutls_boot): Use const for pointer to readonly storage.
900 Comment out unused local. Fix pointer signedness problems.
901
640ee02d
PE
902 * lread.c (openp): Don't stuff size_t into an 'int'.
903 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
904 about possible signed overflow.
905
6048fb2a
PE
906 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
907 (GDK_KEY_g): Don't define if already defined.
908 (xg_prepare_tooltip): Avoid pointer signedness problem.
909 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
910
fa3c87e1
PE
911 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
912 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
913
2172544b
PE
914 * xfns.c (Fx_window_property): Simplify a bit,
915 to make a bit faster and to avoid GCC 4.6.0 warning.
916 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
917
9b821a21
PE
918 * fns.c (internal_equal): Don't assume size_t fits in int.
919
3c616cfa
PE
920 * alloc.c (compact_small_strings): Tighten assertion a little.
921
c2982e87
PE
922 Replace pEd with more-general pI, and fix some printf arg casts.
923 * lisp.h (pI): New macro, generalizing old pEd macro to other
924 conversion specifiers. For example, use "...%"pI"d..." rather
925 than "...%"pEd"...".
926 (pEd): Remove. All uses replaced with similar uses of pI.
927 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
928 * alloc.c (check_pure_size): Don't overflow by converting size to int.
929 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
930 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
931 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
932 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
933 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
934 64-bit hosts.
935 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
936 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
937 * print.c (safe_debug_print, print_object): Likewise.
938 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
939 to int.
6f04d126
PE
940 Use pI instead of if-then-else-abort. Use %p to avoid casts,
941 avoiding the 0 flag, which is not portable.
c2982e87
PE
942 * process.c (Fmake_network_process): Use pI to avoid cast.
943 * region-cache.c (pp_cache): Likewise.
944 * xdisp.c (decode_mode_spec): Likewise.
945 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
946 behavior on 64-bit hosts with printf arg.
6f04d126 947 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
948 (x_stop_queuing_selection_requests): Likewise.
949 (x_get_window_property): Don't truncate byte count to an 'int'
950 when tracing.
0b432f21 951
5e073ec7
PE
952 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
953 here, since it parses constructs like leading '-' and spaces,
954 which are not wanted; and it overflows with large numbers.
955 Instead, simply match F[0-9]+, which is what is wanted anyway.
956
36372bf9
PE
957 * alloc.c: Remove unportable assumptions about struct layout.
958 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
959 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
960 (allocate_vectorlike, make_pure_vector): Use the new macros,
961 plus offsetof, to remove unportable assumptions about struct layout.
962 These assumptions hold on all porting targets that I know of, but
963 they are not guaranteed, they're easy to remove, and removing them
964 makes further changes easier.
965
0b432f21
PE
966 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
967 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
968 (string_overrun_cookie): Now const. Use initializers that
969 don't formally overflow signed char, to avoid warnings.
000098c1
PE
970 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
971 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
972 (allocate_buffer): Don't assume sizeof (struct buffer) is a
973 multiple of sizeof (EMACS_INT); it need not be, if
974 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 975 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 976
895009e1
JB
9772011-04-26 Juanma Barranquero <lekktu@gmail.com>
978
979 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
980
6a7a1b0b
TZ
9812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
982
983 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 984 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
985 Reported by Paul Eggert <eggert@cs.ucla.edu>.
986
841a1577 9872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
988
989 * lisp.h (Qdebug): List symbol.
895009e1 990 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
991 * keyboard.c (debug-on-event): New variable.
992 (handle_user_signal): Break into debugger when debug-on-event
993 matches the current signal symbol.
994
f2d3ba6f
DN
9952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
996
997 * alloc.c (check_sblock, check_string_bytes)
998 (check_string_free_list): Convert to standard C.
999
42ce4c63
TZ
10002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1001
1002 * w32.c (emacs_gnutls_push): Fix typo.
1003
825cd63c
EZ
10042011-04-25 Eli Zaretskii <eliz@gnu.org>
1005
fb11d64d
EZ
1006 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1007 "cast to pointer from integer of different size".
1008
825cd63c
EZ
1009 Improve doprnt and its use in verror. (Bug#8545)
1010 * doprnt.c (doprnt): Document the set of format control sequences
1011 supported by the function. Use SAFE_ALLOCA instead of always
1012 using `alloca'.
1013
1014 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1015 is one byte too soon. Don't use xrealloc; instead xfree and
1016 xmalloc anew.
1017
e061a11b
TZ
10182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1019
1020 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1021 callbacks stage.
1022
1023 * gnutls.c: Renamed global_initialized to
1024 gnutls_global_initialized. Added internals for the
1025 :verify-hostname-error, :verify-error, and :verify-flags
1026 parameters of `gnutls-boot' and documented those parameters in the
1027 docstring. Start callback support.
1028 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1029 unless a fatal error occured. Call gnutls_alert_send_appropriate
1030 on error. Return error code.
1031 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1032 (emacs_gnutls_read): Likewise.
1033 (Fgnutls_boot): Return handshake error code.
1034 (emacs_gnutls_handle_error): New function.
1035 (wsaerror_to_errno): Likewise.
1036
1037 * w32.h (emacs_gnutls_pull): Add prototype.
1038 (emacs_gnutls_push): Likewise.
1039
1040 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1041 (emacs_gnutls_push): Likewise.
1042
10432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1044
1045 * process.c (wait_reading_process_output): Check if GnuTLS
1046 buffered some data internally if no FDs are set for TLS
1047 connections.
1048
1049 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1050 (LIBS): Link to USER_LIBS.
1051 ($(BLD)/gnutls.$(0)): New target.
1052
fa6996bc
EZ
10532011-04-24 Eli Zaretskii <eliz@gnu.org>
1054
eb35682e
EZ
1055 * xdisp.c (handle_single_display_spec): Rename the
1056 display_replaced_before_p argument into display_replaced_p, to
1057 make it consistent with the commentary. Fix typos in the
1058 commentary.
1059
e2ad650c
EZ
1060 * textprop.c (syms_of_textprop): Remove dead code.
1061 (copy_text_properties): Delete obsolete commentary about an
1062 interface that was deleted long ago. Fix typos in the description
1063 of arguments.
1064
1b2de274
EZ
1065 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1066 to changes in oldXMenu/XMenu.h from 2011-04-16.
1067 <menu_help_message, prev_menu_help_message>: Constify.
1068 (IT_menu_make_room): menu->help_text is now `const char **';
1069 adjust.
1070
1071 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1072 to changes in oldXMenu/XMenu.h from 2011-04-16.
1073 (struct XMenu): Declare `help_text' `const char **'.
1074
1075 * xfaces.c <Qunspecified>: Make extern again.
1076
1077 * syntax.c: Include sys/types.h before including regex.h, as
1078 required by Posix.
1079
762b15be
EZ
1080 * doc.c (get_doc_string): Improve the format passed to `error'.
1081
1082 * doprnt.c (doprnt): Improve commentary.
1083
1084 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1085
1086 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1087 them with etags.
1088
f1052e5d
EZ
1089 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1090 changes in globals.h immediately force recompilation.
762b15be
EZ
1091 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1092 $(CURDIR)/s/ms-w32.h.
1093 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1094
fa6996bc
EZ
1095 * character.c (Fchar_direction): Function deleted.
1096 (syms_of_character): Don't defsubr it.
1097 <char-direction-table>: Deleted.
1098
e6c3da20
EZ
10992011-04-23 Eli Zaretskii <eliz@gnu.org>
1100
1101 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1102 * doprnt.c: Include limits.h.
1103 (SIZE_MAX): New macro.
1104 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
1105 local variables are now size_t instead of int or unsigned.
1106 Improve overflow protection. Support `l' modifier for integer
1107 conversions. Support %l conversion. Don't assume an EMACS_INT
1108 argument for integer conversions and for %c.
1109
1110 * lisp.h (doprnt): Restore prototype.
1111
1112 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1113 $(SRC)/character.h.
1114
1115 * Makefile.in (base_obj): Add back doprnt.o.
1116
1117 * deps.mk (doprnt.o): Add back prerequisites.
1118 (callint.o): Depend on character.h.
1119
1120 * eval.c (internal_lisp_condition_case): Include the handler
1121 representation in the error message.
1122 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1123 when breaking from the loop.
1124
1125 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1126
1127 * callint.c (Fcall_interactively): When displaying error message
1128 about invalid control letter, pass the character's codepoint, not
1129 a pointer to its multibyte form. Improve display of the character
1130 in octal and display also its hex code.
1131
1132 * character.c (char_string): Use %x to display the (unsigned)
1133 codepoint of an invalid character, to avoid displaying a bogus
1134 negative value.
1135
1136 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1137 `error', not SYMBOL_NAME itself.
1138
1139 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1140 character arguments to `error'.
1141
1142 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1143 to `error' in error message about FINAL_CHAR argument. Make sure
1144 FINAL_CHAR is a character, and use %c when it is passed as
1145 argument to `error'.
1146
4ffd0d6b 11472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1148
1149 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1150
1151 * w32.c: Include <time.h>.
1152 (sys_localtime): New function.
1153
4ffd0d6b 11542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1155
1156 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1157
4ffd0d6b 1158 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1159
4ffd0d6b 11602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1161
4ffd0d6b
GM
1162 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1163 zombies (Bug#8467).
aac0c6e3 1164
04c56954
EZ
11652011-04-19 Eli Zaretskii <eliz@gnu.org>
1166
1167 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1168 gl_state.e_property when gl_state.object is Qt.
1169
1170 * insdel.c (make_gap_larger): Remove limitation of buffer size
1171 to <= INT_MAX.
1172
16a43933
CY
11732011-04-18 Chong Yidong <cyd@stupidchicken.com>
1174
1175 * xdisp.c (lookup_glyphless_char_display)
1176 (produce_glyphless_glyph): Handle cons cell entry in
1177 glyphless-char-display.
1178 (Vglyphless_char_display): Document it.
1179
1180 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1181 glyphless-char-display.
1182
4581706e
CY
11832011-04-17 Chong Yidong <cyd@stupidchicken.com>
1184
1185 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1186
1187 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1188
1189 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1190 definition for no-X builds.
1191
4887c6e2 11922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1193
fd35b6f9
PE
1194 Static checks with GCC 4.6.0 and non-default toolkits.
1195
5c1ccb01
PE
1196 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1197
006c5daa
PE
1198 * process.c (keyboard_bit_set): Define only if SIGIO.
1199 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1200 (send_process): Repair possible setjmp clobbering.
1201
efc736d3
PE
1202 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1203
4e2fe2e6
PE
1204 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1205
f97334a2
PE
1206 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1207
4e75f29d
PE
1208 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1209 Define only if needed.
1210
90efadd1
PE
1211 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1212 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1213 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1214
3c647824
PE
1215 * dispextern.h (struct redisplay_interface): Rename param
1216 to avoid shadowing.
e264f262 1217 * termhooks.h (struct terminal): Likewise.
761383f4 1218 * xterm.c (xembed_send_message): Likewise.
3c647824 1219
b58c5c4a
PE
1220 * insdel.c (make_gap_smaller): Define only if
1221 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1222
cad59032
PE
1223 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1224 it.
1225
c339dc2e
PE
1226 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1227 so that we aren't warned about unused symbols.
1228
91a3e27b
PE
1229 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1230
399c71d3 1231 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1232
8ffc96f5
PE
1233 * xfns.c (x_real_positions): Mark locals as initialized.
1234
eef9bc79
PE
1235 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1236
098db9dd
PE
1237 * xterm.c: Fix problems found by static analysis with other toolkits.
1238 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1239 (x_dispatch_event): Declare static if USE_GTK, and
1240 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1241 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1242 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1243 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1244 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1245
eb18f6cc
PE
1246 * xmenu.c (menu_help_callback): Pointer type fixes.
1247 Use const pointers when pointing at readonly data. Avoid pointer
1248 signedness clashes.
1249 (FALSE): Remove unused macro.
1250 (update_frame_menubar): Remove unused decl.
1251
1fe72bf8
PE
1252 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1253
60d9e1db
PE
1254 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1255 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1256 (single_menu_item): Rename local to avoid shadowing.
1257
39261c26
PE
1258 * keyboard.c (make_lispy_event): Remove unused local var.
1259
018c5e19
PE
1260 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1261 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1262
63d2b86e
PE
1263 * bitmaps: Change bitmaps from unsigned char back to the X11
1264 compatible char. Avoid the old compiler warnings about
1265 out-of-range initializers by using, for example, '\xab' rather
1266 than 0xab.
1267
aefd87e1
PE
1268 * xgselect.c (xgselect_initialize): Check vs interface
1269 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1270
bf501fb9
PE
1271 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1272
e9829fdf
PE
1273 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1274 to read-only memory.
1275
1086c095
PE
1276 * fns.c (vector): Remove; this old hack is no longer needed.
1277
2baccd04 1278 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1279 Remove unused var.
dde42981 1280 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1281
72391843 1282 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1283
436c16df 1284 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1285 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1286 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1287
92bb796d 1288 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1289 (x_term_init): Remove local to avoid shadowing.
92bb796d 1290
764430a3 1291 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1292
1293 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1294 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1295
d1dfb56c
EZ
12962011-04-16 Eli Zaretskii <eliz@gnu.org>
1297
c4354cb4
EZ
1298 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1299
d1dfb56c
EZ
1300 Fix regex.c, syntax.c and friends for buffers > 2GB.
1301 * syntax.h (struct gl_state_s): Declare character position members
1302 EMACS_INT.
1303
1304 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1305
1306 * textprop.c (verify_interval_modification, interval_of): Declare
1307 arguments EMACS_INT.
1308
1309 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1310 EMACS_INT.
1311
1312 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1313
1314 * indent.c (Fvertical_motion): Local variable it_start is now
1315 EMACS_INT.
1316
1317 * regex.c (re_match, re_match_2, re_match_2_internal)
1318 (bcmp_translate, regcomp, regexec, print_double_string)
1319 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1320 (re_compile_pattern, re_exec): Declare arguments and local
1321 variables `size_t' and `ssize_t' and return values `regoff_t', as
1322 appropriate.
1323 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1324 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1325 <compile_stack_type>: `size' and `avail' are now `size_t'.
1326
1327 * regex.h <regoff_t>: Use ssize_t, not int.
1328 (re_search, re_search_2, re_match, re_match_2): Arguments that
1329 specify buffer/string position and length are now ssize_t and
1330 size_t. Return type is regoff_t.
1331
613052cd
BK
13322011-04-16 Ben Key <bkey76@gmail.com>
1333
1334 * nsfont.m: Fixed bugs in ns_get_family and
1335 ns_descriptor_to_entity that were caused by using free to
1336 deallocate memory blocks that were allocated by xmalloc (via
1337 xstrdup). This caused Emacs to crash when compiled with
1338 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1339 --enable-checking=xmallocoverrun). xfree is now used to
1340 deallocate these memory blocks.
1341
4170f62f 13422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1343
71b41406
PE
1344 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1345
9587a89d
PE
1346 emacs_write: Accept and return EMACS_INT for sizes.
1347 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1348 et seq.
1349 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1350 Accept and return EMACS_INT.
1351 (emacs_gnutls_write): Return the number of bytes written on
1352 partial writes.
1353 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1354 (emacs_read, emacs_write): Remove check for negative size, as the
1355 Emacs source code has been audited now.
9587a89d
PE
1356 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1357 (emacs_read, emacs_write): Use it.
273a5f82
PE
1358 * process.c (send_process): Adjust to the new signatures of
1359 emacs_write and emacs_gnutls_write. Do not attempt to store
1360 a byte offset into an 'int'; it might overflow.
9587a89d 1361 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1362
3e047f51
PE
1363 * sound.c: Don't assume sizes fit in 'int'.
1364 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1365 Return EMACS_INT, not int.
3e047f51 1366 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1367 Accept EMACS_INT, not int.
1368 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1369 record read return values.
1370
cc39a9db
BK
13712011-04-15 Ben Key <bkey76@gmail.com>
1372
c9d0ec6d
JB
1373 * keyboard.c (Qundefined): Don't declare static since it is used
1374 in nsfns.m.
1375 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1376 static since they are used in nsfont.m.
cc39a9db 1377
6c60eb9f
SM
13782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1379
1380 * process.c (Qprocessp): Don't declare static.
1381 * lisp.h (Qprocessp): Declare again.
1382
7990b61a
JB
13832011-04-15 Juanma Barranquero <lekktu@gmail.com>
1384
1385 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1386
5d4cb038
PE
13872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1388
8bd7b830 1389 Improve C-level modularity by making more things 'static'.
cd64ea1d 1390
e3b27b31
PE
1391 Don't publish debugger-only interfaces to other modules.
1392 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1393 (verify_bytepos, count_markers): Move decls to the only modules
1394 that need them.
1395 * region-cache.h (pp_cache): Likewise.
1396 * window.h (check_all_windows): Likewise.
1397 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1398
5d4cb038
PE
1399 * sysdep.c (croak): Now static, if
1400 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1401 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1402
1403 * alloc.c (refill_memory_reserve): Now static if
1404 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1405 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1406
e87b6180
PE
1407 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1408 Define only if USE_LUCID.
1409
ac64929e
PE
1410 * xrdb.c (x_customization_string, x_rm_string): Now static.
1411
6f37259d
PE
1412 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1413 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1414
1683e3ab
PE
1415 * xdisp.c (draw_row_with_mouse_face): Now static.
1416 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1417
de9c2632
PE
1418 * window.h (check_all_windows): Mark externally visible.
1419
2b96acb7
PE
1420 * window.c (window_deletion_count): Now static.
1421
1422 * undo.c: Make symbols static if they're not exported.
1423 (last_undo_buffer, last_boundary_position, pending_boundary):
1424 Now static.
1425
50436f33
PE
1426 * textprop.c (interval_insert_behind_hooks): Now static.
1427 (interval_insert_in_front_hooks): Likewise.
1428
64520e5c
PE
1429 * term.c: Make symbols static if they're not exported.
1430 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1431 (max_frame_lines, tty_set_terminal_modes):
1432 (tty_reset_terminal_modes, tty_turn_off_highlight):
1433 (get_tty_terminal): Now static.
1434 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1435 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1436 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1437 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1438 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1439
1fa53021
PE
1440 * sysdep.c: Make symbols static if they're not exported.
1441 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1442 Now static.
1443 (sigprocmask_set, full_mask): Remove; unused.
1444 (wait_debugging): Mark as visible.
1445 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1446 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1447
d4b43b22
PE
1448 * syntax.c (syntax_temp): Define only if !__GNUC__.
1449
b7c513d0
PE
1450 * sound.c (current_sound_device, current_sound): Now static.
1451
989b29ad
PE
1452 * search.c (searchbufs, searchbuf_head): Now static.
1453
13a55a78
PE
1454 * scroll.c (scroll_cost): Remove; unused.
1455 * dispextern.h (scroll_cost): Remove decl.
1456
de68a1fc
PE
1457 * region-cache.h (pp_cache): Mark as externally visible.
1458
40ccffa6
PE
1459 * process.c: Make symbols static if they're not exported.
1460 (process_tick, update_tick, create_process, chan_process):
1461 (Vprocess_alist, proc_buffered_char, datagram_access):
1462 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1463 (deactivate_process): Mark defn as static, as well as decl.
1464 * lisp.h (create_process): Remove decl.
1465 * process.h (chan_process, Vprocess_alist): Remove decls.
1466
ad64fc97
PE
1467 * print.c: Make symbols static if they're not exported.
1468 (print_depth, new_backquote_output, being_printed, print_buffer):
1469 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1470 (print_interval, print_number_index, initial_stderr_stream):
1471 Now static.
1472 * lisp.h (Fprinc): Remove decl.
1473 (debug_output_compilation_hack): Mark as externally visible.
1474
adddb265
PE
1475 * sysdep.c (croak): Move decl from here to syssignal.h.
1476 * syssignal.h (croak): Put it here, so the API can be checked when
1477 'croak' is called from dissociate_if_controlling_tty.
1478
1717ede2
PE
1479 * minibuf.c: Make symbols static if they're not exported.
1480 (minibuf_save_list, choose_minibuf_frame): Now static.
1481 * lisp.h (choose_minibuf_frame): Remove decl.
1482
fa5fb2bc
PE
1483 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1484
1e3890d1
PE
1485 * lread.c: Make symbols static if they're not exported.
1486 (read_objects, initial_obarray, oblookup_last_bucket_number):
1487 Now static.
1488 (make_symbol): Remove; unused.
1489 * lisp.h (initial_obarray, make_symbol): Remove decls.
1490
8a1414fa
PE
1491 * keyboard.c: Make symbols static if they're not exported.
1492 (single_kboard, recent_keys_index, total_keys, recent_keys):
1493 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1494 (this_single_command_key_start, echoing, last_auto_save):
1495 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1496 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1497 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1498 (Vlispy_mouse_stem, double_click_count):
1499 Now static.
1500 (force_auto_save_soon): Define only if SIGDANGER.
1501 (ignore_mouse_drag_p): Now static if
1502 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1503 (print_help): Remove; unused.
1504 (stop_character, last_timer_event): Mark as externally visible.
1505 * keyboard.h (ignore_mouse_drag_p): Declare only if
1506 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1507 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1508 * lisp.h (echoing): Remove decl.
1509 (force_auto_save_soon): Declare only if SIGDANGER.
1510 * xdisp.c (redisplay_window): Simplify code, to make it more
1511 obvious that ignore_mouse_drag_p is not accessed if !defined
1512 USE_GTK && !defined HAVE_NS.
1513
93ea6e8f
PE
1514 * intervals.c: Make symbols static if they're not exported.
1515 (merge_properties_sticky, merge_interval_right, delete_interval):
1516 Now static.
1517 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1518
77382fcc
PE
1519 * insdel.c: Make symbols static if they're not exported.
1520 However, leave prepare_to_modify_buffer alone. It's never
1521 called from outside this function, but that appears to be a bug.
1522 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1523 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1524 (adjust_after_replace_noundo): Remove; unused.
1525 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1526 (signal_before_change): Remove decls.
77382fcc 1527
9306c32e
PE
1528 * indent.c (val_compute_motion, val_vmotion): Now static.
1529
cd44d2eb
PE
1530 * image.c: Make symbols static if they're not exported.
1531 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1532 if USE_GTK.
1533 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1534 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1535
ad9a7a06
PE
1536 * fringe.c (standard_bitmaps): Now static.
1537 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1538
81626931
PE
1539 * frame.c: Make symbols static if they're not exported.
1540 (x_report_frame_params, make_terminal_frame): Now static.
1541 (get_frame_param): Now static, unless HAVE_NS.
1542 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1543 (x_get_resource_string): Remove; not used.
1544 * frame.h (make_terminal_frame, x_report_frame_params):
1545 (x_get_resource_string); Remove decls.
1546 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1547 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1548
239f9db9
PE
1549 * font.c, fontset.c: Make symbols static if they're not exported.
1550 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1551 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1552 * font.c (font_close_object): Now static.
1553 * font.h (font_close_object): Remove.
1554 * fontset.c (FONTSET_OBJLIST): Remove.
1555 (free_realized_fontset) #if-0 the body, which does nothing.
1556 (face_suitable_for_char_p): #if-0, as it's never called.
1557 * fontset.h (face_suitable_for_char_p): Remove decl.
1558 * xfaces.c (face_at_string_position): Use
1559 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1560 since 0 is always ASCII.
1561
dfcf3579
PE
1562 * fns.c (weak_hash_tables): Now static.
1563
5045092b
PE
1564 * fileio.c: Make symbols static if they're not exported.
1565 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1566 (Vwrite_region_annotation_buffers): Now static.
1567
57a96f5c
PE
1568 * eval.c: Make symbols static if they're not exported.
1569 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1570 * lisp.h (backtrace_list): Remove decl.
1571
35f08c38
PE
1572 * emacs.c: Make symbols static if they're not exported.
1573 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1574 (fatal_error_code, fatal_error_signal_hook, standard_args):
1575 Now static.
1576 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1577 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1578 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1579 * lisp.h (fatal_error_signal_hook): Remove decl.
1580 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1581
f44bd759
PE
1582 * editfns.c: Move a (normally-unused) function to its only use.
1583 * editfns.c, lisp.h (get_operating_system_release): Remove.
1584 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1585 worth the hassle of breaking this out.
1586
b532497d
PE
1587 * xterm.c: Make symbols static if they're not exported.
1588 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1589 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1590 (x_destroy_window, x_delete_display):
1591 Now static.
1592 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1593 (x_mouse_leave): Remove; unused.
1594 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1595 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1596 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1597 Remove decls.
1598 (x_mouse_leave): Declare only if WINDOWSNT.
1599 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1600 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1601 USE_X_TOOLKIT.
1602
1675728f
PE
1603 * ftxfont.c: Make symbols static if they're not exported.
1604 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1605 HAVE_FREETYPE.
1606 * font.h (ftxfont_driver): Likewise.
1607
e4cebfca
PE
1608 * xfns.c: Make symbols static if they're not exported.
1609 (x_last_font_name, x_display_info_for_name):
1610 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1611 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1612 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1613 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1614 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1615 (last_show_tip_args): Now static.
1616 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1617 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1618 (x_screen_planes): Remove; unused.
1619 * dispextern.h (x_screen_planes): Remove decl.
1620
5bf46f05
PE
1621 * dispnew.c: Make symbols static if they're not exported.
1622 * dispextern.h (redraw_garbaged_frames, scrolling):
1623 (increment_row_positions): Remove.
1624 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1625 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1626 Now static.
1627 (redraw_garbaged_frames): Remove; unused.
1628
435f4c28
PE
1629 * xfaces.c: Make symbols static if they're not exported.
1630 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1631 Remove decls.
1632 * xterm.h (defined_color): Remove decls.
1633 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1634 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1635 (menu_face_changed_default, defined_color, free_realized_face):
1636 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1637 (ascii_face_of_lisp_face): Remove; unused.
1638
8524aef3
PE
1639 * xdisp.c: Make symbols static if they're not exported.
1640 * dispextern.h (scratch_glyph_row, window_box_edges):
1641 (glyph_to_pixel_coords, set_cursor_from_row):
1642 (get_next_display_element, set_iterator_to_next):
1643 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1644 (show_mouse_face): Remove decls
1645 * frame.h (message_buf_print): Likewise.
1646 * lisp.h (pop_message, set_message, check_point_in_composition):
1647 Likewise.
1648 * xterm.h (set_vertical_scroll_bar): Likewise.
1649 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1650 (message_buf_print, scratch_glyph_row, displayed_buffer):
1651 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1652 (get_next_display_element, show_mouse_face, window_box_edges):
1653 (frame_to_window_pixel_xy, check_point_in_composition):
1654 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1655 (glyph_to_pixel_coords): Remove; unused.
1656
16390cd2
PE
1657 * dired.c (file_name_completion): Now static.
1658
1659 * dbusbind.c (xd_in_read_queued_messages): Now static.
1660
a25f4dfa
PE
1661 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1662 * data.c (circular_list_error): Remove.
1663
14a9c8df
PE
1664 * commands.h (last_point_position, last_point_position_buffer):
1665 (last_point_position_window): Remove decls.
1666 * keyboard.c: Make these variables static.
1667
74ab6df5
PE
1668 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1669 decls.
1670 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1671 (iso_code_class, detect_coding, code_convert_region): Now static.
1672 (encode_coding_gap): Remove; unused.
1673
38dfbee1
PE
1674 * chartab.c (chartab_chars, chartab_bits): Now static.
1675
a2cb4e63
PE
1676 * charset.h (charset_iso_8859_1): Remove decl.
1677 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1678 Now static.
1679
127198fd
PE
1680 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1681 * ccl.c (Vccl_program_table): Now static.
1682 (check_ccl_update): Remove; unused.
1683
d85b608f
PE
1684 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1685 * category.h: ... from here.
1686 * category.c (check_category_table, set_category_set): Now static.
1687
31cd66f3
PE
1688 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1689 * lisp.h: Remove these decls.
1690
c358e587
PE
1691 * buffer.c (buffer_count): Remove unused var.
1692
e78aecca
PE
1693 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1694 so that it's not optimized away.
1695 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1696 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1697 exported only to the debugger.
1698
e192d7d3
PE
1699 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1700 * atimer.h (run_all_atimers): Removed; not exported.
1701
92470028
PE
1702 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1703 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1704 was inaccessible from Lisp.
1705 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1706 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1707
244ed907
PE
1708 alloc.c: Import and export fewer symbols, and remove unused items.
1709 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1710 is defined.
1711 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1712 it's not optimized away by whole-program optimization.
1713 (message_enable_multibyte, free_misc): Remove.
1714 (catchlist, handlerlist, mark_backtrace):
1715 Declare only if BYTE_MARK_STACK.
1716 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1717 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1718 (message_enable_multibyte): Remove decl.
1719 (free_misc, interval_free_list, float_block, float_block_index):
1720 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1721 (cons_free_list, last_marked_index):
1722 Now static.
1723 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1724 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1725 (mark_backtrace): Define only if BYTE_MARK_STACK.
1726 * xdisp.c (message_enable_multibyte): Now static.
1727
61c2b50e 1728 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1729 This makes it easier for human readers (and static analyzers)
1730 to see whether these variables are used from other modules.
1731 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1732 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1733 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1734 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1735 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1736 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1737 * xmenu.c, xselect.c:
1738 Declare Q* vars static if they are not used in other modules.
1739 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1740 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1741 Remove decls of unexported vars.
1742 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1743
95c82688
PE
1744 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1745
16a97296
PE
1746 Make Emacs functions such as Fatom 'static' by default.
1747 This makes it easier for human readers (and static analyzers)
1748 to see whether these functions can be called from other modules.
1749 DEFUN now defines a static function. To make the function external
1750 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1751 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1752 (Finit_image_library):
16a97296
PE
1753 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1754 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1755 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1756 Remove decls, since these functions are now static.
1757 (Funintern, Fget_internal_run_time): New decls, since these functions
1758 were already external.
95c82688 1759
16a97296
PE
1760 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1761 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1762 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1763 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1764 * keyboard.c, keymap.c, lread.c:
1765 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1766 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1767 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1768 Mark functions with DEFUE instead of DEFUN,
1769 if they are used in other modules.
1770 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1771 decls for now-static functions.
1772 * buffer.h (Fdelete_overlay): Remove decl.
1773 * callproc.c (Fgetenv_internal): Mark as internal.
1774 * composite.c (Fremove_list_of_text_properties): Remove decl.
1775 (Fcomposition_get_gstring): New forward static decl.
1776 * composite.h (Fcomposite_get_gstring): Remove decl.
1777 * dired.c (Ffile_attributes): New forward static decl.
1778 * doc.c (Fdocumntation_property): New forward static decl.
1779 * eval.c (Ffetch_bytecode): New forward static decl.
1780 (Funintern): Remove extern decl; now in .h file where it belongs.
1781 * fileio.c (Fmake_symbolic_link): New forward static decl.
1782 * image.c (Finit_image_library): New forward static decl.
1783 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1784 * intervals.h (Fprevious_property_change):
1785 (Fremove_list_of_text_properties): Remove decls.
1786 * keyboard.c (Fthis_command_keys): Remove decl.
1787 (Fcommand_execute): New forward static decl.
1788 * keymap.c (Flookup_key): New forward static decl.
1789 (Fcopy_keymap): Now static.
1790 * keymap.h (Flookup_key): Remove decl.
1791 * process.c (Fget_process): New forward static decl.
1792 (Fprocess_datagram_address): Mark as internal.
1793 * syntax.c (Fsyntax_table_p): New forward static decl.
1794 (skip_chars): Remove duplicate decl.
1795 * textprop.c (Fprevious_property_change): New forward static decl.
1796 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1797 Now internal.
1798 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1799 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1800
785bbd42
PE
1801 * editfns.c (Fformat): Remove unreachable code.
1802
8b913b57
AS
18032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1804
1805 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1806 change. (Bug#8496)
1807
a6744a35
EZ
18082011-04-13 Eli Zaretskii <eliz@gnu.org>
1809
1810 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1811 when at ZV. (Bug#8487)
1812
e7974947
AS
18132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1814
baad03f0
AS
1815 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1816 (Bug#8437)
1817 * keyboard.c (parse_tool_bar_item): Likewise.
1818 * sound.c (sound_cleanup, alsa_close): Likewise.
1819 * termcap.c (tgetent): Likewise.
1820 * xfns.c (x_default_font_parameter): Likewise.
1821 * xsettings.c (read_and_apply_settings): Likewise.
1822
e7974947
AS
1823 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1824 (overrun_check_free): Protoize.
1825
28272684
PE
18262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1827
1828 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1829 since callers should never pass a negative size.
1830 Change the signature to match that of plain 'read' and 'write'; see
1831 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1832 * lisp.h: Update prototypes of emacs_write and emacs_read.
1833
11997c76
EZ
18342011-04-11 Eli Zaretskii <eliz@gnu.org>
1835
1836 * xdisp.c (redisplay_window): Don't try to determine the character
1837 position of the scroll margin if the window start point w->startp
e896f03c 1838 is outside the buffer's accessible region. (Bug#8468)
11997c76 1839
8a2cbd72
EZ
18402011-04-10 Eli Zaretskii <eliz@gnu.org>
1841
1842 Fix write-region and its subroutines for buffers > 2GB.
1843 * fileio.c (a_write, e_write): Modify declaration of arguments and
1844 local variables to support buffers larger than 2GB.
1845 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1846
1847 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1848 argument, local variables, and return value.
1849
1850 * lisp.h: Update prototypes of emacs_write and emacs_read.
1851
1852 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1853
4073e537 18542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1855
1ebfdcb6
PE
1856 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1857
b2ded58d
PE
1858 Fix more problems found by GCC 4.6.0's static checks.
1859
7d66342c
PE
1860 * xdisp.c (vmessage): Use a better test for character truncation.
1861
bbf47d44
PE
1862 * charset.c (load_charset_map): <, not <=, for optimization,
1863 and to avoid potential problems with integer overflow.
9248994d 1864 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1865 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1866 * editfns.c (Fformat): Likewise.
1e69125e 1867 * syntax.c (skip_chars): Likewise.
3befa583 1868
e3019616
PE
1869 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1870 This also lets GCC 4.6.0 generate slightly better loop code.
1871
becfa255
PE
1872 * callint.c (Fcall_interactively): <, not <=, for optimization.
1873 (Fcall_interactively): Count the number of arguments produced,
1874 not the number of arguments given. This is simpler and lets GCC
1875 4.6.0 generate slightly better code.
1876
dae0cd48
PE
1877 * ftfont.c: Distingish more carefully between FcChar8 and char.
1878 The previous code passed unsigned char * to a functions like
1879 strlen and xstrcasecmp that expect char *, which does not
1880 conform to the C standard.
1881 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1882 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1883 char * when the C standard requires it.
1884
76032d70
PE
1885 * keyboard.c (read_char): Remove unused var.
1886
eb3f1cc8
PE
1887 * eval.c: Port to Windows vsnprintf (Bug#8435).
1888 Include <limits.h>.
1889 (SIZE_MAX): Define if the headers do not.
1890 (verror): Do not give up if vsnprintf returns a negative count.
1891 Instead, grow the buffer. This ports to Windows vsnprintf, which
1892 does not conform to C99. Problem reported by Eli Zaretskii.
1893 Also, simplify the allocation scheme, by avoiding the need for
1894 calling realloc, and removing the ALLOCATED variable.
1895
70476b54
PE
1896 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1897
12020a9e
PE
1898 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1899 But keep the doprint source code for now, as we might revamp it
1900 and use it again (Bug#8435).
ea6c7ae6
PE
1901 * lisp.h (doprnt): Remove.
1902 * Makefile.in (base_obj): Remove doprnt.o.
1903 * deps.mk (doprnt.o): Remove.
1904
5fdb398c
PE
1905 error: Print 32- and 64-bit integers portably (Bug#8435).
1906 Without this change, on typical 64-bit hosts error ("...%d...", N)
1907 was used to print both 32- and 64-bit integers N, which relied on
1908 undefined behavior.
1909 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1910 New macro.
1911 * lisp.h (error, verror): Mark as printf-like functions.
1912 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1913 Report overflow in size calculations when allocating printf buffer.
1914 Do not truncate output string at its first null byte.
1915 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1916 Truncate the output at a character boundary, since vsnprintf does not
1917 do that.
1918 * charset.c (check_iso_charset_parameter): Convert internal
1919 character to string before calling 'error', since %c now has the
1920 printf meaning.
1921 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1922 overflow when computing char to be passed to 'error'. Do not
1923 pass Lisp_Object to 'error'; pass the integer instead.
1924 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1925 formatted with plain %d.
1926
b189fa66
PE
1927 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1928
bff87ef0
PE
1929 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1930
7e2cac20
PE
1931 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1932
ce4d90b5
PE
1933 * xterm.c (x_catch_errors): Remove duplicate declaration.
1934
266c9547
PE
1935 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1936
79c49ad2
PE
1937 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1938
368f4090
JM
19392011-04-10 Jim Meyering <meyering@redhat.com>
1940
1941 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1942 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1943 return ssize_t not "int", and use size_t as the buffer length.
1944 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1945 * gnutls.h: Update declarations.
1946 * process.c (read_process_output): Use ssize_t, to match.
1947 (send_process): Likewise.
1948
a32d4040
CY
19492011-04-09 Chong Yidong <cyd@stupidchicken.com>
1950
1951 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1952
8546720e 19532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1954
8546720e
GM
1955 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1956 unsigned char, to match FcChar8 type definition.
aac0c6e3 1957
8546720e
GM
1958 * xterm.c (handle_one_xevent):
1959 * xmenu.c (create_and_show_popup_menu):
1960 * xselect.c (x_decline_selection_request)
1961 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1962
0a2f5c1a 19632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1964
1965 Fix some uses of `int' instead of EMACS_INT.
1966 * search.c (string_match_1, fast_string_match)
1967 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1968 (scan_buffer, find_next_newline_no_quit)
1969 (find_before_next_newline, search_command, Freplace_match)
1970 (Fmatch_data): Make some `int' variables be EMACS_INT.
1971
1972 * xdisp.c (display_count_lines): 3rd argument and return value now
1973 EMACS_INT. All callers changed.
1974 (pint2hrstr): Last argument is now EMACS_INT.
1975
1976 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1977 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1978 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1979 (decode_coding_utf_16, decode_coding_emacs_mule)
1980 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1981 (decode_coding_ccl, decode_coding_charset)
1982 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1983 (decode_coding_iso_2022, decode_coding_emacs_mule)
1984 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1985 <char_offset, last_offset>: Declare EMACS_INT.
1986 (encode_coding_utf_8, encode_coding_utf_16)
1987 (encode_coding_emacs_mule, encode_invocation_designation)
1988 (encode_designation_at_bol, encode_coding_iso_2022)
1989 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1990 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1991 Declare EMACS_INT.
1992 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1993 (encode_invocation_designation): Last argument P_NCHARS is now
1994 EMACS_INT.
1995 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1996 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1997
1998 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1999 All users changed.
2000
2001 * ccl.c (Fccl_execute_on_string): Declare some variables
2002 EMACS_INT.
2003
8546720e 20042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2005
2006 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2007
4e19a977
CS
20082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2009
2010 * process.c (Fformat_network_address): Doc fix.
2011
87302331
R
20122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2013
2014 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2015
cbb59342
CY
20162011-04-08 Chong Yidong <cyd@stupidchicken.com>
2017
2018 * keyboard.c (read_char): Call Lisp function help-form-show,
2019 instead of using internal_with_output_to_temp_buffer.
2020 (Qhelp_form_show): New var.
e0d38eeb 2021 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2022
2023 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2024
2025 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2026
e67a13ab
CY
20272011-04-06 Chong Yidong <cyd@stupidchicken.com>
2028
2029 * process.c (Flist_processes): Removed to Lisp.
2030 (list_processes_1): Deleted.
2031
973f782d
EZ
20322011-04-06 Eli Zaretskii <eliz@gnu.org>
2033
7c106b1e
EZ
2034 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2035
973f782d
EZ
2036 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2037
41cf7d1a 20382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2039
ca23cc88
PE
2040 Fix more problems found by GCC 4.6.0's static checks.
2041
f390e2d5
PE
2042 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2043
42eea0d0
PE
2044 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2045
b69769da 2046 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2047
f9541e84
PE
2048 * xdisp.c (vmessage): Mark as a printf-like function.
2049
13841b55
PE
2050 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2051
c136c10f
PE
2052 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2053
5e2d4a30
PE
2054 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2055 printf-like functions.
2056 (tiff_load): Add casts to remove these marks before passing them
2057 to system-supplied API.
2058
583f48b9
PE
2059 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2060
b25d760e
PE
2061 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2062 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2063 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2064 directly, rather than having caller test rule sign. This avoids
2065 some unnecessary tests.
2066 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2067 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2068 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2069
bc7b6697 2070 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2071 (xfont_open): Avoid unnecessary tests.
bc7b6697 2072
27ccc379
PE
2073 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2074
dcd5c89a
PE
2075 * composite.h, composite.c (composition_gstring_put_cache):
2076 Use EMACS_INT, not int, for length.
2077
b13a45c6
PE
2078 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2079 breaking out part of COMPOSITION_DECODE_RULE.
2080 (COMPOSITION_DECODE_RULE): Use it.
2081 * composite.c (get_composition_id): Remove unused local vars,
2082 by using the new macro.
2083
1e792e4d
PE
2084 * textprop.c (set_text_properties_1): Change while to do-while,
2085 since the condition is always true at first.
2086
dc6c6455 2087 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2088 (interval_deletion_adjustment): Return unsigned value.
2089 All uses changed.
dc6c6455 2090
aba7731a
PE
2091 * process.c (list_processes_1, create_pty, read_process_output):
2092 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2093 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2094 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2095 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2096 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2097
fdfc4bf3
PE
2098 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2099
fca8fe46 2100 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2101 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2102
06a0259a 2103 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2104 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2105 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2106
e7b9e80f
PE
2107 * print.c (print_error_message): Avoid int overflow.
2108
56201685
PE
2109 * font.c (font_list_entities): Redo for clarity,
2110 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2111
78834453 2112 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2113 (font_score): Avoid potential overflow in diff calculation.
78834453 2114
0bc0b309 2115 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2116 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2117
e610eaca
PE
2118 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2119
b895abce
PE
2120 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2121 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2122 can always succeed if overflow has undefined behavior.
2123
1f1d9321 2124 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2125 (wordify): Omit three unnecessary tests.
1f1d9321 2126
c59478bc
PE
2127 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2128 All callers changed. This avoids the need for an unused var.
2129
79b73827
PE
2130 * casefiddle.c (casify_region): Remove var that is set but not used.
2131
a4db5dfe
PE
2132 * dired.c (file_name_completion): Remove var that is set but not used.
2133
43aae36e
PE
2134 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2135
2a47c44d 2136 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2137 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2138
a37c69bf
PE
2139 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2140 Check for integer overflow on size calculations.
2141
328ab8e7
PE
2142 * buffer.c (Fprevious_overlay_change): Remove var that is set
2143 but not used.
2144
e5a2a5cb
PE
2145 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2146 Remove vars that are set but not used.
8d84a6eb 2147 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2148 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2149
a60e5f68
PE
2150 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2151
f661cb61 2152 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2153 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2154
f0397f5a
PE
2155 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2156 that are set but not used.
2157
8664db06 2158 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2159 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2160
6abdaa4a
PE
2161 * xselect.c (x_get_local_selection, x_handle_property_notify):
2162 Remove vars that are set but not used.
2163
0ce7538d 2164 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2165 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2166
9ae848fc
PE
2167 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2168 Remove var that is set but not used.
0b918413
PE
2169 (scroll_bar_windows_size): Now size_t, not int.
2170 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2171 Check for overflow.
9ae848fc 2172
a5a62657
PE
2173 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2174 (map_tty_color) [!defined MSDOS]: Likewise.
2175
5c5cdd39
PE
2176 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2177
66ebf983
PE
2178 * coding.c: Remove vars that are set but not used.
2179 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2180 All callers changed.
2181 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2182 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2183 (decode_coding_charset): Remove vars that are set but not used.
2184
1be4d761
PE
2185 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2186 that is set but not used.
2187
47553fa8
PE
2188 * print.c (print_object): Remove var that is set but not used.
2189
1f7196bf 2190 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2191 The gnulib version avoids calling malloc in the usual case,
2192 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2193 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2194 * filelock.c (current_lock_owner): Likewise.
2195 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2196 * sysdep.c: Include allocator.h, careadlinkat.h.
2197 (emacs_no_realloc_allocator): New static constant.
2198 (emacs_readlink): New function.
fdb61804
PE
2199 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2200 ../lib/careadlinkat.h.
d1fdcab7 2201
f84c17c7
SM
22022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2203
2204 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2205 first non-nil return value).
2206
ef3862ad
JD
22072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2208
2209 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2210 if not defined (Bug#8403).
2211
376a7006
JB
22122011-04-02 Juanma Barranquero <lekktu@gmail.com>
2213
2214 * xdisp.c (display_count_lines): Remove parameter `start',
2215 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2216 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2217 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2218 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2219 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2220 and thereabouts. All callers changed.
2221 (get_per_char_metric): Remove parameter `f', unused since
2222 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2223
6ca3801d
JM
22242011-04-02 Jim Meyering <meyering@redhat.com>
2225
2226 do not dereference NULL upon failed strdup
2227 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2228 (ns_get_family): Likewise.
2229
d8e2b5ba
JB
22302011-04-02 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2233
8c74fcbd
JD
22342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2235
2236 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2237 later (Bug#8403).
2238
7200d79c
SM
22392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2240
03408648 2241 Add lexical binding.
7200d79c 2242
03408648
SM
2243 * window.c (Ftemp_output_buffer_show): New fun.
2244 (Fsave_window_excursion):
2245 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2246
2247 * lread.c (lisp_file_lexically_bound_p): New function.
2248 (Fload): Bind Qlexical_binding.
2249 (readevalloop): Remove `evalfun' arg.
2250 Bind Qinternal_interpreter_environment.
2251 (Feval_buffer): Bind Qlexical_binding.
2252 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2253 Mark as dynamic.
2254 (syms_of_lread): Declare `lexical-binding'.
2255
2256 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2257
2258 * keyboard.c (eval_dyn): New fun.
2259 (menu_item_eval_property): Use it.
ca105506
SM
2260
2261 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2262
03408648
SM
2263 * fns.c (concat, mapcar1): Accept byte-code-functions.
2264
2265 * eval.c (Fsetq): Handle lexical vars.
2266 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2267 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2268 (FletX, Flet): Obey lexical binding.
2269 (Fcommandp): Handle closures.
2270 (Feval): New `lexical' arg.
2271 (eval_sub): New function extracted from Feval. Use it almost
2272 everywhere where Feval was used. Look up vars in lexical env.
2273 Handle closures.
2274 (Ffunctionp): Move from subr.el.
2275 (Ffuncall): Handle closures.
2276 (apply_lambda): Remove `eval_flags'.
2277 (funcall_lambda): Handle closures and new byte-code-functions.
2278 (Fspecial_variable_p): New function.
2279 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2280 but without exporting it to Lisp.
23aba0ea 2281
23aba0ea 2282 * doc.c (Fdocumentation, store_function_docstring):
03408648 2283 * data.c (Finteractive_form): Handle closures.
23aba0ea 2284
03408648
SM
2285 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2286 interactive spec.
ba83908c 2287
03408648
SM
2288 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2289 byte-codes.
2290 (exec_byte_code): New function extracted from Fbyte_code to handle new
2291 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2292
03408648 2293 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2294
03408648 2295 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2296
e2abce01
JB
22972011-03-31 Juanma Barranquero <lekktu@gmail.com>
2298
2299 * xdisp.c (redisplay_internal): Fix prototype.
2300
63696a73 23012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2302
63696a73
EZ
2303 * xdisp.c (SCROLL_LIMIT): New macro.
2304 (try_scrolling): Use it when setting scroll_limit. Limit
2305 scrolling to 100 screen lines.
2306 (redisplay_window): Even when falling back on "recentering",
2307 position point in the window according to scroll-conservatively,
2308 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2309
2310 (try_scrolling): When point is above the window, allow searching
2311 as far as scroll_max, or one screenful, to compute vertical
2312 distance from PT to the scroll margin position. This prevents
2313 try_scrolling from unnecessarily failing when
2314 scroll-conservatively is set to a value slightly larger than the
2315 window height. Clean up the case of PT below the margin at bottom
2316 of window: scroll_max can no longer be INT_MAX. When aggressive
2317 scrolling is in use, don't let point enter the opposite scroll
2318 margin as result of the scroll.
2319 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2320 threshold of 100 lines for never-recentering scrolling.
2321
e4cc2dfc
JB
23222011-03-31 Juanma Barranquero <lekktu@gmail.com>
2323
2324 * dispextern.h (move_it_by_lines):
2325 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2326 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2327 (message_log_check_duplicate): Remove parameters `prev_bol' and
2328 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2329 (redisplay_internal): Remove parameter `preserve_echo_area',
2330 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2331
2332 * indent.c (Fvertical_motion):
2333 * window.c (window_scroll_pixel_based, Frecenter):
2334 Don't pass `need_y_p' to `move_it_by_lines'.
2335
1c470562
SM
23362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2337
44f230aa
SM
2338 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2339 steal a few bits to be more compact.
2340 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2341 Remove unneeded casts.
2342
1c470562
SM
2343 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2344
888adce9
ZK
23452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2346
2347 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2348 binding" message (bug#7967).
2349
f838ed7b
PE
23502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2351
77861b95
PE
2352 Fix more problems found by GCC 4.6.0's static checks.
2353
de6dbc14
PE
2354 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2355 Remove unused local var.
2356
f838ed7b
PE
2357 * editfns.c (Fmessage_box): Remove unused local var.
2358
792c7b2b
PE
2359 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2360 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2361 Omit unused local vars.
c499e557 2362 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2363 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2364 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2365 Omit unused local var.
2366
ba0165e1
PE
2367 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2368 Don't assume string length fits in int.
32ad8845 2369 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2370 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2371
3c59b4c9
PE
2372 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2373 instead of alloca (Bug#8344).
2374
a3eed478 2375 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2376 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2377
eb4d412d
PE
2378 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2379
1658b401
PE
2380 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2381 concerns.
2382
2383 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2384
2385 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2386
9a2c6e05
PE
2387 * keyboard.c (syms_of_keyboard): Use the same style as later
2388 in this function when indexing through an array. This also
2389 works around GCC bug 48267.
2390
03d0a109
PE
2391 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2392
44f730c8
PE
2393 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2394
fe75f926
PE
2395 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2396 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2397
ffa8c828
PE
2398 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2399 This avoids undefined behavior on integer overflow, and is a bit
2400 more convenient anyway since it is compared to a size_t variable.
2401
c5101a77
PE
2402 Variadic C functions now count arguments with size_t, not int.
2403 This avoids an unnecessary limitation on 64-bit machines, which
2404 caused (substring ...) to crash on large vectors (Bug#8344).
2405 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2406 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2407 All variadic functions and their callers changed accordingly.
c5101a77
PE
2408 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2409 * data.c (arith_driver, float_arith_driver): Likewise.
2410 * editfns.c (general_insert_function): Likewise.
2411 * eval.c (struct backtrace.nargs, interactive_p)
2412 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2413 (funcall_lambda, mark_backtrace): Likewise.
2414 * fns.c (concat): Likewise.
2415 * frame.c (x_set_frame_parameters): Likewise.
2416 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2417 0 if not found, not -1. All callers changed.
2418
dd3f25f7
PE
2419 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2420 (stack_copy_size): Now size_t, not int.
2421 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2422
461c2ab9
JB
24232011-03-28 Juanma Barranquero <lekktu@gmail.com>
2424
2425 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2426 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2427 All callers changed.
2428
2429 * lisp.h (multibyte_char_to_unibyte):
2430 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2431 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2432 * character.h (CHAR_TO_BYTE8):
2433 * cmds.c (internal_self_insert):
2434 * editfns.c (general_insert_function):
2435 * keymap.c (push_key_description):
2436 * search.c (Freplace_match):
2437 * xdisp.c (message_dolog, set_message_1): All callers changed.
2438
f6d62986
SM
24392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2440
2441 * keyboard.c (safe_run_hook_funcall): New function.
2442 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2443 don't set the hook to nil, but remove the offending function instead.
2444 (Qcommand_hook_internal): Remove, unused.
2445 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2446 Vcommand_hook_internal.
2447
2448 * eval.c (enum run_hooks_condition): Remove.
2449 (funcall_nil, funcall_not): New functions.
2450 (run_hook_with_args): Call each function through a `funcall' argument.
2451 Remove `cond' argument, now redundant.
2452 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2453 (Frun_hook_with_args_until_failure): Adjust accordingly.
2454 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2455
1db5b1ad
JB
24562011-03-28 Juanma Barranquero <lekktu@gmail.com>
2457
2458 * dispextern.h (string_buffer_position): Remove declaration.
2459
2460 * print.c (strout): Remove parameter `multibyte', unused since
2461 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2462
2463 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2464 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2465 All callers changed.
2466
2467 * w32.c (_wsa_errlist): Use braces for struct initializers.
2468
2469 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2470 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2471 All callers changed.
2472 (string_buffer_position): Likewise. Also, make static (it's never
2473 used outside xdisp.c).
2474 (cursor_row_p): Remove parameter `w', unused since
2475 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2476 (decode_mode_spec): Remove parameter `precision', introduced during
2477 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2478 All callers changed.
2479
5ffb62aa
JD
24802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2481
2482 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2483
461c2ab9 24842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2485
2486 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2487 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2488 (ns_update_auto_hide_menu_bar): New functions.
2489 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2490 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2491 ns_constrain_all_frames.
2492 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2493 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2494
5c380ffb
JD
24952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2496
2497 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2498
9af30bdf
GM
24992011-03-27 Glenn Morris <rgm@gnu.org>
2500
2501 * syssignal.h: Replace RETSIGTYPE with void.
2502 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2503 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2504 Replace SIGTYPE with void everywhere.
2505 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2506 * s/template.h (SIGTYPE): Remove commented out definition.
2507
e2abce01
JB
25082011-03-26 Eli Zaretskii <eliz@gnu.org>
2509
2510 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2511 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2512
f868cd8a
JB
25132011-03-26 Juanma Barranquero <lekktu@gmail.com>
2514
59eb0929
JB
2515 * w32.c (read_unc_volume): Use parameter `henum', instead of
2516 global variable `wget_enum_handle'.
2517
2518 * keymap.c (describe_vector): Remove parameters `indices' and
2519 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2520 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2521
f868cd8a
JB
2522 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2523
2524 * keyboard.c (timer_check): Remove parameter `do_it_now',
2525 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2526 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2527 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2528
2529 * keyboard.c (read_char):
2530 * w32menu.c (w32_menu_display_help):
2531 * xmenu.c (show_help_event, menu_help_callback):
2532 Adjust calls to `show_help_echo'.
2533
2534 * gtkutil.c (xg_maybe_add_timer):
2535 * keyboard.c (readable_events):
2536 * process.c (wait_reading_process_output):
2537 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2538
2539 * insdel.c (adjust_markers_gap_motion):
2540 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2541 (gap_left, gap_right): Don't call it.
2542
2ecf6fdb
CY
25432011-03-25 Chong Yidong <cyd@stupidchicken.com>
2544
2545 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2546 incurred during fontification.
2547
6b1f9ba4
JB
25482011-03-25 Juanma Barranquero <lekktu@gmail.com>
2549
2550 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2551 (DEFVAR_PER_BUFFER): Don't pass it.
2552
2553 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2554 (scrolling_window): Don't pass it.
2555
0f4a96b5
JB
25562011-03-25 Juanma Barranquero <lekktu@gmail.com>
2557
2558 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2559
2560 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2561 and `suffix'.
2562 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2563 of variables specific to SELinux and computation of `encoded_absname'.
2564
2565 * image.c (XPutPixel): Remove unused variable `height'.
2566
2567 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2568
2569 * unexw32.c (get_section_info): Remove unused variable `section'.
2570
2571 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2572 (system_process_attributes): Remove unused variable `sess'.
2573 (sys_read): Remove unused variable `err'.
2574
2575 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2576 (w32_wnd_proc): Remove unused variable `isdead'.
2577 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2578 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2579 (x_create_tip_frame): Remove unused variable `tem'.
2580
2581 * w32inevt.c (w32_console_read_socket):
2582 Remove unused variable `no_events'.
2583
2584 * w32term.c (x_draw_composite_glyph_string_foreground):
2585 Remove unused variable `width'.
2586
1149507c
JB
25872011-03-24 Juanma Barranquero <lekktu@gmail.com>
2588
2589 * w32term.c (x_set_glyph_string_clipping):
2590 Don't pass uninitialized region to CombineRgn.
2591
9c88f339
JB
25922011-03-23 Juanma Barranquero <lekktu@gmail.com>
2593
2594 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2595 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2596 (Fx_close_connection): Remove unused variable `i'.
2597
2598 * w32font.c (w32font_draw): Return number of glyphs.
2599 (w32font_open_internal): Remove unused variable `i'.
2600 (w32font_driver): Add missing initializer.
2601
2602 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2603 (fill_in_menu): Remove unused variable `items_added'.
2604
2605 * w32term.c (last_mouse_press_frame): Remove static global variable.
2606 (w32_clip_to_row): Remove unused variable `f'.
2607 (x_delete_terminal): Remove unused variable `i'.
2608
2609 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2610 (NOTHING): Remove unused static global variable.
2611 (uniscribe_check_otf): Remove unused variable `table'.
2612 (uniscribe_font_driver): Add missing initializers.
2613
dee091a3
JD
26142011-03-23 Julien Danjou <julien@danjou.info>
2615
2616 * term.c (Fsuspend_tty, Fresume_tty):
2617 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2618 * window.c (temp_output_buffer_show):
2619 * insdel.c (signal_before_change):
2620 * frame.c (Fhandle_switch_frame):
2621 * fileio.c (Fdo_auto_save):
2622 * emacs.c (Fkill_emacs):
2623 * editfns.c (save_excursion_restore):
2624 * cmds.c (internal_self_insert):
2625 * callint.c (Fcall_interactively):
2626 * buffer.c (Fkill_all_local_variables):
2627 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2628 Use Frun_hooks.
0f4a96b5 2629 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2630 unconditionnaly since it does the check itself.
2631
2c520ab5 26322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2633
c9c49752
PE
2634 Fix more problems found by GCC 4.5.2's static checks.
2635
8abc3f12
PE
2636 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2637 the first time through the loop, since we know p0 < p1 then.
2638 This also avoids a gcc -Wstrict-overflow warning.
2639
a2d26660
PE
2640 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2641 leading to a memory leak, possible in functions like
2642 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2643 of objects (Bug#8318).
a2d26660 2644
916c72e9
PE
2645 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2646 that could (at least in theory) be that large.
2647
19ab8a18
PE
2648 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2649 This is less likely to overflow, and avoids undefined behavior if
2650 overflow does occur. All callers changed. Use strtoul to scan
2651 for the unsigned long integer.
b7cbbd6f
PE
2652 (pint2hrstr): Simplify and tune code slightly.
2653 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2654
f0641eff
PE
2655 * scroll.c (do_scrolling): Work around GCC bug 48228.
2656 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2657
7f650bb9
PE
2658 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2659 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2660 (validate_x_resource_name): Simplify count usage.
2661 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2662
37dd57d1
PE
2663 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2664 fail (Bug#8306).
81e56e61 2665
699979fc 2666 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2667
401bf9b4
PE
2668 * process.c (Fmake_network_process): Use socklen_t, not int,
2669 where POSIX says socklen_t is required in portable programs.
2670 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2671 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2672 (Fmake_network_process, server_accept_connection):
2673 (wait_reading_process_output, read_process_output):
2674 Likewise.
2675
b93aacde
PE
2676 * process.c: Rename or move locals to avoid shadowing.
2677 (list_processes_1, Fmake_network_process):
2678 (read_process_output_error_handler, exec_sentinel_error_handler):
2679 Rename or move locals.
4dc343ee 2680 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2681 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2682 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2683 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2684 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2685
af8a867c 2686 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2687 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2688 Include tparam.h instead, since it declares them.
af8a867c
PE
2689 * cm.h (PC): Remove extern decl; tparam.h now does this.
2690 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2691 * terminfo.c: Include tparam.h, to check interfaces.
2692 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2693 (tparam): Adjust signature to match interface in tparam.h;
2694 this removes some undefined behavior. Check that outstring and len
2695 are zero, which they always are with Emacs.
2696 * tparam.h (PC, BC, UP): New extern decls.
2697
0248044d 2698 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2699 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2700
8ff096c1 2701 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2702 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2703 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2704 (ftfont_list): Remove unused local.
49eaafba
PE
2705 (get_adstyle_property, ftfont_pattern_entity):
2706 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2707 Rename locals to avoid shadowing.
8ff096c1 2708
e2be39f6
PE
2709 * xfont.c (xfont_list_family): Mark var as initialized.
2710
c9735e30
PE
2711 * xml.c (make_dom): Now static.
2712
8f5201ae
PE
2713 * composite.c (composition_compute_stop_pos): Rename local to
2714 avoid shadowing.
b246f932
PE
2715 (composition_reseat_it): Remove unused locals.
2716 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2717 (composition_update_it): Mark var as initialized.
11b61122
PE
2718 (find_automatic_composition): Mark vars as initialized,
2719 with a FIXME (Bug#8290).
8f5201ae 2720
760fbc2c
PE
2721 character.h: Rename locals to avoid shadowing.
2722 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2723 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2724 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2725 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2726 to avoid shadowing.
2727
ff08eb85
PE
2728 * textprop.c (property_change_between_p): Remove; unused.
2729
fc7bf025
PE
2730 * intervals.c (interval_start_pos): Now static.
2731
235d7abc
PE
2732 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2733
44f230aa
SM
2734 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2735 Rename locals to avoid shadowing.
3e7d6594 2736
50060332
PE
2737 * sound.c (wav_play, au_play, Fplay_sound_internal):
2738 Fix pointer signedness.
d01f234b 2739 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2740 (wav_play): Initialize a variable to 0, to prevent undefined
2741 behavior (Bug#8278).
50060332 2742
c4fc4e30
PE
2743 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2744
918436ed
PE
2745 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2746
c939f91b
PE
2747 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2748 clobbering (Bug#8298).
b9c7f648
PE
2749 * sysdep.c (sys_subshell): Likewise.
2750 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2751
6bd8c144
PE
2752 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2753 This should get cleaned up, so that child_setup has the
2754 same signature on all platforms.
2755
7710357c 2756 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2757 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2758
c59da222
CY
27592011-03-22 Chong Yidong <cyd@stupidchicken.com>
2760
2761 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2762 not to be necessary, and produces flickering.
2763
66b87493
GM
27642011-03-20 Glenn Morris <rgm@gnu.org>
2765
2766 * config.in: Remove file.
2767
45b6f6d5
JB
27682011-03-20 Juanma Barranquero <lekktu@gmail.com>
2769
2770 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2771 are now in src/globals.h.
2772 (syms_of_minibuf): Remove spurious & from previous change.
2773
3ec03f7e
LL
27742011-03-20 Leo <sdl.web@gmail.com>
2775
2776 * minibuf.c (completing-read-function): New variable.
2777 (completing-read-default): Rename from completing-read.
2778 (completing-read): Call completing-read-function.
2779
b14e3e21
CY
27802011-03-19 Juanma Barranquero <lekktu@gmail.com>
2781
2782 * xfaces.c (Fx_load_color_file):
2783 Read color file from absolute filename (bug#8250).
2784
f2b726e6
JB
27852011-03-19 Juanma Barranquero <lekktu@gmail.com>
2786
2787 * makefile.w32-in: Update dependencies.
2788
09f6ff02
EZ
27892011-03-17 Eli Zaretskii <eliz@gnu.org>
2790
2791 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2792
29a6015a
PE
27932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2794
a3a6c54e
PE
2795 Fix more problems found by GCC 4.5.2's static checks.
2796
b766f867
PE
2797 * process.c (make_serial_process_unwind, send_process_trap):
2798 (sigchld_handler): Now static.
2799
be02381c
PE
2800 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2801 That way, the code declares only the vars that it needs.
2802 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2803 * s/cygwin.h (PTY_ITERATION): Likewise.
2804 * s/darwin.h (PTY_ITERATION): Likewise.
2805 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2806
57048744
PE
2807 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2808 * process.c (allocate_pty): Don't declare stb unless it's needed.
2809
7914961c 2810 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2811 (CONSTANTLIM): Remove; unused.
2812 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2813 Define only if needed.
7914961c 2814
b3967b18
PE
2815 * unexelf.c (unexec): Name an expression,
2816 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2817 Use a different way to cause a compilation error if anyone uses
2818 n rather than nn, a way that does not involve shadowing.
73366a00 2819 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2820
29a6015a
PE
2821 * deps.mk (unexalpha.o): Remove; unused.
2822
43cfc33e 2823 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2824 * unexec.h: New file.
ce701a33
PE
2825 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2826 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2827 Depend on unexec.h.
2828 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2829 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2830 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2831 Change as necessary to match prototype in unexec.h.
ce701a33 2832
01f44d5a
PE
2833 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2834 shadowing.
4f63c6bb 2835 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2836
a6670b0b
PE
2837 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2838 Rename locals to avoid shadowing.
2839
cef2010d 2840 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2841 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2842
d4d7173a
PE
2843 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2844
f08b802a
PE
2845 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2846 warning when compiling print.c.
2847
3ddb0639
PE
2848 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2849 instead of using an uninitialized var.
5ad03b97 2850 (font_sort_entities): Mark var as initialized.
3ddb0639 2851
170a2692
PE
2852 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2853
e663c700
PE
2854 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2855 pointers to constants.
89bc529a 2856 (font_parse_fcname): Remove unused vars.
7b81e2d0 2857 (font_delete_unmatched): Now static.
ea838e10 2858 (font_get_spec): Remove; unused.
13a547c6
PE
2859 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2860 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2861 Rename or move locals to avoid shadowing.
e663c700 2862
2a80c887 2863 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2864 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2865
1384fa33 2866 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2867 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2868
8b2c52e9
PE
2869 * alloc.c (mark_backtrace): Move decl from here ...
2870 * lisp.h: ... to here, so that it can be checked.
2871
475545b5 2872 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2873 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2874 (lisp_indirect_variable): Name an expression,
2875 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2876 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2877
b1349114 2878 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2879 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2880 Use const pointer when appropriate.
b1349114 2881
a2928364
PE
2882 * lisp.h (get_system_name, get_operating_system_release):
2883 Move decls here, to check interfaces.
2884 * process.c (get_operating_system_release): Move decl to lisp.h.
2885 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2886 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2887 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2888 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2889 (Fformat_time_string, Fencode_time, Finsert_char):
2890 (Ftranslate_region_internal, Fformat):
2891 Rename or remove local vars to avoid shadowing.
9710023e 2892 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2893
a415e694
PE
2894 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2895 avoid shadowing.
2896
8ef4622d
PE
2897 * lisp.h (eassert): Check that the argument compiles, even if
2898 ENABLE_CHECKING is not defined.
2899
946f9a5b
PE
2900 * data.c (Findirect_variable): Name an expression, to avoid
2901 gcc -Wbad-function-cast warning.
112396d6 2902 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2903 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2904 (Fmake_variable_buffer_local, Fmake_local_variable):
2905 Mark variables as initialized.
52746918 2906 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2907
e5aab7e7 2908 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2909 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2910 Rename locals to avoid shadowing.
dff45157
PE
2911 (mark_stack): Move local variables into the #ifdef region where
2912 they're used.
7bc26fdb
PE
2913 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2914 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2915 needed otherwise.
2916 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2917 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2918 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2919
e5aab7e7
PE
2920 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2921 avoids undefined behavior in theory.
2922
4da60324
PE
2923 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2924
88043301
PE
2925 Use functions, not macros, for up- and down-casing (Bug#8254).
2926 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2927 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2928 to use the following functions instead of these macros.
2929 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2930 EMACS_INT, since callers assume the returned value fits in int.
2931 (upcase1): Likewise, for UPCASE_TABLE.
2932 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2933 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2934 the race-condition problem in the old DOWNCASE.
88043301 2935
19ed5445
PE
2936 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2937 Rename locals to avoid shadowing.
2938 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2939 (regex_compile, re_search_2, re_match_2_internal):
2940 Remove unused local vars.
952db0d7
PE
2941 (FREE_VAR): Rewrite so as not to use empty "else",
2942 which gcc can warn about.
da053e48 2943 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2944 (RETALLOC_IF): Define only if needed.
2945 (WORDCHAR_P): Likewise. This one is never needed, but is used
2946 only in a comment talking about a compiler bug, so put inside
2947 the #if 0 of that comment.
2948 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2949 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2950 Remove; unused.
19ed5445 2951
1f3561e4 2952 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2953 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2954 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2955
ded6f8f7
PE
2956 * search.c (simple_search): Remove unused var.
2957
dbd37a95
PE
2958 * dired.c (compile_pattern): Move decl from here ...
2959 * lisp.h: ... to here, so that it can be checked.
2960 (struct re_registers): New forward decl.
2961
7e47afad
PE
2962 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2963
85f24f61
PE
2964 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2965 All uses changed.
2966 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2967 Rename locals to avoid shadowing.
5671df8f 2968 (Fvertical_motion): Mark locals as initialized.
85f24f61 2969
181aa2be 2970 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2971 (casify_region): Mark local as initialized.
181aa2be 2972
930d429c
PE
2973 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2974
7082eac6
PE
2975 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2976 New macros, so that the caller can use some names other than
2977 gcpro1, gcpro2, etc.
2978 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2979 of the new macros.
2980 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2981 argument, for consistency with GCPRO2_VAR, etc: it is now the
2982 prefix of the variable, not the variable itself. All uses
2983 changed.
38b2c076
PE
2984 * dired.c (directory_files_internal, file_name_completion):
2985 Rename locals to avoid shadowing.
2986
15206ed9
PE
2987 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2988 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2989 dired.c's scmp function, had undefined behavior.
2990 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2991 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2992 * buffer.h: ... to here, because these macros use current_buffer,
2993 and the new implementation with inline functions needs to have
2994 current_buffer in scope now, rather than later when the macros
2995 are used.
2996 (downcase, upcase1): New static inline functions.
2997 (DOWNCASE, UPCASE1): Reimplement using these functions.
2998 This avoids undefined behavior in expressions like
2999 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3000 from race conditions in accessing the global variables
3001 case_temp1 and case_temp2.
3002 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3003 * lisp.h (case_temp1, case_temp2): Remove their decls.
3004 * character.h (ASCII_CHAR_P): Move from here ...
3005 * lisp.h: ... to here, so that the inline functions mentioned
3006 above can use them.
3007
4a6bea26
PE
3008 * dired.c (directory_files_internal_unwind): Now static.
3009
f14b7e14
PE
3010 * fileio.c (file_name_as_directory, directory_file_name):
3011 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3012 Now static.
2893f146
PE
3013 (file_name_as_directory): Use const pointers when appropriate.
3014 (Fexpand_file_name): Likewise. In particular, newdir might
3015 point at constant storage, so make it a const pointer.
fd4ead52 3016 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3017 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3018 signedness issues.
f839df0c
PE
3019 (Fset_file_times, Finsert_file_contents, auto_save_error):
3020 Rename locals to avoid shadowing.
f14b7e14 3021
5716756e 3022 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3023 (Ftry_completion, Fall_completions): Rename or remove locals
3024 to avoid shadowing.
5716756e 3025
b4c3046a
PE
3026 * marker.c (bytepos_to_charpos): Remove; unused.
3027
b45db522
PE
3028 * lisp.h (verify_bytepos, count_markers): New decls,
3029 so that gcc does not warn that these functions aren't declared.
3030
85876d07
PE
3031 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3032 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3033 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3034 (copy_text): Remove unused local var.
85876d07 3035
03d78a21 3036 * filelock.c (within_one_second): Now static.
b3dd38ab 3037 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3038
5df8f01b
PE
3039 * buffer.c (fix_overlays_before): Mark locals as initialized.
3040 (fix_start_end_in_overlays): Likewise. This function should be
3041 simplified by using pointers-to-pointers, but that's a different
3042 matter.
b1d876f1 3043 (switch_to_buffer_1): Now static.
8f54f30a
PE
3044 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3045 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3046
a70072c9 3047 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3048 Fix pointer signedness issue.
edced198
PE
3049 (sys_subshell): Mark local as volatile if checking for lint,
3050 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3051 (MAXPATHLEN): Define only if needed.
a70072c9 3052
a0977c44
PE
3053 * process.c (serial_open, serial_configure): Move decls from here ...
3054 * systty.h: ... to here, so that they can be checked.
3055
a884fdcc
PE
3056 * fns.c (get_random, seed_random): Move extern decls from here ...
3057 * lisp.h: ... to here, so that they can be checked.
3058
604efe86 3059 * sysdep.c (reset_io): Now static.
b8950c94 3060 (wait_for_termination_signal): Remove; unused.
604efe86 3061
38fc62d9
PE
3062 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3063 (copy_keymap_item, append_key, push_text_char_description):
3064 Now static.
1004a21a 3065 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3066 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3067 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3068 (describe_map_tree):
3069 Rename locals to avoid shadowing.
38fc62d9 3070
2f2650da
PE
3071 * keyboard.c: Declare functions static if they are not used elsewhere.
3072 (echo_char, echo_dash, cmd_error, top_level_2):
3073 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3074 (read_char, kbd_buffer_get_event, make_lispy_position):
3075 (make_lispy_event, make_lispy_movement, apply_modifiers):
3076 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3077 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3078 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3079 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3080 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3081
a053e86c 3082 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3083 (mark_kboards): Move decl here ...
3084 * alloc.c (mark_kboards): ... from here.
a053e86c 3085
4752793e
PE
3086 * lisp.h (force_auto_save_soon): New decl.
3087
74f10ca7 3088 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3089 (DEFINE_DUMMY_FUNCTION): New macro.
3090 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3091 Use it.
c03cd23f
PE
3092 (main): Add casts to avoid warnings
3093 if GCC considers string literals to be constants.
74f10ca7 3094
022e70d4
PE
3095 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3096
59d6fe83
PE
3097 * dbusbind.c: Pointer signedness fixes.
3098 (xd_signature, xd_append_arg, xd_initialize):
3099 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3100 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3101 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3102 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3103
78320123
PE
3104 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3105 if GCC considers string literals to be constants.
49cebcca 3106 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3107
35ac2a97
SM
31082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3109
fb103ca9
SM
3110 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3111 (print_preprocess, print_object): New macro to fix last change.
3112
35ac2a97
SM
3113 * print.c (print_preprocess): Don't forget font objects.
3114
62973b41
JB
31152011-03-16 Juanma Barranquero <lekktu@gmail.com>
3116
3117 * emacs.c (USAGE3): Doc fixes.
3118
0e48bb22
AS
31192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3120
3121 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3122 structure.
3123
7684e57b
JB
31242011-03-14 Juanma Barranquero <lekktu@gmail.com>
3125
3126 * lisp.h (VWindow_system, Qfile_name_history):
3127 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3128 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3129 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3130
3131 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3132 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3133
3134 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3135 * w32console.c (detect_input_pending, read_input_pending)
3136 (encode_terminal_code):
3137 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3138 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3139 (w32_system_caret_y, Qfile_name_history):
3140 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3141 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3142 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3143 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3144 * w32proc.c (Qlocal, report_file_error):
3145 * w32term.c (Vwindow_system, updating_frame):
3146 * w32uniscribe.c (initialized, uniscribe_font_driver):
3147 Remove unneeded extern declarations.
3148
2aa46d6c
CY
31492011-03-14 Chong Yidong <cyd@stupidchicken.com>
3150
c96bbc66 3151 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3152
cffc6f3b
CY
31532011-03-13 Chong Yidong <cyd@stupidchicken.com>
3154
3155 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3156 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3157 These macros can no longer be used for assignment.
3158
44f230aa
SM
3159 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3160 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3161 (record_buffer_markers, fetch_buffer_markers): New functions for
3162 recording and fetching special buffer markers.
3163 (set_buffer_internal_1, set_buffer_temp): Use them.
3164
3165 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3166
3167 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3168
3169 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3170 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3171
3172 * xdisp.c (hscroll_window_tree):
3173 (reconsider_clip_changes): Use PT instead of BUF_PT.
3174
d251f04b
EZ
31752011-03-13 Eli Zaretskii <eliz@gnu.org>
3176
3177 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3178 $(EMACS_ROOT)/lib/intprops.h.
3179
f0c77cd1
PE
31802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3181
3eca4629
PE
3182 Fix more problems found by GCC 4.5.2's static checks.
3183
7c86ee98
PE
3184 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3185 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3186 (xg_free_frame_widgets): Make it clear that a local variable is
3187 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3188 (gdk_window_get_screen): Make it clear that this macro is needed
3189 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3190 (int_gtk_range_get_value): New function, which avoids a diagnostic
3191 from gcc -Wbad-function-cast.
3192 (xg_set_toolkit_scroll_bar_thumb): Use it.
3193 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3194 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3195 (get_utf8_string, xg_get_file_with_chooser):
3196 Rename locals to avoid shadowing.
3197 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3198
41729b81
PE
3199 * xgselect.c (xg_select): Remove unused var.
3200
f0c77cd1
PE
3201 * image.c (four_corners_best): Mark locals as initialized.
3202 (gif_load): Initialize transparent_p to zero (Bug#8238).
3203 Mark another local as initialized.
ec6cf4c6 3204 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3205
ce0ad53d 3206 * image.c (clear_image_cache): Now static.
d5d5a617 3207 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3208 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3209 (x_edge_detection): Remove unnecessary cast that
3210 gcc -Wbad-function-cast diagnoses.
2037898d 3211 (gif_load): Fix pointer signedness.
6ae141d6
PE
3212 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3213 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3214
33383987 32152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3216
d32df629
PE
3217 Improve quality of tests for time stamp overflow.
3218 For example, without this patch (encode-time 0 0 0 1 1
3219 1152921504606846976) returns the obviously-bogus value (-948597
3220 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3221 reports time overflow. See
3222 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3223 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3224 * editfns.c: Include limits.h and intprops.h.
3225 (TIME_T_MIN, TIME_T_MAX): New macros.
3226 (time_overflow): Move earlier, to before first use.
3227 (hi_time, lo_time): New functions, for an accurate test for
3228 out-of-range times.
3229 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3230 (Fget_internal_run_time): Don't assume time_t fits in int.
3231 (make_time): Use list2 instead of Fcons twice.
3232 (Fdecode_time): More accurate test for out-of-range times.
3233 (check_tm_member): New function.
3234 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3235 (lisp_time_argument): Don't rely on undefined left-shift and
3236 right-shift behavior when checking for time stamp overflow.
8be6f318 3237
fe31d94c
PE
3238 * editfns.c (time_overflow): New function, refactoring common code.
3239 (Fformat_time_string, Fdecode_time, Fencode_time):
3240 (Fcurrent_time_string): Use it.
3241
8be6f318
PE
3242 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3243 * dired.c (make_time): Move to ...
3244 * editfns.c (make_time): ... here.
3245 * systime.h: Note the move.
3246
09d9db2c 32472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3248
126bc0dc
YM
3249 * fringe.c (update_window_fringes): Remove unused variables.
3250
c47cbdfd
YM
3251 * unexmacosx.c (copy_data_segment): Also copy __got section.
3252 (Bug#8223)
3253
7ac80be9
EZ
32542011-03-12 Eli Zaretskii <eliz@gnu.org>
3255
c96bbc66 3256 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3257 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3258 Constify `char *' arguments and their references according to
3259 prototypes in tparam.h.
3260
ecb0f94d 3261 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3262
7ac80be9
EZ
3263 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3264 Adapt all references accordingly.
3265
3266 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3267
ef1fd07e
TT
32682011-03-11 Tom Tromey <tromey@redhat.com>
3269
3270 * buffer.c (syms_of_buffer): Remove obsolete comment.
3271
7ef4b50c
EZ
32722011-03-11 Eli Zaretskii <eliz@gnu.org>
3273
3274 * termhooks.h (encode_terminal_code): Declare prototype.
3275
3276 * msdos.c (encode_terminal_code): Don't declare prototype.
3277
3278 * term.c (encode_terminal_code): Now external again, used by
3279 w32console.c and msdos.c.
3280
44f230aa
SM
3281 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3282 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3283
4b1ec863 32842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3285
1714f52b 3286 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3287
4b1ec863
PE
3288 * fringe.c (update_window_fringes): Mark locals as initialized
3289 (Bug#8227).
3290 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3291
524c7aa6
PE
3292 * alloc.c (mark_fringe_data): Move decl from here ...
3293 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3294 to check its interface.
3295 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3296
a5c0af81 3297 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3298 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3299 (fontset_font): Mark local as initialized.
a9a06e0b 3300 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3301
b4716021
PE
3302 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3303
811e9bac 3304 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3305 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3306 (x_own_selection, Fx_disown_selection_internal): Rename locals
3307 to avoid shadowing.
3308 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3309
7e3ab302
PE
3310 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3311 so that the caller can use some name other than gcpro1.
3312 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3313 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3314 (Fx_backspace_delete_keys_p):
3315 Use them to avoid shadowing, and rename vars to avoid shadowing.
3316 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3317 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3318 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3319 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3320 Remove unused locals.
7e3ab302
PE
3321 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3322 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3323 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3324 macros.
f78faa98 3325
e2b13473
PE
3326 * xterm.h (x_mouse_leave): New decl.
3327
77f23912
PE
3328 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3329 Remove unused functions.
cdf4ba58
PE
3330 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3331 (x_calc_absolute_position): Now static.
7411c686 3332 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3333 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3334 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3335 unless they are used.
38d0b34a
PE
3336 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3337 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3338 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3339 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3340 (x_error_catcher, x_connection_closed, x_error_handler):
3341 (x_error_quitter, xembed_send_message, x_iconify_frame):
3342 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3343 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3344 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3345
44f230aa
SM
3346 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3347 Rename or move locals to avoid shadowing.
6b463e58 3348 (tty_defined_color, merge_face_heights): Now static.
5967d051 3349 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3350 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3351 does not deduce is never used uninitialized.
73719eba
PE
3352 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3353 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3354
426994c3 3355 * terminal.c (store_terminal_param): Now static.
5489860b 3356
032f1620 3357 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3358 (set_frame_menubar): Remove unused local.
d4323972 3359 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3360 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3361 since they might point to immutable storage.
281585b0
PE
3362 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3363 since it's unused otherwise.
032f1620 3364
367c19e5 3365 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3366 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3367 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3368 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3369 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3370 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3371 does not deduce are never used uninitialized.
70739cbe 3372
07b48fa9
PE
3373 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3374
8868a238 3375 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3376 * window.c (window_loop, size_window):
3377 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3378
7e5cf297 3379 * window.c (display_buffer): Now static.
d6550a9f
PE
3380 (size_window): Mark variables that gcc -Wuninitialized
3381 does not deduce are never used uninitialized.
a586633d
PE
3382 * window.h (check_all_windows): New decl, to forestall
3383 gcc -Wmissing-prototypes diagnostic.
5b555da1 3384 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3385
f6095868
PE
3386 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3387 shadowing.
3388 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3389 Include <limits.h>.
3390 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3391 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3392 (load_charset_map): Mark variables that gcc -Wuninitialized
3393 does not deduce are never used uninitialized.
53df7c11 3394 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3395
f38b440c
PE
3396 * coding.c (coding_set_source, coding_set_destination):
3397 Use "else { /* comment */ }" rather than "else /* comment */;"
3398 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3399 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3400 a block, when the outer 'i' will do.
3401 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3402 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3403 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3404 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3405 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3406 Rename locals to avoid shadowing.
3407 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3408 * coding.c (emacs_mule_char, encode_invocation_designation):
3409 Now static, since they're not used elsewhere.
413bb2db 3410 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3411 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3412 (decode_coding_emacs_mule): Mark variables that gcc
3413 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3414 (detect_coding_iso_2022): Initialize a local variable that might
3415 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3416 this initialization is needed. (Bug#8211)
5f58e762
PE
3417 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3418 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3419 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3420 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3421 Remove unused macros.
f38b440c 3422
232b38b9 3423 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3424 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3425 * character.c (string_count_byte8): Likewise.
232b38b9 3426
fb90da1b
PE
3427 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3428 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3429
fb93dbc2
PE
3430 * chartab.c (copy_sub_char_table): Now static, since it's not used
3431 elsewhere.
5c156ace
PE
3432 (sub_char_table_ref_and_range, char_table_ref_and_range):
3433 Rename locals to avoid shadowing.
bbcd0949 3434 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3435
7d3b3862 3436 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3437 (BIDI_BOB): Remove unused macro.
7d3b3862 3438
6be7d3da
PE
3439 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3440 deduce are never used uninitialized.
c2ed9c8b 3441 * term.c (encode_terminal_code): Likewise.
6be7d3da 3442
75f8807f 3443 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3444
50938595
PE
3445 * tparam.h: New file.
3446 * term.c, tparam.h: Include it.
3447 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3448 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3449 Move these decls to tparam.h, and make them agree with what
3450 is actually in tparam.c. The previous trick of using incompatible
3451 decls in different modules does not conform to the C standard.
3452 All callers of tparam changed to use tparam's actual API.
3453 * tparam.c (tparam1, tparam, tgoto):
3454 Use const pointers where appropriate.
3455
fbceeba2
PE
3456 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3457 * cm.h (struct cm): Likewise.
3458 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3459 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3460 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3461 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3462 (turn_on_face, init_tty): Likewise.
3463 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3464
7f3f1250
PE
3465 * term.c (term_mouse_position): Rename local to avoid shadowing.
3466
e6ca6543
PE
3467 * alloc.c (mark_ttys): Move decl from here ...
3468 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3469
c40f8d15
AS
34702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3471
3472 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3473
cfe0661d
JB
34742011-03-09 Juanma Barranquero <lekktu@gmail.com>
3475
3476 * search.c (compile_pattern_1): Remove argument regp, unused since
3477 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3478 (compile_pattern): Don't pass it.
3479
0afb4571
J
34802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3481
3482 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3483 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3484 for ! HAVE_GTK3.
3485 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3486
3487 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3488
3489 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3490 gdk_window_get_screen, gdk_window_get_geometry,
3491 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3492 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3493 (xg_get_pixbuf_from_pixmap): New function.
3494 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3495 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3496 Call xg_get_pixbuf_from_pixmap instead of
3497 gdk_pixbuf_get_from_drawable.
3498 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3499 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3500 (xg_check_special_colors): Use GtkStyleContext and its functions
3501 for HAVE_GTK3.
3502 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3503 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3504 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3505 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3506 Call gtk_widget_get_preferred_size.
0afb4571
J
3507 (xg_frame_resized): gdk_window_get_geometry only takes 5
3508 parameters.
44f230aa
SM
3509 (xg_win_to_widget, xg_event_is_for_menubar):
3510 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3511 (xg_set_widget_bg): New function.
3512 (delete_cb): New function.
895009e1 3513 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3514 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3515 (xg_set_background_color): Call xg_set_widget_bg.
3516 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3517 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3518 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3519 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3520 if ! HAVE_GTK3.
3521 (update_frame_tool_bar): Call gtk_widget_hide.
3522 (xg_initialize): Use GDK_KEY_g.
3523
3524 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3525 if ! HAVE_GTK3
3526 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3527
3528 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3529 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3530 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3531
1c2cc4ef
JB
35322011-03-08 Juanma Barranquero <lekktu@gmail.com>
3533
3534 * w32xfns.c (select_palette): Check success of RealizePalette against
3535 GDI_ERROR, not zero.
3536
33383987 3537See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3538
3539;; Local Variables:
3540;; coding: utf-8
aac0c6e3
MR
3541;; End:
3542
33383987 3543 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3544
3545 This file is part of GNU Emacs.
3546
3547 GNU Emacs is free software: you can redistribute it and/or modify
3548 it under the terms of the GNU General Public License as published by
3549 the Free Software Foundation, either version 3 of the License, or
3550 (at your option) any later version.
3551
3552 GNU Emacs is distributed in the hope that it will be useful,
3553 but WITHOUT ANY WARRANTY; without even the implied warranty of
3554 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3555 GNU General Public License for more details.
3556
3557 You should have received a copy of the GNU General Public License
3558 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.