Refactoring with bidi_fetch_char tested and debugged.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
102ebb00
EZ
12011-05-14 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (bidi_fetch_char): Accept also character position
4 corresponding to BYTEPOS. All callers changed.
5 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6 (bidi_resolve_explicit, bidi_resolve_weak)
7 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8 bidi_it->nchars is non-positive.
9 (bidi_level_of_next_char): Don't try to lookup the cache for the
10 next/previous character if nothing is cached there yet, or if we
11 were just reseat()'ed to a new position.
12 (bidi_paragraph_init, bidi_resolve_explicit_1)
13 (bidi_level_of_next_char): Fix arguments in the calls to
14 bidi_fetch_char.
15
182ce2d2
EZ
162011-05-10 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (compute_display_string_pos): New function.
19 (reseat_1): Initialize bidi_it.disp_pos.
20
21 * bidi.c (bidi_copy_it): Use offsetof.
22 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
23 (bidi_cache_search, bidi_cache_iterator_state)
24 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
25 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
26 character positions inside a run of characters covered by a
27 display string.
28 (bidi_paragraph_init, bidi_resolve_explicit_1)
29 (bidi_level_of_next_char): Call bidi_fetch_char and
30 bidi_fetch_char_advance instead of FETCH_CHAR and
31 FETCH_CHAR_ADVANCE.
32 (bidi_init_it): Initialize new members.
33 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
34 definitions.
35 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
36 instead of using explicit *_CHAR codes.
37 (bidi_resolve_explicit, bidi_resolve_weak): Use
38 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
39 bidirectional text is supported only in multibyte buffers.
40
41 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
42 ch_len is now EMACS_INT.
43 (compute_display_string_pos): Declare prototype.
44
57679c86
AS
452011-05-09 Andreas Schwab <schwab@linux-m68k.org>
46
47 * w32menu.c (set_frame_menubar): Fix submenu allocation.
48
888c9e86
EZ
492011-05-07 Eli Zaretskii <eliz@gnu.org>
50
b0512a1d
EZ
51 * w32console.c (Fset_screen_color): Doc fix.
52 (Fget_screen_color): New function.
53 (syms_of_ntterm): Defsubr it.
54
888c9e86
EZ
55 * callproc.c (call_process_cleanup): Don't close and unlink the
56 temporary file if Fcall_process didn't create it in the first
57 place.
58 (Fcall_process): Don't create tempfile if stdout of the child
59 process will be redirected to a file specified with `:file'.
60 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
61 cue to call_process_cleanup not to close that handle.
62
4d3fcc8e
BK
632011-05-07 Ben Key <bkey76@gmail.com>
64
65 * makefile.w32-in: The bootstrap-temacs rule now makes use of
66 one of two shell specific rules, either bootstrap-temacs-CMD or
67 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
68 to the previous implementation of the bootstrap-temacs rule.
69 The bootstrap-temacs-CMD rule is similar to the previous
70 implementation of the bootstrap-temacs rule except that it
71 makes use of the ESC_CFLAGS variable instead of the CFLAGS
72 variable.
73
74 These changes, along with some changes to nt/configure.bat,
75 nt/gmake.defs, and nt/nmake.defs, are required to extend my
76 earlier fix to add support for --cflags and --ldflags options
77 that include quotes so that it works whether make uses cmd or
78 sh as the shell.
79
b4289b64
MA
802011-05-06 Michael Albinus <michael.albinus@gmx.de>
81
82 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
83 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
84 is a constant.
85 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
86 a string. Handle both cases.
87 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
88 (Fdbus_register_method): Use Qinvalid_function.
89
af4c0e28
JB
902011-05-06 Juanma Barranquero <lekktu@gmail.com>
91
92 * makefile.w32-in: Update dependencies.
93 (LISP_H): Add inttypes.h and stdin.h.
94 (PROCESS_H): Add unistd.h.
95
c51453d9
EZ
962011-05-06 Eli Zaretskii <eliz@gnu.org>
97
98 * lread.c: Include limits.h (fixes the MS-Windows build broken by
99 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
100
8ff0ac3c 1012011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 102
4c4b566b
PE
103 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
104
aab2b9b5
PE
105 * term.c (vfatal): Remove stray call to va_end.
106 It's not needed and the C Standard doesn't allow it here anyway.
107
c378da0b
PE
108 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
109 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
110
288b08c7
PE
111 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
112 bytes.
113
e3601888
PE
114 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
115
db6c0e74
PE
116 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
117
dd5963ea
PE
118 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
119
88c9450f
PE
120 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
121
2f9442b8
PE
122 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
123
c032b5f8
PE
124 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
125 * charset.c (Fdefine_charset_internal): Don't initialize
126 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 127 32-bit int (Bug#8600).
a108c10b
PE
128
129 * lread.c (read_integer): Be more consistent with string-to-number.
130 Use string_to_number to do the actual conversion; this avoids
131 rounding errors and fixes some other screwups. Without this fix,
132 for example, #x1fffffffffffffff was misread as -2305843009213693952.
133 (digit_to_number): Move earlier, for benefit of read_integer.
134 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 135 not a digit in any supported base. (Bug#8602)
a108c10b 136
ad5f9eea
PE
137 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
138
aec1708a
PE
139 * dispnew.c (scrolling_window): Return 1 if we scrolled,
140 to match comment at start of function. This also removes a
141 GCC warning about overflow in a 32+64-bit port.
142
47be4ab5
PE
143 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
144
371cac43
PE
145 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
146 Reported by Stefan Monnier in
147 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
148 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
149 SYMBOLP-guarded XSYMBOL, not XPNTR.
150
d01a7826
PE
151 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
152 (EMACS_UINTPTR): Likewise, with uintptr_t.
153
7fd47d5c
PE
154 * lisp.h: Prefer 64-bit EMACS_INT if available.
155 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
156 on 32-bit hosts that have 64-bit int, so that they can access
157 large files.
122b0c86
PE
158 However, temporarily disable this change unless the temporary
159 symbol WIDE_EMACS_INT is defined.
7fd47d5c 160
8727937b
PE
161 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
162
8ac068ac
PE
163 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
164 This removes an assumption that EMACS_INT and long are the same
165 width as pointers. The assumption is true for Emacs porting targets
166 now, but we want to make other targets possible.
167 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
168 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
169 In the rest of the code, change types of integers that hold casted
170 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
171 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
172 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
173 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
174 No need to cast type when ORing.
175 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
176 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
177 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
178 assume EMACS_INT is the same width as char *.
179 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
180 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
181 Remove no-longer-needed casts.
182 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
183 (xg_tool_bar_help_callback, xg_make_tool_item):
184 Use EMACS_INTPTR to hold an integer
185 that will be cast to void *; this can avoid a GCC warning
186 if EMACS_INT is not the same width as void *.
187 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
188 * xdisp.c (display_echo_area_1, resize_mini_window_1):
189 (current_message_1, set_message_1):
190 Use a local to convert to proper width without a cast.
191 * xmenu.c (dialog_selection_callback): Likewise.
192
ede49d71
PE
193 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
194 Also, don't assume VALBITS / RAND_BITS is less than 5,
195 and don't rely on undefined behavior when shifting a 1 left into
196 the sign bit.
197 * lisp.h (get_random): Change signature to match.
198
2f30ecd0
PE
199 * lread.c (hash_string): Use size_t, not int, for hash computation.
200 Normally we prefer signed values; but hashing is special, because
201 it's better to use unsigned division on hash table sizes so that
202 the remainder is nonnegative. Also, size_t is the natural width
203 for hashing into memory. The previous code used 'int', which doesn't
204 retain enough info to hash well into very large tables.
205 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
206
2a866e7b
PE
207 * dbusbind.c: Don't possibly lose pointer info when converting.
208 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
209 Use XPNTR rather than XHASH, so that the high-order bits of
210 the pointer aren't lost when converting through void *.
211
51639eac
PE
212 * eval.c (Fautoload): Don't double-shift a pointer.
213
92394119
PE
214 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
215
dbdb9a7c
JB
2162011-05-06 Juanma Barranquero <lekktu@gmail.com>
217
218 * gnutls.c (DEF_GNUTLS_FN):
219 * image.c (DEF_IMGLIB_FN): Make function pointers static.
220
db7a0b4f
AS
2212011-05-05 Andreas Schwab <schwab@linux-m68k.org>
222
223 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
224 marker. (Bug#8610)
225
f7ff1b0f 2262011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
227
228 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
229 New version that can reserve upto 2GB of heap space.
230
f7ff1b0f 2312011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
232
233 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
234
639c109b
TZ
2352011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
236
237 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
238 `gnutls_certificate_set_x509_key_file'.
239
d2127135
JB
2402011-05-05 Juanma Barranquero <lekktu@gmail.com>
241
242 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
243 Update dependencies.
244
e968f4f3
JB
2452011-05-04 Juanma Barranquero <lekktu@gmail.com>
246
247 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
248 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
249 Remove unused parameter `fildes'.
250 * process.c (read_process_output, send_process): Don't pass it.
251
84d358f0
JB
2522011-05-04 Juanma Barranquero <lekktu@gmail.com>
253
254 Fix previous change: the library cache is defined in w32.c.
255 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
256 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
257
0898ca10
JB
2582011-05-04 Juanma Barranquero <lekktu@gmail.com>
259
260 Implement dynamic loading of GnuTLS on Windows.
261
262 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
263 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
264 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
265 Declare.
266
267 * gnutls.c (Qgnutls_dll): Define.
268 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
269 (gnutls_*): Declare function pointers.
270 (init_gnutls_functions): New function to initialize function pointers.
271 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
272 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
273 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
274 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
275 (emacs_gnutls_write, emacs_gnutls_read)
276 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
277 (Fgnutls_available_p): New function.
278 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
279 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
280 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
281
282 * image.c: Include w32.h.
283 (Vimage_type_cache): Delete.
284 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
285 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
286 (w32_delayed_load): Move to w32.c.
287
288 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
289
290 * w32.c (QCloaded_from, Vlibrary_cache): Define.
291 (w32_delayed_load): Move from image.c. When loading a library, record
292 its filename in the :loaded-from property of the library id.
293 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
294 Initialize and staticpro them.
295 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
296
297 * process.c: Include lisp.h before w32.h, not after.
298 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
299 instead of gnutls_record_check_pending.
300
301 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
302
ff4de4aa
TZ
3032011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
304
305 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
306 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
307 as passed in.
308
abe95abb
JD
3092011-05-03 Jan Djärv <jan.h.d@swipnet.se>
310
311 * xterm.c (x_set_frame_alpha): Do not set property on anything
312 else than FRAME_X_OUTER_WINDOW (Bug#8608).
313
e16e55d4
JB
3142011-05-02 Juanma Barranquero <lekktu@gmail.com>
315
316 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
317
bafcf6a5
JB
3182011-05-02 Juanma Barranquero <lekktu@gmail.com>
319
320 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
321 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
322 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
323 (gnutls_global_initialized, Qgnutls_bootprop_priority)
324 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
325 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
326 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
327 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
328 (Qgnutls_bootprop_callbacks_verify): Make static.
329
e7a6747f
AS
3302011-05-01 Andreas Schwab <schwab@linux-m68k.org>
331
19ed11ba
AS
332 * callproc.c: Indentation fixup.
333
e7a6747f
AS
334 * sysdep.c (wait_for_termination_1): Make static.
335 (wait_for_termination, interruptible_wait_for_termination): Move
336 after wait_for_termination_1.
337
1ef14cb4
LMI
3382011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
339
340 * sysdep.c (interruptible_wait_for_termination): New function
341 which is like wait_for_termination, but allows keyboard
342 interruptions.
343
344 * callproc.c (Fcall_process): Add (:file "file") as an option for
345 the STDOUT buffer.
346 (Fcall_process_region): Ditto.
347
330d880c
EZ
3482011-04-30 Eli Zaretskii <eliz@gnu.org>
349
8db90b73
EZ
350 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
351 rather than `XVECTOR (FOO)->size'.
352
330d880c
EZ
353 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
354 inttypes.h, as a gnulib replacement is used if it not available in
355 system headers.
356
15cbd324
EZ
3572011-04-21 Eli Zaretskii <eliz@gnu.org>
358
359 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
360 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
361 of MOST_POSITIVE_FIXNUM. (Bug#8528)
362
363 * coding.c (coding_alloc_by_realloc): Error out if destination
364 will grow beyond MOST_POSITIVE_FIXNUM.
365 (decode_coding_emacs_mule): Abort if there isn't enough place in
366 charbuf for the composition carryover bytes. Reserve an extra
367 space for up to 2 characters produced in a loop.
368 (decode_coding_iso_2022): Abort if there isn't enough place in
369 charbuf for the composition carryover bytes.
370
3712011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 372
ae940cca
EZ
373 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
374 aborting when %lld or %lll format is passed.
375 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
376 %llo or %llx format is passed. (Bug#8545)
377
03ab8921
EZ
378 * window.c (window_scroll_line_based): Use a marker instead of
379 simple variables to record original value of point. (Bug#7952)
380
afda1437
EZ
381 * doprnt.c (doprnt): Fix the case where a multibyte sequence
382 produced by %s or %c overflows available buffer space. (Bug#8545)
383
f76dee0c
PE
3842011-04-28 Paul Eggert <eggert@cs.ucla.edu>
385
386 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 387 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 388
fdc5744d
JB
3892011-04-28 Juanma Barranquero <lekktu@gmail.com>
390
391 * w32.c (init_environment): Warn about defaulting HOME to C:\.
392
638f053a
JB
3932011-04-28 Juanma Barranquero <lekktu@gmail.com>
394
395 * keyboard.c (Qdelayed_warnings_hook): Define.
396 (command_loop_1): Run `delayed-warnings-hook'
397 if Vdelayed_warnings_list is non-nil.
398 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
399 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
400
d178f871
EZ
4012011-04-28 Eli Zaretskii <eliz@gnu.org>
402
403 * doprnt.c (doprnt): Don't return value smaller than the buffer
404 size if the message was truncated. (Bug#8545).
405
b124fd93
JB
4062011-04-28 Juanma Barranquero <lekktu@gmail.com>
407
408 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
409 (Fx_window_property): #if-0 the whole functions, not just the bodies.
410
e810457d
PE
4112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
412
413 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
414
ea51cceb
JB
4152011-04-27 Juanma Barranquero <lekktu@gmail.com>
416
417 * makefile.w32-in: Update dependencies.
418
94dcfacf
EZ
4192011-04-27 Eli Zaretskii <eliz@gnu.org>
420
421 Improve `doprnt' and its usage. (Bug#8545)
422 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
423 `format_end'. Remove support for %l as a conversion specifier.
424 Don't use xrealloc. Improve diagnostics when the %l size modifier
425 is used. Update the commentary.
426
427 * eval.c (verror): Simplify calculation of size_t.
428
429 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
430 messages.
431
f61f41d7
PE
4322011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
433
434 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
435 change.
436
96fb4434
PE
4372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
438
439 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
440 This makes this file independent of the recent pseudovector change.
441
671875da 4422011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 443
69e9b5a3
PE
444 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
445
b5f869a7 446 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 447 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 448 Remove unused local.
c8926152 449 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 450
841a1577 451 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
452 GCC 4.6.0 optimizes based on type-based alias analysis. For
453 example, if b is of type struct buffer * and v of type struct
454 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
455 != &v->size, and therefore "v->size = 1; b->size = 2; return
456 v->size;" must therefore return 1. This assumption is incorrect
457 for Emacs, since it type-puns struct Lisp_Vector * with many other
458 types. To fix this problem, this patch adds a new type struct
f904488f 459 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
460 and pseudovectors, and helps optimizing compilers not get fooled
461 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
462 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
463 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
464 the size member.
eab3844f
PE
465 (XSETPVECTYPE): Rewrite in terms of new macro.
466 (XSETPVECTYPESIZE): New macro, specifying both type and size.
467 This is a bit clearer, and further avoids the possibility of
468 undesirable aliasing.
469 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 470 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
471 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
472 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
473 (ASIZE): Now uses header.size rather than size. All
474 previous uses of XVECTOR (foo)->size replaced to use this macro,
475 to avoid the hassle of writing XVECTOR (foo)->header.size.
476 (struct vectorlike_header): New type.
eab3844f
PE
477 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
478 object, to help avoid aliasing.
479 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
480 (SUBRP): Likewise, since Lisp_Subr is a special case.
481 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
482 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
483 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 484 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
485 changed to be "header.size" and "header.next".
486 * buffer.h (struct buffer): Likewise.
487 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
488 * frame.h (struct frame): Likewise.
489 * process.h (struct Lisp_Process): Likewise.
490 * termhooks.h (struct terminal): Likewise.
491 * window.c (struct save_window_data, struct saved_window): Likewise.
492 * window.h (struct window): Likewise.
493 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
494 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
495 * buffer.c (init_buffer_once): Likewise.
496 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
497 special case.
498 * process.c (Fformat_network_address): Use local var for size,
499 for brevity.
500
0df1eac5
PE
501 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
502
847ab9d1 503 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
504 * data.c (atof): Remove decl; no longer used or needed.
505 (digit_to_number): Move to lread.c.
506 (Fstring_to_number): Use new string_to_number function, to be
507 consistent with how the Lisp reader treats infinities and NaNs.
508 Do not assume that floating-point numbers represent EMACS_INT
509 without losing information; this is not true on most 64-bit hosts.
510 Avoid double-rounding errors, by insisting on integers when
511 parsing non-base-10 numbers, as the documentation specifies.
512 * lisp.h (string_to_number): New decl, replacing ...
513 (isfloat_string): Remove.
bc0a5c13 514 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 515 (read1): Do not accept +. and -. as integers; this
452f4150
PE
516 appears to have been a coding error. Similarly, do not accept
517 strings like +-1e0 as floating point numbers. Do not report
518 overflow for integer overflows unless the base is not 10 which
519 means we have no simple and reliable way to continue.
520 Break out the floating-point parsing into a new
521 function string_to_number, so that Fstring_to_number parses
522 floating point numbers consistently with the Lisp reader.
523 (digit_to_number): Moved here from data.c. Make it static inline.
524 (E_CHAR, EXP_INT): Remove, replacing with ...
525 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
526 (string_to_number): New function, replacing isfloat_string.
527 This function checks for valid syntax and produces the resulting
528 Lisp float number too. Rework it so that string-to-number
bc0a5c13 529 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
530 so that overflow for non-base-10 numbers is reported only when
531 there's no portable and simple way to convert to floating point.
452f4150 532
67769ffc
PE
533 * textprop.c (set_text_properties_1): Rewrite for clarity,
534 and to avoid GCC warning about integer overflow.
535
c20db43f
PE
536 * intervals.h (struct interval): Use EMACS_INT for members
537 where EMACS_UINT might cause problems. See
538 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
539 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
540 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
541 All uses changed.
37aa2f85
PE
542 (offset_intervals): Tell GCC not to worry about length overflow
543 when negating a negative length.
c20db43f 544
2538aa2f
PE
545 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
546 (overrun_check_free): Likewise.
547
f2d3008d
PE
548 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
549 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
550 word size.
551
ec8df744
PE
552 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
553 (gnutls_make_error): Rename local to avoid shadowing.
554 (gnutls_emacs_global_deinit): ifdef out; not used.
555 (Fgnutls_boot): Use const for pointer to readonly storage.
556 Comment out unused local. Fix pointer signedness problems.
557
640ee02d
PE
558 * lread.c (openp): Don't stuff size_t into an 'int'.
559 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
560 about possible signed overflow.
561
6048fb2a
PE
562 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
563 (GDK_KEY_g): Don't define if already defined.
564 (xg_prepare_tooltip): Avoid pointer signedness problem.
565 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
566
fa3c87e1
PE
567 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
568 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
569
2172544b
PE
570 * xfns.c (Fx_window_property): Simplify a bit,
571 to make a bit faster and to avoid GCC 4.6.0 warning.
572 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
573
9b821a21
PE
574 * fns.c (internal_equal): Don't assume size_t fits in int.
575
3c616cfa
PE
576 * alloc.c (compact_small_strings): Tighten assertion a little.
577
c2982e87
PE
578 Replace pEd with more-general pI, and fix some printf arg casts.
579 * lisp.h (pI): New macro, generalizing old pEd macro to other
580 conversion specifiers. For example, use "...%"pI"d..." rather
581 than "...%"pEd"...".
582 (pEd): Remove. All uses replaced with similar uses of pI.
583 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
584 * alloc.c (check_pure_size): Don't overflow by converting size to int.
585 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
586 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
587 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
588 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
589 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
590 64-bit hosts.
591 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
592 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
593 * print.c (safe_debug_print, print_object): Likewise.
594 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
595 to int.
6f04d126
PE
596 Use pI instead of if-then-else-abort. Use %p to avoid casts,
597 avoiding the 0 flag, which is not portable.
c2982e87
PE
598 * process.c (Fmake_network_process): Use pI to avoid cast.
599 * region-cache.c (pp_cache): Likewise.
600 * xdisp.c (decode_mode_spec): Likewise.
601 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
602 behavior on 64-bit hosts with printf arg.
6f04d126 603 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
604 (x_stop_queuing_selection_requests): Likewise.
605 (x_get_window_property): Don't truncate byte count to an 'int'
606 when tracing.
0b432f21 607
5e073ec7
PE
608 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
609 here, since it parses constructs like leading '-' and spaces,
610 which are not wanted; and it overflows with large numbers.
611 Instead, simply match F[0-9]+, which is what is wanted anyway.
612
36372bf9
PE
613 * alloc.c: Remove unportable assumptions about struct layout.
614 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
615 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
616 (allocate_vectorlike, make_pure_vector): Use the new macros,
617 plus offsetof, to remove unportable assumptions about struct layout.
618 These assumptions hold on all porting targets that I know of, but
619 they are not guaranteed, they're easy to remove, and removing them
620 makes further changes easier.
621
0b432f21
PE
622 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
623 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
624 (string_overrun_cookie): Now const. Use initializers that
625 don't formally overflow signed char, to avoid warnings.
000098c1
PE
626 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
627 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
628 (allocate_buffer): Don't assume sizeof (struct buffer) is a
629 multiple of sizeof (EMACS_INT); it need not be, if
630 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 631 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 632
895009e1
JB
6332011-04-26 Juanma Barranquero <lekktu@gmail.com>
634
635 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
636
6a7a1b0b
TZ
6372011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
638
639 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 640 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
641 Reported by Paul Eggert <eggert@cs.ucla.edu>.
642
841a1577 6432011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
644
645 * lisp.h (Qdebug): List symbol.
895009e1 646 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
647 * keyboard.c (debug-on-event): New variable.
648 (handle_user_signal): Break into debugger when debug-on-event
649 matches the current signal symbol.
650
f2d3ba6f
DN
6512011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
652
653 * alloc.c (check_sblock, check_string_bytes)
654 (check_string_free_list): Convert to standard C.
655
42ce4c63
TZ
6562011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
657
658 * w32.c (emacs_gnutls_push): Fix typo.
659
825cd63c
EZ
6602011-04-25 Eli Zaretskii <eliz@gnu.org>
661
fb11d64d
EZ
662 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
663 "cast to pointer from integer of different size".
664
825cd63c
EZ
665 Improve doprnt and its use in verror. (Bug#8545)
666 * doprnt.c (doprnt): Document the set of format control sequences
667 supported by the function. Use SAFE_ALLOCA instead of always
668 using `alloca'.
669
670 * eval.c (verror): Don't limit the buffer size at size_max-1, that
671 is one byte too soon. Don't use xrealloc; instead xfree and
672 xmalloc anew.
673
e061a11b
TZ
6742011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
675
676 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
677 callbacks stage.
678
679 * gnutls.c: Renamed global_initialized to
680 gnutls_global_initialized. Added internals for the
681 :verify-hostname-error, :verify-error, and :verify-flags
682 parameters of `gnutls-boot' and documented those parameters in the
683 docstring. Start callback support.
684 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
685 unless a fatal error occured. Call gnutls_alert_send_appropriate
686 on error. Return error code.
687 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
688 (emacs_gnutls_read): Likewise.
689 (Fgnutls_boot): Return handshake error code.
690 (emacs_gnutls_handle_error): New function.
691 (wsaerror_to_errno): Likewise.
692
693 * w32.h (emacs_gnutls_pull): Add prototype.
694 (emacs_gnutls_push): Likewise.
695
696 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
697 (emacs_gnutls_push): Likewise.
698
6992011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
700
701 * process.c (wait_reading_process_output): Check if GnuTLS
702 buffered some data internally if no FDs are set for TLS
703 connections.
704
705 * makefile.w32-in (OBJ2): Add gnutls.$(O).
706 (LIBS): Link to USER_LIBS.
707 ($(BLD)/gnutls.$(0)): New target.
708
fa6996bc
EZ
7092011-04-24 Eli Zaretskii <eliz@gnu.org>
710
eb35682e
EZ
711 * xdisp.c (handle_single_display_spec): Rename the
712 display_replaced_before_p argument into display_replaced_p, to
713 make it consistent with the commentary. Fix typos in the
714 commentary.
715
e2ad650c
EZ
716 * textprop.c (syms_of_textprop): Remove dead code.
717 (copy_text_properties): Delete obsolete commentary about an
718 interface that was deleted long ago. Fix typos in the description
719 of arguments.
720
1b2de274
EZ
721 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
722 to changes in oldXMenu/XMenu.h from 2011-04-16.
723 <menu_help_message, prev_menu_help_message>: Constify.
724 (IT_menu_make_room): menu->help_text is now `const char **';
725 adjust.
726
727 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
728 to changes in oldXMenu/XMenu.h from 2011-04-16.
729 (struct XMenu): Declare `help_text' `const char **'.
730
731 * xfaces.c <Qunspecified>: Make extern again.
732
733 * syntax.c: Include sys/types.h before including regex.h, as
734 required by Posix.
735
762b15be
EZ
736 * doc.c (get_doc_string): Improve the format passed to `error'.
737
738 * doprnt.c (doprnt): Improve commentary.
739
740 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
741
742 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
743 them with etags.
744
f1052e5d
EZ
745 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
746 changes in globals.h immediately force recompilation.
762b15be
EZ
747 (TAGS): Depend on $(CURDIR)/m/intel386.h and
748 $(CURDIR)/s/ms-w32.h.
749 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 750
fa6996bc
EZ
751 * character.c (Fchar_direction): Function deleted.
752 (syms_of_character): Don't defsubr it.
753 <char-direction-table>: Deleted.
754
e6c3da20
EZ
7552011-04-23 Eli Zaretskii <eliz@gnu.org>
756
757 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
758 * doprnt.c: Include limits.h.
759 (SIZE_MAX): New macro.
760 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
761 local variables are now size_t instead of int or unsigned.
762 Improve overflow protection. Support `l' modifier for integer
763 conversions. Support %l conversion. Don't assume an EMACS_INT
764 argument for integer conversions and for %c.
765
766 * lisp.h (doprnt): Restore prototype.
767
768 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
769 $(SRC)/character.h.
770
771 * Makefile.in (base_obj): Add back doprnt.o.
772
773 * deps.mk (doprnt.o): Add back prerequisites.
774 (callint.o): Depend on character.h.
775
776 * eval.c (internal_lisp_condition_case): Include the handler
777 representation in the error message.
778 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
779 when breaking from the loop.
780
781 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
782
783 * callint.c (Fcall_interactively): When displaying error message
784 about invalid control letter, pass the character's codepoint, not
785 a pointer to its multibyte form. Improve display of the character
786 in octal and display also its hex code.
787
788 * character.c (char_string): Use %x to display the (unsigned)
789 codepoint of an invalid character, to avoid displaying a bogus
790 negative value.
791
792 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
793 `error', not SYMBOL_NAME itself.
794
795 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
796 character arguments to `error'.
797
798 * charset.c (check_iso_charset_parameter): Fix incorrect argument
799 to `error' in error message about FINAL_CHAR argument. Make sure
800 FINAL_CHAR is a character, and use %c when it is passed as
801 argument to `error'.
802
4ffd0d6b 8032011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
804
805 * s/ms-w32.h (localtime): Redirect to sys_localtime.
806
807 * w32.c: Include <time.h>.
808 (sys_localtime): New function.
809
4ffd0d6b 8102011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
811
812 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
813
4ffd0d6b 814 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 815
4ffd0d6b 8162011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 817
4ffd0d6b
GM
818 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
819 zombies (Bug#8467).
aac0c6e3 820
04c56954
EZ
8212011-04-19 Eli Zaretskii <eliz@gnu.org>
822
823 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
824 gl_state.e_property when gl_state.object is Qt.
825
826 * insdel.c (make_gap_larger): Remove limitation of buffer size
827 to <= INT_MAX.
828
16a43933
CY
8292011-04-18 Chong Yidong <cyd@stupidchicken.com>
830
831 * xdisp.c (lookup_glyphless_char_display)
832 (produce_glyphless_glyph): Handle cons cell entry in
833 glyphless-char-display.
834 (Vglyphless_char_display): Document it.
835
836 * term.c (produce_glyphless_glyph): Handle cons cell entry in
837 glyphless-char-display.
838
4581706e
CY
8392011-04-17 Chong Yidong <cyd@stupidchicken.com>
840
841 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
842
843 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
844
845 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
846 definition for no-X builds.
847
4887c6e2 8482011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 849
fd35b6f9
PE
850 Static checks with GCC 4.6.0 and non-default toolkits.
851
5c1ccb01
PE
852 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
853
006c5daa
PE
854 * process.c (keyboard_bit_set): Define only if SIGIO.
855 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
856 (send_process): Repair possible setjmp clobbering.
857
efc736d3
PE
858 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
859
4e2fe2e6
PE
860 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
861
f97334a2
PE
862 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
863
4e75f29d
PE
864 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
865 Define only if needed.
866
90efadd1
PE
867 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
868 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 869 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 870
3c647824
PE
871 * dispextern.h (struct redisplay_interface): Rename param
872 to avoid shadowing.
e264f262 873 * termhooks.h (struct terminal): Likewise.
761383f4 874 * xterm.c (xembed_send_message): Likewise.
3c647824 875
b58c5c4a
PE
876 * insdel.c (make_gap_smaller): Define only if
877 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
878
cad59032
PE
879 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
880 it.
881
c339dc2e
PE
882 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
883 so that we aren't warned about unused symbols.
884
91a3e27b
PE
885 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
886
399c71d3 887 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 888
8ffc96f5
PE
889 * xfns.c (x_real_positions): Mark locals as initialized.
890
eef9bc79
PE
891 * xmenu.c (xmenu_show): Don't use uninitialized vars.
892
098db9dd
PE
893 * xterm.c: Fix problems found by static analysis with other toolkits.
894 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
895 (x_dispatch_event): Declare static if USE_GTK, and
896 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 897 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 898 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
899 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
900 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 901
eb18f6cc
PE
902 * xmenu.c (menu_help_callback): Pointer type fixes.
903 Use const pointers when pointing at readonly data. Avoid pointer
904 signedness clashes.
905 (FALSE): Remove unused macro.
906 (update_frame_menubar): Remove unused decl.
907
1fe72bf8
PE
908 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
909
60d9e1db
PE
910 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
911 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
912 (single_menu_item): Rename local to avoid shadowing.
913
39261c26
PE
914 * keyboard.c (make_lispy_event): Remove unused local var.
915
018c5e19
PE
916 * frame.c, frame.h (x_get_resource_string): Bring this back, but
917 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
918
63d2b86e
PE
919 * bitmaps: Change bitmaps from unsigned char back to the X11
920 compatible char. Avoid the old compiler warnings about
921 out-of-range initializers by using, for example, '\xab' rather
922 than 0xab.
923
aefd87e1
PE
924 * xgselect.c (xgselect_initialize): Check vs interface
925 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
926
bf501fb9
PE
927 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
928
e9829fdf
PE
929 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
930 to read-only memory.
931
1086c095
PE
932 * fns.c (vector): Remove; this old hack is no longer needed.
933
2baccd04 934 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 935 Remove unused var.
dde42981 936 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 937
72391843 938 * xrdb.c (x_load_resources): Omit unused local.
3565b346 939
436c16df 940 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 941 (x_window): Rename locals to avoid shadowing.
dc5ddd85 942 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 943
92bb796d 944 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 945 (x_term_init): Remove local to avoid shadowing.
92bb796d 946
764430a3 947 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
948
949 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
950 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
951
d1dfb56c
EZ
9522011-04-16 Eli Zaretskii <eliz@gnu.org>
953
c4354cb4
EZ
954 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
955
d1dfb56c
EZ
956 Fix regex.c, syntax.c and friends for buffers > 2GB.
957 * syntax.h (struct gl_state_s): Declare character position members
958 EMACS_INT.
959
960 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
961
962 * textprop.c (verify_interval_modification, interval_of): Declare
963 arguments EMACS_INT.
964
965 * intervals.c (adjust_intervals_for_insertion): Declare arguments
966 EMACS_INT.
967
968 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
969
970 * indent.c (Fvertical_motion): Local variable it_start is now
971 EMACS_INT.
972
973 * regex.c (re_match, re_match_2, re_match_2_internal)
974 (bcmp_translate, regcomp, regexec, print_double_string)
975 (group_in_compile_stack, re_search, re_search_2, regex_compile)
976 (re_compile_pattern, re_exec): Declare arguments and local
977 variables `size_t' and `ssize_t' and return values `regoff_t', as
978 appropriate.
979 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
980 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
981 <compile_stack_type>: `size' and `avail' are now `size_t'.
982
983 * regex.h <regoff_t>: Use ssize_t, not int.
984 (re_search, re_search_2, re_match, re_match_2): Arguments that
985 specify buffer/string position and length are now ssize_t and
986 size_t. Return type is regoff_t.
987
613052cd
BK
9882011-04-16 Ben Key <bkey76@gmail.com>
989
990 * nsfont.m: Fixed bugs in ns_get_family and
991 ns_descriptor_to_entity that were caused by using free to
992 deallocate memory blocks that were allocated by xmalloc (via
993 xstrdup). This caused Emacs to crash when compiled with
994 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
995 --enable-checking=xmallocoverrun). xfree is now used to
996 deallocate these memory blocks.
997
4170f62f 9982011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 999
71b41406
PE
1000 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1001
9587a89d
PE
1002 emacs_write: Accept and return EMACS_INT for sizes.
1003 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1004 et seq.
1005 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1006 Accept and return EMACS_INT.
1007 (emacs_gnutls_write): Return the number of bytes written on
1008 partial writes.
1009 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1010 (emacs_read, emacs_write): Remove check for negative size, as the
1011 Emacs source code has been audited now.
9587a89d
PE
1012 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1013 (emacs_read, emacs_write): Use it.
273a5f82
PE
1014 * process.c (send_process): Adjust to the new signatures of
1015 emacs_write and emacs_gnutls_write. Do not attempt to store
1016 a byte offset into an 'int'; it might overflow.
9587a89d 1017 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1018
3e047f51
PE
1019 * sound.c: Don't assume sizes fit in 'int'.
1020 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1021 Return EMACS_INT, not int.
3e047f51 1022 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1023 Accept EMACS_INT, not int.
1024 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1025 record read return values.
1026
cc39a9db
BK
10272011-04-15 Ben Key <bkey76@gmail.com>
1028
c9d0ec6d
JB
1029 * keyboard.c (Qundefined): Don't declare static since it is used
1030 in nsfns.m.
1031 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1032 static since they are used in nsfont.m.
cc39a9db 1033
6c60eb9f
SM
10342011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1035
1036 * process.c (Qprocessp): Don't declare static.
1037 * lisp.h (Qprocessp): Declare again.
1038
7990b61a
JB
10392011-04-15 Juanma Barranquero <lekktu@gmail.com>
1040
1041 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1042
5d4cb038
PE
10432011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1044
8bd7b830 1045 Improve C-level modularity by making more things 'static'.
cd64ea1d 1046
e3b27b31
PE
1047 Don't publish debugger-only interfaces to other modules.
1048 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1049 (verify_bytepos, count_markers): Move decls to the only modules
1050 that need them.
1051 * region-cache.h (pp_cache): Likewise.
1052 * window.h (check_all_windows): Likewise.
1053 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1054
5d4cb038
PE
1055 * sysdep.c (croak): Now static, if
1056 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1057 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1058
1059 * alloc.c (refill_memory_reserve): Now static if
1060 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1061 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1062
e87b6180
PE
1063 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1064 Define only if USE_LUCID.
1065
ac64929e
PE
1066 * xrdb.c (x_customization_string, x_rm_string): Now static.
1067
6f37259d
PE
1068 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1069 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1070
1683e3ab
PE
1071 * xdisp.c (draw_row_with_mouse_face): Now static.
1072 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1073
de9c2632
PE
1074 * window.h (check_all_windows): Mark externally visible.
1075
2b96acb7
PE
1076 * window.c (window_deletion_count): Now static.
1077
1078 * undo.c: Make symbols static if they're not exported.
1079 (last_undo_buffer, last_boundary_position, pending_boundary):
1080 Now static.
1081
50436f33
PE
1082 * textprop.c (interval_insert_behind_hooks): Now static.
1083 (interval_insert_in_front_hooks): Likewise.
1084
64520e5c
PE
1085 * term.c: Make symbols static if they're not exported.
1086 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1087 (max_frame_lines, tty_set_terminal_modes):
1088 (tty_reset_terminal_modes, tty_turn_off_highlight):
1089 (get_tty_terminal): Now static.
1090 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1091 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1092 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1093 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1094 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1095
1fa53021
PE
1096 * sysdep.c: Make symbols static if they're not exported.
1097 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1098 Now static.
1099 (sigprocmask_set, full_mask): Remove; unused.
1100 (wait_debugging): Mark as visible.
1101 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1102 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1103
d4b43b22
PE
1104 * syntax.c (syntax_temp): Define only if !__GNUC__.
1105
b7c513d0
PE
1106 * sound.c (current_sound_device, current_sound): Now static.
1107
989b29ad
PE
1108 * search.c (searchbufs, searchbuf_head): Now static.
1109
13a55a78
PE
1110 * scroll.c (scroll_cost): Remove; unused.
1111 * dispextern.h (scroll_cost): Remove decl.
1112
de68a1fc
PE
1113 * region-cache.h (pp_cache): Mark as externally visible.
1114
40ccffa6
PE
1115 * process.c: Make symbols static if they're not exported.
1116 (process_tick, update_tick, create_process, chan_process):
1117 (Vprocess_alist, proc_buffered_char, datagram_access):
1118 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1119 (deactivate_process): Mark defn as static, as well as decl.
1120 * lisp.h (create_process): Remove decl.
1121 * process.h (chan_process, Vprocess_alist): Remove decls.
1122
ad64fc97
PE
1123 * print.c: Make symbols static if they're not exported.
1124 (print_depth, new_backquote_output, being_printed, print_buffer):
1125 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1126 (print_interval, print_number_index, initial_stderr_stream):
1127 Now static.
1128 * lisp.h (Fprinc): Remove decl.
1129 (debug_output_compilation_hack): Mark as externally visible.
1130
adddb265
PE
1131 * sysdep.c (croak): Move decl from here to syssignal.h.
1132 * syssignal.h (croak): Put it here, so the API can be checked when
1133 'croak' is called from dissociate_if_controlling_tty.
1134
1717ede2
PE
1135 * minibuf.c: Make symbols static if they're not exported.
1136 (minibuf_save_list, choose_minibuf_frame): Now static.
1137 * lisp.h (choose_minibuf_frame): Remove decl.
1138
fa5fb2bc
PE
1139 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1140
1e3890d1
PE
1141 * lread.c: Make symbols static if they're not exported.
1142 (read_objects, initial_obarray, oblookup_last_bucket_number):
1143 Now static.
1144 (make_symbol): Remove; unused.
1145 * lisp.h (initial_obarray, make_symbol): Remove decls.
1146
8a1414fa
PE
1147 * keyboard.c: Make symbols static if they're not exported.
1148 (single_kboard, recent_keys_index, total_keys, recent_keys):
1149 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1150 (this_single_command_key_start, echoing, last_auto_save):
1151 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1152 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1153 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1154 (Vlispy_mouse_stem, double_click_count):
1155 Now static.
1156 (force_auto_save_soon): Define only if SIGDANGER.
1157 (ignore_mouse_drag_p): Now static if
1158 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1159 (print_help): Remove; unused.
1160 (stop_character, last_timer_event): Mark as externally visible.
1161 * keyboard.h (ignore_mouse_drag_p): Declare only if
1162 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1163 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1164 * lisp.h (echoing): Remove decl.
1165 (force_auto_save_soon): Declare only if SIGDANGER.
1166 * xdisp.c (redisplay_window): Simplify code, to make it more
1167 obvious that ignore_mouse_drag_p is not accessed if !defined
1168 USE_GTK && !defined HAVE_NS.
1169
93ea6e8f
PE
1170 * intervals.c: Make symbols static if they're not exported.
1171 (merge_properties_sticky, merge_interval_right, delete_interval):
1172 Now static.
1173 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1174
77382fcc
PE
1175 * insdel.c: Make symbols static if they're not exported.
1176 However, leave prepare_to_modify_buffer alone. It's never
1177 called from outside this function, but that appears to be a bug.
1178 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1179 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1180 (adjust_after_replace_noundo): Remove; unused.
1181 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1182 (signal_before_change): Remove decls.
77382fcc 1183
9306c32e
PE
1184 * indent.c (val_compute_motion, val_vmotion): Now static.
1185
cd44d2eb
PE
1186 * image.c: Make symbols static if they're not exported.
1187 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1188 if USE_GTK.
1189 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1190 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1191
ad9a7a06
PE
1192 * fringe.c (standard_bitmaps): Now static.
1193 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1194
81626931
PE
1195 * frame.c: Make symbols static if they're not exported.
1196 (x_report_frame_params, make_terminal_frame): Now static.
1197 (get_frame_param): Now static, unless HAVE_NS.
1198 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1199 (x_get_resource_string): Remove; not used.
1200 * frame.h (make_terminal_frame, x_report_frame_params):
1201 (x_get_resource_string); Remove decls.
1202 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1203 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1204
239f9db9
PE
1205 * font.c, fontset.c: Make symbols static if they're not exported.
1206 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1207 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1208 * font.c (font_close_object): Now static.
1209 * font.h (font_close_object): Remove.
1210 * fontset.c (FONTSET_OBJLIST): Remove.
1211 (free_realized_fontset) #if-0 the body, which does nothing.
1212 (face_suitable_for_char_p): #if-0, as it's never called.
1213 * fontset.h (face_suitable_for_char_p): Remove decl.
1214 * xfaces.c (face_at_string_position): Use
1215 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1216 since 0 is always ASCII.
1217
dfcf3579
PE
1218 * fns.c (weak_hash_tables): Now static.
1219
5045092b
PE
1220 * fileio.c: Make symbols static if they're not exported.
1221 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1222 (Vwrite_region_annotation_buffers): Now static.
1223
57a96f5c
PE
1224 * eval.c: Make symbols static if they're not exported.
1225 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1226 * lisp.h (backtrace_list): Remove decl.
1227
35f08c38
PE
1228 * emacs.c: Make symbols static if they're not exported.
1229 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1230 (fatal_error_code, fatal_error_signal_hook, standard_args):
1231 Now static.
1232 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1233 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1234 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1235 * lisp.h (fatal_error_signal_hook): Remove decl.
1236 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1237
f44bd759
PE
1238 * editfns.c: Move a (normally-unused) function to its only use.
1239 * editfns.c, lisp.h (get_operating_system_release): Remove.
1240 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1241 worth the hassle of breaking this out.
1242
b532497d
PE
1243 * xterm.c: Make symbols static if they're not exported.
1244 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1245 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1246 (x_destroy_window, x_delete_display):
1247 Now static.
1248 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1249 (x_mouse_leave): Remove; unused.
1250 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1251 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1252 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1253 Remove decls.
1254 (x_mouse_leave): Declare only if WINDOWSNT.
1255 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1256 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1257 USE_X_TOOLKIT.
1258
1675728f
PE
1259 * ftxfont.c: Make symbols static if they're not exported.
1260 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1261 HAVE_FREETYPE.
1262 * font.h (ftxfont_driver): Likewise.
1263
e4cebfca
PE
1264 * xfns.c: Make symbols static if they're not exported.
1265 (x_last_font_name, x_display_info_for_name):
1266 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1267 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1268 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1269 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1270 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1271 (last_show_tip_args): Now static.
1272 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1273 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1274 (x_screen_planes): Remove; unused.
1275 * dispextern.h (x_screen_planes): Remove decl.
1276
5bf46f05
PE
1277 * dispnew.c: Make symbols static if they're not exported.
1278 * dispextern.h (redraw_garbaged_frames, scrolling):
1279 (increment_row_positions): Remove.
1280 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1281 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1282 Now static.
1283 (redraw_garbaged_frames): Remove; unused.
1284
435f4c28
PE
1285 * xfaces.c: Make symbols static if they're not exported.
1286 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1287 Remove decls.
1288 * xterm.h (defined_color): Remove decls.
1289 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1290 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1291 (menu_face_changed_default, defined_color, free_realized_face):
1292 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1293 (ascii_face_of_lisp_face): Remove; unused.
1294
8524aef3
PE
1295 * xdisp.c: Make symbols static if they're not exported.
1296 * dispextern.h (scratch_glyph_row, window_box_edges):
1297 (glyph_to_pixel_coords, set_cursor_from_row):
1298 (get_next_display_element, set_iterator_to_next):
1299 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1300 (show_mouse_face): Remove decls
1301 * frame.h (message_buf_print): Likewise.
1302 * lisp.h (pop_message, set_message, check_point_in_composition):
1303 Likewise.
1304 * xterm.h (set_vertical_scroll_bar): Likewise.
1305 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1306 (message_buf_print, scratch_glyph_row, displayed_buffer):
1307 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1308 (get_next_display_element, show_mouse_face, window_box_edges):
1309 (frame_to_window_pixel_xy, check_point_in_composition):
1310 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1311 (glyph_to_pixel_coords): Remove; unused.
1312
16390cd2
PE
1313 * dired.c (file_name_completion): Now static.
1314
1315 * dbusbind.c (xd_in_read_queued_messages): Now static.
1316
a25f4dfa
PE
1317 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1318 * data.c (circular_list_error): Remove.
1319
14a9c8df
PE
1320 * commands.h (last_point_position, last_point_position_buffer):
1321 (last_point_position_window): Remove decls.
1322 * keyboard.c: Make these variables static.
1323
74ab6df5
PE
1324 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1325 decls.
1326 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1327 (iso_code_class, detect_coding, code_convert_region): Now static.
1328 (encode_coding_gap): Remove; unused.
1329
38dfbee1
PE
1330 * chartab.c (chartab_chars, chartab_bits): Now static.
1331
a2cb4e63
PE
1332 * charset.h (charset_iso_8859_1): Remove decl.
1333 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1334 Now static.
1335
127198fd
PE
1336 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1337 * ccl.c (Vccl_program_table): Now static.
1338 (check_ccl_update): Remove; unused.
1339
d85b608f
PE
1340 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1341 * category.h: ... from here.
1342 * category.c (check_category_table, set_category_set): Now static.
1343
31cd66f3
PE
1344 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1345 * lisp.h: Remove these decls.
1346
c358e587
PE
1347 * buffer.c (buffer_count): Remove unused var.
1348
e78aecca
PE
1349 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1350 so that it's not optimized away.
1351 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1352 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1353 exported only to the debugger.
1354
e192d7d3
PE
1355 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1356 * atimer.h (run_all_atimers): Removed; not exported.
1357
92470028
PE
1358 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1359 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1360 was inaccessible from Lisp.
1361 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1362 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1363
244ed907
PE
1364 alloc.c: Import and export fewer symbols, and remove unused items.
1365 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1366 is defined.
1367 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1368 it's not optimized away by whole-program optimization.
1369 (message_enable_multibyte, free_misc): Remove.
1370 (catchlist, handlerlist, mark_backtrace):
1371 Declare only if BYTE_MARK_STACK.
1372 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1373 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1374 (message_enable_multibyte): Remove decl.
1375 (free_misc, interval_free_list, float_block, float_block_index):
1376 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1377 (cons_free_list, last_marked_index):
1378 Now static.
1379 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1380 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1381 (mark_backtrace): Define only if BYTE_MARK_STACK.
1382 * xdisp.c (message_enable_multibyte): Now static.
1383
61c2b50e 1384 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1385 This makes it easier for human readers (and static analyzers)
1386 to see whether these variables are used from other modules.
1387 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1388 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1389 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1390 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1391 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1392 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1393 * xmenu.c, xselect.c:
1394 Declare Q* vars static if they are not used in other modules.
1395 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1396 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1397 Remove decls of unexported vars.
1398 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1399
95c82688
PE
1400 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1401
16a97296
PE
1402 Make Emacs functions such as Fatom 'static' by default.
1403 This makes it easier for human readers (and static analyzers)
1404 to see whether these functions can be called from other modules.
1405 DEFUN now defines a static function. To make the function external
1406 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1407 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1408 (Finit_image_library):
16a97296
PE
1409 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1410 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1411 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1412 Remove decls, since these functions are now static.
1413 (Funintern, Fget_internal_run_time): New decls, since these functions
1414 were already external.
95c82688 1415
16a97296
PE
1416 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1417 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1418 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1419 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1420 * keyboard.c, keymap.c, lread.c:
1421 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1422 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1423 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1424 Mark functions with DEFUE instead of DEFUN,
1425 if they are used in other modules.
1426 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1427 decls for now-static functions.
1428 * buffer.h (Fdelete_overlay): Remove decl.
1429 * callproc.c (Fgetenv_internal): Mark as internal.
1430 * composite.c (Fremove_list_of_text_properties): Remove decl.
1431 (Fcomposition_get_gstring): New forward static decl.
1432 * composite.h (Fcomposite_get_gstring): Remove decl.
1433 * dired.c (Ffile_attributes): New forward static decl.
1434 * doc.c (Fdocumntation_property): New forward static decl.
1435 * eval.c (Ffetch_bytecode): New forward static decl.
1436 (Funintern): Remove extern decl; now in .h file where it belongs.
1437 * fileio.c (Fmake_symbolic_link): New forward static decl.
1438 * image.c (Finit_image_library): New forward static decl.
1439 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1440 * intervals.h (Fprevious_property_change):
1441 (Fremove_list_of_text_properties): Remove decls.
1442 * keyboard.c (Fthis_command_keys): Remove decl.
1443 (Fcommand_execute): New forward static decl.
1444 * keymap.c (Flookup_key): New forward static decl.
1445 (Fcopy_keymap): Now static.
1446 * keymap.h (Flookup_key): Remove decl.
1447 * process.c (Fget_process): New forward static decl.
1448 (Fprocess_datagram_address): Mark as internal.
1449 * syntax.c (Fsyntax_table_p): New forward static decl.
1450 (skip_chars): Remove duplicate decl.
1451 * textprop.c (Fprevious_property_change): New forward static decl.
1452 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1453 Now internal.
1454 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1455 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1456
785bbd42
PE
1457 * editfns.c (Fformat): Remove unreachable code.
1458
8b913b57
AS
14592011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1460
1461 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1462 change. (Bug#8496)
1463
a6744a35
EZ
14642011-04-13 Eli Zaretskii <eliz@gnu.org>
1465
1466 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1467 when at ZV. (Bug#8487)
1468
e7974947
AS
14692011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1470
baad03f0
AS
1471 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1472 (Bug#8437)
1473 * keyboard.c (parse_tool_bar_item): Likewise.
1474 * sound.c (sound_cleanup, alsa_close): Likewise.
1475 * termcap.c (tgetent): Likewise.
1476 * xfns.c (x_default_font_parameter): Likewise.
1477 * xsettings.c (read_and_apply_settings): Likewise.
1478
e7974947
AS
1479 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1480 (overrun_check_free): Protoize.
1481
28272684
PE
14822011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1485 since callers should never pass a negative size.
1486 Change the signature to match that of plain 'read' and 'write'; see
1487 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1488 * lisp.h: Update prototypes of emacs_write and emacs_read.
1489
11997c76
EZ
14902011-04-11 Eli Zaretskii <eliz@gnu.org>
1491
1492 * xdisp.c (redisplay_window): Don't try to determine the character
1493 position of the scroll margin if the window start point w->startp
e896f03c 1494 is outside the buffer's accessible region. (Bug#8468)
11997c76 1495
8a2cbd72
EZ
14962011-04-10 Eli Zaretskii <eliz@gnu.org>
1497
1498 Fix write-region and its subroutines for buffers > 2GB.
1499 * fileio.c (a_write, e_write): Modify declaration of arguments and
1500 local variables to support buffers larger than 2GB.
1501 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1502
1503 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1504 argument, local variables, and return value.
1505
1506 * lisp.h: Update prototypes of emacs_write and emacs_read.
1507
1508 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1509
4073e537 15102011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1511
1ebfdcb6
PE
1512 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1513
b2ded58d
PE
1514 Fix more problems found by GCC 4.6.0's static checks.
1515
7d66342c
PE
1516 * xdisp.c (vmessage): Use a better test for character truncation.
1517
bbf47d44
PE
1518 * charset.c (load_charset_map): <, not <=, for optimization,
1519 and to avoid potential problems with integer overflow.
9248994d 1520 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1521 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1522 * editfns.c (Fformat): Likewise.
1e69125e 1523 * syntax.c (skip_chars): Likewise.
3befa583 1524
e3019616
PE
1525 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1526 This also lets GCC 4.6.0 generate slightly better loop code.
1527
becfa255
PE
1528 * callint.c (Fcall_interactively): <, not <=, for optimization.
1529 (Fcall_interactively): Count the number of arguments produced,
1530 not the number of arguments given. This is simpler and lets GCC
1531 4.6.0 generate slightly better code.
1532
dae0cd48
PE
1533 * ftfont.c: Distingish more carefully between FcChar8 and char.
1534 The previous code passed unsigned char * to a functions like
1535 strlen and xstrcasecmp that expect char *, which does not
1536 conform to the C standard.
1537 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1538 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1539 char * when the C standard requires it.
1540
76032d70
PE
1541 * keyboard.c (read_char): Remove unused var.
1542
eb3f1cc8
PE
1543 * eval.c: Port to Windows vsnprintf (Bug#8435).
1544 Include <limits.h>.
1545 (SIZE_MAX): Define if the headers do not.
1546 (verror): Do not give up if vsnprintf returns a negative count.
1547 Instead, grow the buffer. This ports to Windows vsnprintf, which
1548 does not conform to C99. Problem reported by Eli Zaretskii.
1549 Also, simplify the allocation scheme, by avoiding the need for
1550 calling realloc, and removing the ALLOCATED variable.
1551
70476b54
PE
1552 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1553
12020a9e
PE
1554 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1555 But keep the doprint source code for now, as we might revamp it
1556 and use it again (Bug#8435).
ea6c7ae6
PE
1557 * lisp.h (doprnt): Remove.
1558 * Makefile.in (base_obj): Remove doprnt.o.
1559 * deps.mk (doprnt.o): Remove.
1560
5fdb398c
PE
1561 error: Print 32- and 64-bit integers portably (Bug#8435).
1562 Without this change, on typical 64-bit hosts error ("...%d...", N)
1563 was used to print both 32- and 64-bit integers N, which relied on
1564 undefined behavior.
1565 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1566 New macro.
1567 * lisp.h (error, verror): Mark as printf-like functions.
1568 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1569 Report overflow in size calculations when allocating printf buffer.
1570 Do not truncate output string at its first null byte.
1571 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1572 Truncate the output at a character boundary, since vsnprintf does not
1573 do that.
1574 * charset.c (check_iso_charset_parameter): Convert internal
1575 character to string before calling 'error', since %c now has the
1576 printf meaning.
1577 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1578 overflow when computing char to be passed to 'error'. Do not
1579 pass Lisp_Object to 'error'; pass the integer instead.
1580 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1581 formatted with plain %d.
1582
b189fa66
PE
1583 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1584
bff87ef0
PE
1585 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1586
7e2cac20
PE
1587 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1588
ce4d90b5
PE
1589 * xterm.c (x_catch_errors): Remove duplicate declaration.
1590
266c9547
PE
1591 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1592
79c49ad2
PE
1593 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1594
368f4090
JM
15952011-04-10 Jim Meyering <meyering@redhat.com>
1596
1597 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1598 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1599 return ssize_t not "int", and use size_t as the buffer length.
1600 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1601 * gnutls.h: Update declarations.
1602 * process.c (read_process_output): Use ssize_t, to match.
1603 (send_process): Likewise.
1604
a32d4040
CY
16052011-04-09 Chong Yidong <cyd@stupidchicken.com>
1606
1607 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1608
8546720e 16092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1610
8546720e
GM
1611 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1612 unsigned char, to match FcChar8 type definition.
aac0c6e3 1613
8546720e
GM
1614 * xterm.c (handle_one_xevent):
1615 * xmenu.c (create_and_show_popup_menu):
1616 * xselect.c (x_decline_selection_request)
1617 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1618
0a2f5c1a 16192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1620
1621 Fix some uses of `int' instead of EMACS_INT.
1622 * search.c (string_match_1, fast_string_match)
1623 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1624 (scan_buffer, find_next_newline_no_quit)
1625 (find_before_next_newline, search_command, Freplace_match)
1626 (Fmatch_data): Make some `int' variables be EMACS_INT.
1627
1628 * xdisp.c (display_count_lines): 3rd argument and return value now
1629 EMACS_INT. All callers changed.
1630 (pint2hrstr): Last argument is now EMACS_INT.
1631
1632 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1633 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1634 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1635 (decode_coding_utf_16, decode_coding_emacs_mule)
1636 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1637 (decode_coding_ccl, decode_coding_charset)
1638 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1639 (decode_coding_iso_2022, decode_coding_emacs_mule)
1640 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1641 <char_offset, last_offset>: Declare EMACS_INT.
1642 (encode_coding_utf_8, encode_coding_utf_16)
1643 (encode_coding_emacs_mule, encode_invocation_designation)
1644 (encode_designation_at_bol, encode_coding_iso_2022)
1645 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1646 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1647 Declare EMACS_INT.
1648 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1649 (encode_invocation_designation): Last argument P_NCHARS is now
1650 EMACS_INT.
1651 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1652 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1653
1654 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1655 All users changed.
1656
1657 * ccl.c (Fccl_execute_on_string): Declare some variables
1658 EMACS_INT.
1659
8546720e 16602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1661
1662 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1663
4e19a977
CS
16642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1665
1666 * process.c (Fformat_network_address): Doc fix.
1667
87302331
R
16682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1669
1670 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1671
cbb59342
CY
16722011-04-08 Chong Yidong <cyd@stupidchicken.com>
1673
1674 * keyboard.c (read_char): Call Lisp function help-form-show,
1675 instead of using internal_with_output_to_temp_buffer.
1676 (Qhelp_form_show): New var.
e0d38eeb 1677 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1678
1679 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1680
1681 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1682
e67a13ab
CY
16832011-04-06 Chong Yidong <cyd@stupidchicken.com>
1684
1685 * process.c (Flist_processes): Removed to Lisp.
1686 (list_processes_1): Deleted.
1687
973f782d
EZ
16882011-04-06 Eli Zaretskii <eliz@gnu.org>
1689
7c106b1e
EZ
1690 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1691
973f782d
EZ
1692 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1693
41cf7d1a 16942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1695
ca23cc88
PE
1696 Fix more problems found by GCC 4.6.0's static checks.
1697
f390e2d5
PE
1698 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1699
42eea0d0
PE
1700 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1701
b69769da 1702 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1703
f9541e84
PE
1704 * xdisp.c (vmessage): Mark as a printf-like function.
1705
13841b55
PE
1706 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1707
c136c10f
PE
1708 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1709
5e2d4a30
PE
1710 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1711 printf-like functions.
1712 (tiff_load): Add casts to remove these marks before passing them
1713 to system-supplied API.
1714
583f48b9
PE
1715 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1716
b25d760e
PE
1717 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1718 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1719 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1720 directly, rather than having caller test rule sign. This avoids
1721 some unnecessary tests.
1722 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1723 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1724 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1725
bc7b6697 1726 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1727 (xfont_open): Avoid unnecessary tests.
bc7b6697 1728
27ccc379
PE
1729 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1730
dcd5c89a
PE
1731 * composite.h, composite.c (composition_gstring_put_cache):
1732 Use EMACS_INT, not int, for length.
1733
b13a45c6
PE
1734 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1735 breaking out part of COMPOSITION_DECODE_RULE.
1736 (COMPOSITION_DECODE_RULE): Use it.
1737 * composite.c (get_composition_id): Remove unused local vars,
1738 by using the new macro.
1739
1e792e4d
PE
1740 * textprop.c (set_text_properties_1): Change while to do-while,
1741 since the condition is always true at first.
1742
dc6c6455 1743 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1744 (interval_deletion_adjustment): Return unsigned value.
1745 All uses changed.
dc6c6455 1746
aba7731a
PE
1747 * process.c (list_processes_1, create_pty, read_process_output):
1748 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1749 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1750 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1751 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1752 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1753
fdfc4bf3
PE
1754 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1755
fca8fe46 1756 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1757 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1758
06a0259a 1759 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1760 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1761 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1762
e7b9e80f
PE
1763 * print.c (print_error_message): Avoid int overflow.
1764
56201685
PE
1765 * font.c (font_list_entities): Redo for clarity,
1766 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1767
78834453 1768 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1769 (font_score): Avoid potential overflow in diff calculation.
78834453 1770
0bc0b309 1771 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1772 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1773
e610eaca
PE
1774 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1775
b895abce
PE
1776 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1777 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1778 can always succeed if overflow has undefined behavior.
1779
1f1d9321 1780 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1781 (wordify): Omit three unnecessary tests.
1f1d9321 1782
c59478bc
PE
1783 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1784 All callers changed. This avoids the need for an unused var.
1785
79b73827
PE
1786 * casefiddle.c (casify_region): Remove var that is set but not used.
1787
a4db5dfe
PE
1788 * dired.c (file_name_completion): Remove var that is set but not used.
1789
43aae36e
PE
1790 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1791
2a47c44d 1792 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1793 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1794
a37c69bf
PE
1795 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1796 Check for integer overflow on size calculations.
1797
328ab8e7
PE
1798 * buffer.c (Fprevious_overlay_change): Remove var that is set
1799 but not used.
1800
e5a2a5cb
PE
1801 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1802 Remove vars that are set but not used.
8d84a6eb 1803 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1804 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1805
a60e5f68
PE
1806 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1807
f661cb61 1808 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1809 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1810
f0397f5a
PE
1811 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1812 that are set but not used.
1813
8664db06 1814 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1815 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1816
6abdaa4a
PE
1817 * xselect.c (x_get_local_selection, x_handle_property_notify):
1818 Remove vars that are set but not used.
1819
0ce7538d 1820 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1821 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1822
9ae848fc
PE
1823 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1824 Remove var that is set but not used.
0b918413
PE
1825 (scroll_bar_windows_size): Now size_t, not int.
1826 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1827 Check for overflow.
9ae848fc 1828
a5a62657
PE
1829 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1830 (map_tty_color) [!defined MSDOS]: Likewise.
1831
5c5cdd39
PE
1832 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1833
66ebf983
PE
1834 * coding.c: Remove vars that are set but not used.
1835 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1836 All callers changed.
1837 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1838 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1839 (decode_coding_charset): Remove vars that are set but not used.
1840
1be4d761
PE
1841 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1842 that is set but not used.
1843
47553fa8
PE
1844 * print.c (print_object): Remove var that is set but not used.
1845
1f7196bf 1846 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1847 The gnulib version avoids calling malloc in the usual case,
1848 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1849 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1850 * filelock.c (current_lock_owner): Likewise.
1851 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1852 * sysdep.c: Include allocator.h, careadlinkat.h.
1853 (emacs_no_realloc_allocator): New static constant.
1854 (emacs_readlink): New function.
fdb61804
PE
1855 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1856 ../lib/careadlinkat.h.
d1fdcab7 1857
f84c17c7
SM
18582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1859
1860 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1861 first non-nil return value).
1862
ef3862ad
JD
18632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1864
1865 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1866 if not defined (Bug#8403).
1867
376a7006
JB
18682011-04-02 Juanma Barranquero <lekktu@gmail.com>
1869
1870 * xdisp.c (display_count_lines): Remove parameter `start',
1871 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1872 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1873 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1874 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1875 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1876 and thereabouts. All callers changed.
1877 (get_per_char_metric): Remove parameter `f', unused since
1878 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1879
6ca3801d
JM
18802011-04-02 Jim Meyering <meyering@redhat.com>
1881
1882 do not dereference NULL upon failed strdup
1883 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1884 (ns_get_family): Likewise.
1885
d8e2b5ba
JB
18862011-04-02 Juanma Barranquero <lekktu@gmail.com>
1887
1888 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1889
8c74fcbd
JD
18902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1891
1892 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1893 later (Bug#8403).
1894
7200d79c
SM
18952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1896
03408648 1897 Add lexical binding.
7200d79c 1898
03408648
SM
1899 * window.c (Ftemp_output_buffer_show): New fun.
1900 (Fsave_window_excursion):
1901 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1902
1903 * lread.c (lisp_file_lexically_bound_p): New function.
1904 (Fload): Bind Qlexical_binding.
1905 (readevalloop): Remove `evalfun' arg.
1906 Bind Qinternal_interpreter_environment.
1907 (Feval_buffer): Bind Qlexical_binding.
1908 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1909 Mark as dynamic.
1910 (syms_of_lread): Declare `lexical-binding'.
1911
1912 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1913
1914 * keyboard.c (eval_dyn): New fun.
1915 (menu_item_eval_property): Use it.
ca105506
SM
1916
1917 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1918
03408648
SM
1919 * fns.c (concat, mapcar1): Accept byte-code-functions.
1920
1921 * eval.c (Fsetq): Handle lexical vars.
1922 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1923 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1924 (FletX, Flet): Obey lexical binding.
1925 (Fcommandp): Handle closures.
1926 (Feval): New `lexical' arg.
1927 (eval_sub): New function extracted from Feval. Use it almost
1928 everywhere where Feval was used. Look up vars in lexical env.
1929 Handle closures.
1930 (Ffunctionp): Move from subr.el.
1931 (Ffuncall): Handle closures.
1932 (apply_lambda): Remove `eval_flags'.
1933 (funcall_lambda): Handle closures and new byte-code-functions.
1934 (Fspecial_variable_p): New function.
1935 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1936 but without exporting it to Lisp.
23aba0ea 1937
23aba0ea 1938 * doc.c (Fdocumentation, store_function_docstring):
03408648 1939 * data.c (Finteractive_form): Handle closures.
23aba0ea 1940
03408648
SM
1941 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1942 interactive spec.
ba83908c 1943
03408648
SM
1944 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1945 byte-codes.
1946 (exec_byte_code): New function extracted from Fbyte_code to handle new
1947 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1948
03408648 1949 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1950
03408648 1951 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1952
e2abce01
JB
19532011-03-31 Juanma Barranquero <lekktu@gmail.com>
1954
1955 * xdisp.c (redisplay_internal): Fix prototype.
1956
63696a73 19572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1958
63696a73
EZ
1959 * xdisp.c (SCROLL_LIMIT): New macro.
1960 (try_scrolling): Use it when setting scroll_limit. Limit
1961 scrolling to 100 screen lines.
1962 (redisplay_window): Even when falling back on "recentering",
1963 position point in the window according to scroll-conservatively,
1964 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1965
1966 (try_scrolling): When point is above the window, allow searching
1967 as far as scroll_max, or one screenful, to compute vertical
1968 distance from PT to the scroll margin position. This prevents
1969 try_scrolling from unnecessarily failing when
1970 scroll-conservatively is set to a value slightly larger than the
1971 window height. Clean up the case of PT below the margin at bottom
1972 of window: scroll_max can no longer be INT_MAX. When aggressive
1973 scrolling is in use, don't let point enter the opposite scroll
1974 margin as result of the scroll.
1975 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1976 threshold of 100 lines for never-recentering scrolling.
1977
e4cc2dfc
JB
19782011-03-31 Juanma Barranquero <lekktu@gmail.com>
1979
1980 * dispextern.h (move_it_by_lines):
1981 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1982 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1983 (message_log_check_duplicate): Remove parameters `prev_bol' and
1984 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1985 (redisplay_internal): Remove parameter `preserve_echo_area',
1986 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1987
1988 * indent.c (Fvertical_motion):
1989 * window.c (window_scroll_pixel_based, Frecenter):
1990 Don't pass `need_y_p' to `move_it_by_lines'.
1991
1c470562
SM
19922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1993
44f230aa
SM
1994 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1995 steal a few bits to be more compact.
1996 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1997 Remove unneeded casts.
1998
1c470562
SM
1999 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2000
888adce9
ZK
20012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2002
2003 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2004 binding" message (bug#7967).
2005
f838ed7b
PE
20062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2007
77861b95
PE
2008 Fix more problems found by GCC 4.6.0's static checks.
2009
de6dbc14
PE
2010 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2011 Remove unused local var.
2012
f838ed7b
PE
2013 * editfns.c (Fmessage_box): Remove unused local var.
2014
792c7b2b
PE
2015 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2016 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2017 Omit unused local vars.
c499e557 2018 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2019 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2020 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2021 Omit unused local var.
2022
ba0165e1
PE
2023 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2024 Don't assume string length fits in int.
32ad8845 2025 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2026 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2027
3c59b4c9
PE
2028 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2029 instead of alloca (Bug#8344).
2030
a3eed478 2031 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2032 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2033
eb4d412d
PE
2034 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2035
1658b401
PE
2036 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2037 concerns.
2038
2039 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2040
2041 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2042
9a2c6e05
PE
2043 * keyboard.c (syms_of_keyboard): Use the same style as later
2044 in this function when indexing through an array. This also
2045 works around GCC bug 48267.
2046
03d0a109
PE
2047 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2048
44f730c8
PE
2049 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2050
fe75f926
PE
2051 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2052 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2053
ffa8c828
PE
2054 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2055 This avoids undefined behavior on integer overflow, and is a bit
2056 more convenient anyway since it is compared to a size_t variable.
2057
c5101a77
PE
2058 Variadic C functions now count arguments with size_t, not int.
2059 This avoids an unnecessary limitation on 64-bit machines, which
2060 caused (substring ...) to crash on large vectors (Bug#8344).
2061 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2062 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2063 All variadic functions and their callers changed accordingly.
c5101a77
PE
2064 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2065 * data.c (arith_driver, float_arith_driver): Likewise.
2066 * editfns.c (general_insert_function): Likewise.
2067 * eval.c (struct backtrace.nargs, interactive_p)
2068 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2069 (funcall_lambda, mark_backtrace): Likewise.
2070 * fns.c (concat): Likewise.
2071 * frame.c (x_set_frame_parameters): Likewise.
2072 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2073 0 if not found, not -1. All callers changed.
2074
dd3f25f7
PE
2075 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2076 (stack_copy_size): Now size_t, not int.
2077 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2078
461c2ab9
JB
20792011-03-28 Juanma Barranquero <lekktu@gmail.com>
2080
2081 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2082 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2083 All callers changed.
2084
2085 * lisp.h (multibyte_char_to_unibyte):
2086 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2087 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2088 * character.h (CHAR_TO_BYTE8):
2089 * cmds.c (internal_self_insert):
2090 * editfns.c (general_insert_function):
2091 * keymap.c (push_key_description):
2092 * search.c (Freplace_match):
2093 * xdisp.c (message_dolog, set_message_1): All callers changed.
2094
f6d62986
SM
20952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2096
2097 * keyboard.c (safe_run_hook_funcall): New function.
2098 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2099 don't set the hook to nil, but remove the offending function instead.
2100 (Qcommand_hook_internal): Remove, unused.
2101 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2102 Vcommand_hook_internal.
2103
2104 * eval.c (enum run_hooks_condition): Remove.
2105 (funcall_nil, funcall_not): New functions.
2106 (run_hook_with_args): Call each function through a `funcall' argument.
2107 Remove `cond' argument, now redundant.
2108 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2109 (Frun_hook_with_args_until_failure): Adjust accordingly.
2110 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2111
1db5b1ad
JB
21122011-03-28 Juanma Barranquero <lekktu@gmail.com>
2113
2114 * dispextern.h (string_buffer_position): Remove declaration.
2115
2116 * print.c (strout): Remove parameter `multibyte', unused since
2117 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2118
2119 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2120 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2121 All callers changed.
2122
2123 * w32.c (_wsa_errlist): Use braces for struct initializers.
2124
2125 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2126 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2127 All callers changed.
2128 (string_buffer_position): Likewise. Also, make static (it's never
2129 used outside xdisp.c).
2130 (cursor_row_p): Remove parameter `w', unused since
2131 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2132 (decode_mode_spec): Remove parameter `precision', introduced during
2133 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2134 All callers changed.
2135
5ffb62aa
JD
21362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2137
2138 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2139
461c2ab9 21402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2141
2142 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2143 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2144 (ns_update_auto_hide_menu_bar): New functions.
2145 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2146 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2147 ns_constrain_all_frames.
2148 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2149 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2150
5c380ffb
JD
21512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2152
2153 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2154
9af30bdf
GM
21552011-03-27 Glenn Morris <rgm@gnu.org>
2156
2157 * syssignal.h: Replace RETSIGTYPE with void.
2158 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2159 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2160 Replace SIGTYPE with void everywhere.
2161 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2162 * s/template.h (SIGTYPE): Remove commented out definition.
2163
e2abce01
JB
21642011-03-26 Eli Zaretskii <eliz@gnu.org>
2165
2166 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2167 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2168
f868cd8a
JB
21692011-03-26 Juanma Barranquero <lekktu@gmail.com>
2170
59eb0929
JB
2171 * w32.c (read_unc_volume): Use parameter `henum', instead of
2172 global variable `wget_enum_handle'.
2173
2174 * keymap.c (describe_vector): Remove parameters `indices' and
2175 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2176 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2177
f868cd8a
JB
2178 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2179
2180 * keyboard.c (timer_check): Remove parameter `do_it_now',
2181 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2182 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2183 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2184
2185 * keyboard.c (read_char):
2186 * w32menu.c (w32_menu_display_help):
2187 * xmenu.c (show_help_event, menu_help_callback):
2188 Adjust calls to `show_help_echo'.
2189
2190 * gtkutil.c (xg_maybe_add_timer):
2191 * keyboard.c (readable_events):
2192 * process.c (wait_reading_process_output):
2193 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2194
2195 * insdel.c (adjust_markers_gap_motion):
2196 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2197 (gap_left, gap_right): Don't call it.
2198
2ecf6fdb
CY
21992011-03-25 Chong Yidong <cyd@stupidchicken.com>
2200
2201 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2202 incurred during fontification.
2203
6b1f9ba4
JB
22042011-03-25 Juanma Barranquero <lekktu@gmail.com>
2205
2206 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2207 (DEFVAR_PER_BUFFER): Don't pass it.
2208
2209 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2210 (scrolling_window): Don't pass it.
2211
0f4a96b5
JB
22122011-03-25 Juanma Barranquero <lekktu@gmail.com>
2213
2214 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2215
2216 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2217 and `suffix'.
2218 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2219 of variables specific to SELinux and computation of `encoded_absname'.
2220
2221 * image.c (XPutPixel): Remove unused variable `height'.
2222
2223 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2224
2225 * unexw32.c (get_section_info): Remove unused variable `section'.
2226
2227 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2228 (system_process_attributes): Remove unused variable `sess'.
2229 (sys_read): Remove unused variable `err'.
2230
2231 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2232 (w32_wnd_proc): Remove unused variable `isdead'.
2233 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2234 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2235 (x_create_tip_frame): Remove unused variable `tem'.
2236
2237 * w32inevt.c (w32_console_read_socket):
2238 Remove unused variable `no_events'.
2239
2240 * w32term.c (x_draw_composite_glyph_string_foreground):
2241 Remove unused variable `width'.
2242
1149507c
JB
22432011-03-24 Juanma Barranquero <lekktu@gmail.com>
2244
2245 * w32term.c (x_set_glyph_string_clipping):
2246 Don't pass uninitialized region to CombineRgn.
2247
9c88f339
JB
22482011-03-23 Juanma Barranquero <lekktu@gmail.com>
2249
2250 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2251 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2252 (Fx_close_connection): Remove unused variable `i'.
2253
2254 * w32font.c (w32font_draw): Return number of glyphs.
2255 (w32font_open_internal): Remove unused variable `i'.
2256 (w32font_driver): Add missing initializer.
2257
2258 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2259 (fill_in_menu): Remove unused variable `items_added'.
2260
2261 * w32term.c (last_mouse_press_frame): Remove static global variable.
2262 (w32_clip_to_row): Remove unused variable `f'.
2263 (x_delete_terminal): Remove unused variable `i'.
2264
2265 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2266 (NOTHING): Remove unused static global variable.
2267 (uniscribe_check_otf): Remove unused variable `table'.
2268 (uniscribe_font_driver): Add missing initializers.
2269
dee091a3
JD
22702011-03-23 Julien Danjou <julien@danjou.info>
2271
2272 * term.c (Fsuspend_tty, Fresume_tty):
2273 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2274 * window.c (temp_output_buffer_show):
2275 * insdel.c (signal_before_change):
2276 * frame.c (Fhandle_switch_frame):
2277 * fileio.c (Fdo_auto_save):
2278 * emacs.c (Fkill_emacs):
2279 * editfns.c (save_excursion_restore):
2280 * cmds.c (internal_self_insert):
2281 * callint.c (Fcall_interactively):
2282 * buffer.c (Fkill_all_local_variables):
2283 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2284 Use Frun_hooks.
0f4a96b5 2285 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2286 unconditionnaly since it does the check itself.
2287
2c520ab5 22882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2289
c9c49752
PE
2290 Fix more problems found by GCC 4.5.2's static checks.
2291
8abc3f12
PE
2292 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2293 the first time through the loop, since we know p0 < p1 then.
2294 This also avoids a gcc -Wstrict-overflow warning.
2295
a2d26660
PE
2296 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2297 leading to a memory leak, possible in functions like
2298 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2299 of objects (Bug#8318).
a2d26660 2300
916c72e9
PE
2301 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2302 that could (at least in theory) be that large.
2303
19ab8a18
PE
2304 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2305 This is less likely to overflow, and avoids undefined behavior if
2306 overflow does occur. All callers changed. Use strtoul to scan
2307 for the unsigned long integer.
b7cbbd6f
PE
2308 (pint2hrstr): Simplify and tune code slightly.
2309 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2310
f0641eff
PE
2311 * scroll.c (do_scrolling): Work around GCC bug 48228.
2312 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2313
7f650bb9
PE
2314 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2315 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2316 (validate_x_resource_name): Simplify count usage.
2317 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2318
37dd57d1
PE
2319 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2320 fail (Bug#8306).
81e56e61 2321
699979fc 2322 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2323
401bf9b4
PE
2324 * process.c (Fmake_network_process): Use socklen_t, not int,
2325 where POSIX says socklen_t is required in portable programs.
2326 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2327 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2328 (Fmake_network_process, server_accept_connection):
2329 (wait_reading_process_output, read_process_output):
2330 Likewise.
2331
b93aacde
PE
2332 * process.c: Rename or move locals to avoid shadowing.
2333 (list_processes_1, Fmake_network_process):
2334 (read_process_output_error_handler, exec_sentinel_error_handler):
2335 Rename or move locals.
4dc343ee 2336 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2337 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2338 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2339 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2340 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2341
af8a867c 2342 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2343 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2344 Include tparam.h instead, since it declares them.
af8a867c
PE
2345 * cm.h (PC): Remove extern decl; tparam.h now does this.
2346 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2347 * terminfo.c: Include tparam.h, to check interfaces.
2348 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2349 (tparam): Adjust signature to match interface in tparam.h;
2350 this removes some undefined behavior. Check that outstring and len
2351 are zero, which they always are with Emacs.
2352 * tparam.h (PC, BC, UP): New extern decls.
2353
0248044d 2354 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2355 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2356
8ff096c1 2357 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2358 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2359 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2360 (ftfont_list): Remove unused local.
49eaafba
PE
2361 (get_adstyle_property, ftfont_pattern_entity):
2362 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2363 Rename locals to avoid shadowing.
8ff096c1 2364
e2be39f6
PE
2365 * xfont.c (xfont_list_family): Mark var as initialized.
2366
c9735e30
PE
2367 * xml.c (make_dom): Now static.
2368
8f5201ae
PE
2369 * composite.c (composition_compute_stop_pos): Rename local to
2370 avoid shadowing.
b246f932
PE
2371 (composition_reseat_it): Remove unused locals.
2372 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2373 (composition_update_it): Mark var as initialized.
11b61122
PE
2374 (find_automatic_composition): Mark vars as initialized,
2375 with a FIXME (Bug#8290).
8f5201ae 2376
760fbc2c
PE
2377 character.h: Rename locals to avoid shadowing.
2378 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2379 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2380 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2381 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2382 to avoid shadowing.
2383
ff08eb85
PE
2384 * textprop.c (property_change_between_p): Remove; unused.
2385
fc7bf025
PE
2386 * intervals.c (interval_start_pos): Now static.
2387
235d7abc
PE
2388 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2389
44f230aa
SM
2390 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2391 Rename locals to avoid shadowing.
3e7d6594 2392
50060332
PE
2393 * sound.c (wav_play, au_play, Fplay_sound_internal):
2394 Fix pointer signedness.
d01f234b 2395 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2396 (wav_play): Initialize a variable to 0, to prevent undefined
2397 behavior (Bug#8278).
50060332 2398
c4fc4e30
PE
2399 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2400
918436ed
PE
2401 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2402
c939f91b
PE
2403 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2404 clobbering (Bug#8298).
b9c7f648
PE
2405 * sysdep.c (sys_subshell): Likewise.
2406 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2407
6bd8c144
PE
2408 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2409 This should get cleaned up, so that child_setup has the
2410 same signature on all platforms.
2411
7710357c 2412 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2413 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2414
c59da222
CY
24152011-03-22 Chong Yidong <cyd@stupidchicken.com>
2416
2417 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2418 not to be necessary, and produces flickering.
2419
66b87493
GM
24202011-03-20 Glenn Morris <rgm@gnu.org>
2421
2422 * config.in: Remove file.
2423
45b6f6d5
JB
24242011-03-20 Juanma Barranquero <lekktu@gmail.com>
2425
2426 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2427 are now in src/globals.h.
2428 (syms_of_minibuf): Remove spurious & from previous change.
2429
3ec03f7e
LL
24302011-03-20 Leo <sdl.web@gmail.com>
2431
2432 * minibuf.c (completing-read-function): New variable.
2433 (completing-read-default): Rename from completing-read.
2434 (completing-read): Call completing-read-function.
2435
b14e3e21
CY
24362011-03-19 Juanma Barranquero <lekktu@gmail.com>
2437
2438 * xfaces.c (Fx_load_color_file):
2439 Read color file from absolute filename (bug#8250).
2440
f2b726e6
JB
24412011-03-19 Juanma Barranquero <lekktu@gmail.com>
2442
2443 * makefile.w32-in: Update dependencies.
2444
09f6ff02
EZ
24452011-03-17 Eli Zaretskii <eliz@gnu.org>
2446
2447 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2448
29a6015a
PE
24492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2450
a3a6c54e
PE
2451 Fix more problems found by GCC 4.5.2's static checks.
2452
b766f867
PE
2453 * process.c (make_serial_process_unwind, send_process_trap):
2454 (sigchld_handler): Now static.
2455
be02381c
PE
2456 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2457 That way, the code declares only the vars that it needs.
2458 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2459 * s/cygwin.h (PTY_ITERATION): Likewise.
2460 * s/darwin.h (PTY_ITERATION): Likewise.
2461 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2462
57048744
PE
2463 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2464 * process.c (allocate_pty): Don't declare stb unless it's needed.
2465
7914961c 2466 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2467 (CONSTANTLIM): Remove; unused.
2468 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2469 Define only if needed.
7914961c 2470
b3967b18
PE
2471 * unexelf.c (unexec): Name an expression,
2472 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2473 Use a different way to cause a compilation error if anyone uses
2474 n rather than nn, a way that does not involve shadowing.
73366a00 2475 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2476
29a6015a
PE
2477 * deps.mk (unexalpha.o): Remove; unused.
2478
43cfc33e 2479 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2480 * unexec.h: New file.
ce701a33
PE
2481 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2482 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2483 Depend on unexec.h.
2484 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2485 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2486 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2487 Change as necessary to match prototype in unexec.h.
ce701a33 2488
01f44d5a
PE
2489 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2490 shadowing.
4f63c6bb 2491 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2492
a6670b0b
PE
2493 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2494 Rename locals to avoid shadowing.
2495
cef2010d 2496 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2497 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2498
d4d7173a
PE
2499 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2500
f08b802a
PE
2501 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2502 warning when compiling print.c.
2503
3ddb0639
PE
2504 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2505 instead of using an uninitialized var.
5ad03b97 2506 (font_sort_entities): Mark var as initialized.
3ddb0639 2507
170a2692
PE
2508 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2509
e663c700
PE
2510 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2511 pointers to constants.
89bc529a 2512 (font_parse_fcname): Remove unused vars.
7b81e2d0 2513 (font_delete_unmatched): Now static.
ea838e10 2514 (font_get_spec): Remove; unused.
13a547c6
PE
2515 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2516 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2517 Rename or move locals to avoid shadowing.
e663c700 2518
2a80c887 2519 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2520 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2521
1384fa33 2522 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2523 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2524
8b2c52e9
PE
2525 * alloc.c (mark_backtrace): Move decl from here ...
2526 * lisp.h: ... to here, so that it can be checked.
2527
475545b5 2528 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2529 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2530 (lisp_indirect_variable): Name an expression,
2531 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2532 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2533
b1349114 2534 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2535 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2536 Use const pointer when appropriate.
b1349114 2537
a2928364
PE
2538 * lisp.h (get_system_name, get_operating_system_release):
2539 Move decls here, to check interfaces.
2540 * process.c (get_operating_system_release): Move decl to lisp.h.
2541 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2542 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2543 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2544 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2545 (Fformat_time_string, Fencode_time, Finsert_char):
2546 (Ftranslate_region_internal, Fformat):
2547 Rename or remove local vars to avoid shadowing.
9710023e 2548 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2549
a415e694
PE
2550 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2551 avoid shadowing.
2552
8ef4622d
PE
2553 * lisp.h (eassert): Check that the argument compiles, even if
2554 ENABLE_CHECKING is not defined.
2555
946f9a5b
PE
2556 * data.c (Findirect_variable): Name an expression, to avoid
2557 gcc -Wbad-function-cast warning.
112396d6 2558 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2559 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2560 (Fmake_variable_buffer_local, Fmake_local_variable):
2561 Mark variables as initialized.
52746918 2562 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2563
e5aab7e7 2564 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2565 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2566 Rename locals to avoid shadowing.
dff45157
PE
2567 (mark_stack): Move local variables into the #ifdef region where
2568 they're used.
7bc26fdb
PE
2569 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2570 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2571 needed otherwise.
2572 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2573 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2574 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2575
e5aab7e7
PE
2576 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2577 avoids undefined behavior in theory.
2578
4da60324
PE
2579 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2580
88043301
PE
2581 Use functions, not macros, for up- and down-casing (Bug#8254).
2582 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2583 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2584 to use the following functions instead of these macros.
2585 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2586 EMACS_INT, since callers assume the returned value fits in int.
2587 (upcase1): Likewise, for UPCASE_TABLE.
2588 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2589 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2590 the race-condition problem in the old DOWNCASE.
88043301 2591
19ed5445
PE
2592 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2593 Rename locals to avoid shadowing.
2594 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2595 (regex_compile, re_search_2, re_match_2_internal):
2596 Remove unused local vars.
952db0d7
PE
2597 (FREE_VAR): Rewrite so as not to use empty "else",
2598 which gcc can warn about.
da053e48 2599 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2600 (RETALLOC_IF): Define only if needed.
2601 (WORDCHAR_P): Likewise. This one is never needed, but is used
2602 only in a comment talking about a compiler bug, so put inside
2603 the #if 0 of that comment.
2604 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2605 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2606 Remove; unused.
19ed5445 2607
1f3561e4 2608 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2609 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2610 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2611
ded6f8f7
PE
2612 * search.c (simple_search): Remove unused var.
2613
dbd37a95
PE
2614 * dired.c (compile_pattern): Move decl from here ...
2615 * lisp.h: ... to here, so that it can be checked.
2616 (struct re_registers): New forward decl.
2617
7e47afad
PE
2618 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2619
85f24f61
PE
2620 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2621 All uses changed.
2622 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2623 Rename locals to avoid shadowing.
5671df8f 2624 (Fvertical_motion): Mark locals as initialized.
85f24f61 2625
181aa2be 2626 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2627 (casify_region): Mark local as initialized.
181aa2be 2628
930d429c
PE
2629 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2630
7082eac6
PE
2631 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2632 New macros, so that the caller can use some names other than
2633 gcpro1, gcpro2, etc.
2634 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2635 of the new macros.
2636 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2637 argument, for consistency with GCPRO2_VAR, etc: it is now the
2638 prefix of the variable, not the variable itself. All uses
2639 changed.
38b2c076
PE
2640 * dired.c (directory_files_internal, file_name_completion):
2641 Rename locals to avoid shadowing.
2642
15206ed9
PE
2643 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2644 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2645 dired.c's scmp function, had undefined behavior.
2646 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2647 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2648 * buffer.h: ... to here, because these macros use current_buffer,
2649 and the new implementation with inline functions needs to have
2650 current_buffer in scope now, rather than later when the macros
2651 are used.
2652 (downcase, upcase1): New static inline functions.
2653 (DOWNCASE, UPCASE1): Reimplement using these functions.
2654 This avoids undefined behavior in expressions like
2655 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2656 from race conditions in accessing the global variables
2657 case_temp1 and case_temp2.
2658 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2659 * lisp.h (case_temp1, case_temp2): Remove their decls.
2660 * character.h (ASCII_CHAR_P): Move from here ...
2661 * lisp.h: ... to here, so that the inline functions mentioned
2662 above can use them.
2663
4a6bea26
PE
2664 * dired.c (directory_files_internal_unwind): Now static.
2665
f14b7e14
PE
2666 * fileio.c (file_name_as_directory, directory_file_name):
2667 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2668 Now static.
2893f146
PE
2669 (file_name_as_directory): Use const pointers when appropriate.
2670 (Fexpand_file_name): Likewise. In particular, newdir might
2671 point at constant storage, so make it a const pointer.
fd4ead52 2672 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2673 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2674 signedness issues.
f839df0c
PE
2675 (Fset_file_times, Finsert_file_contents, auto_save_error):
2676 Rename locals to avoid shadowing.
f14b7e14 2677
5716756e 2678 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2679 (Ftry_completion, Fall_completions): Rename or remove locals
2680 to avoid shadowing.
5716756e 2681
b4c3046a
PE
2682 * marker.c (bytepos_to_charpos): Remove; unused.
2683
b45db522
PE
2684 * lisp.h (verify_bytepos, count_markers): New decls,
2685 so that gcc does not warn that these functions aren't declared.
2686
85876d07
PE
2687 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2688 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2689 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2690 (copy_text): Remove unused local var.
85876d07 2691
03d78a21 2692 * filelock.c (within_one_second): Now static.
b3dd38ab 2693 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2694
5df8f01b
PE
2695 * buffer.c (fix_overlays_before): Mark locals as initialized.
2696 (fix_start_end_in_overlays): Likewise. This function should be
2697 simplified by using pointers-to-pointers, but that's a different
2698 matter.
b1d876f1 2699 (switch_to_buffer_1): Now static.
8f54f30a
PE
2700 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2701 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2702
a70072c9 2703 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2704 Fix pointer signedness issue.
edced198
PE
2705 (sys_subshell): Mark local as volatile if checking for lint,
2706 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2707 (MAXPATHLEN): Define only if needed.
a70072c9 2708
a0977c44
PE
2709 * process.c (serial_open, serial_configure): Move decls from here ...
2710 * systty.h: ... to here, so that they can be checked.
2711
a884fdcc
PE
2712 * fns.c (get_random, seed_random): Move extern decls from here ...
2713 * lisp.h: ... to here, so that they can be checked.
2714
604efe86 2715 * sysdep.c (reset_io): Now static.
b8950c94 2716 (wait_for_termination_signal): Remove; unused.
604efe86 2717
38fc62d9
PE
2718 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2719 (copy_keymap_item, append_key, push_text_char_description):
2720 Now static.
1004a21a 2721 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2722 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2723 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2724 (describe_map_tree):
2725 Rename locals to avoid shadowing.
38fc62d9 2726
2f2650da
PE
2727 * keyboard.c: Declare functions static if they are not used elsewhere.
2728 (echo_char, echo_dash, cmd_error, top_level_2):
2729 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2730 (read_char, kbd_buffer_get_event, make_lispy_position):
2731 (make_lispy_event, make_lispy_movement, apply_modifiers):
2732 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2733 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2734 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2735 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2736 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2737
a053e86c 2738 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2739 (mark_kboards): Move decl here ...
2740 * alloc.c (mark_kboards): ... from here.
a053e86c 2741
4752793e
PE
2742 * lisp.h (force_auto_save_soon): New decl.
2743
74f10ca7 2744 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2745 (DEFINE_DUMMY_FUNCTION): New macro.
2746 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2747 Use it.
c03cd23f
PE
2748 (main): Add casts to avoid warnings
2749 if GCC considers string literals to be constants.
74f10ca7 2750
022e70d4
PE
2751 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2752
59d6fe83
PE
2753 * dbusbind.c: Pointer signedness fixes.
2754 (xd_signature, xd_append_arg, xd_initialize):
2755 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2756 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2757 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2758 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2759
78320123
PE
2760 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2761 if GCC considers string literals to be constants.
49cebcca 2762 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2763
35ac2a97
SM
27642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2765
fb103ca9
SM
2766 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2767 (print_preprocess, print_object): New macro to fix last change.
2768
35ac2a97
SM
2769 * print.c (print_preprocess): Don't forget font objects.
2770
62973b41
JB
27712011-03-16 Juanma Barranquero <lekktu@gmail.com>
2772
2773 * emacs.c (USAGE3): Doc fixes.
2774
0e48bb22
AS
27752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2776
2777 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2778 structure.
2779
7684e57b
JB
27802011-03-14 Juanma Barranquero <lekktu@gmail.com>
2781
2782 * lisp.h (VWindow_system, Qfile_name_history):
2783 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2784 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2785 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2786
2787 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2788 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2789
2790 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2791 * w32console.c (detect_input_pending, read_input_pending)
2792 (encode_terminal_code):
2793 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2794 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2795 (w32_system_caret_y, Qfile_name_history):
2796 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2797 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2798 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2799 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2800 * w32proc.c (Qlocal, report_file_error):
2801 * w32term.c (Vwindow_system, updating_frame):
2802 * w32uniscribe.c (initialized, uniscribe_font_driver):
2803 Remove unneeded extern declarations.
2804
2aa46d6c
CY
28052011-03-14 Chong Yidong <cyd@stupidchicken.com>
2806
c96bbc66 2807 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2808
cffc6f3b
CY
28092011-03-13 Chong Yidong <cyd@stupidchicken.com>
2810
2811 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2812 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2813 These macros can no longer be used for assignment.
2814
44f230aa
SM
2815 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2816 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2817 (record_buffer_markers, fetch_buffer_markers): New functions for
2818 recording and fetching special buffer markers.
2819 (set_buffer_internal_1, set_buffer_temp): Use them.
2820
2821 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2822
2823 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2824
2825 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2826 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2827
2828 * xdisp.c (hscroll_window_tree):
2829 (reconsider_clip_changes): Use PT instead of BUF_PT.
2830
d251f04b
EZ
28312011-03-13 Eli Zaretskii <eliz@gnu.org>
2832
2833 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2834 $(EMACS_ROOT)/lib/intprops.h.
2835
f0c77cd1
PE
28362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2837
3eca4629
PE
2838 Fix more problems found by GCC 4.5.2's static checks.
2839
7c86ee98
PE
2840 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2841 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2842 (xg_free_frame_widgets): Make it clear that a local variable is
2843 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2844 (gdk_window_get_screen): Make it clear that this macro is needed
2845 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2846 (int_gtk_range_get_value): New function, which avoids a diagnostic
2847 from gcc -Wbad-function-cast.
2848 (xg_set_toolkit_scroll_bar_thumb): Use it.
2849 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2850 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2851 (get_utf8_string, xg_get_file_with_chooser):
2852 Rename locals to avoid shadowing.
2853 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2854
41729b81
PE
2855 * xgselect.c (xg_select): Remove unused var.
2856
f0c77cd1
PE
2857 * image.c (four_corners_best): Mark locals as initialized.
2858 (gif_load): Initialize transparent_p to zero (Bug#8238).
2859 Mark another local as initialized.
ec6cf4c6 2860 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2861
ce0ad53d 2862 * image.c (clear_image_cache): Now static.
d5d5a617 2863 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2864 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2865 (x_edge_detection): Remove unnecessary cast that
2866 gcc -Wbad-function-cast diagnoses.
2037898d 2867 (gif_load): Fix pointer signedness.
6ae141d6
PE
2868 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2869 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2870
33383987 28712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2872
d32df629
PE
2873 Improve quality of tests for time stamp overflow.
2874 For example, without this patch (encode-time 0 0 0 1 1
2875 1152921504606846976) returns the obviously-bogus value (-948597
2876 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2877 reports time overflow. See
2878 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2879 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2880 * editfns.c: Include limits.h and intprops.h.
2881 (TIME_T_MIN, TIME_T_MAX): New macros.
2882 (time_overflow): Move earlier, to before first use.
2883 (hi_time, lo_time): New functions, for an accurate test for
2884 out-of-range times.
2885 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2886 (Fget_internal_run_time): Don't assume time_t fits in int.
2887 (make_time): Use list2 instead of Fcons twice.
2888 (Fdecode_time): More accurate test for out-of-range times.
2889 (check_tm_member): New function.
2890 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2891 (lisp_time_argument): Don't rely on undefined left-shift and
2892 right-shift behavior when checking for time stamp overflow.
8be6f318 2893
fe31d94c
PE
2894 * editfns.c (time_overflow): New function, refactoring common code.
2895 (Fformat_time_string, Fdecode_time, Fencode_time):
2896 (Fcurrent_time_string): Use it.
2897
8be6f318
PE
2898 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2899 * dired.c (make_time): Move to ...
2900 * editfns.c (make_time): ... here.
2901 * systime.h: Note the move.
2902
09d9db2c 29032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2904
126bc0dc
YM
2905 * fringe.c (update_window_fringes): Remove unused variables.
2906
c47cbdfd
YM
2907 * unexmacosx.c (copy_data_segment): Also copy __got section.
2908 (Bug#8223)
2909
7ac80be9
EZ
29102011-03-12 Eli Zaretskii <eliz@gnu.org>
2911
c96bbc66 2912 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2913 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2914 Constify `char *' arguments and their references according to
2915 prototypes in tparam.h.
2916
ecb0f94d 2917 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2918
7ac80be9
EZ
2919 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2920 Adapt all references accordingly.
2921
2922 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2923
ef1fd07e
TT
29242011-03-11 Tom Tromey <tromey@redhat.com>
2925
2926 * buffer.c (syms_of_buffer): Remove obsolete comment.
2927
7ef4b50c
EZ
29282011-03-11 Eli Zaretskii <eliz@gnu.org>
2929
2930 * termhooks.h (encode_terminal_code): Declare prototype.
2931
2932 * msdos.c (encode_terminal_code): Don't declare prototype.
2933
2934 * term.c (encode_terminal_code): Now external again, used by
2935 w32console.c and msdos.c.
2936
44f230aa
SM
2937 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2938 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2939
4b1ec863 29402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2941
1714f52b 2942 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2943
4b1ec863
PE
2944 * fringe.c (update_window_fringes): Mark locals as initialized
2945 (Bug#8227).
2946 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2947
524c7aa6
PE
2948 * alloc.c (mark_fringe_data): Move decl from here ...
2949 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2950 to check its interface.
2951 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2952
a5c0af81 2953 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2954 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2955 (fontset_font): Mark local as initialized.
a9a06e0b 2956 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2957
b4716021
PE
2958 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2959
811e9bac 2960 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2961 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2962 (x_own_selection, Fx_disown_selection_internal): Rename locals
2963 to avoid shadowing.
2964 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2965
7e3ab302
PE
2966 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2967 so that the caller can use some name other than gcpro1.
2968 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2969 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2970 (Fx_backspace_delete_keys_p):
2971 Use them to avoid shadowing, and rename vars to avoid shadowing.
2972 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2973 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2974 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2975 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2976 Remove unused locals.
7e3ab302
PE
2977 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2978 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2979 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2980 macros.
f78faa98 2981
e2b13473
PE
2982 * xterm.h (x_mouse_leave): New decl.
2983
77f23912
PE
2984 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2985 Remove unused functions.
cdf4ba58
PE
2986 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2987 (x_calc_absolute_position): Now static.
7411c686 2988 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2989 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2990 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2991 unless they are used.
38d0b34a
PE
2992 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2993 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2994 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2995 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2996 (x_error_catcher, x_connection_closed, x_error_handler):
2997 (x_error_quitter, xembed_send_message, x_iconify_frame):
2998 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2999 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3000 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3001
44f230aa
SM
3002 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3003 Rename or move locals to avoid shadowing.
6b463e58 3004 (tty_defined_color, merge_face_heights): Now static.
5967d051 3005 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3006 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3007 does not deduce is never used uninitialized.
73719eba
PE
3008 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3009 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3010
426994c3 3011 * terminal.c (store_terminal_param): Now static.
5489860b 3012
032f1620 3013 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3014 (set_frame_menubar): Remove unused local.
d4323972 3015 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3016 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3017 since they might point to immutable storage.
281585b0
PE
3018 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3019 since it's unused otherwise.
032f1620 3020
367c19e5 3021 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3022 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3023 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3024 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3025 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3026 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3027 does not deduce are never used uninitialized.
70739cbe 3028
07b48fa9
PE
3029 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3030
8868a238 3031 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3032 * window.c (window_loop, size_window):
3033 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3034
7e5cf297 3035 * window.c (display_buffer): Now static.
d6550a9f
PE
3036 (size_window): Mark variables that gcc -Wuninitialized
3037 does not deduce are never used uninitialized.
a586633d
PE
3038 * window.h (check_all_windows): New decl, to forestall
3039 gcc -Wmissing-prototypes diagnostic.
5b555da1 3040 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3041
f6095868
PE
3042 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3043 shadowing.
3044 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3045 Include <limits.h>.
3046 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3047 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3048 (load_charset_map): Mark variables that gcc -Wuninitialized
3049 does not deduce are never used uninitialized.
53df7c11 3050 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3051
f38b440c
PE
3052 * coding.c (coding_set_source, coding_set_destination):
3053 Use "else { /* comment */ }" rather than "else /* comment */;"
3054 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3055 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3056 a block, when the outer 'i' will do.
3057 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3058 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3059 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3060 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3061 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3062 Rename locals to avoid shadowing.
3063 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3064 * coding.c (emacs_mule_char, encode_invocation_designation):
3065 Now static, since they're not used elsewhere.
413bb2db 3066 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3067 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3068 (decode_coding_emacs_mule): Mark variables that gcc
3069 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3070 (detect_coding_iso_2022): Initialize a local variable that might
3071 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3072 this initialization is needed. (Bug#8211)
5f58e762
PE
3073 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3074 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3075 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3076 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3077 Remove unused macros.
f38b440c 3078
232b38b9 3079 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3080 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3081 * character.c (string_count_byte8): Likewise.
232b38b9 3082
fb90da1b
PE
3083 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3084 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3085
fb93dbc2
PE
3086 * chartab.c (copy_sub_char_table): Now static, since it's not used
3087 elsewhere.
5c156ace
PE
3088 (sub_char_table_ref_and_range, char_table_ref_and_range):
3089 Rename locals to avoid shadowing.
bbcd0949 3090 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3091
7d3b3862 3092 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3093 (BIDI_BOB): Remove unused macro.
7d3b3862 3094
6be7d3da
PE
3095 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3096 deduce are never used uninitialized.
c2ed9c8b 3097 * term.c (encode_terminal_code): Likewise.
6be7d3da 3098
75f8807f 3099 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3100
50938595
PE
3101 * tparam.h: New file.
3102 * term.c, tparam.h: Include it.
3103 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3104 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3105 Move these decls to tparam.h, and make them agree with what
3106 is actually in tparam.c. The previous trick of using incompatible
3107 decls in different modules does not conform to the C standard.
3108 All callers of tparam changed to use tparam's actual API.
3109 * tparam.c (tparam1, tparam, tgoto):
3110 Use const pointers where appropriate.
3111
fbceeba2
PE
3112 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3113 * cm.h (struct cm): Likewise.
3114 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3115 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3116 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3117 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3118 (turn_on_face, init_tty): Likewise.
3119 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3120
7f3f1250
PE
3121 * term.c (term_mouse_position): Rename local to avoid shadowing.
3122
e6ca6543
PE
3123 * alloc.c (mark_ttys): Move decl from here ...
3124 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3125
c40f8d15
AS
31262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3127
3128 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3129
cfe0661d
JB
31302011-03-09 Juanma Barranquero <lekktu@gmail.com>
3131
3132 * search.c (compile_pattern_1): Remove argument regp, unused since
3133 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3134 (compile_pattern): Don't pass it.
3135
0afb4571
J
31362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3137
3138 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3139 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3140 for ! HAVE_GTK3.
3141 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3142
3143 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3144
3145 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3146 gdk_window_get_screen, gdk_window_get_geometry,
3147 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3148 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3149 (xg_get_pixbuf_from_pixmap): New function.
3150 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3151 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3152 Call xg_get_pixbuf_from_pixmap instead of
3153 gdk_pixbuf_get_from_drawable.
3154 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3155 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3156 (xg_check_special_colors): Use GtkStyleContext and its functions
3157 for HAVE_GTK3.
3158 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3159 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3160 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3161 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3162 Call gtk_widget_get_preferred_size.
0afb4571
J
3163 (xg_frame_resized): gdk_window_get_geometry only takes 5
3164 parameters.
44f230aa
SM
3165 (xg_win_to_widget, xg_event_is_for_menubar):
3166 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3167 (xg_set_widget_bg): New function.
3168 (delete_cb): New function.
895009e1 3169 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3170 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3171 (xg_set_background_color): Call xg_set_widget_bg.
3172 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3173 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3174 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3175 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3176 if ! HAVE_GTK3.
3177 (update_frame_tool_bar): Call gtk_widget_hide.
3178 (xg_initialize): Use GDK_KEY_g.
3179
3180 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3181 if ! HAVE_GTK3
3182 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3183
3184 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3185 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3186 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3187
1c2cc4ef
JB
31882011-03-08 Juanma Barranquero <lekktu@gmail.com>
3189
3190 * w32xfns.c (select_palette): Check success of RealizePalette against
3191 GDI_ERROR, not zero.
3192
33383987 3193See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3194
3195;; Local Variables:
3196;; coding: utf-8
aac0c6e3
MR
3197;; End:
3198
33383987 3199 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3200
3201 This file is part of GNU Emacs.
3202
3203 GNU Emacs is free software: you can redistribute it and/or modify
3204 it under the terms of the GNU General Public License as published by
3205 the Free Software Foundation, either version 3 of the License, or
3206 (at your option) any later version.
3207
3208 GNU Emacs is distributed in the hope that it will be useful,
3209 but WITHOUT ANY WARRANTY; without even the implied warranty of
3210 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3211 GNU General Public License for more details.
3212
3213 You should have received a copy of the GNU General Public License
3214 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.