Tested with buffer reordering, fixed one crash.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d9334cb7
EZ
12011-06-09 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4 itb.string.s to NULL (avoids a crash in bidi_paragraph_init).
5
87e67904
EZ
62011-06-08 Eli Zaretskii <eliz@gnu.org>
7
8 * bidi.c (bidi_paragraph_info): Delete unused struct.
9 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10 (bidi_cache_start): New variable.
11 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12 to zero.
13 (bidi_cache_fetch_state, bidi_cache_search)
14 (bidi_cache_find_level_change, bidi_cache_iterator_state)
15 (bidi_cache_find, bidi_peek_at_next_level)
16 (bidi_level_of_next_char, bidi_find_other_level_edge)
17 (bidi_move_to_visually_next): Compare cache index with
18 bidi_cache_start rather than with zero.
19 (bidi_fetch_char): Accept new argument STRING; all callers
20 changed. Support iteration over a string.
21 (bidi_paragraph_init, bidi_resolve_explicit_1)
22 (bidi_resolve_explicit, bidi_resolve_weak)
23 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
24 iteration over a string.
25 (bidi_set_sor_type, bidi_resolve_explicit_1)
26 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
27 can now be zero (for strings); special values 0 and -1 were
28 changed to -1 and -2, respectively.
29 (bidi_char_at_pos): New function.
30 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
31 Call it instead of FETCH_MULTIBYTE_CHAR.
32 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
33 initialized to valid values.
34 (bidi_init_it): Don't initialize charpos and bytepos with invalid
35 values.
36
37 * xdisp.c (compute_display_string_pos)
38 (compute_display_string_end): Accept additional argument STRING.
39 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
40 (reseat_to_string): Initialize bidi_it->string.s and
41 bidi_it->string.schars.
42
43 * dispextern.h (struct bidi_string_data): New structure.
44 (struct bidi_it): New member `string'. Make flag members be 1-bit
45 fields, and put them last in the struct.
46 (compute_display_string_pos, compute_display_string_end): Update
47 prototypes.
48
9d68c2a9
EZ
492011-06-04 Eli Zaretskii <eliz@gnu.org>
50
51 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
52
57f97249
EZ
532011-06-03 Eli Zaretskii <eliz@gnu.org>
54
55 * bidi.c (bidi_fetch_char_advance): Remove unused and
56 unimplemented function.
57
c40e2fb2
EZ
582011-05-28 Eli Zaretskii <eliz@gnu.org>
59
0e14fe90
EZ
60 * xdisp.c (set_cursor_from_row): Set start and stop points
61 according to the row's direction when priming the loop that looks
62 for the glyph on which to display cursor.
63 (single_display_spec_intangible_p): Function deleted.
64 (display_prop_intangible_p): Reimplement to call
65 handle_display_spec instead of single_display_spec_intangible_p.
66 Accept 3 additional arguments needed by handle_display_spec. This
67 fixes incorrect cursor motion across display property with complex
68 values: lists, `(when COND...)' forms, etc.
69 (single_display_spec_string_p): Support property values that are
70 lists with the argument STRING its top-level element.
71 (display_prop_string_p): Fix the condition for processing a
72 property that is a list to be consistent with handle_display_spec.
73
74 * keyboard.c (adjust_point_for_property): Adjust the call to
75 display_prop_intangible_p to its new signature.
76
77 * dispextern.h (display_prop_intangible_p): Adjust prototype.
c40e2fb2 78
fc6f18ce
EZ
792011-05-21 Eli Zaretskii <eliz@gnu.org>
80
81 * xdisp.c (handle_display_spec): New function, refactored from the
82 last portion of handle_display_prop.
83 (compute_display_string_pos): Accept additional argument
84 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
85 value of a `display' property is a "replacing spec".
86 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
87 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
88 the display property, but just return a value indicating whether
89 the display property will replace the characters it covers.
90 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
91 frame_window_p members of struct bidi_it.
92
93 * bidi.c (bidi_fetch_char): Accept additional argument
94 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
95 callers changed.
96 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
97 it to initialize the frame_window_p member of struct bidi_it.
98
99 * dispextern.h (struct bidi_it): New member frame_window_p.
100 (bidi_init_it, compute_display_string_pos): Update prototypes.
101
102ebb00
EZ
1022011-05-14 Eli Zaretskii <eliz@gnu.org>
103
7b600102
EZ
104 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
105 (compute_display_string_end): New function.
683a44f7
EZ
106 (push_it): Accept second argument POSITION, where pop_it should
107 jump to continue iteration.
7b600102
EZ
108
109 * dispextern.h (compute_display_string_end): Declare prototype.
110
111 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
112 (bidi_fetch_char): Implement support for runs of characters
113 covered by display strings.
114
102ebb00 115 * bidi.c (bidi_fetch_char): Accept also character position
7b600102
EZ
116 corresponding to BYTEPOS. DISP_POS is now a character position,
117 not a byte position. All callers changed.
102ebb00
EZ
118 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
119 (bidi_resolve_explicit, bidi_resolve_weak)
120 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
121 bidi_it->nchars is non-positive.
122 (bidi_level_of_next_char): Don't try to lookup the cache for the
123 next/previous character if nothing is cached there yet, or if we
124 were just reseat()'ed to a new position.
125 (bidi_paragraph_init, bidi_resolve_explicit_1)
126 (bidi_level_of_next_char): Fix arguments in the calls to
127 bidi_fetch_char.
128
182ce2d2
EZ
1292011-05-10 Eli Zaretskii <eliz@gnu.org>
130
131 * xdisp.c (compute_display_string_pos): New function.
132 (reseat_1): Initialize bidi_it.disp_pos.
133
134 * bidi.c (bidi_copy_it): Use offsetof.
135 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
136 (bidi_cache_search, bidi_cache_iterator_state)
137 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
138 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
139 character positions inside a run of characters covered by a
140 display string.
141 (bidi_paragraph_init, bidi_resolve_explicit_1)
142 (bidi_level_of_next_char): Call bidi_fetch_char and
143 bidi_fetch_char_advance instead of FETCH_CHAR and
144 FETCH_CHAR_ADVANCE.
145 (bidi_init_it): Initialize new members.
146 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
147 definitions.
148 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
149 instead of using explicit *_CHAR codes.
150 (bidi_resolve_explicit, bidi_resolve_weak): Use
151 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
152 bidirectional text is supported only in multibyte buffers.
153
154 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
155 ch_len is now EMACS_INT.
156 (compute_display_string_pos): Declare prototype.
157
57679c86
AS
1582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
159
160 * w32menu.c (set_frame_menubar): Fix submenu allocation.
161
888c9e86
EZ
1622011-05-07 Eli Zaretskii <eliz@gnu.org>
163
b0512a1d
EZ
164 * w32console.c (Fset_screen_color): Doc fix.
165 (Fget_screen_color): New function.
166 (syms_of_ntterm): Defsubr it.
167
888c9e86
EZ
168 * callproc.c (call_process_cleanup): Don't close and unlink the
169 temporary file if Fcall_process didn't create it in the first
170 place.
171 (Fcall_process): Don't create tempfile if stdout of the child
172 process will be redirected to a file specified with `:file'.
173 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
174 cue to call_process_cleanup not to close that handle.
175
4d3fcc8e
BK
1762011-05-07 Ben Key <bkey76@gmail.com>
177
178 * makefile.w32-in: The bootstrap-temacs rule now makes use of
179 one of two shell specific rules, either bootstrap-temacs-CMD or
180 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
181 to the previous implementation of the bootstrap-temacs rule.
182 The bootstrap-temacs-CMD rule is similar to the previous
183 implementation of the bootstrap-temacs rule except that it
184 makes use of the ESC_CFLAGS variable instead of the CFLAGS
185 variable.
186
187 These changes, along with some changes to nt/configure.bat,
188 nt/gmake.defs, and nt/nmake.defs, are required to extend my
189 earlier fix to add support for --cflags and --ldflags options
190 that include quotes so that it works whether make uses cmd or
191 sh as the shell.
192
b4289b64
MA
1932011-05-06 Michael Albinus <michael.albinus@gmx.de>
194
195 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
196 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
197 is a constant.
198 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
199 a string. Handle both cases.
200 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
201 (Fdbus_register_method): Use Qinvalid_function.
202
af4c0e28
JB
2032011-05-06 Juanma Barranquero <lekktu@gmail.com>
204
205 * makefile.w32-in: Update dependencies.
206 (LISP_H): Add inttypes.h and stdin.h.
207 (PROCESS_H): Add unistd.h.
208
c51453d9
EZ
2092011-05-06 Eli Zaretskii <eliz@gnu.org>
210
211 * lread.c: Include limits.h (fixes the MS-Windows build broken by
212 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
213
8ff0ac3c 2142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 215
4c4b566b
PE
216 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
217
aab2b9b5
PE
218 * term.c (vfatal): Remove stray call to va_end.
219 It's not needed and the C Standard doesn't allow it here anyway.
220
c378da0b
PE
221 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
222 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
223
288b08c7
PE
224 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
225 bytes.
226
e3601888
PE
227 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
228
db6c0e74
PE
229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
230
dd5963ea
PE
231 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
232
88c9450f
PE
233 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
234
2f9442b8
PE
235 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
236
c032b5f8
PE
237 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
238 * charset.c (Fdefine_charset_internal): Don't initialize
239 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 240 32-bit int (Bug#8600).
a108c10b
PE
241
242 * lread.c (read_integer): Be more consistent with string-to-number.
243 Use string_to_number to do the actual conversion; this avoids
244 rounding errors and fixes some other screwups. Without this fix,
245 for example, #x1fffffffffffffff was misread as -2305843009213693952.
246 (digit_to_number): Move earlier, for benefit of read_integer.
247 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 248 not a digit in any supported base. (Bug#8602)
a108c10b 249
ad5f9eea
PE
250 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
251
aec1708a
PE
252 * dispnew.c (scrolling_window): Return 1 if we scrolled,
253 to match comment at start of function. This also removes a
254 GCC warning about overflow in a 32+64-bit port.
255
47be4ab5
PE
256 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
257
371cac43
PE
258 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
259 Reported by Stefan Monnier in
260 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
261 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
262 SYMBOLP-guarded XSYMBOL, not XPNTR.
263
d01a7826
PE
264 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
265 (EMACS_UINTPTR): Likewise, with uintptr_t.
266
7fd47d5c
PE
267 * lisp.h: Prefer 64-bit EMACS_INT if available.
268 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
269 on 32-bit hosts that have 64-bit int, so that they can access
270 large files.
122b0c86
PE
271 However, temporarily disable this change unless the temporary
272 symbol WIDE_EMACS_INT is defined.
7fd47d5c 273
8727937b
PE
274 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
275
8ac068ac
PE
276 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
277 This removes an assumption that EMACS_INT and long are the same
278 width as pointers. The assumption is true for Emacs porting targets
279 now, but we want to make other targets possible.
280 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
281 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
282 In the rest of the code, change types of integers that hold casted
283 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
284 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
285 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
286 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
287 No need to cast type when ORing.
288 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
289 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
290 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
291 assume EMACS_INT is the same width as char *.
292 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
293 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
294 Remove no-longer-needed casts.
295 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
296 (xg_tool_bar_help_callback, xg_make_tool_item):
297 Use EMACS_INTPTR to hold an integer
298 that will be cast to void *; this can avoid a GCC warning
299 if EMACS_INT is not the same width as void *.
300 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
301 * xdisp.c (display_echo_area_1, resize_mini_window_1):
302 (current_message_1, set_message_1):
303 Use a local to convert to proper width without a cast.
304 * xmenu.c (dialog_selection_callback): Likewise.
305
ede49d71
PE
306 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
307 Also, don't assume VALBITS / RAND_BITS is less than 5,
308 and don't rely on undefined behavior when shifting a 1 left into
309 the sign bit.
310 * lisp.h (get_random): Change signature to match.
311
2f30ecd0
PE
312 * lread.c (hash_string): Use size_t, not int, for hash computation.
313 Normally we prefer signed values; but hashing is special, because
314 it's better to use unsigned division on hash table sizes so that
315 the remainder is nonnegative. Also, size_t is the natural width
316 for hashing into memory. The previous code used 'int', which doesn't
317 retain enough info to hash well into very large tables.
318 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
319
2a866e7b
PE
320 * dbusbind.c: Don't possibly lose pointer info when converting.
321 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
322 Use XPNTR rather than XHASH, so that the high-order bits of
323 the pointer aren't lost when converting through void *.
324
51639eac
PE
325 * eval.c (Fautoload): Don't double-shift a pointer.
326
92394119
PE
327 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
328
dbdb9a7c
JB
3292011-05-06 Juanma Barranquero <lekktu@gmail.com>
330
331 * gnutls.c (DEF_GNUTLS_FN):
332 * image.c (DEF_IMGLIB_FN): Make function pointers static.
333
db7a0b4f
AS
3342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
335
336 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
337 marker. (Bug#8610)
338
f7ff1b0f 3392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
340
341 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
342 New version that can reserve upto 2GB of heap space.
343
f7ff1b0f 3442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
345
346 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
347
639c109b
TZ
3482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
349
350 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
351 `gnutls_certificate_set_x509_key_file'.
352
d2127135
JB
3532011-05-05 Juanma Barranquero <lekktu@gmail.com>
354
355 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
356 Update dependencies.
357
e968f4f3
JB
3582011-05-04 Juanma Barranquero <lekktu@gmail.com>
359
360 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
361 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
362 Remove unused parameter `fildes'.
363 * process.c (read_process_output, send_process): Don't pass it.
364
84d358f0
JB
3652011-05-04 Juanma Barranquero <lekktu@gmail.com>
366
367 Fix previous change: the library cache is defined in w32.c.
368 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
369 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
370
0898ca10
JB
3712011-05-04 Juanma Barranquero <lekktu@gmail.com>
372
373 Implement dynamic loading of GnuTLS on Windows.
374
375 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
376 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
377 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
378 Declare.
379
380 * gnutls.c (Qgnutls_dll): Define.
381 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
382 (gnutls_*): Declare function pointers.
383 (init_gnutls_functions): New function to initialize function pointers.
384 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
385 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
386 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
387 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
388 (emacs_gnutls_write, emacs_gnutls_read)
389 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
390 (Fgnutls_available_p): New function.
391 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
392 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
393 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
394
395 * image.c: Include w32.h.
396 (Vimage_type_cache): Delete.
397 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
398 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
399 (w32_delayed_load): Move to w32.c.
400
401 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
402
403 * w32.c (QCloaded_from, Vlibrary_cache): Define.
404 (w32_delayed_load): Move from image.c. When loading a library, record
405 its filename in the :loaded-from property of the library id.
406 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
407 Initialize and staticpro them.
408 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
409
410 * process.c: Include lisp.h before w32.h, not after.
411 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
412 instead of gnutls_record_check_pending.
413
414 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
415
ff4de4aa
TZ
4162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
417
418 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
419 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
420 as passed in.
421
abe95abb
JD
4222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
423
424 * xterm.c (x_set_frame_alpha): Do not set property on anything
425 else than FRAME_X_OUTER_WINDOW (Bug#8608).
426
e16e55d4
JB
4272011-05-02 Juanma Barranquero <lekktu@gmail.com>
428
429 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
430
bafcf6a5
JB
4312011-05-02 Juanma Barranquero <lekktu@gmail.com>
432
433 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
434 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
435 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
436 (gnutls_global_initialized, Qgnutls_bootprop_priority)
437 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
438 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
439 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
440 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
441 (Qgnutls_bootprop_callbacks_verify): Make static.
442
e7a6747f
AS
4432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
444
19ed11ba
AS
445 * callproc.c: Indentation fixup.
446
e7a6747f
AS
447 * sysdep.c (wait_for_termination_1): Make static.
448 (wait_for_termination, interruptible_wait_for_termination): Move
449 after wait_for_termination_1.
450
1ef14cb4
LMI
4512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
452
453 * sysdep.c (interruptible_wait_for_termination): New function
454 which is like wait_for_termination, but allows keyboard
455 interruptions.
456
457 * callproc.c (Fcall_process): Add (:file "file") as an option for
458 the STDOUT buffer.
459 (Fcall_process_region): Ditto.
460
330d880c
EZ
4612011-04-30 Eli Zaretskii <eliz@gnu.org>
462
8db90b73
EZ
463 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
464 rather than `XVECTOR (FOO)->size'.
465
330d880c
EZ
466 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
467 inttypes.h, as a gnulib replacement is used if it not available in
468 system headers.
469
15cbd324
EZ
4702011-04-21 Eli Zaretskii <eliz@gnu.org>
471
472 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
473 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
474 of MOST_POSITIVE_FIXNUM. (Bug#8528)
475
476 * coding.c (coding_alloc_by_realloc): Error out if destination
477 will grow beyond MOST_POSITIVE_FIXNUM.
478 (decode_coding_emacs_mule): Abort if there isn't enough place in
479 charbuf for the composition carryover bytes. Reserve an extra
480 space for up to 2 characters produced in a loop.
481 (decode_coding_iso_2022): Abort if there isn't enough place in
482 charbuf for the composition carryover bytes.
483
4842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 485
ae940cca
EZ
486 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
487 aborting when %lld or %lll format is passed.
488 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
489 %llo or %llx format is passed. (Bug#8545)
490
03ab8921
EZ
491 * window.c (window_scroll_line_based): Use a marker instead of
492 simple variables to record original value of point. (Bug#7952)
493
afda1437
EZ
494 * doprnt.c (doprnt): Fix the case where a multibyte sequence
495 produced by %s or %c overflows available buffer space. (Bug#8545)
496
f76dee0c
PE
4972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
498
499 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 500 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 501
fdc5744d
JB
5022011-04-28 Juanma Barranquero <lekktu@gmail.com>
503
504 * w32.c (init_environment): Warn about defaulting HOME to C:\.
505
638f053a
JB
5062011-04-28 Juanma Barranquero <lekktu@gmail.com>
507
508 * keyboard.c (Qdelayed_warnings_hook): Define.
509 (command_loop_1): Run `delayed-warnings-hook'
510 if Vdelayed_warnings_list is non-nil.
511 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
512 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
513
d178f871
EZ
5142011-04-28 Eli Zaretskii <eliz@gnu.org>
515
516 * doprnt.c (doprnt): Don't return value smaller than the buffer
517 size if the message was truncated. (Bug#8545).
518
b124fd93
JB
5192011-04-28 Juanma Barranquero <lekktu@gmail.com>
520
521 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
522 (Fx_window_property): #if-0 the whole functions, not just the bodies.
523
e810457d
PE
5242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
525
526 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
527
ea51cceb
JB
5282011-04-27 Juanma Barranquero <lekktu@gmail.com>
529
530 * makefile.w32-in: Update dependencies.
531
94dcfacf
EZ
5322011-04-27 Eli Zaretskii <eliz@gnu.org>
533
534 Improve `doprnt' and its usage. (Bug#8545)
535 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
536 `format_end'. Remove support for %l as a conversion specifier.
537 Don't use xrealloc. Improve diagnostics when the %l size modifier
538 is used. Update the commentary.
539
540 * eval.c (verror): Simplify calculation of size_t.
541
542 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
543 messages.
544
f61f41d7
PE
5452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
546
547 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
548 change.
549
96fb4434
PE
5502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
551
552 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
553 This makes this file independent of the recent pseudovector change.
554
671875da 5552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 556
69e9b5a3
PE
557 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
558
b5f869a7 559 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 560 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 561 Remove unused local.
c8926152 562 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 563
841a1577 564 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
565 GCC 4.6.0 optimizes based on type-based alias analysis. For
566 example, if b is of type struct buffer * and v of type struct
567 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
568 != &v->size, and therefore "v->size = 1; b->size = 2; return
569 v->size;" must therefore return 1. This assumption is incorrect
570 for Emacs, since it type-puns struct Lisp_Vector * with many other
571 types. To fix this problem, this patch adds a new type struct
f904488f 572 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
573 and pseudovectors, and helps optimizing compilers not get fooled
574 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
575 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
576 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
577 the size member.
eab3844f
PE
578 (XSETPVECTYPE): Rewrite in terms of new macro.
579 (XSETPVECTYPESIZE): New macro, specifying both type and size.
580 This is a bit clearer, and further avoids the possibility of
581 undesirable aliasing.
582 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 583 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
584 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
585 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
586 (ASIZE): Now uses header.size rather than size. All
587 previous uses of XVECTOR (foo)->size replaced to use this macro,
588 to avoid the hassle of writing XVECTOR (foo)->header.size.
589 (struct vectorlike_header): New type.
eab3844f
PE
590 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
591 object, to help avoid aliasing.
592 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
593 (SUBRP): Likewise, since Lisp_Subr is a special case.
594 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
595 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
596 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 597 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
598 changed to be "header.size" and "header.next".
599 * buffer.h (struct buffer): Likewise.
600 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
601 * frame.h (struct frame): Likewise.
602 * process.h (struct Lisp_Process): Likewise.
603 * termhooks.h (struct terminal): Likewise.
604 * window.c (struct save_window_data, struct saved_window): Likewise.
605 * window.h (struct window): Likewise.
606 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
607 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
608 * buffer.c (init_buffer_once): Likewise.
609 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
610 special case.
611 * process.c (Fformat_network_address): Use local var for size,
612 for brevity.
613
0df1eac5
PE
614 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
615
847ab9d1 616 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
617 * data.c (atof): Remove decl; no longer used or needed.
618 (digit_to_number): Move to lread.c.
619 (Fstring_to_number): Use new string_to_number function, to be
620 consistent with how the Lisp reader treats infinities and NaNs.
621 Do not assume that floating-point numbers represent EMACS_INT
622 without losing information; this is not true on most 64-bit hosts.
623 Avoid double-rounding errors, by insisting on integers when
624 parsing non-base-10 numbers, as the documentation specifies.
625 * lisp.h (string_to_number): New decl, replacing ...
626 (isfloat_string): Remove.
bc0a5c13 627 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 628 (read1): Do not accept +. and -. as integers; this
452f4150
PE
629 appears to have been a coding error. Similarly, do not accept
630 strings like +-1e0 as floating point numbers. Do not report
631 overflow for integer overflows unless the base is not 10 which
632 means we have no simple and reliable way to continue.
633 Break out the floating-point parsing into a new
634 function string_to_number, so that Fstring_to_number parses
635 floating point numbers consistently with the Lisp reader.
636 (digit_to_number): Moved here from data.c. Make it static inline.
637 (E_CHAR, EXP_INT): Remove, replacing with ...
638 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
639 (string_to_number): New function, replacing isfloat_string.
640 This function checks for valid syntax and produces the resulting
641 Lisp float number too. Rework it so that string-to-number
bc0a5c13 642 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
643 so that overflow for non-base-10 numbers is reported only when
644 there's no portable and simple way to convert to floating point.
452f4150 645
67769ffc
PE
646 * textprop.c (set_text_properties_1): Rewrite for clarity,
647 and to avoid GCC warning about integer overflow.
648
c20db43f
PE
649 * intervals.h (struct interval): Use EMACS_INT for members
650 where EMACS_UINT might cause problems. See
651 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
652 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
653 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
654 All uses changed.
37aa2f85
PE
655 (offset_intervals): Tell GCC not to worry about length overflow
656 when negating a negative length.
c20db43f 657
2538aa2f
PE
658 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
659 (overrun_check_free): Likewise.
660
f2d3008d
PE
661 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
662 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
663 word size.
664
ec8df744
PE
665 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
666 (gnutls_make_error): Rename local to avoid shadowing.
667 (gnutls_emacs_global_deinit): ifdef out; not used.
668 (Fgnutls_boot): Use const for pointer to readonly storage.
669 Comment out unused local. Fix pointer signedness problems.
670
640ee02d
PE
671 * lread.c (openp): Don't stuff size_t into an 'int'.
672 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
673 about possible signed overflow.
674
6048fb2a
PE
675 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
676 (GDK_KEY_g): Don't define if already defined.
677 (xg_prepare_tooltip): Avoid pointer signedness problem.
678 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
679
fa3c87e1
PE
680 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
681 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
682
2172544b
PE
683 * xfns.c (Fx_window_property): Simplify a bit,
684 to make a bit faster and to avoid GCC 4.6.0 warning.
685 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
686
9b821a21
PE
687 * fns.c (internal_equal): Don't assume size_t fits in int.
688
3c616cfa
PE
689 * alloc.c (compact_small_strings): Tighten assertion a little.
690
c2982e87
PE
691 Replace pEd with more-general pI, and fix some printf arg casts.
692 * lisp.h (pI): New macro, generalizing old pEd macro to other
693 conversion specifiers. For example, use "...%"pI"d..." rather
694 than "...%"pEd"...".
695 (pEd): Remove. All uses replaced with similar uses of pI.
696 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
697 * alloc.c (check_pure_size): Don't overflow by converting size to int.
698 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
699 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
700 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
701 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
702 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
703 64-bit hosts.
704 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
705 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
706 * print.c (safe_debug_print, print_object): Likewise.
707 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
708 to int.
6f04d126
PE
709 Use pI instead of if-then-else-abort. Use %p to avoid casts,
710 avoiding the 0 flag, which is not portable.
c2982e87
PE
711 * process.c (Fmake_network_process): Use pI to avoid cast.
712 * region-cache.c (pp_cache): Likewise.
713 * xdisp.c (decode_mode_spec): Likewise.
714 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
715 behavior on 64-bit hosts with printf arg.
6f04d126 716 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
717 (x_stop_queuing_selection_requests): Likewise.
718 (x_get_window_property): Don't truncate byte count to an 'int'
719 when tracing.
0b432f21 720
5e073ec7
PE
721 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
722 here, since it parses constructs like leading '-' and spaces,
723 which are not wanted; and it overflows with large numbers.
724 Instead, simply match F[0-9]+, which is what is wanted anyway.
725
36372bf9
PE
726 * alloc.c: Remove unportable assumptions about struct layout.
727 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
728 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
729 (allocate_vectorlike, make_pure_vector): Use the new macros,
730 plus offsetof, to remove unportable assumptions about struct layout.
731 These assumptions hold on all porting targets that I know of, but
732 they are not guaranteed, they're easy to remove, and removing them
733 makes further changes easier.
734
0b432f21
PE
735 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
736 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
737 (string_overrun_cookie): Now const. Use initializers that
738 don't formally overflow signed char, to avoid warnings.
000098c1
PE
739 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
740 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
741 (allocate_buffer): Don't assume sizeof (struct buffer) is a
742 multiple of sizeof (EMACS_INT); it need not be, if
743 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 744 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 745
895009e1
JB
7462011-04-26 Juanma Barranquero <lekktu@gmail.com>
747
748 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
749
6a7a1b0b
TZ
7502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
751
752 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 753 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
754 Reported by Paul Eggert <eggert@cs.ucla.edu>.
755
841a1577 7562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
757
758 * lisp.h (Qdebug): List symbol.
895009e1 759 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
760 * keyboard.c (debug-on-event): New variable.
761 (handle_user_signal): Break into debugger when debug-on-event
762 matches the current signal symbol.
763
f2d3ba6f
DN
7642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
765
766 * alloc.c (check_sblock, check_string_bytes)
767 (check_string_free_list): Convert to standard C.
768
42ce4c63
TZ
7692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
770
771 * w32.c (emacs_gnutls_push): Fix typo.
772
825cd63c
EZ
7732011-04-25 Eli Zaretskii <eliz@gnu.org>
774
fb11d64d
EZ
775 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
776 "cast to pointer from integer of different size".
777
825cd63c
EZ
778 Improve doprnt and its use in verror. (Bug#8545)
779 * doprnt.c (doprnt): Document the set of format control sequences
780 supported by the function. Use SAFE_ALLOCA instead of always
781 using `alloca'.
782
783 * eval.c (verror): Don't limit the buffer size at size_max-1, that
784 is one byte too soon. Don't use xrealloc; instead xfree and
785 xmalloc anew.
786
e061a11b
TZ
7872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
788
789 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
790 callbacks stage.
791
792 * gnutls.c: Renamed global_initialized to
793 gnutls_global_initialized. Added internals for the
794 :verify-hostname-error, :verify-error, and :verify-flags
795 parameters of `gnutls-boot' and documented those parameters in the
796 docstring. Start callback support.
797 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
798 unless a fatal error occured. Call gnutls_alert_send_appropriate
799 on error. Return error code.
800 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
801 (emacs_gnutls_read): Likewise.
802 (Fgnutls_boot): Return handshake error code.
803 (emacs_gnutls_handle_error): New function.
804 (wsaerror_to_errno): Likewise.
805
806 * w32.h (emacs_gnutls_pull): Add prototype.
807 (emacs_gnutls_push): Likewise.
808
809 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
810 (emacs_gnutls_push): Likewise.
811
8122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
813
814 * process.c (wait_reading_process_output): Check if GnuTLS
815 buffered some data internally if no FDs are set for TLS
816 connections.
817
818 * makefile.w32-in (OBJ2): Add gnutls.$(O).
819 (LIBS): Link to USER_LIBS.
820 ($(BLD)/gnutls.$(0)): New target.
821
fa6996bc
EZ
8222011-04-24 Eli Zaretskii <eliz@gnu.org>
823
eb35682e
EZ
824 * xdisp.c (handle_single_display_spec): Rename the
825 display_replaced_before_p argument into display_replaced_p, to
826 make it consistent with the commentary. Fix typos in the
827 commentary.
828
e2ad650c
EZ
829 * textprop.c (syms_of_textprop): Remove dead code.
830 (copy_text_properties): Delete obsolete commentary about an
831 interface that was deleted long ago. Fix typos in the description
832 of arguments.
833
1b2de274
EZ
834 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
835 to changes in oldXMenu/XMenu.h from 2011-04-16.
836 <menu_help_message, prev_menu_help_message>: Constify.
837 (IT_menu_make_room): menu->help_text is now `const char **';
838 adjust.
839
840 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
841 to changes in oldXMenu/XMenu.h from 2011-04-16.
842 (struct XMenu): Declare `help_text' `const char **'.
843
844 * xfaces.c <Qunspecified>: Make extern again.
845
846 * syntax.c: Include sys/types.h before including regex.h, as
847 required by Posix.
848
762b15be
EZ
849 * doc.c (get_doc_string): Improve the format passed to `error'.
850
851 * doprnt.c (doprnt): Improve commentary.
852
853 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
854
855 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
856 them with etags.
857
f1052e5d
EZ
858 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
859 changes in globals.h immediately force recompilation.
762b15be
EZ
860 (TAGS): Depend on $(CURDIR)/m/intel386.h and
861 $(CURDIR)/s/ms-w32.h.
862 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 863
fa6996bc
EZ
864 * character.c (Fchar_direction): Function deleted.
865 (syms_of_character): Don't defsubr it.
866 <char-direction-table>: Deleted.
867
e6c3da20
EZ
8682011-04-23 Eli Zaretskii <eliz@gnu.org>
869
870 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
871 * doprnt.c: Include limits.h.
872 (SIZE_MAX): New macro.
873 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
874 local variables are now size_t instead of int or unsigned.
875 Improve overflow protection. Support `l' modifier for integer
876 conversions. Support %l conversion. Don't assume an EMACS_INT
877 argument for integer conversions and for %c.
878
879 * lisp.h (doprnt): Restore prototype.
880
881 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
882 $(SRC)/character.h.
883
884 * Makefile.in (base_obj): Add back doprnt.o.
885
886 * deps.mk (doprnt.o): Add back prerequisites.
887 (callint.o): Depend on character.h.
888
889 * eval.c (internal_lisp_condition_case): Include the handler
890 representation in the error message.
891 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
892 when breaking from the loop.
893
894 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
895
896 * callint.c (Fcall_interactively): When displaying error message
897 about invalid control letter, pass the character's codepoint, not
898 a pointer to its multibyte form. Improve display of the character
899 in octal and display also its hex code.
900
901 * character.c (char_string): Use %x to display the (unsigned)
902 codepoint of an invalid character, to avoid displaying a bogus
903 negative value.
904
905 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
906 `error', not SYMBOL_NAME itself.
907
908 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
909 character arguments to `error'.
910
911 * charset.c (check_iso_charset_parameter): Fix incorrect argument
912 to `error' in error message about FINAL_CHAR argument. Make sure
913 FINAL_CHAR is a character, and use %c when it is passed as
914 argument to `error'.
915
4ffd0d6b 9162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
917
918 * s/ms-w32.h (localtime): Redirect to sys_localtime.
919
920 * w32.c: Include <time.h>.
921 (sys_localtime): New function.
922
4ffd0d6b 9232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
924
925 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
926
4ffd0d6b 927 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 928
4ffd0d6b 9292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 930
4ffd0d6b
GM
931 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
932 zombies (Bug#8467).
aac0c6e3 933
04c56954
EZ
9342011-04-19 Eli Zaretskii <eliz@gnu.org>
935
936 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
937 gl_state.e_property when gl_state.object is Qt.
938
939 * insdel.c (make_gap_larger): Remove limitation of buffer size
940 to <= INT_MAX.
941
16a43933
CY
9422011-04-18 Chong Yidong <cyd@stupidchicken.com>
943
944 * xdisp.c (lookup_glyphless_char_display)
945 (produce_glyphless_glyph): Handle cons cell entry in
946 glyphless-char-display.
947 (Vglyphless_char_display): Document it.
948
949 * term.c (produce_glyphless_glyph): Handle cons cell entry in
950 glyphless-char-display.
951
4581706e
CY
9522011-04-17 Chong Yidong <cyd@stupidchicken.com>
953
954 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
955
956 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
957
958 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
959 definition for no-X builds.
960
4887c6e2 9612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 962
fd35b6f9
PE
963 Static checks with GCC 4.6.0 and non-default toolkits.
964
5c1ccb01
PE
965 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
966
006c5daa
PE
967 * process.c (keyboard_bit_set): Define only if SIGIO.
968 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
969 (send_process): Repair possible setjmp clobbering.
970
efc736d3
PE
971 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
972
4e2fe2e6
PE
973 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
974
f97334a2
PE
975 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
976
4e75f29d
PE
977 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
978 Define only if needed.
979
90efadd1
PE
980 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
981 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 982 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 983
3c647824
PE
984 * dispextern.h (struct redisplay_interface): Rename param
985 to avoid shadowing.
e264f262 986 * termhooks.h (struct terminal): Likewise.
761383f4 987 * xterm.c (xembed_send_message): Likewise.
3c647824 988
b58c5c4a
PE
989 * insdel.c (make_gap_smaller): Define only if
990 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
991
cad59032
PE
992 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
993 it.
994
c339dc2e
PE
995 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
996 so that we aren't warned about unused symbols.
997
91a3e27b
PE
998 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
999
399c71d3 1000 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1001
8ffc96f5
PE
1002 * xfns.c (x_real_positions): Mark locals as initialized.
1003
eef9bc79
PE
1004 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1005
098db9dd
PE
1006 * xterm.c: Fix problems found by static analysis with other toolkits.
1007 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1008 (x_dispatch_event): Declare static if USE_GTK, and
1009 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1010 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1011 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1012 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1013 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1014
eb18f6cc
PE
1015 * xmenu.c (menu_help_callback): Pointer type fixes.
1016 Use const pointers when pointing at readonly data. Avoid pointer
1017 signedness clashes.
1018 (FALSE): Remove unused macro.
1019 (update_frame_menubar): Remove unused decl.
1020
1fe72bf8
PE
1021 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1022
60d9e1db
PE
1023 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1024 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1025 (single_menu_item): Rename local to avoid shadowing.
1026
39261c26
PE
1027 * keyboard.c (make_lispy_event): Remove unused local var.
1028
018c5e19
PE
1029 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1030 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1031
63d2b86e
PE
1032 * bitmaps: Change bitmaps from unsigned char back to the X11
1033 compatible char. Avoid the old compiler warnings about
1034 out-of-range initializers by using, for example, '\xab' rather
1035 than 0xab.
1036
aefd87e1
PE
1037 * xgselect.c (xgselect_initialize): Check vs interface
1038 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1039
bf501fb9
PE
1040 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1041
e9829fdf
PE
1042 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1043 to read-only memory.
1044
1086c095
PE
1045 * fns.c (vector): Remove; this old hack is no longer needed.
1046
2baccd04 1047 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1048 Remove unused var.
dde42981 1049 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1050
72391843 1051 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1052
436c16df 1053 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1054 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1055 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1056
92bb796d 1057 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1058 (x_term_init): Remove local to avoid shadowing.
92bb796d 1059
764430a3 1060 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1061
1062 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1063 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1064
d1dfb56c
EZ
10652011-04-16 Eli Zaretskii <eliz@gnu.org>
1066
c4354cb4
EZ
1067 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1068
d1dfb56c
EZ
1069 Fix regex.c, syntax.c and friends for buffers > 2GB.
1070 * syntax.h (struct gl_state_s): Declare character position members
1071 EMACS_INT.
1072
1073 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1074
1075 * textprop.c (verify_interval_modification, interval_of): Declare
1076 arguments EMACS_INT.
1077
1078 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1079 EMACS_INT.
1080
1081 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1082
1083 * indent.c (Fvertical_motion): Local variable it_start is now
1084 EMACS_INT.
1085
1086 * regex.c (re_match, re_match_2, re_match_2_internal)
1087 (bcmp_translate, regcomp, regexec, print_double_string)
1088 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1089 (re_compile_pattern, re_exec): Declare arguments and local
1090 variables `size_t' and `ssize_t' and return values `regoff_t', as
1091 appropriate.
1092 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1093 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1094 <compile_stack_type>: `size' and `avail' are now `size_t'.
1095
1096 * regex.h <regoff_t>: Use ssize_t, not int.
1097 (re_search, re_search_2, re_match, re_match_2): Arguments that
1098 specify buffer/string position and length are now ssize_t and
1099 size_t. Return type is regoff_t.
1100
613052cd
BK
11012011-04-16 Ben Key <bkey76@gmail.com>
1102
1103 * nsfont.m: Fixed bugs in ns_get_family and
1104 ns_descriptor_to_entity that were caused by using free to
1105 deallocate memory blocks that were allocated by xmalloc (via
1106 xstrdup). This caused Emacs to crash when compiled with
1107 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1108 --enable-checking=xmallocoverrun). xfree is now used to
1109 deallocate these memory blocks.
1110
4170f62f 11112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1112
71b41406
PE
1113 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1114
9587a89d
PE
1115 emacs_write: Accept and return EMACS_INT for sizes.
1116 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1117 et seq.
1118 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1119 Accept and return EMACS_INT.
1120 (emacs_gnutls_write): Return the number of bytes written on
1121 partial writes.
1122 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1123 (emacs_read, emacs_write): Remove check for negative size, as the
1124 Emacs source code has been audited now.
9587a89d
PE
1125 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1126 (emacs_read, emacs_write): Use it.
273a5f82
PE
1127 * process.c (send_process): Adjust to the new signatures of
1128 emacs_write and emacs_gnutls_write. Do not attempt to store
1129 a byte offset into an 'int'; it might overflow.
9587a89d 1130 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1131
3e047f51
PE
1132 * sound.c: Don't assume sizes fit in 'int'.
1133 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1134 Return EMACS_INT, not int.
3e047f51 1135 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1136 Accept EMACS_INT, not int.
1137 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1138 record read return values.
1139
cc39a9db
BK
11402011-04-15 Ben Key <bkey76@gmail.com>
1141
c9d0ec6d
JB
1142 * keyboard.c (Qundefined): Don't declare static since it is used
1143 in nsfns.m.
1144 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1145 static since they are used in nsfont.m.
cc39a9db 1146
6c60eb9f
SM
11472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1148
1149 * process.c (Qprocessp): Don't declare static.
1150 * lisp.h (Qprocessp): Declare again.
1151
7990b61a
JB
11522011-04-15 Juanma Barranquero <lekktu@gmail.com>
1153
1154 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1155
5d4cb038
PE
11562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1157
8bd7b830 1158 Improve C-level modularity by making more things 'static'.
cd64ea1d 1159
e3b27b31
PE
1160 Don't publish debugger-only interfaces to other modules.
1161 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1162 (verify_bytepos, count_markers): Move decls to the only modules
1163 that need them.
1164 * region-cache.h (pp_cache): Likewise.
1165 * window.h (check_all_windows): Likewise.
1166 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1167
5d4cb038
PE
1168 * sysdep.c (croak): Now static, if
1169 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1170 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1171
1172 * alloc.c (refill_memory_reserve): Now static if
1173 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1174 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1175
e87b6180
PE
1176 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1177 Define only if USE_LUCID.
1178
ac64929e
PE
1179 * xrdb.c (x_customization_string, x_rm_string): Now static.
1180
6f37259d
PE
1181 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1182 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1183
1683e3ab
PE
1184 * xdisp.c (draw_row_with_mouse_face): Now static.
1185 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1186
de9c2632
PE
1187 * window.h (check_all_windows): Mark externally visible.
1188
2b96acb7
PE
1189 * window.c (window_deletion_count): Now static.
1190
1191 * undo.c: Make symbols static if they're not exported.
1192 (last_undo_buffer, last_boundary_position, pending_boundary):
1193 Now static.
1194
50436f33
PE
1195 * textprop.c (interval_insert_behind_hooks): Now static.
1196 (interval_insert_in_front_hooks): Likewise.
1197
64520e5c
PE
1198 * term.c: Make symbols static if they're not exported.
1199 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1200 (max_frame_lines, tty_set_terminal_modes):
1201 (tty_reset_terminal_modes, tty_turn_off_highlight):
1202 (get_tty_terminal): Now static.
1203 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1204 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1205 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1206 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1207 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1208
1fa53021
PE
1209 * sysdep.c: Make symbols static if they're not exported.
1210 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1211 Now static.
1212 (sigprocmask_set, full_mask): Remove; unused.
1213 (wait_debugging): Mark as visible.
1214 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1215 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1216
d4b43b22
PE
1217 * syntax.c (syntax_temp): Define only if !__GNUC__.
1218
b7c513d0
PE
1219 * sound.c (current_sound_device, current_sound): Now static.
1220
989b29ad
PE
1221 * search.c (searchbufs, searchbuf_head): Now static.
1222
13a55a78
PE
1223 * scroll.c (scroll_cost): Remove; unused.
1224 * dispextern.h (scroll_cost): Remove decl.
1225
de68a1fc
PE
1226 * region-cache.h (pp_cache): Mark as externally visible.
1227
40ccffa6
PE
1228 * process.c: Make symbols static if they're not exported.
1229 (process_tick, update_tick, create_process, chan_process):
1230 (Vprocess_alist, proc_buffered_char, datagram_access):
1231 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1232 (deactivate_process): Mark defn as static, as well as decl.
1233 * lisp.h (create_process): Remove decl.
1234 * process.h (chan_process, Vprocess_alist): Remove decls.
1235
ad64fc97
PE
1236 * print.c: Make symbols static if they're not exported.
1237 (print_depth, new_backquote_output, being_printed, print_buffer):
1238 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1239 (print_interval, print_number_index, initial_stderr_stream):
1240 Now static.
1241 * lisp.h (Fprinc): Remove decl.
1242 (debug_output_compilation_hack): Mark as externally visible.
1243
adddb265
PE
1244 * sysdep.c (croak): Move decl from here to syssignal.h.
1245 * syssignal.h (croak): Put it here, so the API can be checked when
1246 'croak' is called from dissociate_if_controlling_tty.
1247
1717ede2
PE
1248 * minibuf.c: Make symbols static if they're not exported.
1249 (minibuf_save_list, choose_minibuf_frame): Now static.
1250 * lisp.h (choose_minibuf_frame): Remove decl.
1251
fa5fb2bc
PE
1252 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1253
1e3890d1
PE
1254 * lread.c: Make symbols static if they're not exported.
1255 (read_objects, initial_obarray, oblookup_last_bucket_number):
1256 Now static.
1257 (make_symbol): Remove; unused.
1258 * lisp.h (initial_obarray, make_symbol): Remove decls.
1259
8a1414fa
PE
1260 * keyboard.c: Make symbols static if they're not exported.
1261 (single_kboard, recent_keys_index, total_keys, recent_keys):
1262 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1263 (this_single_command_key_start, echoing, last_auto_save):
1264 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1265 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1266 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1267 (Vlispy_mouse_stem, double_click_count):
1268 Now static.
1269 (force_auto_save_soon): Define only if SIGDANGER.
1270 (ignore_mouse_drag_p): Now static if
1271 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1272 (print_help): Remove; unused.
1273 (stop_character, last_timer_event): Mark as externally visible.
1274 * keyboard.h (ignore_mouse_drag_p): Declare only if
1275 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1276 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1277 * lisp.h (echoing): Remove decl.
1278 (force_auto_save_soon): Declare only if SIGDANGER.
1279 * xdisp.c (redisplay_window): Simplify code, to make it more
1280 obvious that ignore_mouse_drag_p is not accessed if !defined
1281 USE_GTK && !defined HAVE_NS.
1282
93ea6e8f
PE
1283 * intervals.c: Make symbols static if they're not exported.
1284 (merge_properties_sticky, merge_interval_right, delete_interval):
1285 Now static.
1286 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1287
77382fcc
PE
1288 * insdel.c: Make symbols static if they're not exported.
1289 However, leave prepare_to_modify_buffer alone. It's never
1290 called from outside this function, but that appears to be a bug.
1291 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1292 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1293 (adjust_after_replace_noundo): Remove; unused.
1294 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1295 (signal_before_change): Remove decls.
77382fcc 1296
9306c32e
PE
1297 * indent.c (val_compute_motion, val_vmotion): Now static.
1298
cd44d2eb
PE
1299 * image.c: Make symbols static if they're not exported.
1300 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1301 if USE_GTK.
1302 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1303 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1304
ad9a7a06
PE
1305 * fringe.c (standard_bitmaps): Now static.
1306 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1307
81626931
PE
1308 * frame.c: Make symbols static if they're not exported.
1309 (x_report_frame_params, make_terminal_frame): Now static.
1310 (get_frame_param): Now static, unless HAVE_NS.
1311 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1312 (x_get_resource_string): Remove; not used.
1313 * frame.h (make_terminal_frame, x_report_frame_params):
1314 (x_get_resource_string); Remove decls.
1315 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1316 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1317
239f9db9
PE
1318 * font.c, fontset.c: Make symbols static if they're not exported.
1319 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1320 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1321 * font.c (font_close_object): Now static.
1322 * font.h (font_close_object): Remove.
1323 * fontset.c (FONTSET_OBJLIST): Remove.
1324 (free_realized_fontset) #if-0 the body, which does nothing.
1325 (face_suitable_for_char_p): #if-0, as it's never called.
1326 * fontset.h (face_suitable_for_char_p): Remove decl.
1327 * xfaces.c (face_at_string_position): Use
1328 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1329 since 0 is always ASCII.
1330
dfcf3579
PE
1331 * fns.c (weak_hash_tables): Now static.
1332
5045092b
PE
1333 * fileio.c: Make symbols static if they're not exported.
1334 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1335 (Vwrite_region_annotation_buffers): Now static.
1336
57a96f5c
PE
1337 * eval.c: Make symbols static if they're not exported.
1338 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1339 * lisp.h (backtrace_list): Remove decl.
1340
35f08c38
PE
1341 * emacs.c: Make symbols static if they're not exported.
1342 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1343 (fatal_error_code, fatal_error_signal_hook, standard_args):
1344 Now static.
1345 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1346 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1347 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1348 * lisp.h (fatal_error_signal_hook): Remove decl.
1349 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1350
f44bd759
PE
1351 * editfns.c: Move a (normally-unused) function to its only use.
1352 * editfns.c, lisp.h (get_operating_system_release): Remove.
1353 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1354 worth the hassle of breaking this out.
1355
b532497d
PE
1356 * xterm.c: Make symbols static if they're not exported.
1357 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1358 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1359 (x_destroy_window, x_delete_display):
1360 Now static.
1361 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1362 (x_mouse_leave): Remove; unused.
1363 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1364 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1365 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1366 Remove decls.
1367 (x_mouse_leave): Declare only if WINDOWSNT.
1368 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1369 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1370 USE_X_TOOLKIT.
1371
1675728f
PE
1372 * ftxfont.c: Make symbols static if they're not exported.
1373 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1374 HAVE_FREETYPE.
1375 * font.h (ftxfont_driver): Likewise.
1376
e4cebfca
PE
1377 * xfns.c: Make symbols static if they're not exported.
1378 (x_last_font_name, x_display_info_for_name):
1379 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1380 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1381 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1382 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1383 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1384 (last_show_tip_args): Now static.
1385 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1386 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1387 (x_screen_planes): Remove; unused.
1388 * dispextern.h (x_screen_planes): Remove decl.
1389
5bf46f05
PE
1390 * dispnew.c: Make symbols static if they're not exported.
1391 * dispextern.h (redraw_garbaged_frames, scrolling):
1392 (increment_row_positions): Remove.
1393 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1394 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1395 Now static.
1396 (redraw_garbaged_frames): Remove; unused.
1397
435f4c28
PE
1398 * xfaces.c: Make symbols static if they're not exported.
1399 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1400 Remove decls.
1401 * xterm.h (defined_color): Remove decls.
1402 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1403 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1404 (menu_face_changed_default, defined_color, free_realized_face):
1405 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1406 (ascii_face_of_lisp_face): Remove; unused.
1407
8524aef3
PE
1408 * xdisp.c: Make symbols static if they're not exported.
1409 * dispextern.h (scratch_glyph_row, window_box_edges):
1410 (glyph_to_pixel_coords, set_cursor_from_row):
1411 (get_next_display_element, set_iterator_to_next):
1412 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1413 (show_mouse_face): Remove decls
1414 * frame.h (message_buf_print): Likewise.
1415 * lisp.h (pop_message, set_message, check_point_in_composition):
1416 Likewise.
1417 * xterm.h (set_vertical_scroll_bar): Likewise.
1418 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1419 (message_buf_print, scratch_glyph_row, displayed_buffer):
1420 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1421 (get_next_display_element, show_mouse_face, window_box_edges):
1422 (frame_to_window_pixel_xy, check_point_in_composition):
1423 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1424 (glyph_to_pixel_coords): Remove; unused.
1425
16390cd2
PE
1426 * dired.c (file_name_completion): Now static.
1427
1428 * dbusbind.c (xd_in_read_queued_messages): Now static.
1429
a25f4dfa
PE
1430 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1431 * data.c (circular_list_error): Remove.
1432
14a9c8df
PE
1433 * commands.h (last_point_position, last_point_position_buffer):
1434 (last_point_position_window): Remove decls.
1435 * keyboard.c: Make these variables static.
1436
74ab6df5
PE
1437 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1438 decls.
1439 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1440 (iso_code_class, detect_coding, code_convert_region): Now static.
1441 (encode_coding_gap): Remove; unused.
1442
38dfbee1
PE
1443 * chartab.c (chartab_chars, chartab_bits): Now static.
1444
a2cb4e63
PE
1445 * charset.h (charset_iso_8859_1): Remove decl.
1446 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1447 Now static.
1448
127198fd
PE
1449 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1450 * ccl.c (Vccl_program_table): Now static.
1451 (check_ccl_update): Remove; unused.
1452
d85b608f
PE
1453 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1454 * category.h: ... from here.
1455 * category.c (check_category_table, set_category_set): Now static.
1456
31cd66f3
PE
1457 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1458 * lisp.h: Remove these decls.
1459
c358e587
PE
1460 * buffer.c (buffer_count): Remove unused var.
1461
e78aecca
PE
1462 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1463 so that it's not optimized away.
1464 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1465 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1466 exported only to the debugger.
1467
e192d7d3
PE
1468 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1469 * atimer.h (run_all_atimers): Removed; not exported.
1470
92470028
PE
1471 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1472 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1473 was inaccessible from Lisp.
1474 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1475 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1476
244ed907
PE
1477 alloc.c: Import and export fewer symbols, and remove unused items.
1478 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1479 is defined.
1480 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1481 it's not optimized away by whole-program optimization.
1482 (message_enable_multibyte, free_misc): Remove.
1483 (catchlist, handlerlist, mark_backtrace):
1484 Declare only if BYTE_MARK_STACK.
1485 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1486 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1487 (message_enable_multibyte): Remove decl.
1488 (free_misc, interval_free_list, float_block, float_block_index):
1489 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1490 (cons_free_list, last_marked_index):
1491 Now static.
1492 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1493 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1494 (mark_backtrace): Define only if BYTE_MARK_STACK.
1495 * xdisp.c (message_enable_multibyte): Now static.
1496
61c2b50e 1497 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1498 This makes it easier for human readers (and static analyzers)
1499 to see whether these variables are used from other modules.
1500 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1501 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1502 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1503 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1504 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1505 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1506 * xmenu.c, xselect.c:
1507 Declare Q* vars static if they are not used in other modules.
1508 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1509 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1510 Remove decls of unexported vars.
1511 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1512
95c82688
PE
1513 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1514
16a97296
PE
1515 Make Emacs functions such as Fatom 'static' by default.
1516 This makes it easier for human readers (and static analyzers)
1517 to see whether these functions can be called from other modules.
1518 DEFUN now defines a static function. To make the function external
1519 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1520 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1521 (Finit_image_library):
16a97296
PE
1522 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1523 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1524 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1525 Remove decls, since these functions are now static.
1526 (Funintern, Fget_internal_run_time): New decls, since these functions
1527 were already external.
95c82688 1528
16a97296
PE
1529 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1530 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1531 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1532 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1533 * keyboard.c, keymap.c, lread.c:
1534 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1535 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1536 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1537 Mark functions with DEFUE instead of DEFUN,
1538 if they are used in other modules.
1539 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1540 decls for now-static functions.
1541 * buffer.h (Fdelete_overlay): Remove decl.
1542 * callproc.c (Fgetenv_internal): Mark as internal.
1543 * composite.c (Fremove_list_of_text_properties): Remove decl.
1544 (Fcomposition_get_gstring): New forward static decl.
1545 * composite.h (Fcomposite_get_gstring): Remove decl.
1546 * dired.c (Ffile_attributes): New forward static decl.
1547 * doc.c (Fdocumntation_property): New forward static decl.
1548 * eval.c (Ffetch_bytecode): New forward static decl.
1549 (Funintern): Remove extern decl; now in .h file where it belongs.
1550 * fileio.c (Fmake_symbolic_link): New forward static decl.
1551 * image.c (Finit_image_library): New forward static decl.
1552 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1553 * intervals.h (Fprevious_property_change):
1554 (Fremove_list_of_text_properties): Remove decls.
1555 * keyboard.c (Fthis_command_keys): Remove decl.
1556 (Fcommand_execute): New forward static decl.
1557 * keymap.c (Flookup_key): New forward static decl.
1558 (Fcopy_keymap): Now static.
1559 * keymap.h (Flookup_key): Remove decl.
1560 * process.c (Fget_process): New forward static decl.
1561 (Fprocess_datagram_address): Mark as internal.
1562 * syntax.c (Fsyntax_table_p): New forward static decl.
1563 (skip_chars): Remove duplicate decl.
1564 * textprop.c (Fprevious_property_change): New forward static decl.
1565 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1566 Now internal.
1567 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1568 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1569
785bbd42
PE
1570 * editfns.c (Fformat): Remove unreachable code.
1571
8b913b57
AS
15722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1573
1574 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1575 change. (Bug#8496)
1576
a6744a35
EZ
15772011-04-13 Eli Zaretskii <eliz@gnu.org>
1578
1579 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1580 when at ZV. (Bug#8487)
1581
e7974947
AS
15822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1583
baad03f0
AS
1584 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1585 (Bug#8437)
1586 * keyboard.c (parse_tool_bar_item): Likewise.
1587 * sound.c (sound_cleanup, alsa_close): Likewise.
1588 * termcap.c (tgetent): Likewise.
1589 * xfns.c (x_default_font_parameter): Likewise.
1590 * xsettings.c (read_and_apply_settings): Likewise.
1591
e7974947
AS
1592 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1593 (overrun_check_free): Protoize.
1594
28272684
PE
15952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1596
1597 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1598 since callers should never pass a negative size.
1599 Change the signature to match that of plain 'read' and 'write'; see
1600 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1601 * lisp.h: Update prototypes of emacs_write and emacs_read.
1602
11997c76
EZ
16032011-04-11 Eli Zaretskii <eliz@gnu.org>
1604
1605 * xdisp.c (redisplay_window): Don't try to determine the character
1606 position of the scroll margin if the window start point w->startp
e896f03c 1607 is outside the buffer's accessible region. (Bug#8468)
11997c76 1608
8a2cbd72
EZ
16092011-04-10 Eli Zaretskii <eliz@gnu.org>
1610
1611 Fix write-region and its subroutines for buffers > 2GB.
1612 * fileio.c (a_write, e_write): Modify declaration of arguments and
1613 local variables to support buffers larger than 2GB.
1614 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1615
1616 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1617 argument, local variables, and return value.
1618
1619 * lisp.h: Update prototypes of emacs_write and emacs_read.
1620
1621 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1622
4073e537 16232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1624
1ebfdcb6
PE
1625 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1626
b2ded58d
PE
1627 Fix more problems found by GCC 4.6.0's static checks.
1628
7d66342c
PE
1629 * xdisp.c (vmessage): Use a better test for character truncation.
1630
bbf47d44
PE
1631 * charset.c (load_charset_map): <, not <=, for optimization,
1632 and to avoid potential problems with integer overflow.
9248994d 1633 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1634 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1635 * editfns.c (Fformat): Likewise.
1e69125e 1636 * syntax.c (skip_chars): Likewise.
3befa583 1637
e3019616
PE
1638 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1639 This also lets GCC 4.6.0 generate slightly better loop code.
1640
becfa255
PE
1641 * callint.c (Fcall_interactively): <, not <=, for optimization.
1642 (Fcall_interactively): Count the number of arguments produced,
1643 not the number of arguments given. This is simpler and lets GCC
1644 4.6.0 generate slightly better code.
1645
dae0cd48
PE
1646 * ftfont.c: Distingish more carefully between FcChar8 and char.
1647 The previous code passed unsigned char * to a functions like
1648 strlen and xstrcasecmp that expect char *, which does not
1649 conform to the C standard.
1650 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1651 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1652 char * when the C standard requires it.
1653
76032d70
PE
1654 * keyboard.c (read_char): Remove unused var.
1655
eb3f1cc8
PE
1656 * eval.c: Port to Windows vsnprintf (Bug#8435).
1657 Include <limits.h>.
1658 (SIZE_MAX): Define if the headers do not.
1659 (verror): Do not give up if vsnprintf returns a negative count.
1660 Instead, grow the buffer. This ports to Windows vsnprintf, which
1661 does not conform to C99. Problem reported by Eli Zaretskii.
1662 Also, simplify the allocation scheme, by avoiding the need for
1663 calling realloc, and removing the ALLOCATED variable.
1664
70476b54
PE
1665 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1666
12020a9e
PE
1667 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1668 But keep the doprint source code for now, as we might revamp it
1669 and use it again (Bug#8435).
ea6c7ae6
PE
1670 * lisp.h (doprnt): Remove.
1671 * Makefile.in (base_obj): Remove doprnt.o.
1672 * deps.mk (doprnt.o): Remove.
1673
5fdb398c
PE
1674 error: Print 32- and 64-bit integers portably (Bug#8435).
1675 Without this change, on typical 64-bit hosts error ("...%d...", N)
1676 was used to print both 32- and 64-bit integers N, which relied on
1677 undefined behavior.
1678 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1679 New macro.
1680 * lisp.h (error, verror): Mark as printf-like functions.
1681 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1682 Report overflow in size calculations when allocating printf buffer.
1683 Do not truncate output string at its first null byte.
1684 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1685 Truncate the output at a character boundary, since vsnprintf does not
1686 do that.
1687 * charset.c (check_iso_charset_parameter): Convert internal
1688 character to string before calling 'error', since %c now has the
1689 printf meaning.
1690 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1691 overflow when computing char to be passed to 'error'. Do not
1692 pass Lisp_Object to 'error'; pass the integer instead.
1693 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1694 formatted with plain %d.
1695
b189fa66
PE
1696 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1697
bff87ef0
PE
1698 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1699
7e2cac20
PE
1700 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1701
ce4d90b5
PE
1702 * xterm.c (x_catch_errors): Remove duplicate declaration.
1703
266c9547
PE
1704 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1705
79c49ad2
PE
1706 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1707
368f4090
JM
17082011-04-10 Jim Meyering <meyering@redhat.com>
1709
1710 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1711 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1712 return ssize_t not "int", and use size_t as the buffer length.
1713 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1714 * gnutls.h: Update declarations.
1715 * process.c (read_process_output): Use ssize_t, to match.
1716 (send_process): Likewise.
1717
a32d4040
CY
17182011-04-09 Chong Yidong <cyd@stupidchicken.com>
1719
1720 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1721
8546720e 17222011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1723
8546720e
GM
1724 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1725 unsigned char, to match FcChar8 type definition.
aac0c6e3 1726
8546720e
GM
1727 * xterm.c (handle_one_xevent):
1728 * xmenu.c (create_and_show_popup_menu):
1729 * xselect.c (x_decline_selection_request)
1730 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1731
0a2f5c1a 17322011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1733
1734 Fix some uses of `int' instead of EMACS_INT.
1735 * search.c (string_match_1, fast_string_match)
1736 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1737 (scan_buffer, find_next_newline_no_quit)
1738 (find_before_next_newline, search_command, Freplace_match)
1739 (Fmatch_data): Make some `int' variables be EMACS_INT.
1740
1741 * xdisp.c (display_count_lines): 3rd argument and return value now
1742 EMACS_INT. All callers changed.
1743 (pint2hrstr): Last argument is now EMACS_INT.
1744
1745 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1746 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1747 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1748 (decode_coding_utf_16, decode_coding_emacs_mule)
1749 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1750 (decode_coding_ccl, decode_coding_charset)
1751 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1752 (decode_coding_iso_2022, decode_coding_emacs_mule)
1753 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1754 <char_offset, last_offset>: Declare EMACS_INT.
1755 (encode_coding_utf_8, encode_coding_utf_16)
1756 (encode_coding_emacs_mule, encode_invocation_designation)
1757 (encode_designation_at_bol, encode_coding_iso_2022)
1758 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1759 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1760 Declare EMACS_INT.
1761 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1762 (encode_invocation_designation): Last argument P_NCHARS is now
1763 EMACS_INT.
1764 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1765 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1766
1767 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1768 All users changed.
1769
1770 * ccl.c (Fccl_execute_on_string): Declare some variables
1771 EMACS_INT.
1772
8546720e 17732011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1774
1775 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1776
4e19a977
CS
17772011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1778
1779 * process.c (Fformat_network_address): Doc fix.
1780
87302331
R
17812011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1782
1783 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1784
cbb59342
CY
17852011-04-08 Chong Yidong <cyd@stupidchicken.com>
1786
1787 * keyboard.c (read_char): Call Lisp function help-form-show,
1788 instead of using internal_with_output_to_temp_buffer.
1789 (Qhelp_form_show): New var.
e0d38eeb 1790 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1791
1792 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1793
1794 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1795
e67a13ab
CY
17962011-04-06 Chong Yidong <cyd@stupidchicken.com>
1797
1798 * process.c (Flist_processes): Removed to Lisp.
1799 (list_processes_1): Deleted.
1800
973f782d
EZ
18012011-04-06 Eli Zaretskii <eliz@gnu.org>
1802
7c106b1e
EZ
1803 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1804
973f782d
EZ
1805 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1806
41cf7d1a 18072011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1808
ca23cc88
PE
1809 Fix more problems found by GCC 4.6.0's static checks.
1810
f390e2d5
PE
1811 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1812
42eea0d0
PE
1813 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1814
b69769da 1815 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1816
f9541e84
PE
1817 * xdisp.c (vmessage): Mark as a printf-like function.
1818
13841b55
PE
1819 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1820
c136c10f
PE
1821 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1822
5e2d4a30
PE
1823 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1824 printf-like functions.
1825 (tiff_load): Add casts to remove these marks before passing them
1826 to system-supplied API.
1827
583f48b9
PE
1828 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1829
b25d760e
PE
1830 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1831 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1832 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1833 directly, rather than having caller test rule sign. This avoids
1834 some unnecessary tests.
1835 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1836 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1837 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1838
bc7b6697 1839 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1840 (xfont_open): Avoid unnecessary tests.
bc7b6697 1841
27ccc379
PE
1842 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1843
dcd5c89a
PE
1844 * composite.h, composite.c (composition_gstring_put_cache):
1845 Use EMACS_INT, not int, for length.
1846
b13a45c6
PE
1847 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1848 breaking out part of COMPOSITION_DECODE_RULE.
1849 (COMPOSITION_DECODE_RULE): Use it.
1850 * composite.c (get_composition_id): Remove unused local vars,
1851 by using the new macro.
1852
1e792e4d
PE
1853 * textprop.c (set_text_properties_1): Change while to do-while,
1854 since the condition is always true at first.
1855
dc6c6455 1856 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1857 (interval_deletion_adjustment): Return unsigned value.
1858 All uses changed.
dc6c6455 1859
aba7731a
PE
1860 * process.c (list_processes_1, create_pty, read_process_output):
1861 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1862 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1863 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1864 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1865 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1866
fdfc4bf3
PE
1867 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1868
fca8fe46 1869 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1870 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1871
06a0259a 1872 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1873 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1874 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1875
e7b9e80f
PE
1876 * print.c (print_error_message): Avoid int overflow.
1877
56201685
PE
1878 * font.c (font_list_entities): Redo for clarity,
1879 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1880
78834453 1881 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1882 (font_score): Avoid potential overflow in diff calculation.
78834453 1883
0bc0b309 1884 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1885 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1886
e610eaca
PE
1887 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1888
b895abce
PE
1889 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1890 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1891 can always succeed if overflow has undefined behavior.
1892
1f1d9321 1893 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1894 (wordify): Omit three unnecessary tests.
1f1d9321 1895
c59478bc
PE
1896 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1897 All callers changed. This avoids the need for an unused var.
1898
79b73827
PE
1899 * casefiddle.c (casify_region): Remove var that is set but not used.
1900
a4db5dfe
PE
1901 * dired.c (file_name_completion): Remove var that is set but not used.
1902
43aae36e
PE
1903 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1904
2a47c44d 1905 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1906 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1907
a37c69bf
PE
1908 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1909 Check for integer overflow on size calculations.
1910
328ab8e7
PE
1911 * buffer.c (Fprevious_overlay_change): Remove var that is set
1912 but not used.
1913
e5a2a5cb
PE
1914 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1915 Remove vars that are set but not used.
8d84a6eb 1916 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1917 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1918
a60e5f68
PE
1919 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1920
f661cb61 1921 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1922 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1923
f0397f5a
PE
1924 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1925 that are set but not used.
1926
8664db06 1927 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1928 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1929
6abdaa4a
PE
1930 * xselect.c (x_get_local_selection, x_handle_property_notify):
1931 Remove vars that are set but not used.
1932
0ce7538d 1933 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1934 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1935
9ae848fc
PE
1936 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1937 Remove var that is set but not used.
0b918413
PE
1938 (scroll_bar_windows_size): Now size_t, not int.
1939 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1940 Check for overflow.
9ae848fc 1941
a5a62657
PE
1942 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1943 (map_tty_color) [!defined MSDOS]: Likewise.
1944
5c5cdd39
PE
1945 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1946
66ebf983
PE
1947 * coding.c: Remove vars that are set but not used.
1948 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1949 All callers changed.
1950 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1951 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1952 (decode_coding_charset): Remove vars that are set but not used.
1953
1be4d761
PE
1954 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1955 that is set but not used.
1956
47553fa8
PE
1957 * print.c (print_object): Remove var that is set but not used.
1958
1f7196bf 1959 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1960 The gnulib version avoids calling malloc in the usual case,
1961 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1962 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1963 * filelock.c (current_lock_owner): Likewise.
1964 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1965 * sysdep.c: Include allocator.h, careadlinkat.h.
1966 (emacs_no_realloc_allocator): New static constant.
1967 (emacs_readlink): New function.
fdb61804
PE
1968 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1969 ../lib/careadlinkat.h.
d1fdcab7 1970
f84c17c7
SM
19712011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1972
1973 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1974 first non-nil return value).
1975
ef3862ad
JD
19762011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1977
1978 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1979 if not defined (Bug#8403).
1980
376a7006
JB
19812011-04-02 Juanma Barranquero <lekktu@gmail.com>
1982
1983 * xdisp.c (display_count_lines): Remove parameter `start',
1984 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1985 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1986 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1987 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1988 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1989 and thereabouts. All callers changed.
1990 (get_per_char_metric): Remove parameter `f', unused since
1991 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1992
6ca3801d
JM
19932011-04-02 Jim Meyering <meyering@redhat.com>
1994
1995 do not dereference NULL upon failed strdup
1996 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1997 (ns_get_family): Likewise.
1998
d8e2b5ba
JB
19992011-04-02 Juanma Barranquero <lekktu@gmail.com>
2000
2001 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2002
8c74fcbd
JD
20032011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2004
2005 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2006 later (Bug#8403).
2007
7200d79c
SM
20082011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2009
03408648 2010 Add lexical binding.
7200d79c 2011
03408648
SM
2012 * window.c (Ftemp_output_buffer_show): New fun.
2013 (Fsave_window_excursion):
2014 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2015
2016 * lread.c (lisp_file_lexically_bound_p): New function.
2017 (Fload): Bind Qlexical_binding.
2018 (readevalloop): Remove `evalfun' arg.
2019 Bind Qinternal_interpreter_environment.
2020 (Feval_buffer): Bind Qlexical_binding.
2021 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2022 Mark as dynamic.
2023 (syms_of_lread): Declare `lexical-binding'.
2024
2025 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2026
2027 * keyboard.c (eval_dyn): New fun.
2028 (menu_item_eval_property): Use it.
ca105506
SM
2029
2030 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2031
03408648
SM
2032 * fns.c (concat, mapcar1): Accept byte-code-functions.
2033
2034 * eval.c (Fsetq): Handle lexical vars.
2035 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2036 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2037 (FletX, Flet): Obey lexical binding.
2038 (Fcommandp): Handle closures.
2039 (Feval): New `lexical' arg.
2040 (eval_sub): New function extracted from Feval. Use it almost
2041 everywhere where Feval was used. Look up vars in lexical env.
2042 Handle closures.
2043 (Ffunctionp): Move from subr.el.
2044 (Ffuncall): Handle closures.
2045 (apply_lambda): Remove `eval_flags'.
2046 (funcall_lambda): Handle closures and new byte-code-functions.
2047 (Fspecial_variable_p): New function.
2048 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2049 but without exporting it to Lisp.
23aba0ea 2050
23aba0ea 2051 * doc.c (Fdocumentation, store_function_docstring):
03408648 2052 * data.c (Finteractive_form): Handle closures.
23aba0ea 2053
03408648
SM
2054 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2055 interactive spec.
ba83908c 2056
03408648
SM
2057 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2058 byte-codes.
2059 (exec_byte_code): New function extracted from Fbyte_code to handle new
2060 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2061
03408648 2062 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2063
03408648 2064 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2065
e2abce01
JB
20662011-03-31 Juanma Barranquero <lekktu@gmail.com>
2067
2068 * xdisp.c (redisplay_internal): Fix prototype.
2069
63696a73 20702011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2071
63696a73
EZ
2072 * xdisp.c (SCROLL_LIMIT): New macro.
2073 (try_scrolling): Use it when setting scroll_limit. Limit
2074 scrolling to 100 screen lines.
2075 (redisplay_window): Even when falling back on "recentering",
2076 position point in the window according to scroll-conservatively,
2077 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2078
2079 (try_scrolling): When point is above the window, allow searching
2080 as far as scroll_max, or one screenful, to compute vertical
2081 distance from PT to the scroll margin position. This prevents
2082 try_scrolling from unnecessarily failing when
2083 scroll-conservatively is set to a value slightly larger than the
2084 window height. Clean up the case of PT below the margin at bottom
2085 of window: scroll_max can no longer be INT_MAX. When aggressive
2086 scrolling is in use, don't let point enter the opposite scroll
2087 margin as result of the scroll.
2088 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2089 threshold of 100 lines for never-recentering scrolling.
2090
e4cc2dfc
JB
20912011-03-31 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * dispextern.h (move_it_by_lines):
2094 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2095 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2096 (message_log_check_duplicate): Remove parameters `prev_bol' and
2097 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2098 (redisplay_internal): Remove parameter `preserve_echo_area',
2099 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2100
2101 * indent.c (Fvertical_motion):
2102 * window.c (window_scroll_pixel_based, Frecenter):
2103 Don't pass `need_y_p' to `move_it_by_lines'.
2104
1c470562
SM
21052011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2106
44f230aa
SM
2107 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2108 steal a few bits to be more compact.
2109 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2110 Remove unneeded casts.
2111
1c470562
SM
2112 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2113
888adce9
ZK
21142011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2115
2116 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2117 binding" message (bug#7967).
2118
f838ed7b
PE
21192011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2120
77861b95
PE
2121 Fix more problems found by GCC 4.6.0's static checks.
2122
de6dbc14
PE
2123 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2124 Remove unused local var.
2125
f838ed7b
PE
2126 * editfns.c (Fmessage_box): Remove unused local var.
2127
792c7b2b
PE
2128 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2129 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2130 Omit unused local vars.
c499e557 2131 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2132 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2133 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2134 Omit unused local var.
2135
ba0165e1
PE
2136 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2137 Don't assume string length fits in int.
32ad8845 2138 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2139 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2140
3c59b4c9
PE
2141 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2142 instead of alloca (Bug#8344).
2143
a3eed478 2144 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2145 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2146
eb4d412d
PE
2147 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2148
1658b401
PE
2149 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2150 concerns.
2151
2152 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2153
2154 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2155
9a2c6e05
PE
2156 * keyboard.c (syms_of_keyboard): Use the same style as later
2157 in this function when indexing through an array. This also
2158 works around GCC bug 48267.
2159
03d0a109
PE
2160 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2161
44f730c8
PE
2162 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2163
fe75f926
PE
2164 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2165 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2166
ffa8c828
PE
2167 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2168 This avoids undefined behavior on integer overflow, and is a bit
2169 more convenient anyway since it is compared to a size_t variable.
2170
c5101a77
PE
2171 Variadic C functions now count arguments with size_t, not int.
2172 This avoids an unnecessary limitation on 64-bit machines, which
2173 caused (substring ...) to crash on large vectors (Bug#8344).
2174 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2175 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2176 All variadic functions and their callers changed accordingly.
c5101a77
PE
2177 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2178 * data.c (arith_driver, float_arith_driver): Likewise.
2179 * editfns.c (general_insert_function): Likewise.
2180 * eval.c (struct backtrace.nargs, interactive_p)
2181 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2182 (funcall_lambda, mark_backtrace): Likewise.
2183 * fns.c (concat): Likewise.
2184 * frame.c (x_set_frame_parameters): Likewise.
2185 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2186 0 if not found, not -1. All callers changed.
2187
dd3f25f7
PE
2188 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2189 (stack_copy_size): Now size_t, not int.
2190 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2191
461c2ab9
JB
21922011-03-28 Juanma Barranquero <lekktu@gmail.com>
2193
2194 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2195 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2196 All callers changed.
2197
2198 * lisp.h (multibyte_char_to_unibyte):
2199 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2200 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2201 * character.h (CHAR_TO_BYTE8):
2202 * cmds.c (internal_self_insert):
2203 * editfns.c (general_insert_function):
2204 * keymap.c (push_key_description):
2205 * search.c (Freplace_match):
2206 * xdisp.c (message_dolog, set_message_1): All callers changed.
2207
f6d62986
SM
22082011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2209
2210 * keyboard.c (safe_run_hook_funcall): New function.
2211 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2212 don't set the hook to nil, but remove the offending function instead.
2213 (Qcommand_hook_internal): Remove, unused.
2214 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2215 Vcommand_hook_internal.
2216
2217 * eval.c (enum run_hooks_condition): Remove.
2218 (funcall_nil, funcall_not): New functions.
2219 (run_hook_with_args): Call each function through a `funcall' argument.
2220 Remove `cond' argument, now redundant.
2221 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2222 (Frun_hook_with_args_until_failure): Adjust accordingly.
2223 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2224
1db5b1ad
JB
22252011-03-28 Juanma Barranquero <lekktu@gmail.com>
2226
2227 * dispextern.h (string_buffer_position): Remove declaration.
2228
2229 * print.c (strout): Remove parameter `multibyte', unused since
2230 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2231
2232 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2233 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2234 All callers changed.
2235
2236 * w32.c (_wsa_errlist): Use braces for struct initializers.
2237
2238 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2239 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2240 All callers changed.
2241 (string_buffer_position): Likewise. Also, make static (it's never
2242 used outside xdisp.c).
2243 (cursor_row_p): Remove parameter `w', unused since
2244 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2245 (decode_mode_spec): Remove parameter `precision', introduced during
2246 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2247 All callers changed.
2248
5ffb62aa
JD
22492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2250
2251 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2252
461c2ab9 22532011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2254
2255 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2256 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2257 (ns_update_auto_hide_menu_bar): New functions.
2258 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2259 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2260 ns_constrain_all_frames.
2261 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2262 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2263
5c380ffb
JD
22642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2265
2266 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2267
9af30bdf
GM
22682011-03-27 Glenn Morris <rgm@gnu.org>
2269
2270 * syssignal.h: Replace RETSIGTYPE with void.
2271 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2272 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2273 Replace SIGTYPE with void everywhere.
2274 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2275 * s/template.h (SIGTYPE): Remove commented out definition.
2276
e2abce01
JB
22772011-03-26 Eli Zaretskii <eliz@gnu.org>
2278
2279 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2280 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2281
f868cd8a
JB
22822011-03-26 Juanma Barranquero <lekktu@gmail.com>
2283
59eb0929
JB
2284 * w32.c (read_unc_volume): Use parameter `henum', instead of
2285 global variable `wget_enum_handle'.
2286
2287 * keymap.c (describe_vector): Remove parameters `indices' and
2288 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2289 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2290
f868cd8a
JB
2291 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2292
2293 * keyboard.c (timer_check): Remove parameter `do_it_now',
2294 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2295 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2296 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2297
2298 * keyboard.c (read_char):
2299 * w32menu.c (w32_menu_display_help):
2300 * xmenu.c (show_help_event, menu_help_callback):
2301 Adjust calls to `show_help_echo'.
2302
2303 * gtkutil.c (xg_maybe_add_timer):
2304 * keyboard.c (readable_events):
2305 * process.c (wait_reading_process_output):
2306 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2307
2308 * insdel.c (adjust_markers_gap_motion):
2309 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2310 (gap_left, gap_right): Don't call it.
2311
2ecf6fdb
CY
23122011-03-25 Chong Yidong <cyd@stupidchicken.com>
2313
2314 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2315 incurred during fontification.
2316
6b1f9ba4
JB
23172011-03-25 Juanma Barranquero <lekktu@gmail.com>
2318
2319 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2320 (DEFVAR_PER_BUFFER): Don't pass it.
2321
2322 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2323 (scrolling_window): Don't pass it.
2324
0f4a96b5
JB
23252011-03-25 Juanma Barranquero <lekktu@gmail.com>
2326
2327 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2328
2329 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2330 and `suffix'.
2331 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2332 of variables specific to SELinux and computation of `encoded_absname'.
2333
2334 * image.c (XPutPixel): Remove unused variable `height'.
2335
2336 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2337
2338 * unexw32.c (get_section_info): Remove unused variable `section'.
2339
2340 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2341 (system_process_attributes): Remove unused variable `sess'.
2342 (sys_read): Remove unused variable `err'.
2343
2344 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2345 (w32_wnd_proc): Remove unused variable `isdead'.
2346 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2347 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2348 (x_create_tip_frame): Remove unused variable `tem'.
2349
2350 * w32inevt.c (w32_console_read_socket):
2351 Remove unused variable `no_events'.
2352
2353 * w32term.c (x_draw_composite_glyph_string_foreground):
2354 Remove unused variable `width'.
2355
1149507c
JB
23562011-03-24 Juanma Barranquero <lekktu@gmail.com>
2357
2358 * w32term.c (x_set_glyph_string_clipping):
2359 Don't pass uninitialized region to CombineRgn.
2360
9c88f339
JB
23612011-03-23 Juanma Barranquero <lekktu@gmail.com>
2362
2363 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2364 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2365 (Fx_close_connection): Remove unused variable `i'.
2366
2367 * w32font.c (w32font_draw): Return number of glyphs.
2368 (w32font_open_internal): Remove unused variable `i'.
2369 (w32font_driver): Add missing initializer.
2370
2371 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2372 (fill_in_menu): Remove unused variable `items_added'.
2373
2374 * w32term.c (last_mouse_press_frame): Remove static global variable.
2375 (w32_clip_to_row): Remove unused variable `f'.
2376 (x_delete_terminal): Remove unused variable `i'.
2377
2378 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2379 (NOTHING): Remove unused static global variable.
2380 (uniscribe_check_otf): Remove unused variable `table'.
2381 (uniscribe_font_driver): Add missing initializers.
2382
dee091a3
JD
23832011-03-23 Julien Danjou <julien@danjou.info>
2384
2385 * term.c (Fsuspend_tty, Fresume_tty):
2386 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2387 * window.c (temp_output_buffer_show):
2388 * insdel.c (signal_before_change):
2389 * frame.c (Fhandle_switch_frame):
2390 * fileio.c (Fdo_auto_save):
2391 * emacs.c (Fkill_emacs):
2392 * editfns.c (save_excursion_restore):
2393 * cmds.c (internal_self_insert):
2394 * callint.c (Fcall_interactively):
2395 * buffer.c (Fkill_all_local_variables):
2396 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2397 Use Frun_hooks.
0f4a96b5 2398 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2399 unconditionnaly since it does the check itself.
2400
2c520ab5 24012011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2402
c9c49752
PE
2403 Fix more problems found by GCC 4.5.2's static checks.
2404
8abc3f12
PE
2405 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2406 the first time through the loop, since we know p0 < p1 then.
2407 This also avoids a gcc -Wstrict-overflow warning.
2408
a2d26660
PE
2409 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2410 leading to a memory leak, possible in functions like
2411 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2412 of objects (Bug#8318).
a2d26660 2413
916c72e9
PE
2414 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2415 that could (at least in theory) be that large.
2416
19ab8a18
PE
2417 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2418 This is less likely to overflow, and avoids undefined behavior if
2419 overflow does occur. All callers changed. Use strtoul to scan
2420 for the unsigned long integer.
b7cbbd6f
PE
2421 (pint2hrstr): Simplify and tune code slightly.
2422 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2423
f0641eff
PE
2424 * scroll.c (do_scrolling): Work around GCC bug 48228.
2425 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2426
7f650bb9
PE
2427 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2428 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2429 (validate_x_resource_name): Simplify count usage.
2430 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2431
37dd57d1
PE
2432 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2433 fail (Bug#8306).
81e56e61 2434
699979fc 2435 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2436
401bf9b4
PE
2437 * process.c (Fmake_network_process): Use socklen_t, not int,
2438 where POSIX says socklen_t is required in portable programs.
2439 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2440 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2441 (Fmake_network_process, server_accept_connection):
2442 (wait_reading_process_output, read_process_output):
2443 Likewise.
2444
b93aacde
PE
2445 * process.c: Rename or move locals to avoid shadowing.
2446 (list_processes_1, Fmake_network_process):
2447 (read_process_output_error_handler, exec_sentinel_error_handler):
2448 Rename or move locals.
4dc343ee 2449 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2450 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2451 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2452 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2453 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2454
af8a867c 2455 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2456 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2457 Include tparam.h instead, since it declares them.
af8a867c
PE
2458 * cm.h (PC): Remove extern decl; tparam.h now does this.
2459 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2460 * terminfo.c: Include tparam.h, to check interfaces.
2461 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2462 (tparam): Adjust signature to match interface in tparam.h;
2463 this removes some undefined behavior. Check that outstring and len
2464 are zero, which they always are with Emacs.
2465 * tparam.h (PC, BC, UP): New extern decls.
2466
0248044d 2467 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2468 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2469
8ff096c1 2470 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2471 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2472 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2473 (ftfont_list): Remove unused local.
49eaafba
PE
2474 (get_adstyle_property, ftfont_pattern_entity):
2475 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2476 Rename locals to avoid shadowing.
8ff096c1 2477
e2be39f6
PE
2478 * xfont.c (xfont_list_family): Mark var as initialized.
2479
c9735e30
PE
2480 * xml.c (make_dom): Now static.
2481
8f5201ae
PE
2482 * composite.c (composition_compute_stop_pos): Rename local to
2483 avoid shadowing.
b246f932
PE
2484 (composition_reseat_it): Remove unused locals.
2485 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2486 (composition_update_it): Mark var as initialized.
11b61122
PE
2487 (find_automatic_composition): Mark vars as initialized,
2488 with a FIXME (Bug#8290).
8f5201ae 2489
760fbc2c
PE
2490 character.h: Rename locals to avoid shadowing.
2491 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2492 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2493 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2494 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2495 to avoid shadowing.
2496
ff08eb85
PE
2497 * textprop.c (property_change_between_p): Remove; unused.
2498
fc7bf025
PE
2499 * intervals.c (interval_start_pos): Now static.
2500
235d7abc
PE
2501 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2502
44f230aa
SM
2503 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2504 Rename locals to avoid shadowing.
3e7d6594 2505
50060332
PE
2506 * sound.c (wav_play, au_play, Fplay_sound_internal):
2507 Fix pointer signedness.
d01f234b 2508 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2509 (wav_play): Initialize a variable to 0, to prevent undefined
2510 behavior (Bug#8278).
50060332 2511
c4fc4e30
PE
2512 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2513
918436ed
PE
2514 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2515
c939f91b
PE
2516 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2517 clobbering (Bug#8298).
b9c7f648
PE
2518 * sysdep.c (sys_subshell): Likewise.
2519 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2520
6bd8c144
PE
2521 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2522 This should get cleaned up, so that child_setup has the
2523 same signature on all platforms.
2524
7710357c 2525 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2526 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2527
c59da222
CY
25282011-03-22 Chong Yidong <cyd@stupidchicken.com>
2529
2530 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2531 not to be necessary, and produces flickering.
2532
66b87493
GM
25332011-03-20 Glenn Morris <rgm@gnu.org>
2534
2535 * config.in: Remove file.
2536
45b6f6d5
JB
25372011-03-20 Juanma Barranquero <lekktu@gmail.com>
2538
2539 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2540 are now in src/globals.h.
2541 (syms_of_minibuf): Remove spurious & from previous change.
2542
3ec03f7e
LL
25432011-03-20 Leo <sdl.web@gmail.com>
2544
2545 * minibuf.c (completing-read-function): New variable.
2546 (completing-read-default): Rename from completing-read.
2547 (completing-read): Call completing-read-function.
2548
b14e3e21
CY
25492011-03-19 Juanma Barranquero <lekktu@gmail.com>
2550
2551 * xfaces.c (Fx_load_color_file):
2552 Read color file from absolute filename (bug#8250).
2553
f2b726e6
JB
25542011-03-19 Juanma Barranquero <lekktu@gmail.com>
2555
2556 * makefile.w32-in: Update dependencies.
2557
09f6ff02
EZ
25582011-03-17 Eli Zaretskii <eliz@gnu.org>
2559
2560 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2561
29a6015a
PE
25622011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2563
a3a6c54e
PE
2564 Fix more problems found by GCC 4.5.2's static checks.
2565
b766f867
PE
2566 * process.c (make_serial_process_unwind, send_process_trap):
2567 (sigchld_handler): Now static.
2568
be02381c
PE
2569 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2570 That way, the code declares only the vars that it needs.
2571 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2572 * s/cygwin.h (PTY_ITERATION): Likewise.
2573 * s/darwin.h (PTY_ITERATION): Likewise.
2574 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2575
57048744
PE
2576 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2577 * process.c (allocate_pty): Don't declare stb unless it's needed.
2578
7914961c 2579 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2580 (CONSTANTLIM): Remove; unused.
2581 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2582 Define only if needed.
7914961c 2583
b3967b18
PE
2584 * unexelf.c (unexec): Name an expression,
2585 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2586 Use a different way to cause a compilation error if anyone uses
2587 n rather than nn, a way that does not involve shadowing.
73366a00 2588 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2589
29a6015a
PE
2590 * deps.mk (unexalpha.o): Remove; unused.
2591
43cfc33e 2592 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2593 * unexec.h: New file.
ce701a33
PE
2594 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2595 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2596 Depend on unexec.h.
2597 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2598 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2599 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2600 Change as necessary to match prototype in unexec.h.
ce701a33 2601
01f44d5a
PE
2602 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2603 shadowing.
4f63c6bb 2604 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2605
a6670b0b
PE
2606 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2607 Rename locals to avoid shadowing.
2608
cef2010d 2609 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2610 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2611
d4d7173a
PE
2612 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2613
f08b802a
PE
2614 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2615 warning when compiling print.c.
2616
3ddb0639
PE
2617 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2618 instead of using an uninitialized var.
5ad03b97 2619 (font_sort_entities): Mark var as initialized.
3ddb0639 2620
170a2692
PE
2621 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2622
e663c700
PE
2623 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2624 pointers to constants.
89bc529a 2625 (font_parse_fcname): Remove unused vars.
7b81e2d0 2626 (font_delete_unmatched): Now static.
ea838e10 2627 (font_get_spec): Remove; unused.
13a547c6
PE
2628 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2629 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2630 Rename or move locals to avoid shadowing.
e663c700 2631
2a80c887 2632 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2633 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2634
1384fa33 2635 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2636 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2637
8b2c52e9
PE
2638 * alloc.c (mark_backtrace): Move decl from here ...
2639 * lisp.h: ... to here, so that it can be checked.
2640
475545b5 2641 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2642 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2643 (lisp_indirect_variable): Name an expression,
2644 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2645 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2646
b1349114 2647 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2648 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2649 Use const pointer when appropriate.
b1349114 2650
a2928364
PE
2651 * lisp.h (get_system_name, get_operating_system_release):
2652 Move decls here, to check interfaces.
2653 * process.c (get_operating_system_release): Move decl to lisp.h.
2654 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2655 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2656 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2657 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2658 (Fformat_time_string, Fencode_time, Finsert_char):
2659 (Ftranslate_region_internal, Fformat):
2660 Rename or remove local vars to avoid shadowing.
9710023e 2661 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2662
a415e694
PE
2663 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2664 avoid shadowing.
2665
8ef4622d
PE
2666 * lisp.h (eassert): Check that the argument compiles, even if
2667 ENABLE_CHECKING is not defined.
2668
946f9a5b
PE
2669 * data.c (Findirect_variable): Name an expression, to avoid
2670 gcc -Wbad-function-cast warning.
112396d6 2671 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2672 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2673 (Fmake_variable_buffer_local, Fmake_local_variable):
2674 Mark variables as initialized.
52746918 2675 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2676
e5aab7e7 2677 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2678 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2679 Rename locals to avoid shadowing.
dff45157
PE
2680 (mark_stack): Move local variables into the #ifdef region where
2681 they're used.
7bc26fdb
PE
2682 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2683 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2684 needed otherwise.
2685 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2686 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2687 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2688
e5aab7e7
PE
2689 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2690 avoids undefined behavior in theory.
2691
4da60324
PE
2692 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2693
88043301
PE
2694 Use functions, not macros, for up- and down-casing (Bug#8254).
2695 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2696 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2697 to use the following functions instead of these macros.
2698 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2699 EMACS_INT, since callers assume the returned value fits in int.
2700 (upcase1): Likewise, for UPCASE_TABLE.
2701 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2702 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2703 the race-condition problem in the old DOWNCASE.
88043301 2704
19ed5445
PE
2705 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2706 Rename locals to avoid shadowing.
2707 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2708 (regex_compile, re_search_2, re_match_2_internal):
2709 Remove unused local vars.
952db0d7
PE
2710 (FREE_VAR): Rewrite so as not to use empty "else",
2711 which gcc can warn about.
da053e48 2712 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2713 (RETALLOC_IF): Define only if needed.
2714 (WORDCHAR_P): Likewise. This one is never needed, but is used
2715 only in a comment talking about a compiler bug, so put inside
2716 the #if 0 of that comment.
2717 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2718 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2719 Remove; unused.
19ed5445 2720
1f3561e4 2721 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2722 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2723 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2724
ded6f8f7
PE
2725 * search.c (simple_search): Remove unused var.
2726
dbd37a95
PE
2727 * dired.c (compile_pattern): Move decl from here ...
2728 * lisp.h: ... to here, so that it can be checked.
2729 (struct re_registers): New forward decl.
2730
7e47afad
PE
2731 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2732
85f24f61
PE
2733 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2734 All uses changed.
2735 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2736 Rename locals to avoid shadowing.
5671df8f 2737 (Fvertical_motion): Mark locals as initialized.
85f24f61 2738
181aa2be 2739 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2740 (casify_region): Mark local as initialized.
181aa2be 2741
930d429c
PE
2742 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2743
7082eac6
PE
2744 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2745 New macros, so that the caller can use some names other than
2746 gcpro1, gcpro2, etc.
2747 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2748 of the new macros.
2749 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2750 argument, for consistency with GCPRO2_VAR, etc: it is now the
2751 prefix of the variable, not the variable itself. All uses
2752 changed.
38b2c076
PE
2753 * dired.c (directory_files_internal, file_name_completion):
2754 Rename locals to avoid shadowing.
2755
15206ed9
PE
2756 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2757 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2758 dired.c's scmp function, had undefined behavior.
2759 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2760 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2761 * buffer.h: ... to here, because these macros use current_buffer,
2762 and the new implementation with inline functions needs to have
2763 current_buffer in scope now, rather than later when the macros
2764 are used.
2765 (downcase, upcase1): New static inline functions.
2766 (DOWNCASE, UPCASE1): Reimplement using these functions.
2767 This avoids undefined behavior in expressions like
2768 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2769 from race conditions in accessing the global variables
2770 case_temp1 and case_temp2.
2771 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2772 * lisp.h (case_temp1, case_temp2): Remove their decls.
2773 * character.h (ASCII_CHAR_P): Move from here ...
2774 * lisp.h: ... to here, so that the inline functions mentioned
2775 above can use them.
2776
4a6bea26
PE
2777 * dired.c (directory_files_internal_unwind): Now static.
2778
f14b7e14
PE
2779 * fileio.c (file_name_as_directory, directory_file_name):
2780 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2781 Now static.
2893f146
PE
2782 (file_name_as_directory): Use const pointers when appropriate.
2783 (Fexpand_file_name): Likewise. In particular, newdir might
2784 point at constant storage, so make it a const pointer.
fd4ead52 2785 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2786 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2787 signedness issues.
f839df0c
PE
2788 (Fset_file_times, Finsert_file_contents, auto_save_error):
2789 Rename locals to avoid shadowing.
f14b7e14 2790
5716756e 2791 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2792 (Ftry_completion, Fall_completions): Rename or remove locals
2793 to avoid shadowing.
5716756e 2794
b4c3046a
PE
2795 * marker.c (bytepos_to_charpos): Remove; unused.
2796
b45db522
PE
2797 * lisp.h (verify_bytepos, count_markers): New decls,
2798 so that gcc does not warn that these functions aren't declared.
2799
85876d07
PE
2800 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2801 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2802 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2803 (copy_text): Remove unused local var.
85876d07 2804
03d78a21 2805 * filelock.c (within_one_second): Now static.
b3dd38ab 2806 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2807
5df8f01b
PE
2808 * buffer.c (fix_overlays_before): Mark locals as initialized.
2809 (fix_start_end_in_overlays): Likewise. This function should be
2810 simplified by using pointers-to-pointers, but that's a different
2811 matter.
b1d876f1 2812 (switch_to_buffer_1): Now static.
8f54f30a
PE
2813 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2814 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2815
a70072c9 2816 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2817 Fix pointer signedness issue.
edced198
PE
2818 (sys_subshell): Mark local as volatile if checking for lint,
2819 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2820 (MAXPATHLEN): Define only if needed.
a70072c9 2821
a0977c44
PE
2822 * process.c (serial_open, serial_configure): Move decls from here ...
2823 * systty.h: ... to here, so that they can be checked.
2824
a884fdcc
PE
2825 * fns.c (get_random, seed_random): Move extern decls from here ...
2826 * lisp.h: ... to here, so that they can be checked.
2827
604efe86 2828 * sysdep.c (reset_io): Now static.
b8950c94 2829 (wait_for_termination_signal): Remove; unused.
604efe86 2830
38fc62d9
PE
2831 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2832 (copy_keymap_item, append_key, push_text_char_description):
2833 Now static.
1004a21a 2834 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2835 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2836 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2837 (describe_map_tree):
2838 Rename locals to avoid shadowing.
38fc62d9 2839
2f2650da
PE
2840 * keyboard.c: Declare functions static if they are not used elsewhere.
2841 (echo_char, echo_dash, cmd_error, top_level_2):
2842 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2843 (read_char, kbd_buffer_get_event, make_lispy_position):
2844 (make_lispy_event, make_lispy_movement, apply_modifiers):
2845 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2846 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2847 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2848 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2849 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2850
a053e86c 2851 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2852 (mark_kboards): Move decl here ...
2853 * alloc.c (mark_kboards): ... from here.
a053e86c 2854
4752793e
PE
2855 * lisp.h (force_auto_save_soon): New decl.
2856
74f10ca7 2857 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2858 (DEFINE_DUMMY_FUNCTION): New macro.
2859 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2860 Use it.
c03cd23f
PE
2861 (main): Add casts to avoid warnings
2862 if GCC considers string literals to be constants.
74f10ca7 2863
022e70d4
PE
2864 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2865
59d6fe83
PE
2866 * dbusbind.c: Pointer signedness fixes.
2867 (xd_signature, xd_append_arg, xd_initialize):
2868 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2869 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2870 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2871 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2872
78320123
PE
2873 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2874 if GCC considers string literals to be constants.
49cebcca 2875 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2876
35ac2a97
SM
28772011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2878
fb103ca9
SM
2879 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2880 (print_preprocess, print_object): New macro to fix last change.
2881
35ac2a97
SM
2882 * print.c (print_preprocess): Don't forget font objects.
2883
62973b41
JB
28842011-03-16 Juanma Barranquero <lekktu@gmail.com>
2885
2886 * emacs.c (USAGE3): Doc fixes.
2887
0e48bb22
AS
28882011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2889
2890 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2891 structure.
2892
7684e57b
JB
28932011-03-14 Juanma Barranquero <lekktu@gmail.com>
2894
2895 * lisp.h (VWindow_system, Qfile_name_history):
2896 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2897 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2898 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2899
2900 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2901 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2902
2903 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2904 * w32console.c (detect_input_pending, read_input_pending)
2905 (encode_terminal_code):
2906 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2907 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2908 (w32_system_caret_y, Qfile_name_history):
2909 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2910 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2911 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2912 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2913 * w32proc.c (Qlocal, report_file_error):
2914 * w32term.c (Vwindow_system, updating_frame):
2915 * w32uniscribe.c (initialized, uniscribe_font_driver):
2916 Remove unneeded extern declarations.
2917
2aa46d6c
CY
29182011-03-14 Chong Yidong <cyd@stupidchicken.com>
2919
c96bbc66 2920 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2921
cffc6f3b
CY
29222011-03-13 Chong Yidong <cyd@stupidchicken.com>
2923
2924 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2925 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2926 These macros can no longer be used for assignment.
2927
44f230aa
SM
2928 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2929 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2930 (record_buffer_markers, fetch_buffer_markers): New functions for
2931 recording and fetching special buffer markers.
2932 (set_buffer_internal_1, set_buffer_temp): Use them.
2933
2934 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2935
2936 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2937
2938 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2939 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2940
2941 * xdisp.c (hscroll_window_tree):
2942 (reconsider_clip_changes): Use PT instead of BUF_PT.
2943
d251f04b
EZ
29442011-03-13 Eli Zaretskii <eliz@gnu.org>
2945
2946 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2947 $(EMACS_ROOT)/lib/intprops.h.
2948
f0c77cd1
PE
29492011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2950
3eca4629
PE
2951 Fix more problems found by GCC 4.5.2's static checks.
2952
7c86ee98
PE
2953 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2954 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2955 (xg_free_frame_widgets): Make it clear that a local variable is
2956 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2957 (gdk_window_get_screen): Make it clear that this macro is needed
2958 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2959 (int_gtk_range_get_value): New function, which avoids a diagnostic
2960 from gcc -Wbad-function-cast.
2961 (xg_set_toolkit_scroll_bar_thumb): Use it.
2962 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2963 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2964 (get_utf8_string, xg_get_file_with_chooser):
2965 Rename locals to avoid shadowing.
2966 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2967
41729b81
PE
2968 * xgselect.c (xg_select): Remove unused var.
2969
f0c77cd1
PE
2970 * image.c (four_corners_best): Mark locals as initialized.
2971 (gif_load): Initialize transparent_p to zero (Bug#8238).
2972 Mark another local as initialized.
ec6cf4c6 2973 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2974
ce0ad53d 2975 * image.c (clear_image_cache): Now static.
d5d5a617 2976 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2977 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2978 (x_edge_detection): Remove unnecessary cast that
2979 gcc -Wbad-function-cast diagnoses.
2037898d 2980 (gif_load): Fix pointer signedness.
6ae141d6
PE
2981 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2982 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2983
33383987 29842011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2985
d32df629
PE
2986 Improve quality of tests for time stamp overflow.
2987 For example, without this patch (encode-time 0 0 0 1 1
2988 1152921504606846976) returns the obviously-bogus value (-948597
2989 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2990 reports time overflow. See
2991 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2992 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2993 * editfns.c: Include limits.h and intprops.h.
2994 (TIME_T_MIN, TIME_T_MAX): New macros.
2995 (time_overflow): Move earlier, to before first use.
2996 (hi_time, lo_time): New functions, for an accurate test for
2997 out-of-range times.
2998 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2999 (Fget_internal_run_time): Don't assume time_t fits in int.
3000 (make_time): Use list2 instead of Fcons twice.
3001 (Fdecode_time): More accurate test for out-of-range times.
3002 (check_tm_member): New function.
3003 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3004 (lisp_time_argument): Don't rely on undefined left-shift and
3005 right-shift behavior when checking for time stamp overflow.
8be6f318 3006
fe31d94c
PE
3007 * editfns.c (time_overflow): New function, refactoring common code.
3008 (Fformat_time_string, Fdecode_time, Fencode_time):
3009 (Fcurrent_time_string): Use it.
3010
8be6f318
PE
3011 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3012 * dired.c (make_time): Move to ...
3013 * editfns.c (make_time): ... here.
3014 * systime.h: Note the move.
3015
09d9db2c 30162011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3017
126bc0dc
YM
3018 * fringe.c (update_window_fringes): Remove unused variables.
3019
c47cbdfd
YM
3020 * unexmacosx.c (copy_data_segment): Also copy __got section.
3021 (Bug#8223)
3022
7ac80be9
EZ
30232011-03-12 Eli Zaretskii <eliz@gnu.org>
3024
c96bbc66 3025 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3026 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3027 Constify `char *' arguments and their references according to
3028 prototypes in tparam.h.
3029
ecb0f94d 3030 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3031
7ac80be9
EZ
3032 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3033 Adapt all references accordingly.
3034
3035 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3036
ef1fd07e
TT
30372011-03-11 Tom Tromey <tromey@redhat.com>
3038
3039 * buffer.c (syms_of_buffer): Remove obsolete comment.
3040
7ef4b50c
EZ
30412011-03-11 Eli Zaretskii <eliz@gnu.org>
3042
3043 * termhooks.h (encode_terminal_code): Declare prototype.
3044
3045 * msdos.c (encode_terminal_code): Don't declare prototype.
3046
3047 * term.c (encode_terminal_code): Now external again, used by
3048 w32console.c and msdos.c.
3049
44f230aa
SM
3050 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3051 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3052
4b1ec863 30532011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3054
1714f52b 3055 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3056
4b1ec863
PE
3057 * fringe.c (update_window_fringes): Mark locals as initialized
3058 (Bug#8227).
3059 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3060
524c7aa6
PE
3061 * alloc.c (mark_fringe_data): Move decl from here ...
3062 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3063 to check its interface.
3064 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3065
a5c0af81 3066 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3067 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3068 (fontset_font): Mark local as initialized.
a9a06e0b 3069 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3070
b4716021
PE
3071 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3072
811e9bac 3073 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3074 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3075 (x_own_selection, Fx_disown_selection_internal): Rename locals
3076 to avoid shadowing.
3077 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3078
7e3ab302
PE
3079 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3080 so that the caller can use some name other than gcpro1.
3081 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3082 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3083 (Fx_backspace_delete_keys_p):
3084 Use them to avoid shadowing, and rename vars to avoid shadowing.
3085 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3086 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3087 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3088 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3089 Remove unused locals.
7e3ab302
PE
3090 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3091 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3092 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3093 macros.
f78faa98 3094
e2b13473
PE
3095 * xterm.h (x_mouse_leave): New decl.
3096
77f23912
PE
3097 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3098 Remove unused functions.
cdf4ba58
PE
3099 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3100 (x_calc_absolute_position): Now static.
7411c686 3101 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3102 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3103 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3104 unless they are used.
38d0b34a
PE
3105 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3106 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3107 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3108 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3109 (x_error_catcher, x_connection_closed, x_error_handler):
3110 (x_error_quitter, xembed_send_message, x_iconify_frame):
3111 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3112 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3113 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3114
44f230aa
SM
3115 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3116 Rename or move locals to avoid shadowing.
6b463e58 3117 (tty_defined_color, merge_face_heights): Now static.
5967d051 3118 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3119 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3120 does not deduce is never used uninitialized.
73719eba
PE
3121 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3122 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3123
426994c3 3124 * terminal.c (store_terminal_param): Now static.
5489860b 3125
032f1620 3126 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3127 (set_frame_menubar): Remove unused local.
d4323972 3128 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3129 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3130 since they might point to immutable storage.
281585b0
PE
3131 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3132 since it's unused otherwise.
032f1620 3133
367c19e5 3134 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3135 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3136 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3137 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3138 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3139 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3140 does not deduce are never used uninitialized.
70739cbe 3141
07b48fa9
PE
3142 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3143
8868a238 3144 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3145 * window.c (window_loop, size_window):
3146 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3147
7e5cf297 3148 * window.c (display_buffer): Now static.
d6550a9f
PE
3149 (size_window): Mark variables that gcc -Wuninitialized
3150 does not deduce are never used uninitialized.
a586633d
PE
3151 * window.h (check_all_windows): New decl, to forestall
3152 gcc -Wmissing-prototypes diagnostic.
5b555da1 3153 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3154
f6095868
PE
3155 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3156 shadowing.
3157 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3158 Include <limits.h>.
3159 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3160 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3161 (load_charset_map): Mark variables that gcc -Wuninitialized
3162 does not deduce are never used uninitialized.
53df7c11 3163 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3164
f38b440c
PE
3165 * coding.c (coding_set_source, coding_set_destination):
3166 Use "else { /* comment */ }" rather than "else /* comment */;"
3167 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3168 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3169 a block, when the outer 'i' will do.
3170 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3171 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3172 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3173 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3174 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3175 Rename locals to avoid shadowing.
3176 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3177 * coding.c (emacs_mule_char, encode_invocation_designation):
3178 Now static, since they're not used elsewhere.
413bb2db 3179 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3180 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3181 (decode_coding_emacs_mule): Mark variables that gcc
3182 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3183 (detect_coding_iso_2022): Initialize a local variable that might
3184 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3185 this initialization is needed. (Bug#8211)
5f58e762
PE
3186 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3187 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3188 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3189 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3190 Remove unused macros.
f38b440c 3191
232b38b9 3192 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3193 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3194 * character.c (string_count_byte8): Likewise.
232b38b9 3195
fb90da1b
PE
3196 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3197 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3198
fb93dbc2
PE
3199 * chartab.c (copy_sub_char_table): Now static, since it's not used
3200 elsewhere.
5c156ace
PE
3201 (sub_char_table_ref_and_range, char_table_ref_and_range):
3202 Rename locals to avoid shadowing.
bbcd0949 3203 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3204
7d3b3862 3205 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3206 (BIDI_BOB): Remove unused macro.
7d3b3862 3207
6be7d3da
PE
3208 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3209 deduce are never used uninitialized.
c2ed9c8b 3210 * term.c (encode_terminal_code): Likewise.
6be7d3da 3211
75f8807f 3212 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3213
50938595
PE
3214 * tparam.h: New file.
3215 * term.c, tparam.h: Include it.
3216 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3217 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3218 Move these decls to tparam.h, and make them agree with what
3219 is actually in tparam.c. The previous trick of using incompatible
3220 decls in different modules does not conform to the C standard.
3221 All callers of tparam changed to use tparam's actual API.
3222 * tparam.c (tparam1, tparam, tgoto):
3223 Use const pointers where appropriate.
3224
fbceeba2
PE
3225 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3226 * cm.h (struct cm): Likewise.
3227 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3228 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3229 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3230 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3231 (turn_on_face, init_tty): Likewise.
3232 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3233
7f3f1250
PE
3234 * term.c (term_mouse_position): Rename local to avoid shadowing.
3235
e6ca6543
PE
3236 * alloc.c (mark_ttys): Move decl from here ...
3237 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3238
c40f8d15
AS
32392011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3240
3241 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3242
cfe0661d
JB
32432011-03-09 Juanma Barranquero <lekktu@gmail.com>
3244
3245 * search.c (compile_pattern_1): Remove argument regp, unused since
3246 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3247 (compile_pattern): Don't pass it.
3248
0afb4571
J
32492011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3250
3251 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3252 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3253 for ! HAVE_GTK3.
3254 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3255
3256 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3257
3258 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3259 gdk_window_get_screen, gdk_window_get_geometry,
3260 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3261 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3262 (xg_get_pixbuf_from_pixmap): New function.
3263 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3264 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3265 Call xg_get_pixbuf_from_pixmap instead of
3266 gdk_pixbuf_get_from_drawable.
3267 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3268 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3269 (xg_check_special_colors): Use GtkStyleContext and its functions
3270 for HAVE_GTK3.
3271 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3272 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3273 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3274 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3275 Call gtk_widget_get_preferred_size.
0afb4571
J
3276 (xg_frame_resized): gdk_window_get_geometry only takes 5
3277 parameters.
44f230aa
SM
3278 (xg_win_to_widget, xg_event_is_for_menubar):
3279 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3280 (xg_set_widget_bg): New function.
3281 (delete_cb): New function.
895009e1 3282 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3283 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3284 (xg_set_background_color): Call xg_set_widget_bg.
3285 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3286 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3287 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3288 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3289 if ! HAVE_GTK3.
3290 (update_frame_tool_bar): Call gtk_widget_hide.
3291 (xg_initialize): Use GDK_KEY_g.
3292
3293 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3294 if ! HAVE_GTK3
3295 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3296
3297 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3298 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3299 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3300
1c2cc4ef
JB
33012011-03-08 Juanma Barranquero <lekktu@gmail.com>
3302
3303 * w32xfns.c (select_palette): Check success of RealizePalette against
3304 GDI_ERROR, not zero.
3305
33383987 3306See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3307
3308;; Local Variables:
3309;; coding: utf-8
aac0c6e3
MR
3310;; End:
3311
33383987 3312 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3313
3314 This file is part of GNU Emacs.
3315
3316 GNU Emacs is free software: you can redistribute it and/or modify
3317 it under the terms of the GNU General Public License as published by
3318 the Free Software Foundation, either version 3 of the License, or
3319 (at your option) any later version.
3320
3321 GNU Emacs is distributed in the hope that it will be useful,
3322 but WITHOUT ANY WARRANTY; without even the implied warranty of
3323 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3324 GNU General Public License for more details.
3325
3326 You should have received a copy of the GNU General Public License
3327 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.