* xterm.h (struct x_output): For 'black_relief' and 'white_relief'
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0085b9be
DA
12013-10-29 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * xterm.h (struct x_output): For 'black_relief' and 'white_relief'
4 fields, drop 'allocated_p' member and use -1 for uninitialized value.
5 * w32term.h (struct w32_output): Similarly but do not use -1 because...
6 * xfaces.c (unload_color) [HAVE_X_WINDOWS]: ...this function is a no-op
7 on MS-Windows anyway.
8 (free_face_colors): Define only if HAVE_X_WINDOWS and...
9 (free_realized_face): ...adjust user.
10 * xfns.c (Fx_create_frame, x_create_tip_frame): Initialize black and
11 white relief pixels to -1.
12 * xterm.c (x_setup_relief_color, x_free_frame_resources): Adjust users.
13 * w32term.c (w32_setup_relief_color, x_free_frame_resources): Likewise.
14 * dispextern.h (unload_color): Move prototype under HAVE_X_WINDOWS.
15
b7e0ef72
PE
162013-10-28 Paul Eggert <eggert@cs.ucla.edu>
17
18 * dispextern.h, image.c (x_bitmap_height, x_bitmap_width): Now static.
19 * xfaces.c (load_pixmap): Omit last two args, which are always NULL
20 in practice now. All callers changed.
21
5d3311e5
DA
222013-10-28 Dmitry Antipov <dmantipov@yandex.ru>
23
24 * dispextern.h (struct face): Use bitfields for 'underline_type'
25 and 'box' members. Remove set-but-unused members 'pixmap_w' and
26 'pixmap_h'. If not HAVE_WINDOW_SYSTEM, also remove dummy
27 'stipple' member. Move 'lface' member up to help...
28 * xfaces.c (make_realized_face): ...this function to find and
29 clear just the members that need clearing.
30 (load_face_colors, realize_x_face):
31 * xdisp.c (extend_face_to_end_of_line): Adjust user.
32
0f771d26
DA
332013-10-27 Dmitry Antipov <dmantipov@yandex.ru>
34
35 * xftfont.c (struct xftfont_info): Remove set-but-unused
36 'screen' member.
37 (xftfont_open): Adjust user.
38 (xftfont_get_colors): Remove useless prototype.
39
c556b44b
EZ
402013-10-26 Eli Zaretskii <eliz@gnu.org>
41
42 * emacs.c (Fdump_emacs): Encode FILENAME and SYMFILE arguments
43 before passing them to 'unexec'. (Bug#15260)
44
2a03e2bc
XF
452013-10-26 Xue Fuqiao <xfq.free@gmail.com>
46
47 * fringe.c (set_fringe_bitmap_face): Add usage note from lispref.
48
6702c559
EZ
492013-10-25 Eli Zaretskii <eliz@gnu.org>
50
f67599d5
EZ
51 * w32uniscribe.c (uniscribe_close): Adjust the argument list to
52 the changed signature of the font driver's 'close' method.
53
6702c559
EZ
54 * w32font.h (w32font_close): Adjust the prototype to the change in
55 function definition.
56
57 * w32font.c (w32font_close): Reintroduce deleted declaration of i.
58
59 * w32uniscribe.c (uniscribe_close): Adapt the call to
60 w32font_close to its new prototype.
61
78e0b35c
DA
622013-10-25 Dmitry Antipov <dmantipov@yandex.ru>
63
64 Omit unused frame argument of font API's close function.
65 * font.h (struct font): Drop frame argument. Adjust comment.
66 * font.c (font_clear_cache, font_close_object): Adjust users.
67 * ftfont.c (ftfont_close):
68 * ftxfont.c (ftxfont_close):
69 * macfont.m (macfont_close):
70 * nsfont.m (nsfont_close):
71 * w32font.c (w32font_close):
72 * xfont.c (xfont_close):
86bd985e
DA
73 * xftfont.c (xftfont_close): Adjust driver-specific close functions,
74 tweak comments and make functions safe if called more than once for
75 the same font object.
76
77 Perform font-specific cleanup when font object is swept by GC. See
78 http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00740.html.
79 * alloc.c (cleanup_vector): New function.
80 (sweep_vector): Call it for each reclaimed vector object.
81 * font.h (struct font): Adjust comment.
78e0b35c 82
eb9a3661
GM
832013-10-24 Glenn Morris <rgm@gnu.org>
84
85 * Makefile.in (abs_top_srcdir): New, set by configure.
86
df24a230
DA
872013-10-23 Dmitry Antipov <dmantipov@yandex.ru>
88
66b238df 89 Adjust recent font-related changes to fix bug#15686.
df24a230 90 * alloc.c (mark_object) [HAVE_WINDOW_SYSTEM]: If marked frame
66b238df 91 is a live window system frame, mark its default font too.
df24a230 92
b8e3b0a9
GM
932013-10-23 Glenn Morris <rgm@gnu.org>
94
95 * Makefile.in (RUN_TEMACS): Make relative (again).
96 ($(leimdir)/leim-list.el, .el.elc, $(lispsource)/loaddefs.el)
97 (bootstrap-emacs$(EXEEXT)):
98 Quote entities that might contain whitespace.
99
e4ea223d
PE
1002013-10-23 Paul Eggert <eggert@cs.ucla.edu>
101
102 Port to Solaris 10 and its bundled GCC.
103 Problem reported by Timothy C. Burt.
104 * floatfns.c (isfinite, isnan): Redefine unconditionally.
105
fc54bdd5
DA
1062013-10-21 Dmitry Antipov <dmantipov@yandex.ru>
107
108 Do not allow font caches to grow too large.
109 * alloc.c (compact_font_cache_entry, compact_font_caches):
110 New functions or stub if not HAVE_WINDOW_SYSTEM.
111 (compact_undo_list): Factor out from Fgarbage_collect.
112 Add comment.
113 (mark_face_cache): Mark face font. Move down to avoid
114 extra prototypes.
115 (mark_terminals): Do not mark font cache here.
116 (Fgarbage_collect): Call compaction functions described
117 above. Adjust comment.
118
aca5fcdc
JD
1192013-10-20 Jan Djärv <jan.h.d@swipnet.se>
120
a9f8deec
JD
121 * emacs.c (main): On Cocoa, if GUI session and 0 is not a tty,
122 chdir to HOME (bug#15607).
123
aca5fcdc
JD
124 * nsterm.m (Qcocoa, Qgnustep): New variables.
125 (syms_of_nsterm): Defsym Qcocoa, Qgnustep. Fprovide appropriate one.
d4816ab3 126 (ns_get_color): Make selection color work for GNUStep also.
aca5fcdc 127
c4e3099f
EZ
1282013-10-18 Eli Zaretskii <eliz@gnu.org>
129
130 * keyboard.c (make_lispy_event): Remove GPM-specific code that
131 handles mouse clicks. Instead, let GPM use the same code as all
132 the other mice use. See the discussion starting at
133 http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00521.html
134 for the details of the problem with the menu bar this fixes.
135
d141d701
DA
1362013-10-18 Dmitry Antipov <dmantipov@yandex.ru>
137
138 Remove port-specific display name lists to avoid extra
139 complexity and data duplication with display info lists.
140 * xterm.h (x_display_name_list): Remove declaration.
141 * xterm.c (x_display_name_list): Remove.
142 (x_term_init, x_delete_display, syms_of_xterm): Adjust users.
143 * xfns.c (x_display_info_for_name, Fx_display_list):
144 Likewise. Use x_display_list where appropriate.
145 * w32term.h (w32_display_name_list): Remove declaration.
146 * w32term.c (w32_display_name_list): Remove.
147 (w32_initialize_display_info, x_delete_display, syms_of_w32term):
148 Adjust users.
149 * w32fns.c (x_display_info_for_name, Fx_display_list):
150 Likewise. Use x_display_list where appropriate.
151 * nsterm.h (ns_display_name_list): Remove declaration.
152 * nsterm.m (ns_display_name_list): Remove.
153 (ns_term_init, syms_of_nsterm): Adjust users.
154 * nsfns.m (ns_display_info_for_name, Fx_display_list):
155 Likewise. Use x_display_list where appropriate.
156 * termhooks.h (TERMINAL_FONT_CACHE): New macro.
157 * alloc.c (toplevel) [HAVE_WINDOW_SYSTEM]: Include TERM_HEADER.
158 (mark_terminals): Mark per-terminal font cache.
159
ef566920
BR
1602013-10-17 Barry O'Reilly <gundaetiapo@gmail.com>
161
162 Don't run timers in input-pending-p. Its new check-timers param
163 provides the prior behavior. (Bug#15045).
164 * src/keyboard.c (Finput_pending_p): Accept optional check-timers
165 param.
166
f2752e01
PE
1672013-10-17 Paul Eggert <eggert@cs.ucla.edu>
168
3d798ba7
PE
169 Make some functions static in non-Microsoft builds.
170 On my platform (Fedora 19 x86-64), this shrinks the
171 Emacs executable (text+data) by 0.25%.
172 * dispextern.h (erase_phys_cursor) [!WINDOWSNT]:
173 (load_color) [!MSDOS]:
174 * gnutls.h (emacs_gnutls_transport_set_errno) [!WINDOWSNT]:
175 * keyboard.h (make_ctrl_char) [!WINDOWSNT]:
176 * lisp.h (check_existing):
177 * process.h (conv_sockaddr_to_lisp, network_interface_list)
178 (network_interface_info) [!WINDOWSNT]:
179 * termhooks.h (encode_terminal_code) [!WINDOWSNT]:
180 Remove extern decls.
181 * fileio.c (check_existing):
182 * keyboard.c (make_ctrl_char) [!WINDOWSNT]:
183 * process.c (conv_sockaddr_to_lisp, network_interface_list)
184 (network_interface_info) [!WINDOWSNT]:
185 * term.c (encode_terminal_code) [!WINDOWSNT]:
186 * xdisp.c (erase_phys_cursor) [!WINDOWSNT]:
187 * xfaces.c (load_color) [!MSDOS]:
188 Now static.
189 * fileio.c (check_existing, check_executable, check_writable):
190 * process.c (network_interface_list, network_interface_info):
191 Move earlier, so that we don't need forward decls.
192 * gnutls.c (fn_gnutls_transport_set_errno)
193 (emacs_gnutls_transport_set_errno) [!WINDOWNT]:
194 Remove; unused.
195 * w32.c (init_environment): Use faccessat rather than
196 check_existing, partly for consistency with the rest of the code
197 in this file, partly so that check_existing can be static.
198
bb9937df
PE
199 Make VALMASK visible to GDB even if clang is used (Bug#15574).
200 * emacs.c (MAIN_PROGRAM): New macro.
201 * lisp.h (DEFINE_GDB_SYMBOL_BEGIN, DEFINE_GDB_SYMBOL_END): New macros.
202 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Use them.
203
f2752e01
PE
204 bool vector int width fixes
205 * data.c (bool_vector_spare_mask, Fbool_vector_count_matches)
206 (Fbool_vector_count_matches_at):
207 Use EMACS_INT, not ptrdiff_t, to record bit counts, as a bit count
208 can exceed PTRDIFF_MAX, at least in theory.
209 (Fbool_vector_count_matches_at):
210 Use int, not ptrdiff_t, to record a value that can't exceed INT_MAX.
211
0a2b8e3c
PE
2122013-10-16 Paul Eggert <eggert@cs.ucla.edu>
213
214 * process.h (conv_sockaddr_to_lisp): New decl, for newly-extern func.
215 (struct sockaddr): Add forward decl, for platforms that lack it.
216
2318fcca
JD
2172013-10-16 Jan Djärv <jan.h.d@swipnet.se>
218
219 * nsselect.m (ns_string_from_pasteboard): Remove Fquit, just return
220 Qnil (Bug#15628).
221
b911a94d
EZ
2222013-10-16 Eli Zaretskii <eliz@gnu.org>
223
3dffe395
EZ
224 * w32.c (network_interface_get_info, network_interface_list)
225 (network_interface_info): New functions. (Bug#15610)
226 (GetAdaptersInfo_Proc): New typedef.
227 (get_adapters_info): New wrapper function.
228 (globals_of_w32): Initialize g_b_init_get_adapters_info.
229
230 * process.h (network_interface_list, network_interface_info): New
231 prototypes.
232
233 * process.c (conv_sockaddr_to_lisp): Now externally-visible.
234 (Fnetwork_interface_list, Fnetwork_interface_info): Define for
235 all systems. Return non-nil for systems that HAVE_NET_IF_H and
236 for WINDOWSNT. Doc fix.
237 (syms_of_process): Defsubr Snetwork_interface_list and
238 Snetwork_interface_info unconditionally.
239
b911a94d
EZ
240 * menu.c (have_boxes): Fix redundant simulation of radio buttons
241 in NS GUI sessions. (Bug#15629)
242
04d47595
DA
2432013-10-16 Dmitry Antipov <dmantipov@yandex.ru>
244
245 * fns.c (Fstring_as_unibyte): Use xlispstrdup.
246
5e15c624
PE
2472013-10-15 Paul Eggert <eggert@cs.ucla.edu>
248
249 * print.c (print_object): Print " ..." when truncating bool vectors.
250
5d64d770
EZ
2512013-10-15 Eli Zaretskii <eliz@gnu.org>
252
253 * w32inevt.c (do_mouse_event): Support mouse wheel and all the 5
254 standard mouse buttons.
255
256 * termhooks.h (struct input_event): Remove incorrect commentary.
257
c911772e
PE
2582013-10-15 Paul Eggert <eggert@cs.ucla.edu>
259
454e2fb9
PE
260 Disallow bool vector operations on mixed-length operands.
261 The old behavior left garbage in the result vector sometimes,
262 and didn't seem to be useful.
263 * data.c (Qwrong_length_argument): New static var.
264 (wrong_length_argument): New function.
265 (bool_vector_binop_driver): Check that args agree in length.
266
c911772e
PE
267 * keyboard.c, keyboard.h (all_kboards): Now static.
268
57f623e2
XF
2692013-10-15 Xue Fuqiao <xfq.free@gmail.com>
270
271 * buffer.c (syms_of_buffer) <buffer-invisibility-spec>: Add usage
272 note from the lispref.
273
47c4d1e9
DA
2742013-10-15 Dmitry Antipov <dmantipov@yandex.ru>
275
276 * nsterm.h (struct ns_display_info): Remove set-but-unused
277 member image_cache (image caches are per-terminal anyway).
278 (FRAME_X_IMAGE_CACHE): Remove.
279 * nsterm.m (ns_initialize_display_info): Adjust user.
280
ccd4a783
EZ
2812013-10-14 Eli Zaretskii <eliz@gnu.org>
282
279066b2
EZ
283 * w32proc.c: Include mingw_time.h.
284
285 * w32.c: Include mingw_time.h.
286
ccd4a783
EZ
287 Implement scrolling of TTY menus when the screen is too short.
288
289 * term.c (tty_menu_display): Accept an additional argument, the
290 menu item from which to start displaying the menu. Account for
291 the value of Y when limiting the menu to the number of available
292 screen lines.
293 (mi_result): New enumeration.
294 (read_menu_input): Return enumerated value. When the y coordinate
295 hits min_y or max_y, return scroll indication instead of wrapping
296 around the menu.
297 (tty_menu_activate): Handle the scrolling indications from
298 read_menu_input. Compute the first menu item to display and pass
299 it to tty_menu_display.
300
77e3b1b7
DA
3012013-10-14 Dmitry Antipov <dmantipov@yandex.ru>
302
303 * termhooks.h (FRAME_MUST_WRITE_SPACES, FRAME_LINE_INS_DEL_OK)
304 (FRAME_CHAR_INS_DEL_OK, FRAME_SCROLL_REGION_OK)
305 (FRAME_SCROLL_REGION_COST, FRAME_MEMORY_BELOW_FRAME):
306 Adjust to match the change described below.
307 (struct terminal): Move must_write_spaces, line_ins_del_ok,
308 char_ins_del_ok, scroll_region_ok, scroll_region_cost and
309 memory_below_frame members to...
310 * termchar.h (struct tty_display_info): ...here because they're
311 relevant only on TTYs. Prefer unsigned bitfield where appropriate.
312 * term.c (init_tty):
313 * nsterm.m (ns_create_terminal):
314 * w32term.c (w32_create_terminal):
315 * xterm.c (x_create_terminal): Adjust users.
316 * dispnew.c (line_hash_code, line_draw_cost): Pass frame arg
317 to filter out non-TTY frames. Adjust comment.
318 (scrolling): Adjust user. Prefer eassert for debugging check.
319
e558436b
DA
3202013-10-14 Dmitry Antipov <dmantipov@yandex.ru>
321
322 * xfaces.c (PT_PER_INCH): Remove unused macro.
323 * termhooks.h (struct terminal): Remove set-but-unused
324 member fast_clear_end_of_line.
325 (FRAME_FAST_CLEAR_END_OF_LINE): Remove.
326 * nsterm.m (ns_create_terminal):
327 * term.c (init_tty):
328 * w32term.c (w32_create_terminal):
329 * xterm.c (x_create_terminal): Adjust users.
330
1c0a7493
PE
3312013-10-14 Paul Eggert <eggert@cs.ucla.edu>
332
333 * lisp.h (bool_vector_size): New function.
334 All uses of XBOOL_VECTOR (x)->size changed to bool_vector_size (x).
335 * data.c (bool_vector_spare_mask, bool_vector_binop_driver)
336 (Fbool_vector_not, Fbool_vector_count_matches_at):
337 Remove uses of 'eassume' that should no longer be needed,
338 because they are subsumed by the 'eassume' in bool_vector_size.
339
567f95ec
EZ
3402013-10-12 Eli Zaretskii <eliz@gnu.org>
341
342 * image.c (GIFLIB_MAJOR, GIFLIB_MINOR, GIFLIB_RELEASE): Move back
343 after inclusion of gif_lib.h, thus fixing compiler warnings caused
344 by 2013-10-10T19:15:33Z!eggert@cs.ucla.edu.
345
abe02020
EZ
3462013-10-11 Eli Zaretskii <eliz@gnu.org>
347
348 * xdisp.c (deep_copy_glyph_row): Handle the case that FROM and TO
349 have different dimensions. (Bug#15575)
350
351 * dispnew.c (fill_up_frame_row_with_spaces): Now has external
352 visibility.
353
354 * dispextern.h (fill_up_frame_row_with_spaces): Add prototype.
355
9428abbf
DA
3562013-10-11 Dmitry Antipov <dmantipov@yandex.ru>
357
358 * term.c (tty_menu_show): Never return with unbalanced
359 specpdl. Use eassert for debugging check. Adjust style.
360
052bac0b
EZ
3612013-10-11 Eli Zaretskii <eliz@gnu.org>
362
363 * term.c (read_menu_input): Make selection of menu items
364 cyclical. Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
365 (tty_menu_activate): Fix off-by-one error when computing max_y.
366
e1f9f9e3
TZ
3672013-10-11 Teodor Zlatanov <tzz@lifelogs.com>
368
369 * gnutls.c (gnutls_audit_log_function): Add function for GnuTLS
370 audit logging (only used with GnuTLS 3.x) and enable it.
371
7d563e36
DA
3722013-10-11 Dmitry Antipov <dmantipov@yandex.ru>
373
374 * dispnew.c (redraw_frame): Remove useless #ifdef because
375 FRAME_MSDOS_P is a compile-time zero everywhere except MS-DOS.
376 Also, move TTY fflush to...
377 * term.c (tty_update_end): ...this function.
378
48621e69
EZ
3792013-10-11 Eli Zaretskii <eliz@gnu.org>
380
381 * xdisp.c (display_tty_menu_item): Make sure we never write beyond
382 the end of the frame's glyph matrix. (Bug#15575)
383
384 * term.c (tty_menu_display): Don't move cursor while overwriting
385 frame's glyphs with menu items. Limit the number of items
386 displayed to what can be shown on the available screen lines,
387 excluding the echo area.
388 (tty_menu_activate): Limit the Y coordinate allowed by
389 read_menu_input to the last screen line used for menu display.
390
b9ff995e
PE
3912013-10-11 Paul Eggert <eggert@cs.ucla.edu>
392
393 * lisp.h (eassume): New macro.
394 Also, include <verify.h>, for 'assume'.
395 * alloc.c (bool_vector_payload_bytes, Fmake_bool_vector)
396 (vroundup, vector_nbytes):
397 * data.c (bool_vector_spare_mask, bool_vector_binop_driver)
398 (Fbool_vector_not, Fbool_vector_count_matches)
399 (Fbool_vector_count_matches_at):
400 Use eassume, not eassert.
401 * casetab.c (set_identity, shuffle):
402 * composite.c (composition_gstring_put_cache):
403 * dispnew.c (update_frame_1):
404 * ftfont.c (ftfont_shape_by_flt):
405 * image.c (gif_load):
406 * intervals.c (offset_intervals):
407 * macfont.m (macfont_shape):
408 Remove calls to 'assume' that are no longer needed, because
409 --enable-gcc-warnings no longer generates bogus warnings
410 when these calls are removed.
411
33ac0265
DA
4122013-10-11 Dmitry Antipov <dmantipov@yandex.ru>
413
414 * xdisp.c (deep_copy_glyph_row): Remove unused locals.
415
ee041f2d
SM
4162013-10-10 Stefan Monnier <monnier@iro.umontreal.ca>
417
418 * fileio.c (Fsubstitute_in_file_name): Use substitute-env-in-file-name.
419 (Qsubstitute_env_in_file_name): New var.
420 (syms_of_fileio): Define it.
421
00036e1d
EZ
4222013-10-10 Eli Zaretskii <eliz@gnu.org>
423
424 * xdisp.c (deep_copy_glyph_row): Assert that the 'used' counts of
425 FROM and TO are identical. Copy only the glyphs of TEXT_AREA.
426 (Bug#15575)
427
428 * term.c (save_and_enable_current_matrix): Don't allocate and
429 don't save margin areas.
430 (restore_desired_matrix): Don't restore margin areas.
431 (free_saved_screen): Don't free margin areas.
432
99149625
PE
4332013-10-10 Paul Eggert <eggert@cs.ucla.edu>
434
435 * image.c: Pacify --enable-gcc-warnings.
436 (GIFLIB_MAJOR, GIFLIB_MINOR, GIFLIB_RELEASE, fn_GifErrorString):
437 #define only if used.
438
a5dab159
EZ
4392013-10-10 Eli Zaretskii <eliz@gnu.org>
440
441 * image.c (GIFLIB_MAJOR): Define to 4 if undefined.
442 (GIFLIB_MINOR, GIFLIB_RELEASE): Define to zero if undefined.
443 (GifErrorString) [GIFLIB_MAJOR >= 5]: Define a function pointer.
444 (gif_load): For giflib v5.x and later, display the error message
445 produced by giflib when its functions fail.
446 (syms_of_image) <Qlibgif_version> [HAVE_NTGUI]: New DEFSYM.
447 (Bug#15531)
448
6bbe6da8
DA
4492013-10-10 Dmitry Antipov <dmantipov@yandex.ru>
450
451 * keyboard.c (last_event_timestamp): Remove. For X selection and
452 GTK popup menus, it may be obtained from per-frame X display info.
453 (kbd_buffer_store_event_hold, kbd_buffer_get_event)
454 (process_special_events): Adjust users.
455 * keyboard.h (last_event_timestamp): Remove declaration.
456 * xmenu.c (xmenu_show, create_and_show_popup_menu): Lost last arg.
457 Use FRAME_DISPLAY_INFO (f)->last_user_time for gtk_menu_popup.
458 * menu.h (xmenu_show): Adjust prototype.
459 * menu.c (Fx_popup_menu): Adjust user.
460 * xselect.c (x_own_selection, x_get_foreign_selection)
461 (Fx_disown_selection_internal): Use dpyinfo->last_user_time.
462
1afcba63
DA
4632013-10-10 Dmitry Antipov <dmantipov@yandex.ru>
464
465 * keyboard.c (init_kboard): Now static. Add arg
466 to denote window system. Adjust comment.
467 (init_keyboard): Adjust user.
468 (allocate_kboard): New function.
469 (syms_of_keyboard):
470 * nsterm.m (ns_term_init):
471 * term.c (init_tty):
472 * w32term.c (w32_create_terminal):
473 * xterm.c (x_term_init): Use it.
474 * keyboard.h (init_kboard): Remove prototype.
475 (allocate_kboard): Add prototype.
476
f3606ef7
BF
4772013-10-10 Barry Fishman <barry_fishman@acm.org> (tiny change)
478
479 * image.c (GIFLIB_MAJOR): Ensure it's defined.
480 (DGifOpen, DGifOpenFileName): Handle giflib 5 syntax. (Bug#15531)
481
e20bb249
PE
4822013-10-09 Paul Eggert <eggert@cs.ucla.edu>
483
484 * fns.c (sxhash_bool_vector): Fix buffer read overrun.
485
9f6a18d2
EZ
4862013-10-09 Eli Zaretskii <eliz@gnu.org>
487
488 * term.c (tty_menu_activate): Flush the output stream after
489 showing the cursor, and don't mark the frame garbaged at exit from
490 the function. Fixes redisplay glitches when moving from one menu
491 to another.
492
0486beac
JD
4932013-10-09 Jan Djärv <jan.h.d@swipnet.se>
494
495 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Check input for valid UTF-8
496 or throw error (Bug#15570).
497
0d5d3029
PE
4982013-10-09 Paul Eggert <eggert@cs.ucla.edu>
499
ab7ce978
PE
500 * intervals.c (temp_set_point_both): Move test into 'eassert',
501 for speed.
502
0d5d3029
PE
503 * lisp.h (eassert): Don't use 'assume'.
504 Sometimes 'assume' wins in performance, and sometimes it loses,
505 so it shouldn't be used all the time. Perhaps we need two
506 flavors of 'eassert', one for where 'assume' is far more likely
507 to help or to hurt; but that can be done later.
1afcba63 508 Problem reported by Dmitry Antipov in
0d5d3029
PE
509 <http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00276.html>.
510 Also, don't include <verify.h>; no longer needed.
511
fa022909
GM
5122013-10-09 Glenn Morris <rgm@gnu.org>
513
514 * eval.c (Fcond): Doc tweak.
515
051277bf
EZ
5162013-10-09 Eli Zaretskii <eliz@gnu.org>
517
518 * xfaces.c (x_free_gc) [HAVE_X_WINDOWS, HAVE_NTGUI]: Don't pass
519 expressions with side effects to eassert. (Bug#15565)
520
79804536
SM
5212013-10-09 Stefan Monnier <monnier@iro.umontreal.ca>
522
523 * fns.c (hashfn_user_defined): Allow hash functions to return any
524 Lisp_Object.
525
3b158d11
PE
5262013-10-08 Paul Eggert <eggert@cs.ucla.edu>
527
528 Fix minor problems found by static checking.
529 * dispnew.c (save_current_matrix): Omit unnecessary casts.
530 * dispnew.c (update_frame_with_menu): Mark debug local as used.
531 * keyboard.c, keyboard.h (Qmouse_movement): Now static.
532 * keyboard.c (read_menu_command): Remove unused local.
533 * lisp.h (read_menu_command): New decl.
534 * menu.c, menu.h (menu_item_width): Arg is now unsigned char *, for
535 benefit of STRING_CHAR_AND_LENGTH. All uses changed.
536 Return ptrdiff_t, not int.
537 * term.c (tty_menu_struct): 'allocated' member is now ptrdiff_t,
538 not int, for benefit of xpalloc.
539 (tty_menu_create, tty_menu_make_room): Simplify by using xzalloc
540 and xpalloc.
541 (have_menus_p): Remove; unused.
542 (tty_menu_add_pane, tty_menu_add_selection): Change signedness of
543 local char * pointer to pacify STRING_CHAR_AND_LENGTH.
544 (tty_menu_add_selection, tty_menu_locate, tty_meny_destroy):
545 Now static.
546 (save_and_enable_current_matrix): Omit unnecessary casts.
547 (read_menu_input): Omit local extern decl (now in lisp.h).
548 Don't access uninitialized storage if mouse_get_xy fails.
549 (tty_menu_activate): Mark local as initialized, for lint.
550 (tty_menu_activate, tty_meny_show): Remove unused locals.
551
4ed77415
EZ
5522013-10-08 Eli Zaretskii <eliz@gnu.org>
553
554 Support menus on text-mode terminals.
555 * xterm.h (xw_popup_dialog): Add prototype.
556
557 * xmenu.c (Fx_popup_dialog): Function moved to menu.c.
558 (xmenu_show): Block input here, instead in Fx_popup_menu.
559 (xw_popup_dialog): New function, with X-specific bits of popup
560 dialogs.
561
562 * xdisp.c (deep_copy_glyph_row, display_tty_menu_item): New
563 functions.
564
565 * window.c (Fset_window_configuration): Use run-time tests of the
566 frame type instead of compile-time conditionals, when menu-bar
567 lines are considered.
568
569 * w32term.h (w32con_hide_cursor, w32con_show_cursor)
570 (w32_popup_dialog): New prototypes.
571
572 * w32menu.c (Fx_popup_dialog): Function deleted.
573 (w32_popup_dialog): New function, with w32 specific bits of popup
574 dialogs. Block input here.
575
576 * w32inevt.c (w32_console_read_socket): Minor change to add
577 debugging TTY events.
578
579 * w32fns.c (show_hourglass): If returning early because the frame
580 is not a GUI frame, unblock input.
581
582 * w32console.c (w32con_hide_cursor, w32con_show_cursor, cursorX)
583 (cursorY): New functions.
584
585 * termhooks.h (cursorX, cursorY): Prototypes of functions on
586 WINDOWSNT, macros that call curX and curY elsewhere.
587
588 * termchar.h (struct tty_display_info) <showing_menu>: New flag.
589
590 * term.c (tty_hide_cursor, tty_show_cursor) [WINDOWSNT]: Call w32
591 specific function to hide and show cursor on a text-mode terminal.
592 (tty_menu_struct, struct tty_menu_state): New structures.
593 (tty_menu_create, tty_menu_make_room, tty_menu_search_pane)
594 (tty_menu_calc_size, mouse_get_xy, tty_menu_display)
595 (have_menus_p, tty_menu_add_pane, tty_menu_add_selection)
596 (tty_menu_locate, save_and_enable_current_matrix)
597 (restore_desired_matrix, screen_update, read_menu_input)
598 (tty_menu_activate, tty_menu_destroy, tty_menu_help_callback)
599 (tty_pop_down_menu, tty_menu_last_menubar_item)
600 (tty_menu_new_item_coords, tty_menu_show): New functions.
601 (syms_of_term): New DEFSYMs for tty-menu-* symbols.
602
603 * nsterm.h (ns_popup_dialog): Adjust prototype.
604
605 * nsmenu.m (ns_menu_show): Block and unblock input here, instead
606 of in x-popup-menu.
607 (ns_popup_dialog): Adapt order of arguments to the other
608 *_menu_show implementations.
609 (Fx_popup_dialog): Function deleted.
610
611 * msdos.c (x_set_menu_bar_lines): Delete unused function.
612
613 * menu.h (tty_menu_show, menu_item_width): provide prototypes.
614
615 * menu.c (have_boxes): New function.
616 (single_keymap_panes): Use it instead of a compile-time
617 conditional.
618 (single_menu_item): Use run-time tests of the frame type instead
619 of compile-time conditionals.
620 (encode_menu_string): New function.
621 (list_of_items, list_of_panes): Use it instead of ENCODE_STRING
622 the macro, since different types of frame need different encoding
623 of menu items.
624 (digest_single_submenu): Use run-time tests of frame type instead
625 of, or in addition to, compile-time conditionals.
626 (menu_item_width, Fmenu_bar_menu_at_x_y): New functions.
627 (Fx_popup_menu): Detect when the function is called from keyboard
628 on a TTY. Don't barf when invoked on a text-mode frame. Check
629 frame type at run time, instead of compile-time conditionals for
630 invoking terminal-specific menu-show functions. Call
631 tty_menu_show on text-mode frames.
632 (Fx_popup_dialog): Moved here from xmenu.c. Test frame types at
633 run time to determine which alternative to invoke; support dialogs
634 on TTYs.
635
636 * keyboard.h <Qmouse_movement>: Declare.
637
638 * keyboard.c <Qmouse_movement>: Now extern.
639 <Qecho_keystrokes>: New static variable.
640 (read_key_sequence): Accept an additional argument, a flag to
641 prevent redisplay during reading of the key sequence. All callers
642 changed.
643 (read_menu_command): New function.
644 (read_char): When COMMANDFLAG is -2, do not redisplay and do not
645 autosave.
646 (toolkit_menubar_in_use): New function.
647 (make_lispy_event): Use it instead of a compile-time test.
648
649 * fns.c (Fyes_or_no_p) [HAVE_MENUS]: Don't condition on
650 window-system being available.
651
652 * editfns.c (Fmessage_box) [HAVE_MENUS]: Don't condition the call
653 to x-popup-dialog on the frame type, they all now support popup
654 dialogs.
655
656 * dispnew.c (save_current_matrix): Save the margin areas.
657 (restore_current_matrix): Restore margin areas.
658 (update_frame_with_menu): New function.
659
660 * dispextern.h (display_tty_menu_item, update_frame_with_menu):
661 Add prototypes.
662
663 * alloc.c (make_save_ptr): Now compiled unconditionally.
664
ecab13d4
DA
6652013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
666
667 * dispnew.c (set_window_update_flags): Add buffer arg. Adjust comment.
668 (redraw_frame, update_frame): Adjust users.
669 * dispextern.h (set_window_update_flags): Adjust prototype.
670 * xdisp.c (redisplay_internal): When updating all frames with zero
671 windows_or_buffers_changed, assume that only the windows that shows
672 current buffer should be really updated.
673
f8498081
DA
6742013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
675
676 Do not allocate huge temporary memory areas and objects while encoding
677 for file I/O, thus reducing an enormous memory usage for large buffers.
678 See http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00180.html.
679 * coding.h (struct coding_system): New member raw_destination.
680 * coding.c (setup_coding_system): Initialize it to zero.
681 (encode_coding_object): If raw_destination is set, do not create
682 dst_object. Add comment.
683 * fileio.c (toplevel): New constant E_WRITE_MAX.
684 (e_write): Do not encode more than E_WRITE_MAX characters per one loop
685 iteration. Use raw_destination if E_WRITE_MAX characters is encoded.
686
d180bde8
JD
6872013-10-08 Jan Djärv <jan.h.d@swipnet.se>
688
689 * nsterm.m (windowDidExitFullScreen:):
690 (toggleFullScreen:): Change NS_IMPL_COCOA to HAVE_NATIVE_FS.
691
87c4314d
PE
6922013-10-08 Paul Eggert <eggert@cs.ucla.edu>
693
18978362
PE
694 Fix race where emacs aborts when sent SIGTERM (Bug#15534).
695 * keyboard.c (unblock_input_to): Don't process pending signals
696 if a fatal error is in progress.
697
87c4314d
PE
698 * lisp.h (bits_word, BITS_WORD_MAX): New type and macro.
699 All uses of 'size_t' and 'SIZE_MAX' changed to use them, when
700 they're talking about words in Lisp bool vectors.
701 (BITS_PER_BITS_WORD): Rename from BITS_PER_SIZE_T. All uses changed.
1142cc2a
PE
702 * data.c (popcount_bits_word): Rename from popcount_size_t.
703 (bits_word_to_host_endian): Rename from size_t_to_host_endian.
704 All uses changed.
87c4314d 705
595e113b
PE
7062013-10-07 Paul Eggert <eggert@cs.ucla.edu>
707
708 Improve support for popcount and counting trailing zeros (Bug#15550).
709 * data.c: Include <count-one-bits.h>, <count-trailing-zeros.h>.
710 (USE_MSC_POPCOUNT, POPCOUNT_STATIC_INLINE)
711 (NEED_GENERIC_POPCOUNT, popcount_size_t_generic)
712 (popcount_size_t_msc, popcount_size_t_gcc):
713 Remove; now done by Gnulib.
714 (popcount_size_t): Now a macro that defers to Gnulib.
715 (count_trailing_zero_bits): Return int, for consistency with
716 Gnulib and because Emacs prefers signed to unsigned int.
717 Don't assume that size_t is either unsigned int or unsigned long
718 or unsigned long long.
719 (size_t_to_host_endian): Do not assume that size_t is either
720 exactly 32 or exactly 64 bits wide.
721 * lisp.h (BITS_PER_SIZE_T): Define consistently with BITS_PER_LONG
722 etc., so that it's now an enum constant, not a macro.
723 No need to assume that it's either 32 or 64.
724
ddb317ba
JD
7252013-10-07 Jan Djärv <jan.h.d@swipnet.se>
726
727 * nsterm.m (windowDidEnterFullScreen:): setPresentationOptions only
728 on >= 10.7.
729
bd74250f
DA
7302013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
731
732 * insdel.c (insert_from_gap): Prefer ptrdiff_t to int where needed.
764636db 733 * xdisp.c (handle_fontified_prop): Likewise. Use bool for boolean.
bd74250f 734
223752d7
PE
7352013-10-07 Paul Eggert <eggert@cs.ucla.edu>
736
737 emacs_read and emacs_write now use void *, not char *.
738 * alloc.c (valid_pointer_p) [!WINDOWSNT]: Remove now-unnecessary cast.
739 * sysdep.c (emacs_read, emacs_write, emacs_write_sig):
740 Buffer arg is now void *, not char *. This matches plain
741 'read' and 'write' better, and avoids a constraint violation
742 on Solaris 9 with Oracle Studio.
743
3c439e0a
DA
7442013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
745
746 * alloc.c (Fmake_string): For ASCII char initializer, prefer
747 memset to explicit loop. Otherwise copy largest possible chunk
748 from initialized to uninitialized part, thus allowing the longer
749 memcpy runs and reducing the number of loop iterations.
750
28c76099
JD
7512013-10-06 Jan Djärv <jan.h.d@swipnet.se>
752
753 * nsterm.m (ns_update_begin): If native fullscreen and no toolbar,
754 hide toolbar (Bug#15388).
755 (windowDidEnterFullScreen:): If presentation options are zero,
756 set them here (Bug#15388).
a3e9050c
JD
757 (ns_update_auto_hide_menu_bar): Remove runtime check.
758 Don't auto hide dock unless menubar is also auto hidden.
28c76099 759
544a2a80
XF
7602013-10-05 Xue Fuqiao <xfq.free@gmail.com>
761
762 * editfns.c (message): Mention batch mode in doc string.
763
a27fd309
JD
7642013-10-05 Jan Djärv <jan.h.d@swipnet.se>
765
766 * nsterm.m (check_native_fs): Remove erroneous comment.
767
942f6f82
DA
7682013-10-04 Dmitry Antipov <dmantipov@yandex.ru>
769
770 * xdisp.c (redisplay_internal): Simplify because scan_for_column now
771 uses find_newline instead of scan_newline and so doesn't move point.
772
157fec2e
PE
7732013-10-04 Paul Eggert <eggert@cs.ucla.edu>
774
4eed3157
PE
775 Use hardware support for byteswapping on glibc x86 etc.
776 On Fedora 19 x86-64, the new bswap_64 needs 1 instruction,
777 whereas the old swap64 needed 30.
778 * fringe.c (init_fringe_bitmap) [WORDS_BIGENDIAN]:
779 * sound.c (le2hl, le2hs, be2hl) [!WINDOWSNT]:
780 Use byteswap.h's macros to swap bytes.
781 * lisp.h (swap16, swap32, swap64): Remove.
782 All uses replaced by bswap_16, bswap_32, bswap_64.
783
157fec2e
PE
784 * bytecode.c (exec_byte_code): Use some more volatile variables
785 to work around local variables getting clobbered by longjmp.
786 Port to pre-C99, which doesn't allow decls after stmts.
787
b52f569d
PE
7882013-10-03 Paul Eggert <eggert@cs.ucla.edu>
789
75273afb
PE
790 * lisp.h (eassert): Assume that COND is true when optimizing.
791 In other words, take on the behavior of eassert_and_assume.
792 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
793 (eassert_and_assume): Remove. All uses replaced by eassert.
794
ead45345
PE
795 * xdisp.c (Qglyphless_char): Now static.
796
0a858ebf
PE
797 Adjust to merge from gnulib.
798 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
799 * lisp.h: Include <verify.h>, for 'assume'.
800
b52f569d
PE
801 * eval.c (clobbered_eassert): New macro.
802 (internal_catch, internal_condition_case)
803 (internal_condition_case_1, internal_condition_case_2)
804 (internal_condition_case_n): Use it instead of eassert
805 when the argument contains locals clobbered by longjmp.
806 Don't use clobbered locals outside of clobbered_eassert.
807 (internal_lisp_condition_case): Use a volatile variable
808 to work around a local variable's getting clobbered.
809
adf2aa61
SM
8102013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
811
812 * lisp.h (struct handler): Merge struct handler and struct catchtag.
813 (PUSH_HANDLER): New macro.
814 (catchlist): Remove.
815 (handlerlist): Always declare.
816
817 * eval.c (catchlist): Remove (merge with handlerlist).
818 (handlerlist, lisp_eval_depth): Not static any more.
819 (internal_catch, internal_condition_case, internal_condition_case_1)
820 (internal_condition_case_2, internal_condition_case_n):
821 Use PUSH_HANDLER.
822 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
823 handlerlist/catchlist.
824 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
825 handlerlist which can only handle a single condition-case handler at
826 a time.
827 (find_handler_clause): Simplify since we only a single branch here
828 any more.
829
830 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
831 and Bpophandler.
832 (bcall0): New function.
833 (exec_byte_code): Add corresponding cases. Improve error message when
834 encountering an invalid byte-code. Let Bunwind_protect accept
835 a function (rather than a list of expressions) as argument.
836
837 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
838 and make them unconditional now that they're heap-allocated.
839
328a8179
SM
8402013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
841
842 * charset.c (Fdecode_char, Fencode_char): Remove description of
843 `restriction' arg. now that it's hidden by advertised-calling-convention.
844
c348360a
JD
8452013-10-02 Jan Djärv <jan.h.d@swipnet.se>
846
328a8179
SM
847 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
848 Remove unused variable (from mac-port).
c348360a
JD
849 (macfont_draw): Use s->ybase for correct y position.
850
1a23cd48
DA
8512013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
852
853 * frame.h (struct frame): Drop has_minibuffer member because...
854 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
855 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
856
29bf4de4
DA
8572013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
858
859 * window.h (struct window): Prefer enum text_cursor_kinds to int
860 for phys_cursor_type member. Move the latter, phys_cursor_width,
861 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
862 * window.c (replace_window, make_window): Adjust users.
863
a30ddace
DA
8642013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
865
866 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
867 this module is never compiled otherwise.
868
45435f08
AA
8692013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
870
871 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
872 (Bug#15500).
873
92e5298b
EZ
8742013-09-29 Eli Zaretskii <eliz@gnu.org>
875
876 * xdisp.c (get_next_display_element): Don't call face_for_font in
877 a build configured --without-x. (Bug#15484)
878
caa50be2
JD
8792013-09-29 Jan Djärv <jan.h.d@swipnet.se>
880
66d13b20
JD
881 * window.c (calc_absolute_offset): #elif should be #elif defined.
882
caa50be2
JD
883 * frame.c (delete_frame): Block/unblock input to overcome race
884 condition (Bug#15475).
885
d3e2acb6
AP
8862013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
887
888 * frame.c (delete_frame): Record selected frame only after
889 calling Qdelete_frame_functions (Bug#15477).
890
1610938f
JD
8912013-09-28 Jan Djärv <jan.h.d@swipnet.se>
892
893 * nsterm.m (ns_selection_color): Remove.
894 (ns_get_color): Check for ns_selection_(fg|bg)_color using
895 NSColor selectedText(Background)Color. Only for COCOA.
896 (ns_term_init): Remove assignment of ns_selection_color, logic
897 moved to ns_get_color.
898
328a8179 899 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
900 NS_SELECTION_COLOR_DEFAULT.
901 (NS_SELECTION_FG_COLOR_DEFAULT): New.
902
0d2647e6
EZ
9032013-09-28 Eli Zaretskii <eliz@gnu.org>
904
905 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
906 frame' does not have the tool_bar_window member.
907
ba355de0
BR
9082013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
909
910 Signal error when reading an empty byte-code object (Bug#15405)
911 * lread.c (read1): signal error
912 * alloc.c (make_byte_code): eassert header size
913 (sweep_vectors): change an int to size_t
914
4710d6f4
PE
9152013-09-24 Paul Eggert <eggert@cs.ucla.edu>
916
cf647d93
PE
917 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
918 instead of ints, as it's the usual style for offsetof constants. See:
919 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
920
4710d6f4
PE
921 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
922 This is ugly, but it should fix the performance problem for older
923 GCC versions in the short run. I'll look into integrating the
924 Gnulib module for popcount, as a better fix.
925 See the thread starting in:
926 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
927 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
928 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
929 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
930 (popcount_size_t): Use it.
931
10ebac9d
DC
9322013-09-24 Daniel Colascione <dancol@dancol.org>
933
934 * process.c (Fnetwork_interface_info): Fix build break due to
935 vector changes.
936
9da0f50e
PE
9372013-09-24 Paul Eggert <eggert@cs.ucla.edu>
938
939 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
940 Prefer signed to unsigned integers where either will do.
941 No need for 'const' on locals that do not escape.
942 Omit easserts with unnecessary and unportable assumptions about
943 alignment. Avoid unnecessary casts to char *.
944
d6d9cbc1
DA
9452013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
946
947 Use union for the payload of struct Lisp_Vector.
948 This helps to avoid a few glitches dictated by C's aliasing rules.
949 * lisp.h (struct Lisp_Vector): Use union for next and
950 contents member. Adjust comment. Change related users.
951 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
952 Related users changed.
953 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
954 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
955 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
956 * xfaces.c, xfont.c, xmenu.c: Related users changed.
957
ec7bc82f
DA
9582013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
959
960 Optimize glyph row clearing and copying routines.
961 * dispextern.h (struct glyph_row): Change layout of struct
962 glyph_row to help copy_row_except_pointers. Adjust comment.
963 * dispnew.c (null_row): Remove.
964 (clear_glyph_row): Use offsetof and memset to find and clear
965 just the members that need clearing. Adjust comment.
966 (copy_row_except_pointers): Likewise for copying.
967
d160dd0c
PE
9682013-09-24 Paul Eggert <eggert@cs.ucla.edu>
969
7be68de5
PE
970 Some minor cleanups of recently-added bool vector code.
971 * conf_post.h (assume): Always return void. Use lint version
972 only if GCC and MSC versions don't apply.
973 * conf_post.h (assume):
974 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
975 Depend on _MSC_VER, not __MSC_VER, for consistency with
976 the rest of Emacs.
977 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
978 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
979 (bool_vector_binop_driver, count_trailing_zero_bits)
980 (size_t_to_host_endian): Now static, not static inline;
981 the latter isn't needed with modern compilers and doesn't
982 work with older compilers anyway.
983
d160dd0c
PE
984 * alloc.c (valgrind_p): Use bool for boolean.
985
e08813d0
DA
9862013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
987
988 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
989 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
990 (display_last_displayed_message_p, message_buf_print)
991 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
992 Use bool for boolean.
3a6a78fd
DA
993 * dispextern.h (cancel_line, init_desired_glyphs):
994 Remove ancient leftover.
995 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
996 * lisp.h (noninteractive_need_newline): Adjust declaration.
997
5492865b
DA
9982013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
1001 Move to...
1002 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
1003 ...this file and convert the latter to static. Adjust comment.
1004 (make_initial_frame):
1005 * window.c (init_window_once): Adjust user.
1006 * frame.h (last_nonminibuf_frame): Remove declaration.
1007 * lisp.h (selected_frame): Likewise.
1008 * msdos.c (the_only_display_info): Adjust comment.
1009
cd548fa4
EZ
10102013-09-23 Eli Zaretskii <eliz@gnu.org>
1011
f03eddbf
EZ
1012 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
1013 computing the end column of mouse-highlight that comes from
1014 display or overlay strings. (Bug#15437)
b519df23
EZ
1015 (note_mouse_highlight): Adapt calculation of last argument to
1016 mouse_face_from_string_pos to the above change.
f03eddbf 1017
cd548fa4
EZ
1018 * conf_post.h (__has_builtin): Define to zero, if undefined, on
1019 all platforms, not just for clang.
1020
8762e524
JD
10212013-09-23 Jan Djärv <jan.h.d@swipnet.se>
1022
1023 * filelock.c (lock_file_1): Rearrange to remove compiler warning
1024 about excess arguments to snprintf.
1025
1026 * conf_post.h(assume): Use __builtin_unreachable for clang.
1027
d4a9284f
JB
10282013-09-23 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
1031 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
1032
a84683fd
DC
10332013-09-23 Daniel Colascione <dancol@dancol.org>
1034
1035 * alloc.c (USE_VALGRIND): New macro; on by default
1036 when ENABLE_CHECKING.
ffb3f67a 1037 (mark_maybe_object, mark_maybe_pointer)
a84683fd
DC
1038 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
1039 valgrind purposes.
1040 (valgrind_p) [USE_VALGRIND]: New variable.
1041 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
1042
8fef36c6
JD
10432013-09-22 Jan Djärv <jan.h.d@swipnet.se>
1044
fb83ea63
JD
1045 * process.c (wait_reading_process_output): Change int pnamelen to
1046 socklen_t.
1047
1048 * nsterm.m (setMarkedText:selectedRange:):
1049 (deleteWorkingText):
1050 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
1051 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
1052 argument to unsigned long to avoid warning.
1053 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
1054
8fef36c6
JD
1055 * conf_post.h (assume): Fix compiler error: x shall be cond.
1056
cd9356f2
DC
10572013-09-22 Daniel Colascione <dancol@dancol.org>
1058
1059 * xfns.c (x_get_monitor_attributes): Suppress unused variable
1060 warning when compiling without a window system.
1061
3e0b94e7
DC
10622013-09-22 Daniel Colascione <dancol@dancol.org>
1063
1064 * data.c (Qbool_vector_p): New symbol.
ffb3f67a
PE
1065 (bool_vector_spare_mask, popcount_size_t_generic)
1066 (popcount_size_t_msc, popcount_size_t_gcc)
3e0b94e7
DC
1067 (popcount_size_t)
1068 (bool_vector_binop_driver)
ffb3f67a 1069 (count_trailing_zero_bits, size_t_to_host_endian)
3e0b94e7
DC
1070 (Fbool_vector_exclusive_or)
1071 (Fbool_vector_union)
ffb3f67a
PE
1072 (Fbool_vector_intersection, Fbool_vector_set_difference)
1073 (Fbool_vector_subsetp, Fbool_vector_not)
3e0b94e7
DC
1074 (Fbool_vector_count_matches)
1075 (Fbool_vector_count_matches_at): New functions.
1076 (syms_of_data): Intern new symbol, functions.
1077 * alloc.c (bool_vector_payload_bytes): New function.
1078 (Fmake_bool_vector): Instead of calling Fmake_vector,
1079 which performs redundant initialization and argument checking,
1080 just call allocate_vector ourselves. Make sure we clear any
1081 terminating padding to zero.
ffb3f67a 1082 (vector_nbytes, sweep_vectors): Use bool_vector_payload_bytes
3e0b94e7
DC
1083 instead of open-coding the size calculation.
1084 (vroundup_ct): New macro.
1085 (vroundup): Assume argument >= 0; invoke vroundup_ct.
ffb3f67a 1086 * casetab.c (shuffle, set_identity): Change lint_assume to assume.
328a8179
SM
1087 * composite.c (composition_gstring_put_cache):
1088 Change lint_assume to assume.
3e0b94e7
DC
1089 * conf_post.h (assume): New macro.
1090 (lint_assume): Remove.
1091 * dispnew.c (update_frame_1): Change lint_assume to assume.
1092 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
1093 to assume.
1094 * image.c (gif_load): Change lint_assume to assume.
1095 * lisp.h (eassert_and_assume): New macro.
1096 (Qbool_vector_p): Declare.
ffb3f67a
PE
1097 (CHECK_BOOL_VECTOR, ROUNDUP, BITS_PER_SIZE_T): New macros.
1098 (swap16, swap32, swap64): New inline functions.
3e0b94e7
DC
1099 * macfont.c (macfont_shape): Change lint_assume to assume.
1100 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
1101 * xsettings.c (parse_settings): Use new swap16 and
1102 swap32 from lisp.h instead of file-specific macros.
1103
76880d88
EZ
11042013-09-22 Eli Zaretskii <eliz@gnu.org>
1105
1106 * xdisp.c (try_window_id): Don't abort if cursor row could not be
1107 found (which can legitimately happen when the glyph row at the
1108 window start is disabled in the current_matrix. (Bug#15365)
1109
c6cfd910
PE
11102013-09-22 Paul Eggert <eggert@cs.ucla.edu>
1111
1112 Fix syntax.h bug introduced by recent INLINE change.
1113 syntax.h defined an extern inline function SYNTAX_ENTRY that was
1114 conditionally compiled one way in some modules, and a different
1115 way in others. This doesn't work with extern inline functions,
1116 which must have the same definition in all modules, because the
1117 defining code might be shared across modules, depending on the
1118 implementation. Symptoms reported by Martin Rudalics in:
1119 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
1120 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
1121 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
1122 overriding the corresponding functions in syntax.h.
1123 * syntax.h (syntax_property_entry, syntax_property_with_flags)
1124 (syntax_property): New inline functions.
1125 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
1126 Rewrite in terms of these new functions.
1127
b3f1d119
EZ
11282013-09-21 Eli Zaretskii <eliz@gnu.org>
1129
1130 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
1131 not chars_in_text, whose result depends on the multibyteness of
1132 the current buffer. (Bug#15426)
1133
00382e8b
PE
11342013-09-20 Paul Eggert <eggert@cs.ucla.edu>
1135
e3b29769
PE
1136 Port recent change to hosts where pointers aren't 'long'.
1137 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
1138 Don't assume that pointers are the same width as 'long'.
1139 Add a compile-time check that a pointer fits into two X slots.
1140
00382e8b
PE
1141 A simpler, centralized INLINE.
1142 * conf_post.h (INLINE): Define only if not already defined.
1143 This allows us to use a single INLINE, defined by one file
1144 per executable.
1145 * emacs.c (INLINE): Define it.
1146 Also, include category.h, charset.h, composite.h, dispextern.h,
1147 syntax.h, systime.h, so that their INLINE definitions are expanded
1148 properly for Emacs.
1149 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
1150 * buffer.h, buffer.c (BUFFER_INLINE):
1151 * category.h, category.c (CATEGORY_INLINE):
1152 * character.h, character.c (CHARACTER_INLINE):
1153 * charset.h, charset.c (CHARSET_INLINE):
1154 * composite.h, composite.c (COMPOSITE_INLINE):
1155 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
1156 * frame.h, frame.c (FRAME_INLINE):
1157 * intervals.h, intervals.c (INTERVALS_INLINE):
1158 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
1159 * lisp.h, alloc.c (LISP_INLINE):
1160 * process.h, process.c (PROCESS_INLINE):
1161 * syntax.h, syntax.c (SYNTAX_INLINE):
1162 * systime.h, sysdep.c (SYSTIME_INLINE):
1163 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
1164 * window.h, window.c (WINDOW_INLINE):
1165 Remove. All uses replaced with INLINE.
1166
2b943ba6
DA
11672013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
1168
1169 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
1170 to avoid Bug#15398.
1171
13d9698a
EZ
11722013-09-19 Eli Zaretskii <eliz@gnu.org>
1173
1174 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
1175 'const char *' to avoid compiler warnings due to similar change in
1176 the prototype of x_get_string_resource.
1177
ced135eb
DA
11782013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
1179
1180 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
1181 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
1182 going to replace static variables below. Adjust comments.
1183 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
1184 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
1185 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
1186 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
1187 Related users changed.
1188 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
1189 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
1190 last_mouse_movement_time, going to replace static variables below.
1191 Adjust comments.
1192 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
1193 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
1194 Remove.
1195 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
1196 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
1197 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
1198 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
1199 static variables below.
1200 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
1201 (last_mouse_scroll_bar): Remove.
1202 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
1203 (mouseExited): Related users changed.
1204
091f1e1f
DA
12052013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Do not use external array to process X scroll bar messages.
1208 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
1209 (x_send_scroll_bar_event): Pack window pointer into two slots
1210 of XClientMessageEvent if we're 64-bit. Adjust comment.
1211 (x_scroll_bar_to_input_event): Unpack accordingly.
1212
582ed56c
DA
12132013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
1214
1215 Ifdef away recent changes which aren't relevant to NS port.
1216 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
1217 [!HAVE_NS]: Declare as such.
1218 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
1219 [!HAVE_NS]: Define as such.
1220
18da0d8a
DA
12212013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
1222
1223 * frame.c (x_redo_mouse_highlight): New function
1224 to factor out common code used in W32 and X ports.
1225 * dispextern.h (x_redo_mouse_highlight): Add prototype.
1226 * xterm.h (struct x_display_info):
1227 * w32term.h (struct w32_display_info):
1228 * nsterm.h (struct ns_display_info): New members
1229 last_mouse_motion_frame, last_mouse_motion_x and
1230 last_mouse_motion_y, going to replace static variables below.
1231 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
1232 (redo_mouse_highlight): Remove.
1233 (note_mouse_movement, syms_of_xterm): Adjust user.
1234 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
1235 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
1236 (redo_mouse_highlight): Remove.
1237 (note_mouse_movement, syms_of_w32term): Adjust user.
1238 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
1239 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
1240 Remove.
1241 (note_mouse_movement, mouseMoved, syms_of_nsterm):
1242 * nsfns.m (compute_tip_xy): Adjust user.
1243
7a0c745a
DA
12442013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
1245
1246 * frame.c (x_mouse_grabbed): New function.
1247 * dispextern.h (x_mouse_grabbed): Add prototype.
1248 (last_mouse_frame): Remove declaration.
1249 * xterm.h (struct x_display_info):
1250 * w32term.h (struct w32_display_info):
1251 * nsterm.h (struct ns_display_info): New member
1252 last_mouse_frame, going to replace...
1253 * xdisp.c (last_mouse_frame): ...global variable.
1254 (note_tool_bar_highlight):
1255 * w32term.c (w32_mouse_position, w32_read_socket):
1256 * xterm.c (XTmouse_position, handle_one_xevent):
1257 Use x_mouse_grabbed.
1258 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
1259
0791d107
DA
12602013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
1261
1262 * w32term.c (w32_read_socket): Avoid temporary
1263 variables in a call to x_real_positions.
1264 * xterm.c (handle_one_xevent): Likewise.
1265
2cd98812
DA
12662013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
1267
1268 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
1269 (x_icon_type): Remove prototype.
1270 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
1271 * frame.c (x_icon_type): Remove.
1272 * w32term.c (x_make_frame_visible, x_iconify_frame):
1273 * xterm.c (x_make_frame_visible, x_iconify_frame):
1274 Use x_set_bitmap_icon to factor out common code.
1275
a6c2ee1b
DA
12762013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
1277
1278 * dispextern.h (check_x_display_info, x_get_string_resource):
1279 Declare here just once and unify the latter.
1280 * frame.c (check_x_display_info, x_get_string_resource):
1281 * nsterm.h (check_x_display_info):
1282 * xrdb.c (x_get_string_resource):
1283 * xterm.h (check_x_display_info): Remove prototypes.
1284 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
1285 * w32reg.c (x_get_string_resource): Likewise.
1286 (w32_get_rdb_resource): Adjust user.
1287
baed3603
DA
12882013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 * xterm.h (struct x_display_info): New member
1291 x_pending_autoraise_frame, going to replace...
1292 * xterm.c (pending_autoraise_frame): ...static variable.
1293 (x_new_focus_frame, XTread_socket): Adjust users.
1294 * w32term.h (struct w32_display_info): New member
1295 w32_pending_autoraise_frame, going to replace...
1296 * w32term.c (pending_autoraise_frame): ...global variable.
1297 (x_new_focus_frame, w32_read_socket): Adjust users.
1298
90582f05
GM
12992013-09-17 Glenn Morris <rgm@gnu.org>
1300
1301 * xdisp.c (message_dolog): If we create *Messages*,
1302 switch it to messages-buffer-mode.
1303
b7ad2f74
PE
13042013-09-17 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 Don't overuse 'const' in types of locals.
1307 * bidi.c (bidi_count_bytes):
1308 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
1309 (xg_event_is_for_scrollbar):
1310 * xselect.c (x_handle_property_notify)
1311 (x_handle_selection_notify, x_handle_dnd_message):
1312 * xsettings.c, xsettings.h (xft_settings_event):
1313 * xterm.c (x_handle_net_wm_state, handle_one_event)
1314 (x_menubar_window_to_frame, x_detect_focus_change)
1315 (construct_mouse_click, note_mouse_movement)
1316 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
1317 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
1318 (handle_one_xevent, x_handle_net_wm_state):
1319 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
1320 (x_handle_dnd_message):
1321 Avoid unnecessary 'const', typically the second 'const' in
1322 'const foo * const arg', a 'const' that does not affect the API
1323 and doesn't significantly help the human reader.
1324
19452b86
DA
13252013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
1326
1327 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
1328 only if Glib < 2.36.0.
1329 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
1330 * xsettings.c (init_gconf, init_gsettings): Do not check
1331 for g_type_init.
1893694e
DA
1332 * xterm.c (handle_one_xevent): Do not call to x_clear_area
1333 if GTK >= 2.7.0.
33b83dd7 1334 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 1335
6434e343
JD
13362013-09-16 Jan Djärv <jan.h.d@swipnet.se>
1337
3f386383
JD
1338 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
1339 before calling g_type_init.
1340
6434e343
JD
1341 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
1342
1343 * nsterm.m (syms_of_nsterm): ... to here.
1344
83a119f8
DA
13452013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
1346
1347 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
1348 (ignore_next_mouse_click_timeout): Use Time as X does.
1349 (handle_one_xevent): Avoid cast and use unsigned comparison.
1350
61582e6a
DA
13512013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
1352
1353 Do not copy X event in handle_one_xevent except KeyPress case.
1354 Wnen XEvent is processed, it is unlikely to be changed except
1355 KeyPress case, so we can avoid copying and use const pointer to
1356 const data to make sure that an event is not changed elsewhere.
1357 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
1358 const' and do not create local copy except for the KeyPress event.
1359 Use casts to avoid a few glitches. Adjust formatting. Add comments.
1360 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
1361 (x_handle_net_wm_state, x_menubar_window_to_frame)
1362 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
1363 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
1364 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
1365 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
1366 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
1367 (x_handle_dnd_message):
1368 * xsettings.c (xft_settings_event):
1369 Use 'const XEvent * const' where appropriate.
1370 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
1371
f8eb1572
DA
13722013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 Fix X event waiting to handle multiple frames.
1375 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
1376 * xterm.c (pending_event_wait): Remove. Adjust users.
1377 (x_detect_focus_change): Pass frame arg.
1378 (handle_one_xevent): Find related frame early and clear per-frame
1379 wait_event_type only if this is an event for the relevant frame.
1380 (x_wait_for_event): Use per-frame wait_event_type.
1381
3fa2054e
JD
13822013-09-15 Jan Djärv <jan.h.d@swipnet.se>
1383
745d3809
JD
1384 * nsfns.m (Fx_create_frame): Fix font driver registration for
1385 GNUStep.
1386
1387 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
1388 for syms_of_macfont.
1389
3fa2054e
JD
1390 * nsterm.m: Include macfont.h.
1391 (ns_tmp_flags, ns_tmp_font): Remove.
1392 (ns_compute_glyph_string_overhangs): Check for driver Qns.
1393 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
1394 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
1395 (changeFont:): Fix code style. Check for font driver type when
1396 getiing font.
1397
1398 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
1399 (f)->descent.
1400
1401 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
1402 (nsfont_open): Set font driver type.
1403 Set font->ascent and font->descent. Figure out font instead of
1404 ns_tmp_font, and flags instead of ns_tmp_flags.
1405 Fix indentation. Remove call to ns_draw_text_decoration,
1406 moved to nsterm.
1407
1408 * nsfns.m: Include macfont.h.
1409 (Fx_create_frame): Register macfont driver, make a better default font.
1410 (Fns_popup_font_panel): Get font from macfont driver, if used.
1411
1412 * macfont.m, macfont.h, maccuvs.h: New files.
1413
1414 * font.h: Declare syms_of_macfont.
1415
1416 * font.c (syms_of_font): Call syms_of_macfont.
1417
1418 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
1419
0eed0355
DA
14202013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
1421
1422 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
1423 and it is always zero for others, so I assume that this is an ancient
1424 leftover which nobody will want to change any more.
1425 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
1426 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
1427 * frame.c (x_set_scroll_bar_width):
1428 * w32fns.c (w32_createscrollbar):
1429 * w32term.c (w32_set_vertical_scroll_bar):
1430 * xfns.c (x_set_scroll_bar_default_width):
1431 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
1432 (x_scroll_bar_expose): Related users changed.
1433
07013c68
DA
14342013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
1437 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
1438 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
1439 Define as such.
c7cc32f7
DA
1440 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
1441 Define once here...
1442 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
1443 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
1444 Remove unused Xisms.
7f09455e
DA
1445 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
1446 these modules are never compiled otherwise.
07013c68 1447
0df00f59
EZ
14482013-09-14 Eli Zaretskii <eliz@gnu.org>
1449
08a209bf 1450 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
1451 Doc fix. (Bug#15375)
1452
fcd42c11
DA
14532013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1454
1455 Unify Fx_focus_frame between all ports.
1456 * frame.h (x_focus_frame): New prototype.
1457 * xfns.c (Fx_focus_frame): Remove.
1458 (syms_of_xfns): Do not defsubr it.
1459 (x_focus_frame): X implementation.
1460 * nsfns.m (Fx_focus_frame): Remove.
1461 (syms_of_nsfns): Do not defsubr it.
1462 (x_focus_frame): NS implementation.
1463 * w32term.c (Fx_focus_frame): Remove.
1464 (x_focus_on_frame): Rename to...
1465 (x_focus_frame): W32 implementation.
1466 * w32term.h (x_focus_on_frame): Remove prototype.
1467 * w32fns.c (Fx_focus_frame): Remove.
1468 (syms_of_w32fns): Do not defsubr it.
1469 * frame.c (Fx_focus_frame): Define here.
1470 (syms_of_frame): Defsubr here.
1471 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
1472
aad3612f
DA
14732013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1474
1475 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
1476 All of them are replaced with FRAME_DISPLAY_INFO, defined in
1477 each port to reference the port-specific window system data.
1478 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
1479 (FRAME_DISPLAY_INFO): Define.
1480 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
1481 (FRAME_DISPLAY_INFO): Define. Adjust users.
1482 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
1483 (FRAME_DISPLAY_INFO): Define. Adjust users.
1484 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
1485 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
1486 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
1487 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
1488 * xselect.c, xterm.c: All related users changed.
1489
9a650e62
DA
14902013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1491
1492 * xterm.h (x_window_to_frame, x_any_window_to_frame)
1493 (x_menubar_window_to_frame): Remove prototypes.
1494 * xfns.c (x_window_to_frame, x_any_window_to_frame)
1495 (x_menubar_window_to_frame, x_top_window_to_frame):
1496 Move from here...
1497 * xterm.c (x_window_to_frame, x_any_window_to_frame)
1498 (x_menubar_window_to_frame, x_top_window_to_frame):
1499 ...to here and convert all but the last to static.
1500
347ae3e1
EZ
15012013-09-12 Eli Zaretskii <eliz@gnu.org>
1502
1503 * lisp.mk (lisp): Add w32-common-fns.elc.
1504
15c6d837
XF
15052013-09-12 Xue Fuqiao <xfq.free@gmail.com>
1506
1507 * charset.c (char_charset): Document an exception for char-charset.
1508
27e90f77
DA
15092013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1510
1511 * xterm.h (x_display_info): New field last_user_time...
1512 * xterm.c (toplevel): ...to replace static last_user_time.
1513 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
1514
8ffbc36b
DA
15152013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1516
1517 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
1518 scroll bar values to prevent thumb from disappear and update comment.
1519
5ec0337a
GM
15202013-09-11 Glenn Morris <rgm@gnu.org>
1521
1522 * emacs.c (usage_message): Possessive apostrophe tweak.
1523
fb55b9d1
DA
15242013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1525
8d2db8be
DA
1526 * nsterm.m (syms_of_nsterm): Use Qns.
1527 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
1528 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
1529 * xfns.c (x_display_info_for_name, Fx_open_connection):
1530 Remove old '#if 0' code.
1531 (syms_of_xfns): Use Qx.
fb55b9d1
DA
1532 * termhooks.h (fullscreen_hook): Remove the leftover.
1533 (struct terminal): Fix typo in comment.
1534
927eec55
DA
15352013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1536
1537 Cleaning up a few X scroll bar bits.
1538 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
1539 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1540 New member last_seen_part, going to replace...
1541 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
1542 (xt_action_hook) [USE_LUCID]: Adjust user.
1543 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
1544 Lucid-specific scroll bar support.
1545 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
1546 to int and adjust to use last_seen_part member.
1547 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
1548 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1549 Initialize last_seen_part.
1550
71b28baa
SM
15512013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1552
1553 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
1554 insert-buffer-substring an empty string.
1555
f5dacaae
PE
15562013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
1559 avoiding a GCC warning.
1560
742516e0
DA
15612013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1562
1563 Ifdef away frame tool bar code when it is not really used.
1564 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
1565 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
1566 and minimize_tool_bar_window_p under the above.
1567 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1568 (fset_tool_bar_window): Likewise.
1569 * dispnew.c (clear_current_matrices, clear_desired_matrices)
1570 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
1571 (change_frame_size_1):
1572 * window.c (window_from_coordinates, Frecenter): Adjust users.
1573 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
1574 code is not really used.
1575 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
1576 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
1577 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
1578 [!USE_GTK && !HAVE_NS]: Define as such.
1579 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
1580 (note_mouse_highlight, expose_frame):
1581 * xfns.c (x_set_tool_bar_lines):
1582 * xterm.c (handle_one_xevent): Adjust users.
1583
73f82c7e
PE
15842013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 Fix corruption with multiple emacsclient -t instances (Bug#15222).
1587 This bug was introduced by my 2013-08-26 patch, which incorrectly
1588 assumed that the terminfo implementation doesn't use termcap buffers.
1589 * term.c (init_tty) [TERMINFO]: Remove optimization, as
1590 these buffers apparently are used after all.
1591 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
1592 (struct tty_display_info): Define members termcap_term_buffer and
1593 termcap_strings_buffer even if TERMINFO.
1594
53482f41
DA
15952013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1596
1597 Fix last change.
1598 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
1599 'usage' docstring entry to pacify make-docfile.
1600
16012013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
1602
1603 Change comparison functions =, <, >, <=, >= to take many arguments.
1604 * data.c: Change comparison functions' interface and implementation.
1605 * lisp.h: Make arithcompare available for efficient two arg
1606 comparisons.
1607 * bytecode.c: Use arithcompare.
1608 * fileio.c: Use new interface.
1609
533f258f
SM
16102013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1611
1612 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
1613
8c27f5ff
SM
16142013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
1615
1616 * eval.c (Feval): Document the new use of `lexical'.
1617
0750a308
DA
16182013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1619
1620 Review and drop old frame resize hack.
1621 * frame.h (struct frame): Remove force_flush_display_p.
1622 * dispnew.c (update_frame): Adjust user and don't call
1623 flush_frame here. The comment has said that there was an issues
1624 with redisplaying fringes, but I don't see any differences with
1625 and without this hack. Hopefully we can continue without it.
1626 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
1627 current frame matrices twice if resized_p is set.
1628
83fc0554
DA
16292013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1630
1631 Do not populate pure Xism x_sync to other ports.
1632 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
1633 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
1634 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
1635 * w32term.h (x_sync): Remove prototype.
1636
fd462129
DA
16372013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1638
1639 Cleanup frame flushing.
8c27f5ff
SM
1640 * dispextern.h (struct redisplay_interface):
1641 Drop flush_display_optional because flush_display is enough
fd462129
DA
1642 for X and flushing via RIF is just a no-op for others.
1643 * frame.h (flush_frame): New function.
1644 * dispnew.c (update_frame):
1645 * minibuf.c (read_minibuf):
1646 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
1647 Use it.
1648 * keyboard.c (detect_input_pending_run_timers): Do not flush
1649 all frames but selected one in redisplay_preserve_echo_area.
1650 * nsterm.m (ns_flush): Remove no-op.
1651 (ns_redisplay_interface): Adjust user.
1652 * w32term.h (x_flush): Remove no-op.
1653 (w32_redisplay_interface): Adjust user.
1654 * xterm.c (x_flush): Simplify because we do not flush all
1655 frames at once any more. Adjust comment.
1656 (x_redisplay_interface): Adjust user.
1657
4b73fc73
PE
16582013-09-07 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 Port --without-x --enable-gcc-warnings to Fedora 19.
1661 * gfilenotify.c (globals_of_gfilenotify):
1662 Call g_type_init only if using an older glib version that needs it.
1663
77394d40
DA
16642013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1665
1666 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1667 (last_glyphless_glyph_merged_face_id): Remove declarations.
1668 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
1669 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1670 (last_glyphless_glyph_merged_face_id): Now static.
1671 (merge_escape_glyph_face): New function, refactored from...
1672 (get_next_display_element): ...here.
1673 (merge_glyphless_glyph_face): New function, refactored from...
1674 (produce_glyphless_glyph): ...here...
1675 * term.c (produce_glyphless_glyph): ...and here.
1676
306d67bd
SM
16772013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
1678
1679 * eval.c (eval_sub): Only call Ffunction if necessary.
1680
7f6c6450
DA
16812013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1682
1683 Attempt to make redisplay more selective when changing cursor type.
1684 * frame.h (struct frame): New bitfield cursor_type_changed.
1685 * xdisp.c (cursor_type_changed): Remove.
1686 (try_cursor_movement, redisplay_window, try_window_id)
1687 (set_frame_cursor_types, try_window_reusing_current_matrix):
1688 Adjust to use per-frame bitfield.
1689 (redisplay_internal): Look for cursor type change on each visible
1690 frame and consider all frames if cursor type has been changed on
1691 the frame other than selected. If cursor type has been changed on
1692 selected frame only, do not use fast update.
1693
bd0443bb
DA
16942013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1695
1696 Attempt to make redisplay more selective when changing fonts.
1697 * frame.h (struct frame): New bitfield fonts_changed.
1698 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
1699 (adjust_frame_glyphs): Add prototype.
1700 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 1701 (adjust_glyphs): Remove because we do not
bd0443bb
DA
1702 adjust matrices on all frames at once any more.
1703 (adjust_frame_glyphs): Block and unblock input here.
1704 (adjust_glyph_matrix): Use fonts_changed.
1705 (change_frame_size_1): Use adjust_frame_glyphs.
1706 * font.c (font_open_entity): Use fonts_changed.
1707 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
1708 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1709 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
1710 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
1711 (shrink_mini_window, Fresize_mini_window_internal)
1712 (window_scroll_pixel_based, Fset_window_configuration)
1713 (apply_window_adjustment, Fset_window_vscroll):
1714 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1715 Use adjust_frame_glyphs.
1716 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
1717 (try_window_reusing_current_matrix, try_window_id, display_line)
1718 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
1719 (redisplay_internal): Consider fonts_changed and adjust frame
1720 matrices for each frame only if the frame is visible. If font
1721 has been changed on some frame during full redisplay, retry
1722 only visible frames where the font has been actually changed.
1723
b9695828
DA
17242013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1725
1726 Cache current header and mode line height for each window.
1727 * window.h (struct window): New fields mode_line_height
1728 and header_line_height.
1729 * window.c (make_window): Initialize them.
1730 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
1731 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
1732 (current_mode_line_height, current_header_line_height):
1733 Remove declaration.
1734 * xdisp.c (current_mode_line_height, current_header_line_height):
1735 Remove.
1736 (pos_visible_p, init_xdisp): Adjust user.
1737 (redisplay_window): Invalidate mode_line_height and
1738 header_line_height if current and desired matrices do not agree.
1739
66738305
DA
17402013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1741
1742 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
1743 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
1744
257b3b03
DA
17452013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1746
1747 Make --without-x compatible with --enable-gcc-warnings.
1748 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
1749 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
1750 members under HAVE_WINDOW_SYSTEM.
1751 * keyboard.c (make_lispy_focus_out): Likewise.
1752 (record_menu_key): Move under HAVE_MENUS.
1753 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
1754 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
1755 (syms_of_xdisp): Adjust user.
1756 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
1757 (start_hourglass, cancel_hourglass):
1758 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
1759 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
1760 and CLEAR_FONT_TABLE_NFONTS.
1761 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
1762 Declare only if HAVE_WINDOW_SYSTEM.
1763 (lface_same_font_attributes_p, clear_face_gcs): Define only
1764 if HAVE_WINDOW_SYSTEM.
1765
98b7f4bd
DA
17662013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1767
1768 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
1769 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
1770 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
1771
a7e43722
SM
17722013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
1773
1774 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
1775
0c90b9ee
PE
17762013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
1779 This fixes a type error on hosts where ptrdiff_t is wider than int.
1780
d99760fa
SM
17812013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1782
6629638e
SM
1783 * keyboard.c (read_key_sequence_vs): New function.
1784 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
1785 common code.
1786
d99760fa
SM
1787 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1788
224e313d
PE
17892013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 Makefile improvements.
1792 * Makefile.in (config.status): Don't use double-colon rules, as
1793 they are not portable according to POSIX. Fix shell typo with `;
1794 I guess this rule has never been tested?
1795 (VCSWITNESS): New macro, to override any environment var.
1796
6d6ed1af
DA
17972013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1798
1799 * xterm.h (struct x_display_info): Do not track X connection
1800 fd separately because it is always available from Display.
1801 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1802 Adjust users.
1803
bc923770
DA
18042013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1805
1806 * buffer.c (drop_overlay):
1807 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1808 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1809
b1cf96de
DA
18102013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1811
1812 * buffer.c (Fmake_overlay, Fmove_overlay):
1813 * intervals.c (set_point_from_marker):
1814 * print.c (PRINTPREPARE): Prefer signal_error
1815 to plain error and report unsuitable marker too.
1816
d1fc6c21
DA
18172013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1818
1819 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1820 for 'dragging' member.
d1ae6a0b
DA
1821 (struct x_output): Remove set-but-unused leftovers
1822 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1823 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1824 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1825 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1826 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1827 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1828 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1829 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1830 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1831
0ce9f6de
JD
18322013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1833
1834 * nsfont.m (INVALID_GLYPH): New define.
1835 (nsfont_encode_char): Use INVALID_GLYPH.
1836 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1837
b594a96c
DA
18382013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1839
1840 * xterm.c (x_last_mouse_movement_time): Revert last change.
1841 This code should use XDisplayMotionBufferSize to check display's
1842 motion history first, and there are few other issues as well.
1843 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1844 (handle_one_xevent): Adjust user.
1845
8b098236
MR
18462013-09-02 Martin Rudalics <rudalics@gmx.at>
1847
9718b207
MR
1848 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1849 * frame.c (Flast_nonminibuf_frame): ... to here.
1850 (check_minibuf_window): Don't abort if no window was found
1851 (Bug#15247).
8b098236 1852
84e70bba
DA
18532013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1854
1855 Use XGetMotionEvents to ask the last mouse motion time from X server.
1856 * xterm.c (X_MOTION_HISTORY): Default to 1.
1857 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1858 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1859 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1860 Ifdef away legacy code.
1861 (XTmouse_position, x_scroll_bar_report_motion):
1862 Use x_last_mouse_movement_time.
fc85e20b
DA
1863 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1864 UnmapNotify event.
84e70bba 1865
1fccc530
DA
18662013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1867
1868 * msdos.c (last_mouse_window): Move to...
1869 (dos_rawgetc): ...this function and adjust comment.
1870 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1871 (mouseMoved): ...this function and adjust comment.
1872 * w32term.c (last_window): Likewise with...
1873 (w32_read_socket): ...this function.
1874 * xterm.c (last_window): Likewise with...
1875 (handle_one_xevent): ...this function.
1876
0ab10992
DA
18772013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1878
b7da754d 1879 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1880 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1881 (handle_one_xevent): ...to here.
1882 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1883 otherwise.
1884
0c7f856e
DA
18852013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1886
1887 * msdos.c (IT_set_terminal_window): Remove no-op.
1888 (initialize_msdos_display): Adjust terminal setup.
1889 * w32console.c (w32con_set_terminal_window): Remove no-op.
1890 (initialize_w32_display): Adjust terminal setup.
1891 * w32term.c (w32_set_terminal_window): Remove no-op.
1892 (w32_create_terminal): Adjust terminal setup.
1893 * xterm.c (XTset_terminal_window): Remove no-op.
1894 (x_create_terminal): Adjust terminal setup.
1895
a892a94c
DA
18962013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1897
1898 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1899 Remove no-ops.
1900 (ns_create_terminal): Adjust terminal setup.
1901 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1902 Remove no-ops.
1903 (w32_create_terminal): Adjust terminal setup.
1904 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1905 Remove no-ops.
1906 (x_create_terminal): Adjust terminal setup.
1907
cf91889a
DA
19082013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1909
1910 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1911 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1912 * dispnew.c (buffer_posn_from_coords):
1913 * window.c (Fwindow_end, displayed_window_lines):
1914 * xdisp.c (redisplay_mode_lines): Use it.
1915
5b0891df
JD
19162013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1917
1918 * fontset.c (face_for_char): Check char in the current face font first
1919 if HAVE_NS (Bug#15138).
1920
0a357e98
MR
19212013-08-31 Martin Rudalics <rudalics@gmx.at>
1922
1923 * window.c (temp_output_buffer_show): Make sure window returned
1924 by display_buffer is live (Bug#15213).
1925
9d7693d7
DA
19262013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 Minor cleanup to avoid forward declarations.
1929 * coding.h (struct ccl_spec): Remove forward declaration.
1930 * composite.h (toplevel): Include font.h.
1931 (struct composition_it, struct face, struct font_metrics):
1932 Remove forward declaration.
1933 * dispextern.h (struct image, struct atimer): Likewise.
1934 * emacsgtkfixed.h (struct frame): Likewise.
1935 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1936 * font.h (struct font_driver, struct font, struct glyph_string)
1937 (struct face): Remove forward declaration.
1938 * fontset.h (struct face, struct font): Likewise.
1939 * frame.h (toplevel): Style cleanup.
1940 (enum output_method): Move to...
1941 * termhooks.h (enum output_method): ...here.
1942 (struct glyph, struct frame, struct ns_display_info)
1943 (struct x_display_info, struct w32_display_info):
1944 Remove forward declaration.
1945 * xterm.h (toplevel): Include termhooks.h.
1946 (struct font, struct window, struct glyph_matrix, struct frame)
1947 (struct input_event, struct face, struct image): Remove forward
1948 declaration.
1949 * gtkutil.h (struct _widget_value): Likewise.
1950 * keyboard.h (toplevel): Include termhooks.h.
1951 (struct input_event): Remove forward declaration.
1952
032f7451
DA
19532013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1954
1955 * intervals.c (set_point_from_marker): New function.
1956 * editfns.c (Fgoto_char):
1957 * process.c (Finternal_default_process_filter):
1958 * window.c (select_window_1): Use it.
1959 * buffer.h (set_point_from_marker): Add prototype.
1960
3f940c5a
EZ
19612013-08-29 Eli Zaretskii <eliz@gnu.org>
1962
1963 * w32.c (term_winsock): Call release_listen_threads before calling
1964 WSACleanup.
1965 (_sys_wait_accept): Wait for accept event in a loop with a finite
1966 timeout, instead of waiting indefinitely. Will hopefully avoid
1967 hanging during exit because WSACleanup deadlocks waiting for the
1968 event object to be released. (Bug#14333)
1969
1970 * w32proc.c (release_listen_threads): New function, signals all
1971 the reader threads that listen for connections to stop waiting.
1972
1973 * w32.h (release_listen_threads): Add prototype.
1974
101ed2bb
DA
19752013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1976
1977 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1978 field of new marker (for sanity and safety).
20de2834
DA
1979 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1980 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1981
1f5cf200
DA
19822013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1983
1984 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1985 (x_after_update_window_line, x_scroll_bar_create):
1986 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1987 (handle_one_xevent, x_clear_frame_area):
1988 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1989 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1990 * xterm.h (x_clear_area): Adjust prototype.
1991
d2b36813
DA
19922013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1993
1994 Hook scanning and indentation functions to find_newline. This helps
1995 to avoid duplicated code and renders more respect to newline cache.
1996 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1997 * cmds.c (Fforward_line):
1998 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1999 Use find_newline and avoid unnecessary point movements.
2000 * search.c (scan_newline): Implement on top of find_newline.
2001
3ec7babc
SM
20022013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
2003
2004 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
2005 scoped code (bug#11258).
2006
5ab473cd
JD
20072013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
2008
2009 * nsterm.m (last_window): New variable.
2010 (EV_TRAILER2): New macro.
2011 (EV_TRAILER): Call EV_TRAILER2.
2012 (mouseMoved:): Add support for mouse-autoselect-window
2013 on nextstep (Bug#6888).
2014
78779650
AS
20152013-08-28 Andreas Schwab <schwab@suse.de>
2016
2017 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
2018 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
2019 Remove unused macro definitions.
2020 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
2021 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
2022 Only define if emacs.
78779650 2023
c3c4768d
DA
20242013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2025
2026 Prefer enum glyph_row_area to int where appropriate.
2027 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
2028 Fix comment.
2029 (window_box, window_box_width, window_box_left, window_box_left_offset)
2030 (window_box_right, window_box_right_offset): Adjust prototypes.
2031 * xdisp.c (window_box, window_box_width, window_box_left)
2032 (window_box_left_offset, window_box_right, window_box_right_offset):
2033 Use enum glyph_row_area. Adjust users and tweak comment where needed.
2034 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
2035 * nsterm.m (ns_clip_to_row):
2036 * w32term.c (w32_clip_to_row):
2037 * xterm.c (x_clip_to_row): Likewise.
2038
6bdcbfe1
DA
20392013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2040
2041 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
2042 (Fprevious_overlay_change): Fast path for buffer with no overlays.
2043
50b13cde
PE
20442013-08-28 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
2047 for portability to hosts where /bin/sh has problems.
2048
f60e429a
DA
20492013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2050
2051 Redesign redisplay interface to drop global output_cursor.
2052 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
2053 (toplevel): Remove declaration of output_cursor.
2054 (set_output_cursor, x_cursor_to): Remove prototype.
2055 * window.h (struct window): New member output_cursor.
2056 (output_cursor_to): New function to replace RIF member.
2057 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
2058 (update_text_area, set_window_cursor_after_update): Use it.
2059 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
2060 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2061 * nsterm.m (ns_update_window_begin, ns_update_window_end):
2062 * w32term.c (x_update_window_begin, x_update_window_end):
2063 * xterm.c (x_update_window_begin, x_update_window_end):
2064 Adjust to use per-window output cursor.
2065
43aac990
PE
20662013-08-27 Paul Eggert <eggert@cs.ucla.edu>
2067
d486344e
PE
2068 Simplify SELECT_TYPE-related code.
2069 Like EMACS_TIME, this portability layer is no longer needed, since
2070 Emacs has been using fd_set as a portability layer for some time.
2071 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
2072 (SELECT_TYPE): Remove. All uses changed to fd_set.
2073 (fd_set) [!FD_SET]: New typedef.
2074
43aac990
PE
2075 Simplify EMACS_TIME-related code.
2076 This portability layer is no longer needed, since Emacs has been
2077 using struct timespec as a portability layer for some time.
2078 * atimer.h, buffer.h, dispextern.h, xgselect.h:
2079 Include <time.h> rather than "systime.h"; that's all that's needed now.
2080 * dispnew.c: Include <timespec.h> rather than "systime.h";
2081 that's all that's needed now.
2082 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
2083 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
2084 TIMESPEC_RESOLUTION.
2085 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
2086 LOG10_TIMESPEC_RESOLUTION.
2087 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
2088 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
2089 (make_emacs_time): Remove. All used changed to make_timespec.
2090 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
2091 (current_timespec): Rename from current_emacs_time. All uses changed.
2092 (add_emacs_time): Remove. All uses changed to timespec_add.
2093 (sub_emacs_time): Remove. All uses change dot timespec_sub.
2094 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
2095 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
2096 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
2097 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
2098 (current_timespec): Rename from current_emacs_time. All uses changed.
2099 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
2100 changed to timespec_cmp.
2101 * xgselect.c: Include <timespec.h>, since our .h files don't.
2102
d350e350
DA
21032013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2104
2105 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
2106 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
2107 Remove the leftovers.
2108 * gtkutil.c (toplevel): Do not declare Qxft but include
2109 font.h to do so.
2110 * image.c (toplevel): Do not declare Vlibrary_cache because
2111 it's already done in lisp.h.
2112
9fed9729
DA
21132013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2114
2115 * lisp.h (Mouse_HLInfo): Move from here...
2116 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
2117 (reset_mouse_highlight): New function.
2118 * msdos.c (dos_set_window_size, IT_update_begin)
2119 (internal_terminal_init):
2120 * nsterm.m (ns_update_window_end, x_free_frame_resources)
2121 (ns_initialize_display_info):
2122 * w32console.c (initialize_w32_display):
2123 * w32term.c (x_update_window_end, x_free_frame_resources)
2124 (w32_initialize_display_info):
2125 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
2126 * window.c (Fdelete_other_windows_internal):
2127 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
2128 * termchar.h (toplevel):
2129 * xterm.h (toplevel): Include dispextern.h.
2130
f462f075
PE
21312013-08-26 Paul Eggert <eggert@cs.ucla.edu>
2132
2133 Fix minor problems found by static checking.
2134 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
2135 (expect): Avoid nested-if warning.
2136 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
2137 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
2138 * nsterm.h, nsterm.m (ns_select):
2139 * xgselect.c, xgselect.h (xg_select):
2140 Adjust signature to better match pselect's.
2141 * nsterm.m (ns_select):
2142 Don't set *TIMEOUT, since pselect doesn't.
2143 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
2144 diagnostic about assigning const char * to it.
2145 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
2146
068f9124
SM
21472013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
2148
2149 * lread.c (substitute_object_recurse): Handle hash-tables as well
2150 (bug#15190).
2151
f5adc984
PE
21522013-08-26 Paul Eggert <eggert@cs.ucla.edu>
2153
1fc8eb33
PE
2154 Fix unlikely core dump in init_tty, and simplify terminfo case.
2155 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
2156 The old version incorrectly dumped core if malloc returned a
2157 buffer containing only non-NUL bytes.
2158 (init_tty): Do not allocate or free termcap buffers; the
2159 struct does that for us now.
2160 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
2161 (struct tty_display_info): Define members termcap_term_buffer and
2162 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
2163 use them. Allocate them directly in struct rather than indirectly
2164 via a pointer, to simplify init_tty.
2165
f5adc984
PE
2166 * frame.c (check_minibuf_window): Initialize 'window' properly,
2167 so that Emacs reliably aborts later if 'window' is not initialized.
2168
efec3894
JD
21692013-08-26 Jan Djärv <jan.h.d@swipnet.se>
2170
2171 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
2172 of VoidSymbol (Bug#15154).
2173
e1d0341e
DA
21742013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
2175
2176 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
2177 mouse_face_beg_y and mouse_face_end_y.
2178 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
2179 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
2180 Adjust users and update comment where appropriate.
2181
bfff6445
MR
21822013-08-26 Martin Rudalics <rudalics@gmx.at>
2183
2184 * frame.c (check_minibuf_window): New function.
068f9124
SM
2185 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
2186 Call check_minibuf_window (Bug#15183).
bfff6445 2187
c80016b3
DA
21882013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
2189
2190 * window.h (struct window): Replace last_cursor with last_cursor_vpos
2191 because this is the only last cursor data we need to keep and consult.
2192 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
2193 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
2194 Adjust users.
2195
de396731
DA
21962013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
2197
068f9124
SM
2198 Fix recovering from possible decompression error.
2199 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 2200 the position where the partially decompressed data ends, and
447218dd 2201 should count how many bytes was produced so far.
de396731
DA
2202 * decompress.c (struct decompress_unwind_data): Add nbytes member.
2203 (unwind_decompress): Really delete partially uncompressed data.
2204 (Fzlib_decompress_region): Take decompressed data size into account.
2205
c76826d9
DA
22062013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
2207
2208 * syntax.c (init_syntax_once): Adjust comment and do an early
2209 initialization of Qchar_table_extra_slots just once...
2210 * casetab.c (init_casetab_once):
2211 * category.c (init_category_once):
2212 * character.c (syms_of_character):
2213 * coding.c (syms_of_coding):
2214 * xdisp.c (syms_of_xdisp): ...and omit it here.
2215
b34454d0
EZ
22162013-08-24 Eli Zaretskii <eliz@gnu.org>
2217
11f20add
EZ
2218 * xdisp.c (get_next_display_element): Don't apply to characters
2219 from a display vector the logic of setting it->end_of_box_run_p
2220 suitable for characters from a buffer. (Bug#15175)
2221
b34454d0
EZ
2222 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
2223 to handle directories, rather than '_utime' which doesn't.
2224 (Bug#15176)
2225
6e1b469e
JD
22262013-08-24 Jan Djärv <jan.h.d@swipnet.se>
2227
2228 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
2229 or fullscreen (Bug#14627).
2230
9c05bccf
PE
22312013-08-24 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 System-dependent integer overflow fixes.
2234 * process.c (Fset_process_window_size): Signal an error if
2235 the window size is outside the range supported by the lower level.
2236 * sysdep.c (set_window_size): Return negative on error,
2237 nonnegative on success, rather than -1, 0, 1 on not in system,
2238 failure, success. This is simpler. Caller changed.
2239 (serial_configure): Remove unnecessary initialization of local.
2240 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
2241 size fits in unsigned long; this isn't true on some 32-bit hosts.
2242 Avoid buffer overrun if some future version of /proc/meminfo has a
2243 variable name longer than 20 bytes.
2244 (system_process_attributes) [__FreeBSD__]:
2245 Don't assume hw.availpages fits in 'int'.
2246
c365c355
PE
22472013-08-23 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 Don't let very long directory names overrun the stack.
2250 Fix some related minor problems involving "//", vfork.
2251 * callproc.c (encode_current_directory): New function.
2252 (call_process): Don't append "/"; not needed.
2253 * fileio.c (file_name_as_directory_slop): New constant.
2254 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
2255 this can save the caller having to alloca.
2256 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
2257 Use SAFE_ALLOCA, not alloca.
2258 (directory_file_name, Fexpand_file_name): Leave leading "//"
2259 alone, since it can be special even on POSIX platforms.
2260 * callproc.c (call_process):
2261 * process.c (Fformat_network_address):
2262 * sysdep.c (sys_subshell):
2263 Use encode_current_directory rather than rolling our own.
2264 (create_process): No need to encode directory; caller does that now.
2265 * process.h (encode_current_directory): New decl.
2266 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
2267 Rework to avoid 'goto xyzzy;'.
2268
6c6014d4
EZ
22692013-08-23 Eli Zaretskii <eliz@gnu.org>
2270
2271 * xdisp.c (handle_face_prop): If the default face was remapped use
2272 the remapped face for strings from prefix properties. (Bug#15155)
2273
9997ec56
DA
22742013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
2275
2276 Minor cleanup for redisplay interface and few related functions.
2277 * frame.h (enum text_cursor_kinds): Move from here...
2278 * dispextern.h (enum text_cursor_kinds): ...to here.
2279 (toplevel): Drop unnecessary declarations.
2280 (struct redisplay_interface): Use bool and enum text_cursor_kinds
2281 in update_window_end_hook and draw_window_cursor functions.
2282 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
2283 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
ffb3f67a 2284 * w32term.c (x_update_window_end, w32_draw_window_cursor):
9997ec56
DA
2285 * xterm.c (x_update_window_end, x_draw_window_cursor):
2286 * xdisp.c (display_and_set_cursor, update_window_cursor)
2287 (update_cursor_in_window_tree, x_update_cursor): Use bool and
2288 enum text_cursor_kinds where appropriate.
2289
7f780da6
DA
22902013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
2291
2292 Redesign redisplay interface to drop updated_row and updated_area.
2293 * dispextern.h (updated_row, updated_area): Remove declaration.
2294 (struct redisplay_interface): Pass glyph row and row area parameters
2295 to write_glyphs, insert_glyphs and clear_end_of_line functions.
2296 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2297 Adjust prototypes.
2298 * dispnew.c (updated_row, updated_area): Remove.
2299 (redraw_overlapped_rows, update_window_line): Adjust user.
2300 (update_marginal_area, update_text_area): Likewise. Pass updated row
2301 as a parameter. Prefer enum glyph_row_area to int where appropriate.
2302 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2303 Adjust users.
2304
26495794
PE
23052013-08-22 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 * process.c (flush_pending_output): Remove stub.
2308 All uses removed.
2309
4a88129a
PE
23102013-08-21 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * callproc.c: Fix race that killed background processes (Bug#15144).
2313 (call_process): New arg TEMPFILE_INDEX. Callers changed.
2314 Record deleted process-id in critical section, not afterwards.
2315 Don't mistakenly kill process created by a call-process invocation
2316 that discards output and does not wait.
2317
0c5307b0
DA
23182013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2319
2320 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
2321 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
2322 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
2323 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
2324 to shut up compiler in mark_object.
2325 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
2326
0d7c1e66
PE
23272013-08-21 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
2330 We can't portably rely on PTY_OPEN doing that, even if
2331 it calls posix_openpt with O_CLOEXEC.
2332
3f246b65
KH
23332013-08-20 Kenichi Handa <handa@gnu.org>
2334
2335 * character.c (string_char): Improve commentary.
2336
8c2f38aa
PE
23372013-08-20 Paul Eggert <eggert@cs.ucla.edu>
2338
2339 * image.c (SIGNATURE_DIGESTSIZE): Remove.
2340 (struct animation_cache): Make signature a flexible array member.
2341 All uses changed. This is a tad slower but may insulate us better
2342 from future changes to ImageMagick.
2343
bb566cea
PE
23442013-08-19 Paul Eggert <eggert@cs.ucla.edu>
2345
2346 * image.c: Shrink memory needed for animation cache.
2347 (SIGNATURE_DIGESTSIZE): New constant.
2348 (struct animation_cache): Make 'signature' a fixed size array of bytes.
2349 (imagemagick_create_cache): Copy the signature. This saves
2350 several KB of memory that ImageMagick wastes per signature.
2351 Don't bother updating the update_time, as the caller does that now.
2352 (imagemagick_prune_animation_cache): Don't destroy the signature, as
2353 it's a fixed size struct member now.
2354 (imagemagick_get_animation_cache): Always destroy the signature,
2355 as it's now imagemagick_create_cache's responsibility to copy it.
2356 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
2357 and use memcmp rather than strcmp.
2358 eassert that ImageMagick returns a signature of the specified length.
2359
6da26928
LMI
23602013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2361
2362 * image.c (imagemagick_get_animation_cache): Don't segfault on
2363 each invocation.
453f4022
LMI
2364 (imagemagick_get_animation_cache): Revert to previous definition
2365 so that it actually works. But keep the memory leak fix.
2366 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 2367
22490125
PE
23682013-08-19 Paul Eggert <eggert@cs.ucla.edu>
2369
d0139df5
PE
2370 * image.c: Fix animation cache signature memory leak.
2371 Fix some other minor performance problems while we're at it.
2372 (imagemagick_create_cache): Clear just the members that
2373 need clearing. Don't set update_time, as caller does that now.
2374 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
2375 Simplify by using pointer-to-pointer instead of a prev pointer.
2376 (imagemagick_prune_animation_cache): Use make_emacs_time rather
2377 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
2378 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
2379 it's already a copy. Free the signature probe unless it's cached.
2380
22490125
PE
2381 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
2382 This was introduced by my 2013-08-12 fix for Bug#15035.
2383
deb31e75
DA
23842013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
2385
2386 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
2387 (imagemagick_prune_animation_cache): Now static.
2388
319a4d03
LMI
23892013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
2390
2391 * image.c (imagemagick_get_animation_cache): Don't segfault when
2392 pruning all entries.
2393
f747d82e
KB
23942013-08-18 Ken Brown <kbrown@cornell.edu>
2395
2396 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
2397 static heap if ENABLE_CHECKING is defined.
2398 (max_bss_sbrk_ptr): New variable.
2399 (bss_sbrk): Use it.
2400 (report_sheap_usage): Report maximum static heap usage instead of
2401 ending static heap usage.
2402
d2c28fab
EZ
24032013-08-17 Eli Zaretskii <eliz@gnu.org>
2404
2405 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
2406 of zlib_initialized according to the results of calling
2407 init_zlib_functions.
2408
274ff63f
LMI
24092013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2410
2411 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 2412 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
2413 (imagemagick_load_image): Remove the ping_wand code, which only
2414 apparently saved time on invalid animated images, and slowed down
2415 everything else. Optimise for the common case.
274ff63f 2416
2bede2ed
XF
24172013-08-16 Xue Fuqiao <xfq.free@gmail.com>
2418
70ff8240
XF
2419 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
2420
de179a3e
XF
2421 * editfns.c (insert_before_markers): Mention overlay in the doc string.
2422
2bede2ed
XF
2423 * marker.c (set_marker): Remove documentation of undefined behavior.
2424
703dbeba
LMI
24252013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2426
2427 * image.c (imagemagick_compute_animated_image): Animate correctly
2428 when sub-images are smaller than the main image.
1d18b1e6
LMI
2429 (imagemagick_compute_animated_image): Setting the iterator row to
2430 zero is apparently not allowed.
79670014
LMI
2431 (imagemagick_compute_animated_image): Allow images that say they
2432 have sub-images that are bigger than the main image, but just crop
2433 them.
703dbeba 2434
63216c5e
JD
24352013-08-15 Jan Djärv <jan.h.d@swipnet.se>
2436
2437 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
2438
a5b5f73f
LMI
24392013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2440
2441 * image.c (imagemagick_compute_animated_image): Respect the GIF
2442 disposal methods.
2443
0fe73012
KB
24442013-08-15 Ken Brown <kbrown@cornell.edu>
2445
2446 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
2447 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
2448 needed.
2449
691a357f
PE
24502013-08-15 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 Fix minor problems found by static checking.
2453 * frame.c (delete_frame):
2454 * xdisp.c (next_element_from_display_vector):
2455 Avoid uninitialized local.
2456 * image.c (imagemagick_compute_animated_image): Port to C89.
2457 Prefer usual GNU indentation style for loops.
2458 Be more careful about bizarrely large sizes, by using ptrdiff_t
2459 instead of int.
2460
42fe2e88
DA
24612013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2462
2463 Fix infinite frame selection loop (Bug#15025).
2464 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
2465
d39a3da6
EZ
24662013-08-15 Eli Zaretskii <eliz@gnu.org>
2467
068f9124
SM
2468 * xdisp.c (compute_window_start_on_continuation_line):
2469 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
2470 to make sure we end up setting the window start at the leftmost
2471 visible character of the display line. This avoids funky
2472 horizontal shifting because the window start is not kept on the
2473 same position. (Bug#15090)
05426239
EZ
2474 (next_element_from_display_vector): Support 'box' face attribute
2475 in the face definitions of a display vector. (Bug#15099)
d39a3da6 2476
6e856b69
LMI
24772013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2478
2479 * image.c (imagemagick_compute_animated_image): Implement animated
2480 images (bug#14700).
995be755
LMI
2481 (imagemagick_compute_animated_image): Fix some compilation
2482 warnings. Implement a very simple cache to make the animation
2483 usable at all, but it should be replaced with a per-image cache.
6e856b69 2484
d5a1acfa
DA
24852013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2486
2487 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
2488 to do `for' loops over alist values.
2489 * buffer.h (FOR_EACH_BUFFER):
2490 * process.c (FOR_EACH_PROCESS): Use it.
2491 (handle_child_signal, status_notify, Fget_buffer_process)
2492 (kill_buffer_processes): Use FOR_EACH_PROCESS.
2493
9c253307
DA
24942013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2495
2496 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
2497 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
2498 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
2499 to xzalloc and so avoid redundant call to memset.
2500 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
2501 members because it is allocated with xzalloc and so already zeroed.
2502
05e64f9f
KB
25032013-08-14 Ken Brown <kbrown@cornell.edu>
2504
2505 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
2506 (Bug#15094).
2507
5b71542d
DA
25082013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2509
2510 Utility function and macro to copy Lisp string to C string.
2511 * lisp.h (xlispstrdupa): New macro.
2512 (xlispstrdup): New prototype.
2513 * alloc.c (xlispstrdup): New function.
2514 * callint.c (Fcall_interactively):
2515 * fileio.c (Ffile_name_directory, Fexpand_file_name)
2516 (Fsubstitute_in_file_name):
2517 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
2518 * image.c (x_create_bitmap_from_file):
2519 * w32term.c (w32_term_init):
2520 * xterm.c (x_term_init): Use xlispstrdup.
2521
71530c97
LMI
25222013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2523
4ce82fb8
LMI
2524 * image.c (imagemagick_load_image): Make animated pictures work.
2525 There's still some problems with background color settings, though
2526 (bug#14700).
2527
71530c97
LMI
2528 * decompress.c (unwind_decompress): Always restore point.
2529
7510a061
XF
25302013-08-14 Xue Fuqiao <xfq.free@gmail.com>
2531
2532 * marker.c (set_marker): Reformat documentation.
2533
01c3051f
PE
25342013-08-14 Paul Eggert <eggert@cs.ucla.edu>
2535
aab1fcdf
PE
2536 * xdisp.c (cursor_type_changed): Now static.
2537
01c3051f
PE
2538 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
2539 Use changed. This avoids the need to call xmalloc and for the
2540 caller to call xfree, and avoids memory leaks in some situations.
2541
2084152a
DA
25422013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2543
2544 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
2545 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
2546 (redisplay_window): If window_end_valid is cleared due to non-zero
2547 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
2548 so do not call to try_cursor_movement for that window.
2084152a 2549
02455cb6
DA
25502013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2551
2552 * window.h (struct window): Convert window_end_pos and
2553 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
2554 (wset_window_end_pos, wset_window_end_vpos): Remove.
2555 * dispnew.c (adjust_glyph_matrix):
2556 * window.c (Fwindow_end, replace_window, set_window_buffer)
2557 (make_window):
2558 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
2559 (set_vertical_scroll_bar, redisplay_window, try_window)
2560 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
2561 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
2562 (note_mouse_highlight): Adjust users.
2563 (try_cursor_movement): Likewise. Convert old precondition to eassert.
2564 Add comment.
2565
da5707e8
DA
25662013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2567
2568 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
2569 * image.c (imagemagick_filename_hint): Use `const char *' and
2570 prefer SSDATA to SDATA to avoid warnings.
2571
25554267
DA
25722013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2573
2574 Cleanup window fringes, margins and scroll bars adjustments.
2575 * window.c (set_window_fringes, set_window_margins)
2576 (set_window_scroll_bars, apply_window_adjustment): New functions.
2577 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
2578 (Fset_window_scroll_bars): Use them.
2579
38a2c910
DA
25802013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2581
2582 * window.h (struct window): Convert scroll_bar_width
2583 from Lisp_Object to integer. Adjust comment.
2584 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
2585 Adjust users.
2586 * window.c (wset_scroll_bar_width): Remove.
2587 (make_window): Initialize scroll_bar_width.
2588 (Fsplit_window_internal): Use direct assignment.
2589 (Fset_window_configuration, save_window_save):
2590 Convert Lisp_Object to integer and back where appropriate.
2591 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
2592 bar was actually changed, and mention this in docstring.
2593
2d065031
PE
25942013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * decompress.c: Minor simplifications.
2597 (Fzlib_decompress_region): Don't bother verifying
2598 that avail_out <= UINT_MAX, as that was confusing.
2599 Mention the restriction in a comment instead.
2600 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
2601
a5bd5abb
JD
26022013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2603
2604 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
2605 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
2606
66e7901a
LMI
26072013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2608
2609 * image.c (imagemagick_filename_hint): Check for errors in the
2610 alist structure.
2611
2fa611b7
EZ
26122013-08-13 Eli Zaretskii <eliz@gnu.org>
2613
2614 * window.c (Fwindow_margins): Return nil when there's no marginal
2615 area, as per the documented API.
2616
2617 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
2618 Fmake_vector, as scroll bar's struct members are not all Lisp
2619 objects now. This avoids crashes in GC.
2620
2621 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
2622 bool, so its address could be taken.
2623
8259030d
LMI
26242013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2625
2626 * image.c (imagemagick_filename_hint): New function to possibly
2627 apply `image-content-type-suffixes'.
2628 (imagemagick_load_image): Use it.
2629
866c710e
EZ
26302013-08-13 Eli Zaretskii <eliz@gnu.org>
2631
2632 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
2633 if loading zlib failed.
2634
f10490f0
JD
26352013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2636
96311be7
JD
2637 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
2638 2013-08-13 checkin below. Change bool to BOOL, rule is:
2639 All Obj-C code uses BOOL, except for interfaces callable from C.
2640
f10490f0
JD
2641 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
2642
c8ae93b0
DA
26432013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2644
2645 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
2646 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
2647 bool instead of BOOL.
2648 * w32term.h (struct scroll_bar): Convert fringe_extended_p
2649 from Lisp_Object to bitfield. Adjust comment.
2650 * w32term.c (x_scroll_bar_create): Adjust user.
2651 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
2652 * xterm.c (XTset_vertical_scroll_bar): Likewise.
2653 Use bool for boolean.
2654 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
2655 to `unsigned int' when defining a bitfield.
2656
53b64418
PE
26572013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2658
2659 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
2660
eeaf9bf3
DA
26612013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2662
2663 * window.h (struct window): Convert left_margin_cols and
2664 right_margin_cols from Lisp_Objects to integers. Adjust comment.
2665 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
2666 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
2667 Adjust users.
2668 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
2669 Adjust comment.
2670 (showing_window_margins_p, update_window_line, update_frame_1):
2671 * fringe.c (draw_fringe_bitmap_1):
2672 * xdisp.c (window_box_width): Adjust users.
2673 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
2674 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
2675 Use direct assignment.
2676 (Fset_window_configuration, save_window_save, Fwindow_margins):
2677 Convert Lisp_Object to integer and back where appropriate.
2678 (Fset_window_margins): Adjust user. Return t if any margin
2679 was actually changed, and mention this in docstring.
2680
956720af
XF
26812013-08-13 Xue Fuqiao <xfq.free@gmail.com>
2682
f73f4ce6 2683 * syntax.c (forward_word):
956720af
XF
2684 * cmds.c (forward_char, backward_char): Mention the optional argument.
2685
9e37ee3b
DA
26862013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2687
2688 * window.h (struct window): Convert left_fringe_width
2689 and right_fringe_width from Lisp_Objects to integers.
2690 Adjust comment.
2691 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
2692 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
2693 * window.c (wset_left_fringe_width, wset_right_fringe_width):
2694 Remove.
2695 (make_window): Initialize new integer fields to -1.
2696 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
2697 (Fset_window_configuration, save_window_save):
2698 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
2699 (Fset_window_fringes): Adjust user. Return t if any fringe
2700 was actually changed, and mention this in docstring.
2701
e4375ca7
DA
27022013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2703
2704 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
2705 * nsfns.m (x_set_cursor_type):
2706 * w32fns.c (x_set_cursor_type):
e903c210 2707 * xfns.c (x_set_cursor_type): Do not set cursor_type_changed here...
9cda66e4 2708 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 2709
a45543bc
DA
27102013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2711
2712 * font.c (clear_font_cache): New function, stripped from...
2713 (Fclear_font_cache): ...here, which now uses the function
2714 above. Adjust comment.
2715 * font.h (clear_font_cache): Add prototype.
2716 * xfaces.c (clear_face_cache): Use clear_font_cache.
2717
ae966a86
DA
27182013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2719
2720 * window.c (Fset_window_start): Compare `w', not `window' because
2721 `w' might not be equal to `window' after call to decode_live_window.
2722
297a545b
PE
27232013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2724
2725 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
2726 This fixes a problem introduced by the Bug#15035 patch
2727 when using GPG. Reported by Herbert J. Skuhra.
2728
aa942e2b
EZ
27292013-08-12 Eli Zaretskii <eliz@gnu.org>
2730
2731 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
2732 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
2733 not yet initialized.
2734
7699d09e
LMI
27352013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2736
2737 * decompress.c (Fzlib_decompress_region): Support zlib
2738 decompression, too, and rename.
2739
1d238bc7
PE
27402013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2741
2742 Minor zlib configuration tweaks.
2743 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
2744 Don't assume presence of fn_inflateInit2_ zlib internal function.
2745
8a44a184
LMI
27462013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2747
2748 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
2749 include the zlib prefix.
2750
594a4307
EZ
27512013-08-12 Eli Zaretskii <eliz@gnu.org>
2752
2753 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
2754 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
2755 define static variables that are pointers to zlib functions to be
2756 dynamically loaded.
2757 (init_zlib_functions) [WINDOWSNT]: New function.
2758 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
2759 New macros.
2760 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
2761 macros instead of invoking the zlib functions directly.
068f9124
SM
2762 (syms_of_decompress): DEFSYM Qzlib_dll.
2763 Staticpro Szlib_available_p.
594a4307 2764
d2e113bc
DA
27652013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
2766
2767 Avoid looping over all frame windows to freeze and unfreeze.
2768 * window.h (struct window): Drop frozen_window_start_p.
2769 (freeze_window_starts): Drop prototype.
2770 * frame.h (struct frame): New frozen_window_starts flag.
2771 (FRAME_WINDOWS_FROZEN): New macro.
2772 * window.c (freeze_window_start, freeze_window_starts):
2773 Remove.
2774 (select_window, replace_window): Adjust users.
2775 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2776 (window_frozen_p): New function.
2777 (redisplay_window): Use it.
2778
94fcd171
PE
27792013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 Fix some fd issues when running subprocesses (Bug#15035).
2782 Fix bugs that can leak files or file descriptors on errors.
2783 Don't unlink open temp files, as that's hard for users to diagnose
2784 when things go awry (e.g., temp disk exhausted).
2785 Don't bother to lock temp files. Check for invalid recursion.
2786 * callproc.c (synch_process_fd): Remove. All uses removed.
2787 (synch_process_tempfile): New var or macro.
2788 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2789 New constants.
2790 (record_kill_process): New arg, the temp name. All callers changed.
2791 (delete_temp_file): Now just a simple wrapper around unlink.
2792 (call_process_kill): New arg, the call_process_fd array.
2793 Close them all. Clear synch_process_pid. Remove the temp file,
2794 or arrange for it to be removed.
2795 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2796 that's been moved to synch_process_tempfile. Caller changed.
2797 Do not remove the tempfile; that's now call_process_kill's
2798 responsibility.
2799 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2800 call_process_kill; the caller now does that.
2801 (call_process_cleanup): Do not close the process fd; that's now
2802 call_process_kill's responsibility.
2803 (Fcall_process): Implement via new function call_process, which
2804 has most of the old body of Fcall_process, but with a different API.
2805 (call_process): New function that does not open or close filefd if
2806 it is nonnegative. Record which fds need to be closed, and let
2807 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2808 Signal an error if invoked recursively (could be done via a hook).
2809 Simplify creation of the tempfile in the MSDOS case.
2810 Don't create the output file until after checking for the executable.
2811 Report any failure to open /dev/null.
2812 Don't open /dev/null for writing twice; once is enough.
2813 Don't create pipe if all output is being discarded or sent to file.
2814 Don't worry about setting up the coding system or reading from the
2815 pipe if all output is being discarded.
2816 Hoist fd_error local into top level, to lessen block nesting.
2817 Don't record deleted pid here; now done by Fcall_process_region.
2818 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2819 and note its success in synch_process_tempfile.
2820 Do not leak resources when child_setup fails.
2821 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2822 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2823 (create_temp_file): Now returns open fd, with an additional
2824 Lisp_Object * argument to return the name. All callers changed.
2825 Do not close the file; rewind it instead, and leave it open for
2826 the caller. Do not lock the temp file. Unwind-protect the file
2827 and the file-descriptor.
2828 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2829 If an asynchrounous process, record it here, not in call_process.
2830 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2831 * eval.c (set_unwind_protect): New function.
2832 * fileio.c (write_region): New function, generalized from the
2833 old Fwrite_region. Do not lock temp files.
2834 (Fwrite_region): Use it.
2835 * lisp.h (set_unwind_protect, write_region): New decls.
2836 * process.c: Include <verify.h>.
2837 (make_process): Mark fds as initially closed.
2838 (deleted_pid_list): Now a list of pid-filename pairs.
2839 All uses changed.
2840 (close_process_fd): New function.
2841 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2842 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2843 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2844 (create_process, create_pty, Fmake_serial_process)
2845 (server_accept_connection): Record which fds need to be closed,
2846 and let deactivate_process close them.
2847 (Fmake_network_process): Do not discard the unwind-protect
2848 until it's safe to do so.
2849 (deactivate_process): Close the fds opened by create_process etc.
2850 (Fprocess_send_eof): Adjust to new way of recording open fds.
2851 Report an error if /dev/null can't be opened, instead of aborting.
2852 * process.h (PROCESS_OPEN_FDS): New constant.
2853 (struct Lisp_Process): New member open_fds.
2854 (record_kill_process, record_deleted_pid): Adjust signatures.
2855 (record_deleted_pid): Move decl here ...
2856 * syswait.h (record_deleted_pid): ... from here.
2857
d0e615c3
PE
28582013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2859
2860 * decompress.c: Fix bugs with large buffers and weird inputs.
2861 Tune a bit. Reindent as per usual Emacs style.
2862 (BUFFER_SIZE): Remove.
2863 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2864 more than UINT_MAX bytes. Decompress into the gap instead of into
2865 an auto buffer, as this should avoid copying. Return nil if
2866 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2867 set immediate_quit; we shouldn't trust zlib code that much.
2868
313546eb
LMI
28692013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2870
99a32242
LMI
2871 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2872 errors, and really move the gap to where we want it.
2873
313546eb
LMI
2874 * lisp.h: Include decompress.c support.
2875
2876 * emacs.c (main): Include decompress.c support.
2877
2878 * Makefile.in: Include -lz if present.
2879
d2d699ac
JD
28802013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2881
f90e3ebd
JD
2882 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2883 (initWithTitle:): Initialize frame to 0.
2884 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2885 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2886 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2887
2888 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2889 fillWithWidgetValue:frame:
2890
423d3b3f
JD
2891 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2892 remove memory leak warnings.
2893
d2d699ac
JD
2894 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2895 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2896 menu_pending_title.
2897
2898 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2899 (x_activate_menubar): Update the whole menu.
2900 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2901 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2902 current event is not NSSystemDefined (Bug#15001).
2903 Call ns_check_menu_open only if trackingMenu is 2.
2904 (menuDidClose:): New method, decrease trackingMenu.
2905 (fillWithWidgetValue:setDelegate:): New method.
2906 (fillWithWidgetValue:): Call the above.
2907
2908 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2909
7d652d97
PE
29102013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 Omit some unnecessary casts.
2913 Many of these go back to the old pre-C89 days, when they may have
2914 been needed, but we've been assuming C89 or later for a while now.
2915 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2916 (live_float_p, live_misc_p, live_vector_p):
2917 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2918 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2919 (defvar_per_buffer):
2920 * callint.c (Fcall_interactively):
2921 * doc.c (Fsubstitute_command_keys):
2922 * filelock.c (get_boot_time):
2923 * frame.c (xrdb_get_resource):
2924 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2925 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2926 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2927 (menuitem_highlight_callback, menu_destroy_callback)
2928 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2929 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2930 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2931 (xg_tool_bar_help_callback, tb_size_cb):
2932 * image.c (xpm_alloc_color, png_read_from_memory)
2933 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2934 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2935 (syms_of_image):
2936 * keymap.c (describe_map):
2937 * nsfns.m (Fns_display_monitor_attributes_list):
2938 * nsmenu.m (process_dialog:):
2939 * nsterm.m (hold_event):
2940 * process.c (wait_reading_process_output):
2941 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2942 * scroll.c (do_direct_scrolling, scrolling_1):
2943 * termcap.c (tgetent):
2944 * window.c (check_window_containing, add_window_to_list)
2945 (freeze_window_starts):
2946 * xdisp.c (compare_overlay_entries, vmessage):
2947 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2948 (x_get_monitor_attributes_xrandr)
2949 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2950 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2951 * xfont.c (xfont_match, xfont_open):
2952 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2953 (menubar_selection_callback, menu_position_func)
2954 (popup_selection_callback, create_and_show_popup_menu)
2955 (dialog_selection_callback, create_and_show_dialog):
2956 * xrdb.c (x_get_string_resource):
2957 (main) [TESTRM]:
2958 * xsmfns.c (x_session_check_input):
2959 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2960 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2961 (xaw_jump_callback, xaw_scroll_callback):
2962 Omit unnecessary casts.
2963
9acc1074
PE
29642013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2965
2966 Minor string-length refactoring.
2967 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2968 * frame.c (make_monitor_attribute_list):
2969 Prefer build_string to strlen + make_string.
2970
361c0eb8
JD
29712013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2972
2973 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2974 don't check minor_code (Bug#14417).
2975
14ba0822
EZ
29762013-08-09 Eli Zaretskii <eliz@gnu.org>
2977
2978 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2979 vertical positions instead. This avoids calling MATRIX_ROW with
2980 row numbers that are possibly beyond valid limits. (Bug#15064)
2981
309f24d1
DA
29822013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2983
2984 Use xstrdup and build_unibyte_string where applicable.
2985 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2986 * xfns.c (x_window):
2987 * xrdb.c (x_get_customization_string):
2988 * xterm.c (xim_initialize):
2989 * w32fns.c (w32_window): Use xstrdup.
2990 (w32_display_monitor_attributes_list):
2991 * emacs.c (init_cmdargs):
2992 * keyboard.c (PUSH_C_STR):
2993 * nsfont.m (nsfont_open):
2994 * sysdep.c (system_process_attributes):
2995 * w32.c (system_process_attributes):
2996 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2997
55902276
EZ
29982013-08-09 Eli Zaretskii <eliz@gnu.org>
2999
3000 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
3001 variables of these types so that GDB would know about them, as aid
3002 for debugging fatal exceptions. (Bug#15024) See also
3003 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
3004 discussions.
3005
10bf7f5a
JD
30062013-08-08 Jan Djärv <jan.h.d@swipnet.se>
3007
3008 * nsterm.m (ns_update_begin): Don't change clip path if it would be
3009 larger than the NSWindow (Bug#14934).
3010
65620264
DA
30112013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3012
3013 Redesign redisplay interface to drop global variable updated_window.
3014 Always pass currently updated window as a parameter to update routines.
3015 * dispextern.h (updated_window): Remove declaration.
3016 (struct redisplay_interface): Pass window parameter to
3017 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
3018 and after_update_window_hook.
3019 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
3020 Adjust prototypes.
3021 * dispnew.c (updated_window): Remove.
3022 (redraw_overlapped_rows, update_marginal_area, update_text_area)
3023 (update_window_line): Adjust to match redisplay interface changes.
3024 * nsterm.m (ns_update_window_begin, ns_update_window_end)
3025 (ns_scroll_run, ns_after_update_window_line):
3026 * w32term.c (x_update_window_begin, x_update_window_end)
3027 (x_after_update_window_line, x_scroll_run):
3028 * xterm.c (x_update_window_begin, x_update_window_end)
3029 (x_after_update_window_line, x_scroll_run):
3030 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
3031 Likewise. Adjust comments where appropriate.
3032 (x_cursor_to): Simplify because this is always called during window
3033 update (but install debugging check anyway).
3034 (expose_window): Check must_be_updated_p flag to see whether this
3035 function is called during window update.
3036
628fdc56
DA
30372013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3038
3039 Do not reset window modification event counters excessively.
3040 These leftovers and poor man's tricky methods to catch extra
3041 redisplay's attention are no longer needed.
3042 * frame.c (set_menu_bar_lines_1):
3043 * minibuf.c (read_minibuf_unwind):
3044 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
3045 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
3046 (window_scroll_line_based, Fset_window_configuration):
3047 * xdisp.c (redisplay_window): Do not reset last_modified and
3048 last_overlay_modified counters.
3049
8fd9c92e
JD
30502013-08-07 Jan Djärv <jan.h.d@swipnet.se>
3051
3052 * xselect.c (x_send_client_event): Set send_event and serial, memset
3053 data.l as it might be bigger than data.b. Use 24 bit mask to
3054 XSendEvent (Bug#15034).
3055
0ee18172
EZ
30562013-08-07 Eli Zaretskii <eliz@gnu.org>
3057
3058 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
3059 for TTY frames that are not the top frame on their console.
3060 (Bug#14616)
3061
16ddd1a6
MR
30622013-08-07 Martin Rudalics <rudalics@gmx.at>
3063
3064 * w32term.c (w32fullscreen_hook): Really maximize frame when
3065 asked for (Bug#14841).
3066
d2a95ffb
DA
30672013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3068
3069 Prefer selected_window to Fselected_window, likewise for frames.
3070 * buffer.c (Fbuffer_swap_text):
3071 * data.c (Fvariable_binding_locus):
3072 * window.c (run_window_configuration_change_hook): Adjust users.
3073 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
3074 Use decode_live_frame.
3075
170da1ec
DA
30762013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3077
3078 Be more careful if selected window shows the buffer other than current,
3079 use window_outdated only if this is not so. This change should also
3080 address some weird issues discussed in Bug#13012.
3081 * window.h (window_outdated): New prototype.
3082 * window.c (window_outdated): Now here. Convert from static and
3083 always assume window's buffer.
3084 (Fwindow_end, Fwindow_line_height): Use it.
3085 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
3086 and always assume window's buffer.
3087 (redisplay_window): Adjust user.
e5eefe9b 3088 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
3089 check whether mode line should be updated only if selected window
3090 shows current buffer.
3091 (run_window_scroll_functions): Use eassert for debugging check.
3092 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
3093
56b5d5b1
DA
30942013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3095
3096 * window.c (window_scroll, window_scroll_pixel_based)
3097 (window_scroll_line_based): Use bool for booleans.
3098
2878ba7e
PE
30992013-08-06 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 * process.c: Fix minor off-by-one issues in descriptor counts.
3102 This shouldn't fix any real bugs, but it cleans up the code a bit.
3103 (max_process_desc, max_input_desc): -1, not 0, means none.
3104 All uses changed.
3105 (delete_input_desc): New function.
3106 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
3107 (deactivate_process): Scan backwards when recomuting max_process_desc;
3108 that should be faster.
3109 (init_process_emacs): Initialize max_input_desc.
3110
e30b79c1
DA
31112013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3112
3113 Use region cache to speedup bidi_find_paragraph_start.
3114 * buffer.h (struct buffer): New member bidi_paragraph_cache.
3115 Rename cache_long_line_scans to cache_long_scans.
3116 * buffer.c (bset_cache_long_line_scans): Rename to
3117 bset_cache_long_scans.
3118 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
3119 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
3120 into account.
3121 (syms_of_buffer): Rename cache-long-line-scans to
3122 cache-long-scans. Adjust docstring.
3123 * search.c (newline_cache_on_off):
3124 * indent.c (width_run_cache_on_off): Adjust users.
3125 * bidi.c (bidi_paragraph_cache_on_off): New function.
3126 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
3127 * insdel.c (prepare_to_modify_buffer):
3128 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 3129
00012b86
DA
31302013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3131
3132 Invalidate region caches only if buffer text is going to be changed.
3133 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
3134 (modify_text): ...new prototype.
3135 (prepare_to_modify_buffer_1): New prototype.
3136 * textprop.c (modify_region): Rename to...
3137 (modify_text_properties): ...new function.
3138 (add_text_properties_1, set_text_properties, Fremove_text_properties)
3139 (Fremove_list_of_text_properties): Adjust users.
3140 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
3141 (modify_text): ...new function.
3142 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
3143 (prepare_to_modify_buffer_1): ...new function.
3144 * casefiddle.c (casify_region):
3145 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
3146 (Ftranspose_regions): Use modify_text.
3147
dc6c0eda
SM
31482013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
3149
3150 * lisp.mk (lisp): Add nadvice.elc.
3151
8f3a2c26
DA
31522013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3153
3154 New macro to iterate over live buffers similar to frames.
3155 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
3156 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
3157 Declare buffer-related variables here to offload lisp.h.
3158 * buffer.c (Vbuffer_alist): Adjust comment.
3159 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
3160 (other_buffer_safely):
3161 * data.c (store_symval_forwarding):
3162 * dispnew.c (Fframe_or_buffer_changed_p):
3163 * fileio.c (Fdo_auto_save):
3164 * filelock.c (unlock_all_files):
3165 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
3166
e0fdb694
PE
31672013-08-04 Paul Eggert <eggert@cs.ucla.edu>
3168
3169 Fix some minor races in hosts lacking mkostemp (Bug#15015).
3170 * callproc.c (create_temp_file):
3171 * filelock.c (create_lock_file):
3172 Assume mkostemp, since it's now provided by Gnulib.
3173
63f5c6c2
EZ
31742013-08-04 Eli Zaretskii <eliz@gnu.org>
3175
3176 * w32.c (mkostemp): New function.
3177 (mktemp): Remove, no longer used. Most of the code reused in
3178 mkostemp. (Bug#15015)
484ab239 3179 (mktemp): Don't undef.
63f5c6c2 3180
f0b79313
DA
31812013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
3182
3183 * dispnew.c (glyph_matrix_count, glyph_pool_count):
3184 Move under GLYPH_DEBUG and ENABLE_CHECKING.
3185 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
3186 (free_glyph_pool, check_glyph_memory): Likewise for
3187 all users. Adjust comments where appropriate.
3188
98f638d6
PE
31892013-08-03 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 * composite.h: Minor fixups.
3192 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
3193 to fix a misspelling, and change it to an inline function while
3194 we're at it (it need not be a macro). All uses changed.
3195 (composition_method, composition_valid_p):
3196 Rewrite to avoid assignments in if-conditions.
3197
75c59fb3
DA
31982013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
3199
3200 Do not use global Lisp_Object in composition macros.
3201 * composite.h (composition_temp): Remove declaration.
3202 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
3203 (composition_method, composition_valid_p): ...inline functions.
416a3e01 3204 (compose_region): Remove the leftover.
75c59fb3
DA
3205 * composite.c (composition_temp): Remove.
3206 (run_composition_function, update_compositions)
3207 (composition_compute_stop_pos, composition_adjust_point)
3208 (Ffind_composition_internal):
3209 * coding.c (handle_composition_annotation):
3210 * xdisp.c (handle_composition_prop, check_point_in_composition):
3211 Related users changed.
3212
a10c8269
DA
32132013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
3214
3215 Drop FRAME_PTR typedef.
3216 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
3217 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
3218 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
3219 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
3220 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
3221 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
3222 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
3223 All related users changed.
3224
a104f656
SM
32252013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3226
3227 * eval.c (default_toplevel_binding): New function.
3228 (Fdefvar): Use it.
3229 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
3230 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
3231 (syms_of_eval): Export them.
3232 * data.c (Fdefault_value): Micro cleanup.
3233 * term.c (init_tty): Use "false".
3234
4b5c9326
DA
32352013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
3236
3237 Fix X GC leak in GTK and raw (no toolkit) X ports.
3238 * xterm.c (x_free_frame_resources): If white and black relief
3239 GCs are allocated, always free them here.
3240 * xfns.c (x_make_gc): Omit redundant initialization.
3241 * widget.c (create_frame_gcs): Remove the leftover.
3242 (EmacsFrameDestroy): Do nothing because all GCs are now freed
3243 in x_free_frame_resources.
3244
b19aa636
JD
32452013-08-02 Jan Djärv <jan.h.d@swipnet.se>
3246
3247 * nsterm.m (windowWillResize:toSize:): Only change title if
3248 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
3249 modifying it.
3250 (viewDidEndLiveResize): New method.
3251
3252 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
3253 inside NS_IMPL_COCOA.
3254
af1f7e06
DA
32552013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
3256
3257 * insdel.c (adjust_after_replace, replace_range, del_range_2):
3258 Do not check whether undo is enabled because record_insert and
3259 record_delete does that themselves.
3260
65b02bb9
DA
32612013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
3262
3263 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
3264 member which is not really used any more.
3265 (FRAME_XIC_BASE_FONTNAME): Remove.
3266 * xfns.c (xic_free_fontset): Adjust user.
3267 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
3268 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
3269 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
3270 (xdialog_show): Use eassert for debugging check.
7ee0f047 3271 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 3272
6318cde0
PE
32732013-08-01 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 * fileio.c, fns.c (merge): Move extern decl from here ...
3276 * lisp.h (merge): ... to here.
3277
6c1a09ba
DA
32782013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3279
3280 Fix last font-related change.
3281 * w32font.h (w32font_list_internal, w32font_match_internal):
3282 Fix prototype.
3283 * w32uniscribe.c (uniscribe_list, uniscribe_match):
3284 (uniscribe_list_family): Adjust to match font API change.
3285 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
3286 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
3287
f8c20208
DA
32882013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3289
3290 * frame.h (FRAME_MOUSE_UPDATE):
3291 * nsterm.m (ns_frame_up_to_date): Omit redundant check
3292 whether hlinfo->mouse_face_mouse_frame is non-NULL.
3293
fdb396e2
DA
32942013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3295
3296 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
3297 * font.h (struct font_driver): Change list, match, and list_family
3298 functions to accept struct frame * as first arg.
068f9124
SM
3299 * font.c (font_score, font_compare, font_sort_entities):
3300 Remove prototypes.
fdb396e2
DA
3301 (font_sort_entities, font_list_entities, font_select_entity):
3302 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
3303 match font API change.
3304 * xfont.c (xfont_list, xfont_match, xfont_list_family):
3305 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
3306 * ftxfont.c (ftxfont_list, ftxfont_match):
3307 * xftfont.c (xftfont_list, xftfont_match):
3308 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
3309 * w32font.c (w32font_list, w32font_match, w32font_list):
3310 (w32font_list_internal, w32_font_match_internal): Likewise.
3311 * xfaces.c (Fx_family_fonts): Adjust user.
3312
52b8a085
DA
33132013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3314
3315 Do not use pure Xism x_wm_set_icon_position in non-X ports.
3316 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
3317 only if HAVE_X_WINDOWS is in use.
3318 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
3319 * nsterm.m (x_wm_set_icon_position): Remove no-op.
3320 * w32term.c (x_wm_set_icon_position): Likewise.
3321 * w32fns.c (x_icon): Adjust user.
3322
c791c18e
DA
33232013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3324
3325 * xterm.c (last_mouse_press_frame): Remove the
3326 leftover which is not really used any more.
3327 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
3328 (x_flush): Call XFlush once per each X display, not frame.
3329 This is better because this code always unconditionally skips
3330 non-X frames in Vframe_list and issues the only XFlush if we
3331 have more than one X frame on the same X display.
2f935d86
DA
3332 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
3333 Use bool for booleans.
3334 (x_draw_glyph_string_background, cvt_string_to_pixel):
3335 (cvt_pixel_dtor): Drop unnecessary prototypes.
3336 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 3337
f435830e
DA
33382013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3339
3340 Drop unnecessary functions that deals with frame pixel size.
3341 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
3342 (x_pixel_height): Drop prototypes.
3343 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
3344 (x_pixel_height): Drop implementations.
3345 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
3346 which should be always valid for window frame.
3347 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
3348 * w32menu.c (Fx_popup_dialog):
3349 * xmenu.c (Fx_popup_dialog): Likewise for both.
3350
84231434
DA
33512013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3352
3353 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
3354 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
3355 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
3356 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
3357 and mention nil frame in docstring.
84231434 3358
959067a1
DA
33592013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3360
3361 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
3362 (x_figure_window_size): Likewise. Adjust to return long.
3363 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
3364 (toplevel): Move Qterminal_live_p to...
3365 * terminal.c (toplevel): ...here, make it static, and...
3366 (syms_of_terminal): ...DEFSYM here.
3367 * frame.h (Qterminal_live_p): Remove declaration.
3368 (make_frame, x_figure_window_size): Adjust prototype.
3369 * nsfns.m (Fx_create_frame): Use long for window flags.
3370
f4b169ce
PE
33712013-07-30 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
3374 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
3375 Do not assume that emacs_close (INT_MAX) is a no-op.
3376
bee6a2c7
DA
33772013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3378
3379 * xfaces.c (make_face_cache): For struct face_cache, prefer
3380 xmalloc to xzalloc and so avoid redundant call to memset.
3381 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
3382
d7e6881a
DA
33832013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3384
3385 * fringe.c (draw_window_fringes, update_window_fringes)
3386 (compute_fringe_widths):
3387 * w32term.c (x_draw_glyph_string):
3388 * window.c (candidate_window_p, Frecenter):
3389 * xfaces.c (realize_basic_faces, realize_default_face)
3390 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
3391 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
3392 * xfns.c (x_set_cursor_color, xic_free_xfontset):
3393 * xmenu.c (Fx_menu_bar_open_internal):
3394 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
3395 * xsettings.c (xft_settings_event):
3396 * xterm.c (x_draw_glyph_string, x_had_errors_p):
3397 Use bool for booleans. Adjust style and comments where
3398 appropriate.
3399 * dispextern.h (draw_window_fringes, update_window_fringes)
3400 (compute_fringe_widths):
3401 * xterm.h (x_had_errors_p): Adjust prototype.
3402
ec3058af
DA
34032013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3404
3405 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
3406 CHECK_LIST. Rewrite the loop to avoid useless local variable.
3407
218e0637
DA
34082013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3409
3410 * fns.c (toplevel): Remove comment before Fsafe_length because
3411 it checks for QUIT.
3412
e560aba9
PE
34132013-07-28 Paul Eggert <eggert@cs.ucla.edu>
3414
3415 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
3416
2e5ce5de
EZ
34172013-07-28 Eli Zaretskii <eliz@gnu.org>
3418
3419 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
3420 frame which got the message is still alive, before dereferencing
3421 its pointer. (Bug#14970)
3422
3423 * frame.c (delete_frame): Test "this" frame's minibuffer window to
3424 be a live window, before using it as such. (Bug#14970)
3425
e95da6d3
EZ
34262013-07-27 Eli Zaretskii <eliz@gnu.org>
3427
3428 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
3429 w32_detect_focus_change instead of doing part of its job by hand.
3430 This fixes the problem whereby FOCUS_OUT events were not sent to
3431 the event queue.
3432
a8f93651
EZ
34332013-07-26 Eli Zaretskii <eliz@gnu.org>
3434
fec92060
EZ
3435 * process.c (Fprocess_list): Doc fix.
3436
a8f93651
EZ
3437 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
3438 being re-exposed only if it didn't ask to become visible.
3439 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
3440 was previously iconified. (Bug#14841)
3441 (x_iconify_frame): Mark the frame iconified.
3442
d5a7a9d9
PE
34432013-07-26 Paul Eggert <eggert@cs.ucla.edu>
3444
3445 Fix minor problems found by static checking.
3446 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
3447 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
3448
56ea7291
SM
34492013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3450
3451 * eval.c (set_specpdl_old_value): New function.
3452 (unbind_to): Minor simplification.
3453 (get_backtrace_frame): New function.
3454 (Fbacktrace_frame): Use it. Add `base' argument.
3455 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
3456 (syms_of_eval): Export backtrace-eval.
3457 * xterm.c (x_focus_changed): Simplify.
3458
9d611ffe
PE
34592013-07-25 Paul Eggert <eggert@cs.ucla.edu>
3460
3461 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
3462
999c74e3
EZ
34632013-07-24 Eli Zaretskii <eliz@gnu.org>
3464
3465 * xdisp.c (redisplay_window): Instead of moving point out of
3466 scroll margin, reject the force_start method, and try scrolling
3467 instead. (Bug#14780)
3468
198fa217
KB
34692013-07-24 Ken Brown <kbrown@cornell.edu>
3470
3471 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
3472 (Bug#14944).
3473
53840e55
PE
34742013-07-24 Paul Eggert <eggert@cs.ucla.edu>
3475
3476 * eval.c (Fprogn): Do not check that BODY is a proper list.
3477 This undoes the previous change. The check slows down the
3478 interpreter, and is not needed to prevent a crash. See
3479 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
3480
60967f56
GM
34812013-07-23 Glenn Morris <rgm@gnu.org>
3482
3483 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
3484
9ca960e2
PE
34852013-07-23 Paul Eggert <eggert@cs.ucla.edu>
3486
a29c3e6d
PE
3487 Port to GNU/Linux systems with tinfo but not ncurses.
3488 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
3489 to decide whether ncurses is being used. Without this change,
3490 GCC complains about tgetent not being declared, on a system
3491 that has tinfo installed but ncurses not installed.
3492
f274311c
PE
3493 * eval.c (Fprogn): Check that BODY is a proper list.
3494
16b0520a
PE
3495 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
3496 * data.c (Fsetq_default):
3497 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
3498 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
3499 (Fcondition_case):
3500 Tune by taking advantage of the fact that ARGS is always a list
3501 when a function is declared to have UNEVALLED args.
3502
9ca960e2
PE
3503 * emacsgtkfixed.c: Port to GCC 4.6.
3504 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
3505
afacaa1b
JB
35062013-07-23 Juanma Barranquero <lekktu@gmail.com>
3507
3508 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
3509 here to silence compiler warnings.
3510
368a85a4
PE
35112013-07-22 Paul Eggert <eggert@cs.ucla.edu>
3512
3513 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
3514 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
3515 from messing up Emacs's 'struct frame' (Bug#14923).
3516
f4e891b5
PE
35172013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3518
3519 * alloc.c (make_save_ptr_ptr): Define this function.
3520 It was inadvertently omitted. It's needed only if
3521 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
3522
96c8b65e
JD
35232013-07-21 Jan Djärv <jan.h.d@swipnet.se>
3524
3525 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
3526 frame have focus (Bug#14895).
3527
ee010797
PE
35282013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3529
3530 Avoid vfork-related deadlock more cleanly.
3531 * callproc.c (child_setup): When the child's exec fails, output
3532 the program name, as that's more useful. Use O_NONBLOCK to avoid
3533 deadlock.
3534 * process.c (create_process_1): Remove; no longer needed.
3535 (create_process): Remove timer hack; no longer needed, now that
3536 the child avoids deadlock.
3537
f0398ec1 35382013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
3539
3540 * image.c (Fimage_flush): Fix doc typo.
3541
b2a069c2
PE
35422013-07-20 Paul Eggert <eggert@cs.ucla.edu>
3543
6496aec9
PE
3544 Fix array bounds violation when pty allocation fails.
3545 * process.c (PTY_NAME_SIZE): New constant.
3546 (pty_name): Remove static variable; it's now auto.
3547 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
3548 Take pty_name as an arg rather than using a static variable.
3549 All callers changed.
3550 (create_process): Recover pty_flag from process, not from volatile local.
3551 (create_pty): Stay inside array even when pty allocation fails.
3552 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
3553
b2a069c2
PE
3554 * lread.c (Fload): Avoid initialization only when lint checking.
3555 Mention that it's needed only for older GCCs.
3556
99107004
KH
35572013-07-20 Kenichi Handa <handa@gnu.org>
3558
3559 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
3560 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
3561
6b1b199d
AS
35622013-07-20 Andreas Schwab <schwab@linux-m68k.org>
3563
3564 * lread.c (Fload): Avoid uninitialized warning.
3565
4195afc3
PE
35662013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3567
3f5bef16
PE
3568 Fix some minor file descriptor leaks and related glitches.
3569 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
3570 (create_lock_file): Use write, not emacs_write.
3571 * image.c (slurp_file, png_load_body):
3572 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
3573 (server_accept_connection):
3574 Don't leak an fd on memory allocation failure.
3575 * image.c (slurp_file): Add a cheap heuristic for growing files.
3576 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
3577 as that's what the other routines do. Maybe input need not be
3578 blocked at all, but it's better to be consistent.
3579 Avoid undefined behavior when strlen is zero.
3580
4195afc3
PE
3581 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
3582 (NSTATICS): Now a constant; doesn't need to be a macro.
3583
a1aeeffe
RS
35842013-07-19 Richard Stallman <rms@gnu.org>
3585
3586 * coding.c (decode_coding_utf_8): Add simple loop for fast
3587 processing of ASCII characters.
3588
63b34baa
PE
35892013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
3592
621dd9ac
EZ
35932013-07-19 Eli Zaretskii <eliz@gnu.org>
3594
3595 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
3596 unportable 'struct x_display_info'.
3597 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
3598 is a portable type.
3599
1396ac86
PE
36002013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3601
ab9980cd
PE
3602 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
3603 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
3604 or fscanf fails.
3605 (system_process_attributes): Prefer plain char to unsigned char
3606 when either will do. Clean up properly if interrupted or if
068f9124
SM
3607 memory allocations fail. Don't assume sscanf succeeds.
3608 Remove no-longer-needed workaround to stop GCC from whining.
3609 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
3610 bit more carefully.
3611
1396ac86
PE
3612 Fix obscure porting bug with varargs functions.
3613 The code assumed that int is treated like ptrdiff_t in a vararg
3614 function, which is not a portable assumption. There was a similar
3615 -- though these days less likely -- porting problem with various
3616 assumptions that pointers of different types all smell the same as
3617 far as vararg functions is conserved. To make this problem less
3618 likely in the future, redo the API to use varargs functions.
3619 * alloc.c (make_save_value): Remove this vararg function.
3620 All uses changed to ...
3621 (make_save_int_int_int, make_save_obj_obj_obj_obj)
3622 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
3623 New functions.
3624 (make_save_ptr): Rename from make_save_pointer, for consistency with
3625 the above. Define only on platforms that need it. All uses changed.
3626
4d19d194
PE
36272013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3628
3629 * keyboard.c: Try to fix typos in previous change.
3630 (DISPLAY_LIST_INFO): New macro.
3631 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 3632 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 3633
945c5bb1
JB
36342013-07-18 Juanma Barranquero <lekktu@gmail.com>
3635
3636 * keyboard.c (kbd_buffer_get_event):
3637 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
3638 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
3639
f4b1eb36
PE
36402013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3641
5e679a2c
PE
3642 * filelock.c: Fix unlikely file descriptor leaks.
3643 (get_boot_time_1): Rework to avoid using emacs_open.
3644 This doesn't actually fix a leak, but is better anyway.
3645 (read_lock_data): Use read, not emacs_read.
3646
a8cd4836
PE
3647 * doc.c: Fix minor memory and file descriptor leaks.
3648 * doc.c (get_doc_string): Fix memory leak when doc file absent.
3649 (get_doc_string, Fsnarf_documentation):
3650 Fix file descriptor leak on error.
3651
ef30e638
PE
3652 * term.c: Fix minor fdopen-related file descriptor leaks.
3653 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
3654 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
3655
f4b1eb36
PE
3656 * charset.c: Fix file descriptor leaks and errno issues.
3657 Include <errno.h>.
3658 (load_charset_map_from_file): Don't leak file descriptor on error.
3659 Use plain record_xmalloc since the allocation is larger than
3660 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
3661 of entries.
3662 * eval.c (record_unwind_protect_nothing):
3663 * fileio.c (fclose_unwind):
3664 New functions.
3665 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
3666 The replacement doesn't block input, but that no longer seems
3667 necessary.
3668
b648c163
PE
36692013-07-17 Paul Eggert <eggert@cs.ucla.edu>
3670
a0931322
PE
3671 * lread.c: Fix file descriptor leaks and errno issues.
3672 (Fload): Close some races that leaked fds or streams when 'load'
3673 was interrupted.
3674 (Fload, openp): Report error number of last nontrivial failure to open.
3675 ENOENT counts as trivial.
3676 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
3677 New functions.
3678 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
3679 now that the function is always called with a nonnegative arg.
3680 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
3681 All uses replaced with ...
3682 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
3683
b648c163
PE
3684 A few more minor file errno-reporting bugs.
3685 * callproc.c (Fcall_process):
3686 * doc.c (Fsnarf_documentation):
3687 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
3688 * process.c (set_socket_option):
3689 Don't let a constructor trash errno.
3690 * doc.c: Include <errno.h>.
3691
b1dc4084
JB
36922013-07-16 Juanma Barranquero <lekktu@gmail.com>
3693
3694 * w32fns.c (unwind_create_tip_frame): Fix declaration.
3695
c43843aa
PE
36962013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3697
50a30cce
PE
3698 Fix w32 bug with call-process-region (Bug#14885).
3699 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
3700 to Fcall_process when the input is empty. This simplifies the
3701 code a bit. It makes no difference on POSIXish platforms but
3702 apparently it fixes a bug on w32.
3703
44e18199 3704 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
3705 * fileio.c (close_file_unwind): Don't close if FD is negative;
3706 this can happen when unwinding a zapped file descriptor.
3707 (Finsert_file_contents): Unwind-protect the fd before the point marker,
3708 in case Emacs runs out of memory between the two unwind-protects.
3709 Don't trash errno when closing FD.
3710 Zap the FD in the specpdl when closing it, instead of deferring
3711 the removal of the unwind-protect; this fixes a bug where a child
3712 function unwinds the stack past us.
3713
27e498e6
PE
3714 New unwind-protect flavors to better type-check C callbacks.
3715 This also lessens the need to write wrappers for callbacks,
3716 and the need for make_save_pointer.
3717 * alloca.c (free_save_value):
3718 * atimer.c (run_all_atimers):
3719 Now extern.
3720 * alloc.c (safe_alloca_unwind):
3721 * atimer.c (unwind_stop_other_atimers):
3722 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
3723 * menu.c (cleanup_popup_menu) [HAVE_NS]:
3724 * minibuf.c (choose_minibuf_frame_1):
3725 * process.c (make_serial_process_unwind):
3726 * xdisp.h (pop_message_unwind):
3727 * xselect.c (queue_selection_requests_unwind):
3728 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
3729 * alloca.c (record_xmalloc):
3730 Prefer record_unwind_protect_ptr to record_unwind_protect with
3731 make_save_pointer.
3732 * alloca.c (Fgarbage_collect):
3733 Prefer record_unwind_protect_void to passing a dummy.
3734 * buffer.c (restore_buffer):
3735 * window.c (restore_window_configuration):
3736 * xfns.c, w32fns.c (do_unwind_create_frame)
3737 New wrapper. All record-unwind uses of wrappee changed.
3738 * buffer.c (set_buffer_if_live):
3739 * callproc.c (call_process_cleanup, delete_temp_file):
3740 * coding.c (code_conversion_restore):
3741 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
3742 * editfns.c (save_excursion_restore)
3743 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
3744 (save_restriction_restore):
3745 * eval.c (restore_stack_limits, un_autoload):
3746 * fns.c (require_unwind):
3747 * keyboard.c (recursive_edit_unwind, tracking_off):
3748 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
3749 * macros.c (pop_kbd_macro, restore_menu_items):
3750 * nsfns.m (unwind_create_frame):
3751 * print.c (print_unwind):
3752 * process.c (start_process_unwind):
3753 * search.c (unwind_set_match_data):
3754 * window.c (select_window_norecord, select_frame_norecord):
3755 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
3756 (fast_set_selected_frame):
3757 * xfns.c, w32fns.c (unwind_create_tip_frame):
3758 Return void, not a dummy Lisp_Object. All uses changed.
3759 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
3760 * callproc.c (call_process_kill):
3761 * fileio.c (restore_point_unwind, decide_coding_unwind)
3762 (build_annotations_unwind):
3763 * insdel.c (Fcombine_after_change_execute_1):
3764 * keyboard.c (read_char_help_form_unwind):
3765 * menu.c (unuse_menu_items):
3766 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
3767 * sound.c (sound_cleanup):
3768 * xdisp.c (unwind_redisplay):
3769 * xfns.c (clean_up_dialog):
3770 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
3771 Accept no args and return void, instead of accepting and returning
3772 a dummy Lisp_Object. All uses changed.
3773 * cygw32.c (fchdir_unwind):
3774 * fileio.c (close_file_unwind):
3775 * keyboard.c (restore_kboard_configuration):
3776 * lread.c (readevalllop_1):
3777 * process.c (wait_reading_process_output_unwind):
3778 Accept int and return void, rather than accepting an Emacs integer
3779 and returning a dummy object. In some cases this fixes an
3780 unlikely bug when the corresponding int is outside Emacs integer
3781 range. All uses changed.
3782 * dired.c (directory_files_internal_unwind):
3783 * fileio.c (do_auto_save_unwind):
3784 * gtkutil.c (pop_down_dialog):
3785 * insdel.c (reset_var_on_error):
3786 * lread.c (load_unwind):
3787 * xfns.c (clean_up_file_dialog):
3788 * xmenu.c, nsmenu.m (pop_down_menu):
3789 * xmenu.c (cleanup_widget_value_tree):
3790 * xselect.c (wait_for_property_change_unwind):
3791 Accept pointer and return void, rather than accepting an Emacs
3792 save value encapsulating the pointer and returning a dummy object.
3793 All uses changed.
3794 * editfns.c (Fformat): Update the saved pointer directly via
3795 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3796 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3797 (unwind_body): New function.
3798 (record_unwind_protect): First arg is now a function returning void,
3799 not a dummy Lisp_Object.
3800 (record_unwind_protect_ptr, record_unwind_protect_int)
3801 (record_unwind_protect_void): New functions.
3802 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3803 * fileio.c (struct auto_save_unwind): New type.
3804 (do_auto_save_unwind): Use it.
3805 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3806 * insdel.c (struct rvoe_arg): New type.
3807 (reset_var_on_error): Use it.
3808 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3809 New constants.
3810 (specbinding_func): Remove; there are now several such functions.
3811 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3812 (set_unwind_protect_ptr): New function.
3813 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3814
4e604a5d
PE
3815 Be simpler and more consistent about reporting I/O errors.
3816 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3817 Say "Read error" and "Write error", rather than "I/O error", or
3818 "IO error reading", or "IO error writing", when a read or write
3819 error occurs.
3820 * process.c (Fmake_network_process, wait_reading_process_output)
3821 (send_process, Fprocess_send_eof, wait_reading_process_output):
3822 Capitalize diagnostics consistently. Put "failed foo" at the
3823 start of the diagnostic, so that we don't capitalize the
3824 function name "foo". Consistently say "failed" for such
3825 diagnostics.
3826 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3827 All callers changed. This is so it can use report_file_error.
3828 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3829 diagnostics consistently as above.
3830
a9757f6a
PE
3831 * fileio.c (report_file_errno): Fix errno reporting bug.
3832 If the file name is neither null nor a pair, package it up as a
3833 singleton list. All callers changed, both to this function and to
3834 report_file_error. This fixes a bug where the memory allocator
3835 invoked by list1 set errno so that the immediately following
3836 report_file_error reported the wrong errno value.
3837
c43843aa
PE
3838 Fix minor problems found by --enable-gcc-warnings.
3839 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3840 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3841
18c26d81
JD
38422013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3843
3844 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3845 Set event->arg to Qt if switch-event shall be generated.
3846 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3847
3848 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3849
3850 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3851 FOCUS_OUT_EVENT.
3852
3853 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3854 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3855 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3856 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3857 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3858 and there is a focused frame.
3859 (head_table): Add focus-in and focus-out.
3860 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3861 bind to handle-focus-in/out.
3862
3863 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3864 (Fhandle_switch_frame): Call Fhandle_focus_in.
3865 (syms_of_frame): defsubr handle-focus-in/out.
3866
6c6f1994
PE
38672013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3868
c7ddc792
PE
3869 Fix porting bug to older POSIXish platforms (Bug#14862).
3870 * sysdep.c (emacs_pipe): New function, that implements
3871 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3872 This should port better to CentOS 5 and to Mac OS X 10.6.
3873 All calls to pipe2 changed.
3874
6c6f1994
PE
3875 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3876 This makes the code easier to read and the executable a bit smaller.
3877 Do not replace all calls to Fcons that happen to create lists,
3878 just calls that are intended to create lists. For example, when
3879 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3880 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3881 Similarly for list2 through list5.
3882 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3883 * bytecode.c (exec_byte_code):
3884 * callint.c (quotify_arg, Fcall_interactively):
3885 * callproc.c (Fcall_process, create_temp_file):
3886 * charset.c (load_charset_map_from_file)
3887 (Fdefine_charset_internal, init_charset):
3888 * coding.c (get_translation_table, detect_coding_system)
3889 (Fcheck_coding_systems_region)
3890 (Fset_terminal_coding_system_internal)
3891 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3892 * composite.c (update_compositions, Ffind_composition_internal):
3893 * dired.c (directory_files_internal, file_name_completion)
3894 (Fsystem_users):
3895 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3896 * doc.c (Fsnarf_documentation):
3897 * editfns.c (Fmessage_box):
3898 * emacs.c (main):
3899 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3900 (Feval, eval_sub, Ffuncall, apply_lambda):
3901 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3902 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3903 (Fset_file_times, Finsert_file_contents)
3904 (Fchoose_write_coding_system, Fwrite_region):
3905 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3906 * font.c (font_registry_charsets, font_parse_fcname)
3907 (font_prepare_cache, font_update_drivers, Flist_fonts):
3908 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3909 * frame.c (make_frame, Fmake_terminal_frame)
3910 (x_set_frame_parameters, x_report_frame_params)
3911 (x_default_parameter, Fx_parse_geometry):
3912 * ftfont.c (syms_of_ftfont):
3913 * image.c (gif_load):
3914 * keyboard.c (command_loop_1):
3915 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3916 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3917 (Fminor_mode_key_binding, accessible_keymaps_1)
3918 (Faccessible_keymaps, Fwhere_is_internal):
3919 * lread.c (read_emacs_mule_char):
3920 * menu.c (find_and_return_menu_selection):
3921 * minibuf.c (get_minibuffer):
3922 * nsfns.m (Fns_perform_service):
3923 * nsfont.m (ns_script_to_charset):
3924 * nsmenu.m (ns_popup_dialog):
3925 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3926 (Fx_own_selection_internal):
3927 * nsterm.m (append2):
3928 * print.c (Fredirect_debugging_output)
3929 (print_prune_string_charset):
3930 * process.c (Fdelete_process, Fprocess_contact)
3931 (Fformat_network_address, set_socket_option)
3932 (read_and_dispose_of_process_output, write_queue_push)
3933 (send_process, exec_sentinel):
3934 * sound.c (Fplay_sound_internal):
3935 * textprop.c (validate_plist, add_properties)
3936 (Fput_text_property, Fadd_face_text_property)
3937 (copy_text_properties, text_property_list, syms_of_textprop):
3938 * unexaix.c (report_error):
3939 * unexcoff.c (report_error):
3940 * unexsol.c (unexec):
3941 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3942 (Fformat_mode_line, syms_of_xdisp):
3943 * xfaces.c (set_font_frame_param)
3944 (Finternal_lisp_face_attribute_values)
3945 (Finternal_merge_in_global_face, syms_of_xfaces):
3946 * xfns.c (x_default_scroll_bar_color_parameter)
3947 (x_default_font_parameter, x_create_tip_frame):
3948 * xfont.c (xfont_supported_scripts):
3949 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3950 (menu_help_callback, xmenu_show):
3951 * xml.c (make_dom):
3952 * xterm.c (set_wm_state):
3953 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3954 and similarly for list2 through list5.
3955
bafe80ce
PE
39562013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 * callproc.c (Fcall_process_region): Fix minor race and tune.
3959 (create_temp_file): New function, with the temp-file-creation part
3960 of the old Fcall_process_region. Use Fcopy_sequence to create the
3961 temp file name, rather than alloca + build_string, for simplicity.
3962 Don't bother to block input around the temp file creation;
068f9124
SM
3963 shouldn't be needed. Simplify use of mktemp.
3964 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3965 this closes an unlikely race where the temp file was not removed.
3966 Use memcpy rather than an open-coded loop.
3967 (Fcall_process_region): Use the new function. If the input is
3968 empty, redirect from /dev/null rather than from a newly created
3969 empty temp file; this avoids unnecessary file system traffic.
3970
4700b5a5
PE
39712013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3972
5c97beae
PE
3973 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3974 Simplify by making this case like the other two. This is a bit
3975 slower on obsolete hosts, but the extra complexity isn't worth it.
3976
4700b5a5
PE
3977 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3978 * process.c (create_process) [!DOS_NT]:
3979 Remove now-unnecessary calls to emacs_close.
3980
f9a74c4c
EZ
39812013-07-13 Eli Zaretskii <eliz@gnu.org>
3982
922ae7ee
EZ
3983 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3984 returning early. (Bug#14850)
3985
f9a74c4c
EZ
3986 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3987 and inhibit-iso-escape-detection attributes of 'undecided'.
3988 (Bug#14822)
3989
5e301d76
PE
39902013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3991
69e0e5ee
PE
3992 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3993 Reported by Herbert J. Skuhra in
3994 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3995
5e301d76
PE
3996 Don't lose top specpdl entry when memory is exhausted.
3997 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3998 specpdl overflow here, to simplify callers; all callers changed.
3999 Always reserve an unused entry at the stack top; this avoids
4000 losing the top entry's information when memory is exhausted.
4001
7e649856
PE
40022013-07-12 Paul Eggert <eggert@cs.ucla.edu>
4003
a773ed9a
PE
4004 Clean up errno reporting and fix some errno-reporting bugs.
4005 * callproc.c (Fcall_process):
4006 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
4007 * process.c (create_process, Fmake_network_process):
4008 * unexaix.c (report_error):
4009 * unexcoff.c (report_error):
4010 Be more careful about reporting the errno of failed operations.
4011 The code previously reported the wrong errno sometimes.
4012 Also, prefer report_file_errno to setting errno + report_file_error.
4013 (Fcall_process): Look at openp return value rather than at path,
4014 as that's a bit faster and clearer when there's a numeric predicate.
4015 * fileio.c (report_file_errno): New function, with most of the
4016 old contents of report_file_error.
4017 (report_file_error): Use it.
4018 (Ffile_exists_p, Ffile_accessible_directory_p):
4019 Set errno to 0 when it is junk.
4020 * fileio.c (Faccess_file):
4021 * image.c (x_create_bitmap_from_file):
4022 Use faccessat rather than opening the file, to avoid the hassle of
4023 having a file descriptor open.
4024 * lisp.h (report_file_errno): New decl.
4025 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
4026
7e649856
PE
4027 Minor EBADF fixes.
4028 * process.c (create_process, wait_reading_process_output) [AIX]:
4029 Remove obsolete SIGHUP-related code, as Emacs no longer disables
4030 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
4031 a multithreaded environment anyway).
4032 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
4033
f6774c1a
AS
40342013-07-12 Andreas Schwab <schwab@linux-m68k.org>
4035
4036 * image.c (x_find_image_file): Don't close a remote file handle.
4037
bacba3c2
PE
40382013-07-12 Paul Eggert <eggert@cs.ucla.edu>
4039
4040 Fix races with threads and file descriptors.
4041 * callproc.c (Fcall_process_region):
4042 * dired.c (open_directory):
4043 * emacs.c (main, Fdaemon_initialized):
4044 * image.c (x_find_image_file):
4045 * inotify.c (Finotify_rm_watch):
4046 * lread.c (Flocate_file_internal):
4047 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
4048 * term.c (term_mouse_moveto, init_tty):
4049 * termcap.c (tgetent):
4050 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
4051 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
4052 * unexhp9k800.c, unexmacosx.c (unexec):
4053 * callproc.c (Fcall_process_region):
4054 Use emacs_close, not close.
4055 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
4056 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
4057 and posix_close function on current platforms (which all lack them).
4058 (emacs_close): Use it. This should fix the races on GNU/Linux and
4059 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
4060 and it should avoid closing random victim file descriptors on
4061 other platforms.
4062
653d4f43
PE
40632013-07-11 Paul Eggert <eggert@cs.ucla.edu>
4064
c8536ec4
PE
4065 * inotify.c (uninitialized): Remove. All uses replaced by -1.
4066 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
4067 Touch up doc a bit.
4068
9c203066
PE
4069 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
4070 This is for .gdbinit xbacktrace.
4071
653d4f43
PE
4072 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
4073 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
4074 (emacs_set_tty): Now static.
4075 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
4076 * term.c (tty_capable_p, tty_default_color_capabilities)
4077 (get_tty_terminal, term_mouse_movement)
4078 (handle_one_term_event, init_tty, maybe_fatal):
4079 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
4080 (tgetent, scan_file, name_match, compare_contin):
4081 * terminal.c (get_terminal):
4082 Use bool for boolean.
4083 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
4084 Prefer char to unsigned char if either will do.
4085 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
4086 (tty_write_glyphs): Prefer int to unsigned.
4087 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
4088 All callers changed.
4089 * termcap.c (tprint, main) [TEST]: Remove non-working test.
4090
45b683a1
PE
40912013-07-10 Paul Eggert <eggert@cs.ucla.edu>
4092
29abe551
PE
4093 Port to C89.
4094 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
4095 (B__dummy__): New dummy symbol, to pacify C89.
4096 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
4097 they can't grok varargs macros.
4098 * dispnew.c (add_window_display_history)
4099 (add_frame_display_history):
4100 * print.c (print_object):
4101 * xdisp.c (debug_method_add):
4102 Use %p printf format only for void pointers.
4103 * emacs.c (usage_message): New constant, replacing ...
4104 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
4105 (main): Adjust to usage reorg.
4106 * fns.c (syms_of_fns):
4107 * profiler.c (syms_of_profiler):
4108 Don't use non-constant struct initializers.
4109 * gnutls.h (gnutls_initstage_t):
4110 * lisp.h (enum Lisp_Fwd_Type):
4111 * lread.c (lisp_file_lexically_bound_p):
4112 * xsettings.c (anonymous enum):
4113 Remove trailing comma.
4114 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
4115 * lisp.h (ENUM_BF): Use unsigned if pedantic.
4116 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
4117 (DEFUN): Use it.
4118 * regex.c (const_re_char): New type, to pacify strict C89.
4119 All uses of 'const re_char' replaced to use it.
4120 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
4121 with glibc when strict C89. This change is imported from gnulib.
4122 All uses changed.
4123 (_Restrict_arr_): Rename from __restrict_arr, similarly.
4124 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
4125 Omit GNU_LINUX implementation, since it requires long long.
4126 * xterm.c (x_draw_underwave):
4127 Do not assume the traditional order of struct's members.
4128 (x_term_init): Rewrite to avoid the need for non-constant structure
4129 initializers.
4130
45b683a1 4131 Syntax cleanup, mostly replacing macros with functions.
763a086d 4132 This removes the need for the syntax_temp hack.
45b683a1
PE
4133 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
4134 * syntax.c (SYNTAX_INLINE): New macro.
4135 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
4136 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
4137 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
4138 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
4139 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
4140 (SYNTAX_COMEND_FIRST): Now functions, not macros.
4141 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
4142 Now constants, not macros.
4143 (syntax_temp) [!__GNUC__]: Remove.
4144 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
4145 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
4146 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
4147 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
4148 Move here from syntax.h; now functions, not macros. Except for the
4149 last function, these are static since only syntax.c uses them.
4150 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
4151 All uses changed. Now a function, not a macro; use this fact
4152 to simplify the code.
4153 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
4154 compiler bugs; no longer relevant.
4155 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4156 (SYNTAX_INLINE): New macro.
4157 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
4158 for the new functions. Use bool for boolean member.
4159 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
4160 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
4161 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
4162 (SETUP_BUFFER_SYNTAX_TABLE):
4163 Now extern inline functions, not macros.
4164 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
4165 Remove; all uses replaced by implementation.
4166 (syntax_temp) [!__GNUC__]: Remove decl.
4167 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
4168
29be4a50
JD
41692013-07-10 Jan Djärv <jan.h.d@swipnet.se>
4170
4171 * emacs.c (main): Fix syntax error.
4172
954b166e
PE
41732013-07-10 Paul Eggert <eggert@cs.ucla.edu>
4174
4175 Timestamp fixes for undo (Bug#14824).
4176 * atimer.c (schedule_atimer):
4177 * fileio.c (Ffile_newer_than_file_p):
4178 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
4179 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
4180 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
4181 (syms_of_fileio): Remove Sclear_visited_file_name.
4182 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
4183 file doesn't exist; this avoids an ambiguity with negative timestamps.
4184 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
4185 * systime.h (make_emacs_time, invalid_emacs_time):
4186 Don't assume struct timespec layout; POSIX doesn't guarantee it.
4187 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
4188 * undo.c (record_first_change): Push (visited-file-modtime) onto
4189 undo list rather than reimplementing it by hand, incorrectly.
4190
d74647c3
KB
41912013-07-09 Ken Brown <kbrown@cornell.edu>
4192
4193 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
4194
3c51b96b
JB
41952013-07-09 Juanma Barranquero <lekktu@gmail.com>
4196
4197 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
4198
4ebbdd67
PE
41992013-07-09 Paul Eggert <eggert@cs.ucla.edu>
4200
4201 Handle errno and exit status a bit more carefully.
4202 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
4203 number into an exit status. Instead, use EXIT_CANCELED.
4204 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
4205 * callproc.c (relocate_fd):
4206 * emacs.c (close_output_streams, main):
4207 * process.c (create_process):
4208 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
4209 Use emacs_perror for simplicity.
4210 * callproc.c (relocate_fd, main):
4211 * sysdep.c (sys_subshell):
4212 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
4213 (shut_down_emacs): Use emacs_write, not write.
4214 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
4215 * fileio.c (Fcopy_file, e_write):
4216 * nsterm.m (ns_select):
4217 * process.c (send_process):
4218 * sound.c (vox_write):
4219 Use emacs_write_sig, not emacs_write.
4220 * lisp.h (emacs_write_sig, emacs_perror): New decls.
4221 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
4222 New constants.
4223 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
4224 of write.
4225 (emacs_full_write): New function.
4226 (emacs_write): Rewrite to use it.
4227 (emacswrite_sig, emacs_perror): New functions.
4228 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
4229
44e18199 42302013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
4231
4232 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
4233 on NS even if it is present. Pixmap on NS is a void*.
4234
9caab067
PE
42352013-07-07 Paul Eggert <eggert@cs.ucla.edu>
4236
4237 Port to Ubuntu 10 (Bug#14803).
4238 Problem reported by T.V. Raman.
4239 * process.c (close_on_exec, accept4, process_socket):
4240 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
4241
1d442672
EZ
42422013-07-07 Eli Zaretskii <eliz@gnu.org>
4243
4244 * w32.c (sys_dup): Declare prototype.
4245
4246 * filelock.c:
4247 * emacs.c:
4248 * callproc.c [WINDOWSNT]: Include sys/socket.h.
4249
067428c1
PE
42502013-07-07 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 Make file descriptors close-on-exec when possible (Bug#14803).
4253 This simplifies Emacs a bit, since it no longer needs to worry
4254 about closing file descriptors by hand in some cases.
4255 It also fixes some unlikely races. Not all such races, as
4256 libraries often open files internally without setting
4257 close-on-exec, but it's an improvement.
4258 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
4259 * callproc.c (Fcall_process) [!MSDOS]:
4260 * emacs.c (main) [!DOS_NT]:
4261 * nsterm.m (ns_term_init):
4262 * process.c (create_process):
4263 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
4264 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
4265 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
4266 Prefer mkostemp with O_CLOEXEC to mkstemp.
4267 * callproc.c (relocate_fd) [!WINDOWSNT]:
4268 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
4269 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
4270 now using pipe2.
4271 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
4272 Make the resulting file descriptor close-on-exec.
4273 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
4274 * lread.c (load_descriptor_list, load_descriptor_unwind):
4275 Remove; no longer needed. All uses removed.
4276 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
4277 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
4278 New functions.
4279 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
4280 (Fmake_network_process, Fnetwork_interface_list):
4281 (Fnetwork_interface_info, server_accept_connection):
4282 Make newly-created socket close-on-exec.
4283 * sysdep.c (emacs_open, emacs_fopen):
4284 Make new-created descriptor close-on-exec.
4285 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
4286 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
4287
0da857dd
JD
42882013-07-07 Jan Djärv <jan.h.d@swipnet.se>
4289
4290 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
4291 for NS_IMPL_GNUSTEP.
4292
5f86adcd
PE
42932013-07-07 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 Fix openp errno handling.
4296 * callproc.c (Fcall_process): Preserve openp errno around close.
4297 * lread.c (openp): Set errno when returning -1, as some callers
4298 expect this.
4299
1afb1d07
JD
43002013-07-06 Jan Djärv <jan.h.d@swipnet.se>
4301
4302 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
4303
4304 * nsterm.h (NSSavePanel): Update comment.
4305 (NSAPP_DATA2_RUNFILEDIALOG): Define.
4306 (ns_run_file_dialog): Declare.
4307
4308 * nsfns.m: Remove panelOK.
4309 (ns_fd_data): New.
4310 (ns_run_file_dialog): New function.
4311 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
4312 event loop, so file dialog is popped up by ns_run_file_dialog, called
4313 by sendEvent (Bug#14578).
4314 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
4315
3323c263
EZ
43162013-07-06 Eli Zaretskii <eliz@gnu.org>
4317
fdda0220
EZ
4318 * xdisp.c (default_line_pixel_height): New function.
4319 (pos_visible_p, move_it_vertically_backward, try_scrolling)
4320 (try_cursor_movement, redisplay_window, try_window)
4321 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
4322
068f9124
SM
4323 * window.c (window_scroll_pixel_based):
4324 use default_line_pixel_height.
fdda0220
EZ
4325
4326 * dispextern.h (default_line_pixel_height): Add prototype.
4327
4328 * frame.c (x_set_line_spacing): Accept a float value for
4329 line-spacing parameter, per the documentation.
4330
3323c263
EZ
4331 * data.c (Fmultibyte_string_p): Doc fix.
4332
47ba6d43
PE
43332013-07-05 Paul Eggert <eggert@cs.ucla.edu>
4334
406af475
PE
4335 Use emacs_open more consistently when opening files.
4336 This handles EINTR more consistently now, and makes it easier
4337 to introduce other uniform changes to file descriptor handling.
4338 * src/systdio.h: New file.
4339 * src/buffer.c (mmap_init):
4340 * cygw32.c (chdir_to_default_directory):
4341 * dispnew.c (Fopen_termscript):
4342 * emacs.c (Fdaemon_initialized):
4343 * fileio.c (Fdo_auto_save):
4344 * image.c (slurp_file, png_load_body, jpeg_load_body):
4345 * keyboard.c (Fopen_dribble_file):
4346 * lread.c (Fload):
4347 * print.c (Fredirect_debugging_output):
4348 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
4349 * termcap.c (tgetent):
4350 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
4351 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
4352 * w32term.c (w32_initialize) [CYGWIN]:
4353 * xfaces.c (Fx_load_color_file):
4354 Use emacs_open instead of plain open, and emacs_fopen instead of
4355 plain fopen.
4356 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
4357 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
4358 * callproc.c (default_output_mode): New constant.
4359 (Fcall_process): Use it to call emacs_open instead of plain creat.
4360 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
4361 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
4362 (emacs_fopen): New function.
4363 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
4364 Include <lisp.h>, for emacs_open.
4365 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
4366
47ba6d43
PE
4367 Remove duplicate #include directives.
4368 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
4369 * xfaces.c:
4370 Don't include stdio.h twice.
4371 * buffer.c [USE_MMAP_FOR_BUFFERS]:
4372 Don't include sys/types.h or stdio.h twice.
4373 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
4374 * lread.c: Don't include coding.h twice.
4375 * nsfont.m: Don't include frame.h twice.
4376 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
4377 * ralloc.c: Don't include <unistd.h> twice.
4378 * xdisp.c: Don't include font.h twice.
4379 * xterm.c: Don't include fontset.h twice.
4380 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
4381
b9ed53d5
PE
43822013-07-04 Paul Eggert <eggert@cs.ucla.edu>
4383
4384 Scale ImageMagick images more carefully.
4385 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
4386 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
4387 Be more careful about avoiding undefined behavior after
4388 integer overflow and division by zero.
4389
cf13177e
YM
43902013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4391
4392 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
4393 (syms_of_w32fns): DEFSYM them.
4394 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
4395 (CCHDEVICENAME): Define macros if not defined.
4396 (struct MONITOR_INFO_EX): New struct.
4397 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
4398 (enum_display_monitors_fn): New variable.
4399 (globals_of_w32fns): Initialize it.
4400 (Fx_display_pixel_width, Fx_display_pixel_height)
4401 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
4402 multi-monitor setups in docstrings.
4403 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
4404 screen size by primary monitor's millimeter per pixel.
4405 (w32_monitor_enum, w32_display_monitor_attributes_list)
4406 (w32_display_monitor_attributes_list_fallback)
4407 (Fw32_display_monitor_attributes_list): New functions.
4408 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
4409
4410 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
4411 if not defined.
4412 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
4413
86dfb7a8
MA
44142013-07-04 Michael Albinus <michael.albinus@gmx.de>
4415
4416 * fileio.c (Qfile_notify_error): New error symbol.
4417
4418 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
4419 * inotify.c (inotify_callback, symbol_to_inotifymask)
4420 (Finotify_add_watch, Finotify_rm_watch): Use it.
4421 (inotifyevent_to_event): Exchange order of cookie and file name.
4422 (Finotify_add_watch): Adapt docstring.
4423
4424 * lisp.h (Qfile_notify_error): Declare.
4425
2c1c974b
PE
44262013-07-04 Paul Eggert <eggert@cs.ucla.edu>
4427
4428 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
4429 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4430 Do not clear _malloc_thread_enabled_p, undoing the previous change,
4431 which did not work (see <http://bugs.gnu.org/14569#307>).
4432 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
4433 && (!noninteractive || initialized)). This attempts to thread
4434 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
4435
7a35b20f
JB
44362013-07-04 Juanma Barranquero <lekktu@gmail.com>
4437
4438 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
4439 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
4440
1ce5cd04
PE
44412013-07-04 Paul Eggert <eggert@cs.ucla.edu>
4442
4443 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
4444 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4445 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
4446 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
4447
57f8c490
PE
44482013-07-02 Paul Eggert <eggert@cs.ucla.edu>
4449
4450 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
4451 Define to __sys_siglist.
4452
bcffb5ca
EZ
44532013-07-02 Eli Zaretskii <eliz@gnu.org>
4454
4455 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
4456 word-wrap, so that overflow-newline-into-fringe would work in
4457 visual-line-mode. (Bug#2749)
4458 (move_it_in_display_line_to): When the last scanned display
4459 element fits exactly on the display line, and
4460 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
4461 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
4462 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
4463 finding buffer position that corresponds to pixel coordinates,
4464 e.g. in buffer_posn_from_coords.
4465
2c41e781
JD
44662013-07-02 Jan Djärv <jan.h.d@swipnet.se>
4467
4468 * process.c (handle_child_signal): Call catch_child_signal if
4469 NS_IMPL_GNUSTEP.
4470
c2418359
PE
44712013-07-02 Paul Eggert <eggert@cs.ucla.edu>
4472
52a9bcae
PE
4473 Don't convert function pointers to void * and back.
4474 It isn't portable C, and it's easy enough to avoid.
4475 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
4476 (make_save_value): Add support for SAVE_FUNCPOINTER.
4477 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
4478 * print.c (print_object):
4479 Distinguish function from object pointers.
4480 * lisp.h (SAVE_FUNCPOINTER): New constant.
4481 (SAVE_SLOT_BITS): Adjust to it.
4482 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
4483 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
4484 (voidfuncptr): New typedef.
4485 (struct Lisp_Save_Value): New member data[0].funcpointer.
4486 (XSAVE_FUNCPOINTER): New function.
4487
c2418359
PE
4488 Simplify buildobj processing.
4489 * Makefile.in (buildobj.h): Make it a sequence of strings each
4490 followed by comma, rather than a single string. Put it into a
4491 .tmp file in case there's an error while generating it.
4492 (gl-stamp): Use .tmp for temp files.
4493 (mostlyclean): Clean .tmp files.
4494 * doc.c (buildobj): Move to just the routine that needs it.
4495 It's now an array of strings, so processing is simpler.
4496
8f43ce49
PE
44972013-07-01 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
4500 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
4501 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4502 Invoke malloc_enable_thread even when not interactive.
4503 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
4504 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
4505 in this case, since the underlying bug has now been fixed.
4506
24827db9
JB
45072013-07-01 Juanma Barranquero <lekktu@gmail.com>
4508
4509 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
4510 unlinking it (bug#14691).
4511
ef099a94
MN
45122013-06-30 Michal Nazarewicz <mina86@mina86.com>
4513
4514 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
4515 before checking whether buffer is modified. This lets
4516 `kill-buffer-query-functions' cancel killing of the buffer or save
4517 its content before `kill-buffer' asks user the "Buffer %s
4518 modified; kill anyway?" question.
4519
9d3f2fc2
JD
45202013-06-30 Jan Djärv <jan.h.d@swipnet.se>
4521
4522 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
4523 Let the super performKeyEquivalent deal with them (Bug#14747).
4524
e6c6c8c7
PE
45252013-06-30 Paul Eggert <eggert@cs.ucla.edu>
4526
1d71c1d9
PE
4527 * widget.c (resize_cb): Remove unused local.
4528
8f5f35cc
PE
4529 Do not use GTK 3 if it exists but cannot be compiled.
4530 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
4531 * xterm.c (x_error_handler) [!USE_GTK]:
4532 Do not use GTK 3.
4533
e6c6c8c7
PE
4534 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
4535
0ba54312
EZ
45362013-06-30 Eli Zaretskii <eliz@gnu.org>
4537
5d1c3286
EZ
4538 * intervals.c (get_local_map): Instead of aborting, clip POSITION
4539 to the valid range of values. (Bug#14753)
4540
0ba54312
EZ
4541 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
4542 when moving point by using the current glyph matrix. This avoids
4543 the need to force redisplay when this function is called in a
4544 loop.
4545
9c90cc06
PE
45462013-06-29 Paul Eggert <eggert@cs.ucla.edu>
4547
4548 Fix minor problems found by static checking.
4549 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
4550 Redo the latter's body to sidestep GCC parenthesization warnings.
4551 (setup_coding_system, detect_coding, detect_coding_system): Use them.
4552 * coding.c (detect_coding, detect_coding_system):
4553 * coding.h (struct undecided_spec):
4554 Use bool for boolean.
4555 * image.c (QCmax_width, QCmax_height): Now static.
4556 * xdisp.c (Fmove_point_visually): Remove unused local.
4557
4c672a0f
EZ
45582013-06-29 Eli Zaretskii <eliz@gnu.org>
4559
4560 * xdisp.c (Fmove_point_visually): New function.
4561
c1ea3abf
JB
45622013-06-28 Kenichi Handa <handa@gnu.org>
4563
4564 * coding.h (define_coding_undecided_arg_index): New enum.
4565 (coding_attr_index): New members
4566 coding_attr_undecided_inhibit_null_byte_detection,
4567 coding_attr_undecided_inhibit_iso_escape_detection,
4568 coding_attr_undecided_prefer_utf_8.
4569 (undecided_spec): New struct.
4570 (struct coding_system): New member `undecided' of the member
4571 `spec'.
4572
4573 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
4574 (detect_coding): Likewise.
4575 (detect_coding_system): Likewise.
4576 (Fdefine_coding_system_internal): New coding system properties
4577 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
4578 :prefer-utf-8.
4579 (syms_of_coding): Adjust for coding_arg_undecided_max.
4580
ba3de9e6
PE
45812013-06-28 Paul Eggert <eggert@cs.ucla.edu>
4582
4583 * image.c (x_from_xcolors): Remove unused local.
4584
547c9269
YM
45852013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4586
4587 Defer image data transfer between X client and server until actual
4588 display happens.
4589
4590 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
4591 and `mask_img'.
4592
4593 * image.c (Destroy_Image): Remove.
4594 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
4595 `mask_p', and `colors_p'. All uses changed.
4596 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
4597 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
4598 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
4599 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
4600 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 4601 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
4602 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
4603 (image_get_x_image, image_unget_x_image): New functions or macros.
4604 (image_background, image_background_transparent, x_to_xcolors)
4605 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
4606 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
4607 instead of Destroy_Image.
4608 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
4609 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
4610 (png_load_body, jpeg_load_body, tiff_load, gif_load)
4611 (imagemagick_load_image, svg_load_image): Use them instead of
4612 x_create_x_image_and_pixmap, and x_put_x_image followed by
4613 x_destroy_x_image, respectively.
4614 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
4615 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
4616 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
4617 background_transparent fields.
4618 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
4619 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
4620
dae2f5ef
PE
46212013-06-27 Paul Eggert <eggert@cs.ucla.edu>
4622
4623 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
4624 This mostly consists of undoing recent changes.
4625 * callproc.c (Fcall_process):
4626 * process.c (create_process):
4627 Do not worry about catching SIGCHLD here, undoing previous change.
4628 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
4629 * process.c, process.h (catch_child_signal):
4630 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
4631 * process.c (catch_child_handler): Don't worry about being called
4632 lazily and do not assume caller has blocked SIGCHLD, undoing
4633 previous change. Move first-time stuff back to
4634 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
4635 tickle glib, as that causes Cygwin bootstrap to fail. Do not
4636 set lib_child_handler if it's already initialized, which may
4637 help avoid problems on GNUStep.
4638
fa55d2aa
PE
46392013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4640
4641 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
4642 * callproc.c (Fcall_process):
4643 * process.c (create_process):
4644 Make sure SIGCHLD is caught before we fork,
4645 since Emacs startup no arranges to catch SIGCHLD.
4646 * process.c (lib_child_handler): Initialize to null, not to
4647 dummy_handler.
4648 (catch_child_signal): Allow self to be called lazily.
4649 Do nothing if it's already been called.
4650 Assume caller has blocked SIGCHLD (all callers do now).
4651 * emacs.c (main): Do not catch SIGCHLD here; defer it until
4652 just before it's really needed.
4653 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
4654 since it hasn't been caught yet.
4655
f3f9606c
LMI
46562013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
4657
4658 * image.c (compute_image_size): New function to implement
4659 :max-width and :max-height.
4660 (imagemagick_load_image): Use it.
4661
c7041908
PE
46622013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4663
4664 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
4665 * callproc.c, process.h (block_child_signal, unblock_child_signal):
4666 Now extern.
4667 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
4668 * process.c (catch_child_signal): Block SIGCHLD while futzing with
4669 the SIGCHLD handler, since the code is not atomic and (due to glib)
4670 signals may be arriving now.
4671 * sysdep.c (init_signals): Do not catch child signals here;
4672 'main' now does that later, at a safer time.
4673
f86852b4
PE
46742013-06-22 Paul Eggert <eggert@cs.ucla.edu>
4675
0dfeed58
PE
4676 Clean up SIGCHLD handling a bit (Bug#14569).
4677 * process.c, process.h (catch_child_signal):
4678 Now always extern, even if !NS_IMPL_GNUSTEP.
4679 * process.c (catch_child_signal): Move glib tickler here from
4680 init_process_emacs, so that it's done earlier in Emacs
4681 initialization. Also move the noninteractive && !initialized
4682 check here from init_process_emacs. This is all a bit cleaner for
4683 GNUish platforms, and I hope it works around the Cygwin bug.
4684 * sysdep.c (init_signals): Invoke catch_child_signal here, so
4685 that glib signal handling is tickled before glib creates threads.
4686
f86852b4
PE
4687 * process.c (wait_reading_process_output): Avoid int overflow
4688 when reading more than 2 GiB total from a process.
4689
cbd6509c
PE
46902013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4691
4692 * process.c (create_process): Handle a couple more cases,
4693 i.e., work even if new_argv and wait_child_setup[i] are cached.
4694 Use Fcall_process's style for volatile vars.
4695
9de1114a
AS
46962013-06-21 Andreas Schwab <schwab@linux-m68k.org>
4697
4698 * process.c (create_process): Mark PROCESS volatile.
4699
fbe9e0b9
PE
47002013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4701
4702 Use C99-style flexible array members if available.
4703 This avoids some subtle aliasing issues, which typically
4704 aren't a problem with GCC but may be a problem elsewhere.
4705 * alloc.c (sdata): New typedef, replacing the old struct sdata.
4706 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
4707 In either case, it uses a flexible array member rather than
4708 the old struct hack. All uses changed.
4709 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
4710 Adjust to sdata reorganization.
4711 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
4712 Use offsetof (struct, flex_array_member), not sizeof (struct), as
4713 that ports better to pre-C99 non-GCC.
4714 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
4715 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
4716 as the latter has changed.
4717 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
4718 and port better to pre-C99 GCC.
4719 * image.c (struct xpm_cached_color):
4720 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
4721 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
4722 Use FLEXIBLE_ARRAY_MEMBER.
4723 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
4724 Move decl to top level so it gets checked against implementation.
4725 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
4726 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
4727
1fc71008
PE
47282013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4729
4730 * syntax.c: Integer cleanups.
4731 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
4732 All uses that need 0-or-2 changed to:
4733 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
4734 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
4735 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
4736 (char_quoted, prev_char_comend_first, back_comment)
4737 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4738 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
4739 Use bool for boolean.
4740 (update_syntax_table, skip_chars, skip_syntaxes):
4741 Prefer int to unsigned when either will do.
4742 (back_comment): Return boolean success flag, like forw_comment,
4743 instead of positive-or-minus-1 (which might have overflowed int anyway).
4744 Don't stuff ptrdiff_t into int.
4745 (syntax_spec_code, syntax_code_spec): Now const.
4746 (Fmatching_paren, scan_lists, scan_sexps_forward):
4747 Use enum syntaxcode for syntax code.
4748 (Fmatching_paren): Check that arg is a character, not just an integer.
4749 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
4750 (Finternal_describe_syntax_value): Omit no-longer-needed
4751 comparison to 0.
4752 (skip_chars): Use char, not unsigned char, when the distinction
4753 doesn't matter.
4754 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
4755 * bytecode.c (exec_byte_code):
4756 * syntax.c (syntax_spec_code, Fchar_syntax)
4757 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4758 (init_syntax_once):
4759 * syntax.h (SYNTAX_WITH_FLAGS):
4760 Omit unnecessary casts.
4761
b932cad7
EZ
47622013-06-20 Eli Zaretskii <eliz@gnu.org>
4763
4764 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
4765 line dimensions here, to avoid race conditions with the main
4766 thread. (Bug#14062, bug#14630, bug#14669)
4767
4768 * w32term.c (w32_draw_window_cursor): Compute the header line and
4769 mode line dimensions here.
4770 <w32_system_caret_window, w32_system_caret_hdr_height>:
4771 <w32_system_caret_mode_height>: New variables.
4772
4773 * w32term.h: Declare them.
4774
89561f72
PE
47752013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4776
5013fc08
PE
4777 * alloc.c (die): Move "assertion failed" string here ...
4778 * lisp.h (eassert): ... from here. Also, suppress evaluation of
4779 COND when SUPPRESS_CHECKING. This shrinks the executable text
4780 size by 0.8% to 2.2% when configured with --enable-checking,
4781 depending on optimization flags (GCC 4.8.1 x86-64).
4782
89561f72
PE
4783 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
4784
763a086d 47852013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
4786
4787 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4788 base is 2; this is more accurate.
4789
983aeb9a
JB
47902013-06-19 Juanma Barranquero <lekktu@gmail.com>
4791
4792 * sound.c (string_default): Move to !WINDOWSNT section.
4793 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4794
178ba3e6
PE
47952013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4796
bbc51b15
PE
4797 * sound.c: Integer cleanups.
4798 Remove unnecessary forward decls.
4799 (struct sound_device): The 'file' member is now a Lisp_Object, not
4800 a char *, so that we needn't invoke alloca on a huge size.
4801 (Fplay_sound_internal): Adjust to this.
4802 (string_default): New function.
4803 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4804 Use it to adjust to the struct sound_device change.
4805 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4806 (be2hs) [0]: Remove.
4807
178ba3e6
PE
4808 * syntax.c (skip_chars): Don't use uninitialized storage
4809 when searching a multibyte buffer for characters that are not in a
4810 unibyte string that contains non-ASCII characters.
4811
69f60cdc
JD
48122013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4813
4814 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4815 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4816
0d6224d4
PE
48172013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4818
4819 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4820
3c542890
KH
48212013-06-18 Kenichi Handa <handa@gnu.org>
4822
f7e3f7cd
KH
4823 * font.c (Ffont_spec): Signal an error for an invalid font name
4824 (Bug#14648).
3c542890 4825
9349e5f7
PE
48262013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4827
4828 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4829 In particular this ports to 32-bit sparc Sun cc.
4830 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4831 array with a dummy element at specpdl[-1], so that its address can
4832 be taken portably.
4833 (unbind_to): Do not copy the binding; not needed, now that we
4834 copy old_value in the one place where the copy is needed.
4835 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4836 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4837 (union specbinding): Rename from struct specbinding. Redo layout
4838 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4839 which is not portable. With Sun C 5.12 32-bit sparc, the
4840 declaration causes nargs to be an unsigned bitfield, a behavior
4841 that the C standard allows; but Emacs wants nargs to be signed.
4842 The overall type is now a union of structures rather than a
4843 structure of union of structures, and the 'kind' member is now a
4844 bitfield, so that the overall type doesn't grow. All uses changed.
4845 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4846
0a4df6a5
PE
48472013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4848
ec6ecaad
PE
4849 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4850 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4851
0a4df6a5
PE
4852 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4853
7bfe8dbc
EZ
48542013-06-17 Eli Zaretskii <eliz@gnu.org>
4855
4856 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4857 unless we know that the window w's frame is a frame object.
4858 Another attempt at solving bug#14062 and bug#14630.
4859
708e05f6
LMI
48602013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4861
4862 * textprop.c (property_set_type): New enum.
4863 (add_properties): Allow appending/prepending text properties.
4864 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4865 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4866 add_text_properties_1.
4867 (Fadd_face_text_property): New function that calls
4868 add_text_properties_1.
4869
84575e67
PE
48702013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 Move functions from lisp.h to individual modules when possible.
4873 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4874 * alloc.c (XFLOAT_INIT, set_symbol_name):
4875 * buffer.c (CHECK_OVERLAY):
4876 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4877 (set_char_table_parent):
4878 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4879 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4880 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4881 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4882 (set_blv_valcell):
4883 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4884 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4885 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4886 (backtrace_args, backtrace_debug_on_exit):
4887 * floatfns.c (CHECK_FLOAT):
4888 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4889 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4890 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4891 (set_hash_index_slot):
4892 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4893 * marker.c (CHECK_MARKER):
4894 * textprop.c (CHECK_STRING_OR_BUFFER):
4895 * window.c (CHECK_WINDOW_CONFIGURATION):
4896 Move here from lisp.h, and make these functions static rather than
4897 extern inline.
4898 * buffer.c (Qoverlayp):
4899 * data.c (Qsubrp):
4900 * fns.c (Qhash_table_p):
4901 * window.c (Qwindow_configuration_p):
4902 Now static.
4903 * lisp.h: Remove the abovementioned defns and decls.
4904
44e18199 4905 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4906 In lisp.h, prefer functions to function-like macros, and
4907 constants to object-like macros, when either will do. This:
4908 . simplifies use, as there's no more need to worry about
4909 arguments' side effects being evaluated multiple times.
4910 . makes the code easier to debug on some platforms.
4911 However, when using gcc -O0, keep using function-like macros
4912 for a few critical operations, for performance reasons.
4913 This sort of thing isn't needed with gcc -Og, but -Og
4914 is a GCC 4.8 feature and isn't widely-enough available yet.
4915 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4916 Remove enum lsb_bits; no longer needed.
4917 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4918 * buffer.c (Qoverlap):
4919 * data.c (Qsubrp):
4920 * fns.c (Qhash_table_p):
4921 Now extern, so lisp.h can use these symbols.
4922 * dispextern.h: Include character.h, for MAX_CHAR etc.
4923 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4924 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4925 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4926 (GLYPH_CODE_P): Move here from lisp.h.
4927 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4928 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4929 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4930 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4931 XUNTAG now returns void *.
4932 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4933 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4934 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4935 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4936 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4937 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4938 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4939 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4940 New macros, renamed from their sans-lisp_h_ counterparts.
4941 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4942 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4943 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4944 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4945 If compiling via GCC without optimization, define these as macros
4946 in addition to inline functions.
4947 To disable this, compile with -DINLINING=0.
4948 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4949 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4950 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4951 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4952 (INTMASK, VALMASK): Now macros, since static values cannot be
4953 accessed from extern inline functions.
4954 (VALMASK): Also a constant, for benefit of old GDB.
4955 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4956 is INTEGERP, which can fold it in.
5165d44a 4957 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4958 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4959 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4960 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4961 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4962 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4963 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4964 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4965 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4966 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4967 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4968 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4969 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4970 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4971 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4972 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4973 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4974 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4975 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4976 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4977 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4978 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4979 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4980 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4981 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4982 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4983 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4984 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4985 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4986 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4987 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4988 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4989 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4990 Now functions.
4991 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4992 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4993 (VALMASK): Define in one place rather than in two, merging the
4994 USE_LSB_TAG parts; this is simpler.
4995 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4996 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4997 Move up, to avoid use before definition.
4998 Also include "globals.h" earlier, for the same reason.
4999 (make_natnum): New function.
5000 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
5001 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
5002 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
5003 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
5004 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
5005 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
5006 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
5007 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
5008 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
5009 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
5010 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
5011 (Qwindow_configuration_p, Qimage): New forward declarations.
5012 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
5013 (STRING_COPYIN): Remove; unused.
5014 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
5015 (xcar_addr, xcdr_addr): New functions. All uses changed.
5016 (IEEE_FLOATING_POINT): Now a constant, not a macro.
5017 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
5018 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
5019 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
5020 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
5021 (TYPE_RANGED_INTEGERP): Simplify.
5022 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
5023 (setlocale, fixup_locale, synchronize_system_messages_locale)
5024 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
5025 Now empty functions, not macros.
5026 (functionp): Return bool, not int.
5027 * window.c (Qwindow_configuration_p): Now extern,
5028 so window.h can use it.
5029 * window.h (Qwindowp): Move decl back to lisp.h.
5030
9583ec36
EZ
50312013-06-15 Eli Zaretskii <eliz@gnu.org>
5032
5033 * xdisp.c (Fline_pixel_height): New function, required for solving
5034 bug #14567.
5035
210272ce
PE
50362013-06-15 Paul Eggert <eggert@cs.ucla.edu>
5037
5038 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
5039
de0503df
SM
50402013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
5041
5042 * lread.c (syms_of_lread):
5043 * fns.c (Fprovide): Adjust to new format of after-load-alist.
5044
afbfe143
KD
50452013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
5046
5047 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
5048
d177e213
XF
50492013-06-12 Xue Fuqiao <xfq.free@gmail.com>
5050
5051 * fileio.c (expand_file_name): Doc fix.
5052
05e3e412
PE
50532013-06-11 Paul Eggert <eggert@cs.ucla.edu>
5054
f7394b12
PE
5055 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
5056 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
5057 Wait for self, not for 0. This can't hurt on GNU or similar
5058 system, and may help with Cygwin.
5059
05e3e412
PE
5060 * keyboard.c: Don't use PROP (...) as an lvalue.
5061 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
5062 Use set_prop (A, B), not PROP (A) = B.
5063
17dd3097
EZ
50642013-06-10 Eli Zaretskii <eliz@gnu.org>
5065
5066 * xdisp.c (get_it_property): Use it->window instead of generating
5067 a Lisp object from it->w.
5068
52fab9c9
EZ
50692013-06-09 Eli Zaretskii <eliz@gnu.org>
5070
5071 * xdisp.c (get_it_property): If it->object is a buffer, pass to
5072 get-char-property the window that is being rendered, instead of
5073 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
5074 (compute_display_string_pos): When W is NULL, use the current
5075 buffer as the object to pass to get-char-property.
5076 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
5077 pointer member of the bidi iterator, since no window is pertinent
5078 to this function.
52fab9c9 5079
5bf97bfc
EZ
50802013-06-08 Eli Zaretskii <eliz@gnu.org>
5081
5082 * bidi.c (bidi_fetch_char): Accept additional argument, the window
5083 being displayed, and pass it to compute_display_string_pos.
5084 (bidi_level_of_next_char, bidi_resolve_explicit_1)
5085 (bidi_paragraph_init): All callers changed.
5086
5087 * xdisp.c (init_from_display_pos, init_iterator)
5088 (handle_single_display_spec, next_overlay_string)
5089 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
5090 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
5091 Set bidi_it.w member from it->w.
5bf97bfc
EZ
5092 (compute_display_string_pos): Accept additional argument, the
5093 window being displayed, and pass it to Fget_char_property.
5094 (Bug#14575)
5095
5096 * dispextern.h (struct bidi_it): New member w, the window being
5097 displayed.
5098 (compute_display_string_pos): Adjust prototype.
5099
5de0e011
JD
51002013-06-08 Jan Djärv <jan.h.d@swipnet.se>
5101
e7b41c4c 5102 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
5103
5104 * process.c (wait_reading_process_output): Check for NS before GLIB.
5105 GLIB may be linked in due to rsvg, but ns_select must be called.
5106
5de0e011
JD
5107 * xgselect.c (xg_select): Remove call to window_system_available
5108 and g_main_context_pending at the top, so Gdk events (i.e. file
5109 notify) are processed when Emacs is started with -nw.
5110
a822acff
EZ
51112013-06-07 Eli Zaretskii <eliz@gnu.org>
5112
5113 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
5114 (ctagsfiles3): New variable, includes only *.m files.
5115 (TAGS): Use an explicit language name in the regular expressions,
5116 to avoid transformation of '/SOMETHING' by MSYS to
5117 'c:\MSYS\SOMETHING'.
5118
6c0a9ed1
RC
51192013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
5120
5121 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
5122
9ef6111b
EZ
51232013-06-06 Eli Zaretskii <eliz@gnu.org>
5124
5125 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
5126 still need to set the mouse pointer shape and activate help-echo.
5127 (Bug#14558)
5128
7d300d64
PE
51292013-06-06 Paul Eggert <eggert@cs.ucla.edu>
5130
5131 A few porting etc. fixes for the new file monitor code.
5132 See the thread containing
5133 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
5134 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
5135 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
5136 (dir_monitor_callback, Fgfile_rm_watch):
5137 Use assq_no_quit instead of Fassoc, for speed.
5138 (dir_monitor_callback, Fgfile_rm_watch):
5139 eassert that the monitor is a fixnum.
5140 (dir_monitor_callback): No need for CDR_SAFE.
5141 Simplify building of lisp with alternative tails.
5142 (Fgfile_add_watch, Fgfile_rm_watch):
5143 Do not assume glib functions set errno reliably on failure.
5144 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
5145 and signal an error otherwise.
5146 (Fgfile_rm_watch): Prefer CONSP to !NILP.
5147 Use Fdelq instead of Fdelete, for speed.
5148
817ebfcf
EZ
51492013-06-05 Eli Zaretskii <eliz@gnu.org>
5150
5151 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
5152 don't insist on being invoked on a highlighted tool-bar button.
5153 Avoids losing tool-bar functionality when mouse-highlight is nil.
5154 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
5155 Don't highlight when mouse-highlight is nil.
5156 (note_mouse_highlight): When mouse-highlight is nil, don't return
5157 right away; instead, run tool-bar and mode-line highlight
5158 subroutine, clear any existing highlight, and revert the mouse
5159 pointer to its default shape. (Bug#14558)
5160
55577e7c
SM
51612013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
5162
5163 * lisp.mk (lisp): Add prog-mode.el.
5164
f019a684
PE
51652013-06-05 Paul Eggert <eggert@cs.ucla.edu>
5166
5167 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
5168 * process.c (dummy_handler): New function.
5169 (lib_child_handler): New static var.
5170 (handle_child_signal): Invoke it.
5171 (catch_child_signal): If a library has set up a signal handler,
5172 save it into lib_child_handler.
5173 (init_process_emacs): If using glib and not on Windows, tickle glib's
5174 child-handling code so that it initializes its private SIGCHLD handler.
5175 * syssignal.h (SA_SIGINFO): Default to 0.
5176 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
5177 31; it should no longer be needed now.
5178
90db8702
MA
51792013-06-05 Michael Albinus <michael.albinus@gmx.de>
5180
5181 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
5182
5183 * gfilenotify.c (globals_of_gfilenotify): New function.
5184 (syms_of_gfilenotify): Move global initialization there.
5185
5186 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
5187
bfa3acd6
SM
51882013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
5189
5190 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
5191 * keyboard.c (menu_bar_items, tool_bar_items):
5192 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
5193 not override local keymaps any more.
5194
ba59bd80
EZ
51952013-06-04 Eli Zaretskii <eliz@gnu.org>
5196
5197 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
5198
7f203aa1
EZ
51992013-06-03 Eli Zaretskii <eliz@gnu.org>
5200
9337e206
EZ
5201 * w32console.c (initialize_w32_display): Return the dimensions of
5202 the console window via 2 additional arguments, not via the current
5203 frame. This avoids crashes due to overrunning the bounds of
5204 frame's decode_mode_spec_buffer, which is not resized following
5205 the change of the frame dimensions from the initial 10x10.
5206
5207 * w32term.h (w32_initialize_display_info): Adjust prototype.
5208
5209 * term.c (init_tty): Take dimensions of the frame from the values
5210 returned by initialize_w32_display.
5211
7f203aa1
EZ
5212 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
5213 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
5214 (LIBES): Add $(GFILENOTIFY_LIBS).
5215
5216 * w32inevt.c (handle_file_notifications): Add dummy implementation
5217 for !HAVE_W32NOTIFY.
5218
5219 * w32term.c: Wrap code with HAVE_W32NOTIFY.
5220
55a87246
JD
52212013-06-03 Jan Djärv <jan.h.d@swipnet.se>
5222
5223 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
5224
5225 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
5226
5227 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
5228
3d5ee10a
PE
52292013-06-03 Paul Eggert <eggert@cs.ucla.edu>
5230
5231 Fix minor problems found by static checking.
5232 * data.c (pure_write_error):
5233 Use xsignal2, not Fsignal, as Fsignal might return.
5234 * eval.c (set_backtrace_debug_on_exit): Now static.
5235 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
5236 No longer inline. EXTERN_INLINE is needed only for functions
5237 defined in .h files. Reindent function header as per GNU style.
5238 (backtrace_p, backtrace_top, backtrace_next):
5239 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
5240 compiler or linker. Add extern decls to pacify gcc -Wall.
5241 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
5242 Now static.
5243 * frame.c (free_monitors): Define only on platforms that need it.
5244 * nsterm.m (ns_term_init):
5245 * process.c (catch_child_signal):
5246 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
5247 defined on all porting targets these days.
5248 * process.c, process.h (catch_child_signal):
5249 Make it extern only if NS_IMPL_GNUSTEP is defined.
5250
e2d8a6f0
EZ
52512013-06-03 Eli Zaretskii <eliz@gnu.org>
5252
5253 * w32.c (gettimeofday): Make the signature identical to prototype
5254 in nt/inc/sys/time.h.
5255
a8a7c5f6
SM
52562013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
5257
5258 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
5259 .gdbinit.
5260
5261 * keyboard.c (safe_run_hooks_error): Improve error message.
5262
5263 * data.c (pure_write_error): Add `object' argument.
5264 * puresize.h (CHECK_IMPURE): Use it.
5265
c9628c79
MA
52662013-06-03 Michael Albinus <michael.albinus@gmx.de>
5267
5268 * Makefile.in (NOTIFY_OBJ): New variable.
5269 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
5270
5271 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
5272 Call syms_of_gfilenotify.
5273
5274 * gfilenotify.c: New file.
5275
5276 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
5277 and Qfile_w32notify.
5278 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
5279 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
5280
5281 * lisp.h: Declare syms_of_gfilenotify.
5282
5283 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
5284
2f592f95
SM
52852013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
5286
5287 Merge the specpdl and backtrace stacks. Make the structure of the
5288 specpdl entries more obvious via a tagged union of structs.
5289 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
5290 (enum specbind_tag): New enum.
5291 (struct specbinding): Make it a tagged union of structs.
5292 Add a case for backtrace records.
5293 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
5294 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
5295 (backtrace_debug_on_exit): New accessors.
5296 (struct backtrace): Remove.
5297 (struct catchtag): Remove backlist field.
5298 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
5299 Move to eval.c.
5300 (Flocal_variable_p): Speed up the common case where the binding is
5301 already loaded.
5302 * eval.c (backtrace_list): Remove.
5303 (set_specpdl_symbol, set_specpdl_old_value): Remove.
5304 (set_backtrace_args, set_backtrace_nargs)
5305 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
5306 (backtrace_next): New functions.
5307 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
5308 (unwind_to_catch, internal_lisp_condition_case)
5309 (internal_condition_case, internal_condition_case_1)
5310 (internal_condition_case_2, internal_condition_case_n): Don't bother
5311 with backtrace_list any more.
5312 (Fsignal): Adjust to new backtrace format.
5313 (grow_specpdl): Move up.
5314 (record_in_backtrace): New function.
5315 (eval_sub, Ffuncall): Use it.
5316 (apply_lambda): Adjust to new backtrace format.
5317 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
5318 data.c.
5319 (specbind): Adjust to new specpdl format. Simplify.
5320 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
5321 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
5322 backtrace format.
5323 (mark_backtrace): Remove.
5324 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
5325 * xdisp.c (redisplay_internal): Use record_in_backtrace.
5326 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
5327 Use mark_specpdl.
5328 * profiler.c (record_backtrace): Use get_backtrace.
5329 (handle_profiler_signal): Use backtrace_top_function.
5330 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
5331 accessor functions.
5332
c0342369
JD
53332013-06-02 Jan Djärv <jan.h.d@swipnet.se>
5334
5335 * process.h (catch_child_signal): Declare.
5336
5337 * process.c (catch_child_signal): New function.
5338 (init_process_emacs): Call it.
5339
5340 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
5341 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
5342 NS_IMPL_COCOA.
5343 (x_set_cursor_type): Remove declaration.
5344 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
5345 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
5346 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
5347 (ns_get_color): Use F suffix on float.
5348 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
5349 (ns_get_rgb_color): Remove.
5350 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
5351 (note_mouse_movement): x and y are CGFloat.
5352 (ns_draw_fringe_bitmap): Remove unused rowY.
5353 Change #if to COCOA && >= 10_6.
5354 (ns_draw_window_cursor): Remove unused overspill.
5355 (ns_draw_underwave): width and x are EamcsCGFloat.
5356 (ns_draw_box): thickness is CGFloat.
5357 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
5358 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
5359 if not in main thread.
5360 (ns_get_pending_menu_title, ns_check_menu_open)
5361 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
5362 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
5363 (sendFromMainThread:): New method.
5364 (changeFont:): size is CGFloat.
5365 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
5366 Disable warning about permanent text.
5367 (characterIndexForPoint:): Adjust return type depending on GNUStep
5368 version.
5369 (mouseDown:): delta is CGFloat.
5370 (updateFrameSize): Remove unised variable f.
5371 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
5372 Cast float to EmacsCGFloat.
5373 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
5374 also to -1 when restoring.
5375 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
5376 inside NS_IMPL_COCOA.
5377 (toggleFullScreen:): Put call to toggleFullScreen inside
5378 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
5379 (setPosition:portion:whole:): por is CGFloat.
5380 (getMouseMotionPart:window:x:y:): Add F suffix to float.
5381 (mouseDown:): Use CGFloat.
5382 (mouseDragged:): Remove unised variable edge.
5383 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
5384
5385 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
5386 of CGFloat differs.
5387 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
5388 when NS_IMPL_GNUSTEP.
5389 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
5390 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
5391 (EmacsToolbar): Add clearAll. Add tag argument to
5392 addDisplayItemWithImage.
5393 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
5394
5395 * nsselect.m (ns_get_local_selection): Remove unused variable type.
5396
5397 * nsmenu.m (ns_update_menubar): Make static.
5398 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
5399 (fillWithWidgetValue:): Add cast to SEL for setAction.
5400 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
5401 (update_frame_tool_bar): Update code for GNUStep.
5402 (clearAll): New method.
5403 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 5404 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 5405 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
5406 call to insertItemWithItemIdentifier.
5407 (validateVisibleItems): Fix indentation.
5408 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
5409 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
5410 UtilityWindow to aStyle, remove call to setStyleMask.
5411
5412 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
5413
5414 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
5415 (ns_charset_covers, ns_get_covering_families, nsfont_open):
5416 Use F suffix on floats.
5417 (ns_char_width): Returns CGFloat.
5418 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 5419 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
5420 DPSxshow.
5421 (ns_glyph_metrics): CGFloat instead of float.
5422
a0eb10b3
JB
5423 * nsfns.m (x_set_foreground_color, x_set_background_color):
5424 Use EmacsCGFloat.
5425 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
5426 remove unused variables.
5427 (Fns_read_file_name): Keep track if panel is for save.
5428 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 5429 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
5430 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
5431 Just return the input if GNUStep.
c0342369
JD
5432 (x_screen_planes): Remove.
5433 (Fxw_color_values): Use EmacsCGFloat
5434 (Fns_display_monitor_attributes_list): Only get screen number for
5435 Cocoa.
ef099a94 5436 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
5437 EmacsSavePanel.
5438 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
5439 ns_directory_from_panel.
5440
da9aff11
PE
54412013-06-01 Paul Eggert <eggert@cs.ucla.edu>
5442
5443 * process.c (handle_child_signal): Also use WCONTINUED.
5444 This is so that list-processes doesn't mistakenly list the process
5445 as stopped, when the process has actually been continued and is
5446 now running.
5447
0e64479a
PE
54482013-05-31 Paul Eggert <eggert@cs.ucla.edu>
5449
fc186a96
PE
5450 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
5451 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
5452 not already configured.
5453
0e64479a
PE
5454 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
5455
38b787fa
EZ
54562013-05-29 Eli Zaretskii <eliz@gnu.org>
5457
5458 * Makefile.in (mostlyclean): Remove *.res files.
5459
22513e52
SM
54602013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
5461
5462 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
5463 a buffer (bug#8447).
5464
6ef3db10
EZ
54652013-05-27 Eli Zaretskii <eliz@gnu.org>
5466
5467 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
5468 display vector, and we backtrack, handle the case that the
5469 previous character position is also displayed from a display
5470 vector or covered by a display string or image. (Bug#14476)
5471
6799bb26
JD
54722013-05-25 Jan Djärv <jan.h.d@swipnet.se>
5473
5474 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
5475 (struct MonitorInfo, free_monitors): Remove.
5476 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
5477 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
5478 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5479 Qframes, Qsource.
5480
5481 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
5482 (struct MonitorInfo, free_monitors): Remove.
5483 (ns_screen_name): Make static.
5484 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
5485 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5486 Qframes, Qsource.
5487
5488 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5489 (struct MonitorInfo): New struct.
5490 (free_monitors, make_monitor_attribute_list): Declare.
5491
22513e52
SM
5492 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
5493 New Lisp_Object:s.
6799bb26
JD
5494 (free_monitors, make_monitor_attribute_list): New functions.
5495 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
5496 Qsource.
5497
38cd43eb
XF
54982013-05-25 Xue Fuqiao <xfq.free@gmail.com>
5499
5500 * callproc.c (call_process): Refine the doc string. (Bug#14045)
5501
2af0948d
SM
55022013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
5503
a7eb9b0f
SM
5504 * keyboard.c: Apply keyboard decoding only to events that come directly
5505 from the tty, not from unread-command-events (bug#14368).
5506 (read_event_from_main_queue): New function, extracted from read_char).
5507 (read_decoded_char): Remove.
5508 (read_decoded_event_from_main_queue): New function to replace it.
5509 (read_char): Use it.
5510 (read_key_sequence): Use read_char rather than read_decoded_char.
5511
2af0948d
SM
5512 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
5513
9698f11c 55142013-05-22 Barry O'Reilly <gundaetiapo@gmail.com>
1413e9a5
BR
5515
5516 * casetab.c (init_casetab_once): Fix last change (bug#14424).
5517
e6d2f155
KH
55182013-05-22 Kenichi Handa <handa@gnu.org>
5519
5520 The following changes are to fix the setting of
5521 buffer-file-coding-system on, for instance, C-x RET c unix RET
5522 _FILE_OF_DOS_EOL_TYPE_ RET.
5523
5524 * coding.h (struct coding_system): New member detected_utf8_chars.
5525
5526 * coding.c (detect_coding_utf_8): Count characters and check EOL
5527 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
5528 BOM is there.
5529 (setup_coding_system): Do not initialize coding->head_ascii.
5530 (check_ascii): Do not set coding->eol_seen but update it. Do not
5531 call adjust_coding_eol_type here.
1413e9a5
BR
5532 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
5533 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
5534 of the found coding-system.
5535 (decode_coding_gap): Cancel previous change. Utilize the
5536 character numbers counted by detect_coding_utf_8. Fix detection
5537 of BOM for utf-8.
5538
9698f11c 55392013-05-21 Barry O'Reilly <gundaetiapo@gmail.com>
fc30d803
SM
5540
5541 * search.c (looking_at_1): Only set last_thing_searched if the match
5542 changed the match-data (bug#14281).
5543
ecc3c6ed
DA
55442013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
5545
5546 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 5547 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
5548 (move_it_vertically_backward): Likewise.
5549
5ba8bf35
YM
55502013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5551
5552 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 5553 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
5554 (Fx_display_mm_width, Fx_display_mm_height):
5555 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 5556
91e8418b 5557 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 5558 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
5559 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
5560 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
5561 (Fx_display_backing_store, Fx_display_visual_class)
5562 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
5563 (Fx_display_grayscale_p, Fx_display_pixel_width)
5564 (Fx_display_pixel_height, Fx_display_planes)
5565 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
5566 (Fx_display_screens): Don't confuse X11 screens with NS screens.
5567 (Fx_display_mm_width, Fx_display_mm_height)
5568 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
5569 height for all physical monitors as in X11.
5570
fc30d803
SM
5571 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
5572 Return pixel width or height for all physical monitors as in X11.
91e8418b 5573
31ff141c
PE
55742013-05-18 Paul Eggert <eggert@cs.ucla.edu>
5575
5576 Port --enable-gcc-warnings to clang.
5577 * bytecode.c (exec_byte_code):
5578 * regex.c:
5579 Redo diagnostic pragmas to pacify clang, too.
5580 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
5581 * editfns.c (Fencode_time):
5582 * fileio.c (file_accessible_directory_p):
5583 * font.c (font_unparse_xlfd):
5584 Use '&"string"[index]' instead of '"string" + (index)'.
5585 * undo.c (user_error): Remove; unused.
5586
df065a0b
EZ
55872013-05-16 Eli Zaretskii <eliz@gnu.org>
5588
04d360e7
EZ
5589 * insdel.c (insert_1_both): Document the arguments, instead of
5590 referring to insert_1, which no longer exists.
5591
5bb98290
EZ
5592 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
5593 some window, increment windows_or_buffers_changed, so that
5594 *Messages* display in that window is updated. (Bug#14408)
5595
df065a0b
EZ
5596 * w32.c: Include epaths.h.
5597 (init_environment): Use cmdproxy.exe without leading directories.
5598 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
5599 case.
5600 (gettimeofday): Adjust signature and return value to Posix
5601 expectations.
5602
5603 * unexw32.c (open_output_file): Delete the existing emacs.exe
5604 before creating it, to break the hard link to the versioned
5605 executable.
5606
5607 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
5608 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
5609 (FIRSTFILE_OBJ): New variables.
5610 (W32_RES): Rename to EMACSRES. All users changed.
5611 (base_obj): Use $(CM_OBJ).
5612 (ALLOBJS): Use $(FIRSTFILE_OBJ).
5613 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
5614 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
5615 $(W32_RES_LINK) before $(LIBES).
5616 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
5617
1aa8d505
SM
56182013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5619
6e911150
SM
5620 * makefile.w32-in (DOC): Use just "DOC".
5621
5622 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
5623
1aa8d505
SM
5624 * process.c: Export default filters and sentinels to Elisp.
5625 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
5626 New constants.
5627 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
5628 (Fset_process_sentinel, Fformat_network_address):
5629 Default to them instead of nil.
5630 (server_accept_connection): Sentinels can't be nil any more.
5631 (read_and_dispose_of_process_output): New function, extracted from
5632 read_process_output.
5633 (read_process_output): Use it; filters can't be nil.
5634 (Finternal_default_process_filter): New function, extracted from
5635 read_process_output.
5636 (exec_sentinel_unwind): Remove function.
5637 (exec_sentinel): Don't zilch sentinel while running.
5638 (status_notify): Sentinels can't be nil.
5639 (Finternal_default_process_sentinel): New function extracted from
5640 status_notify.
5641 (setup_process_coding_systems): Default filter is not nil any more.
5642 (syms_of_process): Export new Elisp functions and initialize
5643 new constants.
5644 * lisp.h (make_lisp_proc): New function.
5645
5ac2eb34
SM
56462013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5647
5648 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
5649
eda9c7d7
EZ
56502013-05-14 Eli Zaretskii <eliz@gnu.org>
5651
5652 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
5653 unless we know that the window w is a leaf window.
5654 Another attempt at solving bug#14062.
eda9c7d7 5655
8fdeaad5
JD
56562013-05-14 Jan Djärv <jan.h.d@swipnet.se>
5657
5658 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
5659 fdesc (Bug#14375).
5660
44aa9ee6
PE
56612013-05-12 Paul Eggert <eggert@cs.ucla.edu>
5662
5663 * image.c (gif_load): Check that subimages fit (Bug#14345).
5664
759fd763
SM
56652013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
5666
5667 * lread.c (skip_dyn_eof): New function.
5668 (read1): Use it to skip the end of a file in response to #@00.
5669
5670 * doc.c (get_doc_string): Slightly relax the sanity checking.
5671
4465bfb4
JD
56722013-05-09 Jan Djärv <jan.h.d@swipnet.se>
5673
5674 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
5675 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5676 (MonitorInfo): New struct.
5677 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
5678 (Fns_display_monitor_attributes_list): New functions.
5679 (display-usable-bounds): Remove.
5680 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
5681 Qsource.
5682
7583e2a0
PE
56832013-05-09 Paul Eggert <eggert@cs.ucla.edu>
5684
5685 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
5686 (GTK_CHECK_VERSION): New macro, if not already defined.
5687 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
5688 replaced by GTK_CHECK_VERSION.
5689
ad75d77e
PE
56902013-05-08 Paul Eggert <eggert@cs.ucla.edu>
5691
5692 * xterm.h (GTK_PREREQ): New macro.
5693 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
5694 to use this macro instead, for consistency and clarity.
5695
07525f77
EZ
56962013-05-08 Eli Zaretskii <eliz@gnu.org>
5697
5698 * xdisp.c (row_for_charpos_p): New function, with code of
5699 cursor_row_p, but accepts an additional argument CHARPOS instead
5700 of using a hardcoded PT.
5701 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
5702 (row_containing_pos): Call row_for_charpos_p instead of partially
5703 doing the same. Fixes cursor positioning under longlines-mode
5704 when longlines-show-effect includes more than one newline, when
5705 moving the cursor vertically up.
5706
d901fc8d
JB
57072013-05-08 Juanma Barranquero <lekktu@gmail.com>
5708
5709 * makefile.w32-in (ACL_H): New macro.
5710 ($(BLD)/fileio.$(O)): Update dependencies.
5711
f269bc61
PE
57122013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5713
e7b41c4c 5714 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
5715 * Makefile.in (LIB_ACL): New macro.
5716 (LIBACL_LIBS): Remove.
5717 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
5718 * fileio.c: Include <acl.h>.
5719 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
5720 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
5721 !acl_errno_valid.
5722 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
5723 it ourselves.
5724
f269bc61
PE
5725 * unexelf.c: Don't assume ElfW (Half) fits in int.
5726 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
5727 when dealing with ElfW (Half) values, since they can exceed 2**31
5728 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
5729 (entry_address): Omit unused NUM arg. All uses changed.
5730
a261c53e
JL
57312013-05-07 Juri Linkov <juri@jurta.org>
5732
5733 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
5734 to the string converted from number with `Fnumber_to_string'.
5735 (Bug#14254)
5736
2b66427d
PE
57372013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5738
5739 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
5740 This fixes a problem introduced by my previous change.
5741
15acfe41
GM
57422013-05-07 Glenn Morris <rgm@gnu.org>
5743
5744 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
5745
5ea03bf5
JD
57462013-05-07 Jan Djärv <jan.h.d@swipnet.se>
5747
5748 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
5749
e0c9d565
PE
57502013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5751
5752 Static checking by GCC 4.8.0.
5753 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
5754 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
5755 (x_get_monitor_attributes_fallback)
5756 (x_get_monitor_attributes_xinerama)
5757 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
5758 Define only if USE_GTK.
5759 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
5760 (x_get_monitor_attributes_fallback): Omit unused locals.
5761 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
5762 Use double, not float, to avoid mixed-mode floating point arithmetic.
5763
4e3f9230
YM
57642013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5765 Jan Djärv <jan.h.d@swipnet.se>
5766
5767 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
5768 (XINERAMA_CFLAGS): New macros.
5769 (ALL_CFLAGS, LIBES): Use them.
5770
5771 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
5772 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
5773 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
5774 (syms_of_xfns): DEFSYM them.
5775 (struct MonitorInfo): New struct.
5776 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
5777 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
5778 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
5779 (x_get_monitor_attributes_xinerama): New functions.
5780 (Fx_display_monitor_attributes_list): New primitive.
5781 (syms_of_xfns): Defsubr it.
5782
5783 * xterm.h (x_display_info): Add Xatom_net_workarea and
5784 Xatom_net_current_desktop.
5785
5786 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5787 and dpyinfo->Xatom_net_current_desktop.
5788
05839b6a
EZ
57892013-05-06 Eli Zaretskii <eliz@gnu.org>
5790
5791 * xdisp.c (pos_visible_p): Use the special code for finding the
5792 beginning of a display property or overlay for any "replacing"
5793 display property, not just for display strings. This solves
5794 incorrect reporting of position by posn-at-point. (Bug#14241)
5795
dc4a2ee0
PE
57962013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5797
5ee94506
PE
5798 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5799 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5800 Verify that ElfW (Half) fits in int.
5801 (fatal): Use same signature as lisp.h.
5802 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5803 configure and build with -DUNEXELF_DEBUG without worrying about
5804 other modules that use DEBUG.
5805 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5806 possibly-wide integers now uses it instead of plain fprintf.
5807 (entry_address): New function, which avoids problems with 32-bit
5808 overflow on 64-bit hosts.
5809 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5810 (round_up): Don't assume the remainder fits in int.
5811 (find_section): Use bool for boolean. Simplify debug code.
5812 (unexec): Don't assume file sizes fit in int or size_t.
5813 Omit unnecessary trailing newline in 'fatal' format.
5814 Use strerror rather than outputting decimal error number.
5815 Remove unused code when emacs is not defined;
5816 this file relies on Emacs now.
5817 Don't assume e_phnum and e_shnum are positive.
5818
dc4a2ee0
PE
5819 * regex.c: Fix problems when DEBUG is defined.
5820 (extract_number, extract_number_and_incr): Define regardless of
5821 whether DEBUG is defined; that's simpler and makes the code less
5822 likely to go stale in the normal case when DEBUG is not defined.
5823 Return int rather than taking an int * arg. All callers changed.
5824 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5825 Remove, replacing with ...
5826 (DEBUG_PRINT): New macro. All callers changed.
5827 (DEBUG_COMPILES_ARGUMENTS): New macro.
5828 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5829 (print_compiled_pattern, print_double_string) [DEBUG]:
5830 Use prototype rather than old-style definition.
5831 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5832 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5833 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5834 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5835 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5836 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5837 This matters only when DEBUG is defined.
5838
14c7ed05
EZ
58392013-05-05 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (set_iterator_to_next): Set the
5842 ignore_overlay_strings_at_pos_p flag only if we are _really_
5843 iterating over an overlay string, as indicated by the
5844 current.overlay_string_index member. (Bug#14306)
5845
e6076b1b
JD
58462013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5847
5848 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5849 to where it is used, to avoid autorelease issues (Bug#14050).
5850
cbee2131
PE
58512013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5852
5853 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5854 * fileio.c (syms_of_fileio): Implement this.
5855 * filelock.c (create_lock_file): If symbolic links don't work, so
5856 we use a regular file as a lock file, do not fsync the lock file;
5857 it's not needed.
5858
30c7e542
SM
58592013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5860
5861 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5862 (syms_of_minibuf): Adjust accodingly.
5863 * lread.c (Fread):
5864 * callint.c (Fcall_interactively): Adjust calls accordingly.
5865
5bebd186
EZ
58662013-05-04 Eli Zaretskii <eliz@gnu.org>
5867
5868 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5869 w->contents is a buffer before computing everything else.
5870 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5871
5872 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5873 assertion violations. (Bug#14062)
5874
0fb0a4f3
DR
58752013-05-01 David Reitter <david.reitter@gmail.com>
5876
5877 * nsfns.m (ns_tooltip): Initialize.
5878
9e63b4a5
EZ
58792013-04-28 Eli Zaretskii <eliz@gnu.org>
5880
5881 * coding.c (decode_coding_gap): Don't remove the character before
5882 a newline unless it's a CR character. (Bug#14287)
5883
ad60824e
DN
58842013-04-28 Dan Nicolaescu <dann@gnu.org>
5885
5886 * dispextern.h (struct face): Move enum face_underline_type
5887 earlier so that bitfields can be in the same word.
5888
edbdcec0
JD
58892013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5890
5891 * nsfns.m (handlePanelKeys): New function.
5892 (EmacsOpenPanel:performKeyEquivalent:)
5893 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5894 arrows/function/control and copy/paste keys (Bug#14296).
5895
0208ede7
JL
58962013-04-27 Juri Linkov <juri@jurta.org>
5897
5898 * callint.c (Fcall_interactively): Call `Qread_number' for
5899 interactive code letter `n' instead of using duplicate code.
5900 (Bug#14254)
5901
b8dd59f7
PE
59022013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5903
5904 * systime.h (make_timeval): Declare as 'const'.
5905
8bd722db
KH
59062013-04-27 Kenichi Handa <handa@gnu.org>
5907
5908 * font.c (font_open_entity): Always open a font of manageable
5909 size.
5910
13d0e56f 59112013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5912
f780d632
PE
5913 Port better to AIX (Bug#14258).
5914 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5915 to pacify AIX xlc.
5916
ec509856
KH
59172013-04-24 Kenichi Handa <handa@gnu.org>
5918
5919 * coding.c (decode_coding_iso_2022): When an invalid escape
5920 sequence is encountered, reset the invocation and designation
5921 status to the safest one.
5922
84fc48e5
PE
59232013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5926 Without this fix, "make distclean" leaves stamp-h1 behind.
5927
806bda47
EC
59282013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5929
5930 * w32fns.c (w32_fullscreen_rect): New function to compute the
5931 window rectangle for the given fullscreen mode.
5932 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5933 longer tunes the window size. This keeps the window's edges flush
5934 with the screen and allows the taskbar to hide itself in fullboth.
5935
5936 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5937 window decorations and uses the entire screen.
5938
5939 * w32term.h (w32_fullscreen_rect) Add prototype.
5940 (struct w32_output): Replace normal_width, normal_height,
5941 normal_top, and normal_left members with a single normal_placement
5942 struct.
5943 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5944 Remove macros.
5945 (FRAME_NORMAL_PLACEMENT): New macro.
5946
9cc2810b
JB
59472013-04-16 Juanma Barranquero <lekktu@gmail.com>
5948
5949 * minibuf.c (Ftest_completion): Silence compiler warning.
5950
fd16b54c
EZ
59512013-04-15 Eli Zaretskii <eliz@gnu.org>
5952
5953 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5954 bug#14062.
fd16b54c
EZ
5955
5956 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5957 parentheses.
5958
5959 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5960 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5961 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5962 parentheses where appropriate.
5963
9e3379a0
PE
59642013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5965
5966 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5967
ddd6b685
EZ
59682013-04-14 Eli Zaretskii <eliz@gnu.org>
5969
5970 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5971 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5972 Mention in the doc string that setting these variables takes
5973 effect only after a call to set-window-buffer. (Bug#14200)
5974
29b79ba1
EZ
59752013-04-13 Eli Zaretskii <eliz@gnu.org>
5976
5977 * indent.c (Fvertical_motion): Don't consider display strings on
5978 overlay strings as display strings on the buffer position we
5979 started from. This prevents vertical cursor motion from jumping
5980 more than one line when there's an overlay string with a display
5981 property at end of line.
5982 Reported by Karl Chen <Karl.Chen@quarl.org> in
5983 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5984
562c6ee9
SM
59852013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5986
5987 * window.c (select_window): `record_buffer' even if window is
5988 already selected (bug#14191).
5989
fcc1fe85
EZ
59902013-04-11 Eli Zaretskii <eliz@gnu.org>
5991
5992 * window.c (Fwindow_end): Test more flags, including the buffer's
5993 last_overlay_modified flag, to determine whether the window's
5994 display is really up-to-date. Prevents the function from
5995 returning a stale value. (Bug#14170)
5996 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5997 current matrix.
5998
f009190a
EZ
59992013-04-10 Eli Zaretskii <eliz@gnu.org>
6000
6001 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
6002 garbaged only if it is not already the top frame on its TTY.
6003 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
6004 there are GUI frames open in the same session. (Bug#13864)
6005
78ce603d
SM
60062013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
6007
6008 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
6009 of marking the idle timers directly.
6010
a8036e40
SM
60112013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
6012
6013 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
6014 tables (bug#14054).
6015
7ffe7ef6
SM
60162013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
6017
6018 * window.c (select_window): Don't record_buffer while the invariant is
6019 temporarily broken (bug#14161).
6020
6021 * fns.c (Fdelq): Don't assume !NILP => CONSP.
6022
7d9f6883
EZ
60232013-04-07 Eli Zaretskii <eliz@gnu.org>
6024
6025 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
6026
5406cfd9
RF
60272013-04-07 Romain Francoise <romain@orebokech.com>
6028
6029 Ignore additional platform-specific ACL errors (Bug#13702).
6030 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
6031 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
6032
95c0e83b
JD
60332013-03-31 Jan Djärv <jan.h.d@swipnet.se>
6034
6035 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
6036 f->output_data.ns.
6037
876da980
PE
60382013-04-07 Paul Eggert <eggert@cs.ucla.edu>
6039
6040 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
6041 This bug was introduced by my 2013-02-25 change that simplified
6042 data_start configuration. Without this change, on GNU/Linux
6043 an Emacs configured with --enable-profiling fails immediately
6044 due to a profiler signal.
6045 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
6046 with these flags. On platforms where special flags are needed
6047 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
6048 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
6049 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
6050
7452b7bd
DA
60512013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
6052
6053 Get rid of some platform-specific functions examining window
6054 system and its capabilities. This is a partial rework of the
6055 2013-04-05 change.
6056 * lisp.h (have_menus_p): Remove prototype. This function is
6057 replaced with platform-independent window_system_available.
6058 (check_window_system): Move to...
6059 * frame.h (decode_window_system_frame, window_system_available):
6060 ...here, add new prototypes.
6061 * frame.c (window_system_available, decode_window_system_frame):
6062 New functions.
6063 (check_window_system): Platform-independent now.
6064 * xterm.h (x_in_use): Remove declaration.
6065 (check_x_frame):
6066 * w32term.h (check_x_frame):
6067 * nsterm.h (check_x_frame): Remove prototypes. This function
6068 is replaced with platform-independent decode_window_system_frame.
6069 * msdos.c (have_menus_p): Remove.
6070 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
6071 Remove platform-specific functions. Use check_window_system,
6072 decode_window_system_frame and check_ns_display_info where
6073 appropriate. Minor style and comment tweaks.
6074 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
6075 (check_x_frame): Likewise.
6076 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
6077 Likewise.
6078 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
6079 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
6080 * xmenu.c, xselect.c: All related users changed.
6081
251e9147
KH
60822013-04-03 Kenichi Handa <handa@gnu.org>
6083
6084 The following changes is to optimize the code for reading UTF-8
6085 files.
6086
562c6ee9 6087 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
6088 changed. Check EOL format. Do not call adjust_coding_eol_type
6089 here.
6090 (check_utf_8): New function.
6091 (adjust_coding_eol_type): Do nothing if already adjusted.
6092 (detect_coding): Compare the return value of check_ascii with
6093 coding->src_bytes. Call adjust_coding_eol_type if necessary.
6094 (decode_coding_gap): Optimize for valid UTF-8.
6095
8bc369d4
KH
60962013-03-21 Kenichi Handa <handa@gnu.org>
6097
6098 * coding.c (syms_of_coding): Cancel previous change.
6099
6100 * insdel.c (insert_from_gap): Fix previous change.
6101
73931ad1
DA
61022013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
6103
6104 Consistently use platform-specific function to detect window system.
6105 * lisp.h (check_window_system): New prototype. This function is
6106 going to replace check_x, check_w32 and check_ns.
6107 (have_menus_p): Mention msdos.c in comment.
6108 * fontset.c (check_window_system_func): Remove. Adjust all users.
6109 * fontset.h (check_window_system_func): Remove prototype.
6110 * nsterm.h (check_ns):
6111 * xterm.h (check_x):
6112 * w32term.h (check_w32): Likewise.
6113 * menu.c (Fx_popup_menu): Use check_window_system.
6114 * msdos.c (check_window_system): Define for MS-DOS.
6115 * nsfns.m (check_window_system): Define for NS. Adjust all users.
6116 * w32fns.c (check_window_system): Likewise for MS-Windows.
6117 * xfns.c (check_window_system): Likewise for X.
6118 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
6119 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
6120
7216e43b
PE
61212013-04-02 Paul Eggert <eggert@cs.ucla.edu>
6122
6123 Prefer < to > in range checks such as 0 <= i && i < N.
6124 This makes it easier to visualize quantities on a number line.
6125 This patch doesn't apply to all such range checks,
6126 only to the range checks affected by the 2013-03-24 change.
6127 This patch reverts most of the 2013-03-24 change.
6128 * alloc.c (xpalloc, Fgarbage_collect):
6129 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
6130 * character.c (string_escape_byte8):
6131 * charset.c (read_hex):
6132 * data.c (cons_to_unsigned):
6133 * dispnew.c (update_frame_1):
6134 * doc.c (Fsubstitute_command_keys):
6135 * doprnt.c (doprnt):
6136 * editfns.c (hi_time, decode_time_components):
6137 * fileio.c (file_offset):
6138 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
6139 * font.c (font_intern_prop):
6140 * frame.c (x_set_alpha):
6141 * gtkutil.c (get_utf8_string):
6142 * indent.c (check_display_width):
6143 * keymap.c (Fkey_description):
6144 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
6145 * lread.c (read1):
6146 * minibuf.c (read_minibuf_noninteractive):
6147 * process.c (wait_reading_process_output):
6148 * search.c (Freplace_match):
6149 * window.c (get_phys_cursor_glyph):
6150 * xdisp.c (redisplay_internal):
6151 * xsmfns.c (smc_save_yourself_CB):
6152 Prefer < to > for range checks.
6153 * dispnew.c (sit_for): Don't mishandle NaNs.
6154 This fixes a bug introduced in the 2013-03-24 change.
6155 * editfns.c (decode_time_components): Don't hoist comparison.
6156 This fixes another bug introduced in the 2013-03-24 change.
6157
92759988
DA
61582013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
6159
6160 * frame.h (struct frame): Drop scroll_bottom_vpos
6161 member becaue all real users are dead long ago.
6162 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
6163 * xdisp.c (redisplay_internal): Adjust user.
6164
9a1971bb
GM
61652013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
6166
f38ab167
JD
6167 * nsmenu.m (showAtX:Y:for:): setLevel to
6168 NSPopUpMenuWindowLevel (Bug#13998).
6169
6d01f1fe
JD
61702013-03-30 Jan Djärv <jan.h.d@swipnet.se>
6171
6172 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
6173 (ns_check_pending_open_menu): Declare.
6174
6175 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
6176 (x_activate_menubar): Update the menu with title that matches
6177 ns_get_pending_menu_title, and call
6178 ns_check_pending_openmenu (Bug#12698).
6179 (menuWillOpen:): New method.
6180 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
6181
6182 * nsterm.m (menu_will_open_state, menu_mouse_point)
6183 (menu_pending_title): New varaibles.
6184 (ns_get_pending_menu_title, ns_check_menu_open)
6185 (ns_check_pending_open_menu): New functions.
6186
781f4782
DA
61872013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
6188
6189 * indent.c (current_column_bol_cache): Remove leftover which is not
6190 used in Fmove_to_column any more.
6191 (current_column, scan_for_column): Adjust users.
6192 * keyboard.c (last_point_position_buffer, last_point_position_window):
6193 Remove leftovers which are not used for recording undo any more.
6194 (command_loop_1, syms_of_keyboard): Adjust users.
6195 * xdisp.c (last_max_ascent): Remove leftover which is not used in
6196 redisplay_window any more.
6197 (move_it_to): Adjust user.
6198
1921c31b
JB
61992013-03-29 Juanma Barranquero <lekktu@gmail.com>
6200
6201 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
6202 Update dependencies.
6203
717b8bcd
SM
62042013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6205
6206 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
6207 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
6208 forward references.
6209
e74aeda8
DA
62102013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
6211
6212 * window.h (struct window): Replace hchild, vchild and buffer slots
6213 with the only contents slot. This is possible because each valid
6214 window may have either the child window (in vertical or horizontal
6215 combination) or buffer to display (for the leaf window). Using that,
6216 a lof of operations to traverse and/or change window hierarchies may
6217 be simplified. New member horizontal is used to distinguish between
6218 horizontal and vertical combinations of internal windows.
6219 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
6220 (WINDOW_VERTICAL_COMBINATION_P): New macros.
6221 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
6222 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
6223 Use contents slot, not buffer, where appropriate.
6224 (wset_combination): New function.
6225 (wset_buffer): Add eassert.
6226 (Fframe_first_window): Simplify the loop reaching first window.
6227 (Fwindow_buffer): Use WINDOW_LEAF_P.
6228 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
6229 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
6230 (unshow_buffer): Convert initial debugging check to eassert.
6231 (replace_window, recombine_windows, Fdelete_other_windows_internal)
6232 (make_parent_window, window_resize_check, window_resize_apply)
6233 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
6234 (Fset_window_configuration, delete_all_child_windows, save_window_save):
6235 Adjust to match struct window changes.
6236 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
6237 (mark_window_cursors_off, count_windows, get_leaf_windows)
6238 (foreach_window_1): Simplify the loop.
6239 * alloc.c (mark_object): Do not check for the leaf window because
6240 internal windows has no glyph matrices anyway.
6241 * dispnew.c (clear_window_matrices, showing_window_margins_p)
6242 (allocate_matrices_for_window_redisplay, fake_current_matrices)
6243 (allocate_matrices_for_frame_redisplay, free_window_matrices)
6244 (build_frame_matrix_from_window_tree, mirror_make_current)
6245 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
6246 (update_window_tree, set_window_update_flags): Simplify the loop.
6247 (sync_window_with_frame_matrix_rows): Enforce live window.
6248 Use contents slot, not buffer, where appropriate.
6249 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
6250 and WINDOW_HORIZONTAL_COMBINATION_P.
6251 (make_frame_visible_1): Simplify the loop.
6252 Use contents slot, not buffer, where appropriate.
6253 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
6254 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
6255 (expose_window_tree): Likewise.
6256 Use contents slot, not buffer, where appropriate.
6257 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
6258 to avoid deleted windows. Use contents slot instead of buffer.
6259 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
6260 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
6261 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
6262 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
6263
121ab1cd
EZ
62642013-03-28 Eli Zaretskii <eliz@gnu.org>
6265
ef454cf7
EZ
6266 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
6267 identify the reasons for assertion violations in bug#14062 and
6268 similar ones.
21e930f8
EZ
6269 (Fx_show_tip): Fix compilation error under
6270 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 6271
121ab1cd
EZ
6272 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
6273 Reported by <rzl24ozi@gmail.com>.
6274
5c89ca24
DA
62752013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
6276
6277 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
6278 start marker...
562c6ee9
SM
6279 (unwind_with_echo_area_buffer): ...to restore it here.
6280 This is needed to ensure that...
5c89ca24
DA
6281 (redisplay_window): ...both window markers are valid here,
6282 which is verified by eassert.
6283 * editfns.c (save_excursion_save): Do not assume that
6284 selected_window always displays the buffer.
c7f53895
DA
6285 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
6286 Fix comment.
5c89ca24 6287
f557c1b1
SM
62882013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
6289
6290 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
6291 the upcase table.
6292
40693bba 62932013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
6294
6295 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
6296
c86f791f
EZ
62972013-03-27 Eli Zaretskii <eliz@gnu.org>
6298
6299 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
6300 since MinGW's w32api headers do. This avoids compiler warnings.
6301
6302 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
6303 if already defined.
6304
c6e72e17
EZ
63052013-03-26 Eli Zaretskii <eliz@gnu.org>
6306
6307 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
6308
54e95010
JD
63092013-03-26 Jan Djärv <jan.h.d@swipnet.se>
6310
6311 * gtkutil.c (style_changed_cb): Check if frame is live and an
6312 X frame (Bug#14038).
6313
b88b62de
EZ
63142013-03-26 Eli Zaretskii <eliz@gnu.org>
6315
a18d7de6
EZ
6316 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
6317 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
6318 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
6319 MinGW64.
8f5e14c8
EZ
6320 Move inclusion of time.h before sys/time.h, so that MinGW64 could
6321 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 6322
b88b62de
EZ
6323 Fix incompatibilities between MinGW.org and MinGW64 headers.
6324 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
6325
6326 * w32.c (REPARSE_DATA_BUFFER): Guard with
6327 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
6328
c074e458
JD
63292013-03-25 Jan Djärv <jan.h.d@swipnet.se>
6330
6331 * xterm.c: Include X11/XKBlib.h
6332 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
6333
908589fd
AS
63342013-03-24 Andreas Schwab <schwab@linux-m68k.org>
6335
6336 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
6337 written backwards.
6338 * blockinput.h (input_blocked_p): Likewise.
6339 * bytecode.c (exec_byte_code): Likewise.
6340 * callproc.c (call_process_kill, call_process_cleanup)
6341 (Fcall_process): Likewise.
6342 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
6343 (Fccl_execute_on_string): Likewise.
6344 * character.c (string_escape_byte8): Likewise.
6345 * charset.c (read_hex): Likewise.
6346 * cm.c (calccost): Likewise.
6347 * data.c (cons_to_unsigned): Likewise.
6348 * dired.c (directory_files_internal, file_name_completion):
6349 Likewise.
6350 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
6351 (sit_for): Likewise.
6352 * doc.c (Fsubstitute_command_keys): Likewise.
6353 * doprnt.c (doprnt): Likewise.
6354 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
6355 * emacsgtkfixed.c: Likewise.
6356 * fileio.c (file_offset, Fwrite_region): Likewise.
6357 * floatfns.c (Fexpt, fmod_float): Likewise.
6358 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
6359 Likewise.
6360 * font.c (font_intern_prop): Likewise.
6361 * frame.c (x_set_alpha): Likewise.
6362 * gtkutil.c (get_utf8_string): Likewise.
6363 * indent.c (check_display_width): Likewise.
6364 * intervals.c (create_root_interval, rotate_right, rotate_left)
6365 (split_interval_right, split_interval_left)
6366 (adjust_intervals_for_insertion, delete_node)
6367 (interval_deletion_adjustment, adjust_intervals_for_deletion)
6368 (merge_interval_right, merge_interval_left, copy_intervals)
6369 (set_intervals_multibyte_1): Likewise.
6370 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
6371 * keymap.c (Fkey_description): Likewise.
6372 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
6373 * lread.c (openp, read_integer, read1, string_to_number):
6374 Likewise.
6375 * menu.c (ensure_menu_items): Likewise.
6376 * minibuf.c (read_minibuf_noninteractive): Likewise.
6377 * print.c (printchar, strout): Likewise.
6378 * process.c (create_process, Faccept_process_output)
6379 (wait_reading_process_output, read_process_output, send_process)
6380 (wait_reading_process_output): Likewise.
6381 * profiler.c (make_log, handle_profiler_signal): Likewise.
6382 * regex.c (re_exec): Likewise.
6383 * regex.h: Likewise.
6384 * search.c (looking_at_1, Freplace_match): Likewise.
6385 * sysdep.c (get_child_status, procfs_ttyname)
6386 (procfs_get_total_memory): Likewise.
6387 * systime.h (EMACS_TIME_VALID_P): Likewise.
6388 * term.c (dissociate_if_controlling_tty): Likewise.
6389 * window.c (get_phys_cursor_glyph): Likewise.
6390 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
6391 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
6392 Likewise.
6393 * xfns.c (Fx_window_property): Likewise.
6394 * xmenu.c (set_frame_menubar): Likewise.
6395 * xselect.c (x_get_window_property, x_handle_dnd_message):
6396 Likewise.
6397 * xsmfns.c (smc_save_yourself_CB): Likewise.
6398 * xterm.c (x_scroll_bar_set_handle): Likewise.
6399
2bf7d27a
DA
64002013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
6401
6402 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
6403 to be optional or nil. Adjust comment and convert it to docstring.
6404 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
6405 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
6406
a9ebfa0b
PE
64072013-03-24 Paul Eggert <eggert@cs.ucla.edu>
6408
6409 Static checking by GCC 4.8-20130319.
6410 * image.c (gif_load): Assume pass < 3 to pacify GCC.
6411 * process.c (Fset_process_datagram_address)
6412 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
6413 * xdisp.c (get_char_face_and_encoding):
6414 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
6415 (get_glyph_face_and_encoding): Prepare face before possibly using it.
6416 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
6417
4f3576ee
KB
64182013-03-24 Ken Brown <kbrown@cornell.edu>
6419
789b5e9a
KB
6420 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
6421 fix compilation on 64-bit Cygwin, where underscores are not
6422 automatically prepended.
6423
4f3576ee
KB
6424 * w32term.c (w32_initialize): Silence compiler warning.
6425
b5b7745f
EZ
64262013-03-23 Eli Zaretskii <eliz@gnu.org>
6427
cdc0d0bd
EZ
6428 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
6429 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
6430 variables, to save and restore frame dimensions.
6431 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
6432 after returning from a 'fullscreen' configuration.
6433 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
6434 to avoid races between the main thread and the input thread.
6435
6436 * w32term.h (struct w32_output): New members normal_width,
6437 normal_height, normal_top, normal_left, and prev_fsmode.
6438 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
6439 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
6440 members of a frame.
6441
b5b7745f
EZ
6442 * w32term.c (w32fullscreen_hook): Record last value of the frame's
6443 'fullscreen' parameter. Always record previous width and height
6444 of the frame, except when switching out of maximized modes, so
6445 that they could be restored correctly, instead of resetting to the
6446 default frame dimensions. Send SC_RESTORE command to the frame,
6447 unless we are going to send SC_MAXIMIZE, to restore the frame
6448 resize hints in the mouse pointer shown by the window manager.
6449 (Bug#14032)
6450
6451 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
6452
6453 * lisp.h (get_frame_param): Adjust conditions for prototype
6454 declaration.
6455
a3454eed
KB
64562013-03-22 Ken Brown <kbrown@cornell.edu>
6457
6458 * unexcw.c: Drop unneeded inclusion of w32common.h.
6459 (report_sheap_usage): Declare.
6460 (read_exe_header): Add magic numbers for x86_64.
6461 (fixup_executable): Fix printf format specifier for unsigned long
6462 argument.
6463
5a49b79c
DA
64642013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
6465
6466 * frame.h (struct frame): Put menu_bar_window under #ifdef
6467 because this member is not needed when X toolkit is in use.
6468 (fset_menu_bar_window):
6469 * dispnew.c (clear_current_matrices, clear_desired_matrices)
6470 (free_glyphs, update_frame):
6471 * xdisp.c (expose_frame): Likewise.
6472 (display_menu_bar): Likewise. Remove redundant eassert.
6473 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
6474 toolkit is in use.
6475
d6723bf7
PE
64762013-03-21 Paul Eggert <eggert@cs.ucla.edu>
6477
7b1123d8
PE
6478 Use functions and constants to manipulate Lisp_Save_Value objects.
6479 This replaces code that used macros and strings and token-pasting.
6480 The change makes the C source a bit easier to follow,
6481 and shrinks the Emacs executable a bit.
6482 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
6483 (make_save_value): Change 1st arg from string to enum. All callers
6484 changed.
6485 (INTX): Remove.
6486 (mark_object): Use if, not #if, for GC_MARK_STACK.
6487 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
6488 (XSAVE_OBJECT): Now functions, not macros.
6489 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
6490 the constant was never used.
6491 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
6492 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
6493 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
6494 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
6495 New constants.
6496 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
6497 type3 with a single member save_type. All uses changed.
6498 (save_type, set_save_pointer, set_save_integer): New functions.
6499 * print.c (PRINTX): Remove.
6500
d6723bf7
PE
6501 * alloc.c: Remove redundant static declarations.
6502
5f24fa51
DA
65032013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6504
6505 * window.h (struct window): Convert left_col, top_line, total_lines
6506 and total_cols from Lisp_Objects to integers. Adjust comments.
6507 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
6508 Remove.
6509 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
6510 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
6511 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
6512 Adjust users where appropriate.
6513
42143acd
DA
65142013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6515
6516 * frame.h (struct frame): Drop resx and resy because the same data is
6517 available from window system-specific output context. Adjust users.
562c6ee9
SM
6518 (default_pixels_per_inch_x, default_pixels_per_inch_y):
6519 New functions to provide defaults when no window system available.
42143acd 6520 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 6521 (NUMVAL): Move from xdisp.c.
42143acd
DA
6522 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
6523 (Ffont_face_attributes, Fopen_font):
6524 * image.c (gs_load):
6525 * w32font.c (fill_in_logfont):
6526 * xdisp.c (calc_pixel_width_or_height):
6527 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
6528 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
6529
c0a17406
KH
65302013-03-20 Kenichi Handa <handa@gnu.org>
6531
6532 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
6533 to 1 (temporary workaround until a bug related to ASCII
6534 optimization is fixed).
6535
095d384d
DA
65362013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
6537
6538 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
6539 Signal error if window is not internal. Adjust docstring.
6540 (delete_all_child_windows): Use combination_limit to save the buffer.
6541 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
6542 * print.c (syms_of_print): Initialize debugging output not here...
6543 (init_print_once): ...but in a new function here.
6544 * lisp.h (init_print_once): Add prototype.
6545 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 6546
748fa866
DA
65472013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
6548
6549 * window.c (window_resize_check, window_resize_apply)
6550 (window_from_coordinates, recombine_windows, set_window_buffer)
6551 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
6552 (Fsplit_window_internal, Fdelete_window_internal)
6553 (freeze_window_starts): Use bool for booleans.
6554 * window.h (window_frame_coordinates, resize_frame_windows)
6555 (freeze_window_starts, set_window_buffer): Adjust prototypes.
6556
81519fd2
SM
65572013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
6558
6559 * dispnew.c (bitch_at_user): Use `user-error'.
6560
6db423a9
KB
65612013-03-17 Ken Brown <kbrown@cornell.edu>
6562
6563 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
6564 as return type of image_background. (Bug#13981)
6565 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
6566
8f2906f5
JD
65672013-03-16 Jan Djärv <jan.h.d@swipnet.se>
6568
960ce480 6569 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 6570 (ns_select): Don't return with result uninitialized.
960ce480 6571
8f2906f5
JD
6572 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
6573 and getDirectory.
6574
81519fd2
SM
6575 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
6576 New functions.
8f2906f5
JD
6577 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
6578 directories. If filename is nil, get directory name (Bug#13932).
6579 Use getFilename and getDirectory.
6580 (getFilename, getDirectory): New methods for EmacsSavePanel and
6581 EmacsOpenPanel.
6582 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
6583
cded56c1
PE
65842013-03-15 Paul Eggert <eggert@cs.ucla.edu>
6585
6586 * coding.c (decode_coding_gap): Fix typo caught by static checking.
6587
251e9147 65882013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
6589
6590 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
6591 (adjust_after_replace): Make it back to static. Delete the third
6592 arg text_at_gap_tail. Cancel the code for handling it.
6593
6594 * coding.h (struct coding_system): New member eol_seen.
6595
6596 * coding.c (detect_ascii): New function.
6597 (detect_coding): Set coding->head_ascii and coding->eol_seen only
6598 when the source bytes are actually scanned. On detecting for
6599 coding_category_utf_8_auto, call detect_ascii instead of scanning
6600 source bytes directly.
6601 (produce_chars): Call insert_from_gap with the new arg 0.
6602 (encode_coding): Likewise.
6603 (decode_coding_gap): Control ASCII optimization by the variable
6604 disable_ascii_optimization instead of #ifndef .. #endif.
6605 Deccode EOL format according to coding->eol_seen.
6606 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
6607 variable.
6608
8a44e6d1
KH
6609 * lisp.h (adjust_after_replace): Cancel externing it.
6610 (insert_from_gap): Adjust prototype.
6611
5f795e34
EZ
66122013-03-15 Eli Zaretskii <eliz@gnu.org>
6613
6614 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
6615 FULLSCREEN_MAXIMIZED. (Bug#13935)
6616
f258b4be
DA
66172013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
6618
6619 * region-cache.c (find_cache_boundary, move_cache_gap)
6620 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
6621 Simplify debugging check and convert to eassert. Adjust comment.
6622 (pp_cache): Put under ENABLE_CHECKING.
6623
a5cc4dde
EZ
66242013-03-14 Eli Zaretskii <eliz@gnu.org>
6625
6626 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
6627 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
6628 and WM_ACTIVATEAPP.
6629 (w32fullscreen_hook): If the frame is visible, reset
6630 f->want_fullscreen flag after changing the frame size. If the
6631 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
6632 (Bug#13953)
6633
3fc5e44a
DC
66342013-03-13 Daniel Colascione <dancol@dancol.org>
6635
6636 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
6637 too so that these builds can use Cygwin's file conversion
6638 functions. (We've been building and linking cygw32.o all along
6639 and just not using it.)
6640
47d7532e
PE
66412013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6642
6643 File synchronization fixes (Bug#13944).
6644 * Makefile.in (LIB_FDATASYNC): New macro.
6645 (LIBES): Use it.
6646 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
6647 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
6648 Don't worry about HAVE_FSYNC, since a substitute fsync is
6649 available if the system lacks one.
6650 (Fwrite_regin): Retry fsync if interrupted.
6651
c7ffccaf
EZ
66522013-03-13 Eli Zaretskii <eliz@gnu.org>
6653
4e2df81d 6654 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
6655 activated, call w32fullscreen_hook, to make sure the new frame
6656 dimensions are in effect. (Bug#13937)
6657
8a7debc1
DA
66582013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
6659
6660 * xdisp.c (init_iterator): Simplify because both character and byte
6661 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
6662 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
6663 character and byte positions can be obtained from marker.
8a7debc1 6664
7fd8c501
PE
66652013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6666
d9df6f40
PE
6667 Static checking by Sun C 5.12.
6668 * alloc.c (buffer_memory_full) [REL_ALLOC]:
6669 * bytecode.c (exec_byte_code):
6670 * dispnew.c (init_display):
6671 * eval.c (error):
6672 * fileio.c (Fsubstitute_in_file_name):
6673 * keyboard.c (Fevent_convert_list):
6674 * keymap.c (Fsingle_key_description):
6675 * term.c (maybe_fatal, fatal):
6676 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
6677 * xsmfns.c (Fhandle_save_session):
6678 Omit unreachable code.
6679 * keymap.c (map_keymap_char_table_item): Cast void * to
6680 a function pointer type; the C Standard requires this.
6681
7fd8c501
PE
6682 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
6683 Include <sys/param.h> unconditionally, as that works elsewhere and
6684 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
6685 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
6686 and FreeBSD now.
6687
a020afb9 6688See ChangeLog.12 for earlier changes.
aac0c6e3
MR
6689
6690;; Local Variables:
6691;; coding: utf-8
aac0c6e3
MR
6692;; End:
6693
ab422c4d 6694 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
6695
6696 This file is part of GNU Emacs.
6697
6698 GNU Emacs is free software: you can redistribute it and/or modify
6699 it under the terms of the GNU General Public License as published by
6700 the Free Software Foundation, either version 3 of the License, or
6701 (at your option) any later version.
6702
6703 GNU Emacs is distributed in the hope that it will be useful,
6704 but WITHOUT ANY WARRANTY; without even the implied warranty of
6705 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6706 GNU General Public License for more details.
6707
6708 You should have received a copy of the GNU General Public License
6709 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.