* nsterm.h: Fix CGFloat for OSX 10.4.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f10490f0
JD
12013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
4
c8ae93b0
DA
52013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
6
7 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
8 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
9 bool instead of BOOL.
10 * w32term.h (struct scroll_bar): Convert fringe_extended_p
11 from Lisp_Object to bitfield. Adjust comment.
12 * w32term.c (x_scroll_bar_create): Adjust user.
13 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
14 * xterm.c (XTset_vertical_scroll_bar): Likewise.
15 Use bool for boolean.
16 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
17 to `unsigned int' when defining a bitfield.
18
53b64418
PE
192013-08-13 Paul Eggert <eggert@cs.ucla.edu>
20
21 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
22
eeaf9bf3
DA
232013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
24
25 * window.h (struct window): Convert left_margin_cols and
26 right_margin_cols from Lisp_Objects to integers. Adjust comment.
27 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
28 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
29 Adjust users.
30 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
31 Adjust comment.
32 (showing_window_margins_p, update_window_line, update_frame_1):
33 * fringe.c (draw_fringe_bitmap_1):
34 * xdisp.c (window_box_width): Adjust users.
35 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
36 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
37 Use direct assignment.
38 (Fset_window_configuration, save_window_save, Fwindow_margins):
39 Convert Lisp_Object to integer and back where appropriate.
40 (Fset_window_margins): Adjust user. Return t if any margin
41 was actually changed, and mention this in docstring.
42
956720af
XF
432013-08-13 Xue Fuqiao <xfq.free@gmail.com>
44
f73f4ce6 45 * syntax.c (forward_word):
956720af
XF
46 * cmds.c (forward_char, backward_char): Mention the optional argument.
47
9e37ee3b
DA
482013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
49
50 * window.h (struct window): Convert left_fringe_width
51 and right_fringe_width from Lisp_Objects to integers.
52 Adjust comment.
53 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
54 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
55 * window.c (wset_left_fringe_width, wset_right_fringe_width):
56 Remove.
57 (make_window): Initialize new integer fields to -1.
58 (Fsplit_window_internal): Use direct assignment.
59 (Fset_window_configuration, save_window_save): Convert
60 Lisp_Object to integer and back where appropriate.
61 (Fset_window_fringes): Adjust user. Return t if any fringe
62 was actually changed, and mention this in docstring.
63
e4375ca7
DA
642013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
65
66 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
67 * nsfns.m (x_set_cursor_type):
68 * w32fns.c (x_set_cursor_type):
69 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
70 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 71
a45543bc
DA
722013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
73
74 * font.c (clear_font_cache): New function, stripped from...
75 (Fclear_font_cache): ...here, which now uses the function
76 above. Adjust comment.
77 * font.h (clear_font_cache): Add prototype.
78 * xfaces.c (clear_face_cache): Use clear_font_cache.
79
ae966a86
DA
802013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
81
82 * window.c (Fset_window_start): Compare `w', not `window' because
83 `w' might not be equal to `window' after call to decode_live_window.
84
297a545b
PE
852013-08-12 Paul Eggert <eggert@cs.ucla.edu>
86
87 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
88 This fixes a problem introduced by the Bug#15035 patch
89 when using GPG. Reported by Herbert J. Skuhra.
90
aa942e2b
EZ
912013-08-12 Eli Zaretskii <eliz@gnu.org>
92
93 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
94 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
95 not yet initialized.
96
7699d09e
LMI
972013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
98
99 * decompress.c (Fzlib_decompress_region): Support zlib
100 decompression, too, and rename.
101
1d238bc7
PE
1022013-08-12 Paul Eggert <eggert@cs.ucla.edu>
103
104 Minor zlib configuration tweaks.
105 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
106 Don't assume presence of fn_inflateInit2_ zlib internal function.
107
8a44a184
LMI
1082013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
109
110 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
111 include the zlib prefix.
112
594a4307
EZ
1132013-08-12 Eli Zaretskii <eliz@gnu.org>
114
115 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
116 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
117 define static variables that are pointers to zlib functions to be
118 dynamically loaded.
119 (init_zlib_functions) [WINDOWSNT]: New function.
120 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
121 New macros.
122 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
123 macros instead of invoking the zlib functions directly.
124 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
125 Szlib_available_p.
126
d2e113bc
DA
1272013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
128
129 Avoid looping over all frame windows to freeze and unfreeze.
130 * window.h (struct window): Drop frozen_window_start_p.
131 (freeze_window_starts): Drop prototype.
132 * frame.h (struct frame): New frozen_window_starts flag.
133 (FRAME_WINDOWS_FROZEN): New macro.
134 * window.c (freeze_window_start, freeze_window_starts):
135 Remove.
136 (select_window, replace_window): Adjust users.
137 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
138 (window_frozen_p): New function.
139 (redisplay_window): Use it.
140
94fcd171
PE
1412013-08-12 Paul Eggert <eggert@cs.ucla.edu>
142
143 Fix some fd issues when running subprocesses (Bug#15035).
144 Fix bugs that can leak files or file descriptors on errors.
145 Don't unlink open temp files, as that's hard for users to diagnose
146 when things go awry (e.g., temp disk exhausted).
147 Don't bother to lock temp files. Check for invalid recursion.
148 * callproc.c (synch_process_fd): Remove. All uses removed.
149 (synch_process_tempfile): New var or macro.
150 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
151 New constants.
152 (record_kill_process): New arg, the temp name. All callers changed.
153 (delete_temp_file): Now just a simple wrapper around unlink.
154 (call_process_kill): New arg, the call_process_fd array.
155 Close them all. Clear synch_process_pid. Remove the temp file,
156 or arrange for it to be removed.
157 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
158 that's been moved to synch_process_tempfile. Caller changed.
159 Do not remove the tempfile; that's now call_process_kill's
160 responsibility.
161 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
162 call_process_kill; the caller now does that.
163 (call_process_cleanup): Do not close the process fd; that's now
164 call_process_kill's responsibility.
165 (Fcall_process): Implement via new function call_process, which
166 has most of the old body of Fcall_process, but with a different API.
167 (call_process): New function that does not open or close filefd if
168 it is nonnegative. Record which fds need to be closed, and let
169 call_process_kill close (and remove the tempfile, on MSDOS) on error.
170 Signal an error if invoked recursively (could be done via a hook).
171 Simplify creation of the tempfile in the MSDOS case.
172 Don't create the output file until after checking for the executable.
173 Report any failure to open /dev/null.
174 Don't open /dev/null for writing twice; once is enough.
175 Don't create pipe if all output is being discarded or sent to file.
176 Don't worry about setting up the coding system or reading from the
177 pipe if all output is being discarded.
178 Hoist fd_error local into top level, to lessen block nesting.
179 Don't record deleted pid here; now done by Fcall_process_region.
180 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
181 and note its success in synch_process_tempfile.
182 Do not leak resources when child_setup fails.
183 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
184 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
185 (create_temp_file): Now returns open fd, with an additional
186 Lisp_Object * argument to return the name. All callers changed.
187 Do not close the file; rewind it instead, and leave it open for
188 the caller. Do not lock the temp file. Unwind-protect the file
189 and the file-descriptor.
190 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
191 If an asynchrounous process, record it here, not in call_process.
192 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
193 * eval.c (set_unwind_protect): New function.
194 * fileio.c (write_region): New function, generalized from the
195 old Fwrite_region. Do not lock temp files.
196 (Fwrite_region): Use it.
197 * lisp.h (set_unwind_protect, write_region): New decls.
198 * process.c: Include <verify.h>.
199 (make_process): Mark fds as initially closed.
200 (deleted_pid_list): Now a list of pid-filename pairs.
201 All uses changed.
202 (close_process_fd): New function.
203 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
204 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
205 New constants. Verify that their number matches PROCESS_OPEN_FDS.
206 (create_process, create_pty, Fmake_serial_process)
207 (server_accept_connection): Record which fds need to be closed,
208 and let deactivate_process close them.
209 (Fmake_network_process): Do not discard the unwind-protect
210 until it's safe to do so.
211 (deactivate_process): Close the fds opened by create_process etc.
212 (Fprocess_send_eof): Adjust to new way of recording open fds.
213 Report an error if /dev/null can't be opened, instead of aborting.
214 * process.h (PROCESS_OPEN_FDS): New constant.
215 (struct Lisp_Process): New member open_fds.
216 (record_kill_process, record_deleted_pid): Adjust signatures.
217 (record_deleted_pid): Move decl here ...
218 * syswait.h (record_deleted_pid): ... from here.
219
d0e615c3
PE
2202013-08-11 Paul Eggert <eggert@cs.ucla.edu>
221
222 * decompress.c: Fix bugs with large buffers and weird inputs.
223 Tune a bit. Reindent as per usual Emacs style.
224 (BUFFER_SIZE): Remove.
225 (Fdecompress_gzipped_region): Do not mishandle input buffers with
226 more than UINT_MAX bytes. Decompress into the gap instead of into
227 an auto buffer, as this should avoid copying. Return nil if
228 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
229 set immediate_quit; we shouldn't trust zlib code that much.
230
313546eb
LMI
2312013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
232
99a32242
LMI
233 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
234 errors, and really move the gap to where we want it.
235
313546eb
LMI
236 * lisp.h: Include decompress.c support.
237
238 * emacs.c (main): Include decompress.c support.
239
240 * Makefile.in: Include -lz if present.
241
d2d699ac
JD
2422013-08-11 Jan Djärv <jan.h.d@swipnet.se>
243
f90e3ebd
JD
244 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
245 (initWithTitle:): Initialize frame to 0.
246 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
247 (fillWithWidgetValue:frame:): Renamed from
248 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
249
250 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
251 fillWithWidgetValue:frame:
252
423d3b3f
JD
253 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
254 remove memory leak warnings.
255
d2d699ac
JD
256 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
257 (ns_check_menu_open): Handle menu == nil. Remove assignment to
258 menu_pending_title.
259
260 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
261 (x_activate_menubar): Update the whole menu.
262 (trackingNotification:): Call ns_check_menu_open if tracking ends.
263 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
264 current event is not NSSystemDefined (Bug#15001).
265 Call ns_check_menu_open only if trackingMenu is 2.
266 (menuDidClose:): New method, decrease trackingMenu.
267 (fillWithWidgetValue:setDelegate:): New method.
268 (fillWithWidgetValue:): Call the above.
269
270 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
271
7d652d97
PE
2722013-08-11 Paul Eggert <eggert@cs.ucla.edu>
273
274 Omit some unnecessary casts.
275 Many of these go back to the old pre-C89 days, when they may have
276 been needed, but we've been assuming C89 or later for a while now.
277 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
278 (live_float_p, live_misc_p, live_vector_p):
279 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
280 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
281 (defvar_per_buffer):
282 * callint.c (Fcall_interactively):
283 * doc.c (Fsubstitute_command_keys):
284 * filelock.c (get_boot_time):
285 * frame.c (xrdb_get_resource):
286 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
287 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
288 (xg_get_file_name_from_selector, menuitem_destroy_callback)
289 (menuitem_highlight_callback, menu_destroy_callback)
290 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
291 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
292 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
293 (xg_tool_bar_help_callback, tb_size_cb):
294 * image.c (xpm_alloc_color, png_read_from_memory)
295 (png_read_from_file, png_load_body, our_memory_skip_input_data)
296 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
297 (syms_of_image):
298 * keymap.c (describe_map):
299 * nsfns.m (Fns_display_monitor_attributes_list):
300 * nsmenu.m (process_dialog:):
301 * nsterm.m (hold_event):
302 * process.c (wait_reading_process_output):
303 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
304 * scroll.c (do_direct_scrolling, scrolling_1):
305 * termcap.c (tgetent):
306 * window.c (check_window_containing, add_window_to_list)
307 (freeze_window_starts):
308 * xdisp.c (compare_overlay_entries, vmessage):
309 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
310 (x_get_monitor_attributes_xrandr)
311 (Fx_display_monitor_attributes_list, x_display_info_for_name)
312 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
313 * xfont.c (xfont_match, xfont_open):
314 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
315 (menubar_selection_callback, menu_position_func)
316 (popup_selection_callback, create_and_show_popup_menu)
317 (dialog_selection_callback, create_and_show_dialog):
318 * xrdb.c (x_get_string_resource):
319 (main) [TESTRM]:
320 * xsmfns.c (x_session_check_input):
321 * xterm.c (x_draw_glyphless_glyph_string_foreground)
322 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
323 (xaw_jump_callback, xaw_scroll_callback):
324 Omit unnecessary casts.
325
9acc1074
PE
3262013-08-10 Paul Eggert <eggert@cs.ucla.edu>
327
328 Minor string-length refactoring.
329 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
330 * frame.c (make_monitor_attribute_list):
331 Prefer build_string to strlen + make_string.
332
361c0eb8
JD
3332013-08-10 Jan Djärv <jan.h.d@swipnet.se>
334
335 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
336 don't check minor_code (Bug#14417).
337
14ba0822
EZ
3382013-08-09 Eli Zaretskii <eliz@gnu.org>
339
340 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
341 vertical positions instead. This avoids calling MATRIX_ROW with
342 row numbers that are possibly beyond valid limits. (Bug#15064)
343
309f24d1
DA
3442013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Use xstrdup and build_unibyte_string where applicable.
347 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
348 * xfns.c (x_window):
349 * xrdb.c (x_get_customization_string):
350 * xterm.c (xim_initialize):
351 * w32fns.c (w32_window): Use xstrdup.
352 (w32_display_monitor_attributes_list):
353 * emacs.c (init_cmdargs):
354 * keyboard.c (PUSH_C_STR):
355 * nsfont.m (nsfont_open):
356 * sysdep.c (system_process_attributes):
357 * w32.c (system_process_attributes):
358 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
359
55902276
EZ
3602013-08-09 Eli Zaretskii <eliz@gnu.org>
361
362 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
363 variables of these types so that GDB would know about them, as aid
364 for debugging fatal exceptions. (Bug#15024) See also
365 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
366 discussions.
367
10bf7f5a
JD
3682013-08-08 Jan Djärv <jan.h.d@swipnet.se>
369
370 * nsterm.m (ns_update_begin): Don't change clip path if it would be
371 larger than the NSWindow (Bug#14934).
372
65620264
DA
3732013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
374
375 Redesign redisplay interface to drop global variable updated_window.
376 Always pass currently updated window as a parameter to update routines.
377 * dispextern.h (updated_window): Remove declaration.
378 (struct redisplay_interface): Pass window parameter to
379 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
380 and after_update_window_hook.
381 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
382 Adjust prototypes.
383 * dispnew.c (updated_window): Remove.
384 (redraw_overlapped_rows, update_marginal_area, update_text_area)
385 (update_window_line): Adjust to match redisplay interface changes.
386 * nsterm.m (ns_update_window_begin, ns_update_window_end)
387 (ns_scroll_run, ns_after_update_window_line):
388 * w32term.c (x_update_window_begin, x_update_window_end)
389 (x_after_update_window_line, x_scroll_run):
390 * xterm.c (x_update_window_begin, x_update_window_end)
391 (x_after_update_window_line, x_scroll_run):
392 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
393 Likewise. Adjust comments where appropriate.
394 (x_cursor_to): Simplify because this is always called during window
395 update (but install debugging check anyway).
396 (expose_window): Check must_be_updated_p flag to see whether this
397 function is called during window update.
398
628fdc56
DA
3992013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
400
401 Do not reset window modification event counters excessively.
402 These leftovers and poor man's tricky methods to catch extra
403 redisplay's attention are no longer needed.
404 * frame.c (set_menu_bar_lines_1):
405 * minibuf.c (read_minibuf_unwind):
406 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
407 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
408 (window_scroll_line_based, Fset_window_configuration):
409 * xdisp.c (redisplay_window): Do not reset last_modified and
410 last_overlay_modified counters.
411
8fd9c92e
JD
4122013-08-07 Jan Djärv <jan.h.d@swipnet.se>
413
414 * xselect.c (x_send_client_event): Set send_event and serial, memset
415 data.l as it might be bigger than data.b. Use 24 bit mask to
416 XSendEvent (Bug#15034).
417
0ee18172
EZ
4182013-08-07 Eli Zaretskii <eliz@gnu.org>
419
420 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
421 for TTY frames that are not the top frame on their console.
422 (Bug#14616)
423
16ddd1a6
MR
4242013-08-07 Martin Rudalics <rudalics@gmx.at>
425
426 * w32term.c (w32fullscreen_hook): Really maximize frame when
427 asked for (Bug#14841).
428
d2a95ffb
DA
4292013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
430
431 Prefer selected_window to Fselected_window, likewise for frames.
432 * buffer.c (Fbuffer_swap_text):
433 * data.c (Fvariable_binding_locus):
434 * window.c (run_window_configuration_change_hook): Adjust users.
435 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
436 Use decode_live_frame.
437
170da1ec
DA
4382013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
439
440 Be more careful if selected window shows the buffer other than current,
441 use window_outdated only if this is not so. This change should also
442 address some weird issues discussed in Bug#13012.
443 * window.h (window_outdated): New prototype.
444 * window.c (window_outdated): Now here. Convert from static and
445 always assume window's buffer.
446 (Fwindow_end, Fwindow_line_height): Use it.
447 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
448 and always assume window's buffer.
449 (redisplay_window): Adjust user.
e5eefe9b 450 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
451 check whether mode line should be updated only if selected window
452 shows current buffer.
453 (run_window_scroll_functions): Use eassert for debugging check.
454 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
455
56b5d5b1
DA
4562013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
457
458 * window.c (window_scroll, window_scroll_pixel_based)
459 (window_scroll_line_based): Use bool for booleans.
460
2878ba7e
PE
4612013-08-06 Paul Eggert <eggert@cs.ucla.edu>
462
463 * process.c: Fix minor off-by-one issues in descriptor counts.
464 This shouldn't fix any real bugs, but it cleans up the code a bit.
465 (max_process_desc, max_input_desc): -1, not 0, means none.
466 All uses changed.
467 (delete_input_desc): New function.
468 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
469 (deactivate_process): Scan backwards when recomuting max_process_desc;
470 that should be faster.
471 (init_process_emacs): Initialize max_input_desc.
472
e30b79c1
DA
4732013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
474
475 Use region cache to speedup bidi_find_paragraph_start.
476 * buffer.h (struct buffer): New member bidi_paragraph_cache.
477 Rename cache_long_line_scans to cache_long_scans.
478 * buffer.c (bset_cache_long_line_scans): Rename to
479 bset_cache_long_scans.
480 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
481 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
482 into account.
483 (syms_of_buffer): Rename cache-long-line-scans to
484 cache-long-scans. Adjust docstring.
485 * search.c (newline_cache_on_off):
486 * indent.c (width_run_cache_on_off): Adjust users.
487 * bidi.c (bidi_paragraph_cache_on_off): New function.
488 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
489 * insdel.c (prepare_to_modify_buffer): Invalidate
490 bidi_paragraph_cache if enabled.
491
00012b86
DA
4922013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
493
494 Invalidate region caches only if buffer text is going to be changed.
495 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
496 (modify_text): ...new prototype.
497 (prepare_to_modify_buffer_1): New prototype.
498 * textprop.c (modify_region): Rename to...
499 (modify_text_properties): ...new function.
500 (add_text_properties_1, set_text_properties, Fremove_text_properties)
501 (Fremove_list_of_text_properties): Adjust users.
502 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
503 (modify_text): ...new function.
504 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
505 (prepare_to_modify_buffer_1): ...new function.
506 * casefiddle.c (casify_region):
507 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
508 (Ftranspose_regions): Use modify_text.
509
dc6c0eda
SM
5102013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
511
512 * lisp.mk (lisp): Add nadvice.elc.
513
8f3a2c26
DA
5142013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
515
516 New macro to iterate over live buffers similar to frames.
517 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
518 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
519 Declare buffer-related variables here to offload lisp.h.
520 * buffer.c (Vbuffer_alist): Adjust comment.
521 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
522 (other_buffer_safely):
523 * data.c (store_symval_forwarding):
524 * dispnew.c (Fframe_or_buffer_changed_p):
525 * fileio.c (Fdo_auto_save):
526 * filelock.c (unlock_all_files):
527 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
528
e0fdb694
PE
5292013-08-04 Paul Eggert <eggert@cs.ucla.edu>
530
531 Fix some minor races in hosts lacking mkostemp (Bug#15015).
532 * callproc.c (create_temp_file):
533 * filelock.c (create_lock_file):
534 Assume mkostemp, since it's now provided by Gnulib.
535
63f5c6c2
EZ
5362013-08-04 Eli Zaretskii <eliz@gnu.org>
537
538 * w32.c (mkostemp): New function.
539 (mktemp): Remove, no longer used. Most of the code reused in
540 mkostemp. (Bug#15015)
484ab239 541 (mktemp): Don't undef.
63f5c6c2 542
f0b79313
DA
5432013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
544
545 * dispnew.c (glyph_matrix_count, glyph_pool_count):
546 Move under GLYPH_DEBUG and ENABLE_CHECKING.
547 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
548 (free_glyph_pool, check_glyph_memory): Likewise for
549 all users. Adjust comments where appropriate.
550
98f638d6
PE
5512013-08-03 Paul Eggert <eggert@cs.ucla.edu>
552
553 * composite.h: Minor fixups.
554 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
555 to fix a misspelling, and change it to an inline function while
556 we're at it (it need not be a macro). All uses changed.
557 (composition_method, composition_valid_p):
558 Rewrite to avoid assignments in if-conditions.
559
75c59fb3
DA
5602013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
561
562 Do not use global Lisp_Object in composition macros.
563 * composite.h (composition_temp): Remove declaration.
564 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
565 (composition_method, composition_valid_p): ...inline functions.
416a3e01 566 (compose_region): Remove the leftover.
75c59fb3
DA
567 * composite.c (composition_temp): Remove.
568 (run_composition_function, update_compositions)
569 (composition_compute_stop_pos, composition_adjust_point)
570 (Ffind_composition_internal):
571 * coding.c (handle_composition_annotation):
572 * xdisp.c (handle_composition_prop, check_point_in_composition):
573 Related users changed.
574
a10c8269
DA
5752013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Drop FRAME_PTR typedef.
578 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
579 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
580 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
581 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
582 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
583 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
584 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
585 All related users changed.
586
a104f656
SM
5872013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
588
589 * eval.c (default_toplevel_binding): New function.
590 (Fdefvar): Use it.
591 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
592 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
593 (syms_of_eval): Export them.
594 * data.c (Fdefault_value): Micro cleanup.
595 * term.c (init_tty): Use "false".
596
4b5c9326
DA
5972013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
598
599 Fix X GC leak in GTK and raw (no toolkit) X ports.
600 * xterm.c (x_free_frame_resources): If white and black relief
601 GCs are allocated, always free them here.
602 * xfns.c (x_make_gc): Omit redundant initialization.
603 * widget.c (create_frame_gcs): Remove the leftover.
604 (EmacsFrameDestroy): Do nothing because all GCs are now freed
605 in x_free_frame_resources.
606
b19aa636
JD
6072013-08-02 Jan Djärv <jan.h.d@swipnet.se>
608
609 * nsterm.m (windowWillResize:toSize:): Only change title if
610 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
611 modifying it.
612 (viewDidEndLiveResize): New method.
613
614 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
615 inside NS_IMPL_COCOA.
616
af1f7e06
DA
6172013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
618
619 * insdel.c (adjust_after_replace, replace_range, del_range_2):
620 Do not check whether undo is enabled because record_insert and
621 record_delete does that themselves.
622
65b02bb9
DA
6232013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
624
625 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
626 member which is not really used any more.
627 (FRAME_XIC_BASE_FONTNAME): Remove.
628 * xfns.c (xic_free_fontset): Adjust user.
629 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
630 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
631 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
632 (xdialog_show): Use eassert for debugging check.
7ee0f047 633 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 634
6318cde0
PE
6352013-08-01 Paul Eggert <eggert@cs.ucla.edu>
636
637 * fileio.c, fns.c (merge): Move extern decl from here ...
638 * lisp.h (merge): ... to here.
639
6c1a09ba
DA
6402013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
641
642 Fix last font-related change.
643 * w32font.h (w32font_list_internal, w32font_match_internal):
644 Fix prototype.
645 * w32uniscribe.c (uniscribe_list, uniscribe_match):
646 (uniscribe_list_family): Adjust to match font API change.
647 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
648 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
649
f8c20208
DA
6502013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
651
652 * frame.h (FRAME_MOUSE_UPDATE):
653 * nsterm.m (ns_frame_up_to_date): Omit redundant check
654 whether hlinfo->mouse_face_mouse_frame is non-NULL.
655
fdb396e2
DA
6562013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
657
658 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
659 * font.h (struct font_driver): Change list, match, and list_family
660 functions to accept struct frame * as first arg.
661 * font.c (font_score, font_compare, font_sort_entities): Remove
662 prototypes.
663 (font_sort_entities, font_list_entities, font_select_entity):
664 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
665 match font API change.
666 * xfont.c (xfont_list, xfont_match, xfont_list_family):
667 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
668 * ftxfont.c (ftxfont_list, ftxfont_match):
669 * xftfont.c (xftfont_list, xftfont_match):
670 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
671 * w32font.c (w32font_list, w32font_match, w32font_list):
672 (w32font_list_internal, w32_font_match_internal): Likewise.
673 * xfaces.c (Fx_family_fonts): Adjust user.
674
52b8a085
DA
6752013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
676
677 Do not use pure Xism x_wm_set_icon_position in non-X ports.
678 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
679 only if HAVE_X_WINDOWS is in use.
680 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
681 * nsterm.m (x_wm_set_icon_position): Remove no-op.
682 * w32term.c (x_wm_set_icon_position): Likewise.
683 * w32fns.c (x_icon): Adjust user.
684
c791c18e
DA
6852013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
686
687 * xterm.c (last_mouse_press_frame): Remove the
688 leftover which is not really used any more.
689 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
690 (x_flush): Call XFlush once per each X display, not frame.
691 This is better because this code always unconditionally skips
692 non-X frames in Vframe_list and issues the only XFlush if we
693 have more than one X frame on the same X display.
2f935d86
DA
694 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
695 Use bool for booleans.
696 (x_draw_glyph_string_background, cvt_string_to_pixel):
697 (cvt_pixel_dtor): Drop unnecessary prototypes.
698 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 699
f435830e
DA
7002013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
701
702 Drop unnecessary functions that deals with frame pixel size.
703 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
704 (x_pixel_height): Drop prototypes.
705 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
706 (x_pixel_height): Drop implementations.
707 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
708 which should be always valid for window frame.
709 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
710 * w32menu.c (Fx_popup_dialog):
711 * xmenu.c (Fx_popup_dialog): Likewise for both.
712
84231434
DA
7132013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
714
715 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
716 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
717 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
718 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
719 and mention nil frame in docstring.
84231434 720
959067a1
DA
7212013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
722
723 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
724 (x_figure_window_size): Likewise. Adjust to return long.
725 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
726 (toplevel): Move Qterminal_live_p to...
727 * terminal.c (toplevel): ...here, make it static, and...
728 (syms_of_terminal): ...DEFSYM here.
729 * frame.h (Qterminal_live_p): Remove declaration.
730 (make_frame, x_figure_window_size): Adjust prototype.
731 * nsfns.m (Fx_create_frame): Use long for window flags.
732
f4b169ce
PE
7332013-07-30 Paul Eggert <eggert@cs.ucla.edu>
734
735 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
736 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
737 Do not assume that emacs_close (INT_MAX) is a no-op.
738
bee6a2c7
DA
7392013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
740
741 * xfaces.c (make_face_cache): For struct face_cache, prefer
742 xmalloc to xzalloc and so avoid redundant call to memset.
743 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
744
d7e6881a
DA
7452013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
746
747 * fringe.c (draw_window_fringes, update_window_fringes)
748 (compute_fringe_widths):
749 * w32term.c (x_draw_glyph_string):
750 * window.c (candidate_window_p, Frecenter):
751 * xfaces.c (realize_basic_faces, realize_default_face)
752 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
753 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
754 * xfns.c (x_set_cursor_color, xic_free_xfontset):
755 * xmenu.c (Fx_menu_bar_open_internal):
756 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
757 * xsettings.c (xft_settings_event):
758 * xterm.c (x_draw_glyph_string, x_had_errors_p):
759 Use bool for booleans. Adjust style and comments where
760 appropriate.
761 * dispextern.h (draw_window_fringes, update_window_fringes)
762 (compute_fringe_widths):
763 * xterm.h (x_had_errors_p): Adjust prototype.
764
ec3058af
DA
7652013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
766
767 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
768 CHECK_LIST. Rewrite the loop to avoid useless local variable.
769
218e0637
DA
7702013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
771
772 * fns.c (toplevel): Remove comment before Fsafe_length because
773 it checks for QUIT.
774
e560aba9
PE
7752013-07-28 Paul Eggert <eggert@cs.ucla.edu>
776
777 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
778
2e5ce5de
EZ
7792013-07-28 Eli Zaretskii <eliz@gnu.org>
780
781 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
782 frame which got the message is still alive, before dereferencing
783 its pointer. (Bug#14970)
784
785 * frame.c (delete_frame): Test "this" frame's minibuffer window to
786 be a live window, before using it as such. (Bug#14970)
787
e95da6d3
EZ
7882013-07-27 Eli Zaretskii <eliz@gnu.org>
789
790 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
791 w32_detect_focus_change instead of doing part of its job by hand.
792 This fixes the problem whereby FOCUS_OUT events were not sent to
793 the event queue.
794
a8f93651
EZ
7952013-07-26 Eli Zaretskii <eliz@gnu.org>
796
fec92060
EZ
797 * process.c (Fprocess_list): Doc fix.
798
a8f93651
EZ
799 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
800 being re-exposed only if it didn't ask to become visible.
801 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
802 was previously iconified. (Bug#14841)
803 (x_iconify_frame): Mark the frame iconified.
804
d5a7a9d9
PE
8052013-07-26 Paul Eggert <eggert@cs.ucla.edu>
806
807 Fix minor problems found by static checking.
808 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
809 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
810
56ea7291
SM
8112013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
812
813 * eval.c (set_specpdl_old_value): New function.
814 (unbind_to): Minor simplification.
815 (get_backtrace_frame): New function.
816 (Fbacktrace_frame): Use it. Add `base' argument.
817 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
818 (syms_of_eval): Export backtrace-eval.
819 * xterm.c (x_focus_changed): Simplify.
820
9d611ffe
PE
8212013-07-25 Paul Eggert <eggert@cs.ucla.edu>
822
823 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
824
999c74e3
EZ
8252013-07-24 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (redisplay_window): Instead of moving point out of
828 scroll margin, reject the force_start method, and try scrolling
829 instead. (Bug#14780)
830
198fa217
KB
8312013-07-24 Ken Brown <kbrown@cornell.edu>
832
833 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
834 (Bug#14944).
835
53840e55
PE
8362013-07-24 Paul Eggert <eggert@cs.ucla.edu>
837
838 * eval.c (Fprogn): Do not check that BODY is a proper list.
839 This undoes the previous change. The check slows down the
840 interpreter, and is not needed to prevent a crash. See
841 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
842
60967f56
GM
8432013-07-23 Glenn Morris <rgm@gnu.org>
844
845 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
846
9ca960e2
PE
8472013-07-23 Paul Eggert <eggert@cs.ucla.edu>
848
a29c3e6d
PE
849 Port to GNU/Linux systems with tinfo but not ncurses.
850 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
851 to decide whether ncurses is being used. Without this change,
852 GCC complains about tgetent not being declared, on a system
853 that has tinfo installed but ncurses not installed.
854
f274311c
PE
855 * eval.c (Fprogn): Check that BODY is a proper list.
856
16b0520a
PE
857 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
858 * data.c (Fsetq_default):
859 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
860 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
861 (Fcondition_case):
862 Tune by taking advantage of the fact that ARGS is always a list
863 when a function is declared to have UNEVALLED args.
864
9ca960e2
PE
865 * emacsgtkfixed.c: Port to GCC 4.6.
866 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
867
afacaa1b
JB
8682013-07-23 Juanma Barranquero <lekktu@gmail.com>
869
870 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
871 here to silence compiler warnings.
872
368a85a4
PE
8732013-07-22 Paul Eggert <eggert@cs.ucla.edu>
874
875 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
876 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
877 from messing up Emacs's 'struct frame' (Bug#14923).
878
f4e891b5
PE
8792013-07-21 Paul Eggert <eggert@cs.ucla.edu>
880
881 * alloc.c (make_save_ptr_ptr): Define this function.
882 It was inadvertently omitted. It's needed only if
883 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
884
96c8b65e
JD
8852013-07-21 Jan Djärv <jan.h.d@swipnet.se>
886
887 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
888 frame have focus (Bug#14895).
889
ee010797
PE
8902013-07-21 Paul Eggert <eggert@cs.ucla.edu>
891
892 Avoid vfork-related deadlock more cleanly.
893 * callproc.c (child_setup): When the child's exec fails, output
894 the program name, as that's more useful. Use O_NONBLOCK to avoid
895 deadlock.
896 * process.c (create_process_1): Remove; no longer needed.
897 (create_process): Remove timer hack; no longer needed, now that
898 the child avoids deadlock.
899
f0398ec1 9002013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
901
902 * image.c (Fimage_flush): Fix doc typo.
903
b2a069c2
PE
9042013-07-20 Paul Eggert <eggert@cs.ucla.edu>
905
6496aec9
PE
906 Fix array bounds violation when pty allocation fails.
907 * process.c (PTY_NAME_SIZE): New constant.
908 (pty_name): Remove static variable; it's now auto.
909 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
910 Take pty_name as an arg rather than using a static variable.
911 All callers changed.
912 (create_process): Recover pty_flag from process, not from volatile local.
913 (create_pty): Stay inside array even when pty allocation fails.
914 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
915
b2a069c2
PE
916 * lread.c (Fload): Avoid initialization only when lint checking.
917 Mention that it's needed only for older GCCs.
918
99107004
KH
9192013-07-20 Kenichi Handa <handa@gnu.org>
920
921 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
922 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
923
6b1b199d
AS
9242013-07-20 Andreas Schwab <schwab@linux-m68k.org>
925
926 * lread.c (Fload): Avoid uninitialized warning.
927
4195afc3
PE
9282013-07-19 Paul Eggert <eggert@cs.ucla.edu>
929
3f5bef16
PE
930 Fix some minor file descriptor leaks and related glitches.
931 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
932 (create_lock_file): Use write, not emacs_write.
933 * image.c (slurp_file, png_load_body):
934 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
935 (server_accept_connection):
936 Don't leak an fd on memory allocation failure.
937 * image.c (slurp_file): Add a cheap heuristic for growing files.
938 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
939 as that's what the other routines do. Maybe input need not be
940 blocked at all, but it's better to be consistent.
941 Avoid undefined behavior when strlen is zero.
942
4195afc3
PE
943 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
944 (NSTATICS): Now a constant; doesn't need to be a macro.
945
a1aeeffe
RS
9462013-07-19 Richard Stallman <rms@gnu.org>
947
948 * coding.c (decode_coding_utf_8): Add simple loop for fast
949 processing of ASCII characters.
950
63b34baa
PE
9512013-07-19 Paul Eggert <eggert@cs.ucla.edu>
952
953 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
954
621dd9ac
EZ
9552013-07-19 Eli Zaretskii <eliz@gnu.org>
956
957 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
958 unportable 'struct x_display_info'.
959 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
960 is a portable type.
961
1396ac86
PE
9622013-07-19 Paul Eggert <eggert@cs.ucla.edu>
963
ab9980cd
PE
964 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
965 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
966 or fscanf fails.
967 (system_process_attributes): Prefer plain char to unsigned char
968 when either will do. Clean up properly if interrupted or if
969 memory allocations fail. Don't assume sscanf succeeds. Remove
970 no-longer-needed workaround to stop GCC from whining. Read
971 command-line once, instead of multiple times. Check read status a
972 bit more carefully.
973
1396ac86
PE
974 Fix obscure porting bug with varargs functions.
975 The code assumed that int is treated like ptrdiff_t in a vararg
976 function, which is not a portable assumption. There was a similar
977 -- though these days less likely -- porting problem with various
978 assumptions that pointers of different types all smell the same as
979 far as vararg functions is conserved. To make this problem less
980 likely in the future, redo the API to use varargs functions.
981 * alloc.c (make_save_value): Remove this vararg function.
982 All uses changed to ...
983 (make_save_int_int_int, make_save_obj_obj_obj_obj)
984 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
985 New functions.
986 (make_save_ptr): Rename from make_save_pointer, for consistency with
987 the above. Define only on platforms that need it. All uses changed.
988
4d19d194
PE
9892013-07-18 Paul Eggert <eggert@cs.ucla.edu>
990
991 * keyboard.c: Try to fix typos in previous change.
992 (DISPLAY_LIST_INFO): New macro.
993 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 994 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 995
945c5bb1
JB
9962013-07-18 Juanma Barranquero <lekktu@gmail.com>
997
998 * keyboard.c (kbd_buffer_get_event):
999 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1000 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1001
f4b1eb36
PE
10022013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1003
5e679a2c
PE
1004 * filelock.c: Fix unlikely file descriptor leaks.
1005 (get_boot_time_1): Rework to avoid using emacs_open.
1006 This doesn't actually fix a leak, but is better anyway.
1007 (read_lock_data): Use read, not emacs_read.
1008
a8cd4836
PE
1009 * doc.c: Fix minor memory and file descriptor leaks.
1010 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1011 (get_doc_string, Fsnarf_documentation):
1012 Fix file descriptor leak on error.
1013
ef30e638
PE
1014 * term.c: Fix minor fdopen-related file descriptor leaks.
1015 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1016 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1017
f4b1eb36
PE
1018 * charset.c: Fix file descriptor leaks and errno issues.
1019 Include <errno.h>.
1020 (load_charset_map_from_file): Don't leak file descriptor on error.
1021 Use plain record_xmalloc since the allocation is larger than
1022 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1023 of entries.
1024 * eval.c (record_unwind_protect_nothing):
1025 * fileio.c (fclose_unwind):
1026 New functions.
1027 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1028 The replacement doesn't block input, but that no longer seems
1029 necessary.
1030
b648c163
PE
10312013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1032
a0931322
PE
1033 * lread.c: Fix file descriptor leaks and errno issues.
1034 (Fload): Close some races that leaked fds or streams when 'load'
1035 was interrupted.
1036 (Fload, openp): Report error number of last nontrivial failure to open.
1037 ENOENT counts as trivial.
1038 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1039 New functions.
1040 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1041 now that the function is always called with a nonnegative arg.
1042 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1043 All uses replaced with ...
1044 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1045
b648c163
PE
1046 A few more minor file errno-reporting bugs.
1047 * callproc.c (Fcall_process):
1048 * doc.c (Fsnarf_documentation):
1049 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1050 * process.c (set_socket_option):
1051 Don't let a constructor trash errno.
1052 * doc.c: Include <errno.h>.
1053
b1dc4084
JB
10542013-07-16 Juanma Barranquero <lekktu@gmail.com>
1055
1056 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1057
c43843aa
PE
10582013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1059
50a30cce
PE
1060 Fix w32 bug with call-process-region (Bug#14885).
1061 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1062 to Fcall_process when the input is empty. This simplifies the
1063 code a bit. It makes no difference on POSIXish platforms but
1064 apparently it fixes a bug on w32.
1065
44e18199 1066 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1067 * fileio.c (close_file_unwind): Don't close if FD is negative;
1068 this can happen when unwinding a zapped file descriptor.
1069 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1070 in case Emacs runs out of memory between the two unwind-protects.
1071 Don't trash errno when closing FD.
1072 Zap the FD in the specpdl when closing it, instead of deferring
1073 the removal of the unwind-protect; this fixes a bug where a child
1074 function unwinds the stack past us.
1075
27e498e6
PE
1076 New unwind-protect flavors to better type-check C callbacks.
1077 This also lessens the need to write wrappers for callbacks,
1078 and the need for make_save_pointer.
1079 * alloca.c (free_save_value):
1080 * atimer.c (run_all_atimers):
1081 Now extern.
1082 * alloc.c (safe_alloca_unwind):
1083 * atimer.c (unwind_stop_other_atimers):
1084 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1085 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1086 * minibuf.c (choose_minibuf_frame_1):
1087 * process.c (make_serial_process_unwind):
1088 * xdisp.h (pop_message_unwind):
1089 * xselect.c (queue_selection_requests_unwind):
1090 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1091 * alloca.c (record_xmalloc):
1092 Prefer record_unwind_protect_ptr to record_unwind_protect with
1093 make_save_pointer.
1094 * alloca.c (Fgarbage_collect):
1095 Prefer record_unwind_protect_void to passing a dummy.
1096 * buffer.c (restore_buffer):
1097 * window.c (restore_window_configuration):
1098 * xfns.c, w32fns.c (do_unwind_create_frame)
1099 New wrapper. All record-unwind uses of wrappee changed.
1100 * buffer.c (set_buffer_if_live):
1101 * callproc.c (call_process_cleanup, delete_temp_file):
1102 * coding.c (code_conversion_restore):
1103 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1104 * editfns.c (save_excursion_restore)
1105 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1106 (save_restriction_restore):
1107 * eval.c (restore_stack_limits, un_autoload):
1108 * fns.c (require_unwind):
1109 * keyboard.c (recursive_edit_unwind, tracking_off):
1110 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1111 * macros.c (pop_kbd_macro, restore_menu_items):
1112 * nsfns.m (unwind_create_frame):
1113 * print.c (print_unwind):
1114 * process.c (start_process_unwind):
1115 * search.c (unwind_set_match_data):
1116 * window.c (select_window_norecord, select_frame_norecord):
1117 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1118 (fast_set_selected_frame):
1119 * xfns.c, w32fns.c (unwind_create_tip_frame):
1120 Return void, not a dummy Lisp_Object. All uses changed.
1121 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1122 * callproc.c (call_process_kill):
1123 * fileio.c (restore_point_unwind, decide_coding_unwind)
1124 (build_annotations_unwind):
1125 * insdel.c (Fcombine_after_change_execute_1):
1126 * keyboard.c (read_char_help_form_unwind):
1127 * menu.c (unuse_menu_items):
1128 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1129 * sound.c (sound_cleanup):
1130 * xdisp.c (unwind_redisplay):
1131 * xfns.c (clean_up_dialog):
1132 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1133 Accept no args and return void, instead of accepting and returning
1134 a dummy Lisp_Object. All uses changed.
1135 * cygw32.c (fchdir_unwind):
1136 * fileio.c (close_file_unwind):
1137 * keyboard.c (restore_kboard_configuration):
1138 * lread.c (readevalllop_1):
1139 * process.c (wait_reading_process_output_unwind):
1140 Accept int and return void, rather than accepting an Emacs integer
1141 and returning a dummy object. In some cases this fixes an
1142 unlikely bug when the corresponding int is outside Emacs integer
1143 range. All uses changed.
1144 * dired.c (directory_files_internal_unwind):
1145 * fileio.c (do_auto_save_unwind):
1146 * gtkutil.c (pop_down_dialog):
1147 * insdel.c (reset_var_on_error):
1148 * lread.c (load_unwind):
1149 * xfns.c (clean_up_file_dialog):
1150 * xmenu.c, nsmenu.m (pop_down_menu):
1151 * xmenu.c (cleanup_widget_value_tree):
1152 * xselect.c (wait_for_property_change_unwind):
1153 Accept pointer and return void, rather than accepting an Emacs
1154 save value encapsulating the pointer and returning a dummy object.
1155 All uses changed.
1156 * editfns.c (Fformat): Update the saved pointer directly via
1157 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1158 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1159 (unwind_body): New function.
1160 (record_unwind_protect): First arg is now a function returning void,
1161 not a dummy Lisp_Object.
1162 (record_unwind_protect_ptr, record_unwind_protect_int)
1163 (record_unwind_protect_void): New functions.
1164 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1165 * fileio.c (struct auto_save_unwind): New type.
1166 (do_auto_save_unwind): Use it.
1167 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1168 * insdel.c (struct rvoe_arg): New type.
1169 (reset_var_on_error): Use it.
1170 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1171 New constants.
1172 (specbinding_func): Remove; there are now several such functions.
1173 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1174 (set_unwind_protect_ptr): New function.
1175 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1176
4e604a5d
PE
1177 Be simpler and more consistent about reporting I/O errors.
1178 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1179 Say "Read error" and "Write error", rather than "I/O error", or
1180 "IO error reading", or "IO error writing", when a read or write
1181 error occurs.
1182 * process.c (Fmake_network_process, wait_reading_process_output)
1183 (send_process, Fprocess_send_eof, wait_reading_process_output):
1184 Capitalize diagnostics consistently. Put "failed foo" at the
1185 start of the diagnostic, so that we don't capitalize the
1186 function name "foo". Consistently say "failed" for such
1187 diagnostics.
1188 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1189 All callers changed. This is so it can use report_file_error.
1190 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1191 diagnostics consistently as above.
1192
a9757f6a
PE
1193 * fileio.c (report_file_errno): Fix errno reporting bug.
1194 If the file name is neither null nor a pair, package it up as a
1195 singleton list. All callers changed, both to this function and to
1196 report_file_error. This fixes a bug where the memory allocator
1197 invoked by list1 set errno so that the immediately following
1198 report_file_error reported the wrong errno value.
1199
c43843aa
PE
1200 Fix minor problems found by --enable-gcc-warnings.
1201 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1202 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1203
18c26d81
JD
12042013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1205
1206 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1207 Set event->arg to Qt if switch-event shall be generated.
1208 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1209
1210 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1211
1212 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1213 FOCUS_OUT_EVENT.
1214
1215 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1216 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1217 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1218 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1219 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1220 and there is a focused frame.
1221 (head_table): Add focus-in and focus-out.
1222 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1223 bind to handle-focus-in/out.
1224
1225 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1226 (Fhandle_switch_frame): Call Fhandle_focus_in.
1227 (syms_of_frame): defsubr handle-focus-in/out.
1228
6c6f1994
PE
12292013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1230
c7ddc792
PE
1231 Fix porting bug to older POSIXish platforms (Bug#14862).
1232 * sysdep.c (emacs_pipe): New function, that implements
1233 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1234 This should port better to CentOS 5 and to Mac OS X 10.6.
1235 All calls to pipe2 changed.
1236
6c6f1994
PE
1237 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1238 This makes the code easier to read and the executable a bit smaller.
1239 Do not replace all calls to Fcons that happen to create lists,
1240 just calls that are intended to create lists. For example, when
1241 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1242 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1243 Similarly for list2 through list5.
1244 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1245 * bytecode.c (exec_byte_code):
1246 * callint.c (quotify_arg, Fcall_interactively):
1247 * callproc.c (Fcall_process, create_temp_file):
1248 * charset.c (load_charset_map_from_file)
1249 (Fdefine_charset_internal, init_charset):
1250 * coding.c (get_translation_table, detect_coding_system)
1251 (Fcheck_coding_systems_region)
1252 (Fset_terminal_coding_system_internal)
1253 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1254 * composite.c (update_compositions, Ffind_composition_internal):
1255 * dired.c (directory_files_internal, file_name_completion)
1256 (Fsystem_users):
1257 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1258 * doc.c (Fsnarf_documentation):
1259 * editfns.c (Fmessage_box):
1260 * emacs.c (main):
1261 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1262 (Feval, eval_sub, Ffuncall, apply_lambda):
1263 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1264 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1265 (Fset_file_times, Finsert_file_contents)
1266 (Fchoose_write_coding_system, Fwrite_region):
1267 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1268 * font.c (font_registry_charsets, font_parse_fcname)
1269 (font_prepare_cache, font_update_drivers, Flist_fonts):
1270 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1271 * frame.c (make_frame, Fmake_terminal_frame)
1272 (x_set_frame_parameters, x_report_frame_params)
1273 (x_default_parameter, Fx_parse_geometry):
1274 * ftfont.c (syms_of_ftfont):
1275 * image.c (gif_load):
1276 * keyboard.c (command_loop_1):
1277 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1278 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1279 (Fminor_mode_key_binding, accessible_keymaps_1)
1280 (Faccessible_keymaps, Fwhere_is_internal):
1281 * lread.c (read_emacs_mule_char):
1282 * menu.c (find_and_return_menu_selection):
1283 * minibuf.c (get_minibuffer):
1284 * nsfns.m (Fns_perform_service):
1285 * nsfont.m (ns_script_to_charset):
1286 * nsmenu.m (ns_popup_dialog):
1287 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1288 (Fx_own_selection_internal):
1289 * nsterm.m (append2):
1290 * print.c (Fredirect_debugging_output)
1291 (print_prune_string_charset):
1292 * process.c (Fdelete_process, Fprocess_contact)
1293 (Fformat_network_address, set_socket_option)
1294 (read_and_dispose_of_process_output, write_queue_push)
1295 (send_process, exec_sentinel):
1296 * sound.c (Fplay_sound_internal):
1297 * textprop.c (validate_plist, add_properties)
1298 (Fput_text_property, Fadd_face_text_property)
1299 (copy_text_properties, text_property_list, syms_of_textprop):
1300 * unexaix.c (report_error):
1301 * unexcoff.c (report_error):
1302 * unexsol.c (unexec):
1303 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1304 (Fformat_mode_line, syms_of_xdisp):
1305 * xfaces.c (set_font_frame_param)
1306 (Finternal_lisp_face_attribute_values)
1307 (Finternal_merge_in_global_face, syms_of_xfaces):
1308 * xfns.c (x_default_scroll_bar_color_parameter)
1309 (x_default_font_parameter, x_create_tip_frame):
1310 * xfont.c (xfont_supported_scripts):
1311 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1312 (menu_help_callback, xmenu_show):
1313 * xml.c (make_dom):
1314 * xterm.c (set_wm_state):
1315 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1316 and similarly for list2 through list5.
1317
bafe80ce
PE
13182013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 * callproc.c (Fcall_process_region): Fix minor race and tune.
1321 (create_temp_file): New function, with the temp-file-creation part
1322 of the old Fcall_process_region. Use Fcopy_sequence to create the
1323 temp file name, rather than alloca + build_string, for simplicity.
1324 Don't bother to block input around the temp file creation;
1325 shouldn't be needed. Simplify use of mktemp. Use
1326 record_unwind_protect immediately after creating the temp file;
1327 this closes an unlikely race where the temp file was not removed.
1328 Use memcpy rather than an open-coded loop.
1329 (Fcall_process_region): Use the new function. If the input is
1330 empty, redirect from /dev/null rather than from a newly created
1331 empty temp file; this avoids unnecessary file system traffic.
1332
4700b5a5
PE
13332013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1334
5c97beae
PE
1335 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1336 Simplify by making this case like the other two. This is a bit
1337 slower on obsolete hosts, but the extra complexity isn't worth it.
1338
4700b5a5
PE
1339 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1340 * process.c (create_process) [!DOS_NT]:
1341 Remove now-unnecessary calls to emacs_close.
1342
f9a74c4c
EZ
13432013-07-13 Eli Zaretskii <eliz@gnu.org>
1344
922ae7ee
EZ
1345 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1346 returning early. (Bug#14850)
1347
f9a74c4c
EZ
1348 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1349 and inhibit-iso-escape-detection attributes of 'undecided'.
1350 (Bug#14822)
1351
5e301d76
PE
13522013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1353
69e0e5ee
PE
1354 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1355 Reported by Herbert J. Skuhra in
1356 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1357
5e301d76
PE
1358 Don't lose top specpdl entry when memory is exhausted.
1359 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1360 specpdl overflow here, to simplify callers; all callers changed.
1361 Always reserve an unused entry at the stack top; this avoids
1362 losing the top entry's information when memory is exhausted.
1363
7e649856
PE
13642013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1365
a773ed9a
PE
1366 Clean up errno reporting and fix some errno-reporting bugs.
1367 * callproc.c (Fcall_process):
1368 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1369 * process.c (create_process, Fmake_network_process):
1370 * unexaix.c (report_error):
1371 * unexcoff.c (report_error):
1372 Be more careful about reporting the errno of failed operations.
1373 The code previously reported the wrong errno sometimes.
1374 Also, prefer report_file_errno to setting errno + report_file_error.
1375 (Fcall_process): Look at openp return value rather than at path,
1376 as that's a bit faster and clearer when there's a numeric predicate.
1377 * fileio.c (report_file_errno): New function, with most of the
1378 old contents of report_file_error.
1379 (report_file_error): Use it.
1380 (Ffile_exists_p, Ffile_accessible_directory_p):
1381 Set errno to 0 when it is junk.
1382 * fileio.c (Faccess_file):
1383 * image.c (x_create_bitmap_from_file):
1384 Use faccessat rather than opening the file, to avoid the hassle of
1385 having a file descriptor open.
1386 * lisp.h (report_file_errno): New decl.
1387 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1388
7e649856
PE
1389 Minor EBADF fixes.
1390 * process.c (create_process, wait_reading_process_output) [AIX]:
1391 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1392 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1393 a multithreaded environment anyway).
1394 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1395
f6774c1a
AS
13962013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1397
1398 * image.c (x_find_image_file): Don't close a remote file handle.
1399
bacba3c2
PE
14002013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1401
1402 Fix races with threads and file descriptors.
1403 * callproc.c (Fcall_process_region):
1404 * dired.c (open_directory):
1405 * emacs.c (main, Fdaemon_initialized):
1406 * image.c (x_find_image_file):
1407 * inotify.c (Finotify_rm_watch):
1408 * lread.c (Flocate_file_internal):
1409 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1410 * term.c (term_mouse_moveto, init_tty):
1411 * termcap.c (tgetent):
1412 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1413 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1414 * unexhp9k800.c, unexmacosx.c (unexec):
1415 * callproc.c (Fcall_process_region):
1416 Use emacs_close, not close.
1417 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1418 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1419 and posix_close function on current platforms (which all lack them).
1420 (emacs_close): Use it. This should fix the races on GNU/Linux and
1421 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1422 and it should avoid closing random victim file descriptors on
1423 other platforms.
1424
653d4f43
PE
14252013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1426
c8536ec4
PE
1427 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1428 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1429 Touch up doc a bit.
1430
9c203066
PE
1431 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1432 This is for .gdbinit xbacktrace.
1433
653d4f43
PE
1434 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1435 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1436 (emacs_set_tty): Now static.
1437 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1438 * term.c (tty_capable_p, tty_default_color_capabilities)
1439 (get_tty_terminal, term_mouse_movement)
1440 (handle_one_term_event, init_tty, maybe_fatal):
1441 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1442 (tgetent, scan_file, name_match, compare_contin):
1443 * terminal.c (get_terminal):
1444 Use bool for boolean.
1445 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1446 Prefer char to unsigned char if either will do.
1447 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1448 (tty_write_glyphs): Prefer int to unsigned.
1449 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1450 All callers changed.
1451 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1452
45b683a1
PE
14532013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1454
29abe551
PE
1455 Port to C89.
1456 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1457 (B__dummy__): New dummy symbol, to pacify C89.
1458 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1459 they can't grok varargs macros.
1460 * dispnew.c (add_window_display_history)
1461 (add_frame_display_history):
1462 * print.c (print_object):
1463 * xdisp.c (debug_method_add):
1464 Use %p printf format only for void pointers.
1465 * emacs.c (usage_message): New constant, replacing ...
1466 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1467 (main): Adjust to usage reorg.
1468 * fns.c (syms_of_fns):
1469 * profiler.c (syms_of_profiler):
1470 Don't use non-constant struct initializers.
1471 * gnutls.h (gnutls_initstage_t):
1472 * lisp.h (enum Lisp_Fwd_Type):
1473 * lread.c (lisp_file_lexically_bound_p):
1474 * xsettings.c (anonymous enum):
1475 Remove trailing comma.
1476 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1477 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1478 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1479 (DEFUN): Use it.
1480 * regex.c (const_re_char): New type, to pacify strict C89.
1481 All uses of 'const re_char' replaced to use it.
1482 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1483 with glibc when strict C89. This change is imported from gnulib.
1484 All uses changed.
1485 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1486 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1487 Omit GNU_LINUX implementation, since it requires long long.
1488 * xterm.c (x_draw_underwave):
1489 Do not assume the traditional order of struct's members.
1490 (x_term_init): Rewrite to avoid the need for non-constant structure
1491 initializers.
1492
45b683a1 1493 Syntax cleanup, mostly replacing macros with functions.
763a086d 1494 This removes the need for the syntax_temp hack.
45b683a1
PE
1495 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1496 * syntax.c (SYNTAX_INLINE): New macro.
1497 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1498 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1499 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1500 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1501 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1502 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1503 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1504 Now constants, not macros.
1505 (syntax_temp) [!__GNUC__]: Remove.
1506 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1507 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1508 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1509 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1510 Move here from syntax.h; now functions, not macros. Except for the
1511 last function, these are static since only syntax.c uses them.
1512 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1513 All uses changed. Now a function, not a macro; use this fact
1514 to simplify the code.
1515 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1516 compiler bugs; no longer relevant.
1517 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1518 (SYNTAX_INLINE): New macro.
1519 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1520 for the new functions. Use bool for boolean member.
1521 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1522 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1523 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1524 (SETUP_BUFFER_SYNTAX_TABLE):
1525 Now extern inline functions, not macros.
1526 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1527 Remove; all uses replaced by implementation.
1528 (syntax_temp) [!__GNUC__]: Remove decl.
1529 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1530
29be4a50
JD
15312013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1532
1533 * emacs.c (main): Fix syntax error.
1534
954b166e
PE
15352013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1536
1537 Timestamp fixes for undo (Bug#14824).
1538 * atimer.c (schedule_atimer):
1539 * fileio.c (Ffile_newer_than_file_p):
1540 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1541 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1542 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1543 (syms_of_fileio): Remove Sclear_visited_file_name.
1544 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1545 file doesn't exist; this avoids an ambiguity with negative timestamps.
1546 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1547 * systime.h (make_emacs_time, invalid_emacs_time):
1548 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1549 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1550 * undo.c (record_first_change): Push (visited-file-modtime) onto
1551 undo list rather than reimplementing it by hand, incorrectly.
1552
d74647c3
KB
15532013-07-09 Ken Brown <kbrown@cornell.edu>
1554
1555 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1556
3c51b96b
JB
15572013-07-09 Juanma Barranquero <lekktu@gmail.com>
1558
1559 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1560
4ebbdd67
PE
15612013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 Handle errno and exit status a bit more carefully.
1564 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1565 number into an exit status. Instead, use EXIT_CANCELED.
1566 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1567 * callproc.c (relocate_fd):
1568 * emacs.c (close_output_streams, main):
1569 * process.c (create_process):
1570 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1571 Use emacs_perror for simplicity.
1572 * callproc.c (relocate_fd, main):
1573 * sysdep.c (sys_subshell):
1574 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1575 (shut_down_emacs): Use emacs_write, not write.
1576 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1577 * fileio.c (Fcopy_file, e_write):
1578 * nsterm.m (ns_select):
1579 * process.c (send_process):
1580 * sound.c (vox_write):
1581 Use emacs_write_sig, not emacs_write.
1582 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1583 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1584 New constants.
1585 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1586 of write.
1587 (emacs_full_write): New function.
1588 (emacs_write): Rewrite to use it.
1589 (emacswrite_sig, emacs_perror): New functions.
1590 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1591
44e18199 15922013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1593
1594 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1595 on NS even if it is present. Pixmap on NS is a void*.
1596
9caab067
PE
15972013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1598
1599 Port to Ubuntu 10 (Bug#14803).
1600 Problem reported by T.V. Raman.
1601 * process.c (close_on_exec, accept4, process_socket):
1602 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1603
1d442672
EZ
16042013-07-07 Eli Zaretskii <eliz@gnu.org>
1605
1606 * w32.c (sys_dup): Declare prototype.
1607
1608 * filelock.c:
1609 * emacs.c:
1610 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1611
067428c1
PE
16122013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1613
1614 Make file descriptors close-on-exec when possible (Bug#14803).
1615 This simplifies Emacs a bit, since it no longer needs to worry
1616 about closing file descriptors by hand in some cases.
1617 It also fixes some unlikely races. Not all such races, as
1618 libraries often open files internally without setting
1619 close-on-exec, but it's an improvement.
1620 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1621 * callproc.c (Fcall_process) [!MSDOS]:
1622 * emacs.c (main) [!DOS_NT]:
1623 * nsterm.m (ns_term_init):
1624 * process.c (create_process):
1625 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1626 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1627 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1628 Prefer mkostemp with O_CLOEXEC to mkstemp.
1629 * callproc.c (relocate_fd) [!WINDOWSNT]:
1630 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1631 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1632 now using pipe2.
1633 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1634 Make the resulting file descriptor close-on-exec.
1635 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1636 * lread.c (load_descriptor_list, load_descriptor_unwind):
1637 Remove; no longer needed. All uses removed.
1638 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1639 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1640 New functions.
1641 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1642 (Fmake_network_process, Fnetwork_interface_list):
1643 (Fnetwork_interface_info, server_accept_connection):
1644 Make newly-created socket close-on-exec.
1645 * sysdep.c (emacs_open, emacs_fopen):
1646 Make new-created descriptor close-on-exec.
1647 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1648 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1649
0da857dd
JD
16502013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1651
1652 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1653 for NS_IMPL_GNUSTEP.
1654
5f86adcd
PE
16552013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 Fix openp errno handling.
1658 * callproc.c (Fcall_process): Preserve openp errno around close.
1659 * lread.c (openp): Set errno when returning -1, as some callers
1660 expect this.
1661
1afb1d07
JD
16622013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1663
1664 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1665
1666 * nsterm.h (NSSavePanel): Update comment.
1667 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1668 (ns_run_file_dialog): Declare.
1669
1670 * nsfns.m: Remove panelOK.
1671 (ns_fd_data): New.
1672 (ns_run_file_dialog): New function.
1673 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1674 event loop, so file dialog is popped up by ns_run_file_dialog, called
1675 by sendEvent (Bug#14578).
1676 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1677
3323c263
EZ
16782013-07-06 Eli Zaretskii <eliz@gnu.org>
1679
fdda0220
EZ
1680 * xdisp.c (default_line_pixel_height): New function.
1681 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1682 (try_cursor_movement, redisplay_window, try_window)
1683 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1684
1685 * window.c (window_scroll_pixel_based): use
1686 default_line_pixel_height.
1687
1688 * dispextern.h (default_line_pixel_height): Add prototype.
1689
1690 * frame.c (x_set_line_spacing): Accept a float value for
1691 line-spacing parameter, per the documentation.
1692
3323c263
EZ
1693 * data.c (Fmultibyte_string_p): Doc fix.
1694
47ba6d43
PE
16952013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1696
406af475
PE
1697 Use emacs_open more consistently when opening files.
1698 This handles EINTR more consistently now, and makes it easier
1699 to introduce other uniform changes to file descriptor handling.
1700 * src/systdio.h: New file.
1701 * src/buffer.c (mmap_init):
1702 * cygw32.c (chdir_to_default_directory):
1703 * dispnew.c (Fopen_termscript):
1704 * emacs.c (Fdaemon_initialized):
1705 * fileio.c (Fdo_auto_save):
1706 * image.c (slurp_file, png_load_body, jpeg_load_body):
1707 * keyboard.c (Fopen_dribble_file):
1708 * lread.c (Fload):
1709 * print.c (Fredirect_debugging_output):
1710 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1711 * termcap.c (tgetent):
1712 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1713 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1714 * w32term.c (w32_initialize) [CYGWIN]:
1715 * xfaces.c (Fx_load_color_file):
1716 Use emacs_open instead of plain open, and emacs_fopen instead of
1717 plain fopen.
1718 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1719 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1720 * callproc.c (default_output_mode): New constant.
1721 (Fcall_process): Use it to call emacs_open instead of plain creat.
1722 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1723 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1724 (emacs_fopen): New function.
1725 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1726 Include <lisp.h>, for emacs_open.
1727 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1728
47ba6d43
PE
1729 Remove duplicate #include directives.
1730 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1731 * xfaces.c:
1732 Don't include stdio.h twice.
1733 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1734 Don't include sys/types.h or stdio.h twice.
1735 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1736 * lread.c: Don't include coding.h twice.
1737 * nsfont.m: Don't include frame.h twice.
1738 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1739 * ralloc.c: Don't include <unistd.h> twice.
1740 * xdisp.c: Don't include font.h twice.
1741 * xterm.c: Don't include fontset.h twice.
1742 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1743
b9ed53d5
PE
17442013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 Scale ImageMagick images more carefully.
1747 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1748 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1749 Be more careful about avoiding undefined behavior after
1750 integer overflow and division by zero.
1751
cf13177e
YM
17522013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1753
1754 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1755 (syms_of_w32fns): DEFSYM them.
1756 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1757 (CCHDEVICENAME): Define macros if not defined.
1758 (struct MONITOR_INFO_EX): New struct.
1759 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1760 (enum_display_monitors_fn): New variable.
1761 (globals_of_w32fns): Initialize it.
1762 (Fx_display_pixel_width, Fx_display_pixel_height)
1763 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1764 multi-monitor setups in docstrings.
1765 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1766 screen size by primary monitor's millimeter per pixel.
1767 (w32_monitor_enum, w32_display_monitor_attributes_list)
1768 (w32_display_monitor_attributes_list_fallback)
1769 (Fw32_display_monitor_attributes_list): New functions.
1770 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1771
1772 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1773 if not defined.
1774 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1775
86dfb7a8
MA
17762013-07-04 Michael Albinus <michael.albinus@gmx.de>
1777
1778 * fileio.c (Qfile_notify_error): New error symbol.
1779
1780 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1781 * inotify.c (inotify_callback, symbol_to_inotifymask)
1782 (Finotify_add_watch, Finotify_rm_watch): Use it.
1783 (inotifyevent_to_event): Exchange order of cookie and file name.
1784 (Finotify_add_watch): Adapt docstring.
1785
1786 * lisp.h (Qfile_notify_error): Declare.
1787
2c1c974b
PE
17882013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1791 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1792 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1793 which did not work (see <http://bugs.gnu.org/14569#307>).
1794 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1795 && (!noninteractive || initialized)). This attempts to thread
1796 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1797
7a35b20f
JB
17982013-07-04 Juanma Barranquero <lekktu@gmail.com>
1799
1800 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1801 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1802
1ce5cd04
PE
18032013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1804
1805 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1806 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1807 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1808 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1809
57f8c490
PE
18102013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1813 Define to __sys_siglist.
1814
bcffb5ca
EZ
18152013-07-02 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1818 word-wrap, so that overflow-newline-into-fringe would work in
1819 visual-line-mode. (Bug#2749)
1820 (move_it_in_display_line_to): When the last scanned display
1821 element fits exactly on the display line, and
1822 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1823 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1824 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1825 finding buffer position that corresponds to pixel coordinates,
1826 e.g. in buffer_posn_from_coords.
1827
2c41e781
JD
18282013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1829
1830 * process.c (handle_child_signal): Call catch_child_signal if
1831 NS_IMPL_GNUSTEP.
1832
c2418359
PE
18332013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1834
52a9bcae
PE
1835 Don't convert function pointers to void * and back.
1836 It isn't portable C, and it's easy enough to avoid.
1837 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1838 (make_save_value): Add support for SAVE_FUNCPOINTER.
1839 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1840 * print.c (print_object):
1841 Distinguish function from object pointers.
1842 * lisp.h (SAVE_FUNCPOINTER): New constant.
1843 (SAVE_SLOT_BITS): Adjust to it.
1844 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1845 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1846 (voidfuncptr): New typedef.
1847 (struct Lisp_Save_Value): New member data[0].funcpointer.
1848 (XSAVE_FUNCPOINTER): New function.
1849
c2418359
PE
1850 Simplify buildobj processing.
1851 * Makefile.in (buildobj.h): Make it a sequence of strings each
1852 followed by comma, rather than a single string. Put it into a
1853 .tmp file in case there's an error while generating it.
1854 (gl-stamp): Use .tmp for temp files.
1855 (mostlyclean): Clean .tmp files.
1856 * doc.c (buildobj): Move to just the routine that needs it.
1857 It's now an array of strings, so processing is simpler.
1858
8f43ce49
PE
18592013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1862 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1863 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1864 Invoke malloc_enable_thread even when not interactive.
1865 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1866 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1867 in this case, since the underlying bug has now been fixed.
1868
24827db9
JB
18692013-07-01 Juanma Barranquero <lekktu@gmail.com>
1870
1871 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1872 unlinking it (bug#14691).
1873
ef099a94
MN
18742013-06-30 Michal Nazarewicz <mina86@mina86.com>
1875
1876 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1877 before checking whether buffer is modified. This lets
1878 `kill-buffer-query-functions' cancel killing of the buffer or save
1879 its content before `kill-buffer' asks user the "Buffer %s
1880 modified; kill anyway?" question.
1881
9d3f2fc2
JD
18822013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1883
1884 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1885 Let the super performKeyEquivalent deal with them (Bug#14747).
1886
e6c6c8c7
PE
18872013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1888
1d71c1d9
PE
1889 * widget.c (resize_cb): Remove unused local.
1890
8f5f35cc
PE
1891 Do not use GTK 3 if it exists but cannot be compiled.
1892 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1893 * xterm.c (x_error_handler) [!USE_GTK]:
1894 Do not use GTK 3.
1895
e6c6c8c7
PE
1896 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1897
0ba54312
EZ
18982013-06-30 Eli Zaretskii <eliz@gnu.org>
1899
5d1c3286
EZ
1900 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1901 to the valid range of values. (Bug#14753)
1902
0ba54312
EZ
1903 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1904 when moving point by using the current glyph matrix. This avoids
1905 the need to force redisplay when this function is called in a
1906 loop.
1907
9c90cc06
PE
19082013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 Fix minor problems found by static checking.
1911 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1912 Redo the latter's body to sidestep GCC parenthesization warnings.
1913 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1914 * coding.c (detect_coding, detect_coding_system):
1915 * coding.h (struct undecided_spec):
1916 Use bool for boolean.
1917 * image.c (QCmax_width, QCmax_height): Now static.
1918 * xdisp.c (Fmove_point_visually): Remove unused local.
1919
4c672a0f
EZ
19202013-06-29 Eli Zaretskii <eliz@gnu.org>
1921
1922 * xdisp.c (Fmove_point_visually): New function.
1923
c1ea3abf
JB
19242013-06-28 Kenichi Handa <handa@gnu.org>
1925
1926 * coding.h (define_coding_undecided_arg_index): New enum.
1927 (coding_attr_index): New members
1928 coding_attr_undecided_inhibit_null_byte_detection,
1929 coding_attr_undecided_inhibit_iso_escape_detection,
1930 coding_attr_undecided_prefer_utf_8.
1931 (undecided_spec): New struct.
1932 (struct coding_system): New member `undecided' of the member
1933 `spec'.
1934
1935 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1936 (detect_coding): Likewise.
1937 (detect_coding_system): Likewise.
1938 (Fdefine_coding_system_internal): New coding system properties
1939 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1940 :prefer-utf-8.
1941 (syms_of_coding): Adjust for coding_arg_undecided_max.
1942
ba3de9e6
PE
19432013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 * image.c (x_from_xcolors): Remove unused local.
1946
547c9269
YM
19472013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1948
1949 Defer image data transfer between X client and server until actual
1950 display happens.
1951
1952 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1953 and `mask_img'.
1954
1955 * image.c (Destroy_Image): Remove.
1956 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1957 `mask_p', and `colors_p'. All uses changed.
1958 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1959 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1960 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1961 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1962 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1963 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1964 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1965 (image_get_x_image, image_unget_x_image): New functions or macros.
1966 (image_background, image_background_transparent, x_to_xcolors)
1967 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1968 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1969 instead of Destroy_Image.
1970 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1971 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1972 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1973 (imagemagick_load_image, svg_load_image): Use them instead of
1974 x_create_x_image_and_pixmap, and x_put_x_image followed by
1975 x_destroy_x_image, respectively.
1976 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1977 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1978 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1979 background_transparent fields.
1980 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1981 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1982
dae2f5ef
PE
19832013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1986 This mostly consists of undoing recent changes.
1987 * callproc.c (Fcall_process):
1988 * process.c (create_process):
1989 Do not worry about catching SIGCHLD here, undoing previous change.
1990 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1991 * process.c, process.h (catch_child_signal):
1992 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1993 * process.c (catch_child_handler): Don't worry about being called
1994 lazily and do not assume caller has blocked SIGCHLD, undoing
1995 previous change. Move first-time stuff back to
1996 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1997 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1998 set lib_child_handler if it's already initialized, which may
1999 help avoid problems on GNUStep.
2000
fa55d2aa
PE
20012013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2004 * callproc.c (Fcall_process):
2005 * process.c (create_process):
2006 Make sure SIGCHLD is caught before we fork,
2007 since Emacs startup no arranges to catch SIGCHLD.
2008 * process.c (lib_child_handler): Initialize to null, not to
2009 dummy_handler.
2010 (catch_child_signal): Allow self to be called lazily.
2011 Do nothing if it's already been called.
2012 Assume caller has blocked SIGCHLD (all callers do now).
2013 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2014 just before it's really needed.
2015 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2016 since it hasn't been caught yet.
2017
f3f9606c
LMI
20182013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2019
2020 * image.c (compute_image_size): New function to implement
2021 :max-width and :max-height.
2022 (imagemagick_load_image): Use it.
2023
c7041908
PE
20242013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2027 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2028 Now extern.
2029 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2030 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2031 the SIGCHLD handler, since the code is not atomic and (due to glib)
2032 signals may be arriving now.
2033 * sysdep.c (init_signals): Do not catch child signals here;
2034 'main' now does that later, at a safer time.
2035
f86852b4
PE
20362013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2037
0dfeed58
PE
2038 Clean up SIGCHLD handling a bit (Bug#14569).
2039 * process.c, process.h (catch_child_signal):
2040 Now always extern, even if !NS_IMPL_GNUSTEP.
2041 * process.c (catch_child_signal): Move glib tickler here from
2042 init_process_emacs, so that it's done earlier in Emacs
2043 initialization. Also move the noninteractive && !initialized
2044 check here from init_process_emacs. This is all a bit cleaner for
2045 GNUish platforms, and I hope it works around the Cygwin bug.
2046 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2047 that glib signal handling is tickled before glib creates threads.
2048
f86852b4
PE
2049 * process.c (wait_reading_process_output): Avoid int overflow
2050 when reading more than 2 GiB total from a process.
2051
cbd6509c
PE
20522013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 * process.c (create_process): Handle a couple more cases,
2055 i.e., work even if new_argv and wait_child_setup[i] are cached.
2056 Use Fcall_process's style for volatile vars.
2057
9de1114a
AS
20582013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2059
2060 * process.c (create_process): Mark PROCESS volatile.
2061
fbe9e0b9
PE
20622013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2063
2064 Use C99-style flexible array members if available.
2065 This avoids some subtle aliasing issues, which typically
2066 aren't a problem with GCC but may be a problem elsewhere.
2067 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2068 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2069 In either case, it uses a flexible array member rather than
2070 the old struct hack. All uses changed.
2071 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2072 Adjust to sdata reorganization.
2073 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2074 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2075 that ports better to pre-C99 non-GCC.
2076 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2077 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2078 as the latter has changed.
2079 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2080 and port better to pre-C99 GCC.
2081 * image.c (struct xpm_cached_color):
2082 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2083 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2084 Use FLEXIBLE_ARRAY_MEMBER.
2085 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2086 Move decl to top level so it gets checked against implementation.
2087 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2088 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2089
1fc71008
PE
20902013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2091
2092 * syntax.c: Integer cleanups.
2093 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2094 All uses that need 0-or-2 changed to:
2095 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2096 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2097 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2098 (char_quoted, prev_char_comend_first, back_comment)
2099 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2100 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2101 Use bool for boolean.
2102 (update_syntax_table, skip_chars, skip_syntaxes):
2103 Prefer int to unsigned when either will do.
2104 (back_comment): Return boolean success flag, like forw_comment,
2105 instead of positive-or-minus-1 (which might have overflowed int anyway).
2106 Don't stuff ptrdiff_t into int.
2107 (syntax_spec_code, syntax_code_spec): Now const.
2108 (Fmatching_paren, scan_lists, scan_sexps_forward):
2109 Use enum syntaxcode for syntax code.
2110 (Fmatching_paren): Check that arg is a character, not just an integer.
2111 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2112 (Finternal_describe_syntax_value): Omit no-longer-needed
2113 comparison to 0.
2114 (skip_chars): Use char, not unsigned char, when the distinction
2115 doesn't matter.
2116 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2117 * bytecode.c (exec_byte_code):
2118 * syntax.c (syntax_spec_code, Fchar_syntax)
2119 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2120 (init_syntax_once):
2121 * syntax.h (SYNTAX_WITH_FLAGS):
2122 Omit unnecessary casts.
2123
b932cad7
EZ
21242013-06-20 Eli Zaretskii <eliz@gnu.org>
2125
2126 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2127 line dimensions here, to avoid race conditions with the main
2128 thread. (Bug#14062, bug#14630, bug#14669)
2129
2130 * w32term.c (w32_draw_window_cursor): Compute the header line and
2131 mode line dimensions here.
2132 <w32_system_caret_window, w32_system_caret_hdr_height>:
2133 <w32_system_caret_mode_height>: New variables.
2134
2135 * w32term.h: Declare them.
2136
89561f72
PE
21372013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2138
5013fc08
PE
2139 * alloc.c (die): Move "assertion failed" string here ...
2140 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2141 COND when SUPPRESS_CHECKING. This shrinks the executable text
2142 size by 0.8% to 2.2% when configured with --enable-checking,
2143 depending on optimization flags (GCC 4.8.1 x86-64).
2144
89561f72
PE
2145 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2146
763a086d 21472013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2148
2149 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2150 base is 2; this is more accurate.
2151
983aeb9a
JB
21522013-06-19 Juanma Barranquero <lekktu@gmail.com>
2153
2154 * sound.c (string_default): Move to !WINDOWSNT section.
2155 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2156
178ba3e6
PE
21572013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2158
bbc51b15
PE
2159 * sound.c: Integer cleanups.
2160 Remove unnecessary forward decls.
2161 (struct sound_device): The 'file' member is now a Lisp_Object, not
2162 a char *, so that we needn't invoke alloca on a huge size.
2163 (Fplay_sound_internal): Adjust to this.
2164 (string_default): New function.
2165 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2166 Use it to adjust to the struct sound_device change.
2167 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2168 (be2hs) [0]: Remove.
2169
178ba3e6
PE
2170 * syntax.c (skip_chars): Don't use uninitialized storage
2171 when searching a multibyte buffer for characters that are not in a
2172 unibyte string that contains non-ASCII characters.
2173
69f60cdc
JD
21742013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2175
2176 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2177 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2178
0d6224d4
PE
21792013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2182
3c542890
KH
21832013-06-18 Kenichi Handa <handa@gnu.org>
2184
f7e3f7cd
KH
2185 * font.c (Ffont_spec): Signal an error for an invalid font name
2186 (Bug#14648).
3c542890 2187
9349e5f7
PE
21882013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2191 In particular this ports to 32-bit sparc Sun cc.
2192 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2193 array with a dummy element at specpdl[-1], so that its address can
2194 be taken portably.
2195 (unbind_to): Do not copy the binding; not needed, now that we
2196 copy old_value in the one place where the copy is needed.
2197 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2198 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2199 (union specbinding): Rename from struct specbinding. Redo layout
2200 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2201 which is not portable. With Sun C 5.12 32-bit sparc, the
2202 declaration causes nargs to be an unsigned bitfield, a behavior
2203 that the C standard allows; but Emacs wants nargs to be signed.
2204 The overall type is now a union of structures rather than a
2205 structure of union of structures, and the 'kind' member is now a
2206 bitfield, so that the overall type doesn't grow. All uses changed.
2207 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2208
0a4df6a5
PE
22092013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2210
ec6ecaad
PE
2211 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2212 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2213
0a4df6a5
PE
2214 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2215
7bfe8dbc
EZ
22162013-06-17 Eli Zaretskii <eliz@gnu.org>
2217
2218 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2219 unless we know that the window w's frame is a frame object.
2220 Another attempt at solving bug#14062 and bug#14630.
2221
708e05f6
LMI
22222013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2223
2224 * textprop.c (property_set_type): New enum.
2225 (add_properties): Allow appending/prepending text properties.
2226 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2227 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2228 add_text_properties_1.
2229 (Fadd_face_text_property): New function that calls
2230 add_text_properties_1.
2231
84575e67
PE
22322013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2233
2234 Move functions from lisp.h to individual modules when possible.
2235 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2236 * alloc.c (XFLOAT_INIT, set_symbol_name):
2237 * buffer.c (CHECK_OVERLAY):
2238 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2239 (set_char_table_parent):
2240 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2241 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2242 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2243 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2244 (set_blv_valcell):
2245 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2246 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2247 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2248 (backtrace_args, backtrace_debug_on_exit):
2249 * floatfns.c (CHECK_FLOAT):
2250 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2251 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2252 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2253 (set_hash_index_slot):
2254 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2255 * marker.c (CHECK_MARKER):
2256 * textprop.c (CHECK_STRING_OR_BUFFER):
2257 * window.c (CHECK_WINDOW_CONFIGURATION):
2258 Move here from lisp.h, and make these functions static rather than
2259 extern inline.
2260 * buffer.c (Qoverlayp):
2261 * data.c (Qsubrp):
2262 * fns.c (Qhash_table_p):
2263 * window.c (Qwindow_configuration_p):
2264 Now static.
2265 * lisp.h: Remove the abovementioned defns and decls.
2266
44e18199 2267 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2268 In lisp.h, prefer functions to function-like macros, and
2269 constants to object-like macros, when either will do. This:
2270 . simplifies use, as there's no more need to worry about
2271 arguments' side effects being evaluated multiple times.
2272 . makes the code easier to debug on some platforms.
2273 However, when using gcc -O0, keep using function-like macros
2274 for a few critical operations, for performance reasons.
2275 This sort of thing isn't needed with gcc -Og, but -Og
2276 is a GCC 4.8 feature and isn't widely-enough available yet.
2277 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2278 Remove enum lsb_bits; no longer needed.
2279 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2280 * buffer.c (Qoverlap):
2281 * data.c (Qsubrp):
2282 * fns.c (Qhash_table_p):
2283 Now extern, so lisp.h can use these symbols.
2284 * dispextern.h: Include character.h, for MAX_CHAR etc.
2285 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2286 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2287 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2288 (GLYPH_CODE_P): Move here from lisp.h.
2289 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2290 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2291 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2292 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2293 XUNTAG now returns void *.
2294 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2295 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2296 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2297 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2298 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2299 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2300 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2301 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2302 New macros, renamed from their sans-lisp_h_ counterparts.
2303 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2304 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2305 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2306 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2307 If compiling via GCC without optimization, define these as macros
2308 in addition to inline functions.
2309 To disable this, compile with -DINLINING=0.
2310 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2311 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2312 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2313 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2314 (INTMASK, VALMASK): Now macros, since static values cannot be
2315 accessed from extern inline functions.
2316 (VALMASK): Also a constant, for benefit of old GDB.
2317 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2318 is INTEGERP, which can fold it in.
5165d44a 2319 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2320 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2321 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2322 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2323 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2324 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2325 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2326 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2327 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2328 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2329 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2330 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2331 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2332 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2333 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2334 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2335 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2336 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2337 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2338 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2339 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2340 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2341 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2342 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2343 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2344 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2345 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2346 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2347 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2348 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2349 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2350 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2351 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2352 Now functions.
2353 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2354 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2355 (VALMASK): Define in one place rather than in two, merging the
2356 USE_LSB_TAG parts; this is simpler.
2357 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2358 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2359 Move up, to avoid use before definition.
2360 Also include "globals.h" earlier, for the same reason.
2361 (make_natnum): New function.
2362 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2363 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2364 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2365 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2366 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2367 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2368 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2369 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2370 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2371 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2372 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2373 (Qwindow_configuration_p, Qimage): New forward declarations.
2374 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2375 (STRING_COPYIN): Remove; unused.
2376 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2377 (xcar_addr, xcdr_addr): New functions. All uses changed.
2378 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2379 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2380 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2381 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2382 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2383 (TYPE_RANGED_INTEGERP): Simplify.
2384 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2385 (setlocale, fixup_locale, synchronize_system_messages_locale)
2386 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2387 Now empty functions, not macros.
2388 (functionp): Return bool, not int.
2389 * window.c (Qwindow_configuration_p): Now extern,
2390 so window.h can use it.
2391 * window.h (Qwindowp): Move decl back to lisp.h.
2392
9583ec36
EZ
23932013-06-15 Eli Zaretskii <eliz@gnu.org>
2394
2395 * xdisp.c (Fline_pixel_height): New function, required for solving
2396 bug #14567.
2397
210272ce
PE
23982013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2401
de0503df
SM
24022013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2403
2404 * lread.c (syms_of_lread):
2405 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2406
afbfe143
KD
24072013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2408
2409 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2410
d177e213
XF
24112013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2412
2413 * fileio.c (expand_file_name): Doc fix.
2414
05e3e412
PE
24152013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2416
f7394b12
PE
2417 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2418 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2419 Wait for self, not for 0. This can't hurt on GNU or similar
2420 system, and may help with Cygwin.
2421
05e3e412
PE
2422 * keyboard.c: Don't use PROP (...) as an lvalue.
2423 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2424 Use set_prop (A, B), not PROP (A) = B.
2425
17dd3097
EZ
24262013-06-10 Eli Zaretskii <eliz@gnu.org>
2427
2428 * xdisp.c (get_it_property): Use it->window instead of generating
2429 a Lisp object from it->w.
2430
52fab9c9
EZ
24312013-06-09 Eli Zaretskii <eliz@gnu.org>
2432
2433 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2434 get-char-property the window that is being rendered, instead of
2435 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2436 (compute_display_string_pos): When W is NULL, use the current
2437 buffer as the object to pass to get-char-property.
2438 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2439 pointer member of the bidi iterator, since no window is pertinent
2440 to this function.
52fab9c9 2441
5bf97bfc
EZ
24422013-06-08 Eli Zaretskii <eliz@gnu.org>
2443
2444 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2445 being displayed, and pass it to compute_display_string_pos.
2446 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2447 (bidi_paragraph_init): All callers changed.
2448
2449 * xdisp.c (init_from_display_pos, init_iterator)
2450 (handle_single_display_spec, next_overlay_string)
2451 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2452 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2453 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2454 (compute_display_string_pos): Accept additional argument, the
2455 window being displayed, and pass it to Fget_char_property.
2456 (Bug#14575)
2457
2458 * dispextern.h (struct bidi_it): New member w, the window being
2459 displayed.
2460 (compute_display_string_pos): Adjust prototype.
2461
5de0e011
JD
24622013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2463
e7b41c4c 2464 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2465
2466 * process.c (wait_reading_process_output): Check for NS before GLIB.
2467 GLIB may be linked in due to rsvg, but ns_select must be called.
2468
5de0e011
JD
2469 * xgselect.c (xg_select): Remove call to window_system_available
2470 and g_main_context_pending at the top, so Gdk events (i.e. file
2471 notify) are processed when Emacs is started with -nw.
2472
a822acff
EZ
24732013-06-07 Eli Zaretskii <eliz@gnu.org>
2474
2475 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2476 (ctagsfiles3): New variable, includes only *.m files.
2477 (TAGS): Use an explicit language name in the regular expressions,
2478 to avoid transformation of '/SOMETHING' by MSYS to
2479 'c:\MSYS\SOMETHING'.
2480
6c0a9ed1
RC
24812013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2482
2483 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2484
9ef6111b
EZ
24852013-06-06 Eli Zaretskii <eliz@gnu.org>
2486
2487 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2488 still need to set the mouse pointer shape and activate help-echo.
2489 (Bug#14558)
2490
7d300d64
PE
24912013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2492
2493 A few porting etc. fixes for the new file monitor code.
2494 See the thread containing
2495 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2496 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2497 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2498 (dir_monitor_callback, Fgfile_rm_watch):
2499 Use assq_no_quit instead of Fassoc, for speed.
2500 (dir_monitor_callback, Fgfile_rm_watch):
2501 eassert that the monitor is a fixnum.
2502 (dir_monitor_callback): No need for CDR_SAFE.
2503 Simplify building of lisp with alternative tails.
2504 (Fgfile_add_watch, Fgfile_rm_watch):
2505 Do not assume glib functions set errno reliably on failure.
2506 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2507 and signal an error otherwise.
2508 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2509 Use Fdelq instead of Fdelete, for speed.
2510
817ebfcf
EZ
25112013-06-05 Eli Zaretskii <eliz@gnu.org>
2512
2513 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2514 don't insist on being invoked on a highlighted tool-bar button.
2515 Avoids losing tool-bar functionality when mouse-highlight is nil.
2516 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2517 Don't highlight when mouse-highlight is nil.
2518 (note_mouse_highlight): When mouse-highlight is nil, don't return
2519 right away; instead, run tool-bar and mode-line highlight
2520 subroutine, clear any existing highlight, and revert the mouse
2521 pointer to its default shape. (Bug#14558)
2522
55577e7c
SM
25232013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2524
2525 * lisp.mk (lisp): Add prog-mode.el.
2526
f019a684
PE
25272013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2530 * process.c (dummy_handler): New function.
2531 (lib_child_handler): New static var.
2532 (handle_child_signal): Invoke it.
2533 (catch_child_signal): If a library has set up a signal handler,
2534 save it into lib_child_handler.
2535 (init_process_emacs): If using glib and not on Windows, tickle glib's
2536 child-handling code so that it initializes its private SIGCHLD handler.
2537 * syssignal.h (SA_SIGINFO): Default to 0.
2538 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2539 31; it should no longer be needed now.
2540
90db8702
MA
25412013-06-05 Michael Albinus <michael.albinus@gmx.de>
2542
2543 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2544
2545 * gfilenotify.c (globals_of_gfilenotify): New function.
2546 (syms_of_gfilenotify): Move global initialization there.
2547
2548 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2549
bfa3acd6
SM
25502013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2551
2552 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2553 * keyboard.c (menu_bar_items, tool_bar_items):
2554 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2555 not override local keymaps any more.
2556
ba59bd80
EZ
25572013-06-04 Eli Zaretskii <eliz@gnu.org>
2558
2559 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2560
7f203aa1
EZ
25612013-06-03 Eli Zaretskii <eliz@gnu.org>
2562
9337e206
EZ
2563 * w32console.c (initialize_w32_display): Return the dimensions of
2564 the console window via 2 additional arguments, not via the current
2565 frame. This avoids crashes due to overrunning the bounds of
2566 frame's decode_mode_spec_buffer, which is not resized following
2567 the change of the frame dimensions from the initial 10x10.
2568
2569 * w32term.h (w32_initialize_display_info): Adjust prototype.
2570
2571 * term.c (init_tty): Take dimensions of the frame from the values
2572 returned by initialize_w32_display.
2573
7f203aa1
EZ
2574 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2575 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2576 (LIBES): Add $(GFILENOTIFY_LIBS).
2577
2578 * w32inevt.c (handle_file_notifications): Add dummy implementation
2579 for !HAVE_W32NOTIFY.
2580
2581 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2582
55a87246
JD
25832013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2584
2585 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2586
2587 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2588
2589 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2590
3d5ee10a
PE
25912013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 Fix minor problems found by static checking.
2594 * data.c (pure_write_error):
2595 Use xsignal2, not Fsignal, as Fsignal might return.
2596 * eval.c (set_backtrace_debug_on_exit): Now static.
2597 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2598 No longer inline. EXTERN_INLINE is needed only for functions
2599 defined in .h files. Reindent function header as per GNU style.
2600 (backtrace_p, backtrace_top, backtrace_next):
2601 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2602 compiler or linker. Add extern decls to pacify gcc -Wall.
2603 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2604 Now static.
2605 * frame.c (free_monitors): Define only on platforms that need it.
2606 * nsterm.m (ns_term_init):
2607 * process.c (catch_child_signal):
2608 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2609 defined on all porting targets these days.
2610 * process.c, process.h (catch_child_signal):
2611 Make it extern only if NS_IMPL_GNUSTEP is defined.
2612
e2d8a6f0
EZ
26132013-06-03 Eli Zaretskii <eliz@gnu.org>
2614
2615 * w32.c (gettimeofday): Make the signature identical to prototype
2616 in nt/inc/sys/time.h.
2617
a8a7c5f6
SM
26182013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2619
2620 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2621 .gdbinit.
2622
2623 * keyboard.c (safe_run_hooks_error): Improve error message.
2624
2625 * data.c (pure_write_error): Add `object' argument.
2626 * puresize.h (CHECK_IMPURE): Use it.
2627
c9628c79
MA
26282013-06-03 Michael Albinus <michael.albinus@gmx.de>
2629
2630 * Makefile.in (NOTIFY_OBJ): New variable.
2631 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2632
2633 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2634 Call syms_of_gfilenotify.
2635
2636 * gfilenotify.c: New file.
2637
2638 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2639 and Qfile_w32notify.
2640 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2641 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2642
2643 * lisp.h: Declare syms_of_gfilenotify.
2644
2645 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2646
2f592f95
SM
26472013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2648
2649 Merge the specpdl and backtrace stacks. Make the structure of the
2650 specpdl entries more obvious via a tagged union of structs.
2651 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2652 (enum specbind_tag): New enum.
2653 (struct specbinding): Make it a tagged union of structs.
2654 Add a case for backtrace records.
2655 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2656 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2657 (backtrace_debug_on_exit): New accessors.
2658 (struct backtrace): Remove.
2659 (struct catchtag): Remove backlist field.
2660 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2661 Move to eval.c.
2662 (Flocal_variable_p): Speed up the common case where the binding is
2663 already loaded.
2664 * eval.c (backtrace_list): Remove.
2665 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2666 (set_backtrace_args, set_backtrace_nargs)
2667 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2668 (backtrace_next): New functions.
2669 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2670 (unwind_to_catch, internal_lisp_condition_case)
2671 (internal_condition_case, internal_condition_case_1)
2672 (internal_condition_case_2, internal_condition_case_n): Don't bother
2673 with backtrace_list any more.
2674 (Fsignal): Adjust to new backtrace format.
2675 (grow_specpdl): Move up.
2676 (record_in_backtrace): New function.
2677 (eval_sub, Ffuncall): Use it.
2678 (apply_lambda): Adjust to new backtrace format.
2679 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2680 data.c.
2681 (specbind): Adjust to new specpdl format. Simplify.
2682 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2683 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2684 backtrace format.
2685 (mark_backtrace): Remove.
2686 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2687 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2688 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2689 Use mark_specpdl.
2690 * profiler.c (record_backtrace): Use get_backtrace.
2691 (handle_profiler_signal): Use backtrace_top_function.
2692 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2693 accessor functions.
2694
c0342369
JD
26952013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2696
2697 * process.h (catch_child_signal): Declare.
2698
2699 * process.c (catch_child_signal): New function.
2700 (init_process_emacs): Call it.
2701
2702 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2703 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2704 NS_IMPL_COCOA.
2705 (x_set_cursor_type): Remove declaration.
2706 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2707 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2708 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2709 (ns_get_color): Use F suffix on float.
2710 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2711 (ns_get_rgb_color): Remove.
2712 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2713 (note_mouse_movement): x and y are CGFloat.
2714 (ns_draw_fringe_bitmap): Remove unused rowY.
2715 Change #if to COCOA && >= 10_6.
2716 (ns_draw_window_cursor): Remove unused overspill.
2717 (ns_draw_underwave): width and x are EamcsCGFloat.
2718 (ns_draw_box): thickness is CGFloat.
2719 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2720 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2721 if not in main thread.
2722 (ns_get_pending_menu_title, ns_check_menu_open)
2723 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2724 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2725 (sendFromMainThread:): New method.
2726 (changeFont:): size is CGFloat.
2727 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2728 Disable warning about permanent text.
2729 (characterIndexForPoint:): Adjust return type depending on GNUStep
2730 version.
2731 (mouseDown:): delta is CGFloat.
2732 (updateFrameSize): Remove unised variable f.
2733 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2734 Cast float to EmacsCGFloat.
2735 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2736 also to -1 when restoring.
2737 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2738 inside NS_IMPL_COCOA.
2739 (toggleFullScreen:): Put call to toggleFullScreen inside
2740 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2741 (setPosition:portion:whole:): por is CGFloat.
2742 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2743 (mouseDown:): Use CGFloat.
2744 (mouseDragged:): Remove unised variable edge.
2745 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2746
2747 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2748 of CGFloat differs.
2749 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2750 when NS_IMPL_GNUSTEP.
2751 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2752 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2753 (EmacsToolbar): Add clearAll. Add tag argument to
2754 addDisplayItemWithImage.
2755 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2756
2757 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2758
2759 * nsmenu.m (ns_update_menubar): Make static.
2760 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2761 (fillWithWidgetValue:): Add cast to SEL for setAction.
2762 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2763 (update_frame_tool_bar): Update code for GNUStep.
2764 (clearAll): New method.
2765 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2766 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2767 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2768 call to insertItemWithItemIdentifier.
2769 (validateVisibleItems): Fix indentation.
2770 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2771 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2772 UtilityWindow to aStyle, remove call to setStyleMask.
2773
2774 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2775
2776 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2777 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2778 Use F suffix on floats.
2779 (ns_char_width): Returns CGFloat.
2780 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2781 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2782 DPSxshow.
2783 (ns_glyph_metrics): CGFloat instead of float.
2784
a0eb10b3
JB
2785 * nsfns.m (x_set_foreground_color, x_set_background_color):
2786 Use EmacsCGFloat.
2787 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2788 remove unused variables.
2789 (Fns_read_file_name): Keep track if panel is for save.
2790 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2791 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2792 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2793 Just return the input if GNUStep.
c0342369
JD
2794 (x_screen_planes): Remove.
2795 (Fxw_color_values): Use EmacsCGFloat
2796 (Fns_display_monitor_attributes_list): Only get screen number for
2797 Cocoa.
ef099a94 2798 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2799 EmacsSavePanel.
2800 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2801 ns_directory_from_panel.
2802
da9aff11
PE
28032013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 * process.c (handle_child_signal): Also use WCONTINUED.
2806 This is so that list-processes doesn't mistakenly list the process
2807 as stopped, when the process has actually been continued and is
2808 now running.
2809
0e64479a
PE
28102013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2811
fc186a96
PE
2812 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2813 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2814 not already configured.
2815
0e64479a
PE
2816 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2817
38b787fa
EZ
28182013-05-29 Eli Zaretskii <eliz@gnu.org>
2819
2820 * Makefile.in (mostlyclean): Remove *.res files.
2821
22513e52
SM
28222013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2823
2824 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2825 a buffer (bug#8447).
2826
6ef3db10
EZ
28272013-05-27 Eli Zaretskii <eliz@gnu.org>
2828
2829 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2830 display vector, and we backtrack, handle the case that the
2831 previous character position is also displayed from a display
2832 vector or covered by a display string or image. (Bug#14476)
2833
6799bb26
JD
28342013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2835
2836 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2837 (struct MonitorInfo, free_monitors): Remove.
2838 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2839 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2840 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2841 Qframes, Qsource.
2842
2843 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2844 (struct MonitorInfo, free_monitors): Remove.
2845 (ns_screen_name): Make static.
2846 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2847 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2848 Qframes, Qsource.
2849
2850 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2851 (struct MonitorInfo): New struct.
2852 (free_monitors, make_monitor_attribute_list): Declare.
2853
22513e52
SM
2854 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2855 New Lisp_Object:s.
6799bb26
JD
2856 (free_monitors, make_monitor_attribute_list): New functions.
2857 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2858 Qsource.
2859
38cd43eb
XF
28602013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2861
2862 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2863
2af0948d
SM
28642013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2865
a7eb9b0f
SM
2866 * keyboard.c: Apply keyboard decoding only to events that come directly
2867 from the tty, not from unread-command-events (bug#14368).
2868 (read_event_from_main_queue): New function, extracted from read_char).
2869 (read_decoded_char): Remove.
2870 (read_decoded_event_from_main_queue): New function to replace it.
2871 (read_char): Use it.
2872 (read_key_sequence): Use read_char rather than read_decoded_char.
2873
2af0948d
SM
2874 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2875
1413e9a5
BR
28762013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2877
2878 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2879
e6d2f155
KH
28802013-05-22 Kenichi Handa <handa@gnu.org>
2881
2882 The following changes are to fix the setting of
2883 buffer-file-coding-system on, for instance, C-x RET c unix RET
2884 _FILE_OF_DOS_EOL_TYPE_ RET.
2885
2886 * coding.h (struct coding_system): New member detected_utf8_chars.
2887
2888 * coding.c (detect_coding_utf_8): Count characters and check EOL
2889 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2890 BOM is there.
2891 (setup_coding_system): Do not initialize coding->head_ascii.
2892 (check_ascii): Do not set coding->eol_seen but update it. Do not
2893 call adjust_coding_eol_type here.
1413e9a5
BR
2894 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2895 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2896 of the found coding-system.
2897 (decode_coding_gap): Cancel previous change. Utilize the
2898 character numbers counted by detect_coding_utf_8. Fix detection
2899 of BOM for utf-8.
2900
ab56a6f4 29012013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2902
2903 * search.c (looking_at_1): Only set last_thing_searched if the match
2904 changed the match-data (bug#14281).
2905
ecc3c6ed
DA
29062013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2907
2908 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2909 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2910 (move_it_vertically_backward): Likewise.
2911
5ba8bf35
YM
29122013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2913
2914 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2915 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2916 (Fx_display_mm_width, Fx_display_mm_height):
2917 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2918
91e8418b 2919 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2920 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2921 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2922 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2923 (Fx_display_backing_store, Fx_display_visual_class)
2924 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2925 (Fx_display_grayscale_p, Fx_display_pixel_width)
2926 (Fx_display_pixel_height, Fx_display_planes)
2927 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2928 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2929 (Fx_display_mm_width, Fx_display_mm_height)
2930 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2931 height for all physical monitors as in X11.
2932
fc30d803
SM
2933 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2934 Return pixel width or height for all physical monitors as in X11.
91e8418b 2935
31ff141c
PE
29362013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 Port --enable-gcc-warnings to clang.
2939 * bytecode.c (exec_byte_code):
2940 * regex.c:
2941 Redo diagnostic pragmas to pacify clang, too.
2942 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2943 * editfns.c (Fencode_time):
2944 * fileio.c (file_accessible_directory_p):
2945 * font.c (font_unparse_xlfd):
2946 Use '&"string"[index]' instead of '"string" + (index)'.
2947 * undo.c (user_error): Remove; unused.
2948
df065a0b
EZ
29492013-05-16 Eli Zaretskii <eliz@gnu.org>
2950
04d360e7
EZ
2951 * insdel.c (insert_1_both): Document the arguments, instead of
2952 referring to insert_1, which no longer exists.
2953
5bb98290
EZ
2954 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2955 some window, increment windows_or_buffers_changed, so that
2956 *Messages* display in that window is updated. (Bug#14408)
2957
df065a0b
EZ
2958 * w32.c: Include epaths.h.
2959 (init_environment): Use cmdproxy.exe without leading directories.
2960 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2961 case.
2962 (gettimeofday): Adjust signature and return value to Posix
2963 expectations.
2964
2965 * unexw32.c (open_output_file): Delete the existing emacs.exe
2966 before creating it, to break the hard link to the versioned
2967 executable.
2968
2969 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2970 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2971 (FIRSTFILE_OBJ): New variables.
2972 (W32_RES): Rename to EMACSRES. All users changed.
2973 (base_obj): Use $(CM_OBJ).
2974 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2975 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2976 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2977 $(W32_RES_LINK) before $(LIBES).
2978 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2979
1aa8d505
SM
29802013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2981
6e911150
SM
2982 * makefile.w32-in (DOC): Use just "DOC".
2983
2984 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2985
1aa8d505
SM
2986 * process.c: Export default filters and sentinels to Elisp.
2987 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2988 New constants.
2989 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2990 (Fset_process_sentinel, Fformat_network_address):
2991 Default to them instead of nil.
2992 (server_accept_connection): Sentinels can't be nil any more.
2993 (read_and_dispose_of_process_output): New function, extracted from
2994 read_process_output.
2995 (read_process_output): Use it; filters can't be nil.
2996 (Finternal_default_process_filter): New function, extracted from
2997 read_process_output.
2998 (exec_sentinel_unwind): Remove function.
2999 (exec_sentinel): Don't zilch sentinel while running.
3000 (status_notify): Sentinels can't be nil.
3001 (Finternal_default_process_sentinel): New function extracted from
3002 status_notify.
3003 (setup_process_coding_systems): Default filter is not nil any more.
3004 (syms_of_process): Export new Elisp functions and initialize
3005 new constants.
3006 * lisp.h (make_lisp_proc): New function.
3007
5ac2eb34
SM
30082013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3009
3010 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3011
eda9c7d7
EZ
30122013-05-14 Eli Zaretskii <eliz@gnu.org>
3013
3014 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3015 unless we know that the window w is a leaf window.
3016 Another attempt at solving bug#14062.
eda9c7d7 3017
8fdeaad5
JD
30182013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3019
3020 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3021 fdesc (Bug#14375).
3022
44aa9ee6
PE
30232013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 * image.c (gif_load): Check that subimages fit (Bug#14345).
3026
759fd763
SM
30272013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3028
3029 * lread.c (skip_dyn_eof): New function.
3030 (read1): Use it to skip the end of a file in response to #@00.
3031
3032 * doc.c (get_doc_string): Slightly relax the sanity checking.
3033
4465bfb4
JD
30342013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3035
3036 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3037 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3038 (MonitorInfo): New struct.
3039 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3040 (Fns_display_monitor_attributes_list): New functions.
3041 (display-usable-bounds): Remove.
3042 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3043 Qsource.
3044
7583e2a0
PE
30452013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3046
3047 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3048 (GTK_CHECK_VERSION): New macro, if not already defined.
3049 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3050 replaced by GTK_CHECK_VERSION.
3051
ad75d77e
PE
30522013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 * xterm.h (GTK_PREREQ): New macro.
3055 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3056 to use this macro instead, for consistency and clarity.
3057
07525f77
EZ
30582013-05-08 Eli Zaretskii <eliz@gnu.org>
3059
3060 * xdisp.c (row_for_charpos_p): New function, with code of
3061 cursor_row_p, but accepts an additional argument CHARPOS instead
3062 of using a hardcoded PT.
3063 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3064 (row_containing_pos): Call row_for_charpos_p instead of partially
3065 doing the same. Fixes cursor positioning under longlines-mode
3066 when longlines-show-effect includes more than one newline, when
3067 moving the cursor vertically up.
3068
d901fc8d
JB
30692013-05-08 Juanma Barranquero <lekktu@gmail.com>
3070
3071 * makefile.w32-in (ACL_H): New macro.
3072 ($(BLD)/fileio.$(O)): Update dependencies.
3073
f269bc61
PE
30742013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3075
e7b41c4c 3076 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3077 * Makefile.in (LIB_ACL): New macro.
3078 (LIBACL_LIBS): Remove.
3079 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3080 * fileio.c: Include <acl.h>.
3081 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3082 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3083 !acl_errno_valid.
3084 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3085 it ourselves.
3086
f269bc61
PE
3087 * unexelf.c: Don't assume ElfW (Half) fits in int.
3088 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3089 when dealing with ElfW (Half) values, since they can exceed 2**31
3090 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3091 (entry_address): Omit unused NUM arg. All uses changed.
3092
a261c53e
JL
30932013-05-07 Juri Linkov <juri@jurta.org>
3094
3095 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3096 to the string converted from number with `Fnumber_to_string'.
3097 (Bug#14254)
3098
2b66427d
PE
30992013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3102 This fixes a problem introduced by my previous change.
3103
15acfe41
GM
31042013-05-07 Glenn Morris <rgm@gnu.org>
3105
3106 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3107
5ea03bf5
JD
31082013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3109
3110 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3111
e0c9d565
PE
31122013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3113
3114 Static checking by GCC 4.8.0.
3115 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3116 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3117 (x_get_monitor_attributes_fallback)
3118 (x_get_monitor_attributes_xinerama)
3119 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3120 Define only if USE_GTK.
3121 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3122 (x_get_monitor_attributes_fallback): Omit unused locals.
3123 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3124 Use double, not float, to avoid mixed-mode floating point arithmetic.
3125
4e3f9230
YM
31262013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3127 Jan Djärv <jan.h.d@swipnet.se>
3128
3129 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3130 (XINERAMA_CFLAGS): New macros.
3131 (ALL_CFLAGS, LIBES): Use them.
3132
3133 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3134 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3135 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3136 (syms_of_xfns): DEFSYM them.
3137 (struct MonitorInfo): New struct.
3138 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3139 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3140 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3141 (x_get_monitor_attributes_xinerama): New functions.
3142 (Fx_display_monitor_attributes_list): New primitive.
3143 (syms_of_xfns): Defsubr it.
3144
3145 * xterm.h (x_display_info): Add Xatom_net_workarea and
3146 Xatom_net_current_desktop.
3147
3148 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3149 and dpyinfo->Xatom_net_current_desktop.
3150
05839b6a
EZ
31512013-05-06 Eli Zaretskii <eliz@gnu.org>
3152
3153 * xdisp.c (pos_visible_p): Use the special code for finding the
3154 beginning of a display property or overlay for any "replacing"
3155 display property, not just for display strings. This solves
3156 incorrect reporting of position by posn-at-point. (Bug#14241)
3157
dc4a2ee0
PE
31582013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3159
5ee94506
PE
3160 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3161 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3162 Verify that ElfW (Half) fits in int.
3163 (fatal): Use same signature as lisp.h.
3164 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3165 configure and build with -DUNEXELF_DEBUG without worrying about
3166 other modules that use DEBUG.
3167 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3168 possibly-wide integers now uses it instead of plain fprintf.
3169 (entry_address): New function, which avoids problems with 32-bit
3170 overflow on 64-bit hosts.
3171 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3172 (round_up): Don't assume the remainder fits in int.
3173 (find_section): Use bool for boolean. Simplify debug code.
3174 (unexec): Don't assume file sizes fit in int or size_t.
3175 Omit unnecessary trailing newline in 'fatal' format.
3176 Use strerror rather than outputting decimal error number.
3177 Remove unused code when emacs is not defined;
3178 this file relies on Emacs now.
3179 Don't assume e_phnum and e_shnum are positive.
3180
dc4a2ee0
PE
3181 * regex.c: Fix problems when DEBUG is defined.
3182 (extract_number, extract_number_and_incr): Define regardless of
3183 whether DEBUG is defined; that's simpler and makes the code less
3184 likely to go stale in the normal case when DEBUG is not defined.
3185 Return int rather than taking an int * arg. All callers changed.
3186 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3187 Remove, replacing with ...
3188 (DEBUG_PRINT): New macro. All callers changed.
3189 (DEBUG_COMPILES_ARGUMENTS): New macro.
3190 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3191 (print_compiled_pattern, print_double_string) [DEBUG]:
3192 Use prototype rather than old-style definition.
3193 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3194 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3195 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3196 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3197 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3198 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3199 This matters only when DEBUG is defined.
3200
14c7ed05
EZ
32012013-05-05 Eli Zaretskii <eliz@gnu.org>
3202
3203 * xdisp.c (set_iterator_to_next): Set the
3204 ignore_overlay_strings_at_pos_p flag only if we are _really_
3205 iterating over an overlay string, as indicated by the
3206 current.overlay_string_index member. (Bug#14306)
3207
e6076b1b
JD
32082013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3209
3210 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3211 to where it is used, to avoid autorelease issues (Bug#14050).
3212
cbee2131
PE
32132013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3214
3215 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3216 * fileio.c (syms_of_fileio): Implement this.
3217 * filelock.c (create_lock_file): If symbolic links don't work, so
3218 we use a regular file as a lock file, do not fsync the lock file;
3219 it's not needed.
3220
30c7e542
SM
32212013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3222
3223 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3224 (syms_of_minibuf): Adjust accodingly.
3225 * lread.c (Fread):
3226 * callint.c (Fcall_interactively): Adjust calls accordingly.
3227
5bebd186
EZ
32282013-05-04 Eli Zaretskii <eliz@gnu.org>
3229
3230 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3231 w->contents is a buffer before computing everything else.
3232 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3233
3234 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3235 assertion violations. (Bug#14062)
3236
0fb0a4f3
DR
32372013-05-01 David Reitter <david.reitter@gmail.com>
3238
3239 * nsfns.m (ns_tooltip): Initialize.
3240
9e63b4a5
EZ
32412013-04-28 Eli Zaretskii <eliz@gnu.org>
3242
3243 * coding.c (decode_coding_gap): Don't remove the character before
3244 a newline unless it's a CR character. (Bug#14287)
3245
ad60824e
DN
32462013-04-28 Dan Nicolaescu <dann@gnu.org>
3247
3248 * dispextern.h (struct face): Move enum face_underline_type
3249 earlier so that bitfields can be in the same word.
3250
edbdcec0
JD
32512013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3252
3253 * nsfns.m (handlePanelKeys): New function.
3254 (EmacsOpenPanel:performKeyEquivalent:)
3255 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3256 arrows/function/control and copy/paste keys (Bug#14296).
3257
0208ede7
JL
32582013-04-27 Juri Linkov <juri@jurta.org>
3259
3260 * callint.c (Fcall_interactively): Call `Qread_number' for
3261 interactive code letter `n' instead of using duplicate code.
3262 (Bug#14254)
3263
b8dd59f7
PE
32642013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3265
3266 * systime.h (make_timeval): Declare as 'const'.
3267
8bd722db
KH
32682013-04-27 Kenichi Handa <handa@gnu.org>
3269
3270 * font.c (font_open_entity): Always open a font of manageable
3271 size.
3272
13d0e56f 32732013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3274
f780d632
PE
3275 Port better to AIX (Bug#14258).
3276 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3277 to pacify AIX xlc.
3278
ec509856
KH
32792013-04-24 Kenichi Handa <handa@gnu.org>
3280
3281 * coding.c (decode_coding_iso_2022): When an invalid escape
3282 sequence is encountered, reset the invocation and designation
3283 status to the safest one.
3284
84fc48e5
PE
32852013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3286
3287 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3288 Without this fix, "make distclean" leaves stamp-h1 behind.
3289
806bda47
EC
32902013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3291
3292 * w32fns.c (w32_fullscreen_rect): New function to compute the
3293 window rectangle for the given fullscreen mode.
3294 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3295 longer tunes the window size. This keeps the window's edges flush
3296 with the screen and allows the taskbar to hide itself in fullboth.
3297
3298 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3299 window decorations and uses the entire screen.
3300
3301 * w32term.h (w32_fullscreen_rect) Add prototype.
3302 (struct w32_output): Replace normal_width, normal_height,
3303 normal_top, and normal_left members with a single normal_placement
3304 struct.
3305 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3306 Remove macros.
3307 (FRAME_NORMAL_PLACEMENT): New macro.
3308
9cc2810b
JB
33092013-04-16 Juanma Barranquero <lekktu@gmail.com>
3310
3311 * minibuf.c (Ftest_completion): Silence compiler warning.
3312
fd16b54c
EZ
33132013-04-15 Eli Zaretskii <eliz@gnu.org>
3314
3315 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3316 bug#14062.
fd16b54c
EZ
3317
3318 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3319 parentheses.
3320
3321 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3322 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3323 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3324 parentheses where appropriate.
3325
9e3379a0
PE
33262013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3327
3328 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3329
ddd6b685
EZ
33302013-04-14 Eli Zaretskii <eliz@gnu.org>
3331
3332 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3333 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3334 Mention in the doc string that setting these variables takes
3335 effect only after a call to set-window-buffer. (Bug#14200)
3336
29b79ba1
EZ
33372013-04-13 Eli Zaretskii <eliz@gnu.org>
3338
3339 * indent.c (Fvertical_motion): Don't consider display strings on
3340 overlay strings as display strings on the buffer position we
3341 started from. This prevents vertical cursor motion from jumping
3342 more than one line when there's an overlay string with a display
3343 property at end of line.
3344 Reported by Karl Chen <Karl.Chen@quarl.org> in
3345 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3346
562c6ee9
SM
33472013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3348
3349 * window.c (select_window): `record_buffer' even if window is
3350 already selected (bug#14191).
3351
fcc1fe85
EZ
33522013-04-11 Eli Zaretskii <eliz@gnu.org>
3353
3354 * window.c (Fwindow_end): Test more flags, including the buffer's
3355 last_overlay_modified flag, to determine whether the window's
3356 display is really up-to-date. Prevents the function from
3357 returning a stale value. (Bug#14170)
3358 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3359 current matrix.
3360
f009190a
EZ
33612013-04-10 Eli Zaretskii <eliz@gnu.org>
3362
3363 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3364 garbaged only if it is not already the top frame on its TTY.
3365 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3366 there are GUI frames open in the same session. (Bug#13864)
3367
78ce603d
SM
33682013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3369
3370 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3371 of marking the idle timers directly.
3372
a8036e40
SM
33732013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3374
3375 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3376 tables (bug#14054).
3377
7ffe7ef6
SM
33782013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3379
3380 * window.c (select_window): Don't record_buffer while the invariant is
3381 temporarily broken (bug#14161).
3382
3383 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3384
7d9f6883
EZ
33852013-04-07 Eli Zaretskii <eliz@gnu.org>
3386
3387 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3388
5406cfd9
RF
33892013-04-07 Romain Francoise <romain@orebokech.com>
3390
3391 Ignore additional platform-specific ACL errors (Bug#13702).
3392 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3393 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3394
95c0e83b
JD
33952013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3396
3397 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3398 f->output_data.ns.
3399
876da980
PE
34002013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3401
3402 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3403 This bug was introduced by my 2013-02-25 change that simplified
3404 data_start configuration. Without this change, on GNU/Linux
3405 an Emacs configured with --enable-profiling fails immediately
3406 due to a profiler signal.
3407 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3408 with these flags. On platforms where special flags are needed
3409 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3410 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3411 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3412
7452b7bd
DA
34132013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3414
3415 Get rid of some platform-specific functions examining window
3416 system and its capabilities. This is a partial rework of the
3417 2013-04-05 change.
3418 * lisp.h (have_menus_p): Remove prototype. This function is
3419 replaced with platform-independent window_system_available.
3420 (check_window_system): Move to...
3421 * frame.h (decode_window_system_frame, window_system_available):
3422 ...here, add new prototypes.
3423 * frame.c (window_system_available, decode_window_system_frame):
3424 New functions.
3425 (check_window_system): Platform-independent now.
3426 * xterm.h (x_in_use): Remove declaration.
3427 (check_x_frame):
3428 * w32term.h (check_x_frame):
3429 * nsterm.h (check_x_frame): Remove prototypes. This function
3430 is replaced with platform-independent decode_window_system_frame.
3431 * msdos.c (have_menus_p): Remove.
3432 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3433 Remove platform-specific functions. Use check_window_system,
3434 decode_window_system_frame and check_ns_display_info where
3435 appropriate. Minor style and comment tweaks.
3436 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3437 (check_x_frame): Likewise.
3438 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3439 Likewise.
3440 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3441 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3442 * xmenu.c, xselect.c: All related users changed.
3443
251e9147
KH
34442013-04-03 Kenichi Handa <handa@gnu.org>
3445
3446 The following changes is to optimize the code for reading UTF-8
3447 files.
3448
562c6ee9 3449 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3450 changed. Check EOL format. Do not call adjust_coding_eol_type
3451 here.
3452 (check_utf_8): New function.
3453 (adjust_coding_eol_type): Do nothing if already adjusted.
3454 (detect_coding): Compare the return value of check_ascii with
3455 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3456 (decode_coding_gap): Optimize for valid UTF-8.
3457
8bc369d4
KH
34582013-03-21 Kenichi Handa <handa@gnu.org>
3459
3460 * coding.c (syms_of_coding): Cancel previous change.
3461
3462 * insdel.c (insert_from_gap): Fix previous change.
3463
73931ad1
DA
34642013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3465
3466 Consistently use platform-specific function to detect window system.
3467 * lisp.h (check_window_system): New prototype. This function is
3468 going to replace check_x, check_w32 and check_ns.
3469 (have_menus_p): Mention msdos.c in comment.
3470 * fontset.c (check_window_system_func): Remove. Adjust all users.
3471 * fontset.h (check_window_system_func): Remove prototype.
3472 * nsterm.h (check_ns):
3473 * xterm.h (check_x):
3474 * w32term.h (check_w32): Likewise.
3475 * menu.c (Fx_popup_menu): Use check_window_system.
3476 * msdos.c (check_window_system): Define for MS-DOS.
3477 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3478 * w32fns.c (check_window_system): Likewise for MS-Windows.
3479 * xfns.c (check_window_system): Likewise for X.
3480 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3481 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3482
7216e43b
PE
34832013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3484
3485 Prefer < to > in range checks such as 0 <= i && i < N.
3486 This makes it easier to visualize quantities on a number line.
3487 This patch doesn't apply to all such range checks,
3488 only to the range checks affected by the 2013-03-24 change.
3489 This patch reverts most of the 2013-03-24 change.
3490 * alloc.c (xpalloc, Fgarbage_collect):
3491 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3492 * character.c (string_escape_byte8):
3493 * charset.c (read_hex):
3494 * data.c (cons_to_unsigned):
3495 * dispnew.c (update_frame_1):
3496 * doc.c (Fsubstitute_command_keys):
3497 * doprnt.c (doprnt):
3498 * editfns.c (hi_time, decode_time_components):
3499 * fileio.c (file_offset):
3500 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3501 * font.c (font_intern_prop):
3502 * frame.c (x_set_alpha):
3503 * gtkutil.c (get_utf8_string):
3504 * indent.c (check_display_width):
3505 * keymap.c (Fkey_description):
3506 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3507 * lread.c (read1):
3508 * minibuf.c (read_minibuf_noninteractive):
3509 * process.c (wait_reading_process_output):
3510 * search.c (Freplace_match):
3511 * window.c (get_phys_cursor_glyph):
3512 * xdisp.c (redisplay_internal):
3513 * xsmfns.c (smc_save_yourself_CB):
3514 Prefer < to > for range checks.
3515 * dispnew.c (sit_for): Don't mishandle NaNs.
3516 This fixes a bug introduced in the 2013-03-24 change.
3517 * editfns.c (decode_time_components): Don't hoist comparison.
3518 This fixes another bug introduced in the 2013-03-24 change.
3519
92759988
DA
35202013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3521
3522 * frame.h (struct frame): Drop scroll_bottom_vpos
3523 member becaue all real users are dead long ago.
3524 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3525 * xdisp.c (redisplay_internal): Adjust user.
3526
9a1971bb
GM
35272013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3528
f38ab167
JD
3529 * nsmenu.m (showAtX:Y:for:): setLevel to
3530 NSPopUpMenuWindowLevel (Bug#13998).
3531
6d01f1fe
JD
35322013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3533
3534 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3535 (ns_check_pending_open_menu): Declare.
3536
3537 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3538 (x_activate_menubar): Update the menu with title that matches
3539 ns_get_pending_menu_title, and call
3540 ns_check_pending_openmenu (Bug#12698).
3541 (menuWillOpen:): New method.
3542 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3543
3544 * nsterm.m (menu_will_open_state, menu_mouse_point)
3545 (menu_pending_title): New varaibles.
3546 (ns_get_pending_menu_title, ns_check_menu_open)
3547 (ns_check_pending_open_menu): New functions.
3548
781f4782
DA
35492013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3550
3551 * indent.c (current_column_bol_cache): Remove leftover which is not
3552 used in Fmove_to_column any more.
3553 (current_column, scan_for_column): Adjust users.
3554 * keyboard.c (last_point_position_buffer, last_point_position_window):
3555 Remove leftovers which are not used for recording undo any more.
3556 (command_loop_1, syms_of_keyboard): Adjust users.
3557 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3558 redisplay_window any more.
3559 (move_it_to): Adjust user.
3560
1921c31b
JB
35612013-03-29 Juanma Barranquero <lekktu@gmail.com>
3562
3563 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3564 Update dependencies.
3565
717b8bcd
SM
35662013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3567
3568 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3569 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3570 forward references.
3571
e74aeda8
DA
35722013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3573
3574 * window.h (struct window): Replace hchild, vchild and buffer slots
3575 with the only contents slot. This is possible because each valid
3576 window may have either the child window (in vertical or horizontal
3577 combination) or buffer to display (for the leaf window). Using that,
3578 a lof of operations to traverse and/or change window hierarchies may
3579 be simplified. New member horizontal is used to distinguish between
3580 horizontal and vertical combinations of internal windows.
3581 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3582 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3583 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3584 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3585 Use contents slot, not buffer, where appropriate.
3586 (wset_combination): New function.
3587 (wset_buffer): Add eassert.
3588 (Fframe_first_window): Simplify the loop reaching first window.
3589 (Fwindow_buffer): Use WINDOW_LEAF_P.
3590 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3591 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3592 (unshow_buffer): Convert initial debugging check to eassert.
3593 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3594 (make_parent_window, window_resize_check, window_resize_apply)
3595 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3596 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3597 Adjust to match struct window changes.
3598 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3599 (mark_window_cursors_off, count_windows, get_leaf_windows)
3600 (foreach_window_1): Simplify the loop.
3601 * alloc.c (mark_object): Do not check for the leaf window because
3602 internal windows has no glyph matrices anyway.
3603 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3604 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3605 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3606 (build_frame_matrix_from_window_tree, mirror_make_current)
3607 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3608 (update_window_tree, set_window_update_flags): Simplify the loop.
3609 (sync_window_with_frame_matrix_rows): Enforce live window.
3610 Use contents slot, not buffer, where appropriate.
3611 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3612 and WINDOW_HORIZONTAL_COMBINATION_P.
3613 (make_frame_visible_1): Simplify the loop.
3614 Use contents slot, not buffer, where appropriate.
3615 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3616 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3617 (expose_window_tree): Likewise.
3618 Use contents slot, not buffer, where appropriate.
3619 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3620 to avoid deleted windows. Use contents slot instead of buffer.
3621 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3622 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3623 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3624 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3625
121ab1cd
EZ
36262013-03-28 Eli Zaretskii <eliz@gnu.org>
3627
ef454cf7
EZ
3628 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3629 identify the reasons for assertion violations in bug#14062 and
3630 similar ones.
21e930f8
EZ
3631 (Fx_show_tip): Fix compilation error under
3632 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3633
121ab1cd
EZ
3634 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3635 Reported by <rzl24ozi@gmail.com>.
3636
5c89ca24
DA
36372013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3638
3639 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3640 start marker...
562c6ee9
SM
3641 (unwind_with_echo_area_buffer): ...to restore it here.
3642 This is needed to ensure that...
5c89ca24
DA
3643 (redisplay_window): ...both window markers are valid here,
3644 which is verified by eassert.
3645 * editfns.c (save_excursion_save): Do not assume that
3646 selected_window always displays the buffer.
c7f53895
DA
3647 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3648 Fix comment.
5c89ca24 3649
f557c1b1
SM
36502013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3651
3652 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3653 the upcase table.
3654
40693bba 36552013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3656
3657 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3658
c86f791f
EZ
36592013-03-27 Eli Zaretskii <eliz@gnu.org>
3660
3661 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3662 since MinGW's w32api headers do. This avoids compiler warnings.
3663
3664 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3665 if already defined.
3666
c6e72e17
EZ
36672013-03-26 Eli Zaretskii <eliz@gnu.org>
3668
3669 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3670
54e95010
JD
36712013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3672
3673 * gtkutil.c (style_changed_cb): Check if frame is live and an
3674 X frame (Bug#14038).
3675
b88b62de
EZ
36762013-03-26 Eli Zaretskii <eliz@gnu.org>
3677
a18d7de6
EZ
3678 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3679 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3680 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3681 MinGW64.
8f5e14c8
EZ
3682 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3683 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3684
b88b62de
EZ
3685 Fix incompatibilities between MinGW.org and MinGW64 headers.
3686 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3687
3688 * w32.c (REPARSE_DATA_BUFFER): Guard with
3689 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3690
c074e458
JD
36912013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3692
3693 * xterm.c: Include X11/XKBlib.h
3694 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3695
908589fd
AS
36962013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3697
3698 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3699 written backwards.
3700 * blockinput.h (input_blocked_p): Likewise.
3701 * bytecode.c (exec_byte_code): Likewise.
3702 * callproc.c (call_process_kill, call_process_cleanup)
3703 (Fcall_process): Likewise.
3704 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3705 (Fccl_execute_on_string): Likewise.
3706 * character.c (string_escape_byte8): Likewise.
3707 * charset.c (read_hex): Likewise.
3708 * cm.c (calccost): Likewise.
3709 * data.c (cons_to_unsigned): Likewise.
3710 * dired.c (directory_files_internal, file_name_completion):
3711 Likewise.
3712 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3713 (sit_for): Likewise.
3714 * doc.c (Fsubstitute_command_keys): Likewise.
3715 * doprnt.c (doprnt): Likewise.
3716 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3717 * emacsgtkfixed.c: Likewise.
3718 * fileio.c (file_offset, Fwrite_region): Likewise.
3719 * floatfns.c (Fexpt, fmod_float): Likewise.
3720 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3721 Likewise.
3722 * font.c (font_intern_prop): Likewise.
3723 * frame.c (x_set_alpha): Likewise.
3724 * gtkutil.c (get_utf8_string): Likewise.
3725 * indent.c (check_display_width): Likewise.
3726 * intervals.c (create_root_interval, rotate_right, rotate_left)
3727 (split_interval_right, split_interval_left)
3728 (adjust_intervals_for_insertion, delete_node)
3729 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3730 (merge_interval_right, merge_interval_left, copy_intervals)
3731 (set_intervals_multibyte_1): Likewise.
3732 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3733 * keymap.c (Fkey_description): Likewise.
3734 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3735 * lread.c (openp, read_integer, read1, string_to_number):
3736 Likewise.
3737 * menu.c (ensure_menu_items): Likewise.
3738 * minibuf.c (read_minibuf_noninteractive): Likewise.
3739 * print.c (printchar, strout): Likewise.
3740 * process.c (create_process, Faccept_process_output)
3741 (wait_reading_process_output, read_process_output, send_process)
3742 (wait_reading_process_output): Likewise.
3743 * profiler.c (make_log, handle_profiler_signal): Likewise.
3744 * regex.c (re_exec): Likewise.
3745 * regex.h: Likewise.
3746 * search.c (looking_at_1, Freplace_match): Likewise.
3747 * sysdep.c (get_child_status, procfs_ttyname)
3748 (procfs_get_total_memory): Likewise.
3749 * systime.h (EMACS_TIME_VALID_P): Likewise.
3750 * term.c (dissociate_if_controlling_tty): Likewise.
3751 * window.c (get_phys_cursor_glyph): Likewise.
3752 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3753 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3754 Likewise.
3755 * xfns.c (Fx_window_property): Likewise.
3756 * xmenu.c (set_frame_menubar): Likewise.
3757 * xselect.c (x_get_window_property, x_handle_dnd_message):
3758 Likewise.
3759 * xsmfns.c (smc_save_yourself_CB): Likewise.
3760 * xterm.c (x_scroll_bar_set_handle): Likewise.
3761
2bf7d27a
DA
37622013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3763
3764 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3765 to be optional or nil. Adjust comment and convert it to docstring.
3766 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3767 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3768
a9ebfa0b
PE
37692013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3770
3771 Static checking by GCC 4.8-20130319.
3772 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3773 * process.c (Fset_process_datagram_address)
3774 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3775 * xdisp.c (get_char_face_and_encoding):
3776 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3777 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3778 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3779
4f3576ee
KB
37802013-03-24 Ken Brown <kbrown@cornell.edu>
3781
789b5e9a
KB
3782 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3783 fix compilation on 64-bit Cygwin, where underscores are not
3784 automatically prepended.
3785
4f3576ee
KB
3786 * w32term.c (w32_initialize): Silence compiler warning.
3787
b5b7745f
EZ
37882013-03-23 Eli Zaretskii <eliz@gnu.org>
3789
cdc0d0bd
EZ
3790 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3791 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3792 variables, to save and restore frame dimensions.
3793 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3794 after returning from a 'fullscreen' configuration.
3795 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3796 to avoid races between the main thread and the input thread.
3797
3798 * w32term.h (struct w32_output): New members normal_width,
3799 normal_height, normal_top, normal_left, and prev_fsmode.
3800 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3801 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3802 members of a frame.
3803
b5b7745f
EZ
3804 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3805 'fullscreen' parameter. Always record previous width and height
3806 of the frame, except when switching out of maximized modes, so
3807 that they could be restored correctly, instead of resetting to the
3808 default frame dimensions. Send SC_RESTORE command to the frame,
3809 unless we are going to send SC_MAXIMIZE, to restore the frame
3810 resize hints in the mouse pointer shown by the window manager.
3811 (Bug#14032)
3812
3813 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3814
3815 * lisp.h (get_frame_param): Adjust conditions for prototype
3816 declaration.
3817
a3454eed
KB
38182013-03-22 Ken Brown <kbrown@cornell.edu>
3819
3820 * unexcw.c: Drop unneeded inclusion of w32common.h.
3821 (report_sheap_usage): Declare.
3822 (read_exe_header): Add magic numbers for x86_64.
3823 (fixup_executable): Fix printf format specifier for unsigned long
3824 argument.
3825
5a49b79c
DA
38262013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3827
3828 * frame.h (struct frame): Put menu_bar_window under #ifdef
3829 because this member is not needed when X toolkit is in use.
3830 (fset_menu_bar_window):
3831 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3832 (free_glyphs, update_frame):
3833 * xdisp.c (expose_frame): Likewise.
3834 (display_menu_bar): Likewise. Remove redundant eassert.
3835 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3836 toolkit is in use.
3837
d6723bf7
PE
38382013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3839
7b1123d8
PE
3840 Use functions and constants to manipulate Lisp_Save_Value objects.
3841 This replaces code that used macros and strings and token-pasting.
3842 The change makes the C source a bit easier to follow,
3843 and shrinks the Emacs executable a bit.
3844 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3845 (make_save_value): Change 1st arg from string to enum. All callers
3846 changed.
3847 (INTX): Remove.
3848 (mark_object): Use if, not #if, for GC_MARK_STACK.
3849 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3850 (XSAVE_OBJECT): Now functions, not macros.
3851 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3852 the constant was never used.
3853 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3854 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3855 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3856 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3857 New constants.
3858 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3859 type3 with a single member save_type. All uses changed.
3860 (save_type, set_save_pointer, set_save_integer): New functions.
3861 * print.c (PRINTX): Remove.
3862
d6723bf7
PE
3863 * alloc.c: Remove redundant static declarations.
3864
5f24fa51
DA
38652013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3866
3867 * window.h (struct window): Convert left_col, top_line, total_lines
3868 and total_cols from Lisp_Objects to integers. Adjust comments.
3869 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3870 Remove.
3871 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3872 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3873 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3874 Adjust users where appropriate.
3875
42143acd
DA
38762013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3877
3878 * frame.h (struct frame): Drop resx and resy because the same data is
3879 available from window system-specific output context. Adjust users.
562c6ee9
SM
3880 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3881 New functions to provide defaults when no window system available.
42143acd 3882 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3883 (NUMVAL): Move from xdisp.c.
42143acd
DA
3884 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3885 (Ffont_face_attributes, Fopen_font):
3886 * image.c (gs_load):
3887 * w32font.c (fill_in_logfont):
3888 * xdisp.c (calc_pixel_width_or_height):
3889 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3890 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3891
c0a17406
KH
38922013-03-20 Kenichi Handa <handa@gnu.org>
3893
3894 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3895 to 1 (temporary workaround until a bug related to ASCII
3896 optimization is fixed).
3897
095d384d
DA
38982013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3899
3900 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3901 Signal error if window is not internal. Adjust docstring.
3902 (delete_all_child_windows): Use combination_limit to save the buffer.
3903 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3904 * print.c (syms_of_print): Initialize debugging output not here...
3905 (init_print_once): ...but in a new function here.
3906 * lisp.h (init_print_once): Add prototype.
3907 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3908
748fa866
DA
39092013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3910
3911 * window.c (window_resize_check, window_resize_apply)
3912 (window_from_coordinates, recombine_windows, set_window_buffer)
3913 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3914 (Fsplit_window_internal, Fdelete_window_internal)
3915 (freeze_window_starts): Use bool for booleans.
3916 * window.h (window_frame_coordinates, resize_frame_windows)
3917 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3918
81519fd2
SM
39192013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3920
3921 * dispnew.c (bitch_at_user): Use `user-error'.
3922
6db423a9
KB
39232013-03-17 Ken Brown <kbrown@cornell.edu>
3924
3925 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3926 as return type of image_background. (Bug#13981)
3927 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3928
8f2906f5
JD
39292013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3930
960ce480 3931 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3932 (ns_select): Don't return with result uninitialized.
960ce480 3933
8f2906f5
JD
3934 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3935 and getDirectory.
3936
81519fd2
SM
3937 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3938 New functions.
8f2906f5
JD
3939 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3940 directories. If filename is nil, get directory name (Bug#13932).
3941 Use getFilename and getDirectory.
3942 (getFilename, getDirectory): New methods for EmacsSavePanel and
3943 EmacsOpenPanel.
3944 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3945
cded56c1
PE
39462013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3949
251e9147 39502013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3951
3952 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3953 (adjust_after_replace): Make it back to static. Delete the third
3954 arg text_at_gap_tail. Cancel the code for handling it.
3955
3956 * coding.h (struct coding_system): New member eol_seen.
3957
3958 * coding.c (detect_ascii): New function.
3959 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3960 when the source bytes are actually scanned. On detecting for
3961 coding_category_utf_8_auto, call detect_ascii instead of scanning
3962 source bytes directly.
3963 (produce_chars): Call insert_from_gap with the new arg 0.
3964 (encode_coding): Likewise.
3965 (decode_coding_gap): Control ASCII optimization by the variable
3966 disable_ascii_optimization instead of #ifndef .. #endif.
3967 Deccode EOL format according to coding->eol_seen.
3968 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3969 variable.
3970
8a44e6d1
KH
3971 * lisp.h (adjust_after_replace): Cancel externing it.
3972 (insert_from_gap): Adjust prototype.
3973
5f795e34
EZ
39742013-03-15 Eli Zaretskii <eliz@gnu.org>
3975
3976 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3977 FULLSCREEN_MAXIMIZED. (Bug#13935)
3978
f258b4be
DA
39792013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3980
3981 * region-cache.c (find_cache_boundary, move_cache_gap)
3982 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3983 Simplify debugging check and convert to eassert. Adjust comment.
3984 (pp_cache): Put under ENABLE_CHECKING.
3985
a5cc4dde
EZ
39862013-03-14 Eli Zaretskii <eliz@gnu.org>
3987
3988 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3989 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3990 and WM_ACTIVATEAPP.
3991 (w32fullscreen_hook): If the frame is visible, reset
3992 f->want_fullscreen flag after changing the frame size. If the
3993 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3994 (Bug#13953)
3995
3fc5e44a
DC
39962013-03-13 Daniel Colascione <dancol@dancol.org>
3997
3998 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3999 too so that these builds can use Cygwin's file conversion
4000 functions. (We've been building and linking cygw32.o all along
4001 and just not using it.)
4002
47d7532e
PE
40032013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4004
4005 File synchronization fixes (Bug#13944).
4006 * Makefile.in (LIB_FDATASYNC): New macro.
4007 (LIBES): Use it.
4008 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4009 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4010 Don't worry about HAVE_FSYNC, since a substitute fsync is
4011 available if the system lacks one.
4012 (Fwrite_regin): Retry fsync if interrupted.
4013
c7ffccaf
EZ
40142013-03-13 Eli Zaretskii <eliz@gnu.org>
4015
4e2df81d 4016 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4017 activated, call w32fullscreen_hook, to make sure the new frame
4018 dimensions are in effect. (Bug#13937)
4019
8a7debc1
DA
40202013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4021
4022 * xdisp.c (init_iterator): Simplify because both character and byte
4023 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4024 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4025 character and byte positions can be obtained from marker.
8a7debc1 4026
7fd8c501
PE
40272013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4028
d9df6f40
PE
4029 Static checking by Sun C 5.12.
4030 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4031 * bytecode.c (exec_byte_code):
4032 * dispnew.c (init_display):
4033 * eval.c (error):
4034 * fileio.c (Fsubstitute_in_file_name):
4035 * keyboard.c (Fevent_convert_list):
4036 * keymap.c (Fsingle_key_description):
4037 * term.c (maybe_fatal, fatal):
4038 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4039 * xsmfns.c (Fhandle_save_session):
4040 Omit unreachable code.
4041 * keymap.c (map_keymap_char_table_item): Cast void * to
4042 a function pointer type; the C Standard requires this.
4043
7fd8c501
PE
4044 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4045 Include <sys/param.h> unconditionally, as that works elsewhere and
4046 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4047 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4048 and FreeBSD now.
4049
a020afb9 4050See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4051
4052;; Local Variables:
4053;; coding: utf-8
aac0c6e3
MR
4054;; End:
4055
ab422c4d 4056 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4057
4058 This file is part of GNU Emacs.
4059
4060 GNU Emacs is free software: you can redistribute it and/or modify
4061 it under the terms of the GNU General Public License as published by
4062 the Free Software Foundation, either version 3 of the License, or
4063 (at your option) any later version.
4064
4065 GNU Emacs is distributed in the hope that it will be useful,
4066 but WITHOUT ANY WARRANTY; without even the implied warranty of
4067 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4068 GNU General Public License for more details.
4069
4070 You should have received a copy of the GNU General Public License
4071 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.