* nsmenu.m (menuWillOpen:): Fix preprocessor test.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
63216c5e
JD
12013-08-15 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
4
a5b5f73f
LMI
52013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6
7 * image.c (imagemagick_compute_animated_image): Respect the GIF
8 disposal methods.
9
0fe73012
KB
102013-08-15 Ken Brown <kbrown@cornell.edu>
11
12 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
13 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
14 needed.
15
691a357f
PE
162013-08-15 Paul Eggert <eggert@cs.ucla.edu>
17
18 Fix minor problems found by static checking.
19 * frame.c (delete_frame):
20 * xdisp.c (next_element_from_display_vector):
21 Avoid uninitialized local.
22 * image.c (imagemagick_compute_animated_image): Port to C89.
23 Prefer usual GNU indentation style for loops.
24 Be more careful about bizarrely large sizes, by using ptrdiff_t
25 instead of int.
26
42fe2e88
DA
272013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
28
29 Fix infinite frame selection loop (Bug#15025).
30 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
31
d39a3da6
EZ
322013-08-15 Eli Zaretskii <eliz@gnu.org>
33
34 * xdisp.c (compute_window_start_on_continuation_line): When
35 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
36 to make sure we end up setting the window start at the leftmost
37 visible character of the display line. This avoids funky
38 horizontal shifting because the window start is not kept on the
39 same position. (Bug#15090)
05426239
EZ
40 (next_element_from_display_vector): Support 'box' face attribute
41 in the face definitions of a display vector. (Bug#15099)
d39a3da6 42
6e856b69
LMI
432013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
44
45 * image.c (imagemagick_compute_animated_image): Implement animated
46 images (bug#14700).
995be755
LMI
47 (imagemagick_compute_animated_image): Fix some compilation
48 warnings. Implement a very simple cache to make the animation
49 usable at all, but it should be replaced with a per-image cache.
6e856b69 50
d5a1acfa
DA
512013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
52
53 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
54 to do `for' loops over alist values.
55 * buffer.h (FOR_EACH_BUFFER):
56 * process.c (FOR_EACH_PROCESS): Use it.
57 (handle_child_signal, status_notify, Fget_buffer_process)
58 (kill_buffer_processes): Use FOR_EACH_PROCESS.
59
9c253307
DA
602013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
61
62 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
63 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
64 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
65 to xzalloc and so avoid redundant call to memset.
66 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
67 members because it is allocated with xzalloc and so already zeroed.
68
05e64f9f
KB
692013-08-14 Ken Brown <kbrown@cornell.edu>
70
71 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
72 (Bug#15094).
73
5b71542d
DA
742013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
75
76 Utility function and macro to copy Lisp string to C string.
77 * lisp.h (xlispstrdupa): New macro.
78 (xlispstrdup): New prototype.
79 * alloc.c (xlispstrdup): New function.
80 * callint.c (Fcall_interactively):
81 * fileio.c (Ffile_name_directory, Fexpand_file_name)
82 (Fsubstitute_in_file_name):
83 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
84 * image.c (x_create_bitmap_from_file):
85 * w32term.c (w32_term_init):
86 * xterm.c (x_term_init): Use xlispstrdup.
87
71530c97
LMI
882013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
89
4ce82fb8
LMI
90 * image.c (imagemagick_load_image): Make animated pictures work.
91 There's still some problems with background color settings, though
92 (bug#14700).
93
71530c97
LMI
94 * decompress.c (unwind_decompress): Always restore point.
95
7510a061
XF
962013-08-14 Xue Fuqiao <xfq.free@gmail.com>
97
98 * marker.c (set_marker): Reformat documentation.
99
01c3051f
PE
1002013-08-14 Paul Eggert <eggert@cs.ucla.edu>
101
aab1fcdf
PE
102 * xdisp.c (cursor_type_changed): Now static.
103
01c3051f
PE
104 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
105 Use changed. This avoids the need to call xmalloc and for the
106 caller to call xfree, and avoids memory leaks in some situations.
107
2084152a
DA
1082013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
109
110 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
111 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
112 (redisplay_window): If window_end_valid is cleared due to non-zero
113 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
114 so do not call to try_cursor_movement for that window.
2084152a 115
02455cb6
DA
1162013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
117
118 * window.h (struct window): Convert window_end_pos and
119 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
120 (wset_window_end_pos, wset_window_end_vpos): Remove.
121 * dispnew.c (adjust_glyph_matrix):
122 * window.c (Fwindow_end, replace_window, set_window_buffer)
123 (make_window):
124 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
125 (set_vertical_scroll_bar, redisplay_window, try_window)
126 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
127 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
128 (note_mouse_highlight): Adjust users.
129 (try_cursor_movement): Likewise. Convert old precondition to eassert.
130 Add comment.
131
da5707e8
DA
1322013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
133
134 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
135 * image.c (imagemagick_filename_hint): Use `const char *' and
136 prefer SSDATA to SDATA to avoid warnings.
137
25554267
DA
1382013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
139
140 Cleanup window fringes, margins and scroll bars adjustments.
141 * window.c (set_window_fringes, set_window_margins)
142 (set_window_scroll_bars, apply_window_adjustment): New functions.
143 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
144 (Fset_window_scroll_bars): Use them.
145
38a2c910
DA
1462013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
147
148 * window.h (struct window): Convert scroll_bar_width
149 from Lisp_Object to integer. Adjust comment.
150 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
151 Adjust users.
152 * window.c (wset_scroll_bar_width): Remove.
153 (make_window): Initialize scroll_bar_width.
154 (Fsplit_window_internal): Use direct assignment.
155 (Fset_window_configuration, save_window_save):
156 Convert Lisp_Object to integer and back where appropriate.
157 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
158 bar was actually changed, and mention this in docstring.
159
2d065031
PE
1602013-08-13 Paul Eggert <eggert@cs.ucla.edu>
161
162 * decompress.c: Minor simplifications.
163 (Fzlib_decompress_region): Don't bother verifying
164 that avail_out <= UINT_MAX, as that was confusing.
165 Mention the restriction in a comment instead.
166 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
167
a5bd5abb
JD
1682013-08-13 Jan Djärv <jan.h.d@swipnet.se>
169
170 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
171 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
172
66e7901a
LMI
1732013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
174
175 * image.c (imagemagick_filename_hint): Check for errors in the
176 alist structure.
177
2fa611b7
EZ
1782013-08-13 Eli Zaretskii <eliz@gnu.org>
179
180 * window.c (Fwindow_margins): Return nil when there's no marginal
181 area, as per the documented API.
182
183 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
184 Fmake_vector, as scroll bar's struct members are not all Lisp
185 objects now. This avoids crashes in GC.
186
187 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
188 bool, so its address could be taken.
189
8259030d
LMI
1902013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
191
192 * image.c (imagemagick_filename_hint): New function to possibly
193 apply `image-content-type-suffixes'.
194 (imagemagick_load_image): Use it.
195
866c710e
EZ
1962013-08-13 Eli Zaretskii <eliz@gnu.org>
197
198 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
199 if loading zlib failed.
200
f10490f0
JD
2012013-08-13 Jan Djärv <jan.h.d@swipnet.se>
202
96311be7
JD
203 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
204 2013-08-13 checkin below. Change bool to BOOL, rule is:
205 All Obj-C code uses BOOL, except for interfaces callable from C.
206
f10490f0
JD
207 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
208
c8ae93b0
DA
2092013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
210
211 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
212 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
213 bool instead of BOOL.
214 * w32term.h (struct scroll_bar): Convert fringe_extended_p
215 from Lisp_Object to bitfield. Adjust comment.
216 * w32term.c (x_scroll_bar_create): Adjust user.
217 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
218 * xterm.c (XTset_vertical_scroll_bar): Likewise.
219 Use bool for boolean.
220 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
221 to `unsigned int' when defining a bitfield.
222
53b64418
PE
2232013-08-13 Paul Eggert <eggert@cs.ucla.edu>
224
225 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
226
eeaf9bf3
DA
2272013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * window.h (struct window): Convert left_margin_cols and
230 right_margin_cols from Lisp_Objects to integers. Adjust comment.
231 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
232 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
233 Adjust users.
234 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
235 Adjust comment.
236 (showing_window_margins_p, update_window_line, update_frame_1):
237 * fringe.c (draw_fringe_bitmap_1):
238 * xdisp.c (window_box_width): Adjust users.
239 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
240 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
241 Use direct assignment.
242 (Fset_window_configuration, save_window_save, Fwindow_margins):
243 Convert Lisp_Object to integer and back where appropriate.
244 (Fset_window_margins): Adjust user. Return t if any margin
245 was actually changed, and mention this in docstring.
246
956720af
XF
2472013-08-13 Xue Fuqiao <xfq.free@gmail.com>
248
f73f4ce6 249 * syntax.c (forward_word):
956720af
XF
250 * cmds.c (forward_char, backward_char): Mention the optional argument.
251
9e37ee3b
DA
2522013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
253
254 * window.h (struct window): Convert left_fringe_width
255 and right_fringe_width from Lisp_Objects to integers.
256 Adjust comment.
257 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
258 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
259 * window.c (wset_left_fringe_width, wset_right_fringe_width):
260 Remove.
261 (make_window): Initialize new integer fields to -1.
262 (Fsplit_window_internal): Use direct assignment.
263 (Fset_window_configuration, save_window_save): Convert
264 Lisp_Object to integer and back where appropriate.
265 (Fset_window_fringes): Adjust user. Return t if any fringe
266 was actually changed, and mention this in docstring.
267
e4375ca7
DA
2682013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
269
270 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
271 * nsfns.m (x_set_cursor_type):
272 * w32fns.c (x_set_cursor_type):
273 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
274 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 275
a45543bc
DA
2762013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
277
278 * font.c (clear_font_cache): New function, stripped from...
279 (Fclear_font_cache): ...here, which now uses the function
280 above. Adjust comment.
281 * font.h (clear_font_cache): Add prototype.
282 * xfaces.c (clear_face_cache): Use clear_font_cache.
283
ae966a86
DA
2842013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
285
286 * window.c (Fset_window_start): Compare `w', not `window' because
287 `w' might not be equal to `window' after call to decode_live_window.
288
297a545b
PE
2892013-08-12 Paul Eggert <eggert@cs.ucla.edu>
290
291 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
292 This fixes a problem introduced by the Bug#15035 patch
293 when using GPG. Reported by Herbert J. Skuhra.
294
aa942e2b
EZ
2952013-08-12 Eli Zaretskii <eliz@gnu.org>
296
297 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
298 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
299 not yet initialized.
300
7699d09e
LMI
3012013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
302
303 * decompress.c (Fzlib_decompress_region): Support zlib
304 decompression, too, and rename.
305
1d238bc7
PE
3062013-08-12 Paul Eggert <eggert@cs.ucla.edu>
307
308 Minor zlib configuration tweaks.
309 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
310 Don't assume presence of fn_inflateInit2_ zlib internal function.
311
8a44a184
LMI
3122013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
313
314 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
315 include the zlib prefix.
316
594a4307
EZ
3172013-08-12 Eli Zaretskii <eliz@gnu.org>
318
319 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
320 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
321 define static variables that are pointers to zlib functions to be
322 dynamically loaded.
323 (init_zlib_functions) [WINDOWSNT]: New function.
324 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
325 New macros.
326 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
327 macros instead of invoking the zlib functions directly.
328 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
329 Szlib_available_p.
330
d2e113bc
DA
3312013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
332
333 Avoid looping over all frame windows to freeze and unfreeze.
334 * window.h (struct window): Drop frozen_window_start_p.
335 (freeze_window_starts): Drop prototype.
336 * frame.h (struct frame): New frozen_window_starts flag.
337 (FRAME_WINDOWS_FROZEN): New macro.
338 * window.c (freeze_window_start, freeze_window_starts):
339 Remove.
340 (select_window, replace_window): Adjust users.
341 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
342 (window_frozen_p): New function.
343 (redisplay_window): Use it.
344
94fcd171
PE
3452013-08-12 Paul Eggert <eggert@cs.ucla.edu>
346
347 Fix some fd issues when running subprocesses (Bug#15035).
348 Fix bugs that can leak files or file descriptors on errors.
349 Don't unlink open temp files, as that's hard for users to diagnose
350 when things go awry (e.g., temp disk exhausted).
351 Don't bother to lock temp files. Check for invalid recursion.
352 * callproc.c (synch_process_fd): Remove. All uses removed.
353 (synch_process_tempfile): New var or macro.
354 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
355 New constants.
356 (record_kill_process): New arg, the temp name. All callers changed.
357 (delete_temp_file): Now just a simple wrapper around unlink.
358 (call_process_kill): New arg, the call_process_fd array.
359 Close them all. Clear synch_process_pid. Remove the temp file,
360 or arrange for it to be removed.
361 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
362 that's been moved to synch_process_tempfile. Caller changed.
363 Do not remove the tempfile; that's now call_process_kill's
364 responsibility.
365 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
366 call_process_kill; the caller now does that.
367 (call_process_cleanup): Do not close the process fd; that's now
368 call_process_kill's responsibility.
369 (Fcall_process): Implement via new function call_process, which
370 has most of the old body of Fcall_process, but with a different API.
371 (call_process): New function that does not open or close filefd if
372 it is nonnegative. Record which fds need to be closed, and let
373 call_process_kill close (and remove the tempfile, on MSDOS) on error.
374 Signal an error if invoked recursively (could be done via a hook).
375 Simplify creation of the tempfile in the MSDOS case.
376 Don't create the output file until after checking for the executable.
377 Report any failure to open /dev/null.
378 Don't open /dev/null for writing twice; once is enough.
379 Don't create pipe if all output is being discarded or sent to file.
380 Don't worry about setting up the coding system or reading from the
381 pipe if all output is being discarded.
382 Hoist fd_error local into top level, to lessen block nesting.
383 Don't record deleted pid here; now done by Fcall_process_region.
384 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
385 and note its success in synch_process_tempfile.
386 Do not leak resources when child_setup fails.
387 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
388 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
389 (create_temp_file): Now returns open fd, with an additional
390 Lisp_Object * argument to return the name. All callers changed.
391 Do not close the file; rewind it instead, and leave it open for
392 the caller. Do not lock the temp file. Unwind-protect the file
393 and the file-descriptor.
394 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
395 If an asynchrounous process, record it here, not in call_process.
396 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
397 * eval.c (set_unwind_protect): New function.
398 * fileio.c (write_region): New function, generalized from the
399 old Fwrite_region. Do not lock temp files.
400 (Fwrite_region): Use it.
401 * lisp.h (set_unwind_protect, write_region): New decls.
402 * process.c: Include <verify.h>.
403 (make_process): Mark fds as initially closed.
404 (deleted_pid_list): Now a list of pid-filename pairs.
405 All uses changed.
406 (close_process_fd): New function.
407 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
408 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
409 New constants. Verify that their number matches PROCESS_OPEN_FDS.
410 (create_process, create_pty, Fmake_serial_process)
411 (server_accept_connection): Record which fds need to be closed,
412 and let deactivate_process close them.
413 (Fmake_network_process): Do not discard the unwind-protect
414 until it's safe to do so.
415 (deactivate_process): Close the fds opened by create_process etc.
416 (Fprocess_send_eof): Adjust to new way of recording open fds.
417 Report an error if /dev/null can't be opened, instead of aborting.
418 * process.h (PROCESS_OPEN_FDS): New constant.
419 (struct Lisp_Process): New member open_fds.
420 (record_kill_process, record_deleted_pid): Adjust signatures.
421 (record_deleted_pid): Move decl here ...
422 * syswait.h (record_deleted_pid): ... from here.
423
d0e615c3
PE
4242013-08-11 Paul Eggert <eggert@cs.ucla.edu>
425
426 * decompress.c: Fix bugs with large buffers and weird inputs.
427 Tune a bit. Reindent as per usual Emacs style.
428 (BUFFER_SIZE): Remove.
429 (Fdecompress_gzipped_region): Do not mishandle input buffers with
430 more than UINT_MAX bytes. Decompress into the gap instead of into
431 an auto buffer, as this should avoid copying. Return nil if
432 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
433 set immediate_quit; we shouldn't trust zlib code that much.
434
313546eb
LMI
4352013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
436
99a32242
LMI
437 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
438 errors, and really move the gap to where we want it.
439
313546eb
LMI
440 * lisp.h: Include decompress.c support.
441
442 * emacs.c (main): Include decompress.c support.
443
444 * Makefile.in: Include -lz if present.
445
d2d699ac
JD
4462013-08-11 Jan Djärv <jan.h.d@swipnet.se>
447
f90e3ebd
JD
448 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
449 (initWithTitle:): Initialize frame to 0.
450 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
451 (fillWithWidgetValue:frame:): Renamed from
452 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
453
454 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
455 fillWithWidgetValue:frame:
456
423d3b3f
JD
457 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
458 remove memory leak warnings.
459
d2d699ac
JD
460 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
461 (ns_check_menu_open): Handle menu == nil. Remove assignment to
462 menu_pending_title.
463
464 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
465 (x_activate_menubar): Update the whole menu.
466 (trackingNotification:): Call ns_check_menu_open if tracking ends.
467 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
468 current event is not NSSystemDefined (Bug#15001).
469 Call ns_check_menu_open only if trackingMenu is 2.
470 (menuDidClose:): New method, decrease trackingMenu.
471 (fillWithWidgetValue:setDelegate:): New method.
472 (fillWithWidgetValue:): Call the above.
473
474 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
475
7d652d97
PE
4762013-08-11 Paul Eggert <eggert@cs.ucla.edu>
477
478 Omit some unnecessary casts.
479 Many of these go back to the old pre-C89 days, when they may have
480 been needed, but we've been assuming C89 or later for a while now.
481 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
482 (live_float_p, live_misc_p, live_vector_p):
483 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
484 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
485 (defvar_per_buffer):
486 * callint.c (Fcall_interactively):
487 * doc.c (Fsubstitute_command_keys):
488 * filelock.c (get_boot_time):
489 * frame.c (xrdb_get_resource):
490 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
491 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
492 (xg_get_file_name_from_selector, menuitem_destroy_callback)
493 (menuitem_highlight_callback, menu_destroy_callback)
494 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
495 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
496 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
497 (xg_tool_bar_help_callback, tb_size_cb):
498 * image.c (xpm_alloc_color, png_read_from_memory)
499 (png_read_from_file, png_load_body, our_memory_skip_input_data)
500 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
501 (syms_of_image):
502 * keymap.c (describe_map):
503 * nsfns.m (Fns_display_monitor_attributes_list):
504 * nsmenu.m (process_dialog:):
505 * nsterm.m (hold_event):
506 * process.c (wait_reading_process_output):
507 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
508 * scroll.c (do_direct_scrolling, scrolling_1):
509 * termcap.c (tgetent):
510 * window.c (check_window_containing, add_window_to_list)
511 (freeze_window_starts):
512 * xdisp.c (compare_overlay_entries, vmessage):
513 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
514 (x_get_monitor_attributes_xrandr)
515 (Fx_display_monitor_attributes_list, x_display_info_for_name)
516 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
517 * xfont.c (xfont_match, xfont_open):
518 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
519 (menubar_selection_callback, menu_position_func)
520 (popup_selection_callback, create_and_show_popup_menu)
521 (dialog_selection_callback, create_and_show_dialog):
522 * xrdb.c (x_get_string_resource):
523 (main) [TESTRM]:
524 * xsmfns.c (x_session_check_input):
525 * xterm.c (x_draw_glyphless_glyph_string_foreground)
526 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
527 (xaw_jump_callback, xaw_scroll_callback):
528 Omit unnecessary casts.
529
9acc1074
PE
5302013-08-10 Paul Eggert <eggert@cs.ucla.edu>
531
532 Minor string-length refactoring.
533 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
534 * frame.c (make_monitor_attribute_list):
535 Prefer build_string to strlen + make_string.
536
361c0eb8
JD
5372013-08-10 Jan Djärv <jan.h.d@swipnet.se>
538
539 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
540 don't check minor_code (Bug#14417).
541
14ba0822
EZ
5422013-08-09 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
545 vertical positions instead. This avoids calling MATRIX_ROW with
546 row numbers that are possibly beyond valid limits. (Bug#15064)
547
309f24d1
DA
5482013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
549
550 Use xstrdup and build_unibyte_string where applicable.
551 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
552 * xfns.c (x_window):
553 * xrdb.c (x_get_customization_string):
554 * xterm.c (xim_initialize):
555 * w32fns.c (w32_window): Use xstrdup.
556 (w32_display_monitor_attributes_list):
557 * emacs.c (init_cmdargs):
558 * keyboard.c (PUSH_C_STR):
559 * nsfont.m (nsfont_open):
560 * sysdep.c (system_process_attributes):
561 * w32.c (system_process_attributes):
562 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
563
55902276
EZ
5642013-08-09 Eli Zaretskii <eliz@gnu.org>
565
566 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
567 variables of these types so that GDB would know about them, as aid
568 for debugging fatal exceptions. (Bug#15024) See also
569 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
570 discussions.
571
10bf7f5a
JD
5722013-08-08 Jan Djärv <jan.h.d@swipnet.se>
573
574 * nsterm.m (ns_update_begin): Don't change clip path if it would be
575 larger than the NSWindow (Bug#14934).
576
65620264
DA
5772013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
578
579 Redesign redisplay interface to drop global variable updated_window.
580 Always pass currently updated window as a parameter to update routines.
581 * dispextern.h (updated_window): Remove declaration.
582 (struct redisplay_interface): Pass window parameter to
583 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
584 and after_update_window_hook.
585 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
586 Adjust prototypes.
587 * dispnew.c (updated_window): Remove.
588 (redraw_overlapped_rows, update_marginal_area, update_text_area)
589 (update_window_line): Adjust to match redisplay interface changes.
590 * nsterm.m (ns_update_window_begin, ns_update_window_end)
591 (ns_scroll_run, ns_after_update_window_line):
592 * w32term.c (x_update_window_begin, x_update_window_end)
593 (x_after_update_window_line, x_scroll_run):
594 * xterm.c (x_update_window_begin, x_update_window_end)
595 (x_after_update_window_line, x_scroll_run):
596 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
597 Likewise. Adjust comments where appropriate.
598 (x_cursor_to): Simplify because this is always called during window
599 update (but install debugging check anyway).
600 (expose_window): Check must_be_updated_p flag to see whether this
601 function is called during window update.
602
628fdc56
DA
6032013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Do not reset window modification event counters excessively.
606 These leftovers and poor man's tricky methods to catch extra
607 redisplay's attention are no longer needed.
608 * frame.c (set_menu_bar_lines_1):
609 * minibuf.c (read_minibuf_unwind):
610 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
611 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
612 (window_scroll_line_based, Fset_window_configuration):
613 * xdisp.c (redisplay_window): Do not reset last_modified and
614 last_overlay_modified counters.
615
8fd9c92e
JD
6162013-08-07 Jan Djärv <jan.h.d@swipnet.se>
617
618 * xselect.c (x_send_client_event): Set send_event and serial, memset
619 data.l as it might be bigger than data.b. Use 24 bit mask to
620 XSendEvent (Bug#15034).
621
0ee18172
EZ
6222013-08-07 Eli Zaretskii <eliz@gnu.org>
623
624 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
625 for TTY frames that are not the top frame on their console.
626 (Bug#14616)
627
16ddd1a6
MR
6282013-08-07 Martin Rudalics <rudalics@gmx.at>
629
630 * w32term.c (w32fullscreen_hook): Really maximize frame when
631 asked for (Bug#14841).
632
d2a95ffb
DA
6332013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Prefer selected_window to Fselected_window, likewise for frames.
636 * buffer.c (Fbuffer_swap_text):
637 * data.c (Fvariable_binding_locus):
638 * window.c (run_window_configuration_change_hook): Adjust users.
639 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
640 Use decode_live_frame.
641
170da1ec
DA
6422013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
643
644 Be more careful if selected window shows the buffer other than current,
645 use window_outdated only if this is not so. This change should also
646 address some weird issues discussed in Bug#13012.
647 * window.h (window_outdated): New prototype.
648 * window.c (window_outdated): Now here. Convert from static and
649 always assume window's buffer.
650 (Fwindow_end, Fwindow_line_height): Use it.
651 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
652 and always assume window's buffer.
653 (redisplay_window): Adjust user.
e5eefe9b 654 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
655 check whether mode line should be updated only if selected window
656 shows current buffer.
657 (run_window_scroll_functions): Use eassert for debugging check.
658 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
659
56b5d5b1
DA
6602013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
661
662 * window.c (window_scroll, window_scroll_pixel_based)
663 (window_scroll_line_based): Use bool for booleans.
664
2878ba7e
PE
6652013-08-06 Paul Eggert <eggert@cs.ucla.edu>
666
667 * process.c: Fix minor off-by-one issues in descriptor counts.
668 This shouldn't fix any real bugs, but it cleans up the code a bit.
669 (max_process_desc, max_input_desc): -1, not 0, means none.
670 All uses changed.
671 (delete_input_desc): New function.
672 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
673 (deactivate_process): Scan backwards when recomuting max_process_desc;
674 that should be faster.
675 (init_process_emacs): Initialize max_input_desc.
676
e30b79c1
DA
6772013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Use region cache to speedup bidi_find_paragraph_start.
680 * buffer.h (struct buffer): New member bidi_paragraph_cache.
681 Rename cache_long_line_scans to cache_long_scans.
682 * buffer.c (bset_cache_long_line_scans): Rename to
683 bset_cache_long_scans.
684 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
685 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
686 into account.
687 (syms_of_buffer): Rename cache-long-line-scans to
688 cache-long-scans. Adjust docstring.
689 * search.c (newline_cache_on_off):
690 * indent.c (width_run_cache_on_off): Adjust users.
691 * bidi.c (bidi_paragraph_cache_on_off): New function.
692 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
693 * insdel.c (prepare_to_modify_buffer): Invalidate
694 bidi_paragraph_cache if enabled.
695
00012b86
DA
6962013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
697
698 Invalidate region caches only if buffer text is going to be changed.
699 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
700 (modify_text): ...new prototype.
701 (prepare_to_modify_buffer_1): New prototype.
702 * textprop.c (modify_region): Rename to...
703 (modify_text_properties): ...new function.
704 (add_text_properties_1, set_text_properties, Fremove_text_properties)
705 (Fremove_list_of_text_properties): Adjust users.
706 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
707 (modify_text): ...new function.
708 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
709 (prepare_to_modify_buffer_1): ...new function.
710 * casefiddle.c (casify_region):
711 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
712 (Ftranspose_regions): Use modify_text.
713
dc6c0eda
SM
7142013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
715
716 * lisp.mk (lisp): Add nadvice.elc.
717
8f3a2c26
DA
7182013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
719
720 New macro to iterate over live buffers similar to frames.
721 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
722 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
723 Declare buffer-related variables here to offload lisp.h.
724 * buffer.c (Vbuffer_alist): Adjust comment.
725 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
726 (other_buffer_safely):
727 * data.c (store_symval_forwarding):
728 * dispnew.c (Fframe_or_buffer_changed_p):
729 * fileio.c (Fdo_auto_save):
730 * filelock.c (unlock_all_files):
731 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
732
e0fdb694
PE
7332013-08-04 Paul Eggert <eggert@cs.ucla.edu>
734
735 Fix some minor races in hosts lacking mkostemp (Bug#15015).
736 * callproc.c (create_temp_file):
737 * filelock.c (create_lock_file):
738 Assume mkostemp, since it's now provided by Gnulib.
739
63f5c6c2
EZ
7402013-08-04 Eli Zaretskii <eliz@gnu.org>
741
742 * w32.c (mkostemp): New function.
743 (mktemp): Remove, no longer used. Most of the code reused in
744 mkostemp. (Bug#15015)
484ab239 745 (mktemp): Don't undef.
63f5c6c2 746
f0b79313
DA
7472013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
748
749 * dispnew.c (glyph_matrix_count, glyph_pool_count):
750 Move under GLYPH_DEBUG and ENABLE_CHECKING.
751 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
752 (free_glyph_pool, check_glyph_memory): Likewise for
753 all users. Adjust comments where appropriate.
754
98f638d6
PE
7552013-08-03 Paul Eggert <eggert@cs.ucla.edu>
756
757 * composite.h: Minor fixups.
758 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
759 to fix a misspelling, and change it to an inline function while
760 we're at it (it need not be a macro). All uses changed.
761 (composition_method, composition_valid_p):
762 Rewrite to avoid assignments in if-conditions.
763
75c59fb3
DA
7642013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
765
766 Do not use global Lisp_Object in composition macros.
767 * composite.h (composition_temp): Remove declaration.
768 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
769 (composition_method, composition_valid_p): ...inline functions.
416a3e01 770 (compose_region): Remove the leftover.
75c59fb3
DA
771 * composite.c (composition_temp): Remove.
772 (run_composition_function, update_compositions)
773 (composition_compute_stop_pos, composition_adjust_point)
774 (Ffind_composition_internal):
775 * coding.c (handle_composition_annotation):
776 * xdisp.c (handle_composition_prop, check_point_in_composition):
777 Related users changed.
778
a10c8269
DA
7792013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
780
781 Drop FRAME_PTR typedef.
782 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
783 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
784 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
785 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
786 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
787 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
788 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
789 All related users changed.
790
a104f656
SM
7912013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 * eval.c (default_toplevel_binding): New function.
794 (Fdefvar): Use it.
795 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
796 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
797 (syms_of_eval): Export them.
798 * data.c (Fdefault_value): Micro cleanup.
799 * term.c (init_tty): Use "false".
800
4b5c9326
DA
8012013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
802
803 Fix X GC leak in GTK and raw (no toolkit) X ports.
804 * xterm.c (x_free_frame_resources): If white and black relief
805 GCs are allocated, always free them here.
806 * xfns.c (x_make_gc): Omit redundant initialization.
807 * widget.c (create_frame_gcs): Remove the leftover.
808 (EmacsFrameDestroy): Do nothing because all GCs are now freed
809 in x_free_frame_resources.
810
b19aa636
JD
8112013-08-02 Jan Djärv <jan.h.d@swipnet.se>
812
813 * nsterm.m (windowWillResize:toSize:): Only change title if
814 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
815 modifying it.
816 (viewDidEndLiveResize): New method.
817
818 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
819 inside NS_IMPL_COCOA.
820
af1f7e06
DA
8212013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
822
823 * insdel.c (adjust_after_replace, replace_range, del_range_2):
824 Do not check whether undo is enabled because record_insert and
825 record_delete does that themselves.
826
65b02bb9
DA
8272013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
828
829 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
830 member which is not really used any more.
831 (FRAME_XIC_BASE_FONTNAME): Remove.
832 * xfns.c (xic_free_fontset): Adjust user.
833 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
834 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
835 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
836 (xdialog_show): Use eassert for debugging check.
7ee0f047 837 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 838
6318cde0
PE
8392013-08-01 Paul Eggert <eggert@cs.ucla.edu>
840
841 * fileio.c, fns.c (merge): Move extern decl from here ...
842 * lisp.h (merge): ... to here.
843
6c1a09ba
DA
8442013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
845
846 Fix last font-related change.
847 * w32font.h (w32font_list_internal, w32font_match_internal):
848 Fix prototype.
849 * w32uniscribe.c (uniscribe_list, uniscribe_match):
850 (uniscribe_list_family): Adjust to match font API change.
851 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
852 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
853
f8c20208
DA
8542013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
855
856 * frame.h (FRAME_MOUSE_UPDATE):
857 * nsterm.m (ns_frame_up_to_date): Omit redundant check
858 whether hlinfo->mouse_face_mouse_frame is non-NULL.
859
fdb396e2
DA
8602013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
861
862 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
863 * font.h (struct font_driver): Change list, match, and list_family
864 functions to accept struct frame * as first arg.
865 * font.c (font_score, font_compare, font_sort_entities): Remove
866 prototypes.
867 (font_sort_entities, font_list_entities, font_select_entity):
868 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
869 match font API change.
870 * xfont.c (xfont_list, xfont_match, xfont_list_family):
871 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
872 * ftxfont.c (ftxfont_list, ftxfont_match):
873 * xftfont.c (xftfont_list, xftfont_match):
874 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
875 * w32font.c (w32font_list, w32font_match, w32font_list):
876 (w32font_list_internal, w32_font_match_internal): Likewise.
877 * xfaces.c (Fx_family_fonts): Adjust user.
878
52b8a085
DA
8792013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
880
881 Do not use pure Xism x_wm_set_icon_position in non-X ports.
882 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
883 only if HAVE_X_WINDOWS is in use.
884 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
885 * nsterm.m (x_wm_set_icon_position): Remove no-op.
886 * w32term.c (x_wm_set_icon_position): Likewise.
887 * w32fns.c (x_icon): Adjust user.
888
c791c18e
DA
8892013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
890
891 * xterm.c (last_mouse_press_frame): Remove the
892 leftover which is not really used any more.
893 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
894 (x_flush): Call XFlush once per each X display, not frame.
895 This is better because this code always unconditionally skips
896 non-X frames in Vframe_list and issues the only XFlush if we
897 have more than one X frame on the same X display.
2f935d86
DA
898 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
899 Use bool for booleans.
900 (x_draw_glyph_string_background, cvt_string_to_pixel):
901 (cvt_pixel_dtor): Drop unnecessary prototypes.
902 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 903
f435830e
DA
9042013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
905
906 Drop unnecessary functions that deals with frame pixel size.
907 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
908 (x_pixel_height): Drop prototypes.
909 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
910 (x_pixel_height): Drop implementations.
911 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
912 which should be always valid for window frame.
913 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
914 * w32menu.c (Fx_popup_dialog):
915 * xmenu.c (Fx_popup_dialog): Likewise for both.
916
84231434
DA
9172013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
918
919 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
920 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
921 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
922 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
923 and mention nil frame in docstring.
84231434 924
959067a1
DA
9252013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
926
927 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
928 (x_figure_window_size): Likewise. Adjust to return long.
929 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
930 (toplevel): Move Qterminal_live_p to...
931 * terminal.c (toplevel): ...here, make it static, and...
932 (syms_of_terminal): ...DEFSYM here.
933 * frame.h (Qterminal_live_p): Remove declaration.
934 (make_frame, x_figure_window_size): Adjust prototype.
935 * nsfns.m (Fx_create_frame): Use long for window flags.
936
f4b169ce
PE
9372013-07-30 Paul Eggert <eggert@cs.ucla.edu>
938
939 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
940 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
941 Do not assume that emacs_close (INT_MAX) is a no-op.
942
bee6a2c7
DA
9432013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
944
945 * xfaces.c (make_face_cache): For struct face_cache, prefer
946 xmalloc to xzalloc and so avoid redundant call to memset.
947 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
948
d7e6881a
DA
9492013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
950
951 * fringe.c (draw_window_fringes, update_window_fringes)
952 (compute_fringe_widths):
953 * w32term.c (x_draw_glyph_string):
954 * window.c (candidate_window_p, Frecenter):
955 * xfaces.c (realize_basic_faces, realize_default_face)
956 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
957 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
958 * xfns.c (x_set_cursor_color, xic_free_xfontset):
959 * xmenu.c (Fx_menu_bar_open_internal):
960 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
961 * xsettings.c (xft_settings_event):
962 * xterm.c (x_draw_glyph_string, x_had_errors_p):
963 Use bool for booleans. Adjust style and comments where
964 appropriate.
965 * dispextern.h (draw_window_fringes, update_window_fringes)
966 (compute_fringe_widths):
967 * xterm.h (x_had_errors_p): Adjust prototype.
968
ec3058af
DA
9692013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
970
971 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
972 CHECK_LIST. Rewrite the loop to avoid useless local variable.
973
218e0637
DA
9742013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
975
976 * fns.c (toplevel): Remove comment before Fsafe_length because
977 it checks for QUIT.
978
e560aba9
PE
9792013-07-28 Paul Eggert <eggert@cs.ucla.edu>
980
981 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
982
2e5ce5de
EZ
9832013-07-28 Eli Zaretskii <eliz@gnu.org>
984
985 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
986 frame which got the message is still alive, before dereferencing
987 its pointer. (Bug#14970)
988
989 * frame.c (delete_frame): Test "this" frame's minibuffer window to
990 be a live window, before using it as such. (Bug#14970)
991
e95da6d3
EZ
9922013-07-27 Eli Zaretskii <eliz@gnu.org>
993
994 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
995 w32_detect_focus_change instead of doing part of its job by hand.
996 This fixes the problem whereby FOCUS_OUT events were not sent to
997 the event queue.
998
a8f93651
EZ
9992013-07-26 Eli Zaretskii <eliz@gnu.org>
1000
fec92060
EZ
1001 * process.c (Fprocess_list): Doc fix.
1002
a8f93651
EZ
1003 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1004 being re-exposed only if it didn't ask to become visible.
1005 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1006 was previously iconified. (Bug#14841)
1007 (x_iconify_frame): Mark the frame iconified.
1008
d5a7a9d9
PE
10092013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 Fix minor problems found by static checking.
1012 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1013 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1014
56ea7291
SM
10152013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1016
1017 * eval.c (set_specpdl_old_value): New function.
1018 (unbind_to): Minor simplification.
1019 (get_backtrace_frame): New function.
1020 (Fbacktrace_frame): Use it. Add `base' argument.
1021 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1022 (syms_of_eval): Export backtrace-eval.
1023 * xterm.c (x_focus_changed): Simplify.
1024
9d611ffe
PE
10252013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1026
1027 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1028
999c74e3
EZ
10292013-07-24 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (redisplay_window): Instead of moving point out of
1032 scroll margin, reject the force_start method, and try scrolling
1033 instead. (Bug#14780)
1034
198fa217
KB
10352013-07-24 Ken Brown <kbrown@cornell.edu>
1036
1037 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1038 (Bug#14944).
1039
53840e55
PE
10402013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1041
1042 * eval.c (Fprogn): Do not check that BODY is a proper list.
1043 This undoes the previous change. The check slows down the
1044 interpreter, and is not needed to prevent a crash. See
1045 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1046
60967f56
GM
10472013-07-23 Glenn Morris <rgm@gnu.org>
1048
1049 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1050
9ca960e2
PE
10512013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1052
a29c3e6d
PE
1053 Port to GNU/Linux systems with tinfo but not ncurses.
1054 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1055 to decide whether ncurses is being used. Without this change,
1056 GCC complains about tgetent not being declared, on a system
1057 that has tinfo installed but ncurses not installed.
1058
f274311c
PE
1059 * eval.c (Fprogn): Check that BODY is a proper list.
1060
16b0520a
PE
1061 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1062 * data.c (Fsetq_default):
1063 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1064 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1065 (Fcondition_case):
1066 Tune by taking advantage of the fact that ARGS is always a list
1067 when a function is declared to have UNEVALLED args.
1068
9ca960e2
PE
1069 * emacsgtkfixed.c: Port to GCC 4.6.
1070 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1071
afacaa1b
JB
10722013-07-23 Juanma Barranquero <lekktu@gmail.com>
1073
1074 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1075 here to silence compiler warnings.
1076
368a85a4
PE
10772013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1078
1079 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1080 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1081 from messing up Emacs's 'struct frame' (Bug#14923).
1082
f4e891b5
PE
10832013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 * alloc.c (make_save_ptr_ptr): Define this function.
1086 It was inadvertently omitted. It's needed only if
1087 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1088
96c8b65e
JD
10892013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1090
1091 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1092 frame have focus (Bug#14895).
1093
ee010797
PE
10942013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 Avoid vfork-related deadlock more cleanly.
1097 * callproc.c (child_setup): When the child's exec fails, output
1098 the program name, as that's more useful. Use O_NONBLOCK to avoid
1099 deadlock.
1100 * process.c (create_process_1): Remove; no longer needed.
1101 (create_process): Remove timer hack; no longer needed, now that
1102 the child avoids deadlock.
1103
f0398ec1 11042013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1105
1106 * image.c (Fimage_flush): Fix doc typo.
1107
b2a069c2
PE
11082013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1109
6496aec9
PE
1110 Fix array bounds violation when pty allocation fails.
1111 * process.c (PTY_NAME_SIZE): New constant.
1112 (pty_name): Remove static variable; it's now auto.
1113 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1114 Take pty_name as an arg rather than using a static variable.
1115 All callers changed.
1116 (create_process): Recover pty_flag from process, not from volatile local.
1117 (create_pty): Stay inside array even when pty allocation fails.
1118 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1119
b2a069c2
PE
1120 * lread.c (Fload): Avoid initialization only when lint checking.
1121 Mention that it's needed only for older GCCs.
1122
99107004
KH
11232013-07-20 Kenichi Handa <handa@gnu.org>
1124
1125 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1126 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1127
6b1b199d
AS
11282013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1129
1130 * lread.c (Fload): Avoid uninitialized warning.
1131
4195afc3
PE
11322013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1133
3f5bef16
PE
1134 Fix some minor file descriptor leaks and related glitches.
1135 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1136 (create_lock_file): Use write, not emacs_write.
1137 * image.c (slurp_file, png_load_body):
1138 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1139 (server_accept_connection):
1140 Don't leak an fd on memory allocation failure.
1141 * image.c (slurp_file): Add a cheap heuristic for growing files.
1142 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1143 as that's what the other routines do. Maybe input need not be
1144 blocked at all, but it's better to be consistent.
1145 Avoid undefined behavior when strlen is zero.
1146
4195afc3
PE
1147 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1148 (NSTATICS): Now a constant; doesn't need to be a macro.
1149
a1aeeffe
RS
11502013-07-19 Richard Stallman <rms@gnu.org>
1151
1152 * coding.c (decode_coding_utf_8): Add simple loop for fast
1153 processing of ASCII characters.
1154
63b34baa
PE
11552013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1158
621dd9ac
EZ
11592013-07-19 Eli Zaretskii <eliz@gnu.org>
1160
1161 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1162 unportable 'struct x_display_info'.
1163 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1164 is a portable type.
1165
1396ac86
PE
11662013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1167
ab9980cd
PE
1168 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1169 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1170 or fscanf fails.
1171 (system_process_attributes): Prefer plain char to unsigned char
1172 when either will do. Clean up properly if interrupted or if
1173 memory allocations fail. Don't assume sscanf succeeds. Remove
1174 no-longer-needed workaround to stop GCC from whining. Read
1175 command-line once, instead of multiple times. Check read status a
1176 bit more carefully.
1177
1396ac86
PE
1178 Fix obscure porting bug with varargs functions.
1179 The code assumed that int is treated like ptrdiff_t in a vararg
1180 function, which is not a portable assumption. There was a similar
1181 -- though these days less likely -- porting problem with various
1182 assumptions that pointers of different types all smell the same as
1183 far as vararg functions is conserved. To make this problem less
1184 likely in the future, redo the API to use varargs functions.
1185 * alloc.c (make_save_value): Remove this vararg function.
1186 All uses changed to ...
1187 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1188 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1189 New functions.
1190 (make_save_ptr): Rename from make_save_pointer, for consistency with
1191 the above. Define only on platforms that need it. All uses changed.
1192
4d19d194
PE
11932013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 * keyboard.c: Try to fix typos in previous change.
1196 (DISPLAY_LIST_INFO): New macro.
1197 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1198 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1199
945c5bb1
JB
12002013-07-18 Juanma Barranquero <lekktu@gmail.com>
1201
1202 * keyboard.c (kbd_buffer_get_event):
1203 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1204 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1205
f4b1eb36
PE
12062013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1207
5e679a2c
PE
1208 * filelock.c: Fix unlikely file descriptor leaks.
1209 (get_boot_time_1): Rework to avoid using emacs_open.
1210 This doesn't actually fix a leak, but is better anyway.
1211 (read_lock_data): Use read, not emacs_read.
1212
a8cd4836
PE
1213 * doc.c: Fix minor memory and file descriptor leaks.
1214 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1215 (get_doc_string, Fsnarf_documentation):
1216 Fix file descriptor leak on error.
1217
ef30e638
PE
1218 * term.c: Fix minor fdopen-related file descriptor leaks.
1219 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1220 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1221
f4b1eb36
PE
1222 * charset.c: Fix file descriptor leaks and errno issues.
1223 Include <errno.h>.
1224 (load_charset_map_from_file): Don't leak file descriptor on error.
1225 Use plain record_xmalloc since the allocation is larger than
1226 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1227 of entries.
1228 * eval.c (record_unwind_protect_nothing):
1229 * fileio.c (fclose_unwind):
1230 New functions.
1231 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1232 The replacement doesn't block input, but that no longer seems
1233 necessary.
1234
b648c163
PE
12352013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1236
a0931322
PE
1237 * lread.c: Fix file descriptor leaks and errno issues.
1238 (Fload): Close some races that leaked fds or streams when 'load'
1239 was interrupted.
1240 (Fload, openp): Report error number of last nontrivial failure to open.
1241 ENOENT counts as trivial.
1242 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1243 New functions.
1244 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1245 now that the function is always called with a nonnegative arg.
1246 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1247 All uses replaced with ...
1248 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1249
b648c163
PE
1250 A few more minor file errno-reporting bugs.
1251 * callproc.c (Fcall_process):
1252 * doc.c (Fsnarf_documentation):
1253 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1254 * process.c (set_socket_option):
1255 Don't let a constructor trash errno.
1256 * doc.c: Include <errno.h>.
1257
b1dc4084
JB
12582013-07-16 Juanma Barranquero <lekktu@gmail.com>
1259
1260 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1261
c43843aa
PE
12622013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1263
50a30cce
PE
1264 Fix w32 bug with call-process-region (Bug#14885).
1265 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1266 to Fcall_process when the input is empty. This simplifies the
1267 code a bit. It makes no difference on POSIXish platforms but
1268 apparently it fixes a bug on w32.
1269
44e18199 1270 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1271 * fileio.c (close_file_unwind): Don't close if FD is negative;
1272 this can happen when unwinding a zapped file descriptor.
1273 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1274 in case Emacs runs out of memory between the two unwind-protects.
1275 Don't trash errno when closing FD.
1276 Zap the FD in the specpdl when closing it, instead of deferring
1277 the removal of the unwind-protect; this fixes a bug where a child
1278 function unwinds the stack past us.
1279
27e498e6
PE
1280 New unwind-protect flavors to better type-check C callbacks.
1281 This also lessens the need to write wrappers for callbacks,
1282 and the need for make_save_pointer.
1283 * alloca.c (free_save_value):
1284 * atimer.c (run_all_atimers):
1285 Now extern.
1286 * alloc.c (safe_alloca_unwind):
1287 * atimer.c (unwind_stop_other_atimers):
1288 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1289 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1290 * minibuf.c (choose_minibuf_frame_1):
1291 * process.c (make_serial_process_unwind):
1292 * xdisp.h (pop_message_unwind):
1293 * xselect.c (queue_selection_requests_unwind):
1294 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1295 * alloca.c (record_xmalloc):
1296 Prefer record_unwind_protect_ptr to record_unwind_protect with
1297 make_save_pointer.
1298 * alloca.c (Fgarbage_collect):
1299 Prefer record_unwind_protect_void to passing a dummy.
1300 * buffer.c (restore_buffer):
1301 * window.c (restore_window_configuration):
1302 * xfns.c, w32fns.c (do_unwind_create_frame)
1303 New wrapper. All record-unwind uses of wrappee changed.
1304 * buffer.c (set_buffer_if_live):
1305 * callproc.c (call_process_cleanup, delete_temp_file):
1306 * coding.c (code_conversion_restore):
1307 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1308 * editfns.c (save_excursion_restore)
1309 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1310 (save_restriction_restore):
1311 * eval.c (restore_stack_limits, un_autoload):
1312 * fns.c (require_unwind):
1313 * keyboard.c (recursive_edit_unwind, tracking_off):
1314 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1315 * macros.c (pop_kbd_macro, restore_menu_items):
1316 * nsfns.m (unwind_create_frame):
1317 * print.c (print_unwind):
1318 * process.c (start_process_unwind):
1319 * search.c (unwind_set_match_data):
1320 * window.c (select_window_norecord, select_frame_norecord):
1321 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1322 (fast_set_selected_frame):
1323 * xfns.c, w32fns.c (unwind_create_tip_frame):
1324 Return void, not a dummy Lisp_Object. All uses changed.
1325 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1326 * callproc.c (call_process_kill):
1327 * fileio.c (restore_point_unwind, decide_coding_unwind)
1328 (build_annotations_unwind):
1329 * insdel.c (Fcombine_after_change_execute_1):
1330 * keyboard.c (read_char_help_form_unwind):
1331 * menu.c (unuse_menu_items):
1332 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1333 * sound.c (sound_cleanup):
1334 * xdisp.c (unwind_redisplay):
1335 * xfns.c (clean_up_dialog):
1336 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1337 Accept no args and return void, instead of accepting and returning
1338 a dummy Lisp_Object. All uses changed.
1339 * cygw32.c (fchdir_unwind):
1340 * fileio.c (close_file_unwind):
1341 * keyboard.c (restore_kboard_configuration):
1342 * lread.c (readevalllop_1):
1343 * process.c (wait_reading_process_output_unwind):
1344 Accept int and return void, rather than accepting an Emacs integer
1345 and returning a dummy object. In some cases this fixes an
1346 unlikely bug when the corresponding int is outside Emacs integer
1347 range. All uses changed.
1348 * dired.c (directory_files_internal_unwind):
1349 * fileio.c (do_auto_save_unwind):
1350 * gtkutil.c (pop_down_dialog):
1351 * insdel.c (reset_var_on_error):
1352 * lread.c (load_unwind):
1353 * xfns.c (clean_up_file_dialog):
1354 * xmenu.c, nsmenu.m (pop_down_menu):
1355 * xmenu.c (cleanup_widget_value_tree):
1356 * xselect.c (wait_for_property_change_unwind):
1357 Accept pointer and return void, rather than accepting an Emacs
1358 save value encapsulating the pointer and returning a dummy object.
1359 All uses changed.
1360 * editfns.c (Fformat): Update the saved pointer directly via
1361 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1362 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1363 (unwind_body): New function.
1364 (record_unwind_protect): First arg is now a function returning void,
1365 not a dummy Lisp_Object.
1366 (record_unwind_protect_ptr, record_unwind_protect_int)
1367 (record_unwind_protect_void): New functions.
1368 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1369 * fileio.c (struct auto_save_unwind): New type.
1370 (do_auto_save_unwind): Use it.
1371 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1372 * insdel.c (struct rvoe_arg): New type.
1373 (reset_var_on_error): Use it.
1374 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1375 New constants.
1376 (specbinding_func): Remove; there are now several such functions.
1377 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1378 (set_unwind_protect_ptr): New function.
1379 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1380
4e604a5d
PE
1381 Be simpler and more consistent about reporting I/O errors.
1382 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1383 Say "Read error" and "Write error", rather than "I/O error", or
1384 "IO error reading", or "IO error writing", when a read or write
1385 error occurs.
1386 * process.c (Fmake_network_process, wait_reading_process_output)
1387 (send_process, Fprocess_send_eof, wait_reading_process_output):
1388 Capitalize diagnostics consistently. Put "failed foo" at the
1389 start of the diagnostic, so that we don't capitalize the
1390 function name "foo". Consistently say "failed" for such
1391 diagnostics.
1392 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1393 All callers changed. This is so it can use report_file_error.
1394 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1395 diagnostics consistently as above.
1396
a9757f6a
PE
1397 * fileio.c (report_file_errno): Fix errno reporting bug.
1398 If the file name is neither null nor a pair, package it up as a
1399 singleton list. All callers changed, both to this function and to
1400 report_file_error. This fixes a bug where the memory allocator
1401 invoked by list1 set errno so that the immediately following
1402 report_file_error reported the wrong errno value.
1403
c43843aa
PE
1404 Fix minor problems found by --enable-gcc-warnings.
1405 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1406 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1407
18c26d81
JD
14082013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1409
1410 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1411 Set event->arg to Qt if switch-event shall be generated.
1412 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1413
1414 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1415
1416 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1417 FOCUS_OUT_EVENT.
1418
1419 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1420 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1421 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1422 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1423 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1424 and there is a focused frame.
1425 (head_table): Add focus-in and focus-out.
1426 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1427 bind to handle-focus-in/out.
1428
1429 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1430 (Fhandle_switch_frame): Call Fhandle_focus_in.
1431 (syms_of_frame): defsubr handle-focus-in/out.
1432
6c6f1994
PE
14332013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1434
c7ddc792
PE
1435 Fix porting bug to older POSIXish platforms (Bug#14862).
1436 * sysdep.c (emacs_pipe): New function, that implements
1437 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1438 This should port better to CentOS 5 and to Mac OS X 10.6.
1439 All calls to pipe2 changed.
1440
6c6f1994
PE
1441 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1442 This makes the code easier to read and the executable a bit smaller.
1443 Do not replace all calls to Fcons that happen to create lists,
1444 just calls that are intended to create lists. For example, when
1445 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1446 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1447 Similarly for list2 through list5.
1448 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1449 * bytecode.c (exec_byte_code):
1450 * callint.c (quotify_arg, Fcall_interactively):
1451 * callproc.c (Fcall_process, create_temp_file):
1452 * charset.c (load_charset_map_from_file)
1453 (Fdefine_charset_internal, init_charset):
1454 * coding.c (get_translation_table, detect_coding_system)
1455 (Fcheck_coding_systems_region)
1456 (Fset_terminal_coding_system_internal)
1457 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1458 * composite.c (update_compositions, Ffind_composition_internal):
1459 * dired.c (directory_files_internal, file_name_completion)
1460 (Fsystem_users):
1461 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1462 * doc.c (Fsnarf_documentation):
1463 * editfns.c (Fmessage_box):
1464 * emacs.c (main):
1465 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1466 (Feval, eval_sub, Ffuncall, apply_lambda):
1467 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1468 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1469 (Fset_file_times, Finsert_file_contents)
1470 (Fchoose_write_coding_system, Fwrite_region):
1471 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1472 * font.c (font_registry_charsets, font_parse_fcname)
1473 (font_prepare_cache, font_update_drivers, Flist_fonts):
1474 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1475 * frame.c (make_frame, Fmake_terminal_frame)
1476 (x_set_frame_parameters, x_report_frame_params)
1477 (x_default_parameter, Fx_parse_geometry):
1478 * ftfont.c (syms_of_ftfont):
1479 * image.c (gif_load):
1480 * keyboard.c (command_loop_1):
1481 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1482 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1483 (Fminor_mode_key_binding, accessible_keymaps_1)
1484 (Faccessible_keymaps, Fwhere_is_internal):
1485 * lread.c (read_emacs_mule_char):
1486 * menu.c (find_and_return_menu_selection):
1487 * minibuf.c (get_minibuffer):
1488 * nsfns.m (Fns_perform_service):
1489 * nsfont.m (ns_script_to_charset):
1490 * nsmenu.m (ns_popup_dialog):
1491 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1492 (Fx_own_selection_internal):
1493 * nsterm.m (append2):
1494 * print.c (Fredirect_debugging_output)
1495 (print_prune_string_charset):
1496 * process.c (Fdelete_process, Fprocess_contact)
1497 (Fformat_network_address, set_socket_option)
1498 (read_and_dispose_of_process_output, write_queue_push)
1499 (send_process, exec_sentinel):
1500 * sound.c (Fplay_sound_internal):
1501 * textprop.c (validate_plist, add_properties)
1502 (Fput_text_property, Fadd_face_text_property)
1503 (copy_text_properties, text_property_list, syms_of_textprop):
1504 * unexaix.c (report_error):
1505 * unexcoff.c (report_error):
1506 * unexsol.c (unexec):
1507 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1508 (Fformat_mode_line, syms_of_xdisp):
1509 * xfaces.c (set_font_frame_param)
1510 (Finternal_lisp_face_attribute_values)
1511 (Finternal_merge_in_global_face, syms_of_xfaces):
1512 * xfns.c (x_default_scroll_bar_color_parameter)
1513 (x_default_font_parameter, x_create_tip_frame):
1514 * xfont.c (xfont_supported_scripts):
1515 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1516 (menu_help_callback, xmenu_show):
1517 * xml.c (make_dom):
1518 * xterm.c (set_wm_state):
1519 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1520 and similarly for list2 through list5.
1521
bafe80ce
PE
15222013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * callproc.c (Fcall_process_region): Fix minor race and tune.
1525 (create_temp_file): New function, with the temp-file-creation part
1526 of the old Fcall_process_region. Use Fcopy_sequence to create the
1527 temp file name, rather than alloca + build_string, for simplicity.
1528 Don't bother to block input around the temp file creation;
1529 shouldn't be needed. Simplify use of mktemp. Use
1530 record_unwind_protect immediately after creating the temp file;
1531 this closes an unlikely race where the temp file was not removed.
1532 Use memcpy rather than an open-coded loop.
1533 (Fcall_process_region): Use the new function. If the input is
1534 empty, redirect from /dev/null rather than from a newly created
1535 empty temp file; this avoids unnecessary file system traffic.
1536
4700b5a5
PE
15372013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1538
5c97beae
PE
1539 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1540 Simplify by making this case like the other two. This is a bit
1541 slower on obsolete hosts, but the extra complexity isn't worth it.
1542
4700b5a5
PE
1543 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1544 * process.c (create_process) [!DOS_NT]:
1545 Remove now-unnecessary calls to emacs_close.
1546
f9a74c4c
EZ
15472013-07-13 Eli Zaretskii <eliz@gnu.org>
1548
922ae7ee
EZ
1549 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1550 returning early. (Bug#14850)
1551
f9a74c4c
EZ
1552 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1553 and inhibit-iso-escape-detection attributes of 'undecided'.
1554 (Bug#14822)
1555
5e301d76
PE
15562013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1557
69e0e5ee
PE
1558 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1559 Reported by Herbert J. Skuhra in
1560 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1561
5e301d76
PE
1562 Don't lose top specpdl entry when memory is exhausted.
1563 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1564 specpdl overflow here, to simplify callers; all callers changed.
1565 Always reserve an unused entry at the stack top; this avoids
1566 losing the top entry's information when memory is exhausted.
1567
7e649856
PE
15682013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1569
a773ed9a
PE
1570 Clean up errno reporting and fix some errno-reporting bugs.
1571 * callproc.c (Fcall_process):
1572 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1573 * process.c (create_process, Fmake_network_process):
1574 * unexaix.c (report_error):
1575 * unexcoff.c (report_error):
1576 Be more careful about reporting the errno of failed operations.
1577 The code previously reported the wrong errno sometimes.
1578 Also, prefer report_file_errno to setting errno + report_file_error.
1579 (Fcall_process): Look at openp return value rather than at path,
1580 as that's a bit faster and clearer when there's a numeric predicate.
1581 * fileio.c (report_file_errno): New function, with most of the
1582 old contents of report_file_error.
1583 (report_file_error): Use it.
1584 (Ffile_exists_p, Ffile_accessible_directory_p):
1585 Set errno to 0 when it is junk.
1586 * fileio.c (Faccess_file):
1587 * image.c (x_create_bitmap_from_file):
1588 Use faccessat rather than opening the file, to avoid the hassle of
1589 having a file descriptor open.
1590 * lisp.h (report_file_errno): New decl.
1591 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1592
7e649856
PE
1593 Minor EBADF fixes.
1594 * process.c (create_process, wait_reading_process_output) [AIX]:
1595 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1596 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1597 a multithreaded environment anyway).
1598 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1599
f6774c1a
AS
16002013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1601
1602 * image.c (x_find_image_file): Don't close a remote file handle.
1603
bacba3c2
PE
16042013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 Fix races with threads and file descriptors.
1607 * callproc.c (Fcall_process_region):
1608 * dired.c (open_directory):
1609 * emacs.c (main, Fdaemon_initialized):
1610 * image.c (x_find_image_file):
1611 * inotify.c (Finotify_rm_watch):
1612 * lread.c (Flocate_file_internal):
1613 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1614 * term.c (term_mouse_moveto, init_tty):
1615 * termcap.c (tgetent):
1616 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1617 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1618 * unexhp9k800.c, unexmacosx.c (unexec):
1619 * callproc.c (Fcall_process_region):
1620 Use emacs_close, not close.
1621 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1622 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1623 and posix_close function on current platforms (which all lack them).
1624 (emacs_close): Use it. This should fix the races on GNU/Linux and
1625 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1626 and it should avoid closing random victim file descriptors on
1627 other platforms.
1628
653d4f43
PE
16292013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1630
c8536ec4
PE
1631 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1632 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1633 Touch up doc a bit.
1634
9c203066
PE
1635 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1636 This is for .gdbinit xbacktrace.
1637
653d4f43
PE
1638 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1639 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1640 (emacs_set_tty): Now static.
1641 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1642 * term.c (tty_capable_p, tty_default_color_capabilities)
1643 (get_tty_terminal, term_mouse_movement)
1644 (handle_one_term_event, init_tty, maybe_fatal):
1645 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1646 (tgetent, scan_file, name_match, compare_contin):
1647 * terminal.c (get_terminal):
1648 Use bool for boolean.
1649 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1650 Prefer char to unsigned char if either will do.
1651 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1652 (tty_write_glyphs): Prefer int to unsigned.
1653 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1654 All callers changed.
1655 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1656
45b683a1
PE
16572013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1658
29abe551
PE
1659 Port to C89.
1660 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1661 (B__dummy__): New dummy symbol, to pacify C89.
1662 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1663 they can't grok varargs macros.
1664 * dispnew.c (add_window_display_history)
1665 (add_frame_display_history):
1666 * print.c (print_object):
1667 * xdisp.c (debug_method_add):
1668 Use %p printf format only for void pointers.
1669 * emacs.c (usage_message): New constant, replacing ...
1670 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1671 (main): Adjust to usage reorg.
1672 * fns.c (syms_of_fns):
1673 * profiler.c (syms_of_profiler):
1674 Don't use non-constant struct initializers.
1675 * gnutls.h (gnutls_initstage_t):
1676 * lisp.h (enum Lisp_Fwd_Type):
1677 * lread.c (lisp_file_lexically_bound_p):
1678 * xsettings.c (anonymous enum):
1679 Remove trailing comma.
1680 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1681 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1682 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1683 (DEFUN): Use it.
1684 * regex.c (const_re_char): New type, to pacify strict C89.
1685 All uses of 'const re_char' replaced to use it.
1686 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1687 with glibc when strict C89. This change is imported from gnulib.
1688 All uses changed.
1689 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1690 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1691 Omit GNU_LINUX implementation, since it requires long long.
1692 * xterm.c (x_draw_underwave):
1693 Do not assume the traditional order of struct's members.
1694 (x_term_init): Rewrite to avoid the need for non-constant structure
1695 initializers.
1696
45b683a1 1697 Syntax cleanup, mostly replacing macros with functions.
763a086d 1698 This removes the need for the syntax_temp hack.
45b683a1
PE
1699 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1700 * syntax.c (SYNTAX_INLINE): New macro.
1701 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1702 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1703 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1704 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1705 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1706 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1707 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1708 Now constants, not macros.
1709 (syntax_temp) [!__GNUC__]: Remove.
1710 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1711 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1712 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1713 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1714 Move here from syntax.h; now functions, not macros. Except for the
1715 last function, these are static since only syntax.c uses them.
1716 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1717 All uses changed. Now a function, not a macro; use this fact
1718 to simplify the code.
1719 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1720 compiler bugs; no longer relevant.
1721 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1722 (SYNTAX_INLINE): New macro.
1723 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1724 for the new functions. Use bool for boolean member.
1725 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1726 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1727 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1728 (SETUP_BUFFER_SYNTAX_TABLE):
1729 Now extern inline functions, not macros.
1730 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1731 Remove; all uses replaced by implementation.
1732 (syntax_temp) [!__GNUC__]: Remove decl.
1733 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1734
29be4a50
JD
17352013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1736
1737 * emacs.c (main): Fix syntax error.
1738
954b166e
PE
17392013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 Timestamp fixes for undo (Bug#14824).
1742 * atimer.c (schedule_atimer):
1743 * fileio.c (Ffile_newer_than_file_p):
1744 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1745 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1746 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1747 (syms_of_fileio): Remove Sclear_visited_file_name.
1748 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1749 file doesn't exist; this avoids an ambiguity with negative timestamps.
1750 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1751 * systime.h (make_emacs_time, invalid_emacs_time):
1752 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1753 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1754 * undo.c (record_first_change): Push (visited-file-modtime) onto
1755 undo list rather than reimplementing it by hand, incorrectly.
1756
d74647c3
KB
17572013-07-09 Ken Brown <kbrown@cornell.edu>
1758
1759 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1760
3c51b96b
JB
17612013-07-09 Juanma Barranquero <lekktu@gmail.com>
1762
1763 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1764
4ebbdd67
PE
17652013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 Handle errno and exit status a bit more carefully.
1768 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1769 number into an exit status. Instead, use EXIT_CANCELED.
1770 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1771 * callproc.c (relocate_fd):
1772 * emacs.c (close_output_streams, main):
1773 * process.c (create_process):
1774 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1775 Use emacs_perror for simplicity.
1776 * callproc.c (relocate_fd, main):
1777 * sysdep.c (sys_subshell):
1778 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1779 (shut_down_emacs): Use emacs_write, not write.
1780 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1781 * fileio.c (Fcopy_file, e_write):
1782 * nsterm.m (ns_select):
1783 * process.c (send_process):
1784 * sound.c (vox_write):
1785 Use emacs_write_sig, not emacs_write.
1786 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1787 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1788 New constants.
1789 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1790 of write.
1791 (emacs_full_write): New function.
1792 (emacs_write): Rewrite to use it.
1793 (emacswrite_sig, emacs_perror): New functions.
1794 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1795
44e18199 17962013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1797
1798 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1799 on NS even if it is present. Pixmap on NS is a void*.
1800
9caab067
PE
18012013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 Port to Ubuntu 10 (Bug#14803).
1804 Problem reported by T.V. Raman.
1805 * process.c (close_on_exec, accept4, process_socket):
1806 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1807
1d442672
EZ
18082013-07-07 Eli Zaretskii <eliz@gnu.org>
1809
1810 * w32.c (sys_dup): Declare prototype.
1811
1812 * filelock.c:
1813 * emacs.c:
1814 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1815
067428c1
PE
18162013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1817
1818 Make file descriptors close-on-exec when possible (Bug#14803).
1819 This simplifies Emacs a bit, since it no longer needs to worry
1820 about closing file descriptors by hand in some cases.
1821 It also fixes some unlikely races. Not all such races, as
1822 libraries often open files internally without setting
1823 close-on-exec, but it's an improvement.
1824 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1825 * callproc.c (Fcall_process) [!MSDOS]:
1826 * emacs.c (main) [!DOS_NT]:
1827 * nsterm.m (ns_term_init):
1828 * process.c (create_process):
1829 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1830 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1831 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1832 Prefer mkostemp with O_CLOEXEC to mkstemp.
1833 * callproc.c (relocate_fd) [!WINDOWSNT]:
1834 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1835 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1836 now using pipe2.
1837 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1838 Make the resulting file descriptor close-on-exec.
1839 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1840 * lread.c (load_descriptor_list, load_descriptor_unwind):
1841 Remove; no longer needed. All uses removed.
1842 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1843 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1844 New functions.
1845 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1846 (Fmake_network_process, Fnetwork_interface_list):
1847 (Fnetwork_interface_info, server_accept_connection):
1848 Make newly-created socket close-on-exec.
1849 * sysdep.c (emacs_open, emacs_fopen):
1850 Make new-created descriptor close-on-exec.
1851 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1852 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1853
0da857dd
JD
18542013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1855
1856 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1857 for NS_IMPL_GNUSTEP.
1858
5f86adcd
PE
18592013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 Fix openp errno handling.
1862 * callproc.c (Fcall_process): Preserve openp errno around close.
1863 * lread.c (openp): Set errno when returning -1, as some callers
1864 expect this.
1865
1afb1d07
JD
18662013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1867
1868 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1869
1870 * nsterm.h (NSSavePanel): Update comment.
1871 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1872 (ns_run_file_dialog): Declare.
1873
1874 * nsfns.m: Remove panelOK.
1875 (ns_fd_data): New.
1876 (ns_run_file_dialog): New function.
1877 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1878 event loop, so file dialog is popped up by ns_run_file_dialog, called
1879 by sendEvent (Bug#14578).
1880 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1881
3323c263
EZ
18822013-07-06 Eli Zaretskii <eliz@gnu.org>
1883
fdda0220
EZ
1884 * xdisp.c (default_line_pixel_height): New function.
1885 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1886 (try_cursor_movement, redisplay_window, try_window)
1887 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1888
1889 * window.c (window_scroll_pixel_based): use
1890 default_line_pixel_height.
1891
1892 * dispextern.h (default_line_pixel_height): Add prototype.
1893
1894 * frame.c (x_set_line_spacing): Accept a float value for
1895 line-spacing parameter, per the documentation.
1896
3323c263
EZ
1897 * data.c (Fmultibyte_string_p): Doc fix.
1898
47ba6d43
PE
18992013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1900
406af475
PE
1901 Use emacs_open more consistently when opening files.
1902 This handles EINTR more consistently now, and makes it easier
1903 to introduce other uniform changes to file descriptor handling.
1904 * src/systdio.h: New file.
1905 * src/buffer.c (mmap_init):
1906 * cygw32.c (chdir_to_default_directory):
1907 * dispnew.c (Fopen_termscript):
1908 * emacs.c (Fdaemon_initialized):
1909 * fileio.c (Fdo_auto_save):
1910 * image.c (slurp_file, png_load_body, jpeg_load_body):
1911 * keyboard.c (Fopen_dribble_file):
1912 * lread.c (Fload):
1913 * print.c (Fredirect_debugging_output):
1914 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1915 * termcap.c (tgetent):
1916 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1917 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1918 * w32term.c (w32_initialize) [CYGWIN]:
1919 * xfaces.c (Fx_load_color_file):
1920 Use emacs_open instead of plain open, and emacs_fopen instead of
1921 plain fopen.
1922 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1923 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1924 * callproc.c (default_output_mode): New constant.
1925 (Fcall_process): Use it to call emacs_open instead of plain creat.
1926 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1927 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1928 (emacs_fopen): New function.
1929 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1930 Include <lisp.h>, for emacs_open.
1931 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1932
47ba6d43
PE
1933 Remove duplicate #include directives.
1934 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1935 * xfaces.c:
1936 Don't include stdio.h twice.
1937 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1938 Don't include sys/types.h or stdio.h twice.
1939 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1940 * lread.c: Don't include coding.h twice.
1941 * nsfont.m: Don't include frame.h twice.
1942 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1943 * ralloc.c: Don't include <unistd.h> twice.
1944 * xdisp.c: Don't include font.h twice.
1945 * xterm.c: Don't include fontset.h twice.
1946 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1947
b9ed53d5
PE
19482013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 Scale ImageMagick images more carefully.
1951 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1952 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1953 Be more careful about avoiding undefined behavior after
1954 integer overflow and division by zero.
1955
cf13177e
YM
19562013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1957
1958 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1959 (syms_of_w32fns): DEFSYM them.
1960 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1961 (CCHDEVICENAME): Define macros if not defined.
1962 (struct MONITOR_INFO_EX): New struct.
1963 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1964 (enum_display_monitors_fn): New variable.
1965 (globals_of_w32fns): Initialize it.
1966 (Fx_display_pixel_width, Fx_display_pixel_height)
1967 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1968 multi-monitor setups in docstrings.
1969 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1970 screen size by primary monitor's millimeter per pixel.
1971 (w32_monitor_enum, w32_display_monitor_attributes_list)
1972 (w32_display_monitor_attributes_list_fallback)
1973 (Fw32_display_monitor_attributes_list): New functions.
1974 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1975
1976 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1977 if not defined.
1978 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1979
86dfb7a8
MA
19802013-07-04 Michael Albinus <michael.albinus@gmx.de>
1981
1982 * fileio.c (Qfile_notify_error): New error symbol.
1983
1984 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1985 * inotify.c (inotify_callback, symbol_to_inotifymask)
1986 (Finotify_add_watch, Finotify_rm_watch): Use it.
1987 (inotifyevent_to_event): Exchange order of cookie and file name.
1988 (Finotify_add_watch): Adapt docstring.
1989
1990 * lisp.h (Qfile_notify_error): Declare.
1991
2c1c974b
PE
19922013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1995 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1996 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1997 which did not work (see <http://bugs.gnu.org/14569#307>).
1998 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1999 && (!noninteractive || initialized)). This attempts to thread
2000 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2001
7a35b20f
JB
20022013-07-04 Juanma Barranquero <lekktu@gmail.com>
2003
2004 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2005 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2006
1ce5cd04
PE
20072013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2010 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2011 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2012 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2013
57f8c490
PE
20142013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2017 Define to __sys_siglist.
2018
bcffb5ca
EZ
20192013-07-02 Eli Zaretskii <eliz@gnu.org>
2020
2021 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2022 word-wrap, so that overflow-newline-into-fringe would work in
2023 visual-line-mode. (Bug#2749)
2024 (move_it_in_display_line_to): When the last scanned display
2025 element fits exactly on the display line, and
2026 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2027 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2028 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2029 finding buffer position that corresponds to pixel coordinates,
2030 e.g. in buffer_posn_from_coords.
2031
2c41e781
JD
20322013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2033
2034 * process.c (handle_child_signal): Call catch_child_signal if
2035 NS_IMPL_GNUSTEP.
2036
c2418359
PE
20372013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2038
52a9bcae
PE
2039 Don't convert function pointers to void * and back.
2040 It isn't portable C, and it's easy enough to avoid.
2041 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2042 (make_save_value): Add support for SAVE_FUNCPOINTER.
2043 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2044 * print.c (print_object):
2045 Distinguish function from object pointers.
2046 * lisp.h (SAVE_FUNCPOINTER): New constant.
2047 (SAVE_SLOT_BITS): Adjust to it.
2048 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2049 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2050 (voidfuncptr): New typedef.
2051 (struct Lisp_Save_Value): New member data[0].funcpointer.
2052 (XSAVE_FUNCPOINTER): New function.
2053
c2418359
PE
2054 Simplify buildobj processing.
2055 * Makefile.in (buildobj.h): Make it a sequence of strings each
2056 followed by comma, rather than a single string. Put it into a
2057 .tmp file in case there's an error while generating it.
2058 (gl-stamp): Use .tmp for temp files.
2059 (mostlyclean): Clean .tmp files.
2060 * doc.c (buildobj): Move to just the routine that needs it.
2061 It's now an array of strings, so processing is simpler.
2062
8f43ce49
PE
20632013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2066 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2067 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2068 Invoke malloc_enable_thread even when not interactive.
2069 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2070 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2071 in this case, since the underlying bug has now been fixed.
2072
24827db9
JB
20732013-07-01 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2076 unlinking it (bug#14691).
2077
ef099a94
MN
20782013-06-30 Michal Nazarewicz <mina86@mina86.com>
2079
2080 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2081 before checking whether buffer is modified. This lets
2082 `kill-buffer-query-functions' cancel killing of the buffer or save
2083 its content before `kill-buffer' asks user the "Buffer %s
2084 modified; kill anyway?" question.
2085
9d3f2fc2
JD
20862013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2087
2088 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2089 Let the super performKeyEquivalent deal with them (Bug#14747).
2090
e6c6c8c7
PE
20912013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2092
1d71c1d9
PE
2093 * widget.c (resize_cb): Remove unused local.
2094
8f5f35cc
PE
2095 Do not use GTK 3 if it exists but cannot be compiled.
2096 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2097 * xterm.c (x_error_handler) [!USE_GTK]:
2098 Do not use GTK 3.
2099
e6c6c8c7
PE
2100 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2101
0ba54312
EZ
21022013-06-30 Eli Zaretskii <eliz@gnu.org>
2103
5d1c3286
EZ
2104 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2105 to the valid range of values. (Bug#14753)
2106
0ba54312
EZ
2107 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2108 when moving point by using the current glyph matrix. This avoids
2109 the need to force redisplay when this function is called in a
2110 loop.
2111
9c90cc06
PE
21122013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2113
2114 Fix minor problems found by static checking.
2115 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2116 Redo the latter's body to sidestep GCC parenthesization warnings.
2117 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2118 * coding.c (detect_coding, detect_coding_system):
2119 * coding.h (struct undecided_spec):
2120 Use bool for boolean.
2121 * image.c (QCmax_width, QCmax_height): Now static.
2122 * xdisp.c (Fmove_point_visually): Remove unused local.
2123
4c672a0f
EZ
21242013-06-29 Eli Zaretskii <eliz@gnu.org>
2125
2126 * xdisp.c (Fmove_point_visually): New function.
2127
c1ea3abf
JB
21282013-06-28 Kenichi Handa <handa@gnu.org>
2129
2130 * coding.h (define_coding_undecided_arg_index): New enum.
2131 (coding_attr_index): New members
2132 coding_attr_undecided_inhibit_null_byte_detection,
2133 coding_attr_undecided_inhibit_iso_escape_detection,
2134 coding_attr_undecided_prefer_utf_8.
2135 (undecided_spec): New struct.
2136 (struct coding_system): New member `undecided' of the member
2137 `spec'.
2138
2139 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2140 (detect_coding): Likewise.
2141 (detect_coding_system): Likewise.
2142 (Fdefine_coding_system_internal): New coding system properties
2143 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2144 :prefer-utf-8.
2145 (syms_of_coding): Adjust for coding_arg_undecided_max.
2146
ba3de9e6
PE
21472013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2148
2149 * image.c (x_from_xcolors): Remove unused local.
2150
547c9269
YM
21512013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2152
2153 Defer image data transfer between X client and server until actual
2154 display happens.
2155
2156 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2157 and `mask_img'.
2158
2159 * image.c (Destroy_Image): Remove.
2160 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2161 `mask_p', and `colors_p'. All uses changed.
2162 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2163 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2164 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2165 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2166 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2167 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2168 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2169 (image_get_x_image, image_unget_x_image): New functions or macros.
2170 (image_background, image_background_transparent, x_to_xcolors)
2171 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2172 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2173 instead of Destroy_Image.
2174 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2175 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2176 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2177 (imagemagick_load_image, svg_load_image): Use them instead of
2178 x_create_x_image_and_pixmap, and x_put_x_image followed by
2179 x_destroy_x_image, respectively.
2180 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2181 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2182 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2183 background_transparent fields.
2184 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2185 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2186
dae2f5ef
PE
21872013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2190 This mostly consists of undoing recent changes.
2191 * callproc.c (Fcall_process):
2192 * process.c (create_process):
2193 Do not worry about catching SIGCHLD here, undoing previous change.
2194 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2195 * process.c, process.h (catch_child_signal):
2196 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2197 * process.c (catch_child_handler): Don't worry about being called
2198 lazily and do not assume caller has blocked SIGCHLD, undoing
2199 previous change. Move first-time stuff back to
2200 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2201 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2202 set lib_child_handler if it's already initialized, which may
2203 help avoid problems on GNUStep.
2204
fa55d2aa
PE
22052013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2206
2207 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2208 * callproc.c (Fcall_process):
2209 * process.c (create_process):
2210 Make sure SIGCHLD is caught before we fork,
2211 since Emacs startup no arranges to catch SIGCHLD.
2212 * process.c (lib_child_handler): Initialize to null, not to
2213 dummy_handler.
2214 (catch_child_signal): Allow self to be called lazily.
2215 Do nothing if it's already been called.
2216 Assume caller has blocked SIGCHLD (all callers do now).
2217 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2218 just before it's really needed.
2219 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2220 since it hasn't been caught yet.
2221
f3f9606c
LMI
22222013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2223
2224 * image.c (compute_image_size): New function to implement
2225 :max-width and :max-height.
2226 (imagemagick_load_image): Use it.
2227
c7041908
PE
22282013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2231 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2232 Now extern.
2233 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2234 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2235 the SIGCHLD handler, since the code is not atomic and (due to glib)
2236 signals may be arriving now.
2237 * sysdep.c (init_signals): Do not catch child signals here;
2238 'main' now does that later, at a safer time.
2239
f86852b4
PE
22402013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2241
0dfeed58
PE
2242 Clean up SIGCHLD handling a bit (Bug#14569).
2243 * process.c, process.h (catch_child_signal):
2244 Now always extern, even if !NS_IMPL_GNUSTEP.
2245 * process.c (catch_child_signal): Move glib tickler here from
2246 init_process_emacs, so that it's done earlier in Emacs
2247 initialization. Also move the noninteractive && !initialized
2248 check here from init_process_emacs. This is all a bit cleaner for
2249 GNUish platforms, and I hope it works around the Cygwin bug.
2250 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2251 that glib signal handling is tickled before glib creates threads.
2252
f86852b4
PE
2253 * process.c (wait_reading_process_output): Avoid int overflow
2254 when reading more than 2 GiB total from a process.
2255
cbd6509c
PE
22562013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2257
2258 * process.c (create_process): Handle a couple more cases,
2259 i.e., work even if new_argv and wait_child_setup[i] are cached.
2260 Use Fcall_process's style for volatile vars.
2261
9de1114a
AS
22622013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2263
2264 * process.c (create_process): Mark PROCESS volatile.
2265
fbe9e0b9
PE
22662013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2267
2268 Use C99-style flexible array members if available.
2269 This avoids some subtle aliasing issues, which typically
2270 aren't a problem with GCC but may be a problem elsewhere.
2271 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2272 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2273 In either case, it uses a flexible array member rather than
2274 the old struct hack. All uses changed.
2275 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2276 Adjust to sdata reorganization.
2277 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2278 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2279 that ports better to pre-C99 non-GCC.
2280 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2281 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2282 as the latter has changed.
2283 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2284 and port better to pre-C99 GCC.
2285 * image.c (struct xpm_cached_color):
2286 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2287 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2288 Use FLEXIBLE_ARRAY_MEMBER.
2289 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2290 Move decl to top level so it gets checked against implementation.
2291 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2292 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2293
1fc71008
PE
22942013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2295
2296 * syntax.c: Integer cleanups.
2297 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2298 All uses that need 0-or-2 changed to:
2299 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2300 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2301 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2302 (char_quoted, prev_char_comend_first, back_comment)
2303 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2304 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2305 Use bool for boolean.
2306 (update_syntax_table, skip_chars, skip_syntaxes):
2307 Prefer int to unsigned when either will do.
2308 (back_comment): Return boolean success flag, like forw_comment,
2309 instead of positive-or-minus-1 (which might have overflowed int anyway).
2310 Don't stuff ptrdiff_t into int.
2311 (syntax_spec_code, syntax_code_spec): Now const.
2312 (Fmatching_paren, scan_lists, scan_sexps_forward):
2313 Use enum syntaxcode for syntax code.
2314 (Fmatching_paren): Check that arg is a character, not just an integer.
2315 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2316 (Finternal_describe_syntax_value): Omit no-longer-needed
2317 comparison to 0.
2318 (skip_chars): Use char, not unsigned char, when the distinction
2319 doesn't matter.
2320 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2321 * bytecode.c (exec_byte_code):
2322 * syntax.c (syntax_spec_code, Fchar_syntax)
2323 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2324 (init_syntax_once):
2325 * syntax.h (SYNTAX_WITH_FLAGS):
2326 Omit unnecessary casts.
2327
b932cad7
EZ
23282013-06-20 Eli Zaretskii <eliz@gnu.org>
2329
2330 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2331 line dimensions here, to avoid race conditions with the main
2332 thread. (Bug#14062, bug#14630, bug#14669)
2333
2334 * w32term.c (w32_draw_window_cursor): Compute the header line and
2335 mode line dimensions here.
2336 <w32_system_caret_window, w32_system_caret_hdr_height>:
2337 <w32_system_caret_mode_height>: New variables.
2338
2339 * w32term.h: Declare them.
2340
89561f72
PE
23412013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2342
5013fc08
PE
2343 * alloc.c (die): Move "assertion failed" string here ...
2344 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2345 COND when SUPPRESS_CHECKING. This shrinks the executable text
2346 size by 0.8% to 2.2% when configured with --enable-checking,
2347 depending on optimization flags (GCC 4.8.1 x86-64).
2348
89561f72
PE
2349 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2350
763a086d 23512013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2352
2353 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2354 base is 2; this is more accurate.
2355
983aeb9a
JB
23562013-06-19 Juanma Barranquero <lekktu@gmail.com>
2357
2358 * sound.c (string_default): Move to !WINDOWSNT section.
2359 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2360
178ba3e6
PE
23612013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2362
bbc51b15
PE
2363 * sound.c: Integer cleanups.
2364 Remove unnecessary forward decls.
2365 (struct sound_device): The 'file' member is now a Lisp_Object, not
2366 a char *, so that we needn't invoke alloca on a huge size.
2367 (Fplay_sound_internal): Adjust to this.
2368 (string_default): New function.
2369 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2370 Use it to adjust to the struct sound_device change.
2371 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2372 (be2hs) [0]: Remove.
2373
178ba3e6
PE
2374 * syntax.c (skip_chars): Don't use uninitialized storage
2375 when searching a multibyte buffer for characters that are not in a
2376 unibyte string that contains non-ASCII characters.
2377
69f60cdc
JD
23782013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2379
2380 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2381 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2382
0d6224d4
PE
23832013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2384
2385 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2386
3c542890
KH
23872013-06-18 Kenichi Handa <handa@gnu.org>
2388
f7e3f7cd
KH
2389 * font.c (Ffont_spec): Signal an error for an invalid font name
2390 (Bug#14648).
3c542890 2391
9349e5f7
PE
23922013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2395 In particular this ports to 32-bit sparc Sun cc.
2396 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2397 array with a dummy element at specpdl[-1], so that its address can
2398 be taken portably.
2399 (unbind_to): Do not copy the binding; not needed, now that we
2400 copy old_value in the one place where the copy is needed.
2401 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2402 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2403 (union specbinding): Rename from struct specbinding. Redo layout
2404 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2405 which is not portable. With Sun C 5.12 32-bit sparc, the
2406 declaration causes nargs to be an unsigned bitfield, a behavior
2407 that the C standard allows; but Emacs wants nargs to be signed.
2408 The overall type is now a union of structures rather than a
2409 structure of union of structures, and the 'kind' member is now a
2410 bitfield, so that the overall type doesn't grow. All uses changed.
2411 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2412
0a4df6a5
PE
24132013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2414
ec6ecaad
PE
2415 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2416 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2417
0a4df6a5
PE
2418 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2419
7bfe8dbc
EZ
24202013-06-17 Eli Zaretskii <eliz@gnu.org>
2421
2422 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2423 unless we know that the window w's frame is a frame object.
2424 Another attempt at solving bug#14062 and bug#14630.
2425
708e05f6
LMI
24262013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2427
2428 * textprop.c (property_set_type): New enum.
2429 (add_properties): Allow appending/prepending text properties.
2430 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2431 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2432 add_text_properties_1.
2433 (Fadd_face_text_property): New function that calls
2434 add_text_properties_1.
2435
84575e67
PE
24362013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 Move functions from lisp.h to individual modules when possible.
2439 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2440 * alloc.c (XFLOAT_INIT, set_symbol_name):
2441 * buffer.c (CHECK_OVERLAY):
2442 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2443 (set_char_table_parent):
2444 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2445 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2446 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2447 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2448 (set_blv_valcell):
2449 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2450 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2451 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2452 (backtrace_args, backtrace_debug_on_exit):
2453 * floatfns.c (CHECK_FLOAT):
2454 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2455 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2456 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2457 (set_hash_index_slot):
2458 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2459 * marker.c (CHECK_MARKER):
2460 * textprop.c (CHECK_STRING_OR_BUFFER):
2461 * window.c (CHECK_WINDOW_CONFIGURATION):
2462 Move here from lisp.h, and make these functions static rather than
2463 extern inline.
2464 * buffer.c (Qoverlayp):
2465 * data.c (Qsubrp):
2466 * fns.c (Qhash_table_p):
2467 * window.c (Qwindow_configuration_p):
2468 Now static.
2469 * lisp.h: Remove the abovementioned defns and decls.
2470
44e18199 2471 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2472 In lisp.h, prefer functions to function-like macros, and
2473 constants to object-like macros, when either will do. This:
2474 . simplifies use, as there's no more need to worry about
2475 arguments' side effects being evaluated multiple times.
2476 . makes the code easier to debug on some platforms.
2477 However, when using gcc -O0, keep using function-like macros
2478 for a few critical operations, for performance reasons.
2479 This sort of thing isn't needed with gcc -Og, but -Og
2480 is a GCC 4.8 feature and isn't widely-enough available yet.
2481 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2482 Remove enum lsb_bits; no longer needed.
2483 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2484 * buffer.c (Qoverlap):
2485 * data.c (Qsubrp):
2486 * fns.c (Qhash_table_p):
2487 Now extern, so lisp.h can use these symbols.
2488 * dispextern.h: Include character.h, for MAX_CHAR etc.
2489 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2490 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2491 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2492 (GLYPH_CODE_P): Move here from lisp.h.
2493 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2494 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2495 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2496 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2497 XUNTAG now returns void *.
2498 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2499 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2500 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2501 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2502 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2503 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2504 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2505 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2506 New macros, renamed from their sans-lisp_h_ counterparts.
2507 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2508 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2509 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2510 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2511 If compiling via GCC without optimization, define these as macros
2512 in addition to inline functions.
2513 To disable this, compile with -DINLINING=0.
2514 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2515 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2516 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2517 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2518 (INTMASK, VALMASK): Now macros, since static values cannot be
2519 accessed from extern inline functions.
2520 (VALMASK): Also a constant, for benefit of old GDB.
2521 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2522 is INTEGERP, which can fold it in.
5165d44a 2523 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2524 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2525 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2526 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2527 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2528 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2529 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2530 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2531 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2532 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2533 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2534 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2535 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2536 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2537 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2538 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2539 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2540 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2541 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2542 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2543 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2544 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2545 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2546 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2547 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2548 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2549 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2550 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2551 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2552 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2553 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2554 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2555 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2556 Now functions.
2557 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2558 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2559 (VALMASK): Define in one place rather than in two, merging the
2560 USE_LSB_TAG parts; this is simpler.
2561 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2562 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2563 Move up, to avoid use before definition.
2564 Also include "globals.h" earlier, for the same reason.
2565 (make_natnum): New function.
2566 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2567 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2568 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2569 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2570 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2571 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2572 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2573 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2574 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2575 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2576 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2577 (Qwindow_configuration_p, Qimage): New forward declarations.
2578 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2579 (STRING_COPYIN): Remove; unused.
2580 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2581 (xcar_addr, xcdr_addr): New functions. All uses changed.
2582 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2583 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2584 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2585 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2586 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2587 (TYPE_RANGED_INTEGERP): Simplify.
2588 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2589 (setlocale, fixup_locale, synchronize_system_messages_locale)
2590 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2591 Now empty functions, not macros.
2592 (functionp): Return bool, not int.
2593 * window.c (Qwindow_configuration_p): Now extern,
2594 so window.h can use it.
2595 * window.h (Qwindowp): Move decl back to lisp.h.
2596
9583ec36
EZ
25972013-06-15 Eli Zaretskii <eliz@gnu.org>
2598
2599 * xdisp.c (Fline_pixel_height): New function, required for solving
2600 bug #14567.
2601
210272ce
PE
26022013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2603
2604 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2605
de0503df
SM
26062013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2607
2608 * lread.c (syms_of_lread):
2609 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2610
afbfe143
KD
26112013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2612
2613 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2614
d177e213
XF
26152013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2616
2617 * fileio.c (expand_file_name): Doc fix.
2618
05e3e412
PE
26192013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2620
f7394b12
PE
2621 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2622 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2623 Wait for self, not for 0. This can't hurt on GNU or similar
2624 system, and may help with Cygwin.
2625
05e3e412
PE
2626 * keyboard.c: Don't use PROP (...) as an lvalue.
2627 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2628 Use set_prop (A, B), not PROP (A) = B.
2629
17dd3097
EZ
26302013-06-10 Eli Zaretskii <eliz@gnu.org>
2631
2632 * xdisp.c (get_it_property): Use it->window instead of generating
2633 a Lisp object from it->w.
2634
52fab9c9
EZ
26352013-06-09 Eli Zaretskii <eliz@gnu.org>
2636
2637 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2638 get-char-property the window that is being rendered, instead of
2639 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2640 (compute_display_string_pos): When W is NULL, use the current
2641 buffer as the object to pass to get-char-property.
2642 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2643 pointer member of the bidi iterator, since no window is pertinent
2644 to this function.
52fab9c9 2645
5bf97bfc
EZ
26462013-06-08 Eli Zaretskii <eliz@gnu.org>
2647
2648 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2649 being displayed, and pass it to compute_display_string_pos.
2650 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2651 (bidi_paragraph_init): All callers changed.
2652
2653 * xdisp.c (init_from_display_pos, init_iterator)
2654 (handle_single_display_spec, next_overlay_string)
2655 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2656 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2657 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2658 (compute_display_string_pos): Accept additional argument, the
2659 window being displayed, and pass it to Fget_char_property.
2660 (Bug#14575)
2661
2662 * dispextern.h (struct bidi_it): New member w, the window being
2663 displayed.
2664 (compute_display_string_pos): Adjust prototype.
2665
5de0e011
JD
26662013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2667
e7b41c4c 2668 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2669
2670 * process.c (wait_reading_process_output): Check for NS before GLIB.
2671 GLIB may be linked in due to rsvg, but ns_select must be called.
2672
5de0e011
JD
2673 * xgselect.c (xg_select): Remove call to window_system_available
2674 and g_main_context_pending at the top, so Gdk events (i.e. file
2675 notify) are processed when Emacs is started with -nw.
2676
a822acff
EZ
26772013-06-07 Eli Zaretskii <eliz@gnu.org>
2678
2679 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2680 (ctagsfiles3): New variable, includes only *.m files.
2681 (TAGS): Use an explicit language name in the regular expressions,
2682 to avoid transformation of '/SOMETHING' by MSYS to
2683 'c:\MSYS\SOMETHING'.
2684
6c0a9ed1
RC
26852013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2686
2687 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2688
9ef6111b
EZ
26892013-06-06 Eli Zaretskii <eliz@gnu.org>
2690
2691 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2692 still need to set the mouse pointer shape and activate help-echo.
2693 (Bug#14558)
2694
7d300d64
PE
26952013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2696
2697 A few porting etc. fixes for the new file monitor code.
2698 See the thread containing
2699 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2700 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2701 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2702 (dir_monitor_callback, Fgfile_rm_watch):
2703 Use assq_no_quit instead of Fassoc, for speed.
2704 (dir_monitor_callback, Fgfile_rm_watch):
2705 eassert that the monitor is a fixnum.
2706 (dir_monitor_callback): No need for CDR_SAFE.
2707 Simplify building of lisp with alternative tails.
2708 (Fgfile_add_watch, Fgfile_rm_watch):
2709 Do not assume glib functions set errno reliably on failure.
2710 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2711 and signal an error otherwise.
2712 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2713 Use Fdelq instead of Fdelete, for speed.
2714
817ebfcf
EZ
27152013-06-05 Eli Zaretskii <eliz@gnu.org>
2716
2717 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2718 don't insist on being invoked on a highlighted tool-bar button.
2719 Avoids losing tool-bar functionality when mouse-highlight is nil.
2720 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2721 Don't highlight when mouse-highlight is nil.
2722 (note_mouse_highlight): When mouse-highlight is nil, don't return
2723 right away; instead, run tool-bar and mode-line highlight
2724 subroutine, clear any existing highlight, and revert the mouse
2725 pointer to its default shape. (Bug#14558)
2726
55577e7c
SM
27272013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2728
2729 * lisp.mk (lisp): Add prog-mode.el.
2730
f019a684
PE
27312013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2732
2733 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2734 * process.c (dummy_handler): New function.
2735 (lib_child_handler): New static var.
2736 (handle_child_signal): Invoke it.
2737 (catch_child_signal): If a library has set up a signal handler,
2738 save it into lib_child_handler.
2739 (init_process_emacs): If using glib and not on Windows, tickle glib's
2740 child-handling code so that it initializes its private SIGCHLD handler.
2741 * syssignal.h (SA_SIGINFO): Default to 0.
2742 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2743 31; it should no longer be needed now.
2744
90db8702
MA
27452013-06-05 Michael Albinus <michael.albinus@gmx.de>
2746
2747 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2748
2749 * gfilenotify.c (globals_of_gfilenotify): New function.
2750 (syms_of_gfilenotify): Move global initialization there.
2751
2752 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2753
bfa3acd6
SM
27542013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2755
2756 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2757 * keyboard.c (menu_bar_items, tool_bar_items):
2758 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2759 not override local keymaps any more.
2760
ba59bd80
EZ
27612013-06-04 Eli Zaretskii <eliz@gnu.org>
2762
2763 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2764
7f203aa1
EZ
27652013-06-03 Eli Zaretskii <eliz@gnu.org>
2766
9337e206
EZ
2767 * w32console.c (initialize_w32_display): Return the dimensions of
2768 the console window via 2 additional arguments, not via the current
2769 frame. This avoids crashes due to overrunning the bounds of
2770 frame's decode_mode_spec_buffer, which is not resized following
2771 the change of the frame dimensions from the initial 10x10.
2772
2773 * w32term.h (w32_initialize_display_info): Adjust prototype.
2774
2775 * term.c (init_tty): Take dimensions of the frame from the values
2776 returned by initialize_w32_display.
2777
7f203aa1
EZ
2778 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2779 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2780 (LIBES): Add $(GFILENOTIFY_LIBS).
2781
2782 * w32inevt.c (handle_file_notifications): Add dummy implementation
2783 for !HAVE_W32NOTIFY.
2784
2785 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2786
55a87246
JD
27872013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2788
2789 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2790
2791 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2792
2793 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2794
3d5ee10a
PE
27952013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2796
2797 Fix minor problems found by static checking.
2798 * data.c (pure_write_error):
2799 Use xsignal2, not Fsignal, as Fsignal might return.
2800 * eval.c (set_backtrace_debug_on_exit): Now static.
2801 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2802 No longer inline. EXTERN_INLINE is needed only for functions
2803 defined in .h files. Reindent function header as per GNU style.
2804 (backtrace_p, backtrace_top, backtrace_next):
2805 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2806 compiler or linker. Add extern decls to pacify gcc -Wall.
2807 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2808 Now static.
2809 * frame.c (free_monitors): Define only on platforms that need it.
2810 * nsterm.m (ns_term_init):
2811 * process.c (catch_child_signal):
2812 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2813 defined on all porting targets these days.
2814 * process.c, process.h (catch_child_signal):
2815 Make it extern only if NS_IMPL_GNUSTEP is defined.
2816
e2d8a6f0
EZ
28172013-06-03 Eli Zaretskii <eliz@gnu.org>
2818
2819 * w32.c (gettimeofday): Make the signature identical to prototype
2820 in nt/inc/sys/time.h.
2821
a8a7c5f6
SM
28222013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2823
2824 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2825 .gdbinit.
2826
2827 * keyboard.c (safe_run_hooks_error): Improve error message.
2828
2829 * data.c (pure_write_error): Add `object' argument.
2830 * puresize.h (CHECK_IMPURE): Use it.
2831
c9628c79
MA
28322013-06-03 Michael Albinus <michael.albinus@gmx.de>
2833
2834 * Makefile.in (NOTIFY_OBJ): New variable.
2835 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2836
2837 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2838 Call syms_of_gfilenotify.
2839
2840 * gfilenotify.c: New file.
2841
2842 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2843 and Qfile_w32notify.
2844 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2845 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2846
2847 * lisp.h: Declare syms_of_gfilenotify.
2848
2849 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2850
2f592f95
SM
28512013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2852
2853 Merge the specpdl and backtrace stacks. Make the structure of the
2854 specpdl entries more obvious via a tagged union of structs.
2855 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2856 (enum specbind_tag): New enum.
2857 (struct specbinding): Make it a tagged union of structs.
2858 Add a case for backtrace records.
2859 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2860 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2861 (backtrace_debug_on_exit): New accessors.
2862 (struct backtrace): Remove.
2863 (struct catchtag): Remove backlist field.
2864 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2865 Move to eval.c.
2866 (Flocal_variable_p): Speed up the common case where the binding is
2867 already loaded.
2868 * eval.c (backtrace_list): Remove.
2869 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2870 (set_backtrace_args, set_backtrace_nargs)
2871 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2872 (backtrace_next): New functions.
2873 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2874 (unwind_to_catch, internal_lisp_condition_case)
2875 (internal_condition_case, internal_condition_case_1)
2876 (internal_condition_case_2, internal_condition_case_n): Don't bother
2877 with backtrace_list any more.
2878 (Fsignal): Adjust to new backtrace format.
2879 (grow_specpdl): Move up.
2880 (record_in_backtrace): New function.
2881 (eval_sub, Ffuncall): Use it.
2882 (apply_lambda): Adjust to new backtrace format.
2883 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2884 data.c.
2885 (specbind): Adjust to new specpdl format. Simplify.
2886 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2887 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2888 backtrace format.
2889 (mark_backtrace): Remove.
2890 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2891 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2892 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2893 Use mark_specpdl.
2894 * profiler.c (record_backtrace): Use get_backtrace.
2895 (handle_profiler_signal): Use backtrace_top_function.
2896 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2897 accessor functions.
2898
c0342369
JD
28992013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2900
2901 * process.h (catch_child_signal): Declare.
2902
2903 * process.c (catch_child_signal): New function.
2904 (init_process_emacs): Call it.
2905
2906 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2907 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2908 NS_IMPL_COCOA.
2909 (x_set_cursor_type): Remove declaration.
2910 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2911 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2912 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2913 (ns_get_color): Use F suffix on float.
2914 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2915 (ns_get_rgb_color): Remove.
2916 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2917 (note_mouse_movement): x and y are CGFloat.
2918 (ns_draw_fringe_bitmap): Remove unused rowY.
2919 Change #if to COCOA && >= 10_6.
2920 (ns_draw_window_cursor): Remove unused overspill.
2921 (ns_draw_underwave): width and x are EamcsCGFloat.
2922 (ns_draw_box): thickness is CGFloat.
2923 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2924 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2925 if not in main thread.
2926 (ns_get_pending_menu_title, ns_check_menu_open)
2927 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2928 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2929 (sendFromMainThread:): New method.
2930 (changeFont:): size is CGFloat.
2931 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2932 Disable warning about permanent text.
2933 (characterIndexForPoint:): Adjust return type depending on GNUStep
2934 version.
2935 (mouseDown:): delta is CGFloat.
2936 (updateFrameSize): Remove unised variable f.
2937 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2938 Cast float to EmacsCGFloat.
2939 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2940 also to -1 when restoring.
2941 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2942 inside NS_IMPL_COCOA.
2943 (toggleFullScreen:): Put call to toggleFullScreen inside
2944 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2945 (setPosition:portion:whole:): por is CGFloat.
2946 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2947 (mouseDown:): Use CGFloat.
2948 (mouseDragged:): Remove unised variable edge.
2949 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2950
2951 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2952 of CGFloat differs.
2953 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2954 when NS_IMPL_GNUSTEP.
2955 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2956 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2957 (EmacsToolbar): Add clearAll. Add tag argument to
2958 addDisplayItemWithImage.
2959 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2960
2961 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2962
2963 * nsmenu.m (ns_update_menubar): Make static.
2964 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2965 (fillWithWidgetValue:): Add cast to SEL for setAction.
2966 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2967 (update_frame_tool_bar): Update code for GNUStep.
2968 (clearAll): New method.
2969 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2970 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2971 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2972 call to insertItemWithItemIdentifier.
2973 (validateVisibleItems): Fix indentation.
2974 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2975 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2976 UtilityWindow to aStyle, remove call to setStyleMask.
2977
2978 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2979
2980 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2981 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2982 Use F suffix on floats.
2983 (ns_char_width): Returns CGFloat.
2984 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2985 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2986 DPSxshow.
2987 (ns_glyph_metrics): CGFloat instead of float.
2988
a0eb10b3
JB
2989 * nsfns.m (x_set_foreground_color, x_set_background_color):
2990 Use EmacsCGFloat.
2991 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2992 remove unused variables.
2993 (Fns_read_file_name): Keep track if panel is for save.
2994 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2995 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2996 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2997 Just return the input if GNUStep.
c0342369
JD
2998 (x_screen_planes): Remove.
2999 (Fxw_color_values): Use EmacsCGFloat
3000 (Fns_display_monitor_attributes_list): Only get screen number for
3001 Cocoa.
ef099a94 3002 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3003 EmacsSavePanel.
3004 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3005 ns_directory_from_panel.
3006
da9aff11
PE
30072013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 * process.c (handle_child_signal): Also use WCONTINUED.
3010 This is so that list-processes doesn't mistakenly list the process
3011 as stopped, when the process has actually been continued and is
3012 now running.
3013
0e64479a
PE
30142013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3015
fc186a96
PE
3016 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3017 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3018 not already configured.
3019
0e64479a
PE
3020 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3021
38b787fa
EZ
30222013-05-29 Eli Zaretskii <eliz@gnu.org>
3023
3024 * Makefile.in (mostlyclean): Remove *.res files.
3025
22513e52
SM
30262013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3027
3028 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3029 a buffer (bug#8447).
3030
6ef3db10
EZ
30312013-05-27 Eli Zaretskii <eliz@gnu.org>
3032
3033 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3034 display vector, and we backtrack, handle the case that the
3035 previous character position is also displayed from a display
3036 vector or covered by a display string or image. (Bug#14476)
3037
6799bb26
JD
30382013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3039
3040 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3041 (struct MonitorInfo, free_monitors): Remove.
3042 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3043 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3044 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3045 Qframes, Qsource.
3046
3047 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3048 (struct MonitorInfo, free_monitors): Remove.
3049 (ns_screen_name): Make static.
3050 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3051 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3052 Qframes, Qsource.
3053
3054 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3055 (struct MonitorInfo): New struct.
3056 (free_monitors, make_monitor_attribute_list): Declare.
3057
22513e52
SM
3058 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3059 New Lisp_Object:s.
6799bb26
JD
3060 (free_monitors, make_monitor_attribute_list): New functions.
3061 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3062 Qsource.
3063
38cd43eb
XF
30642013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3065
3066 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3067
2af0948d
SM
30682013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3069
a7eb9b0f
SM
3070 * keyboard.c: Apply keyboard decoding only to events that come directly
3071 from the tty, not from unread-command-events (bug#14368).
3072 (read_event_from_main_queue): New function, extracted from read_char).
3073 (read_decoded_char): Remove.
3074 (read_decoded_event_from_main_queue): New function to replace it.
3075 (read_char): Use it.
3076 (read_key_sequence): Use read_char rather than read_decoded_char.
3077
2af0948d
SM
3078 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3079
1413e9a5
BR
30802013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3081
3082 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3083
e6d2f155
KH
30842013-05-22 Kenichi Handa <handa@gnu.org>
3085
3086 The following changes are to fix the setting of
3087 buffer-file-coding-system on, for instance, C-x RET c unix RET
3088 _FILE_OF_DOS_EOL_TYPE_ RET.
3089
3090 * coding.h (struct coding_system): New member detected_utf8_chars.
3091
3092 * coding.c (detect_coding_utf_8): Count characters and check EOL
3093 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3094 BOM is there.
3095 (setup_coding_system): Do not initialize coding->head_ascii.
3096 (check_ascii): Do not set coding->eol_seen but update it. Do not
3097 call adjust_coding_eol_type here.
1413e9a5
BR
3098 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3099 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3100 of the found coding-system.
3101 (decode_coding_gap): Cancel previous change. Utilize the
3102 character numbers counted by detect_coding_utf_8. Fix detection
3103 of BOM for utf-8.
3104
ab56a6f4 31052013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3106
3107 * search.c (looking_at_1): Only set last_thing_searched if the match
3108 changed the match-data (bug#14281).
3109
ecc3c6ed
DA
31102013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3111
3112 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3113 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3114 (move_it_vertically_backward): Likewise.
3115
5ba8bf35
YM
31162013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3117
3118 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3119 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3120 (Fx_display_mm_width, Fx_display_mm_height):
3121 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3122
91e8418b 3123 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3124 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3125 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3126 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3127 (Fx_display_backing_store, Fx_display_visual_class)
3128 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3129 (Fx_display_grayscale_p, Fx_display_pixel_width)
3130 (Fx_display_pixel_height, Fx_display_planes)
3131 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3132 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3133 (Fx_display_mm_width, Fx_display_mm_height)
3134 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3135 height for all physical monitors as in X11.
3136
fc30d803
SM
3137 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3138 Return pixel width or height for all physical monitors as in X11.
91e8418b 3139
31ff141c
PE
31402013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 Port --enable-gcc-warnings to clang.
3143 * bytecode.c (exec_byte_code):
3144 * regex.c:
3145 Redo diagnostic pragmas to pacify clang, too.
3146 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3147 * editfns.c (Fencode_time):
3148 * fileio.c (file_accessible_directory_p):
3149 * font.c (font_unparse_xlfd):
3150 Use '&"string"[index]' instead of '"string" + (index)'.
3151 * undo.c (user_error): Remove; unused.
3152
df065a0b
EZ
31532013-05-16 Eli Zaretskii <eliz@gnu.org>
3154
04d360e7
EZ
3155 * insdel.c (insert_1_both): Document the arguments, instead of
3156 referring to insert_1, which no longer exists.
3157
5bb98290
EZ
3158 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3159 some window, increment windows_or_buffers_changed, so that
3160 *Messages* display in that window is updated. (Bug#14408)
3161
df065a0b
EZ
3162 * w32.c: Include epaths.h.
3163 (init_environment): Use cmdproxy.exe without leading directories.
3164 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3165 case.
3166 (gettimeofday): Adjust signature and return value to Posix
3167 expectations.
3168
3169 * unexw32.c (open_output_file): Delete the existing emacs.exe
3170 before creating it, to break the hard link to the versioned
3171 executable.
3172
3173 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3174 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3175 (FIRSTFILE_OBJ): New variables.
3176 (W32_RES): Rename to EMACSRES. All users changed.
3177 (base_obj): Use $(CM_OBJ).
3178 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3179 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3180 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3181 $(W32_RES_LINK) before $(LIBES).
3182 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3183
1aa8d505
SM
31842013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3185
6e911150
SM
3186 * makefile.w32-in (DOC): Use just "DOC".
3187
3188 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3189
1aa8d505
SM
3190 * process.c: Export default filters and sentinels to Elisp.
3191 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3192 New constants.
3193 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3194 (Fset_process_sentinel, Fformat_network_address):
3195 Default to them instead of nil.
3196 (server_accept_connection): Sentinels can't be nil any more.
3197 (read_and_dispose_of_process_output): New function, extracted from
3198 read_process_output.
3199 (read_process_output): Use it; filters can't be nil.
3200 (Finternal_default_process_filter): New function, extracted from
3201 read_process_output.
3202 (exec_sentinel_unwind): Remove function.
3203 (exec_sentinel): Don't zilch sentinel while running.
3204 (status_notify): Sentinels can't be nil.
3205 (Finternal_default_process_sentinel): New function extracted from
3206 status_notify.
3207 (setup_process_coding_systems): Default filter is not nil any more.
3208 (syms_of_process): Export new Elisp functions and initialize
3209 new constants.
3210 * lisp.h (make_lisp_proc): New function.
3211
5ac2eb34
SM
32122013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3213
3214 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3215
eda9c7d7
EZ
32162013-05-14 Eli Zaretskii <eliz@gnu.org>
3217
3218 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3219 unless we know that the window w is a leaf window.
3220 Another attempt at solving bug#14062.
eda9c7d7 3221
8fdeaad5
JD
32222013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3223
3224 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3225 fdesc (Bug#14375).
3226
44aa9ee6
PE
32272013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3228
3229 * image.c (gif_load): Check that subimages fit (Bug#14345).
3230
759fd763
SM
32312013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3232
3233 * lread.c (skip_dyn_eof): New function.
3234 (read1): Use it to skip the end of a file in response to #@00.
3235
3236 * doc.c (get_doc_string): Slightly relax the sanity checking.
3237
4465bfb4
JD
32382013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3239
3240 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3241 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3242 (MonitorInfo): New struct.
3243 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3244 (Fns_display_monitor_attributes_list): New functions.
3245 (display-usable-bounds): Remove.
3246 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3247 Qsource.
3248
7583e2a0
PE
32492013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3250
3251 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3252 (GTK_CHECK_VERSION): New macro, if not already defined.
3253 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3254 replaced by GTK_CHECK_VERSION.
3255
ad75d77e
PE
32562013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 * xterm.h (GTK_PREREQ): New macro.
3259 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3260 to use this macro instead, for consistency and clarity.
3261
07525f77
EZ
32622013-05-08 Eli Zaretskii <eliz@gnu.org>
3263
3264 * xdisp.c (row_for_charpos_p): New function, with code of
3265 cursor_row_p, but accepts an additional argument CHARPOS instead
3266 of using a hardcoded PT.
3267 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3268 (row_containing_pos): Call row_for_charpos_p instead of partially
3269 doing the same. Fixes cursor positioning under longlines-mode
3270 when longlines-show-effect includes more than one newline, when
3271 moving the cursor vertically up.
3272
d901fc8d
JB
32732013-05-08 Juanma Barranquero <lekktu@gmail.com>
3274
3275 * makefile.w32-in (ACL_H): New macro.
3276 ($(BLD)/fileio.$(O)): Update dependencies.
3277
f269bc61
PE
32782013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3279
e7b41c4c 3280 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3281 * Makefile.in (LIB_ACL): New macro.
3282 (LIBACL_LIBS): Remove.
3283 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3284 * fileio.c: Include <acl.h>.
3285 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3286 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3287 !acl_errno_valid.
3288 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3289 it ourselves.
3290
f269bc61
PE
3291 * unexelf.c: Don't assume ElfW (Half) fits in int.
3292 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3293 when dealing with ElfW (Half) values, since they can exceed 2**31
3294 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3295 (entry_address): Omit unused NUM arg. All uses changed.
3296
a261c53e
JL
32972013-05-07 Juri Linkov <juri@jurta.org>
3298
3299 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3300 to the string converted from number with `Fnumber_to_string'.
3301 (Bug#14254)
3302
2b66427d
PE
33032013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3306 This fixes a problem introduced by my previous change.
3307
15acfe41
GM
33082013-05-07 Glenn Morris <rgm@gnu.org>
3309
3310 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3311
5ea03bf5
JD
33122013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3313
3314 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3315
e0c9d565
PE
33162013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3317
3318 Static checking by GCC 4.8.0.
3319 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3320 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3321 (x_get_monitor_attributes_fallback)
3322 (x_get_monitor_attributes_xinerama)
3323 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3324 Define only if USE_GTK.
3325 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3326 (x_get_monitor_attributes_fallback): Omit unused locals.
3327 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3328 Use double, not float, to avoid mixed-mode floating point arithmetic.
3329
4e3f9230
YM
33302013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3331 Jan Djärv <jan.h.d@swipnet.se>
3332
3333 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3334 (XINERAMA_CFLAGS): New macros.
3335 (ALL_CFLAGS, LIBES): Use them.
3336
3337 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3338 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3339 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3340 (syms_of_xfns): DEFSYM them.
3341 (struct MonitorInfo): New struct.
3342 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3343 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3344 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3345 (x_get_monitor_attributes_xinerama): New functions.
3346 (Fx_display_monitor_attributes_list): New primitive.
3347 (syms_of_xfns): Defsubr it.
3348
3349 * xterm.h (x_display_info): Add Xatom_net_workarea and
3350 Xatom_net_current_desktop.
3351
3352 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3353 and dpyinfo->Xatom_net_current_desktop.
3354
05839b6a
EZ
33552013-05-06 Eli Zaretskii <eliz@gnu.org>
3356
3357 * xdisp.c (pos_visible_p): Use the special code for finding the
3358 beginning of a display property or overlay for any "replacing"
3359 display property, not just for display strings. This solves
3360 incorrect reporting of position by posn-at-point. (Bug#14241)
3361
dc4a2ee0
PE
33622013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3363
5ee94506
PE
3364 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3365 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3366 Verify that ElfW (Half) fits in int.
3367 (fatal): Use same signature as lisp.h.
3368 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3369 configure and build with -DUNEXELF_DEBUG without worrying about
3370 other modules that use DEBUG.
3371 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3372 possibly-wide integers now uses it instead of plain fprintf.
3373 (entry_address): New function, which avoids problems with 32-bit
3374 overflow on 64-bit hosts.
3375 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3376 (round_up): Don't assume the remainder fits in int.
3377 (find_section): Use bool for boolean. Simplify debug code.
3378 (unexec): Don't assume file sizes fit in int or size_t.
3379 Omit unnecessary trailing newline in 'fatal' format.
3380 Use strerror rather than outputting decimal error number.
3381 Remove unused code when emacs is not defined;
3382 this file relies on Emacs now.
3383 Don't assume e_phnum and e_shnum are positive.
3384
dc4a2ee0
PE
3385 * regex.c: Fix problems when DEBUG is defined.
3386 (extract_number, extract_number_and_incr): Define regardless of
3387 whether DEBUG is defined; that's simpler and makes the code less
3388 likely to go stale in the normal case when DEBUG is not defined.
3389 Return int rather than taking an int * arg. All callers changed.
3390 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3391 Remove, replacing with ...
3392 (DEBUG_PRINT): New macro. All callers changed.
3393 (DEBUG_COMPILES_ARGUMENTS): New macro.
3394 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3395 (print_compiled_pattern, print_double_string) [DEBUG]:
3396 Use prototype rather than old-style definition.
3397 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3398 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3399 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3400 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3401 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3402 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3403 This matters only when DEBUG is defined.
3404
14c7ed05
EZ
34052013-05-05 Eli Zaretskii <eliz@gnu.org>
3406
3407 * xdisp.c (set_iterator_to_next): Set the
3408 ignore_overlay_strings_at_pos_p flag only if we are _really_
3409 iterating over an overlay string, as indicated by the
3410 current.overlay_string_index member. (Bug#14306)
3411
e6076b1b
JD
34122013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3413
3414 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3415 to where it is used, to avoid autorelease issues (Bug#14050).
3416
cbee2131
PE
34172013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3420 * fileio.c (syms_of_fileio): Implement this.
3421 * filelock.c (create_lock_file): If symbolic links don't work, so
3422 we use a regular file as a lock file, do not fsync the lock file;
3423 it's not needed.
3424
30c7e542
SM
34252013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3426
3427 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3428 (syms_of_minibuf): Adjust accodingly.
3429 * lread.c (Fread):
3430 * callint.c (Fcall_interactively): Adjust calls accordingly.
3431
5bebd186
EZ
34322013-05-04 Eli Zaretskii <eliz@gnu.org>
3433
3434 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3435 w->contents is a buffer before computing everything else.
3436 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3437
3438 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3439 assertion violations. (Bug#14062)
3440
0fb0a4f3
DR
34412013-05-01 David Reitter <david.reitter@gmail.com>
3442
3443 * nsfns.m (ns_tooltip): Initialize.
3444
9e63b4a5
EZ
34452013-04-28 Eli Zaretskii <eliz@gnu.org>
3446
3447 * coding.c (decode_coding_gap): Don't remove the character before
3448 a newline unless it's a CR character. (Bug#14287)
3449
ad60824e
DN
34502013-04-28 Dan Nicolaescu <dann@gnu.org>
3451
3452 * dispextern.h (struct face): Move enum face_underline_type
3453 earlier so that bitfields can be in the same word.
3454
edbdcec0
JD
34552013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3456
3457 * nsfns.m (handlePanelKeys): New function.
3458 (EmacsOpenPanel:performKeyEquivalent:)
3459 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3460 arrows/function/control and copy/paste keys (Bug#14296).
3461
0208ede7
JL
34622013-04-27 Juri Linkov <juri@jurta.org>
3463
3464 * callint.c (Fcall_interactively): Call `Qread_number' for
3465 interactive code letter `n' instead of using duplicate code.
3466 (Bug#14254)
3467
b8dd59f7
PE
34682013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3469
3470 * systime.h (make_timeval): Declare as 'const'.
3471
8bd722db
KH
34722013-04-27 Kenichi Handa <handa@gnu.org>
3473
3474 * font.c (font_open_entity): Always open a font of manageable
3475 size.
3476
13d0e56f 34772013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3478
f780d632
PE
3479 Port better to AIX (Bug#14258).
3480 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3481 to pacify AIX xlc.
3482
ec509856
KH
34832013-04-24 Kenichi Handa <handa@gnu.org>
3484
3485 * coding.c (decode_coding_iso_2022): When an invalid escape
3486 sequence is encountered, reset the invocation and designation
3487 status to the safest one.
3488
84fc48e5
PE
34892013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3490
3491 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3492 Without this fix, "make distclean" leaves stamp-h1 behind.
3493
806bda47
EC
34942013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3495
3496 * w32fns.c (w32_fullscreen_rect): New function to compute the
3497 window rectangle for the given fullscreen mode.
3498 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3499 longer tunes the window size. This keeps the window's edges flush
3500 with the screen and allows the taskbar to hide itself in fullboth.
3501
3502 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3503 window decorations and uses the entire screen.
3504
3505 * w32term.h (w32_fullscreen_rect) Add prototype.
3506 (struct w32_output): Replace normal_width, normal_height,
3507 normal_top, and normal_left members with a single normal_placement
3508 struct.
3509 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3510 Remove macros.
3511 (FRAME_NORMAL_PLACEMENT): New macro.
3512
9cc2810b
JB
35132013-04-16 Juanma Barranquero <lekktu@gmail.com>
3514
3515 * minibuf.c (Ftest_completion): Silence compiler warning.
3516
fd16b54c
EZ
35172013-04-15 Eli Zaretskii <eliz@gnu.org>
3518
3519 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3520 bug#14062.
fd16b54c
EZ
3521
3522 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3523 parentheses.
3524
3525 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3526 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3527 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3528 parentheses where appropriate.
3529
9e3379a0
PE
35302013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3531
3532 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3533
ddd6b685
EZ
35342013-04-14 Eli Zaretskii <eliz@gnu.org>
3535
3536 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3537 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3538 Mention in the doc string that setting these variables takes
3539 effect only after a call to set-window-buffer. (Bug#14200)
3540
29b79ba1
EZ
35412013-04-13 Eli Zaretskii <eliz@gnu.org>
3542
3543 * indent.c (Fvertical_motion): Don't consider display strings on
3544 overlay strings as display strings on the buffer position we
3545 started from. This prevents vertical cursor motion from jumping
3546 more than one line when there's an overlay string with a display
3547 property at end of line.
3548 Reported by Karl Chen <Karl.Chen@quarl.org> in
3549 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3550
562c6ee9
SM
35512013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3552
3553 * window.c (select_window): `record_buffer' even if window is
3554 already selected (bug#14191).
3555
fcc1fe85
EZ
35562013-04-11 Eli Zaretskii <eliz@gnu.org>
3557
3558 * window.c (Fwindow_end): Test more flags, including the buffer's
3559 last_overlay_modified flag, to determine whether the window's
3560 display is really up-to-date. Prevents the function from
3561 returning a stale value. (Bug#14170)
3562 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3563 current matrix.
3564
f009190a
EZ
35652013-04-10 Eli Zaretskii <eliz@gnu.org>
3566
3567 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3568 garbaged only if it is not already the top frame on its TTY.
3569 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3570 there are GUI frames open in the same session. (Bug#13864)
3571
78ce603d
SM
35722013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3573
3574 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3575 of marking the idle timers directly.
3576
a8036e40
SM
35772013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3578
3579 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3580 tables (bug#14054).
3581
7ffe7ef6
SM
35822013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3583
3584 * window.c (select_window): Don't record_buffer while the invariant is
3585 temporarily broken (bug#14161).
3586
3587 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3588
7d9f6883
EZ
35892013-04-07 Eli Zaretskii <eliz@gnu.org>
3590
3591 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3592
5406cfd9
RF
35932013-04-07 Romain Francoise <romain@orebokech.com>
3594
3595 Ignore additional platform-specific ACL errors (Bug#13702).
3596 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3597 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3598
95c0e83b
JD
35992013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3600
3601 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3602 f->output_data.ns.
3603
876da980
PE
36042013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3605
3606 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3607 This bug was introduced by my 2013-02-25 change that simplified
3608 data_start configuration. Without this change, on GNU/Linux
3609 an Emacs configured with --enable-profiling fails immediately
3610 due to a profiler signal.
3611 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3612 with these flags. On platforms where special flags are needed
3613 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3614 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3615 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3616
7452b7bd
DA
36172013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3618
3619 Get rid of some platform-specific functions examining window
3620 system and its capabilities. This is a partial rework of the
3621 2013-04-05 change.
3622 * lisp.h (have_menus_p): Remove prototype. This function is
3623 replaced with platform-independent window_system_available.
3624 (check_window_system): Move to...
3625 * frame.h (decode_window_system_frame, window_system_available):
3626 ...here, add new prototypes.
3627 * frame.c (window_system_available, decode_window_system_frame):
3628 New functions.
3629 (check_window_system): Platform-independent now.
3630 * xterm.h (x_in_use): Remove declaration.
3631 (check_x_frame):
3632 * w32term.h (check_x_frame):
3633 * nsterm.h (check_x_frame): Remove prototypes. This function
3634 is replaced with platform-independent decode_window_system_frame.
3635 * msdos.c (have_menus_p): Remove.
3636 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3637 Remove platform-specific functions. Use check_window_system,
3638 decode_window_system_frame and check_ns_display_info where
3639 appropriate. Minor style and comment tweaks.
3640 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3641 (check_x_frame): Likewise.
3642 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3643 Likewise.
3644 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3645 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3646 * xmenu.c, xselect.c: All related users changed.
3647
251e9147
KH
36482013-04-03 Kenichi Handa <handa@gnu.org>
3649
3650 The following changes is to optimize the code for reading UTF-8
3651 files.
3652
562c6ee9 3653 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3654 changed. Check EOL format. Do not call adjust_coding_eol_type
3655 here.
3656 (check_utf_8): New function.
3657 (adjust_coding_eol_type): Do nothing if already adjusted.
3658 (detect_coding): Compare the return value of check_ascii with
3659 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3660 (decode_coding_gap): Optimize for valid UTF-8.
3661
8bc369d4
KH
36622013-03-21 Kenichi Handa <handa@gnu.org>
3663
3664 * coding.c (syms_of_coding): Cancel previous change.
3665
3666 * insdel.c (insert_from_gap): Fix previous change.
3667
73931ad1
DA
36682013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3669
3670 Consistently use platform-specific function to detect window system.
3671 * lisp.h (check_window_system): New prototype. This function is
3672 going to replace check_x, check_w32 and check_ns.
3673 (have_menus_p): Mention msdos.c in comment.
3674 * fontset.c (check_window_system_func): Remove. Adjust all users.
3675 * fontset.h (check_window_system_func): Remove prototype.
3676 * nsterm.h (check_ns):
3677 * xterm.h (check_x):
3678 * w32term.h (check_w32): Likewise.
3679 * menu.c (Fx_popup_menu): Use check_window_system.
3680 * msdos.c (check_window_system): Define for MS-DOS.
3681 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3682 * w32fns.c (check_window_system): Likewise for MS-Windows.
3683 * xfns.c (check_window_system): Likewise for X.
3684 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3685 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3686
7216e43b
PE
36872013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3688
3689 Prefer < to > in range checks such as 0 <= i && i < N.
3690 This makes it easier to visualize quantities on a number line.
3691 This patch doesn't apply to all such range checks,
3692 only to the range checks affected by the 2013-03-24 change.
3693 This patch reverts most of the 2013-03-24 change.
3694 * alloc.c (xpalloc, Fgarbage_collect):
3695 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3696 * character.c (string_escape_byte8):
3697 * charset.c (read_hex):
3698 * data.c (cons_to_unsigned):
3699 * dispnew.c (update_frame_1):
3700 * doc.c (Fsubstitute_command_keys):
3701 * doprnt.c (doprnt):
3702 * editfns.c (hi_time, decode_time_components):
3703 * fileio.c (file_offset):
3704 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3705 * font.c (font_intern_prop):
3706 * frame.c (x_set_alpha):
3707 * gtkutil.c (get_utf8_string):
3708 * indent.c (check_display_width):
3709 * keymap.c (Fkey_description):
3710 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3711 * lread.c (read1):
3712 * minibuf.c (read_minibuf_noninteractive):
3713 * process.c (wait_reading_process_output):
3714 * search.c (Freplace_match):
3715 * window.c (get_phys_cursor_glyph):
3716 * xdisp.c (redisplay_internal):
3717 * xsmfns.c (smc_save_yourself_CB):
3718 Prefer < to > for range checks.
3719 * dispnew.c (sit_for): Don't mishandle NaNs.
3720 This fixes a bug introduced in the 2013-03-24 change.
3721 * editfns.c (decode_time_components): Don't hoist comparison.
3722 This fixes another bug introduced in the 2013-03-24 change.
3723
92759988
DA
37242013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3725
3726 * frame.h (struct frame): Drop scroll_bottom_vpos
3727 member becaue all real users are dead long ago.
3728 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3729 * xdisp.c (redisplay_internal): Adjust user.
3730
9a1971bb
GM
37312013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3732
f38ab167
JD
3733 * nsmenu.m (showAtX:Y:for:): setLevel to
3734 NSPopUpMenuWindowLevel (Bug#13998).
3735
6d01f1fe
JD
37362013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3737
3738 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3739 (ns_check_pending_open_menu): Declare.
3740
3741 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3742 (x_activate_menubar): Update the menu with title that matches
3743 ns_get_pending_menu_title, and call
3744 ns_check_pending_openmenu (Bug#12698).
3745 (menuWillOpen:): New method.
3746 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3747
3748 * nsterm.m (menu_will_open_state, menu_mouse_point)
3749 (menu_pending_title): New varaibles.
3750 (ns_get_pending_menu_title, ns_check_menu_open)
3751 (ns_check_pending_open_menu): New functions.
3752
781f4782
DA
37532013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3754
3755 * indent.c (current_column_bol_cache): Remove leftover which is not
3756 used in Fmove_to_column any more.
3757 (current_column, scan_for_column): Adjust users.
3758 * keyboard.c (last_point_position_buffer, last_point_position_window):
3759 Remove leftovers which are not used for recording undo any more.
3760 (command_loop_1, syms_of_keyboard): Adjust users.
3761 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3762 redisplay_window any more.
3763 (move_it_to): Adjust user.
3764
1921c31b
JB
37652013-03-29 Juanma Barranquero <lekktu@gmail.com>
3766
3767 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3768 Update dependencies.
3769
717b8bcd
SM
37702013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3771
3772 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3773 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3774 forward references.
3775
e74aeda8
DA
37762013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3777
3778 * window.h (struct window): Replace hchild, vchild and buffer slots
3779 with the only contents slot. This is possible because each valid
3780 window may have either the child window (in vertical or horizontal
3781 combination) or buffer to display (for the leaf window). Using that,
3782 a lof of operations to traverse and/or change window hierarchies may
3783 be simplified. New member horizontal is used to distinguish between
3784 horizontal and vertical combinations of internal windows.
3785 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3786 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3787 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3788 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3789 Use contents slot, not buffer, where appropriate.
3790 (wset_combination): New function.
3791 (wset_buffer): Add eassert.
3792 (Fframe_first_window): Simplify the loop reaching first window.
3793 (Fwindow_buffer): Use WINDOW_LEAF_P.
3794 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3795 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3796 (unshow_buffer): Convert initial debugging check to eassert.
3797 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3798 (make_parent_window, window_resize_check, window_resize_apply)
3799 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3800 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3801 Adjust to match struct window changes.
3802 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3803 (mark_window_cursors_off, count_windows, get_leaf_windows)
3804 (foreach_window_1): Simplify the loop.
3805 * alloc.c (mark_object): Do not check for the leaf window because
3806 internal windows has no glyph matrices anyway.
3807 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3808 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3809 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3810 (build_frame_matrix_from_window_tree, mirror_make_current)
3811 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3812 (update_window_tree, set_window_update_flags): Simplify the loop.
3813 (sync_window_with_frame_matrix_rows): Enforce live window.
3814 Use contents slot, not buffer, where appropriate.
3815 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3816 and WINDOW_HORIZONTAL_COMBINATION_P.
3817 (make_frame_visible_1): Simplify the loop.
3818 Use contents slot, not buffer, where appropriate.
3819 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3820 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3821 (expose_window_tree): Likewise.
3822 Use contents slot, not buffer, where appropriate.
3823 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3824 to avoid deleted windows. Use contents slot instead of buffer.
3825 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3826 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3827 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3828 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3829
121ab1cd
EZ
38302013-03-28 Eli Zaretskii <eliz@gnu.org>
3831
ef454cf7
EZ
3832 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3833 identify the reasons for assertion violations in bug#14062 and
3834 similar ones.
21e930f8
EZ
3835 (Fx_show_tip): Fix compilation error under
3836 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3837
121ab1cd
EZ
3838 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3839 Reported by <rzl24ozi@gmail.com>.
3840
5c89ca24
DA
38412013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3842
3843 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3844 start marker...
562c6ee9
SM
3845 (unwind_with_echo_area_buffer): ...to restore it here.
3846 This is needed to ensure that...
5c89ca24
DA
3847 (redisplay_window): ...both window markers are valid here,
3848 which is verified by eassert.
3849 * editfns.c (save_excursion_save): Do not assume that
3850 selected_window always displays the buffer.
c7f53895
DA
3851 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3852 Fix comment.
5c89ca24 3853
f557c1b1
SM
38542013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3855
3856 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3857 the upcase table.
3858
40693bba 38592013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3860
3861 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3862
c86f791f
EZ
38632013-03-27 Eli Zaretskii <eliz@gnu.org>
3864
3865 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3866 since MinGW's w32api headers do. This avoids compiler warnings.
3867
3868 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3869 if already defined.
3870
c6e72e17
EZ
38712013-03-26 Eli Zaretskii <eliz@gnu.org>
3872
3873 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3874
54e95010
JD
38752013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3876
3877 * gtkutil.c (style_changed_cb): Check if frame is live and an
3878 X frame (Bug#14038).
3879
b88b62de
EZ
38802013-03-26 Eli Zaretskii <eliz@gnu.org>
3881
a18d7de6
EZ
3882 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3883 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3884 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3885 MinGW64.
8f5e14c8
EZ
3886 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3887 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3888
b88b62de
EZ
3889 Fix incompatibilities between MinGW.org and MinGW64 headers.
3890 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3891
3892 * w32.c (REPARSE_DATA_BUFFER): Guard with
3893 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3894
c074e458
JD
38952013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3896
3897 * xterm.c: Include X11/XKBlib.h
3898 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3899
908589fd
AS
39002013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3901
3902 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3903 written backwards.
3904 * blockinput.h (input_blocked_p): Likewise.
3905 * bytecode.c (exec_byte_code): Likewise.
3906 * callproc.c (call_process_kill, call_process_cleanup)
3907 (Fcall_process): Likewise.
3908 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3909 (Fccl_execute_on_string): Likewise.
3910 * character.c (string_escape_byte8): Likewise.
3911 * charset.c (read_hex): Likewise.
3912 * cm.c (calccost): Likewise.
3913 * data.c (cons_to_unsigned): Likewise.
3914 * dired.c (directory_files_internal, file_name_completion):
3915 Likewise.
3916 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3917 (sit_for): Likewise.
3918 * doc.c (Fsubstitute_command_keys): Likewise.
3919 * doprnt.c (doprnt): Likewise.
3920 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3921 * emacsgtkfixed.c: Likewise.
3922 * fileio.c (file_offset, Fwrite_region): Likewise.
3923 * floatfns.c (Fexpt, fmod_float): Likewise.
3924 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3925 Likewise.
3926 * font.c (font_intern_prop): Likewise.
3927 * frame.c (x_set_alpha): Likewise.
3928 * gtkutil.c (get_utf8_string): Likewise.
3929 * indent.c (check_display_width): Likewise.
3930 * intervals.c (create_root_interval, rotate_right, rotate_left)
3931 (split_interval_right, split_interval_left)
3932 (adjust_intervals_for_insertion, delete_node)
3933 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3934 (merge_interval_right, merge_interval_left, copy_intervals)
3935 (set_intervals_multibyte_1): Likewise.
3936 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3937 * keymap.c (Fkey_description): Likewise.
3938 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3939 * lread.c (openp, read_integer, read1, string_to_number):
3940 Likewise.
3941 * menu.c (ensure_menu_items): Likewise.
3942 * minibuf.c (read_minibuf_noninteractive): Likewise.
3943 * print.c (printchar, strout): Likewise.
3944 * process.c (create_process, Faccept_process_output)
3945 (wait_reading_process_output, read_process_output, send_process)
3946 (wait_reading_process_output): Likewise.
3947 * profiler.c (make_log, handle_profiler_signal): Likewise.
3948 * regex.c (re_exec): Likewise.
3949 * regex.h: Likewise.
3950 * search.c (looking_at_1, Freplace_match): Likewise.
3951 * sysdep.c (get_child_status, procfs_ttyname)
3952 (procfs_get_total_memory): Likewise.
3953 * systime.h (EMACS_TIME_VALID_P): Likewise.
3954 * term.c (dissociate_if_controlling_tty): Likewise.
3955 * window.c (get_phys_cursor_glyph): Likewise.
3956 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3957 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3958 Likewise.
3959 * xfns.c (Fx_window_property): Likewise.
3960 * xmenu.c (set_frame_menubar): Likewise.
3961 * xselect.c (x_get_window_property, x_handle_dnd_message):
3962 Likewise.
3963 * xsmfns.c (smc_save_yourself_CB): Likewise.
3964 * xterm.c (x_scroll_bar_set_handle): Likewise.
3965
2bf7d27a
DA
39662013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3967
3968 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3969 to be optional or nil. Adjust comment and convert it to docstring.
3970 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3971 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3972
a9ebfa0b
PE
39732013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3974
3975 Static checking by GCC 4.8-20130319.
3976 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3977 * process.c (Fset_process_datagram_address)
3978 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3979 * xdisp.c (get_char_face_and_encoding):
3980 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3981 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3982 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3983
4f3576ee
KB
39842013-03-24 Ken Brown <kbrown@cornell.edu>
3985
789b5e9a
KB
3986 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3987 fix compilation on 64-bit Cygwin, where underscores are not
3988 automatically prepended.
3989
4f3576ee
KB
3990 * w32term.c (w32_initialize): Silence compiler warning.
3991
b5b7745f
EZ
39922013-03-23 Eli Zaretskii <eliz@gnu.org>
3993
cdc0d0bd
EZ
3994 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3995 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3996 variables, to save and restore frame dimensions.
3997 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3998 after returning from a 'fullscreen' configuration.
3999 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4000 to avoid races between the main thread and the input thread.
4001
4002 * w32term.h (struct w32_output): New members normal_width,
4003 normal_height, normal_top, normal_left, and prev_fsmode.
4004 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4005 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4006 members of a frame.
4007
b5b7745f
EZ
4008 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4009 'fullscreen' parameter. Always record previous width and height
4010 of the frame, except when switching out of maximized modes, so
4011 that they could be restored correctly, instead of resetting to the
4012 default frame dimensions. Send SC_RESTORE command to the frame,
4013 unless we are going to send SC_MAXIMIZE, to restore the frame
4014 resize hints in the mouse pointer shown by the window manager.
4015 (Bug#14032)
4016
4017 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4018
4019 * lisp.h (get_frame_param): Adjust conditions for prototype
4020 declaration.
4021
a3454eed
KB
40222013-03-22 Ken Brown <kbrown@cornell.edu>
4023
4024 * unexcw.c: Drop unneeded inclusion of w32common.h.
4025 (report_sheap_usage): Declare.
4026 (read_exe_header): Add magic numbers for x86_64.
4027 (fixup_executable): Fix printf format specifier for unsigned long
4028 argument.
4029
5a49b79c
DA
40302013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4031
4032 * frame.h (struct frame): Put menu_bar_window under #ifdef
4033 because this member is not needed when X toolkit is in use.
4034 (fset_menu_bar_window):
4035 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4036 (free_glyphs, update_frame):
4037 * xdisp.c (expose_frame): Likewise.
4038 (display_menu_bar): Likewise. Remove redundant eassert.
4039 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4040 toolkit is in use.
4041
d6723bf7
PE
40422013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4043
7b1123d8
PE
4044 Use functions and constants to manipulate Lisp_Save_Value objects.
4045 This replaces code that used macros and strings and token-pasting.
4046 The change makes the C source a bit easier to follow,
4047 and shrinks the Emacs executable a bit.
4048 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4049 (make_save_value): Change 1st arg from string to enum. All callers
4050 changed.
4051 (INTX): Remove.
4052 (mark_object): Use if, not #if, for GC_MARK_STACK.
4053 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4054 (XSAVE_OBJECT): Now functions, not macros.
4055 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4056 the constant was never used.
4057 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4058 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4059 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4060 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4061 New constants.
4062 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4063 type3 with a single member save_type. All uses changed.
4064 (save_type, set_save_pointer, set_save_integer): New functions.
4065 * print.c (PRINTX): Remove.
4066
d6723bf7
PE
4067 * alloc.c: Remove redundant static declarations.
4068
5f24fa51
DA
40692013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4070
4071 * window.h (struct window): Convert left_col, top_line, total_lines
4072 and total_cols from Lisp_Objects to integers. Adjust comments.
4073 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4074 Remove.
4075 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4076 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4077 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4078 Adjust users where appropriate.
4079
42143acd
DA
40802013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4081
4082 * frame.h (struct frame): Drop resx and resy because the same data is
4083 available from window system-specific output context. Adjust users.
562c6ee9
SM
4084 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4085 New functions to provide defaults when no window system available.
42143acd 4086 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4087 (NUMVAL): Move from xdisp.c.
42143acd
DA
4088 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4089 (Ffont_face_attributes, Fopen_font):
4090 * image.c (gs_load):
4091 * w32font.c (fill_in_logfont):
4092 * xdisp.c (calc_pixel_width_or_height):
4093 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4094 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4095
c0a17406
KH
40962013-03-20 Kenichi Handa <handa@gnu.org>
4097
4098 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4099 to 1 (temporary workaround until a bug related to ASCII
4100 optimization is fixed).
4101
095d384d
DA
41022013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4103
4104 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4105 Signal error if window is not internal. Adjust docstring.
4106 (delete_all_child_windows): Use combination_limit to save the buffer.
4107 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4108 * print.c (syms_of_print): Initialize debugging output not here...
4109 (init_print_once): ...but in a new function here.
4110 * lisp.h (init_print_once): Add prototype.
4111 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4112
748fa866
DA
41132013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4114
4115 * window.c (window_resize_check, window_resize_apply)
4116 (window_from_coordinates, recombine_windows, set_window_buffer)
4117 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4118 (Fsplit_window_internal, Fdelete_window_internal)
4119 (freeze_window_starts): Use bool for booleans.
4120 * window.h (window_frame_coordinates, resize_frame_windows)
4121 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4122
81519fd2
SM
41232013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4124
4125 * dispnew.c (bitch_at_user): Use `user-error'.
4126
6db423a9
KB
41272013-03-17 Ken Brown <kbrown@cornell.edu>
4128
4129 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4130 as return type of image_background. (Bug#13981)
4131 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4132
8f2906f5
JD
41332013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4134
960ce480 4135 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4136 (ns_select): Don't return with result uninitialized.
960ce480 4137
8f2906f5
JD
4138 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4139 and getDirectory.
4140
81519fd2
SM
4141 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4142 New functions.
8f2906f5
JD
4143 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4144 directories. If filename is nil, get directory name (Bug#13932).
4145 Use getFilename and getDirectory.
4146 (getFilename, getDirectory): New methods for EmacsSavePanel and
4147 EmacsOpenPanel.
4148 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4149
cded56c1
PE
41502013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4151
4152 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4153
251e9147 41542013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4155
4156 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4157 (adjust_after_replace): Make it back to static. Delete the third
4158 arg text_at_gap_tail. Cancel the code for handling it.
4159
4160 * coding.h (struct coding_system): New member eol_seen.
4161
4162 * coding.c (detect_ascii): New function.
4163 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4164 when the source bytes are actually scanned. On detecting for
4165 coding_category_utf_8_auto, call detect_ascii instead of scanning
4166 source bytes directly.
4167 (produce_chars): Call insert_from_gap with the new arg 0.
4168 (encode_coding): Likewise.
4169 (decode_coding_gap): Control ASCII optimization by the variable
4170 disable_ascii_optimization instead of #ifndef .. #endif.
4171 Deccode EOL format according to coding->eol_seen.
4172 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4173 variable.
4174
8a44e6d1
KH
4175 * lisp.h (adjust_after_replace): Cancel externing it.
4176 (insert_from_gap): Adjust prototype.
4177
5f795e34
EZ
41782013-03-15 Eli Zaretskii <eliz@gnu.org>
4179
4180 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4181 FULLSCREEN_MAXIMIZED. (Bug#13935)
4182
f258b4be
DA
41832013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4184
4185 * region-cache.c (find_cache_boundary, move_cache_gap)
4186 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4187 Simplify debugging check and convert to eassert. Adjust comment.
4188 (pp_cache): Put under ENABLE_CHECKING.
4189
a5cc4dde
EZ
41902013-03-14 Eli Zaretskii <eliz@gnu.org>
4191
4192 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4193 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4194 and WM_ACTIVATEAPP.
4195 (w32fullscreen_hook): If the frame is visible, reset
4196 f->want_fullscreen flag after changing the frame size. If the
4197 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4198 (Bug#13953)
4199
3fc5e44a
DC
42002013-03-13 Daniel Colascione <dancol@dancol.org>
4201
4202 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4203 too so that these builds can use Cygwin's file conversion
4204 functions. (We've been building and linking cygw32.o all along
4205 and just not using it.)
4206
47d7532e
PE
42072013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4208
4209 File synchronization fixes (Bug#13944).
4210 * Makefile.in (LIB_FDATASYNC): New macro.
4211 (LIBES): Use it.
4212 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4213 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4214 Don't worry about HAVE_FSYNC, since a substitute fsync is
4215 available if the system lacks one.
4216 (Fwrite_regin): Retry fsync if interrupted.
4217
c7ffccaf
EZ
42182013-03-13 Eli Zaretskii <eliz@gnu.org>
4219
4e2df81d 4220 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4221 activated, call w32fullscreen_hook, to make sure the new frame
4222 dimensions are in effect. (Bug#13937)
4223
8a7debc1
DA
42242013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4225
4226 * xdisp.c (init_iterator): Simplify because both character and byte
4227 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4228 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4229 character and byte positions can be obtained from marker.
8a7debc1 4230
7fd8c501
PE
42312013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4232
d9df6f40
PE
4233 Static checking by Sun C 5.12.
4234 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4235 * bytecode.c (exec_byte_code):
4236 * dispnew.c (init_display):
4237 * eval.c (error):
4238 * fileio.c (Fsubstitute_in_file_name):
4239 * keyboard.c (Fevent_convert_list):
4240 * keymap.c (Fsingle_key_description):
4241 * term.c (maybe_fatal, fatal):
4242 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4243 * xsmfns.c (Fhandle_save_session):
4244 Omit unreachable code.
4245 * keymap.c (map_keymap_char_table_item): Cast void * to
4246 a function pointer type; the C Standard requires this.
4247
7fd8c501
PE
4248 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4249 Include <sys/param.h> unconditionally, as that works elsewhere and
4250 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4251 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4252 and FreeBSD now.
4253
a020afb9 4254See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4255
4256;; Local Variables:
4257;; coding: utf-8
aac0c6e3
MR
4258;; End:
4259
ab422c4d 4260 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4261
4262 This file is part of GNU Emacs.
4263
4264 GNU Emacs is free software: you can redistribute it and/or modify
4265 it under the terms of the GNU General Public License as published by
4266 the Free Software Foundation, either version 3 of the License, or
4267 (at your option) any later version.
4268
4269 GNU Emacs is distributed in the hope that it will be useful,
4270 but WITHOUT ANY WARRANTY; without even the implied warranty of
4271 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4272 GNU General Public License for more details.
4273
4274 You should have received a copy of the GNU General Public License
4275 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.