* lisp/url/url-handlers.el (url-file-name-completion)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f4b169ce
PE
12013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
4 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
5 Do not assume that emacs_close (INT_MAX) is a no-op.
6
bee6a2c7
DA
72013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
8
9 * xfaces.c (make_face_cache): For struct face_cache, prefer
10 xmalloc to xzalloc and so avoid redundant call to memset.
11 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
12
d7e6881a
DA
132013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
14
15 * fringe.c (draw_window_fringes, update_window_fringes)
16 (compute_fringe_widths):
17 * w32term.c (x_draw_glyph_string):
18 * window.c (candidate_window_p, Frecenter):
19 * xfaces.c (realize_basic_faces, realize_default_face)
20 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
21 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
22 * xfns.c (x_set_cursor_color, xic_free_xfontset):
23 * xmenu.c (Fx_menu_bar_open_internal):
24 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
25 * xsettings.c (xft_settings_event):
26 * xterm.c (x_draw_glyph_string, x_had_errors_p):
27 Use bool for booleans. Adjust style and comments where
28 appropriate.
29 * dispextern.h (draw_window_fringes, update_window_fringes)
30 (compute_fringe_widths):
31 * xterm.h (x_had_errors_p): Adjust prototype.
32
ec3058af
DA
332013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
34
35 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
36 CHECK_LIST. Rewrite the loop to avoid useless local variable.
37
218e0637
DA
382013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
39
40 * fns.c (toplevel): Remove comment before Fsafe_length because
41 it checks for QUIT.
42
e560aba9
PE
432013-07-28 Paul Eggert <eggert@cs.ucla.edu>
44
45 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
46
2e5ce5de
EZ
472013-07-28 Eli Zaretskii <eliz@gnu.org>
48
49 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
50 frame which got the message is still alive, before dereferencing
51 its pointer. (Bug#14970)
52
53 * frame.c (delete_frame): Test "this" frame's minibuffer window to
54 be a live window, before using it as such. (Bug#14970)
55
e95da6d3
EZ
562013-07-27 Eli Zaretskii <eliz@gnu.org>
57
58 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
59 w32_detect_focus_change instead of doing part of its job by hand.
60 This fixes the problem whereby FOCUS_OUT events were not sent to
61 the event queue.
62
a8f93651
EZ
632013-07-26 Eli Zaretskii <eliz@gnu.org>
64
fec92060
EZ
65 * process.c (Fprocess_list): Doc fix.
66
a8f93651
EZ
67 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
68 being re-exposed only if it didn't ask to become visible.
69 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
70 was previously iconified. (Bug#14841)
71 (x_iconify_frame): Mark the frame iconified.
72
d5a7a9d9
PE
732013-07-26 Paul Eggert <eggert@cs.ucla.edu>
74
75 Fix minor problems found by static checking.
76 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
77 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
78
56ea7291
SM
792013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
80
81 * eval.c (set_specpdl_old_value): New function.
82 (unbind_to): Minor simplification.
83 (get_backtrace_frame): New function.
84 (Fbacktrace_frame): Use it. Add `base' argument.
85 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
86 (syms_of_eval): Export backtrace-eval.
87 * xterm.c (x_focus_changed): Simplify.
88
9d611ffe
PE
892013-07-25 Paul Eggert <eggert@cs.ucla.edu>
90
91 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
92
999c74e3
EZ
932013-07-24 Eli Zaretskii <eliz@gnu.org>
94
95 * xdisp.c (redisplay_window): Instead of moving point out of
96 scroll margin, reject the force_start method, and try scrolling
97 instead. (Bug#14780)
98
198fa217
KB
992013-07-24 Ken Brown <kbrown@cornell.edu>
100
101 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
102 (Bug#14944).
103
53840e55
PE
1042013-07-24 Paul Eggert <eggert@cs.ucla.edu>
105
106 * eval.c (Fprogn): Do not check that BODY is a proper list.
107 This undoes the previous change. The check slows down the
108 interpreter, and is not needed to prevent a crash. See
109 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
110
60967f56
GM
1112013-07-23 Glenn Morris <rgm@gnu.org>
112
113 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
114
9ca960e2
PE
1152013-07-23 Paul Eggert <eggert@cs.ucla.edu>
116
a29c3e6d
PE
117 Port to GNU/Linux systems with tinfo but not ncurses.
118 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
119 to decide whether ncurses is being used. Without this change,
120 GCC complains about tgetent not being declared, on a system
121 that has tinfo installed but ncurses not installed.
122
f274311c
PE
123 * eval.c (Fprogn): Check that BODY is a proper list.
124
16b0520a
PE
125 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
126 * data.c (Fsetq_default):
127 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
128 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
129 (Fcondition_case):
130 Tune by taking advantage of the fact that ARGS is always a list
131 when a function is declared to have UNEVALLED args.
132
9ca960e2
PE
133 * emacsgtkfixed.c: Port to GCC 4.6.
134 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
135
afacaa1b
JB
1362013-07-23 Juanma Barranquero <lekktu@gmail.com>
137
138 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
139 here to silence compiler warnings.
140
368a85a4
PE
1412013-07-22 Paul Eggert <eggert@cs.ucla.edu>
142
143 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
144 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
145 from messing up Emacs's 'struct frame' (Bug#14923).
146
f4e891b5
PE
1472013-07-21 Paul Eggert <eggert@cs.ucla.edu>
148
149 * alloc.c (make_save_ptr_ptr): Define this function.
150 It was inadvertently omitted. It's needed only if
151 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
152
96c8b65e
JD
1532013-07-21 Jan Djärv <jan.h.d@swipnet.se>
154
155 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
156 frame have focus (Bug#14895).
157
ee010797
PE
1582013-07-21 Paul Eggert <eggert@cs.ucla.edu>
159
160 Avoid vfork-related deadlock more cleanly.
161 * callproc.c (child_setup): When the child's exec fails, output
162 the program name, as that's more useful. Use O_NONBLOCK to avoid
163 deadlock.
164 * process.c (create_process_1): Remove; no longer needed.
165 (create_process): Remove timer hack; no longer needed, now that
166 the child avoids deadlock.
167
f0398ec1 1682013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
169
170 * image.c (Fimage_flush): Fix doc typo.
171
b2a069c2
PE
1722013-07-20 Paul Eggert <eggert@cs.ucla.edu>
173
6496aec9
PE
174 Fix array bounds violation when pty allocation fails.
175 * process.c (PTY_NAME_SIZE): New constant.
176 (pty_name): Remove static variable; it's now auto.
177 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
178 Take pty_name as an arg rather than using a static variable.
179 All callers changed.
180 (create_process): Recover pty_flag from process, not from volatile local.
181 (create_pty): Stay inside array even when pty allocation fails.
182 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
183
b2a069c2
PE
184 * lread.c (Fload): Avoid initialization only when lint checking.
185 Mention that it's needed only for older GCCs.
186
99107004
KH
1872013-07-20 Kenichi Handa <handa@gnu.org>
188
189 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
190 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
191
6b1b199d
AS
1922013-07-20 Andreas Schwab <schwab@linux-m68k.org>
193
194 * lread.c (Fload): Avoid uninitialized warning.
195
4195afc3
PE
1962013-07-19 Paul Eggert <eggert@cs.ucla.edu>
197
3f5bef16
PE
198 Fix some minor file descriptor leaks and related glitches.
199 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
200 (create_lock_file): Use write, not emacs_write.
201 * image.c (slurp_file, png_load_body):
202 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
203 (server_accept_connection):
204 Don't leak an fd on memory allocation failure.
205 * image.c (slurp_file): Add a cheap heuristic for growing files.
206 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
207 as that's what the other routines do. Maybe input need not be
208 blocked at all, but it's better to be consistent.
209 Avoid undefined behavior when strlen is zero.
210
4195afc3
PE
211 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
212 (NSTATICS): Now a constant; doesn't need to be a macro.
213
a1aeeffe
RS
2142013-07-19 Richard Stallman <rms@gnu.org>
215
216 * coding.c (decode_coding_utf_8): Add simple loop for fast
217 processing of ASCII characters.
218
63b34baa
PE
2192013-07-19 Paul Eggert <eggert@cs.ucla.edu>
220
221 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
222
621dd9ac
EZ
2232013-07-19 Eli Zaretskii <eliz@gnu.org>
224
225 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
226 unportable 'struct x_display_info'.
227 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
228 is a portable type.
229
1396ac86
PE
2302013-07-19 Paul Eggert <eggert@cs.ucla.edu>
231
ab9980cd
PE
232 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
233 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
234 or fscanf fails.
235 (system_process_attributes): Prefer plain char to unsigned char
236 when either will do. Clean up properly if interrupted or if
237 memory allocations fail. Don't assume sscanf succeeds. Remove
238 no-longer-needed workaround to stop GCC from whining. Read
239 command-line once, instead of multiple times. Check read status a
240 bit more carefully.
241
1396ac86
PE
242 Fix obscure porting bug with varargs functions.
243 The code assumed that int is treated like ptrdiff_t in a vararg
244 function, which is not a portable assumption. There was a similar
245 -- though these days less likely -- porting problem with various
246 assumptions that pointers of different types all smell the same as
247 far as vararg functions is conserved. To make this problem less
248 likely in the future, redo the API to use varargs functions.
249 * alloc.c (make_save_value): Remove this vararg function.
250 All uses changed to ...
251 (make_save_int_int_int, make_save_obj_obj_obj_obj)
252 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
253 New functions.
254 (make_save_ptr): Rename from make_save_pointer, for consistency with
255 the above. Define only on platforms that need it. All uses changed.
256
4d19d194
PE
2572013-07-18 Paul Eggert <eggert@cs.ucla.edu>
258
259 * keyboard.c: Try to fix typos in previous change.
260 (DISPLAY_LIST_INFO): New macro.
261 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 262 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 263
945c5bb1
JB
2642013-07-18 Juanma Barranquero <lekktu@gmail.com>
265
266 * keyboard.c (kbd_buffer_get_event):
267 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
268 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
269
f4b1eb36
PE
2702013-07-18 Paul Eggert <eggert@cs.ucla.edu>
271
5e679a2c
PE
272 * filelock.c: Fix unlikely file descriptor leaks.
273 (get_boot_time_1): Rework to avoid using emacs_open.
274 This doesn't actually fix a leak, but is better anyway.
275 (read_lock_data): Use read, not emacs_read.
276
a8cd4836
PE
277 * doc.c: Fix minor memory and file descriptor leaks.
278 * doc.c (get_doc_string): Fix memory leak when doc file absent.
279 (get_doc_string, Fsnarf_documentation):
280 Fix file descriptor leak on error.
281
ef30e638
PE
282 * term.c: Fix minor fdopen-related file descriptor leaks.
283 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
284 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
285
f4b1eb36
PE
286 * charset.c: Fix file descriptor leaks and errno issues.
287 Include <errno.h>.
288 (load_charset_map_from_file): Don't leak file descriptor on error.
289 Use plain record_xmalloc since the allocation is larger than
290 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
291 of entries.
292 * eval.c (record_unwind_protect_nothing):
293 * fileio.c (fclose_unwind):
294 New functions.
295 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
296 The replacement doesn't block input, but that no longer seems
297 necessary.
298
b648c163
PE
2992013-07-17 Paul Eggert <eggert@cs.ucla.edu>
300
a0931322
PE
301 * lread.c: Fix file descriptor leaks and errno issues.
302 (Fload): Close some races that leaked fds or streams when 'load'
303 was interrupted.
304 (Fload, openp): Report error number of last nontrivial failure to open.
305 ENOENT counts as trivial.
306 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
307 New functions.
308 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
309 now that the function is always called with a nonnegative arg.
310 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
311 All uses replaced with ...
312 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
313
b648c163
PE
314 A few more minor file errno-reporting bugs.
315 * callproc.c (Fcall_process):
316 * doc.c (Fsnarf_documentation):
317 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
318 * process.c (set_socket_option):
319 Don't let a constructor trash errno.
320 * doc.c: Include <errno.h>.
321
b1dc4084
JB
3222013-07-16 Juanma Barranquero <lekktu@gmail.com>
323
324 * w32fns.c (unwind_create_tip_frame): Fix declaration.
325
c43843aa
PE
3262013-07-16 Paul Eggert <eggert@cs.ucla.edu>
327
50a30cce
PE
328 Fix w32 bug with call-process-region (Bug#14885).
329 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
330 to Fcall_process when the input is empty. This simplifies the
331 code a bit. It makes no difference on POSIXish platforms but
332 apparently it fixes a bug on w32.
333
334 Fix bug where insert-file-contents closes a file twice. (Bug#14839).
41d48a42
PE
335 * fileio.c (close_file_unwind): Don't close if FD is negative;
336 this can happen when unwinding a zapped file descriptor.
337 (Finsert_file_contents): Unwind-protect the fd before the point marker,
338 in case Emacs runs out of memory between the two unwind-protects.
339 Don't trash errno when closing FD.
340 Zap the FD in the specpdl when closing it, instead of deferring
341 the removal of the unwind-protect; this fixes a bug where a child
342 function unwinds the stack past us.
343
27e498e6
PE
344 New unwind-protect flavors to better type-check C callbacks.
345 This also lessens the need to write wrappers for callbacks,
346 and the need for make_save_pointer.
347 * alloca.c (free_save_value):
348 * atimer.c (run_all_atimers):
349 Now extern.
350 * alloc.c (safe_alloca_unwind):
351 * atimer.c (unwind_stop_other_atimers):
352 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
353 * menu.c (cleanup_popup_menu) [HAVE_NS]:
354 * minibuf.c (choose_minibuf_frame_1):
355 * process.c (make_serial_process_unwind):
356 * xdisp.h (pop_message_unwind):
357 * xselect.c (queue_selection_requests_unwind):
358 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
359 * alloca.c (record_xmalloc):
360 Prefer record_unwind_protect_ptr to record_unwind_protect with
361 make_save_pointer.
362 * alloca.c (Fgarbage_collect):
363 Prefer record_unwind_protect_void to passing a dummy.
364 * buffer.c (restore_buffer):
365 * window.c (restore_window_configuration):
366 * xfns.c, w32fns.c (do_unwind_create_frame)
367 New wrapper. All record-unwind uses of wrappee changed.
368 * buffer.c (set_buffer_if_live):
369 * callproc.c (call_process_cleanup, delete_temp_file):
370 * coding.c (code_conversion_restore):
371 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
372 * editfns.c (save_excursion_restore)
373 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
374 (save_restriction_restore):
375 * eval.c (restore_stack_limits, un_autoload):
376 * fns.c (require_unwind):
377 * keyboard.c (recursive_edit_unwind, tracking_off):
378 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
379 * macros.c (pop_kbd_macro, restore_menu_items):
380 * nsfns.m (unwind_create_frame):
381 * print.c (print_unwind):
382 * process.c (start_process_unwind):
383 * search.c (unwind_set_match_data):
384 * window.c (select_window_norecord, select_frame_norecord):
385 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
386 (fast_set_selected_frame):
387 * xfns.c, w32fns.c (unwind_create_tip_frame):
388 Return void, not a dummy Lisp_Object. All uses changed.
389 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
390 * callproc.c (call_process_kill):
391 * fileio.c (restore_point_unwind, decide_coding_unwind)
392 (build_annotations_unwind):
393 * insdel.c (Fcombine_after_change_execute_1):
394 * keyboard.c (read_char_help_form_unwind):
395 * menu.c (unuse_menu_items):
396 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
397 * sound.c (sound_cleanup):
398 * xdisp.c (unwind_redisplay):
399 * xfns.c (clean_up_dialog):
400 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
401 Accept no args and return void, instead of accepting and returning
402 a dummy Lisp_Object. All uses changed.
403 * cygw32.c (fchdir_unwind):
404 * fileio.c (close_file_unwind):
405 * keyboard.c (restore_kboard_configuration):
406 * lread.c (readevalllop_1):
407 * process.c (wait_reading_process_output_unwind):
408 Accept int and return void, rather than accepting an Emacs integer
409 and returning a dummy object. In some cases this fixes an
410 unlikely bug when the corresponding int is outside Emacs integer
411 range. All uses changed.
412 * dired.c (directory_files_internal_unwind):
413 * fileio.c (do_auto_save_unwind):
414 * gtkutil.c (pop_down_dialog):
415 * insdel.c (reset_var_on_error):
416 * lread.c (load_unwind):
417 * xfns.c (clean_up_file_dialog):
418 * xmenu.c, nsmenu.m (pop_down_menu):
419 * xmenu.c (cleanup_widget_value_tree):
420 * xselect.c (wait_for_property_change_unwind):
421 Accept pointer and return void, rather than accepting an Emacs
422 save value encapsulating the pointer and returning a dummy object.
423 All uses changed.
424 * editfns.c (Fformat): Update the saved pointer directly via
425 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
426 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
427 (unwind_body): New function.
428 (record_unwind_protect): First arg is now a function returning void,
429 not a dummy Lisp_Object.
430 (record_unwind_protect_ptr, record_unwind_protect_int)
431 (record_unwind_protect_void): New functions.
432 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
433 * fileio.c (struct auto_save_unwind): New type.
434 (do_auto_save_unwind): Use it.
435 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
436 * insdel.c (struct rvoe_arg): New type.
437 (reset_var_on_error): Use it.
438 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
439 New constants.
440 (specbinding_func): Remove; there are now several such functions.
441 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
442 (set_unwind_protect_ptr): New function.
443 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
444
4e604a5d
PE
445 Be simpler and more consistent about reporting I/O errors.
446 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
447 Say "Read error" and "Write error", rather than "I/O error", or
448 "IO error reading", or "IO error writing", when a read or write
449 error occurs.
450 * process.c (Fmake_network_process, wait_reading_process_output)
451 (send_process, Fprocess_send_eof, wait_reading_process_output):
452 Capitalize diagnostics consistently. Put "failed foo" at the
453 start of the diagnostic, so that we don't capitalize the
454 function name "foo". Consistently say "failed" for such
455 diagnostics.
456 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
457 All callers changed. This is so it can use report_file_error.
458 * sysdep.c (serial_open, serial_configure): Capitalize I/O
459 diagnostics consistently as above.
460
a9757f6a
PE
461 * fileio.c (report_file_errno): Fix errno reporting bug.
462 If the file name is neither null nor a pair, package it up as a
463 singleton list. All callers changed, both to this function and to
464 report_file_error. This fixes a bug where the memory allocator
465 invoked by list1 set errno so that the immediately following
466 report_file_error reported the wrong errno value.
467
c43843aa
PE
468 Fix minor problems found by --enable-gcc-warnings.
469 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
470 * keyboard.c (kbd_buffer_get_event): Remove unused local.
471
18c26d81
JD
4722013-07-16 Jan Djärv <jan.h.d@swipnet.se>
473
474 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
475 Set event->arg to Qt if switch-event shall be generated.
476 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
477
478 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
479
480 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
481 FOCUS_OUT_EVENT.
482
483 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
484 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
485 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
486 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
487 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
488 and there is a focused frame.
489 (head_table): Add focus-in and focus-out.
490 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
491 bind to handle-focus-in/out.
492
493 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
494 (Fhandle_switch_frame): Call Fhandle_focus_in.
495 (syms_of_frame): defsubr handle-focus-in/out.
496
6c6f1994
PE
4972013-07-16 Paul Eggert <eggert@cs.ucla.edu>
498
c7ddc792
PE
499 Fix porting bug to older POSIXish platforms (Bug#14862).
500 * sysdep.c (emacs_pipe): New function, that implements
501 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
502 This should port better to CentOS 5 and to Mac OS X 10.6.
503 All calls to pipe2 changed.
504
6c6f1994
PE
505 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
506 This makes the code easier to read and the executable a bit smaller.
507 Do not replace all calls to Fcons that happen to create lists,
508 just calls that are intended to create lists. For example, when
509 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
510 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
511 Similarly for list2 through list5.
512 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
513 * bytecode.c (exec_byte_code):
514 * callint.c (quotify_arg, Fcall_interactively):
515 * callproc.c (Fcall_process, create_temp_file):
516 * charset.c (load_charset_map_from_file)
517 (Fdefine_charset_internal, init_charset):
518 * coding.c (get_translation_table, detect_coding_system)
519 (Fcheck_coding_systems_region)
520 (Fset_terminal_coding_system_internal)
521 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
522 * composite.c (update_compositions, Ffind_composition_internal):
523 * dired.c (directory_files_internal, file_name_completion)
524 (Fsystem_users):
525 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
526 * doc.c (Fsnarf_documentation):
527 * editfns.c (Fmessage_box):
528 * emacs.c (main):
529 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
530 (Feval, eval_sub, Ffuncall, apply_lambda):
531 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
532 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
533 (Fset_file_times, Finsert_file_contents)
534 (Fchoose_write_coding_system, Fwrite_region):
535 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
536 * font.c (font_registry_charsets, font_parse_fcname)
537 (font_prepare_cache, font_update_drivers, Flist_fonts):
538 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
539 * frame.c (make_frame, Fmake_terminal_frame)
540 (x_set_frame_parameters, x_report_frame_params)
541 (x_default_parameter, Fx_parse_geometry):
542 * ftfont.c (syms_of_ftfont):
543 * image.c (gif_load):
544 * keyboard.c (command_loop_1):
545 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
546 (Fcopy_keymap, append_key, Fcurrent_active_maps)
547 (Fminor_mode_key_binding, accessible_keymaps_1)
548 (Faccessible_keymaps, Fwhere_is_internal):
549 * lread.c (read_emacs_mule_char):
550 * menu.c (find_and_return_menu_selection):
551 * minibuf.c (get_minibuffer):
552 * nsfns.m (Fns_perform_service):
553 * nsfont.m (ns_script_to_charset):
554 * nsmenu.m (ns_popup_dialog):
555 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
556 (Fx_own_selection_internal):
557 * nsterm.m (append2):
558 * print.c (Fredirect_debugging_output)
559 (print_prune_string_charset):
560 * process.c (Fdelete_process, Fprocess_contact)
561 (Fformat_network_address, set_socket_option)
562 (read_and_dispose_of_process_output, write_queue_push)
563 (send_process, exec_sentinel):
564 * sound.c (Fplay_sound_internal):
565 * textprop.c (validate_plist, add_properties)
566 (Fput_text_property, Fadd_face_text_property)
567 (copy_text_properties, text_property_list, syms_of_textprop):
568 * unexaix.c (report_error):
569 * unexcoff.c (report_error):
570 * unexsol.c (unexec):
571 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
572 (Fformat_mode_line, syms_of_xdisp):
573 * xfaces.c (set_font_frame_param)
574 (Finternal_lisp_face_attribute_values)
575 (Finternal_merge_in_global_face, syms_of_xfaces):
576 * xfns.c (x_default_scroll_bar_color_parameter)
577 (x_default_font_parameter, x_create_tip_frame):
578 * xfont.c (xfont_supported_scripts):
579 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
580 (menu_help_callback, xmenu_show):
581 * xml.c (make_dom):
582 * xterm.c (set_wm_state):
583 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
584 and similarly for list2 through list5.
585
bafe80ce
PE
5862013-07-15 Paul Eggert <eggert@cs.ucla.edu>
587
588 * callproc.c (Fcall_process_region): Fix minor race and tune.
589 (create_temp_file): New function, with the temp-file-creation part
590 of the old Fcall_process_region. Use Fcopy_sequence to create the
591 temp file name, rather than alloca + build_string, for simplicity.
592 Don't bother to block input around the temp file creation;
593 shouldn't be needed. Simplify use of mktemp. Use
594 record_unwind_protect immediately after creating the temp file;
595 this closes an unlikely race where the temp file was not removed.
596 Use memcpy rather than an open-coded loop.
597 (Fcall_process_region): Use the new function. If the input is
598 empty, redirect from /dev/null rather than from a newly created
599 empty temp file; this avoids unnecessary file system traffic.
600
4700b5a5
PE
6012013-07-14 Paul Eggert <eggert@cs.ucla.edu>
602
5c97beae
PE
603 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
604 Simplify by making this case like the other two. This is a bit
605 slower on obsolete hosts, but the extra complexity isn't worth it.
606
4700b5a5
PE
607 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
608 * process.c (create_process) [!DOS_NT]:
609 Remove now-unnecessary calls to emacs_close.
610
f9a74c4c
EZ
6112013-07-13 Eli Zaretskii <eliz@gnu.org>
612
922ae7ee
EZ
613 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
614 returning early. (Bug#14850)
615
f9a74c4c
EZ
616 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
617 and inhibit-iso-escape-detection attributes of 'undecided'.
618 (Bug#14822)
619
5e301d76
PE
6202013-07-13 Paul Eggert <eggert@cs.ucla.edu>
621
69e0e5ee
PE
622 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
623 Reported by Herbert J. Skuhra in
624 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
625
5e301d76
PE
626 Don't lose top specpdl entry when memory is exhausted.
627 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
628 specpdl overflow here, to simplify callers; all callers changed.
629 Always reserve an unused entry at the stack top; this avoids
630 losing the top entry's information when memory is exhausted.
631
7e649856
PE
6322013-07-12 Paul Eggert <eggert@cs.ucla.edu>
633
a773ed9a
PE
634 Clean up errno reporting and fix some errno-reporting bugs.
635 * callproc.c (Fcall_process):
636 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
637 * process.c (create_process, Fmake_network_process):
638 * unexaix.c (report_error):
639 * unexcoff.c (report_error):
640 Be more careful about reporting the errno of failed operations.
641 The code previously reported the wrong errno sometimes.
642 Also, prefer report_file_errno to setting errno + report_file_error.
643 (Fcall_process): Look at openp return value rather than at path,
644 as that's a bit faster and clearer when there's a numeric predicate.
645 * fileio.c (report_file_errno): New function, with most of the
646 old contents of report_file_error.
647 (report_file_error): Use it.
648 (Ffile_exists_p, Ffile_accessible_directory_p):
649 Set errno to 0 when it is junk.
650 * fileio.c (Faccess_file):
651 * image.c (x_create_bitmap_from_file):
652 Use faccessat rather than opening the file, to avoid the hassle of
653 having a file descriptor open.
654 * lisp.h (report_file_errno): New decl.
655 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
656
7e649856
PE
657 Minor EBADF fixes.
658 * process.c (create_process, wait_reading_process_output) [AIX]:
659 Remove obsolete SIGHUP-related code, as Emacs no longer disables
660 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
661 a multithreaded environment anyway).
662 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
663
f6774c1a
AS
6642013-07-12 Andreas Schwab <schwab@linux-m68k.org>
665
666 * image.c (x_find_image_file): Don't close a remote file handle.
667
bacba3c2
PE
6682013-07-12 Paul Eggert <eggert@cs.ucla.edu>
669
670 Fix races with threads and file descriptors.
671 * callproc.c (Fcall_process_region):
672 * dired.c (open_directory):
673 * emacs.c (main, Fdaemon_initialized):
674 * image.c (x_find_image_file):
675 * inotify.c (Finotify_rm_watch):
676 * lread.c (Flocate_file_internal):
677 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
678 * term.c (term_mouse_moveto, init_tty):
679 * termcap.c (tgetent):
680 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
681 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
682 * unexhp9k800.c, unexmacosx.c (unexec):
683 * callproc.c (Fcall_process_region):
684 Use emacs_close, not close.
685 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
686 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
687 and posix_close function on current platforms (which all lack them).
688 (emacs_close): Use it. This should fix the races on GNU/Linux and
689 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
690 and it should avoid closing random victim file descriptors on
691 other platforms.
692
653d4f43
PE
6932013-07-11 Paul Eggert <eggert@cs.ucla.edu>
694
c8536ec4
PE
695 * inotify.c (uninitialized): Remove. All uses replaced by -1.
696 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
697 Touch up doc a bit.
698
9c203066
PE
699 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
700 This is for .gdbinit xbacktrace.
701
653d4f43
PE
702 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
703 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
704 (emacs_set_tty): Now static.
705 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
706 * term.c (tty_capable_p, tty_default_color_capabilities)
707 (get_tty_terminal, term_mouse_movement)
708 (handle_one_term_event, init_tty, maybe_fatal):
709 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
710 (tgetent, scan_file, name_match, compare_contin):
711 * terminal.c (get_terminal):
712 Use bool for boolean.
713 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
714 Prefer char to unsigned char if either will do.
715 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
716 (tty_write_glyphs): Prefer int to unsigned.
717 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
718 All callers changed.
719 * termcap.c (tprint, main) [TEST]: Remove non-working test.
720
45b683a1
PE
7212013-07-10 Paul Eggert <eggert@cs.ucla.edu>
722
29abe551
PE
723 Port to C89.
724 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
725 (B__dummy__): New dummy symbol, to pacify C89.
726 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
727 they can't grok varargs macros.
728 * dispnew.c (add_window_display_history)
729 (add_frame_display_history):
730 * print.c (print_object):
731 * xdisp.c (debug_method_add):
732 Use %p printf format only for void pointers.
733 * emacs.c (usage_message): New constant, replacing ...
734 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
735 (main): Adjust to usage reorg.
736 * fns.c (syms_of_fns):
737 * profiler.c (syms_of_profiler):
738 Don't use non-constant struct initializers.
739 * gnutls.h (gnutls_initstage_t):
740 * lisp.h (enum Lisp_Fwd_Type):
741 * lread.c (lisp_file_lexically_bound_p):
742 * xsettings.c (anonymous enum):
743 Remove trailing comma.
744 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
745 * lisp.h (ENUM_BF): Use unsigned if pedantic.
746 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
747 (DEFUN): Use it.
748 * regex.c (const_re_char): New type, to pacify strict C89.
749 All uses of 'const re_char' replaced to use it.
750 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
751 with glibc when strict C89. This change is imported from gnulib.
752 All uses changed.
753 (_Restrict_arr_): Rename from __restrict_arr, similarly.
754 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
755 Omit GNU_LINUX implementation, since it requires long long.
756 * xterm.c (x_draw_underwave):
757 Do not assume the traditional order of struct's members.
758 (x_term_init): Rewrite to avoid the need for non-constant structure
759 initializers.
760
45b683a1 761 Syntax cleanup, mostly replacing macros with functions.
763a086d 762 This removes the need for the syntax_temp hack.
45b683a1
PE
763 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
764 * syntax.c (SYNTAX_INLINE): New macro.
765 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
766 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
767 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
768 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
769 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
770 (SYNTAX_COMEND_FIRST): Now functions, not macros.
771 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
772 Now constants, not macros.
773 (syntax_temp) [!__GNUC__]: Remove.
774 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
775 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
776 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
777 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
778 Move here from syntax.h; now functions, not macros. Except for the
779 last function, these are static since only syntax.c uses them.
780 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
781 All uses changed. Now a function, not a macro; use this fact
782 to simplify the code.
783 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
784 compiler bugs; no longer relevant.
785 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
786 (SYNTAX_INLINE): New macro.
787 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
788 for the new functions. Use bool for boolean member.
789 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
790 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
791 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
792 (SETUP_BUFFER_SYNTAX_TABLE):
793 Now extern inline functions, not macros.
794 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
795 Remove; all uses replaced by implementation.
796 (syntax_temp) [!__GNUC__]: Remove decl.
797 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
798
29be4a50
JD
7992013-07-10 Jan Djärv <jan.h.d@swipnet.se>
800
801 * emacs.c (main): Fix syntax error.
802
954b166e
PE
8032013-07-10 Paul Eggert <eggert@cs.ucla.edu>
804
805 Timestamp fixes for undo (Bug#14824).
806 * atimer.c (schedule_atimer):
807 * fileio.c (Ffile_newer_than_file_p):
808 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
809 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
810 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
811 (syms_of_fileio): Remove Sclear_visited_file_name.
812 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
813 file doesn't exist; this avoids an ambiguity with negative timestamps.
814 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
815 * systime.h (make_emacs_time, invalid_emacs_time):
816 Don't assume struct timespec layout; POSIX doesn't guarantee it.
817 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
818 * undo.c (record_first_change): Push (visited-file-modtime) onto
819 undo list rather than reimplementing it by hand, incorrectly.
820
d74647c3
KB
8212013-07-09 Ken Brown <kbrown@cornell.edu>
822
823 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
824
3c51b96b
JB
8252013-07-09 Juanma Barranquero <lekktu@gmail.com>
826
827 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
828
4ebbdd67
PE
8292013-07-09 Paul Eggert <eggert@cs.ucla.edu>
830
831 Handle errno and exit status a bit more carefully.
832 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
833 number into an exit status. Instead, use EXIT_CANCELED.
834 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
835 * callproc.c (relocate_fd):
836 * emacs.c (close_output_streams, main):
837 * process.c (create_process):
838 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
839 Use emacs_perror for simplicity.
840 * callproc.c (relocate_fd, main):
841 * sysdep.c (sys_subshell):
842 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
843 (shut_down_emacs): Use emacs_write, not write.
844 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
845 * fileio.c (Fcopy_file, e_write):
846 * nsterm.m (ns_select):
847 * process.c (send_process):
848 * sound.c (vox_write):
849 Use emacs_write_sig, not emacs_write.
850 * lisp.h (emacs_write_sig, emacs_perror): New decls.
851 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
852 New constants.
853 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
854 of write.
855 (emacs_full_write): New function.
856 (emacs_write): Rewrite to use it.
857 (emacswrite_sig, emacs_perror): New functions.
858 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
859
763a086d 8602013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change).
e4b1e5af
JD
861
862 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
863 on NS even if it is present. Pixmap on NS is a void*.
864
9caab067
PE
8652013-07-07 Paul Eggert <eggert@cs.ucla.edu>
866
867 Port to Ubuntu 10 (Bug#14803).
868 Problem reported by T.V. Raman.
869 * process.c (close_on_exec, accept4, process_socket):
870 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
871
1d442672
EZ
8722013-07-07 Eli Zaretskii <eliz@gnu.org>
873
874 * w32.c (sys_dup): Declare prototype.
875
876 * filelock.c:
877 * emacs.c:
878 * callproc.c [WINDOWSNT]: Include sys/socket.h.
879
067428c1
PE
8802013-07-07 Paul Eggert <eggert@cs.ucla.edu>
881
882 Make file descriptors close-on-exec when possible (Bug#14803).
883 This simplifies Emacs a bit, since it no longer needs to worry
884 about closing file descriptors by hand in some cases.
885 It also fixes some unlikely races. Not all such races, as
886 libraries often open files internally without setting
887 close-on-exec, but it's an improvement.
888 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
889 * callproc.c (Fcall_process) [!MSDOS]:
890 * emacs.c (main) [!DOS_NT]:
891 * nsterm.m (ns_term_init):
892 * process.c (create_process):
893 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
894 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
895 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
896 Prefer mkostemp with O_CLOEXEC to mkstemp.
897 * callproc.c (relocate_fd) [!WINDOWSNT]:
898 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
899 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
900 now using pipe2.
901 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
902 Make the resulting file descriptor close-on-exec.
903 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
904 * lread.c (load_descriptor_list, load_descriptor_unwind):
905 Remove; no longer needed. All uses removed.
906 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
907 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
908 New functions.
909 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
910 (Fmake_network_process, Fnetwork_interface_list):
911 (Fnetwork_interface_info, server_accept_connection):
912 Make newly-created socket close-on-exec.
913 * sysdep.c (emacs_open, emacs_fopen):
914 Make new-created descriptor close-on-exec.
915 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
916 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
917
0da857dd
JD
9182013-07-07 Jan Djärv <jan.h.d@swipnet.se>
919
920 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
921 for NS_IMPL_GNUSTEP.
922
5f86adcd
PE
9232013-07-07 Paul Eggert <eggert@cs.ucla.edu>
924
925 Fix openp errno handling.
926 * callproc.c (Fcall_process): Preserve openp errno around close.
927 * lread.c (openp): Set errno when returning -1, as some callers
928 expect this.
929
1afb1d07
JD
9302013-07-06 Jan Djärv <jan.h.d@swipnet.se>
931
932 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
933
934 * nsterm.h (NSSavePanel): Update comment.
935 (NSAPP_DATA2_RUNFILEDIALOG): Define.
936 (ns_run_file_dialog): Declare.
937
938 * nsfns.m: Remove panelOK.
939 (ns_fd_data): New.
940 (ns_run_file_dialog): New function.
941 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
942 event loop, so file dialog is popped up by ns_run_file_dialog, called
943 by sendEvent (Bug#14578).
944 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
945
3323c263
EZ
9462013-07-06 Eli Zaretskii <eliz@gnu.org>
947
fdda0220
EZ
948 * xdisp.c (default_line_pixel_height): New function.
949 (pos_visible_p, move_it_vertically_backward, try_scrolling)
950 (try_cursor_movement, redisplay_window, try_window)
951 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
952
953 * window.c (window_scroll_pixel_based): use
954 default_line_pixel_height.
955
956 * dispextern.h (default_line_pixel_height): Add prototype.
957
958 * frame.c (x_set_line_spacing): Accept a float value for
959 line-spacing parameter, per the documentation.
960
3323c263
EZ
961 * data.c (Fmultibyte_string_p): Doc fix.
962
47ba6d43
PE
9632013-07-05 Paul Eggert <eggert@cs.ucla.edu>
964
406af475
PE
965 Use emacs_open more consistently when opening files.
966 This handles EINTR more consistently now, and makes it easier
967 to introduce other uniform changes to file descriptor handling.
968 * src/systdio.h: New file.
969 * src/buffer.c (mmap_init):
970 * cygw32.c (chdir_to_default_directory):
971 * dispnew.c (Fopen_termscript):
972 * emacs.c (Fdaemon_initialized):
973 * fileio.c (Fdo_auto_save):
974 * image.c (slurp_file, png_load_body, jpeg_load_body):
975 * keyboard.c (Fopen_dribble_file):
976 * lread.c (Fload):
977 * print.c (Fredirect_debugging_output):
978 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
979 * termcap.c (tgetent):
980 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
981 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
982 * w32term.c (w32_initialize) [CYGWIN]:
983 * xfaces.c (Fx_load_color_file):
984 Use emacs_open instead of plain open, and emacs_fopen instead of
985 plain fopen.
986 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
987 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
988 * callproc.c (default_output_mode): New constant.
989 (Fcall_process): Use it to call emacs_open instead of plain creat.
990 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
991 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
992 (emacs_fopen): New function.
993 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
994 Include <lisp.h>, for emacs_open.
995 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
996
47ba6d43
PE
997 Remove duplicate #include directives.
998 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
999 * xfaces.c:
1000 Don't include stdio.h twice.
1001 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1002 Don't include sys/types.h or stdio.h twice.
1003 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1004 * lread.c: Don't include coding.h twice.
1005 * nsfont.m: Don't include frame.h twice.
1006 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1007 * ralloc.c: Don't include <unistd.h> twice.
1008 * xdisp.c: Don't include font.h twice.
1009 * xterm.c: Don't include fontset.h twice.
1010 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1011
b9ed53d5
PE
10122013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1013
1014 Scale ImageMagick images more carefully.
1015 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1016 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1017 Be more careful about avoiding undefined behavior after
1018 integer overflow and division by zero.
1019
cf13177e
YM
10202013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1021
1022 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1023 (syms_of_w32fns): DEFSYM them.
1024 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1025 (CCHDEVICENAME): Define macros if not defined.
1026 (struct MONITOR_INFO_EX): New struct.
1027 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1028 (enum_display_monitors_fn): New variable.
1029 (globals_of_w32fns): Initialize it.
1030 (Fx_display_pixel_width, Fx_display_pixel_height)
1031 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1032 multi-monitor setups in docstrings.
1033 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1034 screen size by primary monitor's millimeter per pixel.
1035 (w32_monitor_enum, w32_display_monitor_attributes_list)
1036 (w32_display_monitor_attributes_list_fallback)
1037 (Fw32_display_monitor_attributes_list): New functions.
1038 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1039
1040 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1041 if not defined.
1042 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1043
86dfb7a8
MA
10442013-07-04 Michael Albinus <michael.albinus@gmx.de>
1045
1046 * fileio.c (Qfile_notify_error): New error symbol.
1047
1048 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1049 * inotify.c (inotify_callback, symbol_to_inotifymask)
1050 (Finotify_add_watch, Finotify_rm_watch): Use it.
1051 (inotifyevent_to_event): Exchange order of cookie and file name.
1052 (Finotify_add_watch): Adapt docstring.
1053
1054 * lisp.h (Qfile_notify_error): Declare.
1055
2c1c974b
PE
10562013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1059 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1060 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1061 which did not work (see <http://bugs.gnu.org/14569#307>).
1062 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1063 && (!noninteractive || initialized)). This attempts to thread
1064 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1065
7a35b20f
JB
10662013-07-04 Juanma Barranquero <lekktu@gmail.com>
1067
1068 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1069 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1070
1ce5cd04
PE
10712013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1074 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1075 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1076 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1077
57f8c490
PE
10782013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1081 Define to __sys_siglist.
1082
bcffb5ca
EZ
10832013-07-02 Eli Zaretskii <eliz@gnu.org>
1084
1085 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1086 word-wrap, so that overflow-newline-into-fringe would work in
1087 visual-line-mode. (Bug#2749)
1088 (move_it_in_display_line_to): When the last scanned display
1089 element fits exactly on the display line, and
1090 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1091 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1092 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1093 finding buffer position that corresponds to pixel coordinates,
1094 e.g. in buffer_posn_from_coords.
1095
2c41e781
JD
10962013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1097
1098 * process.c (handle_child_signal): Call catch_child_signal if
1099 NS_IMPL_GNUSTEP.
1100
c2418359
PE
11012013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1102
52a9bcae
PE
1103 Don't convert function pointers to void * and back.
1104 It isn't portable C, and it's easy enough to avoid.
1105 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1106 (make_save_value): Add support for SAVE_FUNCPOINTER.
1107 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1108 * print.c (print_object):
1109 Distinguish function from object pointers.
1110 * lisp.h (SAVE_FUNCPOINTER): New constant.
1111 (SAVE_SLOT_BITS): Adjust to it.
1112 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1113 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1114 (voidfuncptr): New typedef.
1115 (struct Lisp_Save_Value): New member data[0].funcpointer.
1116 (XSAVE_FUNCPOINTER): New function.
1117
c2418359
PE
1118 Simplify buildobj processing.
1119 * Makefile.in (buildobj.h): Make it a sequence of strings each
1120 followed by comma, rather than a single string. Put it into a
1121 .tmp file in case there's an error while generating it.
1122 (gl-stamp): Use .tmp for temp files.
1123 (mostlyclean): Clean .tmp files.
1124 * doc.c (buildobj): Move to just the routine that needs it.
1125 It's now an array of strings, so processing is simpler.
1126
8f43ce49
PE
11272013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1128
1129 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1130 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1131 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1132 Invoke malloc_enable_thread even when not interactive.
1133 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1134 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1135 in this case, since the underlying bug has now been fixed.
1136
24827db9
JB
11372013-07-01 Juanma Barranquero <lekktu@gmail.com>
1138
1139 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1140 unlinking it (bug#14691).
1141
ef099a94
MN
11422013-06-30 Michal Nazarewicz <mina86@mina86.com>
1143
1144 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1145 before checking whether buffer is modified. This lets
1146 `kill-buffer-query-functions' cancel killing of the buffer or save
1147 its content before `kill-buffer' asks user the "Buffer %s
1148 modified; kill anyway?" question.
1149
9d3f2fc2
JD
11502013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1151
1152 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1153 Let the super performKeyEquivalent deal with them (Bug#14747).
1154
e6c6c8c7
PE
11552013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1156
1d71c1d9
PE
1157 * widget.c (resize_cb): Remove unused local.
1158
8f5f35cc
PE
1159 Do not use GTK 3 if it exists but cannot be compiled.
1160 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1161 * xterm.c (x_error_handler) [!USE_GTK]:
1162 Do not use GTK 3.
1163
e6c6c8c7
PE
1164 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1165
0ba54312
EZ
11662013-06-30 Eli Zaretskii <eliz@gnu.org>
1167
5d1c3286
EZ
1168 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1169 to the valid range of values. (Bug#14753)
1170
0ba54312
EZ
1171 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1172 when moving point by using the current glyph matrix. This avoids
1173 the need to force redisplay when this function is called in a
1174 loop.
1175
9c90cc06
PE
11762013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 Fix minor problems found by static checking.
1179 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1180 Redo the latter's body to sidestep GCC parenthesization warnings.
1181 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1182 * coding.c (detect_coding, detect_coding_system):
1183 * coding.h (struct undecided_spec):
1184 Use bool for boolean.
1185 * image.c (QCmax_width, QCmax_height): Now static.
1186 * xdisp.c (Fmove_point_visually): Remove unused local.
1187
4c672a0f
EZ
11882013-06-29 Eli Zaretskii <eliz@gnu.org>
1189
1190 * xdisp.c (Fmove_point_visually): New function.
1191
c1ea3abf
JB
11922013-06-28 Kenichi Handa <handa@gnu.org>
1193
1194 * coding.h (define_coding_undecided_arg_index): New enum.
1195 (coding_attr_index): New members
1196 coding_attr_undecided_inhibit_null_byte_detection,
1197 coding_attr_undecided_inhibit_iso_escape_detection,
1198 coding_attr_undecided_prefer_utf_8.
1199 (undecided_spec): New struct.
1200 (struct coding_system): New member `undecided' of the member
1201 `spec'.
1202
1203 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1204 (detect_coding): Likewise.
1205 (detect_coding_system): Likewise.
1206 (Fdefine_coding_system_internal): New coding system properties
1207 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1208 :prefer-utf-8.
1209 (syms_of_coding): Adjust for coding_arg_undecided_max.
1210
ba3de9e6
PE
12112013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 * image.c (x_from_xcolors): Remove unused local.
1214
547c9269
YM
12152013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1216
1217 Defer image data transfer between X client and server until actual
1218 display happens.
1219
1220 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1221 and `mask_img'.
1222
1223 * image.c (Destroy_Image): Remove.
1224 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1225 `mask_p', and `colors_p'. All uses changed.
1226 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1227 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1228 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1229 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1230 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1231 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1232 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1233 (image_get_x_image, image_unget_x_image): New functions or macros.
1234 (image_background, image_background_transparent, x_to_xcolors)
1235 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1236 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1237 instead of Destroy_Image.
1238 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1239 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1240 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1241 (imagemagick_load_image, svg_load_image): Use them instead of
1242 x_create_x_image_and_pixmap, and x_put_x_image followed by
1243 x_destroy_x_image, respectively.
1244 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1245 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1246 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1247 background_transparent fields.
1248 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1249 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1250
dae2f5ef
PE
12512013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1254 This mostly consists of undoing recent changes.
1255 * callproc.c (Fcall_process):
1256 * process.c (create_process):
1257 Do not worry about catching SIGCHLD here, undoing previous change.
1258 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1259 * process.c, process.h (catch_child_signal):
1260 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1261 * process.c (catch_child_handler): Don't worry about being called
1262 lazily and do not assume caller has blocked SIGCHLD, undoing
1263 previous change. Move first-time stuff back to
1264 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1265 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1266 set lib_child_handler if it's already initialized, which may
1267 help avoid problems on GNUStep.
1268
fa55d2aa
PE
12692013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1270
1271 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1272 * callproc.c (Fcall_process):
1273 * process.c (create_process):
1274 Make sure SIGCHLD is caught before we fork,
1275 since Emacs startup no arranges to catch SIGCHLD.
1276 * process.c (lib_child_handler): Initialize to null, not to
1277 dummy_handler.
1278 (catch_child_signal): Allow self to be called lazily.
1279 Do nothing if it's already been called.
1280 Assume caller has blocked SIGCHLD (all callers do now).
1281 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1282 just before it's really needed.
1283 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1284 since it hasn't been caught yet.
1285
f3f9606c
LMI
12862013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1287
1288 * image.c (compute_image_size): New function to implement
1289 :max-width and :max-height.
1290 (imagemagick_load_image): Use it.
1291
c7041908
PE
12922013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1295 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1296 Now extern.
1297 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1298 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1299 the SIGCHLD handler, since the code is not atomic and (due to glib)
1300 signals may be arriving now.
1301 * sysdep.c (init_signals): Do not catch child signals here;
1302 'main' now does that later, at a safer time.
1303
f86852b4
PE
13042013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1305
0dfeed58
PE
1306 Clean up SIGCHLD handling a bit (Bug#14569).
1307 * process.c, process.h (catch_child_signal):
1308 Now always extern, even if !NS_IMPL_GNUSTEP.
1309 * process.c (catch_child_signal): Move glib tickler here from
1310 init_process_emacs, so that it's done earlier in Emacs
1311 initialization. Also move the noninteractive && !initialized
1312 check here from init_process_emacs. This is all a bit cleaner for
1313 GNUish platforms, and I hope it works around the Cygwin bug.
1314 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1315 that glib signal handling is tickled before glib creates threads.
1316
f86852b4
PE
1317 * process.c (wait_reading_process_output): Avoid int overflow
1318 when reading more than 2 GiB total from a process.
1319
cbd6509c
PE
13202013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 * process.c (create_process): Handle a couple more cases,
1323 i.e., work even if new_argv and wait_child_setup[i] are cached.
1324 Use Fcall_process's style for volatile vars.
1325
9de1114a
AS
13262013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1327
1328 * process.c (create_process): Mark PROCESS volatile.
1329
fbe9e0b9
PE
13302013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 Use C99-style flexible array members if available.
1333 This avoids some subtle aliasing issues, which typically
1334 aren't a problem with GCC but may be a problem elsewhere.
1335 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1336 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1337 In either case, it uses a flexible array member rather than
1338 the old struct hack. All uses changed.
1339 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1340 Adjust to sdata reorganization.
1341 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1342 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1343 that ports better to pre-C99 non-GCC.
1344 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1345 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1346 as the latter has changed.
1347 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1348 and port better to pre-C99 GCC.
1349 * image.c (struct xpm_cached_color):
1350 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1351 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1352 Use FLEXIBLE_ARRAY_MEMBER.
1353 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1354 Move decl to top level so it gets checked against implementation.
1355 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1356 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1357
1fc71008
PE
13582013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 * syntax.c: Integer cleanups.
1361 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1362 All uses that need 0-or-2 changed to:
1363 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1364 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1365 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1366 (char_quoted, prev_char_comend_first, back_comment)
1367 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1368 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1369 Use bool for boolean.
1370 (update_syntax_table, skip_chars, skip_syntaxes):
1371 Prefer int to unsigned when either will do.
1372 (back_comment): Return boolean success flag, like forw_comment,
1373 instead of positive-or-minus-1 (which might have overflowed int anyway).
1374 Don't stuff ptrdiff_t into int.
1375 (syntax_spec_code, syntax_code_spec): Now const.
1376 (Fmatching_paren, scan_lists, scan_sexps_forward):
1377 Use enum syntaxcode for syntax code.
1378 (Fmatching_paren): Check that arg is a character, not just an integer.
1379 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1380 (Finternal_describe_syntax_value): Omit no-longer-needed
1381 comparison to 0.
1382 (skip_chars): Use char, not unsigned char, when the distinction
1383 doesn't matter.
1384 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1385 * bytecode.c (exec_byte_code):
1386 * syntax.c (syntax_spec_code, Fchar_syntax)
1387 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1388 (init_syntax_once):
1389 * syntax.h (SYNTAX_WITH_FLAGS):
1390 Omit unnecessary casts.
1391
b932cad7
EZ
13922013-06-20 Eli Zaretskii <eliz@gnu.org>
1393
1394 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1395 line dimensions here, to avoid race conditions with the main
1396 thread. (Bug#14062, bug#14630, bug#14669)
1397
1398 * w32term.c (w32_draw_window_cursor): Compute the header line and
1399 mode line dimensions here.
1400 <w32_system_caret_window, w32_system_caret_hdr_height>:
1401 <w32_system_caret_mode_height>: New variables.
1402
1403 * w32term.h: Declare them.
1404
89561f72
PE
14052013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1406
5013fc08
PE
1407 * alloc.c (die): Move "assertion failed" string here ...
1408 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1409 COND when SUPPRESS_CHECKING. This shrinks the executable text
1410 size by 0.8% to 2.2% when configured with --enable-checking,
1411 depending on optimization flags (GCC 4.8.1 x86-64).
1412
89561f72
PE
1413 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1414
763a086d 14152013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
1416
1417 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1418 base is 2; this is more accurate.
1419
983aeb9a
JB
14202013-06-19 Juanma Barranquero <lekktu@gmail.com>
1421
1422 * sound.c (string_default): Move to !WINDOWSNT section.
1423 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1424
178ba3e6
PE
14252013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1426
bbc51b15
PE
1427 * sound.c: Integer cleanups.
1428 Remove unnecessary forward decls.
1429 (struct sound_device): The 'file' member is now a Lisp_Object, not
1430 a char *, so that we needn't invoke alloca on a huge size.
1431 (Fplay_sound_internal): Adjust to this.
1432 (string_default): New function.
1433 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1434 Use it to adjust to the struct sound_device change.
1435 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1436 (be2hs) [0]: Remove.
1437
178ba3e6
PE
1438 * syntax.c (skip_chars): Don't use uninitialized storage
1439 when searching a multibyte buffer for characters that are not in a
1440 unibyte string that contains non-ASCII characters.
1441
69f60cdc
JD
14422013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1443
1444 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1445 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1446
0d6224d4
PE
14472013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1450
3c542890
KH
14512013-06-18 Kenichi Handa <handa@gnu.org>
1452
f7e3f7cd
KH
1453 * font.c (Ffont_spec): Signal an error for an invalid font name
1454 (Bug#14648).
3c542890 1455
9349e5f7
PE
14562013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1457
1458 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1459 In particular this ports to 32-bit sparc Sun cc.
1460 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1461 array with a dummy element at specpdl[-1], so that its address can
1462 be taken portably.
1463 (unbind_to): Do not copy the binding; not needed, now that we
1464 copy old_value in the one place where the copy is needed.
1465 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1466 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1467 (union specbinding): Rename from struct specbinding. Redo layout
1468 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1469 which is not portable. With Sun C 5.12 32-bit sparc, the
1470 declaration causes nargs to be an unsigned bitfield, a behavior
1471 that the C standard allows; but Emacs wants nargs to be signed.
1472 The overall type is now a union of structures rather than a
1473 structure of union of structures, and the 'kind' member is now a
1474 bitfield, so that the overall type doesn't grow. All uses changed.
1475 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1476
0a4df6a5
PE
14772013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1478
ec6ecaad
PE
1479 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1480 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1481
0a4df6a5
PE
1482 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1483
7bfe8dbc
EZ
14842013-06-17 Eli Zaretskii <eliz@gnu.org>
1485
1486 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1487 unless we know that the window w's frame is a frame object.
1488 Another attempt at solving bug#14062 and bug#14630.
1489
708e05f6
LMI
14902013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1491
1492 * textprop.c (property_set_type): New enum.
1493 (add_properties): Allow appending/prepending text properties.
1494 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1495 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1496 add_text_properties_1.
1497 (Fadd_face_text_property): New function that calls
1498 add_text_properties_1.
1499
84575e67
PE
15002013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1501
1502 Move functions from lisp.h to individual modules when possible.
1503 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1504 * alloc.c (XFLOAT_INIT, set_symbol_name):
1505 * buffer.c (CHECK_OVERLAY):
1506 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1507 (set_char_table_parent):
1508 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1509 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1510 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1511 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1512 (set_blv_valcell):
1513 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1514 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1515 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1516 (backtrace_args, backtrace_debug_on_exit):
1517 * floatfns.c (CHECK_FLOAT):
1518 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1519 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1520 (set_hash_hash, set_hash_hash_slot, set_hash_index)
1521 (set_hash_index_slot):
1522 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
1523 * marker.c (CHECK_MARKER):
1524 * textprop.c (CHECK_STRING_OR_BUFFER):
1525 * window.c (CHECK_WINDOW_CONFIGURATION):
1526 Move here from lisp.h, and make these functions static rather than
1527 extern inline.
1528 * buffer.c (Qoverlayp):
1529 * data.c (Qsubrp):
1530 * fns.c (Qhash_table_p):
1531 * window.c (Qwindow_configuration_p):
1532 Now static.
1533 * lisp.h: Remove the abovementioned defns and decls.
1534
1535 Use functions, not macros, for XINT etc. (Bug#11935).
1536 In lisp.h, prefer functions to function-like macros, and
1537 constants to object-like macros, when either will do. This:
1538 . simplifies use, as there's no more need to worry about
1539 arguments' side effects being evaluated multiple times.
1540 . makes the code easier to debug on some platforms.
1541 However, when using gcc -O0, keep using function-like macros
1542 for a few critical operations, for performance reasons.
1543 This sort of thing isn't needed with gcc -Og, but -Og
1544 is a GCC 4.8 feature and isn't widely-enough available yet.
1545 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
1546 Remove enum lsb_bits; no longer needed.
1547 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
1548 * buffer.c (Qoverlap):
1549 * data.c (Qsubrp):
1550 * fns.c (Qhash_table_p):
1551 Now extern, so lisp.h can use these symbols.
1552 * dispextern.h: Include character.h, for MAX_CHAR etc.
1553 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1554 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1555 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1556 (GLYPH_CODE_P): Move here from lisp.h.
1557 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1558 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
1559 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
1560 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
1561 XUNTAG now returns void *.
1562 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
1563 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
1564 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
1565 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
1566 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
1567 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
1568 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
1569 (lisp_h_XPNTR, lisp_h_XSYMBOL):
1570 New macros, renamed from their sans-lisp_h_ counterparts.
1571 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
1572 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
1573 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
1574 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
1575 If compiling via GCC without optimization, define these as macros
1576 in addition to inline functions.
1577 To disable this, compile with -DINLINING=0.
1578 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
1579 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
1580 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
1581 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
1582 (INTMASK, VALMASK): Now macros, since static values cannot be
1583 accessed from extern inline functions.
1584 (VALMASK): Also a constant, for benefit of old GDB.
1585 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
1586 is INTEGERP, which can fold it in.
5165d44a 1587 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
1588 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
1589 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
1590 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
1591 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
1592 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
1593 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
1594 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
1595 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
1596 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
1597 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
1598 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
1599 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
1600 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
1601 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
1602 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
1603 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
1604 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
1605 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
1606 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
1607 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
1608 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
1609 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
1610 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
1611 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
1612 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
1613 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
1614 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
1615 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
1616 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
1617 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
1618 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
1619 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
1620 Now functions.
1621 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
1622 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
1623 (VALMASK): Define in one place rather than in two, merging the
1624 USE_LSB_TAG parts; this is simpler.
1625 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
1626 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
1627 Move up, to avoid use before definition.
1628 Also include "globals.h" earlier, for the same reason.
1629 (make_natnum): New function.
1630 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
1631 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
1632 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
1633 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
1634 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
1635 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
1636 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
1637 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
1638 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
1639 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
1640 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
1641 (Qwindow_configuration_p, Qimage): New forward declarations.
1642 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
1643 (STRING_COPYIN): Remove; unused.
1644 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
1645 (xcar_addr, xcdr_addr): New functions. All uses changed.
1646 (IEEE_FLOATING_POINT): Now a constant, not a macro.
1647 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1648 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1649 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1650 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
1651 (TYPE_RANGED_INTEGERP): Simplify.
1652 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
1653 (setlocale, fixup_locale, synchronize_system_messages_locale)
1654 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
1655 Now empty functions, not macros.
1656 (functionp): Return bool, not int.
1657 * window.c (Qwindow_configuration_p): Now extern,
1658 so window.h can use it.
1659 * window.h (Qwindowp): Move decl back to lisp.h.
1660
9583ec36
EZ
16612013-06-15 Eli Zaretskii <eliz@gnu.org>
1662
1663 * xdisp.c (Fline_pixel_height): New function, required for solving
1664 bug #14567.
1665
210272ce
PE
16662013-06-15 Paul Eggert <eggert@cs.ucla.edu>
1667
1668 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
1669
de0503df
SM
16702013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
1671
1672 * lread.c (syms_of_lread):
1673 * fns.c (Fprovide): Adjust to new format of after-load-alist.
1674
afbfe143
KD
16752013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
1676
1677 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
1678
d177e213
XF
16792013-06-12 Xue Fuqiao <xfq.free@gmail.com>
1680
1681 * fileio.c (expand_file_name): Doc fix.
1682
05e3e412
PE
16832013-06-11 Paul Eggert <eggert@cs.ucla.edu>
1684
f7394b12
PE
1685 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
1686 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
1687 Wait for self, not for 0. This can't hurt on GNU or similar
1688 system, and may help with Cygwin.
1689
05e3e412
PE
1690 * keyboard.c: Don't use PROP (...) as an lvalue.
1691 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
1692 Use set_prop (A, B), not PROP (A) = B.
1693
17dd3097
EZ
16942013-06-10 Eli Zaretskii <eliz@gnu.org>
1695
1696 * xdisp.c (get_it_property): Use it->window instead of generating
1697 a Lisp object from it->w.
1698
52fab9c9
EZ
16992013-06-09 Eli Zaretskii <eliz@gnu.org>
1700
1701 * xdisp.c (get_it_property): If it->object is a buffer, pass to
1702 get-char-property the window that is being rendered, instead of
1703 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
1704 (compute_display_string_pos): When W is NULL, use the current
1705 buffer as the object to pass to get-char-property.
1706 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
1707 pointer member of the bidi iterator, since no window is pertinent
1708 to this function.
52fab9c9 1709
5bf97bfc
EZ
17102013-06-08 Eli Zaretskii <eliz@gnu.org>
1711
1712 * bidi.c (bidi_fetch_char): Accept additional argument, the window
1713 being displayed, and pass it to compute_display_string_pos.
1714 (bidi_level_of_next_char, bidi_resolve_explicit_1)
1715 (bidi_paragraph_init): All callers changed.
1716
1717 * xdisp.c (init_from_display_pos, init_iterator)
1718 (handle_single_display_spec, next_overlay_string)
1719 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
1720 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
1721 Set bidi_it.w member from it->w.
5bf97bfc
EZ
1722 (compute_display_string_pos): Accept additional argument, the
1723 window being displayed, and pass it to Fget_char_property.
1724 (Bug#14575)
1725
1726 * dispextern.h (struct bidi_it): New member w, the window being
1727 displayed.
1728 (compute_display_string_pos): Adjust prototype.
1729
5de0e011
JD
17302013-06-08 Jan Djärv <jan.h.d@swipnet.se>
1731
e7b41c4c 1732 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
1733
1734 * process.c (wait_reading_process_output): Check for NS before GLIB.
1735 GLIB may be linked in due to rsvg, but ns_select must be called.
1736
5de0e011
JD
1737 * xgselect.c (xg_select): Remove call to window_system_available
1738 and g_main_context_pending at the top, so Gdk events (i.e. file
1739 notify) are processed when Emacs is started with -nw.
1740
a822acff
EZ
17412013-06-07 Eli Zaretskii <eliz@gnu.org>
1742
1743 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
1744 (ctagsfiles3): New variable, includes only *.m files.
1745 (TAGS): Use an explicit language name in the regular expressions,
1746 to avoid transformation of '/SOMETHING' by MSYS to
1747 'c:\MSYS\SOMETHING'.
1748
6c0a9ed1
RC
17492013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
1750
1751 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
1752
9ef6111b
EZ
17532013-06-06 Eli Zaretskii <eliz@gnu.org>
1754
1755 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
1756 still need to set the mouse pointer shape and activate help-echo.
1757 (Bug#14558)
1758
7d300d64
PE
17592013-06-06 Paul Eggert <eggert@cs.ucla.edu>
1760
1761 A few porting etc. fixes for the new file monitor code.
1762 See the thread containing
1763 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
1764 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
1765 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
1766 (dir_monitor_callback, Fgfile_rm_watch):
1767 Use assq_no_quit instead of Fassoc, for speed.
1768 (dir_monitor_callback, Fgfile_rm_watch):
1769 eassert that the monitor is a fixnum.
1770 (dir_monitor_callback): No need for CDR_SAFE.
1771 Simplify building of lisp with alternative tails.
1772 (Fgfile_add_watch, Fgfile_rm_watch):
1773 Do not assume glib functions set errno reliably on failure.
1774 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
1775 and signal an error otherwise.
1776 (Fgfile_rm_watch): Prefer CONSP to !NILP.
1777 Use Fdelq instead of Fdelete, for speed.
1778
817ebfcf
EZ
17792013-06-05 Eli Zaretskii <eliz@gnu.org>
1780
1781 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
1782 don't insist on being invoked on a highlighted tool-bar button.
1783 Avoids losing tool-bar functionality when mouse-highlight is nil.
1784 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
1785 Don't highlight when mouse-highlight is nil.
1786 (note_mouse_highlight): When mouse-highlight is nil, don't return
1787 right away; instead, run tool-bar and mode-line highlight
1788 subroutine, clear any existing highlight, and revert the mouse
1789 pointer to its default shape. (Bug#14558)
1790
55577e7c
SM
17912013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1792
1793 * lisp.mk (lisp): Add prog-mode.el.
1794
f019a684
PE
17952013-06-05 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
1798 * process.c (dummy_handler): New function.
1799 (lib_child_handler): New static var.
1800 (handle_child_signal): Invoke it.
1801 (catch_child_signal): If a library has set up a signal handler,
1802 save it into lib_child_handler.
1803 (init_process_emacs): If using glib and not on Windows, tickle glib's
1804 child-handling code so that it initializes its private SIGCHLD handler.
1805 * syssignal.h (SA_SIGINFO): Default to 0.
1806 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
1807 31; it should no longer be needed now.
1808
90db8702
MA
18092013-06-05 Michael Albinus <michael.albinus@gmx.de>
1810
1811 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
1812
1813 * gfilenotify.c (globals_of_gfilenotify): New function.
1814 (syms_of_gfilenotify): Move global initialization there.
1815
1816 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
1817
bfa3acd6
SM
18182013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1819
1820 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
1821 * keyboard.c (menu_bar_items, tool_bar_items):
1822 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
1823 not override local keymaps any more.
1824
ba59bd80
EZ
18252013-06-04 Eli Zaretskii <eliz@gnu.org>
1826
1827 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
1828
7f203aa1
EZ
18292013-06-03 Eli Zaretskii <eliz@gnu.org>
1830
9337e206
EZ
1831 * w32console.c (initialize_w32_display): Return the dimensions of
1832 the console window via 2 additional arguments, not via the current
1833 frame. This avoids crashes due to overrunning the bounds of
1834 frame's decode_mode_spec_buffer, which is not resized following
1835 the change of the frame dimensions from the initial 10x10.
1836
1837 * w32term.h (w32_initialize_display_info): Adjust prototype.
1838
1839 * term.c (init_tty): Take dimensions of the frame from the values
1840 returned by initialize_w32_display.
1841
7f203aa1
EZ
1842 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
1843 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
1844 (LIBES): Add $(GFILENOTIFY_LIBS).
1845
1846 * w32inevt.c (handle_file_notifications): Add dummy implementation
1847 for !HAVE_W32NOTIFY.
1848
1849 * w32term.c: Wrap code with HAVE_W32NOTIFY.
1850
55a87246
JD
18512013-06-03 Jan Djärv <jan.h.d@swipnet.se>
1852
1853 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
1854
1855 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
1856
1857 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
1858
3d5ee10a
PE
18592013-06-03 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 Fix minor problems found by static checking.
1862 * data.c (pure_write_error):
1863 Use xsignal2, not Fsignal, as Fsignal might return.
1864 * eval.c (set_backtrace_debug_on_exit): Now static.
1865 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
1866 No longer inline. EXTERN_INLINE is needed only for functions
1867 defined in .h files. Reindent function header as per GNU style.
1868 (backtrace_p, backtrace_top, backtrace_next):
1869 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
1870 compiler or linker. Add extern decls to pacify gcc -Wall.
1871 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1872 Now static.
1873 * frame.c (free_monitors): Define only on platforms that need it.
1874 * nsterm.m (ns_term_init):
1875 * process.c (catch_child_signal):
1876 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
1877 defined on all porting targets these days.
1878 * process.c, process.h (catch_child_signal):
1879 Make it extern only if NS_IMPL_GNUSTEP is defined.
1880
e2d8a6f0
EZ
18812013-06-03 Eli Zaretskii <eliz@gnu.org>
1882
1883 * w32.c (gettimeofday): Make the signature identical to prototype
1884 in nt/inc/sys/time.h.
1885
a8a7c5f6
SM
18862013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1887
1888 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
1889 .gdbinit.
1890
1891 * keyboard.c (safe_run_hooks_error): Improve error message.
1892
1893 * data.c (pure_write_error): Add `object' argument.
1894 * puresize.h (CHECK_IMPURE): Use it.
1895
c9628c79
MA
18962013-06-03 Michael Albinus <michael.albinus@gmx.de>
1897
1898 * Makefile.in (NOTIFY_OBJ): New variable.
1899 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
1900
1901 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
1902 Call syms_of_gfilenotify.
1903
1904 * gfilenotify.c: New file.
1905
1906 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
1907 and Qfile_w32notify.
1908 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
1909 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
1910
1911 * lisp.h: Declare syms_of_gfilenotify.
1912
1913 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
1914
2f592f95
SM
19152013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1916
1917 Merge the specpdl and backtrace stacks. Make the structure of the
1918 specpdl entries more obvious via a tagged union of structs.
1919 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
1920 (enum specbind_tag): New enum.
1921 (struct specbinding): Make it a tagged union of structs.
1922 Add a case for backtrace records.
1923 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
1924 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
1925 (backtrace_debug_on_exit): New accessors.
1926 (struct backtrace): Remove.
1927 (struct catchtag): Remove backlist field.
1928 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1929 Move to eval.c.
1930 (Flocal_variable_p): Speed up the common case where the binding is
1931 already loaded.
1932 * eval.c (backtrace_list): Remove.
1933 (set_specpdl_symbol, set_specpdl_old_value): Remove.
1934 (set_backtrace_args, set_backtrace_nargs)
1935 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
1936 (backtrace_next): New functions.
1937 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
1938 (unwind_to_catch, internal_lisp_condition_case)
1939 (internal_condition_case, internal_condition_case_1)
1940 (internal_condition_case_2, internal_condition_case_n): Don't bother
1941 with backtrace_list any more.
1942 (Fsignal): Adjust to new backtrace format.
1943 (grow_specpdl): Move up.
1944 (record_in_backtrace): New function.
1945 (eval_sub, Ffuncall): Use it.
1946 (apply_lambda): Adjust to new backtrace format.
1947 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
1948 data.c.
1949 (specbind): Adjust to new specpdl format. Simplify.
1950 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
1951 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
1952 backtrace format.
1953 (mark_backtrace): Remove.
1954 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
1955 * xdisp.c (redisplay_internal): Use record_in_backtrace.
1956 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
1957 Use mark_specpdl.
1958 * profiler.c (record_backtrace): Use get_backtrace.
1959 (handle_profiler_signal): Use backtrace_top_function.
1960 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
1961 accessor functions.
1962
c0342369
JD
19632013-06-02 Jan Djärv <jan.h.d@swipnet.se>
1964
1965 * process.h (catch_child_signal): Declare.
1966
1967 * process.c (catch_child_signal): New function.
1968 (init_process_emacs): Call it.
1969
1970 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
1971 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
1972 NS_IMPL_COCOA.
1973 (x_set_cursor_type): Remove declaration.
1974 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
1975 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
1976 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
1977 (ns_get_color): Use F suffix on float.
1978 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
1979 (ns_get_rgb_color): Remove.
1980 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
1981 (note_mouse_movement): x and y are CGFloat.
1982 (ns_draw_fringe_bitmap): Remove unused rowY.
1983 Change #if to COCOA && >= 10_6.
1984 (ns_draw_window_cursor): Remove unused overspill.
1985 (ns_draw_underwave): width and x are EamcsCGFloat.
1986 (ns_draw_box): thickness is CGFloat.
1987 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
1988 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
1989 if not in main thread.
1990 (ns_get_pending_menu_title, ns_check_menu_open)
1991 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
1992 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
1993 (sendFromMainThread:): New method.
1994 (changeFont:): size is CGFloat.
1995 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
1996 Disable warning about permanent text.
1997 (characterIndexForPoint:): Adjust return type depending on GNUStep
1998 version.
1999 (mouseDown:): delta is CGFloat.
2000 (updateFrameSize): Remove unised variable f.
2001 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2002 Cast float to EmacsCGFloat.
2003 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2004 also to -1 when restoring.
2005 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2006 inside NS_IMPL_COCOA.
2007 (toggleFullScreen:): Put call to toggleFullScreen inside
2008 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2009 (setPosition:portion:whole:): por is CGFloat.
2010 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2011 (mouseDown:): Use CGFloat.
2012 (mouseDragged:): Remove unised variable edge.
2013 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2014
2015 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2016 of CGFloat differs.
2017 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2018 when NS_IMPL_GNUSTEP.
2019 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2020 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2021 (EmacsToolbar): Add clearAll. Add tag argument to
2022 addDisplayItemWithImage.
2023 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2024
2025 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2026
2027 * nsmenu.m (ns_update_menubar): Make static.
2028 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2029 (fillWithWidgetValue:): Add cast to SEL for setAction.
2030 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2031 (update_frame_tool_bar): Update code for GNUStep.
2032 (clearAll): New method.
2033 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2034 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2035 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2036 call to insertItemWithItemIdentifier.
2037 (validateVisibleItems): Fix indentation.
2038 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2039 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2040 UtilityWindow to aStyle, remove call to setStyleMask.
2041
2042 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2043
2044 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2045 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2046 Use F suffix on floats.
2047 (ns_char_width): Returns CGFloat.
2048 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2049 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2050 DPSxshow.
2051 (ns_glyph_metrics): CGFloat instead of float.
2052
a0eb10b3
JB
2053 * nsfns.m (x_set_foreground_color, x_set_background_color):
2054 Use EmacsCGFloat.
2055 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2056 remove unused variables.
2057 (Fns_read_file_name): Keep track if panel is for save.
2058 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2059 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2060 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2061 Just return the input if GNUStep.
c0342369
JD
2062 (x_screen_planes): Remove.
2063 (Fxw_color_values): Use EmacsCGFloat
2064 (Fns_display_monitor_attributes_list): Only get screen number for
2065 Cocoa.
ef099a94 2066 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2067 EmacsSavePanel.
2068 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2069 ns_directory_from_panel.
2070
da9aff11
PE
20712013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 * process.c (handle_child_signal): Also use WCONTINUED.
2074 This is so that list-processes doesn't mistakenly list the process
2075 as stopped, when the process has actually been continued and is
2076 now running.
2077
0e64479a
PE
20782013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2079
fc186a96
PE
2080 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2081 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2082 not already configured.
2083
0e64479a
PE
2084 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2085
38b787fa
EZ
20862013-05-29 Eli Zaretskii <eliz@gnu.org>
2087
2088 * Makefile.in (mostlyclean): Remove *.res files.
2089
22513e52
SM
20902013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2091
2092 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2093 a buffer (bug#8447).
2094
6ef3db10
EZ
20952013-05-27 Eli Zaretskii <eliz@gnu.org>
2096
2097 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2098 display vector, and we backtrack, handle the case that the
2099 previous character position is also displayed from a display
2100 vector or covered by a display string or image. (Bug#14476)
2101
6799bb26
JD
21022013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2103
2104 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2105 (struct MonitorInfo, free_monitors): Remove.
2106 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2107 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2108 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2109 Qframes, Qsource.
2110
2111 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2112 (struct MonitorInfo, free_monitors): Remove.
2113 (ns_screen_name): Make static.
2114 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2115 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2116 Qframes, Qsource.
2117
2118 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2119 (struct MonitorInfo): New struct.
2120 (free_monitors, make_monitor_attribute_list): Declare.
2121
22513e52
SM
2122 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2123 New Lisp_Object:s.
6799bb26
JD
2124 (free_monitors, make_monitor_attribute_list): New functions.
2125 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2126 Qsource.
2127
38cd43eb
XF
21282013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2129
2130 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2131
2af0948d
SM
21322013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2133
a7eb9b0f
SM
2134 * keyboard.c: Apply keyboard decoding only to events that come directly
2135 from the tty, not from unread-command-events (bug#14368).
2136 (read_event_from_main_queue): New function, extracted from read_char).
2137 (read_decoded_char): Remove.
2138 (read_decoded_event_from_main_queue): New function to replace it.
2139 (read_char): Use it.
2140 (read_key_sequence): Use read_char rather than read_decoded_char.
2141
2af0948d
SM
2142 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2143
1413e9a5
BR
21442013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2145
2146 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2147
e6d2f155
KH
21482013-05-22 Kenichi Handa <handa@gnu.org>
2149
2150 The following changes are to fix the setting of
2151 buffer-file-coding-system on, for instance, C-x RET c unix RET
2152 _FILE_OF_DOS_EOL_TYPE_ RET.
2153
2154 * coding.h (struct coding_system): New member detected_utf8_chars.
2155
2156 * coding.c (detect_coding_utf_8): Count characters and check EOL
2157 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2158 BOM is there.
2159 (setup_coding_system): Do not initialize coding->head_ascii.
2160 (check_ascii): Do not set coding->eol_seen but update it. Do not
2161 call adjust_coding_eol_type here.
1413e9a5
BR
2162 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2163 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2164 of the found coding-system.
2165 (decode_coding_gap): Cancel previous change. Utilize the
2166 character numbers counted by detect_coding_utf_8. Fix detection
2167 of BOM for utf-8.
2168
ab56a6f4 21692013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2170
2171 * search.c (looking_at_1): Only set last_thing_searched if the match
2172 changed the match-data (bug#14281).
2173
ecc3c6ed
DA
21742013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2175
2176 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2177 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2178 (move_it_vertically_backward): Likewise.
2179
5ba8bf35
YM
21802013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2181
2182 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2183 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2184 (Fx_display_mm_width, Fx_display_mm_height):
2185 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2186
91e8418b 2187 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2188 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2189 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2190 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2191 (Fx_display_backing_store, Fx_display_visual_class)
2192 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2193 (Fx_display_grayscale_p, Fx_display_pixel_width)
2194 (Fx_display_pixel_height, Fx_display_planes)
2195 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2196 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2197 (Fx_display_mm_width, Fx_display_mm_height)
2198 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2199 height for all physical monitors as in X11.
2200
fc30d803
SM
2201 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2202 Return pixel width or height for all physical monitors as in X11.
91e8418b 2203
31ff141c
PE
22042013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2205
2206 Port --enable-gcc-warnings to clang.
2207 * bytecode.c (exec_byte_code):
2208 * regex.c:
2209 Redo diagnostic pragmas to pacify clang, too.
2210 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2211 * editfns.c (Fencode_time):
2212 * fileio.c (file_accessible_directory_p):
2213 * font.c (font_unparse_xlfd):
2214 Use '&"string"[index]' instead of '"string" + (index)'.
2215 * undo.c (user_error): Remove; unused.
2216
df065a0b
EZ
22172013-05-16 Eli Zaretskii <eliz@gnu.org>
2218
04d360e7
EZ
2219 * insdel.c (insert_1_both): Document the arguments, instead of
2220 referring to insert_1, which no longer exists.
2221
5bb98290
EZ
2222 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2223 some window, increment windows_or_buffers_changed, so that
2224 *Messages* display in that window is updated. (Bug#14408)
2225
df065a0b
EZ
2226 * w32.c: Include epaths.h.
2227 (init_environment): Use cmdproxy.exe without leading directories.
2228 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2229 case.
2230 (gettimeofday): Adjust signature and return value to Posix
2231 expectations.
2232
2233 * unexw32.c (open_output_file): Delete the existing emacs.exe
2234 before creating it, to break the hard link to the versioned
2235 executable.
2236
2237 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2238 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2239 (FIRSTFILE_OBJ): New variables.
2240 (W32_RES): Rename to EMACSRES. All users changed.
2241 (base_obj): Use $(CM_OBJ).
2242 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2243 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2244 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2245 $(W32_RES_LINK) before $(LIBES).
2246 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2247
1aa8d505
SM
22482013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2249
6e911150
SM
2250 * makefile.w32-in (DOC): Use just "DOC".
2251
2252 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2253
1aa8d505
SM
2254 * process.c: Export default filters and sentinels to Elisp.
2255 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2256 New constants.
2257 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2258 (Fset_process_sentinel, Fformat_network_address):
2259 Default to them instead of nil.
2260 (server_accept_connection): Sentinels can't be nil any more.
2261 (read_and_dispose_of_process_output): New function, extracted from
2262 read_process_output.
2263 (read_process_output): Use it; filters can't be nil.
2264 (Finternal_default_process_filter): New function, extracted from
2265 read_process_output.
2266 (exec_sentinel_unwind): Remove function.
2267 (exec_sentinel): Don't zilch sentinel while running.
2268 (status_notify): Sentinels can't be nil.
2269 (Finternal_default_process_sentinel): New function extracted from
2270 status_notify.
2271 (setup_process_coding_systems): Default filter is not nil any more.
2272 (syms_of_process): Export new Elisp functions and initialize
2273 new constants.
2274 * lisp.h (make_lisp_proc): New function.
2275
5ac2eb34
SM
22762013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2277
2278 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2279
eda9c7d7
EZ
22802013-05-14 Eli Zaretskii <eliz@gnu.org>
2281
2282 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2283 unless we know that the window w is a leaf window.
2284 Another attempt at solving bug#14062.
eda9c7d7 2285
8fdeaad5
JD
22862013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2287
2288 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2289 fdesc (Bug#14375).
2290
44aa9ee6
PE
22912013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2292
2293 * image.c (gif_load): Check that subimages fit (Bug#14345).
2294
759fd763
SM
22952013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2296
2297 * lread.c (skip_dyn_eof): New function.
2298 (read1): Use it to skip the end of a file in response to #@00.
2299
2300 * doc.c (get_doc_string): Slightly relax the sanity checking.
2301
4465bfb4
JD
23022013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2303
2304 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2305 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2306 (MonitorInfo): New struct.
2307 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2308 (Fns_display_monitor_attributes_list): New functions.
2309 (display-usable-bounds): Remove.
2310 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2311 Qsource.
2312
7583e2a0
PE
23132013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2316 (GTK_CHECK_VERSION): New macro, if not already defined.
2317 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2318 replaced by GTK_CHECK_VERSION.
2319
ad75d77e
PE
23202013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2321
2322 * xterm.h (GTK_PREREQ): New macro.
2323 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2324 to use this macro instead, for consistency and clarity.
2325
07525f77
EZ
23262013-05-08 Eli Zaretskii <eliz@gnu.org>
2327
2328 * xdisp.c (row_for_charpos_p): New function, with code of
2329 cursor_row_p, but accepts an additional argument CHARPOS instead
2330 of using a hardcoded PT.
2331 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2332 (row_containing_pos): Call row_for_charpos_p instead of partially
2333 doing the same. Fixes cursor positioning under longlines-mode
2334 when longlines-show-effect includes more than one newline, when
2335 moving the cursor vertically up.
2336
d901fc8d
JB
23372013-05-08 Juanma Barranquero <lekktu@gmail.com>
2338
2339 * makefile.w32-in (ACL_H): New macro.
2340 ($(BLD)/fileio.$(O)): Update dependencies.
2341
f269bc61
PE
23422013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2343
e7b41c4c 2344 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2345 * Makefile.in (LIB_ACL): New macro.
2346 (LIBACL_LIBS): Remove.
2347 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2348 * fileio.c: Include <acl.h>.
2349 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2350 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2351 !acl_errno_valid.
2352 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2353 it ourselves.
2354
f269bc61
PE
2355 * unexelf.c: Don't assume ElfW (Half) fits in int.
2356 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2357 when dealing with ElfW (Half) values, since they can exceed 2**31
2358 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2359 (entry_address): Omit unused NUM arg. All uses changed.
2360
a261c53e
JL
23612013-05-07 Juri Linkov <juri@jurta.org>
2362
2363 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2364 to the string converted from number with `Fnumber_to_string'.
2365 (Bug#14254)
2366
2b66427d
PE
23672013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2370 This fixes a problem introduced by my previous change.
2371
15acfe41
GM
23722013-05-07 Glenn Morris <rgm@gnu.org>
2373
2374 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2375
5ea03bf5
JD
23762013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2377
2378 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2379
e0c9d565
PE
23802013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 Static checking by GCC 4.8.0.
2383 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2384 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2385 (x_get_monitor_attributes_fallback)
2386 (x_get_monitor_attributes_xinerama)
2387 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2388 Define only if USE_GTK.
2389 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2390 (x_get_monitor_attributes_fallback): Omit unused locals.
2391 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2392 Use double, not float, to avoid mixed-mode floating point arithmetic.
2393
4e3f9230
YM
23942013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2395 Jan Djärv <jan.h.d@swipnet.se>
2396
2397 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2398 (XINERAMA_CFLAGS): New macros.
2399 (ALL_CFLAGS, LIBES): Use them.
2400
2401 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2402 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2403 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2404 (syms_of_xfns): DEFSYM them.
2405 (struct MonitorInfo): New struct.
2406 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2407 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2408 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2409 (x_get_monitor_attributes_xinerama): New functions.
2410 (Fx_display_monitor_attributes_list): New primitive.
2411 (syms_of_xfns): Defsubr it.
2412
2413 * xterm.h (x_display_info): Add Xatom_net_workarea and
2414 Xatom_net_current_desktop.
2415
2416 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2417 and dpyinfo->Xatom_net_current_desktop.
2418
05839b6a
EZ
24192013-05-06 Eli Zaretskii <eliz@gnu.org>
2420
2421 * xdisp.c (pos_visible_p): Use the special code for finding the
2422 beginning of a display property or overlay for any "replacing"
2423 display property, not just for display strings. This solves
2424 incorrect reporting of position by posn-at-point. (Bug#14241)
2425
dc4a2ee0
PE
24262013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2427
5ee94506
PE
2428 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2429 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2430 Verify that ElfW (Half) fits in int.
2431 (fatal): Use same signature as lisp.h.
2432 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2433 configure and build with -DUNEXELF_DEBUG without worrying about
2434 other modules that use DEBUG.
2435 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2436 possibly-wide integers now uses it instead of plain fprintf.
2437 (entry_address): New function, which avoids problems with 32-bit
2438 overflow on 64-bit hosts.
2439 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2440 (round_up): Don't assume the remainder fits in int.
2441 (find_section): Use bool for boolean. Simplify debug code.
2442 (unexec): Don't assume file sizes fit in int or size_t.
2443 Omit unnecessary trailing newline in 'fatal' format.
2444 Use strerror rather than outputting decimal error number.
2445 Remove unused code when emacs is not defined;
2446 this file relies on Emacs now.
2447 Don't assume e_phnum and e_shnum are positive.
2448
dc4a2ee0
PE
2449 * regex.c: Fix problems when DEBUG is defined.
2450 (extract_number, extract_number_and_incr): Define regardless of
2451 whether DEBUG is defined; that's simpler and makes the code less
2452 likely to go stale in the normal case when DEBUG is not defined.
2453 Return int rather than taking an int * arg. All callers changed.
2454 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2455 Remove, replacing with ...
2456 (DEBUG_PRINT): New macro. All callers changed.
2457 (DEBUG_COMPILES_ARGUMENTS): New macro.
2458 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2459 (print_compiled_pattern, print_double_string) [DEBUG]:
2460 Use prototype rather than old-style definition.
2461 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2462 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2463 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2464 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2465 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2466 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2467 This matters only when DEBUG is defined.
2468
14c7ed05
EZ
24692013-05-05 Eli Zaretskii <eliz@gnu.org>
2470
2471 * xdisp.c (set_iterator_to_next): Set the
2472 ignore_overlay_strings_at_pos_p flag only if we are _really_
2473 iterating over an overlay string, as indicated by the
2474 current.overlay_string_index member. (Bug#14306)
2475
e6076b1b
JD
24762013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2477
2478 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2479 to where it is used, to avoid autorelease issues (Bug#14050).
2480
cbee2131
PE
24812013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2482
2483 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2484 * fileio.c (syms_of_fileio): Implement this.
2485 * filelock.c (create_lock_file): If symbolic links don't work, so
2486 we use a regular file as a lock file, do not fsync the lock file;
2487 it's not needed.
2488
30c7e542
SM
24892013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2490
2491 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2492 (syms_of_minibuf): Adjust accodingly.
2493 * lread.c (Fread):
2494 * callint.c (Fcall_interactively): Adjust calls accordingly.
2495
5bebd186
EZ
24962013-05-04 Eli Zaretskii <eliz@gnu.org>
2497
2498 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2499 w->contents is a buffer before computing everything else.
2500 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2501
2502 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2503 assertion violations. (Bug#14062)
2504
0fb0a4f3
DR
25052013-05-01 David Reitter <david.reitter@gmail.com>
2506
2507 * nsfns.m (ns_tooltip): Initialize.
2508
9e63b4a5
EZ
25092013-04-28 Eli Zaretskii <eliz@gnu.org>
2510
2511 * coding.c (decode_coding_gap): Don't remove the character before
2512 a newline unless it's a CR character. (Bug#14287)
2513
ad60824e
DN
25142013-04-28 Dan Nicolaescu <dann@gnu.org>
2515
2516 * dispextern.h (struct face): Move enum face_underline_type
2517 earlier so that bitfields can be in the same word.
2518
edbdcec0
JD
25192013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2520
2521 * nsfns.m (handlePanelKeys): New function.
2522 (EmacsOpenPanel:performKeyEquivalent:)
2523 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
2524 arrows/function/control and copy/paste keys (Bug#14296).
2525
0208ede7
JL
25262013-04-27 Juri Linkov <juri@jurta.org>
2527
2528 * callint.c (Fcall_interactively): Call `Qread_number' for
2529 interactive code letter `n' instead of using duplicate code.
2530 (Bug#14254)
2531
b8dd59f7
PE
25322013-04-27 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 * systime.h (make_timeval): Declare as 'const'.
2535
8bd722db
KH
25362013-04-27 Kenichi Handa <handa@gnu.org>
2537
2538 * font.c (font_open_entity): Always open a font of manageable
2539 size.
2540
13d0e56f 25412013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 2542
f780d632
PE
2543 Port better to AIX (Bug#14258).
2544 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
2545 to pacify AIX xlc.
2546
ec509856
KH
25472013-04-24 Kenichi Handa <handa@gnu.org>
2548
2549 * coding.c (decode_coding_iso_2022): When an invalid escape
2550 sequence is encountered, reset the invocation and designation
2551 status to the safest one.
2552
84fc48e5
PE
25532013-04-22 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
2556 Without this fix, "make distclean" leaves stamp-h1 behind.
2557
806bda47
EC
25582013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
2559
2560 * w32fns.c (w32_fullscreen_rect): New function to compute the
2561 window rectangle for the given fullscreen mode.
2562 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
2563 longer tunes the window size. This keeps the window's edges flush
2564 with the screen and allows the taskbar to hide itself in fullboth.
2565
2566 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
2567 window decorations and uses the entire screen.
2568
2569 * w32term.h (w32_fullscreen_rect) Add prototype.
2570 (struct w32_output): Replace normal_width, normal_height,
2571 normal_top, and normal_left members with a single normal_placement
2572 struct.
2573 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
2574 Remove macros.
2575 (FRAME_NORMAL_PLACEMENT): New macro.
2576
9cc2810b
JB
25772013-04-16 Juanma Barranquero <lekktu@gmail.com>
2578
2579 * minibuf.c (Ftest_completion): Silence compiler warning.
2580
fd16b54c
EZ
25812013-04-15 Eli Zaretskii <eliz@gnu.org>
2582
2583 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 2584 bug#14062.
fd16b54c
EZ
2585
2586 * frame.h (WINDOW_FRAME): Protect macro and its argument with
2587 parentheses.
2588
2589 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
2590 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
2591 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
2592 parentheses where appropriate.
2593
9e3379a0
PE
25942013-04-14 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * keyboard.c (timer_start_idle): Remove no-longer-used local.
2597
ddd6b685
EZ
25982013-04-14 Eli Zaretskii <eliz@gnu.org>
2599
2600 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
2601 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
2602 Mention in the doc string that setting these variables takes
2603 effect only after a call to set-window-buffer. (Bug#14200)
2604
29b79ba1
EZ
26052013-04-13 Eli Zaretskii <eliz@gnu.org>
2606
2607 * indent.c (Fvertical_motion): Don't consider display strings on
2608 overlay strings as display strings on the buffer position we
2609 started from. This prevents vertical cursor motion from jumping
2610 more than one line when there's an overlay string with a display
2611 property at end of line.
2612 Reported by Karl Chen <Karl.Chen@quarl.org> in
2613 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
2614
562c6ee9
SM
26152013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
2616
2617 * window.c (select_window): `record_buffer' even if window is
2618 already selected (bug#14191).
2619
fcc1fe85
EZ
26202013-04-11 Eli Zaretskii <eliz@gnu.org>
2621
2622 * window.c (Fwindow_end): Test more flags, including the buffer's
2623 last_overlay_modified flag, to determine whether the window's
2624 display is really up-to-date. Prevents the function from
2625 returning a stale value. (Bug#14170)
2626 (Fwindow_line_height): Fix the test for up-to-date-ness of the
2627 current matrix.
2628
f009190a
EZ
26292013-04-10 Eli Zaretskii <eliz@gnu.org>
2630
2631 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
2632 garbaged only if it is not already the top frame on its TTY.
2633 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
2634 there are GUI frames open in the same session. (Bug#13864)
2635
78ce603d
SM
26362013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
2637
2638 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
2639 of marking the idle timers directly.
2640
a8036e40
SM
26412013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
2642
2643 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
2644 tables (bug#14054).
2645
7ffe7ef6
SM
26462013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
2647
2648 * window.c (select_window): Don't record_buffer while the invariant is
2649 temporarily broken (bug#14161).
2650
2651 * fns.c (Fdelq): Don't assume !NILP => CONSP.
2652
7d9f6883
EZ
26532013-04-07 Eli Zaretskii <eliz@gnu.org>
2654
2655 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
2656
5406cfd9
RF
26572013-04-07 Romain Francoise <romain@orebokech.com>
2658
2659 Ignore additional platform-specific ACL errors (Bug#13702).
2660 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
2661 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
2662
95c0e83b
JD
26632013-03-31 Jan Djärv <jan.h.d@swipnet.se>
2664
2665 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
2666 f->output_data.ns.
2667
876da980
PE
26682013-04-07 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
2671 This bug was introduced by my 2013-02-25 change that simplified
2672 data_start configuration. Without this change, on GNU/Linux
2673 an Emacs configured with --enable-profiling fails immediately
2674 due to a profiler signal.
2675 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
2676 with these flags. On platforms where special flags are needed
2677 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
2678 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
2679 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
2680
7452b7bd
DA
26812013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
2682
2683 Get rid of some platform-specific functions examining window
2684 system and its capabilities. This is a partial rework of the
2685 2013-04-05 change.
2686 * lisp.h (have_menus_p): Remove prototype. This function is
2687 replaced with platform-independent window_system_available.
2688 (check_window_system): Move to...
2689 * frame.h (decode_window_system_frame, window_system_available):
2690 ...here, add new prototypes.
2691 * frame.c (window_system_available, decode_window_system_frame):
2692 New functions.
2693 (check_window_system): Platform-independent now.
2694 * xterm.h (x_in_use): Remove declaration.
2695 (check_x_frame):
2696 * w32term.h (check_x_frame):
2697 * nsterm.h (check_x_frame): Remove prototypes. This function
2698 is replaced with platform-independent decode_window_system_frame.
2699 * msdos.c (have_menus_p): Remove.
2700 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
2701 Remove platform-specific functions. Use check_window_system,
2702 decode_window_system_frame and check_ns_display_info where
2703 appropriate. Minor style and comment tweaks.
2704 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
2705 (check_x_frame): Likewise.
2706 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
2707 Likewise.
2708 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
2709 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
2710 * xmenu.c, xselect.c: All related users changed.
2711
251e9147
KH
27122013-04-03 Kenichi Handa <handa@gnu.org>
2713
2714 The following changes is to optimize the code for reading UTF-8
2715 files.
2716
562c6ee9 2717 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
2718 changed. Check EOL format. Do not call adjust_coding_eol_type
2719 here.
2720 (check_utf_8): New function.
2721 (adjust_coding_eol_type): Do nothing if already adjusted.
2722 (detect_coding): Compare the return value of check_ascii with
2723 coding->src_bytes. Call adjust_coding_eol_type if necessary.
2724 (decode_coding_gap): Optimize for valid UTF-8.
2725
8bc369d4
KH
27262013-03-21 Kenichi Handa <handa@gnu.org>
2727
2728 * coding.c (syms_of_coding): Cancel previous change.
2729
2730 * insdel.c (insert_from_gap): Fix previous change.
2731
73931ad1
DA
27322013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
2733
2734 Consistently use platform-specific function to detect window system.
2735 * lisp.h (check_window_system): New prototype. This function is
2736 going to replace check_x, check_w32 and check_ns.
2737 (have_menus_p): Mention msdos.c in comment.
2738 * fontset.c (check_window_system_func): Remove. Adjust all users.
2739 * fontset.h (check_window_system_func): Remove prototype.
2740 * nsterm.h (check_ns):
2741 * xterm.h (check_x):
2742 * w32term.h (check_w32): Likewise.
2743 * menu.c (Fx_popup_menu): Use check_window_system.
2744 * msdos.c (check_window_system): Define for MS-DOS.
2745 * nsfns.m (check_window_system): Define for NS. Adjust all users.
2746 * w32fns.c (check_window_system): Likewise for MS-Windows.
2747 * xfns.c (check_window_system): Likewise for X.
2748 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
2749 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
2750
7216e43b
PE
27512013-04-02 Paul Eggert <eggert@cs.ucla.edu>
2752
2753 Prefer < to > in range checks such as 0 <= i && i < N.
2754 This makes it easier to visualize quantities on a number line.
2755 This patch doesn't apply to all such range checks,
2756 only to the range checks affected by the 2013-03-24 change.
2757 This patch reverts most of the 2013-03-24 change.
2758 * alloc.c (xpalloc, Fgarbage_collect):
2759 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
2760 * character.c (string_escape_byte8):
2761 * charset.c (read_hex):
2762 * data.c (cons_to_unsigned):
2763 * dispnew.c (update_frame_1):
2764 * doc.c (Fsubstitute_command_keys):
2765 * doprnt.c (doprnt):
2766 * editfns.c (hi_time, decode_time_components):
2767 * fileio.c (file_offset):
2768 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2769 * font.c (font_intern_prop):
2770 * frame.c (x_set_alpha):
2771 * gtkutil.c (get_utf8_string):
2772 * indent.c (check_display_width):
2773 * keymap.c (Fkey_description):
2774 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
2775 * lread.c (read1):
2776 * minibuf.c (read_minibuf_noninteractive):
2777 * process.c (wait_reading_process_output):
2778 * search.c (Freplace_match):
2779 * window.c (get_phys_cursor_glyph):
2780 * xdisp.c (redisplay_internal):
2781 * xsmfns.c (smc_save_yourself_CB):
2782 Prefer < to > for range checks.
2783 * dispnew.c (sit_for): Don't mishandle NaNs.
2784 This fixes a bug introduced in the 2013-03-24 change.
2785 * editfns.c (decode_time_components): Don't hoist comparison.
2786 This fixes another bug introduced in the 2013-03-24 change.
2787
92759988
DA
27882013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
2789
2790 * frame.h (struct frame): Drop scroll_bottom_vpos
2791 member becaue all real users are dead long ago.
2792 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
2793 * xdisp.c (redisplay_internal): Adjust user.
2794
9a1971bb
GM
27952013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
2796
f38ab167
JD
2797 * nsmenu.m (showAtX:Y:for:): setLevel to
2798 NSPopUpMenuWindowLevel (Bug#13998).
2799
6d01f1fe
JD
28002013-03-30 Jan Djärv <jan.h.d@swipnet.se>
2801
2802 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
2803 (ns_check_pending_open_menu): Declare.
2804
2805 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
2806 (x_activate_menubar): Update the menu with title that matches
2807 ns_get_pending_menu_title, and call
2808 ns_check_pending_openmenu (Bug#12698).
2809 (menuWillOpen:): New method.
2810 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
2811
2812 * nsterm.m (menu_will_open_state, menu_mouse_point)
2813 (menu_pending_title): New varaibles.
2814 (ns_get_pending_menu_title, ns_check_menu_open)
2815 (ns_check_pending_open_menu): New functions.
2816
781f4782
DA
28172013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
2818
2819 * indent.c (current_column_bol_cache): Remove leftover which is not
2820 used in Fmove_to_column any more.
2821 (current_column, scan_for_column): Adjust users.
2822 * keyboard.c (last_point_position_buffer, last_point_position_window):
2823 Remove leftovers which are not used for recording undo any more.
2824 (command_loop_1, syms_of_keyboard): Adjust users.
2825 * xdisp.c (last_max_ascent): Remove leftover which is not used in
2826 redisplay_window any more.
2827 (move_it_to): Adjust user.
2828
1921c31b
JB
28292013-03-29 Juanma Barranquero <lekktu@gmail.com>
2830
2831 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
2832 Update dependencies.
2833
717b8bcd
SM
28342013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2835
2836 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
2837 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
2838 forward references.
2839
e74aeda8
DA
28402013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2841
2842 * window.h (struct window): Replace hchild, vchild and buffer slots
2843 with the only contents slot. This is possible because each valid
2844 window may have either the child window (in vertical or horizontal
2845 combination) or buffer to display (for the leaf window). Using that,
2846 a lof of operations to traverse and/or change window hierarchies may
2847 be simplified. New member horizontal is used to distinguish between
2848 horizontal and vertical combinations of internal windows.
2849 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
2850 (WINDOW_VERTICAL_COMBINATION_P): New macros.
2851 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
2852 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
2853 Use contents slot, not buffer, where appropriate.
2854 (wset_combination): New function.
2855 (wset_buffer): Add eassert.
2856 (Fframe_first_window): Simplify the loop reaching first window.
2857 (Fwindow_buffer): Use WINDOW_LEAF_P.
2858 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
2859 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
2860 (unshow_buffer): Convert initial debugging check to eassert.
2861 (replace_window, recombine_windows, Fdelete_other_windows_internal)
2862 (make_parent_window, window_resize_check, window_resize_apply)
2863 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
2864 (Fset_window_configuration, delete_all_child_windows, save_window_save):
2865 Adjust to match struct window changes.
2866 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
2867 (mark_window_cursors_off, count_windows, get_leaf_windows)
2868 (foreach_window_1): Simplify the loop.
2869 * alloc.c (mark_object): Do not check for the leaf window because
2870 internal windows has no glyph matrices anyway.
2871 * dispnew.c (clear_window_matrices, showing_window_margins_p)
2872 (allocate_matrices_for_window_redisplay, fake_current_matrices)
2873 (allocate_matrices_for_frame_redisplay, free_window_matrices)
2874 (build_frame_matrix_from_window_tree, mirror_make_current)
2875 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
2876 (update_window_tree, set_window_update_flags): Simplify the loop.
2877 (sync_window_with_frame_matrix_rows): Enforce live window.
2878 Use contents slot, not buffer, where appropriate.
2879 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
2880 and WINDOW_HORIZONTAL_COMBINATION_P.
2881 (make_frame_visible_1): Simplify the loop.
2882 Use contents slot, not buffer, where appropriate.
2883 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
2884 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
2885 (expose_window_tree): Likewise.
2886 Use contents slot, not buffer, where appropriate.
2887 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
2888 to avoid deleted windows. Use contents slot instead of buffer.
2889 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
2890 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
2891 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
2892 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
2893
121ab1cd
EZ
28942013-03-28 Eli Zaretskii <eliz@gnu.org>
2895
ef454cf7
EZ
2896 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
2897 identify the reasons for assertion violations in bug#14062 and
2898 similar ones.
21e930f8
EZ
2899 (Fx_show_tip): Fix compilation error under
2900 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 2901
121ab1cd
EZ
2902 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
2903 Reported by <rzl24ozi@gmail.com>.
2904
5c89ca24
DA
29052013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2906
2907 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
2908 start marker...
562c6ee9
SM
2909 (unwind_with_echo_area_buffer): ...to restore it here.
2910 This is needed to ensure that...
5c89ca24
DA
2911 (redisplay_window): ...both window markers are valid here,
2912 which is verified by eassert.
2913 * editfns.c (save_excursion_save): Do not assume that
2914 selected_window always displays the buffer.
c7f53895
DA
2915 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
2916 Fix comment.
5c89ca24 2917
f557c1b1
SM
29182013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
2919
2920 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
2921 the upcase table.
2922
40693bba 29232013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
2924
2925 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
2926
c86f791f
EZ
29272013-03-27 Eli Zaretskii <eliz@gnu.org>
2928
2929 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
2930 since MinGW's w32api headers do. This avoids compiler warnings.
2931
2932 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
2933 if already defined.
2934
c6e72e17
EZ
29352013-03-26 Eli Zaretskii <eliz@gnu.org>
2936
2937 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
2938
54e95010
JD
29392013-03-26 Jan Djärv <jan.h.d@swipnet.se>
2940
2941 * gtkutil.c (style_changed_cb): Check if frame is live and an
2942 X frame (Bug#14038).
2943
b88b62de
EZ
29442013-03-26 Eli Zaretskii <eliz@gnu.org>
2945
a18d7de6
EZ
2946 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
2947 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
2948 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
2949 MinGW64.
8f5e14c8
EZ
2950 Move inclusion of time.h before sys/time.h, so that MinGW64 could
2951 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 2952
b88b62de
EZ
2953 Fix incompatibilities between MinGW.org and MinGW64 headers.
2954 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
2955
2956 * w32.c (REPARSE_DATA_BUFFER): Guard with
2957 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
2958
c074e458
JD
29592013-03-25 Jan Djärv <jan.h.d@swipnet.se>
2960
2961 * xterm.c: Include X11/XKBlib.h
2962 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
2963
908589fd
AS
29642013-03-24 Andreas Schwab <schwab@linux-m68k.org>
2965
2966 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
2967 written backwards.
2968 * blockinput.h (input_blocked_p): Likewise.
2969 * bytecode.c (exec_byte_code): Likewise.
2970 * callproc.c (call_process_kill, call_process_cleanup)
2971 (Fcall_process): Likewise.
2972 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
2973 (Fccl_execute_on_string): Likewise.
2974 * character.c (string_escape_byte8): Likewise.
2975 * charset.c (read_hex): Likewise.
2976 * cm.c (calccost): Likewise.
2977 * data.c (cons_to_unsigned): Likewise.
2978 * dired.c (directory_files_internal, file_name_completion):
2979 Likewise.
2980 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
2981 (sit_for): Likewise.
2982 * doc.c (Fsubstitute_command_keys): Likewise.
2983 * doprnt.c (doprnt): Likewise.
2984 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
2985 * emacsgtkfixed.c: Likewise.
2986 * fileio.c (file_offset, Fwrite_region): Likewise.
2987 * floatfns.c (Fexpt, fmod_float): Likewise.
2988 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2989 Likewise.
2990 * font.c (font_intern_prop): Likewise.
2991 * frame.c (x_set_alpha): Likewise.
2992 * gtkutil.c (get_utf8_string): Likewise.
2993 * indent.c (check_display_width): Likewise.
2994 * intervals.c (create_root_interval, rotate_right, rotate_left)
2995 (split_interval_right, split_interval_left)
2996 (adjust_intervals_for_insertion, delete_node)
2997 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2998 (merge_interval_right, merge_interval_left, copy_intervals)
2999 (set_intervals_multibyte_1): Likewise.
3000 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3001 * keymap.c (Fkey_description): Likewise.
3002 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3003 * lread.c (openp, read_integer, read1, string_to_number):
3004 Likewise.
3005 * menu.c (ensure_menu_items): Likewise.
3006 * minibuf.c (read_minibuf_noninteractive): Likewise.
3007 * print.c (printchar, strout): Likewise.
3008 * process.c (create_process, Faccept_process_output)
3009 (wait_reading_process_output, read_process_output, send_process)
3010 (wait_reading_process_output): Likewise.
3011 * profiler.c (make_log, handle_profiler_signal): Likewise.
3012 * regex.c (re_exec): Likewise.
3013 * regex.h: Likewise.
3014 * search.c (looking_at_1, Freplace_match): Likewise.
3015 * sysdep.c (get_child_status, procfs_ttyname)
3016 (procfs_get_total_memory): Likewise.
3017 * systime.h (EMACS_TIME_VALID_P): Likewise.
3018 * term.c (dissociate_if_controlling_tty): Likewise.
3019 * window.c (get_phys_cursor_glyph): Likewise.
3020 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3021 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3022 Likewise.
3023 * xfns.c (Fx_window_property): Likewise.
3024 * xmenu.c (set_frame_menubar): Likewise.
3025 * xselect.c (x_get_window_property, x_handle_dnd_message):
3026 Likewise.
3027 * xsmfns.c (smc_save_yourself_CB): Likewise.
3028 * xterm.c (x_scroll_bar_set_handle): Likewise.
3029
2bf7d27a
DA
30302013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3031
3032 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3033 to be optional or nil. Adjust comment and convert it to docstring.
3034 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3035 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3036
a9ebfa0b
PE
30372013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 Static checking by GCC 4.8-20130319.
3040 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3041 * process.c (Fset_process_datagram_address)
3042 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3043 * xdisp.c (get_char_face_and_encoding):
3044 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3045 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3046 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3047
4f3576ee
KB
30482013-03-24 Ken Brown <kbrown@cornell.edu>
3049
789b5e9a
KB
3050 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3051 fix compilation on 64-bit Cygwin, where underscores are not
3052 automatically prepended.
3053
4f3576ee
KB
3054 * w32term.c (w32_initialize): Silence compiler warning.
3055
b5b7745f
EZ
30562013-03-23 Eli Zaretskii <eliz@gnu.org>
3057
cdc0d0bd
EZ
3058 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3059 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3060 variables, to save and restore frame dimensions.
3061 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3062 after returning from a 'fullscreen' configuration.
3063 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3064 to avoid races between the main thread and the input thread.
3065
3066 * w32term.h (struct w32_output): New members normal_width,
3067 normal_height, normal_top, normal_left, and prev_fsmode.
3068 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3069 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3070 members of a frame.
3071
b5b7745f
EZ
3072 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3073 'fullscreen' parameter. Always record previous width and height
3074 of the frame, except when switching out of maximized modes, so
3075 that they could be restored correctly, instead of resetting to the
3076 default frame dimensions. Send SC_RESTORE command to the frame,
3077 unless we are going to send SC_MAXIMIZE, to restore the frame
3078 resize hints in the mouse pointer shown by the window manager.
3079 (Bug#14032)
3080
3081 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3082
3083 * lisp.h (get_frame_param): Adjust conditions for prototype
3084 declaration.
3085
a3454eed
KB
30862013-03-22 Ken Brown <kbrown@cornell.edu>
3087
3088 * unexcw.c: Drop unneeded inclusion of w32common.h.
3089 (report_sheap_usage): Declare.
3090 (read_exe_header): Add magic numbers for x86_64.
3091 (fixup_executable): Fix printf format specifier for unsigned long
3092 argument.
3093
5a49b79c
DA
30942013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3095
3096 * frame.h (struct frame): Put menu_bar_window under #ifdef
3097 because this member is not needed when X toolkit is in use.
3098 (fset_menu_bar_window):
3099 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3100 (free_glyphs, update_frame):
3101 * xdisp.c (expose_frame): Likewise.
3102 (display_menu_bar): Likewise. Remove redundant eassert.
3103 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3104 toolkit is in use.
3105
d6723bf7
PE
31062013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3107
7b1123d8
PE
3108 Use functions and constants to manipulate Lisp_Save_Value objects.
3109 This replaces code that used macros and strings and token-pasting.
3110 The change makes the C source a bit easier to follow,
3111 and shrinks the Emacs executable a bit.
3112 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3113 (make_save_value): Change 1st arg from string to enum. All callers
3114 changed.
3115 (INTX): Remove.
3116 (mark_object): Use if, not #if, for GC_MARK_STACK.
3117 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3118 (XSAVE_OBJECT): Now functions, not macros.
3119 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3120 the constant was never used.
3121 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3122 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3123 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3124 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3125 New constants.
3126 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3127 type3 with a single member save_type. All uses changed.
3128 (save_type, set_save_pointer, set_save_integer): New functions.
3129 * print.c (PRINTX): Remove.
3130
d6723bf7
PE
3131 * alloc.c: Remove redundant static declarations.
3132
5f24fa51
DA
31332013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3134
3135 * window.h (struct window): Convert left_col, top_line, total_lines
3136 and total_cols from Lisp_Objects to integers. Adjust comments.
3137 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3138 Remove.
3139 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3140 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3141 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3142 Adjust users where appropriate.
3143
42143acd
DA
31442013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3145
3146 * frame.h (struct frame): Drop resx and resy because the same data is
3147 available from window system-specific output context. Adjust users.
562c6ee9
SM
3148 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3149 New functions to provide defaults when no window system available.
42143acd 3150 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3151 (NUMVAL): Move from xdisp.c.
42143acd
DA
3152 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3153 (Ffont_face_attributes, Fopen_font):
3154 * image.c (gs_load):
3155 * w32font.c (fill_in_logfont):
3156 * xdisp.c (calc_pixel_width_or_height):
3157 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3158 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3159
c0a17406
KH
31602013-03-20 Kenichi Handa <handa@gnu.org>
3161
3162 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3163 to 1 (temporary workaround until a bug related to ASCII
3164 optimization is fixed).
3165
095d384d
DA
31662013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3167
3168 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3169 Signal error if window is not internal. Adjust docstring.
3170 (delete_all_child_windows): Use combination_limit to save the buffer.
3171 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3172 * print.c (syms_of_print): Initialize debugging output not here...
3173 (init_print_once): ...but in a new function here.
3174 * lisp.h (init_print_once): Add prototype.
3175 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3176
748fa866
DA
31772013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3178
3179 * window.c (window_resize_check, window_resize_apply)
3180 (window_from_coordinates, recombine_windows, set_window_buffer)
3181 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3182 (Fsplit_window_internal, Fdelete_window_internal)
3183 (freeze_window_starts): Use bool for booleans.
3184 * window.h (window_frame_coordinates, resize_frame_windows)
3185 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3186
81519fd2
SM
31872013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3188
3189 * dispnew.c (bitch_at_user): Use `user-error'.
3190
6db423a9
KB
31912013-03-17 Ken Brown <kbrown@cornell.edu>
3192
3193 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3194 as return type of image_background. (Bug#13981)
3195 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3196
8f2906f5
JD
31972013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3198
960ce480 3199 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3200 (ns_select): Don't return with result uninitialized.
960ce480 3201
8f2906f5
JD
3202 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3203 and getDirectory.
3204
81519fd2
SM
3205 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3206 New functions.
8f2906f5
JD
3207 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3208 directories. If filename is nil, get directory name (Bug#13932).
3209 Use getFilename and getDirectory.
3210 (getFilename, getDirectory): New methods for EmacsSavePanel and
3211 EmacsOpenPanel.
3212 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3213
cded56c1
PE
32142013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3215
3216 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3217
251e9147 32182013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3219
3220 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3221 (adjust_after_replace): Make it back to static. Delete the third
3222 arg text_at_gap_tail. Cancel the code for handling it.
3223
3224 * coding.h (struct coding_system): New member eol_seen.
3225
3226 * coding.c (detect_ascii): New function.
3227 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3228 when the source bytes are actually scanned. On detecting for
3229 coding_category_utf_8_auto, call detect_ascii instead of scanning
3230 source bytes directly.
3231 (produce_chars): Call insert_from_gap with the new arg 0.
3232 (encode_coding): Likewise.
3233 (decode_coding_gap): Control ASCII optimization by the variable
3234 disable_ascii_optimization instead of #ifndef .. #endif.
3235 Deccode EOL format according to coding->eol_seen.
3236 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3237 variable.
3238
8a44e6d1
KH
3239 * lisp.h (adjust_after_replace): Cancel externing it.
3240 (insert_from_gap): Adjust prototype.
3241
5f795e34
EZ
32422013-03-15 Eli Zaretskii <eliz@gnu.org>
3243
3244 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3245 FULLSCREEN_MAXIMIZED. (Bug#13935)
3246
f258b4be
DA
32472013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3248
3249 * region-cache.c (find_cache_boundary, move_cache_gap)
3250 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3251 Simplify debugging check and convert to eassert. Adjust comment.
3252 (pp_cache): Put under ENABLE_CHECKING.
3253
a5cc4dde
EZ
32542013-03-14 Eli Zaretskii <eliz@gnu.org>
3255
3256 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3257 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3258 and WM_ACTIVATEAPP.
3259 (w32fullscreen_hook): If the frame is visible, reset
3260 f->want_fullscreen flag after changing the frame size. If the
3261 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3262 (Bug#13953)
3263
3fc5e44a
DC
32642013-03-13 Daniel Colascione <dancol@dancol.org>
3265
3266 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3267 too so that these builds can use Cygwin's file conversion
3268 functions. (We've been building and linking cygw32.o all along
3269 and just not using it.)
3270
47d7532e
PE
32712013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3272
3273 File synchronization fixes (Bug#13944).
3274 * Makefile.in (LIB_FDATASYNC): New macro.
3275 (LIBES): Use it.
3276 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3277 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3278 Don't worry about HAVE_FSYNC, since a substitute fsync is
3279 available if the system lacks one.
3280 (Fwrite_regin): Retry fsync if interrupted.
3281
c7ffccaf
EZ
32822013-03-13 Eli Zaretskii <eliz@gnu.org>
3283
4e2df81d 3284 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3285 activated, call w32fullscreen_hook, to make sure the new frame
3286 dimensions are in effect. (Bug#13937)
3287
8a7debc1
DA
32882013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3289
3290 * xdisp.c (init_iterator): Simplify because both character and byte
3291 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3292 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3293 character and byte positions can be obtained from marker.
8a7debc1 3294
7fd8c501
PE
32952013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3296
d9df6f40
PE
3297 Static checking by Sun C 5.12.
3298 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3299 * bytecode.c (exec_byte_code):
3300 * dispnew.c (init_display):
3301 * eval.c (error):
3302 * fileio.c (Fsubstitute_in_file_name):
3303 * keyboard.c (Fevent_convert_list):
3304 * keymap.c (Fsingle_key_description):
3305 * term.c (maybe_fatal, fatal):
3306 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3307 * xsmfns.c (Fhandle_save_session):
3308 Omit unreachable code.
3309 * keymap.c (map_keymap_char_table_item): Cast void * to
3310 a function pointer type; the C Standard requires this.
3311
7fd8c501
PE
3312 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3313 Include <sys/param.h> unconditionally, as that works elsewhere and
3314 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3315 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3316 and FreeBSD now.
3317
a020afb9 3318See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3319
3320;; Local Variables:
3321;; coding: utf-8
aac0c6e3
MR
3322;; End:
3323
ab422c4d 3324 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3325
3326 This file is part of GNU Emacs.
3327
3328 GNU Emacs is free software: you can redistribute it and/or modify
3329 it under the terms of the GNU General Public License as published by
3330 the Free Software Foundation, either version 3 of the License, or
3331 (at your option) any later version.
3332
3333 GNU Emacs is distributed in the hope that it will be useful,
3334 but WITHOUT ANY WARRANTY; without even the implied warranty of
3335 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3336 GNU General Public License for more details.
3337
3338 You should have received a copy of the GNU General Public License
3339 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.