* doc/lispref/text.texi (Insertion): Add cross-references.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2bede2ed
XF
12013-08-16 Xue Fuqiao <xfq.free@gmail.com>
2
3 * marker.c (set_marker): Remove documentation of undefined behavior.
4
703dbeba
LMI
52013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6
7 * image.c (imagemagick_compute_animated_image): Animate correctly
8 when sub-images are smaller than the main image.
1d18b1e6
LMI
9 (imagemagick_compute_animated_image): Setting the iterator row to
10 zero is apparently not allowed.
79670014
LMI
11 (imagemagick_compute_animated_image): Allow images that say they
12 have sub-images that are bigger than the main image, but just crop
13 them.
703dbeba 14
63216c5e
JD
152013-08-15 Jan Djärv <jan.h.d@swipnet.se>
16
17 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
18
a5b5f73f
LMI
192013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
20
21 * image.c (imagemagick_compute_animated_image): Respect the GIF
22 disposal methods.
23
0fe73012
KB
242013-08-15 Ken Brown <kbrown@cornell.edu>
25
26 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
27 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
28 needed.
29
691a357f
PE
302013-08-15 Paul Eggert <eggert@cs.ucla.edu>
31
32 Fix minor problems found by static checking.
33 * frame.c (delete_frame):
34 * xdisp.c (next_element_from_display_vector):
35 Avoid uninitialized local.
36 * image.c (imagemagick_compute_animated_image): Port to C89.
37 Prefer usual GNU indentation style for loops.
38 Be more careful about bizarrely large sizes, by using ptrdiff_t
39 instead of int.
40
42fe2e88
DA
412013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
42
43 Fix infinite frame selection loop (Bug#15025).
44 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
45
d39a3da6
EZ
462013-08-15 Eli Zaretskii <eliz@gnu.org>
47
48 * xdisp.c (compute_window_start_on_continuation_line): When
49 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
50 to make sure we end up setting the window start at the leftmost
51 visible character of the display line. This avoids funky
52 horizontal shifting because the window start is not kept on the
53 same position. (Bug#15090)
05426239
EZ
54 (next_element_from_display_vector): Support 'box' face attribute
55 in the face definitions of a display vector. (Bug#15099)
d39a3da6 56
6e856b69
LMI
572013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
58
59 * image.c (imagemagick_compute_animated_image): Implement animated
60 images (bug#14700).
995be755
LMI
61 (imagemagick_compute_animated_image): Fix some compilation
62 warnings. Implement a very simple cache to make the animation
63 usable at all, but it should be replaced with a per-image cache.
6e856b69 64
d5a1acfa
DA
652013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
66
67 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
68 to do `for' loops over alist values.
69 * buffer.h (FOR_EACH_BUFFER):
70 * process.c (FOR_EACH_PROCESS): Use it.
71 (handle_child_signal, status_notify, Fget_buffer_process)
72 (kill_buffer_processes): Use FOR_EACH_PROCESS.
73
9c253307
DA
742013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
75
76 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
77 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
78 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
79 to xzalloc and so avoid redundant call to memset.
80 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
81 members because it is allocated with xzalloc and so already zeroed.
82
05e64f9f
KB
832013-08-14 Ken Brown <kbrown@cornell.edu>
84
85 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
86 (Bug#15094).
87
5b71542d
DA
882013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
89
90 Utility function and macro to copy Lisp string to C string.
91 * lisp.h (xlispstrdupa): New macro.
92 (xlispstrdup): New prototype.
93 * alloc.c (xlispstrdup): New function.
94 * callint.c (Fcall_interactively):
95 * fileio.c (Ffile_name_directory, Fexpand_file_name)
96 (Fsubstitute_in_file_name):
97 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
98 * image.c (x_create_bitmap_from_file):
99 * w32term.c (w32_term_init):
100 * xterm.c (x_term_init): Use xlispstrdup.
101
71530c97
LMI
1022013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
103
4ce82fb8
LMI
104 * image.c (imagemagick_load_image): Make animated pictures work.
105 There's still some problems with background color settings, though
106 (bug#14700).
107
71530c97
LMI
108 * decompress.c (unwind_decompress): Always restore point.
109
7510a061
XF
1102013-08-14 Xue Fuqiao <xfq.free@gmail.com>
111
112 * marker.c (set_marker): Reformat documentation.
113
01c3051f
PE
1142013-08-14 Paul Eggert <eggert@cs.ucla.edu>
115
aab1fcdf
PE
116 * xdisp.c (cursor_type_changed): Now static.
117
01c3051f
PE
118 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
119 Use changed. This avoids the need to call xmalloc and for the
120 caller to call xfree, and avoids memory leaks in some situations.
121
2084152a
DA
1222013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
123
124 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
125 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
126 (redisplay_window): If window_end_valid is cleared due to non-zero
127 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
128 so do not call to try_cursor_movement for that window.
2084152a 129
02455cb6
DA
1302013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
131
132 * window.h (struct window): Convert window_end_pos and
133 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
134 (wset_window_end_pos, wset_window_end_vpos): Remove.
135 * dispnew.c (adjust_glyph_matrix):
136 * window.c (Fwindow_end, replace_window, set_window_buffer)
137 (make_window):
138 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
139 (set_vertical_scroll_bar, redisplay_window, try_window)
140 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
141 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
142 (note_mouse_highlight): Adjust users.
143 (try_cursor_movement): Likewise. Convert old precondition to eassert.
144 Add comment.
145
da5707e8
DA
1462013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
147
148 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
149 * image.c (imagemagick_filename_hint): Use `const char *' and
150 prefer SSDATA to SDATA to avoid warnings.
151
25554267
DA
1522013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Cleanup window fringes, margins and scroll bars adjustments.
155 * window.c (set_window_fringes, set_window_margins)
156 (set_window_scroll_bars, apply_window_adjustment): New functions.
157 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
158 (Fset_window_scroll_bars): Use them.
159
38a2c910
DA
1602013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
161
162 * window.h (struct window): Convert scroll_bar_width
163 from Lisp_Object to integer. Adjust comment.
164 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
165 Adjust users.
166 * window.c (wset_scroll_bar_width): Remove.
167 (make_window): Initialize scroll_bar_width.
168 (Fsplit_window_internal): Use direct assignment.
169 (Fset_window_configuration, save_window_save):
170 Convert Lisp_Object to integer and back where appropriate.
171 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
172 bar was actually changed, and mention this in docstring.
173
2d065031
PE
1742013-08-13 Paul Eggert <eggert@cs.ucla.edu>
175
176 * decompress.c: Minor simplifications.
177 (Fzlib_decompress_region): Don't bother verifying
178 that avail_out <= UINT_MAX, as that was confusing.
179 Mention the restriction in a comment instead.
180 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
181
a5bd5abb
JD
1822013-08-13 Jan Djärv <jan.h.d@swipnet.se>
183
184 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
185 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
186
66e7901a
LMI
1872013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
188
189 * image.c (imagemagick_filename_hint): Check for errors in the
190 alist structure.
191
2fa611b7
EZ
1922013-08-13 Eli Zaretskii <eliz@gnu.org>
193
194 * window.c (Fwindow_margins): Return nil when there's no marginal
195 area, as per the documented API.
196
197 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
198 Fmake_vector, as scroll bar's struct members are not all Lisp
199 objects now. This avoids crashes in GC.
200
201 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
202 bool, so its address could be taken.
203
8259030d
LMI
2042013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
205
206 * image.c (imagemagick_filename_hint): New function to possibly
207 apply `image-content-type-suffixes'.
208 (imagemagick_load_image): Use it.
209
866c710e
EZ
2102013-08-13 Eli Zaretskii <eliz@gnu.org>
211
212 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
213 if loading zlib failed.
214
f10490f0
JD
2152013-08-13 Jan Djärv <jan.h.d@swipnet.se>
216
96311be7
JD
217 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
218 2013-08-13 checkin below. Change bool to BOOL, rule is:
219 All Obj-C code uses BOOL, except for interfaces callable from C.
220
f10490f0
JD
221 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
222
c8ae93b0
DA
2232013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
224
225 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
226 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
227 bool instead of BOOL.
228 * w32term.h (struct scroll_bar): Convert fringe_extended_p
229 from Lisp_Object to bitfield. Adjust comment.
230 * w32term.c (x_scroll_bar_create): Adjust user.
231 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
232 * xterm.c (XTset_vertical_scroll_bar): Likewise.
233 Use bool for boolean.
234 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
235 to `unsigned int' when defining a bitfield.
236
53b64418
PE
2372013-08-13 Paul Eggert <eggert@cs.ucla.edu>
238
239 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
240
eeaf9bf3
DA
2412013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
242
243 * window.h (struct window): Convert left_margin_cols and
244 right_margin_cols from Lisp_Objects to integers. Adjust comment.
245 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
246 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
247 Adjust users.
248 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
249 Adjust comment.
250 (showing_window_margins_p, update_window_line, update_frame_1):
251 * fringe.c (draw_fringe_bitmap_1):
252 * xdisp.c (window_box_width): Adjust users.
253 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
254 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
255 Use direct assignment.
256 (Fset_window_configuration, save_window_save, Fwindow_margins):
257 Convert Lisp_Object to integer and back where appropriate.
258 (Fset_window_margins): Adjust user. Return t if any margin
259 was actually changed, and mention this in docstring.
260
956720af
XF
2612013-08-13 Xue Fuqiao <xfq.free@gmail.com>
262
f73f4ce6 263 * syntax.c (forward_word):
956720af
XF
264 * cmds.c (forward_char, backward_char): Mention the optional argument.
265
9e37ee3b
DA
2662013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
267
268 * window.h (struct window): Convert left_fringe_width
269 and right_fringe_width from Lisp_Objects to integers.
270 Adjust comment.
271 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
272 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
273 * window.c (wset_left_fringe_width, wset_right_fringe_width):
274 Remove.
275 (make_window): Initialize new integer fields to -1.
276 (Fsplit_window_internal): Use direct assignment.
277 (Fset_window_configuration, save_window_save): Convert
278 Lisp_Object to integer and back where appropriate.
279 (Fset_window_fringes): Adjust user. Return t if any fringe
280 was actually changed, and mention this in docstring.
281
e4375ca7
DA
2822013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
283
284 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
285 * nsfns.m (x_set_cursor_type):
286 * w32fns.c (x_set_cursor_type):
287 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
288 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 289
a45543bc
DA
2902013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
291
292 * font.c (clear_font_cache): New function, stripped from...
293 (Fclear_font_cache): ...here, which now uses the function
294 above. Adjust comment.
295 * font.h (clear_font_cache): Add prototype.
296 * xfaces.c (clear_face_cache): Use clear_font_cache.
297
ae966a86
DA
2982013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
299
300 * window.c (Fset_window_start): Compare `w', not `window' because
301 `w' might not be equal to `window' after call to decode_live_window.
302
297a545b
PE
3032013-08-12 Paul Eggert <eggert@cs.ucla.edu>
304
305 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
306 This fixes a problem introduced by the Bug#15035 patch
307 when using GPG. Reported by Herbert J. Skuhra.
308
aa942e2b
EZ
3092013-08-12 Eli Zaretskii <eliz@gnu.org>
310
311 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
312 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
313 not yet initialized.
314
7699d09e
LMI
3152013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
316
317 * decompress.c (Fzlib_decompress_region): Support zlib
318 decompression, too, and rename.
319
1d238bc7
PE
3202013-08-12 Paul Eggert <eggert@cs.ucla.edu>
321
322 Minor zlib configuration tweaks.
323 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
324 Don't assume presence of fn_inflateInit2_ zlib internal function.
325
8a44a184
LMI
3262013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
327
328 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
329 include the zlib prefix.
330
594a4307
EZ
3312013-08-12 Eli Zaretskii <eliz@gnu.org>
332
333 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
334 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
335 define static variables that are pointers to zlib functions to be
336 dynamically loaded.
337 (init_zlib_functions) [WINDOWSNT]: New function.
338 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
339 New macros.
340 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
341 macros instead of invoking the zlib functions directly.
342 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
343 Szlib_available_p.
344
d2e113bc
DA
3452013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
346
347 Avoid looping over all frame windows to freeze and unfreeze.
348 * window.h (struct window): Drop frozen_window_start_p.
349 (freeze_window_starts): Drop prototype.
350 * frame.h (struct frame): New frozen_window_starts flag.
351 (FRAME_WINDOWS_FROZEN): New macro.
352 * window.c (freeze_window_start, freeze_window_starts):
353 Remove.
354 (select_window, replace_window): Adjust users.
355 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
356 (window_frozen_p): New function.
357 (redisplay_window): Use it.
358
94fcd171
PE
3592013-08-12 Paul Eggert <eggert@cs.ucla.edu>
360
361 Fix some fd issues when running subprocesses (Bug#15035).
362 Fix bugs that can leak files or file descriptors on errors.
363 Don't unlink open temp files, as that's hard for users to diagnose
364 when things go awry (e.g., temp disk exhausted).
365 Don't bother to lock temp files. Check for invalid recursion.
366 * callproc.c (synch_process_fd): Remove. All uses removed.
367 (synch_process_tempfile): New var or macro.
368 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
369 New constants.
370 (record_kill_process): New arg, the temp name. All callers changed.
371 (delete_temp_file): Now just a simple wrapper around unlink.
372 (call_process_kill): New arg, the call_process_fd array.
373 Close them all. Clear synch_process_pid. Remove the temp file,
374 or arrange for it to be removed.
375 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
376 that's been moved to synch_process_tempfile. Caller changed.
377 Do not remove the tempfile; that's now call_process_kill's
378 responsibility.
379 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
380 call_process_kill; the caller now does that.
381 (call_process_cleanup): Do not close the process fd; that's now
382 call_process_kill's responsibility.
383 (Fcall_process): Implement via new function call_process, which
384 has most of the old body of Fcall_process, but with a different API.
385 (call_process): New function that does not open or close filefd if
386 it is nonnegative. Record which fds need to be closed, and let
387 call_process_kill close (and remove the tempfile, on MSDOS) on error.
388 Signal an error if invoked recursively (could be done via a hook).
389 Simplify creation of the tempfile in the MSDOS case.
390 Don't create the output file until after checking for the executable.
391 Report any failure to open /dev/null.
392 Don't open /dev/null for writing twice; once is enough.
393 Don't create pipe if all output is being discarded or sent to file.
394 Don't worry about setting up the coding system or reading from the
395 pipe if all output is being discarded.
396 Hoist fd_error local into top level, to lessen block nesting.
397 Don't record deleted pid here; now done by Fcall_process_region.
398 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
399 and note its success in synch_process_tempfile.
400 Do not leak resources when child_setup fails.
401 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
402 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
403 (create_temp_file): Now returns open fd, with an additional
404 Lisp_Object * argument to return the name. All callers changed.
405 Do not close the file; rewind it instead, and leave it open for
406 the caller. Do not lock the temp file. Unwind-protect the file
407 and the file-descriptor.
408 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
409 If an asynchrounous process, record it here, not in call_process.
410 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
411 * eval.c (set_unwind_protect): New function.
412 * fileio.c (write_region): New function, generalized from the
413 old Fwrite_region. Do not lock temp files.
414 (Fwrite_region): Use it.
415 * lisp.h (set_unwind_protect, write_region): New decls.
416 * process.c: Include <verify.h>.
417 (make_process): Mark fds as initially closed.
418 (deleted_pid_list): Now a list of pid-filename pairs.
419 All uses changed.
420 (close_process_fd): New function.
421 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
422 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
423 New constants. Verify that their number matches PROCESS_OPEN_FDS.
424 (create_process, create_pty, Fmake_serial_process)
425 (server_accept_connection): Record which fds need to be closed,
426 and let deactivate_process close them.
427 (Fmake_network_process): Do not discard the unwind-protect
428 until it's safe to do so.
429 (deactivate_process): Close the fds opened by create_process etc.
430 (Fprocess_send_eof): Adjust to new way of recording open fds.
431 Report an error if /dev/null can't be opened, instead of aborting.
432 * process.h (PROCESS_OPEN_FDS): New constant.
433 (struct Lisp_Process): New member open_fds.
434 (record_kill_process, record_deleted_pid): Adjust signatures.
435 (record_deleted_pid): Move decl here ...
436 * syswait.h (record_deleted_pid): ... from here.
437
d0e615c3
PE
4382013-08-11 Paul Eggert <eggert@cs.ucla.edu>
439
440 * decompress.c: Fix bugs with large buffers and weird inputs.
441 Tune a bit. Reindent as per usual Emacs style.
442 (BUFFER_SIZE): Remove.
443 (Fdecompress_gzipped_region): Do not mishandle input buffers with
444 more than UINT_MAX bytes. Decompress into the gap instead of into
445 an auto buffer, as this should avoid copying. Return nil if
446 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
447 set immediate_quit; we shouldn't trust zlib code that much.
448
313546eb
LMI
4492013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
450
99a32242
LMI
451 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
452 errors, and really move the gap to where we want it.
453
313546eb
LMI
454 * lisp.h: Include decompress.c support.
455
456 * emacs.c (main): Include decompress.c support.
457
458 * Makefile.in: Include -lz if present.
459
d2d699ac
JD
4602013-08-11 Jan Djärv <jan.h.d@swipnet.se>
461
f90e3ebd
JD
462 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
463 (initWithTitle:): Initialize frame to 0.
464 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
465 (fillWithWidgetValue:frame:): Renamed from
466 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
467
468 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
469 fillWithWidgetValue:frame:
470
423d3b3f
JD
471 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
472 remove memory leak warnings.
473
d2d699ac
JD
474 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
475 (ns_check_menu_open): Handle menu == nil. Remove assignment to
476 menu_pending_title.
477
478 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
479 (x_activate_menubar): Update the whole menu.
480 (trackingNotification:): Call ns_check_menu_open if tracking ends.
481 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
482 current event is not NSSystemDefined (Bug#15001).
483 Call ns_check_menu_open only if trackingMenu is 2.
484 (menuDidClose:): New method, decrease trackingMenu.
485 (fillWithWidgetValue:setDelegate:): New method.
486 (fillWithWidgetValue:): Call the above.
487
488 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
489
7d652d97
PE
4902013-08-11 Paul Eggert <eggert@cs.ucla.edu>
491
492 Omit some unnecessary casts.
493 Many of these go back to the old pre-C89 days, when they may have
494 been needed, but we've been assuming C89 or later for a while now.
495 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
496 (live_float_p, live_misc_p, live_vector_p):
497 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
498 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
499 (defvar_per_buffer):
500 * callint.c (Fcall_interactively):
501 * doc.c (Fsubstitute_command_keys):
502 * filelock.c (get_boot_time):
503 * frame.c (xrdb_get_resource):
504 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
505 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
506 (xg_get_file_name_from_selector, menuitem_destroy_callback)
507 (menuitem_highlight_callback, menu_destroy_callback)
508 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
509 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
510 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
511 (xg_tool_bar_help_callback, tb_size_cb):
512 * image.c (xpm_alloc_color, png_read_from_memory)
513 (png_read_from_file, png_load_body, our_memory_skip_input_data)
514 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
515 (syms_of_image):
516 * keymap.c (describe_map):
517 * nsfns.m (Fns_display_monitor_attributes_list):
518 * nsmenu.m (process_dialog:):
519 * nsterm.m (hold_event):
520 * process.c (wait_reading_process_output):
521 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
522 * scroll.c (do_direct_scrolling, scrolling_1):
523 * termcap.c (tgetent):
524 * window.c (check_window_containing, add_window_to_list)
525 (freeze_window_starts):
526 * xdisp.c (compare_overlay_entries, vmessage):
527 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
528 (x_get_monitor_attributes_xrandr)
529 (Fx_display_monitor_attributes_list, x_display_info_for_name)
530 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
531 * xfont.c (xfont_match, xfont_open):
532 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
533 (menubar_selection_callback, menu_position_func)
534 (popup_selection_callback, create_and_show_popup_menu)
535 (dialog_selection_callback, create_and_show_dialog):
536 * xrdb.c (x_get_string_resource):
537 (main) [TESTRM]:
538 * xsmfns.c (x_session_check_input):
539 * xterm.c (x_draw_glyphless_glyph_string_foreground)
540 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
541 (xaw_jump_callback, xaw_scroll_callback):
542 Omit unnecessary casts.
543
9acc1074
PE
5442013-08-10 Paul Eggert <eggert@cs.ucla.edu>
545
546 Minor string-length refactoring.
547 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
548 * frame.c (make_monitor_attribute_list):
549 Prefer build_string to strlen + make_string.
550
361c0eb8
JD
5512013-08-10 Jan Djärv <jan.h.d@swipnet.se>
552
553 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
554 don't check minor_code (Bug#14417).
555
14ba0822
EZ
5562013-08-09 Eli Zaretskii <eliz@gnu.org>
557
558 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
559 vertical positions instead. This avoids calling MATRIX_ROW with
560 row numbers that are possibly beyond valid limits. (Bug#15064)
561
309f24d1
DA
5622013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
563
564 Use xstrdup and build_unibyte_string where applicable.
565 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
566 * xfns.c (x_window):
567 * xrdb.c (x_get_customization_string):
568 * xterm.c (xim_initialize):
569 * w32fns.c (w32_window): Use xstrdup.
570 (w32_display_monitor_attributes_list):
571 * emacs.c (init_cmdargs):
572 * keyboard.c (PUSH_C_STR):
573 * nsfont.m (nsfont_open):
574 * sysdep.c (system_process_attributes):
575 * w32.c (system_process_attributes):
576 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
577
55902276
EZ
5782013-08-09 Eli Zaretskii <eliz@gnu.org>
579
580 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
581 variables of these types so that GDB would know about them, as aid
582 for debugging fatal exceptions. (Bug#15024) See also
583 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
584 discussions.
585
10bf7f5a
JD
5862013-08-08 Jan Djärv <jan.h.d@swipnet.se>
587
588 * nsterm.m (ns_update_begin): Don't change clip path if it would be
589 larger than the NSWindow (Bug#14934).
590
65620264
DA
5912013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
592
593 Redesign redisplay interface to drop global variable updated_window.
594 Always pass currently updated window as a parameter to update routines.
595 * dispextern.h (updated_window): Remove declaration.
596 (struct redisplay_interface): Pass window parameter to
597 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
598 and after_update_window_hook.
599 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
600 Adjust prototypes.
601 * dispnew.c (updated_window): Remove.
602 (redraw_overlapped_rows, update_marginal_area, update_text_area)
603 (update_window_line): Adjust to match redisplay interface changes.
604 * nsterm.m (ns_update_window_begin, ns_update_window_end)
605 (ns_scroll_run, ns_after_update_window_line):
606 * w32term.c (x_update_window_begin, x_update_window_end)
607 (x_after_update_window_line, x_scroll_run):
608 * xterm.c (x_update_window_begin, x_update_window_end)
609 (x_after_update_window_line, x_scroll_run):
610 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
611 Likewise. Adjust comments where appropriate.
612 (x_cursor_to): Simplify because this is always called during window
613 update (but install debugging check anyway).
614 (expose_window): Check must_be_updated_p flag to see whether this
615 function is called during window update.
616
628fdc56
DA
6172013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
618
619 Do not reset window modification event counters excessively.
620 These leftovers and poor man's tricky methods to catch extra
621 redisplay's attention are no longer needed.
622 * frame.c (set_menu_bar_lines_1):
623 * minibuf.c (read_minibuf_unwind):
624 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
625 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
626 (window_scroll_line_based, Fset_window_configuration):
627 * xdisp.c (redisplay_window): Do not reset last_modified and
628 last_overlay_modified counters.
629
8fd9c92e
JD
6302013-08-07 Jan Djärv <jan.h.d@swipnet.se>
631
632 * xselect.c (x_send_client_event): Set send_event and serial, memset
633 data.l as it might be bigger than data.b. Use 24 bit mask to
634 XSendEvent (Bug#15034).
635
0ee18172
EZ
6362013-08-07 Eli Zaretskii <eliz@gnu.org>
637
638 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
639 for TTY frames that are not the top frame on their console.
640 (Bug#14616)
641
16ddd1a6
MR
6422013-08-07 Martin Rudalics <rudalics@gmx.at>
643
644 * w32term.c (w32fullscreen_hook): Really maximize frame when
645 asked for (Bug#14841).
646
d2a95ffb
DA
6472013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
648
649 Prefer selected_window to Fselected_window, likewise for frames.
650 * buffer.c (Fbuffer_swap_text):
651 * data.c (Fvariable_binding_locus):
652 * window.c (run_window_configuration_change_hook): Adjust users.
653 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
654 Use decode_live_frame.
655
170da1ec
DA
6562013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
657
658 Be more careful if selected window shows the buffer other than current,
659 use window_outdated only if this is not so. This change should also
660 address some weird issues discussed in Bug#13012.
661 * window.h (window_outdated): New prototype.
662 * window.c (window_outdated): Now here. Convert from static and
663 always assume window's buffer.
664 (Fwindow_end, Fwindow_line_height): Use it.
665 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
666 and always assume window's buffer.
667 (redisplay_window): Adjust user.
e5eefe9b 668 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
669 check whether mode line should be updated only if selected window
670 shows current buffer.
671 (run_window_scroll_functions): Use eassert for debugging check.
672 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
673
56b5d5b1
DA
6742013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
675
676 * window.c (window_scroll, window_scroll_pixel_based)
677 (window_scroll_line_based): Use bool for booleans.
678
2878ba7e
PE
6792013-08-06 Paul Eggert <eggert@cs.ucla.edu>
680
681 * process.c: Fix minor off-by-one issues in descriptor counts.
682 This shouldn't fix any real bugs, but it cleans up the code a bit.
683 (max_process_desc, max_input_desc): -1, not 0, means none.
684 All uses changed.
685 (delete_input_desc): New function.
686 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
687 (deactivate_process): Scan backwards when recomuting max_process_desc;
688 that should be faster.
689 (init_process_emacs): Initialize max_input_desc.
690
e30b79c1
DA
6912013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Use region cache to speedup bidi_find_paragraph_start.
694 * buffer.h (struct buffer): New member bidi_paragraph_cache.
695 Rename cache_long_line_scans to cache_long_scans.
696 * buffer.c (bset_cache_long_line_scans): Rename to
697 bset_cache_long_scans.
698 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
699 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
700 into account.
701 (syms_of_buffer): Rename cache-long-line-scans to
702 cache-long-scans. Adjust docstring.
703 * search.c (newline_cache_on_off):
704 * indent.c (width_run_cache_on_off): Adjust users.
705 * bidi.c (bidi_paragraph_cache_on_off): New function.
706 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
707 * insdel.c (prepare_to_modify_buffer): Invalidate
708 bidi_paragraph_cache if enabled.
709
00012b86
DA
7102013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
711
712 Invalidate region caches only if buffer text is going to be changed.
713 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
714 (modify_text): ...new prototype.
715 (prepare_to_modify_buffer_1): New prototype.
716 * textprop.c (modify_region): Rename to...
717 (modify_text_properties): ...new function.
718 (add_text_properties_1, set_text_properties, Fremove_text_properties)
719 (Fremove_list_of_text_properties): Adjust users.
720 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
721 (modify_text): ...new function.
722 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
723 (prepare_to_modify_buffer_1): ...new function.
724 * casefiddle.c (casify_region):
725 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
726 (Ftranspose_regions): Use modify_text.
727
dc6c0eda
SM
7282013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
729
730 * lisp.mk (lisp): Add nadvice.elc.
731
8f3a2c26
DA
7322013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
733
734 New macro to iterate over live buffers similar to frames.
735 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
736 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
737 Declare buffer-related variables here to offload lisp.h.
738 * buffer.c (Vbuffer_alist): Adjust comment.
739 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
740 (other_buffer_safely):
741 * data.c (store_symval_forwarding):
742 * dispnew.c (Fframe_or_buffer_changed_p):
743 * fileio.c (Fdo_auto_save):
744 * filelock.c (unlock_all_files):
745 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
746
e0fdb694
PE
7472013-08-04 Paul Eggert <eggert@cs.ucla.edu>
748
749 Fix some minor races in hosts lacking mkostemp (Bug#15015).
750 * callproc.c (create_temp_file):
751 * filelock.c (create_lock_file):
752 Assume mkostemp, since it's now provided by Gnulib.
753
63f5c6c2
EZ
7542013-08-04 Eli Zaretskii <eliz@gnu.org>
755
756 * w32.c (mkostemp): New function.
757 (mktemp): Remove, no longer used. Most of the code reused in
758 mkostemp. (Bug#15015)
484ab239 759 (mktemp): Don't undef.
63f5c6c2 760
f0b79313
DA
7612013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
762
763 * dispnew.c (glyph_matrix_count, glyph_pool_count):
764 Move under GLYPH_DEBUG and ENABLE_CHECKING.
765 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
766 (free_glyph_pool, check_glyph_memory): Likewise for
767 all users. Adjust comments where appropriate.
768
98f638d6
PE
7692013-08-03 Paul Eggert <eggert@cs.ucla.edu>
770
771 * composite.h: Minor fixups.
772 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
773 to fix a misspelling, and change it to an inline function while
774 we're at it (it need not be a macro). All uses changed.
775 (composition_method, composition_valid_p):
776 Rewrite to avoid assignments in if-conditions.
777
75c59fb3
DA
7782013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
779
780 Do not use global Lisp_Object in composition macros.
781 * composite.h (composition_temp): Remove declaration.
782 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
783 (composition_method, composition_valid_p): ...inline functions.
416a3e01 784 (compose_region): Remove the leftover.
75c59fb3
DA
785 * composite.c (composition_temp): Remove.
786 (run_composition_function, update_compositions)
787 (composition_compute_stop_pos, composition_adjust_point)
788 (Ffind_composition_internal):
789 * coding.c (handle_composition_annotation):
790 * xdisp.c (handle_composition_prop, check_point_in_composition):
791 Related users changed.
792
a10c8269
DA
7932013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
794
795 Drop FRAME_PTR typedef.
796 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
797 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
798 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
799 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
800 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
801 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
802 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
803 All related users changed.
804
a104f656
SM
8052013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
806
807 * eval.c (default_toplevel_binding): New function.
808 (Fdefvar): Use it.
809 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
810 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
811 (syms_of_eval): Export them.
812 * data.c (Fdefault_value): Micro cleanup.
813 * term.c (init_tty): Use "false".
814
4b5c9326
DA
8152013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
816
817 Fix X GC leak in GTK and raw (no toolkit) X ports.
818 * xterm.c (x_free_frame_resources): If white and black relief
819 GCs are allocated, always free them here.
820 * xfns.c (x_make_gc): Omit redundant initialization.
821 * widget.c (create_frame_gcs): Remove the leftover.
822 (EmacsFrameDestroy): Do nothing because all GCs are now freed
823 in x_free_frame_resources.
824
b19aa636
JD
8252013-08-02 Jan Djärv <jan.h.d@swipnet.se>
826
827 * nsterm.m (windowWillResize:toSize:): Only change title if
828 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
829 modifying it.
830 (viewDidEndLiveResize): New method.
831
832 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
833 inside NS_IMPL_COCOA.
834
af1f7e06
DA
8352013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
836
837 * insdel.c (adjust_after_replace, replace_range, del_range_2):
838 Do not check whether undo is enabled because record_insert and
839 record_delete does that themselves.
840
65b02bb9
DA
8412013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
842
843 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
844 member which is not really used any more.
845 (FRAME_XIC_BASE_FONTNAME): Remove.
846 * xfns.c (xic_free_fontset): Adjust user.
847 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
848 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
849 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
850 (xdialog_show): Use eassert for debugging check.
7ee0f047 851 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 852
6318cde0
PE
8532013-08-01 Paul Eggert <eggert@cs.ucla.edu>
854
855 * fileio.c, fns.c (merge): Move extern decl from here ...
856 * lisp.h (merge): ... to here.
857
6c1a09ba
DA
8582013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
859
860 Fix last font-related change.
861 * w32font.h (w32font_list_internal, w32font_match_internal):
862 Fix prototype.
863 * w32uniscribe.c (uniscribe_list, uniscribe_match):
864 (uniscribe_list_family): Adjust to match font API change.
865 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
866 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
867
f8c20208
DA
8682013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
869
870 * frame.h (FRAME_MOUSE_UPDATE):
871 * nsterm.m (ns_frame_up_to_date): Omit redundant check
872 whether hlinfo->mouse_face_mouse_frame is non-NULL.
873
fdb396e2
DA
8742013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
875
876 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
877 * font.h (struct font_driver): Change list, match, and list_family
878 functions to accept struct frame * as first arg.
879 * font.c (font_score, font_compare, font_sort_entities): Remove
880 prototypes.
881 (font_sort_entities, font_list_entities, font_select_entity):
882 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
883 match font API change.
884 * xfont.c (xfont_list, xfont_match, xfont_list_family):
885 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
886 * ftxfont.c (ftxfont_list, ftxfont_match):
887 * xftfont.c (xftfont_list, xftfont_match):
888 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
889 * w32font.c (w32font_list, w32font_match, w32font_list):
890 (w32font_list_internal, w32_font_match_internal): Likewise.
891 * xfaces.c (Fx_family_fonts): Adjust user.
892
52b8a085
DA
8932013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
894
895 Do not use pure Xism x_wm_set_icon_position in non-X ports.
896 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
897 only if HAVE_X_WINDOWS is in use.
898 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
899 * nsterm.m (x_wm_set_icon_position): Remove no-op.
900 * w32term.c (x_wm_set_icon_position): Likewise.
901 * w32fns.c (x_icon): Adjust user.
902
c791c18e
DA
9032013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
904
905 * xterm.c (last_mouse_press_frame): Remove the
906 leftover which is not really used any more.
907 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
908 (x_flush): Call XFlush once per each X display, not frame.
909 This is better because this code always unconditionally skips
910 non-X frames in Vframe_list and issues the only XFlush if we
911 have more than one X frame on the same X display.
2f935d86
DA
912 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
913 Use bool for booleans.
914 (x_draw_glyph_string_background, cvt_string_to_pixel):
915 (cvt_pixel_dtor): Drop unnecessary prototypes.
916 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 917
f435830e
DA
9182013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
919
920 Drop unnecessary functions that deals with frame pixel size.
921 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
922 (x_pixel_height): Drop prototypes.
923 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
924 (x_pixel_height): Drop implementations.
925 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
926 which should be always valid for window frame.
927 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
928 * w32menu.c (Fx_popup_dialog):
929 * xmenu.c (Fx_popup_dialog): Likewise for both.
930
84231434
DA
9312013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
932
933 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
934 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
935 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
936 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
937 and mention nil frame in docstring.
84231434 938
959067a1
DA
9392013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
940
941 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
942 (x_figure_window_size): Likewise. Adjust to return long.
943 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
944 (toplevel): Move Qterminal_live_p to...
945 * terminal.c (toplevel): ...here, make it static, and...
946 (syms_of_terminal): ...DEFSYM here.
947 * frame.h (Qterminal_live_p): Remove declaration.
948 (make_frame, x_figure_window_size): Adjust prototype.
949 * nsfns.m (Fx_create_frame): Use long for window flags.
950
f4b169ce
PE
9512013-07-30 Paul Eggert <eggert@cs.ucla.edu>
952
953 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
954 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
955 Do not assume that emacs_close (INT_MAX) is a no-op.
956
bee6a2c7
DA
9572013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
958
959 * xfaces.c (make_face_cache): For struct face_cache, prefer
960 xmalloc to xzalloc and so avoid redundant call to memset.
961 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
962
d7e6881a
DA
9632013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
964
965 * fringe.c (draw_window_fringes, update_window_fringes)
966 (compute_fringe_widths):
967 * w32term.c (x_draw_glyph_string):
968 * window.c (candidate_window_p, Frecenter):
969 * xfaces.c (realize_basic_faces, realize_default_face)
970 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
971 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
972 * xfns.c (x_set_cursor_color, xic_free_xfontset):
973 * xmenu.c (Fx_menu_bar_open_internal):
974 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
975 * xsettings.c (xft_settings_event):
976 * xterm.c (x_draw_glyph_string, x_had_errors_p):
977 Use bool for booleans. Adjust style and comments where
978 appropriate.
979 * dispextern.h (draw_window_fringes, update_window_fringes)
980 (compute_fringe_widths):
981 * xterm.h (x_had_errors_p): Adjust prototype.
982
ec3058af
DA
9832013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
984
985 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
986 CHECK_LIST. Rewrite the loop to avoid useless local variable.
987
218e0637
DA
9882013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
989
990 * fns.c (toplevel): Remove comment before Fsafe_length because
991 it checks for QUIT.
992
e560aba9
PE
9932013-07-28 Paul Eggert <eggert@cs.ucla.edu>
994
995 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
996
2e5ce5de
EZ
9972013-07-28 Eli Zaretskii <eliz@gnu.org>
998
999 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1000 frame which got the message is still alive, before dereferencing
1001 its pointer. (Bug#14970)
1002
1003 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1004 be a live window, before using it as such. (Bug#14970)
1005
e95da6d3
EZ
10062013-07-27 Eli Zaretskii <eliz@gnu.org>
1007
1008 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1009 w32_detect_focus_change instead of doing part of its job by hand.
1010 This fixes the problem whereby FOCUS_OUT events were not sent to
1011 the event queue.
1012
a8f93651
EZ
10132013-07-26 Eli Zaretskii <eliz@gnu.org>
1014
fec92060
EZ
1015 * process.c (Fprocess_list): Doc fix.
1016
a8f93651
EZ
1017 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1018 being re-exposed only if it didn't ask to become visible.
1019 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1020 was previously iconified. (Bug#14841)
1021 (x_iconify_frame): Mark the frame iconified.
1022
d5a7a9d9
PE
10232013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1024
1025 Fix minor problems found by static checking.
1026 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1027 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1028
56ea7291
SM
10292013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1030
1031 * eval.c (set_specpdl_old_value): New function.
1032 (unbind_to): Minor simplification.
1033 (get_backtrace_frame): New function.
1034 (Fbacktrace_frame): Use it. Add `base' argument.
1035 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1036 (syms_of_eval): Export backtrace-eval.
1037 * xterm.c (x_focus_changed): Simplify.
1038
9d611ffe
PE
10392013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1040
1041 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1042
999c74e3
EZ
10432013-07-24 Eli Zaretskii <eliz@gnu.org>
1044
1045 * xdisp.c (redisplay_window): Instead of moving point out of
1046 scroll margin, reject the force_start method, and try scrolling
1047 instead. (Bug#14780)
1048
198fa217
KB
10492013-07-24 Ken Brown <kbrown@cornell.edu>
1050
1051 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1052 (Bug#14944).
1053
53840e55
PE
10542013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 * eval.c (Fprogn): Do not check that BODY is a proper list.
1057 This undoes the previous change. The check slows down the
1058 interpreter, and is not needed to prevent a crash. See
1059 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1060
60967f56
GM
10612013-07-23 Glenn Morris <rgm@gnu.org>
1062
1063 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1064
9ca960e2
PE
10652013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1066
a29c3e6d
PE
1067 Port to GNU/Linux systems with tinfo but not ncurses.
1068 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1069 to decide whether ncurses is being used. Without this change,
1070 GCC complains about tgetent not being declared, on a system
1071 that has tinfo installed but ncurses not installed.
1072
f274311c
PE
1073 * eval.c (Fprogn): Check that BODY is a proper list.
1074
16b0520a
PE
1075 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1076 * data.c (Fsetq_default):
1077 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1078 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1079 (Fcondition_case):
1080 Tune by taking advantage of the fact that ARGS is always a list
1081 when a function is declared to have UNEVALLED args.
1082
9ca960e2
PE
1083 * emacsgtkfixed.c: Port to GCC 4.6.
1084 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1085
afacaa1b
JB
10862013-07-23 Juanma Barranquero <lekktu@gmail.com>
1087
1088 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1089 here to silence compiler warnings.
1090
368a85a4
PE
10912013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1094 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1095 from messing up Emacs's 'struct frame' (Bug#14923).
1096
f4e891b5
PE
10972013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1098
1099 * alloc.c (make_save_ptr_ptr): Define this function.
1100 It was inadvertently omitted. It's needed only if
1101 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1102
96c8b65e
JD
11032013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1104
1105 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1106 frame have focus (Bug#14895).
1107
ee010797
PE
11082013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 Avoid vfork-related deadlock more cleanly.
1111 * callproc.c (child_setup): When the child's exec fails, output
1112 the program name, as that's more useful. Use O_NONBLOCK to avoid
1113 deadlock.
1114 * process.c (create_process_1): Remove; no longer needed.
1115 (create_process): Remove timer hack; no longer needed, now that
1116 the child avoids deadlock.
1117
f0398ec1 11182013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1119
1120 * image.c (Fimage_flush): Fix doc typo.
1121
b2a069c2
PE
11222013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1123
6496aec9
PE
1124 Fix array bounds violation when pty allocation fails.
1125 * process.c (PTY_NAME_SIZE): New constant.
1126 (pty_name): Remove static variable; it's now auto.
1127 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1128 Take pty_name as an arg rather than using a static variable.
1129 All callers changed.
1130 (create_process): Recover pty_flag from process, not from volatile local.
1131 (create_pty): Stay inside array even when pty allocation fails.
1132 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1133
b2a069c2
PE
1134 * lread.c (Fload): Avoid initialization only when lint checking.
1135 Mention that it's needed only for older GCCs.
1136
99107004
KH
11372013-07-20 Kenichi Handa <handa@gnu.org>
1138
1139 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1140 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1141
6b1b199d
AS
11422013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1143
1144 * lread.c (Fload): Avoid uninitialized warning.
1145
4195afc3
PE
11462013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1147
3f5bef16
PE
1148 Fix some minor file descriptor leaks and related glitches.
1149 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1150 (create_lock_file): Use write, not emacs_write.
1151 * image.c (slurp_file, png_load_body):
1152 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1153 (server_accept_connection):
1154 Don't leak an fd on memory allocation failure.
1155 * image.c (slurp_file): Add a cheap heuristic for growing files.
1156 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1157 as that's what the other routines do. Maybe input need not be
1158 blocked at all, but it's better to be consistent.
1159 Avoid undefined behavior when strlen is zero.
1160
4195afc3
PE
1161 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1162 (NSTATICS): Now a constant; doesn't need to be a macro.
1163
a1aeeffe
RS
11642013-07-19 Richard Stallman <rms@gnu.org>
1165
1166 * coding.c (decode_coding_utf_8): Add simple loop for fast
1167 processing of ASCII characters.
1168
63b34baa
PE
11692013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1172
621dd9ac
EZ
11732013-07-19 Eli Zaretskii <eliz@gnu.org>
1174
1175 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1176 unportable 'struct x_display_info'.
1177 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1178 is a portable type.
1179
1396ac86
PE
11802013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1181
ab9980cd
PE
1182 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1183 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1184 or fscanf fails.
1185 (system_process_attributes): Prefer plain char to unsigned char
1186 when either will do. Clean up properly if interrupted or if
1187 memory allocations fail. Don't assume sscanf succeeds. Remove
1188 no-longer-needed workaround to stop GCC from whining. Read
1189 command-line once, instead of multiple times. Check read status a
1190 bit more carefully.
1191
1396ac86
PE
1192 Fix obscure porting bug with varargs functions.
1193 The code assumed that int is treated like ptrdiff_t in a vararg
1194 function, which is not a portable assumption. There was a similar
1195 -- though these days less likely -- porting problem with various
1196 assumptions that pointers of different types all smell the same as
1197 far as vararg functions is conserved. To make this problem less
1198 likely in the future, redo the API to use varargs functions.
1199 * alloc.c (make_save_value): Remove this vararg function.
1200 All uses changed to ...
1201 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1202 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1203 New functions.
1204 (make_save_ptr): Rename from make_save_pointer, for consistency with
1205 the above. Define only on platforms that need it. All uses changed.
1206
4d19d194
PE
12072013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1208
1209 * keyboard.c: Try to fix typos in previous change.
1210 (DISPLAY_LIST_INFO): New macro.
1211 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1212 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1213
945c5bb1
JB
12142013-07-18 Juanma Barranquero <lekktu@gmail.com>
1215
1216 * keyboard.c (kbd_buffer_get_event):
1217 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1218 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1219
f4b1eb36
PE
12202013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1221
5e679a2c
PE
1222 * filelock.c: Fix unlikely file descriptor leaks.
1223 (get_boot_time_1): Rework to avoid using emacs_open.
1224 This doesn't actually fix a leak, but is better anyway.
1225 (read_lock_data): Use read, not emacs_read.
1226
a8cd4836
PE
1227 * doc.c: Fix minor memory and file descriptor leaks.
1228 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1229 (get_doc_string, Fsnarf_documentation):
1230 Fix file descriptor leak on error.
1231
ef30e638
PE
1232 * term.c: Fix minor fdopen-related file descriptor leaks.
1233 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1234 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1235
f4b1eb36
PE
1236 * charset.c: Fix file descriptor leaks and errno issues.
1237 Include <errno.h>.
1238 (load_charset_map_from_file): Don't leak file descriptor on error.
1239 Use plain record_xmalloc since the allocation is larger than
1240 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1241 of entries.
1242 * eval.c (record_unwind_protect_nothing):
1243 * fileio.c (fclose_unwind):
1244 New functions.
1245 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1246 The replacement doesn't block input, but that no longer seems
1247 necessary.
1248
b648c163
PE
12492013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1250
a0931322
PE
1251 * lread.c: Fix file descriptor leaks and errno issues.
1252 (Fload): Close some races that leaked fds or streams when 'load'
1253 was interrupted.
1254 (Fload, openp): Report error number of last nontrivial failure to open.
1255 ENOENT counts as trivial.
1256 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1257 New functions.
1258 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1259 now that the function is always called with a nonnegative arg.
1260 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1261 All uses replaced with ...
1262 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1263
b648c163
PE
1264 A few more minor file errno-reporting bugs.
1265 * callproc.c (Fcall_process):
1266 * doc.c (Fsnarf_documentation):
1267 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1268 * process.c (set_socket_option):
1269 Don't let a constructor trash errno.
1270 * doc.c: Include <errno.h>.
1271
b1dc4084
JB
12722013-07-16 Juanma Barranquero <lekktu@gmail.com>
1273
1274 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1275
c43843aa
PE
12762013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1277
50a30cce
PE
1278 Fix w32 bug with call-process-region (Bug#14885).
1279 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1280 to Fcall_process when the input is empty. This simplifies the
1281 code a bit. It makes no difference on POSIXish platforms but
1282 apparently it fixes a bug on w32.
1283
44e18199 1284 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1285 * fileio.c (close_file_unwind): Don't close if FD is negative;
1286 this can happen when unwinding a zapped file descriptor.
1287 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1288 in case Emacs runs out of memory between the two unwind-protects.
1289 Don't trash errno when closing FD.
1290 Zap the FD in the specpdl when closing it, instead of deferring
1291 the removal of the unwind-protect; this fixes a bug where a child
1292 function unwinds the stack past us.
1293
27e498e6
PE
1294 New unwind-protect flavors to better type-check C callbacks.
1295 This also lessens the need to write wrappers for callbacks,
1296 and the need for make_save_pointer.
1297 * alloca.c (free_save_value):
1298 * atimer.c (run_all_atimers):
1299 Now extern.
1300 * alloc.c (safe_alloca_unwind):
1301 * atimer.c (unwind_stop_other_atimers):
1302 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1303 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1304 * minibuf.c (choose_minibuf_frame_1):
1305 * process.c (make_serial_process_unwind):
1306 * xdisp.h (pop_message_unwind):
1307 * xselect.c (queue_selection_requests_unwind):
1308 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1309 * alloca.c (record_xmalloc):
1310 Prefer record_unwind_protect_ptr to record_unwind_protect with
1311 make_save_pointer.
1312 * alloca.c (Fgarbage_collect):
1313 Prefer record_unwind_protect_void to passing a dummy.
1314 * buffer.c (restore_buffer):
1315 * window.c (restore_window_configuration):
1316 * xfns.c, w32fns.c (do_unwind_create_frame)
1317 New wrapper. All record-unwind uses of wrappee changed.
1318 * buffer.c (set_buffer_if_live):
1319 * callproc.c (call_process_cleanup, delete_temp_file):
1320 * coding.c (code_conversion_restore):
1321 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1322 * editfns.c (save_excursion_restore)
1323 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1324 (save_restriction_restore):
1325 * eval.c (restore_stack_limits, un_autoload):
1326 * fns.c (require_unwind):
1327 * keyboard.c (recursive_edit_unwind, tracking_off):
1328 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1329 * macros.c (pop_kbd_macro, restore_menu_items):
1330 * nsfns.m (unwind_create_frame):
1331 * print.c (print_unwind):
1332 * process.c (start_process_unwind):
1333 * search.c (unwind_set_match_data):
1334 * window.c (select_window_norecord, select_frame_norecord):
1335 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1336 (fast_set_selected_frame):
1337 * xfns.c, w32fns.c (unwind_create_tip_frame):
1338 Return void, not a dummy Lisp_Object. All uses changed.
1339 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1340 * callproc.c (call_process_kill):
1341 * fileio.c (restore_point_unwind, decide_coding_unwind)
1342 (build_annotations_unwind):
1343 * insdel.c (Fcombine_after_change_execute_1):
1344 * keyboard.c (read_char_help_form_unwind):
1345 * menu.c (unuse_menu_items):
1346 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1347 * sound.c (sound_cleanup):
1348 * xdisp.c (unwind_redisplay):
1349 * xfns.c (clean_up_dialog):
1350 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1351 Accept no args and return void, instead of accepting and returning
1352 a dummy Lisp_Object. All uses changed.
1353 * cygw32.c (fchdir_unwind):
1354 * fileio.c (close_file_unwind):
1355 * keyboard.c (restore_kboard_configuration):
1356 * lread.c (readevalllop_1):
1357 * process.c (wait_reading_process_output_unwind):
1358 Accept int and return void, rather than accepting an Emacs integer
1359 and returning a dummy object. In some cases this fixes an
1360 unlikely bug when the corresponding int is outside Emacs integer
1361 range. All uses changed.
1362 * dired.c (directory_files_internal_unwind):
1363 * fileio.c (do_auto_save_unwind):
1364 * gtkutil.c (pop_down_dialog):
1365 * insdel.c (reset_var_on_error):
1366 * lread.c (load_unwind):
1367 * xfns.c (clean_up_file_dialog):
1368 * xmenu.c, nsmenu.m (pop_down_menu):
1369 * xmenu.c (cleanup_widget_value_tree):
1370 * xselect.c (wait_for_property_change_unwind):
1371 Accept pointer and return void, rather than accepting an Emacs
1372 save value encapsulating the pointer and returning a dummy object.
1373 All uses changed.
1374 * editfns.c (Fformat): Update the saved pointer directly via
1375 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1376 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1377 (unwind_body): New function.
1378 (record_unwind_protect): First arg is now a function returning void,
1379 not a dummy Lisp_Object.
1380 (record_unwind_protect_ptr, record_unwind_protect_int)
1381 (record_unwind_protect_void): New functions.
1382 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1383 * fileio.c (struct auto_save_unwind): New type.
1384 (do_auto_save_unwind): Use it.
1385 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1386 * insdel.c (struct rvoe_arg): New type.
1387 (reset_var_on_error): Use it.
1388 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1389 New constants.
1390 (specbinding_func): Remove; there are now several such functions.
1391 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1392 (set_unwind_protect_ptr): New function.
1393 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1394
4e604a5d
PE
1395 Be simpler and more consistent about reporting I/O errors.
1396 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1397 Say "Read error" and "Write error", rather than "I/O error", or
1398 "IO error reading", or "IO error writing", when a read or write
1399 error occurs.
1400 * process.c (Fmake_network_process, wait_reading_process_output)
1401 (send_process, Fprocess_send_eof, wait_reading_process_output):
1402 Capitalize diagnostics consistently. Put "failed foo" at the
1403 start of the diagnostic, so that we don't capitalize the
1404 function name "foo". Consistently say "failed" for such
1405 diagnostics.
1406 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1407 All callers changed. This is so it can use report_file_error.
1408 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1409 diagnostics consistently as above.
1410
a9757f6a
PE
1411 * fileio.c (report_file_errno): Fix errno reporting bug.
1412 If the file name is neither null nor a pair, package it up as a
1413 singleton list. All callers changed, both to this function and to
1414 report_file_error. This fixes a bug where the memory allocator
1415 invoked by list1 set errno so that the immediately following
1416 report_file_error reported the wrong errno value.
1417
c43843aa
PE
1418 Fix minor problems found by --enable-gcc-warnings.
1419 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1420 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1421
18c26d81
JD
14222013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1423
1424 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1425 Set event->arg to Qt if switch-event shall be generated.
1426 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1427
1428 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1429
1430 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1431 FOCUS_OUT_EVENT.
1432
1433 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1434 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1435 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1436 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1437 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1438 and there is a focused frame.
1439 (head_table): Add focus-in and focus-out.
1440 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1441 bind to handle-focus-in/out.
1442
1443 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1444 (Fhandle_switch_frame): Call Fhandle_focus_in.
1445 (syms_of_frame): defsubr handle-focus-in/out.
1446
6c6f1994
PE
14472013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1448
c7ddc792
PE
1449 Fix porting bug to older POSIXish platforms (Bug#14862).
1450 * sysdep.c (emacs_pipe): New function, that implements
1451 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1452 This should port better to CentOS 5 and to Mac OS X 10.6.
1453 All calls to pipe2 changed.
1454
6c6f1994
PE
1455 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1456 This makes the code easier to read and the executable a bit smaller.
1457 Do not replace all calls to Fcons that happen to create lists,
1458 just calls that are intended to create lists. For example, when
1459 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1460 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1461 Similarly for list2 through list5.
1462 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1463 * bytecode.c (exec_byte_code):
1464 * callint.c (quotify_arg, Fcall_interactively):
1465 * callproc.c (Fcall_process, create_temp_file):
1466 * charset.c (load_charset_map_from_file)
1467 (Fdefine_charset_internal, init_charset):
1468 * coding.c (get_translation_table, detect_coding_system)
1469 (Fcheck_coding_systems_region)
1470 (Fset_terminal_coding_system_internal)
1471 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1472 * composite.c (update_compositions, Ffind_composition_internal):
1473 * dired.c (directory_files_internal, file_name_completion)
1474 (Fsystem_users):
1475 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1476 * doc.c (Fsnarf_documentation):
1477 * editfns.c (Fmessage_box):
1478 * emacs.c (main):
1479 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1480 (Feval, eval_sub, Ffuncall, apply_lambda):
1481 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1482 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1483 (Fset_file_times, Finsert_file_contents)
1484 (Fchoose_write_coding_system, Fwrite_region):
1485 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1486 * font.c (font_registry_charsets, font_parse_fcname)
1487 (font_prepare_cache, font_update_drivers, Flist_fonts):
1488 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1489 * frame.c (make_frame, Fmake_terminal_frame)
1490 (x_set_frame_parameters, x_report_frame_params)
1491 (x_default_parameter, Fx_parse_geometry):
1492 * ftfont.c (syms_of_ftfont):
1493 * image.c (gif_load):
1494 * keyboard.c (command_loop_1):
1495 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1496 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1497 (Fminor_mode_key_binding, accessible_keymaps_1)
1498 (Faccessible_keymaps, Fwhere_is_internal):
1499 * lread.c (read_emacs_mule_char):
1500 * menu.c (find_and_return_menu_selection):
1501 * minibuf.c (get_minibuffer):
1502 * nsfns.m (Fns_perform_service):
1503 * nsfont.m (ns_script_to_charset):
1504 * nsmenu.m (ns_popup_dialog):
1505 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1506 (Fx_own_selection_internal):
1507 * nsterm.m (append2):
1508 * print.c (Fredirect_debugging_output)
1509 (print_prune_string_charset):
1510 * process.c (Fdelete_process, Fprocess_contact)
1511 (Fformat_network_address, set_socket_option)
1512 (read_and_dispose_of_process_output, write_queue_push)
1513 (send_process, exec_sentinel):
1514 * sound.c (Fplay_sound_internal):
1515 * textprop.c (validate_plist, add_properties)
1516 (Fput_text_property, Fadd_face_text_property)
1517 (copy_text_properties, text_property_list, syms_of_textprop):
1518 * unexaix.c (report_error):
1519 * unexcoff.c (report_error):
1520 * unexsol.c (unexec):
1521 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1522 (Fformat_mode_line, syms_of_xdisp):
1523 * xfaces.c (set_font_frame_param)
1524 (Finternal_lisp_face_attribute_values)
1525 (Finternal_merge_in_global_face, syms_of_xfaces):
1526 * xfns.c (x_default_scroll_bar_color_parameter)
1527 (x_default_font_parameter, x_create_tip_frame):
1528 * xfont.c (xfont_supported_scripts):
1529 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1530 (menu_help_callback, xmenu_show):
1531 * xml.c (make_dom):
1532 * xterm.c (set_wm_state):
1533 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1534 and similarly for list2 through list5.
1535
bafe80ce
PE
15362013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1537
1538 * callproc.c (Fcall_process_region): Fix minor race and tune.
1539 (create_temp_file): New function, with the temp-file-creation part
1540 of the old Fcall_process_region. Use Fcopy_sequence to create the
1541 temp file name, rather than alloca + build_string, for simplicity.
1542 Don't bother to block input around the temp file creation;
1543 shouldn't be needed. Simplify use of mktemp. Use
1544 record_unwind_protect immediately after creating the temp file;
1545 this closes an unlikely race where the temp file was not removed.
1546 Use memcpy rather than an open-coded loop.
1547 (Fcall_process_region): Use the new function. If the input is
1548 empty, redirect from /dev/null rather than from a newly created
1549 empty temp file; this avoids unnecessary file system traffic.
1550
4700b5a5
PE
15512013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1552
5c97beae
PE
1553 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1554 Simplify by making this case like the other two. This is a bit
1555 slower on obsolete hosts, but the extra complexity isn't worth it.
1556
4700b5a5
PE
1557 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1558 * process.c (create_process) [!DOS_NT]:
1559 Remove now-unnecessary calls to emacs_close.
1560
f9a74c4c
EZ
15612013-07-13 Eli Zaretskii <eliz@gnu.org>
1562
922ae7ee
EZ
1563 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1564 returning early. (Bug#14850)
1565
f9a74c4c
EZ
1566 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1567 and inhibit-iso-escape-detection attributes of 'undecided'.
1568 (Bug#14822)
1569
5e301d76
PE
15702013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1571
69e0e5ee
PE
1572 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1573 Reported by Herbert J. Skuhra in
1574 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1575
5e301d76
PE
1576 Don't lose top specpdl entry when memory is exhausted.
1577 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1578 specpdl overflow here, to simplify callers; all callers changed.
1579 Always reserve an unused entry at the stack top; this avoids
1580 losing the top entry's information when memory is exhausted.
1581
7e649856
PE
15822013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1583
a773ed9a
PE
1584 Clean up errno reporting and fix some errno-reporting bugs.
1585 * callproc.c (Fcall_process):
1586 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1587 * process.c (create_process, Fmake_network_process):
1588 * unexaix.c (report_error):
1589 * unexcoff.c (report_error):
1590 Be more careful about reporting the errno of failed operations.
1591 The code previously reported the wrong errno sometimes.
1592 Also, prefer report_file_errno to setting errno + report_file_error.
1593 (Fcall_process): Look at openp return value rather than at path,
1594 as that's a bit faster and clearer when there's a numeric predicate.
1595 * fileio.c (report_file_errno): New function, with most of the
1596 old contents of report_file_error.
1597 (report_file_error): Use it.
1598 (Ffile_exists_p, Ffile_accessible_directory_p):
1599 Set errno to 0 when it is junk.
1600 * fileio.c (Faccess_file):
1601 * image.c (x_create_bitmap_from_file):
1602 Use faccessat rather than opening the file, to avoid the hassle of
1603 having a file descriptor open.
1604 * lisp.h (report_file_errno): New decl.
1605 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1606
7e649856
PE
1607 Minor EBADF fixes.
1608 * process.c (create_process, wait_reading_process_output) [AIX]:
1609 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1610 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1611 a multithreaded environment anyway).
1612 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1613
f6774c1a
AS
16142013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1615
1616 * image.c (x_find_image_file): Don't close a remote file handle.
1617
bacba3c2
PE
16182013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Fix races with threads and file descriptors.
1621 * callproc.c (Fcall_process_region):
1622 * dired.c (open_directory):
1623 * emacs.c (main, Fdaemon_initialized):
1624 * image.c (x_find_image_file):
1625 * inotify.c (Finotify_rm_watch):
1626 * lread.c (Flocate_file_internal):
1627 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1628 * term.c (term_mouse_moveto, init_tty):
1629 * termcap.c (tgetent):
1630 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1631 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1632 * unexhp9k800.c, unexmacosx.c (unexec):
1633 * callproc.c (Fcall_process_region):
1634 Use emacs_close, not close.
1635 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1636 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1637 and posix_close function on current platforms (which all lack them).
1638 (emacs_close): Use it. This should fix the races on GNU/Linux and
1639 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1640 and it should avoid closing random victim file descriptors on
1641 other platforms.
1642
653d4f43
PE
16432013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1644
c8536ec4
PE
1645 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1646 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1647 Touch up doc a bit.
1648
9c203066
PE
1649 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1650 This is for .gdbinit xbacktrace.
1651
653d4f43
PE
1652 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1653 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1654 (emacs_set_tty): Now static.
1655 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1656 * term.c (tty_capable_p, tty_default_color_capabilities)
1657 (get_tty_terminal, term_mouse_movement)
1658 (handle_one_term_event, init_tty, maybe_fatal):
1659 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1660 (tgetent, scan_file, name_match, compare_contin):
1661 * terminal.c (get_terminal):
1662 Use bool for boolean.
1663 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1664 Prefer char to unsigned char if either will do.
1665 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1666 (tty_write_glyphs): Prefer int to unsigned.
1667 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1668 All callers changed.
1669 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1670
45b683a1
PE
16712013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1672
29abe551
PE
1673 Port to C89.
1674 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1675 (B__dummy__): New dummy symbol, to pacify C89.
1676 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1677 they can't grok varargs macros.
1678 * dispnew.c (add_window_display_history)
1679 (add_frame_display_history):
1680 * print.c (print_object):
1681 * xdisp.c (debug_method_add):
1682 Use %p printf format only for void pointers.
1683 * emacs.c (usage_message): New constant, replacing ...
1684 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1685 (main): Adjust to usage reorg.
1686 * fns.c (syms_of_fns):
1687 * profiler.c (syms_of_profiler):
1688 Don't use non-constant struct initializers.
1689 * gnutls.h (gnutls_initstage_t):
1690 * lisp.h (enum Lisp_Fwd_Type):
1691 * lread.c (lisp_file_lexically_bound_p):
1692 * xsettings.c (anonymous enum):
1693 Remove trailing comma.
1694 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1695 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1696 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1697 (DEFUN): Use it.
1698 * regex.c (const_re_char): New type, to pacify strict C89.
1699 All uses of 'const re_char' replaced to use it.
1700 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1701 with glibc when strict C89. This change is imported from gnulib.
1702 All uses changed.
1703 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1704 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1705 Omit GNU_LINUX implementation, since it requires long long.
1706 * xterm.c (x_draw_underwave):
1707 Do not assume the traditional order of struct's members.
1708 (x_term_init): Rewrite to avoid the need for non-constant structure
1709 initializers.
1710
45b683a1 1711 Syntax cleanup, mostly replacing macros with functions.
763a086d 1712 This removes the need for the syntax_temp hack.
45b683a1
PE
1713 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1714 * syntax.c (SYNTAX_INLINE): New macro.
1715 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1716 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1717 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1718 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1719 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1720 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1721 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1722 Now constants, not macros.
1723 (syntax_temp) [!__GNUC__]: Remove.
1724 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1725 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1726 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1727 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1728 Move here from syntax.h; now functions, not macros. Except for the
1729 last function, these are static since only syntax.c uses them.
1730 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1731 All uses changed. Now a function, not a macro; use this fact
1732 to simplify the code.
1733 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1734 compiler bugs; no longer relevant.
1735 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1736 (SYNTAX_INLINE): New macro.
1737 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1738 for the new functions. Use bool for boolean member.
1739 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1740 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1741 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1742 (SETUP_BUFFER_SYNTAX_TABLE):
1743 Now extern inline functions, not macros.
1744 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1745 Remove; all uses replaced by implementation.
1746 (syntax_temp) [!__GNUC__]: Remove decl.
1747 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1748
29be4a50
JD
17492013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1750
1751 * emacs.c (main): Fix syntax error.
1752
954b166e
PE
17532013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 Timestamp fixes for undo (Bug#14824).
1756 * atimer.c (schedule_atimer):
1757 * fileio.c (Ffile_newer_than_file_p):
1758 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1759 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1760 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1761 (syms_of_fileio): Remove Sclear_visited_file_name.
1762 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1763 file doesn't exist; this avoids an ambiguity with negative timestamps.
1764 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1765 * systime.h (make_emacs_time, invalid_emacs_time):
1766 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1767 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1768 * undo.c (record_first_change): Push (visited-file-modtime) onto
1769 undo list rather than reimplementing it by hand, incorrectly.
1770
d74647c3
KB
17712013-07-09 Ken Brown <kbrown@cornell.edu>
1772
1773 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1774
3c51b96b
JB
17752013-07-09 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1778
4ebbdd67
PE
17792013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 Handle errno and exit status a bit more carefully.
1782 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1783 number into an exit status. Instead, use EXIT_CANCELED.
1784 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1785 * callproc.c (relocate_fd):
1786 * emacs.c (close_output_streams, main):
1787 * process.c (create_process):
1788 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1789 Use emacs_perror for simplicity.
1790 * callproc.c (relocate_fd, main):
1791 * sysdep.c (sys_subshell):
1792 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1793 (shut_down_emacs): Use emacs_write, not write.
1794 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1795 * fileio.c (Fcopy_file, e_write):
1796 * nsterm.m (ns_select):
1797 * process.c (send_process):
1798 * sound.c (vox_write):
1799 Use emacs_write_sig, not emacs_write.
1800 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1801 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1802 New constants.
1803 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1804 of write.
1805 (emacs_full_write): New function.
1806 (emacs_write): Rewrite to use it.
1807 (emacswrite_sig, emacs_perror): New functions.
1808 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1809
44e18199 18102013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1811
1812 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1813 on NS even if it is present. Pixmap on NS is a void*.
1814
9caab067
PE
18152013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 Port to Ubuntu 10 (Bug#14803).
1818 Problem reported by T.V. Raman.
1819 * process.c (close_on_exec, accept4, process_socket):
1820 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1821
1d442672
EZ
18222013-07-07 Eli Zaretskii <eliz@gnu.org>
1823
1824 * w32.c (sys_dup): Declare prototype.
1825
1826 * filelock.c:
1827 * emacs.c:
1828 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1829
067428c1
PE
18302013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1831
1832 Make file descriptors close-on-exec when possible (Bug#14803).
1833 This simplifies Emacs a bit, since it no longer needs to worry
1834 about closing file descriptors by hand in some cases.
1835 It also fixes some unlikely races. Not all such races, as
1836 libraries often open files internally without setting
1837 close-on-exec, but it's an improvement.
1838 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1839 * callproc.c (Fcall_process) [!MSDOS]:
1840 * emacs.c (main) [!DOS_NT]:
1841 * nsterm.m (ns_term_init):
1842 * process.c (create_process):
1843 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1844 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1845 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1846 Prefer mkostemp with O_CLOEXEC to mkstemp.
1847 * callproc.c (relocate_fd) [!WINDOWSNT]:
1848 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1849 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1850 now using pipe2.
1851 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1852 Make the resulting file descriptor close-on-exec.
1853 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1854 * lread.c (load_descriptor_list, load_descriptor_unwind):
1855 Remove; no longer needed. All uses removed.
1856 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1857 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1858 New functions.
1859 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1860 (Fmake_network_process, Fnetwork_interface_list):
1861 (Fnetwork_interface_info, server_accept_connection):
1862 Make newly-created socket close-on-exec.
1863 * sysdep.c (emacs_open, emacs_fopen):
1864 Make new-created descriptor close-on-exec.
1865 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1866 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1867
0da857dd
JD
18682013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1869
1870 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1871 for NS_IMPL_GNUSTEP.
1872
5f86adcd
PE
18732013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 Fix openp errno handling.
1876 * callproc.c (Fcall_process): Preserve openp errno around close.
1877 * lread.c (openp): Set errno when returning -1, as some callers
1878 expect this.
1879
1afb1d07
JD
18802013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1881
1882 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1883
1884 * nsterm.h (NSSavePanel): Update comment.
1885 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1886 (ns_run_file_dialog): Declare.
1887
1888 * nsfns.m: Remove panelOK.
1889 (ns_fd_data): New.
1890 (ns_run_file_dialog): New function.
1891 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1892 event loop, so file dialog is popped up by ns_run_file_dialog, called
1893 by sendEvent (Bug#14578).
1894 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1895
3323c263
EZ
18962013-07-06 Eli Zaretskii <eliz@gnu.org>
1897
fdda0220
EZ
1898 * xdisp.c (default_line_pixel_height): New function.
1899 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1900 (try_cursor_movement, redisplay_window, try_window)
1901 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1902
1903 * window.c (window_scroll_pixel_based): use
1904 default_line_pixel_height.
1905
1906 * dispextern.h (default_line_pixel_height): Add prototype.
1907
1908 * frame.c (x_set_line_spacing): Accept a float value for
1909 line-spacing parameter, per the documentation.
1910
3323c263
EZ
1911 * data.c (Fmultibyte_string_p): Doc fix.
1912
47ba6d43
PE
19132013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1914
406af475
PE
1915 Use emacs_open more consistently when opening files.
1916 This handles EINTR more consistently now, and makes it easier
1917 to introduce other uniform changes to file descriptor handling.
1918 * src/systdio.h: New file.
1919 * src/buffer.c (mmap_init):
1920 * cygw32.c (chdir_to_default_directory):
1921 * dispnew.c (Fopen_termscript):
1922 * emacs.c (Fdaemon_initialized):
1923 * fileio.c (Fdo_auto_save):
1924 * image.c (slurp_file, png_load_body, jpeg_load_body):
1925 * keyboard.c (Fopen_dribble_file):
1926 * lread.c (Fload):
1927 * print.c (Fredirect_debugging_output):
1928 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1929 * termcap.c (tgetent):
1930 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1931 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1932 * w32term.c (w32_initialize) [CYGWIN]:
1933 * xfaces.c (Fx_load_color_file):
1934 Use emacs_open instead of plain open, and emacs_fopen instead of
1935 plain fopen.
1936 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1937 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1938 * callproc.c (default_output_mode): New constant.
1939 (Fcall_process): Use it to call emacs_open instead of plain creat.
1940 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1941 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1942 (emacs_fopen): New function.
1943 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1944 Include <lisp.h>, for emacs_open.
1945 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1946
47ba6d43
PE
1947 Remove duplicate #include directives.
1948 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1949 * xfaces.c:
1950 Don't include stdio.h twice.
1951 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1952 Don't include sys/types.h or stdio.h twice.
1953 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1954 * lread.c: Don't include coding.h twice.
1955 * nsfont.m: Don't include frame.h twice.
1956 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1957 * ralloc.c: Don't include <unistd.h> twice.
1958 * xdisp.c: Don't include font.h twice.
1959 * xterm.c: Don't include fontset.h twice.
1960 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1961
b9ed53d5
PE
19622013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 Scale ImageMagick images more carefully.
1965 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1966 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1967 Be more careful about avoiding undefined behavior after
1968 integer overflow and division by zero.
1969
cf13177e
YM
19702013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1971
1972 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1973 (syms_of_w32fns): DEFSYM them.
1974 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1975 (CCHDEVICENAME): Define macros if not defined.
1976 (struct MONITOR_INFO_EX): New struct.
1977 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1978 (enum_display_monitors_fn): New variable.
1979 (globals_of_w32fns): Initialize it.
1980 (Fx_display_pixel_width, Fx_display_pixel_height)
1981 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1982 multi-monitor setups in docstrings.
1983 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1984 screen size by primary monitor's millimeter per pixel.
1985 (w32_monitor_enum, w32_display_monitor_attributes_list)
1986 (w32_display_monitor_attributes_list_fallback)
1987 (Fw32_display_monitor_attributes_list): New functions.
1988 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1989
1990 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1991 if not defined.
1992 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1993
86dfb7a8
MA
19942013-07-04 Michael Albinus <michael.albinus@gmx.de>
1995
1996 * fileio.c (Qfile_notify_error): New error symbol.
1997
1998 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1999 * inotify.c (inotify_callback, symbol_to_inotifymask)
2000 (Finotify_add_watch, Finotify_rm_watch): Use it.
2001 (inotifyevent_to_event): Exchange order of cookie and file name.
2002 (Finotify_add_watch): Adapt docstring.
2003
2004 * lisp.h (Qfile_notify_error): Declare.
2005
2c1c974b
PE
20062013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2007
2008 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2009 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2010 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2011 which did not work (see <http://bugs.gnu.org/14569#307>).
2012 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2013 && (!noninteractive || initialized)). This attempts to thread
2014 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2015
7a35b20f
JB
20162013-07-04 Juanma Barranquero <lekktu@gmail.com>
2017
2018 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2019 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2020
1ce5cd04
PE
20212013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2024 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2025 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2026 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2027
57f8c490
PE
20282013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2031 Define to __sys_siglist.
2032
bcffb5ca
EZ
20332013-07-02 Eli Zaretskii <eliz@gnu.org>
2034
2035 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2036 word-wrap, so that overflow-newline-into-fringe would work in
2037 visual-line-mode. (Bug#2749)
2038 (move_it_in_display_line_to): When the last scanned display
2039 element fits exactly on the display line, and
2040 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2041 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2042 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2043 finding buffer position that corresponds to pixel coordinates,
2044 e.g. in buffer_posn_from_coords.
2045
2c41e781
JD
20462013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2047
2048 * process.c (handle_child_signal): Call catch_child_signal if
2049 NS_IMPL_GNUSTEP.
2050
c2418359
PE
20512013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2052
52a9bcae
PE
2053 Don't convert function pointers to void * and back.
2054 It isn't portable C, and it's easy enough to avoid.
2055 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2056 (make_save_value): Add support for SAVE_FUNCPOINTER.
2057 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2058 * print.c (print_object):
2059 Distinguish function from object pointers.
2060 * lisp.h (SAVE_FUNCPOINTER): New constant.
2061 (SAVE_SLOT_BITS): Adjust to it.
2062 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2063 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2064 (voidfuncptr): New typedef.
2065 (struct Lisp_Save_Value): New member data[0].funcpointer.
2066 (XSAVE_FUNCPOINTER): New function.
2067
c2418359
PE
2068 Simplify buildobj processing.
2069 * Makefile.in (buildobj.h): Make it a sequence of strings each
2070 followed by comma, rather than a single string. Put it into a
2071 .tmp file in case there's an error while generating it.
2072 (gl-stamp): Use .tmp for temp files.
2073 (mostlyclean): Clean .tmp files.
2074 * doc.c (buildobj): Move to just the routine that needs it.
2075 It's now an array of strings, so processing is simpler.
2076
8f43ce49
PE
20772013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2078
2079 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2080 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2081 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2082 Invoke malloc_enable_thread even when not interactive.
2083 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2084 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2085 in this case, since the underlying bug has now been fixed.
2086
24827db9
JB
20872013-07-01 Juanma Barranquero <lekktu@gmail.com>
2088
2089 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2090 unlinking it (bug#14691).
2091
ef099a94
MN
20922013-06-30 Michal Nazarewicz <mina86@mina86.com>
2093
2094 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2095 before checking whether buffer is modified. This lets
2096 `kill-buffer-query-functions' cancel killing of the buffer or save
2097 its content before `kill-buffer' asks user the "Buffer %s
2098 modified; kill anyway?" question.
2099
9d3f2fc2
JD
21002013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2101
2102 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2103 Let the super performKeyEquivalent deal with them (Bug#14747).
2104
e6c6c8c7
PE
21052013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2106
1d71c1d9
PE
2107 * widget.c (resize_cb): Remove unused local.
2108
8f5f35cc
PE
2109 Do not use GTK 3 if it exists but cannot be compiled.
2110 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2111 * xterm.c (x_error_handler) [!USE_GTK]:
2112 Do not use GTK 3.
2113
e6c6c8c7
PE
2114 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2115
0ba54312
EZ
21162013-06-30 Eli Zaretskii <eliz@gnu.org>
2117
5d1c3286
EZ
2118 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2119 to the valid range of values. (Bug#14753)
2120
0ba54312
EZ
2121 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2122 when moving point by using the current glyph matrix. This avoids
2123 the need to force redisplay when this function is called in a
2124 loop.
2125
9c90cc06
PE
21262013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 Fix minor problems found by static checking.
2129 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2130 Redo the latter's body to sidestep GCC parenthesization warnings.
2131 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2132 * coding.c (detect_coding, detect_coding_system):
2133 * coding.h (struct undecided_spec):
2134 Use bool for boolean.
2135 * image.c (QCmax_width, QCmax_height): Now static.
2136 * xdisp.c (Fmove_point_visually): Remove unused local.
2137
4c672a0f
EZ
21382013-06-29 Eli Zaretskii <eliz@gnu.org>
2139
2140 * xdisp.c (Fmove_point_visually): New function.
2141
c1ea3abf
JB
21422013-06-28 Kenichi Handa <handa@gnu.org>
2143
2144 * coding.h (define_coding_undecided_arg_index): New enum.
2145 (coding_attr_index): New members
2146 coding_attr_undecided_inhibit_null_byte_detection,
2147 coding_attr_undecided_inhibit_iso_escape_detection,
2148 coding_attr_undecided_prefer_utf_8.
2149 (undecided_spec): New struct.
2150 (struct coding_system): New member `undecided' of the member
2151 `spec'.
2152
2153 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2154 (detect_coding): Likewise.
2155 (detect_coding_system): Likewise.
2156 (Fdefine_coding_system_internal): New coding system properties
2157 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2158 :prefer-utf-8.
2159 (syms_of_coding): Adjust for coding_arg_undecided_max.
2160
ba3de9e6
PE
21612013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * image.c (x_from_xcolors): Remove unused local.
2164
547c9269
YM
21652013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2166
2167 Defer image data transfer between X client and server until actual
2168 display happens.
2169
2170 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2171 and `mask_img'.
2172
2173 * image.c (Destroy_Image): Remove.
2174 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2175 `mask_p', and `colors_p'. All uses changed.
2176 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2177 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2178 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2179 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2180 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2181 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2182 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2183 (image_get_x_image, image_unget_x_image): New functions or macros.
2184 (image_background, image_background_transparent, x_to_xcolors)
2185 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2186 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2187 instead of Destroy_Image.
2188 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2189 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2190 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2191 (imagemagick_load_image, svg_load_image): Use them instead of
2192 x_create_x_image_and_pixmap, and x_put_x_image followed by
2193 x_destroy_x_image, respectively.
2194 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2195 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2196 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2197 background_transparent fields.
2198 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2199 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2200
dae2f5ef
PE
22012013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2202
2203 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2204 This mostly consists of undoing recent changes.
2205 * callproc.c (Fcall_process):
2206 * process.c (create_process):
2207 Do not worry about catching SIGCHLD here, undoing previous change.
2208 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2209 * process.c, process.h (catch_child_signal):
2210 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2211 * process.c (catch_child_handler): Don't worry about being called
2212 lazily and do not assume caller has blocked SIGCHLD, undoing
2213 previous change. Move first-time stuff back to
2214 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2215 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2216 set lib_child_handler if it's already initialized, which may
2217 help avoid problems on GNUStep.
2218
fa55d2aa
PE
22192013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2222 * callproc.c (Fcall_process):
2223 * process.c (create_process):
2224 Make sure SIGCHLD is caught before we fork,
2225 since Emacs startup no arranges to catch SIGCHLD.
2226 * process.c (lib_child_handler): Initialize to null, not to
2227 dummy_handler.
2228 (catch_child_signal): Allow self to be called lazily.
2229 Do nothing if it's already been called.
2230 Assume caller has blocked SIGCHLD (all callers do now).
2231 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2232 just before it's really needed.
2233 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2234 since it hasn't been caught yet.
2235
f3f9606c
LMI
22362013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2237
2238 * image.c (compute_image_size): New function to implement
2239 :max-width and :max-height.
2240 (imagemagick_load_image): Use it.
2241
c7041908
PE
22422013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2243
2244 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2245 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2246 Now extern.
2247 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2248 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2249 the SIGCHLD handler, since the code is not atomic and (due to glib)
2250 signals may be arriving now.
2251 * sysdep.c (init_signals): Do not catch child signals here;
2252 'main' now does that later, at a safer time.
2253
f86852b4
PE
22542013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2255
0dfeed58
PE
2256 Clean up SIGCHLD handling a bit (Bug#14569).
2257 * process.c, process.h (catch_child_signal):
2258 Now always extern, even if !NS_IMPL_GNUSTEP.
2259 * process.c (catch_child_signal): Move glib tickler here from
2260 init_process_emacs, so that it's done earlier in Emacs
2261 initialization. Also move the noninteractive && !initialized
2262 check here from init_process_emacs. This is all a bit cleaner for
2263 GNUish platforms, and I hope it works around the Cygwin bug.
2264 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2265 that glib signal handling is tickled before glib creates threads.
2266
f86852b4
PE
2267 * process.c (wait_reading_process_output): Avoid int overflow
2268 when reading more than 2 GiB total from a process.
2269
cbd6509c
PE
22702013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2271
2272 * process.c (create_process): Handle a couple more cases,
2273 i.e., work even if new_argv and wait_child_setup[i] are cached.
2274 Use Fcall_process's style for volatile vars.
2275
9de1114a
AS
22762013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2277
2278 * process.c (create_process): Mark PROCESS volatile.
2279
fbe9e0b9
PE
22802013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2281
2282 Use C99-style flexible array members if available.
2283 This avoids some subtle aliasing issues, which typically
2284 aren't a problem with GCC but may be a problem elsewhere.
2285 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2286 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2287 In either case, it uses a flexible array member rather than
2288 the old struct hack. All uses changed.
2289 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2290 Adjust to sdata reorganization.
2291 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2292 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2293 that ports better to pre-C99 non-GCC.
2294 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2295 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2296 as the latter has changed.
2297 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2298 and port better to pre-C99 GCC.
2299 * image.c (struct xpm_cached_color):
2300 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2301 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2302 Use FLEXIBLE_ARRAY_MEMBER.
2303 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2304 Move decl to top level so it gets checked against implementation.
2305 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2306 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2307
1fc71008
PE
23082013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2309
2310 * syntax.c: Integer cleanups.
2311 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2312 All uses that need 0-or-2 changed to:
2313 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2314 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2315 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2316 (char_quoted, prev_char_comend_first, back_comment)
2317 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2318 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2319 Use bool for boolean.
2320 (update_syntax_table, skip_chars, skip_syntaxes):
2321 Prefer int to unsigned when either will do.
2322 (back_comment): Return boolean success flag, like forw_comment,
2323 instead of positive-or-minus-1 (which might have overflowed int anyway).
2324 Don't stuff ptrdiff_t into int.
2325 (syntax_spec_code, syntax_code_spec): Now const.
2326 (Fmatching_paren, scan_lists, scan_sexps_forward):
2327 Use enum syntaxcode for syntax code.
2328 (Fmatching_paren): Check that arg is a character, not just an integer.
2329 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2330 (Finternal_describe_syntax_value): Omit no-longer-needed
2331 comparison to 0.
2332 (skip_chars): Use char, not unsigned char, when the distinction
2333 doesn't matter.
2334 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2335 * bytecode.c (exec_byte_code):
2336 * syntax.c (syntax_spec_code, Fchar_syntax)
2337 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2338 (init_syntax_once):
2339 * syntax.h (SYNTAX_WITH_FLAGS):
2340 Omit unnecessary casts.
2341
b932cad7
EZ
23422013-06-20 Eli Zaretskii <eliz@gnu.org>
2343
2344 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2345 line dimensions here, to avoid race conditions with the main
2346 thread. (Bug#14062, bug#14630, bug#14669)
2347
2348 * w32term.c (w32_draw_window_cursor): Compute the header line and
2349 mode line dimensions here.
2350 <w32_system_caret_window, w32_system_caret_hdr_height>:
2351 <w32_system_caret_mode_height>: New variables.
2352
2353 * w32term.h: Declare them.
2354
89561f72
PE
23552013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2356
5013fc08
PE
2357 * alloc.c (die): Move "assertion failed" string here ...
2358 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2359 COND when SUPPRESS_CHECKING. This shrinks the executable text
2360 size by 0.8% to 2.2% when configured with --enable-checking,
2361 depending on optimization flags (GCC 4.8.1 x86-64).
2362
89561f72
PE
2363 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2364
763a086d 23652013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2366
2367 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2368 base is 2; this is more accurate.
2369
983aeb9a
JB
23702013-06-19 Juanma Barranquero <lekktu@gmail.com>
2371
2372 * sound.c (string_default): Move to !WINDOWSNT section.
2373 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2374
178ba3e6
PE
23752013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2376
bbc51b15
PE
2377 * sound.c: Integer cleanups.
2378 Remove unnecessary forward decls.
2379 (struct sound_device): The 'file' member is now a Lisp_Object, not
2380 a char *, so that we needn't invoke alloca on a huge size.
2381 (Fplay_sound_internal): Adjust to this.
2382 (string_default): New function.
2383 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2384 Use it to adjust to the struct sound_device change.
2385 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2386 (be2hs) [0]: Remove.
2387
178ba3e6
PE
2388 * syntax.c (skip_chars): Don't use uninitialized storage
2389 when searching a multibyte buffer for characters that are not in a
2390 unibyte string that contains non-ASCII characters.
2391
69f60cdc
JD
23922013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2393
2394 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2395 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2396
0d6224d4
PE
23972013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2398
2399 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2400
3c542890
KH
24012013-06-18 Kenichi Handa <handa@gnu.org>
2402
f7e3f7cd
KH
2403 * font.c (Ffont_spec): Signal an error for an invalid font name
2404 (Bug#14648).
3c542890 2405
9349e5f7
PE
24062013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2407
2408 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2409 In particular this ports to 32-bit sparc Sun cc.
2410 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2411 array with a dummy element at specpdl[-1], so that its address can
2412 be taken portably.
2413 (unbind_to): Do not copy the binding; not needed, now that we
2414 copy old_value in the one place where the copy is needed.
2415 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2416 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2417 (union specbinding): Rename from struct specbinding. Redo layout
2418 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2419 which is not portable. With Sun C 5.12 32-bit sparc, the
2420 declaration causes nargs to be an unsigned bitfield, a behavior
2421 that the C standard allows; but Emacs wants nargs to be signed.
2422 The overall type is now a union of structures rather than a
2423 structure of union of structures, and the 'kind' member is now a
2424 bitfield, so that the overall type doesn't grow. All uses changed.
2425 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2426
0a4df6a5
PE
24272013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2428
ec6ecaad
PE
2429 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2430 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2431
0a4df6a5
PE
2432 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2433
7bfe8dbc
EZ
24342013-06-17 Eli Zaretskii <eliz@gnu.org>
2435
2436 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2437 unless we know that the window w's frame is a frame object.
2438 Another attempt at solving bug#14062 and bug#14630.
2439
708e05f6
LMI
24402013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2441
2442 * textprop.c (property_set_type): New enum.
2443 (add_properties): Allow appending/prepending text properties.
2444 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2445 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2446 add_text_properties_1.
2447 (Fadd_face_text_property): New function that calls
2448 add_text_properties_1.
2449
84575e67
PE
24502013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 Move functions from lisp.h to individual modules when possible.
2453 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2454 * alloc.c (XFLOAT_INIT, set_symbol_name):
2455 * buffer.c (CHECK_OVERLAY):
2456 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2457 (set_char_table_parent):
2458 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2459 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2460 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2461 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2462 (set_blv_valcell):
2463 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2464 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2465 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2466 (backtrace_args, backtrace_debug_on_exit):
2467 * floatfns.c (CHECK_FLOAT):
2468 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2469 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2470 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2471 (set_hash_index_slot):
2472 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2473 * marker.c (CHECK_MARKER):
2474 * textprop.c (CHECK_STRING_OR_BUFFER):
2475 * window.c (CHECK_WINDOW_CONFIGURATION):
2476 Move here from lisp.h, and make these functions static rather than
2477 extern inline.
2478 * buffer.c (Qoverlayp):
2479 * data.c (Qsubrp):
2480 * fns.c (Qhash_table_p):
2481 * window.c (Qwindow_configuration_p):
2482 Now static.
2483 * lisp.h: Remove the abovementioned defns and decls.
2484
44e18199 2485 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2486 In lisp.h, prefer functions to function-like macros, and
2487 constants to object-like macros, when either will do. This:
2488 . simplifies use, as there's no more need to worry about
2489 arguments' side effects being evaluated multiple times.
2490 . makes the code easier to debug on some platforms.
2491 However, when using gcc -O0, keep using function-like macros
2492 for a few critical operations, for performance reasons.
2493 This sort of thing isn't needed with gcc -Og, but -Og
2494 is a GCC 4.8 feature and isn't widely-enough available yet.
2495 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2496 Remove enum lsb_bits; no longer needed.
2497 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2498 * buffer.c (Qoverlap):
2499 * data.c (Qsubrp):
2500 * fns.c (Qhash_table_p):
2501 Now extern, so lisp.h can use these symbols.
2502 * dispextern.h: Include character.h, for MAX_CHAR etc.
2503 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2504 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2505 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2506 (GLYPH_CODE_P): Move here from lisp.h.
2507 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2508 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2509 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2510 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2511 XUNTAG now returns void *.
2512 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2513 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2514 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2515 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2516 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2517 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2518 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2519 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2520 New macros, renamed from their sans-lisp_h_ counterparts.
2521 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2522 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2523 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2524 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2525 If compiling via GCC without optimization, define these as macros
2526 in addition to inline functions.
2527 To disable this, compile with -DINLINING=0.
2528 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2529 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2530 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2531 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2532 (INTMASK, VALMASK): Now macros, since static values cannot be
2533 accessed from extern inline functions.
2534 (VALMASK): Also a constant, for benefit of old GDB.
2535 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2536 is INTEGERP, which can fold it in.
5165d44a 2537 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2538 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2539 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2540 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2541 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2542 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2543 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2544 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2545 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2546 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2547 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2548 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2549 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2550 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2551 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2552 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2553 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2554 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2555 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2556 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2557 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2558 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2559 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2560 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2561 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2562 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2563 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2564 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2565 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2566 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2567 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2568 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2569 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2570 Now functions.
2571 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2572 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2573 (VALMASK): Define in one place rather than in two, merging the
2574 USE_LSB_TAG parts; this is simpler.
2575 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2576 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2577 Move up, to avoid use before definition.
2578 Also include "globals.h" earlier, for the same reason.
2579 (make_natnum): New function.
2580 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2581 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2582 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2583 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2584 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2585 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2586 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2587 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2588 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2589 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2590 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2591 (Qwindow_configuration_p, Qimage): New forward declarations.
2592 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2593 (STRING_COPYIN): Remove; unused.
2594 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2595 (xcar_addr, xcdr_addr): New functions. All uses changed.
2596 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2597 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2598 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2599 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2600 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2601 (TYPE_RANGED_INTEGERP): Simplify.
2602 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2603 (setlocale, fixup_locale, synchronize_system_messages_locale)
2604 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2605 Now empty functions, not macros.
2606 (functionp): Return bool, not int.
2607 * window.c (Qwindow_configuration_p): Now extern,
2608 so window.h can use it.
2609 * window.h (Qwindowp): Move decl back to lisp.h.
2610
9583ec36
EZ
26112013-06-15 Eli Zaretskii <eliz@gnu.org>
2612
2613 * xdisp.c (Fline_pixel_height): New function, required for solving
2614 bug #14567.
2615
210272ce
PE
26162013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2617
2618 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2619
de0503df
SM
26202013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2621
2622 * lread.c (syms_of_lread):
2623 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2624
afbfe143
KD
26252013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2626
2627 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2628
d177e213
XF
26292013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2630
2631 * fileio.c (expand_file_name): Doc fix.
2632
05e3e412
PE
26332013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2634
f7394b12
PE
2635 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2636 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2637 Wait for self, not for 0. This can't hurt on GNU or similar
2638 system, and may help with Cygwin.
2639
05e3e412
PE
2640 * keyboard.c: Don't use PROP (...) as an lvalue.
2641 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2642 Use set_prop (A, B), not PROP (A) = B.
2643
17dd3097
EZ
26442013-06-10 Eli Zaretskii <eliz@gnu.org>
2645
2646 * xdisp.c (get_it_property): Use it->window instead of generating
2647 a Lisp object from it->w.
2648
52fab9c9
EZ
26492013-06-09 Eli Zaretskii <eliz@gnu.org>
2650
2651 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2652 get-char-property the window that is being rendered, instead of
2653 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2654 (compute_display_string_pos): When W is NULL, use the current
2655 buffer as the object to pass to get-char-property.
2656 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2657 pointer member of the bidi iterator, since no window is pertinent
2658 to this function.
52fab9c9 2659
5bf97bfc
EZ
26602013-06-08 Eli Zaretskii <eliz@gnu.org>
2661
2662 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2663 being displayed, and pass it to compute_display_string_pos.
2664 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2665 (bidi_paragraph_init): All callers changed.
2666
2667 * xdisp.c (init_from_display_pos, init_iterator)
2668 (handle_single_display_spec, next_overlay_string)
2669 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2670 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2671 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2672 (compute_display_string_pos): Accept additional argument, the
2673 window being displayed, and pass it to Fget_char_property.
2674 (Bug#14575)
2675
2676 * dispextern.h (struct bidi_it): New member w, the window being
2677 displayed.
2678 (compute_display_string_pos): Adjust prototype.
2679
5de0e011
JD
26802013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2681
e7b41c4c 2682 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2683
2684 * process.c (wait_reading_process_output): Check for NS before GLIB.
2685 GLIB may be linked in due to rsvg, but ns_select must be called.
2686
5de0e011
JD
2687 * xgselect.c (xg_select): Remove call to window_system_available
2688 and g_main_context_pending at the top, so Gdk events (i.e. file
2689 notify) are processed when Emacs is started with -nw.
2690
a822acff
EZ
26912013-06-07 Eli Zaretskii <eliz@gnu.org>
2692
2693 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2694 (ctagsfiles3): New variable, includes only *.m files.
2695 (TAGS): Use an explicit language name in the regular expressions,
2696 to avoid transformation of '/SOMETHING' by MSYS to
2697 'c:\MSYS\SOMETHING'.
2698
6c0a9ed1
RC
26992013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2700
2701 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2702
9ef6111b
EZ
27032013-06-06 Eli Zaretskii <eliz@gnu.org>
2704
2705 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2706 still need to set the mouse pointer shape and activate help-echo.
2707 (Bug#14558)
2708
7d300d64
PE
27092013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 A few porting etc. fixes for the new file monitor code.
2712 See the thread containing
2713 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2714 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2715 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2716 (dir_monitor_callback, Fgfile_rm_watch):
2717 Use assq_no_quit instead of Fassoc, for speed.
2718 (dir_monitor_callback, Fgfile_rm_watch):
2719 eassert that the monitor is a fixnum.
2720 (dir_monitor_callback): No need for CDR_SAFE.
2721 Simplify building of lisp with alternative tails.
2722 (Fgfile_add_watch, Fgfile_rm_watch):
2723 Do not assume glib functions set errno reliably on failure.
2724 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2725 and signal an error otherwise.
2726 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2727 Use Fdelq instead of Fdelete, for speed.
2728
817ebfcf
EZ
27292013-06-05 Eli Zaretskii <eliz@gnu.org>
2730
2731 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2732 don't insist on being invoked on a highlighted tool-bar button.
2733 Avoids losing tool-bar functionality when mouse-highlight is nil.
2734 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2735 Don't highlight when mouse-highlight is nil.
2736 (note_mouse_highlight): When mouse-highlight is nil, don't return
2737 right away; instead, run tool-bar and mode-line highlight
2738 subroutine, clear any existing highlight, and revert the mouse
2739 pointer to its default shape. (Bug#14558)
2740
55577e7c
SM
27412013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2742
2743 * lisp.mk (lisp): Add prog-mode.el.
2744
f019a684
PE
27452013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2748 * process.c (dummy_handler): New function.
2749 (lib_child_handler): New static var.
2750 (handle_child_signal): Invoke it.
2751 (catch_child_signal): If a library has set up a signal handler,
2752 save it into lib_child_handler.
2753 (init_process_emacs): If using glib and not on Windows, tickle glib's
2754 child-handling code so that it initializes its private SIGCHLD handler.
2755 * syssignal.h (SA_SIGINFO): Default to 0.
2756 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2757 31; it should no longer be needed now.
2758
90db8702
MA
27592013-06-05 Michael Albinus <michael.albinus@gmx.de>
2760
2761 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2762
2763 * gfilenotify.c (globals_of_gfilenotify): New function.
2764 (syms_of_gfilenotify): Move global initialization there.
2765
2766 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2767
bfa3acd6
SM
27682013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2769
2770 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2771 * keyboard.c (menu_bar_items, tool_bar_items):
2772 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2773 not override local keymaps any more.
2774
ba59bd80
EZ
27752013-06-04 Eli Zaretskii <eliz@gnu.org>
2776
2777 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2778
7f203aa1
EZ
27792013-06-03 Eli Zaretskii <eliz@gnu.org>
2780
9337e206
EZ
2781 * w32console.c (initialize_w32_display): Return the dimensions of
2782 the console window via 2 additional arguments, not via the current
2783 frame. This avoids crashes due to overrunning the bounds of
2784 frame's decode_mode_spec_buffer, which is not resized following
2785 the change of the frame dimensions from the initial 10x10.
2786
2787 * w32term.h (w32_initialize_display_info): Adjust prototype.
2788
2789 * term.c (init_tty): Take dimensions of the frame from the values
2790 returned by initialize_w32_display.
2791
7f203aa1
EZ
2792 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2793 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2794 (LIBES): Add $(GFILENOTIFY_LIBS).
2795
2796 * w32inevt.c (handle_file_notifications): Add dummy implementation
2797 for !HAVE_W32NOTIFY.
2798
2799 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2800
55a87246
JD
28012013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2802
2803 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2804
2805 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2806
2807 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2808
3d5ee10a
PE
28092013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 Fix minor problems found by static checking.
2812 * data.c (pure_write_error):
2813 Use xsignal2, not Fsignal, as Fsignal might return.
2814 * eval.c (set_backtrace_debug_on_exit): Now static.
2815 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2816 No longer inline. EXTERN_INLINE is needed only for functions
2817 defined in .h files. Reindent function header as per GNU style.
2818 (backtrace_p, backtrace_top, backtrace_next):
2819 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2820 compiler or linker. Add extern decls to pacify gcc -Wall.
2821 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2822 Now static.
2823 * frame.c (free_monitors): Define only on platforms that need it.
2824 * nsterm.m (ns_term_init):
2825 * process.c (catch_child_signal):
2826 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2827 defined on all porting targets these days.
2828 * process.c, process.h (catch_child_signal):
2829 Make it extern only if NS_IMPL_GNUSTEP is defined.
2830
e2d8a6f0
EZ
28312013-06-03 Eli Zaretskii <eliz@gnu.org>
2832
2833 * w32.c (gettimeofday): Make the signature identical to prototype
2834 in nt/inc/sys/time.h.
2835
a8a7c5f6
SM
28362013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2837
2838 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2839 .gdbinit.
2840
2841 * keyboard.c (safe_run_hooks_error): Improve error message.
2842
2843 * data.c (pure_write_error): Add `object' argument.
2844 * puresize.h (CHECK_IMPURE): Use it.
2845
c9628c79
MA
28462013-06-03 Michael Albinus <michael.albinus@gmx.de>
2847
2848 * Makefile.in (NOTIFY_OBJ): New variable.
2849 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2850
2851 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2852 Call syms_of_gfilenotify.
2853
2854 * gfilenotify.c: New file.
2855
2856 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2857 and Qfile_w32notify.
2858 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2859 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2860
2861 * lisp.h: Declare syms_of_gfilenotify.
2862
2863 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2864
2f592f95
SM
28652013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2866
2867 Merge the specpdl and backtrace stacks. Make the structure of the
2868 specpdl entries more obvious via a tagged union of structs.
2869 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2870 (enum specbind_tag): New enum.
2871 (struct specbinding): Make it a tagged union of structs.
2872 Add a case for backtrace records.
2873 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2874 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2875 (backtrace_debug_on_exit): New accessors.
2876 (struct backtrace): Remove.
2877 (struct catchtag): Remove backlist field.
2878 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2879 Move to eval.c.
2880 (Flocal_variable_p): Speed up the common case where the binding is
2881 already loaded.
2882 * eval.c (backtrace_list): Remove.
2883 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2884 (set_backtrace_args, set_backtrace_nargs)
2885 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2886 (backtrace_next): New functions.
2887 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2888 (unwind_to_catch, internal_lisp_condition_case)
2889 (internal_condition_case, internal_condition_case_1)
2890 (internal_condition_case_2, internal_condition_case_n): Don't bother
2891 with backtrace_list any more.
2892 (Fsignal): Adjust to new backtrace format.
2893 (grow_specpdl): Move up.
2894 (record_in_backtrace): New function.
2895 (eval_sub, Ffuncall): Use it.
2896 (apply_lambda): Adjust to new backtrace format.
2897 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2898 data.c.
2899 (specbind): Adjust to new specpdl format. Simplify.
2900 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2901 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2902 backtrace format.
2903 (mark_backtrace): Remove.
2904 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2905 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2906 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2907 Use mark_specpdl.
2908 * profiler.c (record_backtrace): Use get_backtrace.
2909 (handle_profiler_signal): Use backtrace_top_function.
2910 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2911 accessor functions.
2912
c0342369
JD
29132013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2914
2915 * process.h (catch_child_signal): Declare.
2916
2917 * process.c (catch_child_signal): New function.
2918 (init_process_emacs): Call it.
2919
2920 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2921 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2922 NS_IMPL_COCOA.
2923 (x_set_cursor_type): Remove declaration.
2924 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2925 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2926 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2927 (ns_get_color): Use F suffix on float.
2928 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2929 (ns_get_rgb_color): Remove.
2930 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2931 (note_mouse_movement): x and y are CGFloat.
2932 (ns_draw_fringe_bitmap): Remove unused rowY.
2933 Change #if to COCOA && >= 10_6.
2934 (ns_draw_window_cursor): Remove unused overspill.
2935 (ns_draw_underwave): width and x are EamcsCGFloat.
2936 (ns_draw_box): thickness is CGFloat.
2937 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2938 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2939 if not in main thread.
2940 (ns_get_pending_menu_title, ns_check_menu_open)
2941 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2942 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2943 (sendFromMainThread:): New method.
2944 (changeFont:): size is CGFloat.
2945 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2946 Disable warning about permanent text.
2947 (characterIndexForPoint:): Adjust return type depending on GNUStep
2948 version.
2949 (mouseDown:): delta is CGFloat.
2950 (updateFrameSize): Remove unised variable f.
2951 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2952 Cast float to EmacsCGFloat.
2953 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2954 also to -1 when restoring.
2955 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2956 inside NS_IMPL_COCOA.
2957 (toggleFullScreen:): Put call to toggleFullScreen inside
2958 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2959 (setPosition:portion:whole:): por is CGFloat.
2960 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2961 (mouseDown:): Use CGFloat.
2962 (mouseDragged:): Remove unised variable edge.
2963 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2964
2965 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2966 of CGFloat differs.
2967 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2968 when NS_IMPL_GNUSTEP.
2969 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2970 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2971 (EmacsToolbar): Add clearAll. Add tag argument to
2972 addDisplayItemWithImage.
2973 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2974
2975 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2976
2977 * nsmenu.m (ns_update_menubar): Make static.
2978 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2979 (fillWithWidgetValue:): Add cast to SEL for setAction.
2980 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2981 (update_frame_tool_bar): Update code for GNUStep.
2982 (clearAll): New method.
2983 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2984 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2985 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2986 call to insertItemWithItemIdentifier.
2987 (validateVisibleItems): Fix indentation.
2988 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2989 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2990 UtilityWindow to aStyle, remove call to setStyleMask.
2991
2992 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2993
2994 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2995 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2996 Use F suffix on floats.
2997 (ns_char_width): Returns CGFloat.
2998 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2999 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3000 DPSxshow.
3001 (ns_glyph_metrics): CGFloat instead of float.
3002
a0eb10b3
JB
3003 * nsfns.m (x_set_foreground_color, x_set_background_color):
3004 Use EmacsCGFloat.
3005 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3006 remove unused variables.
3007 (Fns_read_file_name): Keep track if panel is for save.
3008 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3009 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3010 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3011 Just return the input if GNUStep.
c0342369
JD
3012 (x_screen_planes): Remove.
3013 (Fxw_color_values): Use EmacsCGFloat
3014 (Fns_display_monitor_attributes_list): Only get screen number for
3015 Cocoa.
ef099a94 3016 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3017 EmacsSavePanel.
3018 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3019 ns_directory_from_panel.
3020
da9aff11
PE
30212013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 * process.c (handle_child_signal): Also use WCONTINUED.
3024 This is so that list-processes doesn't mistakenly list the process
3025 as stopped, when the process has actually been continued and is
3026 now running.
3027
0e64479a
PE
30282013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3029
fc186a96
PE
3030 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3031 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3032 not already configured.
3033
0e64479a
PE
3034 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3035
38b787fa
EZ
30362013-05-29 Eli Zaretskii <eliz@gnu.org>
3037
3038 * Makefile.in (mostlyclean): Remove *.res files.
3039
22513e52
SM
30402013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3041
3042 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3043 a buffer (bug#8447).
3044
6ef3db10
EZ
30452013-05-27 Eli Zaretskii <eliz@gnu.org>
3046
3047 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3048 display vector, and we backtrack, handle the case that the
3049 previous character position is also displayed from a display
3050 vector or covered by a display string or image. (Bug#14476)
3051
6799bb26
JD
30522013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3053
3054 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3055 (struct MonitorInfo, free_monitors): Remove.
3056 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3057 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3058 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3059 Qframes, Qsource.
3060
3061 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3062 (struct MonitorInfo, free_monitors): Remove.
3063 (ns_screen_name): Make static.
3064 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3065 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3066 Qframes, Qsource.
3067
3068 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3069 (struct MonitorInfo): New struct.
3070 (free_monitors, make_monitor_attribute_list): Declare.
3071
22513e52
SM
3072 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3073 New Lisp_Object:s.
6799bb26
JD
3074 (free_monitors, make_monitor_attribute_list): New functions.
3075 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3076 Qsource.
3077
38cd43eb
XF
30782013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3079
3080 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3081
2af0948d
SM
30822013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3083
a7eb9b0f
SM
3084 * keyboard.c: Apply keyboard decoding only to events that come directly
3085 from the tty, not from unread-command-events (bug#14368).
3086 (read_event_from_main_queue): New function, extracted from read_char).
3087 (read_decoded_char): Remove.
3088 (read_decoded_event_from_main_queue): New function to replace it.
3089 (read_char): Use it.
3090 (read_key_sequence): Use read_char rather than read_decoded_char.
3091
2af0948d
SM
3092 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3093
1413e9a5
BR
30942013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3095
3096 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3097
e6d2f155
KH
30982013-05-22 Kenichi Handa <handa@gnu.org>
3099
3100 The following changes are to fix the setting of
3101 buffer-file-coding-system on, for instance, C-x RET c unix RET
3102 _FILE_OF_DOS_EOL_TYPE_ RET.
3103
3104 * coding.h (struct coding_system): New member detected_utf8_chars.
3105
3106 * coding.c (detect_coding_utf_8): Count characters and check EOL
3107 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3108 BOM is there.
3109 (setup_coding_system): Do not initialize coding->head_ascii.
3110 (check_ascii): Do not set coding->eol_seen but update it. Do not
3111 call adjust_coding_eol_type here.
1413e9a5
BR
3112 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3113 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3114 of the found coding-system.
3115 (decode_coding_gap): Cancel previous change. Utilize the
3116 character numbers counted by detect_coding_utf_8. Fix detection
3117 of BOM for utf-8.
3118
ab56a6f4 31192013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3120
3121 * search.c (looking_at_1): Only set last_thing_searched if the match
3122 changed the match-data (bug#14281).
3123
ecc3c6ed
DA
31242013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3125
3126 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3127 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3128 (move_it_vertically_backward): Likewise.
3129
5ba8bf35
YM
31302013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3131
3132 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3133 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3134 (Fx_display_mm_width, Fx_display_mm_height):
3135 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3136
91e8418b 3137 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3138 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3139 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3140 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3141 (Fx_display_backing_store, Fx_display_visual_class)
3142 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3143 (Fx_display_grayscale_p, Fx_display_pixel_width)
3144 (Fx_display_pixel_height, Fx_display_planes)
3145 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3146 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3147 (Fx_display_mm_width, Fx_display_mm_height)
3148 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3149 height for all physical monitors as in X11.
3150
fc30d803
SM
3151 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3152 Return pixel width or height for all physical monitors as in X11.
91e8418b 3153
31ff141c
PE
31542013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 Port --enable-gcc-warnings to clang.
3157 * bytecode.c (exec_byte_code):
3158 * regex.c:
3159 Redo diagnostic pragmas to pacify clang, too.
3160 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3161 * editfns.c (Fencode_time):
3162 * fileio.c (file_accessible_directory_p):
3163 * font.c (font_unparse_xlfd):
3164 Use '&"string"[index]' instead of '"string" + (index)'.
3165 * undo.c (user_error): Remove; unused.
3166
df065a0b
EZ
31672013-05-16 Eli Zaretskii <eliz@gnu.org>
3168
04d360e7
EZ
3169 * insdel.c (insert_1_both): Document the arguments, instead of
3170 referring to insert_1, which no longer exists.
3171
5bb98290
EZ
3172 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3173 some window, increment windows_or_buffers_changed, so that
3174 *Messages* display in that window is updated. (Bug#14408)
3175
df065a0b
EZ
3176 * w32.c: Include epaths.h.
3177 (init_environment): Use cmdproxy.exe without leading directories.
3178 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3179 case.
3180 (gettimeofday): Adjust signature and return value to Posix
3181 expectations.
3182
3183 * unexw32.c (open_output_file): Delete the existing emacs.exe
3184 before creating it, to break the hard link to the versioned
3185 executable.
3186
3187 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3188 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3189 (FIRSTFILE_OBJ): New variables.
3190 (W32_RES): Rename to EMACSRES. All users changed.
3191 (base_obj): Use $(CM_OBJ).
3192 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3193 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3194 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3195 $(W32_RES_LINK) before $(LIBES).
3196 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3197
1aa8d505
SM
31982013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3199
6e911150
SM
3200 * makefile.w32-in (DOC): Use just "DOC".
3201
3202 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3203
1aa8d505
SM
3204 * process.c: Export default filters and sentinels to Elisp.
3205 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3206 New constants.
3207 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3208 (Fset_process_sentinel, Fformat_network_address):
3209 Default to them instead of nil.
3210 (server_accept_connection): Sentinels can't be nil any more.
3211 (read_and_dispose_of_process_output): New function, extracted from
3212 read_process_output.
3213 (read_process_output): Use it; filters can't be nil.
3214 (Finternal_default_process_filter): New function, extracted from
3215 read_process_output.
3216 (exec_sentinel_unwind): Remove function.
3217 (exec_sentinel): Don't zilch sentinel while running.
3218 (status_notify): Sentinels can't be nil.
3219 (Finternal_default_process_sentinel): New function extracted from
3220 status_notify.
3221 (setup_process_coding_systems): Default filter is not nil any more.
3222 (syms_of_process): Export new Elisp functions and initialize
3223 new constants.
3224 * lisp.h (make_lisp_proc): New function.
3225
5ac2eb34
SM
32262013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3227
3228 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3229
eda9c7d7
EZ
32302013-05-14 Eli Zaretskii <eliz@gnu.org>
3231
3232 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3233 unless we know that the window w is a leaf window.
3234 Another attempt at solving bug#14062.
eda9c7d7 3235
8fdeaad5
JD
32362013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3237
3238 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3239 fdesc (Bug#14375).
3240
44aa9ee6
PE
32412013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 * image.c (gif_load): Check that subimages fit (Bug#14345).
3244
759fd763
SM
32452013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3246
3247 * lread.c (skip_dyn_eof): New function.
3248 (read1): Use it to skip the end of a file in response to #@00.
3249
3250 * doc.c (get_doc_string): Slightly relax the sanity checking.
3251
4465bfb4
JD
32522013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3253
3254 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3255 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3256 (MonitorInfo): New struct.
3257 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3258 (Fns_display_monitor_attributes_list): New functions.
3259 (display-usable-bounds): Remove.
3260 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3261 Qsource.
3262
7583e2a0
PE
32632013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3266 (GTK_CHECK_VERSION): New macro, if not already defined.
3267 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3268 replaced by GTK_CHECK_VERSION.
3269
ad75d77e
PE
32702013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3271
3272 * xterm.h (GTK_PREREQ): New macro.
3273 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3274 to use this macro instead, for consistency and clarity.
3275
07525f77
EZ
32762013-05-08 Eli Zaretskii <eliz@gnu.org>
3277
3278 * xdisp.c (row_for_charpos_p): New function, with code of
3279 cursor_row_p, but accepts an additional argument CHARPOS instead
3280 of using a hardcoded PT.
3281 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3282 (row_containing_pos): Call row_for_charpos_p instead of partially
3283 doing the same. Fixes cursor positioning under longlines-mode
3284 when longlines-show-effect includes more than one newline, when
3285 moving the cursor vertically up.
3286
d901fc8d
JB
32872013-05-08 Juanma Barranquero <lekktu@gmail.com>
3288
3289 * makefile.w32-in (ACL_H): New macro.
3290 ($(BLD)/fileio.$(O)): Update dependencies.
3291
f269bc61
PE
32922013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3293
e7b41c4c 3294 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3295 * Makefile.in (LIB_ACL): New macro.
3296 (LIBACL_LIBS): Remove.
3297 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3298 * fileio.c: Include <acl.h>.
3299 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3300 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3301 !acl_errno_valid.
3302 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3303 it ourselves.
3304
f269bc61
PE
3305 * unexelf.c: Don't assume ElfW (Half) fits in int.
3306 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3307 when dealing with ElfW (Half) values, since they can exceed 2**31
3308 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3309 (entry_address): Omit unused NUM arg. All uses changed.
3310
a261c53e
JL
33112013-05-07 Juri Linkov <juri@jurta.org>
3312
3313 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3314 to the string converted from number with `Fnumber_to_string'.
3315 (Bug#14254)
3316
2b66427d
PE
33172013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3320 This fixes a problem introduced by my previous change.
3321
15acfe41
GM
33222013-05-07 Glenn Morris <rgm@gnu.org>
3323
3324 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3325
5ea03bf5
JD
33262013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3327
3328 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3329
e0c9d565
PE
33302013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3331
3332 Static checking by GCC 4.8.0.
3333 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3334 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3335 (x_get_monitor_attributes_fallback)
3336 (x_get_monitor_attributes_xinerama)
3337 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3338 Define only if USE_GTK.
3339 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3340 (x_get_monitor_attributes_fallback): Omit unused locals.
3341 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3342 Use double, not float, to avoid mixed-mode floating point arithmetic.
3343
4e3f9230
YM
33442013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3345 Jan Djärv <jan.h.d@swipnet.se>
3346
3347 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3348 (XINERAMA_CFLAGS): New macros.
3349 (ALL_CFLAGS, LIBES): Use them.
3350
3351 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3352 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3353 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3354 (syms_of_xfns): DEFSYM them.
3355 (struct MonitorInfo): New struct.
3356 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3357 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3358 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3359 (x_get_monitor_attributes_xinerama): New functions.
3360 (Fx_display_monitor_attributes_list): New primitive.
3361 (syms_of_xfns): Defsubr it.
3362
3363 * xterm.h (x_display_info): Add Xatom_net_workarea and
3364 Xatom_net_current_desktop.
3365
3366 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3367 and dpyinfo->Xatom_net_current_desktop.
3368
05839b6a
EZ
33692013-05-06 Eli Zaretskii <eliz@gnu.org>
3370
3371 * xdisp.c (pos_visible_p): Use the special code for finding the
3372 beginning of a display property or overlay for any "replacing"
3373 display property, not just for display strings. This solves
3374 incorrect reporting of position by posn-at-point. (Bug#14241)
3375
dc4a2ee0
PE
33762013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3377
5ee94506
PE
3378 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3379 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3380 Verify that ElfW (Half) fits in int.
3381 (fatal): Use same signature as lisp.h.
3382 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3383 configure and build with -DUNEXELF_DEBUG without worrying about
3384 other modules that use DEBUG.
3385 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3386 possibly-wide integers now uses it instead of plain fprintf.
3387 (entry_address): New function, which avoids problems with 32-bit
3388 overflow on 64-bit hosts.
3389 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3390 (round_up): Don't assume the remainder fits in int.
3391 (find_section): Use bool for boolean. Simplify debug code.
3392 (unexec): Don't assume file sizes fit in int or size_t.
3393 Omit unnecessary trailing newline in 'fatal' format.
3394 Use strerror rather than outputting decimal error number.
3395 Remove unused code when emacs is not defined;
3396 this file relies on Emacs now.
3397 Don't assume e_phnum and e_shnum are positive.
3398
dc4a2ee0
PE
3399 * regex.c: Fix problems when DEBUG is defined.
3400 (extract_number, extract_number_and_incr): Define regardless of
3401 whether DEBUG is defined; that's simpler and makes the code less
3402 likely to go stale in the normal case when DEBUG is not defined.
3403 Return int rather than taking an int * arg. All callers changed.
3404 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3405 Remove, replacing with ...
3406 (DEBUG_PRINT): New macro. All callers changed.
3407 (DEBUG_COMPILES_ARGUMENTS): New macro.
3408 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3409 (print_compiled_pattern, print_double_string) [DEBUG]:
3410 Use prototype rather than old-style definition.
3411 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3412 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3413 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3414 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3415 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3416 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3417 This matters only when DEBUG is defined.
3418
14c7ed05
EZ
34192013-05-05 Eli Zaretskii <eliz@gnu.org>
3420
3421 * xdisp.c (set_iterator_to_next): Set the
3422 ignore_overlay_strings_at_pos_p flag only if we are _really_
3423 iterating over an overlay string, as indicated by the
3424 current.overlay_string_index member. (Bug#14306)
3425
e6076b1b
JD
34262013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3427
3428 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3429 to where it is used, to avoid autorelease issues (Bug#14050).
3430
cbee2131
PE
34312013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3432
3433 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3434 * fileio.c (syms_of_fileio): Implement this.
3435 * filelock.c (create_lock_file): If symbolic links don't work, so
3436 we use a regular file as a lock file, do not fsync the lock file;
3437 it's not needed.
3438
30c7e542
SM
34392013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3440
3441 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3442 (syms_of_minibuf): Adjust accodingly.
3443 * lread.c (Fread):
3444 * callint.c (Fcall_interactively): Adjust calls accordingly.
3445
5bebd186
EZ
34462013-05-04 Eli Zaretskii <eliz@gnu.org>
3447
3448 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3449 w->contents is a buffer before computing everything else.
3450 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3451
3452 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3453 assertion violations. (Bug#14062)
3454
0fb0a4f3
DR
34552013-05-01 David Reitter <david.reitter@gmail.com>
3456
3457 * nsfns.m (ns_tooltip): Initialize.
3458
9e63b4a5
EZ
34592013-04-28 Eli Zaretskii <eliz@gnu.org>
3460
3461 * coding.c (decode_coding_gap): Don't remove the character before
3462 a newline unless it's a CR character. (Bug#14287)
3463
ad60824e
DN
34642013-04-28 Dan Nicolaescu <dann@gnu.org>
3465
3466 * dispextern.h (struct face): Move enum face_underline_type
3467 earlier so that bitfields can be in the same word.
3468
edbdcec0
JD
34692013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3470
3471 * nsfns.m (handlePanelKeys): New function.
3472 (EmacsOpenPanel:performKeyEquivalent:)
3473 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3474 arrows/function/control and copy/paste keys (Bug#14296).
3475
0208ede7
JL
34762013-04-27 Juri Linkov <juri@jurta.org>
3477
3478 * callint.c (Fcall_interactively): Call `Qread_number' for
3479 interactive code letter `n' instead of using duplicate code.
3480 (Bug#14254)
3481
b8dd59f7
PE
34822013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3483
3484 * systime.h (make_timeval): Declare as 'const'.
3485
8bd722db
KH
34862013-04-27 Kenichi Handa <handa@gnu.org>
3487
3488 * font.c (font_open_entity): Always open a font of manageable
3489 size.
3490
13d0e56f 34912013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3492
f780d632
PE
3493 Port better to AIX (Bug#14258).
3494 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3495 to pacify AIX xlc.
3496
ec509856
KH
34972013-04-24 Kenichi Handa <handa@gnu.org>
3498
3499 * coding.c (decode_coding_iso_2022): When an invalid escape
3500 sequence is encountered, reset the invocation and designation
3501 status to the safest one.
3502
84fc48e5
PE
35032013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3504
3505 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3506 Without this fix, "make distclean" leaves stamp-h1 behind.
3507
806bda47
EC
35082013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3509
3510 * w32fns.c (w32_fullscreen_rect): New function to compute the
3511 window rectangle for the given fullscreen mode.
3512 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3513 longer tunes the window size. This keeps the window's edges flush
3514 with the screen and allows the taskbar to hide itself in fullboth.
3515
3516 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3517 window decorations and uses the entire screen.
3518
3519 * w32term.h (w32_fullscreen_rect) Add prototype.
3520 (struct w32_output): Replace normal_width, normal_height,
3521 normal_top, and normal_left members with a single normal_placement
3522 struct.
3523 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3524 Remove macros.
3525 (FRAME_NORMAL_PLACEMENT): New macro.
3526
9cc2810b
JB
35272013-04-16 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * minibuf.c (Ftest_completion): Silence compiler warning.
3530
fd16b54c
EZ
35312013-04-15 Eli Zaretskii <eliz@gnu.org>
3532
3533 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3534 bug#14062.
fd16b54c
EZ
3535
3536 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3537 parentheses.
3538
3539 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3540 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3541 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3542 parentheses where appropriate.
3543
9e3379a0
PE
35442013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3547
ddd6b685
EZ
35482013-04-14 Eli Zaretskii <eliz@gnu.org>
3549
3550 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3551 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3552 Mention in the doc string that setting these variables takes
3553 effect only after a call to set-window-buffer. (Bug#14200)
3554
29b79ba1
EZ
35552013-04-13 Eli Zaretskii <eliz@gnu.org>
3556
3557 * indent.c (Fvertical_motion): Don't consider display strings on
3558 overlay strings as display strings on the buffer position we
3559 started from. This prevents vertical cursor motion from jumping
3560 more than one line when there's an overlay string with a display
3561 property at end of line.
3562 Reported by Karl Chen <Karl.Chen@quarl.org> in
3563 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3564
562c6ee9
SM
35652013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3566
3567 * window.c (select_window): `record_buffer' even if window is
3568 already selected (bug#14191).
3569
fcc1fe85
EZ
35702013-04-11 Eli Zaretskii <eliz@gnu.org>
3571
3572 * window.c (Fwindow_end): Test more flags, including the buffer's
3573 last_overlay_modified flag, to determine whether the window's
3574 display is really up-to-date. Prevents the function from
3575 returning a stale value. (Bug#14170)
3576 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3577 current matrix.
3578
f009190a
EZ
35792013-04-10 Eli Zaretskii <eliz@gnu.org>
3580
3581 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3582 garbaged only if it is not already the top frame on its TTY.
3583 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3584 there are GUI frames open in the same session. (Bug#13864)
3585
78ce603d
SM
35862013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3587
3588 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3589 of marking the idle timers directly.
3590
a8036e40
SM
35912013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3592
3593 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3594 tables (bug#14054).
3595
7ffe7ef6
SM
35962013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3597
3598 * window.c (select_window): Don't record_buffer while the invariant is
3599 temporarily broken (bug#14161).
3600
3601 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3602
7d9f6883
EZ
36032013-04-07 Eli Zaretskii <eliz@gnu.org>
3604
3605 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3606
5406cfd9
RF
36072013-04-07 Romain Francoise <romain@orebokech.com>
3608
3609 Ignore additional platform-specific ACL errors (Bug#13702).
3610 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3611 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3612
95c0e83b
JD
36132013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3614
3615 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3616 f->output_data.ns.
3617
876da980
PE
36182013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3621 This bug was introduced by my 2013-02-25 change that simplified
3622 data_start configuration. Without this change, on GNU/Linux
3623 an Emacs configured with --enable-profiling fails immediately
3624 due to a profiler signal.
3625 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3626 with these flags. On platforms where special flags are needed
3627 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3628 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3629 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3630
7452b7bd
DA
36312013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3632
3633 Get rid of some platform-specific functions examining window
3634 system and its capabilities. This is a partial rework of the
3635 2013-04-05 change.
3636 * lisp.h (have_menus_p): Remove prototype. This function is
3637 replaced with platform-independent window_system_available.
3638 (check_window_system): Move to...
3639 * frame.h (decode_window_system_frame, window_system_available):
3640 ...here, add new prototypes.
3641 * frame.c (window_system_available, decode_window_system_frame):
3642 New functions.
3643 (check_window_system): Platform-independent now.
3644 * xterm.h (x_in_use): Remove declaration.
3645 (check_x_frame):
3646 * w32term.h (check_x_frame):
3647 * nsterm.h (check_x_frame): Remove prototypes. This function
3648 is replaced with platform-independent decode_window_system_frame.
3649 * msdos.c (have_menus_p): Remove.
3650 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3651 Remove platform-specific functions. Use check_window_system,
3652 decode_window_system_frame and check_ns_display_info where
3653 appropriate. Minor style and comment tweaks.
3654 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3655 (check_x_frame): Likewise.
3656 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3657 Likewise.
3658 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3659 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3660 * xmenu.c, xselect.c: All related users changed.
3661
251e9147
KH
36622013-04-03 Kenichi Handa <handa@gnu.org>
3663
3664 The following changes is to optimize the code for reading UTF-8
3665 files.
3666
562c6ee9 3667 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3668 changed. Check EOL format. Do not call adjust_coding_eol_type
3669 here.
3670 (check_utf_8): New function.
3671 (adjust_coding_eol_type): Do nothing if already adjusted.
3672 (detect_coding): Compare the return value of check_ascii with
3673 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3674 (decode_coding_gap): Optimize for valid UTF-8.
3675
8bc369d4
KH
36762013-03-21 Kenichi Handa <handa@gnu.org>
3677
3678 * coding.c (syms_of_coding): Cancel previous change.
3679
3680 * insdel.c (insert_from_gap): Fix previous change.
3681
73931ad1
DA
36822013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3683
3684 Consistently use platform-specific function to detect window system.
3685 * lisp.h (check_window_system): New prototype. This function is
3686 going to replace check_x, check_w32 and check_ns.
3687 (have_menus_p): Mention msdos.c in comment.
3688 * fontset.c (check_window_system_func): Remove. Adjust all users.
3689 * fontset.h (check_window_system_func): Remove prototype.
3690 * nsterm.h (check_ns):
3691 * xterm.h (check_x):
3692 * w32term.h (check_w32): Likewise.
3693 * menu.c (Fx_popup_menu): Use check_window_system.
3694 * msdos.c (check_window_system): Define for MS-DOS.
3695 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3696 * w32fns.c (check_window_system): Likewise for MS-Windows.
3697 * xfns.c (check_window_system): Likewise for X.
3698 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3699 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3700
7216e43b
PE
37012013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3702
3703 Prefer < to > in range checks such as 0 <= i && i < N.
3704 This makes it easier to visualize quantities on a number line.
3705 This patch doesn't apply to all such range checks,
3706 only to the range checks affected by the 2013-03-24 change.
3707 This patch reverts most of the 2013-03-24 change.
3708 * alloc.c (xpalloc, Fgarbage_collect):
3709 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3710 * character.c (string_escape_byte8):
3711 * charset.c (read_hex):
3712 * data.c (cons_to_unsigned):
3713 * dispnew.c (update_frame_1):
3714 * doc.c (Fsubstitute_command_keys):
3715 * doprnt.c (doprnt):
3716 * editfns.c (hi_time, decode_time_components):
3717 * fileio.c (file_offset):
3718 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3719 * font.c (font_intern_prop):
3720 * frame.c (x_set_alpha):
3721 * gtkutil.c (get_utf8_string):
3722 * indent.c (check_display_width):
3723 * keymap.c (Fkey_description):
3724 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3725 * lread.c (read1):
3726 * minibuf.c (read_minibuf_noninteractive):
3727 * process.c (wait_reading_process_output):
3728 * search.c (Freplace_match):
3729 * window.c (get_phys_cursor_glyph):
3730 * xdisp.c (redisplay_internal):
3731 * xsmfns.c (smc_save_yourself_CB):
3732 Prefer < to > for range checks.
3733 * dispnew.c (sit_for): Don't mishandle NaNs.
3734 This fixes a bug introduced in the 2013-03-24 change.
3735 * editfns.c (decode_time_components): Don't hoist comparison.
3736 This fixes another bug introduced in the 2013-03-24 change.
3737
92759988
DA
37382013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3739
3740 * frame.h (struct frame): Drop scroll_bottom_vpos
3741 member becaue all real users are dead long ago.
3742 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3743 * xdisp.c (redisplay_internal): Adjust user.
3744
9a1971bb
GM
37452013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3746
f38ab167
JD
3747 * nsmenu.m (showAtX:Y:for:): setLevel to
3748 NSPopUpMenuWindowLevel (Bug#13998).
3749
6d01f1fe
JD
37502013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3751
3752 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3753 (ns_check_pending_open_menu): Declare.
3754
3755 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3756 (x_activate_menubar): Update the menu with title that matches
3757 ns_get_pending_menu_title, and call
3758 ns_check_pending_openmenu (Bug#12698).
3759 (menuWillOpen:): New method.
3760 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3761
3762 * nsterm.m (menu_will_open_state, menu_mouse_point)
3763 (menu_pending_title): New varaibles.
3764 (ns_get_pending_menu_title, ns_check_menu_open)
3765 (ns_check_pending_open_menu): New functions.
3766
781f4782
DA
37672013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3768
3769 * indent.c (current_column_bol_cache): Remove leftover which is not
3770 used in Fmove_to_column any more.
3771 (current_column, scan_for_column): Adjust users.
3772 * keyboard.c (last_point_position_buffer, last_point_position_window):
3773 Remove leftovers which are not used for recording undo any more.
3774 (command_loop_1, syms_of_keyboard): Adjust users.
3775 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3776 redisplay_window any more.
3777 (move_it_to): Adjust user.
3778
1921c31b
JB
37792013-03-29 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3782 Update dependencies.
3783
717b8bcd
SM
37842013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3785
3786 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3787 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3788 forward references.
3789
e74aeda8
DA
37902013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3791
3792 * window.h (struct window): Replace hchild, vchild and buffer slots
3793 with the only contents slot. This is possible because each valid
3794 window may have either the child window (in vertical or horizontal
3795 combination) or buffer to display (for the leaf window). Using that,
3796 a lof of operations to traverse and/or change window hierarchies may
3797 be simplified. New member horizontal is used to distinguish between
3798 horizontal and vertical combinations of internal windows.
3799 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3800 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3801 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3802 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3803 Use contents slot, not buffer, where appropriate.
3804 (wset_combination): New function.
3805 (wset_buffer): Add eassert.
3806 (Fframe_first_window): Simplify the loop reaching first window.
3807 (Fwindow_buffer): Use WINDOW_LEAF_P.
3808 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3809 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3810 (unshow_buffer): Convert initial debugging check to eassert.
3811 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3812 (make_parent_window, window_resize_check, window_resize_apply)
3813 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3814 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3815 Adjust to match struct window changes.
3816 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3817 (mark_window_cursors_off, count_windows, get_leaf_windows)
3818 (foreach_window_1): Simplify the loop.
3819 * alloc.c (mark_object): Do not check for the leaf window because
3820 internal windows has no glyph matrices anyway.
3821 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3822 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3823 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3824 (build_frame_matrix_from_window_tree, mirror_make_current)
3825 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3826 (update_window_tree, set_window_update_flags): Simplify the loop.
3827 (sync_window_with_frame_matrix_rows): Enforce live window.
3828 Use contents slot, not buffer, where appropriate.
3829 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3830 and WINDOW_HORIZONTAL_COMBINATION_P.
3831 (make_frame_visible_1): Simplify the loop.
3832 Use contents slot, not buffer, where appropriate.
3833 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3834 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3835 (expose_window_tree): Likewise.
3836 Use contents slot, not buffer, where appropriate.
3837 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3838 to avoid deleted windows. Use contents slot instead of buffer.
3839 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3840 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3841 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3842 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3843
121ab1cd
EZ
38442013-03-28 Eli Zaretskii <eliz@gnu.org>
3845
ef454cf7
EZ
3846 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3847 identify the reasons for assertion violations in bug#14062 and
3848 similar ones.
21e930f8
EZ
3849 (Fx_show_tip): Fix compilation error under
3850 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3851
121ab1cd
EZ
3852 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3853 Reported by <rzl24ozi@gmail.com>.
3854
5c89ca24
DA
38552013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3856
3857 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3858 start marker...
562c6ee9
SM
3859 (unwind_with_echo_area_buffer): ...to restore it here.
3860 This is needed to ensure that...
5c89ca24
DA
3861 (redisplay_window): ...both window markers are valid here,
3862 which is verified by eassert.
3863 * editfns.c (save_excursion_save): Do not assume that
3864 selected_window always displays the buffer.
c7f53895
DA
3865 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3866 Fix comment.
5c89ca24 3867
f557c1b1
SM
38682013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3869
3870 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3871 the upcase table.
3872
40693bba 38732013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3874
3875 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3876
c86f791f
EZ
38772013-03-27 Eli Zaretskii <eliz@gnu.org>
3878
3879 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3880 since MinGW's w32api headers do. This avoids compiler warnings.
3881
3882 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3883 if already defined.
3884
c6e72e17
EZ
38852013-03-26 Eli Zaretskii <eliz@gnu.org>
3886
3887 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3888
54e95010
JD
38892013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3890
3891 * gtkutil.c (style_changed_cb): Check if frame is live and an
3892 X frame (Bug#14038).
3893
b88b62de
EZ
38942013-03-26 Eli Zaretskii <eliz@gnu.org>
3895
a18d7de6
EZ
3896 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3897 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3898 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3899 MinGW64.
8f5e14c8
EZ
3900 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3901 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3902
b88b62de
EZ
3903 Fix incompatibilities between MinGW.org and MinGW64 headers.
3904 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3905
3906 * w32.c (REPARSE_DATA_BUFFER): Guard with
3907 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3908
c074e458
JD
39092013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3910
3911 * xterm.c: Include X11/XKBlib.h
3912 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3913
908589fd
AS
39142013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3915
3916 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3917 written backwards.
3918 * blockinput.h (input_blocked_p): Likewise.
3919 * bytecode.c (exec_byte_code): Likewise.
3920 * callproc.c (call_process_kill, call_process_cleanup)
3921 (Fcall_process): Likewise.
3922 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3923 (Fccl_execute_on_string): Likewise.
3924 * character.c (string_escape_byte8): Likewise.
3925 * charset.c (read_hex): Likewise.
3926 * cm.c (calccost): Likewise.
3927 * data.c (cons_to_unsigned): Likewise.
3928 * dired.c (directory_files_internal, file_name_completion):
3929 Likewise.
3930 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3931 (sit_for): Likewise.
3932 * doc.c (Fsubstitute_command_keys): Likewise.
3933 * doprnt.c (doprnt): Likewise.
3934 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3935 * emacsgtkfixed.c: Likewise.
3936 * fileio.c (file_offset, Fwrite_region): Likewise.
3937 * floatfns.c (Fexpt, fmod_float): Likewise.
3938 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3939 Likewise.
3940 * font.c (font_intern_prop): Likewise.
3941 * frame.c (x_set_alpha): Likewise.
3942 * gtkutil.c (get_utf8_string): Likewise.
3943 * indent.c (check_display_width): Likewise.
3944 * intervals.c (create_root_interval, rotate_right, rotate_left)
3945 (split_interval_right, split_interval_left)
3946 (adjust_intervals_for_insertion, delete_node)
3947 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3948 (merge_interval_right, merge_interval_left, copy_intervals)
3949 (set_intervals_multibyte_1): Likewise.
3950 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3951 * keymap.c (Fkey_description): Likewise.
3952 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3953 * lread.c (openp, read_integer, read1, string_to_number):
3954 Likewise.
3955 * menu.c (ensure_menu_items): Likewise.
3956 * minibuf.c (read_minibuf_noninteractive): Likewise.
3957 * print.c (printchar, strout): Likewise.
3958 * process.c (create_process, Faccept_process_output)
3959 (wait_reading_process_output, read_process_output, send_process)
3960 (wait_reading_process_output): Likewise.
3961 * profiler.c (make_log, handle_profiler_signal): Likewise.
3962 * regex.c (re_exec): Likewise.
3963 * regex.h: Likewise.
3964 * search.c (looking_at_1, Freplace_match): Likewise.
3965 * sysdep.c (get_child_status, procfs_ttyname)
3966 (procfs_get_total_memory): Likewise.
3967 * systime.h (EMACS_TIME_VALID_P): Likewise.
3968 * term.c (dissociate_if_controlling_tty): Likewise.
3969 * window.c (get_phys_cursor_glyph): Likewise.
3970 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3971 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3972 Likewise.
3973 * xfns.c (Fx_window_property): Likewise.
3974 * xmenu.c (set_frame_menubar): Likewise.
3975 * xselect.c (x_get_window_property, x_handle_dnd_message):
3976 Likewise.
3977 * xsmfns.c (smc_save_yourself_CB): Likewise.
3978 * xterm.c (x_scroll_bar_set_handle): Likewise.
3979
2bf7d27a
DA
39802013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3981
3982 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3983 to be optional or nil. Adjust comment and convert it to docstring.
3984 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3985 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3986
a9ebfa0b
PE
39872013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 Static checking by GCC 4.8-20130319.
3990 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3991 * process.c (Fset_process_datagram_address)
3992 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3993 * xdisp.c (get_char_face_and_encoding):
3994 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3995 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3996 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3997
4f3576ee
KB
39982013-03-24 Ken Brown <kbrown@cornell.edu>
3999
789b5e9a
KB
4000 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4001 fix compilation on 64-bit Cygwin, where underscores are not
4002 automatically prepended.
4003
4f3576ee
KB
4004 * w32term.c (w32_initialize): Silence compiler warning.
4005
b5b7745f
EZ
40062013-03-23 Eli Zaretskii <eliz@gnu.org>
4007
cdc0d0bd
EZ
4008 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4009 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4010 variables, to save and restore frame dimensions.
4011 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4012 after returning from a 'fullscreen' configuration.
4013 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4014 to avoid races between the main thread and the input thread.
4015
4016 * w32term.h (struct w32_output): New members normal_width,
4017 normal_height, normal_top, normal_left, and prev_fsmode.
4018 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4019 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4020 members of a frame.
4021
b5b7745f
EZ
4022 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4023 'fullscreen' parameter. Always record previous width and height
4024 of the frame, except when switching out of maximized modes, so
4025 that they could be restored correctly, instead of resetting to the
4026 default frame dimensions. Send SC_RESTORE command to the frame,
4027 unless we are going to send SC_MAXIMIZE, to restore the frame
4028 resize hints in the mouse pointer shown by the window manager.
4029 (Bug#14032)
4030
4031 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4032
4033 * lisp.h (get_frame_param): Adjust conditions for prototype
4034 declaration.
4035
a3454eed
KB
40362013-03-22 Ken Brown <kbrown@cornell.edu>
4037
4038 * unexcw.c: Drop unneeded inclusion of w32common.h.
4039 (report_sheap_usage): Declare.
4040 (read_exe_header): Add magic numbers for x86_64.
4041 (fixup_executable): Fix printf format specifier for unsigned long
4042 argument.
4043
5a49b79c
DA
40442013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4045
4046 * frame.h (struct frame): Put menu_bar_window under #ifdef
4047 because this member is not needed when X toolkit is in use.
4048 (fset_menu_bar_window):
4049 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4050 (free_glyphs, update_frame):
4051 * xdisp.c (expose_frame): Likewise.
4052 (display_menu_bar): Likewise. Remove redundant eassert.
4053 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4054 toolkit is in use.
4055
d6723bf7
PE
40562013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4057
7b1123d8
PE
4058 Use functions and constants to manipulate Lisp_Save_Value objects.
4059 This replaces code that used macros and strings and token-pasting.
4060 The change makes the C source a bit easier to follow,
4061 and shrinks the Emacs executable a bit.
4062 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4063 (make_save_value): Change 1st arg from string to enum. All callers
4064 changed.
4065 (INTX): Remove.
4066 (mark_object): Use if, not #if, for GC_MARK_STACK.
4067 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4068 (XSAVE_OBJECT): Now functions, not macros.
4069 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4070 the constant was never used.
4071 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4072 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4073 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4074 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4075 New constants.
4076 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4077 type3 with a single member save_type. All uses changed.
4078 (save_type, set_save_pointer, set_save_integer): New functions.
4079 * print.c (PRINTX): Remove.
4080
d6723bf7
PE
4081 * alloc.c: Remove redundant static declarations.
4082
5f24fa51
DA
40832013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4084
4085 * window.h (struct window): Convert left_col, top_line, total_lines
4086 and total_cols from Lisp_Objects to integers. Adjust comments.
4087 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4088 Remove.
4089 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4090 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4091 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4092 Adjust users where appropriate.
4093
42143acd
DA
40942013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4095
4096 * frame.h (struct frame): Drop resx and resy because the same data is
4097 available from window system-specific output context. Adjust users.
562c6ee9
SM
4098 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4099 New functions to provide defaults when no window system available.
42143acd 4100 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4101 (NUMVAL): Move from xdisp.c.
42143acd
DA
4102 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4103 (Ffont_face_attributes, Fopen_font):
4104 * image.c (gs_load):
4105 * w32font.c (fill_in_logfont):
4106 * xdisp.c (calc_pixel_width_or_height):
4107 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4108 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4109
c0a17406
KH
41102013-03-20 Kenichi Handa <handa@gnu.org>
4111
4112 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4113 to 1 (temporary workaround until a bug related to ASCII
4114 optimization is fixed).
4115
095d384d
DA
41162013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4117
4118 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4119 Signal error if window is not internal. Adjust docstring.
4120 (delete_all_child_windows): Use combination_limit to save the buffer.
4121 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4122 * print.c (syms_of_print): Initialize debugging output not here...
4123 (init_print_once): ...but in a new function here.
4124 * lisp.h (init_print_once): Add prototype.
4125 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4126
748fa866
DA
41272013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4128
4129 * window.c (window_resize_check, window_resize_apply)
4130 (window_from_coordinates, recombine_windows, set_window_buffer)
4131 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4132 (Fsplit_window_internal, Fdelete_window_internal)
4133 (freeze_window_starts): Use bool for booleans.
4134 * window.h (window_frame_coordinates, resize_frame_windows)
4135 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4136
81519fd2
SM
41372013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4138
4139 * dispnew.c (bitch_at_user): Use `user-error'.
4140
6db423a9
KB
41412013-03-17 Ken Brown <kbrown@cornell.edu>
4142
4143 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4144 as return type of image_background. (Bug#13981)
4145 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4146
8f2906f5
JD
41472013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4148
960ce480 4149 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4150 (ns_select): Don't return with result uninitialized.
960ce480 4151
8f2906f5
JD
4152 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4153 and getDirectory.
4154
81519fd2
SM
4155 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4156 New functions.
8f2906f5
JD
4157 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4158 directories. If filename is nil, get directory name (Bug#13932).
4159 Use getFilename and getDirectory.
4160 (getFilename, getDirectory): New methods for EmacsSavePanel and
4161 EmacsOpenPanel.
4162 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4163
cded56c1
PE
41642013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4165
4166 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4167
251e9147 41682013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4169
4170 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4171 (adjust_after_replace): Make it back to static. Delete the third
4172 arg text_at_gap_tail. Cancel the code for handling it.
4173
4174 * coding.h (struct coding_system): New member eol_seen.
4175
4176 * coding.c (detect_ascii): New function.
4177 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4178 when the source bytes are actually scanned. On detecting for
4179 coding_category_utf_8_auto, call detect_ascii instead of scanning
4180 source bytes directly.
4181 (produce_chars): Call insert_from_gap with the new arg 0.
4182 (encode_coding): Likewise.
4183 (decode_coding_gap): Control ASCII optimization by the variable
4184 disable_ascii_optimization instead of #ifndef .. #endif.
4185 Deccode EOL format according to coding->eol_seen.
4186 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4187 variable.
4188
8a44e6d1
KH
4189 * lisp.h (adjust_after_replace): Cancel externing it.
4190 (insert_from_gap): Adjust prototype.
4191
5f795e34
EZ
41922013-03-15 Eli Zaretskii <eliz@gnu.org>
4193
4194 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4195 FULLSCREEN_MAXIMIZED. (Bug#13935)
4196
f258b4be
DA
41972013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4198
4199 * region-cache.c (find_cache_boundary, move_cache_gap)
4200 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4201 Simplify debugging check and convert to eassert. Adjust comment.
4202 (pp_cache): Put under ENABLE_CHECKING.
4203
a5cc4dde
EZ
42042013-03-14 Eli Zaretskii <eliz@gnu.org>
4205
4206 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4207 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4208 and WM_ACTIVATEAPP.
4209 (w32fullscreen_hook): If the frame is visible, reset
4210 f->want_fullscreen flag after changing the frame size. If the
4211 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4212 (Bug#13953)
4213
3fc5e44a
DC
42142013-03-13 Daniel Colascione <dancol@dancol.org>
4215
4216 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4217 too so that these builds can use Cygwin's file conversion
4218 functions. (We've been building and linking cygw32.o all along
4219 and just not using it.)
4220
47d7532e
PE
42212013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4222
4223 File synchronization fixes (Bug#13944).
4224 * Makefile.in (LIB_FDATASYNC): New macro.
4225 (LIBES): Use it.
4226 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4227 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4228 Don't worry about HAVE_FSYNC, since a substitute fsync is
4229 available if the system lacks one.
4230 (Fwrite_regin): Retry fsync if interrupted.
4231
c7ffccaf
EZ
42322013-03-13 Eli Zaretskii <eliz@gnu.org>
4233
4e2df81d 4234 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4235 activated, call w32fullscreen_hook, to make sure the new frame
4236 dimensions are in effect. (Bug#13937)
4237
8a7debc1
DA
42382013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4239
4240 * xdisp.c (init_iterator): Simplify because both character and byte
4241 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4242 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4243 character and byte positions can be obtained from marker.
8a7debc1 4244
7fd8c501
PE
42452013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4246
d9df6f40
PE
4247 Static checking by Sun C 5.12.
4248 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4249 * bytecode.c (exec_byte_code):
4250 * dispnew.c (init_display):
4251 * eval.c (error):
4252 * fileio.c (Fsubstitute_in_file_name):
4253 * keyboard.c (Fevent_convert_list):
4254 * keymap.c (Fsingle_key_description):
4255 * term.c (maybe_fatal, fatal):
4256 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4257 * xsmfns.c (Fhandle_save_session):
4258 Omit unreachable code.
4259 * keymap.c (map_keymap_char_table_item): Cast void * to
4260 a function pointer type; the C Standard requires this.
4261
7fd8c501
PE
4262 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4263 Include <sys/param.h> unconditionally, as that works elsewhere and
4264 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4265 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4266 and FreeBSD now.
4267
a020afb9 4268See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4269
4270;; Local Variables:
4271;; coding: utf-8
aac0c6e3
MR
4272;; End:
4273
ab422c4d 4274 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4275
4276 This file is part of GNU Emacs.
4277
4278 GNU Emacs is free software: you can redistribute it and/or modify
4279 it under the terms of the GNU General Public License as published by
4280 the Free Software Foundation, either version 3 of the License, or
4281 (at your option) any later version.
4282
4283 GNU Emacs is distributed in the hope that it will be useful,
4284 but WITHOUT ANY WARRANTY; without even the implied warranty of
4285 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4286 GNU General Public License for more details.
4287
4288 You should have received a copy of the GNU General Public License
4289 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.