* net/secrets.el (secrets-create-collection): Add optional
[bpt/emacs.git] / src / ChangeLog
CommitLineData
157fec2e
PE
12013-10-04 Paul Eggert <eggert@cs.ucla.edu>
2
4eed3157
PE
3 Use hardware support for byteswapping on glibc x86 etc.
4 On Fedora 19 x86-64, the new bswap_64 needs 1 instruction,
5 whereas the old swap64 needed 30.
6 * fringe.c (init_fringe_bitmap) [WORDS_BIGENDIAN]:
7 * sound.c (le2hl, le2hs, be2hl) [!WINDOWSNT]:
8 Use byteswap.h's macros to swap bytes.
9 * lisp.h (swap16, swap32, swap64): Remove.
10 All uses replaced by bswap_16, bswap_32, bswap_64.
11
157fec2e
PE
12 * bytecode.c (exec_byte_code): Use some more volatile variables
13 to work around local variables getting clobbered by longjmp.
14 Port to pre-C99, which doesn't allow decls after stmts.
15
b52f569d
PE
162013-10-03 Paul Eggert <eggert@cs.ucla.edu>
17
75273afb
PE
18 * lisp.h (eassert): Assume that COND is true when optimizing.
19 In other words, take on the behavior of eassert_and_assume.
20 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
21 (eassert_and_assume): Remove. All uses replaced by eassert.
22
ead45345
PE
23 * xdisp.c (Qglyphless_char): Now static.
24
0a858ebf
PE
25 Adjust to merge from gnulib.
26 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
27 * lisp.h: Include <verify.h>, for 'assume'.
28
b52f569d
PE
29 * eval.c (clobbered_eassert): New macro.
30 (internal_catch, internal_condition_case)
31 (internal_condition_case_1, internal_condition_case_2)
32 (internal_condition_case_n): Use it instead of eassert
33 when the argument contains locals clobbered by longjmp.
34 Don't use clobbered locals outside of clobbered_eassert.
35 (internal_lisp_condition_case): Use a volatile variable
36 to work around a local variable's getting clobbered.
37
adf2aa61
SM
382013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * lisp.h (struct handler): Merge struct handler and struct catchtag.
41 (PUSH_HANDLER): New macro.
42 (catchlist): Remove.
43 (handlerlist): Always declare.
44
45 * eval.c (catchlist): Remove (merge with handlerlist).
46 (handlerlist, lisp_eval_depth): Not static any more.
47 (internal_catch, internal_condition_case, internal_condition_case_1)
48 (internal_condition_case_2, internal_condition_case_n):
49 Use PUSH_HANDLER.
50 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
51 handlerlist/catchlist.
52 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
53 handlerlist which can only handle a single condition-case handler at
54 a time.
55 (find_handler_clause): Simplify since we only a single branch here
56 any more.
57
58 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
59 and Bpophandler.
60 (bcall0): New function.
61 (exec_byte_code): Add corresponding cases. Improve error message when
62 encountering an invalid byte-code. Let Bunwind_protect accept
63 a function (rather than a list of expressions) as argument.
64
65 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
66 and make them unconditional now that they're heap-allocated.
67
328a8179
SM
682013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
69
70 * charset.c (Fdecode_char, Fencode_char): Remove description of
71 `restriction' arg. now that it's hidden by advertised-calling-convention.
72
c348360a
JD
732013-10-02 Jan Djärv <jan.h.d@swipnet.se>
74
328a8179
SM
75 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
76 Remove unused variable (from mac-port).
c348360a
JD
77 (macfont_draw): Use s->ybase for correct y position.
78
1a23cd48
DA
792013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
80
81 * frame.h (struct frame): Drop has_minibuffer member because...
82 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
83 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
84
29bf4de4
DA
852013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
86
87 * window.h (struct window): Prefer enum text_cursor_kinds to int
88 for phys_cursor_type member. Move the latter, phys_cursor_width,
89 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
90 * window.c (replace_window, make_window): Adjust users.
91
a30ddace
DA
922013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
93
94 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
95 this module is never compiled otherwise.
96
45435f08
AA
972013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
98
99 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
100 (Bug#15500).
101
92e5298b
EZ
1022013-09-29 Eli Zaretskii <eliz@gnu.org>
103
104 * xdisp.c (get_next_display_element): Don't call face_for_font in
105 a build configured --without-x. (Bug#15484)
106
caa50be2
JD
1072013-09-29 Jan Djärv <jan.h.d@swipnet.se>
108
66d13b20
JD
109 * window.c (calc_absolute_offset): #elif should be #elif defined.
110
caa50be2
JD
111 * frame.c (delete_frame): Block/unblock input to overcome race
112 condition (Bug#15475).
113
d3e2acb6
AP
1142013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
115
116 * frame.c (delete_frame): Record selected frame only after
117 calling Qdelete_frame_functions (Bug#15477).
118
1610938f
JD
1192013-09-28 Jan Djärv <jan.h.d@swipnet.se>
120
121 * nsterm.m (ns_selection_color): Remove.
122 (ns_get_color): Check for ns_selection_(fg|bg)_color using
123 NSColor selectedText(Background)Color. Only for COCOA.
124 (ns_term_init): Remove assignment of ns_selection_color, logic
125 moved to ns_get_color.
126
328a8179 127 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
128 NS_SELECTION_COLOR_DEFAULT.
129 (NS_SELECTION_FG_COLOR_DEFAULT): New.
130
0d2647e6
EZ
1312013-09-28 Eli Zaretskii <eliz@gnu.org>
132
133 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
134 frame' does not have the tool_bar_window member.
135
ba355de0
BR
1362013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
137
138 Signal error when reading an empty byte-code object (Bug#15405)
139 * lread.c (read1): signal error
140 * alloc.c (make_byte_code): eassert header size
141 (sweep_vectors): change an int to size_t
142
4710d6f4
PE
1432013-09-24 Paul Eggert <eggert@cs.ucla.edu>
144
cf647d93
PE
145 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
146 instead of ints, as it's the usual style for offsetof constants. See:
147 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
148
4710d6f4
PE
149 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
150 This is ugly, but it should fix the performance problem for older
151 GCC versions in the short run. I'll look into integrating the
152 Gnulib module for popcount, as a better fix.
153 See the thread starting in:
154 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
155 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
156 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
157 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
158 (popcount_size_t): Use it.
159
10ebac9d
DC
1602013-09-24 Daniel Colascione <dancol@dancol.org>
161
162 * process.c (Fnetwork_interface_info): Fix build break due to
163 vector changes.
164
9da0f50e
PE
1652013-09-24 Paul Eggert <eggert@cs.ucla.edu>
166
167 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
168 Prefer signed to unsigned integers where either will do.
169 No need for 'const' on locals that do not escape.
170 Omit easserts with unnecessary and unportable assumptions about
171 alignment. Avoid unnecessary casts to char *.
172
d6d9cbc1
DA
1732013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
174
175 Use union for the payload of struct Lisp_Vector.
176 This helps to avoid a few glitches dictated by C's aliasing rules.
177 * lisp.h (struct Lisp_Vector): Use union for next and
178 contents member. Adjust comment. Change related users.
179 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
180 Related users changed.
181 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
182 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
183 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
184 * xfaces.c, xfont.c, xmenu.c: Related users changed.
185
ec7bc82f
DA
1862013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
187
188 Optimize glyph row clearing and copying routines.
189 * dispextern.h (struct glyph_row): Change layout of struct
190 glyph_row to help copy_row_except_pointers. Adjust comment.
191 * dispnew.c (null_row): Remove.
192 (clear_glyph_row): Use offsetof and memset to find and clear
193 just the members that need clearing. Adjust comment.
194 (copy_row_except_pointers): Likewise for copying.
195
d160dd0c
PE
1962013-09-24 Paul Eggert <eggert@cs.ucla.edu>
197
7be68de5
PE
198 Some minor cleanups of recently-added bool vector code.
199 * conf_post.h (assume): Always return void. Use lint version
200 only if GCC and MSC versions don't apply.
201 * conf_post.h (assume):
202 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
203 Depend on _MSC_VER, not __MSC_VER, for consistency with
204 the rest of Emacs.
205 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
206 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
207 (bool_vector_binop_driver, count_trailing_zero_bits)
208 (size_t_to_host_endian): Now static, not static inline;
209 the latter isn't needed with modern compilers and doesn't
210 work with older compilers anyway.
211
d160dd0c
PE
212 * alloc.c (valgrind_p): Use bool for boolean.
213
e08813d0
DA
2142013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
215
216 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
217 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
218 (display_last_displayed_message_p, message_buf_print)
219 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
220 Use bool for boolean.
3a6a78fd
DA
221 * dispextern.h (cancel_line, init_desired_glyphs):
222 Remove ancient leftover.
223 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
224 * lisp.h (noninteractive_need_newline): Adjust declaration.
225
5492865b
DA
2262013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
227
228 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
229 Move to...
230 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
231 ...this file and convert the latter to static. Adjust comment.
232 (make_initial_frame):
233 * window.c (init_window_once): Adjust user.
234 * frame.h (last_nonminibuf_frame): Remove declaration.
235 * lisp.h (selected_frame): Likewise.
236 * msdos.c (the_only_display_info): Adjust comment.
237
cd548fa4
EZ
2382013-09-23 Eli Zaretskii <eliz@gnu.org>
239
f03eddbf
EZ
240 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
241 computing the end column of mouse-highlight that comes from
242 display or overlay strings. (Bug#15437)
b519df23
EZ
243 (note_mouse_highlight): Adapt calculation of last argument to
244 mouse_face_from_string_pos to the above change.
f03eddbf 245
cd548fa4
EZ
246 * conf_post.h (__has_builtin): Define to zero, if undefined, on
247 all platforms, not just for clang.
248
8762e524
JD
2492013-09-23 Jan Djärv <jan.h.d@swipnet.se>
250
251 * filelock.c (lock_file_1): Rearrange to remove compiler warning
252 about excess arguments to snprintf.
253
254 * conf_post.h(assume): Use __builtin_unreachable for clang.
255
d4a9284f
JB
2562013-09-23 Juanma Barranquero <lekktu@gmail.com>
257
258 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
259 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
260
a84683fd
DC
2612013-09-23 Daniel Colascione <dancol@dancol.org>
262
263 * alloc.c (USE_VALGRIND): New macro; on by default
264 when ENABLE_CHECKING.
265 (mark_maybe_object,mark_maybe_pointer)
266 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
267 valgrind purposes.
268 (valgrind_p) [USE_VALGRIND]: New variable.
269 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
270
8fef36c6
JD
2712013-09-22 Jan Djärv <jan.h.d@swipnet.se>
272
fb83ea63
JD
273 * process.c (wait_reading_process_output): Change int pnamelen to
274 socklen_t.
275
276 * nsterm.m (setMarkedText:selectedRange:):
277 (deleteWorkingText):
278 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
279 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
280 argument to unsigned long to avoid warning.
281 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
282
8fef36c6
JD
283 * conf_post.h (assume): Fix compiler error: x shall be cond.
284
cd9356f2
DC
2852013-09-22 Daniel Colascione <dancol@dancol.org>
286
287 * xfns.c (x_get_monitor_attributes): Suppress unused variable
288 warning when compiling without a window system.
289
3e0b94e7
DC
2902013-09-22 Daniel Colascione <dancol@dancol.org>
291
292 * data.c (Qbool_vector_p): New symbol.
293 (bool_vector_spare_mask,popcount_size_t_generic)
294 (popcount_size_t_msc,popcount_size_t_gcc)
295 (popcount_size_t)
296 (bool_vector_binop_driver)
297 (count_trailing_zero_bits,size_t_to_host_endian)
298 (Fbool_vector_exclusive_or)
299 (Fbool_vector_union)
300 (Fbool_vector_intersection,Fbool_vector_set_difference)
301 (Fbool_vector_subsetp,Fbool_vector_not)
302 (Fbool_vector_count_matches)
303 (Fbool_vector_count_matches_at): New functions.
304 (syms_of_data): Intern new symbol, functions.
305 * alloc.c (bool_vector_payload_bytes): New function.
306 (Fmake_bool_vector): Instead of calling Fmake_vector,
307 which performs redundant initialization and argument checking,
308 just call allocate_vector ourselves. Make sure we clear any
309 terminating padding to zero.
310 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
311 instead of open-coding the size calculation.
312 (vroundup_ct): New macro.
313 (vroundup): Assume argument >= 0; invoke vroundup_ct.
314 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
315 * composite.c (composition_gstring_put_cache):
316 Change lint_assume to assume.
3e0b94e7
DC
317 * conf_post.h (assume): New macro.
318 (lint_assume): Remove.
319 * dispnew.c (update_frame_1): Change lint_assume to assume.
320 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
321 to assume.
322 * image.c (gif_load): Change lint_assume to assume.
323 * lisp.h (eassert_and_assume): New macro.
324 (Qbool_vector_p): Declare.
325 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
326 (swap16,swap32,swap64): New inline functions.
327 * macfont.c (macfont_shape): Change lint_assume to assume.
328 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
329 * xsettings.c (parse_settings): Use new swap16 and
330 swap32 from lisp.h instead of file-specific macros.
331
76880d88
EZ
3322013-09-22 Eli Zaretskii <eliz@gnu.org>
333
334 * xdisp.c (try_window_id): Don't abort if cursor row could not be
335 found (which can legitimately happen when the glyph row at the
336 window start is disabled in the current_matrix. (Bug#15365)
337
c6cfd910
PE
3382013-09-22 Paul Eggert <eggert@cs.ucla.edu>
339
340 Fix syntax.h bug introduced by recent INLINE change.
341 syntax.h defined an extern inline function SYNTAX_ENTRY that was
342 conditionally compiled one way in some modules, and a different
343 way in others. This doesn't work with extern inline functions,
344 which must have the same definition in all modules, because the
345 defining code might be shared across modules, depending on the
346 implementation. Symptoms reported by Martin Rudalics in:
347 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
348 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
349 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
350 overriding the corresponding functions in syntax.h.
351 * syntax.h (syntax_property_entry, syntax_property_with_flags)
352 (syntax_property): New inline functions.
353 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
354 Rewrite in terms of these new functions.
355
b3f1d119
EZ
3562013-09-21 Eli Zaretskii <eliz@gnu.org>
357
358 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
359 not chars_in_text, whose result depends on the multibyteness of
360 the current buffer. (Bug#15426)
361
00382e8b
PE
3622013-09-20 Paul Eggert <eggert@cs.ucla.edu>
363
e3b29769
PE
364 Port recent change to hosts where pointers aren't 'long'.
365 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
366 Don't assume that pointers are the same width as 'long'.
367 Add a compile-time check that a pointer fits into two X slots.
368
00382e8b
PE
369 A simpler, centralized INLINE.
370 * conf_post.h (INLINE): Define only if not already defined.
371 This allows us to use a single INLINE, defined by one file
372 per executable.
373 * emacs.c (INLINE): Define it.
374 Also, include category.h, charset.h, composite.h, dispextern.h,
375 syntax.h, systime.h, so that their INLINE definitions are expanded
376 properly for Emacs.
377 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
378 * buffer.h, buffer.c (BUFFER_INLINE):
379 * category.h, category.c (CATEGORY_INLINE):
380 * character.h, character.c (CHARACTER_INLINE):
381 * charset.h, charset.c (CHARSET_INLINE):
382 * composite.h, composite.c (COMPOSITE_INLINE):
383 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
384 * frame.h, frame.c (FRAME_INLINE):
385 * intervals.h, intervals.c (INTERVALS_INLINE):
386 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
387 * lisp.h, alloc.c (LISP_INLINE):
388 * process.h, process.c (PROCESS_INLINE):
389 * syntax.h, syntax.c (SYNTAX_INLINE):
390 * systime.h, sysdep.c (SYSTIME_INLINE):
391 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
392 * window.h, window.c (WINDOW_INLINE):
393 Remove. All uses replaced with INLINE.
394
2b943ba6
DA
3952013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
396
397 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
398 to avoid Bug#15398.
399
13d9698a
EZ
4002013-09-19 Eli Zaretskii <eliz@gnu.org>
401
402 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
403 'const char *' to avoid compiler warnings due to similar change in
404 the prototype of x_get_string_resource.
405
ced135eb
DA
4062013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
407
408 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
409 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
410 going to replace static variables below. Adjust comments.
411 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
412 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
413 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
414 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
415 Related users changed.
416 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
417 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
418 last_mouse_movement_time, going to replace static variables below.
419 Adjust comments.
420 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
421 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
422 Remove.
423 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
424 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
425 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
426 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
427 static variables below.
428 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
429 (last_mouse_scroll_bar): Remove.
430 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
431 (mouseExited): Related users changed.
432
091f1e1f
DA
4332013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
434
435 Do not use external array to process X scroll bar messages.
436 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
437 (x_send_scroll_bar_event): Pack window pointer into two slots
438 of XClientMessageEvent if we're 64-bit. Adjust comment.
439 (x_scroll_bar_to_input_event): Unpack accordingly.
440
582ed56c
DA
4412013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
442
443 Ifdef away recent changes which aren't relevant to NS port.
444 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
445 [!HAVE_NS]: Declare as such.
446 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
447 [!HAVE_NS]: Define as such.
448
18da0d8a
DA
4492013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
450
451 * frame.c (x_redo_mouse_highlight): New function
452 to factor out common code used in W32 and X ports.
453 * dispextern.h (x_redo_mouse_highlight): Add prototype.
454 * xterm.h (struct x_display_info):
455 * w32term.h (struct w32_display_info):
456 * nsterm.h (struct ns_display_info): New members
457 last_mouse_motion_frame, last_mouse_motion_x and
458 last_mouse_motion_y, going to replace static variables below.
459 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
460 (redo_mouse_highlight): Remove.
461 (note_mouse_movement, syms_of_xterm): Adjust user.
462 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
463 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
464 (redo_mouse_highlight): Remove.
465 (note_mouse_movement, syms_of_w32term): Adjust user.
466 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
467 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
468 Remove.
469 (note_mouse_movement, mouseMoved, syms_of_nsterm):
470 * nsfns.m (compute_tip_xy): Adjust user.
471
7a0c745a
DA
4722013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
473
474 * frame.c (x_mouse_grabbed): New function.
475 * dispextern.h (x_mouse_grabbed): Add prototype.
476 (last_mouse_frame): Remove declaration.
477 * xterm.h (struct x_display_info):
478 * w32term.h (struct w32_display_info):
479 * nsterm.h (struct ns_display_info): New member
480 last_mouse_frame, going to replace...
481 * xdisp.c (last_mouse_frame): ...global variable.
482 (note_tool_bar_highlight):
483 * w32term.c (w32_mouse_position, w32_read_socket):
484 * xterm.c (XTmouse_position, handle_one_xevent):
485 Use x_mouse_grabbed.
486 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
487
0791d107
DA
4882013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
489
490 * w32term.c (w32_read_socket): Avoid temporary
491 variables in a call to x_real_positions.
492 * xterm.c (handle_one_xevent): Likewise.
493
2cd98812
DA
4942013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
495
496 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
497 (x_icon_type): Remove prototype.
498 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
499 * frame.c (x_icon_type): Remove.
500 * w32term.c (x_make_frame_visible, x_iconify_frame):
501 * xterm.c (x_make_frame_visible, x_iconify_frame):
502 Use x_set_bitmap_icon to factor out common code.
503
a6c2ee1b
DA
5042013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
505
506 * dispextern.h (check_x_display_info, x_get_string_resource):
507 Declare here just once and unify the latter.
508 * frame.c (check_x_display_info, x_get_string_resource):
509 * nsterm.h (check_x_display_info):
510 * xrdb.c (x_get_string_resource):
511 * xterm.h (check_x_display_info): Remove prototypes.
512 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
513 * w32reg.c (x_get_string_resource): Likewise.
514 (w32_get_rdb_resource): Adjust user.
515
baed3603
DA
5162013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
517
518 * xterm.h (struct x_display_info): New member
519 x_pending_autoraise_frame, going to replace...
520 * xterm.c (pending_autoraise_frame): ...static variable.
521 (x_new_focus_frame, XTread_socket): Adjust users.
522 * w32term.h (struct w32_display_info): New member
523 w32_pending_autoraise_frame, going to replace...
524 * w32term.c (pending_autoraise_frame): ...global variable.
525 (x_new_focus_frame, w32_read_socket): Adjust users.
526
90582f05
GM
5272013-09-17 Glenn Morris <rgm@gnu.org>
528
529 * xdisp.c (message_dolog): If we create *Messages*,
530 switch it to messages-buffer-mode.
531
b7ad2f74
PE
5322013-09-17 Paul Eggert <eggert@cs.ucla.edu>
533
534 Don't overuse 'const' in types of locals.
535 * bidi.c (bidi_count_bytes):
536 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
537 (xg_event_is_for_scrollbar):
538 * xselect.c (x_handle_property_notify)
539 (x_handle_selection_notify, x_handle_dnd_message):
540 * xsettings.c, xsettings.h (xft_settings_event):
541 * xterm.c (x_handle_net_wm_state, handle_one_event)
542 (x_menubar_window_to_frame, x_detect_focus_change)
543 (construct_mouse_click, note_mouse_movement)
544 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
545 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
546 (handle_one_xevent, x_handle_net_wm_state):
547 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
548 (x_handle_dnd_message):
549 Avoid unnecessary 'const', typically the second 'const' in
550 'const foo * const arg', a 'const' that does not affect the API
551 and doesn't significantly help the human reader.
552
19452b86
DA
5532013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
554
555 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
556 only if Glib < 2.36.0.
557 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
558 * xsettings.c (init_gconf, init_gsettings): Do not check
559 for g_type_init.
1893694e
DA
560 * xterm.c (handle_one_xevent): Do not call to x_clear_area
561 if GTK >= 2.7.0.
33b83dd7 562 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 563
6434e343
JD
5642013-09-16 Jan Djärv <jan.h.d@swipnet.se>
565
3f386383
JD
566 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
567 before calling g_type_init.
568
6434e343
JD
569 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
570
571 * nsterm.m (syms_of_nsterm): ... to here.
572
83a119f8
DA
5732013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
574
575 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
576 (ignore_next_mouse_click_timeout): Use Time as X does.
577 (handle_one_xevent): Avoid cast and use unsigned comparison.
578
61582e6a
DA
5792013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
580
581 Do not copy X event in handle_one_xevent except KeyPress case.
582 Wnen XEvent is processed, it is unlikely to be changed except
583 KeyPress case, so we can avoid copying and use const pointer to
584 const data to make sure that an event is not changed elsewhere.
585 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
586 const' and do not create local copy except for the KeyPress event.
587 Use casts to avoid a few glitches. Adjust formatting. Add comments.
588 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
589 (x_handle_net_wm_state, x_menubar_window_to_frame)
590 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
591 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
592 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
593 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
594 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
595 (x_handle_dnd_message):
596 * xsettings.c (xft_settings_event):
597 Use 'const XEvent * const' where appropriate.
598 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
599
f8eb1572
DA
6002013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
601
602 Fix X event waiting to handle multiple frames.
603 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
604 * xterm.c (pending_event_wait): Remove. Adjust users.
605 (x_detect_focus_change): Pass frame arg.
606 (handle_one_xevent): Find related frame early and clear per-frame
607 wait_event_type only if this is an event for the relevant frame.
608 (x_wait_for_event): Use per-frame wait_event_type.
609
3fa2054e
JD
6102013-09-15 Jan Djärv <jan.h.d@swipnet.se>
611
745d3809
JD
612 * nsfns.m (Fx_create_frame): Fix font driver registration for
613 GNUStep.
614
615 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
616 for syms_of_macfont.
617
3fa2054e
JD
618 * nsterm.m: Include macfont.h.
619 (ns_tmp_flags, ns_tmp_font): Remove.
620 (ns_compute_glyph_string_overhangs): Check for driver Qns.
621 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
622 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
623 (changeFont:): Fix code style. Check for font driver type when
624 getiing font.
625
626 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
627 (f)->descent.
628
629 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
630 (nsfont_open): Set font driver type.
631 Set font->ascent and font->descent. Figure out font instead of
632 ns_tmp_font, and flags instead of ns_tmp_flags.
633 Fix indentation. Remove call to ns_draw_text_decoration,
634 moved to nsterm.
635
636 * nsfns.m: Include macfont.h.
637 (Fx_create_frame): Register macfont driver, make a better default font.
638 (Fns_popup_font_panel): Get font from macfont driver, if used.
639
640 * macfont.m, macfont.h, maccuvs.h: New files.
641
642 * font.h: Declare syms_of_macfont.
643
644 * font.c (syms_of_font): Call syms_of_macfont.
645
646 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
647
0eed0355
DA
6482013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
649
650 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
651 and it is always zero for others, so I assume that this is an ancient
652 leftover which nobody will want to change any more.
653 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
654 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
655 * frame.c (x_set_scroll_bar_width):
656 * w32fns.c (w32_createscrollbar):
657 * w32term.c (w32_set_vertical_scroll_bar):
658 * xfns.c (x_set_scroll_bar_default_width):
659 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
660 (x_scroll_bar_expose): Related users changed.
661
07013c68
DA
6622013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
663
664 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
665 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
666 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
667 Define as such.
c7cc32f7
DA
668 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
669 Define once here...
670 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
671 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
672 Remove unused Xisms.
7f09455e
DA
673 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
674 these modules are never compiled otherwise.
07013c68 675
0df00f59
EZ
6762013-09-14 Eli Zaretskii <eliz@gnu.org>
677
08a209bf 678 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
679 Doc fix. (Bug#15375)
680
fcd42c11
DA
6812013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
682
683 Unify Fx_focus_frame between all ports.
684 * frame.h (x_focus_frame): New prototype.
685 * xfns.c (Fx_focus_frame): Remove.
686 (syms_of_xfns): Do not defsubr it.
687 (x_focus_frame): X implementation.
688 * nsfns.m (Fx_focus_frame): Remove.
689 (syms_of_nsfns): Do not defsubr it.
690 (x_focus_frame): NS implementation.
691 * w32term.c (Fx_focus_frame): Remove.
692 (x_focus_on_frame): Rename to...
693 (x_focus_frame): W32 implementation.
694 * w32term.h (x_focus_on_frame): Remove prototype.
695 * w32fns.c (Fx_focus_frame): Remove.
696 (syms_of_w32fns): Do not defsubr it.
697 * frame.c (Fx_focus_frame): Define here.
698 (syms_of_frame): Defsubr here.
699 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
700
aad3612f
DA
7012013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
702
703 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
704 All of them are replaced with FRAME_DISPLAY_INFO, defined in
705 each port to reference the port-specific window system data.
706 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
707 (FRAME_DISPLAY_INFO): Define.
708 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
709 (FRAME_DISPLAY_INFO): Define. Adjust users.
710 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
711 (FRAME_DISPLAY_INFO): Define. Adjust users.
712 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
713 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
714 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
715 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
716 * xselect.c, xterm.c: All related users changed.
717
9a650e62
DA
7182013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
719
720 * xterm.h (x_window_to_frame, x_any_window_to_frame)
721 (x_menubar_window_to_frame): Remove prototypes.
722 * xfns.c (x_window_to_frame, x_any_window_to_frame)
723 (x_menubar_window_to_frame, x_top_window_to_frame):
724 Move from here...
725 * xterm.c (x_window_to_frame, x_any_window_to_frame)
726 (x_menubar_window_to_frame, x_top_window_to_frame):
727 ...to here and convert all but the last to static.
728
347ae3e1
EZ
7292013-09-12 Eli Zaretskii <eliz@gnu.org>
730
731 * lisp.mk (lisp): Add w32-common-fns.elc.
732
15c6d837
XF
7332013-09-12 Xue Fuqiao <xfq.free@gmail.com>
734
735 * charset.c (char_charset): Document an exception for char-charset.
736
27e90f77
DA
7372013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
738
739 * xterm.h (x_display_info): New field last_user_time...
740 * xterm.c (toplevel): ...to replace static last_user_time.
741 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
742
8ffbc36b
DA
7432013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
744
745 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
746 scroll bar values to prevent thumb from disappear and update comment.
747
5ec0337a
GM
7482013-09-11 Glenn Morris <rgm@gnu.org>
749
750 * emacs.c (usage_message): Possessive apostrophe tweak.
751
fb55b9d1
DA
7522013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
753
8d2db8be
DA
754 * nsterm.m (syms_of_nsterm): Use Qns.
755 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
756 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
757 * xfns.c (x_display_info_for_name, Fx_open_connection):
758 Remove old '#if 0' code.
759 (syms_of_xfns): Use Qx.
fb55b9d1
DA
760 * termhooks.h (fullscreen_hook): Remove the leftover.
761 (struct terminal): Fix typo in comment.
762
927eec55
DA
7632013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
764
765 Cleaning up a few X scroll bar bits.
766 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
767 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
768 New member last_seen_part, going to replace...
769 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
770 (xt_action_hook) [USE_LUCID]: Adjust user.
771 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
772 Lucid-specific scroll bar support.
773 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
774 to int and adjust to use last_seen_part member.
775 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
776 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
777 Initialize last_seen_part.
778
71b28baa
SM
7792013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
780
781 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
782 insert-buffer-substring an empty string.
783
f5dacaae
PE
7842013-09-11 Paul Eggert <eggert@cs.ucla.edu>
785
786 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
787 avoiding a GCC warning.
788
742516e0
DA
7892013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
790
791 Ifdef away frame tool bar code when it is not really used.
792 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
793 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
794 and minimize_tool_bar_window_p under the above.
795 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
796 (fset_tool_bar_window): Likewise.
797 * dispnew.c (clear_current_matrices, clear_desired_matrices)
798 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
799 (change_frame_size_1):
800 * window.c (window_from_coordinates, Frecenter): Adjust users.
801 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
802 code is not really used.
803 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
804 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
805 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
806 [!USE_GTK && !HAVE_NS]: Define as such.
807 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
808 (note_mouse_highlight, expose_frame):
809 * xfns.c (x_set_tool_bar_lines):
810 * xterm.c (handle_one_xevent): Adjust users.
811
73f82c7e
PE
8122013-09-11 Paul Eggert <eggert@cs.ucla.edu>
813
814 Fix corruption with multiple emacsclient -t instances (Bug#15222).
815 This bug was introduced by my 2013-08-26 patch, which incorrectly
816 assumed that the terminfo implementation doesn't use termcap buffers.
817 * term.c (init_tty) [TERMINFO]: Remove optimization, as
818 these buffers apparently are used after all.
819 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
820 (struct tty_display_info): Define members termcap_term_buffer and
821 termcap_strings_buffer even if TERMINFO.
822
53482f41
DA
8232013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
824
825 Fix last change.
826 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
827 'usage' docstring entry to pacify make-docfile.
828
8292013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
830
831 Change comparison functions =, <, >, <=, >= to take many arguments.
832 * data.c: Change comparison functions' interface and implementation.
833 * lisp.h: Make arithcompare available for efficient two arg
834 comparisons.
835 * bytecode.c: Use arithcompare.
836 * fileio.c: Use new interface.
837
533f258f
SM
8382013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
839
840 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
841
8c27f5ff
SM
8422013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * eval.c (Feval): Document the new use of `lexical'.
845
0750a308
DA
8462013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
847
848 Review and drop old frame resize hack.
849 * frame.h (struct frame): Remove force_flush_display_p.
850 * dispnew.c (update_frame): Adjust user and don't call
851 flush_frame here. The comment has said that there was an issues
852 with redisplaying fringes, but I don't see any differences with
853 and without this hack. Hopefully we can continue without it.
854 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
855 current frame matrices twice if resized_p is set.
856
83fc0554
DA
8572013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
858
859 Do not populate pure Xism x_sync to other ports.
860 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
861 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
862 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
863 * w32term.h (x_sync): Remove prototype.
864
fd462129
DA
8652013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
866
867 Cleanup frame flushing.
8c27f5ff
SM
868 * dispextern.h (struct redisplay_interface):
869 Drop flush_display_optional because flush_display is enough
fd462129
DA
870 for X and flushing via RIF is just a no-op for others.
871 * frame.h (flush_frame): New function.
872 * dispnew.c (update_frame):
873 * minibuf.c (read_minibuf):
874 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
875 Use it.
876 * keyboard.c (detect_input_pending_run_timers): Do not flush
877 all frames but selected one in redisplay_preserve_echo_area.
878 * nsterm.m (ns_flush): Remove no-op.
879 (ns_redisplay_interface): Adjust user.
880 * w32term.h (x_flush): Remove no-op.
881 (w32_redisplay_interface): Adjust user.
882 * xterm.c (x_flush): Simplify because we do not flush all
883 frames at once any more. Adjust comment.
884 (x_redisplay_interface): Adjust user.
885
4b73fc73
PE
8862013-09-07 Paul Eggert <eggert@cs.ucla.edu>
887
888 Port --without-x --enable-gcc-warnings to Fedora 19.
889 * gfilenotify.c (globals_of_gfilenotify):
890 Call g_type_init only if using an older glib version that needs it.
891
77394d40
DA
8922013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
893
894 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
895 (last_glyphless_glyph_merged_face_id): Remove declarations.
896 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
897 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
898 (last_glyphless_glyph_merged_face_id): Now static.
899 (merge_escape_glyph_face): New function, refactored from...
900 (get_next_display_element): ...here.
901 (merge_glyphless_glyph_face): New function, refactored from...
902 (produce_glyphless_glyph): ...here...
903 * term.c (produce_glyphless_glyph): ...and here.
904
306d67bd
SM
9052013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
906
907 * eval.c (eval_sub): Only call Ffunction if necessary.
908
7f6c6450
DA
9092013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
910
911 Attempt to make redisplay more selective when changing cursor type.
912 * frame.h (struct frame): New bitfield cursor_type_changed.
913 * xdisp.c (cursor_type_changed): Remove.
914 (try_cursor_movement, redisplay_window, try_window_id)
915 (set_frame_cursor_types, try_window_reusing_current_matrix):
916 Adjust to use per-frame bitfield.
917 (redisplay_internal): Look for cursor type change on each visible
918 frame and consider all frames if cursor type has been changed on
919 the frame other than selected. If cursor type has been changed on
920 selected frame only, do not use fast update.
921
bd0443bb
DA
9222013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
923
924 Attempt to make redisplay more selective when changing fonts.
925 * frame.h (struct frame): New bitfield fonts_changed.
926 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
927 (adjust_frame_glyphs): Add prototype.
928 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 929 (adjust_glyphs): Remove because we do not
bd0443bb
DA
930 adjust matrices on all frames at once any more.
931 (adjust_frame_glyphs): Block and unblock input here.
932 (adjust_glyph_matrix): Use fonts_changed.
933 (change_frame_size_1): Use adjust_frame_glyphs.
934 * font.c (font_open_entity): Use fonts_changed.
935 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
936 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
937 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
938 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
939 (shrink_mini_window, Fresize_mini_window_internal)
940 (window_scroll_pixel_based, Fset_window_configuration)
941 (apply_window_adjustment, Fset_window_vscroll):
942 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
943 Use adjust_frame_glyphs.
944 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
945 (try_window_reusing_current_matrix, try_window_id, display_line)
946 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
947 (redisplay_internal): Consider fonts_changed and adjust frame
948 matrices for each frame only if the frame is visible. If font
949 has been changed on some frame during full redisplay, retry
950 only visible frames where the font has been actually changed.
951
b9695828
DA
9522013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
953
954 Cache current header and mode line height for each window.
955 * window.h (struct window): New fields mode_line_height
956 and header_line_height.
957 * window.c (make_window): Initialize them.
958 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
959 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
960 (current_mode_line_height, current_header_line_height):
961 Remove declaration.
962 * xdisp.c (current_mode_line_height, current_header_line_height):
963 Remove.
964 (pos_visible_p, init_xdisp): Adjust user.
965 (redisplay_window): Invalidate mode_line_height and
966 header_line_height if current and desired matrices do not agree.
967
66738305
DA
9682013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
969
970 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
971 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
972
257b3b03
DA
9732013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
974
975 Make --without-x compatible with --enable-gcc-warnings.
976 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
977 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
978 members under HAVE_WINDOW_SYSTEM.
979 * keyboard.c (make_lispy_focus_out): Likewise.
980 (record_menu_key): Move under HAVE_MENUS.
981 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
982 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
983 (syms_of_xdisp): Adjust user.
984 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
985 (start_hourglass, cancel_hourglass):
986 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
987 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
988 and CLEAR_FONT_TABLE_NFONTS.
989 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
990 Declare only if HAVE_WINDOW_SYSTEM.
991 (lface_same_font_attributes_p, clear_face_gcs): Define only
992 if HAVE_WINDOW_SYSTEM.
993
98b7f4bd
DA
9942013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
995
996 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
997 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
998 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
999
a7e43722
SM
10002013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
1001
1002 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
1003
0c90b9ee
PE
10042013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
1007 This fixes a type error on hosts where ptrdiff_t is wider than int.
1008
d99760fa
SM
10092013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1010
6629638e
SM
1011 * keyboard.c (read_key_sequence_vs): New function.
1012 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
1013 common code.
1014
d99760fa
SM
1015 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1016
224e313d
PE
10172013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1018
1019 Makefile improvements.
1020 * Makefile.in (config.status): Don't use double-colon rules, as
1021 they are not portable according to POSIX. Fix shell typo with `;
1022 I guess this rule has never been tested?
1023 (VCSWITNESS): New macro, to override any environment var.
1024
6d6ed1af
DA
10252013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1026
1027 * xterm.h (struct x_display_info): Do not track X connection
1028 fd separately because it is always available from Display.
1029 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1030 Adjust users.
1031
bc923770
DA
10322013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1033
1034 * buffer.c (drop_overlay):
1035 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1036 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1037
b1cf96de
DA
10382013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1039
1040 * buffer.c (Fmake_overlay, Fmove_overlay):
1041 * intervals.c (set_point_from_marker):
1042 * print.c (PRINTPREPARE): Prefer signal_error
1043 to plain error and report unsuitable marker too.
1044
d1fc6c21
DA
10452013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1046
1047 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1048 for 'dragging' member.
d1ae6a0b
DA
1049 (struct x_output): Remove set-but-unused leftovers
1050 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1051 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1052 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1053 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1054 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1055 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1056 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1057 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1058 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1059
0ce9f6de
JD
10602013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1061
1062 * nsfont.m (INVALID_GLYPH): New define.
1063 (nsfont_encode_char): Use INVALID_GLYPH.
1064 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1065
b594a96c
DA
10662013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1067
1068 * xterm.c (x_last_mouse_movement_time): Revert last change.
1069 This code should use XDisplayMotionBufferSize to check display's
1070 motion history first, and there are few other issues as well.
1071 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1072 (handle_one_xevent): Adjust user.
1073
8b098236
MR
10742013-09-02 Martin Rudalics <rudalics@gmx.at>
1075
9718b207
MR
1076 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1077 * frame.c (Flast_nonminibuf_frame): ... to here.
1078 (check_minibuf_window): Don't abort if no window was found
1079 (Bug#15247).
8b098236 1080
84e70bba
DA
10812013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1082
1083 Use XGetMotionEvents to ask the last mouse motion time from X server.
1084 * xterm.c (X_MOTION_HISTORY): Default to 1.
1085 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1086 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1087 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1088 Ifdef away legacy code.
1089 (XTmouse_position, x_scroll_bar_report_motion):
1090 Use x_last_mouse_movement_time.
fc85e20b
DA
1091 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1092 UnmapNotify event.
84e70bba 1093
1fccc530
DA
10942013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1095
1096 * msdos.c (last_mouse_window): Move to...
1097 (dos_rawgetc): ...this function and adjust comment.
1098 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1099 (mouseMoved): ...this function and adjust comment.
1100 * w32term.c (last_window): Likewise with...
1101 (w32_read_socket): ...this function.
1102 * xterm.c (last_window): Likewise with...
1103 (handle_one_xevent): ...this function.
1104
0ab10992
DA
11052013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1106
b7da754d 1107 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1108 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1109 (handle_one_xevent): ...to here.
1110 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1111 otherwise.
1112
0c7f856e
DA
11132013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 * msdos.c (IT_set_terminal_window): Remove no-op.
1116 (initialize_msdos_display): Adjust terminal setup.
1117 * w32console.c (w32con_set_terminal_window): Remove no-op.
1118 (initialize_w32_display): Adjust terminal setup.
1119 * w32term.c (w32_set_terminal_window): Remove no-op.
1120 (w32_create_terminal): Adjust terminal setup.
1121 * xterm.c (XTset_terminal_window): Remove no-op.
1122 (x_create_terminal): Adjust terminal setup.
1123
a892a94c
DA
11242013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1125
1126 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1127 Remove no-ops.
1128 (ns_create_terminal): Adjust terminal setup.
1129 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1130 Remove no-ops.
1131 (w32_create_terminal): Adjust terminal setup.
1132 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1133 Remove no-ops.
1134 (x_create_terminal): Adjust terminal setup.
1135
cf91889a
DA
11362013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1137
1138 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1139 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1140 * dispnew.c (buffer_posn_from_coords):
1141 * window.c (Fwindow_end, displayed_window_lines):
1142 * xdisp.c (redisplay_mode_lines): Use it.
1143
5b0891df
JD
11442013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1145
1146 * fontset.c (face_for_char): Check char in the current face font first
1147 if HAVE_NS (Bug#15138).
1148
0a357e98
MR
11492013-08-31 Martin Rudalics <rudalics@gmx.at>
1150
1151 * window.c (temp_output_buffer_show): Make sure window returned
1152 by display_buffer is live (Bug#15213).
1153
9d7693d7
DA
11542013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1155
1156 Minor cleanup to avoid forward declarations.
1157 * coding.h (struct ccl_spec): Remove forward declaration.
1158 * composite.h (toplevel): Include font.h.
1159 (struct composition_it, struct face, struct font_metrics):
1160 Remove forward declaration.
1161 * dispextern.h (struct image, struct atimer): Likewise.
1162 * emacsgtkfixed.h (struct frame): Likewise.
1163 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1164 * font.h (struct font_driver, struct font, struct glyph_string)
1165 (struct face): Remove forward declaration.
1166 * fontset.h (struct face, struct font): Likewise.
1167 * frame.h (toplevel): Style cleanup.
1168 (enum output_method): Move to...
1169 * termhooks.h (enum output_method): ...here.
1170 (struct glyph, struct frame, struct ns_display_info)
1171 (struct x_display_info, struct w32_display_info):
1172 Remove forward declaration.
1173 * xterm.h (toplevel): Include termhooks.h.
1174 (struct font, struct window, struct glyph_matrix, struct frame)
1175 (struct input_event, struct face, struct image): Remove forward
1176 declaration.
1177 * gtkutil.h (struct _widget_value): Likewise.
1178 * keyboard.h (toplevel): Include termhooks.h.
1179 (struct input_event): Remove forward declaration.
1180
032f7451
DA
11812013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 * intervals.c (set_point_from_marker): New function.
1184 * editfns.c (Fgoto_char):
1185 * process.c (Finternal_default_process_filter):
1186 * window.c (select_window_1): Use it.
1187 * buffer.h (set_point_from_marker): Add prototype.
1188
3f940c5a
EZ
11892013-08-29 Eli Zaretskii <eliz@gnu.org>
1190
1191 * w32.c (term_winsock): Call release_listen_threads before calling
1192 WSACleanup.
1193 (_sys_wait_accept): Wait for accept event in a loop with a finite
1194 timeout, instead of waiting indefinitely. Will hopefully avoid
1195 hanging during exit because WSACleanup deadlocks waiting for the
1196 event object to be released. (Bug#14333)
1197
1198 * w32proc.c (release_listen_threads): New function, signals all
1199 the reader threads that listen for connections to stop waiting.
1200
1201 * w32.h (release_listen_threads): Add prototype.
1202
101ed2bb
DA
12032013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1204
1205 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1206 field of new marker (for sanity and safety).
20de2834
DA
1207 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1208 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1209
1f5cf200
DA
12102013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1211
1212 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1213 (x_after_update_window_line, x_scroll_bar_create):
1214 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1215 (handle_one_xevent, x_clear_frame_area):
1216 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1217 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1218 * xterm.h (x_clear_area): Adjust prototype.
1219
d2b36813
DA
12202013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1221
1222 Hook scanning and indentation functions to find_newline. This helps
1223 to avoid duplicated code and renders more respect to newline cache.
1224 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1225 * cmds.c (Fforward_line):
1226 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1227 Use find_newline and avoid unnecessary point movements.
1228 * search.c (scan_newline): Implement on top of find_newline.
1229
3ec7babc
SM
12302013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1231
1232 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1233 scoped code (bug#11258).
1234
5ab473cd
JD
12352013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1236
1237 * nsterm.m (last_window): New variable.
1238 (EV_TRAILER2): New macro.
1239 (EV_TRAILER): Call EV_TRAILER2.
1240 (mouseMoved:): Add support for mouse-autoselect-window
1241 on nextstep (Bug#6888).
1242
78779650
AS
12432013-08-28 Andreas Schwab <schwab@suse.de>
1244
1245 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1246 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1247 Remove unused macro definitions.
1248 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1249 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1250 Only define if emacs.
78779650 1251
c3c4768d
DA
12522013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1253
1254 Prefer enum glyph_row_area to int where appropriate.
1255 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1256 Fix comment.
1257 (window_box, window_box_width, window_box_left, window_box_left_offset)
1258 (window_box_right, window_box_right_offset): Adjust prototypes.
1259 * xdisp.c (window_box, window_box_width, window_box_left)
1260 (window_box_left_offset, window_box_right, window_box_right_offset):
1261 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1262 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1263 * nsterm.m (ns_clip_to_row):
1264 * w32term.c (w32_clip_to_row):
1265 * xterm.c (x_clip_to_row): Likewise.
1266
6bdcbfe1
DA
12672013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1268
1269 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1270 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1271
50b13cde
PE
12722013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1275 for portability to hosts where /bin/sh has problems.
1276
f60e429a
DA
12772013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1278
1279 Redesign redisplay interface to drop global output_cursor.
1280 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1281 (toplevel): Remove declaration of output_cursor.
1282 (set_output_cursor, x_cursor_to): Remove prototype.
1283 * window.h (struct window): New member output_cursor.
1284 (output_cursor_to): New function to replace RIF member.
1285 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1286 (update_text_area, set_window_cursor_after_update): Use it.
1287 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1288 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1289 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1290 * w32term.c (x_update_window_begin, x_update_window_end):
1291 * xterm.c (x_update_window_begin, x_update_window_end):
1292 Adjust to use per-window output cursor.
1293
43aac990
PE
12942013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1295
d486344e
PE
1296 Simplify SELECT_TYPE-related code.
1297 Like EMACS_TIME, this portability layer is no longer needed, since
1298 Emacs has been using fd_set as a portability layer for some time.
1299 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1300 (SELECT_TYPE): Remove. All uses changed to fd_set.
1301 (fd_set) [!FD_SET]: New typedef.
1302
43aac990
PE
1303 Simplify EMACS_TIME-related code.
1304 This portability layer is no longer needed, since Emacs has been
1305 using struct timespec as a portability layer for some time.
1306 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1307 Include <time.h> rather than "systime.h"; that's all that's needed now.
1308 * dispnew.c: Include <timespec.h> rather than "systime.h";
1309 that's all that's needed now.
1310 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1311 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1312 TIMESPEC_RESOLUTION.
1313 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1314 LOG10_TIMESPEC_RESOLUTION.
1315 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1316 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1317 (make_emacs_time): Remove. All used changed to make_timespec.
1318 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1319 (current_timespec): Rename from current_emacs_time. All uses changed.
1320 (add_emacs_time): Remove. All uses changed to timespec_add.
1321 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1322 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1323 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1324 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1325 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1326 (current_timespec): Rename from current_emacs_time. All uses changed.
1327 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1328 changed to timespec_cmp.
1329 * xgselect.c: Include <timespec.h>, since our .h files don't.
1330
d350e350
DA
13312013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1332
1333 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1334 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1335 Remove the leftovers.
1336 * gtkutil.c (toplevel): Do not declare Qxft but include
1337 font.h to do so.
1338 * image.c (toplevel): Do not declare Vlibrary_cache because
1339 it's already done in lisp.h.
1340
9fed9729
DA
13412013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1342
1343 * lisp.h (Mouse_HLInfo): Move from here...
1344 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1345 (reset_mouse_highlight): New function.
1346 * msdos.c (dos_set_window_size, IT_update_begin)
1347 (internal_terminal_init):
1348 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1349 (ns_initialize_display_info):
1350 * w32console.c (initialize_w32_display):
1351 * w32term.c (x_update_window_end, x_free_frame_resources)
1352 (w32_initialize_display_info):
1353 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1354 * window.c (Fdelete_other_windows_internal):
1355 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1356 * termchar.h (toplevel):
1357 * xterm.h (toplevel): Include dispextern.h.
1358
f462f075
PE
13592013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 Fix minor problems found by static checking.
1362 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1363 (expect): Avoid nested-if warning.
1364 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1365 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1366 * nsterm.h, nsterm.m (ns_select):
1367 * xgselect.c, xgselect.h (xg_select):
1368 Adjust signature to better match pselect's.
1369 * nsterm.m (ns_select):
1370 Don't set *TIMEOUT, since pselect doesn't.
1371 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1372 diagnostic about assigning const char * to it.
1373 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1374
068f9124
SM
13752013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1376
1377 * lread.c (substitute_object_recurse): Handle hash-tables as well
1378 (bug#15190).
1379
f5adc984
PE
13802013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1381
1fc8eb33
PE
1382 Fix unlikely core dump in init_tty, and simplify terminfo case.
1383 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1384 The old version incorrectly dumped core if malloc returned a
1385 buffer containing only non-NUL bytes.
1386 (init_tty): Do not allocate or free termcap buffers; the
1387 struct does that for us now.
1388 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1389 (struct tty_display_info): Define members termcap_term_buffer and
1390 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1391 use them. Allocate them directly in struct rather than indirectly
1392 via a pointer, to simplify init_tty.
1393
f5adc984
PE
1394 * frame.c (check_minibuf_window): Initialize 'window' properly,
1395 so that Emacs reliably aborts later if 'window' is not initialized.
1396
efec3894
JD
13972013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1398
1399 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1400 of VoidSymbol (Bug#15154).
1401
e1d0341e
DA
14022013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1403
1404 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1405 mouse_face_beg_y and mouse_face_end_y.
1406 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1407 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1408 Adjust users and update comment where appropriate.
1409
bfff6445
MR
14102013-08-26 Martin Rudalics <rudalics@gmx.at>
1411
1412 * frame.c (check_minibuf_window): New function.
068f9124
SM
1413 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1414 Call check_minibuf_window (Bug#15183).
bfff6445 1415
c80016b3
DA
14162013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1417
1418 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1419 because this is the only last cursor data we need to keep and consult.
1420 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1421 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1422 Adjust users.
1423
de396731
DA
14242013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1425
068f9124
SM
1426 Fix recovering from possible decompression error.
1427 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1428 the position where the partially decompressed data ends, and
447218dd 1429 should count how many bytes was produced so far.
de396731
DA
1430 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1431 (unwind_decompress): Really delete partially uncompressed data.
1432 (Fzlib_decompress_region): Take decompressed data size into account.
1433
c76826d9
DA
14342013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 * syntax.c (init_syntax_once): Adjust comment and do an early
1437 initialization of Qchar_table_extra_slots just once...
1438 * casetab.c (init_casetab_once):
1439 * category.c (init_category_once):
1440 * character.c (syms_of_character):
1441 * coding.c (syms_of_coding):
1442 * xdisp.c (syms_of_xdisp): ...and omit it here.
1443
b34454d0
EZ
14442013-08-24 Eli Zaretskii <eliz@gnu.org>
1445
11f20add
EZ
1446 * xdisp.c (get_next_display_element): Don't apply to characters
1447 from a display vector the logic of setting it->end_of_box_run_p
1448 suitable for characters from a buffer. (Bug#15175)
1449
b34454d0
EZ
1450 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1451 to handle directories, rather than '_utime' which doesn't.
1452 (Bug#15176)
1453
6e1b469e
JD
14542013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1455
1456 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1457 or fullscreen (Bug#14627).
1458
9c05bccf
PE
14592013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 System-dependent integer overflow fixes.
1462 * process.c (Fset_process_window_size): Signal an error if
1463 the window size is outside the range supported by the lower level.
1464 * sysdep.c (set_window_size): Return negative on error,
1465 nonnegative on success, rather than -1, 0, 1 on not in system,
1466 failure, success. This is simpler. Caller changed.
1467 (serial_configure): Remove unnecessary initialization of local.
1468 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1469 size fits in unsigned long; this isn't true on some 32-bit hosts.
1470 Avoid buffer overrun if some future version of /proc/meminfo has a
1471 variable name longer than 20 bytes.
1472 (system_process_attributes) [__FreeBSD__]:
1473 Don't assume hw.availpages fits in 'int'.
1474
c365c355
PE
14752013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 Don't let very long directory names overrun the stack.
1478 Fix some related minor problems involving "//", vfork.
1479 * callproc.c (encode_current_directory): New function.
1480 (call_process): Don't append "/"; not needed.
1481 * fileio.c (file_name_as_directory_slop): New constant.
1482 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1483 this can save the caller having to alloca.
1484 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1485 Use SAFE_ALLOCA, not alloca.
1486 (directory_file_name, Fexpand_file_name): Leave leading "//"
1487 alone, since it can be special even on POSIX platforms.
1488 * callproc.c (call_process):
1489 * process.c (Fformat_network_address):
1490 * sysdep.c (sys_subshell):
1491 Use encode_current_directory rather than rolling our own.
1492 (create_process): No need to encode directory; caller does that now.
1493 * process.h (encode_current_directory): New decl.
1494 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1495 Rework to avoid 'goto xyzzy;'.
1496
6c6014d4
EZ
14972013-08-23 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (handle_face_prop): If the default face was remapped use
1500 the remapped face for strings from prefix properties. (Bug#15155)
1501
9997ec56
DA
15022013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1503
1504 Minor cleanup for redisplay interface and few related functions.
1505 * frame.h (enum text_cursor_kinds): Move from here...
1506 * dispextern.h (enum text_cursor_kinds): ...to here.
1507 (toplevel): Drop unnecessary declarations.
1508 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1509 in update_window_end_hook and draw_window_cursor functions.
1510 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1511 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1512 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1513 * xterm.c (x_update_window_end, x_draw_window_cursor):
1514 * xdisp.c (display_and_set_cursor, update_window_cursor)
1515 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1516 enum text_cursor_kinds where appropriate.
1517
7f780da6
DA
15182013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1519
1520 Redesign redisplay interface to drop updated_row and updated_area.
1521 * dispextern.h (updated_row, updated_area): Remove declaration.
1522 (struct redisplay_interface): Pass glyph row and row area parameters
1523 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1524 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1525 Adjust prototypes.
1526 * dispnew.c (updated_row, updated_area): Remove.
1527 (redraw_overlapped_rows, update_window_line): Adjust user.
1528 (update_marginal_area, update_text_area): Likewise. Pass updated row
1529 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1530 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1531 Adjust users.
1532
26495794
PE
15332013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1534
1535 * process.c (flush_pending_output): Remove stub.
1536 All uses removed.
1537
4a88129a
PE
15382013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1539
1540 * callproc.c: Fix race that killed background processes (Bug#15144).
1541 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1542 Record deleted process-id in critical section, not afterwards.
1543 Don't mistakenly kill process created by a call-process invocation
1544 that discards output and does not wait.
1545
0c5307b0
DA
15462013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1547
1548 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1549 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1550 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1551 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1552 to shut up compiler in mark_object.
1553 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1554
0d7c1e66
PE
15552013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1556
1557 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1558 We can't portably rely on PTY_OPEN doing that, even if
1559 it calls posix_openpt with O_CLOEXEC.
1560
3f246b65
KH
15612013-08-20 Kenichi Handa <handa@gnu.org>
1562
1563 * character.c (string_char): Improve commentary.
1564
8c2f38aa
PE
15652013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1566
1567 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1568 (struct animation_cache): Make signature a flexible array member.
1569 All uses changed. This is a tad slower but may insulate us better
1570 from future changes to ImageMagick.
1571
bb566cea
PE
15722013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1573
1574 * image.c: Shrink memory needed for animation cache.
1575 (SIGNATURE_DIGESTSIZE): New constant.
1576 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1577 (imagemagick_create_cache): Copy the signature. This saves
1578 several KB of memory that ImageMagick wastes per signature.
1579 Don't bother updating the update_time, as the caller does that now.
1580 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1581 it's a fixed size struct member now.
1582 (imagemagick_get_animation_cache): Always destroy the signature,
1583 as it's now imagemagick_create_cache's responsibility to copy it.
1584 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1585 and use memcmp rather than strcmp.
1586 eassert that ImageMagick returns a signature of the specified length.
1587
6da26928
LMI
15882013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1589
1590 * image.c (imagemagick_get_animation_cache): Don't segfault on
1591 each invocation.
453f4022
LMI
1592 (imagemagick_get_animation_cache): Revert to previous definition
1593 so that it actually works. But keep the memory leak fix.
1594 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1595
22490125
PE
15962013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1597
d0139df5
PE
1598 * image.c: Fix animation cache signature memory leak.
1599 Fix some other minor performance problems while we're at it.
1600 (imagemagick_create_cache): Clear just the members that
1601 need clearing. Don't set update_time, as caller does that now.
1602 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1603 Simplify by using pointer-to-pointer instead of a prev pointer.
1604 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1605 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1606 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1607 it's already a copy. Free the signature probe unless it's cached.
1608
22490125
PE
1609 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1610 This was introduced by my 2013-08-12 fix for Bug#15035.
1611
deb31e75
DA
16122013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1613
1614 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1615 (imagemagick_prune_animation_cache): Now static.
1616
319a4d03
LMI
16172013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1618
1619 * image.c (imagemagick_get_animation_cache): Don't segfault when
1620 pruning all entries.
1621
f747d82e
KB
16222013-08-18 Ken Brown <kbrown@cornell.edu>
1623
1624 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1625 static heap if ENABLE_CHECKING is defined.
1626 (max_bss_sbrk_ptr): New variable.
1627 (bss_sbrk): Use it.
1628 (report_sheap_usage): Report maximum static heap usage instead of
1629 ending static heap usage.
1630
d2c28fab
EZ
16312013-08-17 Eli Zaretskii <eliz@gnu.org>
1632
1633 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1634 of zlib_initialized according to the results of calling
1635 init_zlib_functions.
1636
274ff63f
LMI
16372013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1638
1639 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1640 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1641 (imagemagick_load_image): Remove the ping_wand code, which only
1642 apparently saved time on invalid animated images, and slowed down
1643 everything else. Optimise for the common case.
274ff63f 1644
2bede2ed
XF
16452013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1646
70ff8240
XF
1647 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1648
de179a3e
XF
1649 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1650
2bede2ed
XF
1651 * marker.c (set_marker): Remove documentation of undefined behavior.
1652
703dbeba
LMI
16532013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1654
1655 * image.c (imagemagick_compute_animated_image): Animate correctly
1656 when sub-images are smaller than the main image.
1d18b1e6
LMI
1657 (imagemagick_compute_animated_image): Setting the iterator row to
1658 zero is apparently not allowed.
79670014
LMI
1659 (imagemagick_compute_animated_image): Allow images that say they
1660 have sub-images that are bigger than the main image, but just crop
1661 them.
703dbeba 1662
63216c5e
JD
16632013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1664
1665 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1666
a5b5f73f
LMI
16672013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1668
1669 * image.c (imagemagick_compute_animated_image): Respect the GIF
1670 disposal methods.
1671
0fe73012
KB
16722013-08-15 Ken Brown <kbrown@cornell.edu>
1673
1674 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1675 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1676 needed.
1677
691a357f
PE
16782013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 Fix minor problems found by static checking.
1681 * frame.c (delete_frame):
1682 * xdisp.c (next_element_from_display_vector):
1683 Avoid uninitialized local.
1684 * image.c (imagemagick_compute_animated_image): Port to C89.
1685 Prefer usual GNU indentation style for loops.
1686 Be more careful about bizarrely large sizes, by using ptrdiff_t
1687 instead of int.
1688
42fe2e88
DA
16892013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1690
1691 Fix infinite frame selection loop (Bug#15025).
1692 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1693
d39a3da6
EZ
16942013-08-15 Eli Zaretskii <eliz@gnu.org>
1695
068f9124
SM
1696 * xdisp.c (compute_window_start_on_continuation_line):
1697 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1698 to make sure we end up setting the window start at the leftmost
1699 visible character of the display line. This avoids funky
1700 horizontal shifting because the window start is not kept on the
1701 same position. (Bug#15090)
05426239
EZ
1702 (next_element_from_display_vector): Support 'box' face attribute
1703 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1704
6e856b69
LMI
17052013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1706
1707 * image.c (imagemagick_compute_animated_image): Implement animated
1708 images (bug#14700).
995be755
LMI
1709 (imagemagick_compute_animated_image): Fix some compilation
1710 warnings. Implement a very simple cache to make the animation
1711 usable at all, but it should be replaced with a per-image cache.
6e856b69 1712
d5a1acfa
DA
17132013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1714
1715 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1716 to do `for' loops over alist values.
1717 * buffer.h (FOR_EACH_BUFFER):
1718 * process.c (FOR_EACH_PROCESS): Use it.
1719 (handle_child_signal, status_notify, Fget_buffer_process)
1720 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1721
9c253307
DA
17222013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1723
1724 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1725 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1726 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1727 to xzalloc and so avoid redundant call to memset.
1728 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1729 members because it is allocated with xzalloc and so already zeroed.
1730
05e64f9f
KB
17312013-08-14 Ken Brown <kbrown@cornell.edu>
1732
1733 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1734 (Bug#15094).
1735
5b71542d
DA
17362013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1737
1738 Utility function and macro to copy Lisp string to C string.
1739 * lisp.h (xlispstrdupa): New macro.
1740 (xlispstrdup): New prototype.
1741 * alloc.c (xlispstrdup): New function.
1742 * callint.c (Fcall_interactively):
1743 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1744 (Fsubstitute_in_file_name):
1745 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1746 * image.c (x_create_bitmap_from_file):
1747 * w32term.c (w32_term_init):
1748 * xterm.c (x_term_init): Use xlispstrdup.
1749
71530c97
LMI
17502013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1751
4ce82fb8
LMI
1752 * image.c (imagemagick_load_image): Make animated pictures work.
1753 There's still some problems with background color settings, though
1754 (bug#14700).
1755
71530c97
LMI
1756 * decompress.c (unwind_decompress): Always restore point.
1757
7510a061
XF
17582013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1759
1760 * marker.c (set_marker): Reformat documentation.
1761
01c3051f
PE
17622013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1763
aab1fcdf
PE
1764 * xdisp.c (cursor_type_changed): Now static.
1765
01c3051f
PE
1766 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1767 Use changed. This avoids the need to call xmalloc and for the
1768 caller to call xfree, and avoids memory leaks in some situations.
1769
2084152a
DA
17702013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1771
1772 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1773 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1774 (redisplay_window): If window_end_valid is cleared due to non-zero
1775 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1776 so do not call to try_cursor_movement for that window.
2084152a 1777
02455cb6
DA
17782013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1779
1780 * window.h (struct window): Convert window_end_pos and
1781 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1782 (wset_window_end_pos, wset_window_end_vpos): Remove.
1783 * dispnew.c (adjust_glyph_matrix):
1784 * window.c (Fwindow_end, replace_window, set_window_buffer)
1785 (make_window):
1786 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1787 (set_vertical_scroll_bar, redisplay_window, try_window)
1788 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1789 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1790 (note_mouse_highlight): Adjust users.
1791 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1792 Add comment.
1793
da5707e8
DA
17942013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1795
1796 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1797 * image.c (imagemagick_filename_hint): Use `const char *' and
1798 prefer SSDATA to SDATA to avoid warnings.
1799
25554267
DA
18002013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 Cleanup window fringes, margins and scroll bars adjustments.
1803 * window.c (set_window_fringes, set_window_margins)
1804 (set_window_scroll_bars, apply_window_adjustment): New functions.
1805 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1806 (Fset_window_scroll_bars): Use them.
1807
38a2c910
DA
18082013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1809
1810 * window.h (struct window): Convert scroll_bar_width
1811 from Lisp_Object to integer. Adjust comment.
1812 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1813 Adjust users.
1814 * window.c (wset_scroll_bar_width): Remove.
1815 (make_window): Initialize scroll_bar_width.
1816 (Fsplit_window_internal): Use direct assignment.
1817 (Fset_window_configuration, save_window_save):
1818 Convert Lisp_Object to integer and back where appropriate.
1819 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1820 bar was actually changed, and mention this in docstring.
1821
2d065031
PE
18222013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1823
1824 * decompress.c: Minor simplifications.
1825 (Fzlib_decompress_region): Don't bother verifying
1826 that avail_out <= UINT_MAX, as that was confusing.
1827 Mention the restriction in a comment instead.
1828 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1829
a5bd5abb
JD
18302013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1831
1832 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1833 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1834
66e7901a
LMI
18352013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1836
1837 * image.c (imagemagick_filename_hint): Check for errors in the
1838 alist structure.
1839
2fa611b7
EZ
18402013-08-13 Eli Zaretskii <eliz@gnu.org>
1841
1842 * window.c (Fwindow_margins): Return nil when there's no marginal
1843 area, as per the documented API.
1844
1845 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1846 Fmake_vector, as scroll bar's struct members are not all Lisp
1847 objects now. This avoids crashes in GC.
1848
1849 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1850 bool, so its address could be taken.
1851
8259030d
LMI
18522013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1853
1854 * image.c (imagemagick_filename_hint): New function to possibly
1855 apply `image-content-type-suffixes'.
1856 (imagemagick_load_image): Use it.
1857
866c710e
EZ
18582013-08-13 Eli Zaretskii <eliz@gnu.org>
1859
1860 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1861 if loading zlib failed.
1862
f10490f0
JD
18632013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1864
96311be7
JD
1865 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1866 2013-08-13 checkin below. Change bool to BOOL, rule is:
1867 All Obj-C code uses BOOL, except for interfaces callable from C.
1868
f10490f0
JD
1869 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1870
c8ae93b0
DA
18712013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1872
1873 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1874 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1875 bool instead of BOOL.
1876 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1877 from Lisp_Object to bitfield. Adjust comment.
1878 * w32term.c (x_scroll_bar_create): Adjust user.
1879 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1880 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1881 Use bool for boolean.
1882 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1883 to `unsigned int' when defining a bitfield.
1884
53b64418
PE
18852013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1886
1887 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1888
eeaf9bf3
DA
18892013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1890
1891 * window.h (struct window): Convert left_margin_cols and
1892 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1893 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1894 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1895 Adjust users.
1896 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1897 Adjust comment.
1898 (showing_window_margins_p, update_window_line, update_frame_1):
1899 * fringe.c (draw_fringe_bitmap_1):
1900 * xdisp.c (window_box_width): Adjust users.
1901 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1902 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1903 Use direct assignment.
1904 (Fset_window_configuration, save_window_save, Fwindow_margins):
1905 Convert Lisp_Object to integer and back where appropriate.
1906 (Fset_window_margins): Adjust user. Return t if any margin
1907 was actually changed, and mention this in docstring.
1908
956720af
XF
19092013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1910
f73f4ce6 1911 * syntax.c (forward_word):
956720af
XF
1912 * cmds.c (forward_char, backward_char): Mention the optional argument.
1913
9e37ee3b
DA
19142013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1915
1916 * window.h (struct window): Convert left_fringe_width
1917 and right_fringe_width from Lisp_Objects to integers.
1918 Adjust comment.
1919 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1920 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1921 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1922 Remove.
1923 (make_window): Initialize new integer fields to -1.
1924 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1925 (Fset_window_configuration, save_window_save):
1926 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1927 (Fset_window_fringes): Adjust user. Return t if any fringe
1928 was actually changed, and mention this in docstring.
1929
e4375ca7
DA
19302013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1931
1932 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1933 * nsfns.m (x_set_cursor_type):
1934 * w32fns.c (x_set_cursor_type):
1935 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1936 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1937
a45543bc
DA
19382013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1939
1940 * font.c (clear_font_cache): New function, stripped from...
1941 (Fclear_font_cache): ...here, which now uses the function
1942 above. Adjust comment.
1943 * font.h (clear_font_cache): Add prototype.
1944 * xfaces.c (clear_face_cache): Use clear_font_cache.
1945
ae966a86
DA
19462013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1947
1948 * window.c (Fset_window_start): Compare `w', not `window' because
1949 `w' might not be equal to `window' after call to decode_live_window.
1950
297a545b
PE
19512013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1954 This fixes a problem introduced by the Bug#15035 patch
1955 when using GPG. Reported by Herbert J. Skuhra.
1956
aa942e2b
EZ
19572013-08-12 Eli Zaretskii <eliz@gnu.org>
1958
1959 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1960 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1961 not yet initialized.
1962
7699d09e
LMI
19632013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1964
1965 * decompress.c (Fzlib_decompress_region): Support zlib
1966 decompression, too, and rename.
1967
1d238bc7
PE
19682013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 Minor zlib configuration tweaks.
1971 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1972 Don't assume presence of fn_inflateInit2_ zlib internal function.
1973
8a44a184
LMI
19742013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1975
1976 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1977 include the zlib prefix.
1978
594a4307
EZ
19792013-08-12 Eli Zaretskii <eliz@gnu.org>
1980
1981 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1982 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1983 define static variables that are pointers to zlib functions to be
1984 dynamically loaded.
1985 (init_zlib_functions) [WINDOWSNT]: New function.
1986 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1987 New macros.
1988 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1989 macros instead of invoking the zlib functions directly.
068f9124
SM
1990 (syms_of_decompress): DEFSYM Qzlib_dll.
1991 Staticpro Szlib_available_p.
594a4307 1992
d2e113bc
DA
19932013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1994
1995 Avoid looping over all frame windows to freeze and unfreeze.
1996 * window.h (struct window): Drop frozen_window_start_p.
1997 (freeze_window_starts): Drop prototype.
1998 * frame.h (struct frame): New frozen_window_starts flag.
1999 (FRAME_WINDOWS_FROZEN): New macro.
2000 * window.c (freeze_window_start, freeze_window_starts):
2001 Remove.
2002 (select_window, replace_window): Adjust users.
2003 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2004 (window_frozen_p): New function.
2005 (redisplay_window): Use it.
2006
94fcd171
PE
20072013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 Fix some fd issues when running subprocesses (Bug#15035).
2010 Fix bugs that can leak files or file descriptors on errors.
2011 Don't unlink open temp files, as that's hard for users to diagnose
2012 when things go awry (e.g., temp disk exhausted).
2013 Don't bother to lock temp files. Check for invalid recursion.
2014 * callproc.c (synch_process_fd): Remove. All uses removed.
2015 (synch_process_tempfile): New var or macro.
2016 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2017 New constants.
2018 (record_kill_process): New arg, the temp name. All callers changed.
2019 (delete_temp_file): Now just a simple wrapper around unlink.
2020 (call_process_kill): New arg, the call_process_fd array.
2021 Close them all. Clear synch_process_pid. Remove the temp file,
2022 or arrange for it to be removed.
2023 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2024 that's been moved to synch_process_tempfile. Caller changed.
2025 Do not remove the tempfile; that's now call_process_kill's
2026 responsibility.
2027 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2028 call_process_kill; the caller now does that.
2029 (call_process_cleanup): Do not close the process fd; that's now
2030 call_process_kill's responsibility.
2031 (Fcall_process): Implement via new function call_process, which
2032 has most of the old body of Fcall_process, but with a different API.
2033 (call_process): New function that does not open or close filefd if
2034 it is nonnegative. Record which fds need to be closed, and let
2035 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2036 Signal an error if invoked recursively (could be done via a hook).
2037 Simplify creation of the tempfile in the MSDOS case.
2038 Don't create the output file until after checking for the executable.
2039 Report any failure to open /dev/null.
2040 Don't open /dev/null for writing twice; once is enough.
2041 Don't create pipe if all output is being discarded or sent to file.
2042 Don't worry about setting up the coding system or reading from the
2043 pipe if all output is being discarded.
2044 Hoist fd_error local into top level, to lessen block nesting.
2045 Don't record deleted pid here; now done by Fcall_process_region.
2046 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2047 and note its success in synch_process_tempfile.
2048 Do not leak resources when child_setup fails.
2049 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2050 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2051 (create_temp_file): Now returns open fd, with an additional
2052 Lisp_Object * argument to return the name. All callers changed.
2053 Do not close the file; rewind it instead, and leave it open for
2054 the caller. Do not lock the temp file. Unwind-protect the file
2055 and the file-descriptor.
2056 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2057 If an asynchrounous process, record it here, not in call_process.
2058 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2059 * eval.c (set_unwind_protect): New function.
2060 * fileio.c (write_region): New function, generalized from the
2061 old Fwrite_region. Do not lock temp files.
2062 (Fwrite_region): Use it.
2063 * lisp.h (set_unwind_protect, write_region): New decls.
2064 * process.c: Include <verify.h>.
2065 (make_process): Mark fds as initially closed.
2066 (deleted_pid_list): Now a list of pid-filename pairs.
2067 All uses changed.
2068 (close_process_fd): New function.
2069 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2070 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2071 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2072 (create_process, create_pty, Fmake_serial_process)
2073 (server_accept_connection): Record which fds need to be closed,
2074 and let deactivate_process close them.
2075 (Fmake_network_process): Do not discard the unwind-protect
2076 until it's safe to do so.
2077 (deactivate_process): Close the fds opened by create_process etc.
2078 (Fprocess_send_eof): Adjust to new way of recording open fds.
2079 Report an error if /dev/null can't be opened, instead of aborting.
2080 * process.h (PROCESS_OPEN_FDS): New constant.
2081 (struct Lisp_Process): New member open_fds.
2082 (record_kill_process, record_deleted_pid): Adjust signatures.
2083 (record_deleted_pid): Move decl here ...
2084 * syswait.h (record_deleted_pid): ... from here.
2085
d0e615c3
PE
20862013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2087
2088 * decompress.c: Fix bugs with large buffers and weird inputs.
2089 Tune a bit. Reindent as per usual Emacs style.
2090 (BUFFER_SIZE): Remove.
2091 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2092 more than UINT_MAX bytes. Decompress into the gap instead of into
2093 an auto buffer, as this should avoid copying. Return nil if
2094 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2095 set immediate_quit; we shouldn't trust zlib code that much.
2096
313546eb
LMI
20972013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2098
99a32242
LMI
2099 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2100 errors, and really move the gap to where we want it.
2101
313546eb
LMI
2102 * lisp.h: Include decompress.c support.
2103
2104 * emacs.c (main): Include decompress.c support.
2105
2106 * Makefile.in: Include -lz if present.
2107
d2d699ac
JD
21082013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2109
f90e3ebd
JD
2110 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2111 (initWithTitle:): Initialize frame to 0.
2112 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2113 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2114 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2115
2116 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2117 fillWithWidgetValue:frame:
2118
423d3b3f
JD
2119 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2120 remove memory leak warnings.
2121
d2d699ac
JD
2122 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2123 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2124 menu_pending_title.
2125
2126 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2127 (x_activate_menubar): Update the whole menu.
2128 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2129 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2130 current event is not NSSystemDefined (Bug#15001).
2131 Call ns_check_menu_open only if trackingMenu is 2.
2132 (menuDidClose:): New method, decrease trackingMenu.
2133 (fillWithWidgetValue:setDelegate:): New method.
2134 (fillWithWidgetValue:): Call the above.
2135
2136 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2137
7d652d97
PE
21382013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 Omit some unnecessary casts.
2141 Many of these go back to the old pre-C89 days, when they may have
2142 been needed, but we've been assuming C89 or later for a while now.
2143 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2144 (live_float_p, live_misc_p, live_vector_p):
2145 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2146 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2147 (defvar_per_buffer):
2148 * callint.c (Fcall_interactively):
2149 * doc.c (Fsubstitute_command_keys):
2150 * filelock.c (get_boot_time):
2151 * frame.c (xrdb_get_resource):
2152 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2153 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2154 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2155 (menuitem_highlight_callback, menu_destroy_callback)
2156 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2157 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2158 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2159 (xg_tool_bar_help_callback, tb_size_cb):
2160 * image.c (xpm_alloc_color, png_read_from_memory)
2161 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2162 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2163 (syms_of_image):
2164 * keymap.c (describe_map):
2165 * nsfns.m (Fns_display_monitor_attributes_list):
2166 * nsmenu.m (process_dialog:):
2167 * nsterm.m (hold_event):
2168 * process.c (wait_reading_process_output):
2169 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2170 * scroll.c (do_direct_scrolling, scrolling_1):
2171 * termcap.c (tgetent):
2172 * window.c (check_window_containing, add_window_to_list)
2173 (freeze_window_starts):
2174 * xdisp.c (compare_overlay_entries, vmessage):
2175 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2176 (x_get_monitor_attributes_xrandr)
2177 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2178 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2179 * xfont.c (xfont_match, xfont_open):
2180 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2181 (menubar_selection_callback, menu_position_func)
2182 (popup_selection_callback, create_and_show_popup_menu)
2183 (dialog_selection_callback, create_and_show_dialog):
2184 * xrdb.c (x_get_string_resource):
2185 (main) [TESTRM]:
2186 * xsmfns.c (x_session_check_input):
2187 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2188 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2189 (xaw_jump_callback, xaw_scroll_callback):
2190 Omit unnecessary casts.
2191
9acc1074
PE
21922013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2193
2194 Minor string-length refactoring.
2195 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2196 * frame.c (make_monitor_attribute_list):
2197 Prefer build_string to strlen + make_string.
2198
361c0eb8
JD
21992013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2200
2201 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2202 don't check minor_code (Bug#14417).
2203
14ba0822
EZ
22042013-08-09 Eli Zaretskii <eliz@gnu.org>
2205
2206 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2207 vertical positions instead. This avoids calling MATRIX_ROW with
2208 row numbers that are possibly beyond valid limits. (Bug#15064)
2209
309f24d1
DA
22102013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2211
2212 Use xstrdup and build_unibyte_string where applicable.
2213 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2214 * xfns.c (x_window):
2215 * xrdb.c (x_get_customization_string):
2216 * xterm.c (xim_initialize):
2217 * w32fns.c (w32_window): Use xstrdup.
2218 (w32_display_monitor_attributes_list):
2219 * emacs.c (init_cmdargs):
2220 * keyboard.c (PUSH_C_STR):
2221 * nsfont.m (nsfont_open):
2222 * sysdep.c (system_process_attributes):
2223 * w32.c (system_process_attributes):
2224 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2225
55902276
EZ
22262013-08-09 Eli Zaretskii <eliz@gnu.org>
2227
2228 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2229 variables of these types so that GDB would know about them, as aid
2230 for debugging fatal exceptions. (Bug#15024) See also
2231 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2232 discussions.
2233
10bf7f5a
JD
22342013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2235
2236 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2237 larger than the NSWindow (Bug#14934).
2238
65620264
DA
22392013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2240
2241 Redesign redisplay interface to drop global variable updated_window.
2242 Always pass currently updated window as a parameter to update routines.
2243 * dispextern.h (updated_window): Remove declaration.
2244 (struct redisplay_interface): Pass window parameter to
2245 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2246 and after_update_window_hook.
2247 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2248 Adjust prototypes.
2249 * dispnew.c (updated_window): Remove.
2250 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2251 (update_window_line): Adjust to match redisplay interface changes.
2252 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2253 (ns_scroll_run, ns_after_update_window_line):
2254 * w32term.c (x_update_window_begin, x_update_window_end)
2255 (x_after_update_window_line, x_scroll_run):
2256 * xterm.c (x_update_window_begin, x_update_window_end)
2257 (x_after_update_window_line, x_scroll_run):
2258 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2259 Likewise. Adjust comments where appropriate.
2260 (x_cursor_to): Simplify because this is always called during window
2261 update (but install debugging check anyway).
2262 (expose_window): Check must_be_updated_p flag to see whether this
2263 function is called during window update.
2264
628fdc56
DA
22652013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2266
2267 Do not reset window modification event counters excessively.
2268 These leftovers and poor man's tricky methods to catch extra
2269 redisplay's attention are no longer needed.
2270 * frame.c (set_menu_bar_lines_1):
2271 * minibuf.c (read_minibuf_unwind):
2272 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2273 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2274 (window_scroll_line_based, Fset_window_configuration):
2275 * xdisp.c (redisplay_window): Do not reset last_modified and
2276 last_overlay_modified counters.
2277
8fd9c92e
JD
22782013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2279
2280 * xselect.c (x_send_client_event): Set send_event and serial, memset
2281 data.l as it might be bigger than data.b. Use 24 bit mask to
2282 XSendEvent (Bug#15034).
2283
0ee18172
EZ
22842013-08-07 Eli Zaretskii <eliz@gnu.org>
2285
2286 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2287 for TTY frames that are not the top frame on their console.
2288 (Bug#14616)
2289
16ddd1a6
MR
22902013-08-07 Martin Rudalics <rudalics@gmx.at>
2291
2292 * w32term.c (w32fullscreen_hook): Really maximize frame when
2293 asked for (Bug#14841).
2294
d2a95ffb
DA
22952013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2296
2297 Prefer selected_window to Fselected_window, likewise for frames.
2298 * buffer.c (Fbuffer_swap_text):
2299 * data.c (Fvariable_binding_locus):
2300 * window.c (run_window_configuration_change_hook): Adjust users.
2301 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2302 Use decode_live_frame.
2303
170da1ec
DA
23042013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2305
2306 Be more careful if selected window shows the buffer other than current,
2307 use window_outdated only if this is not so. This change should also
2308 address some weird issues discussed in Bug#13012.
2309 * window.h (window_outdated): New prototype.
2310 * window.c (window_outdated): Now here. Convert from static and
2311 always assume window's buffer.
2312 (Fwindow_end, Fwindow_line_height): Use it.
2313 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2314 and always assume window's buffer.
2315 (redisplay_window): Adjust user.
e5eefe9b 2316 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2317 check whether mode line should be updated only if selected window
2318 shows current buffer.
2319 (run_window_scroll_functions): Use eassert for debugging check.
2320 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2321
56b5d5b1
DA
23222013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2323
2324 * window.c (window_scroll, window_scroll_pixel_based)
2325 (window_scroll_line_based): Use bool for booleans.
2326
2878ba7e
PE
23272013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 * process.c: Fix minor off-by-one issues in descriptor counts.
2330 This shouldn't fix any real bugs, but it cleans up the code a bit.
2331 (max_process_desc, max_input_desc): -1, not 0, means none.
2332 All uses changed.
2333 (delete_input_desc): New function.
2334 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2335 (deactivate_process): Scan backwards when recomuting max_process_desc;
2336 that should be faster.
2337 (init_process_emacs): Initialize max_input_desc.
2338
e30b79c1
DA
23392013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2340
2341 Use region cache to speedup bidi_find_paragraph_start.
2342 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2343 Rename cache_long_line_scans to cache_long_scans.
2344 * buffer.c (bset_cache_long_line_scans): Rename to
2345 bset_cache_long_scans.
2346 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2347 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2348 into account.
2349 (syms_of_buffer): Rename cache-long-line-scans to
2350 cache-long-scans. Adjust docstring.
2351 * search.c (newline_cache_on_off):
2352 * indent.c (width_run_cache_on_off): Adjust users.
2353 * bidi.c (bidi_paragraph_cache_on_off): New function.
2354 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2355 * insdel.c (prepare_to_modify_buffer):
2356 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2357
00012b86
DA
23582013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2359
2360 Invalidate region caches only if buffer text is going to be changed.
2361 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2362 (modify_text): ...new prototype.
2363 (prepare_to_modify_buffer_1): New prototype.
2364 * textprop.c (modify_region): Rename to...
2365 (modify_text_properties): ...new function.
2366 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2367 (Fremove_list_of_text_properties): Adjust users.
2368 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2369 (modify_text): ...new function.
2370 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2371 (prepare_to_modify_buffer_1): ...new function.
2372 * casefiddle.c (casify_region):
2373 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2374 (Ftranspose_regions): Use modify_text.
2375
dc6c0eda
SM
23762013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2377
2378 * lisp.mk (lisp): Add nadvice.elc.
2379
8f3a2c26
DA
23802013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2381
2382 New macro to iterate over live buffers similar to frames.
2383 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2384 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2385 Declare buffer-related variables here to offload lisp.h.
2386 * buffer.c (Vbuffer_alist): Adjust comment.
2387 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2388 (other_buffer_safely):
2389 * data.c (store_symval_forwarding):
2390 * dispnew.c (Fframe_or_buffer_changed_p):
2391 * fileio.c (Fdo_auto_save):
2392 * filelock.c (unlock_all_files):
2393 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2394
e0fdb694
PE
23952013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2398 * callproc.c (create_temp_file):
2399 * filelock.c (create_lock_file):
2400 Assume mkostemp, since it's now provided by Gnulib.
2401
63f5c6c2
EZ
24022013-08-04 Eli Zaretskii <eliz@gnu.org>
2403
2404 * w32.c (mkostemp): New function.
2405 (mktemp): Remove, no longer used. Most of the code reused in
2406 mkostemp. (Bug#15015)
484ab239 2407 (mktemp): Don't undef.
63f5c6c2 2408
f0b79313
DA
24092013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2410
2411 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2412 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2413 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2414 (free_glyph_pool, check_glyph_memory): Likewise for
2415 all users. Adjust comments where appropriate.
2416
98f638d6
PE
24172013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2418
2419 * composite.h: Minor fixups.
2420 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2421 to fix a misspelling, and change it to an inline function while
2422 we're at it (it need not be a macro). All uses changed.
2423 (composition_method, composition_valid_p):
2424 Rewrite to avoid assignments in if-conditions.
2425
75c59fb3
DA
24262013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2427
2428 Do not use global Lisp_Object in composition macros.
2429 * composite.h (composition_temp): Remove declaration.
2430 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2431 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2432 (compose_region): Remove the leftover.
75c59fb3
DA
2433 * composite.c (composition_temp): Remove.
2434 (run_composition_function, update_compositions)
2435 (composition_compute_stop_pos, composition_adjust_point)
2436 (Ffind_composition_internal):
2437 * coding.c (handle_composition_annotation):
2438 * xdisp.c (handle_composition_prop, check_point_in_composition):
2439 Related users changed.
2440
a10c8269
DA
24412013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2442
2443 Drop FRAME_PTR typedef.
2444 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2445 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2446 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2447 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2448 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2449 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2450 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2451 All related users changed.
2452
a104f656
SM
24532013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2454
2455 * eval.c (default_toplevel_binding): New function.
2456 (Fdefvar): Use it.
2457 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2458 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2459 (syms_of_eval): Export them.
2460 * data.c (Fdefault_value): Micro cleanup.
2461 * term.c (init_tty): Use "false".
2462
4b5c9326
DA
24632013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2464
2465 Fix X GC leak in GTK and raw (no toolkit) X ports.
2466 * xterm.c (x_free_frame_resources): If white and black relief
2467 GCs are allocated, always free them here.
2468 * xfns.c (x_make_gc): Omit redundant initialization.
2469 * widget.c (create_frame_gcs): Remove the leftover.
2470 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2471 in x_free_frame_resources.
2472
b19aa636
JD
24732013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2474
2475 * nsterm.m (windowWillResize:toSize:): Only change title if
2476 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2477 modifying it.
2478 (viewDidEndLiveResize): New method.
2479
2480 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2481 inside NS_IMPL_COCOA.
2482
af1f7e06
DA
24832013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2484
2485 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2486 Do not check whether undo is enabled because record_insert and
2487 record_delete does that themselves.
2488
65b02bb9
DA
24892013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2490
2491 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2492 member which is not really used any more.
2493 (FRAME_XIC_BASE_FONTNAME): Remove.
2494 * xfns.c (xic_free_fontset): Adjust user.
2495 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2496 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2497 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2498 (xdialog_show): Use eassert for debugging check.
7ee0f047 2499 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2500
6318cde0
PE
25012013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 * fileio.c, fns.c (merge): Move extern decl from here ...
2504 * lisp.h (merge): ... to here.
2505
6c1a09ba
DA
25062013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2507
2508 Fix last font-related change.
2509 * w32font.h (w32font_list_internal, w32font_match_internal):
2510 Fix prototype.
2511 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2512 (uniscribe_list_family): Adjust to match font API change.
2513 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2514 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2515
f8c20208
DA
25162013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2517
2518 * frame.h (FRAME_MOUSE_UPDATE):
2519 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2520 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2521
fdb396e2
DA
25222013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2523
2524 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2525 * font.h (struct font_driver): Change list, match, and list_family
2526 functions to accept struct frame * as first arg.
068f9124
SM
2527 * font.c (font_score, font_compare, font_sort_entities):
2528 Remove prototypes.
fdb396e2
DA
2529 (font_sort_entities, font_list_entities, font_select_entity):
2530 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2531 match font API change.
2532 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2533 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2534 * ftxfont.c (ftxfont_list, ftxfont_match):
2535 * xftfont.c (xftfont_list, xftfont_match):
2536 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2537 * w32font.c (w32font_list, w32font_match, w32font_list):
2538 (w32font_list_internal, w32_font_match_internal): Likewise.
2539 * xfaces.c (Fx_family_fonts): Adjust user.
2540
52b8a085
DA
25412013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2542
2543 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2544 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2545 only if HAVE_X_WINDOWS is in use.
2546 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2547 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2548 * w32term.c (x_wm_set_icon_position): Likewise.
2549 * w32fns.c (x_icon): Adjust user.
2550
c791c18e
DA
25512013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2552
2553 * xterm.c (last_mouse_press_frame): Remove the
2554 leftover which is not really used any more.
2555 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2556 (x_flush): Call XFlush once per each X display, not frame.
2557 This is better because this code always unconditionally skips
2558 non-X frames in Vframe_list and issues the only XFlush if we
2559 have more than one X frame on the same X display.
2f935d86
DA
2560 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2561 Use bool for booleans.
2562 (x_draw_glyph_string_background, cvt_string_to_pixel):
2563 (cvt_pixel_dtor): Drop unnecessary prototypes.
2564 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2565
f435830e
DA
25662013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2567
2568 Drop unnecessary functions that deals with frame pixel size.
2569 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2570 (x_pixel_height): Drop prototypes.
2571 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2572 (x_pixel_height): Drop implementations.
2573 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2574 which should be always valid for window frame.
2575 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2576 * w32menu.c (Fx_popup_dialog):
2577 * xmenu.c (Fx_popup_dialog): Likewise for both.
2578
84231434
DA
25792013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2580
2581 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2582 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2583 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2584 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2585 and mention nil frame in docstring.
84231434 2586
959067a1
DA
25872013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2588
2589 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2590 (x_figure_window_size): Likewise. Adjust to return long.
2591 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2592 (toplevel): Move Qterminal_live_p to...
2593 * terminal.c (toplevel): ...here, make it static, and...
2594 (syms_of_terminal): ...DEFSYM here.
2595 * frame.h (Qterminal_live_p): Remove declaration.
2596 (make_frame, x_figure_window_size): Adjust prototype.
2597 * nsfns.m (Fx_create_frame): Use long for window flags.
2598
f4b169ce
PE
25992013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2602 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2603 Do not assume that emacs_close (INT_MAX) is a no-op.
2604
bee6a2c7
DA
26052013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2606
2607 * xfaces.c (make_face_cache): For struct face_cache, prefer
2608 xmalloc to xzalloc and so avoid redundant call to memset.
2609 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2610
d7e6881a
DA
26112013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2612
2613 * fringe.c (draw_window_fringes, update_window_fringes)
2614 (compute_fringe_widths):
2615 * w32term.c (x_draw_glyph_string):
2616 * window.c (candidate_window_p, Frecenter):
2617 * xfaces.c (realize_basic_faces, realize_default_face)
2618 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2619 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2620 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2621 * xmenu.c (Fx_menu_bar_open_internal):
2622 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2623 * xsettings.c (xft_settings_event):
2624 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2625 Use bool for booleans. Adjust style and comments where
2626 appropriate.
2627 * dispextern.h (draw_window_fringes, update_window_fringes)
2628 (compute_fringe_widths):
2629 * xterm.h (x_had_errors_p): Adjust prototype.
2630
ec3058af
DA
26312013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2632
2633 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2634 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2635
218e0637
DA
26362013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2637
2638 * fns.c (toplevel): Remove comment before Fsafe_length because
2639 it checks for QUIT.
2640
e560aba9
PE
26412013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2644
2e5ce5de
EZ
26452013-07-28 Eli Zaretskii <eliz@gnu.org>
2646
2647 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2648 frame which got the message is still alive, before dereferencing
2649 its pointer. (Bug#14970)
2650
2651 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2652 be a live window, before using it as such. (Bug#14970)
2653
e95da6d3
EZ
26542013-07-27 Eli Zaretskii <eliz@gnu.org>
2655
2656 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2657 w32_detect_focus_change instead of doing part of its job by hand.
2658 This fixes the problem whereby FOCUS_OUT events were not sent to
2659 the event queue.
2660
a8f93651
EZ
26612013-07-26 Eli Zaretskii <eliz@gnu.org>
2662
fec92060
EZ
2663 * process.c (Fprocess_list): Doc fix.
2664
a8f93651
EZ
2665 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2666 being re-exposed only if it didn't ask to become visible.
2667 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2668 was previously iconified. (Bug#14841)
2669 (x_iconify_frame): Mark the frame iconified.
2670
d5a7a9d9
PE
26712013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 Fix minor problems found by static checking.
2674 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2675 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2676
56ea7291
SM
26772013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2678
2679 * eval.c (set_specpdl_old_value): New function.
2680 (unbind_to): Minor simplification.
2681 (get_backtrace_frame): New function.
2682 (Fbacktrace_frame): Use it. Add `base' argument.
2683 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2684 (syms_of_eval): Export backtrace-eval.
2685 * xterm.c (x_focus_changed): Simplify.
2686
9d611ffe
PE
26872013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2690
999c74e3
EZ
26912013-07-24 Eli Zaretskii <eliz@gnu.org>
2692
2693 * xdisp.c (redisplay_window): Instead of moving point out of
2694 scroll margin, reject the force_start method, and try scrolling
2695 instead. (Bug#14780)
2696
198fa217
KB
26972013-07-24 Ken Brown <kbrown@cornell.edu>
2698
2699 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2700 (Bug#14944).
2701
53840e55
PE
27022013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 * eval.c (Fprogn): Do not check that BODY is a proper list.
2705 This undoes the previous change. The check slows down the
2706 interpreter, and is not needed to prevent a crash. See
2707 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2708
60967f56
GM
27092013-07-23 Glenn Morris <rgm@gnu.org>
2710
2711 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2712
9ca960e2
PE
27132013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2714
a29c3e6d
PE
2715 Port to GNU/Linux systems with tinfo but not ncurses.
2716 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2717 to decide whether ncurses is being used. Without this change,
2718 GCC complains about tgetent not being declared, on a system
2719 that has tinfo installed but ncurses not installed.
2720
f274311c
PE
2721 * eval.c (Fprogn): Check that BODY is a proper list.
2722
16b0520a
PE
2723 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2724 * data.c (Fsetq_default):
2725 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2726 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2727 (Fcondition_case):
2728 Tune by taking advantage of the fact that ARGS is always a list
2729 when a function is declared to have UNEVALLED args.
2730
9ca960e2
PE
2731 * emacsgtkfixed.c: Port to GCC 4.6.
2732 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2733
afacaa1b
JB
27342013-07-23 Juanma Barranquero <lekktu@gmail.com>
2735
2736 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2737 here to silence compiler warnings.
2738
368a85a4
PE
27392013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2742 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2743 from messing up Emacs's 'struct frame' (Bug#14923).
2744
f4e891b5
PE
27452013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 * alloc.c (make_save_ptr_ptr): Define this function.
2748 It was inadvertently omitted. It's needed only if
2749 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2750
96c8b65e
JD
27512013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2752
2753 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2754 frame have focus (Bug#14895).
2755
ee010797
PE
27562013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2757
2758 Avoid vfork-related deadlock more cleanly.
2759 * callproc.c (child_setup): When the child's exec fails, output
2760 the program name, as that's more useful. Use O_NONBLOCK to avoid
2761 deadlock.
2762 * process.c (create_process_1): Remove; no longer needed.
2763 (create_process): Remove timer hack; no longer needed, now that
2764 the child avoids deadlock.
2765
f0398ec1 27662013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2767
2768 * image.c (Fimage_flush): Fix doc typo.
2769
b2a069c2
PE
27702013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2771
6496aec9
PE
2772 Fix array bounds violation when pty allocation fails.
2773 * process.c (PTY_NAME_SIZE): New constant.
2774 (pty_name): Remove static variable; it's now auto.
2775 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2776 Take pty_name as an arg rather than using a static variable.
2777 All callers changed.
2778 (create_process): Recover pty_flag from process, not from volatile local.
2779 (create_pty): Stay inside array even when pty allocation fails.
2780 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2781
b2a069c2
PE
2782 * lread.c (Fload): Avoid initialization only when lint checking.
2783 Mention that it's needed only for older GCCs.
2784
99107004
KH
27852013-07-20 Kenichi Handa <handa@gnu.org>
2786
2787 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2788 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2789
6b1b199d
AS
27902013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2791
2792 * lread.c (Fload): Avoid uninitialized warning.
2793
4195afc3
PE
27942013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2795
3f5bef16
PE
2796 Fix some minor file descriptor leaks and related glitches.
2797 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2798 (create_lock_file): Use write, not emacs_write.
2799 * image.c (slurp_file, png_load_body):
2800 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2801 (server_accept_connection):
2802 Don't leak an fd on memory allocation failure.
2803 * image.c (slurp_file): Add a cheap heuristic for growing files.
2804 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2805 as that's what the other routines do. Maybe input need not be
2806 blocked at all, but it's better to be consistent.
2807 Avoid undefined behavior when strlen is zero.
2808
4195afc3
PE
2809 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2810 (NSTATICS): Now a constant; doesn't need to be a macro.
2811
a1aeeffe
RS
28122013-07-19 Richard Stallman <rms@gnu.org>
2813
2814 * coding.c (decode_coding_utf_8): Add simple loop for fast
2815 processing of ASCII characters.
2816
63b34baa
PE
28172013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2820
621dd9ac
EZ
28212013-07-19 Eli Zaretskii <eliz@gnu.org>
2822
2823 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2824 unportable 'struct x_display_info'.
2825 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2826 is a portable type.
2827
1396ac86
PE
28282013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2829
ab9980cd
PE
2830 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2831 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2832 or fscanf fails.
2833 (system_process_attributes): Prefer plain char to unsigned char
2834 when either will do. Clean up properly if interrupted or if
068f9124
SM
2835 memory allocations fail. Don't assume sscanf succeeds.
2836 Remove no-longer-needed workaround to stop GCC from whining.
2837 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2838 bit more carefully.
2839
1396ac86
PE
2840 Fix obscure porting bug with varargs functions.
2841 The code assumed that int is treated like ptrdiff_t in a vararg
2842 function, which is not a portable assumption. There was a similar
2843 -- though these days less likely -- porting problem with various
2844 assumptions that pointers of different types all smell the same as
2845 far as vararg functions is conserved. To make this problem less
2846 likely in the future, redo the API to use varargs functions.
2847 * alloc.c (make_save_value): Remove this vararg function.
2848 All uses changed to ...
2849 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2850 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2851 New functions.
2852 (make_save_ptr): Rename from make_save_pointer, for consistency with
2853 the above. Define only on platforms that need it. All uses changed.
2854
4d19d194
PE
28552013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 * keyboard.c: Try to fix typos in previous change.
2858 (DISPLAY_LIST_INFO): New macro.
2859 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2860 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2861
945c5bb1
JB
28622013-07-18 Juanma Barranquero <lekktu@gmail.com>
2863
2864 * keyboard.c (kbd_buffer_get_event):
2865 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2866 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2867
f4b1eb36
PE
28682013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2869
5e679a2c
PE
2870 * filelock.c: Fix unlikely file descriptor leaks.
2871 (get_boot_time_1): Rework to avoid using emacs_open.
2872 This doesn't actually fix a leak, but is better anyway.
2873 (read_lock_data): Use read, not emacs_read.
2874
a8cd4836
PE
2875 * doc.c: Fix minor memory and file descriptor leaks.
2876 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2877 (get_doc_string, Fsnarf_documentation):
2878 Fix file descriptor leak on error.
2879
ef30e638
PE
2880 * term.c: Fix minor fdopen-related file descriptor leaks.
2881 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2882 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2883
f4b1eb36
PE
2884 * charset.c: Fix file descriptor leaks and errno issues.
2885 Include <errno.h>.
2886 (load_charset_map_from_file): Don't leak file descriptor on error.
2887 Use plain record_xmalloc since the allocation is larger than
2888 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2889 of entries.
2890 * eval.c (record_unwind_protect_nothing):
2891 * fileio.c (fclose_unwind):
2892 New functions.
2893 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2894 The replacement doesn't block input, but that no longer seems
2895 necessary.
2896
b648c163
PE
28972013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2898
a0931322
PE
2899 * lread.c: Fix file descriptor leaks and errno issues.
2900 (Fload): Close some races that leaked fds or streams when 'load'
2901 was interrupted.
2902 (Fload, openp): Report error number of last nontrivial failure to open.
2903 ENOENT counts as trivial.
2904 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2905 New functions.
2906 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2907 now that the function is always called with a nonnegative arg.
2908 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2909 All uses replaced with ...
2910 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2911
b648c163
PE
2912 A few more minor file errno-reporting bugs.
2913 * callproc.c (Fcall_process):
2914 * doc.c (Fsnarf_documentation):
2915 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2916 * process.c (set_socket_option):
2917 Don't let a constructor trash errno.
2918 * doc.c: Include <errno.h>.
2919
b1dc4084
JB
29202013-07-16 Juanma Barranquero <lekktu@gmail.com>
2921
2922 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2923
c43843aa
PE
29242013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2925
50a30cce
PE
2926 Fix w32 bug with call-process-region (Bug#14885).
2927 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2928 to Fcall_process when the input is empty. This simplifies the
2929 code a bit. It makes no difference on POSIXish platforms but
2930 apparently it fixes a bug on w32.
2931
44e18199 2932 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2933 * fileio.c (close_file_unwind): Don't close if FD is negative;
2934 this can happen when unwinding a zapped file descriptor.
2935 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2936 in case Emacs runs out of memory between the two unwind-protects.
2937 Don't trash errno when closing FD.
2938 Zap the FD in the specpdl when closing it, instead of deferring
2939 the removal of the unwind-protect; this fixes a bug where a child
2940 function unwinds the stack past us.
2941
27e498e6
PE
2942 New unwind-protect flavors to better type-check C callbacks.
2943 This also lessens the need to write wrappers for callbacks,
2944 and the need for make_save_pointer.
2945 * alloca.c (free_save_value):
2946 * atimer.c (run_all_atimers):
2947 Now extern.
2948 * alloc.c (safe_alloca_unwind):
2949 * atimer.c (unwind_stop_other_atimers):
2950 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2951 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2952 * minibuf.c (choose_minibuf_frame_1):
2953 * process.c (make_serial_process_unwind):
2954 * xdisp.h (pop_message_unwind):
2955 * xselect.c (queue_selection_requests_unwind):
2956 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2957 * alloca.c (record_xmalloc):
2958 Prefer record_unwind_protect_ptr to record_unwind_protect with
2959 make_save_pointer.
2960 * alloca.c (Fgarbage_collect):
2961 Prefer record_unwind_protect_void to passing a dummy.
2962 * buffer.c (restore_buffer):
2963 * window.c (restore_window_configuration):
2964 * xfns.c, w32fns.c (do_unwind_create_frame)
2965 New wrapper. All record-unwind uses of wrappee changed.
2966 * buffer.c (set_buffer_if_live):
2967 * callproc.c (call_process_cleanup, delete_temp_file):
2968 * coding.c (code_conversion_restore):
2969 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2970 * editfns.c (save_excursion_restore)
2971 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2972 (save_restriction_restore):
2973 * eval.c (restore_stack_limits, un_autoload):
2974 * fns.c (require_unwind):
2975 * keyboard.c (recursive_edit_unwind, tracking_off):
2976 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2977 * macros.c (pop_kbd_macro, restore_menu_items):
2978 * nsfns.m (unwind_create_frame):
2979 * print.c (print_unwind):
2980 * process.c (start_process_unwind):
2981 * search.c (unwind_set_match_data):
2982 * window.c (select_window_norecord, select_frame_norecord):
2983 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2984 (fast_set_selected_frame):
2985 * xfns.c, w32fns.c (unwind_create_tip_frame):
2986 Return void, not a dummy Lisp_Object. All uses changed.
2987 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2988 * callproc.c (call_process_kill):
2989 * fileio.c (restore_point_unwind, decide_coding_unwind)
2990 (build_annotations_unwind):
2991 * insdel.c (Fcombine_after_change_execute_1):
2992 * keyboard.c (read_char_help_form_unwind):
2993 * menu.c (unuse_menu_items):
2994 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2995 * sound.c (sound_cleanup):
2996 * xdisp.c (unwind_redisplay):
2997 * xfns.c (clean_up_dialog):
2998 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2999 Accept no args and return void, instead of accepting and returning
3000 a dummy Lisp_Object. All uses changed.
3001 * cygw32.c (fchdir_unwind):
3002 * fileio.c (close_file_unwind):
3003 * keyboard.c (restore_kboard_configuration):
3004 * lread.c (readevalllop_1):
3005 * process.c (wait_reading_process_output_unwind):
3006 Accept int and return void, rather than accepting an Emacs integer
3007 and returning a dummy object. In some cases this fixes an
3008 unlikely bug when the corresponding int is outside Emacs integer
3009 range. All uses changed.
3010 * dired.c (directory_files_internal_unwind):
3011 * fileio.c (do_auto_save_unwind):
3012 * gtkutil.c (pop_down_dialog):
3013 * insdel.c (reset_var_on_error):
3014 * lread.c (load_unwind):
3015 * xfns.c (clean_up_file_dialog):
3016 * xmenu.c, nsmenu.m (pop_down_menu):
3017 * xmenu.c (cleanup_widget_value_tree):
3018 * xselect.c (wait_for_property_change_unwind):
3019 Accept pointer and return void, rather than accepting an Emacs
3020 save value encapsulating the pointer and returning a dummy object.
3021 All uses changed.
3022 * editfns.c (Fformat): Update the saved pointer directly via
3023 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3024 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3025 (unwind_body): New function.
3026 (record_unwind_protect): First arg is now a function returning void,
3027 not a dummy Lisp_Object.
3028 (record_unwind_protect_ptr, record_unwind_protect_int)
3029 (record_unwind_protect_void): New functions.
3030 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3031 * fileio.c (struct auto_save_unwind): New type.
3032 (do_auto_save_unwind): Use it.
3033 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3034 * insdel.c (struct rvoe_arg): New type.
3035 (reset_var_on_error): Use it.
3036 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3037 New constants.
3038 (specbinding_func): Remove; there are now several such functions.
3039 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3040 (set_unwind_protect_ptr): New function.
3041 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3042
4e604a5d
PE
3043 Be simpler and more consistent about reporting I/O errors.
3044 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3045 Say "Read error" and "Write error", rather than "I/O error", or
3046 "IO error reading", or "IO error writing", when a read or write
3047 error occurs.
3048 * process.c (Fmake_network_process, wait_reading_process_output)
3049 (send_process, Fprocess_send_eof, wait_reading_process_output):
3050 Capitalize diagnostics consistently. Put "failed foo" at the
3051 start of the diagnostic, so that we don't capitalize the
3052 function name "foo". Consistently say "failed" for such
3053 diagnostics.
3054 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3055 All callers changed. This is so it can use report_file_error.
3056 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3057 diagnostics consistently as above.
3058
a9757f6a
PE
3059 * fileio.c (report_file_errno): Fix errno reporting bug.
3060 If the file name is neither null nor a pair, package it up as a
3061 singleton list. All callers changed, both to this function and to
3062 report_file_error. This fixes a bug where the memory allocator
3063 invoked by list1 set errno so that the immediately following
3064 report_file_error reported the wrong errno value.
3065
c43843aa
PE
3066 Fix minor problems found by --enable-gcc-warnings.
3067 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3068 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3069
18c26d81
JD
30702013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3071
3072 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3073 Set event->arg to Qt if switch-event shall be generated.
3074 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3075
3076 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3077
3078 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3079 FOCUS_OUT_EVENT.
3080
3081 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3082 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3083 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3084 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3085 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3086 and there is a focused frame.
3087 (head_table): Add focus-in and focus-out.
3088 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3089 bind to handle-focus-in/out.
3090
3091 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3092 (Fhandle_switch_frame): Call Fhandle_focus_in.
3093 (syms_of_frame): defsubr handle-focus-in/out.
3094
6c6f1994
PE
30952013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3096
c7ddc792
PE
3097 Fix porting bug to older POSIXish platforms (Bug#14862).
3098 * sysdep.c (emacs_pipe): New function, that implements
3099 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3100 This should port better to CentOS 5 and to Mac OS X 10.6.
3101 All calls to pipe2 changed.
3102
6c6f1994
PE
3103 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3104 This makes the code easier to read and the executable a bit smaller.
3105 Do not replace all calls to Fcons that happen to create lists,
3106 just calls that are intended to create lists. For example, when
3107 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3108 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3109 Similarly for list2 through list5.
3110 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3111 * bytecode.c (exec_byte_code):
3112 * callint.c (quotify_arg, Fcall_interactively):
3113 * callproc.c (Fcall_process, create_temp_file):
3114 * charset.c (load_charset_map_from_file)
3115 (Fdefine_charset_internal, init_charset):
3116 * coding.c (get_translation_table, detect_coding_system)
3117 (Fcheck_coding_systems_region)
3118 (Fset_terminal_coding_system_internal)
3119 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3120 * composite.c (update_compositions, Ffind_composition_internal):
3121 * dired.c (directory_files_internal, file_name_completion)
3122 (Fsystem_users):
3123 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3124 * doc.c (Fsnarf_documentation):
3125 * editfns.c (Fmessage_box):
3126 * emacs.c (main):
3127 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3128 (Feval, eval_sub, Ffuncall, apply_lambda):
3129 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3130 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3131 (Fset_file_times, Finsert_file_contents)
3132 (Fchoose_write_coding_system, Fwrite_region):
3133 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3134 * font.c (font_registry_charsets, font_parse_fcname)
3135 (font_prepare_cache, font_update_drivers, Flist_fonts):
3136 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3137 * frame.c (make_frame, Fmake_terminal_frame)
3138 (x_set_frame_parameters, x_report_frame_params)
3139 (x_default_parameter, Fx_parse_geometry):
3140 * ftfont.c (syms_of_ftfont):
3141 * image.c (gif_load):
3142 * keyboard.c (command_loop_1):
3143 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3144 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3145 (Fminor_mode_key_binding, accessible_keymaps_1)
3146 (Faccessible_keymaps, Fwhere_is_internal):
3147 * lread.c (read_emacs_mule_char):
3148 * menu.c (find_and_return_menu_selection):
3149 * minibuf.c (get_minibuffer):
3150 * nsfns.m (Fns_perform_service):
3151 * nsfont.m (ns_script_to_charset):
3152 * nsmenu.m (ns_popup_dialog):
3153 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3154 (Fx_own_selection_internal):
3155 * nsterm.m (append2):
3156 * print.c (Fredirect_debugging_output)
3157 (print_prune_string_charset):
3158 * process.c (Fdelete_process, Fprocess_contact)
3159 (Fformat_network_address, set_socket_option)
3160 (read_and_dispose_of_process_output, write_queue_push)
3161 (send_process, exec_sentinel):
3162 * sound.c (Fplay_sound_internal):
3163 * textprop.c (validate_plist, add_properties)
3164 (Fput_text_property, Fadd_face_text_property)
3165 (copy_text_properties, text_property_list, syms_of_textprop):
3166 * unexaix.c (report_error):
3167 * unexcoff.c (report_error):
3168 * unexsol.c (unexec):
3169 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3170 (Fformat_mode_line, syms_of_xdisp):
3171 * xfaces.c (set_font_frame_param)
3172 (Finternal_lisp_face_attribute_values)
3173 (Finternal_merge_in_global_face, syms_of_xfaces):
3174 * xfns.c (x_default_scroll_bar_color_parameter)
3175 (x_default_font_parameter, x_create_tip_frame):
3176 * xfont.c (xfont_supported_scripts):
3177 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3178 (menu_help_callback, xmenu_show):
3179 * xml.c (make_dom):
3180 * xterm.c (set_wm_state):
3181 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3182 and similarly for list2 through list5.
3183
bafe80ce
PE
31842013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 * callproc.c (Fcall_process_region): Fix minor race and tune.
3187 (create_temp_file): New function, with the temp-file-creation part
3188 of the old Fcall_process_region. Use Fcopy_sequence to create the
3189 temp file name, rather than alloca + build_string, for simplicity.
3190 Don't bother to block input around the temp file creation;
068f9124
SM
3191 shouldn't be needed. Simplify use of mktemp.
3192 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3193 this closes an unlikely race where the temp file was not removed.
3194 Use memcpy rather than an open-coded loop.
3195 (Fcall_process_region): Use the new function. If the input is
3196 empty, redirect from /dev/null rather than from a newly created
3197 empty temp file; this avoids unnecessary file system traffic.
3198
4700b5a5
PE
31992013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3200
5c97beae
PE
3201 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3202 Simplify by making this case like the other two. This is a bit
3203 slower on obsolete hosts, but the extra complexity isn't worth it.
3204
4700b5a5
PE
3205 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3206 * process.c (create_process) [!DOS_NT]:
3207 Remove now-unnecessary calls to emacs_close.
3208
f9a74c4c
EZ
32092013-07-13 Eli Zaretskii <eliz@gnu.org>
3210
922ae7ee
EZ
3211 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3212 returning early. (Bug#14850)
3213
f9a74c4c
EZ
3214 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3215 and inhibit-iso-escape-detection attributes of 'undecided'.
3216 (Bug#14822)
3217
5e301d76
PE
32182013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3219
69e0e5ee
PE
3220 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3221 Reported by Herbert J. Skuhra in
3222 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3223
5e301d76
PE
3224 Don't lose top specpdl entry when memory is exhausted.
3225 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3226 specpdl overflow here, to simplify callers; all callers changed.
3227 Always reserve an unused entry at the stack top; this avoids
3228 losing the top entry's information when memory is exhausted.
3229
7e649856
PE
32302013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3231
a773ed9a
PE
3232 Clean up errno reporting and fix some errno-reporting bugs.
3233 * callproc.c (Fcall_process):
3234 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3235 * process.c (create_process, Fmake_network_process):
3236 * unexaix.c (report_error):
3237 * unexcoff.c (report_error):
3238 Be more careful about reporting the errno of failed operations.
3239 The code previously reported the wrong errno sometimes.
3240 Also, prefer report_file_errno to setting errno + report_file_error.
3241 (Fcall_process): Look at openp return value rather than at path,
3242 as that's a bit faster and clearer when there's a numeric predicate.
3243 * fileio.c (report_file_errno): New function, with most of the
3244 old contents of report_file_error.
3245 (report_file_error): Use it.
3246 (Ffile_exists_p, Ffile_accessible_directory_p):
3247 Set errno to 0 when it is junk.
3248 * fileio.c (Faccess_file):
3249 * image.c (x_create_bitmap_from_file):
3250 Use faccessat rather than opening the file, to avoid the hassle of
3251 having a file descriptor open.
3252 * lisp.h (report_file_errno): New decl.
3253 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3254
7e649856
PE
3255 Minor EBADF fixes.
3256 * process.c (create_process, wait_reading_process_output) [AIX]:
3257 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3258 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3259 a multithreaded environment anyway).
3260 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3261
f6774c1a
AS
32622013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3263
3264 * image.c (x_find_image_file): Don't close a remote file handle.
3265
bacba3c2
PE
32662013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3267
3268 Fix races with threads and file descriptors.
3269 * callproc.c (Fcall_process_region):
3270 * dired.c (open_directory):
3271 * emacs.c (main, Fdaemon_initialized):
3272 * image.c (x_find_image_file):
3273 * inotify.c (Finotify_rm_watch):
3274 * lread.c (Flocate_file_internal):
3275 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3276 * term.c (term_mouse_moveto, init_tty):
3277 * termcap.c (tgetent):
3278 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3279 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3280 * unexhp9k800.c, unexmacosx.c (unexec):
3281 * callproc.c (Fcall_process_region):
3282 Use emacs_close, not close.
3283 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3284 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3285 and posix_close function on current platforms (which all lack them).
3286 (emacs_close): Use it. This should fix the races on GNU/Linux and
3287 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3288 and it should avoid closing random victim file descriptors on
3289 other platforms.
3290
653d4f43
PE
32912013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3292
c8536ec4
PE
3293 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3294 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3295 Touch up doc a bit.
3296
9c203066
PE
3297 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3298 This is for .gdbinit xbacktrace.
3299
653d4f43
PE
3300 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3301 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3302 (emacs_set_tty): Now static.
3303 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3304 * term.c (tty_capable_p, tty_default_color_capabilities)
3305 (get_tty_terminal, term_mouse_movement)
3306 (handle_one_term_event, init_tty, maybe_fatal):
3307 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3308 (tgetent, scan_file, name_match, compare_contin):
3309 * terminal.c (get_terminal):
3310 Use bool for boolean.
3311 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3312 Prefer char to unsigned char if either will do.
3313 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3314 (tty_write_glyphs): Prefer int to unsigned.
3315 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3316 All callers changed.
3317 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3318
45b683a1
PE
33192013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3320
29abe551
PE
3321 Port to C89.
3322 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3323 (B__dummy__): New dummy symbol, to pacify C89.
3324 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3325 they can't grok varargs macros.
3326 * dispnew.c (add_window_display_history)
3327 (add_frame_display_history):
3328 * print.c (print_object):
3329 * xdisp.c (debug_method_add):
3330 Use %p printf format only for void pointers.
3331 * emacs.c (usage_message): New constant, replacing ...
3332 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3333 (main): Adjust to usage reorg.
3334 * fns.c (syms_of_fns):
3335 * profiler.c (syms_of_profiler):
3336 Don't use non-constant struct initializers.
3337 * gnutls.h (gnutls_initstage_t):
3338 * lisp.h (enum Lisp_Fwd_Type):
3339 * lread.c (lisp_file_lexically_bound_p):
3340 * xsettings.c (anonymous enum):
3341 Remove trailing comma.
3342 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3343 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3344 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3345 (DEFUN): Use it.
3346 * regex.c (const_re_char): New type, to pacify strict C89.
3347 All uses of 'const re_char' replaced to use it.
3348 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3349 with glibc when strict C89. This change is imported from gnulib.
3350 All uses changed.
3351 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3352 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3353 Omit GNU_LINUX implementation, since it requires long long.
3354 * xterm.c (x_draw_underwave):
3355 Do not assume the traditional order of struct's members.
3356 (x_term_init): Rewrite to avoid the need for non-constant structure
3357 initializers.
3358
45b683a1 3359 Syntax cleanup, mostly replacing macros with functions.
763a086d 3360 This removes the need for the syntax_temp hack.
45b683a1
PE
3361 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3362 * syntax.c (SYNTAX_INLINE): New macro.
3363 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3364 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3365 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3366 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3367 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3368 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3369 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3370 Now constants, not macros.
3371 (syntax_temp) [!__GNUC__]: Remove.
3372 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3373 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3374 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3375 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3376 Move here from syntax.h; now functions, not macros. Except for the
3377 last function, these are static since only syntax.c uses them.
3378 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3379 All uses changed. Now a function, not a macro; use this fact
3380 to simplify the code.
3381 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3382 compiler bugs; no longer relevant.
3383 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3384 (SYNTAX_INLINE): New macro.
3385 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3386 for the new functions. Use bool for boolean member.
3387 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3388 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3389 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3390 (SETUP_BUFFER_SYNTAX_TABLE):
3391 Now extern inline functions, not macros.
3392 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3393 Remove; all uses replaced by implementation.
3394 (syntax_temp) [!__GNUC__]: Remove decl.
3395 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3396
29be4a50
JD
33972013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3398
3399 * emacs.c (main): Fix syntax error.
3400
954b166e
PE
34012013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 Timestamp fixes for undo (Bug#14824).
3404 * atimer.c (schedule_atimer):
3405 * fileio.c (Ffile_newer_than_file_p):
3406 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3407 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3408 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3409 (syms_of_fileio): Remove Sclear_visited_file_name.
3410 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3411 file doesn't exist; this avoids an ambiguity with negative timestamps.
3412 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3413 * systime.h (make_emacs_time, invalid_emacs_time):
3414 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3415 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3416 * undo.c (record_first_change): Push (visited-file-modtime) onto
3417 undo list rather than reimplementing it by hand, incorrectly.
3418
d74647c3
KB
34192013-07-09 Ken Brown <kbrown@cornell.edu>
3420
3421 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3422
3c51b96b
JB
34232013-07-09 Juanma Barranquero <lekktu@gmail.com>
3424
3425 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3426
4ebbdd67
PE
34272013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3428
3429 Handle errno and exit status a bit more carefully.
3430 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3431 number into an exit status. Instead, use EXIT_CANCELED.
3432 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3433 * callproc.c (relocate_fd):
3434 * emacs.c (close_output_streams, main):
3435 * process.c (create_process):
3436 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3437 Use emacs_perror for simplicity.
3438 * callproc.c (relocate_fd, main):
3439 * sysdep.c (sys_subshell):
3440 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3441 (shut_down_emacs): Use emacs_write, not write.
3442 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3443 * fileio.c (Fcopy_file, e_write):
3444 * nsterm.m (ns_select):
3445 * process.c (send_process):
3446 * sound.c (vox_write):
3447 Use emacs_write_sig, not emacs_write.
3448 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3449 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3450 New constants.
3451 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3452 of write.
3453 (emacs_full_write): New function.
3454 (emacs_write): Rewrite to use it.
3455 (emacswrite_sig, emacs_perror): New functions.
3456 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3457
44e18199 34582013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3459
3460 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3461 on NS even if it is present. Pixmap on NS is a void*.
3462
9caab067
PE
34632013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3464
3465 Port to Ubuntu 10 (Bug#14803).
3466 Problem reported by T.V. Raman.
3467 * process.c (close_on_exec, accept4, process_socket):
3468 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3469
1d442672
EZ
34702013-07-07 Eli Zaretskii <eliz@gnu.org>
3471
3472 * w32.c (sys_dup): Declare prototype.
3473
3474 * filelock.c:
3475 * emacs.c:
3476 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3477
067428c1
PE
34782013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3479
3480 Make file descriptors close-on-exec when possible (Bug#14803).
3481 This simplifies Emacs a bit, since it no longer needs to worry
3482 about closing file descriptors by hand in some cases.
3483 It also fixes some unlikely races. Not all such races, as
3484 libraries often open files internally without setting
3485 close-on-exec, but it's an improvement.
3486 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3487 * callproc.c (Fcall_process) [!MSDOS]:
3488 * emacs.c (main) [!DOS_NT]:
3489 * nsterm.m (ns_term_init):
3490 * process.c (create_process):
3491 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3492 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3493 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3494 Prefer mkostemp with O_CLOEXEC to mkstemp.
3495 * callproc.c (relocate_fd) [!WINDOWSNT]:
3496 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3497 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3498 now using pipe2.
3499 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3500 Make the resulting file descriptor close-on-exec.
3501 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3502 * lread.c (load_descriptor_list, load_descriptor_unwind):
3503 Remove; no longer needed. All uses removed.
3504 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3505 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3506 New functions.
3507 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3508 (Fmake_network_process, Fnetwork_interface_list):
3509 (Fnetwork_interface_info, server_accept_connection):
3510 Make newly-created socket close-on-exec.
3511 * sysdep.c (emacs_open, emacs_fopen):
3512 Make new-created descriptor close-on-exec.
3513 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3514 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3515
0da857dd
JD
35162013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3517
3518 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3519 for NS_IMPL_GNUSTEP.
3520
5f86adcd
PE
35212013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 Fix openp errno handling.
3524 * callproc.c (Fcall_process): Preserve openp errno around close.
3525 * lread.c (openp): Set errno when returning -1, as some callers
3526 expect this.
3527
1afb1d07
JD
35282013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3529
3530 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3531
3532 * nsterm.h (NSSavePanel): Update comment.
3533 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3534 (ns_run_file_dialog): Declare.
3535
3536 * nsfns.m: Remove panelOK.
3537 (ns_fd_data): New.
3538 (ns_run_file_dialog): New function.
3539 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3540 event loop, so file dialog is popped up by ns_run_file_dialog, called
3541 by sendEvent (Bug#14578).
3542 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3543
3323c263
EZ
35442013-07-06 Eli Zaretskii <eliz@gnu.org>
3545
fdda0220
EZ
3546 * xdisp.c (default_line_pixel_height): New function.
3547 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3548 (try_cursor_movement, redisplay_window, try_window)
3549 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3550
068f9124
SM
3551 * window.c (window_scroll_pixel_based):
3552 use default_line_pixel_height.
fdda0220
EZ
3553
3554 * dispextern.h (default_line_pixel_height): Add prototype.
3555
3556 * frame.c (x_set_line_spacing): Accept a float value for
3557 line-spacing parameter, per the documentation.
3558
3323c263
EZ
3559 * data.c (Fmultibyte_string_p): Doc fix.
3560
47ba6d43
PE
35612013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3562
406af475
PE
3563 Use emacs_open more consistently when opening files.
3564 This handles EINTR more consistently now, and makes it easier
3565 to introduce other uniform changes to file descriptor handling.
3566 * src/systdio.h: New file.
3567 * src/buffer.c (mmap_init):
3568 * cygw32.c (chdir_to_default_directory):
3569 * dispnew.c (Fopen_termscript):
3570 * emacs.c (Fdaemon_initialized):
3571 * fileio.c (Fdo_auto_save):
3572 * image.c (slurp_file, png_load_body, jpeg_load_body):
3573 * keyboard.c (Fopen_dribble_file):
3574 * lread.c (Fload):
3575 * print.c (Fredirect_debugging_output):
3576 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3577 * termcap.c (tgetent):
3578 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3579 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3580 * w32term.c (w32_initialize) [CYGWIN]:
3581 * xfaces.c (Fx_load_color_file):
3582 Use emacs_open instead of plain open, and emacs_fopen instead of
3583 plain fopen.
3584 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3585 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3586 * callproc.c (default_output_mode): New constant.
3587 (Fcall_process): Use it to call emacs_open instead of plain creat.
3588 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3589 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3590 (emacs_fopen): New function.
3591 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3592 Include <lisp.h>, for emacs_open.
3593 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3594
47ba6d43
PE
3595 Remove duplicate #include directives.
3596 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3597 * xfaces.c:
3598 Don't include stdio.h twice.
3599 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3600 Don't include sys/types.h or stdio.h twice.
3601 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3602 * lread.c: Don't include coding.h twice.
3603 * nsfont.m: Don't include frame.h twice.
3604 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3605 * ralloc.c: Don't include <unistd.h> twice.
3606 * xdisp.c: Don't include font.h twice.
3607 * xterm.c: Don't include fontset.h twice.
3608 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3609
b9ed53d5
PE
36102013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 Scale ImageMagick images more carefully.
3613 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3614 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3615 Be more careful about avoiding undefined behavior after
3616 integer overflow and division by zero.
3617
cf13177e
YM
36182013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3619
3620 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3621 (syms_of_w32fns): DEFSYM them.
3622 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3623 (CCHDEVICENAME): Define macros if not defined.
3624 (struct MONITOR_INFO_EX): New struct.
3625 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3626 (enum_display_monitors_fn): New variable.
3627 (globals_of_w32fns): Initialize it.
3628 (Fx_display_pixel_width, Fx_display_pixel_height)
3629 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3630 multi-monitor setups in docstrings.
3631 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3632 screen size by primary monitor's millimeter per pixel.
3633 (w32_monitor_enum, w32_display_monitor_attributes_list)
3634 (w32_display_monitor_attributes_list_fallback)
3635 (Fw32_display_monitor_attributes_list): New functions.
3636 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3637
3638 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3639 if not defined.
3640 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3641
86dfb7a8
MA
36422013-07-04 Michael Albinus <michael.albinus@gmx.de>
3643
3644 * fileio.c (Qfile_notify_error): New error symbol.
3645
3646 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3647 * inotify.c (inotify_callback, symbol_to_inotifymask)
3648 (Finotify_add_watch, Finotify_rm_watch): Use it.
3649 (inotifyevent_to_event): Exchange order of cookie and file name.
3650 (Finotify_add_watch): Adapt docstring.
3651
3652 * lisp.h (Qfile_notify_error): Declare.
3653
2c1c974b
PE
36542013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3657 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3658 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3659 which did not work (see <http://bugs.gnu.org/14569#307>).
3660 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3661 && (!noninteractive || initialized)). This attempts to thread
3662 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3663
7a35b20f
JB
36642013-07-04 Juanma Barranquero <lekktu@gmail.com>
3665
3666 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3667 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3668
1ce5cd04
PE
36692013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3672 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3673 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3674 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3675
57f8c490
PE
36762013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3679 Define to __sys_siglist.
3680
bcffb5ca
EZ
36812013-07-02 Eli Zaretskii <eliz@gnu.org>
3682
3683 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3684 word-wrap, so that overflow-newline-into-fringe would work in
3685 visual-line-mode. (Bug#2749)
3686 (move_it_in_display_line_to): When the last scanned display
3687 element fits exactly on the display line, and
3688 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3689 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3690 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3691 finding buffer position that corresponds to pixel coordinates,
3692 e.g. in buffer_posn_from_coords.
3693
2c41e781
JD
36942013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3695
3696 * process.c (handle_child_signal): Call catch_child_signal if
3697 NS_IMPL_GNUSTEP.
3698
c2418359
PE
36992013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3700
52a9bcae
PE
3701 Don't convert function pointers to void * and back.
3702 It isn't portable C, and it's easy enough to avoid.
3703 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3704 (make_save_value): Add support for SAVE_FUNCPOINTER.
3705 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3706 * print.c (print_object):
3707 Distinguish function from object pointers.
3708 * lisp.h (SAVE_FUNCPOINTER): New constant.
3709 (SAVE_SLOT_BITS): Adjust to it.
3710 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3711 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3712 (voidfuncptr): New typedef.
3713 (struct Lisp_Save_Value): New member data[0].funcpointer.
3714 (XSAVE_FUNCPOINTER): New function.
3715
c2418359
PE
3716 Simplify buildobj processing.
3717 * Makefile.in (buildobj.h): Make it a sequence of strings each
3718 followed by comma, rather than a single string. Put it into a
3719 .tmp file in case there's an error while generating it.
3720 (gl-stamp): Use .tmp for temp files.
3721 (mostlyclean): Clean .tmp files.
3722 * doc.c (buildobj): Move to just the routine that needs it.
3723 It's now an array of strings, so processing is simpler.
3724
8f43ce49
PE
37252013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3726
3727 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3728 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3729 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3730 Invoke malloc_enable_thread even when not interactive.
3731 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3732 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3733 in this case, since the underlying bug has now been fixed.
3734
24827db9
JB
37352013-07-01 Juanma Barranquero <lekktu@gmail.com>
3736
3737 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3738 unlinking it (bug#14691).
3739
ef099a94
MN
37402013-06-30 Michal Nazarewicz <mina86@mina86.com>
3741
3742 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3743 before checking whether buffer is modified. This lets
3744 `kill-buffer-query-functions' cancel killing of the buffer or save
3745 its content before `kill-buffer' asks user the "Buffer %s
3746 modified; kill anyway?" question.
3747
9d3f2fc2
JD
37482013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3749
3750 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3751 Let the super performKeyEquivalent deal with them (Bug#14747).
3752
e6c6c8c7
PE
37532013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3754
1d71c1d9
PE
3755 * widget.c (resize_cb): Remove unused local.
3756
8f5f35cc
PE
3757 Do not use GTK 3 if it exists but cannot be compiled.
3758 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3759 * xterm.c (x_error_handler) [!USE_GTK]:
3760 Do not use GTK 3.
3761
e6c6c8c7
PE
3762 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3763
0ba54312
EZ
37642013-06-30 Eli Zaretskii <eliz@gnu.org>
3765
5d1c3286
EZ
3766 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3767 to the valid range of values. (Bug#14753)
3768
0ba54312
EZ
3769 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3770 when moving point by using the current glyph matrix. This avoids
3771 the need to force redisplay when this function is called in a
3772 loop.
3773
9c90cc06
PE
37742013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3775
3776 Fix minor problems found by static checking.
3777 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3778 Redo the latter's body to sidestep GCC parenthesization warnings.
3779 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3780 * coding.c (detect_coding, detect_coding_system):
3781 * coding.h (struct undecided_spec):
3782 Use bool for boolean.
3783 * image.c (QCmax_width, QCmax_height): Now static.
3784 * xdisp.c (Fmove_point_visually): Remove unused local.
3785
4c672a0f
EZ
37862013-06-29 Eli Zaretskii <eliz@gnu.org>
3787
3788 * xdisp.c (Fmove_point_visually): New function.
3789
c1ea3abf
JB
37902013-06-28 Kenichi Handa <handa@gnu.org>
3791
3792 * coding.h (define_coding_undecided_arg_index): New enum.
3793 (coding_attr_index): New members
3794 coding_attr_undecided_inhibit_null_byte_detection,
3795 coding_attr_undecided_inhibit_iso_escape_detection,
3796 coding_attr_undecided_prefer_utf_8.
3797 (undecided_spec): New struct.
3798 (struct coding_system): New member `undecided' of the member
3799 `spec'.
3800
3801 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3802 (detect_coding): Likewise.
3803 (detect_coding_system): Likewise.
3804 (Fdefine_coding_system_internal): New coding system properties
3805 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3806 :prefer-utf-8.
3807 (syms_of_coding): Adjust for coding_arg_undecided_max.
3808
ba3de9e6
PE
38092013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3810
3811 * image.c (x_from_xcolors): Remove unused local.
3812
547c9269
YM
38132013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3814
3815 Defer image data transfer between X client and server until actual
3816 display happens.
3817
3818 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3819 and `mask_img'.
3820
3821 * image.c (Destroy_Image): Remove.
3822 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3823 `mask_p', and `colors_p'. All uses changed.
3824 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3825 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3826 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3827 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3828 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3829 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3830 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3831 (image_get_x_image, image_unget_x_image): New functions or macros.
3832 (image_background, image_background_transparent, x_to_xcolors)
3833 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3834 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3835 instead of Destroy_Image.
3836 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3837 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3838 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3839 (imagemagick_load_image, svg_load_image): Use them instead of
3840 x_create_x_image_and_pixmap, and x_put_x_image followed by
3841 x_destroy_x_image, respectively.
3842 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3843 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3844 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3845 background_transparent fields.
3846 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3847 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3848
dae2f5ef
PE
38492013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3850
3851 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3852 This mostly consists of undoing recent changes.
3853 * callproc.c (Fcall_process):
3854 * process.c (create_process):
3855 Do not worry about catching SIGCHLD here, undoing previous change.
3856 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3857 * process.c, process.h (catch_child_signal):
3858 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3859 * process.c (catch_child_handler): Don't worry about being called
3860 lazily and do not assume caller has blocked SIGCHLD, undoing
3861 previous change. Move first-time stuff back to
3862 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3863 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3864 set lib_child_handler if it's already initialized, which may
3865 help avoid problems on GNUStep.
3866
fa55d2aa
PE
38672013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3868
3869 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3870 * callproc.c (Fcall_process):
3871 * process.c (create_process):
3872 Make sure SIGCHLD is caught before we fork,
3873 since Emacs startup no arranges to catch SIGCHLD.
3874 * process.c (lib_child_handler): Initialize to null, not to
3875 dummy_handler.
3876 (catch_child_signal): Allow self to be called lazily.
3877 Do nothing if it's already been called.
3878 Assume caller has blocked SIGCHLD (all callers do now).
3879 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3880 just before it's really needed.
3881 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3882 since it hasn't been caught yet.
3883
f3f9606c
LMI
38842013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3885
3886 * image.c (compute_image_size): New function to implement
3887 :max-width and :max-height.
3888 (imagemagick_load_image): Use it.
3889
c7041908
PE
38902013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3893 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3894 Now extern.
3895 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3896 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3897 the SIGCHLD handler, since the code is not atomic and (due to glib)
3898 signals may be arriving now.
3899 * sysdep.c (init_signals): Do not catch child signals here;
3900 'main' now does that later, at a safer time.
3901
f86852b4
PE
39022013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3903
0dfeed58
PE
3904 Clean up SIGCHLD handling a bit (Bug#14569).
3905 * process.c, process.h (catch_child_signal):
3906 Now always extern, even if !NS_IMPL_GNUSTEP.
3907 * process.c (catch_child_signal): Move glib tickler here from
3908 init_process_emacs, so that it's done earlier in Emacs
3909 initialization. Also move the noninteractive && !initialized
3910 check here from init_process_emacs. This is all a bit cleaner for
3911 GNUish platforms, and I hope it works around the Cygwin bug.
3912 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3913 that glib signal handling is tickled before glib creates threads.
3914
f86852b4
PE
3915 * process.c (wait_reading_process_output): Avoid int overflow
3916 when reading more than 2 GiB total from a process.
3917
cbd6509c
PE
39182013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3919
3920 * process.c (create_process): Handle a couple more cases,
3921 i.e., work even if new_argv and wait_child_setup[i] are cached.
3922 Use Fcall_process's style for volatile vars.
3923
9de1114a
AS
39242013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3925
3926 * process.c (create_process): Mark PROCESS volatile.
3927
fbe9e0b9
PE
39282013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3929
3930 Use C99-style flexible array members if available.
3931 This avoids some subtle aliasing issues, which typically
3932 aren't a problem with GCC but may be a problem elsewhere.
3933 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3934 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3935 In either case, it uses a flexible array member rather than
3936 the old struct hack. All uses changed.
3937 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3938 Adjust to sdata reorganization.
3939 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3940 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3941 that ports better to pre-C99 non-GCC.
3942 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3943 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3944 as the latter has changed.
3945 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3946 and port better to pre-C99 GCC.
3947 * image.c (struct xpm_cached_color):
3948 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3949 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3950 Use FLEXIBLE_ARRAY_MEMBER.
3951 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3952 Move decl to top level so it gets checked against implementation.
3953 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3954 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3955
1fc71008
PE
39562013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 * syntax.c: Integer cleanups.
3959 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3960 All uses that need 0-or-2 changed to:
3961 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3962 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3963 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3964 (char_quoted, prev_char_comend_first, back_comment)
3965 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3966 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3967 Use bool for boolean.
3968 (update_syntax_table, skip_chars, skip_syntaxes):
3969 Prefer int to unsigned when either will do.
3970 (back_comment): Return boolean success flag, like forw_comment,
3971 instead of positive-or-minus-1 (which might have overflowed int anyway).
3972 Don't stuff ptrdiff_t into int.
3973 (syntax_spec_code, syntax_code_spec): Now const.
3974 (Fmatching_paren, scan_lists, scan_sexps_forward):
3975 Use enum syntaxcode for syntax code.
3976 (Fmatching_paren): Check that arg is a character, not just an integer.
3977 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3978 (Finternal_describe_syntax_value): Omit no-longer-needed
3979 comparison to 0.
3980 (skip_chars): Use char, not unsigned char, when the distinction
3981 doesn't matter.
3982 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3983 * bytecode.c (exec_byte_code):
3984 * syntax.c (syntax_spec_code, Fchar_syntax)
3985 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3986 (init_syntax_once):
3987 * syntax.h (SYNTAX_WITH_FLAGS):
3988 Omit unnecessary casts.
3989
b932cad7
EZ
39902013-06-20 Eli Zaretskii <eliz@gnu.org>
3991
3992 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3993 line dimensions here, to avoid race conditions with the main
3994 thread. (Bug#14062, bug#14630, bug#14669)
3995
3996 * w32term.c (w32_draw_window_cursor): Compute the header line and
3997 mode line dimensions here.
3998 <w32_system_caret_window, w32_system_caret_hdr_height>:
3999 <w32_system_caret_mode_height>: New variables.
4000
4001 * w32term.h: Declare them.
4002
89561f72
PE
40032013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4004
5013fc08
PE
4005 * alloc.c (die): Move "assertion failed" string here ...
4006 * lisp.h (eassert): ... from here. Also, suppress evaluation of
4007 COND when SUPPRESS_CHECKING. This shrinks the executable text
4008 size by 0.8% to 2.2% when configured with --enable-checking,
4009 depending on optimization flags (GCC 4.8.1 x86-64).
4010
89561f72
PE
4011 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
4012
763a086d 40132013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
4014
4015 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4016 base is 2; this is more accurate.
4017
983aeb9a
JB
40182013-06-19 Juanma Barranquero <lekktu@gmail.com>
4019
4020 * sound.c (string_default): Move to !WINDOWSNT section.
4021 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4022
178ba3e6
PE
40232013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4024
bbc51b15
PE
4025 * sound.c: Integer cleanups.
4026 Remove unnecessary forward decls.
4027 (struct sound_device): The 'file' member is now a Lisp_Object, not
4028 a char *, so that we needn't invoke alloca on a huge size.
4029 (Fplay_sound_internal): Adjust to this.
4030 (string_default): New function.
4031 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4032 Use it to adjust to the struct sound_device change.
4033 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4034 (be2hs) [0]: Remove.
4035
178ba3e6
PE
4036 * syntax.c (skip_chars): Don't use uninitialized storage
4037 when searching a multibyte buffer for characters that are not in a
4038 unibyte string that contains non-ASCII characters.
4039
69f60cdc
JD
40402013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4041
4042 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4043 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4044
0d6224d4
PE
40452013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4046
4047 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4048
3c542890
KH
40492013-06-18 Kenichi Handa <handa@gnu.org>
4050
f7e3f7cd
KH
4051 * font.c (Ffont_spec): Signal an error for an invalid font name
4052 (Bug#14648).
3c542890 4053
9349e5f7
PE
40542013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4055
4056 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4057 In particular this ports to 32-bit sparc Sun cc.
4058 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4059 array with a dummy element at specpdl[-1], so that its address can
4060 be taken portably.
4061 (unbind_to): Do not copy the binding; not needed, now that we
4062 copy old_value in the one place where the copy is needed.
4063 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4064 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4065 (union specbinding): Rename from struct specbinding. Redo layout
4066 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4067 which is not portable. With Sun C 5.12 32-bit sparc, the
4068 declaration causes nargs to be an unsigned bitfield, a behavior
4069 that the C standard allows; but Emacs wants nargs to be signed.
4070 The overall type is now a union of structures rather than a
4071 structure of union of structures, and the 'kind' member is now a
4072 bitfield, so that the overall type doesn't grow. All uses changed.
4073 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4074
0a4df6a5
PE
40752013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4076
ec6ecaad
PE
4077 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4078 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4079
0a4df6a5
PE
4080 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4081
7bfe8dbc
EZ
40822013-06-17 Eli Zaretskii <eliz@gnu.org>
4083
4084 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4085 unless we know that the window w's frame is a frame object.
4086 Another attempt at solving bug#14062 and bug#14630.
4087
708e05f6
LMI
40882013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4089
4090 * textprop.c (property_set_type): New enum.
4091 (add_properties): Allow appending/prepending text properties.
4092 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4093 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4094 add_text_properties_1.
4095 (Fadd_face_text_property): New function that calls
4096 add_text_properties_1.
4097
84575e67
PE
40982013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4099
4100 Move functions from lisp.h to individual modules when possible.
4101 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4102 * alloc.c (XFLOAT_INIT, set_symbol_name):
4103 * buffer.c (CHECK_OVERLAY):
4104 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4105 (set_char_table_parent):
4106 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4107 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4108 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4109 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4110 (set_blv_valcell):
4111 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4112 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4113 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4114 (backtrace_args, backtrace_debug_on_exit):
4115 * floatfns.c (CHECK_FLOAT):
4116 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4117 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4118 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4119 (set_hash_index_slot):
4120 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4121 * marker.c (CHECK_MARKER):
4122 * textprop.c (CHECK_STRING_OR_BUFFER):
4123 * window.c (CHECK_WINDOW_CONFIGURATION):
4124 Move here from lisp.h, and make these functions static rather than
4125 extern inline.
4126 * buffer.c (Qoverlayp):
4127 * data.c (Qsubrp):
4128 * fns.c (Qhash_table_p):
4129 * window.c (Qwindow_configuration_p):
4130 Now static.
4131 * lisp.h: Remove the abovementioned defns and decls.
4132
44e18199 4133 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4134 In lisp.h, prefer functions to function-like macros, and
4135 constants to object-like macros, when either will do. This:
4136 . simplifies use, as there's no more need to worry about
4137 arguments' side effects being evaluated multiple times.
4138 . makes the code easier to debug on some platforms.
4139 However, when using gcc -O0, keep using function-like macros
4140 for a few critical operations, for performance reasons.
4141 This sort of thing isn't needed with gcc -Og, but -Og
4142 is a GCC 4.8 feature and isn't widely-enough available yet.
4143 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4144 Remove enum lsb_bits; no longer needed.
4145 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4146 * buffer.c (Qoverlap):
4147 * data.c (Qsubrp):
4148 * fns.c (Qhash_table_p):
4149 Now extern, so lisp.h can use these symbols.
4150 * dispextern.h: Include character.h, for MAX_CHAR etc.
4151 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4152 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4153 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4154 (GLYPH_CODE_P): Move here from lisp.h.
4155 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4156 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4157 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4158 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4159 XUNTAG now returns void *.
4160 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4161 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4162 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4163 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4164 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4165 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4166 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4167 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4168 New macros, renamed from their sans-lisp_h_ counterparts.
4169 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4170 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4171 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4172 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4173 If compiling via GCC without optimization, define these as macros
4174 in addition to inline functions.
4175 To disable this, compile with -DINLINING=0.
4176 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4177 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4178 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4179 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4180 (INTMASK, VALMASK): Now macros, since static values cannot be
4181 accessed from extern inline functions.
4182 (VALMASK): Also a constant, for benefit of old GDB.
4183 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4184 is INTEGERP, which can fold it in.
5165d44a 4185 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4186 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4187 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4188 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4189 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4190 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4191 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4192 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4193 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4194 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4195 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4196 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4197 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4198 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4199 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4200 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4201 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4202 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4203 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4204 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4205 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4206 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4207 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4208 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4209 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4210 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4211 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4212 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4213 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4214 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4215 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4216 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4217 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4218 Now functions.
4219 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4220 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4221 (VALMASK): Define in one place rather than in two, merging the
4222 USE_LSB_TAG parts; this is simpler.
4223 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4224 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4225 Move up, to avoid use before definition.
4226 Also include "globals.h" earlier, for the same reason.
4227 (make_natnum): New function.
4228 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4229 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4230 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4231 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4232 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4233 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4234 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4235 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4236 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4237 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4238 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4239 (Qwindow_configuration_p, Qimage): New forward declarations.
4240 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4241 (STRING_COPYIN): Remove; unused.
4242 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4243 (xcar_addr, xcdr_addr): New functions. All uses changed.
4244 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4245 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4246 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4247 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4248 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4249 (TYPE_RANGED_INTEGERP): Simplify.
4250 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4251 (setlocale, fixup_locale, synchronize_system_messages_locale)
4252 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4253 Now empty functions, not macros.
4254 (functionp): Return bool, not int.
4255 * window.c (Qwindow_configuration_p): Now extern,
4256 so window.h can use it.
4257 * window.h (Qwindowp): Move decl back to lisp.h.
4258
9583ec36
EZ
42592013-06-15 Eli Zaretskii <eliz@gnu.org>
4260
4261 * xdisp.c (Fline_pixel_height): New function, required for solving
4262 bug #14567.
4263
210272ce
PE
42642013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4265
4266 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4267
de0503df
SM
42682013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4269
4270 * lread.c (syms_of_lread):
4271 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4272
afbfe143
KD
42732013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4274
4275 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4276
d177e213
XF
42772013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4278
4279 * fileio.c (expand_file_name): Doc fix.
4280
05e3e412
PE
42812013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4282
f7394b12
PE
4283 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4284 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4285 Wait for self, not for 0. This can't hurt on GNU or similar
4286 system, and may help with Cygwin.
4287
05e3e412
PE
4288 * keyboard.c: Don't use PROP (...) as an lvalue.
4289 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4290 Use set_prop (A, B), not PROP (A) = B.
4291
17dd3097
EZ
42922013-06-10 Eli Zaretskii <eliz@gnu.org>
4293
4294 * xdisp.c (get_it_property): Use it->window instead of generating
4295 a Lisp object from it->w.
4296
52fab9c9
EZ
42972013-06-09 Eli Zaretskii <eliz@gnu.org>
4298
4299 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4300 get-char-property the window that is being rendered, instead of
4301 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4302 (compute_display_string_pos): When W is NULL, use the current
4303 buffer as the object to pass to get-char-property.
4304 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4305 pointer member of the bidi iterator, since no window is pertinent
4306 to this function.
52fab9c9 4307
5bf97bfc
EZ
43082013-06-08 Eli Zaretskii <eliz@gnu.org>
4309
4310 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4311 being displayed, and pass it to compute_display_string_pos.
4312 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4313 (bidi_paragraph_init): All callers changed.
4314
4315 * xdisp.c (init_from_display_pos, init_iterator)
4316 (handle_single_display_spec, next_overlay_string)
4317 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4318 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4319 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4320 (compute_display_string_pos): Accept additional argument, the
4321 window being displayed, and pass it to Fget_char_property.
4322 (Bug#14575)
4323
4324 * dispextern.h (struct bidi_it): New member w, the window being
4325 displayed.
4326 (compute_display_string_pos): Adjust prototype.
4327
5de0e011
JD
43282013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4329
e7b41c4c 4330 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4331
4332 * process.c (wait_reading_process_output): Check for NS before GLIB.
4333 GLIB may be linked in due to rsvg, but ns_select must be called.
4334
5de0e011
JD
4335 * xgselect.c (xg_select): Remove call to window_system_available
4336 and g_main_context_pending at the top, so Gdk events (i.e. file
4337 notify) are processed when Emacs is started with -nw.
4338
a822acff
EZ
43392013-06-07 Eli Zaretskii <eliz@gnu.org>
4340
4341 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4342 (ctagsfiles3): New variable, includes only *.m files.
4343 (TAGS): Use an explicit language name in the regular expressions,
4344 to avoid transformation of '/SOMETHING' by MSYS to
4345 'c:\MSYS\SOMETHING'.
4346
6c0a9ed1
RC
43472013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4348
4349 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4350
9ef6111b
EZ
43512013-06-06 Eli Zaretskii <eliz@gnu.org>
4352
4353 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4354 still need to set the mouse pointer shape and activate help-echo.
4355 (Bug#14558)
4356
7d300d64
PE
43572013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4358
4359 A few porting etc. fixes for the new file monitor code.
4360 See the thread containing
4361 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4362 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4363 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4364 (dir_monitor_callback, Fgfile_rm_watch):
4365 Use assq_no_quit instead of Fassoc, for speed.
4366 (dir_monitor_callback, Fgfile_rm_watch):
4367 eassert that the monitor is a fixnum.
4368 (dir_monitor_callback): No need for CDR_SAFE.
4369 Simplify building of lisp with alternative tails.
4370 (Fgfile_add_watch, Fgfile_rm_watch):
4371 Do not assume glib functions set errno reliably on failure.
4372 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4373 and signal an error otherwise.
4374 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4375 Use Fdelq instead of Fdelete, for speed.
4376
817ebfcf
EZ
43772013-06-05 Eli Zaretskii <eliz@gnu.org>
4378
4379 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4380 don't insist on being invoked on a highlighted tool-bar button.
4381 Avoids losing tool-bar functionality when mouse-highlight is nil.
4382 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4383 Don't highlight when mouse-highlight is nil.
4384 (note_mouse_highlight): When mouse-highlight is nil, don't return
4385 right away; instead, run tool-bar and mode-line highlight
4386 subroutine, clear any existing highlight, and revert the mouse
4387 pointer to its default shape. (Bug#14558)
4388
55577e7c
SM
43892013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4390
4391 * lisp.mk (lisp): Add prog-mode.el.
4392
f019a684
PE
43932013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4394
4395 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4396 * process.c (dummy_handler): New function.
4397 (lib_child_handler): New static var.
4398 (handle_child_signal): Invoke it.
4399 (catch_child_signal): If a library has set up a signal handler,
4400 save it into lib_child_handler.
4401 (init_process_emacs): If using glib and not on Windows, tickle glib's
4402 child-handling code so that it initializes its private SIGCHLD handler.
4403 * syssignal.h (SA_SIGINFO): Default to 0.
4404 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4405 31; it should no longer be needed now.
4406
90db8702
MA
44072013-06-05 Michael Albinus <michael.albinus@gmx.de>
4408
4409 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4410
4411 * gfilenotify.c (globals_of_gfilenotify): New function.
4412 (syms_of_gfilenotify): Move global initialization there.
4413
4414 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4415
bfa3acd6
SM
44162013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4417
4418 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4419 * keyboard.c (menu_bar_items, tool_bar_items):
4420 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4421 not override local keymaps any more.
4422
ba59bd80
EZ
44232013-06-04 Eli Zaretskii <eliz@gnu.org>
4424
4425 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4426
7f203aa1
EZ
44272013-06-03 Eli Zaretskii <eliz@gnu.org>
4428
9337e206
EZ
4429 * w32console.c (initialize_w32_display): Return the dimensions of
4430 the console window via 2 additional arguments, not via the current
4431 frame. This avoids crashes due to overrunning the bounds of
4432 frame's decode_mode_spec_buffer, which is not resized following
4433 the change of the frame dimensions from the initial 10x10.
4434
4435 * w32term.h (w32_initialize_display_info): Adjust prototype.
4436
4437 * term.c (init_tty): Take dimensions of the frame from the values
4438 returned by initialize_w32_display.
4439
7f203aa1
EZ
4440 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4441 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4442 (LIBES): Add $(GFILENOTIFY_LIBS).
4443
4444 * w32inevt.c (handle_file_notifications): Add dummy implementation
4445 for !HAVE_W32NOTIFY.
4446
4447 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4448
55a87246
JD
44492013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4450
4451 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4452
4453 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4454
4455 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4456
3d5ee10a
PE
44572013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 Fix minor problems found by static checking.
4460 * data.c (pure_write_error):
4461 Use xsignal2, not Fsignal, as Fsignal might return.
4462 * eval.c (set_backtrace_debug_on_exit): Now static.
4463 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4464 No longer inline. EXTERN_INLINE is needed only for functions
4465 defined in .h files. Reindent function header as per GNU style.
4466 (backtrace_p, backtrace_top, backtrace_next):
4467 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4468 compiler or linker. Add extern decls to pacify gcc -Wall.
4469 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4470 Now static.
4471 * frame.c (free_monitors): Define only on platforms that need it.
4472 * nsterm.m (ns_term_init):
4473 * process.c (catch_child_signal):
4474 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4475 defined on all porting targets these days.
4476 * process.c, process.h (catch_child_signal):
4477 Make it extern only if NS_IMPL_GNUSTEP is defined.
4478
e2d8a6f0
EZ
44792013-06-03 Eli Zaretskii <eliz@gnu.org>
4480
4481 * w32.c (gettimeofday): Make the signature identical to prototype
4482 in nt/inc/sys/time.h.
4483
a8a7c5f6
SM
44842013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4485
4486 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4487 .gdbinit.
4488
4489 * keyboard.c (safe_run_hooks_error): Improve error message.
4490
4491 * data.c (pure_write_error): Add `object' argument.
4492 * puresize.h (CHECK_IMPURE): Use it.
4493
c9628c79
MA
44942013-06-03 Michael Albinus <michael.albinus@gmx.de>
4495
4496 * Makefile.in (NOTIFY_OBJ): New variable.
4497 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4498
4499 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4500 Call syms_of_gfilenotify.
4501
4502 * gfilenotify.c: New file.
4503
4504 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4505 and Qfile_w32notify.
4506 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4507 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4508
4509 * lisp.h: Declare syms_of_gfilenotify.
4510
4511 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4512
2f592f95
SM
45132013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4514
4515 Merge the specpdl and backtrace stacks. Make the structure of the
4516 specpdl entries more obvious via a tagged union of structs.
4517 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4518 (enum specbind_tag): New enum.
4519 (struct specbinding): Make it a tagged union of structs.
4520 Add a case for backtrace records.
4521 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4522 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4523 (backtrace_debug_on_exit): New accessors.
4524 (struct backtrace): Remove.
4525 (struct catchtag): Remove backlist field.
4526 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4527 Move to eval.c.
4528 (Flocal_variable_p): Speed up the common case where the binding is
4529 already loaded.
4530 * eval.c (backtrace_list): Remove.
4531 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4532 (set_backtrace_args, set_backtrace_nargs)
4533 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4534 (backtrace_next): New functions.
4535 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4536 (unwind_to_catch, internal_lisp_condition_case)
4537 (internal_condition_case, internal_condition_case_1)
4538 (internal_condition_case_2, internal_condition_case_n): Don't bother
4539 with backtrace_list any more.
4540 (Fsignal): Adjust to new backtrace format.
4541 (grow_specpdl): Move up.
4542 (record_in_backtrace): New function.
4543 (eval_sub, Ffuncall): Use it.
4544 (apply_lambda): Adjust to new backtrace format.
4545 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4546 data.c.
4547 (specbind): Adjust to new specpdl format. Simplify.
4548 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4549 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4550 backtrace format.
4551 (mark_backtrace): Remove.
4552 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4553 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4554 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4555 Use mark_specpdl.
4556 * profiler.c (record_backtrace): Use get_backtrace.
4557 (handle_profiler_signal): Use backtrace_top_function.
4558 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4559 accessor functions.
4560
c0342369
JD
45612013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4562
4563 * process.h (catch_child_signal): Declare.
4564
4565 * process.c (catch_child_signal): New function.
4566 (init_process_emacs): Call it.
4567
4568 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4569 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4570 NS_IMPL_COCOA.
4571 (x_set_cursor_type): Remove declaration.
4572 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4573 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4574 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4575 (ns_get_color): Use F suffix on float.
4576 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4577 (ns_get_rgb_color): Remove.
4578 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4579 (note_mouse_movement): x and y are CGFloat.
4580 (ns_draw_fringe_bitmap): Remove unused rowY.
4581 Change #if to COCOA && >= 10_6.
4582 (ns_draw_window_cursor): Remove unused overspill.
4583 (ns_draw_underwave): width and x are EamcsCGFloat.
4584 (ns_draw_box): thickness is CGFloat.
4585 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4586 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4587 if not in main thread.
4588 (ns_get_pending_menu_title, ns_check_menu_open)
4589 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4590 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4591 (sendFromMainThread:): New method.
4592 (changeFont:): size is CGFloat.
4593 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4594 Disable warning about permanent text.
4595 (characterIndexForPoint:): Adjust return type depending on GNUStep
4596 version.
4597 (mouseDown:): delta is CGFloat.
4598 (updateFrameSize): Remove unised variable f.
4599 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4600 Cast float to EmacsCGFloat.
4601 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4602 also to -1 when restoring.
4603 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4604 inside NS_IMPL_COCOA.
4605 (toggleFullScreen:): Put call to toggleFullScreen inside
4606 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4607 (setPosition:portion:whole:): por is CGFloat.
4608 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4609 (mouseDown:): Use CGFloat.
4610 (mouseDragged:): Remove unised variable edge.
4611 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4612
4613 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4614 of CGFloat differs.
4615 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4616 when NS_IMPL_GNUSTEP.
4617 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4618 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4619 (EmacsToolbar): Add clearAll. Add tag argument to
4620 addDisplayItemWithImage.
4621 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4622
4623 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4624
4625 * nsmenu.m (ns_update_menubar): Make static.
4626 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4627 (fillWithWidgetValue:): Add cast to SEL for setAction.
4628 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4629 (update_frame_tool_bar): Update code for GNUStep.
4630 (clearAll): New method.
4631 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4632 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4633 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4634 call to insertItemWithItemIdentifier.
4635 (validateVisibleItems): Fix indentation.
4636 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4637 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4638 UtilityWindow to aStyle, remove call to setStyleMask.
4639
4640 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4641
4642 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4643 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4644 Use F suffix on floats.
4645 (ns_char_width): Returns CGFloat.
4646 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4647 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4648 DPSxshow.
4649 (ns_glyph_metrics): CGFloat instead of float.
4650
a0eb10b3
JB
4651 * nsfns.m (x_set_foreground_color, x_set_background_color):
4652 Use EmacsCGFloat.
4653 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4654 remove unused variables.
4655 (Fns_read_file_name): Keep track if panel is for save.
4656 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4657 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4658 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4659 Just return the input if GNUStep.
c0342369
JD
4660 (x_screen_planes): Remove.
4661 (Fxw_color_values): Use EmacsCGFloat
4662 (Fns_display_monitor_attributes_list): Only get screen number for
4663 Cocoa.
ef099a94 4664 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4665 EmacsSavePanel.
4666 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4667 ns_directory_from_panel.
4668
da9aff11
PE
46692013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4670
4671 * process.c (handle_child_signal): Also use WCONTINUED.
4672 This is so that list-processes doesn't mistakenly list the process
4673 as stopped, when the process has actually been continued and is
4674 now running.
4675
0e64479a
PE
46762013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4677
fc186a96
PE
4678 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4679 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4680 not already configured.
4681
0e64479a
PE
4682 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4683
38b787fa
EZ
46842013-05-29 Eli Zaretskii <eliz@gnu.org>
4685
4686 * Makefile.in (mostlyclean): Remove *.res files.
4687
22513e52
SM
46882013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4689
4690 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4691 a buffer (bug#8447).
4692
6ef3db10
EZ
46932013-05-27 Eli Zaretskii <eliz@gnu.org>
4694
4695 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4696 display vector, and we backtrack, handle the case that the
4697 previous character position is also displayed from a display
4698 vector or covered by a display string or image. (Bug#14476)
4699
6799bb26
JD
47002013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4701
4702 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4703 (struct MonitorInfo, free_monitors): Remove.
4704 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4705 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4706 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4707 Qframes, Qsource.
4708
4709 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4710 (struct MonitorInfo, free_monitors): Remove.
4711 (ns_screen_name): Make static.
4712 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4713 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4714 Qframes, Qsource.
4715
4716 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4717 (struct MonitorInfo): New struct.
4718 (free_monitors, make_monitor_attribute_list): Declare.
4719
22513e52
SM
4720 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4721 New Lisp_Object:s.
6799bb26
JD
4722 (free_monitors, make_monitor_attribute_list): New functions.
4723 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4724 Qsource.
4725
38cd43eb
XF
47262013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4727
4728 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4729
2af0948d
SM
47302013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4731
a7eb9b0f
SM
4732 * keyboard.c: Apply keyboard decoding only to events that come directly
4733 from the tty, not from unread-command-events (bug#14368).
4734 (read_event_from_main_queue): New function, extracted from read_char).
4735 (read_decoded_char): Remove.
4736 (read_decoded_event_from_main_queue): New function to replace it.
4737 (read_char): Use it.
4738 (read_key_sequence): Use read_char rather than read_decoded_char.
4739
2af0948d
SM
4740 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4741
1413e9a5
BR
47422013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4743
4744 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4745
e6d2f155
KH
47462013-05-22 Kenichi Handa <handa@gnu.org>
4747
4748 The following changes are to fix the setting of
4749 buffer-file-coding-system on, for instance, C-x RET c unix RET
4750 _FILE_OF_DOS_EOL_TYPE_ RET.
4751
4752 * coding.h (struct coding_system): New member detected_utf8_chars.
4753
4754 * coding.c (detect_coding_utf_8): Count characters and check EOL
4755 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4756 BOM is there.
4757 (setup_coding_system): Do not initialize coding->head_ascii.
4758 (check_ascii): Do not set coding->eol_seen but update it. Do not
4759 call adjust_coding_eol_type here.
1413e9a5
BR
4760 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4761 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4762 of the found coding-system.
4763 (decode_coding_gap): Cancel previous change. Utilize the
4764 character numbers counted by detect_coding_utf_8. Fix detection
4765 of BOM for utf-8.
4766
ab56a6f4 47672013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4768
4769 * search.c (looking_at_1): Only set last_thing_searched if the match
4770 changed the match-data (bug#14281).
4771
ecc3c6ed
DA
47722013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4773
4774 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4775 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4776 (move_it_vertically_backward): Likewise.
4777
5ba8bf35
YM
47782013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4779
4780 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4781 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4782 (Fx_display_mm_width, Fx_display_mm_height):
4783 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4784
91e8418b 4785 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4786 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4787 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4788 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4789 (Fx_display_backing_store, Fx_display_visual_class)
4790 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4791 (Fx_display_grayscale_p, Fx_display_pixel_width)
4792 (Fx_display_pixel_height, Fx_display_planes)
4793 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4794 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4795 (Fx_display_mm_width, Fx_display_mm_height)
4796 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4797 height for all physical monitors as in X11.
4798
fc30d803
SM
4799 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4800 Return pixel width or height for all physical monitors as in X11.
91e8418b 4801
31ff141c
PE
48022013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4803
4804 Port --enable-gcc-warnings to clang.
4805 * bytecode.c (exec_byte_code):
4806 * regex.c:
4807 Redo diagnostic pragmas to pacify clang, too.
4808 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4809 * editfns.c (Fencode_time):
4810 * fileio.c (file_accessible_directory_p):
4811 * font.c (font_unparse_xlfd):
4812 Use '&"string"[index]' instead of '"string" + (index)'.
4813 * undo.c (user_error): Remove; unused.
4814
df065a0b
EZ
48152013-05-16 Eli Zaretskii <eliz@gnu.org>
4816
04d360e7
EZ
4817 * insdel.c (insert_1_both): Document the arguments, instead of
4818 referring to insert_1, which no longer exists.
4819
5bb98290
EZ
4820 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4821 some window, increment windows_or_buffers_changed, so that
4822 *Messages* display in that window is updated. (Bug#14408)
4823
df065a0b
EZ
4824 * w32.c: Include epaths.h.
4825 (init_environment): Use cmdproxy.exe without leading directories.
4826 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4827 case.
4828 (gettimeofday): Adjust signature and return value to Posix
4829 expectations.
4830
4831 * unexw32.c (open_output_file): Delete the existing emacs.exe
4832 before creating it, to break the hard link to the versioned
4833 executable.
4834
4835 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4836 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4837 (FIRSTFILE_OBJ): New variables.
4838 (W32_RES): Rename to EMACSRES. All users changed.
4839 (base_obj): Use $(CM_OBJ).
4840 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4841 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4842 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4843 $(W32_RES_LINK) before $(LIBES).
4844 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4845
1aa8d505
SM
48462013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4847
6e911150
SM
4848 * makefile.w32-in (DOC): Use just "DOC".
4849
4850 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4851
1aa8d505
SM
4852 * process.c: Export default filters and sentinels to Elisp.
4853 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4854 New constants.
4855 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4856 (Fset_process_sentinel, Fformat_network_address):
4857 Default to them instead of nil.
4858 (server_accept_connection): Sentinels can't be nil any more.
4859 (read_and_dispose_of_process_output): New function, extracted from
4860 read_process_output.
4861 (read_process_output): Use it; filters can't be nil.
4862 (Finternal_default_process_filter): New function, extracted from
4863 read_process_output.
4864 (exec_sentinel_unwind): Remove function.
4865 (exec_sentinel): Don't zilch sentinel while running.
4866 (status_notify): Sentinels can't be nil.
4867 (Finternal_default_process_sentinel): New function extracted from
4868 status_notify.
4869 (setup_process_coding_systems): Default filter is not nil any more.
4870 (syms_of_process): Export new Elisp functions and initialize
4871 new constants.
4872 * lisp.h (make_lisp_proc): New function.
4873
5ac2eb34
SM
48742013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4875
4876 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4877
eda9c7d7
EZ
48782013-05-14 Eli Zaretskii <eliz@gnu.org>
4879
4880 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4881 unless we know that the window w is a leaf window.
4882 Another attempt at solving bug#14062.
eda9c7d7 4883
8fdeaad5
JD
48842013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4885
4886 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4887 fdesc (Bug#14375).
4888
44aa9ee6
PE
48892013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4890
4891 * image.c (gif_load): Check that subimages fit (Bug#14345).
4892
759fd763
SM
48932013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4894
4895 * lread.c (skip_dyn_eof): New function.
4896 (read1): Use it to skip the end of a file in response to #@00.
4897
4898 * doc.c (get_doc_string): Slightly relax the sanity checking.
4899
4465bfb4
JD
49002013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4901
4902 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4903 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4904 (MonitorInfo): New struct.
4905 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4906 (Fns_display_monitor_attributes_list): New functions.
4907 (display-usable-bounds): Remove.
4908 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4909 Qsource.
4910
7583e2a0
PE
49112013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4912
4913 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4914 (GTK_CHECK_VERSION): New macro, if not already defined.
4915 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4916 replaced by GTK_CHECK_VERSION.
4917
ad75d77e
PE
49182013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4919
4920 * xterm.h (GTK_PREREQ): New macro.
4921 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4922 to use this macro instead, for consistency and clarity.
4923
07525f77
EZ
49242013-05-08 Eli Zaretskii <eliz@gnu.org>
4925
4926 * xdisp.c (row_for_charpos_p): New function, with code of
4927 cursor_row_p, but accepts an additional argument CHARPOS instead
4928 of using a hardcoded PT.
4929 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4930 (row_containing_pos): Call row_for_charpos_p instead of partially
4931 doing the same. Fixes cursor positioning under longlines-mode
4932 when longlines-show-effect includes more than one newline, when
4933 moving the cursor vertically up.
4934
d901fc8d
JB
49352013-05-08 Juanma Barranquero <lekktu@gmail.com>
4936
4937 * makefile.w32-in (ACL_H): New macro.
4938 ($(BLD)/fileio.$(O)): Update dependencies.
4939
f269bc61
PE
49402013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4941
e7b41c4c 4942 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4943 * Makefile.in (LIB_ACL): New macro.
4944 (LIBACL_LIBS): Remove.
4945 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4946 * fileio.c: Include <acl.h>.
4947 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4948 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4949 !acl_errno_valid.
4950 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4951 it ourselves.
4952
f269bc61
PE
4953 * unexelf.c: Don't assume ElfW (Half) fits in int.
4954 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4955 when dealing with ElfW (Half) values, since they can exceed 2**31
4956 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4957 (entry_address): Omit unused NUM arg. All uses changed.
4958
a261c53e
JL
49592013-05-07 Juri Linkov <juri@jurta.org>
4960
4961 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4962 to the string converted from number with `Fnumber_to_string'.
4963 (Bug#14254)
4964
2b66427d
PE
49652013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4966
4967 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4968 This fixes a problem introduced by my previous change.
4969
15acfe41
GM
49702013-05-07 Glenn Morris <rgm@gnu.org>
4971
4972 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4973
5ea03bf5
JD
49742013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4975
4976 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4977
e0c9d565
PE
49782013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4979
4980 Static checking by GCC 4.8.0.
4981 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4982 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4983 (x_get_monitor_attributes_fallback)
4984 (x_get_monitor_attributes_xinerama)
4985 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4986 Define only if USE_GTK.
4987 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4988 (x_get_monitor_attributes_fallback): Omit unused locals.
4989 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4990 Use double, not float, to avoid mixed-mode floating point arithmetic.
4991
4e3f9230
YM
49922013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4993 Jan Djärv <jan.h.d@swipnet.se>
4994
4995 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4996 (XINERAMA_CFLAGS): New macros.
4997 (ALL_CFLAGS, LIBES): Use them.
4998
4999 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
5000 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
5001 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
5002 (syms_of_xfns): DEFSYM them.
5003 (struct MonitorInfo): New struct.
5004 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
5005 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
5006 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
5007 (x_get_monitor_attributes_xinerama): New functions.
5008 (Fx_display_monitor_attributes_list): New primitive.
5009 (syms_of_xfns): Defsubr it.
5010
5011 * xterm.h (x_display_info): Add Xatom_net_workarea and
5012 Xatom_net_current_desktop.
5013
5014 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5015 and dpyinfo->Xatom_net_current_desktop.
5016
05839b6a
EZ
50172013-05-06 Eli Zaretskii <eliz@gnu.org>
5018
5019 * xdisp.c (pos_visible_p): Use the special code for finding the
5020 beginning of a display property or overlay for any "replacing"
5021 display property, not just for display strings. This solves
5022 incorrect reporting of position by posn-at-point. (Bug#14241)
5023
dc4a2ee0
PE
50242013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5025
5ee94506
PE
5026 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5027 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5028 Verify that ElfW (Half) fits in int.
5029 (fatal): Use same signature as lisp.h.
5030 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5031 configure and build with -DUNEXELF_DEBUG without worrying about
5032 other modules that use DEBUG.
5033 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5034 possibly-wide integers now uses it instead of plain fprintf.
5035 (entry_address): New function, which avoids problems with 32-bit
5036 overflow on 64-bit hosts.
5037 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5038 (round_up): Don't assume the remainder fits in int.
5039 (find_section): Use bool for boolean. Simplify debug code.
5040 (unexec): Don't assume file sizes fit in int or size_t.
5041 Omit unnecessary trailing newline in 'fatal' format.
5042 Use strerror rather than outputting decimal error number.
5043 Remove unused code when emacs is not defined;
5044 this file relies on Emacs now.
5045 Don't assume e_phnum and e_shnum are positive.
5046
dc4a2ee0
PE
5047 * regex.c: Fix problems when DEBUG is defined.
5048 (extract_number, extract_number_and_incr): Define regardless of
5049 whether DEBUG is defined; that's simpler and makes the code less
5050 likely to go stale in the normal case when DEBUG is not defined.
5051 Return int rather than taking an int * arg. All callers changed.
5052 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5053 Remove, replacing with ...
5054 (DEBUG_PRINT): New macro. All callers changed.
5055 (DEBUG_COMPILES_ARGUMENTS): New macro.
5056 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5057 (print_compiled_pattern, print_double_string) [DEBUG]:
5058 Use prototype rather than old-style definition.
5059 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5060 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5061 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5062 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5063 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5064 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5065 This matters only when DEBUG is defined.
5066
14c7ed05
EZ
50672013-05-05 Eli Zaretskii <eliz@gnu.org>
5068
5069 * xdisp.c (set_iterator_to_next): Set the
5070 ignore_overlay_strings_at_pos_p flag only if we are _really_
5071 iterating over an overlay string, as indicated by the
5072 current.overlay_string_index member. (Bug#14306)
5073
e6076b1b
JD
50742013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5075
5076 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5077 to where it is used, to avoid autorelease issues (Bug#14050).
5078
cbee2131
PE
50792013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5080
5081 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5082 * fileio.c (syms_of_fileio): Implement this.
5083 * filelock.c (create_lock_file): If symbolic links don't work, so
5084 we use a regular file as a lock file, do not fsync the lock file;
5085 it's not needed.
5086
30c7e542
SM
50872013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5088
5089 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5090 (syms_of_minibuf): Adjust accodingly.
5091 * lread.c (Fread):
5092 * callint.c (Fcall_interactively): Adjust calls accordingly.
5093
5bebd186
EZ
50942013-05-04 Eli Zaretskii <eliz@gnu.org>
5095
5096 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5097 w->contents is a buffer before computing everything else.
5098 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5099
5100 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5101 assertion violations. (Bug#14062)
5102
0fb0a4f3
DR
51032013-05-01 David Reitter <david.reitter@gmail.com>
5104
5105 * nsfns.m (ns_tooltip): Initialize.
5106
9e63b4a5
EZ
51072013-04-28 Eli Zaretskii <eliz@gnu.org>
5108
5109 * coding.c (decode_coding_gap): Don't remove the character before
5110 a newline unless it's a CR character. (Bug#14287)
5111
ad60824e
DN
51122013-04-28 Dan Nicolaescu <dann@gnu.org>
5113
5114 * dispextern.h (struct face): Move enum face_underline_type
5115 earlier so that bitfields can be in the same word.
5116
edbdcec0
JD
51172013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5118
5119 * nsfns.m (handlePanelKeys): New function.
5120 (EmacsOpenPanel:performKeyEquivalent:)
5121 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5122 arrows/function/control and copy/paste keys (Bug#14296).
5123
0208ede7
JL
51242013-04-27 Juri Linkov <juri@jurta.org>
5125
5126 * callint.c (Fcall_interactively): Call `Qread_number' for
5127 interactive code letter `n' instead of using duplicate code.
5128 (Bug#14254)
5129
b8dd59f7
PE
51302013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5131
5132 * systime.h (make_timeval): Declare as 'const'.
5133
8bd722db
KH
51342013-04-27 Kenichi Handa <handa@gnu.org>
5135
5136 * font.c (font_open_entity): Always open a font of manageable
5137 size.
5138
13d0e56f 51392013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5140
f780d632
PE
5141 Port better to AIX (Bug#14258).
5142 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5143 to pacify AIX xlc.
5144
ec509856
KH
51452013-04-24 Kenichi Handa <handa@gnu.org>
5146
5147 * coding.c (decode_coding_iso_2022): When an invalid escape
5148 sequence is encountered, reset the invocation and designation
5149 status to the safest one.
5150
84fc48e5
PE
51512013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5152
5153 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5154 Without this fix, "make distclean" leaves stamp-h1 behind.
5155
806bda47
EC
51562013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5157
5158 * w32fns.c (w32_fullscreen_rect): New function to compute the
5159 window rectangle for the given fullscreen mode.
5160 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5161 longer tunes the window size. This keeps the window's edges flush
5162 with the screen and allows the taskbar to hide itself in fullboth.
5163
5164 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5165 window decorations and uses the entire screen.
5166
5167 * w32term.h (w32_fullscreen_rect) Add prototype.
5168 (struct w32_output): Replace normal_width, normal_height,
5169 normal_top, and normal_left members with a single normal_placement
5170 struct.
5171 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5172 Remove macros.
5173 (FRAME_NORMAL_PLACEMENT): New macro.
5174
9cc2810b
JB
51752013-04-16 Juanma Barranquero <lekktu@gmail.com>
5176
5177 * minibuf.c (Ftest_completion): Silence compiler warning.
5178
fd16b54c
EZ
51792013-04-15 Eli Zaretskii <eliz@gnu.org>
5180
5181 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5182 bug#14062.
fd16b54c
EZ
5183
5184 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5185 parentheses.
5186
5187 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5188 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5189 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5190 parentheses where appropriate.
5191
9e3379a0
PE
51922013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5193
5194 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5195
ddd6b685
EZ
51962013-04-14 Eli Zaretskii <eliz@gnu.org>
5197
5198 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5199 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5200 Mention in the doc string that setting these variables takes
5201 effect only after a call to set-window-buffer. (Bug#14200)
5202
29b79ba1
EZ
52032013-04-13 Eli Zaretskii <eliz@gnu.org>
5204
5205 * indent.c (Fvertical_motion): Don't consider display strings on
5206 overlay strings as display strings on the buffer position we
5207 started from. This prevents vertical cursor motion from jumping
5208 more than one line when there's an overlay string with a display
5209 property at end of line.
5210 Reported by Karl Chen <Karl.Chen@quarl.org> in
5211 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5212
562c6ee9
SM
52132013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5214
5215 * window.c (select_window): `record_buffer' even if window is
5216 already selected (bug#14191).
5217
fcc1fe85
EZ
52182013-04-11 Eli Zaretskii <eliz@gnu.org>
5219
5220 * window.c (Fwindow_end): Test more flags, including the buffer's
5221 last_overlay_modified flag, to determine whether the window's
5222 display is really up-to-date. Prevents the function from
5223 returning a stale value. (Bug#14170)
5224 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5225 current matrix.
5226
f009190a
EZ
52272013-04-10 Eli Zaretskii <eliz@gnu.org>
5228
5229 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5230 garbaged only if it is not already the top frame on its TTY.
5231 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5232 there are GUI frames open in the same session. (Bug#13864)
5233
78ce603d
SM
52342013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5235
5236 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5237 of marking the idle timers directly.
5238
a8036e40
SM
52392013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5240
5241 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5242 tables (bug#14054).
5243
7ffe7ef6
SM
52442013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5245
5246 * window.c (select_window): Don't record_buffer while the invariant is
5247 temporarily broken (bug#14161).
5248
5249 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5250
7d9f6883
EZ
52512013-04-07 Eli Zaretskii <eliz@gnu.org>
5252
5253 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5254
5406cfd9
RF
52552013-04-07 Romain Francoise <romain@orebokech.com>
5256
5257 Ignore additional platform-specific ACL errors (Bug#13702).
5258 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5259 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5260
95c0e83b
JD
52612013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5262
5263 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5264 f->output_data.ns.
5265
876da980
PE
52662013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5267
5268 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5269 This bug was introduced by my 2013-02-25 change that simplified
5270 data_start configuration. Without this change, on GNU/Linux
5271 an Emacs configured with --enable-profiling fails immediately
5272 due to a profiler signal.
5273 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5274 with these flags. On platforms where special flags are needed
5275 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5276 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5277 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5278
7452b7bd
DA
52792013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5280
5281 Get rid of some platform-specific functions examining window
5282 system and its capabilities. This is a partial rework of the
5283 2013-04-05 change.
5284 * lisp.h (have_menus_p): Remove prototype. This function is
5285 replaced with platform-independent window_system_available.
5286 (check_window_system): Move to...
5287 * frame.h (decode_window_system_frame, window_system_available):
5288 ...here, add new prototypes.
5289 * frame.c (window_system_available, decode_window_system_frame):
5290 New functions.
5291 (check_window_system): Platform-independent now.
5292 * xterm.h (x_in_use): Remove declaration.
5293 (check_x_frame):
5294 * w32term.h (check_x_frame):
5295 * nsterm.h (check_x_frame): Remove prototypes. This function
5296 is replaced with platform-independent decode_window_system_frame.
5297 * msdos.c (have_menus_p): Remove.
5298 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5299 Remove platform-specific functions. Use check_window_system,
5300 decode_window_system_frame and check_ns_display_info where
5301 appropriate. Minor style and comment tweaks.
5302 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5303 (check_x_frame): Likewise.
5304 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5305 Likewise.
5306 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5307 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5308 * xmenu.c, xselect.c: All related users changed.
5309
251e9147
KH
53102013-04-03 Kenichi Handa <handa@gnu.org>
5311
5312 The following changes is to optimize the code for reading UTF-8
5313 files.
5314
562c6ee9 5315 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5316 changed. Check EOL format. Do not call adjust_coding_eol_type
5317 here.
5318 (check_utf_8): New function.
5319 (adjust_coding_eol_type): Do nothing if already adjusted.
5320 (detect_coding): Compare the return value of check_ascii with
5321 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5322 (decode_coding_gap): Optimize for valid UTF-8.
5323
8bc369d4
KH
53242013-03-21 Kenichi Handa <handa@gnu.org>
5325
5326 * coding.c (syms_of_coding): Cancel previous change.
5327
5328 * insdel.c (insert_from_gap): Fix previous change.
5329
73931ad1
DA
53302013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5331
5332 Consistently use platform-specific function to detect window system.
5333 * lisp.h (check_window_system): New prototype. This function is
5334 going to replace check_x, check_w32 and check_ns.
5335 (have_menus_p): Mention msdos.c in comment.
5336 * fontset.c (check_window_system_func): Remove. Adjust all users.
5337 * fontset.h (check_window_system_func): Remove prototype.
5338 * nsterm.h (check_ns):
5339 * xterm.h (check_x):
5340 * w32term.h (check_w32): Likewise.
5341 * menu.c (Fx_popup_menu): Use check_window_system.
5342 * msdos.c (check_window_system): Define for MS-DOS.
5343 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5344 * w32fns.c (check_window_system): Likewise for MS-Windows.
5345 * xfns.c (check_window_system): Likewise for X.
5346 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5347 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5348
7216e43b
PE
53492013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5350
5351 Prefer < to > in range checks such as 0 <= i && i < N.
5352 This makes it easier to visualize quantities on a number line.
5353 This patch doesn't apply to all such range checks,
5354 only to the range checks affected by the 2013-03-24 change.
5355 This patch reverts most of the 2013-03-24 change.
5356 * alloc.c (xpalloc, Fgarbage_collect):
5357 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5358 * character.c (string_escape_byte8):
5359 * charset.c (read_hex):
5360 * data.c (cons_to_unsigned):
5361 * dispnew.c (update_frame_1):
5362 * doc.c (Fsubstitute_command_keys):
5363 * doprnt.c (doprnt):
5364 * editfns.c (hi_time, decode_time_components):
5365 * fileio.c (file_offset):
5366 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5367 * font.c (font_intern_prop):
5368 * frame.c (x_set_alpha):
5369 * gtkutil.c (get_utf8_string):
5370 * indent.c (check_display_width):
5371 * keymap.c (Fkey_description):
5372 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5373 * lread.c (read1):
5374 * minibuf.c (read_minibuf_noninteractive):
5375 * process.c (wait_reading_process_output):
5376 * search.c (Freplace_match):
5377 * window.c (get_phys_cursor_glyph):
5378 * xdisp.c (redisplay_internal):
5379 * xsmfns.c (smc_save_yourself_CB):
5380 Prefer < to > for range checks.
5381 * dispnew.c (sit_for): Don't mishandle NaNs.
5382 This fixes a bug introduced in the 2013-03-24 change.
5383 * editfns.c (decode_time_components): Don't hoist comparison.
5384 This fixes another bug introduced in the 2013-03-24 change.
5385
92759988
DA
53862013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5387
5388 * frame.h (struct frame): Drop scroll_bottom_vpos
5389 member becaue all real users are dead long ago.
5390 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5391 * xdisp.c (redisplay_internal): Adjust user.
5392
9a1971bb
GM
53932013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5394
f38ab167
JD
5395 * nsmenu.m (showAtX:Y:for:): setLevel to
5396 NSPopUpMenuWindowLevel (Bug#13998).
5397
6d01f1fe
JD
53982013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5399
5400 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5401 (ns_check_pending_open_menu): Declare.
5402
5403 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5404 (x_activate_menubar): Update the menu with title that matches
5405 ns_get_pending_menu_title, and call
5406 ns_check_pending_openmenu (Bug#12698).
5407 (menuWillOpen:): New method.
5408 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5409
5410 * nsterm.m (menu_will_open_state, menu_mouse_point)
5411 (menu_pending_title): New varaibles.
5412 (ns_get_pending_menu_title, ns_check_menu_open)
5413 (ns_check_pending_open_menu): New functions.
5414
781f4782
DA
54152013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5416
5417 * indent.c (current_column_bol_cache): Remove leftover which is not
5418 used in Fmove_to_column any more.
5419 (current_column, scan_for_column): Adjust users.
5420 * keyboard.c (last_point_position_buffer, last_point_position_window):
5421 Remove leftovers which are not used for recording undo any more.
5422 (command_loop_1, syms_of_keyboard): Adjust users.
5423 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5424 redisplay_window any more.
5425 (move_it_to): Adjust user.
5426
1921c31b
JB
54272013-03-29 Juanma Barranquero <lekktu@gmail.com>
5428
5429 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5430 Update dependencies.
5431
717b8bcd
SM
54322013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5433
5434 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5435 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5436 forward references.
5437
e74aeda8
DA
54382013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5439
5440 * window.h (struct window): Replace hchild, vchild and buffer slots
5441 with the only contents slot. This is possible because each valid
5442 window may have either the child window (in vertical or horizontal
5443 combination) or buffer to display (for the leaf window). Using that,
5444 a lof of operations to traverse and/or change window hierarchies may
5445 be simplified. New member horizontal is used to distinguish between
5446 horizontal and vertical combinations of internal windows.
5447 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5448 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5449 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5450 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5451 Use contents slot, not buffer, where appropriate.
5452 (wset_combination): New function.
5453 (wset_buffer): Add eassert.
5454 (Fframe_first_window): Simplify the loop reaching first window.
5455 (Fwindow_buffer): Use WINDOW_LEAF_P.
5456 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5457 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5458 (unshow_buffer): Convert initial debugging check to eassert.
5459 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5460 (make_parent_window, window_resize_check, window_resize_apply)
5461 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5462 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5463 Adjust to match struct window changes.
5464 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5465 (mark_window_cursors_off, count_windows, get_leaf_windows)
5466 (foreach_window_1): Simplify the loop.
5467 * alloc.c (mark_object): Do not check for the leaf window because
5468 internal windows has no glyph matrices anyway.
5469 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5470 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5471 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5472 (build_frame_matrix_from_window_tree, mirror_make_current)
5473 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5474 (update_window_tree, set_window_update_flags): Simplify the loop.
5475 (sync_window_with_frame_matrix_rows): Enforce live window.
5476 Use contents slot, not buffer, where appropriate.
5477 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5478 and WINDOW_HORIZONTAL_COMBINATION_P.
5479 (make_frame_visible_1): Simplify the loop.
5480 Use contents slot, not buffer, where appropriate.
5481 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5482 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5483 (expose_window_tree): Likewise.
5484 Use contents slot, not buffer, where appropriate.
5485 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5486 to avoid deleted windows. Use contents slot instead of buffer.
5487 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5488 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5489 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5490 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5491
121ab1cd
EZ
54922013-03-28 Eli Zaretskii <eliz@gnu.org>
5493
ef454cf7
EZ
5494 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5495 identify the reasons for assertion violations in bug#14062 and
5496 similar ones.
21e930f8
EZ
5497 (Fx_show_tip): Fix compilation error under
5498 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5499
121ab1cd
EZ
5500 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5501 Reported by <rzl24ozi@gmail.com>.
5502
5c89ca24
DA
55032013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5504
5505 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5506 start marker...
562c6ee9
SM
5507 (unwind_with_echo_area_buffer): ...to restore it here.
5508 This is needed to ensure that...
5c89ca24
DA
5509 (redisplay_window): ...both window markers are valid here,
5510 which is verified by eassert.
5511 * editfns.c (save_excursion_save): Do not assume that
5512 selected_window always displays the buffer.
c7f53895
DA
5513 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5514 Fix comment.
5c89ca24 5515
f557c1b1
SM
55162013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5517
5518 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5519 the upcase table.
5520
40693bba 55212013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5522
5523 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5524
c86f791f
EZ
55252013-03-27 Eli Zaretskii <eliz@gnu.org>
5526
5527 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5528 since MinGW's w32api headers do. This avoids compiler warnings.
5529
5530 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5531 if already defined.
5532
c6e72e17
EZ
55332013-03-26 Eli Zaretskii <eliz@gnu.org>
5534
5535 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5536
54e95010
JD
55372013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5538
5539 * gtkutil.c (style_changed_cb): Check if frame is live and an
5540 X frame (Bug#14038).
5541
b88b62de
EZ
55422013-03-26 Eli Zaretskii <eliz@gnu.org>
5543
a18d7de6
EZ
5544 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5545 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5546 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5547 MinGW64.
8f5e14c8
EZ
5548 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5549 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5550
b88b62de
EZ
5551 Fix incompatibilities between MinGW.org and MinGW64 headers.
5552 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5553
5554 * w32.c (REPARSE_DATA_BUFFER): Guard with
5555 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5556
c074e458
JD
55572013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5558
5559 * xterm.c: Include X11/XKBlib.h
5560 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5561
908589fd
AS
55622013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5563
5564 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5565 written backwards.
5566 * blockinput.h (input_blocked_p): Likewise.
5567 * bytecode.c (exec_byte_code): Likewise.
5568 * callproc.c (call_process_kill, call_process_cleanup)
5569 (Fcall_process): Likewise.
5570 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5571 (Fccl_execute_on_string): Likewise.
5572 * character.c (string_escape_byte8): Likewise.
5573 * charset.c (read_hex): Likewise.
5574 * cm.c (calccost): Likewise.
5575 * data.c (cons_to_unsigned): Likewise.
5576 * dired.c (directory_files_internal, file_name_completion):
5577 Likewise.
5578 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5579 (sit_for): Likewise.
5580 * doc.c (Fsubstitute_command_keys): Likewise.
5581 * doprnt.c (doprnt): Likewise.
5582 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5583 * emacsgtkfixed.c: Likewise.
5584 * fileio.c (file_offset, Fwrite_region): Likewise.
5585 * floatfns.c (Fexpt, fmod_float): Likewise.
5586 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5587 Likewise.
5588 * font.c (font_intern_prop): Likewise.
5589 * frame.c (x_set_alpha): Likewise.
5590 * gtkutil.c (get_utf8_string): Likewise.
5591 * indent.c (check_display_width): Likewise.
5592 * intervals.c (create_root_interval, rotate_right, rotate_left)
5593 (split_interval_right, split_interval_left)
5594 (adjust_intervals_for_insertion, delete_node)
5595 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5596 (merge_interval_right, merge_interval_left, copy_intervals)
5597 (set_intervals_multibyte_1): Likewise.
5598 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5599 * keymap.c (Fkey_description): Likewise.
5600 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5601 * lread.c (openp, read_integer, read1, string_to_number):
5602 Likewise.
5603 * menu.c (ensure_menu_items): Likewise.
5604 * minibuf.c (read_minibuf_noninteractive): Likewise.
5605 * print.c (printchar, strout): Likewise.
5606 * process.c (create_process, Faccept_process_output)
5607 (wait_reading_process_output, read_process_output, send_process)
5608 (wait_reading_process_output): Likewise.
5609 * profiler.c (make_log, handle_profiler_signal): Likewise.
5610 * regex.c (re_exec): Likewise.
5611 * regex.h: Likewise.
5612 * search.c (looking_at_1, Freplace_match): Likewise.
5613 * sysdep.c (get_child_status, procfs_ttyname)
5614 (procfs_get_total_memory): Likewise.
5615 * systime.h (EMACS_TIME_VALID_P): Likewise.
5616 * term.c (dissociate_if_controlling_tty): Likewise.
5617 * window.c (get_phys_cursor_glyph): Likewise.
5618 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5619 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5620 Likewise.
5621 * xfns.c (Fx_window_property): Likewise.
5622 * xmenu.c (set_frame_menubar): Likewise.
5623 * xselect.c (x_get_window_property, x_handle_dnd_message):
5624 Likewise.
5625 * xsmfns.c (smc_save_yourself_CB): Likewise.
5626 * xterm.c (x_scroll_bar_set_handle): Likewise.
5627
2bf7d27a
DA
56282013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5629
5630 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5631 to be optional or nil. Adjust comment and convert it to docstring.
5632 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5633 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5634
a9ebfa0b
PE
56352013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5636
5637 Static checking by GCC 4.8-20130319.
5638 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5639 * process.c (Fset_process_datagram_address)
5640 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5641 * xdisp.c (get_char_face_and_encoding):
5642 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5643 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5644 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5645
4f3576ee
KB
56462013-03-24 Ken Brown <kbrown@cornell.edu>
5647
789b5e9a
KB
5648 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5649 fix compilation on 64-bit Cygwin, where underscores are not
5650 automatically prepended.
5651
4f3576ee
KB
5652 * w32term.c (w32_initialize): Silence compiler warning.
5653
b5b7745f
EZ
56542013-03-23 Eli Zaretskii <eliz@gnu.org>
5655
cdc0d0bd
EZ
5656 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5657 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5658 variables, to save and restore frame dimensions.
5659 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5660 after returning from a 'fullscreen' configuration.
5661 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5662 to avoid races between the main thread and the input thread.
5663
5664 * w32term.h (struct w32_output): New members normal_width,
5665 normal_height, normal_top, normal_left, and prev_fsmode.
5666 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5667 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5668 members of a frame.
5669
b5b7745f
EZ
5670 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5671 'fullscreen' parameter. Always record previous width and height
5672 of the frame, except when switching out of maximized modes, so
5673 that they could be restored correctly, instead of resetting to the
5674 default frame dimensions. Send SC_RESTORE command to the frame,
5675 unless we are going to send SC_MAXIMIZE, to restore the frame
5676 resize hints in the mouse pointer shown by the window manager.
5677 (Bug#14032)
5678
5679 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5680
5681 * lisp.h (get_frame_param): Adjust conditions for prototype
5682 declaration.
5683
a3454eed
KB
56842013-03-22 Ken Brown <kbrown@cornell.edu>
5685
5686 * unexcw.c: Drop unneeded inclusion of w32common.h.
5687 (report_sheap_usage): Declare.
5688 (read_exe_header): Add magic numbers for x86_64.
5689 (fixup_executable): Fix printf format specifier for unsigned long
5690 argument.
5691
5a49b79c
DA
56922013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5693
5694 * frame.h (struct frame): Put menu_bar_window under #ifdef
5695 because this member is not needed when X toolkit is in use.
5696 (fset_menu_bar_window):
5697 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5698 (free_glyphs, update_frame):
5699 * xdisp.c (expose_frame): Likewise.
5700 (display_menu_bar): Likewise. Remove redundant eassert.
5701 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5702 toolkit is in use.
5703
d6723bf7
PE
57042013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5705
7b1123d8
PE
5706 Use functions and constants to manipulate Lisp_Save_Value objects.
5707 This replaces code that used macros and strings and token-pasting.
5708 The change makes the C source a bit easier to follow,
5709 and shrinks the Emacs executable a bit.
5710 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5711 (make_save_value): Change 1st arg from string to enum. All callers
5712 changed.
5713 (INTX): Remove.
5714 (mark_object): Use if, not #if, for GC_MARK_STACK.
5715 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5716 (XSAVE_OBJECT): Now functions, not macros.
5717 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5718 the constant was never used.
5719 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5720 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5721 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5722 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5723 New constants.
5724 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5725 type3 with a single member save_type. All uses changed.
5726 (save_type, set_save_pointer, set_save_integer): New functions.
5727 * print.c (PRINTX): Remove.
5728
d6723bf7
PE
5729 * alloc.c: Remove redundant static declarations.
5730
5f24fa51
DA
57312013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5732
5733 * window.h (struct window): Convert left_col, top_line, total_lines
5734 and total_cols from Lisp_Objects to integers. Adjust comments.
5735 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5736 Remove.
5737 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5738 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5739 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5740 Adjust users where appropriate.
5741
42143acd
DA
57422013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5743
5744 * frame.h (struct frame): Drop resx and resy because the same data is
5745 available from window system-specific output context. Adjust users.
562c6ee9
SM
5746 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5747 New functions to provide defaults when no window system available.
42143acd 5748 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5749 (NUMVAL): Move from xdisp.c.
42143acd
DA
5750 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5751 (Ffont_face_attributes, Fopen_font):
5752 * image.c (gs_load):
5753 * w32font.c (fill_in_logfont):
5754 * xdisp.c (calc_pixel_width_or_height):
5755 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5756 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5757
c0a17406
KH
57582013-03-20 Kenichi Handa <handa@gnu.org>
5759
5760 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5761 to 1 (temporary workaround until a bug related to ASCII
5762 optimization is fixed).
5763
095d384d
DA
57642013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5765
5766 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5767 Signal error if window is not internal. Adjust docstring.
5768 (delete_all_child_windows): Use combination_limit to save the buffer.
5769 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5770 * print.c (syms_of_print): Initialize debugging output not here...
5771 (init_print_once): ...but in a new function here.
5772 * lisp.h (init_print_once): Add prototype.
5773 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5774
748fa866
DA
57752013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5776
5777 * window.c (window_resize_check, window_resize_apply)
5778 (window_from_coordinates, recombine_windows, set_window_buffer)
5779 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5780 (Fsplit_window_internal, Fdelete_window_internal)
5781 (freeze_window_starts): Use bool for booleans.
5782 * window.h (window_frame_coordinates, resize_frame_windows)
5783 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5784
81519fd2
SM
57852013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5786
5787 * dispnew.c (bitch_at_user): Use `user-error'.
5788
6db423a9
KB
57892013-03-17 Ken Brown <kbrown@cornell.edu>
5790
5791 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5792 as return type of image_background. (Bug#13981)
5793 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5794
8f2906f5
JD
57952013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5796
960ce480 5797 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5798 (ns_select): Don't return with result uninitialized.
960ce480 5799
8f2906f5
JD
5800 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5801 and getDirectory.
5802
81519fd2
SM
5803 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5804 New functions.
8f2906f5
JD
5805 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5806 directories. If filename is nil, get directory name (Bug#13932).
5807 Use getFilename and getDirectory.
5808 (getFilename, getDirectory): New methods for EmacsSavePanel and
5809 EmacsOpenPanel.
5810 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5811
cded56c1
PE
58122013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5813
5814 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5815
251e9147 58162013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5817
5818 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5819 (adjust_after_replace): Make it back to static. Delete the third
5820 arg text_at_gap_tail. Cancel the code for handling it.
5821
5822 * coding.h (struct coding_system): New member eol_seen.
5823
5824 * coding.c (detect_ascii): New function.
5825 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5826 when the source bytes are actually scanned. On detecting for
5827 coding_category_utf_8_auto, call detect_ascii instead of scanning
5828 source bytes directly.
5829 (produce_chars): Call insert_from_gap with the new arg 0.
5830 (encode_coding): Likewise.
5831 (decode_coding_gap): Control ASCII optimization by the variable
5832 disable_ascii_optimization instead of #ifndef .. #endif.
5833 Deccode EOL format according to coding->eol_seen.
5834 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5835 variable.
5836
8a44e6d1
KH
5837 * lisp.h (adjust_after_replace): Cancel externing it.
5838 (insert_from_gap): Adjust prototype.
5839
5f795e34
EZ
58402013-03-15 Eli Zaretskii <eliz@gnu.org>
5841
5842 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5843 FULLSCREEN_MAXIMIZED. (Bug#13935)
5844
f258b4be
DA
58452013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5846
5847 * region-cache.c (find_cache_boundary, move_cache_gap)
5848 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5849 Simplify debugging check and convert to eassert. Adjust comment.
5850 (pp_cache): Put under ENABLE_CHECKING.
5851
a5cc4dde
EZ
58522013-03-14 Eli Zaretskii <eliz@gnu.org>
5853
5854 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5855 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5856 and WM_ACTIVATEAPP.
5857 (w32fullscreen_hook): If the frame is visible, reset
5858 f->want_fullscreen flag after changing the frame size. If the
5859 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5860 (Bug#13953)
5861
3fc5e44a
DC
58622013-03-13 Daniel Colascione <dancol@dancol.org>
5863
5864 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5865 too so that these builds can use Cygwin's file conversion
5866 functions. (We've been building and linking cygw32.o all along
5867 and just not using it.)
5868
47d7532e
PE
58692013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5870
5871 File synchronization fixes (Bug#13944).
5872 * Makefile.in (LIB_FDATASYNC): New macro.
5873 (LIBES): Use it.
5874 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5875 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5876 Don't worry about HAVE_FSYNC, since a substitute fsync is
5877 available if the system lacks one.
5878 (Fwrite_regin): Retry fsync if interrupted.
5879
c7ffccaf
EZ
58802013-03-13 Eli Zaretskii <eliz@gnu.org>
5881
4e2df81d 5882 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5883 activated, call w32fullscreen_hook, to make sure the new frame
5884 dimensions are in effect. (Bug#13937)
5885
8a7debc1
DA
58862013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5887
5888 * xdisp.c (init_iterator): Simplify because both character and byte
5889 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5890 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5891 character and byte positions can be obtained from marker.
8a7debc1 5892
7fd8c501
PE
58932013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5894
d9df6f40
PE
5895 Static checking by Sun C 5.12.
5896 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5897 * bytecode.c (exec_byte_code):
5898 * dispnew.c (init_display):
5899 * eval.c (error):
5900 * fileio.c (Fsubstitute_in_file_name):
5901 * keyboard.c (Fevent_convert_list):
5902 * keymap.c (Fsingle_key_description):
5903 * term.c (maybe_fatal, fatal):
5904 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5905 * xsmfns.c (Fhandle_save_session):
5906 Omit unreachable code.
5907 * keymap.c (map_keymap_char_table_item): Cast void * to
5908 a function pointer type; the C Standard requires this.
5909
7fd8c501
PE
5910 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5911 Include <sys/param.h> unconditionally, as that works elsewhere and
5912 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5913 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5914 and FreeBSD now.
5915
a020afb9 5916See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5917
5918;; Local Variables:
5919;; coding: utf-8
aac0c6e3
MR
5920;; End:
5921
ab422c4d 5922 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5923
5924 This file is part of GNU Emacs.
5925
5926 GNU Emacs is free software: you can redistribute it and/or modify
5927 it under the terms of the GNU General Public License as published by
5928 the Free Software Foundation, either version 3 of the License, or
5929 (at your option) any later version.
5930
5931 GNU Emacs is distributed in the hope that it will be useful,
5932 but WITHOUT ANY WARRANTY; without even the implied warranty of
5933 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5934 GNU General Public License for more details.
5935
5936 You should have received a copy of the GNU General Public License
5937 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.