Fix syntax.h bug introduced by recent INLINE change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c6cfd910
PE
12013-09-22 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix syntax.h bug introduced by recent INLINE change.
4 syntax.h defined an extern inline function SYNTAX_ENTRY that was
5 conditionally compiled one way in some modules, and a different
6 way in others. This doesn't work with extern inline functions,
7 which must have the same definition in all modules, because the
8 defining code might be shared across modules, depending on the
9 implementation. Symptoms reported by Martin Rudalics in:
10 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
11 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
12 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
13 overriding the corresponding functions in syntax.h.
14 * syntax.h (syntax_property_entry, syntax_property_with_flags)
15 (syntax_property): New inline functions.
16 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
17 Rewrite in terms of these new functions.
18
b3f1d119
EZ
192013-09-21 Eli Zaretskii <eliz@gnu.org>
20
21 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
22 not chars_in_text, whose result depends on the multibyteness of
23 the current buffer. (Bug#15426)
24
00382e8b
PE
252013-09-20 Paul Eggert <eggert@cs.ucla.edu>
26
e3b29769
PE
27 Port recent change to hosts where pointers aren't 'long'.
28 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
29 Don't assume that pointers are the same width as 'long'.
30 Add a compile-time check that a pointer fits into two X slots.
31
00382e8b
PE
32 A simpler, centralized INLINE.
33 * conf_post.h (INLINE): Define only if not already defined.
34 This allows us to use a single INLINE, defined by one file
35 per executable.
36 * emacs.c (INLINE): Define it.
37 Also, include category.h, charset.h, composite.h, dispextern.h,
38 syntax.h, systime.h, so that their INLINE definitions are expanded
39 properly for Emacs.
40 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
41 * buffer.h, buffer.c (BUFFER_INLINE):
42 * category.h, category.c (CATEGORY_INLINE):
43 * character.h, character.c (CHARACTER_INLINE):
44 * charset.h, charset.c (CHARSET_INLINE):
45 * composite.h, composite.c (COMPOSITE_INLINE):
46 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
47 * frame.h, frame.c (FRAME_INLINE):
48 * intervals.h, intervals.c (INTERVALS_INLINE):
49 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
50 * lisp.h, alloc.c (LISP_INLINE):
51 * process.h, process.c (PROCESS_INLINE):
52 * syntax.h, syntax.c (SYNTAX_INLINE):
53 * systime.h, sysdep.c (SYSTIME_INLINE):
54 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
55 * window.h, window.c (WINDOW_INLINE):
56 Remove. All uses replaced with INLINE.
57
2b943ba6
DA
582013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
59
60 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
61 to avoid Bug#15398.
62
13d9698a
EZ
632013-09-19 Eli Zaretskii <eliz@gnu.org>
64
65 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
66 'const char *' to avoid compiler warnings due to similar change in
67 the prototype of x_get_string_resource.
68
ced135eb
DA
692013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
70
71 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
72 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
73 going to replace static variables below. Adjust comments.
74 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
75 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
76 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
77 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
78 Related users changed.
79 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
80 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
81 last_mouse_movement_time, going to replace static variables below.
82 Adjust comments.
83 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
84 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
85 Remove.
86 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
87 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
88 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
89 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
90 static variables below.
91 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
92 (last_mouse_scroll_bar): Remove.
93 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
94 (mouseExited): Related users changed.
95
091f1e1f
DA
962013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
97
98 Do not use external array to process X scroll bar messages.
99 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
100 (x_send_scroll_bar_event): Pack window pointer into two slots
101 of XClientMessageEvent if we're 64-bit. Adjust comment.
102 (x_scroll_bar_to_input_event): Unpack accordingly.
103
582ed56c
DA
1042013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
105
106 Ifdef away recent changes which aren't relevant to NS port.
107 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
108 [!HAVE_NS]: Declare as such.
109 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
110 [!HAVE_NS]: Define as such.
111
18da0d8a
DA
1122013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * frame.c (x_redo_mouse_highlight): New function
115 to factor out common code used in W32 and X ports.
116 * dispextern.h (x_redo_mouse_highlight): Add prototype.
117 * xterm.h (struct x_display_info):
118 * w32term.h (struct w32_display_info):
119 * nsterm.h (struct ns_display_info): New members
120 last_mouse_motion_frame, last_mouse_motion_x and
121 last_mouse_motion_y, going to replace static variables below.
122 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
123 (redo_mouse_highlight): Remove.
124 (note_mouse_movement, syms_of_xterm): Adjust user.
125 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
126 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
127 (redo_mouse_highlight): Remove.
128 (note_mouse_movement, syms_of_w32term): Adjust user.
129 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
130 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
131 Remove.
132 (note_mouse_movement, mouseMoved, syms_of_nsterm):
133 * nsfns.m (compute_tip_xy): Adjust user.
134
7a0c745a
DA
1352013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
136
137 * frame.c (x_mouse_grabbed): New function.
138 * dispextern.h (x_mouse_grabbed): Add prototype.
139 (last_mouse_frame): Remove declaration.
140 * xterm.h (struct x_display_info):
141 * w32term.h (struct w32_display_info):
142 * nsterm.h (struct ns_display_info): New member
143 last_mouse_frame, going to replace...
144 * xdisp.c (last_mouse_frame): ...global variable.
145 (note_tool_bar_highlight):
146 * w32term.c (w32_mouse_position, w32_read_socket):
147 * xterm.c (XTmouse_position, handle_one_xevent):
148 Use x_mouse_grabbed.
149 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
150
0791d107
DA
1512013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
152
153 * w32term.c (w32_read_socket): Avoid temporary
154 variables in a call to x_real_positions.
155 * xterm.c (handle_one_xevent): Likewise.
156
2cd98812
DA
1572013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
158
159 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
160 (x_icon_type): Remove prototype.
161 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
162 * frame.c (x_icon_type): Remove.
163 * w32term.c (x_make_frame_visible, x_iconify_frame):
164 * xterm.c (x_make_frame_visible, x_iconify_frame):
165 Use x_set_bitmap_icon to factor out common code.
166
a6c2ee1b
DA
1672013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
168
169 * dispextern.h (check_x_display_info, x_get_string_resource):
170 Declare here just once and unify the latter.
171 * frame.c (check_x_display_info, x_get_string_resource):
172 * nsterm.h (check_x_display_info):
173 * xrdb.c (x_get_string_resource):
174 * xterm.h (check_x_display_info): Remove prototypes.
175 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
176 * w32reg.c (x_get_string_resource): Likewise.
177 (w32_get_rdb_resource): Adjust user.
178
baed3603
DA
1792013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
180
181 * xterm.h (struct x_display_info): New member
182 x_pending_autoraise_frame, going to replace...
183 * xterm.c (pending_autoraise_frame): ...static variable.
184 (x_new_focus_frame, XTread_socket): Adjust users.
185 * w32term.h (struct w32_display_info): New member
186 w32_pending_autoraise_frame, going to replace...
187 * w32term.c (pending_autoraise_frame): ...global variable.
188 (x_new_focus_frame, w32_read_socket): Adjust users.
189
90582f05
GM
1902013-09-17 Glenn Morris <rgm@gnu.org>
191
192 * xdisp.c (message_dolog): If we create *Messages*,
193 switch it to messages-buffer-mode.
194
b7ad2f74
PE
1952013-09-17 Paul Eggert <eggert@cs.ucla.edu>
196
197 Don't overuse 'const' in types of locals.
198 * bidi.c (bidi_count_bytes):
199 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
200 (xg_event_is_for_scrollbar):
201 * xselect.c (x_handle_property_notify)
202 (x_handle_selection_notify, x_handle_dnd_message):
203 * xsettings.c, xsettings.h (xft_settings_event):
204 * xterm.c (x_handle_net_wm_state, handle_one_event)
205 (x_menubar_window_to_frame, x_detect_focus_change)
206 (construct_mouse_click, note_mouse_movement)
207 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
208 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
209 (handle_one_xevent, x_handle_net_wm_state):
210 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
211 (x_handle_dnd_message):
212 Avoid unnecessary 'const', typically the second 'const' in
213 'const foo * const arg', a 'const' that does not affect the API
214 and doesn't significantly help the human reader.
215
19452b86
DA
2162013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
217
218 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
219 only if Glib < 2.36.0.
220 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
221 * xsettings.c (init_gconf, init_gsettings): Do not check
222 for g_type_init.
1893694e
DA
223 * xterm.c (handle_one_xevent): Do not call to x_clear_area
224 if GTK >= 2.7.0.
33b83dd7 225 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 226
6434e343
JD
2272013-09-16 Jan Djärv <jan.h.d@swipnet.se>
228
3f386383
JD
229 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
230 before calling g_type_init.
231
6434e343
JD
232 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
233
234 * nsterm.m (syms_of_nsterm): ... to here.
235
83a119f8
DA
2362013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
237
238 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
239 (ignore_next_mouse_click_timeout): Use Time as X does.
240 (handle_one_xevent): Avoid cast and use unsigned comparison.
241
61582e6a
DA
2422013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
243
244 Do not copy X event in handle_one_xevent except KeyPress case.
245 Wnen XEvent is processed, it is unlikely to be changed except
246 KeyPress case, so we can avoid copying and use const pointer to
247 const data to make sure that an event is not changed elsewhere.
248 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
249 const' and do not create local copy except for the KeyPress event.
250 Use casts to avoid a few glitches. Adjust formatting. Add comments.
251 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
252 (x_handle_net_wm_state, x_menubar_window_to_frame)
253 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
254 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
255 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
256 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
257 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
258 (x_handle_dnd_message):
259 * xsettings.c (xft_settings_event):
260 Use 'const XEvent * const' where appropriate.
261 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
262
f8eb1572
DA
2632013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Fix X event waiting to handle multiple frames.
266 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
267 * xterm.c (pending_event_wait): Remove. Adjust users.
268 (x_detect_focus_change): Pass frame arg.
269 (handle_one_xevent): Find related frame early and clear per-frame
270 wait_event_type only if this is an event for the relevant frame.
271 (x_wait_for_event): Use per-frame wait_event_type.
272
3fa2054e
JD
2732013-09-15 Jan Djärv <jan.h.d@swipnet.se>
274
745d3809
JD
275 * nsfns.m (Fx_create_frame): Fix font driver registration for
276 GNUStep.
277
278 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
279 for syms_of_macfont.
280
3fa2054e
JD
281 * nsterm.m: Include macfont.h.
282 (ns_tmp_flags, ns_tmp_font): Remove.
283 (ns_compute_glyph_string_overhangs): Check for driver Qns.
284 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
285 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
286 (changeFont:): Fix code style. Check for font driver type when
287 getiing font.
288
289 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
290 (f)->descent.
291
292 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
293 (nsfont_open): Set font driver type.
294 Set font->ascent and font->descent. Figure out font instead of
295 ns_tmp_font, and flags instead of ns_tmp_flags.
296 Fix indentation. Remove call to ns_draw_text_decoration,
297 moved to nsterm.
298
299 * nsfns.m: Include macfont.h.
300 (Fx_create_frame): Register macfont driver, make a better default font.
301 (Fns_popup_font_panel): Get font from macfont driver, if used.
302
303 * macfont.m, macfont.h, maccuvs.h: New files.
304
305 * font.h: Declare syms_of_macfont.
306
307 * font.c (syms_of_font): Call syms_of_macfont.
308
309 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
310
0eed0355
DA
3112013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
312
313 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
314 and it is always zero for others, so I assume that this is an ancient
315 leftover which nobody will want to change any more.
316 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
317 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
318 * frame.c (x_set_scroll_bar_width):
319 * w32fns.c (w32_createscrollbar):
320 * w32term.c (w32_set_vertical_scroll_bar):
321 * xfns.c (x_set_scroll_bar_default_width):
322 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
323 (x_scroll_bar_expose): Related users changed.
324
07013c68
DA
3252013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
326
327 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
328 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
329 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
330 Define as such.
c7cc32f7
DA
331 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
332 Define once here...
333 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
334 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
335 Remove unused Xisms.
7f09455e
DA
336 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
337 these modules are never compiled otherwise.
07013c68 338
0df00f59
EZ
3392013-09-14 Eli Zaretskii <eliz@gnu.org>
340
08a209bf 341 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
342 Doc fix. (Bug#15375)
343
fcd42c11
DA
3442013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Unify Fx_focus_frame between all ports.
347 * frame.h (x_focus_frame): New prototype.
348 * xfns.c (Fx_focus_frame): Remove.
349 (syms_of_xfns): Do not defsubr it.
350 (x_focus_frame): X implementation.
351 * nsfns.m (Fx_focus_frame): Remove.
352 (syms_of_nsfns): Do not defsubr it.
353 (x_focus_frame): NS implementation.
354 * w32term.c (Fx_focus_frame): Remove.
355 (x_focus_on_frame): Rename to...
356 (x_focus_frame): W32 implementation.
357 * w32term.h (x_focus_on_frame): Remove prototype.
358 * w32fns.c (Fx_focus_frame): Remove.
359 (syms_of_w32fns): Do not defsubr it.
360 * frame.c (Fx_focus_frame): Define here.
361 (syms_of_frame): Defsubr here.
362 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
363
aad3612f
DA
3642013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
365
366 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
367 All of them are replaced with FRAME_DISPLAY_INFO, defined in
368 each port to reference the port-specific window system data.
369 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
370 (FRAME_DISPLAY_INFO): Define.
371 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
372 (FRAME_DISPLAY_INFO): Define. Adjust users.
373 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
374 (FRAME_DISPLAY_INFO): Define. Adjust users.
375 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
376 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
377 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
378 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
379 * xselect.c, xterm.c: All related users changed.
380
9a650e62
DA
3812013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
382
383 * xterm.h (x_window_to_frame, x_any_window_to_frame)
384 (x_menubar_window_to_frame): Remove prototypes.
385 * xfns.c (x_window_to_frame, x_any_window_to_frame)
386 (x_menubar_window_to_frame, x_top_window_to_frame):
387 Move from here...
388 * xterm.c (x_window_to_frame, x_any_window_to_frame)
389 (x_menubar_window_to_frame, x_top_window_to_frame):
390 ...to here and convert all but the last to static.
391
347ae3e1
EZ
3922013-09-12 Eli Zaretskii <eliz@gnu.org>
393
394 * lisp.mk (lisp): Add w32-common-fns.elc.
395
15c6d837
XF
3962013-09-12 Xue Fuqiao <xfq.free@gmail.com>
397
398 * charset.c (char_charset): Document an exception for char-charset.
399
27e90f77
DA
4002013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
401
402 * xterm.h (x_display_info): New field last_user_time...
403 * xterm.c (toplevel): ...to replace static last_user_time.
404 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
405
8ffbc36b
DA
4062013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
407
408 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
409 scroll bar values to prevent thumb from disappear and update comment.
410
5ec0337a
GM
4112013-09-11 Glenn Morris <rgm@gnu.org>
412
413 * emacs.c (usage_message): Possessive apostrophe tweak.
414
fb55b9d1
DA
4152013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
416
8d2db8be
DA
417 * nsterm.m (syms_of_nsterm): Use Qns.
418 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
419 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
420 * xfns.c (x_display_info_for_name, Fx_open_connection):
421 Remove old '#if 0' code.
422 (syms_of_xfns): Use Qx.
fb55b9d1
DA
423 * termhooks.h (fullscreen_hook): Remove the leftover.
424 (struct terminal): Fix typo in comment.
425
927eec55
DA
4262013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
427
428 Cleaning up a few X scroll bar bits.
429 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
430 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
431 New member last_seen_part, going to replace...
432 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
433 (xt_action_hook) [USE_LUCID]: Adjust user.
434 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
435 Lucid-specific scroll bar support.
436 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
437 to int and adjust to use last_seen_part member.
438 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
439 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
440 Initialize last_seen_part.
441
71b28baa
SM
4422013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
443
444 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
445 insert-buffer-substring an empty string.
446
f5dacaae
PE
4472013-09-11 Paul Eggert <eggert@cs.ucla.edu>
448
449 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
450 avoiding a GCC warning.
451
742516e0
DA
4522013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
453
454 Ifdef away frame tool bar code when it is not really used.
455 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
456 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
457 and minimize_tool_bar_window_p under the above.
458 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
459 (fset_tool_bar_window): Likewise.
460 * dispnew.c (clear_current_matrices, clear_desired_matrices)
461 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
462 (change_frame_size_1):
463 * window.c (window_from_coordinates, Frecenter): Adjust users.
464 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
465 code is not really used.
466 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
467 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
468 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
469 [!USE_GTK && !HAVE_NS]: Define as such.
470 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
471 (note_mouse_highlight, expose_frame):
472 * xfns.c (x_set_tool_bar_lines):
473 * xterm.c (handle_one_xevent): Adjust users.
474
73f82c7e
PE
4752013-09-11 Paul Eggert <eggert@cs.ucla.edu>
476
477 Fix corruption with multiple emacsclient -t instances (Bug#15222).
478 This bug was introduced by my 2013-08-26 patch, which incorrectly
479 assumed that the terminfo implementation doesn't use termcap buffers.
480 * term.c (init_tty) [TERMINFO]: Remove optimization, as
481 these buffers apparently are used after all.
482 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
483 (struct tty_display_info): Define members termcap_term_buffer and
484 termcap_strings_buffer even if TERMINFO.
485
53482f41
DA
4862013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Fix last change.
489 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
490 'usage' docstring entry to pacify make-docfile.
491
4922013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
493
494 Change comparison functions =, <, >, <=, >= to take many arguments.
495 * data.c: Change comparison functions' interface and implementation.
496 * lisp.h: Make arithcompare available for efficient two arg
497 comparisons.
498 * bytecode.c: Use arithcompare.
499 * fileio.c: Use new interface.
500
533f258f
SM
5012013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
502
503 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
504
8c27f5ff
SM
5052013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
506
507 * eval.c (Feval): Document the new use of `lexical'.
508
0750a308
DA
5092013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
510
511 Review and drop old frame resize hack.
512 * frame.h (struct frame): Remove force_flush_display_p.
513 * dispnew.c (update_frame): Adjust user and don't call
514 flush_frame here. The comment has said that there was an issues
515 with redisplaying fringes, but I don't see any differences with
516 and without this hack. Hopefully we can continue without it.
517 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
518 current frame matrices twice if resized_p is set.
519
83fc0554
DA
5202013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
521
522 Do not populate pure Xism x_sync to other ports.
523 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
524 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
525 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
526 * w32term.h (x_sync): Remove prototype.
527
fd462129
DA
5282013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
529
530 Cleanup frame flushing.
8c27f5ff
SM
531 * dispextern.h (struct redisplay_interface):
532 Drop flush_display_optional because flush_display is enough
fd462129
DA
533 for X and flushing via RIF is just a no-op for others.
534 * frame.h (flush_frame): New function.
535 * dispnew.c (update_frame):
536 * minibuf.c (read_minibuf):
537 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
538 Use it.
539 * keyboard.c (detect_input_pending_run_timers): Do not flush
540 all frames but selected one in redisplay_preserve_echo_area.
541 * nsterm.m (ns_flush): Remove no-op.
542 (ns_redisplay_interface): Adjust user.
543 * w32term.h (x_flush): Remove no-op.
544 (w32_redisplay_interface): Adjust user.
545 * xterm.c (x_flush): Simplify because we do not flush all
546 frames at once any more. Adjust comment.
547 (x_redisplay_interface): Adjust user.
548
4b73fc73
PE
5492013-09-07 Paul Eggert <eggert@cs.ucla.edu>
550
551 Port --without-x --enable-gcc-warnings to Fedora 19.
552 * gfilenotify.c (globals_of_gfilenotify):
553 Call g_type_init only if using an older glib version that needs it.
554
77394d40
DA
5552013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
556
557 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
558 (last_glyphless_glyph_merged_face_id): Remove declarations.
559 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
560 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
561 (last_glyphless_glyph_merged_face_id): Now static.
562 (merge_escape_glyph_face): New function, refactored from...
563 (get_next_display_element): ...here.
564 (merge_glyphless_glyph_face): New function, refactored from...
565 (produce_glyphless_glyph): ...here...
566 * term.c (produce_glyphless_glyph): ...and here.
567
306d67bd
SM
5682013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
569
570 * eval.c (eval_sub): Only call Ffunction if necessary.
571
7f6c6450
DA
5722013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
573
574 Attempt to make redisplay more selective when changing cursor type.
575 * frame.h (struct frame): New bitfield cursor_type_changed.
576 * xdisp.c (cursor_type_changed): Remove.
577 (try_cursor_movement, redisplay_window, try_window_id)
578 (set_frame_cursor_types, try_window_reusing_current_matrix):
579 Adjust to use per-frame bitfield.
580 (redisplay_internal): Look for cursor type change on each visible
581 frame and consider all frames if cursor type has been changed on
582 the frame other than selected. If cursor type has been changed on
583 selected frame only, do not use fast update.
584
bd0443bb
DA
5852013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
586
587 Attempt to make redisplay more selective when changing fonts.
588 * frame.h (struct frame): New bitfield fonts_changed.
589 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
590 (adjust_frame_glyphs): Add prototype.
591 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 592 (adjust_glyphs): Remove because we do not
bd0443bb
DA
593 adjust matrices on all frames at once any more.
594 (adjust_frame_glyphs): Block and unblock input here.
595 (adjust_glyph_matrix): Use fonts_changed.
596 (change_frame_size_1): Use adjust_frame_glyphs.
597 * font.c (font_open_entity): Use fonts_changed.
598 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
599 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
600 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
601 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
602 (shrink_mini_window, Fresize_mini_window_internal)
603 (window_scroll_pixel_based, Fset_window_configuration)
604 (apply_window_adjustment, Fset_window_vscroll):
605 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
606 Use adjust_frame_glyphs.
607 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
608 (try_window_reusing_current_matrix, try_window_id, display_line)
609 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
610 (redisplay_internal): Consider fonts_changed and adjust frame
611 matrices for each frame only if the frame is visible. If font
612 has been changed on some frame during full redisplay, retry
613 only visible frames where the font has been actually changed.
614
b9695828
DA
6152013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
616
617 Cache current header and mode line height for each window.
618 * window.h (struct window): New fields mode_line_height
619 and header_line_height.
620 * window.c (make_window): Initialize them.
621 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
622 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
623 (current_mode_line_height, current_header_line_height):
624 Remove declaration.
625 * xdisp.c (current_mode_line_height, current_header_line_height):
626 Remove.
627 (pos_visible_p, init_xdisp): Adjust user.
628 (redisplay_window): Invalidate mode_line_height and
629 header_line_height if current and desired matrices do not agree.
630
66738305
DA
6312013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
632
633 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
634 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
635
257b3b03
DA
6362013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
637
638 Make --without-x compatible with --enable-gcc-warnings.
639 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
640 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
641 members under HAVE_WINDOW_SYSTEM.
642 * keyboard.c (make_lispy_focus_out): Likewise.
643 (record_menu_key): Move under HAVE_MENUS.
644 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
645 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
646 (syms_of_xdisp): Adjust user.
647 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
648 (start_hourglass, cancel_hourglass):
649 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
650 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
651 and CLEAR_FONT_TABLE_NFONTS.
652 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
653 Declare only if HAVE_WINDOW_SYSTEM.
654 (lface_same_font_attributes_p, clear_face_gcs): Define only
655 if HAVE_WINDOW_SYSTEM.
656
98b7f4bd
DA
6572013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
658
659 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
660 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
661 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
662
a7e43722
SM
6632013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
664
665 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
666
0c90b9ee
PE
6672013-09-04 Paul Eggert <eggert@cs.ucla.edu>
668
669 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
670 This fixes a type error on hosts where ptrdiff_t is wider than int.
671
d99760fa
SM
6722013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
673
6629638e
SM
674 * keyboard.c (read_key_sequence_vs): New function.
675 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
676 common code.
677
d99760fa
SM
678 * callint.c (Fcall_interactively): Always return a vector for 'K'.
679
224e313d
PE
6802013-09-04 Paul Eggert <eggert@cs.ucla.edu>
681
682 Makefile improvements.
683 * Makefile.in (config.status): Don't use double-colon rules, as
684 they are not portable according to POSIX. Fix shell typo with `;
685 I guess this rule has never been tested?
686 (VCSWITNESS): New macro, to override any environment var.
687
6d6ed1af
DA
6882013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
689
690 * xterm.h (struct x_display_info): Do not track X connection
691 fd separately because it is always available from Display.
692 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
693 Adjust users.
694
bc923770
DA
6952013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
696
697 * buffer.c (drop_overlay):
698 * fileio.c (restore_point_unwind): Prefer unchain_marker to
699 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
700
b1cf96de
DA
7012013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
702
703 * buffer.c (Fmake_overlay, Fmove_overlay):
704 * intervals.c (set_point_from_marker):
705 * print.c (PRINTPREPARE): Prefer signal_error
706 to plain error and report unsuitable marker too.
707
d1fc6c21
DA
7082013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
709
710 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
711 for 'dragging' member.
d1ae6a0b
DA
712 (struct x_output): Remove set-but-unused leftovers
713 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
714 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
715 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
716 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
717 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
718 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
719 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 720 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 721 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 722
0ce9f6de
JD
7232013-09-03 Jan Djärv <jan.h.d@swipnet.se>
724
725 * nsfont.m (INVALID_GLYPH): New define.
726 (nsfont_encode_char): Use INVALID_GLYPH.
727 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
728
b594a96c
DA
7292013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
730
731 * xterm.c (x_last_mouse_movement_time): Revert last change.
732 This code should use XDisplayMotionBufferSize to check display's
733 motion history first, and there are few other issues as well.
734 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
735 (handle_one_xevent): Adjust user.
736
8b098236
MR
7372013-09-02 Martin Rudalics <rudalics@gmx.at>
738
9718b207
MR
739 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
740 * frame.c (Flast_nonminibuf_frame): ... to here.
741 (check_minibuf_window): Don't abort if no window was found
742 (Bug#15247).
8b098236 743
84e70bba
DA
7442013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
745
746 Use XGetMotionEvents to ask the last mouse motion time from X server.
747 * xterm.c (X_MOTION_HISTORY): Default to 1.
748 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
749 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
750 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
751 Ifdef away legacy code.
752 (XTmouse_position, x_scroll_bar_report_motion):
753 Use x_last_mouse_movement_time.
fc85e20b
DA
754 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
755 UnmapNotify event.
84e70bba 756
1fccc530
DA
7572013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
758
759 * msdos.c (last_mouse_window): Move to...
760 (dos_rawgetc): ...this function and adjust comment.
761 * nsterm.m (last_window): Rename to last_mouse_window, move to...
762 (mouseMoved): ...this function and adjust comment.
763 * w32term.c (last_window): Likewise with...
764 (w32_read_socket): ...this function.
765 * xterm.c (last_window): Likewise with...
766 (handle_one_xevent): ...this function.
767
0ab10992
DA
7682013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
769
b7da754d 770 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
771 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
772 (handle_one_xevent): ...to here.
773 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
774 otherwise.
775
0c7f856e
DA
7762013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
777
778 * msdos.c (IT_set_terminal_window): Remove no-op.
779 (initialize_msdos_display): Adjust terminal setup.
780 * w32console.c (w32con_set_terminal_window): Remove no-op.
781 (initialize_w32_display): Adjust terminal setup.
782 * w32term.c (w32_set_terminal_window): Remove no-op.
783 (w32_create_terminal): Adjust terminal setup.
784 * xterm.c (XTset_terminal_window): Remove no-op.
785 (x_create_terminal): Adjust terminal setup.
786
a892a94c
DA
7872013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
788
789 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
790 Remove no-ops.
791 (ns_create_terminal): Adjust terminal setup.
792 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
793 Remove no-ops.
794 (w32_create_terminal): Adjust terminal setup.
795 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
796 Remove no-ops.
797 (x_create_terminal): Adjust terminal setup.
798
cf91889a
DA
7992013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
800
801 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
802 (CLIP_TEXT_POS_FROM_MARKER): New macro.
803 * dispnew.c (buffer_posn_from_coords):
804 * window.c (Fwindow_end, displayed_window_lines):
805 * xdisp.c (redisplay_mode_lines): Use it.
806
5b0891df
JD
8072013-09-01 Jan Djärv <jan.h.d@swipnet.se>
808
809 * fontset.c (face_for_char): Check char in the current face font first
810 if HAVE_NS (Bug#15138).
811
0a357e98
MR
8122013-08-31 Martin Rudalics <rudalics@gmx.at>
813
814 * window.c (temp_output_buffer_show): Make sure window returned
815 by display_buffer is live (Bug#15213).
816
9d7693d7
DA
8172013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
818
819 Minor cleanup to avoid forward declarations.
820 * coding.h (struct ccl_spec): Remove forward declaration.
821 * composite.h (toplevel): Include font.h.
822 (struct composition_it, struct face, struct font_metrics):
823 Remove forward declaration.
824 * dispextern.h (struct image, struct atimer): Likewise.
825 * emacsgtkfixed.h (struct frame): Likewise.
826 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
827 * font.h (struct font_driver, struct font, struct glyph_string)
828 (struct face): Remove forward declaration.
829 * fontset.h (struct face, struct font): Likewise.
830 * frame.h (toplevel): Style cleanup.
831 (enum output_method): Move to...
832 * termhooks.h (enum output_method): ...here.
833 (struct glyph, struct frame, struct ns_display_info)
834 (struct x_display_info, struct w32_display_info):
835 Remove forward declaration.
836 * xterm.h (toplevel): Include termhooks.h.
837 (struct font, struct window, struct glyph_matrix, struct frame)
838 (struct input_event, struct face, struct image): Remove forward
839 declaration.
840 * gtkutil.h (struct _widget_value): Likewise.
841 * keyboard.h (toplevel): Include termhooks.h.
842 (struct input_event): Remove forward declaration.
843
032f7451
DA
8442013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
845
846 * intervals.c (set_point_from_marker): New function.
847 * editfns.c (Fgoto_char):
848 * process.c (Finternal_default_process_filter):
849 * window.c (select_window_1): Use it.
850 * buffer.h (set_point_from_marker): Add prototype.
851
3f940c5a
EZ
8522013-08-29 Eli Zaretskii <eliz@gnu.org>
853
854 * w32.c (term_winsock): Call release_listen_threads before calling
855 WSACleanup.
856 (_sys_wait_accept): Wait for accept event in a loop with a finite
857 timeout, instead of waiting indefinitely. Will hopefully avoid
858 hanging during exit because WSACleanup deadlocks waiting for the
859 event object to be released. (Bug#14333)
860
861 * w32proc.c (release_listen_threads): New function, signals all
862 the reader threads that listen for connections to stop waiting.
863
864 * w32.h (release_listen_threads): Add prototype.
865
101ed2bb
DA
8662013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
867
868 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
869 field of new marker (for sanity and safety).
20de2834
DA
870 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
871 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 872
1f5cf200
DA
8732013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
874
875 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
876 (x_after_update_window_line, x_scroll_bar_create):
877 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
878 (handle_one_xevent, x_clear_frame_area):
879 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
880 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
881 * xterm.h (x_clear_area): Adjust prototype.
882
d2b36813
DA
8832013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
884
885 Hook scanning and indentation functions to find_newline. This helps
886 to avoid duplicated code and renders more respect to newline cache.
887 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
888 * cmds.c (Fforward_line):
889 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
890 Use find_newline and avoid unnecessary point movements.
891 * search.c (scan_newline): Implement on top of find_newline.
892
3ec7babc
SM
8932013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
894
895 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
896 scoped code (bug#11258).
897
5ab473cd
JD
8982013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
899
900 * nsterm.m (last_window): New variable.
901 (EV_TRAILER2): New macro.
902 (EV_TRAILER): Call EV_TRAILER2.
903 (mouseMoved:): Add support for mouse-autoselect-window
904 on nextstep (Bug#6888).
905
78779650
AS
9062013-08-28 Andreas Schwab <schwab@suse.de>
907
908 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
909 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
910 Remove unused macro definitions.
911 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
912 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
913 Only define if emacs.
78779650 914
c3c4768d
DA
9152013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
916
917 Prefer enum glyph_row_area to int where appropriate.
918 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
919 Fix comment.
920 (window_box, window_box_width, window_box_left, window_box_left_offset)
921 (window_box_right, window_box_right_offset): Adjust prototypes.
922 * xdisp.c (window_box, window_box_width, window_box_left)
923 (window_box_left_offset, window_box_right, window_box_right_offset):
924 Use enum glyph_row_area. Adjust users and tweak comment where needed.
925 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
926 * nsterm.m (ns_clip_to_row):
927 * w32term.c (w32_clip_to_row):
928 * xterm.c (x_clip_to_row): Likewise.
929
6bdcbfe1
DA
9302013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
931
932 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
933 (Fprevious_overlay_change): Fast path for buffer with no overlays.
934
50b13cde
PE
9352013-08-28 Paul Eggert <eggert@cs.ucla.edu>
936
937 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
938 for portability to hosts where /bin/sh has problems.
939
f60e429a
DA
9402013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
941
942 Redesign redisplay interface to drop global output_cursor.
943 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
944 (toplevel): Remove declaration of output_cursor.
945 (set_output_cursor, x_cursor_to): Remove prototype.
946 * window.h (struct window): New member output_cursor.
947 (output_cursor_to): New function to replace RIF member.
948 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
949 (update_text_area, set_window_cursor_after_update): Use it.
950 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
951 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
952 * nsterm.m (ns_update_window_begin, ns_update_window_end):
953 * w32term.c (x_update_window_begin, x_update_window_end):
954 * xterm.c (x_update_window_begin, x_update_window_end):
955 Adjust to use per-window output cursor.
956
43aac990
PE
9572013-08-27 Paul Eggert <eggert@cs.ucla.edu>
958
d486344e
PE
959 Simplify SELECT_TYPE-related code.
960 Like EMACS_TIME, this portability layer is no longer needed, since
961 Emacs has been using fd_set as a portability layer for some time.
962 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
963 (SELECT_TYPE): Remove. All uses changed to fd_set.
964 (fd_set) [!FD_SET]: New typedef.
965
43aac990
PE
966 Simplify EMACS_TIME-related code.
967 This portability layer is no longer needed, since Emacs has been
968 using struct timespec as a portability layer for some time.
969 * atimer.h, buffer.h, dispextern.h, xgselect.h:
970 Include <time.h> rather than "systime.h"; that's all that's needed now.
971 * dispnew.c: Include <timespec.h> rather than "systime.h";
972 that's all that's needed now.
973 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
974 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
975 TIMESPEC_RESOLUTION.
976 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
977 LOG10_TIMESPEC_RESOLUTION.
978 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
979 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
980 (make_emacs_time): Remove. All used changed to make_timespec.
981 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
982 (current_timespec): Rename from current_emacs_time. All uses changed.
983 (add_emacs_time): Remove. All uses changed to timespec_add.
984 (sub_emacs_time): Remove. All uses change dot timespec_sub.
985 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
986 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
987 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
988 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
989 (current_timespec): Rename from current_emacs_time. All uses changed.
990 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
991 changed to timespec_cmp.
992 * xgselect.c: Include <timespec.h>, since our .h files don't.
993
d350e350
DA
9942013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
995
996 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
997 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
998 Remove the leftovers.
999 * gtkutil.c (toplevel): Do not declare Qxft but include
1000 font.h to do so.
1001 * image.c (toplevel): Do not declare Vlibrary_cache because
1002 it's already done in lisp.h.
1003
9fed9729
DA
10042013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1005
1006 * lisp.h (Mouse_HLInfo): Move from here...
1007 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1008 (reset_mouse_highlight): New function.
1009 * msdos.c (dos_set_window_size, IT_update_begin)
1010 (internal_terminal_init):
1011 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1012 (ns_initialize_display_info):
1013 * w32console.c (initialize_w32_display):
1014 * w32term.c (x_update_window_end, x_free_frame_resources)
1015 (w32_initialize_display_info):
1016 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1017 * window.c (Fdelete_other_windows_internal):
1018 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1019 * termchar.h (toplevel):
1020 * xterm.h (toplevel): Include dispextern.h.
1021
f462f075
PE
10222013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 Fix minor problems found by static checking.
1025 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1026 (expect): Avoid nested-if warning.
1027 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1028 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1029 * nsterm.h, nsterm.m (ns_select):
1030 * xgselect.c, xgselect.h (xg_select):
1031 Adjust signature to better match pselect's.
1032 * nsterm.m (ns_select):
1033 Don't set *TIMEOUT, since pselect doesn't.
1034 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1035 diagnostic about assigning const char * to it.
1036 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1037
068f9124
SM
10382013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1039
1040 * lread.c (substitute_object_recurse): Handle hash-tables as well
1041 (bug#15190).
1042
f5adc984
PE
10432013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1044
1fc8eb33
PE
1045 Fix unlikely core dump in init_tty, and simplify terminfo case.
1046 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1047 The old version incorrectly dumped core if malloc returned a
1048 buffer containing only non-NUL bytes.
1049 (init_tty): Do not allocate or free termcap buffers; the
1050 struct does that for us now.
1051 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1052 (struct tty_display_info): Define members termcap_term_buffer and
1053 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1054 use them. Allocate them directly in struct rather than indirectly
1055 via a pointer, to simplify init_tty.
1056
f5adc984
PE
1057 * frame.c (check_minibuf_window): Initialize 'window' properly,
1058 so that Emacs reliably aborts later if 'window' is not initialized.
1059
efec3894
JD
10602013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1061
1062 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1063 of VoidSymbol (Bug#15154).
1064
e1d0341e
DA
10652013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1066
1067 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1068 mouse_face_beg_y and mouse_face_end_y.
1069 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1070 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1071 Adjust users and update comment where appropriate.
1072
bfff6445
MR
10732013-08-26 Martin Rudalics <rudalics@gmx.at>
1074
1075 * frame.c (check_minibuf_window): New function.
068f9124
SM
1076 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1077 Call check_minibuf_window (Bug#15183).
bfff6445 1078
c80016b3
DA
10792013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1080
1081 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1082 because this is the only last cursor data we need to keep and consult.
1083 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1084 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1085 Adjust users.
1086
de396731
DA
10872013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1088
068f9124
SM
1089 Fix recovering from possible decompression error.
1090 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1091 the position where the partially decompressed data ends, and
447218dd 1092 should count how many bytes was produced so far.
de396731
DA
1093 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1094 (unwind_decompress): Really delete partially uncompressed data.
1095 (Fzlib_decompress_region): Take decompressed data size into account.
1096
c76826d9
DA
10972013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 * syntax.c (init_syntax_once): Adjust comment and do an early
1100 initialization of Qchar_table_extra_slots just once...
1101 * casetab.c (init_casetab_once):
1102 * category.c (init_category_once):
1103 * character.c (syms_of_character):
1104 * coding.c (syms_of_coding):
1105 * xdisp.c (syms_of_xdisp): ...and omit it here.
1106
b34454d0
EZ
11072013-08-24 Eli Zaretskii <eliz@gnu.org>
1108
11f20add
EZ
1109 * xdisp.c (get_next_display_element): Don't apply to characters
1110 from a display vector the logic of setting it->end_of_box_run_p
1111 suitable for characters from a buffer. (Bug#15175)
1112
b34454d0
EZ
1113 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1114 to handle directories, rather than '_utime' which doesn't.
1115 (Bug#15176)
1116
6e1b469e
JD
11172013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1118
1119 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1120 or fullscreen (Bug#14627).
1121
9c05bccf
PE
11222013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 System-dependent integer overflow fixes.
1125 * process.c (Fset_process_window_size): Signal an error if
1126 the window size is outside the range supported by the lower level.
1127 * sysdep.c (set_window_size): Return negative on error,
1128 nonnegative on success, rather than -1, 0, 1 on not in system,
1129 failure, success. This is simpler. Caller changed.
1130 (serial_configure): Remove unnecessary initialization of local.
1131 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1132 size fits in unsigned long; this isn't true on some 32-bit hosts.
1133 Avoid buffer overrun if some future version of /proc/meminfo has a
1134 variable name longer than 20 bytes.
1135 (system_process_attributes) [__FreeBSD__]:
1136 Don't assume hw.availpages fits in 'int'.
1137
c365c355
PE
11382013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 Don't let very long directory names overrun the stack.
1141 Fix some related minor problems involving "//", vfork.
1142 * callproc.c (encode_current_directory): New function.
1143 (call_process): Don't append "/"; not needed.
1144 * fileio.c (file_name_as_directory_slop): New constant.
1145 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1146 this can save the caller having to alloca.
1147 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1148 Use SAFE_ALLOCA, not alloca.
1149 (directory_file_name, Fexpand_file_name): Leave leading "//"
1150 alone, since it can be special even on POSIX platforms.
1151 * callproc.c (call_process):
1152 * process.c (Fformat_network_address):
1153 * sysdep.c (sys_subshell):
1154 Use encode_current_directory rather than rolling our own.
1155 (create_process): No need to encode directory; caller does that now.
1156 * process.h (encode_current_directory): New decl.
1157 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1158 Rework to avoid 'goto xyzzy;'.
1159
6c6014d4
EZ
11602013-08-23 Eli Zaretskii <eliz@gnu.org>
1161
1162 * xdisp.c (handle_face_prop): If the default face was remapped use
1163 the remapped face for strings from prefix properties. (Bug#15155)
1164
9997ec56
DA
11652013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1166
1167 Minor cleanup for redisplay interface and few related functions.
1168 * frame.h (enum text_cursor_kinds): Move from here...
1169 * dispextern.h (enum text_cursor_kinds): ...to here.
1170 (toplevel): Drop unnecessary declarations.
1171 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1172 in update_window_end_hook and draw_window_cursor functions.
1173 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1174 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1175 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1176 * xterm.c (x_update_window_end, x_draw_window_cursor):
1177 * xdisp.c (display_and_set_cursor, update_window_cursor)
1178 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1179 enum text_cursor_kinds where appropriate.
1180
7f780da6
DA
11812013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 Redesign redisplay interface to drop updated_row and updated_area.
1184 * dispextern.h (updated_row, updated_area): Remove declaration.
1185 (struct redisplay_interface): Pass glyph row and row area parameters
1186 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1187 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1188 Adjust prototypes.
1189 * dispnew.c (updated_row, updated_area): Remove.
1190 (redraw_overlapped_rows, update_window_line): Adjust user.
1191 (update_marginal_area, update_text_area): Likewise. Pass updated row
1192 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1193 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1194 Adjust users.
1195
26495794
PE
11962013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 * process.c (flush_pending_output): Remove stub.
1199 All uses removed.
1200
4a88129a
PE
12012013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1202
1203 * callproc.c: Fix race that killed background processes (Bug#15144).
1204 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1205 Record deleted process-id in critical section, not afterwards.
1206 Don't mistakenly kill process created by a call-process invocation
1207 that discards output and does not wait.
1208
0c5307b0
DA
12092013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1210
1211 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1212 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1213 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1214 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1215 to shut up compiler in mark_object.
1216 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1217
0d7c1e66
PE
12182013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1221 We can't portably rely on PTY_OPEN doing that, even if
1222 it calls posix_openpt with O_CLOEXEC.
1223
3f246b65
KH
12242013-08-20 Kenichi Handa <handa@gnu.org>
1225
1226 * character.c (string_char): Improve commentary.
1227
8c2f38aa
PE
12282013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1231 (struct animation_cache): Make signature a flexible array member.
1232 All uses changed. This is a tad slower but may insulate us better
1233 from future changes to ImageMagick.
1234
bb566cea
PE
12352013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1236
1237 * image.c: Shrink memory needed for animation cache.
1238 (SIGNATURE_DIGESTSIZE): New constant.
1239 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1240 (imagemagick_create_cache): Copy the signature. This saves
1241 several KB of memory that ImageMagick wastes per signature.
1242 Don't bother updating the update_time, as the caller does that now.
1243 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1244 it's a fixed size struct member now.
1245 (imagemagick_get_animation_cache): Always destroy the signature,
1246 as it's now imagemagick_create_cache's responsibility to copy it.
1247 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1248 and use memcmp rather than strcmp.
1249 eassert that ImageMagick returns a signature of the specified length.
1250
6da26928
LMI
12512013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1252
1253 * image.c (imagemagick_get_animation_cache): Don't segfault on
1254 each invocation.
453f4022
LMI
1255 (imagemagick_get_animation_cache): Revert to previous definition
1256 so that it actually works. But keep the memory leak fix.
1257 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1258
22490125
PE
12592013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1260
d0139df5
PE
1261 * image.c: Fix animation cache signature memory leak.
1262 Fix some other minor performance problems while we're at it.
1263 (imagemagick_create_cache): Clear just the members that
1264 need clearing. Don't set update_time, as caller does that now.
1265 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1266 Simplify by using pointer-to-pointer instead of a prev pointer.
1267 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1268 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1269 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1270 it's already a copy. Free the signature probe unless it's cached.
1271
22490125
PE
1272 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1273 This was introduced by my 2013-08-12 fix for Bug#15035.
1274
deb31e75
DA
12752013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1276
1277 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1278 (imagemagick_prune_animation_cache): Now static.
1279
319a4d03
LMI
12802013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1281
1282 * image.c (imagemagick_get_animation_cache): Don't segfault when
1283 pruning all entries.
1284
f747d82e
KB
12852013-08-18 Ken Brown <kbrown@cornell.edu>
1286
1287 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1288 static heap if ENABLE_CHECKING is defined.
1289 (max_bss_sbrk_ptr): New variable.
1290 (bss_sbrk): Use it.
1291 (report_sheap_usage): Report maximum static heap usage instead of
1292 ending static heap usage.
1293
d2c28fab
EZ
12942013-08-17 Eli Zaretskii <eliz@gnu.org>
1295
1296 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1297 of zlib_initialized according to the results of calling
1298 init_zlib_functions.
1299
274ff63f
LMI
13002013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1301
1302 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1303 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1304 (imagemagick_load_image): Remove the ping_wand code, which only
1305 apparently saved time on invalid animated images, and slowed down
1306 everything else. Optimise for the common case.
274ff63f 1307
2bede2ed
XF
13082013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1309
70ff8240
XF
1310 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1311
de179a3e
XF
1312 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1313
2bede2ed
XF
1314 * marker.c (set_marker): Remove documentation of undefined behavior.
1315
703dbeba
LMI
13162013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1317
1318 * image.c (imagemagick_compute_animated_image): Animate correctly
1319 when sub-images are smaller than the main image.
1d18b1e6
LMI
1320 (imagemagick_compute_animated_image): Setting the iterator row to
1321 zero is apparently not allowed.
79670014
LMI
1322 (imagemagick_compute_animated_image): Allow images that say they
1323 have sub-images that are bigger than the main image, but just crop
1324 them.
703dbeba 1325
63216c5e
JD
13262013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1327
1328 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1329
a5b5f73f
LMI
13302013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1331
1332 * image.c (imagemagick_compute_animated_image): Respect the GIF
1333 disposal methods.
1334
0fe73012
KB
13352013-08-15 Ken Brown <kbrown@cornell.edu>
1336
1337 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1338 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1339 needed.
1340
691a357f
PE
13412013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 Fix minor problems found by static checking.
1344 * frame.c (delete_frame):
1345 * xdisp.c (next_element_from_display_vector):
1346 Avoid uninitialized local.
1347 * image.c (imagemagick_compute_animated_image): Port to C89.
1348 Prefer usual GNU indentation style for loops.
1349 Be more careful about bizarrely large sizes, by using ptrdiff_t
1350 instead of int.
1351
42fe2e88
DA
13522013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1353
1354 Fix infinite frame selection loop (Bug#15025).
1355 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1356
d39a3da6
EZ
13572013-08-15 Eli Zaretskii <eliz@gnu.org>
1358
068f9124
SM
1359 * xdisp.c (compute_window_start_on_continuation_line):
1360 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1361 to make sure we end up setting the window start at the leftmost
1362 visible character of the display line. This avoids funky
1363 horizontal shifting because the window start is not kept on the
1364 same position. (Bug#15090)
05426239
EZ
1365 (next_element_from_display_vector): Support 'box' face attribute
1366 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1367
6e856b69
LMI
13682013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1369
1370 * image.c (imagemagick_compute_animated_image): Implement animated
1371 images (bug#14700).
995be755
LMI
1372 (imagemagick_compute_animated_image): Fix some compilation
1373 warnings. Implement a very simple cache to make the animation
1374 usable at all, but it should be replaced with a per-image cache.
6e856b69 1375
d5a1acfa
DA
13762013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1377
1378 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1379 to do `for' loops over alist values.
1380 * buffer.h (FOR_EACH_BUFFER):
1381 * process.c (FOR_EACH_PROCESS): Use it.
1382 (handle_child_signal, status_notify, Fget_buffer_process)
1383 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1384
9c253307
DA
13852013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1386
1387 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1388 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1389 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1390 to xzalloc and so avoid redundant call to memset.
1391 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1392 members because it is allocated with xzalloc and so already zeroed.
1393
05e64f9f
KB
13942013-08-14 Ken Brown <kbrown@cornell.edu>
1395
1396 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1397 (Bug#15094).
1398
5b71542d
DA
13992013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1400
1401 Utility function and macro to copy Lisp string to C string.
1402 * lisp.h (xlispstrdupa): New macro.
1403 (xlispstrdup): New prototype.
1404 * alloc.c (xlispstrdup): New function.
1405 * callint.c (Fcall_interactively):
1406 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1407 (Fsubstitute_in_file_name):
1408 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1409 * image.c (x_create_bitmap_from_file):
1410 * w32term.c (w32_term_init):
1411 * xterm.c (x_term_init): Use xlispstrdup.
1412
71530c97
LMI
14132013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1414
4ce82fb8
LMI
1415 * image.c (imagemagick_load_image): Make animated pictures work.
1416 There's still some problems with background color settings, though
1417 (bug#14700).
1418
71530c97
LMI
1419 * decompress.c (unwind_decompress): Always restore point.
1420
7510a061
XF
14212013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1422
1423 * marker.c (set_marker): Reformat documentation.
1424
01c3051f
PE
14252013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1426
aab1fcdf
PE
1427 * xdisp.c (cursor_type_changed): Now static.
1428
01c3051f
PE
1429 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1430 Use changed. This avoids the need to call xmalloc and for the
1431 caller to call xfree, and avoids memory leaks in some situations.
1432
2084152a
DA
14332013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1434
1435 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1436 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1437 (redisplay_window): If window_end_valid is cleared due to non-zero
1438 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1439 so do not call to try_cursor_movement for that window.
2084152a 1440
02455cb6
DA
14412013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1442
1443 * window.h (struct window): Convert window_end_pos and
1444 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1445 (wset_window_end_pos, wset_window_end_vpos): Remove.
1446 * dispnew.c (adjust_glyph_matrix):
1447 * window.c (Fwindow_end, replace_window, set_window_buffer)
1448 (make_window):
1449 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1450 (set_vertical_scroll_bar, redisplay_window, try_window)
1451 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1452 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1453 (note_mouse_highlight): Adjust users.
1454 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1455 Add comment.
1456
da5707e8
DA
14572013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1458
1459 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1460 * image.c (imagemagick_filename_hint): Use `const char *' and
1461 prefer SSDATA to SDATA to avoid warnings.
1462
25554267
DA
14632013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1464
1465 Cleanup window fringes, margins and scroll bars adjustments.
1466 * window.c (set_window_fringes, set_window_margins)
1467 (set_window_scroll_bars, apply_window_adjustment): New functions.
1468 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1469 (Fset_window_scroll_bars): Use them.
1470
38a2c910
DA
14712013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1472
1473 * window.h (struct window): Convert scroll_bar_width
1474 from Lisp_Object to integer. Adjust comment.
1475 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1476 Adjust users.
1477 * window.c (wset_scroll_bar_width): Remove.
1478 (make_window): Initialize scroll_bar_width.
1479 (Fsplit_window_internal): Use direct assignment.
1480 (Fset_window_configuration, save_window_save):
1481 Convert Lisp_Object to integer and back where appropriate.
1482 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1483 bar was actually changed, and mention this in docstring.
1484
2d065031
PE
14852013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 * decompress.c: Minor simplifications.
1488 (Fzlib_decompress_region): Don't bother verifying
1489 that avail_out <= UINT_MAX, as that was confusing.
1490 Mention the restriction in a comment instead.
1491 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1492
a5bd5abb
JD
14932013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1494
1495 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1496 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1497
66e7901a
LMI
14982013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1499
1500 * image.c (imagemagick_filename_hint): Check for errors in the
1501 alist structure.
1502
2fa611b7
EZ
15032013-08-13 Eli Zaretskii <eliz@gnu.org>
1504
1505 * window.c (Fwindow_margins): Return nil when there's no marginal
1506 area, as per the documented API.
1507
1508 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1509 Fmake_vector, as scroll bar's struct members are not all Lisp
1510 objects now. This avoids crashes in GC.
1511
1512 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1513 bool, so its address could be taken.
1514
8259030d
LMI
15152013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1516
1517 * image.c (imagemagick_filename_hint): New function to possibly
1518 apply `image-content-type-suffixes'.
1519 (imagemagick_load_image): Use it.
1520
866c710e
EZ
15212013-08-13 Eli Zaretskii <eliz@gnu.org>
1522
1523 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1524 if loading zlib failed.
1525
f10490f0
JD
15262013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1527
96311be7
JD
1528 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1529 2013-08-13 checkin below. Change bool to BOOL, rule is:
1530 All Obj-C code uses BOOL, except for interfaces callable from C.
1531
f10490f0
JD
1532 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1533
c8ae93b0
DA
15342013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1537 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1538 bool instead of BOOL.
1539 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1540 from Lisp_Object to bitfield. Adjust comment.
1541 * w32term.c (x_scroll_bar_create): Adjust user.
1542 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1543 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1544 Use bool for boolean.
1545 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1546 to `unsigned int' when defining a bitfield.
1547
53b64418
PE
15482013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1549
1550 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1551
eeaf9bf3
DA
15522013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1553
1554 * window.h (struct window): Convert left_margin_cols and
1555 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1556 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1557 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1558 Adjust users.
1559 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1560 Adjust comment.
1561 (showing_window_margins_p, update_window_line, update_frame_1):
1562 * fringe.c (draw_fringe_bitmap_1):
1563 * xdisp.c (window_box_width): Adjust users.
1564 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1565 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1566 Use direct assignment.
1567 (Fset_window_configuration, save_window_save, Fwindow_margins):
1568 Convert Lisp_Object to integer and back where appropriate.
1569 (Fset_window_margins): Adjust user. Return t if any margin
1570 was actually changed, and mention this in docstring.
1571
956720af
XF
15722013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1573
f73f4ce6 1574 * syntax.c (forward_word):
956720af
XF
1575 * cmds.c (forward_char, backward_char): Mention the optional argument.
1576
9e37ee3b
DA
15772013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1578
1579 * window.h (struct window): Convert left_fringe_width
1580 and right_fringe_width from Lisp_Objects to integers.
1581 Adjust comment.
1582 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1583 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1584 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1585 Remove.
1586 (make_window): Initialize new integer fields to -1.
1587 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1588 (Fset_window_configuration, save_window_save):
1589 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1590 (Fset_window_fringes): Adjust user. Return t if any fringe
1591 was actually changed, and mention this in docstring.
1592
e4375ca7
DA
15932013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1594
1595 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1596 * nsfns.m (x_set_cursor_type):
1597 * w32fns.c (x_set_cursor_type):
1598 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1599 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1600
a45543bc
DA
16012013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1602
1603 * font.c (clear_font_cache): New function, stripped from...
1604 (Fclear_font_cache): ...here, which now uses the function
1605 above. Adjust comment.
1606 * font.h (clear_font_cache): Add prototype.
1607 * xfaces.c (clear_face_cache): Use clear_font_cache.
1608
ae966a86
DA
16092013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1610
1611 * window.c (Fset_window_start): Compare `w', not `window' because
1612 `w' might not be equal to `window' after call to decode_live_window.
1613
297a545b
PE
16142013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1617 This fixes a problem introduced by the Bug#15035 patch
1618 when using GPG. Reported by Herbert J. Skuhra.
1619
aa942e2b
EZ
16202013-08-12 Eli Zaretskii <eliz@gnu.org>
1621
1622 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1623 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1624 not yet initialized.
1625
7699d09e
LMI
16262013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1627
1628 * decompress.c (Fzlib_decompress_region): Support zlib
1629 decompression, too, and rename.
1630
1d238bc7
PE
16312013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 Minor zlib configuration tweaks.
1634 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1635 Don't assume presence of fn_inflateInit2_ zlib internal function.
1636
8a44a184
LMI
16372013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1638
1639 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1640 include the zlib prefix.
1641
594a4307
EZ
16422013-08-12 Eli Zaretskii <eliz@gnu.org>
1643
1644 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1645 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1646 define static variables that are pointers to zlib functions to be
1647 dynamically loaded.
1648 (init_zlib_functions) [WINDOWSNT]: New function.
1649 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1650 New macros.
1651 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1652 macros instead of invoking the zlib functions directly.
068f9124
SM
1653 (syms_of_decompress): DEFSYM Qzlib_dll.
1654 Staticpro Szlib_available_p.
594a4307 1655
d2e113bc
DA
16562013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1657
1658 Avoid looping over all frame windows to freeze and unfreeze.
1659 * window.h (struct window): Drop frozen_window_start_p.
1660 (freeze_window_starts): Drop prototype.
1661 * frame.h (struct frame): New frozen_window_starts flag.
1662 (FRAME_WINDOWS_FROZEN): New macro.
1663 * window.c (freeze_window_start, freeze_window_starts):
1664 Remove.
1665 (select_window, replace_window): Adjust users.
1666 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1667 (window_frozen_p): New function.
1668 (redisplay_window): Use it.
1669
94fcd171
PE
16702013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 Fix some fd issues when running subprocesses (Bug#15035).
1673 Fix bugs that can leak files or file descriptors on errors.
1674 Don't unlink open temp files, as that's hard for users to diagnose
1675 when things go awry (e.g., temp disk exhausted).
1676 Don't bother to lock temp files. Check for invalid recursion.
1677 * callproc.c (synch_process_fd): Remove. All uses removed.
1678 (synch_process_tempfile): New var or macro.
1679 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1680 New constants.
1681 (record_kill_process): New arg, the temp name. All callers changed.
1682 (delete_temp_file): Now just a simple wrapper around unlink.
1683 (call_process_kill): New arg, the call_process_fd array.
1684 Close them all. Clear synch_process_pid. Remove the temp file,
1685 or arrange for it to be removed.
1686 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1687 that's been moved to synch_process_tempfile. Caller changed.
1688 Do not remove the tempfile; that's now call_process_kill's
1689 responsibility.
1690 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1691 call_process_kill; the caller now does that.
1692 (call_process_cleanup): Do not close the process fd; that's now
1693 call_process_kill's responsibility.
1694 (Fcall_process): Implement via new function call_process, which
1695 has most of the old body of Fcall_process, but with a different API.
1696 (call_process): New function that does not open or close filefd if
1697 it is nonnegative. Record which fds need to be closed, and let
1698 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1699 Signal an error if invoked recursively (could be done via a hook).
1700 Simplify creation of the tempfile in the MSDOS case.
1701 Don't create the output file until after checking for the executable.
1702 Report any failure to open /dev/null.
1703 Don't open /dev/null for writing twice; once is enough.
1704 Don't create pipe if all output is being discarded or sent to file.
1705 Don't worry about setting up the coding system or reading from the
1706 pipe if all output is being discarded.
1707 Hoist fd_error local into top level, to lessen block nesting.
1708 Don't record deleted pid here; now done by Fcall_process_region.
1709 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1710 and note its success in synch_process_tempfile.
1711 Do not leak resources when child_setup fails.
1712 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1713 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1714 (create_temp_file): Now returns open fd, with an additional
1715 Lisp_Object * argument to return the name. All callers changed.
1716 Do not close the file; rewind it instead, and leave it open for
1717 the caller. Do not lock the temp file. Unwind-protect the file
1718 and the file-descriptor.
1719 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1720 If an asynchrounous process, record it here, not in call_process.
1721 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1722 * eval.c (set_unwind_protect): New function.
1723 * fileio.c (write_region): New function, generalized from the
1724 old Fwrite_region. Do not lock temp files.
1725 (Fwrite_region): Use it.
1726 * lisp.h (set_unwind_protect, write_region): New decls.
1727 * process.c: Include <verify.h>.
1728 (make_process): Mark fds as initially closed.
1729 (deleted_pid_list): Now a list of pid-filename pairs.
1730 All uses changed.
1731 (close_process_fd): New function.
1732 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1733 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1734 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1735 (create_process, create_pty, Fmake_serial_process)
1736 (server_accept_connection): Record which fds need to be closed,
1737 and let deactivate_process close them.
1738 (Fmake_network_process): Do not discard the unwind-protect
1739 until it's safe to do so.
1740 (deactivate_process): Close the fds opened by create_process etc.
1741 (Fprocess_send_eof): Adjust to new way of recording open fds.
1742 Report an error if /dev/null can't be opened, instead of aborting.
1743 * process.h (PROCESS_OPEN_FDS): New constant.
1744 (struct Lisp_Process): New member open_fds.
1745 (record_kill_process, record_deleted_pid): Adjust signatures.
1746 (record_deleted_pid): Move decl here ...
1747 * syswait.h (record_deleted_pid): ... from here.
1748
d0e615c3
PE
17492013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * decompress.c: Fix bugs with large buffers and weird inputs.
1752 Tune a bit. Reindent as per usual Emacs style.
1753 (BUFFER_SIZE): Remove.
1754 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1755 more than UINT_MAX bytes. Decompress into the gap instead of into
1756 an auto buffer, as this should avoid copying. Return nil if
1757 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1758 set immediate_quit; we shouldn't trust zlib code that much.
1759
313546eb
LMI
17602013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1761
99a32242
LMI
1762 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1763 errors, and really move the gap to where we want it.
1764
313546eb
LMI
1765 * lisp.h: Include decompress.c support.
1766
1767 * emacs.c (main): Include decompress.c support.
1768
1769 * Makefile.in: Include -lz if present.
1770
d2d699ac
JD
17712013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1772
f90e3ebd
JD
1773 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1774 (initWithTitle:): Initialize frame to 0.
1775 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1776 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1777 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1778
1779 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1780 fillWithWidgetValue:frame:
1781
423d3b3f
JD
1782 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1783 remove memory leak warnings.
1784
d2d699ac
JD
1785 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1786 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1787 menu_pending_title.
1788
1789 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1790 (x_activate_menubar): Update the whole menu.
1791 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1792 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1793 current event is not NSSystemDefined (Bug#15001).
1794 Call ns_check_menu_open only if trackingMenu is 2.
1795 (menuDidClose:): New method, decrease trackingMenu.
1796 (fillWithWidgetValue:setDelegate:): New method.
1797 (fillWithWidgetValue:): Call the above.
1798
1799 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1800
7d652d97
PE
18012013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 Omit some unnecessary casts.
1804 Many of these go back to the old pre-C89 days, when they may have
1805 been needed, but we've been assuming C89 or later for a while now.
1806 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1807 (live_float_p, live_misc_p, live_vector_p):
1808 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1809 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1810 (defvar_per_buffer):
1811 * callint.c (Fcall_interactively):
1812 * doc.c (Fsubstitute_command_keys):
1813 * filelock.c (get_boot_time):
1814 * frame.c (xrdb_get_resource):
1815 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1816 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1817 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1818 (menuitem_highlight_callback, menu_destroy_callback)
1819 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1820 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1821 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1822 (xg_tool_bar_help_callback, tb_size_cb):
1823 * image.c (xpm_alloc_color, png_read_from_memory)
1824 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1825 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1826 (syms_of_image):
1827 * keymap.c (describe_map):
1828 * nsfns.m (Fns_display_monitor_attributes_list):
1829 * nsmenu.m (process_dialog:):
1830 * nsterm.m (hold_event):
1831 * process.c (wait_reading_process_output):
1832 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1833 * scroll.c (do_direct_scrolling, scrolling_1):
1834 * termcap.c (tgetent):
1835 * window.c (check_window_containing, add_window_to_list)
1836 (freeze_window_starts):
1837 * xdisp.c (compare_overlay_entries, vmessage):
1838 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1839 (x_get_monitor_attributes_xrandr)
1840 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1841 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1842 * xfont.c (xfont_match, xfont_open):
1843 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1844 (menubar_selection_callback, menu_position_func)
1845 (popup_selection_callback, create_and_show_popup_menu)
1846 (dialog_selection_callback, create_and_show_dialog):
1847 * xrdb.c (x_get_string_resource):
1848 (main) [TESTRM]:
1849 * xsmfns.c (x_session_check_input):
1850 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1851 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1852 (xaw_jump_callback, xaw_scroll_callback):
1853 Omit unnecessary casts.
1854
9acc1074
PE
18552013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1856
1857 Minor string-length refactoring.
1858 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1859 * frame.c (make_monitor_attribute_list):
1860 Prefer build_string to strlen + make_string.
1861
361c0eb8
JD
18622013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1863
1864 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1865 don't check minor_code (Bug#14417).
1866
14ba0822
EZ
18672013-08-09 Eli Zaretskii <eliz@gnu.org>
1868
1869 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1870 vertical positions instead. This avoids calling MATRIX_ROW with
1871 row numbers that are possibly beyond valid limits. (Bug#15064)
1872
309f24d1
DA
18732013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1874
1875 Use xstrdup and build_unibyte_string where applicable.
1876 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1877 * xfns.c (x_window):
1878 * xrdb.c (x_get_customization_string):
1879 * xterm.c (xim_initialize):
1880 * w32fns.c (w32_window): Use xstrdup.
1881 (w32_display_monitor_attributes_list):
1882 * emacs.c (init_cmdargs):
1883 * keyboard.c (PUSH_C_STR):
1884 * nsfont.m (nsfont_open):
1885 * sysdep.c (system_process_attributes):
1886 * w32.c (system_process_attributes):
1887 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1888
55902276
EZ
18892013-08-09 Eli Zaretskii <eliz@gnu.org>
1890
1891 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1892 variables of these types so that GDB would know about them, as aid
1893 for debugging fatal exceptions. (Bug#15024) See also
1894 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1895 discussions.
1896
10bf7f5a
JD
18972013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1898
1899 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1900 larger than the NSWindow (Bug#14934).
1901
65620264
DA
19022013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1903
1904 Redesign redisplay interface to drop global variable updated_window.
1905 Always pass currently updated window as a parameter to update routines.
1906 * dispextern.h (updated_window): Remove declaration.
1907 (struct redisplay_interface): Pass window parameter to
1908 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1909 and after_update_window_hook.
1910 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1911 Adjust prototypes.
1912 * dispnew.c (updated_window): Remove.
1913 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1914 (update_window_line): Adjust to match redisplay interface changes.
1915 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1916 (ns_scroll_run, ns_after_update_window_line):
1917 * w32term.c (x_update_window_begin, x_update_window_end)
1918 (x_after_update_window_line, x_scroll_run):
1919 * xterm.c (x_update_window_begin, x_update_window_end)
1920 (x_after_update_window_line, x_scroll_run):
1921 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1922 Likewise. Adjust comments where appropriate.
1923 (x_cursor_to): Simplify because this is always called during window
1924 update (but install debugging check anyway).
1925 (expose_window): Check must_be_updated_p flag to see whether this
1926 function is called during window update.
1927
628fdc56
DA
19282013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1929
1930 Do not reset window modification event counters excessively.
1931 These leftovers and poor man's tricky methods to catch extra
1932 redisplay's attention are no longer needed.
1933 * frame.c (set_menu_bar_lines_1):
1934 * minibuf.c (read_minibuf_unwind):
1935 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1936 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1937 (window_scroll_line_based, Fset_window_configuration):
1938 * xdisp.c (redisplay_window): Do not reset last_modified and
1939 last_overlay_modified counters.
1940
8fd9c92e
JD
19412013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1942
1943 * xselect.c (x_send_client_event): Set send_event and serial, memset
1944 data.l as it might be bigger than data.b. Use 24 bit mask to
1945 XSendEvent (Bug#15034).
1946
0ee18172
EZ
19472013-08-07 Eli Zaretskii <eliz@gnu.org>
1948
1949 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1950 for TTY frames that are not the top frame on their console.
1951 (Bug#14616)
1952
16ddd1a6
MR
19532013-08-07 Martin Rudalics <rudalics@gmx.at>
1954
1955 * w32term.c (w32fullscreen_hook): Really maximize frame when
1956 asked for (Bug#14841).
1957
d2a95ffb
DA
19582013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1959
1960 Prefer selected_window to Fselected_window, likewise for frames.
1961 * buffer.c (Fbuffer_swap_text):
1962 * data.c (Fvariable_binding_locus):
1963 * window.c (run_window_configuration_change_hook): Adjust users.
1964 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1965 Use decode_live_frame.
1966
170da1ec
DA
19672013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1968
1969 Be more careful if selected window shows the buffer other than current,
1970 use window_outdated only if this is not so. This change should also
1971 address some weird issues discussed in Bug#13012.
1972 * window.h (window_outdated): New prototype.
1973 * window.c (window_outdated): Now here. Convert from static and
1974 always assume window's buffer.
1975 (Fwindow_end, Fwindow_line_height): Use it.
1976 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1977 and always assume window's buffer.
1978 (redisplay_window): Adjust user.
e5eefe9b 1979 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1980 check whether mode line should be updated only if selected window
1981 shows current buffer.
1982 (run_window_scroll_functions): Use eassert for debugging check.
1983 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1984
56b5d5b1
DA
19852013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1986
1987 * window.c (window_scroll, window_scroll_pixel_based)
1988 (window_scroll_line_based): Use bool for booleans.
1989
2878ba7e
PE
19902013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 * process.c: Fix minor off-by-one issues in descriptor counts.
1993 This shouldn't fix any real bugs, but it cleans up the code a bit.
1994 (max_process_desc, max_input_desc): -1, not 0, means none.
1995 All uses changed.
1996 (delete_input_desc): New function.
1997 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1998 (deactivate_process): Scan backwards when recomuting max_process_desc;
1999 that should be faster.
2000 (init_process_emacs): Initialize max_input_desc.
2001
e30b79c1
DA
20022013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2003
2004 Use region cache to speedup bidi_find_paragraph_start.
2005 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2006 Rename cache_long_line_scans to cache_long_scans.
2007 * buffer.c (bset_cache_long_line_scans): Rename to
2008 bset_cache_long_scans.
2009 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2010 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2011 into account.
2012 (syms_of_buffer): Rename cache-long-line-scans to
2013 cache-long-scans. Adjust docstring.
2014 * search.c (newline_cache_on_off):
2015 * indent.c (width_run_cache_on_off): Adjust users.
2016 * bidi.c (bidi_paragraph_cache_on_off): New function.
2017 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2018 * insdel.c (prepare_to_modify_buffer):
2019 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2020
00012b86
DA
20212013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2022
2023 Invalidate region caches only if buffer text is going to be changed.
2024 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2025 (modify_text): ...new prototype.
2026 (prepare_to_modify_buffer_1): New prototype.
2027 * textprop.c (modify_region): Rename to...
2028 (modify_text_properties): ...new function.
2029 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2030 (Fremove_list_of_text_properties): Adjust users.
2031 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2032 (modify_text): ...new function.
2033 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2034 (prepare_to_modify_buffer_1): ...new function.
2035 * casefiddle.c (casify_region):
2036 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2037 (Ftranspose_regions): Use modify_text.
2038
dc6c0eda
SM
20392013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2040
2041 * lisp.mk (lisp): Add nadvice.elc.
2042
8f3a2c26
DA
20432013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2044
2045 New macro to iterate over live buffers similar to frames.
2046 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2047 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2048 Declare buffer-related variables here to offload lisp.h.
2049 * buffer.c (Vbuffer_alist): Adjust comment.
2050 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2051 (other_buffer_safely):
2052 * data.c (store_symval_forwarding):
2053 * dispnew.c (Fframe_or_buffer_changed_p):
2054 * fileio.c (Fdo_auto_save):
2055 * filelock.c (unlock_all_files):
2056 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2057
e0fdb694
PE
20582013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2061 * callproc.c (create_temp_file):
2062 * filelock.c (create_lock_file):
2063 Assume mkostemp, since it's now provided by Gnulib.
2064
63f5c6c2
EZ
20652013-08-04 Eli Zaretskii <eliz@gnu.org>
2066
2067 * w32.c (mkostemp): New function.
2068 (mktemp): Remove, no longer used. Most of the code reused in
2069 mkostemp. (Bug#15015)
484ab239 2070 (mktemp): Don't undef.
63f5c6c2 2071
f0b79313
DA
20722013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2073
2074 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2075 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2076 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2077 (free_glyph_pool, check_glyph_memory): Likewise for
2078 all users. Adjust comments where appropriate.
2079
98f638d6
PE
20802013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 * composite.h: Minor fixups.
2083 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2084 to fix a misspelling, and change it to an inline function while
2085 we're at it (it need not be a macro). All uses changed.
2086 (composition_method, composition_valid_p):
2087 Rewrite to avoid assignments in if-conditions.
2088
75c59fb3
DA
20892013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2090
2091 Do not use global Lisp_Object in composition macros.
2092 * composite.h (composition_temp): Remove declaration.
2093 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2094 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2095 (compose_region): Remove the leftover.
75c59fb3
DA
2096 * composite.c (composition_temp): Remove.
2097 (run_composition_function, update_compositions)
2098 (composition_compute_stop_pos, composition_adjust_point)
2099 (Ffind_composition_internal):
2100 * coding.c (handle_composition_annotation):
2101 * xdisp.c (handle_composition_prop, check_point_in_composition):
2102 Related users changed.
2103
a10c8269
DA
21042013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2105
2106 Drop FRAME_PTR typedef.
2107 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2108 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2109 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2110 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2111 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2112 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2113 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2114 All related users changed.
2115
a104f656
SM
21162013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2117
2118 * eval.c (default_toplevel_binding): New function.
2119 (Fdefvar): Use it.
2120 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2121 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2122 (syms_of_eval): Export them.
2123 * data.c (Fdefault_value): Micro cleanup.
2124 * term.c (init_tty): Use "false".
2125
4b5c9326
DA
21262013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2127
2128 Fix X GC leak in GTK and raw (no toolkit) X ports.
2129 * xterm.c (x_free_frame_resources): If white and black relief
2130 GCs are allocated, always free them here.
2131 * xfns.c (x_make_gc): Omit redundant initialization.
2132 * widget.c (create_frame_gcs): Remove the leftover.
2133 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2134 in x_free_frame_resources.
2135
b19aa636
JD
21362013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2137
2138 * nsterm.m (windowWillResize:toSize:): Only change title if
2139 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2140 modifying it.
2141 (viewDidEndLiveResize): New method.
2142
2143 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2144 inside NS_IMPL_COCOA.
2145
af1f7e06
DA
21462013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2147
2148 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2149 Do not check whether undo is enabled because record_insert and
2150 record_delete does that themselves.
2151
65b02bb9
DA
21522013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2153
2154 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2155 member which is not really used any more.
2156 (FRAME_XIC_BASE_FONTNAME): Remove.
2157 * xfns.c (xic_free_fontset): Adjust user.
2158 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2159 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2160 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2161 (xdialog_show): Use eassert for debugging check.
7ee0f047 2162 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2163
6318cde0
PE
21642013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 * fileio.c, fns.c (merge): Move extern decl from here ...
2167 * lisp.h (merge): ... to here.
2168
6c1a09ba
DA
21692013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 Fix last font-related change.
2172 * w32font.h (w32font_list_internal, w32font_match_internal):
2173 Fix prototype.
2174 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2175 (uniscribe_list_family): Adjust to match font API change.
2176 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2177 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2178
f8c20208
DA
21792013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2180
2181 * frame.h (FRAME_MOUSE_UPDATE):
2182 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2183 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2184
fdb396e2
DA
21852013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2186
2187 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2188 * font.h (struct font_driver): Change list, match, and list_family
2189 functions to accept struct frame * as first arg.
068f9124
SM
2190 * font.c (font_score, font_compare, font_sort_entities):
2191 Remove prototypes.
fdb396e2
DA
2192 (font_sort_entities, font_list_entities, font_select_entity):
2193 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2194 match font API change.
2195 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2196 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2197 * ftxfont.c (ftxfont_list, ftxfont_match):
2198 * xftfont.c (xftfont_list, xftfont_match):
2199 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2200 * w32font.c (w32font_list, w32font_match, w32font_list):
2201 (w32font_list_internal, w32_font_match_internal): Likewise.
2202 * xfaces.c (Fx_family_fonts): Adjust user.
2203
52b8a085
DA
22042013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2205
2206 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2207 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2208 only if HAVE_X_WINDOWS is in use.
2209 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2210 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2211 * w32term.c (x_wm_set_icon_position): Likewise.
2212 * w32fns.c (x_icon): Adjust user.
2213
c791c18e
DA
22142013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2215
2216 * xterm.c (last_mouse_press_frame): Remove the
2217 leftover which is not really used any more.
2218 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2219 (x_flush): Call XFlush once per each X display, not frame.
2220 This is better because this code always unconditionally skips
2221 non-X frames in Vframe_list and issues the only XFlush if we
2222 have more than one X frame on the same X display.
2f935d86
DA
2223 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2224 Use bool for booleans.
2225 (x_draw_glyph_string_background, cvt_string_to_pixel):
2226 (cvt_pixel_dtor): Drop unnecessary prototypes.
2227 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2228
f435830e
DA
22292013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2230
2231 Drop unnecessary functions that deals with frame pixel size.
2232 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2233 (x_pixel_height): Drop prototypes.
2234 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2235 (x_pixel_height): Drop implementations.
2236 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2237 which should be always valid for window frame.
2238 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2239 * w32menu.c (Fx_popup_dialog):
2240 * xmenu.c (Fx_popup_dialog): Likewise for both.
2241
84231434
DA
22422013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2243
2244 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2245 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2246 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2247 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2248 and mention nil frame in docstring.
84231434 2249
959067a1
DA
22502013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2251
2252 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2253 (x_figure_window_size): Likewise. Adjust to return long.
2254 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2255 (toplevel): Move Qterminal_live_p to...
2256 * terminal.c (toplevel): ...here, make it static, and...
2257 (syms_of_terminal): ...DEFSYM here.
2258 * frame.h (Qterminal_live_p): Remove declaration.
2259 (make_frame, x_figure_window_size): Adjust prototype.
2260 * nsfns.m (Fx_create_frame): Use long for window flags.
2261
f4b169ce
PE
22622013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2263
2264 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2265 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2266 Do not assume that emacs_close (INT_MAX) is a no-op.
2267
bee6a2c7
DA
22682013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2269
2270 * xfaces.c (make_face_cache): For struct face_cache, prefer
2271 xmalloc to xzalloc and so avoid redundant call to memset.
2272 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2273
d7e6881a
DA
22742013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2275
2276 * fringe.c (draw_window_fringes, update_window_fringes)
2277 (compute_fringe_widths):
2278 * w32term.c (x_draw_glyph_string):
2279 * window.c (candidate_window_p, Frecenter):
2280 * xfaces.c (realize_basic_faces, realize_default_face)
2281 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2282 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2283 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2284 * xmenu.c (Fx_menu_bar_open_internal):
2285 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2286 * xsettings.c (xft_settings_event):
2287 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2288 Use bool for booleans. Adjust style and comments where
2289 appropriate.
2290 * dispextern.h (draw_window_fringes, update_window_fringes)
2291 (compute_fringe_widths):
2292 * xterm.h (x_had_errors_p): Adjust prototype.
2293
ec3058af
DA
22942013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2295
2296 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2297 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2298
218e0637
DA
22992013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2300
2301 * fns.c (toplevel): Remove comment before Fsafe_length because
2302 it checks for QUIT.
2303
e560aba9
PE
23042013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2307
2e5ce5de
EZ
23082013-07-28 Eli Zaretskii <eliz@gnu.org>
2309
2310 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2311 frame which got the message is still alive, before dereferencing
2312 its pointer. (Bug#14970)
2313
2314 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2315 be a live window, before using it as such. (Bug#14970)
2316
e95da6d3
EZ
23172013-07-27 Eli Zaretskii <eliz@gnu.org>
2318
2319 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2320 w32_detect_focus_change instead of doing part of its job by hand.
2321 This fixes the problem whereby FOCUS_OUT events were not sent to
2322 the event queue.
2323
a8f93651
EZ
23242013-07-26 Eli Zaretskii <eliz@gnu.org>
2325
fec92060
EZ
2326 * process.c (Fprocess_list): Doc fix.
2327
a8f93651
EZ
2328 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2329 being re-exposed only if it didn't ask to become visible.
2330 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2331 was previously iconified. (Bug#14841)
2332 (x_iconify_frame): Mark the frame iconified.
2333
d5a7a9d9
PE
23342013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2335
2336 Fix minor problems found by static checking.
2337 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2338 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2339
56ea7291
SM
23402013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2341
2342 * eval.c (set_specpdl_old_value): New function.
2343 (unbind_to): Minor simplification.
2344 (get_backtrace_frame): New function.
2345 (Fbacktrace_frame): Use it. Add `base' argument.
2346 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2347 (syms_of_eval): Export backtrace-eval.
2348 * xterm.c (x_focus_changed): Simplify.
2349
9d611ffe
PE
23502013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2353
999c74e3
EZ
23542013-07-24 Eli Zaretskii <eliz@gnu.org>
2355
2356 * xdisp.c (redisplay_window): Instead of moving point out of
2357 scroll margin, reject the force_start method, and try scrolling
2358 instead. (Bug#14780)
2359
198fa217
KB
23602013-07-24 Ken Brown <kbrown@cornell.edu>
2361
2362 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2363 (Bug#14944).
2364
53840e55
PE
23652013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2366
2367 * eval.c (Fprogn): Do not check that BODY is a proper list.
2368 This undoes the previous change. The check slows down the
2369 interpreter, and is not needed to prevent a crash. See
2370 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2371
60967f56
GM
23722013-07-23 Glenn Morris <rgm@gnu.org>
2373
2374 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2375
9ca960e2
PE
23762013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2377
a29c3e6d
PE
2378 Port to GNU/Linux systems with tinfo but not ncurses.
2379 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2380 to decide whether ncurses is being used. Without this change,
2381 GCC complains about tgetent not being declared, on a system
2382 that has tinfo installed but ncurses not installed.
2383
f274311c
PE
2384 * eval.c (Fprogn): Check that BODY is a proper list.
2385
16b0520a
PE
2386 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2387 * data.c (Fsetq_default):
2388 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2389 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2390 (Fcondition_case):
2391 Tune by taking advantage of the fact that ARGS is always a list
2392 when a function is declared to have UNEVALLED args.
2393
9ca960e2
PE
2394 * emacsgtkfixed.c: Port to GCC 4.6.
2395 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2396
afacaa1b
JB
23972013-07-23 Juanma Barranquero <lekktu@gmail.com>
2398
2399 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2400 here to silence compiler warnings.
2401
368a85a4
PE
24022013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2405 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2406 from messing up Emacs's 'struct frame' (Bug#14923).
2407
f4e891b5
PE
24082013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 * alloc.c (make_save_ptr_ptr): Define this function.
2411 It was inadvertently omitted. It's needed only if
2412 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2413
96c8b65e
JD
24142013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2415
2416 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2417 frame have focus (Bug#14895).
2418
ee010797
PE
24192013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 Avoid vfork-related deadlock more cleanly.
2422 * callproc.c (child_setup): When the child's exec fails, output
2423 the program name, as that's more useful. Use O_NONBLOCK to avoid
2424 deadlock.
2425 * process.c (create_process_1): Remove; no longer needed.
2426 (create_process): Remove timer hack; no longer needed, now that
2427 the child avoids deadlock.
2428
f0398ec1 24292013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2430
2431 * image.c (Fimage_flush): Fix doc typo.
2432
b2a069c2
PE
24332013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2434
6496aec9
PE
2435 Fix array bounds violation when pty allocation fails.
2436 * process.c (PTY_NAME_SIZE): New constant.
2437 (pty_name): Remove static variable; it's now auto.
2438 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2439 Take pty_name as an arg rather than using a static variable.
2440 All callers changed.
2441 (create_process): Recover pty_flag from process, not from volatile local.
2442 (create_pty): Stay inside array even when pty allocation fails.
2443 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2444
b2a069c2
PE
2445 * lread.c (Fload): Avoid initialization only when lint checking.
2446 Mention that it's needed only for older GCCs.
2447
99107004
KH
24482013-07-20 Kenichi Handa <handa@gnu.org>
2449
2450 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2451 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2452
6b1b199d
AS
24532013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2454
2455 * lread.c (Fload): Avoid uninitialized warning.
2456
4195afc3
PE
24572013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2458
3f5bef16
PE
2459 Fix some minor file descriptor leaks and related glitches.
2460 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2461 (create_lock_file): Use write, not emacs_write.
2462 * image.c (slurp_file, png_load_body):
2463 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2464 (server_accept_connection):
2465 Don't leak an fd on memory allocation failure.
2466 * image.c (slurp_file): Add a cheap heuristic for growing files.
2467 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2468 as that's what the other routines do. Maybe input need not be
2469 blocked at all, but it's better to be consistent.
2470 Avoid undefined behavior when strlen is zero.
2471
4195afc3
PE
2472 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2473 (NSTATICS): Now a constant; doesn't need to be a macro.
2474
a1aeeffe
RS
24752013-07-19 Richard Stallman <rms@gnu.org>
2476
2477 * coding.c (decode_coding_utf_8): Add simple loop for fast
2478 processing of ASCII characters.
2479
63b34baa
PE
24802013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2481
2482 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2483
621dd9ac
EZ
24842013-07-19 Eli Zaretskii <eliz@gnu.org>
2485
2486 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2487 unportable 'struct x_display_info'.
2488 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2489 is a portable type.
2490
1396ac86
PE
24912013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2492
ab9980cd
PE
2493 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2494 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2495 or fscanf fails.
2496 (system_process_attributes): Prefer plain char to unsigned char
2497 when either will do. Clean up properly if interrupted or if
068f9124
SM
2498 memory allocations fail. Don't assume sscanf succeeds.
2499 Remove no-longer-needed workaround to stop GCC from whining.
2500 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2501 bit more carefully.
2502
1396ac86
PE
2503 Fix obscure porting bug with varargs functions.
2504 The code assumed that int is treated like ptrdiff_t in a vararg
2505 function, which is not a portable assumption. There was a similar
2506 -- though these days less likely -- porting problem with various
2507 assumptions that pointers of different types all smell the same as
2508 far as vararg functions is conserved. To make this problem less
2509 likely in the future, redo the API to use varargs functions.
2510 * alloc.c (make_save_value): Remove this vararg function.
2511 All uses changed to ...
2512 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2513 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2514 New functions.
2515 (make_save_ptr): Rename from make_save_pointer, for consistency with
2516 the above. Define only on platforms that need it. All uses changed.
2517
4d19d194
PE
25182013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2519
2520 * keyboard.c: Try to fix typos in previous change.
2521 (DISPLAY_LIST_INFO): New macro.
2522 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2523 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2524
945c5bb1
JB
25252013-07-18 Juanma Barranquero <lekktu@gmail.com>
2526
2527 * keyboard.c (kbd_buffer_get_event):
2528 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2529 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2530
f4b1eb36
PE
25312013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2532
5e679a2c
PE
2533 * filelock.c: Fix unlikely file descriptor leaks.
2534 (get_boot_time_1): Rework to avoid using emacs_open.
2535 This doesn't actually fix a leak, but is better anyway.
2536 (read_lock_data): Use read, not emacs_read.
2537
a8cd4836
PE
2538 * doc.c: Fix minor memory and file descriptor leaks.
2539 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2540 (get_doc_string, Fsnarf_documentation):
2541 Fix file descriptor leak on error.
2542
ef30e638
PE
2543 * term.c: Fix minor fdopen-related file descriptor leaks.
2544 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2545 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2546
f4b1eb36
PE
2547 * charset.c: Fix file descriptor leaks and errno issues.
2548 Include <errno.h>.
2549 (load_charset_map_from_file): Don't leak file descriptor on error.
2550 Use plain record_xmalloc since the allocation is larger than
2551 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2552 of entries.
2553 * eval.c (record_unwind_protect_nothing):
2554 * fileio.c (fclose_unwind):
2555 New functions.
2556 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2557 The replacement doesn't block input, but that no longer seems
2558 necessary.
2559
b648c163
PE
25602013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2561
a0931322
PE
2562 * lread.c: Fix file descriptor leaks and errno issues.
2563 (Fload): Close some races that leaked fds or streams when 'load'
2564 was interrupted.
2565 (Fload, openp): Report error number of last nontrivial failure to open.
2566 ENOENT counts as trivial.
2567 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2568 New functions.
2569 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2570 now that the function is always called with a nonnegative arg.
2571 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2572 All uses replaced with ...
2573 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2574
b648c163
PE
2575 A few more minor file errno-reporting bugs.
2576 * callproc.c (Fcall_process):
2577 * doc.c (Fsnarf_documentation):
2578 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2579 * process.c (set_socket_option):
2580 Don't let a constructor trash errno.
2581 * doc.c: Include <errno.h>.
2582
b1dc4084
JB
25832013-07-16 Juanma Barranquero <lekktu@gmail.com>
2584
2585 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2586
c43843aa
PE
25872013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2588
50a30cce
PE
2589 Fix w32 bug with call-process-region (Bug#14885).
2590 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2591 to Fcall_process when the input is empty. This simplifies the
2592 code a bit. It makes no difference on POSIXish platforms but
2593 apparently it fixes a bug on w32.
2594
44e18199 2595 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2596 * fileio.c (close_file_unwind): Don't close if FD is negative;
2597 this can happen when unwinding a zapped file descriptor.
2598 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2599 in case Emacs runs out of memory between the two unwind-protects.
2600 Don't trash errno when closing FD.
2601 Zap the FD in the specpdl when closing it, instead of deferring
2602 the removal of the unwind-protect; this fixes a bug where a child
2603 function unwinds the stack past us.
2604
27e498e6
PE
2605 New unwind-protect flavors to better type-check C callbacks.
2606 This also lessens the need to write wrappers for callbacks,
2607 and the need for make_save_pointer.
2608 * alloca.c (free_save_value):
2609 * atimer.c (run_all_atimers):
2610 Now extern.
2611 * alloc.c (safe_alloca_unwind):
2612 * atimer.c (unwind_stop_other_atimers):
2613 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2614 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2615 * minibuf.c (choose_minibuf_frame_1):
2616 * process.c (make_serial_process_unwind):
2617 * xdisp.h (pop_message_unwind):
2618 * xselect.c (queue_selection_requests_unwind):
2619 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2620 * alloca.c (record_xmalloc):
2621 Prefer record_unwind_protect_ptr to record_unwind_protect with
2622 make_save_pointer.
2623 * alloca.c (Fgarbage_collect):
2624 Prefer record_unwind_protect_void to passing a dummy.
2625 * buffer.c (restore_buffer):
2626 * window.c (restore_window_configuration):
2627 * xfns.c, w32fns.c (do_unwind_create_frame)
2628 New wrapper. All record-unwind uses of wrappee changed.
2629 * buffer.c (set_buffer_if_live):
2630 * callproc.c (call_process_cleanup, delete_temp_file):
2631 * coding.c (code_conversion_restore):
2632 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2633 * editfns.c (save_excursion_restore)
2634 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2635 (save_restriction_restore):
2636 * eval.c (restore_stack_limits, un_autoload):
2637 * fns.c (require_unwind):
2638 * keyboard.c (recursive_edit_unwind, tracking_off):
2639 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2640 * macros.c (pop_kbd_macro, restore_menu_items):
2641 * nsfns.m (unwind_create_frame):
2642 * print.c (print_unwind):
2643 * process.c (start_process_unwind):
2644 * search.c (unwind_set_match_data):
2645 * window.c (select_window_norecord, select_frame_norecord):
2646 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2647 (fast_set_selected_frame):
2648 * xfns.c, w32fns.c (unwind_create_tip_frame):
2649 Return void, not a dummy Lisp_Object. All uses changed.
2650 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2651 * callproc.c (call_process_kill):
2652 * fileio.c (restore_point_unwind, decide_coding_unwind)
2653 (build_annotations_unwind):
2654 * insdel.c (Fcombine_after_change_execute_1):
2655 * keyboard.c (read_char_help_form_unwind):
2656 * menu.c (unuse_menu_items):
2657 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2658 * sound.c (sound_cleanup):
2659 * xdisp.c (unwind_redisplay):
2660 * xfns.c (clean_up_dialog):
2661 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2662 Accept no args and return void, instead of accepting and returning
2663 a dummy Lisp_Object. All uses changed.
2664 * cygw32.c (fchdir_unwind):
2665 * fileio.c (close_file_unwind):
2666 * keyboard.c (restore_kboard_configuration):
2667 * lread.c (readevalllop_1):
2668 * process.c (wait_reading_process_output_unwind):
2669 Accept int and return void, rather than accepting an Emacs integer
2670 and returning a dummy object. In some cases this fixes an
2671 unlikely bug when the corresponding int is outside Emacs integer
2672 range. All uses changed.
2673 * dired.c (directory_files_internal_unwind):
2674 * fileio.c (do_auto_save_unwind):
2675 * gtkutil.c (pop_down_dialog):
2676 * insdel.c (reset_var_on_error):
2677 * lread.c (load_unwind):
2678 * xfns.c (clean_up_file_dialog):
2679 * xmenu.c, nsmenu.m (pop_down_menu):
2680 * xmenu.c (cleanup_widget_value_tree):
2681 * xselect.c (wait_for_property_change_unwind):
2682 Accept pointer and return void, rather than accepting an Emacs
2683 save value encapsulating the pointer and returning a dummy object.
2684 All uses changed.
2685 * editfns.c (Fformat): Update the saved pointer directly via
2686 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2687 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2688 (unwind_body): New function.
2689 (record_unwind_protect): First arg is now a function returning void,
2690 not a dummy Lisp_Object.
2691 (record_unwind_protect_ptr, record_unwind_protect_int)
2692 (record_unwind_protect_void): New functions.
2693 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2694 * fileio.c (struct auto_save_unwind): New type.
2695 (do_auto_save_unwind): Use it.
2696 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2697 * insdel.c (struct rvoe_arg): New type.
2698 (reset_var_on_error): Use it.
2699 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2700 New constants.
2701 (specbinding_func): Remove; there are now several such functions.
2702 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2703 (set_unwind_protect_ptr): New function.
2704 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2705
4e604a5d
PE
2706 Be simpler and more consistent about reporting I/O errors.
2707 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2708 Say "Read error" and "Write error", rather than "I/O error", or
2709 "IO error reading", or "IO error writing", when a read or write
2710 error occurs.
2711 * process.c (Fmake_network_process, wait_reading_process_output)
2712 (send_process, Fprocess_send_eof, wait_reading_process_output):
2713 Capitalize diagnostics consistently. Put "failed foo" at the
2714 start of the diagnostic, so that we don't capitalize the
2715 function name "foo". Consistently say "failed" for such
2716 diagnostics.
2717 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2718 All callers changed. This is so it can use report_file_error.
2719 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2720 diagnostics consistently as above.
2721
a9757f6a
PE
2722 * fileio.c (report_file_errno): Fix errno reporting bug.
2723 If the file name is neither null nor a pair, package it up as a
2724 singleton list. All callers changed, both to this function and to
2725 report_file_error. This fixes a bug where the memory allocator
2726 invoked by list1 set errno so that the immediately following
2727 report_file_error reported the wrong errno value.
2728
c43843aa
PE
2729 Fix minor problems found by --enable-gcc-warnings.
2730 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2731 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2732
18c26d81
JD
27332013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2734
2735 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2736 Set event->arg to Qt if switch-event shall be generated.
2737 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2738
2739 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2740
2741 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2742 FOCUS_OUT_EVENT.
2743
2744 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2745 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2746 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2747 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2748 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2749 and there is a focused frame.
2750 (head_table): Add focus-in and focus-out.
2751 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2752 bind to handle-focus-in/out.
2753
2754 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2755 (Fhandle_switch_frame): Call Fhandle_focus_in.
2756 (syms_of_frame): defsubr handle-focus-in/out.
2757
6c6f1994
PE
27582013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2759
c7ddc792
PE
2760 Fix porting bug to older POSIXish platforms (Bug#14862).
2761 * sysdep.c (emacs_pipe): New function, that implements
2762 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2763 This should port better to CentOS 5 and to Mac OS X 10.6.
2764 All calls to pipe2 changed.
2765
6c6f1994
PE
2766 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2767 This makes the code easier to read and the executable a bit smaller.
2768 Do not replace all calls to Fcons that happen to create lists,
2769 just calls that are intended to create lists. For example, when
2770 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2771 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2772 Similarly for list2 through list5.
2773 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2774 * bytecode.c (exec_byte_code):
2775 * callint.c (quotify_arg, Fcall_interactively):
2776 * callproc.c (Fcall_process, create_temp_file):
2777 * charset.c (load_charset_map_from_file)
2778 (Fdefine_charset_internal, init_charset):
2779 * coding.c (get_translation_table, detect_coding_system)
2780 (Fcheck_coding_systems_region)
2781 (Fset_terminal_coding_system_internal)
2782 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2783 * composite.c (update_compositions, Ffind_composition_internal):
2784 * dired.c (directory_files_internal, file_name_completion)
2785 (Fsystem_users):
2786 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2787 * doc.c (Fsnarf_documentation):
2788 * editfns.c (Fmessage_box):
2789 * emacs.c (main):
2790 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2791 (Feval, eval_sub, Ffuncall, apply_lambda):
2792 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2793 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2794 (Fset_file_times, Finsert_file_contents)
2795 (Fchoose_write_coding_system, Fwrite_region):
2796 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2797 * font.c (font_registry_charsets, font_parse_fcname)
2798 (font_prepare_cache, font_update_drivers, Flist_fonts):
2799 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2800 * frame.c (make_frame, Fmake_terminal_frame)
2801 (x_set_frame_parameters, x_report_frame_params)
2802 (x_default_parameter, Fx_parse_geometry):
2803 * ftfont.c (syms_of_ftfont):
2804 * image.c (gif_load):
2805 * keyboard.c (command_loop_1):
2806 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2807 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2808 (Fminor_mode_key_binding, accessible_keymaps_1)
2809 (Faccessible_keymaps, Fwhere_is_internal):
2810 * lread.c (read_emacs_mule_char):
2811 * menu.c (find_and_return_menu_selection):
2812 * minibuf.c (get_minibuffer):
2813 * nsfns.m (Fns_perform_service):
2814 * nsfont.m (ns_script_to_charset):
2815 * nsmenu.m (ns_popup_dialog):
2816 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2817 (Fx_own_selection_internal):
2818 * nsterm.m (append2):
2819 * print.c (Fredirect_debugging_output)
2820 (print_prune_string_charset):
2821 * process.c (Fdelete_process, Fprocess_contact)
2822 (Fformat_network_address, set_socket_option)
2823 (read_and_dispose_of_process_output, write_queue_push)
2824 (send_process, exec_sentinel):
2825 * sound.c (Fplay_sound_internal):
2826 * textprop.c (validate_plist, add_properties)
2827 (Fput_text_property, Fadd_face_text_property)
2828 (copy_text_properties, text_property_list, syms_of_textprop):
2829 * unexaix.c (report_error):
2830 * unexcoff.c (report_error):
2831 * unexsol.c (unexec):
2832 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2833 (Fformat_mode_line, syms_of_xdisp):
2834 * xfaces.c (set_font_frame_param)
2835 (Finternal_lisp_face_attribute_values)
2836 (Finternal_merge_in_global_face, syms_of_xfaces):
2837 * xfns.c (x_default_scroll_bar_color_parameter)
2838 (x_default_font_parameter, x_create_tip_frame):
2839 * xfont.c (xfont_supported_scripts):
2840 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2841 (menu_help_callback, xmenu_show):
2842 * xml.c (make_dom):
2843 * xterm.c (set_wm_state):
2844 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2845 and similarly for list2 through list5.
2846
bafe80ce
PE
28472013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2848
2849 * callproc.c (Fcall_process_region): Fix minor race and tune.
2850 (create_temp_file): New function, with the temp-file-creation part
2851 of the old Fcall_process_region. Use Fcopy_sequence to create the
2852 temp file name, rather than alloca + build_string, for simplicity.
2853 Don't bother to block input around the temp file creation;
068f9124
SM
2854 shouldn't be needed. Simplify use of mktemp.
2855 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2856 this closes an unlikely race where the temp file was not removed.
2857 Use memcpy rather than an open-coded loop.
2858 (Fcall_process_region): Use the new function. If the input is
2859 empty, redirect from /dev/null rather than from a newly created
2860 empty temp file; this avoids unnecessary file system traffic.
2861
4700b5a5
PE
28622013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2863
5c97beae
PE
2864 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2865 Simplify by making this case like the other two. This is a bit
2866 slower on obsolete hosts, but the extra complexity isn't worth it.
2867
4700b5a5
PE
2868 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2869 * process.c (create_process) [!DOS_NT]:
2870 Remove now-unnecessary calls to emacs_close.
2871
f9a74c4c
EZ
28722013-07-13 Eli Zaretskii <eliz@gnu.org>
2873
922ae7ee
EZ
2874 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2875 returning early. (Bug#14850)
2876
f9a74c4c
EZ
2877 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2878 and inhibit-iso-escape-detection attributes of 'undecided'.
2879 (Bug#14822)
2880
5e301d76
PE
28812013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2882
69e0e5ee
PE
2883 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2884 Reported by Herbert J. Skuhra in
2885 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2886
5e301d76
PE
2887 Don't lose top specpdl entry when memory is exhausted.
2888 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2889 specpdl overflow here, to simplify callers; all callers changed.
2890 Always reserve an unused entry at the stack top; this avoids
2891 losing the top entry's information when memory is exhausted.
2892
7e649856
PE
28932013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2894
a773ed9a
PE
2895 Clean up errno reporting and fix some errno-reporting bugs.
2896 * callproc.c (Fcall_process):
2897 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2898 * process.c (create_process, Fmake_network_process):
2899 * unexaix.c (report_error):
2900 * unexcoff.c (report_error):
2901 Be more careful about reporting the errno of failed operations.
2902 The code previously reported the wrong errno sometimes.
2903 Also, prefer report_file_errno to setting errno + report_file_error.
2904 (Fcall_process): Look at openp return value rather than at path,
2905 as that's a bit faster and clearer when there's a numeric predicate.
2906 * fileio.c (report_file_errno): New function, with most of the
2907 old contents of report_file_error.
2908 (report_file_error): Use it.
2909 (Ffile_exists_p, Ffile_accessible_directory_p):
2910 Set errno to 0 when it is junk.
2911 * fileio.c (Faccess_file):
2912 * image.c (x_create_bitmap_from_file):
2913 Use faccessat rather than opening the file, to avoid the hassle of
2914 having a file descriptor open.
2915 * lisp.h (report_file_errno): New decl.
2916 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2917
7e649856
PE
2918 Minor EBADF fixes.
2919 * process.c (create_process, wait_reading_process_output) [AIX]:
2920 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2921 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2922 a multithreaded environment anyway).
2923 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2924
f6774c1a
AS
29252013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2926
2927 * image.c (x_find_image_file): Don't close a remote file handle.
2928
bacba3c2
PE
29292013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 Fix races with threads and file descriptors.
2932 * callproc.c (Fcall_process_region):
2933 * dired.c (open_directory):
2934 * emacs.c (main, Fdaemon_initialized):
2935 * image.c (x_find_image_file):
2936 * inotify.c (Finotify_rm_watch):
2937 * lread.c (Flocate_file_internal):
2938 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2939 * term.c (term_mouse_moveto, init_tty):
2940 * termcap.c (tgetent):
2941 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2942 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2943 * unexhp9k800.c, unexmacosx.c (unexec):
2944 * callproc.c (Fcall_process_region):
2945 Use emacs_close, not close.
2946 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2947 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2948 and posix_close function on current platforms (which all lack them).
2949 (emacs_close): Use it. This should fix the races on GNU/Linux and
2950 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2951 and it should avoid closing random victim file descriptors on
2952 other platforms.
2953
653d4f43
PE
29542013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2955
c8536ec4
PE
2956 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2957 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2958 Touch up doc a bit.
2959
9c203066
PE
2960 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2961 This is for .gdbinit xbacktrace.
2962
653d4f43
PE
2963 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2964 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2965 (emacs_set_tty): Now static.
2966 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2967 * term.c (tty_capable_p, tty_default_color_capabilities)
2968 (get_tty_terminal, term_mouse_movement)
2969 (handle_one_term_event, init_tty, maybe_fatal):
2970 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2971 (tgetent, scan_file, name_match, compare_contin):
2972 * terminal.c (get_terminal):
2973 Use bool for boolean.
2974 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2975 Prefer char to unsigned char if either will do.
2976 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2977 (tty_write_glyphs): Prefer int to unsigned.
2978 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2979 All callers changed.
2980 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2981
45b683a1
PE
29822013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2983
29abe551
PE
2984 Port to C89.
2985 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2986 (B__dummy__): New dummy symbol, to pacify C89.
2987 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2988 they can't grok varargs macros.
2989 * dispnew.c (add_window_display_history)
2990 (add_frame_display_history):
2991 * print.c (print_object):
2992 * xdisp.c (debug_method_add):
2993 Use %p printf format only for void pointers.
2994 * emacs.c (usage_message): New constant, replacing ...
2995 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2996 (main): Adjust to usage reorg.
2997 * fns.c (syms_of_fns):
2998 * profiler.c (syms_of_profiler):
2999 Don't use non-constant struct initializers.
3000 * gnutls.h (gnutls_initstage_t):
3001 * lisp.h (enum Lisp_Fwd_Type):
3002 * lread.c (lisp_file_lexically_bound_p):
3003 * xsettings.c (anonymous enum):
3004 Remove trailing comma.
3005 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3006 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3007 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3008 (DEFUN): Use it.
3009 * regex.c (const_re_char): New type, to pacify strict C89.
3010 All uses of 'const re_char' replaced to use it.
3011 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3012 with glibc when strict C89. This change is imported from gnulib.
3013 All uses changed.
3014 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3015 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3016 Omit GNU_LINUX implementation, since it requires long long.
3017 * xterm.c (x_draw_underwave):
3018 Do not assume the traditional order of struct's members.
3019 (x_term_init): Rewrite to avoid the need for non-constant structure
3020 initializers.
3021
45b683a1 3022 Syntax cleanup, mostly replacing macros with functions.
763a086d 3023 This removes the need for the syntax_temp hack.
45b683a1
PE
3024 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3025 * syntax.c (SYNTAX_INLINE): New macro.
3026 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3027 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3028 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3029 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3030 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3031 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3032 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3033 Now constants, not macros.
3034 (syntax_temp) [!__GNUC__]: Remove.
3035 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3036 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3037 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3038 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3039 Move here from syntax.h; now functions, not macros. Except for the
3040 last function, these are static since only syntax.c uses them.
3041 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3042 All uses changed. Now a function, not a macro; use this fact
3043 to simplify the code.
3044 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3045 compiler bugs; no longer relevant.
3046 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3047 (SYNTAX_INLINE): New macro.
3048 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3049 for the new functions. Use bool for boolean member.
3050 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3051 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3052 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3053 (SETUP_BUFFER_SYNTAX_TABLE):
3054 Now extern inline functions, not macros.
3055 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3056 Remove; all uses replaced by implementation.
3057 (syntax_temp) [!__GNUC__]: Remove decl.
3058 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3059
29be4a50
JD
30602013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3061
3062 * emacs.c (main): Fix syntax error.
3063
954b166e
PE
30642013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3065
3066 Timestamp fixes for undo (Bug#14824).
3067 * atimer.c (schedule_atimer):
3068 * fileio.c (Ffile_newer_than_file_p):
3069 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3070 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3071 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3072 (syms_of_fileio): Remove Sclear_visited_file_name.
3073 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3074 file doesn't exist; this avoids an ambiguity with negative timestamps.
3075 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3076 * systime.h (make_emacs_time, invalid_emacs_time):
3077 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3078 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3079 * undo.c (record_first_change): Push (visited-file-modtime) onto
3080 undo list rather than reimplementing it by hand, incorrectly.
3081
d74647c3
KB
30822013-07-09 Ken Brown <kbrown@cornell.edu>
3083
3084 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3085
3c51b96b
JB
30862013-07-09 Juanma Barranquero <lekktu@gmail.com>
3087
3088 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3089
4ebbdd67
PE
30902013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 Handle errno and exit status a bit more carefully.
3093 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3094 number into an exit status. Instead, use EXIT_CANCELED.
3095 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3096 * callproc.c (relocate_fd):
3097 * emacs.c (close_output_streams, main):
3098 * process.c (create_process):
3099 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3100 Use emacs_perror for simplicity.
3101 * callproc.c (relocate_fd, main):
3102 * sysdep.c (sys_subshell):
3103 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3104 (shut_down_emacs): Use emacs_write, not write.
3105 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3106 * fileio.c (Fcopy_file, e_write):
3107 * nsterm.m (ns_select):
3108 * process.c (send_process):
3109 * sound.c (vox_write):
3110 Use emacs_write_sig, not emacs_write.
3111 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3112 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3113 New constants.
3114 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3115 of write.
3116 (emacs_full_write): New function.
3117 (emacs_write): Rewrite to use it.
3118 (emacswrite_sig, emacs_perror): New functions.
3119 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3120
44e18199 31212013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3122
3123 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3124 on NS even if it is present. Pixmap on NS is a void*.
3125
9caab067
PE
31262013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3127
3128 Port to Ubuntu 10 (Bug#14803).
3129 Problem reported by T.V. Raman.
3130 * process.c (close_on_exec, accept4, process_socket):
3131 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3132
1d442672
EZ
31332013-07-07 Eli Zaretskii <eliz@gnu.org>
3134
3135 * w32.c (sys_dup): Declare prototype.
3136
3137 * filelock.c:
3138 * emacs.c:
3139 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3140
067428c1
PE
31412013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 Make file descriptors close-on-exec when possible (Bug#14803).
3144 This simplifies Emacs a bit, since it no longer needs to worry
3145 about closing file descriptors by hand in some cases.
3146 It also fixes some unlikely races. Not all such races, as
3147 libraries often open files internally without setting
3148 close-on-exec, but it's an improvement.
3149 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3150 * callproc.c (Fcall_process) [!MSDOS]:
3151 * emacs.c (main) [!DOS_NT]:
3152 * nsterm.m (ns_term_init):
3153 * process.c (create_process):
3154 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3155 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3156 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3157 Prefer mkostemp with O_CLOEXEC to mkstemp.
3158 * callproc.c (relocate_fd) [!WINDOWSNT]:
3159 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3160 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3161 now using pipe2.
3162 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3163 Make the resulting file descriptor close-on-exec.
3164 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3165 * lread.c (load_descriptor_list, load_descriptor_unwind):
3166 Remove; no longer needed. All uses removed.
3167 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3168 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3169 New functions.
3170 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3171 (Fmake_network_process, Fnetwork_interface_list):
3172 (Fnetwork_interface_info, server_accept_connection):
3173 Make newly-created socket close-on-exec.
3174 * sysdep.c (emacs_open, emacs_fopen):
3175 Make new-created descriptor close-on-exec.
3176 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3177 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3178
0da857dd
JD
31792013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3180
3181 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3182 for NS_IMPL_GNUSTEP.
3183
5f86adcd
PE
31842013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 Fix openp errno handling.
3187 * callproc.c (Fcall_process): Preserve openp errno around close.
3188 * lread.c (openp): Set errno when returning -1, as some callers
3189 expect this.
3190
1afb1d07
JD
31912013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3192
3193 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3194
3195 * nsterm.h (NSSavePanel): Update comment.
3196 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3197 (ns_run_file_dialog): Declare.
3198
3199 * nsfns.m: Remove panelOK.
3200 (ns_fd_data): New.
3201 (ns_run_file_dialog): New function.
3202 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3203 event loop, so file dialog is popped up by ns_run_file_dialog, called
3204 by sendEvent (Bug#14578).
3205 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3206
3323c263
EZ
32072013-07-06 Eli Zaretskii <eliz@gnu.org>
3208
fdda0220
EZ
3209 * xdisp.c (default_line_pixel_height): New function.
3210 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3211 (try_cursor_movement, redisplay_window, try_window)
3212 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3213
068f9124
SM
3214 * window.c (window_scroll_pixel_based):
3215 use default_line_pixel_height.
fdda0220
EZ
3216
3217 * dispextern.h (default_line_pixel_height): Add prototype.
3218
3219 * frame.c (x_set_line_spacing): Accept a float value for
3220 line-spacing parameter, per the documentation.
3221
3323c263
EZ
3222 * data.c (Fmultibyte_string_p): Doc fix.
3223
47ba6d43
PE
32242013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3225
406af475
PE
3226 Use emacs_open more consistently when opening files.
3227 This handles EINTR more consistently now, and makes it easier
3228 to introduce other uniform changes to file descriptor handling.
3229 * src/systdio.h: New file.
3230 * src/buffer.c (mmap_init):
3231 * cygw32.c (chdir_to_default_directory):
3232 * dispnew.c (Fopen_termscript):
3233 * emacs.c (Fdaemon_initialized):
3234 * fileio.c (Fdo_auto_save):
3235 * image.c (slurp_file, png_load_body, jpeg_load_body):
3236 * keyboard.c (Fopen_dribble_file):
3237 * lread.c (Fload):
3238 * print.c (Fredirect_debugging_output):
3239 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3240 * termcap.c (tgetent):
3241 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3242 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3243 * w32term.c (w32_initialize) [CYGWIN]:
3244 * xfaces.c (Fx_load_color_file):
3245 Use emacs_open instead of plain open, and emacs_fopen instead of
3246 plain fopen.
3247 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3248 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3249 * callproc.c (default_output_mode): New constant.
3250 (Fcall_process): Use it to call emacs_open instead of plain creat.
3251 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3252 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3253 (emacs_fopen): New function.
3254 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3255 Include <lisp.h>, for emacs_open.
3256 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3257
47ba6d43
PE
3258 Remove duplicate #include directives.
3259 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3260 * xfaces.c:
3261 Don't include stdio.h twice.
3262 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3263 Don't include sys/types.h or stdio.h twice.
3264 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3265 * lread.c: Don't include coding.h twice.
3266 * nsfont.m: Don't include frame.h twice.
3267 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3268 * ralloc.c: Don't include <unistd.h> twice.
3269 * xdisp.c: Don't include font.h twice.
3270 * xterm.c: Don't include fontset.h twice.
3271 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3272
b9ed53d5
PE
32732013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 Scale ImageMagick images more carefully.
3276 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3277 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3278 Be more careful about avoiding undefined behavior after
3279 integer overflow and division by zero.
3280
cf13177e
YM
32812013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3282
3283 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3284 (syms_of_w32fns): DEFSYM them.
3285 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3286 (CCHDEVICENAME): Define macros if not defined.
3287 (struct MONITOR_INFO_EX): New struct.
3288 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3289 (enum_display_monitors_fn): New variable.
3290 (globals_of_w32fns): Initialize it.
3291 (Fx_display_pixel_width, Fx_display_pixel_height)
3292 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3293 multi-monitor setups in docstrings.
3294 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3295 screen size by primary monitor's millimeter per pixel.
3296 (w32_monitor_enum, w32_display_monitor_attributes_list)
3297 (w32_display_monitor_attributes_list_fallback)
3298 (Fw32_display_monitor_attributes_list): New functions.
3299 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3300
3301 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3302 if not defined.
3303 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3304
86dfb7a8
MA
33052013-07-04 Michael Albinus <michael.albinus@gmx.de>
3306
3307 * fileio.c (Qfile_notify_error): New error symbol.
3308
3309 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3310 * inotify.c (inotify_callback, symbol_to_inotifymask)
3311 (Finotify_add_watch, Finotify_rm_watch): Use it.
3312 (inotifyevent_to_event): Exchange order of cookie and file name.
3313 (Finotify_add_watch): Adapt docstring.
3314
3315 * lisp.h (Qfile_notify_error): Declare.
3316
2c1c974b
PE
33172013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3320 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3321 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3322 which did not work (see <http://bugs.gnu.org/14569#307>).
3323 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3324 && (!noninteractive || initialized)). This attempts to thread
3325 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3326
7a35b20f
JB
33272013-07-04 Juanma Barranquero <lekktu@gmail.com>
3328
3329 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3330 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3331
1ce5cd04
PE
33322013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3333
3334 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3335 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3336 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3337 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3338
57f8c490
PE
33392013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3340
3341 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3342 Define to __sys_siglist.
3343
bcffb5ca
EZ
33442013-07-02 Eli Zaretskii <eliz@gnu.org>
3345
3346 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3347 word-wrap, so that overflow-newline-into-fringe would work in
3348 visual-line-mode. (Bug#2749)
3349 (move_it_in_display_line_to): When the last scanned display
3350 element fits exactly on the display line, and
3351 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3352 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3353 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3354 finding buffer position that corresponds to pixel coordinates,
3355 e.g. in buffer_posn_from_coords.
3356
2c41e781
JD
33572013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3358
3359 * process.c (handle_child_signal): Call catch_child_signal if
3360 NS_IMPL_GNUSTEP.
3361
c2418359
PE
33622013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3363
52a9bcae
PE
3364 Don't convert function pointers to void * and back.
3365 It isn't portable C, and it's easy enough to avoid.
3366 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3367 (make_save_value): Add support for SAVE_FUNCPOINTER.
3368 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3369 * print.c (print_object):
3370 Distinguish function from object pointers.
3371 * lisp.h (SAVE_FUNCPOINTER): New constant.
3372 (SAVE_SLOT_BITS): Adjust to it.
3373 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3374 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3375 (voidfuncptr): New typedef.
3376 (struct Lisp_Save_Value): New member data[0].funcpointer.
3377 (XSAVE_FUNCPOINTER): New function.
3378
c2418359
PE
3379 Simplify buildobj processing.
3380 * Makefile.in (buildobj.h): Make it a sequence of strings each
3381 followed by comma, rather than a single string. Put it into a
3382 .tmp file in case there's an error while generating it.
3383 (gl-stamp): Use .tmp for temp files.
3384 (mostlyclean): Clean .tmp files.
3385 * doc.c (buildobj): Move to just the routine that needs it.
3386 It's now an array of strings, so processing is simpler.
3387
8f43ce49
PE
33882013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3389
3390 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3391 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3392 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3393 Invoke malloc_enable_thread even when not interactive.
3394 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3395 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3396 in this case, since the underlying bug has now been fixed.
3397
24827db9
JB
33982013-07-01 Juanma Barranquero <lekktu@gmail.com>
3399
3400 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3401 unlinking it (bug#14691).
3402
ef099a94
MN
34032013-06-30 Michal Nazarewicz <mina86@mina86.com>
3404
3405 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3406 before checking whether buffer is modified. This lets
3407 `kill-buffer-query-functions' cancel killing of the buffer or save
3408 its content before `kill-buffer' asks user the "Buffer %s
3409 modified; kill anyway?" question.
3410
9d3f2fc2
JD
34112013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3412
3413 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3414 Let the super performKeyEquivalent deal with them (Bug#14747).
3415
e6c6c8c7
PE
34162013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3417
1d71c1d9
PE
3418 * widget.c (resize_cb): Remove unused local.
3419
8f5f35cc
PE
3420 Do not use GTK 3 if it exists but cannot be compiled.
3421 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3422 * xterm.c (x_error_handler) [!USE_GTK]:
3423 Do not use GTK 3.
3424
e6c6c8c7
PE
3425 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3426
0ba54312
EZ
34272013-06-30 Eli Zaretskii <eliz@gnu.org>
3428
5d1c3286
EZ
3429 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3430 to the valid range of values. (Bug#14753)
3431
0ba54312
EZ
3432 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3433 when moving point by using the current glyph matrix. This avoids
3434 the need to force redisplay when this function is called in a
3435 loop.
3436
9c90cc06
PE
34372013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3438
3439 Fix minor problems found by static checking.
3440 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3441 Redo the latter's body to sidestep GCC parenthesization warnings.
3442 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3443 * coding.c (detect_coding, detect_coding_system):
3444 * coding.h (struct undecided_spec):
3445 Use bool for boolean.
3446 * image.c (QCmax_width, QCmax_height): Now static.
3447 * xdisp.c (Fmove_point_visually): Remove unused local.
3448
4c672a0f
EZ
34492013-06-29 Eli Zaretskii <eliz@gnu.org>
3450
3451 * xdisp.c (Fmove_point_visually): New function.
3452
c1ea3abf
JB
34532013-06-28 Kenichi Handa <handa@gnu.org>
3454
3455 * coding.h (define_coding_undecided_arg_index): New enum.
3456 (coding_attr_index): New members
3457 coding_attr_undecided_inhibit_null_byte_detection,
3458 coding_attr_undecided_inhibit_iso_escape_detection,
3459 coding_attr_undecided_prefer_utf_8.
3460 (undecided_spec): New struct.
3461 (struct coding_system): New member `undecided' of the member
3462 `spec'.
3463
3464 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3465 (detect_coding): Likewise.
3466 (detect_coding_system): Likewise.
3467 (Fdefine_coding_system_internal): New coding system properties
3468 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3469 :prefer-utf-8.
3470 (syms_of_coding): Adjust for coding_arg_undecided_max.
3471
ba3de9e6
PE
34722013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3473
3474 * image.c (x_from_xcolors): Remove unused local.
3475
547c9269
YM
34762013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3477
3478 Defer image data transfer between X client and server until actual
3479 display happens.
3480
3481 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3482 and `mask_img'.
3483
3484 * image.c (Destroy_Image): Remove.
3485 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3486 `mask_p', and `colors_p'. All uses changed.
3487 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3488 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3489 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3490 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3491 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3492 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3493 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3494 (image_get_x_image, image_unget_x_image): New functions or macros.
3495 (image_background, image_background_transparent, x_to_xcolors)
3496 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3497 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3498 instead of Destroy_Image.
3499 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3500 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3501 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3502 (imagemagick_load_image, svg_load_image): Use them instead of
3503 x_create_x_image_and_pixmap, and x_put_x_image followed by
3504 x_destroy_x_image, respectively.
3505 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3506 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3507 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3508 background_transparent fields.
3509 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3510 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3511
dae2f5ef
PE
35122013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3515 This mostly consists of undoing recent changes.
3516 * callproc.c (Fcall_process):
3517 * process.c (create_process):
3518 Do not worry about catching SIGCHLD here, undoing previous change.
3519 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3520 * process.c, process.h (catch_child_signal):
3521 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3522 * process.c (catch_child_handler): Don't worry about being called
3523 lazily and do not assume caller has blocked SIGCHLD, undoing
3524 previous change. Move first-time stuff back to
3525 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3526 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3527 set lib_child_handler if it's already initialized, which may
3528 help avoid problems on GNUStep.
3529
fa55d2aa
PE
35302013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3531
3532 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3533 * callproc.c (Fcall_process):
3534 * process.c (create_process):
3535 Make sure SIGCHLD is caught before we fork,
3536 since Emacs startup no arranges to catch SIGCHLD.
3537 * process.c (lib_child_handler): Initialize to null, not to
3538 dummy_handler.
3539 (catch_child_signal): Allow self to be called lazily.
3540 Do nothing if it's already been called.
3541 Assume caller has blocked SIGCHLD (all callers do now).
3542 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3543 just before it's really needed.
3544 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3545 since it hasn't been caught yet.
3546
f3f9606c
LMI
35472013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3548
3549 * image.c (compute_image_size): New function to implement
3550 :max-width and :max-height.
3551 (imagemagick_load_image): Use it.
3552
c7041908
PE
35532013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3556 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3557 Now extern.
3558 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3559 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3560 the SIGCHLD handler, since the code is not atomic and (due to glib)
3561 signals may be arriving now.
3562 * sysdep.c (init_signals): Do not catch child signals here;
3563 'main' now does that later, at a safer time.
3564
f86852b4
PE
35652013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3566
0dfeed58
PE
3567 Clean up SIGCHLD handling a bit (Bug#14569).
3568 * process.c, process.h (catch_child_signal):
3569 Now always extern, even if !NS_IMPL_GNUSTEP.
3570 * process.c (catch_child_signal): Move glib tickler here from
3571 init_process_emacs, so that it's done earlier in Emacs
3572 initialization. Also move the noninteractive && !initialized
3573 check here from init_process_emacs. This is all a bit cleaner for
3574 GNUish platforms, and I hope it works around the Cygwin bug.
3575 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3576 that glib signal handling is tickled before glib creates threads.
3577
f86852b4
PE
3578 * process.c (wait_reading_process_output): Avoid int overflow
3579 when reading more than 2 GiB total from a process.
3580
cbd6509c
PE
35812013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3582
3583 * process.c (create_process): Handle a couple more cases,
3584 i.e., work even if new_argv and wait_child_setup[i] are cached.
3585 Use Fcall_process's style for volatile vars.
3586
9de1114a
AS
35872013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3588
3589 * process.c (create_process): Mark PROCESS volatile.
3590
fbe9e0b9
PE
35912013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3592
3593 Use C99-style flexible array members if available.
3594 This avoids some subtle aliasing issues, which typically
3595 aren't a problem with GCC but may be a problem elsewhere.
3596 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3597 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3598 In either case, it uses a flexible array member rather than
3599 the old struct hack. All uses changed.
3600 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3601 Adjust to sdata reorganization.
3602 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3603 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3604 that ports better to pre-C99 non-GCC.
3605 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3606 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3607 as the latter has changed.
3608 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3609 and port better to pre-C99 GCC.
3610 * image.c (struct xpm_cached_color):
3611 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3612 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3613 Use FLEXIBLE_ARRAY_MEMBER.
3614 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3615 Move decl to top level so it gets checked against implementation.
3616 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3617 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3618
1fc71008
PE
36192013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3620
3621 * syntax.c: Integer cleanups.
3622 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3623 All uses that need 0-or-2 changed to:
3624 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3625 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3626 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3627 (char_quoted, prev_char_comend_first, back_comment)
3628 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3629 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3630 Use bool for boolean.
3631 (update_syntax_table, skip_chars, skip_syntaxes):
3632 Prefer int to unsigned when either will do.
3633 (back_comment): Return boolean success flag, like forw_comment,
3634 instead of positive-or-minus-1 (which might have overflowed int anyway).
3635 Don't stuff ptrdiff_t into int.
3636 (syntax_spec_code, syntax_code_spec): Now const.
3637 (Fmatching_paren, scan_lists, scan_sexps_forward):
3638 Use enum syntaxcode for syntax code.
3639 (Fmatching_paren): Check that arg is a character, not just an integer.
3640 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3641 (Finternal_describe_syntax_value): Omit no-longer-needed
3642 comparison to 0.
3643 (skip_chars): Use char, not unsigned char, when the distinction
3644 doesn't matter.
3645 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3646 * bytecode.c (exec_byte_code):
3647 * syntax.c (syntax_spec_code, Fchar_syntax)
3648 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3649 (init_syntax_once):
3650 * syntax.h (SYNTAX_WITH_FLAGS):
3651 Omit unnecessary casts.
3652
b932cad7
EZ
36532013-06-20 Eli Zaretskii <eliz@gnu.org>
3654
3655 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3656 line dimensions here, to avoid race conditions with the main
3657 thread. (Bug#14062, bug#14630, bug#14669)
3658
3659 * w32term.c (w32_draw_window_cursor): Compute the header line and
3660 mode line dimensions here.
3661 <w32_system_caret_window, w32_system_caret_hdr_height>:
3662 <w32_system_caret_mode_height>: New variables.
3663
3664 * w32term.h: Declare them.
3665
89561f72
PE
36662013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3667
5013fc08
PE
3668 * alloc.c (die): Move "assertion failed" string here ...
3669 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3670 COND when SUPPRESS_CHECKING. This shrinks the executable text
3671 size by 0.8% to 2.2% when configured with --enable-checking,
3672 depending on optimization flags (GCC 4.8.1 x86-64).
3673
89561f72
PE
3674 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3675
763a086d 36762013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3677
3678 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3679 base is 2; this is more accurate.
3680
983aeb9a
JB
36812013-06-19 Juanma Barranquero <lekktu@gmail.com>
3682
3683 * sound.c (string_default): Move to !WINDOWSNT section.
3684 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3685
178ba3e6
PE
36862013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3687
bbc51b15
PE
3688 * sound.c: Integer cleanups.
3689 Remove unnecessary forward decls.
3690 (struct sound_device): The 'file' member is now a Lisp_Object, not
3691 a char *, so that we needn't invoke alloca on a huge size.
3692 (Fplay_sound_internal): Adjust to this.
3693 (string_default): New function.
3694 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3695 Use it to adjust to the struct sound_device change.
3696 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3697 (be2hs) [0]: Remove.
3698
178ba3e6
PE
3699 * syntax.c (skip_chars): Don't use uninitialized storage
3700 when searching a multibyte buffer for characters that are not in a
3701 unibyte string that contains non-ASCII characters.
3702
69f60cdc
JD
37032013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3704
3705 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3706 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3707
0d6224d4
PE
37082013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3709
3710 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3711
3c542890
KH
37122013-06-18 Kenichi Handa <handa@gnu.org>
3713
f7e3f7cd
KH
3714 * font.c (Ffont_spec): Signal an error for an invalid font name
3715 (Bug#14648).
3c542890 3716
9349e5f7
PE
37172013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3718
3719 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3720 In particular this ports to 32-bit sparc Sun cc.
3721 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3722 array with a dummy element at specpdl[-1], so that its address can
3723 be taken portably.
3724 (unbind_to): Do not copy the binding; not needed, now that we
3725 copy old_value in the one place where the copy is needed.
3726 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3727 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3728 (union specbinding): Rename from struct specbinding. Redo layout
3729 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3730 which is not portable. With Sun C 5.12 32-bit sparc, the
3731 declaration causes nargs to be an unsigned bitfield, a behavior
3732 that the C standard allows; but Emacs wants nargs to be signed.
3733 The overall type is now a union of structures rather than a
3734 structure of union of structures, and the 'kind' member is now a
3735 bitfield, so that the overall type doesn't grow. All uses changed.
3736 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3737
0a4df6a5
PE
37382013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3739
ec6ecaad
PE
3740 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3741 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3742
0a4df6a5
PE
3743 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3744
7bfe8dbc
EZ
37452013-06-17 Eli Zaretskii <eliz@gnu.org>
3746
3747 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3748 unless we know that the window w's frame is a frame object.
3749 Another attempt at solving bug#14062 and bug#14630.
3750
708e05f6
LMI
37512013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3752
3753 * textprop.c (property_set_type): New enum.
3754 (add_properties): Allow appending/prepending text properties.
3755 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3756 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3757 add_text_properties_1.
3758 (Fadd_face_text_property): New function that calls
3759 add_text_properties_1.
3760
84575e67
PE
37612013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3762
3763 Move functions from lisp.h to individual modules when possible.
3764 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3765 * alloc.c (XFLOAT_INIT, set_symbol_name):
3766 * buffer.c (CHECK_OVERLAY):
3767 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3768 (set_char_table_parent):
3769 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3770 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3771 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3772 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3773 (set_blv_valcell):
3774 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3775 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3776 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3777 (backtrace_args, backtrace_debug_on_exit):
3778 * floatfns.c (CHECK_FLOAT):
3779 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3780 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3781 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3782 (set_hash_index_slot):
3783 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3784 * marker.c (CHECK_MARKER):
3785 * textprop.c (CHECK_STRING_OR_BUFFER):
3786 * window.c (CHECK_WINDOW_CONFIGURATION):
3787 Move here from lisp.h, and make these functions static rather than
3788 extern inline.
3789 * buffer.c (Qoverlayp):
3790 * data.c (Qsubrp):
3791 * fns.c (Qhash_table_p):
3792 * window.c (Qwindow_configuration_p):
3793 Now static.
3794 * lisp.h: Remove the abovementioned defns and decls.
3795
44e18199 3796 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3797 In lisp.h, prefer functions to function-like macros, and
3798 constants to object-like macros, when either will do. This:
3799 . simplifies use, as there's no more need to worry about
3800 arguments' side effects being evaluated multiple times.
3801 . makes the code easier to debug on some platforms.
3802 However, when using gcc -O0, keep using function-like macros
3803 for a few critical operations, for performance reasons.
3804 This sort of thing isn't needed with gcc -Og, but -Og
3805 is a GCC 4.8 feature and isn't widely-enough available yet.
3806 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3807 Remove enum lsb_bits; no longer needed.
3808 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3809 * buffer.c (Qoverlap):
3810 * data.c (Qsubrp):
3811 * fns.c (Qhash_table_p):
3812 Now extern, so lisp.h can use these symbols.
3813 * dispextern.h: Include character.h, for MAX_CHAR etc.
3814 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3815 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3816 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3817 (GLYPH_CODE_P): Move here from lisp.h.
3818 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3819 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3820 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3821 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3822 XUNTAG now returns void *.
3823 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3824 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3825 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3826 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3827 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3828 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3829 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3830 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3831 New macros, renamed from their sans-lisp_h_ counterparts.
3832 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3833 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3834 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3835 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3836 If compiling via GCC without optimization, define these as macros
3837 in addition to inline functions.
3838 To disable this, compile with -DINLINING=0.
3839 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3840 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3841 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3842 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3843 (INTMASK, VALMASK): Now macros, since static values cannot be
3844 accessed from extern inline functions.
3845 (VALMASK): Also a constant, for benefit of old GDB.
3846 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3847 is INTEGERP, which can fold it in.
5165d44a 3848 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3849 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3850 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3851 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3852 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3853 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3854 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3855 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3856 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3857 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3858 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3859 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3860 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3861 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3862 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3863 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3864 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3865 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3866 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3867 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3868 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3869 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3870 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3871 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3872 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3873 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3874 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3875 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3876 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3877 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3878 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3879 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3880 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3881 Now functions.
3882 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3883 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3884 (VALMASK): Define in one place rather than in two, merging the
3885 USE_LSB_TAG parts; this is simpler.
3886 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3887 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3888 Move up, to avoid use before definition.
3889 Also include "globals.h" earlier, for the same reason.
3890 (make_natnum): New function.
3891 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3892 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3893 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3894 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3895 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3896 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3897 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3898 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3899 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3900 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3901 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3902 (Qwindow_configuration_p, Qimage): New forward declarations.
3903 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3904 (STRING_COPYIN): Remove; unused.
3905 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3906 (xcar_addr, xcdr_addr): New functions. All uses changed.
3907 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3908 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3909 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3910 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3911 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3912 (TYPE_RANGED_INTEGERP): Simplify.
3913 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3914 (setlocale, fixup_locale, synchronize_system_messages_locale)
3915 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3916 Now empty functions, not macros.
3917 (functionp): Return bool, not int.
3918 * window.c (Qwindow_configuration_p): Now extern,
3919 so window.h can use it.
3920 * window.h (Qwindowp): Move decl back to lisp.h.
3921
9583ec36
EZ
39222013-06-15 Eli Zaretskii <eliz@gnu.org>
3923
3924 * xdisp.c (Fline_pixel_height): New function, required for solving
3925 bug #14567.
3926
210272ce
PE
39272013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3928
3929 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3930
de0503df
SM
39312013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3932
3933 * lread.c (syms_of_lread):
3934 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3935
afbfe143
KD
39362013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3937
3938 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3939
d177e213
XF
39402013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3941
3942 * fileio.c (expand_file_name): Doc fix.
3943
05e3e412
PE
39442013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3945
f7394b12
PE
3946 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3947 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3948 Wait for self, not for 0. This can't hurt on GNU or similar
3949 system, and may help with Cygwin.
3950
05e3e412
PE
3951 * keyboard.c: Don't use PROP (...) as an lvalue.
3952 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3953 Use set_prop (A, B), not PROP (A) = B.
3954
17dd3097
EZ
39552013-06-10 Eli Zaretskii <eliz@gnu.org>
3956
3957 * xdisp.c (get_it_property): Use it->window instead of generating
3958 a Lisp object from it->w.
3959
52fab9c9
EZ
39602013-06-09 Eli Zaretskii <eliz@gnu.org>
3961
3962 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3963 get-char-property the window that is being rendered, instead of
3964 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3965 (compute_display_string_pos): When W is NULL, use the current
3966 buffer as the object to pass to get-char-property.
3967 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3968 pointer member of the bidi iterator, since no window is pertinent
3969 to this function.
52fab9c9 3970
5bf97bfc
EZ
39712013-06-08 Eli Zaretskii <eliz@gnu.org>
3972
3973 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3974 being displayed, and pass it to compute_display_string_pos.
3975 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3976 (bidi_paragraph_init): All callers changed.
3977
3978 * xdisp.c (init_from_display_pos, init_iterator)
3979 (handle_single_display_spec, next_overlay_string)
3980 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3981 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3982 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3983 (compute_display_string_pos): Accept additional argument, the
3984 window being displayed, and pass it to Fget_char_property.
3985 (Bug#14575)
3986
3987 * dispextern.h (struct bidi_it): New member w, the window being
3988 displayed.
3989 (compute_display_string_pos): Adjust prototype.
3990
5de0e011
JD
39912013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3992
e7b41c4c 3993 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3994
3995 * process.c (wait_reading_process_output): Check for NS before GLIB.
3996 GLIB may be linked in due to rsvg, but ns_select must be called.
3997
5de0e011
JD
3998 * xgselect.c (xg_select): Remove call to window_system_available
3999 and g_main_context_pending at the top, so Gdk events (i.e. file
4000 notify) are processed when Emacs is started with -nw.
4001
a822acff
EZ
40022013-06-07 Eli Zaretskii <eliz@gnu.org>
4003
4004 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4005 (ctagsfiles3): New variable, includes only *.m files.
4006 (TAGS): Use an explicit language name in the regular expressions,
4007 to avoid transformation of '/SOMETHING' by MSYS to
4008 'c:\MSYS\SOMETHING'.
4009
6c0a9ed1
RC
40102013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4011
4012 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4013
9ef6111b
EZ
40142013-06-06 Eli Zaretskii <eliz@gnu.org>
4015
4016 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4017 still need to set the mouse pointer shape and activate help-echo.
4018 (Bug#14558)
4019
7d300d64
PE
40202013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 A few porting etc. fixes for the new file monitor code.
4023 See the thread containing
4024 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4025 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4026 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4027 (dir_monitor_callback, Fgfile_rm_watch):
4028 Use assq_no_quit instead of Fassoc, for speed.
4029 (dir_monitor_callback, Fgfile_rm_watch):
4030 eassert that the monitor is a fixnum.
4031 (dir_monitor_callback): No need for CDR_SAFE.
4032 Simplify building of lisp with alternative tails.
4033 (Fgfile_add_watch, Fgfile_rm_watch):
4034 Do not assume glib functions set errno reliably on failure.
4035 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4036 and signal an error otherwise.
4037 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4038 Use Fdelq instead of Fdelete, for speed.
4039
817ebfcf
EZ
40402013-06-05 Eli Zaretskii <eliz@gnu.org>
4041
4042 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4043 don't insist on being invoked on a highlighted tool-bar button.
4044 Avoids losing tool-bar functionality when mouse-highlight is nil.
4045 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4046 Don't highlight when mouse-highlight is nil.
4047 (note_mouse_highlight): When mouse-highlight is nil, don't return
4048 right away; instead, run tool-bar and mode-line highlight
4049 subroutine, clear any existing highlight, and revert the mouse
4050 pointer to its default shape. (Bug#14558)
4051
55577e7c
SM
40522013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4053
4054 * lisp.mk (lisp): Add prog-mode.el.
4055
f019a684
PE
40562013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4059 * process.c (dummy_handler): New function.
4060 (lib_child_handler): New static var.
4061 (handle_child_signal): Invoke it.
4062 (catch_child_signal): If a library has set up a signal handler,
4063 save it into lib_child_handler.
4064 (init_process_emacs): If using glib and not on Windows, tickle glib's
4065 child-handling code so that it initializes its private SIGCHLD handler.
4066 * syssignal.h (SA_SIGINFO): Default to 0.
4067 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4068 31; it should no longer be needed now.
4069
90db8702
MA
40702013-06-05 Michael Albinus <michael.albinus@gmx.de>
4071
4072 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4073
4074 * gfilenotify.c (globals_of_gfilenotify): New function.
4075 (syms_of_gfilenotify): Move global initialization there.
4076
4077 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4078
bfa3acd6
SM
40792013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4080
4081 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4082 * keyboard.c (menu_bar_items, tool_bar_items):
4083 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4084 not override local keymaps any more.
4085
ba59bd80
EZ
40862013-06-04 Eli Zaretskii <eliz@gnu.org>
4087
4088 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4089
7f203aa1
EZ
40902013-06-03 Eli Zaretskii <eliz@gnu.org>
4091
9337e206
EZ
4092 * w32console.c (initialize_w32_display): Return the dimensions of
4093 the console window via 2 additional arguments, not via the current
4094 frame. This avoids crashes due to overrunning the bounds of
4095 frame's decode_mode_spec_buffer, which is not resized following
4096 the change of the frame dimensions from the initial 10x10.
4097
4098 * w32term.h (w32_initialize_display_info): Adjust prototype.
4099
4100 * term.c (init_tty): Take dimensions of the frame from the values
4101 returned by initialize_w32_display.
4102
7f203aa1
EZ
4103 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4104 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4105 (LIBES): Add $(GFILENOTIFY_LIBS).
4106
4107 * w32inevt.c (handle_file_notifications): Add dummy implementation
4108 for !HAVE_W32NOTIFY.
4109
4110 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4111
55a87246
JD
41122013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4113
4114 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4115
4116 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4117
4118 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4119
3d5ee10a
PE
41202013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4121
4122 Fix minor problems found by static checking.
4123 * data.c (pure_write_error):
4124 Use xsignal2, not Fsignal, as Fsignal might return.
4125 * eval.c (set_backtrace_debug_on_exit): Now static.
4126 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4127 No longer inline. EXTERN_INLINE is needed only for functions
4128 defined in .h files. Reindent function header as per GNU style.
4129 (backtrace_p, backtrace_top, backtrace_next):
4130 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4131 compiler or linker. Add extern decls to pacify gcc -Wall.
4132 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4133 Now static.
4134 * frame.c (free_monitors): Define only on platforms that need it.
4135 * nsterm.m (ns_term_init):
4136 * process.c (catch_child_signal):
4137 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4138 defined on all porting targets these days.
4139 * process.c, process.h (catch_child_signal):
4140 Make it extern only if NS_IMPL_GNUSTEP is defined.
4141
e2d8a6f0
EZ
41422013-06-03 Eli Zaretskii <eliz@gnu.org>
4143
4144 * w32.c (gettimeofday): Make the signature identical to prototype
4145 in nt/inc/sys/time.h.
4146
a8a7c5f6
SM
41472013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4148
4149 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4150 .gdbinit.
4151
4152 * keyboard.c (safe_run_hooks_error): Improve error message.
4153
4154 * data.c (pure_write_error): Add `object' argument.
4155 * puresize.h (CHECK_IMPURE): Use it.
4156
c9628c79
MA
41572013-06-03 Michael Albinus <michael.albinus@gmx.de>
4158
4159 * Makefile.in (NOTIFY_OBJ): New variable.
4160 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4161
4162 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4163 Call syms_of_gfilenotify.
4164
4165 * gfilenotify.c: New file.
4166
4167 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4168 and Qfile_w32notify.
4169 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4170 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4171
4172 * lisp.h: Declare syms_of_gfilenotify.
4173
4174 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4175
2f592f95
SM
41762013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4177
4178 Merge the specpdl and backtrace stacks. Make the structure of the
4179 specpdl entries more obvious via a tagged union of structs.
4180 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4181 (enum specbind_tag): New enum.
4182 (struct specbinding): Make it a tagged union of structs.
4183 Add a case for backtrace records.
4184 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4185 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4186 (backtrace_debug_on_exit): New accessors.
4187 (struct backtrace): Remove.
4188 (struct catchtag): Remove backlist field.
4189 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4190 Move to eval.c.
4191 (Flocal_variable_p): Speed up the common case where the binding is
4192 already loaded.
4193 * eval.c (backtrace_list): Remove.
4194 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4195 (set_backtrace_args, set_backtrace_nargs)
4196 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4197 (backtrace_next): New functions.
4198 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4199 (unwind_to_catch, internal_lisp_condition_case)
4200 (internal_condition_case, internal_condition_case_1)
4201 (internal_condition_case_2, internal_condition_case_n): Don't bother
4202 with backtrace_list any more.
4203 (Fsignal): Adjust to new backtrace format.
4204 (grow_specpdl): Move up.
4205 (record_in_backtrace): New function.
4206 (eval_sub, Ffuncall): Use it.
4207 (apply_lambda): Adjust to new backtrace format.
4208 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4209 data.c.
4210 (specbind): Adjust to new specpdl format. Simplify.
4211 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4212 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4213 backtrace format.
4214 (mark_backtrace): Remove.
4215 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4216 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4217 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4218 Use mark_specpdl.
4219 * profiler.c (record_backtrace): Use get_backtrace.
4220 (handle_profiler_signal): Use backtrace_top_function.
4221 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4222 accessor functions.
4223
c0342369
JD
42242013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4225
4226 * process.h (catch_child_signal): Declare.
4227
4228 * process.c (catch_child_signal): New function.
4229 (init_process_emacs): Call it.
4230
4231 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4232 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4233 NS_IMPL_COCOA.
4234 (x_set_cursor_type): Remove declaration.
4235 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4236 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4237 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4238 (ns_get_color): Use F suffix on float.
4239 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4240 (ns_get_rgb_color): Remove.
4241 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4242 (note_mouse_movement): x and y are CGFloat.
4243 (ns_draw_fringe_bitmap): Remove unused rowY.
4244 Change #if to COCOA && >= 10_6.
4245 (ns_draw_window_cursor): Remove unused overspill.
4246 (ns_draw_underwave): width and x are EamcsCGFloat.
4247 (ns_draw_box): thickness is CGFloat.
4248 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4249 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4250 if not in main thread.
4251 (ns_get_pending_menu_title, ns_check_menu_open)
4252 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4253 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4254 (sendFromMainThread:): New method.
4255 (changeFont:): size is CGFloat.
4256 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4257 Disable warning about permanent text.
4258 (characterIndexForPoint:): Adjust return type depending on GNUStep
4259 version.
4260 (mouseDown:): delta is CGFloat.
4261 (updateFrameSize): Remove unised variable f.
4262 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4263 Cast float to EmacsCGFloat.
4264 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4265 also to -1 when restoring.
4266 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4267 inside NS_IMPL_COCOA.
4268 (toggleFullScreen:): Put call to toggleFullScreen inside
4269 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4270 (setPosition:portion:whole:): por is CGFloat.
4271 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4272 (mouseDown:): Use CGFloat.
4273 (mouseDragged:): Remove unised variable edge.
4274 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4275
4276 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4277 of CGFloat differs.
4278 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4279 when NS_IMPL_GNUSTEP.
4280 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4281 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4282 (EmacsToolbar): Add clearAll. Add tag argument to
4283 addDisplayItemWithImage.
4284 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4285
4286 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4287
4288 * nsmenu.m (ns_update_menubar): Make static.
4289 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4290 (fillWithWidgetValue:): Add cast to SEL for setAction.
4291 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4292 (update_frame_tool_bar): Update code for GNUStep.
4293 (clearAll): New method.
4294 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4295 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4296 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4297 call to insertItemWithItemIdentifier.
4298 (validateVisibleItems): Fix indentation.
4299 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4300 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4301 UtilityWindow to aStyle, remove call to setStyleMask.
4302
4303 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4304
4305 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4306 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4307 Use F suffix on floats.
4308 (ns_char_width): Returns CGFloat.
4309 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4310 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4311 DPSxshow.
4312 (ns_glyph_metrics): CGFloat instead of float.
4313
a0eb10b3
JB
4314 * nsfns.m (x_set_foreground_color, x_set_background_color):
4315 Use EmacsCGFloat.
4316 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4317 remove unused variables.
4318 (Fns_read_file_name): Keep track if panel is for save.
4319 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4320 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4321 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4322 Just return the input if GNUStep.
c0342369
JD
4323 (x_screen_planes): Remove.
4324 (Fxw_color_values): Use EmacsCGFloat
4325 (Fns_display_monitor_attributes_list): Only get screen number for
4326 Cocoa.
ef099a94 4327 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4328 EmacsSavePanel.
4329 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4330 ns_directory_from_panel.
4331
da9aff11
PE
43322013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 * process.c (handle_child_signal): Also use WCONTINUED.
4335 This is so that list-processes doesn't mistakenly list the process
4336 as stopped, when the process has actually been continued and is
4337 now running.
4338
0e64479a
PE
43392013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4340
fc186a96
PE
4341 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4342 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4343 not already configured.
4344
0e64479a
PE
4345 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4346
38b787fa
EZ
43472013-05-29 Eli Zaretskii <eliz@gnu.org>
4348
4349 * Makefile.in (mostlyclean): Remove *.res files.
4350
22513e52
SM
43512013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4352
4353 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4354 a buffer (bug#8447).
4355
6ef3db10
EZ
43562013-05-27 Eli Zaretskii <eliz@gnu.org>
4357
4358 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4359 display vector, and we backtrack, handle the case that the
4360 previous character position is also displayed from a display
4361 vector or covered by a display string or image. (Bug#14476)
4362
6799bb26
JD
43632013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4364
4365 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4366 (struct MonitorInfo, free_monitors): Remove.
4367 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4368 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4369 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4370 Qframes, Qsource.
4371
4372 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4373 (struct MonitorInfo, free_monitors): Remove.
4374 (ns_screen_name): Make static.
4375 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4376 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4377 Qframes, Qsource.
4378
4379 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4380 (struct MonitorInfo): New struct.
4381 (free_monitors, make_monitor_attribute_list): Declare.
4382
22513e52
SM
4383 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4384 New Lisp_Object:s.
6799bb26
JD
4385 (free_monitors, make_monitor_attribute_list): New functions.
4386 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4387 Qsource.
4388
38cd43eb
XF
43892013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4390
4391 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4392
2af0948d
SM
43932013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4394
a7eb9b0f
SM
4395 * keyboard.c: Apply keyboard decoding only to events that come directly
4396 from the tty, not from unread-command-events (bug#14368).
4397 (read_event_from_main_queue): New function, extracted from read_char).
4398 (read_decoded_char): Remove.
4399 (read_decoded_event_from_main_queue): New function to replace it.
4400 (read_char): Use it.
4401 (read_key_sequence): Use read_char rather than read_decoded_char.
4402
2af0948d
SM
4403 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4404
1413e9a5
BR
44052013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4406
4407 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4408
e6d2f155
KH
44092013-05-22 Kenichi Handa <handa@gnu.org>
4410
4411 The following changes are to fix the setting of
4412 buffer-file-coding-system on, for instance, C-x RET c unix RET
4413 _FILE_OF_DOS_EOL_TYPE_ RET.
4414
4415 * coding.h (struct coding_system): New member detected_utf8_chars.
4416
4417 * coding.c (detect_coding_utf_8): Count characters and check EOL
4418 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4419 BOM is there.
4420 (setup_coding_system): Do not initialize coding->head_ascii.
4421 (check_ascii): Do not set coding->eol_seen but update it. Do not
4422 call adjust_coding_eol_type here.
1413e9a5
BR
4423 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4424 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4425 of the found coding-system.
4426 (decode_coding_gap): Cancel previous change. Utilize the
4427 character numbers counted by detect_coding_utf_8. Fix detection
4428 of BOM for utf-8.
4429
ab56a6f4 44302013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4431
4432 * search.c (looking_at_1): Only set last_thing_searched if the match
4433 changed the match-data (bug#14281).
4434
ecc3c6ed
DA
44352013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4436
4437 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4438 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4439 (move_it_vertically_backward): Likewise.
4440
5ba8bf35
YM
44412013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4442
4443 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4444 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4445 (Fx_display_mm_width, Fx_display_mm_height):
4446 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4447
91e8418b 4448 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4449 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4450 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4451 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4452 (Fx_display_backing_store, Fx_display_visual_class)
4453 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4454 (Fx_display_grayscale_p, Fx_display_pixel_width)
4455 (Fx_display_pixel_height, Fx_display_planes)
4456 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4457 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4458 (Fx_display_mm_width, Fx_display_mm_height)
4459 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4460 height for all physical monitors as in X11.
4461
fc30d803
SM
4462 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4463 Return pixel width or height for all physical monitors as in X11.
91e8418b 4464
31ff141c
PE
44652013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4466
4467 Port --enable-gcc-warnings to clang.
4468 * bytecode.c (exec_byte_code):
4469 * regex.c:
4470 Redo diagnostic pragmas to pacify clang, too.
4471 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4472 * editfns.c (Fencode_time):
4473 * fileio.c (file_accessible_directory_p):
4474 * font.c (font_unparse_xlfd):
4475 Use '&"string"[index]' instead of '"string" + (index)'.
4476 * undo.c (user_error): Remove; unused.
4477
df065a0b
EZ
44782013-05-16 Eli Zaretskii <eliz@gnu.org>
4479
04d360e7
EZ
4480 * insdel.c (insert_1_both): Document the arguments, instead of
4481 referring to insert_1, which no longer exists.
4482
5bb98290
EZ
4483 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4484 some window, increment windows_or_buffers_changed, so that
4485 *Messages* display in that window is updated. (Bug#14408)
4486
df065a0b
EZ
4487 * w32.c: Include epaths.h.
4488 (init_environment): Use cmdproxy.exe without leading directories.
4489 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4490 case.
4491 (gettimeofday): Adjust signature and return value to Posix
4492 expectations.
4493
4494 * unexw32.c (open_output_file): Delete the existing emacs.exe
4495 before creating it, to break the hard link to the versioned
4496 executable.
4497
4498 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4499 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4500 (FIRSTFILE_OBJ): New variables.
4501 (W32_RES): Rename to EMACSRES. All users changed.
4502 (base_obj): Use $(CM_OBJ).
4503 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4504 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4505 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4506 $(W32_RES_LINK) before $(LIBES).
4507 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4508
1aa8d505
SM
45092013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4510
6e911150
SM
4511 * makefile.w32-in (DOC): Use just "DOC".
4512
4513 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4514
1aa8d505
SM
4515 * process.c: Export default filters and sentinels to Elisp.
4516 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4517 New constants.
4518 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4519 (Fset_process_sentinel, Fformat_network_address):
4520 Default to them instead of nil.
4521 (server_accept_connection): Sentinels can't be nil any more.
4522 (read_and_dispose_of_process_output): New function, extracted from
4523 read_process_output.
4524 (read_process_output): Use it; filters can't be nil.
4525 (Finternal_default_process_filter): New function, extracted from
4526 read_process_output.
4527 (exec_sentinel_unwind): Remove function.
4528 (exec_sentinel): Don't zilch sentinel while running.
4529 (status_notify): Sentinels can't be nil.
4530 (Finternal_default_process_sentinel): New function extracted from
4531 status_notify.
4532 (setup_process_coding_systems): Default filter is not nil any more.
4533 (syms_of_process): Export new Elisp functions and initialize
4534 new constants.
4535 * lisp.h (make_lisp_proc): New function.
4536
5ac2eb34
SM
45372013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4538
4539 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4540
eda9c7d7
EZ
45412013-05-14 Eli Zaretskii <eliz@gnu.org>
4542
4543 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4544 unless we know that the window w is a leaf window.
4545 Another attempt at solving bug#14062.
eda9c7d7 4546
8fdeaad5
JD
45472013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4548
4549 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4550 fdesc (Bug#14375).
4551
44aa9ee6
PE
45522013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4553
4554 * image.c (gif_load): Check that subimages fit (Bug#14345).
4555
759fd763
SM
45562013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4557
4558 * lread.c (skip_dyn_eof): New function.
4559 (read1): Use it to skip the end of a file in response to #@00.
4560
4561 * doc.c (get_doc_string): Slightly relax the sanity checking.
4562
4465bfb4
JD
45632013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4564
4565 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4566 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4567 (MonitorInfo): New struct.
4568 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4569 (Fns_display_monitor_attributes_list): New functions.
4570 (display-usable-bounds): Remove.
4571 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4572 Qsource.
4573
7583e2a0
PE
45742013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4575
4576 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4577 (GTK_CHECK_VERSION): New macro, if not already defined.
4578 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4579 replaced by GTK_CHECK_VERSION.
4580
ad75d77e
PE
45812013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4582
4583 * xterm.h (GTK_PREREQ): New macro.
4584 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4585 to use this macro instead, for consistency and clarity.
4586
07525f77
EZ
45872013-05-08 Eli Zaretskii <eliz@gnu.org>
4588
4589 * xdisp.c (row_for_charpos_p): New function, with code of
4590 cursor_row_p, but accepts an additional argument CHARPOS instead
4591 of using a hardcoded PT.
4592 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4593 (row_containing_pos): Call row_for_charpos_p instead of partially
4594 doing the same. Fixes cursor positioning under longlines-mode
4595 when longlines-show-effect includes more than one newline, when
4596 moving the cursor vertically up.
4597
d901fc8d
JB
45982013-05-08 Juanma Barranquero <lekktu@gmail.com>
4599
4600 * makefile.w32-in (ACL_H): New macro.
4601 ($(BLD)/fileio.$(O)): Update dependencies.
4602
f269bc61
PE
46032013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4604
e7b41c4c 4605 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4606 * Makefile.in (LIB_ACL): New macro.
4607 (LIBACL_LIBS): Remove.
4608 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4609 * fileio.c: Include <acl.h>.
4610 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4611 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4612 !acl_errno_valid.
4613 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4614 it ourselves.
4615
f269bc61
PE
4616 * unexelf.c: Don't assume ElfW (Half) fits in int.
4617 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4618 when dealing with ElfW (Half) values, since they can exceed 2**31
4619 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4620 (entry_address): Omit unused NUM arg. All uses changed.
4621
a261c53e
JL
46222013-05-07 Juri Linkov <juri@jurta.org>
4623
4624 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4625 to the string converted from number with `Fnumber_to_string'.
4626 (Bug#14254)
4627
2b66427d
PE
46282013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4629
4630 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4631 This fixes a problem introduced by my previous change.
4632
15acfe41
GM
46332013-05-07 Glenn Morris <rgm@gnu.org>
4634
4635 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4636
5ea03bf5
JD
46372013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4638
4639 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4640
e0c9d565
PE
46412013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 Static checking by GCC 4.8.0.
4644 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4645 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4646 (x_get_monitor_attributes_fallback)
4647 (x_get_monitor_attributes_xinerama)
4648 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4649 Define only if USE_GTK.
4650 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4651 (x_get_monitor_attributes_fallback): Omit unused locals.
4652 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4653 Use double, not float, to avoid mixed-mode floating point arithmetic.
4654
4e3f9230
YM
46552013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4656 Jan Djärv <jan.h.d@swipnet.se>
4657
4658 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4659 (XINERAMA_CFLAGS): New macros.
4660 (ALL_CFLAGS, LIBES): Use them.
4661
4662 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4663 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4664 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4665 (syms_of_xfns): DEFSYM them.
4666 (struct MonitorInfo): New struct.
4667 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4668 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4669 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4670 (x_get_monitor_attributes_xinerama): New functions.
4671 (Fx_display_monitor_attributes_list): New primitive.
4672 (syms_of_xfns): Defsubr it.
4673
4674 * xterm.h (x_display_info): Add Xatom_net_workarea and
4675 Xatom_net_current_desktop.
4676
4677 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4678 and dpyinfo->Xatom_net_current_desktop.
4679
05839b6a
EZ
46802013-05-06 Eli Zaretskii <eliz@gnu.org>
4681
4682 * xdisp.c (pos_visible_p): Use the special code for finding the
4683 beginning of a display property or overlay for any "replacing"
4684 display property, not just for display strings. This solves
4685 incorrect reporting of position by posn-at-point. (Bug#14241)
4686
dc4a2ee0
PE
46872013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4688
5ee94506
PE
4689 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4690 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4691 Verify that ElfW (Half) fits in int.
4692 (fatal): Use same signature as lisp.h.
4693 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4694 configure and build with -DUNEXELF_DEBUG without worrying about
4695 other modules that use DEBUG.
4696 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4697 possibly-wide integers now uses it instead of plain fprintf.
4698 (entry_address): New function, which avoids problems with 32-bit
4699 overflow on 64-bit hosts.
4700 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4701 (round_up): Don't assume the remainder fits in int.
4702 (find_section): Use bool for boolean. Simplify debug code.
4703 (unexec): Don't assume file sizes fit in int or size_t.
4704 Omit unnecessary trailing newline in 'fatal' format.
4705 Use strerror rather than outputting decimal error number.
4706 Remove unused code when emacs is not defined;
4707 this file relies on Emacs now.
4708 Don't assume e_phnum and e_shnum are positive.
4709
dc4a2ee0
PE
4710 * regex.c: Fix problems when DEBUG is defined.
4711 (extract_number, extract_number_and_incr): Define regardless of
4712 whether DEBUG is defined; that's simpler and makes the code less
4713 likely to go stale in the normal case when DEBUG is not defined.
4714 Return int rather than taking an int * arg. All callers changed.
4715 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4716 Remove, replacing with ...
4717 (DEBUG_PRINT): New macro. All callers changed.
4718 (DEBUG_COMPILES_ARGUMENTS): New macro.
4719 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4720 (print_compiled_pattern, print_double_string) [DEBUG]:
4721 Use prototype rather than old-style definition.
4722 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4723 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4724 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4725 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4726 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4727 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4728 This matters only when DEBUG is defined.
4729
14c7ed05
EZ
47302013-05-05 Eli Zaretskii <eliz@gnu.org>
4731
4732 * xdisp.c (set_iterator_to_next): Set the
4733 ignore_overlay_strings_at_pos_p flag only if we are _really_
4734 iterating over an overlay string, as indicated by the
4735 current.overlay_string_index member. (Bug#14306)
4736
e6076b1b
JD
47372013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4738
4739 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4740 to where it is used, to avoid autorelease issues (Bug#14050).
4741
cbee2131
PE
47422013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4743
4744 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4745 * fileio.c (syms_of_fileio): Implement this.
4746 * filelock.c (create_lock_file): If symbolic links don't work, so
4747 we use a regular file as a lock file, do not fsync the lock file;
4748 it's not needed.
4749
30c7e542
SM
47502013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4751
4752 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4753 (syms_of_minibuf): Adjust accodingly.
4754 * lread.c (Fread):
4755 * callint.c (Fcall_interactively): Adjust calls accordingly.
4756
5bebd186
EZ
47572013-05-04 Eli Zaretskii <eliz@gnu.org>
4758
4759 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4760 w->contents is a buffer before computing everything else.
4761 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4762
4763 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4764 assertion violations. (Bug#14062)
4765
0fb0a4f3
DR
47662013-05-01 David Reitter <david.reitter@gmail.com>
4767
4768 * nsfns.m (ns_tooltip): Initialize.
4769
9e63b4a5
EZ
47702013-04-28 Eli Zaretskii <eliz@gnu.org>
4771
4772 * coding.c (decode_coding_gap): Don't remove the character before
4773 a newline unless it's a CR character. (Bug#14287)
4774
ad60824e
DN
47752013-04-28 Dan Nicolaescu <dann@gnu.org>
4776
4777 * dispextern.h (struct face): Move enum face_underline_type
4778 earlier so that bitfields can be in the same word.
4779
edbdcec0
JD
47802013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4781
4782 * nsfns.m (handlePanelKeys): New function.
4783 (EmacsOpenPanel:performKeyEquivalent:)
4784 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4785 arrows/function/control and copy/paste keys (Bug#14296).
4786
0208ede7
JL
47872013-04-27 Juri Linkov <juri@jurta.org>
4788
4789 * callint.c (Fcall_interactively): Call `Qread_number' for
4790 interactive code letter `n' instead of using duplicate code.
4791 (Bug#14254)
4792
b8dd59f7
PE
47932013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4794
4795 * systime.h (make_timeval): Declare as 'const'.
4796
8bd722db
KH
47972013-04-27 Kenichi Handa <handa@gnu.org>
4798
4799 * font.c (font_open_entity): Always open a font of manageable
4800 size.
4801
13d0e56f 48022013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4803
f780d632
PE
4804 Port better to AIX (Bug#14258).
4805 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4806 to pacify AIX xlc.
4807
ec509856
KH
48082013-04-24 Kenichi Handa <handa@gnu.org>
4809
4810 * coding.c (decode_coding_iso_2022): When an invalid escape
4811 sequence is encountered, reset the invocation and designation
4812 status to the safest one.
4813
84fc48e5
PE
48142013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4815
4816 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4817 Without this fix, "make distclean" leaves stamp-h1 behind.
4818
806bda47
EC
48192013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4820
4821 * w32fns.c (w32_fullscreen_rect): New function to compute the
4822 window rectangle for the given fullscreen mode.
4823 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4824 longer tunes the window size. This keeps the window's edges flush
4825 with the screen and allows the taskbar to hide itself in fullboth.
4826
4827 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4828 window decorations and uses the entire screen.
4829
4830 * w32term.h (w32_fullscreen_rect) Add prototype.
4831 (struct w32_output): Replace normal_width, normal_height,
4832 normal_top, and normal_left members with a single normal_placement
4833 struct.
4834 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4835 Remove macros.
4836 (FRAME_NORMAL_PLACEMENT): New macro.
4837
9cc2810b
JB
48382013-04-16 Juanma Barranquero <lekktu@gmail.com>
4839
4840 * minibuf.c (Ftest_completion): Silence compiler warning.
4841
fd16b54c
EZ
48422013-04-15 Eli Zaretskii <eliz@gnu.org>
4843
4844 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4845 bug#14062.
fd16b54c
EZ
4846
4847 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4848 parentheses.
4849
4850 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4851 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4852 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4853 parentheses where appropriate.
4854
9e3379a0
PE
48552013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4856
4857 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4858
ddd6b685
EZ
48592013-04-14 Eli Zaretskii <eliz@gnu.org>
4860
4861 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4862 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4863 Mention in the doc string that setting these variables takes
4864 effect only after a call to set-window-buffer. (Bug#14200)
4865
29b79ba1
EZ
48662013-04-13 Eli Zaretskii <eliz@gnu.org>
4867
4868 * indent.c (Fvertical_motion): Don't consider display strings on
4869 overlay strings as display strings on the buffer position we
4870 started from. This prevents vertical cursor motion from jumping
4871 more than one line when there's an overlay string with a display
4872 property at end of line.
4873 Reported by Karl Chen <Karl.Chen@quarl.org> in
4874 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4875
562c6ee9
SM
48762013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4877
4878 * window.c (select_window): `record_buffer' even if window is
4879 already selected (bug#14191).
4880
fcc1fe85
EZ
48812013-04-11 Eli Zaretskii <eliz@gnu.org>
4882
4883 * window.c (Fwindow_end): Test more flags, including the buffer's
4884 last_overlay_modified flag, to determine whether the window's
4885 display is really up-to-date. Prevents the function from
4886 returning a stale value. (Bug#14170)
4887 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4888 current matrix.
4889
f009190a
EZ
48902013-04-10 Eli Zaretskii <eliz@gnu.org>
4891
4892 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4893 garbaged only if it is not already the top frame on its TTY.
4894 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4895 there are GUI frames open in the same session. (Bug#13864)
4896
78ce603d
SM
48972013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4898
4899 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4900 of marking the idle timers directly.
4901
a8036e40
SM
49022013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4903
4904 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4905 tables (bug#14054).
4906
7ffe7ef6
SM
49072013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4908
4909 * window.c (select_window): Don't record_buffer while the invariant is
4910 temporarily broken (bug#14161).
4911
4912 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4913
7d9f6883
EZ
49142013-04-07 Eli Zaretskii <eliz@gnu.org>
4915
4916 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4917
5406cfd9
RF
49182013-04-07 Romain Francoise <romain@orebokech.com>
4919
4920 Ignore additional platform-specific ACL errors (Bug#13702).
4921 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4922 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4923
95c0e83b
JD
49242013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4925
4926 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4927 f->output_data.ns.
4928
876da980
PE
49292013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4930
4931 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4932 This bug was introduced by my 2013-02-25 change that simplified
4933 data_start configuration. Without this change, on GNU/Linux
4934 an Emacs configured with --enable-profiling fails immediately
4935 due to a profiler signal.
4936 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4937 with these flags. On platforms where special flags are needed
4938 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4939 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4940 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4941
7452b7bd
DA
49422013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4943
4944 Get rid of some platform-specific functions examining window
4945 system and its capabilities. This is a partial rework of the
4946 2013-04-05 change.
4947 * lisp.h (have_menus_p): Remove prototype. This function is
4948 replaced with platform-independent window_system_available.
4949 (check_window_system): Move to...
4950 * frame.h (decode_window_system_frame, window_system_available):
4951 ...here, add new prototypes.
4952 * frame.c (window_system_available, decode_window_system_frame):
4953 New functions.
4954 (check_window_system): Platform-independent now.
4955 * xterm.h (x_in_use): Remove declaration.
4956 (check_x_frame):
4957 * w32term.h (check_x_frame):
4958 * nsterm.h (check_x_frame): Remove prototypes. This function
4959 is replaced with platform-independent decode_window_system_frame.
4960 * msdos.c (have_menus_p): Remove.
4961 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4962 Remove platform-specific functions. Use check_window_system,
4963 decode_window_system_frame and check_ns_display_info where
4964 appropriate. Minor style and comment tweaks.
4965 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4966 (check_x_frame): Likewise.
4967 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4968 Likewise.
4969 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4970 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4971 * xmenu.c, xselect.c: All related users changed.
4972
251e9147
KH
49732013-04-03 Kenichi Handa <handa@gnu.org>
4974
4975 The following changes is to optimize the code for reading UTF-8
4976 files.
4977
562c6ee9 4978 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4979 changed. Check EOL format. Do not call adjust_coding_eol_type
4980 here.
4981 (check_utf_8): New function.
4982 (adjust_coding_eol_type): Do nothing if already adjusted.
4983 (detect_coding): Compare the return value of check_ascii with
4984 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4985 (decode_coding_gap): Optimize for valid UTF-8.
4986
8bc369d4
KH
49872013-03-21 Kenichi Handa <handa@gnu.org>
4988
4989 * coding.c (syms_of_coding): Cancel previous change.
4990
4991 * insdel.c (insert_from_gap): Fix previous change.
4992
73931ad1
DA
49932013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4994
4995 Consistently use platform-specific function to detect window system.
4996 * lisp.h (check_window_system): New prototype. This function is
4997 going to replace check_x, check_w32 and check_ns.
4998 (have_menus_p): Mention msdos.c in comment.
4999 * fontset.c (check_window_system_func): Remove. Adjust all users.
5000 * fontset.h (check_window_system_func): Remove prototype.
5001 * nsterm.h (check_ns):
5002 * xterm.h (check_x):
5003 * w32term.h (check_w32): Likewise.
5004 * menu.c (Fx_popup_menu): Use check_window_system.
5005 * msdos.c (check_window_system): Define for MS-DOS.
5006 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5007 * w32fns.c (check_window_system): Likewise for MS-Windows.
5008 * xfns.c (check_window_system): Likewise for X.
5009 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5010 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5011
7216e43b
PE
50122013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5013
5014 Prefer < to > in range checks such as 0 <= i && i < N.
5015 This makes it easier to visualize quantities on a number line.
5016 This patch doesn't apply to all such range checks,
5017 only to the range checks affected by the 2013-03-24 change.
5018 This patch reverts most of the 2013-03-24 change.
5019 * alloc.c (xpalloc, Fgarbage_collect):
5020 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5021 * character.c (string_escape_byte8):
5022 * charset.c (read_hex):
5023 * data.c (cons_to_unsigned):
5024 * dispnew.c (update_frame_1):
5025 * doc.c (Fsubstitute_command_keys):
5026 * doprnt.c (doprnt):
5027 * editfns.c (hi_time, decode_time_components):
5028 * fileio.c (file_offset):
5029 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5030 * font.c (font_intern_prop):
5031 * frame.c (x_set_alpha):
5032 * gtkutil.c (get_utf8_string):
5033 * indent.c (check_display_width):
5034 * keymap.c (Fkey_description):
5035 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5036 * lread.c (read1):
5037 * minibuf.c (read_minibuf_noninteractive):
5038 * process.c (wait_reading_process_output):
5039 * search.c (Freplace_match):
5040 * window.c (get_phys_cursor_glyph):
5041 * xdisp.c (redisplay_internal):
5042 * xsmfns.c (smc_save_yourself_CB):
5043 Prefer < to > for range checks.
5044 * dispnew.c (sit_for): Don't mishandle NaNs.
5045 This fixes a bug introduced in the 2013-03-24 change.
5046 * editfns.c (decode_time_components): Don't hoist comparison.
5047 This fixes another bug introduced in the 2013-03-24 change.
5048
92759988
DA
50492013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5050
5051 * frame.h (struct frame): Drop scroll_bottom_vpos
5052 member becaue all real users are dead long ago.
5053 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5054 * xdisp.c (redisplay_internal): Adjust user.
5055
9a1971bb
GM
50562013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5057
f38ab167
JD
5058 * nsmenu.m (showAtX:Y:for:): setLevel to
5059 NSPopUpMenuWindowLevel (Bug#13998).
5060
6d01f1fe
JD
50612013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5062
5063 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5064 (ns_check_pending_open_menu): Declare.
5065
5066 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5067 (x_activate_menubar): Update the menu with title that matches
5068 ns_get_pending_menu_title, and call
5069 ns_check_pending_openmenu (Bug#12698).
5070 (menuWillOpen:): New method.
5071 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5072
5073 * nsterm.m (menu_will_open_state, menu_mouse_point)
5074 (menu_pending_title): New varaibles.
5075 (ns_get_pending_menu_title, ns_check_menu_open)
5076 (ns_check_pending_open_menu): New functions.
5077
781f4782
DA
50782013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5079
5080 * indent.c (current_column_bol_cache): Remove leftover which is not
5081 used in Fmove_to_column any more.
5082 (current_column, scan_for_column): Adjust users.
5083 * keyboard.c (last_point_position_buffer, last_point_position_window):
5084 Remove leftovers which are not used for recording undo any more.
5085 (command_loop_1, syms_of_keyboard): Adjust users.
5086 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5087 redisplay_window any more.
5088 (move_it_to): Adjust user.
5089
1921c31b
JB
50902013-03-29 Juanma Barranquero <lekktu@gmail.com>
5091
5092 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5093 Update dependencies.
5094
717b8bcd
SM
50952013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5096
5097 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5098 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5099 forward references.
5100
e74aeda8
DA
51012013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5102
5103 * window.h (struct window): Replace hchild, vchild and buffer slots
5104 with the only contents slot. This is possible because each valid
5105 window may have either the child window (in vertical or horizontal
5106 combination) or buffer to display (for the leaf window). Using that,
5107 a lof of operations to traverse and/or change window hierarchies may
5108 be simplified. New member horizontal is used to distinguish between
5109 horizontal and vertical combinations of internal windows.
5110 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5111 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5112 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5113 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5114 Use contents slot, not buffer, where appropriate.
5115 (wset_combination): New function.
5116 (wset_buffer): Add eassert.
5117 (Fframe_first_window): Simplify the loop reaching first window.
5118 (Fwindow_buffer): Use WINDOW_LEAF_P.
5119 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5120 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5121 (unshow_buffer): Convert initial debugging check to eassert.
5122 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5123 (make_parent_window, window_resize_check, window_resize_apply)
5124 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5125 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5126 Adjust to match struct window changes.
5127 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5128 (mark_window_cursors_off, count_windows, get_leaf_windows)
5129 (foreach_window_1): Simplify the loop.
5130 * alloc.c (mark_object): Do not check for the leaf window because
5131 internal windows has no glyph matrices anyway.
5132 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5133 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5134 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5135 (build_frame_matrix_from_window_tree, mirror_make_current)
5136 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5137 (update_window_tree, set_window_update_flags): Simplify the loop.
5138 (sync_window_with_frame_matrix_rows): Enforce live window.
5139 Use contents slot, not buffer, where appropriate.
5140 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5141 and WINDOW_HORIZONTAL_COMBINATION_P.
5142 (make_frame_visible_1): Simplify the loop.
5143 Use contents slot, not buffer, where appropriate.
5144 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5145 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5146 (expose_window_tree): Likewise.
5147 Use contents slot, not buffer, where appropriate.
5148 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5149 to avoid deleted windows. Use contents slot instead of buffer.
5150 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5151 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5152 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5153 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5154
121ab1cd
EZ
51552013-03-28 Eli Zaretskii <eliz@gnu.org>
5156
ef454cf7
EZ
5157 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5158 identify the reasons for assertion violations in bug#14062 and
5159 similar ones.
21e930f8
EZ
5160 (Fx_show_tip): Fix compilation error under
5161 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5162
121ab1cd
EZ
5163 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5164 Reported by <rzl24ozi@gmail.com>.
5165
5c89ca24
DA
51662013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5167
5168 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5169 start marker...
562c6ee9
SM
5170 (unwind_with_echo_area_buffer): ...to restore it here.
5171 This is needed to ensure that...
5c89ca24
DA
5172 (redisplay_window): ...both window markers are valid here,
5173 which is verified by eassert.
5174 * editfns.c (save_excursion_save): Do not assume that
5175 selected_window always displays the buffer.
c7f53895
DA
5176 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5177 Fix comment.
5c89ca24 5178
f557c1b1
SM
51792013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5180
5181 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5182 the upcase table.
5183
40693bba 51842013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5185
5186 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5187
c86f791f
EZ
51882013-03-27 Eli Zaretskii <eliz@gnu.org>
5189
5190 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5191 since MinGW's w32api headers do. This avoids compiler warnings.
5192
5193 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5194 if already defined.
5195
c6e72e17
EZ
51962013-03-26 Eli Zaretskii <eliz@gnu.org>
5197
5198 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5199
54e95010
JD
52002013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5201
5202 * gtkutil.c (style_changed_cb): Check if frame is live and an
5203 X frame (Bug#14038).
5204
b88b62de
EZ
52052013-03-26 Eli Zaretskii <eliz@gnu.org>
5206
a18d7de6
EZ
5207 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5208 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5209 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5210 MinGW64.
8f5e14c8
EZ
5211 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5212 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5213
b88b62de
EZ
5214 Fix incompatibilities between MinGW.org and MinGW64 headers.
5215 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5216
5217 * w32.c (REPARSE_DATA_BUFFER): Guard with
5218 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5219
c074e458
JD
52202013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5221
5222 * xterm.c: Include X11/XKBlib.h
5223 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5224
908589fd
AS
52252013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5226
5227 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5228 written backwards.
5229 * blockinput.h (input_blocked_p): Likewise.
5230 * bytecode.c (exec_byte_code): Likewise.
5231 * callproc.c (call_process_kill, call_process_cleanup)
5232 (Fcall_process): Likewise.
5233 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5234 (Fccl_execute_on_string): Likewise.
5235 * character.c (string_escape_byte8): Likewise.
5236 * charset.c (read_hex): Likewise.
5237 * cm.c (calccost): Likewise.
5238 * data.c (cons_to_unsigned): Likewise.
5239 * dired.c (directory_files_internal, file_name_completion):
5240 Likewise.
5241 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5242 (sit_for): Likewise.
5243 * doc.c (Fsubstitute_command_keys): Likewise.
5244 * doprnt.c (doprnt): Likewise.
5245 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5246 * emacsgtkfixed.c: Likewise.
5247 * fileio.c (file_offset, Fwrite_region): Likewise.
5248 * floatfns.c (Fexpt, fmod_float): Likewise.
5249 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5250 Likewise.
5251 * font.c (font_intern_prop): Likewise.
5252 * frame.c (x_set_alpha): Likewise.
5253 * gtkutil.c (get_utf8_string): Likewise.
5254 * indent.c (check_display_width): Likewise.
5255 * intervals.c (create_root_interval, rotate_right, rotate_left)
5256 (split_interval_right, split_interval_left)
5257 (adjust_intervals_for_insertion, delete_node)
5258 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5259 (merge_interval_right, merge_interval_left, copy_intervals)
5260 (set_intervals_multibyte_1): Likewise.
5261 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5262 * keymap.c (Fkey_description): Likewise.
5263 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5264 * lread.c (openp, read_integer, read1, string_to_number):
5265 Likewise.
5266 * menu.c (ensure_menu_items): Likewise.
5267 * minibuf.c (read_minibuf_noninteractive): Likewise.
5268 * print.c (printchar, strout): Likewise.
5269 * process.c (create_process, Faccept_process_output)
5270 (wait_reading_process_output, read_process_output, send_process)
5271 (wait_reading_process_output): Likewise.
5272 * profiler.c (make_log, handle_profiler_signal): Likewise.
5273 * regex.c (re_exec): Likewise.
5274 * regex.h: Likewise.
5275 * search.c (looking_at_1, Freplace_match): Likewise.
5276 * sysdep.c (get_child_status, procfs_ttyname)
5277 (procfs_get_total_memory): Likewise.
5278 * systime.h (EMACS_TIME_VALID_P): Likewise.
5279 * term.c (dissociate_if_controlling_tty): Likewise.
5280 * window.c (get_phys_cursor_glyph): Likewise.
5281 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5282 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5283 Likewise.
5284 * xfns.c (Fx_window_property): Likewise.
5285 * xmenu.c (set_frame_menubar): Likewise.
5286 * xselect.c (x_get_window_property, x_handle_dnd_message):
5287 Likewise.
5288 * xsmfns.c (smc_save_yourself_CB): Likewise.
5289 * xterm.c (x_scroll_bar_set_handle): Likewise.
5290
2bf7d27a
DA
52912013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5292
5293 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5294 to be optional or nil. Adjust comment and convert it to docstring.
5295 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5296 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5297
a9ebfa0b
PE
52982013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5299
5300 Static checking by GCC 4.8-20130319.
5301 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5302 * process.c (Fset_process_datagram_address)
5303 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5304 * xdisp.c (get_char_face_and_encoding):
5305 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5306 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5307 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5308
4f3576ee
KB
53092013-03-24 Ken Brown <kbrown@cornell.edu>
5310
789b5e9a
KB
5311 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5312 fix compilation on 64-bit Cygwin, where underscores are not
5313 automatically prepended.
5314
4f3576ee
KB
5315 * w32term.c (w32_initialize): Silence compiler warning.
5316
b5b7745f
EZ
53172013-03-23 Eli Zaretskii <eliz@gnu.org>
5318
cdc0d0bd
EZ
5319 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5320 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5321 variables, to save and restore frame dimensions.
5322 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5323 after returning from a 'fullscreen' configuration.
5324 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5325 to avoid races between the main thread and the input thread.
5326
5327 * w32term.h (struct w32_output): New members normal_width,
5328 normal_height, normal_top, normal_left, and prev_fsmode.
5329 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5330 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5331 members of a frame.
5332
b5b7745f
EZ
5333 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5334 'fullscreen' parameter. Always record previous width and height
5335 of the frame, except when switching out of maximized modes, so
5336 that they could be restored correctly, instead of resetting to the
5337 default frame dimensions. Send SC_RESTORE command to the frame,
5338 unless we are going to send SC_MAXIMIZE, to restore the frame
5339 resize hints in the mouse pointer shown by the window manager.
5340 (Bug#14032)
5341
5342 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5343
5344 * lisp.h (get_frame_param): Adjust conditions for prototype
5345 declaration.
5346
a3454eed
KB
53472013-03-22 Ken Brown <kbrown@cornell.edu>
5348
5349 * unexcw.c: Drop unneeded inclusion of w32common.h.
5350 (report_sheap_usage): Declare.
5351 (read_exe_header): Add magic numbers for x86_64.
5352 (fixup_executable): Fix printf format specifier for unsigned long
5353 argument.
5354
5a49b79c
DA
53552013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5356
5357 * frame.h (struct frame): Put menu_bar_window under #ifdef
5358 because this member is not needed when X toolkit is in use.
5359 (fset_menu_bar_window):
5360 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5361 (free_glyphs, update_frame):
5362 * xdisp.c (expose_frame): Likewise.
5363 (display_menu_bar): Likewise. Remove redundant eassert.
5364 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5365 toolkit is in use.
5366
d6723bf7
PE
53672013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5368
7b1123d8
PE
5369 Use functions and constants to manipulate Lisp_Save_Value objects.
5370 This replaces code that used macros and strings and token-pasting.
5371 The change makes the C source a bit easier to follow,
5372 and shrinks the Emacs executable a bit.
5373 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5374 (make_save_value): Change 1st arg from string to enum. All callers
5375 changed.
5376 (INTX): Remove.
5377 (mark_object): Use if, not #if, for GC_MARK_STACK.
5378 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5379 (XSAVE_OBJECT): Now functions, not macros.
5380 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5381 the constant was never used.
5382 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5383 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5384 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5385 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5386 New constants.
5387 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5388 type3 with a single member save_type. All uses changed.
5389 (save_type, set_save_pointer, set_save_integer): New functions.
5390 * print.c (PRINTX): Remove.
5391
d6723bf7
PE
5392 * alloc.c: Remove redundant static declarations.
5393
5f24fa51
DA
53942013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5395
5396 * window.h (struct window): Convert left_col, top_line, total_lines
5397 and total_cols from Lisp_Objects to integers. Adjust comments.
5398 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5399 Remove.
5400 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5401 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5402 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5403 Adjust users where appropriate.
5404
42143acd
DA
54052013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5406
5407 * frame.h (struct frame): Drop resx and resy because the same data is
5408 available from window system-specific output context. Adjust users.
562c6ee9
SM
5409 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5410 New functions to provide defaults when no window system available.
42143acd 5411 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5412 (NUMVAL): Move from xdisp.c.
42143acd
DA
5413 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5414 (Ffont_face_attributes, Fopen_font):
5415 * image.c (gs_load):
5416 * w32font.c (fill_in_logfont):
5417 * xdisp.c (calc_pixel_width_or_height):
5418 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5419 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5420
c0a17406
KH
54212013-03-20 Kenichi Handa <handa@gnu.org>
5422
5423 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5424 to 1 (temporary workaround until a bug related to ASCII
5425 optimization is fixed).
5426
095d384d
DA
54272013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5428
5429 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5430 Signal error if window is not internal. Adjust docstring.
5431 (delete_all_child_windows): Use combination_limit to save the buffer.
5432 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5433 * print.c (syms_of_print): Initialize debugging output not here...
5434 (init_print_once): ...but in a new function here.
5435 * lisp.h (init_print_once): Add prototype.
5436 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5437
748fa866
DA
54382013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5439
5440 * window.c (window_resize_check, window_resize_apply)
5441 (window_from_coordinates, recombine_windows, set_window_buffer)
5442 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5443 (Fsplit_window_internal, Fdelete_window_internal)
5444 (freeze_window_starts): Use bool for booleans.
5445 * window.h (window_frame_coordinates, resize_frame_windows)
5446 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5447
81519fd2
SM
54482013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5449
5450 * dispnew.c (bitch_at_user): Use `user-error'.
5451
6db423a9
KB
54522013-03-17 Ken Brown <kbrown@cornell.edu>
5453
5454 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5455 as return type of image_background. (Bug#13981)
5456 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5457
8f2906f5
JD
54582013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5459
960ce480 5460 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5461 (ns_select): Don't return with result uninitialized.
960ce480 5462
8f2906f5
JD
5463 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5464 and getDirectory.
5465
81519fd2
SM
5466 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5467 New functions.
8f2906f5
JD
5468 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5469 directories. If filename is nil, get directory name (Bug#13932).
5470 Use getFilename and getDirectory.
5471 (getFilename, getDirectory): New methods for EmacsSavePanel and
5472 EmacsOpenPanel.
5473 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5474
cded56c1
PE
54752013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5476
5477 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5478
251e9147 54792013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5480
5481 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5482 (adjust_after_replace): Make it back to static. Delete the third
5483 arg text_at_gap_tail. Cancel the code for handling it.
5484
5485 * coding.h (struct coding_system): New member eol_seen.
5486
5487 * coding.c (detect_ascii): New function.
5488 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5489 when the source bytes are actually scanned. On detecting for
5490 coding_category_utf_8_auto, call detect_ascii instead of scanning
5491 source bytes directly.
5492 (produce_chars): Call insert_from_gap with the new arg 0.
5493 (encode_coding): Likewise.
5494 (decode_coding_gap): Control ASCII optimization by the variable
5495 disable_ascii_optimization instead of #ifndef .. #endif.
5496 Deccode EOL format according to coding->eol_seen.
5497 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5498 variable.
5499
8a44e6d1
KH
5500 * lisp.h (adjust_after_replace): Cancel externing it.
5501 (insert_from_gap): Adjust prototype.
5502
5f795e34
EZ
55032013-03-15 Eli Zaretskii <eliz@gnu.org>
5504
5505 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5506 FULLSCREEN_MAXIMIZED. (Bug#13935)
5507
f258b4be
DA
55082013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5509
5510 * region-cache.c (find_cache_boundary, move_cache_gap)
5511 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5512 Simplify debugging check and convert to eassert. Adjust comment.
5513 (pp_cache): Put under ENABLE_CHECKING.
5514
a5cc4dde
EZ
55152013-03-14 Eli Zaretskii <eliz@gnu.org>
5516
5517 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5518 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5519 and WM_ACTIVATEAPP.
5520 (w32fullscreen_hook): If the frame is visible, reset
5521 f->want_fullscreen flag after changing the frame size. If the
5522 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5523 (Bug#13953)
5524
3fc5e44a
DC
55252013-03-13 Daniel Colascione <dancol@dancol.org>
5526
5527 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5528 too so that these builds can use Cygwin's file conversion
5529 functions. (We've been building and linking cygw32.o all along
5530 and just not using it.)
5531
47d7532e
PE
55322013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5533
5534 File synchronization fixes (Bug#13944).
5535 * Makefile.in (LIB_FDATASYNC): New macro.
5536 (LIBES): Use it.
5537 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5538 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5539 Don't worry about HAVE_FSYNC, since a substitute fsync is
5540 available if the system lacks one.
5541 (Fwrite_regin): Retry fsync if interrupted.
5542
c7ffccaf
EZ
55432013-03-13 Eli Zaretskii <eliz@gnu.org>
5544
4e2df81d 5545 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5546 activated, call w32fullscreen_hook, to make sure the new frame
5547 dimensions are in effect. (Bug#13937)
5548
8a7debc1
DA
55492013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5550
5551 * xdisp.c (init_iterator): Simplify because both character and byte
5552 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5553 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5554 character and byte positions can be obtained from marker.
8a7debc1 5555
7fd8c501
PE
55562013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5557
d9df6f40
PE
5558 Static checking by Sun C 5.12.
5559 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5560 * bytecode.c (exec_byte_code):
5561 * dispnew.c (init_display):
5562 * eval.c (error):
5563 * fileio.c (Fsubstitute_in_file_name):
5564 * keyboard.c (Fevent_convert_list):
5565 * keymap.c (Fsingle_key_description):
5566 * term.c (maybe_fatal, fatal):
5567 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5568 * xsmfns.c (Fhandle_save_session):
5569 Omit unreachable code.
5570 * keymap.c (map_keymap_char_table_item): Cast void * to
5571 a function pointer type; the C Standard requires this.
5572
7fd8c501
PE
5573 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5574 Include <sys/param.h> unconditionally, as that works elsewhere and
5575 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5576 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5577 and FreeBSD now.
5578
a020afb9 5579See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5580
5581;; Local Variables:
5582;; coding: utf-8
aac0c6e3
MR
5583;; End:
5584
ab422c4d 5585 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5586
5587 This file is part of GNU Emacs.
5588
5589 GNU Emacs is free software: you can redistribute it and/or modify
5590 it under the terms of the GNU General Public License as published by
5591 the Free Software Foundation, either version 3 of the License, or
5592 (at your option) any later version.
5593
5594 GNU Emacs is distributed in the hope that it will be useful,
5595 but WITHOUT ANY WARRANTY; without even the implied warranty of
5596 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5597 GNU General Public License for more details.
5598
5599 You should have received a copy of the GNU General Public License
5600 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.