* window.h (struct window): Convert left_margin_cols and
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eeaf9bf3
DA
12013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * window.h (struct window): Convert left_margin_cols and
4 right_margin_cols from Lisp_Objects to integers. Adjust comment.
5 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
6 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
7 Adjust users.
8 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
9 Adjust comment.
10 (showing_window_margins_p, update_window_line, update_frame_1):
11 * fringe.c (draw_fringe_bitmap_1):
12 * xdisp.c (window_box_width): Adjust users.
13 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
14 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
15 Use direct assignment.
16 (Fset_window_configuration, save_window_save, Fwindow_margins):
17 Convert Lisp_Object to integer and back where appropriate.
18 (Fset_window_margins): Adjust user. Return t if any margin
19 was actually changed, and mention this in docstring.
20
956720af
XF
212013-08-13 Xue Fuqiao <xfq.free@gmail.com>
22
f73f4ce6 23 * syntax.c (forward_word):
956720af
XF
24 * cmds.c (forward_char, backward_char): Mention the optional argument.
25
9e37ee3b
DA
262013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
27
28 * window.h (struct window): Convert left_fringe_width
29 and right_fringe_width from Lisp_Objects to integers.
30 Adjust comment.
31 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
32 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
33 * window.c (wset_left_fringe_width, wset_right_fringe_width):
34 Remove.
35 (make_window): Initialize new integer fields to -1.
36 (Fsplit_window_internal): Use direct assignment.
37 (Fset_window_configuration, save_window_save): Convert
38 Lisp_Object to integer and back where appropriate.
39 (Fset_window_fringes): Adjust user. Return t if any fringe
40 was actually changed, and mention this in docstring.
41
e4375ca7
DA
422013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
43
44 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
45 * nsfns.m (x_set_cursor_type):
46 * w32fns.c (x_set_cursor_type):
47 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
48 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 49
a45543bc
DA
502013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
51
52 * font.c (clear_font_cache): New function, stripped from...
53 (Fclear_font_cache): ...here, which now uses the function
54 above. Adjust comment.
55 * font.h (clear_font_cache): Add prototype.
56 * xfaces.c (clear_face_cache): Use clear_font_cache.
57
ae966a86
DA
582013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
59
60 * window.c (Fset_window_start): Compare `w', not `window' because
61 `w' might not be equal to `window' after call to decode_live_window.
62
297a545b
PE
632013-08-12 Paul Eggert <eggert@cs.ucla.edu>
64
65 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
66 This fixes a problem introduced by the Bug#15035 patch
67 when using GPG. Reported by Herbert J. Skuhra.
68
aa942e2b
EZ
692013-08-12 Eli Zaretskii <eliz@gnu.org>
70
71 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
72 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
73 not yet initialized.
74
7699d09e
LMI
752013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
76
77 * decompress.c (Fzlib_decompress_region): Support zlib
78 decompression, too, and rename.
79
1d238bc7
PE
802013-08-12 Paul Eggert <eggert@cs.ucla.edu>
81
82 Minor zlib configuration tweaks.
83 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
84 Don't assume presence of fn_inflateInit2_ zlib internal function.
85
8a44a184
LMI
862013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
87
88 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
89 include the zlib prefix.
90
594a4307
EZ
912013-08-12 Eli Zaretskii <eliz@gnu.org>
92
93 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
94 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
95 define static variables that are pointers to zlib functions to be
96 dynamically loaded.
97 (init_zlib_functions) [WINDOWSNT]: New function.
98 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
99 New macros.
100 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
101 macros instead of invoking the zlib functions directly.
102 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
103 Szlib_available_p.
104
d2e113bc
DA
1052013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
106
107 Avoid looping over all frame windows to freeze and unfreeze.
108 * window.h (struct window): Drop frozen_window_start_p.
109 (freeze_window_starts): Drop prototype.
110 * frame.h (struct frame): New frozen_window_starts flag.
111 (FRAME_WINDOWS_FROZEN): New macro.
112 * window.c (freeze_window_start, freeze_window_starts):
113 Remove.
114 (select_window, replace_window): Adjust users.
115 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
116 (window_frozen_p): New function.
117 (redisplay_window): Use it.
118
94fcd171
PE
1192013-08-12 Paul Eggert <eggert@cs.ucla.edu>
120
121 Fix some fd issues when running subprocesses (Bug#15035).
122 Fix bugs that can leak files or file descriptors on errors.
123 Don't unlink open temp files, as that's hard for users to diagnose
124 when things go awry (e.g., temp disk exhausted).
125 Don't bother to lock temp files. Check for invalid recursion.
126 * callproc.c (synch_process_fd): Remove. All uses removed.
127 (synch_process_tempfile): New var or macro.
128 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
129 New constants.
130 (record_kill_process): New arg, the temp name. All callers changed.
131 (delete_temp_file): Now just a simple wrapper around unlink.
132 (call_process_kill): New arg, the call_process_fd array.
133 Close them all. Clear synch_process_pid. Remove the temp file,
134 or arrange for it to be removed.
135 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
136 that's been moved to synch_process_tempfile. Caller changed.
137 Do not remove the tempfile; that's now call_process_kill's
138 responsibility.
139 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
140 call_process_kill; the caller now does that.
141 (call_process_cleanup): Do not close the process fd; that's now
142 call_process_kill's responsibility.
143 (Fcall_process): Implement via new function call_process, which
144 has most of the old body of Fcall_process, but with a different API.
145 (call_process): New function that does not open or close filefd if
146 it is nonnegative. Record which fds need to be closed, and let
147 call_process_kill close (and remove the tempfile, on MSDOS) on error.
148 Signal an error if invoked recursively (could be done via a hook).
149 Simplify creation of the tempfile in the MSDOS case.
150 Don't create the output file until after checking for the executable.
151 Report any failure to open /dev/null.
152 Don't open /dev/null for writing twice; once is enough.
153 Don't create pipe if all output is being discarded or sent to file.
154 Don't worry about setting up the coding system or reading from the
155 pipe if all output is being discarded.
156 Hoist fd_error local into top level, to lessen block nesting.
157 Don't record deleted pid here; now done by Fcall_process_region.
158 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
159 and note its success in synch_process_tempfile.
160 Do not leak resources when child_setup fails.
161 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
162 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
163 (create_temp_file): Now returns open fd, with an additional
164 Lisp_Object * argument to return the name. All callers changed.
165 Do not close the file; rewind it instead, and leave it open for
166 the caller. Do not lock the temp file. Unwind-protect the file
167 and the file-descriptor.
168 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
169 If an asynchrounous process, record it here, not in call_process.
170 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
171 * eval.c (set_unwind_protect): New function.
172 * fileio.c (write_region): New function, generalized from the
173 old Fwrite_region. Do not lock temp files.
174 (Fwrite_region): Use it.
175 * lisp.h (set_unwind_protect, write_region): New decls.
176 * process.c: Include <verify.h>.
177 (make_process): Mark fds as initially closed.
178 (deleted_pid_list): Now a list of pid-filename pairs.
179 All uses changed.
180 (close_process_fd): New function.
181 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
182 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
183 New constants. Verify that their number matches PROCESS_OPEN_FDS.
184 (create_process, create_pty, Fmake_serial_process)
185 (server_accept_connection): Record which fds need to be closed,
186 and let deactivate_process close them.
187 (Fmake_network_process): Do not discard the unwind-protect
188 until it's safe to do so.
189 (deactivate_process): Close the fds opened by create_process etc.
190 (Fprocess_send_eof): Adjust to new way of recording open fds.
191 Report an error if /dev/null can't be opened, instead of aborting.
192 * process.h (PROCESS_OPEN_FDS): New constant.
193 (struct Lisp_Process): New member open_fds.
194 (record_kill_process, record_deleted_pid): Adjust signatures.
195 (record_deleted_pid): Move decl here ...
196 * syswait.h (record_deleted_pid): ... from here.
197
d0e615c3
PE
1982013-08-11 Paul Eggert <eggert@cs.ucla.edu>
199
200 * decompress.c: Fix bugs with large buffers and weird inputs.
201 Tune a bit. Reindent as per usual Emacs style.
202 (BUFFER_SIZE): Remove.
203 (Fdecompress_gzipped_region): Do not mishandle input buffers with
204 more than UINT_MAX bytes. Decompress into the gap instead of into
205 an auto buffer, as this should avoid copying. Return nil if
206 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
207 set immediate_quit; we shouldn't trust zlib code that much.
208
313546eb
LMI
2092013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
210
99a32242
LMI
211 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
212 errors, and really move the gap to where we want it.
213
313546eb
LMI
214 * lisp.h: Include decompress.c support.
215
216 * emacs.c (main): Include decompress.c support.
217
218 * Makefile.in: Include -lz if present.
219
d2d699ac
JD
2202013-08-11 Jan Djärv <jan.h.d@swipnet.se>
221
f90e3ebd
JD
222 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
223 (initWithTitle:): Initialize frame to 0.
224 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
225 (fillWithWidgetValue:frame:): Renamed from
226 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
227
228 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
229 fillWithWidgetValue:frame:
230
423d3b3f
JD
231 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
232 remove memory leak warnings.
233
d2d699ac
JD
234 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
235 (ns_check_menu_open): Handle menu == nil. Remove assignment to
236 menu_pending_title.
237
238 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
239 (x_activate_menubar): Update the whole menu.
240 (trackingNotification:): Call ns_check_menu_open if tracking ends.
241 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
242 current event is not NSSystemDefined (Bug#15001).
243 Call ns_check_menu_open only if trackingMenu is 2.
244 (menuDidClose:): New method, decrease trackingMenu.
245 (fillWithWidgetValue:setDelegate:): New method.
246 (fillWithWidgetValue:): Call the above.
247
248 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
249
7d652d97
PE
2502013-08-11 Paul Eggert <eggert@cs.ucla.edu>
251
252 Omit some unnecessary casts.
253 Many of these go back to the old pre-C89 days, when they may have
254 been needed, but we've been assuming C89 or later for a while now.
255 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
256 (live_float_p, live_misc_p, live_vector_p):
257 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
258 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
259 (defvar_per_buffer):
260 * callint.c (Fcall_interactively):
261 * doc.c (Fsubstitute_command_keys):
262 * filelock.c (get_boot_time):
263 * frame.c (xrdb_get_resource):
264 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
265 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
266 (xg_get_file_name_from_selector, menuitem_destroy_callback)
267 (menuitem_highlight_callback, menu_destroy_callback)
268 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
269 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
270 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
271 (xg_tool_bar_help_callback, tb_size_cb):
272 * image.c (xpm_alloc_color, png_read_from_memory)
273 (png_read_from_file, png_load_body, our_memory_skip_input_data)
274 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
275 (syms_of_image):
276 * keymap.c (describe_map):
277 * nsfns.m (Fns_display_monitor_attributes_list):
278 * nsmenu.m (process_dialog:):
279 * nsterm.m (hold_event):
280 * process.c (wait_reading_process_output):
281 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
282 * scroll.c (do_direct_scrolling, scrolling_1):
283 * termcap.c (tgetent):
284 * window.c (check_window_containing, add_window_to_list)
285 (freeze_window_starts):
286 * xdisp.c (compare_overlay_entries, vmessage):
287 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
288 (x_get_monitor_attributes_xrandr)
289 (Fx_display_monitor_attributes_list, x_display_info_for_name)
290 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
291 * xfont.c (xfont_match, xfont_open):
292 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
293 (menubar_selection_callback, menu_position_func)
294 (popup_selection_callback, create_and_show_popup_menu)
295 (dialog_selection_callback, create_and_show_dialog):
296 * xrdb.c (x_get_string_resource):
297 (main) [TESTRM]:
298 * xsmfns.c (x_session_check_input):
299 * xterm.c (x_draw_glyphless_glyph_string_foreground)
300 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
301 (xaw_jump_callback, xaw_scroll_callback):
302 Omit unnecessary casts.
303
9acc1074
PE
3042013-08-10 Paul Eggert <eggert@cs.ucla.edu>
305
306 Minor string-length refactoring.
307 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
308 * frame.c (make_monitor_attribute_list):
309 Prefer build_string to strlen + make_string.
310
361c0eb8
JD
3112013-08-10 Jan Djärv <jan.h.d@swipnet.se>
312
313 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
314 don't check minor_code (Bug#14417).
315
14ba0822
EZ
3162013-08-09 Eli Zaretskii <eliz@gnu.org>
317
318 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
319 vertical positions instead. This avoids calling MATRIX_ROW with
320 row numbers that are possibly beyond valid limits. (Bug#15064)
321
309f24d1
DA
3222013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
323
324 Use xstrdup and build_unibyte_string where applicable.
325 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
326 * xfns.c (x_window):
327 * xrdb.c (x_get_customization_string):
328 * xterm.c (xim_initialize):
329 * w32fns.c (w32_window): Use xstrdup.
330 (w32_display_monitor_attributes_list):
331 * emacs.c (init_cmdargs):
332 * keyboard.c (PUSH_C_STR):
333 * nsfont.m (nsfont_open):
334 * sysdep.c (system_process_attributes):
335 * w32.c (system_process_attributes):
336 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
337
55902276
EZ
3382013-08-09 Eli Zaretskii <eliz@gnu.org>
339
340 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
341 variables of these types so that GDB would know about them, as aid
342 for debugging fatal exceptions. (Bug#15024) See also
343 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
344 discussions.
345
10bf7f5a
JD
3462013-08-08 Jan Djärv <jan.h.d@swipnet.se>
347
348 * nsterm.m (ns_update_begin): Don't change clip path if it would be
349 larger than the NSWindow (Bug#14934).
350
65620264
DA
3512013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
352
353 Redesign redisplay interface to drop global variable updated_window.
354 Always pass currently updated window as a parameter to update routines.
355 * dispextern.h (updated_window): Remove declaration.
356 (struct redisplay_interface): Pass window parameter to
357 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
358 and after_update_window_hook.
359 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
360 Adjust prototypes.
361 * dispnew.c (updated_window): Remove.
362 (redraw_overlapped_rows, update_marginal_area, update_text_area)
363 (update_window_line): Adjust to match redisplay interface changes.
364 * nsterm.m (ns_update_window_begin, ns_update_window_end)
365 (ns_scroll_run, ns_after_update_window_line):
366 * w32term.c (x_update_window_begin, x_update_window_end)
367 (x_after_update_window_line, x_scroll_run):
368 * xterm.c (x_update_window_begin, x_update_window_end)
369 (x_after_update_window_line, x_scroll_run):
370 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
371 Likewise. Adjust comments where appropriate.
372 (x_cursor_to): Simplify because this is always called during window
373 update (but install debugging check anyway).
374 (expose_window): Check must_be_updated_p flag to see whether this
375 function is called during window update.
376
628fdc56
DA
3772013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
378
379 Do not reset window modification event counters excessively.
380 These leftovers and poor man's tricky methods to catch extra
381 redisplay's attention are no longer needed.
382 * frame.c (set_menu_bar_lines_1):
383 * minibuf.c (read_minibuf_unwind):
384 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
385 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
386 (window_scroll_line_based, Fset_window_configuration):
387 * xdisp.c (redisplay_window): Do not reset last_modified and
388 last_overlay_modified counters.
389
8fd9c92e
JD
3902013-08-07 Jan Djärv <jan.h.d@swipnet.se>
391
392 * xselect.c (x_send_client_event): Set send_event and serial, memset
393 data.l as it might be bigger than data.b. Use 24 bit mask to
394 XSendEvent (Bug#15034).
395
0ee18172
EZ
3962013-08-07 Eli Zaretskii <eliz@gnu.org>
397
398 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
399 for TTY frames that are not the top frame on their console.
400 (Bug#14616)
401
16ddd1a6
MR
4022013-08-07 Martin Rudalics <rudalics@gmx.at>
403
404 * w32term.c (w32fullscreen_hook): Really maximize frame when
405 asked for (Bug#14841).
406
d2a95ffb
DA
4072013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
408
409 Prefer selected_window to Fselected_window, likewise for frames.
410 * buffer.c (Fbuffer_swap_text):
411 * data.c (Fvariable_binding_locus):
412 * window.c (run_window_configuration_change_hook): Adjust users.
413 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
414 Use decode_live_frame.
415
170da1ec
DA
4162013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
417
418 Be more careful if selected window shows the buffer other than current,
419 use window_outdated only if this is not so. This change should also
420 address some weird issues discussed in Bug#13012.
421 * window.h (window_outdated): New prototype.
422 * window.c (window_outdated): Now here. Convert from static and
423 always assume window's buffer.
424 (Fwindow_end, Fwindow_line_height): Use it.
425 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
426 and always assume window's buffer.
427 (redisplay_window): Adjust user.
e5eefe9b 428 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
429 check whether mode line should be updated only if selected window
430 shows current buffer.
431 (run_window_scroll_functions): Use eassert for debugging check.
432 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
433
56b5d5b1
DA
4342013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
435
436 * window.c (window_scroll, window_scroll_pixel_based)
437 (window_scroll_line_based): Use bool for booleans.
438
2878ba7e
PE
4392013-08-06 Paul Eggert <eggert@cs.ucla.edu>
440
441 * process.c: Fix minor off-by-one issues in descriptor counts.
442 This shouldn't fix any real bugs, but it cleans up the code a bit.
443 (max_process_desc, max_input_desc): -1, not 0, means none.
444 All uses changed.
445 (delete_input_desc): New function.
446 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
447 (deactivate_process): Scan backwards when recomuting max_process_desc;
448 that should be faster.
449 (init_process_emacs): Initialize max_input_desc.
450
e30b79c1
DA
4512013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
452
453 Use region cache to speedup bidi_find_paragraph_start.
454 * buffer.h (struct buffer): New member bidi_paragraph_cache.
455 Rename cache_long_line_scans to cache_long_scans.
456 * buffer.c (bset_cache_long_line_scans): Rename to
457 bset_cache_long_scans.
458 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
459 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
460 into account.
461 (syms_of_buffer): Rename cache-long-line-scans to
462 cache-long-scans. Adjust docstring.
463 * search.c (newline_cache_on_off):
464 * indent.c (width_run_cache_on_off): Adjust users.
465 * bidi.c (bidi_paragraph_cache_on_off): New function.
466 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
467 * insdel.c (prepare_to_modify_buffer): Invalidate
468 bidi_paragraph_cache if enabled.
469
00012b86
DA
4702013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Invalidate region caches only if buffer text is going to be changed.
473 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
474 (modify_text): ...new prototype.
475 (prepare_to_modify_buffer_1): New prototype.
476 * textprop.c (modify_region): Rename to...
477 (modify_text_properties): ...new function.
478 (add_text_properties_1, set_text_properties, Fremove_text_properties)
479 (Fremove_list_of_text_properties): Adjust users.
480 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
481 (modify_text): ...new function.
482 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
483 (prepare_to_modify_buffer_1): ...new function.
484 * casefiddle.c (casify_region):
485 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
486 (Ftranspose_regions): Use modify_text.
487
dc6c0eda
SM
4882013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
489
490 * lisp.mk (lisp): Add nadvice.elc.
491
8f3a2c26
DA
4922013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
493
494 New macro to iterate over live buffers similar to frames.
495 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
496 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
497 Declare buffer-related variables here to offload lisp.h.
498 * buffer.c (Vbuffer_alist): Adjust comment.
499 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
500 (other_buffer_safely):
501 * data.c (store_symval_forwarding):
502 * dispnew.c (Fframe_or_buffer_changed_p):
503 * fileio.c (Fdo_auto_save):
504 * filelock.c (unlock_all_files):
505 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
506
e0fdb694
PE
5072013-08-04 Paul Eggert <eggert@cs.ucla.edu>
508
509 Fix some minor races in hosts lacking mkostemp (Bug#15015).
510 * callproc.c (create_temp_file):
511 * filelock.c (create_lock_file):
512 Assume mkostemp, since it's now provided by Gnulib.
513
63f5c6c2
EZ
5142013-08-04 Eli Zaretskii <eliz@gnu.org>
515
516 * w32.c (mkostemp): New function.
517 (mktemp): Remove, no longer used. Most of the code reused in
518 mkostemp. (Bug#15015)
484ab239 519 (mktemp): Don't undef.
63f5c6c2 520
f0b79313
DA
5212013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
522
523 * dispnew.c (glyph_matrix_count, glyph_pool_count):
524 Move under GLYPH_DEBUG and ENABLE_CHECKING.
525 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
526 (free_glyph_pool, check_glyph_memory): Likewise for
527 all users. Adjust comments where appropriate.
528
98f638d6
PE
5292013-08-03 Paul Eggert <eggert@cs.ucla.edu>
530
531 * composite.h: Minor fixups.
532 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
533 to fix a misspelling, and change it to an inline function while
534 we're at it (it need not be a macro). All uses changed.
535 (composition_method, composition_valid_p):
536 Rewrite to avoid assignments in if-conditions.
537
75c59fb3
DA
5382013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
539
540 Do not use global Lisp_Object in composition macros.
541 * composite.h (composition_temp): Remove declaration.
542 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
543 (composition_method, composition_valid_p): ...inline functions.
416a3e01 544 (compose_region): Remove the leftover.
75c59fb3
DA
545 * composite.c (composition_temp): Remove.
546 (run_composition_function, update_compositions)
547 (composition_compute_stop_pos, composition_adjust_point)
548 (Ffind_composition_internal):
549 * coding.c (handle_composition_annotation):
550 * xdisp.c (handle_composition_prop, check_point_in_composition):
551 Related users changed.
552
a10c8269
DA
5532013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
554
555 Drop FRAME_PTR typedef.
556 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
557 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
558 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
559 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
560 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
561 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
562 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
563 All related users changed.
564
a104f656
SM
5652013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
566
567 * eval.c (default_toplevel_binding): New function.
568 (Fdefvar): Use it.
569 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
570 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
571 (syms_of_eval): Export them.
572 * data.c (Fdefault_value): Micro cleanup.
573 * term.c (init_tty): Use "false".
574
4b5c9326
DA
5752013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Fix X GC leak in GTK and raw (no toolkit) X ports.
578 * xterm.c (x_free_frame_resources): If white and black relief
579 GCs are allocated, always free them here.
580 * xfns.c (x_make_gc): Omit redundant initialization.
581 * widget.c (create_frame_gcs): Remove the leftover.
582 (EmacsFrameDestroy): Do nothing because all GCs are now freed
583 in x_free_frame_resources.
584
b19aa636
JD
5852013-08-02 Jan Djärv <jan.h.d@swipnet.se>
586
587 * nsterm.m (windowWillResize:toSize:): Only change title if
588 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
589 modifying it.
590 (viewDidEndLiveResize): New method.
591
592 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
593 inside NS_IMPL_COCOA.
594
af1f7e06
DA
5952013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
596
597 * insdel.c (adjust_after_replace, replace_range, del_range_2):
598 Do not check whether undo is enabled because record_insert and
599 record_delete does that themselves.
600
65b02bb9
DA
6012013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
602
603 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
604 member which is not really used any more.
605 (FRAME_XIC_BASE_FONTNAME): Remove.
606 * xfns.c (xic_free_fontset): Adjust user.
607 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
608 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
609 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
610 (xdialog_show): Use eassert for debugging check.
7ee0f047 611 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 612
6318cde0
PE
6132013-08-01 Paul Eggert <eggert@cs.ucla.edu>
614
615 * fileio.c, fns.c (merge): Move extern decl from here ...
616 * lisp.h (merge): ... to here.
617
6c1a09ba
DA
6182013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
619
620 Fix last font-related change.
621 * w32font.h (w32font_list_internal, w32font_match_internal):
622 Fix prototype.
623 * w32uniscribe.c (uniscribe_list, uniscribe_match):
624 (uniscribe_list_family): Adjust to match font API change.
625 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
626 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
627
f8c20208
DA
6282013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
629
630 * frame.h (FRAME_MOUSE_UPDATE):
631 * nsterm.m (ns_frame_up_to_date): Omit redundant check
632 whether hlinfo->mouse_face_mouse_frame is non-NULL.
633
fdb396e2
DA
6342013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
635
636 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
637 * font.h (struct font_driver): Change list, match, and list_family
638 functions to accept struct frame * as first arg.
639 * font.c (font_score, font_compare, font_sort_entities): Remove
640 prototypes.
641 (font_sort_entities, font_list_entities, font_select_entity):
642 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
643 match font API change.
644 * xfont.c (xfont_list, xfont_match, xfont_list_family):
645 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
646 * ftxfont.c (ftxfont_list, ftxfont_match):
647 * xftfont.c (xftfont_list, xftfont_match):
648 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
649 * w32font.c (w32font_list, w32font_match, w32font_list):
650 (w32font_list_internal, w32_font_match_internal): Likewise.
651 * xfaces.c (Fx_family_fonts): Adjust user.
652
52b8a085
DA
6532013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
654
655 Do not use pure Xism x_wm_set_icon_position in non-X ports.
656 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
657 only if HAVE_X_WINDOWS is in use.
658 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
659 * nsterm.m (x_wm_set_icon_position): Remove no-op.
660 * w32term.c (x_wm_set_icon_position): Likewise.
661 * w32fns.c (x_icon): Adjust user.
662
c791c18e
DA
6632013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
664
665 * xterm.c (last_mouse_press_frame): Remove the
666 leftover which is not really used any more.
667 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
668 (x_flush): Call XFlush once per each X display, not frame.
669 This is better because this code always unconditionally skips
670 non-X frames in Vframe_list and issues the only XFlush if we
671 have more than one X frame on the same X display.
2f935d86
DA
672 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
673 Use bool for booleans.
674 (x_draw_glyph_string_background, cvt_string_to_pixel):
675 (cvt_pixel_dtor): Drop unnecessary prototypes.
676 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 677
f435830e
DA
6782013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
679
680 Drop unnecessary functions that deals with frame pixel size.
681 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
682 (x_pixel_height): Drop prototypes.
683 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
684 (x_pixel_height): Drop implementations.
685 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
686 which should be always valid for window frame.
687 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
688 * w32menu.c (Fx_popup_dialog):
689 * xmenu.c (Fx_popup_dialog): Likewise for both.
690
84231434
DA
6912013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
692
693 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
694 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
695 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
696 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
697 and mention nil frame in docstring.
84231434 698
959067a1
DA
6992013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
700
701 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
702 (x_figure_window_size): Likewise. Adjust to return long.
703 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
704 (toplevel): Move Qterminal_live_p to...
705 * terminal.c (toplevel): ...here, make it static, and...
706 (syms_of_terminal): ...DEFSYM here.
707 * frame.h (Qterminal_live_p): Remove declaration.
708 (make_frame, x_figure_window_size): Adjust prototype.
709 * nsfns.m (Fx_create_frame): Use long for window flags.
710
f4b169ce
PE
7112013-07-30 Paul Eggert <eggert@cs.ucla.edu>
712
713 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
714 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
715 Do not assume that emacs_close (INT_MAX) is a no-op.
716
bee6a2c7
DA
7172013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
718
719 * xfaces.c (make_face_cache): For struct face_cache, prefer
720 xmalloc to xzalloc and so avoid redundant call to memset.
721 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
722
d7e6881a
DA
7232013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
724
725 * fringe.c (draw_window_fringes, update_window_fringes)
726 (compute_fringe_widths):
727 * w32term.c (x_draw_glyph_string):
728 * window.c (candidate_window_p, Frecenter):
729 * xfaces.c (realize_basic_faces, realize_default_face)
730 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
731 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
732 * xfns.c (x_set_cursor_color, xic_free_xfontset):
733 * xmenu.c (Fx_menu_bar_open_internal):
734 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
735 * xsettings.c (xft_settings_event):
736 * xterm.c (x_draw_glyph_string, x_had_errors_p):
737 Use bool for booleans. Adjust style and comments where
738 appropriate.
739 * dispextern.h (draw_window_fringes, update_window_fringes)
740 (compute_fringe_widths):
741 * xterm.h (x_had_errors_p): Adjust prototype.
742
ec3058af
DA
7432013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
744
745 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
746 CHECK_LIST. Rewrite the loop to avoid useless local variable.
747
218e0637
DA
7482013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
749
750 * fns.c (toplevel): Remove comment before Fsafe_length because
751 it checks for QUIT.
752
e560aba9
PE
7532013-07-28 Paul Eggert <eggert@cs.ucla.edu>
754
755 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
756
2e5ce5de
EZ
7572013-07-28 Eli Zaretskii <eliz@gnu.org>
758
759 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
760 frame which got the message is still alive, before dereferencing
761 its pointer. (Bug#14970)
762
763 * frame.c (delete_frame): Test "this" frame's minibuffer window to
764 be a live window, before using it as such. (Bug#14970)
765
e95da6d3
EZ
7662013-07-27 Eli Zaretskii <eliz@gnu.org>
767
768 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
769 w32_detect_focus_change instead of doing part of its job by hand.
770 This fixes the problem whereby FOCUS_OUT events were not sent to
771 the event queue.
772
a8f93651
EZ
7732013-07-26 Eli Zaretskii <eliz@gnu.org>
774
fec92060
EZ
775 * process.c (Fprocess_list): Doc fix.
776
a8f93651
EZ
777 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
778 being re-exposed only if it didn't ask to become visible.
779 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
780 was previously iconified. (Bug#14841)
781 (x_iconify_frame): Mark the frame iconified.
782
d5a7a9d9
PE
7832013-07-26 Paul Eggert <eggert@cs.ucla.edu>
784
785 Fix minor problems found by static checking.
786 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
787 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
788
56ea7291
SM
7892013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
790
791 * eval.c (set_specpdl_old_value): New function.
792 (unbind_to): Minor simplification.
793 (get_backtrace_frame): New function.
794 (Fbacktrace_frame): Use it. Add `base' argument.
795 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
796 (syms_of_eval): Export backtrace-eval.
797 * xterm.c (x_focus_changed): Simplify.
798
9d611ffe
PE
7992013-07-25 Paul Eggert <eggert@cs.ucla.edu>
800
801 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
802
999c74e3
EZ
8032013-07-24 Eli Zaretskii <eliz@gnu.org>
804
805 * xdisp.c (redisplay_window): Instead of moving point out of
806 scroll margin, reject the force_start method, and try scrolling
807 instead. (Bug#14780)
808
198fa217
KB
8092013-07-24 Ken Brown <kbrown@cornell.edu>
810
811 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
812 (Bug#14944).
813
53840e55
PE
8142013-07-24 Paul Eggert <eggert@cs.ucla.edu>
815
816 * eval.c (Fprogn): Do not check that BODY is a proper list.
817 This undoes the previous change. The check slows down the
818 interpreter, and is not needed to prevent a crash. See
819 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
820
60967f56
GM
8212013-07-23 Glenn Morris <rgm@gnu.org>
822
823 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
824
9ca960e2
PE
8252013-07-23 Paul Eggert <eggert@cs.ucla.edu>
826
a29c3e6d
PE
827 Port to GNU/Linux systems with tinfo but not ncurses.
828 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
829 to decide whether ncurses is being used. Without this change,
830 GCC complains about tgetent not being declared, on a system
831 that has tinfo installed but ncurses not installed.
832
f274311c
PE
833 * eval.c (Fprogn): Check that BODY is a proper list.
834
16b0520a
PE
835 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
836 * data.c (Fsetq_default):
837 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
838 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
839 (Fcondition_case):
840 Tune by taking advantage of the fact that ARGS is always a list
841 when a function is declared to have UNEVALLED args.
842
9ca960e2
PE
843 * emacsgtkfixed.c: Port to GCC 4.6.
844 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
845
afacaa1b
JB
8462013-07-23 Juanma Barranquero <lekktu@gmail.com>
847
848 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
849 here to silence compiler warnings.
850
368a85a4
PE
8512013-07-22 Paul Eggert <eggert@cs.ucla.edu>
852
853 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
854 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
855 from messing up Emacs's 'struct frame' (Bug#14923).
856
f4e891b5
PE
8572013-07-21 Paul Eggert <eggert@cs.ucla.edu>
858
859 * alloc.c (make_save_ptr_ptr): Define this function.
860 It was inadvertently omitted. It's needed only if
861 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
862
96c8b65e
JD
8632013-07-21 Jan Djärv <jan.h.d@swipnet.se>
864
865 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
866 frame have focus (Bug#14895).
867
ee010797
PE
8682013-07-21 Paul Eggert <eggert@cs.ucla.edu>
869
870 Avoid vfork-related deadlock more cleanly.
871 * callproc.c (child_setup): When the child's exec fails, output
872 the program name, as that's more useful. Use O_NONBLOCK to avoid
873 deadlock.
874 * process.c (create_process_1): Remove; no longer needed.
875 (create_process): Remove timer hack; no longer needed, now that
876 the child avoids deadlock.
877
f0398ec1 8782013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
879
880 * image.c (Fimage_flush): Fix doc typo.
881
b2a069c2
PE
8822013-07-20 Paul Eggert <eggert@cs.ucla.edu>
883
6496aec9
PE
884 Fix array bounds violation when pty allocation fails.
885 * process.c (PTY_NAME_SIZE): New constant.
886 (pty_name): Remove static variable; it's now auto.
887 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
888 Take pty_name as an arg rather than using a static variable.
889 All callers changed.
890 (create_process): Recover pty_flag from process, not from volatile local.
891 (create_pty): Stay inside array even when pty allocation fails.
892 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
893
b2a069c2
PE
894 * lread.c (Fload): Avoid initialization only when lint checking.
895 Mention that it's needed only for older GCCs.
896
99107004
KH
8972013-07-20 Kenichi Handa <handa@gnu.org>
898
899 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
900 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
901
6b1b199d
AS
9022013-07-20 Andreas Schwab <schwab@linux-m68k.org>
903
904 * lread.c (Fload): Avoid uninitialized warning.
905
4195afc3
PE
9062013-07-19 Paul Eggert <eggert@cs.ucla.edu>
907
3f5bef16
PE
908 Fix some minor file descriptor leaks and related glitches.
909 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
910 (create_lock_file): Use write, not emacs_write.
911 * image.c (slurp_file, png_load_body):
912 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
913 (server_accept_connection):
914 Don't leak an fd on memory allocation failure.
915 * image.c (slurp_file): Add a cheap heuristic for growing files.
916 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
917 as that's what the other routines do. Maybe input need not be
918 blocked at all, but it's better to be consistent.
919 Avoid undefined behavior when strlen is zero.
920
4195afc3
PE
921 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
922 (NSTATICS): Now a constant; doesn't need to be a macro.
923
a1aeeffe
RS
9242013-07-19 Richard Stallman <rms@gnu.org>
925
926 * coding.c (decode_coding_utf_8): Add simple loop for fast
927 processing of ASCII characters.
928
63b34baa
PE
9292013-07-19 Paul Eggert <eggert@cs.ucla.edu>
930
931 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
932
621dd9ac
EZ
9332013-07-19 Eli Zaretskii <eliz@gnu.org>
934
935 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
936 unportable 'struct x_display_info'.
937 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
938 is a portable type.
939
1396ac86
PE
9402013-07-19 Paul Eggert <eggert@cs.ucla.edu>
941
ab9980cd
PE
942 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
943 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
944 or fscanf fails.
945 (system_process_attributes): Prefer plain char to unsigned char
946 when either will do. Clean up properly if interrupted or if
947 memory allocations fail. Don't assume sscanf succeeds. Remove
948 no-longer-needed workaround to stop GCC from whining. Read
949 command-line once, instead of multiple times. Check read status a
950 bit more carefully.
951
1396ac86
PE
952 Fix obscure porting bug with varargs functions.
953 The code assumed that int is treated like ptrdiff_t in a vararg
954 function, which is not a portable assumption. There was a similar
955 -- though these days less likely -- porting problem with various
956 assumptions that pointers of different types all smell the same as
957 far as vararg functions is conserved. To make this problem less
958 likely in the future, redo the API to use varargs functions.
959 * alloc.c (make_save_value): Remove this vararg function.
960 All uses changed to ...
961 (make_save_int_int_int, make_save_obj_obj_obj_obj)
962 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
963 New functions.
964 (make_save_ptr): Rename from make_save_pointer, for consistency with
965 the above. Define only on platforms that need it. All uses changed.
966
4d19d194
PE
9672013-07-18 Paul Eggert <eggert@cs.ucla.edu>
968
969 * keyboard.c: Try to fix typos in previous change.
970 (DISPLAY_LIST_INFO): New macro.
971 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 972 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 973
945c5bb1
JB
9742013-07-18 Juanma Barranquero <lekktu@gmail.com>
975
976 * keyboard.c (kbd_buffer_get_event):
977 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
978 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
979
f4b1eb36
PE
9802013-07-18 Paul Eggert <eggert@cs.ucla.edu>
981
5e679a2c
PE
982 * filelock.c: Fix unlikely file descriptor leaks.
983 (get_boot_time_1): Rework to avoid using emacs_open.
984 This doesn't actually fix a leak, but is better anyway.
985 (read_lock_data): Use read, not emacs_read.
986
a8cd4836
PE
987 * doc.c: Fix minor memory and file descriptor leaks.
988 * doc.c (get_doc_string): Fix memory leak when doc file absent.
989 (get_doc_string, Fsnarf_documentation):
990 Fix file descriptor leak on error.
991
ef30e638
PE
992 * term.c: Fix minor fdopen-related file descriptor leaks.
993 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
994 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
995
f4b1eb36
PE
996 * charset.c: Fix file descriptor leaks and errno issues.
997 Include <errno.h>.
998 (load_charset_map_from_file): Don't leak file descriptor on error.
999 Use plain record_xmalloc since the allocation is larger than
1000 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1001 of entries.
1002 * eval.c (record_unwind_protect_nothing):
1003 * fileio.c (fclose_unwind):
1004 New functions.
1005 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1006 The replacement doesn't block input, but that no longer seems
1007 necessary.
1008
b648c163
PE
10092013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1010
a0931322
PE
1011 * lread.c: Fix file descriptor leaks and errno issues.
1012 (Fload): Close some races that leaked fds or streams when 'load'
1013 was interrupted.
1014 (Fload, openp): Report error number of last nontrivial failure to open.
1015 ENOENT counts as trivial.
1016 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1017 New functions.
1018 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1019 now that the function is always called with a nonnegative arg.
1020 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1021 All uses replaced with ...
1022 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1023
b648c163
PE
1024 A few more minor file errno-reporting bugs.
1025 * callproc.c (Fcall_process):
1026 * doc.c (Fsnarf_documentation):
1027 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1028 * process.c (set_socket_option):
1029 Don't let a constructor trash errno.
1030 * doc.c: Include <errno.h>.
1031
b1dc4084
JB
10322013-07-16 Juanma Barranquero <lekktu@gmail.com>
1033
1034 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1035
c43843aa
PE
10362013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1037
50a30cce
PE
1038 Fix w32 bug with call-process-region (Bug#14885).
1039 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1040 to Fcall_process when the input is empty. This simplifies the
1041 code a bit. It makes no difference on POSIXish platforms but
1042 apparently it fixes a bug on w32.
1043
44e18199 1044 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1045 * fileio.c (close_file_unwind): Don't close if FD is negative;
1046 this can happen when unwinding a zapped file descriptor.
1047 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1048 in case Emacs runs out of memory between the two unwind-protects.
1049 Don't trash errno when closing FD.
1050 Zap the FD in the specpdl when closing it, instead of deferring
1051 the removal of the unwind-protect; this fixes a bug where a child
1052 function unwinds the stack past us.
1053
27e498e6
PE
1054 New unwind-protect flavors to better type-check C callbacks.
1055 This also lessens the need to write wrappers for callbacks,
1056 and the need for make_save_pointer.
1057 * alloca.c (free_save_value):
1058 * atimer.c (run_all_atimers):
1059 Now extern.
1060 * alloc.c (safe_alloca_unwind):
1061 * atimer.c (unwind_stop_other_atimers):
1062 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1063 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1064 * minibuf.c (choose_minibuf_frame_1):
1065 * process.c (make_serial_process_unwind):
1066 * xdisp.h (pop_message_unwind):
1067 * xselect.c (queue_selection_requests_unwind):
1068 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1069 * alloca.c (record_xmalloc):
1070 Prefer record_unwind_protect_ptr to record_unwind_protect with
1071 make_save_pointer.
1072 * alloca.c (Fgarbage_collect):
1073 Prefer record_unwind_protect_void to passing a dummy.
1074 * buffer.c (restore_buffer):
1075 * window.c (restore_window_configuration):
1076 * xfns.c, w32fns.c (do_unwind_create_frame)
1077 New wrapper. All record-unwind uses of wrappee changed.
1078 * buffer.c (set_buffer_if_live):
1079 * callproc.c (call_process_cleanup, delete_temp_file):
1080 * coding.c (code_conversion_restore):
1081 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1082 * editfns.c (save_excursion_restore)
1083 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1084 (save_restriction_restore):
1085 * eval.c (restore_stack_limits, un_autoload):
1086 * fns.c (require_unwind):
1087 * keyboard.c (recursive_edit_unwind, tracking_off):
1088 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1089 * macros.c (pop_kbd_macro, restore_menu_items):
1090 * nsfns.m (unwind_create_frame):
1091 * print.c (print_unwind):
1092 * process.c (start_process_unwind):
1093 * search.c (unwind_set_match_data):
1094 * window.c (select_window_norecord, select_frame_norecord):
1095 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1096 (fast_set_selected_frame):
1097 * xfns.c, w32fns.c (unwind_create_tip_frame):
1098 Return void, not a dummy Lisp_Object. All uses changed.
1099 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1100 * callproc.c (call_process_kill):
1101 * fileio.c (restore_point_unwind, decide_coding_unwind)
1102 (build_annotations_unwind):
1103 * insdel.c (Fcombine_after_change_execute_1):
1104 * keyboard.c (read_char_help_form_unwind):
1105 * menu.c (unuse_menu_items):
1106 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1107 * sound.c (sound_cleanup):
1108 * xdisp.c (unwind_redisplay):
1109 * xfns.c (clean_up_dialog):
1110 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1111 Accept no args and return void, instead of accepting and returning
1112 a dummy Lisp_Object. All uses changed.
1113 * cygw32.c (fchdir_unwind):
1114 * fileio.c (close_file_unwind):
1115 * keyboard.c (restore_kboard_configuration):
1116 * lread.c (readevalllop_1):
1117 * process.c (wait_reading_process_output_unwind):
1118 Accept int and return void, rather than accepting an Emacs integer
1119 and returning a dummy object. In some cases this fixes an
1120 unlikely bug when the corresponding int is outside Emacs integer
1121 range. All uses changed.
1122 * dired.c (directory_files_internal_unwind):
1123 * fileio.c (do_auto_save_unwind):
1124 * gtkutil.c (pop_down_dialog):
1125 * insdel.c (reset_var_on_error):
1126 * lread.c (load_unwind):
1127 * xfns.c (clean_up_file_dialog):
1128 * xmenu.c, nsmenu.m (pop_down_menu):
1129 * xmenu.c (cleanup_widget_value_tree):
1130 * xselect.c (wait_for_property_change_unwind):
1131 Accept pointer and return void, rather than accepting an Emacs
1132 save value encapsulating the pointer and returning a dummy object.
1133 All uses changed.
1134 * editfns.c (Fformat): Update the saved pointer directly via
1135 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1136 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1137 (unwind_body): New function.
1138 (record_unwind_protect): First arg is now a function returning void,
1139 not a dummy Lisp_Object.
1140 (record_unwind_protect_ptr, record_unwind_protect_int)
1141 (record_unwind_protect_void): New functions.
1142 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1143 * fileio.c (struct auto_save_unwind): New type.
1144 (do_auto_save_unwind): Use it.
1145 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1146 * insdel.c (struct rvoe_arg): New type.
1147 (reset_var_on_error): Use it.
1148 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1149 New constants.
1150 (specbinding_func): Remove; there are now several such functions.
1151 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1152 (set_unwind_protect_ptr): New function.
1153 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1154
4e604a5d
PE
1155 Be simpler and more consistent about reporting I/O errors.
1156 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1157 Say "Read error" and "Write error", rather than "I/O error", or
1158 "IO error reading", or "IO error writing", when a read or write
1159 error occurs.
1160 * process.c (Fmake_network_process, wait_reading_process_output)
1161 (send_process, Fprocess_send_eof, wait_reading_process_output):
1162 Capitalize diagnostics consistently. Put "failed foo" at the
1163 start of the diagnostic, so that we don't capitalize the
1164 function name "foo". Consistently say "failed" for such
1165 diagnostics.
1166 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1167 All callers changed. This is so it can use report_file_error.
1168 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1169 diagnostics consistently as above.
1170
a9757f6a
PE
1171 * fileio.c (report_file_errno): Fix errno reporting bug.
1172 If the file name is neither null nor a pair, package it up as a
1173 singleton list. All callers changed, both to this function and to
1174 report_file_error. This fixes a bug where the memory allocator
1175 invoked by list1 set errno so that the immediately following
1176 report_file_error reported the wrong errno value.
1177
c43843aa
PE
1178 Fix minor problems found by --enable-gcc-warnings.
1179 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1180 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1181
18c26d81
JD
11822013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1183
1184 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1185 Set event->arg to Qt if switch-event shall be generated.
1186 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1187
1188 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1189
1190 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1191 FOCUS_OUT_EVENT.
1192
1193 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1194 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1195 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1196 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1197 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1198 and there is a focused frame.
1199 (head_table): Add focus-in and focus-out.
1200 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1201 bind to handle-focus-in/out.
1202
1203 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1204 (Fhandle_switch_frame): Call Fhandle_focus_in.
1205 (syms_of_frame): defsubr handle-focus-in/out.
1206
6c6f1994
PE
12072013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1208
c7ddc792
PE
1209 Fix porting bug to older POSIXish platforms (Bug#14862).
1210 * sysdep.c (emacs_pipe): New function, that implements
1211 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1212 This should port better to CentOS 5 and to Mac OS X 10.6.
1213 All calls to pipe2 changed.
1214
6c6f1994
PE
1215 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1216 This makes the code easier to read and the executable a bit smaller.
1217 Do not replace all calls to Fcons that happen to create lists,
1218 just calls that are intended to create lists. For example, when
1219 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1220 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1221 Similarly for list2 through list5.
1222 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1223 * bytecode.c (exec_byte_code):
1224 * callint.c (quotify_arg, Fcall_interactively):
1225 * callproc.c (Fcall_process, create_temp_file):
1226 * charset.c (load_charset_map_from_file)
1227 (Fdefine_charset_internal, init_charset):
1228 * coding.c (get_translation_table, detect_coding_system)
1229 (Fcheck_coding_systems_region)
1230 (Fset_terminal_coding_system_internal)
1231 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1232 * composite.c (update_compositions, Ffind_composition_internal):
1233 * dired.c (directory_files_internal, file_name_completion)
1234 (Fsystem_users):
1235 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1236 * doc.c (Fsnarf_documentation):
1237 * editfns.c (Fmessage_box):
1238 * emacs.c (main):
1239 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1240 (Feval, eval_sub, Ffuncall, apply_lambda):
1241 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1242 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1243 (Fset_file_times, Finsert_file_contents)
1244 (Fchoose_write_coding_system, Fwrite_region):
1245 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1246 * font.c (font_registry_charsets, font_parse_fcname)
1247 (font_prepare_cache, font_update_drivers, Flist_fonts):
1248 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1249 * frame.c (make_frame, Fmake_terminal_frame)
1250 (x_set_frame_parameters, x_report_frame_params)
1251 (x_default_parameter, Fx_parse_geometry):
1252 * ftfont.c (syms_of_ftfont):
1253 * image.c (gif_load):
1254 * keyboard.c (command_loop_1):
1255 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1256 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1257 (Fminor_mode_key_binding, accessible_keymaps_1)
1258 (Faccessible_keymaps, Fwhere_is_internal):
1259 * lread.c (read_emacs_mule_char):
1260 * menu.c (find_and_return_menu_selection):
1261 * minibuf.c (get_minibuffer):
1262 * nsfns.m (Fns_perform_service):
1263 * nsfont.m (ns_script_to_charset):
1264 * nsmenu.m (ns_popup_dialog):
1265 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1266 (Fx_own_selection_internal):
1267 * nsterm.m (append2):
1268 * print.c (Fredirect_debugging_output)
1269 (print_prune_string_charset):
1270 * process.c (Fdelete_process, Fprocess_contact)
1271 (Fformat_network_address, set_socket_option)
1272 (read_and_dispose_of_process_output, write_queue_push)
1273 (send_process, exec_sentinel):
1274 * sound.c (Fplay_sound_internal):
1275 * textprop.c (validate_plist, add_properties)
1276 (Fput_text_property, Fadd_face_text_property)
1277 (copy_text_properties, text_property_list, syms_of_textprop):
1278 * unexaix.c (report_error):
1279 * unexcoff.c (report_error):
1280 * unexsol.c (unexec):
1281 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1282 (Fformat_mode_line, syms_of_xdisp):
1283 * xfaces.c (set_font_frame_param)
1284 (Finternal_lisp_face_attribute_values)
1285 (Finternal_merge_in_global_face, syms_of_xfaces):
1286 * xfns.c (x_default_scroll_bar_color_parameter)
1287 (x_default_font_parameter, x_create_tip_frame):
1288 * xfont.c (xfont_supported_scripts):
1289 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1290 (menu_help_callback, xmenu_show):
1291 * xml.c (make_dom):
1292 * xterm.c (set_wm_state):
1293 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1294 and similarly for list2 through list5.
1295
bafe80ce
PE
12962013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 * callproc.c (Fcall_process_region): Fix minor race and tune.
1299 (create_temp_file): New function, with the temp-file-creation part
1300 of the old Fcall_process_region. Use Fcopy_sequence to create the
1301 temp file name, rather than alloca + build_string, for simplicity.
1302 Don't bother to block input around the temp file creation;
1303 shouldn't be needed. Simplify use of mktemp. Use
1304 record_unwind_protect immediately after creating the temp file;
1305 this closes an unlikely race where the temp file was not removed.
1306 Use memcpy rather than an open-coded loop.
1307 (Fcall_process_region): Use the new function. If the input is
1308 empty, redirect from /dev/null rather than from a newly created
1309 empty temp file; this avoids unnecessary file system traffic.
1310
4700b5a5
PE
13112013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1312
5c97beae
PE
1313 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1314 Simplify by making this case like the other two. This is a bit
1315 slower on obsolete hosts, but the extra complexity isn't worth it.
1316
4700b5a5
PE
1317 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1318 * process.c (create_process) [!DOS_NT]:
1319 Remove now-unnecessary calls to emacs_close.
1320
f9a74c4c
EZ
13212013-07-13 Eli Zaretskii <eliz@gnu.org>
1322
922ae7ee
EZ
1323 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1324 returning early. (Bug#14850)
1325
f9a74c4c
EZ
1326 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1327 and inhibit-iso-escape-detection attributes of 'undecided'.
1328 (Bug#14822)
1329
5e301d76
PE
13302013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1331
69e0e5ee
PE
1332 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1333 Reported by Herbert J. Skuhra in
1334 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1335
5e301d76
PE
1336 Don't lose top specpdl entry when memory is exhausted.
1337 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1338 specpdl overflow here, to simplify callers; all callers changed.
1339 Always reserve an unused entry at the stack top; this avoids
1340 losing the top entry's information when memory is exhausted.
1341
7e649856
PE
13422013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1343
a773ed9a
PE
1344 Clean up errno reporting and fix some errno-reporting bugs.
1345 * callproc.c (Fcall_process):
1346 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1347 * process.c (create_process, Fmake_network_process):
1348 * unexaix.c (report_error):
1349 * unexcoff.c (report_error):
1350 Be more careful about reporting the errno of failed operations.
1351 The code previously reported the wrong errno sometimes.
1352 Also, prefer report_file_errno to setting errno + report_file_error.
1353 (Fcall_process): Look at openp return value rather than at path,
1354 as that's a bit faster and clearer when there's a numeric predicate.
1355 * fileio.c (report_file_errno): New function, with most of the
1356 old contents of report_file_error.
1357 (report_file_error): Use it.
1358 (Ffile_exists_p, Ffile_accessible_directory_p):
1359 Set errno to 0 when it is junk.
1360 * fileio.c (Faccess_file):
1361 * image.c (x_create_bitmap_from_file):
1362 Use faccessat rather than opening the file, to avoid the hassle of
1363 having a file descriptor open.
1364 * lisp.h (report_file_errno): New decl.
1365 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1366
7e649856
PE
1367 Minor EBADF fixes.
1368 * process.c (create_process, wait_reading_process_output) [AIX]:
1369 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1370 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1371 a multithreaded environment anyway).
1372 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1373
f6774c1a
AS
13742013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1375
1376 * image.c (x_find_image_file): Don't close a remote file handle.
1377
bacba3c2
PE
13782013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1379
1380 Fix races with threads and file descriptors.
1381 * callproc.c (Fcall_process_region):
1382 * dired.c (open_directory):
1383 * emacs.c (main, Fdaemon_initialized):
1384 * image.c (x_find_image_file):
1385 * inotify.c (Finotify_rm_watch):
1386 * lread.c (Flocate_file_internal):
1387 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1388 * term.c (term_mouse_moveto, init_tty):
1389 * termcap.c (tgetent):
1390 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1391 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1392 * unexhp9k800.c, unexmacosx.c (unexec):
1393 * callproc.c (Fcall_process_region):
1394 Use emacs_close, not close.
1395 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1396 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1397 and posix_close function on current platforms (which all lack them).
1398 (emacs_close): Use it. This should fix the races on GNU/Linux and
1399 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1400 and it should avoid closing random victim file descriptors on
1401 other platforms.
1402
653d4f43
PE
14032013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1404
c8536ec4
PE
1405 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1406 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1407 Touch up doc a bit.
1408
9c203066
PE
1409 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1410 This is for .gdbinit xbacktrace.
1411
653d4f43
PE
1412 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1413 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1414 (emacs_set_tty): Now static.
1415 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1416 * term.c (tty_capable_p, tty_default_color_capabilities)
1417 (get_tty_terminal, term_mouse_movement)
1418 (handle_one_term_event, init_tty, maybe_fatal):
1419 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1420 (tgetent, scan_file, name_match, compare_contin):
1421 * terminal.c (get_terminal):
1422 Use bool for boolean.
1423 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1424 Prefer char to unsigned char if either will do.
1425 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1426 (tty_write_glyphs): Prefer int to unsigned.
1427 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1428 All callers changed.
1429 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1430
45b683a1
PE
14312013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1432
29abe551
PE
1433 Port to C89.
1434 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1435 (B__dummy__): New dummy symbol, to pacify C89.
1436 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1437 they can't grok varargs macros.
1438 * dispnew.c (add_window_display_history)
1439 (add_frame_display_history):
1440 * print.c (print_object):
1441 * xdisp.c (debug_method_add):
1442 Use %p printf format only for void pointers.
1443 * emacs.c (usage_message): New constant, replacing ...
1444 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1445 (main): Adjust to usage reorg.
1446 * fns.c (syms_of_fns):
1447 * profiler.c (syms_of_profiler):
1448 Don't use non-constant struct initializers.
1449 * gnutls.h (gnutls_initstage_t):
1450 * lisp.h (enum Lisp_Fwd_Type):
1451 * lread.c (lisp_file_lexically_bound_p):
1452 * xsettings.c (anonymous enum):
1453 Remove trailing comma.
1454 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1455 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1456 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1457 (DEFUN): Use it.
1458 * regex.c (const_re_char): New type, to pacify strict C89.
1459 All uses of 'const re_char' replaced to use it.
1460 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1461 with glibc when strict C89. This change is imported from gnulib.
1462 All uses changed.
1463 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1464 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1465 Omit GNU_LINUX implementation, since it requires long long.
1466 * xterm.c (x_draw_underwave):
1467 Do not assume the traditional order of struct's members.
1468 (x_term_init): Rewrite to avoid the need for non-constant structure
1469 initializers.
1470
45b683a1 1471 Syntax cleanup, mostly replacing macros with functions.
763a086d 1472 This removes the need for the syntax_temp hack.
45b683a1
PE
1473 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1474 * syntax.c (SYNTAX_INLINE): New macro.
1475 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1476 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1477 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1478 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1479 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1480 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1481 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1482 Now constants, not macros.
1483 (syntax_temp) [!__GNUC__]: Remove.
1484 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1485 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1486 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1487 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1488 Move here from syntax.h; now functions, not macros. Except for the
1489 last function, these are static since only syntax.c uses them.
1490 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1491 All uses changed. Now a function, not a macro; use this fact
1492 to simplify the code.
1493 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1494 compiler bugs; no longer relevant.
1495 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1496 (SYNTAX_INLINE): New macro.
1497 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1498 for the new functions. Use bool for boolean member.
1499 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1500 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1501 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1502 (SETUP_BUFFER_SYNTAX_TABLE):
1503 Now extern inline functions, not macros.
1504 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1505 Remove; all uses replaced by implementation.
1506 (syntax_temp) [!__GNUC__]: Remove decl.
1507 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1508
29be4a50
JD
15092013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1510
1511 * emacs.c (main): Fix syntax error.
1512
954b166e
PE
15132013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1514
1515 Timestamp fixes for undo (Bug#14824).
1516 * atimer.c (schedule_atimer):
1517 * fileio.c (Ffile_newer_than_file_p):
1518 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1519 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1520 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1521 (syms_of_fileio): Remove Sclear_visited_file_name.
1522 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1523 file doesn't exist; this avoids an ambiguity with negative timestamps.
1524 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1525 * systime.h (make_emacs_time, invalid_emacs_time):
1526 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1527 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1528 * undo.c (record_first_change): Push (visited-file-modtime) onto
1529 undo list rather than reimplementing it by hand, incorrectly.
1530
d74647c3
KB
15312013-07-09 Ken Brown <kbrown@cornell.edu>
1532
1533 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1534
3c51b96b
JB
15352013-07-09 Juanma Barranquero <lekktu@gmail.com>
1536
1537 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1538
4ebbdd67
PE
15392013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 Handle errno and exit status a bit more carefully.
1542 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1543 number into an exit status. Instead, use EXIT_CANCELED.
1544 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1545 * callproc.c (relocate_fd):
1546 * emacs.c (close_output_streams, main):
1547 * process.c (create_process):
1548 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1549 Use emacs_perror for simplicity.
1550 * callproc.c (relocate_fd, main):
1551 * sysdep.c (sys_subshell):
1552 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1553 (shut_down_emacs): Use emacs_write, not write.
1554 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1555 * fileio.c (Fcopy_file, e_write):
1556 * nsterm.m (ns_select):
1557 * process.c (send_process):
1558 * sound.c (vox_write):
1559 Use emacs_write_sig, not emacs_write.
1560 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1561 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1562 New constants.
1563 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1564 of write.
1565 (emacs_full_write): New function.
1566 (emacs_write): Rewrite to use it.
1567 (emacswrite_sig, emacs_perror): New functions.
1568 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1569
44e18199 15702013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1571
1572 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1573 on NS even if it is present. Pixmap on NS is a void*.
1574
9caab067
PE
15752013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 Port to Ubuntu 10 (Bug#14803).
1578 Problem reported by T.V. Raman.
1579 * process.c (close_on_exec, accept4, process_socket):
1580 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1581
1d442672
EZ
15822013-07-07 Eli Zaretskii <eliz@gnu.org>
1583
1584 * w32.c (sys_dup): Declare prototype.
1585
1586 * filelock.c:
1587 * emacs.c:
1588 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1589
067428c1
PE
15902013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1591
1592 Make file descriptors close-on-exec when possible (Bug#14803).
1593 This simplifies Emacs a bit, since it no longer needs to worry
1594 about closing file descriptors by hand in some cases.
1595 It also fixes some unlikely races. Not all such races, as
1596 libraries often open files internally without setting
1597 close-on-exec, but it's an improvement.
1598 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1599 * callproc.c (Fcall_process) [!MSDOS]:
1600 * emacs.c (main) [!DOS_NT]:
1601 * nsterm.m (ns_term_init):
1602 * process.c (create_process):
1603 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1604 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1605 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1606 Prefer mkostemp with O_CLOEXEC to mkstemp.
1607 * callproc.c (relocate_fd) [!WINDOWSNT]:
1608 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1609 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1610 now using pipe2.
1611 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1612 Make the resulting file descriptor close-on-exec.
1613 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1614 * lread.c (load_descriptor_list, load_descriptor_unwind):
1615 Remove; no longer needed. All uses removed.
1616 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1617 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1618 New functions.
1619 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1620 (Fmake_network_process, Fnetwork_interface_list):
1621 (Fnetwork_interface_info, server_accept_connection):
1622 Make newly-created socket close-on-exec.
1623 * sysdep.c (emacs_open, emacs_fopen):
1624 Make new-created descriptor close-on-exec.
1625 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1626 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1627
0da857dd
JD
16282013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1629
1630 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1631 for NS_IMPL_GNUSTEP.
1632
5f86adcd
PE
16332013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1634
1635 Fix openp errno handling.
1636 * callproc.c (Fcall_process): Preserve openp errno around close.
1637 * lread.c (openp): Set errno when returning -1, as some callers
1638 expect this.
1639
1afb1d07
JD
16402013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1641
1642 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1643
1644 * nsterm.h (NSSavePanel): Update comment.
1645 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1646 (ns_run_file_dialog): Declare.
1647
1648 * nsfns.m: Remove panelOK.
1649 (ns_fd_data): New.
1650 (ns_run_file_dialog): New function.
1651 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1652 event loop, so file dialog is popped up by ns_run_file_dialog, called
1653 by sendEvent (Bug#14578).
1654 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1655
3323c263
EZ
16562013-07-06 Eli Zaretskii <eliz@gnu.org>
1657
fdda0220
EZ
1658 * xdisp.c (default_line_pixel_height): New function.
1659 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1660 (try_cursor_movement, redisplay_window, try_window)
1661 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1662
1663 * window.c (window_scroll_pixel_based): use
1664 default_line_pixel_height.
1665
1666 * dispextern.h (default_line_pixel_height): Add prototype.
1667
1668 * frame.c (x_set_line_spacing): Accept a float value for
1669 line-spacing parameter, per the documentation.
1670
3323c263
EZ
1671 * data.c (Fmultibyte_string_p): Doc fix.
1672
47ba6d43
PE
16732013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1674
406af475
PE
1675 Use emacs_open more consistently when opening files.
1676 This handles EINTR more consistently now, and makes it easier
1677 to introduce other uniform changes to file descriptor handling.
1678 * src/systdio.h: New file.
1679 * src/buffer.c (mmap_init):
1680 * cygw32.c (chdir_to_default_directory):
1681 * dispnew.c (Fopen_termscript):
1682 * emacs.c (Fdaemon_initialized):
1683 * fileio.c (Fdo_auto_save):
1684 * image.c (slurp_file, png_load_body, jpeg_load_body):
1685 * keyboard.c (Fopen_dribble_file):
1686 * lread.c (Fload):
1687 * print.c (Fredirect_debugging_output):
1688 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1689 * termcap.c (tgetent):
1690 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1691 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1692 * w32term.c (w32_initialize) [CYGWIN]:
1693 * xfaces.c (Fx_load_color_file):
1694 Use emacs_open instead of plain open, and emacs_fopen instead of
1695 plain fopen.
1696 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1697 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1698 * callproc.c (default_output_mode): New constant.
1699 (Fcall_process): Use it to call emacs_open instead of plain creat.
1700 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1701 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1702 (emacs_fopen): New function.
1703 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1704 Include <lisp.h>, for emacs_open.
1705 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1706
47ba6d43
PE
1707 Remove duplicate #include directives.
1708 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1709 * xfaces.c:
1710 Don't include stdio.h twice.
1711 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1712 Don't include sys/types.h or stdio.h twice.
1713 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1714 * lread.c: Don't include coding.h twice.
1715 * nsfont.m: Don't include frame.h twice.
1716 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1717 * ralloc.c: Don't include <unistd.h> twice.
1718 * xdisp.c: Don't include font.h twice.
1719 * xterm.c: Don't include fontset.h twice.
1720 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1721
b9ed53d5
PE
17222013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 Scale ImageMagick images more carefully.
1725 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1726 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1727 Be more careful about avoiding undefined behavior after
1728 integer overflow and division by zero.
1729
cf13177e
YM
17302013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1731
1732 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1733 (syms_of_w32fns): DEFSYM them.
1734 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1735 (CCHDEVICENAME): Define macros if not defined.
1736 (struct MONITOR_INFO_EX): New struct.
1737 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1738 (enum_display_monitors_fn): New variable.
1739 (globals_of_w32fns): Initialize it.
1740 (Fx_display_pixel_width, Fx_display_pixel_height)
1741 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1742 multi-monitor setups in docstrings.
1743 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1744 screen size by primary monitor's millimeter per pixel.
1745 (w32_monitor_enum, w32_display_monitor_attributes_list)
1746 (w32_display_monitor_attributes_list_fallback)
1747 (Fw32_display_monitor_attributes_list): New functions.
1748 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1749
1750 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1751 if not defined.
1752 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1753
86dfb7a8
MA
17542013-07-04 Michael Albinus <michael.albinus@gmx.de>
1755
1756 * fileio.c (Qfile_notify_error): New error symbol.
1757
1758 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1759 * inotify.c (inotify_callback, symbol_to_inotifymask)
1760 (Finotify_add_watch, Finotify_rm_watch): Use it.
1761 (inotifyevent_to_event): Exchange order of cookie and file name.
1762 (Finotify_add_watch): Adapt docstring.
1763
1764 * lisp.h (Qfile_notify_error): Declare.
1765
2c1c974b
PE
17662013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1769 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1770 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1771 which did not work (see <http://bugs.gnu.org/14569#307>).
1772 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1773 && (!noninteractive || initialized)). This attempts to thread
1774 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1775
7a35b20f
JB
17762013-07-04 Juanma Barranquero <lekktu@gmail.com>
1777
1778 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1779 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1780
1ce5cd04
PE
17812013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1784 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1785 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1786 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1787
57f8c490
PE
17882013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1791 Define to __sys_siglist.
1792
bcffb5ca
EZ
17932013-07-02 Eli Zaretskii <eliz@gnu.org>
1794
1795 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1796 word-wrap, so that overflow-newline-into-fringe would work in
1797 visual-line-mode. (Bug#2749)
1798 (move_it_in_display_line_to): When the last scanned display
1799 element fits exactly on the display line, and
1800 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1801 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1802 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1803 finding buffer position that corresponds to pixel coordinates,
1804 e.g. in buffer_posn_from_coords.
1805
2c41e781
JD
18062013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1807
1808 * process.c (handle_child_signal): Call catch_child_signal if
1809 NS_IMPL_GNUSTEP.
1810
c2418359
PE
18112013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1812
52a9bcae
PE
1813 Don't convert function pointers to void * and back.
1814 It isn't portable C, and it's easy enough to avoid.
1815 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1816 (make_save_value): Add support for SAVE_FUNCPOINTER.
1817 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1818 * print.c (print_object):
1819 Distinguish function from object pointers.
1820 * lisp.h (SAVE_FUNCPOINTER): New constant.
1821 (SAVE_SLOT_BITS): Adjust to it.
1822 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1823 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1824 (voidfuncptr): New typedef.
1825 (struct Lisp_Save_Value): New member data[0].funcpointer.
1826 (XSAVE_FUNCPOINTER): New function.
1827
c2418359
PE
1828 Simplify buildobj processing.
1829 * Makefile.in (buildobj.h): Make it a sequence of strings each
1830 followed by comma, rather than a single string. Put it into a
1831 .tmp file in case there's an error while generating it.
1832 (gl-stamp): Use .tmp for temp files.
1833 (mostlyclean): Clean .tmp files.
1834 * doc.c (buildobj): Move to just the routine that needs it.
1835 It's now an array of strings, so processing is simpler.
1836
8f43ce49
PE
18372013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1840 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1841 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1842 Invoke malloc_enable_thread even when not interactive.
1843 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1844 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1845 in this case, since the underlying bug has now been fixed.
1846
24827db9
JB
18472013-07-01 Juanma Barranquero <lekktu@gmail.com>
1848
1849 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1850 unlinking it (bug#14691).
1851
ef099a94
MN
18522013-06-30 Michal Nazarewicz <mina86@mina86.com>
1853
1854 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1855 before checking whether buffer is modified. This lets
1856 `kill-buffer-query-functions' cancel killing of the buffer or save
1857 its content before `kill-buffer' asks user the "Buffer %s
1858 modified; kill anyway?" question.
1859
9d3f2fc2
JD
18602013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1861
1862 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1863 Let the super performKeyEquivalent deal with them (Bug#14747).
1864
e6c6c8c7
PE
18652013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1866
1d71c1d9
PE
1867 * widget.c (resize_cb): Remove unused local.
1868
8f5f35cc
PE
1869 Do not use GTK 3 if it exists but cannot be compiled.
1870 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1871 * xterm.c (x_error_handler) [!USE_GTK]:
1872 Do not use GTK 3.
1873
e6c6c8c7
PE
1874 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1875
0ba54312
EZ
18762013-06-30 Eli Zaretskii <eliz@gnu.org>
1877
5d1c3286
EZ
1878 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1879 to the valid range of values. (Bug#14753)
1880
0ba54312
EZ
1881 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1882 when moving point by using the current glyph matrix. This avoids
1883 the need to force redisplay when this function is called in a
1884 loop.
1885
9c90cc06
PE
18862013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1887
1888 Fix minor problems found by static checking.
1889 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1890 Redo the latter's body to sidestep GCC parenthesization warnings.
1891 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1892 * coding.c (detect_coding, detect_coding_system):
1893 * coding.h (struct undecided_spec):
1894 Use bool for boolean.
1895 * image.c (QCmax_width, QCmax_height): Now static.
1896 * xdisp.c (Fmove_point_visually): Remove unused local.
1897
4c672a0f
EZ
18982013-06-29 Eli Zaretskii <eliz@gnu.org>
1899
1900 * xdisp.c (Fmove_point_visually): New function.
1901
c1ea3abf
JB
19022013-06-28 Kenichi Handa <handa@gnu.org>
1903
1904 * coding.h (define_coding_undecided_arg_index): New enum.
1905 (coding_attr_index): New members
1906 coding_attr_undecided_inhibit_null_byte_detection,
1907 coding_attr_undecided_inhibit_iso_escape_detection,
1908 coding_attr_undecided_prefer_utf_8.
1909 (undecided_spec): New struct.
1910 (struct coding_system): New member `undecided' of the member
1911 `spec'.
1912
1913 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1914 (detect_coding): Likewise.
1915 (detect_coding_system): Likewise.
1916 (Fdefine_coding_system_internal): New coding system properties
1917 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1918 :prefer-utf-8.
1919 (syms_of_coding): Adjust for coding_arg_undecided_max.
1920
ba3de9e6
PE
19212013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * image.c (x_from_xcolors): Remove unused local.
1924
547c9269
YM
19252013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1926
1927 Defer image data transfer between X client and server until actual
1928 display happens.
1929
1930 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1931 and `mask_img'.
1932
1933 * image.c (Destroy_Image): Remove.
1934 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1935 `mask_p', and `colors_p'. All uses changed.
1936 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1937 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1938 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1939 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1940 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1941 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1942 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1943 (image_get_x_image, image_unget_x_image): New functions or macros.
1944 (image_background, image_background_transparent, x_to_xcolors)
1945 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1946 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1947 instead of Destroy_Image.
1948 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1949 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1950 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1951 (imagemagick_load_image, svg_load_image): Use them instead of
1952 x_create_x_image_and_pixmap, and x_put_x_image followed by
1953 x_destroy_x_image, respectively.
1954 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1955 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1956 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1957 background_transparent fields.
1958 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1959 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1960
dae2f5ef
PE
19612013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1964 This mostly consists of undoing recent changes.
1965 * callproc.c (Fcall_process):
1966 * process.c (create_process):
1967 Do not worry about catching SIGCHLD here, undoing previous change.
1968 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1969 * process.c, process.h (catch_child_signal):
1970 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1971 * process.c (catch_child_handler): Don't worry about being called
1972 lazily and do not assume caller has blocked SIGCHLD, undoing
1973 previous change. Move first-time stuff back to
1974 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1975 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1976 set lib_child_handler if it's already initialized, which may
1977 help avoid problems on GNUStep.
1978
fa55d2aa
PE
19792013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1980
1981 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1982 * callproc.c (Fcall_process):
1983 * process.c (create_process):
1984 Make sure SIGCHLD is caught before we fork,
1985 since Emacs startup no arranges to catch SIGCHLD.
1986 * process.c (lib_child_handler): Initialize to null, not to
1987 dummy_handler.
1988 (catch_child_signal): Allow self to be called lazily.
1989 Do nothing if it's already been called.
1990 Assume caller has blocked SIGCHLD (all callers do now).
1991 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1992 just before it's really needed.
1993 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1994 since it hasn't been caught yet.
1995
f3f9606c
LMI
19962013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1997
1998 * image.c (compute_image_size): New function to implement
1999 :max-width and :max-height.
2000 (imagemagick_load_image): Use it.
2001
c7041908
PE
20022013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2005 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2006 Now extern.
2007 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2008 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2009 the SIGCHLD handler, since the code is not atomic and (due to glib)
2010 signals may be arriving now.
2011 * sysdep.c (init_signals): Do not catch child signals here;
2012 'main' now does that later, at a safer time.
2013
f86852b4
PE
20142013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2015
0dfeed58
PE
2016 Clean up SIGCHLD handling a bit (Bug#14569).
2017 * process.c, process.h (catch_child_signal):
2018 Now always extern, even if !NS_IMPL_GNUSTEP.
2019 * process.c (catch_child_signal): Move glib tickler here from
2020 init_process_emacs, so that it's done earlier in Emacs
2021 initialization. Also move the noninteractive && !initialized
2022 check here from init_process_emacs. This is all a bit cleaner for
2023 GNUish platforms, and I hope it works around the Cygwin bug.
2024 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2025 that glib signal handling is tickled before glib creates threads.
2026
f86852b4
PE
2027 * process.c (wait_reading_process_output): Avoid int overflow
2028 when reading more than 2 GiB total from a process.
2029
cbd6509c
PE
20302013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 * process.c (create_process): Handle a couple more cases,
2033 i.e., work even if new_argv and wait_child_setup[i] are cached.
2034 Use Fcall_process's style for volatile vars.
2035
9de1114a
AS
20362013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2037
2038 * process.c (create_process): Mark PROCESS volatile.
2039
fbe9e0b9
PE
20402013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2041
2042 Use C99-style flexible array members if available.
2043 This avoids some subtle aliasing issues, which typically
2044 aren't a problem with GCC but may be a problem elsewhere.
2045 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2046 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2047 In either case, it uses a flexible array member rather than
2048 the old struct hack. All uses changed.
2049 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2050 Adjust to sdata reorganization.
2051 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2052 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2053 that ports better to pre-C99 non-GCC.
2054 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2055 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2056 as the latter has changed.
2057 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2058 and port better to pre-C99 GCC.
2059 * image.c (struct xpm_cached_color):
2060 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2061 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2062 Use FLEXIBLE_ARRAY_MEMBER.
2063 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2064 Move decl to top level so it gets checked against implementation.
2065 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2066 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2067
1fc71008
PE
20682013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2069
2070 * syntax.c: Integer cleanups.
2071 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2072 All uses that need 0-or-2 changed to:
2073 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2074 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2075 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2076 (char_quoted, prev_char_comend_first, back_comment)
2077 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2078 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2079 Use bool for boolean.
2080 (update_syntax_table, skip_chars, skip_syntaxes):
2081 Prefer int to unsigned when either will do.
2082 (back_comment): Return boolean success flag, like forw_comment,
2083 instead of positive-or-minus-1 (which might have overflowed int anyway).
2084 Don't stuff ptrdiff_t into int.
2085 (syntax_spec_code, syntax_code_spec): Now const.
2086 (Fmatching_paren, scan_lists, scan_sexps_forward):
2087 Use enum syntaxcode for syntax code.
2088 (Fmatching_paren): Check that arg is a character, not just an integer.
2089 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2090 (Finternal_describe_syntax_value): Omit no-longer-needed
2091 comparison to 0.
2092 (skip_chars): Use char, not unsigned char, when the distinction
2093 doesn't matter.
2094 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2095 * bytecode.c (exec_byte_code):
2096 * syntax.c (syntax_spec_code, Fchar_syntax)
2097 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2098 (init_syntax_once):
2099 * syntax.h (SYNTAX_WITH_FLAGS):
2100 Omit unnecessary casts.
2101
b932cad7
EZ
21022013-06-20 Eli Zaretskii <eliz@gnu.org>
2103
2104 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2105 line dimensions here, to avoid race conditions with the main
2106 thread. (Bug#14062, bug#14630, bug#14669)
2107
2108 * w32term.c (w32_draw_window_cursor): Compute the header line and
2109 mode line dimensions here.
2110 <w32_system_caret_window, w32_system_caret_hdr_height>:
2111 <w32_system_caret_mode_height>: New variables.
2112
2113 * w32term.h: Declare them.
2114
89561f72
PE
21152013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2116
5013fc08
PE
2117 * alloc.c (die): Move "assertion failed" string here ...
2118 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2119 COND when SUPPRESS_CHECKING. This shrinks the executable text
2120 size by 0.8% to 2.2% when configured with --enable-checking,
2121 depending on optimization flags (GCC 4.8.1 x86-64).
2122
89561f72
PE
2123 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2124
763a086d 21252013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2126
2127 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2128 base is 2; this is more accurate.
2129
983aeb9a
JB
21302013-06-19 Juanma Barranquero <lekktu@gmail.com>
2131
2132 * sound.c (string_default): Move to !WINDOWSNT section.
2133 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2134
178ba3e6
PE
21352013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2136
bbc51b15
PE
2137 * sound.c: Integer cleanups.
2138 Remove unnecessary forward decls.
2139 (struct sound_device): The 'file' member is now a Lisp_Object, not
2140 a char *, so that we needn't invoke alloca on a huge size.
2141 (Fplay_sound_internal): Adjust to this.
2142 (string_default): New function.
2143 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2144 Use it to adjust to the struct sound_device change.
2145 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2146 (be2hs) [0]: Remove.
2147
178ba3e6
PE
2148 * syntax.c (skip_chars): Don't use uninitialized storage
2149 when searching a multibyte buffer for characters that are not in a
2150 unibyte string that contains non-ASCII characters.
2151
69f60cdc
JD
21522013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2153
2154 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2155 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2156
0d6224d4
PE
21572013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2158
2159 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2160
3c542890
KH
21612013-06-18 Kenichi Handa <handa@gnu.org>
2162
f7e3f7cd
KH
2163 * font.c (Ffont_spec): Signal an error for an invalid font name
2164 (Bug#14648).
3c542890 2165
9349e5f7
PE
21662013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2167
2168 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2169 In particular this ports to 32-bit sparc Sun cc.
2170 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2171 array with a dummy element at specpdl[-1], so that its address can
2172 be taken portably.
2173 (unbind_to): Do not copy the binding; not needed, now that we
2174 copy old_value in the one place where the copy is needed.
2175 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2176 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2177 (union specbinding): Rename from struct specbinding. Redo layout
2178 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2179 which is not portable. With Sun C 5.12 32-bit sparc, the
2180 declaration causes nargs to be an unsigned bitfield, a behavior
2181 that the C standard allows; but Emacs wants nargs to be signed.
2182 The overall type is now a union of structures rather than a
2183 structure of union of structures, and the 'kind' member is now a
2184 bitfield, so that the overall type doesn't grow. All uses changed.
2185 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2186
0a4df6a5
PE
21872013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2188
ec6ecaad
PE
2189 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2190 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2191
0a4df6a5
PE
2192 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2193
7bfe8dbc
EZ
21942013-06-17 Eli Zaretskii <eliz@gnu.org>
2195
2196 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2197 unless we know that the window w's frame is a frame object.
2198 Another attempt at solving bug#14062 and bug#14630.
2199
708e05f6
LMI
22002013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2201
2202 * textprop.c (property_set_type): New enum.
2203 (add_properties): Allow appending/prepending text properties.
2204 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2205 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2206 add_text_properties_1.
2207 (Fadd_face_text_property): New function that calls
2208 add_text_properties_1.
2209
84575e67
PE
22102013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2211
2212 Move functions from lisp.h to individual modules when possible.
2213 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2214 * alloc.c (XFLOAT_INIT, set_symbol_name):
2215 * buffer.c (CHECK_OVERLAY):
2216 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2217 (set_char_table_parent):
2218 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2219 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2220 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2221 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2222 (set_blv_valcell):
2223 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2224 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2225 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2226 (backtrace_args, backtrace_debug_on_exit):
2227 * floatfns.c (CHECK_FLOAT):
2228 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2229 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2230 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2231 (set_hash_index_slot):
2232 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2233 * marker.c (CHECK_MARKER):
2234 * textprop.c (CHECK_STRING_OR_BUFFER):
2235 * window.c (CHECK_WINDOW_CONFIGURATION):
2236 Move here from lisp.h, and make these functions static rather than
2237 extern inline.
2238 * buffer.c (Qoverlayp):
2239 * data.c (Qsubrp):
2240 * fns.c (Qhash_table_p):
2241 * window.c (Qwindow_configuration_p):
2242 Now static.
2243 * lisp.h: Remove the abovementioned defns and decls.
2244
44e18199 2245 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2246 In lisp.h, prefer functions to function-like macros, and
2247 constants to object-like macros, when either will do. This:
2248 . simplifies use, as there's no more need to worry about
2249 arguments' side effects being evaluated multiple times.
2250 . makes the code easier to debug on some platforms.
2251 However, when using gcc -O0, keep using function-like macros
2252 for a few critical operations, for performance reasons.
2253 This sort of thing isn't needed with gcc -Og, but -Og
2254 is a GCC 4.8 feature and isn't widely-enough available yet.
2255 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2256 Remove enum lsb_bits; no longer needed.
2257 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2258 * buffer.c (Qoverlap):
2259 * data.c (Qsubrp):
2260 * fns.c (Qhash_table_p):
2261 Now extern, so lisp.h can use these symbols.
2262 * dispextern.h: Include character.h, for MAX_CHAR etc.
2263 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2264 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2265 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2266 (GLYPH_CODE_P): Move here from lisp.h.
2267 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2268 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2269 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2270 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2271 XUNTAG now returns void *.
2272 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2273 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2274 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2275 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2276 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2277 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2278 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2279 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2280 New macros, renamed from their sans-lisp_h_ counterparts.
2281 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2282 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2283 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2284 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2285 If compiling via GCC without optimization, define these as macros
2286 in addition to inline functions.
2287 To disable this, compile with -DINLINING=0.
2288 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2289 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2290 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2291 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2292 (INTMASK, VALMASK): Now macros, since static values cannot be
2293 accessed from extern inline functions.
2294 (VALMASK): Also a constant, for benefit of old GDB.
2295 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2296 is INTEGERP, which can fold it in.
5165d44a 2297 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2298 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2299 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2300 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2301 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2302 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2303 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2304 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2305 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2306 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2307 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2308 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2309 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2310 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2311 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2312 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2313 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2314 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2315 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2316 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2317 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2318 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2319 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2320 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2321 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2322 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2323 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2324 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2325 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2326 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2327 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2328 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2329 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2330 Now functions.
2331 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2332 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2333 (VALMASK): Define in one place rather than in two, merging the
2334 USE_LSB_TAG parts; this is simpler.
2335 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2336 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2337 Move up, to avoid use before definition.
2338 Also include "globals.h" earlier, for the same reason.
2339 (make_natnum): New function.
2340 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2341 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2342 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2343 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2344 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2345 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2346 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2347 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2348 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2349 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2350 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2351 (Qwindow_configuration_p, Qimage): New forward declarations.
2352 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2353 (STRING_COPYIN): Remove; unused.
2354 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2355 (xcar_addr, xcdr_addr): New functions. All uses changed.
2356 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2357 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2358 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2359 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2360 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2361 (TYPE_RANGED_INTEGERP): Simplify.
2362 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2363 (setlocale, fixup_locale, synchronize_system_messages_locale)
2364 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2365 Now empty functions, not macros.
2366 (functionp): Return bool, not int.
2367 * window.c (Qwindow_configuration_p): Now extern,
2368 so window.h can use it.
2369 * window.h (Qwindowp): Move decl back to lisp.h.
2370
9583ec36
EZ
23712013-06-15 Eli Zaretskii <eliz@gnu.org>
2372
2373 * xdisp.c (Fline_pixel_height): New function, required for solving
2374 bug #14567.
2375
210272ce
PE
23762013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2377
2378 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2379
de0503df
SM
23802013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2381
2382 * lread.c (syms_of_lread):
2383 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2384
afbfe143
KD
23852013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2386
2387 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2388
d177e213
XF
23892013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2390
2391 * fileio.c (expand_file_name): Doc fix.
2392
05e3e412
PE
23932013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2394
f7394b12
PE
2395 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2396 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2397 Wait for self, not for 0. This can't hurt on GNU or similar
2398 system, and may help with Cygwin.
2399
05e3e412
PE
2400 * keyboard.c: Don't use PROP (...) as an lvalue.
2401 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2402 Use set_prop (A, B), not PROP (A) = B.
2403
17dd3097
EZ
24042013-06-10 Eli Zaretskii <eliz@gnu.org>
2405
2406 * xdisp.c (get_it_property): Use it->window instead of generating
2407 a Lisp object from it->w.
2408
52fab9c9
EZ
24092013-06-09 Eli Zaretskii <eliz@gnu.org>
2410
2411 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2412 get-char-property the window that is being rendered, instead of
2413 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2414 (compute_display_string_pos): When W is NULL, use the current
2415 buffer as the object to pass to get-char-property.
2416 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2417 pointer member of the bidi iterator, since no window is pertinent
2418 to this function.
52fab9c9 2419
5bf97bfc
EZ
24202013-06-08 Eli Zaretskii <eliz@gnu.org>
2421
2422 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2423 being displayed, and pass it to compute_display_string_pos.
2424 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2425 (bidi_paragraph_init): All callers changed.
2426
2427 * xdisp.c (init_from_display_pos, init_iterator)
2428 (handle_single_display_spec, next_overlay_string)
2429 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2430 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2431 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2432 (compute_display_string_pos): Accept additional argument, the
2433 window being displayed, and pass it to Fget_char_property.
2434 (Bug#14575)
2435
2436 * dispextern.h (struct bidi_it): New member w, the window being
2437 displayed.
2438 (compute_display_string_pos): Adjust prototype.
2439
5de0e011
JD
24402013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2441
e7b41c4c 2442 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2443
2444 * process.c (wait_reading_process_output): Check for NS before GLIB.
2445 GLIB may be linked in due to rsvg, but ns_select must be called.
2446
5de0e011
JD
2447 * xgselect.c (xg_select): Remove call to window_system_available
2448 and g_main_context_pending at the top, so Gdk events (i.e. file
2449 notify) are processed when Emacs is started with -nw.
2450
a822acff
EZ
24512013-06-07 Eli Zaretskii <eliz@gnu.org>
2452
2453 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2454 (ctagsfiles3): New variable, includes only *.m files.
2455 (TAGS): Use an explicit language name in the regular expressions,
2456 to avoid transformation of '/SOMETHING' by MSYS to
2457 'c:\MSYS\SOMETHING'.
2458
6c0a9ed1
RC
24592013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2460
2461 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2462
9ef6111b
EZ
24632013-06-06 Eli Zaretskii <eliz@gnu.org>
2464
2465 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2466 still need to set the mouse pointer shape and activate help-echo.
2467 (Bug#14558)
2468
7d300d64
PE
24692013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2470
2471 A few porting etc. fixes for the new file monitor code.
2472 See the thread containing
2473 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2474 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2475 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2476 (dir_monitor_callback, Fgfile_rm_watch):
2477 Use assq_no_quit instead of Fassoc, for speed.
2478 (dir_monitor_callback, Fgfile_rm_watch):
2479 eassert that the monitor is a fixnum.
2480 (dir_monitor_callback): No need for CDR_SAFE.
2481 Simplify building of lisp with alternative tails.
2482 (Fgfile_add_watch, Fgfile_rm_watch):
2483 Do not assume glib functions set errno reliably on failure.
2484 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2485 and signal an error otherwise.
2486 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2487 Use Fdelq instead of Fdelete, for speed.
2488
817ebfcf
EZ
24892013-06-05 Eli Zaretskii <eliz@gnu.org>
2490
2491 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2492 don't insist on being invoked on a highlighted tool-bar button.
2493 Avoids losing tool-bar functionality when mouse-highlight is nil.
2494 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2495 Don't highlight when mouse-highlight is nil.
2496 (note_mouse_highlight): When mouse-highlight is nil, don't return
2497 right away; instead, run tool-bar and mode-line highlight
2498 subroutine, clear any existing highlight, and revert the mouse
2499 pointer to its default shape. (Bug#14558)
2500
55577e7c
SM
25012013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2502
2503 * lisp.mk (lisp): Add prog-mode.el.
2504
f019a684
PE
25052013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2508 * process.c (dummy_handler): New function.
2509 (lib_child_handler): New static var.
2510 (handle_child_signal): Invoke it.
2511 (catch_child_signal): If a library has set up a signal handler,
2512 save it into lib_child_handler.
2513 (init_process_emacs): If using glib and not on Windows, tickle glib's
2514 child-handling code so that it initializes its private SIGCHLD handler.
2515 * syssignal.h (SA_SIGINFO): Default to 0.
2516 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2517 31; it should no longer be needed now.
2518
90db8702
MA
25192013-06-05 Michael Albinus <michael.albinus@gmx.de>
2520
2521 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2522
2523 * gfilenotify.c (globals_of_gfilenotify): New function.
2524 (syms_of_gfilenotify): Move global initialization there.
2525
2526 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2527
bfa3acd6
SM
25282013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2529
2530 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2531 * keyboard.c (menu_bar_items, tool_bar_items):
2532 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2533 not override local keymaps any more.
2534
ba59bd80
EZ
25352013-06-04 Eli Zaretskii <eliz@gnu.org>
2536
2537 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2538
7f203aa1
EZ
25392013-06-03 Eli Zaretskii <eliz@gnu.org>
2540
9337e206
EZ
2541 * w32console.c (initialize_w32_display): Return the dimensions of
2542 the console window via 2 additional arguments, not via the current
2543 frame. This avoids crashes due to overrunning the bounds of
2544 frame's decode_mode_spec_buffer, which is not resized following
2545 the change of the frame dimensions from the initial 10x10.
2546
2547 * w32term.h (w32_initialize_display_info): Adjust prototype.
2548
2549 * term.c (init_tty): Take dimensions of the frame from the values
2550 returned by initialize_w32_display.
2551
7f203aa1
EZ
2552 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2553 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2554 (LIBES): Add $(GFILENOTIFY_LIBS).
2555
2556 * w32inevt.c (handle_file_notifications): Add dummy implementation
2557 for !HAVE_W32NOTIFY.
2558
2559 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2560
55a87246
JD
25612013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2562
2563 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2564
2565 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2566
2567 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2568
3d5ee10a
PE
25692013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2570
2571 Fix minor problems found by static checking.
2572 * data.c (pure_write_error):
2573 Use xsignal2, not Fsignal, as Fsignal might return.
2574 * eval.c (set_backtrace_debug_on_exit): Now static.
2575 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2576 No longer inline. EXTERN_INLINE is needed only for functions
2577 defined in .h files. Reindent function header as per GNU style.
2578 (backtrace_p, backtrace_top, backtrace_next):
2579 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2580 compiler or linker. Add extern decls to pacify gcc -Wall.
2581 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2582 Now static.
2583 * frame.c (free_monitors): Define only on platforms that need it.
2584 * nsterm.m (ns_term_init):
2585 * process.c (catch_child_signal):
2586 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2587 defined on all porting targets these days.
2588 * process.c, process.h (catch_child_signal):
2589 Make it extern only if NS_IMPL_GNUSTEP is defined.
2590
e2d8a6f0
EZ
25912013-06-03 Eli Zaretskii <eliz@gnu.org>
2592
2593 * w32.c (gettimeofday): Make the signature identical to prototype
2594 in nt/inc/sys/time.h.
2595
a8a7c5f6
SM
25962013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2597
2598 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2599 .gdbinit.
2600
2601 * keyboard.c (safe_run_hooks_error): Improve error message.
2602
2603 * data.c (pure_write_error): Add `object' argument.
2604 * puresize.h (CHECK_IMPURE): Use it.
2605
c9628c79
MA
26062013-06-03 Michael Albinus <michael.albinus@gmx.de>
2607
2608 * Makefile.in (NOTIFY_OBJ): New variable.
2609 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2610
2611 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2612 Call syms_of_gfilenotify.
2613
2614 * gfilenotify.c: New file.
2615
2616 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2617 and Qfile_w32notify.
2618 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2619 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2620
2621 * lisp.h: Declare syms_of_gfilenotify.
2622
2623 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2624
2f592f95
SM
26252013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2626
2627 Merge the specpdl and backtrace stacks. Make the structure of the
2628 specpdl entries more obvious via a tagged union of structs.
2629 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2630 (enum specbind_tag): New enum.
2631 (struct specbinding): Make it a tagged union of structs.
2632 Add a case for backtrace records.
2633 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2634 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2635 (backtrace_debug_on_exit): New accessors.
2636 (struct backtrace): Remove.
2637 (struct catchtag): Remove backlist field.
2638 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2639 Move to eval.c.
2640 (Flocal_variable_p): Speed up the common case where the binding is
2641 already loaded.
2642 * eval.c (backtrace_list): Remove.
2643 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2644 (set_backtrace_args, set_backtrace_nargs)
2645 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2646 (backtrace_next): New functions.
2647 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2648 (unwind_to_catch, internal_lisp_condition_case)
2649 (internal_condition_case, internal_condition_case_1)
2650 (internal_condition_case_2, internal_condition_case_n): Don't bother
2651 with backtrace_list any more.
2652 (Fsignal): Adjust to new backtrace format.
2653 (grow_specpdl): Move up.
2654 (record_in_backtrace): New function.
2655 (eval_sub, Ffuncall): Use it.
2656 (apply_lambda): Adjust to new backtrace format.
2657 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2658 data.c.
2659 (specbind): Adjust to new specpdl format. Simplify.
2660 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2661 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2662 backtrace format.
2663 (mark_backtrace): Remove.
2664 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2665 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2666 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2667 Use mark_specpdl.
2668 * profiler.c (record_backtrace): Use get_backtrace.
2669 (handle_profiler_signal): Use backtrace_top_function.
2670 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2671 accessor functions.
2672
c0342369
JD
26732013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2674
2675 * process.h (catch_child_signal): Declare.
2676
2677 * process.c (catch_child_signal): New function.
2678 (init_process_emacs): Call it.
2679
2680 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2681 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2682 NS_IMPL_COCOA.
2683 (x_set_cursor_type): Remove declaration.
2684 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2685 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2686 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2687 (ns_get_color): Use F suffix on float.
2688 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2689 (ns_get_rgb_color): Remove.
2690 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2691 (note_mouse_movement): x and y are CGFloat.
2692 (ns_draw_fringe_bitmap): Remove unused rowY.
2693 Change #if to COCOA && >= 10_6.
2694 (ns_draw_window_cursor): Remove unused overspill.
2695 (ns_draw_underwave): width and x are EamcsCGFloat.
2696 (ns_draw_box): thickness is CGFloat.
2697 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2698 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2699 if not in main thread.
2700 (ns_get_pending_menu_title, ns_check_menu_open)
2701 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2702 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2703 (sendFromMainThread:): New method.
2704 (changeFont:): size is CGFloat.
2705 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2706 Disable warning about permanent text.
2707 (characterIndexForPoint:): Adjust return type depending on GNUStep
2708 version.
2709 (mouseDown:): delta is CGFloat.
2710 (updateFrameSize): Remove unised variable f.
2711 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2712 Cast float to EmacsCGFloat.
2713 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2714 also to -1 when restoring.
2715 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2716 inside NS_IMPL_COCOA.
2717 (toggleFullScreen:): Put call to toggleFullScreen inside
2718 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2719 (setPosition:portion:whole:): por is CGFloat.
2720 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2721 (mouseDown:): Use CGFloat.
2722 (mouseDragged:): Remove unised variable edge.
2723 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2724
2725 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2726 of CGFloat differs.
2727 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2728 when NS_IMPL_GNUSTEP.
2729 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2730 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2731 (EmacsToolbar): Add clearAll. Add tag argument to
2732 addDisplayItemWithImage.
2733 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2734
2735 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2736
2737 * nsmenu.m (ns_update_menubar): Make static.
2738 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2739 (fillWithWidgetValue:): Add cast to SEL for setAction.
2740 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2741 (update_frame_tool_bar): Update code for GNUStep.
2742 (clearAll): New method.
2743 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2744 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2745 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2746 call to insertItemWithItemIdentifier.
2747 (validateVisibleItems): Fix indentation.
2748 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2749 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2750 UtilityWindow to aStyle, remove call to setStyleMask.
2751
2752 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2753
2754 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2755 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2756 Use F suffix on floats.
2757 (ns_char_width): Returns CGFloat.
2758 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2759 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2760 DPSxshow.
2761 (ns_glyph_metrics): CGFloat instead of float.
2762
a0eb10b3
JB
2763 * nsfns.m (x_set_foreground_color, x_set_background_color):
2764 Use EmacsCGFloat.
2765 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2766 remove unused variables.
2767 (Fns_read_file_name): Keep track if panel is for save.
2768 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2769 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2770 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2771 Just return the input if GNUStep.
c0342369
JD
2772 (x_screen_planes): Remove.
2773 (Fxw_color_values): Use EmacsCGFloat
2774 (Fns_display_monitor_attributes_list): Only get screen number for
2775 Cocoa.
ef099a94 2776 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2777 EmacsSavePanel.
2778 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2779 ns_directory_from_panel.
2780
da9aff11
PE
27812013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2782
2783 * process.c (handle_child_signal): Also use WCONTINUED.
2784 This is so that list-processes doesn't mistakenly list the process
2785 as stopped, when the process has actually been continued and is
2786 now running.
2787
0e64479a
PE
27882013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2789
fc186a96
PE
2790 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2791 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2792 not already configured.
2793
0e64479a
PE
2794 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2795
38b787fa
EZ
27962013-05-29 Eli Zaretskii <eliz@gnu.org>
2797
2798 * Makefile.in (mostlyclean): Remove *.res files.
2799
22513e52
SM
28002013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2801
2802 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2803 a buffer (bug#8447).
2804
6ef3db10
EZ
28052013-05-27 Eli Zaretskii <eliz@gnu.org>
2806
2807 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2808 display vector, and we backtrack, handle the case that the
2809 previous character position is also displayed from a display
2810 vector or covered by a display string or image. (Bug#14476)
2811
6799bb26
JD
28122013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2813
2814 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2815 (struct MonitorInfo, free_monitors): Remove.
2816 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2817 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2818 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2819 Qframes, Qsource.
2820
2821 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2822 (struct MonitorInfo, free_monitors): Remove.
2823 (ns_screen_name): Make static.
2824 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2825 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2826 Qframes, Qsource.
2827
2828 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2829 (struct MonitorInfo): New struct.
2830 (free_monitors, make_monitor_attribute_list): Declare.
2831
22513e52
SM
2832 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2833 New Lisp_Object:s.
6799bb26
JD
2834 (free_monitors, make_monitor_attribute_list): New functions.
2835 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2836 Qsource.
2837
38cd43eb
XF
28382013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2839
2840 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2841
2af0948d
SM
28422013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2843
a7eb9b0f
SM
2844 * keyboard.c: Apply keyboard decoding only to events that come directly
2845 from the tty, not from unread-command-events (bug#14368).
2846 (read_event_from_main_queue): New function, extracted from read_char).
2847 (read_decoded_char): Remove.
2848 (read_decoded_event_from_main_queue): New function to replace it.
2849 (read_char): Use it.
2850 (read_key_sequence): Use read_char rather than read_decoded_char.
2851
2af0948d
SM
2852 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2853
1413e9a5
BR
28542013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2855
2856 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2857
e6d2f155
KH
28582013-05-22 Kenichi Handa <handa@gnu.org>
2859
2860 The following changes are to fix the setting of
2861 buffer-file-coding-system on, for instance, C-x RET c unix RET
2862 _FILE_OF_DOS_EOL_TYPE_ RET.
2863
2864 * coding.h (struct coding_system): New member detected_utf8_chars.
2865
2866 * coding.c (detect_coding_utf_8): Count characters and check EOL
2867 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2868 BOM is there.
2869 (setup_coding_system): Do not initialize coding->head_ascii.
2870 (check_ascii): Do not set coding->eol_seen but update it. Do not
2871 call adjust_coding_eol_type here.
1413e9a5
BR
2872 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2873 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2874 of the found coding-system.
2875 (decode_coding_gap): Cancel previous change. Utilize the
2876 character numbers counted by detect_coding_utf_8. Fix detection
2877 of BOM for utf-8.
2878
ab56a6f4 28792013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2880
2881 * search.c (looking_at_1): Only set last_thing_searched if the match
2882 changed the match-data (bug#14281).
2883
ecc3c6ed
DA
28842013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2885
2886 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2887 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2888 (move_it_vertically_backward): Likewise.
2889
5ba8bf35
YM
28902013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2891
2892 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2893 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2894 (Fx_display_mm_width, Fx_display_mm_height):
2895 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2896
91e8418b 2897 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2898 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2899 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2900 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2901 (Fx_display_backing_store, Fx_display_visual_class)
2902 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2903 (Fx_display_grayscale_p, Fx_display_pixel_width)
2904 (Fx_display_pixel_height, Fx_display_planes)
2905 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2906 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2907 (Fx_display_mm_width, Fx_display_mm_height)
2908 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2909 height for all physical monitors as in X11.
2910
fc30d803
SM
2911 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2912 Return pixel width or height for all physical monitors as in X11.
91e8418b 2913
31ff141c
PE
29142013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 Port --enable-gcc-warnings to clang.
2917 * bytecode.c (exec_byte_code):
2918 * regex.c:
2919 Redo diagnostic pragmas to pacify clang, too.
2920 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2921 * editfns.c (Fencode_time):
2922 * fileio.c (file_accessible_directory_p):
2923 * font.c (font_unparse_xlfd):
2924 Use '&"string"[index]' instead of '"string" + (index)'.
2925 * undo.c (user_error): Remove; unused.
2926
df065a0b
EZ
29272013-05-16 Eli Zaretskii <eliz@gnu.org>
2928
04d360e7
EZ
2929 * insdel.c (insert_1_both): Document the arguments, instead of
2930 referring to insert_1, which no longer exists.
2931
5bb98290
EZ
2932 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2933 some window, increment windows_or_buffers_changed, so that
2934 *Messages* display in that window is updated. (Bug#14408)
2935
df065a0b
EZ
2936 * w32.c: Include epaths.h.
2937 (init_environment): Use cmdproxy.exe without leading directories.
2938 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2939 case.
2940 (gettimeofday): Adjust signature and return value to Posix
2941 expectations.
2942
2943 * unexw32.c (open_output_file): Delete the existing emacs.exe
2944 before creating it, to break the hard link to the versioned
2945 executable.
2946
2947 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2948 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2949 (FIRSTFILE_OBJ): New variables.
2950 (W32_RES): Rename to EMACSRES. All users changed.
2951 (base_obj): Use $(CM_OBJ).
2952 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2953 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2954 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2955 $(W32_RES_LINK) before $(LIBES).
2956 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2957
1aa8d505
SM
29582013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2959
6e911150
SM
2960 * makefile.w32-in (DOC): Use just "DOC".
2961
2962 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2963
1aa8d505
SM
2964 * process.c: Export default filters and sentinels to Elisp.
2965 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2966 New constants.
2967 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2968 (Fset_process_sentinel, Fformat_network_address):
2969 Default to them instead of nil.
2970 (server_accept_connection): Sentinels can't be nil any more.
2971 (read_and_dispose_of_process_output): New function, extracted from
2972 read_process_output.
2973 (read_process_output): Use it; filters can't be nil.
2974 (Finternal_default_process_filter): New function, extracted from
2975 read_process_output.
2976 (exec_sentinel_unwind): Remove function.
2977 (exec_sentinel): Don't zilch sentinel while running.
2978 (status_notify): Sentinels can't be nil.
2979 (Finternal_default_process_sentinel): New function extracted from
2980 status_notify.
2981 (setup_process_coding_systems): Default filter is not nil any more.
2982 (syms_of_process): Export new Elisp functions and initialize
2983 new constants.
2984 * lisp.h (make_lisp_proc): New function.
2985
5ac2eb34
SM
29862013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2987
2988 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2989
eda9c7d7
EZ
29902013-05-14 Eli Zaretskii <eliz@gnu.org>
2991
2992 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2993 unless we know that the window w is a leaf window.
2994 Another attempt at solving bug#14062.
eda9c7d7 2995
8fdeaad5
JD
29962013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2997
2998 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2999 fdesc (Bug#14375).
3000
44aa9ee6
PE
30012013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 * image.c (gif_load): Check that subimages fit (Bug#14345).
3004
759fd763
SM
30052013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3006
3007 * lread.c (skip_dyn_eof): New function.
3008 (read1): Use it to skip the end of a file in response to #@00.
3009
3010 * doc.c (get_doc_string): Slightly relax the sanity checking.
3011
4465bfb4
JD
30122013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3013
3014 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3015 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3016 (MonitorInfo): New struct.
3017 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3018 (Fns_display_monitor_attributes_list): New functions.
3019 (display-usable-bounds): Remove.
3020 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3021 Qsource.
3022
7583e2a0
PE
30232013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3026 (GTK_CHECK_VERSION): New macro, if not already defined.
3027 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3028 replaced by GTK_CHECK_VERSION.
3029
ad75d77e
PE
30302013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 * xterm.h (GTK_PREREQ): New macro.
3033 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3034 to use this macro instead, for consistency and clarity.
3035
07525f77
EZ
30362013-05-08 Eli Zaretskii <eliz@gnu.org>
3037
3038 * xdisp.c (row_for_charpos_p): New function, with code of
3039 cursor_row_p, but accepts an additional argument CHARPOS instead
3040 of using a hardcoded PT.
3041 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3042 (row_containing_pos): Call row_for_charpos_p instead of partially
3043 doing the same. Fixes cursor positioning under longlines-mode
3044 when longlines-show-effect includes more than one newline, when
3045 moving the cursor vertically up.
3046
d901fc8d
JB
30472013-05-08 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * makefile.w32-in (ACL_H): New macro.
3050 ($(BLD)/fileio.$(O)): Update dependencies.
3051
f269bc61
PE
30522013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3053
e7b41c4c 3054 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3055 * Makefile.in (LIB_ACL): New macro.
3056 (LIBACL_LIBS): Remove.
3057 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3058 * fileio.c: Include <acl.h>.
3059 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3060 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3061 !acl_errno_valid.
3062 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3063 it ourselves.
3064
f269bc61
PE
3065 * unexelf.c: Don't assume ElfW (Half) fits in int.
3066 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3067 when dealing with ElfW (Half) values, since they can exceed 2**31
3068 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3069 (entry_address): Omit unused NUM arg. All uses changed.
3070
a261c53e
JL
30712013-05-07 Juri Linkov <juri@jurta.org>
3072
3073 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3074 to the string converted from number with `Fnumber_to_string'.
3075 (Bug#14254)
3076
2b66427d
PE
30772013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3078
3079 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3080 This fixes a problem introduced by my previous change.
3081
15acfe41
GM
30822013-05-07 Glenn Morris <rgm@gnu.org>
3083
3084 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3085
5ea03bf5
JD
30862013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3087
3088 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3089
e0c9d565
PE
30902013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 Static checking by GCC 4.8.0.
3093 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3094 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3095 (x_get_monitor_attributes_fallback)
3096 (x_get_monitor_attributes_xinerama)
3097 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3098 Define only if USE_GTK.
3099 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3100 (x_get_monitor_attributes_fallback): Omit unused locals.
3101 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3102 Use double, not float, to avoid mixed-mode floating point arithmetic.
3103
4e3f9230
YM
31042013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3105 Jan Djärv <jan.h.d@swipnet.se>
3106
3107 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3108 (XINERAMA_CFLAGS): New macros.
3109 (ALL_CFLAGS, LIBES): Use them.
3110
3111 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3112 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3113 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3114 (syms_of_xfns): DEFSYM them.
3115 (struct MonitorInfo): New struct.
3116 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3117 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3118 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3119 (x_get_monitor_attributes_xinerama): New functions.
3120 (Fx_display_monitor_attributes_list): New primitive.
3121 (syms_of_xfns): Defsubr it.
3122
3123 * xterm.h (x_display_info): Add Xatom_net_workarea and
3124 Xatom_net_current_desktop.
3125
3126 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3127 and dpyinfo->Xatom_net_current_desktop.
3128
05839b6a
EZ
31292013-05-06 Eli Zaretskii <eliz@gnu.org>
3130
3131 * xdisp.c (pos_visible_p): Use the special code for finding the
3132 beginning of a display property or overlay for any "replacing"
3133 display property, not just for display strings. This solves
3134 incorrect reporting of position by posn-at-point. (Bug#14241)
3135
dc4a2ee0
PE
31362013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3137
5ee94506
PE
3138 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3139 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3140 Verify that ElfW (Half) fits in int.
3141 (fatal): Use same signature as lisp.h.
3142 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3143 configure and build with -DUNEXELF_DEBUG without worrying about
3144 other modules that use DEBUG.
3145 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3146 possibly-wide integers now uses it instead of plain fprintf.
3147 (entry_address): New function, which avoids problems with 32-bit
3148 overflow on 64-bit hosts.
3149 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3150 (round_up): Don't assume the remainder fits in int.
3151 (find_section): Use bool for boolean. Simplify debug code.
3152 (unexec): Don't assume file sizes fit in int or size_t.
3153 Omit unnecessary trailing newline in 'fatal' format.
3154 Use strerror rather than outputting decimal error number.
3155 Remove unused code when emacs is not defined;
3156 this file relies on Emacs now.
3157 Don't assume e_phnum and e_shnum are positive.
3158
dc4a2ee0
PE
3159 * regex.c: Fix problems when DEBUG is defined.
3160 (extract_number, extract_number_and_incr): Define regardless of
3161 whether DEBUG is defined; that's simpler and makes the code less
3162 likely to go stale in the normal case when DEBUG is not defined.
3163 Return int rather than taking an int * arg. All callers changed.
3164 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3165 Remove, replacing with ...
3166 (DEBUG_PRINT): New macro. All callers changed.
3167 (DEBUG_COMPILES_ARGUMENTS): New macro.
3168 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3169 (print_compiled_pattern, print_double_string) [DEBUG]:
3170 Use prototype rather than old-style definition.
3171 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3172 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3173 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3174 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3175 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3176 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3177 This matters only when DEBUG is defined.
3178
14c7ed05
EZ
31792013-05-05 Eli Zaretskii <eliz@gnu.org>
3180
3181 * xdisp.c (set_iterator_to_next): Set the
3182 ignore_overlay_strings_at_pos_p flag only if we are _really_
3183 iterating over an overlay string, as indicated by the
3184 current.overlay_string_index member. (Bug#14306)
3185
e6076b1b
JD
31862013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3187
3188 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3189 to where it is used, to avoid autorelease issues (Bug#14050).
3190
cbee2131
PE
31912013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3194 * fileio.c (syms_of_fileio): Implement this.
3195 * filelock.c (create_lock_file): If symbolic links don't work, so
3196 we use a regular file as a lock file, do not fsync the lock file;
3197 it's not needed.
3198
30c7e542
SM
31992013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3200
3201 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3202 (syms_of_minibuf): Adjust accodingly.
3203 * lread.c (Fread):
3204 * callint.c (Fcall_interactively): Adjust calls accordingly.
3205
5bebd186
EZ
32062013-05-04 Eli Zaretskii <eliz@gnu.org>
3207
3208 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3209 w->contents is a buffer before computing everything else.
3210 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3211
3212 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3213 assertion violations. (Bug#14062)
3214
0fb0a4f3
DR
32152013-05-01 David Reitter <david.reitter@gmail.com>
3216
3217 * nsfns.m (ns_tooltip): Initialize.
3218
9e63b4a5
EZ
32192013-04-28 Eli Zaretskii <eliz@gnu.org>
3220
3221 * coding.c (decode_coding_gap): Don't remove the character before
3222 a newline unless it's a CR character. (Bug#14287)
3223
ad60824e
DN
32242013-04-28 Dan Nicolaescu <dann@gnu.org>
3225
3226 * dispextern.h (struct face): Move enum face_underline_type
3227 earlier so that bitfields can be in the same word.
3228
edbdcec0
JD
32292013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3230
3231 * nsfns.m (handlePanelKeys): New function.
3232 (EmacsOpenPanel:performKeyEquivalent:)
3233 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3234 arrows/function/control and copy/paste keys (Bug#14296).
3235
0208ede7
JL
32362013-04-27 Juri Linkov <juri@jurta.org>
3237
3238 * callint.c (Fcall_interactively): Call `Qread_number' for
3239 interactive code letter `n' instead of using duplicate code.
3240 (Bug#14254)
3241
b8dd59f7
PE
32422013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3243
3244 * systime.h (make_timeval): Declare as 'const'.
3245
8bd722db
KH
32462013-04-27 Kenichi Handa <handa@gnu.org>
3247
3248 * font.c (font_open_entity): Always open a font of manageable
3249 size.
3250
13d0e56f 32512013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3252
f780d632
PE
3253 Port better to AIX (Bug#14258).
3254 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3255 to pacify AIX xlc.
3256
ec509856
KH
32572013-04-24 Kenichi Handa <handa@gnu.org>
3258
3259 * coding.c (decode_coding_iso_2022): When an invalid escape
3260 sequence is encountered, reset the invocation and designation
3261 status to the safest one.
3262
84fc48e5
PE
32632013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3266 Without this fix, "make distclean" leaves stamp-h1 behind.
3267
806bda47
EC
32682013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3269
3270 * w32fns.c (w32_fullscreen_rect): New function to compute the
3271 window rectangle for the given fullscreen mode.
3272 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3273 longer tunes the window size. This keeps the window's edges flush
3274 with the screen and allows the taskbar to hide itself in fullboth.
3275
3276 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3277 window decorations and uses the entire screen.
3278
3279 * w32term.h (w32_fullscreen_rect) Add prototype.
3280 (struct w32_output): Replace normal_width, normal_height,
3281 normal_top, and normal_left members with a single normal_placement
3282 struct.
3283 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3284 Remove macros.
3285 (FRAME_NORMAL_PLACEMENT): New macro.
3286
9cc2810b
JB
32872013-04-16 Juanma Barranquero <lekktu@gmail.com>
3288
3289 * minibuf.c (Ftest_completion): Silence compiler warning.
3290
fd16b54c
EZ
32912013-04-15 Eli Zaretskii <eliz@gnu.org>
3292
3293 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3294 bug#14062.
fd16b54c
EZ
3295
3296 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3297 parentheses.
3298
3299 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3300 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3301 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3302 parentheses where appropriate.
3303
9e3379a0
PE
33042013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3307
ddd6b685
EZ
33082013-04-14 Eli Zaretskii <eliz@gnu.org>
3309
3310 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3311 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3312 Mention in the doc string that setting these variables takes
3313 effect only after a call to set-window-buffer. (Bug#14200)
3314
29b79ba1
EZ
33152013-04-13 Eli Zaretskii <eliz@gnu.org>
3316
3317 * indent.c (Fvertical_motion): Don't consider display strings on
3318 overlay strings as display strings on the buffer position we
3319 started from. This prevents vertical cursor motion from jumping
3320 more than one line when there's an overlay string with a display
3321 property at end of line.
3322 Reported by Karl Chen <Karl.Chen@quarl.org> in
3323 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3324
562c6ee9
SM
33252013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3326
3327 * window.c (select_window): `record_buffer' even if window is
3328 already selected (bug#14191).
3329
fcc1fe85
EZ
33302013-04-11 Eli Zaretskii <eliz@gnu.org>
3331
3332 * window.c (Fwindow_end): Test more flags, including the buffer's
3333 last_overlay_modified flag, to determine whether the window's
3334 display is really up-to-date. Prevents the function from
3335 returning a stale value. (Bug#14170)
3336 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3337 current matrix.
3338
f009190a
EZ
33392013-04-10 Eli Zaretskii <eliz@gnu.org>
3340
3341 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3342 garbaged only if it is not already the top frame on its TTY.
3343 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3344 there are GUI frames open in the same session. (Bug#13864)
3345
78ce603d
SM
33462013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3347
3348 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3349 of marking the idle timers directly.
3350
a8036e40
SM
33512013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3352
3353 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3354 tables (bug#14054).
3355
7ffe7ef6
SM
33562013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3357
3358 * window.c (select_window): Don't record_buffer while the invariant is
3359 temporarily broken (bug#14161).
3360
3361 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3362
7d9f6883
EZ
33632013-04-07 Eli Zaretskii <eliz@gnu.org>
3364
3365 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3366
5406cfd9
RF
33672013-04-07 Romain Francoise <romain@orebokech.com>
3368
3369 Ignore additional platform-specific ACL errors (Bug#13702).
3370 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3371 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3372
95c0e83b
JD
33732013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3374
3375 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3376 f->output_data.ns.
3377
876da980
PE
33782013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3381 This bug was introduced by my 2013-02-25 change that simplified
3382 data_start configuration. Without this change, on GNU/Linux
3383 an Emacs configured with --enable-profiling fails immediately
3384 due to a profiler signal.
3385 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3386 with these flags. On platforms where special flags are needed
3387 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3388 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3389 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3390
7452b7bd
DA
33912013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3392
3393 Get rid of some platform-specific functions examining window
3394 system and its capabilities. This is a partial rework of the
3395 2013-04-05 change.
3396 * lisp.h (have_menus_p): Remove prototype. This function is
3397 replaced with platform-independent window_system_available.
3398 (check_window_system): Move to...
3399 * frame.h (decode_window_system_frame, window_system_available):
3400 ...here, add new prototypes.
3401 * frame.c (window_system_available, decode_window_system_frame):
3402 New functions.
3403 (check_window_system): Platform-independent now.
3404 * xterm.h (x_in_use): Remove declaration.
3405 (check_x_frame):
3406 * w32term.h (check_x_frame):
3407 * nsterm.h (check_x_frame): Remove prototypes. This function
3408 is replaced with platform-independent decode_window_system_frame.
3409 * msdos.c (have_menus_p): Remove.
3410 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3411 Remove platform-specific functions. Use check_window_system,
3412 decode_window_system_frame and check_ns_display_info where
3413 appropriate. Minor style and comment tweaks.
3414 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3415 (check_x_frame): Likewise.
3416 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3417 Likewise.
3418 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3419 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3420 * xmenu.c, xselect.c: All related users changed.
3421
251e9147
KH
34222013-04-03 Kenichi Handa <handa@gnu.org>
3423
3424 The following changes is to optimize the code for reading UTF-8
3425 files.
3426
562c6ee9 3427 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3428 changed. Check EOL format. Do not call adjust_coding_eol_type
3429 here.
3430 (check_utf_8): New function.
3431 (adjust_coding_eol_type): Do nothing if already adjusted.
3432 (detect_coding): Compare the return value of check_ascii with
3433 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3434 (decode_coding_gap): Optimize for valid UTF-8.
3435
8bc369d4
KH
34362013-03-21 Kenichi Handa <handa@gnu.org>
3437
3438 * coding.c (syms_of_coding): Cancel previous change.
3439
3440 * insdel.c (insert_from_gap): Fix previous change.
3441
73931ad1
DA
34422013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3443
3444 Consistently use platform-specific function to detect window system.
3445 * lisp.h (check_window_system): New prototype. This function is
3446 going to replace check_x, check_w32 and check_ns.
3447 (have_menus_p): Mention msdos.c in comment.
3448 * fontset.c (check_window_system_func): Remove. Adjust all users.
3449 * fontset.h (check_window_system_func): Remove prototype.
3450 * nsterm.h (check_ns):
3451 * xterm.h (check_x):
3452 * w32term.h (check_w32): Likewise.
3453 * menu.c (Fx_popup_menu): Use check_window_system.
3454 * msdos.c (check_window_system): Define for MS-DOS.
3455 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3456 * w32fns.c (check_window_system): Likewise for MS-Windows.
3457 * xfns.c (check_window_system): Likewise for X.
3458 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3459 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3460
7216e43b
PE
34612013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3462
3463 Prefer < to > in range checks such as 0 <= i && i < N.
3464 This makes it easier to visualize quantities on a number line.
3465 This patch doesn't apply to all such range checks,
3466 only to the range checks affected by the 2013-03-24 change.
3467 This patch reverts most of the 2013-03-24 change.
3468 * alloc.c (xpalloc, Fgarbage_collect):
3469 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3470 * character.c (string_escape_byte8):
3471 * charset.c (read_hex):
3472 * data.c (cons_to_unsigned):
3473 * dispnew.c (update_frame_1):
3474 * doc.c (Fsubstitute_command_keys):
3475 * doprnt.c (doprnt):
3476 * editfns.c (hi_time, decode_time_components):
3477 * fileio.c (file_offset):
3478 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3479 * font.c (font_intern_prop):
3480 * frame.c (x_set_alpha):
3481 * gtkutil.c (get_utf8_string):
3482 * indent.c (check_display_width):
3483 * keymap.c (Fkey_description):
3484 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3485 * lread.c (read1):
3486 * minibuf.c (read_minibuf_noninteractive):
3487 * process.c (wait_reading_process_output):
3488 * search.c (Freplace_match):
3489 * window.c (get_phys_cursor_glyph):
3490 * xdisp.c (redisplay_internal):
3491 * xsmfns.c (smc_save_yourself_CB):
3492 Prefer < to > for range checks.
3493 * dispnew.c (sit_for): Don't mishandle NaNs.
3494 This fixes a bug introduced in the 2013-03-24 change.
3495 * editfns.c (decode_time_components): Don't hoist comparison.
3496 This fixes another bug introduced in the 2013-03-24 change.
3497
92759988
DA
34982013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3499
3500 * frame.h (struct frame): Drop scroll_bottom_vpos
3501 member becaue all real users are dead long ago.
3502 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3503 * xdisp.c (redisplay_internal): Adjust user.
3504
9a1971bb
GM
35052013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3506
f38ab167
JD
3507 * nsmenu.m (showAtX:Y:for:): setLevel to
3508 NSPopUpMenuWindowLevel (Bug#13998).
3509
6d01f1fe
JD
35102013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3511
3512 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3513 (ns_check_pending_open_menu): Declare.
3514
3515 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3516 (x_activate_menubar): Update the menu with title that matches
3517 ns_get_pending_menu_title, and call
3518 ns_check_pending_openmenu (Bug#12698).
3519 (menuWillOpen:): New method.
3520 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3521
3522 * nsterm.m (menu_will_open_state, menu_mouse_point)
3523 (menu_pending_title): New varaibles.
3524 (ns_get_pending_menu_title, ns_check_menu_open)
3525 (ns_check_pending_open_menu): New functions.
3526
781f4782
DA
35272013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3528
3529 * indent.c (current_column_bol_cache): Remove leftover which is not
3530 used in Fmove_to_column any more.
3531 (current_column, scan_for_column): Adjust users.
3532 * keyboard.c (last_point_position_buffer, last_point_position_window):
3533 Remove leftovers which are not used for recording undo any more.
3534 (command_loop_1, syms_of_keyboard): Adjust users.
3535 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3536 redisplay_window any more.
3537 (move_it_to): Adjust user.
3538
1921c31b
JB
35392013-03-29 Juanma Barranquero <lekktu@gmail.com>
3540
3541 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3542 Update dependencies.
3543
717b8bcd
SM
35442013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3545
3546 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3547 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3548 forward references.
3549
e74aeda8
DA
35502013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3551
3552 * window.h (struct window): Replace hchild, vchild and buffer slots
3553 with the only contents slot. This is possible because each valid
3554 window may have either the child window (in vertical or horizontal
3555 combination) or buffer to display (for the leaf window). Using that,
3556 a lof of operations to traverse and/or change window hierarchies may
3557 be simplified. New member horizontal is used to distinguish between
3558 horizontal and vertical combinations of internal windows.
3559 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3560 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3561 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3562 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3563 Use contents slot, not buffer, where appropriate.
3564 (wset_combination): New function.
3565 (wset_buffer): Add eassert.
3566 (Fframe_first_window): Simplify the loop reaching first window.
3567 (Fwindow_buffer): Use WINDOW_LEAF_P.
3568 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3569 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3570 (unshow_buffer): Convert initial debugging check to eassert.
3571 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3572 (make_parent_window, window_resize_check, window_resize_apply)
3573 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3574 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3575 Adjust to match struct window changes.
3576 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3577 (mark_window_cursors_off, count_windows, get_leaf_windows)
3578 (foreach_window_1): Simplify the loop.
3579 * alloc.c (mark_object): Do not check for the leaf window because
3580 internal windows has no glyph matrices anyway.
3581 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3582 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3583 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3584 (build_frame_matrix_from_window_tree, mirror_make_current)
3585 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3586 (update_window_tree, set_window_update_flags): Simplify the loop.
3587 (sync_window_with_frame_matrix_rows): Enforce live window.
3588 Use contents slot, not buffer, where appropriate.
3589 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3590 and WINDOW_HORIZONTAL_COMBINATION_P.
3591 (make_frame_visible_1): Simplify the loop.
3592 Use contents slot, not buffer, where appropriate.
3593 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3594 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3595 (expose_window_tree): Likewise.
3596 Use contents slot, not buffer, where appropriate.
3597 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3598 to avoid deleted windows. Use contents slot instead of buffer.
3599 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3600 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3601 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3602 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3603
121ab1cd
EZ
36042013-03-28 Eli Zaretskii <eliz@gnu.org>
3605
ef454cf7
EZ
3606 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3607 identify the reasons for assertion violations in bug#14062 and
3608 similar ones.
21e930f8
EZ
3609 (Fx_show_tip): Fix compilation error under
3610 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3611
121ab1cd
EZ
3612 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3613 Reported by <rzl24ozi@gmail.com>.
3614
5c89ca24
DA
36152013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3616
3617 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3618 start marker...
562c6ee9
SM
3619 (unwind_with_echo_area_buffer): ...to restore it here.
3620 This is needed to ensure that...
5c89ca24
DA
3621 (redisplay_window): ...both window markers are valid here,
3622 which is verified by eassert.
3623 * editfns.c (save_excursion_save): Do not assume that
3624 selected_window always displays the buffer.
c7f53895
DA
3625 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3626 Fix comment.
5c89ca24 3627
f557c1b1
SM
36282013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3629
3630 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3631 the upcase table.
3632
40693bba 36332013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3634
3635 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3636
c86f791f
EZ
36372013-03-27 Eli Zaretskii <eliz@gnu.org>
3638
3639 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3640 since MinGW's w32api headers do. This avoids compiler warnings.
3641
3642 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3643 if already defined.
3644
c6e72e17
EZ
36452013-03-26 Eli Zaretskii <eliz@gnu.org>
3646
3647 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3648
54e95010
JD
36492013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3650
3651 * gtkutil.c (style_changed_cb): Check if frame is live and an
3652 X frame (Bug#14038).
3653
b88b62de
EZ
36542013-03-26 Eli Zaretskii <eliz@gnu.org>
3655
a18d7de6
EZ
3656 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3657 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3658 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3659 MinGW64.
8f5e14c8
EZ
3660 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3661 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3662
b88b62de
EZ
3663 Fix incompatibilities between MinGW.org and MinGW64 headers.
3664 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3665
3666 * w32.c (REPARSE_DATA_BUFFER): Guard with
3667 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3668
c074e458
JD
36692013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3670
3671 * xterm.c: Include X11/XKBlib.h
3672 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3673
908589fd
AS
36742013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3675
3676 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3677 written backwards.
3678 * blockinput.h (input_blocked_p): Likewise.
3679 * bytecode.c (exec_byte_code): Likewise.
3680 * callproc.c (call_process_kill, call_process_cleanup)
3681 (Fcall_process): Likewise.
3682 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3683 (Fccl_execute_on_string): Likewise.
3684 * character.c (string_escape_byte8): Likewise.
3685 * charset.c (read_hex): Likewise.
3686 * cm.c (calccost): Likewise.
3687 * data.c (cons_to_unsigned): Likewise.
3688 * dired.c (directory_files_internal, file_name_completion):
3689 Likewise.
3690 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3691 (sit_for): Likewise.
3692 * doc.c (Fsubstitute_command_keys): Likewise.
3693 * doprnt.c (doprnt): Likewise.
3694 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3695 * emacsgtkfixed.c: Likewise.
3696 * fileio.c (file_offset, Fwrite_region): Likewise.
3697 * floatfns.c (Fexpt, fmod_float): Likewise.
3698 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3699 Likewise.
3700 * font.c (font_intern_prop): Likewise.
3701 * frame.c (x_set_alpha): Likewise.
3702 * gtkutil.c (get_utf8_string): Likewise.
3703 * indent.c (check_display_width): Likewise.
3704 * intervals.c (create_root_interval, rotate_right, rotate_left)
3705 (split_interval_right, split_interval_left)
3706 (adjust_intervals_for_insertion, delete_node)
3707 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3708 (merge_interval_right, merge_interval_left, copy_intervals)
3709 (set_intervals_multibyte_1): Likewise.
3710 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3711 * keymap.c (Fkey_description): Likewise.
3712 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3713 * lread.c (openp, read_integer, read1, string_to_number):
3714 Likewise.
3715 * menu.c (ensure_menu_items): Likewise.
3716 * minibuf.c (read_minibuf_noninteractive): Likewise.
3717 * print.c (printchar, strout): Likewise.
3718 * process.c (create_process, Faccept_process_output)
3719 (wait_reading_process_output, read_process_output, send_process)
3720 (wait_reading_process_output): Likewise.
3721 * profiler.c (make_log, handle_profiler_signal): Likewise.
3722 * regex.c (re_exec): Likewise.
3723 * regex.h: Likewise.
3724 * search.c (looking_at_1, Freplace_match): Likewise.
3725 * sysdep.c (get_child_status, procfs_ttyname)
3726 (procfs_get_total_memory): Likewise.
3727 * systime.h (EMACS_TIME_VALID_P): Likewise.
3728 * term.c (dissociate_if_controlling_tty): Likewise.
3729 * window.c (get_phys_cursor_glyph): Likewise.
3730 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3731 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3732 Likewise.
3733 * xfns.c (Fx_window_property): Likewise.
3734 * xmenu.c (set_frame_menubar): Likewise.
3735 * xselect.c (x_get_window_property, x_handle_dnd_message):
3736 Likewise.
3737 * xsmfns.c (smc_save_yourself_CB): Likewise.
3738 * xterm.c (x_scroll_bar_set_handle): Likewise.
3739
2bf7d27a
DA
37402013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3741
3742 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3743 to be optional or nil. Adjust comment and convert it to docstring.
3744 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3745 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3746
a9ebfa0b
PE
37472013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3748
3749 Static checking by GCC 4.8-20130319.
3750 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3751 * process.c (Fset_process_datagram_address)
3752 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3753 * xdisp.c (get_char_face_and_encoding):
3754 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3755 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3756 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3757
4f3576ee
KB
37582013-03-24 Ken Brown <kbrown@cornell.edu>
3759
789b5e9a
KB
3760 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3761 fix compilation on 64-bit Cygwin, where underscores are not
3762 automatically prepended.
3763
4f3576ee
KB
3764 * w32term.c (w32_initialize): Silence compiler warning.
3765
b5b7745f
EZ
37662013-03-23 Eli Zaretskii <eliz@gnu.org>
3767
cdc0d0bd
EZ
3768 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3769 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3770 variables, to save and restore frame dimensions.
3771 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3772 after returning from a 'fullscreen' configuration.
3773 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3774 to avoid races between the main thread and the input thread.
3775
3776 * w32term.h (struct w32_output): New members normal_width,
3777 normal_height, normal_top, normal_left, and prev_fsmode.
3778 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3779 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3780 members of a frame.
3781
b5b7745f
EZ
3782 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3783 'fullscreen' parameter. Always record previous width and height
3784 of the frame, except when switching out of maximized modes, so
3785 that they could be restored correctly, instead of resetting to the
3786 default frame dimensions. Send SC_RESTORE command to the frame,
3787 unless we are going to send SC_MAXIMIZE, to restore the frame
3788 resize hints in the mouse pointer shown by the window manager.
3789 (Bug#14032)
3790
3791 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3792
3793 * lisp.h (get_frame_param): Adjust conditions for prototype
3794 declaration.
3795
a3454eed
KB
37962013-03-22 Ken Brown <kbrown@cornell.edu>
3797
3798 * unexcw.c: Drop unneeded inclusion of w32common.h.
3799 (report_sheap_usage): Declare.
3800 (read_exe_header): Add magic numbers for x86_64.
3801 (fixup_executable): Fix printf format specifier for unsigned long
3802 argument.
3803
5a49b79c
DA
38042013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3805
3806 * frame.h (struct frame): Put menu_bar_window under #ifdef
3807 because this member is not needed when X toolkit is in use.
3808 (fset_menu_bar_window):
3809 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3810 (free_glyphs, update_frame):
3811 * xdisp.c (expose_frame): Likewise.
3812 (display_menu_bar): Likewise. Remove redundant eassert.
3813 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3814 toolkit is in use.
3815
d6723bf7
PE
38162013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3817
7b1123d8
PE
3818 Use functions and constants to manipulate Lisp_Save_Value objects.
3819 This replaces code that used macros and strings and token-pasting.
3820 The change makes the C source a bit easier to follow,
3821 and shrinks the Emacs executable a bit.
3822 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3823 (make_save_value): Change 1st arg from string to enum. All callers
3824 changed.
3825 (INTX): Remove.
3826 (mark_object): Use if, not #if, for GC_MARK_STACK.
3827 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3828 (XSAVE_OBJECT): Now functions, not macros.
3829 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3830 the constant was never used.
3831 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3832 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3833 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3834 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3835 New constants.
3836 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3837 type3 with a single member save_type. All uses changed.
3838 (save_type, set_save_pointer, set_save_integer): New functions.
3839 * print.c (PRINTX): Remove.
3840
d6723bf7
PE
3841 * alloc.c: Remove redundant static declarations.
3842
5f24fa51
DA
38432013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3844
3845 * window.h (struct window): Convert left_col, top_line, total_lines
3846 and total_cols from Lisp_Objects to integers. Adjust comments.
3847 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3848 Remove.
3849 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3850 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3851 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3852 Adjust users where appropriate.
3853
42143acd
DA
38542013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3855
3856 * frame.h (struct frame): Drop resx and resy because the same data is
3857 available from window system-specific output context. Adjust users.
562c6ee9
SM
3858 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3859 New functions to provide defaults when no window system available.
42143acd 3860 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3861 (NUMVAL): Move from xdisp.c.
42143acd
DA
3862 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3863 (Ffont_face_attributes, Fopen_font):
3864 * image.c (gs_load):
3865 * w32font.c (fill_in_logfont):
3866 * xdisp.c (calc_pixel_width_or_height):
3867 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3868 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3869
c0a17406
KH
38702013-03-20 Kenichi Handa <handa@gnu.org>
3871
3872 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3873 to 1 (temporary workaround until a bug related to ASCII
3874 optimization is fixed).
3875
095d384d
DA
38762013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3877
3878 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3879 Signal error if window is not internal. Adjust docstring.
3880 (delete_all_child_windows): Use combination_limit to save the buffer.
3881 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3882 * print.c (syms_of_print): Initialize debugging output not here...
3883 (init_print_once): ...but in a new function here.
3884 * lisp.h (init_print_once): Add prototype.
3885 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3886
748fa866
DA
38872013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3888
3889 * window.c (window_resize_check, window_resize_apply)
3890 (window_from_coordinates, recombine_windows, set_window_buffer)
3891 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3892 (Fsplit_window_internal, Fdelete_window_internal)
3893 (freeze_window_starts): Use bool for booleans.
3894 * window.h (window_frame_coordinates, resize_frame_windows)
3895 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3896
81519fd2
SM
38972013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3898
3899 * dispnew.c (bitch_at_user): Use `user-error'.
3900
6db423a9
KB
39012013-03-17 Ken Brown <kbrown@cornell.edu>
3902
3903 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3904 as return type of image_background. (Bug#13981)
3905 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3906
8f2906f5
JD
39072013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3908
960ce480 3909 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3910 (ns_select): Don't return with result uninitialized.
960ce480 3911
8f2906f5
JD
3912 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3913 and getDirectory.
3914
81519fd2
SM
3915 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3916 New functions.
8f2906f5
JD
3917 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3918 directories. If filename is nil, get directory name (Bug#13932).
3919 Use getFilename and getDirectory.
3920 (getFilename, getDirectory): New methods for EmacsSavePanel and
3921 EmacsOpenPanel.
3922 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3923
cded56c1
PE
39242013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3925
3926 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3927
251e9147 39282013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3929
3930 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3931 (adjust_after_replace): Make it back to static. Delete the third
3932 arg text_at_gap_tail. Cancel the code for handling it.
3933
3934 * coding.h (struct coding_system): New member eol_seen.
3935
3936 * coding.c (detect_ascii): New function.
3937 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3938 when the source bytes are actually scanned. On detecting for
3939 coding_category_utf_8_auto, call detect_ascii instead of scanning
3940 source bytes directly.
3941 (produce_chars): Call insert_from_gap with the new arg 0.
3942 (encode_coding): Likewise.
3943 (decode_coding_gap): Control ASCII optimization by the variable
3944 disable_ascii_optimization instead of #ifndef .. #endif.
3945 Deccode EOL format according to coding->eol_seen.
3946 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3947 variable.
3948
8a44e6d1
KH
3949 * lisp.h (adjust_after_replace): Cancel externing it.
3950 (insert_from_gap): Adjust prototype.
3951
5f795e34
EZ
39522013-03-15 Eli Zaretskii <eliz@gnu.org>
3953
3954 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3955 FULLSCREEN_MAXIMIZED. (Bug#13935)
3956
f258b4be
DA
39572013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3958
3959 * region-cache.c (find_cache_boundary, move_cache_gap)
3960 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3961 Simplify debugging check and convert to eassert. Adjust comment.
3962 (pp_cache): Put under ENABLE_CHECKING.
3963
a5cc4dde
EZ
39642013-03-14 Eli Zaretskii <eliz@gnu.org>
3965
3966 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3967 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3968 and WM_ACTIVATEAPP.
3969 (w32fullscreen_hook): If the frame is visible, reset
3970 f->want_fullscreen flag after changing the frame size. If the
3971 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3972 (Bug#13953)
3973
3fc5e44a
DC
39742013-03-13 Daniel Colascione <dancol@dancol.org>
3975
3976 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3977 too so that these builds can use Cygwin's file conversion
3978 functions. (We've been building and linking cygw32.o all along
3979 and just not using it.)
3980
47d7532e
PE
39812013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3982
3983 File synchronization fixes (Bug#13944).
3984 * Makefile.in (LIB_FDATASYNC): New macro.
3985 (LIBES): Use it.
3986 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3987 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3988 Don't worry about HAVE_FSYNC, since a substitute fsync is
3989 available if the system lacks one.
3990 (Fwrite_regin): Retry fsync if interrupted.
3991
c7ffccaf
EZ
39922013-03-13 Eli Zaretskii <eliz@gnu.org>
3993
4e2df81d 3994 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3995 activated, call w32fullscreen_hook, to make sure the new frame
3996 dimensions are in effect. (Bug#13937)
3997
8a7debc1
DA
39982013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3999
4000 * xdisp.c (init_iterator): Simplify because both character and byte
4001 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4002 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4003 character and byte positions can be obtained from marker.
8a7debc1 4004
7fd8c501
PE
40052013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4006
d9df6f40
PE
4007 Static checking by Sun C 5.12.
4008 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4009 * bytecode.c (exec_byte_code):
4010 * dispnew.c (init_display):
4011 * eval.c (error):
4012 * fileio.c (Fsubstitute_in_file_name):
4013 * keyboard.c (Fevent_convert_list):
4014 * keymap.c (Fsingle_key_description):
4015 * term.c (maybe_fatal, fatal):
4016 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4017 * xsmfns.c (Fhandle_save_session):
4018 Omit unreachable code.
4019 * keymap.c (map_keymap_char_table_item): Cast void * to
4020 a function pointer type; the C Standard requires this.
4021
7fd8c501
PE
4022 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4023 Include <sys/param.h> unconditionally, as that works elsewhere and
4024 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4025 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4026 and FreeBSD now.
4027
a020afb9 4028See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4029
4030;; Local Variables:
4031;; coding: utf-8
aac0c6e3
MR
4032;; End:
4033
ab422c4d 4034 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4035
4036 This file is part of GNU Emacs.
4037
4038 GNU Emacs is free software: you can redistribute it and/or modify
4039 it under the terms of the GNU General Public License as published by
4040 the Free Software Foundation, either version 3 of the License, or
4041 (at your option) any later version.
4042
4043 GNU Emacs is distributed in the hope that it will be useful,
4044 but WITHOUT ANY WARRANTY; without even the implied warranty of
4045 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4046 GNU General Public License for more details.
4047
4048 You should have received a copy of the GNU General Public License
4049 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.