* lisp/vc/vc-dispatcher.el (vc-run-delayed): New macro.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d99760fa
SM
12013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
2
6629638e
SM
3 * keyboard.c (read_key_sequence_vs): New function.
4 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
5 common code.
6
d99760fa
SM
7 * callint.c (Fcall_interactively): Always return a vector for 'K'.
8
224e313d
PE
92013-09-04 Paul Eggert <eggert@cs.ucla.edu>
10
11 Makefile improvements.
12 * Makefile.in (config.status): Don't use double-colon rules, as
13 they are not portable according to POSIX. Fix shell typo with `;
14 I guess this rule has never been tested?
15 (VCSWITNESS): New macro, to override any environment var.
16
6d6ed1af
DA
172013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
18
19 * xterm.h (struct x_display_info): Do not track X connection
20 fd separately because it is always available from Display.
21 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
22 Adjust users.
23
bc923770
DA
242013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
25
26 * buffer.c (drop_overlay):
27 * fileio.c (restore_point_unwind): Prefer unchain_marker to
28 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
29
b1cf96de
DA
302013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
31
32 * buffer.c (Fmake_overlay, Fmove_overlay):
33 * intervals.c (set_point_from_marker):
34 * print.c (PRINTPREPARE): Prefer signal_error
35 to plain error and report unsuitable marker too.
36
d1fc6c21
DA
372013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
38
39 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
40 for 'dragging' member.
d1ae6a0b
DA
41 (struct x_output): Remove set-but-unused leftovers
42 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
43 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
44 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
45 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
46 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
47 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
48 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 49 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 50 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 51
0ce9f6de
JD
522013-09-03 Jan Djärv <jan.h.d@swipnet.se>
53
54 * nsfont.m (INVALID_GLYPH): New define.
55 (nsfont_encode_char): Use INVALID_GLYPH.
56 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
57
b594a96c
DA
582013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
59
60 * xterm.c (x_last_mouse_movement_time): Revert last change.
61 This code should use XDisplayMotionBufferSize to check display's
62 motion history first, and there are few other issues as well.
63 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
64 (handle_one_xevent): Adjust user.
65
8b098236
MR
662013-09-02 Martin Rudalics <rudalics@gmx.at>
67
9718b207
MR
68 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
69 * frame.c (Flast_nonminibuf_frame): ... to here.
70 (check_minibuf_window): Don't abort if no window was found
71 (Bug#15247).
8b098236 72
84e70bba
DA
732013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Use XGetMotionEvents to ask the last mouse motion time from X server.
76 * xterm.c (X_MOTION_HISTORY): Default to 1.
77 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
78 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
79 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
80 Ifdef away legacy code.
81 (XTmouse_position, x_scroll_bar_report_motion):
82 Use x_last_mouse_movement_time.
fc85e20b
DA
83 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
84 UnmapNotify event.
84e70bba 85
1fccc530
DA
862013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
87
88 * msdos.c (last_mouse_window): Move to...
89 (dos_rawgetc): ...this function and adjust comment.
90 * nsterm.m (last_window): Rename to last_mouse_window, move to...
91 (mouseMoved): ...this function and adjust comment.
92 * w32term.c (last_window): Likewise with...
93 (w32_read_socket): ...this function.
94 * xterm.c (last_window): Likewise with...
95 (handle_one_xevent): ...this function.
96
0ab10992
DA
972013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
98
b7da754d 99 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
100 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
101 (handle_one_xevent): ...to here.
102 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
103 otherwise.
104
0c7f856e
DA
1052013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
106
107 * msdos.c (IT_set_terminal_window): Remove no-op.
108 (initialize_msdos_display): Adjust terminal setup.
109 * w32console.c (w32con_set_terminal_window): Remove no-op.
110 (initialize_w32_display): Adjust terminal setup.
111 * w32term.c (w32_set_terminal_window): Remove no-op.
112 (w32_create_terminal): Adjust terminal setup.
113 * xterm.c (XTset_terminal_window): Remove no-op.
114 (x_create_terminal): Adjust terminal setup.
115
a892a94c
DA
1162013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
117
118 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
119 Remove no-ops.
120 (ns_create_terminal): Adjust terminal setup.
121 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
122 Remove no-ops.
123 (w32_create_terminal): Adjust terminal setup.
124 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
125 Remove no-ops.
126 (x_create_terminal): Adjust terminal setup.
127
cf91889a
DA
1282013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
129
130 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
131 (CLIP_TEXT_POS_FROM_MARKER): New macro.
132 * dispnew.c (buffer_posn_from_coords):
133 * window.c (Fwindow_end, displayed_window_lines):
134 * xdisp.c (redisplay_mode_lines): Use it.
135
5b0891df
JD
1362013-09-01 Jan Djärv <jan.h.d@swipnet.se>
137
138 * fontset.c (face_for_char): Check char in the current face font first
139 if HAVE_NS (Bug#15138).
140
0a357e98
MR
1412013-08-31 Martin Rudalics <rudalics@gmx.at>
142
143 * window.c (temp_output_buffer_show): Make sure window returned
144 by display_buffer is live (Bug#15213).
145
9d7693d7
DA
1462013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
147
148 Minor cleanup to avoid forward declarations.
149 * coding.h (struct ccl_spec): Remove forward declaration.
150 * composite.h (toplevel): Include font.h.
151 (struct composition_it, struct face, struct font_metrics):
152 Remove forward declaration.
153 * dispextern.h (struct image, struct atimer): Likewise.
154 * emacsgtkfixed.h (struct frame): Likewise.
155 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
156 * font.h (struct font_driver, struct font, struct glyph_string)
157 (struct face): Remove forward declaration.
158 * fontset.h (struct face, struct font): Likewise.
159 * frame.h (toplevel): Style cleanup.
160 (enum output_method): Move to...
161 * termhooks.h (enum output_method): ...here.
162 (struct glyph, struct frame, struct ns_display_info)
163 (struct x_display_info, struct w32_display_info):
164 Remove forward declaration.
165 * xterm.h (toplevel): Include termhooks.h.
166 (struct font, struct window, struct glyph_matrix, struct frame)
167 (struct input_event, struct face, struct image): Remove forward
168 declaration.
169 * gtkutil.h (struct _widget_value): Likewise.
170 * keyboard.h (toplevel): Include termhooks.h.
171 (struct input_event): Remove forward declaration.
172
032f7451
DA
1732013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
174
175 * intervals.c (set_point_from_marker): New function.
176 * editfns.c (Fgoto_char):
177 * process.c (Finternal_default_process_filter):
178 * window.c (select_window_1): Use it.
179 * buffer.h (set_point_from_marker): Add prototype.
180
3f940c5a
EZ
1812013-08-29 Eli Zaretskii <eliz@gnu.org>
182
183 * w32.c (term_winsock): Call release_listen_threads before calling
184 WSACleanup.
185 (_sys_wait_accept): Wait for accept event in a loop with a finite
186 timeout, instead of waiting indefinitely. Will hopefully avoid
187 hanging during exit because WSACleanup deadlocks waiting for the
188 event object to be released. (Bug#14333)
189
190 * w32proc.c (release_listen_threads): New function, signals all
191 the reader threads that listen for connections to stop waiting.
192
193 * w32.h (release_listen_threads): Add prototype.
194
101ed2bb
DA
1952013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
196
197 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
198 field of new marker (for sanity and safety).
20de2834
DA
199 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
200 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 201
1f5cf200
DA
2022013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
203
204 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
205 (x_after_update_window_line, x_scroll_bar_create):
206 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
207 (handle_one_xevent, x_clear_frame_area):
208 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
209 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
210 * xterm.h (x_clear_area): Adjust prototype.
211
d2b36813
DA
2122013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
213
214 Hook scanning and indentation functions to find_newline. This helps
215 to avoid duplicated code and renders more respect to newline cache.
216 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
217 * cmds.c (Fforward_line):
218 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
219 Use find_newline and avoid unnecessary point movements.
220 * search.c (scan_newline): Implement on top of find_newline.
221
3ec7babc
SM
2222013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
223
224 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
225 scoped code (bug#11258).
226
5ab473cd
JD
2272013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
228
229 * nsterm.m (last_window): New variable.
230 (EV_TRAILER2): New macro.
231 (EV_TRAILER): Call EV_TRAILER2.
232 (mouseMoved:): Add support for mouse-autoselect-window
233 on nextstep (Bug#6888).
234
78779650
AS
2352013-08-28 Andreas Schwab <schwab@suse.de>
236
237 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
238 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
239 Remove unused macro definitions.
240 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
241 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
242 Only define if emacs.
78779650 243
c3c4768d
DA
2442013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Prefer enum glyph_row_area to int where appropriate.
247 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
248 Fix comment.
249 (window_box, window_box_width, window_box_left, window_box_left_offset)
250 (window_box_right, window_box_right_offset): Adjust prototypes.
251 * xdisp.c (window_box, window_box_width, window_box_left)
252 (window_box_left_offset, window_box_right, window_box_right_offset):
253 Use enum glyph_row_area. Adjust users and tweak comment where needed.
254 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
255 * nsterm.m (ns_clip_to_row):
256 * w32term.c (w32_clip_to_row):
257 * xterm.c (x_clip_to_row): Likewise.
258
6bdcbfe1
DA
2592013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
260
261 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
262 (Fprevious_overlay_change): Fast path for buffer with no overlays.
263
50b13cde
PE
2642013-08-28 Paul Eggert <eggert@cs.ucla.edu>
265
266 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
267 for portability to hosts where /bin/sh has problems.
268
f60e429a
DA
2692013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Redesign redisplay interface to drop global output_cursor.
272 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
273 (toplevel): Remove declaration of output_cursor.
274 (set_output_cursor, x_cursor_to): Remove prototype.
275 * window.h (struct window): New member output_cursor.
276 (output_cursor_to): New function to replace RIF member.
277 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
278 (update_text_area, set_window_cursor_after_update): Use it.
279 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
280 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
281 * nsterm.m (ns_update_window_begin, ns_update_window_end):
282 * w32term.c (x_update_window_begin, x_update_window_end):
283 * xterm.c (x_update_window_begin, x_update_window_end):
284 Adjust to use per-window output cursor.
285
43aac990
PE
2862013-08-27 Paul Eggert <eggert@cs.ucla.edu>
287
d486344e
PE
288 Simplify SELECT_TYPE-related code.
289 Like EMACS_TIME, this portability layer is no longer needed, since
290 Emacs has been using fd_set as a portability layer for some time.
291 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
292 (SELECT_TYPE): Remove. All uses changed to fd_set.
293 (fd_set) [!FD_SET]: New typedef.
294
43aac990
PE
295 Simplify EMACS_TIME-related code.
296 This portability layer is no longer needed, since Emacs has been
297 using struct timespec as a portability layer for some time.
298 * atimer.h, buffer.h, dispextern.h, xgselect.h:
299 Include <time.h> rather than "systime.h"; that's all that's needed now.
300 * dispnew.c: Include <timespec.h> rather than "systime.h";
301 that's all that's needed now.
302 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
303 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
304 TIMESPEC_RESOLUTION.
305 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
306 LOG10_TIMESPEC_RESOLUTION.
307 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
308 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
309 (make_emacs_time): Remove. All used changed to make_timespec.
310 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
311 (current_timespec): Rename from current_emacs_time. All uses changed.
312 (add_emacs_time): Remove. All uses changed to timespec_add.
313 (sub_emacs_time): Remove. All uses change dot timespec_sub.
314 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
315 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
316 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
317 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
318 (current_timespec): Rename from current_emacs_time. All uses changed.
319 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
320 changed to timespec_cmp.
321 * xgselect.c: Include <timespec.h>, since our .h files don't.
322
d350e350
DA
3232013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
324
325 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
326 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
327 Remove the leftovers.
328 * gtkutil.c (toplevel): Do not declare Qxft but include
329 font.h to do so.
330 * image.c (toplevel): Do not declare Vlibrary_cache because
331 it's already done in lisp.h.
332
9fed9729
DA
3332013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
334
335 * lisp.h (Mouse_HLInfo): Move from here...
336 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
337 (reset_mouse_highlight): New function.
338 * msdos.c (dos_set_window_size, IT_update_begin)
339 (internal_terminal_init):
340 * nsterm.m (ns_update_window_end, x_free_frame_resources)
341 (ns_initialize_display_info):
342 * w32console.c (initialize_w32_display):
343 * w32term.c (x_update_window_end, x_free_frame_resources)
344 (w32_initialize_display_info):
345 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
346 * window.c (Fdelete_other_windows_internal):
347 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
348 * termchar.h (toplevel):
349 * xterm.h (toplevel): Include dispextern.h.
350
f462f075
PE
3512013-08-26 Paul Eggert <eggert@cs.ucla.edu>
352
353 Fix minor problems found by static checking.
354 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
355 (expect): Avoid nested-if warning.
356 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
357 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
358 * nsterm.h, nsterm.m (ns_select):
359 * xgselect.c, xgselect.h (xg_select):
360 Adjust signature to better match pselect's.
361 * nsterm.m (ns_select):
362 Don't set *TIMEOUT, since pselect doesn't.
363 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
364 diagnostic about assigning const char * to it.
365 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
366
068f9124
SM
3672013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
368
369 * lread.c (substitute_object_recurse): Handle hash-tables as well
370 (bug#15190).
371
f5adc984
PE
3722013-08-26 Paul Eggert <eggert@cs.ucla.edu>
373
1fc8eb33
PE
374 Fix unlikely core dump in init_tty, and simplify terminfo case.
375 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
376 The old version incorrectly dumped core if malloc returned a
377 buffer containing only non-NUL bytes.
378 (init_tty): Do not allocate or free termcap buffers; the
379 struct does that for us now.
380 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
381 (struct tty_display_info): Define members termcap_term_buffer and
382 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
383 use them. Allocate them directly in struct rather than indirectly
384 via a pointer, to simplify init_tty.
385
f5adc984
PE
386 * frame.c (check_minibuf_window): Initialize 'window' properly,
387 so that Emacs reliably aborts later if 'window' is not initialized.
388
efec3894
JD
3892013-08-26 Jan Djärv <jan.h.d@swipnet.se>
390
391 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
392 of VoidSymbol (Bug#15154).
393
e1d0341e
DA
3942013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
395
396 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
397 mouse_face_beg_y and mouse_face_end_y.
398 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
399 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
400 Adjust users and update comment where appropriate.
401
bfff6445
MR
4022013-08-26 Martin Rudalics <rudalics@gmx.at>
403
404 * frame.c (check_minibuf_window): New function.
068f9124
SM
405 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
406 Call check_minibuf_window (Bug#15183).
bfff6445 407
c80016b3
DA
4082013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
409
410 * window.h (struct window): Replace last_cursor with last_cursor_vpos
411 because this is the only last cursor data we need to keep and consult.
412 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
413 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
414 Adjust users.
415
de396731
DA
4162013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
417
068f9124
SM
418 Fix recovering from possible decompression error.
419 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 420 the position where the partially decompressed data ends, and
447218dd 421 should count how many bytes was produced so far.
de396731
DA
422 * decompress.c (struct decompress_unwind_data): Add nbytes member.
423 (unwind_decompress): Really delete partially uncompressed data.
424 (Fzlib_decompress_region): Take decompressed data size into account.
425
c76826d9
DA
4262013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
427
428 * syntax.c (init_syntax_once): Adjust comment and do an early
429 initialization of Qchar_table_extra_slots just once...
430 * casetab.c (init_casetab_once):
431 * category.c (init_category_once):
432 * character.c (syms_of_character):
433 * coding.c (syms_of_coding):
434 * xdisp.c (syms_of_xdisp): ...and omit it here.
435
b34454d0
EZ
4362013-08-24 Eli Zaretskii <eliz@gnu.org>
437
11f20add
EZ
438 * xdisp.c (get_next_display_element): Don't apply to characters
439 from a display vector the logic of setting it->end_of_box_run_p
440 suitable for characters from a buffer. (Bug#15175)
441
b34454d0
EZ
442 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
443 to handle directories, rather than '_utime' which doesn't.
444 (Bug#15176)
445
6e1b469e
JD
4462013-08-24 Jan Djärv <jan.h.d@swipnet.se>
447
448 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
449 or fullscreen (Bug#14627).
450
9c05bccf
PE
4512013-08-24 Paul Eggert <eggert@cs.ucla.edu>
452
453 System-dependent integer overflow fixes.
454 * process.c (Fset_process_window_size): Signal an error if
455 the window size is outside the range supported by the lower level.
456 * sysdep.c (set_window_size): Return negative on error,
457 nonnegative on success, rather than -1, 0, 1 on not in system,
458 failure, success. This is simpler. Caller changed.
459 (serial_configure): Remove unnecessary initialization of local.
460 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
461 size fits in unsigned long; this isn't true on some 32-bit hosts.
462 Avoid buffer overrun if some future version of /proc/meminfo has a
463 variable name longer than 20 bytes.
464 (system_process_attributes) [__FreeBSD__]:
465 Don't assume hw.availpages fits in 'int'.
466
c365c355
PE
4672013-08-23 Paul Eggert <eggert@cs.ucla.edu>
468
469 Don't let very long directory names overrun the stack.
470 Fix some related minor problems involving "//", vfork.
471 * callproc.c (encode_current_directory): New function.
472 (call_process): Don't append "/"; not needed.
473 * fileio.c (file_name_as_directory_slop): New constant.
474 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
475 this can save the caller having to alloca.
476 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
477 Use SAFE_ALLOCA, not alloca.
478 (directory_file_name, Fexpand_file_name): Leave leading "//"
479 alone, since it can be special even on POSIX platforms.
480 * callproc.c (call_process):
481 * process.c (Fformat_network_address):
482 * sysdep.c (sys_subshell):
483 Use encode_current_directory rather than rolling our own.
484 (create_process): No need to encode directory; caller does that now.
485 * process.h (encode_current_directory): New decl.
486 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
487 Rework to avoid 'goto xyzzy;'.
488
6c6014d4
EZ
4892013-08-23 Eli Zaretskii <eliz@gnu.org>
490
491 * xdisp.c (handle_face_prop): If the default face was remapped use
492 the remapped face for strings from prefix properties. (Bug#15155)
493
9997ec56
DA
4942013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
495
496 Minor cleanup for redisplay interface and few related functions.
497 * frame.h (enum text_cursor_kinds): Move from here...
498 * dispextern.h (enum text_cursor_kinds): ...to here.
499 (toplevel): Drop unnecessary declarations.
500 (struct redisplay_interface): Use bool and enum text_cursor_kinds
501 in update_window_end_hook and draw_window_cursor functions.
502 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
503 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
504 * w32term.c (x_update_window_end,w32_draw_window_cursor):
505 * xterm.c (x_update_window_end, x_draw_window_cursor):
506 * xdisp.c (display_and_set_cursor, update_window_cursor)
507 (update_cursor_in_window_tree, x_update_cursor): Use bool and
508 enum text_cursor_kinds where appropriate.
509
7f780da6
DA
5102013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
511
512 Redesign redisplay interface to drop updated_row and updated_area.
513 * dispextern.h (updated_row, updated_area): Remove declaration.
514 (struct redisplay_interface): Pass glyph row and row area parameters
515 to write_glyphs, insert_glyphs and clear_end_of_line functions.
516 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
517 Adjust prototypes.
518 * dispnew.c (updated_row, updated_area): Remove.
519 (redraw_overlapped_rows, update_window_line): Adjust user.
520 (update_marginal_area, update_text_area): Likewise. Pass updated row
521 as a parameter. Prefer enum glyph_row_area to int where appropriate.
522 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
523 Adjust users.
524
26495794
PE
5252013-08-22 Paul Eggert <eggert@cs.ucla.edu>
526
527 * process.c (flush_pending_output): Remove stub.
528 All uses removed.
529
4a88129a
PE
5302013-08-21 Paul Eggert <eggert@cs.ucla.edu>
531
532 * callproc.c: Fix race that killed background processes (Bug#15144).
533 (call_process): New arg TEMPFILE_INDEX. Callers changed.
534 Record deleted process-id in critical section, not afterwards.
535 Don't mistakenly kill process created by a call-process invocation
536 that discards output and does not wait.
537
0c5307b0
DA
5382013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
539
540 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
541 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
542 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
543 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
544 to shut up compiler in mark_object.
545 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
546
0d7c1e66
PE
5472013-08-21 Paul Eggert <eggert@cs.ucla.edu>
548
549 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
550 We can't portably rely on PTY_OPEN doing that, even if
551 it calls posix_openpt with O_CLOEXEC.
552
3f246b65
KH
5532013-08-20 Kenichi Handa <handa@gnu.org>
554
555 * character.c (string_char): Improve commentary.
556
8c2f38aa
PE
5572013-08-20 Paul Eggert <eggert@cs.ucla.edu>
558
559 * image.c (SIGNATURE_DIGESTSIZE): Remove.
560 (struct animation_cache): Make signature a flexible array member.
561 All uses changed. This is a tad slower but may insulate us better
562 from future changes to ImageMagick.
563
bb566cea
PE
5642013-08-19 Paul Eggert <eggert@cs.ucla.edu>
565
566 * image.c: Shrink memory needed for animation cache.
567 (SIGNATURE_DIGESTSIZE): New constant.
568 (struct animation_cache): Make 'signature' a fixed size array of bytes.
569 (imagemagick_create_cache): Copy the signature. This saves
570 several KB of memory that ImageMagick wastes per signature.
571 Don't bother updating the update_time, as the caller does that now.
572 (imagemagick_prune_animation_cache): Don't destroy the signature, as
573 it's a fixed size struct member now.
574 (imagemagick_get_animation_cache): Always destroy the signature,
575 as it's now imagemagick_create_cache's responsibility to copy it.
576 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
577 and use memcmp rather than strcmp.
578 eassert that ImageMagick returns a signature of the specified length.
579
6da26928
LMI
5802013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
581
582 * image.c (imagemagick_get_animation_cache): Don't segfault on
583 each invocation.
453f4022
LMI
584 (imagemagick_get_animation_cache): Revert to previous definition
585 so that it actually works. But keep the memory leak fix.
586 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 587
22490125
PE
5882013-08-19 Paul Eggert <eggert@cs.ucla.edu>
589
d0139df5
PE
590 * image.c: Fix animation cache signature memory leak.
591 Fix some other minor performance problems while we're at it.
592 (imagemagick_create_cache): Clear just the members that
593 need clearing. Don't set update_time, as caller does that now.
594 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
595 Simplify by using pointer-to-pointer instead of a prev pointer.
596 (imagemagick_prune_animation_cache): Use make_emacs_time rather
597 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
598 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
599 it's already a copy. Free the signature probe unless it's cached.
600
22490125
PE
601 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
602 This was introduced by my 2013-08-12 fix for Bug#15035.
603
deb31e75
DA
6042013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
605
606 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
607 (imagemagick_prune_animation_cache): Now static.
608
319a4d03
LMI
6092013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
610
611 * image.c (imagemagick_get_animation_cache): Don't segfault when
612 pruning all entries.
613
f747d82e
KB
6142013-08-18 Ken Brown <kbrown@cornell.edu>
615
616 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
617 static heap if ENABLE_CHECKING is defined.
618 (max_bss_sbrk_ptr): New variable.
619 (bss_sbrk): Use it.
620 (report_sheap_usage): Report maximum static heap usage instead of
621 ending static heap usage.
622
d2c28fab
EZ
6232013-08-17 Eli Zaretskii <eliz@gnu.org>
624
625 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
626 of zlib_initialized according to the results of calling
627 init_zlib_functions.
628
274ff63f
LMI
6292013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
630
631 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 632 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
633 (imagemagick_load_image): Remove the ping_wand code, which only
634 apparently saved time on invalid animated images, and slowed down
635 everything else. Optimise for the common case.
274ff63f 636
2bede2ed
XF
6372013-08-16 Xue Fuqiao <xfq.free@gmail.com>
638
70ff8240
XF
639 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
640
de179a3e
XF
641 * editfns.c (insert_before_markers): Mention overlay in the doc string.
642
2bede2ed
XF
643 * marker.c (set_marker): Remove documentation of undefined behavior.
644
703dbeba
LMI
6452013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
646
647 * image.c (imagemagick_compute_animated_image): Animate correctly
648 when sub-images are smaller than the main image.
1d18b1e6
LMI
649 (imagemagick_compute_animated_image): Setting the iterator row to
650 zero is apparently not allowed.
79670014
LMI
651 (imagemagick_compute_animated_image): Allow images that say they
652 have sub-images that are bigger than the main image, but just crop
653 them.
703dbeba 654
63216c5e
JD
6552013-08-15 Jan Djärv <jan.h.d@swipnet.se>
656
657 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
658
a5b5f73f
LMI
6592013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
660
661 * image.c (imagemagick_compute_animated_image): Respect the GIF
662 disposal methods.
663
0fe73012
KB
6642013-08-15 Ken Brown <kbrown@cornell.edu>
665
666 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
667 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
668 needed.
669
691a357f
PE
6702013-08-15 Paul Eggert <eggert@cs.ucla.edu>
671
672 Fix minor problems found by static checking.
673 * frame.c (delete_frame):
674 * xdisp.c (next_element_from_display_vector):
675 Avoid uninitialized local.
676 * image.c (imagemagick_compute_animated_image): Port to C89.
677 Prefer usual GNU indentation style for loops.
678 Be more careful about bizarrely large sizes, by using ptrdiff_t
679 instead of int.
680
42fe2e88
DA
6812013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
682
683 Fix infinite frame selection loop (Bug#15025).
684 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
685
d39a3da6
EZ
6862013-08-15 Eli Zaretskii <eliz@gnu.org>
687
068f9124
SM
688 * xdisp.c (compute_window_start_on_continuation_line):
689 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
690 to make sure we end up setting the window start at the leftmost
691 visible character of the display line. This avoids funky
692 horizontal shifting because the window start is not kept on the
693 same position. (Bug#15090)
05426239
EZ
694 (next_element_from_display_vector): Support 'box' face attribute
695 in the face definitions of a display vector. (Bug#15099)
d39a3da6 696
6e856b69
LMI
6972013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
698
699 * image.c (imagemagick_compute_animated_image): Implement animated
700 images (bug#14700).
995be755
LMI
701 (imagemagick_compute_animated_image): Fix some compilation
702 warnings. Implement a very simple cache to make the animation
703 usable at all, but it should be replaced with a per-image cache.
6e856b69 704
d5a1acfa
DA
7052013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
706
707 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
708 to do `for' loops over alist values.
709 * buffer.h (FOR_EACH_BUFFER):
710 * process.c (FOR_EACH_PROCESS): Use it.
711 (handle_child_signal, status_notify, Fget_buffer_process)
712 (kill_buffer_processes): Use FOR_EACH_PROCESS.
713
9c253307
DA
7142013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
715
716 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
717 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
718 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
719 to xzalloc and so avoid redundant call to memset.
720 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
721 members because it is allocated with xzalloc and so already zeroed.
722
05e64f9f
KB
7232013-08-14 Ken Brown <kbrown@cornell.edu>
724
725 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
726 (Bug#15094).
727
5b71542d
DA
7282013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Utility function and macro to copy Lisp string to C string.
731 * lisp.h (xlispstrdupa): New macro.
732 (xlispstrdup): New prototype.
733 * alloc.c (xlispstrdup): New function.
734 * callint.c (Fcall_interactively):
735 * fileio.c (Ffile_name_directory, Fexpand_file_name)
736 (Fsubstitute_in_file_name):
737 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
738 * image.c (x_create_bitmap_from_file):
739 * w32term.c (w32_term_init):
740 * xterm.c (x_term_init): Use xlispstrdup.
741
71530c97
LMI
7422013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
743
4ce82fb8
LMI
744 * image.c (imagemagick_load_image): Make animated pictures work.
745 There's still some problems with background color settings, though
746 (bug#14700).
747
71530c97
LMI
748 * decompress.c (unwind_decompress): Always restore point.
749
7510a061
XF
7502013-08-14 Xue Fuqiao <xfq.free@gmail.com>
751
752 * marker.c (set_marker): Reformat documentation.
753
01c3051f
PE
7542013-08-14 Paul Eggert <eggert@cs.ucla.edu>
755
aab1fcdf
PE
756 * xdisp.c (cursor_type_changed): Now static.
757
01c3051f
PE
758 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
759 Use changed. This avoids the need to call xmalloc and for the
760 caller to call xfree, and avoids memory leaks in some situations.
761
2084152a
DA
7622013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
763
764 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
765 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
766 (redisplay_window): If window_end_valid is cleared due to non-zero
767 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
768 so do not call to try_cursor_movement for that window.
2084152a 769
02455cb6
DA
7702013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
771
772 * window.h (struct window): Convert window_end_pos and
773 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
774 (wset_window_end_pos, wset_window_end_vpos): Remove.
775 * dispnew.c (adjust_glyph_matrix):
776 * window.c (Fwindow_end, replace_window, set_window_buffer)
777 (make_window):
778 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
779 (set_vertical_scroll_bar, redisplay_window, try_window)
780 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
781 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
782 (note_mouse_highlight): Adjust users.
783 (try_cursor_movement): Likewise. Convert old precondition to eassert.
784 Add comment.
785
da5707e8
DA
7862013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
789 * image.c (imagemagick_filename_hint): Use `const char *' and
790 prefer SSDATA to SDATA to avoid warnings.
791
25554267
DA
7922013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
793
794 Cleanup window fringes, margins and scroll bars adjustments.
795 * window.c (set_window_fringes, set_window_margins)
796 (set_window_scroll_bars, apply_window_adjustment): New functions.
797 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
798 (Fset_window_scroll_bars): Use them.
799
38a2c910
DA
8002013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
801
802 * window.h (struct window): Convert scroll_bar_width
803 from Lisp_Object to integer. Adjust comment.
804 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
805 Adjust users.
806 * window.c (wset_scroll_bar_width): Remove.
807 (make_window): Initialize scroll_bar_width.
808 (Fsplit_window_internal): Use direct assignment.
809 (Fset_window_configuration, save_window_save):
810 Convert Lisp_Object to integer and back where appropriate.
811 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
812 bar was actually changed, and mention this in docstring.
813
2d065031
PE
8142013-08-13 Paul Eggert <eggert@cs.ucla.edu>
815
816 * decompress.c: Minor simplifications.
817 (Fzlib_decompress_region): Don't bother verifying
818 that avail_out <= UINT_MAX, as that was confusing.
819 Mention the restriction in a comment instead.
820 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
821
a5bd5abb
JD
8222013-08-13 Jan Djärv <jan.h.d@swipnet.se>
823
824 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
825 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
826
66e7901a
LMI
8272013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
828
829 * image.c (imagemagick_filename_hint): Check for errors in the
830 alist structure.
831
2fa611b7
EZ
8322013-08-13 Eli Zaretskii <eliz@gnu.org>
833
834 * window.c (Fwindow_margins): Return nil when there's no marginal
835 area, as per the documented API.
836
837 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
838 Fmake_vector, as scroll bar's struct members are not all Lisp
839 objects now. This avoids crashes in GC.
840
841 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
842 bool, so its address could be taken.
843
8259030d
LMI
8442013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
845
846 * image.c (imagemagick_filename_hint): New function to possibly
847 apply `image-content-type-suffixes'.
848 (imagemagick_load_image): Use it.
849
866c710e
EZ
8502013-08-13 Eli Zaretskii <eliz@gnu.org>
851
852 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
853 if loading zlib failed.
854
f10490f0
JD
8552013-08-13 Jan Djärv <jan.h.d@swipnet.se>
856
96311be7
JD
857 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
858 2013-08-13 checkin below. Change bool to BOOL, rule is:
859 All Obj-C code uses BOOL, except for interfaces callable from C.
860
f10490f0
JD
861 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
862
c8ae93b0
DA
8632013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
864
865 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
866 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
867 bool instead of BOOL.
868 * w32term.h (struct scroll_bar): Convert fringe_extended_p
869 from Lisp_Object to bitfield. Adjust comment.
870 * w32term.c (x_scroll_bar_create): Adjust user.
871 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
872 * xterm.c (XTset_vertical_scroll_bar): Likewise.
873 Use bool for boolean.
874 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
875 to `unsigned int' when defining a bitfield.
876
53b64418
PE
8772013-08-13 Paul Eggert <eggert@cs.ucla.edu>
878
879 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
880
eeaf9bf3
DA
8812013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
882
883 * window.h (struct window): Convert left_margin_cols and
884 right_margin_cols from Lisp_Objects to integers. Adjust comment.
885 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
886 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
887 Adjust users.
888 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
889 Adjust comment.
890 (showing_window_margins_p, update_window_line, update_frame_1):
891 * fringe.c (draw_fringe_bitmap_1):
892 * xdisp.c (window_box_width): Adjust users.
893 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
894 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
895 Use direct assignment.
896 (Fset_window_configuration, save_window_save, Fwindow_margins):
897 Convert Lisp_Object to integer and back where appropriate.
898 (Fset_window_margins): Adjust user. Return t if any margin
899 was actually changed, and mention this in docstring.
900
956720af
XF
9012013-08-13 Xue Fuqiao <xfq.free@gmail.com>
902
f73f4ce6 903 * syntax.c (forward_word):
956720af
XF
904 * cmds.c (forward_char, backward_char): Mention the optional argument.
905
9e37ee3b
DA
9062013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
907
908 * window.h (struct window): Convert left_fringe_width
909 and right_fringe_width from Lisp_Objects to integers.
910 Adjust comment.
911 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
912 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
913 * window.c (wset_left_fringe_width, wset_right_fringe_width):
914 Remove.
915 (make_window): Initialize new integer fields to -1.
916 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
917 (Fset_window_configuration, save_window_save):
918 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
919 (Fset_window_fringes): Adjust user. Return t if any fringe
920 was actually changed, and mention this in docstring.
921
e4375ca7
DA
9222013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
923
924 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
925 * nsfns.m (x_set_cursor_type):
926 * w32fns.c (x_set_cursor_type):
927 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
928 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 929
a45543bc
DA
9302013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
931
932 * font.c (clear_font_cache): New function, stripped from...
933 (Fclear_font_cache): ...here, which now uses the function
934 above. Adjust comment.
935 * font.h (clear_font_cache): Add prototype.
936 * xfaces.c (clear_face_cache): Use clear_font_cache.
937
ae966a86
DA
9382013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
939
940 * window.c (Fset_window_start): Compare `w', not `window' because
941 `w' might not be equal to `window' after call to decode_live_window.
942
297a545b
PE
9432013-08-12 Paul Eggert <eggert@cs.ucla.edu>
944
945 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
946 This fixes a problem introduced by the Bug#15035 patch
947 when using GPG. Reported by Herbert J. Skuhra.
948
aa942e2b
EZ
9492013-08-12 Eli Zaretskii <eliz@gnu.org>
950
951 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
952 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
953 not yet initialized.
954
7699d09e
LMI
9552013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
956
957 * decompress.c (Fzlib_decompress_region): Support zlib
958 decompression, too, and rename.
959
1d238bc7
PE
9602013-08-12 Paul Eggert <eggert@cs.ucla.edu>
961
962 Minor zlib configuration tweaks.
963 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
964 Don't assume presence of fn_inflateInit2_ zlib internal function.
965
8a44a184
LMI
9662013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
967
968 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
969 include the zlib prefix.
970
594a4307
EZ
9712013-08-12 Eli Zaretskii <eliz@gnu.org>
972
973 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
974 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
975 define static variables that are pointers to zlib functions to be
976 dynamically loaded.
977 (init_zlib_functions) [WINDOWSNT]: New function.
978 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
979 New macros.
980 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
981 macros instead of invoking the zlib functions directly.
068f9124
SM
982 (syms_of_decompress): DEFSYM Qzlib_dll.
983 Staticpro Szlib_available_p.
594a4307 984
d2e113bc
DA
9852013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
986
987 Avoid looping over all frame windows to freeze and unfreeze.
988 * window.h (struct window): Drop frozen_window_start_p.
989 (freeze_window_starts): Drop prototype.
990 * frame.h (struct frame): New frozen_window_starts flag.
991 (FRAME_WINDOWS_FROZEN): New macro.
992 * window.c (freeze_window_start, freeze_window_starts):
993 Remove.
994 (select_window, replace_window): Adjust users.
995 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
996 (window_frozen_p): New function.
997 (redisplay_window): Use it.
998
94fcd171
PE
9992013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1000
1001 Fix some fd issues when running subprocesses (Bug#15035).
1002 Fix bugs that can leak files or file descriptors on errors.
1003 Don't unlink open temp files, as that's hard for users to diagnose
1004 when things go awry (e.g., temp disk exhausted).
1005 Don't bother to lock temp files. Check for invalid recursion.
1006 * callproc.c (synch_process_fd): Remove. All uses removed.
1007 (synch_process_tempfile): New var or macro.
1008 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1009 New constants.
1010 (record_kill_process): New arg, the temp name. All callers changed.
1011 (delete_temp_file): Now just a simple wrapper around unlink.
1012 (call_process_kill): New arg, the call_process_fd array.
1013 Close them all. Clear synch_process_pid. Remove the temp file,
1014 or arrange for it to be removed.
1015 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1016 that's been moved to synch_process_tempfile. Caller changed.
1017 Do not remove the tempfile; that's now call_process_kill's
1018 responsibility.
1019 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1020 call_process_kill; the caller now does that.
1021 (call_process_cleanup): Do not close the process fd; that's now
1022 call_process_kill's responsibility.
1023 (Fcall_process): Implement via new function call_process, which
1024 has most of the old body of Fcall_process, but with a different API.
1025 (call_process): New function that does not open or close filefd if
1026 it is nonnegative. Record which fds need to be closed, and let
1027 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1028 Signal an error if invoked recursively (could be done via a hook).
1029 Simplify creation of the tempfile in the MSDOS case.
1030 Don't create the output file until after checking for the executable.
1031 Report any failure to open /dev/null.
1032 Don't open /dev/null for writing twice; once is enough.
1033 Don't create pipe if all output is being discarded or sent to file.
1034 Don't worry about setting up the coding system or reading from the
1035 pipe if all output is being discarded.
1036 Hoist fd_error local into top level, to lessen block nesting.
1037 Don't record deleted pid here; now done by Fcall_process_region.
1038 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1039 and note its success in synch_process_tempfile.
1040 Do not leak resources when child_setup fails.
1041 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1042 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1043 (create_temp_file): Now returns open fd, with an additional
1044 Lisp_Object * argument to return the name. All callers changed.
1045 Do not close the file; rewind it instead, and leave it open for
1046 the caller. Do not lock the temp file. Unwind-protect the file
1047 and the file-descriptor.
1048 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1049 If an asynchrounous process, record it here, not in call_process.
1050 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1051 * eval.c (set_unwind_protect): New function.
1052 * fileio.c (write_region): New function, generalized from the
1053 old Fwrite_region. Do not lock temp files.
1054 (Fwrite_region): Use it.
1055 * lisp.h (set_unwind_protect, write_region): New decls.
1056 * process.c: Include <verify.h>.
1057 (make_process): Mark fds as initially closed.
1058 (deleted_pid_list): Now a list of pid-filename pairs.
1059 All uses changed.
1060 (close_process_fd): New function.
1061 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1062 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1063 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1064 (create_process, create_pty, Fmake_serial_process)
1065 (server_accept_connection): Record which fds need to be closed,
1066 and let deactivate_process close them.
1067 (Fmake_network_process): Do not discard the unwind-protect
1068 until it's safe to do so.
1069 (deactivate_process): Close the fds opened by create_process etc.
1070 (Fprocess_send_eof): Adjust to new way of recording open fds.
1071 Report an error if /dev/null can't be opened, instead of aborting.
1072 * process.h (PROCESS_OPEN_FDS): New constant.
1073 (struct Lisp_Process): New member open_fds.
1074 (record_kill_process, record_deleted_pid): Adjust signatures.
1075 (record_deleted_pid): Move decl here ...
1076 * syswait.h (record_deleted_pid): ... from here.
1077
d0e615c3
PE
10782013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * decompress.c: Fix bugs with large buffers and weird inputs.
1081 Tune a bit. Reindent as per usual Emacs style.
1082 (BUFFER_SIZE): Remove.
1083 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1084 more than UINT_MAX bytes. Decompress into the gap instead of into
1085 an auto buffer, as this should avoid copying. Return nil if
1086 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1087 set immediate_quit; we shouldn't trust zlib code that much.
1088
313546eb
LMI
10892013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1090
99a32242
LMI
1091 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1092 errors, and really move the gap to where we want it.
1093
313546eb
LMI
1094 * lisp.h: Include decompress.c support.
1095
1096 * emacs.c (main): Include decompress.c support.
1097
1098 * Makefile.in: Include -lz if present.
1099
d2d699ac
JD
11002013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1101
f90e3ebd
JD
1102 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1103 (initWithTitle:): Initialize frame to 0.
1104 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1105 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1106 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1107
1108 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1109 fillWithWidgetValue:frame:
1110
423d3b3f
JD
1111 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1112 remove memory leak warnings.
1113
d2d699ac
JD
1114 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1115 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1116 menu_pending_title.
1117
1118 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1119 (x_activate_menubar): Update the whole menu.
1120 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1121 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1122 current event is not NSSystemDefined (Bug#15001).
1123 Call ns_check_menu_open only if trackingMenu is 2.
1124 (menuDidClose:): New method, decrease trackingMenu.
1125 (fillWithWidgetValue:setDelegate:): New method.
1126 (fillWithWidgetValue:): Call the above.
1127
1128 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1129
7d652d97
PE
11302013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1131
1132 Omit some unnecessary casts.
1133 Many of these go back to the old pre-C89 days, when they may have
1134 been needed, but we've been assuming C89 or later for a while now.
1135 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1136 (live_float_p, live_misc_p, live_vector_p):
1137 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1138 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1139 (defvar_per_buffer):
1140 * callint.c (Fcall_interactively):
1141 * doc.c (Fsubstitute_command_keys):
1142 * filelock.c (get_boot_time):
1143 * frame.c (xrdb_get_resource):
1144 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1145 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1146 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1147 (menuitem_highlight_callback, menu_destroy_callback)
1148 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1149 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1150 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1151 (xg_tool_bar_help_callback, tb_size_cb):
1152 * image.c (xpm_alloc_color, png_read_from_memory)
1153 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1154 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1155 (syms_of_image):
1156 * keymap.c (describe_map):
1157 * nsfns.m (Fns_display_monitor_attributes_list):
1158 * nsmenu.m (process_dialog:):
1159 * nsterm.m (hold_event):
1160 * process.c (wait_reading_process_output):
1161 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1162 * scroll.c (do_direct_scrolling, scrolling_1):
1163 * termcap.c (tgetent):
1164 * window.c (check_window_containing, add_window_to_list)
1165 (freeze_window_starts):
1166 * xdisp.c (compare_overlay_entries, vmessage):
1167 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1168 (x_get_monitor_attributes_xrandr)
1169 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1170 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1171 * xfont.c (xfont_match, xfont_open):
1172 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1173 (menubar_selection_callback, menu_position_func)
1174 (popup_selection_callback, create_and_show_popup_menu)
1175 (dialog_selection_callback, create_and_show_dialog):
1176 * xrdb.c (x_get_string_resource):
1177 (main) [TESTRM]:
1178 * xsmfns.c (x_session_check_input):
1179 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1180 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1181 (xaw_jump_callback, xaw_scroll_callback):
1182 Omit unnecessary casts.
1183
9acc1074
PE
11842013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 Minor string-length refactoring.
1187 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1188 * frame.c (make_monitor_attribute_list):
1189 Prefer build_string to strlen + make_string.
1190
361c0eb8
JD
11912013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1192
1193 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1194 don't check minor_code (Bug#14417).
1195
14ba0822
EZ
11962013-08-09 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1199 vertical positions instead. This avoids calling MATRIX_ROW with
1200 row numbers that are possibly beyond valid limits. (Bug#15064)
1201
309f24d1
DA
12022013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1203
1204 Use xstrdup and build_unibyte_string where applicable.
1205 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1206 * xfns.c (x_window):
1207 * xrdb.c (x_get_customization_string):
1208 * xterm.c (xim_initialize):
1209 * w32fns.c (w32_window): Use xstrdup.
1210 (w32_display_monitor_attributes_list):
1211 * emacs.c (init_cmdargs):
1212 * keyboard.c (PUSH_C_STR):
1213 * nsfont.m (nsfont_open):
1214 * sysdep.c (system_process_attributes):
1215 * w32.c (system_process_attributes):
1216 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1217
55902276
EZ
12182013-08-09 Eli Zaretskii <eliz@gnu.org>
1219
1220 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1221 variables of these types so that GDB would know about them, as aid
1222 for debugging fatal exceptions. (Bug#15024) See also
1223 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1224 discussions.
1225
10bf7f5a
JD
12262013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1227
1228 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1229 larger than the NSWindow (Bug#14934).
1230
65620264
DA
12312013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1232
1233 Redesign redisplay interface to drop global variable updated_window.
1234 Always pass currently updated window as a parameter to update routines.
1235 * dispextern.h (updated_window): Remove declaration.
1236 (struct redisplay_interface): Pass window parameter to
1237 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1238 and after_update_window_hook.
1239 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1240 Adjust prototypes.
1241 * dispnew.c (updated_window): Remove.
1242 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1243 (update_window_line): Adjust to match redisplay interface changes.
1244 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1245 (ns_scroll_run, ns_after_update_window_line):
1246 * w32term.c (x_update_window_begin, x_update_window_end)
1247 (x_after_update_window_line, x_scroll_run):
1248 * xterm.c (x_update_window_begin, x_update_window_end)
1249 (x_after_update_window_line, x_scroll_run):
1250 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1251 Likewise. Adjust comments where appropriate.
1252 (x_cursor_to): Simplify because this is always called during window
1253 update (but install debugging check anyway).
1254 (expose_window): Check must_be_updated_p flag to see whether this
1255 function is called during window update.
1256
628fdc56
DA
12572013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1258
1259 Do not reset window modification event counters excessively.
1260 These leftovers and poor man's tricky methods to catch extra
1261 redisplay's attention are no longer needed.
1262 * frame.c (set_menu_bar_lines_1):
1263 * minibuf.c (read_minibuf_unwind):
1264 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1265 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1266 (window_scroll_line_based, Fset_window_configuration):
1267 * xdisp.c (redisplay_window): Do not reset last_modified and
1268 last_overlay_modified counters.
1269
8fd9c92e
JD
12702013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1271
1272 * xselect.c (x_send_client_event): Set send_event and serial, memset
1273 data.l as it might be bigger than data.b. Use 24 bit mask to
1274 XSendEvent (Bug#15034).
1275
0ee18172
EZ
12762013-08-07 Eli Zaretskii <eliz@gnu.org>
1277
1278 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1279 for TTY frames that are not the top frame on their console.
1280 (Bug#14616)
1281
16ddd1a6
MR
12822013-08-07 Martin Rudalics <rudalics@gmx.at>
1283
1284 * w32term.c (w32fullscreen_hook): Really maximize frame when
1285 asked for (Bug#14841).
1286
d2a95ffb
DA
12872013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1288
1289 Prefer selected_window to Fselected_window, likewise for frames.
1290 * buffer.c (Fbuffer_swap_text):
1291 * data.c (Fvariable_binding_locus):
1292 * window.c (run_window_configuration_change_hook): Adjust users.
1293 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1294 Use decode_live_frame.
1295
170da1ec
DA
12962013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1297
1298 Be more careful if selected window shows the buffer other than current,
1299 use window_outdated only if this is not so. This change should also
1300 address some weird issues discussed in Bug#13012.
1301 * window.h (window_outdated): New prototype.
1302 * window.c (window_outdated): Now here. Convert from static and
1303 always assume window's buffer.
1304 (Fwindow_end, Fwindow_line_height): Use it.
1305 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1306 and always assume window's buffer.
1307 (redisplay_window): Adjust user.
e5eefe9b 1308 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1309 check whether mode line should be updated only if selected window
1310 shows current buffer.
1311 (run_window_scroll_functions): Use eassert for debugging check.
1312 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1313
56b5d5b1
DA
13142013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1315
1316 * window.c (window_scroll, window_scroll_pixel_based)
1317 (window_scroll_line_based): Use bool for booleans.
1318
2878ba7e
PE
13192013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * process.c: Fix minor off-by-one issues in descriptor counts.
1322 This shouldn't fix any real bugs, but it cleans up the code a bit.
1323 (max_process_desc, max_input_desc): -1, not 0, means none.
1324 All uses changed.
1325 (delete_input_desc): New function.
1326 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1327 (deactivate_process): Scan backwards when recomuting max_process_desc;
1328 that should be faster.
1329 (init_process_emacs): Initialize max_input_desc.
1330
e30b79c1
DA
13312013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1332
1333 Use region cache to speedup bidi_find_paragraph_start.
1334 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1335 Rename cache_long_line_scans to cache_long_scans.
1336 * buffer.c (bset_cache_long_line_scans): Rename to
1337 bset_cache_long_scans.
1338 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1339 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1340 into account.
1341 (syms_of_buffer): Rename cache-long-line-scans to
1342 cache-long-scans. Adjust docstring.
1343 * search.c (newline_cache_on_off):
1344 * indent.c (width_run_cache_on_off): Adjust users.
1345 * bidi.c (bidi_paragraph_cache_on_off): New function.
1346 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1347 * insdel.c (prepare_to_modify_buffer):
1348 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1349
00012b86
DA
13502013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1351
1352 Invalidate region caches only if buffer text is going to be changed.
1353 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1354 (modify_text): ...new prototype.
1355 (prepare_to_modify_buffer_1): New prototype.
1356 * textprop.c (modify_region): Rename to...
1357 (modify_text_properties): ...new function.
1358 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1359 (Fremove_list_of_text_properties): Adjust users.
1360 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1361 (modify_text): ...new function.
1362 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1363 (prepare_to_modify_buffer_1): ...new function.
1364 * casefiddle.c (casify_region):
1365 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1366 (Ftranspose_regions): Use modify_text.
1367
dc6c0eda
SM
13682013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1369
1370 * lisp.mk (lisp): Add nadvice.elc.
1371
8f3a2c26
DA
13722013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 New macro to iterate over live buffers similar to frames.
1375 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1376 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1377 Declare buffer-related variables here to offload lisp.h.
1378 * buffer.c (Vbuffer_alist): Adjust comment.
1379 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1380 (other_buffer_safely):
1381 * data.c (store_symval_forwarding):
1382 * dispnew.c (Fframe_or_buffer_changed_p):
1383 * fileio.c (Fdo_auto_save):
1384 * filelock.c (unlock_all_files):
1385 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1386
e0fdb694
PE
13872013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1390 * callproc.c (create_temp_file):
1391 * filelock.c (create_lock_file):
1392 Assume mkostemp, since it's now provided by Gnulib.
1393
63f5c6c2
EZ
13942013-08-04 Eli Zaretskii <eliz@gnu.org>
1395
1396 * w32.c (mkostemp): New function.
1397 (mktemp): Remove, no longer used. Most of the code reused in
1398 mkostemp. (Bug#15015)
484ab239 1399 (mktemp): Don't undef.
63f5c6c2 1400
f0b79313
DA
14012013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1402
1403 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1404 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1405 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1406 (free_glyph_pool, check_glyph_memory): Likewise for
1407 all users. Adjust comments where appropriate.
1408
98f638d6
PE
14092013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 * composite.h: Minor fixups.
1412 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1413 to fix a misspelling, and change it to an inline function while
1414 we're at it (it need not be a macro). All uses changed.
1415 (composition_method, composition_valid_p):
1416 Rewrite to avoid assignments in if-conditions.
1417
75c59fb3
DA
14182013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1419
1420 Do not use global Lisp_Object in composition macros.
1421 * composite.h (composition_temp): Remove declaration.
1422 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1423 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1424 (compose_region): Remove the leftover.
75c59fb3
DA
1425 * composite.c (composition_temp): Remove.
1426 (run_composition_function, update_compositions)
1427 (composition_compute_stop_pos, composition_adjust_point)
1428 (Ffind_composition_internal):
1429 * coding.c (handle_composition_annotation):
1430 * xdisp.c (handle_composition_prop, check_point_in_composition):
1431 Related users changed.
1432
a10c8269
DA
14332013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1434
1435 Drop FRAME_PTR typedef.
1436 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1437 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1438 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1439 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1440 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1441 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1442 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1443 All related users changed.
1444
a104f656
SM
14452013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1446
1447 * eval.c (default_toplevel_binding): New function.
1448 (Fdefvar): Use it.
1449 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1450 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1451 (syms_of_eval): Export them.
1452 * data.c (Fdefault_value): Micro cleanup.
1453 * term.c (init_tty): Use "false".
1454
4b5c9326
DA
14552013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1456
1457 Fix X GC leak in GTK and raw (no toolkit) X ports.
1458 * xterm.c (x_free_frame_resources): If white and black relief
1459 GCs are allocated, always free them here.
1460 * xfns.c (x_make_gc): Omit redundant initialization.
1461 * widget.c (create_frame_gcs): Remove the leftover.
1462 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1463 in x_free_frame_resources.
1464
b19aa636
JD
14652013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1466
1467 * nsterm.m (windowWillResize:toSize:): Only change title if
1468 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1469 modifying it.
1470 (viewDidEndLiveResize): New method.
1471
1472 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1473 inside NS_IMPL_COCOA.
1474
af1f7e06
DA
14752013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1478 Do not check whether undo is enabled because record_insert and
1479 record_delete does that themselves.
1480
65b02bb9
DA
14812013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1482
1483 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1484 member which is not really used any more.
1485 (FRAME_XIC_BASE_FONTNAME): Remove.
1486 * xfns.c (xic_free_fontset): Adjust user.
1487 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1488 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1489 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1490 (xdialog_show): Use eassert for debugging check.
7ee0f047 1491 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1492
6318cde0
PE
14932013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 * fileio.c, fns.c (merge): Move extern decl from here ...
1496 * lisp.h (merge): ... to here.
1497
6c1a09ba
DA
14982013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1499
1500 Fix last font-related change.
1501 * w32font.h (w32font_list_internal, w32font_match_internal):
1502 Fix prototype.
1503 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1504 (uniscribe_list_family): Adjust to match font API change.
1505 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1506 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1507
f8c20208
DA
15082013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1509
1510 * frame.h (FRAME_MOUSE_UPDATE):
1511 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1512 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1513
fdb396e2
DA
15142013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1515
1516 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1517 * font.h (struct font_driver): Change list, match, and list_family
1518 functions to accept struct frame * as first arg.
068f9124
SM
1519 * font.c (font_score, font_compare, font_sort_entities):
1520 Remove prototypes.
fdb396e2
DA
1521 (font_sort_entities, font_list_entities, font_select_entity):
1522 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1523 match font API change.
1524 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1525 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1526 * ftxfont.c (ftxfont_list, ftxfont_match):
1527 * xftfont.c (xftfont_list, xftfont_match):
1528 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1529 * w32font.c (w32font_list, w32font_match, w32font_list):
1530 (w32font_list_internal, w32_font_match_internal): Likewise.
1531 * xfaces.c (Fx_family_fonts): Adjust user.
1532
52b8a085
DA
15332013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1534
1535 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1536 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1537 only if HAVE_X_WINDOWS is in use.
1538 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1539 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1540 * w32term.c (x_wm_set_icon_position): Likewise.
1541 * w32fns.c (x_icon): Adjust user.
1542
c791c18e
DA
15432013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1544
1545 * xterm.c (last_mouse_press_frame): Remove the
1546 leftover which is not really used any more.
1547 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1548 (x_flush): Call XFlush once per each X display, not frame.
1549 This is better because this code always unconditionally skips
1550 non-X frames in Vframe_list and issues the only XFlush if we
1551 have more than one X frame on the same X display.
2f935d86
DA
1552 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1553 Use bool for booleans.
1554 (x_draw_glyph_string_background, cvt_string_to_pixel):
1555 (cvt_pixel_dtor): Drop unnecessary prototypes.
1556 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1557
f435830e
DA
15582013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1559
1560 Drop unnecessary functions that deals with frame pixel size.
1561 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1562 (x_pixel_height): Drop prototypes.
1563 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1564 (x_pixel_height): Drop implementations.
1565 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1566 which should be always valid for window frame.
1567 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1568 * w32menu.c (Fx_popup_dialog):
1569 * xmenu.c (Fx_popup_dialog): Likewise for both.
1570
84231434
DA
15712013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1572
1573 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1574 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1575 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1576 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1577 and mention nil frame in docstring.
84231434 1578
959067a1
DA
15792013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1580
1581 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1582 (x_figure_window_size): Likewise. Adjust to return long.
1583 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1584 (toplevel): Move Qterminal_live_p to...
1585 * terminal.c (toplevel): ...here, make it static, and...
1586 (syms_of_terminal): ...DEFSYM here.
1587 * frame.h (Qterminal_live_p): Remove declaration.
1588 (make_frame, x_figure_window_size): Adjust prototype.
1589 * nsfns.m (Fx_create_frame): Use long for window flags.
1590
f4b169ce
PE
15912013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1592
1593 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1594 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1595 Do not assume that emacs_close (INT_MAX) is a no-op.
1596
bee6a2c7
DA
15972013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1598
1599 * xfaces.c (make_face_cache): For struct face_cache, prefer
1600 xmalloc to xzalloc and so avoid redundant call to memset.
1601 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1602
d7e6881a
DA
16032013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1604
1605 * fringe.c (draw_window_fringes, update_window_fringes)
1606 (compute_fringe_widths):
1607 * w32term.c (x_draw_glyph_string):
1608 * window.c (candidate_window_p, Frecenter):
1609 * xfaces.c (realize_basic_faces, realize_default_face)
1610 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1611 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1612 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1613 * xmenu.c (Fx_menu_bar_open_internal):
1614 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1615 * xsettings.c (xft_settings_event):
1616 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1617 Use bool for booleans. Adjust style and comments where
1618 appropriate.
1619 * dispextern.h (draw_window_fringes, update_window_fringes)
1620 (compute_fringe_widths):
1621 * xterm.h (x_had_errors_p): Adjust prototype.
1622
ec3058af
DA
16232013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1624
1625 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1626 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1627
218e0637
DA
16282013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1629
1630 * fns.c (toplevel): Remove comment before Fsafe_length because
1631 it checks for QUIT.
1632
e560aba9
PE
16332013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1634
1635 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1636
2e5ce5de
EZ
16372013-07-28 Eli Zaretskii <eliz@gnu.org>
1638
1639 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1640 frame which got the message is still alive, before dereferencing
1641 its pointer. (Bug#14970)
1642
1643 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1644 be a live window, before using it as such. (Bug#14970)
1645
e95da6d3
EZ
16462013-07-27 Eli Zaretskii <eliz@gnu.org>
1647
1648 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1649 w32_detect_focus_change instead of doing part of its job by hand.
1650 This fixes the problem whereby FOCUS_OUT events were not sent to
1651 the event queue.
1652
a8f93651
EZ
16532013-07-26 Eli Zaretskii <eliz@gnu.org>
1654
fec92060
EZ
1655 * process.c (Fprocess_list): Doc fix.
1656
a8f93651
EZ
1657 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1658 being re-exposed only if it didn't ask to become visible.
1659 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1660 was previously iconified. (Bug#14841)
1661 (x_iconify_frame): Mark the frame iconified.
1662
d5a7a9d9
PE
16632013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1664
1665 Fix minor problems found by static checking.
1666 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1667 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1668
56ea7291
SM
16692013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1670
1671 * eval.c (set_specpdl_old_value): New function.
1672 (unbind_to): Minor simplification.
1673 (get_backtrace_frame): New function.
1674 (Fbacktrace_frame): Use it. Add `base' argument.
1675 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1676 (syms_of_eval): Export backtrace-eval.
1677 * xterm.c (x_focus_changed): Simplify.
1678
9d611ffe
PE
16792013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1682
999c74e3
EZ
16832013-07-24 Eli Zaretskii <eliz@gnu.org>
1684
1685 * xdisp.c (redisplay_window): Instead of moving point out of
1686 scroll margin, reject the force_start method, and try scrolling
1687 instead. (Bug#14780)
1688
198fa217
KB
16892013-07-24 Ken Brown <kbrown@cornell.edu>
1690
1691 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1692 (Bug#14944).
1693
53840e55
PE
16942013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 * eval.c (Fprogn): Do not check that BODY is a proper list.
1697 This undoes the previous change. The check slows down the
1698 interpreter, and is not needed to prevent a crash. See
1699 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1700
60967f56
GM
17012013-07-23 Glenn Morris <rgm@gnu.org>
1702
1703 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1704
9ca960e2
PE
17052013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1706
a29c3e6d
PE
1707 Port to GNU/Linux systems with tinfo but not ncurses.
1708 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1709 to decide whether ncurses is being used. Without this change,
1710 GCC complains about tgetent not being declared, on a system
1711 that has tinfo installed but ncurses not installed.
1712
f274311c
PE
1713 * eval.c (Fprogn): Check that BODY is a proper list.
1714
16b0520a
PE
1715 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1716 * data.c (Fsetq_default):
1717 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1718 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1719 (Fcondition_case):
1720 Tune by taking advantage of the fact that ARGS is always a list
1721 when a function is declared to have UNEVALLED args.
1722
9ca960e2
PE
1723 * emacsgtkfixed.c: Port to GCC 4.6.
1724 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1725
afacaa1b
JB
17262013-07-23 Juanma Barranquero <lekktu@gmail.com>
1727
1728 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1729 here to silence compiler warnings.
1730
368a85a4
PE
17312013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1734 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1735 from messing up Emacs's 'struct frame' (Bug#14923).
1736
f4e891b5
PE
17372013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1738
1739 * alloc.c (make_save_ptr_ptr): Define this function.
1740 It was inadvertently omitted. It's needed only if
1741 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1742
96c8b65e
JD
17432013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1744
1745 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1746 frame have focus (Bug#14895).
1747
ee010797
PE
17482013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1749
1750 Avoid vfork-related deadlock more cleanly.
1751 * callproc.c (child_setup): When the child's exec fails, output
1752 the program name, as that's more useful. Use O_NONBLOCK to avoid
1753 deadlock.
1754 * process.c (create_process_1): Remove; no longer needed.
1755 (create_process): Remove timer hack; no longer needed, now that
1756 the child avoids deadlock.
1757
f0398ec1 17582013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1759
1760 * image.c (Fimage_flush): Fix doc typo.
1761
b2a069c2
PE
17622013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1763
6496aec9
PE
1764 Fix array bounds violation when pty allocation fails.
1765 * process.c (PTY_NAME_SIZE): New constant.
1766 (pty_name): Remove static variable; it's now auto.
1767 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1768 Take pty_name as an arg rather than using a static variable.
1769 All callers changed.
1770 (create_process): Recover pty_flag from process, not from volatile local.
1771 (create_pty): Stay inside array even when pty allocation fails.
1772 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1773
b2a069c2
PE
1774 * lread.c (Fload): Avoid initialization only when lint checking.
1775 Mention that it's needed only for older GCCs.
1776
99107004
KH
17772013-07-20 Kenichi Handa <handa@gnu.org>
1778
1779 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1780 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1781
6b1b199d
AS
17822013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1783
1784 * lread.c (Fload): Avoid uninitialized warning.
1785
4195afc3
PE
17862013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1787
3f5bef16
PE
1788 Fix some minor file descriptor leaks and related glitches.
1789 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1790 (create_lock_file): Use write, not emacs_write.
1791 * image.c (slurp_file, png_load_body):
1792 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1793 (server_accept_connection):
1794 Don't leak an fd on memory allocation failure.
1795 * image.c (slurp_file): Add a cheap heuristic for growing files.
1796 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1797 as that's what the other routines do. Maybe input need not be
1798 blocked at all, but it's better to be consistent.
1799 Avoid undefined behavior when strlen is zero.
1800
4195afc3
PE
1801 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1802 (NSTATICS): Now a constant; doesn't need to be a macro.
1803
a1aeeffe
RS
18042013-07-19 Richard Stallman <rms@gnu.org>
1805
1806 * coding.c (decode_coding_utf_8): Add simple loop for fast
1807 processing of ASCII characters.
1808
63b34baa
PE
18092013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1812
621dd9ac
EZ
18132013-07-19 Eli Zaretskii <eliz@gnu.org>
1814
1815 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1816 unportable 'struct x_display_info'.
1817 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1818 is a portable type.
1819
1396ac86
PE
18202013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1821
ab9980cd
PE
1822 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1823 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1824 or fscanf fails.
1825 (system_process_attributes): Prefer plain char to unsigned char
1826 when either will do. Clean up properly if interrupted or if
068f9124
SM
1827 memory allocations fail. Don't assume sscanf succeeds.
1828 Remove no-longer-needed workaround to stop GCC from whining.
1829 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1830 bit more carefully.
1831
1396ac86
PE
1832 Fix obscure porting bug with varargs functions.
1833 The code assumed that int is treated like ptrdiff_t in a vararg
1834 function, which is not a portable assumption. There was a similar
1835 -- though these days less likely -- porting problem with various
1836 assumptions that pointers of different types all smell the same as
1837 far as vararg functions is conserved. To make this problem less
1838 likely in the future, redo the API to use varargs functions.
1839 * alloc.c (make_save_value): Remove this vararg function.
1840 All uses changed to ...
1841 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1842 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1843 New functions.
1844 (make_save_ptr): Rename from make_save_pointer, for consistency with
1845 the above. Define only on platforms that need it. All uses changed.
1846
4d19d194
PE
18472013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 * keyboard.c: Try to fix typos in previous change.
1850 (DISPLAY_LIST_INFO): New macro.
1851 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1852 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1853
945c5bb1
JB
18542013-07-18 Juanma Barranquero <lekktu@gmail.com>
1855
1856 * keyboard.c (kbd_buffer_get_event):
1857 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1858 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1859
f4b1eb36
PE
18602013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1861
5e679a2c
PE
1862 * filelock.c: Fix unlikely file descriptor leaks.
1863 (get_boot_time_1): Rework to avoid using emacs_open.
1864 This doesn't actually fix a leak, but is better anyway.
1865 (read_lock_data): Use read, not emacs_read.
1866
a8cd4836
PE
1867 * doc.c: Fix minor memory and file descriptor leaks.
1868 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1869 (get_doc_string, Fsnarf_documentation):
1870 Fix file descriptor leak on error.
1871
ef30e638
PE
1872 * term.c: Fix minor fdopen-related file descriptor leaks.
1873 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1874 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1875
f4b1eb36
PE
1876 * charset.c: Fix file descriptor leaks and errno issues.
1877 Include <errno.h>.
1878 (load_charset_map_from_file): Don't leak file descriptor on error.
1879 Use plain record_xmalloc since the allocation is larger than
1880 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1881 of entries.
1882 * eval.c (record_unwind_protect_nothing):
1883 * fileio.c (fclose_unwind):
1884 New functions.
1885 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1886 The replacement doesn't block input, but that no longer seems
1887 necessary.
1888
b648c163
PE
18892013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1890
a0931322
PE
1891 * lread.c: Fix file descriptor leaks and errno issues.
1892 (Fload): Close some races that leaked fds or streams when 'load'
1893 was interrupted.
1894 (Fload, openp): Report error number of last nontrivial failure to open.
1895 ENOENT counts as trivial.
1896 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1897 New functions.
1898 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1899 now that the function is always called with a nonnegative arg.
1900 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1901 All uses replaced with ...
1902 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1903
b648c163
PE
1904 A few more minor file errno-reporting bugs.
1905 * callproc.c (Fcall_process):
1906 * doc.c (Fsnarf_documentation):
1907 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1908 * process.c (set_socket_option):
1909 Don't let a constructor trash errno.
1910 * doc.c: Include <errno.h>.
1911
b1dc4084
JB
19122013-07-16 Juanma Barranquero <lekktu@gmail.com>
1913
1914 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1915
c43843aa
PE
19162013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1917
50a30cce
PE
1918 Fix w32 bug with call-process-region (Bug#14885).
1919 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1920 to Fcall_process when the input is empty. This simplifies the
1921 code a bit. It makes no difference on POSIXish platforms but
1922 apparently it fixes a bug on w32.
1923
44e18199 1924 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1925 * fileio.c (close_file_unwind): Don't close if FD is negative;
1926 this can happen when unwinding a zapped file descriptor.
1927 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1928 in case Emacs runs out of memory between the two unwind-protects.
1929 Don't trash errno when closing FD.
1930 Zap the FD in the specpdl when closing it, instead of deferring
1931 the removal of the unwind-protect; this fixes a bug where a child
1932 function unwinds the stack past us.
1933
27e498e6
PE
1934 New unwind-protect flavors to better type-check C callbacks.
1935 This also lessens the need to write wrappers for callbacks,
1936 and the need for make_save_pointer.
1937 * alloca.c (free_save_value):
1938 * atimer.c (run_all_atimers):
1939 Now extern.
1940 * alloc.c (safe_alloca_unwind):
1941 * atimer.c (unwind_stop_other_atimers):
1942 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1943 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1944 * minibuf.c (choose_minibuf_frame_1):
1945 * process.c (make_serial_process_unwind):
1946 * xdisp.h (pop_message_unwind):
1947 * xselect.c (queue_selection_requests_unwind):
1948 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1949 * alloca.c (record_xmalloc):
1950 Prefer record_unwind_protect_ptr to record_unwind_protect with
1951 make_save_pointer.
1952 * alloca.c (Fgarbage_collect):
1953 Prefer record_unwind_protect_void to passing a dummy.
1954 * buffer.c (restore_buffer):
1955 * window.c (restore_window_configuration):
1956 * xfns.c, w32fns.c (do_unwind_create_frame)
1957 New wrapper. All record-unwind uses of wrappee changed.
1958 * buffer.c (set_buffer_if_live):
1959 * callproc.c (call_process_cleanup, delete_temp_file):
1960 * coding.c (code_conversion_restore):
1961 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1962 * editfns.c (save_excursion_restore)
1963 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1964 (save_restriction_restore):
1965 * eval.c (restore_stack_limits, un_autoload):
1966 * fns.c (require_unwind):
1967 * keyboard.c (recursive_edit_unwind, tracking_off):
1968 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1969 * macros.c (pop_kbd_macro, restore_menu_items):
1970 * nsfns.m (unwind_create_frame):
1971 * print.c (print_unwind):
1972 * process.c (start_process_unwind):
1973 * search.c (unwind_set_match_data):
1974 * window.c (select_window_norecord, select_frame_norecord):
1975 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1976 (fast_set_selected_frame):
1977 * xfns.c, w32fns.c (unwind_create_tip_frame):
1978 Return void, not a dummy Lisp_Object. All uses changed.
1979 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1980 * callproc.c (call_process_kill):
1981 * fileio.c (restore_point_unwind, decide_coding_unwind)
1982 (build_annotations_unwind):
1983 * insdel.c (Fcombine_after_change_execute_1):
1984 * keyboard.c (read_char_help_form_unwind):
1985 * menu.c (unuse_menu_items):
1986 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1987 * sound.c (sound_cleanup):
1988 * xdisp.c (unwind_redisplay):
1989 * xfns.c (clean_up_dialog):
1990 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1991 Accept no args and return void, instead of accepting and returning
1992 a dummy Lisp_Object. All uses changed.
1993 * cygw32.c (fchdir_unwind):
1994 * fileio.c (close_file_unwind):
1995 * keyboard.c (restore_kboard_configuration):
1996 * lread.c (readevalllop_1):
1997 * process.c (wait_reading_process_output_unwind):
1998 Accept int and return void, rather than accepting an Emacs integer
1999 and returning a dummy object. In some cases this fixes an
2000 unlikely bug when the corresponding int is outside Emacs integer
2001 range. All uses changed.
2002 * dired.c (directory_files_internal_unwind):
2003 * fileio.c (do_auto_save_unwind):
2004 * gtkutil.c (pop_down_dialog):
2005 * insdel.c (reset_var_on_error):
2006 * lread.c (load_unwind):
2007 * xfns.c (clean_up_file_dialog):
2008 * xmenu.c, nsmenu.m (pop_down_menu):
2009 * xmenu.c (cleanup_widget_value_tree):
2010 * xselect.c (wait_for_property_change_unwind):
2011 Accept pointer and return void, rather than accepting an Emacs
2012 save value encapsulating the pointer and returning a dummy object.
2013 All uses changed.
2014 * editfns.c (Fformat): Update the saved pointer directly via
2015 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2016 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2017 (unwind_body): New function.
2018 (record_unwind_protect): First arg is now a function returning void,
2019 not a dummy Lisp_Object.
2020 (record_unwind_protect_ptr, record_unwind_protect_int)
2021 (record_unwind_protect_void): New functions.
2022 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2023 * fileio.c (struct auto_save_unwind): New type.
2024 (do_auto_save_unwind): Use it.
2025 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2026 * insdel.c (struct rvoe_arg): New type.
2027 (reset_var_on_error): Use it.
2028 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2029 New constants.
2030 (specbinding_func): Remove; there are now several such functions.
2031 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2032 (set_unwind_protect_ptr): New function.
2033 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2034
4e604a5d
PE
2035 Be simpler and more consistent about reporting I/O errors.
2036 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2037 Say "Read error" and "Write error", rather than "I/O error", or
2038 "IO error reading", or "IO error writing", when a read or write
2039 error occurs.
2040 * process.c (Fmake_network_process, wait_reading_process_output)
2041 (send_process, Fprocess_send_eof, wait_reading_process_output):
2042 Capitalize diagnostics consistently. Put "failed foo" at the
2043 start of the diagnostic, so that we don't capitalize the
2044 function name "foo". Consistently say "failed" for such
2045 diagnostics.
2046 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2047 All callers changed. This is so it can use report_file_error.
2048 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2049 diagnostics consistently as above.
2050
a9757f6a
PE
2051 * fileio.c (report_file_errno): Fix errno reporting bug.
2052 If the file name is neither null nor a pair, package it up as a
2053 singleton list. All callers changed, both to this function and to
2054 report_file_error. This fixes a bug where the memory allocator
2055 invoked by list1 set errno so that the immediately following
2056 report_file_error reported the wrong errno value.
2057
c43843aa
PE
2058 Fix minor problems found by --enable-gcc-warnings.
2059 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2060 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2061
18c26d81
JD
20622013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2063
2064 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2065 Set event->arg to Qt if switch-event shall be generated.
2066 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2067
2068 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2069
2070 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2071 FOCUS_OUT_EVENT.
2072
2073 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2074 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2075 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2076 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2077 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2078 and there is a focused frame.
2079 (head_table): Add focus-in and focus-out.
2080 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2081 bind to handle-focus-in/out.
2082
2083 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2084 (Fhandle_switch_frame): Call Fhandle_focus_in.
2085 (syms_of_frame): defsubr handle-focus-in/out.
2086
6c6f1994
PE
20872013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2088
c7ddc792
PE
2089 Fix porting bug to older POSIXish platforms (Bug#14862).
2090 * sysdep.c (emacs_pipe): New function, that implements
2091 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2092 This should port better to CentOS 5 and to Mac OS X 10.6.
2093 All calls to pipe2 changed.
2094
6c6f1994
PE
2095 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2096 This makes the code easier to read and the executable a bit smaller.
2097 Do not replace all calls to Fcons that happen to create lists,
2098 just calls that are intended to create lists. For example, when
2099 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2100 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2101 Similarly for list2 through list5.
2102 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2103 * bytecode.c (exec_byte_code):
2104 * callint.c (quotify_arg, Fcall_interactively):
2105 * callproc.c (Fcall_process, create_temp_file):
2106 * charset.c (load_charset_map_from_file)
2107 (Fdefine_charset_internal, init_charset):
2108 * coding.c (get_translation_table, detect_coding_system)
2109 (Fcheck_coding_systems_region)
2110 (Fset_terminal_coding_system_internal)
2111 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2112 * composite.c (update_compositions, Ffind_composition_internal):
2113 * dired.c (directory_files_internal, file_name_completion)
2114 (Fsystem_users):
2115 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2116 * doc.c (Fsnarf_documentation):
2117 * editfns.c (Fmessage_box):
2118 * emacs.c (main):
2119 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2120 (Feval, eval_sub, Ffuncall, apply_lambda):
2121 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2122 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2123 (Fset_file_times, Finsert_file_contents)
2124 (Fchoose_write_coding_system, Fwrite_region):
2125 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2126 * font.c (font_registry_charsets, font_parse_fcname)
2127 (font_prepare_cache, font_update_drivers, Flist_fonts):
2128 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2129 * frame.c (make_frame, Fmake_terminal_frame)
2130 (x_set_frame_parameters, x_report_frame_params)
2131 (x_default_parameter, Fx_parse_geometry):
2132 * ftfont.c (syms_of_ftfont):
2133 * image.c (gif_load):
2134 * keyboard.c (command_loop_1):
2135 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2136 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2137 (Fminor_mode_key_binding, accessible_keymaps_1)
2138 (Faccessible_keymaps, Fwhere_is_internal):
2139 * lread.c (read_emacs_mule_char):
2140 * menu.c (find_and_return_menu_selection):
2141 * minibuf.c (get_minibuffer):
2142 * nsfns.m (Fns_perform_service):
2143 * nsfont.m (ns_script_to_charset):
2144 * nsmenu.m (ns_popup_dialog):
2145 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2146 (Fx_own_selection_internal):
2147 * nsterm.m (append2):
2148 * print.c (Fredirect_debugging_output)
2149 (print_prune_string_charset):
2150 * process.c (Fdelete_process, Fprocess_contact)
2151 (Fformat_network_address, set_socket_option)
2152 (read_and_dispose_of_process_output, write_queue_push)
2153 (send_process, exec_sentinel):
2154 * sound.c (Fplay_sound_internal):
2155 * textprop.c (validate_plist, add_properties)
2156 (Fput_text_property, Fadd_face_text_property)
2157 (copy_text_properties, text_property_list, syms_of_textprop):
2158 * unexaix.c (report_error):
2159 * unexcoff.c (report_error):
2160 * unexsol.c (unexec):
2161 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2162 (Fformat_mode_line, syms_of_xdisp):
2163 * xfaces.c (set_font_frame_param)
2164 (Finternal_lisp_face_attribute_values)
2165 (Finternal_merge_in_global_face, syms_of_xfaces):
2166 * xfns.c (x_default_scroll_bar_color_parameter)
2167 (x_default_font_parameter, x_create_tip_frame):
2168 * xfont.c (xfont_supported_scripts):
2169 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2170 (menu_help_callback, xmenu_show):
2171 * xml.c (make_dom):
2172 * xterm.c (set_wm_state):
2173 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2174 and similarly for list2 through list5.
2175
bafe80ce
PE
21762013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 * callproc.c (Fcall_process_region): Fix minor race and tune.
2179 (create_temp_file): New function, with the temp-file-creation part
2180 of the old Fcall_process_region. Use Fcopy_sequence to create the
2181 temp file name, rather than alloca + build_string, for simplicity.
2182 Don't bother to block input around the temp file creation;
068f9124
SM
2183 shouldn't be needed. Simplify use of mktemp.
2184 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2185 this closes an unlikely race where the temp file was not removed.
2186 Use memcpy rather than an open-coded loop.
2187 (Fcall_process_region): Use the new function. If the input is
2188 empty, redirect from /dev/null rather than from a newly created
2189 empty temp file; this avoids unnecessary file system traffic.
2190
4700b5a5
PE
21912013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2192
5c97beae
PE
2193 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2194 Simplify by making this case like the other two. This is a bit
2195 slower on obsolete hosts, but the extra complexity isn't worth it.
2196
4700b5a5
PE
2197 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2198 * process.c (create_process) [!DOS_NT]:
2199 Remove now-unnecessary calls to emacs_close.
2200
f9a74c4c
EZ
22012013-07-13 Eli Zaretskii <eliz@gnu.org>
2202
922ae7ee
EZ
2203 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2204 returning early. (Bug#14850)
2205
f9a74c4c
EZ
2206 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2207 and inhibit-iso-escape-detection attributes of 'undecided'.
2208 (Bug#14822)
2209
5e301d76
PE
22102013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2211
69e0e5ee
PE
2212 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2213 Reported by Herbert J. Skuhra in
2214 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2215
5e301d76
PE
2216 Don't lose top specpdl entry when memory is exhausted.
2217 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2218 specpdl overflow here, to simplify callers; all callers changed.
2219 Always reserve an unused entry at the stack top; this avoids
2220 losing the top entry's information when memory is exhausted.
2221
7e649856
PE
22222013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2223
a773ed9a
PE
2224 Clean up errno reporting and fix some errno-reporting bugs.
2225 * callproc.c (Fcall_process):
2226 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2227 * process.c (create_process, Fmake_network_process):
2228 * unexaix.c (report_error):
2229 * unexcoff.c (report_error):
2230 Be more careful about reporting the errno of failed operations.
2231 The code previously reported the wrong errno sometimes.
2232 Also, prefer report_file_errno to setting errno + report_file_error.
2233 (Fcall_process): Look at openp return value rather than at path,
2234 as that's a bit faster and clearer when there's a numeric predicate.
2235 * fileio.c (report_file_errno): New function, with most of the
2236 old contents of report_file_error.
2237 (report_file_error): Use it.
2238 (Ffile_exists_p, Ffile_accessible_directory_p):
2239 Set errno to 0 when it is junk.
2240 * fileio.c (Faccess_file):
2241 * image.c (x_create_bitmap_from_file):
2242 Use faccessat rather than opening the file, to avoid the hassle of
2243 having a file descriptor open.
2244 * lisp.h (report_file_errno): New decl.
2245 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2246
7e649856
PE
2247 Minor EBADF fixes.
2248 * process.c (create_process, wait_reading_process_output) [AIX]:
2249 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2250 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2251 a multithreaded environment anyway).
2252 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2253
f6774c1a
AS
22542013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2255
2256 * image.c (x_find_image_file): Don't close a remote file handle.
2257
bacba3c2
PE
22582013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 Fix races with threads and file descriptors.
2261 * callproc.c (Fcall_process_region):
2262 * dired.c (open_directory):
2263 * emacs.c (main, Fdaemon_initialized):
2264 * image.c (x_find_image_file):
2265 * inotify.c (Finotify_rm_watch):
2266 * lread.c (Flocate_file_internal):
2267 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2268 * term.c (term_mouse_moveto, init_tty):
2269 * termcap.c (tgetent):
2270 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2271 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2272 * unexhp9k800.c, unexmacosx.c (unexec):
2273 * callproc.c (Fcall_process_region):
2274 Use emacs_close, not close.
2275 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2276 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2277 and posix_close function on current platforms (which all lack them).
2278 (emacs_close): Use it. This should fix the races on GNU/Linux and
2279 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2280 and it should avoid closing random victim file descriptors on
2281 other platforms.
2282
653d4f43
PE
22832013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2284
c8536ec4
PE
2285 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2286 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2287 Touch up doc a bit.
2288
9c203066
PE
2289 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2290 This is for .gdbinit xbacktrace.
2291
653d4f43
PE
2292 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2293 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2294 (emacs_set_tty): Now static.
2295 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2296 * term.c (tty_capable_p, tty_default_color_capabilities)
2297 (get_tty_terminal, term_mouse_movement)
2298 (handle_one_term_event, init_tty, maybe_fatal):
2299 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2300 (tgetent, scan_file, name_match, compare_contin):
2301 * terminal.c (get_terminal):
2302 Use bool for boolean.
2303 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2304 Prefer char to unsigned char if either will do.
2305 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2306 (tty_write_glyphs): Prefer int to unsigned.
2307 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2308 All callers changed.
2309 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2310
45b683a1
PE
23112013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2312
29abe551
PE
2313 Port to C89.
2314 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2315 (B__dummy__): New dummy symbol, to pacify C89.
2316 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2317 they can't grok varargs macros.
2318 * dispnew.c (add_window_display_history)
2319 (add_frame_display_history):
2320 * print.c (print_object):
2321 * xdisp.c (debug_method_add):
2322 Use %p printf format only for void pointers.
2323 * emacs.c (usage_message): New constant, replacing ...
2324 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2325 (main): Adjust to usage reorg.
2326 * fns.c (syms_of_fns):
2327 * profiler.c (syms_of_profiler):
2328 Don't use non-constant struct initializers.
2329 * gnutls.h (gnutls_initstage_t):
2330 * lisp.h (enum Lisp_Fwd_Type):
2331 * lread.c (lisp_file_lexically_bound_p):
2332 * xsettings.c (anonymous enum):
2333 Remove trailing comma.
2334 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2335 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2336 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2337 (DEFUN): Use it.
2338 * regex.c (const_re_char): New type, to pacify strict C89.
2339 All uses of 'const re_char' replaced to use it.
2340 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2341 with glibc when strict C89. This change is imported from gnulib.
2342 All uses changed.
2343 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2344 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2345 Omit GNU_LINUX implementation, since it requires long long.
2346 * xterm.c (x_draw_underwave):
2347 Do not assume the traditional order of struct's members.
2348 (x_term_init): Rewrite to avoid the need for non-constant structure
2349 initializers.
2350
45b683a1 2351 Syntax cleanup, mostly replacing macros with functions.
763a086d 2352 This removes the need for the syntax_temp hack.
45b683a1
PE
2353 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2354 * syntax.c (SYNTAX_INLINE): New macro.
2355 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2356 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2357 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2358 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2359 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2360 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2361 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2362 Now constants, not macros.
2363 (syntax_temp) [!__GNUC__]: Remove.
2364 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2365 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2366 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2367 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2368 Move here from syntax.h; now functions, not macros. Except for the
2369 last function, these are static since only syntax.c uses them.
2370 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2371 All uses changed. Now a function, not a macro; use this fact
2372 to simplify the code.
2373 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2374 compiler bugs; no longer relevant.
2375 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2376 (SYNTAX_INLINE): New macro.
2377 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2378 for the new functions. Use bool for boolean member.
2379 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2380 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2381 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2382 (SETUP_BUFFER_SYNTAX_TABLE):
2383 Now extern inline functions, not macros.
2384 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2385 Remove; all uses replaced by implementation.
2386 (syntax_temp) [!__GNUC__]: Remove decl.
2387 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2388
29be4a50
JD
23892013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2390
2391 * emacs.c (main): Fix syntax error.
2392
954b166e
PE
23932013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 Timestamp fixes for undo (Bug#14824).
2396 * atimer.c (schedule_atimer):
2397 * fileio.c (Ffile_newer_than_file_p):
2398 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2399 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2400 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2401 (syms_of_fileio): Remove Sclear_visited_file_name.
2402 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2403 file doesn't exist; this avoids an ambiguity with negative timestamps.
2404 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2405 * systime.h (make_emacs_time, invalid_emacs_time):
2406 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2407 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2408 * undo.c (record_first_change): Push (visited-file-modtime) onto
2409 undo list rather than reimplementing it by hand, incorrectly.
2410
d74647c3
KB
24112013-07-09 Ken Brown <kbrown@cornell.edu>
2412
2413 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2414
3c51b96b
JB
24152013-07-09 Juanma Barranquero <lekktu@gmail.com>
2416
2417 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2418
4ebbdd67
PE
24192013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 Handle errno and exit status a bit more carefully.
2422 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2423 number into an exit status. Instead, use EXIT_CANCELED.
2424 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2425 * callproc.c (relocate_fd):
2426 * emacs.c (close_output_streams, main):
2427 * process.c (create_process):
2428 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2429 Use emacs_perror for simplicity.
2430 * callproc.c (relocate_fd, main):
2431 * sysdep.c (sys_subshell):
2432 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2433 (shut_down_emacs): Use emacs_write, not write.
2434 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2435 * fileio.c (Fcopy_file, e_write):
2436 * nsterm.m (ns_select):
2437 * process.c (send_process):
2438 * sound.c (vox_write):
2439 Use emacs_write_sig, not emacs_write.
2440 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2441 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2442 New constants.
2443 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2444 of write.
2445 (emacs_full_write): New function.
2446 (emacs_write): Rewrite to use it.
2447 (emacswrite_sig, emacs_perror): New functions.
2448 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2449
44e18199 24502013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2451
2452 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2453 on NS even if it is present. Pixmap on NS is a void*.
2454
9caab067
PE
24552013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 Port to Ubuntu 10 (Bug#14803).
2458 Problem reported by T.V. Raman.
2459 * process.c (close_on_exec, accept4, process_socket):
2460 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2461
1d442672
EZ
24622013-07-07 Eli Zaretskii <eliz@gnu.org>
2463
2464 * w32.c (sys_dup): Declare prototype.
2465
2466 * filelock.c:
2467 * emacs.c:
2468 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2469
067428c1
PE
24702013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 Make file descriptors close-on-exec when possible (Bug#14803).
2473 This simplifies Emacs a bit, since it no longer needs to worry
2474 about closing file descriptors by hand in some cases.
2475 It also fixes some unlikely races. Not all such races, as
2476 libraries often open files internally without setting
2477 close-on-exec, but it's an improvement.
2478 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2479 * callproc.c (Fcall_process) [!MSDOS]:
2480 * emacs.c (main) [!DOS_NT]:
2481 * nsterm.m (ns_term_init):
2482 * process.c (create_process):
2483 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2484 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2485 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2486 Prefer mkostemp with O_CLOEXEC to mkstemp.
2487 * callproc.c (relocate_fd) [!WINDOWSNT]:
2488 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2489 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2490 now using pipe2.
2491 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2492 Make the resulting file descriptor close-on-exec.
2493 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2494 * lread.c (load_descriptor_list, load_descriptor_unwind):
2495 Remove; no longer needed. All uses removed.
2496 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2497 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2498 New functions.
2499 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2500 (Fmake_network_process, Fnetwork_interface_list):
2501 (Fnetwork_interface_info, server_accept_connection):
2502 Make newly-created socket close-on-exec.
2503 * sysdep.c (emacs_open, emacs_fopen):
2504 Make new-created descriptor close-on-exec.
2505 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2506 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2507
0da857dd
JD
25082013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2509
2510 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2511 for NS_IMPL_GNUSTEP.
2512
5f86adcd
PE
25132013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2514
2515 Fix openp errno handling.
2516 * callproc.c (Fcall_process): Preserve openp errno around close.
2517 * lread.c (openp): Set errno when returning -1, as some callers
2518 expect this.
2519
1afb1d07
JD
25202013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2521
2522 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2523
2524 * nsterm.h (NSSavePanel): Update comment.
2525 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2526 (ns_run_file_dialog): Declare.
2527
2528 * nsfns.m: Remove panelOK.
2529 (ns_fd_data): New.
2530 (ns_run_file_dialog): New function.
2531 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2532 event loop, so file dialog is popped up by ns_run_file_dialog, called
2533 by sendEvent (Bug#14578).
2534 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2535
3323c263
EZ
25362013-07-06 Eli Zaretskii <eliz@gnu.org>
2537
fdda0220
EZ
2538 * xdisp.c (default_line_pixel_height): New function.
2539 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2540 (try_cursor_movement, redisplay_window, try_window)
2541 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2542
068f9124
SM
2543 * window.c (window_scroll_pixel_based):
2544 use default_line_pixel_height.
fdda0220
EZ
2545
2546 * dispextern.h (default_line_pixel_height): Add prototype.
2547
2548 * frame.c (x_set_line_spacing): Accept a float value for
2549 line-spacing parameter, per the documentation.
2550
3323c263
EZ
2551 * data.c (Fmultibyte_string_p): Doc fix.
2552
47ba6d43
PE
25532013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2554
406af475
PE
2555 Use emacs_open more consistently when opening files.
2556 This handles EINTR more consistently now, and makes it easier
2557 to introduce other uniform changes to file descriptor handling.
2558 * src/systdio.h: New file.
2559 * src/buffer.c (mmap_init):
2560 * cygw32.c (chdir_to_default_directory):
2561 * dispnew.c (Fopen_termscript):
2562 * emacs.c (Fdaemon_initialized):
2563 * fileio.c (Fdo_auto_save):
2564 * image.c (slurp_file, png_load_body, jpeg_load_body):
2565 * keyboard.c (Fopen_dribble_file):
2566 * lread.c (Fload):
2567 * print.c (Fredirect_debugging_output):
2568 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2569 * termcap.c (tgetent):
2570 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2571 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2572 * w32term.c (w32_initialize) [CYGWIN]:
2573 * xfaces.c (Fx_load_color_file):
2574 Use emacs_open instead of plain open, and emacs_fopen instead of
2575 plain fopen.
2576 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2577 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2578 * callproc.c (default_output_mode): New constant.
2579 (Fcall_process): Use it to call emacs_open instead of plain creat.
2580 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2581 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2582 (emacs_fopen): New function.
2583 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2584 Include <lisp.h>, for emacs_open.
2585 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2586
47ba6d43
PE
2587 Remove duplicate #include directives.
2588 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2589 * xfaces.c:
2590 Don't include stdio.h twice.
2591 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2592 Don't include sys/types.h or stdio.h twice.
2593 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2594 * lread.c: Don't include coding.h twice.
2595 * nsfont.m: Don't include frame.h twice.
2596 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2597 * ralloc.c: Don't include <unistd.h> twice.
2598 * xdisp.c: Don't include font.h twice.
2599 * xterm.c: Don't include fontset.h twice.
2600 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2601
b9ed53d5
PE
26022013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2603
2604 Scale ImageMagick images more carefully.
2605 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2606 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2607 Be more careful about avoiding undefined behavior after
2608 integer overflow and division by zero.
2609
cf13177e
YM
26102013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2611
2612 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2613 (syms_of_w32fns): DEFSYM them.
2614 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2615 (CCHDEVICENAME): Define macros if not defined.
2616 (struct MONITOR_INFO_EX): New struct.
2617 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2618 (enum_display_monitors_fn): New variable.
2619 (globals_of_w32fns): Initialize it.
2620 (Fx_display_pixel_width, Fx_display_pixel_height)
2621 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2622 multi-monitor setups in docstrings.
2623 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2624 screen size by primary monitor's millimeter per pixel.
2625 (w32_monitor_enum, w32_display_monitor_attributes_list)
2626 (w32_display_monitor_attributes_list_fallback)
2627 (Fw32_display_monitor_attributes_list): New functions.
2628 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2629
2630 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2631 if not defined.
2632 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2633
86dfb7a8
MA
26342013-07-04 Michael Albinus <michael.albinus@gmx.de>
2635
2636 * fileio.c (Qfile_notify_error): New error symbol.
2637
2638 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2639 * inotify.c (inotify_callback, symbol_to_inotifymask)
2640 (Finotify_add_watch, Finotify_rm_watch): Use it.
2641 (inotifyevent_to_event): Exchange order of cookie and file name.
2642 (Finotify_add_watch): Adapt docstring.
2643
2644 * lisp.h (Qfile_notify_error): Declare.
2645
2c1c974b
PE
26462013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2647
2648 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2649 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2650 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2651 which did not work (see <http://bugs.gnu.org/14569#307>).
2652 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2653 && (!noninteractive || initialized)). This attempts to thread
2654 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2655
7a35b20f
JB
26562013-07-04 Juanma Barranquero <lekktu@gmail.com>
2657
2658 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2659 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2660
1ce5cd04
PE
26612013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2664 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2665 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2666 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2667
57f8c490
PE
26682013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2671 Define to __sys_siglist.
2672
bcffb5ca
EZ
26732013-07-02 Eli Zaretskii <eliz@gnu.org>
2674
2675 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2676 word-wrap, so that overflow-newline-into-fringe would work in
2677 visual-line-mode. (Bug#2749)
2678 (move_it_in_display_line_to): When the last scanned display
2679 element fits exactly on the display line, and
2680 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2681 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2682 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2683 finding buffer position that corresponds to pixel coordinates,
2684 e.g. in buffer_posn_from_coords.
2685
2c41e781
JD
26862013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2687
2688 * process.c (handle_child_signal): Call catch_child_signal if
2689 NS_IMPL_GNUSTEP.
2690
c2418359
PE
26912013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2692
52a9bcae
PE
2693 Don't convert function pointers to void * and back.
2694 It isn't portable C, and it's easy enough to avoid.
2695 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2696 (make_save_value): Add support for SAVE_FUNCPOINTER.
2697 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2698 * print.c (print_object):
2699 Distinguish function from object pointers.
2700 * lisp.h (SAVE_FUNCPOINTER): New constant.
2701 (SAVE_SLOT_BITS): Adjust to it.
2702 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2703 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2704 (voidfuncptr): New typedef.
2705 (struct Lisp_Save_Value): New member data[0].funcpointer.
2706 (XSAVE_FUNCPOINTER): New function.
2707
c2418359
PE
2708 Simplify buildobj processing.
2709 * Makefile.in (buildobj.h): Make it a sequence of strings each
2710 followed by comma, rather than a single string. Put it into a
2711 .tmp file in case there's an error while generating it.
2712 (gl-stamp): Use .tmp for temp files.
2713 (mostlyclean): Clean .tmp files.
2714 * doc.c (buildobj): Move to just the routine that needs it.
2715 It's now an array of strings, so processing is simpler.
2716
8f43ce49
PE
27172013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2718
2719 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2720 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2721 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2722 Invoke malloc_enable_thread even when not interactive.
2723 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2724 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2725 in this case, since the underlying bug has now been fixed.
2726
24827db9
JB
27272013-07-01 Juanma Barranquero <lekktu@gmail.com>
2728
2729 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2730 unlinking it (bug#14691).
2731
ef099a94
MN
27322013-06-30 Michal Nazarewicz <mina86@mina86.com>
2733
2734 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2735 before checking whether buffer is modified. This lets
2736 `kill-buffer-query-functions' cancel killing of the buffer or save
2737 its content before `kill-buffer' asks user the "Buffer %s
2738 modified; kill anyway?" question.
2739
9d3f2fc2
JD
27402013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2741
2742 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2743 Let the super performKeyEquivalent deal with them (Bug#14747).
2744
e6c6c8c7
PE
27452013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2746
1d71c1d9
PE
2747 * widget.c (resize_cb): Remove unused local.
2748
8f5f35cc
PE
2749 Do not use GTK 3 if it exists but cannot be compiled.
2750 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2751 * xterm.c (x_error_handler) [!USE_GTK]:
2752 Do not use GTK 3.
2753
e6c6c8c7
PE
2754 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2755
0ba54312
EZ
27562013-06-30 Eli Zaretskii <eliz@gnu.org>
2757
5d1c3286
EZ
2758 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2759 to the valid range of values. (Bug#14753)
2760
0ba54312
EZ
2761 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2762 when moving point by using the current glyph matrix. This avoids
2763 the need to force redisplay when this function is called in a
2764 loop.
2765
9c90cc06
PE
27662013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 Fix minor problems found by static checking.
2769 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2770 Redo the latter's body to sidestep GCC parenthesization warnings.
2771 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2772 * coding.c (detect_coding, detect_coding_system):
2773 * coding.h (struct undecided_spec):
2774 Use bool for boolean.
2775 * image.c (QCmax_width, QCmax_height): Now static.
2776 * xdisp.c (Fmove_point_visually): Remove unused local.
2777
4c672a0f
EZ
27782013-06-29 Eli Zaretskii <eliz@gnu.org>
2779
2780 * xdisp.c (Fmove_point_visually): New function.
2781
c1ea3abf
JB
27822013-06-28 Kenichi Handa <handa@gnu.org>
2783
2784 * coding.h (define_coding_undecided_arg_index): New enum.
2785 (coding_attr_index): New members
2786 coding_attr_undecided_inhibit_null_byte_detection,
2787 coding_attr_undecided_inhibit_iso_escape_detection,
2788 coding_attr_undecided_prefer_utf_8.
2789 (undecided_spec): New struct.
2790 (struct coding_system): New member `undecided' of the member
2791 `spec'.
2792
2793 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2794 (detect_coding): Likewise.
2795 (detect_coding_system): Likewise.
2796 (Fdefine_coding_system_internal): New coding system properties
2797 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2798 :prefer-utf-8.
2799 (syms_of_coding): Adjust for coding_arg_undecided_max.
2800
ba3de9e6
PE
28012013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 * image.c (x_from_xcolors): Remove unused local.
2804
547c9269
YM
28052013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2806
2807 Defer image data transfer between X client and server until actual
2808 display happens.
2809
2810 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2811 and `mask_img'.
2812
2813 * image.c (Destroy_Image): Remove.
2814 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2815 `mask_p', and `colors_p'. All uses changed.
2816 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2817 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2818 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2819 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2820 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2821 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2822 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2823 (image_get_x_image, image_unget_x_image): New functions or macros.
2824 (image_background, image_background_transparent, x_to_xcolors)
2825 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2826 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2827 instead of Destroy_Image.
2828 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2829 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2830 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2831 (imagemagick_load_image, svg_load_image): Use them instead of
2832 x_create_x_image_and_pixmap, and x_put_x_image followed by
2833 x_destroy_x_image, respectively.
2834 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2835 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2836 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2837 background_transparent fields.
2838 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2839 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2840
dae2f5ef
PE
28412013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2844 This mostly consists of undoing recent changes.
2845 * callproc.c (Fcall_process):
2846 * process.c (create_process):
2847 Do not worry about catching SIGCHLD here, undoing previous change.
2848 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2849 * process.c, process.h (catch_child_signal):
2850 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2851 * process.c (catch_child_handler): Don't worry about being called
2852 lazily and do not assume caller has blocked SIGCHLD, undoing
2853 previous change. Move first-time stuff back to
2854 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2855 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2856 set lib_child_handler if it's already initialized, which may
2857 help avoid problems on GNUStep.
2858
fa55d2aa
PE
28592013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2862 * callproc.c (Fcall_process):
2863 * process.c (create_process):
2864 Make sure SIGCHLD is caught before we fork,
2865 since Emacs startup no arranges to catch SIGCHLD.
2866 * process.c (lib_child_handler): Initialize to null, not to
2867 dummy_handler.
2868 (catch_child_signal): Allow self to be called lazily.
2869 Do nothing if it's already been called.
2870 Assume caller has blocked SIGCHLD (all callers do now).
2871 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2872 just before it's really needed.
2873 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2874 since it hasn't been caught yet.
2875
f3f9606c
LMI
28762013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2877
2878 * image.c (compute_image_size): New function to implement
2879 :max-width and :max-height.
2880 (imagemagick_load_image): Use it.
2881
c7041908
PE
28822013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2883
2884 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2885 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2886 Now extern.
2887 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2888 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2889 the SIGCHLD handler, since the code is not atomic and (due to glib)
2890 signals may be arriving now.
2891 * sysdep.c (init_signals): Do not catch child signals here;
2892 'main' now does that later, at a safer time.
2893
f86852b4
PE
28942013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2895
0dfeed58
PE
2896 Clean up SIGCHLD handling a bit (Bug#14569).
2897 * process.c, process.h (catch_child_signal):
2898 Now always extern, even if !NS_IMPL_GNUSTEP.
2899 * process.c (catch_child_signal): Move glib tickler here from
2900 init_process_emacs, so that it's done earlier in Emacs
2901 initialization. Also move the noninteractive && !initialized
2902 check here from init_process_emacs. This is all a bit cleaner for
2903 GNUish platforms, and I hope it works around the Cygwin bug.
2904 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2905 that glib signal handling is tickled before glib creates threads.
2906
f86852b4
PE
2907 * process.c (wait_reading_process_output): Avoid int overflow
2908 when reading more than 2 GiB total from a process.
2909
cbd6509c
PE
29102013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 * process.c (create_process): Handle a couple more cases,
2913 i.e., work even if new_argv and wait_child_setup[i] are cached.
2914 Use Fcall_process's style for volatile vars.
2915
9de1114a
AS
29162013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2917
2918 * process.c (create_process): Mark PROCESS volatile.
2919
fbe9e0b9
PE
29202013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2921
2922 Use C99-style flexible array members if available.
2923 This avoids some subtle aliasing issues, which typically
2924 aren't a problem with GCC but may be a problem elsewhere.
2925 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2926 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2927 In either case, it uses a flexible array member rather than
2928 the old struct hack. All uses changed.
2929 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2930 Adjust to sdata reorganization.
2931 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2932 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2933 that ports better to pre-C99 non-GCC.
2934 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2935 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2936 as the latter has changed.
2937 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2938 and port better to pre-C99 GCC.
2939 * image.c (struct xpm_cached_color):
2940 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2941 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2942 Use FLEXIBLE_ARRAY_MEMBER.
2943 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2944 Move decl to top level so it gets checked against implementation.
2945 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2946 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2947
1fc71008
PE
29482013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 * syntax.c: Integer cleanups.
2951 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2952 All uses that need 0-or-2 changed to:
2953 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2954 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2955 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2956 (char_quoted, prev_char_comend_first, back_comment)
2957 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2958 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2959 Use bool for boolean.
2960 (update_syntax_table, skip_chars, skip_syntaxes):
2961 Prefer int to unsigned when either will do.
2962 (back_comment): Return boolean success flag, like forw_comment,
2963 instead of positive-or-minus-1 (which might have overflowed int anyway).
2964 Don't stuff ptrdiff_t into int.
2965 (syntax_spec_code, syntax_code_spec): Now const.
2966 (Fmatching_paren, scan_lists, scan_sexps_forward):
2967 Use enum syntaxcode for syntax code.
2968 (Fmatching_paren): Check that arg is a character, not just an integer.
2969 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2970 (Finternal_describe_syntax_value): Omit no-longer-needed
2971 comparison to 0.
2972 (skip_chars): Use char, not unsigned char, when the distinction
2973 doesn't matter.
2974 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2975 * bytecode.c (exec_byte_code):
2976 * syntax.c (syntax_spec_code, Fchar_syntax)
2977 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2978 (init_syntax_once):
2979 * syntax.h (SYNTAX_WITH_FLAGS):
2980 Omit unnecessary casts.
2981
b932cad7
EZ
29822013-06-20 Eli Zaretskii <eliz@gnu.org>
2983
2984 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2985 line dimensions here, to avoid race conditions with the main
2986 thread. (Bug#14062, bug#14630, bug#14669)
2987
2988 * w32term.c (w32_draw_window_cursor): Compute the header line and
2989 mode line dimensions here.
2990 <w32_system_caret_window, w32_system_caret_hdr_height>:
2991 <w32_system_caret_mode_height>: New variables.
2992
2993 * w32term.h: Declare them.
2994
89561f72
PE
29952013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2996
5013fc08
PE
2997 * alloc.c (die): Move "assertion failed" string here ...
2998 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2999 COND when SUPPRESS_CHECKING. This shrinks the executable text
3000 size by 0.8% to 2.2% when configured with --enable-checking,
3001 depending on optimization flags (GCC 4.8.1 x86-64).
3002
89561f72
PE
3003 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3004
763a086d 30052013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3006
3007 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3008 base is 2; this is more accurate.
3009
983aeb9a
JB
30102013-06-19 Juanma Barranquero <lekktu@gmail.com>
3011
3012 * sound.c (string_default): Move to !WINDOWSNT section.
3013 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3014
178ba3e6
PE
30152013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3016
bbc51b15
PE
3017 * sound.c: Integer cleanups.
3018 Remove unnecessary forward decls.
3019 (struct sound_device): The 'file' member is now a Lisp_Object, not
3020 a char *, so that we needn't invoke alloca on a huge size.
3021 (Fplay_sound_internal): Adjust to this.
3022 (string_default): New function.
3023 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3024 Use it to adjust to the struct sound_device change.
3025 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3026 (be2hs) [0]: Remove.
3027
178ba3e6
PE
3028 * syntax.c (skip_chars): Don't use uninitialized storage
3029 when searching a multibyte buffer for characters that are not in a
3030 unibyte string that contains non-ASCII characters.
3031
69f60cdc
JD
30322013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3033
3034 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3035 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3036
0d6224d4
PE
30372013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3040
3c542890
KH
30412013-06-18 Kenichi Handa <handa@gnu.org>
3042
f7e3f7cd
KH
3043 * font.c (Ffont_spec): Signal an error for an invalid font name
3044 (Bug#14648).
3c542890 3045
9349e5f7
PE
30462013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3047
3048 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3049 In particular this ports to 32-bit sparc Sun cc.
3050 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3051 array with a dummy element at specpdl[-1], so that its address can
3052 be taken portably.
3053 (unbind_to): Do not copy the binding; not needed, now that we
3054 copy old_value in the one place where the copy is needed.
3055 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3056 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3057 (union specbinding): Rename from struct specbinding. Redo layout
3058 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3059 which is not portable. With Sun C 5.12 32-bit sparc, the
3060 declaration causes nargs to be an unsigned bitfield, a behavior
3061 that the C standard allows; but Emacs wants nargs to be signed.
3062 The overall type is now a union of structures rather than a
3063 structure of union of structures, and the 'kind' member is now a
3064 bitfield, so that the overall type doesn't grow. All uses changed.
3065 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3066
0a4df6a5
PE
30672013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3068
ec6ecaad
PE
3069 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3070 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3071
0a4df6a5
PE
3072 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3073
7bfe8dbc
EZ
30742013-06-17 Eli Zaretskii <eliz@gnu.org>
3075
3076 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3077 unless we know that the window w's frame is a frame object.
3078 Another attempt at solving bug#14062 and bug#14630.
3079
708e05f6
LMI
30802013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3081
3082 * textprop.c (property_set_type): New enum.
3083 (add_properties): Allow appending/prepending text properties.
3084 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3085 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3086 add_text_properties_1.
3087 (Fadd_face_text_property): New function that calls
3088 add_text_properties_1.
3089
84575e67
PE
30902013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 Move functions from lisp.h to individual modules when possible.
3093 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3094 * alloc.c (XFLOAT_INIT, set_symbol_name):
3095 * buffer.c (CHECK_OVERLAY):
3096 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3097 (set_char_table_parent):
3098 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3099 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3100 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3101 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3102 (set_blv_valcell):
3103 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3104 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3105 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3106 (backtrace_args, backtrace_debug_on_exit):
3107 * floatfns.c (CHECK_FLOAT):
3108 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3109 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3110 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3111 (set_hash_index_slot):
3112 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3113 * marker.c (CHECK_MARKER):
3114 * textprop.c (CHECK_STRING_OR_BUFFER):
3115 * window.c (CHECK_WINDOW_CONFIGURATION):
3116 Move here from lisp.h, and make these functions static rather than
3117 extern inline.
3118 * buffer.c (Qoverlayp):
3119 * data.c (Qsubrp):
3120 * fns.c (Qhash_table_p):
3121 * window.c (Qwindow_configuration_p):
3122 Now static.
3123 * lisp.h: Remove the abovementioned defns and decls.
3124
44e18199 3125 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3126 In lisp.h, prefer functions to function-like macros, and
3127 constants to object-like macros, when either will do. This:
3128 . simplifies use, as there's no more need to worry about
3129 arguments' side effects being evaluated multiple times.
3130 . makes the code easier to debug on some platforms.
3131 However, when using gcc -O0, keep using function-like macros
3132 for a few critical operations, for performance reasons.
3133 This sort of thing isn't needed with gcc -Og, but -Og
3134 is a GCC 4.8 feature and isn't widely-enough available yet.
3135 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3136 Remove enum lsb_bits; no longer needed.
3137 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3138 * buffer.c (Qoverlap):
3139 * data.c (Qsubrp):
3140 * fns.c (Qhash_table_p):
3141 Now extern, so lisp.h can use these symbols.
3142 * dispextern.h: Include character.h, for MAX_CHAR etc.
3143 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3144 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3145 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3146 (GLYPH_CODE_P): Move here from lisp.h.
3147 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3148 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3149 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3150 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3151 XUNTAG now returns void *.
3152 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3153 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3154 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3155 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3156 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3157 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3158 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3159 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3160 New macros, renamed from their sans-lisp_h_ counterparts.
3161 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3162 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3163 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3164 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3165 If compiling via GCC without optimization, define these as macros
3166 in addition to inline functions.
3167 To disable this, compile with -DINLINING=0.
3168 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3169 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3170 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3171 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3172 (INTMASK, VALMASK): Now macros, since static values cannot be
3173 accessed from extern inline functions.
3174 (VALMASK): Also a constant, for benefit of old GDB.
3175 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3176 is INTEGERP, which can fold it in.
5165d44a 3177 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3178 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3179 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3180 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3181 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3182 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3183 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3184 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3185 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3186 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3187 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3188 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3189 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3190 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3191 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3192 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3193 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3194 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3195 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3196 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3197 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3198 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3199 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3200 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3201 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3202 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3203 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3204 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3205 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3206 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3207 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3208 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3209 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3210 Now functions.
3211 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3212 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3213 (VALMASK): Define in one place rather than in two, merging the
3214 USE_LSB_TAG parts; this is simpler.
3215 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3216 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3217 Move up, to avoid use before definition.
3218 Also include "globals.h" earlier, for the same reason.
3219 (make_natnum): New function.
3220 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3221 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3222 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3223 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3224 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3225 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3226 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3227 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3228 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3229 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3230 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3231 (Qwindow_configuration_p, Qimage): New forward declarations.
3232 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3233 (STRING_COPYIN): Remove; unused.
3234 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3235 (xcar_addr, xcdr_addr): New functions. All uses changed.
3236 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3237 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3238 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3239 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3240 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3241 (TYPE_RANGED_INTEGERP): Simplify.
3242 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3243 (setlocale, fixup_locale, synchronize_system_messages_locale)
3244 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3245 Now empty functions, not macros.
3246 (functionp): Return bool, not int.
3247 * window.c (Qwindow_configuration_p): Now extern,
3248 so window.h can use it.
3249 * window.h (Qwindowp): Move decl back to lisp.h.
3250
9583ec36
EZ
32512013-06-15 Eli Zaretskii <eliz@gnu.org>
3252
3253 * xdisp.c (Fline_pixel_height): New function, required for solving
3254 bug #14567.
3255
210272ce
PE
32562013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3259
de0503df
SM
32602013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3261
3262 * lread.c (syms_of_lread):
3263 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3264
afbfe143
KD
32652013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3266
3267 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3268
d177e213
XF
32692013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3270
3271 * fileio.c (expand_file_name): Doc fix.
3272
05e3e412
PE
32732013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3274
f7394b12
PE
3275 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3276 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3277 Wait for self, not for 0. This can't hurt on GNU or similar
3278 system, and may help with Cygwin.
3279
05e3e412
PE
3280 * keyboard.c: Don't use PROP (...) as an lvalue.
3281 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3282 Use set_prop (A, B), not PROP (A) = B.
3283
17dd3097
EZ
32842013-06-10 Eli Zaretskii <eliz@gnu.org>
3285
3286 * xdisp.c (get_it_property): Use it->window instead of generating
3287 a Lisp object from it->w.
3288
52fab9c9
EZ
32892013-06-09 Eli Zaretskii <eliz@gnu.org>
3290
3291 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3292 get-char-property the window that is being rendered, instead of
3293 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3294 (compute_display_string_pos): When W is NULL, use the current
3295 buffer as the object to pass to get-char-property.
3296 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3297 pointer member of the bidi iterator, since no window is pertinent
3298 to this function.
52fab9c9 3299
5bf97bfc
EZ
33002013-06-08 Eli Zaretskii <eliz@gnu.org>
3301
3302 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3303 being displayed, and pass it to compute_display_string_pos.
3304 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3305 (bidi_paragraph_init): All callers changed.
3306
3307 * xdisp.c (init_from_display_pos, init_iterator)
3308 (handle_single_display_spec, next_overlay_string)
3309 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3310 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3311 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3312 (compute_display_string_pos): Accept additional argument, the
3313 window being displayed, and pass it to Fget_char_property.
3314 (Bug#14575)
3315
3316 * dispextern.h (struct bidi_it): New member w, the window being
3317 displayed.
3318 (compute_display_string_pos): Adjust prototype.
3319
5de0e011
JD
33202013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3321
e7b41c4c 3322 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3323
3324 * process.c (wait_reading_process_output): Check for NS before GLIB.
3325 GLIB may be linked in due to rsvg, but ns_select must be called.
3326
5de0e011
JD
3327 * xgselect.c (xg_select): Remove call to window_system_available
3328 and g_main_context_pending at the top, so Gdk events (i.e. file
3329 notify) are processed when Emacs is started with -nw.
3330
a822acff
EZ
33312013-06-07 Eli Zaretskii <eliz@gnu.org>
3332
3333 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3334 (ctagsfiles3): New variable, includes only *.m files.
3335 (TAGS): Use an explicit language name in the regular expressions,
3336 to avoid transformation of '/SOMETHING' by MSYS to
3337 'c:\MSYS\SOMETHING'.
3338
6c0a9ed1
RC
33392013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3340
3341 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3342
9ef6111b
EZ
33432013-06-06 Eli Zaretskii <eliz@gnu.org>
3344
3345 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3346 still need to set the mouse pointer shape and activate help-echo.
3347 (Bug#14558)
3348
7d300d64
PE
33492013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 A few porting etc. fixes for the new file monitor code.
3352 See the thread containing
3353 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3354 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3355 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3356 (dir_monitor_callback, Fgfile_rm_watch):
3357 Use assq_no_quit instead of Fassoc, for speed.
3358 (dir_monitor_callback, Fgfile_rm_watch):
3359 eassert that the monitor is a fixnum.
3360 (dir_monitor_callback): No need for CDR_SAFE.
3361 Simplify building of lisp with alternative tails.
3362 (Fgfile_add_watch, Fgfile_rm_watch):
3363 Do not assume glib functions set errno reliably on failure.
3364 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3365 and signal an error otherwise.
3366 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3367 Use Fdelq instead of Fdelete, for speed.
3368
817ebfcf
EZ
33692013-06-05 Eli Zaretskii <eliz@gnu.org>
3370
3371 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3372 don't insist on being invoked on a highlighted tool-bar button.
3373 Avoids losing tool-bar functionality when mouse-highlight is nil.
3374 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3375 Don't highlight when mouse-highlight is nil.
3376 (note_mouse_highlight): When mouse-highlight is nil, don't return
3377 right away; instead, run tool-bar and mode-line highlight
3378 subroutine, clear any existing highlight, and revert the mouse
3379 pointer to its default shape. (Bug#14558)
3380
55577e7c
SM
33812013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3382
3383 * lisp.mk (lisp): Add prog-mode.el.
3384
f019a684
PE
33852013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3386
3387 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3388 * process.c (dummy_handler): New function.
3389 (lib_child_handler): New static var.
3390 (handle_child_signal): Invoke it.
3391 (catch_child_signal): If a library has set up a signal handler,
3392 save it into lib_child_handler.
3393 (init_process_emacs): If using glib and not on Windows, tickle glib's
3394 child-handling code so that it initializes its private SIGCHLD handler.
3395 * syssignal.h (SA_SIGINFO): Default to 0.
3396 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3397 31; it should no longer be needed now.
3398
90db8702
MA
33992013-06-05 Michael Albinus <michael.albinus@gmx.de>
3400
3401 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3402
3403 * gfilenotify.c (globals_of_gfilenotify): New function.
3404 (syms_of_gfilenotify): Move global initialization there.
3405
3406 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3407
bfa3acd6
SM
34082013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3409
3410 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3411 * keyboard.c (menu_bar_items, tool_bar_items):
3412 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3413 not override local keymaps any more.
3414
ba59bd80
EZ
34152013-06-04 Eli Zaretskii <eliz@gnu.org>
3416
3417 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3418
7f203aa1
EZ
34192013-06-03 Eli Zaretskii <eliz@gnu.org>
3420
9337e206
EZ
3421 * w32console.c (initialize_w32_display): Return the dimensions of
3422 the console window via 2 additional arguments, not via the current
3423 frame. This avoids crashes due to overrunning the bounds of
3424 frame's decode_mode_spec_buffer, which is not resized following
3425 the change of the frame dimensions from the initial 10x10.
3426
3427 * w32term.h (w32_initialize_display_info): Adjust prototype.
3428
3429 * term.c (init_tty): Take dimensions of the frame from the values
3430 returned by initialize_w32_display.
3431
7f203aa1
EZ
3432 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3433 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3434 (LIBES): Add $(GFILENOTIFY_LIBS).
3435
3436 * w32inevt.c (handle_file_notifications): Add dummy implementation
3437 for !HAVE_W32NOTIFY.
3438
3439 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3440
55a87246
JD
34412013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3442
3443 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3444
3445 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3446
3447 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3448
3d5ee10a
PE
34492013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3450
3451 Fix minor problems found by static checking.
3452 * data.c (pure_write_error):
3453 Use xsignal2, not Fsignal, as Fsignal might return.
3454 * eval.c (set_backtrace_debug_on_exit): Now static.
3455 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3456 No longer inline. EXTERN_INLINE is needed only for functions
3457 defined in .h files. Reindent function header as per GNU style.
3458 (backtrace_p, backtrace_top, backtrace_next):
3459 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3460 compiler or linker. Add extern decls to pacify gcc -Wall.
3461 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3462 Now static.
3463 * frame.c (free_monitors): Define only on platforms that need it.
3464 * nsterm.m (ns_term_init):
3465 * process.c (catch_child_signal):
3466 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3467 defined on all porting targets these days.
3468 * process.c, process.h (catch_child_signal):
3469 Make it extern only if NS_IMPL_GNUSTEP is defined.
3470
e2d8a6f0
EZ
34712013-06-03 Eli Zaretskii <eliz@gnu.org>
3472
3473 * w32.c (gettimeofday): Make the signature identical to prototype
3474 in nt/inc/sys/time.h.
3475
a8a7c5f6
SM
34762013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3477
3478 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3479 .gdbinit.
3480
3481 * keyboard.c (safe_run_hooks_error): Improve error message.
3482
3483 * data.c (pure_write_error): Add `object' argument.
3484 * puresize.h (CHECK_IMPURE): Use it.
3485
c9628c79
MA
34862013-06-03 Michael Albinus <michael.albinus@gmx.de>
3487
3488 * Makefile.in (NOTIFY_OBJ): New variable.
3489 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3490
3491 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3492 Call syms_of_gfilenotify.
3493
3494 * gfilenotify.c: New file.
3495
3496 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3497 and Qfile_w32notify.
3498 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3499 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3500
3501 * lisp.h: Declare syms_of_gfilenotify.
3502
3503 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3504
2f592f95
SM
35052013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3506
3507 Merge the specpdl and backtrace stacks. Make the structure of the
3508 specpdl entries more obvious via a tagged union of structs.
3509 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3510 (enum specbind_tag): New enum.
3511 (struct specbinding): Make it a tagged union of structs.
3512 Add a case for backtrace records.
3513 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3514 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3515 (backtrace_debug_on_exit): New accessors.
3516 (struct backtrace): Remove.
3517 (struct catchtag): Remove backlist field.
3518 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3519 Move to eval.c.
3520 (Flocal_variable_p): Speed up the common case where the binding is
3521 already loaded.
3522 * eval.c (backtrace_list): Remove.
3523 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3524 (set_backtrace_args, set_backtrace_nargs)
3525 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3526 (backtrace_next): New functions.
3527 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3528 (unwind_to_catch, internal_lisp_condition_case)
3529 (internal_condition_case, internal_condition_case_1)
3530 (internal_condition_case_2, internal_condition_case_n): Don't bother
3531 with backtrace_list any more.
3532 (Fsignal): Adjust to new backtrace format.
3533 (grow_specpdl): Move up.
3534 (record_in_backtrace): New function.
3535 (eval_sub, Ffuncall): Use it.
3536 (apply_lambda): Adjust to new backtrace format.
3537 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3538 data.c.
3539 (specbind): Adjust to new specpdl format. Simplify.
3540 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3541 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3542 backtrace format.
3543 (mark_backtrace): Remove.
3544 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3545 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3546 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3547 Use mark_specpdl.
3548 * profiler.c (record_backtrace): Use get_backtrace.
3549 (handle_profiler_signal): Use backtrace_top_function.
3550 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3551 accessor functions.
3552
c0342369
JD
35532013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3554
3555 * process.h (catch_child_signal): Declare.
3556
3557 * process.c (catch_child_signal): New function.
3558 (init_process_emacs): Call it.
3559
3560 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3561 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3562 NS_IMPL_COCOA.
3563 (x_set_cursor_type): Remove declaration.
3564 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3565 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3566 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3567 (ns_get_color): Use F suffix on float.
3568 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3569 (ns_get_rgb_color): Remove.
3570 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3571 (note_mouse_movement): x and y are CGFloat.
3572 (ns_draw_fringe_bitmap): Remove unused rowY.
3573 Change #if to COCOA && >= 10_6.
3574 (ns_draw_window_cursor): Remove unused overspill.
3575 (ns_draw_underwave): width and x are EamcsCGFloat.
3576 (ns_draw_box): thickness is CGFloat.
3577 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3578 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3579 if not in main thread.
3580 (ns_get_pending_menu_title, ns_check_menu_open)
3581 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3582 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3583 (sendFromMainThread:): New method.
3584 (changeFont:): size is CGFloat.
3585 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3586 Disable warning about permanent text.
3587 (characterIndexForPoint:): Adjust return type depending on GNUStep
3588 version.
3589 (mouseDown:): delta is CGFloat.
3590 (updateFrameSize): Remove unised variable f.
3591 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3592 Cast float to EmacsCGFloat.
3593 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3594 also to -1 when restoring.
3595 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3596 inside NS_IMPL_COCOA.
3597 (toggleFullScreen:): Put call to toggleFullScreen inside
3598 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3599 (setPosition:portion:whole:): por is CGFloat.
3600 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3601 (mouseDown:): Use CGFloat.
3602 (mouseDragged:): Remove unised variable edge.
3603 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3604
3605 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3606 of CGFloat differs.
3607 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3608 when NS_IMPL_GNUSTEP.
3609 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3610 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3611 (EmacsToolbar): Add clearAll. Add tag argument to
3612 addDisplayItemWithImage.
3613 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3614
3615 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3616
3617 * nsmenu.m (ns_update_menubar): Make static.
3618 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3619 (fillWithWidgetValue:): Add cast to SEL for setAction.
3620 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3621 (update_frame_tool_bar): Update code for GNUStep.
3622 (clearAll): New method.
3623 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3624 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3625 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3626 call to insertItemWithItemIdentifier.
3627 (validateVisibleItems): Fix indentation.
3628 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3629 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3630 UtilityWindow to aStyle, remove call to setStyleMask.
3631
3632 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3633
3634 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3635 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3636 Use F suffix on floats.
3637 (ns_char_width): Returns CGFloat.
3638 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3639 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3640 DPSxshow.
3641 (ns_glyph_metrics): CGFloat instead of float.
3642
a0eb10b3
JB
3643 * nsfns.m (x_set_foreground_color, x_set_background_color):
3644 Use EmacsCGFloat.
3645 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3646 remove unused variables.
3647 (Fns_read_file_name): Keep track if panel is for save.
3648 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3649 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3650 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3651 Just return the input if GNUStep.
c0342369
JD
3652 (x_screen_planes): Remove.
3653 (Fxw_color_values): Use EmacsCGFloat
3654 (Fns_display_monitor_attributes_list): Only get screen number for
3655 Cocoa.
ef099a94 3656 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3657 EmacsSavePanel.
3658 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3659 ns_directory_from_panel.
3660
da9aff11
PE
36612013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 * process.c (handle_child_signal): Also use WCONTINUED.
3664 This is so that list-processes doesn't mistakenly list the process
3665 as stopped, when the process has actually been continued and is
3666 now running.
3667
0e64479a
PE
36682013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3669
fc186a96
PE
3670 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3671 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3672 not already configured.
3673
0e64479a
PE
3674 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3675
38b787fa
EZ
36762013-05-29 Eli Zaretskii <eliz@gnu.org>
3677
3678 * Makefile.in (mostlyclean): Remove *.res files.
3679
22513e52
SM
36802013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3681
3682 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3683 a buffer (bug#8447).
3684
6ef3db10
EZ
36852013-05-27 Eli Zaretskii <eliz@gnu.org>
3686
3687 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3688 display vector, and we backtrack, handle the case that the
3689 previous character position is also displayed from a display
3690 vector or covered by a display string or image. (Bug#14476)
3691
6799bb26
JD
36922013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3693
3694 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3695 (struct MonitorInfo, free_monitors): Remove.
3696 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3697 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3698 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3699 Qframes, Qsource.
3700
3701 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3702 (struct MonitorInfo, free_monitors): Remove.
3703 (ns_screen_name): Make static.
3704 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3705 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3706 Qframes, Qsource.
3707
3708 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3709 (struct MonitorInfo): New struct.
3710 (free_monitors, make_monitor_attribute_list): Declare.
3711
22513e52
SM
3712 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3713 New Lisp_Object:s.
6799bb26
JD
3714 (free_monitors, make_monitor_attribute_list): New functions.
3715 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3716 Qsource.
3717
38cd43eb
XF
37182013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3719
3720 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3721
2af0948d
SM
37222013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3723
a7eb9b0f
SM
3724 * keyboard.c: Apply keyboard decoding only to events that come directly
3725 from the tty, not from unread-command-events (bug#14368).
3726 (read_event_from_main_queue): New function, extracted from read_char).
3727 (read_decoded_char): Remove.
3728 (read_decoded_event_from_main_queue): New function to replace it.
3729 (read_char): Use it.
3730 (read_key_sequence): Use read_char rather than read_decoded_char.
3731
2af0948d
SM
3732 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3733
1413e9a5
BR
37342013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3735
3736 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3737
e6d2f155
KH
37382013-05-22 Kenichi Handa <handa@gnu.org>
3739
3740 The following changes are to fix the setting of
3741 buffer-file-coding-system on, for instance, C-x RET c unix RET
3742 _FILE_OF_DOS_EOL_TYPE_ RET.
3743
3744 * coding.h (struct coding_system): New member detected_utf8_chars.
3745
3746 * coding.c (detect_coding_utf_8): Count characters and check EOL
3747 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3748 BOM is there.
3749 (setup_coding_system): Do not initialize coding->head_ascii.
3750 (check_ascii): Do not set coding->eol_seen but update it. Do not
3751 call adjust_coding_eol_type here.
1413e9a5
BR
3752 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3753 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3754 of the found coding-system.
3755 (decode_coding_gap): Cancel previous change. Utilize the
3756 character numbers counted by detect_coding_utf_8. Fix detection
3757 of BOM for utf-8.
3758
ab56a6f4 37592013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3760
3761 * search.c (looking_at_1): Only set last_thing_searched if the match
3762 changed the match-data (bug#14281).
3763
ecc3c6ed
DA
37642013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3765
3766 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3767 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3768 (move_it_vertically_backward): Likewise.
3769
5ba8bf35
YM
37702013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3771
3772 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3773 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3774 (Fx_display_mm_width, Fx_display_mm_height):
3775 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3776
91e8418b 3777 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3778 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3779 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3780 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3781 (Fx_display_backing_store, Fx_display_visual_class)
3782 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3783 (Fx_display_grayscale_p, Fx_display_pixel_width)
3784 (Fx_display_pixel_height, Fx_display_planes)
3785 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3786 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3787 (Fx_display_mm_width, Fx_display_mm_height)
3788 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3789 height for all physical monitors as in X11.
3790
fc30d803
SM
3791 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3792 Return pixel width or height for all physical monitors as in X11.
91e8418b 3793
31ff141c
PE
37942013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3795
3796 Port --enable-gcc-warnings to clang.
3797 * bytecode.c (exec_byte_code):
3798 * regex.c:
3799 Redo diagnostic pragmas to pacify clang, too.
3800 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3801 * editfns.c (Fencode_time):
3802 * fileio.c (file_accessible_directory_p):
3803 * font.c (font_unparse_xlfd):
3804 Use '&"string"[index]' instead of '"string" + (index)'.
3805 * undo.c (user_error): Remove; unused.
3806
df065a0b
EZ
38072013-05-16 Eli Zaretskii <eliz@gnu.org>
3808
04d360e7
EZ
3809 * insdel.c (insert_1_both): Document the arguments, instead of
3810 referring to insert_1, which no longer exists.
3811
5bb98290
EZ
3812 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3813 some window, increment windows_or_buffers_changed, so that
3814 *Messages* display in that window is updated. (Bug#14408)
3815
df065a0b
EZ
3816 * w32.c: Include epaths.h.
3817 (init_environment): Use cmdproxy.exe without leading directories.
3818 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3819 case.
3820 (gettimeofday): Adjust signature and return value to Posix
3821 expectations.
3822
3823 * unexw32.c (open_output_file): Delete the existing emacs.exe
3824 before creating it, to break the hard link to the versioned
3825 executable.
3826
3827 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3828 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3829 (FIRSTFILE_OBJ): New variables.
3830 (W32_RES): Rename to EMACSRES. All users changed.
3831 (base_obj): Use $(CM_OBJ).
3832 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3833 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3834 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3835 $(W32_RES_LINK) before $(LIBES).
3836 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3837
1aa8d505
SM
38382013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3839
6e911150
SM
3840 * makefile.w32-in (DOC): Use just "DOC".
3841
3842 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3843
1aa8d505
SM
3844 * process.c: Export default filters and sentinels to Elisp.
3845 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3846 New constants.
3847 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3848 (Fset_process_sentinel, Fformat_network_address):
3849 Default to them instead of nil.
3850 (server_accept_connection): Sentinels can't be nil any more.
3851 (read_and_dispose_of_process_output): New function, extracted from
3852 read_process_output.
3853 (read_process_output): Use it; filters can't be nil.
3854 (Finternal_default_process_filter): New function, extracted from
3855 read_process_output.
3856 (exec_sentinel_unwind): Remove function.
3857 (exec_sentinel): Don't zilch sentinel while running.
3858 (status_notify): Sentinels can't be nil.
3859 (Finternal_default_process_sentinel): New function extracted from
3860 status_notify.
3861 (setup_process_coding_systems): Default filter is not nil any more.
3862 (syms_of_process): Export new Elisp functions and initialize
3863 new constants.
3864 * lisp.h (make_lisp_proc): New function.
3865
5ac2eb34
SM
38662013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3867
3868 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3869
eda9c7d7
EZ
38702013-05-14 Eli Zaretskii <eliz@gnu.org>
3871
3872 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3873 unless we know that the window w is a leaf window.
3874 Another attempt at solving bug#14062.
eda9c7d7 3875
8fdeaad5
JD
38762013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3877
3878 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3879 fdesc (Bug#14375).
3880
44aa9ee6
PE
38812013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 * image.c (gif_load): Check that subimages fit (Bug#14345).
3884
759fd763
SM
38852013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3886
3887 * lread.c (skip_dyn_eof): New function.
3888 (read1): Use it to skip the end of a file in response to #@00.
3889
3890 * doc.c (get_doc_string): Slightly relax the sanity checking.
3891
4465bfb4
JD
38922013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3893
3894 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3895 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3896 (MonitorInfo): New struct.
3897 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3898 (Fns_display_monitor_attributes_list): New functions.
3899 (display-usable-bounds): Remove.
3900 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3901 Qsource.
3902
7583e2a0
PE
39032013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3906 (GTK_CHECK_VERSION): New macro, if not already defined.
3907 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3908 replaced by GTK_CHECK_VERSION.
3909
ad75d77e
PE
39102013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3911
3912 * xterm.h (GTK_PREREQ): New macro.
3913 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3914 to use this macro instead, for consistency and clarity.
3915
07525f77
EZ
39162013-05-08 Eli Zaretskii <eliz@gnu.org>
3917
3918 * xdisp.c (row_for_charpos_p): New function, with code of
3919 cursor_row_p, but accepts an additional argument CHARPOS instead
3920 of using a hardcoded PT.
3921 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3922 (row_containing_pos): Call row_for_charpos_p instead of partially
3923 doing the same. Fixes cursor positioning under longlines-mode
3924 when longlines-show-effect includes more than one newline, when
3925 moving the cursor vertically up.
3926
d901fc8d
JB
39272013-05-08 Juanma Barranquero <lekktu@gmail.com>
3928
3929 * makefile.w32-in (ACL_H): New macro.
3930 ($(BLD)/fileio.$(O)): Update dependencies.
3931
f269bc61
PE
39322013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3933
e7b41c4c 3934 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3935 * Makefile.in (LIB_ACL): New macro.
3936 (LIBACL_LIBS): Remove.
3937 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3938 * fileio.c: Include <acl.h>.
3939 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3940 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3941 !acl_errno_valid.
3942 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3943 it ourselves.
3944
f269bc61
PE
3945 * unexelf.c: Don't assume ElfW (Half) fits in int.
3946 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3947 when dealing with ElfW (Half) values, since they can exceed 2**31
3948 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3949 (entry_address): Omit unused NUM arg. All uses changed.
3950
a261c53e
JL
39512013-05-07 Juri Linkov <juri@jurta.org>
3952
3953 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3954 to the string converted from number with `Fnumber_to_string'.
3955 (Bug#14254)
3956
2b66427d
PE
39572013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3960 This fixes a problem introduced by my previous change.
3961
15acfe41
GM
39622013-05-07 Glenn Morris <rgm@gnu.org>
3963
3964 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3965
5ea03bf5
JD
39662013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3967
3968 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3969
e0c9d565
PE
39702013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3971
3972 Static checking by GCC 4.8.0.
3973 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3974 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3975 (x_get_monitor_attributes_fallback)
3976 (x_get_monitor_attributes_xinerama)
3977 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3978 Define only if USE_GTK.
3979 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3980 (x_get_monitor_attributes_fallback): Omit unused locals.
3981 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3982 Use double, not float, to avoid mixed-mode floating point arithmetic.
3983
4e3f9230
YM
39842013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3985 Jan Djärv <jan.h.d@swipnet.se>
3986
3987 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3988 (XINERAMA_CFLAGS): New macros.
3989 (ALL_CFLAGS, LIBES): Use them.
3990
3991 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3992 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3993 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3994 (syms_of_xfns): DEFSYM them.
3995 (struct MonitorInfo): New struct.
3996 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3997 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3998 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3999 (x_get_monitor_attributes_xinerama): New functions.
4000 (Fx_display_monitor_attributes_list): New primitive.
4001 (syms_of_xfns): Defsubr it.
4002
4003 * xterm.h (x_display_info): Add Xatom_net_workarea and
4004 Xatom_net_current_desktop.
4005
4006 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4007 and dpyinfo->Xatom_net_current_desktop.
4008
05839b6a
EZ
40092013-05-06 Eli Zaretskii <eliz@gnu.org>
4010
4011 * xdisp.c (pos_visible_p): Use the special code for finding the
4012 beginning of a display property or overlay for any "replacing"
4013 display property, not just for display strings. This solves
4014 incorrect reporting of position by posn-at-point. (Bug#14241)
4015
dc4a2ee0
PE
40162013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4017
5ee94506
PE
4018 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4019 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4020 Verify that ElfW (Half) fits in int.
4021 (fatal): Use same signature as lisp.h.
4022 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4023 configure and build with -DUNEXELF_DEBUG without worrying about
4024 other modules that use DEBUG.
4025 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4026 possibly-wide integers now uses it instead of plain fprintf.
4027 (entry_address): New function, which avoids problems with 32-bit
4028 overflow on 64-bit hosts.
4029 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4030 (round_up): Don't assume the remainder fits in int.
4031 (find_section): Use bool for boolean. Simplify debug code.
4032 (unexec): Don't assume file sizes fit in int or size_t.
4033 Omit unnecessary trailing newline in 'fatal' format.
4034 Use strerror rather than outputting decimal error number.
4035 Remove unused code when emacs is not defined;
4036 this file relies on Emacs now.
4037 Don't assume e_phnum and e_shnum are positive.
4038
dc4a2ee0
PE
4039 * regex.c: Fix problems when DEBUG is defined.
4040 (extract_number, extract_number_and_incr): Define regardless of
4041 whether DEBUG is defined; that's simpler and makes the code less
4042 likely to go stale in the normal case when DEBUG is not defined.
4043 Return int rather than taking an int * arg. All callers changed.
4044 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4045 Remove, replacing with ...
4046 (DEBUG_PRINT): New macro. All callers changed.
4047 (DEBUG_COMPILES_ARGUMENTS): New macro.
4048 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4049 (print_compiled_pattern, print_double_string) [DEBUG]:
4050 Use prototype rather than old-style definition.
4051 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4052 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4053 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4054 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4055 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4056 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4057 This matters only when DEBUG is defined.
4058
14c7ed05
EZ
40592013-05-05 Eli Zaretskii <eliz@gnu.org>
4060
4061 * xdisp.c (set_iterator_to_next): Set the
4062 ignore_overlay_strings_at_pos_p flag only if we are _really_
4063 iterating over an overlay string, as indicated by the
4064 current.overlay_string_index member. (Bug#14306)
4065
e6076b1b
JD
40662013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4067
4068 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4069 to where it is used, to avoid autorelease issues (Bug#14050).
4070
cbee2131
PE
40712013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4072
4073 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4074 * fileio.c (syms_of_fileio): Implement this.
4075 * filelock.c (create_lock_file): If symbolic links don't work, so
4076 we use a regular file as a lock file, do not fsync the lock file;
4077 it's not needed.
4078
30c7e542
SM
40792013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4080
4081 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4082 (syms_of_minibuf): Adjust accodingly.
4083 * lread.c (Fread):
4084 * callint.c (Fcall_interactively): Adjust calls accordingly.
4085
5bebd186
EZ
40862013-05-04 Eli Zaretskii <eliz@gnu.org>
4087
4088 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4089 w->contents is a buffer before computing everything else.
4090 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4091
4092 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4093 assertion violations. (Bug#14062)
4094
0fb0a4f3
DR
40952013-05-01 David Reitter <david.reitter@gmail.com>
4096
4097 * nsfns.m (ns_tooltip): Initialize.
4098
9e63b4a5
EZ
40992013-04-28 Eli Zaretskii <eliz@gnu.org>
4100
4101 * coding.c (decode_coding_gap): Don't remove the character before
4102 a newline unless it's a CR character. (Bug#14287)
4103
ad60824e
DN
41042013-04-28 Dan Nicolaescu <dann@gnu.org>
4105
4106 * dispextern.h (struct face): Move enum face_underline_type
4107 earlier so that bitfields can be in the same word.
4108
edbdcec0
JD
41092013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4110
4111 * nsfns.m (handlePanelKeys): New function.
4112 (EmacsOpenPanel:performKeyEquivalent:)
4113 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4114 arrows/function/control and copy/paste keys (Bug#14296).
4115
0208ede7
JL
41162013-04-27 Juri Linkov <juri@jurta.org>
4117
4118 * callint.c (Fcall_interactively): Call `Qread_number' for
4119 interactive code letter `n' instead of using duplicate code.
4120 (Bug#14254)
4121
b8dd59f7
PE
41222013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4123
4124 * systime.h (make_timeval): Declare as 'const'.
4125
8bd722db
KH
41262013-04-27 Kenichi Handa <handa@gnu.org>
4127
4128 * font.c (font_open_entity): Always open a font of manageable
4129 size.
4130
13d0e56f 41312013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4132
f780d632
PE
4133 Port better to AIX (Bug#14258).
4134 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4135 to pacify AIX xlc.
4136
ec509856
KH
41372013-04-24 Kenichi Handa <handa@gnu.org>
4138
4139 * coding.c (decode_coding_iso_2022): When an invalid escape
4140 sequence is encountered, reset the invocation and designation
4141 status to the safest one.
4142
84fc48e5
PE
41432013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4146 Without this fix, "make distclean" leaves stamp-h1 behind.
4147
806bda47
EC
41482013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4149
4150 * w32fns.c (w32_fullscreen_rect): New function to compute the
4151 window rectangle for the given fullscreen mode.
4152 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4153 longer tunes the window size. This keeps the window's edges flush
4154 with the screen and allows the taskbar to hide itself in fullboth.
4155
4156 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4157 window decorations and uses the entire screen.
4158
4159 * w32term.h (w32_fullscreen_rect) Add prototype.
4160 (struct w32_output): Replace normal_width, normal_height,
4161 normal_top, and normal_left members with a single normal_placement
4162 struct.
4163 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4164 Remove macros.
4165 (FRAME_NORMAL_PLACEMENT): New macro.
4166
9cc2810b
JB
41672013-04-16 Juanma Barranquero <lekktu@gmail.com>
4168
4169 * minibuf.c (Ftest_completion): Silence compiler warning.
4170
fd16b54c
EZ
41712013-04-15 Eli Zaretskii <eliz@gnu.org>
4172
4173 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4174 bug#14062.
fd16b54c
EZ
4175
4176 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4177 parentheses.
4178
4179 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4180 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4181 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4182 parentheses where appropriate.
4183
9e3379a0
PE
41842013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4185
4186 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4187
ddd6b685
EZ
41882013-04-14 Eli Zaretskii <eliz@gnu.org>
4189
4190 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4191 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4192 Mention in the doc string that setting these variables takes
4193 effect only after a call to set-window-buffer. (Bug#14200)
4194
29b79ba1
EZ
41952013-04-13 Eli Zaretskii <eliz@gnu.org>
4196
4197 * indent.c (Fvertical_motion): Don't consider display strings on
4198 overlay strings as display strings on the buffer position we
4199 started from. This prevents vertical cursor motion from jumping
4200 more than one line when there's an overlay string with a display
4201 property at end of line.
4202 Reported by Karl Chen <Karl.Chen@quarl.org> in
4203 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4204
562c6ee9
SM
42052013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4206
4207 * window.c (select_window): `record_buffer' even if window is
4208 already selected (bug#14191).
4209
fcc1fe85
EZ
42102013-04-11 Eli Zaretskii <eliz@gnu.org>
4211
4212 * window.c (Fwindow_end): Test more flags, including the buffer's
4213 last_overlay_modified flag, to determine whether the window's
4214 display is really up-to-date. Prevents the function from
4215 returning a stale value. (Bug#14170)
4216 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4217 current matrix.
4218
f009190a
EZ
42192013-04-10 Eli Zaretskii <eliz@gnu.org>
4220
4221 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4222 garbaged only if it is not already the top frame on its TTY.
4223 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4224 there are GUI frames open in the same session. (Bug#13864)
4225
78ce603d
SM
42262013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4227
4228 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4229 of marking the idle timers directly.
4230
a8036e40
SM
42312013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4232
4233 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4234 tables (bug#14054).
4235
7ffe7ef6
SM
42362013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4237
4238 * window.c (select_window): Don't record_buffer while the invariant is
4239 temporarily broken (bug#14161).
4240
4241 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4242
7d9f6883
EZ
42432013-04-07 Eli Zaretskii <eliz@gnu.org>
4244
4245 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4246
5406cfd9
RF
42472013-04-07 Romain Francoise <romain@orebokech.com>
4248
4249 Ignore additional platform-specific ACL errors (Bug#13702).
4250 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4251 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4252
95c0e83b
JD
42532013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4254
4255 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4256 f->output_data.ns.
4257
876da980
PE
42582013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4261 This bug was introduced by my 2013-02-25 change that simplified
4262 data_start configuration. Without this change, on GNU/Linux
4263 an Emacs configured with --enable-profiling fails immediately
4264 due to a profiler signal.
4265 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4266 with these flags. On platforms where special flags are needed
4267 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4268 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4269 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4270
7452b7bd
DA
42712013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4272
4273 Get rid of some platform-specific functions examining window
4274 system and its capabilities. This is a partial rework of the
4275 2013-04-05 change.
4276 * lisp.h (have_menus_p): Remove prototype. This function is
4277 replaced with platform-independent window_system_available.
4278 (check_window_system): Move to...
4279 * frame.h (decode_window_system_frame, window_system_available):
4280 ...here, add new prototypes.
4281 * frame.c (window_system_available, decode_window_system_frame):
4282 New functions.
4283 (check_window_system): Platform-independent now.
4284 * xterm.h (x_in_use): Remove declaration.
4285 (check_x_frame):
4286 * w32term.h (check_x_frame):
4287 * nsterm.h (check_x_frame): Remove prototypes. This function
4288 is replaced with platform-independent decode_window_system_frame.
4289 * msdos.c (have_menus_p): Remove.
4290 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4291 Remove platform-specific functions. Use check_window_system,
4292 decode_window_system_frame and check_ns_display_info where
4293 appropriate. Minor style and comment tweaks.
4294 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4295 (check_x_frame): Likewise.
4296 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4297 Likewise.
4298 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4299 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4300 * xmenu.c, xselect.c: All related users changed.
4301
251e9147
KH
43022013-04-03 Kenichi Handa <handa@gnu.org>
4303
4304 The following changes is to optimize the code for reading UTF-8
4305 files.
4306
562c6ee9 4307 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4308 changed. Check EOL format. Do not call adjust_coding_eol_type
4309 here.
4310 (check_utf_8): New function.
4311 (adjust_coding_eol_type): Do nothing if already adjusted.
4312 (detect_coding): Compare the return value of check_ascii with
4313 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4314 (decode_coding_gap): Optimize for valid UTF-8.
4315
8bc369d4
KH
43162013-03-21 Kenichi Handa <handa@gnu.org>
4317
4318 * coding.c (syms_of_coding): Cancel previous change.
4319
4320 * insdel.c (insert_from_gap): Fix previous change.
4321
73931ad1
DA
43222013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4323
4324 Consistently use platform-specific function to detect window system.
4325 * lisp.h (check_window_system): New prototype. This function is
4326 going to replace check_x, check_w32 and check_ns.
4327 (have_menus_p): Mention msdos.c in comment.
4328 * fontset.c (check_window_system_func): Remove. Adjust all users.
4329 * fontset.h (check_window_system_func): Remove prototype.
4330 * nsterm.h (check_ns):
4331 * xterm.h (check_x):
4332 * w32term.h (check_w32): Likewise.
4333 * menu.c (Fx_popup_menu): Use check_window_system.
4334 * msdos.c (check_window_system): Define for MS-DOS.
4335 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4336 * w32fns.c (check_window_system): Likewise for MS-Windows.
4337 * xfns.c (check_window_system): Likewise for X.
4338 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4339 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4340
7216e43b
PE
43412013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4342
4343 Prefer < to > in range checks such as 0 <= i && i < N.
4344 This makes it easier to visualize quantities on a number line.
4345 This patch doesn't apply to all such range checks,
4346 only to the range checks affected by the 2013-03-24 change.
4347 This patch reverts most of the 2013-03-24 change.
4348 * alloc.c (xpalloc, Fgarbage_collect):
4349 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4350 * character.c (string_escape_byte8):
4351 * charset.c (read_hex):
4352 * data.c (cons_to_unsigned):
4353 * dispnew.c (update_frame_1):
4354 * doc.c (Fsubstitute_command_keys):
4355 * doprnt.c (doprnt):
4356 * editfns.c (hi_time, decode_time_components):
4357 * fileio.c (file_offset):
4358 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4359 * font.c (font_intern_prop):
4360 * frame.c (x_set_alpha):
4361 * gtkutil.c (get_utf8_string):
4362 * indent.c (check_display_width):
4363 * keymap.c (Fkey_description):
4364 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4365 * lread.c (read1):
4366 * minibuf.c (read_minibuf_noninteractive):
4367 * process.c (wait_reading_process_output):
4368 * search.c (Freplace_match):
4369 * window.c (get_phys_cursor_glyph):
4370 * xdisp.c (redisplay_internal):
4371 * xsmfns.c (smc_save_yourself_CB):
4372 Prefer < to > for range checks.
4373 * dispnew.c (sit_for): Don't mishandle NaNs.
4374 This fixes a bug introduced in the 2013-03-24 change.
4375 * editfns.c (decode_time_components): Don't hoist comparison.
4376 This fixes another bug introduced in the 2013-03-24 change.
4377
92759988
DA
43782013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4379
4380 * frame.h (struct frame): Drop scroll_bottom_vpos
4381 member becaue all real users are dead long ago.
4382 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4383 * xdisp.c (redisplay_internal): Adjust user.
4384
9a1971bb
GM
43852013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4386
f38ab167
JD
4387 * nsmenu.m (showAtX:Y:for:): setLevel to
4388 NSPopUpMenuWindowLevel (Bug#13998).
4389
6d01f1fe
JD
43902013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4391
4392 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4393 (ns_check_pending_open_menu): Declare.
4394
4395 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4396 (x_activate_menubar): Update the menu with title that matches
4397 ns_get_pending_menu_title, and call
4398 ns_check_pending_openmenu (Bug#12698).
4399 (menuWillOpen:): New method.
4400 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4401
4402 * nsterm.m (menu_will_open_state, menu_mouse_point)
4403 (menu_pending_title): New varaibles.
4404 (ns_get_pending_menu_title, ns_check_menu_open)
4405 (ns_check_pending_open_menu): New functions.
4406
781f4782
DA
44072013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4408
4409 * indent.c (current_column_bol_cache): Remove leftover which is not
4410 used in Fmove_to_column any more.
4411 (current_column, scan_for_column): Adjust users.
4412 * keyboard.c (last_point_position_buffer, last_point_position_window):
4413 Remove leftovers which are not used for recording undo any more.
4414 (command_loop_1, syms_of_keyboard): Adjust users.
4415 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4416 redisplay_window any more.
4417 (move_it_to): Adjust user.
4418
1921c31b
JB
44192013-03-29 Juanma Barranquero <lekktu@gmail.com>
4420
4421 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4422 Update dependencies.
4423
717b8bcd
SM
44242013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4425
4426 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4427 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4428 forward references.
4429
e74aeda8
DA
44302013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4431
4432 * window.h (struct window): Replace hchild, vchild and buffer slots
4433 with the only contents slot. This is possible because each valid
4434 window may have either the child window (in vertical or horizontal
4435 combination) or buffer to display (for the leaf window). Using that,
4436 a lof of operations to traverse and/or change window hierarchies may
4437 be simplified. New member horizontal is used to distinguish between
4438 horizontal and vertical combinations of internal windows.
4439 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4440 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4441 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4442 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4443 Use contents slot, not buffer, where appropriate.
4444 (wset_combination): New function.
4445 (wset_buffer): Add eassert.
4446 (Fframe_first_window): Simplify the loop reaching first window.
4447 (Fwindow_buffer): Use WINDOW_LEAF_P.
4448 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4449 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4450 (unshow_buffer): Convert initial debugging check to eassert.
4451 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4452 (make_parent_window, window_resize_check, window_resize_apply)
4453 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4454 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4455 Adjust to match struct window changes.
4456 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4457 (mark_window_cursors_off, count_windows, get_leaf_windows)
4458 (foreach_window_1): Simplify the loop.
4459 * alloc.c (mark_object): Do not check for the leaf window because
4460 internal windows has no glyph matrices anyway.
4461 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4462 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4463 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4464 (build_frame_matrix_from_window_tree, mirror_make_current)
4465 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4466 (update_window_tree, set_window_update_flags): Simplify the loop.
4467 (sync_window_with_frame_matrix_rows): Enforce live window.
4468 Use contents slot, not buffer, where appropriate.
4469 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4470 and WINDOW_HORIZONTAL_COMBINATION_P.
4471 (make_frame_visible_1): Simplify the loop.
4472 Use contents slot, not buffer, where appropriate.
4473 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4474 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4475 (expose_window_tree): Likewise.
4476 Use contents slot, not buffer, where appropriate.
4477 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4478 to avoid deleted windows. Use contents slot instead of buffer.
4479 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4480 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4481 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4482 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4483
121ab1cd
EZ
44842013-03-28 Eli Zaretskii <eliz@gnu.org>
4485
ef454cf7
EZ
4486 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4487 identify the reasons for assertion violations in bug#14062 and
4488 similar ones.
21e930f8
EZ
4489 (Fx_show_tip): Fix compilation error under
4490 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4491
121ab1cd
EZ
4492 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4493 Reported by <rzl24ozi@gmail.com>.
4494
5c89ca24
DA
44952013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4496
4497 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4498 start marker...
562c6ee9
SM
4499 (unwind_with_echo_area_buffer): ...to restore it here.
4500 This is needed to ensure that...
5c89ca24
DA
4501 (redisplay_window): ...both window markers are valid here,
4502 which is verified by eassert.
4503 * editfns.c (save_excursion_save): Do not assume that
4504 selected_window always displays the buffer.
c7f53895
DA
4505 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4506 Fix comment.
5c89ca24 4507
f557c1b1
SM
45082013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4509
4510 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4511 the upcase table.
4512
40693bba 45132013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4514
4515 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4516
c86f791f
EZ
45172013-03-27 Eli Zaretskii <eliz@gnu.org>
4518
4519 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4520 since MinGW's w32api headers do. This avoids compiler warnings.
4521
4522 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4523 if already defined.
4524
c6e72e17
EZ
45252013-03-26 Eli Zaretskii <eliz@gnu.org>
4526
4527 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4528
54e95010
JD
45292013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4530
4531 * gtkutil.c (style_changed_cb): Check if frame is live and an
4532 X frame (Bug#14038).
4533
b88b62de
EZ
45342013-03-26 Eli Zaretskii <eliz@gnu.org>
4535
a18d7de6
EZ
4536 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4537 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4538 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4539 MinGW64.
8f5e14c8
EZ
4540 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4541 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4542
b88b62de
EZ
4543 Fix incompatibilities between MinGW.org and MinGW64 headers.
4544 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4545
4546 * w32.c (REPARSE_DATA_BUFFER): Guard with
4547 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4548
c074e458
JD
45492013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4550
4551 * xterm.c: Include X11/XKBlib.h
4552 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4553
908589fd
AS
45542013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4555
4556 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4557 written backwards.
4558 * blockinput.h (input_blocked_p): Likewise.
4559 * bytecode.c (exec_byte_code): Likewise.
4560 * callproc.c (call_process_kill, call_process_cleanup)
4561 (Fcall_process): Likewise.
4562 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4563 (Fccl_execute_on_string): Likewise.
4564 * character.c (string_escape_byte8): Likewise.
4565 * charset.c (read_hex): Likewise.
4566 * cm.c (calccost): Likewise.
4567 * data.c (cons_to_unsigned): Likewise.
4568 * dired.c (directory_files_internal, file_name_completion):
4569 Likewise.
4570 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4571 (sit_for): Likewise.
4572 * doc.c (Fsubstitute_command_keys): Likewise.
4573 * doprnt.c (doprnt): Likewise.
4574 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4575 * emacsgtkfixed.c: Likewise.
4576 * fileio.c (file_offset, Fwrite_region): Likewise.
4577 * floatfns.c (Fexpt, fmod_float): Likewise.
4578 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4579 Likewise.
4580 * font.c (font_intern_prop): Likewise.
4581 * frame.c (x_set_alpha): Likewise.
4582 * gtkutil.c (get_utf8_string): Likewise.
4583 * indent.c (check_display_width): Likewise.
4584 * intervals.c (create_root_interval, rotate_right, rotate_left)
4585 (split_interval_right, split_interval_left)
4586 (adjust_intervals_for_insertion, delete_node)
4587 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4588 (merge_interval_right, merge_interval_left, copy_intervals)
4589 (set_intervals_multibyte_1): Likewise.
4590 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4591 * keymap.c (Fkey_description): Likewise.
4592 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4593 * lread.c (openp, read_integer, read1, string_to_number):
4594 Likewise.
4595 * menu.c (ensure_menu_items): Likewise.
4596 * minibuf.c (read_minibuf_noninteractive): Likewise.
4597 * print.c (printchar, strout): Likewise.
4598 * process.c (create_process, Faccept_process_output)
4599 (wait_reading_process_output, read_process_output, send_process)
4600 (wait_reading_process_output): Likewise.
4601 * profiler.c (make_log, handle_profiler_signal): Likewise.
4602 * regex.c (re_exec): Likewise.
4603 * regex.h: Likewise.
4604 * search.c (looking_at_1, Freplace_match): Likewise.
4605 * sysdep.c (get_child_status, procfs_ttyname)
4606 (procfs_get_total_memory): Likewise.
4607 * systime.h (EMACS_TIME_VALID_P): Likewise.
4608 * term.c (dissociate_if_controlling_tty): Likewise.
4609 * window.c (get_phys_cursor_glyph): Likewise.
4610 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4611 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4612 Likewise.
4613 * xfns.c (Fx_window_property): Likewise.
4614 * xmenu.c (set_frame_menubar): Likewise.
4615 * xselect.c (x_get_window_property, x_handle_dnd_message):
4616 Likewise.
4617 * xsmfns.c (smc_save_yourself_CB): Likewise.
4618 * xterm.c (x_scroll_bar_set_handle): Likewise.
4619
2bf7d27a
DA
46202013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4621
4622 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4623 to be optional or nil. Adjust comment and convert it to docstring.
4624 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4625 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4626
a9ebfa0b
PE
46272013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4628
4629 Static checking by GCC 4.8-20130319.
4630 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4631 * process.c (Fset_process_datagram_address)
4632 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4633 * xdisp.c (get_char_face_and_encoding):
4634 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4635 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4636 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4637
4f3576ee
KB
46382013-03-24 Ken Brown <kbrown@cornell.edu>
4639
789b5e9a
KB
4640 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4641 fix compilation on 64-bit Cygwin, where underscores are not
4642 automatically prepended.
4643
4f3576ee
KB
4644 * w32term.c (w32_initialize): Silence compiler warning.
4645
b5b7745f
EZ
46462013-03-23 Eli Zaretskii <eliz@gnu.org>
4647
cdc0d0bd
EZ
4648 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4649 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4650 variables, to save and restore frame dimensions.
4651 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4652 after returning from a 'fullscreen' configuration.
4653 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4654 to avoid races between the main thread and the input thread.
4655
4656 * w32term.h (struct w32_output): New members normal_width,
4657 normal_height, normal_top, normal_left, and prev_fsmode.
4658 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4659 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4660 members of a frame.
4661
b5b7745f
EZ
4662 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4663 'fullscreen' parameter. Always record previous width and height
4664 of the frame, except when switching out of maximized modes, so
4665 that they could be restored correctly, instead of resetting to the
4666 default frame dimensions. Send SC_RESTORE command to the frame,
4667 unless we are going to send SC_MAXIMIZE, to restore the frame
4668 resize hints in the mouse pointer shown by the window manager.
4669 (Bug#14032)
4670
4671 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4672
4673 * lisp.h (get_frame_param): Adjust conditions for prototype
4674 declaration.
4675
a3454eed
KB
46762013-03-22 Ken Brown <kbrown@cornell.edu>
4677
4678 * unexcw.c: Drop unneeded inclusion of w32common.h.
4679 (report_sheap_usage): Declare.
4680 (read_exe_header): Add magic numbers for x86_64.
4681 (fixup_executable): Fix printf format specifier for unsigned long
4682 argument.
4683
5a49b79c
DA
46842013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4685
4686 * frame.h (struct frame): Put menu_bar_window under #ifdef
4687 because this member is not needed when X toolkit is in use.
4688 (fset_menu_bar_window):
4689 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4690 (free_glyphs, update_frame):
4691 * xdisp.c (expose_frame): Likewise.
4692 (display_menu_bar): Likewise. Remove redundant eassert.
4693 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4694 toolkit is in use.
4695
d6723bf7
PE
46962013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4697
7b1123d8
PE
4698 Use functions and constants to manipulate Lisp_Save_Value objects.
4699 This replaces code that used macros and strings and token-pasting.
4700 The change makes the C source a bit easier to follow,
4701 and shrinks the Emacs executable a bit.
4702 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4703 (make_save_value): Change 1st arg from string to enum. All callers
4704 changed.
4705 (INTX): Remove.
4706 (mark_object): Use if, not #if, for GC_MARK_STACK.
4707 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4708 (XSAVE_OBJECT): Now functions, not macros.
4709 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4710 the constant was never used.
4711 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4712 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4713 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4714 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4715 New constants.
4716 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4717 type3 with a single member save_type. All uses changed.
4718 (save_type, set_save_pointer, set_save_integer): New functions.
4719 * print.c (PRINTX): Remove.
4720
d6723bf7
PE
4721 * alloc.c: Remove redundant static declarations.
4722
5f24fa51
DA
47232013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4724
4725 * window.h (struct window): Convert left_col, top_line, total_lines
4726 and total_cols from Lisp_Objects to integers. Adjust comments.
4727 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4728 Remove.
4729 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4730 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4731 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4732 Adjust users where appropriate.
4733
42143acd
DA
47342013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4735
4736 * frame.h (struct frame): Drop resx and resy because the same data is
4737 available from window system-specific output context. Adjust users.
562c6ee9
SM
4738 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4739 New functions to provide defaults when no window system available.
42143acd 4740 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4741 (NUMVAL): Move from xdisp.c.
42143acd
DA
4742 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4743 (Ffont_face_attributes, Fopen_font):
4744 * image.c (gs_load):
4745 * w32font.c (fill_in_logfont):
4746 * xdisp.c (calc_pixel_width_or_height):
4747 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4748 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4749
c0a17406
KH
47502013-03-20 Kenichi Handa <handa@gnu.org>
4751
4752 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4753 to 1 (temporary workaround until a bug related to ASCII
4754 optimization is fixed).
4755
095d384d
DA
47562013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4757
4758 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4759 Signal error if window is not internal. Adjust docstring.
4760 (delete_all_child_windows): Use combination_limit to save the buffer.
4761 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4762 * print.c (syms_of_print): Initialize debugging output not here...
4763 (init_print_once): ...but in a new function here.
4764 * lisp.h (init_print_once): Add prototype.
4765 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4766
748fa866
DA
47672013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4768
4769 * window.c (window_resize_check, window_resize_apply)
4770 (window_from_coordinates, recombine_windows, set_window_buffer)
4771 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4772 (Fsplit_window_internal, Fdelete_window_internal)
4773 (freeze_window_starts): Use bool for booleans.
4774 * window.h (window_frame_coordinates, resize_frame_windows)
4775 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4776
81519fd2
SM
47772013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4778
4779 * dispnew.c (bitch_at_user): Use `user-error'.
4780
6db423a9
KB
47812013-03-17 Ken Brown <kbrown@cornell.edu>
4782
4783 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4784 as return type of image_background. (Bug#13981)
4785 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4786
8f2906f5
JD
47872013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4788
960ce480 4789 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4790 (ns_select): Don't return with result uninitialized.
960ce480 4791
8f2906f5
JD
4792 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4793 and getDirectory.
4794
81519fd2
SM
4795 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4796 New functions.
8f2906f5
JD
4797 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4798 directories. If filename is nil, get directory name (Bug#13932).
4799 Use getFilename and getDirectory.
4800 (getFilename, getDirectory): New methods for EmacsSavePanel and
4801 EmacsOpenPanel.
4802 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4803
cded56c1
PE
48042013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4805
4806 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4807
251e9147 48082013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4809
4810 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4811 (adjust_after_replace): Make it back to static. Delete the third
4812 arg text_at_gap_tail. Cancel the code for handling it.
4813
4814 * coding.h (struct coding_system): New member eol_seen.
4815
4816 * coding.c (detect_ascii): New function.
4817 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4818 when the source bytes are actually scanned. On detecting for
4819 coding_category_utf_8_auto, call detect_ascii instead of scanning
4820 source bytes directly.
4821 (produce_chars): Call insert_from_gap with the new arg 0.
4822 (encode_coding): Likewise.
4823 (decode_coding_gap): Control ASCII optimization by the variable
4824 disable_ascii_optimization instead of #ifndef .. #endif.
4825 Deccode EOL format according to coding->eol_seen.
4826 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4827 variable.
4828
8a44e6d1
KH
4829 * lisp.h (adjust_after_replace): Cancel externing it.
4830 (insert_from_gap): Adjust prototype.
4831
5f795e34
EZ
48322013-03-15 Eli Zaretskii <eliz@gnu.org>
4833
4834 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4835 FULLSCREEN_MAXIMIZED. (Bug#13935)
4836
f258b4be
DA
48372013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4838
4839 * region-cache.c (find_cache_boundary, move_cache_gap)
4840 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4841 Simplify debugging check and convert to eassert. Adjust comment.
4842 (pp_cache): Put under ENABLE_CHECKING.
4843
a5cc4dde
EZ
48442013-03-14 Eli Zaretskii <eliz@gnu.org>
4845
4846 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4847 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4848 and WM_ACTIVATEAPP.
4849 (w32fullscreen_hook): If the frame is visible, reset
4850 f->want_fullscreen flag after changing the frame size. If the
4851 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4852 (Bug#13953)
4853
3fc5e44a
DC
48542013-03-13 Daniel Colascione <dancol@dancol.org>
4855
4856 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4857 too so that these builds can use Cygwin's file conversion
4858 functions. (We've been building and linking cygw32.o all along
4859 and just not using it.)
4860
47d7532e
PE
48612013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4862
4863 File synchronization fixes (Bug#13944).
4864 * Makefile.in (LIB_FDATASYNC): New macro.
4865 (LIBES): Use it.
4866 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4867 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4868 Don't worry about HAVE_FSYNC, since a substitute fsync is
4869 available if the system lacks one.
4870 (Fwrite_regin): Retry fsync if interrupted.
4871
c7ffccaf
EZ
48722013-03-13 Eli Zaretskii <eliz@gnu.org>
4873
4e2df81d 4874 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4875 activated, call w32fullscreen_hook, to make sure the new frame
4876 dimensions are in effect. (Bug#13937)
4877
8a7debc1
DA
48782013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4879
4880 * xdisp.c (init_iterator): Simplify because both character and byte
4881 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4882 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4883 character and byte positions can be obtained from marker.
8a7debc1 4884
7fd8c501
PE
48852013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4886
d9df6f40
PE
4887 Static checking by Sun C 5.12.
4888 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4889 * bytecode.c (exec_byte_code):
4890 * dispnew.c (init_display):
4891 * eval.c (error):
4892 * fileio.c (Fsubstitute_in_file_name):
4893 * keyboard.c (Fevent_convert_list):
4894 * keymap.c (Fsingle_key_description):
4895 * term.c (maybe_fatal, fatal):
4896 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4897 * xsmfns.c (Fhandle_save_session):
4898 Omit unreachable code.
4899 * keymap.c (map_keymap_char_table_item): Cast void * to
4900 a function pointer type; the C Standard requires this.
4901
7fd8c501
PE
4902 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4903 Include <sys/param.h> unconditionally, as that works elsewhere and
4904 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4905 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4906 and FreeBSD now.
4907
a020afb9 4908See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4909
4910;; Local Variables:
4911;; coding: utf-8
aac0c6e3
MR
4912;; End:
4913
ab422c4d 4914 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4915
4916 This file is part of GNU Emacs.
4917
4918 GNU Emacs is free software: you can redistribute it and/or modify
4919 it under the terms of the GNU General Public License as published by
4920 the Free Software Foundation, either version 3 of the License, or
4921 (at your option) any later version.
4922
4923 GNU Emacs is distributed in the hope that it will be useful,
4924 but WITHOUT ANY WARRANTY; without even the implied warranty of
4925 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4926 GNU General Public License for more details.
4927
4928 You should have received a copy of the GNU General Public License
4929 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.